* composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f10fe38f
PE
12012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2
de1339b0
PE
3 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
4 * composite.c (find_composition, composition_gstring_p)
5 (composition_reseat_it, find_automatic_composition):
6 * data.c (let_shadows_buffer_binding_p)
7 (let_shadows_global_binding_p, set_internal, make_blv)
8 (Fmake_variable_buffer_local, Fmake_local_variable)
9 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
10 (cons_to_signed, arith_driver):
11 * dbusbind.c (xd_in_read_queued_messages):
12 * dired.c (directory_files_internal, file_name_completion):
13 Use bool for booleans.
14 * dired.c (file_name_completion):
15 * process.h (fd_callback):
16 Omit int (actually boolean) argument. It wasn't being used.
17 All uses changed.
18 * composite.h, lisp.h: Reflect above API changes.
19
f10fe38f
PE
20 * cmds.c, coding.c: Use bool for booleans.
21 * cmds.c (move_point, Fself_insert_command):
22 * coding.h (struct composition status, struct coding_system):
23 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
24 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
25 (emacs_mule_char, decode_coding_emacs_mule)
26 (encode_coding_emacs_mule, detect_coding_iso_2022)
27 (decode_coding_iso_2022, encode_invocation_designation)
28 (encode_designation_at_bol, encode_coding_iso_2022)
29 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
30 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
31 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
32 (encode_coding_raw_text, detect_coding_charset)
33 (decode_coding_charset, encode_coding_charset, detect_eol)
34 (detect_coding, get_translation_table, produce_chars)
35 (consume_chars, reused_workbuf_in_use)
36 (make_conversion_work_buffer, code_conversion_save)
37 (decode_coding_object, encode_coding_object)
38 (detect_coding_system, char_encodable_p)
39 (Funencodable_char_position, code_convert_region)
40 (code_convert_string, code_convert_string_norecord)
41 (Fset_coding_system_priority):
42 * fileio.c (Finsert_file_contents):
43 Use bool for booleans.
44 * coding.h, lisp.h: Reflect above API changes.
45 * coding.c: Remove unnecessary static function decls.
46 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
47 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
48 not a boolean 'int', since callers never look at the return value.
49 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
50 * coding.h (decoding_buffer_size, encoding_buffer_size)
51 (emacs_mule_string_char): Remove unused extern decls.
52 (struct iso_2022_spec, struct coding_system):
53 Use 'unsigned int : 1' for boolean fields, since there's more than one.
54 (struct emacs_mule_spec): Remove unused field 'full_support'.
55 All initializations removed.
56 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
57
5474c384
DA
582012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
59
f10fe38f 60 Fix spare memory change (Bug#12286).
5474c384
DA
61 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
62 (valid_lisp_object_p): Likewise.
63
c4b6914d
MR
642012-08-27 Martin Rudalics <rudalics@gmx.at>
65
66 * window.c (Fset_window_configuration): Record any window's old
67 buffer if it's replaced (see Bug#8789). If the new current
68 buffer doesn't appear in the selected window, go to its old
69 point (Bug#12208).
70
35aaa1ea
DA
712012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
72
73 Special MEM_TYPE_SPARE to denote reserved memory.
74 * alloc.c (enum mem_type): New memory type.
75 (refill_memory_reserve): Use new type for spare memory.
76 This prevents live_cons_p and live_string_p from incorrect
77 detection of uninitialized objects from spare memory as live.
78
6af64513
PE
792012-08-26 Paul Eggert <eggert@cs.ucla.edu>
80
8b2e00a3
PE
81 Spelling fixes.
82 * Makefile.in (.PHONY): versioclean -> versionclean.
83
b52d6985
PE
84 Remove unused external symbols.
85 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
86 * window.c (Qwindow_valid_p, decode_valid_window):
87 Now static, not extern.
88 * data.c (Qinterval): Remove; unused.
89 (syms_of_data): Do not define 'interval'.
90 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
91 * window.h (decode_valid_window):
92 Remove decls.
93
d5172d4f
PE
94 * character.c, charset.c, chartab.c: Use bool for booleans.
95 * character.c (lisp_string_width, string_count_byte8)
96 (string_escape_byte8):
97 * charset.c (charset_map_loaded, load_charset_map, read_hex):
98 (load_charset_map_from_file, map_charset_chars)
99 (Fdefine_charset_internal, define_charset_internal)
100 (Fdeclare_equiv_charset, find_charsets_in_text)
101 (Ffind_charset_region, char_charset, Fiso_charset):
102 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
103 (sub_char_table_set, sub_char_table_set_range)
104 (char_table_set_range, optimize_sub_char_table)
105 (map_sub_char_table):
106 Use bool for boolean.
107 * character.c (str_to_unibyte): Omit last boolean argument; it was
108 always 0. All callers changed.
109 * character.h, charset.h: Adjust to match previous changes.
110 * character.h (char_printable_p): Remove decl of nonexistent function.
111 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
112 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
113 are all boolean, so make them single-bit bitfields.
114
6af64513
PE
115 * lisp.h (ASET): Remove attempt to detect side effects.
116 It was meant to be temporary and it often doesn't work,
117 because when IDX has side effects the behavior of IDX==IDX
118 is undefined. See Stefan Monnier in
119 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
120
e1f29348
BR
1212012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
122
123 * lisp.h (functionp): New function (extracted from Ffunctionp).
124 (FUNCTIONP): Use it.
125 * eval.c (Ffunctionp): Use it.
126
17c05d74
PE
1272012-08-25 Paul Eggert <eggert@cs.ucla.edu>
128
0f46bc75
PE
129 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
130 as that's faster and simpler than static storage. Don't bother
131 with the g_main_context_query overhead if g_main_context_pending
132 says no events are pending.
133 (gfds, gfds_size): Remove these static vars.
134 (xgselect_initialize): Remove; no longer needed.
135 All uses and decls removed.
136
ee4c0f69
PE
137 * emacs.c (fatal_error_signal_hook): Remove.
138 All uses removed. This leftover from old code was always 0.
139
17c05d74
PE
140 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
141 * casefiddle.c (casify_object, casify_region):
142 * casetab.c (set_case_table):
143 * category.c, category.h (word_boundary_p):
144 * category.h (CHAR_HAS_CATEGORY):
145 Use bool for booleans, instead of int.
146
391ceac5
EZ
1472012-08-25 Eli Zaretskii <eliz@gnu.org>
148
149 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
150
2f221583
PE
1512012-08-25 Paul Eggert <eggert@cs.ucla.edu>
152
f4a681b0
PE
153 On assertion failure, print backtrace if available.
154 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
155 (die) [ENABLE_CHECKING]: Print a backtrace if available.
156 * Makefile.in (LIB_EXECINFO): New macro.
157 (LIBES): Use it.
158
2f221583
PE
159 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
160 * bytecode.c (exec_byte_code):
161 * callint.c (check_mark, Fcall_interactively):
162 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
163 (getenv_internal, sync_process_alive, call_process_exited):
164 * lisp.h (USE_SAFE_ALLOCA):
165 Use bool for booleans, instead of int.
166 * lisp.h, process.h: Adjust prototypes to match above changes.
167 * callint.c (Fcall_interactively): Don't assume the mark's
168 offset fits in 'int'.
169
37ef52bb
PE
1702012-08-24 Paul Eggert <eggert@cs.ucla.edu>
171
172 * buffer.c, buffer.h: Use bool for boolean.
173 * buffer.c (reset_buffer_local_variables)
174 (buffer_lisp_local_variables, Fset_buffer_modified_p)
175 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
176 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
177 (overlay_touches_p, overlay_strings, Foverlay_put)
178 (report_overlay_modification, call_overlay_mod_hooks):
179 (mmap_enlarge, mmap_set_vars):
180 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
181 Use bool for booleans, instead of int.
182 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
183 since the 1-or-0 return value is always ignored anyway.
184 (mmap_initialized_p):
185 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
186 * buffer.h, lisp.h: Adjust prototypes to match above changes.
187
2cc21167
PE
1882012-08-23 Paul Eggert <eggert@cs.ucla.edu>
189
190 * bidi.c: Use bool for boolean.
191 This is a bit more readable, and makes the text segment of bidi.o
192 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
193 Presumably it's faster too.
194 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
195 Now bool.
196 (bidi_cache_find_level_change, bidi_cache_iterator_state)
197 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
198 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
199 (bidi_explicit_dir_char, bidi_level_of_next_char)
200 (bidi_find_other_level_edge, bidi_move_to_visually_next):
201 Use bool for booleans, instead of int.
202 * dispextern.h (bidi_init_it, bidi_paragraph_init)
203 (bidi_unshelve_cache): Adjust decls to match code.
204
7db4ddf4
MR
2052012-08-23 Martin Rudalics <rudalics@gmx.at>
206
207 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
208 argument.
209
b1bb8011
PE
2102012-08-23 Paul Eggert <eggert@cs.ucla.edu>
211
212 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
213 * atimer.h: Include <stdbool.h>.
214
ff687885
DN
2152012-08-22 Dan Nicolaescu <dann@gnu.org>
216
217 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
218 compile time tests instead of run time tests on systems that do
219 not use them.
220 (FRAME_MAC_P): Remove leftover from deleted code.
221 * frame.c (syms_of_frame): Remove leftover from deleted code.
222
4ce7a138
JD
2232012-08-22 Jan Djärv <jan.h.d@swipnet.se>
224
225 * nsterm.m (insertText:): Don't clear modifiers if code is space.
226
d733ec6d
PE
2272012-08-22 Paul Eggert <eggert@cs.ucla.edu>
228
229 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
230 Otherwise, the compiler complains about (A?B:C) where B is void
231 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
232 (fontset_add): Return void, for FONTSET_ADD.
233
d0d2d26f
PE
2342012-08-21 Paul Eggert <eggert@cs.ucla.edu>
235
fce31d69
PE
236 * alloc.c: Use bool for booleans.
237 (gc_in_progress, abort_on_gc)
238 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
239 (dont_register_blocks) [GC_MALLOC_CHECK]:
240 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
241 (check_string_bytes, make_specified_string, memory_full)
242 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
243 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
244 (mark_stack, valid_pointer_p, make_pure_string)
245 (Fgarbage_collect, survives_gc_p, gc_sweep):
246 Use bool for booleans, instead of int.
247 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
248 Remove unused local.
249 * alloc.c (PURE_POINTER_P):
250 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
251 * editfns.c (Fformat):
252 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
253 (Fdo_auto_save):
254 * fns.c (sweep_weak_table):
255 * lisp.h (suppress_checking, push_message, survives_gc_p)
256 (make_pure_string, gc_in_progress, abort_on_gc):
257 * lread.c (readchar, read1):
258 * print.c (Fprin1_to_string):
259 * xdisp.c (push_message):
260 Use bool for booleans affected directly or indirectly by
261 alloc.c's changes.
262
d0d2d26f
PE
263 Make recently-introduced setters macros.
264 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
265 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
266 (set_fontset_default, set_fontset_fallback): Rename from their
267 upper-case counterparts, and make them functions rather than macros.
268 This is more consistent with the other recently-introduced setters.
269 These don't need to be inline, since they're local.
270
d18e2bb6
JD
2712012-08-21 Jan Djärv <jan.h.d@swipnet.se>
272
273 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
274 the loop (Bug#12247).
275
1b9d9d16
PE
2762012-08-21 Paul Eggert <eggert@cs.ucla.edu>
277
278 * lisp.h (vcopy): Use memcpy rather than our own loop.
279 This fixes a performance regression introduced by the recent
280 addition of vcopy. This means 'vcopy' will need to be modified
281 for a copying collector, but that's OK. Also, tighten the
282 checking in the assertion.
283
b2f09701
EZ
2842012-08-21 Eli Zaretskii <eliz@gnu.org>
285
286 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
287 components for RTL text (Bug#11860). Adjust X-OFFSET of each
288 non-base glyph for the width of the base character, according to
e1f29348
BR
289 what x_draw_composite_glyph_string_foreground expects.
290 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
291 expectations, to produce correct width of the composed character.
292 Reverse the sign of the DU offset produced by ScriptPlace.
293
9b994fed
PE
2942012-08-21 Paul Eggert <eggert@cs.ucla.edu>
295
296 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
297
086ca913
DA
2982012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
299
300 Avoid direct writes to contents member of struct Lisp_Vector.
301 * lisp.h (vcopy): New function to copy data into vector.
302 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
303 * fns.c (Ffillarray): Use ASET.
304 * keyboard.c (timer_check_2): Use AREF and ASET.
305 (append_tool_bar_item, Frecent_keys): Use vcopy.
306 * lread.c (read_vector): Use ASET.
307 * msdos.c (Frecent_doskeys): Use vcopy.
308 * xface.c (Finternal_copy_lisp_face): Use vcopy.
309 (Finternal_merge_in_global_face): Use ASET and vcopy.
310 * xfont.c (xfont_list_pattern): Likewise.
311
5481664a
MR
3122012-08-21 Martin Rudalics <rudalics@gmx.at>
313
314 * window.c (Fwindow_point): For the selected window always return
315 the position of its buffer's point.
316 (Fset_window_point): For the selected window always go in its
317 buffer to the specified position.
318
6d470bdd
DA
3192012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
320
321 Setter macros for fontsets.
322 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
323 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
324 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
325 Adjust users.
326
24564fe1
GM
3272012-08-20 Glenn Morris <rgm@gnu.org>
328
329 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
330 Don't assume that `ln -f' works.
331
0a05a035
EZ
3322012-08-20 Eli Zaretskii <eliz@gnu.org>
333
334 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
335 and later about non-assignments with no effect. See discussion at
336 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
337 details.
338
e46f2325
DA
3392012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
340
341 Inline setter functions for Lisp_Objects slots of struct specbinding.
342 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
343 Adjust users.
344
734fbd86
MR
3452012-08-20 Martin Rudalics <rudalics@gmx.at>
346
347 * window.c (select_window): Always make selected window's buffer
348 current.
349
f1a95992
DA
3502012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
351
352 Use AREF and ASET for docstrings of category tables.
353 * category.h (CATEGORY_DOCSTRING): Use AREF.
354 (SET_CATEGORY_DOCSTRING): Use ASET.
355 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
356
e83064be
DA
3572012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
358
359 Inline setter functions for hash table members.
360 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
361 (set_hash_hash, set_hash_index): Rename with _slot suffix.
362 (set_hash_key_and_value, set_hash_index, set_hash_next)
363 (set_hash_hash): New functions.
364 * charset.c, fns.c: Adjust users.
365
4ce60d2e
DA
3662012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
367
368 Inline getter and setter functions for per-buffer values.
369 * buffer.h (per_buffer_default, set_per_buffer_default)
370 (per_buffer_value, set_per_buffer_value): New functions.
371 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
372 * buffer.c, data.c: Adjust users.
373
c06c9690
JB
3742012-08-20 Juanma Barranquero <lekktu@gmail.com>
375
376 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
377
32bd4250
PE
3782012-08-19 Paul Eggert <eggert@cs.ucla.edu>
379
bad03192 380 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
381 as gnulib does this if the system doesn't.
382 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
383 Remove declaration. MS-Windows declares it on stdlib.h which is
384 included by conf_post.h.
b69a6d22
PE
385 * emacs.c (environ) [DOUG_LEA_MALLOC]:
386 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
387 * vm-limit.c: Include <unistd.h>, for 'environ'.
388
22d7feb2
PE
389 * unexaix.c, unexcoff.c: Include "mem-limits.h".
390 (start_of_data): Remove decl; mem-limits.h provides it.
391
32bd4250
PE
392 * xdisp.c (handle_invisible_prop): Make it a bit faster
393 and avoid a gcc -Wmaybe-uninitialized diagnostic.
394
450809af
CY
3952012-08-19 Chong Yidong <cyd@gnu.org>
396
397 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
398 ends (Bug#3874).
399
9e677988
AS
4002012-08-19 Andreas Schwab <schwab@linux-m68k.org>
401
6b1319ce
AS
402 * .gdbinit: Use call instead of set when calling a function in the
403 inferior.
404
9e677988
AS
405 * data.c (set_internal): Don't use set_blv_found.
406 (Fkill_local_variable): Likewise.
407
d7191076
AA
4082012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
409
410 * nsfont.m (ns_ascii_average_width): Ensure the string
411 ascii_printable is initialized with a null-terminated character
412 array. Otherwise, it can contain undesired extra characters.
413
e757f1c6
PE
4142012-08-18 Paul Eggert <eggert@cs.ucla.edu>
415
416 port new setting code to Sun C 5.8 2005/10/13
417 * chartab.c, lisp.h (char_table_set, char_table_set_range):
418 Return void, not Lisp_Object. Otherwise, the compiler
419 complains about (A?B:C) where B is void and C is Lisp_Object
420 when compiling CHAR_TABLE_SET, due to the recent change to
421 the API of sub_char_table_set_contents.
422
a999ce26
CY
4232012-08-18 Chong Yidong <cyd@gnu.org>
424
425 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
426 for the string case (Bug#3874).
427
3f22b86f
PE
4282012-08-18 Paul Eggert <eggert@cs.ucla.edu>
429
39eb03f1
PE
430 * buffer.h (BSET): Remove (Bug#12215).
431 Replace all uses with calls to new setter functions.
432 (bset_bidi_paragraph_direction, bset_case_canon_table)
433 (bset_case_eqv_table, bset_directory, bset_display_count)
434 (bset_display_time, bset_downcase_table)
435 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
436 (bset_last_selected_window, bset_local_var_alist)
437 (bset_mark_active, bset_point_before_scroll, bset_read_only)
438 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
439 (bset_width_table):
440 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
441 (bset_auto_fill_function, bset_auto_save_file_format)
442 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
443 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
444 (bset_cache_long_line_scans, bset_case_fold_search)
445 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
446 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
447 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
448 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
449 (bset_header_line_format, bset_indicate_buffer_boundaries)
450 (bset_indicate_empty_lines, bset_invisibility_spec)
451 (bset_left_fringe_width, bset_major_mode, bset_mark)
452 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
453 (bset_name, bset_overwrite_mode, bset_pt_marker)
454 (bset_right_fringe_width, bset_save_length)
455 (bset_scroll_bar_width, bset_scroll_down_aggressively)
456 (bset_scroll_up_aggressively, bset_selective_display)
457 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
458 (bset_word_wrap, bset_zv_marker):
459 * category.c (bset_category_table):
460 * syntax.c (bset_syntax_table):
461 New setter functions.
462
6a09a33b
PE
463 * process.h (PSET): Remove (Bug#12215).
464 Replace all uses with calls to new setter functions.
465 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
466 (PROCESS_INLINE): New macro.
467 (pset_childp): New setter function.
468 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
469 * process.c (PROCESS_INLINE):
470 Define to EXTERN_INLINE, so that the corresponding functions
471 are compiled into code.
472 (pset_buffer, pset_command, pset_decode_coding_system)
473 (pset_decoding_buf, pset_encode_coding_system)
474 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
475 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
476 (pset_type, pset_write_queue): New setter functions.
477
e8c17b81
PE
478 * window.h (WSET): Remove (Bug#12215).
479 Replace all uses with calls to new setter functions.
480 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
481 (WINDOW_INLINE): New macro.
482 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
483 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
484 (wset_total_lines, wset_vertical_scroll_bar)
485 (wset_window_end_pos, wset_window_end_valid)
486 (wset_window_end_vpos): New setter functions.
487 * window.c (WINDOW_INLINE):
488 Define to EXTERN_INLINE, so that the corresponding functions
489 are compiled into code.
490 (wset_combination_limit, wset_dedicated, wset_display_table)
491 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
492 (wset_new_normal, wset_new_total, wset_next_buffers)
493 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
494 (wset_prev_buffers, wset_right_fringe_width)
495 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
496 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
497 (wset_window_parameters):
498 * xdisp.c (wset_base_line_number, wset_base_line_pos)
499 (wset_column_number_displayed, wset_region_showing):
500 New setter functions.
501
3f22b86f
PE
502 * termhooks.h (TSET): Remove (Bug#12215).
503 Replace all uses with calls to new setter functions.
504 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
505 (TERMHOOKS_INLINE): New macro.
506 (tset_charset_list, tset_selection_alist): New setter functions.
507 * terminal.c (TERMHOOKS_INLINE):
508 Define to EXTERN_INLINE, so that the corresponding functions
509 are compiled into code.
510 (tset_param_alist): New setter function.
511
742af32f
PE
5122012-08-17 Paul Eggert <eggert@cs.ucla.edu>
513
15dbb4d6
PE
514 * keyboard.h (KSET): Remove (Bug#12215).
515 Replace all uses with calls to new setter functions.
516 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
517 (KEYBOARD_INLINE): New macro.
518 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
519 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
520 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
521 New setter functions.
522 * keyboard.c (KEYBOARD_INLINE):
523 Define to EXTERN_INLINE, so that the corresponding functions
524 are compiled into code.
525 (kset_echo_string, kset_kbd_queue)
526 (kset_keyboard_translate_table, kset_last_prefix_arg)
527 (kset_last_repeatable_command, kset_local_function_key_map)
528 (kset_overriding_terminal_local_map, kset_real_last_command)
529 (kset_system_key_syms): New setter functions.
530
f00af5b1
PE
531 * frame.h (FSET): Remove (Bug#12215).
532 Replace all uses with calls to new setter functions.
533 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
534 (FRAME_INLINE): New macro.
535 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
536 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
537 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
538 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
539 (fset_param_alist, fset_root_window, fset_scroll_bars)
540 (fset_selected_window, fset_title, fset_tool_bar_items)
541 (fset_tool_bar_position, fset_tool_bar_window): New functions.
542 * frame.c (FRAME_INLINE):
543 Define to EXTERN_INLINE, so that the corresponding functions
544 are compiled into code.
545 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
546
0c94c8d6
PE
547 A few more naming-convention fixes for getters and setters.
548 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
549 and rename from buffer_overlays_set_before.
550 (set_buffer_overlays_after): Move here from buffer.h, and rename
551 from buffer_overlays_set_after.
552 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
553 All uses changed.
554 (set_buffer_intervals): Rename from buffer_set_intervals.
555 * intervals.c (set_interval_object): Move here from intervals.h,
556 and rename from interval_set_object.
557 (set_interval_left): Move here from intervals.h, and rename from
558 interval_set_left.
559 (set_interval_right): Move here from intervals.h, and rename from
560 interval_set_right.
561 (copy_interval_parent): Move here from intervals.h, and rename from
562 interval_copy_parent.
563 * intervals.h (set_interval_parent): Rename from interval_set_parent.
564 (set_interval_plist): Rename from interval_set_plist.
565 Return void, not Lisp_Object, since no caller uses the result.
566 * lisp.h (string_intervals): Rename from string_get_intervals.
567 (set_string_intervals): Rename from string_set_intervals.
568
34dabdb7
PE
569 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
570 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 571 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
572 All uses changed. See the end of
573 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
574
742af32f
PE
575 * lisp.h (CSET): Remove (Bug#12215).
576 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
577 (set_char_table_purpose): New functions,
578 replacing CSET. All uses changed. For example, replace
579 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 580 "set_char_table_parent (char_table, parent);".
742af32f
PE
581 The old version was confusing because it used the same name
582 'parent' for two different things.
583
a04e2c62
DA
5842012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Functions to get and set Lisp_Object fields of buffer-local variables.
587 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
588 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
589 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
590 * data.c, eval.c, frame.c: Adjust users.
591
383dcbf9
CY
5922012-08-17 Chong Yidong <cyd@gnu.org>
593
594 * xfaces.c (merge_face_vectors): If the target font specfies a
595 font spec, make the font's attributes take precedence over
596 directly-specified attributes.
597 (merge_face_ref): Recognize :font.
598
44386687
DA
5992012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Do not use memcpy for copying intervals.
602 * intervals.c (reproduce_interval): New function.
603 (reproduce_tree, reproduce_tree_obj): Use it.
604 (reproduce_tree_obj): Remove prototype.
605
927c7216
PE
6062012-08-17 Paul Eggert <eggert@cs.ucla.edu>
607
608 * lisp.h (duration_to_sec_usec): Remove unused decl.
609
93044f7b
AA
6102012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
611
612 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
613 to an allocated instance of NSString, not to the class itself.
614
9851e4a5
JB
6152012-08-17 Juanma Barranquero <lekktu@gmail.com>
616
617 * makefile.w32-in (C_CTYPE_H): New macro.
618 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
619 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
620 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
621
620f13b0
PE
6222012-08-16 Paul Eggert <eggert@cs.ucla.edu>
623
624 Use ASCII tests for character types.
625 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
626 * xfns.c, xterm.c:
627 Don't include <ctype.h>; was not needed.
628 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
629 * sysdep.c, xfaces.c:
630 Include <c-ctype.h> instead of <ctype.h>.
631 * nsterm.m: Include <c-ctype.h>.
632 * charset.c (read_hex):
633 * doc.c (Fsnarf_documentation):
634 * fileio.c (IS_DRIVE) [WINDOWSNT]:
635 (DRIVE_LETTER) [DOS_NT]:
636 (Ffile_name_directory, Fexpand_file_name)
637 (Fsubstitute_in_file_name):
638 * font.c (font_parse_xlfd, font_parse_fcname):
639 * frame.c (x_set_font_backend):
640 * gtkutil.c (xg_get_font):
641 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
642 * nsimage.m (hexchar):
643 * nsterm.m (ns_xlfd_to_fontname):
644 * sysdep.c (system_process_attributes):
645 * xfaces.c (hash_string_case_insensitive):
646 Use C-locale tests instead of locale-specific tests for character
647 types, since we want the ASCII interpretation here, not the
648 interpretation suitable for whatever happens to be the current locale.
649
52162052
MR
6502012-08-16 Martin Rudalics <rudalics@gmx.at>
651
652 Consistently check windows for validity/liveness
653 (Bug#11984, Bug#12025, Bug#12026).
654 * lisp.h (CHECK_VALID_WINDOW): New macro.
655 * window.c (decode_window): Rename to decode_live_window.
656 (decode_valid_window, Fwindow_valid_p): New functions.
657 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
658 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
659 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
660 (Fwindow_prev_sibling, Fwindow_combination_limit)
661 (Fset_window_combination_limit, Fwindow_use_time)
662 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
663 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
664 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
665 (Fwindow_hscroll, Fset_window_hscroll)
666 (Fwindow_redisplay_end_trigger)
667 (Fset_window_redisplay_end_trigger, Fwindow_edges)
668 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
669 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
670 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
671 (Fwindow_end, Fset_window_point, Fset_window_start)
672 (Fpos_visible_in_window_p, Fwindow_line_height)
673 (Fwindow_dedicated_p, Fset_window_dedicated_p)
674 (Fwindow_prev_buffers, Fset_window_prev_buffers)
675 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
676 (Fset_window_parameter, Fwindow_display_table)
677 (Fset_window_display_table, Fdelete_other_windows_internal)
678 (Fset_window_buffer, Fset_window_new_total)
679 (Fset_window_new_normal, Fdelete_window_internal)
680 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
681 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
682 (Fwindow_scroll_bars): Check whether argument window is a valid or
683 live window. Update doc-strings.
684 (syms_of_window): New symbol Qwindow_valid_p.
685 * keyboard.c (Fposn_at_x_y): Check whether argument
686 frame_or_window denotes a valid window.
687
2751c80f
DA
6882012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
689
690 Fix previous char table change.
691 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
692 * chartab.c (optimize_sub_char_table): Likewise.
693
032a42c8
CY
6942012-08-16 Chong Yidong <cyd@gnu.org>
695
a2d19368
CY
696 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
697
032a42c8
CY
698 * xfont.c (xfont_open):
699 * xftfont.c (xftfont_open): Set the font's max_width field.
700
701 * nsfont.m (nsfont_open): Similar to the Xft backend, set
702 min_width to space_width and average_width to the average over
703 printable ASCII characters.
704 (ns_char_width): Code cleanup.
705 (ns_ascii_average_width): New utility function.
706
707 * font.h (struct font): Update comments.
708
a098c930
DA
7092012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
710
032a42c8 711 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
712 * lisp.h (CSET): New macro.
713 (char_table_set_extras, char_table_set_contents)
714 (sub_char_table_set_contents): New function.
715 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
716 * syntax.c: Adjust users.
717
8be3a09c
SM
7182012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
719
720 * eval.c (eval_sub): Bind lexical-binding.
721 * lread.c (Qlexical_binding): Make non-static.
722
ac4845a6
JD
7232012-08-15 Jan Djärv <jan.h.d@swipnet.se>
724
ddee6515
JD
725 * nsmenu.m (popupSession): Remove.
726 (pop_down_menu): Remove endModalSession.
727 (timeout_handler:): New method.
728 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
729 Call runModalForWindow. Check timer_fired when it returns.
730 If not set, cancel timer and break out of loop.
731 Otherwise loop again, with a new timeout.
732
733 * nsterm.m: Include fcntl.h if present.
734 (fd_entry, t_readfds, inNsSelect): Remove.
735 (select_writefds, select_valid, select_timeout, selfds)
736 (select_mutex, apploopnr): Add.
737 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
738 Otherwise call kbd_buffer_store_event.
739 (ns_send_appdefined): Remove release of fd_entry.
740 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
741 Increment and decrement apploopnr.
742 (ns_select): If no file descriptors, just do a NSTimer.
743 Otherwise copy read/write masks and start select thread (fd_handler).
744 Start main loop and wait for application defined event.
745 Inform select thread to stop selecting after main loop is exited.
746 (ns_term_init): Create selfds pipe and set non-blocking.
747 Initialize select_mutex. Start the select thread (fd_handler).
748 (fd_handler:): Loop forever, wait for info from the main thread
749 to either start or stop selecting. When select returns, send
750 and appdefined event.
751 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
752 If not call kbd_buffer_store_event.
753
754 * nsterm.h (EmacsApp): fd_handler takes id argument.
755 (EmacsDialogPanel): Add timer_fired and timeout_handler.
756
ac4845a6
JD
757 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
758
eb424fe3
EZ
7592012-08-15 Eli Zaretskii <eliz@gnu.org>
760
761 * region-cache.c (move_cache_gap): Update gap_len using the actual
762 growth of the boundaries array. Do not change cache_len.
763 (Bug#12196)
764
4e6a86c6
DA
7652012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
766
767 Generalize and cleanup font subsystem checks.
768 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
769 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
770 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 771
5bf192ca
DA
7722012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
773
774 * gtkutil.c (xg_get_font): Use pango_units_to_double.
775
f2045622
CY
7762012-08-15 Chong Yidong <cyd@gnu.org>
777
8be3a09c
SM
778 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
779 When using the new font chooser, use gtk_font_chooser_get_font_desc to
780 extract the font descriptor instead of just the font name.
781 In that case, return a font spec instead of a string.
f2045622
CY
782 (x_last_font_name): Move to this file from xfns.c.
783
784 * xfns.c (Fx_select_font): The return value can also be a font
785 spec. Move x_last_font_name management to gtkutil.c.
786
787 * xfaces.c: Make font weight and style symbols non-static.
788
7f6feb56
SM
7892012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
790
791 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
792 (bug#12117).
793
fecbd8ff
SM
7942012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
795
796 * alloc.c (Fgarbage_collect): Use plural form consistently.
797
9b8d5165
EZ
7982012-08-14 Eli Zaretskii <eliz@gnu.org>
799
800 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
801 iteration through the command loop. Fixes a problem whereby mouse
802 movements are ignored until the first mouse click.
803
f5d9e83a
PE
8042012-08-14 Paul Eggert <eggert@cs.ucla.edu>
805
806 Use bool, not int, for Lisp booleans.
807 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
808 makes Emacs a bit smaller and presumably a bit faster.
809 * lisp.h: Include <stdbool.h>.
810 (struct Lisp_Boolfwd, defvar_bool):
811 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
812 * regex.c [!emacs]: Include <stdbool.h>.
813 (false, true): Remove; <stdbool.h> does this for us now.
814
55802e4a
CY
8152012-08-14 Chong Yidong <cyd@gnu.org>
816
4abcdac8
CY
817 * character.c (Fcharacterp): Doc fix (Bug#12076).
818
819 * data.c (Findirect_variable): Doc fix (Bug#11040).
820
55802e4a
CY
821 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
822
823 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 824 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 825
8e99d072
BR
8262012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
827
828 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
829 (bug#12022).
830
08908aca
MR
8312012-08-14 Martin Rudalics <rudalics@gmx.at>
832
833 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
834 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
835 * minibuf.c (choose_minibuf_frame, read_minibuf):
836 * w32fns.c (x_create_tip_frame):
837 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
838 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
839
56120d6f
PE
8402012-08-14 Paul Eggert <eggert@cs.ucla.edu>
841
842 * intervals.c (offset_intervals): Remove obsolete comment.
843
67b77c0b
AS
8442012-08-14 Andreas Schwab <schwab@linux-m68k.org>
845
846 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
847
f48b82fd
GR
8482012-08-14 Gergely Risko <gergely@risko.hu>
849
850 * coding.c (decode_coding): Record buffer modification before
851 disabling undo_list (Bug#11773).
852
fd318b54
DA
8532012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
854
855 Revert and cleanup some recent overlay changes.
856 * buffer.h (enum overlay_type): Remove.
857 (buffer_get_overlays, buffer_set_overlays): Likewise.
858 (buffer_set_overlays_before, buffer_set_overlays_after):
859 New function. Adjust users.
860 (unchain_both): Add eassert.
861
41a62dd9
DA
8622012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
863
864 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
865
5884c324
PE
8662012-08-14 Paul Eggert <eggert@cs.ucla.edu>
867
868 * gtkutil.c (xg_mark_data): Don't assume C99.
869
ca06f160
JD
8702012-08-13 Jan Djärv <jan.h.d@swipnet.se>
871
872 * gtkutil.c (xg_frame_tb_info): New struct.
873 (TB_INFO_KEY): New define.
874 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
875 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
876 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
877 if not present.
878 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
879 is up to date. Otherwise store new data.
880 (free_frame_tool_bar): Free xg_frame_tb_info if present.
881
7864a3f7
DA
8822012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
883
884 Use KSET for write access to Lisp_Object members of struct kboard.
885 * keyboard.h (KSET): New macro.
886 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
887 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
888 * xterm.c: Adjust users.
889
4c31be61
DA
8902012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
891
892 Use BSET for write access to Lisp_Object members of struct buffer.
893 * buffer.h (BSET): New macro.
894 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
895 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
896 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
897 * window.c, xdisp.c, xfns.c: Adjust users.
898
14ae4239
BT
8992012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
900
901 * lread.c (syms_of_lread): Initialize Vlexical_binding.
902
32bcadb4
JD
9032012-08-11 Jan Djärv <jan.h.d@swipnet.se>
904
3d29b2ce
JD
905 * nsterm.m (not_in_argv): New function.
906 (application:openFile, application:openTempFile:):
907 (application:openFileWithoutUI:, application:openFiles:): Open file
908 if not_in_argv returns non-zero (bug#12171).
909
32bcadb4 910 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
911 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
912 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
913 (xg_get_font_name): Use those functions/macros here.
914 Reported by Frans Oilinki <moilinki@gmail.com>.
915
9ff9402d 9162012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
917
918 * unexmacosx.c (copy_data_segment): Copy initialized data in
919 statically linked libraries from input file rather than memory.
920
db74a5fc
YM
921 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
922 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
923 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
924
25e65510
GM
9252012-08-10 Glenn Morris <rgm@gnu.org>
926
927 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
928 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
929
7961135c
DA
9302012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
931
932 Fix last change to allow compilation with low optimization levels.
933 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
934 Reported by Jan Djärv <jan.h.d@swipnet.se>.
935
42b3a444
DA
9362012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
937
938 Use common inline syntax in intervals.h.
939 * intervals.h (INTERVALS_INLINE): New macro.
940 Change all users from LISP_INLINE.
941
9fb0c957
DA
9422012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
943
944 Define Qnone once for all platforms.
945 * frame.c (Qnone): Define here.
946 (syms_of_frame): DEFSYM it.
947 * lisp.h (Qnone): New declaration.
948 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
949 * xfns.c: Remove duplication. Adjust users.
950
65e8ee52
DA
9512012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
952
953 Remove unused macros from intervals.h.
954 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
955 * intervals.c: Adjust comment.
956
9b855fd6
EZ
9572012-08-10 Eli Zaretskii <eliz@gnu.org>
958
959 * w32fns.c <w32_unicode_gui>: New static variable.
960 (globals_of_w32fns): Initialize it according to os_subtype.
961 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
962 testing os_subtype.
963
39cb9e56 9642012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
965 Eli Zaretskii <eliz@gnu.org>
966
967 Fix bug #10299 with Unicode characters sent by customized
968 keyboards created by MSKLC.
969 * w32fns.c (INIT_WINDOW_CLASS): New macro.
970 (w32_init_class): Use it to initialize the Emacs class with either
971 ANSI or Unicode API calls.
972 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
973 later.
974 (w32_wnd_proc): If the character code sent by WM_CHAR or
975 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
976 original message. Call DefWindowProcW on NT and later.
977
9374581a
GM
9782012-08-10 Glenn Morris <rgm@gnu.org>
979
4b94e8cf
GM
980 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
981
9374581a
GM
982 * lisp.h (DIRECTORY_SEP): Let configure set it.
983
a2752828
DA
9842012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
985
986 Use TSET for write access to Lisp_Object slots of struct terminal.
987 * termhooks.h (TSET): New macro.
988 * coding.c, terminal.c, xselect.c: Adjust users.
989
cc92c454
SM
9902012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
991
992 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
993 the failing expression, include them in the error message.
994 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
995 * lisp.h (internal_condition_case_n): Update declaration.
996
4cb3e6b3
DA
9972012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
998
999 Inline functions to examine and change buffer overlays.
1000 * buffer.c (unchain_both): New function.
1001 * buffer.h (buffer_get_overlays, buffer_set_overlays):
1002 (buffer_has_overlays): New function.
1003 (enum overlay_type): New enum.
1004 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
1005 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
1006
8707c1e5
DA
10072012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1008
1009 Inline functions to examine and change buffer intervals.
1010 * alloc.c (mark_interval_tree): Remove.
1011 (MARK_INTERVAL_TREE): Simplify.
1012 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
1013 * intervals.c (buffer_balance_intervals): New function.
1014 (graft_intervals_into_buffer): Adjust indentation.
1015 (set_intervals_multibyte): Simplify.
1016 * buffer.h (BUF_INTERVALS): Remove.
1017 (buffer_get_intervals, buffer_set_intervals): New function.
1018 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
1019 * intervals.c, textprop.c: Adjust users.
1020
ad8c997f
DA
10212012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1022
1023 Inline functions to examine and change string intervals.
1024 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
1025 (string_get_intervals, string_set_intervals): New function.
1026 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1027 * lread.c, print.c, textprop.c: Adjust users.
1028
32ac3a6b
GM
10292012-08-08 Glenn Morris <rgm@gnu.org>
1030
1031 * lisp.mk (lisp): Remove language/persian.elc.
1032
77c7bcb1
DA
10332012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1034
1035 Cleanup intervals.
1036 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
1037 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
1038 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
1039 Adjust comment. Move under #if 0.
77c7bcb1
DA
1040 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1041 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
1042
9c08a8d4
DA
10432012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1044
1045 Check total length of intervals with eassert.
1046 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
1047 * intervals.c: Change all users to eassert.
1048
26d16b35
EZ
10492012-08-07 Eli Zaretskii <eliz@gnu.org>
1050
14ae4239
BT
1051 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
1052 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
1053 INTERNAL_FIELD in Lisp_Cons.
1054
c644523b
DA
10552012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1056
1057 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
1058 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
1059 name since all xname users are fixed long time ago. Do not
1060 use INTERNAL_FIELD.
1061 (set_symbol_name, set_symbol_function, set_symbol_plist):
1062 (set_symbol_next, set_overlay_plist): New function.
1063 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
1064 (struct Lisp_Overlay): Likewise.
1065 (CVAR, MVAR, SVAR): Remove.
1066 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
1067 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
1068 * xterm.c: Adjust users.
1069 * .gdbinit: Change to use name field of struct Lisp_Symbol
1070 where appropriate.
1071
6a3d20cc
DA
10722012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1073
1074 Basic functions to set Lisp_Object and pointer slots of intervals.
1075 * intervals.h (interval_set_parent, interval_set_object):
1076 (interval_set_left, interval_set_right, interval_set_plist):
1077 (interval_copy_parent): New function.
1078 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
1079 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
1080 Adjust indentation.
6a3d20cc
DA
1081 (INTERVAL_SIZE): Remove. Adjust users.
1082 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
1083
4d2b044c
DA
10842012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1085
1086 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
1087 * process.h (PGET): Remove.
1088 (struct Lisp_Process): Do not use INTERNAL_FIELD.
1089 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1090
d3d50620
DA
10912012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1092
1093 Drop WGET and revert read access to Lisp_Objects slots of struct window.
1094 * window.h (WGET): Remove.
1095 (struct window): Do not use INTERNAL_FIELD.
1096 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1097 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1098 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1099 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1100 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1101 Adjust users.
1102
d10a51dc
CY
11032012-08-07 Chong Yidong <cyd@gnu.org>
1104
1105 * window.c (Fwindow_edges, Fwindow_pixel_edges)
1106 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
1107 (Fdelete_window_internal): Signal an error if the window is not on
1108 a live frame (Bug#12025).
1109
e69b0960
DA
11102012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1111
1112 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
1113 * frame.h (FGET): Remove.
1114 (struct frame): Do not use INTERNAL_FIELD.
1115 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1116 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1117 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1118 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1119
25a20a3a
JB
11202012-08-06 Juanma Barranquero <lekktu@gmail.com>
1121
1122 * w32.c: Silence compiler warnings.
1123 (map_w32_filename): Remove unused variable `is_fat'.
1124 (chase_symlinks): Add parentheses around expression.
1125
1c6f11f4
GM
11262012-08-06 Glenn Morris <rgm@gnu.org>
1127
1db4583a
GM
1128 * sysdep.c: Respect BROKEN_GETWD.
1129
1c6f11f4
GM
1130 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
1131 Let configure handle it.
1132 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
1133
2b90362b
DA
11342012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1135
1136 Use GCALIGNMENT where appropriate.
1137 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
1138 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
1139 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
1140
5f50daf2
EZ
11412012-08-06 Eli Zaretskii <eliz@gnu.org>
1142
14ae4239
BT
1143 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
1144 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 1145
cbcc7007
SM
11462012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
1147
1148 * buffer.h (struct buffer): Revert `indirections' to a simple int;
1149 that should be sufficient for everyone.
1150
4d365fa4
JD
11512012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1152
1153 * keyboard.c (timer_check_2): Add break so timer_check returns next
1154 timeout.
1155
dd86bd82
DA
11562012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 Fix Windows build errors introduced after converting to WGET and WSET.
1159 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
1160 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1161
054e1668
JD
11622012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1163
1164 * nsterm.m (ns_frame_rehighlight): Use FSET.
1165
1166 * nsmenu.m (ns_update_menubar): Use FSET.
1167
21238f11
DA
11682012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1169
1170 Separate read and write access to Lisp_Object slots of Lisp_Process.
1171 * process.h (PGET, PSET): New macros similar to AREF and ASET.
1172 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1173
077288cf
DA
11742012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1175
1176 Separate read and write access to Lisp_Object slots of struct window.
1177 * window.h (WGET, WSET): New macros similar to AREF and ASET.
1178 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1179 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1180 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1181 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1182 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1183 Adjust users.
1184
71688bd7
DA
11852012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1186
1187 Fix Windows build errors introduced after converting to FGET and FSET.
1188 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
1189 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
1190 (w32_judge_scroll_bars): Change to use FSET.
1191 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1192
f99bac93
DA
11932012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1194
1195 Fix replacement typo.
1196 * window.c (replace_window): Set root_window instead of
1197 selected_window. This fixes a total window subsystem
1198 malfunction reported by Bastien Guerry <bzg@gnu.org>.
1199
8c2a0f2d
GM
12002012-08-06 Glenn Morris <rgm@gnu.org>
1201
1202 * lisp.mk (lisp): Add language/persian.elc.
1203
edd74c35
DA
12042012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1205
1206 Separate read and write access to Lisp_Object slots of struct frame.
1207 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
1208 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1209 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1210 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1211 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1212
8671676c
AS
12132012-08-05 Andreas Schwab <schwab@linux-m68k.org>
1214
1215 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
1216
663e2b3f
DA
12172012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1218
1219 Generalize common compile-time constants.
1220 * lisp.h (header_size, bool_header_size, word_size): Now here.
1221 (struct Lisp_Vector): Add comment.
1222 (struct Lisp_Bool_Vector): Move up to define handy constants.
1223 (VECSIZE, PSEUDOVECSIZE): Simplify.
1224 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
1225 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
1226 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
1227 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
1228 * xfont.c, xmenu.c: Use word_size where appropriate.
1229
d32e47af
LM
12302012-08-05 Lawrence Mitchell <wence@gmx.li>
1231
1232 * search.c (Freplace_match): Treat \? in the replacement text
1233 literally (Bug#8161).
1234
e5d9c0d1
CY
12352012-08-05 Chong Yidong <cyd@gnu.org>
1236
1237 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
1238 * frame.c (Vdelete_frame_functions):
1239 * emacs.c (Vkill_emacs_hook): Doc fix.
1240
8da0576b
EZ
12412012-08-04 Eli Zaretskii <eliz@gnu.org>
1242
1243 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
1244 --with-x-toolkit=no builds.
1245 Reported by Carsten Mattner <carstenmattner@gmail.com>.
1246
02676e5d
CY
12472012-08-04 Chong Yidong <cyd@gnu.org>
1248
1249 * syntax.c (Fmodify_syntax_entry): Doc fix.
1250
97147da9
EZ
12512012-08-04 Eli Zaretskii <eliz@gnu.org>
1252
76151e2c
EZ
1253 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
1254 * w32.c (init_environment): Change the default values of many
1255 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
1256 them into environment when they were not already defined.
1257 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 1258 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
1259 (check_windows_init_file): Now external, not static.
1260 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
1261 called when Vload_path is already set up.
1262
1263 * w32.h (check_windows_init_file): Add prototype.
1264
1265 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
1266 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
1267 compatibility with Posix platforms.
1268 (main): Move the call to check_windows_init_file to here from
1269 w32.c.
1270 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
1271 any, in the DEFALT argument into the root of the Emacs build or
1272 installation tree, as appropriate.
1273
1274 * callproc.c (init_callproc_1): Call decode_env_path instead of
1275 doing its equivalent by hand.
1276 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
1277 the code that sets Vexec_path run on MS-Windows.
1278
1279 * lread.c (init_lread): Add comments to #ifdef's.
1280
97147da9
EZ
1281 * msdos.c (dos_set_window_size, IT_update_begin)
1282 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
1283 instead of direct references.
1284
185ee146
PE
12852012-08-04 Paul Eggert <eggert@cs.ucla.edu>
1286
1287 Export DEFAULT_REHASH_* to GDB.
1288 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
1289 Now constants, not macros.
1290
8834c57a
PE
12912012-08-03 Paul Eggert <eggert@cs.ucla.edu>
1292
98c6f1e3
PE
1293 Remove unnecessary casts involving pointers.
1294 These casts are no longer needed now that we assume C89 or later,
1295 since they involve casting to or from void *.
1296 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
1297 (make_pure_float, make_pure_vector):
1298 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
1299 * macros.c (Fstart_kbd_macro):
1300 * menu.c (find_and_return_menu_selection):
1301 * minibuf.c (read_minibuf_noninteractive):
1302 * sysdep.c (closedir):
1303 * xdisp.c (x_produce_glyphs):
1304 * xfaces.c (compare_fonts_by_sort_order):
1305 * xfns.c (x_real_positions, select_visual):
1306 * xselect.c (x_stop_queuing_selection_requests)
1307 (x_get_window_property, x_get_window_property_as_lisp_data):
1308 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
1309 Remove unnecessary pointer casts.
1310 * alloc.c (record_xmalloc): New function.
1311 * lisp.h (record_xmalloc): New decl.
1312 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
1313 more like a function. This is because the pointer cast is not
1314 needed. All uses changed.
1315 * print.c (print_string, print_error_message): Avoid length recalc.
1316
8834c57a
PE
1317 Improve fix for macroexp crash with debugging (Bug#12118).
1318 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
1319 ARRAY_MARK_FLAG when checking subscripts, because ASET is
1320 not supposed to be invoked from the garbage collector.
1321 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
1322 (gc_aset): New function, which is like ASET but can be
1323 used in the garbage collector.
1324 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1325 (set_hash_index): Use it instead of ASET.
1326
6dad7178
EZ
13272012-08-03 Eli Zaretskii <eliz@gnu.org>
1328
1329 Support symlinks on latest versions of MS-Windows.
1330 * w32.c: Include winioctl.h and aclapi.h.
1331 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
1332 (revert_to_self): Forward declarations of static functions.
1333 <static BOOL g_b_init_get_security_info>:
1334 <g_b_init_create_symbolic_link>: New static flags.
1335 (globals_of_w32): Initialize them to zero.
1336 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
1337 (map_w32_filename): Improve commentary. Simplify switch.
1338 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
1339 headers (most versions of MinGW w32api don't).
1340 (get_security_info, create_symbolic_link)
1341 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
1342 New functions.
1343 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
1344 in the argument file name.
1345 (sys_access): Call unc_volume_file_attributes only if
1346 GetFileAttributes fails with network-related error codes.
1347 (sys_rename): Diagnose renaming of a symlink when the user doesn't
1348 have the required privileges.
14ae4239 1349 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
1350 get_file_security_desc.
1351 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
1352 with addition of handling of symlinks and support for 'lstat'.
1353 If possible, get file's attributes and security information by
6dad7178
EZ
1354 handle, not by name. Produce S_IFLNK bit for symlinks, when
1355 called from 'lstat'.
1356 (stat, lstat): New functions, call 'stat_worker'.
1357 (symlink, readlink, careadlinkat): Rewritten to create and resolve
1358 symlinks when the underlying filesystem supports them.
1359
f162bcc3
PE
13602012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1361
79ea6c20
PE
1362 Fix macroexp crash on Windows with debugging (Bug#12118).
1363 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
1364 checking subscripts; problem introduced with the recent
1365 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
1366 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
1367 since it's used in non-static inline functions now.
1368
c0ce93fd
PE
1369 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
1370 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 1371
f162bcc3
PE
1372 Use C99-style 'extern inline' if available.
1373 * buffer.h (BUFFER_INLINE):
1374 * category.h (CATEGORY_INLINE):
1375 * character.h (CHARACTER_INLINE):
1376 * charset.h (CHARSET_INLINE):
1377 * composite.h (COMPOSITE_INLINE):
1378 * dispextern.h (DISPEXTERN_INLINE):
1379 * lisp.h (LISP_INLINE):
1380 * systime.h (SYSTIME_INLINE):
1381 New macro, replacing 'static inline' in this header.
1382 * buffer.h, category.h, character.h, charset.h, composite.h:
1383 * dispextern.h, lisp.h, systime.h:
1384 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1385 * alloc.c (LISP_INLINE):
1386 * buffer.c (BUFFER_INLINE):
1387 * category.c (CATEGORY_INLINE):
1388 * character.c (CHARACTER_INLINE):
1389 * charset.c (CHARSET_INLINE):
1390 * composite.c (COMPOSITE_INLINE):
1391 * dispnew.c (DISPEXTERN_INLINE):
1392 * sysdep.c (SYSTIME_INLINE):
1393 Define to EXTERN_INLINE, so that the corresponding functions
1394 are compiled into code.
1395 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1396 (INLINE_HEADER_END): New macros.
1397 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1398 since it's used in non-static inline functions now.
a8333d03 1399 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1400
837b365b
GM
14012012-08-02 Glenn Morris <rgm@gnu.org>
1402
d66b744d
GM
1403 * s/: Remove empty directory.
1404
837b365b
GM
1405 * s/ms-w32.h: Move to ../nt/inc.
1406 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1407 Update for new ms-w32.h location.
1408
13294f95
PE
14092012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 Port to Solaris 8.
1412 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1413
90df0db3
GM
14142012-08-02 Glenn Morris <rgm@gnu.org>
1415
1416 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1417 hard-coding the path separator.
1418
4939150c
PE
14192012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1422 This how ASET and AREF are supposed to work, and makes
1423 it easier to think about future improvements. See
1424 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1425 * charset.h (set_charset_attr): New function.
1426 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1427 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1428 (aref_addr): New function. All uses of &AREF(...) changed.
1429 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1430 (set_hash_index): New functions. All lvalue-style uses of
1431 HASH_KEY etc. changed.
1432 * keyboard.c (set_prop): New function. All lvalue-style uses
1433 of PROP changed.
1434
947b2afd
AA
14352012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1436
1437 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1438 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1439 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1440 * nsfns.m (ns_set_name_as_filename): Likewise.
1441 * nsmenu.m (ns_update_menubar): Likewise.
1442 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1443
4f5d0325
EZ
14442012-08-01 Eli Zaretskii <eliz@gnu.org>
1445
2008beae
EZ
1446 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1447 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1448 objects.
2008beae 1449
4f5d0325
EZ
1450 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1451
fe3cc771
GM
14522012-08-01 Glenn Morris <rgm@gnu.org>
1453
1454 * s/msdos.h: Remove file.
1455 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1456 * Makefile.in (S_FILE): Remove.
1457 (config_h): Remove S_FILE.
1458
c90acc54
JB
14592012-08-01 Juanma Barranquero <lekktu@gmail.com>
1460
1461 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1462 Remove; moved to nt/config.nt.
1463
d8a05828
DA
14642012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1465
1466 Use INTERNAL_FIELD for conses and overlays.
1467 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1468 Remove obsolete comment.
1469 (MVAR): New macro.
1470 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1471 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1472
8271d590
DA
14732012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1474
1475 Use INTERNAL_FIELD for symbols.
1476 * lisp.h (SVAR): New macro. Adjust users.
1477 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1478 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1479
3193acd2
DA
14802012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1481
1482 Use INTERNAL_FIELD for processes.
1483 * process.h (PVAR): New macro. Adjust style.
1484 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1485 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1486
3a45383a
DA
14872012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1488
1489 Use INTERNAL_FIELD for windows.
1490 * window.h (WVAR): New macro.
1491 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1492 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1493 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1494 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1495 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1496 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1497
c1dbc63c
PE
14982012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1501
5c0c0e8a
GM
15022012-08-01 Glenn Morris <rgm@gnu.org>
1503
1504 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1505 Move to configure.ac.
1506
552a99b4
JB
15072012-08-01 Juanma Barranquero <lekktu@gmail.com>
1508
1509 * makefile.w32-in (CONFIG_H): Update dependencies.
1510 (CONF_POST_H): New macro.
1511
1512 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1513
8d8e2dfe
GM
15142012-07-31 Glenn Morris <rgm@gnu.org>
1515
bc96620a
GM
1516 * Makefile.in (S_FILE): No longer set by configure.
1517
476b1b2d
GM
1518 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1519 is available.
1520 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1521
b2c7a106
GM
1522 * process.h (NULL_DEVICE):
1523 * emacs.c (SEPCHAR):
1524 * editfns.c (USER_FULL_NAME): Let configure set them.
1525
d53d062a
GM
1526 * s/README, s/template.h: Remove files.
1527
4515017f
GM
1528 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1529
8d8e2dfe
GM
1530 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1531 Move to configure.ac.
1532
5b20b3cc
EZ
15332012-07-31 Eli Zaretskii <eliz@gnu.org>
1534
1e0afd9a
EZ
1535 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1536 resulting renaming of 'struct frame' members.
1537
5b20b3cc
EZ
1538 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1539
1540 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1541 after introduction of FVAR.
1542
f1310128
JD
15432012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1544
79e721e0
JD
1545 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1546
1547 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1548 instead of compositeToPoint.
1549 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1550
8d7c7eed 1551 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1552
e34f7f79
DA
15532012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1554
1555 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1556 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1557 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1558 (BVAR): Change to use INTERNAL_FIELD.
1559 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1560 (KVAR): Change to use INTERNAL_FIELD.
1561 * frame.h (FVAR): New macro.
1562 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1563 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1564 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1565 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1566 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1567
c09bfb2f
DA
15682012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1569
1570 Miscellaneous fixes for non-default X toolkits.
1571 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
1572 * xterm.c (x_frame_of_widget): Remove redundant prototype.
1573 Move under #ifdef USE_LUCID.
1574 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
1575 definition and usage to avoid warnings.
1576
14c114ae
JD
15772012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1578
1579 * nsterm.m (openFiles): Fix previous checkin.
1580
3bd21e82
PE
15812012-07-31 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * indent.c (compute_motion): Remove unused local.
1584
c1529ded
GM
15852012-07-31 Glenn Morris <rgm@gnu.org>
1586
400d5621
GM
1587 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
1588
268e2432
GM
1589 * conf_post.h [USG5_4]:
1590 Move remaining contents of s/usg5-4-common.h here.
1591 * s/usg5-4-common.h: Remove file.
1592
7552f3ee
GM
1593 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
1594 * s/irix6-5.h: Remove file.
1595
6a381852
GM
1596 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
1597 * s/darwin.h: Remove file.
1598
c1529ded
GM
1599 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1600 * s/hpux10-20.h: Remove file, which is now empty.
1601
b429a4ee
GM
16022012-07-30 Glenn Morris <rgm@gnu.org>
1603
1604 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1605 * Makefile.in (config_h): Add conf_post.h.
1606 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1607
adff3182
JD
16082012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1609
1610 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1611 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1612 (openFile, openTempFile, openFileWithoutUI, openFiles):
1613 Open files only if ns_do_open_file.
adff3182 1614
c32af1e4
PE
16152012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1616
7393bcbb
PE
1617 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1618 This no-op macro hasn't been needed for many years.
1619 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1620
c32af1e4
PE
1621 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1622 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1623 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1624 gdb_make_enums_visible.
1625 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1626 (DIRECTORY_SEP): Now a constant, not a macro.
1627
302fc036
EZ
16282012-07-30 Eli Zaretskii <eliz@gnu.org>
1629
1630 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1631 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1632
1633 * w32term.c <w32_keyboard_codepage>: Renamed from
1634 keyboard_codepage and now external. All users changed.
1635
1636 * w32term.h: Add declaration of w32_keyboard_codepage.
1637
1638 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1639 the codepage to translate keys to Unicode. If this argument is
1640 -1, use the value returned by GetConsoleCP. All callers changed.
1641
88fb40b4
PE
16422012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1643
0aee6912
PE
1644 Update .PHONY listings in makefiles.
1645 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1646 bootstrap-clean, distclean, maintainer-clean, versioclean,
1647 extraclean, frc.
1648
88fb40b4
PE
1649 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1650 This is a bit clearer. Fix some commentary typos.
1651
0a763bd1
GM
16522012-07-30 Glenn Morris <rgm@gnu.org>
1653
32bac6d6
GM
1654 * s/netbsd.h: Let configure include signal.h if needed.
1655 Remove file, which is now empty.
1656
b65e7c46
GM
1657 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1658 Let configure set them.
1659 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1660 No more need to undefine.
0a763bd1 1661
169304bd
AS
16622012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1663
1664 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1665 non-single-byte char when adding meta modifier. (Bug#12090)
1666
6cd7a139
DA
16672012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1668
1669 Convert safe_call to use variable number of arguments.
1670 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1671 (safe_call2): Fix comment.
1672 * lisp.h (safe_call): Adjust prototype.
1673 * coding.c (encode_coding_object): Change to use safe_call2.
1674 * xfaces.c (merge_face_heights): Change to use safe_call1.
1675
d34d6ffc
GM
16762012-07-30 Glenn Morris <rgm@gnu.org>
1677
7b8a48e4 1678 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1679 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1680
d34d6ffc
GM
1681 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1682 Remove empty files.
1683
03a660a6
PE
16842012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1685
1686 Export to GDB most of lisp.h's remaining object-like macros.
1687 * lisp.h (min, max): Move earlier, because they're used earlier now.
1688 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1689 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1690 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1691 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1692 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1693 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1694 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1695 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1696 Now constants, for GDB. They need not be macros.
1697 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1698 Now constants, for GDB, as well as macros, for static initializers.
1699 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1700 Move to after the definition of struct Lisp_Char_Table,
1701 since the former now needs that type defined.
1702 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1703 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1704 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1705 New enums, for gdb_make_enums_visible.
1706 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1707 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1708 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1709 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1710 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1711 enum maxargs, enum MAX_ALLOCA.
1712 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1713 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1714 no longer needed, now that they are done in lisp.h.
1715
e499d0ee
DA
17162012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1717
1718 Cleanup string bytes checking.
1719 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1720 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1721 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1722 (check_sblock, compact_small_strings): Simplify.
1723
d5040d2d
PE
17242012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1727 These macros are confusing and no longer need to be defined, as
1728 the enum values now suffice. All uses replaced with definiens.
1729 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1730
7f259ae6
JB
17312012-07-29 Juanma Barranquero <lekktu@gmail.com>
1732
1733 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1734 ($(BLD)/w32console.$(O)): Update dependencies.
1735
7e63e0c3
DA
17362012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1737
1738 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1739 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1740 time. Adjust users.
1741 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1742
ffd817eb
JD
17432012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1744
1745 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1746 setting sitelisp (Bug#12010).
1747
417a7a0e
EZ
17482012-07-29 Eli Zaretskii <eliz@gnu.org>
1749
14ae4239 1750 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1751
1752 * w32heap.c (cache_system_info):
1753 * w32.c (sys_rename):
1754 * w32proc.c (find_child_console, sys_kill): All users changed.
1755
387d4d92
PE
17562012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1757
1758 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1759
55a6cca6
EZ
17602012-07-29 Eli Zaretskii <eliz@gnu.org>
1761
1762 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1763
dbcf001c
DA
17642012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1765
1766 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1767 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1768 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1769
e2688e4a
DA
17702012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1771
1772 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1773 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1774 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1775 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1776 (replace_range, replace_range_2, del_range_2): Change to eassert.
1777 * marker.c (byte_char_debug_check): Adjust style.
1778
b46a6a83
PE
17792012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1782 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1783 long-ago-commented-out code that talks about "WIN32".
1784 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1785 All uses changed.
1786
e32a5799
PE
17872012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1790 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1791 Simplify by using alignof.
1792 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1793 * lisp.h: Include <stdalign.h>.
1794 (GCALIGNMENT): New macro and constant.
1795 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1796 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1797 (stdalign): New macro, if not already defined.
1798
df81cd29
EZ
17992012-07-28 Eli Zaretskii <eliz@gnu.org>
1800
01bd1b0d
EZ
1801 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1802 * w32inevt.c: Include w32inevt.h.
1803 (w32_read_console_input): New inline function, calls either
1804 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1805 w32_console_unicode_input.
1806 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1807 (w32_kbd_patch_key, key_event): Use the codepage returned by
1808 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1809 (key_event): use uChar.UnicodeChar only if
1810 w32_console_unicode_input is non-zero.
1811
1812 * w32console.c: Include w32heap.h.
1813 <w32_console_unicode_input>: New global variable.
1814 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1815 family of Windows, zero otherwise.
1816
1817 * w32inevt.h: Declare w32_console_unicode_input.
1818
df81cd29
EZ
1819 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1820 --without-x. (Bug#11742)
1821
c20fdd9e
PE
18222012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1823
1824 Adjust GDB to reflect pvec_type changes (Bug#12036).
1825 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1826 2012-07-04 changes to pseudovector representation.
1827 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1828
32770973 18292012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1830
1831 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1832 bus address.
1833 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1834
3438fe21
EZ
18352012-07-27 Eli Zaretskii <eliz@gnu.org>
1836
bcfbc9de
EZ
1837 * alloc.c (listn): Fix the order the arguments are consed onto the
1838 list.
1839
3438fe21
EZ
1840 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1841 enumeration constants, as PURE and HEAP are too general, and clash
1842 with other headers and sources, such as gmalloc.c and the
1843 MS-Windows system headers. All users changed.
1844
eeaea515
DA
18452012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1846
1847 Revert last save_excursion_save and save_excursion_restore changes.
1848 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1849 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1850
073c88c2
DA
18512012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1852
1853 Fix recently-introduced typos in Windows port.
1854 Reported by Martin Rudalics <rudalics@gmx.at>.
1855 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1856 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1857
4706125e
PE
18582012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 Improve GDB symbol export (Bug#12036).
1861 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1862 arms of an 'if', not using conditional expressions; otherwise GDB
1863 complains about the types in the unevaluated arm when the argument
1864 is an integer literal.
1865 (xgetint): Simplify expression.
1866 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1867 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1868 Zaretskii in <http://bugs.gnu.org/12036#13>.
1869 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1870 needed now that we have gdb_make_enums_visible.
1871 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1872 (enum enum_USE_LSB_TAG):
1873 New enum types, packaging up enums that need to be exported to GDB.
1874
694b6c97
DA
18752012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1876
1877 Utility function to make a list from specified amount of objects.
1878 * lisp.h (enum constype): New datatype.
1879 (listn): New prototype.
1880 * alloc.c (listn): New function.
1881 (Fmemory_use_count, syms_of_alloc): Use it.
1882 * buffer.c (syms_of_buffer): Likewise.
1883 * callint.c (syms_of_callint): Likewise.
1884 * charset.c (define_charset_internal): Likewise.
1885 * coding.c (syms_of_coding): Likewise.
1886 * keymap.c (syms_of_keymap): Likewise.
1887 * search.c (syms_of_search): Likewise.
1888 * syntax.c (syms_of_syntax): Likewise.
1889 * w32.c (init_environment): Likewise.
1890 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1891 * xdisp.c (syms_of_xdisp): Likewise.
1892 * xfns.c (syms_of_xfns): Likewise.
1893
6195f384
DA
18942012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1895
1896 Fast save_excursion_save and save_excursion_restore.
1897 * lisp.h (struct Lisp_Excursion): New data type.
1898 (PVEC_EXCURSION): New pseudovector type.
1899 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1900 to deal with it. Adjust comments.
1901 (init_marker, attach_marker): New prototype.
1902 (unchain_marker): Adjust prototype.
1903 * marker.c (attach_marker): Change to global.
1904 (init_marker): New function.
1905 * alloc.c (Fmake_marker, build_marker): Use it.
1906 (build_marker): More easserts.
1907 (mark_object): Handle struct Lisp_Excursion.
1908 * editfns.c (save_excursion_save, save_excursion_restore):
1909 Reimplement to use struct Lisp_Excursion. Add comments.
1910
5eceb8fb
PE
19112012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 Fix export of symbols to GDB (Bug#12036).
1914 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1915 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1916 emacs.c, as this is a more-suitable home. Had this been done earlier
1917 the fix for 12036 would have avoided some of the problems noted in
1918 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1919 would have been more obvious.
562157c8
PE
1920 * emacs.c: Do not include <verify.h>; no longer needed.
1921 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1922 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1923 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1924 Remove; now done in lisp.h.
1925 * lisp.h (PUBLISH_TO_GDB): New macro.
1926 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1927 (DATA_SEG_BITS): Use it.
1928 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1929 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1930 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1931 not be usable in #if. This simplifies things.
1932
d6749401
JB
19332012-07-26 Juanma Barranquero <lekktu@gmail.com>
1934
1935 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1936
1781b9e9
PE
19372012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1938
d89518db 1939 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1940 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1941 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1942 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1943 Adjust to changes in lisp.h and emacs.c, by using
1944 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1945 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1946 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1947 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1948 instead of gdb_valbits.
1949 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1950 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1951 instead of gdb_array_mark_flag.
1952 (xboolvector): Get size from $->size, not $->header.size.
1953 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1954 (xreload, hook-run, hookpost-run): Remove.
1955 * emacs.c: Include <verify.h>.
1956 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1957 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1958 Remove.
1959 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1960 (gdb_USE_LSB_TAG): New enum constants.
1961 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1962 Also define these as enum constants, so they're visible to GDB.
1963 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1964 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1965 as constants, so they're visible to GDB.
1966 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1967 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1968 Now enum constants, not macros, so they're visible to GDB.
1969 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1970 more convenient now. All uses changed.
1971 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1972 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1973
3628596a
DA
19742012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1975
1976 Explicitly free restriction data that are not needed anymore.
1977 * editfns.c (save_restriction_restore): Free restriction data.
1978
7abaf5cc
SM
19792012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1980
1981 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1982 add argument, tune behavior, and adjust all callers.
1983
71f88e00
PE
19842012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 Use typedef for EMACS_INT, EMACS_UINT.
1987 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1988 than macros. This simplifies debugging in the usual case, since
1989 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1990 and it allows expressions involving EMACS_INT casts.
1991 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1992
57ec3034
JD
19932012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1994
1995 * nsterm.m (ns_read_socket): Return early if there is a modal
1996 window (Bug#12043).
1997
8137e7b3
MR
19982012-07-25 Martin Rudalics <rudalics@gmx.at>
1999
2000 * frame.c (Fredirect_frame_focus): In doc-string don't mention
2001 that FOCUS-FRAME can be omitted.
2002
04e9897c
DA
20032012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
2004
2005 Adjust buffer text indirection counters at the end of Fkill_buffer.
2006 * buffer.c (Fkill_buffer): Adjust indirection counters when the
2007 buffer is definitely dead. This should really fix an issue reported
2008 by Christoph Scholtes again. (Bug#12007).
2009 (init_buffer_once): Initialize indirection counters of
2010 buffer_defaults and buffer_local_symbols (for sanity and safety).
2011
8a0484e1
EZ
20122012-07-24 Eli Zaretskii <eliz@gnu.org>
2013
2014 * xdisp.c (init_iterator): Don't compute dimensions of truncation
2015 and continuation glyphs on tooltip frames, leave them at zero.
2016 Avoids continued lines in tooltips. (Bug#11832)
2017
fa691a83
DA
20182012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
2019
2020 Simplify copy_overlay.
04e9897c 2021 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
2022 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
2023
436bc8e0
EZ
20242012-07-23 Eli Zaretskii <eliz@gnu.org>
2025
2026 * print.c (print_object): Don't crash when a frame's name is nil
2027 or invalid. (Bug#12025)
2028
2029 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
2030 it signals an error when a tooltip frame is being created.
2031
d7a7fda3
DA
20322012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
2033
2034 Cleanup miscellaneous objects allocation and initialization.
2035 * alloc.c (allocate_misc): Change to static. Add argument to
2036 specify the subtype. Adjust comment and users.
2037 (build_overlay): New function.
2038 * buffer.c (copy_overlays, Fmake_overlay): Use it.
2039 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
2040 (allocate_misc): Remove prototype.
2041 (build_overlay): Add prototype.
2042
20432012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
2044
2045 Swap buffer text indirection counters in Fbuffer_swap_text.
2046 * buffer.c (Fbuffer_swap_text): Swap indirections too.
2047 This avoids crash reported by Christoph Scholtes at
2048 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
2049
9d7fa573
JD
20502012-07-22 Jan Djärv <jan.h.d@swipnet.se>
2051
2052 * nsmenu.m (Popdown_data): New struct.
2053 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
2054 free Popdown_data.
2055 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
2056 (initWithContentRect): Make imgView and contentView non-static
2057 and autorelease them. Also autorelease img and matrix (Bug#12005).
2058 (dealloc): Remove (Bug#12005).
2059
0dd6d66d
DA
20602012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2061
2062 Adjust consing_since_gc when objects are explicitly freed.
2063 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
2064 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
2065 (free_cons, free_misc): Subtract object size from consing_since_gc.
2066
d36d71df
DA
20672012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2068
2069 Simplify and cleanup markers positioning code.
2070 * marker.c (attach_marker): More useful eassert.
2071 (live_buffer, set_marker_internal): New function.
2072 (Fset_marker, set_marker_restricted): Use set_marker_internal.
2073 (set_marker_both, set_marker_restricted_both): Use live_buffer.
2074
fb9ea40f
PE
20752012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
2078 as it's limited by the amount of memory, not by INT_MAX.
2079
2d5c5f7d
EZ
20802012-07-21 Eli Zaretskii <eliz@gnu.org>
2081
07fb592e
EZ
2082 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
2083 in special-event-map. See the discussion at
2084 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
2085 for the reasons.
2086
37a9eac8 2087 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
2088 info.dwItemData. Fixes crashes on 64-bit Windows.
2089 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 2090
c4328746
JD
20912012-07-21 Jan Djärv <jan.h.d@swipnet.se>
2092
2093 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 2094 (conversationIdentifier): Return value is NSInteger.
784051c4 2095 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 2096
6e5d1c12
CY
20972012-07-21 Chong Yidong <cyd@gnu.org>
2098
2099 * window.c (decode_any_window): Signal an error if the window is
2100 on a dead frame (Bug#11984).
2101
9928463d
DA
21022012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2103
2104 Add indirection counting to speed up Fkill_buffer.
2105 * buffer.h (struct buffer): New member.
2106 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
2107 (Fmake_indirect_buffer): Set indirection counter to -1, increment
2108 base buffer indirection counter.
2109 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
2110 (Fkill_buffer): Adjust indirection counters as needed, don't walk
2111 through buffer list if indirection counter is 0.
2112
f8643a6b
DA
21132012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2114
2115 Extend the value returned by Fgarbage_collect with heap statistics.
2116 * alloc.c (Qheap): New symbol.
2117 (syms_of_alloc): DEFSYM it.
2118 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
2119 (Fmemory_free): Remove.
2120 (syms_of_alloc): Don't defsubr it.
2121 * buffer.c (Fcompact_buffer): Remove.
2122 (syms_of_buffer): Don't defsubr it.
2123
dac616ff
DA
21242012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2125
2126 Make maybe_gc inline.
2127 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
2128 * lisp.h (consing_since_gc, gc_relative_threshold)
2129 (memory_full_cons_threshold): Revert declaration.
2130 (maybe_gc): Remove prototype, define as inline.
2131 * alloc.c: Remove old commented-out code.
2132 (consing_since_gc, gc_relative_threshold)
2133 (memory_full_cons_threshold): Revert to global.
2134 (maybe_gc): Remove.
2135
d7ea76b4
DA
21362012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
2139 * lisp.h (build_unibyte_string): New function.
2140 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
2141 * sysdep.c, w32fns.c, xfns.c: Use it.
2142 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
2143 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
2144 Adjust users accordingly.
2145 * font.h (font_open_by_name): Adjust prototype.
2146
765e61e3
DA
21472012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2148
2149 Cleanup calls to Fgarbage_collect.
2150 * lisp.h (maybe_gc): New prototype.
2151 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2152 Remove declarations.
2153 * alloc.c (maybe_gc): New function.
2154 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2155 Make them static.
2156 * bytecode.c (MAYBE_GC): Use maybe_gc.
2157 * eval.c (eval_sub, Ffuncall): Likewise.
2158 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
2159 to avoid dependency from auto-save feature.
2160
52b852c7
PE
21612012-07-19 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
2164 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
2165 'for_each_per_buffer_object_at'.
2166 All uses changed. It's better to use upper-case for macros that
2167 cannot be implemented as functions, to give the reader a clue
2168 that they're special.
2169
5db81e33
SM
21702012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
2171
2172 * alloc.c (Fgarbage_collect): Tweak docstring.
2173
5b835e1d
DA
21742012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2175
2176 Tweak the value returned from Fgarbage_collect again.
2177 * alloc.c (Fgarbage_collect): New return value, as confirmed in
2178 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
2179 Adjust documentation.
2180 (total_vector_bytes): Rename to total_vector_slots, adjust
2181 accounting.
2182 (total_free_vector_bytes): Rename to total_free_vector_slots,
2183 adjust accounting.
2184 (Qstring_bytes, Qvector_slots): New symbols.
2185 (syms_of_alloc): DEFSYM them.
2186
9cd47b72
DA
21872012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2188
2189 Buffer compaction primitive which may be used from Lisp.
2190 * buffer.c (compact_buffer, Fcompact_buffer): New function.
2191 (syms_of_buffer): Register Fcompact_buffer.
2192 * alloc.c (Fgarbage_collect): Use compact_buffer.
2193 * buffer.h (compact_buffer): New prototype.
2194 (struct buffer_text): New member.
2195
d17337e5
DA
21962012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2197
2198 New macro to iterate over all buffers, miscellaneous cleanups.
2199 * lisp.h (all_buffers): Remove declaration.
2200 * buffer.h (all_buffers): Add declaration, with comment.
2201 (for_each_buffer): New macro.
2202 * alloc.c (Fgarbage_collect, mark_object): Use it.
2203 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
2204 (init_buffer): Likewise.
2205 * data.c (Fset_default): Likewise.
2206 * coding.c (code_conversion_restore): Remove redundant check
2207 for dead buffer.
2208 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
2209
60cfd278
AS
22102012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2211
2212 Fix bug that created negative-length intervals.
2213 * intervals.c (merge_interval_right, merge_interval_left):
2214 Do not zero out this interval if it is absorbed by its children,
2215 as this interval's total length doesn't change in that case. See
2216 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
2217
d06714cb
PE
22182012-07-18 Paul Eggert <eggert@cs.ucla.edu>
2219
83713154
PE
2220 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
2221 when invoking (make-bool-vector N t) and N is a positive
2222 multiple of 8 -- the last 8 bits were mistakenly cleared.
2223
d06714cb
PE
2224 Remove some struct layout assumptions in bool vectors.
2225 * alloc.c (bool_header_size): New constant.
2226 (header_size, word_size): Move earlier, as they're now used earlier.
2227 Use 'word_size' in a few more places, where it's appropriate.
2228 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
2229 padding before the data member of a bool vector.
2230 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
2231 than doing the check by hand with an abort ().
2232
464d5a5e
SM
22332012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2234
5fbc0409
SM
2235 * eval.c (Fdefvar): Don't check constants since we only set the var if
2236 it's not yet defined anyway (bug#11904).
2237
464d5a5e
SM
2238 * lisp.h (last_undo_boundary): Declare new var.
2239 * keyboard.c (command_loop_1): Set it.
2240 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
2241 were auto-added by the command loop (bug#11774).
2242
8dc2e44a
AS
22432012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2244
2245 * w32font.c (Qsymbol): Remove local definition.
2246 (syms_of_w32font): Don't DEFSYM it.
2247
169925ec
DA
22482012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2249
2250 Fix sweep_vectors to handle large bool vectors correctly.
2251 * alloc.c (sweep_vectors): Account total_vector_bytes for
2252 bool vectors larger than VBLOCK_BYTES_MAX.
2253
5fbfb018
CY
22542012-07-18 Chong Yidong <cyd@gnu.org>
2255
2256 * frame.c (x_set_frame_parameters): Revert bogus change introduced
2257 in 2012-05-25 commit by Paul Eggert (Bug#11738).
2258
3ab6e069
DA
22592012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2260
2261 Return more descriptive data from Fgarbage_collect.
2262 Suggested by Stefan Monnier in
2263 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
2264 * alloc.c (bounded_number): New function.
2265 (total_buffers, total_vectors): New variable.
2266 (total_string_size): Rename to total_string_bytes, adjust users.
2267 (total_vector_size): Rename to total_vector_bytes, adjust users.
2268 (sweep_vectors): Account total_vectors and total_vector_bytes.
2269 (Fgarbage_collect): New return value. Adjust documentation.
2270 (gc_sweep): Account total_buffers.
2271 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
2272 (VECTOR_SIZE): Remove.
2273 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
2274 (Qinterval, Qmisc): New symbols.
2275 (syms_of_data): Initialize them.
2276 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
2277 (Qcons, Qbuffer): New declarations.
2278
6d02fe5b
PE
22792012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 * alloc.c (Fmemory_free): Account for memory-free's own storage.
2282 Round up, not down. Improve doc.
2283
b7ffe040
DA
22842012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2285
2286 Restore old code in allocate_string_data to avoid Faset breakage.
2287 Reported by Julien Danjou <julien@danjou.info> in
2288 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
2289 * alloc.c (allocate_string_data): Restore old code with minor
2290 adjustments, fix comment to explain this subtle issue.
2291
4dc7c8d5
SM
22922012-07-17 Eli Zaretskii <eliz@gnu.org>
2293
2294 Remove FILE_SYSTEM_CASE.
2295 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
2296
2297 * fileio.c (FILE_SYSTEM_CASE): Don't define.
2298 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
2299 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
2300 call-process-region passes it through expand-file-name.
2301
2302 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
2303
23042012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2305
2306 Fix crash when creating indirect buffer (Bug#11917)
2307 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
2308 Don't handle unbound variables specially if non-zero.
2309 (Fbuffer_local_variables): Pass zero.
2310 (clone_per_buffer_values): Pass non-zero.
2311
23122012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2313
2314 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
2315 to make the loop interruptible.
2316
23172012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2318
2319 * gnutls.c (emacs_gnutls_handshake): Only retry if
2320 GNUTLS_E_INTERRUPTED.
2321
cce7fefc
DA
23222012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2323
2324 Cleanup and convert miscellaneous checks to eassert.
2325 * alloc.c (mark_interval): Fix comment, partially rephrase
2326 old comment from intervals.h (see below).
2327 * intervals.c (find_interval, adjust_intervals_for_insertion)
2328 (delete_interval, adjust_intervals_for_deletion)
2329 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
2330 Convert to eassert.
2331 (adjust_intervals_for_insertion, make_new_interval):
2332 Remove obsolete and unused code.
2333 * intervals.h (struct interval): Remove obsolete comment.
2334 * textprotp.c (erase_properties): Remove unused code.
2335 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
2336 (Fremove_list_of_text_properties): Convert to eassert.
2337
9ea10cc3
CY
23382012-07-17 Chong Yidong <cyd@gnu.org>
2339
2340 * editfns.c (Finsert_char): Doc fix.
2341
3900d5de
DA
23422012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2343
2344 Fix previous change to make Fmemory_free always accurate.
2345 * alloc.c (make_interval): Update total_free_intervals.
2346 (make_float): Likewise for total_free_floats.
2347 (free_cons, Fcons): Likewise for total_free_conses.
2348 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
2349 Likewise for total_free_vector_bytes.
2350 (Fmake_symbol): Likewise for total_free_symbols.
2351 (bytes_free): Remove.
2352
7098646f
DA
23532012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2354
2355 Simple free memory accounting feature.
2356 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
2357 (sweep_vectors): Accumulate size of free vectors.
2358 (Fgarbage_collect): Setup bytes_free.
2359 (Fmemory_free): New function.
2360 (syms_of_alloc): Register it.
2361
22657b40
DA
23622012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2363
2364 Cleanup overlays checking.
2365 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
2366 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
2367 eassert and OVERLAYP.
2368 (sort_overlays): Change to use OVERLAYP.
2369
ddfc8813
RK
23702012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
2371
2372 * editfns.c (Finsert_char): Make it interactive, and make the
2373 second arg optional. Copy interactive spec and docstring from
2374 ucs-insert.
2375
7c26cf3c
PE
23762012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2377
2378 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2379 Unlike the other wrapped functions, fabs has an unspecified
2380 effect on errno.
2381
5d127af9
JD
23822012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2383
2384 * nsterm.m (keyDown): Interpret flags without left/right bits
2385 as the left key (Bug#11670).
2386
6a0dd1d7
DA
23872012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2388
2389 Remove empty and useless init functions.
2390 * lisp.h (init_character_once, init_fns, init_image)
2391 (init_filelock, init_sound): Remove prototype.
2392 * character.c (init_character_once): Remove.
2393 * filelock.c (init_filelock): Likewise.
2394 * fns.c (init_fns): Likewise.
2395 * image.c (init_image): Likewise.
2396 * sound.c (init_sound): Likewise.
2397 * emacs.c (main): Adjust accordingly.
2398
7a6136fd
DA
23992012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2400
2401 * gtkutil.h: Tiny cleanups.
2402 (use_old_gtk_file_dialog): Remove useless declaration.
2403 (xg_uses_old_file_dialog): Add suggested const attribute.
2404
ce811ad9
EZ
24052012-07-15 Eli Zaretskii <eliz@gnu.org>
2406
2407 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2408 (bidi_paragraph_init): Use it to limit search forward for a strong
2409 directional character in abnormally large paragraphs full of
2410 neutral or weak characters. (Bug#11943)
2411
c9adfeaa
SF
24122012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2413
2414 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2415 the toolbar (Bug#9451).
2416 (xg_make_tool_item): Give the widget event box a transparent
2417 background.
2418
fff62aa9
DA
24192012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2420
2421 Cleanup basic allocation variables and functions.
2422 * alloc.c (ignore_warnings, init_intervals, init_float)
2423 (init_cons, init_symbol, init_marker): Remove.
2424 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2425 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2426 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2427 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2428 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2429 (staticidx, init_alloc_once, init_strings, free_ablock):
2430 Remove redundant initialization.
2431 * fns.c (init_weak_hash_tables): Remove.
2432 * lisp.h (init_weak_hash_tables): Remove prototype.
2433
9730daca
DA
24342012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2435
2436 Use zero_vector where appropriate.
2437 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2438 accordingly.
2439 * lisp.h (zero_vector): New declaration.
2440 * font.c (null_vector): Remove.
2441 (syms_of_font): Remove initialization and staticpro.
2442 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2443 * keymap.c (Faccessible_keymaps): Likewise.
2444
2e2d2a13
LL
24452012-07-15 Leo Liu <sdl.web@gmail.com>
2446
2447 * fringe.c: Fix typo in comments.
2448
cd276f6e
LL
24492012-07-14 Leo Liu <sdl.web@gmail.com>
2450
2451 * fringe.c: Add a new bitmap exclamation-mark.
2452
5a1131d9
EZ
24532012-07-14 Eli Zaretskii <eliz@gnu.org>
2454
2455 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2456
2457 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2458 (HAVE_MENUS): Don't define, defined by editing config.in with
2459 msdos/sed2v2.inp.
2460 (GMALLOC_INHIBIT_VALLOC): Don't define.
2461 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2462
22e983b7
JB
24632012-07-14 Juanma Barranquero <lekktu@gmail.com>
2464
2465 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2466
5b3f250f
GM
24672012-07-14 Glenn Morris <rgm@gnu.org>
2468
2469 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2470 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2471 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2472
33d63ff4
GM
24732012-07-13 Glenn Morris <rgm@gnu.org>
2474
5b633342
GM
2475 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2476
33d63ff4
GM
2477 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2478 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2479
b55b9f85
JD
24802012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2481
0dc8cf50
JD
2482 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2483 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2484 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2485 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2486 where appropriate.
2487 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2488 as boolean expression.
2489 (x_set_window_size): Remove unused variable toolbar.
2490 (ns_get_color_default, ns_mod_to_lisp): Remove.
2491 (ns_mouse_position): Remove unused variables xchar and ychar.
2492 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2493 (ns_set_vertical_scroll_bar): Remove unused variable count.
2494 (ns_delete_terminal): Remove unused variable i.
2495 (ns_term_init): Remove unused variables r, g and b.
2496 (mouseDown): Remove unused variable window.
2497 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2498 (initFrameFromEmacs): Remove unused variable vbextra.
2499 (mouseEntered): Remove unused variables p and dpyinfo.
2500 (mouseExited): Remove unused variables p and r.
2501 (ns_define_frame_cursor, ns_clear_frame_area)
2502 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2503 (menuDown): Assign [sender tag] to variable and cast the variable.
2504
2505 * nsterm.h (menuDown): Add id as type to argument sender.
2506 (ns_display_info_for_name): Add Lisp_Object argument.
2507 (ns_term_init): Add Lisp_Object argument.
2508 (ns_map_event_to_object): Add void argument.
2509 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2510 prototype with arguments and only declare if __OBJC__.
2511 (nxatoms_of_nsselect): Add void argument.
2512 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2513 (ns_alloc_autorelease_pool): Add void argument.
2514 (ns_release_autorelease_pool): Add void* argument.
2515 (ns_get_defaults_value): Add const char* argument.
2516
2517 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2518 (initFromContents): Use SSDATA where appropriate.
2519 (ns_update_menubar): Add braces to ambigous if-else.
2520 (initWithTitle): Put () around assignment in if statement.
2521 (ns_menu_show): Remove unused variables window and keymap.
2522 (update_frame_tool_bar): Remove unused variable selected_p.
2523 (initWithContentRect): Remove unused variable this_cmd_name.
2524
2525 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2526 appropriate.
2527 (setXBMColor): Remove unused variable len.
2528 (setPixmapData): Put () around assignment in loop statement.
2529
2530 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2531 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2532 where appropriate.
2533 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2534 around assignment in loop statement.
2535 (nsfont_open): Remove unused variable i.
2536 (nsfont_open): Remove unused variable len.
2537 (nsfont_draw): Remove unused variable cs.
2538
2539 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2540 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2541 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2542 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2543 (Fns_font_name, Fns_perform_service)
2544 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2545 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2546 (ns_set_name): Remove unused variable view.
2547 (x_set_menu_bar_lines): Remove unused variable olines.
2548 (x_set_tool_bar_lines): Remove unused variable root_window.
2549 (Fns_list_colors): Put () around assignment in while statement.
2550 (Fns_perform_service): Remove unused variable len.
2551 (Fns_display_usable_bounds): Remove unused variable top.
2552 (syms_of_nsfns): Remove unused variable i.
2553
b55b9f85
JD
2554 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2555 memcpy (Bug#11907).
2556
ed9265fc 25572012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2558
2559 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2560 and free it with DestroyExceptionInfo (Bug#11558).
2561
ef099b57
JB
25622012-07-13 Juanma Barranquero <lekktu@gmail.com>
2563
2564 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2565 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2566 Set here, not in nt/config.nt.
2567
ea814a5d
EZ
25682012-07-13 Eli Zaretskii <eliz@gnu.org>
2569
2570 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
2571 cursor overflow into the last glyph on display line when the right
2572 fringe is off. (Bug#11832)
2573
1a952767
PE
25742012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 * xdisp.c (produce_special_glyphs): Now static.
2577 * dispextern.h (produce_special_glyphs): Remove decl.
2578
983188fd
GM
25792012-07-13 Glenn Morris <rgm@gnu.org>
2580
8d7c7eed 2581 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
2582 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
2583
983188fd
GM
2584 * s/usg5-4-common.h (USG, USG5):
2585 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
2586 * s/sol2-6.h (SOLARIS2):
2587 * s/irix6-5.h (IRIX6_5):
2588 * s/hpux10-20.h (USG, USG5, HPUX):
2589 * s/gnu-linux.h (USG, GNU_LINUX):
2590 * s/freebsd.h (BSD_SYSTEM):
2591 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
2592 * s/cygwin.h (CYGWIN):
2593 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
2594 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
2595
d1e68667 25962012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2597
2598 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2599
6de0e799
GM
26002012-07-13 Glenn Morris <rgm@gnu.org>
2601
739ae010
GM
2602 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2603
dbee5793
GM
2604 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2605
6de0e799
GM
2606 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2607 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2608
b82da769
GM
26092012-07-12 Glenn Morris <rgm@gnu.org>
2610
4fae5a7a 2611 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2612
2613 * process.c (init_process_emacs): Rename from init_process.
2614 The old name is also the name of a Mach system call.
2615 * lisp.h, emacs.c: Update for this name change.
2616 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2617 longer needed.
2618
5a979817
EZ
26192012-07-12 Eli Zaretskii <eliz@gnu.org>
2620
2621 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2622 memmove call that removes glyphs covered by the left truncation
2623 glyph. Improve commentary.
2624 (display_line): Fix display of continuation glyphs on GUI frames
2625 when the right fringe is turned off and variable-size fonts are
2626 used in the window. Move the code that appends a stretch glyph to
2627 produce_special_glyphs, so that it could be used for truncation
2628 and continuation glyphs alike.
2629 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2630 glyph of a suitably computed width, to align the special glyphs at
2631 the window margin. Code moved from display_line. (Bug#11832)
2632
3e91a053
GM
26332012-07-12 Glenn Morris <rgm@gnu.org>
2634
ba9e4b84
GM
2635 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2636
2637 * s/gnu-linux.h, s/hpux10-20.h:
2638 Do not unconditionally define HAVE_XRMSETDATABASE.
2639
3e91a053
GM
2640 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2641
b300b1f4
PE
26422012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 Fix typos that broke OS X build.
2645 Reported by Randal L. Schwartz in
2646 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2647 * nsterm.m (ns_timeout): Add missing local decl.
2648 (ns_get_color): snprintf -> sprintf, to fix typo.
2649
6e777848
GM
26502012-07-12 Glenn Morris <rgm@gnu.org>
2651
3f922c37
GM
2652 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2653 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2654 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2655 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2656
0ab7b23a
GM
2657 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2658 Move PTY_OPEN to configure.
2659
6e777848
GM
2660 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2661 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2662 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2663
4a7edc24
DA
26642012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2665
2666 Use empty_unibyte_string where applicable.
2667 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2668 * lread.c (read1): Likewise.
2669 * xsettings.c (syms_of_xsettings): Likewise.
2670
308aab79
GM
26712012-07-12 Glenn Morris <rgm@gnu.org>
2672
42bd1719
GM
2673 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2674 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2675 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2676 * s/hpux10-20.h (RUN_TIME_REMAP):
2677 * s/bsd-common.h (TABDLY): Move to configure.
2678
2679 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2680
2681 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2682
ea0bbd17 2683 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2684 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2685
2686 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2687
308aab79
GM
2688 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2689 * s/template.h: Move NARROWPROTO to configure.
2690
ee1cf5cf
GM
26912012-07-11 Glenn Morris <rgm@gnu.org>
2692
30fe9bf4
GM
2693 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2694 unused since 2011-01-17 change to systty.h.
2695
ee1cf5cf
GM
2696 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2697 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2698 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2699
63e47e07
PE
27002012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2701
2702 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2703
c43fb4c3
GM
27042012-07-11 Glenn Morris <rgm@gnu.org>
2705
2706 * s/darwin.h, s/gnu-linux.h, s/template.h:
2707 Move INTERRUPT_INPUT to configure.
2708
e8df9267
DA
27092012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2710
2711 Minor adjustments to interning code.
2712 * lisp.h (intern, intern_c_string): Redefine as static inline
2713 wrappers for intern_1 and intern_c_string_1, respectively.
2714 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2715 * lread.c (intern_1, intern_c_string_1, oblookup):
2716 Simplify Vobarray checking.
e8df9267
DA
2717 * font.c (font_intern_prop): Likewise. Adjust comment.
2718 * w32font.c (intern_font_name): Likewise.
2719
34348bd4
AS
27202012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2721
d96a1e0c
AS
2722 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2723
34348bd4
AS
2724 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2725 of Fcar/Fcdr if possible.
2726 * font.c (check_otf_features): Likewise.
2727 * fontset.c (Fnew_fontset): Likewise.
2728 * gnutls.c (Fgnutls_boot): Likewise.
2729 * minibuf.c (read_minibuf): Likewise.
2730 * msdos.c (IT_set_frame_parameters): Likewise.
2731 * xmenu.c (Fx_popup_dialog): Likewise.
2732 * w32menu.c (Fx_popup_dialog): Likewise.
2733
c8add24e
GM
27342012-07-11 Glenn Morris <rgm@gnu.org>
2735
4b575b3c
GM
2736 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2737 since nothing has defined it on these platforms.
2738
09f4e3b0
GM
2739 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2740 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2741
172bedef
GM
2742 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2743 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2744 Move CLASH_DETECTION to configure.
2745
249685df
GM
2746 * s/gnu.h: Remove file, which is now empty.
2747
c8add24e
GM
2748 * s/gnu.h, s/gnu-linux.h:
2749 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2750
b41253a3
JW
27512012-07-11 John Wiegley <johnw@newartisans.com>
2752
2753 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2754 function attribute, so we only use it if it exists in the
2755 compiler.
2756
d923b542
DA
27572012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2758
2759 Avoid call to strlen in fast_c_string_match_ignore_case.
2760 * search.c (fast_c_string_match_ignore_case): Change to use
2761 length argument. Adjust users accordingly.
2762 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2763
5ebbef1d
PE
27642012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2765
bb352260
PE
2766 Assume mkdir, rmdir.
2767 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2768 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2769
57054ddd
PE
2770 Assume rename.
2771 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2772
b747d3f7
PE
2773 Assume perror.
2774 * s/hpux10-20.h (HAVE_PERROR): Remove.
2775 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2776 Remove dummy definition, as this problem was obsolete long ago.
2777
5ebbef1d
PE
2778 Assume strerror.
2779 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2780
984e7f30
DA
27812012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2782
2783 Avoid calls to strlen in font processing functions.
2784 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2785 (font_open_by_name): Change to use length argument.
2786 Adjust users accordingly.
d923b542
DA
2787 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2788 Adjust prototypes.
2789 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2790 Change to return ptrdiff_t.
984e7f30
DA
2791 (xfont_list_pattern, xfont_match): Use length returned by
2792 xfont_decode_coding_xlfd.
2793 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2794
20e94fdd
GM
27952012-07-11 Glenn Morris <rgm@gnu.org>
2796
9d596af3
GM
2797 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2798 Move DONT_REOPEN_PTY to configure.
2799
20e94fdd
GM
2800 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2801 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2802
e99a530f
PE
28032012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2804
22ffb973
PE
2805 Remove "#define unix" that is no longer needed (Bug#11905).
2806 * s/aix4-2.h (unix): Remove; no longer needed.
2807
e9a9ae03
PE
2808 EMACS_TIME simplification (Bug#11875).
2809 This replaces macros (which typically do not work in GDB)
2810 with functions, typedefs and enums, making the code easier to debug.
2811 The functional style also makes code easier to read and maintain.
2812 * systime.h: Include <sys/time.h> on all hosts, not just if
2813 WINDOWSNT, since 'struct timeval' is needed in general.
2814 (EMACS_TIME): Now a typedef, not a macro.
2815 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2816 not macros.
2817 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2818 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2819 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2820 (EMACS_TIME_LE): Now functions, not macros.
2821 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2822 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2823 which are not functions. All uses rewritten to use:
2824 (make_emacs_time): New function.
2825 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2826 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2827 not functions. All uses rewritten to use the following, respectively:
2828 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2829 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2830 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2831 * fileio.c (Fcopy_file):
2832 * xterm.c (XTflash): Get the current time closer to when it's used.
2833 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2834
ffacb126
PE
2835 * bytecode.c (targets): Suppress -Woverride-init warnings.
2836
e99a530f
PE
2837 Simplify by avoiding confusing use of strncpy etc.
2838 * doc.c (Fsnarf_documentation):
2839 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2840 * frame.c (Fmake_terminal_frame):
2841 * gtkutil.c (get_utf8_string):
2842 * lread.c (openp):
2843 * nsmenu.m (ns_update_menubar):
2844 * regex.c (regerror):
2845 Prefer memcpy to strncpy and strncat when either will do.
2846 * fileio.c (Fsubstitute_in_file_name):
2847 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2848 (menu_separator_name_p):
2849 * nsmenu.m (ns_update_menubar):
2850 Prefer memcmp to strncmp when either will do.
2851 * nsterm.m: Include <ftoastr.h>.
2852 (ns_get_color):
2853 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2854 Prefer snprintf to strncpy.
2855 * nsterm.m (ns_term_init):
2856 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2857 * nsterm.m (ns_term_init):
2858 Avoid the need for strncpy, by using build_string or
2859 make_unibyte_string directly. Use dtoastr, not snprintf.
2860 * process.c (Fmake_network_process): Diagnose service names that
2861 are too long, rather than silently truncating them or creating
2862 non-null-terminated names.
2863 (Fnetwork_interface_info): Likewise, for interface names.
2864 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2865 Prefer sprintf to strncat.
2866 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2867 Prefer vsnprintf to vsprintf + strncpy.
2868
c59592b3
GM
28692012-07-10 Glenn Morris <rgm@gnu.org>
2870
2871 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2872 Clarify fallback case.
2873
7d7bbefd
DA
28742012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2875
2876 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2877 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2878 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2879 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2880 where argument type is known to be a Lisp_Cons.
2881
3a4c8000
TT
28822012-07-10 Tom Tromey <tromey@redhat.com>
2883
2884 * bytecode.c (BYTE_CODE_THREADED): New macro.
2885 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2886 (enum byte_code_op): New type.
2887 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2888 (exec_byte_code): Use them. Use token threading when applicable.
2889
2a0213a6
DA
28902012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2891
2892 Optimize pure C strings initialization.
2893 * lisp.h (make_pure_string): Fix prototype.
2894 (build_pure_c_string): New function, defined as static inline. This
2895 provides a better opportunity to optimize away calls to strlen when
2896 the function is called with compile-time constant argument.
2897 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2898 argument, adjust users accordingly. Use build_pure_c_string where
2899 appropriate.
2900 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2901 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2902 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2903
cb1caeaf
DA
29042012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2905
2906 Avoid calls to strlen in miscellaneous functions.
2907 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2908 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2909 * lread.c (openp): Likewise.
2910
c293e30c
DA
29112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2912
2913 Avoid calls to strlen in path processing functions.
2914 * fileio.c (file_name_as_directory): Add comment. Change to add
2915 srclen argument and return the length of result. Adjust users
2916 accordingly.
2917 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2918 swap 1st and 2nd arguments to obey the common convention.
2919 Adjust users accordingly.
c293e30c
DA
2920 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2921
9e059e3f
GM
29222012-07-10 Glenn Morris <rgm@gnu.org>
2923
d02eb359
GM
2924 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2925 Move PENDING_OUTPUT_COUNT definition to configure.
2926
882cf227
GM
2927 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2928 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2929 * s/gnu.h (DATA_START): Move definitions to configure.
2930
af6e839f
GM
2931 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2932 We include usg5-4-common.h, which defines them both.
2933
40289a12
GM
2934 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2935 O_RDONLY already includes it).
2936
9e059e3f
GM
2937 Stop ns builds setting the EMACSLOADPATH environment variable.
2938 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2939 Now it does not set EMACSLOADPATH, just returns the load-path string.
2940 * nsterm.h: Update accordingly.
2941 * lread.c [HAVE_NS]: Include nsterm.h.
2942 (init_lread) [HAVE_NS]: Use ns_load_path.
2943 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2944
7c4e8ec0
GM
29452012-07-09 Glenn Morris <rgm@gnu.org>
2946
d4f600ff
GM
2947 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2948 since the included bsd-common.h does so.
2949
cbb31951
GM
2950 Stop ns builds setting the EMACSPATH environment variable.
2951 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2952 (ns_init_paths): Do not set EMACSPATH.
2953 * nsterm.h (ns_exec_path): Add it.
2954 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2955 Use ns_exec_path.
2956
7c4e8ec0
GM
2957 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2958
26bccfae
PE
29592012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2960
a0bee46f
PE
2961 * process.c (wait_reading_process_output): 'waitchannels' was unset
2962 when read_kbd || !NILP (wait_for_cell); fix this.
2963
5994c183
PE
2964 Add GCC-style 'const' attribute to functions that can use it.
2965 * character.h (char_resolve_modifier_mask):
2966 * keyboard.h (make_ctrl_char):
2967 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2968 (init_character_once, next_almost_prime, init_fns, init_image)
2969 (flush_pending_output, init_sound):
2970 * mem-limits.h (start_of_data):
2971 * menu.h (finish_menu_items):
2972 Add ATTRIBUTE_CONST.
2973 * emacs.c (DEFINE_DUMMY_FUNCTION):
2974 Declare the dummy function with ATTRIBUTE_CONST.
2975 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2976 Add decls with ATTRIBUTE_CONST.
2977
26bccfae
PE
2978 Minor improvements to make_formatted_string.
2979 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2980 where int is good enough, as vsprintf returns an int.
2981 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2982
a8290ec3
DA
29832012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2984
2985 Use make_formatted_string to avoid double length calculation.
2986 * lisp.h (make_formatted_string): New prototype.
2987 * alloc.c (make_formatted_string): New function.
2988 * buffer.c (Fgenerate_new_buffer_name): Use it.
2989 * dbus.c (syms_of_dbusbind): Likewise.
2990 * editfns.c (Fcurrent_time_zone): Likewise.
2991 * filelock.c (get_boot_time): Likewise.
2992 * frame.c (make_terminal_frame, set_term_frame_name)
2993 (x_report_frame_params): Likewise.
2994 * image.c (gs_load): Likewise.
2995 * minibuf.c (get_minibuffer): Likewise.
2996 * msdos.c (dos_set_window_size): Likewise.
2997 * process.c (make_process): Likewise.
2998 * xdisp.c (ensure_echo_area_buffers): Likewise.
2999 * xsettings.c (apply_xft_settings): Likewise.
3000
d01ba2f1
GM
30012012-07-09 Glenn Morris <rgm@gnu.org>
3002
3003 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
3004 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
3005 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
3006 * nsterm.h (ns_etc_directory): Add it.
3007 * callproc.c [HAVE_NS]: Include nsterm.h.
3008 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
3009
f1f924b6
DA
30102012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3011
3012 Move marker debugging code under MARKER_DEBUG.
3013 * marker.c (MARKER_DEBUG): Move marker debugging code under
3014 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
3015 for bootstrap with --enable-checking (~3x slowdown reported
3016 by Juanma Barranquero <lekktu@gmail.com>).
3017 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
3018
ab531b66
PE
30192012-07-08 Paul Eggert <eggert@cs.ucla.edu>
3020
3021 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
3022 See <http://bugs.gnu.org/11825#29>.
3023
c4b3bc8a
EZ
30242012-07-08 Eli Zaretskii <eliz@gnu.org>
3025
3026 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
3027 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
3028 (display_line): Add commentary about displaying truncation glyphs
3029 on GUI frames.
3030 (produce_special_glyphs): Move here from term.c.
3031
3032 * term.c (produce_special_glyphs): Move to xdisp.c.
3033
3034 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
3035 section.
c4b3bc8a 3036
b676b881
AS
30372012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3038
f17c5273
AS
3039 * xdisp.c (display_line): Avoid warning about implicit declaration
3040 of FRAME_FONT.
3041
298819b9
AS
3042 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
3043
b676b881
AS
3044 * lisp.h: Remove empty conditional.
3045
6045c4fd
PE
30462012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3047
b3350bf9
PE
3048 * lread.c (load_path_check): Now static.
3049
6045c4fd
PE
3050 Fix some minor --with-ns problems found by static checking.
3051 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
3052 (x_set_font) [!HAVE_X_WINDOWS]:
3053 * image.c (xpm_load_image) [HAVE_NS]:
3054 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
3055 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
3056 Remove unused local.
3057 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
3058 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
3059 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
3060 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
3061 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
3062 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
3063 Fix pointer signedness problem.
3064 * xfaces.c (FRAME_X_FONT_TABLE):
3065 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
3066
929e7845
GM
30672012-07-07 Glenn Morris <rgm@gnu.org>
3068
3069 * lread.c (load_path_check): New function, split from init_lread.
3070 (init_lread): Reorganize. Motivation:
3071 If EMACSLOADPATH is set, check/warn about that rather than the
3072 defaults, which we are not going to use. Hence we can remove
3073 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
3074 Don't warn if site-lisp directories are missing.
3075 If not installed, start from a blank load-path, since
3076 PATH_LOADSEARCH refers to the eventual installation directories.
3077
58dd0aa4
EZ
30782012-07-07 Eli Zaretskii <eliz@gnu.org>
3079
3080 Support truncation and continuation glyphs on GUI frames, when
3081 fringes are disabled. (Bug#11832)
3082 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
3083 continuation glyphs even if on GUI frames.
3084 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
3085 or both, are absent.
3086 (start_display, move_it_in_display_line_to): Handle the case of a
3087 GUI frame without a fringe to display continuation or truncation
3088 glyphs.
3089 (insert_left_trunc_glyphs): Support GUI frames: make sure
3090 truncation glyphs overwrite enough glyphs from the current line to
3091 have sufficient space in pixels.
3092 (display_line): Support truncation and continuation glyphs on GUI
3093 frames. If some spare pixels are left on the line after inserting
3094 the truncation glyphs, fill that space with a stretch glyph of a
3095 suitably computed width.
3096
3097 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
3098 produce_glyphs, to support GUI sessions.
3099
31571fd7
PE
31002012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3101
5a16b9bc
PE
3102 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
3103
f3047c75
PE
3104 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
3105
31571fd7
PE
3106 Do not require float-time's arg to fit in time_t (Bug#11825).
3107 This works better on hosts where time_t is unsigned, and where
3108 float-time is applied to the (negative) difference between two times.
3109 * editfns.c (decode_time_components): Last arg is now double *,
3110 not int *, and means to store all the result as a double, without
3111 worrying about whether the seconds part fits in time_t.
3112 All callers changed.
3113 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
3114 All callers changed.
3115 (Ffloat_time): Do not fail merely because the specified time falls
3116 outside of time_t range.
3117
4516fbef
GM
31182012-07-07 Glenn Morris <rgm@gnu.org>
3119
3120 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
3121 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
3122 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
3123
07adc2c6
JB
31242012-07-07 Juanma Barranquero <lekktu@gmail.com>
3125
3126 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
3127 Update dependencies.
3128
3129 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
3130
fd573f31
PE
31312012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3132
fee5959d
PE
3133 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
3134 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
3135 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
3136 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
3137 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
3138 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
3139
fd573f31
PE
3140 * xfont.c (compare_font_names): Redo to omit the need for casts.
3141
ddadbc0e
AS
31422012-07-06 Andreas Schwab <schwab@linux-m68k.org>
3143
fca8d6b6
AS
3144 * xfns.c (Fx_change_window_property): Doc fix.
3145 * w32fns.c (Fx_change_window_property): Doc fix.
3146
ddadbc0e
AS
3147 * w32fns.c (Fx_window_property): Accept the same arguments as the
3148 X Windows version. Doc fix.
3149 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
3150
ed9265fc 31512012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
3152 Eli Zaretskii <eliz@gnu.org>
3153
3154 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
3155 Windows-specific code from nt/config.nt moved here.
3156 Obsolete settings removed.
3157
216ee680
PE
31582012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 * process.c: Avoid unnecessary calls to gettime.
3161 (wait_reading_process_output): Don't get the time of day
3162 when gobbling data immediately and not waiting, as there's no need
3163 for it in that case. This removes a FIXME.
3164
bdd091e4
JD
31652012-07-06 Jan Djärv <jan.h.d@swipnet.se>
3166
3167 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
3168 is defined (Bug#11768).
3169
9d44f8ce
DA
31702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3171
3172 Fix marker debugging code.
3173 * marker.c (byte_char_debug_check): Do not perform the check
3174 if buffer is not multibyte.
090bd7cb
JB
3175 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3176 Call byte_char_debug_check with correct arguments.
9d44f8ce 3177
90fc4786
DA
31782012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3179
3180 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
3181 * marker.c (byte_char_debug_check, count_markers):
3182 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
3183 (byte_debug_flag): Remove.
3184 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3185 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
3186
7b7ae965
DA
31872012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3188
4e57b342
DA
3189 Avoid code repetition in marker-related functions.
3190 * marker.c (attach_marker): New function.
3191 (Fset_marker, set_marker_restricted, set_marker_both)
3192 (set_marker_restricted_both): Use it.
3193 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
3194 Consistently rename charno to charpos.
3195 (marker_position): Add eassert.
3196 (marker_byte_position): Convert to eassert.
3197
31982012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3199
3200 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 3201 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 3202 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 3203
657924ff
DA
32042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3205
3206 Introduce fast path for the widely used marker operation.
3207 * alloc.c (build_marker): New function.
3208 * lisp.h (build_marker): New prototype.
3209 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
3210 * composite.c (autocmp_chars): Likewise.
3211 * editfns.c (buildmark): Remove.
3212 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
3213 (save_restriction_save): Use build_marker.
3214 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
3215 * window.c (save_window_save): Likewise.
3216
041a49a6
DA
32172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3218
3219 Do not use Fdelete_overlay in delete_all_overlays
3220 to avoid redundant calls to unchain_overlay.
3221 * buffer.c (drop_overlay): New function.
3222 (delete_all_overlays, Fdelete_overlay): Use it.
3223 * minibuf.c (get_minibuffer): Fix comment.
3224
7dca65a4
PE
32252012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 Port to OpenBSD 5.1 amd64.
3228 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
3229 This is needed for OpenBSD, and should be harmless on all BSD systems.
3230 Also, include <sys/sysctl.h>, as it should be available on all
3231 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
3232 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
3233 use p_pid member, not kp_proc.pid.
3234
8eb876e2
GM
32352012-07-06 Glenn Morris <rgm@gnu.org>
3236
3237 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
3238
38182d90
PE
32392012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3240
3241 More xmalloc and related cleanup.
3242 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
3243 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
3244 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
3245 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
3246 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
3247 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
3248 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
3249 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
3250 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
3251 * xterm.c:
3252 Omit needless casts involving void * pointers and allocation.
3253 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
3254 as the former is more robust if P's type is changed.
3255 Prefer xzalloc to xmalloc + memset 0.
3256 Simplify malloc-or-realloc to realloc.
3257 Don't worry about xmalloc returning a null pointer.
3258 Prefer xstrdup to xmalloc + strcpy.
3259 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
3260 growing it.
3261 * keyboard.c (apply_modifiers_uncached): Prefer local array to
3262 alloca of a constant.
3263
6dd5a677
EZ
32642012-07-05 Eli Zaretskii <eliz@gnu.org>
3265
3266 * xdisp.c (display_line): Fix horizontal pixel coordinates when
3267 hscroll is larger than the line width. Fixes long and futile
3268 looping inside extend_face_to_end_of_line (on a TTY) producing
3269 glyphs that are not needed and thrown away.
3270
6b312f0f
DA
32712012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3272
3273 * marker.c (set_marker_restricted_both): Simplify by using
3274 clip_to_bounds.
3275
f520ef9b
PE
32762012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3277
3278 * editfns.c (region_limit): Simplify by using clip_to_bounds.
3279
383b7c95
JD
32802012-07-05 Jan Djärv <jan.h.d@swipnet.se>
3281
3282 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
3283 not defined (Bug#11768).
3284 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
3285 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
3286 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
3287 followed by gtk_box_set_homogeneous (Bug#11768).
3288 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
3289 (update_theme_scrollbar_width, xg_create_scroll_bar):
3290 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
3291 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
3292 (is_box_type): New function (Bug#11768).
3293 (xg_tool_item_stale_p): Call is_box_type.
5293d758 3294 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
3295 with default display (Bug#11768).
3296
d6e7bf45
EZ
32972012-07-05 Eli Zaretskii <eliz@gnu.org>
3298
3299 * xdisp.c (window_hscroll_limited): New function.
3300 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
3301 coordinates when window's hscroll is set to insanely large
3302 values. (Bug#11857)
3303
431391ec
JB
33042012-07-05 Juanma Barranquero <lekktu@gmail.com>
3305
3306 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
3307 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
3308
23f86fce
DA
33092012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3310
3311 Cleanup xmalloc.
3312 * lisp.h (xzalloc): New prototype. Omit needless casts.
3313 * alloc.c (xzalloc): New function. Omit needless casts.
3314 * charset.c: Omit needless casts. Convert all calls to
3315 xmalloc with following memset to xzalloc.
3316 * dispnew.c: Likewise.
3317 * fringe.c: Likewise.
3318 * image.c: Likewise.
3319 * sound.c: Likewise.
3320 * term.c: Likewise.
3321 * w32fns.c: Likewise.
3322 * w32font.c: Likewise.
3323 * w32term.c: Likewise.
3324 * xfaces.c: Likewise.
3325 * xfns.c: Likewise.
3326 * xterm.c: Likewise.
3327 * atimer.c: Omit needless casts.
3328 * buffer.c: Likewise.
3329 * callproc.c: Likewise.
3330 * ccl.c: Likewise.
3331 * coding.c: Likewise.
3332 * composite.c: Likewise.
3333 * doc.c: Likewise.
3334 * doprnt.c: Likewise.
3335 * editfns.c: Likewise.
3336 * emacs.c: Likewise.
3337 * eval.c: Likewise.
3338 * filelock.c: Likewise.
3339 * fns.c: Likewise.
3340 * gtkutil.c: Likewise.
3341 * keyboard.c: Likewise.
3342 * lisp.h: Likewise.
3343 * lread.c: Likewise.
3344 * minibuf.c: Likewise.
3345 * msdos.c: Likewise.
3346 * print.c: Likewise.
3347 * process.c: Likewise.
3348 * region-cache.c: Likewise.
3349 * search.c: Likewise.
3350 * sysdep.c: Likewise.
3351 * termcap.c: Likewise.
3352 * terminal.c: Likewise.
3353 * tparam.c: Likewise.
3354 * w16select.c: Likewise.
3355 * w32.c: Likewise.
3356 * w32reg.c: Likewise.
3357 * w32select.c: Likewise.
3358 * w32uniscribe.c: Likewise.
3359 * widget.c: Likewise.
3360 * xdisp.c: Likewise.
3361 * xmenu.c: Likewise.
3362 * xrdb.c: Likewise.
3363 * xselect.c: Likewise.
3364
0497dc44
PE
33652012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3366
3367 * fileio.c (time_error_value): Check the right error number.
3368 Problem reported by Troels Nielsen in
3369 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
3370
356e7178
PE
33712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3372
4e71fd89
PE
3373 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
3374 This should be fixed in a better way; see Eli Zaretskii in
3375 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
3376 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
3377
f0941253
PE
3378 * fileio.c (time_error_value): Rename from special_mtime.
3379 The old name's problems were noted by Eli Zaretskii in
3380 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3381
065c9eb4
PE
3382 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3383 This variable's comment says Emacs needs at least one GDB-visible
3384 symbol of type enum pvec_type, to work around GDB problems.
3385 The symbol's value doesn't matter.
3386
356e7178
PE
3387 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3388 that causes compilation to fail on pre-C99 compilers.
3389
ed9265fc 33902012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3391
3392 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3393 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3394
3884d954
DA
33952012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3396
d209e2fb 3397 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3398 headers for buffer_defaults and buffer_local_symbols.
3399 Reported by Juanma Barranquero <lekktu@gmail.com>.
3400
ee28be33
SM
34012012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3402
3403 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3404 * lisp.h (enum pvec_type): Use fewer bits.
3405 (PSEUDOVECTOR_SIZE_BITS): New constant.
3406 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3407 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3408 change in pvec_type.
3409 (PSEUDOVECTOR_TYPEP): New macro.
3410 (TYPED_PSEUDOVECTORP): Use it.
3411 * fns.c (internal_equal): Adapt code to extract pvectype.
3412 * emacs.c (gdb_pvec_type): Update type.
3413 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3414 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3415 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3416 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3417 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3418 abusing vector->header.next.nbytes.
3419 (live_vector_p): Use PVEC_TYPE.
3420 (mark_object): Adapt code to extract pvectype. Use switch.
3421
c7f2cd7f
PE
34222012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3423
3424 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3425 Tighten new eassert a bit.
3426
8ce70ed2
DA
34272012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3428
3429 Fix compilation with --enable-gcc-warnings and -O1
3430 optimization level.
3431 * doprnt.c (doprnt): Change type of tem to int, initialize
3432 to avoid compiler warning. Add eassert.
3433 * search.c (simple_search): Initialize match_byte to avoid
3434 compiler warning. Add eassert.
3435
dea7f1e5
PE
34362012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3437
24a212eb
PE
3438 Avoid weird behavior with large horizontal scrolls.
3439 Without this change, for example, large hscroll values would
3440 mess up Emacs's display on Fedora 15 x86, presumably due to
3441 overflows in int calculations in the display code.
3442 Also, if buffers had long lines, Emacs would freeze.
3443 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3444 (set_window_hscroll): New function, containing the old guts of
3445 Fset_window_hscroll. Return the clipped value.
3446 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3447 This avoids the need to check against PTRDIFF_MAX.
3448
dea7f1e5
PE
3449 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3450
76046526
DA
34512012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3452
3453 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3454
39adff0d
PE
34552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3456
63807d47
PE
3457 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3458 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3459 since GCC 4.4.6 issues a bogus warning for them.
3460
39adff0d
PE
3461 Fix bugs in file timestamp newness comparisons.
3462 * fileio.c (Ffile_newer_than_file_p):
3463 * lread.c (Fload): Use full timestamp resolution of files,
3464 not just the 1-second resolution, so that files that are only
3465 slightly newer still count as newer.
3466 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3467 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3468
dbeed9a6
PE
34692012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3470
3471 * fileio.c: Improve handling of file time marker. (Bug#11852)
3472 (special_mtime): New function.
3473 (Finsert_file_contents, Fverify_visited_file_modtime):
3474 Use it to set special mtime values consistently.
3475
636334d6
AS
34762012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3477
3478 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3479 marker for non-existing file. (Bug#11852)
3480
e2017fe2
GM
34812012-07-03 Glenn Morris <rgm@gnu.org>
3482
3483 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3484 and did not make it into globals.h).
3485
404dbd37
TT
34862012-07-03 Tom Tromey <tromey@redhat.com>
3487
3488 * window.c (Fset_window_margins, Fset_window_fringes)
3489 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3490 * textprop.c (Fprevious_property_change): No longer static.
3491 * syntax.c (Fsyntax_table_p): No longer static.
3492 * process.c (Fget_process, Fprocess_datagram_address): No longer
3493 static.
3494 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3495 * keyboard.c (Fcommand_execute): No longer static.
3496 Remove EXFUN.
3497 * insdel.c (Fcombine_after_change_execute): No longer static.
3498 * image.c (Finit_image_library): No longer static.
3499 * fileio.c (Fmake_symbolic_link): No longer static.
3500 * eval.c (Ffetch_bytecode): No longer static.
3501 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3502 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3503 No longer static.
404dbd37
TT
3504 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3505 static.
3506 * dired.c (Ffile_attributes): No longer static.
3507 * composite.c (Fcomposition_get_gstring): No longer static.
3508 * callproc.c (Fgetenv_internal): No longer static.
3509
3510 * ccl.h: Remove EXFUNs.
3511 * buffer.h: Remove EXFUNs.
3512 * dispextern.h: Remove EXFUNs.
3513 * intervals.h: Remove EXFUNs.
3514 * fontset.h: Remove EXFUN.
3515 * font.h: Remove EXFUNs.
3516 * dosfns.c (system_process_attributes): Remove EXFUN.
3517 * keymap.h: Remove EXFUNs.
3518 * lisp.h: Remove EXFUNs.
3519 * w32term.h: Remove EXFUNs.
3520 * window.h: Remove EXFUNs.
3521 * xsettings.h: Remove EXFUN.
3522 * xterm.h: Remove EXFUN.
3523
8e4fd1e1
GM
35242012-07-03 Glenn Morris <rgm@gnu.org>
3525
3526 * lisp.h (Frandom): Make it visible to C.
3527 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3528 buffer for invisible buffers. (Bug#1229)
3529
ca95b3eb
DA
35302012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3531
3532 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3533 values which aren't power of 2.
14ae4239
BT
3534 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3535 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3536 accordingly.
3537
7555c33f
SM
35382012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3539
3540 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3541
3542 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3543
d12e8f5a
DA
35442012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3545
3546 * alloc.c (allocate_vector_block): Remove redundant
3547 calls to mallopt if DOUG_LEA_MALLOC is defined.
3548 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3549 avoid calls to mallopt if zero_vector is returned.
3550
296094c3
DA
35512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3552
3553 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3554 is enabled, avoid dereferencing NULL current_sblock if
3555 running undumped.
3556
36429c89
DA
35572012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3558
3559 Cleanup basic buffer management.
3560 * buffer.h (struct buffer): Change layout to use generic vector
3561 marking code. Fix some comments. Change type of 'clip_changed'
3562 to bitfield. Remove unused #ifndef old.
3563 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3564 (GET_OVERLAYS_AT): Fix indentation.
3565 (for_each_per_buffer_object_at): New macro.
3566 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3567 (Fbuffer_local_variables): Use it.
3568 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
3569 * alloc.c (allocate_buffer): Adjust to match new layout of
3570 struct buffer. Fix comment.
3571 (mark_overlay): New function.
3572 (mark_buffer): Use it. Use mark_vectorlike to mark normal
3573 Lisp area of struct buffer.
3574 (mark_object): Use it. Adjust marking of misc objects
3575 and related comments.
3576
3b3e4cac
PE
35772012-07-02 Paul Eggert <eggert@cs.ucla.edu>
3578
3579 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
3580 wrapper that is not needed because the wrapped code is a no-op (zero
3581 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
3582 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
3583
cf5c0175
DA
35842012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
3585
3586 * alloc.c (mark_buffer): Simplify. Remove prototype.
3587 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 3588 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
3589 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
3590 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 3591
ca26824c
GM
35922012-06-30 Glenn Morris <rgm@gnu.org>
3593
2e4c5312
GM
3594 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
3595
ca26824c
GM
3596 * epaths.in (PATH_SITELOADSEARCH): New.
3597 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3598 This is rather than relying on --enable-locallisppath elements
3599 having "site-lisp" in their names. (Bug#10208#25, 11658)
3600
0d23c240
EZ
36012012-06-30 Eli Zaretskii <eliz@gnu.org>
3602
c9240d7a
EZ
3603 * w32proc.c (sys_select): Accept and ignore one more argument.
3604
3605 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3606
0d23c240 3607 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3608 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3609
3610 * sysdep.c: Don't include dos.h and dosfns.h.
3611
3612 * process.c (sys_select):
3613 * msdos.c (sys_select): Accept one more argument and ignore it.
3614
3615 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3616 adapt data types and code to that.
3617
3618 * dosfns.c:
3619 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3620 which clashes with the gnulib function of the same name.
3621
af5a5a98
AS
36222012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3623
c5e4379c
AS
3624 * font.c (font_style_to_value, font_style_symbolic)
3625 (font_prop_validate_style): Add type checks for values in
3626 font_style_table.
3627
af5a5a98
AS
3628 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3629 argument.
3630 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3631 uses.
3632
8d38f461
EZ
36332012-06-29 Eli Zaretskii <eliz@gnu.org>
3634
2e5a6631
EZ
3635 * xdisp.c (try_window_id): Undo last change.
3636
8d38f461
EZ
3637 * w32.c (getwd): Adjust commentary about startup_dir.
3638 (init_environment): Always call sys_access, even in non-MSVC
3639 builds. Don't chdir to the directory of the Emacs executable.
3640 This undoes code from 1997 which was justified by the need to
3641 "avoid conflicts when removing and renaming directories". But its
3642 downside was that every relative file name was being interpreted
3643 relative to the directory of the Emacs executable, which can never
3644 be TRT. In particular, it broke sys_access when called with
3645 relative file names.
3646 (sys_access): Map GetLastError to errno.
3647
2af3565e
DA
36482012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3649
3650 * window.h (struct window): Change type of 'fringes_outside_margins'
3651 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3652 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3653 Adjust comment.
3654 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3655 to ptrdiff_t.
3656
c8d3a25c 36572012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3658
c8d3a25c
GM
3659 * gnutls.c (emacs_gnutls_handshake):
3660 Add QUIT to make the loop interruptible.
57570cd3 3661
c8d3a25c 36622012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3663
c8d3a25c
GM
3664 * charset.c (init_charset): Make lack of etc/charsets fatal.
3665
3e984ee8
DA
36662012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3667
3668 * editfns.c (region_limit): Fix type mismatch.
3669
ef884f23
DA
36702012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3671
3672 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3673 undefined. Convert from xassert to eassert.
3674 * nsmenu.m: Convert from xassert to eassert.
3675 * nsterm.m: Likewise.
3676
7d7e0027
SM
36772012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3678
3679 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3680
aa754e6a
PE
36812012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 Avoid integer overflow on scroll-left and scroll-right.
3684 * window.c (HSCROLL_MAX): New macro.
3685 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3686 overflow when requested scroll falls outside ptrdiff_t range.
3687
80b00b08
DA
36882012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3689
3690 * window.h (struct window): Change type of 'hscroll',
3691 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3692 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3693 Adjust users accordingly.
3694 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3695 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3696 from EMACS_INT to ptrdiff_t.
3697 (make_window): Omit redundant initialization.
3698
62b2bcf6
JB
36992012-06-28 Juanma Barranquero <lekktu@gmail.com>
3700
3701 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3702
45942c7d
DA
37032012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3704
3705 * window.h (struct window): Change type of 'use_time' and
3706 'sequence_number' from Lisp_Object to int.
3707 * frame.c (make_frame): Adjust users accordingly.
3708 * print.c (print_object): Likewise.
3709 * window.c (select_window, Fwindow_use_time, make_parent_window)
3710 (make_window): Likewise.
3711
e509cfa6
DA
37122012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3713
3714 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3715 enabled with --enable-checking=[all,glyphs] configure option.
3716 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3717 adjust comments accordingly.
3718 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3719 undefined, adjust comments accordingly.
3720 * image.c: Likewise.
3721 * scroll.c: Likewise.
3722 * w32fns.c: Likewise.
3723 * w32term.c: Likewise.
3724 * xdisp.c: Likewise.
3725 * xfaces.c: Likewise.
3726 * xfns.c: Likewise.
3727 * xterm.c: Likewise.
3728
a54e2c05
DA
37292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3730
3731 Generalize run-time debugging checks.
3732 * dispextern.h (XASSERTS): Remove.
3733 * fontset.c (xassert): Remove.
3734 Convert from xassert to eassert.
3735 * alloc.c: Convert from xassert to eassert.
3736 * bidi.c: Likewise.
3737 * dispnew.c: Likewise.
3738 * fns.c: Likewise.
3739 * fringe.c: Likewise.
3740 * ftfont.c: Likewise.
3741 * gtkutil.c: Likewise.
3742 * image.c: Likewise.
3743 * keyboard.c: Likewise.
3744 * menu.c: Likewise.
3745 * process.c: Likewise.
3746 * scroll.c: Likewise.
3747 * sound.c: Likewise.
3748 * term.c: Likewise.
3749 * w32console.c: Likewise.
3750 * w32fns.c: Likewise.
3751 * w32term.c: Likewise.
3752 * window.c: Likewise.
3753 * xdisp.c: Likewise.
3754 * xfaces.c: Likewise.
3755 * xfns.c: Likewise.
3756 * xselect.c: Likewise.
3757 * xterm.c: Likewise.
3758
1ec4b7b2
SM
37592012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3760
3761 * fns.c (maybe_resize_hash_table): Output message when growing the
3762 purify-hashtable.
3763
2014308a
DA
37642012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3765
3766 * alloc.c (allocate_string_data): Remove dead code.
3767 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3768 avoid GCC warning about unused macro.
3769
246155eb
DA
37702012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3771
3772 * alloc.c (allocate_string): Omit intervals initialization.
3773 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3774 as in make_pure_string and make_pure_c_string.
3775
43184b7b
DA
37762012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3777
d209e2fb 3778 * alloc.c (allocate_string): Fix last change.
43184b7b 3779
3fe6dd74
DA
37802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3781
d209e2fb 3782 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3783 to memset, add explicit initialization where appropriate.
3784
1ba6038a
GM
37852012-06-27 Glenn Morris <rgm@gnu.org>
3786
3787 * lisp.mk (lisp): Remove paths.elc.
3788
c89926a5
CY
37892012-06-27 Chong Yidong <cyd@gnu.org>
3790
3791 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3792
ed6b3510
JW
37932012-06-26 John Wiegley <johnw@newartisans.com>
3794
1ec4b7b2 3795 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3796 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3797
ed6b3510
JW
3798 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3799 when building with Clang.
3800
8edd4a2b
SM
38012012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3802
3803 * eval.c (Fapply): Allow calling it with a single argument.
3804
f6f62d1b
EZ
38052012-06-26 Eli Zaretskii <eliz@gnu.org>
3806
3807 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3808 _stricmp and _strnicmp.
3809 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3810
62efea5e
DA
38112012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3812
3813 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3814 allocated window.
3815 (allocate_process): Likewise for new process.
8edd4a2b 3816 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3817 (allocate_frame): Likewise.
3818 * frame.c (make_frame): Omit redundant initialization.
3819 * window.c (make_parent_window): Use memset.
3820 (make_window): Omit redundant initialization.
3821 * process.c (make_process): Omit redundant initialization.
3822 * terminal.c (create_terminal): Likewise.
3823
42997f4d
DA
38242012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3825
3826 * term.c (delete_tty): Remove redundant call to memset.
3827
1130ecfc
DA
38282012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3829
3830 * alloc.c: Remove build_string.
3831 * lisp.h: Define build_string as static inline. This provides
3832 a better opportunity to optimize away calls to strlen when the
3833 function is called with compile-time constant argument.
3834 * image.c (imagemagick_error): Convert to build_string.
3835 * w32proc.c (sys_spawnve): Likewise.
3836 * xterm.c (x_term_init): Likewise.
3837
cf38a720
PE
38382012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3839
99027bdd
PE
3840 Use sprintf return value instead of invoking strlen on result.
3841 In the old days this wasn't portable, since some sprintf
3842 implementations returned char *. But they died out years ago and
3843 Emacs already assumes sprintf returns int.
3844 Similarly for float_to_string.
3845 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3846 * ccl.c (ccl_driver):
3847 * character.c (string_escape_byte8):
3848 * data.c (Fnumber_to_string):
3849 * doprnt.c (doprnt):
3850 * print.c (print_object):
3851 * xdisp.c (message_dolog):
3852 * xfns.c (syms_of_xfns):
3853 Use sprintf or float_to_string result to avoid need to call strlen.
3854 * data.c (Fnumber_to_string):
3855 Use make_unibyte_string, since the string must be ASCII.
3856 * lisp.h, print.c (float_to_string): Now returns int length.
3857 * term.c (produce_glyphless_glyph):
3858 Use sprintf result rather than recomputing it.
3859
cf38a720
PE
3860 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3861 * Makefile.in (ALL_CFLAGS):
3862 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3863 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3864
3511c784
DA
38652012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3866
0a08eb21 3867 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3868 strcasecmp if available.
3869 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3870
fb7da12e
AS
38712012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3872
3873 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3874 Avoid comma operator.
3875 * menu.c (push_submenu_start, push_submenu_end)
3876 (push_left_right_boundary, push_menu_pane): Likewise.
3877 * msdos.c (dos_rawgetc): Likewise.
3878
afa2ffd8
DA
38792012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3880
3881 * xfns.c (xic_create_fontsetname): Remove redundant calls
3882 to memset.
3883
b3b4476b
PE
38842012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3885
4495ff38
PE
3886 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3887 sprintf already null-terminates its output.
3888
b3b4476b
PE
3889 * xfns.c (x_window): Remove redundant cast.
3890
b00876c9
DA
38912012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3892
3893 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3894 `const char *' to `char *' to avoid compiler warning.
3895
d188e26b
PE
38962012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3897
885d1d74
PE
3898 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3899 instead of truncating it to 63 (admittedly a generous limit).
3900
d188e26b
PE
3901 * process.c: Fix spelling and caps in comments.
3902
e2f560b1
DN
39032012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3904
e86db54b 3905 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3906 * sysdep.c (setpgrp): Remove definition, not used in this file.
3907
7583a3a1
JB
39082012-06-24 Juanma Barranquero <lekktu@gmail.com>
3909
3910 * makefile.w32-in: Update dependencies.
3911
696056c2
EZ
39122012-06-24 Eli Zaretskii <eliz@gnu.org>
3913
3914 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3915 (SYSTIME_H): Add nt/inc/sys/time.h.
3916
3917 * systime.h [WINDOWSNT]: Include sys/time.h.
3918
3919 * s/ms-w32.h (struct timespec): Definition moved from
3920 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3921
845ca893
PE
39222012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3925 * buffer.h (buffer_slot_type_mismatch):
3926 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3927 * eval.c (unwind_to_catch):
3928 * image.c (my_png_error, my_error_exit):
3929 * keyboard.c (quit_throw_to_read_char, user_error)
3930 (Fexit_recursive_edit, Fabort_recursive_edit):
3931 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3932 (wrong_type_argument, buffer_overflow, __executable_start)
3933 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3934 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3935 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3936 (fatal):
3937 (child_setup) [!DOS_NT]:
3938 * lread.c (end_of_file_error, invalid_syntax):
3939 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3940 * puresize.h (pure_write_error):
3941 * search.c (matcher_overflow):
3942 * sound.c (sound_perror, alsa_sound_perror):
3943 * sysdep.c, syssignal.h (croak):
3944 * term.c (maybe_fatal, vfatal):
3945 * textprop.c (text_read_only):
3946 * undo.c (user_error):
3947 * unexmacosx.c (unexec_error):
3948 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3949 Use _Noreturn rather than NO_RETURN.
3950 No need for separate decl merely because of _Noreturn.
3951 * sound.c (sound_warning, parse_sound):
3952 Remove unnecessary forward decls.
3953
f1dd8073
PE
39542012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3955
3956 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3957 * lisp.h (WAIT_READING_MAX): New macro.
3958 * dispnew.c (Fsleep_for, sit_for):
3959 * keyboard.c (kbd_buffer_get_event):
3960 * process.c (Faccept_process_output):
3961 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3962 This improves on the previous patch, which introduced a bug
3963 when time_t is unsigned and as wide as intmax_t.
3964 See <http://bugs.gnu.org/9000#51>.
3965
b82c1755
EZ
39662012-06-23 Eli Zaretskii <eliz@gnu.org>
3967
3968 * dispnew.c (sit_for, Fsleep_for):
3969 * keyboard.c (kbd_buffer_get_event):
3970 * process.c (Faccept_process_output): Avoid compiler warnings when
3971 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3972
ca300656
JB
39732012-06-23 Juanma Barranquero <lekktu@gmail.com>
3974
049ec95b
JB
3975 * makefile.w32-in: Update dependencies.
3976
ca300656
JB
3977 * w32.c (ltime): Add return type and declare static.
3978 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3979
db7b8d06
PE
39802012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3983 Privately reported by Herbert J. Skuhra.
3984 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3985 All uses changed.
3986 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3987 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3988
0bd8297f
EZ
39892012-06-23 Eli Zaretskii <eliz@gnu.org>
3990
96512555
EZ
3991 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3992 last argument of make_unibyte_string.
3993
0bd8297f
EZ
3994 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3995 language ID in the event parameters.
3996
3997 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3998 event.code, not the obscure "character set ID".
3999
63def6b6
CY
40002012-06-23 Chong Yidong <cyd@gnu.org>
4001
4002 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
4003
e8a02204
EZ
40042012-06-23 Eli Zaretskii <eliz@gnu.org>
4005
388cdec0
EZ
4006 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4007 * w32.c (fdutimens): New function.
4008
4009 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
4010
4011 * s/ms-w32.h (pselect): Redirect to sys_select.
4012
4013 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
4014
e8a02204
EZ
4015 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4016 in the logic of incrementing and decrementing the value of
4017 use_relocatable_buffers.
4018
d054f3fb
PE
40192012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
4022 Privately reported by Herbert J. Skuhra.
4023 [__FreeBSD__]: Remove "*/" typo after "#include".
4024 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
4025 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
4026 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
4027 Don't assume EMACS_TIME and struct timeval are the same type.
4028
d35af63c
PE
40292012-06-22 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 Support higher-resolution time stamps (Bug#9000).
4032 The time stamps are only nanosecond-resolution at the C level,
4033 since that's the best that any real-world system supports now.
4034 But they are picosecond-resolution at the Lisp level, as that's
4035 easy, and leaves room for future OS improvements.
4036
4037 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
4038 (LIBES): Use it.
4039
4040 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
4041 Don't get current time unless it's needed.
4042
4043 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
4044 now provides it if it's absent.
4045 (start_atimer): Port to higher-res time stamps.
4046 Check for time stamp overflow. Don't get current time more
4047 often than is needed.
4048
4049 * buffer.h (struct buffer): Buffer modtime now has high resolution.
4050 Include systime.h, not time.h.
4051 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
4052
4053 * dired.c: Include stat-time.h.
4054 (Ffile-attributes): File times now have higher resolution.
4055
4056 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
4057 (struct image): Timestamp now has higher resolution.
4058
4059 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
4060 has at least microseconds now. All uses removed.
4061 (update_frame, update_single_window, update_window, update_frame_1)
4062 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 4063 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
4064
4065 * editfns.c (time_overflow): Now extern.
4066 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
4067 (float-time, Fformat_time_string, Fcurrent_time_string)
4068 (Fcurrent_time_zone): Accept and generate higher-resolution
4069 time stamps.
4070 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
4071 (decode_time_components, lisp_seconds_argument): New functions.
4072 (make_time): Now static.
4073 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
4074 Report an error if the time is invalid, rather than having the caller
4075 do that.
4076
4077 * fileio.c: Include <stat-time.h>
4078 (Fcopy_file): Copy higher-resolution time stamps.
4079 Prefer to set the time stamp via a file descriptor if that works.
4080 (Fset_file_times, Finsert_file_contents, Fwrite_region)
4081 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
4082 (Fvisited_file_modtime, Fset_visited_file_modtime):
4083 Support higher-resolution time stamps.
4084
4085 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
4086
4087 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
4088
4089 * image.c (prepare_image_for_display, clear_image_cache)
4090 (lookup_image): Port to higer-resolution time stamps.
4091
4092 * keyboard.c (start_polling, bind_polling_period):
4093 Check for time stamp overflow.
4094 (read_char, kbd_buffer_get_event, timer_start_idle)
4095 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
4096 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
4097 Port to higher-resolution time stamps. Do not assume time_t is signed.
4098 (decode_timer): New function. Timers are now vectors of length 9,
4099 not 8, to accommodate the picosecond component.
4100 (timer_check_2): Use it.
4101
4102 * nsterm.m (select_timeout, timeval_subtract): Remove.
4103 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
4104 as they're a bit more accurate and handle overflow better.
4105 (ns_select): Change prototype to be compatible with pselect.
4106 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
4107 * nsterm.h (ns_select): Adjust prototype.
4108
4109 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
4110 us-resolution time stamps.
4111 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
4112
4113 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
4114
4115 * lisp.h (time_overflow): New decl.
4116 (wait_reading_process_output): First arg is now intmax_t, not int,
4117 to accommodate larger waits.
4118
4119 * process.h (struct Lisp_Process.read_output_delay):
4120 Now counts nanoseconds, not microseconds.
4121 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
4122 EMACS_HAS_USECS.
4123 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
4124 (wait_reading_process_output):
4125 Port to ns-resolution time stamps.
4126 (Faccept_process_output, wait_reading_process_output):
4127 Check for time stamp overflow. Do not assume time_t is signed.
4128 (select_wrapper): Remove; we now use pselect.
4129 (Fprocess_attributes): Now generates ns-resolution time stamps.
4130
4131 * sysdep.c: Include utimens.h. Don't include utime.h
4132 or worry about struct utimbuf; gnulib does that for us now.
4133 (gettimeofday): Remove; gnulib provides a substitute.
4134 (make_timeval): New function.
4135 (set_file_times): Now sets ns-resolution time stamps.
4136 New arg FD; all uses changed.
4137 (time_from_jiffies, ltime_from_jiffies, get_up_time)
4138 (system_process_attributes):
4139 Now returns ns-resolution time stamp. All uses changed.
4140 Check for time stamp overflow.
4141
4142 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
4143 provides a substitute now.
4144
4145 * systime.h: Include timespec.h rather than sys/time.h and time.h,
4146 since it guarantees struct timespec.
4147 (EMACS_TIME): Now struct timespec, so that we can support
4148 ns-resolution time stamps.
4149 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
4150 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
4151 (EMACS_USECS): Remove.
4152 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
4153 so multiply the arg by 1000 before storing it.
4154 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
4155 New macros.
4156 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
4157 Port to ns-resolution time stamps.
4158 (EMACS_TIME_NEG_P): Remove; replaced by....
4159 (EMACS_TIME_SIGN): New macro.
4160 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
4161 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
4162 (set_file_times, make_time, lisp_time_argument): Adjust signature.
4163 (make_timeval, make_lisp_time, decode_time_components): New decls.
4164 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
4165 that it mishandled time_t overflow. You can't compare by subtracting!
4166 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
4167 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
4168
4169 * term.c: Include <sys/time.h>.
4170 (timeval_to_Time): New function, for proper overflow wraparound.
4171 (term_mouse_position, term_mouse_click): Use it.
4172
4173 * undo.c (record_first_change): Support higher-resolution time stamps
4174 in the undo buffer.
4175 (Fprimitive_undo): Use them when restoring time stamps.
4176
4177 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
4178 (w32_get_internal_run_time):
4179 Port to higher-resolution Emacs time stamps.
4180 (ltime): Now accepts single 64-bit integer, as that's more convenient
4181 for callers.
4182
4183 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
4184
4185 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
4186 for compatibility with pselect. Support ns-resolution time stamps.
4187
4188 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
4189
4190 * xselect.c (wait_for_property_change, x_get_foreign_selection):
4191 Check for time stamp overflow, and support ns-resolution time stamps.
4192
4193 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
4194 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
4195 (timeval_subtract): Remove; no longer needed.
4196 (XTflash, XTring_bell, x_wait_for_event):
4197 Port to ns-resolution time stamps. Don't assume time_t is signed.
4198
b6a92dfe
CY
41992012-06-22 Chong Yidong <cyd@gnu.org>
4200
4201 * xdisp.c (x_consider_frame_title): Revert last change.
4202
d251c37c
EZ
42032012-06-22 Eli Zaretskii <eliz@gnu.org>
4204
4205 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
4206 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
4207 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
4208 staticidx goes up to 1597 out of 1600 = 0x640.)
4209
f10deafb
PE
42102012-06-20 Paul Eggert <eggert@cs.ucla.edu>
4211
4212 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
4213 Otherwise, the umask might be mistakenly 0 while handling input signals.
4214
ec6de1e2
SM
42152012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
4216
4217 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
4218
28be1ada
DA
42192012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
4220
4221 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
4222 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
4223 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
4224 access to `contents' member of Lisp_Vector objects with AREF and ASET
4225 where appropriate.
4226
c6bf3022
CY
42272012-06-19 Chong Yidong <cyd@gnu.org>
4228
4229 * frame.c (delete_frame): When selecting a frame on a different
4230 text terminal, do not alter the terminal's top-frame.
4231
4232 * xdisp.c (format_mode_line_unwind_data): Record the target
4233 frame's selected window and its terminal's top-frame.
4234 (unwind_format_mode_line): Restore them.
4235 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
4236 Callers changed.
4237 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
4238 since tty frames can be explicitly named.
4239 (prepare_menu_bars): Likewise.
4240
4241 * term.c (Ftty_top_frame): New function.
4242
defd4196
PE
42432012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4244
4245 Port byte-code-meter to modern targets.
4246 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
4247 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 4248 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
4249 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
4250 (METER_1, METER_2): Simplify.
4251
1053a871
SM
42522012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
4253
4254 * data.c (Fdefalias): Return `symbol' (bug#11686).
4255
b7e8d081
MR
42562012-06-18 Martin Rudalics <rudalics@gmx.at>
4257
4258 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
4259 gets killed during executing of this function (Bug#11665).
4260 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
4261 (Vkill_buffer_query_functions): In doc-string say that functions
4262 run by this hook should not change the current buffer.
4263
7ea2b339
PE
42642012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4265
4266 Fix recently-introduced process.c problems found by static checking.
4267 * process.c (write_queue_push, write_queue_pop, send_process):
4268 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
4269 (write_queue_pop): Fix pointer signedness problem.
4270 (send_process): Remove unused local.
4271
96a313a1
CY
42722012-06-17 Chong Yidong <cyd@gnu.org>
4273
4274 * xdisp.c (redisplay_internal): No need to redisplay terminal
4275 frames that are not on top.
4276
20ca2e94
TN
42772012-06-17 Troels Nielsen <bn.troels@gmail.com>
4278
4279 * process.c (make_process): Initialize write_queue.
4280 (write_queue_push, write_queue_pop): New functions.
4281 (send_process): Use them to maintain correct ordering of process
4282 writes (Bug#10815).
4283
9a900ca9
PE
42842012-06-17 Paul Eggert <eggert@cs.ucla.edu>
4285
310fbfa8
PE
4286 * lisp.h (eassert): Assume C89 or later.
4287 This removes the need for CHECK.
4288 (CHECK): Remove. Its comments about always evaluating its
4289 argument were confusing, as 'eassert' typically does not evaluate
4290 its argument.
4291
27bb1ca4
PE
4292 * coding.c (produce_chars): Use ptrdiff_t, not int.
4293
9a900ca9
PE
4294 * xterm.c (x_draw_underwave): Check for integer overflow.
4295 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
4296
41b7f8bc 42972012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
4298
4299 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4300 referenced (Bug#11583).
4301
9b0e3eba
AA
43022012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
4303
4304 Implement wave-style variant of underlining.
4305 * dispextern.h (face_underline_type): New enum.
4306 (face): Add field for underline type.
4307 * nsterm.m (ns_draw_underwave): New function.
4308 (ns_draw_text_decoration): Use it.
4309 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
4310 New functions.
4311 (x_draw_glyph_string): Use them.
4312 * xfaces.c (Qline, Qwave): New Lisp objects.
4313 (check_lface_attrs, merge_face_ref)
1053a871
SM
4314 (Finternal_set_lisp_face_attribute, realize_x_face):
4315 Handle wave-style underline face attributes.
9b0e3eba
AA
4316 * xterm.c (x_draw_underwave): New function.
4317 (x_draw_glyph_string): Use it.
4318
0fb52f11
JB
43192012-06-16 Juanma Barranquero <lekktu@gmail.com>
4320
4321 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
4322 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
4323 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
4324 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
4325 ($(BLD)/w32select.$(O)): Update dependencies.
4326
e5560ff7
AS
43272012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4328
4329 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
4330 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
4331 * character.c (_fetch_multibyte_char_p): Remove.
4332 * alloc.c: Include "character.h" before "buffer.h".
4333 * bidi.c: Likewise.
4334 * buffer.c: Likewise.
4335 * bytecode.c: Likewise.
4336 * callint.c: Likewise.
4337 * callproc.c: Likewise.
4338 * casefiddle.c: Likewise.
4339 * casetab.c: Likewise.
4340 * category.c: Likewise.
4341 * cmds.c: Likewise.
4342 * coding.c: Likewise.
4343 * composite.c: Likewise.
4344 * dired.c: Likewise.
4345 * dispnew.c: Likewise.
4346 * doc.c: Likewise.
4347 * dosfns.c: Likewise.
4348 * editfns.c: Likewise.
4349 * emacs.c: Likewise.
4350 * fileio.c: Likewise.
4351 * filelock.c: Likewise.
4352 * font.c: Likewise.
4353 * fontset.c: Likewise.
4354 * fringe.c: Likewise.
4355 * indent.c: Likewise.
4356 * insdel.c: Likewise.
4357 * intervals.c: Likewise.
4358 * keyboard.c: Likewise.
4359 * keymap.c: Likewise.
4360 * lread.c: Likewise.
4361 * macros.c: Likewise.
4362 * marker.c: Likewise.
4363 * minibuf.c: Likewise.
4364 * nsfns.m: Likewise.
4365 * nsmenu.m: Likewise.
4366 * print.c: Likewise.
4367 * process.c: Likewise.
4368 * regex.c: Likewise.
4369 * region-cache.c: Likewise.
4370 * search.c: Likewise.
4371 * syntax.c: Likewise.
4372 * term.c: Likewise.
4373 * textprop.c: Likewise.
4374 * undo.c: Likewise.
4375 * unexsol.c: Likewise.
4376 * w16select.c: Likewise.
4377 * w32fns.c: Likewise.
4378 * w32menu.c: Likewise.
4379 * window.c: Likewise.
4380 * xdisp.c: Likewise.
4381 * xfns.c: Likewise.
4382 * xmenu.c: Likewise.
4383 * xml.c: Likewise.
4384 * xselect.c: Likewise.
4385
2f07e6af
EZ
43862012-06-16 Eli Zaretskii <eliz@gnu.org>
4387
1053a871
SM
4388 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4389 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4390 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4391 row.
4392 (handle_face_prop): Use chunk-relative overlay string index when
4393 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4394 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4395 the rightmost. (Bug#11720)
2f07e6af 4396
29b83cec
AS
43972012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4398
4399 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4400 (CATEGORY_MEMBER): Enforce 1/0 value.
4401 * category.c (_temp_category_set): Remove.
4402
4c5501e9
EZ
44032012-06-16 Eli Zaretskii <eliz@gnu.org>
4404
4405 * window.c (Fdelete_other_windows_internal)
4406 (Fdelete_window_internal): Don't access frame's mouse highlight
4407 info of the initial frame. (Bug#11677)
4408
2b570124
PE
44092012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4410
e93864f9
PE
4411 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4412 Assume USE_2_TAGS_FOR_INTS.
4413 (xreload): Adjust $tagmask width to match recent lisp.h change.
4414
2b570124
PE
4415 Simplify lisp.h in minor ways that should not affect code.
4416 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4417 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4418 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4419 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4420 (INTTYPEBITS): New macro, for clarity.
4421 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4422 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4423 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4424 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4425 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4426
81755f69
JB
44272012-06-13 Juanma Barranquero <lekktu@gmail.com>
4428
4429 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4430
16192a57
GM
44312012-06-13 Glenn Morris <rgm@gnu.org>
4432
4433 * s/bsd-common.h (BSD4_3):
4434 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4435
646b5f55
AS
44362012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4437
4438 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4439 instead of union.
4440 (XLI, XIL): Define.
1053a871
SM
4441 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4442 Use them.
4443 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4444 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4445 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4446 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4447 * frame.c (delete_frame): Remove outdated comment.
4448 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4449 USE_LISP_UNION_TYPE.
4450 (Fw32_unregister_hot_key): Likewise.
4451 (Fw32_toggle_lock_key): Likewise.
4452 * w32menu.c (add_menu_item): Likewise.
4453 (w32_menu_display_help): Use XIL instead of checking
4454 USE_LISP_UNION_TYPE.
4455 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4456 (init_heap): Likewise.
4457 * w32term.c (w32_read_socket): Update comment.
4458
1d3823c9
GM
44592012-06-13 Glenn Morris <rgm@gnu.org>
4460
c62ff706
GM
4461 * s/usg5-4-common.h, src/s/unixware.h:
4462 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4463
1d3823c9
GM
4464 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4465
bfe3e0a2
PE
44662012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4467
4468 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4469 * alloc.c (make_number) [!defined make_number]:
4470 Remove, as lisp.h always defines this now.
4471 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4472 (roundup_size): Verify that it is a power of 2.
4473 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4474 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4475 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4476 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4477 USE_LSB_TAG now is always defined to be either 0 or 1.
4478 All uses changed.
4479 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4480 code works fine either way, and efficiency is not a concern here,
4481 as the union type is for debugging, not for production.
4482 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4483 Use an inline function on all platforms when using the union type,
4484 since this is simpler and 'static inline' can be used portably
4485 within Emacs now.
4486 (LISP_INITIALLY_ZERO): New macro.
4487 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4488 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4489
45fa9c0f
GM
44902012-06-12 Glenn Morris <rgm@gnu.org>
4491
b4492cba
GM
4492 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4493
4494 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4495
45fa9c0f
GM
4496 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4497 Move BROKEN_SIGIO to configure.
4498
4499 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4500 Move NO_TERMIO to configure.
4501
0e25d334
CY
45022012-06-12 Chong Yidong <cyd@gnu.org>
4503
4504 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4505 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4506 MagickExportImagePixels is undefined.
4507
43682bb6
PE
45082012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4509
4510 * image.c (imagemagick_load_image): Remove unused label.
4511
a9be7d2b
GM
45122012-06-11 Glenn Morris <rgm@gnu.org>
4513
4514 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4515 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4516 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4517 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4518
3017f87f
SM
45192012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4520
4521 * alloc.c (make_byte_code): New function.
4522 (Fmake_byte_code): Use it. Don't purify here.
4523 * lread.c (read1): Use it as well to avoid extra allocation.
4524
1b9b4cf4
CY
45252012-06-11 Chong Yidong <cyd@gnu.org>
4526
4527 * image.c (imagemagick_load_image): Implement transparency.
4528
95988fcf
AS
45292012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4530
4531 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4532 account for preceding backslashes. (Bug#11663)
4533
cd4eb164
CY
45342012-06-09 Chong Yidong <cyd@gnu.org>
4535
4536 * term.c: Support italics in capable terminals (Bug#9652).
4537 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4538 (turn_on_face): Output using TS_enter_italic_mode if available.
4539 Don't handle unused blinking and alt-charset cases.
4540 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4541 and tty_alt_charset_p cases.
4542 (tty_capable_p, init_tty): Support italics.
4543
4544 * termchar.h (struct tty_display_info): Add field for italics.
4545 Remove unused blink field.
4546
4547 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4548 Handle slant.
4549
4550 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4551 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4552 tty_alt_charset_p. Add tty_italic_p.
4553
ff88beb8
MA
45542012-06-09 Michael Albinus <michael.albinus@gmx.de>
4555
4556 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4557 dbus_type_is_basic if available.
4558 (xd_extract_signed, xd_extract_unsigned): Rename from
4559 extract_signed and extract_unsigned, respectively. Adapt callers.
4560
44286096
CY
45612012-06-09 Chong Yidong <cyd@gnu.org>
4562
1682701f
CY
4563 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4564
44286096
CY
4565 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4566 case (Bug#9752).
4567
d86feb17
PE
45682012-06-08 Paul Eggert <eggert@cs.ucla.edu>
4569
4570 * xdisp.c (vmessage): Treat frame message as multibyte.
4571 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
4572 would generate the diagnostic "Making \302\247 buffer-local while
4573 let-bound!".
4574
d5c20fe8
EZ
45752012-06-08 Eli Zaretskii <eliz@gnu.org>
4576
4577 * dispnew.c (showing_window_margins_p): Undo last change, which
4578 was done due to an inadvertent commit.
4579 (adjust_frame_glyphs_for_frame_redisplay): Do call
4580 showing_window_margins_p.
4581
513749ee
SM
45822012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4583
4584 * eval.c (Fmake_var_non_special): New primitive.
4585 (syms_of_eval): Defsubr it.
4586 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
4587
d4a8f5c1
JB
45882012-06-08 Juanma Barranquero <lekktu@gmail.com>
4589
4590 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4591 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
4592
8bbbc977
EZ
45932012-06-08 Eli Zaretskii <eliz@gnu.org>
4594
4595 * alloc.c (allocate_vectorlike): Fix last change.
4596
f3372c87
DA
45972012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4598
4599 Block-based vector allocation of small vectors.
4600 * lisp.h (struct vectorlike_header): New field `nbytes',
4601 adjust comment accordingly.
4602 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4603 to denote vector blocks. Adjust users (live_vector_p,
4604 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4605 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4606 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4607 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4608 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4609 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4610 (roundup_size): New constant.
4611 (struct vector_block): New data type.
4612 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4613 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4614 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4615 (sweep_vectors): New functions.
4616 (allocate_vectorlike): Return `zero_vector' as the only vector of
4617 0 items. Allocate new vector from block if vector size is less than
4618 or equal to VBLOCK_BYTES_MAX.
4619 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4620 (init_alloc_once): Add call to init_vectors.
4621
4f18a4ed
SM
46222012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4623
4624 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4625
86f158bc
PE
46262012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4627
4628 * doprnt.c (doprnt): Truncate multibyte char correctly.
4629 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4630 would mishandle a string argument "Xc" if X was a multibyte
4631 character of length 2: it would truncate after X's first byte
4632 rather than including all of X.
4633
c5cfcbe0
CY
46342012-06-06 Chong Yidong <cyd@gnu.org>
4635
4636 * buffer.c (word_wrap): Doc fix.
4637
c05cf390
PE
46382012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4639
4640 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4641
0c3461de
GM
46422012-06-03 Glenn Morris <rgm@gnu.org>
4643
4644 * xdisp.c (tool-bar-style): Doc fix.
4645
c71232db
UM
46462012-06-03 Ulrich Müller <ulm@gentoo.org>
4647
4648 * Makefile.in (PAXCTL): Define.
4649 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4650 binary via PaX flags if the paxctl utility is available.
4651 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4652 Restore PaX flags to their default. (Bug#11398)
4653
383f7350
CY
46542012-06-03 Chong Yidong <cyd@gnu.org>
4655
4656 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4657 buffer (Bug#11226).
4658
5f2c76c6
CY
46592012-06-03 Chong Yidong <cyd@gnu.org>
4660
4661 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4662 (note_mode_line_or_margin_highlight): If there is no help echo,
4663 use mode-line-default-help-echo. Handle the case where the mouse
4664 position is past the end of the mode line string.
4665
4666 * buffer.c (buffer_local_value_1): New function, split from
4667 Fbuffer_local_value; can return Qunbound.
4668 (Fbuffer_local_value): Use it.
4669 (Vmode_line_format): Docstring tweaks.
4670
773d47f6
PE
46712012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4672
4673 * sysdep.c (system_process_attributes): Improve comment.
4674
f2d6a3df
SM
46752012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4676
4677 * keyboard.c: Export real-this-command to Elisp.
4678 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4679 and DEFVAR it. Update all users.
4680
63810350
PE
46812012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4682
7bd5c1f4
PE
4683 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4684
63810350
PE
4685 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4686 Convert pctcpu and pctmem to Lisp float properly.
4687 Let the compiler fold better, as 100.0/0x8000 is exact.
4688
a2821611
AS
46892012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4690
4691 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4692 cons_block.
4693
5fceba1d
PE
46942012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4697
c98ff5dd
DA
46982012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4699
4700 For a 'struct window', replace some Lisp_Object fields to
4701 bitfields where appropriate, remove unused fields.
4702 * window.h (struct window): Remove unused 'last_mark_x' and
4703 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4704 change it's type from Lisp_Object to bitfield.
4705 Change type of 'force_start', 'optional_new_start',
4706 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4707 fields from Lisp_Object to bitfield. Adjust users accordingly.
4708
ca34e0be
PE
47092012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4710
4711 Pacify gcc -Wdouble-precision when using Xaw.
4712 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4713 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4714 Use 'float' consistently, rather than 'float' in most places
4715 and 'double' in a couple of places.
4716
efc00ab1 47172012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4718
4719 * xdisp.c (handle_stop): Detect whether we have overlay strings
4720 loaded by testing it->current.overlay_string_index to be
4721 non-negative, instead of checking whether n_overlay_strings is
4722 positive. (Bug#11587)
4723
efc00ab1 47242012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4725
4726 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4727
4728 * doc.c (Fsubstitute_command_keys): Doc fix.
4729
efc00ab1 47302012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4731
4732 * search.c (search_buffer): Remove calls to
4733 r_alloc_inhibit_buffer_relocation, as it is now called by
4734 maybe_unify_char, which was the cause of relocation of buffer text
4735 in bug#11519.
4736
efc00ab1 47372012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4738
4739 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4740 for the duration of call to load_charset, to avoid problems with
4741 callers of maybe_unify_char that access buffer text through C
4742 pointers.
4743
4744 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4745 decrement the inhibition flag, instead of just setting or
4746 resetting it.
4747
ba93a187
PE
47482012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4749
4750 Remove obsolete '#define static' cruft.
4751 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4752 This #undef was "temporary" in 2000; it is no longer needed
4753 now that '#define static' has gone away.
4754 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4755 (gray_bitmap_bits): Remove; no longer needed.
4756 All uses replaced with definiens.
4757 * xterm.c: Include "bitmaps/gray.xbm".
4758
9e4bf381
PE
47592012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4760
4761 Clean up __executable_start, monstartup when --enable-profiling.
4762 The following changes affect the code only when profiling.
4763 * dispnew.c (__executable_start): Rename from safe_bcopy.
4764 Define only on platforms that need it.
4765 * emacs.c: Include <sys/gmon.h> when profiling.
4766 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4767 (__executable_start): Remove decl, since lisp.h does it now.
4768 (safe_bcopy): Remove decl; no longer has that name.
4769 (main): Coalesce #if into single bit of code, for simplicity.
4770 Cast pointers to uintptr_t, since standard libraries want integers
4771 and not pointers.
4772 * lisp.h (__executable_start): New decl.
4773
32d72c2f
GM
47742012-05-31 Glenn Morris <rgm@gnu.org>
4775
4776 * image.c (Fimagemagick_types): Doc fix.
4777
baac5bc7
JM
47782012-05-30 Jim Meyering <meyering@redhat.com>
4779
4780 * callproc.c (Fcall_process_region): Include directory component
4781 in mkstemp error message (Bug#11586).
4782
72cb32cf
PE
47832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4784
4785 * alloc.c, lisp.h (make_pure_vector): Now static.
4786
61b108cc
SM
47872012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4788
4789 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4790 Move to byte-run.el.
4791 (Fautoload): Do the hash-doc more carefully.
4792 * data.c (Fdefalias): Purify definition, except for keymaps.
4793 (Qdefun): Move from eval.c.
4794 * lisp.h (Qdefun): Remove.
4795 * lread.c (read1): Tiny simplification.
4796
471fe23d
TN
47972012-05-29 Troels Nielsen <bn.troels@gmail.com>
4798
934f3f58 4799 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4800 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4801 Bug#9642, but explicitly check that the buffer the overlay would
4802 be moved to is live and rearrange lines to make sure that errors
4803 will not put the overlay in an inconsistent state.
4804 (Fdelete_overlay): Cosmetics.
4805
85d0efd1
EZ
48062012-05-28 Eli Zaretskii <eliz@gnu.org>
4807
4808 * w32term.c (my_bring_window_to_top): New function.
4809 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4810 could be different from the original one.
4811 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4812 (Bug#11513)
4813
4814 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4815 by calling BringWindowToTop.
4816
4817 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4818 (WM_EMACS_END): Increase by one.
4819
da92a98c
PE
48202012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4821
4822 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4823 This avoids undefined behavior that might cause the eassert
4824 to not catch an out-of-range value.
4825
74d1f848
JB
48262012-05-28 Juanma Barranquero <lekktu@gmail.com>
4827
4828 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4829 Update dependencies.
4830
9e1a06fc
EZ
48312012-05-27 Eli Zaretskii <eliz@gnu.org>
4832
4833 * bidi.c (bidi_mirror_char): Fix last change.
4834
f3dd7312
AS
48352012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4836
4837 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4838 when referring to sectname field in printf format.
4839
81899c91
PE
48402012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4841
57b81a9f
PE
4842 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4843 Only r_alloc_inhibit_buffer_relocation needed to be added;
4844 the others were already declared.
4845
81899c91
PE
4846 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4847 before checking whether it's out of range. Put the check inside
4848 eassert. See
4849 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4850
33017faf 48512012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4852
4853 * callproc.c (Fcall_process): Restore a line that was accidentally
4854 commented out in the 2011-02-13 change (bug#11547).
4855
33017faf 48562012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4857
4858 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4859 defined on ralloc.c.
4860
4861 * buffer.c [REL_ALLOC]: Remove prototypes of
4862 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4863 they are now on lisp.h.
4864
4865 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4866
4867 * search.c (search_buffer): Use it to inhibit relocation of buffer
4868 text while re_search_2 is doing its job, because re_search_2 is
4869 passed C pointers to buffer text. (Bug#11519)
4870
23415acf
EZ
4871 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4872 Update value to 24.
4873
44e27368
EZ
4874 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4875 state after an additional call to move_it_in_display_line_to, keep
4876 the values of it->max_ascent and it->max_descent found for the
4877 entire line.
4878 (pos_visible_p): Revert the comparison against bottom_y to what it
4879 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4880 (Bug#11464)
4881
c1892f11
PE
48822012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4883
4884 Fix coding-related core dumps with gcc -ftrapv.
4885 The code was computing A - B, where A and B are pointers, and B is
4886 random garbage. This can lead to core dumps on platforms that
4887 have special pointer registers, and it also leads to core dumps on
4888 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4889 A - B only when B is initialized properly.
4890 * coding.c (coding_set_source, coding_set_destination): Return void.
4891 (coding_change_source, coding_change_destinations): New functions,
4892 with the old behaviors of coding_set_source and coding_set_destination.
4893 All callers that need an offset changed to use these new functions.
4894
eb7afdad
GM
48952012-05-26 Glenn Morris <rgm@gnu.org>
4896
4897 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4898
f12fdf02
EZ
48992012-05-26 Eli Zaretskii <eliz@gnu.org>
4900
53a63be6 4901 Extend mouse support on W32 text-mode console.
61b108cc
SM
4902 * xdisp.c (draw_row_with_mouse_face):
4903 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4904
eb3f6f01 4905 * w32console.c: Include window.h.
61b108cc
SM
4906 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4907 New functions.
eb3f6f01
EZ
4908 (initialize_w32_display): Initialize mouse-highlight data.
4909
53a63be6
EZ
4910 * w32inevt.c: Include termchar.h and window.h.
4911 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4912 moves, call note_mouse_highlight. If help_echo changed, call
4913 gen_help_event to produce help-echo message in the echo area.
4914 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4915 highlight info.
4916
4cfd81f6
PE
49172012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4918
4919 * lread.c (read1): Simplify slightly to avoid an overflow warning
4920 with GCC 4.7.0 on x86-64.
4921
4446092a
EZ
49222012-05-26 Eli Zaretskii <eliz@gnu.org>
4923
4924 * bidi.c (bidi_mirror_char): Revert last change: an int is
4925 definitely wide enough here.
4926
42b2a986 49272012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4928
42b2a986 4929 Fix integer width and related bugs (Bug#9874).
eb106a49 4930 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4931 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4932 (string_bytes, check_sblock, allocate_string_data):
4933 (compact_small_strings, Fmake_bool_vector, make_string)
4934 (make_unibyte_string, make_multibyte_string)
4935 (make_string_from_bytes, make_specified_string)
4936 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4937 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4938 (mark_vectorlike):
4939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4940 (allocate_pseudovector):
4941 Use int, not EMACS_INT, where int is wide enough.
4942 (inhibit_garbage_collection, Fgarbage_collect):
4943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4944 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4945 int might not be wide enough.
4946 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4947 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4948 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4949 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4950 (bidi_level_of_next_char, bidi_move_to_visually_next):
4951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4952 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4953 (Fkill_buffer, Fset_buffer_major_mode)
4954 (advance_to_char_boundary, Fbuffer_swap_text)
4955 (Fset_buffer_multibyte, overlays_at, overlays_in)
4956 (overlay_touches_p, struct sortvec, record_overlay_string)
4957 (overlay_strings, recenter_overlay_lists)
4958 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4959 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4960 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4961 (Foverlay_recenter, last_overlay_modification_hooks_used)
4962 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4964 (validate_region): Omit unnecessary test for b <= e,
4965 since that's guaranteed by the previous test.
d311d28c
PE
4966 (adjust_overlays_for_delete): Avoid pos + length overflow.
4967 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4968 (report_overlay_modification):
4969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4970 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4971 Omit pointer cast, which isn't needed anyway, and doesn't work
4972 after the EMACS_INT -> ptrdiff_t change.
02481186 4973 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4974 * buffer.h: Adjust decls to match defn changes elsewhere.
4975 (struct buffer_text, struct buffer):
4976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4977 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4978 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4979 not int, to avoid needless 32-bit limit on 64-bit hosts.
4980 (exec_byte_code): Use tighter memory-full test, one that checks
4981 for alloca overflow. Don't compute the address of the object just
4982 before an array, as that's not portable. Use EMACS_INT, not
4983 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4984 * callint.c (Fcall_interactively):
4985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4986 * callproc.c (call_process_kill, Fcall_process):
4987 Don't assume pid_t fits into an Emacs fixnum.
4988 (call_process_cleanup, Fcall_process, child_setup):
4989 Don't assume pid_t fits into int.
4990 (call_process_cleanup, Fcall_process, delete_temp_file)
4991 (Fcall_process_region):
4992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4993 (Fcall_process): Simplify handling of volatile integers.
4994 Use int, not EMACS_INT, where int will do.
4995 * casefiddle.c (casify_object, casify_region, operate_on_word)
4996 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4998 (casify_object): Avoid integer overflow when overallocating buffer.
4999 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 5000 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
5001 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
5002 * category.h (CATEGORYP): Don't assume arg is nonnegative.
5003 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
5004 integers are now checked earlier. All uses replaced with XINT.
5005 (ccl_driver):
5006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5007 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
5008 (ccl_driver, Fregister_code_conversion_map):
5009 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
5010 (resolve_symbol_ccl_program): Check that vector header is in range.
5011 Always copy the vector, so that we can check its contents reliably
5012 now rather than having to recheck each instruction as it's being
5013 executed. Check that vector words fit in 'int'.
5014 (ccl_get_compiled_code, Fregister_ccl_program)
5015 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
5016 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
5017 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
5018 contents are in range.
5019 (Fccl_execute_on_string): Check that status is in range.
5020 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
5021 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
5022 Accept and return EMACS_INT, not int, because callers can pass values
5023 out of 'int' range.
5024 (c_string_width, strwidth, lisp_string_width, chars_in_text)
5025 (multibyte_chars_in_text, parse_str_as_multibyte)
5026 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
5027 (str_as_unibyte, str_to_unibyte, string_count_byte8)
5028 (string_escape_byte8, Fget_byte):
5029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 5030 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
5031 avoid mishandling large integers.
5032 * character.h: Adjust decls to match defn changes elsewhere.
5033 * charset.c (load_charset_map_from_file, find_charsets_in_text)
5034 (Ffind_charset_region):
5035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5036 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
5037 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 5038 Don't assume fixnum fits in int.
d311d28c
PE
5039 (load_charset_map_from_vector, Fmap_charset_chars):
5040 Remove now-unnecessary CHECK_NATNUMs.
5041 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
5042 Don't rely on undefined behavior with signed left shift overflow.
5043 Don't assume unsigned int fits into fixnum, or that fixnum fits
5044 into unsigned int. Don't require max_code to be a valid fixnum;
5045 that's not true for gb10830 4-byte on a 32-bit host. Allow
5046 invalid_code to be a cons, for the same reason. Require code_offset
5047 to be a character. Avoid int overflow if max_char is close
5048 to INT_MAX.
5049 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
5050 this is intended anyway and avoids some undefined behavior.
5051 (load_charset_map): Pass unsigned, not int, as 2nd arg of
5052 INDEX_TO_CODE_POINT, as that's what it expects.
5053 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
5054 * charset.h (DECODE_CHAR): Return int, not unsigned;
5055 this is what was intended anyway, and it avoids undefined behavior.
5056 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
5057 integer-overflow issues.
5058 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
5059 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
5060 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
5061 * chartab.c (Fmake_char_table, Fset_char_table_range)
5062 (uniprop_get_decoder, uniprop_get_encoder):
5063 Don't assume fixnum fits in int.
5064 * cmds.c (move_point): New function, that does the gist of
5065 Fforward_char and Fbackward_char, but does so while checking
5066 for integer overflow more accurately.
c96e5d6a 5067 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
5068 (Fforward_line, Fend_of_line, internal_self_insert)
5069 (internal_self_insert):
5070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5071 Fix a FIXME, by checking for integer overflow when calculating
5072 target_clm and actual_clm.
5073 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 5074 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
5075 (ASSURE_DESTINATION, coding_alloc_by_realloc)
5076 (coding_alloc_by_making_gap, alloc_destination)
5077 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
5078 (encode_coding_utf_16, detect_coding_emacs_mule)
5079 (decode_coding_emacs_mule, encode_coding_emacs_mule)
5080 (detect_coding_iso_2022, decode_coding_iso_2022)
5081 (encode_invocation_designation, encode_designation_at_bol)
5082 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5083 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
5084 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
5085 (encode_coding_ccl, encode_coding_raw_text)
5086 (detect_coding_charset, decode_coding_charset)
5087 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
5088 (produce_composition, produce_charset, produce_annotation)
5089 (decode_coding, handle_composition_annotation)
5090 (handle_charset_annotation, consume_chars, decode_coding_gap)
5091 (decode_coding_object, encode_coding_object, detect_coding_system)
5092 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
5093 (code_convert_region, code_convert_string)
8f50130c
PE
5094 (Fdefine_coding_system_internal)
5095 (coding_set_source, coding_set_destination):
d311d28c
PE
5096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5097 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
5098 (Fdefine_coding_system_internal):
5099 Don't assume fixnums fit in int.
5100 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 5101 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
5102 (Funencodable_char_position, Fcheck_coding_systems_region)
5103 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 5104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 5105 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 5106 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 5107 Don't access memory outside of the args array.
d311d28c 5108 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
5109 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
5110 result of ENCODE_CHAR.
d311d28c
PE
5111 * coding.h: Adjust decls to match defn changes elsewhere.
5112 (struct coding_system):
5113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5114 * composite.c (get_composition_id, find_composition)
5115 (run_composition_function, update_compositions)
5116 (compose_text, composition_gstring_put_cache)
5117 (composition_gstring_p, composition_gstring_width)
5118 (fill_gstring_header, fill_gstring_body, autocmp_chars)
5119 (composition_compute_stop_pos, composition_reseat_it)
5120 (composition_update_it, struct position_record)
5121 (find_automatic_composition, composition_adjust_point)
5122 (Fcomposition_get_gstring, Ffind_composition_internal):
5123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5124 (update_compositions):
5125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5126 * composite.h: Adjust decls to match defn changes elsewhere.
5127 (struct composition):
5128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5129 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
5130 Do not attempt to compute the address of the object just before a
5131 buffer; this is not portable.
5132 (Faref, Faset):
5133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5134 (Faset): Use int, not EMACS_INT, where int is wide enough.
5135 (Fstring_to_number): Don't assume fixnums fit in int.
5136 (Frem): Don't assume arg is nonnegative.
5137 * dbusbind.c (xd_append_arg): Check for integers out of range.
5138 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 5139 (extract_signed, extract_unsigned): New functions.
243e0530
PE
5140 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
5141 (xd_get_connection_references): Return ptrdiff_t, not int.
5142 All uses changed.
5143 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
5144 (xd_read_message_1):
5145 Use int, not unsigned, where the dbus API uses int.
5146 (Fdbus_message_internal): Don't overflow mtype.
5147 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
5148 * dired.c (directory_files_internal, file_name_completion, scmp)
5149 (file_name_completion_stat):
5150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5151 (file_name_completion): Don't overflow matchcount.
5152 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
5153 * dispextern.h: Adjust decls to match defn changes elsewhere.
5154 (struct text_pos, struct glyph, struct bidi_saved_info)
5155 (struct bidi_string_data, struct bidi_it, struct composition_it)
5156 (struct it):
5157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5158 (struct display_pos, struct composition_it, struct it):
5159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5160 * dispnew.c (increment_matrix_positions)
5161 (increment_row_positions, mode_line_string)
5162 (marginal_area_string):
5163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 5164 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
5165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5166 (duration_to_sec_usec): New function, to check for overflow better.
5167 (Fsleep_for, sit_for): Use it.
5168 * doc.c (get_doc_string, store_function_docstring):
5169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5170 (get_doc_string, Fsnarf_documentation):
5171 Use int, not EMACS_INT, where int is wide enough.
5172 (get_doc_string):
5173 Use SAFE_ALLOCA, not alloca.
5174 Check for overflow when converting EMACS_INT to off_t.
5175 * doprnt.c (doprnt):
5176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5177 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
5178 Don't assume uid_t fits into fixnum.
5179 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
5180 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
5181 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
5182 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
5183 (general_insert_function)
5184 (Finsert_char, make_buffer_string, make_buffer_string_both)
5185 (update_buffer_properties, Fbuffer_substring)
5186 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
5187 (Fsubst_char_in_region, check_translation)
5188 (Ftranslate_region_internal, save_restriction_restore, Fformat)
5189 (transpose_markers, Ftranspose_regions):
5190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5191 (clip_to_bounds): Move to lisp.h as an inline function).
5192 (Fconstrain_to_field): Don't assume integers are nonnegative.
5193 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
5194 (Fsubst_char_in_region, Fsave_restriction):
5195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5196 (Femacs_pid): Don't assume pid_t fits into fixnum.
5197 (lo_time): Use int, not EMACS_INT, when int suffices.
5198 (lisp_time_argument): Check for usec out of range.
5199 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
5200 (Fuser_login_name, Fuser_full_name): Signal an error
5201 if a uid argument is out of range, rather than relying on
5202 undefined behavior.
c8d5c857
PE
5203 (Fformat_time_string): Remove now-unnecessary check.
5204 lisp_time_argument checks for out-of-range usec now.
243e0530 5205 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
5206 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
5207 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
5208 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
5209 (init_cmdargs, Fdump_emacs):
5210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5211 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
5212 the bottom (typically) 32 bits of the fixnum.
5213 * eval.c (specpdl_size, call_debugger):
5214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5215 (when_entered_debugger, Fbacktrace_debug):
5216 Don't assume fixnum can fit in int.
5217 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
5218 the object just before a buffer; this is not portable.
5219 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
5220 (grow_specpdl, unbind_to):
5221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5222 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
5223 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 5224 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
5225 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
5226 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
5227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5228 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
5229 (a_write, e_write):
5230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5231 (Fcopy_file, non_regular_nbytes, read_non_regular)
5232 (Finsert_file_contents):
5233 Use int, not EMACS_INT, where int is wide enough.
5234 (READ_BUF_SIZE): Verify that it fits in int.
5235 (Finsert_file_contents): Check that counts are in proper range,
5236 rather than assuming fixnums fit into ptrdiff_t etc.
5237 Don't assume fixnums fit into int.
125b3835 5238 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
5239 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
5240 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
5241 (string_char_to_byte, string_byte_to_char)
5242 (string_make_multibyte, string_to_multibyte)
5243 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
5244 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
5245 (substring_both, Fdelete, internal_equal, Ffillarray)
5246 (Fclear_string, mapcar1)
5247 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
5248 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
5249 (larger_vector, make_hash_table, maybe_resize_hash_table)
5250 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
5251 (Fmaphash, secure_hash):
5252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5253 (concat): Check for string index and length overflow.
5254 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
5255 (Frequire):
5256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5257 (larger_vector): New API (vec, incr_min, size_max) replaces old
5258 one (vec, new_size, init). This catches size overflow.
5259 INIT was removed because it was always Qnil.
5260 All callers changed.
5261 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
5262 the upper bound on a hash table index size.
5263 (make_hash_table, maybe_resize_hash_table): Use it.
5264 (secure_hash): Computer start_byte and end_byte only after
5265 they're known to be in ptrdiff_t range.
5266 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
5267 (Ffont_get_glyphs, Ffont_at):
5268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5269 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
5270 (Flist_fonts, Fopen_font):
5271 Don't assume fixnum can fit in int.
5272 (check_gstring): Don't assume index can fit in int.
5273 (font_match_p): Check that fixnum is a character, not a nonnegative
5274 fixnum, since the later code needs to stuff it into an int.
5275 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
5276 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
5277 conversion overflow issues.
5278 (Fopen_font): Check for integer out of range.
5279 (Ffont_get_glyphs): Don't assume index can fit in int.
5280 * font.h: Adjust decls to match defn changes elsewhere.
5281 * fontset.c (reorder_font_vector): Redo score calculation to avoid
5282 integer overflow.
5283 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
5284 printmax_t, where ptrdiff_t is wide enough.
5285 (Finternal_char_font):
5286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5287 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
5288 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
5289 (Fset_frame_position, x_set_frame_parameters)
5290 (x_set_line_spacing, x_set_border_width)
5291 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
5292 Check that fixnums are in proper range for system types.
5293 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
5294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5295 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
5296 Use SAFE_ALLOCA_LISP, not alloca.
5297 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
5298 intptr_t is wide enough.
5299 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
5300 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
5301 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
5302 Check for fixnum out of range.
5303 * ftfont.c (ftfont_list): Don't assume index fits in int.
5304 Check that fixnums are in proper range for system types.
5305 (ftfont_shape_by_flt):
5306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
5307 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5309 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
5310 Check that fixnums are in proper range for system types.
5311 * gnutls.h: Adjust decls to match defn changes elsewhere.
5312 * gtkutil.c (xg_dialog_run):
5313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5314 (update_frame_tool_bar):
5315 Check that fixnums are in proper range for system types.
5316 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 5317 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
5318 * indent.c (last_known_column, last_known_column_point):
5319 (current_column_bol_cache):
5320 (skip_invisible, current_column, check_display_width):
5321 (check_display_width, scan_for_column, current_column_1)
5322 (Findent_to, Fcurrent_indentation, position_indentation)
5323 (indented_beyond_p, Fmove_to_column, compute_motion):
5324 (Fcompute_motion, Fvertical_motion):
5325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5326 (last_known_column_modified): Use EMACS_INT, not int.
5327 (check_display_width):
5328 (Fcompute_motion):
5329 Check that fixnums and floats are in proper range for system types.
5330 (compute_motion): Don't assume index or fixnum fits in int.
5331 (compute_motion, Fcompute_motion):
5332 Use int, not EMACS_INT, when it is wide enough.
5333 (vmotion): Omit local var start_hpos that is always 0; that way
5334 we don't need to worry about overflow in expressions involving it.
5335 * indent.h: Adjust decls to match defn changes elsewhere.
5336 (struct position):
5337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5338 Use int, not EMACS_INT, where int is wide enough.
5339 Remove unused members ovstring_chars_done and tab_offset;
5340 all uses removed.
5341 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
5342 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
5343 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
5344 (make_gap, copy_text, insert, insert_and_inherit)
5345 (insert_before_markers, insert_before_markers_and_inherit)
5346 (insert_1, count_combining_before, count_combining_after)
5347 (insert_1_both, insert_from_string)
5348 (insert_from_string_before_markers, insert_from_string_1)
5349 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
5350 (adjust_after_replace, adjust_after_insert, replace_range)
5351 (replace_range_2, del_range, del_range_1, del_range_byte)
5352 (del_range_both, del_range_2, modify_region)
5353 (prepare_to_modify_buffer, signal_before_change)
5354 (signal_after_change, Fcombine_after_change_execute):
5355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5356 * intervals.c (traverse_intervals, rotate_right, rotate_left)
5357 (balance_an_interval, split_interval_right, split_interval_left)
5358 (find_interval, next_interval, update_interval)
5359 (adjust_intervals_for_insertion, delete_node, delete_interval)
5360 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5361 (static_offset_intervals, offset_intervals)
5362 (merge_interval_right, merge_interval_left, make_new_interval)
5363 (graft_intervals_into_buffer, temp_set_point_both)
5364 (temp_set_point, set_point, adjust_for_invis_intang)
5365 (set_point_both, move_if_not_intangible, get_property_and_range)
5366 (get_local_map, copy_intervals, copy_intervals_to_string)
5367 (compare_string_intervals, set_intervals_multibyte_1):
5368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5369 * intervals.h: Adjust decls to match defn changes elsewhere.
5370 (struct interval):
5371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5372 * keyboard.c (this_command_key_count, this_single_command_key_start)
5373 (before_command_key_count, before_command_echo_length, echo_now)
5374 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
5375 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
5376 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
5377 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
5378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5379 (last_non_minibuf_size, last_point_position, echo_truncate)
5380 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5381 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5382 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5383 (stuff_buffered_input):
5384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5385 (last_auto_save, command_loop_1, read_char):
5386 Use EMACS_INT, not int, to avoid integer overflow.
5387 (record_char): Avoid overflow in total_keys computation.
5388 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5389 * keyboard.h: Adjust decls to match defn changes elsewhere.
5390 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5391 (Fkey_description, Fdescribe_vector, Flookup_key):
5392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5393 (click_position): New function, to check that positions are in range.
5394 (Fcurrent_active_maps):
5395 (describe_command):
5396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5397 (Faccessible_keymaps, Fkey_description):
5398 (preferred_sequence_p):
5399 Don't assume fixnum can fit into int.
5400 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5401 Check for integer overflow in size calculations.
5402 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5403 avoid mishandling large integers.
5404 * lisp.h: Adjust decls to match defn changes elsewhere.
5405 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5406 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5407 (struct Lisp_Marker):
5408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5409 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5410 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5411 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5412 All callers changed.
5413 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5414 Assume the arg has valid form, since it always does.
5415 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5416 unsigned integer system type.
5417 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5418 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5420 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5421 (duration_to_sec_usec): New decl.
5422 * lread.c (read_from_string_index, read_from_string_index_byte)
5423 (read_from_string_limit, readchar, unreadchar, openp)
5424 (read_internal_start, read1, oblookup):
5425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5426 (Fload, readevalloop, Feval_buffer, Feval_region):
5427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5428 (openp): Check for out-of-range argument to 'access'.
5429 (read1): Use int, not EMACS_INT, where int is wide enough.
5430 Don't assume fixnum fits into int.
6efdadfd 5431 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5432 (read_filtered_event): Use duration_to_sec_usec
5433 to do proper overflow checking on durations.
d311d28c
PE
5434 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5435 in size calculation.
5436 (Fexecute_kbd_macro):
5437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5438 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5439 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5440 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5441 (set_marker_both, set_marker_restricted_both, marker_position)
5442 (marker_byte_position, Fbuffer_has_markers_at):
5443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5444 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5445 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5446 It now merely ensures that the menu is large enough, without
5447 necessarily growing it, as this avoids some integer overflow issues.
5448 All callers changed.
5449 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5451 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5452 Use SAFE_ALLOCA_LISP, not alloca.
5453 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5454 to EMACS_INT. Check that fixnums are in proper range for system types.
5455 * minibuf.c (minibuf_prompt_width, string_to_object)
5456 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5457 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5459 (get_minibuffer, read_minibuf_unwind):
5460 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5461 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5462 this simplifies overflow checking. All callers changed.
5463 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5464 (Ftest_completion):
5465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5466 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5467 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5468 Check that fixnums are in proper range for system types.
5469 (Fx_create_frame, Fx_show_tip):
5470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5471 * nsfont.m (ns_findfonts, nsfont_list_family):
5472 Don't assume fixnum fits in long.
5473 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5475 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5476 wide enough.
17fdb222 5477 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5479 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5480 (PRINTDECLARE, PRINTPREPARE):
5481 (strout, print_string):
5482 (print, print_preprocess, print_check_string_charset_prop)
5483 (print_object):
5484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5485 (PRINTDECLARE):
5486 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5488 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5489 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5490 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5491 (print_error_message): Use SAFE_ALLOCA, not alloca.
5492 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5493 (print_depth, new_backquote_output, print_number_index):
5494 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5495 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5496 (Fset_process_window_size, Fformat_network_address)
5497 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5498 (sigchld_handler):
d311d28c 5499 Check that fixnums are in proper range for system types.
d44287d4 5500 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5501 Check for process-ids out of pid_t range rather than relying on
5502 undefined behavior.
e4d81efc 5503 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5504 (Fformat_network_address, read_process_output, send_process)
5505 (Fprocess_send_region, status_notify):
5506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5507 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5508 (wait_reading_process_output, read_process_output, exec_sentinel):
5509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5510 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5511 (Faccept_process_output): Use duration_to_sec_usec to do proper
5512 overflow checking on durations.
dde14581
PE
5513 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5514 Don't assume pid_t fits in int.
02481186
PE
5515 * process.h (struct Lisp_Process): Members tick and update_tick
5516 are now of type EMACS_INT, not int.
b62b53e8
PE
5517 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5518 configured --with-wide-int.
d311d28c
PE
5519 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5520 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5521 * search.c (looking_at_1, string_match_1):
5522 (fast_string_match, fast_c_string_match_ignore_case)
5523 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5524 (scan_newline, find_before_next_newline, search_command)
5525 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5526 (set_search_regs, wordify):
5527 (Freplace_match):
5528 (Fmatch_data):
5529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5530 (string_match_1, search_buffer, set_search_regs):
5531 (Fmatch_data):
5532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5533 (wordify): Check for overflow in size calculation.
5534 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5535 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5536 Check that fixnums are in proper range for system types.
5537 * sound.c (struct sound_device)
5538 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5540 (Fplay_sound_internal):
5541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5542 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5543 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5544 (Fparse_partial_sexp):
5545 Don't assume fixnums can fit in int.
5546 (struct lisp_parse_state, find_start_pos, find_start_value)
5547 (find_start_value_byte, find_start_begv)
5548 (update_syntax_table, char_quoted, dec_bytepos)
5549 (find_defun_start, prev_char_comend_first, back_comment):
5550 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5551 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5553 (Finternal_describe_syntax_value): Check that match_lisp is a
5554 character, not an integer, since the code stuffs it into int.
5555 (scan_words, scan_sexps_forward):
5556 Check that fixnums are in proper range for system types.
5557 (Fforward_word):
5558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5559 (scan_sexps_forward):
5560 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5561 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5562 * syntax.h: Adjust decls to match defn changes elsewhere.
5563 (struct gl_state_s):
5564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5565 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5566 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5567 * sysdep.c (wait_for_termination_1, wait_for_termination)
5568 (interruptible_wait_for_termination, mkdir):
5569 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
5570 (emacs_read, emacs_write):
5571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
5572 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
5573 and double all fit in int.
d311d28c
PE
5574 * term.c (set_tty_color_mode):
5575 Check that fixnums are in proper range for system types.
5576 * termhooks.h (struct input_event):
5577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5578 * textprop.c (validate_interval_range, interval_of)
5579 (Fadd_text_properties, set_text_properties_1)
5580 (Fremove_text_properties, Fremove_list_of_text_properties)
5581 (Ftext_property_any, Ftext_property_not_all)
5582 (copy_text_properties, text_property_list, extend_property_ranges)
5583 (verify_interval_modification):
5584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5585 (Fnext_single_char_property_change)
5586 (Fprevious_single_char_property_change):
5587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
5588 (copy_text_properties):
5589 Check for integer overflow in index calculation.
d311d28c
PE
5590 * undo.c (last_boundary_position, record_point, record_insert)
5591 (record_delete, record_marker_adjustment, record_change)
5592 (record_property_change):
5593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5594 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
5595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5596 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5597 (Fx_hide_tip, Fx_file_dialog):
5598 * w32menu.c (set_frame_menubar):
5599 Use ptrdiff_t, not int, for consistency with rest of code.
5600 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5601 (select_window, Fdelete_other_windows_internal)
5602 (window_scroll_pixel_based, window_scroll_line_based)
5603 (Frecenter, Fset_window_configuration):
5604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5605 (Fset_window_hscroll, run_window_configuration_change_hook)
5606 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5607 (Fscroll_other_window, Frecenter):
d311d28c
PE
5608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5609 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5610 Don't assume fixnum fits in int.
5611 (Fset_window_scroll_bars):
5612 Check that fixnums are in proper range for system types.
5613 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5614 (string_pos, c_string_pos, number_of_chars, init_iterator)
5615 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5616 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5617 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5618 (face_before_or_after_it_pos, handle_invisible_prop)
5619 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5620 (display_prop_intangible_p, string_buffer_position_lim)
5621 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5622 (get_overlay_strings_1, get_overlay_strings)
5623 (iterate_out_of_display_property, forward_to_next_line_start)
5624 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5625 (get_next_display_element, set_iterator_to_next)
5626 (get_visually_first_element, compute_stop_pos_backwards)
5627 (handle_stop_backwards, next_element_from_buffer)
5628 (move_it_in_display_line_to, move_it_in_display_line)
5629 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5630 (add_to_log, message_dolog, message_log_check_duplicate)
5631 (message2, message2_nolog, message3, message3_nolog
5632 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5633 (current_message_1, truncate_echo_area, truncate_message_1)
5634 (set_message, set_message_1, store_mode_line_noprop)
5635 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5636 (text_outside_line_unchanged_p, check_point_in_composition)
5637 (reconsider_clip_changes)
5638 (redisplay_internal, set_cursor_from_row, try_scrolling)
5639 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5640 (redisplay_window, find_last_unchanged_at_beg_row)
5641 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5642 (trailing_whitespace_p, find_row_edges, display_line)
5643 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5644 (display_mode_element, store_mode_line_string)
5645 (pint2str, pint2hrstr, decode_mode_spec)
5646 (display_count_lines, display_string, draw_glyphs)
5647 (x_produce_glyphs, x_insert_glyphs)
5648 (rows_from_pos_range, mouse_face_from_buffer_pos)
5649 (fast_find_string_pos, mouse_face_from_string_pos)
5650 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5652 (safe_call, init_from_display_pos, handle_fontified_prop)
5653 (handle_single_display_spec, load_overlay_strings)
5654 (with_echo_area_buffer, setup_echo_area_for_printing)
5655 (display_echo_area, echo_area_display)
5656 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5657 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5658 (redisplay_window, dump_glyph_row, display_mode_line)
5659 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5660 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5662 (handle_single_display_spec, build_desired_tool_bar_string)
5663 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5664 (get_specified_cursor_type):
5665 Check that fixnums are in proper range for system types.
5666 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5667 (Flookup_image_map):
5668 Don't assume fixnums fit in int.
5669 (compare_overlay_entries):
5670 Avoid mishandling comparisons due to subtraction overflow.
5671 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5672 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5673 (handle_tool_bar_click):
5674 Use int, not unsigned, since we prefer signed and the signedness
5675 doesn't matter here.
5676 (get_next_display_element, next_element_from_display_vector):
5677 Use int, not EMACS_INT, when int is wide enough.
5678 (start_hourglass): Use duration_to_sec_usec to do proper
5679 overflow checking on durations.
5680 * xfaces.c (Fbitmap_spec_p):
5681 Check that fixnums are in proper range for system types.
5682 (compare_fonts_by_sort_order):
5683 Avoid mishandling comparisons due to subtraction overflow.
5684 (Fx_family_fonts, realize_basic_faces):
5685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5686 (Fx_family_fonts):
5687 Don't assume fixnum fits in int.
5688 Use SAFE_ALLOCA_LISP, not alloca.
5689 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5690 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5691 (face_at_buffer_position, face_for_overlay_string)
5692 (face_at_string_position):
5693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5694 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5695 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5696 (Fx_show_tip):
5697 Check that fixnums are in proper range for system types.
5698 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5699 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5701 (Fx_change_window_property): Don't assume fixnums fit in int.
5702 * xfont.c (xfont_chars_supported):
5703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5704 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5705 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5707 * xml.c (parse_region):
5708 * xrdb.c (magic_file_p):
5709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5710 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5711 (x_get_local_selection, x_reply_selection_request)
5712 (x_handle_selection_request, wait_for_property_change):
5713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5714 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5715 short is wide enough.
5716 (x_send_client_event): Don't assume fixnum fits in int.
5717 * xterm.c (x_x_to_emacs_modifiers):
5718 Don't assume EMACS_INT overflows nicely into int.
5719 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5720 may come from Lisp.
5721 (handle_one_xevent): NATNUMP can eval its arg twice.
5722 (x_connection_closed):
5723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5724 * xterm.h: Adjust decls to match defn changes elsewhere.
5725 (struct scroll_bar): Use struct vectorlike_header
5726 rather than rolling our own approximation.
5727 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5728
c6574eb5
GM
57292012-05-25 Glenn Morris <rgm@gnu.org>
5730
5731 * lisp.mk (lisp): Update for more files being compiled now.
5732
e8d32c7e
SM
57332012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5734
48def666
SM
5735 * lread.c: Remove `read_pure' which makes no difference.
5736 (read_pure): Remove var.
5737 (unreadpure): Remove function.
5738 (readevalloop): Don't call read_list with -1 flag.
5739 (read1, read_vector): Don't test read_pure any more.
5740 (read_list): Simplify.
5741
e8d32c7e
SM
5742 * fileio.c, character.h: Minor style tweaks.
5743
4b2addb7
DA
57442012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5745
5746 * window.h (clip_changed): Remove useless declaration.
5747
584461b2
JB
57482012-05-22 Juanma Barranquero <lekktu@gmail.com>
5749
5750 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5751 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5752
34374650
PE
57532012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5754
5755 Remove src/m/*.
5756 This directory predates autoconf and is no longer needed nowadays.
5757 Move its few remaining bits of functionality to where they're needed.
5758 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5759 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5760 * m/template.h: Remove.
5761 * Makefile.in (M_FILE): Remove. All uses removed.
5762 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5763 * lisp.h (USE_LSB_TAG):
5764 * mem-limits.h (EXCEEDS_LISP_PTR):
5765 Use VAL_MAX, not VALBITS, in #if.
5766 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5767 (EMACS_UINT): Define unconditionally now.
5768 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5769 (BITS_PER_EMACS_INT): New constants, replacing
5770 what used to be in config.h, but not useful in #if.
5771 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5772 define them any more.
5773 (VAL_MAX): New macro.
5774 (VALMASK): Use it.
5775 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5776 BITS_PER_EMACS_INT, in #if.
5777 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5778 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5779 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5780 * s/ms-w32.h (DATA_START):
5781 Move here from removed file m/intel386.h.
5782 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5783 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5784
261cb4bb
PE
57852012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5786
5787 Assume C89 or later.
5788 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5789 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5790 (xrealloc):
5791 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5792 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5793 * textprop.c, tparam.c (NULL): Remove.
5794 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5795 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5796 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5797 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5798 * xterm.c (input_signal_count): Assume volatile works.
5799
ff23cd9f
KB
58002012-05-21 Ken Brown <kbrown@cornell.edu>
5801
5802 * xgselect.c (xg_select): Fix first argument in call to 'select'
5803 (bug#11508).
5804
1b170bc6
KB
58052012-05-20 Ken Brown <kbrown@cornell.edu>
5806
5807 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5808 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5809
b2f4d39f
KB
58102012-05-19 Ken Brown <kbrown@cornell.edu>
5811
5812 * xfns.c (x_in_use): Remove `static' qualifier.
5813 * xterm.h (x_in_use): Declare.
5814 * xgselect.c: Include xterm.h.
5815 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5816 and `display_arg' (bug#9754).
5817
003fdae2
PE
58182012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5819
9232a6d9
PE
5820 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5821
003fdae2
PE
5822 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5823 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5824
784b56e2
EZ
58252012-05-18 Eli Zaretskii <eliz@gnu.org>
5826
5827 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5828
5829 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5830 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5831
5832 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5833 reference to image_cache->refcount.
5834 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5835
a0a79cde
JL
58362012-05-17 Juri Linkov <juri@jurta.org>
5837
5838 * search.c (Fword_search_regexp, Fword_search_backward)
5839 (Fword_search_forward, Fword_search_backward_lax)
5840 (Fword_search_forward_lax): Move functions to isearch.el
5841 (bug#10145, bug#11381).
5842
b0572523
PE
58432012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5844
5845 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5846
9660f5fc
SM
58472012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5848
5849 * lread.c (init_obarray): Declare Qt and Qnil as special.
5850
4374de83
GM
58512012-05-14 Glenn Morris <rgm@gnu.org>
5852
5853 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5854 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5855
dc44c39a
PE
58562012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5857
078c97cb
PE
5858 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5859
dc44c39a
PE
5860 * unexaix.c: Port to more-recent AIX compilers.
5861 (report_error, report_error_1, make_hdr, copy_sym)
5862 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5863 Make arguments const char *, not char *, to avoid violations of C
5864 standard and to fix some AIX warnings reported by Gilles Pion.
5865
e18afed7 58662012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5867
5868 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5869 already have overlays loaded.
5870 (handle_single_display_spec): Before returning without displaying
5871 fringe bitmap, synchronize the bidi iterator with the main display
5872 iterator, by calling iterate_out_of_display_property.
5873 (iterate_out_of_display_property): Detect buffer iteration by
5874 testing that it->string is a Lisp string.
5875 (get_next_display_element): When the current object is exhausted,
5876 and there's something on it->stack, call set_iterator_to_next to
5877 proceed with what's on the stack, instead of returning zero.
5878 (set_iterator_to_next): If called at the end of a Lisp string,
5879 proceed to consider_string_end without incrementing string
5880 position. Don't increment display vector index past the end of
5881 the display vector. (Bug#11417)
c8fb9dc6
EZ
5882 (pos_visible_p): Don't report a position visible when move_it_to
5883 stopped at the last line of window, which happens to be scanned
5884 backwards by the bidi iteration. (Bug#11464)
ac268e67 5885
e18afed7 58862012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5887
5888 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5889 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5890 are on a TTY, and thus unable to display on the fringes.
5891 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5892 so we need to signal to the caller that this is a "replacing"
5893 display spec. This fixes display when the spec is invalid or we
5894 are on a TTY.
5895
e18afed7 58962012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5897
5898 * unexaix.c (make_hdr): Fix typo in prototype.
5899 This bug broke the build on AIX. Problem reported by Gilles Pion.
5900
9d0a235a
MA
59012012-05-14 Michael Albinus <michael.albinus@gmx.de>
5902
5903 * keyboard.c (kbd_buffer_get_event): Read special events also in
5904 batch mode. (Bug#11415)
5905
9e6b06ed
GM
59062012-05-12 Glenn Morris <rgm@gnu.org>
5907
5908 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5909
c1a1d7a3
EZ
59102012-05-12 Eli Zaretskii <eliz@gnu.org>
5911
5912 * lisp.mk (lisp): Add newcomment.elc.
5913
3fe7cdc8
GM
59142012-05-12 Glenn Morris <rgm@gnu.org>
5915
5916 * Makefile.in (MKDIR_P): New, set by configure.
5917 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5918
53f7d2c0
PE
59192012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5920
5921 Remove unused function hourglass_started.
5922 * dispextern.h (hourglass_started):
5923 * w32fns.c (hourglass_started):
5924 * xdisp.c (hourglass_started): Remove.
5925
75aafb17
JB
59262012-05-10 Juanma Barranquero <lekktu@gmail.com>
5927
5928 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5929 Update dependencies.
5930
12959e8e
PE
59312012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5932
97107e2e
PE
5933 * xgselect.c (xg_select): Put maxfds+1 into a var.
5934 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5935
12959e8e
PE
5936 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5937
836d29b3
DA
59382012-05-10 Dave Abrahams <dave@boostpro.com>
5939
5940 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5941 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5942
5cb67954
MA
59432012-05-09 Michael Albinus <michael.albinus@gmx.de>
5944
5945 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5946 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5947 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5948 Initialize xd_registered_buses.
5949
3478ec45
PE
59502012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5951
b263a6b0
PE
5952 Untag more efficiently if USE_LSB_TAG.
5953 This is based on a proposal by YAMAMOTO Mitsuharu in
5954 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5955 For an admittedly artificial (nth 8000 longlist) benchmark on
5956 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5957 Emacs's overall text size by 1%.
5958 * lisp.h (XUNTAG): New macro.
5959 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5960 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5961 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5962 * eval.c (Fautoload):
5963 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5964 * frame.h (XFRAME): Use XUNTAG.
5965
3478ec45
PE
5966 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5967 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5968 Remove unportable assumptions about print widths of types like
5969 dbus_uint32_t.
5970 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5971 intptr_t when converting between pointer and integer, to avoid GCC
5972 warnings about wrong width.
5973
666b903b 59742012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5975
5976 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5977 stack for each reader_thread, instead of defaulting to 8MB
5978 determined by the linker. This avoids failures in creating
5979 subprocesses on Windows 7, see the discussion in this thread:
5980 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5981
b120cc17
JC
59822012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5983
5984 Fix up display of the *Minibuf-0* buffer in the mini window.
5985 * keyboard.c (read_char): Don't clear the echo area if there's no
5986 message to clear.
5987 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5988 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5989
9a4b36f8
MA
59902012-05-07 Michael Albinus <michael.albinus@gmx.de>
5991
5992 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5993 batch mode.
5994
e5f9458f
CY
59952012-05-06 Chong Yidong <cyd@gnu.org>
5996
5997 * lisp.mk (lisp): Update.
5998
eceeb5fc 59992012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
6000
6001 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
6002
71873e2b
SM
60032012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6004
6005 * data.c (PUT_ERROR): New macro.
6006 (syms_of_data): Use it. Add new error type `user-error'.
6007 * undo.c (user_error): New function.
6008 (Fprimitive_undo): Use it.
6009 * print.c (print_error_message): Adjust print style for `user-error'.
6010 * keyboard.c (user_error): New function.
6011 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
6012
ab0fa4e4
PE
60132012-05-03 Paul Eggert <eggert@cs.ucla.edu>
6014
6015 Do not limit current-time-string to years 1000..9999.
6016 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
6017 (Fcurrent_time_string): Support any year that is supported by the
6018 underlying localtime representation. Don't use asctime, as it
6019 has undefined behavior for years outside the range -999..9999.
6020
7ed806a7
PE
60212012-05-02 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 Fix race conditions involving setenv, gmtime, localtime, asctime.
6024 Without this fix, interrupts could mess up code that uses these
6025 nonreentrant functions, since setting TZ invalidates existing
6026 tm_zone or tzname values, and since most of these functions return
6027 pointers to static storage.
6028 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
6029 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
6030 Grow the critical sections to include not just invoking
6031 localtime/gmtime, but also accessing these functions' results
6032 including their tm_zone values if any, and any related TZ setting.
6033 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
6034 so that the struct tm is saved in the critical section.
6035 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
6036 motivated by the fact that memory allocation needs to be outside
6037 the critical section.
6038
0c16dfed
DA
60392012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
6040
6041 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
6042 with RESET_INTERVAL.
6043
6044 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6045 Remove duplicated buffer name initialization.
6046
3f83ace8
JM
60472012-05-02 Jim Meyering <jim@meyering.net>
6048
6049 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
6050
c7b8541e
JM
6051 * xfns.c (x_window): Use xstrdup (Bug#11375).
6052
90207a15 60532012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6054
6055 * xdisp.c (pos_visible_p): If already at a newline from the
6056 display string before the 'while' loop, don't walk back the glyphs
6057 from it3.glyph_row. Solves assertion violation when the display
6058 string begins with a newline (egg.el). (Bug#11367)
6059
b593d6a9
AH
60602012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
6061
6062 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6063 Move to simple.el.
6064
4737362e
GM
60652012-05-01 Glenn Morris <rgm@gnu.org>
6066
99cf43f9
GM
6067 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
6068 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
6069 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
6070 All were removed before 23.1.
6071
9311dcff
GM
6072 * dispnew.c: Remove HAVE_LIBNCURSES test;
6073 it is always true on relevant platforms.
6074
4d5c6349
GM
6075 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
6076 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
6077
4737362e
GM
6078 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
6079
74dd3a6b
AS
60802012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6081
6082 * .gdbinit (xpr): Remove checks for no longer existing misc types.
6083 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
6084 Remove.
6085
13c379ee
PE
60862012-04-28 Paul Eggert <eggert@cs.ucla.edu>
6087
6088 Do not avoid creating empty evaporating overlays (Bug#9642).
6089 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
6090 That is, do not delete an evaporating overlay if it becomes
6091 empty after its bounds are adjusted to fit within its buffer.
6092 This fix caused other problems, and I'm reverting it until we get
6093 to the bottom of them.
6094
a8e7d6d7 60952012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
6096
6097 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
6098
a8e7d6d7 60992012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
6100
6101 * xdisp.c (pos_visible_p): If the window start position is beyond
6102 ZV, start the display from buffer beginning. Prevents assertion
6103 violation in init_iterator when the minibuffer window is scrolled
6104 via the scroll bar.
6105
6106 * window.c (window_scroll_pixel_based): Likewise.
6107
a8e7d6d7 61082012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
6109
6110 * keymap.c (where_is_internal): Doc fix (Bug#10872).
6111
a8e7d6d7 61122012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
6113
6114 * fileio.c (Fcopy_file, Fset_file_selinux_context):
6115 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
6116
a8e7d6d7 61172012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 6118
b593d6a9
AH
6119 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
6120 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 6121
1c6900d9
EZ
61222012-04-26 Eli Zaretskii <eliz@gnu.org>
6123
4c3fa1d9
EZ
6124 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
6125 display element, check also the underlying string or buffer
6126 character. (Bug#11341)
6127
1c6900d9
EZ
6128 * w32menu.c: Include w32heap.h.
6129 (add_menu_item): If the call to AppendMenuW (via
6130 unicode_append_menu) fails, disable Unicode menus only if we are
6131 running on Windows 9X/Me.
6132
42bf8205
AS
61332012-04-24 Andreas Schwab <schwab@linux-m68k.org>
6134
6135 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
6136 (xgetint): Add missing shift for LSB tags.
6137
b1bac16e
MR
61382012-04-24 Martin Rudalics <rudalics@gmx.at>
6139
6140 * keyboard.c (read_char): Don't wipe echo area for select window
6141 events: These might get delayed via `mouse-autoselect-window'
6142 (Bug#11304).
6143
d69621cc
JB
61442012-04-24 Juanma Barranquero <lekktu@gmail.com>
6145
6146 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
6147 manipulation of :loaded-from data.
6148
02fd101b
JB
61492012-04-23 Juanma Barranquero <lekktu@gmail.com>
6150
6151 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
6152 now a cons (bug#11311).
6153
888bec30
PE
61542012-04-23 Paul Eggert <eggert@cs.ucla.edu>
6155
89a438bd
PE
6156 Do not create empty overlays with the evaporate property (Bug#9642).
6157 * buffer.c (Fmove_overlay): Delete an evaporating overlay
6158 if it becomes empty after its bounds are adjusted to fit within
6159 its buffer. Without this fix, in a nonempty buffer (let ((o
6160 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
6161 yields an empty overlay that has the evaporate property, which is
6162 not supposed to happen.
6163
1068fe4d
PE
6164 Fix minor GTK3 problems found by static checking.
6165 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6166 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6167 (struct _EmacsFixedClass, emacs_fixed_get_type):
6168 Move decls here from emacsgtkfixed.h, since they needn't be public.
6169 (emacs_fixed_get_type): Now static.
6170 (emacs_fixed_class_init): Omit unused local.
6171 (emacs_fixed_child_type): Remove; unused.
6172 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6173 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6174 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
6175 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
6176 (EMACS_FIXED_GET_CLASS): Remove; unused.
6177 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
6178
888bec30
PE
6179 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
6180 Problem reported by Juanma Barranquero for Windows -Wunused-function.
6181
de85e130
PE
61822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6183
d0baac98 6184 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 6185 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
6186 (__malloc_size_t, __malloc_ptrdiff_t):
6187 Remove. All uses removed, replaced by the definiens if needed,
6188 since we can assume C89 or better now.
6189 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
6190 (protect_malloc_state, align, get_contiguous_space)
6191 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
6192 (malloc_atfork_handler_child, malloc_enable_thread)
6193 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
6194 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
6195 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
6196 (special_realloc, _realloc_internal_nolock, _realloc_internal)
6197 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
6198 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
6199 Define using prototypes, not old style.
6200 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
6201 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
6202 (align): Don't assume that signed integer overflow wraps around.
6203 Omit unused local var.
6204 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
6205 (_free_internal_nolock, memalign, mallochook, reallochook):
6206 Omit no-longer-needed casts.
6207 (valloc): Use getpagesize, not __getpagesize.
6208 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
6209 (struct hdr): The 'magic' member is now size_t, not unsigned long.
6210
de85e130
PE
6211 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
6212
dcbf5805
MA
62132012-04-22 Michael Albinus <michael.albinus@gmx.de>
6214
6215 Move functions from C to Lisp. Make non-blocking method calls
6216 the default. Implement further D-Bus standard interfaces.
6217
6218 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
6219 (QCdbus_request_name_allow_replacement)
6220 (QCdbus_request_name_replace_existing)
6221 (QCdbus_request_name_do_not_queue)
6222 (QCdbus_request_name_reply_primary_owner)
6223 (QCdbus_request_name_reply_in_queue)
6224 (QCdbus_request_name_reply_exists)
6225 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
6226 (QCdbus_registered_serial, QCdbus_registered_method)
6227 (QCdbus_registered_signal): New Lisp objects.
6228 (XD_DEBUG_MESSAGE): Use sizeof.
6229 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
6230 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
6231 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
6232 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
6233 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
6234 (xd_signature, xd_append_arg): Allow float for integer types.
6235 (xd_get_connection_references): New function.
b593d6a9
AH
6236 (xd_get_connection_address): Rename from xd_initialize.
6237 Return cached address.
dcbf5805
MA
6238 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
6239 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
6240 level.
6241 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 6242 Return number of refcounts.
dcbf5805
MA
6243 (Fdbus_get_unique_name): Make stronger parameter check.
6244 (Fdbus_message_internal): New defun.
6245 (Fdbus_call_method, Fdbus_call_method_asynchronously)
6246 (Fdbus_method_return_internal, Fdbus_method_error_internal)
6247 (Fdbus_send_signal, Fdbus_register_service)
6248 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
6249 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
6250 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
6251 (Vdbus_compiled_version, Vdbus_runtime_version)
6252 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
6253 (Vdbus_message_type_method_return, Vdbus_message_type_error)
6254 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
6255 (Vdbus_registered_buses, Vdbus_registered_objects_table):
6256 Adapt docstring.
dcbf5805 6257
52828e02
PE
62582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6259
da05bc4c
PE
6260 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
6261 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
6262 Do not assume ptrdiff_t is the same width as 'int'.
6263
52828e02
PE
6264 * alloc.c: Handle unusual debugging option combinations.
6265 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
6266 since the two debugging options are incompatible.
6267 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
6268 is defined.
6269 (mem_init, mem_insert, mem_insert_fixup):
6270 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
6271 (NEED_MEM_INSERT): Remove; no longer needed.
6272
f01769f9
LL
62732012-04-22 Leo Liu <sdl.web@gmail.com>
6274
6275 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
6276
5790543d
PE
62772012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6278
6279 * sysdep.c [__FreeBSD__]: Minor cleanups.
6280 (list_system_processes, system_process_attributes) [__FreeBSD__]:
6281 Use Emacs indenting style more consistently. Avoid some casts.
6282 Use 'double' consistently rather than mixing 'float' and 'double'.
6283
b91b7e4d
EW
62842012-04-21 Eduard Wiebe <usenet@pusto.de>
6285
b593d6a9
AH
6286 * sysdep.c (list_system_processes, system_process_attributes):
6287 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 6288
6114eb15
AS
62892012-04-21 Andreas Schwab <schwab@linux-m68k.org>
6290
6291 * lisp.mk (lisp): Update.
6292
2f38dff7
PE
62932012-04-20 Paul Eggert <eggert@cs.ucla.edu>
6294
6295 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
6296 It is never used otherwise.
6297
4ae29f89
SM
62982012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
6299
6300 * print.c (print_preprocess): Only check print_depth if print-circle
6301 is nil.
6302 (print_object): Check for cycles even when print-circle is nil and
6303 print-gensym is t, but only check print_depth if print-circle is nil.
6304
f30d612a
CY
63052012-04-20 Chong Yidong <cyd@gnu.org>
6306
6307 * process.c (wait_reading_process_output): If EIO occurs on a pty,
6308 set the status to "failed" and ensure that sentinel is run.
6309
c07a4c0b 63102012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
6311
6312 * process.c (Fset_process_inherit_coding_system_flag)
6313 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 6314 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 6315
c07a4c0b 63162012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
6317
6318 * xdisp.c (string_buffer_position_lim): Limit starting position to
6319 BEGV.
6320 (set_cursor_from_row): If called for a mode-line or header-line
6321 row, return zero immediately.
6322 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
6323 farther than the first row after the header line, if any.
6324 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
6325 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
6326
c07a4c0b 63272012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6328
4ae29f89
SM
6329 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
6330 (bug#11238).
ad3a2b41 6331
c07a4c0b 63322012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 63332012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
6334
6335 configure: new option --enable-gcc-warnings (Bug#11207)
6336 * Makefile.in (C_WARNINGS_SWITCH): Remove.
6337 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6338 (ALL_CFLAGS): Use new macros rather than old.
6339 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
6340 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
6341 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
6342 -Wunused-result, -Wunused-variable. This should go away once
6343 the Emacs and Gnulib regex code is merged.
6344 (xmalloc, xrealloc): Now static.
6345
aba027e8
PE
63462012-04-17 Paul Eggert <eggert@cs.ucla.edu>
6347
6348 * dired.c (Fsystem_groups): Remove unused local.
6349
e5a36063
GM
63502012-04-17 Glenn Morris <rgm@gnu.org>
6351
6352 * dired.c (Fsystem_users): Doc fix.
6353
316411f0
DA
63542012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
6355
6356 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
6357 (syms_of_dired): Add them.
6358
9426aba4
PE
63592012-04-16 Paul Eggert <eggert@cs.ucla.edu>
6360
b62a57be
PE
6361 Fix minor alloc.c problems found by static checking.
6362 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
6363 New extern decls, to avoid calling undeclared functions.
6364 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
6365 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
6366 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
6367 (NEED_MEM_INSERT): New macro.
6368 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 6369 Remove one incorrect comment and fix another.
b62a57be 6370
3539f31f
PE
6371 Fix minor ralloc.c problems found by static checking.
6372 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6373 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6374 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
6375 (r_alloc_sbrk): Now static.
6376
a041960a
PE
6377 Improve ralloc.c interface checking.
6378 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6379 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6380 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6381 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6382 [REL_ALLOC]: ... to here, to check interface.
6383 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6384 Remove decls. This fixes an "It stinks!".
6385
9426aba4
PE
6386 * alloc.c (which_symbols): Fix alignment issue / type clash.
6387
d55c12ed
AS
63882012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6389
6390 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6391 (struct Lisp_Misc_Any): Likewise.
6392 (struct Lisp_Free): Likewise.
6393 * alloc.c (union aligned_Lisp_Symbol): Define.
6394 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6395 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6396 (union aligned_Lisp_Misc): Define.
6397 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6398 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6399 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6400
b948ce8b
PE
64012012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6402
6403 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6404 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6405 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6406 * s/netbsd.h, s/sol2-6.h:
6407 Remove definition of GC_MARK_STACK, since the default now works.
6408 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6409 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6410 no longer the default.
6411 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6412
35dc09a1 64132012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6414
35dc09a1
GM
6415 * lread.c (lisp_file_lexically_bound_p):
6416 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6417
35dc09a1
GM
64182012-04-14 Eli Zaretskii <eliz@gnu.org>
6419
6420 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6421 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6422
64232012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6424
6425 * nsterm.m (constrainFrameRect): Always constrain when there is only
6426 one screen (Bug#10962).
6427
bcd86815
KB
64282012-04-13 Ken Brown <kbrown@cornell.edu>
6429
6430 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6431
c25df26e
RT
64322012-04-13 Reuben Thomas <rrt@sc3d.org>
6433
6434 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6435
0fc59f1e
DC
64362012-04-11 Daniel Colascione <dancol@dancol.org>
6437
6438 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6439 against is gone. It's better to use vfork now so that when Cygwin
6440 gains a new, working vfork, we use it automatically (bug#10398).
6441
de8c03dc
SM
64422012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6443
6444 * window.c (save_window_save): Obey window-point-insertion-type.
6445
2f097256
GM
64462012-04-11 Glenn Morris <rgm@gnu.org>
6447
6448 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6449
453b951e
SM
64502012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6451
6452 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6453
75f1671a 64542012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6455
6456 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6457 (force_quit_count): New var.
6458 (handle_interrupt): Use it.
6459
2a8ce227
JB
64602012-04-10 Juanma Barranquero <lekktu@gmail.com>
6461
6462 * w32.c (w32_delayed_load): Record the full path of the library
6463 being loaded (bug#10424).
6464
935396c0
GM
64652012-04-09 Glenn Morris <rgm@gnu.org>
6466
05920a43
GM
6467 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6468 not just in the obarray, before snarfing them. (Bug#11036)
6469
935396c0
GM
6470 * Makefile.in ($(leimdir)/leim-list.el):
6471 Pass EMACS rather than BUILT_EMACS.
6472
a18ecafa
TZ
64732012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6474
6475 * process.c (make_process):
6476 * process.h: Add integer `gnutls_handshakes_tried' member to
6477 process struct.
6478
6bbef4e5
JC
6479 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6480 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6481
6482 * gnutls.c (gnutls_log_function2i): Convenience log function.
6483 (emacs_gnutls_read): Use new log functions,
6484 `gnutls_handshakes_tried' process member, and
6485 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6486 attempts per process (connection).
6487
b4d3bc10
CY
64882012-04-09 Chong Yidong <cyd@gnu.org>
6489
6490 * eval.c (Fuser_variable_p, user_variable_p_eh)
6491 (lisp_indirect_variable): Functions deleted.
6492 (Fdefvar): Caller changed.
6493
6494 * callint.c (Finteractive, Fcall_interactively):
6495 * minibuf.c (Fread_variable): Callers changed.
6496
70f4d973
EZ
64972012-04-09 Eli Zaretskii <eliz@gnu.org>
6498
6499 * xdisp.c (set_cursor_from_row): If the display string appears in
6500 the buffer at position that is closer to point than the position
6501 after the display string, display the cursor on the first glyph of
6502 the display string. Fixes cursor display when a 'display' text
6503 property immediately follows invisible text. (Bug#11094)
6504
cb3c2e3e
PE
65052012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6506
6507 composite.c: use 'double' consistently
6508 * composite.c (get_composition_id): Use 'double' consistently
6509 instead of converting 'float' to 'double' and vice versa; this is
6510 easier to understand and avoids a GCC warning.
6511
fd06db5d
GM
65122012-04-09 Glenn Morris <rgm@gnu.org>
6513
50fe702a
GM
6514 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6515 preparation for dumping it with emacs. (Bug#4789)
6516 (leimdir): New variable.
6517 ($(leimdir)/leim-list.el): New rule.
6518 (emacs$(EXEEXT)): Depend on leim-list.el.
6519
fd06db5d
GM
6520 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6521 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6522 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6523
55c131ee
AS
65242012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6525
6526 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6527 proper alignment.
6528
9209588f
JB
65292012-04-07 Juanma Barranquero <lekktu@gmail.com>
6530
6531 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6532 Remove unused local variable.
6533
e3fb2efb
PE
65342012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6535
6536 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6537 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6538 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6539 objects, as mark_maybe_pointer will catch them otherwise.
6540 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6541 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6542
b5385551
PE
65432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6544
6545 Fix typo that broke non-Windows builds.
6546 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6547
9078ead6
EZ
65482012-04-07 Eli Zaretskii <eliz@gnu.org>
6549
6550 Support building on MS-Windows with libxml2.
6551
6552 * makefile.w32-in (OBJ2): Add xml.$(O).
6553 (GLOBAL_SOURCES): Add xml.c.
6554 ($(BLD)/xml.$(O)): New dependency list.
6555
6556 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6557 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6558 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6559 [!WINDOWSNT]: New macros.
6560 (init_libxml2_functions, libxml2_loaded_p): New functions.
6561 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6562 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6563 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6564 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6565 linked in).
6bbef4e5
JC
6566 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6567 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6568 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
6569
6570 * emacs.c: Don't include libxml/parser.h.
6571 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
6572 xmlCleanupParser directly.
6573
6574 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
6575
3811fdf3
EZ
65762012-04-07 Eli Zaretskii <eliz@gnu.org>
6577
6578 * indent.c (Fvertical_motion): If there is a display string at
6579 point, use it.vpos to compute how many lines to backtrack after
6580 move_it_to point. (Bug#11133)
6581
2f8e16b2
EZ
65822012-04-06 Eli Zaretskii <eliz@gnu.org>
6583
6584 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
6585 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
6586 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6587 macros related to unification of CJK characters. For the details,
6588 see the discussion following the message here:
6589 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
6590
3d439cd1
CY
65912012-04-04 Chong Yidong <cyd@gnu.org>
6592
6593 * keyboard.c (Vdelayed_warnings_list): Doc fix.
6594
8bc53d00
EZ
65952012-04-01 Eli Zaretskii <eliz@gnu.org>
6596
6597 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6598 instead of alloca. (Bug#11138)
6599
3b0512a3
AS
66002012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6601
6602 * w32menu.c (is_simple_dialog): Properly check lisp types.
6603 (Bug#11141)
6604
8427ddd2
EZ
66052012-03-31 Eli Zaretskii <eliz@gnu.org>
6606
979022ef
EZ
6607 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6608 position we get to after a call to move_it_to fails the
6609 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6610 only if we wind up in a string from display property. (Bug#11063)
6611
a6b1c7cc
EZ
6612 * window.c (Fdelete_other_windows_internal): Invalidate the row
6613 and column information about mouse highlight, so that redisplay
6614 restores it after reallocating the glyph matrices. (Bug#7464)
6615
8427ddd2
EZ
6616 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6617 string comes from a `display' text property, use the buffer
6618 position of that property as if we actually saw that position in
6619 the row's glyphs.
697ba24b
EZ
6620 (move_it_by_lines): Remove the assertion that
6621 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6622 violated when there's a before-string at the beginning of a line.
6623 (Bug#11063)
8427ddd2 6624
65a0a738
EZ
66252012-03-30 Eli Zaretskii <eliz@gnu.org>
6626
6627 * xdisp.c (append_space_for_newline): If the default face was
6628 remapped, use the remapped face for the appended newline.
6629 (extend_face_to_end_of_line): Use the remapped default face for
6630 extending the face to the end of the line.
6631 (display_line): Call extend_face_to_end_of_line when the default
6632 face was remapped. (Bug#11068)
6633
581355cc
EZ
66342012-03-29 Eli Zaretskii <eliz@gnu.org>
6635
6636 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6637
e8fc049f
SM
66382012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6639
6640 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6641
4fb9a543
GM
66422012-03-27 Glenn Morris <rgm@gnu.org>
6643
6644 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6645 Doc fixes.
6646
679910f1
KH
66472012-03-26 Kenichi Handa <handa@m17n.org>
6648
6649 * dispextern.h (struct glyph): Fix previous change. Change the
6650 bit length of glyphless.ch to 25 (Bug#11082).
6651
90d49b7f
CY
66522012-03-26 Chong Yidong <cyd@gnu.org>
6653
6654 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6655 (command_loop_1): Use it; inhibit selection update for
6656 handle-select-window too (Bug#8996).
6657
f514f6f0
FP
66582012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6659
e8fc049f 6660 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6661
bf43fa51
KH
66622012-03-25 Kenichi Handa <handa@m17n.org>
6663
6664 * dispextern.h (struct glyph): Change the bit length of
6665 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6666
8a0c01dd
EZ
66672012-03-24 Eli Zaretskii <eliz@gnu.org>
6668
6669 * s/ms-w32.h (tzname): Include time.h before redirecting to
6670 _tzname. Fixes the MSVC build. (Bug#9960)
6671
7d1c3a76
AS
66722012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6673
8ed79523
AS
6674 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6675 characters.
6676
7d1c3a76
AS
6677 * xterm.c (XTread_socket): Only modify handling_signal if
6678 !SYNC_INPUT. (Bug#11080)
6679
e99a9b8b
EZ
66802012-03-23 Eli Zaretskii <eliz@gnu.org>
6681
6682 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6683 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6684 when fetching a multibyte character consumes more bytes than
6685 CHAR_BYTES returns, due to unification of CJK characters in
6686 string_char. (Bug#11073)
6687
5063c0e1
TN
66882012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6689
6690 * process.c (wait_reading_process_output): Handle pty disconnect
6691 by refraining from sending oneself a SIGCHLD (bug#10933).
6692
9f851fbd
CY
66932012-03-22 Chong Yidong <cyd@gnu.org>
6694
6695 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6696
5063c0e1 6697 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6698 Mark string as coming from a prefix property.
6699 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6700 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6701
fb5b8aca
CY
67022012-03-21 Chong Yidong <cyd@gnu.org>
6703
6704 * xfaces.c (Vface_remapping_alist): Doc fix.
6705
62356a1b
EZ
67062012-03-20 Eli Zaretskii <eliz@gnu.org>
6707
6708 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6709 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6710 Doc fixes.
62356a1b 6711
025de85b
CY
67122012-03-20 Chong Yidong <cyd@gnu.org>
6713
6714 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6715 to reflect default non-nil value of redisplay-dont-pause.
6716
4827f94e
KH
67172012-03-19 Kenichi Handa <handa@m17n.org>
6718
6719 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6720 it fit in a valid range (Bug#11003).
6721
e50a24a2
EZ
67222012-03-18 Eli Zaretskii <eliz@gnu.org>
6723
6724 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6725 that is not from display property, accept the row as a "cursor
6726 row" if one of the string's character has a non-nil `cursor'
6727 property. Fixes cursor positioning when there are newlines in
6728 overlay strings, e.g. in icomplete.el. (Bug#11035)
6729
9af5ed87
PE
67302012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6731
6732 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6733
d1f55f16
CY
67342012-03-12 Chong Yidong <cyd@gnu.org>
6735
6736 * eval.c (inhibit_lisp_code): Rename from
6737 inhibit_window_configuration_change_hook; move from window.c.
6738
6739 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6740 * window.c (run_window_configuration_change_hook)
6741 (syms_of_window): Callers changed.
6742
66c5eebd
CY
67432012-03-11 Chong Yidong <cyd@gnu.org>
6744
413df973
CY
6745 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6746
66c5eebd
CY
6747 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6748
1de11f56
CY
67492012-03-10 Chong Yidong <cyd@gnu.org>
6750
6751 * frame.c (other_visible_frames): Don't assume the selected frame
6752 is visible (Bug#10955).
6753
cae07000
SM
67542012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6755
6756 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6757
89c94350
JD
67582012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6759
6760 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6761 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6762 zero (Bug#10954).
6763
999dd333
GM
67642012-03-03 Glenn Morris <rgm@gnu.org>
6765
01a6dcc8 6766 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6767
de0100f2
EZ
67682012-03-02 Eli Zaretskii <eliz@gnu.org>
6769
6770 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6771 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6772 (redisplay_window, next_element_from_string): Fix typos in
6773 comments.
3e441275
EZ
6774 (redisplay_window): Pass to move_it_vertically the margin in
6775 pixels, not in screen lines.
de0100f2 6776
96a72ee9
GM
67772012-03-02 Glenn Morris <rgm@gnu.org>
6778
6779 * buffer.c (buffer-list-update-hook): Doc fix.
6780
312508d7
EZ
67812012-02-29 Eli Zaretskii <eliz@gnu.org>
6782
6783 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6784 push_it before setting up the iterator for the first overlay
6785 string, even if we have an empty string loaded.
6786 (next_overlay_string): If there's an empty string on the iterator
6787 stack, pop the stack. (Bug#10903)
6788
27f3c637
PE
67892012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6790
6791 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6792 Suggested by Stefan Monnier in
6793 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6794 * alloc.c (widen_to_Lisp_Object): New static function.
6795 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6796 and widening them to Lisp_Objects. This would work even if
6797 USE_LSB_TAG is defined and wide integers are used, which might
6798 happen in a future version of Emacs.
6799
3c9dfce6
CY
68002012-02-25 Chong Yidong <cyd@gnu.org>
6801
fa74b241
CY
6802 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6803 Doc fix.
6804
3c9dfce6
CY
6805 * xselect.c (Fx_selection_exists_p): Doc fix.
6806 (x_clipboard_manager_save_all): Print an informative message
6807 before saving to clipboard manager.
6808
9486df08
CY
68092012-02-24 Chong Yidong <cyd@gnu.org>
6810
6811 * keyboard.c (process_special_events): Handle all X selection
6812 requests in kbd_buffer, not just the next one (Bug#8869).
6813
f01d3321
CY
68142012-02-23 Chong Yidong <cyd@gnu.org>
6815
6816 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6817 call when setting menu-bar-lines and tool-bar-lines parameters.
6818 (unwind_create_frame_1): New helper function.
6819
6820 * window.c (inhibit_window_configuration_change_hook): New var.
6821 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6822 (syms_of_window): Initialize it.
f01d3321 6823
86b847b6
CY
68242012-02-22 Chong Yidong <cyd@gnu.org>
6825
6826 * xterm.c (x_draw_image_relief): Add missing type check for
6827 Vtool_bar_button_margin (Bug#10743).
6828
a59225b1
CY
68292012-02-21 Chong Yidong <cyd@gnu.org>
6830
6831 * fileio.c (Vfile_name_handler_alist): Doc fix.
6832
6833 * buffer.c (Fget_file_buffer): Protect against invalid file
6834 handler return value.
6835
310f5bd4
PE
68362012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6837
cb3a28cc
PE
6838 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6839 when computing $valmask.
6840
310f5bd4
PE
6841 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6842 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6843 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6844 It's useless in that case, and it can cause problems on hosts
6845 that allocate halves of EMACS_INT values separately.
6846 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6847 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6848 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6849 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6850 it avoids undefined behavior on hosts where shifting right by more
6851 than the word width has undefined behavior.
6852
2375c96a
CY
68532012-02-19 Chong Yidong <cyd@gnu.org>
6854
6855 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6856 (Funhandled_file_name_directory, Ffile_name_as_directory)
6857 (Fdirectory_file_name, Fexpand_file_name)
6858 (Fsubstitute_in_file_name): Protect against invalid file handler
6859 return values (Bug#10845).
6860
3eb49e71
EZ
68612012-02-18 Eli Zaretskii <eliz@gnu.org>
6862
6863 * .gdbinit (pitx): Fix incorrect references to fields of the
6864 iterator stack.
6865
7b926f3f
CY
68662012-02-17 Chong Yidong <cyd@gnu.org>
6867
6868 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6869
11273115
PE
68702012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6871
6872 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6873 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6874
c3a70e2b
CY
68752012-02-15 Chong Yidong <cyd@gnu.org>
6876
6877 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6878 marked as special. Also, starting docstrings with * is obsolete.
6879
0ca43699
AS
68802012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6881
6882 * gnutls.c (emacs_gnutls_write): Fix last change.
6883
2e8f3c56
LI
68842012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6885
6886 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6887 send_process.
6888
af70074f
SM
68892012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6890
6891 * keymap.c (Fsingle_key_description): Handle char ranges.
6892
95986d52
CY
68932012-02-12 Chong Yidong <cyd@gnu.org>
6894
afd83bd1
CY
6895 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6896 as that creates a dangerous corner case.
6897
95986d52
CY
6898 * window.c (Fdelete_window_internal): Invalidate the mouse
6899 highlight (Bug#9904).
6900
bd7da63e
GM
69012012-02-12 Glenn Morris <rgm@gnu.org>
6902
6903 * xselect.c (Fx_own_selection_internal)
6904 (Fx_get_selection_internal, Fx_disown_selection_internal)
6905 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6906 * nsselect.m (Fx_own_selection_internal)
6907 (Fx_disown_selection_internal, Fx_selection_exists_p)
6908 (Fx_selection_owner_p, Fx_get_selection_internal):
6909 Sync docs and argument specs with the xselect.c versions.
6910
77abcbc2
LI
69112012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6912
6913 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6914
90b671e2
EZ
69152012-02-11 Eli Zaretskii <eliz@gnu.org>
6916
1c0ca0b7
EZ
6917 * w32select.c (Fx_selection_exists_p): Sync doc string and
6918 argument list with xselect.c. (Bug#10783)
6919
6920 * w16select.c (Fx_selection_exists_p): Sync doc string and
6921 argument list with xselect.c. (Bug#10783)
90b671e2 6922
49241268
GM
69232012-02-10 Glenn Morris <rgm@gnu.org>
6924
6925 * fns.c (Fsecure_hash): Doc fix.
6926
f998bbe7 69272012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6928
6929 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6930
0992bd9c
CY
69312012-02-07 Chong Yidong <cyd@gnu.org>
6932
6933 * buffer.c (Fbuffer_local_variables)
6934 (buffer_lisp_local_variables): Handle unbound vars correctly;
6935 don't let Qunbound leak into Lisp.
6936
af008560
GM
69372012-02-07 Glenn Morris <rgm@gnu.org>
6938
dd605cc4
GM
6939 * image.c (Fimagemagick_types): Doc fix.
6940
af008560
GM
6941 * image.c (imagemagick-render-type): Change it from a lisp object
6942 to an integer. Move the doc here from the lisp manual.
6943 Treat all values not equal to 0 the same.
6944
1449fa1d
CY
69452012-02-06 Chong Yidong <cyd@gnu.org>
6946
6947 * doc.c (store_function_docstring): Avoid applying docstring of
6948 alias to base function (Bug#2603).
6949
3723ec07
AS
69502012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6951
6952 * .gdbinit (pp1, pv1): Remove redundant defines.
6953 (pr): Use pp.
6954
79c1cc1e
CY
69552012-02-04 Chong Yidong <cyd@gnu.org>
6956
6957 * nsterm.m: Declare a global (Bug#10694).
6958
d7f29f8e
EZ
69592012-02-04 Eli Zaretskii <eliz@gnu.org>
6960
cae07000
SM
6961 * w32.c (get_emacs_configuration_options):
6962 Include --enable-checking, if specified, in the return value.
d7f29f8e 6963
3b95a6f9
MR
69642012-02-04 Martin Rudalics <rudalics@gmx.at>
6965
6966 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6967 after rounding frame sizes. (Bug#9723)
6968
d6fa96a6
EZ
69692012-02-04 Eli Zaretskii <eliz@gnu.org>
6970
6971 * keyboard.c (adjust_point_for_property): Don't position point
6972 before BEGV. (Bug#10696)
6973
df0b2940
PE
69742012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6975
6976 Handle overflow when computing char display width (Bug#9496).
6977 * character.c (char_width): Return EMACS_INT, not int.
6978 (char_width, c_string_width): Check for overflow when
6979 computing the width; this is possible now that individual
6980 characters can have unbounded width. Problem introduced
6981 by merge from Emacs 23 on 2012-01-19.
6982
6bee44d6
MA
69832012-02-02 Michael Albinus <michael.albinus@gmx.de>
6984
6985 * dbusbind.c (Fdbus_register_method): Mention the return value
6986 :ignore in the docstring.
6987
44f92739
GM
69882012-02-02 Glenn Morris <rgm@gnu.org>
6989
1b9f60cc
GM
6990 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6991
44f92739
GM
6992 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6993 Unconditionally set to t. (Bug#10673)
6994 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6995 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6996 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6997
c5d3843c
KH
69982012-02-02 Kenichi Handa <handa@m17n.org>
6999
7000 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
7001 0, do not call append_composite_glyph.
7002
159462d4 70032012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
7004
7005 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
7006 NULL (Bug#6988).
7007 (x_produce_glyphs): If the component of a composition is a null
7008 string, set it->pixel_width to 1 to avoid zero-width glyph.
7009
78cef877
EZ
70102012-02-01 Eli Zaretskii <eliz@gnu.org>
7011
7012 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
7013 first 2 arguments are identical. This makes inserting large
7014 output from a subprocess an order of magnitude faster on
7015 MS-Windows, where all sbrk'ed memory is always contiguous.
7016
97897668
GM
70172012-01-31 Glenn Morris <rgm@gnu.org>
7018
7019 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 7020 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
7021 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
7022
31fd3586
GM
70232012-01-29 Glenn Morris <rgm@gnu.org>
7024
7025 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
7026
0e24a8b2
CY
70272012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
7028
7029 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
7030
cc0adcb0
CY
70312012-01-28 Chong Yidong <cyd@gnu.org>
7032
7033 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
7034
acc28cb9
CY
70352012-01-26 Chong Yidong <cyd@gnu.org>
7036
9c69cfb7
CY
7037 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
7038
acc28cb9
CY
7039 * search.c (Fsearch_forward, Fsearch_backward): Document negative
7040 repeat counts (Bug#10507).
7041
48da7392
GM
70422012-01-26 Glenn Morris <rgm@gnu.org>
7043
7044 * lread.c (syms_of_lread): Doc fix.
7045
14af5f7f
CY
70462012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7047
7048 * coding.c (encode_designation_at_bol): Change return value to
7049 EMACS_INT.
7050
0b21c100
CY
70512012-01-25 Chong Yidong <cyd@gnu.org>
7052
7053 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
7054
3c2907f7
CY
70552012-01-21 Chong Yidong <cyd@gnu.org>
7056
7057 * floatfns.c (Fcopysign): Make the second argument non-optional,
7058 since nil is not allowed anyway.
7059
959ad23f
AS
70602012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7061
7062 * process.c (read_process_output): Use p instead of XPROCESS (proc).
7063 (send_process): Likewise.
7064
34a02f46
MR
70652012-01-19 Martin Rudalics <rudalics@gmx.at>
7066
7067 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
7068 (Vwindow_persistent_parameters): Do not use Qstate.
7069 Rewrite doc-strings.
34a02f46 7070
1259009a 70712012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
7072
7073 * character.c (char_width): New function.
70d4fdf6
GM
7074 (Fchar_width, c_string_width, lisp_string_width):
7075 Use char_width (Bug#9496).
25ed9e61 7076
6a6ee00d
MR
70772012-01-16 Martin Rudalics <rudalics@gmx.at>
7078
7079 * window.c (Vwindow_persistent_parameters): New variable.
7080 (Fset_window_configuration, save_window_save): Handle persistent
7081 window parameters.
7082
c85efaf7
EZ
70832012-01-14 Eli Zaretskii <eliz@gnu.org>
7084
7085 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
7086 thrashing the stack of the thread. (Bug#9087)
7087
5944709e
PE
70882012-01-12 Paul Eggert <eggert@cs.ucla.edu>
7089
7090 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
7091
e71f5d99
EZ
70922012-01-11 Eli Zaretskii <eliz@gnu.org>
7093
7094 * xdisp.c (rows_from_pos_range): Handle the case where the
7095 highlight ends on a newline. (Bug#10464)
7096 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
7097 he end column for display of highlight that ends on a newline
7098 before a R2L line.
7099
ce316182
GM
71002012-01-11 Glenn Morris <rgm@gnu.org>
7101
7102 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
7103 from load-path also when installation-directory is nil. (Bug#10208)
7104
5b43da69
GM
71052012-01-10 Glenn Morris <rgm@gnu.org>
7106
74cc8ff9
GM
7107 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
7108
7d8d6e4e
GM
7109 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
7110 Update template values to be closer to their typical values these days.
5b43da69 7111
a0db8d43
EZ
71122012-01-09 Eli Zaretskii <eliz@gnu.org>
7113
7114 * xdisp.c (rows_from_pos_range): Accept additional argument
7115 DISP_STRING, and accept any glyph in a row whose object is that
7116 string as eligible for mouse highlight. Fixes mouse highlight of
7117 display strings from overlays. (Bug#10464)
7118
9a0115ab 71192012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 7120
b9110d6a 7121 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
7122 * fileio.c (auto_saving_dir_umask): New static var.
7123 (Fmake_directory_internal): Use it.
7124 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7125 creating the directory. The old code temporarily assigns
7126 too-generous permissions to the directory.
7127 (do_auto_save_eh): Clear it.
b9110d6a 7128 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
7129 that the var is always cleared.
7130
6c1bd3f3
EZ
71312012-01-07 Eli Zaretskii <eliz@gnu.org>
7132
7133 * search.c (scan_buffer): Pass character positions to
7134 know_region_cache, not byte positions. (Bug#6540)
7135
069d2b50
L
71362012-01-07 LynX <_LynX@bk.ru> (tiny change)
7137
7138 * w32.c (sys_rename): Report EXDEV when rename of a directory
7139 fails because the target is on another logical disk. (Bug#10284)
7140
75bf0d33
DB
71412012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
7142
7143 * xterm.c (x_embed_request_focus): New function.
7144
7145 * xterm.h: Add prototype.
7146
7147 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
7148
1c6e5a32
GM
71492012-01-05 Glenn Morris <rgm@gnu.org>
7150
7151 * emacs.c (emacs_copyright): Update short copyright year to 2012.
7152
651e947e
EZ
71532012-01-01 Eli Zaretskii <eliz@gnu.org>
7154
7155 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
7156 Load gnutls_transport_set_lowat only if GnuTLS version is below
7157 2.11.1.
7158 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
7159 GnuTLS versions below 2.11.1.
7160
3778cdd8
AL
71612011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
7162
7163 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
7164 to the doc string advising against its use for altering the way
7165 windows are scrolled.
7166
0e5317f7
KH
71672011-12-28 Kenichi Handa <handa@m17n.org>
7168
7169 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
7170 coding-system ASCII compatible only when it does not produce BOM
7171 on encoding (Bug#10383).
7172
93d5ca1f
JD
71732011-12-26 Jan Djärv <jan.h.d@swipnet.se>
7174
7175 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
7176 can scroll.
7177 (create_and_show_popup_menu): Always use menu_position_func for
7178 Gtk3 (Bug#10361).
7179
ca22b785
AS
71802011-12-24 Andreas Schwab <schwab@linux-m68k.org>
7181
7182 * callint.c (Fcall_interactively): Don't truncate prompt string.
7183
d048e1e6
EZ
71842011-12-23 Eli Zaretskii <eliz@gnu.org>
7185
7186 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
7187 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 7188 resumed from there (after widening). (Bug#10360)
d048e1e6 7189
5ccaba1f
JD
71902011-12-22 Jan Djärv <jan.h.d@swipnet.se>
7191
7192 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
7193
204ee57f
JD
71942011-12-21 Jan Djärv <jan.h.d@swipnet.se>
7195
b81d40f0
JB
7196 * nsterm.m (x_free_frame_resources):
7197 Release f->output_data.ns->miniimage.
204ee57f
JD
7198 (ns_index_color): Fix indentation. Do not retain
7199 color_table->colors[i].
7200
7201 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
7202 before returning.
7203
7204 * nsfns.m (x_set_background_color): Assign return value from
7205 ns_index_color to face-background instead of NSColor*.
7206 (ns_implicitly_set_icon_type): Fix indentation.
7207 Change assignment in for loop to comparison.
7208
7209 * emacs.c (ns_pool): New variable.
7210 (main): Assign ns_pool.
7211 (Fkill_emacs): Call ns_release_autorelease_pool.
7212
7213 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
7214 autorelease fdesc, release fdAttrs and tdict.
7215 (ns_get_covering_families): Release charset.
7216 (ns_findfonts): Release NSFontDescriptor created with new.
7217 (ns_uni_to_glyphs): Fix indentation.
7218 (setString): Release attrStr before assigning new value.
7219
c803b2b7
JD
72202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
7221
678f4426
JD
7222 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
7223 and NS_IMPL_COCOA.
7224 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
7225 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
7226
cd394be1 72272011-12-18 David Reitter <reitter@cmu.edu>
678f4426 7228
5fecd5fc
JD
7229 * nsterm.m (ns_term_init): Subscribe for notifications
7230 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
7231 to method trackingNotification in EmacsMenu.
7232
7233 * nsmenu.m (trackingMenu): New variable.
3771cb17 7234 (trackingNotification): New method (from Aquamacs).
5fecd5fc 7235 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 7236 from Aquamacs (Bug#7030).
678f4426
JD
7237
72382011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 7239
c803b2b7
JD
7240 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
7241 (symbol_to_nsstring): Fix indentation.
7242 (ns_symbol_to_pb): New function.
cae07000
SM
7243 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
7244 (Fns_rotate_cut_buffers_internal): Remove.
7245 (Fns_store_selection_internal): Rename from
c803b2b7
JD
7246 Fns_store_cut_buffer_internal.
7247 (ns_get_foreign_selection, Fx_own_selection_internal)
7248 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
7249 (Fns_get_selection_internal, Fns_store_selection_internal):
7250 Use ns_symbol_to_pb and check if return value is nil.
7251 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
7252 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
7253 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
7254 renamed to Sns_store_selection_internal.
7255 (ns_handle_selection_request): Move code to Fx_own_selection_internal
7256 and remove this function.
7257 (ns_handle_selection_clear): Remove, never used.
7258 (Fx_own_selection_internal): Move code from ns_handle_selection_request
7259 here.
7260
e1b01a3a
KB
72612011-12-17 Ken Brown <kbrown@cornell.edu>
7262
7263 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
7264 GID is unknown (Bug#10257).
7265
2adb6e85
PE
72662011-12-17 Paul Eggert <eggert@cs.ucla.edu>
7267
7268 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
7269 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
7270 which caused a build failure on GNU/Linux IA-64. This problem was
7271 introduced by my 2011-10-07 patch.
7272
d1d7b339
JL
72732011-12-15 Juri Linkov <juri@jurta.org>
7274
7275 * image.c (imagemagick_error): New function. (Bug#10112)
7276 (imagemagick_load_image): Comment out `MagickSetResolution' call.
7277 Use `imagemagick_error' where ImageMagick functions return
7278 `MagickFalse'.
7279 (Fimagemagick_types): Add `Fnreverse' to return the list in the
7280 proper order.
7281
100d5755
KH
72822011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7283
7284 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
7285 fill background (Bug#8992).
7286
454592a6
MR
72872011-12-13 Martin Rudalics <rudalics@gmx.at>
7288
7289 * window.c (Vwindow_combination_resize)
7290 (Vwindow_combination_limit): Use t instead of non-nil in
7291 doc-strings.
61d4b438
MR
7292 (Vrecenter_redisplay): Add first sentence of doc-string on
7293 separate line.
53524d93 7294 (Frecenter): Fix doc-string typo.
454592a6 7295
3633e3aa
KH
72962011-12-11 Kenichi Handa <handa@m17n.org>
7297
7298 * coding.c (Funencodable_char_position): Pay attention to the
7299 buffer text relocation (Bug#9389).
7300
7b9d523a 73012011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 7302
7b9d523a
JD
7303 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
7304 gtk_init (Bug#10100).
7305
b73189c6
EZ
73062011-12-10 Eli Zaretskii <eliz@gnu.org>
7307
7308 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
7309 IT->string is nil. (Bug#10263)
7310
f7dfe5d6
JD
73112011-12-10 Jan Djärv <jan.h.d@swipnet.se>
7312
83faebb4
JD
7313 * nsterm.h (x_free_frame_resources): Declare.
7314
f7dfe5d6
JD
7315 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
7316 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
7317
7318 * nsterm.h (ns_get_defaults_value): Declare.
7319
7320 * nsterm.m (ns_default): Call ns_get_defaults_value.
7321
7cd4e72c
EZ
73222011-12-09 Eli Zaretskii <eliz@gnu.org>
7323
7324 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
7325 (Bug#10170)
7326
b34d7317
YM
73272011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7328
7329 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
7330 that where the value of an _OBJC_* symbol points to is in the .bss
7331 section (Bug#10240).
7332
76470ad1
KH
73332011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7334
7335 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 7336 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 7337
745fff94
KH
73382011-12-08 Kenichi Handa <handa@m17n.org>
7339
7340 * ftfont.c (get_adstyle_property): Fix previous change
7341 (Bug#10233).
7342
6e44397c
JB
73432011-12-07 Juanma Barranquero <lekktu@gmail.com>
7344
7345 * w32.c (init_environment): If no_site_lisp, remove site-lisp
7346 dirs from the default value of EMACSLOADPATH (bug#10208).
7347
7efa6272
GM
73482011-12-07 Glenn Morris <rgm@gnu.org>
7349
7350 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
7351 installation and source directories as well. (Bug#10208)
7352
f6fc4d87
CY
73532011-12-06 Chong Yidong <cyd@gnu.org>
7354
7355 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
7356
2bf26180
GM
73572011-12-06 Glenn Morris <rgm@gnu.org>
7358
7359 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
7360 as an error, not just -1. (Bug#10217)
7361
3a6ad4f0
CY
73622011-12-05 Chong Yidong <cyd@gnu.org>
7363
7364 * keyboard.c (process_special_events): New function.
7365 (swallow_events, Finput_pending_p): Use it (Bug#10195).
7366
75a3b399
PE
73672011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7368
7369 * coding.c (encode_designation_at_bol): Don't use uninitialized
7370 local variable (Bug#9318).
7371
c3c9e25e
KH
73722011-12-05 Kenichi Handa <handa@m17n.org>
7373
7374 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
7375 return Qnil (Bug#8046, Bug#10193).
7376
5eb05ea3
KH
73772011-12-05 Kenichi Handa <handa@m17n.org>
7378
7379 * coding.c (encode_designation_at_bol): New args charbuf_end and
7380 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7381 (coding_set_source): Return how many bytes coding->source was
7382 relocated.
7383 (coding_set_destination): Return how many bytes
7384 coding->destination was relocated.
7385 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7386 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7387
73882011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7389
7390 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7391 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7392 macro (Bug#9318).
7393
73942011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7395
7396 The following changes are to fix Bug#9318.
7397
a79703f5 7398 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7399 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7400 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7401 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7402
7dbda6df
JB
74032011-12-05 Juanma Barranquero <lekktu@gmail.com>
7404
7405 * lisp.h (process_quit_flag): Fix external declaration.
7406
6d5eb5b0
SM
74072011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7408
7409 Don't macro-inline non-performance-critical code.
7410 * eval.c (process_quit_flag): New function.
7411 * lisp.h (QUIT): Use it.
7412
a0c3fad0
JD
74132011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7414
7415 * nsfns.m (get_geometry_from_preferences): New function.
7416 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7417
6c07aac2
AS
74182011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7419
7420 * emacs.c (Qkill_emacs): Define.
7421 (syms_of_emacs): Initialize it.
7422 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7423 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7424 (quit_throw_to_read_char): Add parameter `from_signal'.
7425 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7426 * lisp.h (QUIT): Call Fkill_emacs if requested.
7427
c052ead4
JD
74282011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7429
7430 * widget.c (update_wm_hints): Return if wmshell is null.
7431 (widget_update_wm_size_hints): New function.
7432
7433 * widget.h (widget_update_wm_size_hints): Declare.
7434
7435 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7436 widget_update_wm_size_hints (Bug#10104).
7437
9e49252b
EZ
74382011-12-03 Eli Zaretskii <eliz@gnu.org>
7439
7440 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7441 before a newline, prepare the bidi iterator for consuming the
7442 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7443 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7444
02b16839
JL
74452011-12-02 Juri Linkov <juri@jurta.org>
7446
7447 * search.c (Fword_search_regexp): New Lisp function created from
7448 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7449 (Fword_search_backward, Fword_search_forward)
7450 (Fword_search_backward_lax, Fword_search_forward_lax):
7451 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7452 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7453
0068070e
SM
74542011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7455
7456 * fileio.c (Finsert_file_contents): Move after-change-function call
7457 to before the "handled:" label, since all "goto handled" appear in
7458 cases where the *-change-functions have already been properly called
7459 (bug#10117).
7460
3360a3fc
AS
74612011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7462
7463 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7464 waiting for input. (Bug#10169)
7465
73d6c093
EZ
74662011-11-30 Eli Zaretskii <eliz@gnu.org>
7467
7468 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7469 verifies glyph row's hash code--we have just reallocated the
7470 glyphs, so their contents can be complete garbage. (Bug#10164)
7471
febe6bea
JB
74722011-11-30 Juanma Barranquero <lekktu@gmail.com>
7473
7474 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7475
801a4313
EZ
74762011-11-30 Eli Zaretskii <eliz@gnu.org>
7477
7478 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7479 attributes are tested _before_ calling verify_row_hash, to protect
7480 against GCC re-ordering of the tests. (Bug#10164)
7481
2b56b87e
JD
74822011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7483
7484 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7485
7486 * xterm.c (handle_one_xevent): Only set async_visible and friends
7487 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7488 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7489 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7490
dbf31225
PE
74912011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7492
7493 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7494 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7495 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7496 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7497 All uses changed to use GCPRO1 etc.
7498 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7499 Revert to old implementation (i.e., before 2011-03-11).
7500
1305621b
YM
75012011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7502
7503 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7504 of scroll runs so as to avoid assigning disabled bogus rows and
7505 unnecessary graphics copy operations.
7506
8c9afb46
EZ
75072011-11-27 Eli Zaretskii <eliz@gnu.org>
7508
7509 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7510 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7511 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7512 (malloc, free, realloc, calloc): Redirect to e_* only when
7513 compiling Emacs.
7514
7515 * lisp.h (GCTYPEBITS): Move before first use.
7516 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7517 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7518 this macro definition.
7519
7520 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7521 _MSC_VER.
7522
54e9e3bf
JD
75232011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7524
6d5eb5b0
SM
7525 * gtkutil.c (xg_create_frame_widgets):
7526 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7527 present with Gtk+ 2.0.
7528
83aca1cb
PE
75292011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7530
7531 * fileio.c (Finsert_file_contents): Undo previous change; see
7532 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7533
5b76caa4
PE
75342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7535
7536 Rename locals to avoid shadowing.
7537 * fileio.c (Finsert_file_contents):
7538 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7539 * process.c (wait_reading_process_output):
7540 Rename inner 'proc' to 'p' to avoid shadowing.
7541 Indent for consistency with usual Emacs style.
7542
8c535114
EZ
75432011-11-25 Eli Zaretskii <eliz@gnu.org>
7544
7545 * xdisp.c (redisplay_window): If cursor row is not fully visible
7546 after recentering, and scroll-conservatively is set to a large
7547 number, scroll window by a few more lines to make the cursor fully
7548 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7549 (start_display): Don't move to the next line if the display should
7550 start at a newline that is part of a display vector or an overlay
7551 string. (Bug#10119)
8c535114 7552
fa4fdb5c
JL
75532011-11-24 Juri Linkov <juri@jurta.org>
7554
7555 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7556 after the `MagickPingImage' call. (Bug#10112)
7557
90ec88df
CY
75582011-11-23 Chong Yidong <cyd@gnu.org>
7559
7560 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7561
56e2e794
MR
75622011-11-23 Martin Rudalics <rudalics@gmx.at>
7563
7564 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7565 making another buffer current. (Bug#10114)
7566
b6e64c41
GM
75672011-11-23 Glenn Morris <rgm@gnu.org>
7568
7569 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
7570
6b21de18
CY
75712011-11-23 Chong Yidong <cyd@gnu.org>
7572
7573 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
7574 using it (Bug#5984).
7575
b12cd789
EZ
75762011-11-22 Eli Zaretskii <eliz@gnu.org>
7577
7578 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
7579 and header-lines, as they don't have one computed for them.
7580 (Bug#10098)
7581
7582 * .gdbinit (prow): Make displayed values more self-explaining.
7583 Add row's hash code.
7584
261b6fd4
LMI
75852011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
7586
7587 * process.c (wait_reading_process_output): Fix asynchrounous
7588 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 7589 (wait_reading_process_output): Add comment and URL.
261b6fd4 7590
e7cfd277
JD
75912011-11-21 Jan Djärv <jan.h.d@swipnet.se>
7592
7593 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
7594
a9b9b7f5
CY
75952011-11-21 Chong Yidong <cyd@gnu.org>
7596
7597 * window.c (Fnext_window, Fprevious_window): Doc fix.
7598
b0d15b4f
SM
75992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7600
7601 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7602
fe7a3057
JB
76032011-11-20 Juanma Barranquero <lekktu@gmail.com>
7604
7605 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7606
d2999b1a
MR
76072011-11-20 Martin Rudalics <rudalics@gmx.at>
7608
7609 * window.c (Fset_window_combination_limit): Rename argument
7610 STATUS to LIMIT.
7611 (Vwindow_combination_limit): Remove "status" from doc-string.
7612
d5ff9cd0
AS
76132011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7614
7615 * m/ibms390.h: Remove.
7616 * m/ibms390x.h: Don't include "ibms390.h".
7617
a5bb9bd3
SM
76182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7619
7620 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7621 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7622
cd1181db
JB
76232011-11-20 Juanma Barranquero <lekktu@gmail.com>
7624
7625 * casetab.c (Fset_case_table):
7626 * charset.c (Fcharset_after): Fix typos.
7627
615a3b8d 76282011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7629
17e845af
PE
7630 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7631 Otherwise, valgrind does not work on some platforms.
7632 Problem reported by Andreas Schwab in
6a0bf43d
PE
7633 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7634 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7635 is set, removing the need for VIRT_ADDRESS_VARIES.
7636 (PURE_P): Use a more-efficient implementation that needs just one
7637 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7638 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7639 to 4 (xorl, subq, cmpq, setbe).
7640 * alloc.c (pure): Always extern now, since that's the
7641 VIRT_ADDR_VARIES behavior.
7642 (PURE_POINTER_P): Use a single comparison, not two, for
7643 consistency with the new puresize.h.
7644 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7645 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7646 Remove VIRT_ADDR_VARIES no longer needed.
7647
f8fe6f96
EZ
76482011-11-19 Eli Zaretskii <eliz@gnu.org>
7649
7650 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7651 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7652 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7653 behave as if the cursor position were at the window margin.
7654
7655 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7656 and the cursor position is out of bounds, behave as if the cursor
7657 position were at the window margin. (Bug#10075)
7658
df05a53c
CY
76592011-11-18 Chong Yidong <cyd@gnu.org>
7660
7661 * window.c (Fwindow_combination_limit): Make first argument
7662 non-optional, since it is meaningless for live windows like the
7663 selected window.
61ccba97 7664
2071918e
DA
76652011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7666
7667 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7668
b50a28de
SM
76692011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7670
7671 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7672 (graft_intervals_into_buffer): Simplify.
7673
015137db
EZ
76742011-11-18 Eli Zaretskii <eliz@gnu.org>
7675
7676 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7677 hash values of the two rows.
7678 (copy_row_except_pointers): Preserve the used[] arrays and the
7679 hash values of the two rows. (Bug#10035)
68c95424 7680 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7681
7682 * xdisp.c (row_hash): New function, body extracted from
7683 compute_line_metrics.
7684 (compute_line_metrics): Call row_hash, instead of computing the
7685 hash code inline.
7686
7687 * dispnew.c (verify_row_hash): Call row_hash for computing the
7688 hash code of a row, instead of duplicating code from xdisp.c.
7689
7690 * dispextern.h (row_hash): Add prototype.
7691
a2addb04
TH
76922011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7693
7694 * frame.c (delete_frame): Don't delete the terminal when the last
7695 X frame is closed if emacs is built with GTK toolkit.
7696
df85d315
JB
76972011-11-17 Juanma Barranquero <lekktu@gmail.com>
7698
7699 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7700
a0c2d0ae
MR
77012011-11-17 Martin Rudalics <rudalics@gmx.at>
7702
7703 * window.c (Vwindow_splits): Rename to
7704 Vwindow_combination_resize. Suggested by Juri Linkov.
7705 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7706 of Vwindow_splits.
7707
58179cce
JB
77082011-11-16 Juanma Barranquero <lekktu@gmail.com>
7709
7877f373
JB
7710 * nsfns.m (Fns_font_name):
7711 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7712
b6f67890
MR
77132011-11-16 Martin Rudalics <rudalics@gmx.at>
7714
7715 * window.h (window): Rename slot "nest" to "combination_limit".
7716 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7717 (Fset_window_nest): Rename to Fset_window_combination_limit.
7718 (Vwindow_nest): Rename to Vwindow_combination_limit.
7719 (recombine_windows, make_parent_window, make_window)
7720 (Fsplit_window_internal, saved_window)
7721 (Fset_window_configuration, save_window_save): Rename all
7722 occurrences of window_nest to window_combination_limit.
7723
c7015153
JB
77242011-11-15 Juanma Barranquero <lekktu@gmail.com>
7725
7726 * image.c (imagemagick_load_image): Fix typo.
7727
322ad6ec
EZ
77282011-11-14 Eli Zaretskii <eliz@gnu.org>
7729
7730 * xdisp.c (display_line): Move the call to
7731 highlight_trailing_whitespace before the call to
7732 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7733 faces of all the glyphs to compute ROW's hash value.
7734 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7735
f067b8ec
JB
77362011-11-14 Juanma Barranquero <lekktu@gmail.com>
7737
7738 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7739 just return (bug#10044).
7740
1e5b2111
EZ
77412011-11-12 Eli Zaretskii <eliz@gnu.org>
7742
7ef3cbd5
EZ
7743 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7744 with user-defined heap size. Bump the default size of the temacs
7745 heap to 27MB, to avoid memory warning when running temacs.
7746 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7747
1e5b2111
EZ
7748 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7749 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7750 (verify_row_hash) [XASSERTS]: New function.
7751 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7752 that the hash value of glyph rows is correct.
1e5b2111 7753
89d61221
MR
77542011-11-12 Martin Rudalics <rudalics@gmx.at>
7755
7756 * window.h (window): Remove splits slot.
7757 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7758 (Fdelete_other_windows_internal, make_parent_window)
7759 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7760 (Fset_window_configuration, save_window_save): Don't deal with
7761 split status of windows.
7762 (saved_window): Remove splits slot.
7763 (Vwindow_splits): Rewrite doc-string.
7764
97f18cc8
JD
77652011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7766
7767 * xfns.c (unwind_create_frame):
7768 * nsfns.m (unwind_create_frame):
7769 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7770 Vframe_list (Bug#9999).
7771
22a648b4
DA
77722011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7773
0b381c7e 7774 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7775
659afede
KH
77762011-11-11 Kenichi Handa <handa@m17n.org>
7777
7778 * callproc.c (Fcall_process): Set the member dst_multibyte of
7779 process_coding.
7780
9ac0394b
KH
77812011-11-11 Johan Bockgård <bojohan@gnu.org>
7782
7783 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7784 avoid a crash (bug#9496).
7785
2fbdc249
CY
77862011-11-09 Chong Yidong <cyd@gnu.org>
7787
7788 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7789 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7790
ac6b1f81
PE
77912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7792
7793 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7794
09db192c
PE
77952011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7796
7797 Avoid some portability problems by eschewing 'extern inline' functions.
7798 The trivial performance wins aren't worth the portability hassles; see
7799 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7800 et seq.
7801 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7802 (window_box_width, window_box_left, window_box_left_offset)
7803 (window_box_right, window_box_right_offset): Undo previous change,
7804 by removing the "extern"s.
7805 * intervals.c (adjust_intervals_for_insertion)
7806 (adjust_intervals_for_deletion): Undo previous change,
7807 making these static again.
7808 (offset_intervals, temp_set_point_both, temp_set_point)
7809 (copy_intervals_to_string): No longer inline.
7810 * xdisp.c (window_text_bottom_y, window_box_width)
7811 (window_box_height, window_box_left_offset)
7812 (window_box_right_offset, window_box_left, window_box_right)
7813 (window_box): No longer inline.
7814
105216ed
CY
78152011-11-08 Chong Yidong <cyd@gnu.org>
7816
7817 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7818 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7819 Signal an error if not a live window.
105216ed
CY
7820 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7821 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7822
ae9e237f
JB
78232011-11-07 Juanma Barranquero <lekktu@gmail.com>
7824
7825 * lisp.h (syms_of_abbrev): Remove declaration.
7826 Reported by CHENG Gao <chenggao@royau.me>.
7827
c7aa8333
EZ
78282011-11-07 Eli Zaretskii <eliz@gnu.org>
7829
7830 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7831 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7832 of temacs in GUI mode.
7833
be7f5545
MR
78342011-11-07 Martin Rudalics <rudalics@gmx.at>
7835
7836 * window.h: Declare delete_all_child_windows instead of
7837 delete_all_subwindows.
7838 * window.c (Fwindow_nest, Fset_window_nest)
7839 (Fset_window_new_total, Fset_window_new_normal)
7840 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7841 (delete_all_subwindows): Rename to delete_all_child_windows.
7842 (Fdelete_other_windows_internal, Fset_window_configuration):
7843 Call delete_all_child_windows instead of delete_all_subwindows.
7844 * frame.c (delete_frame): Call delete_all_child_windows instead
7845 of delete_all_subwindows.
7846
ca78dc43
PE
78472011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7848
7849 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7850 This is also needed for porting to any host where GC_MARK_STACK is
7851 not GC_MAKE_GCPROS_NOOPS.
7852 (which_symbols): Use it.
7853
a0241d01
KH
78542011-11-07 Kenichi Handa <handa@m17n.org>
7855
7856 * coding.c (coding_set_destination): Check coding->src_pos only
7857 when coding->src_object is a buffer (bug#9910).
7858
7859 * process.c (send_process): Set the member src_multibyte of coding
7860 to 0 (bug#9911) when sending a unibyte text.
7861
7862 * callproc.c (Fcall_process): Set the member src_multibyte of
7863 process_coding to 0 (bug#9912).
7864
a64bfdfa 78652011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7866
7867 * xmenu.c (cleanup_widget_value_tree): New function.
7868 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7869 calling free_menubar_widget_value_tree directly (Bug#9830).
7870
cb41b32a
PE
78712011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7872
7873 Fix some portability problems with 'inline'.
7874 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7875 (window_box_width, window_box_left, window_box_left_offset)
7876 (window_box_right, window_box_right_offset): Declare extern.
7877 Otherwise, these inline functions do not conform to C99 and
7878 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7879 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7880 * intervals.c (adjust_intervals_for_insertion)
7881 (adjust_intervals_for_deletion): Now extern, because otherwise the
7882 extern inline functions 'offset_intervals' couldn't refer to it.
7883 (static_offset_intervals): Remove.
7884 (offset_intervals): Rewrite using the old contents of
7885 static_offset_intervals. The old version didn't conform to C99
7886 because an extern inline function contained a reference to an
7887 identifier with static linkage.
7888
b7041366
AS
78892011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7890
7891 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7892 GC.
7893
88a37c4d
EZ
78942011-11-06 Eli Zaretskii <eliz@gnu.org>
7895
7896 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7897 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7898 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7899 return Qleft_to_right.
7900
49745b39
CY
79012011-11-06 Chong Yidong <cyd@gnu.org>
7902
7903 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7904 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7905 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7906 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7907 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7908 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7909 (Fwindow_vscroll): Doc fix.
7910 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7911 argument, since it makes no sense to pass a live window and for
7912 consistency with window-child.
7913
1f05cd82
CS
79142011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7915
7916 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7917 support MSVC.
7918
22610910
JR
79192011-11-05 Jason Rumney <jasonr@gnu.org>
7920
7921 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7922 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7923 fonts (Bug#6029).
7924 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7925 bitwise arithmetic preventing use of unicode-sip and non-truetype
7926 opentype fonts.
7927
a06776b2
EZ
79282011-11-05 Eli Zaretskii <eliz@gnu.org>
7929
3ad924ba
EZ
7930 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7931 "emacs"-only part.
7932
a06776b2
EZ
7933 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7934 initialization code to keep similarity to xfns.c after changes
7935 from 2011-11-05.
7936
c9e7db78
JD
79372011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7938
a97f8f3f
JD
7939 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7940 (unwind_create_frame): New function (Bug#9943).
7941 (Fx_create_frame): Restructure code to be more similar to the one in
7942 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7943 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7944 Move terminal->reference_count++ just before making the frame official
7945 (Bug#9943).
7946
7947 * nsterm.m (x_free_frame_resources): New function.
7948 (x_destroy_window): Move code to x_free_frame_resources.
7949
c9e7db78 7950 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7951 (Fx_create_frame, x_create_tip_frame):
7952 Move terminal->reference_count++ just before making the frame
75f1671a 7953 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7954 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7955
a6fc3b5c
EZ
79562011-11-05 Eli Zaretskii <eliz@gnu.org>
7957
7958 Support MSVC build with newer versions of Visual Studio.
7959 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7960 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7961 nt/gmake.defs.
7962
7963 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7964 which are not supported by MSVC.
7965 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7966 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7967 bitfields.
7968 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7969 types in bitfields.
7970 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7971
7972 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7973
58179cce 79742011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7975
7976 Support MSVC build with newer versions of Visual Studio.
7977 * w32.c: Don't include w32api.h for MSVC.
7978 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7979
7980 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7981 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7982 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7983 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7984 e_* cousins.
7985 (alloca) [_MSC_VER]: Define to _alloca.
7986
7987 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7988
7989 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7990
a58c13ed
EZ
79912011-11-04 Eli Zaretskii <eliz@gnu.org>
7992
7993 * xdisp.c (note_mouse_highlight): If either of
7994 previous/next-single-property-change returns nil, treat that as
7995 the beginning or the end of the buffer. (Bug#9955)
7996
fe0b6370
JD
79972011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7998
a58c13ed 7999 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
8000 label is not null (Bug#9951).
8001 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
8002 may be NULL.
8003
89bd5ee1
EZ
80042011-11-04 Eli Zaretskii <eliz@gnu.org>
8005
8006 * window.c (Fwindow_body_size): Mention in the doc string that the
8007 return value is in frame's canonical units. (Bug#9949)
8008
84c3edb9
EZ
80092011-11-03 Eli Zaretskii <eliz@gnu.org>
8010
4e2fb5c7
EZ
8011 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
8012
84c3edb9 8013 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 8014 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 8015 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 8016
bc17a887
EZ
80172011-11-01 Eli Zaretskii <eliz@gnu.org>
8018
8019 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
8020 Don't stop backward scan on the continuation glyph, even though
8021 its CHARPOS is positive.
6d5eb5b0
SM
8022 (mouse_face_from_buffer_pos, note_mouse_highlight):
8023 Rename cover_string to disp_string.
bc17a887 8024
4ee88440
MR
80252011-11-01 Martin Rudalics <rudalics@gmx.at>
8026
8027 * window.c (temp_output_buffer_show): Don't use
8028 Vtemp_buffer_show_specifiers.
8029 (Vtemp_buffer_show_specifiers): Remove unused variable.
8030
c2ff3c02
EZ
80312011-10-30 Eli Zaretskii <eliz@gnu.org>
8032
8033 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
8034 past the beginning of the current glyph matrix.
8035
58179cce 80362011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
8037
8038 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
8039 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
8040 HAVE_GTK3 (Bug#9869).
b77a6a7f 8041
3b574623
JD
8042 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8043 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
8044
b77a6a7f
JD
8045 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8046
8047 * xterm.c: Declare x_handle_net_wm_state to return int.
8048 (handle_one_xevent): Check if we are iconified but don't have
8049 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8050 (get_current_wm_state): Return non-zero if not hidden,
8051 check for _NET_WM_STATE_HIDDEN (Bug#9893).
8052 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
8053 (x_handle_net_wm_state): Return what get_current_wm_state returns.
8054 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
8055
196e41e4
PE
80562011-10-29 Paul Eggert <eggert@cs.ucla.edu>
8057
8058 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
8059 so that this new function doesn't get optimized away by a
8060 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
8061
021f2e1a
AS
80622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8063
8064 * frame.h (MOUSE_HL_INFO): Remove excess parens.
8065
8b058d44
EZ
80662011-10-29 Eli Zaretskii <eliz@gnu.org>
8067
8068 Fix the `xbytecode' command.
8069 * .gdbinit (xprintbytestr): New command.
b50a28de 8070 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
8071 (xbytecode): Print the byte-code string as well.
8072
4452fb80
EZ
80732011-10-29 Kim Storm <storm@cua.dk>
8074
8b058d44
EZ
8075 * alloc.c (which_symbols): New function.
8076
21b72067
AS
80772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8078
8079 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
8080 line. (Bug#9903)
8081
83ed7b5c
GM
80822011-10-29 Glenn Morris <rgm@gnu.org>
8083
8084 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
8085 Not clear what it was for, and it causes various bugs. (Bug#9839)
8086
5a7a728b
EZ
80872011-10-28 Eli Zaretskii <eliz@gnu.org>
8088
8089 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
8090 possible random value that matches one of those tested as
8091 condition to clear the mouse face.
8092
d3d0842f
CY
80932011-10-28 Chong Yidong <cyd@gnu.org>
8094
8095 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
8096
31b39d13
DN
80972011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
8098
8099 * window.c (make_window): Initialize phys_cursor_on_p.
8100
9aba6043
SM
81012011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
8102
8103 * lisp.h (struct Lisp_Symbol): Update comments.
8104
c20992f4
JB
81052011-10-28 Juanma Barranquero <lekktu@gmail.com>
8106
8107 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
8108
db4f02f2
EZ
81092011-10-28 Eli Zaretskii <eliz@gnu.org>
8110
8111 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
8112 <oslsachem@gmail.com> for helping to debug this.
8113
8114 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
8115 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
8116 (g_b_init_get_glyph_outline_w): New static variables.
8117 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
8118 (GetGlyphOutlineW_Proc): New typedefs.
8119 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
8120 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
8121 New functions.
8122 (w32font_open_internal, compute_metrics):
8123 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
8124 instead of calling the "wide" APIs directly.
8125
8126 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
8127
8128 * w32.h (syms_of_w32font): Add prototype.
8129
87e68db4
JB
81302011-10-27 Juanma Barranquero <lekktu@gmail.com>
8131
8132 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
8133 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
8134 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
8135 (Fmove_to_window_line): Doc fix.
8136
435c1d67
CY
81372011-10-27 Chong Yidong <cyd@gnu.org>
8138
8139 * process.c (make_process): Set gnutls_state to NULL.
8140
8141 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
8142 non-NULL, regardless of GNUTLS_INITSTAGE.
8143 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
8144 an error. Set process slots as soon as we allocate them.
8145
8146 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
8147
9c6c6f49
CY
81482011-10-27 Chong Yidong <cyd@gnu.org>
8149
9aba6043
SM
8150 * gnutls.c (emacs_gnutls_deinit): New function.
8151 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
8152 (Fgnutls_deinit, Fgnutls_boot): Use it.
8153
8154 * process.c (make_process): Initialize GnuTLS credentials to NULL.
8155 (deactivate_process): Call emacs_gnutls_deinit.
8156
657d08d3
JB
81572011-10-27 Juanma Barranquero <lekktu@gmail.com>
8158
8159 * image.c (x_create_x_image_and_pixmap):
8160 * w32.c (sys_rename, w32_delayed_load):
8161 * w32font.c (fill_in_logfont):
8162 * w32reg.c (x_get_string_resource): Silence compiler warnings.
8163
5430d399
JB
81642011-10-26 Juanma Barranquero <lekktu@gmail.com>
8165
8166 * w32fns.c (w32_default_color_map): New function,
8167 extracted from Fw32_default_color_map.
a7ef684b 8168 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 8169
fe0055fa
PE
81702011-10-25 Paul Eggert <eggert@cs.ucla.edu>
8171
8172 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
8173
e6346438
SM
81742011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
8175
8176 * keyboard.c (test_undefined): New function (bug#9751).
8177 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
8178
e112cc37
ET
81792011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
8180
8181 * sysdep.c (init_sys_modes): Fix the check for the controlling
8182 terminal (Bug#6649).
8183
7b5d6677
EZ
81842011-10-20 Eli Zaretskii <eliz@gnu.org>
8185
8186 * dispextern.h (struct bidi_it): New member next_en_type.
8187
8188 * bidi.c (bidi_line_init): Initialize the next_en_type member.
8189 (bidi_resolve_explicit_1): When next_en_pos is valid for the
8190 current character, check also for next_en_type being WEAK_EN.
8191 (bidi_resolve_weak): Don't enter the expensive loop if the current
8192 position is before next_en_pos. Record the bidi type of the first
8193 non-ET, non-BN character we find, in addition to its position.
8194 (bidi_level_of_next_char): Invalidate next_en_type when
8195 next_en_pos is over-stepped.
8196
7da0b018
PE
81972011-10-20 Paul Eggert <eggert@cs.ucla.edu>
8198
8199 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
8200 * editfns.c: Rewrite current-time-zone so that it invokes
8201 the equivalent of (format-time-string "%Z") to get the time zone name.
8202 This fixes a bug when the time zone name contains characters that
8203 need converting from the system time locale to Emacs internal format.
8204 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
8205 that patch fixed format-time-string to do the conversion, but
8206 I forgot to fix current-time-zone.
8207 (format_time_string): New function, containing most of
8208 what Fformat_time_string used to contain.
8209 (Fformat_time_string): Rewrite in terms of format_time_string.
8210 This doesn't change this function's behavior.
8211 (current-time-zone): Rewrite to use format_time_string.
8212 This fixes the bug reported by Michael Schierl in
8213 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
8214 Jason Rumney's 2007-06-07 change worked around this bug, but
8215 didn't fix it.
8216 * systime.h (tzname, timezone): Remove no-longer-used declarations.
8217
8547b010
EZ
82182011-10-19 Eli Zaretskii <eliz@gnu.org>
8219
8220 * xdisp.c (start_display): If the character at POS is displayed
8221 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
8222 (try_window_reusing_current_matrix): If a line ends in a display
8223 vector or the next line starts in a display vector, continue
8224 redrawing the window even though the character position of
8225 start_row was reached.
8547b010
EZ
8226 (Bug#9771, part 2)
8227
4e948d15
CY
82282011-10-18 Chong Yidong <cyd@gnu.org>
8229
8230 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
8231 with nobreak-char-display too.
8232
4787455f
EZ
82332011-10-18 Eli Zaretskii <eliz@gnu.org>
8234
8235 Fix part 3 of bug#9771.
8236 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
8237 (bidi_resolve_neutral): Don't enter the expensive loop looking for
8238 non-neutral characters if the current character is a paragraph
8239 separator (a.k.a. Newline). This avoids running the same
8240 expensive loop twice, once when we consume the preceding newline
8241 and the other time when the line actually needs to be displayed.
8242 Avoid the loop when we see neutrals on the base embedding level
8243 following a character whose directionality is the same as the
8244 paragraph's. This avoids running the expensive loop when a line
8245 ends in a long sequence of neutrals, like control characters.
8246 Add assertion against STRONG_AL type. Slightly rearrange code
8247 that determines the type of a neutral given the first non-neutral
8248 that follows it.
8249 (bidi_level_of_next_char): Set next_en_pos to zero when
8250 invalidating its info.
8251
2c91f553
EZ
82522011-10-17 Eli Zaretskii <eliz@gnu.org>
8253
8254 * xdisp.c (push_display_prop): Determine whether to record string
8255 or buffer position by IT->string, not by IT->method. Allow
8256 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
8257 (move_it_vertically_backward): Don't look for character position
8258 immediately after the newline when in a continuation line.
8259 (Bug#9771, part 1)
2c91f553 8260
c7b08b0d
MR
82612011-10-15 Martin Rudalics <rudalics@gmx.at>
8262
8263 * window.c (coordinates_in_window): Rewrite and delabelize
8264 vertical border check. (Bug#5357) (Bug#9618)
8265
6b02f655
SM
82662011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
8267
8268 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
8269 errors in XSetWindowBorder (bug#9310).
8270
81d40c92
DA
82712011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
8272
8273 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
8274 avoid crash when xmalloc overrun checking is enabled.
8275
d4172c3b
EZ
82762011-10-13 Eli Zaretskii <eliz@gnu.org>
8277
8278 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
8279 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
8280 cursor motion with <left> and <right> arrow keys.
8281
8282 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
8283 some callers set that themselves.
8284
b00eea75
EZ
82852011-10-12 Eli Zaretskii <eliz@gnu.org>
8286
8287 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
8288 display string and the previous row comes from the same string and
8289 is empty. (Bug#9739) (Bug#9738)
8290
8fe012c4
SM
82912011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
8292
8293 * doc.c (get_doc_string): Encode file name (bug#9735).
8294
0074aef2
EZ
82952011-10-12 Eli Zaretskii <eliz@gnu.org>
8296
79beb178
EZ
8297 * bidi.c (bidi_level_of_next_char):
8298 * xdisp.c (get_visually_first_element): Remove old incorrect
8299 comments regarding the Unicode Line Separator character.
8300
0074aef2
EZ
8301 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
8302
6e4b3fbe
DA
83032011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
8304
8305 * alloc.c (Fgc_status): Do not access beyond zombies array
8306 boundary if nzombies > MAX_ZOMBIES.
8307 * alloc.c (dump_zombies): Add missing format specifier.
8308
0324f3af
PE
83092011-10-12 Paul Eggert <eggert@cs.ucla.edu>
8310
b5525cac
PE
8311 * xdisp.c (set_cursor_from_row): Simplify conditionals,
8312 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
8313
0324f3af
PE
8314 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
8315 Some packages use them to denote characters with modifiers.
8316
e9b5f888
AS
83172011-10-11 Andreas Schwab <schwab@linux-m68k.org>
8318
8319 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
8320 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
8321 matching a pp-number. Rename parameter var to var1.
8322
127827c0
SM
83232011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
8324
8325 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
8326
c8fd3bd0
GM
83272011-10-08 Glenn Morris <rgm@gnu.org>
8328
8329 * callint.c (Fcall_interactively): Give a more explicit error for the
8330 'c' case with a non-character input. (Bug#8479)
8331
352ec8ff
EZ
83322011-10-08 Eli Zaretskii <eliz@gnu.org>
8333
03669ccb
EZ
8334 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
8335 lines.
7061c986
EZ
8336 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
8337 lines that are hscrolled on the left.
03669ccb 8338
352ec8ff
EZ
8339 * dispnew.c (buffer_posn_from_coords): Account for a possible
8340 presence of header-line. (Bug#4426)
8341
a66cfb1c
SM
83422011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
8343
6b02f655
SM
8344 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
8345 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 8346
7c5ee88e
PE
83472011-10-07 Paul Eggert <eggert@cs.ucla.edu>
8348
8349 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
8350 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
8351 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
8352 this makes Emacs dump core during garbage collection on rare
8353 occasions. sizeof is obviously inferior to offsetof here, so
8354 stick with offsetof.
8355 (GC_POINTER_ALIGNMENT): New macro.
8356 (mark_memory): Omit 3rd (offset) arg; caller changed.
8357 Don't assume EMACS_INT alignment is the same as pointer alignment.
8358
df1bbe5b
SM
83592011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
8360
8361 * keyboard.c (read_key_sequence_remapped): New var.
8362 (read_key_sequence): Compute remapping in the right buffer.
8363 (command_loop_1): Use read_key_sequence's remapping directly.
8364
51553db6
SM
83652011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
8366
32c1fffd
SM
8367 * dired.c (file_name_completion): Don't expand file name.
8368 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
8369 before checking file name handler.
8370
51553db6
SM
8371 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
8372 they've been requested explicitly (bug#9591).
8373
b6bd1599 83742011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
8375
8376 * keymap.c (Fsingle_key_description): Use make_specified_string
8377 instead of build_string to build string from push_key_description.
8378 (Bug#5193)
8379
f701dc2a
PE
83802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8381
4222c55d
PE
8382 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8383 This fixes a Y2038 bug on 64-bit hosts.
8384 * buffer.c (reset_buffer):
8385 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8386 (Fclear_buffer_auto_save_failure):
8387 Use 0, not -1, to represent an unset failure time, since time_t
8388 might not be signed.
8389
f701dc2a
PE
8390 Remove dependency on glibc malloc internals.
8391 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8392 Move back here from lisp.h, but with their new implementations.
8393 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8394 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8395 * charset.c (charset_table_init): New static var.
8396 (syms_of_charset): Use it instead of xmalloc. This removes a
8397 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8398 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8399 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8400 Move back to alloc.c.
8401 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8402 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8403
9ceebf39
JD
84042011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8405
8406 * nsterm.m (windowDidResize): Call x_set_window_size only when
8407 ns_in_resize is true. Otherwise set pixelwidth/height and
8408 call change_frame_size (Bug#9628).
8409
cb993c58
PE
84102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8411
3930c88b
PE
8412 Port --enable-checking=all to Fedora 14 x86-64.
8413 * charset.c (syms_of_charset): Also account for glibc malloc's
8414 internal overhead when calculating the initial malloc maximum.
8415
cb993c58
PE
8416 Port --enable-checking=all to Fedora 14 x86.
8417 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8418 Move to lisp.h.
8419 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8420 (overrun_check_realloc, overrun_check_free):
8421 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8422 That way, xmalloc returns a properly-aligned pointer even if
8423 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8424 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8425 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8426 into account when calculating the initial malloc maximum.
8427 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8428 Move here from alloc.c, so that charset.c can use it too.
8429 Properly align; the old code wasn't right for common 32-bit hosts
8430 when configured with --enable-checking=all.
8431 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8432 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8433
31bed486
EZ
84342011-09-29 Eli Zaretskii <eliz@gnu.org>
8435
04c70788 8436 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8437 use EDOM.
8438
fbcaa2f3
EZ
84392011-09-28 Eli Zaretskii <eliz@gnu.org>
8440
8441 * xdisp.c (compute_display_string_end): If there's no display
8442 string at CHARPOS, return -1.
8443
8444 * bidi.c (bidi_fetch_char): When compute_display_string_end
8445 returns a negative value, treat the character as a normal
8446 character not covered by a display string. (Bug#9624)
8447
a239d4e9
JB
84482011-09-28 Juanma Barranquero <lekktu@gmail.com>
8449
8450 * lread.c (Fread_from_string): Fix typo in docstring.
8451
88652fd5
EZ
84522011-09-27 Eli Zaretskii <eliz@gnu.org>
8453
8454 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8455 newline, reseat the iterator instead of bidi-iterating there one
8456 character at a time. (Bug#9610)
32c1fffd
SM
8457 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8458 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8459
ed497dd4
AS
84602011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8461
8462 * lread.c (readevalloop): Use correct code for NBSP.
8463 (read1): Likewise. (Bug#9608)
8464
b2bf61aa
MA
84652011-09-25 Michael Albinus <michael.albinus@gmx.de>
8466
8467 * dbusbind.c (Fdbus_register_signal): When service is not
8468 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8469
32bbb17c
GM
84702011-09-25 Glenn Morris <rgm@gnu.org>
8471
8472 * buffer.c (truncate-lines): Doc fix.
8473
94e0933e
CY
84742011-09-24 Chong Yidong <cyd@stupidchicken.com>
8475
8476 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8477 (Fset_window_next_buffers): Doc fix.
8478
cddde921
GM
84792011-09-24 Glenn Morris <rgm@gnu.org>
8480
8481 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8482
1260aef1
PE
84832011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8484
25b4bfa0
PE
8485 Fix minor problems found by static checking.
8486 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8487 * indent.c (Fvertical_motion): Fix == vs = typo.
8488
e3cbd34b
EZ
84892011-09-24 Eli Zaretskii <eliz@gnu.org>
8490
a66cfb1c
SM
8491 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8492 Default value is now t. Doc fix.
6bf7006f 8493
e3cbd34b 8494 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8495 logic when moving up, not only when moving down. Fix the
e3cbd34b 8496 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8497 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8498
8499 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8500 CHARPOS is covered by a display string which includes newlines.
8501 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8502 is covered by a display string with embedded newlines.
8503
a3de0cbd
MA
85042011-09-24 Michael Albinus <michael.albinus@gmx.de>
8505
8506 * dbusbind.c (Fdbus_register_signal): Add match rule to
8507 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8508 (Fdbus_register_method, Vdbus_registered_objects_table):
8509 Fix docstring.
a3de0cbd 8510
b260039d
JM
85112011-09-24 Jim Meyering <meyering@redhat.com>
8512
32c1fffd 8513 do not ignore write error for any output size
b260039d
JM
8514 The previous change was incomplete.
8515 While it makes emacs --batch detect the vast majority of stdout
8516 write failures, errors were still ignored whenever the output size is
8517 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8518 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8519 && echo FAIL: ignored write error
8520 FAIL: ignored write error
8521 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8522 && echo FAIL: ignored write error
8523 FAIL: ignored write error
8524 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8525
8eca8a7c
AS
85262011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8527
8528 * emacs.c (Fkill_emacs): In noninteractive mode exit
8529 non-successfully if a write error occurred on stdout. (Bug#9574)
8530
3341db62
EZ
85312011-09-21 Eli Zaretskii <eliz@gnu.org>
8532
8533 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8534 the xassert test.
8535
8536 * dispextern.h (struct it): Update the comment documenting what
8537 can it->OBJECT be.
8538
8c203dbf
EZ
85392011-09-20 Eli Zaretskii <eliz@gnu.org>
8540
8541 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8542 a display string, extend search for cursor position to end of row.
8543 (find_row_edges): If the row ends in a newline from a display
8544 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8545 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8546 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8547 non-empty line. Fixes confusing cursor motion with arrow keys at
8548 the beginning of a line that starts with whitespace.
8c203dbf 8549
a4824228
LMI
85502011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8551
8552 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8553 (bug#9493).
8554
33ed493b
CY
85552011-09-18 Chong Yidong <cyd@stupidchicken.com>
8556
8557 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8558 boolean (Bug#9154).
8559
56cd55c8
EZ
85602011-09-18 Eli Zaretskii <eliz@gnu.org>
8561
8562 * xdisp.c (display_line): Record maximum and minimum buffer
8563 positions even if no glyphs were produced (e.g., by a zero-width
8564 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8565 buffer positions that will be removed from the glyph row because
8566 they don't fit.
c02dcedf
EZ
8567 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8568 column is beyond frame width: don't subtract 1 "pixel" when
8569 computing width of the stretch.
3e62b7e0
EZ
8570 (reseat_at_next_visible_line_start): Undo the change made on
8571 2011-09-17 that saved paragraph information and restored it after
8572 the call to `reseat'. (Bug#9545)
56cd55c8 8573
5ed99d36 85742011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
8575
8576 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
8577 and turn window cursor on if cleared (Bug#9415).
8578
5ed99d36 85792011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
8580
8581 * search.c (boyer_moore): Take unibyte characters from pattern
8582 literally. (Bug#9458)
8583
9bade7b2
EZ
85842011-09-18 Eli Zaretskii <eliz@gnu.org>
8585
8586 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
8587
e5e9d610
PE
85882011-09-18 Paul Eggert <eggert@cs.ucla.edu>
8589
87e4427a
PE
8590 Fix minor problem found by static checking.
8591 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
8592 initialized, to pacify gcc -Wuninitialized.
8593
e5e9d610
PE
8594 * fileio.c: Report proper errno when syscall falls.
8595 (Finsert_file_contents): Save and restore errno,
8596 so that report_file_error outputs the correct diagnostic.
8597 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8598
a1674f0b
EZ
85992011-09-18 Eli Zaretskii <eliz@gnu.org>
8600
8601 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8602
fbfb6dd4
EZ
86032011-09-17 Eli Zaretskii <eliz@gnu.org>
8604
8605 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8606 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8607
bb187662
EZ
86082011-09-17 Eli Zaretskii <eliz@gnu.org>
8609
1137e8b8 8610 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8611 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8612
8613 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8614 (bidi_find_paragraph_start): Search back for paragraph beginning
8615 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8616 (bidi_move_to_visually_next): Only trigger paragraph-related
8617 computations when the last character is a newline or at EOB, not
8618 just any NEUTRAL_B. (Bug#9470)
8619
bb187662
EZ
8620 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8621 truncated lines if point is covered by a display string. (Bug#9524)
8622
2e621251
PE
86232011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8624
8625 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8626 (cons_to_x_long): New function.
8627 (lisp_data_to_selection_data): Use it. Correct the test for
8628 short-versus-long data; it was negated. Break out of vector
8629 loop, for efficiency, when a long datum is discovered.
8630
91a15bc6
SM
86312011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8632
8633 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8634
b41c3a35
EZ
86352011-09-16 Eli Zaretskii <eliz@gnu.org>
8636
8637 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8638 GCC PR/17406) by declaring this function with external scope.
8639
7812ba2d
PE
86402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8641
8642 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8643 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8644
cf7edc2a
AS
86452011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8646
8647 * editfns.c (Fformat): Correctly handle text properties on "%%".
8648
bd01620e
EZ
86492011-09-15 Eli Zaretskii <eliz@gnu.org>
8650
8651 * xterm.c (x_draw_composite_glyph_string_foreground):
8652 * w32term.c (x_draw_composite_glyph_string_foreground):
8653 * term.c (encode_terminal_code):
8654 * composite.c (composition_update_it, get_composition_id):
8655 * xdisp.c (get_next_display_element)
8656 (fill_composite_glyph_string): Add comments about special meaning
8657 of TAB characters in a composition.
8658
a02719a3
PE
86592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8660
8661 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8662 This occurs when processing a multibyte format.
8663 Problem reported by Wolfgang Jenker.
a02719a3 8664
72589a3c
JB
86652011-09-15 Johan Bockgård <bojohan@gnu.org>
8666
8667 * xdisp.c (try_cursor_movement): Only check for exact match if
8668 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8669
1c14176c
PE
86702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8671
8672 Remove unused external symbols.
8673 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8674 * xdisp.c (calc_pixel_width_or_height): Now static.
8675 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8676 * indent.c (check_display_width):
8677 * w32term.c: Fix comment to match code.
8678 * xterm.c, xterm.h (x_catching_errors): Remove.
8679
d2eea5b5
PE
86802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8681
8682 * xselect.c: Use signed conversions more consistently (Bug#9498).
8683 (selection_data_to_lisp_data): Assume incoming selection data are
8684 signed integers, not unsigned. This is to be consistent with
8685 outgoing selection data, which was modified to use signed integers
8686 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8687 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8688 expects long, not unsigned long.
8689
46888499
EZ
86902011-09-14 Eli Zaretskii <eliz@gnu.org>
8691
8692 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8693 computation of loop end. Reported by Johan Bockgård
8694 <bojohan@gnu.org>.
8695
ef8ef9fb
CY
86962011-09-13 Chong Yidong <cyd@stupidchicken.com>
8697
8698 * frame.c (Fother_visible_frames_p): Function deleted.
8699
fa819fed
EZ
87002011-09-12 Eli Zaretskii <eliz@gnu.org>
8701
8702 * indent.c (compute_motion): Process display vector front to back
8703 rather than the other way around. (Bug#2496)
8704
2ba8e008
SM
87052011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8706
8707 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8708
20f53c69
CY
87092011-09-11 Chong Yidong <cyd@stupidchicken.com>
8710
8711 * minibuf.c (Fread_from_minibuffer): Doc fix.
8712
d562d7a4
EZ
87132011-09-11 Eli Zaretskii <eliz@gnu.org>
8714
8715 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8716 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8717
1c4d7f3d
LMI
87182011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8719
8720 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8721 value for non-existent files.
8722
b885bf36
EZ
87232011-09-11 Eli Zaretskii <eliz@gnu.org>
8724
8725 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8726 set its "size" to -1. This will set the modtime_size field of
8727 the corresponding buffer to -1, which is what
8728 verify-visited-file-modtime expects for files that do not exist.
8729 (Bug#9139)
8730
6612f0bf
PE
87312011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8732
8733 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8734 here ...
8735 * lisp.h: ... from here. push_key_description is no longer
8736 defined in keyboard.c, so its declaration should not be in
8737 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8738 logically belongs with push_key_description.
8739
dfb3f755
PE
87402011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8741
8742 * buffer.h: Include <sys/types.h> instead of <time.h>.
8743 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8744 Problem reported by Herbert J. Skuhra.
8745
3134906c
LMI
87462011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8747
8748 * xml.c (parse_region): Make the parsing work for
8749 non-comment-starting XML files again (bug#9144).
8750
8d903f4e
AS
87512011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8752
8753 * image.c (gif_load): Fix calculation of bottom and right corner.
8754 (Bug#9468)
8755
80ad64f4
EZ
87562011-09-10 Eli Zaretskii <eliz@gnu.org>
8757
8758 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8759 redisplay in small windows.
8760
208a048d
EZ
87612011-09-09 Eli Zaretskii <eliz@gnu.org>
8762
8763 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8764
9b1c252e
MR
87652011-09-08 Martin Rudalics <rudalics@gmx.at>
8766
8767 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8768 Operate on live windows only.
8769
2949f33b
JB
87702011-09-08 Juanma Barranquero <lekktu@gmail.com>
8771
8772 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8773
e08dcafd
EZ
87742011-09-07 Eli Zaretskii <eliz@gnu.org>
8775
8776 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8777 only under bidi iteration.
8778
115b96bd
JD
87792011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8780
8781 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8782
c8199d0f
PE
87832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8784
8785 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8786 Without this fix, the command to link temacs failed due to an
8787 undefined symbol __builtin_isnan. This is because
8788 /usr/include/iso/math_c99.h #defines isnan(x) to
8789 __builtin_isnan(x), but the bundled gcc, which identifies itself
8790 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8791 a __builtin_isnan.
8792 * floatfns.c (isnan): #undef, and then #define to a clone of
8793 what's in data.c.
8794 (Fisnan): Always define, since it's always available now.
8795 (syms_of_floatfns): Always define isnan at the Lisp level.
8796
e39b275c 87972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8798
8799 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8800
b2db44d9 88012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8802
f4af5137 8803 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8804 The previous code assumed that file offsets (off_t values) fit in
8805 EMACS_INT variables, which is not true on typical 32-bit hosts.
8806 The code messed up by falsely reporting buffer overflow in cases
8807 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8808 when "big" contains more than 2**29 bytes, even though this
8809 inserts just one byte and does not overflow the buffer.
8810 (Finsert_file_contents): Store file offsets as off_t
8811 values, not as EMACS_INT values. Check for overflow when
8812 converting between EMACS_INT and off_t. When checking for
8813 buffer overflow or for overlap, take the offsets into account.
8814 Don't use EMACS_INT for small values where int suffices.
8815 When checking for overlap, fix a typo: ZV was used where
8816 ZV_BYTE was intended.
8817 (Fwrite_region): Don't assume off_t fits into 'long'.
8818 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8819
ecfc0a49
MA
88202011-09-05 Michael Albinus <michael.albinus@gmx.de>
8821
8822 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8823
6511acf2 88242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8825
0999621a 8826 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8827
8828 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8829 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8830 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8831 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8832 (modify_event_symbol): Do not assume that the length of
8833 name_alist_or_stem is safe to alloca and fits in int.
8834 (Fexecute_extended_command): Likewise for function name and binding.
8835 (Frecursion_depth): Wrap around reliably on integer overflow.
8836 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8837 since some callers pass EMACS_INT values.
8838 (Fsingle_key_description): Don't crash if symbol name contains more
8839 than MAX_ALLOCA bytes.
8840 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8841 (get_minibuffer): Arg is now EMACS_INT, not int.
8842 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8843 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8844 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8845
2be7d702
PE
8846 * dbusbind.c (signature_cat): New function.
8847 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8848 Do not overrun buffer; instead, report string overflow.
8849
9d1df220
PE
8850 * dispnew.c (add_window_display_history): Don't overrun buffer.
8851 Truncate instead; this is OK since it's just a log.
8852
33ef5c64
PE
8853 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8854 even if the time zone offset is outlandishly large.
8855 Don't mishandle offset == INT_MIN.
8856
66c6fdd5
PE
8857 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8858 when creating daemon; the previous buffer-overflow check was incorrect.
8859
d749b01b
PE
8860 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8861 which has the guts of the old verror function.
8862
b5cd1905
PE
8863 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8864 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8865
6e1a67fb
PE
8866 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8867 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8868 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8869 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8870 length of string rather than counting it via multiple sprintfs;
8871 that's simpler and more reliable.
c21721cc
PE
8872 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8873 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8874 sprintf, in case result does not fit in int.
8875
c57b67fc
PE
8876 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8877 (fontset_from_font): Print it.
8878
8a401434
PE
8879 * frame.c (tty_frame_count): Now printmax_t, not int.
8880 (make_terminal_frame, set_term_frame_name): Print it.
8881 (x_report_frame_params): In X, window IDs are unsigned long,
8882 not signed long, so print them as unsigned.
8883 (validate_x_resource_name): Check for implausibly long names,
8884 and don't assume name length fits in 'int'.
8885 (x_get_resource_string): Don't blindly alloca invocation name;
8886 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8887 not fit in int.
8888
6e1a67fb
PE
8889 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8890 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8891 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8892
0df02bf3
PE
8893 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8894 Use esprintf, not sprintf, in case result does not fit in int.
8895
48e30793
PE
8896 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8897 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8898 it as a large positive number.
8899 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8900 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8901
a66ff6d8
PE
8902 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8903 in case result does not fit in int.
8904
aca216ff
PE
8905 * print.c (float_to_string): Detect width overflow more reliably.
8906 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8907 buffer overrun. Don't assume list length fits in 'int'. Treat
8908 print length of 0 as 0, not as infinity; to be consistent with other
8909 uses of print length in this function. Don't overflow print length
8910 index. Don't assume hash table size fits in 'long', or that
8911 vectorlike size fits in 'unsigned long'.
8912
31c286f7
PE
8913 * process.c (make_process): Use printmax_t, not int, to format
8914 process-name gensyms.
8915
55e5faa1
PE
8916 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8917
80f2e268
PE
8918 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8919 to avoid potential buffer overrun.
8920
670741ab
PE
8921 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8922 if X resource line is longer than 512 bytes.
8923
b7163a50
PE
8924 * xfns.c (x_window): Make sprintf buffer a bit bigger
8925 to avoid potential buffer overrun.
8926
ae58ff1f
PE
8927 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8928
c43c8a6a
PE
8929 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8930
3f8236f4
PE
89312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8932
53e9fe90 8933 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8934 Without these, Emacs silently mishandles large integers sometimes.
8935 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8936 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8937
6511acf2
PE
8938 * xdisp.c (try_window_id): Check Emacs fixnum range before
8939 converting to 'int'.
806add1d 8940
6511acf2 8941 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8942 Check that an Emacs fixnum is in range before assigning it to 'int'.
8943 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8944 values converted from Emacs fixnums.
8945 (Frecenter): Don't wrap around a line count if it is out of 'int'
8946 range; instead, treat it as an extreme value.
8947 (Fset_window_configuration, compare_window_configurations):
8948 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8949
6511acf2
PE
8950 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8951 that can exceed INT_MAX. Check that EMACS_INT value is in range
8952 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8953 (match_limit): Don't assume that a fixnum can fit in 'int'.
8954
6511acf2 8955 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8956 exceed INT_MAX.
8957
6511acf2 8958 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8959 (Fvertical_motion): Don't wrap around LINES values that don't fit
8960 in 'int'. Instead, treat them as extreme values. This is good
8961 enough for windows, which can't have more than INT_MAX lines anyway.
8962
fcb901a7
LMI
89632011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8964
0f2f6b6d
LMI
8965 * Require libxml/parser.h to avoid compilation warning.
8966
fcb901a7
LMI
8967 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8968
8969 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8970 since this reportedly can destroy thread storage.
8971
6e20a0d4
CY
89722011-08-30 Chong Yidong <cyd@stupidchicken.com>
8973
8974 * syntax.c (find_defun_start): Update all cache variables if
8975 exiting early (Bug#9401).
8976
148ae00e
EZ
89772011-08-30 Eli Zaretskii <eliz@gnu.org>
8978
f6cfbd8f
EZ
8979 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8980
148ae00e
EZ
8981 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8982 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8983 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8984
8985 * term.c (tty_append_glyph): New function.
8986 (produce_stretch_glyph): Static function and its prototype deleted.
8987
a66cfb1c
SM
8988 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8989 Add prototypes.
148ae00e 8990
c4a07a4c
PE
89912011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8992
8993 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8994 when checking :margin (Bug#9390).
8995 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8996 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8997 so that the name doesn't mislead. All uses changed.
8998
6bc8cd65
JB
89992011-08-28 Johan Bockgård <bojohan@gnu.org>
9000
9001 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
9002 set_tty_hooks.
9003
dca4927e
EZ
90042011-08-27 Eli Zaretskii <eliz@gnu.org>
9005
9006 * xdisp.c (move_it_to): Don't bail out early when reaching
9007 position beyond to_charpos, if we are scanning backwards.
9008 (move_it_vertically_backward): When DY == 0, make sure we get to
9009 the first character in the line after the newline.
9010
f2cad773
PE
90112011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9012
9013 * ccl.c: Improve and simplify overflow checking (Bug#9196).
9014 (ccl_driver): Do not generate an out-of-range pointer.
9015 (Fccl_execute_on_string): Remove unnecessary check for
9016 integer overflow, noted by Stefan Monnier in
9017 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
9018 Remove a FIXME that didn't need fixing.
9019 Simplify the newly-introduced buffer reallocation code.
9020
0cae2cdb
JB
90212011-08-27 Juanma Barranquero <lekktu@gmail.com>
9022
9023 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
9024
5fc295a4 90252011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 9026
70c60eb2 9027 Integer and memory overflow issues (Bug#9196).
726e0ab1 9028
d31850da
PE
9029 * doc.c (get_doc_string): Rework so that
9030 get_doc_string_buffer_size is the actual buffer size, rather than
9031 being 1 less than the actual buffer size; this makes xpalloc more
9032 convenient.
9033
a69fbedb
PE
9034 * image.c (x_allocate_bitmap_record, cache_image):
9035 * xselect.c (Fx_register_dnd_atom):
9036 Simplify previous changes by using xpalloc.
9037
fe5c5d37
PE
9038 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
9039 since either will do and ptrdiff_t is convenient with xpalloc.
9040
0065d054
PE
9041 * charset.c (charset_table_size)
9042 (struct charset_sort_data.priority): Now ptrdiff_t.
9043 (charset_compare): Don't overflow if priorities differ greatly.
9044 (Fsort_charsets): Don't assume list length fits in int.
9045 Check for size-calculation overflow when allocating sort data.
9046 (syms_of_charset): Allocate an initial charset table that is
9047 just under 64 KiB, to avoid problems with glibc malloc and mmap.
9048
9049 * cmds.c (internal_self_insert): Check for size-calculation overflow.
9050
9051 * composite.h (struct composition.glyph_len): Now int, not unsigned.
9052 The actual value is always <= INT_MAX, and leaving it unsigned made
9053 overflow checking harder.
9054
9055 * dispextern.h (struct glyph_matrix.rows_allocated)
9056 (struct face_cache.size): Now ptrdiff_t, for convenience in use
9057 with xpalloc. The values are still always <= INT_MAX.
9058
9059 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
9060
9061 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
9062 (SAFE_NALLOCA): New macro.
9063
9064 * region-cache.c (struct boundary.pos, find_cache_boundary)
9065 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
9066 (set_cache_region, invalidate_region_cache)
9067 (revalidate_region_cache, know_region_cache, region_cache_forward)
9068 (region_cache_backward, pp_cache):
9069 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
9070 so that ptrdiff_t * can be passed to xpalloc.
9071 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
9072 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
9073 (pp_cache): Don't assume cache_len fits in int.
9074 * region-cache.h: Adjust extern decls to match.
9075
9076 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
9077 EMACS_INT, since either will do, for xpalloc.
9078
9079 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
9080 (xnmalloc, xnrealloc, xpalloc): New functions.
9081
726e0ab1
PE
9082 * bidi.c (bidi_shelve_header_size): New constant.
9083 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
9084 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
9085
51f30bc5 9086 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
9087 * buffer.c (overlays_at, overlays_in, record_overlay_string)
9088 (overlay_strings):
9089 Don't update size of array until after memory allocation succeeds,
9090 because xmalloc/xrealloc may not return.
0065d054
PE
9091 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
9092 now that we have proper integer overflow checking.
9093 (record_overlay_string, overlay_strings): Catch overflows when
9094 calculating size of overlay_str_buf.
726e0ab1 9095
0065d054
PE
9096 * callproc.c (Fcall_process): Check for size overflow when
9097 calculating size of args2.
9098 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
9099 Normally we prefer signed values, but sticking with ptrdiff_t would
9100 require adding more-complicated checks.
726e0ab1
PE
9101
9102 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
9103 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
9104 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 9105 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
9106
9107 * character.c (Fstring): Check for size-calculation overflow.
9108
9109 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
9110 unnecessary integer overflow. Check for size overflow.
9111 (encode_coding_object): Don't update size until xmalloc succeeds.
9112
9113 * composite.c (get_composition_id): Check for overflow in glyph
9114 length calculations.
9115
9116 Integer and memory overflow fixes for display code.
9117 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
9118 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
9119 (scrolling_window): Check for overflow in size calculations.
9120 (line_draw_cost, realloc_glyph_pool, add_row_entry):
9121 Don't assume glyph table len fits in int.
9122 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
9123 (row_table_size): Now ptrdiff_t, not int.
9124 (scrolling_window): Avoid overflow in size calculations.
9125 Don't update size until allocation succeeds.
9126 * fns.c (concat): Check for overflow in size calculations.
9127 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
9128 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9129 (NEXT_ALMOST_PRIME_LIMIT): New constant.
9130
9131 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
9132 (get_doc_string): Check for size calculation overflow.
9133 Don't update size until allocation succeeds.
9134 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
9135 EMACS_INT, where ptrdiff_t will do.
9136 (Fsubstitute_command_keys): Check for string overflow.
9137
9138 * editfns.c (set_time_zone_rule): Don't assume environment length
9139 fits in int.
9140 (message_length): Now ptrdiff_t, not int.
9141 (Fmessage_box): Don't update size until allocation succeeds.
9142 Don't assume message length fits in int.
9143 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
9144
0065d054
PE
9145 * emacs.c (main): Do not reallocate argv, since there is a null at
9146 the end that can be overwritten, and this way there's no need to
9147 worry about size-calculation overflow.
9148 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
9149
9150 * eval.c (init_eval_once, grow_specpdl): Don't update size until
9151 alloc succeeds.
9152 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
9153
9154 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
9155 (x_set_scroll_bar_width, x_figure_window_size):
9156 Check for integer overflow.
9157 (x_set_alpha): Do not assume XINT fits in int.
9158
9159 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
9160 This is for the members text_lines, text_cols, total_lines, total_cols,
9161 where the system imposes an 'int' limit.
9162
9163 * fringe.c (Fdefine_fringe_bitmap):
9164 Don't update size until alloc works.
9165
9166 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
9167 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
9168
9169 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
9170 Check for size-calculation overflow.
9171 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
9172 do, as we prefer signed integers.
9173 (id_to_widget.max_size, id_to_widget.used)
9174 (xg_store_widget_in_map, xg_remove_widget_from_map)
9175 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
9176 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
9177 Use and return ptrdiff_t, not int.
9178 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
9179 * gtkutil.h: Change prototypes to match the above.
9180
9181 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
9182 are duplicate now that they've been promoted to lisp.h.
9183 (x_allocate_bitmap_record, x_alloc_image_color)
9184 (make_image_cache, cache_image, xpm_load):
9185 Don't update size until alloc is done.
9186 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
9187 (x_detect_edges):
3256efce 9188 Check for size calculation overflow.
726e0ab1
PE
9189 (ct_colors_allocated_max): New constant.
9190 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
9191 overflow.
3256efce 9192
726e0ab1
PE
9193 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
9194 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
9195 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
9196 Use ptrdiff_t, not int, to count maps.
9197 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
9198 calculations. Don't update size until allocation succeeds.
9199 Redo calculations to avoid overflow.
726e0ab1
PE
9200 * keyboard.h: Change prototypes to match the above.
9201
9202 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
9203 to count maps.
9204 (current_minor_maps): Check for size calculation overflow.
9205 * keymap.h: Change prototypes to match the above.
9206
9207 * lread.c (read1, init_obarray): Don't update size until alloc done.
9208
9209 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
9210 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
9211
726e0ab1
PE
9212 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
9213 Now ptrdiff_t, not int.
9214 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
9215 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
9216
9217 * process.c (Fnetwork_interface_list): Check for overflow
9218 in size calculation.
9219
9220 * region-cache.c (move_cache_gap): Check for size calculation overflow.
9221
9222 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
9223 overflow. Don't bother calling xmalloc when xrealloc will do.
9224
9225 * search.c (Freplace_match): Check for size calculation overflow.
9226 (Fset_match_data): Don't assume list lengths fit in 'int'.
9227
9228 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
9229 for command line length. Do not attempt to address one before the
9230 beginning of an array, as that's not portable.
9231
9232 * term.c (max_frame_lines): Remove; unused.
9233 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
9234 not int.
9235 (encode_terminal_code, calculate_costs): Check for size
9236 calculation overflow.
9237 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
9238 table lengths and related sizes. Don't update size until alloc
9239 done. Redo calculations to avoid overflow.
9240 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
9241
9242 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
9243 subtracting pointers.
9244 (gobble_line): Check for overflow more carefully. Don't update size
9245 until alloc done.
9246
9247 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
9248 Don't update size until alloc done.
9249 Redo size calculations to avoid overflow.
9250 Check for size calculation overflow.
0065d054 9251 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
9252
9253 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
9254 Use ptrdiff_t, not int, for sizes.
9255 (store_mode_line_noprop_char): Don't update size until alloc done.
9256
0065d054
PE
9257 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
9258 Use ptrdiff_t, not int, for sizes.
9259 (Finternal_make_lisp_face, cache_face):
9260 Check for size calculation overflow.
9261 (cache_face): Treat size calculation overflows as if they were
9262 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
9263
9264 * xfns.c (x_encode_text, x_set_name_internal)
9265 (Fx_change_window_property): Use ptrdiff_t, not int, to count
9266 sizes, since they can exceed INT_MAX in size. Check for size
9267 calculation overflow.
9268
0065d054
PE
9269 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
9270 (xg_select): Check for size calculation overflow.
726e0ab1
PE
9271 Don't update size until alloc done.
9272
0065d054 9273 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 9274 as sprintf is limited to int lengths.
1d526e2f 9275
252c5ee1
PE
9276 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
9277 (X_LONG_MIN): New macros.
864d7ce7
PE
9278 Use them to make the following changes clearer.
9279 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
9280 This change doesn't affect the value now, but it may help remind
9281 future maintainers not to raise the value too much later.
9282 (SELECTION_QUANTUM): Remove, replacing with ...
9283 (selection_quantum): ... new function, which avoids overflow.
9284 All uses changed.
9285 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
9286 assumption that selection length fits in 'int'.
9287 (x_reply_selection_request, x_handle_selection_request)
9288 (x_get_window_property, receive_incremental_selection)
9289 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
9290 (lisp_data_to_selection_data, clean_local_selection_data):
9291 Use ptrdiff_t, not int, to record length of selection.
9292 (x_reply_selection_request, x_get_window_property)
9293 (receive_incremental_selection, x_property_data_to_lisp):
9294 Redo calculations to avoid overflow.
9295 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 9296 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
9297 something.
9298 (x_get_window_property, receive_incremental_selection)
9299 (lisp_data_to_selection_data, x_property_data_to_lisp):
9300 Check for size-calculation overflow.
9301 (x_get_window_property, receive_incremental_selection)
9302 (lisp_data_to_selection_data, Fx_register_dnd_atom):
9303 Don't store size until memory allocation succeeds.
9304 (x_get_window_property): Plug memory leak on memory exhaustion.
9305 Don't double-block input; malloc is safe here. Don't assume 2**34
9306 - 4 fits in unsigned long. Add an xassert to check
9307 XGetWindowProperty overflow. Be more careful about overflow
9308 calculations, and distinguish size from memory overflow better.
9309 (receive_incremental_selection): When tracing, don't assume
9310 unsigned int is less than INT_MAX.
9311 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
9312 harmful) conversions of unsigned short to int.
9313 (lisp_data_to_selection_data): Don't assume that integers
9314 in the range -65535 through -1 fit in an X unsigned short.
9315 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
9316 result parameters unless successful. Rely on cons_to_unsigned
9317 to report problems with elements; the old code wasn't right anyway.
9318 (x_check_property_data): Check for int overflow; we cannot use
9319 a wider type due to X limits.
9320 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
9321
726e0ab1 9322 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 9323
0065d054
PE
9324 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
9325 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
9326 (x_color_cells): Don't store size until memory allocation succeeds.
9327 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 9328 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
9329 (x_term_init): Don't assume length fits in int (sprintf is limited
9330 to int size).
bc18e09d 9331
ebfa62c0
PE
9332 Use ptrdiff_t for composition IDs.
9333 * character.c (lisp_string_width):
9334 * composite.c (composition_table_size, n_compositions)
9335 (get_composition_id, composition_gstring_from_id):
9336 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
9337 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
9338 * window.c (Frecenter):
9339 Use ptrdiff_t, not int, for composition IDs.
9340 * composite.c (get_composition_id): Check for integer overflow.
9341 * composite.h: Adjust prototypes to match the above changes.
9342
d3411f89
PE
9343 Use ptrdiff_t for hash table indexes.
9344 * category.c (hash_get_category_set):
9345 * ccl.c (ccl_driver):
9346 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
9347 * coding.c (coding_system_charset_list, detect_coding_system):
9348 * coding.h (struct coding_system.id):
9349 * composite.c (get_composition_id, gstring_lookup_cache):
9350 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
9351 * image.c (xpm_get_color_table_h):
9352 * lisp.h (hash_lookup, hash_put):
9353 * minibuf.c (Ftest_completion):
9354 Use ptrdiff_t for hash table indexes, not int (which is too
9355 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
9356 32-bit --with-wide-int hosts).
9357
e097a6fa
PE
9358 * charset.c (Fdefine_charset_internal): Check for integer overflow.
9359 Add a FIXME comment about memory leaks.
9360 (syms_of_charset): Don't assume xmalloc returns.
9361
5637687f
PE
9362 Don't assume that stated character widths fit in int.
9363 * character.c (Fchar_width, c_string_width, lisp_string_width):
9364 * character.h (CHAR_WIDTH):
9365 * indent.c (MULTIBYTE_BYTES_WIDTH):
9366 Use sanitize_char_width to avoid undefined and/or bad behavior
9367 with outlandish widths.
a66cfb1c 9368 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
9369 now that we have two such functions. All uses changed.
9370 (sanitize_char_width): New inline function.
9371
a2271ba2
PE
9372 Don't assume that tab-width fits in int.
9373 * character.h (sanitize_width): New inline function.
9374 (SANE_TAB_WIDTH): New macro.
9375 (ASCII_CHAR_WIDTH): Use it.
9376 * indent.c (sane_tab_width): Remove. All uses replaced by
9377 SANE_TAB_WIDTH (current_buffer).
9378 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9379
18c52557
PE
9380 * fileio.c: Integer overflow issues with file modes.
9381 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9382
caeeedc1
PE
9383 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9384 Remove unreachable code.
9385 (read_hex, load_charset_map_from_file): Check for integer overflow.
9386
6df6ae42 9387 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9388 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9389 (x_send_scroll_bar_event): Likewise. Check that the size does not
9390 exceed limits imposed by XClientMessageEvent, as well as the usual
9391 ptrdiff_t and size_t limits.
9392
b13995db
PE
9393 * keyboard.c: Overflow, signedness and related fixes.
9394 (make_lispy_movement): Use same integer type in forward decl
9395 that is used in the definition.
9396 (read_key_sequence, keyremap_step):
9397 Change bufsize argument back to int, undoing my 2011-03-30 change.
9398 We prefer signed types, and int is wide enough here.
9399 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9400 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9401 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9402 length, not size_t. Use ptrdiff_t for index, not int.
9403 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9404 possibility of integer overflow.
9405
13464394
PE
9406 Overflow, signedness and related fixes for images.
9407
9408 * dispextern.h (struct it.stack[0].u.image.image_id)
9409 (struct_it.image_id, struct image.id, struct image_cache.size)
9410 (struct image_cache.used, struct image_cache.ref_count):
9411 * gtkutil.c (update_frame_tool_bar):
9412 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9413 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9414 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9415 * nsmenu.m (update_frame_tool_bar):
9416 * xdisp.c (calc_pixel_width_or_height):
9417 * xfns.c (image_cache_refcount):
9418 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9419 on typical 64-bit hosts.
9420
9421 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9422 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9423 Omit unnecessary casts to int.
9424 (parse_image_spec): Check that integers fall into 'int' range
9425 when the callers expect that.
9426 (image_ascent): Redo ascent calculation to avoid int overflow.
9427 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9428 (lookup_image): Remove unnecessary tests.
9429 (xbm_image_p): Locals are now of int, not EMACS_INT,
9430 since parse_image_check makes sure they fit into int.
9431 (png_load, gif_load, svg_load_image):
9432 Prefer int to unsigned where either will do.
9433 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9434 old tiff_error_handler and tiff_warning_handler.
9435 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9436 stack buffer overflows. It uses only the features of vsnprintf
9437 that are common to both POSIX and native Microsoft.
9438 (tiff_error_handler, tiff_warning_handler): Use it.
9439 (tiff_load, gif_load, imagemagick_load_image):
9440 Don't assume :index value fits in 'int'.
9441 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9442 (imagemagick_load_image): Check that crop parameters fit into
9443 the integer types that MagickCropImage accepts. Don't assume
9444 Vimagemagick_render_type has a nonnegative value. Don't assume
9445 size_t fits in 'long'.
9446 (gs_load): Use printmax_t to print the widest integers possible.
9447 Check for integer overflow when computing image height and width.
9448
c11821d4
EZ
94492011-08-26 Eli Zaretskii <eliz@gnu.org>
9450
9451 * xdisp.c (redisplay_window): Don't force window start if point
9452 will be invisible in the resulting window. (Bug#9324)
9453
0c95fcf7
EZ
94542011-08-25 Eli Zaretskii <eliz@gnu.org>
9455
9456 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9457 the display spec is of the form `(space ...)'.
9458 (handle_display_spec): Return the value returned by
9459 handle_single_display_spec, not just 1 or zero.
9460 (handle_single_display_spec): If the display spec is of the form
9461 `(space ...)', and specifies display in the text area, return 2
9462 rather than 1.
fee65a97 9463 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9464 accurately, and prefer exact match for point under bidi.
9465 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9466
9467 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9468 into disp_prop; all users changed.
9469
9470 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9471 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9472 for the text covered by the display property.
9473
e4ed06f1
CY
94742011-08-25 Chong Yidong <cyd@stupidchicken.com>
9475
9476 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9477 Change return value to nil.
9478 (Frecord_buffer): Delete unused function.
9479
f67cdd7f
EZ
94802011-08-24 Eli Zaretskii <eliz@gnu.org>
9481
5980d4c6
EZ
9482 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9483 buffers, return left-to-right.
8610fe8b
EZ
9484 (set_cursor_from_row): Consider candidate row a win if its glyph
9485 represents a newline and point is on that newline. Fixes cursor
9486 positioning on the newline at EOL of R2L text within L2R
9487 paragraph, and vice versa.
9488 (try_cursor_movement): Check continued rows, in addition to
9489 continuation rows. Fixes unwarranted scroll when point enters a
9490 continued line of R2L text within an L2R paragraph, or vice versa.
9491 (cursor_row_p): Consider the case of point being equal to
9492 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9493 from the end of a short line to the beginning of a continued line
9494 of R2L text within L2R paragraph.
9495 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9496 composed characters.
5980d4c6 9497
f67cdd7f
EZ
9498 * bidi.c (bidi_check_type): Use xassert.
9499 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9500 members.
9501
bca633fb
EZ
95022011-08-23 Eli Zaretskii <eliz@gnu.org>
9503
9504 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9505 a character.
9506
4a5885a7
CY
95072011-08-23 Chong Yidong <cyd@stupidchicken.com>
9508
9509 * nsfont.m (ns_otf_to_script): Fix typo.
9510
0902a04e
KH
95112011-08-22 Kenichi Handa <handa@m17n.org>
9512
9513 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9514 extra slot even if the purpose is char-code-property-table.
9515
1a2e6670
EZ
95162011-08-23 Eli Zaretskii <eliz@gnu.org>
9517
8ddde651
EZ
9518 * xdisp.c (redisplay_window): When computing centering_position,
9519 account for the height of the header line. (Bug#8874)
9520
425cc014
EZ
9521 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9522 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9523 candidate is selected by the mouse, and that candidate has a
9524 composed character under the mouse.
9525
1a2e6670
EZ
9526 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9527 coordinates reported by pos-visible-in-window-p for a composed
9528 character in column zero.
9529
8b76d6f8
SM
95302011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9531
9532 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9533
dac347dd
EZ
95342011-08-22 Eli Zaretskii <eliz@gnu.org>
9535
9536 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9537 consider it a hit if to_charpos is anywhere in the range of the
9538 composed buffer positions.
9539
e013fb34
CY
95402011-08-22 Chong Yidong <cyd@stupidchicken.com>
9541
9542 * image.c (gif_load): Don't assume that each subimage has the same
9543 dimensions as the base image. Handle disposal method that is
9544 "undefined" by the gif spec (Bug#9335).
9545
bd1ba3e8
CY
95462011-08-20 Chong Yidong <cyd@stupidchicken.com>
9547
9548 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9549 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9550
54a1215b
EZ
95512011-08-19 Eli Zaretskii <eliz@gnu.org>
9552
823564e5
EZ
9553 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9554 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9555 from an Org mode buffer to a Speedbar frame.
9556
54a1215b
EZ
9557 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9558 a composition, take its buffer position from IT->cmp_it.charpos.
9559 Fixes cursor positioning at the beginning of a line that begins
9560 with a composed character.
9561
9778ebcc
EZ
95622011-08-18 Eli Zaretskii <eliz@gnu.org>
9563
0be6ee06
EZ
9564 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9565 character bidirectional type, use STRONG_L instead. Fixes crashes
9566 in a buffer produced by `describe-categories'.
9567
9778ebcc
EZ
9568 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
9569 members before the level stack, so they would be saved and
9570 restored when copying iterator state. Fixes incorrect reordering
9571 around TABs covered by display properties.
9572
156bffbe
AS
95732011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9574
6b02f655 9575 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 9576
72ad093b
CY
95772011-08-17 Chong Yidong <cyd@stupidchicken.com>
9578
9579 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
9580 (internal_condition_case_2, internal_condition_case_n):
9581 Remove unnecessary aborts (Bug#9081).
72ad093b 9582
35774242
EZ
95832011-08-17 Eli Zaretskii <eliz@gnu.org>
9584
9585 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
9586 has no `load' handler, try opening the file locally. (Bug#9311)
9587
db76dd85
KB
95882011-08-16 Ken Brown <kbrown@cornell.edu>
9589
9590 * gmalloc.c: Expand comment.
9591
b215eee5
EZ
95922011-08-16 Eli Zaretskii <eliz@gnu.org>
9593
9594 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
9595 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
9596
a4579d33
KB
95972011-08-16 Ken Brown <kbrown@cornell.edu>
9598
9599 Fix memory allocation problems in Cygwin build (Bug#9273).
9600
9601 * unexcw.c ( __malloc_initialized): Declare external variable.
9602 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9603
8b76d6f8
SM
9604 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9605 New variables.
a4579d33
KB
9606 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9607 dumped emacs.
9608 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9609 in the static heap.
9610 [CYGWIN] (special_realloc): New function.
9611 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9612 requests to realloc storage in the static heap.
9613
3ebec551
PE
96142011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9615
9616 * bidi.c (bidi_initialize): Remove unused local.
9617
9fd8be00
EZ
96182011-08-15 Eli Zaretskii <eliz@gnu.org>
9619
6b02f655
SM
9620 * bidimirror.h:
9621 * biditype.h: Remove file.
9622 * makefile.w32-in ($(BLD)/bidi.$(O)):
9623 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9624
9625 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9626
9627 * chartab.c: Improve commentary for the uniprop_table API.
9628
32413314
EZ
9629 * bidi.c (bidi_paragraph_init): Support zero value of
9630 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9631 (bidi_initialize): Use uniprop_table instead of including
9632 biditype.h and bidimirror.h.
32413314 9633
9fd8be00
EZ
9634 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9635 coordinates of the iterator when restoring from ppos_it.
9636 (Bug#9296)
9637
5cf2b69b
KH
96382011-08-14 Kenichi Handa <handa@m17n.org>
9639
9640 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9641 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9642
daf17d00
EZ
96432011-08-14 Eli Zaretskii <eliz@gnu.org>
9644
9645 * xdisp.c (move_it_in_display_line_to): Don't invoke
9646 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9647 ppos_it. Fixes vertical cursor motion when line beginning is
9648 covered by an image. (Bug#9296)
9649
08e3161a
JD
96502011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9651
9652 * nsterm.h (ns_run_ascript): Declare.
9653 (NSAPP_DATA2_RUNASSCRIPT): Define.
9654
9655 * nsfns.m (as_script, as_result, as_status): New static variables.
9656 (ns_run_ascript): New function.
5e617bc2 9657 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9658 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9659 the event loop. Get status from as_status (Bug#7276).
9660
9661 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9662 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9663 the event loop (Bug#7276).
9664
a3720aa2
AS
96652011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9666
9667 * gnutls.c (QCgnutls_bootprop_priority)
9668 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9669 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9670 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9671 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9672 (QCgnutls_bootprop_verify_hostname_error)
9673 (QCgnutls_bootprop_callbacks_verify): Rename from
9674 Qgnutls_bootprop_..., all uses changed.
9675
9676 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9677 uses changed.
9678
0a0d27fb
PE
96792011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9680
19d5c50c
PE
9681 * xfaces.c (Qframe_set_background_mode): Now static.
9682 * dispextern.h (Qframe_set_background_mode): Remove decl.
9683
0a0d27fb
PE
9684 * process.c (Fnetwork_interface_info): Declare local only if needed.
9685
377538cb
JD
96862011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9687
9688 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9689 (Fnetwork_interface_list): Allocate in increments of bytes instead
9690 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9691 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9692 sockaddr.
9693 (struct ifflag_def): notrailers is smart on OSX.
9694 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9695 Get hardware address with getifaddrs if available.
9696
08fff70c
EZ
96972011-08-12 Eli Zaretskii <eliz@gnu.org>
9698
9699 * xdisp.c (iterate_out_of_display_property): xassert that
9700 IT->position is set to within IT->object's boundaries. Break from
9701 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9702 when IT->position is set up wrongly due to some bug.
9703 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9704 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9705 entry. Force push_it to save on the stack the current
9706 buffer/string position, to be restored by pop_it. Fix flags in
9707 the iterator structure wrt the object coming from a display
9708 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9709 properties. (Bug#9284)
9710
7be1c708 97112011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9712
7be1c708
CY
9713 * fontset.c (fontset_get_font_group): Add proper type checks.
9714 (Bug#9172)
aac0c6e3 9715
7be1c708 97162011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9717
7be1c708
CY
9718 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9719 and LC_VERSION_MIN_MACOSX.
9720 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9721 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9722
97bb72a6
EZ
97232011-08-08 Eli Zaretskii <eliz@gnu.org>
9724
9725 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9726 no-display-properties-and-no-overlays under bidi display.
9727 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9728 properties and overlays.
97bb72a6 9729
d5617611
CY
97302011-08-08 Chong Yidong <cyd@stupidchicken.com>
9731
37e11a63
CY
9732 * editfns.c (Fset_time_zone_rule): Document relationship with the
9733 setenv function.
9734
d5617611
CY
9735 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9736 the font entity extracted from the cache (Bug#8109).
9737
58872834
CY
97382011-08-07 Chong Yidong <cyd@stupidchicken.com>
9739
9740 * composite.c (autocmp_chars): Don't reset point. That is done by
9741 restore_point_unwind (Bug#5984).
9742
75bfc667
JL
97432011-08-07 Juri Linkov <juri@jurta.org>
9744
9745 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9746 to show the arg `TIME' instead of `TIMEVAL'.
9747
d1410150
EZ
97482011-08-06 Eli Zaretskii <eliz@gnu.org>
9749
9750 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9751 display property strides EOL and includes a newline, as in
9752 longlines-mode. (Bug#9254)
75b771e4
EZ
9753 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9754 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9755
9756 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9757 is non-zero, even if the data buffer is NULL. Fixes a crash in
9758 vertical-motion with longlines-mode. (Bug#9254)
9759
35928349
EZ
97602011-08-05 Eli Zaretskii <eliz@gnu.org>
9761
ec7cc85b
EZ
9762 * bidi.c <bidi_cache_total_alloc>: Now static.
9763 (bidi_initialize): Initialize bidi_cache_total_alloc.
9764
8b76d6f8 9765 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9766 cache. (Bug#9221)
9767
9768 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9769 amount allocated this far in `bidi_cache_total_alloc'.
9770 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9771 non-zero, only free the data buffer without restoring the cache
9772 contents. All callers changed.
9773
9774 * dispextern.h (bidi_unshelve_cache): Update prototype.
9775
9776 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9777 (move_it_in_display_line, move_it_to)
9778 (move_it_vertically_backward, move_it_by_lines): Replace the call
9779 to xfree to an equivalent call to bidi_unshelve_cache.
9780 (move_it_in_display_line_to): Fix logic of returning
412b6358 9781 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9782
e2e2423b
EZ
97832011-08-05 Eli Zaretskii <eliz@gnu.org>
9784
9785 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9786 came from a string character with a `cursor' property. (Bug#9229)
9787
ae9e757a
JD
97882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9789
9790 * Makefile.in (LIB_PTHREAD): New variable.
9791 (LIBES): Add LIB_PTHREAD (Bug#9216).
9792
9793 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9794 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9795
213bd7f2
AS
97962011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9797
6b02f655 9798 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9799
99aaf75f
JD
98002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9801
9802 * xterm.c (x_find_topmost_parent): New function.
9803 (x_set_frame_alpha): Find topmost parent window with
9804 x_find_topmost_parent and set the property there also (bug#9181).
9805 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9806
c74e9d86
PE
98072011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9808
9809 * callproc.c (Fcall_process): Avoid vfork clobbering
9810 the local vars buffer, coding_systems, current_dir.
9811
640c8776
SM
98122011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9813
9814 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9815
f26d0e4c
PE
98162011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9817
8a10d76c
PE
9818 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9819 so that it is not optimized away.
9820
f26d0e4c
PE
9821 * xdisp.c (compute_display_string_pos): Remove unused local.
9822
55439c61
EZ
98232011-08-02 Eli Zaretskii <eliz@gnu.org>
9824
9825 Fix slow cursor motion and scrolling in large buffers with
9826 selective display, like Org Mode buffers. (Bug#9218)
9827
9828 * dispextern.h (struct bidi_it): New member disp_prop_p.
9829
9830 * xdisp.c: Remove one-slot cache of display string positions.
9831 (compute_display_string_pos): Accept an additional argument
5e617bc2 9832 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9833 for a display string or property. If found, set DISP_PROP_P
9834 non-zero.
9835
9836 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9837 DISP_PROP_P, and pass it to compute_display_string_pos.
9838 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9839 non-zero. All callers of bidi_fetch_char changed.
9840
fb33fa43
SM
98412011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9842
9843 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9844
b099e063
DM
98452010-12-03 Don March <don@ohspite.net>
9846
9847 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9848 last character M-[char] is translated to ESC [char] (bug#7541).
9849
5cc7f7af
KH
98502011-08-02 Kenichi Handa <handa@m17n.org>
9851
d0fffa3f 9852 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9853
9854 * chartab.c (uniprop_table): Make it non-static.
9855
525d5e6e
EZ
98562011-08-01 Eli Zaretskii <eliz@gnu.org>
9857
9858 * xdisp.c (forward_to_next_line_start): Accept additional argument
9859 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9860 on the newline.
9861 (reseat_at_next_visible_line_start): Use the bidi iterator state
9862 returned by forward_to_next_line_start to restore the state of
9863 it->bidi_it after backing up to previous newline. (Bug#9212)
9864
31011111
AS
98652011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9866
9867 * regex.c (re_comp): Protoize.
9868 (re_exec): Fix return type.
9869 (regexec): Fix type of `ret'. (Bug#9203)
9870
476371c4
PE
98712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9872
e5d76069
PE
9873 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9874 This is needed if max-image-size is a floating-point number.
9875
9a79b20c
AS
98762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9877
9878 * print.c (print_object): Print empty symbol as ##.
9879
9880 * lread.c (read1): Read ## as empty symbol.
9881
d8c2fa78
AA
98822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9883
9884 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9885 setting frame foreground color (Bug#9175).
9886 (x_set_background_color): Likewise.
9887
ffe57a7a
AA
9888 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9889 contents (Bug#9176).
9890 (EmacsTooltip -init): Remove bezels and add shadows to
9891 tooltip windows.
9892
bf3492a5
AA
9893 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9894 or scroll bar (Bug#8470).
9895
d55e9c53
AA
9896 * nsfont.m (nsfont_open): Remove assignment to voffset and
9897 unnecessary vars hshink, expand, hd, full_height, min_height.
9898 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9899
9900 * nsterm.h (nsfont_info): Remove voffset field.
9901
d8c2fa78 99022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9903
9904 Implement strike-through and overline on NextStep (Bug#8863).
9905
9906 * nsfont.m (nsfont_open): Use underline position provided by font,
9907 instead of hard-coded value of 2.
9908 (nsfont_draw): Call ns_draw_text_decoration instead.
9909
9910 * nsterm.h: Add declaration for ns_draw_text_decoration.
9911
9912 * nsterm.m (ns_draw_text_decoration): New function for drawing
9913 underline, overline, and strike-through.
9914 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9915 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9916 accommodate underlining, etc.
4843aac3 9917
4cc60b9b
EZ
99182011-07-28 Eli Zaretskii <eliz@gnu.org>
9919
bc7ece87
EZ
9920 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9921 default.
4cc60b9b 9922
476371c4
PE
99232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9924
66606eea
PE
9925 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9926 Without this fix, if a signal arrives just after memory fills up,
9927 'malloc' might be invoked reentrantly.
9928
476371c4
PE
9929 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9930 In other words, assume that every image size is allowed, on non-X
9931 hosts. This assumption is probably wrong, but it lets Emacs compile.
9932
f3fcc40d
AS
99332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9934
9935 * regex.c (re_iswctype): Convert return values to boolean.
9936
350c992f
EZ
99372011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9938
9939 * xdisp.c (compute_display_string_pos): Don't use cached display
9940 string position if the buffer had its restriction changed.
9941 (Bug#9184)
9942
5266b4bb
PE
99432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9944
9945 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9946
2573a837 99472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9948
41f55ccd 9949 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9950
39e378da
PE
9951 * bidi.c: Integer size and overflow fixes.
9952 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9953 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9954 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9955 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9956 (bidi_find_other_level_edge):
9957 Use ptrdiff_t instead of EMACS_INT where either will do.
9958 This works better on 32-bit hosts configured --with-wide-int.
9959 (bidi_cache_ensure_space): Check for size-calculation overflow.
9960 Use % rather than repeated addition, for better worst-case speed.
9961 Don't set bidi_cache_size until after xrealloc returns, because it
9962 might not return.
9963 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9964 (bidi_cache_ensure_space): Also check that the bidi cache size
9965 does not exceed that of the largest Lisp string or buffer. See Eli
9966 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9967
5e927815
PE
9968 * alloc.c (__malloc_size_t): Remove.
9969 All uses replaced by size_t. See Andreas Schwab's note
9970 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9971
ca4aa935
PE
9972 * image.c: Improve checking for integer overflow.
9973 (check_image_size): Assume that f is nonnull, since
9974 it is always nonnull in practice. This is one less thing to
9975 worry about when checking for integer overflow later.
9976 (x_check_image_size): New function, which checks for integer
9977 overflow issues inside X.
9978 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9979 This removes the need for a memory_full check.
9980 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9981 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9982 (xbm_read_bitmap_data): Change locals back to 'int', since
9983 their values must fit in 'int'.
9984 (xpm_load_image, png_load, tiff_load):
9985 Invoke x_create_x_image_and_pixmap earlier,
9986 to avoid much needless work if the image is too large.
9987 (tiff_load): Treat overly large images as if
9988 x_create_x_image_and_pixmap failed, not as malloc failures.
9989 (gs_load): Use x_check_image_size.
9990
5f8f9cc2
PE
9991 * gtkutil.c: Omit integer casts.
9992 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9993 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9994
5adf60bc
PE
9995 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9996
c8907a93
PE
9997 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9998 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9999 would wrongly return t on a 64-bit host.
10000
e3c25c68
PE
10001 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
10002 The plain *_OVERFLOW macros run afoul of GCC bug 49705
10003 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
10004 and therefore cause GCC to emit a bogus diagnostic in some cases.
10005
3f791afe
PE
10006 * image.c: Integer signedness and overflow and related fixes.
10007 This is not an exhaustive set of fixes, but it's time to
10008 record what I've got.
10009 (lookup_pixel_color, check_image_size): Remove redundant decls.
10010 (check_image_size): Don't assume that arbitrary EMACS_INT values
10011 fit in 'int', or that arbitrary 'double' values fit in 'int'.
10012 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10013 (tiff_load, imagemagick_load_image):
10014 Check for overflow in size calculations.
10015 (x_create_x_image_and_pixmap): Remove unnecessary test for
10016 xmalloc returning NULL; that can't happen.
10017 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
10018 (xpm_color_bucket): Use better integer hashing function.
10019 (xpm_cache_color): Don't possibly over-allocate memory.
10020 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
10021 (gif_memory_source):
10022 Use ptrdiff_t, not int or size_t, to record sizes.
10023 (png_load): Don't assume values greater than 2**31 fit in 'int'.
10024 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
10025 either works, as we prefer signed integers.
10026 (tiff_read_from_memory, tiff_write_from_memory):
10027 Return tsize_t, not size_t, since that's what the TIFF API wants.
10028 (tiff_read_from_memory): Don't fail simply because the read would
10029 go past EOF; instead, return a short read.
10030 (tiff_load): Omit no-longer-needed casts.
10031 (Fimagemagick_types): Don't assume size fits into 'int'.
10032
3cc5a532
PE
10033 Improve hashing quality when configured --with-wide-int.
10034 * fns.c (hash_string): New function, taken from sxhash_string.
10035 Do not discard information about ASCII character case; this
10036 discarding is no longer needed.
10037 (sxhash-string): Use it. Change sig to match it. Caller changed.
10038 * lisp.h: Declare it.
10039 * lread.c (hash_string): Remove, since we now use fns.c's version.
10040 The fns.c version returns a wider integer if --with-wide-int is
10041 specified, so this should help the quality of the hashing a bit.
10042
b312a492
PE
10043 * emacs.c: Integer overflow minor fix.
10044 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
10045 Define only if GNU_LINUX.
10046 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
10047
dfd153ae
PE
10048 * dispnew.c: Integer signedness and overflow fixes.
10049 Remove unnecessary forward decls, that were a maintenance hassle.
10050 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
10051 All uses changed.
10052 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
10053 (scrolling_window): Use ptrdiff_t, not int, for byte count.
10054 (prepare_desired_row, line_draw_cost):
10055 Use int, not unsigned, where either works.
10056 (save_current_matrix, restore_current_matrix):
10057 Use ptrdiff_t, not size_t, where either works.
10058 (init_display): Check for overflow more accurately, and without
10059 relying on undefined behavior.
10060
a81d11a3
PE
10061 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
10062 Remove, replacing with the new symbols in lisp.h. All uses changed.
10063 * fileio.c (make_temp_name):
10064 * filelock.c (lock_file_1, lock_file):
10065 * xdisp.c (message_dolog):
10066 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10067 Use pMd etc. instead.
10068 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
10069 replacing the pWIDE etc. symbols removed from editfns.c.
10070
3300e6fd
PE
10071 * keyboard.h (num_input_events): Now uintmax_t.
10072 This is (very slightly) less likely to mess up due to wraparound.
10073 All uses changed.
10074
fd05c7e9
PE
10075 * buffer.c: Integer signedness fixes.
10076 (alloc_buffer_text, enlarge_buffer_text):
10077 Use ptrdiff_t rather than size_t when either will do, as we prefer
10078 signed integers.
10079
903fe15d
PE
10080 * alloc.c: Integer signedness and overflow fixes.
10081 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
10082 (__malloc_size_t): Default to size_t, not to int.
10083 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
10084 (Fgarbage_collect, mark_object_loop_halt, mark_object):
10085 Prefer ptrdiff_t to size_t when either would do, as we prefer
10086 signed integers.
10087 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
10088 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
10089 Now const. Initialize with values that are in range even if char
10090 is signed.
10091 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
10092 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
10093 These functions do the right thing with sizes > 2**32.
10094 (check_depth): Now ptrdiff_t, not int.
10095 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
10096 Adjust to new way of storing sizes. Check for size overflow bugs
10097 in rest of code.
10098 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
10099 slightly wrong anyway, as it missed one instance of
10100 XMALLOC_OVERRUN_CHECK_OVERHEAD.
10101 (refill_memory_reserve): Omit needless cast to size_t.
10102 (mark_object_loop_halt): Mark as externally visible.
10103
ac82cc6a
PE
10104 * xselect.c: Integer signedness and overflow fixes.
10105 (Fx_register_dnd_atom, x_handle_dnd_message):
10106 Use ptrdiff_t, not size_t, since we prefer signed.
10107 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
10108 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
10109 x_dnd_atoms_size and x_dnd_atoms_length.
10110
c2d1e36d
PE
10111 * doprnt.c: Prefer signed to unsigned when either works.
10112 * eval.c (verror):
10113 * doprnt.c (doprnt):
10114 * lisp.h (doprnt):
10115 * xdisp.c (vmessage):
10116 Use ptrdiff_t, not size_t, when using or implementing doprnt,
10117 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
10118 prefer signed arithmetic to avoid comparison confusion.
10119 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
10120 but is a bit tricky.
10121
0e926e56
PE
10122 Assume freestanding C89 headers, string.h, stdlib.h.
10123 * data.c, doprnt.c, floatfns.c, print.c:
10124 Include float.h unconditionally.
10125 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
10126 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
10127 * regex.c: Likewise for stddef.h, string.h.
10128 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
10129 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
10130 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
10131 (STDC_HEADERS): Remove obsolete defines.
10132 * sysdep.c: Include limits.h unconditionally.
10133
9cfdb3ec
PE
10134 Assume support for memcmp, memcpy, memmove, memset.
10135 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
10136 * regex.c (memcmp, memcpy):
10137 Remove; we assume C89 now.
10138
10139 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
10140 (__malloc_safe_bcopy): Remove; no longer needed.
10141
cf950e6b 10142 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
10143 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
10144 well either way, and we prefer signed to unsigned.
10145
dbf38e02
LMI
101462011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
10147
10148 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
10149 closes the connection while we're reading (bug#9182).
10150
d6f0886c 101512011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 10152
d6f0886c
JD
10153 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
10154 are specified (Bug#9168).
24e0f6b1 10155
2eb1f9e6
PE
101562011-07-25 Paul Eggert <eggert@cs.ucla.edu>
10157
10158 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
10159 Found by GCC static checking and --with-wide-int on a 32-bit host.
10160
22381272 101612011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
10162
10163 * xdisp.c (compute_display_string_pos): Fix logic of caching
10164 previous display string position. Initialize cached_prev_pos to
10165 -1. Fixes slow-down at the beginning of a buffer.
10166
f25e39b4
EZ
101672011-07-24 Eli Zaretskii <eliz@gnu.org>
10168
10169 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
10170 for attrs[LFACE_FONTSET_INDEX].
10171
04c4b52e
PE
101722011-07-23 Paul Eggert <eggert@cs.ucla.edu>
10173
10174 * xml.c (parse_region): Remove unused local
10175 that was recently introduced.
10176
c1734fbd
EZ
101772011-07-23 Eli Zaretskii <eliz@gnu.org>
10178
be18c5a5
EZ
10179 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
10180 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
10181
c1734fbd
EZ
10182 * xdisp.c (move_it_in_display_line_to): Record the best matching
10183 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
10184 exit if none of the characters scanned was an exact match.
10185 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
10186 when exact match is impossible due to invisible text, and the
10187 lines are truncated.
10188
a258d627
JD
101892011-07-23 Jan Djärv <jan.h.d@swipnet.se>
10190
10191 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
10192 for OSX >= 10.7.
10193
b6d5a689
EZ
101942011-07-22 Eli Zaretskii <eliz@gnu.org>
10195
0f74f785
EZ
10196 Fix a significant slow-down of cursor motion with C-n, C-p,
10197 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
10198 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 10199 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
10200 (next_element_from_buffer): Call compute_stop_pos_backwards to
10201 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
10202 base_level_stop.
10203 (reseat): Don't look for prev_stop, as that could mean a very long
10204 run.
10205 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
10206 <cached_disp_overlay_modiff>: Cache for last found display string
10207 position.
551918c1 10208 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
10209 about the same buffer in the same area of character positions, and
10210 the buffer wasn't changed since the time the display string
10211 position was cached.
551918c1 10212
b2d0c91a
EZ
102132011-07-22 Eli Zaretskii <eliz@gnu.org>
10214
10215 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
10216 is an integer, which is important for empty lines. (Bug#9149)
10217
043604ee
CY
102182011-07-22 Chong Yidong <cyd@stupidchicken.com>
10219
10220 * frame.c (Fmodify_frame_parameters): In tty case, update the
10221 default face if necessary (Bug#4238).
10222
da4adb04
CY
102232011-07-21 Chong Yidong <cyd@stupidchicken.com>
10224
10225 * editfns.c (Fstring_to_char): No need to explain what a character
10226 is in the docstring (Bug#6576).
10227
9abd0532
LMI
102282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10229
10230 * xml.c (parse_region): Make sure we always return a tree.
10231
36881d16
HK
102322011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
10233
10234 * xml.c (parse_region): If a document contains only comments,
10235 return that, too.
10236
1e98674d
LMI
102372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10238
10239 * xml.c (make_dom): Return comments, too.
10240
590bd467
PE
102412011-07-19 Paul Eggert <eggert@cs.ucla.edu>
10242
10243 Port to OpenBSD.
10244 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
10245 and the surrounding thread.
10246 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
10247 rather than fgets, and retry after EINTR. Otherwise, 'emacs
10248 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
10249 timer goes off.
10250 * s/openbsd.h (BROKEN_SIGIO): Define.
10251 * unexelf.c (unexec) [__OpenBSD__]:
10252 Don't update the .mdebug section of the Alpha COFF symbol table.
10253
f41628b2
LMI
102542011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10255
10256 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
10257 (bug#8460).
10258
b59b67c5
PE
102592011-07-18 Paul Eggert <eggert@cs.ucla.edu>
10260
15e3a074
PE
10261 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
10262 This fixes some race conditions on the permissions of any newly
10263 created file.
10264
41bed37d
PE
10265 * alloc.c (valid_pointer_p): Use pipe, not open.
10266 This fixes some permissions issues when debugging.
10267
b59b67c5
PE
10268 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
10269 If fchown fails to set both uid and gid, try to set just gid,
10270 as that is sometimes allowed. Adjust the file's mode to eliminate
10271 setuid or setgid bits that are inappropriate if fchown fails.
10272
925a6be7
SM
102732011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
10274
10275 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
10276 to compare Lisp_Objects.
10277 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
10278 global_gnutls_log_level, don't mistake it for a Lisp_Object.
10279 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
10280
52968808
AS
102812011-07-17 Andreas Schwab <schwab@linux-m68k.org>
10282
0a6a104b
AS
10283 * lread.c (read_integer): Unread even EOF character.
10284 (read1): Likewise. Properly record start position of symbol.
10285
52968808
AS
10286 * lread.c (read1): Read `#:' as empty uninterned symbol if no
10287 symbol character follows.
10288
9e381cdd
PE
102892011-07-17 Paul Eggert <eggert@cs.ucla.edu>
10290
10291 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
10292 This works around a problem with the previous change to Fcopy_file.
10293 Recent glibc declares fchown with __attribute__((warn_unused_result)),
10294 and without this change, GCC might complain about discarding
10295 fchown's return value.
10296
b5641435
JB
102972011-07-16 Juanma Barranquero <lekktu@gmail.com>
10298
10299 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
10300
a8031457
PE
103012011-07-16 Paul Eggert <eggert@cs.ucla.edu>
10302
10303 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
10304
dd889327
LMI
103052011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
10306
750c33f7
LMI
10307 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
10308 it's used from the C level.
10309
dd889327
LMI
10310 * process.c: Use the same condition for POLL_FOR_INPUT in both
10311 keyboard.c and process.c (bug#1858).
10312
87e86684
LM
103132011-07-09 Lawrence Mitchell <wence@gmx.li>
10314
10315 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
10316 (Fgnutls_boot): Use it.
10317
64348f40
AS
103182011-07-15 Andreas Schwab <schwab@linux-m68k.org>
10319
10320 * doc.c (Fsubstitute_command_keys): Revert last change.
10321
1d698799
LMI
103222011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
10323
f863868c
LMI
10324 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
10325 quotes the next character, and doesn't affect other longer
10326 sequences (bug#8935).
10327
1d698799
LMI
10328 * lread.c (syms_of_lread): Clarify that is isn't only
10329 `eval-buffer' and `eval-defun' that's affected by
10330 `lexical-binding' (bug#8460).
10331
aa4b6df6
EZ
103322011-07-15 Eli Zaretskii <eliz@gnu.org>
10333
10334 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 10335 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 10336
5d856da6
PE
103372011-07-14 Paul Eggert <eggert@cs.ucla.edu>
10338
ad6042bb
PE
10339 Fix minor problems found by static checking.
10340 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
10341 (elsz): Now a signed constant, not a size_t var. We prefer signed
10342 types to unsigned, to avoid integer comparison confusion. Without
10343 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
10344 "cannot optimize loop, the loop counter may overflow", a symptom
10345 of the confusion.
f00bbb22 10346 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
10347 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
10348
6468f31c
LMI
103492011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10350
49080b10
LMI
10351 * search.c (Fre_search_backward): Mention `case-fold-search' in
10352 all the re_search_* functions (bug#8138).
10353
6468f31c
LMI
10354 * keyboard.c (Fopen_dribble_file): Document when the file is
10355 closed (bug#8056).
10356
c965adc5
EZ
103572011-07-14 Eli Zaretskii <eliz@gnu.org>
10358
df9733bf
EZ
10359 * bidi.c (bidi_dump_cached_states): Fix format of displaying
10360 bidi_cache_idx.
10361
0bb23927
EZ
10362 Support bidi reordering of display and overlay strings.
10363 * xdisp.c (compute_display_string_pos)
10364 (compute_display_string_end): Accept additional argument STRING.
10365 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
10366 (reseat_to_string): Initialize bidi_it->string.s and
10367 bidi_it->string.schars.
10368 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
10369 NULL (avoids a crash in bidi_paragraph_init).
10370 Initialize itb.string.lstring.
0bb23927
EZ
10371 (init_iterator): Call bidi_init_it only of a valid
10372 buffer position was specified. Initialize paragraph_embedding to
10373 L2R.
10374 (reseat_to_string): Initialize the bidi iterator.
10375 (display_string): If we need to ignore text properties of
10376 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
10377 original value of -1 will not work with bidi.)
10378 (compute_display_string_pos): First arg is now struct
10379 `text_pos *'; all callers changed. Support display properties on
10380 Lisp strings.
10381 (compute_display_string_end): Support display properties on Lisp
10382 strings.
10383 (init_iterator, reseat_1, reseat_to_string): Initialize the
10384 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10385 when iterating on a string not from display properties).
640c8776
SM
10386 (compute_display_string_pos, compute_display_string_end):
10387 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10388 arrow keys.
10389 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10390 base_level_stop; instead, set base_level_stop to BEGV.
10391 Fixes crashes in vertical-motion.
0bb23927
EZ
10392 (next_element_from_buffer): Improve commentary for when
10393 the iterator is before prev_stop.
10394 (init_iterator): Initialize bidi_p from the default value of
10395 bidi-display-reordering, not from buffer-local value. Use the
10396 buffer-local value only if initializing for buffer iteration.
10397 (handle_invisible_prop): Support invisible properties on strings
10398 that are being bidi-reordered.
10399 (set_iterator_to_next): Support bidi reordering of C strings and
10400 Lisp strings.
10401 (next_element_from_string): Support bidi reordering of Lisp
10402 strings.
10403 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10404 (display_string): Support display of R2L glyph rows.
10405 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10406 (init_iterator): Don't initialize it->bidi_p for strings
10407 here.
10408 (reseat_to_string): Initialize it->bidi_p for strings here.
10409 (next_element_from_string, next_element_from_c_string)
10410 (next_element_from_buffer): Add xassert's for correspondence
10411 between IT's object being iterated and it->bidi_it.string
10412 structure.
10413 (face_before_or_after_it_pos): Support bidi iteration.
10414 (next_element_from_c_string): Handle the case of the first string
10415 character that is not the first one in the visual order.
10416 (get_visually_first_element): New function, refactored from common
10417 parts of next_element_from_buffer, next_element_from_string, and
10418 next_element_from_c_string.
10419 (tool_bar_lines_needed, redisplay_tool_bar)
10420 (display_menu_bar): Force left-to-right direction. Add a FIXME
10421 comment for making that be controlled by a user option.
10422 (push_it, pop_it): Save and restore the state of the
10423 bidi iterator. Save and restore the bidi_p flag.
10424 (pop_it): Iterate out of display property for string iteration as
10425 well.
10426 (iterate_out_of_display_property): Support iteration over strings.
10427 (handle_single_display_spec): Set up it->bidi_it for iteration
10428 over a display string, and call bidi_init_it.
10429 (handle_single_display_spec, next_overlay_string)
10430 (get_overlay_strings_1, push_display_prop): Set up the bidi
10431 iterator for displaying display or overlay strings.
10432 (forward_to_next_line_start): Don't use the shortcut if
10433 bidi-iterating.
10434 (back_to_previous_visible_line_start): If handle_display_prop
10435 pushed the iterator stack, restore the internal state of the bidi
10436 iterator by calling bidi_pop_it same number of times.
10437 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10438 and we are bidi-iterating, don't decrement the iterator position;
10439 instead, set the first_elt flag in the bidi iterator, to produce
10440 the same effect.
10441 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10442 (push_display_prop): xassert that we are iterating a buffer.
10443 (push_it, pop_it): Save and restore paragraph_embedding member.
10444 (handle_single_display_spec, next_overlay_string)
10445 (get_overlay_strings_1, reseat_1, reseat_to_string)
10446 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10447 correctly. Don't assume unibyte strings are not bidi-reordered.
10448 (compute_display_string_pos)
10449 (compute_display_string_end): Fix handling the case of C string.
10450 (push_it, pop_it): Save and restore from_disp_prop_p.
10451 (handle_single_display_spec, push_display_prop): Set the
10452 from_disp_prop_p flag.
10453 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10454 (pop_it): Call iterate_out_of_display_property only if we are
10455 popping after iteration over a string that came from a display
10456 property. Fix a typo in popping stretch info. Add an assertion
10457 for verifying that the iterator position is in sync with the bidi
10458 iterator.
10459 (handle_single_display_spec, get_overlay_strings_1)
10460 (push_display_prop): Fix initialization of paragraph direction for
10461 string when that of the parent object is not yet determined.
10462 (reseat_1): Call bidi_init_it to resync the bidi
10463 iterator with IT's position. (Bug#7616)
10464 (find_row_edges): If ROW->start.pos gives position
10465 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10466 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10467 Reset the from_disp_prop_p flag.
10468 (SAVE_IT, RESTORE_IT): New macros.
10469 (pos_visible_p, face_before_or_after_it_pos)
10470 (back_to_previous_visible_line_start)
10471 (move_it_in_display_line_to, move_it_in_display_line)
10472 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10473 (try_scrolling, redisplay_window, display_line): Use them when
10474 saving a temporary copy of the iterator and restoring it back.
10475 (back_to_previous_visible_line_start, reseat_1)
10476 (init_iterator): Empty the bidi cache "stack".
10477 (move_it_in_display_line_to): If iterator ended up at
10478 EOL, but we never saw any buffer positions smaller than
10479 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10480 motion in bidi-reordered lines.
10481 (move_it_in_display_line_to): Record prev_method and prev_pos
10482 immediately before the call to set_iterator_to_next. Fixes cursor
10483 motion in bidi-reordered lines with stretch glyphs and strings
10484 displayed in margins. (Bug#8133) (Bug#8867)
10485 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10486 TO_CHARPOS.
640c8776
SM
10487 (pos_visible_p): Support positions in bidi-reordered lines.
10488 Save and restore bidi cache.
0bb23927
EZ
10489
10490 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10491 (bidi_paragraph_info): Delete unused struct.
10492 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10493 (bidi_cache_start): New variable.
10494 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10495 to zero.
10496 (bidi_cache_fetch_state, bidi_cache_search)
10497 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10498 (bidi_cache_find, bidi_peek_at_next_level)
10499 (bidi_level_of_next_char, bidi_find_other_level_edge)
10500 (bidi_move_to_visually_next): Compare cache index with
10501 bidi_cache_start rather than with zero.
10502 (bidi_fetch_char): Accept new argument STRING; all callers
10503 changed. Support iteration over a string. Support strings with
10504 display properties. Support unibyte strings. Fix the type of
10505 `len' according to what STRING_CHAR_AND_LENGTH expects.
10506 (bidi_paragraph_init, bidi_resolve_explicit_1)
10507 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10508 (bidi_level_of_next_char, bidi_move_to_visually_next):
10509 Support iteration over a string.
0bb23927
EZ
10510 (bidi_set_sor_type, bidi_resolve_explicit_1)
10511 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10512 can now be zero (for strings); special values 0 and -1 were
10513 changed to -1 and -2, respectively.
10514 (bidi_char_at_pos): New function.
10515 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10516 Call it instead of FETCH_MULTIBYTE_CHAR.
10517 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10518 initialized to valid values.
10519 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10520 values.
10521 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10522 the test for valid cached positions. Fix the logic for looking up
10523 the sentinel state in the cache. GCPRO the Lisp string we are
10524 iterating.
10525 (bidi_push_it, bidi_pop_it): New functions.
10526 (bidi_initialize): Initialize the bidi cache start stack pointer.
10527 (bidi_cache_ensure_space): New function, refactored from part of
10528 bidi_cache_iterator_state. Don't assume the required size is just
10529 one BIDI_CACHE_CHUNK away.
10530 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10531 (bidi_count_bytes, bidi_char_at_pos): New functions.
10532 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10533 always valid if bidi_cache_idx is valid.
10534 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10535 is valid if it's going to be used.
10536 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10537 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10538 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10539 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10540 (bidi_find_other_level_edge, bidi_cache_start_stack):
10541 All variables related to cache indices are now EMACS_INT.
c965adc5 10542
0bb23927
EZ
10543 * dispextern.h (struct bidi_string_data): New structure.
10544 (struct bidi_it): New member `string'. Make flag members be 1-bit
10545 fields, and put them last in the struct.
640c8776
SM
10546 (compute_display_string_pos, compute_display_string_end):
10547 Update prototypes.
0bb23927
EZ
10548 (bidi_push_it, bidi_pop_it): Add prototypes.
10549 (struct iterator_stack_entry): New members bidi_p,
10550 paragraph_embedding, and from_disp_prop_p.
10551 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10552 (bidi_shelve_cache, bidi_unshelve_cache):
10553 Declare prototypes.
0bb23927
EZ
10554
10555 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10556 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10557 and vector-like objects.
10558
10559 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10560 cache around display iteration.
10561
10562 * window.c (Fwindow_end, window_scroll_pixel_based)
10563 (displayed_window_lines, Frecenter): Save and restore the bidi
10564 cache around display iteration.
10565
3bbd2265
LMI
105662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10567
10568 * editfns.c (Fdelete_region): Clarify the use of the named
10569 parameters (bug#6788).
10570
adc47434
MR
105712011-07-14 Martin Rudalics <rudalics@gmx.at>
10572
10573 * indent.c (Fvertical_motion): Set and restore w->pointm when
10574 saving and restoring the window's buffer (Bug#9006).
10575
837c31f8
LMI
105762011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
10577
10578 * editfns.c (Fstring_to_char): Clarify just what is returned
10579 (bug#6576). Text by Eli Zaretskii.
10580
ac389d0c
JB
105812011-07-13 Juanma Barranquero <lekktu@gmail.com>
10582
10583 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
10584
0be0ce47
EZ
105852011-07-13 Eli Zaretskii <eliz@gnu.org>
10586
10587 * buffer.c (mmap_find): Fix a typo.
10588
cd18e7e3
JB
105892011-07-13 Johan Bockgård <bojohan@gnu.org>
10590
10591 Fix execution of x selection hooks.
10592 * xselect.c (Qx_lost_selection_functions)
10593 (Qx_sent_selection_functions): New vars.
10594 (syms_of_xselect): DEFSYM them.
10595 (x_handle_selection_request): Pass Qx_sent_selection_functions
10596 rather than Vx_sent_selection_functions to Frun_hook_with_args.
10597 (x_handle_selection_clear,x_clear_frame_selections):
10598 Pass Qx_lost_selection_functions rather than
10599 Vx_lost_selection_functions to Frun_hook_with_args.
10600
47ea7f44
PE
106012011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10602
ac389d0c 10603 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10604 The old code sometimes used this field without initializing it.
10605
47ea7f44
PE
10606 * alloc.c (gc_sweep): Don't read past end of array.
10607 In theory, the old code could also have corrupted Emacs internals,
10608 though it'd be very unlikely.
10609
bc985c87
AS
106102011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10611
10612 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10613 argument. (Bug#4026)
bc985c87 10614
0cf34688
LMI
106152011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10616
b3dadd76
LMI
10617 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10618 key" (bug#4257).
10619
0cf34688
LMI
10620 * window.c (Fset_window_start): Doc fix (bug#4199).
10621 (Fset_window_hscroll): Ditto.
10622
270768cd
PE
106232011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10624
077e3dda 10625 Fix minor new problems caught by GCC 4.6.1.
270768cd 10626 * term.c (init_tty): Remove unused local.
490011a6 10627 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10628 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10629 not used otherwise.
270768cd 10630
b1f58454
CY
106312011-07-12 Chong Yidong <cyd@stupidchicken.com>
10632
10633 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10634
22b9578d
LMI
106352011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10636
6e70ab07
LMI
10637 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10638 are the mini-buffer and the echo area (bug#3320).
10639
22b9578d
LMI
10640 * term.c (init_tty): Remove support for supdup, c10 and perq
10641 terminals, which are no longer supported (bug#1482).
10642
8974cc9f
JB
106432011-07-10 Johan Bockgård <bojohan@gnu.org>
10644
10645 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10646
a560d974
JD
106472011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10648
10649 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10650 for non-popups (Bug#3642).
10651
1dae0f0a
AS
106522011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10653
268c2c36 10654 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10655 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10656 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10657 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10658 * data.c (fmod): Likewise.
10659 * dispnew.c (swap_glyphs_in_rows): Likewise.
10660 * emacs.c (memory_warning_signal): Likewise.
10661 * floatfns.c (float_error): Likewise.
10662 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10663 (otf_open, font_otf_capability, generate_otf_features)
10664 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10665 Likewise.
10666 * image.c (pbm_read_file): Likewise.
10667 * indent.c (string_display_width): Likewise.
10668 * intervals.c (check_for_interval, search_for_interval)
10669 (inc_interval_count, count_intervals, root_interval)
10670 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10671 * lread.c (defalias): Likewise.
268c2c36 10672 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10673 * regex.c (set_image_of_range_1, set_image_of_range)
10674 (regex_grow_registers): Likewise.
10675 * sysdep.c (strerror): Likewise.
10676 * termcap.c (valid_filename_p, tprint, main): Likewise.
10677 * tparam.c (main): Likewise.
10678 * unexhp9k800.c (run_time_remap, save_data_space)
10679 (update_file_ptrs, read_header, write_header, calculate_checksum)
10680 (copy_file, copy_rest, display_header): Likewise.
10681 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10682 Likewise.
10683 * xdisp.c (check_it): Likewise.
10684 * xfaces.c (register_color, unregister_color, unregister_colors):
10685 Likewise.
10686 * xfns.c (print_fontset_result): Likewise.
10687 * xrdb.c (member, fatal, main): Likewise.
10688
99033785
PE
106892011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10690
10691 Fix minor problems found by static checking (Bug#9031).
10692 * chartab.c (char_table_set_range, map_sub_char_table):
10693 Remove unused locals.
10694 (uniprop_table): Now static.
10695 * composite.c (_work_char): Remove unused static var.
10696
9cb2ac56
JB
106972011-07-09 Juanma Barranquero <lekktu@gmail.com>
10698
10699 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10700
f25661f0
JD
107012011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10702
10703 * gtkutil.c (qttip_cb): Remove code without function.
10704
8278c4fe
EZ
107052011-07-09 Eli Zaretskii <eliz@gnu.org>
10706
10707 * w32.c (pthread_sigmask): New stub.
10708
1692ae2d 107092011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10710
8a6ebd58 10711 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10712 sigprocmask is portable only for single-threaded applications, and
10713 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10714 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10715 (LIBES): Use it.
10716 * callproc.c (Fcall_process):
10717 * process.c (create_process):
10718 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10719 Use pthread_sigmask, not sigprocmask.
123403e4 10720
1b854618
JD
107212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10722
10723 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10724 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10725 wrong (Bug#8591).
10726
3fe4b549
JD
107272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10728
0ce7e563
JD
10729 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10730 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10731 (xg_hide_tooltip): Fix comment.
10732
3fe4b549
JD
10733 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10734 in registerServicesMenuSendTypes.
10735 (validRequestorForSendType): Don't check ns_return_types.
10736
10737 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10738 ns_return_type.
10739
5df75e47
JR
107402011-07-08 Jason Rumney <jasonr@gnu.org>
10741
22610910
JR
10742 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10743 SH_SHOW for hidden windows (Bug#5482).
10744
5df75e47
JR
10745 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10746 frame struct members of non-existent frames (Bug#6284).
10747
699c10bd
JD
107482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10749
4393663b
JD
10750 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10751 variable firstTime not needed on OSX >= 10.6.
10752 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10753 >= 10.5. Use setKnobProportion, setDoubleValue.
10754
10755 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10756 (MAC_OS_X_VERSION_10_5): Define if not defined.
10757 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10758 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10759 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10760
10761 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10762 cString and lossyCString on OSX >= 10.4.
4393663b 10763
58179cce 10764 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10765 sizeToFit on OSX >= 10.2.
10766
10767 * nsimage.m (allocInitFromFile): Don't use deprecated method
10768 bestRepresentationForDevice on OSX >= 10.6.
10769
10770 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10771 to avoid warning.
10772
10773 * emacs.c: Declare unexec_init_emacs_zone.
10774
a63e0781
JD
10775 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10776
699c10bd
JD
10777 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10778
10779 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10780 on svcsMenu (Bug#8842).
10781
10782 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10783 ns_return_types.
10784 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10785
10786 * nsterm.m (QUTF8_STRING): Declare.
10787 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10788 (validRequestorForSendType): Return type is (id).
10789 Change indexOfObjectIdenticalTo to indexOfObject.
10790 Check if we have local selection before returning self (Bug#8842).
10791 (writeSelectionToPasteboard): Put local selection into paste board
10792 if we have a local selection (Bug#8842).
10793 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10794
10795 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10796 (ns_get_local_selection): Declare.
10797
54e10184
LMI
107982011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10799
9888ff71
LMI
10800 * keymap.c (describe_map_tree): Don't insert a double newline at
10801 the end of the buffer (bug#1169) and return whether we inserted
10802 something.
10803
54e10184
LMI
10804 * callint.c (Fcall_interactively): Change "reading args" to
10805 "providing args" to try to clarify what it does (bug#1010).
10806
15fa4783
KH
108072011-07-07 Kenichi Handa <handa@m17n.org>
10808
10809 * composite.c (composition_compute_stop_pos): Ignore a static
10810 composition starting before CHARPOS (Bug#8915).
10811
10812 * xdisp.c (handle_composition_prop): Likewise.
10813
a8815b00
EZ
108142011-07-07 Eli Zaretskii <eliz@gnu.org>
10815
10816 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10817 (Bug#9015)
10818
ef7b981d 108192011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10820
10821 * character.h (unicode_category_t): New enum type.
10822
10823 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10824 (Qchar_code_property_table): New variable.
10825 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10826 (UNIPROP_COMPRESSED_FORM_P): New macros.
10827 (char_table_ascii): Uncompress the compressed values.
10828 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10829 Uncompress the compressed values.
ac389d0c 10830 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10831 (char_table_ref_and_range): Uncompress the compressed values.
10832 (sub_char_table_set): New arg is_uniprop. Callers changed.
10833 Uncompress the compressed values.
10834 (sub_char_table_set_range): Args changed. Callers changed.
10835 (char_table_set_range): Adjuted for the above change.
10836 (map_sub_char_table): Delete args default_val and parent. Add arg
10837 top. Give decoded values to a Lisp function.
640c8776 10838 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10839 values to a Lisp function. Gcpro more variables.
10840 (uniprop_table_uncompress)
10841 (uniprop_decode_value_run_length): New functions.
10842 (uniprop_decoder, uniprop_decoder_count): New variables.
10843 (uniprop_get_decoder, uniprop_encode_value_character)
10844 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10845 New functions.
10846 (uniprop_encoder, uniprop_encoder_count): New variables.
10847 (uniprop_get_encoder, uniprop_table)
10848 (Funicode_property_table_internal, Fget_unicode_property_internal)
10849 (Fput_unicode_property_internal): New functions.
10850 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10851 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10852 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10853 char-code-property-alist.
10854
640c8776 10855 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10856 Vunicode_category_table.
10857
640c8776 10858 * font.c (font_range): Adjust for the change of
c805dec0
KH
10859 Vunicode_category_table.
10860
76b397fb
DN
108612011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10862
10863 * m/iris4d.h: Remove file, move contents ...
10864 * s/irix6-5.h: ... here.
10865
22b4128e
PE
108662011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10867
10868 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10869 * alloc.c (mark_buffer):
10870 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10871 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10872 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10873 This isn't true in general, and it's particularly not true
10874 if Emacs is configured with --with-wide-int.
10875 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10876 New macros, used in the buffer.c change.
10877
869795d6
JD
108782011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10879
10880 * xsettings.c: Use both GConf and GSettings if both are available.
10881 (store_config_changed_event): Add comment.
10882 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10883 (store_tool_bar_style_changed): New functions.
5e617bc2 10884 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10885 (struct xsettings): Move font inside HAVE_XFT.
10886 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10887 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10888 Move inside HAVE_XFT.
640c8776 10889 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10890 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10891 also.
10892 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10893 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10894 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10895 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10896 (parse_settings): Move check for font inside HAVE_XFT.
10897 (read_settings, apply_xft_settings): Add comment.
10898 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10899 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10900 call store_font_name_changed.
10901 (xft_settings_event): Add comment.
10902 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10903 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10904 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10905 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10906 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10907 (xsettings_get_system_font, xsettings_get_system_normal_font):
10908 Add comment.
869795d6 10909
d8ed26bd
PE
109102011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10911
10912 Random fixes. E.g., (random) never returned negative values.
10913 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10914 subseconds part to the entropy, as that's a bit more random.
10915 Prefer signed to unsigned, since the signedness doesn't matter and
10916 in general we prefer signed. When given a limit, use a
10917 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10918 latter isn't right if USE_2_TAGS_FOR_INTS.
10919 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10920 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10921
cabf1cac
SM
109222011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10923
10924 * textprop.c (text_property_stickiness):
10925 Obey Vtext_property_default_nonsticky.
10926 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10927 * w32fns.c (syms_of_w32fns):
10928 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10929
6e9b2be9
PE
109302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10931
10932 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10933 This is more efficient than Ffile_directory_p and avoids a minor race.
10934
90186c68
LMI
109352011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10936
7c301272
LMI
10937 * buffer.c (Foverlay_put): Say what the return value is
10938 (bug#7835).
10939
c4f2d8d4
LMI
10940 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10941 is a directory before asking whether to use the file name
10942 (bug#7564).
ad637907
LMI
10943 (barf_or_query_if_file_exists): Make the "File is a directory"
10944 error be more correct.
c4f2d8d4 10945
90186c68
LMI
10946 * fns.c (Frequire): Remove the mention of the .gz files, since
10947 that's installation-specific, but keep the mention of
10948 `get-load-suffixes'.
10949
da64016e
PE
109502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10951
10952 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10953 Report string overflow if the output is too long.
10954
7d47b580
JB
109552011-07-04 Juanma Barranquero <lekktu@gmail.com>
10956
a555cb87
JB
10957 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10958 (syms_of_gnutls): Remove duplicate DEFSYM for
10959 Qgnutls_bootprop_verify_hostname_error, an error for
10960 Qgnutls_bootprop_verify_error (which is no longer used).
10961
7d47b580
JB
10962 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10963 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10964 Also (re)move comments that are misplaced or no longer relevant.
10965
1e49bfab
LMI
109662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10967
10968 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10969
1485f4c0
CY
109702011-07-03 Chong Yidong <cyd@stupidchicken.com>
10971
10972 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10973 and background color parameters if they have been changed.
10974
a9ab721e
LMI
109752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10976
10977 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10978
cf7cff57
PE
109792011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10980
2e13213d
PE
10981 * xsettings.c (SYSTEM_FONT): Define only when used.
10982 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10983
cf7cff57
PE
10984 * keymap.c (access_keymap_1): Now static.
10985
7a8e04f7
CY
109862011-07-02 Chong Yidong <cyd@stupidchicken.com>
10987
10988 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10989 leave any prefix arg for the up event (Bug#1586).
10990
61352f62
LMI
109912011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10992
69bb1ef7
LMI
10993 * lread.c (syms_of_lread): Mention single symbols defined by
10994 `defvar' or `defconst' (bug#7154).
10995
61352f62 10996 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10997 (Frequire): Mention get-load-suffixes.
61352f62 10998
28545e04
MR
109992011-07-02 Martin Rudalics <rudalics@gmx.at>
11000
11001 * window.h (window): Remove clone_number slot.
11002 * window.c (Fwindow_clone_number, Fset_window_clone_number):
11003 Remove.
11004 (make_parent_window, make_window, saved_window)
11005 (Fset_window_configuration, save_window_save): Don't deal with
11006 clone numbers.
11007 * buffer.c (Qclone_number): Remove declaration.
11008 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11009
3349e122
SM
110102011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
11011
11012 Add multiple inheritance to keymaps.
11013 * keymap.c (Fmake_composed_keymap): New function.
11014 (Fset_keymap_parent): Simplify.
11015 (fix_submap_inheritance): Remove.
11016 (access_keymap_1): New function extracted from access_keymap to handle
11017 embedded parents and handle lists of maps.
11018 (access_keymap): Use it.
11019 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11020 (Fcopy_keymap): Handle embedded parents.
11021 (Fcommand_remapping, define_as_prefix): Simplify.
11022 (Fkey_binding): Simplify.
11023 (syms_of_keymap): Move minibuffer-local-completion-map,
11024 minibuffer-local-filename-completion-map,
11025 minibuffer-local-must-match-map, and
11026 minibuffer-local-filename-must-match-map to Elisp.
11027 (syms_of_keymap): Defsubr make-composed-keymap.
11028 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
11029 (parse_menu_item): Trivial simplification.
11030
3279eb87
GM
110312011-07-01 Glenn Morris <rgm@gnu.org>
11032
11033 * Makefile.in (SETTINGS_LIBS): Fix typo.
11034
39cb9e56 110352011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
11036
11037 * coding.c (Fencode_coding_string): Record the last coding system
11038 used, as the function doc string says (bug#8738).
11039
0949d2b6
JD
110402011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11041
11042 * xsettings.c (store_monospaced_changed): Take new font as arg and
11043 check for change against current_mono_font.
11044 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11045 (emacs_settings_constructor, emacs_settings_get_property)
11046 (emacs_settings_set_property, emacs_settings_class_init)
11047 (emacs_settings_init, gsettings_obj): Remove.
11048 (something_changedCB): New function for HAVE_GSETTINGS.
11049 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
11050 with value as argument.
11051 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
11052 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 11053 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
11054 "changed".
11055
11056 * xgselect.c: Add defined (HAVE_GSETTINGS).
11057 (xgselect_initialize): Ditto.
11058
11059 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
11060 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
11061 xg_select.
11062
bbc6b304
PE
110632011-07-01 Paul Eggert <eggert@cs.ucla.edu>
11064
11065 * eval.c (struct backtrace): Simplify and port the data structure.
11066 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
11067 signed bit field, as this assumption is not portable and it makes
11068 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
11069 "char debug_on_exit : 1" as this is not portable either; instead,
11070 use the portable "unsigned int debug_on_exit : 1". Remove unused
11071 member evalargs. Remove obsolete comments about cc bombing out.
11072
9851bfc5
JD
110732011-06-30 Jan Djärv <jan.h.d@swipnet.se>
11074
51bb811f 11075 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
11076 Let HAVE_GSETTINGS override HAVE_GCONF.
11077 (store_monospaced_changed): New function.
11078 (EMACS_SETTINGS): A new type derived from GObject to handle
11079 GSettings notifications.
11080 (emacs_settings_constructor, emacs_settings_get_property)
11081 (emacs_settings_set_property, emacs_settings_class_init):
11082 New functions.
11083 (gsettings_client, gsettings_obj): New variables.
11084 (GSETTINGS_SCHEMA): New define.
11085 (something_changedCB): Call store_monospaced_changed.
11086 (init_gsettings): New function.
11087 (xsettings_initialize): Call init_gsettings.
11088 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
11089 to NULL.
11090
640c8776 11091 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
11092 GCONF_CFLAGS/LIBS.
11093
5386012d
MR
110942011-06-29 Martin Rudalics <rudalics@gmx.at>
11095
11096 * window.c (resize_root_window, grow_mini_window)
11097 (shrink_mini_window): Rename Qresize_root_window to
11098 Qwindow_resize_root_window and Qresize_root_window_vertically to
11099 Qwindow_resize_root_window_vertically.
11100
f13e0b08
PE
111012011-06-28 Paul Eggert <eggert@cs.ucla.edu>
11102
11103 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
11104
94515237
JB
111052011-06-27 Juanma Barranquero <lekktu@gmail.com>
11106
11107 * makefile.w32-in: Redesign dependencies so they reflect more
11108 clearly which files are directly included by each source file,
11109 and not through other includes.
11110
e43b6e43
MR
111112011-06-27 Martin Rudalics <rudalics@gmx.at>
11112
11113 * buffer.c (Qclone_number): Declare static and DEFSYM it.
11114 (sort_overlays, overlay_strings): When an overlay's clone number
11115 matches the window's clone number process the overlay even if
11116 the overlay's window property doesn't match the current window.
11117
d68443dc
MR
11118 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
11119 (Fwindow_hchild): Rename to Fwindow_left_child.
11120 (Fwindow_next): Rename to Fwindow_next_sibling.
11121 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
11122 (resize_window_check): Rename to window_resize_check.
11123 (resize_window_apply): Rename to window_resize_apply.
11124 (Fresize_window_apply): Rename to Fwindow_resize_apply.
11125 (Fdelete_other_windows_internal, resize_frame_windows)
11126 (Fsplit_window_internal, Fdelete_window_internal)
11127 (grow_mini_window, shrink_mini_window)
11128 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 11129
c7e73be5
JD
111302011-06-26 Jan Djärv <jan.h.d@swipnet.se>
11131
11132 * emacsgtkfixed.h: State that this is only used with Gtk+3.
11133 (emacs_fixed_set_min_size): Remove.
11134 (emacs_fixed_new): Take frame as argument.
11135
11136 * emacsgtkfixed.c: State that this is only used with Gtk+3.
11137 (_EmacsFixedPrivate): Remove minwidth/height.
11138 Add struct frame *f.
11139 (emacs_fixed_init): Initialize priv->f.
11140 (get_parent_class, emacs_fixed_set_min_size): Remove.
11141 (emacs_fixed_new): Set priv->f to argument.
11142 (emacs_fixed_get_preferred_width)
11143 (emacs_fixed_get_preferred_height): Use min_width/height from
11144 frames size_hint to set minimum and natural (Bug#8919).
11145 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
11146 and use min_width/height from frames size_hint to set
11147 min_width/height (Bug#8919).
11148
11149 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
11150 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
11151 Fix indentation.
c7e73be5 11152
cf99dcf8
EZ
111532011-06-26 Eli Zaretskii <eliz@gnu.org>
11154
11155 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
11156 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
11157 called at ZV.
11158
029529ac
CY
111592011-06-26 Chong Yidong <cyd@stupidchicken.com>
11160
11161 * process.c (wait_reading_process_output): Bypass select if
11162 waiting for a cell while ignoring keyboard input, and input is
11163 pending. Suggested by Jan Djärv (Bug#8869).
11164
7a7ef429
PE
111652011-06-25 Paul Eggert <eggert@cs.ucla.edu>
11166
11167 Use gnulib's dup2 module instead of rolling our own.
11168 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
11169
11fdef7d 111702011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
11171
11172 * dispnew.c (scrolling_window): Before scrolling, turn off a
11173 mouse-highlight in the window being scrolled.
11174
cd3520a4
JB
111752011-06-24 Juanma Barranquero <lekktu@gmail.com>
11176
11177 Move DEFSYM to lisp.h and use everywhere.
11178
11179 * character.h (DEFSYM): Move declaration...
11180 * lisp.h (DEFSYM): ...here.
11181
11182 * gnutls.c:
11183 * minibuf.c:
11184 * w32menu.c:
11185 * w32proc.c:
11186 * w32select.c: Don't include character.h.
11187
11188 * alloc.c (syms_of_alloc):
11189 * buffer.c (syms_of_buffer):
11190 * bytecode.c (syms_of_bytecode):
11191 * callint.c (syms_of_callint):
11192 * casefiddle.c (syms_of_casefiddle):
11193 * casetab.c (init_casetab_once):
11194 * category.c (init_category_once, syms_of_category):
11195 * ccl.c (syms_of_ccl):
11196 * cmds.c (syms_of_cmds):
11197 * composite.c (syms_of_composite):
11198 * dbusbind.c (syms_of_dbusbind):
11199 * dired.c (syms_of_dired):
11200 * dispnew.c (syms_of_display):
11201 * doc.c (syms_of_doc):
11202 * editfns.c (syms_of_editfns):
11203 * emacs.c (syms_of_emacs):
11204 * eval.c (syms_of_eval):
11205 * fileio.c (syms_of_fileio):
11206 * fns.c (syms_of_fns):
11207 * frame.c (syms_of_frame):
11208 * fringe.c (syms_of_fringe):
11209 * insdel.c (syms_of_insdel):
11210 * keymap.c (syms_of_keymap):
11211 * lread.c (init_obarray, syms_of_lread):
11212 * macros.c (syms_of_macros):
11213 * msdos.c (syms_of_msdos):
11214 * print.c (syms_of_print):
11215 * process.c (syms_of_process):
11216 * search.c (syms_of_search):
11217 * sound.c (syms_of_sound):
11218 * syntax.c (init_syntax_once, syms_of_syntax):
11219 * terminal.c (syms_of_terminal):
11220 * textprop.c (syms_of_textprop):
11221 * undo.c (syms_of_undo):
11222 * w32.c (globals_of_w32):
11223 * window.c (syms_of_window):
11224 * xdisp.c (syms_of_xdisp):
11225 * xfaces.c (syms_of_xfaces):
11226 * xfns.c (syms_of_xfns):
11227 * xmenu.c (syms_of_xmenu):
11228 * xsettings.c (syms_of_xsettings):
11229 * xterm.c (syms_of_xterm): Use DEFSYM.
11230
4228cf16
TZ
112312011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
11232
cd3520a4 11233 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 11234
7fcccf1e
PE
112352011-06-23 Paul Eggert <eggert@cs.ucla.edu>
11236
7efb4e0e
PE
11237 Integer and buffer overflow fixes (Bug#8873).
11238
ff5844ad
PE
11239 * print.c (printchar, strout): Check for string overflow.
11240 (PRINTPREPARE, printchar, strout):
11241 Don't set size unless allocation succeeds.
11242
90532f02
PE
11243 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
11244 for sizes. Check for string overflow more accurately.
11245 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
11246
6d84508d
PE
11247 * macros.c: Integer and buffer overflow fixes.
11248 * keyboard.h (struct keyboard.kbd_macro_bufsize):
11249 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
11250 Use ptrdiff_t, not int, for sizes.
11251 Don't increment bufsize until after realloc succeeds.
11252 Check for size-calculation overflow.
11253 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
11254
437b2cb4
PE
11255 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
11256
8b9ac8b4
PE
11257 * lread.c: Integer overflow fixes.
11258 (read_integer): Radix is now EMACS_INT, not int,
11259 to improve quality of diagnostics for out-of-range radices.
11260 Calculate buffer size correctly for out-of-range radices.
11261 (read1): Check for integer overflow in radices, and in
11262 read-circle numbers.
82cb60d3
PE
11263 (read_escape): Avoid int overflow.
11264 (Fload, openp, read_buffer_size, read1)
11265 (substitute_object_recurse, read_vector, read_list, map_obarray):
11266 Use ptrdiff_t, not int, for sizes.
11267 (read1): Use EMACS_INT, not int, for sizes.
20270765 11268 Check for size overflow.
8b9ac8b4 11269
7fcccf1e
PE
11270 * image.c (cache_image): Check for size arithmetic overflow.
11271
bfbbd7e7
PE
11272 * lread.c: Integer overflow issues.
11273 (saved_doc_string_size, saved_doc_string_length)
11274 (prev_saved_doc_string_size, prev_saved_doc_string_length):
11275 Now ptrdiff_t, not int.
11276 (read1): Don't assume doc string length fits in int. Check for
11277 out-of-range doc string lengths.
11278 (read_list): Don't assume file position fits in int.
39019e54 11279 (read_escape): Check for hex character overflow.
bfbbd7e7 11280
4e323265
LL
112812011-06-22 Leo Liu <sdl.web@gmail.com>
11282
11283 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
11284 Move to minibuffer.el.
11285
85fece3e
PE
112862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11287
20b84ce9 11288 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
11289 The following patches are for when GLYPH_DEBUG && !XASSERT.
11290 * dispextern.h (trace_redisplay_p, dump_glyph_string):
11291 * dispnew.c (flush_stdout):
11292 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
11293 Mark as externally visible.
11294 * dispnew.c (check_window_matrix_pointers): Now static.
11295 * dispnew.c (window_to_frame_vpos):
11296 * xfns.c (unwind_create_frame):
11297 * xterm.c (x_check_font): Remove unused local.
11298 * scroll.c (CHECK_BOUNDS):
11299 * xfaces.c (cache_fache): Rename local to avoid shadowing.
11300 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
11301 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
11302 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
11303 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
11304 Now static.
11305 (debug_method_add): Use va_list and vsprintf rather than relying
11306 on undefined behavior with wrong number of arguments.
11307 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
11308 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
11309 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
11310 since we're not interested in debugging glyphs with old libraries.
11311 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
11312 GCC 4.6.0's static checking.
11313
0766b489
PE
113142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11315
31fd4b32
PE
11316 Integer overflow and signedness fixes (Bug#8873).
11317 A few related buffer overrun fixes, too.
11318
b79e8648
PE
11319 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
11320
0766b489
PE
11321 * dispextern.h (struct face.stipple):
11322 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
11323 (x_bitmap_mask, x_allocate_bitmap_record)
11324 (x_create_bitmap_from_data, x_create_bitmap_from_file)
11325 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
11326 (x_create_bitmap_from_xpm_data):
11327 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
11328 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
11329 (.bitmaps_last):
11330 * xfaces.c (load_pixmap):
11331 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
11332 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
11333 (.bitmaps_last, struct x_output.icon_bitmap):
11334 Use ptrdiff_t, not int, for bitmap indexes.
11335 (x_allocate_bitmap_record): Check for size overflow.
11336 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
11337
b081724f
PE
11338 Use ptrdiff_t, not int, for overlay counts.
11339 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
11340 * editfns.c (overlays_around, get_pos_property):
11341 * textprop.c (get_char_property_and_overlay):
11342 * xdisp.c (next_overlay_change, note_mouse_highlight):
11343 * xfaces.c (face_at_buffer_position):
21514da7
PE
11344 * buffer.c (OVERLAY_COUNT_MAX): New macro.
11345 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
11346 (Fnext_overlay_change, Fprevious_overlay_change)
11347 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 11348 Use ptrdiff_t, not int, for sizes.
21514da7 11349 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 11350
3de73e5e
PE
11351 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
11352
2606c57b
PE
11353 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
11354 (x_session_initialize): Do not assume string length fits in int.
11355
aaafe47a
PE
11356 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
11357 This is unlikely, but can occur if DPI is outlandish.
11358
2674ddc8 11359 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
11360 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
11361
28154962
PE
11362 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
11363 * xrdb.c (magic_file_p, search_magic_path):
11364 Omit last arg SUFFIX; it was always 0. All callers changed.
11365 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
11366
7de51af5
PE
11367 * xfont.c (xfont_match): Avoid need for strlen.
11368
25ed6cc3
PE
11369 * xfns.c: Don't assume strlen fits in int.
11370 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
11371
4eab31dd
PE
11372 * xdisp.c (message_log_check_duplicate): Return intmax_t,
11373 not unsigned long, as we prefer signed integers. All callers changed.
11374 Detect integer overflow in repeat count.
11375 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 11376 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 11377
171e2a58
PE
11378 * termcap.c: Don't assume sizes fit in int and never overflow.
11379 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11380 (gobble_line): Check for size-calculation overflow.
11381
ad39faca 11382 * minibuf.c (Fread_buffer):
6e5bb2dc 11383 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11384 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11385 Don't assume string length fits in int.
11386
52c61c22 11387 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11388 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11389
b5b8c9e5
PE
11390 * font.c: Don't assume string length fits in int.
11391 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11392 Use ptrdiff_t, not int.
ccd6111c
PE
11393 (font_intern_prop): Don't assume string length fits in int.
11394 Don't assume integer property fits in fixnum.
11395 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11396
882f0d81 11397 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11398 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11399 Reformulate so as not to need the command string.
11400 Invoke gzip -cd rather than gunzip, as it's more portable.
11401 (lock_info_type, lock_file_1, lock_file):
11402 Don't assume pid_t and time_t fit in unsigned long.
11403 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11404 (current_lock_owner): Prefer signed type for sizes.
11405 Use memcpy, not strncpy, where memcpy is what is really wanted.
11406 Don't assume (via atoi) that time_t and pid_t fit in int.
11407 Check for time_t and/or pid_t out of range, e.g., via a network share.
11408 Don't alloca where an auto var works fine.
11409
93f4cf88
PE
11410 * fileio.c: Fix some integer overflow issues.
11411 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11412 Don't assume string length fits in int.
11413 (directory_file_name): Don't assume string length fits in long.
11414 (make_temp_name): Don't assume pid fits in int, or that its print
11415 length is less than 20.
11416
f3e92b69
PE
11417 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11418
1bfdaf10
PE
11419 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11420
35016e9a
PE
11421 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11422
3d1e65a1
PE
11423 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11424 We prefer signed integers, even for size calculations.
11425
0b963a93
PE
11426 * emacs.c: Don't assume string length fits in 'int'.
11427 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11428 (main): Don't invoke strlen when not needed.
11429
573f4b54
PE
11430 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11431 (XD_DEBUG_MESSAGE): Don't waste a byte.
11432
989f33ba
PE
11433 * callproc.c (getenv_internal_1, getenv_internal)
11434 (Fgetenv_internal):
965d34eb
PE
11435 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11436
e4d29b33
PE
11437 * lread.c (invalid_syntax): Omit length argument.
11438 All uses changed. This doesn't fix a bug, but it simplifies the
11439 code away from its former Hollerith-constant appearance, and it's
11440 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11441 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11442
eb49b136
PE
11443 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11444 This didn't break anything, but it didn't help either.
11445 It's confusing to put a bogus integer in a place where the actual
11446 value does not matter.
9f62aeb1 11447 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11448 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11449
15375a22
PE
11450 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11451 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11452 implementation.
b61cc01c
PE
11453 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11454 We prefer signed types, and the value cannot exceed the EMACS_INT
11455 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11456 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11457 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11458 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11459
53b2623d
PE
11460 * indent.c (sane_tab_width): New function.
11461 (current_column, scan_for_column, Findent_to, position_indentation)
11462 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11463 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11464
51cab52b 11465 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11466
f2ed8a70
PE
11467 * lisp.h (lint_assume): New macro.
11468 * composite.c (composition_gstring_put_cache):
11469 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11470
abe80cc6
PE
11471 * editfns.c, insdel.c:
11472 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11473
b02c740e
PE
11474 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11475
ebc96716
PE
11476 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11477
b4e50fa0 11478 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11479 Use much-faster test for byte-length change.
311d5d7c 11480 Don't assume string byte-length fits in 'int'.
a4cf38e4 11481 Check that character arg fits in 'int'.
85461888 11482 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11483
c0c1ee9f
PE
11484 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11485
a498d7f4
PE
11486 * fns.c (concat): Catch string overflow earlier.
11487 Do not rely on integer wraparound.
11488
51cab52b
PE
11489 * dispextern.h (struct it.overlay_strings_charpos)
11490 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11491 * xdisp.c (forward_to_next_line_start)
11492 (back_to_previous_visible_line_start)
11493 (reseat_at_next_visible_line_start, next_element_from_buffer):
11494 Don't arbitrarily truncate the value of 'selective' to int.
11495
76031fad
PE
11496 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11497
5eb55db9
PE
11498 * composite.c: Don't truncate sizes to 'int'.
11499 (composition_gstring_p, composition_reseat_it)
11500 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11501 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11502 not EMACS_UINT, for indexes.
5eb55db9 11503
0703a717
PE
11504 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11505
d6202519
PE
11506 * buffer.c: Include <verify.h>.
11507 (struct sortvec.priority, struct sortstr.priority):
8961a454 11508 Now EMACS_INT, not int.
c20998a7 11509 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11510 (struct sortstr.size, record_overlay_string)
11511 (struct sortstrlist.size, struct sortlist.used):
11512 Don't truncate size to int.
11513 (record_overlay_string): Check for size-calculation overflow.
d6202519 11514 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11515
d5a19415
JM
115162011-06-22 Jim Meyering <meyering@redhat.com>
11517
029529ac 11518 Don't leak an XBM-image-sized buffer
d5a19415
JM
11519 * image.c (xbm_load): Free the image buffer after using it.
11520
a9041e6c
PE
115212011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11522
11523 Port to Sun C.
11524 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11525 that Sun C diagnosed.
11526 * fns.c (secure_hash): Fix pointer signedness issue.
11527 * intervals.c (static_offset_intervals): New function.
11528 (offset_intervals): Use it.
11529
7f3f739f
LL
115302011-06-21 Leo Liu <sdl.web@gmail.com>
11531
11532 * deps.mk (fns.o):
11533 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11534 sha512.h.
11535
11536 * fns.c (secure_hash): Rename from crypto_hash_function and change
11537 the first arg to accept symbols.
5b66d427 11538 (Fsecure_hash): New primitive.
7f3f739f
LL
11539 (syms_of_fns): New symbols.
11540
76147d94
DD
115412011-06-20 Deniz Dogan <deniz@dogan.se>
11542
11543 * process.c (Fset_process_buffer): Clarify return value in
11544 docstring.
11545
7d7d0045
CY
115462011-06-18 Chong Yidong <cyd@stupidchicken.com>
11547
11548 * dispnew.c (add_window_display_history): Use BVAR.
11549
11550 * xdisp.c (debug_method_add): Use BVAR.
11551 (check_window_end, dump_glyph_matrix, dump_glyph)
11552 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11553
11554 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11555 Likewise.
11556
11557 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11558 check till after the cache is created in init_frame_faces.
11559
ff2bc410
SM
115602011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11561
11562 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11563
28177add
PE
115642011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11565
dd3482fe
PE
11566 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11567 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11568 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11569
393d71f3 11570 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
11571 * fileio.c (Finsert_file_contents):
11572 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
11573 Remove the old (too-loose) buffer overflow checks.
11574 They weren't needed, since make_gap checks for buffer overflow.
11575 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
11576 The old code merely checked for Emacs fixnum overflow, and relied
11577 on undefined (wraparound) behavior. The new code avoids undefined
11578 behavior, and also checks for ptrdiff_t and/or size_t overflow.
11579
2e6813b0 11580 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
11581 Tune. Don't use wider integers than needed. Don't use alloca.
11582 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 11583
599a9e4f
PE
11584 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
11585
99561444
PE
11586 * insdel.c, lisp.h (buffer_overflow): New function.
11587 (insert_from_buffer_1, replace_range, replace_range_2):
11588 * insdel.c (make_gap_larger):
11589 * editfns.c (Finsert_char):
11590 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
11591
28177add
PE
11592 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
11593
e69dafad
PE
115942011-06-15 Paul Eggert <eggert@cs.ucla.edu>
11595
4baa020d 11596 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 11597
b1c46f02
PE
11598 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11599 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11600
e69dafad
PE
11601 * fileio.c: Don't assume EMACS_INT fits in off_t.
11602 (emacs_lseek): New static function.
11603 (Finsert_file_contents, Fwrite_region): Use it.
11604 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11605
566684ea
PE
11606 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11607
e6966cd6
PE
11608 * fns.c: Don't overflow int when computing a list length.
11609 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11610 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11611 truncation on 64-bit hosts. Check for QUIT every
11612 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11613 faster and is responsive enough.
11614 (Flength): Report an error instead of overflowing an integer.
11615 (Fsafe_length): Return a float if the value is not representable
11616 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11617 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11618 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11619
dd0b0efb
PE
11620 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11621 (header_size, word_size): New constants.
11622 (allocate_vectorlike): Don't check size overflow here.
11623 (allocate_vector): Check it here instead, since this is the only
11624 caller of allocate_vectorlike that could cause overflow.
11625 Check that the new vector's length is representable as a fixnum.
11626
86fe5cfe
PE
11627 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11628 The previous code was bogus. For example, next_almost_prime (32)
11629 returned 39, which is undesirable as it is a multiple of 3; and
11630 next_almost_prime (24) returned 25, which is a multiple of 5 so
11631 why was the code bothering to check for multiples of 7?
11632
80e88859
PE
11633 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11634
4a2f0ad6
PE
11635 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11636
f66c7cf8
PE
11637 Variadic C functions now count arguments with ptrdiff_t.
11638 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11639 Back then I didn't know that the Emacs coding style prefers signed int.
11640 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11641 were being counted with int, which may truncate counts on 64-bit
11642 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11643 * lisp.h (struct Lisp_Subr.function.aMANY)
11644 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11645 Arg counts are now ptrdiff_t, not size_t.
11646 All variadic functions and their callers changed accordingly.
11647 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11648 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11649 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11650 * callint.c (Fcall_interactively): Check arg count for overflow,
11651 to avoid potential buffer overrun. Use signed char, not 'int',
11652 for 'varies' array, so that we needn't bother to check its size
11653 calculation for overflow.
11654 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11655 * eval.c (apply_lambda):
11656 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11657 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11658 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11659
a1759b76
PE
11660 * callint.c (Fcall_interactively): Don't use index var as event count.
11661
d96be9fc
PE
11662 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11663 * mem-limits.h (SIZE): Remove; no longer used.
11664
a690a978 11665 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11666
578c21e6
PE
11667 Remove unnecessary casts.
11668 * xterm.c (x_term_init):
11669 * xfns.c (x_set_border_pixel):
11670 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11671 These aren't needed now that we assume ANSI C.
11672
96f53c6c
PE
11673 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11674 It's more likely to cause problems (due to unsigned overflow)
11675 than to cure them.
11676
83c77d31
PE
11677 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11678
ee2079f1
PE
11679 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11680
6da65536
PE
11681 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11682
7147c4a4
PE
11683 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11684
193e32d9
PE
11685 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11686
e5533da6
PE
11687 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11688
9910e595
PE
11689 GLYPH_CODE_FACE returns EMACS_INT, not int.
11690 * dispextern.h (merge_faces):
11691 * xfaces.c (merge_faces):
01103c44
PE
11692 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11693 Don't assume EMACS_INT fits in int.
9910e595 11694
2638320e
PE
11695 * character.h (CHAR_VALID_P): Remove unused parameter.
11696 * fontset.c, lisp.h, xdisp.c: All uses changed.
11697
045eb8d9
PE
11698 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11699
c1f134b5
PE
11700 * fns.c (concat): Minor tuning based on overflow analysis.
11701 This doesn't fix any bugs. Use int to hold character, instead
11702 of constantly refetching from Emacs object. Use XFASTINT, not
11703 XINT, for value known to be a character. Don't bother comparing
11704 a single byte to 0400, as it's always less.
11705
395fcb93 11706 * floatfns.c (Fexpt):
327eeec8
PE
11707 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11708
abbd3d23
PE
11709 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11710 for characters.
11711
684a03ef
PE
11712 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11713
0fed43f3
PE
11714 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11715 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11716 incorrectly succeed when S was a string, because 4294967386 was
11717 truncated before it was used.
11718
8fd02eb7
PE
11719 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11720 Otherwise, an out-of-range integer could cause undefined behavior
11721 on a 64-bit host.
11722
f8c86b69
PE
11723 * composite.c: Use int, not EMACS_INT, for characters.
11724 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11725 EMACS_INT, for values that are known to be in character range.
11726 This doesn't fix any bugs but is the usual style inside Emacs and
11727 may generate better code on 32-bit machines.
11728
34206dd2
PE
11729 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11730 This is for reasons similar to the recent CHAR_STRING fix.
11731 * charset.c (Fencode_char): Check that character arg is actually
11732 a character. Pass an int to ENCODE_CHAR.
11733 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11734 wider than 'int', as a compile-time check to prevent future regressions
11735 in this area.
11736
c5958d4c 11737 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11738
11739 Make sure a 64-bit char is never passed to CHAR_STRING.
11740 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11741 by silently ignoring the top 32 bits, allowing some values
11742 that were far too large to be valid characters.
11743 * character.h: Include <verify.h>.
11744 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11745 arguments are no wider than unsigned, as a compile-time check
11746 to prevent future regressions in this area.
11747 * data.c (Faset):
01103c44 11748 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11749 (Fsubst_char_in_region):
11750 * fns.c (concat):
11751 * xdisp.c (decode_mode_spec_coding):
11752 Adjust to CHAR_STRING's new requirement.
11753 * editfns.c (Finsert_char, Fsubst_char_in_region):
11754 * fns.c (concat): Check that character args are actually
11755 characters. Without this test, these functions did the wrong
11756 thing with wildly out-of-range values on 64-bit hosts.
11757
d37ca623
PE
11758 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11759 These casts should not be needed on 32-bit hosts, either.
11760 * keyboard.c (read_char):
11761 * lread.c (Fload): Remove casts to unsigned.
11762
ea204efb
PE
11763 * lisp.h (UNSIGNED_CMP): New macro.
11764 This fixes comparison bugs on 64-bit hosts.
11765 (ASCII_CHAR_P): Use it.
11766 * casefiddle.c (casify_object):
01103c44 11767 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11768 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11769 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11770 * dispextern.h (FACE_FROM_ID):
11771 * keyboard.c (read_char): Use UNSIGNED_CMP.
11772
41cb286c
PE
11773 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11774 not to EMACS_INT, to avoid GCC warning.
11775
4a1b9832
PE
11776 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11777
55daad71
PE
11778 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11779 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11780 isn't needed on 32-bit machines.
8f95c75c 11781
01103c44
PE
11782 * buffer.c (Fgenerate_new_buffer_name):
11783 Use EMACS_INT for count, not int.
0ceccced 11784 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11785
11786 * data.c (Qcompiled_function): Now static.
11787
c6f072e7
PE
11788 * window.c (window_body_lines): Now static.
11789
20ce5912
PE
11790 * image.c (gif_load): Rename local to avoid shadowing.
11791
9c4c5f81
PE
11792 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11793 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11794 * alloc.c (make_save_value): Integer argument is now of type
11795 ptrdiff_t, not int.
11796 (mark_object): Use ptrdiff_t, not int.
11797 * lisp.h (pD): New macro.
11798 * print.c (print_object): Use it.
11799
c0c5c8ae
PE
11800 * alloc.c: Use EMACS_INT, not int, to count objects.
11801 (total_conses, total_markers, total_symbols, total_vector_size)
11802 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11803 (total_free_floats, total_floats, total_free_intervals)
11804 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11805 Now EMACS_INT, not int. All uses changed.
11806 (Fgarbage_collect): Compute overall total using a double, so that
11807 integer overflow is less likely to be a problem. Check for overflow
11808 when converting back to an integer.
5a25e253
PE
11809 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11810 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11811 These were 'int' variables that could overflow on 64-bit hosts;
11812 they were never used, so remove them instead of repairing them.
211a0b2a 11813 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11814 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11815 Previously, this ceilinged at INT_MAX, but that doesn't work on
11816 64-bit machines.
e46bb31a 11817 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11818
c78baabf 11819 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11820 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11821 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11822 when a (possibly-narrower) signed value would do just as well.
11823 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11824
c9d624c6
PE
11825 * alloc.c: Catch some string size overflows that we were missing.
11826 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11827 for convenience in STRING_BYTES_MAX.
11828 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11829 The definition here is exact; the one in lisp.h was approximate.
11830 (allocate_string_data): Check for string overflow. This catches
11831 some instances we weren't catching before. Also, it catches
11832 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11833 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11834 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11835
c9d624c6
PE
11836 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11837 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11838 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11839
353032ce
PE
11840 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11841
2bccce07
PE
11842 * alloc.c (Fmake_string): Check for out-of-range init.
11843
0ac30604
SM
118442011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11845
11846 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11847
c195f2de
JD
118482011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11849
11850 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11851 xg_get_default_scrollbar_width.
11852
11853 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11854 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11855 (style_changed_cb): Call update_theme_scrollbar_width and call
11856 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11857 all frames (Bug#8505).
11858 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11859 Call gtk_window_set_resizable if HAVE_GTK3.
11860 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11861 and height if HAVE_GTK3 (Bug#8505).
11862 (scroll_bar_width_for_theme): New variable.
11863 (update_theme_scrollbar_width): New function.
11864 (xg_get_default_scrollbar_width): Move code to
11865 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11866 (xg_initialize): Call update_theme_scrollbar_width.
11867
11868 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11869
11870 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11871
e10ac9f1
MR
118722011-06-12 Martin Rudalics <rudalics@gmx.at>
11873
11874 * frame.c (make_frame): Call other_buffer_safely instead of
11875 other_buffer.
11876
11877 * window.c (temp_output_buffer_show): Call display_buffer with
11878 second argument Vtemp_buffer_show_specifiers and reset latter
11879 immediately after the call.
11880 (Vtemp_buffer_show_specifiers): New variable.
11881 (auto_window_vscroll_p, next_screen_context_lines)
11882 (Vscroll_preserve_screen_position): Remove leading asterisks from
11883 doc-strings.
11884
2d3c217e 118852011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11886
7b7f97e8 11887 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11888 * buffer.c (Qclone_number): Remove for now, as it's unused.
11889 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11890 (record_buffer): Remove unused local.
11891 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11892 (set_frame_buffer_list): Remove; unused.
11893 * frame.h (other_visible_frames): Remove decl.
11894 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11895 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11896 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11897 if HAVE_GPM.
11898 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11899 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11900 Define only if HAVE_GPM.
11901 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11902 (update_hints_inhibit): Remove; never set. All uses removed.
11903 * widgetprv.h (emacsFrameClassRec): Remove decl.
11904 * window.c (delete_deletable_window): Now returns void, since it
11905 wasn't returning anything.
11906 (compare_window_configurations): Remove unused locals.
11907 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11908 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11909 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11910 the same widths as pointers. This follows up on the 2011-05-06 patch.
11911 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11912 * xterm.h: Likewise.
11913 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11914
1384b89e
JB
119152011-06-12 Juanma Barranquero <lekktu@gmail.com>
11916
11917 * makefile.w32-in: Update dependencies.
11918 (LISP_H): Add lib/intprops.h.
11919
1100a63c
CY
119202011-06-11 Chong Yidong <cyd@stupidchicken.com>
11921
11922 * image.c (gif_load): Add animation frame delay to the metadata.
11923 (syms_of_image): Use DEFSYM. New symbol `delay'.
11924
6198ccd0
MR
119252011-06-11 Martin Rudalics <rudalics@gmx.at>
11926
11927 * window.c (delete_deletable_window): Re-add.
11928 (Fset_window_configuration): Rewrite to handle dead buffers and
11929 consequently deletable windows.
11930 (window_tree, Fwindow_tree): Remove. Supply functionality in
11931 window.el.
11932 (compare_window_configurations): Simplify code.
11933
b6e3633c
AS
119342011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11935
1ab0dee5
AS
11936 * image.c (imagemagick_load_image): Fix type mismatch.
11937 (Fimagemagick_types): Likewise.
11938
b6e3633c
AS
11939 * window.h (replace_buffer_in_windows): Declare.
11940
9397e56f
MR
119412011-06-11 Martin Rudalics <rudalics@gmx.at>
11942
11943 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11944 Qclone_number. Remove external declaration of Qdelete_window.
11945 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11946 code.
640c8776
SM
11947 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11948 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11949 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11950 buffer list implementation.
11951 (other_buffer_safely): New function.
11952 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11953 calls to replace_buffer_in_windows and
11954 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11955 if allowed.
11956 (record_buffer): Inhibit quitting and rewrite using quittable
11957 functions. Run Qbuffer_list_update_hook if allowed.
11958 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11959 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11960 Move switch-to-buffer to window.el.
9397e56f
MR
11961 (bury-buffer): Move to window.el.
11962 (Vbuffer_list_update_hook): New variable.
11963
11964 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11965 section.
11966
11967 * window.h (resize_frame_windows): Move up in code.
11968 (Fwindow_frame): Remove EXFUN.
11969 (replace_buffer_in_all_windows): Remove prototype.
11970 (replace_buffer_in_windows_safely): Add prototype.
11971
11972 * window.c: Declare Qdelete_window static again. Move down
11973 declaration of select_count.
11974 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11975 (Fother_window): Move to window.el.
11976 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11977 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11978 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11979 window.el.
11980 (replace_buffer_in_windows): Implement by calling
11981 Qreplace_buffer_in_windows.
11982 (replace_buffer_in_all_windows): Remove with some functionality
11983 moved into replace_buffer_in_windows_safely.
11984 (replace_buffer_in_windows_safely): New function.
11985 (select_window_norecord, select_frame_norecord): Move in front
11986 of run_window_configuration_change_hook. Remove now obsolete
11987 declarations.
640c8776
SM
11988 (Fset_window_buffer): Rewrite doc-string.
11989 Call Qrecord_window_buffer.
9397e56f
MR
11990 (keys_of_window): Move binding for other-window to window.el.
11991
b50691aa
CY
119922011-06-11 Chong Yidong <cyd@stupidchicken.com>
11993
11994 * dispextern.h (struct image): Replace data member, whose int_val
11995 and ptr_val fields were not used by anything, with a single
11996 lisp_val object.
11997
11998 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11999 (gif_clear_image, gif_load, imagemagick_load_image)
12000 (gs_clear_image, gs_load): Callers changed.
12001
3f754b86
PE
120022011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12003
cca69397
PE
12004 * buffer.h: Include <time.h>, for time_t.
12005 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
12006
109e28d0
PE
12007 Fix minor problems found by static checking.
12008
60737f02
PE
12009 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
12010
4b66faf3
PE
12011 Make identifiers static if they are not used in other modules.
12012 * data.c (Qcompiled_function, Qframe, Qvector):
12013 * image.c (QimageMagick, Qsvg):
12014 * minibuf.c (Qmetadata):
12015 * window.c (resize_window_check, resize_root_window): Now static.
12016 * window.h (resize_window_check, resize_root_window): Remove decls.
12017
109e28d0
PE
12018 * window.c (window_deletion_count, delete_deletable_window):
12019 Remove; unused.
46a4ce9e
PE
12020 (window_body_lines): Now static.
12021 (Fdelete_other_windows_internal): Mark vars as initialized.
12022 Make sure 'resize_failed' is initialized.
12023 (run_window_configuration_change_hook): Rename local to avoid shadowing.
12024 (resize_window_apply): Remove unused local.
12025 * window.h (delete_deletable_window): Remove decl.
12026
109e28d0 12027 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
12028 (imagemagick_load_image): Fix pointer signedness problem by changing
12029 last arg from unsigned char * to char *. All uses changed.
12030 Also, fix a local for similar reasons.
12031 Remove unused locals. Remove locals to avoid shadowing.
12032 (fn_rsvg_handle_free): Remove; unused.
12033 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 12034 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 12035
3f754b86
PE
12036 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
12037
2547adb1
CY
120382011-06-10 Chong Yidong <cyd@stupidchicken.com>
12039
12040 * image.c (gif_load): Fix omitted cast error introduced by
12041 2011-06-06 change.
12042
2c8e37d4
MR
120432011-06-10 Martin Rudalics <rudalics@gmx.at>
12044
12045 * window.h (resize_proportionally, orig_total_lines)
12046 (orig_top_line): Remove from window structure.
12047 (set_window_height, set_window_width, change_window_heights)
12048 (Fdelete_window): Remove prototypes.
12049 (resize_frame_windows): Remove duplicate declaration.
12050
440a42e3
EZ
120512011-06-10 Eli Zaretskii <eliz@gnu.org>
12052
12053 * window.h (resize_frame_windows, resize_window_check)
12054 (delete_deletable_window, resize_root_window)
12055 (resize_frame_windows): Declare prototypes.
12056
12057 * window.c (resize_window_apply): Make definition be "static" to
12058 match the prototype.
12059
562dd5e9
MR
120602011-06-10 Martin Rudalics <rudalics@gmx.at>
12061
12062 * window.c: Remove declarations of Qwindow_size_fixed,
12063 window_min_size_1, window_min_size_2, window_min_size,
12064 size_window, window_fixed_size_p, enlarge_window, delete_window.
12065 Remove static from declaration of Qdelete_window, it's
12066 temporarily needed by Fbury_buffer.
12067 (replace_window): Don't assign orig_top_line and
12068 orig_total_lines.
12069 (Fdelete_window, delete_window): Remove. Window deletion is
12070 handled by window.el.
640c8776
SM
12071 (window_loop): Remove DELETE_OTHER_WINDOWS case.
12072 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
12073 (Fdelete_other_windows): Remove. Deleting other windows is
12074 handled by window.el.
12075 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
12076 handled in window.el.
12077 (window_min_size_2, window_min_size_1, window_min_size): Remove.
12078 Window minimum sizes are handled in window.el.
12079 (shrink_windows, size_window, set_window_height)
12080 (set_window_width, change_window_heights, window_height)
12081 (window_width, CURBEG, CURSIZE, enlarge_window)
12082 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
12083 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
12084 handled in window.el.
12085 (make_dummy_parent): Rename to make_parent_window and give it a
12086 second argument horflag.
12087 (make_window): Don't set resize_proportionally any more.
12088 (Fsplit_window): Remove. Windows are split in window.el.
12089 (save_restore_action, save_restore_orig_size)
12090 (shrink_window_lowest_first, save_restore_orig_size): Remove.
12091 Resize mini windows in window.el.
12092 (grow_mini_window, shrink_mini_window): Implement by calling
12093 Qresize_root_window_vertically, resize_window_check and
12094 resize_window_apply.
640c8776
SM
12095 (saved_window, Fset_window_configuration, save_window_save):
12096 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
12097 resize_proportionally.
12098 (window_min_height, window_min_width): Move to window.el.
12099 (keys_of_window): Move bindings for delete-other-windows,
12100 split-window, delete-window and enlarge-window to window.el.
12101
12102 * buffer.c: Temporarily extern Qdelete_window.
12103 (Fbury_buffer): Temporarily call Qdelete_window instead of
12104 Fdelete_window (Fbury_buffer will move to window.el soon).
12105
12106 * frame.c (set_menu_bar_lines_1): Remove code handling
12107 orig_top_line and orig_total_lines.
12108
12109 * dispnew.c (adjust_frame_glyphs_initially): Don't use
12110 set_window_height but set heights directly.
12111 (change_frame_size_1): Use resize_frame_windows.
12112
12113 * xdisp.c (init_xdisp): Don't use set_window_height but set
12114 heights directly.
12115
640c8776
SM
12116 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
12117 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
12118 run_window_configuration_change_hook.
12119
12120 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
12121 instead of change_window_heights and run
12122 run_window_configuration_change_hook.
12123
1a13852e
MR
121242011-06-09 Martin Rudalics <rudalics@gmx.at>
12125
12126 * window.c (replace_window): Rename second argument REPLACEMENT to
12127 NEW. New third argument SETFLAG. Rewrite.
12128 (delete_window, make_dummy_parent): Call replace_window with
12129 third argument 1.
12130 (window_list_1): Move down in code.
12131 (run_window_configuration_change_hook): Move set_buffer part
12132 before select_frame_norecord part in order to unwind correctly.
12133 Rename count1 to count.
12134 (recombine_windows, delete_deletable_window, resize_root_window)
12135 (Fdelete_other_windows_internal)
12136 (Frun_window_configuration_change_hook, make_parent_window)
12137 (resize_window_check, resize_window_apply, Fresize_window_apply)
12138 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
12139 (Fdelete_window_internal, Fresize_mini_window_internal):
12140 New functions.
1a13852e
MR
12141 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
12142
f3d1777e
MR
121432011-06-08 Martin Rudalics <rudalics@gmx.at>
12144
496e208e
MR
12145 * window.h (window): Add some new members to window structure -
12146 normal_lines, normal_cols, new_total, new_normal, clone_number,
12147 splits, nest, prev_buffers, next_buffers.
12148 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 12149 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 12150
f3d1777e
MR
12151 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
12152 Remove.
496e208e
MR
12153 (make_dummy_parent): Set new members of windows structure.
12154 (make_window): Move down in code. Handle new members of window
12155 structure.
12156 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
12157 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
12158 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
12159 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
12160 (Fset_window_next_buffers, Fset_window_clone_number):
12161 New functions.
496e208e
MR
12162 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
12163 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
12164 Doc-string fixes.
12165 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
12166 Argument WINDOW can be now internal window too.
12167 (Fwindow_use_time): Move up in code.
12168 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
12169 Rewrite doc-string.
12170 (Fset_window_configuration, saved_window)
12171 (Fcurrent_window_configuration, save_window_save): Handle new
12172 members of window structure.
b9e809c2
MR
12173 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
12174 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
12175 (syms_of_window): New Lisp objects Qrecord_window_buffer,
12176 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
12177 Qget_mru_window, Qresize_root_window,
12178 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
12179 Qauto_buffer_name; staticpro them.
f3d1777e 12180
abde8f8c
MR
121812011-06-07 Martin Rudalics <rudalics@gmx.at>
12182
12183 * window.c (Fwindow_total_size, Fwindow_left_column)
12184 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
12185 (Fwindow_list_1): New functions.
12186 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
12187 (Fwindow_width, Fscroll_left, Fscroll_right):
12188 Use window_body_cols instead of window_box_text_cols.
12189 (delete_window, Fset_window_configuration):
12190 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
12191 (delete_all_subwindows): Take a window as argument and not a
12192 structure. Rewrite.
190b47e6
MR
12193 (window_loop): Remove handling of GET_LRU_WINDOW and
12194 GET_LARGEST_WINDOW.
12195 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
12196
12197 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
12198 window_box_text_cols. delete_all_subwindows now takes a
12199 Lisp_Object as argument.
abde8f8c 12200
640c8776
SM
12201 * indent.c (compute_motion, Fcompute_motion):
12202 Use window_body_cols instead of window_box_text_cols.
abde8f8c 12203
fa8a67e6
MR
12204 * frame.c (delete_frame): Call delete_all_subwindows with root
12205 window as argument.
12206
a54e3482
DC
122072011-06-07 Daniel Colascione <dan.colascione@gmail.com>
12208
12209 * fns.c (Fputhash): Document return value.
12210
60002bf5
CY
122112011-06-06 Chong Yidong <cyd@stupidchicken.com>
12212
12213 * image.c (gif_load): Implement gif89a spec "no disposal" method.
12214
0c671da6 122152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 12216
b862a52a 12217 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 12218
be44ca6c
PE
12219 Check for overflow when converting integer to cons and back.
12220 * charset.c (Fdefine_charset_internal, Fdecode_char):
12221 Use cons_to_unsigned to catch overflow.
12222 (Fencode_char): Use INTEGER_TO_CONS.
12223 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
12224 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
12225 * data.c (long_to_cons, cons_to_long): Remove.
12226 (cons_to_unsigned, cons_to_signed): New functions.
12227 These signal an error for invalid or out-of-range values.
12228 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
12229 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
12230 * font.c (Ffont_variation_glyphs):
12231 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
12232 * lisp.h: Include <intprops.h>.
12233 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
12234 (cons_to_signed, cons_to_unsigned): New decls.
12235 (long_to_cons, cons_to_long): Remove decls.
12236 * undo.c (record_first_change): Use INTEGER_TO_CONS.
12237 (Fprimitive_undo): Use CONS_TO_INTEGER.
12238 * xfns.c (Fx_window_property): Likewise.
12239 * xselect.c: Include <limits.h>.
12240 (x_own_selection, selection_data_to_lisp_data):
12241 Use INTEGER_TO_CONS.
12242 (x_handle_selection_request, x_handle_selection_clear)
12243 (x_get_foreign_selection, Fx_disown_selection_internal)
12244 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
12245 (lisp_data_to_selection_data): Use cons_to_unsigned.
12246 (x_fill_property_data): Use cons_to_signed.
12247 Report values out of range.
12248
d1f3d2af
PE
12249 Check for buffer and string overflow more precisely.
12250 * buffer.h (BUF_BYTES_MAX): New macro.
12251 * lisp.h (STRING_BYTES_MAX): New macro.
12252 * alloc.c (Fmake_string):
12253 * character.c (string_escape_byte8):
12254 * coding.c (coding_alloc_by_realloc):
12255 * doprnt.c (doprnt):
12256 * editfns.c (Fformat):
12257 * eval.c (verror):
12258 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
12259 since they may not be the same number.
12260 * editfns.c (Finsert_char):
12261 * fileio.c (Finsert_file_contents):
12262 Likewise for BUF_BYTES_MAX.
12263
dd52fcea
PE
12264 * image.c: Use ptrdiff_t, not int, for sizes.
12265 (slurp_file): Switch from int to ptrdiff_t.
12266 All uses changed.
12267 (slurp_file): Check that file size fits in both size_t (for
12268 malloc) and ptrdiff_t (for sanity and safety).
12269
7f9bbdbb
PE
12270 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
12271 if b->modtime has its maximal value.
12272
dfe18f82
PE
12273 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
12274
84acfcf0
PE
12275 Don't assume time_t can fit into int.
12276 * buffer.h (struct buffer.modtime): Now time_t, not int.
12277 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
12278 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
12279
ccd9a01a
PE
12280 Minor fixes for signed vs unsigned integers.
12281 * character.h (MAYBE_UNIFY_CHAR):
12282 * charset.c (maybe_unify_char):
12283 * keyboard.c (read_char, reorder_modifiers):
12284 XINT -> XFASTINT, since the integer must be nonnegative.
12285 * ftfont.c (ftfont_spec_pattern):
12286 * keymap.c (access_keymap, silly_event_symbol_error):
12287 XUINT -> XFASTINT, since the integer must be nonnegative.
12288 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12289 since it makes no difference and we prefer signed.
12290 * keyboard.c (record_char): Use XUINT when all the neighbors do.
12291 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
12292 nonnegative.
12293
d6d100dd
SM
122942011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
12295
12296 * window.h (Fwindow_frame): Declare.
12297
2b6148e4
PE
122982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12299
12300 * alloc.c: Simplify handling of large-request failures (Bug#8800).
12301 (SPARE_MEMORY): Always define.
12302 (LARGE_REQUEST): Remove.
12303 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
12304
f230ecc9
MR
123052011-06-06 Martin Rudalics <rudalics@gmx.at>
12306
727e958e
MR
12307 * lisp.h: Move EXFUNS for Fframe_root_window,
12308 Fframe_first_window and Fset_frame_selected_window to window.h.
12309
12310 * window.h: Move EXFUNS for Fframe_root_window,
12311 Fframe_first_window and Fset_frame_selected_window here from
12312 lisp.h.
12313
12314 * frame.c (Fwindow_frame, Fframe_first_window)
12315 (Fframe_root_window, Fframe_selected_window)
12316 (Fset_frame_selected_window): Move to window.c.
12317 (Factive_minibuffer_window): Move to minibuf.c.
12318 (Fother_visible_frames_p): New function.
12319
12320 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
12321
f230ecc9
MR
12322 * window.c (decode_window, decode_any_window): Move up in code.
12323 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
12324 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
12325 (Fwindow_buffer): Move up and rewrite doc-string.
12326 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
12327 (Fwindow_prev): New functions.
727e958e
MR
12328 (Fwindow_frame): Move here from frame.c. Accept any window as
12329 argument.
12330 (Fframe_root_window, Fframe_first_window)
12331 (Fframe_selected_window): Move here from frame.c. Accept frame
12332 or arbitrary window as argument. Update doc-strings.
12333 (Fminibuffer_window): Move up in code.
12334 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
12335 (Fset_frame_selected_window): Move here from frame.c.
12336 Marginal rewrite.
727e958e
MR
12337 (Fselected_window, select_window, Fselect_window): Move up in
12338 code. Minor doc-string fixes.
f230ecc9 12339
4d09bcf6
PE
123402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12341
12342 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
12343 Do not assume that spare memory exists; that assumption is valid
12344 only if SYSTEM_MALLOC.
12345 (LARGE_REQUEST): New macro, so that the issue of large requests
12346 is separated from the issue of spare memory.
12347
810928a2
AS
123482011-06-05 Andreas Schwab <schwab@linux-m68k.org>
12349
172418ad
AS
12350 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
12351 format. (Bug#8806)
12352
43f862f7
AS
12353 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
12354
810928a2
AS
12355 * xfns.c (x_set_scroll_bar_default_width): Move declarations
12356 before statements.
12357
a059fe24
JD
123582011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12359
12360 * gtkutil.c (xg_get_default_scrollbar_width): New function.
12361
12362 * gtkutil.h: Declare xg_get_default_scrollbar_width.
12363
12364 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
12365 min width by calling x_set_scroll_bar_default_width (Bug#8505).
12366
989bf368
JB
123672011-06-05 Juanma Barranquero <lekktu@gmail.com>
12368
12369 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
12370
4b80f674
CY
123712011-06-04 Chong Yidong <cyd@stupidchicken.com>
12372
12373 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
12374 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
12375 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
12376 New error handlers.
4b80f674
CY
12377 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12378 Obey Vx_select_enable_clipboard_manager. Catch errors in
12379 x_clipboard_manager_save (Bug#8779).
12380 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12381 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12382
99a33b77 123832011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12384
12385 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12386
99a33b77 123872011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12388
12389 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12390 in the current matrix if keep_current_p is non-zero.
12391
8264569d
EZ
123922011-06-04 Eli Zaretskii <eliz@gnu.org>
12393
12394 * bidi.c (bidi_level_of_next_char): Fix last change.
12395
57f97249
EZ
123962011-06-03 Eli Zaretskii <eliz@gnu.org>
12397
fec2107c 12398 Support bidi reordering of text covered by display properties.
57f97249 12399
fec2107c
EZ
12400 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12401 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12402 (bidi_cache_search, bidi_cache_iterator_state)
12403 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12404 (bidi_level_of_next_char, bidi_move_to_visually_next):
12405 Support character positions inside a run of characters covered by a
fec2107c
EZ
12406 display string.
12407 (bidi_paragraph_init, bidi_resolve_explicit_1)
12408 (bidi_level_of_next_char): Call bidi_fetch_char and
12409 bidi_fetch_char_advance instead of FETCH_CHAR and
12410 FETCH_CHAR_ADVANCE.
12411 (bidi_init_it): Initialize new members.
12412 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12413 definitions.
12414 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12415 instead of using explicit *_CHAR codes.
d6d100dd
SM
12416 (bidi_resolve_explicit, bidi_resolve_weak):
12417 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12418 bidirectional text is supported only in multibyte buffers.
12419 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12420 it to initialize the frame_window_p member of struct bidi_it.
12421 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12422 (bidi_resolve_explicit, bidi_resolve_weak)
12423 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12424 bidi_it->nchars is non-positive.
12425 (bidi_level_of_next_char): Don't try to lookup the cache for the
12426 next/previous character if nothing is cached there yet, or if we
12427 were just reseat()'ed to a new position.
c40e2fb2 12428
0e14fe90
EZ
12429 * xdisp.c (set_cursor_from_row): Set start and stop points
12430 according to the row's direction when priming the loop that looks
12431 for the glyph on which to display cursor.
12432 (single_display_spec_intangible_p): Function deleted.
12433 (display_prop_intangible_p): Reimplement to call
12434 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12435 Accept 3 additional arguments needed by handle_display_spec.
12436 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12437 values: lists, `(when COND...)' forms, etc.
12438 (single_display_spec_string_p): Support property values that are
12439 lists with the argument STRING its top-level element.
12440 (display_prop_string_p): Fix the condition for processing a
12441 property that is a list to be consistent with handle_display_spec.
fec2107c 12442 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12443 last portion of handle_display_prop.
12444 (compute_display_string_pos): Accept additional argument
12445 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12446 value of a `display' property is a "replacing spec".
12447 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12448 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12449 the display property, but just return a value indicating whether
12450 the display property will replace the characters it covers.
12451 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12452 frame_window_p members of struct bidi_it.
d6d100dd
SM
12453 (compute_display_string_pos, compute_display_string_end):
12454 New functions.
fec2107c
EZ
12455 (push_it): Accept second argument POSITION, where pop_it should
12456 jump to continue iteration.
12457 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12458
fec2107c
EZ
12459 * keyboard.c (adjust_point_for_property): Adjust the call to
12460 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12461
12462 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12463 (bidi_init_it): Update prototypes.
12464 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12465 (compute_display_string_pos, compute_display_string_end):
12466 Declare prototypes.
fec2107c
EZ
12467 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12468 EMACS_INT.
fc6f18ce 12469
40087514 124702011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12471
57f53182
PE
12472 Malloc failure behavior now depends on size of allocation.
12473 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12474 * lisp.h: Change signatures accordingly.
12475 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12476 All callers changed. (Bug#8762)
12477
12478 * gnutls.c: Use Emacs's memory allocators.
12479 Without this change, the gnutls library would invoke malloc etc.
12480 directly, which causes problems on non-SYNC_INPUT hosts, and which
12481 runs afoul of improving memory_full behavior. (Bug#8761)
12482 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12483 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12484 xfree instead of the default malloc, realloc, free.
12485 (Fgnutls_boot): No need to check for memory allocation failure,
12486 since xmalloc does that for us.
12487
ac32cd99 12488 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12489 * category.c (hash_get_category_set):
12490 * ccl.c (ccl_driver):
12491 * charset.c (Fdefine_charset_internal):
12492 * charset.h (struct charset.hash_index):
12493 * composite.c (get_composition_id, gstring_lookup_cache)
12494 (composition_gstring_put_cache):
12495 * composite.h (struct composition.hash_index):
12496 * dispextern.h (struct image.hash):
12497 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12498 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12499 (hashfn_equal, hashfn_user_defined, make_hash_table)
12500 (maybe_resize_hash_table, hash_lookup, hash_put)
12501 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12502 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12503 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12504 * image.c (make_image, search_image_cache, lookup_image)
12505 (xpm_put_color_table_h):
12506 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12507 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12508 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12509 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12510 * alloc.c (allocate_vectorlike):
12511 Check for overflow in vector size calculations.
12512 * ccl.c (ccl_driver):
12513 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12514 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12515 need to be updated by these changes.
40087514
PE
12516 * fns.c (make_hash_table, maybe_resize_hash_table):
12517 Check for integer overflow with large hash tables.
0de4bb68
PE
12518 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12519 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12520 (SXHASH_REDUCE): New macro.
12521 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12522 Use it instead of discarding useful hash info with large hash values.
12523 (sxhash_float): New function.
12524 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12525 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12526 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12527 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12528 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12529 Adjust signatures to match updated version of code.
12530 (consing_since_gc): Now EMACS_INT, since a single hash table can
12531 use more than INT_MAX bytes.
12532
698d32e2
DN
125332011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12534
12535 Make it possible to build with GCC-4.6+ -O2 -flto.
12536
12537 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12538
fd6fa53f
SM
125392011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12540
12541 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12542 Call minibuffer-inactive-mode.
12543
864db017
JB
125442011-05-31 Juanma Barranquero <lekktu@gmail.com>
12545
12546 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12547 Update dependencies.
12548
2ad0baf4
DN
125492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12550
12551 * data.c (init_data): Remove code for UTS, this system is not
12552 supported anymore.
12553
4fcc2638
DN
125542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12555
12556 Don't force ./temacs to start in terminal mode.
12557
12558 * frame.c (make_initial_frame): Initialize faces in all cases, not
12559 only when CANNOT_DUMP is defined.
12560 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12561
c56e0fd5
DN
125622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12563
12564 * dispnew.c (add_window_display_history): Use const for the string
12565 pointer. Remove declaration, not needed.
12566
333d54da 125672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12568
55d4c1b2 12569 Use 'inline', not 'INLINE'.
333d54da 12570 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
12571 * alloc.c, fontset.c (INLINE): Remove.
12572 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12573 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
12574 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
12575 * gmalloc.c (register_heapinfo): Use inline unconditionally.
12576 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
12577
738db178
DN
125782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12579
12580 Make it possible to run ./temacs.
12581
12582 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
12583 syms_of_callproc does the same thing. Remove test for
12584 "initialized", do it in the caller.
12585 * emacs.c (main): Avoid calling set_initial_environment when dumping.
12586
620c53a6
SM
125872011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
12588
12589 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
12590 (read_minibuf): Use get_minibuffer.
12591 (syms_of_minibuf): Use DEFSYM.
12592 (Qmetadata): New var.
12593 * data.c (Qbuffer): Don't make it static.
12594 (syms_of_data): Use DEFSYM.
12595
e003a292
PE
125962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
12597
12598 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12599 (CCL_CODE_MIN): New macro.
12600
ed008a6d
PE
126012011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12602
3687c2ef
PE
12603 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12604
ed008a6d
PE
12605 * eval.c (Qdebug): Now static.
12606 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12607 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12608 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12609
d66c4c7c
CY
126102011-05-29 Chong Yidong <cyd@stupidchicken.com>
12611
12612 * image.c: Various fixes to ImageMagick code comments.
12613 (Fimagemagick_types): Doc fix.
12614
5fbc2025
PE
126152011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12616
0196f88a
PE
12617 Minor fixes prompted by GCC 4.6.0 warnings.
12618
12619 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12620
5fbc2025
PE
12621 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12622 (x_clipboard_manager_save_all): Move extern decl to ...
12623 * xterm.h: ... here, so that it can be checked for consistency.
12624
1dd3c2d9
CY
126252011-05-29 Chong Yidong <cyd@stupidchicken.com>
12626
12627 * xselect.c (x_clipboard_manager_save_frame)
12628 (x_clipboard_manager_save_all): New functions.
12629 (Fx_clipboard_manager_save): Lisp function deleted.
12630
12631 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12632 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12633
12634 * xterm.h: Update prototype.
12635
5ba6571d
WX
126362011-05-28 William Xu <william.xwl@gmail.com>
12637
12638 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12639 exiting (Bug#8239).
12640
3eaff834
JM
126412011-05-28 Jim Meyering <meyering@redhat.com>
12642
e1900994 12643 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12644 * fns.c (to_uchar): Define.
12645 (crypto_hash_function): Use it to convert some newly-signed
12646 variables to unsigned, to avoid sign-extension bugs. For example,
12647 without this change, (md5 "truc") would evaluate to
12648 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12649 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12650 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12651
0f6990a7
PE
126522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12653
12654 Integer overflow fixes.
c8a9ca5a 12655
08686060
PE
12656 * dbusbind.c: Serial number integer overflow fixes.
12657 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12658 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12659 to hold a serial number that is too large for a fixnum.
12660 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12661 Check for serial numbers out of range. Decode any serial number
59568bf0 12662 that was so large that it became a float. (Bug#8722)
08686060 12663
2d1fc3c7
PE
12664 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12665 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12666 Use XFASTINT rather than XUINT when numbers are nonnegative.
12667 (xd_append_arg, Fdbus_method_return_internal):
12668 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12669 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12670 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12671 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12672 (Bug#8722)
2d1fc3c7 12673
c8a9ca5a
PE
12674 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12675
519e1d69
PE
12676 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12677
6df6ae42 12678 ccl: Add integer overflow checks.
30569699
PE
12679 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12680 (IN_INT_RANGE): New macros.
12681 (ccl_driver): Use them to check for integer overflow when
12682 decoding a CCL program. Many of the new checks are whether XINT (x)
12683 fits in int; it doesn't always, on 64-bit hosts. The new version
12684 doesn't catch all possible integer overflows, but it's an
847044ea 12685 improvement. (Bug#8719)
30569699 12686
c11285dc
PE
12687 * alloc.c (make_event_array): Use XINT, not XUINT.
12688 There's no need for unsigned here.
12689
fdccd48e
PE
12690 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12691 This follows up to the 2011-05-06 change that substituted uintptr_t
12692 for EMACS_INT. This case wasn't caught back then.
12693
37910ab2
PE
12694 Rework Fformat to avoid integer overflow issues.
12695 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12696 now (part of C89). Include <verify.h>.
12697 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12698 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12699 (Fformat): Avoid the prepass trying to compute sizes; it was only
12700 approximate and thus did not catch overflow reliably. Instead, walk
12701 through the format just once, formatting and computing sizes as we go,
12702 checking for integer overflow at every step, and allocating a larger
12703 buffer as needed. Keep track separately whether the format is
12704 multibyte. Keep only the most-recently calculated precision, rather
12705 than them all. Record whether each argument has been converted to
12706 string. Use EMACS_INT, not int, for byte and char and arg counts.
12707 Support field widths and precisions larger than INT_MAX. Avoid
12708 sprintf's undefined behavior with conversion specifications such as %#d
12709 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12710 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12711 formatting out-of-range floating point numbers with int
9173deec 12712 formats. (Bug#8668)
37910ab2 12713
2e6578fb
PE
12714 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12715
0ae6bdee
PE
12716 * data.c: Avoid integer truncation in expressions involving floats.
12717 * data.c: Include <intprops.h>.
12718 (arith_driver): When there's an integer overflow in an expression
12719 involving floating point, convert the integers to floating point
12720 so that the resulting value does not suffer from catastrophic
12721 integer truncation. For example, on a 64-bit host (* 4
12722 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12723 Do not rely on undefined behavior after integer overflow.
12724
de883a70
PE
12725 merge count_size_as_multibyte, parse_str_to_multibyte
12726 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12727 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12728 Check for integer overflow.
12729 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12730 since it's now a duplicate of the other. This is more of
12731 a character than a buffer op, so better that it's in character.c.
12732 * fns.c, print.c: Adjust to above changes.
12733
2ff916cb
PE
127342011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12735
12736 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12737
f1b54466
PE
127382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12739
fb1ac845
PE
12740 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12741 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12742 (x_clipboard_manager_save): Now static.
12743 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12744
f1b54466
PE
12745 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12746 (crypto_hash_function): Now static.
12747 Fix pointer signedness problems. Avoid unnecessary initializations.
12748
a9f737ee
CY
127492011-05-27 Chong Yidong <cyd@stupidchicken.com>
12750
12751 * termhooks.h (Vselection_alist): Make it terminal-local.
12752
12753 * terminal.c (create_terminal): Initialize it.
12754
12755 * xselect.c: Support for clipboard managers.
12756 (Vselection_alist): Move to termhooks.h as terminal-local var.
12757 (LOCAL_SELECTION): New macro.
12758 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12759 (symbol_to_x_atom): Remove gratuitous arg.
12760 (x_handle_selection_request, lisp_data_to_selection_data)
12761 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12762 (x_own_selection, x_get_local_selection, x_convert_selection):
12763 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12764 (some_frame_on_display): Delete unused function.
12765 (Fx_own_selection_internal, Fx_get_selection_internal)
12766 (Fx_disown_selection_internal, Fx_selection_owner_p)
12767 (Fx_selection_exists_p): New optional frame arg.
12768 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12769 (x_handle_selection_clear): Don't treat other terminals with the
12770 same keyboard specially. Use the terminal-local Vselection_alist.
12771 (x_clear_frame_selections): Use Frun_hook_with_args.
12772
12773 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12774
12775 * xterm.h: Add support for those atoms.
12776
e067f0c1
CY
127772011-05-26 Chong Yidong <cyd@stupidchicken.com>
12778
12779 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12780 (converted_selections, conversion_fail_tag): New global variables.
12781 (x_selection_request_lisp_error): Free the above.
12782 (x_get_local_selection): Remove unnecessary code.
12783 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12784 of converted selections stored in converted_selections.
12785 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12786 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12787 (x_convert_selection): New function.
12788 (x_handle_selection_event): Simplify.
12789 (x_get_foreign_selection): Don't ignore incoming requests while
12790 waiting for an answer; this will fail when we implement
12791 SAVE_TARGETS, and seems unnecessary anyway.
12792 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12793 (Vx_sent_selection_functions): Doc fix.
12794
0f4aebc0
LL
127952011-05-26 Leo Liu <sdl.web@gmail.com>
12796
12797 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12798
e61124cd
YM
127992011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12800
12801 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12802
12803 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12804 for fringe update if it has periodic bitmap.
ac389d0c 12805 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12806 and fringe_bitmap_periodic_p.
12807
12808 * fringe.c (get_fringe_bitmap_data): New function.
12809 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12810 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12811 row. Mark glyph row for fringe update if periodicity changed.
12812
12813 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12814 for fringe update unless it has periodic bitmap.
12815
f16d9837
KH
128162011-05-25 Kenichi Handa <handa@m17n.org>
12817
12818 * xdisp.c (get_next_display_element): Set correct it->face_id for
12819 a static composition.
12820
e1b90ef6
LL
128212011-05-24 Leo Liu <sdl.web@gmail.com>
12822
12823 * deps.mk (fns.o):
12824 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12825
12826 * fns.c (crypto_hash_function, Fsha1): New function.
12827 (Fmd5): Use crypto_hash_function.
12828 (syms_of_fns): Add Ssha1.
12829
7400048f
PE
128302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12831
12832 * gnutls.c: Remove unused macros.
12833 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12834 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12835 Remove macros that are defined and never used.
12836 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12837
abb71cf4
CY
128382011-05-22 Chong Yidong <cyd@stupidchicken.com>
12839
12840 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12841 (Fx_get_selection_internal): Minor cleanup.
12842 (Fx_own_selection_internal): Rename arguments for consistency with
12843 select.el.
12844
6307db39
PE
128452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12846
12847 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12848
f3d4e0a4
CY
128492011-05-22 Chong Yidong <cyd@stupidchicken.com>
12850
12851 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12852
4d8ade89
YM
128532011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12854
12855 * dispnew.c (scrolling_window): Don't exclude the case that the
12856 last enabled row in the desired matrix touches the bottom boundary.
12857
32078c8d
GM
128582011-05-21 Glenn Morris <rgm@gnu.org>
12859
12860 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12861 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12862 and add some more files.
32078c8d 12863
7285dc67
EZ
128642011-05-20 Eli Zaretskii <eliz@gnu.org>
12865
12866 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12867 report_file_error introduced by the change from 2011-05-07.
12868
89d1bd22
PE
128692011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12870
12871 * systime.h (Time): Define only if emacs is defined.
12872 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12873 where the include path doesn't have X11/X.h by default. See
12874 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12875
cd394be1 128762011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12877
12878 * composite.c (find_automatic_composition): Fix previous change.
12879
b9704ad9
GM
128802011-05-20 Glenn Morris <rgm@gnu.org>
12881
12882 * lisp.mk: New file, split from Makefile.in.
12883 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12884 (shortlisp): Remove.
12885 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12886
4a720484
GM
128872011-05-19 Glenn Morris <rgm@gnu.org>
12888
12889 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12890 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12891 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12892 (lisp): Set the order to that of loadup.el.
12893 (shortlisp): Make it a copy of $lisp.
12894 (SOME_MACHINE_LISP): Remove.
12895 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12896 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12897
a28d4396
KH
128982011-05-18 Kenichi Handa <handa@m17n.org>
12899
12900 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12901 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12902 (find_automatic_composition): Mostly rewrite for efficiency.
12903
a2b1fa8e
JB
129042011-05-18 Juanma Barranquero <lekktu@gmail.com>
12905
12906 * makefile.w32-in: Update dependencies.
12907
8e1f5610
CS
129082011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12909
12910 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12911 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12912
7025ee00 129132011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12914
cdfa6eab
PE
12915 Fix some integer overflow issues, such as string length overflow.
12916
06d6db33
PE
12917 * insdel.c (count_size_as_multibyte): Check for string overflow.
12918
2b4560a8
PE
12919 * character.c (lisp_string_width): Check for string overflow.
12920 Use EMACS_INT, not int, for string indexes and lengths; in
12921 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12922 the resulting string length overflows an EMACS_INT; instead,
12923 report a string overflow if no precision given. When checking for
12924 precision exhaustion, use a check that cannot possibly have
12925 integer overflow. (Bug#8675)
12926 * character.h (lisp_string_width): Adjust to new signature.
12927
cb93f9be
PE
12928 * alloc.c (string_overflow): New function.
12929 (Fmake_string): Use it. This doesn't change behavior, but saves
12930 a few bytes and will simplify future changes.
12931 * character.c (string_escape_byte8): Likewise.
12932 * lisp.h (string_overflow): New decl.
12933
1a1f3366
PE
12934 Fixups, following up to the user-interface timestamp change.
12935 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12936 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12937 * msdos.c (mouse_get_pos): Likewise.
12938 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12939 * w32gui.h (Time): Define by including "systime.h" rather than by
12940 declaring it ourselves. (Bug#8664)
12941
d4e3e4d3
PE
12942 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12943 * image.c (clear_image_cache): Likewise.
12944
f6a24d19
PE
12945 * term.c (term_mouse_position): Don't assume time_t wraparound.
12946
08dc5ae6
PE
12947 Be more systematic about user-interface timestamps.
12948 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12949 and sometimes 'EMACS_UINT', to represent these timestamps.
12950 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12951 This makes the code easier to follow, and makes it easier to catch
12952 integer overflow bugs such as Bug#8664.
12953 * frame.c (Fmouse_position, Fmouse_pixel_position):
12954 Use Time, not unsigned long, for user-interface timestamps.
12955 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12956 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12957 * keyboard.h (last_event_timestamp): Likewise.
12958 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12959 * menu.h (xmenu_show): Likewise.
12960 * term.c (term_mouse_position): Likewise.
12961 * termhooks.h (struct input_event.timestamp): Likewise.
12962 (struct terminal.mouse_position_hook): Likewise.
12963 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12964 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12965 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12966 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12967 what it was before.
12968 * menu.h, termhooks.h: Include "systime.h", for Time.
12969
8e55734a
PE
12970 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12971 Don't assume that the difference between two unsigned long values
12972 can fit into an integer. At this point, we know button_down_time
12973 <= event->timestamp, so the difference must be nonnegative, so
12974 there's no need to cast the result if double-click-time is
12975 nonnegative, as it should be; check that it's nonnegative, just in
12976 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12977 apart (about 25 days). (Bug#8664)
8e55734a 12978
841f1b75 12979 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12980 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12981
3e26f69c
PE
12982 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12983 that always fit in int. Use a sentinel instead of a counter, to
12984 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12985 * frame.h (struct frame): Use int for menu_bar_items_used
12986 instead of EMACS_INT, since it always fits in int.
3e26f69c 12987
5cc152c0
PE
12988 * menu.c (grow_menu_items): Check for int overflow.
12989
d89eb65e
PE
12990 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12991
5235bd3e
PE
12992 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12993 Before, the code was not consistent. These values cannot exceed
12994 2**31 - 1 so there's no need to make them unsigned.
12995 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12996 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12997 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12998 as modifiers.
12999 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
13000
bc827e23
PE
13001 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13002 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
13003 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
13004 presumably because the widths might not match.
13005
78eb494e
PE
13006 * window.c (size_window): Avoid needless test at loop start.
13007
04f2d78b
CB
130082011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
13009
13010 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
13011
d2fc7e3d 130122011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
13013
13014 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
13015
d2fc7e3d 130162011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
13017
13018 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
13019 `width' to `bar_area_x' and `bar_area_width', respectively.
13020 (x_scroll_run): Take account of fringe background extension.
13021
04f2d78b
CB
13022 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
13023 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
13024 `bar_area_width', respectively.
13025 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
13026 background extension.
13027
79b70037
GM
130282011-05-10 Jim Meyering <meyering@redhat.com>
13029
13030 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
13031
2f142cc5
JB
130322011-05-10 Juanma Barranquero <lekktu@gmail.com>
13033
13034 * image.c (Finit_image_library): Return t for built-in image types,
13035 like pbm and xbm. (Bug#8640)
13036
57679c86
AS
130372011-05-09 Andreas Schwab <schwab@linux-m68k.org>
13038
13039 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13040
888c9e86
EZ
130412011-05-07 Eli Zaretskii <eliz@gnu.org>
13042
b0512a1d
EZ
13043 * w32console.c (Fset_screen_color): Doc fix.
13044 (Fget_screen_color): New function.
13045 (syms_of_ntterm): Defsubr it.
13046
7285dc67
EZ
13047 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
13048 unlink the temporary file if Fcall_process didn't create it in the
13049 first place.
13050 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
13051 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
13052 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13053 cue to call_process_cleanup not to close that handle.
13054
4d3fcc8e
BK
130552011-05-07 Ben Key <bkey76@gmail.com>
13056
13057 * makefile.w32-in: The bootstrap-temacs rule now makes use of
13058 one of two shell specific rules, either bootstrap-temacs-CMD or
13059 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
13060 to the previous implementation of the bootstrap-temacs rule.
13061 The bootstrap-temacs-CMD rule is similar to the previous
13062 implementation of the bootstrap-temacs rule except that it
13063 makes use of the ESC_CFLAGS variable instead of the CFLAGS
13064 variable.
13065
13066 These changes, along with some changes to nt/configure.bat,
13067 nt/gmake.defs, and nt/nmake.defs, are required to extend my
13068 earlier fix to add support for --cflags and --ldflags options
13069 that include quotes so that it works whether make uses cmd or
13070 sh as the shell.
13071
b4289b64
MA
130722011-05-06 Michael Albinus <michael.albinus@gmx.de>
13073
13074 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
13075 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
13076 is a constant.
13077 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
13078 a string. Handle both cases.
13079 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
13080 (Fdbus_register_method): Use Qinvalid_function.
13081
af4c0e28
JB
130822011-05-06 Juanma Barranquero <lekktu@gmail.com>
13083
13084 * makefile.w32-in: Update dependencies.
13085 (LISP_H): Add inttypes.h and stdin.h.
13086 (PROCESS_H): Add unistd.h.
13087
c51453d9
EZ
130882011-05-06 Eli Zaretskii <eliz@gnu.org>
13089
13090 * lread.c: Include limits.h (fixes the MS-Windows build broken by
13091 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
13092
8ff0ac3c 130932011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 13094
4c4b566b
PE
13095 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
13096
aab2b9b5
PE
13097 * term.c (vfatal): Remove stray call to va_end.
13098 It's not needed and the C Standard doesn't allow it here anyway.
13099
c378da0b
PE
13100 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
13101 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
13102
288b08c7
PE
13103 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
13104 bytes.
13105
e3601888
PE
13106 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
13107
db6c0e74
PE
13108 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
13109
dd5963ea
PE
13110 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
13111
88c9450f
PE
13112 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
13113
2f9442b8
PE
13114 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
13115
c032b5f8
PE
13116 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
13117 * charset.c (Fdefine_charset_internal): Don't initialize
13118 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 13119 32-bit int (Bug#8600).
a108c10b
PE
13120
13121 * lread.c (read_integer): Be more consistent with string-to-number.
13122 Use string_to_number to do the actual conversion; this avoids
13123 rounding errors and fixes some other screwups. Without this fix,
13124 for example, #x1fffffffffffffff was misread as -2305843009213693952.
13125 (digit_to_number): Move earlier, for benefit of read_integer.
13126 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 13127 not a digit in any supported base. (Bug#8602)
a108c10b 13128
ad5f9eea
PE
13129 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
13130
aec1708a
PE
13131 * dispnew.c (scrolling_window): Return 1 if we scrolled,
13132 to match comment at start of function. This also removes a
13133 GCC warning about overflow in a 32+64-bit port.
13134
47be4ab5
PE
13135 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
13136
371cac43
PE
13137 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
13138 Reported by Stefan Monnier in
13139 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
13140 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13141 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 13142
d01a7826
PE
13143 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
13144 (EMACS_UINTPTR): Likewise, with uintptr_t.
13145
7fd47d5c
PE
13146 * lisp.h: Prefer 64-bit EMACS_INT if available.
13147 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
13148 on 32-bit hosts that have 64-bit int, so that they can access
13149 large files.
122b0c86
PE
13150 However, temporarily disable this change unless the temporary
13151 symbol WIDE_EMACS_INT is defined.
7fd47d5c 13152
8727937b
PE
13153 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
13154
8ac068ac
PE
13155 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
13156 This removes an assumption that EMACS_INT and long are the same
13157 width as pointers. The assumption is true for Emacs porting targets
13158 now, but we want to make other targets possible.
13159 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
13160 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
13161 In the rest of the code, change types of integers that hold casted
13162 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
13163 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
13164 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
13165 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
13166 No need to cast type when ORing.
13167 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
13168 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
13169 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
13170 assume EMACS_INT is the same width as char *.
13171 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
13172 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
13173 Remove no-longer-needed casts.
13174 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
13175 (xg_tool_bar_help_callback, xg_make_tool_item):
13176 Use EMACS_INTPTR to hold an integer
13177 that will be cast to void *; this can avoid a GCC warning
13178 if EMACS_INT is not the same width as void *.
13179 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
13180 * xdisp.c (display_echo_area_1, resize_mini_window_1):
13181 (current_message_1, set_message_1):
13182 Use a local to convert to proper width without a cast.
13183 * xmenu.c (dialog_selection_callback): Likewise.
13184
ede49d71
PE
13185 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
13186 Also, don't assume VALBITS / RAND_BITS is less than 5,
13187 and don't rely on undefined behavior when shifting a 1 left into
13188 the sign bit.
13189 * lisp.h (get_random): Change signature to match.
13190
2f30ecd0
PE
13191 * lread.c (hash_string): Use size_t, not int, for hash computation.
13192 Normally we prefer signed values; but hashing is special, because
13193 it's better to use unsigned division on hash table sizes so that
13194 the remainder is nonnegative. Also, size_t is the natural width
13195 for hashing into memory. The previous code used 'int', which doesn't
13196 retain enough info to hash well into very large tables.
13197 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
13198
2a866e7b
PE
13199 * dbusbind.c: Don't possibly lose pointer info when converting.
13200 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13201 Use XPNTR rather than XHASH, so that the high-order bits of
13202 the pointer aren't lost when converting through void *.
13203
51639eac
PE
13204 * eval.c (Fautoload): Don't double-shift a pointer.
13205
92394119
PE
13206 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
13207
dbdb9a7c
JB
132082011-05-06 Juanma Barranquero <lekktu@gmail.com>
13209
13210 * gnutls.c (DEF_GNUTLS_FN):
13211 * image.c (DEF_IMGLIB_FN): Make function pointers static.
13212
db7a0b4f
AS
132132011-05-05 Andreas Schwab <schwab@linux-m68k.org>
13214
13215 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
13216 marker. (Bug#8610)
13217
cd394be1 132182011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
13219
13220 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
13221 New version that can reserve upto 2GB of heap space.
13222
f7ff1b0f 132232011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
13224
13225 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
13226
639c109b
TZ
132272011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
13228
13229 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
13230 `gnutls_certificate_set_x509_key_file'.
13231
d2127135
JB
132322011-05-05 Juanma Barranquero <lekktu@gmail.com>
13233
13234 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
13235 Update dependencies.
13236
e968f4f3
JB
132372011-05-04 Juanma Barranquero <lekktu@gmail.com>
13238
13239 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
13240 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
13241 Remove unused parameter `fildes'.
13242 * process.c (read_process_output, send_process): Don't pass it.
13243
84d358f0
JB
132442011-05-04 Juanma Barranquero <lekktu@gmail.com>
13245
13246 Fix previous change: the library cache is defined in w32.c.
13247 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
13248 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
13249
0898ca10
JB
132502011-05-04 Juanma Barranquero <lekktu@gmail.com>
13251
13252 Implement dynamic loading of GnuTLS on Windows.
13253
13254 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
13255 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
13256 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13257 Declare.
13258
13259 * gnutls.c (Qgnutls_dll): Define.
13260 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
13261 (gnutls_*): Declare function pointers.
13262 (init_gnutls_functions): New function to initialize function pointers.
13263 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
13264 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
13265 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13266 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
13267 (emacs_gnutls_write, emacs_gnutls_read)
13268 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
13269 (Fgnutls_available_p): New function.
13270 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
13271 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
13272 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
13273
13274 * image.c: Include w32.h.
13275 (Vimage_type_cache): Delete.
13276 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
13277 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
13278 (w32_delayed_load): Move to w32.c.
13279
13280 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
13281
13282 * w32.c (QCloaded_from, Vlibrary_cache): Define.
13283 (w32_delayed_load): Move from image.c. When loading a library, record
13284 its filename in the :loaded-from property of the library id.
13285 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
13286 Initialize and staticpro them.
13287 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
13288
13289 * process.c: Include lisp.h before w32.h, not after.
13290 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
13291 instead of gnutls_record_check_pending.
13292
13293 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
13294
ff4de4aa
TZ
132952011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
13296
13297 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
13298 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
13299 as passed in.
13300
abe95abb
JD
133012011-05-03 Jan Djärv <jan.h.d@swipnet.se>
13302
13303 * xterm.c (x_set_frame_alpha): Do not set property on anything
13304 else than FRAME_X_OUTER_WINDOW (Bug#8608).
13305
e16e55d4
JB
133062011-05-02 Juanma Barranquero <lekktu@gmail.com>
13307
13308 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
13309
bafcf6a5
JB
133102011-05-02 Juanma Barranquero <lekktu@gmail.com>
13311
13312 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
13313 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
13314 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
13315 (gnutls_global_initialized, Qgnutls_bootprop_priority)
13316 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
13317 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
13318 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
13319 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
13320 (Qgnutls_bootprop_callbacks_verify): Make static.
13321
e7a6747f
AS
133222011-05-01 Andreas Schwab <schwab@linux-m68k.org>
13323
19ed11ba
AS
13324 * callproc.c: Indentation fixup.
13325
e7a6747f 13326 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
13327 (wait_for_termination, interruptible_wait_for_termination):
13328 Move after wait_for_termination_1.
e7a6747f 13329
1ef14cb4
LMI
133302011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
13331
13332 * sysdep.c (interruptible_wait_for_termination): New function
13333 which is like wait_for_termination, but allows keyboard
13334 interruptions.
13335
13336 * callproc.c (Fcall_process): Add (:file "file") as an option for
13337 the STDOUT buffer.
13338 (Fcall_process_region): Ditto.
13339
330d880c
EZ
133402011-04-30 Eli Zaretskii <eliz@gnu.org>
13341
8db90b73
EZ
13342 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
13343 rather than `XVECTOR (FOO)->size'.
13344
330d880c
EZ
13345 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
13346 inttypes.h, as a gnulib replacement is used if it not available in
13347 system headers.
13348
15cbd324
EZ
133492011-04-21 Eli Zaretskii <eliz@gnu.org>
13350
13351 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
13352 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
13353 of MOST_POSITIVE_FIXNUM. (Bug#8528)
13354
13355 * coding.c (coding_alloc_by_realloc): Error out if destination
13356 will grow beyond MOST_POSITIVE_FIXNUM.
13357 (decode_coding_emacs_mule): Abort if there isn't enough place in
13358 charbuf for the composition carryover bytes. Reserve an extra
13359 space for up to 2 characters produced in a loop.
13360 (decode_coding_iso_2022): Abort if there isn't enough place in
13361 charbuf for the composition carryover bytes.
13362
133632011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 13364
ae940cca
EZ
13365 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
13366 aborting when %lld or %lll format is passed.
13367 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
13368 %llo or %llx format is passed. (Bug#8545)
13369
03ab8921
EZ
13370 * window.c (window_scroll_line_based): Use a marker instead of
13371 simple variables to record original value of point. (Bug#7952)
13372
afda1437
EZ
13373 * doprnt.c (doprnt): Fix the case where a multibyte sequence
13374 produced by %s or %c overflows available buffer space. (Bug#8545)
13375
f76dee0c
PE
133762011-04-28 Paul Eggert <eggert@cs.ucla.edu>
13377
13378 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13379 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13380
fdc5744d
JB
133812011-04-28 Juanma Barranquero <lekktu@gmail.com>
13382
13383 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13384
638f053a
JB
133852011-04-28 Juanma Barranquero <lekktu@gmail.com>
13386
13387 * keyboard.c (Qdelayed_warnings_hook): Define.
13388 (command_loop_1): Run `delayed-warnings-hook'
13389 if Vdelayed_warnings_list is non-nil.
13390 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13391 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13392
d178f871
EZ
133932011-04-28 Eli Zaretskii <eliz@gnu.org>
13394
13395 * doprnt.c (doprnt): Don't return value smaller than the buffer
13396 size if the message was truncated. (Bug#8545).
13397
b124fd93
JB
133982011-04-28 Juanma Barranquero <lekktu@gmail.com>
13399
13400 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13401 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13402
e810457d
PE
134032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13404
13405 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13406
ea51cceb
JB
134072011-04-27 Juanma Barranquero <lekktu@gmail.com>
13408
13409 * makefile.w32-in: Update dependencies.
13410
94dcfacf
EZ
134112011-04-27 Eli Zaretskii <eliz@gnu.org>
13412
13413 Improve `doprnt' and its usage. (Bug#8545)
13414 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13415 `format_end'. Remove support for %l as a conversion specifier.
13416 Don't use xrealloc. Improve diagnostics when the %l size modifier
13417 is used. Update the commentary.
13418
13419 * eval.c (verror): Simplify calculation of size_t.
13420
13421 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13422 messages.
13423
f61f41d7
PE
134242011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13425
13426 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13427 change.
13428
96fb4434
PE
134292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13430
13431 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13432 This makes this file independent of the recent pseudovector change.
13433
671875da 134342011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13435
69e9b5a3
PE
13436 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13437
b5f869a7 13438 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13439 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13440 Remove unused local.
c8926152 13441 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13442
841a1577 13443 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13444 GCC 4.6.0 optimizes based on type-based alias analysis.
13445 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13446 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13447 != &v->size, and therefore "v->size = 1; b->size = 2; return
13448 v->size;" must therefore return 1. This assumption is incorrect
13449 for Emacs, since it type-puns struct Lisp_Vector * with many other
13450 types. To fix this problem, this patch adds a new type struct
f904488f 13451 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13452 and pseudovectors, and helps optimizing compilers not get fooled
13453 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13454 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13455 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13456 the size member.
eab3844f
PE
13457 (XSETPVECTYPE): Rewrite in terms of new macro.
13458 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13459 This is a bit clearer, and further avoids the possibility of
13460 undesirable aliasing.
13461 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13462 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13463 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13464 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13465 (ASIZE): Now uses header.size rather than size.
13466 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13467 to avoid the hassle of writing XVECTOR (foo)->header.size.
13468 (struct vectorlike_header): New type.
eab3844f
PE
13469 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13470 object, to help avoid aliasing.
13471 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13472 (SUBRP): Likewise, since Lisp_Subr is a special case.
13473 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13474 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13475 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13476 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13477 changed to be "header.size" and "header.next".
13478 * buffer.h (struct buffer): Likewise.
13479 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13480 * frame.h (struct frame): Likewise.
13481 * process.h (struct Lisp_Process): Likewise.
13482 * termhooks.h (struct terminal): Likewise.
13483 * window.c (struct save_window_data, struct saved_window): Likewise.
13484 * window.h (struct window): Likewise.
13485 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13486 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13487 * buffer.c (init_buffer_once): Likewise.
13488 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13489 special case.
13490 * process.c (Fformat_network_address): Use local var for size,
13491 for brevity.
13492
0df1eac5
PE
13493 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13494
847ab9d1 13495 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13496 * data.c (atof): Remove decl; no longer used or needed.
13497 (digit_to_number): Move to lread.c.
13498 (Fstring_to_number): Use new string_to_number function, to be
13499 consistent with how the Lisp reader treats infinities and NaNs.
13500 Do not assume that floating-point numbers represent EMACS_INT
13501 without losing information; this is not true on most 64-bit hosts.
13502 Avoid double-rounding errors, by insisting on integers when
13503 parsing non-base-10 numbers, as the documentation specifies.
13504 * lisp.h (string_to_number): New decl, replacing ...
13505 (isfloat_string): Remove.
bc0a5c13 13506 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13507 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13508 appears to have been a coding error. Similarly, do not accept
13509 strings like +-1e0 as floating point numbers. Do not report
13510 overflow for integer overflows unless the base is not 10 which
13511 means we have no simple and reliable way to continue.
13512 Break out the floating-point parsing into a new
13513 function string_to_number, so that Fstring_to_number parses
13514 floating point numbers consistently with the Lisp reader.
04f2d78b 13515 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13516 (E_CHAR, EXP_INT): Remove, replacing with ...
13517 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13518 (string_to_number): New function, replacing isfloat_string.
13519 This function checks for valid syntax and produces the resulting
13520 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13521 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13522 so that overflow for non-base-10 numbers is reported only when
13523 there's no portable and simple way to convert to floating point.
452f4150 13524
67769ffc
PE
13525 * textprop.c (set_text_properties_1): Rewrite for clarity,
13526 and to avoid GCC warning about integer overflow.
13527
c20db43f
PE
13528 * intervals.h (struct interval): Use EMACS_INT for members
13529 where EMACS_UINT might cause problems. See
13530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13531 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13532 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13533 All uses changed.
37aa2f85
PE
13534 (offset_intervals): Tell GCC not to worry about length overflow
13535 when negating a negative length.
c20db43f 13536
2538aa2f
PE
13537 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13538 (overrun_check_free): Likewise.
13539
f2d3008d
PE
13540 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13541 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13542 word size.
13543
ec8df744
PE
13544 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13545 (gnutls_make_error): Rename local to avoid shadowing.
13546 (gnutls_emacs_global_deinit): ifdef out; not used.
13547 (Fgnutls_boot): Use const for pointer to readonly storage.
13548 Comment out unused local. Fix pointer signedness problems.
13549
640ee02d
PE
13550 * lread.c (openp): Don't stuff size_t into an 'int'.
13551 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13552 about possible signed overflow.
13553
6048fb2a
PE
13554 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13555 (GDK_KEY_g): Don't define if already defined.
13556 (xg_prepare_tooltip): Avoid pointer signedness problem.
13557 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13558
fa3c87e1
PE
13559 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13560 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13561
2172544b
PE
13562 * xfns.c (Fx_window_property): Simplify a bit,
13563 to make a bit faster and to avoid GCC 4.6.0 warning.
13564 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13565
9b821a21
PE
13566 * fns.c (internal_equal): Don't assume size_t fits in int.
13567
3c616cfa
PE
13568 * alloc.c (compact_small_strings): Tighten assertion a little.
13569
c2982e87
PE
13570 Replace pEd with more-general pI, and fix some printf arg casts.
13571 * lisp.h (pI): New macro, generalizing old pEd macro to other
13572 conversion specifiers. For example, use "...%"pI"d..." rather
13573 than "...%"pEd"...".
13574 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 13575 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
13576 * alloc.c (check_pure_size): Don't overflow by converting size to int.
13577 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
13578 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
13579 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13580 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
13581 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
13582 64-bit hosts.
13583 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
13584 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
13585 * print.c (safe_debug_print, print_object): Likewise.
13586 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
13587 to int.
6f04d126
PE
13588 Use pI instead of if-then-else-abort. Use %p to avoid casts,
13589 avoiding the 0 flag, which is not portable.
c2982e87
PE
13590 * process.c (Fmake_network_process): Use pI to avoid cast.
13591 * region-cache.c (pp_cache): Likewise.
13592 * xdisp.c (decode_mode_spec): Likewise.
13593 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
13594 behavior on 64-bit hosts with printf arg.
6f04d126 13595 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
13596 (x_stop_queuing_selection_requests): Likewise.
13597 (x_get_window_property): Don't truncate byte count to an 'int'
13598 when tracing.
0b432f21 13599
5e073ec7
PE
13600 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13601 here, since it parses constructs like leading '-' and spaces,
13602 which are not wanted; and it overflows with large numbers.
13603 Instead, simply match F[0-9]+, which is what is wanted anyway.
13604
36372bf9
PE
13605 * alloc.c: Remove unportable assumptions about struct layout.
13606 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13607 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13608 (allocate_vectorlike, make_pure_vector): Use the new macros,
13609 plus offsetof, to remove unportable assumptions about struct layout.
13610 These assumptions hold on all porting targets that I know of, but
13611 they are not guaranteed, they're easy to remove, and removing them
13612 makes further changes easier.
13613
0b432f21
PE
13614 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13615 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13616 (string_overrun_cookie): Now const. Use initializers that
13617 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13618 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13619 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13620 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13621 multiple of sizeof (EMACS_INT); it need not be, if
13622 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13623 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13624
895009e1
JB
136252011-04-26 Juanma Barranquero <lekktu@gmail.com>
13626
13627 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13628
6a7a1b0b
TZ
136292011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13630
13631 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13632 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13633 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13634
841a1577 136352011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13636
13637 * lisp.h (Qdebug): List symbol.
895009e1 13638 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13639 * keyboard.c (debug-on-event): New variable.
13640 (handle_user_signal): Break into debugger when debug-on-event
13641 matches the current signal symbol.
13642
f2d3ba6f
DN
136432011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13644
13645 * alloc.c (check_sblock, check_string_bytes)
13646 (check_string_free_list): Convert to standard C.
13647
42ce4c63
TZ
136482011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13649
13650 * w32.c (emacs_gnutls_push): Fix typo.
13651
825cd63c
EZ
136522011-04-25 Eli Zaretskii <eliz@gnu.org>
13653
fb11d64d
EZ
13654 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13655 "cast to pointer from integer of different size".
13656
825cd63c
EZ
13657 Improve doprnt and its use in verror. (Bug#8545)
13658 * doprnt.c (doprnt): Document the set of format control sequences
13659 supported by the function. Use SAFE_ALLOCA instead of always
13660 using `alloca'.
13661
13662 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13663 is one byte too soon. Don't use xrealloc; instead xfree and
13664 xmalloc anew.
13665
e061a11b
TZ
136662011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13667
13668 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13669 callbacks stage.
13670
13671 * gnutls.c: Renamed global_initialized to
13672 gnutls_global_initialized. Added internals for the
13673 :verify-hostname-error, :verify-error, and :verify-flags
13674 parameters of `gnutls-boot' and documented those parameters in the
13675 docstring. Start callback support.
9173deec
JB
13676 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13677 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13678 on error. Return error code.
e061a11b
TZ
13679 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13680 (emacs_gnutls_read): Likewise.
13681 (Fgnutls_boot): Return handshake error code.
13682 (emacs_gnutls_handle_error): New function.
13683 (wsaerror_to_errno): Likewise.
13684
13685 * w32.h (emacs_gnutls_pull): Add prototype.
13686 (emacs_gnutls_push): Likewise.
13687
13688 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13689 (emacs_gnutls_push): Likewise.
13690
136912011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13692
13693 * process.c (wait_reading_process_output): Check if GnuTLS
13694 buffered some data internally if no FDs are set for TLS
13695 connections.
13696
13697 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13698 (LIBS): Link to USER_LIBS.
13699 ($(BLD)/gnutls.$(0)): New target.
13700
fa6996bc
EZ
137012011-04-24 Eli Zaretskii <eliz@gnu.org>
13702
eb35682e
EZ
13703 * xdisp.c (handle_single_display_spec): Rename the
13704 display_replaced_before_p argument into display_replaced_p, to
13705 make it consistent with the commentary. Fix typos in the
13706 commentary.
13707
e2ad650c
EZ
13708 * textprop.c (syms_of_textprop): Remove dead code.
13709 (copy_text_properties): Delete obsolete commentary about an
13710 interface that was deleted long ago. Fix typos in the description
13711 of arguments.
13712
1b2de274
EZ
13713 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13714 to changes in oldXMenu/XMenu.h from 2011-04-16.
13715 <menu_help_message, prev_menu_help_message>: Constify.
13716 (IT_menu_make_room): menu->help_text is now `const char **';
13717 adjust.
13718
13719 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13720 to changes in oldXMenu/XMenu.h from 2011-04-16.
13721 (struct XMenu): Declare `help_text' `const char **'.
13722
13723 * xfaces.c <Qunspecified>: Make extern again.
13724
13725 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13726 required by POSIX.
1b2de274 13727
762b15be
EZ
13728 * doc.c (get_doc_string): Improve the format passed to `error'.
13729
13730 * doprnt.c (doprnt): Improve commentary.
13731
13732 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13733
13734 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13735 them with etags.
13736
f1052e5d
EZ
13737 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13738 changes in globals.h immediately force recompilation.
762b15be
EZ
13739 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13740 $(CURDIR)/s/ms-w32.h.
13741 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13742
fa6996bc
EZ
13743 * character.c (Fchar_direction): Function deleted.
13744 (syms_of_character): Don't defsubr it.
13745 <char-direction-table>: Deleted.
13746
e6c3da20
EZ
137472011-04-23 Eli Zaretskii <eliz@gnu.org>
13748
13749 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13750 * doprnt.c: Include limits.h.
13751 (SIZE_MAX): New macro.
04f2d78b
CB
13752 (doprnt): Return a size_t value. 2nd arg is now size_t.
13753 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13754 Improve overflow protection. Support `l' modifier for integer
13755 conversions. Support %l conversion. Don't assume an EMACS_INT
13756 argument for integer conversions and for %c.
13757
13758 * lisp.h (doprnt): Restore prototype.
13759
13760 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13761 $(SRC)/character.h.
13762
13763 * Makefile.in (base_obj): Add back doprnt.o.
13764
13765 * deps.mk (doprnt.o): Add back prerequisites.
13766 (callint.o): Depend on character.h.
13767
13768 * eval.c (internal_lisp_condition_case): Include the handler
13769 representation in the error message.
13770 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13771 when breaking from the loop.
13772
13773 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13774
13775 * callint.c (Fcall_interactively): When displaying error message
13776 about invalid control letter, pass the character's codepoint, not
13777 a pointer to its multibyte form. Improve display of the character
13778 in octal and display also its hex code.
13779
13780 * character.c (char_string): Use %x to display the (unsigned)
13781 codepoint of an invalid character, to avoid displaying a bogus
13782 negative value.
13783
13784 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13785 `error', not SYMBOL_NAME itself.
13786
13787 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13788 character arguments to `error'.
13789
13790 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13791 to `error' in error message about FINAL_CHAR argument. Make sure
13792 FINAL_CHAR is a character, and use %c when it is passed as
13793 argument to `error'.
13794
4ffd0d6b 137952011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13796
13797 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13798
13799 * w32.c: Include <time.h>.
13800 (sys_localtime): New function.
13801
4ffd0d6b 138022011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13803
13804 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13805
4ffd0d6b 13806 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13807
4ffd0d6b 138082011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13809
4ffd0d6b
GM
13810 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13811 zombies (Bug#8467).
aac0c6e3 13812
04c56954
EZ
138132011-04-19 Eli Zaretskii <eliz@gnu.org>
13814
13815 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13816 gl_state.e_property when gl_state.object is Qt.
13817
13818 * insdel.c (make_gap_larger): Remove limitation of buffer size
13819 to <= INT_MAX.
13820
16a43933
CY
138212011-04-18 Chong Yidong <cyd@stupidchicken.com>
13822
13823 * xdisp.c (lookup_glyphless_char_display)
13824 (produce_glyphless_glyph): Handle cons cell entry in
13825 glyphless-char-display.
13826 (Vglyphless_char_display): Document it.
13827
13828 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13829 glyphless-char-display.
13830
4581706e
CY
138312011-04-17 Chong Yidong <cyd@stupidchicken.com>
13832
13833 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13834
13835 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13836
13837 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13838 definition for no-X builds.
13839
4887c6e2 138402011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13841
fd35b6f9
PE
13842 Static checks with GCC 4.6.0 and non-default toolkits.
13843
5c1ccb01
PE
13844 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13845
006c5daa
PE
13846 * process.c (keyboard_bit_set): Define only if SIGIO.
13847 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13848 (send_process): Repair possible setjmp clobbering.
13849
efc736d3
PE
13850 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13851
4e2fe2e6
PE
13852 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13853
f97334a2
PE
13854 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13855
4e75f29d
PE
13856 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13857 Define only if needed.
13858
90efadd1
PE
13859 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13860 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13861 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13862
3c647824
PE
13863 * dispextern.h (struct redisplay_interface): Rename param
13864 to avoid shadowing.
e264f262 13865 * termhooks.h (struct terminal): Likewise.
761383f4 13866 * xterm.c (xembed_send_message): Likewise.
3c647824 13867
b58c5c4a
PE
13868 * insdel.c (make_gap_smaller): Define only if
13869 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13870
cad59032
PE
13871 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13872 it.
13873
c339dc2e
PE
13874 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13875 so that we aren't warned about unused symbols.
13876
91a3e27b
PE
13877 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13878
399c71d3 13879 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13880
8ffc96f5
PE
13881 * xfns.c (x_real_positions): Mark locals as initialized.
13882
eef9bc79
PE
13883 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13884
098db9dd
PE
13885 * xterm.c: Fix problems found by static analysis with other toolkits.
13886 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13887 (x_dispatch_event): Declare static if USE_GTK, and
13888 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13889 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13890 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13891 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13892 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13893
eb18f6cc
PE
13894 * xmenu.c (menu_help_callback): Pointer type fixes.
13895 Use const pointers when pointing at readonly data. Avoid pointer
13896 signedness clashes.
13897 (FALSE): Remove unused macro.
13898 (update_frame_menubar): Remove unused decl.
13899
1fe72bf8
PE
13900 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13901
60d9e1db
PE
13902 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13903 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13904 (single_menu_item): Rename local to avoid shadowing.
13905
39261c26
PE
13906 * keyboard.c (make_lispy_event): Remove unused local var.
13907
018c5e19
PE
13908 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13909 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13910
63d2b86e
PE
13911 * bitmaps: Change bitmaps from unsigned char back to the X11
13912 compatible char. Avoid the old compiler warnings about
13913 out-of-range initializers by using, for example, '\xab' rather
13914 than 0xab.
13915
aefd87e1
PE
13916 * xgselect.c (xgselect_initialize): Check vs interface
13917 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13918
bf501fb9
PE
13919 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13920
e9829fdf
PE
13921 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13922 to read-only memory.
13923
1086c095
PE
13924 * fns.c (vector): Remove; this old hack is no longer needed.
13925
2baccd04 13926 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13927 Remove unused var.
dde42981 13928 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13929
72391843 13930 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13931
436c16df 13932 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13933 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13934 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13935
92bb796d 13936 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13937 (x_term_init): Remove local to avoid shadowing.
92bb796d 13938
764430a3 13939 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13940
13941 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13942 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13943
d1dfb56c
EZ
139442011-04-16 Eli Zaretskii <eliz@gnu.org>
13945
c4354cb4
EZ
13946 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13947
d1dfb56c
EZ
13948 Fix regex.c, syntax.c and friends for buffers > 2GB.
13949 * syntax.h (struct gl_state_s): Declare character position members
13950 EMACS_INT.
13951
13952 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13953
04f2d78b
CB
13954 * textprop.c (verify_interval_modification, interval_of):
13955 Declare arguments EMACS_INT.
d1dfb56c
EZ
13956
13957 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13958 EMACS_INT.
13959
13960 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13961
13962 * indent.c (Fvertical_motion): Local variable it_start is now
13963 EMACS_INT.
13964
13965 * regex.c (re_match, re_match_2, re_match_2_internal)
13966 (bcmp_translate, regcomp, regexec, print_double_string)
13967 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13968 (re_compile_pattern, re_exec): Declare arguments and local
13969 variables `size_t' and `ssize_t' and return values `regoff_t', as
13970 appropriate.
13971 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13972 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13973 <compile_stack_type>: `size' and `avail' are now `size_t'.
13974
13975 * regex.h <regoff_t>: Use ssize_t, not int.
13976 (re_search, re_search_2, re_match, re_match_2): Arguments that
13977 specify buffer/string position and length are now ssize_t and
13978 size_t. Return type is regoff_t.
13979
613052cd
BK
139802011-04-16 Ben Key <bkey76@gmail.com>
13981
13982 * nsfont.m: Fixed bugs in ns_get_family and
13983 ns_descriptor_to_entity that were caused by using free to
13984 deallocate memory blocks that were allocated by xmalloc (via
13985 xstrdup). This caused Emacs to crash when compiled with
13986 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13987 --enable-checking=xmallocoverrun). xfree is now used to
13988 deallocate these memory blocks.
13989
4170f62f 139902011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13991
71b41406
PE
13992 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13993
9587a89d
PE
13994 emacs_write: Accept and return EMACS_INT for sizes.
13995 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13996 et seq.
13997 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13998 Accept and return EMACS_INT.
13999 (emacs_gnutls_write): Return the number of bytes written on
14000 partial writes.
14001 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
14002 (emacs_read, emacs_write): Remove check for negative size, as the
14003 Emacs source code has been audited now.
9587a89d
PE
14004 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14005 (emacs_read, emacs_write): Use it.
273a5f82
PE
14006 * process.c (send_process): Adjust to the new signatures of
14007 emacs_write and emacs_gnutls_write. Do not attempt to store
14008 a byte offset into an 'int'; it might overflow.
9587a89d 14009 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 14010
3e047f51
PE
14011 * sound.c: Don't assume sizes fit in 'int'.
14012 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 14013 Return EMACS_INT, not int.
3e047f51 14014 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
14015 Accept EMACS_INT, not int.
14016 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
14017 record read return values.
14018
cc39a9db
BK
140192011-04-15 Ben Key <bkey76@gmail.com>
14020
c9d0ec6d
JB
14021 * keyboard.c (Qundefined): Don't declare static since it is used
14022 in nsfns.m.
14023 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
14024 static since they are used in nsfont.m.
cc39a9db 14025
6c60eb9f
SM
140262011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
14027
14028 * process.c (Qprocessp): Don't declare static.
14029 * lisp.h (Qprocessp): Declare again.
14030
7990b61a
JB
140312011-04-15 Juanma Barranquero <lekktu@gmail.com>
14032
14033 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
14034
5d4cb038
PE
140352011-04-14 Paul Eggert <eggert@cs.ucla.edu>
14036
8bd7b830 14037 Improve C-level modularity by making more things 'static'.
cd64ea1d 14038
e3b27b31
PE
14039 Don't publish debugger-only interfaces to other modules.
14040 * lisp.h (safe_debug_print, debug_output_compilation_hack):
14041 (verify_bytepos, count_markers): Move decls to the only modules
14042 that need them.
14043 * region-cache.h (pp_cache): Likewise.
14044 * window.h (check_all_windows): Likewise.
14045 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
14046
5d4cb038
PE
14047 * sysdep.c (croak): Now static, if
14048 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
14049 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14050
14051 * alloc.c (refill_memory_reserve): Now static if
14052 !defined REL_ALLOC || defined SYSTEM_MALLOC.
14053 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 14054
e87b6180
PE
14055 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
14056 Define only if USE_LUCID.
14057
ac64929e
PE
14058 * xrdb.c (x_customization_string, x_rm_string): Now static.
14059
6f37259d
PE
14060 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
14061 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
14062
1683e3ab
PE
14063 * xdisp.c (draw_row_with_mouse_face): Now static.
14064 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
14065
de9c2632
PE
14066 * window.h (check_all_windows): Mark externally visible.
14067
2b96acb7
PE
14068 * window.c (window_deletion_count): Now static.
14069
14070 * undo.c: Make symbols static if they're not exported.
14071 (last_undo_buffer, last_boundary_position, pending_boundary):
14072 Now static.
14073
50436f33
PE
14074 * textprop.c (interval_insert_behind_hooks): Now static.
14075 (interval_insert_in_front_hooks): Likewise.
14076
64520e5c
PE
14077 * term.c: Make symbols static if they're not exported.
14078 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
14079 (max_frame_lines, tty_set_terminal_modes):
14080 (tty_reset_terminal_modes, tty_turn_off_highlight):
14081 (get_tty_terminal): Now static.
14082 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
14083 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 14084 HAVE_WINDOW_SYSTEM.
64520e5c
PE
14085 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
14086 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
14087
1fa53021
PE
14088 * sysdep.c: Make symbols static if they're not exported.
14089 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
14090 Now static.
14091 (sigprocmask_set, full_mask): Remove; unused.
14092 (wait_debugging): Mark as visible.
14093 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
14094 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
14095
d4b43b22
PE
14096 * syntax.c (syntax_temp): Define only if !__GNUC__.
14097
b7c513d0
PE
14098 * sound.c (current_sound_device, current_sound): Now static.
14099
989b29ad
PE
14100 * search.c (searchbufs, searchbuf_head): Now static.
14101
13a55a78
PE
14102 * scroll.c (scroll_cost): Remove; unused.
14103 * dispextern.h (scroll_cost): Remove decl.
14104
de68a1fc
PE
14105 * region-cache.h (pp_cache): Mark as externally visible.
14106
40ccffa6
PE
14107 * process.c: Make symbols static if they're not exported.
14108 (process_tick, update_tick, create_process, chan_process):
14109 (Vprocess_alist, proc_buffered_char, datagram_access):
14110 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14111 (deactivate_process): Mark defn as static, as well as decl.
14112 * lisp.h (create_process): Remove decl.
14113 * process.h (chan_process, Vprocess_alist): Remove decls.
14114
ad64fc97
PE
14115 * print.c: Make symbols static if they're not exported.
14116 (print_depth, new_backquote_output, being_printed, print_buffer):
14117 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
14118 (print_interval, print_number_index, initial_stderr_stream):
14119 Now static.
14120 * lisp.h (Fprinc): Remove decl.
14121 (debug_output_compilation_hack): Mark as externally visible.
14122
adddb265
PE
14123 * sysdep.c (croak): Move decl from here to syssignal.h.
14124 * syssignal.h (croak): Put it here, so the API can be checked when
14125 'croak' is called from dissociate_if_controlling_tty.
14126
1717ede2
PE
14127 * minibuf.c: Make symbols static if they're not exported.
14128 (minibuf_save_list, choose_minibuf_frame): Now static.
14129 * lisp.h (choose_minibuf_frame): Remove decl.
14130
fa5fb2bc
PE
14131 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
14132
1e3890d1
PE
14133 * lread.c: Make symbols static if they're not exported.
14134 (read_objects, initial_obarray, oblookup_last_bucket_number):
14135 Now static.
14136 (make_symbol): Remove; unused.
14137 * lisp.h (initial_obarray, make_symbol): Remove decls.
14138
8a1414fa
PE
14139 * keyboard.c: Make symbols static if they're not exported.
14140 (single_kboard, recent_keys_index, total_keys, recent_keys):
14141 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
14142 (this_single_command_key_start, echoing, last_auto_save):
14143 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
14144 (command_loop, echo_now, keyboard_init_hook, help_char_p):
14145 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
14146 (Vlispy_mouse_stem, double_click_count):
14147 Now static.
14148 (force_auto_save_soon): Define only if SIGDANGER.
14149 (ignore_mouse_drag_p): Now static if
14150 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
14151 (print_help): Remove; unused.
14152 (stop_character, last_timer_event): Mark as externally visible.
14153 * keyboard.h (ignore_mouse_drag_p): Declare only if
14154 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
14155 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
14156 * lisp.h (echoing): Remove decl.
14157 (force_auto_save_soon): Declare only if SIGDANGER.
14158 * xdisp.c (redisplay_window): Simplify code, to make it more
14159 obvious that ignore_mouse_drag_p is not accessed if !defined
14160 USE_GTK && !defined HAVE_NS.
14161
93ea6e8f
PE
14162 * intervals.c: Make symbols static if they're not exported.
14163 (merge_properties_sticky, merge_interval_right, delete_interval):
14164 Now static.
14165 * intervals.h (merge_interval_right, delete_interval): Remove decls.
14166
77382fcc
PE
14167 * insdel.c: Make symbols static if they're not exported.
14168 However, leave prepare_to_modify_buffer alone. It's never
14169 called from outside this function, but that appears to be a bug.
14170 (combine_after_change_list, combine_after_change_buffer):
4889fc82 14171 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
14172 (adjust_after_replace_noundo): Remove; unused.
14173 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 14174 (signal_before_change): Remove decls.
77382fcc 14175
9306c32e
PE
14176 * indent.c (val_compute_motion, val_vmotion): Now static.
14177
cd44d2eb
PE
14178 * image.c: Make symbols static if they're not exported.
14179 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
14180 if USE_GTK.
14181 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
14182 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
14183
ad9a7a06
PE
14184 * fringe.c (standard_bitmaps): Now static.
14185 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
14186
81626931
PE
14187 * frame.c: Make symbols static if they're not exported.
14188 (x_report_frame_params, make_terminal_frame): Now static.
14189 (get_frame_param): Now static, unless HAVE_NS.
14190 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
14191 (x_get_resource_string): Remove; not used.
14192 * frame.h (make_terminal_frame, x_report_frame_params):
14193 (x_get_resource_string); Remove decls.
14194 (x_fullscreen_adjust): Declare only if WINDOWSNT.
14195 * lisp.h (get_frame_param): Declare only if HAVE_NS.
14196
239f9db9
PE
14197 * font.c, fontset.c: Make symbols static if they're not exported.
14198 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
14199 (FACE_SUITABLE_FOR_CHAR_P): Use it.
14200 * font.c (font_close_object): Now static.
14201 * font.h (font_close_object): Remove.
14202 * fontset.c (FONTSET_OBJLIST): Remove.
14203 (free_realized_fontset) #if-0 the body, which does nothing.
14204 (face_suitable_for_char_p): #if-0, as it's never called.
14205 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
14206 * xfaces.c (face_at_string_position):
14207 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
14208 since 0 is always ASCII.
14209
dfcf3579
PE
14210 * fns.c (weak_hash_tables): Now static.
14211
5045092b
PE
14212 * fileio.c: Make symbols static if they're not exported.
14213 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
14214 (Vwrite_region_annotation_buffers): Now static.
14215
57a96f5c
PE
14216 * eval.c: Make symbols static if they're not exported.
14217 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
14218 * lisp.h (backtrace_list): Remove decl.
14219
35f08c38
PE
14220 * emacs.c: Make symbols static if they're not exported.
14221 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
14222 (fatal_error_code, fatal_error_signal_hook, standard_args):
14223 Now static.
14224 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
14225 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
14226 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
14227 * lisp.h (fatal_error_signal_hook): Remove decl.
14228 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
14229
f44bd759
PE
14230 * editfns.c: Move a (normally-unused) function to its only use.
14231 * editfns.c, lisp.h (get_operating_system_release): Remove.
14232 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
14233 worth the hassle of breaking this out.
14234
b532497d
PE
14235 * xterm.c: Make symbols static if they're not exported.
14236 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
14237 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
14238 (x_destroy_window, x_delete_display):
14239 Now static.
14240 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
14241 (x_mouse_leave): Remove; unused.
14242 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
14243 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
14244 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
14245 Remove decls.
14246 (x_mouse_leave): Declare only if WINDOWSNT.
14247 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
14248 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
14249 USE_X_TOOLKIT.
14250
1675728f
PE
14251 * ftxfont.c: Make symbols static if they're not exported.
14252 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
14253 HAVE_FREETYPE.
14254 * font.h (ftxfont_driver): Likewise.
14255
e4cebfca
PE
14256 * xfns.c: Make symbols static if they're not exported.
14257 (x_last_font_name, x_display_info_for_name):
14258 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
14259 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
14260 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
14261 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
14262 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
14263 (last_show_tip_args): Now static.
14264 (xic_defaut_fontset, xic_create_fontsetname): Define only if
14265 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
14266 (x_screen_planes): Remove; unused.
14267 * dispextern.h (x_screen_planes): Remove decl.
14268
5bf46f05
PE
14269 * dispnew.c: Make symbols static if they're not exported.
14270 * dispextern.h (redraw_garbaged_frames, scrolling):
14271 (increment_row_positions): Remove.
14272 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
14273 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
14274 Now static.
14275 (redraw_garbaged_frames): Remove; unused.
14276
435f4c28
PE
14277 * xfaces.c: Make symbols static if they're not exported.
14278 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
14279 Remove decls.
14280 * xterm.h (defined_color): Remove decls.
14281 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
14282 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
14283 (menu_face_changed_default, defined_color, free_realized_face):
14284 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
14285 (ascii_face_of_lisp_face): Remove; unused.
14286
8524aef3
PE
14287 * xdisp.c: Make symbols static if they're not exported.
14288 * dispextern.h (scratch_glyph_row, window_box_edges):
14289 (glyph_to_pixel_coords, set_cursor_from_row):
14290 (get_next_display_element, set_iterator_to_next):
14291 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
14292 (show_mouse_face): Remove decls
14293 * frame.h (message_buf_print): Likewise.
14294 * lisp.h (pop_message, set_message, check_point_in_composition):
14295 Likewise.
14296 * xterm.h (set_vertical_scroll_bar): Likewise.
14297 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
14298 (message_buf_print, scratch_glyph_row, displayed_buffer):
14299 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
14300 (get_next_display_element, show_mouse_face, window_box_edges):
14301 (frame_to_window_pixel_xy, check_point_in_composition):
14302 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
14303 (glyph_to_pixel_coords): Remove; unused.
14304
16390cd2
PE
14305 * dired.c (file_name_completion): Now static.
14306
14307 * dbusbind.c (xd_in_read_queued_messages): Now static.
14308
a25f4dfa
PE
14309 * lisp.h (circular_list_error, FOREACH): Remove; unused.
14310 * data.c (circular_list_error): Remove.
14311
14a9c8df
PE
14312 * commands.h (last_point_position, last_point_position_buffer):
14313 (last_point_position_window): Remove decls.
14314 * keyboard.c: Make these variables static.
14315
04f2d78b
CB
14316 * coding.h (coding, code_convert_region, encode_coding_gap):
14317 Remove decls.
74ab6df5
PE
14318 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
14319 (iso_code_class, detect_coding, code_convert_region): Now static.
14320 (encode_coding_gap): Remove; unused.
14321
38dfbee1
PE
14322 * chartab.c (chartab_chars, chartab_bits): Now static.
14323
a2cb4e63
PE
14324 * charset.h (charset_iso_8859_1): Remove decl.
14325 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
14326 Now static.
14327
127198fd
PE
14328 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
14329 * ccl.c (Vccl_program_table): Now static.
14330 (check_ccl_update): Remove; unused.
14331
d85b608f
PE
14332 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
14333 * category.h: ... from here.
14334 * category.c (check_category_table, set_category_set): Now static.
14335
31cd66f3
PE
14336 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
14337 * lisp.h: Remove these decls.
14338
c358e587
PE
14339 * buffer.c (buffer_count): Remove unused var.
14340
e78aecca
PE
14341 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
14342 so that it's not optimized away.
14343 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
14344 * dispextern.h (bidi_dump_cached_states): Remove, since it's
14345 exported only to the debugger.
14346
e192d7d3 14347 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 14348 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 14349
92470028
PE
14350 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
14351 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
14352 was inaccessible from Lisp.
14353 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
14354 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
14355
244ed907
PE
14356 alloc.c: Import and export fewer symbols, and remove unused items.
14357 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
14358 is defined.
14359 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
14360 it's not optimized away by whole-program optimization.
14361 (message_enable_multibyte, free_misc): Remove.
14362 (catchlist, handlerlist, mark_backtrace):
14363 Declare only if BYTE_MARK_STACK.
14364 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
14365 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
14366 (message_enable_multibyte): Remove decl.
14367 (free_misc, interval_free_list, float_block, float_block_index):
14368 (n_float_blocks, float_free_list, cons_block, cons_block_index):
14369 (cons_free_list, last_marked_index):
14370 Now static.
14371 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
14372 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
14373 (mark_backtrace): Define only if BYTE_MARK_STACK.
14374 * xdisp.c (message_enable_multibyte): Now static.
14375
61c2b50e 14376 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
14377 This makes it easier for human readers (and static analyzers)
14378 to see whether these variables are used from other modules.
14379 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14380 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14381 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14382 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14383 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14384 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14385 * xmenu.c, xselect.c:
14386 Declare Q* vars static if they are not used in other modules.
14387 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14388 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14389 Remove decls of unexported vars.
14390 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14391
95c82688
PE
14392 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14393
16a97296
PE
14394 Make Emacs functions such as Fatom 'static' by default.
14395 This makes it easier for human readers (and static analyzers)
14396 to see whether these functions can be called from other modules.
14397 DEFUN now defines a static function. To make the function external
14398 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14399 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14400 (Finit_image_library):
16a97296
PE
14401 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14402 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14403 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14404 Remove decls, since these functions are now static.
14405 (Funintern, Fget_internal_run_time): New decls, since these functions
14406 were already external.
95c82688 14407
16a97296
PE
14408 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14409 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14410 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14411 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14412 * keyboard.c, keymap.c, lread.c:
14413 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14414 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14415 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14416 Mark functions with DEFUE instead of DEFUN,
14417 if they are used in other modules.
14418 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14419 decls for now-static functions.
14420 * buffer.h (Fdelete_overlay): Remove decl.
14421 * callproc.c (Fgetenv_internal): Mark as internal.
14422 * composite.c (Fremove_list_of_text_properties): Remove decl.
14423 (Fcomposition_get_gstring): New forward static decl.
14424 * composite.h (Fcomposite_get_gstring): Remove decl.
14425 * dired.c (Ffile_attributes): New forward static decl.
14426 * doc.c (Fdocumntation_property): New forward static decl.
14427 * eval.c (Ffetch_bytecode): New forward static decl.
14428 (Funintern): Remove extern decl; now in .h file where it belongs.
14429 * fileio.c (Fmake_symbolic_link): New forward static decl.
14430 * image.c (Finit_image_library): New forward static decl.
14431 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14432 * intervals.h (Fprevious_property_change):
14433 (Fremove_list_of_text_properties): Remove decls.
14434 * keyboard.c (Fthis_command_keys): Remove decl.
14435 (Fcommand_execute): New forward static decl.
14436 * keymap.c (Flookup_key): New forward static decl.
14437 (Fcopy_keymap): Now static.
14438 * keymap.h (Flookup_key): Remove decl.
14439 * process.c (Fget_process): New forward static decl.
14440 (Fprocess_datagram_address): Mark as internal.
14441 * syntax.c (Fsyntax_table_p): New forward static decl.
14442 (skip_chars): Remove duplicate decl.
14443 * textprop.c (Fprevious_property_change): New forward static decl.
14444 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14445 Now internal.
14446 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14447 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14448
785bbd42
PE
14449 * editfns.c (Fformat): Remove unreachable code.
14450
8b913b57
AS
144512011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14452
14453 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14454 change. (Bug#8496)
14455
a6744a35
EZ
144562011-04-13 Eli Zaretskii <eliz@gnu.org>
14457
14458 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14459 when at ZV. (Bug#8487)
14460
e7974947
AS
144612011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14462
baad03f0
AS
14463 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14464 (Bug#8437)
14465 * keyboard.c (parse_tool_bar_item): Likewise.
14466 * sound.c (sound_cleanup, alsa_close): Likewise.
14467 * termcap.c (tgetent): Likewise.
14468 * xfns.c (x_default_font_parameter): Likewise.
14469 * xsettings.c (read_and_apply_settings): Likewise.
14470
e7974947
AS
14471 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14472 (overrun_check_free): Protoize.
14473
28272684
PE
144742011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14475
14476 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14477 since callers should never pass a negative size.
14478 Change the signature to match that of plain 'read' and 'write'; see
14479 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14480 * lisp.h: Update prototypes of emacs_write and emacs_read.
14481
11997c76
EZ
144822011-04-11 Eli Zaretskii <eliz@gnu.org>
14483
14484 * xdisp.c (redisplay_window): Don't try to determine the character
14485 position of the scroll margin if the window start point w->startp
e896f03c 14486 is outside the buffer's accessible region. (Bug#8468)
11997c76 14487
8a2cbd72
EZ
144882011-04-10 Eli Zaretskii <eliz@gnu.org>
14489
14490 Fix write-region and its subroutines for buffers > 2GB.
14491 * fileio.c (a_write, e_write): Modify declaration of arguments and
14492 local variables to support buffers larger than 2GB.
14493 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14494
14495 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14496 argument, local variables, and return value.
14497
14498 * lisp.h: Update prototypes of emacs_write and emacs_read.
14499
14500 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14501
4073e537 145022011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14503
1ebfdcb6
PE
14504 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14505
b2ded58d
PE
14506 Fix more problems found by GCC 4.6.0's static checks.
14507
7d66342c
PE
14508 * xdisp.c (vmessage): Use a better test for character truncation.
14509
bbf47d44
PE
14510 * charset.c (load_charset_map): <, not <=, for optimization,
14511 and to avoid potential problems with integer overflow.
9248994d 14512 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14513 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14514 * editfns.c (Fformat): Likewise.
1e69125e 14515 * syntax.c (skip_chars): Likewise.
3befa583 14516
e3019616
PE
14517 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14518 This also lets GCC 4.6.0 generate slightly better loop code.
14519
becfa255
PE
14520 * callint.c (Fcall_interactively): <, not <=, for optimization.
14521 (Fcall_interactively): Count the number of arguments produced,
14522 not the number of arguments given. This is simpler and lets GCC
14523 4.6.0 generate slightly better code.
14524
dae0cd48
PE
14525 * ftfont.c: Distingish more carefully between FcChar8 and char.
14526 The previous code passed unsigned char * to a functions like
14527 strlen and xstrcasecmp that expect char *, which does not
14528 conform to the C standard.
14529 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14530 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14531 char * when the C standard requires it.
14532
76032d70
PE
14533 * keyboard.c (read_char): Remove unused var.
14534
eb3f1cc8
PE
14535 * eval.c: Port to Windows vsnprintf (Bug#8435).
14536 Include <limits.h>.
14537 (SIZE_MAX): Define if the headers do not.
14538 (verror): Do not give up if vsnprintf returns a negative count.
14539 Instead, grow the buffer. This ports to Windows vsnprintf, which
14540 does not conform to C99. Problem reported by Eli Zaretskii.
14541 Also, simplify the allocation scheme, by avoiding the need for
14542 calling realloc, and removing the ALLOCATED variable.
14543
70476b54
PE
14544 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14545
12020a9e
PE
14546 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14547 But keep the doprint source code for now, as we might revamp it
14548 and use it again (Bug#8435).
ea6c7ae6
PE
14549 * lisp.h (doprnt): Remove.
14550 * Makefile.in (base_obj): Remove doprnt.o.
14551 * deps.mk (doprnt.o): Remove.
14552
5fdb398c
PE
14553 error: Print 32- and 64-bit integers portably (Bug#8435).
14554 Without this change, on typical 64-bit hosts error ("...%d...", N)
14555 was used to print both 32- and 64-bit integers N, which relied on
14556 undefined behavior.
61bdb816 14557 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14558 * lisp.h (error, verror): Mark as printf-like functions.
14559 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14560 Report overflow in size calculations when allocating printf buffer.
14561 Do not truncate output string at its first null byte.
14562 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14563 Truncate the output at a character boundary, since vsnprintf does not
14564 do that.
14565 * charset.c (check_iso_charset_parameter): Convert internal
14566 character to string before calling 'error', since %c now has the
14567 printf meaning.
14568 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
14569 overflow when computing char to be passed to 'error'. Do not
14570 pass Lisp_Object to 'error'; pass the integer instead.
14571 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
14572 formatted with plain %d.
14573
b189fa66
PE
14574 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
14575
bff87ef0
PE
14576 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
14577
7e2cac20
PE
14578 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
14579
ce4d90b5
PE
14580 * xterm.c (x_catch_errors): Remove duplicate declaration.
14581
266c9547
PE
14582 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14583
79c49ad2
PE
14584 * xdisp.c, lisp.h (message_nolog): Remove; unused.
14585
368f4090
JM
145862011-04-10 Jim Meyering <meyering@redhat.com>
14587
14588 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
14589 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
14590 return ssize_t not "int", and use size_t as the buffer length.
14591 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
14592 * gnutls.h: Update declarations.
14593 * process.c (read_process_output): Use ssize_t, to match.
14594 (send_process): Likewise.
14595
a32d4040
CY
145962011-04-09 Chong Yidong <cyd@stupidchicken.com>
14597
14598 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14599
8546720e 146002011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14601
04f2d78b
CB
14602 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14603 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14604
8546720e
GM
14605 * xterm.c (handle_one_xevent):
14606 * xmenu.c (create_and_show_popup_menu):
14607 * xselect.c (x_decline_selection_request)
14608 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14609
0a2f5c1a 146102011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14611
14612 Fix some uses of `int' instead of EMACS_INT.
14613 * search.c (string_match_1, fast_string_match)
14614 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14615 (scan_buffer, find_next_newline_no_quit)
14616 (find_before_next_newline, search_command, Freplace_match)
14617 (Fmatch_data): Make some `int' variables be EMACS_INT.
14618
14619 * xdisp.c (display_count_lines): 3rd argument and return value now
14620 EMACS_INT. All callers changed.
14621 (pint2hrstr): Last argument is now EMACS_INT.
14622
14623 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14624 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14625 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14626 (decode_coding_utf_16, decode_coding_emacs_mule)
14627 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14628 (decode_coding_ccl, decode_coding_charset)
14629 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14630 (decode_coding_iso_2022, decode_coding_emacs_mule)
14631 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14632 <char_offset, last_offset>: Declare EMACS_INT.
14633 (encode_coding_utf_8, encode_coding_utf_16)
14634 (encode_coding_emacs_mule, encode_invocation_designation)
14635 (encode_designation_at_bol, encode_coding_iso_2022)
14636 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14637 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14638 Declare EMACS_INT.
14639 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14640 (encode_invocation_designation): Last argument P_NCHARS is now
14641 EMACS_INT.
14642 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14643 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14644
14645 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14646 All users changed.
14647
14648 * ccl.c (Fccl_execute_on_string): Declare some variables
14649 EMACS_INT.
14650
8546720e 146512011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14652
14653 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14654
4e19a977
CS
146552011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14656
14657 * process.c (Fformat_network_address): Doc fix.
14658
87302331
R
146592011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14660
ee7683eb 14661 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14662
cbb59342
CY
146632011-04-08 Chong Yidong <cyd@stupidchicken.com>
14664
14665 * keyboard.c (read_char): Call Lisp function help-form-show,
14666 instead of using internal_with_output_to_temp_buffer.
14667 (Qhelp_form_show): New var.
e0d38eeb 14668 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14669
14670 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14671
14672 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14673
e67a13ab
CY
146742011-04-06 Chong Yidong <cyd@stupidchicken.com>
14675
04f2d78b
CB
14676 * process.c (Flist_processes): Remove to Lisp.
14677 (list_processes_1): Delete.
e67a13ab 14678
973f782d
EZ
146792011-04-06 Eli Zaretskii <eliz@gnu.org>
14680
7c106b1e
EZ
14681 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14682
973f782d
EZ
14683 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14684
41cf7d1a 146852011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14686
ca23cc88
PE
14687 Fix more problems found by GCC 4.6.0's static checks.
14688
f390e2d5
PE
14689 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14690
42eea0d0
PE
14691 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14692
b69769da 14693 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14694
f9541e84
PE
14695 * xdisp.c (vmessage): Mark as a printf-like function.
14696
13841b55
PE
14697 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14698
c136c10f
PE
14699 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14700
5e2d4a30
PE
14701 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14702 printf-like functions.
14703 (tiff_load): Add casts to remove these marks before passing them
14704 to system-supplied API.
14705
583f48b9
PE
14706 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14707
b25d760e
PE
14708 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14709 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14710 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14711 directly, rather than having caller test rule sign. This avoids
14712 some unnecessary tests.
14713 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14714 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14715 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14716
bc7b6697 14717 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14718 (xfont_open): Avoid unnecessary tests.
bc7b6697 14719
27ccc379
PE
14720 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14721
dcd5c89a
PE
14722 * composite.h, composite.c (composition_gstring_put_cache):
14723 Use EMACS_INT, not int, for length.
14724
b13a45c6
PE
14725 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14726 breaking out part of COMPOSITION_DECODE_RULE.
14727 (COMPOSITION_DECODE_RULE): Use it.
14728 * composite.c (get_composition_id): Remove unused local vars,
14729 by using the new macro.
14730
1e792e4d
PE
14731 * textprop.c (set_text_properties_1): Change while to do-while,
14732 since the condition is always true at first.
14733
dc6c6455 14734 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14735 (interval_deletion_adjustment): Return unsigned value.
14736 All uses changed.
dc6c6455 14737
aba7731a
PE
14738 * process.c (list_processes_1, create_pty, read_process_output):
14739 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14740 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14741 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14742 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14743 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14744
fdfc4bf3
PE
14745 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14746
fca8fe46 14747 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14748 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14749
06a0259a 14750 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14751 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14752 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14753
e7b9e80f
PE
14754 * print.c (print_error_message): Avoid int overflow.
14755
56201685
PE
14756 * font.c (font_list_entities): Redo for clarity,
14757 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14758
78834453 14759 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14760 (font_score): Avoid potential overflow in diff calculation.
78834453 14761
0bc0b309 14762 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14763 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14764
e610eaca
PE
14765 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14766
b895abce
PE
14767 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14768 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14769 can always succeed if overflow has undefined behavior.
14770
1f1d9321 14771 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14772 (wordify): Omit three unnecessary tests.
1f1d9321 14773
c59478bc
PE
14774 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14775 All callers changed. This avoids the need for an unused var.
14776
79b73827
PE
14777 * casefiddle.c (casify_region): Remove var that is set but not used.
14778
a4db5dfe
PE
14779 * dired.c (file_name_completion): Remove var that is set but not used.
14780
43aae36e
PE
14781 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14782
2a47c44d 14783 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14784 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14785
a37c69bf
PE
14786 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14787 Check for integer overflow on size calculations.
14788
328ab8e7
PE
14789 * buffer.c (Fprevious_overlay_change): Remove var that is set
14790 but not used.
14791
e5a2a5cb
PE
14792 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14793 Remove vars that are set but not used.
8d84a6eb 14794 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14795 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14796
a60e5f68
PE
14797 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14798
f661cb61 14799 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14800 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14801
f0397f5a
PE
14802 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14803 that are set but not used.
14804
8664db06 14805 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14806 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14807
6abdaa4a
PE
14808 * xselect.c (x_get_local_selection, x_handle_property_notify):
14809 Remove vars that are set but not used.
14810
0ce7538d 14811 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14812 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14813
9ae848fc
PE
14814 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14815 Remove var that is set but not used.
0b918413
PE
14816 (scroll_bar_windows_size): Now size_t, not int.
14817 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14818 Check for overflow.
9ae848fc 14819
a5a62657
PE
14820 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14821 (map_tty_color) [!defined MSDOS]: Likewise.
14822
5c5cdd39
PE
14823 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14824
66ebf983
PE
14825 * coding.c: Remove vars that are set but not used.
14826 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14827 All callers changed.
14828 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14829 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14830 (decode_coding_charset): Remove vars that are set but not used.
14831
1be4d761
PE
14832 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14833 that is set but not used.
14834
47553fa8
PE
14835 * print.c (print_object): Remove var that is set but not used.
14836
1f7196bf 14837 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14838 The gnulib version avoids calling malloc in the usual case,
14839 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14840 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14841 * filelock.c (current_lock_owner): Likewise.
14842 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14843 * sysdep.c: Include allocator.h, careadlinkat.h.
14844 (emacs_no_realloc_allocator): New static constant.
14845 (emacs_readlink): New function.
fdb61804
PE
14846 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14847 ../lib/careadlinkat.h.
d1fdcab7 14848
f84c17c7
SM
148492011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14850
14851 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14852 first non-nil return value).
14853
ef3862ad
JD
148542011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14855
14856 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14857 if not defined (Bug#8403).
14858
376a7006
JB
148592011-04-02 Juanma Barranquero <lekktu@gmail.com>
14860
14861 * xdisp.c (display_count_lines): Remove parameter `start',
14862 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14863 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14864 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14865 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14866 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14867 and thereabouts. All callers changed.
14868 (get_per_char_metric): Remove parameter `f', unused since
14869 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14870
6ca3801d
JM
148712011-04-02 Jim Meyering <meyering@redhat.com>
14872
14873 do not dereference NULL upon failed strdup
14874 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14875 (ns_get_family): Likewise.
14876
d8e2b5ba
JB
148772011-04-02 Juanma Barranquero <lekktu@gmail.com>
14878
14879 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14880
8c74fcbd
JD
148812011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14882
14883 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14884 later (Bug#8403).
14885
7200d79c
SM
148862011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14887
03408648 14888 Add lexical binding.
7200d79c 14889
03408648
SM
14890 * window.c (Ftemp_output_buffer_show): New fun.
14891 (Fsave_window_excursion):
14892 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14893
14894 * lread.c (lisp_file_lexically_bound_p): New function.
14895 (Fload): Bind Qlexical_binding.
14896 (readevalloop): Remove `evalfun' arg.
14897 Bind Qinternal_interpreter_environment.
14898 (Feval_buffer): Bind Qlexical_binding.
14899 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14900 Mark as dynamic.
14901 (syms_of_lread): Declare `lexical-binding'.
14902
14903 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14904
14905 * keyboard.c (eval_dyn): New fun.
14906 (menu_item_eval_property): Use it.
ca105506
SM
14907
14908 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14909
03408648
SM
14910 * fns.c (concat, mapcar1): Accept byte-code-functions.
14911
14912 * eval.c (Fsetq): Handle lexical vars.
14913 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14914 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14915 (FletX, Flet): Obey lexical binding.
14916 (Fcommandp): Handle closures.
14917 (Feval): New `lexical' arg.
14918 (eval_sub): New function extracted from Feval. Use it almost
14919 everywhere where Feval was used. Look up vars in lexical env.
14920 Handle closures.
14921 (Ffunctionp): Move from subr.el.
14922 (Ffuncall): Handle closures.
14923 (apply_lambda): Remove `eval_flags'.
14924 (funcall_lambda): Handle closures and new byte-code-functions.
14925 (Fspecial_variable_p): New function.
14926 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14927 but without exporting it to Lisp.
23aba0ea 14928
23aba0ea 14929 * doc.c (Fdocumentation, store_function_docstring):
03408648 14930 * data.c (Finteractive_form): Handle closures.
23aba0ea 14931
03408648
SM
14932 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14933 interactive spec.
ba83908c 14934
04f2d78b
CB
14935 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14936 New byte-codes.
03408648
SM
14937 (exec_byte_code): New function extracted from Fbyte_code to handle new
14938 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14939
03408648 14940 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14941
03408648 14942 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14943
e2abce01
JB
149442011-03-31 Juanma Barranquero <lekktu@gmail.com>
14945
14946 * xdisp.c (redisplay_internal): Fix prototype.
14947
63696a73 149482011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14949
63696a73 14950 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14951 (try_scrolling): Use it when setting scroll_limit.
14952 Limit scrolling to 100 screen lines.
63696a73
EZ
14953 (redisplay_window): Even when falling back on "recentering",
14954 position point in the window according to scroll-conservatively,
14955 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14956
14957 (try_scrolling): When point is above the window, allow searching
14958 as far as scroll_max, or one screenful, to compute vertical
14959 distance from PT to the scroll margin position. This prevents
14960 try_scrolling from unnecessarily failing when
14961 scroll-conservatively is set to a value slightly larger than the
14962 window height. Clean up the case of PT below the margin at bottom
14963 of window: scroll_max can no longer be INT_MAX. When aggressive
14964 scrolling is in use, don't let point enter the opposite scroll
14965 margin as result of the scroll.
14966 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14967 threshold of 100 lines for never-recentering scrolling.
14968
e4cc2dfc
JB
149692011-03-31 Juanma Barranquero <lekktu@gmail.com>
14970
14971 * dispextern.h (move_it_by_lines):
14972 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14973 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14974 (message_log_check_duplicate): Remove parameters `prev_bol' and
14975 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14976 (redisplay_internal): Remove parameter `preserve_echo_area',
14977 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14978
14979 * indent.c (Fvertical_motion):
14980 * window.c (window_scroll_pixel_based, Frecenter):
14981 Don't pass `need_y_p' to `move_it_by_lines'.
14982
1c470562
SM
149832011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14984
44f230aa
SM
14985 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14986 steal a few bits to be more compact.
14987 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14988 Remove unneeded casts.
14989
1c470562
SM
14990 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14991
888adce9
ZK
149922011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14993
14994 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14995 binding" message (bug#7967).
14996
f838ed7b
PE
149972011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14998
77861b95
PE
14999 Fix more problems found by GCC 4.6.0's static checks.
15000
de6dbc14
PE
15001 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
15002 Remove unused local var.
15003
f838ed7b
PE
15004 * editfns.c (Fmessage_box): Remove unused local var.
15005
792c7b2b
PE
15006 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
15007 (note_mode_line_or_margin_highlight, note_mouse_highlight):
15008 Omit unused local vars.
c499e557 15009 * window.c (shrink_windows): Omit unused local var.
b01a1c29 15010 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
15011 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
15012 Omit unused local var.
15013
ba0165e1
PE
15014 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
15015 Don't assume string length fits in int.
32ad8845 15016 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 15017 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 15018
3c59b4c9
PE
15019 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
15020 instead of alloca (Bug#8344).
15021
a3eed478 15022 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 15023 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 15024
eb4d412d
PE
15025 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
15026
1658b401
PE
15027 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
15028 concerns.
15029
15030 * term.c (produce_glyphless_glyph): Remove unnecessary test.
15031
15032 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 15033
9a2c6e05
PE
15034 * keyboard.c (syms_of_keyboard): Use the same style as later
15035 in this function when indexing through an array. This also
15036 works around GCC bug 48267.
15037
03d0a109
PE
15038 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
15039
44f730c8
PE
15040 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
15041
fe75f926
PE
15042 * chartab.c (sub_char_table_ref_and_range): Redo for slight
15043 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
15044
ffa8c828
PE
15045 * keyboard.c, keyboard.h (num_input_events): Now size_t.
15046 This avoids undefined behavior on integer overflow, and is a bit
15047 more convenient anyway since it is compared to a size_t variable.
15048
c5101a77
PE
15049 Variadic C functions now count arguments with size_t, not int.
15050 This avoids an unnecessary limitation on 64-bit machines, which
15051 caused (substring ...) to crash on large vectors (Bug#8344).
15052 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
15053 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 15054 All variadic functions and their callers changed accordingly.
c5101a77
PE
15055 (struct gcpro.nvars): Now size_t, not int. All uses changed.
15056 * data.c (arith_driver, float_arith_driver): Likewise.
15057 * editfns.c (general_insert_function): Likewise.
15058 * eval.c (struct backtrace.nargs, interactive_p)
15059 (internal_condition_case_n, run_hook_with_args, apply_lambda)
15060 (funcall_lambda, mark_backtrace): Likewise.
15061 * fns.c (concat): Likewise.
15062 * frame.c (x_set_frame_parameters): Likewise.
15063 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
15064 0 if not found, not -1. All callers changed.
15065
dd3f25f7
PE
15066 * alloc.c (garbage_collect): Don't assume stack size fits in int.
15067 (stack_copy_size): Now size_t, not int.
15068 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
15069
461c2ab9
JB
150702011-03-28 Juanma Barranquero <lekktu@gmail.com>
15071
15072 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
15073 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15074 All callers changed.
15075
15076 * lisp.h (multibyte_char_to_unibyte):
15077 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
15078 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15079 * character.h (CHAR_TO_BYTE8):
15080 * cmds.c (internal_self_insert):
15081 * editfns.c (general_insert_function):
15082 * keymap.c (push_key_description):
15083 * search.c (Freplace_match):
15084 * xdisp.c (message_dolog, set_message_1): All callers changed.
15085
f6d62986
SM
150862011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15087
15088 * keyboard.c (safe_run_hook_funcall): New function.
15089 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
15090 don't set the hook to nil, but remove the offending function instead.
15091 (Qcommand_hook_internal): Remove, unused.
15092 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
15093 Vcommand_hook_internal.
15094
15095 * eval.c (enum run_hooks_condition): Remove.
15096 (funcall_nil, funcall_not): New functions.
15097 (run_hook_with_args): Call each function through a `funcall' argument.
15098 Remove `cond' argument, now redundant.
15099 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
15100 (Frun_hook_with_args_until_failure): Adjust accordingly.
15101 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
15102
1db5b1ad
JB
151032011-03-28 Juanma Barranquero <lekktu@gmail.com>
15104
15105 * dispextern.h (string_buffer_position): Remove declaration.
15106
15107 * print.c (strout): Remove parameter `multibyte', unused since
15108 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
15109
15110 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
15111 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
15112 All callers changed.
15113
15114 * w32.c (_wsa_errlist): Use braces for struct initializers.
15115
15116 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
15117 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
15118 All callers changed.
15119 (string_buffer_position): Likewise. Also, make static (it's never
15120 used outside xdisp.c).
15121 (cursor_row_p): Remove parameter `w', unused since
15122 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
15123 (decode_mode_spec): Remove parameter `precision', introduced during
15124 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
15125 All callers changed.
15126
5ffb62aa
JD
151272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15128
15129 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
15130
461c2ab9 151312011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
15132
15133 * nsterm.m (ns_menu_bar_is_hidden): New variable.
15134 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
15135 (ns_update_auto_hide_menu_bar): New functions.
15136 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
15137 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
15138 ns_constrain_all_frames.
15139 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
15140 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
15141
5c380ffb
JD
151422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15143
15144 * nsmenu.m (runDialogAt): Remove argument to timer_check.
15145
9af30bdf
GM
151462011-03-27 Glenn Morris <rgm@gnu.org>
15147
15148 * syssignal.h: Replace RETSIGTYPE with void.
15149 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
15150 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
15151 Replace SIGTYPE with void everywhere.
15152 * s/usg5-4-common.h (SIGTYPE): Remove definition.
15153 * s/template.h (SIGTYPE): Remove commented out definition.
15154
e2abce01
JB
151552011-03-26 Eli Zaretskii <eliz@gnu.org>
15156
15157 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
15158 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
15159
f868cd8a
JB
151602011-03-26 Juanma Barranquero <lekktu@gmail.com>
15161
59eb0929
JB
15162 * w32.c (read_unc_volume): Use parameter `henum', instead of
15163 global variable `wget_enum_handle'.
15164
15165 * keymap.c (describe_vector): Remove parameters `indices' and
15166 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
15167 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
15168
f868cd8a
JB
15169 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
15170
15171 * keyboard.c (timer_check): Remove parameter `do_it_now',
15172 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
15173 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
15174 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
15175
15176 * keyboard.c (read_char):
15177 * w32menu.c (w32_menu_display_help):
15178 * xmenu.c (show_help_event, menu_help_callback):
15179 Adjust calls to `show_help_echo'.
15180
15181 * gtkutil.c (xg_maybe_add_timer):
15182 * keyboard.c (readable_events):
15183 * process.c (wait_reading_process_output):
15184 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
15185
15186 * insdel.c (adjust_markers_gap_motion):
15187 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
15188 (gap_left, gap_right): Don't call it.
15189
2ecf6fdb
CY
151902011-03-25 Chong Yidong <cyd@stupidchicken.com>
15191
15192 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
15193 incurred during fontification.
15194
6b1f9ba4
JB
151952011-03-25 Juanma Barranquero <lekktu@gmail.com>
15196
15197 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
15198 (DEFVAR_PER_BUFFER): Don't pass it.
15199
15200 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
15201 (scrolling_window): Don't pass it.
15202
0f4a96b5
JB
152032011-03-25 Juanma Barranquero <lekktu@gmail.com>
15204
15205 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
15206
15207 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
15208 and `suffix'.
15209 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
15210 of variables specific to SELinux and computation of `encoded_absname'.
15211
15212 * image.c (XPutPixel): Remove unused variable `height'.
15213
15214 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
15215
15216 * unexw32.c (get_section_info): Remove unused variable `section'.
15217
15218 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
15219 (system_process_attributes): Remove unused variable `sess'.
15220 (sys_read): Remove unused variable `err'.
15221
15222 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
15223 (w32_wnd_proc): Remove unused variable `isdead'.
15224 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
15225 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
15226 (x_create_tip_frame): Remove unused variable `tem'.
15227
15228 * w32inevt.c (w32_console_read_socket):
15229 Remove unused variable `no_events'.
15230
15231 * w32term.c (x_draw_composite_glyph_string_foreground):
15232 Remove unused variable `width'.
15233
1149507c
JB
152342011-03-24 Juanma Barranquero <lekktu@gmail.com>
15235
15236 * w32term.c (x_set_glyph_string_clipping):
15237 Don't pass uninitialized region to CombineRgn.
15238
9c88f339
JB
152392011-03-23 Juanma Barranquero <lekktu@gmail.com>
15240
15241 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
15242 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
15243 (Fx_close_connection): Remove unused variable `i'.
15244
15245 * w32font.c (w32font_draw): Return number of glyphs.
15246 (w32font_open_internal): Remove unused variable `i'.
15247 (w32font_driver): Add missing initializer.
15248
15249 * w32menu.c (utf8to16): Remove unused variable `utf16'.
15250 (fill_in_menu): Remove unused variable `items_added'.
15251
15252 * w32term.c (last_mouse_press_frame): Remove static global variable.
15253 (w32_clip_to_row): Remove unused variable `f'.
15254 (x_delete_terminal): Remove unused variable `i'.
15255
15256 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
15257 (NOTHING): Remove unused static global variable.
15258 (uniscribe_check_otf): Remove unused variable `table'.
15259 (uniscribe_font_driver): Add missing initializers.
15260
dee091a3
JD
152612011-03-23 Julien Danjou <julien@danjou.info>
15262
15263 * term.c (Fsuspend_tty, Fresume_tty):
15264 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
15265 * window.c (temp_output_buffer_show):
15266 * insdel.c (signal_before_change):
15267 * frame.c (Fhandle_switch_frame):
15268 * fileio.c (Fdo_auto_save):
15269 * emacs.c (Fkill_emacs):
15270 * editfns.c (save_excursion_restore):
15271 * cmds.c (internal_self_insert):
15272 * callint.c (Fcall_interactively):
15273 * buffer.c (Fkill_all_local_variables):
15274 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
15275 Use Frun_hooks.
0f4a96b5 15276 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 15277 unconditionally since it does the check itself.
dee091a3 15278
2c520ab5 152792011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 15280
c9c49752
PE
15281 Fix more problems found by GCC 4.5.2's static checks.
15282
8abc3f12
PE
15283 * coding.c (encode_coding_raw_text): Avoid unnecessary test
15284 the first time through the loop, since we know p0 < p1 then.
15285 This also avoids a gcc -Wstrict-overflow warning.
15286
a2d26660
PE
15287 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
15288 leading to a memory leak, possible in functions like
15289 load_charset_map_from_file that can allocate an unbounded number
b12ef411 15290 of objects (Bug#8318).
a2d26660 15291
916c72e9
PE
15292 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
15293 that could (at least in theory) be that large.
15294
19ab8a18
PE
15295 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
15296 This is less likely to overflow, and avoids undefined behavior if
15297 overflow does occur. All callers changed. Use strtoul to scan
15298 for the unsigned long integer.
b7cbbd6f
PE
15299 (pint2hrstr): Simplify and tune code slightly.
15300 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 15301
f0641eff
PE
15302 * scroll.c (do_scrolling): Work around GCC bug 48228.
15303 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
15304
7f650bb9
PE
15305 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
15306 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
15307 (validate_x_resource_name): Simplify count usage.
15308 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 15309
37dd57d1
PE
15310 * fileio.c (Fcopy_file): Report error if fchown or fchmod
15311 fail (Bug#8306).
81e56e61 15312
699979fc 15313 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 15314
401bf9b4
PE
15315 * process.c (Fmake_network_process): Use socklen_t, not int,
15316 where POSIX says socklen_t is required in portable programs.
15317 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 15318 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
15319 (Fmake_network_process, server_accept_connection):
15320 (wait_reading_process_output, read_process_output):
15321 Likewise.
15322
b93aacde
PE
15323 * process.c: Rename or move locals to avoid shadowing.
15324 (list_processes_1, Fmake_network_process):
15325 (read_process_output_error_handler, exec_sentinel_error_handler):
15326 Rename or move locals.
4dc343ee 15327 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 15328 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 15329 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 15330 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 15331 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 15332
af8a867c 15333 Make tparam.h and terminfo.c consistent.
44f230aa
SM
15334 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
15335 Include tparam.h instead, since it declares them.
af8a867c
PE
15336 * cm.h (PC): Remove extern decl; tparam.h now does this.
15337 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
15338 * terminfo.c: Include tparam.h, to check interfaces.
15339 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
15340 (tparam): Adjust signature to match interface in tparam.h;
15341 this removes some undefined behavior. Check that outstring and len
15342 are zero, which they always are with Emacs.
15343 * tparam.h (PC, BC, UP): New extern decls.
15344
0248044d 15345 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 15346 (xftfont_open): Rename locals to avoid shadowing.
0248044d 15347
8ff096c1 15348 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
15349 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
15350 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 15351 (ftfont_list): Remove unused local.
49eaafba
PE
15352 (get_adstyle_property, ftfont_pattern_entity):
15353 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
15354 Rename locals to avoid shadowing.
8ff096c1 15355
e2be39f6
PE
15356 * xfont.c (xfont_list_family): Mark var as initialized.
15357
c9735e30
PE
15358 * xml.c (make_dom): Now static.
15359
8f5201ae
PE
15360 * composite.c (composition_compute_stop_pos): Rename local to
15361 avoid shadowing.
b246f932
PE
15362 (composition_reseat_it): Remove unused locals.
15363 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 15364 (composition_update_it): Mark var as initialized.
11b61122
PE
15365 (find_automatic_composition): Mark vars as initialized,
15366 with a FIXME (Bug#8290).
8f5201ae 15367
760fbc2c
PE
15368 character.h: Rename locals to avoid shadowing.
15369 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
15370 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
15371 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
15372 (BUF_DEC_POS): Be more systematic about renaming local temporaries
15373 to avoid shadowing.
15374
ff08eb85
PE
15375 * textprop.c (property_change_between_p): Remove; unused.
15376
fc7bf025
PE
15377 * intervals.c (interval_start_pos): Now static.
15378
235d7abc
PE
15379 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15380
44f230aa
SM
15381 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15382 Rename locals to avoid shadowing.
3e7d6594 15383
50060332
PE
15384 * sound.c (wav_play, au_play, Fplay_sound_internal):
15385 Fix pointer signedness.
d01f234b 15386 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15387 (wav_play): Initialize a variable to 0, to prevent undefined
15388 behavior (Bug#8278).
50060332 15389
c4fc4e30
PE
15390 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15391
918436ed
PE
15392 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15393
c939f91b
PE
15394 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15395 clobbering (Bug#8298).
b9c7f648
PE
15396 * sysdep.c (sys_subshell): Likewise.
15397 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15398
6bd8c144
PE
15399 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15400 This should get cleaned up, so that child_setup has the
15401 same signature on all platforms.
15402
7710357c 15403 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15404 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15405
c59da222
CY
154062011-03-22 Chong Yidong <cyd@stupidchicken.com>
15407
15408 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15409 not to be necessary, and produces flickering.
15410
66b87493
GM
154112011-03-20 Glenn Morris <rgm@gnu.org>
15412
15413 * config.in: Remove file.
15414
45b6f6d5
JB
154152011-03-20 Juanma Barranquero <lekktu@gmail.com>
15416
15417 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15418 are now in src/globals.h.
15419 (syms_of_minibuf): Remove spurious & from previous change.
15420
cd394be1 154212011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15422
15423 * minibuf.c (completing-read-function): New variable.
15424 (completing-read-default): Rename from completing-read.
15425 (completing-read): Call completing-read-function.
15426
b14e3e21
CY
154272011-03-19 Juanma Barranquero <lekktu@gmail.com>
15428
15429 * xfaces.c (Fx_load_color_file):
15430 Read color file from absolute filename (bug#8250).
15431
f2b726e6
JB
154322011-03-19 Juanma Barranquero <lekktu@gmail.com>
15433
15434 * makefile.w32-in: Update dependencies.
15435
09f6ff02
EZ
154362011-03-17 Eli Zaretskii <eliz@gnu.org>
15437
15438 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15439
29a6015a
PE
154402011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15441
a3a6c54e
PE
15442 Fix more problems found by GCC 4.5.2's static checks.
15443
b766f867
PE
15444 * process.c (make_serial_process_unwind, send_process_trap):
15445 (sigchld_handler): Now static.
15446
be02381c
PE
15447 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15448 That way, the code declares only the vars that it needs.
15449 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15450 * s/cygwin.h (PTY_ITERATION): Likewise.
15451 * s/darwin.h (PTY_ITERATION): Likewise.
15452 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15453
57048744
PE
15454 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15455 * process.c (allocate_pty): Don't declare stb unless it's needed.
15456
7914961c 15457 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15458 (CONSTANTLIM): Remove; unused.
15459 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15460 Define only if needed.
7914961c 15461
b3967b18
PE
15462 * unexelf.c (unexec): Name an expression,
15463 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15464 Use a different way to cause a compilation error if anyone uses
15465 n rather than nn, a way that does not involve shadowing.
73366a00 15466 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15467
29a6015a
PE
15468 * deps.mk (unexalpha.o): Remove; unused.
15469
43cfc33e 15470 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15471 * unexec.h: New file.
ce701a33
PE
15472 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15473 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15474 Depend on unexec.h.
15475 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15476 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15477 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15478 Change as necessary to match prototype in unexec.h.
ce701a33 15479
01f44d5a
PE
15480 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15481 shadowing.
4f63c6bb 15482 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15483
a6670b0b
PE
15484 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15485 Rename locals to avoid shadowing.
15486
cef2010d 15487 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15488 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15489
d4d7173a
PE
15490 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15491
f08b802a
PE
15492 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15493 warning when compiling print.c.
15494
3ddb0639
PE
15495 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15496 instead of using an uninitialized var.
5ad03b97 15497 (font_sort_entities): Mark var as initialized.
3ddb0639 15498
170a2692
PE
15499 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15500
e663c700
PE
15501 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15502 pointers to constants.
89bc529a 15503 (font_parse_fcname): Remove unused vars.
7b81e2d0 15504 (font_delete_unmatched): Now static.
ea838e10 15505 (font_get_spec): Remove; unused.
13a547c6
PE
15506 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15507 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15508 Rename or move locals to avoid shadowing.
e663c700 15509
2a80c887 15510 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15511 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15512
1384fa33 15513 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15514 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15515
8b2c52e9
PE
15516 * alloc.c (mark_backtrace): Move decl from here ...
15517 * lisp.h: ... to here, so that it can be checked.
15518
475545b5 15519 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15520 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15521 (lisp_indirect_variable): Name an expression,
15522 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15523 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15524
b1349114 15525 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15526 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15527 Use const pointer when appropriate.
b1349114 15528
a2928364
PE
15529 * lisp.h (get_system_name, get_operating_system_release):
15530 Move decls here, to check interfaces.
15531 * process.c (get_operating_system_release): Move decl to lisp.h.
15532 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15533 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15534 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15535 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15536 (Fformat_time_string, Fencode_time, Finsert_char):
15537 (Ftranslate_region_internal, Fformat):
15538 Rename or remove local vars to avoid shadowing.
9710023e 15539 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15540
a415e694
PE
15541 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15542 avoid shadowing.
15543
8ef4622d
PE
15544 * lisp.h (eassert): Check that the argument compiles, even if
15545 ENABLE_CHECKING is not defined.
15546
946f9a5b
PE
15547 * data.c (Findirect_variable): Name an expression, to avoid
15548 gcc -Wbad-function-cast warning.
112396d6 15549 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15550 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15551 (Fmake_variable_buffer_local, Fmake_local_variable):
15552 Mark variables as initialized.
52746918 15553 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15554
e5aab7e7 15555 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15556 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15557 Rename locals to avoid shadowing.
dff45157
PE
15558 (mark_stack): Move local variables into the #ifdef region where
15559 they're used.
7bc26fdb
PE
15560 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15561 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15562 needed otherwise.
15563 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15564 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15565 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15566
e5aab7e7
PE
15567 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15568 avoids undefined behavior in theory.
15569
4da60324
PE
15570 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
15571
88043301
PE
15572 Use functions, not macros, for up- and down-casing (Bug#8254).
15573 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15574 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
15575 to use the following functions instead of these macros.
15576 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
15577 EMACS_INT, since callers assume the returned value fits in int.
15578 (upcase1): Likewise, for UPCASE_TABLE.
15579 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 15580 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 15581 the race-condition problem in the old DOWNCASE.
88043301 15582
19ed5445
PE
15583 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
15584 Rename locals to avoid shadowing.
15585 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
15586 (regex_compile, re_search_2, re_match_2_internal):
15587 Remove unused local vars.
952db0d7
PE
15588 (FREE_VAR): Rewrite so as not to use empty "else",
15589 which gcc can warn about.
da053e48 15590 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
15591 (RETALLOC_IF): Define only if needed.
15592 (WORDCHAR_P): Likewise. This one is never needed, but is used
15593 only in a comment talking about a compiler bug, so put inside
15594 the #if 0 of that comment.
15595 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
15596 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
15597 Remove; unused.
19ed5445 15598
1f3561e4 15599 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15600 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15601 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15602
ded6f8f7
PE
15603 * search.c (simple_search): Remove unused var.
15604
dbd37a95
PE
15605 * dired.c (compile_pattern): Move decl from here ...
15606 * lisp.h: ... to here, so that it can be checked.
15607 (struct re_registers): New forward decl.
15608
7e47afad
PE
15609 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15610
85f24f61
PE
15611 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15612 All uses changed.
15613 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15614 Rename locals to avoid shadowing.
5671df8f 15615 (Fvertical_motion): Mark locals as initialized.
85f24f61 15616
181aa2be 15617 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15618 (casify_region): Mark local as initialized.
181aa2be 15619
930d429c
PE
15620 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15621
7082eac6
PE
15622 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15623 New macros, so that the caller can use some names other than
15624 gcpro1, gcpro2, etc.
15625 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15626 of the new macros.
15627 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15628 argument, for consistency with GCPRO2_VAR, etc: it is now the
15629 prefix of the variable, not the variable itself. All uses
15630 changed.
38b2c076
PE
15631 * dired.c (directory_files_internal, file_name_completion):
15632 Rename locals to avoid shadowing.
15633
15206ed9
PE
15634 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15635 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15636 dired.c's scmp function, had undefined behavior.
15637 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15638 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15639 * buffer.h: ... to here, because these macros use current_buffer,
15640 and the new implementation with inline functions needs to have
15641 current_buffer in scope now, rather than later when the macros
15642 are used.
15643 (downcase, upcase1): New static inline functions.
15644 (DOWNCASE, UPCASE1): Reimplement using these functions.
15645 This avoids undefined behavior in expressions like
15646 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15647 from race conditions in accessing the global variables
15648 case_temp1 and case_temp2.
15649 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15650 * lisp.h (case_temp1, case_temp2): Remove their decls.
15651 * character.h (ASCII_CHAR_P): Move from here ...
15652 * lisp.h: ... to here, so that the inline functions mentioned
15653 above can use them.
15654
4a6bea26
PE
15655 * dired.c (directory_files_internal_unwind): Now static.
15656
f14b7e14
PE
15657 * fileio.c (file_name_as_directory, directory_file_name):
15658 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15659 Now static.
2893f146
PE
15660 (file_name_as_directory): Use const pointers when appropriate.
15661 (Fexpand_file_name): Likewise. In particular, newdir might
15662 point at constant storage, so make it a const pointer.
fd4ead52 15663 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15664 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15665 signedness issues.
f839df0c
PE
15666 (Fset_file_times, Finsert_file_contents, auto_save_error):
15667 Rename locals to avoid shadowing.
f14b7e14 15668
5716756e 15669 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15670 (Ftry_completion, Fall_completions): Rename or remove locals
15671 to avoid shadowing.
5716756e 15672
b4c3046a
PE
15673 * marker.c (bytepos_to_charpos): Remove; unused.
15674
b45db522
PE
15675 * lisp.h (verify_bytepos, count_markers): New decls,
15676 so that gcc does not warn that these functions aren't declared.
15677
85876d07
PE
15678 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15679 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15680 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15681 (copy_text): Remove unused local var.
85876d07 15682
03d78a21 15683 * filelock.c (within_one_second): Now static.
b3dd38ab 15684 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15685
5df8f01b
PE
15686 * buffer.c (fix_overlays_before): Mark locals as initialized.
15687 (fix_start_end_in_overlays): Likewise. This function should be
15688 simplified by using pointers-to-pointers, but that's a different
15689 matter.
b1d876f1 15690 (switch_to_buffer_1): Now static.
8f54f30a
PE
15691 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15692 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15693
a70072c9 15694 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15695 Fix pointer signedness issue.
edced198
PE
15696 (sys_subshell): Mark local as volatile if checking for lint,
15697 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15698 (MAXPATHLEN): Define only if needed.
a70072c9 15699
a0977c44
PE
15700 * process.c (serial_open, serial_configure): Move decls from here ...
15701 * systty.h: ... to here, so that they can be checked.
15702
a884fdcc
PE
15703 * fns.c (get_random, seed_random): Move extern decls from here ...
15704 * lisp.h: ... to here, so that they can be checked.
15705
604efe86 15706 * sysdep.c (reset_io): Now static.
b8950c94 15707 (wait_for_termination_signal): Remove; unused.
604efe86 15708
38fc62d9
PE
15709 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15710 (copy_keymap_item, append_key, push_text_char_description):
15711 Now static.
1004a21a 15712 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15713 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15714 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15715 (describe_map_tree):
15716 Rename locals to avoid shadowing.
38fc62d9 15717
2f2650da
PE
15718 * keyboard.c: Declare functions static if they are not used elsewhere.
15719 (echo_char, echo_dash, cmd_error, top_level_2):
15720 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15721 (read_char, kbd_buffer_get_event, make_lispy_position):
15722 (make_lispy_event, make_lispy_movement, apply_modifiers):
15723 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15724 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15725 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15726 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15727 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15728
a053e86c 15729 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15730 (mark_kboards): Move decl here ...
15731 * alloc.c (mark_kboards): ... from here.
a053e86c 15732
4752793e
PE
15733 * lisp.h (force_auto_save_soon): New decl.
15734
74f10ca7 15735 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15736 (DEFINE_DUMMY_FUNCTION): New macro.
15737 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15738 Use it.
c03cd23f
PE
15739 (main): Add casts to avoid warnings
15740 if GCC considers string literals to be constants.
74f10ca7 15741
022e70d4
PE
15742 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15743
59d6fe83
PE
15744 * dbusbind.c: Pointer signedness fixes.
15745 (xd_signature, xd_append_arg, xd_initialize):
15746 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15747 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15748 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15749 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15750
78320123
PE
15751 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15752 if GCC considers string literals to be constants.
49cebcca 15753 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15754
35ac2a97
SM
157552011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15756
fb103ca9
SM
15757 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15758 (print_preprocess, print_object): New macro to fix last change.
15759
35ac2a97
SM
15760 * print.c (print_preprocess): Don't forget font objects.
15761
62973b41
JB
157622011-03-16 Juanma Barranquero <lekktu@gmail.com>
15763
15764 * emacs.c (USAGE3): Doc fixes.
15765
0e48bb22
AS
157662011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15767
15768 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15769 structure.
15770
7684e57b
JB
157712011-03-14 Juanma Barranquero <lekktu@gmail.com>
15772
15773 * lisp.h (VWindow_system, Qfile_name_history):
15774 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15775 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15776 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15777
15778 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15779 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15780
15781 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15782 * w32console.c (detect_input_pending, read_input_pending)
15783 (encode_terminal_code):
15784 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15785 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15786 (w32_system_caret_y, Qfile_name_history):
15787 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15788 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15789 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15790 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15791 * w32proc.c (Qlocal, report_file_error):
15792 * w32term.c (Vwindow_system, updating_frame):
15793 * w32uniscribe.c (initialized, uniscribe_font_driver):
15794 Remove unneeded extern declarations.
15795
2aa46d6c
CY
157962011-03-14 Chong Yidong <cyd@stupidchicken.com>
15797
c96bbc66 15798 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15799
cffc6f3b
CY
158002011-03-13 Chong Yidong <cyd@stupidchicken.com>
15801
15802 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15803 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15804 These macros can no longer be used for assignment.
15805
44f230aa
SM
15806 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15807 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15808 (record_buffer_markers, fetch_buffer_markers): New functions for
15809 recording and fetching special buffer markers.
15810 (set_buffer_internal_1, set_buffer_temp): Use them.
15811
15812 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15813
15814 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15815
15816 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15817 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15818
15819 * xdisp.c (hscroll_window_tree):
15820 (reconsider_clip_changes): Use PT instead of BUF_PT.
15821
d251f04b
EZ
158222011-03-13 Eli Zaretskii <eliz@gnu.org>
15823
15824 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15825 $(EMACS_ROOT)/lib/intprops.h.
15826
f0c77cd1
PE
158272011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15828
3eca4629
PE
15829 Fix more problems found by GCC 4.5.2's static checks.
15830
7c86ee98
PE
15831 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15832 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15833 (xg_free_frame_widgets): Make it clear that a local variable is
15834 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15835 (gdk_window_get_screen): Make it clear that this macro is needed
15836 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15837 (int_gtk_range_get_value): New function, which avoids a diagnostic
15838 from gcc -Wbad-function-cast.
15839 (xg_set_toolkit_scroll_bar_thumb): Use it.
15840 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15841 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15842 (get_utf8_string, xg_get_file_with_chooser):
15843 Rename locals to avoid shadowing.
15844 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15845
41729b81
PE
15846 * xgselect.c (xg_select): Remove unused var.
15847
f0c77cd1
PE
15848 * image.c (four_corners_best): Mark locals as initialized.
15849 (gif_load): Initialize transparent_p to zero (Bug#8238).
15850 Mark another local as initialized.
ec6cf4c6 15851 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15852
ce0ad53d 15853 * image.c (clear_image_cache): Now static.
d5d5a617 15854 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15855 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15856 (x_edge_detection): Remove unnecessary cast that
15857 gcc -Wbad-function-cast diagnoses.
2037898d 15858 (gif_load): Fix pointer signedness.
6ae141d6
PE
15859 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15860 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15861
33383987 158622011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15863
d32df629
PE
15864 Improve quality of tests for time stamp overflow.
15865 For example, without this patch (encode-time 0 0 0 1 1
15866 1152921504606846976) returns the obviously-bogus value (-948597
15867 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15868 reports time overflow. See
15869 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15870 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15871 * editfns.c: Include limits.h and intprops.h.
15872 (TIME_T_MIN, TIME_T_MAX): New macros.
15873 (time_overflow): Move earlier, to before first use.
15874 (hi_time, lo_time): New functions, for an accurate test for
15875 out-of-range times.
15876 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15877 (Fget_internal_run_time): Don't assume time_t fits in int.
15878 (make_time): Use list2 instead of Fcons twice.
15879 (Fdecode_time): More accurate test for out-of-range times.
15880 (check_tm_member): New function.
15881 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15882 (lisp_time_argument): Don't rely on undefined left-shift and
15883 right-shift behavior when checking for time stamp overflow.
8be6f318 15884
fe31d94c
PE
15885 * editfns.c (time_overflow): New function, refactoring common code.
15886 (Fformat_time_string, Fdecode_time, Fencode_time):
15887 (Fcurrent_time_string): Use it.
15888
8be6f318
PE
15889 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15890 * dired.c (make_time): Move to ...
15891 * editfns.c (make_time): ... here.
15892 * systime.h: Note the move.
15893
09d9db2c 158942011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15895
126bc0dc
YM
15896 * fringe.c (update_window_fringes): Remove unused variables.
15897
c47cbdfd
YM
15898 * unexmacosx.c (copy_data_segment): Also copy __got section.
15899 (Bug#8223)
15900
7ac80be9
EZ
159012011-03-12 Eli Zaretskii <eliz@gnu.org>
15902
c96bbc66 15903 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15904 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15905 Constify `char *' arguments and their references according to
15906 prototypes in tparam.h.
15907
ecb0f94d 15908 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15909
7ac80be9
EZ
15910 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15911 Adapt all references accordingly.
15912
15913 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15914
ef1fd07e
TT
159152011-03-11 Tom Tromey <tromey@redhat.com>
15916
15917 * buffer.c (syms_of_buffer): Remove obsolete comment.
15918
7ef4b50c
EZ
159192011-03-11 Eli Zaretskii <eliz@gnu.org>
15920
15921 * termhooks.h (encode_terminal_code): Declare prototype.
15922
15923 * msdos.c (encode_terminal_code): Don't declare prototype.
15924
15925 * term.c (encode_terminal_code): Now external again, used by
15926 w32console.c and msdos.c.
15927
44f230aa
SM
15928 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15929 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15930
4b1ec863 159312011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15932
1714f52b 15933 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15934
4b1ec863
PE
15935 * fringe.c (update_window_fringes): Mark locals as initialized
15936 (Bug#8227).
15937 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15938
524c7aa6
PE
15939 * alloc.c (mark_fringe_data): Move decl from here ...
15940 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15941 to check its interface.
15942 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15943
a5c0af81 15944 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15945 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15946 (fontset_font): Mark local as initialized.
a9a06e0b 15947 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15948
b4716021
PE
15949 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15950
811e9bac 15951 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15952 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15953 (x_own_selection, Fx_disown_selection_internal): Rename locals
15954 to avoid shadowing.
15955 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15956
7e3ab302
PE
15957 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15958 so that the caller can use some name other than gcpro1.
15959 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15960 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15961 (Fx_backspace_delete_keys_p):
15962 Use them to avoid shadowing, and rename vars to avoid shadowing.
15963 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15964 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15965 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15966 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15967 Remove unused locals.
7e3ab302
PE
15968 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15969 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15970 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15971 macros.
f78faa98 15972
e2b13473
PE
15973 * xterm.h (x_mouse_leave): New decl.
15974
77f23912
PE
15975 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15976 Remove unused functions.
cdf4ba58
PE
15977 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15978 (x_calc_absolute_position): Now static.
7411c686 15979 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15980 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15981 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15982 unless they are used.
38d0b34a
PE
15983 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15984 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15985 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15986 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15987 (x_error_catcher, x_connection_closed, x_error_handler):
15988 (x_error_quitter, xembed_send_message, x_iconify_frame):
15989 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15990 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15991 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15992
44f230aa
SM
15993 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15994 Rename or move locals to avoid shadowing.
6b463e58 15995 (tty_defined_color, merge_face_heights): Now static.
5967d051 15996 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15997 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15998 does not deduce is never used uninitialized.
73719eba
PE
15999 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
16000 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 16001
426994c3 16002 * terminal.c (store_terminal_param): Now static.
5489860b 16003
032f1620 16004 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 16005 (set_frame_menubar): Remove unused local.
d4323972 16006 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
16007 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
16008 since they might point to immutable storage.
281585b0
PE
16009 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
16010 since it's unused otherwise.
032f1620 16011
367c19e5 16012 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 16013 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
16014 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
16015 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 16016 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
16017 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
16018 does not deduce are never used uninitialized.
70739cbe 16019
07b48fa9
PE
16020 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
16021
8868a238 16022 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
16023 * window.c (window_loop, size_window):
16024 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 16025
7e5cf297 16026 * window.c (display_buffer): Now static.
d6550a9f
PE
16027 (size_window): Mark variables that gcc -Wuninitialized
16028 does not deduce are never used uninitialized.
a586633d
PE
16029 * window.h (check_all_windows): New decl, to forestall
16030 gcc -Wmissing-prototypes diagnostic.
5b555da1 16031 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 16032
f6095868
PE
16033 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
16034 shadowing.
16035 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
16036 Include <limits.h>.
16037 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
16038 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
16039 (load_charset_map): Mark variables that gcc -Wuninitialized
16040 does not deduce are never used uninitialized.
53df7c11 16041 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 16042
f38b440c
PE
16043 * coding.c (coding_set_source, coding_set_destination):
16044 Use "else { /* comment */ }" rather than "else /* comment */;"
16045 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
16046 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
16047 a block, when the outer 'i' will do.
16048 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
16049 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
16050 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
16051 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
16052 (Fdecode_sjis_char, Fdefine_coding_system_internal):
16053 Rename locals to avoid shadowing.
16054 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
16055 * coding.c (emacs_mule_char, encode_invocation_designation):
16056 Now static, since they're not used elsewhere.
413bb2db 16057 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 16058 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
16059 (decode_coding_emacs_mule): Mark variables that gcc
16060 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
16061 (detect_coding_iso_2022): Initialize a local variable that might
16062 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 16063 this initialization is needed. (Bug#8211)
5f58e762
PE
16064 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
16065 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
16066 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
16067 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
16068 Remove unused macros.
f38b440c 16069
232b38b9 16070 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 16071 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 16072 * character.c (string_count_byte8): Likewise.
232b38b9 16073
fb90da1b
PE
16074 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
16075 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
16076
fb93dbc2
PE
16077 * chartab.c (copy_sub_char_table): Now static, since it's not used
16078 elsewhere.
5c156ace
PE
16079 (sub_char_table_ref_and_range, char_table_ref_and_range):
16080 Rename locals to avoid shadowing.
bbcd0949 16081 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 16082
7d3b3862 16083 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 16084 (BIDI_BOB): Remove unused macro.
7d3b3862 16085
6be7d3da
PE
16086 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
16087 deduce are never used uninitialized.
c2ed9c8b 16088 * term.c (encode_terminal_code): Likewise.
6be7d3da 16089
75f8807f 16090 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 16091
50938595
PE
16092 * tparam.h: New file.
16093 * term.c, tparam.h: Include it.
16094 * deps.mk (term.o, tparam.o): Depend on tparam.h.
16095 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
16096 Move these decls to tparam.h, and make them agree with what
16097 is actually in tparam.c. The previous trick of using incompatible
16098 decls in different modules does not conform to the C standard.
16099 All callers of tparam changed to use tparam's actual API.
16100 * tparam.c (tparam1, tparam, tgoto):
16101 Use const pointers where appropriate.
16102
fbceeba2
PE
16103 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
16104 * cm.h (struct cm): Likewise.
16105 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
16106 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
16107 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
16108 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
16109 (turn_on_face, init_tty): Likewise.
16110 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 16111
7f3f1250
PE
16112 * term.c (term_mouse_position): Rename local to avoid shadowing.
16113
e6ca6543
PE
16114 * alloc.c (mark_ttys): Move decl from here ...
16115 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
16116
c40f8d15
AS
161172011-03-11 Andreas Schwab <schwab@linux-m68k.org>
16118
16119 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
16120
cfe0661d
JB
161212011-03-09 Juanma Barranquero <lekktu@gmail.com>
16122
16123 * search.c (compile_pattern_1): Remove argument regp, unused since
16124 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
16125 (compile_pattern): Don't pass it.
16126
0afb4571
J
161272011-03-08 Jan Djärv <jan.h.d@swipnet.se>
16128
16129 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
16130 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
16131 for ! HAVE_GTK3.
16132 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
16133
16134 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
16135
16136 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
16137 gdk_window_get_screen, gdk_window_get_geometry,
16138 gdk_x11_window_lookup_for_display and GDK_KEY_g.
16139 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
16140 (xg_get_pixbuf_from_pixmap): New function.
16141 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
16142 to Pixmap, take frame as parameter, remove GdkColormap parameter.
16143 Call xg_get_pixbuf_from_pixmap instead of
16144 gdk_pixbuf_get_from_drawable.
16145 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
16146 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
16147 (xg_check_special_colors): Use GtkStyleContext and its functions
16148 for HAVE_GTK3.
16149 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
16150 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
16151 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
16152 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
16153 Call gtk_widget_get_preferred_size.
0afb4571
J
16154 (xg_frame_resized): gdk_window_get_geometry only takes 5
16155 parameters.
44f230aa
SM
16156 (xg_win_to_widget, xg_event_is_for_menubar):
16157 Call gdk_x11_window_lookup_for_display.
0afb4571
J
16158 (xg_set_widget_bg): New function.
16159 (delete_cb): New function.
895009e1 16160 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 16161 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
16162 (xg_set_background_color): Call xg_set_widget_bg.
16163 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
16164 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
16165 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
16166 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
16167 if ! HAVE_GTK3.
16168 (update_frame_tool_bar): Call gtk_widget_hide.
16169 (xg_initialize): Use GDK_KEY_g.
16170
16171 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
16172 if ! HAVE_GTK3
16173 (x_session_initialize): Call gdk_x11_set_sm_client_id.
16174
16175 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
16176 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
16177 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
16178
1c2cc4ef
JB
161792011-03-08 Juanma Barranquero <lekktu@gmail.com>
16180
16181 * w32xfns.c (select_palette): Check success of RealizePalette against
16182 GDI_ERROR, not zero.
16183
33383987 16184See ChangeLog.11 for earlier changes.
aac0c6e3
MR
16185
16186;; Local Variables:
16187;; coding: utf-8
aac0c6e3
MR
16188;; End:
16189
2f097256 16190 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
16191
16192 This file is part of GNU Emacs.
16193
16194 GNU Emacs is free software: you can redistribute it and/or modify
16195 it under the terms of the GNU General Public License as published by
16196 the Free Software Foundation, either version 3 of the License, or
16197 (at your option) any later version.
16198
16199 GNU Emacs is distributed in the hope that it will be useful,
16200 but WITHOUT ANY WARRANTY; without even the implied warranty of
16201 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16202 GNU General Public License for more details.
16203
16204 You should have received a copy of the GNU General Public License
16205 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.