* lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d8ed26bd
PE
12011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2
6089c567
PE
3 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5 well either way, and we prefer signed to unsigned.
6
d8ed26bd
PE
7 Random fixes. E.g., (random) never returned negative values.
8 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9 subseconds part to the entropy, as that's a bit more random.
10 Prefer signed to unsigned, since the signedness doesn't matter and
11 in general we prefer signed. When given a limit, use a
12 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
13 latter isn't right if USE_2_TAGS_FOR_INTS.
14 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
15 not 0..VALMASK. Don't discard "excess" bits that random () returns.
16
cabf1cac
SM
172011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
18
19 * textprop.c (text_property_stickiness):
20 Obey Vtext_property_default_nonsticky.
21 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
22 * w32fns.c (syms_of_w32fns):
23 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
24
6e9b2be9
PE
252011-07-04 Paul Eggert <eggert@cs.ucla.edu>
26
27 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
28 This is more efficient than Ffile_directory_p and avoids a minor race.
29
90186c68
LMI
302011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
31
7c301272
LMI
32 * buffer.c (Foverlay_put): Say what the return value is
33 (bug#7835).
34
c4f2d8d4
LMI
35 * fileio.c (barf_or_query_if_file_exists): Check first if the file
36 is a directory before asking whether to use the file name
37 (bug#7564).
ad637907
LMI
38 (barf_or_query_if_file_exists): Make the "File is a directory"
39 error be more correct.
c4f2d8d4 40
90186c68
LMI
41 * fns.c (Frequire): Remove the mention of the .gz files, since
42 that's installation-specific, but keep the mention of
43 `get-load-suffixes'.
44
da64016e
PE
452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
46
47 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
48 Report string overflow if the output is too long.
49
7d47b580
JB
502011-07-04 Juanma Barranquero <lekktu@gmail.com>
51
a555cb87
JB
52 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
53 (syms_of_gnutls): Remove duplicate DEFSYM for
54 Qgnutls_bootprop_verify_hostname_error, an error for
55 Qgnutls_bootprop_verify_error (which is no longer used).
56
7d47b580
JB
57 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
58 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
59 Also (re)move comments that are misplaced or no longer relevant.
60
1e49bfab
LMI
612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
62
63 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
64
1485f4c0
CY
652011-07-03 Chong Yidong <cyd@stupidchicken.com>
66
67 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
68 and background color parameters if they have been changed.
69
a9ab721e
LMI
702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
71
72 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
73
cf7cff57
PE
742011-07-03 Paul Eggert <eggert@cs.ucla.edu>
75
2e13213d
PE
76 * xsettings.c (SYSTEM_FONT): Define only when used.
77 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
78
cf7cff57
PE
79 * keymap.c (access_keymap_1): Now static.
80
7a8e04f7
CY
812011-07-02 Chong Yidong <cyd@stupidchicken.com>
82
83 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
84 leave any prefix arg for the up event (Bug#1586).
85
61352f62
LMI
862011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
87
69bb1ef7
LMI
88 * lread.c (syms_of_lread): Mention single symbols defined by
89 `defvar' or `defconst' (bug#7154).
90
61352f62 91 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 92 (Frequire): Mention get-load-suffixes.
61352f62 93
28545e04
MR
942011-07-02 Martin Rudalics <rudalics@gmx.at>
95
96 * window.h (window): Remove clone_number slot.
97 * window.c (Fwindow_clone_number, Fset_window_clone_number):
98 Remove.
99 (make_parent_window, make_window, saved_window)
100 (Fset_window_configuration, save_window_save): Don't deal with
101 clone numbers.
102 * buffer.c (Qclone_number): Remove declaration.
103 (sort_overlays, overlay_strings): Don't deal with clone numbers.
104
3349e122
SM
1052011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
106
107 Add multiple inheritance to keymaps.
108 * keymap.c (Fmake_composed_keymap): New function.
109 (Fset_keymap_parent): Simplify.
110 (fix_submap_inheritance): Remove.
111 (access_keymap_1): New function extracted from access_keymap to handle
112 embedded parents and handle lists of maps.
113 (access_keymap): Use it.
114 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
115 (Fcopy_keymap): Handle embedded parents.
116 (Fcommand_remapping, define_as_prefix): Simplify.
117 (Fkey_binding): Simplify.
118 (syms_of_keymap): Move minibuffer-local-completion-map,
119 minibuffer-local-filename-completion-map,
120 minibuffer-local-must-match-map, and
121 minibuffer-local-filename-must-match-map to Elisp.
122 (syms_of_keymap): Defsubr make-composed-keymap.
123 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
124 (parse_menu_item): Trivial simplification.
125
3279eb87
GM
1262011-07-01 Glenn Morris <rgm@gnu.org>
127
128 * Makefile.in (SETTINGS_LIBS): Fix typo.
129
4550efdf
KI
1302011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
131
132 * coding.c (Fencode_coding_string): Record the last coding system
133 used, as the function doc string says (bug#8738).
134
0949d2b6
JD
1352011-07-01 Jan Djärv <jan.h.d@swipnet.se>
136
137 * xsettings.c (store_monospaced_changed): Take new font as arg and
138 check for change against current_mono_font.
139 (EMACS_TYPE_SETTINGS): Remove this and related defines.
140 (emacs_settings_constructor, emacs_settings_get_property)
141 (emacs_settings_set_property, emacs_settings_class_init)
142 (emacs_settings_init, gsettings_obj): Remove.
143 (something_changedCB): New function for HAVE_GSETTINGS.
144 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
145 with value as argument.
146 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
147 g_settings_new (Bug#8967). Do not create gsettings_obj.
148 Remove calls to g_settings_bind. Connect something_changedCB to
149 "changed".
150
151 * xgselect.c: Add defined (HAVE_GSETTINGS).
152 (xgselect_initialize): Ditto.
153
154 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
155 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
156 xg_select.
157
bbc6b304
PE
1582011-07-01 Paul Eggert <eggert@cs.ucla.edu>
159
160 * eval.c (struct backtrace): Simplify and port the data structure.
161 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
162 signed bit field, as this assumption is not portable and it makes
163 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
164 "char debug_on_exit : 1" as this is not portable either; instead,
165 use the portable "unsigned int debug_on_exit : 1". Remove unused
166 member evalargs. Remove obsolete comments about cc bombing out.
167
9851bfc5
JD
1682011-06-30 Jan Djärv <jan.h.d@swipnet.se>
169
51bb811f 170 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
171 Let HAVE_GSETTINGS override HAVE_GCONF.
172 (store_monospaced_changed): New function.
173 (EMACS_SETTINGS): A new type derived from GObject to handle
174 GSettings notifications.
175 (emacs_settings_constructor, emacs_settings_get_property)
176 (emacs_settings_set_property, emacs_settings_class_init):
177 New functions.
178 (gsettings_client, gsettings_obj): New variables.
179 (GSETTINGS_SCHEMA): New define.
180 (something_changedCB): Call store_monospaced_changed.
181 (init_gsettings): New function.
182 (xsettings_initialize): Call init_gsettings.
183 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
184 to NULL.
185
186 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
187 GCONF_CFLAGS/LIBS.
188
5386012d
MR
1892011-06-29 Martin Rudalics <rudalics@gmx.at>
190
191 * window.c (resize_root_window, grow_mini_window)
192 (shrink_mini_window): Rename Qresize_root_window to
193 Qwindow_resize_root_window and Qresize_root_window_vertically to
194 Qwindow_resize_root_window_vertically.
195
f13e0b08
PE
1962011-06-28 Paul Eggert <eggert@cs.ucla.edu>
197
198 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
199
94515237
JB
2002011-06-27 Juanma Barranquero <lekktu@gmail.com>
201
202 * makefile.w32-in: Redesign dependencies so they reflect more
203 clearly which files are directly included by each source file,
204 and not through other includes.
205
e43b6e43
MR
2062011-06-27 Martin Rudalics <rudalics@gmx.at>
207
208 * buffer.c (Qclone_number): Declare static and DEFSYM it.
209 (sort_overlays, overlay_strings): When an overlay's clone number
210 matches the window's clone number process the overlay even if
211 the overlay's window property doesn't match the current window.
212
d68443dc
MR
213 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
214 (Fwindow_hchild): Rename to Fwindow_left_child.
215 (Fwindow_next): Rename to Fwindow_next_sibling.
216 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
217 (resize_window_check): Rename to window_resize_check.
218 (resize_window_apply): Rename to window_resize_apply.
219 (Fresize_window_apply): Rename to Fwindow_resize_apply.
220 (Fdelete_other_windows_internal, resize_frame_windows)
221 (Fsplit_window_internal, Fdelete_window_internal)
222 (grow_mini_window, shrink_mini_window)
223 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 224
c7e73be5
JD
2252011-06-26 Jan Djärv <jan.h.d@swipnet.se>
226
227 * emacsgtkfixed.h: State that this is only used with Gtk+3.
228 (emacs_fixed_set_min_size): Remove.
229 (emacs_fixed_new): Take frame as argument.
230
231 * emacsgtkfixed.c: State that this is only used with Gtk+3.
232 (_EmacsFixedPrivate): Remove minwidth/height.
233 Add struct frame *f.
234 (emacs_fixed_init): Initialize priv->f.
235 (get_parent_class, emacs_fixed_set_min_size): Remove.
236 (emacs_fixed_new): Set priv->f to argument.
237 (emacs_fixed_get_preferred_width)
238 (emacs_fixed_get_preferred_height): Use min_width/height from
239 frames size_hint to set minimum and natural (Bug#8919).
240 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
241 and use min_width/height from frames size_hint to set
242 min_width/height (Bug#8919).
243
244 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
245 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
246 indentation.
247
cf99dcf8
EZ
2482011-06-26 Eli Zaretskii <eliz@gnu.org>
249
250 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
251 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
252 called at ZV.
253
029529ac
CY
2542011-06-26 Chong Yidong <cyd@stupidchicken.com>
255
256 * process.c (wait_reading_process_output): Bypass select if
257 waiting for a cell while ignoring keyboard input, and input is
258 pending. Suggested by Jan Djärv (Bug#8869).
259
7a7ef429
PE
2602011-06-25 Paul Eggert <eggert@cs.ucla.edu>
261
262 Use gnulib's dup2 module instead of rolling our own.
263 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
264
11fdef7d 2652011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
266
267 * dispnew.c (scrolling_window): Before scrolling, turn off a
268 mouse-highlight in the window being scrolled.
269
cd3520a4
JB
2702011-06-24 Juanma Barranquero <lekktu@gmail.com>
271
272 Move DEFSYM to lisp.h and use everywhere.
273
274 * character.h (DEFSYM): Move declaration...
275 * lisp.h (DEFSYM): ...here.
276
277 * gnutls.c:
278 * minibuf.c:
279 * w32menu.c:
280 * w32proc.c:
281 * w32select.c: Don't include character.h.
282
283 * alloc.c (syms_of_alloc):
284 * buffer.c (syms_of_buffer):
285 * bytecode.c (syms_of_bytecode):
286 * callint.c (syms_of_callint):
287 * casefiddle.c (syms_of_casefiddle):
288 * casetab.c (init_casetab_once):
289 * category.c (init_category_once, syms_of_category):
290 * ccl.c (syms_of_ccl):
291 * cmds.c (syms_of_cmds):
292 * composite.c (syms_of_composite):
293 * dbusbind.c (syms_of_dbusbind):
294 * dired.c (syms_of_dired):
295 * dispnew.c (syms_of_display):
296 * doc.c (syms_of_doc):
297 * editfns.c (syms_of_editfns):
298 * emacs.c (syms_of_emacs):
299 * eval.c (syms_of_eval):
300 * fileio.c (syms_of_fileio):
301 * fns.c (syms_of_fns):
302 * frame.c (syms_of_frame):
303 * fringe.c (syms_of_fringe):
304 * insdel.c (syms_of_insdel):
305 * keymap.c (syms_of_keymap):
306 * lread.c (init_obarray, syms_of_lread):
307 * macros.c (syms_of_macros):
308 * msdos.c (syms_of_msdos):
309 * print.c (syms_of_print):
310 * process.c (syms_of_process):
311 * search.c (syms_of_search):
312 * sound.c (syms_of_sound):
313 * syntax.c (init_syntax_once, syms_of_syntax):
314 * terminal.c (syms_of_terminal):
315 * textprop.c (syms_of_textprop):
316 * undo.c (syms_of_undo):
317 * w32.c (globals_of_w32):
318 * window.c (syms_of_window):
319 * xdisp.c (syms_of_xdisp):
320 * xfaces.c (syms_of_xfaces):
321 * xfns.c (syms_of_xfns):
322 * xmenu.c (syms_of_xmenu):
323 * xsettings.c (syms_of_xsettings):
324 * xterm.c (syms_of_xterm): Use DEFSYM.
325
4228cf16
TZ
3262011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
327
cd3520a4 328 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 329
7fcccf1e
PE
3302011-06-23 Paul Eggert <eggert@cs.ucla.edu>
331
7efb4e0e
PE
332 Integer and buffer overflow fixes (Bug#8873).
333
ff5844ad
PE
334 * print.c (printchar, strout): Check for string overflow.
335 (PRINTPREPARE, printchar, strout):
336 Don't set size unless allocation succeeds.
337
90532f02
PE
338 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
339 for sizes. Check for string overflow more accurately.
340 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
341
6d84508d
PE
342 * macros.c: Integer and buffer overflow fixes.
343 * keyboard.h (struct keyboard.kbd_macro_bufsize):
344 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
345 Use ptrdiff_t, not int, for sizes.
346 Don't increment bufsize until after realloc succeeds.
347 Check for size-calculation overflow.
348 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
349
437b2cb4
PE
350 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
351
8b9ac8b4
PE
352 * lread.c: Integer overflow fixes.
353 (read_integer): Radix is now EMACS_INT, not int,
354 to improve quality of diagnostics for out-of-range radices.
355 Calculate buffer size correctly for out-of-range radices.
356 (read1): Check for integer overflow in radices, and in
357 read-circle numbers.
82cb60d3
PE
358 (read_escape): Avoid int overflow.
359 (Fload, openp, read_buffer_size, read1)
360 (substitute_object_recurse, read_vector, read_list, map_obarray):
361 Use ptrdiff_t, not int, for sizes.
362 (read1): Use EMACS_INT, not int, for sizes.
20270765 363 Check for size overflow.
8b9ac8b4 364
7fcccf1e
PE
365 * image.c (cache_image): Check for size arithmetic overflow.
366
bfbbd7e7
PE
367 * lread.c: Integer overflow issues.
368 (saved_doc_string_size, saved_doc_string_length)
369 (prev_saved_doc_string_size, prev_saved_doc_string_length):
370 Now ptrdiff_t, not int.
371 (read1): Don't assume doc string length fits in int. Check for
372 out-of-range doc string lengths.
373 (read_list): Don't assume file position fits in int.
39019e54 374 (read_escape): Check for hex character overflow.
bfbbd7e7 375
4e323265
LL
3762011-06-22 Leo Liu <sdl.web@gmail.com>
377
378 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
379 Move to minibuffer.el.
380
85fece3e
PE
3812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
382
20b84ce9 383 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
384 The following patches are for when GLYPH_DEBUG && !XASSERT.
385 * dispextern.h (trace_redisplay_p, dump_glyph_string):
386 * dispnew.c (flush_stdout):
387 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
388 Mark as externally visible.
389 * dispnew.c (check_window_matrix_pointers): Now static.
390 * dispnew.c (window_to_frame_vpos):
391 * xfns.c (unwind_create_frame):
392 * xterm.c (x_check_font): Remove unused local.
393 * scroll.c (CHECK_BOUNDS):
394 * xfaces.c (cache_fache): Rename local to avoid shadowing.
395 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
396 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
397 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
398 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
399 Now static.
400 (debug_method_add): Use va_list and vsprintf rather than relying
401 on undefined behavior with wrong number of arguments.
402 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
403 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
404 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
405 since we're not interested in debugging glyphs with old libraries.
406 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
407 GCC 4.6.0's static checking.
408
0766b489
PE
4092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
410
31fd4b32
PE
411 Integer overflow and signedness fixes (Bug#8873).
412 A few related buffer overrun fixes, too.
413
b79e8648
PE
414 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
415
0766b489
PE
416 * dispextern.h (struct face.stipple):
417 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
418 (x_bitmap_mask, x_allocate_bitmap_record)
419 (x_create_bitmap_from_data, x_create_bitmap_from_file)
420 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
421 (x_create_bitmap_from_xpm_data):
422 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
423 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
424 (.bitmaps_last):
425 * xfaces.c (load_pixmap):
426 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
427 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
428 (.bitmaps_last, struct x_output.icon_bitmap):
429 Use ptrdiff_t, not int, for bitmap indexes.
430 (x_allocate_bitmap_record): Check for size overflow.
431 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
432
b081724f
PE
433 Use ptrdiff_t, not int, for overlay counts.
434 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
435 * editfns.c (overlays_around, get_pos_property):
436 * textprop.c (get_char_property_and_overlay):
437 * xdisp.c (next_overlay_change, note_mouse_highlight):
438 * xfaces.c (face_at_buffer_position):
21514da7
PE
439 * buffer.c (OVERLAY_COUNT_MAX): New macro.
440 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
441 (Fnext_overlay_change, Fprevious_overlay_change)
442 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 443 Use ptrdiff_t, not int, for sizes.
21514da7 444 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 445
3de73e5e
PE
446 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
447
2606c57b
PE
448 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
449 (x_session_initialize): Do not assume string length fits in int.
450
aaafe47a
PE
451 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
452 This is unlikely, but can occur if DPI is outlandish.
453
2674ddc8 454 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
455 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
456
28154962
PE
457 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
458 * xrdb.c (magic_file_p, search_magic_path):
459 Omit last arg SUFFIX; it was always 0. All callers changed.
460 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
461
7de51af5
PE
462 * xfont.c (xfont_match): Avoid need for strlen.
463
25ed6cc3
PE
464 * xfns.c: Don't assume strlen fits in int.
465 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
466
4eab31dd
PE
467 * xdisp.c (message_log_check_duplicate): Return intmax_t,
468 not unsigned long, as we prefer signed integers. All callers changed.
469 Detect integer overflow in repeat count.
470 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 471 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 472
171e2a58
PE
473 * termcap.c: Don't assume sizes fit in int and never overflow.
474 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
475 (gobble_line): Check for size-calculation overflow.
476
ad39faca 477 * minibuf.c (Fread_buffer):
6e5bb2dc 478 * lread.c (intern, intern_c_string):
74ca2eb3
PE
479 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
480 Don't assume string length fits in int.
481
52c61c22 482 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
483 * gtkutil.c (style_changed_cb): Avoid need for strlen.
484
b5b8c9e5
PE
485 * font.c: Don't assume string length fits in int.
486 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
487 Use ptrdiff_t, not int.
ccd6111c
PE
488 (font_intern_prop): Don't assume string length fits in int.
489 Don't assume integer property fits in fixnum.
490 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 491
882f0d81 492 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 493 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
494 Reformulate so as not to need the command string.
495 Invoke gzip -cd rather than gunzip, as it's more portable.
496 (lock_info_type, lock_file_1, lock_file):
497 Don't assume pid_t and time_t fit in unsigned long.
498 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
499 (current_lock_owner): Prefer signed type for sizes.
500 Use memcpy, not strncpy, where memcpy is what is really wanted.
501 Don't assume (via atoi) that time_t and pid_t fit in int.
502 Check for time_t and/or pid_t out of range, e.g., via a network share.
503 Don't alloca where an auto var works fine.
504
93f4cf88
PE
505 * fileio.c: Fix some integer overflow issues.
506 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
507 Don't assume string length fits in int.
508 (directory_file_name): Don't assume string length fits in long.
509 (make_temp_name): Don't assume pid fits in int, or that its print
510 length is less than 20.
511
f3e92b69
PE
512 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
513
1bfdaf10
PE
514 * coding.c (make_subsidiaries): Don't assume string length fits in int.
515
35016e9a
PE
516 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
517
3d1e65a1
PE
518 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
519 We prefer signed integers, even for size calculations.
520
0b963a93
PE
521 * emacs.c: Don't assume string length fits in 'int'.
522 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
523 (main): Don't invoke strlen when not needed.
524
573f4b54
PE
525 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
526 (XD_DEBUG_MESSAGE): Don't waste a byte.
527
989f33ba
PE
528 * callproc.c (getenv_internal_1, getenv_internal)
529 (Fgetenv_internal):
965d34eb
PE
530 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
531
e4d29b33
PE
532 * lread.c (invalid_syntax): Omit length argument.
533 All uses changed. This doesn't fix a bug, but it simplifies the
534 code away from its former Hollerith-constant appearance, and it's
535 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 536 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 537
eb49b136
PE
538 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
539 This didn't break anything, but it didn't help either.
540 It's confusing to put a bogus integer in a place where the actual
541 value does not matter.
9f62aeb1 542 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 543 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 544
15375a22
PE
545 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
546 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
547 implementation.
b61cc01c
PE
548 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
549 We prefer signed types, and the value cannot exceed the EMACS_INT
550 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
551 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
552 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
553 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 554
53b2623d
PE
555 * indent.c (sane_tab_width): New function.
556 (current_column, scan_for_column, Findent_to, position_indentation)
557 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 558 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 559
51cab52b 560 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 561
f2ed8a70
PE
562 * lisp.h (lint_assume): New macro.
563 * composite.c (composition_gstring_put_cache):
564 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
565
abe80cc6
PE
566 * editfns.c, insdel.c:
567 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 568
b02c740e
PE
569 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
570
ebc96716
PE
571 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
572
b4e50fa0 573 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 574 Use much-faster test for byte-length change.
311d5d7c 575 Don't assume string byte-length fits in 'int'.
a4cf38e4 576 Check that character arg fits in 'int'.
85461888 577 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 578
c0c1ee9f
PE
579 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
580
a498d7f4
PE
581 * fns.c (concat): Catch string overflow earlier.
582 Do not rely on integer wraparound.
583
51cab52b
PE
584 * dispextern.h (struct it.overlay_strings_charpos)
585 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
586 * xdisp.c (forward_to_next_line_start)
587 (back_to_previous_visible_line_start)
588 (reseat_at_next_visible_line_start, next_element_from_buffer):
589 Don't arbitrarily truncate the value of 'selective' to int.
590
76031fad
PE
591 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
592
5eb55db9
PE
593 * composite.c: Don't truncate sizes to 'int'.
594 (composition_gstring_p, composition_reseat_it)
595 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
596 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
597 not EMACS_UINT, for indexes.
5eb55db9 598
0703a717
PE
599 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
600
d6202519
PE
601 * buffer.c: Include <verify.h>.
602 (struct sortvec.priority, struct sortstr.priority):
8961a454 603 Now EMACS_INT, not int.
c20998a7 604 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
605 (struct sortstr.size, record_overlay_string)
606 (struct sortstrlist.size, struct sortlist.used):
607 Don't truncate size to int.
608 (record_overlay_string): Check for size-calculation overflow.
d6202519 609 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 610
d5a19415
JM
6112011-06-22 Jim Meyering <meyering@redhat.com>
612
029529ac 613 Don't leak an XBM-image-sized buffer
d5a19415
JM
614 * image.c (xbm_load): Free the image buffer after using it.
615
a9041e6c
PE
6162011-06-21 Paul Eggert <eggert@cs.ucla.edu>
617
618 Port to Sun C.
619 * composite.c (find_automatic_composition): Omit needless 'return 0;'
620 that Sun C diagnosed.
621 * fns.c (secure_hash): Fix pointer signedness issue.
622 * intervals.c (static_offset_intervals): New function.
623 (offset_intervals): Use it.
624
7f3f739f
LL
6252011-06-21 Leo Liu <sdl.web@gmail.com>
626
627 * deps.mk (fns.o):
628 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
629 sha512.h.
630
631 * fns.c (secure_hash): Rename from crypto_hash_function and change
632 the first arg to accept symbols.
5b66d427 633 (Fsecure_hash): New primitive.
7f3f739f
LL
634 (syms_of_fns): New symbols.
635
76147d94
DD
6362011-06-20 Deniz Dogan <deniz@dogan.se>
637
638 * process.c (Fset_process_buffer): Clarify return value in
639 docstring.
640
7d7d0045
CY
6412011-06-18 Chong Yidong <cyd@stupidchicken.com>
642
643 * dispnew.c (add_window_display_history): Use BVAR.
644
645 * xdisp.c (debug_method_add): Use BVAR.
646 (check_window_end, dump_glyph_matrix, dump_glyph)
647 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
648
649 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
650 Likewise.
651
652 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
653 check till after the cache is created in init_frame_faces.
654
ff2bc410
SM
6552011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
656
657 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
658
28177add
PE
6592011-06-16 Paul Eggert <eggert@cs.ucla.edu>
660
dd3482fe
PE
661 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
662 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
663 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
664
393d71f3 665 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
666 * fileio.c (Finsert_file_contents):
667 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
668 Remove the old (too-loose) buffer overflow checks.
669 They weren't needed, since make_gap checks for buffer overflow.
670 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
671 The old code merely checked for Emacs fixnum overflow, and relied
672 on undefined (wraparound) behavior. The new code avoids undefined
673 behavior, and also checks for ptrdiff_t and/or size_t overflow.
674
2e6813b0 675 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
676 Tune. Don't use wider integers than needed. Don't use alloca.
677 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 678
599a9e4f
PE
679 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
680
99561444
PE
681 * insdel.c, lisp.h (buffer_overflow): New function.
682 (insert_from_buffer_1, replace_range, replace_range_2):
683 * insdel.c (make_gap_larger):
684 * editfns.c (Finsert_char):
685 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
686
28177add
PE
687 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
688
e69dafad
PE
6892011-06-15 Paul Eggert <eggert@cs.ucla.edu>
690
a7af7fde 691 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 692
b1c46f02
PE
693 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
694 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
695
e69dafad
PE
696 * fileio.c: Don't assume EMACS_INT fits in off_t.
697 (emacs_lseek): New static function.
698 (Finsert_file_contents, Fwrite_region): Use it.
699 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
700
566684ea
PE
701 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
702
e6966cd6
PE
703 * fns.c: Don't overflow int when computing a list length.
704 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
705 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
706 truncation on 64-bit hosts. Check for QUIT every
707 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
708 faster and is responsive enough.
709 (Flength): Report an error instead of overflowing an integer.
710 (Fsafe_length): Return a float if the value is not representable
711 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 712 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 713 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 714
dd0b0efb
PE
715 * alloc.c: Check that resized vectors' lengths fit in fixnums.
716 (header_size, word_size): New constants.
717 (allocate_vectorlike): Don't check size overflow here.
718 (allocate_vector): Check it here instead, since this is the only
719 caller of allocate_vectorlike that could cause overflow.
720 Check that the new vector's length is representable as a fixnum.
721
86fe5cfe
PE
722 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
723 The previous code was bogus. For example, next_almost_prime (32)
724 returned 39, which is undesirable as it is a multiple of 3; and
725 next_almost_prime (24) returned 25, which is a multiple of 5 so
726 why was the code bothering to check for multiples of 7?
727
80e88859
PE
728 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
729
4a2f0ad6
PE
730 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
731
f66c7cf8
PE
732 Variadic C functions now count arguments with ptrdiff_t.
733 This partly undoes my 2011-03-30 change, which replaced int with size_t.
734 Back then I didn't know that the Emacs coding style prefers signed int.
735 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
736 were being counted with int, which may truncate counts on 64-bit
737 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
738 * lisp.h (struct Lisp_Subr.function.aMANY)
739 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
740 Arg counts are now ptrdiff_t, not size_t.
741 All variadic functions and their callers changed accordingly.
742 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
743 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
744 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
745 * callint.c (Fcall_interactively): Check arg count for overflow,
746 to avoid potential buffer overrun. Use signed char, not 'int',
747 for 'varies' array, so that we needn't bother to check its size
748 calculation for overflow.
749 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
750 * eval.c (apply_lambda):
751 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
752 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
753 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
754
a1759b76
PE
755 * callint.c (Fcall_interactively): Don't use index var as event count.
756
d96be9fc
PE
757 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
758 * mem-limits.h (SIZE): Remove; no longer used.
759
a690a978 760 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 761
578c21e6
PE
762 Remove unnecessary casts.
763 * xterm.c (x_term_init):
764 * xfns.c (x_set_border_pixel):
765 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
766 These aren't needed now that we assume ANSI C.
767
96f53c6c
PE
768 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
769 It's more likely to cause problems (due to unsigned overflow)
770 than to cure them.
771
83c77d31
PE
772 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
773
ee2079f1
PE
774 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
775
6da65536
PE
776 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
777
7147c4a4
PE
778 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
779
193e32d9
PE
780 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
781
e5533da6
PE
782 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
783
9910e595
PE
784 GLYPH_CODE_FACE returns EMACS_INT, not int.
785 * dispextern.h (merge_faces):
786 * xfaces.c (merge_faces):
01103c44
PE
787 * xdisp.c (get_next_display_element, next_element_from_display_vector):
788 Don't assume EMACS_INT fits in int.
9910e595 789
2638320e
PE
790 * character.h (CHAR_VALID_P): Remove unused parameter.
791 * fontset.c, lisp.h, xdisp.c: All uses changed.
792
045eb8d9
PE
793 * editfns.c (Ftranslate_region_internal): Omit redundant test.
794
c1f134b5
PE
795 * fns.c (concat): Minor tuning based on overflow analysis.
796 This doesn't fix any bugs. Use int to hold character, instead
797 of constantly refetching from Emacs object. Use XFASTINT, not
798 XINT, for value known to be a character. Don't bother comparing
799 a single byte to 0400, as it's always less.
800
395fcb93 801 * floatfns.c (Fexpt):
327eeec8
PE
802 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
803
abbd3d23
PE
804 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
805 for characters.
806
684a03ef
PE
807 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
808
0fed43f3
PE
809 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
810 Without this fix, on a 64-bit host (aset S 0 4294967386) would
811 incorrectly succeed when S was a string, because 4294967386 was
812 truncated before it was used.
813
8fd02eb7
PE
814 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
815 Otherwise, an out-of-range integer could cause undefined behavior
816 on a 64-bit host.
817
f8c86b69
PE
818 * composite.c: Use int, not EMACS_INT, for characters.
819 (fill_gstring_body, composition_compute_stop_pos): Use int, not
820 EMACS_INT, for values that are known to be in character range.
821 This doesn't fix any bugs but is the usual style inside Emacs and
822 may generate better code on 32-bit machines.
823
34206dd2
PE
824 Make sure a 64-bit char is never passed to ENCODE_CHAR.
825 This is for reasons similar to the recent CHAR_STRING fix.
826 * charset.c (Fencode_char): Check that character arg is actually
827 a character. Pass an int to ENCODE_CHAR.
828 * charset.h (ENCODE_CHAR): Verify that the character argument is no
829 wider than 'int', as a compile-time check to prevent future regressions
830 in this area.
831
c5958d4c 832 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
833
834 Make sure a 64-bit char is never passed to CHAR_STRING.
835 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
836 by silently ignoring the top 32 bits, allowing some values
837 that were far too large to be valid characters.
838 * character.h: Include <verify.h>.
839 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
840 arguments are no wider than unsigned, as a compile-time check
841 to prevent future regressions in this area.
842 * data.c (Faset):
01103c44 843 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
844 (Fsubst_char_in_region):
845 * fns.c (concat):
846 * xdisp.c (decode_mode_spec_coding):
847 Adjust to CHAR_STRING's new requirement.
848 * editfns.c (Finsert_char, Fsubst_char_in_region):
849 * fns.c (concat): Check that character args are actually
850 characters. Without this test, these functions did the wrong
851 thing with wildly out-of-range values on 64-bit hosts.
852
d37ca623
PE
853 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
854 These casts should not be needed on 32-bit hosts, either.
855 * keyboard.c (read_char):
856 * lread.c (Fload): Remove casts to unsigned.
857
ea204efb
PE
858 * lisp.h (UNSIGNED_CMP): New macro.
859 This fixes comparison bugs on 64-bit hosts.
860 (ASCII_CHAR_P): Use it.
861 * casefiddle.c (casify_object):
01103c44 862 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
863 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
864 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
865 * dispextern.h (FACE_FROM_ID):
866 * keyboard.c (read_char): Use UNSIGNED_CMP.
867
41cb286c
PE
868 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
869 not to EMACS_INT, to avoid GCC warning.
870
4a1b9832
PE
871 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
872
55daad71
PE
873 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
874 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
875 isn't needed on 32-bit machines.
8f95c75c 876
01103c44
PE
877 * buffer.c (Fgenerate_new_buffer_name):
878 Use EMACS_INT for count, not int.
0ceccced 879 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
880
881 * data.c (Qcompiled_function): Now static.
882
c6f072e7
PE
883 * window.c (window_body_lines): Now static.
884
20ce5912
PE
885 * image.c (gif_load): Rename local to avoid shadowing.
886
9c4c5f81
PE
887 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
888 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
889 * alloc.c (make_save_value): Integer argument is now of type
890 ptrdiff_t, not int.
891 (mark_object): Use ptrdiff_t, not int.
892 * lisp.h (pD): New macro.
893 * print.c (print_object): Use it.
894
c0c5c8ae
PE
895 * alloc.c: Use EMACS_INT, not int, to count objects.
896 (total_conses, total_markers, total_symbols, total_vector_size)
897 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
898 (total_free_floats, total_floats, total_free_intervals)
899 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
900 Now EMACS_INT, not int. All uses changed.
901 (Fgarbage_collect): Compute overall total using a double, so that
902 integer overflow is less likely to be a problem. Check for overflow
903 when converting back to an integer.
5a25e253
PE
904 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
905 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
906 These were 'int' variables that could overflow on 64-bit hosts;
907 they were never used, so remove them instead of repairing them.
211a0b2a 908 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
909 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
910 Previously, this ceilinged at INT_MAX, but that doesn't work on
911 64-bit machines.
e46bb31a 912 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 913
c78baabf 914 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 915 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
916 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
917 when a (possibly-narrower) signed value would do just as well.
918 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 919
c9d624c6
PE
920 * alloc.c: Catch some string size overflows that we were missing.
921 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
922 for convenience in STRING_BYTES_MAX.
923 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
924 The definition here is exact; the one in lisp.h was approximate.
925 (allocate_string_data): Check for string overflow. This catches
926 some instances we weren't catching before. Also, it catches
927 size_t overflow on (unusual) hosts where SIZE_MAX <= min
928 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
929 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 930
c9d624c6
PE
931 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
932 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
933 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
934
353032ce
PE
935 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
936
2bccce07
PE
937 * alloc.c (Fmake_string): Check for out-of-range init.
938
0ac30604
SM
9392011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
940
941 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
942
c195f2de
JD
9432011-06-14 Jan Djärv <jan.h.d@swipnet.se>
944
945 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
946 xg_get_default_scrollbar_width.
947
948 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
949 (int_gtk_range_get_value): Move to the scroll bar part of the file.
950 (style_changed_cb): Call update_theme_scrollbar_width and call
951 x_set_scroll_bar_default_width and xg_frame_set_char_size for
952 all frames (Bug#8505).
953 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
954 Call gtk_window_set_resizable if HAVE_GTK3.
955 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
956 and height if HAVE_GTK3 (Bug#8505).
957 (scroll_bar_width_for_theme): New variable.
958 (update_theme_scrollbar_width): New function.
959 (xg_get_default_scrollbar_width): Move code to
960 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
961 (xg_initialize): Call update_theme_scrollbar_width.
962
963 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
964
965 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
966
e10ac9f1
MR
9672011-06-12 Martin Rudalics <rudalics@gmx.at>
968
969 * frame.c (make_frame): Call other_buffer_safely instead of
970 other_buffer.
971
972 * window.c (temp_output_buffer_show): Call display_buffer with
973 second argument Vtemp_buffer_show_specifiers and reset latter
974 immediately after the call.
975 (Vtemp_buffer_show_specifiers): New variable.
976 (auto_window_vscroll_p, next_screen_context_lines)
977 (Vscroll_preserve_screen_position): Remove leading asterisks from
978 doc-strings.
979
2d3c217e 9802011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 981
7b7f97e8 982 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
983 * buffer.c (Qclone_number): Remove for now, as it's unused.
984 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
985 (record_buffer): Remove unused local.
986 * frame.c (other_visible_frames, frame_buffer_list): Now static.
987 (set_frame_buffer_list): Remove; unused.
988 * frame.h (other_visible_frames): Remove decl.
989 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
990 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
991 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
992 if HAVE_GPM.
993 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
994 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
995 Define only if HAVE_GPM.
996 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
997 (update_hints_inhibit): Remove; never set. All uses removed.
998 * widgetprv.h (emacsFrameClassRec): Remove decl.
999 * window.c (delete_deletable_window): Now returns void, since it
1000 wasn't returning anything.
1001 (compare_window_configurations): Remove unused locals.
1002 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1003 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1004 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1005 the same widths as pointers. This follows up on the 2011-05-06 patch.
1006 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1007 * xterm.h: Likewise.
1008 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1009
1384b89e
JB
10102011-06-12 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * makefile.w32-in: Update dependencies.
1013 (LISP_H): Add lib/intprops.h.
1014
1100a63c
CY
10152011-06-11 Chong Yidong <cyd@stupidchicken.com>
1016
1017 * image.c (gif_load): Add animation frame delay to the metadata.
1018 (syms_of_image): Use DEFSYM. New symbol `delay'.
1019
6198ccd0
MR
10202011-06-11 Martin Rudalics <rudalics@gmx.at>
1021
1022 * window.c (delete_deletable_window): Re-add.
1023 (Fset_window_configuration): Rewrite to handle dead buffers and
1024 consequently deletable windows.
1025 (window_tree, Fwindow_tree): Remove. Supply functionality in
1026 window.el.
1027 (compare_window_configurations): Simplify code.
1028
b6e3633c
AS
10292011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1030
1ab0dee5
AS
1031 * image.c (imagemagick_load_image): Fix type mismatch.
1032 (Fimagemagick_types): Likewise.
1033
b6e3633c
AS
1034 * window.h (replace_buffer_in_windows): Declare.
1035
9397e56f
MR
10362011-06-11 Martin Rudalics <rudalics@gmx.at>
1037
1038 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1039 Qclone_number. Remove external declaration of Qdelete_window.
1040 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1041 code.
1042 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1043 Qbuffer_list_update_hook if allowed.
1044 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1045 buffer list implementation.
1046 (other_buffer_safely): New function.
1047 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1048 calls to replace_buffer_in_windows and
1049 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1050 if allowed.
1051 (record_buffer): Inhibit quitting and rewrite using quittable
1052 functions. Run Qbuffer_list_update_hook if allowed.
1053 (Frecord_buffer, Funrecord_buffer): New functions.
1054 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1055 switch-to-buffer to window.el.
1056 (bury-buffer): Move to window.el.
1057 (Vbuffer_list_update_hook): New variable.
1058
1059 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1060 section.
1061
1062 * window.h (resize_frame_windows): Move up in code.
1063 (Fwindow_frame): Remove EXFUN.
1064 (replace_buffer_in_all_windows): Remove prototype.
1065 (replace_buffer_in_windows_safely): Add prototype.
1066
1067 * window.c: Declare Qdelete_window static again. Move down
1068 declaration of select_count.
1069 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1070 (Fother_window): Move to window.el.
1071 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1072 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1073 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1074 window.el.
1075 (replace_buffer_in_windows): Implement by calling
1076 Qreplace_buffer_in_windows.
1077 (replace_buffer_in_all_windows): Remove with some functionality
1078 moved into replace_buffer_in_windows_safely.
1079 (replace_buffer_in_windows_safely): New function.
1080 (select_window_norecord, select_frame_norecord): Move in front
1081 of run_window_configuration_change_hook. Remove now obsolete
1082 declarations.
1083 (Fset_window_buffer): Rewrite doc-string. Call
1084 Qrecord_window_buffer.
1085 (keys_of_window): Move binding for other-window to window.el.
1086
b50691aa
CY
10872011-06-11 Chong Yidong <cyd@stupidchicken.com>
1088
1089 * dispextern.h (struct image): Replace data member, whose int_val
1090 and ptr_val fields were not used by anything, with a single
1091 lisp_val object.
1092
1093 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1094 (gif_clear_image, gif_load, imagemagick_load_image)
1095 (gs_clear_image, gs_load): Callers changed.
1096
3f754b86
PE
10972011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1098
cca69397
PE
1099 * buffer.h: Include <time.h>, for time_t.
1100 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1101
109e28d0
PE
1102 Fix minor problems found by static checking.
1103
60737f02
PE
1104 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1105
4b66faf3
PE
1106 Make identifiers static if they are not used in other modules.
1107 * data.c (Qcompiled_function, Qframe, Qvector):
1108 * image.c (QimageMagick, Qsvg):
1109 * minibuf.c (Qmetadata):
1110 * window.c (resize_window_check, resize_root_window): Now static.
1111 * window.h (resize_window_check, resize_root_window): Remove decls.
1112
109e28d0
PE
1113 * window.c (window_deletion_count, delete_deletable_window):
1114 Remove; unused.
46a4ce9e
PE
1115 (window_body_lines): Now static.
1116 (Fdelete_other_windows_internal): Mark vars as initialized.
1117 Make sure 'resize_failed' is initialized.
1118 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1119 (resize_window_apply): Remove unused local.
1120 * window.h (delete_deletable_window): Remove decl.
1121
109e28d0 1122 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1123 (imagemagick_load_image): Fix pointer signedness problem by changing
1124 last arg from unsigned char * to char *. All uses changed.
1125 Also, fix a local for similar reasons.
1126 Remove unused locals. Remove locals to avoid shadowing.
1127 (fn_rsvg_handle_free): Remove; unused.
1128 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1129 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1130
3f754b86
PE
1131 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1132
2547adb1
CY
11332011-06-10 Chong Yidong <cyd@stupidchicken.com>
1134
1135 * image.c (gif_load): Fix omitted cast error introduced by
1136 2011-06-06 change.
1137
2c8e37d4
MR
11382011-06-10 Martin Rudalics <rudalics@gmx.at>
1139
1140 * window.h (resize_proportionally, orig_total_lines)
1141 (orig_top_line): Remove from window structure.
1142 (set_window_height, set_window_width, change_window_heights)
1143 (Fdelete_window): Remove prototypes.
1144 (resize_frame_windows): Remove duplicate declaration.
1145
440a42e3
EZ
11462011-06-10 Eli Zaretskii <eliz@gnu.org>
1147
1148 * window.h (resize_frame_windows, resize_window_check)
1149 (delete_deletable_window, resize_root_window)
1150 (resize_frame_windows): Declare prototypes.
1151
1152 * window.c (resize_window_apply): Make definition be "static" to
1153 match the prototype.
1154
562dd5e9
MR
11552011-06-10 Martin Rudalics <rudalics@gmx.at>
1156
1157 * window.c: Remove declarations of Qwindow_size_fixed,
1158 window_min_size_1, window_min_size_2, window_min_size,
1159 size_window, window_fixed_size_p, enlarge_window, delete_window.
1160 Remove static from declaration of Qdelete_window, it's
1161 temporarily needed by Fbury_buffer.
1162 (replace_window): Don't assign orig_top_line and
1163 orig_total_lines.
1164 (Fdelete_window, delete_window): Remove. Window deletion is
1165 handled by window.el.
1166 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1167 Fdelete_window calls with calls to Qdelete_window.
1168 (Fdelete_other_windows): Remove. Deleting other windows is
1169 handled by window.el.
1170 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1171 handled in window.el.
1172 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1173 Window minimum sizes are handled in window.el.
1174 (shrink_windows, size_window, set_window_height)
1175 (set_window_width, change_window_heights, window_height)
1176 (window_width, CURBEG, CURSIZE, enlarge_window)
1177 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1178 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1179 handled in window.el.
1180 (make_dummy_parent): Rename to make_parent_window and give it a
1181 second argument horflag.
1182 (make_window): Don't set resize_proportionally any more.
1183 (Fsplit_window): Remove. Windows are split in window.el.
1184 (save_restore_action, save_restore_orig_size)
1185 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1186 Resize mini windows in window.el.
1187 (grow_mini_window, shrink_mini_window): Implement by calling
1188 Qresize_root_window_vertically, resize_window_check and
1189 resize_window_apply.
1190 (saved_window, Fset_window_configuration, save_window_save): Do
1191 not handle orig_top_line, orig_total_lines, and
1192 resize_proportionally.
1193 (window_min_height, window_min_width): Move to window.el.
1194 (keys_of_window): Move bindings for delete-other-windows,
1195 split-window, delete-window and enlarge-window to window.el.
1196
1197 * buffer.c: Temporarily extern Qdelete_window.
1198 (Fbury_buffer): Temporarily call Qdelete_window instead of
1199 Fdelete_window (Fbury_buffer will move to window.el soon).
1200
1201 * frame.c (set_menu_bar_lines_1): Remove code handling
1202 orig_top_line and orig_total_lines.
1203
1204 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1205 set_window_height but set heights directly.
1206 (change_frame_size_1): Use resize_frame_windows.
1207
1208 * xdisp.c (init_xdisp): Don't use set_window_height but set
1209 heights directly.
1210
1211 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1212 resize_frame_windows instead of change_window_heights and run
1213 run_window_configuration_change_hook.
1214
1215 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1216 instead of change_window_heights and run
1217 run_window_configuration_change_hook.
1218
1a13852e
MR
12192011-06-09 Martin Rudalics <rudalics@gmx.at>
1220
1221 * window.c (replace_window): Rename second argument REPLACEMENT to
1222 NEW. New third argument SETFLAG. Rewrite.
1223 (delete_window, make_dummy_parent): Call replace_window with
1224 third argument 1.
1225 (window_list_1): Move down in code.
1226 (run_window_configuration_change_hook): Move set_buffer part
1227 before select_frame_norecord part in order to unwind correctly.
1228 Rename count1 to count.
1229 (recombine_windows, delete_deletable_window, resize_root_window)
1230 (Fdelete_other_windows_internal)
1231 (Frun_window_configuration_change_hook, make_parent_window)
1232 (resize_window_check, resize_window_apply, Fresize_window_apply)
1233 (resize_frame_windows, Fsplit_window_internal)
1234 (Fdelete_window_internal, Fresize_mini_window_internal): New
1235 functions.
1236 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1237
f3d1777e
MR
12382011-06-08 Martin Rudalics <rudalics@gmx.at>
1239
496e208e
MR
1240 * window.h (window): Add some new members to window structure -
1241 normal_lines, normal_cols, new_total, new_normal, clone_number,
1242 splits, nest, prev_buffers, next_buffers.
1243 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1244 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1245
f3d1777e
MR
1246 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1247 Remove.
496e208e
MR
1248 (make_dummy_parent): Set new members of windows structure.
1249 (make_window): Move down in code. Handle new members of window
1250 structure.
1251 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1252 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1253 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1254 (Fset_window_prev_buffers, Fwindow_next_buffers)
1255 (Fset_window_next_buffers, Fset_window_clone_number): New
1256 functions.
1257 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1258 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1259 Doc-string fixes.
1260 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1261 Argument WINDOW can be now internal window too.
1262 (Fwindow_use_time): Move up in code.
1263 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1264 Rewrite doc-string.
1265 (Fset_window_configuration, saved_window)
1266 (Fcurrent_window_configuration, save_window_save): Handle new
1267 members of window structure.
b9e809c2
MR
1268 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1269 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1270 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1271 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1272 Qget_mru_window, Qresize_root_window,
1273 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1274 Qauto_buffer_name; staticpro them.
f3d1777e 1275
abde8f8c
MR
12762011-06-07 Martin Rudalics <rudalics@gmx.at>
1277
1278 * window.c (Fwindow_total_size, Fwindow_left_column)
1279 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1280 (Fwindow_list_1): New functions.
1281 (window_box_text_cols): Replace with window_body_cols.
1282 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1283 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1284 (delete_window, Fset_window_configuration): Call
1285 delete_all_subwindows with window as argument.
1286 (delete_all_subwindows): Take a window as argument and not a
1287 structure. Rewrite.
190b47e6
MR
1288 (window_loop): Remove handling of GET_LRU_WINDOW and
1289 GET_LARGEST_WINDOW.
1290 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1291
1292 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1293 window_box_text_cols. delete_all_subwindows now takes a
1294 Lisp_Object as argument.
abde8f8c
MR
1295
1296 * indent.c (compute_motion, Fcompute_motion): Use
1297 window_body_cols instead of window_box_text_cols.
1298
fa8a67e6
MR
1299 * frame.c (delete_frame): Call delete_all_subwindows with root
1300 window as argument.
1301
a54e3482
DC
13022011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1303
1304 * fns.c (Fputhash): Document return value.
1305
60002bf5
CY
13062011-06-06 Chong Yidong <cyd@stupidchicken.com>
1307
1308 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1309
0c671da6 13102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1311
b862a52a 1312 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1313
be44ca6c
PE
1314 Check for overflow when converting integer to cons and back.
1315 * charset.c (Fdefine_charset_internal, Fdecode_char):
1316 Use cons_to_unsigned to catch overflow.
1317 (Fencode_char): Use INTEGER_TO_CONS.
1318 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1319 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1320 * data.c (long_to_cons, cons_to_long): Remove.
1321 (cons_to_unsigned, cons_to_signed): New functions.
1322 These signal an error for invalid or out-of-range values.
1323 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1324 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1325 * font.c (Ffont_variation_glyphs):
1326 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1327 * lisp.h: Include <intprops.h>.
1328 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1329 (cons_to_signed, cons_to_unsigned): New decls.
1330 (long_to_cons, cons_to_long): Remove decls.
1331 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1332 (Fprimitive_undo): Use CONS_TO_INTEGER.
1333 * xfns.c (Fx_window_property): Likewise.
1334 * xselect.c: Include <limits.h>.
1335 (x_own_selection, selection_data_to_lisp_data):
1336 Use INTEGER_TO_CONS.
1337 (x_handle_selection_request, x_handle_selection_clear)
1338 (x_get_foreign_selection, Fx_disown_selection_internal)
1339 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1340 (lisp_data_to_selection_data): Use cons_to_unsigned.
1341 (x_fill_property_data): Use cons_to_signed.
1342 Report values out of range.
1343
d1f3d2af
PE
1344 Check for buffer and string overflow more precisely.
1345 * buffer.h (BUF_BYTES_MAX): New macro.
1346 * lisp.h (STRING_BYTES_MAX): New macro.
1347 * alloc.c (Fmake_string):
1348 * character.c (string_escape_byte8):
1349 * coding.c (coding_alloc_by_realloc):
1350 * doprnt.c (doprnt):
1351 * editfns.c (Fformat):
1352 * eval.c (verror):
1353 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1354 since they may not be the same number.
1355 * editfns.c (Finsert_char):
1356 * fileio.c (Finsert_file_contents):
1357 Likewise for BUF_BYTES_MAX.
1358
dd52fcea
PE
1359 * image.c: Use ptrdiff_t, not int, for sizes.
1360 (slurp_file): Switch from int to ptrdiff_t.
1361 All uses changed.
1362 (slurp_file): Check that file size fits in both size_t (for
1363 malloc) and ptrdiff_t (for sanity and safety).
1364
7f9bbdbb
PE
1365 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1366 if b->modtime has its maximal value.
1367
dfe18f82
PE
1368 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1369
84acfcf0
PE
1370 Don't assume time_t can fit into int.
1371 * buffer.h (struct buffer.modtime): Now time_t, not int.
1372 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1373 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1374
ccd9a01a
PE
1375 Minor fixes for signed vs unsigned integers.
1376 * character.h (MAYBE_UNIFY_CHAR):
1377 * charset.c (maybe_unify_char):
1378 * keyboard.c (read_char, reorder_modifiers):
1379 XINT -> XFASTINT, since the integer must be nonnegative.
1380 * ftfont.c (ftfont_spec_pattern):
1381 * keymap.c (access_keymap, silly_event_symbol_error):
1382 XUINT -> XFASTINT, since the integer must be nonnegative.
1383 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1384 since it makes no difference and we prefer signed.
1385 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1386 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1387 nonnegative.
1388
d6d100dd
SM
13892011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1390
1391 * window.h (Fwindow_frame): Declare.
1392
2b6148e4
PE
13932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1394
1395 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1396 (SPARE_MEMORY): Always define.
1397 (LARGE_REQUEST): Remove.
1398 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1399
f230ecc9
MR
14002011-06-06 Martin Rudalics <rudalics@gmx.at>
1401
727e958e
MR
1402 * lisp.h: Move EXFUNS for Fframe_root_window,
1403 Fframe_first_window and Fset_frame_selected_window to window.h.
1404
1405 * window.h: Move EXFUNS for Fframe_root_window,
1406 Fframe_first_window and Fset_frame_selected_window here from
1407 lisp.h.
1408
1409 * frame.c (Fwindow_frame, Fframe_first_window)
1410 (Fframe_root_window, Fframe_selected_window)
1411 (Fset_frame_selected_window): Move to window.c.
1412 (Factive_minibuffer_window): Move to minibuf.c.
1413 (Fother_visible_frames_p): New function.
1414
1415 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1416
f230ecc9
MR
1417 * window.c (decode_window, decode_any_window): Move up in code.
1418 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1419 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1420 (Fwindow_buffer): Move up and rewrite doc-string.
1421 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1422 (Fwindow_prev): New functions.
727e958e
MR
1423 (Fwindow_frame): Move here from frame.c. Accept any window as
1424 argument.
1425 (Fframe_root_window, Fframe_first_window)
1426 (Fframe_selected_window): Move here from frame.c. Accept frame
1427 or arbitrary window as argument. Update doc-strings.
1428 (Fminibuffer_window): Move up in code.
1429 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1430 (Fset_frame_selected_window): Move here from frame.c.
1431 Marginal rewrite.
727e958e
MR
1432 (Fselected_window, select_window, Fselect_window): Move up in
1433 code. Minor doc-string fixes.
f230ecc9 1434
4d09bcf6
PE
14352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1438 Do not assume that spare memory exists; that assumption is valid
1439 only if SYSTEM_MALLOC.
1440 (LARGE_REQUEST): New macro, so that the issue of large requests
1441 is separated from the issue of spare memory.
1442
810928a2
AS
14432011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1444
172418ad
AS
1445 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1446 format. (Bug#8806)
1447
43f862f7
AS
1448 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1449
810928a2
AS
1450 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1451 before statements.
1452
a059fe24
JD
14532011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1454
1455 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1456
1457 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1458
1459 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1460 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1461
989bf368
JB
14622011-06-05 Juanma Barranquero <lekktu@gmail.com>
1463
1464 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1465
4b80f674
CY
14662011-06-04 Chong Yidong <cyd@stupidchicken.com>
1467
1468 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1469 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1470 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1471 New error handlers.
4b80f674
CY
1472 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1473 Obey Vx_select_enable_clipboard_manager. Catch errors in
1474 x_clipboard_manager_save (Bug#8779).
1475 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1476 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1477
99a33b77 14782011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1479
1480 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1481
99a33b77 14822011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1483
1484 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1485 in the current matrix if keep_current_p is non-zero.
1486
8264569d
EZ
14872011-06-04 Eli Zaretskii <eliz@gnu.org>
1488
1489 * bidi.c (bidi_level_of_next_char): Fix last change.
1490
57f97249
EZ
14912011-06-03 Eli Zaretskii <eliz@gnu.org>
1492
fec2107c 1493 Support bidi reordering of text covered by display properties.
57f97249 1494
fec2107c
EZ
1495 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1496 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1497 (bidi_cache_search, bidi_cache_iterator_state)
1498 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1499 (bidi_level_of_next_char, bidi_move_to_visually_next):
1500 Support character positions inside a run of characters covered by a
fec2107c
EZ
1501 display string.
1502 (bidi_paragraph_init, bidi_resolve_explicit_1)
1503 (bidi_level_of_next_char): Call bidi_fetch_char and
1504 bidi_fetch_char_advance instead of FETCH_CHAR and
1505 FETCH_CHAR_ADVANCE.
1506 (bidi_init_it): Initialize new members.
1507 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1508 definitions.
1509 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1510 instead of using explicit *_CHAR codes.
d6d100dd
SM
1511 (bidi_resolve_explicit, bidi_resolve_weak):
1512 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1513 bidirectional text is supported only in multibyte buffers.
1514 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1515 it to initialize the frame_window_p member of struct bidi_it.
1516 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1517 (bidi_resolve_explicit, bidi_resolve_weak)
1518 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1519 bidi_it->nchars is non-positive.
1520 (bidi_level_of_next_char): Don't try to lookup the cache for the
1521 next/previous character if nothing is cached there yet, or if we
1522 were just reseat()'ed to a new position.
c40e2fb2 1523
0e14fe90
EZ
1524 * xdisp.c (set_cursor_from_row): Set start and stop points
1525 according to the row's direction when priming the loop that looks
1526 for the glyph on which to display cursor.
1527 (single_display_spec_intangible_p): Function deleted.
1528 (display_prop_intangible_p): Reimplement to call
1529 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1530 Accept 3 additional arguments needed by handle_display_spec.
1531 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1532 values: lists, `(when COND...)' forms, etc.
1533 (single_display_spec_string_p): Support property values that are
1534 lists with the argument STRING its top-level element.
1535 (display_prop_string_p): Fix the condition for processing a
1536 property that is a list to be consistent with handle_display_spec.
fec2107c 1537 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1538 last portion of handle_display_prop.
1539 (compute_display_string_pos): Accept additional argument
1540 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1541 value of a `display' property is a "replacing spec".
1542 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1543 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1544 the display property, but just return a value indicating whether
1545 the display property will replace the characters it covers.
1546 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1547 frame_window_p members of struct bidi_it.
d6d100dd
SM
1548 (compute_display_string_pos, compute_display_string_end):
1549 New functions.
fec2107c
EZ
1550 (push_it): Accept second argument POSITION, where pop_it should
1551 jump to continue iteration.
1552 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1553
fec2107c
EZ
1554 * keyboard.c (adjust_point_for_property): Adjust the call to
1555 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1556
1557 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1558 (bidi_init_it): Update prototypes.
1559 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1560 (compute_display_string_pos, compute_display_string_end):
1561 Declare prototypes.
fec2107c
EZ
1562 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1563 EMACS_INT.
fc6f18ce 1564
40087514 15652011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1566
57f53182
PE
1567 Malloc failure behavior now depends on size of allocation.
1568 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1569 * lisp.h: Change signatures accordingly.
1570 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1571 All callers changed. (Bug#8762)
1572
1573 * gnutls.c: Use Emacs's memory allocators.
1574 Without this change, the gnutls library would invoke malloc etc.
1575 directly, which causes problems on non-SYNC_INPUT hosts, and which
1576 runs afoul of improving memory_full behavior. (Bug#8761)
1577 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1578 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1579 xfree instead of the default malloc, realloc, free.
1580 (Fgnutls_boot): No need to check for memory allocation failure,
1581 since xmalloc does that for us.
1582
ac32cd99 1583 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1584 * category.c (hash_get_category_set):
1585 * ccl.c (ccl_driver):
1586 * charset.c (Fdefine_charset_internal):
1587 * charset.h (struct charset.hash_index):
1588 * composite.c (get_composition_id, gstring_lookup_cache)
1589 (composition_gstring_put_cache):
1590 * composite.h (struct composition.hash_index):
1591 * dispextern.h (struct image.hash):
1592 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1593 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1594 (hashfn_equal, hashfn_user_defined, make_hash_table)
1595 (maybe_resize_hash_table, hash_lookup, hash_put)
1596 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1597 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1598 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1599 * image.c (make_image, search_image_cache, lookup_image)
1600 (xpm_put_color_table_h):
1601 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1602 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1603 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1604 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1605 * alloc.c (allocate_vectorlike):
1606 Check for overflow in vector size calculations.
1607 * ccl.c (ccl_driver):
1608 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1609 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1610 need to be updated by these changes.
40087514
PE
1611 * fns.c (make_hash_table, maybe_resize_hash_table):
1612 Check for integer overflow with large hash tables.
0de4bb68
PE
1613 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1614 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1615 (SXHASH_REDUCE): New macro.
1616 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1617 Use it instead of discarding useful hash info with large hash values.
1618 (sxhash_float): New function.
1619 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1620 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1621 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1622 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1623 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1624 Adjust signatures to match updated version of code.
1625 (consing_since_gc): Now EMACS_INT, since a single hash table can
1626 use more than INT_MAX bytes.
1627
698d32e2
DN
16282011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1629
1630 Make it possible to build with GCC-4.6+ -O2 -flto.
1631
1632 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1633
fd6fa53f
SM
16342011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1635
1636 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1637 Call minibuffer-inactive-mode.
1638
864db017
JB
16392011-05-31 Juanma Barranquero <lekktu@gmail.com>
1640
1641 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1642 Update dependencies.
1643
2ad0baf4
DN
16442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1645
1646 * data.c (init_data): Remove code for UTS, this system is not
1647 supported anymore.
1648
4fcc2638
DN
16492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1650
1651 Don't force ./temacs to start in terminal mode.
1652
1653 * frame.c (make_initial_frame): Initialize faces in all cases, not
1654 only when CANNOT_DUMP is defined.
1655 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1656
c56e0fd5
DN
16572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1658
1659 * dispnew.c (add_window_display_history): Use const for the string
1660 pointer. Remove declaration, not needed.
1661
333d54da 16622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1663
55d4c1b2 1664 Use 'inline', not 'INLINE'.
333d54da 1665 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1666 * alloc.c, fontset.c (INLINE): Remove.
1667 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1668 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1669 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1670 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1671 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1672
738db178
DN
16732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1674
1675 Make it possible to run ./temacs.
1676
1677 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1678 syms_of_callproc does the same thing. Remove test for
1679 "initialized", do it in the caller.
1680 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1681
620c53a6
SM
16822011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1683
1684 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1685 (read_minibuf): Use get_minibuffer.
1686 (syms_of_minibuf): Use DEFSYM.
1687 (Qmetadata): New var.
1688 * data.c (Qbuffer): Don't make it static.
1689 (syms_of_data): Use DEFSYM.
1690
e003a292
PE
16912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1694 (CCL_CODE_MIN): New macro.
1695
ed008a6d
PE
16962011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1697
3687c2ef
PE
1698 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1699
ed008a6d
PE
1700 * eval.c (Qdebug): Now static.
1701 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1702 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1703 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1704
d66c4c7c
CY
17052011-05-29 Chong Yidong <cyd@stupidchicken.com>
1706
1707 * image.c: Various fixes to ImageMagick code comments.
1708 (Fimagemagick_types): Doc fix.
1709
5fbc2025
PE
17102011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1711
0196f88a
PE
1712 Minor fixes prompted by GCC 4.6.0 warnings.
1713
1714 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1715
5fbc2025
PE
1716 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1717 (x_clipboard_manager_save_all): Move extern decl to ...
1718 * xterm.h: ... here, so that it can be checked for consistency.
1719
1dd3c2d9
CY
17202011-05-29 Chong Yidong <cyd@stupidchicken.com>
1721
1722 * xselect.c (x_clipboard_manager_save_frame)
1723 (x_clipboard_manager_save_all): New functions.
1724 (Fx_clipboard_manager_save): Lisp function deleted.
1725
1726 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1727 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1728
1729 * xterm.h: Update prototype.
1730
5ba6571d
WX
17312011-05-28 William Xu <william.xwl@gmail.com>
1732
1733 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1734 exiting (Bug#8239).
1735
3eaff834
JM
17362011-05-28 Jim Meyering <meyering@redhat.com>
1737
e1900994 1738 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1739 * fns.c (to_uchar): Define.
1740 (crypto_hash_function): Use it to convert some newly-signed
1741 variables to unsigned, to avoid sign-extension bugs. For example,
1742 without this change, (md5 "truc") would evaluate to
1743 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1744 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1745 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1746
0f6990a7
PE
17472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 Integer overflow fixes.
c8a9ca5a 1750
08686060
PE
1751 * dbusbind.c: Serial number integer overflow fixes.
1752 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1753 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1754 to hold a serial number that is too large for a fixnum.
1755 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1756 Check for serial numbers out of range. Decode any serial number
59568bf0 1757 that was so large that it became a float. (Bug#8722)
08686060 1758
2d1fc3c7
PE
1759 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1760 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1761 Use XFASTINT rather than XUINT when numbers are nonnegative.
1762 (xd_append_arg, Fdbus_method_return_internal):
1763 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1764 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1765 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1766 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1767 (Bug#8722)
2d1fc3c7 1768
c8a9ca5a
PE
1769 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1770
519e1d69
PE
1771 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1772
30569699
PE
1773 ccl: add integer overflow checks
1774 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1775 (IN_INT_RANGE): New macros.
1776 (ccl_driver): Use them to check for integer overflow when
1777 decoding a CCL program. Many of the new checks are whether XINT (x)
1778 fits in int; it doesn't always, on 64-bit hosts. The new version
1779 doesn't catch all possible integer overflows, but it's an
847044ea 1780 improvement. (Bug#8719)
30569699 1781
c11285dc
PE
1782 * alloc.c (make_event_array): Use XINT, not XUINT.
1783 There's no need for unsigned here.
1784
fdccd48e
PE
1785 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1786 This follows up to the 2011-05-06 change that substituted uintptr_t
1787 for EMACS_INT. This case wasn't caught back then.
1788
37910ab2
PE
1789 Rework Fformat to avoid integer overflow issues.
1790 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1791 now (part of C89). Include <verify.h>.
1792 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1793 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1794 (Fformat): Avoid the prepass trying to compute sizes; it was only
1795 approximate and thus did not catch overflow reliably. Instead, walk
1796 through the format just once, formatting and computing sizes as we go,
1797 checking for integer overflow at every step, and allocating a larger
1798 buffer as needed. Keep track separately whether the format is
1799 multibyte. Keep only the most-recently calculated precision, rather
1800 than them all. Record whether each argument has been converted to
1801 string. Use EMACS_INT, not int, for byte and char and arg counts.
1802 Support field widths and precisions larger than INT_MAX. Avoid
1803 sprintf's undefined behavior with conversion specifications such as %#d
1804 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1805 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1806 formatting out-of-range floating point numbers with int
1807 formats. (Bug#8668)
1808
2e6578fb
PE
1809 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1810
0ae6bdee
PE
1811 * data.c: Avoid integer truncation in expressions involving floats.
1812 * data.c: Include <intprops.h>.
1813 (arith_driver): When there's an integer overflow in an expression
1814 involving floating point, convert the integers to floating point
1815 so that the resulting value does not suffer from catastrophic
1816 integer truncation. For example, on a 64-bit host (* 4
1817 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1818 Do not rely on undefined behavior after integer overflow.
1819
de883a70
PE
1820 merge count_size_as_multibyte, parse_str_to_multibyte
1821 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1822 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1823 Check for integer overflow.
1824 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1825 since it's now a duplicate of the other. This is more of
1826 a character than a buffer op, so better that it's in character.c.
1827 * fns.c, print.c: Adjust to above changes.
1828
2ff916cb
PE
18292011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1830
1831 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1832
f1b54466
PE
18332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1834
fb1ac845
PE
1835 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1836 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1837 (x_clipboard_manager_save): Now static.
1838 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1839
f1b54466
PE
1840 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1841 (crypto_hash_function): Now static.
1842 Fix pointer signedness problems. Avoid unnecessary initializations.
1843
a9f737ee
CY
18442011-05-27 Chong Yidong <cyd@stupidchicken.com>
1845
1846 * termhooks.h (Vselection_alist): Make it terminal-local.
1847
1848 * terminal.c (create_terminal): Initialize it.
1849
1850 * xselect.c: Support for clipboard managers.
1851 (Vselection_alist): Move to termhooks.h as terminal-local var.
1852 (LOCAL_SELECTION): New macro.
1853 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1854 (symbol_to_x_atom): Remove gratuitous arg.
1855 (x_handle_selection_request, lisp_data_to_selection_data)
1856 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1857 (x_own_selection, x_get_local_selection, x_convert_selection):
1858 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1859 (some_frame_on_display): Delete unused function.
1860 (Fx_own_selection_internal, Fx_get_selection_internal)
1861 (Fx_disown_selection_internal, Fx_selection_owner_p)
1862 (Fx_selection_exists_p): New optional frame arg.
1863 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1864 (x_handle_selection_clear): Don't treat other terminals with the
1865 same keyboard specially. Use the terminal-local Vselection_alist.
1866 (x_clear_frame_selections): Use Frun_hook_with_args.
1867
1868 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1869
1870 * xterm.h: Add support for those atoms.
1871
e067f0c1
CY
18722011-05-26 Chong Yidong <cyd@stupidchicken.com>
1873
1874 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1875 (converted_selections, conversion_fail_tag): New global variables.
1876 (x_selection_request_lisp_error): Free the above.
1877 (x_get_local_selection): Remove unnecessary code.
1878 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1879 of converted selections stored in converted_selections.
1880 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1881 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1882 (x_convert_selection): New function.
1883 (x_handle_selection_event): Simplify.
1884 (x_get_foreign_selection): Don't ignore incoming requests while
1885 waiting for an answer; this will fail when we implement
1886 SAVE_TARGETS, and seems unnecessary anyway.
1887 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1888 (Vx_sent_selection_functions): Doc fix.
1889
0f4aebc0
LL
18902011-05-26 Leo Liu <sdl.web@gmail.com>
1891
1892 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1893
e61124cd
YM
18942011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1895
1896 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1897
1898 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1899 for fringe update if it has periodic bitmap.
1900 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1901 and fringe_bitmap_periodic_p.
1902
1903 * fringe.c (get_fringe_bitmap_data): New function.
1904 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1905 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1906 row. Mark glyph row for fringe update if periodicity changed.
1907
1908 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1909 for fringe update unless it has periodic bitmap.
1910
f16d9837
KH
19112011-05-25 Kenichi Handa <handa@m17n.org>
1912
1913 * xdisp.c (get_next_display_element): Set correct it->face_id for
1914 a static composition.
1915
e1b90ef6
LL
19162011-05-24 Leo Liu <sdl.web@gmail.com>
1917
1918 * deps.mk (fns.o):
1919 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1920
1921 * fns.c (crypto_hash_function, Fsha1): New function.
1922 (Fmd5): Use crypto_hash_function.
1923 (syms_of_fns): Add Ssha1.
1924
7400048f
PE
19252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * gnutls.c: Remove unused macros.
1928 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1929 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1930 Remove macros that are defined and never used.
1931 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1932
abb71cf4
CY
19332011-05-22 Chong Yidong <cyd@stupidchicken.com>
1934
1935 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1936 (Fx_get_selection_internal): Minor cleanup.
1937 (Fx_own_selection_internal): Rename arguments for consistency with
1938 select.el.
1939
6307db39
PE
19402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1943
f3d4e0a4
CY
19442011-05-22 Chong Yidong <cyd@stupidchicken.com>
1945
1946 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1947
4d8ade89
YM
19482011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1949
1950 * dispnew.c (scrolling_window): Don't exclude the case that the
1951 last enabled row in the desired matrix touches the bottom boundary.
1952
32078c8d
GM
19532011-05-21 Glenn Morris <rgm@gnu.org>
1954
1955 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1956 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1957 and add some more files.
32078c8d 1958
7285dc67
EZ
19592011-05-20 Eli Zaretskii <eliz@gnu.org>
1960
1961 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1962 report_file_error introduced by the change from 2011-05-07.
1963
89d1bd22
PE
19642011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 * systime.h (Time): Define only if emacs is defined.
1967 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1968 where the include path doesn't have X11/X.h by default. See
1969 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1970
e23640bb 19712011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1972
1973 * composite.c (find_automatic_composition): Fix previous change.
1974
b9704ad9
GM
19752011-05-20 Glenn Morris <rgm@gnu.org>
1976
1977 * lisp.mk: New file, split from Makefile.in.
1978 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1979 (shortlisp): Remove.
1980 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1981
4a720484
GM
19822011-05-19 Glenn Morris <rgm@gnu.org>
1983
1984 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1985 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1986 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1987 (lisp): Set the order to that of loadup.el.
1988 (shortlisp): Make it a copy of $lisp.
1989 (SOME_MACHINE_LISP): Remove.
1990 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1991 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1992
a28d4396
KH
19932011-05-18 Kenichi Handa <handa@m17n.org>
1994
1995 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1996 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1997 (find_automatic_composition): Mostly rewrite for efficiency.
1998
a2b1fa8e
JB
19992011-05-18 Juanma Barranquero <lekktu@gmail.com>
2000
2001 * makefile.w32-in: Update dependencies.
2002
8e1f5610
CS
20032011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2004
2005 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2006 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2007
7025ee00 20082011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2009
cdfa6eab
PE
2010 Fix some integer overflow issues, such as string length overflow.
2011
06d6db33
PE
2012 * insdel.c (count_size_as_multibyte): Check for string overflow.
2013
2b4560a8
PE
2014 * character.c (lisp_string_width): Check for string overflow.
2015 Use EMACS_INT, not int, for string indexes and lengths; in
2016 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2017 the resulting string length overflows an EMACS_INT; instead,
2018 report a string overflow if no precision given. When checking for
2019 precision exhaustion, use a check that cannot possibly have
2020 integer overflow. (Bug#8675)
2021 * character.h (lisp_string_width): Adjust to new signature.
2022
cb93f9be
PE
2023 * alloc.c (string_overflow): New function.
2024 (Fmake_string): Use it. This doesn't change behavior, but saves
2025 a few bytes and will simplify future changes.
2026 * character.c (string_escape_byte8): Likewise.
2027 * lisp.h (string_overflow): New decl.
2028
1a1f3366
PE
2029 Fixups, following up to the user-interface timestamp change.
2030 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2031 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2032 * msdos.c (mouse_get_pos): Likewise.
2033 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2034 * w32gui.h (Time): Define by including "systime.h" rather than by
2035 declaring it ourselves. (Bug#8664)
2036
d4e3e4d3
PE
2037 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2038 * image.c (clear_image_cache): Likewise.
2039
f6a24d19
PE
2040 * term.c (term_mouse_position): Don't assume time_t wraparound.
2041
08dc5ae6
PE
2042 Be more systematic about user-interface timestamps.
2043 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2044 and sometimes 'EMACS_UINT', to represent these timestamps.
2045 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2046 This makes the code easier to follow, and makes it easier to catch
2047 integer overflow bugs such as Bug#8664.
2048 * frame.c (Fmouse_position, Fmouse_pixel_position):
2049 Use Time, not unsigned long, for user-interface timestamps.
2050 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2051 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2052 * keyboard.h (last_event_timestamp): Likewise.
2053 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2054 * menu.h (xmenu_show): Likewise.
2055 * term.c (term_mouse_position): Likewise.
2056 * termhooks.h (struct input_event.timestamp): Likewise.
2057 (struct terminal.mouse_position_hook): Likewise.
2058 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2059 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2060 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2061 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2062 what it was before.
2063 * menu.h, termhooks.h: Include "systime.h", for Time.
2064
8e55734a
PE
2065 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2066 Don't assume that the difference between two unsigned long values
2067 can fit into an integer. At this point, we know button_down_time
2068 <= event->timestamp, so the difference must be nonnegative, so
2069 there's no need to cast the result if double-click-time is
2070 nonnegative, as it should be; check that it's nonnegative, just in
2071 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2072 apart (about 25 days). (Bug#8664)
8e55734a 2073
841f1b75 2074 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2075 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2076
3e26f69c
PE
2077 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2078 that always fit in int. Use a sentinel instead of a counter, to
2079 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2080 * frame.h (struct frame): Use int for menu_bar_items_used
2081 instead of EMACS_INT, since it always fits in int.
3e26f69c 2082
5cc152c0
PE
2083 * menu.c (grow_menu_items): Check for int overflow.
2084
d89eb65e
PE
2085 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2086
5235bd3e
PE
2087 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2088 Before, the code was not consistent. These values cannot exceed
2089 2**31 - 1 so there's no need to make them unsigned.
2090 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2091 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2092 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2093 as modifiers.
2094 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2095
bc827e23
PE
2096 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2097 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2098 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2099 presumably because the widths might not match.
2100
78eb494e
PE
2101 * window.c (size_window): Avoid needless test at loop start.
2102
04f2d78b
CB
21032011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2104
2105 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2106
d2fc7e3d 21072011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2108
2109 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2110
d2fc7e3d 21112011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2112
2113 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2114 `width' to `bar_area_x' and `bar_area_width', respectively.
2115 (x_scroll_run): Take account of fringe background extension.
2116
04f2d78b
CB
2117 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2118 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2119 `bar_area_width', respectively.
2120 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2121 background extension.
2122
79b70037
GM
21232011-05-10 Jim Meyering <meyering@redhat.com>
2124
2125 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2126
2f142cc5
JB
21272011-05-10 Juanma Barranquero <lekktu@gmail.com>
2128
2129 * image.c (Finit_image_library): Return t for built-in image types,
2130 like pbm and xbm. (Bug#8640)
2131
57679c86
AS
21322011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2133
2134 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2135
888c9e86
EZ
21362011-05-07 Eli Zaretskii <eliz@gnu.org>
2137
b0512a1d
EZ
2138 * w32console.c (Fset_screen_color): Doc fix.
2139 (Fget_screen_color): New function.
2140 (syms_of_ntterm): Defsubr it.
2141
7285dc67
EZ
2142 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2143 unlink the temporary file if Fcall_process didn't create it in the
2144 first place.
2145 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2146 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2147 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2148 cue to call_process_cleanup not to close that handle.
2149
4d3fcc8e
BK
21502011-05-07 Ben Key <bkey76@gmail.com>
2151
2152 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2153 one of two shell specific rules, either bootstrap-temacs-CMD or
2154 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2155 to the previous implementation of the bootstrap-temacs rule.
2156 The bootstrap-temacs-CMD rule is similar to the previous
2157 implementation of the bootstrap-temacs rule except that it
2158 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2159 variable.
2160
2161 These changes, along with some changes to nt/configure.bat,
2162 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2163 earlier fix to add support for --cflags and --ldflags options
2164 that include quotes so that it works whether make uses cmd or
2165 sh as the shell.
2166
b4289b64
MA
21672011-05-06 Michael Albinus <michael.albinus@gmx.de>
2168
2169 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2170 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2171 is a constant.
2172 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2173 a string. Handle both cases.
2174 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2175 (Fdbus_register_method): Use Qinvalid_function.
2176
af4c0e28
JB
21772011-05-06 Juanma Barranquero <lekktu@gmail.com>
2178
2179 * makefile.w32-in: Update dependencies.
2180 (LISP_H): Add inttypes.h and stdin.h.
2181 (PROCESS_H): Add unistd.h.
2182
c51453d9
EZ
21832011-05-06 Eli Zaretskii <eliz@gnu.org>
2184
2185 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2186 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2187
8ff0ac3c 21882011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2189
4c4b566b
PE
2190 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2191
aab2b9b5
PE
2192 * term.c (vfatal): Remove stray call to va_end.
2193 It's not needed and the C Standard doesn't allow it here anyway.
2194
c378da0b
PE
2195 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2196 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2197
288b08c7
PE
2198 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2199 bytes.
2200
e3601888
PE
2201 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2202
db6c0e74
PE
2203 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2204
dd5963ea
PE
2205 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2206
88c9450f
PE
2207 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2208
2f9442b8
PE
2209 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2210
c032b5f8
PE
2211 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2212 * charset.c (Fdefine_charset_internal): Don't initialize
2213 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2214 32-bit int (Bug#8600).
a108c10b
PE
2215
2216 * lread.c (read_integer): Be more consistent with string-to-number.
2217 Use string_to_number to do the actual conversion; this avoids
2218 rounding errors and fixes some other screwups. Without this fix,
2219 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2220 (digit_to_number): Move earlier, for benefit of read_integer.
2221 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2222 not a digit in any supported base. (Bug#8602)
a108c10b 2223
ad5f9eea
PE
2224 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2225
aec1708a
PE
2226 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2227 to match comment at start of function. This also removes a
2228 GCC warning about overflow in a 32+64-bit port.
2229
47be4ab5
PE
2230 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2231
371cac43
PE
2232 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2233 Reported by Stefan Monnier in
2234 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2235 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2236 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2237
d01a7826
PE
2238 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2239 (EMACS_UINTPTR): Likewise, with uintptr_t.
2240
7fd47d5c
PE
2241 * lisp.h: Prefer 64-bit EMACS_INT if available.
2242 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2243 on 32-bit hosts that have 64-bit int, so that they can access
2244 large files.
122b0c86
PE
2245 However, temporarily disable this change unless the temporary
2246 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2247
8727937b
PE
2248 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2249
8ac068ac
PE
2250 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2251 This removes an assumption that EMACS_INT and long are the same
2252 width as pointers. The assumption is true for Emacs porting targets
2253 now, but we want to make other targets possible.
2254 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2255 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2256 In the rest of the code, change types of integers that hold casted
2257 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2258 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2259 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2260 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2261 No need to cast type when ORing.
2262 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2263 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2264 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2265 assume EMACS_INT is the same width as char *.
2266 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2267 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2268 Remove no-longer-needed casts.
2269 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2270 (xg_tool_bar_help_callback, xg_make_tool_item):
2271 Use EMACS_INTPTR to hold an integer
2272 that will be cast to void *; this can avoid a GCC warning
2273 if EMACS_INT is not the same width as void *.
2274 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2275 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2276 (current_message_1, set_message_1):
2277 Use a local to convert to proper width without a cast.
2278 * xmenu.c (dialog_selection_callback): Likewise.
2279
ede49d71
PE
2280 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2281 Also, don't assume VALBITS / RAND_BITS is less than 5,
2282 and don't rely on undefined behavior when shifting a 1 left into
2283 the sign bit.
2284 * lisp.h (get_random): Change signature to match.
2285
2f30ecd0
PE
2286 * lread.c (hash_string): Use size_t, not int, for hash computation.
2287 Normally we prefer signed values; but hashing is special, because
2288 it's better to use unsigned division on hash table sizes so that
2289 the remainder is nonnegative. Also, size_t is the natural width
2290 for hashing into memory. The previous code used 'int', which doesn't
2291 retain enough info to hash well into very large tables.
2292 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2293
2a866e7b
PE
2294 * dbusbind.c: Don't possibly lose pointer info when converting.
2295 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2296 Use XPNTR rather than XHASH, so that the high-order bits of
2297 the pointer aren't lost when converting through void *.
2298
51639eac
PE
2299 * eval.c (Fautoload): Don't double-shift a pointer.
2300
92394119
PE
2301 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2302
dbdb9a7c
JB
23032011-05-06 Juanma Barranquero <lekktu@gmail.com>
2304
2305 * gnutls.c (DEF_GNUTLS_FN):
2306 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2307
db7a0b4f
AS
23082011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2309
2310 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2311 marker. (Bug#8610)
2312
f7ff1b0f 23132011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2314
2315 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2316 New version that can reserve upto 2GB of heap space.
2317
f7ff1b0f 23182011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2319
2320 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2321
639c109b
TZ
23222011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2323
2324 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2325 `gnutls_certificate_set_x509_key_file'.
2326
d2127135
JB
23272011-05-05 Juanma Barranquero <lekktu@gmail.com>
2328
2329 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2330 Update dependencies.
2331
e968f4f3
JB
23322011-05-04 Juanma Barranquero <lekktu@gmail.com>
2333
2334 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2335 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2336 Remove unused parameter `fildes'.
2337 * process.c (read_process_output, send_process): Don't pass it.
2338
84d358f0
JB
23392011-05-04 Juanma Barranquero <lekktu@gmail.com>
2340
2341 Fix previous change: the library cache is defined in w32.c.
2342 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2343 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2344
0898ca10
JB
23452011-05-04 Juanma Barranquero <lekktu@gmail.com>
2346
2347 Implement dynamic loading of GnuTLS on Windows.
2348
2349 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2350 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2351 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2352 Declare.
2353
2354 * gnutls.c (Qgnutls_dll): Define.
2355 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2356 (gnutls_*): Declare function pointers.
2357 (init_gnutls_functions): New function to initialize function pointers.
2358 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2359 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2360 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2361 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2362 (emacs_gnutls_write, emacs_gnutls_read)
2363 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2364 (Fgnutls_available_p): New function.
2365 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2366 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2367 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2368
2369 * image.c: Include w32.h.
2370 (Vimage_type_cache): Delete.
2371 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2372 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2373 (w32_delayed_load): Move to w32.c.
2374
2375 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2376
2377 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2378 (w32_delayed_load): Move from image.c. When loading a library, record
2379 its filename in the :loaded-from property of the library id.
2380 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2381 Initialize and staticpro them.
2382 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2383
2384 * process.c: Include lisp.h before w32.h, not after.
2385 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2386 instead of gnutls_record_check_pending.
2387
2388 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2389
ff4de4aa
TZ
23902011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2391
2392 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2393 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2394 as passed in.
2395
abe95abb
JD
23962011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2397
2398 * xterm.c (x_set_frame_alpha): Do not set property on anything
2399 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2400
e16e55d4
JB
24012011-05-02 Juanma Barranquero <lekktu@gmail.com>
2402
2403 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2404
bafcf6a5
JB
24052011-05-02 Juanma Barranquero <lekktu@gmail.com>
2406
2407 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2408 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2409 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2410 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2411 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2412 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2413 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2414 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2415 (Qgnutls_bootprop_callbacks_verify): Make static.
2416
e7a6747f
AS
24172011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2418
19ed11ba
AS
2419 * callproc.c: Indentation fixup.
2420
e7a6747f 2421 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2422 (wait_for_termination, interruptible_wait_for_termination):
2423 Move after wait_for_termination_1.
e7a6747f 2424
1ef14cb4
LMI
24252011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2426
2427 * sysdep.c (interruptible_wait_for_termination): New function
2428 which is like wait_for_termination, but allows keyboard
2429 interruptions.
2430
2431 * callproc.c (Fcall_process): Add (:file "file") as an option for
2432 the STDOUT buffer.
2433 (Fcall_process_region): Ditto.
2434
330d880c
EZ
24352011-04-30 Eli Zaretskii <eliz@gnu.org>
2436
8db90b73
EZ
2437 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2438 rather than `XVECTOR (FOO)->size'.
2439
330d880c
EZ
2440 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2441 inttypes.h, as a gnulib replacement is used if it not available in
2442 system headers.
2443
15cbd324
EZ
24442011-04-21 Eli Zaretskii <eliz@gnu.org>
2445
2446 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2447 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2448 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2449
2450 * coding.c (coding_alloc_by_realloc): Error out if destination
2451 will grow beyond MOST_POSITIVE_FIXNUM.
2452 (decode_coding_emacs_mule): Abort if there isn't enough place in
2453 charbuf for the composition carryover bytes. Reserve an extra
2454 space for up to 2 characters produced in a loop.
2455 (decode_coding_iso_2022): Abort if there isn't enough place in
2456 charbuf for the composition carryover bytes.
2457
24582011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2459
ae940cca
EZ
2460 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2461 aborting when %lld or %lll format is passed.
2462 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2463 %llo or %llx format is passed. (Bug#8545)
2464
03ab8921
EZ
2465 * window.c (window_scroll_line_based): Use a marker instead of
2466 simple variables to record original value of point. (Bug#7952)
2467
afda1437
EZ
2468 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2469 produced by %s or %c overflows available buffer space. (Bug#8545)
2470
f76dee0c
PE
24712011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2472
2473 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2474 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2475
fdc5744d
JB
24762011-04-28 Juanma Barranquero <lekktu@gmail.com>
2477
2478 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2479
638f053a
JB
24802011-04-28 Juanma Barranquero <lekktu@gmail.com>
2481
2482 * keyboard.c (Qdelayed_warnings_hook): Define.
2483 (command_loop_1): Run `delayed-warnings-hook'
2484 if Vdelayed_warnings_list is non-nil.
2485 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2486 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2487
d178f871
EZ
24882011-04-28 Eli Zaretskii <eliz@gnu.org>
2489
2490 * doprnt.c (doprnt): Don't return value smaller than the buffer
2491 size if the message was truncated. (Bug#8545).
2492
b124fd93
JB
24932011-04-28 Juanma Barranquero <lekktu@gmail.com>
2494
2495 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2496 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2497
e810457d
PE
24982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2501
ea51cceb
JB
25022011-04-27 Juanma Barranquero <lekktu@gmail.com>
2503
2504 * makefile.w32-in: Update dependencies.
2505
94dcfacf
EZ
25062011-04-27 Eli Zaretskii <eliz@gnu.org>
2507
2508 Improve `doprnt' and its usage. (Bug#8545)
2509 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2510 `format_end'. Remove support for %l as a conversion specifier.
2511 Don't use xrealloc. Improve diagnostics when the %l size modifier
2512 is used. Update the commentary.
2513
2514 * eval.c (verror): Simplify calculation of size_t.
2515
2516 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2517 messages.
2518
f61f41d7
PE
25192011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2520
2521 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2522 change.
2523
96fb4434
PE
25242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2527 This makes this file independent of the recent pseudovector change.
2528
671875da 25292011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2530
69e9b5a3
PE
2531 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2532
b5f869a7 2533 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2534 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2535 Remove unused local.
c8926152 2536 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2537
841a1577 2538 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2539 GCC 4.6.0 optimizes based on type-based alias analysis.
2540 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2541 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2542 != &v->size, and therefore "v->size = 1; b->size = 2; return
2543 v->size;" must therefore return 1. This assumption is incorrect
2544 for Emacs, since it type-puns struct Lisp_Vector * with many other
2545 types. To fix this problem, this patch adds a new type struct
f904488f 2546 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2547 and pseudovectors, and helps optimizing compilers not get fooled
2548 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2549 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2550 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2551 the size member.
eab3844f
PE
2552 (XSETPVECTYPE): Rewrite in terms of new macro.
2553 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2554 This is a bit clearer, and further avoids the possibility of
2555 undesirable aliasing.
2556 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2557 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2558 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2559 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2560 (ASIZE): Now uses header.size rather than size.
2561 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2562 to avoid the hassle of writing XVECTOR (foo)->header.size.
2563 (struct vectorlike_header): New type.
eab3844f
PE
2564 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2565 object, to help avoid aliasing.
2566 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2567 (SUBRP): Likewise, since Lisp_Subr is a special case.
2568 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2569 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2570 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2571 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2572 changed to be "header.size" and "header.next".
2573 * buffer.h (struct buffer): Likewise.
2574 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2575 * frame.h (struct frame): Likewise.
2576 * process.h (struct Lisp_Process): Likewise.
2577 * termhooks.h (struct terminal): Likewise.
2578 * window.c (struct save_window_data, struct saved_window): Likewise.
2579 * window.h (struct window): Likewise.
2580 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2581 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2582 * buffer.c (init_buffer_once): Likewise.
2583 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2584 special case.
2585 * process.c (Fformat_network_address): Use local var for size,
2586 for brevity.
2587
0df1eac5
PE
2588 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2589
847ab9d1 2590 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2591 * data.c (atof): Remove decl; no longer used or needed.
2592 (digit_to_number): Move to lread.c.
2593 (Fstring_to_number): Use new string_to_number function, to be
2594 consistent with how the Lisp reader treats infinities and NaNs.
2595 Do not assume that floating-point numbers represent EMACS_INT
2596 without losing information; this is not true on most 64-bit hosts.
2597 Avoid double-rounding errors, by insisting on integers when
2598 parsing non-base-10 numbers, as the documentation specifies.
2599 * lisp.h (string_to_number): New decl, replacing ...
2600 (isfloat_string): Remove.
bc0a5c13 2601 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2602 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2603 appears to have been a coding error. Similarly, do not accept
2604 strings like +-1e0 as floating point numbers. Do not report
2605 overflow for integer overflows unless the base is not 10 which
2606 means we have no simple and reliable way to continue.
2607 Break out the floating-point parsing into a new
2608 function string_to_number, so that Fstring_to_number parses
2609 floating point numbers consistently with the Lisp reader.
04f2d78b 2610 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2611 (E_CHAR, EXP_INT): Remove, replacing with ...
2612 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2613 (string_to_number): New function, replacing isfloat_string.
2614 This function checks for valid syntax and produces the resulting
2615 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2616 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2617 so that overflow for non-base-10 numbers is reported only when
2618 there's no portable and simple way to convert to floating point.
452f4150 2619
67769ffc
PE
2620 * textprop.c (set_text_properties_1): Rewrite for clarity,
2621 and to avoid GCC warning about integer overflow.
2622
c20db43f
PE
2623 * intervals.h (struct interval): Use EMACS_INT for members
2624 where EMACS_UINT might cause problems. See
2625 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2626 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2627 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2628 All uses changed.
37aa2f85
PE
2629 (offset_intervals): Tell GCC not to worry about length overflow
2630 when negating a negative length.
c20db43f 2631
2538aa2f
PE
2632 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2633 (overrun_check_free): Likewise.
2634
f2d3008d
PE
2635 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2636 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2637 word size.
2638
ec8df744
PE
2639 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2640 (gnutls_make_error): Rename local to avoid shadowing.
2641 (gnutls_emacs_global_deinit): ifdef out; not used.
2642 (Fgnutls_boot): Use const for pointer to readonly storage.
2643 Comment out unused local. Fix pointer signedness problems.
2644
640ee02d
PE
2645 * lread.c (openp): Don't stuff size_t into an 'int'.
2646 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2647 about possible signed overflow.
2648
6048fb2a
PE
2649 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2650 (GDK_KEY_g): Don't define if already defined.
2651 (xg_prepare_tooltip): Avoid pointer signedness problem.
2652 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2653
fa3c87e1
PE
2654 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2655 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2656
2172544b
PE
2657 * xfns.c (Fx_window_property): Simplify a bit,
2658 to make a bit faster and to avoid GCC 4.6.0 warning.
2659 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2660
9b821a21
PE
2661 * fns.c (internal_equal): Don't assume size_t fits in int.
2662
3c616cfa
PE
2663 * alloc.c (compact_small_strings): Tighten assertion a little.
2664
c2982e87
PE
2665 Replace pEd with more-general pI, and fix some printf arg casts.
2666 * lisp.h (pI): New macro, generalizing old pEd macro to other
2667 conversion specifiers. For example, use "...%"pI"d..." rather
2668 than "...%"pEd"...".
2669 (pEd): Remove. All uses replaced with similar uses of pI.
2670 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2671 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2672 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2673 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2674 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2675 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2676 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2677 64-bit hosts.
2678 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2679 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2680 * print.c (safe_debug_print, print_object): Likewise.
2681 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2682 to int.
6f04d126
PE
2683 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2684 avoiding the 0 flag, which is not portable.
c2982e87
PE
2685 * process.c (Fmake_network_process): Use pI to avoid cast.
2686 * region-cache.c (pp_cache): Likewise.
2687 * xdisp.c (decode_mode_spec): Likewise.
2688 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2689 behavior on 64-bit hosts with printf arg.
6f04d126 2690 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2691 (x_stop_queuing_selection_requests): Likewise.
2692 (x_get_window_property): Don't truncate byte count to an 'int'
2693 when tracing.
0b432f21 2694
5e073ec7
PE
2695 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2696 here, since it parses constructs like leading '-' and spaces,
2697 which are not wanted; and it overflows with large numbers.
2698 Instead, simply match F[0-9]+, which is what is wanted anyway.
2699
36372bf9
PE
2700 * alloc.c: Remove unportable assumptions about struct layout.
2701 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2702 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2703 (allocate_vectorlike, make_pure_vector): Use the new macros,
2704 plus offsetof, to remove unportable assumptions about struct layout.
2705 These assumptions hold on all porting targets that I know of, but
2706 they are not guaranteed, they're easy to remove, and removing them
2707 makes further changes easier.
2708
0b432f21
PE
2709 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2710 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2711 (string_overrun_cookie): Now const. Use initializers that
2712 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2713 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2714 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2715 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2716 multiple of sizeof (EMACS_INT); it need not be, if
2717 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2718 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2719
895009e1
JB
27202011-04-26 Juanma Barranquero <lekktu@gmail.com>
2721
2722 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2723
6a7a1b0b
TZ
27242011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2725
2726 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2727 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2728 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2729
841a1577 27302011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2731
2732 * lisp.h (Qdebug): List symbol.
895009e1 2733 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2734 * keyboard.c (debug-on-event): New variable.
2735 (handle_user_signal): Break into debugger when debug-on-event
2736 matches the current signal symbol.
2737
f2d3ba6f
DN
27382011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2739
2740 * alloc.c (check_sblock, check_string_bytes)
2741 (check_string_free_list): Convert to standard C.
2742
42ce4c63
TZ
27432011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2744
2745 * w32.c (emacs_gnutls_push): Fix typo.
2746
825cd63c
EZ
27472011-04-25 Eli Zaretskii <eliz@gnu.org>
2748
fb11d64d
EZ
2749 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2750 "cast to pointer from integer of different size".
2751
825cd63c
EZ
2752 Improve doprnt and its use in verror. (Bug#8545)
2753 * doprnt.c (doprnt): Document the set of format control sequences
2754 supported by the function. Use SAFE_ALLOCA instead of always
2755 using `alloca'.
2756
2757 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2758 is one byte too soon. Don't use xrealloc; instead xfree and
2759 xmalloc anew.
2760
e061a11b
TZ
27612011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2762
2763 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2764 callbacks stage.
2765
2766 * gnutls.c: Renamed global_initialized to
2767 gnutls_global_initialized. Added internals for the
2768 :verify-hostname-error, :verify-error, and :verify-flags
2769 parameters of `gnutls-boot' and documented those parameters in the
2770 docstring. Start callback support.
2771 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2772 unless a fatal error occured. Call gnutls_alert_send_appropriate
2773 on error. Return error code.
2774 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2775 (emacs_gnutls_read): Likewise.
2776 (Fgnutls_boot): Return handshake error code.
2777 (emacs_gnutls_handle_error): New function.
2778 (wsaerror_to_errno): Likewise.
2779
2780 * w32.h (emacs_gnutls_pull): Add prototype.
2781 (emacs_gnutls_push): Likewise.
2782
2783 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2784 (emacs_gnutls_push): Likewise.
2785
27862011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2787
2788 * process.c (wait_reading_process_output): Check if GnuTLS
2789 buffered some data internally if no FDs are set for TLS
2790 connections.
2791
2792 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2793 (LIBS): Link to USER_LIBS.
2794 ($(BLD)/gnutls.$(0)): New target.
2795
fa6996bc
EZ
27962011-04-24 Eli Zaretskii <eliz@gnu.org>
2797
eb35682e
EZ
2798 * xdisp.c (handle_single_display_spec): Rename the
2799 display_replaced_before_p argument into display_replaced_p, to
2800 make it consistent with the commentary. Fix typos in the
2801 commentary.
2802
e2ad650c
EZ
2803 * textprop.c (syms_of_textprop): Remove dead code.
2804 (copy_text_properties): Delete obsolete commentary about an
2805 interface that was deleted long ago. Fix typos in the description
2806 of arguments.
2807
1b2de274
EZ
2808 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2809 to changes in oldXMenu/XMenu.h from 2011-04-16.
2810 <menu_help_message, prev_menu_help_message>: Constify.
2811 (IT_menu_make_room): menu->help_text is now `const char **';
2812 adjust.
2813
2814 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2815 to changes in oldXMenu/XMenu.h from 2011-04-16.
2816 (struct XMenu): Declare `help_text' `const char **'.
2817
2818 * xfaces.c <Qunspecified>: Make extern again.
2819
2820 * syntax.c: Include sys/types.h before including regex.h, as
2821 required by Posix.
2822
762b15be
EZ
2823 * doc.c (get_doc_string): Improve the format passed to `error'.
2824
2825 * doprnt.c (doprnt): Improve commentary.
2826
2827 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2828
2829 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2830 them with etags.
2831
f1052e5d
EZ
2832 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2833 changes in globals.h immediately force recompilation.
762b15be
EZ
2834 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2835 $(CURDIR)/s/ms-w32.h.
2836 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2837
fa6996bc
EZ
2838 * character.c (Fchar_direction): Function deleted.
2839 (syms_of_character): Don't defsubr it.
2840 <char-direction-table>: Deleted.
2841
e6c3da20
EZ
28422011-04-23 Eli Zaretskii <eliz@gnu.org>
2843
2844 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2845 * doprnt.c: Include limits.h.
2846 (SIZE_MAX): New macro.
04f2d78b
CB
2847 (doprnt): Return a size_t value. 2nd arg is now size_t.
2848 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2849 Improve overflow protection. Support `l' modifier for integer
2850 conversions. Support %l conversion. Don't assume an EMACS_INT
2851 argument for integer conversions and for %c.
2852
2853 * lisp.h (doprnt): Restore prototype.
2854
2855 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2856 $(SRC)/character.h.
2857
2858 * Makefile.in (base_obj): Add back doprnt.o.
2859
2860 * deps.mk (doprnt.o): Add back prerequisites.
2861 (callint.o): Depend on character.h.
2862
2863 * eval.c (internal_lisp_condition_case): Include the handler
2864 representation in the error message.
2865 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2866 when breaking from the loop.
2867
2868 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2869
2870 * callint.c (Fcall_interactively): When displaying error message
2871 about invalid control letter, pass the character's codepoint, not
2872 a pointer to its multibyte form. Improve display of the character
2873 in octal and display also its hex code.
2874
2875 * character.c (char_string): Use %x to display the (unsigned)
2876 codepoint of an invalid character, to avoid displaying a bogus
2877 negative value.
2878
2879 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2880 `error', not SYMBOL_NAME itself.
2881
2882 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2883 character arguments to `error'.
2884
2885 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2886 to `error' in error message about FINAL_CHAR argument. Make sure
2887 FINAL_CHAR is a character, and use %c when it is passed as
2888 argument to `error'.
2889
4ffd0d6b 28902011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2891
2892 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2893
2894 * w32.c: Include <time.h>.
2895 (sys_localtime): New function.
2896
4ffd0d6b 28972011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2898
2899 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2900
4ffd0d6b 2901 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2902
4ffd0d6b 29032011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2904
4ffd0d6b
GM
2905 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2906 zombies (Bug#8467).
aac0c6e3 2907
04c56954
EZ
29082011-04-19 Eli Zaretskii <eliz@gnu.org>
2909
2910 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2911 gl_state.e_property when gl_state.object is Qt.
2912
2913 * insdel.c (make_gap_larger): Remove limitation of buffer size
2914 to <= INT_MAX.
2915
16a43933
CY
29162011-04-18 Chong Yidong <cyd@stupidchicken.com>
2917
2918 * xdisp.c (lookup_glyphless_char_display)
2919 (produce_glyphless_glyph): Handle cons cell entry in
2920 glyphless-char-display.
2921 (Vglyphless_char_display): Document it.
2922
2923 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2924 glyphless-char-display.
2925
4581706e
CY
29262011-04-17 Chong Yidong <cyd@stupidchicken.com>
2927
2928 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2929
2930 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2931
2932 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2933 definition for no-X builds.
2934
4887c6e2 29352011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2936
fd35b6f9
PE
2937 Static checks with GCC 4.6.0 and non-default toolkits.
2938
5c1ccb01
PE
2939 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2940
006c5daa
PE
2941 * process.c (keyboard_bit_set): Define only if SIGIO.
2942 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2943 (send_process): Repair possible setjmp clobbering.
2944
efc736d3
PE
2945 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2946
4e2fe2e6
PE
2947 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2948
f97334a2
PE
2949 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2950
4e75f29d
PE
2951 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2952 Define only if needed.
2953
90efadd1
PE
2954 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2955 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2956 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2957
3c647824
PE
2958 * dispextern.h (struct redisplay_interface): Rename param
2959 to avoid shadowing.
e264f262 2960 * termhooks.h (struct terminal): Likewise.
761383f4 2961 * xterm.c (xembed_send_message): Likewise.
3c647824 2962
b58c5c4a
PE
2963 * insdel.c (make_gap_smaller): Define only if
2964 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2965
cad59032
PE
2966 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2967 it.
2968
c339dc2e
PE
2969 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2970 so that we aren't warned about unused symbols.
2971
91a3e27b
PE
2972 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2973
399c71d3 2974 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2975
8ffc96f5
PE
2976 * xfns.c (x_real_positions): Mark locals as initialized.
2977
eef9bc79
PE
2978 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2979
098db9dd
PE
2980 * xterm.c: Fix problems found by static analysis with other toolkits.
2981 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2982 (x_dispatch_event): Declare static if USE_GTK, and
2983 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2984 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2985 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2986 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2987 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2988
eb18f6cc
PE
2989 * xmenu.c (menu_help_callback): Pointer type fixes.
2990 Use const pointers when pointing at readonly data. Avoid pointer
2991 signedness clashes.
2992 (FALSE): Remove unused macro.
2993 (update_frame_menubar): Remove unused decl.
2994
1fe72bf8
PE
2995 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2996
60d9e1db
PE
2997 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2998 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2999 (single_menu_item): Rename local to avoid shadowing.
3000
39261c26
PE
3001 * keyboard.c (make_lispy_event): Remove unused local var.
3002
018c5e19
PE
3003 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3004 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3005
63d2b86e
PE
3006 * bitmaps: Change bitmaps from unsigned char back to the X11
3007 compatible char. Avoid the old compiler warnings about
3008 out-of-range initializers by using, for example, '\xab' rather
3009 than 0xab.
3010
aefd87e1
PE
3011 * xgselect.c (xgselect_initialize): Check vs interface
3012 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3013
bf501fb9
PE
3014 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3015
e9829fdf
PE
3016 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3017 to read-only memory.
3018
1086c095
PE
3019 * fns.c (vector): Remove; this old hack is no longer needed.
3020
2baccd04 3021 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3022 Remove unused var.
dde42981 3023 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3024
72391843 3025 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3026
436c16df 3027 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3028 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3029 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3030
92bb796d 3031 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3032 (x_term_init): Remove local to avoid shadowing.
92bb796d 3033
764430a3 3034 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3035
3036 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3037 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3038
d1dfb56c
EZ
30392011-04-16 Eli Zaretskii <eliz@gnu.org>
3040
c4354cb4
EZ
3041 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3042
d1dfb56c
EZ
3043 Fix regex.c, syntax.c and friends for buffers > 2GB.
3044 * syntax.h (struct gl_state_s): Declare character position members
3045 EMACS_INT.
3046
3047 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3048
04f2d78b
CB
3049 * textprop.c (verify_interval_modification, interval_of):
3050 Declare arguments EMACS_INT.
d1dfb56c
EZ
3051
3052 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3053 EMACS_INT.
3054
3055 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3056
3057 * indent.c (Fvertical_motion): Local variable it_start is now
3058 EMACS_INT.
3059
3060 * regex.c (re_match, re_match_2, re_match_2_internal)
3061 (bcmp_translate, regcomp, regexec, print_double_string)
3062 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3063 (re_compile_pattern, re_exec): Declare arguments and local
3064 variables `size_t' and `ssize_t' and return values `regoff_t', as
3065 appropriate.
3066 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3067 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3068 <compile_stack_type>: `size' and `avail' are now `size_t'.
3069
3070 * regex.h <regoff_t>: Use ssize_t, not int.
3071 (re_search, re_search_2, re_match, re_match_2): Arguments that
3072 specify buffer/string position and length are now ssize_t and
3073 size_t. Return type is regoff_t.
3074
613052cd
BK
30752011-04-16 Ben Key <bkey76@gmail.com>
3076
3077 * nsfont.m: Fixed bugs in ns_get_family and
3078 ns_descriptor_to_entity that were caused by using free to
3079 deallocate memory blocks that were allocated by xmalloc (via
3080 xstrdup). This caused Emacs to crash when compiled with
3081 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3082 --enable-checking=xmallocoverrun). xfree is now used to
3083 deallocate these memory blocks.
3084
4170f62f 30852011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3086
71b41406
PE
3087 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3088
9587a89d
PE
3089 emacs_write: Accept and return EMACS_INT for sizes.
3090 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3091 et seq.
3092 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3093 Accept and return EMACS_INT.
3094 (emacs_gnutls_write): Return the number of bytes written on
3095 partial writes.
3096 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3097 (emacs_read, emacs_write): Remove check for negative size, as the
3098 Emacs source code has been audited now.
9587a89d
PE
3099 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3100 (emacs_read, emacs_write): Use it.
273a5f82
PE
3101 * process.c (send_process): Adjust to the new signatures of
3102 emacs_write and emacs_gnutls_write. Do not attempt to store
3103 a byte offset into an 'int'; it might overflow.
9587a89d 3104 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3105
3e047f51
PE
3106 * sound.c: Don't assume sizes fit in 'int'.
3107 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3108 Return EMACS_INT, not int.
3e047f51 3109 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3110 Accept EMACS_INT, not int.
3111 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3112 record read return values.
3113
cc39a9db
BK
31142011-04-15 Ben Key <bkey76@gmail.com>
3115
c9d0ec6d
JB
3116 * keyboard.c (Qundefined): Don't declare static since it is used
3117 in nsfns.m.
3118 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3119 static since they are used in nsfont.m.
cc39a9db 3120
6c60eb9f
SM
31212011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3122
3123 * process.c (Qprocessp): Don't declare static.
3124 * lisp.h (Qprocessp): Declare again.
3125
7990b61a
JB
31262011-04-15 Juanma Barranquero <lekktu@gmail.com>
3127
3128 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3129
5d4cb038
PE
31302011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3131
8bd7b830 3132 Improve C-level modularity by making more things 'static'.
cd64ea1d 3133
e3b27b31
PE
3134 Don't publish debugger-only interfaces to other modules.
3135 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3136 (verify_bytepos, count_markers): Move decls to the only modules
3137 that need them.
3138 * region-cache.h (pp_cache): Likewise.
3139 * window.h (check_all_windows): Likewise.
3140 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3141
5d4cb038
PE
3142 * sysdep.c (croak): Now static, if
3143 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3144 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3145
3146 * alloc.c (refill_memory_reserve): Now static if
3147 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3148 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3149
e87b6180
PE
3150 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3151 Define only if USE_LUCID.
3152
ac64929e
PE
3153 * xrdb.c (x_customization_string, x_rm_string): Now static.
3154
6f37259d
PE
3155 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3156 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3157
1683e3ab
PE
3158 * xdisp.c (draw_row_with_mouse_face): Now static.
3159 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3160
de9c2632
PE
3161 * window.h (check_all_windows): Mark externally visible.
3162
2b96acb7
PE
3163 * window.c (window_deletion_count): Now static.
3164
3165 * undo.c: Make symbols static if they're not exported.
3166 (last_undo_buffer, last_boundary_position, pending_boundary):
3167 Now static.
3168
50436f33
PE
3169 * textprop.c (interval_insert_behind_hooks): Now static.
3170 (interval_insert_in_front_hooks): Likewise.
3171
64520e5c
PE
3172 * term.c: Make symbols static if they're not exported.
3173 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3174 (max_frame_lines, tty_set_terminal_modes):
3175 (tty_reset_terminal_modes, tty_turn_off_highlight):
3176 (get_tty_terminal): Now static.
3177 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3178 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3179 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3180 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3181 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3182
1fa53021
PE
3183 * sysdep.c: Make symbols static if they're not exported.
3184 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3185 Now static.
3186 (sigprocmask_set, full_mask): Remove; unused.
3187 (wait_debugging): Mark as visible.
3188 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3189 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3190
d4b43b22
PE
3191 * syntax.c (syntax_temp): Define only if !__GNUC__.
3192
b7c513d0
PE
3193 * sound.c (current_sound_device, current_sound): Now static.
3194
989b29ad
PE
3195 * search.c (searchbufs, searchbuf_head): Now static.
3196
13a55a78
PE
3197 * scroll.c (scroll_cost): Remove; unused.
3198 * dispextern.h (scroll_cost): Remove decl.
3199
de68a1fc
PE
3200 * region-cache.h (pp_cache): Mark as externally visible.
3201
40ccffa6
PE
3202 * process.c: Make symbols static if they're not exported.
3203 (process_tick, update_tick, create_process, chan_process):
3204 (Vprocess_alist, proc_buffered_char, datagram_access):
3205 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3206 (deactivate_process): Mark defn as static, as well as decl.
3207 * lisp.h (create_process): Remove decl.
3208 * process.h (chan_process, Vprocess_alist): Remove decls.
3209
ad64fc97
PE
3210 * print.c: Make symbols static if they're not exported.
3211 (print_depth, new_backquote_output, being_printed, print_buffer):
3212 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3213 (print_interval, print_number_index, initial_stderr_stream):
3214 Now static.
3215 * lisp.h (Fprinc): Remove decl.
3216 (debug_output_compilation_hack): Mark as externally visible.
3217
adddb265
PE
3218 * sysdep.c (croak): Move decl from here to syssignal.h.
3219 * syssignal.h (croak): Put it here, so the API can be checked when
3220 'croak' is called from dissociate_if_controlling_tty.
3221
1717ede2
PE
3222 * minibuf.c: Make symbols static if they're not exported.
3223 (minibuf_save_list, choose_minibuf_frame): Now static.
3224 * lisp.h (choose_minibuf_frame): Remove decl.
3225
fa5fb2bc
PE
3226 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3227
1e3890d1
PE
3228 * lread.c: Make symbols static if they're not exported.
3229 (read_objects, initial_obarray, oblookup_last_bucket_number):
3230 Now static.
3231 (make_symbol): Remove; unused.
3232 * lisp.h (initial_obarray, make_symbol): Remove decls.
3233
8a1414fa
PE
3234 * keyboard.c: Make symbols static if they're not exported.
3235 (single_kboard, recent_keys_index, total_keys, recent_keys):
3236 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3237 (this_single_command_key_start, echoing, last_auto_save):
3238 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3239 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3240 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3241 (Vlispy_mouse_stem, double_click_count):
3242 Now static.
3243 (force_auto_save_soon): Define only if SIGDANGER.
3244 (ignore_mouse_drag_p): Now static if
3245 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3246 (print_help): Remove; unused.
3247 (stop_character, last_timer_event): Mark as externally visible.
3248 * keyboard.h (ignore_mouse_drag_p): Declare only if
3249 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3250 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3251 * lisp.h (echoing): Remove decl.
3252 (force_auto_save_soon): Declare only if SIGDANGER.
3253 * xdisp.c (redisplay_window): Simplify code, to make it more
3254 obvious that ignore_mouse_drag_p is not accessed if !defined
3255 USE_GTK && !defined HAVE_NS.
3256
93ea6e8f
PE
3257 * intervals.c: Make symbols static if they're not exported.
3258 (merge_properties_sticky, merge_interval_right, delete_interval):
3259 Now static.
3260 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3261
77382fcc
PE
3262 * insdel.c: Make symbols static if they're not exported.
3263 However, leave prepare_to_modify_buffer alone. It's never
3264 called from outside this function, but that appears to be a bug.
3265 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3266 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3267 (adjust_after_replace_noundo): Remove; unused.
3268 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3269 (signal_before_change): Remove decls.
77382fcc 3270
9306c32e
PE
3271 * indent.c (val_compute_motion, val_vmotion): Now static.
3272
cd44d2eb
PE
3273 * image.c: Make symbols static if they're not exported.
3274 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3275 if USE_GTK.
3276 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3277 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3278
ad9a7a06
PE
3279 * fringe.c (standard_bitmaps): Now static.
3280 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3281
81626931
PE
3282 * frame.c: Make symbols static if they're not exported.
3283 (x_report_frame_params, make_terminal_frame): Now static.
3284 (get_frame_param): Now static, unless HAVE_NS.
3285 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3286 (x_get_resource_string): Remove; not used.
3287 * frame.h (make_terminal_frame, x_report_frame_params):
3288 (x_get_resource_string); Remove decls.
3289 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3290 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3291
239f9db9
PE
3292 * font.c, fontset.c: Make symbols static if they're not exported.
3293 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3294 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3295 * font.c (font_close_object): Now static.
3296 * font.h (font_close_object): Remove.
3297 * fontset.c (FONTSET_OBJLIST): Remove.
3298 (free_realized_fontset) #if-0 the body, which does nothing.
3299 (face_suitable_for_char_p): #if-0, as it's never called.
3300 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3301 * xfaces.c (face_at_string_position):
3302 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3303 since 0 is always ASCII.
3304
dfcf3579
PE
3305 * fns.c (weak_hash_tables): Now static.
3306
5045092b
PE
3307 * fileio.c: Make symbols static if they're not exported.
3308 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3309 (Vwrite_region_annotation_buffers): Now static.
3310
57a96f5c
PE
3311 * eval.c: Make symbols static if they're not exported.
3312 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3313 * lisp.h (backtrace_list): Remove decl.
3314
35f08c38
PE
3315 * emacs.c: Make symbols static if they're not exported.
3316 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3317 (fatal_error_code, fatal_error_signal_hook, standard_args):
3318 Now static.
3319 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3320 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3321 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3322 * lisp.h (fatal_error_signal_hook): Remove decl.
3323 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3324
f44bd759
PE
3325 * editfns.c: Move a (normally-unused) function to its only use.
3326 * editfns.c, lisp.h (get_operating_system_release): Remove.
3327 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3328 worth the hassle of breaking this out.
3329
b532497d
PE
3330 * xterm.c: Make symbols static if they're not exported.
3331 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3332 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3333 (x_destroy_window, x_delete_display):
3334 Now static.
3335 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3336 (x_mouse_leave): Remove; unused.
3337 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3338 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3339 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3340 Remove decls.
3341 (x_mouse_leave): Declare only if WINDOWSNT.
3342 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3343 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3344 USE_X_TOOLKIT.
3345
1675728f
PE
3346 * ftxfont.c: Make symbols static if they're not exported.
3347 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3348 HAVE_FREETYPE.
3349 * font.h (ftxfont_driver): Likewise.
3350
e4cebfca
PE
3351 * xfns.c: Make symbols static if they're not exported.
3352 (x_last_font_name, x_display_info_for_name):
3353 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3354 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3355 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3356 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3357 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3358 (last_show_tip_args): Now static.
3359 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3360 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3361 (x_screen_planes): Remove; unused.
3362 * dispextern.h (x_screen_planes): Remove decl.
3363
5bf46f05
PE
3364 * dispnew.c: Make symbols static if they're not exported.
3365 * dispextern.h (redraw_garbaged_frames, scrolling):
3366 (increment_row_positions): Remove.
3367 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3368 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3369 Now static.
3370 (redraw_garbaged_frames): Remove; unused.
3371
435f4c28
PE
3372 * xfaces.c: Make symbols static if they're not exported.
3373 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3374 Remove decls.
3375 * xterm.h (defined_color): Remove decls.
3376 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3377 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3378 (menu_face_changed_default, defined_color, free_realized_face):
3379 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3380 (ascii_face_of_lisp_face): Remove; unused.
3381
8524aef3
PE
3382 * xdisp.c: Make symbols static if they're not exported.
3383 * dispextern.h (scratch_glyph_row, window_box_edges):
3384 (glyph_to_pixel_coords, set_cursor_from_row):
3385 (get_next_display_element, set_iterator_to_next):
3386 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3387 (show_mouse_face): Remove decls
3388 * frame.h (message_buf_print): Likewise.
3389 * lisp.h (pop_message, set_message, check_point_in_composition):
3390 Likewise.
3391 * xterm.h (set_vertical_scroll_bar): Likewise.
3392 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3393 (message_buf_print, scratch_glyph_row, displayed_buffer):
3394 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3395 (get_next_display_element, show_mouse_face, window_box_edges):
3396 (frame_to_window_pixel_xy, check_point_in_composition):
3397 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3398 (glyph_to_pixel_coords): Remove; unused.
3399
16390cd2
PE
3400 * dired.c (file_name_completion): Now static.
3401
3402 * dbusbind.c (xd_in_read_queued_messages): Now static.
3403
a25f4dfa
PE
3404 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3405 * data.c (circular_list_error): Remove.
3406
14a9c8df
PE
3407 * commands.h (last_point_position, last_point_position_buffer):
3408 (last_point_position_window): Remove decls.
3409 * keyboard.c: Make these variables static.
3410
04f2d78b
CB
3411 * coding.h (coding, code_convert_region, encode_coding_gap):
3412 Remove decls.
74ab6df5
PE
3413 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3414 (iso_code_class, detect_coding, code_convert_region): Now static.
3415 (encode_coding_gap): Remove; unused.
3416
38dfbee1
PE
3417 * chartab.c (chartab_chars, chartab_bits): Now static.
3418
a2cb4e63
PE
3419 * charset.h (charset_iso_8859_1): Remove decl.
3420 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3421 Now static.
3422
127198fd
PE
3423 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3424 * ccl.c (Vccl_program_table): Now static.
3425 (check_ccl_update): Remove; unused.
3426
d85b608f
PE
3427 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3428 * category.h: ... from here.
3429 * category.c (check_category_table, set_category_set): Now static.
3430
31cd66f3
PE
3431 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3432 * lisp.h: Remove these decls.
3433
c358e587
PE
3434 * buffer.c (buffer_count): Remove unused var.
3435
e78aecca
PE
3436 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3437 so that it's not optimized away.
3438 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3439 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3440 exported only to the debugger.
3441
e192d7d3 3442 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3443 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3444
92470028
PE
3445 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3446 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3447 was inaccessible from Lisp.
3448 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3449 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3450
244ed907
PE
3451 alloc.c: Import and export fewer symbols, and remove unused items.
3452 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3453 is defined.
3454 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3455 it's not optimized away by whole-program optimization.
3456 (message_enable_multibyte, free_misc): Remove.
3457 (catchlist, handlerlist, mark_backtrace):
3458 Declare only if BYTE_MARK_STACK.
3459 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3460 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3461 (message_enable_multibyte): Remove decl.
3462 (free_misc, interval_free_list, float_block, float_block_index):
3463 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3464 (cons_free_list, last_marked_index):
3465 Now static.
3466 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3467 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3468 (mark_backtrace): Define only if BYTE_MARK_STACK.
3469 * xdisp.c (message_enable_multibyte): Now static.
3470
61c2b50e 3471 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3472 This makes it easier for human readers (and static analyzers)
3473 to see whether these variables are used from other modules.
3474 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3475 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3476 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3477 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3478 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3479 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3480 * xmenu.c, xselect.c:
3481 Declare Q* vars static if they are not used in other modules.
3482 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3483 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3484 Remove decls of unexported vars.
3485 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3486
95c82688
PE
3487 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3488
16a97296
PE
3489 Make Emacs functions such as Fatom 'static' by default.
3490 This makes it easier for human readers (and static analyzers)
3491 to see whether these functions can be called from other modules.
3492 DEFUN now defines a static function. To make the function external
3493 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3494 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3495 (Finit_image_library):
16a97296
PE
3496 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3497 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3498 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3499 Remove decls, since these functions are now static.
3500 (Funintern, Fget_internal_run_time): New decls, since these functions
3501 were already external.
95c82688 3502
16a97296
PE
3503 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3504 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3505 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3506 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3507 * keyboard.c, keymap.c, lread.c:
3508 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3509 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3510 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3511 Mark functions with DEFUE instead of DEFUN,
3512 if they are used in other modules.
3513 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3514 decls for now-static functions.
3515 * buffer.h (Fdelete_overlay): Remove decl.
3516 * callproc.c (Fgetenv_internal): Mark as internal.
3517 * composite.c (Fremove_list_of_text_properties): Remove decl.
3518 (Fcomposition_get_gstring): New forward static decl.
3519 * composite.h (Fcomposite_get_gstring): Remove decl.
3520 * dired.c (Ffile_attributes): New forward static decl.
3521 * doc.c (Fdocumntation_property): New forward static decl.
3522 * eval.c (Ffetch_bytecode): New forward static decl.
3523 (Funintern): Remove extern decl; now in .h file where it belongs.
3524 * fileio.c (Fmake_symbolic_link): New forward static decl.
3525 * image.c (Finit_image_library): New forward static decl.
3526 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3527 * intervals.h (Fprevious_property_change):
3528 (Fremove_list_of_text_properties): Remove decls.
3529 * keyboard.c (Fthis_command_keys): Remove decl.
3530 (Fcommand_execute): New forward static decl.
3531 * keymap.c (Flookup_key): New forward static decl.
3532 (Fcopy_keymap): Now static.
3533 * keymap.h (Flookup_key): Remove decl.
3534 * process.c (Fget_process): New forward static decl.
3535 (Fprocess_datagram_address): Mark as internal.
3536 * syntax.c (Fsyntax_table_p): New forward static decl.
3537 (skip_chars): Remove duplicate decl.
3538 * textprop.c (Fprevious_property_change): New forward static decl.
3539 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3540 Now internal.
3541 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3542 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3543
785bbd42
PE
3544 * editfns.c (Fformat): Remove unreachable code.
3545
8b913b57
AS
35462011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3547
3548 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3549 change. (Bug#8496)
3550
a6744a35
EZ
35512011-04-13 Eli Zaretskii <eliz@gnu.org>
3552
3553 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3554 when at ZV. (Bug#8487)
3555
e7974947
AS
35562011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3557
baad03f0
AS
3558 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3559 (Bug#8437)
3560 * keyboard.c (parse_tool_bar_item): Likewise.
3561 * sound.c (sound_cleanup, alsa_close): Likewise.
3562 * termcap.c (tgetent): Likewise.
3563 * xfns.c (x_default_font_parameter): Likewise.
3564 * xsettings.c (read_and_apply_settings): Likewise.
3565
e7974947
AS
3566 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3567 (overrun_check_free): Protoize.
3568
28272684
PE
35692011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3570
3571 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3572 since callers should never pass a negative size.
3573 Change the signature to match that of plain 'read' and 'write'; see
3574 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3575 * lisp.h: Update prototypes of emacs_write and emacs_read.
3576
11997c76
EZ
35772011-04-11 Eli Zaretskii <eliz@gnu.org>
3578
3579 * xdisp.c (redisplay_window): Don't try to determine the character
3580 position of the scroll margin if the window start point w->startp
e896f03c 3581 is outside the buffer's accessible region. (Bug#8468)
11997c76 3582
8a2cbd72
EZ
35832011-04-10 Eli Zaretskii <eliz@gnu.org>
3584
3585 Fix write-region and its subroutines for buffers > 2GB.
3586 * fileio.c (a_write, e_write): Modify declaration of arguments and
3587 local variables to support buffers larger than 2GB.
3588 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3589
3590 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3591 argument, local variables, and return value.
3592
3593 * lisp.h: Update prototypes of emacs_write and emacs_read.
3594
3595 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3596
4073e537 35972011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3598
1ebfdcb6
PE
3599 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3600
b2ded58d
PE
3601 Fix more problems found by GCC 4.6.0's static checks.
3602
7d66342c
PE
3603 * xdisp.c (vmessage): Use a better test for character truncation.
3604
bbf47d44
PE
3605 * charset.c (load_charset_map): <, not <=, for optimization,
3606 and to avoid potential problems with integer overflow.
9248994d 3607 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3608 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3609 * editfns.c (Fformat): Likewise.
1e69125e 3610 * syntax.c (skip_chars): Likewise.
3befa583 3611
e3019616
PE
3612 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3613 This also lets GCC 4.6.0 generate slightly better loop code.
3614
becfa255
PE
3615 * callint.c (Fcall_interactively): <, not <=, for optimization.
3616 (Fcall_interactively): Count the number of arguments produced,
3617 not the number of arguments given. This is simpler and lets GCC
3618 4.6.0 generate slightly better code.
3619
dae0cd48
PE
3620 * ftfont.c: Distingish more carefully between FcChar8 and char.
3621 The previous code passed unsigned char * to a functions like
3622 strlen and xstrcasecmp that expect char *, which does not
3623 conform to the C standard.
3624 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3625 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3626 char * when the C standard requires it.
3627
76032d70
PE
3628 * keyboard.c (read_char): Remove unused var.
3629
eb3f1cc8
PE
3630 * eval.c: Port to Windows vsnprintf (Bug#8435).
3631 Include <limits.h>.
3632 (SIZE_MAX): Define if the headers do not.
3633 (verror): Do not give up if vsnprintf returns a negative count.
3634 Instead, grow the buffer. This ports to Windows vsnprintf, which
3635 does not conform to C99. Problem reported by Eli Zaretskii.
3636 Also, simplify the allocation scheme, by avoiding the need for
3637 calling realloc, and removing the ALLOCATED variable.
3638
70476b54
PE
3639 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3640
12020a9e
PE
3641 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3642 But keep the doprint source code for now, as we might revamp it
3643 and use it again (Bug#8435).
ea6c7ae6
PE
3644 * lisp.h (doprnt): Remove.
3645 * Makefile.in (base_obj): Remove doprnt.o.
3646 * deps.mk (doprnt.o): Remove.
3647
5fdb398c
PE
3648 error: Print 32- and 64-bit integers portably (Bug#8435).
3649 Without this change, on typical 64-bit hosts error ("...%d...", N)
3650 was used to print both 32- and 64-bit integers N, which relied on
3651 undefined behavior.
3652 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3653 New macro.
3654 * lisp.h (error, verror): Mark as printf-like functions.
3655 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3656 Report overflow in size calculations when allocating printf buffer.
3657 Do not truncate output string at its first null byte.
3658 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3659 Truncate the output at a character boundary, since vsnprintf does not
3660 do that.
3661 * charset.c (check_iso_charset_parameter): Convert internal
3662 character to string before calling 'error', since %c now has the
3663 printf meaning.
3664 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3665 overflow when computing char to be passed to 'error'. Do not
3666 pass Lisp_Object to 'error'; pass the integer instead.
3667 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3668 formatted with plain %d.
3669
b189fa66
PE
3670 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3671
bff87ef0
PE
3672 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3673
7e2cac20
PE
3674 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3675
ce4d90b5
PE
3676 * xterm.c (x_catch_errors): Remove duplicate declaration.
3677
266c9547
PE
3678 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3679
79c49ad2
PE
3680 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3681
368f4090
JM
36822011-04-10 Jim Meyering <meyering@redhat.com>
3683
3684 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3685 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3686 return ssize_t not "int", and use size_t as the buffer length.
3687 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3688 * gnutls.h: Update declarations.
3689 * process.c (read_process_output): Use ssize_t, to match.
3690 (send_process): Likewise.
3691
a32d4040
CY
36922011-04-09 Chong Yidong <cyd@stupidchicken.com>
3693
3694 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3695
8546720e 36962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3697
04f2d78b
CB
3698 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3699 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3700
8546720e
GM
3701 * xterm.c (handle_one_xevent):
3702 * xmenu.c (create_and_show_popup_menu):
3703 * xselect.c (x_decline_selection_request)
3704 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3705
0a2f5c1a 37062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3707
3708 Fix some uses of `int' instead of EMACS_INT.
3709 * search.c (string_match_1, fast_string_match)
3710 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3711 (scan_buffer, find_next_newline_no_quit)
3712 (find_before_next_newline, search_command, Freplace_match)
3713 (Fmatch_data): Make some `int' variables be EMACS_INT.
3714
3715 * xdisp.c (display_count_lines): 3rd argument and return value now
3716 EMACS_INT. All callers changed.
3717 (pint2hrstr): Last argument is now EMACS_INT.
3718
3719 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3720 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3721 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3722 (decode_coding_utf_16, decode_coding_emacs_mule)
3723 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3724 (decode_coding_ccl, decode_coding_charset)
3725 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3726 (decode_coding_iso_2022, decode_coding_emacs_mule)
3727 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3728 <char_offset, last_offset>: Declare EMACS_INT.
3729 (encode_coding_utf_8, encode_coding_utf_16)
3730 (encode_coding_emacs_mule, encode_invocation_designation)
3731 (encode_designation_at_bol, encode_coding_iso_2022)
3732 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3733 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3734 Declare EMACS_INT.
3735 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3736 (encode_invocation_designation): Last argument P_NCHARS is now
3737 EMACS_INT.
3738 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3739 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3740
3741 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3742 All users changed.
3743
3744 * ccl.c (Fccl_execute_on_string): Declare some variables
3745 EMACS_INT.
3746
8546720e 37472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3748
3749 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3750
4e19a977
CS
37512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3752
3753 * process.c (Fformat_network_address): Doc fix.
3754
87302331
R
37552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3756
3757 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3758
cbb59342
CY
37592011-04-08 Chong Yidong <cyd@stupidchicken.com>
3760
3761 * keyboard.c (read_char): Call Lisp function help-form-show,
3762 instead of using internal_with_output_to_temp_buffer.
3763 (Qhelp_form_show): New var.
e0d38eeb 3764 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3765
3766 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3767
3768 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3769
e67a13ab
CY
37702011-04-06 Chong Yidong <cyd@stupidchicken.com>
3771
04f2d78b
CB
3772 * process.c (Flist_processes): Remove to Lisp.
3773 (list_processes_1): Delete.
e67a13ab 3774
973f782d
EZ
37752011-04-06 Eli Zaretskii <eliz@gnu.org>
3776
7c106b1e
EZ
3777 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3778
973f782d
EZ
3779 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3780
41cf7d1a 37812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3782
ca23cc88
PE
3783 Fix more problems found by GCC 4.6.0's static checks.
3784
f390e2d5
PE
3785 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3786
42eea0d0
PE
3787 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3788
b69769da 3789 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3790
f9541e84
PE
3791 * xdisp.c (vmessage): Mark as a printf-like function.
3792
13841b55
PE
3793 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3794
c136c10f
PE
3795 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3796
5e2d4a30
PE
3797 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3798 printf-like functions.
3799 (tiff_load): Add casts to remove these marks before passing them
3800 to system-supplied API.
3801
583f48b9
PE
3802 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3803
b25d760e
PE
3804 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3805 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3806 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3807 directly, rather than having caller test rule sign. This avoids
3808 some unnecessary tests.
3809 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3810 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3811 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3812
bc7b6697 3813 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3814 (xfont_open): Avoid unnecessary tests.
bc7b6697 3815
27ccc379
PE
3816 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3817
dcd5c89a
PE
3818 * composite.h, composite.c (composition_gstring_put_cache):
3819 Use EMACS_INT, not int, for length.
3820
b13a45c6
PE
3821 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3822 breaking out part of COMPOSITION_DECODE_RULE.
3823 (COMPOSITION_DECODE_RULE): Use it.
3824 * composite.c (get_composition_id): Remove unused local vars,
3825 by using the new macro.
3826
1e792e4d
PE
3827 * textprop.c (set_text_properties_1): Change while to do-while,
3828 since the condition is always true at first.
3829
dc6c6455 3830 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3831 (interval_deletion_adjustment): Return unsigned value.
3832 All uses changed.
dc6c6455 3833
aba7731a
PE
3834 * process.c (list_processes_1, create_pty, read_process_output):
3835 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3836 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3837 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3838 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3839 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3840
fdfc4bf3
PE
3841 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3842
fca8fe46 3843 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3844 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3845
06a0259a 3846 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3847 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3848 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3849
e7b9e80f
PE
3850 * print.c (print_error_message): Avoid int overflow.
3851
56201685
PE
3852 * font.c (font_list_entities): Redo for clarity,
3853 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3854
78834453 3855 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3856 (font_score): Avoid potential overflow in diff calculation.
78834453 3857
0bc0b309 3858 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3859 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3860
e610eaca
PE
3861 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3862
b895abce
PE
3863 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3864 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3865 can always succeed if overflow has undefined behavior.
3866
1f1d9321 3867 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3868 (wordify): Omit three unnecessary tests.
1f1d9321 3869
c59478bc
PE
3870 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3871 All callers changed. This avoids the need for an unused var.
3872
79b73827
PE
3873 * casefiddle.c (casify_region): Remove var that is set but not used.
3874
a4db5dfe
PE
3875 * dired.c (file_name_completion): Remove var that is set but not used.
3876
43aae36e
PE
3877 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3878
2a47c44d 3879 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3880 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3881
a37c69bf
PE
3882 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3883 Check for integer overflow on size calculations.
3884
328ab8e7
PE
3885 * buffer.c (Fprevious_overlay_change): Remove var that is set
3886 but not used.
3887
e5a2a5cb
PE
3888 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3889 Remove vars that are set but not used.
8d84a6eb 3890 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3891 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3892
a60e5f68
PE
3893 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3894
f661cb61 3895 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3896 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3897
f0397f5a
PE
3898 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3899 that are set but not used.
3900
8664db06 3901 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3902 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3903
6abdaa4a
PE
3904 * xselect.c (x_get_local_selection, x_handle_property_notify):
3905 Remove vars that are set but not used.
3906
0ce7538d 3907 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3908 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3909
9ae848fc
PE
3910 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3911 Remove var that is set but not used.
0b918413
PE
3912 (scroll_bar_windows_size): Now size_t, not int.
3913 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3914 Check for overflow.
9ae848fc 3915
a5a62657
PE
3916 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3917 (map_tty_color) [!defined MSDOS]: Likewise.
3918
5c5cdd39
PE
3919 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3920
66ebf983
PE
3921 * coding.c: Remove vars that are set but not used.
3922 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3923 All callers changed.
3924 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3925 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3926 (decode_coding_charset): Remove vars that are set but not used.
3927
1be4d761
PE
3928 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3929 that is set but not used.
3930
47553fa8
PE
3931 * print.c (print_object): Remove var that is set but not used.
3932
1f7196bf 3933 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3934 The gnulib version avoids calling malloc in the usual case,
3935 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3936 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3937 * filelock.c (current_lock_owner): Likewise.
3938 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3939 * sysdep.c: Include allocator.h, careadlinkat.h.
3940 (emacs_no_realloc_allocator): New static constant.
3941 (emacs_readlink): New function.
fdb61804
PE
3942 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3943 ../lib/careadlinkat.h.
d1fdcab7 3944
f84c17c7
SM
39452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3946
3947 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3948 first non-nil return value).
3949
ef3862ad
JD
39502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3951
3952 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3953 if not defined (Bug#8403).
3954
376a7006
JB
39552011-04-02 Juanma Barranquero <lekktu@gmail.com>
3956
3957 * xdisp.c (display_count_lines): Remove parameter `start',
3958 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3959 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3960 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3961 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3962 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3963 and thereabouts. All callers changed.
3964 (get_per_char_metric): Remove parameter `f', unused since
3965 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3966
6ca3801d
JM
39672011-04-02 Jim Meyering <meyering@redhat.com>
3968
3969 do not dereference NULL upon failed strdup
3970 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3971 (ns_get_family): Likewise.
3972
d8e2b5ba
JB
39732011-04-02 Juanma Barranquero <lekktu@gmail.com>
3974
3975 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3976
8c74fcbd
JD
39772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3978
3979 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3980 later (Bug#8403).
3981
7200d79c
SM
39822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3983
03408648 3984 Add lexical binding.
7200d79c 3985
03408648
SM
3986 * window.c (Ftemp_output_buffer_show): New fun.
3987 (Fsave_window_excursion):
3988 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3989
3990 * lread.c (lisp_file_lexically_bound_p): New function.
3991 (Fload): Bind Qlexical_binding.
3992 (readevalloop): Remove `evalfun' arg.
3993 Bind Qinternal_interpreter_environment.
3994 (Feval_buffer): Bind Qlexical_binding.
3995 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3996 Mark as dynamic.
3997 (syms_of_lread): Declare `lexical-binding'.
3998
3999 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4000
4001 * keyboard.c (eval_dyn): New fun.
4002 (menu_item_eval_property): Use it.
ca105506
SM
4003
4004 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4005
03408648
SM
4006 * fns.c (concat, mapcar1): Accept byte-code-functions.
4007
4008 * eval.c (Fsetq): Handle lexical vars.
4009 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4010 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4011 (FletX, Flet): Obey lexical binding.
4012 (Fcommandp): Handle closures.
4013 (Feval): New `lexical' arg.
4014 (eval_sub): New function extracted from Feval. Use it almost
4015 everywhere where Feval was used. Look up vars in lexical env.
4016 Handle closures.
4017 (Ffunctionp): Move from subr.el.
4018 (Ffuncall): Handle closures.
4019 (apply_lambda): Remove `eval_flags'.
4020 (funcall_lambda): Handle closures and new byte-code-functions.
4021 (Fspecial_variable_p): New function.
4022 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4023 but without exporting it to Lisp.
23aba0ea 4024
23aba0ea 4025 * doc.c (Fdocumentation, store_function_docstring):
03408648 4026 * data.c (Finteractive_form): Handle closures.
23aba0ea 4027
03408648
SM
4028 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4029 interactive spec.
ba83908c 4030
04f2d78b
CB
4031 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4032 New byte-codes.
03408648
SM
4033 (exec_byte_code): New function extracted from Fbyte_code to handle new
4034 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4035
03408648 4036 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4037
03408648 4038 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4039
e2abce01
JB
40402011-03-31 Juanma Barranquero <lekktu@gmail.com>
4041
4042 * xdisp.c (redisplay_internal): Fix prototype.
4043
63696a73 40442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4045
63696a73 4046 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4047 (try_scrolling): Use it when setting scroll_limit.
4048 Limit scrolling to 100 screen lines.
63696a73
EZ
4049 (redisplay_window): Even when falling back on "recentering",
4050 position point in the window according to scroll-conservatively,
4051 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4052
4053 (try_scrolling): When point is above the window, allow searching
4054 as far as scroll_max, or one screenful, to compute vertical
4055 distance from PT to the scroll margin position. This prevents
4056 try_scrolling from unnecessarily failing when
4057 scroll-conservatively is set to a value slightly larger than the
4058 window height. Clean up the case of PT below the margin at bottom
4059 of window: scroll_max can no longer be INT_MAX. When aggressive
4060 scrolling is in use, don't let point enter the opposite scroll
4061 margin as result of the scroll.
4062 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4063 threshold of 100 lines for never-recentering scrolling.
4064
e4cc2dfc
JB
40652011-03-31 Juanma Barranquero <lekktu@gmail.com>
4066
4067 * dispextern.h (move_it_by_lines):
4068 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4069 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4070 (message_log_check_duplicate): Remove parameters `prev_bol' and
4071 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4072 (redisplay_internal): Remove parameter `preserve_echo_area',
4073 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4074
4075 * indent.c (Fvertical_motion):
4076 * window.c (window_scroll_pixel_based, Frecenter):
4077 Don't pass `need_y_p' to `move_it_by_lines'.
4078
1c470562
SM
40792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4080
44f230aa
SM
4081 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4082 steal a few bits to be more compact.
4083 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4084 Remove unneeded casts.
4085
1c470562
SM
4086 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4087
888adce9
ZK
40882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4089
4090 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4091 binding" message (bug#7967).
4092
f838ed7b
PE
40932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4094
77861b95
PE
4095 Fix more problems found by GCC 4.6.0's static checks.
4096
de6dbc14
PE
4097 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4098 Remove unused local var.
4099
f838ed7b
PE
4100 * editfns.c (Fmessage_box): Remove unused local var.
4101
792c7b2b
PE
4102 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4103 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4104 Omit unused local vars.
c499e557 4105 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4106 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4107 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4108 Omit unused local var.
4109
ba0165e1
PE
4110 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4111 Don't assume string length fits in int.
32ad8845 4112 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4113 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4114
3c59b4c9
PE
4115 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4116 instead of alloca (Bug#8344).
4117
a3eed478 4118 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4119 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4120
eb4d412d
PE
4121 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4122
1658b401
PE
4123 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4124 concerns.
4125
4126 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4127
4128 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4129
9a2c6e05
PE
4130 * keyboard.c (syms_of_keyboard): Use the same style as later
4131 in this function when indexing through an array. This also
4132 works around GCC bug 48267.
4133
03d0a109
PE
4134 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4135
44f730c8
PE
4136 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4137
fe75f926
PE
4138 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4139 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4140
ffa8c828
PE
4141 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4142 This avoids undefined behavior on integer overflow, and is a bit
4143 more convenient anyway since it is compared to a size_t variable.
4144
c5101a77
PE
4145 Variadic C functions now count arguments with size_t, not int.
4146 This avoids an unnecessary limitation on 64-bit machines, which
4147 caused (substring ...) to crash on large vectors (Bug#8344).
4148 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4149 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4150 All variadic functions and their callers changed accordingly.
c5101a77
PE
4151 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4152 * data.c (arith_driver, float_arith_driver): Likewise.
4153 * editfns.c (general_insert_function): Likewise.
4154 * eval.c (struct backtrace.nargs, interactive_p)
4155 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4156 (funcall_lambda, mark_backtrace): Likewise.
4157 * fns.c (concat): Likewise.
4158 * frame.c (x_set_frame_parameters): Likewise.
4159 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4160 0 if not found, not -1. All callers changed.
4161
dd3f25f7
PE
4162 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4163 (stack_copy_size): Now size_t, not int.
4164 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4165
461c2ab9
JB
41662011-03-28 Juanma Barranquero <lekktu@gmail.com>
4167
4168 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4169 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4170 All callers changed.
4171
4172 * lisp.h (multibyte_char_to_unibyte):
4173 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4174 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4175 * character.h (CHAR_TO_BYTE8):
4176 * cmds.c (internal_self_insert):
4177 * editfns.c (general_insert_function):
4178 * keymap.c (push_key_description):
4179 * search.c (Freplace_match):
4180 * xdisp.c (message_dolog, set_message_1): All callers changed.
4181
f6d62986
SM
41822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4183
4184 * keyboard.c (safe_run_hook_funcall): New function.
4185 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4186 don't set the hook to nil, but remove the offending function instead.
4187 (Qcommand_hook_internal): Remove, unused.
4188 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4189 Vcommand_hook_internal.
4190
4191 * eval.c (enum run_hooks_condition): Remove.
4192 (funcall_nil, funcall_not): New functions.
4193 (run_hook_with_args): Call each function through a `funcall' argument.
4194 Remove `cond' argument, now redundant.
4195 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4196 (Frun_hook_with_args_until_failure): Adjust accordingly.
4197 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4198
1db5b1ad
JB
41992011-03-28 Juanma Barranquero <lekktu@gmail.com>
4200
4201 * dispextern.h (string_buffer_position): Remove declaration.
4202
4203 * print.c (strout): Remove parameter `multibyte', unused since
4204 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4205
4206 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4207 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4208 All callers changed.
4209
4210 * w32.c (_wsa_errlist): Use braces for struct initializers.
4211
4212 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4213 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4214 All callers changed.
4215 (string_buffer_position): Likewise. Also, make static (it's never
4216 used outside xdisp.c).
4217 (cursor_row_p): Remove parameter `w', unused since
4218 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4219 (decode_mode_spec): Remove parameter `precision', introduced during
4220 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4221 All callers changed.
4222
5ffb62aa
JD
42232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4224
4225 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4226
461c2ab9 42272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4228
4229 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4230 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4231 (ns_update_auto_hide_menu_bar): New functions.
4232 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4233 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4234 ns_constrain_all_frames.
4235 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4236 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4237
5c380ffb
JD
42382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4239
4240 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4241
9af30bdf
GM
42422011-03-27 Glenn Morris <rgm@gnu.org>
4243
4244 * syssignal.h: Replace RETSIGTYPE with void.
4245 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4246 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4247 Replace SIGTYPE with void everywhere.
4248 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4249 * s/template.h (SIGTYPE): Remove commented out definition.
4250
e2abce01
JB
42512011-03-26 Eli Zaretskii <eliz@gnu.org>
4252
4253 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4254 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4255
f868cd8a
JB
42562011-03-26 Juanma Barranquero <lekktu@gmail.com>
4257
59eb0929
JB
4258 * w32.c (read_unc_volume): Use parameter `henum', instead of
4259 global variable `wget_enum_handle'.
4260
4261 * keymap.c (describe_vector): Remove parameters `indices' and
4262 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4263 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4264
f868cd8a
JB
4265 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4266
4267 * keyboard.c (timer_check): Remove parameter `do_it_now',
4268 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4269 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4270 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4271
4272 * keyboard.c (read_char):
4273 * w32menu.c (w32_menu_display_help):
4274 * xmenu.c (show_help_event, menu_help_callback):
4275 Adjust calls to `show_help_echo'.
4276
4277 * gtkutil.c (xg_maybe_add_timer):
4278 * keyboard.c (readable_events):
4279 * process.c (wait_reading_process_output):
4280 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4281
4282 * insdel.c (adjust_markers_gap_motion):
4283 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4284 (gap_left, gap_right): Don't call it.
4285
2ecf6fdb
CY
42862011-03-25 Chong Yidong <cyd@stupidchicken.com>
4287
4288 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4289 incurred during fontification.
4290
6b1f9ba4
JB
42912011-03-25 Juanma Barranquero <lekktu@gmail.com>
4292
4293 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4294 (DEFVAR_PER_BUFFER): Don't pass it.
4295
4296 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4297 (scrolling_window): Don't pass it.
4298
0f4a96b5
JB
42992011-03-25 Juanma Barranquero <lekktu@gmail.com>
4300
4301 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4302
4303 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4304 and `suffix'.
4305 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4306 of variables specific to SELinux and computation of `encoded_absname'.
4307
4308 * image.c (XPutPixel): Remove unused variable `height'.
4309
4310 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4311
4312 * unexw32.c (get_section_info): Remove unused variable `section'.
4313
4314 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4315 (system_process_attributes): Remove unused variable `sess'.
4316 (sys_read): Remove unused variable `err'.
4317
4318 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4319 (w32_wnd_proc): Remove unused variable `isdead'.
4320 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4321 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4322 (x_create_tip_frame): Remove unused variable `tem'.
4323
4324 * w32inevt.c (w32_console_read_socket):
4325 Remove unused variable `no_events'.
4326
4327 * w32term.c (x_draw_composite_glyph_string_foreground):
4328 Remove unused variable `width'.
4329
1149507c
JB
43302011-03-24 Juanma Barranquero <lekktu@gmail.com>
4331
4332 * w32term.c (x_set_glyph_string_clipping):
4333 Don't pass uninitialized region to CombineRgn.
4334
9c88f339
JB
43352011-03-23 Juanma Barranquero <lekktu@gmail.com>
4336
4337 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4338 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4339 (Fx_close_connection): Remove unused variable `i'.
4340
4341 * w32font.c (w32font_draw): Return number of glyphs.
4342 (w32font_open_internal): Remove unused variable `i'.
4343 (w32font_driver): Add missing initializer.
4344
4345 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4346 (fill_in_menu): Remove unused variable `items_added'.
4347
4348 * w32term.c (last_mouse_press_frame): Remove static global variable.
4349 (w32_clip_to_row): Remove unused variable `f'.
4350 (x_delete_terminal): Remove unused variable `i'.
4351
4352 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4353 (NOTHING): Remove unused static global variable.
4354 (uniscribe_check_otf): Remove unused variable `table'.
4355 (uniscribe_font_driver): Add missing initializers.
4356
dee091a3
JD
43572011-03-23 Julien Danjou <julien@danjou.info>
4358
4359 * term.c (Fsuspend_tty, Fresume_tty):
4360 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4361 * window.c (temp_output_buffer_show):
4362 * insdel.c (signal_before_change):
4363 * frame.c (Fhandle_switch_frame):
4364 * fileio.c (Fdo_auto_save):
4365 * emacs.c (Fkill_emacs):
4366 * editfns.c (save_excursion_restore):
4367 * cmds.c (internal_self_insert):
4368 * callint.c (Fcall_interactively):
4369 * buffer.c (Fkill_all_local_variables):
4370 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4371 Use Frun_hooks.
0f4a96b5 4372 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4373 unconditionnaly since it does the check itself.
4374
2c520ab5 43752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4376
c9c49752
PE
4377 Fix more problems found by GCC 4.5.2's static checks.
4378
8abc3f12
PE
4379 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4380 the first time through the loop, since we know p0 < p1 then.
4381 This also avoids a gcc -Wstrict-overflow warning.
4382
a2d26660
PE
4383 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4384 leading to a memory leak, possible in functions like
4385 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4386 of objects (Bug#8318).
a2d26660 4387
916c72e9
PE
4388 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4389 that could (at least in theory) be that large.
4390
19ab8a18
PE
4391 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4392 This is less likely to overflow, and avoids undefined behavior if
4393 overflow does occur. All callers changed. Use strtoul to scan
4394 for the unsigned long integer.
b7cbbd6f
PE
4395 (pint2hrstr): Simplify and tune code slightly.
4396 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4397
f0641eff
PE
4398 * scroll.c (do_scrolling): Work around GCC bug 48228.
4399 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4400
7f650bb9
PE
4401 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4402 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4403 (validate_x_resource_name): Simplify count usage.
4404 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4405
37dd57d1
PE
4406 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4407 fail (Bug#8306).
81e56e61 4408
699979fc 4409 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4410
401bf9b4
PE
4411 * process.c (Fmake_network_process): Use socklen_t, not int,
4412 where POSIX says socklen_t is required in portable programs.
4413 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4414 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4415 (Fmake_network_process, server_accept_connection):
4416 (wait_reading_process_output, read_process_output):
4417 Likewise.
4418
b93aacde
PE
4419 * process.c: Rename or move locals to avoid shadowing.
4420 (list_processes_1, Fmake_network_process):
4421 (read_process_output_error_handler, exec_sentinel_error_handler):
4422 Rename or move locals.
4dc343ee 4423 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4424 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4425 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4426 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4427 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4428
af8a867c 4429 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4430 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4431 Include tparam.h instead, since it declares them.
af8a867c
PE
4432 * cm.h (PC): Remove extern decl; tparam.h now does this.
4433 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4434 * terminfo.c: Include tparam.h, to check interfaces.
4435 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4436 (tparam): Adjust signature to match interface in tparam.h;
4437 this removes some undefined behavior. Check that outstring and len
4438 are zero, which they always are with Emacs.
4439 * tparam.h (PC, BC, UP): New extern decls.
4440
0248044d 4441 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4442 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4443
8ff096c1 4444 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4445 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4446 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4447 (ftfont_list): Remove unused local.
49eaafba
PE
4448 (get_adstyle_property, ftfont_pattern_entity):
4449 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4450 Rename locals to avoid shadowing.
8ff096c1 4451
e2be39f6
PE
4452 * xfont.c (xfont_list_family): Mark var as initialized.
4453
c9735e30
PE
4454 * xml.c (make_dom): Now static.
4455
8f5201ae
PE
4456 * composite.c (composition_compute_stop_pos): Rename local to
4457 avoid shadowing.
b246f932
PE
4458 (composition_reseat_it): Remove unused locals.
4459 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4460 (composition_update_it): Mark var as initialized.
11b61122
PE
4461 (find_automatic_composition): Mark vars as initialized,
4462 with a FIXME (Bug#8290).
8f5201ae 4463
760fbc2c
PE
4464 character.h: Rename locals to avoid shadowing.
4465 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4466 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4467 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4468 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4469 to avoid shadowing.
4470
ff08eb85
PE
4471 * textprop.c (property_change_between_p): Remove; unused.
4472
fc7bf025
PE
4473 * intervals.c (interval_start_pos): Now static.
4474
235d7abc
PE
4475 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4476
44f230aa
SM
4477 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4478 Rename locals to avoid shadowing.
3e7d6594 4479
50060332
PE
4480 * sound.c (wav_play, au_play, Fplay_sound_internal):
4481 Fix pointer signedness.
d01f234b 4482 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4483 (wav_play): Initialize a variable to 0, to prevent undefined
4484 behavior (Bug#8278).
50060332 4485
c4fc4e30
PE
4486 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4487
918436ed
PE
4488 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4489
c939f91b
PE
4490 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4491 clobbering (Bug#8298).
b9c7f648
PE
4492 * sysdep.c (sys_subshell): Likewise.
4493 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4494
6bd8c144
PE
4495 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4496 This should get cleaned up, so that child_setup has the
4497 same signature on all platforms.
4498
7710357c 4499 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4500 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4501
c59da222
CY
45022011-03-22 Chong Yidong <cyd@stupidchicken.com>
4503
4504 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4505 not to be necessary, and produces flickering.
4506
66b87493
GM
45072011-03-20 Glenn Morris <rgm@gnu.org>
4508
4509 * config.in: Remove file.
4510
45b6f6d5
JB
45112011-03-20 Juanma Barranquero <lekktu@gmail.com>
4512
4513 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4514 are now in src/globals.h.
4515 (syms_of_minibuf): Remove spurious & from previous change.
4516
3ec03f7e
LL
45172011-03-20 Leo <sdl.web@gmail.com>
4518
4519 * minibuf.c (completing-read-function): New variable.
4520 (completing-read-default): Rename from completing-read.
4521 (completing-read): Call completing-read-function.
4522
b14e3e21
CY
45232011-03-19 Juanma Barranquero <lekktu@gmail.com>
4524
4525 * xfaces.c (Fx_load_color_file):
4526 Read color file from absolute filename (bug#8250).
4527
f2b726e6
JB
45282011-03-19 Juanma Barranquero <lekktu@gmail.com>
4529
4530 * makefile.w32-in: Update dependencies.
4531
09f6ff02
EZ
45322011-03-17 Eli Zaretskii <eliz@gnu.org>
4533
4534 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4535
29a6015a
PE
45362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4537
a3a6c54e
PE
4538 Fix more problems found by GCC 4.5.2's static checks.
4539
b766f867
PE
4540 * process.c (make_serial_process_unwind, send_process_trap):
4541 (sigchld_handler): Now static.
4542
be02381c
PE
4543 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4544 That way, the code declares only the vars that it needs.
4545 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4546 * s/cygwin.h (PTY_ITERATION): Likewise.
4547 * s/darwin.h (PTY_ITERATION): Likewise.
4548 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4549
57048744
PE
4550 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4551 * process.c (allocate_pty): Don't declare stb unless it's needed.
4552
7914961c 4553 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4554 (CONSTANTLIM): Remove; unused.
4555 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4556 Define only if needed.
7914961c 4557
b3967b18
PE
4558 * unexelf.c (unexec): Name an expression,
4559 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4560 Use a different way to cause a compilation error if anyone uses
4561 n rather than nn, a way that does not involve shadowing.
73366a00 4562 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4563
29a6015a
PE
4564 * deps.mk (unexalpha.o): Remove; unused.
4565
43cfc33e 4566 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4567 * unexec.h: New file.
ce701a33
PE
4568 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4569 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4570 Depend on unexec.h.
4571 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4572 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4573 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4574 Change as necessary to match prototype in unexec.h.
ce701a33 4575
01f44d5a
PE
4576 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4577 shadowing.
4f63c6bb 4578 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4579
a6670b0b
PE
4580 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4581 Rename locals to avoid shadowing.
4582
cef2010d 4583 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4584 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4585
d4d7173a
PE
4586 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4587
f08b802a
PE
4588 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4589 warning when compiling print.c.
4590
3ddb0639
PE
4591 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4592 instead of using an uninitialized var.
5ad03b97 4593 (font_sort_entities): Mark var as initialized.
3ddb0639 4594
170a2692
PE
4595 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4596
e663c700
PE
4597 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4598 pointers to constants.
89bc529a 4599 (font_parse_fcname): Remove unused vars.
7b81e2d0 4600 (font_delete_unmatched): Now static.
ea838e10 4601 (font_get_spec): Remove; unused.
13a547c6
PE
4602 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4603 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4604 Rename or move locals to avoid shadowing.
e663c700 4605
2a80c887 4606 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4607 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4608
1384fa33 4609 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4610 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4611
8b2c52e9
PE
4612 * alloc.c (mark_backtrace): Move decl from here ...
4613 * lisp.h: ... to here, so that it can be checked.
4614
475545b5 4615 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4616 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4617 (lisp_indirect_variable): Name an expression,
4618 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4619 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4620
b1349114 4621 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4622 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4623 Use const pointer when appropriate.
b1349114 4624
a2928364
PE
4625 * lisp.h (get_system_name, get_operating_system_release):
4626 Move decls here, to check interfaces.
4627 * process.c (get_operating_system_release): Move decl to lisp.h.
4628 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4629 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4630 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4631 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4632 (Fformat_time_string, Fencode_time, Finsert_char):
4633 (Ftranslate_region_internal, Fformat):
4634 Rename or remove local vars to avoid shadowing.
9710023e 4635 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4636
a415e694
PE
4637 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4638 avoid shadowing.
4639
8ef4622d
PE
4640 * lisp.h (eassert): Check that the argument compiles, even if
4641 ENABLE_CHECKING is not defined.
4642
946f9a5b
PE
4643 * data.c (Findirect_variable): Name an expression, to avoid
4644 gcc -Wbad-function-cast warning.
112396d6 4645 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4646 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4647 (Fmake_variable_buffer_local, Fmake_local_variable):
4648 Mark variables as initialized.
52746918 4649 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4650
e5aab7e7 4651 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4652 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4653 Rename locals to avoid shadowing.
dff45157
PE
4654 (mark_stack): Move local variables into the #ifdef region where
4655 they're used.
7bc26fdb
PE
4656 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4657 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4658 needed otherwise.
4659 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4660 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4661 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4662
e5aab7e7
PE
4663 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4664 avoids undefined behavior in theory.
4665
4da60324
PE
4666 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4667
88043301
PE
4668 Use functions, not macros, for up- and down-casing (Bug#8254).
4669 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4670 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4671 to use the following functions instead of these macros.
4672 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4673 EMACS_INT, since callers assume the returned value fits in int.
4674 (upcase1): Likewise, for UPCASE_TABLE.
4675 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4676 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4677 the race-condition problem in the old DOWNCASE.
88043301 4678
19ed5445
PE
4679 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4680 Rename locals to avoid shadowing.
4681 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4682 (regex_compile, re_search_2, re_match_2_internal):
4683 Remove unused local vars.
952db0d7
PE
4684 (FREE_VAR): Rewrite so as not to use empty "else",
4685 which gcc can warn about.
da053e48 4686 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4687 (RETALLOC_IF): Define only if needed.
4688 (WORDCHAR_P): Likewise. This one is never needed, but is used
4689 only in a comment talking about a compiler bug, so put inside
4690 the #if 0 of that comment.
4691 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4692 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4693 Remove; unused.
19ed5445 4694
1f3561e4 4695 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4696 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4697 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4698
ded6f8f7
PE
4699 * search.c (simple_search): Remove unused var.
4700
dbd37a95
PE
4701 * dired.c (compile_pattern): Move decl from here ...
4702 * lisp.h: ... to here, so that it can be checked.
4703 (struct re_registers): New forward decl.
4704
7e47afad
PE
4705 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4706
85f24f61
PE
4707 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4708 All uses changed.
4709 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4710 Rename locals to avoid shadowing.
5671df8f 4711 (Fvertical_motion): Mark locals as initialized.
85f24f61 4712
181aa2be 4713 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4714 (casify_region): Mark local as initialized.
181aa2be 4715
930d429c
PE
4716 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4717
7082eac6
PE
4718 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4719 New macros, so that the caller can use some names other than
4720 gcpro1, gcpro2, etc.
4721 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4722 of the new macros.
4723 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4724 argument, for consistency with GCPRO2_VAR, etc: it is now the
4725 prefix of the variable, not the variable itself. All uses
4726 changed.
38b2c076
PE
4727 * dired.c (directory_files_internal, file_name_completion):
4728 Rename locals to avoid shadowing.
4729
15206ed9
PE
4730 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4731 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4732 dired.c's scmp function, had undefined behavior.
4733 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4734 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4735 * buffer.h: ... to here, because these macros use current_buffer,
4736 and the new implementation with inline functions needs to have
4737 current_buffer in scope now, rather than later when the macros
4738 are used.
4739 (downcase, upcase1): New static inline functions.
4740 (DOWNCASE, UPCASE1): Reimplement using these functions.
4741 This avoids undefined behavior in expressions like
4742 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4743 from race conditions in accessing the global variables
4744 case_temp1 and case_temp2.
4745 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4746 * lisp.h (case_temp1, case_temp2): Remove their decls.
4747 * character.h (ASCII_CHAR_P): Move from here ...
4748 * lisp.h: ... to here, so that the inline functions mentioned
4749 above can use them.
4750
4a6bea26
PE
4751 * dired.c (directory_files_internal_unwind): Now static.
4752
f14b7e14
PE
4753 * fileio.c (file_name_as_directory, directory_file_name):
4754 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4755 Now static.
2893f146
PE
4756 (file_name_as_directory): Use const pointers when appropriate.
4757 (Fexpand_file_name): Likewise. In particular, newdir might
4758 point at constant storage, so make it a const pointer.
fd4ead52 4759 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4760 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4761 signedness issues.
f839df0c
PE
4762 (Fset_file_times, Finsert_file_contents, auto_save_error):
4763 Rename locals to avoid shadowing.
f14b7e14 4764
5716756e 4765 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4766 (Ftry_completion, Fall_completions): Rename or remove locals
4767 to avoid shadowing.
5716756e 4768
b4c3046a
PE
4769 * marker.c (bytepos_to_charpos): Remove; unused.
4770
b45db522
PE
4771 * lisp.h (verify_bytepos, count_markers): New decls,
4772 so that gcc does not warn that these functions aren't declared.
4773
85876d07
PE
4774 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4775 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4776 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4777 (copy_text): Remove unused local var.
85876d07 4778
03d78a21 4779 * filelock.c (within_one_second): Now static.
b3dd38ab 4780 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4781
5df8f01b
PE
4782 * buffer.c (fix_overlays_before): Mark locals as initialized.
4783 (fix_start_end_in_overlays): Likewise. This function should be
4784 simplified by using pointers-to-pointers, but that's a different
4785 matter.
b1d876f1 4786 (switch_to_buffer_1): Now static.
8f54f30a
PE
4787 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4788 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4789
a70072c9 4790 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4791 Fix pointer signedness issue.
edced198
PE
4792 (sys_subshell): Mark local as volatile if checking for lint,
4793 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4794 (MAXPATHLEN): Define only if needed.
a70072c9 4795
a0977c44
PE
4796 * process.c (serial_open, serial_configure): Move decls from here ...
4797 * systty.h: ... to here, so that they can be checked.
4798
a884fdcc
PE
4799 * fns.c (get_random, seed_random): Move extern decls from here ...
4800 * lisp.h: ... to here, so that they can be checked.
4801
604efe86 4802 * sysdep.c (reset_io): Now static.
b8950c94 4803 (wait_for_termination_signal): Remove; unused.
604efe86 4804
38fc62d9
PE
4805 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4806 (copy_keymap_item, append_key, push_text_char_description):
4807 Now static.
1004a21a 4808 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4809 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4810 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4811 (describe_map_tree):
4812 Rename locals to avoid shadowing.
38fc62d9 4813
2f2650da
PE
4814 * keyboard.c: Declare functions static if they are not used elsewhere.
4815 (echo_char, echo_dash, cmd_error, top_level_2):
4816 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4817 (read_char, kbd_buffer_get_event, make_lispy_position):
4818 (make_lispy_event, make_lispy_movement, apply_modifiers):
4819 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4820 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4821 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4822 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4823 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4824
a053e86c 4825 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4826 (mark_kboards): Move decl here ...
4827 * alloc.c (mark_kboards): ... from here.
a053e86c 4828
4752793e
PE
4829 * lisp.h (force_auto_save_soon): New decl.
4830
74f10ca7 4831 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4832 (DEFINE_DUMMY_FUNCTION): New macro.
4833 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4834 Use it.
c03cd23f
PE
4835 (main): Add casts to avoid warnings
4836 if GCC considers string literals to be constants.
74f10ca7 4837
022e70d4
PE
4838 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4839
59d6fe83
PE
4840 * dbusbind.c: Pointer signedness fixes.
4841 (xd_signature, xd_append_arg, xd_initialize):
4842 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4843 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4844 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4845 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4846
78320123
PE
4847 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4848 if GCC considers string literals to be constants.
49cebcca 4849 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4850
35ac2a97
SM
48512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4852
fb103ca9
SM
4853 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4854 (print_preprocess, print_object): New macro to fix last change.
4855
35ac2a97
SM
4856 * print.c (print_preprocess): Don't forget font objects.
4857
62973b41
JB
48582011-03-16 Juanma Barranquero <lekktu@gmail.com>
4859
4860 * emacs.c (USAGE3): Doc fixes.
4861
0e48bb22
AS
48622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4863
4864 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4865 structure.
4866
7684e57b
JB
48672011-03-14 Juanma Barranquero <lekktu@gmail.com>
4868
4869 * lisp.h (VWindow_system, Qfile_name_history):
4870 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4871 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4872 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4873
4874 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4875 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4876
4877 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4878 * w32console.c (detect_input_pending, read_input_pending)
4879 (encode_terminal_code):
4880 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4881 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4882 (w32_system_caret_y, Qfile_name_history):
4883 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4884 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4885 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4886 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4887 * w32proc.c (Qlocal, report_file_error):
4888 * w32term.c (Vwindow_system, updating_frame):
4889 * w32uniscribe.c (initialized, uniscribe_font_driver):
4890 Remove unneeded extern declarations.
4891
2aa46d6c
CY
48922011-03-14 Chong Yidong <cyd@stupidchicken.com>
4893
c96bbc66 4894 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4895
cffc6f3b
CY
48962011-03-13 Chong Yidong <cyd@stupidchicken.com>
4897
4898 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4899 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4900 These macros can no longer be used for assignment.
4901
44f230aa
SM
4902 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4903 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4904 (record_buffer_markers, fetch_buffer_markers): New functions for
4905 recording and fetching special buffer markers.
4906 (set_buffer_internal_1, set_buffer_temp): Use them.
4907
4908 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4909
4910 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4911
4912 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4913 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4914
4915 * xdisp.c (hscroll_window_tree):
4916 (reconsider_clip_changes): Use PT instead of BUF_PT.
4917
d251f04b
EZ
49182011-03-13 Eli Zaretskii <eliz@gnu.org>
4919
4920 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4921 $(EMACS_ROOT)/lib/intprops.h.
4922
f0c77cd1
PE
49232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4924
3eca4629
PE
4925 Fix more problems found by GCC 4.5.2's static checks.
4926
7c86ee98
PE
4927 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4928 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4929 (xg_free_frame_widgets): Make it clear that a local variable is
4930 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4931 (gdk_window_get_screen): Make it clear that this macro is needed
4932 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4933 (int_gtk_range_get_value): New function, which avoids a diagnostic
4934 from gcc -Wbad-function-cast.
4935 (xg_set_toolkit_scroll_bar_thumb): Use it.
4936 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4937 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4938 (get_utf8_string, xg_get_file_with_chooser):
4939 Rename locals to avoid shadowing.
4940 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4941
41729b81
PE
4942 * xgselect.c (xg_select): Remove unused var.
4943
f0c77cd1
PE
4944 * image.c (four_corners_best): Mark locals as initialized.
4945 (gif_load): Initialize transparent_p to zero (Bug#8238).
4946 Mark another local as initialized.
ec6cf4c6 4947 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4948
ce0ad53d 4949 * image.c (clear_image_cache): Now static.
d5d5a617 4950 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4951 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4952 (x_edge_detection): Remove unnecessary cast that
4953 gcc -Wbad-function-cast diagnoses.
2037898d 4954 (gif_load): Fix pointer signedness.
6ae141d6
PE
4955 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4956 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4957
33383987 49582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4959
d32df629
PE
4960 Improve quality of tests for time stamp overflow.
4961 For example, without this patch (encode-time 0 0 0 1 1
4962 1152921504606846976) returns the obviously-bogus value (-948597
4963 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4964 reports time overflow. See
4965 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4966 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4967 * editfns.c: Include limits.h and intprops.h.
4968 (TIME_T_MIN, TIME_T_MAX): New macros.
4969 (time_overflow): Move earlier, to before first use.
4970 (hi_time, lo_time): New functions, for an accurate test for
4971 out-of-range times.
4972 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4973 (Fget_internal_run_time): Don't assume time_t fits in int.
4974 (make_time): Use list2 instead of Fcons twice.
4975 (Fdecode_time): More accurate test for out-of-range times.
4976 (check_tm_member): New function.
4977 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4978 (lisp_time_argument): Don't rely on undefined left-shift and
4979 right-shift behavior when checking for time stamp overflow.
8be6f318 4980
fe31d94c
PE
4981 * editfns.c (time_overflow): New function, refactoring common code.
4982 (Fformat_time_string, Fdecode_time, Fencode_time):
4983 (Fcurrent_time_string): Use it.
4984
8be6f318
PE
4985 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4986 * dired.c (make_time): Move to ...
4987 * editfns.c (make_time): ... here.
4988 * systime.h: Note the move.
4989
09d9db2c 49902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4991
126bc0dc
YM
4992 * fringe.c (update_window_fringes): Remove unused variables.
4993
c47cbdfd
YM
4994 * unexmacosx.c (copy_data_segment): Also copy __got section.
4995 (Bug#8223)
4996
7ac80be9
EZ
49972011-03-12 Eli Zaretskii <eliz@gnu.org>
4998
c96bbc66 4999 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5000 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5001 Constify `char *' arguments and their references according to
5002 prototypes in tparam.h.
5003
ecb0f94d 5004 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5005
7ac80be9
EZ
5006 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5007 Adapt all references accordingly.
5008
5009 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5010
ef1fd07e
TT
50112011-03-11 Tom Tromey <tromey@redhat.com>
5012
5013 * buffer.c (syms_of_buffer): Remove obsolete comment.
5014
7ef4b50c
EZ
50152011-03-11 Eli Zaretskii <eliz@gnu.org>
5016
5017 * termhooks.h (encode_terminal_code): Declare prototype.
5018
5019 * msdos.c (encode_terminal_code): Don't declare prototype.
5020
5021 * term.c (encode_terminal_code): Now external again, used by
5022 w32console.c and msdos.c.
5023
44f230aa
SM
5024 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5025 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5026
4b1ec863 50272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5028
1714f52b 5029 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5030
4b1ec863
PE
5031 * fringe.c (update_window_fringes): Mark locals as initialized
5032 (Bug#8227).
5033 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5034
524c7aa6
PE
5035 * alloc.c (mark_fringe_data): Move decl from here ...
5036 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5037 to check its interface.
5038 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5039
a5c0af81 5040 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5041 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5042 (fontset_font): Mark local as initialized.
a9a06e0b 5043 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5044
b4716021
PE
5045 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5046
811e9bac 5047 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5048 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5049 (x_own_selection, Fx_disown_selection_internal): Rename locals
5050 to avoid shadowing.
5051 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5052
7e3ab302
PE
5053 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5054 so that the caller can use some name other than gcpro1.
5055 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5056 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5057 (Fx_backspace_delete_keys_p):
5058 Use them to avoid shadowing, and rename vars to avoid shadowing.
5059 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5060 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5061 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5062 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5063 Remove unused locals.
7e3ab302
PE
5064 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5065 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5066 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5067 macros.
f78faa98 5068
e2b13473
PE
5069 * xterm.h (x_mouse_leave): New decl.
5070
77f23912
PE
5071 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5072 Remove unused functions.
cdf4ba58
PE
5073 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5074 (x_calc_absolute_position): Now static.
7411c686 5075 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5076 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5077 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5078 unless they are used.
38d0b34a
PE
5079 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5080 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5081 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5082 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5083 (x_error_catcher, x_connection_closed, x_error_handler):
5084 (x_error_quitter, xembed_send_message, x_iconify_frame):
5085 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5086 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5087 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5088
44f230aa
SM
5089 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5090 Rename or move locals to avoid shadowing.
6b463e58 5091 (tty_defined_color, merge_face_heights): Now static.
5967d051 5092 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5093 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5094 does not deduce is never used uninitialized.
73719eba
PE
5095 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5096 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5097
426994c3 5098 * terminal.c (store_terminal_param): Now static.
5489860b 5099
032f1620 5100 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5101 (set_frame_menubar): Remove unused local.
d4323972 5102 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5103 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5104 since they might point to immutable storage.
281585b0
PE
5105 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5106 since it's unused otherwise.
032f1620 5107
367c19e5 5108 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5109 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5110 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5111 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5112 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5113 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5114 does not deduce are never used uninitialized.
70739cbe 5115
07b48fa9
PE
5116 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5117
8868a238 5118 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5119 * window.c (window_loop, size_window):
5120 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5121
7e5cf297 5122 * window.c (display_buffer): Now static.
d6550a9f
PE
5123 (size_window): Mark variables that gcc -Wuninitialized
5124 does not deduce are never used uninitialized.
a586633d
PE
5125 * window.h (check_all_windows): New decl, to forestall
5126 gcc -Wmissing-prototypes diagnostic.
5b555da1 5127 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5128
f6095868
PE
5129 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5130 shadowing.
5131 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5132 Include <limits.h>.
5133 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5134 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5135 (load_charset_map): Mark variables that gcc -Wuninitialized
5136 does not deduce are never used uninitialized.
53df7c11 5137 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5138
f38b440c
PE
5139 * coding.c (coding_set_source, coding_set_destination):
5140 Use "else { /* comment */ }" rather than "else /* comment */;"
5141 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5142 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5143 a block, when the outer 'i' will do.
5144 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5145 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5146 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5147 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5148 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5149 Rename locals to avoid shadowing.
5150 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5151 * coding.c (emacs_mule_char, encode_invocation_designation):
5152 Now static, since they're not used elsewhere.
413bb2db 5153 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5154 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5155 (decode_coding_emacs_mule): Mark variables that gcc
5156 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5157 (detect_coding_iso_2022): Initialize a local variable that might
5158 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5159 this initialization is needed. (Bug#8211)
5f58e762
PE
5160 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5161 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5162 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5163 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5164 Remove unused macros.
f38b440c 5165
232b38b9 5166 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5167 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5168 * character.c (string_count_byte8): Likewise.
232b38b9 5169
fb90da1b
PE
5170 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5171 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5172
fb93dbc2
PE
5173 * chartab.c (copy_sub_char_table): Now static, since it's not used
5174 elsewhere.
5c156ace
PE
5175 (sub_char_table_ref_and_range, char_table_ref_and_range):
5176 Rename locals to avoid shadowing.
bbcd0949 5177 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5178
7d3b3862 5179 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5180 (BIDI_BOB): Remove unused macro.
7d3b3862 5181
6be7d3da
PE
5182 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5183 deduce are never used uninitialized.
c2ed9c8b 5184 * term.c (encode_terminal_code): Likewise.
6be7d3da 5185
75f8807f 5186 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5187
50938595
PE
5188 * tparam.h: New file.
5189 * term.c, tparam.h: Include it.
5190 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5191 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5192 Move these decls to tparam.h, and make them agree with what
5193 is actually in tparam.c. The previous trick of using incompatible
5194 decls in different modules does not conform to the C standard.
5195 All callers of tparam changed to use tparam's actual API.
5196 * tparam.c (tparam1, tparam, tgoto):
5197 Use const pointers where appropriate.
5198
fbceeba2
PE
5199 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5200 * cm.h (struct cm): Likewise.
5201 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5202 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5203 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5204 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5205 (turn_on_face, init_tty): Likewise.
5206 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5207
7f3f1250
PE
5208 * term.c (term_mouse_position): Rename local to avoid shadowing.
5209
e6ca6543
PE
5210 * alloc.c (mark_ttys): Move decl from here ...
5211 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5212
c40f8d15
AS
52132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5214
5215 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5216
cfe0661d
JB
52172011-03-09 Juanma Barranquero <lekktu@gmail.com>
5218
5219 * search.c (compile_pattern_1): Remove argument regp, unused since
5220 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5221 (compile_pattern): Don't pass it.
5222
0afb4571
J
52232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5224
5225 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5226 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5227 for ! HAVE_GTK3.
5228 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5229
5230 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5231
5232 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5233 gdk_window_get_screen, gdk_window_get_geometry,
5234 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5235 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5236 (xg_get_pixbuf_from_pixmap): New function.
5237 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5238 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5239 Call xg_get_pixbuf_from_pixmap instead of
5240 gdk_pixbuf_get_from_drawable.
5241 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5242 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5243 (xg_check_special_colors): Use GtkStyleContext and its functions
5244 for HAVE_GTK3.
5245 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5246 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5247 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5248 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5249 Call gtk_widget_get_preferred_size.
0afb4571
J
5250 (xg_frame_resized): gdk_window_get_geometry only takes 5
5251 parameters.
44f230aa
SM
5252 (xg_win_to_widget, xg_event_is_for_menubar):
5253 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5254 (xg_set_widget_bg): New function.
5255 (delete_cb): New function.
895009e1 5256 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5257 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5258 (xg_set_background_color): Call xg_set_widget_bg.
5259 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5260 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5261 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5262 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5263 if ! HAVE_GTK3.
5264 (update_frame_tool_bar): Call gtk_widget_hide.
5265 (xg_initialize): Use GDK_KEY_g.
5266
5267 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5268 if ! HAVE_GTK3
5269 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5270
5271 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5272 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5273 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5274
1c2cc4ef
JB
52752011-03-08 Juanma Barranquero <lekktu@gmail.com>
5276
5277 * w32xfns.c (select_palette): Check success of RealizePalette against
5278 GDI_ERROR, not zero.
5279
33383987 5280See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5281
5282;; Local Variables:
5283;; coding: utf-8
aac0c6e3
MR
5284;; End:
5285
33383987 5286 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5287
5288 This file is part of GNU Emacs.
5289
5290 GNU Emacs is free software: you can redistribute it and/or modify
5291 it under the terms of the GNU General Public License as published by
5292 the Free Software Foundation, either version 3 of the License, or
5293 (at your option) any later version.
5294
5295 GNU Emacs is distributed in the hope that it will be useful,
5296 but WITHOUT ANY WARRANTY; without even the implied warranty of
5297 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5298 GNU General Public License for more details.
5299
5300 You should have received a copy of the GNU General Public License
5301 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.