* lread.c: Make symbols static if they're not exported.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
93ea6e8f
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
1e3890d1
PE
3 * lread.c: Make symbols static if they're not exported.
4 (read_objects, initial_obarray, oblookup_last_bucket_number):
5 Now static.
6 (make_symbol): Remove; unused.
7 * lisp.h (initial_obarray, make_symbol): Remove decls.
8
8a1414fa
PE
9 * keyboard.c: Make symbols static if they're not exported.
10 (single_kboard, recent_keys_index, total_keys, recent_keys):
11 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12 (this_single_command_key_start, echoing, last_auto_save):
13 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
14 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
16 (Vlispy_mouse_stem, double_click_count):
17 Now static.
18 (force_auto_save_soon): Define only if SIGDANGER.
19 (ignore_mouse_drag_p): Now static if
20 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
21 (print_help): Remove; unused.
22 (stop_character, last_timer_event): Mark as externally visible.
23 * keyboard.h (ignore_mouse_drag_p): Declare only if
24 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
25 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
26 * lisp.h (echoing): Remove decl.
27 (force_auto_save_soon): Declare only if SIGDANGER.
28 * xdisp.c (redisplay_window): Simplify code, to make it more
29 obvious that ignore_mouse_drag_p is not accessed if !defined
30 USE_GTK && !defined HAVE_NS.
31
93ea6e8f
PE
32 * intervals.c: Make symbols static if they're not exported.
33 (merge_properties_sticky, merge_interval_right, delete_interval):
34 Now static.
35 * intervals.h (merge_interval_right, delete_interval): Remove decls.
36
b532497d
PE
372011-04-13 Paul Eggert <eggert@cs.ucla.edu>
38
77382fcc
PE
39 * insdel.c: Make symbols static if they're not exported.
40 However, leave prepare_to_modify_buffer alone. It's never
41 called from outside this function, but that appears to be a bug.
42 (combine_after_change_list, combine_after_change_buffer):
4889fc82 43 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
44 (adjust_after_replace_noundo): Remove; unused.
45 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 46 (signal_before_change): Remove decls.
77382fcc 47
9306c32e
PE
48 * indent.c (val_compute_motion, val_vmotion): Now static.
49
cd44d2eb
PE
50 * image.c: Make symbols static if they're not exported.
51 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
52 if USE_GTK.
53 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
54 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
55
ad9a7a06
PE
56 * fringe.c (standard_bitmaps): Now static.
57 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
58
81626931
PE
59 * frame.c: Make symbols static if they're not exported.
60 (x_report_frame_params, make_terminal_frame): Now static.
61 (get_frame_param): Now static, unless HAVE_NS.
62 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
63 (x_get_resource_string): Remove; not used.
64 * frame.h (make_terminal_frame, x_report_frame_params):
65 (x_get_resource_string); Remove decls.
66 (x_fullscreen_adjust): Declare only if WINDOWSNT.
67 * lisp.h (get_frame_param): Declare only if HAVE_NS.
68
239f9db9
PE
69 * font.c, fontset.c: Make symbols static if they're not exported.
70 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
71 (FACE_SUITABLE_FOR_CHAR_P): Use it.
72 * font.c (font_close_object): Now static.
73 * font.h (font_close_object): Remove.
74 * fontset.c (FONTSET_OBJLIST): Remove.
75 (free_realized_fontset) #if-0 the body, which does nothing.
76 (face_suitable_for_char_p): #if-0, as it's never called.
77 * fontset.h (face_suitable_for_char_p): Remove decl.
78 * xfaces.c (face_at_string_position): Use
79 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
80 since 0 is always ASCII.
81
dfcf3579
PE
82 * fns.c (weak_hash_tables): Now static.
83
5045092b
PE
84 * fileio.c: Make symbols static if they're not exported.
85 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
86 (Vwrite_region_annotation_buffers): Now static.
87
57a96f5c
PE
88 * eval.c: Make symbols static if they're not exported.
89 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
90 * lisp.h (backtrace_list): Remove decl.
91
35f08c38
PE
92 * emacs.c: Make symbols static if they're not exported.
93 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
94 (fatal_error_code, fatal_error_signal_hook, standard_args):
95 Now static.
96 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
97 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
98 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
99 * lisp.h (fatal_error_signal_hook): Remove decl.
100 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
101
f44bd759
PE
102 * editfns.c: Move a (normally-unused) function to its only use.
103 * editfns.c, lisp.h (get_operating_system_release): Remove.
104 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
105 worth the hassle of breaking this out.
106
b532497d
PE
107 * xterm.c: Make symbols static if they're not exported.
108 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
109 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
110 (x_destroy_window, x_delete_display):
111 Now static.
112 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
113 (x_mouse_leave): Remove; unused.
114 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
115 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
116 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
117 Remove decls.
118 (x_mouse_leave): Declare only if WINDOWSNT.
119 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
120 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
121 USE_X_TOOLKIT.
122
a25f4dfa
PE
1232011-04-12 Paul Eggert <eggert@cs.ucla.edu>
124
1675728f
PE
125 * ftxfont.c: Make symbols static if they're not exported.
126 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
127 HAVE_FREETYPE.
128 * font.h (ftxfont_driver): Likewise.
129
e4cebfca
PE
130 * xfns.c: Make symbols static if they're not exported.
131 (x_last_font_name, x_display_info_for_name):
132 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
133 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
134 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
135 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
136 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
137 (last_show_tip_args): Now static.
138 (xic_defaut_fontset, xic_create_fontsetname): Define only if
139 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
140 (x_screen_planes): Remove; unused.
141 * dispextern.h (x_screen_planes): Remove decl.
142
5bf46f05
PE
143 * dispnew.c: Make symbols static if they're not exported.
144 * dispextern.h (redraw_garbaged_frames, scrolling):
145 (increment_row_positions): Remove.
146 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
147 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
148 Now static.
149 (redraw_garbaged_frames): Remove; unused.
150
435f4c28
PE
151 * xfaces.c: Make symbols static if they're not exported.
152 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
153 Remove decls.
154 * xterm.h (defined_color): Remove decls.
155 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
156 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
157 (menu_face_changed_default, defined_color, free_realized_face):
158 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
159 (ascii_face_of_lisp_face): Remove; unused.
160
8524aef3
PE
161 * xdisp.c: Make symbols static if they're not exported.
162 * dispextern.h (scratch_glyph_row, window_box_edges):
163 (glyph_to_pixel_coords, set_cursor_from_row):
164 (get_next_display_element, set_iterator_to_next):
165 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
166 (show_mouse_face): Remove decls
167 * frame.h (message_buf_print): Likewise.
168 * lisp.h (pop_message, set_message, check_point_in_composition):
169 Likewise.
170 * xterm.h (set_vertical_scroll_bar): Likewise.
171 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
172 (message_buf_print, scratch_glyph_row, displayed_buffer):
173 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
174 (get_next_display_element, show_mouse_face, window_box_edges):
175 (frame_to_window_pixel_xy, check_point_in_composition):
176 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
177 (glyph_to_pixel_coords): Remove; unused.
178
16390cd2
PE
179 * dired.c (file_name_completion): Now static.
180
181 * dbusbind.c (xd_in_read_queued_messages): Now static.
182
a25f4dfa
PE
183 * lisp.h (circular_list_error, FOREACH): Remove; unused.
184 * data.c (circular_list_error): Remove.
185
16a97296
PE
1862011-04-11 Paul Eggert <eggert@cs.ucla.edu>
187
14a9c8df
PE
188 * commands.h (last_point_position, last_point_position_buffer):
189 (last_point_position_window): Remove decls.
190 * keyboard.c: Make these variables static.
191
74ab6df5
PE
192 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
193 decls.
194 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
195 (iso_code_class, detect_coding, code_convert_region): Now static.
196 (encode_coding_gap): Remove; unused.
197
38dfbee1
PE
198 * chartab.c (chartab_chars, chartab_bits): Now static.
199
a2cb4e63
PE
200 * charset.h (charset_iso_8859_1): Remove decl.
201 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
202 Now static.
203
127198fd
PE
204 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
205 * ccl.c (Vccl_program_table): Now static.
206 (check_ccl_update): Remove; unused.
207
d85b608f
PE
208 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
209 * category.h: ... from here.
210 * category.c (check_category_table, set_category_set): Now static.
211
31cd66f3
PE
212 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
213 * lisp.h: Remove these decls.
214
c358e587
PE
215 * buffer.c (buffer_count): Remove unused var.
216
e78aecca
PE
217 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
218 so that it's not optimized away.
219 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
220 * dispextern.h (bidi_dump_cached_states): Remove, since it's
221 exported only to the debugger.
222
e192d7d3
PE
223 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
224 * atimer.h (run_all_atimers): Removed; not exported.
225
92470028
PE
226 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
227 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
228 was inaccessible from Lisp.
229 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
230 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
231
244ed907
PE
232 alloc.c: Import and export fewer symbols, and remove unused items.
233 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
234 is defined.
235 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
236 it's not optimized away by whole-program optimization.
237 (message_enable_multibyte, free_misc): Remove.
238 (catchlist, handlerlist, mark_backtrace):
239 Declare only if BYTE_MARK_STACK.
240 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
241 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
242 (message_enable_multibyte): Remove decl.
243 (free_misc, interval_free_list, float_block, float_block_index):
244 (n_float_blocks, float_free_list, cons_block, cons_block_index):
245 (cons_free_list, last_marked_index):
246 Now static.
247 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
248 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
249 (mark_backtrace): Define only if BYTE_MARK_STACK.
250 * xdisp.c (message_enable_multibyte): Now static.
251
955cbe7b
PE
252 Declare Lisp_Object Q* variables to be 'static' if not exproted.
253 This makes it easier for human readers (and static analyzers)
254 to see whether these variables are used from other modules.
255 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
256 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
257 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
258 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
259 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
260 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
261 * xmenu.c, xselect.c:
262 Declare Q* vars static if they are not used in other modules.
263 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
264 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
265 Remove decls of unexported vars.
266 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
267
95c82688
PE
268 * lisp.h (DEFINE_FUNC): Make sname 'static'.
269
16a97296
PE
270 Make Emacs functions such as Fatom 'static' by default.
271 This makes it easier for human readers (and static analyzers)
272 to see whether these functions can be called from other modules.
273 DEFUN now defines a static function. To make the function external
274 so that it can be used in other C modules, use the new macro DEFUE.
275 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
276 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
277 static function definition. Use DEFUE if you want an extern one.
278 (DEFUE, INFUN): New macros.
279 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
280 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
281 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
282 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
283 Remove decls, since these functions are now static.
284 (Funintern, Fget_internal_run_time): New decls, since these functions
285 were already external.
95c82688 286
16a97296
PE
287 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
288 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
289 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
290 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
291 * keyboard.c, keymap.c, lread.c:
292 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
293 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
294 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
295 Mark functions with DEFUE instead of DEFUN,
296 if they are used in other modules.
297 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
298 decls for now-static functions.
299 * buffer.h (Fdelete_overlay): Remove decl.
300 * callproc.c (Fgetenv_internal): Mark as internal.
301 * composite.c (Fremove_list_of_text_properties): Remove decl.
302 (Fcomposition_get_gstring): New forward static decl.
303 * composite.h (Fcomposite_get_gstring): Remove decl.
304 * dired.c (Ffile_attributes): New forward static decl.
305 * doc.c (Fdocumntation_property): New forward static decl.
306 * eval.c (Ffetch_bytecode): New forward static decl.
307 (Funintern): Remove extern decl; now in .h file where it belongs.
308 * fileio.c (Fmake_symbolic_link): New forward static decl.
309 * image.c (Finit_image_library): New forward static decl.
310 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
311 * intervals.h (Fprevious_property_change):
312 (Fremove_list_of_text_properties): Remove decls.
313 * keyboard.c (Fthis_command_keys): Remove decl.
314 (Fcommand_execute): New forward static decl.
315 * keymap.c (Flookup_key): New forward static decl.
316 (Fcopy_keymap): Now static.
317 * keymap.h (Flookup_key): Remove decl.
318 * process.c (Fget_process): New forward static decl.
319 (Fprocess_datagram_address): Mark as internal.
320 * syntax.c (Fsyntax_table_p): New forward static decl.
321 (skip_chars): Remove duplicate decl.
322 * textprop.c (Fprevious_property_change): New forward static decl.
323 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
324 Now internal.
325 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
326 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
327
785bbd42
PE
3282011-04-10 Paul Eggert <eggert@cs.ucla.edu>
329
330 * editfns.c (Fformat): Remove unreachable code.
331
4073e537 3322011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 333
b2ded58d
PE
334 Fix more problems found by GCC 4.6.0's static checks.
335
7d66342c
PE
336 * xdisp.c (vmessage): Use a better test for character truncation.
337
bbf47d44
PE
338 * charset.c (load_charset_map): <, not <=, for optimization,
339 and to avoid potential problems with integer overflow.
9248994d 340 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 341 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 342 * editfns.c (Fformat): Likewise.
1e69125e 343 * syntax.c (skip_chars): Likewise.
3befa583 344
e3019616
PE
345 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
346 This also lets GCC 4.6.0 generate slightly better loop code.
347
becfa255
PE
348 * callint.c (Fcall_interactively): <, not <=, for optimization.
349 (Fcall_interactively): Count the number of arguments produced,
350 not the number of arguments given. This is simpler and lets GCC
351 4.6.0 generate slightly better code.
352
dae0cd48
PE
353 * ftfont.c: Distingish more carefully between FcChar8 and char.
354 The previous code passed unsigned char * to a functions like
355 strlen and xstrcasecmp that expect char *, which does not
356 conform to the C standard.
357 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
358 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
359 char * when the C standard requires it.
360
76032d70
PE
361 * keyboard.c (read_char): Remove unused var.
362
eb3f1cc8
PE
363 * eval.c: Port to Windows vsnprintf (Bug#8435).
364 Include <limits.h>.
365 (SIZE_MAX): Define if the headers do not.
366 (verror): Do not give up if vsnprintf returns a negative count.
367 Instead, grow the buffer. This ports to Windows vsnprintf, which
368 does not conform to C99. Problem reported by Eli Zaretskii.
369 Also, simplify the allocation scheme, by avoiding the need for
370 calling realloc, and removing the ALLOCATED variable.
371
70476b54
PE
372 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
373
12020a9e
PE
374 Remove invocations of doprnt, as Emacs now uses vsnprintf.
375 But keep the doprint source code for now, as we might revamp it
376 and use it again (Bug#8435).
ea6c7ae6
PE
377 * lisp.h (doprnt): Remove.
378 * Makefile.in (base_obj): Remove doprnt.o.
379 * deps.mk (doprnt.o): Remove.
380
5fdb398c
PE
381 error: Print 32- and 64-bit integers portably (Bug#8435).
382 Without this change, on typical 64-bit hosts error ("...%d...", N)
383 was used to print both 32- and 64-bit integers N, which relied on
384 undefined behavior.
385 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
386 New macro.
387 * lisp.h (error, verror): Mark as printf-like functions.
388 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
389 Report overflow in size calculations when allocating printf buffer.
390 Do not truncate output string at its first null byte.
391 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
392 Truncate the output at a character boundary, since vsnprintf does not
393 do that.
394 * charset.c (check_iso_charset_parameter): Convert internal
395 character to string before calling 'error', since %c now has the
396 printf meaning.
397 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
398 overflow when computing char to be passed to 'error'. Do not
399 pass Lisp_Object to 'error'; pass the integer instead.
400 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
401 formatted with plain %d.
402
b189fa66
PE
403 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
404
bff87ef0
PE
405 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
406
7e2cac20
PE
407 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
408
ce4d90b5
PE
409 * xterm.c (x_catch_errors): Remove duplicate declaration.
410
266c9547
PE
411 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
412
79c49ad2
PE
413 * xdisp.c, lisp.h (message_nolog): Remove; unused.
414
368f4090
JM
4152011-04-10 Jim Meyering <meyering@redhat.com>
416
417 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
418 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
419 return ssize_t not "int", and use size_t as the buffer length.
420 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
421 * gnutls.h: Update declarations.
422 * process.c (read_process_output): Use ssize_t, to match.
423 (send_process): Likewise.
424
a32d4040
CY
4252011-04-09 Chong Yidong <cyd@stupidchicken.com>
426
427 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
428
8546720e 4292011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 430
8546720e
GM
431 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
432 unsigned char, to match FcChar8 type definition.
aac0c6e3 433
8546720e
GM
434 * xterm.c (handle_one_xevent):
435 * xmenu.c (create_and_show_popup_menu):
436 * xselect.c (x_decline_selection_request)
437 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 438
a53e2e89
EZ
4392011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
440
441 Fix some uses of `int' instead of EMACS_INT.
442 * search.c (string_match_1, fast_string_match)
443 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
444 (scan_buffer, find_next_newline_no_quit)
445 (find_before_next_newline, search_command, Freplace_match)
446 (Fmatch_data): Make some `int' variables be EMACS_INT.
447
448 * xdisp.c (display_count_lines): 3rd argument and return value now
449 EMACS_INT. All callers changed.
450 (pint2hrstr): Last argument is now EMACS_INT.
451
452 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
453 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
454 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
455 (decode_coding_utf_16, decode_coding_emacs_mule)
456 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
457 (decode_coding_ccl, decode_coding_charset)
458 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
459 (decode_coding_iso_2022, decode_coding_emacs_mule)
460 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
461 <char_offset, last_offset>: Declare EMACS_INT.
462 (encode_coding_utf_8, encode_coding_utf_16)
463 (encode_coding_emacs_mule, encode_invocation_designation)
464 (encode_designation_at_bol, encode_coding_iso_2022)
465 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
466 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
467 Declare EMACS_INT.
468 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
469 (encode_invocation_designation): Last argument P_NCHARS is now
470 EMACS_INT.
471 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
472 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
473
474 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
475 All users changed.
476
477 * ccl.c (Fccl_execute_on_string): Declare some variables
478 EMACS_INT.
479
8546720e 4802011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
481
482 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
483
4e19a977
CS
4842011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
485
486 * process.c (Fformat_network_address): Doc fix.
487
87302331
R
4882011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
489
490 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
491
cbb59342
CY
4922011-04-08 Chong Yidong <cyd@stupidchicken.com>
493
494 * keyboard.c (read_char): Call Lisp function help-form-show,
495 instead of using internal_with_output_to_temp_buffer.
496 (Qhelp_form_show): New var.
e0d38eeb 497 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
498
499 * print.c (internal_with_output_to_temp_buffer): Function deleted.
500
501 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
502
e67a13ab
CY
5032011-04-06 Chong Yidong <cyd@stupidchicken.com>
504
505 * process.c (Flist_processes): Removed to Lisp.
506 (list_processes_1): Deleted.
507
973f782d
EZ
5082011-04-06 Eli Zaretskii <eliz@gnu.org>
509
7c106b1e
EZ
510 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
511
973f782d
EZ
512 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
513
41cf7d1a 5142011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 515
ca23cc88
PE
516 Fix more problems found by GCC 4.6.0's static checks.
517
f390e2d5
PE
518 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
519
42eea0d0
PE
520 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
521
b69769da 522 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 523
f9541e84
PE
524 * xdisp.c (vmessage): Mark as a printf-like function.
525
13841b55
PE
526 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
527
c136c10f
PE
528 * sound.c (sound_warning): Don't crash if arg contains a printf format.
529
5e2d4a30
PE
530 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
531 printf-like functions.
532 (tiff_load): Add casts to remove these marks before passing them
533 to system-supplied API.
534
583f48b9
PE
535 * eval.c (Fsignal): Remove excess argument to 'fatal'.
536
b25d760e
PE
537 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
538 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
539 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
540 directly, rather than having caller test rule sign. This avoids
541 some unnecessary tests.
542 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
543 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
544 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 545
bc7b6697 546 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 547 (xfont_open): Avoid unnecessary tests.
bc7b6697 548
27ccc379
PE
549 * composite.c (composition_gstring_put_cache): Use unsigned integer.
550
dcd5c89a
PE
551 * composite.h, composite.c (composition_gstring_put_cache):
552 Use EMACS_INT, not int, for length.
553
b13a45c6
PE
554 * composite.h (COMPOSITION_DECODE_REFS): New macro,
555 breaking out part of COMPOSITION_DECODE_RULE.
556 (COMPOSITION_DECODE_RULE): Use it.
557 * composite.c (get_composition_id): Remove unused local vars,
558 by using the new macro.
559
1e792e4d
PE
560 * textprop.c (set_text_properties_1): Change while to do-while,
561 since the condition is always true at first.
562
dc6c6455 563 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
564 (interval_deletion_adjustment): Return unsigned value.
565 All uses changed.
dc6c6455 566
aba7731a
PE
567 * process.c (list_processes_1, create_pty, read_process_output):
568 (exec_sentinel): Remove vars that were set but not used.
afd4052b 569 (create_pty): Remove unnecessary "volatile"s.
bc57d757 570 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 571 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 572 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 573
fdfc4bf3
PE
574 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
575
fca8fe46 576 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 577 (update_syntax_table): Use unsigned instead of int.
fca8fe46 578
06a0259a 579 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 580 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 581 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 582
e7b9e80f
PE
583 * print.c (print_error_message): Avoid int overflow.
584
56201685
PE
585 * font.c (font_list_entities): Redo for clarity,
586 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
587
78834453 588 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 589 (font_score): Avoid potential overflow in diff calculation.
78834453 590
0bc0b309 591 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 592 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 593
e610eaca
PE
594 * eval.c (funcall_lambda): Rename local to avoid shadowing.
595
b895abce
PE
596 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
597 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
598 can always succeed if overflow has undefined behavior.
599
1f1d9321 600 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 601 (wordify): Omit three unnecessary tests.
1f1d9321 602
c59478bc
PE
603 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
604 All callers changed. This avoids the need for an unused var.
605
79b73827
PE
606 * casefiddle.c (casify_region): Remove var that is set but not used.
607
a4db5dfe
PE
608 * dired.c (file_name_completion): Remove var that is set but not used.
609
43aae36e
PE
610 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
611
2a47c44d 612 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 613 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 614
a37c69bf
PE
615 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
616 Check for integer overflow on size calculations.
617
328ab8e7
PE
618 * buffer.c (Fprevious_overlay_change): Remove var that is set
619 but not used.
620
e5a2a5cb
PE
621 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
622 Remove vars that are set but not used.
8d84a6eb 623 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 624 (timer_check_2): Mark vars as initialized.
e5a2a5cb 625
a60e5f68
PE
626 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
627
f661cb61 628 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 629 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 630
f0397f5a
PE
631 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
632 that are set but not used.
633
8664db06 634 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 635 if XCreateBitmapFromData fails (Bug#8410).
8664db06 636
6abdaa4a
PE
637 * xselect.c (x_get_local_selection, x_handle_property_notify):
638 Remove vars that are set but not used.
639
0ce7538d 640 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 641 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 642
9ae848fc
PE
643 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
644 Remove var that is set but not used.
0b918413
PE
645 (scroll_bar_windows_size): Now size_t, not int.
646 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
647 Check for overflow.
9ae848fc 648
a5a62657
PE
649 * xfaces.c (realize_named_face): Remove vars that are set but not used.
650 (map_tty_color) [!defined MSDOS]: Likewise.
651
5c5cdd39
PE
652 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
653
66ebf983
PE
654 * coding.c: Remove vars that are set but not used.
655 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
656 All callers changed.
657 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
658 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
659 (decode_coding_charset): Remove vars that are set but not used.
660
1be4d761
PE
661 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
662 that is set but not used.
663
47553fa8
PE
664 * print.c (print_object): Remove var that is set but not used.
665
1f7196bf 666 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
667 The gnulib version avoids calling malloc in the usual case,
668 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
669 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
670 * filelock.c (current_lock_owner): Likewise.
671 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
672 * sysdep.c: Include allocator.h, careadlinkat.h.
673 (emacs_no_realloc_allocator): New static constant.
674 (emacs_readlink): New function.
fdb61804
PE
675 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
676 ../lib/careadlinkat.h.
d1fdcab7 677
f84c17c7
SM
6782011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
679
680 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
681 first non-nil return value).
682
ef3862ad
JD
6832011-04-03 Jan Djärv <jan.h.d@swipnet.se>
684
685 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
686 if not defined (Bug#8403).
687
376a7006
JB
6882011-04-02 Juanma Barranquero <lekktu@gmail.com>
689
690 * xdisp.c (display_count_lines): Remove parameter `start',
691 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
692 (get_char_face_and_encoding): Remove parameter `multibyte_p',
693 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
694 (fill_stretch_glyph_string): Remove parameters `row' and `area',
695 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
696 and thereabouts. All callers changed.
697 (get_per_char_metric): Remove parameter `f', unused since
698 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
699
6ca3801d
JM
7002011-04-02 Jim Meyering <meyering@redhat.com>
701
702 do not dereference NULL upon failed strdup
703 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
704 (ns_get_family): Likewise.
705
d8e2b5ba
JB
7062011-04-02 Juanma Barranquero <lekktu@gmail.com>
707
708 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
709
8c74fcbd
JD
7102011-04-02 Jan Djärv <jan.h.d@swipnet.se>
711
712 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
713 later (Bug#8403).
714
7200d79c
SM
7152011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
716
03408648 717 Add lexical binding.
7200d79c 718
03408648
SM
719 * window.c (Ftemp_output_buffer_show): New fun.
720 (Fsave_window_excursion):
721 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
722
723 * lread.c (lisp_file_lexically_bound_p): New function.
724 (Fload): Bind Qlexical_binding.
725 (readevalloop): Remove `evalfun' arg.
726 Bind Qinternal_interpreter_environment.
727 (Feval_buffer): Bind Qlexical_binding.
728 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
729 Mark as dynamic.
730 (syms_of_lread): Declare `lexical-binding'.
731
732 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
733
734 * keyboard.c (eval_dyn): New fun.
735 (menu_item_eval_property): Use it.
ca105506
SM
736
737 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 738
03408648
SM
739 * fns.c (concat, mapcar1): Accept byte-code-functions.
740
741 * eval.c (Fsetq): Handle lexical vars.
742 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
743 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
744 (FletX, Flet): Obey lexical binding.
745 (Fcommandp): Handle closures.
746 (Feval): New `lexical' arg.
747 (eval_sub): New function extracted from Feval. Use it almost
748 everywhere where Feval was used. Look up vars in lexical env.
749 Handle closures.
750 (Ffunctionp): Move from subr.el.
751 (Ffuncall): Handle closures.
752 (apply_lambda): Remove `eval_flags'.
753 (funcall_lambda): Handle closures and new byte-code-functions.
754 (Fspecial_variable_p): New function.
755 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
756 but without exporting it to Lisp.
23aba0ea 757
23aba0ea 758 * doc.c (Fdocumentation, store_function_docstring):
03408648 759 * data.c (Finteractive_form): Handle closures.
23aba0ea 760
03408648
SM
761 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
762 interactive spec.
ba83908c 763
03408648
SM
764 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
765 byte-codes.
766 (exec_byte_code): New function extracted from Fbyte_code to handle new
767 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 768
03408648 769 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 770
03408648 771 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 772
e2abce01
JB
7732011-03-31 Juanma Barranquero <lekktu@gmail.com>
774
775 * xdisp.c (redisplay_internal): Fix prototype.
776
63696a73 7772011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 778
63696a73
EZ
779 * xdisp.c (SCROLL_LIMIT): New macro.
780 (try_scrolling): Use it when setting scroll_limit. Limit
781 scrolling to 100 screen lines.
782 (redisplay_window): Even when falling back on "recentering",
783 position point in the window according to scroll-conservatively,
784 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
785
786 (try_scrolling): When point is above the window, allow searching
787 as far as scroll_max, or one screenful, to compute vertical
788 distance from PT to the scroll margin position. This prevents
789 try_scrolling from unnecessarily failing when
790 scroll-conservatively is set to a value slightly larger than the
791 window height. Clean up the case of PT below the margin at bottom
792 of window: scroll_max can no longer be INT_MAX. When aggressive
793 scrolling is in use, don't let point enter the opposite scroll
794 margin as result of the scroll.
795 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
796 threshold of 100 lines for never-recentering scrolling.
797
e4cc2dfc
JB
7982011-03-31 Juanma Barranquero <lekktu@gmail.com>
799
800 * dispextern.h (move_it_by_lines):
801 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
802 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
803 (message_log_check_duplicate): Remove parameters `prev_bol' and
804 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
805 (redisplay_internal): Remove parameter `preserve_echo_area',
806 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
807
808 * indent.c (Fvertical_motion):
809 * window.c (window_scroll_pixel_based, Frecenter):
810 Don't pass `need_y_p' to `move_it_by_lines'.
811
1c470562
SM
8122011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
813
44f230aa
SM
814 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
815 steal a few bits to be more compact.
816 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
817 Remove unneeded casts.
818
1c470562
SM
819 * bytecode.c (Fbyte_code): CAR and CDR can GC.
820
888adce9
ZK
8212011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
822
823 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
824 binding" message (bug#7967).
825
f838ed7b
PE
8262011-03-30 Paul Eggert <eggert@cs.ucla.edu>
827
77861b95
PE
828 Fix more problems found by GCC 4.6.0's static checks.
829
de6dbc14
PE
830 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
831 Remove unused local var.
832
f838ed7b
PE
833 * editfns.c (Fmessage_box): Remove unused local var.
834
792c7b2b
PE
835 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
836 (note_mode_line_or_margin_highlight, note_mouse_highlight):
837 Omit unused local vars.
c499e557 838 * window.c (shrink_windows): Omit unused local var.
b01a1c29 839 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
840 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
841 Omit unused local var.
842
ba0165e1
PE
843 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
844 Don't assume string length fits in int.
32ad8845 845 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 846 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 847
3c59b4c9
PE
848 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
849 instead of alloca (Bug#8344).
850
a3eed478 851 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 852 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 853
eb4d412d
PE
854 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
855
1658b401
PE
856 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
857 concerns.
858
859 * term.c (produce_glyphless_glyph): Remove unnecessary test.
860
861 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 862
9a2c6e05
PE
863 * keyboard.c (syms_of_keyboard): Use the same style as later
864 in this function when indexing through an array. This also
865 works around GCC bug 48267.
866
03d0a109
PE
867 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
868
44f730c8
PE
869 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
870
fe75f926
PE
871 * chartab.c (sub_char_table_ref_and_range): Redo for slight
872 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
873
ffa8c828
PE
874 * keyboard.c, keyboard.h (num_input_events): Now size_t.
875 This avoids undefined behavior on integer overflow, and is a bit
876 more convenient anyway since it is compared to a size_t variable.
877
c5101a77
PE
878 Variadic C functions now count arguments with size_t, not int.
879 This avoids an unnecessary limitation on 64-bit machines, which
880 caused (substring ...) to crash on large vectors (Bug#8344).
881 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
882 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 883 All variadic functions and their callers changed accordingly.
c5101a77
PE
884 (struct gcpro.nvars): Now size_t, not int. All uses changed.
885 * data.c (arith_driver, float_arith_driver): Likewise.
886 * editfns.c (general_insert_function): Likewise.
887 * eval.c (struct backtrace.nargs, interactive_p)
888 (internal_condition_case_n, run_hook_with_args, apply_lambda)
889 (funcall_lambda, mark_backtrace): Likewise.
890 * fns.c (concat): Likewise.
891 * frame.c (x_set_frame_parameters): Likewise.
892 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
893 0 if not found, not -1. All callers changed.
894
dd3f25f7
PE
895 * alloc.c (garbage_collect): Don't assume stack size fits in int.
896 (stack_copy_size): Now size_t, not int.
897 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
898
461c2ab9
JB
8992011-03-28 Juanma Barranquero <lekktu@gmail.com>
900
901 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
902 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
903 All callers changed.
904
905 * lisp.h (multibyte_char_to_unibyte):
906 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
907 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
908 * character.h (CHAR_TO_BYTE8):
909 * cmds.c (internal_self_insert):
910 * editfns.c (general_insert_function):
911 * keymap.c (push_key_description):
912 * search.c (Freplace_match):
913 * xdisp.c (message_dolog, set_message_1): All callers changed.
914
f6d62986
SM
9152011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
916
917 * keyboard.c (safe_run_hook_funcall): New function.
918 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
919 don't set the hook to nil, but remove the offending function instead.
920 (Qcommand_hook_internal): Remove, unused.
921 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
922 Vcommand_hook_internal.
923
924 * eval.c (enum run_hooks_condition): Remove.
925 (funcall_nil, funcall_not): New functions.
926 (run_hook_with_args): Call each function through a `funcall' argument.
927 Remove `cond' argument, now redundant.
928 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
929 (Frun_hook_with_args_until_failure): Adjust accordingly.
930 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
931
1db5b1ad
JB
9322011-03-28 Juanma Barranquero <lekktu@gmail.com>
933
934 * dispextern.h (string_buffer_position): Remove declaration.
935
936 * print.c (strout): Remove parameter `multibyte', unused since
937 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
938
939 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
940 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
941 All callers changed.
942
943 * w32.c (_wsa_errlist): Use braces for struct initializers.
944
945 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
946 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
947 All callers changed.
948 (string_buffer_position): Likewise. Also, make static (it's never
949 used outside xdisp.c).
950 (cursor_row_p): Remove parameter `w', unused since
951 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
952 (decode_mode_spec): Remove parameter `precision', introduced during
953 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
954 All callers changed.
955
5ffb62aa
JD
9562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
957
958 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
959
461c2ab9 9602011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
961
962 * nsterm.m (ns_menu_bar_is_hidden): New variable.
963 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
964 (ns_update_auto_hide_menu_bar): New functions.
965 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
966 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
967 ns_constrain_all_frames.
968 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
969 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
970
5c380ffb
JD
9712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
972
973 * nsmenu.m (runDialogAt): Remove argument to timer_check.
974
9af30bdf
GM
9752011-03-27 Glenn Morris <rgm@gnu.org>
976
977 * syssignal.h: Replace RETSIGTYPE with void.
978 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
979 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
980 Replace SIGTYPE with void everywhere.
981 * s/usg5-4-common.h (SIGTYPE): Remove definition.
982 * s/template.h (SIGTYPE): Remove commented out definition.
983
e2abce01
JB
9842011-03-26 Eli Zaretskii <eliz@gnu.org>
985
986 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
987 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
988
f868cd8a
JB
9892011-03-26 Juanma Barranquero <lekktu@gmail.com>
990
59eb0929
JB
991 * w32.c (read_unc_volume): Use parameter `henum', instead of
992 global variable `wget_enum_handle'.
993
994 * keymap.c (describe_vector): Remove parameters `indices' and
995 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
996 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
997
f868cd8a
JB
998 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
999
1000 * keyboard.c (timer_check): Remove parameter `do_it_now',
1001 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1002 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1003 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1004
1005 * keyboard.c (read_char):
1006 * w32menu.c (w32_menu_display_help):
1007 * xmenu.c (show_help_event, menu_help_callback):
1008 Adjust calls to `show_help_echo'.
1009
1010 * gtkutil.c (xg_maybe_add_timer):
1011 * keyboard.c (readable_events):
1012 * process.c (wait_reading_process_output):
1013 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1014
1015 * insdel.c (adjust_markers_gap_motion):
1016 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1017 (gap_left, gap_right): Don't call it.
1018
2ecf6fdb
CY
10192011-03-25 Chong Yidong <cyd@stupidchicken.com>
1020
1021 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1022 incurred during fontification.
1023
6b1f9ba4
JB
10242011-03-25 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1027 (DEFVAR_PER_BUFFER): Don't pass it.
1028
1029 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1030 (scrolling_window): Don't pass it.
1031
0f4a96b5
JB
10322011-03-25 Juanma Barranquero <lekktu@gmail.com>
1033
1034 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1035
1036 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1037 and `suffix'.
1038 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1039 of variables specific to SELinux and computation of `encoded_absname'.
1040
1041 * image.c (XPutPixel): Remove unused variable `height'.
1042
1043 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1044
1045 * unexw32.c (get_section_info): Remove unused variable `section'.
1046
1047 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1048 (system_process_attributes): Remove unused variable `sess'.
1049 (sys_read): Remove unused variable `err'.
1050
1051 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1052 (w32_wnd_proc): Remove unused variable `isdead'.
1053 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1054 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1055 (x_create_tip_frame): Remove unused variable `tem'.
1056
1057 * w32inevt.c (w32_console_read_socket):
1058 Remove unused variable `no_events'.
1059
1060 * w32term.c (x_draw_composite_glyph_string_foreground):
1061 Remove unused variable `width'.
1062
1149507c
JB
10632011-03-24 Juanma Barranquero <lekktu@gmail.com>
1064
1065 * w32term.c (x_set_glyph_string_clipping):
1066 Don't pass uninitialized region to CombineRgn.
1067
9c88f339
JB
10682011-03-23 Juanma Barranquero <lekktu@gmail.com>
1069
1070 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1071 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1072 (Fx_close_connection): Remove unused variable `i'.
1073
1074 * w32font.c (w32font_draw): Return number of glyphs.
1075 (w32font_open_internal): Remove unused variable `i'.
1076 (w32font_driver): Add missing initializer.
1077
1078 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1079 (fill_in_menu): Remove unused variable `items_added'.
1080
1081 * w32term.c (last_mouse_press_frame): Remove static global variable.
1082 (w32_clip_to_row): Remove unused variable `f'.
1083 (x_delete_terminal): Remove unused variable `i'.
1084
1085 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1086 (NOTHING): Remove unused static global variable.
1087 (uniscribe_check_otf): Remove unused variable `table'.
1088 (uniscribe_font_driver): Add missing initializers.
1089
dee091a3
JD
10902011-03-23 Julien Danjou <julien@danjou.info>
1091
1092 * term.c (Fsuspend_tty, Fresume_tty):
1093 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1094 * window.c (temp_output_buffer_show):
1095 * insdel.c (signal_before_change):
1096 * frame.c (Fhandle_switch_frame):
1097 * fileio.c (Fdo_auto_save):
1098 * emacs.c (Fkill_emacs):
1099 * editfns.c (save_excursion_restore):
1100 * cmds.c (internal_self_insert):
1101 * callint.c (Fcall_interactively):
1102 * buffer.c (Fkill_all_local_variables):
1103 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1104 Use Frun_hooks.
0f4a96b5 1105 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1106 unconditionnaly since it does the check itself.
1107
2c520ab5 11082011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1109
c9c49752
PE
1110 Fix more problems found by GCC 4.5.2's static checks.
1111
8abc3f12
PE
1112 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1113 the first time through the loop, since we know p0 < p1 then.
1114 This also avoids a gcc -Wstrict-overflow warning.
1115
a2d26660
PE
1116 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1117 leading to a memory leak, possible in functions like
1118 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1119 of objects (Bug#8318).
a2d26660 1120
916c72e9
PE
1121 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1122 that could (at least in theory) be that large.
1123
19ab8a18
PE
1124 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1125 This is less likely to overflow, and avoids undefined behavior if
1126 overflow does occur. All callers changed. Use strtoul to scan
1127 for the unsigned long integer.
b7cbbd6f
PE
1128 (pint2hrstr): Simplify and tune code slightly.
1129 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1130
f0641eff
PE
1131 * scroll.c (do_scrolling): Work around GCC bug 48228.
1132 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1133
7f650bb9
PE
1134 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1135 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1136 (validate_x_resource_name): Simplify count usage.
1137 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1138
37dd57d1
PE
1139 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1140 fail (Bug#8306).
81e56e61 1141
699979fc 1142 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1143
401bf9b4
PE
1144 * process.c (Fmake_network_process): Use socklen_t, not int,
1145 where POSIX says socklen_t is required in portable programs.
1146 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1147 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1148 (Fmake_network_process, server_accept_connection):
1149 (wait_reading_process_output, read_process_output):
1150 Likewise.
1151
b93aacde
PE
1152 * process.c: Rename or move locals to avoid shadowing.
1153 (list_processes_1, Fmake_network_process):
1154 (read_process_output_error_handler, exec_sentinel_error_handler):
1155 Rename or move locals.
4dc343ee 1156 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1157 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1158 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1159 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1160 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1161
af8a867c 1162 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1163 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1164 Include tparam.h instead, since it declares them.
af8a867c
PE
1165 * cm.h (PC): Remove extern decl; tparam.h now does this.
1166 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1167 * terminfo.c: Include tparam.h, to check interfaces.
1168 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1169 (tparam): Adjust signature to match interface in tparam.h;
1170 this removes some undefined behavior. Check that outstring and len
1171 are zero, which they always are with Emacs.
1172 * tparam.h (PC, BC, UP): New extern decls.
1173
0248044d 1174 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1175 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1176
8ff096c1 1177 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1178 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1179 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1180 (ftfont_list): Remove unused local.
49eaafba
PE
1181 (get_adstyle_property, ftfont_pattern_entity):
1182 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1183 Rename locals to avoid shadowing.
8ff096c1 1184
e2be39f6
PE
1185 * xfont.c (xfont_list_family): Mark var as initialized.
1186
c9735e30
PE
1187 * xml.c (make_dom): Now static.
1188
8f5201ae
PE
1189 * composite.c (composition_compute_stop_pos): Rename local to
1190 avoid shadowing.
b246f932
PE
1191 (composition_reseat_it): Remove unused locals.
1192 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1193 (composition_update_it): Mark var as initialized.
11b61122
PE
1194 (find_automatic_composition): Mark vars as initialized,
1195 with a FIXME (Bug#8290).
8f5201ae 1196
760fbc2c
PE
1197 character.h: Rename locals to avoid shadowing.
1198 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1199 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1200 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1201 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1202 to avoid shadowing.
1203
ff08eb85
PE
1204 * textprop.c (property_change_between_p): Remove; unused.
1205
fc7bf025
PE
1206 * intervals.c (interval_start_pos): Now static.
1207
235d7abc
PE
1208 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1209
44f230aa
SM
1210 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1211 Rename locals to avoid shadowing.
3e7d6594 1212
50060332
PE
1213 * sound.c (wav_play, au_play, Fplay_sound_internal):
1214 Fix pointer signedness.
d01f234b 1215 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1216 (wav_play): Initialize a variable to 0, to prevent undefined
1217 behavior (Bug#8278).
50060332 1218
c4fc4e30
PE
1219 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1220
918436ed
PE
1221 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1222
c939f91b
PE
1223 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1224 clobbering (Bug#8298).
b9c7f648
PE
1225 * sysdep.c (sys_subshell): Likewise.
1226 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1227
6bd8c144
PE
1228 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1229 This should get cleaned up, so that child_setup has the
1230 same signature on all platforms.
1231
7710357c 1232 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1233 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1234
c59da222
CY
12352011-03-22 Chong Yidong <cyd@stupidchicken.com>
1236
1237 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1238 not to be necessary, and produces flickering.
1239
66b87493
GM
12402011-03-20 Glenn Morris <rgm@gnu.org>
1241
1242 * config.in: Remove file.
1243
45b6f6d5
JB
12442011-03-20 Juanma Barranquero <lekktu@gmail.com>
1245
1246 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1247 are now in src/globals.h.
1248 (syms_of_minibuf): Remove spurious & from previous change.
1249
3ec03f7e
LL
12502011-03-20 Leo <sdl.web@gmail.com>
1251
1252 * minibuf.c (completing-read-function): New variable.
1253 (completing-read-default): Rename from completing-read.
1254 (completing-read): Call completing-read-function.
1255
b14e3e21
CY
12562011-03-19 Juanma Barranquero <lekktu@gmail.com>
1257
1258 * xfaces.c (Fx_load_color_file):
1259 Read color file from absolute filename (bug#8250).
1260
f2b726e6
JB
12612011-03-19 Juanma Barranquero <lekktu@gmail.com>
1262
1263 * makefile.w32-in: Update dependencies.
1264
09f6ff02
EZ
12652011-03-17 Eli Zaretskii <eliz@gnu.org>
1266
1267 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1268
29a6015a
PE
12692011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1270
a3a6c54e
PE
1271 Fix more problems found by GCC 4.5.2's static checks.
1272
b766f867
PE
1273 * process.c (make_serial_process_unwind, send_process_trap):
1274 (sigchld_handler): Now static.
1275
be02381c
PE
1276 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1277 That way, the code declares only the vars that it needs.
1278 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1279 * s/cygwin.h (PTY_ITERATION): Likewise.
1280 * s/darwin.h (PTY_ITERATION): Likewise.
1281 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1282
57048744
PE
1283 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1284 * process.c (allocate_pty): Don't declare stb unless it's needed.
1285
7914961c 1286 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1287 (CONSTANTLIM): Remove; unused.
1288 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1289 Define only if needed.
7914961c 1290
b3967b18
PE
1291 * unexelf.c (unexec): Name an expression,
1292 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1293 Use a different way to cause a compilation error if anyone uses
1294 n rather than nn, a way that does not involve shadowing.
73366a00 1295 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1296
29a6015a
PE
1297 * deps.mk (unexalpha.o): Remove; unused.
1298
43cfc33e 1299 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1300 * unexec.h: New file.
ce701a33
PE
1301 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1302 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1303 Depend on unexec.h.
1304 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1305 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1306 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1307 Change as necessary to match prototype in unexec.h.
ce701a33 1308
01f44d5a
PE
1309 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1310 shadowing.
4f63c6bb 1311 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1312
a6670b0b
PE
1313 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1314 Rename locals to avoid shadowing.
1315
cef2010d 1316 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1317 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1318
d4d7173a
PE
1319 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1320
f08b802a
PE
1321 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1322 warning when compiling print.c.
1323
3ddb0639
PE
1324 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1325 instead of using an uninitialized var.
5ad03b97 1326 (font_sort_entities): Mark var as initialized.
3ddb0639 1327
170a2692
PE
1328 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1329
e663c700
PE
1330 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1331 pointers to constants.
89bc529a 1332 (font_parse_fcname): Remove unused vars.
7b81e2d0 1333 (font_delete_unmatched): Now static.
ea838e10 1334 (font_get_spec): Remove; unused.
13a547c6
PE
1335 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1336 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1337 Rename or move locals to avoid shadowing.
e663c700 1338
2a80c887 1339 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1340 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1341
1384fa33 1342 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1343 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1344
8b2c52e9
PE
1345 * alloc.c (mark_backtrace): Move decl from here ...
1346 * lisp.h: ... to here, so that it can be checked.
1347
475545b5 1348 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1349 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1350 (lisp_indirect_variable): Name an expression,
1351 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1352 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1353
b1349114 1354 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1355 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1356 Use const pointer when appropriate.
b1349114 1357
a2928364
PE
1358 * lisp.h (get_system_name, get_operating_system_release):
1359 Move decls here, to check interfaces.
1360 * process.c (get_operating_system_release): Move decl to lisp.h.
1361 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1362 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1363 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1364 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1365 (Fformat_time_string, Fencode_time, Finsert_char):
1366 (Ftranslate_region_internal, Fformat):
1367 Rename or remove local vars to avoid shadowing.
9710023e 1368 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1369
a415e694
PE
1370 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1371 avoid shadowing.
1372
8ef4622d
PE
1373 * lisp.h (eassert): Check that the argument compiles, even if
1374 ENABLE_CHECKING is not defined.
1375
946f9a5b
PE
1376 * data.c (Findirect_variable): Name an expression, to avoid
1377 gcc -Wbad-function-cast warning.
112396d6 1378 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1379 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1380 (Fmake_variable_buffer_local, Fmake_local_variable):
1381 Mark variables as initialized.
52746918 1382 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1383
e5aab7e7 1384 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1385 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1386 Rename locals to avoid shadowing.
dff45157
PE
1387 (mark_stack): Move local variables into the #ifdef region where
1388 they're used.
7bc26fdb
PE
1389 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1390 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1391 needed otherwise.
1392 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1393 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1394 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1395
e5aab7e7
PE
1396 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1397 avoids undefined behavior in theory.
1398
4da60324
PE
1399 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1400
88043301
PE
1401 Use functions, not macros, for up- and down-casing (Bug#8254).
1402 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1403 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1404 to use the following functions instead of these macros.
1405 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1406 EMACS_INT, since callers assume the returned value fits in int.
1407 (upcase1): Likewise, for UPCASE_TABLE.
1408 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1409 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1410 the race-condition problem in the old DOWNCASE.
88043301 1411
19ed5445
PE
1412 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1413 Rename locals to avoid shadowing.
1414 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1415 (regex_compile, re_search_2, re_match_2_internal):
1416 Remove unused local vars.
952db0d7
PE
1417 (FREE_VAR): Rewrite so as not to use empty "else",
1418 which gcc can warn about.
da053e48 1419 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1420 (RETALLOC_IF): Define only if needed.
1421 (WORDCHAR_P): Likewise. This one is never needed, but is used
1422 only in a comment talking about a compiler bug, so put inside
1423 the #if 0 of that comment.
1424 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1425 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1426 Remove; unused.
19ed5445 1427
1f3561e4 1428 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1429 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1430 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1431
ded6f8f7
PE
1432 * search.c (simple_search): Remove unused var.
1433
dbd37a95
PE
1434 * dired.c (compile_pattern): Move decl from here ...
1435 * lisp.h: ... to here, so that it can be checked.
1436 (struct re_registers): New forward decl.
1437
7e47afad
PE
1438 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1439
85f24f61
PE
1440 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1441 All uses changed.
1442 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1443 Rename locals to avoid shadowing.
5671df8f 1444 (Fvertical_motion): Mark locals as initialized.
85f24f61 1445
181aa2be 1446 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1447 (casify_region): Mark local as initialized.
181aa2be 1448
930d429c
PE
1449 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1450
7082eac6
PE
1451 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1452 New macros, so that the caller can use some names other than
1453 gcpro1, gcpro2, etc.
1454 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1455 of the new macros.
1456 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1457 argument, for consistency with GCPRO2_VAR, etc: it is now the
1458 prefix of the variable, not the variable itself. All uses
1459 changed.
38b2c076
PE
1460 * dired.c (directory_files_internal, file_name_completion):
1461 Rename locals to avoid shadowing.
1462
15206ed9
PE
1463 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1464 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1465 dired.c's scmp function, had undefined behavior.
1466 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1467 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1468 * buffer.h: ... to here, because these macros use current_buffer,
1469 and the new implementation with inline functions needs to have
1470 current_buffer in scope now, rather than later when the macros
1471 are used.
1472 (downcase, upcase1): New static inline functions.
1473 (DOWNCASE, UPCASE1): Reimplement using these functions.
1474 This avoids undefined behavior in expressions like
1475 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1476 from race conditions in accessing the global variables
1477 case_temp1 and case_temp2.
1478 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1479 * lisp.h (case_temp1, case_temp2): Remove their decls.
1480 * character.h (ASCII_CHAR_P): Move from here ...
1481 * lisp.h: ... to here, so that the inline functions mentioned
1482 above can use them.
1483
4a6bea26
PE
1484 * dired.c (directory_files_internal_unwind): Now static.
1485
f14b7e14
PE
1486 * fileio.c (file_name_as_directory, directory_file_name):
1487 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1488 Now static.
2893f146
PE
1489 (file_name_as_directory): Use const pointers when appropriate.
1490 (Fexpand_file_name): Likewise. In particular, newdir might
1491 point at constant storage, so make it a const pointer.
fd4ead52 1492 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1493 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1494 signedness issues.
f839df0c
PE
1495 (Fset_file_times, Finsert_file_contents, auto_save_error):
1496 Rename locals to avoid shadowing.
f14b7e14 1497
5716756e 1498 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1499 (Ftry_completion, Fall_completions): Rename or remove locals
1500 to avoid shadowing.
5716756e 1501
b4c3046a
PE
1502 * marker.c (bytepos_to_charpos): Remove; unused.
1503
b45db522
PE
1504 * lisp.h (verify_bytepos, count_markers): New decls,
1505 so that gcc does not warn that these functions aren't declared.
1506
85876d07
PE
1507 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1508 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1509 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1510 (copy_text): Remove unused local var.
85876d07 1511
03d78a21 1512 * filelock.c (within_one_second): Now static.
b3dd38ab 1513 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1514
5df8f01b
PE
1515 * buffer.c (fix_overlays_before): Mark locals as initialized.
1516 (fix_start_end_in_overlays): Likewise. This function should be
1517 simplified by using pointers-to-pointers, but that's a different
1518 matter.
b1d876f1 1519 (switch_to_buffer_1): Now static.
8f54f30a
PE
1520 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1521 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1522
a70072c9 1523 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1524 Fix pointer signedness issue.
edced198
PE
1525 (sys_subshell): Mark local as volatile if checking for lint,
1526 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1527 (MAXPATHLEN): Define only if needed.
a70072c9 1528
a0977c44
PE
1529 * process.c (serial_open, serial_configure): Move decls from here ...
1530 * systty.h: ... to here, so that they can be checked.
1531
a884fdcc
PE
1532 * fns.c (get_random, seed_random): Move extern decls from here ...
1533 * lisp.h: ... to here, so that they can be checked.
1534
604efe86 1535 * sysdep.c (reset_io): Now static.
b8950c94 1536 (wait_for_termination_signal): Remove; unused.
604efe86 1537
38fc62d9
PE
1538 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1539 (copy_keymap_item, append_key, push_text_char_description):
1540 Now static.
1004a21a 1541 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1542 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1543 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1544 (describe_map_tree):
1545 Rename locals to avoid shadowing.
38fc62d9 1546
2f2650da
PE
1547 * keyboard.c: Declare functions static if they are not used elsewhere.
1548 (echo_char, echo_dash, cmd_error, top_level_2):
1549 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1550 (read_char, kbd_buffer_get_event, make_lispy_position):
1551 (make_lispy_event, make_lispy_movement, apply_modifiers):
1552 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1553 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1554 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1555 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1556 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1557
a053e86c 1558 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1559 (mark_kboards): Move decl here ...
1560 * alloc.c (mark_kboards): ... from here.
a053e86c 1561
4752793e
PE
1562 * lisp.h (force_auto_save_soon): New decl.
1563
74f10ca7 1564 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1565 (DEFINE_DUMMY_FUNCTION): New macro.
1566 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1567 Use it.
c03cd23f
PE
1568 (main): Add casts to avoid warnings
1569 if GCC considers string literals to be constants.
74f10ca7 1570
022e70d4
PE
1571 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1572
59d6fe83
PE
1573 * dbusbind.c: Pointer signedness fixes.
1574 (xd_signature, xd_append_arg, xd_initialize):
1575 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1576 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1577 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1578 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1579
78320123
PE
1580 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1581 if GCC considers string literals to be constants.
49cebcca 1582 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1583
35ac2a97
SM
15842011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1585
fb103ca9
SM
1586 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1587 (print_preprocess, print_object): New macro to fix last change.
1588
35ac2a97
SM
1589 * print.c (print_preprocess): Don't forget font objects.
1590
62973b41
JB
15912011-03-16 Juanma Barranquero <lekktu@gmail.com>
1592
1593 * emacs.c (USAGE3): Doc fixes.
1594
0e48bb22
AS
15952011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1596
1597 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1598 structure.
1599
7684e57b
JB
16002011-03-14 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * lisp.h (VWindow_system, Qfile_name_history):
1603 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1604 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1605 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1606
1607 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1608 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1609
1610 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1611 * w32console.c (detect_input_pending, read_input_pending)
1612 (encode_terminal_code):
1613 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1614 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1615 (w32_system_caret_y, Qfile_name_history):
1616 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1617 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1618 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1619 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1620 * w32proc.c (Qlocal, report_file_error):
1621 * w32term.c (Vwindow_system, updating_frame):
1622 * w32uniscribe.c (initialized, uniscribe_font_driver):
1623 Remove unneeded extern declarations.
1624
2aa46d6c
CY
16252011-03-14 Chong Yidong <cyd@stupidchicken.com>
1626
c96bbc66 1627 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1628
cffc6f3b
CY
16292011-03-13 Chong Yidong <cyd@stupidchicken.com>
1630
1631 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1632 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1633 These macros can no longer be used for assignment.
1634
44f230aa
SM
1635 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1636 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1637 (record_buffer_markers, fetch_buffer_markers): New functions for
1638 recording and fetching special buffer markers.
1639 (set_buffer_internal_1, set_buffer_temp): Use them.
1640
1641 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1642
1643 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1644
1645 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1646 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1647
1648 * xdisp.c (hscroll_window_tree):
1649 (reconsider_clip_changes): Use PT instead of BUF_PT.
1650
d251f04b
EZ
16512011-03-13 Eli Zaretskii <eliz@gnu.org>
1652
1653 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1654 $(EMACS_ROOT)/lib/intprops.h.
1655
f0c77cd1
PE
16562011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1657
3eca4629
PE
1658 Fix more problems found by GCC 4.5.2's static checks.
1659
7c86ee98
PE
1660 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1661 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1662 (xg_free_frame_widgets): Make it clear that a local variable is
1663 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1664 (gdk_window_get_screen): Make it clear that this macro is needed
1665 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1666 (int_gtk_range_get_value): New function, which avoids a diagnostic
1667 from gcc -Wbad-function-cast.
1668 (xg_set_toolkit_scroll_bar_thumb): Use it.
1669 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1670 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1671 (get_utf8_string, xg_get_file_with_chooser):
1672 Rename locals to avoid shadowing.
1673 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1674
41729b81
PE
1675 * xgselect.c (xg_select): Remove unused var.
1676
f0c77cd1
PE
1677 * image.c (four_corners_best): Mark locals as initialized.
1678 (gif_load): Initialize transparent_p to zero (Bug#8238).
1679 Mark another local as initialized.
ec6cf4c6 1680 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1681
ce0ad53d 1682 * image.c (clear_image_cache): Now static.
d5d5a617 1683 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1684 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1685 (x_edge_detection): Remove unnecessary cast that
1686 gcc -Wbad-function-cast diagnoses.
2037898d 1687 (gif_load): Fix pointer signedness.
6ae141d6
PE
1688 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1689 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1690
33383987 16912011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1692
d32df629
PE
1693 Improve quality of tests for time stamp overflow.
1694 For example, without this patch (encode-time 0 0 0 1 1
1695 1152921504606846976) returns the obviously-bogus value (-948597
1696 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1697 reports time overflow. See
1698 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1699 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1700 * editfns.c: Include limits.h and intprops.h.
1701 (TIME_T_MIN, TIME_T_MAX): New macros.
1702 (time_overflow): Move earlier, to before first use.
1703 (hi_time, lo_time): New functions, for an accurate test for
1704 out-of-range times.
1705 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1706 (Fget_internal_run_time): Don't assume time_t fits in int.
1707 (make_time): Use list2 instead of Fcons twice.
1708 (Fdecode_time): More accurate test for out-of-range times.
1709 (check_tm_member): New function.
1710 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1711 (lisp_time_argument): Don't rely on undefined left-shift and
1712 right-shift behavior when checking for time stamp overflow.
8be6f318 1713
fe31d94c
PE
1714 * editfns.c (time_overflow): New function, refactoring common code.
1715 (Fformat_time_string, Fdecode_time, Fencode_time):
1716 (Fcurrent_time_string): Use it.
1717
8be6f318
PE
1718 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1719 * dired.c (make_time): Move to ...
1720 * editfns.c (make_time): ... here.
1721 * systime.h: Note the move.
1722
09d9db2c 17232011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1724
126bc0dc
YM
1725 * fringe.c (update_window_fringes): Remove unused variables.
1726
c47cbdfd
YM
1727 * unexmacosx.c (copy_data_segment): Also copy __got section.
1728 (Bug#8223)
1729
7ac80be9
EZ
17302011-03-12 Eli Zaretskii <eliz@gnu.org>
1731
c96bbc66 1732 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1733 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1734 Constify `char *' arguments and their references according to
1735 prototypes in tparam.h.
1736
ecb0f94d 1737 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1738
7ac80be9
EZ
1739 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1740 Adapt all references accordingly.
1741
1742 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1743
ef1fd07e
TT
17442011-03-11 Tom Tromey <tromey@redhat.com>
1745
1746 * buffer.c (syms_of_buffer): Remove obsolete comment.
1747
7ef4b50c
EZ
17482011-03-11 Eli Zaretskii <eliz@gnu.org>
1749
1750 * termhooks.h (encode_terminal_code): Declare prototype.
1751
1752 * msdos.c (encode_terminal_code): Don't declare prototype.
1753
1754 * term.c (encode_terminal_code): Now external again, used by
1755 w32console.c and msdos.c.
1756
44f230aa
SM
1757 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1758 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1759
4b1ec863 17602011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1761
1714f52b 1762 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1763
4b1ec863
PE
1764 * fringe.c (update_window_fringes): Mark locals as initialized
1765 (Bug#8227).
1766 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1767
524c7aa6
PE
1768 * alloc.c (mark_fringe_data): Move decl from here ...
1769 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1770 to check its interface.
1771 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1772
a5c0af81 1773 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1774 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1775 (fontset_font): Mark local as initialized.
a9a06e0b 1776 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1777
b4716021
PE
1778 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1779
811e9bac 1780 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1781 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1782 (x_own_selection, Fx_disown_selection_internal): Rename locals
1783 to avoid shadowing.
1784 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1785
7e3ab302
PE
1786 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1787 so that the caller can use some name other than gcpro1.
1788 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1789 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1790 (Fx_backspace_delete_keys_p):
1791 Use them to avoid shadowing, and rename vars to avoid shadowing.
1792 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1793 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1794 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1795 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1796 Remove unused locals.
7e3ab302
PE
1797 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1798 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1799 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1800 macros.
f78faa98 1801
e2b13473
PE
1802 * xterm.h (x_mouse_leave): New decl.
1803
77f23912
PE
1804 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1805 Remove unused functions.
cdf4ba58
PE
1806 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1807 (x_calc_absolute_position): Now static.
7411c686 1808 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1809 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1810 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1811 unless they are used.
38d0b34a
PE
1812 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1813 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1814 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1815 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1816 (x_error_catcher, x_connection_closed, x_error_handler):
1817 (x_error_quitter, xembed_send_message, x_iconify_frame):
1818 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1819 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1820 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1821
44f230aa
SM
1822 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1823 Rename or move locals to avoid shadowing.
6b463e58 1824 (tty_defined_color, merge_face_heights): Now static.
5967d051 1825 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1826 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1827 does not deduce is never used uninitialized.
73719eba
PE
1828 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1829 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1830
426994c3 1831 * terminal.c (store_terminal_param): Now static.
5489860b 1832
032f1620 1833 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1834 (set_frame_menubar): Remove unused local.
d4323972 1835 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1836 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1837 since they might point to immutable storage.
281585b0
PE
1838 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1839 since it's unused otherwise.
032f1620 1840
367c19e5 1841 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1842 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1843 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1844 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1845 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1846 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1847 does not deduce are never used uninitialized.
70739cbe 1848
07b48fa9
PE
1849 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1850
8868a238 1851 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1852 * window.c (window_loop, size_window):
1853 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1854
7e5cf297 1855 * window.c (display_buffer): Now static.
d6550a9f
PE
1856 (size_window): Mark variables that gcc -Wuninitialized
1857 does not deduce are never used uninitialized.
a586633d
PE
1858 * window.h (check_all_windows): New decl, to forestall
1859 gcc -Wmissing-prototypes diagnostic.
5b555da1 1860 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1861
f6095868
PE
1862 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1863 shadowing.
1864 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1865 Include <limits.h>.
1866 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1867 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1868 (load_charset_map): Mark variables that gcc -Wuninitialized
1869 does not deduce are never used uninitialized.
53df7c11 1870 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1871
f38b440c
PE
1872 * coding.c (coding_set_source, coding_set_destination):
1873 Use "else { /* comment */ }" rather than "else /* comment */;"
1874 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1875 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1876 a block, when the outer 'i' will do.
1877 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1878 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1879 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1880 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1881 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1882 Rename locals to avoid shadowing.
1883 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1884 * coding.c (emacs_mule_char, encode_invocation_designation):
1885 Now static, since they're not used elsewhere.
413bb2db 1886 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1887 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1888 (decode_coding_emacs_mule): Mark variables that gcc
1889 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1890 (detect_coding_iso_2022): Initialize a local variable that might
1891 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1892 this initialization is needed. (Bug#8211)
5f58e762
PE
1893 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1894 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1895 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1896 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1897 Remove unused macros.
f38b440c 1898
232b38b9 1899 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1900 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1901 * character.c (string_count_byte8): Likewise.
232b38b9 1902
fb90da1b
PE
1903 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1904 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1905
fb93dbc2
PE
1906 * chartab.c (copy_sub_char_table): Now static, since it's not used
1907 elsewhere.
5c156ace
PE
1908 (sub_char_table_ref_and_range, char_table_ref_and_range):
1909 Rename locals to avoid shadowing.
bbcd0949 1910 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1911
7d3b3862 1912 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1913 (BIDI_BOB): Remove unused macro.
7d3b3862 1914
6be7d3da
PE
1915 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1916 deduce are never used uninitialized.
c2ed9c8b 1917 * term.c (encode_terminal_code): Likewise.
6be7d3da 1918
75f8807f 1919 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1920
50938595
PE
1921 * tparam.h: New file.
1922 * term.c, tparam.h: Include it.
1923 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1924 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1925 Move these decls to tparam.h, and make them agree with what
1926 is actually in tparam.c. The previous trick of using incompatible
1927 decls in different modules does not conform to the C standard.
1928 All callers of tparam changed to use tparam's actual API.
1929 * tparam.c (tparam1, tparam, tgoto):
1930 Use const pointers where appropriate.
1931
fbceeba2
PE
1932 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1933 * cm.h (struct cm): Likewise.
1934 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1935 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1936 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1937 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1938 (turn_on_face, init_tty): Likewise.
1939 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1940
7f3f1250
PE
1941 * term.c (term_mouse_position): Rename local to avoid shadowing.
1942
e6ca6543
PE
1943 * alloc.c (mark_ttys): Move decl from here ...
1944 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1945
c40f8d15
AS
19462011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1947
1948 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1949
cfe0661d
JB
19502011-03-09 Juanma Barranquero <lekktu@gmail.com>
1951
1952 * search.c (compile_pattern_1): Remove argument regp, unused since
1953 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1954 (compile_pattern): Don't pass it.
1955
0afb4571
J
19562011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1957
1958 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1959 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1960 for ! HAVE_GTK3.
1961 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1962
1963 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1964
1965 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1966 gdk_window_get_screen, gdk_window_get_geometry,
1967 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1968 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1969 (xg_get_pixbuf_from_pixmap): New function.
1970 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1971 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1972 Call xg_get_pixbuf_from_pixmap instead of
1973 gdk_pixbuf_get_from_drawable.
1974 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1975 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1976 (xg_check_special_colors): Use GtkStyleContext and its functions
1977 for HAVE_GTK3.
1978 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1979 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1980 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1981 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1982 Call gtk_widget_get_preferred_size.
0afb4571
J
1983 (xg_frame_resized): gdk_window_get_geometry only takes 5
1984 parameters.
44f230aa
SM
1985 (xg_win_to_widget, xg_event_is_for_menubar):
1986 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1987 (xg_set_widget_bg): New function.
1988 (delete_cb): New function.
1989 (xg_create_frame_widgets): connect delete-event to delete_cb.
1990 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1991 (xg_set_background_color): Call xg_set_widget_bg.
1992 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1993 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1994 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1995 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1996 if ! HAVE_GTK3.
1997 (update_frame_tool_bar): Call gtk_widget_hide.
1998 (xg_initialize): Use GDK_KEY_g.
1999
2000 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2001 if ! HAVE_GTK3
2002 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2003
2004 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2005 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2006 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2007
1c2cc4ef
JB
20082011-03-08 Juanma Barranquero <lekktu@gmail.com>
2009
2010 * w32xfns.c (select_palette): Check success of RealizePalette against
2011 GDI_ERROR, not zero.
2012
33383987 2013See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2014
2015;; Local Variables:
2016;; coding: utf-8
aac0c6e3
MR
2017;; End:
2018
33383987 2019 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2020
2021 This file is part of GNU Emacs.
2022
2023 GNU Emacs is free software: you can redistribute it and/or modify
2024 it under the terms of the GNU General Public License as published by
2025 the Free Software Foundation, either version 3 of the License, or
2026 (at your option) any later version.
2027
2028 GNU Emacs is distributed in the hope that it will be useful,
2029 but WITHOUT ANY WARRANTY; without even the implied warranty of
2030 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2031 GNU General Public License for more details.
2032
2033 You should have received a copy of the GNU General Public License
2034 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.