* coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
[bpt/emacs.git] / src / ChangeLog
CommitLineData
34348bd4
AS
12012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2
3 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
4 of Fcar/Fcdr if possible.
5 * font.c (check_otf_features): Likewise.
6 * fontset.c (Fnew_fontset): Likewise.
7 * gnutls.c (Fgnutls_boot): Likewise.
8 * minibuf.c (read_minibuf): Likewise.
9 * msdos.c (IT_set_frame_parameters): Likewise.
10 * xmenu.c (Fx_popup_dialog): Likewise.
11 * w32menu.c (Fx_popup_dialog): Likewise.
12
c8add24e
GM
132012-07-11 Glenn Morris <rgm@gnu.org>
14
172bedef
GM
15 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
16 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
17 Move CLASH_DETECTION to configure.
18
249685df
GM
19 * s/gnu.h: Remove file, which is now empty.
20
c8add24e
GM
21 * s/gnu.h, s/gnu-linux.h:
22 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
23
b41253a3
JW
242012-07-11 John Wiegley <johnw@newartisans.com>
25
26 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
27 function attribute, so we only use it if it exists in the
28 compiler.
29
d923b542
DA
302012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
31
32 Avoid call to strlen in fast_c_string_match_ignore_case.
33 * search.c (fast_c_string_match_ignore_case): Change to use
34 length argument. Adjust users accordingly.
35 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
36
5ebbef1d
PE
372012-07-11 Paul Eggert <eggert@cs.ucla.edu>
38
bb352260
PE
39 Assume mkdir, rmdir.
40 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
41 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
42
57054ddd
PE
43 Assume rename.
44 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
45
b747d3f7
PE
46 Assume perror.
47 * s/hpux10-20.h (HAVE_PERROR): Remove.
48 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
49 Remove dummy definition, as this problem was obsolete long ago.
50
5ebbef1d
PE
51 Assume strerror.
52 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
53
984e7f30
DA
542012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
55
56 Avoid calls to strlen in font processing functions.
57 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 58 (font_open_by_name): Change to use length argument. Adjust
984e7f30 59 users accordingly.
d923b542
DA
60 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
61 Adjust prototypes.
62 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
63 Change to return ptrdiff_t.
984e7f30
DA
64 (xfont_list_pattern, xfont_match): Use length returned by
65 xfont_decode_coding_xlfd.
66 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
67
20e94fdd
GM
682012-07-11 Glenn Morris <rgm@gnu.org>
69
9d596af3
GM
70 * s/darwin.h, s/freebsd.h, s/netbsd.h:
71 Move DONT_REOPEN_PTY to configure.
72
20e94fdd
GM
73 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
74 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
75
e99a530f
PE
762012-07-10 Paul Eggert <eggert@cs.ucla.edu>
77
22ffb973
PE
78 Remove "#define unix" that is no longer needed (Bug#11905).
79 * s/aix4-2.h (unix): Remove; no longer needed.
80
e9a9ae03
PE
81 EMACS_TIME simplification (Bug#11875).
82 This replaces macros (which typically do not work in GDB)
83 with functions, typedefs and enums, making the code easier to debug.
84 The functional style also makes code easier to read and maintain.
85 * systime.h: Include <sys/time.h> on all hosts, not just if
86 WINDOWSNT, since 'struct timeval' is needed in general.
87 (EMACS_TIME): Now a typedef, not a macro.
88 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
89 not macros.
90 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
91 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
92 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
93 (EMACS_TIME_LE): Now functions, not macros.
94 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
95 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
96 which are not functions. All uses rewritten to use:
97 (make_emacs_time): New function.
98 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
99 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
100 not functions. All uses rewritten to use the following, respectively:
101 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
102 (add_emacs_time, sub_emacs_time): New functions.
103 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
104 * fileio.c (Fcopy_file):
105 * xterm.c (XTflash): Get the current time closer to when it's used.
106 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
107
ffacb126
PE
108 * bytecode.c (targets): Suppress -Woverride-init warnings.
109
e99a530f
PE
110 Simplify by avoiding confusing use of strncpy etc.
111 * doc.c (Fsnarf_documentation):
112 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
113 * frame.c (Fmake_terminal_frame):
114 * gtkutil.c (get_utf8_string):
115 * lread.c (openp):
116 * nsmenu.m (ns_update_menubar):
117 * regex.c (regerror):
118 Prefer memcpy to strncpy and strncat when either will do.
119 * fileio.c (Fsubstitute_in_file_name):
120 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
121 (menu_separator_name_p):
122 * nsmenu.m (ns_update_menubar):
123 Prefer memcmp to strncmp when either will do.
124 * nsterm.m: Include <ftoastr.h>.
125 (ns_get_color):
126 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
127 Prefer snprintf to strncpy.
128 * nsterm.m (ns_term_init):
129 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
130 * nsterm.m (ns_term_init):
131 Avoid the need for strncpy, by using build_string or
132 make_unibyte_string directly. Use dtoastr, not snprintf.
133 * process.c (Fmake_network_process): Diagnose service names that
134 are too long, rather than silently truncating them or creating
135 non-null-terminated names.
136 (Fnetwork_interface_info): Likewise, for interface names.
137 * sysdep.c (system_process_attributes) [GNU_LINUX]:
138 Prefer sprintf to strncat.
139 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
140 Prefer vsnprintf to vsprintf + strncpy.
141
c59592b3
GM
1422012-07-10 Glenn Morris <rgm@gnu.org>
143
144 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
145 Clarify fallback case.
146
7d7bbefd
DA
1472012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
148
149 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
150 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
151 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 152 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
153 where argument type is known to be a Lisp_Cons.
154
3a4c8000
TT
1552012-07-10 Tom Tromey <tromey@redhat.com>
156
157 * bytecode.c (BYTE_CODE_THREADED): New macro.
158 (BYTE_CODES): New macro. Replaces all old byte-code defines.
159 (enum byte_code_op): New type.
160 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
161 (exec_byte_code): Use them. Use token threading when applicable.
162
2a0213a6
DA
1632012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
164
165 Optimize pure C strings initialization.
166 * lisp.h (make_pure_string): Fix prototype.
167 (build_pure_c_string): New function, defined as static inline. This
168 provides a better opportunity to optimize away calls to strlen when
169 the function is called with compile-time constant argument.
170 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
171 argument, adjust users accordingly. Use build_pure_c_string where
172 appropriate.
173 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
174 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
175 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
176
cb1caeaf
DA
1772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
178
179 Avoid calls to strlen in miscellaneous functions.
180 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
181 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
182 * lread.c (openp): Likewise.
183
c293e30c
DA
1842012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
185
186 Avoid calls to strlen in path processing functions.
187 * fileio.c (file_name_as_directory): Add comment. Change to add
188 srclen argument and return the length of result. Adjust users
189 accordingly.
190 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 191 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
192 users accordingly.
193 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
194
9e059e3f
GM
1952012-07-10 Glenn Morris <rgm@gnu.org>
196
d02eb359
GM
197 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
198 Move PENDING_OUTPUT_COUNT definition to configure.
199
882cf227
GM
200 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
201 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
202 * s/gnu.h (DATA_START): Move definitions to configure.
203
af6e839f
GM
204 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
205 We include usg5-4-common.h, which defines them both.
206
40289a12
GM
207 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
208 O_RDONLY already includes it).
209
9e059e3f
GM
210 Stop ns builds setting the EMACSLOADPATH environment variable.
211 * nsterm.m (ns_load_path): Rename from ns_init_paths.
212 Now it does not set EMACSLOADPATH, just returns the load-path string.
213 * nsterm.h: Update accordingly.
214 * lread.c [HAVE_NS]: Include nsterm.h.
215 (init_lread) [HAVE_NS]: Use ns_load_path.
216 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
217
7c4e8ec0
GM
2182012-07-09 Glenn Morris <rgm@gnu.org>
219
d4f600ff
GM
220 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
221 since the included bsd-common.h does so.
222
cbb31951
GM
223 Stop ns builds setting the EMACSPATH environment variable.
224 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
225 (ns_init_paths): Do not set EMACSPATH.
226 * nsterm.h (ns_exec_path): Add it.
227 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
228 Use ns_exec_path.
229
7c4e8ec0
GM
230 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
231
26bccfae
PE
2322012-07-09 Paul Eggert <eggert@cs.ucla.edu>
233
a0bee46f
PE
234 * process.c (wait_reading_process_output): 'waitchannels' was unset
235 when read_kbd || !NILP (wait_for_cell); fix this.
236
5994c183
PE
237 Add GCC-style 'const' attribute to functions that can use it.
238 * character.h (char_resolve_modifier_mask):
239 * keyboard.h (make_ctrl_char):
240 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
241 (init_character_once, next_almost_prime, init_fns, init_image)
242 (flush_pending_output, init_sound):
243 * mem-limits.h (start_of_data):
244 * menu.h (finish_menu_items):
245 Add ATTRIBUTE_CONST.
246 * emacs.c (DEFINE_DUMMY_FUNCTION):
247 Declare the dummy function with ATTRIBUTE_CONST.
248 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
249 Add decls with ATTRIBUTE_CONST.
250
26bccfae
PE
251 Minor improvements to make_formatted_string.
252 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
253 where int is good enough, as vsprintf returns an int.
254 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
255
a8290ec3
DA
2562012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
257
258 Use make_formatted_string to avoid double length calculation.
259 * lisp.h (make_formatted_string): New prototype.
260 * alloc.c (make_formatted_string): New function.
261 * buffer.c (Fgenerate_new_buffer_name): Use it.
262 * dbus.c (syms_of_dbusbind): Likewise.
263 * editfns.c (Fcurrent_time_zone): Likewise.
264 * filelock.c (get_boot_time): Likewise.
265 * frame.c (make_terminal_frame, set_term_frame_name)
266 (x_report_frame_params): Likewise.
267 * image.c (gs_load): Likewise.
268 * minibuf.c (get_minibuffer): Likewise.
269 * msdos.c (dos_set_window_size): Likewise.
270 * process.c (make_process): Likewise.
271 * xdisp.c (ensure_echo_area_buffers): Likewise.
272 * xsettings.c (apply_xft_settings): Likewise.
273
d01ba2f1
GM
2742012-07-09 Glenn Morris <rgm@gnu.org>
275
276 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
277 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
278 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
279 * nsterm.h (ns_etc_directory): Add it.
280 * callproc.c [HAVE_NS]: Include nsterm.h.
281 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
282
f1f924b6
DA
2832012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
284
285 Move marker debugging code under MARKER_DEBUG.
286 * marker.c (MARKER_DEBUG): Move marker debugging code under
287 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
288 for bootstrap with --enable-checking (~3x slowdown reported
289 by Juanma Barranquero <lekktu@gmail.com>).
290 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
291
ab531b66
PE
2922012-07-08 Paul Eggert <eggert@cs.ucla.edu>
293
294 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
295 See <http://bugs.gnu.org/11825#29>.
296
c4b3bc8a
EZ
2972012-07-08 Eli Zaretskii <eliz@gnu.org>
298
299 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
300 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
301 (display_line): Add commentary about displaying truncation glyphs
302 on GUI frames.
303 (produce_special_glyphs): Move here from term.c.
304
305 * term.c (produce_special_glyphs): Move to xdisp.c.
306
307 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
308 section.
c4b3bc8a 309
b676b881
AS
3102012-07-07 Andreas Schwab <schwab@linux-m68k.org>
311
f17c5273
AS
312 * xdisp.c (display_line): Avoid warning about implicit declaration
313 of FRAME_FONT.
314
298819b9
AS
315 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
316
b676b881
AS
317 * lisp.h: Remove empty conditional.
318
6045c4fd
PE
3192012-07-07 Paul Eggert <eggert@cs.ucla.edu>
320
b3350bf9
PE
321 * lread.c (load_path_check): Now static.
322
6045c4fd
PE
323 Fix some minor --with-ns problems found by static checking.
324 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
325 (x_set_font) [!HAVE_X_WINDOWS]:
326 * image.c (xpm_load_image) [HAVE_NS]:
327 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
328 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
329 Remove unused local.
330 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
331 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
332 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
333 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
334 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
335 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
336 Fix pointer signedness problem.
337 * xfaces.c (FRAME_X_FONT_TABLE):
338 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
339
929e7845
GM
3402012-07-07 Glenn Morris <rgm@gnu.org>
341
342 * lread.c (load_path_check): New function, split from init_lread.
343 (init_lread): Reorganize. Motivation:
344 If EMACSLOADPATH is set, check/warn about that rather than the
345 defaults, which we are not going to use. Hence we can remove
346 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
347 Don't warn if site-lisp directories are missing.
348 If not installed, start from a blank load-path, since
349 PATH_LOADSEARCH refers to the eventual installation directories.
350
58dd0aa4
EZ
3512012-07-07 Eli Zaretskii <eliz@gnu.org>
352
353 Support truncation and continuation glyphs on GUI frames, when
354 fringes are disabled. (Bug#11832)
355 * xdisp.c (init_iterator): Get dimensions of truncation and
356 continuation glyphs even if on GUI frames. Adjust
357 it->last_visible_x on GUI frames when the left or right fringes,
358 or both, are absent.
359 (start_display, move_it_in_display_line_to): Handle the case of a
360 GUI frame without a fringe to display continuation or truncation
361 glyphs.
362 (insert_left_trunc_glyphs): Support GUI frames: make sure
363 truncation glyphs overwrite enough glyphs from the current line to
364 have sufficient space in pixels.
365 (display_line): Support truncation and continuation glyphs on GUI
366 frames. If some spare pixels are left on the line after inserting
367 the truncation glyphs, fill that space with a stretch glyph of a
368 suitably computed width.
369
370 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
371 produce_glyphs, to support GUI sessions.
372
31571fd7
PE
3732012-07-07 Paul Eggert <eggert@cs.ucla.edu>
374
5a16b9bc
PE
375 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
376
f3047c75
PE
377 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
378
31571fd7
PE
379 Do not require float-time's arg to fit in time_t (Bug#11825).
380 This works better on hosts where time_t is unsigned, and where
381 float-time is applied to the (negative) difference between two times.
382 * editfns.c (decode_time_components): Last arg is now double *,
383 not int *, and means to store all the result as a double, without
384 worrying about whether the seconds part fits in time_t.
385 All callers changed.
386 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
387 All callers changed.
388 (Ffloat_time): Do not fail merely because the specified time falls
389 outside of time_t range.
390
4516fbef
GM
3912012-07-07 Glenn Morris <rgm@gnu.org>
392
393 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
394 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
395 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
396
07adc2c6
JB
3972012-07-07 Juanma Barranquero <lekktu@gmail.com>
398
399 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
400 Update dependencies.
401
402 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
403
fd573f31
PE
4042012-07-06 Paul Eggert <eggert@cs.ucla.edu>
405
fee5959d
PE
406 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
407 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
408 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
409 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
410 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
411 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
412
fd573f31
PE
413 * xfont.c (compare_font_names): Redo to omit the need for casts.
414
ddadbc0e
AS
4152012-07-06 Andreas Schwab <schwab@linux-m68k.org>
416
fca8d6b6
AS
417 * xfns.c (Fx_change_window_property): Doc fix.
418 * w32fns.c (Fx_change_window_property): Doc fix.
419
ddadbc0e
AS
420 * w32fns.c (Fx_window_property): Accept the same arguments as the
421 X Windows version. Doc fix.
422 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
423
f247498e
JB
4242012-07-06 Juanma Barranquero <lekktu@gmail.com>
425 Eli Zaretskii <eliz@gnu.org>
426
427 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
428 Windows-specific code from nt/config.nt moved here.
429 Obsolete settings removed.
430
216ee680
PE
4312012-07-06 Paul Eggert <eggert@cs.ucla.edu>
432
433 * process.c: Avoid unnecessary calls to gettime.
434 (wait_reading_process_output): Don't get the time of day
435 when gobbling data immediately and not waiting, as there's no need
436 for it in that case. This removes a FIXME.
437
bdd091e4
JD
4382012-07-06 Jan Djärv <jan.h.d@swipnet.se>
439
440 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
441 is defined (Bug#11768).
442
9d44f8ce
DA
4432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
444
445 Fix marker debugging code.
446 * marker.c (byte_char_debug_check): Do not perform the check
447 if buffer is not multibyte.
090bd7cb
JB
448 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
449 Call byte_char_debug_check with correct arguments.
9d44f8ce 450
90fc4786
DA
4512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
452
453 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
454 * marker.c (byte_char_debug_check, count_markers):
455 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
456 (byte_debug_flag): Remove.
457 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
458 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
459
7b7ae965
DA
4602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
461
4e57b342
DA
462 Avoid code repetition in marker-related functions.
463 * marker.c (attach_marker): New function.
464 (Fset_marker, set_marker_restricted, set_marker_both)
465 (set_marker_restricted_both): Use it.
466 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
467 Consistently rename charno to charpos.
468 (marker_position): Add eassert.
469 (marker_byte_position): Convert to eassert.
470
4712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
472
473 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 474 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 475 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 476
657924ff
DA
4772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
478
479 Introduce fast path for the widely used marker operation.
480 * alloc.c (build_marker): New function.
481 * lisp.h (build_marker): New prototype.
482 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
483 * composite.c (autocmp_chars): Likewise.
484 * editfns.c (buildmark): Remove.
485 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
486 (save_restriction_save): Use build_marker.
487 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
488 * window.c (save_window_save): Likewise.
489
041a49a6
DA
4902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
491
492 Do not use Fdelete_overlay in delete_all_overlays
493 to avoid redundant calls to unchain_overlay.
494 * buffer.c (drop_overlay): New function.
495 (delete_all_overlays, Fdelete_overlay): Use it.
496 * minibuf.c (get_minibuffer): Fix comment.
497
7dca65a4
PE
4982012-07-06 Paul Eggert <eggert@cs.ucla.edu>
499
500 Port to OpenBSD 5.1 amd64.
501 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
502 This is needed for OpenBSD, and should be harmless on all BSD systems.
503 Also, include <sys/sysctl.h>, as it should be available on all
504 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
505 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
506 use p_pid member, not kp_proc.pid.
507
8eb876e2
GM
5082012-07-06 Glenn Morris <rgm@gnu.org>
509
510 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
511
38182d90
PE
5122012-07-05 Paul Eggert <eggert@cs.ucla.edu>
513
514 More xmalloc and related cleanup.
515 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
516 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
517 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
518 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
519 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
520 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
521 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
522 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
523 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
524 * xterm.c:
525 Omit needless casts involving void * pointers and allocation.
526 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
527 as the former is more robust if P's type is changed.
528 Prefer xzalloc to xmalloc + memset 0.
529 Simplify malloc-or-realloc to realloc.
530 Don't worry about xmalloc returning a null pointer.
531 Prefer xstrdup to xmalloc + strcpy.
532 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
533 growing it.
534 * keyboard.c (apply_modifiers_uncached): Prefer local array to
535 alloca of a constant.
536
6dd5a677
EZ
5372012-07-05 Eli Zaretskii <eliz@gnu.org>
538
539 * xdisp.c (display_line): Fix horizontal pixel coordinates when
540 hscroll is larger than the line width. Fixes long and futile
541 looping inside extend_face_to_end_of_line (on a TTY) producing
542 glyphs that are not needed and thrown away.
543
6b312f0f
DA
5442012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
545
546 * marker.c (set_marker_restricted_both): Simplify by using
547 clip_to_bounds.
548
f520ef9b
PE
5492012-07-05 Paul Eggert <eggert@cs.ucla.edu>
550
551 * editfns.c (region_limit): Simplify by using clip_to_bounds.
552
383b7c95
JD
5532012-07-05 Jan Djärv <jan.h.d@swipnet.se>
554
555 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
556 not defined (Bug#11768).
557 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
558 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
559 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
560 followed by gtk_box_set_homogeneous (Bug#11768).
561 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
562 (update_theme_scrollbar_width, xg_create_scroll_bar):
563 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
564 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
565 (is_box_type): New function (Bug#11768).
566 (xg_tool_item_stale_p): Call is_box_type.
5293d758 567 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
568 with default display (Bug#11768).
569
d6e7bf45
EZ
5702012-07-05 Eli Zaretskii <eliz@gnu.org>
571
572 * xdisp.c (window_hscroll_limited): New function.
573 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
574 coordinates when window's hscroll is set to insanely large
575 values. (Bug#11857)
576
431391ec
JB
5772012-07-05 Juanma Barranquero <lekktu@gmail.com>
578
579 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
580 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
581
23f86fce
DA
5822012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
583
584 Cleanup xmalloc.
585 * lisp.h (xzalloc): New prototype. Omit needless casts.
586 * alloc.c (xzalloc): New function. Omit needless casts.
587 * charset.c: Omit needless casts. Convert all calls to
588 xmalloc with following memset to xzalloc.
589 * dispnew.c: Likewise.
590 * fringe.c: Likewise.
591 * image.c: Likewise.
592 * sound.c: Likewise.
593 * term.c: Likewise.
594 * w32fns.c: Likewise.
595 * w32font.c: Likewise.
596 * w32term.c: Likewise.
597 * xfaces.c: Likewise.
598 * xfns.c: Likewise.
599 * xterm.c: Likewise.
600 * atimer.c: Omit needless casts.
601 * buffer.c: Likewise.
602 * callproc.c: Likewise.
603 * ccl.c: Likewise.
604 * coding.c: Likewise.
605 * composite.c: Likewise.
606 * doc.c: Likewise.
607 * doprnt.c: Likewise.
608 * editfns.c: Likewise.
609 * emacs.c: Likewise.
610 * eval.c: Likewise.
611 * filelock.c: Likewise.
612 * fns.c: Likewise.
613 * gtkutil.c: Likewise.
614 * keyboard.c: Likewise.
615 * lisp.h: Likewise.
616 * lread.c: Likewise.
617 * minibuf.c: Likewise.
618 * msdos.c: Likewise.
619 * print.c: Likewise.
620 * process.c: Likewise.
621 * region-cache.c: Likewise.
622 * search.c: Likewise.
623 * sysdep.c: Likewise.
624 * termcap.c: Likewise.
625 * terminal.c: Likewise.
626 * tparam.c: Likewise.
627 * w16select.c: Likewise.
628 * w32.c: Likewise.
629 * w32reg.c: Likewise.
630 * w32select.c: Likewise.
631 * w32uniscribe.c: Likewise.
632 * widget.c: Likewise.
633 * xdisp.c: Likewise.
634 * xmenu.c: Likewise.
635 * xrdb.c: Likewise.
636 * xselect.c: Likewise.
637
0497dc44
PE
6382012-07-05 Paul Eggert <eggert@cs.ucla.edu>
639
640 * fileio.c (time_error_value): Check the right error number.
641 Problem reported by Troels Nielsen in
642 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
643
356e7178
PE
6442012-07-04 Paul Eggert <eggert@cs.ucla.edu>
645
4e71fd89
PE
646 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
647 This should be fixed in a better way; see Eli Zaretskii in
648 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
649 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
650
f0941253
PE
651 * fileio.c (time_error_value): Rename from special_mtime.
652 The old name's problems were noted by Eli Zaretskii in
653 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
654
065c9eb4
PE
655 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
656 This variable's comment says Emacs needs at least one GDB-visible
657 symbol of type enum pvec_type, to work around GDB problems.
658 The symbol's value doesn't matter.
659
356e7178
PE
660 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
661 that causes compilation to fail on pre-C99 compilers.
662
95f61aa2
JB
6632012-07-04 Juanma Barranquero <lekktu@gmail.com>
664
665 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
666 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
667
3884d954
DA
6682012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
669
d209e2fb 670 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
671 headers for buffer_defaults and buffer_local_symbols.
672 Reported by Juanma Barranquero <lekktu@gmail.com>.
673
ee28be33
SM
6742012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
675
676 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
677 * lisp.h (enum pvec_type): Use fewer bits.
678 (PSEUDOVECTOR_SIZE_BITS): New constant.
679 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
680 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
681 change in pvec_type.
682 (PSEUDOVECTOR_TYPEP): New macro.
683 (TYPED_PSEUDOVECTORP): Use it.
684 * fns.c (internal_equal): Adapt code to extract pvectype.
685 * emacs.c (gdb_pvec_type): Update type.
686 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
687 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
688 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
689 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
690 (sweep_vectors): Use it. Use local var `total_bytes' instead of
691 abusing vector->header.next.nbytes.
692 (live_vector_p): Use PVEC_TYPE.
693 (mark_object): Adapt code to extract pvectype. Use switch.
694
c7f2cd7f
PE
6952012-07-04 Paul Eggert <eggert@cs.ucla.edu>
696
697 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
698 Tighten new eassert a bit.
699
8ce70ed2
DA
7002012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
701
702 Fix compilation with --enable-gcc-warnings and -O1
703 optimization level.
704 * doprnt.c (doprnt): Change type of tem to int, initialize
705 to avoid compiler warning. Add eassert.
706 * search.c (simple_search): Initialize match_byte to avoid
707 compiler warning. Add eassert.
708
dea7f1e5
PE
7092012-07-04 Paul Eggert <eggert@cs.ucla.edu>
710
24a212eb
PE
711 Avoid weird behavior with large horizontal scrolls.
712 Without this change, for example, large hscroll values would
713 mess up Emacs's display on Fedora 15 x86, presumably due to
714 overflows in int calculations in the display code.
715 Also, if buffers had long lines, Emacs would freeze.
716 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
717 (set_window_hscroll): New function, containing the old guts of
718 Fset_window_hscroll. Return the clipped value.
719 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
720 This avoids the need to check against PTRDIFF_MAX.
721
dea7f1e5
PE
722 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
723
76046526
DA
7242012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
725
726 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
727
39adff0d
PE
7282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
729
63807d47
PE
730 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
731 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
732 since GCC 4.4.6 issues a bogus warning for them.
733
39adff0d
PE
734 Fix bugs in file timestamp newness comparisons.
735 * fileio.c (Ffile_newer_than_file_p):
736 * lread.c (Fload): Use full timestamp resolution of files,
737 not just the 1-second resolution, so that files that are only
738 slightly newer still count as newer.
739 * fileio.c (Ffile_newer_than_file_p): Don't assume file
740 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
741
dbeed9a6
PE
7422012-07-03 Paul Eggert <eggert@cs.ucla.edu>
743
744 * fileio.c: Improve handling of file time marker. (Bug#11852)
745 (special_mtime): New function.
746 (Finsert_file_contents, Fverify_visited_file_modtime):
747 Use it to set special mtime values consistently.
748
636334d6
AS
7492012-07-03 Andreas Schwab <schwab@linux-m68k.org>
750
751 * fileio.c (Finsert_file_contents): Properly handle st_mtime
752 marker for non-existing file. (Bug#11852)
753
e2017fe2
GM
7542012-07-03 Glenn Morris <rgm@gnu.org>
755
756 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
757 and did not make it into globals.h).
758
404dbd37
TT
7592012-07-03 Tom Tromey <tromey@redhat.com>
760
761 * window.c (Fset_window_margins, Fset_window_fringes)
762 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
763 * textprop.c (Fprevious_property_change): No longer static.
764 * syntax.c (Fsyntax_table_p): No longer static.
765 * process.c (Fget_process, Fprocess_datagram_address): No longer
766 static.
767 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
768 * keyboard.c (Fcommand_execute): No longer static.
769 Remove EXFUN.
770 * insdel.c (Fcombine_after_change_execute): No longer static.
771 * image.c (Finit_image_library): No longer static.
772 * fileio.c (Fmake_symbolic_link): No longer static.
773 * eval.c (Ffetch_bytecode): No longer static.
774 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
775 * doc.c (Fdocumentation_property, Fsnarf_documentation):
776 No longer static.
404dbd37
TT
777 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
778 static.
779 * dired.c (Ffile_attributes): No longer static.
780 * composite.c (Fcomposition_get_gstring): No longer static.
781 * callproc.c (Fgetenv_internal): No longer static.
782
783 * ccl.h: Remove EXFUNs.
784 * buffer.h: Remove EXFUNs.
785 * dispextern.h: Remove EXFUNs.
786 * intervals.h: Remove EXFUNs.
787 * fontset.h: Remove EXFUN.
788 * font.h: Remove EXFUNs.
789 * dosfns.c (system_process_attributes): Remove EXFUN.
790 * keymap.h: Remove EXFUNs.
791 * lisp.h: Remove EXFUNs.
792 * w32term.h: Remove EXFUNs.
793 * window.h: Remove EXFUNs.
794 * xsettings.h: Remove EXFUN.
795 * xterm.h: Remove EXFUN.
796
8e4fd1e1
GM
7972012-07-03 Glenn Morris <rgm@gnu.org>
798
799 * lisp.h (Frandom): Make it visible to C.
800 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
801 buffer for invisible buffers. (Bug#1229)
802
ca95b3eb
DA
8032012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
804
805 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
806 values which aren't power of 2.
807 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
808 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
809 accordingly.
810
7555c33f
SM
8112012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
812
813 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
814
815 * alloc.c (mark_object): Revert part of last patch to use `switch'.
816
d12e8f5a
DA
8172012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
818
819 * alloc.c (allocate_vector_block): Remove redundant
820 calls to mallopt if DOUG_LEA_MALLOC is defined.
821 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
822 avoid calls to mallopt if zero_vector is returned.
823
296094c3
DA
8242012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
825
826 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
827 is enabled, avoid dereferencing NULL current_sblock if
828 running undumped.
829
36429c89
DA
8302012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
831
832 Cleanup basic buffer management.
833 * buffer.h (struct buffer): Change layout to use generic vector
834 marking code. Fix some comments. Change type of 'clip_changed'
835 to bitfield. Remove unused #ifndef old.
836 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
837 (GET_OVERLAYS_AT): Fix indentation.
838 (for_each_per_buffer_object_at): New macro.
839 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
840 (Fbuffer_local_variables): Use it.
841 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
842 * alloc.c (allocate_buffer): Adjust to match new layout of
843 struct buffer. Fix comment.
844 (mark_overlay): New function.
845 (mark_buffer): Use it. Use mark_vectorlike to mark normal
846 Lisp area of struct buffer.
847 (mark_object): Use it. Adjust marking of misc objects
848 and related comments.
849
3b3e4cac
PE
8502012-07-02 Paul Eggert <eggert@cs.ucla.edu>
851
852 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
853 wrapper that is not needed because the wrapped code is a no-op (zero
854 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
855 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
856
cf5c0175
DA
8572012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
858
859 * alloc.c (mark_buffer): Simplify. Remove prototype.
860 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 861 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
862 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
863 redundant calls to mark_vectorlike for bool vectors.
864
ca26824c
GM
8652012-06-30 Glenn Morris <rgm@gnu.org>
866
2e4c5312
GM
867 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
868
ca26824c
GM
869 * epaths.in (PATH_SITELOADSEARCH): New.
870 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
871 This is rather than relying on --enable-locallisppath elements
872 having "site-lisp" in their names. (Bug#10208#25, 11658)
873
0d23c240
EZ
8742012-06-30 Eli Zaretskii <eliz@gnu.org>
875
c9240d7a
EZ
876 * w32proc.c (sys_select): Accept and ignore one more argument.
877
878 * w32.c (emacs_gnutls_pull): Call select with one more argument.
879
0d23c240 880 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 881 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
882
883 * sysdep.c: Don't include dos.h and dosfns.h.
884
885 * process.c (sys_select):
886 * msdos.c (sys_select): Accept one more argument and ignore it.
887
888 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
889 adapt data types and code to that.
890
891 * dosfns.c:
892 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
893 which clashes with the gnulib function of the same name.
894
af5a5a98
AS
8952012-06-30 Andreas Schwab <schwab@linux-m68k.org>
896
c5e4379c
AS
897 * font.c (font_style_to_value, font_style_symbolic)
898 (font_prop_validate_style): Add type checks for values in
899 font_style_table.
900
af5a5a98
AS
901 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
902 argument.
903 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
904 uses.
905
8d38f461
EZ
9062012-06-29 Eli Zaretskii <eliz@gnu.org>
907
2e5a6631
EZ
908 * xdisp.c (try_window_id): Undo last change.
909
8d38f461
EZ
910 * w32.c (getwd): Adjust commentary about startup_dir.
911 (init_environment): Always call sys_access, even in non-MSVC
912 builds. Don't chdir to the directory of the Emacs executable.
913 This undoes code from 1997 which was justified by the need to
914 "avoid conflicts when removing and renaming directories". But its
915 downside was that every relative file name was being interpreted
916 relative to the directory of the Emacs executable, which can never
917 be TRT. In particular, it broke sys_access when called with
918 relative file names.
919 (sys_access): Map GetLastError to errno.
920
2af3565e
DA
9212012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
922
923 * window.h (struct window): Change type of 'fringes_outside_margins'
924 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 925 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
926 Adjust comment.
927 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
928 to ptrdiff_t.
929
c8d3a25c 9302012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 931
c8d3a25c
GM
932 * gnutls.c (emacs_gnutls_handshake):
933 Add QUIT to make the loop interruptible.
57570cd3 934
c8d3a25c 9352012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 936
c8d3a25c
GM
937 * charset.c (init_charset): Make lack of etc/charsets fatal.
938
3e984ee8
DA
9392012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
940
941 * editfns.c (region_limit): Fix type mismatch.
942
ef884f23
DA
9432012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
944
945 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
946 undefined. Convert from xassert to eassert.
947 * nsmenu.m: Convert from xassert to eassert.
948 * nsterm.m: Likewise.
949
7d7e0027
SM
9502012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
951
952 * editfns.c (region_limit): Clip to narrowing (bug#11770).
953
aa754e6a
PE
9542012-06-28 Paul Eggert <eggert@cs.ucla.edu>
955
956 Avoid integer overflow on scroll-left and scroll-right.
957 * window.c (HSCROLL_MAX): New macro.
958 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
959 overflow when requested scroll falls outside ptrdiff_t range.
960
80b00b08
DA
9612012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
962
963 * window.h (struct window): Change type of 'hscroll',
964 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
965 'last_modified' and 'last_overlay_modified' to EMACS_INT.
966 Adjust users accordingly.
967 * xdisp.c (try_cursor_movement): Replace type check with eassert.
968 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
969 from EMACS_INT to ptrdiff_t.
970 (make_window): Omit redundant initialization.
971
62b2bcf6
JB
9722012-06-28 Juanma Barranquero <lekktu@gmail.com>
973
974 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
975
45942c7d
DA
9762012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
977
978 * window.h (struct window): Change type of 'use_time' and
979 'sequence_number' from Lisp_Object to int.
980 * frame.c (make_frame): Adjust users accordingly.
981 * print.c (print_object): Likewise.
982 * window.c (select_window, Fwindow_use_time, make_parent_window)
983 (make_window): Likewise.
984
e509cfa6
DA
9852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
986
987 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
988 enabled with --enable-checking=[all,glyphs] configure option.
989 Fix GLYPH_DEBUG usage assuming that it may be undefined,
990 adjust comments accordingly.
991 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
992 undefined, adjust comments accordingly.
993 * image.c: Likewise.
994 * scroll.c: Likewise.
995 * w32fns.c: Likewise.
996 * w32term.c: Likewise.
997 * xdisp.c: Likewise.
998 * xfaces.c: Likewise.
999 * xfns.c: Likewise.
1000 * xterm.c: Likewise.
1001
a54e2c05
DA
10022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1003
1004 Generalize run-time debugging checks.
1005 * dispextern.h (XASSERTS): Remove.
1006 * fontset.c (xassert): Remove.
1007 Convert from xassert to eassert.
1008 * alloc.c: Convert from xassert to eassert.
1009 * bidi.c: Likewise.
1010 * dispnew.c: Likewise.
1011 * fns.c: Likewise.
1012 * fringe.c: Likewise.
1013 * ftfont.c: Likewise.
1014 * gtkutil.c: Likewise.
1015 * image.c: Likewise.
1016 * keyboard.c: Likewise.
1017 * menu.c: Likewise.
1018 * process.c: Likewise.
1019 * scroll.c: Likewise.
1020 * sound.c: Likewise.
1021 * term.c: Likewise.
1022 * w32console.c: Likewise.
1023 * w32fns.c: Likewise.
1024 * w32term.c: Likewise.
1025 * window.c: Likewise.
1026 * xdisp.c: Likewise.
1027 * xfaces.c: Likewise.
1028 * xfns.c: Likewise.
1029 * xselect.c: Likewise.
1030 * xterm.c: Likewise.
1031
1ec4b7b2
SM
10322012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1033
1034 * fns.c (maybe_resize_hash_table): Output message when growing the
1035 purify-hashtable.
1036
2014308a
DA
10372012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1038
1039 * alloc.c (allocate_string_data): Remove dead code.
1040 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1041 avoid GCC warning about unused macro.
1042
246155eb
DA
10432012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1044
1045 * alloc.c (allocate_string): Omit intervals initialization.
1046 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1047 as in make_pure_string and make_pure_c_string.
1048
43184b7b
DA
10492012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1050
d209e2fb 1051 * alloc.c (allocate_string): Fix last change.
43184b7b 1052
3fe6dd74
DA
10532012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1054
d209e2fb 1055 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1056 to memset, add explicit initialization where appropriate.
1057
1ba6038a
GM
10582012-06-27 Glenn Morris <rgm@gnu.org>
1059
1060 * lisp.mk (lisp): Remove paths.elc.
1061
c89926a5
CY
10622012-06-27 Chong Yidong <cyd@gnu.org>
1063
1064 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1065
ed6b3510
JW
10662012-06-26 John Wiegley <johnw@newartisans.com>
1067
1ec4b7b2 1068 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1069 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1070
ed6b3510
JW
1071 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1072 when building with Clang.
1073
8edd4a2b
SM
10742012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1075
1076 * eval.c (Fapply): Allow calling it with a single argument.
1077
f6f62d1b
EZ
10782012-06-26 Eli Zaretskii <eliz@gnu.org>
1079
1080 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1081 _stricmp and _strnicmp.
1082 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1083
62efea5e
DA
10842012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1085
1086 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1087 allocated window.
1088 (allocate_process): Likewise for new process.
8edd4a2b 1089 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1090 (allocate_frame): Likewise.
1091 * frame.c (make_frame): Omit redundant initialization.
1092 * window.c (make_parent_window): Use memset.
1093 (make_window): Omit redundant initialization.
1094 * process.c (make_process): Omit redundant initialization.
1095 * terminal.c (create_terminal): Likewise.
1096
42997f4d
DA
10972012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 * term.c (delete_tty): Remove redundant call to memset.
1100
1130ecfc
DA
11012012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 * alloc.c: Remove build_string.
1104 * lisp.h: Define build_string as static inline. This provides
1105 a better opportunity to optimize away calls to strlen when the
1106 function is called with compile-time constant argument.
1107 * image.c (imagemagick_error): Convert to build_string.
1108 * w32proc.c (sys_spawnve): Likewise.
1109 * xterm.c (x_term_init): Likewise.
1110
cf38a720
PE
11112012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1112
99027bdd
PE
1113 Use sprintf return value instead of invoking strlen on result.
1114 In the old days this wasn't portable, since some sprintf
1115 implementations returned char *. But they died out years ago and
1116 Emacs already assumes sprintf returns int.
1117 Similarly for float_to_string.
1118 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1119 * ccl.c (ccl_driver):
1120 * character.c (string_escape_byte8):
1121 * data.c (Fnumber_to_string):
1122 * doprnt.c (doprnt):
1123 * print.c (print_object):
1124 * xdisp.c (message_dolog):
1125 * xfns.c (syms_of_xfns):
1126 Use sprintf or float_to_string result to avoid need to call strlen.
1127 * data.c (Fnumber_to_string):
1128 Use make_unibyte_string, since the string must be ASCII.
1129 * lisp.h, print.c (float_to_string): Now returns int length.
1130 * term.c (produce_glyphless_glyph):
1131 Use sprintf result rather than recomputing it.
1132
cf38a720
PE
1133 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1134 * Makefile.in (ALL_CFLAGS):
1135 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1136 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1137
3511c784
DA
11382012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1139
0a08eb21 1140 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1141 strcasecmp if available.
1142 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1143
fb7da12e
AS
11442012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1145
1146 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1147 Avoid comma operator.
1148 * menu.c (push_submenu_start, push_submenu_end)
1149 (push_left_right_boundary, push_menu_pane): Likewise.
1150 * msdos.c (dos_rawgetc): Likewise.
1151
afa2ffd8
DA
11522012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1153
1154 * xfns.c (xic_create_fontsetname): Remove redundant calls
1155 to memset.
1156
b3b4476b
PE
11572012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1158
4495ff38
PE
1159 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1160 sprintf already null-terminates its output.
1161
b3b4476b
PE
1162 * xfns.c (x_window): Remove redundant cast.
1163
b00876c9
DA
11642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1165
1166 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1167 `const char *' to `char *' to avoid compiler warning.
1168
d188e26b
PE
11692012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1170
885d1d74
PE
1171 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1172 instead of truncating it to 63 (admittedly a generous limit).
1173
d188e26b
PE
1174 * process.c: Fix spelling and caps in comments.
1175
e2f560b1
DN
11762012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1177
e86db54b 1178 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1179 * sysdep.c (setpgrp): Remove definition, not used in this file.
1180
7583a3a1
JB
11812012-06-24 Juanma Barranquero <lekktu@gmail.com>
1182
1183 * makefile.w32-in: Update dependencies.
1184
696056c2
EZ
11852012-06-24 Eli Zaretskii <eliz@gnu.org>
1186
1187 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1188 (SYSTIME_H): Add nt/inc/sys/time.h.
1189
1190 * systime.h [WINDOWSNT]: Include sys/time.h.
1191
1192 * s/ms-w32.h (struct timespec): Definition moved from
1193 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1194
845ca893
PE
11952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1198 * buffer.h (buffer_slot_type_mismatch):
1199 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1200 * eval.c (unwind_to_catch):
1201 * image.c (my_png_error, my_error_exit):
1202 * keyboard.c (quit_throw_to_read_char, user_error)
1203 (Fexit_recursive_edit, Fabort_recursive_edit):
1204 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1205 (wrong_type_argument, buffer_overflow, __executable_start)
1206 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1207 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1208 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1209 (fatal):
1210 (child_setup) [!DOS_NT]:
1211 * lread.c (end_of_file_error, invalid_syntax):
1212 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1213 * puresize.h (pure_write_error):
1214 * search.c (matcher_overflow):
1215 * sound.c (sound_perror, alsa_sound_perror):
1216 * sysdep.c, syssignal.h (croak):
1217 * term.c (maybe_fatal, vfatal):
1218 * textprop.c (text_read_only):
1219 * undo.c (user_error):
1220 * unexmacosx.c (unexec_error):
1221 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1222 Use _Noreturn rather than NO_RETURN.
1223 No need for separate decl merely because of _Noreturn.
1224 * sound.c (sound_warning, parse_sound):
1225 Remove unnecessary forward decls.
1226
f1dd8073
PE
12272012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1230 * lisp.h (WAIT_READING_MAX): New macro.
1231 * dispnew.c (Fsleep_for, sit_for):
1232 * keyboard.c (kbd_buffer_get_event):
1233 * process.c (Faccept_process_output):
1234 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1235 This improves on the previous patch, which introduced a bug
1236 when time_t is unsigned and as wide as intmax_t.
1237 See <http://bugs.gnu.org/9000#51>.
1238
b82c1755
EZ
12392012-06-23 Eli Zaretskii <eliz@gnu.org>
1240
1241 * dispnew.c (sit_for, Fsleep_for):
1242 * keyboard.c (kbd_buffer_get_event):
1243 * process.c (Faccept_process_output): Avoid compiler warnings when
1244 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1245
ca300656
JB
12462012-06-23 Juanma Barranquero <lekktu@gmail.com>
1247
049ec95b
JB
1248 * makefile.w32-in: Update dependencies.
1249
ca300656
JB
1250 * w32.c (ltime): Add return type and declare static.
1251 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1252
db7b8d06
PE
12532012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1256 Privately reported by Herbert J. Skuhra.
1257 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1258 All uses changed.
1259 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1260 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1261
0bd8297f
EZ
12622012-06-23 Eli Zaretskii <eliz@gnu.org>
1263
96512555
EZ
1264 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1265 last argument of make_unibyte_string.
1266
0bd8297f
EZ
1267 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1268 language ID in the event parameters.
1269
1270 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1271 event.code, not the obscure "character set ID".
1272
63def6b6
CY
12732012-06-23 Chong Yidong <cyd@gnu.org>
1274
1275 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1276
e8a02204
EZ
12772012-06-23 Eli Zaretskii <eliz@gnu.org>
1278
388cdec0
EZ
1279 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1280 * w32.c (fdutimens): New function.
1281
1282 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1283
1284 * s/ms-w32.h (pselect): Redirect to sys_select.
1285
1286 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1287
e8a02204
EZ
1288 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1289 in the logic of incrementing and decrementing the value of
1290 use_relocatable_buffers.
1291
d054f3fb
PE
12922012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1295 Privately reported by Herbert J. Skuhra.
1296 [__FreeBSD__]: Remove "*/" typo after "#include".
1297 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1298 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1299 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1300 Don't assume EMACS_TIME and struct timeval are the same type.
1301
d35af63c
PE
13022012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 Support higher-resolution time stamps (Bug#9000).
1305 The time stamps are only nanosecond-resolution at the C level,
1306 since that's the best that any real-world system supports now.
1307 But they are picosecond-resolution at the Lisp level, as that's
1308 easy, and leaves room for future OS improvements.
1309
1310 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1311 (LIBES): Use it.
1312
1313 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1314 Don't get current time unless it's needed.
1315
1316 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1317 now provides it if it's absent.
1318 (start_atimer): Port to higher-res time stamps.
1319 Check for time stamp overflow. Don't get current time more
1320 often than is needed.
1321
1322 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1323 Include systime.h, not time.h.
1324 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1325
1326 * dired.c: Include stat-time.h.
1327 (Ffile-attributes): File times now have higher resolution.
1328
1329 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1330 (struct image): Timestamp now has higher resolution.
1331
1332 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1333 has at least microseconds now. All uses removed.
1334 (update_frame, update_single_window, update_window, update_frame_1)
1335 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1336
1337 * editfns.c (time_overflow): Now extern.
1338 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1339 (float-time, Fformat_time_string, Fcurrent_time_string)
1340 (Fcurrent_time_zone): Accept and generate higher-resolution
1341 time stamps.
1342 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1343 (decode_time_components, lisp_seconds_argument): New functions.
1344 (make_time): Now static.
1345 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1346 Report an error if the time is invalid, rather than having the caller
1347 do that.
1348
1349 * fileio.c: Include <stat-time.h>
1350 (Fcopy_file): Copy higher-resolution time stamps.
1351 Prefer to set the time stamp via a file descriptor if that works.
1352 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1353 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1354 (Fvisited_file_modtime, Fset_visited_file_modtime):
1355 Support higher-resolution time stamps.
1356
1357 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1358
1359 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1360
1361 * image.c (prepare_image_for_display, clear_image_cache)
1362 (lookup_image): Port to higer-resolution time stamps.
1363
1364 * keyboard.c (start_polling, bind_polling_period):
1365 Check for time stamp overflow.
1366 (read_char, kbd_buffer_get_event, timer_start_idle)
1367 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1368 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1369 Port to higher-resolution time stamps. Do not assume time_t is signed.
1370 (decode_timer): New function. Timers are now vectors of length 9,
1371 not 8, to accommodate the picosecond component.
1372 (timer_check_2): Use it.
1373
1374 * nsterm.m (select_timeout, timeval_subtract): Remove.
1375 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1376 as they're a bit more accurate and handle overflow better.
1377 (ns_select): Change prototype to be compatible with pselect.
1378 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1379 * nsterm.h (ns_select): Adjust prototype.
1380
1381 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1382 us-resolution time stamps.
1383 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1384
1385 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1386
1387 * lisp.h (time_overflow): New decl.
1388 (wait_reading_process_output): First arg is now intmax_t, not int,
1389 to accommodate larger waits.
1390
1391 * process.h (struct Lisp_Process.read_output_delay):
1392 Now counts nanoseconds, not microseconds.
1393 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1394 EMACS_HAS_USECS.
1395 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1396 (wait_reading_process_output):
1397 Port to ns-resolution time stamps.
1398 (Faccept_process_output, wait_reading_process_output):
1399 Check for time stamp overflow. Do not assume time_t is signed.
1400 (select_wrapper): Remove; we now use pselect.
1401 (Fprocess_attributes): Now generates ns-resolution time stamps.
1402
1403 * sysdep.c: Include utimens.h. Don't include utime.h
1404 or worry about struct utimbuf; gnulib does that for us now.
1405 (gettimeofday): Remove; gnulib provides a substitute.
1406 (make_timeval): New function.
1407 (set_file_times): Now sets ns-resolution time stamps.
1408 New arg FD; all uses changed.
1409 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1410 (system_process_attributes):
1411 Now returns ns-resolution time stamp. All uses changed.
1412 Check for time stamp overflow.
1413
1414 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1415 provides a substitute now.
1416
1417 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1418 since it guarantees struct timespec.
1419 (EMACS_TIME): Now struct timespec, so that we can support
1420 ns-resolution time stamps.
1421 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1422 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1423 (EMACS_USECS): Remove.
1424 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1425 so multiply the arg by 1000 before storing it.
1426 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1427 New macros.
1428 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1429 Port to ns-resolution time stamps.
1430 (EMACS_TIME_NEG_P): Remove; replaced by....
1431 (EMACS_TIME_SIGN): New macro.
1432 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1433 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1434 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1435 (make_timeval, make_lisp_time, decode_time_components): New decls.
1436 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1437 that it mishandled time_t overflow. You can't compare by subtracting!
1438 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1439 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1440
1441 * term.c: Include <sys/time.h>.
1442 (timeval_to_Time): New function, for proper overflow wraparound.
1443 (term_mouse_position, term_mouse_click): Use it.
1444
1445 * undo.c (record_first_change): Support higher-resolution time stamps
1446 in the undo buffer.
1447 (Fprimitive_undo): Use them when restoring time stamps.
1448
1449 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1450 (w32_get_internal_run_time):
1451 Port to higher-resolution Emacs time stamps.
1452 (ltime): Now accepts single 64-bit integer, as that's more convenient
1453 for callers.
1454
1455 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1456
1457 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1458 for compatibility with pselect. Support ns-resolution time stamps.
1459
1460 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1461
1462 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1463 Check for time stamp overflow, and support ns-resolution time stamps.
1464
1465 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1466 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1467 (timeval_subtract): Remove; no longer needed.
1468 (XTflash, XTring_bell, x_wait_for_event):
1469 Port to ns-resolution time stamps. Don't assume time_t is signed.
1470
b6a92dfe
CY
14712012-06-22 Chong Yidong <cyd@gnu.org>
1472
1473 * xdisp.c (x_consider_frame_title): Revert last change.
1474
d251c37c
EZ
14752012-06-22 Eli Zaretskii <eliz@gnu.org>
1476
1477 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1478 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1479 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1480 staticidx goes up to 1597 out of 1600 = 0x640.)
1481
f10deafb
PE
14822012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1485 Otherwise, the umask might be mistakenly 0 while handling input signals.
1486
ec6de1e2
SM
14872012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1488
1489 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1490
28be1ada
DA
14912012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1492
1493 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1494 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1495 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1496 access to `contents' member of Lisp_Vector objects with AREF and ASET
1497 where appropriate.
1498
c6bf3022
CY
14992012-06-19 Chong Yidong <cyd@gnu.org>
1500
1501 * frame.c (delete_frame): When selecting a frame on a different
1502 text terminal, do not alter the terminal's top-frame.
1503
1504 * xdisp.c (format_mode_line_unwind_data): Record the target
1505 frame's selected window and its terminal's top-frame.
1506 (unwind_format_mode_line): Restore them.
1507 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1508 Callers changed.
1509 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1510 since tty frames can be explicitly named.
1511 (prepare_menu_bars): Likewise.
1512
1513 * term.c (Ftty_top_frame): New function.
1514
defd4196
PE
15152012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 Port byte-code-meter to modern targets.
1518 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1519 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1520 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1521 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1522 (METER_1, METER_2): Simplify.
1523
1053a871
SM
15242012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * data.c (Fdefalias): Return `symbol' (bug#11686).
1527
b7e8d081
MR
15282012-06-18 Martin Rudalics <rudalics@gmx.at>
1529
1530 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1531 gets killed during executing of this function (Bug#11665).
1532 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1533 (Vkill_buffer_query_functions): In doc-string say that functions
1534 run by this hook should not change the current buffer.
1535
7ea2b339
PE
15362012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1537
1538 Fix recently-introduced process.c problems found by static checking.
1539 * process.c (write_queue_push, write_queue_pop, send_process):
1540 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1541 (write_queue_pop): Fix pointer signedness problem.
1542 (send_process): Remove unused local.
1543
96a313a1
CY
15442012-06-17 Chong Yidong <cyd@gnu.org>
1545
1546 * xdisp.c (redisplay_internal): No need to redisplay terminal
1547 frames that are not on top.
1548
20ca2e94
TN
15492012-06-17 Troels Nielsen <bn.troels@gmail.com>
1550
1551 * process.c (make_process): Initialize write_queue.
1552 (write_queue_push, write_queue_pop): New functions.
1553 (send_process): Use them to maintain correct ordering of process
1554 writes (Bug#10815).
1555
9a900ca9
PE
15562012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1557
310fbfa8
PE
1558 * lisp.h (eassert): Assume C89 or later.
1559 This removes the need for CHECK.
1560 (CHECK): Remove. Its comments about always evaluating its
1561 argument were confusing, as 'eassert' typically does not evaluate
1562 its argument.
1563
27bb1ca4
PE
1564 * coding.c (produce_chars): Use ptrdiff_t, not int.
1565
9a900ca9
PE
1566 * xterm.c (x_draw_underwave): Check for integer overflow.
1567 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1568
41b7f8bc 15692012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1570
1571 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1572 referenced (Bug#11583).
1573
9b0e3eba
AA
15742012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1575
1576 Implement wave-style variant of underlining.
1577 * dispextern.h (face_underline_type): New enum.
1578 (face): Add field for underline type.
1579 * nsterm.m (ns_draw_underwave): New function.
1580 (ns_draw_text_decoration): Use it.
1581 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1582 New functions.
1583 (x_draw_glyph_string): Use them.
1584 * xfaces.c (Qline, Qwave): New Lisp objects.
1585 (check_lface_attrs, merge_face_ref)
1053a871
SM
1586 (Finternal_set_lisp_face_attribute, realize_x_face):
1587 Handle wave-style underline face attributes.
9b0e3eba
AA
1588 * xterm.c (x_draw_underwave): New function.
1589 (x_draw_glyph_string): Use it.
1590
0fb52f11
JB
15912012-06-16 Juanma Barranquero <lekktu@gmail.com>
1592
1593 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1594 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1595 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1596 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1597 ($(BLD)/w32select.$(O)): Update dependencies.
1598
e5560ff7
AS
15992012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1600
1601 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1602 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1603 * character.c (_fetch_multibyte_char_p): Remove.
1604 * alloc.c: Include "character.h" before "buffer.h".
1605 * bidi.c: Likewise.
1606 * buffer.c: Likewise.
1607 * bytecode.c: Likewise.
1608 * callint.c: Likewise.
1609 * callproc.c: Likewise.
1610 * casefiddle.c: Likewise.
1611 * casetab.c: Likewise.
1612 * category.c: Likewise.
1613 * cmds.c: Likewise.
1614 * coding.c: Likewise.
1615 * composite.c: Likewise.
1616 * dired.c: Likewise.
1617 * dispnew.c: Likewise.
1618 * doc.c: Likewise.
1619 * dosfns.c: Likewise.
1620 * editfns.c: Likewise.
1621 * emacs.c: Likewise.
1622 * fileio.c: Likewise.
1623 * filelock.c: Likewise.
1624 * font.c: Likewise.
1625 * fontset.c: Likewise.
1626 * fringe.c: Likewise.
1627 * indent.c: Likewise.
1628 * insdel.c: Likewise.
1629 * intervals.c: Likewise.
1630 * keyboard.c: Likewise.
1631 * keymap.c: Likewise.
1632 * lread.c: Likewise.
1633 * macros.c: Likewise.
1634 * marker.c: Likewise.
1635 * minibuf.c: Likewise.
1636 * nsfns.m: Likewise.
1637 * nsmenu.m: Likewise.
1638 * print.c: Likewise.
1639 * process.c: Likewise.
1640 * regex.c: Likewise.
1641 * region-cache.c: Likewise.
1642 * search.c: Likewise.
1643 * syntax.c: Likewise.
1644 * term.c: Likewise.
1645 * textprop.c: Likewise.
1646 * undo.c: Likewise.
1647 * unexsol.c: Likewise.
1648 * w16select.c: Likewise.
1649 * w32fns.c: Likewise.
1650 * w32menu.c: Likewise.
1651 * window.c: Likewise.
1652 * xdisp.c: Likewise.
1653 * xfns.c: Likewise.
1654 * xmenu.c: Likewise.
1655 * xml.c: Likewise.
1656 * xselect.c: Likewise.
1657
2f07e6af
EZ
16582012-06-16 Eli Zaretskii <eliz@gnu.org>
1659
1053a871
SM
1660 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1661 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1662 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1663 row.
1664 (handle_face_prop): Use chunk-relative overlay string index when
1665 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1666 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1667 the rightmost. (Bug#11720)
2f07e6af 1668
29b83cec
AS
16692012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1670
1671 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1672 (CATEGORY_MEMBER): Enforce 1/0 value.
1673 * category.c (_temp_category_set): Remove.
1674
4c5501e9
EZ
16752012-06-16 Eli Zaretskii <eliz@gnu.org>
1676
1677 * window.c (Fdelete_other_windows_internal)
1678 (Fdelete_window_internal): Don't access frame's mouse highlight
1679 info of the initial frame. (Bug#11677)
1680
2b570124
PE
16812012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1682
e93864f9
PE
1683 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1684 Assume USE_2_TAGS_FOR_INTS.
1685 (xreload): Adjust $tagmask width to match recent lisp.h change.
1686
2b570124
PE
1687 Simplify lisp.h in minor ways that should not affect code.
1688 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1689 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1690 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1691 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1692 (INTTYPEBITS): New macro, for clarity.
1693 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1694 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1695 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1696 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1697 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1698
81755f69
JB
16992012-06-13 Juanma Barranquero <lekktu@gmail.com>
1700
1701 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1702
16192a57
GM
17032012-06-13 Glenn Morris <rgm@gnu.org>
1704
1705 * s/bsd-common.h (BSD4_3):
1706 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1707
646b5f55
AS
17082012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1709
1710 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1711 instead of union.
1712 (XLI, XIL): Define.
1053a871
SM
1713 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1714 Use them.
1715 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1716 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1717 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1718 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1719 * frame.c (delete_frame): Remove outdated comment.
1720 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1721 USE_LISP_UNION_TYPE.
1722 (Fw32_unregister_hot_key): Likewise.
1723 (Fw32_toggle_lock_key): Likewise.
1724 * w32menu.c (add_menu_item): Likewise.
1725 (w32_menu_display_help): Use XIL instead of checking
1726 USE_LISP_UNION_TYPE.
1727 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1728 (init_heap): Likewise.
1729 * w32term.c (w32_read_socket): Update comment.
1730
1d3823c9
GM
17312012-06-13 Glenn Morris <rgm@gnu.org>
1732
c62ff706
GM
1733 * s/usg5-4-common.h, src/s/unixware.h:
1734 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1735
1d3823c9
GM
1736 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1737
bfe3e0a2
PE
17382012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1741 * alloc.c (make_number) [!defined make_number]:
1742 Remove, as lisp.h always defines this now.
1743 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1744 (roundup_size): Verify that it is a power of 2.
1745 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1746 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1747 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1748 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1749 USE_LSB_TAG now is always defined to be either 0 or 1.
1750 All uses changed.
1751 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1752 code works fine either way, and efficiency is not a concern here,
1753 as the union type is for debugging, not for production.
1754 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1755 Use an inline function on all platforms when using the union type,
1756 since this is simpler and 'static inline' can be used portably
1757 within Emacs now.
1758 (LISP_INITIALLY_ZERO): New macro.
1759 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1760 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1761
45fa9c0f
GM
17622012-06-12 Glenn Morris <rgm@gnu.org>
1763
b4492cba
GM
1764 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1765
1766 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1767
45fa9c0f
GM
1768 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1769 Move BROKEN_SIGIO to configure.
1770
1771 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1772 Move NO_TERMIO to configure.
1773
0e25d334
CY
17742012-06-12 Chong Yidong <cyd@gnu.org>
1775
1776 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1777 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1778 MagickExportImagePixels is undefined.
1779
43682bb6
PE
17802012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 * image.c (imagemagick_load_image): Remove unused label.
1783
a9be7d2b
GM
17842012-06-11 Glenn Morris <rgm@gnu.org>
1785
1786 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1787 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1788 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1789 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1790
3017f87f
SM
17912012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1792
1793 * alloc.c (make_byte_code): New function.
1794 (Fmake_byte_code): Use it. Don't purify here.
1795 * lread.c (read1): Use it as well to avoid extra allocation.
1796
1b9b4cf4
CY
17972012-06-11 Chong Yidong <cyd@gnu.org>
1798
1799 * image.c (imagemagick_load_image): Implement transparency.
1800
95988fcf
AS
18012012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1802
1803 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1804 account for preceding backslashes. (Bug#11663)
1805
cd4eb164
CY
18062012-06-09 Chong Yidong <cyd@gnu.org>
1807
1808 * term.c: Support italics in capable terminals (Bug#9652).
1809 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1810 (turn_on_face): Output using TS_enter_italic_mode if available.
1811 Don't handle unused blinking and alt-charset cases.
1812 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1813 and tty_alt_charset_p cases.
1814 (tty_capable_p, init_tty): Support italics.
1815
1816 * termchar.h (struct tty_display_info): Add field for italics.
1817 Remove unused blink field.
1818
1819 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1820 Handle slant.
1821
1822 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1823 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1824 tty_alt_charset_p. Add tty_italic_p.
1825
ff88beb8
MA
18262012-06-09 Michael Albinus <michael.albinus@gmx.de>
1827
1828 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1829 dbus_type_is_basic if available.
1830 (xd_extract_signed, xd_extract_unsigned): Rename from
1831 extract_signed and extract_unsigned, respectively. Adapt callers.
1832
44286096
CY
18332012-06-09 Chong Yidong <cyd@gnu.org>
1834
1682701f
CY
1835 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1836
44286096
CY
1837 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1838 case (Bug#9752).
1839
d86feb17
PE
18402012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 * xdisp.c (vmessage): Treat frame message as multibyte.
1843 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1844 would generate the diagnostic "Making \302\247 buffer-local while
1845 let-bound!".
1846
d5c20fe8
EZ
18472012-06-08 Eli Zaretskii <eliz@gnu.org>
1848
1849 * dispnew.c (showing_window_margins_p): Undo last change, which
1850 was done due to an inadvertent commit.
1851 (adjust_frame_glyphs_for_frame_redisplay): Do call
1852 showing_window_margins_p.
1853
513749ee
SM
18542012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1855
1856 * eval.c (Fmake_var_non_special): New primitive.
1857 (syms_of_eval): Defsubr it.
1858 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1859
d4a8f5c1
JB
18602012-06-08 Juanma Barranquero <lekktu@gmail.com>
1861
1862 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1863 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1864
8bbbc977
EZ
18652012-06-08 Eli Zaretskii <eliz@gnu.org>
1866
1867 * alloc.c (allocate_vectorlike): Fix last change.
1868
f3372c87
DA
18692012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1870
1871 Block-based vector allocation of small vectors.
1872 * lisp.h (struct vectorlike_header): New field `nbytes',
1873 adjust comment accordingly.
1874 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1875 to denote vector blocks. Adjust users (live_vector_p,
1876 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1877 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1878 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1879 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1880 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1881 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1882 (roundup_size): New constant.
1883 (struct vector_block): New data type.
1884 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1885 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1886 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1887 (sweep_vectors): New functions.
1888 (allocate_vectorlike): Return `zero_vector' as the only vector of
1889 0 items. Allocate new vector from block if vector size is less than
1890 or equal to VBLOCK_BYTES_MAX.
1891 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1892 (init_alloc_once): Add call to init_vectors.
1893
4f18a4ed
SM
18942012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1895
1896 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1897
86f158bc
PE
18982012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1899
1900 * doprnt.c (doprnt): Truncate multibyte char correctly.
1901 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1902 would mishandle a string argument "Xc" if X was a multibyte
1903 character of length 2: it would truncate after X's first byte
1904 rather than including all of X.
1905
c5cfcbe0
CY
19062012-06-06 Chong Yidong <cyd@gnu.org>
1907
1908 * buffer.c (word_wrap): Doc fix.
1909
c05cf390
PE
19102012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1911
1912 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1913
0c3461de
GM
19142012-06-03 Glenn Morris <rgm@gnu.org>
1915
1916 * xdisp.c (tool-bar-style): Doc fix.
1917
c71232db
UM
19182012-06-03 Ulrich Müller <ulm@gentoo.org>
1919
1920 * Makefile.in (PAXCTL): Define.
1921 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1922 binary via PaX flags if the paxctl utility is available.
1923 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1924 Restore PaX flags to their default. (Bug#11398)
1925
383f7350
CY
19262012-06-03 Chong Yidong <cyd@gnu.org>
1927
1928 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1929 buffer (Bug#11226).
1930
5f2c76c6
CY
19312012-06-03 Chong Yidong <cyd@gnu.org>
1932
1933 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1934 (note_mode_line_or_margin_highlight): If there is no help echo,
1935 use mode-line-default-help-echo. Handle the case where the mouse
1936 position is past the end of the mode line string.
1937
1938 * buffer.c (buffer_local_value_1): New function, split from
1939 Fbuffer_local_value; can return Qunbound.
1940 (Fbuffer_local_value): Use it.
1941 (Vmode_line_format): Docstring tweaks.
1942
773d47f6
PE
19432012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 * sysdep.c (system_process_attributes): Improve comment.
1946
f2d6a3df
SM
19472012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1948
1949 * keyboard.c: Export real-this-command to Elisp.
1950 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1951 and DEFVAR it. Update all users.
1952
63810350
PE
19532012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1954
7bd5c1f4
PE
1955 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1956
63810350
PE
1957 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1958 Convert pctcpu and pctmem to Lisp float properly.
1959 Let the compiler fold better, as 100.0/0x8000 is exact.
1960
a2821611
AS
19612012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1962
1963 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1964 cons_block.
1965
5fceba1d
PE
19662012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1967
1968 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1969
c98ff5dd
DA
19702012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1971
1972 For a 'struct window', replace some Lisp_Object fields to
1973 bitfields where appropriate, remove unused fields.
1974 * window.h (struct window): Remove unused 'last_mark_x' and
1975 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1976 change it's type from Lisp_Object to bitfield.
1977 Change type of 'force_start', 'optional_new_start',
1978 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1979 fields from Lisp_Object to bitfield. Adjust users accordingly.
1980
ca34e0be
PE
19812012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 Pacify gcc -Wdouble-precision when using Xaw.
1984 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1985 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1986 Use 'float' consistently, rather than 'float' in most places
1987 and 'double' in a couple of places.
1988
efc00ab1 19892012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1990
1991 * xdisp.c (handle_stop): Detect whether we have overlay strings
1992 loaded by testing it->current.overlay_string_index to be
1993 non-negative, instead of checking whether n_overlay_strings is
1994 positive. (Bug#11587)
1995
efc00ab1 19962012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1997
1998 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1999
2000 * doc.c (Fsubstitute_command_keys): Doc fix.
2001
efc00ab1 20022012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2003
2004 * search.c (search_buffer): Remove calls to
2005 r_alloc_inhibit_buffer_relocation, as it is now called by
2006 maybe_unify_char, which was the cause of relocation of buffer text
2007 in bug#11519.
2008
efc00ab1 20092012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2010
2011 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2012 for the duration of call to load_charset, to avoid problems with
2013 callers of maybe_unify_char that access buffer text through C
2014 pointers.
2015
2016 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2017 decrement the inhibition flag, instead of just setting or
2018 resetting it.
2019
ba93a187
PE
20202012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 Remove obsolete '#define static' cruft.
2023 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2024 This #undef was "temporary" in 2000; it is no longer needed
2025 now that '#define static' has gone away.
2026 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2027 (gray_bitmap_bits): Remove; no longer needed.
2028 All uses replaced with definiens.
2029 * xterm.c: Include "bitmaps/gray.xbm".
2030
9e4bf381
PE
20312012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 Clean up __executable_start, monstartup when --enable-profiling.
2034 The following changes affect the code only when profiling.
2035 * dispnew.c (__executable_start): Rename from safe_bcopy.
2036 Define only on platforms that need it.
2037 * emacs.c: Include <sys/gmon.h> when profiling.
2038 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2039 (__executable_start): Remove decl, since lisp.h does it now.
2040 (safe_bcopy): Remove decl; no longer has that name.
2041 (main): Coalesce #if into single bit of code, for simplicity.
2042 Cast pointers to uintptr_t, since standard libraries want integers
2043 and not pointers.
2044 * lisp.h (__executable_start): New decl.
2045
32d72c2f
GM
20462012-05-31 Glenn Morris <rgm@gnu.org>
2047
2048 * image.c (Fimagemagick_types): Doc fix.
2049
baac5bc7
JM
20502012-05-30 Jim Meyering <meyering@redhat.com>
2051
2052 * callproc.c (Fcall_process_region): Include directory component
2053 in mkstemp error message (Bug#11586).
2054
72cb32cf
PE
20552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 * alloc.c, lisp.h (make_pure_vector): Now static.
2058
61b108cc
SM
20592012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2062 Move to byte-run.el.
2063 (Fautoload): Do the hash-doc more carefully.
2064 * data.c (Fdefalias): Purify definition, except for keymaps.
2065 (Qdefun): Move from eval.c.
2066 * lisp.h (Qdefun): Remove.
2067 * lread.c (read1): Tiny simplification.
2068
471fe23d
TN
20692012-05-29 Troels Nielsen <bn.troels@gmail.com>
2070
934f3f58 2071 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2072 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2073 Bug#9642, but explicitly check that the buffer the overlay would
2074 be moved to is live and rearrange lines to make sure that errors
2075 will not put the overlay in an inconsistent state.
2076 (Fdelete_overlay): Cosmetics.
2077
85d0efd1
EZ
20782012-05-28 Eli Zaretskii <eliz@gnu.org>
2079
2080 * w32term.c (my_bring_window_to_top): New function.
2081 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2082 could be different from the original one.
2083 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2084 (Bug#11513)
2085
2086 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2087 by calling BringWindowToTop.
2088
2089 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2090 (WM_EMACS_END): Increase by one.
2091
da92a98c
PE
20922012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2095 This avoids undefined behavior that might cause the eassert
2096 to not catch an out-of-range value.
2097
74d1f848
JB
20982012-05-28 Juanma Barranquero <lekktu@gmail.com>
2099
2100 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2101 Update dependencies.
2102
9e1a06fc
EZ
21032012-05-27 Eli Zaretskii <eliz@gnu.org>
2104
2105 * bidi.c (bidi_mirror_char): Fix last change.
2106
f3dd7312
AS
21072012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2108
2109 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2110 when referring to sectname field in printf format.
2111
81899c91
PE
21122012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2113
57b81a9f
PE
2114 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2115 Only r_alloc_inhibit_buffer_relocation needed to be added;
2116 the others were already declared.
2117
81899c91
PE
2118 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2119 before checking whether it's out of range. Put the check inside
2120 eassert. See
2121 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2122
33017faf 21232012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2124
2125 * callproc.c (Fcall_process): Restore a line that was accidentally
2126 commented out in the 2011-02-13 change (bug#11547).
2127
33017faf 21282012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2129
2130 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2131 defined on ralloc.c.
2132
2133 * buffer.c [REL_ALLOC]: Remove prototypes of
2134 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2135 they are now on lisp.h.
2136
2137 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2138
2139 * search.c (search_buffer): Use it to inhibit relocation of buffer
2140 text while re_search_2 is doing its job, because re_search_2 is
2141 passed C pointers to buffer text. (Bug#11519)
2142
23415acf
EZ
2143 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2144 Update value to 24.
2145
44e27368
EZ
2146 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2147 state after an additional call to move_it_in_display_line_to, keep
2148 the values of it->max_ascent and it->max_descent found for the
2149 entire line.
2150 (pos_visible_p): Revert the comparison against bottom_y to what it
2151 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2152 (Bug#11464)
2153
c1892f11
PE
21542012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 Fix coding-related core dumps with gcc -ftrapv.
2157 The code was computing A - B, where A and B are pointers, and B is
2158 random garbage. This can lead to core dumps on platforms that
2159 have special pointer registers, and it also leads to core dumps on
2160 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2161 A - B only when B is initialized properly.
2162 * coding.c (coding_set_source, coding_set_destination): Return void.
2163 (coding_change_source, coding_change_destinations): New functions,
2164 with the old behaviors of coding_set_source and coding_set_destination.
2165 All callers that need an offset changed to use these new functions.
2166
eb7afdad
GM
21672012-05-26 Glenn Morris <rgm@gnu.org>
2168
2169 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2170
f12fdf02
EZ
21712012-05-26 Eli Zaretskii <eliz@gnu.org>
2172
53a63be6 2173 Extend mouse support on W32 text-mode console.
61b108cc
SM
2174 * xdisp.c (draw_row_with_mouse_face):
2175 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2176
eb3f6f01 2177 * w32console.c: Include window.h.
61b108cc
SM
2178 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2179 New functions.
eb3f6f01
EZ
2180 (initialize_w32_display): Initialize mouse-highlight data.
2181
53a63be6
EZ
2182 * w32inevt.c: Include termchar.h and window.h.
2183 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2184 moves, call note_mouse_highlight. If help_echo changed, call
2185 gen_help_event to produce help-echo message in the echo area.
2186 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2187 highlight info.
2188
4cfd81f6
PE
21892012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2190
2191 * lread.c (read1): Simplify slightly to avoid an overflow warning
2192 with GCC 4.7.0 on x86-64.
2193
4446092a
EZ
21942012-05-26 Eli Zaretskii <eliz@gnu.org>
2195
2196 * bidi.c (bidi_mirror_char): Revert last change: an int is
2197 definitely wide enough here.
2198
42b2a986 21992012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2200
42b2a986 2201 Fix integer width and related bugs (Bug#9874).
eb106a49 2202 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2203 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2204 (string_bytes, check_sblock, allocate_string_data):
2205 (compact_small_strings, Fmake_bool_vector, make_string)
2206 (make_unibyte_string, make_multibyte_string)
2207 (make_string_from_bytes, make_specified_string)
2208 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2209 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2210 (mark_vectorlike):
2211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2212 (allocate_pseudovector):
2213 Use int, not EMACS_INT, where int is wide enough.
2214 (inhibit_garbage_collection, Fgarbage_collect):
2215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2216 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2217 int might not be wide enough.
2218 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2219 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2220 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2221 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2222 (bidi_level_of_next_char, bidi_move_to_visually_next):
2223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2224 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2225 (Fkill_buffer, Fset_buffer_major_mode)
2226 (advance_to_char_boundary, Fbuffer_swap_text)
2227 (Fset_buffer_multibyte, overlays_at, overlays_in)
2228 (overlay_touches_p, struct sortvec, record_overlay_string)
2229 (overlay_strings, recenter_overlay_lists)
2230 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2231 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2232 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2233 (Foverlay_recenter, last_overlay_modification_hooks_used)
2234 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2236 (validate_region): Omit unnecessary test for b <= e,
2237 since that's guaranteed by the previous test.
d311d28c
PE
2238 (adjust_overlays_for_delete): Avoid pos + length overflow.
2239 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2240 (report_overlay_modification):
2241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2242 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2243 Omit pointer cast, which isn't needed anyway, and doesn't work
2244 after the EMACS_INT -> ptrdiff_t change.
02481186 2245 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2246 * buffer.h: Adjust decls to match defn changes elsewhere.
2247 (struct buffer_text, struct buffer):
2248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2249 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2250 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2251 not int, to avoid needless 32-bit limit on 64-bit hosts.
2252 (exec_byte_code): Use tighter memory-full test, one that checks
2253 for alloca overflow. Don't compute the address of the object just
2254 before an array, as that's not portable. Use EMACS_INT, not
2255 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2256 * callint.c (Fcall_interactively):
2257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2258 * callproc.c (call_process_kill, Fcall_process):
2259 Don't assume pid_t fits into an Emacs fixnum.
2260 (call_process_cleanup, Fcall_process, child_setup):
2261 Don't assume pid_t fits into int.
2262 (call_process_cleanup, Fcall_process, delete_temp_file)
2263 (Fcall_process_region):
2264 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2265 (Fcall_process): Simplify handling of volatile integers.
2266 Use int, not EMACS_INT, where int will do.
2267 * casefiddle.c (casify_object, casify_region, operate_on_word)
2268 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2270 (casify_object): Avoid integer overflow when overallocating buffer.
2271 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2272 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2273 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2274 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2275 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2276 integers are now checked earlier. All uses replaced with XINT.
2277 (ccl_driver):
2278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2279 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2280 (ccl_driver, Fregister_code_conversion_map):
2281 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2282 (resolve_symbol_ccl_program): Check that vector header is in range.
2283 Always copy the vector, so that we can check its contents reliably
2284 now rather than having to recheck each instruction as it's being
2285 executed. Check that vector words fit in 'int'.
2286 (ccl_get_compiled_code, Fregister_ccl_program)
2287 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2288 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2289 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2290 contents are in range.
2291 (Fccl_execute_on_string): Check that status is in range.
2292 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2293 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2294 Accept and return EMACS_INT, not int, because callers can pass values
2295 out of 'int' range.
2296 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2297 (multibyte_chars_in_text, parse_str_as_multibyte)
2298 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2299 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2300 (string_escape_byte8, Fget_byte):
2301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2302 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2303 avoid mishandling large integers.
2304 * character.h: Adjust decls to match defn changes elsewhere.
2305 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2306 (Ffind_charset_region):
2307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2308 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2309 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2310 Don't assume fixnum fits in int.
d311d28c
PE
2311 (load_charset_map_from_vector, Fmap_charset_chars):
2312 Remove now-unnecessary CHECK_NATNUMs.
2313 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2314 Don't rely on undefined behavior with signed left shift overflow.
2315 Don't assume unsigned int fits into fixnum, or that fixnum fits
2316 into unsigned int. Don't require max_code to be a valid fixnum;
2317 that's not true for gb10830 4-byte on a 32-bit host. Allow
2318 invalid_code to be a cons, for the same reason. Require code_offset
2319 to be a character. Avoid int overflow if max_char is close
2320 to INT_MAX.
2321 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2322 this is intended anyway and avoids some undefined behavior.
2323 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2324 INDEX_TO_CODE_POINT, as that's what it expects.
2325 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2326 * charset.h (DECODE_CHAR): Return int, not unsigned;
2327 this is what was intended anyway, and it avoids undefined behavior.
2328 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2329 integer-overflow issues.
2330 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2331 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2332 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2333 * chartab.c (Fmake_char_table, Fset_char_table_range)
2334 (uniprop_get_decoder, uniprop_get_encoder):
2335 Don't assume fixnum fits in int.
2336 * cmds.c (move_point): New function, that does the gist of
2337 Fforward_char and Fbackward_char, but does so while checking
2338 for integer overflow more accurately.
c96e5d6a 2339 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2340 (Fforward_line, Fend_of_line, internal_self_insert)
2341 (internal_self_insert):
2342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2343 Fix a FIXME, by checking for integer overflow when calculating
2344 target_clm and actual_clm.
2345 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2346 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2347 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2348 (coding_alloc_by_making_gap, alloc_destination)
2349 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2350 (encode_coding_utf_16, detect_coding_emacs_mule)
2351 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2352 (detect_coding_iso_2022, decode_coding_iso_2022)
2353 (encode_invocation_designation, encode_designation_at_bol)
2354 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2355 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2356 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2357 (encode_coding_ccl, encode_coding_raw_text)
2358 (detect_coding_charset, decode_coding_charset)
2359 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2360 (produce_composition, produce_charset, produce_annotation)
2361 (decode_coding, handle_composition_annotation)
2362 (handle_charset_annotation, consume_chars, decode_coding_gap)
2363 (decode_coding_object, encode_coding_object, detect_coding_system)
2364 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2365 (code_convert_region, code_convert_string)
8f50130c
PE
2366 (Fdefine_coding_system_internal)
2367 (coding_set_source, coding_set_destination):
d311d28c
PE
2368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2369 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2370 (Fdefine_coding_system_internal):
2371 Don't assume fixnums fit in int.
2372 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2373 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2374 (Funencodable_char_position, Fcheck_coding_systems_region)
2375 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2377 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2378 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2379 Don't access memory outside of the args array.
d311d28c 2380 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2381 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2382 result of ENCODE_CHAR.
d311d28c
PE
2383 * coding.h: Adjust decls to match defn changes elsewhere.
2384 (struct coding_system):
2385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2386 * composite.c (get_composition_id, find_composition)
2387 (run_composition_function, update_compositions)
2388 (compose_text, composition_gstring_put_cache)
2389 (composition_gstring_p, composition_gstring_width)
2390 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2391 (composition_compute_stop_pos, composition_reseat_it)
2392 (composition_update_it, struct position_record)
2393 (find_automatic_composition, composition_adjust_point)
2394 (Fcomposition_get_gstring, Ffind_composition_internal):
2395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2396 (update_compositions):
2397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2398 * composite.h: Adjust decls to match defn changes elsewhere.
2399 (struct composition):
2400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2401 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2402 Do not attempt to compute the address of the object just before a
2403 buffer; this is not portable.
2404 (Faref, Faset):
2405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2406 (Faset): Use int, not EMACS_INT, where int is wide enough.
2407 (Fstring_to_number): Don't assume fixnums fit in int.
2408 (Frem): Don't assume arg is nonnegative.
2409 * dbusbind.c (xd_append_arg): Check for integers out of range.
2410 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2411 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2412 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2413 (xd_get_connection_references): Return ptrdiff_t, not int.
2414 All uses changed.
2415 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2416 (xd_read_message_1):
2417 Use int, not unsigned, where the dbus API uses int.
2418 (Fdbus_message_internal): Don't overflow mtype.
2419 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2420 * dired.c (directory_files_internal, file_name_completion, scmp)
2421 (file_name_completion_stat):
2422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2423 (file_name_completion): Don't overflow matchcount.
2424 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2425 * dispextern.h: Adjust decls to match defn changes elsewhere.
2426 (struct text_pos, struct glyph, struct bidi_saved_info)
2427 (struct bidi_string_data, struct bidi_it, struct composition_it)
2428 (struct it):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2430 (struct display_pos, struct composition_it, struct it):
2431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2432 * dispnew.c (increment_matrix_positions)
2433 (increment_row_positions, mode_line_string)
2434 (marginal_area_string):
2435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2436 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2438 (duration_to_sec_usec): New function, to check for overflow better.
2439 (Fsleep_for, sit_for): Use it.
2440 * doc.c (get_doc_string, store_function_docstring):
2441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2442 (get_doc_string, Fsnarf_documentation):
2443 Use int, not EMACS_INT, where int is wide enough.
2444 (get_doc_string):
2445 Use SAFE_ALLOCA, not alloca.
2446 Check for overflow when converting EMACS_INT to off_t.
2447 * doprnt.c (doprnt):
2448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2449 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2450 Don't assume uid_t fits into fixnum.
2451 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2452 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2453 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2454 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2455 (general_insert_function)
2456 (Finsert_char, make_buffer_string, make_buffer_string_both)
2457 (update_buffer_properties, Fbuffer_substring)
2458 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2459 (Fsubst_char_in_region, check_translation)
2460 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2461 (transpose_markers, Ftranspose_regions):
2462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2463 (clip_to_bounds): Move to lisp.h as an inline function).
2464 (Fconstrain_to_field): Don't assume integers are nonnegative.
2465 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2466 (Fsubst_char_in_region, Fsave_restriction):
2467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2468 (Femacs_pid): Don't assume pid_t fits into fixnum.
2469 (lo_time): Use int, not EMACS_INT, when int suffices.
2470 (lisp_time_argument): Check for usec out of range.
2471 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2472 (Fuser_login_name, Fuser_full_name): Signal an error
2473 if a uid argument is out of range, rather than relying on
2474 undefined behavior.
c8d5c857
PE
2475 (Fformat_time_string): Remove now-unnecessary check.
2476 lisp_time_argument checks for out-of-range usec now.
243e0530 2477 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2478 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2479 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2480 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2481 (init_cmdargs, Fdump_emacs):
2482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2483 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2484 the bottom (typically) 32 bits of the fixnum.
2485 * eval.c (specpdl_size, call_debugger):
2486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2487 (when_entered_debugger, Fbacktrace_debug):
2488 Don't assume fixnum can fit in int.
2489 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2490 the object just before a buffer; this is not portable.
2491 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2492 (grow_specpdl, unbind_to):
2493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2494 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2495 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2496 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2497 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2498 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2500 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2501 (a_write, e_write):
2502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2503 (Fcopy_file, non_regular_nbytes, read_non_regular)
2504 (Finsert_file_contents):
2505 Use int, not EMACS_INT, where int is wide enough.
2506 (READ_BUF_SIZE): Verify that it fits in int.
2507 (Finsert_file_contents): Check that counts are in proper range,
2508 rather than assuming fixnums fit into ptrdiff_t etc.
2509 Don't assume fixnums fit into int.
125b3835 2510 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2511 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2512 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2513 (string_char_to_byte, string_byte_to_char)
2514 (string_make_multibyte, string_to_multibyte)
2515 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2516 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2517 (substring_both, Fdelete, internal_equal, Ffillarray)
2518 (Fclear_string, mapcar1)
2519 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2520 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2521 (larger_vector, make_hash_table, maybe_resize_hash_table)
2522 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2523 (Fmaphash, secure_hash):
2524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2525 (concat): Check for string index and length overflow.
2526 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2527 (Frequire):
2528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2529 (larger_vector): New API (vec, incr_min, size_max) replaces old
2530 one (vec, new_size, init). This catches size overflow.
2531 INIT was removed because it was always Qnil.
2532 All callers changed.
2533 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2534 the upper bound on a hash table index size.
2535 (make_hash_table, maybe_resize_hash_table): Use it.
2536 (secure_hash): Computer start_byte and end_byte only after
2537 they're known to be in ptrdiff_t range.
2538 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2539 (Ffont_get_glyphs, Ffont_at):
2540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2541 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2542 (Flist_fonts, Fopen_font):
2543 Don't assume fixnum can fit in int.
2544 (check_gstring): Don't assume index can fit in int.
2545 (font_match_p): Check that fixnum is a character, not a nonnegative
2546 fixnum, since the later code needs to stuff it into an int.
2547 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2548 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2549 conversion overflow issues.
2550 (Fopen_font): Check for integer out of range.
2551 (Ffont_get_glyphs): Don't assume index can fit in int.
2552 * font.h: Adjust decls to match defn changes elsewhere.
2553 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2554 integer overflow.
2555 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2556 printmax_t, where ptrdiff_t is wide enough.
2557 (Finternal_char_font):
2558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2559 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2560 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2561 (Fset_frame_position, x_set_frame_parameters)
2562 (x_set_line_spacing, x_set_border_width)
2563 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2564 Check that fixnums are in proper range for system types.
2565 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2567 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2568 Use SAFE_ALLOCA_LISP, not alloca.
2569 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2570 intptr_t is wide enough.
2571 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2572 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2573 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2574 Check for fixnum out of range.
2575 * ftfont.c (ftfont_list): Don't assume index fits in int.
2576 Check that fixnums are in proper range for system types.
2577 (ftfont_shape_by_flt):
2578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2579 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2581 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2582 Check that fixnums are in proper range for system types.
2583 * gnutls.h: Adjust decls to match defn changes elsewhere.
2584 * gtkutil.c (xg_dialog_run):
2585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2586 (update_frame_tool_bar):
2587 Check that fixnums are in proper range for system types.
2588 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2589 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2590 * indent.c (last_known_column, last_known_column_point):
2591 (current_column_bol_cache):
2592 (skip_invisible, current_column, check_display_width):
2593 (check_display_width, scan_for_column, current_column_1)
2594 (Findent_to, Fcurrent_indentation, position_indentation)
2595 (indented_beyond_p, Fmove_to_column, compute_motion):
2596 (Fcompute_motion, Fvertical_motion):
2597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2598 (last_known_column_modified): Use EMACS_INT, not int.
2599 (check_display_width):
2600 (Fcompute_motion):
2601 Check that fixnums and floats are in proper range for system types.
2602 (compute_motion): Don't assume index or fixnum fits in int.
2603 (compute_motion, Fcompute_motion):
2604 Use int, not EMACS_INT, when it is wide enough.
2605 (vmotion): Omit local var start_hpos that is always 0; that way
2606 we don't need to worry about overflow in expressions involving it.
2607 * indent.h: Adjust decls to match defn changes elsewhere.
2608 (struct position):
2609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2610 Use int, not EMACS_INT, where int is wide enough.
2611 Remove unused members ovstring_chars_done and tab_offset;
2612 all uses removed.
2613 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2614 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2615 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2616 (make_gap, copy_text, insert, insert_and_inherit)
2617 (insert_before_markers, insert_before_markers_and_inherit)
2618 (insert_1, count_combining_before, count_combining_after)
2619 (insert_1_both, insert_from_string)
2620 (insert_from_string_before_markers, insert_from_string_1)
2621 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2622 (adjust_after_replace, adjust_after_insert, replace_range)
2623 (replace_range_2, del_range, del_range_1, del_range_byte)
2624 (del_range_both, del_range_2, modify_region)
2625 (prepare_to_modify_buffer, signal_before_change)
2626 (signal_after_change, Fcombine_after_change_execute):
2627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2628 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2629 (balance_an_interval, split_interval_right, split_interval_left)
2630 (find_interval, next_interval, update_interval)
2631 (adjust_intervals_for_insertion, delete_node, delete_interval)
2632 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2633 (static_offset_intervals, offset_intervals)
2634 (merge_interval_right, merge_interval_left, make_new_interval)
2635 (graft_intervals_into_buffer, temp_set_point_both)
2636 (temp_set_point, set_point, adjust_for_invis_intang)
2637 (set_point_both, move_if_not_intangible, get_property_and_range)
2638 (get_local_map, copy_intervals, copy_intervals_to_string)
2639 (compare_string_intervals, set_intervals_multibyte_1):
2640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2641 * intervals.h: Adjust decls to match defn changes elsewhere.
2642 (struct interval):
2643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2644 * keyboard.c (this_command_key_count, this_single_command_key_start)
2645 (before_command_key_count, before_command_echo_length, echo_now)
2646 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2647 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2648 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2649 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2651 (last_non_minibuf_size, last_point_position, echo_truncate)
2652 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2653 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2654 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2655 (stuff_buffered_input):
2656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2657 (last_auto_save, command_loop_1, read_char):
2658 Use EMACS_INT, not int, to avoid integer overflow.
2659 (record_char): Avoid overflow in total_keys computation.
2660 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2661 * keyboard.h: Adjust decls to match defn changes elsewhere.
2662 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2663 (Fkey_description, Fdescribe_vector, Flookup_key):
2664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2665 (click_position): New function, to check that positions are in range.
2666 (Fcurrent_active_maps):
2667 (describe_command):
2668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2669 (Faccessible_keymaps, Fkey_description):
2670 (preferred_sequence_p):
2671 Don't assume fixnum can fit into int.
2672 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2673 Check for integer overflow in size calculations.
2674 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2675 avoid mishandling large integers.
2676 * lisp.h: Adjust decls to match defn changes elsewhere.
2677 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2678 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2679 (struct Lisp_Marker):
2680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2681 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2682 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2683 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2684 All callers changed.
2685 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2686 Assume the arg has valid form, since it always does.
2687 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2688 unsigned integer system type.
2689 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2690 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2692 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2693 (duration_to_sec_usec): New decl.
2694 * lread.c (read_from_string_index, read_from_string_index_byte)
2695 (read_from_string_limit, readchar, unreadchar, openp)
2696 (read_internal_start, read1, oblookup):
2697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2698 (Fload, readevalloop, Feval_buffer, Feval_region):
2699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2700 (openp): Check for out-of-range argument to 'access'.
2701 (read1): Use int, not EMACS_INT, where int is wide enough.
2702 Don't assume fixnum fits into int.
6efdadfd 2703 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2704 (read_filtered_event): Use duration_to_sec_usec
2705 to do proper overflow checking on durations.
d311d28c
PE
2706 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2707 in size calculation.
2708 (Fexecute_kbd_macro):
2709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2710 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2711 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2712 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2713 (set_marker_both, set_marker_restricted_both, marker_position)
2714 (marker_byte_position, Fbuffer_has_markers_at):
2715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2716 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2717 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2718 It now merely ensures that the menu is large enough, without
2719 necessarily growing it, as this avoids some integer overflow issues.
2720 All callers changed.
2721 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2723 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2724 Use SAFE_ALLOCA_LISP, not alloca.
2725 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2726 to EMACS_INT. Check that fixnums are in proper range for system types.
2727 * minibuf.c (minibuf_prompt_width, string_to_object)
2728 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2729 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2731 (get_minibuffer, read_minibuf_unwind):
2732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2733 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2734 this simplifies overflow checking. All callers changed.
2735 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2736 (Ftest_completion):
2737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2738 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2739 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2740 Check that fixnums are in proper range for system types.
2741 (Fx_create_frame, Fx_show_tip):
2742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2743 * nsfont.m (ns_findfonts, nsfont_list_family):
2744 Don't assume fixnum fits in long.
2745 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2747 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2748 wide enough.
17fdb222 2749 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2751 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2752 (PRINTDECLARE, PRINTPREPARE):
2753 (strout, print_string):
2754 (print, print_preprocess, print_check_string_charset_prop)
2755 (print_object):
2756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2757 (PRINTDECLARE):
2758 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2760 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2761 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2762 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2763 (print_error_message): Use SAFE_ALLOCA, not alloca.
2764 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2765 (print_depth, new_backquote_output, print_number_index):
2766 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2767 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2768 (Fset_process_window_size, Fformat_network_address)
2769 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2770 (sigchld_handler):
d311d28c 2771 Check that fixnums are in proper range for system types.
d44287d4 2772 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2773 Check for process-ids out of pid_t range rather than relying on
2774 undefined behavior.
e4d81efc 2775 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2776 (Fformat_network_address, read_process_output, send_process)
2777 (Fprocess_send_region, status_notify):
2778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2779 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2780 (wait_reading_process_output, read_process_output, exec_sentinel):
2781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2782 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2783 (Faccept_process_output): Use duration_to_sec_usec to do proper
2784 overflow checking on durations.
dde14581
PE
2785 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2786 Don't assume pid_t fits in int.
02481186
PE
2787 * process.h (struct Lisp_Process): Members tick and update_tick
2788 are now of type EMACS_INT, not int.
b62b53e8
PE
2789 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2790 configured --with-wide-int.
d311d28c
PE
2791 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2792 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2793 * search.c (looking_at_1, string_match_1):
2794 (fast_string_match, fast_c_string_match_ignore_case)
2795 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2796 (scan_newline, find_before_next_newline, search_command)
2797 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2798 (set_search_regs, wordify):
2799 (Freplace_match):
2800 (Fmatch_data):
2801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2802 (string_match_1, search_buffer, set_search_regs):
2803 (Fmatch_data):
2804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2805 (wordify): Check for overflow in size calculation.
2806 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2807 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2808 Check that fixnums are in proper range for system types.
2809 * sound.c (struct sound_device)
2810 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2812 (Fplay_sound_internal):
2813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2814 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2815 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2816 (Fparse_partial_sexp):
2817 Don't assume fixnums can fit in int.
2818 (struct lisp_parse_state, find_start_pos, find_start_value)
2819 (find_start_value_byte, find_start_begv)
2820 (update_syntax_table, char_quoted, dec_bytepos)
2821 (find_defun_start, prev_char_comend_first, back_comment):
2822 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2823 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2825 (Finternal_describe_syntax_value): Check that match_lisp is a
2826 character, not an integer, since the code stuffs it into int.
2827 (scan_words, scan_sexps_forward):
2828 Check that fixnums are in proper range for system types.
2829 (Fforward_word):
2830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2831 (scan_sexps_forward):
2832 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2833 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2834 * syntax.h: Adjust decls to match defn changes elsewhere.
2835 (struct gl_state_s):
2836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2837 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2838 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2839 * sysdep.c (wait_for_termination_1, wait_for_termination)
2840 (interruptible_wait_for_termination, mkdir):
2841 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2842 (emacs_read, emacs_write):
2843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2844 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2845 and double all fit in int.
d311d28c
PE
2846 * term.c (set_tty_color_mode):
2847 Check that fixnums are in proper range for system types.
2848 * termhooks.h (struct input_event):
2849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2850 * textprop.c (validate_interval_range, interval_of)
2851 (Fadd_text_properties, set_text_properties_1)
2852 (Fremove_text_properties, Fremove_list_of_text_properties)
2853 (Ftext_property_any, Ftext_property_not_all)
2854 (copy_text_properties, text_property_list, extend_property_ranges)
2855 (verify_interval_modification):
2856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2857 (Fnext_single_char_property_change)
2858 (Fprevious_single_char_property_change):
2859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2860 (copy_text_properties):
2861 Check for integer overflow in index calculation.
d311d28c
PE
2862 * undo.c (last_boundary_position, record_point, record_insert)
2863 (record_delete, record_marker_adjustment, record_change)
2864 (record_property_change):
2865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2866 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2868 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2869 (Fx_hide_tip, Fx_file_dialog):
2870 * w32menu.c (set_frame_menubar):
2871 Use ptrdiff_t, not int, for consistency with rest of code.
2872 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2873 (select_window, Fdelete_other_windows_internal)
2874 (window_scroll_pixel_based, window_scroll_line_based)
2875 (Frecenter, Fset_window_configuration):
2876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2877 (Fset_window_hscroll, run_window_configuration_change_hook)
2878 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2879 (Fscroll_other_window, Frecenter):
d311d28c
PE
2880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2881 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2882 Don't assume fixnum fits in int.
2883 (Fset_window_scroll_bars):
2884 Check that fixnums are in proper range for system types.
2885 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2886 (string_pos, c_string_pos, number_of_chars, init_iterator)
2887 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2888 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2889 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2890 (face_before_or_after_it_pos, handle_invisible_prop)
2891 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2892 (display_prop_intangible_p, string_buffer_position_lim)
2893 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2894 (get_overlay_strings_1, get_overlay_strings)
2895 (iterate_out_of_display_property, forward_to_next_line_start)
2896 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2897 (get_next_display_element, set_iterator_to_next)
2898 (get_visually_first_element, compute_stop_pos_backwards)
2899 (handle_stop_backwards, next_element_from_buffer)
2900 (move_it_in_display_line_to, move_it_in_display_line)
2901 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2902 (add_to_log, message_dolog, message_log_check_duplicate)
2903 (message2, message2_nolog, message3, message3_nolog
2904 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2905 (current_message_1, truncate_echo_area, truncate_message_1)
2906 (set_message, set_message_1, store_mode_line_noprop)
2907 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2908 (text_outside_line_unchanged_p, check_point_in_composition)
2909 (reconsider_clip_changes)
2910 (redisplay_internal, set_cursor_from_row, try_scrolling)
2911 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2912 (redisplay_window, find_last_unchanged_at_beg_row)
2913 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2914 (trailing_whitespace_p, find_row_edges, display_line)
2915 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2916 (display_mode_element, store_mode_line_string)
2917 (pint2str, pint2hrstr, decode_mode_spec)
2918 (display_count_lines, display_string, draw_glyphs)
2919 (x_produce_glyphs, x_insert_glyphs)
2920 (rows_from_pos_range, mouse_face_from_buffer_pos)
2921 (fast_find_string_pos, mouse_face_from_string_pos)
2922 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2924 (safe_call, init_from_display_pos, handle_fontified_prop)
2925 (handle_single_display_spec, load_overlay_strings)
2926 (with_echo_area_buffer, setup_echo_area_for_printing)
2927 (display_echo_area, echo_area_display)
2928 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2929 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2930 (redisplay_window, dump_glyph_row, display_mode_line)
2931 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2932 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2934 (handle_single_display_spec, build_desired_tool_bar_string)
2935 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2936 (get_specified_cursor_type):
2937 Check that fixnums are in proper range for system types.
2938 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2939 (Flookup_image_map):
2940 Don't assume fixnums fit in int.
2941 (compare_overlay_entries):
2942 Avoid mishandling comparisons due to subtraction overflow.
2943 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2944 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2945 (handle_tool_bar_click):
2946 Use int, not unsigned, since we prefer signed and the signedness
2947 doesn't matter here.
2948 (get_next_display_element, next_element_from_display_vector):
2949 Use int, not EMACS_INT, when int is wide enough.
2950 (start_hourglass): Use duration_to_sec_usec to do proper
2951 overflow checking on durations.
2952 * xfaces.c (Fbitmap_spec_p):
2953 Check that fixnums are in proper range for system types.
2954 (compare_fonts_by_sort_order):
2955 Avoid mishandling comparisons due to subtraction overflow.
2956 (Fx_family_fonts, realize_basic_faces):
2957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2958 (Fx_family_fonts):
2959 Don't assume fixnum fits in int.
2960 Use SAFE_ALLOCA_LISP, not alloca.
2961 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2962 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2963 (face_at_buffer_position, face_for_overlay_string)
2964 (face_at_string_position):
2965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2966 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2967 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2968 (Fx_show_tip):
2969 Check that fixnums are in proper range for system types.
2970 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2971 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2973 (Fx_change_window_property): Don't assume fixnums fit in int.
2974 * xfont.c (xfont_chars_supported):
2975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2976 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2977 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2978 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2979 * xml.c (parse_region):
2980 * xrdb.c (magic_file_p):
2981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2982 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2983 (x_get_local_selection, x_reply_selection_request)
2984 (x_handle_selection_request, wait_for_property_change):
2985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2986 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2987 short is wide enough.
2988 (x_send_client_event): Don't assume fixnum fits in int.
2989 * xterm.c (x_x_to_emacs_modifiers):
2990 Don't assume EMACS_INT overflows nicely into int.
2991 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2992 may come from Lisp.
2993 (handle_one_xevent): NATNUMP can eval its arg twice.
2994 (x_connection_closed):
2995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2996 * xterm.h: Adjust decls to match defn changes elsewhere.
2997 (struct scroll_bar): Use struct vectorlike_header
2998 rather than rolling our own approximation.
2999 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3000
c6574eb5
GM
30012012-05-25 Glenn Morris <rgm@gnu.org>
3002
3003 * lisp.mk (lisp): Update for more files being compiled now.
3004
e8d32c7e
SM
30052012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3006
48def666
SM
3007 * lread.c: Remove `read_pure' which makes no difference.
3008 (read_pure): Remove var.
3009 (unreadpure): Remove function.
3010 (readevalloop): Don't call read_list with -1 flag.
3011 (read1, read_vector): Don't test read_pure any more.
3012 (read_list): Simplify.
3013
e8d32c7e
SM
3014 * fileio.c, character.h: Minor style tweaks.
3015
4b2addb7
DA
30162012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3017
3018 * window.h (clip_changed): Remove useless declaration.
3019
584461b2
JB
30202012-05-22 Juanma Barranquero <lekktu@gmail.com>
3021
3022 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3023 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3024
34374650
PE
30252012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3026
3027 Remove src/m/*.
3028 This directory predates autoconf and is no longer needed nowadays.
3029 Move its few remaining bits of functionality to where they're needed.
3030 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3031 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3032 * m/template.h: Remove.
3033 * Makefile.in (M_FILE): Remove. All uses removed.
3034 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3035 * lisp.h (USE_LSB_TAG):
3036 * mem-limits.h (EXCEEDS_LISP_PTR):
3037 Use VAL_MAX, not VALBITS, in #if.
3038 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3039 (EMACS_UINT): Define unconditionally now.
3040 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3041 (BITS_PER_EMACS_INT): New constants, replacing
3042 what used to be in config.h, but not useful in #if.
3043 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3044 define them any more.
3045 (VAL_MAX): New macro.
3046 (VALMASK): Use it.
3047 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3048 BITS_PER_EMACS_INT, in #if.
3049 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3050 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3051 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3052 * s/ms-w32.h (DATA_START):
3053 Move here from removed file m/intel386.h.
3054 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3055 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3056
261cb4bb
PE
30572012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 Assume C89 or later.
3060 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3061 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3062 (xrealloc):
3063 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3064 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3065 * textprop.c, tparam.c (NULL): Remove.
3066 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3067 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3068 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3069 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3070 * xterm.c (input_signal_count): Assume volatile works.
3071
ff23cd9f
KB
30722012-05-21 Ken Brown <kbrown@cornell.edu>
3073
3074 * xgselect.c (xg_select): Fix first argument in call to 'select'
3075 (bug#11508).
3076
1b170bc6
KB
30772012-05-20 Ken Brown <kbrown@cornell.edu>
3078
3079 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3080 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3081
b2f4d39f
KB
30822012-05-19 Ken Brown <kbrown@cornell.edu>
3083
3084 * xfns.c (x_in_use): Remove `static' qualifier.
3085 * xterm.h (x_in_use): Declare.
3086 * xgselect.c: Include xterm.h.
3087 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3088 and `display_arg' (bug#9754).
3089
003fdae2
PE
30902012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3091
9232a6d9
PE
3092 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3093
003fdae2
PE
3094 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3095 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3096
784b56e2
EZ
30972012-05-18 Eli Zaretskii <eliz@gnu.org>
3098
3099 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3100
3101 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3102 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3103
3104 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3105 reference to image_cache->refcount.
3106 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3107
a0a79cde
JL
31082012-05-17 Juri Linkov <juri@jurta.org>
3109
3110 * search.c (Fword_search_regexp, Fword_search_backward)
3111 (Fword_search_forward, Fword_search_backward_lax)
3112 (Fword_search_forward_lax): Move functions to isearch.el
3113 (bug#10145, bug#11381).
3114
b0572523
PE
31152012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3118
9660f5fc
SM
31192012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3120
3121 * lread.c (init_obarray): Declare Qt and Qnil as special.
3122
4374de83
GM
31232012-05-14 Glenn Morris <rgm@gnu.org>
3124
3125 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3126 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3127
dc44c39a
PE
31282012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3129
078c97cb
PE
3130 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3131
dc44c39a
PE
3132 * unexaix.c: Port to more-recent AIX compilers.
3133 (report_error, report_error_1, make_hdr, copy_sym)
3134 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3135 Make arguments const char *, not char *, to avoid violations of C
3136 standard and to fix some AIX warnings reported by Gilles Pion.
3137
e18afed7 31382012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3139
3140 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3141 already have overlays loaded.
3142 (handle_single_display_spec): Before returning without displaying
3143 fringe bitmap, synchronize the bidi iterator with the main display
3144 iterator, by calling iterate_out_of_display_property.
3145 (iterate_out_of_display_property): Detect buffer iteration by
3146 testing that it->string is a Lisp string.
3147 (get_next_display_element): When the current object is exhausted,
3148 and there's something on it->stack, call set_iterator_to_next to
3149 proceed with what's on the stack, instead of returning zero.
3150 (set_iterator_to_next): If called at the end of a Lisp string,
3151 proceed to consider_string_end without incrementing string
3152 position. Don't increment display vector index past the end of
3153 the display vector. (Bug#11417)
c8fb9dc6
EZ
3154 (pos_visible_p): Don't report a position visible when move_it_to
3155 stopped at the last line of window, which happens to be scanned
3156 backwards by the bidi iteration. (Bug#11464)
ac268e67 3157
e18afed7 31582012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3159
3160 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3161 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3162 are on a TTY, and thus unable to display on the fringes.
3163 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3164 so we need to signal to the caller that this is a "replacing"
3165 display spec. This fixes display when the spec is invalid or we
3166 are on a TTY.
3167
e18afed7 31682012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3169
3170 * unexaix.c (make_hdr): Fix typo in prototype.
3171 This bug broke the build on AIX. Problem reported by Gilles Pion.
3172
9d0a235a
MA
31732012-05-14 Michael Albinus <michael.albinus@gmx.de>
3174
3175 * keyboard.c (kbd_buffer_get_event): Read special events also in
3176 batch mode. (Bug#11415)
3177
9e6b06ed
GM
31782012-05-12 Glenn Morris <rgm@gnu.org>
3179
3180 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3181
c1a1d7a3
EZ
31822012-05-12 Eli Zaretskii <eliz@gnu.org>
3183
3184 * lisp.mk (lisp): Add newcomment.elc.
3185
3fe7cdc8
GM
31862012-05-12 Glenn Morris <rgm@gnu.org>
3187
3188 * Makefile.in (MKDIR_P): New, set by configure.
3189 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3190
53f7d2c0
PE
31912012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 Remove unused function hourglass_started.
3194 * dispextern.h (hourglass_started):
3195 * w32fns.c (hourglass_started):
3196 * xdisp.c (hourglass_started): Remove.
3197
75aafb17
JB
31982012-05-10 Juanma Barranquero <lekktu@gmail.com>
3199
3200 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3201 Update dependencies.
3202
12959e8e
PE
32032012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3204
97107e2e
PE
3205 * xgselect.c (xg_select): Put maxfds+1 into a var.
3206 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3207
12959e8e
PE
3208 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3209
836d29b3
DA
32102012-05-10 Dave Abrahams <dave@boostpro.com>
3211
3212 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3213 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3214
5cb67954
MA
32152012-05-09 Michael Albinus <michael.albinus@gmx.de>
3216
3217 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3218 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3219 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3220 Initialize xd_registered_buses.
3221
3478ec45
PE
32222012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3223
b263a6b0
PE
3224 Untag more efficiently if USE_LSB_TAG.
3225 This is based on a proposal by YAMAMOTO Mitsuharu in
3226 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3227 For an admittedly artificial (nth 8000 longlist) benchmark on
3228 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3229 Emacs's overall text size by 1%.
3230 * lisp.h (XUNTAG): New macro.
3231 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3232 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3233 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3234 * eval.c (Fautoload):
3235 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3236 * frame.h (XFRAME): Use XUNTAG.
3237
3478ec45
PE
3238 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3239 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3240 Remove unportable assumptions about print widths of types like
3241 dbus_uint32_t.
3242 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3243 intptr_t when converting between pointer and integer, to avoid GCC
3244 warnings about wrong width.
3245
666b903b 32462012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3247
3248 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3249 stack for each reader_thread, instead of defaulting to 8MB
3250 determined by the linker. This avoids failures in creating
3251 subprocesses on Windows 7, see the discussion in this thread:
3252 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3253
b120cc17
JC
32542012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3255
3256 Fix up display of the *Minibuf-0* buffer in the mini window.
3257 * keyboard.c (read_char): Don't clear the echo area if there's no
3258 message to clear.
3259 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3260 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3261
9a4b36f8
MA
32622012-05-07 Michael Albinus <michael.albinus@gmx.de>
3263
3264 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3265 batch mode.
3266
e5f9458f
CY
32672012-05-06 Chong Yidong <cyd@gnu.org>
3268
3269 * lisp.mk (lisp): Update.
3270
eceeb5fc 32712012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3272
3273 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3274
71873e2b
SM
32752012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3276
3277 * data.c (PUT_ERROR): New macro.
3278 (syms_of_data): Use it. Add new error type `user-error'.
3279 * undo.c (user_error): New function.
3280 (Fprimitive_undo): Use it.
3281 * print.c (print_error_message): Adjust print style for `user-error'.
3282 * keyboard.c (user_error): New function.
3283 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3284
ab0fa4e4
PE
32852012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3286
3287 Do not limit current-time-string to years 1000..9999.
3288 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3289 (Fcurrent_time_string): Support any year that is supported by the
3290 underlying localtime representation. Don't use asctime, as it
3291 has undefined behavior for years outside the range -999..9999.
3292
7ed806a7
PE
32932012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3294
3295 Fix race conditions involving setenv, gmtime, localtime, asctime.
3296 Without this fix, interrupts could mess up code that uses these
3297 nonreentrant functions, since setting TZ invalidates existing
3298 tm_zone or tzname values, and since most of these functions return
3299 pointers to static storage.
3300 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3301 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3302 Grow the critical sections to include not just invoking
3303 localtime/gmtime, but also accessing these functions' results
3304 including their tm_zone values if any, and any related TZ setting.
3305 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3306 so that the struct tm is saved in the critical section.
3307 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3308 motivated by the fact that memory allocation needs to be outside
3309 the critical section.
3310
0c16dfed
DA
33112012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3312
3313 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3314 with RESET_INTERVAL.
3315
3316 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3317 Remove duplicated buffer name initialization.
3318
3f83ace8
JM
33192012-05-02 Jim Meyering <jim@meyering.net>
3320
3321 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3322
c7b8541e
JM
3323 * xfns.c (x_window): Use xstrdup (Bug#11375).
3324
90207a15 33252012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3326
3327 * xdisp.c (pos_visible_p): If already at a newline from the
3328 display string before the 'while' loop, don't walk back the glyphs
3329 from it3.glyph_row. Solves assertion violation when the display
3330 string begins with a newline (egg.el). (Bug#11367)
3331
b593d6a9
AH
33322012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3333
3334 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3335 Move to simple.el.
3336
4737362e
GM
33372012-05-01 Glenn Morris <rgm@gnu.org>
3338
99cf43f9
GM
3339 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3340 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3341 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3342 All were removed before 23.1.
3343
9311dcff
GM
3344 * dispnew.c: Remove HAVE_LIBNCURSES test;
3345 it is always true on relevant platforms.
3346
4d5c6349
GM
3347 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3348 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3349
4737362e
GM
3350 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3351
74dd3a6b
AS
33522012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3353
3354 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3355 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3356 Remove.
3357
13c379ee
PE
33582012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3359
3360 Do not avoid creating empty evaporating overlays (Bug#9642).
3361 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3362 That is, do not delete an evaporating overlay if it becomes
3363 empty after its bounds are adjusted to fit within its buffer.
3364 This fix caused other problems, and I'm reverting it until we get
3365 to the bottom of them.
3366
a8e7d6d7 33672012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3368
3369 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3370
a8e7d6d7 33712012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3372
3373 * xdisp.c (pos_visible_p): If the window start position is beyond
3374 ZV, start the display from buffer beginning. Prevents assertion
3375 violation in init_iterator when the minibuffer window is scrolled
3376 via the scroll bar.
3377
3378 * window.c (window_scroll_pixel_based): Likewise.
3379
a8e7d6d7 33802012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3381
3382 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3383
a8e7d6d7 33842012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3385
3386 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3387 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3388
a8e7d6d7 33892012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3390
b593d6a9
AH
3391 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3392 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3393
1c6900d9
EZ
33942012-04-26 Eli Zaretskii <eliz@gnu.org>
3395
4c3fa1d9
EZ
3396 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3397 display element, check also the underlying string or buffer
3398 character. (Bug#11341)
3399
1c6900d9
EZ
3400 * w32menu.c: Include w32heap.h.
3401 (add_menu_item): If the call to AppendMenuW (via
3402 unicode_append_menu) fails, disable Unicode menus only if we are
3403 running on Windows 9X/Me.
3404
42bf8205
AS
34052012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3406
3407 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3408 (xgetint): Add missing shift for LSB tags.
3409
b1bac16e
MR
34102012-04-24 Martin Rudalics <rudalics@gmx.at>
3411
3412 * keyboard.c (read_char): Don't wipe echo area for select window
3413 events: These might get delayed via `mouse-autoselect-window'
3414 (Bug#11304).
3415
d69621cc
JB
34162012-04-24 Juanma Barranquero <lekktu@gmail.com>
3417
3418 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3419 manipulation of :loaded-from data.
3420
02fd101b
JB
34212012-04-23 Juanma Barranquero <lekktu@gmail.com>
3422
3423 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3424 now a cons (bug#11311).
3425
888bec30
PE
34262012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3427
89a438bd
PE
3428 Do not create empty overlays with the evaporate property (Bug#9642).
3429 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3430 if it becomes empty after its bounds are adjusted to fit within
3431 its buffer. Without this fix, in a nonempty buffer (let ((o
3432 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3433 yields an empty overlay that has the evaporate property, which is
3434 not supposed to happen.
3435
1068fe4d
PE
3436 Fix minor GTK3 problems found by static checking.
3437 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3438 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3439 (struct _EmacsFixedClass, emacs_fixed_get_type):
3440 Move decls here from emacsgtkfixed.h, since they needn't be public.
3441 (emacs_fixed_get_type): Now static.
3442 (emacs_fixed_class_init): Omit unused local.
3443 (emacs_fixed_child_type): Remove; unused.
3444 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3445 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3446 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3447 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3448 (EMACS_FIXED_GET_CLASS): Remove; unused.
3449 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3450
888bec30
PE
3451 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3452 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3453
de85e130
PE
34542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3455
d0baac98 3456 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3457 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3458 (__malloc_size_t, __malloc_ptrdiff_t):
3459 Remove. All uses removed, replaced by the definiens if needed,
3460 since we can assume C89 or better now.
3461 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3462 (protect_malloc_state, align, get_contiguous_space)
3463 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3464 (malloc_atfork_handler_child, malloc_enable_thread)
3465 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3466 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3467 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3468 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3469 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3470 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3471 Define using prototypes, not old style.
3472 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3473 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3474 (align): Don't assume that signed integer overflow wraps around.
3475 Omit unused local var.
3476 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3477 (_free_internal_nolock, memalign, mallochook, reallochook):
3478 Omit no-longer-needed casts.
3479 (valloc): Use getpagesize, not __getpagesize.
3480 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3481 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3482
de85e130
PE
3483 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3484
dcbf5805
MA
34852012-04-22 Michael Albinus <michael.albinus@gmx.de>
3486
3487 Move functions from C to Lisp. Make non-blocking method calls
3488 the default. Implement further D-Bus standard interfaces.
3489
3490 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3491 (QCdbus_request_name_allow_replacement)
3492 (QCdbus_request_name_replace_existing)
3493 (QCdbus_request_name_do_not_queue)
3494 (QCdbus_request_name_reply_primary_owner)
3495 (QCdbus_request_name_reply_in_queue)
3496 (QCdbus_request_name_reply_exists)
3497 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3498 (QCdbus_registered_serial, QCdbus_registered_method)
3499 (QCdbus_registered_signal): New Lisp objects.
3500 (XD_DEBUG_MESSAGE): Use sizeof.
3501 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3502 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3503 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3504 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3505 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3506 (xd_signature, xd_append_arg): Allow float for integer types.
3507 (xd_get_connection_references): New function.
b593d6a9
AH
3508 (xd_get_connection_address): Rename from xd_initialize.
3509 Return cached address.
dcbf5805
MA
3510 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3511 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3512 level.
3513 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3514 Return number of refcounts.
dcbf5805
MA
3515 (Fdbus_get_unique_name): Make stronger parameter check.
3516 (Fdbus_message_internal): New defun.
3517 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3518 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3519 (Fdbus_send_signal, Fdbus_register_service)
3520 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3521 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3522 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3523 (Vdbus_compiled_version, Vdbus_runtime_version)
3524 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3525 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3526 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3527 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3528 Adapt docstring.
dcbf5805 3529
52828e02
PE
35302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3531
da05bc4c
PE
3532 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3533 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3534 Do not assume ptrdiff_t is the same width as 'int'.
3535
52828e02
PE
3536 * alloc.c: Handle unusual debugging option combinations.
3537 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3538 since the two debugging options are incompatible.
3539 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3540 is defined.
3541 (mem_init, mem_insert, mem_insert_fixup):
3542 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3543 (NEED_MEM_INSERT): Remove; no longer needed.
3544
f01769f9
LL
35452012-04-22 Leo Liu <sdl.web@gmail.com>
3546
3547 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3548
5790543d
PE
35492012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 * sysdep.c [__FreeBSD__]: Minor cleanups.
3552 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3553 Use Emacs indenting style more consistently. Avoid some casts.
3554 Use 'double' consistently rather than mixing 'float' and 'double'.
3555
b91b7e4d
EW
35562012-04-21 Eduard Wiebe <usenet@pusto.de>
3557
b593d6a9
AH
3558 * sysdep.c (list_system_processes, system_process_attributes):
3559 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3560
6114eb15
AS
35612012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3562
3563 * lisp.mk (lisp): Update.
3564
2f38dff7
PE
35652012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3568 It is never used otherwise.
3569
4ae29f89
SM
35702012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3571
3572 * print.c (print_preprocess): Only check print_depth if print-circle
3573 is nil.
3574 (print_object): Check for cycles even when print-circle is nil and
3575 print-gensym is t, but only check print_depth if print-circle is nil.
3576
f30d612a
CY
35772012-04-20 Chong Yidong <cyd@gnu.org>
3578
3579 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3580 set the status to "failed" and ensure that sentinel is run.
3581
c07a4c0b 35822012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3583
3584 * process.c (Fset_process_inherit_coding_system_flag)
3585 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3586 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3587
c07a4c0b 35882012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3589
3590 * xdisp.c (string_buffer_position_lim): Limit starting position to
3591 BEGV.
3592 (set_cursor_from_row): If called for a mode-line or header-line
3593 row, return zero immediately.
3594 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3595 farther than the first row after the header line, if any.
3596 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3597 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3598
c07a4c0b 35992012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3600
4ae29f89
SM
3601 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3602 (bug#11238).
ad3a2b41 3603
c07a4c0b 36042012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36052012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3606
3607 configure: new option --enable-gcc-warnings (Bug#11207)
3608 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3609 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3610 (ALL_CFLAGS): Use new macros rather than old.
3611 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3612 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3613 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3614 -Wunused-result, -Wunused-variable. This should go away once
3615 the Emacs and Gnulib regex code is merged.
3616 (xmalloc, xrealloc): Now static.
3617
aba027e8
PE
36182012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 * dired.c (Fsystem_groups): Remove unused local.
3621
e5a36063
GM
36222012-04-17 Glenn Morris <rgm@gnu.org>
3623
3624 * dired.c (Fsystem_users): Doc fix.
3625
316411f0
DA
36262012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3627
3628 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3629 (syms_of_dired): Add them.
3630
9426aba4
PE
36312012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3632
b62a57be
PE
3633 Fix minor alloc.c problems found by static checking.
3634 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3635 New extern decls, to avoid calling undeclared functions.
3636 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3637 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3638 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3639 (NEED_MEM_INSERT): New macro.
3640 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3641 Remove one incorrect comment and fix another.
b62a57be 3642
3539f31f
PE
3643 Fix minor ralloc.c problems found by static checking.
3644 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3645 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3646 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3647 (r_alloc_sbrk): Now static.
3648
a041960a
PE
3649 Improve ralloc.c interface checking.
3650 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3651 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3652 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3653 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3654 [REL_ALLOC]: ... to here, to check interface.
3655 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3656 Remove decls. This fixes an "It stinks!".
3657
9426aba4
PE
3658 * alloc.c (which_symbols): Fix alignment issue / type clash.
3659
d55c12ed
AS
36602012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3661
3662 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3663 (struct Lisp_Misc_Any): Likewise.
3664 (struct Lisp_Free): Likewise.
3665 * alloc.c (union aligned_Lisp_Symbol): Define.
3666 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3667 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3668 (union aligned_Lisp_Misc): Define.
3669 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3670 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3671 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3672
b948ce8b
PE
36732012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3674
3675 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3676 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3677 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3678 * s/netbsd.h, s/sol2-6.h:
3679 Remove definition of GC_MARK_STACK, since the default now works.
3680 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3681 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3682 no longer the default.
3683 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3684
35dc09a1 36852012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3686
35dc09a1
GM
3687 * lread.c (lisp_file_lexically_bound_p):
3688 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3689
35dc09a1
GM
36902012-04-14 Eli Zaretskii <eliz@gnu.org>
3691
3692 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3693 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3694
36952012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3696
3697 * nsterm.m (constrainFrameRect): Always constrain when there is only
3698 one screen (Bug#10962).
3699
bcd86815
KB
37002012-04-13 Ken Brown <kbrown@cornell.edu>
3701
3702 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3703
c25df26e
RT
37042012-04-13 Reuben Thomas <rrt@sc3d.org>
3705
3706 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3707
0fc59f1e
DC
37082012-04-11 Daniel Colascione <dancol@dancol.org>
3709
3710 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3711 against is gone. It's better to use vfork now so that when Cygwin
3712 gains a new, working vfork, we use it automatically (bug#10398).
3713
de8c03dc
SM
37142012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3715
3716 * window.c (save_window_save): Obey window-point-insertion-type.
3717
2f097256
GM
37182012-04-11 Glenn Morris <rgm@gnu.org>
3719
3720 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3721
453b951e
SM
37222012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3723
3724 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3725
75f1671a 37262012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3727
3728 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3729 (force_quit_count): New var.
3730 (handle_interrupt): Use it.
3731
2a8ce227
JB
37322012-04-10 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * w32.c (w32_delayed_load): Record the full path of the library
3735 being loaded (bug#10424).
3736
935396c0
GM
37372012-04-09 Glenn Morris <rgm@gnu.org>
3738
05920a43
GM
3739 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3740 not just in the obarray, before snarfing them. (Bug#11036)
3741
935396c0
GM
3742 * Makefile.in ($(leimdir)/leim-list.el):
3743 Pass EMACS rather than BUILT_EMACS.
3744
a18ecafa
TZ
37452012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3746
3747 * process.c (make_process):
3748 * process.h: Add integer `gnutls_handshakes_tried' member to
3749 process struct.
3750
6bbef4e5
JC
3751 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3752 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3753
3754 * gnutls.c (gnutls_log_function2i): Convenience log function.
3755 (emacs_gnutls_read): Use new log functions,
3756 `gnutls_handshakes_tried' process member, and
3757 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3758 attempts per process (connection).
3759
b4d3bc10
CY
37602012-04-09 Chong Yidong <cyd@gnu.org>
3761
3762 * eval.c (Fuser_variable_p, user_variable_p_eh)
3763 (lisp_indirect_variable): Functions deleted.
3764 (Fdefvar): Caller changed.
3765
3766 * callint.c (Finteractive, Fcall_interactively):
3767 * minibuf.c (Fread_variable): Callers changed.
3768
70f4d973
EZ
37692012-04-09 Eli Zaretskii <eliz@gnu.org>
3770
3771 * xdisp.c (set_cursor_from_row): If the display string appears in
3772 the buffer at position that is closer to point than the position
3773 after the display string, display the cursor on the first glyph of
3774 the display string. Fixes cursor display when a 'display' text
3775 property immediately follows invisible text. (Bug#11094)
3776
cb3c2e3e
PE
37772012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3778
3779 composite.c: use 'double' consistently
3780 * composite.c (get_composition_id): Use 'double' consistently
3781 instead of converting 'float' to 'double' and vice versa; this is
3782 easier to understand and avoids a GCC warning.
3783
fd06db5d
GM
37842012-04-09 Glenn Morris <rgm@gnu.org>
3785
50fe702a
GM
3786 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3787 preparation for dumping it with emacs. (Bug#4789)
3788 (leimdir): New variable.
3789 ($(leimdir)/leim-list.el): New rule.
3790 (emacs$(EXEEXT)): Depend on leim-list.el.
3791
fd06db5d
GM
3792 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3793 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3794 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3795
55c131ee
AS
37962012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3797
3798 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3799 proper alignment.
3800
9209588f
JB
38012012-04-07 Juanma Barranquero <lekktu@gmail.com>
3802
3803 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3804 Remove unused local variable.
3805
e3fb2efb
PE
38062012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3809 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3810 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3811 objects, as mark_maybe_pointer will catch them otherwise.
3812 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3813 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3814
b5385551
PE
38152012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3816
3817 Fix typo that broke non-Windows builds.
3818 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3819
9078ead6
EZ
38202012-04-07 Eli Zaretskii <eliz@gnu.org>
3821
3822 Support building on MS-Windows with libxml2.
3823
3824 * makefile.w32-in (OBJ2): Add xml.$(O).
3825 (GLOBAL_SOURCES): Add xml.c.
3826 ($(BLD)/xml.$(O)): New dependency list.
3827
3828 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3829 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3830 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3831 [!WINDOWSNT]: New macros.
3832 (init_libxml2_functions, libxml2_loaded_p): New functions.
3833 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3834 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3835 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3836 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3837 linked in).
6bbef4e5
JC
3838 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3839 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3840 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3841
3842 * emacs.c: Don't include libxml/parser.h.
3843 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3844 xmlCleanupParser directly.
3845
3846 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3847
3811fdf3
EZ
38482012-04-07 Eli Zaretskii <eliz@gnu.org>
3849
3850 * indent.c (Fvertical_motion): If there is a display string at
3851 point, use it.vpos to compute how many lines to backtrack after
3852 move_it_to point. (Bug#11133)
3853
2f8e16b2
EZ
38542012-04-06 Eli Zaretskii <eliz@gnu.org>
3855
3856 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3857 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3858 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3859 macros related to unification of CJK characters. For the details,
3860 see the discussion following the message here:
3861 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3862
3d439cd1
CY
38632012-04-04 Chong Yidong <cyd@gnu.org>
3864
3865 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3866
8bc53d00
EZ
38672012-04-01 Eli Zaretskii <eliz@gnu.org>
3868
3869 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3870 instead of alloca. (Bug#11138)
3871
3b0512a3
AS
38722012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3873
3874 * w32menu.c (is_simple_dialog): Properly check lisp types.
3875 (Bug#11141)
3876
8427ddd2
EZ
38772012-03-31 Eli Zaretskii <eliz@gnu.org>
3878
979022ef
EZ
3879 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3880 position we get to after a call to move_it_to fails the
3881 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3882 only if we wind up in a string from display property. (Bug#11063)
3883
a6b1c7cc
EZ
3884 * window.c (Fdelete_other_windows_internal): Invalidate the row
3885 and column information about mouse highlight, so that redisplay
3886 restores it after reallocating the glyph matrices. (Bug#7464)
3887
8427ddd2
EZ
3888 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3889 string comes from a `display' text property, use the buffer
3890 position of that property as if we actually saw that position in
3891 the row's glyphs.
697ba24b
EZ
3892 (move_it_by_lines): Remove the assertion that
3893 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3894 violated when there's a before-string at the beginning of a line.
3895 (Bug#11063)
8427ddd2 3896
65a0a738
EZ
38972012-03-30 Eli Zaretskii <eliz@gnu.org>
3898
3899 * xdisp.c (append_space_for_newline): If the default face was
3900 remapped, use the remapped face for the appended newline.
3901 (extend_face_to_end_of_line): Use the remapped default face for
3902 extending the face to the end of the line.
3903 (display_line): Call extend_face_to_end_of_line when the default
3904 face was remapped. (Bug#11068)
3905
581355cc
EZ
39062012-03-29 Eli Zaretskii <eliz@gnu.org>
3907
3908 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3909
e8fc049f
SM
39102012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3911
3912 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3913
4fb9a543
GM
39142012-03-27 Glenn Morris <rgm@gnu.org>
3915
3916 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3917 Doc fixes.
3918
679910f1
KH
39192012-03-26 Kenichi Handa <handa@m17n.org>
3920
3921 * dispextern.h (struct glyph): Fix previous change. Change the
3922 bit length of glyphless.ch to 25 (Bug#11082).
3923
90d49b7f
CY
39242012-03-26 Chong Yidong <cyd@gnu.org>
3925
3926 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3927 (command_loop_1): Use it; inhibit selection update for
3928 handle-select-window too (Bug#8996).
3929
f514f6f0
FP
39302012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3931
e8fc049f 3932 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3933
bf43fa51
KH
39342012-03-25 Kenichi Handa <handa@m17n.org>
3935
3936 * dispextern.h (struct glyph): Change the bit length of
3937 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3938
8a0c01dd
EZ
39392012-03-24 Eli Zaretskii <eliz@gnu.org>
3940
3941 * s/ms-w32.h (tzname): Include time.h before redirecting to
3942 _tzname. Fixes the MSVC build. (Bug#9960)
3943
7d1c3a76
AS
39442012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3945
8ed79523
AS
3946 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3947 characters.
3948
7d1c3a76
AS
3949 * xterm.c (XTread_socket): Only modify handling_signal if
3950 !SYNC_INPUT. (Bug#11080)
3951
e99a9b8b
EZ
39522012-03-23 Eli Zaretskii <eliz@gnu.org>
3953
3954 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3955 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3956 when fetching a multibyte character consumes more bytes than
3957 CHAR_BYTES returns, due to unification of CJK characters in
3958 string_char. (Bug#11073)
3959
5063c0e1
TN
39602012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3961
3962 * process.c (wait_reading_process_output): Handle pty disconnect
3963 by refraining from sending oneself a SIGCHLD (bug#10933).
3964
9f851fbd
CY
39652012-03-22 Chong Yidong <cyd@gnu.org>
3966
3967 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3968
5063c0e1 3969 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3970 Mark string as coming from a prefix property.
3971 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3972 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3973
fb5b8aca
CY
39742012-03-21 Chong Yidong <cyd@gnu.org>
3975
3976 * xfaces.c (Vface_remapping_alist): Doc fix.
3977
62356a1b
EZ
39782012-03-20 Eli Zaretskii <eliz@gnu.org>
3979
3980 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3981 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3982 Doc fixes.
62356a1b 3983
025de85b
CY
39842012-03-20 Chong Yidong <cyd@gnu.org>
3985
3986 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3987 to reflect default non-nil value of redisplay-dont-pause.
3988
4827f94e
KH
39892012-03-19 Kenichi Handa <handa@m17n.org>
3990
3991 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3992 it fit in a valid range (Bug#11003).
3993
e50a24a2
EZ
39942012-03-18 Eli Zaretskii <eliz@gnu.org>
3995
3996 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3997 that is not from display property, accept the row as a "cursor
3998 row" if one of the string's character has a non-nil `cursor'
3999 property. Fixes cursor positioning when there are newlines in
4000 overlay strings, e.g. in icomplete.el. (Bug#11035)
4001
9af5ed87
PE
40022012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4003
4004 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4005
d1f55f16
CY
40062012-03-12 Chong Yidong <cyd@gnu.org>
4007
4008 * eval.c (inhibit_lisp_code): Rename from
4009 inhibit_window_configuration_change_hook; move from window.c.
4010
4011 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4012 * window.c (run_window_configuration_change_hook)
4013 (syms_of_window): Callers changed.
4014
66c5eebd
CY
40152012-03-11 Chong Yidong <cyd@gnu.org>
4016
413df973
CY
4017 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4018
66c5eebd
CY
4019 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4020
1de11f56
CY
40212012-03-10 Chong Yidong <cyd@gnu.org>
4022
4023 * frame.c (other_visible_frames): Don't assume the selected frame
4024 is visible (Bug#10955).
4025
cae07000
SM
40262012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4027
4028 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4029
89c94350
JD
40302012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4031
4032 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4033 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4034 zero (Bug#10954).
4035
999dd333
GM
40362012-03-03 Glenn Morris <rgm@gnu.org>
4037
01a6dcc8 4038 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4039
de0100f2
EZ
40402012-03-02 Eli Zaretskii <eliz@gnu.org>
4041
4042 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4043 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4044 (redisplay_window, next_element_from_string): Fix typos in
4045 comments.
3e441275
EZ
4046 (redisplay_window): Pass to move_it_vertically the margin in
4047 pixels, not in screen lines.
de0100f2 4048
96a72ee9
GM
40492012-03-02 Glenn Morris <rgm@gnu.org>
4050
4051 * buffer.c (buffer-list-update-hook): Doc fix.
4052
312508d7
EZ
40532012-02-29 Eli Zaretskii <eliz@gnu.org>
4054
4055 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4056 push_it before setting up the iterator for the first overlay
4057 string, even if we have an empty string loaded.
4058 (next_overlay_string): If there's an empty string on the iterator
4059 stack, pop the stack. (Bug#10903)
4060
27f3c637
PE
40612012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4064 Suggested by Stefan Monnier in
4065 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4066 * alloc.c (widen_to_Lisp_Object): New static function.
4067 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4068 and widening them to Lisp_Objects. This would work even if
4069 USE_LSB_TAG is defined and wide integers are used, which might
4070 happen in a future version of Emacs.
4071
3c9dfce6
CY
40722012-02-25 Chong Yidong <cyd@gnu.org>
4073
fa74b241
CY
4074 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4075 Doc fix.
4076
3c9dfce6
CY
4077 * xselect.c (Fx_selection_exists_p): Doc fix.
4078 (x_clipboard_manager_save_all): Print an informative message
4079 before saving to clipboard manager.
4080
9486df08
CY
40812012-02-24 Chong Yidong <cyd@gnu.org>
4082
4083 * keyboard.c (process_special_events): Handle all X selection
4084 requests in kbd_buffer, not just the next one (Bug#8869).
4085
f01d3321
CY
40862012-02-23 Chong Yidong <cyd@gnu.org>
4087
4088 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4089 call when setting menu-bar-lines and tool-bar-lines parameters.
4090 (unwind_create_frame_1): New helper function.
4091
4092 * window.c (inhibit_window_configuration_change_hook): New var.
4093 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4094 (syms_of_window): Initialize it.
f01d3321 4095
86b847b6
CY
40962012-02-22 Chong Yidong <cyd@gnu.org>
4097
4098 * xterm.c (x_draw_image_relief): Add missing type check for
4099 Vtool_bar_button_margin (Bug#10743).
4100
a59225b1
CY
41012012-02-21 Chong Yidong <cyd@gnu.org>
4102
4103 * fileio.c (Vfile_name_handler_alist): Doc fix.
4104
4105 * buffer.c (Fget_file_buffer): Protect against invalid file
4106 handler return value.
4107
310f5bd4
PE
41082012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4109
cb3a28cc
PE
4110 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4111 when computing $valmask.
4112
310f5bd4
PE
4113 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4114 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4115 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4116 It's useless in that case, and it can cause problems on hosts
4117 that allocate halves of EMACS_INT values separately.
4118 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4119 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4120 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4121 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4122 it avoids undefined behavior on hosts where shifting right by more
4123 than the word width has undefined behavior.
4124
2375c96a
CY
41252012-02-19 Chong Yidong <cyd@gnu.org>
4126
4127 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4128 (Funhandled_file_name_directory, Ffile_name_as_directory)
4129 (Fdirectory_file_name, Fexpand_file_name)
4130 (Fsubstitute_in_file_name): Protect against invalid file handler
4131 return values (Bug#10845).
4132
3eb49e71
EZ
41332012-02-18 Eli Zaretskii <eliz@gnu.org>
4134
4135 * .gdbinit (pitx): Fix incorrect references to fields of the
4136 iterator stack.
4137
7b926f3f
CY
41382012-02-17 Chong Yidong <cyd@gnu.org>
4139
4140 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4141
11273115
PE
41422012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4143
4144 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4145 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4146
c3a70e2b
CY
41472012-02-15 Chong Yidong <cyd@gnu.org>
4148
4149 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4150 marked as special. Also, starting docstrings with * is obsolete.
4151
0ca43699
AS
41522012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4153
4154 * gnutls.c (emacs_gnutls_write): Fix last change.
4155
2e8f3c56
LI
41562012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4157
4158 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4159 send_process.
4160
af70074f
SM
41612012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4162
4163 * keymap.c (Fsingle_key_description): Handle char ranges.
4164
95986d52
CY
41652012-02-12 Chong Yidong <cyd@gnu.org>
4166
afd83bd1
CY
4167 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4168 as that creates a dangerous corner case.
4169
95986d52
CY
4170 * window.c (Fdelete_window_internal): Invalidate the mouse
4171 highlight (Bug#9904).
4172
bd7da63e
GM
41732012-02-12 Glenn Morris <rgm@gnu.org>
4174
4175 * xselect.c (Fx_own_selection_internal)
4176 (Fx_get_selection_internal, Fx_disown_selection_internal)
4177 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4178 * nsselect.m (Fx_own_selection_internal)
4179 (Fx_disown_selection_internal, Fx_selection_exists_p)
4180 (Fx_selection_owner_p, Fx_get_selection_internal):
4181 Sync docs and argument specs with the xselect.c versions.
4182
77abcbc2
LI
41832012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4184
4185 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4186
90b671e2
EZ
41872012-02-11 Eli Zaretskii <eliz@gnu.org>
4188
1c0ca0b7
EZ
4189 * w32select.c (Fx_selection_exists_p): Sync doc string and
4190 argument list with xselect.c. (Bug#10783)
4191
4192 * w16select.c (Fx_selection_exists_p): Sync doc string and
4193 argument list with xselect.c. (Bug#10783)
90b671e2 4194
49241268
GM
41952012-02-10 Glenn Morris <rgm@gnu.org>
4196
4197 * fns.c (Fsecure_hash): Doc fix.
4198
f998bbe7 41992012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4200
4201 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4202
0992bd9c
CY
42032012-02-07 Chong Yidong <cyd@gnu.org>
4204
4205 * buffer.c (Fbuffer_local_variables)
4206 (buffer_lisp_local_variables): Handle unbound vars correctly;
4207 don't let Qunbound leak into Lisp.
4208
af008560
GM
42092012-02-07 Glenn Morris <rgm@gnu.org>
4210
dd605cc4
GM
4211 * image.c (Fimagemagick_types): Doc fix.
4212
af008560
GM
4213 * image.c (imagemagick-render-type): Change it from a lisp object
4214 to an integer. Move the doc here from the lisp manual.
4215 Treat all values not equal to 0 the same.
4216
1449fa1d
CY
42172012-02-06 Chong Yidong <cyd@gnu.org>
4218
4219 * doc.c (store_function_docstring): Avoid applying docstring of
4220 alias to base function (Bug#2603).
4221
3723ec07
AS
42222012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4223
4224 * .gdbinit (pp1, pv1): Remove redundant defines.
4225 (pr): Use pp.
4226
79c1cc1e
CY
42272012-02-04 Chong Yidong <cyd@gnu.org>
4228
4229 * nsterm.m: Declare a global (Bug#10694).
4230
d7f29f8e
EZ
42312012-02-04 Eli Zaretskii <eliz@gnu.org>
4232
cae07000
SM
4233 * w32.c (get_emacs_configuration_options):
4234 Include --enable-checking, if specified, in the return value.
d7f29f8e 4235
3b95a6f9
MR
42362012-02-04 Martin Rudalics <rudalics@gmx.at>
4237
4238 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4239 after rounding frame sizes. (Bug#9723)
4240
d6fa96a6
EZ
42412012-02-04 Eli Zaretskii <eliz@gnu.org>
4242
4243 * keyboard.c (adjust_point_for_property): Don't position point
4244 before BEGV. (Bug#10696)
4245
df0b2940
PE
42462012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4247
4248 Handle overflow when computing char display width (Bug#9496).
4249 * character.c (char_width): Return EMACS_INT, not int.
4250 (char_width, c_string_width): Check for overflow when
4251 computing the width; this is possible now that individual
4252 characters can have unbounded width. Problem introduced
4253 by merge from Emacs 23 on 2012-01-19.
4254
6bee44d6
MA
42552012-02-02 Michael Albinus <michael.albinus@gmx.de>
4256
4257 * dbusbind.c (Fdbus_register_method): Mention the return value
4258 :ignore in the docstring.
4259
44f92739
GM
42602012-02-02 Glenn Morris <rgm@gnu.org>
4261
1b9f60cc
GM
4262 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4263
44f92739
GM
4264 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4265 Unconditionally set to t. (Bug#10673)
4266 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4267 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4268 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4269
c5d3843c
KH
42702012-02-02 Kenichi Handa <handa@m17n.org>
4271
4272 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4273 0, do not call append_composite_glyph.
4274
159462d4 42752012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4276
4277 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4278 NULL (Bug#6988).
4279 (x_produce_glyphs): If the component of a composition is a null
4280 string, set it->pixel_width to 1 to avoid zero-width glyph.
4281
78cef877
EZ
42822012-02-01 Eli Zaretskii <eliz@gnu.org>
4283
4284 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4285 first 2 arguments are identical. This makes inserting large
4286 output from a subprocess an order of magnitude faster on
4287 MS-Windows, where all sbrk'ed memory is always contiguous.
4288
97897668
GM
42892012-01-31 Glenn Morris <rgm@gnu.org>
4290
4291 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4292 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4293 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4294
31fd3586
GM
42952012-01-29 Glenn Morris <rgm@gnu.org>
4296
4297 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4298
0e24a8b2
CY
42992012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4300
4301 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4302
cc0adcb0
CY
43032012-01-28 Chong Yidong <cyd@gnu.org>
4304
4305 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4306
acc28cb9
CY
43072012-01-26 Chong Yidong <cyd@gnu.org>
4308
9c69cfb7
CY
4309 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4310
acc28cb9
CY
4311 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4312 repeat counts (Bug#10507).
4313
48da7392
GM
43142012-01-26 Glenn Morris <rgm@gnu.org>
4315
4316 * lread.c (syms_of_lread): Doc fix.
4317
14af5f7f
CY
43182012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4319
4320 * coding.c (encode_designation_at_bol): Change return value to
4321 EMACS_INT.
4322
0b21c100
CY
43232012-01-25 Chong Yidong <cyd@gnu.org>
4324
4325 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4326
3c2907f7
CY
43272012-01-21 Chong Yidong <cyd@gnu.org>
4328
4329 * floatfns.c (Fcopysign): Make the second argument non-optional,
4330 since nil is not allowed anyway.
4331
959ad23f
AS
43322012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4333
4334 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4335 (send_process): Likewise.
4336
34a02f46
MR
43372012-01-19 Martin Rudalics <rudalics@gmx.at>
4338
4339 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4340 (Vwindow_persistent_parameters): Do not use Qstate.
4341 Rewrite doc-strings.
34a02f46 4342
1259009a 43432012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4344
4345 * character.c (char_width): New function.
70d4fdf6
GM
4346 (Fchar_width, c_string_width, lisp_string_width):
4347 Use char_width (Bug#9496).
25ed9e61 4348
6a6ee00d
MR
43492012-01-16 Martin Rudalics <rudalics@gmx.at>
4350
4351 * window.c (Vwindow_persistent_parameters): New variable.
4352 (Fset_window_configuration, save_window_save): Handle persistent
4353 window parameters.
4354
c85efaf7
EZ
43552012-01-14 Eli Zaretskii <eliz@gnu.org>
4356
4357 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4358 thrashing the stack of the thread. (Bug#9087)
4359
5944709e
PE
43602012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4361
4362 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4363
e71f5d99
EZ
43642012-01-11 Eli Zaretskii <eliz@gnu.org>
4365
4366 * xdisp.c (rows_from_pos_range): Handle the case where the
4367 highlight ends on a newline. (Bug#10464)
4368 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4369 he end column for display of highlight that ends on a newline
4370 before a R2L line.
4371
ce316182
GM
43722012-01-11 Glenn Morris <rgm@gnu.org>
4373
4374 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4375 from load-path also when installation-directory is nil. (Bug#10208)
4376
5b43da69
GM
43772012-01-10 Glenn Morris <rgm@gnu.org>
4378
74cc8ff9
GM
4379 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4380
7d8d6e4e
GM
4381 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4382 Update template values to be closer to their typical values these days.
5b43da69 4383
a0db8d43
EZ
43842012-01-09 Eli Zaretskii <eliz@gnu.org>
4385
4386 * xdisp.c (rows_from_pos_range): Accept additional argument
4387 DISP_STRING, and accept any glyph in a row whose object is that
4388 string as eligible for mouse highlight. Fixes mouse highlight of
4389 display strings from overlays. (Bug#10464)
4390
9a0115ab 43912012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4392
b9110d6a 4393 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4394 * fileio.c (auto_saving_dir_umask): New static var.
4395 (Fmake_directory_internal): Use it.
4396 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4397 creating the directory. The old code temporarily assigns
4398 too-generous permissions to the directory.
4399 (do_auto_save_eh): Clear it.
b9110d6a 4400 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4401 that the var is always cleared.
4402
6c1bd3f3
EZ
44032012-01-07 Eli Zaretskii <eliz@gnu.org>
4404
4405 * search.c (scan_buffer): Pass character positions to
4406 know_region_cache, not byte positions. (Bug#6540)
4407
069d2b50
L
44082012-01-07 LynX <_LynX@bk.ru> (tiny change)
4409
4410 * w32.c (sys_rename): Report EXDEV when rename of a directory
4411 fails because the target is on another logical disk. (Bug#10284)
4412
75bf0d33
DB
44132012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4414
4415 * xterm.c (x_embed_request_focus): New function.
4416
4417 * xterm.h: Add prototype.
4418
4419 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4420
1c6e5a32
GM
44212012-01-05 Glenn Morris <rgm@gnu.org>
4422
4423 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4424
651e947e
EZ
44252012-01-01 Eli Zaretskii <eliz@gnu.org>
4426
4427 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4428 Load gnutls_transport_set_lowat only if GnuTLS version is below
4429 2.11.1.
4430 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4431 GnuTLS versions below 2.11.1.
4432
3778cdd8
AL
44332011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4434
4435 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4436 to the doc string advising against its use for altering the way
4437 windows are scrolled.
4438
0e5317f7
KH
44392011-12-28 Kenichi Handa <handa@m17n.org>
4440
4441 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4442 coding-system ASCII compatible only when it does not produce BOM
4443 on encoding (Bug#10383).
4444
93d5ca1f
JD
44452011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4446
4447 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4448 can scroll.
4449 (create_and_show_popup_menu): Always use menu_position_func for
4450 Gtk3 (Bug#10361).
4451
ca22b785
AS
44522011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4453
4454 * callint.c (Fcall_interactively): Don't truncate prompt string.
4455
d048e1e6
EZ
44562011-12-23 Eli Zaretskii <eliz@gnu.org>
4457
4458 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4459 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4460 resumed from there (after widening). (Bug#10360)
d048e1e6 4461
5ccaba1f
JD
44622011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4463
4464 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4465
204ee57f
JD
44662011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4467
b81d40f0
JB
4468 * nsterm.m (x_free_frame_resources):
4469 Release f->output_data.ns->miniimage.
204ee57f
JD
4470 (ns_index_color): Fix indentation. Do not retain
4471 color_table->colors[i].
4472
4473 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4474 before returning.
4475
4476 * nsfns.m (x_set_background_color): Assign return value from
4477 ns_index_color to face-background instead of NSColor*.
4478 (ns_implicitly_set_icon_type): Fix indentation.
4479 Change assignment in for loop to comparison.
4480
4481 * emacs.c (ns_pool): New variable.
4482 (main): Assign ns_pool.
4483 (Fkill_emacs): Call ns_release_autorelease_pool.
4484
4485 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4486 autorelease fdesc, release fdAttrs and tdict.
4487 (ns_get_covering_families): Release charset.
4488 (ns_findfonts): Release NSFontDescriptor created with new.
4489 (ns_uni_to_glyphs): Fix indentation.
4490 (setString): Release attrStr before assigning new value.
4491
c803b2b7
JD
44922011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4493
678f4426
JD
4494 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4495 and NS_IMPL_COCOA.
4496 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4497 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4498
cd394be1 44992011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4500
5fecd5fc
JD
4501 * nsterm.m (ns_term_init): Subscribe for notifications
4502 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4503 to method trackingNotification in EmacsMenu.
4504
4505 * nsmenu.m (trackingMenu): New variable.
3771cb17 4506 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4507 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4508 from Aquamacs (Bug#7030).
678f4426
JD
4509
45102011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4511
c803b2b7
JD
4512 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4513 (symbol_to_nsstring): Fix indentation.
4514 (ns_symbol_to_pb): New function.
cae07000
SM
4515 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4516 (Fns_rotate_cut_buffers_internal): Remove.
4517 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4518 Fns_store_cut_buffer_internal.
4519 (ns_get_foreign_selection, Fx_own_selection_internal)
4520 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4521 (Fns_get_selection_internal, Fns_store_selection_internal):
4522 Use ns_symbol_to_pb and check if return value is nil.
4523 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4524 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4525 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4526 renamed to Sns_store_selection_internal.
4527 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4528 and remove this function.
4529 (ns_handle_selection_clear): Remove, never used.
4530 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4531 here.
4532
e1b01a3a
KB
45332011-12-17 Ken Brown <kbrown@cornell.edu>
4534
4535 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4536 GID is unknown (Bug#10257).
4537
2adb6e85
PE
45382011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4541 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4542 which caused a build failure on GNU/Linux IA-64. This problem was
4543 introduced by my 2011-10-07 patch.
4544
d1d7b339
JL
45452011-12-15 Juri Linkov <juri@jurta.org>
4546
4547 * image.c (imagemagick_error): New function. (Bug#10112)
4548 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4549 Use `imagemagick_error' where ImageMagick functions return
4550 `MagickFalse'.
4551 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4552 proper order.
4553
100d5755
KH
45542011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4555
4556 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4557 fill background (Bug#8992).
4558
454592a6
MR
45592011-12-13 Martin Rudalics <rudalics@gmx.at>
4560
4561 * window.c (Vwindow_combination_resize)
4562 (Vwindow_combination_limit): Use t instead of non-nil in
4563 doc-strings.
61d4b438
MR
4564 (Vrecenter_redisplay): Add first sentence of doc-string on
4565 separate line.
53524d93 4566 (Frecenter): Fix doc-string typo.
454592a6 4567
3633e3aa
KH
45682011-12-11 Kenichi Handa <handa@m17n.org>
4569
4570 * coding.c (Funencodable_char_position): Pay attention to the
4571 buffer text relocation (Bug#9389).
4572
7b9d523a 45732011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4574
7b9d523a
JD
4575 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4576 gtk_init (Bug#10100).
4577
b73189c6
EZ
45782011-12-10 Eli Zaretskii <eliz@gnu.org>
4579
4580 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4581 IT->string is nil. (Bug#10263)
4582
f7dfe5d6
JD
45832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4584
83faebb4
JD
4585 * nsterm.h (x_free_frame_resources): Declare.
4586
f7dfe5d6
JD
4587 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4588 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4589
4590 * nsterm.h (ns_get_defaults_value): Declare.
4591
4592 * nsterm.m (ns_default): Call ns_get_defaults_value.
4593
7cd4e72c
EZ
45942011-12-09 Eli Zaretskii <eliz@gnu.org>
4595
4596 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4597 (Bug#10170)
4598
b34d7317
YM
45992011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4600
4601 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4602 that where the value of an _OBJC_* symbol points to is in the .bss
4603 section (Bug#10240).
4604
76470ad1
KH
46052011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4606
4607 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4608 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4609
745fff94
KH
46102011-12-08 Kenichi Handa <handa@m17n.org>
4611
4612 * ftfont.c (get_adstyle_property): Fix previous change
4613 (Bug#10233).
4614
6e44397c
JB
46152011-12-07 Juanma Barranquero <lekktu@gmail.com>
4616
4617 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4618 dirs from the default value of EMACSLOADPATH (bug#10208).
4619
7efa6272
GM
46202011-12-07 Glenn Morris <rgm@gnu.org>
4621
4622 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4623 installation and source directories as well. (Bug#10208)
4624
f6fc4d87
CY
46252011-12-06 Chong Yidong <cyd@gnu.org>
4626
4627 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4628
2bf26180
GM
46292011-12-06 Glenn Morris <rgm@gnu.org>
4630
4631 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4632 as an error, not just -1. (Bug#10217)
4633
3a6ad4f0
CY
46342011-12-05 Chong Yidong <cyd@gnu.org>
4635
4636 * keyboard.c (process_special_events): New function.
4637 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4638
75a3b399
PE
46392011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4640
4641 * coding.c (encode_designation_at_bol): Don't use uninitialized
4642 local variable (Bug#9318).
4643
c3c9e25e
KH
46442011-12-05 Kenichi Handa <handa@m17n.org>
4645
4646 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4647 return Qnil (Bug#8046, Bug#10193).
4648
5eb05ea3
KH
46492011-12-05 Kenichi Handa <handa@m17n.org>
4650
4651 * coding.c (encode_designation_at_bol): New args charbuf_end and
4652 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4653 (coding_set_source): Return how many bytes coding->source was
4654 relocated.
4655 (coding_set_destination): Return how many bytes
4656 coding->destination was relocated.
4657 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4658 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4659
46602011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4661
4662 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4663 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4664 macro (Bug#9318).
4665
46662011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4667
4668 The following changes are to fix Bug#9318.
4669
a79703f5 4670 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4671 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4672 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4673 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4674
7dbda6df
JB
46752011-12-05 Juanma Barranquero <lekktu@gmail.com>
4676
4677 * lisp.h (process_quit_flag): Fix external declaration.
4678
6d5eb5b0
SM
46792011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4680
4681 Don't macro-inline non-performance-critical code.
4682 * eval.c (process_quit_flag): New function.
4683 * lisp.h (QUIT): Use it.
4684
a0c3fad0
JD
46852011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4686
4687 * nsfns.m (get_geometry_from_preferences): New function.
4688 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4689
6c07aac2
AS
46902011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4691
4692 * emacs.c (Qkill_emacs): Define.
4693 (syms_of_emacs): Initialize it.
4694 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4695 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4696 (quit_throw_to_read_char): Add parameter `from_signal'.
4697 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4698 * lisp.h (QUIT): Call Fkill_emacs if requested.
4699
c052ead4
JD
47002011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4701
4702 * widget.c (update_wm_hints): Return if wmshell is null.
4703 (widget_update_wm_size_hints): New function.
4704
4705 * widget.h (widget_update_wm_size_hints): Declare.
4706
4707 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4708 widget_update_wm_size_hints (Bug#10104).
4709
9e49252b
EZ
47102011-12-03 Eli Zaretskii <eliz@gnu.org>
4711
4712 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4713 before a newline, prepare the bidi iterator for consuming the
4714 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4715 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4716
02b16839
JL
47172011-12-02 Juri Linkov <juri@jurta.org>
4718
4719 * search.c (Fword_search_regexp): New Lisp function created from
4720 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4721 (Fword_search_backward, Fword_search_forward)
4722 (Fword_search_backward_lax, Fword_search_forward_lax):
4723 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4724 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4725
0068070e
SM
47262011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4727
4728 * fileio.c (Finsert_file_contents): Move after-change-function call
4729 to before the "handled:" label, since all "goto handled" appear in
4730 cases where the *-change-functions have already been properly called
4731 (bug#10117).
4732
3360a3fc
AS
47332011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4734
4735 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4736 waiting for input. (Bug#10169)
4737
73d6c093
EZ
47382011-11-30 Eli Zaretskii <eliz@gnu.org>
4739
4740 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4741 verifies glyph row's hash code--we have just reallocated the
4742 glyphs, so their contents can be complete garbage. (Bug#10164)
4743
febe6bea
JB
47442011-11-30 Juanma Barranquero <lekktu@gmail.com>
4745
4746 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4747
801a4313
EZ
47482011-11-30 Eli Zaretskii <eliz@gnu.org>
4749
4750 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4751 attributes are tested _before_ calling verify_row_hash, to protect
4752 against GCC re-ordering of the tests. (Bug#10164)
4753
2b56b87e
JD
47542011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4755
4756 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4757
4758 * xterm.c (handle_one_xevent): Only set async_visible and friends
4759 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4760 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4761 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4762
dbf31225
PE
47632011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4764
4765 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4766 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4767 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4768 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4769 All uses changed to use GCPRO1 etc.
4770 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4771 Revert to old implementation (i.e., before 2011-03-11).
4772
1305621b
YM
47732011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4774
4775 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4776 of scroll runs so as to avoid assigning disabled bogus rows and
4777 unnecessary graphics copy operations.
4778
8c9afb46
EZ
47792011-11-27 Eli Zaretskii <eliz@gnu.org>
4780
4781 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4782 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4783 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4784 (malloc, free, realloc, calloc): Redirect to e_* only when
4785 compiling Emacs.
4786
4787 * lisp.h (GCTYPEBITS): Move before first use.
4788 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4789 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4790 this macro definition.
4791
4792 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4793 _MSC_VER.
4794
54e9e3bf
JD
47952011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4796
6d5eb5b0
SM
4797 * gtkutil.c (xg_create_frame_widgets):
4798 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4799 present with Gtk+ 2.0.
4800
83aca1cb
PE
48012011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4802
4803 * fileio.c (Finsert_file_contents): Undo previous change; see
4804 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4805
5b76caa4
PE
48062011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4807
4808 Rename locals to avoid shadowing.
4809 * fileio.c (Finsert_file_contents):
4810 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4811 * process.c (wait_reading_process_output):
4812 Rename inner 'proc' to 'p' to avoid shadowing.
4813 Indent for consistency with usual Emacs style.
4814
8c535114
EZ
48152011-11-25 Eli Zaretskii <eliz@gnu.org>
4816
4817 * xdisp.c (redisplay_window): If cursor row is not fully visible
4818 after recentering, and scroll-conservatively is set to a large
4819 number, scroll window by a few more lines to make the cursor fully
4820 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4821 (start_display): Don't move to the next line if the display should
4822 start at a newline that is part of a display vector or an overlay
4823 string. (Bug#10119)
8c535114 4824
fa4fdb5c
JL
48252011-11-24 Juri Linkov <juri@jurta.org>
4826
4827 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4828 after the `MagickPingImage' call. (Bug#10112)
4829
90ec88df
CY
48302011-11-23 Chong Yidong <cyd@gnu.org>
4831
4832 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4833
56e2e794
MR
48342011-11-23 Martin Rudalics <rudalics@gmx.at>
4835
4836 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4837 making another buffer current. (Bug#10114)
4838
b6e64c41
GM
48392011-11-23 Glenn Morris <rgm@gnu.org>
4840
4841 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4842
6b21de18
CY
48432011-11-23 Chong Yidong <cyd@gnu.org>
4844
4845 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4846 using it (Bug#5984).
4847
b12cd789
EZ
48482011-11-22 Eli Zaretskii <eliz@gnu.org>
4849
4850 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4851 and header-lines, as they don't have one computed for them.
4852 (Bug#10098)
4853
4854 * .gdbinit (prow): Make displayed values more self-explaining.
4855 Add row's hash code.
4856
261b6fd4
LMI
48572011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4858
4859 * process.c (wait_reading_process_output): Fix asynchrounous
4860 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4861 (wait_reading_process_output): Add comment and URL.
261b6fd4 4862
e7cfd277
JD
48632011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4864
4865 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4866
a9b9b7f5
CY
48672011-11-21 Chong Yidong <cyd@gnu.org>
4868
4869 * window.c (Fnext_window, Fprevious_window): Doc fix.
4870
b0d15b4f
SM
48712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4872
4873 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4874
fe7a3057
JB
48752011-11-20 Juanma Barranquero <lekktu@gmail.com>
4876
4877 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4878
d2999b1a
MR
48792011-11-20 Martin Rudalics <rudalics@gmx.at>
4880
4881 * window.c (Fset_window_combination_limit): Rename argument
4882 STATUS to LIMIT.
4883 (Vwindow_combination_limit): Remove "status" from doc-string.
4884
d5ff9cd0
AS
48852011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4886
4887 * m/ibms390.h: Remove.
4888 * m/ibms390x.h: Don't include "ibms390.h".
4889
a5bb9bd3
SM
48902011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4891
4892 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4893 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4894
cd1181db
JB
48952011-11-20 Juanma Barranquero <lekktu@gmail.com>
4896
4897 * casetab.c (Fset_case_table):
4898 * charset.c (Fcharset_after): Fix typos.
4899
615a3b8d 49002011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4901
17e845af
PE
4902 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4903 Otherwise, valgrind does not work on some platforms.
4904 Problem reported by Andreas Schwab in
6a0bf43d
PE
4905 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4906 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4907 is set, removing the need for VIRT_ADDRESS_VARIES.
4908 (PURE_P): Use a more-efficient implementation that needs just one
4909 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4910 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4911 to 4 (xorl, subq, cmpq, setbe).
4912 * alloc.c (pure): Always extern now, since that's the
4913 VIRT_ADDR_VARIES behavior.
4914 (PURE_POINTER_P): Use a single comparison, not two, for
4915 consistency with the new puresize.h.
4916 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4917 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4918 Remove VIRT_ADDR_VARIES no longer needed.
4919
f8fe6f96
EZ
49202011-11-19 Eli Zaretskii <eliz@gnu.org>
4921
4922 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4923 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4924 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4925 behave as if the cursor position were at the window margin.
4926
4927 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4928 and the cursor position is out of bounds, behave as if the cursor
4929 position were at the window margin. (Bug#10075)
4930
df05a53c
CY
49312011-11-18 Chong Yidong <cyd@gnu.org>
4932
4933 * window.c (Fwindow_combination_limit): Make first argument
4934 non-optional, since it is meaningless for live windows like the
4935 selected window.
61ccba97 4936
2071918e
DA
49372011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4938
4939 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4940
b50a28de
SM
49412011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4942
4943 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4944 (graft_intervals_into_buffer): Simplify.
4945
015137db
EZ
49462011-11-18 Eli Zaretskii <eliz@gnu.org>
4947
4948 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4949 hash values of the two rows.
4950 (copy_row_except_pointers): Preserve the used[] arrays and the
4951 hash values of the two rows. (Bug#10035)
68c95424 4952 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4953
4954 * xdisp.c (row_hash): New function, body extracted from
4955 compute_line_metrics.
4956 (compute_line_metrics): Call row_hash, instead of computing the
4957 hash code inline.
4958
4959 * dispnew.c (verify_row_hash): Call row_hash for computing the
4960 hash code of a row, instead of duplicating code from xdisp.c.
4961
4962 * dispextern.h (row_hash): Add prototype.
4963
a2addb04
TH
49642011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4965
4966 * frame.c (delete_frame): Don't delete the terminal when the last
4967 X frame is closed if emacs is built with GTK toolkit.
4968
df85d315
JB
49692011-11-17 Juanma Barranquero <lekktu@gmail.com>
4970
4971 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4972
a0c2d0ae
MR
49732011-11-17 Martin Rudalics <rudalics@gmx.at>
4974
4975 * window.c (Vwindow_splits): Rename to
4976 Vwindow_combination_resize. Suggested by Juri Linkov.
4977 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4978 of Vwindow_splits.
4979
58179cce
JB
49802011-11-16 Juanma Barranquero <lekktu@gmail.com>
4981
7877f373
JB
4982 * nsfns.m (Fns_font_name):
4983 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4984
b6f67890
MR
49852011-11-16 Martin Rudalics <rudalics@gmx.at>
4986
4987 * window.h (window): Rename slot "nest" to "combination_limit".
4988 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4989 (Fset_window_nest): Rename to Fset_window_combination_limit.
4990 (Vwindow_nest): Rename to Vwindow_combination_limit.
4991 (recombine_windows, make_parent_window, make_window)
4992 (Fsplit_window_internal, saved_window)
4993 (Fset_window_configuration, save_window_save): Rename all
4994 occurrences of window_nest to window_combination_limit.
4995
c7015153
JB
49962011-11-15 Juanma Barranquero <lekktu@gmail.com>
4997
4998 * image.c (imagemagick_load_image): Fix typo.
4999
322ad6ec
EZ
50002011-11-14 Eli Zaretskii <eliz@gnu.org>
5001
5002 * xdisp.c (display_line): Move the call to
5003 highlight_trailing_whitespace before the call to
5004 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5005 faces of all the glyphs to compute ROW's hash value.
5006 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5007
f067b8ec
JB
50082011-11-14 Juanma Barranquero <lekktu@gmail.com>
5009
5010 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5011 just return (bug#10044).
5012
1e5b2111
EZ
50132011-11-12 Eli Zaretskii <eliz@gnu.org>
5014
7ef3cbd5
EZ
5015 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5016 with user-defined heap size. Bump the default size of the temacs
5017 heap to 27MB, to avoid memory warning when running temacs.
5018 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5019
1e5b2111
EZ
5020 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5021 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5022 (verify_row_hash) [XASSERTS]: New function.
5023 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5024 that the hash value of glyph rows is correct.
1e5b2111 5025
89d61221
MR
50262011-11-12 Martin Rudalics <rudalics@gmx.at>
5027
5028 * window.h (window): Remove splits slot.
5029 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5030 (Fdelete_other_windows_internal, make_parent_window)
5031 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5032 (Fset_window_configuration, save_window_save): Don't deal with
5033 split status of windows.
5034 (saved_window): Remove splits slot.
5035 (Vwindow_splits): Rewrite doc-string.
5036
97f18cc8
JD
50372011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5038
5039 * xfns.c (unwind_create_frame):
5040 * nsfns.m (unwind_create_frame):
5041 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5042 Vframe_list (Bug#9999).
5043
22a648b4
DA
50442011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5045
0b381c7e 5046 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5047
659afede
KH
50482011-11-11 Kenichi Handa <handa@m17n.org>
5049
5050 * callproc.c (Fcall_process): Set the member dst_multibyte of
5051 process_coding.
5052
9ac0394b
KH
50532011-11-11 Johan Bockgård <bojohan@gnu.org>
5054
5055 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5056 avoid a crash (bug#9496).
5057
2fbdc249
CY
50582011-11-09 Chong Yidong <cyd@gnu.org>
5059
5060 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5061 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5062
ac6b1f81
PE
50632011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5064
5065 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5066
09db192c
PE
50672011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 Avoid some portability problems by eschewing 'extern inline' functions.
5070 The trivial performance wins aren't worth the portability hassles; see
5071 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5072 et seq.
5073 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5074 (window_box_width, window_box_left, window_box_left_offset)
5075 (window_box_right, window_box_right_offset): Undo previous change,
5076 by removing the "extern"s.
5077 * intervals.c (adjust_intervals_for_insertion)
5078 (adjust_intervals_for_deletion): Undo previous change,
5079 making these static again.
5080 (offset_intervals, temp_set_point_both, temp_set_point)
5081 (copy_intervals_to_string): No longer inline.
5082 * xdisp.c (window_text_bottom_y, window_box_width)
5083 (window_box_height, window_box_left_offset)
5084 (window_box_right_offset, window_box_left, window_box_right)
5085 (window_box): No longer inline.
5086
105216ed
CY
50872011-11-08 Chong Yidong <cyd@gnu.org>
5088
5089 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5090 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5091 Signal an error if not a live window.
105216ed
CY
5092 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5093 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5094
ae9e237f
JB
50952011-11-07 Juanma Barranquero <lekktu@gmail.com>
5096
5097 * lisp.h (syms_of_abbrev): Remove declaration.
5098 Reported by CHENG Gao <chenggao@royau.me>.
5099
c7aa8333
EZ
51002011-11-07 Eli Zaretskii <eliz@gnu.org>
5101
5102 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5103 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5104 of temacs in GUI mode.
5105
be7f5545
MR
51062011-11-07 Martin Rudalics <rudalics@gmx.at>
5107
5108 * window.h: Declare delete_all_child_windows instead of
5109 delete_all_subwindows.
5110 * window.c (Fwindow_nest, Fset_window_nest)
5111 (Fset_window_new_total, Fset_window_new_normal)
5112 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5113 (delete_all_subwindows): Rename to delete_all_child_windows.
5114 (Fdelete_other_windows_internal, Fset_window_configuration):
5115 Call delete_all_child_windows instead of delete_all_subwindows.
5116 * frame.c (delete_frame): Call delete_all_child_windows instead
5117 of delete_all_subwindows.
5118
ca78dc43
PE
51192011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5120
5121 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5122 This is also needed for porting to any host where GC_MARK_STACK is
5123 not GC_MAKE_GCPROS_NOOPS.
5124 (which_symbols): Use it.
5125
a0241d01
KH
51262011-11-07 Kenichi Handa <handa@m17n.org>
5127
5128 * coding.c (coding_set_destination): Check coding->src_pos only
5129 when coding->src_object is a buffer (bug#9910).
5130
5131 * process.c (send_process): Set the member src_multibyte of coding
5132 to 0 (bug#9911) when sending a unibyte text.
5133
5134 * callproc.c (Fcall_process): Set the member src_multibyte of
5135 process_coding to 0 (bug#9912).
5136
a64bfdfa 51372011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5138
5139 * xmenu.c (cleanup_widget_value_tree): New function.
5140 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5141 calling free_menubar_widget_value_tree directly (Bug#9830).
5142
cb41b32a
PE
51432011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5144
5145 Fix some portability problems with 'inline'.
5146 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5147 (window_box_width, window_box_left, window_box_left_offset)
5148 (window_box_right, window_box_right_offset): Declare extern.
5149 Otherwise, these inline functions do not conform to C99 and
5150 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5151 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5152 * intervals.c (adjust_intervals_for_insertion)
5153 (adjust_intervals_for_deletion): Now extern, because otherwise the
5154 extern inline functions 'offset_intervals' couldn't refer to it.
5155 (static_offset_intervals): Remove.
5156 (offset_intervals): Rewrite using the old contents of
5157 static_offset_intervals. The old version didn't conform to C99
5158 because an extern inline function contained a reference to an
5159 identifier with static linkage.
5160
b7041366
AS
51612011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5162
5163 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5164 GC.
5165
88a37c4d
EZ
51662011-11-06 Eli Zaretskii <eliz@gnu.org>
5167
5168 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5169 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5170 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5171 return Qleft_to_right.
5172
49745b39
CY
51732011-11-06 Chong Yidong <cyd@gnu.org>
5174
5175 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5176 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5177 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5178 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5179 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5180 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5181 (Fwindow_vscroll): Doc fix.
5182 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5183 argument, since it makes no sense to pass a live window and for
5184 consistency with window-child.
5185
1f05cd82
CS
51862011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5187
5188 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5189 support MSVC.
5190
22610910
JR
51912011-11-05 Jason Rumney <jasonr@gnu.org>
5192
5193 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5194 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5195 fonts (Bug#6029).
5196 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5197 bitwise arithmetic preventing use of unicode-sip and non-truetype
5198 opentype fonts.
5199
a06776b2
EZ
52002011-11-05 Eli Zaretskii <eliz@gnu.org>
5201
3ad924ba
EZ
5202 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5203 "emacs"-only part.
5204
a06776b2
EZ
5205 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5206 initialization code to keep similarity to xfns.c after changes
5207 from 2011-11-05.
5208
c9e7db78
JD
52092011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5210
a97f8f3f
JD
5211 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5212 (unwind_create_frame): New function (Bug#9943).
5213 (Fx_create_frame): Restructure code to be more similar to the one in
5214 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5215 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5216 Move terminal->reference_count++ just before making the frame official
5217 (Bug#9943).
5218
5219 * nsterm.m (x_free_frame_resources): New function.
5220 (x_destroy_window): Move code to x_free_frame_resources.
5221
c9e7db78 5222 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5223 (Fx_create_frame, x_create_tip_frame):
5224 Move terminal->reference_count++ just before making the frame
75f1671a 5225 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5226 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5227
a6fc3b5c
EZ
52282011-11-05 Eli Zaretskii <eliz@gnu.org>
5229
5230 Support MSVC build with newer versions of Visual Studio.
5231 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5232 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5233 nt/gmake.defs.
5234
5235 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5236 which are not supported by MSVC.
5237 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5238 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5239 bitfields.
5240 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5241 types in bitfields.
5242 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5243
5244 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5245
58179cce 52462011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5247
5248 Support MSVC build with newer versions of Visual Studio.
5249 * w32.c: Don't include w32api.h for MSVC.
5250 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5251
5252 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5253 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5254 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5255 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5256 e_* cousins.
5257 (alloca) [_MSC_VER]: Define to _alloca.
5258
5259 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5260
5261 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5262
a58c13ed
EZ
52632011-11-04 Eli Zaretskii <eliz@gnu.org>
5264
5265 * xdisp.c (note_mouse_highlight): If either of
5266 previous/next-single-property-change returns nil, treat that as
5267 the beginning or the end of the buffer. (Bug#9955)
5268
fe0b6370
JD
52692011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5270
a58c13ed 5271 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5272 label is not null (Bug#9951).
5273 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5274 may be NULL.
5275
89bd5ee1
EZ
52762011-11-04 Eli Zaretskii <eliz@gnu.org>
5277
5278 * window.c (Fwindow_body_size): Mention in the doc string that the
5279 return value is in frame's canonical units. (Bug#9949)
5280
84c3edb9
EZ
52812011-11-03 Eli Zaretskii <eliz@gnu.org>
5282
4e2fb5c7
EZ
5283 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5284
84c3edb9 5285 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5286 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5287 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5288
bc17a887
EZ
52892011-11-01 Eli Zaretskii <eliz@gnu.org>
5290
5291 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5292 Don't stop backward scan on the continuation glyph, even though
5293 its CHARPOS is positive.
6d5eb5b0
SM
5294 (mouse_face_from_buffer_pos, note_mouse_highlight):
5295 Rename cover_string to disp_string.
bc17a887 5296
4ee88440
MR
52972011-11-01 Martin Rudalics <rudalics@gmx.at>
5298
5299 * window.c (temp_output_buffer_show): Don't use
5300 Vtemp_buffer_show_specifiers.
5301 (Vtemp_buffer_show_specifiers): Remove unused variable.
5302
c2ff3c02
EZ
53032011-10-30 Eli Zaretskii <eliz@gnu.org>
5304
5305 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5306 past the beginning of the current glyph matrix.
5307
58179cce 53082011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5309
5310 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5311 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5312 HAVE_GTK3 (Bug#9869).
b77a6a7f 5313
3b574623
JD
5314 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5315 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5316
b77a6a7f
JD
5317 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5318
5319 * xterm.c: Declare x_handle_net_wm_state to return int.
5320 (handle_one_xevent): Check if we are iconified but don't have
5321 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5322 (get_current_wm_state): Return non-zero if not hidden,
5323 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5324 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5325 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5326 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5327
196e41e4
PE
53282011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5329
5330 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5331 so that this new function doesn't get optimized away by a
5332 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5333
021f2e1a
AS
53342011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5335
5336 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5337
8b058d44
EZ
53382011-10-29 Eli Zaretskii <eliz@gnu.org>
5339
5340 Fix the `xbytecode' command.
5341 * .gdbinit (xprintbytestr): New command.
b50a28de 5342 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5343 (xbytecode): Print the byte-code string as well.
5344
4452fb80
EZ
53452011-10-29 Kim Storm <storm@cua.dk>
5346
8b058d44
EZ
5347 * alloc.c (which_symbols): New function.
5348
21b72067
AS
53492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5350
5351 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5352 line. (Bug#9903)
5353
83ed7b5c
GM
53542011-10-29 Glenn Morris <rgm@gnu.org>
5355
5356 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5357 Not clear what it was for, and it causes various bugs. (Bug#9839)
5358
5a7a728b
EZ
53592011-10-28 Eli Zaretskii <eliz@gnu.org>
5360
5361 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5362 possible random value that matches one of those tested as
5363 condition to clear the mouse face.
5364
d3d0842f
CY
53652011-10-28 Chong Yidong <cyd@gnu.org>
5366
5367 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5368
31b39d13
DN
53692011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5370
5371 * window.c (make_window): Initialize phys_cursor_on_p.
5372
9aba6043
SM
53732011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5374
5375 * lisp.h (struct Lisp_Symbol): Update comments.
5376
c20992f4
JB
53772011-10-28 Juanma Barranquero <lekktu@gmail.com>
5378
5379 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5380
db4f02f2
EZ
53812011-10-28 Eli Zaretskii <eliz@gnu.org>
5382
5383 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5384 <oslsachem@gmail.com> for helping to debug this.
5385
5386 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5387 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5388 (g_b_init_get_glyph_outline_w): New static variables.
5389 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5390 (GetGlyphOutlineW_Proc): New typedefs.
5391 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5392 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5393 New functions.
5394 (w32font_open_internal, compute_metrics):
5395 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5396 instead of calling the "wide" APIs directly.
5397
5398 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5399
5400 * w32.h (syms_of_w32font): Add prototype.
5401
87e68db4
JB
54022011-10-27 Juanma Barranquero <lekktu@gmail.com>
5403
5404 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5405 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5406 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5407 (Fmove_to_window_line): Doc fix.
5408
435c1d67
CY
54092011-10-27 Chong Yidong <cyd@gnu.org>
5410
5411 * process.c (make_process): Set gnutls_state to NULL.
5412
5413 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5414 non-NULL, regardless of GNUTLS_INITSTAGE.
5415 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5416 an error. Set process slots as soon as we allocate them.
5417
5418 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5419
9c6c6f49
CY
54202011-10-27 Chong Yidong <cyd@gnu.org>
5421
9aba6043
SM
5422 * gnutls.c (emacs_gnutls_deinit): New function.
5423 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5424 (Fgnutls_deinit, Fgnutls_boot): Use it.
5425
5426 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5427 (deactivate_process): Call emacs_gnutls_deinit.
5428
657d08d3
JB
54292011-10-27 Juanma Barranquero <lekktu@gmail.com>
5430
5431 * image.c (x_create_x_image_and_pixmap):
5432 * w32.c (sys_rename, w32_delayed_load):
5433 * w32font.c (fill_in_logfont):
5434 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5435
5430d399
JB
54362011-10-26 Juanma Barranquero <lekktu@gmail.com>
5437
5438 * w32fns.c (w32_default_color_map): New function,
5439 extracted from Fw32_default_color_map.
a7ef684b 5440 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5441
fe0055fa
PE
54422011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5445
e6346438
SM
54462011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5447
5448 * keyboard.c (test_undefined): New function (bug#9751).
5449 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5450
e112cc37
ET
54512011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5452
5453 * sysdep.c (init_sys_modes): Fix the check for the controlling
5454 terminal (Bug#6649).
5455
7b5d6677
EZ
54562011-10-20 Eli Zaretskii <eliz@gnu.org>
5457
5458 * dispextern.h (struct bidi_it): New member next_en_type.
5459
5460 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5461 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5462 current character, check also for next_en_type being WEAK_EN.
5463 (bidi_resolve_weak): Don't enter the expensive loop if the current
5464 position is before next_en_pos. Record the bidi type of the first
5465 non-ET, non-BN character we find, in addition to its position.
5466 (bidi_level_of_next_char): Invalidate next_en_type when
5467 next_en_pos is over-stepped.
5468
7da0b018
PE
54692011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5470
5471 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5472 * editfns.c: Rewrite current-time-zone so that it invokes
5473 the equivalent of (format-time-string "%Z") to get the time zone name.
5474 This fixes a bug when the time zone name contains characters that
5475 need converting from the system time locale to Emacs internal format.
5476 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5477 that patch fixed format-time-string to do the conversion, but
5478 I forgot to fix current-time-zone.
5479 (format_time_string): New function, containing most of
5480 what Fformat_time_string used to contain.
5481 (Fformat_time_string): Rewrite in terms of format_time_string.
5482 This doesn't change this function's behavior.
5483 (current-time-zone): Rewrite to use format_time_string.
5484 This fixes the bug reported by Michael Schierl in
5485 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5486 Jason Rumney's 2007-06-07 change worked around this bug, but
5487 didn't fix it.
5488 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5489
8547b010
EZ
54902011-10-19 Eli Zaretskii <eliz@gnu.org>
5491
5492 * xdisp.c (start_display): If the character at POS is displayed
5493 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5494 (try_window_reusing_current_matrix): If a line ends in a display
5495 vector or the next line starts in a display vector, continue
5496 redrawing the window even though the character position of
5497 start_row was reached.
8547b010
EZ
5498 (Bug#9771, part 2)
5499
4e948d15
CY
55002011-10-18 Chong Yidong <cyd@gnu.org>
5501
5502 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5503 with nobreak-char-display too.
5504
4787455f
EZ
55052011-10-18 Eli Zaretskii <eliz@gnu.org>
5506
5507 Fix part 3 of bug#9771.
5508 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5509 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5510 non-neutral characters if the current character is a paragraph
5511 separator (a.k.a. Newline). This avoids running the same
5512 expensive loop twice, once when we consume the preceding newline
5513 and the other time when the line actually needs to be displayed.
5514 Avoid the loop when we see neutrals on the base embedding level
5515 following a character whose directionality is the same as the
5516 paragraph's. This avoids running the expensive loop when a line
5517 ends in a long sequence of neutrals, like control characters.
5518 Add assertion against STRONG_AL type. Slightly rearrange code
5519 that determines the type of a neutral given the first non-neutral
5520 that follows it.
5521 (bidi_level_of_next_char): Set next_en_pos to zero when
5522 invalidating its info.
5523
2c91f553
EZ
55242011-10-17 Eli Zaretskii <eliz@gnu.org>
5525
5526 * xdisp.c (push_display_prop): Determine whether to record string
5527 or buffer position by IT->string, not by IT->method. Allow
5528 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5529 (move_it_vertically_backward): Don't look for character position
5530 immediately after the newline when in a continuation line.
5531 (Bug#9771, part 1)
2c91f553 5532
c7b08b0d
MR
55332011-10-15 Martin Rudalics <rudalics@gmx.at>
5534
5535 * window.c (coordinates_in_window): Rewrite and delabelize
5536 vertical border check. (Bug#5357) (Bug#9618)
5537
6b02f655
SM
55382011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5539
5540 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5541 errors in XSetWindowBorder (bug#9310).
5542
81d40c92
DA
55432011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5544
5545 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5546 avoid crash when xmalloc overrun checking is enabled.
5547
d4172c3b
EZ
55482011-10-13 Eli Zaretskii <eliz@gnu.org>
5549
5550 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5551 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5552 cursor motion with <left> and <right> arrow keys.
5553
5554 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5555 some callers set that themselves.
5556
b00eea75
EZ
55572011-10-12 Eli Zaretskii <eliz@gnu.org>
5558
5559 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5560 display string and the previous row comes from the same string and
5561 is empty. (Bug#9739) (Bug#9738)
5562
8fe012c4
SM
55632011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5564
5565 * doc.c (get_doc_string): Encode file name (bug#9735).
5566
0074aef2
EZ
55672011-10-12 Eli Zaretskii <eliz@gnu.org>
5568
79beb178
EZ
5569 * bidi.c (bidi_level_of_next_char):
5570 * xdisp.c (get_visually_first_element): Remove old incorrect
5571 comments regarding the Unicode Line Separator character.
5572
0074aef2
EZ
5573 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5574
6e4b3fbe
DA
55752011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5576
5577 * alloc.c (Fgc_status): Do not access beyond zombies array
5578 boundary if nzombies > MAX_ZOMBIES.
5579 * alloc.c (dump_zombies): Add missing format specifier.
5580
0324f3af
PE
55812011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5582
b5525cac
PE
5583 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5584 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5585
0324f3af
PE
5586 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5587 Some packages use them to denote characters with modifiers.
5588
e9b5f888
AS
55892011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5590
5591 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5592 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5593 matching a pp-number. Rename parameter var to var1.
5594
127827c0
SM
55952011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5596
5597 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5598
c8fd3bd0
GM
55992011-10-08 Glenn Morris <rgm@gnu.org>
5600
5601 * callint.c (Fcall_interactively): Give a more explicit error for the
5602 'c' case with a non-character input. (Bug#8479)
5603
352ec8ff
EZ
56042011-10-08 Eli Zaretskii <eliz@gnu.org>
5605
03669ccb
EZ
5606 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5607 lines.
7061c986
EZ
5608 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5609 lines that are hscrolled on the left.
03669ccb 5610
352ec8ff
EZ
5611 * dispnew.c (buffer_posn_from_coords): Account for a possible
5612 presence of header-line. (Bug#4426)
5613
a66cfb1c
SM
56142011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5615
6b02f655
SM
5616 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5617 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5618
7c5ee88e
PE
56192011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5620
5621 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5622 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5623 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5624 this makes Emacs dump core during garbage collection on rare
5625 occasions. sizeof is obviously inferior to offsetof here, so
5626 stick with offsetof.
5627 (GC_POINTER_ALIGNMENT): New macro.
5628 (mark_memory): Omit 3rd (offset) arg; caller changed.
5629 Don't assume EMACS_INT alignment is the same as pointer alignment.
5630
df1bbe5b
SM
56312011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5632
5633 * keyboard.c (read_key_sequence_remapped): New var.
5634 (read_key_sequence): Compute remapping in the right buffer.
5635 (command_loop_1): Use read_key_sequence's remapping directly.
5636
51553db6
SM
56372011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5638
32c1fffd
SM
5639 * dired.c (file_name_completion): Don't expand file name.
5640 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5641 before checking file name handler.
5642
51553db6
SM
5643 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5644 they've been requested explicitly (bug#9591).
5645
b6bd1599 56462011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5647
5648 * keymap.c (Fsingle_key_description): Use make_specified_string
5649 instead of build_string to build string from push_key_description.
5650 (Bug#5193)
5651
f701dc2a
PE
56522011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5653
4222c55d
PE
5654 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5655 This fixes a Y2038 bug on 64-bit hosts.
5656 * buffer.c (reset_buffer):
5657 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5658 (Fclear_buffer_auto_save_failure):
5659 Use 0, not -1, to represent an unset failure time, since time_t
5660 might not be signed.
5661
f701dc2a
PE
5662 Remove dependency on glibc malloc internals.
5663 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5664 Move back here from lisp.h, but with their new implementations.
5665 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5666 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5667 * charset.c (charset_table_init): New static var.
5668 (syms_of_charset): Use it instead of xmalloc. This removes a
5669 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5670 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5671 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5672 Move back to alloc.c.
5673 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5674 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5675
9ceebf39
JD
56762011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5677
5678 * nsterm.m (windowDidResize): Call x_set_window_size only when
5679 ns_in_resize is true. Otherwise set pixelwidth/height and
5680 call change_frame_size (Bug#9628).
5681
cb993c58
PE
56822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5683
3930c88b
PE
5684 Port --enable-checking=all to Fedora 14 x86-64.
5685 * charset.c (syms_of_charset): Also account for glibc malloc's
5686 internal overhead when calculating the initial malloc maximum.
5687
cb993c58
PE
5688 Port --enable-checking=all to Fedora 14 x86.
5689 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5690 Move to lisp.h.
5691 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5692 (overrun_check_realloc, overrun_check_free):
5693 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5694 That way, xmalloc returns a properly-aligned pointer even if
5695 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5696 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5697 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5698 into account when calculating the initial malloc maximum.
5699 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5700 Move here from alloc.c, so that charset.c can use it too.
5701 Properly align; the old code wasn't right for common 32-bit hosts
5702 when configured with --enable-checking=all.
5703 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5704 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5705
31bed486
EZ
57062011-09-29 Eli Zaretskii <eliz@gnu.org>
5707
04c70788 5708 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5709 use EDOM.
5710
fbcaa2f3
EZ
57112011-09-28 Eli Zaretskii <eliz@gnu.org>
5712
5713 * xdisp.c (compute_display_string_end): If there's no display
5714 string at CHARPOS, return -1.
5715
5716 * bidi.c (bidi_fetch_char): When compute_display_string_end
5717 returns a negative value, treat the character as a normal
5718 character not covered by a display string. (Bug#9624)
5719
a239d4e9
JB
57202011-09-28 Juanma Barranquero <lekktu@gmail.com>
5721
5722 * lread.c (Fread_from_string): Fix typo in docstring.
5723
88652fd5
EZ
57242011-09-27 Eli Zaretskii <eliz@gnu.org>
5725
5726 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5727 newline, reseat the iterator instead of bidi-iterating there one
5728 character at a time. (Bug#9610)
32c1fffd
SM
5729 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5730 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5731
ed497dd4
AS
57322011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5733
5734 * lread.c (readevalloop): Use correct code for NBSP.
5735 (read1): Likewise. (Bug#9608)
5736
b2bf61aa
MA
57372011-09-25 Michael Albinus <michael.albinus@gmx.de>
5738
5739 * dbusbind.c (Fdbus_register_signal): When service is not
5740 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5741
32bbb17c
GM
57422011-09-25 Glenn Morris <rgm@gnu.org>
5743
5744 * buffer.c (truncate-lines): Doc fix.
5745
94e0933e
CY
57462011-09-24 Chong Yidong <cyd@stupidchicken.com>
5747
5748 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5749 (Fset_window_next_buffers): Doc fix.
5750
cddde921
GM
57512011-09-24 Glenn Morris <rgm@gnu.org>
5752
5753 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5754
1260aef1
PE
57552011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5756
25b4bfa0
PE
5757 Fix minor problems found by static checking.
5758 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5759 * indent.c (Fvertical_motion): Fix == vs = typo.
5760
e3cbd34b
EZ
57612011-09-24 Eli Zaretskii <eliz@gnu.org>
5762
a66cfb1c
SM
5763 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5764 Default value is now t. Doc fix.
6bf7006f 5765
e3cbd34b 5766 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5767 logic when moving up, not only when moving down. Fix the
e3cbd34b 5768 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5769 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5770
5771 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5772 CHARPOS is covered by a display string which includes newlines.
5773 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5774 is covered by a display string with embedded newlines.
5775
a3de0cbd
MA
57762011-09-24 Michael Albinus <michael.albinus@gmx.de>
5777
5778 * dbusbind.c (Fdbus_register_signal): Add match rule to
5779 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5780 (Fdbus_register_method, Vdbus_registered_objects_table):
5781 Fix docstring.
a3de0cbd 5782
b260039d
JM
57832011-09-24 Jim Meyering <meyering@redhat.com>
5784
32c1fffd 5785 do not ignore write error for any output size
b260039d
JM
5786 The previous change was incomplete.
5787 While it makes emacs --batch detect the vast majority of stdout
5788 write failures, errors were still ignored whenever the output size is
5789 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5790 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5791 && echo FAIL: ignored write error
5792 FAIL: ignored write error
5793 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5794 && echo FAIL: ignored write error
5795 FAIL: ignored write error
5796 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5797
8eca8a7c
AS
57982011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5799
5800 * emacs.c (Fkill_emacs): In noninteractive mode exit
5801 non-successfully if a write error occurred on stdout. (Bug#9574)
5802
3341db62
EZ
58032011-09-21 Eli Zaretskii <eliz@gnu.org>
5804
5805 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5806 the xassert test.
5807
5808 * dispextern.h (struct it): Update the comment documenting what
5809 can it->OBJECT be.
5810
8c203dbf
EZ
58112011-09-20 Eli Zaretskii <eliz@gnu.org>
5812
5813 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5814 a display string, extend search for cursor position to end of row.
5815 (find_row_edges): If the row ends in a newline from a display
5816 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5817 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5818 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5819 non-empty line. Fixes confusing cursor motion with arrow keys at
5820 the beginning of a line that starts with whitespace.
8c203dbf 5821
a4824228
LMI
58222011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5823
5824 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5825 (bug#9493).
5826
33ed493b
CY
58272011-09-18 Chong Yidong <cyd@stupidchicken.com>
5828
5829 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5830 boolean (Bug#9154).
5831
56cd55c8
EZ
58322011-09-18 Eli Zaretskii <eliz@gnu.org>
5833
5834 * xdisp.c (display_line): Record maximum and minimum buffer
5835 positions even if no glyphs were produced (e.g., by a zero-width
5836 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5837 buffer positions that will be removed from the glyph row because
5838 they don't fit.
c02dcedf
EZ
5839 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5840 column is beyond frame width: don't subtract 1 "pixel" when
5841 computing width of the stretch.
3e62b7e0
EZ
5842 (reseat_at_next_visible_line_start): Undo the change made on
5843 2011-09-17 that saved paragraph information and restored it after
5844 the call to `reseat'. (Bug#9545)
56cd55c8 5845
5ed99d36 58462011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5847
5848 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5849 and turn window cursor on if cleared (Bug#9415).
5850
5ed99d36 58512011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5852
5853 * search.c (boyer_moore): Take unibyte characters from pattern
5854 literally. (Bug#9458)
5855
9bade7b2
EZ
58562011-09-18 Eli Zaretskii <eliz@gnu.org>
5857
5858 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5859
e5e9d610
PE
58602011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5861
87e4427a
PE
5862 Fix minor problem found by static checking.
5863 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5864 initialized, to pacify gcc -Wuninitialized.
5865
e5e9d610
PE
5866 * fileio.c: Report proper errno when syscall falls.
5867 (Finsert_file_contents): Save and restore errno,
5868 so that report_file_error outputs the correct diagnostic.
5869 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5870
a1674f0b
EZ
58712011-09-18 Eli Zaretskii <eliz@gnu.org>
5872
5873 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5874
fbfb6dd4
EZ
58752011-09-17 Eli Zaretskii <eliz@gnu.org>
5876
5877 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5878 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5879
bb187662
EZ
58802011-09-17 Eli Zaretskii <eliz@gnu.org>
5881
1137e8b8 5882 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5883 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5884
5885 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5886 (bidi_find_paragraph_start): Search back for paragraph beginning
5887 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5888 (bidi_move_to_visually_next): Only trigger paragraph-related
5889 computations when the last character is a newline or at EOB, not
5890 just any NEUTRAL_B. (Bug#9470)
5891
bb187662
EZ
5892 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5893 truncated lines if point is covered by a display string. (Bug#9524)
5894
2e621251
PE
58952011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5896
5897 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5898 (cons_to_x_long): New function.
5899 (lisp_data_to_selection_data): Use it. Correct the test for
5900 short-versus-long data; it was negated. Break out of vector
5901 loop, for efficiency, when a long datum is discovered.
5902
91a15bc6
SM
59032011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5904
5905 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5906
b41c3a35
EZ
59072011-09-16 Eli Zaretskii <eliz@gnu.org>
5908
5909 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5910 GCC PR/17406) by declaring this function with external scope.
5911
7812ba2d
PE
59122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5913
5914 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5915 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5916
cf7edc2a
AS
59172011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5918
5919 * editfns.c (Fformat): Correctly handle text properties on "%%".
5920
bd01620e
EZ
59212011-09-15 Eli Zaretskii <eliz@gnu.org>
5922
5923 * xterm.c (x_draw_composite_glyph_string_foreground):
5924 * w32term.c (x_draw_composite_glyph_string_foreground):
5925 * term.c (encode_terminal_code):
5926 * composite.c (composition_update_it, get_composition_id):
5927 * xdisp.c (get_next_display_element)
5928 (fill_composite_glyph_string): Add comments about special meaning
5929 of TAB characters in a composition.
5930
a02719a3
PE
59312011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5932
5933 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5934 This occurs when processing a multibyte format.
5935 Problem reported by Wolfgang Jenker.
a02719a3 5936
72589a3c
JB
59372011-09-15 Johan Bockgård <bojohan@gnu.org>
5938
5939 * xdisp.c (try_cursor_movement): Only check for exact match if
5940 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5941
1c14176c
PE
59422011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5943
5944 Remove unused external symbols.
5945 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5946 * xdisp.c (calc_pixel_width_or_height): Now static.
5947 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5948 * indent.c (check_display_width):
5949 * w32term.c: Fix comment to match code.
5950 * xterm.c, xterm.h (x_catching_errors): Remove.
5951
d2eea5b5
PE
59522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5953
5954 * xselect.c: Use signed conversions more consistently (Bug#9498).
5955 (selection_data_to_lisp_data): Assume incoming selection data are
5956 signed integers, not unsigned. This is to be consistent with
5957 outgoing selection data, which was modified to use signed integers
5958 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5959 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5960 expects long, not unsigned long.
5961
46888499
EZ
59622011-09-14 Eli Zaretskii <eliz@gnu.org>
5963
5964 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5965 computation of loop end. Reported by Johan Bockgård
5966 <bojohan@gnu.org>.
5967
ef8ef9fb
CY
59682011-09-13 Chong Yidong <cyd@stupidchicken.com>
5969
5970 * frame.c (Fother_visible_frames_p): Function deleted.
5971
fa819fed
EZ
59722011-09-12 Eli Zaretskii <eliz@gnu.org>
5973
5974 * indent.c (compute_motion): Process display vector front to back
5975 rather than the other way around. (Bug#2496)
5976
2ba8e008
SM
59772011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5978
5979 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5980
20f53c69
CY
59812011-09-11 Chong Yidong <cyd@stupidchicken.com>
5982
5983 * minibuf.c (Fread_from_minibuffer): Doc fix.
5984
d562d7a4
EZ
59852011-09-11 Eli Zaretskii <eliz@gnu.org>
5986
5987 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5988 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5989
1c4d7f3d
LMI
59902011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5991
5992 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5993 value for non-existent files.
5994
b885bf36
EZ
59952011-09-11 Eli Zaretskii <eliz@gnu.org>
5996
5997 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5998 set its "size" to -1. This will set the modtime_size field of
5999 the corresponding buffer to -1, which is what
6000 verify-visited-file-modtime expects for files that do not exist.
6001 (Bug#9139)
6002
6612f0bf
PE
60032011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6004
6005 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6006 here ...
6007 * lisp.h: ... from here. push_key_description is no longer
6008 defined in keyboard.c, so its declaration should not be in
6009 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6010 logically belongs with push_key_description.
6011
dfb3f755
PE
60122011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6013
6014 * buffer.h: Include <sys/types.h> instead of <time.h>.
6015 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6016 Problem reported by Herbert J. Skuhra.
6017
3134906c
LMI
60182011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6019
6020 * xml.c (parse_region): Make the parsing work for
6021 non-comment-starting XML files again (bug#9144).
6022
8d903f4e
AS
60232011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6024
6025 * image.c (gif_load): Fix calculation of bottom and right corner.
6026 (Bug#9468)
6027
80ad64f4
EZ
60282011-09-10 Eli Zaretskii <eliz@gnu.org>
6029
6030 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6031 redisplay in small windows.
6032
208a048d
EZ
60332011-09-09 Eli Zaretskii <eliz@gnu.org>
6034
6035 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6036
9b1c252e
MR
60372011-09-08 Martin Rudalics <rudalics@gmx.at>
6038
6039 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6040 Operate on live windows only.
6041
2949f33b
JB
60422011-09-08 Juanma Barranquero <lekktu@gmail.com>
6043
6044 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6045
e08dcafd
EZ
60462011-09-07 Eli Zaretskii <eliz@gnu.org>
6047
6048 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6049 only under bidi iteration.
6050
115b96bd
JD
60512011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6052
6053 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6054
c8199d0f
PE
60552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6056
6057 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6058 Without this fix, the command to link temacs failed due to an
6059 undefined symbol __builtin_isnan. This is because
6060 /usr/include/iso/math_c99.h #defines isnan(x) to
6061 __builtin_isnan(x), but the bundled gcc, which identifies itself
6062 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6063 a __builtin_isnan.
6064 * floatfns.c (isnan): #undef, and then #define to a clone of
6065 what's in data.c.
6066 (Fisnan): Always define, since it's always available now.
6067 (syms_of_floatfns): Always define isnan at the Lisp level.
6068
e39b275c 60692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6070
6071 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6072
b2db44d9 60732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6074
f4af5137 6075 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6076 The previous code assumed that file offsets (off_t values) fit in
6077 EMACS_INT variables, which is not true on typical 32-bit hosts.
6078 The code messed up by falsely reporting buffer overflow in cases
6079 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6080 when "big" contains more than 2**29 bytes, even though this
6081 inserts just one byte and does not overflow the buffer.
6082 (Finsert_file_contents): Store file offsets as off_t
6083 values, not as EMACS_INT values. Check for overflow when
6084 converting between EMACS_INT and off_t. When checking for
6085 buffer overflow or for overlap, take the offsets into account.
6086 Don't use EMACS_INT for small values where int suffices.
6087 When checking for overlap, fix a typo: ZV was used where
6088 ZV_BYTE was intended.
6089 (Fwrite_region): Don't assume off_t fits into 'long'.
6090 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6091
ecfc0a49
MA
60922011-09-05 Michael Albinus <michael.albinus@gmx.de>
6093
6094 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6095
6511acf2 60962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6097
0999621a 6098 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6099
6100 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6101 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6102 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6103 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6104 (modify_event_symbol): Do not assume that the length of
6105 name_alist_or_stem is safe to alloca and fits in int.
6106 (Fexecute_extended_command): Likewise for function name and binding.
6107 (Frecursion_depth): Wrap around reliably on integer overflow.
6108 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6109 since some callers pass EMACS_INT values.
6110 (Fsingle_key_description): Don't crash if symbol name contains more
6111 than MAX_ALLOCA bytes.
6112 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6113 (get_minibuffer): Arg is now EMACS_INT, not int.
6114 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6115 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6116 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6117
2be7d702
PE
6118 * dbusbind.c (signature_cat): New function.
6119 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6120 Do not overrun buffer; instead, report string overflow.
6121
9d1df220
PE
6122 * dispnew.c (add_window_display_history): Don't overrun buffer.
6123 Truncate instead; this is OK since it's just a log.
6124
33ef5c64
PE
6125 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6126 even if the time zone offset is outlandishly large.
6127 Don't mishandle offset == INT_MIN.
6128
66c6fdd5
PE
6129 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6130 when creating daemon; the previous buffer-overflow check was incorrect.
6131
d749b01b
PE
6132 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6133 which has the guts of the old verror function.
6134
b5cd1905
PE
6135 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6136 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6137
6e1a67fb
PE
6138 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6139 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6140 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6141 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6142 length of string rather than counting it via multiple sprintfs;
6143 that's simpler and more reliable.
c21721cc
PE
6144 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6145 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6146 sprintf, in case result does not fit in int.
6147
c57b67fc
PE
6148 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6149 (fontset_from_font): Print it.
6150
8a401434
PE
6151 * frame.c (tty_frame_count): Now printmax_t, not int.
6152 (make_terminal_frame, set_term_frame_name): Print it.
6153 (x_report_frame_params): In X, window IDs are unsigned long,
6154 not signed long, so print them as unsigned.
6155 (validate_x_resource_name): Check for implausibly long names,
6156 and don't assume name length fits in 'int'.
6157 (x_get_resource_string): Don't blindly alloca invocation name;
6158 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6159 not fit in int.
6160
6e1a67fb
PE
6161 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6162 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6163 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6164
0df02bf3
PE
6165 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6166 Use esprintf, not sprintf, in case result does not fit in int.
6167
48e30793
PE
6168 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6169 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6170 it as a large positive number.
6171 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6172 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6173
a66ff6d8
PE
6174 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6175 in case result does not fit in int.
6176
aca216ff
PE
6177 * print.c (float_to_string): Detect width overflow more reliably.
6178 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6179 buffer overrun. Don't assume list length fits in 'int'. Treat
6180 print length of 0 as 0, not as infinity; to be consistent with other
6181 uses of print length in this function. Don't overflow print length
6182 index. Don't assume hash table size fits in 'long', or that
6183 vectorlike size fits in 'unsigned long'.
6184
31c286f7
PE
6185 * process.c (make_process): Use printmax_t, not int, to format
6186 process-name gensyms.
6187
55e5faa1
PE
6188 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6189
80f2e268
PE
6190 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6191 to avoid potential buffer overrun.
6192
670741ab
PE
6193 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6194 if X resource line is longer than 512 bytes.
6195
b7163a50
PE
6196 * xfns.c (x_window): Make sprintf buffer a bit bigger
6197 to avoid potential buffer overrun.
6198
ae58ff1f
PE
6199 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6200
c43c8a6a
PE
6201 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6202
3f8236f4
PE
62032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6204
53e9fe90 6205 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6206 Without these, Emacs silently mishandles large integers sometimes.
6207 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6208 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6209
6511acf2
PE
6210 * xdisp.c (try_window_id): Check Emacs fixnum range before
6211 converting to 'int'.
806add1d 6212
6511acf2 6213 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6214 Check that an Emacs fixnum is in range before assigning it to 'int'.
6215 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6216 values converted from Emacs fixnums.
6217 (Frecenter): Don't wrap around a line count if it is out of 'int'
6218 range; instead, treat it as an extreme value.
6219 (Fset_window_configuration, compare_window_configurations):
6220 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6221
6511acf2
PE
6222 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6223 that can exceed INT_MAX. Check that EMACS_INT value is in range
6224 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6225 (match_limit): Don't assume that a fixnum can fit in 'int'.
6226
6511acf2 6227 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6228 exceed INT_MAX.
6229
6511acf2 6230 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6231 (Fvertical_motion): Don't wrap around LINES values that don't fit
6232 in 'int'. Instead, treat them as extreme values. This is good
6233 enough for windows, which can't have more than INT_MAX lines anyway.
6234
fcb901a7
LMI
62352011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6236
0f2f6b6d
LMI
6237 * Require libxml/parser.h to avoid compilation warning.
6238
fcb901a7
LMI
6239 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6240
6241 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6242 since this reportedly can destroy thread storage.
6243
6e20a0d4
CY
62442011-08-30 Chong Yidong <cyd@stupidchicken.com>
6245
6246 * syntax.c (find_defun_start): Update all cache variables if
6247 exiting early (Bug#9401).
6248
148ae00e
EZ
62492011-08-30 Eli Zaretskii <eliz@gnu.org>
6250
f6cfbd8f
EZ
6251 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6252
148ae00e
EZ
6253 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6254 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6255 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6256
6257 * term.c (tty_append_glyph): New function.
6258 (produce_stretch_glyph): Static function and its prototype deleted.
6259
a66cfb1c
SM
6260 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6261 Add prototypes.
148ae00e 6262
c4a07a4c
PE
62632011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6264
6265 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6266 when checking :margin (Bug#9390).
6267 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6268 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6269 so that the name doesn't mislead. All uses changed.
6270
6bc8cd65
JB
62712011-08-28 Johan Bockgård <bojohan@gnu.org>
6272
6273 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6274 set_tty_hooks.
6275
dca4927e
EZ
62762011-08-27 Eli Zaretskii <eliz@gnu.org>
6277
6278 * xdisp.c (move_it_to): Don't bail out early when reaching
6279 position beyond to_charpos, if we are scanning backwards.
6280 (move_it_vertically_backward): When DY == 0, make sure we get to
6281 the first character in the line after the newline.
6282
f2cad773
PE
62832011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6284
6285 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6286 (ccl_driver): Do not generate an out-of-range pointer.
6287 (Fccl_execute_on_string): Remove unnecessary check for
6288 integer overflow, noted by Stefan Monnier in
6289 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6290 Remove a FIXME that didn't need fixing.
6291 Simplify the newly-introduced buffer reallocation code.
6292
0cae2cdb
JB
62932011-08-27 Juanma Barranquero <lekktu@gmail.com>
6294
6295 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6296
5fc295a4 62972011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6298
70c60eb2 6299 Integer and memory overflow issues (Bug#9196).
726e0ab1 6300
d31850da
PE
6301 * doc.c (get_doc_string): Rework so that
6302 get_doc_string_buffer_size is the actual buffer size, rather than
6303 being 1 less than the actual buffer size; this makes xpalloc more
6304 convenient.
6305
a69fbedb
PE
6306 * image.c (x_allocate_bitmap_record, cache_image):
6307 * xselect.c (Fx_register_dnd_atom):
6308 Simplify previous changes by using xpalloc.
6309
fe5c5d37
PE
6310 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6311 since either will do and ptrdiff_t is convenient with xpalloc.
6312
0065d054
PE
6313 * charset.c (charset_table_size)
6314 (struct charset_sort_data.priority): Now ptrdiff_t.
6315 (charset_compare): Don't overflow if priorities differ greatly.
6316 (Fsort_charsets): Don't assume list length fits in int.
6317 Check for size-calculation overflow when allocating sort data.
6318 (syms_of_charset): Allocate an initial charset table that is
6319 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6320
6321 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6322
6323 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6324 The actual value is always <= INT_MAX, and leaving it unsigned made
6325 overflow checking harder.
6326
6327 * dispextern.h (struct glyph_matrix.rows_allocated)
6328 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6329 with xpalloc. The values are still always <= INT_MAX.
6330
6331 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6332
6333 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6334 (SAFE_NALLOCA): New macro.
6335
6336 * region-cache.c (struct boundary.pos, find_cache_boundary)
6337 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6338 (set_cache_region, invalidate_region_cache)
6339 (revalidate_region_cache, know_region_cache, region_cache_forward)
6340 (region_cache_backward, pp_cache):
6341 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6342 so that ptrdiff_t * can be passed to xpalloc.
6343 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6344 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6345 (pp_cache): Don't assume cache_len fits in int.
6346 * region-cache.h: Adjust extern decls to match.
6347
6348 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6349 EMACS_INT, since either will do, for xpalloc.
6350
6351 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6352 (xnmalloc, xnrealloc, xpalloc): New functions.
6353
726e0ab1
PE
6354 * bidi.c (bidi_shelve_header_size): New constant.
6355 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6356 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6357
51f30bc5 6358 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6359 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6360 (overlay_strings):
6361 Don't update size of array until after memory allocation succeeds,
6362 because xmalloc/xrealloc may not return.
0065d054
PE
6363 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6364 now that we have proper integer overflow checking.
6365 (record_overlay_string, overlay_strings): Catch overflows when
6366 calculating size of overlay_str_buf.
726e0ab1 6367
0065d054
PE
6368 * callproc.c (Fcall_process): Check for size overflow when
6369 calculating size of args2.
6370 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6371 Normally we prefer signed values, but sticking with ptrdiff_t would
6372 require adding more-complicated checks.
726e0ab1
PE
6373
6374 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6375 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6376 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6377 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6378
6379 * character.c (Fstring): Check for size-calculation overflow.
6380
6381 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6382 unnecessary integer overflow. Check for size overflow.
6383 (encode_coding_object): Don't update size until xmalloc succeeds.
6384
6385 * composite.c (get_composition_id): Check for overflow in glyph
6386 length calculations.
6387
6388 Integer and memory overflow fixes for display code.
6389 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6390 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6391 (scrolling_window): Check for overflow in size calculations.
6392 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6393 Don't assume glyph table len fits in int.
6394 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6395 (row_table_size): Now ptrdiff_t, not int.
6396 (scrolling_window): Avoid overflow in size calculations.
6397 Don't update size until allocation succeeds.
6398 * fns.c (concat): Check for overflow in size calculations.
6399 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6400 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6401 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6402
6403 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6404 (get_doc_string): Check for size calculation overflow.
6405 Don't update size until allocation succeeds.
6406 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6407 EMACS_INT, where ptrdiff_t will do.
6408 (Fsubstitute_command_keys): Check for string overflow.
6409
6410 * editfns.c (set_time_zone_rule): Don't assume environment length
6411 fits in int.
6412 (message_length): Now ptrdiff_t, not int.
6413 (Fmessage_box): Don't update size until allocation succeeds.
6414 Don't assume message length fits in int.
6415 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6416
0065d054
PE
6417 * emacs.c (main): Do not reallocate argv, since there is a null at
6418 the end that can be overwritten, and this way there's no need to
6419 worry about size-calculation overflow.
6420 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6421
6422 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6423 alloc succeeds.
6424 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6425
6426 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6427 (x_set_scroll_bar_width, x_figure_window_size):
6428 Check for integer overflow.
6429 (x_set_alpha): Do not assume XINT fits in int.
6430
6431 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6432 This is for the members text_lines, text_cols, total_lines, total_cols,
6433 where the system imposes an 'int' limit.
6434
6435 * fringe.c (Fdefine_fringe_bitmap):
6436 Don't update size until alloc works.
6437
6438 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6439 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6440
6441 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6442 Check for size-calculation overflow.
6443 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6444 do, as we prefer signed integers.
6445 (id_to_widget.max_size, id_to_widget.used)
6446 (xg_store_widget_in_map, xg_remove_widget_from_map)
6447 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6448 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6449 Use and return ptrdiff_t, not int.
6450 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6451 * gtkutil.h: Change prototypes to match the above.
6452
6453 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6454 are duplicate now that they've been promoted to lisp.h.
6455 (x_allocate_bitmap_record, x_alloc_image_color)
6456 (make_image_cache, cache_image, xpm_load):
6457 Don't update size until alloc is done.
6458 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6459 (x_detect_edges):
3256efce 6460 Check for size calculation overflow.
726e0ab1
PE
6461 (ct_colors_allocated_max): New constant.
6462 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6463 overflow.
3256efce 6464
726e0ab1
PE
6465 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6466 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6467 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6468 Use ptrdiff_t, not int, to count maps.
6469 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6470 calculations. Don't update size until allocation succeeds.
6471 Redo calculations to avoid overflow.
726e0ab1
PE
6472 * keyboard.h: Change prototypes to match the above.
6473
6474 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6475 to count maps.
6476 (current_minor_maps): Check for size calculation overflow.
6477 * keymap.h: Change prototypes to match the above.
6478
6479 * lread.c (read1, init_obarray): Don't update size until alloc done.
6480
6481 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6482 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6483
726e0ab1
PE
6484 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6485 Now ptrdiff_t, not int.
6486 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6487 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6488
6489 * process.c (Fnetwork_interface_list): Check for overflow
6490 in size calculation.
6491
6492 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6493
6494 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6495 overflow. Don't bother calling xmalloc when xrealloc will do.
6496
6497 * search.c (Freplace_match): Check for size calculation overflow.
6498 (Fset_match_data): Don't assume list lengths fit in 'int'.
6499
6500 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6501 for command line length. Do not attempt to address one before the
6502 beginning of an array, as that's not portable.
6503
6504 * term.c (max_frame_lines): Remove; unused.
6505 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6506 not int.
6507 (encode_terminal_code, calculate_costs): Check for size
6508 calculation overflow.
6509 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6510 table lengths and related sizes. Don't update size until alloc
6511 done. Redo calculations to avoid overflow.
6512 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6513
6514 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6515 subtracting pointers.
6516 (gobble_line): Check for overflow more carefully. Don't update size
6517 until alloc done.
6518
6519 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6520 Don't update size until alloc done.
6521 Redo size calculations to avoid overflow.
6522 Check for size calculation overflow.
0065d054 6523 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6524
6525 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6526 Use ptrdiff_t, not int, for sizes.
6527 (store_mode_line_noprop_char): Don't update size until alloc done.
6528
0065d054
PE
6529 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6530 Use ptrdiff_t, not int, for sizes.
6531 (Finternal_make_lisp_face, cache_face):
6532 Check for size calculation overflow.
6533 (cache_face): Treat size calculation overflows as if they were
6534 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6535
6536 * xfns.c (x_encode_text, x_set_name_internal)
6537 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6538 sizes, since they can exceed INT_MAX in size. Check for size
6539 calculation overflow.
6540
0065d054
PE
6541 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6542 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6543 Don't update size until alloc done.
6544
0065d054 6545 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6546 as sprintf is limited to int lengths.
1d526e2f 6547
252c5ee1
PE
6548 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6549 (X_LONG_MIN): New macros.
864d7ce7
PE
6550 Use them to make the following changes clearer.
6551 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6552 This change doesn't affect the value now, but it may help remind
6553 future maintainers not to raise the value too much later.
6554 (SELECTION_QUANTUM): Remove, replacing with ...
6555 (selection_quantum): ... new function, which avoids overflow.
6556 All uses changed.
6557 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6558 assumption that selection length fits in 'int'.
6559 (x_reply_selection_request, x_handle_selection_request)
6560 (x_get_window_property, receive_incremental_selection)
6561 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6562 (lisp_data_to_selection_data, clean_local_selection_data):
6563 Use ptrdiff_t, not int, to record length of selection.
6564 (x_reply_selection_request, x_get_window_property)
6565 (receive_incremental_selection, x_property_data_to_lisp):
6566 Redo calculations to avoid overflow.
6567 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6568 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6569 something.
6570 (x_get_window_property, receive_incremental_selection)
6571 (lisp_data_to_selection_data, x_property_data_to_lisp):
6572 Check for size-calculation overflow.
6573 (x_get_window_property, receive_incremental_selection)
6574 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6575 Don't store size until memory allocation succeeds.
6576 (x_get_window_property): Plug memory leak on memory exhaustion.
6577 Don't double-block input; malloc is safe here. Don't assume 2**34
6578 - 4 fits in unsigned long. Add an xassert to check
6579 XGetWindowProperty overflow. Be more careful about overflow
6580 calculations, and distinguish size from memory overflow better.
6581 (receive_incremental_selection): When tracing, don't assume
6582 unsigned int is less than INT_MAX.
6583 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6584 harmful) conversions of unsigned short to int.
6585 (lisp_data_to_selection_data): Don't assume that integers
6586 in the range -65535 through -1 fit in an X unsigned short.
6587 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6588 result parameters unless successful. Rely on cons_to_unsigned
6589 to report problems with elements; the old code wasn't right anyway.
6590 (x_check_property_data): Check for int overflow; we cannot use
6591 a wider type due to X limits.
6592 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6593
726e0ab1 6594 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6595
0065d054
PE
6596 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6597 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6598 (x_color_cells): Don't store size until memory allocation succeeds.
6599 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6600 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6601 (x_term_init): Don't assume length fits in int (sprintf is limited
6602 to int size).
bc18e09d 6603
ebfa62c0
PE
6604 Use ptrdiff_t for composition IDs.
6605 * character.c (lisp_string_width):
6606 * composite.c (composition_table_size, n_compositions)
6607 (get_composition_id, composition_gstring_from_id):
6608 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6609 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6610 * window.c (Frecenter):
6611 Use ptrdiff_t, not int, for composition IDs.
6612 * composite.c (get_composition_id): Check for integer overflow.
6613 * composite.h: Adjust prototypes to match the above changes.
6614
d3411f89
PE
6615 Use ptrdiff_t for hash table indexes.
6616 * category.c (hash_get_category_set):
6617 * ccl.c (ccl_driver):
6618 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6619 * coding.c (coding_system_charset_list, detect_coding_system):
6620 * coding.h (struct coding_system.id):
6621 * composite.c (get_composition_id, gstring_lookup_cache):
6622 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6623 * image.c (xpm_get_color_table_h):
6624 * lisp.h (hash_lookup, hash_put):
6625 * minibuf.c (Ftest_completion):
6626 Use ptrdiff_t for hash table indexes, not int (which is too
6627 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6628 32-bit --with-wide-int hosts).
6629
e097a6fa
PE
6630 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6631 Add a FIXME comment about memory leaks.
6632 (syms_of_charset): Don't assume xmalloc returns.
6633
5637687f
PE
6634 Don't assume that stated character widths fit in int.
6635 * character.c (Fchar_width, c_string_width, lisp_string_width):
6636 * character.h (CHAR_WIDTH):
6637 * indent.c (MULTIBYTE_BYTES_WIDTH):
6638 Use sanitize_char_width to avoid undefined and/or bad behavior
6639 with outlandish widths.
a66cfb1c 6640 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6641 now that we have two such functions. All uses changed.
6642 (sanitize_char_width): New inline function.
6643
a2271ba2
PE
6644 Don't assume that tab-width fits in int.
6645 * character.h (sanitize_width): New inline function.
6646 (SANE_TAB_WIDTH): New macro.
6647 (ASCII_CHAR_WIDTH): Use it.
6648 * indent.c (sane_tab_width): Remove. All uses replaced by
6649 SANE_TAB_WIDTH (current_buffer).
6650 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6651
18c52557
PE
6652 * fileio.c: Integer overflow issues with file modes.
6653 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6654
caeeedc1
PE
6655 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6656 Remove unreachable code.
6657 (read_hex, load_charset_map_from_file): Check for integer overflow.
6658
6df6ae42 6659 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6660 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6661 (x_send_scroll_bar_event): Likewise. Check that the size does not
6662 exceed limits imposed by XClientMessageEvent, as well as the usual
6663 ptrdiff_t and size_t limits.
6664
b13995db
PE
6665 * keyboard.c: Overflow, signedness and related fixes.
6666 (make_lispy_movement): Use same integer type in forward decl
6667 that is used in the definition.
6668 (read_key_sequence, keyremap_step):
6669 Change bufsize argument back to int, undoing my 2011-03-30 change.
6670 We prefer signed types, and int is wide enough here.
6671 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6672 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6673 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6674 length, not size_t. Use ptrdiff_t for index, not int.
6675 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6676 possibility of integer overflow.
6677
13464394
PE
6678 Overflow, signedness and related fixes for images.
6679
6680 * dispextern.h (struct it.stack[0].u.image.image_id)
6681 (struct_it.image_id, struct image.id, struct image_cache.size)
6682 (struct image_cache.used, struct image_cache.ref_count):
6683 * gtkutil.c (update_frame_tool_bar):
6684 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6685 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6686 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6687 * nsmenu.m (update_frame_tool_bar):
6688 * xdisp.c (calc_pixel_width_or_height):
6689 * xfns.c (image_cache_refcount):
6690 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6691 on typical 64-bit hosts.
6692
6693 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6694 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6695 Omit unnecessary casts to int.
6696 (parse_image_spec): Check that integers fall into 'int' range
6697 when the callers expect that.
6698 (image_ascent): Redo ascent calculation to avoid int overflow.
6699 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6700 (lookup_image): Remove unnecessary tests.
6701 (xbm_image_p): Locals are now of int, not EMACS_INT,
6702 since parse_image_check makes sure they fit into int.
6703 (png_load, gif_load, svg_load_image):
6704 Prefer int to unsigned where either will do.
6705 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6706 old tiff_error_handler and tiff_warning_handler.
6707 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6708 stack buffer overflows. It uses only the features of vsnprintf
6709 that are common to both POSIX and native Microsoft.
6710 (tiff_error_handler, tiff_warning_handler): Use it.
6711 (tiff_load, gif_load, imagemagick_load_image):
6712 Don't assume :index value fits in 'int'.
6713 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6714 (imagemagick_load_image): Check that crop parameters fit into
6715 the integer types that MagickCropImage accepts. Don't assume
6716 Vimagemagick_render_type has a nonnegative value. Don't assume
6717 size_t fits in 'long'.
6718 (gs_load): Use printmax_t to print the widest integers possible.
6719 Check for integer overflow when computing image height and width.
6720
c11821d4
EZ
67212011-08-26 Eli Zaretskii <eliz@gnu.org>
6722
6723 * xdisp.c (redisplay_window): Don't force window start if point
6724 will be invisible in the resulting window. (Bug#9324)
6725
0c95fcf7
EZ
67262011-08-25 Eli Zaretskii <eliz@gnu.org>
6727
6728 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6729 the display spec is of the form `(space ...)'.
6730 (handle_display_spec): Return the value returned by
6731 handle_single_display_spec, not just 1 or zero.
6732 (handle_single_display_spec): If the display spec is of the form
6733 `(space ...)', and specifies display in the text area, return 2
6734 rather than 1.
fee65a97 6735 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6736 accurately, and prefer exact match for point under bidi.
6737 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6738
6739 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6740 into disp_prop; all users changed.
6741
6742 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6743 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6744 for the text covered by the display property.
6745
e4ed06f1
CY
67462011-08-25 Chong Yidong <cyd@stupidchicken.com>
6747
6748 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6749 Change return value to nil.
6750 (Frecord_buffer): Delete unused function.
6751
f67cdd7f
EZ
67522011-08-24 Eli Zaretskii <eliz@gnu.org>
6753
5980d4c6
EZ
6754 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6755 buffers, return left-to-right.
8610fe8b
EZ
6756 (set_cursor_from_row): Consider candidate row a win if its glyph
6757 represents a newline and point is on that newline. Fixes cursor
6758 positioning on the newline at EOL of R2L text within L2R
6759 paragraph, and vice versa.
6760 (try_cursor_movement): Check continued rows, in addition to
6761 continuation rows. Fixes unwarranted scroll when point enters a
6762 continued line of R2L text within an L2R paragraph, or vice versa.
6763 (cursor_row_p): Consider the case of point being equal to
6764 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6765 from the end of a short line to the beginning of a continued line
6766 of R2L text within L2R paragraph.
6767 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6768 composed characters.
5980d4c6 6769
f67cdd7f
EZ
6770 * bidi.c (bidi_check_type): Use xassert.
6771 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6772 members.
6773
bca633fb
EZ
67742011-08-23 Eli Zaretskii <eliz@gnu.org>
6775
6776 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6777 a character.
6778
4a5885a7
CY
67792011-08-23 Chong Yidong <cyd@stupidchicken.com>
6780
6781 * nsfont.m (ns_otf_to_script): Fix typo.
6782
0902a04e
KH
67832011-08-22 Kenichi Handa <handa@m17n.org>
6784
6785 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6786 extra slot even if the purpose is char-code-property-table.
6787
1a2e6670
EZ
67882011-08-23 Eli Zaretskii <eliz@gnu.org>
6789
8ddde651
EZ
6790 * xdisp.c (redisplay_window): When computing centering_position,
6791 account for the height of the header line. (Bug#8874)
6792
425cc014
EZ
6793 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6794 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6795 candidate is selected by the mouse, and that candidate has a
6796 composed character under the mouse.
6797
1a2e6670
EZ
6798 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6799 coordinates reported by pos-visible-in-window-p for a composed
6800 character in column zero.
6801
8b76d6f8
SM
68022011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6803
6804 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6805
dac347dd
EZ
68062011-08-22 Eli Zaretskii <eliz@gnu.org>
6807
6808 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6809 consider it a hit if to_charpos is anywhere in the range of the
6810 composed buffer positions.
6811
e013fb34
CY
68122011-08-22 Chong Yidong <cyd@stupidchicken.com>
6813
6814 * image.c (gif_load): Don't assume that each subimage has the same
6815 dimensions as the base image. Handle disposal method that is
6816 "undefined" by the gif spec (Bug#9335).
6817
bd1ba3e8
CY
68182011-08-20 Chong Yidong <cyd@stupidchicken.com>
6819
6820 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6821 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6822
54a1215b
EZ
68232011-08-19 Eli Zaretskii <eliz@gnu.org>
6824
823564e5
EZ
6825 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6826 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6827 from an Org mode buffer to a Speedbar frame.
6828
54a1215b
EZ
6829 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6830 a composition, take its buffer position from IT->cmp_it.charpos.
6831 Fixes cursor positioning at the beginning of a line that begins
6832 with a composed character.
6833
9778ebcc
EZ
68342011-08-18 Eli Zaretskii <eliz@gnu.org>
6835
0be6ee06
EZ
6836 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6837 character bidirectional type, use STRONG_L instead. Fixes crashes
6838 in a buffer produced by `describe-categories'.
6839
9778ebcc
EZ
6840 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6841 members before the level stack, so they would be saved and
6842 restored when copying iterator state. Fixes incorrect reordering
6843 around TABs covered by display properties.
6844
156bffbe
AS
68452011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6846
6b02f655 6847 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6848
72ad093b
CY
68492011-08-17 Chong Yidong <cyd@stupidchicken.com>
6850
6851 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6852 (internal_condition_case_2, internal_condition_case_n):
6853 Remove unnecessary aborts (Bug#9081).
72ad093b 6854
35774242
EZ
68552011-08-17 Eli Zaretskii <eliz@gnu.org>
6856
6857 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6858 has no `load' handler, try opening the file locally. (Bug#9311)
6859
db76dd85
KB
68602011-08-16 Ken Brown <kbrown@cornell.edu>
6861
6862 * gmalloc.c: Expand comment.
6863
b215eee5
EZ
68642011-08-16 Eli Zaretskii <eliz@gnu.org>
6865
6866 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6867 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6868
a4579d33
KB
68692011-08-16 Ken Brown <kbrown@cornell.edu>
6870
6871 Fix memory allocation problems in Cygwin build (Bug#9273).
6872
6873 * unexcw.c ( __malloc_initialized): Declare external variable.
6874 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6875
8b76d6f8
SM
6876 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6877 New variables.
a4579d33
KB
6878 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6879 dumped emacs.
6880 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6881 in the static heap.
6882 [CYGWIN] (special_realloc): New function.
6883 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6884 requests to realloc storage in the static heap.
6885
3ebec551
PE
68862011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6887
6888 * bidi.c (bidi_initialize): Remove unused local.
6889
9fd8be00
EZ
68902011-08-15 Eli Zaretskii <eliz@gnu.org>
6891
6b02f655
SM
6892 * bidimirror.h:
6893 * biditype.h: Remove file.
6894 * makefile.w32-in ($(BLD)/bidi.$(O)):
6895 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6896
6897 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6898
6899 * chartab.c: Improve commentary for the uniprop_table API.
6900
32413314
EZ
6901 * bidi.c (bidi_paragraph_init): Support zero value of
6902 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6903 (bidi_initialize): Use uniprop_table instead of including
6904 biditype.h and bidimirror.h.
32413314 6905
9fd8be00
EZ
6906 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6907 coordinates of the iterator when restoring from ppos_it.
6908 (Bug#9296)
6909
5cf2b69b
KH
69102011-08-14 Kenichi Handa <handa@m17n.org>
6911
6912 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6913 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6914
daf17d00
EZ
69152011-08-14 Eli Zaretskii <eliz@gnu.org>
6916
6917 * xdisp.c (move_it_in_display_line_to): Don't invoke
6918 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6919 ppos_it. Fixes vertical cursor motion when line beginning is
6920 covered by an image. (Bug#9296)
6921
08e3161a
JD
69222011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6923
6924 * nsterm.h (ns_run_ascript): Declare.
6925 (NSAPP_DATA2_RUNASSCRIPT): Define.
6926
6927 * nsfns.m (as_script, as_result, as_status): New static variables.
6928 (ns_run_ascript): New function.
5e617bc2 6929 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6930 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6931 the event loop. Get status from as_status (Bug#7276).
6932
6933 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6934 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6935 the event loop (Bug#7276).
6936
a3720aa2
AS
69372011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6938
6939 * gnutls.c (QCgnutls_bootprop_priority)
6940 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6941 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6942 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6943 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6944 (QCgnutls_bootprop_verify_hostname_error)
6945 (QCgnutls_bootprop_callbacks_verify): Rename from
6946 Qgnutls_bootprop_..., all uses changed.
6947
6948 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6949 uses changed.
6950
0a0d27fb
PE
69512011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6952
19d5c50c
PE
6953 * xfaces.c (Qframe_set_background_mode): Now static.
6954 * dispextern.h (Qframe_set_background_mode): Remove decl.
6955
0a0d27fb
PE
6956 * process.c (Fnetwork_interface_info): Declare local only if needed.
6957
377538cb
JD
69582011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6959
6960 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6961 (Fnetwork_interface_list): Allocate in increments of bytes instead
6962 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6963 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6964 sockaddr.
6965 (struct ifflag_def): notrailers is smart on OSX.
6966 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6967 Get hardware address with getifaddrs if available.
6968
08fff70c
EZ
69692011-08-12 Eli Zaretskii <eliz@gnu.org>
6970
6971 * xdisp.c (iterate_out_of_display_property): xassert that
6972 IT->position is set to within IT->object's boundaries. Break from
6973 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6974 when IT->position is set up wrongly due to some bug.
6975 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6976 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6977 entry. Force push_it to save on the stack the current
6978 buffer/string position, to be restored by pop_it. Fix flags in
6979 the iterator structure wrt the object coming from a display
6980 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6981 properties. (Bug#9284)
6982
7be1c708 69832011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6984
7be1c708
CY
6985 * fontset.c (fontset_get_font_group): Add proper type checks.
6986 (Bug#9172)
aac0c6e3 6987
7be1c708 69882011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6989
7be1c708
CY
6990 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6991 and LC_VERSION_MIN_MACOSX.
6992 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6993 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6994
97bb72a6
EZ
69952011-08-08 Eli Zaretskii <eliz@gnu.org>
6996
6997 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6998 no-display-properties-and-no-overlays under bidi display.
6999 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7000 properties and overlays.
97bb72a6 7001
d5617611
CY
70022011-08-08 Chong Yidong <cyd@stupidchicken.com>
7003
37e11a63
CY
7004 * editfns.c (Fset_time_zone_rule): Document relationship with the
7005 setenv function.
7006
d5617611
CY
7007 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7008 the font entity extracted from the cache (Bug#8109).
7009
58872834
CY
70102011-08-07 Chong Yidong <cyd@stupidchicken.com>
7011
7012 * composite.c (autocmp_chars): Don't reset point. That is done by
7013 restore_point_unwind (Bug#5984).
7014
75bfc667
JL
70152011-08-07 Juri Linkov <juri@jurta.org>
7016
7017 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7018 to show the arg `TIME' instead of `TIMEVAL'.
7019
d1410150
EZ
70202011-08-06 Eli Zaretskii <eliz@gnu.org>
7021
7022 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7023 display property strides EOL and includes a newline, as in
7024 longlines-mode. (Bug#9254)
75b771e4
EZ
7025 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7026 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7027
7028 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7029 is non-zero, even if the data buffer is NULL. Fixes a crash in
7030 vertical-motion with longlines-mode. (Bug#9254)
7031
35928349
EZ
70322011-08-05 Eli Zaretskii <eliz@gnu.org>
7033
ec7cc85b
EZ
7034 * bidi.c <bidi_cache_total_alloc>: Now static.
7035 (bidi_initialize): Initialize bidi_cache_total_alloc.
7036
8b76d6f8 7037 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7038 cache. (Bug#9221)
7039
7040 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7041 amount allocated this far in `bidi_cache_total_alloc'.
7042 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7043 non-zero, only free the data buffer without restoring the cache
7044 contents. All callers changed.
7045
7046 * dispextern.h (bidi_unshelve_cache): Update prototype.
7047
7048 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7049 (move_it_in_display_line, move_it_to)
7050 (move_it_vertically_backward, move_it_by_lines): Replace the call
7051 to xfree to an equivalent call to bidi_unshelve_cache.
7052 (move_it_in_display_line_to): Fix logic of returning
412b6358 7053 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7054
e2e2423b
EZ
70552011-08-05 Eli Zaretskii <eliz@gnu.org>
7056
7057 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7058 came from a string character with a `cursor' property. (Bug#9229)
7059
ae9e757a
JD
70602011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7061
7062 * Makefile.in (LIB_PTHREAD): New variable.
7063 (LIBES): Add LIB_PTHREAD (Bug#9216).
7064
7065 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7066 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7067
213bd7f2
AS
70682011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7069
6b02f655 7070 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7071
99aaf75f
JD
70722011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7073
7074 * xterm.c (x_find_topmost_parent): New function.
7075 (x_set_frame_alpha): Find topmost parent window with
7076 x_find_topmost_parent and set the property there also (bug#9181).
7077 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7078
c74e9d86
PE
70792011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7080
7081 * callproc.c (Fcall_process): Avoid vfork clobbering
7082 the local vars buffer, coding_systems, current_dir.
7083
640c8776
SM
70842011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7085
7086 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7087
f26d0e4c
PE
70882011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7089
8a10d76c
PE
7090 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7091 so that it is not optimized away.
7092
f26d0e4c
PE
7093 * xdisp.c (compute_display_string_pos): Remove unused local.
7094
55439c61
EZ
70952011-08-02 Eli Zaretskii <eliz@gnu.org>
7096
7097 Fix slow cursor motion and scrolling in large buffers with
7098 selective display, like Org Mode buffers. (Bug#9218)
7099
7100 * dispextern.h (struct bidi_it): New member disp_prop_p.
7101
7102 * xdisp.c: Remove one-slot cache of display string positions.
7103 (compute_display_string_pos): Accept an additional argument
5e617bc2 7104 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7105 for a display string or property. If found, set DISP_PROP_P
7106 non-zero.
7107
7108 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7109 DISP_PROP_P, and pass it to compute_display_string_pos.
7110 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7111 non-zero. All callers of bidi_fetch_char changed.
7112
fb33fa43
SM
71132011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7114
7115 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7116
b099e063
DM
71172010-12-03 Don March <don@ohspite.net>
7118
7119 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7120 last character M-[char] is translated to ESC [char] (bug#7541).
7121
5cc7f7af
KH
71222011-08-02 Kenichi Handa <handa@m17n.org>
7123
d0fffa3f 7124 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7125
7126 * chartab.c (uniprop_table): Make it non-static.
7127
525d5e6e
EZ
71282011-08-01 Eli Zaretskii <eliz@gnu.org>
7129
7130 * xdisp.c (forward_to_next_line_start): Accept additional argument
7131 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7132 on the newline.
7133 (reseat_at_next_visible_line_start): Use the bidi iterator state
7134 returned by forward_to_next_line_start to restore the state of
7135 it->bidi_it after backing up to previous newline. (Bug#9212)
7136
31011111
AS
71372011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7138
7139 * regex.c (re_comp): Protoize.
7140 (re_exec): Fix return type.
7141 (regexec): Fix type of `ret'. (Bug#9203)
7142
476371c4
PE
71432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7144
e5d76069
PE
7145 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7146 This is needed if max-image-size is a floating-point number.
7147
9a79b20c
AS
71482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7149
7150 * print.c (print_object): Print empty symbol as ##.
7151
7152 * lread.c (read1): Read ## as empty symbol.
7153
d8c2fa78
AA
71542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7155
7156 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7157 setting frame foreground color (Bug#9175).
7158 (x_set_background_color): Likewise.
7159
ffe57a7a
AA
7160 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7161 contents (Bug#9176).
7162 (EmacsTooltip -init): Remove bezels and add shadows to
7163 tooltip windows.
7164
bf3492a5
AA
7165 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7166 or scroll bar (Bug#8470).
7167
d55e9c53
AA
7168 * nsfont.m (nsfont_open): Remove assignment to voffset and
7169 unnecessary vars hshink, expand, hd, full_height, min_height.
7170 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7171
7172 * nsterm.h (nsfont_info): Remove voffset field.
7173
d8c2fa78 71742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7175
7176 Implement strike-through and overline on NextStep (Bug#8863).
7177
7178 * nsfont.m (nsfont_open): Use underline position provided by font,
7179 instead of hard-coded value of 2.
7180 (nsfont_draw): Call ns_draw_text_decoration instead.
7181
7182 * nsterm.h: Add declaration for ns_draw_text_decoration.
7183
7184 * nsterm.m (ns_draw_text_decoration): New function for drawing
7185 underline, overline, and strike-through.
7186 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7187 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7188 accommodate underlining, etc.
4843aac3 7189
4cc60b9b
EZ
71902011-07-28 Eli Zaretskii <eliz@gnu.org>
7191
bc7ece87
EZ
7192 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7193 default.
4cc60b9b 7194
476371c4
PE
71952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7196
66606eea
PE
7197 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7198 Without this fix, if a signal arrives just after memory fills up,
7199 'malloc' might be invoked reentrantly.
7200
476371c4
PE
7201 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7202 In other words, assume that every image size is allowed, on non-X
7203 hosts. This assumption is probably wrong, but it lets Emacs compile.
7204
f3fcc40d
AS
72052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7206
7207 * regex.c (re_iswctype): Convert return values to boolean.
7208
350c992f
EZ
72092011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7210
7211 * xdisp.c (compute_display_string_pos): Don't use cached display
7212 string position if the buffer had its restriction changed.
7213 (Bug#9184)
7214
5266b4bb
PE
72152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7216
7217 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7218
2573a837 72192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7220
41f55ccd 7221 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7222
39e378da
PE
7223 * bidi.c: Integer size and overflow fixes.
7224 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7225 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7226 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7227 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7228 (bidi_find_other_level_edge):
7229 Use ptrdiff_t instead of EMACS_INT where either will do.
7230 This works better on 32-bit hosts configured --with-wide-int.
7231 (bidi_cache_ensure_space): Check for size-calculation overflow.
7232 Use % rather than repeated addition, for better worst-case speed.
7233 Don't set bidi_cache_size until after xrealloc returns, because it
7234 might not return.
7235 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7236 (bidi_cache_ensure_space): Also check that the bidi cache size
7237 does not exceed that of the largest Lisp string or buffer. See Eli
7238 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7239
5e927815
PE
7240 * alloc.c (__malloc_size_t): Remove.
7241 All uses replaced by size_t. See Andreas Schwab's note
7242 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7243
ca4aa935
PE
7244 * image.c: Improve checking for integer overflow.
7245 (check_image_size): Assume that f is nonnull, since
7246 it is always nonnull in practice. This is one less thing to
7247 worry about when checking for integer overflow later.
7248 (x_check_image_size): New function, which checks for integer
7249 overflow issues inside X.
7250 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7251 This removes the need for a memory_full check.
7252 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7253 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7254 (xbm_read_bitmap_data): Change locals back to 'int', since
7255 their values must fit in 'int'.
7256 (xpm_load_image, png_load, tiff_load):
7257 Invoke x_create_x_image_and_pixmap earlier,
7258 to avoid much needless work if the image is too large.
7259 (tiff_load): Treat overly large images as if
7260 x_create_x_image_and_pixmap failed, not as malloc failures.
7261 (gs_load): Use x_check_image_size.
7262
5f8f9cc2
PE
7263 * gtkutil.c: Omit integer casts.
7264 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7265 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7266
5adf60bc
PE
7267 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7268
c8907a93
PE
7269 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7270 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7271 would wrongly return t on a 64-bit host.
7272
e3c25c68
PE
7273 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7274 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7275 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7276 and therefore cause GCC to emit a bogus diagnostic in some cases.
7277
3f791afe
PE
7278 * image.c: Integer signedness and overflow and related fixes.
7279 This is not an exhaustive set of fixes, but it's time to
7280 record what I've got.
7281 (lookup_pixel_color, check_image_size): Remove redundant decls.
7282 (check_image_size): Don't assume that arbitrary EMACS_INT values
7283 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7284 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7285 (tiff_load, imagemagick_load_image):
7286 Check for overflow in size calculations.
7287 (x_create_x_image_and_pixmap): Remove unnecessary test for
7288 xmalloc returning NULL; that can't happen.
7289 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7290 (xpm_color_bucket): Use better integer hashing function.
7291 (xpm_cache_color): Don't possibly over-allocate memory.
7292 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7293 (gif_memory_source):
7294 Use ptrdiff_t, not int or size_t, to record sizes.
7295 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7296 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7297 either works, as we prefer signed integers.
7298 (tiff_read_from_memory, tiff_write_from_memory):
7299 Return tsize_t, not size_t, since that's what the TIFF API wants.
7300 (tiff_read_from_memory): Don't fail simply because the read would
7301 go past EOF; instead, return a short read.
7302 (tiff_load): Omit no-longer-needed casts.
7303 (Fimagemagick_types): Don't assume size fits into 'int'.
7304
3cc5a532
PE
7305 Improve hashing quality when configured --with-wide-int.
7306 * fns.c (hash_string): New function, taken from sxhash_string.
7307 Do not discard information about ASCII character case; this
7308 discarding is no longer needed.
7309 (sxhash-string): Use it. Change sig to match it. Caller changed.
7310 * lisp.h: Declare it.
7311 * lread.c (hash_string): Remove, since we now use fns.c's version.
7312 The fns.c version returns a wider integer if --with-wide-int is
7313 specified, so this should help the quality of the hashing a bit.
7314
b312a492
PE
7315 * emacs.c: Integer overflow minor fix.
7316 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7317 Define only if GNU_LINUX.
7318 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7319
dfd153ae
PE
7320 * dispnew.c: Integer signedness and overflow fixes.
7321 Remove unnecessary forward decls, that were a maintenance hassle.
7322 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7323 All uses changed.
7324 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7325 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7326 (prepare_desired_row, line_draw_cost):
7327 Use int, not unsigned, where either works.
7328 (save_current_matrix, restore_current_matrix):
7329 Use ptrdiff_t, not size_t, where either works.
7330 (init_display): Check for overflow more accurately, and without
7331 relying on undefined behavior.
7332
a81d11a3
PE
7333 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7334 Remove, replacing with the new symbols in lisp.h. All uses changed.
7335 * fileio.c (make_temp_name):
7336 * filelock.c (lock_file_1, lock_file):
7337 * xdisp.c (message_dolog):
7338 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7339 Use pMd etc. instead.
7340 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7341 replacing the pWIDE etc. symbols removed from editfns.c.
7342
3300e6fd
PE
7343 * keyboard.h (num_input_events): Now uintmax_t.
7344 This is (very slightly) less likely to mess up due to wraparound.
7345 All uses changed.
7346
fd05c7e9
PE
7347 * buffer.c: Integer signedness fixes.
7348 (alloc_buffer_text, enlarge_buffer_text):
7349 Use ptrdiff_t rather than size_t when either will do, as we prefer
7350 signed integers.
7351
903fe15d
PE
7352 * alloc.c: Integer signedness and overflow fixes.
7353 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7354 (__malloc_size_t): Default to size_t, not to int.
7355 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7356 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7357 Prefer ptrdiff_t to size_t when either would do, as we prefer
7358 signed integers.
7359 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7360 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7361 Now const. Initialize with values that are in range even if char
7362 is signed.
7363 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7364 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7365 These functions do the right thing with sizes > 2**32.
7366 (check_depth): Now ptrdiff_t, not int.
7367 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7368 Adjust to new way of storing sizes. Check for size overflow bugs
7369 in rest of code.
7370 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7371 slightly wrong anyway, as it missed one instance of
7372 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7373 (refill_memory_reserve): Omit needless cast to size_t.
7374 (mark_object_loop_halt): Mark as externally visible.
7375
ac82cc6a
PE
7376 * xselect.c: Integer signedness and overflow fixes.
7377 (Fx_register_dnd_atom, x_handle_dnd_message):
7378 Use ptrdiff_t, not size_t, since we prefer signed.
7379 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7380 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7381 x_dnd_atoms_size and x_dnd_atoms_length.
7382
c2d1e36d
PE
7383 * doprnt.c: Prefer signed to unsigned when either works.
7384 * eval.c (verror):
7385 * doprnt.c (doprnt):
7386 * lisp.h (doprnt):
7387 * xdisp.c (vmessage):
7388 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7389 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7390 prefer signed arithmetic to avoid comparison confusion.
7391 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7392 but is a bit tricky.
7393
0e926e56
PE
7394 Assume freestanding C89 headers, string.h, stdlib.h.
7395 * data.c, doprnt.c, floatfns.c, print.c:
7396 Include float.h unconditionally.
7397 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7398 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7399 * regex.c: Likewise for stddef.h, string.h.
7400 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7401 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7402 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7403 (STDC_HEADERS): Remove obsolete defines.
7404 * sysdep.c: Include limits.h unconditionally.
7405
9cfdb3ec
PE
7406 Assume support for memcmp, memcpy, memmove, memset.
7407 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7408 * regex.c (memcmp, memcpy):
7409 Remove; we assume C89 now.
7410
7411 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7412 (__malloc_safe_bcopy): Remove; no longer needed.
7413
cf950e6b 7414 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7415 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7416 well either way, and we prefer signed to unsigned.
7417
dbf38e02
LMI
74182011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7419
7420 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7421 closes the connection while we're reading (bug#9182).
7422
d6f0886c 74232011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7424
d6f0886c
JD
7425 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7426 are specified (Bug#9168).
24e0f6b1 7427
2eb1f9e6
PE
74282011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7429
7430 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7431 Found by GCC static checking and --with-wide-int on a 32-bit host.
7432
22381272 74332011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7434
7435 * xdisp.c (compute_display_string_pos): Fix logic of caching
7436 previous display string position. Initialize cached_prev_pos to
7437 -1. Fixes slow-down at the beginning of a buffer.
7438
f25e39b4
EZ
74392011-07-24 Eli Zaretskii <eliz@gnu.org>
7440
7441 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7442 for attrs[LFACE_FONTSET_INDEX].
7443
04c4b52e
PE
74442011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7445
7446 * xml.c (parse_region): Remove unused local
7447 that was recently introduced.
7448
c1734fbd
EZ
74492011-07-23 Eli Zaretskii <eliz@gnu.org>
7450
be18c5a5
EZ
7451 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7452 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7453
c1734fbd
EZ
7454 * xdisp.c (move_it_in_display_line_to): Record the best matching
7455 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7456 exit if none of the characters scanned was an exact match.
7457 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7458 when exact match is impossible due to invisible text, and the
7459 lines are truncated.
7460
a258d627
JD
74612011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7462
7463 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7464 for OSX >= 10.7.
7465
b6d5a689
EZ
74662011-07-22 Eli Zaretskii <eliz@gnu.org>
7467
0f74f785
EZ
7468 Fix a significant slow-down of cursor motion with C-n, C-p,
7469 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7470 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7471 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7472 (next_element_from_buffer): Call compute_stop_pos_backwards to
7473 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7474 base_level_stop.
7475 (reseat): Don't look for prev_stop, as that could mean a very long
7476 run.
7477 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7478 <cached_disp_overlay_modiff>: Cache for last found display string
7479 position.
551918c1 7480 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7481 about the same buffer in the same area of character positions, and
7482 the buffer wasn't changed since the time the display string
7483 position was cached.
551918c1 7484
b2d0c91a
EZ
74852011-07-22 Eli Zaretskii <eliz@gnu.org>
7486
7487 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7488 is an integer, which is important for empty lines. (Bug#9149)
7489
043604ee
CY
74902011-07-22 Chong Yidong <cyd@stupidchicken.com>
7491
7492 * frame.c (Fmodify_frame_parameters): In tty case, update the
7493 default face if necessary (Bug#4238).
7494
da4adb04
CY
74952011-07-21 Chong Yidong <cyd@stupidchicken.com>
7496
7497 * editfns.c (Fstring_to_char): No need to explain what a character
7498 is in the docstring (Bug#6576).
7499
9abd0532
LMI
75002011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7501
7502 * xml.c (parse_region): Make sure we always return a tree.
7503
36881d16
HK
75042011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7505
7506 * xml.c (parse_region): If a document contains only comments,
7507 return that, too.
7508
1e98674d
LMI
75092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7510
7511 * xml.c (make_dom): Return comments, too.
7512
590bd467
PE
75132011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7514
7515 Port to OpenBSD.
7516 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7517 and the surrounding thread.
7518 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7519 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7520 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7521 timer goes off.
7522 * s/openbsd.h (BROKEN_SIGIO): Define.
7523 * unexelf.c (unexec) [__OpenBSD__]:
7524 Don't update the .mdebug section of the Alpha COFF symbol table.
7525
f41628b2
LMI
75262011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7527
7528 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7529 (bug#8460).
7530
b59b67c5
PE
75312011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7532
15e3a074
PE
7533 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7534 This fixes some race conditions on the permissions of any newly
7535 created file.
7536
41bed37d
PE
7537 * alloc.c (valid_pointer_p): Use pipe, not open.
7538 This fixes some permissions issues when debugging.
7539
b59b67c5
PE
7540 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7541 If fchown fails to set both uid and gid, try to set just gid,
7542 as that is sometimes allowed. Adjust the file's mode to eliminate
7543 setuid or setgid bits that are inappropriate if fchown fails.
7544
925a6be7
SM
75452011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7546
7547 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7548 to compare Lisp_Objects.
7549 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7550 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7551 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7552
52968808
AS
75532011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7554
0a6a104b
AS
7555 * lread.c (read_integer): Unread even EOF character.
7556 (read1): Likewise. Properly record start position of symbol.
7557
52968808
AS
7558 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7559 symbol character follows.
7560
9e381cdd
PE
75612011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7562
7563 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7564 This works around a problem with the previous change to Fcopy_file.
7565 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7566 and without this change, GCC might complain about discarding
7567 fchown's return value.
7568
b5641435
JB
75692011-07-16 Juanma Barranquero <lekktu@gmail.com>
7570
7571 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7572
a8031457
PE
75732011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7574
7575 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7576
dd889327
LMI
75772011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7578
750c33f7
LMI
7579 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7580 it's used from the C level.
7581
dd889327
LMI
7582 * process.c: Use the same condition for POLL_FOR_INPUT in both
7583 keyboard.c and process.c (bug#1858).
7584
87e86684
LM
75852011-07-09 Lawrence Mitchell <wence@gmx.li>
7586
7587 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7588 (Fgnutls_boot): Use it.
7589
64348f40
AS
75902011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7591
7592 * doc.c (Fsubstitute_command_keys): Revert last change.
7593
1d698799
LMI
75942011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7595
f863868c
LMI
7596 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7597 quotes the next character, and doesn't affect other longer
7598 sequences (bug#8935).
7599
1d698799
LMI
7600 * lread.c (syms_of_lread): Clarify that is isn't only
7601 `eval-buffer' and `eval-defun' that's affected by
7602 `lexical-binding' (bug#8460).
7603
aa4b6df6
EZ
76042011-07-15 Eli Zaretskii <eliz@gnu.org>
7605
7606 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7607 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7608
5d856da6
PE
76092011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7610
ad6042bb
PE
7611 Fix minor problems found by static checking.
7612 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7613 (elsz): Now a signed constant, not a size_t var. We prefer signed
7614 types to unsigned, to avoid integer comparison confusion. Without
7615 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7616 "cannot optimize loop, the loop counter may overflow", a symptom
7617 of the confusion.
f00bbb22 7618 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7619 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7620
6468f31c
LMI
76212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7622
49080b10
LMI
7623 * search.c (Fre_search_backward): Mention `case-fold-search' in
7624 all the re_search_* functions (bug#8138).
7625
6468f31c
LMI
7626 * keyboard.c (Fopen_dribble_file): Document when the file is
7627 closed (bug#8056).
7628
c965adc5
EZ
76292011-07-14 Eli Zaretskii <eliz@gnu.org>
7630
df9733bf
EZ
7631 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7632 bidi_cache_idx.
7633
0bb23927
EZ
7634 Support bidi reordering of display and overlay strings.
7635 * xdisp.c (compute_display_string_pos)
7636 (compute_display_string_end): Accept additional argument STRING.
7637 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7638 (reseat_to_string): Initialize bidi_it->string.s and
7639 bidi_it->string.schars.
7640 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7641 NULL (avoids a crash in bidi_paragraph_init).
7642 Initialize itb.string.lstring.
0bb23927
EZ
7643 (init_iterator): Call bidi_init_it only of a valid
7644 buffer position was specified. Initialize paragraph_embedding to
7645 L2R.
7646 (reseat_to_string): Initialize the bidi iterator.
7647 (display_string): If we need to ignore text properties of
7648 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7649 original value of -1 will not work with bidi.)
7650 (compute_display_string_pos): First arg is now struct
7651 `text_pos *'; all callers changed. Support display properties on
7652 Lisp strings.
7653 (compute_display_string_end): Support display properties on Lisp
7654 strings.
7655 (init_iterator, reseat_1, reseat_to_string): Initialize the
7656 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7657 when iterating on a string not from display properties).
640c8776
SM
7658 (compute_display_string_pos, compute_display_string_end):
7659 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7660 arrow keys.
7661 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7662 base_level_stop; instead, set base_level_stop to BEGV.
7663 Fixes crashes in vertical-motion.
0bb23927
EZ
7664 (next_element_from_buffer): Improve commentary for when
7665 the iterator is before prev_stop.
7666 (init_iterator): Initialize bidi_p from the default value of
7667 bidi-display-reordering, not from buffer-local value. Use the
7668 buffer-local value only if initializing for buffer iteration.
7669 (handle_invisible_prop): Support invisible properties on strings
7670 that are being bidi-reordered.
7671 (set_iterator_to_next): Support bidi reordering of C strings and
7672 Lisp strings.
7673 (next_element_from_string): Support bidi reordering of Lisp
7674 strings.
7675 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7676 (display_string): Support display of R2L glyph rows.
7677 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7678 (init_iterator): Don't initialize it->bidi_p for strings
7679 here.
7680 (reseat_to_string): Initialize it->bidi_p for strings here.
7681 (next_element_from_string, next_element_from_c_string)
7682 (next_element_from_buffer): Add xassert's for correspondence
7683 between IT's object being iterated and it->bidi_it.string
7684 structure.
7685 (face_before_or_after_it_pos): Support bidi iteration.
7686 (next_element_from_c_string): Handle the case of the first string
7687 character that is not the first one in the visual order.
7688 (get_visually_first_element): New function, refactored from common
7689 parts of next_element_from_buffer, next_element_from_string, and
7690 next_element_from_c_string.
7691 (tool_bar_lines_needed, redisplay_tool_bar)
7692 (display_menu_bar): Force left-to-right direction. Add a FIXME
7693 comment for making that be controlled by a user option.
7694 (push_it, pop_it): Save and restore the state of the
7695 bidi iterator. Save and restore the bidi_p flag.
7696 (pop_it): Iterate out of display property for string iteration as
7697 well.
7698 (iterate_out_of_display_property): Support iteration over strings.
7699 (handle_single_display_spec): Set up it->bidi_it for iteration
7700 over a display string, and call bidi_init_it.
7701 (handle_single_display_spec, next_overlay_string)
7702 (get_overlay_strings_1, push_display_prop): Set up the bidi
7703 iterator for displaying display or overlay strings.
7704 (forward_to_next_line_start): Don't use the shortcut if
7705 bidi-iterating.
7706 (back_to_previous_visible_line_start): If handle_display_prop
7707 pushed the iterator stack, restore the internal state of the bidi
7708 iterator by calling bidi_pop_it same number of times.
7709 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7710 and we are bidi-iterating, don't decrement the iterator position;
7711 instead, set the first_elt flag in the bidi iterator, to produce
7712 the same effect.
7713 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7714 (push_display_prop): xassert that we are iterating a buffer.
7715 (push_it, pop_it): Save and restore paragraph_embedding member.
7716 (handle_single_display_spec, next_overlay_string)
7717 (get_overlay_strings_1, reseat_1, reseat_to_string)
7718 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7719 correctly. Don't assume unibyte strings are not bidi-reordered.
7720 (compute_display_string_pos)
7721 (compute_display_string_end): Fix handling the case of C string.
7722 (push_it, pop_it): Save and restore from_disp_prop_p.
7723 (handle_single_display_spec, push_display_prop): Set the
7724 from_disp_prop_p flag.
7725 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7726 (pop_it): Call iterate_out_of_display_property only if we are
7727 popping after iteration over a string that came from a display
7728 property. Fix a typo in popping stretch info. Add an assertion
7729 for verifying that the iterator position is in sync with the bidi
7730 iterator.
7731 (handle_single_display_spec, get_overlay_strings_1)
7732 (push_display_prop): Fix initialization of paragraph direction for
7733 string when that of the parent object is not yet determined.
7734 (reseat_1): Call bidi_init_it to resync the bidi
7735 iterator with IT's position. (Bug#7616)
7736 (find_row_edges): If ROW->start.pos gives position
7737 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7738 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7739 Reset the from_disp_prop_p flag.
7740 (SAVE_IT, RESTORE_IT): New macros.
7741 (pos_visible_p, face_before_or_after_it_pos)
7742 (back_to_previous_visible_line_start)
7743 (move_it_in_display_line_to, move_it_in_display_line)
7744 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7745 (try_scrolling, redisplay_window, display_line): Use them when
7746 saving a temporary copy of the iterator and restoring it back.
7747 (back_to_previous_visible_line_start, reseat_1)
7748 (init_iterator): Empty the bidi cache "stack".
7749 (move_it_in_display_line_to): If iterator ended up at
7750 EOL, but we never saw any buffer positions smaller than
7751 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7752 motion in bidi-reordered lines.
7753 (move_it_in_display_line_to): Record prev_method and prev_pos
7754 immediately before the call to set_iterator_to_next. Fixes cursor
7755 motion in bidi-reordered lines with stretch glyphs and strings
7756 displayed in margins. (Bug#8133) (Bug#8867)
7757 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7758 TO_CHARPOS.
640c8776
SM
7759 (pos_visible_p): Support positions in bidi-reordered lines.
7760 Save and restore bidi cache.
0bb23927
EZ
7761
7762 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7763 (bidi_paragraph_info): Delete unused struct.
7764 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7765 (bidi_cache_start): New variable.
7766 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7767 to zero.
7768 (bidi_cache_fetch_state, bidi_cache_search)
7769 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7770 (bidi_cache_find, bidi_peek_at_next_level)
7771 (bidi_level_of_next_char, bidi_find_other_level_edge)
7772 (bidi_move_to_visually_next): Compare cache index with
7773 bidi_cache_start rather than with zero.
7774 (bidi_fetch_char): Accept new argument STRING; all callers
7775 changed. Support iteration over a string. Support strings with
7776 display properties. Support unibyte strings. Fix the type of
7777 `len' according to what STRING_CHAR_AND_LENGTH expects.
7778 (bidi_paragraph_init, bidi_resolve_explicit_1)
7779 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7780 (bidi_level_of_next_char, bidi_move_to_visually_next):
7781 Support iteration over a string.
0bb23927
EZ
7782 (bidi_set_sor_type, bidi_resolve_explicit_1)
7783 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7784 can now be zero (for strings); special values 0 and -1 were
7785 changed to -1 and -2, respectively.
7786 (bidi_char_at_pos): New function.
7787 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7788 Call it instead of FETCH_MULTIBYTE_CHAR.
7789 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7790 initialized to valid values.
7791 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7792 values.
7793 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7794 the test for valid cached positions. Fix the logic for looking up
7795 the sentinel state in the cache. GCPRO the Lisp string we are
7796 iterating.
7797 (bidi_push_it, bidi_pop_it): New functions.
7798 (bidi_initialize): Initialize the bidi cache start stack pointer.
7799 (bidi_cache_ensure_space): New function, refactored from part of
7800 bidi_cache_iterator_state. Don't assume the required size is just
7801 one BIDI_CACHE_CHUNK away.
7802 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7803 (bidi_count_bytes, bidi_char_at_pos): New functions.
7804 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7805 always valid if bidi_cache_idx is valid.
7806 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7807 is valid if it's going to be used.
7808 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7809 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7810 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7811 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7812 (bidi_find_other_level_edge, bidi_cache_start_stack):
7813 All variables related to cache indices are now EMACS_INT.
c965adc5 7814
0bb23927
EZ
7815 * dispextern.h (struct bidi_string_data): New structure.
7816 (struct bidi_it): New member `string'. Make flag members be 1-bit
7817 fields, and put them last in the struct.
640c8776
SM
7818 (compute_display_string_pos, compute_display_string_end):
7819 Update prototypes.
0bb23927
EZ
7820 (bidi_push_it, bidi_pop_it): Add prototypes.
7821 (struct iterator_stack_entry): New members bidi_p,
7822 paragraph_embedding, and from_disp_prop_p.
7823 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7824 (bidi_shelve_cache, bidi_unshelve_cache):
7825 Declare prototypes.
0bb23927
EZ
7826
7827 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7828 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7829 and vector-like objects.
7830
7831 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7832 cache around display iteration.
7833
7834 * window.c (Fwindow_end, window_scroll_pixel_based)
7835 (displayed_window_lines, Frecenter): Save and restore the bidi
7836 cache around display iteration.
7837
3bbd2265
LMI
78382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7839
7840 * editfns.c (Fdelete_region): Clarify the use of the named
7841 parameters (bug#6788).
7842
adc47434
MR
78432011-07-14 Martin Rudalics <rudalics@gmx.at>
7844
7845 * indent.c (Fvertical_motion): Set and restore w->pointm when
7846 saving and restoring the window's buffer (Bug#9006).
7847
837c31f8
LMI
78482011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7849
7850 * editfns.c (Fstring_to_char): Clarify just what is returned
7851 (bug#6576). Text by Eli Zaretskii.
7852
ac389d0c
JB
78532011-07-13 Juanma Barranquero <lekktu@gmail.com>
7854
7855 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7856
0be0ce47
EZ
78572011-07-13 Eli Zaretskii <eliz@gnu.org>
7858
7859 * buffer.c (mmap_find): Fix a typo.
7860
cd18e7e3
JB
78612011-07-13 Johan Bockgård <bojohan@gnu.org>
7862
7863 Fix execution of x selection hooks.
7864 * xselect.c (Qx_lost_selection_functions)
7865 (Qx_sent_selection_functions): New vars.
7866 (syms_of_xselect): DEFSYM them.
7867 (x_handle_selection_request): Pass Qx_sent_selection_functions
7868 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7869 (x_handle_selection_clear,x_clear_frame_selections):
7870 Pass Qx_lost_selection_functions rather than
7871 Vx_lost_selection_functions to Frun_hook_with_args.
7872
47ea7f44
PE
78732011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7874
ac389d0c 7875 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7876 The old code sometimes used this field without initializing it.
7877
47ea7f44
PE
7878 * alloc.c (gc_sweep): Don't read past end of array.
7879 In theory, the old code could also have corrupted Emacs internals,
7880 though it'd be very unlikely.
7881
bc985c87
AS
78822011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7883
7884 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7885 argument. (Bug#4026)
bc985c87 7886
0cf34688
LMI
78872011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7888
b3dadd76
LMI
7889 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7890 key" (bug#4257).
7891
0cf34688
LMI
7892 * window.c (Fset_window_start): Doc fix (bug#4199).
7893 (Fset_window_hscroll): Ditto.
7894
270768cd
PE
78952011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7896
077e3dda 7897 Fix minor new problems caught by GCC 4.6.1.
270768cd 7898 * term.c (init_tty): Remove unused local.
490011a6 7899 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7900 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7901 not used otherwise.
270768cd 7902
b1f58454
CY
79032011-07-12 Chong Yidong <cyd@stupidchicken.com>
7904
7905 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7906
22b9578d
LMI
79072011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7908
6e70ab07
LMI
7909 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7910 are the mini-buffer and the echo area (bug#3320).
7911
22b9578d
LMI
7912 * term.c (init_tty): Remove support for supdup, c10 and perq
7913 terminals, which are no longer supported (bug#1482).
7914
8974cc9f
JB
79152011-07-10 Johan Bockgård <bojohan@gnu.org>
7916
7917 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7918
a560d974
JD
79192011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7920
7921 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7922 for non-popups (Bug#3642).
7923
1dae0f0a
AS
79242011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7925
268c2c36 7926 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7927 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7928 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7929 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7930 * data.c (fmod): Likewise.
7931 * dispnew.c (swap_glyphs_in_rows): Likewise.
7932 * emacs.c (memory_warning_signal): Likewise.
7933 * floatfns.c (float_error): Likewise.
7934 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7935 (otf_open, font_otf_capability, generate_otf_features)
7936 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7937 Likewise.
7938 * image.c (pbm_read_file): Likewise.
7939 * indent.c (string_display_width): Likewise.
7940 * intervals.c (check_for_interval, search_for_interval)
7941 (inc_interval_count, count_intervals, root_interval)
7942 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7943 * lread.c (defalias): Likewise.
268c2c36 7944 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7945 * regex.c (set_image_of_range_1, set_image_of_range)
7946 (regex_grow_registers): Likewise.
7947 * sysdep.c (strerror): Likewise.
7948 * termcap.c (valid_filename_p, tprint, main): Likewise.
7949 * tparam.c (main): Likewise.
7950 * unexhp9k800.c (run_time_remap, save_data_space)
7951 (update_file_ptrs, read_header, write_header, calculate_checksum)
7952 (copy_file, copy_rest, display_header): Likewise.
7953 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7954 Likewise.
7955 * xdisp.c (check_it): Likewise.
7956 * xfaces.c (register_color, unregister_color, unregister_colors):
7957 Likewise.
7958 * xfns.c (print_fontset_result): Likewise.
7959 * xrdb.c (member, fatal, main): Likewise.
7960
99033785
PE
79612011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7962
7963 Fix minor problems found by static checking (Bug#9031).
7964 * chartab.c (char_table_set_range, map_sub_char_table):
7965 Remove unused locals.
7966 (uniprop_table): Now static.
7967 * composite.c (_work_char): Remove unused static var.
7968
9cb2ac56
JB
79692011-07-09 Juanma Barranquero <lekktu@gmail.com>
7970
7971 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7972
f25661f0
JD
79732011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7974
7975 * gtkutil.c (qttip_cb): Remove code without function.
7976
8278c4fe
EZ
79772011-07-09 Eli Zaretskii <eliz@gnu.org>
7978
7979 * w32.c (pthread_sigmask): New stub.
7980
1692ae2d 79812011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7982
8a6ebd58 7983 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7984 sigprocmask is portable only for single-threaded applications, and
7985 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7986 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7987 (LIBES): Use it.
7988 * callproc.c (Fcall_process):
7989 * process.c (create_process):
7990 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7991 Use pthread_sigmask, not sigprocmask.
123403e4 7992
1b854618
JD
79932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7994
7995 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7996 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7997 wrong (Bug#8591).
7998
3fe4b549
JD
79992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8000
0ce7e563
JD
8001 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8002 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8003 (xg_hide_tooltip): Fix comment.
8004
3fe4b549
JD
8005 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8006 in registerServicesMenuSendTypes.
8007 (validRequestorForSendType): Don't check ns_return_types.
8008
8009 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8010 ns_return_type.
8011
5df75e47
JR
80122011-07-08 Jason Rumney <jasonr@gnu.org>
8013
22610910
JR
8014 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8015 SH_SHOW for hidden windows (Bug#5482).
8016
5df75e47
JR
8017 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8018 frame struct members of non-existent frames (Bug#6284).
8019
699c10bd
JD
80202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8021
4393663b
JD
8022 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8023 variable firstTime not needed on OSX >= 10.6.
8024 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8025 >= 10.5. Use setKnobProportion, setDoubleValue.
8026
8027 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8028 (MAC_OS_X_VERSION_10_5): Define if not defined.
8029 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8030 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8031 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8032
8033 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8034 cString and lossyCString on OSX >= 10.4.
4393663b 8035
58179cce 8036 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8037 sizeToFit on OSX >= 10.2.
8038
8039 * nsimage.m (allocInitFromFile): Don't use deprecated method
8040 bestRepresentationForDevice on OSX >= 10.6.
8041
8042 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8043 to avoid warning.
8044
8045 * emacs.c: Declare unexec_init_emacs_zone.
8046
a63e0781
JD
8047 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8048
699c10bd
JD
8049 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8050
8051 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8052 on svcsMenu (Bug#8842).
8053
8054 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8055 ns_return_types.
8056 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8057
8058 * nsterm.m (QUTF8_STRING): Declare.
8059 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8060 (validRequestorForSendType): Return type is (id).
8061 Change indexOfObjectIdenticalTo to indexOfObject.
8062 Check if we have local selection before returning self (Bug#8842).
8063 (writeSelectionToPasteboard): Put local selection into paste board
8064 if we have a local selection (Bug#8842).
8065 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8066
8067 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8068 (ns_get_local_selection): Declare.
8069
54e10184
LMI
80702011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8071
9888ff71
LMI
8072 * keymap.c (describe_map_tree): Don't insert a double newline at
8073 the end of the buffer (bug#1169) and return whether we inserted
8074 something.
8075
54e10184
LMI
8076 * callint.c (Fcall_interactively): Change "reading args" to
8077 "providing args" to try to clarify what it does (bug#1010).
8078
15fa4783
KH
80792011-07-07 Kenichi Handa <handa@m17n.org>
8080
8081 * composite.c (composition_compute_stop_pos): Ignore a static
8082 composition starting before CHARPOS (Bug#8915).
8083
8084 * xdisp.c (handle_composition_prop): Likewise.
8085
a8815b00
EZ
80862011-07-07 Eli Zaretskii <eliz@gnu.org>
8087
8088 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8089 (Bug#9015)
8090
ef7b981d 80912011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8092
8093 * character.h (unicode_category_t): New enum type.
8094
8095 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8096 (Qchar_code_property_table): New variable.
8097 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8098 (UNIPROP_COMPRESSED_FORM_P): New macros.
8099 (char_table_ascii): Uncompress the compressed values.
8100 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8101 Uncompress the compressed values.
ac389d0c 8102 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8103 (char_table_ref_and_range): Uncompress the compressed values.
8104 (sub_char_table_set): New arg is_uniprop. Callers changed.
8105 Uncompress the compressed values.
8106 (sub_char_table_set_range): Args changed. Callers changed.
8107 (char_table_set_range): Adjuted for the above change.
8108 (map_sub_char_table): Delete args default_val and parent. Add arg
8109 top. Give decoded values to a Lisp function.
640c8776 8110 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8111 values to a Lisp function. Gcpro more variables.
8112 (uniprop_table_uncompress)
8113 (uniprop_decode_value_run_length): New functions.
8114 (uniprop_decoder, uniprop_decoder_count): New variables.
8115 (uniprop_get_decoder, uniprop_encode_value_character)
8116 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8117 New functions.
8118 (uniprop_encoder, uniprop_encoder_count): New variables.
8119 (uniprop_get_encoder, uniprop_table)
8120 (Funicode_property_table_internal, Fget_unicode_property_internal)
8121 (Fput_unicode_property_internal): New functions.
8122 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8123 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8124 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8125 char-code-property-alist.
8126
640c8776 8127 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8128 Vunicode_category_table.
8129
640c8776 8130 * font.c (font_range): Adjust for the change of
c805dec0
KH
8131 Vunicode_category_table.
8132
76b397fb
DN
81332011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8134
8135 * m/iris4d.h: Remove file, move contents ...
8136 * s/irix6-5.h: ... here.
8137
22b4128e
PE
81382011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8139
8140 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8141 * alloc.c (mark_buffer):
8142 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8143 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8144 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8145 This isn't true in general, and it's particularly not true
8146 if Emacs is configured with --with-wide-int.
8147 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8148 New macros, used in the buffer.c change.
8149
869795d6
JD
81502011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8151
8152 * xsettings.c: Use both GConf and GSettings if both are available.
8153 (store_config_changed_event): Add comment.
8154 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8155 (store_tool_bar_style_changed): New functions.
5e617bc2 8156 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8157 (struct xsettings): Move font inside HAVE_XFT.
8158 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8159 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8160 Move inside HAVE_XFT.
640c8776 8161 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8162 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8163 also.
8164 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8165 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8166 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8167 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8168 (parse_settings): Move check for font inside HAVE_XFT.
8169 (read_settings, apply_xft_settings): Add comment.
8170 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8171 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8172 call store_font_name_changed.
8173 (xft_settings_event): Add comment.
8174 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8175 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8176 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8177 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8178 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8179 (xsettings_get_system_font, xsettings_get_system_normal_font):
8180 Add comment.
869795d6 8181
d8ed26bd
PE
81822011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8183
8184 Random fixes. E.g., (random) never returned negative values.
8185 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8186 subseconds part to the entropy, as that's a bit more random.
8187 Prefer signed to unsigned, since the signedness doesn't matter and
8188 in general we prefer signed. When given a limit, use a
8189 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8190 latter isn't right if USE_2_TAGS_FOR_INTS.
8191 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8192 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8193
cabf1cac
SM
81942011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8195
8196 * textprop.c (text_property_stickiness):
8197 Obey Vtext_property_default_nonsticky.
8198 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8199 * w32fns.c (syms_of_w32fns):
8200 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8201
6e9b2be9
PE
82022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8203
8204 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8205 This is more efficient than Ffile_directory_p and avoids a minor race.
8206
90186c68
LMI
82072011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8208
7c301272
LMI
8209 * buffer.c (Foverlay_put): Say what the return value is
8210 (bug#7835).
8211
c4f2d8d4
LMI
8212 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8213 is a directory before asking whether to use the file name
8214 (bug#7564).
ad637907
LMI
8215 (barf_or_query_if_file_exists): Make the "File is a directory"
8216 error be more correct.
c4f2d8d4 8217
90186c68
LMI
8218 * fns.c (Frequire): Remove the mention of the .gz files, since
8219 that's installation-specific, but keep the mention of
8220 `get-load-suffixes'.
8221
da64016e
PE
82222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8223
8224 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8225 Report string overflow if the output is too long.
8226
7d47b580
JB
82272011-07-04 Juanma Barranquero <lekktu@gmail.com>
8228
a555cb87
JB
8229 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8230 (syms_of_gnutls): Remove duplicate DEFSYM for
8231 Qgnutls_bootprop_verify_hostname_error, an error for
8232 Qgnutls_bootprop_verify_error (which is no longer used).
8233
7d47b580
JB
8234 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8235 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8236 Also (re)move comments that are misplaced or no longer relevant.
8237
1e49bfab
LMI
82382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8239
8240 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8241
1485f4c0
CY
82422011-07-03 Chong Yidong <cyd@stupidchicken.com>
8243
8244 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8245 and background color parameters if they have been changed.
8246
a9ab721e
LMI
82472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8248
8249 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8250
cf7cff57
PE
82512011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8252
2e13213d
PE
8253 * xsettings.c (SYSTEM_FONT): Define only when used.
8254 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8255
cf7cff57
PE
8256 * keymap.c (access_keymap_1): Now static.
8257
7a8e04f7
CY
82582011-07-02 Chong Yidong <cyd@stupidchicken.com>
8259
8260 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8261 leave any prefix arg for the up event (Bug#1586).
8262
61352f62
LMI
82632011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8264
69bb1ef7
LMI
8265 * lread.c (syms_of_lread): Mention single symbols defined by
8266 `defvar' or `defconst' (bug#7154).
8267
61352f62 8268 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8269 (Frequire): Mention get-load-suffixes.
61352f62 8270
28545e04
MR
82712011-07-02 Martin Rudalics <rudalics@gmx.at>
8272
8273 * window.h (window): Remove clone_number slot.
8274 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8275 Remove.
8276 (make_parent_window, make_window, saved_window)
8277 (Fset_window_configuration, save_window_save): Don't deal with
8278 clone numbers.
8279 * buffer.c (Qclone_number): Remove declaration.
8280 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8281
3349e122
SM
82822011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8283
8284 Add multiple inheritance to keymaps.
8285 * keymap.c (Fmake_composed_keymap): New function.
8286 (Fset_keymap_parent): Simplify.
8287 (fix_submap_inheritance): Remove.
8288 (access_keymap_1): New function extracted from access_keymap to handle
8289 embedded parents and handle lists of maps.
8290 (access_keymap): Use it.
8291 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8292 (Fcopy_keymap): Handle embedded parents.
8293 (Fcommand_remapping, define_as_prefix): Simplify.
8294 (Fkey_binding): Simplify.
8295 (syms_of_keymap): Move minibuffer-local-completion-map,
8296 minibuffer-local-filename-completion-map,
8297 minibuffer-local-must-match-map, and
8298 minibuffer-local-filename-must-match-map to Elisp.
8299 (syms_of_keymap): Defsubr make-composed-keymap.
8300 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8301 (parse_menu_item): Trivial simplification.
8302
3279eb87
GM
83032011-07-01 Glenn Morris <rgm@gnu.org>
8304
8305 * Makefile.in (SETTINGS_LIBS): Fix typo.
8306
4550efdf
KI
83072011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8308
8309 * coding.c (Fencode_coding_string): Record the last coding system
8310 used, as the function doc string says (bug#8738).
8311
0949d2b6
JD
83122011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8313
8314 * xsettings.c (store_monospaced_changed): Take new font as arg and
8315 check for change against current_mono_font.
8316 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8317 (emacs_settings_constructor, emacs_settings_get_property)
8318 (emacs_settings_set_property, emacs_settings_class_init)
8319 (emacs_settings_init, gsettings_obj): Remove.
8320 (something_changedCB): New function for HAVE_GSETTINGS.
8321 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8322 with value as argument.
8323 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8324 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8325 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8326 "changed".
8327
8328 * xgselect.c: Add defined (HAVE_GSETTINGS).
8329 (xgselect_initialize): Ditto.
8330
8331 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8332 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8333 xg_select.
8334
bbc6b304
PE
83352011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8336
8337 * eval.c (struct backtrace): Simplify and port the data structure.
8338 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8339 signed bit field, as this assumption is not portable and it makes
8340 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8341 "char debug_on_exit : 1" as this is not portable either; instead,
8342 use the portable "unsigned int debug_on_exit : 1". Remove unused
8343 member evalargs. Remove obsolete comments about cc bombing out.
8344
9851bfc5
JD
83452011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8346
51bb811f 8347 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8348 Let HAVE_GSETTINGS override HAVE_GCONF.
8349 (store_monospaced_changed): New function.
8350 (EMACS_SETTINGS): A new type derived from GObject to handle
8351 GSettings notifications.
8352 (emacs_settings_constructor, emacs_settings_get_property)
8353 (emacs_settings_set_property, emacs_settings_class_init):
8354 New functions.
8355 (gsettings_client, gsettings_obj): New variables.
8356 (GSETTINGS_SCHEMA): New define.
8357 (something_changedCB): Call store_monospaced_changed.
8358 (init_gsettings): New function.
8359 (xsettings_initialize): Call init_gsettings.
8360 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8361 to NULL.
8362
640c8776 8363 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8364 GCONF_CFLAGS/LIBS.
8365
5386012d
MR
83662011-06-29 Martin Rudalics <rudalics@gmx.at>
8367
8368 * window.c (resize_root_window, grow_mini_window)
8369 (shrink_mini_window): Rename Qresize_root_window to
8370 Qwindow_resize_root_window and Qresize_root_window_vertically to
8371 Qwindow_resize_root_window_vertically.
8372
f13e0b08
PE
83732011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8374
8375 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8376
94515237
JB
83772011-06-27 Juanma Barranquero <lekktu@gmail.com>
8378
8379 * makefile.w32-in: Redesign dependencies so they reflect more
8380 clearly which files are directly included by each source file,
8381 and not through other includes.
8382
e43b6e43
MR
83832011-06-27 Martin Rudalics <rudalics@gmx.at>
8384
8385 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8386 (sort_overlays, overlay_strings): When an overlay's clone number
8387 matches the window's clone number process the overlay even if
8388 the overlay's window property doesn't match the current window.
8389
d68443dc
MR
8390 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8391 (Fwindow_hchild): Rename to Fwindow_left_child.
8392 (Fwindow_next): Rename to Fwindow_next_sibling.
8393 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8394 (resize_window_check): Rename to window_resize_check.
8395 (resize_window_apply): Rename to window_resize_apply.
8396 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8397 (Fdelete_other_windows_internal, resize_frame_windows)
8398 (Fsplit_window_internal, Fdelete_window_internal)
8399 (grow_mini_window, shrink_mini_window)
8400 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8401
c7e73be5
JD
84022011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8403
8404 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8405 (emacs_fixed_set_min_size): Remove.
8406 (emacs_fixed_new): Take frame as argument.
8407
8408 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8409 (_EmacsFixedPrivate): Remove minwidth/height.
8410 Add struct frame *f.
8411 (emacs_fixed_init): Initialize priv->f.
8412 (get_parent_class, emacs_fixed_set_min_size): Remove.
8413 (emacs_fixed_new): Set priv->f to argument.
8414 (emacs_fixed_get_preferred_width)
8415 (emacs_fixed_get_preferred_height): Use min_width/height from
8416 frames size_hint to set minimum and natural (Bug#8919).
8417 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8418 and use min_width/height from frames size_hint to set
8419 min_width/height (Bug#8919).
8420
8421 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8422 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8423 Fix indentation.
c7e73be5 8424
cf99dcf8
EZ
84252011-06-26 Eli Zaretskii <eliz@gnu.org>
8426
8427 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8428 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8429 called at ZV.
8430
029529ac
CY
84312011-06-26 Chong Yidong <cyd@stupidchicken.com>
8432
8433 * process.c (wait_reading_process_output): Bypass select if
8434 waiting for a cell while ignoring keyboard input, and input is
8435 pending. Suggested by Jan Djärv (Bug#8869).
8436
7a7ef429
PE
84372011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8438
8439 Use gnulib's dup2 module instead of rolling our own.
8440 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8441
11fdef7d 84422011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8443
8444 * dispnew.c (scrolling_window): Before scrolling, turn off a
8445 mouse-highlight in the window being scrolled.
8446
cd3520a4
JB
84472011-06-24 Juanma Barranquero <lekktu@gmail.com>
8448
8449 Move DEFSYM to lisp.h and use everywhere.
8450
8451 * character.h (DEFSYM): Move declaration...
8452 * lisp.h (DEFSYM): ...here.
8453
8454 * gnutls.c:
8455 * minibuf.c:
8456 * w32menu.c:
8457 * w32proc.c:
8458 * w32select.c: Don't include character.h.
8459
8460 * alloc.c (syms_of_alloc):
8461 * buffer.c (syms_of_buffer):
8462 * bytecode.c (syms_of_bytecode):
8463 * callint.c (syms_of_callint):
8464 * casefiddle.c (syms_of_casefiddle):
8465 * casetab.c (init_casetab_once):
8466 * category.c (init_category_once, syms_of_category):
8467 * ccl.c (syms_of_ccl):
8468 * cmds.c (syms_of_cmds):
8469 * composite.c (syms_of_composite):
8470 * dbusbind.c (syms_of_dbusbind):
8471 * dired.c (syms_of_dired):
8472 * dispnew.c (syms_of_display):
8473 * doc.c (syms_of_doc):
8474 * editfns.c (syms_of_editfns):
8475 * emacs.c (syms_of_emacs):
8476 * eval.c (syms_of_eval):
8477 * fileio.c (syms_of_fileio):
8478 * fns.c (syms_of_fns):
8479 * frame.c (syms_of_frame):
8480 * fringe.c (syms_of_fringe):
8481 * insdel.c (syms_of_insdel):
8482 * keymap.c (syms_of_keymap):
8483 * lread.c (init_obarray, syms_of_lread):
8484 * macros.c (syms_of_macros):
8485 * msdos.c (syms_of_msdos):
8486 * print.c (syms_of_print):
8487 * process.c (syms_of_process):
8488 * search.c (syms_of_search):
8489 * sound.c (syms_of_sound):
8490 * syntax.c (init_syntax_once, syms_of_syntax):
8491 * terminal.c (syms_of_terminal):
8492 * textprop.c (syms_of_textprop):
8493 * undo.c (syms_of_undo):
8494 * w32.c (globals_of_w32):
8495 * window.c (syms_of_window):
8496 * xdisp.c (syms_of_xdisp):
8497 * xfaces.c (syms_of_xfaces):
8498 * xfns.c (syms_of_xfns):
8499 * xmenu.c (syms_of_xmenu):
8500 * xsettings.c (syms_of_xsettings):
8501 * xterm.c (syms_of_xterm): Use DEFSYM.
8502
4228cf16
TZ
85032011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8504
cd3520a4 8505 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8506
7fcccf1e
PE
85072011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8508
7efb4e0e
PE
8509 Integer and buffer overflow fixes (Bug#8873).
8510
ff5844ad
PE
8511 * print.c (printchar, strout): Check for string overflow.
8512 (PRINTPREPARE, printchar, strout):
8513 Don't set size unless allocation succeeds.
8514
90532f02
PE
8515 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8516 for sizes. Check for string overflow more accurately.
8517 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8518
6d84508d
PE
8519 * macros.c: Integer and buffer overflow fixes.
8520 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8521 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8522 Use ptrdiff_t, not int, for sizes.
8523 Don't increment bufsize until after realloc succeeds.
8524 Check for size-calculation overflow.
8525 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8526
437b2cb4
PE
8527 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8528
8b9ac8b4
PE
8529 * lread.c: Integer overflow fixes.
8530 (read_integer): Radix is now EMACS_INT, not int,
8531 to improve quality of diagnostics for out-of-range radices.
8532 Calculate buffer size correctly for out-of-range radices.
8533 (read1): Check for integer overflow in radices, and in
8534 read-circle numbers.
82cb60d3
PE
8535 (read_escape): Avoid int overflow.
8536 (Fload, openp, read_buffer_size, read1)
8537 (substitute_object_recurse, read_vector, read_list, map_obarray):
8538 Use ptrdiff_t, not int, for sizes.
8539 (read1): Use EMACS_INT, not int, for sizes.
20270765 8540 Check for size overflow.
8b9ac8b4 8541
7fcccf1e
PE
8542 * image.c (cache_image): Check for size arithmetic overflow.
8543
bfbbd7e7
PE
8544 * lread.c: Integer overflow issues.
8545 (saved_doc_string_size, saved_doc_string_length)
8546 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8547 Now ptrdiff_t, not int.
8548 (read1): Don't assume doc string length fits in int. Check for
8549 out-of-range doc string lengths.
8550 (read_list): Don't assume file position fits in int.
39019e54 8551 (read_escape): Check for hex character overflow.
bfbbd7e7 8552
4e323265
LL
85532011-06-22 Leo Liu <sdl.web@gmail.com>
8554
8555 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8556 Move to minibuffer.el.
8557
85fece3e
PE
85582011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8559
20b84ce9 8560 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8561 The following patches are for when GLYPH_DEBUG && !XASSERT.
8562 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8563 * dispnew.c (flush_stdout):
8564 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8565 Mark as externally visible.
8566 * dispnew.c (check_window_matrix_pointers): Now static.
8567 * dispnew.c (window_to_frame_vpos):
8568 * xfns.c (unwind_create_frame):
8569 * xterm.c (x_check_font): Remove unused local.
8570 * scroll.c (CHECK_BOUNDS):
8571 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8572 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8573 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8574 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8575 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8576 Now static.
8577 (debug_method_add): Use va_list and vsprintf rather than relying
8578 on undefined behavior with wrong number of arguments.
8579 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8580 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8581 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8582 since we're not interested in debugging glyphs with old libraries.
8583 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8584 GCC 4.6.0's static checking.
8585
0766b489
PE
85862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8587
31fd4b32
PE
8588 Integer overflow and signedness fixes (Bug#8873).
8589 A few related buffer overrun fixes, too.
8590
b79e8648
PE
8591 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8592
0766b489
PE
8593 * dispextern.h (struct face.stipple):
8594 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8595 (x_bitmap_mask, x_allocate_bitmap_record)
8596 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8597 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8598 (x_create_bitmap_from_xpm_data):
8599 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8600 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8601 (.bitmaps_last):
8602 * xfaces.c (load_pixmap):
8603 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8604 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8605 (.bitmaps_last, struct x_output.icon_bitmap):
8606 Use ptrdiff_t, not int, for bitmap indexes.
8607 (x_allocate_bitmap_record): Check for size overflow.
8608 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8609
b081724f
PE
8610 Use ptrdiff_t, not int, for overlay counts.
8611 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8612 * editfns.c (overlays_around, get_pos_property):
8613 * textprop.c (get_char_property_and_overlay):
8614 * xdisp.c (next_overlay_change, note_mouse_highlight):
8615 * xfaces.c (face_at_buffer_position):
21514da7
PE
8616 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8617 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8618 (Fnext_overlay_change, Fprevious_overlay_change)
8619 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8620 Use ptrdiff_t, not int, for sizes.
21514da7 8621 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8622
3de73e5e
PE
8623 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8624
2606c57b
PE
8625 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8626 (x_session_initialize): Do not assume string length fits in int.
8627
aaafe47a
PE
8628 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8629 This is unlikely, but can occur if DPI is outlandish.
8630
2674ddc8 8631 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8632 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8633
28154962
PE
8634 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8635 * xrdb.c (magic_file_p, search_magic_path):
8636 Omit last arg SUFFIX; it was always 0. All callers changed.
8637 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8638
7de51af5
PE
8639 * xfont.c (xfont_match): Avoid need for strlen.
8640
25ed6cc3
PE
8641 * xfns.c: Don't assume strlen fits in int.
8642 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8643
4eab31dd
PE
8644 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8645 not unsigned long, as we prefer signed integers. All callers changed.
8646 Detect integer overflow in repeat count.
8647 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8648 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8649
171e2a58
PE
8650 * termcap.c: Don't assume sizes fit in int and never overflow.
8651 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8652 (gobble_line): Check for size-calculation overflow.
8653
ad39faca 8654 * minibuf.c (Fread_buffer):
6e5bb2dc 8655 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8656 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8657 Don't assume string length fits in int.
8658
52c61c22 8659 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8660 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8661
b5b8c9e5
PE
8662 * font.c: Don't assume string length fits in int.
8663 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8664 Use ptrdiff_t, not int.
ccd6111c
PE
8665 (font_intern_prop): Don't assume string length fits in int.
8666 Don't assume integer property fits in fixnum.
8667 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8668
882f0d81 8669 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8670 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8671 Reformulate so as not to need the command string.
8672 Invoke gzip -cd rather than gunzip, as it's more portable.
8673 (lock_info_type, lock_file_1, lock_file):
8674 Don't assume pid_t and time_t fit in unsigned long.
8675 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8676 (current_lock_owner): Prefer signed type for sizes.
8677 Use memcpy, not strncpy, where memcpy is what is really wanted.
8678 Don't assume (via atoi) that time_t and pid_t fit in int.
8679 Check for time_t and/or pid_t out of range, e.g., via a network share.
8680 Don't alloca where an auto var works fine.
8681
93f4cf88
PE
8682 * fileio.c: Fix some integer overflow issues.
8683 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8684 Don't assume string length fits in int.
8685 (directory_file_name): Don't assume string length fits in long.
8686 (make_temp_name): Don't assume pid fits in int, or that its print
8687 length is less than 20.
8688
f3e92b69
PE
8689 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8690
1bfdaf10
PE
8691 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8692
35016e9a
PE
8693 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8694
3d1e65a1
PE
8695 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8696 We prefer signed integers, even for size calculations.
8697
0b963a93
PE
8698 * emacs.c: Don't assume string length fits in 'int'.
8699 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8700 (main): Don't invoke strlen when not needed.
8701
573f4b54
PE
8702 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8703 (XD_DEBUG_MESSAGE): Don't waste a byte.
8704
989f33ba
PE
8705 * callproc.c (getenv_internal_1, getenv_internal)
8706 (Fgetenv_internal):
965d34eb
PE
8707 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8708
e4d29b33
PE
8709 * lread.c (invalid_syntax): Omit length argument.
8710 All uses changed. This doesn't fix a bug, but it simplifies the
8711 code away from its former Hollerith-constant appearance, and it's
8712 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8713 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8714
eb49b136
PE
8715 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8716 This didn't break anything, but it didn't help either.
8717 It's confusing to put a bogus integer in a place where the actual
8718 value does not matter.
9f62aeb1 8719 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8720 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8721
15375a22
PE
8722 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8723 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8724 implementation.
b61cc01c
PE
8725 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8726 We prefer signed types, and the value cannot exceed the EMACS_INT
8727 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8728 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8729 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8730 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8731
53b2623d
PE
8732 * indent.c (sane_tab_width): New function.
8733 (current_column, scan_for_column, Findent_to, position_indentation)
8734 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8735 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8736
51cab52b 8737 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8738
f2ed8a70
PE
8739 * lisp.h (lint_assume): New macro.
8740 * composite.c (composition_gstring_put_cache):
8741 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8742
abe80cc6
PE
8743 * editfns.c, insdel.c:
8744 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8745
b02c740e
PE
8746 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8747
ebc96716
PE
8748 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8749
b4e50fa0 8750 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8751 Use much-faster test for byte-length change.
311d5d7c 8752 Don't assume string byte-length fits in 'int'.
a4cf38e4 8753 Check that character arg fits in 'int'.
85461888 8754 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8755
c0c1ee9f
PE
8756 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8757
a498d7f4
PE
8758 * fns.c (concat): Catch string overflow earlier.
8759 Do not rely on integer wraparound.
8760
51cab52b
PE
8761 * dispextern.h (struct it.overlay_strings_charpos)
8762 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8763 * xdisp.c (forward_to_next_line_start)
8764 (back_to_previous_visible_line_start)
8765 (reseat_at_next_visible_line_start, next_element_from_buffer):
8766 Don't arbitrarily truncate the value of 'selective' to int.
8767
76031fad
PE
8768 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8769
5eb55db9
PE
8770 * composite.c: Don't truncate sizes to 'int'.
8771 (composition_gstring_p, composition_reseat_it)
8772 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8773 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8774 not EMACS_UINT, for indexes.
5eb55db9 8775
0703a717
PE
8776 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8777
d6202519
PE
8778 * buffer.c: Include <verify.h>.
8779 (struct sortvec.priority, struct sortstr.priority):
8961a454 8780 Now EMACS_INT, not int.
c20998a7 8781 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8782 (struct sortstr.size, record_overlay_string)
8783 (struct sortstrlist.size, struct sortlist.used):
8784 Don't truncate size to int.
8785 (record_overlay_string): Check for size-calculation overflow.
d6202519 8786 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8787
d5a19415
JM
87882011-06-22 Jim Meyering <meyering@redhat.com>
8789
029529ac 8790 Don't leak an XBM-image-sized buffer
d5a19415
JM
8791 * image.c (xbm_load): Free the image buffer after using it.
8792
a9041e6c
PE
87932011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8794
8795 Port to Sun C.
8796 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8797 that Sun C diagnosed.
8798 * fns.c (secure_hash): Fix pointer signedness issue.
8799 * intervals.c (static_offset_intervals): New function.
8800 (offset_intervals): Use it.
8801
7f3f739f
LL
88022011-06-21 Leo Liu <sdl.web@gmail.com>
8803
8804 * deps.mk (fns.o):
8805 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8806 sha512.h.
8807
8808 * fns.c (secure_hash): Rename from crypto_hash_function and change
8809 the first arg to accept symbols.
5b66d427 8810 (Fsecure_hash): New primitive.
7f3f739f
LL
8811 (syms_of_fns): New symbols.
8812
76147d94
DD
88132011-06-20 Deniz Dogan <deniz@dogan.se>
8814
8815 * process.c (Fset_process_buffer): Clarify return value in
8816 docstring.
8817
7d7d0045
CY
88182011-06-18 Chong Yidong <cyd@stupidchicken.com>
8819
8820 * dispnew.c (add_window_display_history): Use BVAR.
8821
8822 * xdisp.c (debug_method_add): Use BVAR.
8823 (check_window_end, dump_glyph_matrix, dump_glyph)
8824 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8825
8826 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8827 Likewise.
8828
8829 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8830 check till after the cache is created in init_frame_faces.
8831
ff2bc410
SM
88322011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8833
8834 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8835
28177add
PE
88362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8837
dd3482fe
PE
8838 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8839 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8840 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8841
393d71f3 8842 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8843 * fileio.c (Finsert_file_contents):
8844 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8845 Remove the old (too-loose) buffer overflow checks.
8846 They weren't needed, since make_gap checks for buffer overflow.
8847 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8848 The old code merely checked for Emacs fixnum overflow, and relied
8849 on undefined (wraparound) behavior. The new code avoids undefined
8850 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8851
2e6813b0 8852 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8853 Tune. Don't use wider integers than needed. Don't use alloca.
8854 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8855
599a9e4f
PE
8856 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8857
99561444
PE
8858 * insdel.c, lisp.h (buffer_overflow): New function.
8859 (insert_from_buffer_1, replace_range, replace_range_2):
8860 * insdel.c (make_gap_larger):
8861 * editfns.c (Finsert_char):
8862 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8863
28177add
PE
8864 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8865
e69dafad
PE
88662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8867
4baa020d 8868 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8869
b1c46f02
PE
8870 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8871 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8872
e69dafad
PE
8873 * fileio.c: Don't assume EMACS_INT fits in off_t.
8874 (emacs_lseek): New static function.
8875 (Finsert_file_contents, Fwrite_region): Use it.
8876 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8877
566684ea
PE
8878 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8879
e6966cd6
PE
8880 * fns.c: Don't overflow int when computing a list length.
8881 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8882 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8883 truncation on 64-bit hosts. Check for QUIT every
8884 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8885 faster and is responsive enough.
8886 (Flength): Report an error instead of overflowing an integer.
8887 (Fsafe_length): Return a float if the value is not representable
8888 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8889 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8890 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8891
dd0b0efb
PE
8892 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8893 (header_size, word_size): New constants.
8894 (allocate_vectorlike): Don't check size overflow here.
8895 (allocate_vector): Check it here instead, since this is the only
8896 caller of allocate_vectorlike that could cause overflow.
8897 Check that the new vector's length is representable as a fixnum.
8898
86fe5cfe
PE
8899 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8900 The previous code was bogus. For example, next_almost_prime (32)
8901 returned 39, which is undesirable as it is a multiple of 3; and
8902 next_almost_prime (24) returned 25, which is a multiple of 5 so
8903 why was the code bothering to check for multiples of 7?
8904
80e88859
PE
8905 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8906
4a2f0ad6
PE
8907 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8908
f66c7cf8
PE
8909 Variadic C functions now count arguments with ptrdiff_t.
8910 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8911 Back then I didn't know that the Emacs coding style prefers signed int.
8912 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8913 were being counted with int, which may truncate counts on 64-bit
8914 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8915 * lisp.h (struct Lisp_Subr.function.aMANY)
8916 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8917 Arg counts are now ptrdiff_t, not size_t.
8918 All variadic functions and their callers changed accordingly.
8919 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8920 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8921 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8922 * callint.c (Fcall_interactively): Check arg count for overflow,
8923 to avoid potential buffer overrun. Use signed char, not 'int',
8924 for 'varies' array, so that we needn't bother to check its size
8925 calculation for overflow.
8926 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8927 * eval.c (apply_lambda):
8928 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8929 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8930 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8931
a1759b76
PE
8932 * callint.c (Fcall_interactively): Don't use index var as event count.
8933
d96be9fc
PE
8934 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8935 * mem-limits.h (SIZE): Remove; no longer used.
8936
a690a978 8937 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8938
578c21e6
PE
8939 Remove unnecessary casts.
8940 * xterm.c (x_term_init):
8941 * xfns.c (x_set_border_pixel):
8942 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8943 These aren't needed now that we assume ANSI C.
8944
96f53c6c
PE
8945 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8946 It's more likely to cause problems (due to unsigned overflow)
8947 than to cure them.
8948
83c77d31
PE
8949 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8950
ee2079f1
PE
8951 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8952
6da65536
PE
8953 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8954
7147c4a4
PE
8955 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8956
193e32d9
PE
8957 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8958
e5533da6
PE
8959 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8960
9910e595
PE
8961 GLYPH_CODE_FACE returns EMACS_INT, not int.
8962 * dispextern.h (merge_faces):
8963 * xfaces.c (merge_faces):
01103c44
PE
8964 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8965 Don't assume EMACS_INT fits in int.
9910e595 8966
2638320e
PE
8967 * character.h (CHAR_VALID_P): Remove unused parameter.
8968 * fontset.c, lisp.h, xdisp.c: All uses changed.
8969
045eb8d9
PE
8970 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8971
c1f134b5
PE
8972 * fns.c (concat): Minor tuning based on overflow analysis.
8973 This doesn't fix any bugs. Use int to hold character, instead
8974 of constantly refetching from Emacs object. Use XFASTINT, not
8975 XINT, for value known to be a character. Don't bother comparing
8976 a single byte to 0400, as it's always less.
8977
395fcb93 8978 * floatfns.c (Fexpt):
327eeec8
PE
8979 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8980
abbd3d23
PE
8981 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8982 for characters.
8983
684a03ef
PE
8984 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8985
0fed43f3
PE
8986 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8987 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8988 incorrectly succeed when S was a string, because 4294967386 was
8989 truncated before it was used.
8990
8fd02eb7
PE
8991 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8992 Otherwise, an out-of-range integer could cause undefined behavior
8993 on a 64-bit host.
8994
f8c86b69
PE
8995 * composite.c: Use int, not EMACS_INT, for characters.
8996 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8997 EMACS_INT, for values that are known to be in character range.
8998 This doesn't fix any bugs but is the usual style inside Emacs and
8999 may generate better code on 32-bit machines.
9000
34206dd2
PE
9001 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9002 This is for reasons similar to the recent CHAR_STRING fix.
9003 * charset.c (Fencode_char): Check that character arg is actually
9004 a character. Pass an int to ENCODE_CHAR.
9005 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9006 wider than 'int', as a compile-time check to prevent future regressions
9007 in this area.
9008
c5958d4c 9009 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9010
9011 Make sure a 64-bit char is never passed to CHAR_STRING.
9012 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9013 by silently ignoring the top 32 bits, allowing some values
9014 that were far too large to be valid characters.
9015 * character.h: Include <verify.h>.
9016 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9017 arguments are no wider than unsigned, as a compile-time check
9018 to prevent future regressions in this area.
9019 * data.c (Faset):
01103c44 9020 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9021 (Fsubst_char_in_region):
9022 * fns.c (concat):
9023 * xdisp.c (decode_mode_spec_coding):
9024 Adjust to CHAR_STRING's new requirement.
9025 * editfns.c (Finsert_char, Fsubst_char_in_region):
9026 * fns.c (concat): Check that character args are actually
9027 characters. Without this test, these functions did the wrong
9028 thing with wildly out-of-range values on 64-bit hosts.
9029
d37ca623
PE
9030 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9031 These casts should not be needed on 32-bit hosts, either.
9032 * keyboard.c (read_char):
9033 * lread.c (Fload): Remove casts to unsigned.
9034
ea204efb
PE
9035 * lisp.h (UNSIGNED_CMP): New macro.
9036 This fixes comparison bugs on 64-bit hosts.
9037 (ASCII_CHAR_P): Use it.
9038 * casefiddle.c (casify_object):
01103c44 9039 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9040 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9041 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9042 * dispextern.h (FACE_FROM_ID):
9043 * keyboard.c (read_char): Use UNSIGNED_CMP.
9044
41cb286c
PE
9045 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9046 not to EMACS_INT, to avoid GCC warning.
9047
4a1b9832
PE
9048 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9049
55daad71
PE
9050 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9051 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9052 isn't needed on 32-bit machines.
8f95c75c 9053
01103c44
PE
9054 * buffer.c (Fgenerate_new_buffer_name):
9055 Use EMACS_INT for count, not int.
0ceccced 9056 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9057
9058 * data.c (Qcompiled_function): Now static.
9059
c6f072e7
PE
9060 * window.c (window_body_lines): Now static.
9061
20ce5912
PE
9062 * image.c (gif_load): Rename local to avoid shadowing.
9063
9c4c5f81
PE
9064 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9065 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9066 * alloc.c (make_save_value): Integer argument is now of type
9067 ptrdiff_t, not int.
9068 (mark_object): Use ptrdiff_t, not int.
9069 * lisp.h (pD): New macro.
9070 * print.c (print_object): Use it.
9071
c0c5c8ae
PE
9072 * alloc.c: Use EMACS_INT, not int, to count objects.
9073 (total_conses, total_markers, total_symbols, total_vector_size)
9074 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9075 (total_free_floats, total_floats, total_free_intervals)
9076 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9077 Now EMACS_INT, not int. All uses changed.
9078 (Fgarbage_collect): Compute overall total using a double, so that
9079 integer overflow is less likely to be a problem. Check for overflow
9080 when converting back to an integer.
5a25e253
PE
9081 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9082 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9083 These were 'int' variables that could overflow on 64-bit hosts;
9084 they were never used, so remove them instead of repairing them.
211a0b2a 9085 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9086 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9087 Previously, this ceilinged at INT_MAX, but that doesn't work on
9088 64-bit machines.
e46bb31a 9089 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9090
c78baabf 9091 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9092 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9093 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9094 when a (possibly-narrower) signed value would do just as well.
9095 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9096
c9d624c6
PE
9097 * alloc.c: Catch some string size overflows that we were missing.
9098 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9099 for convenience in STRING_BYTES_MAX.
9100 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9101 The definition here is exact; the one in lisp.h was approximate.
9102 (allocate_string_data): Check for string overflow. This catches
9103 some instances we weren't catching before. Also, it catches
9104 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9105 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9106 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9107
c9d624c6
PE
9108 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9109 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9110 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9111
353032ce
PE
9112 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9113
2bccce07
PE
9114 * alloc.c (Fmake_string): Check for out-of-range init.
9115
0ac30604
SM
91162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9117
9118 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9119
c195f2de
JD
91202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9121
9122 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9123 xg_get_default_scrollbar_width.
9124
9125 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9126 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9127 (style_changed_cb): Call update_theme_scrollbar_width and call
9128 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9129 all frames (Bug#8505).
9130 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9131 Call gtk_window_set_resizable if HAVE_GTK3.
9132 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9133 and height if HAVE_GTK3 (Bug#8505).
9134 (scroll_bar_width_for_theme): New variable.
9135 (update_theme_scrollbar_width): New function.
9136 (xg_get_default_scrollbar_width): Move code to
9137 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9138 (xg_initialize): Call update_theme_scrollbar_width.
9139
9140 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9141
9142 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9143
e10ac9f1
MR
91442011-06-12 Martin Rudalics <rudalics@gmx.at>
9145
9146 * frame.c (make_frame): Call other_buffer_safely instead of
9147 other_buffer.
9148
9149 * window.c (temp_output_buffer_show): Call display_buffer with
9150 second argument Vtemp_buffer_show_specifiers and reset latter
9151 immediately after the call.
9152 (Vtemp_buffer_show_specifiers): New variable.
9153 (auto_window_vscroll_p, next_screen_context_lines)
9154 (Vscroll_preserve_screen_position): Remove leading asterisks from
9155 doc-strings.
9156
2d3c217e 91572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9158
7b7f97e8 9159 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9160 * buffer.c (Qclone_number): Remove for now, as it's unused.
9161 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9162 (record_buffer): Remove unused local.
9163 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9164 (set_frame_buffer_list): Remove; unused.
9165 * frame.h (other_visible_frames): Remove decl.
9166 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9167 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9168 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9169 if HAVE_GPM.
9170 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9171 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9172 Define only if HAVE_GPM.
9173 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9174 (update_hints_inhibit): Remove; never set. All uses removed.
9175 * widgetprv.h (emacsFrameClassRec): Remove decl.
9176 * window.c (delete_deletable_window): Now returns void, since it
9177 wasn't returning anything.
9178 (compare_window_configurations): Remove unused locals.
9179 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9180 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9181 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9182 the same widths as pointers. This follows up on the 2011-05-06 patch.
9183 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9184 * xterm.h: Likewise.
9185 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9186
1384b89e
JB
91872011-06-12 Juanma Barranquero <lekktu@gmail.com>
9188
9189 * makefile.w32-in: Update dependencies.
9190 (LISP_H): Add lib/intprops.h.
9191
1100a63c
CY
91922011-06-11 Chong Yidong <cyd@stupidchicken.com>
9193
9194 * image.c (gif_load): Add animation frame delay to the metadata.
9195 (syms_of_image): Use DEFSYM. New symbol `delay'.
9196
6198ccd0
MR
91972011-06-11 Martin Rudalics <rudalics@gmx.at>
9198
9199 * window.c (delete_deletable_window): Re-add.
9200 (Fset_window_configuration): Rewrite to handle dead buffers and
9201 consequently deletable windows.
9202 (window_tree, Fwindow_tree): Remove. Supply functionality in
9203 window.el.
9204 (compare_window_configurations): Simplify code.
9205
b6e3633c
AS
92062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9207
1ab0dee5
AS
9208 * image.c (imagemagick_load_image): Fix type mismatch.
9209 (Fimagemagick_types): Likewise.
9210
b6e3633c
AS
9211 * window.h (replace_buffer_in_windows): Declare.
9212
9397e56f
MR
92132011-06-11 Martin Rudalics <rudalics@gmx.at>
9214
9215 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9216 Qclone_number. Remove external declaration of Qdelete_window.
9217 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9218 code.
640c8776
SM
9219 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9220 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9221 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9222 buffer list implementation.
9223 (other_buffer_safely): New function.
9224 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9225 calls to replace_buffer_in_windows and
9226 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9227 if allowed.
9228 (record_buffer): Inhibit quitting and rewrite using quittable
9229 functions. Run Qbuffer_list_update_hook if allowed.
9230 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9231 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9232 Move switch-to-buffer to window.el.
9397e56f
MR
9233 (bury-buffer): Move to window.el.
9234 (Vbuffer_list_update_hook): New variable.
9235
9236 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9237 section.
9238
9239 * window.h (resize_frame_windows): Move up in code.
9240 (Fwindow_frame): Remove EXFUN.
9241 (replace_buffer_in_all_windows): Remove prototype.
9242 (replace_buffer_in_windows_safely): Add prototype.
9243
9244 * window.c: Declare Qdelete_window static again. Move down
9245 declaration of select_count.
9246 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9247 (Fother_window): Move to window.el.
9248 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9249 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9250 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9251 window.el.
9252 (replace_buffer_in_windows): Implement by calling
9253 Qreplace_buffer_in_windows.
9254 (replace_buffer_in_all_windows): Remove with some functionality
9255 moved into replace_buffer_in_windows_safely.
9256 (replace_buffer_in_windows_safely): New function.
9257 (select_window_norecord, select_frame_norecord): Move in front
9258 of run_window_configuration_change_hook. Remove now obsolete
9259 declarations.
640c8776
SM
9260 (Fset_window_buffer): Rewrite doc-string.
9261 Call Qrecord_window_buffer.
9397e56f
MR
9262 (keys_of_window): Move binding for other-window to window.el.
9263
b50691aa
CY
92642011-06-11 Chong Yidong <cyd@stupidchicken.com>
9265
9266 * dispextern.h (struct image): Replace data member, whose int_val
9267 and ptr_val fields were not used by anything, with a single
9268 lisp_val object.
9269
9270 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9271 (gif_clear_image, gif_load, imagemagick_load_image)
9272 (gs_clear_image, gs_load): Callers changed.
9273
3f754b86
PE
92742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9275
cca69397
PE
9276 * buffer.h: Include <time.h>, for time_t.
9277 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9278
109e28d0
PE
9279 Fix minor problems found by static checking.
9280
60737f02
PE
9281 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9282
4b66faf3
PE
9283 Make identifiers static if they are not used in other modules.
9284 * data.c (Qcompiled_function, Qframe, Qvector):
9285 * image.c (QimageMagick, Qsvg):
9286 * minibuf.c (Qmetadata):
9287 * window.c (resize_window_check, resize_root_window): Now static.
9288 * window.h (resize_window_check, resize_root_window): Remove decls.
9289
109e28d0
PE
9290 * window.c (window_deletion_count, delete_deletable_window):
9291 Remove; unused.
46a4ce9e
PE
9292 (window_body_lines): Now static.
9293 (Fdelete_other_windows_internal): Mark vars as initialized.
9294 Make sure 'resize_failed' is initialized.
9295 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9296 (resize_window_apply): Remove unused local.
9297 * window.h (delete_deletable_window): Remove decl.
9298
109e28d0 9299 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9300 (imagemagick_load_image): Fix pointer signedness problem by changing
9301 last arg from unsigned char * to char *. All uses changed.
9302 Also, fix a local for similar reasons.
9303 Remove unused locals. Remove locals to avoid shadowing.
9304 (fn_rsvg_handle_free): Remove; unused.
9305 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9306 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9307
3f754b86
PE
9308 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9309
2547adb1
CY
93102011-06-10 Chong Yidong <cyd@stupidchicken.com>
9311
9312 * image.c (gif_load): Fix omitted cast error introduced by
9313 2011-06-06 change.
9314
2c8e37d4
MR
93152011-06-10 Martin Rudalics <rudalics@gmx.at>
9316
9317 * window.h (resize_proportionally, orig_total_lines)
9318 (orig_top_line): Remove from window structure.
9319 (set_window_height, set_window_width, change_window_heights)
9320 (Fdelete_window): Remove prototypes.
9321 (resize_frame_windows): Remove duplicate declaration.
9322
440a42e3
EZ
93232011-06-10 Eli Zaretskii <eliz@gnu.org>
9324
9325 * window.h (resize_frame_windows, resize_window_check)
9326 (delete_deletable_window, resize_root_window)
9327 (resize_frame_windows): Declare prototypes.
9328
9329 * window.c (resize_window_apply): Make definition be "static" to
9330 match the prototype.
9331
562dd5e9
MR
93322011-06-10 Martin Rudalics <rudalics@gmx.at>
9333
9334 * window.c: Remove declarations of Qwindow_size_fixed,
9335 window_min_size_1, window_min_size_2, window_min_size,
9336 size_window, window_fixed_size_p, enlarge_window, delete_window.
9337 Remove static from declaration of Qdelete_window, it's
9338 temporarily needed by Fbury_buffer.
9339 (replace_window): Don't assign orig_top_line and
9340 orig_total_lines.
9341 (Fdelete_window, delete_window): Remove. Window deletion is
9342 handled by window.el.
640c8776
SM
9343 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9344 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9345 (Fdelete_other_windows): Remove. Deleting other windows is
9346 handled by window.el.
9347 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9348 handled in window.el.
9349 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9350 Window minimum sizes are handled in window.el.
9351 (shrink_windows, size_window, set_window_height)
9352 (set_window_width, change_window_heights, window_height)
9353 (window_width, CURBEG, CURSIZE, enlarge_window)
9354 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9355 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9356 handled in window.el.
9357 (make_dummy_parent): Rename to make_parent_window and give it a
9358 second argument horflag.
9359 (make_window): Don't set resize_proportionally any more.
9360 (Fsplit_window): Remove. Windows are split in window.el.
9361 (save_restore_action, save_restore_orig_size)
9362 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9363 Resize mini windows in window.el.
9364 (grow_mini_window, shrink_mini_window): Implement by calling
9365 Qresize_root_window_vertically, resize_window_check and
9366 resize_window_apply.
640c8776
SM
9367 (saved_window, Fset_window_configuration, save_window_save):
9368 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9369 resize_proportionally.
9370 (window_min_height, window_min_width): Move to window.el.
9371 (keys_of_window): Move bindings for delete-other-windows,
9372 split-window, delete-window and enlarge-window to window.el.
9373
9374 * buffer.c: Temporarily extern Qdelete_window.
9375 (Fbury_buffer): Temporarily call Qdelete_window instead of
9376 Fdelete_window (Fbury_buffer will move to window.el soon).
9377
9378 * frame.c (set_menu_bar_lines_1): Remove code handling
9379 orig_top_line and orig_total_lines.
9380
9381 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9382 set_window_height but set heights directly.
9383 (change_frame_size_1): Use resize_frame_windows.
9384
9385 * xdisp.c (init_xdisp): Don't use set_window_height but set
9386 heights directly.
9387
640c8776
SM
9388 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9389 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9390 run_window_configuration_change_hook.
9391
9392 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9393 instead of change_window_heights and run
9394 run_window_configuration_change_hook.
9395
1a13852e
MR
93962011-06-09 Martin Rudalics <rudalics@gmx.at>
9397
9398 * window.c (replace_window): Rename second argument REPLACEMENT to
9399 NEW. New third argument SETFLAG. Rewrite.
9400 (delete_window, make_dummy_parent): Call replace_window with
9401 third argument 1.
9402 (window_list_1): Move down in code.
9403 (run_window_configuration_change_hook): Move set_buffer part
9404 before select_frame_norecord part in order to unwind correctly.
9405 Rename count1 to count.
9406 (recombine_windows, delete_deletable_window, resize_root_window)
9407 (Fdelete_other_windows_internal)
9408 (Frun_window_configuration_change_hook, make_parent_window)
9409 (resize_window_check, resize_window_apply, Fresize_window_apply)
9410 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9411 (Fdelete_window_internal, Fresize_mini_window_internal):
9412 New functions.
1a13852e
MR
9413 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9414
f3d1777e
MR
94152011-06-08 Martin Rudalics <rudalics@gmx.at>
9416
496e208e
MR
9417 * window.h (window): Add some new members to window structure -
9418 normal_lines, normal_cols, new_total, new_normal, clone_number,
9419 splits, nest, prev_buffers, next_buffers.
9420 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9421 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9422
f3d1777e
MR
9423 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9424 Remove.
496e208e
MR
9425 (make_dummy_parent): Set new members of windows structure.
9426 (make_window): Move down in code. Handle new members of window
9427 structure.
9428 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9429 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9430 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9431 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9432 (Fset_window_next_buffers, Fset_window_clone_number):
9433 New functions.
496e208e
MR
9434 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9435 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9436 Doc-string fixes.
9437 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9438 Argument WINDOW can be now internal window too.
9439 (Fwindow_use_time): Move up in code.
9440 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9441 Rewrite doc-string.
9442 (Fset_window_configuration, saved_window)
9443 (Fcurrent_window_configuration, save_window_save): Handle new
9444 members of window structure.
b9e809c2
MR
9445 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9446 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9447 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9448 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9449 Qget_mru_window, Qresize_root_window,
9450 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9451 Qauto_buffer_name; staticpro them.
f3d1777e 9452
abde8f8c
MR
94532011-06-07 Martin Rudalics <rudalics@gmx.at>
9454
9455 * window.c (Fwindow_total_size, Fwindow_left_column)
9456 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9457 (Fwindow_list_1): New functions.
9458 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9459 (Fwindow_width, Fscroll_left, Fscroll_right):
9460 Use window_body_cols instead of window_box_text_cols.
9461 (delete_window, Fset_window_configuration):
9462 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9463 (delete_all_subwindows): Take a window as argument and not a
9464 structure. Rewrite.
190b47e6
MR
9465 (window_loop): Remove handling of GET_LRU_WINDOW and
9466 GET_LARGEST_WINDOW.
9467 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9468
9469 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9470 window_box_text_cols. delete_all_subwindows now takes a
9471 Lisp_Object as argument.
abde8f8c 9472
640c8776
SM
9473 * indent.c (compute_motion, Fcompute_motion):
9474 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9475
fa8a67e6
MR
9476 * frame.c (delete_frame): Call delete_all_subwindows with root
9477 window as argument.
9478
a54e3482
DC
94792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9480
9481 * fns.c (Fputhash): Document return value.
9482
60002bf5
CY
94832011-06-06 Chong Yidong <cyd@stupidchicken.com>
9484
9485 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9486
0c671da6 94872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9488
b862a52a 9489 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9490
be44ca6c
PE
9491 Check for overflow when converting integer to cons and back.
9492 * charset.c (Fdefine_charset_internal, Fdecode_char):
9493 Use cons_to_unsigned to catch overflow.
9494 (Fencode_char): Use INTEGER_TO_CONS.
9495 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9496 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9497 * data.c (long_to_cons, cons_to_long): Remove.
9498 (cons_to_unsigned, cons_to_signed): New functions.
9499 These signal an error for invalid or out-of-range values.
9500 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9501 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9502 * font.c (Ffont_variation_glyphs):
9503 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9504 * lisp.h: Include <intprops.h>.
9505 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9506 (cons_to_signed, cons_to_unsigned): New decls.
9507 (long_to_cons, cons_to_long): Remove decls.
9508 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9509 (Fprimitive_undo): Use CONS_TO_INTEGER.
9510 * xfns.c (Fx_window_property): Likewise.
9511 * xselect.c: Include <limits.h>.
9512 (x_own_selection, selection_data_to_lisp_data):
9513 Use INTEGER_TO_CONS.
9514 (x_handle_selection_request, x_handle_selection_clear)
9515 (x_get_foreign_selection, Fx_disown_selection_internal)
9516 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9517 (lisp_data_to_selection_data): Use cons_to_unsigned.
9518 (x_fill_property_data): Use cons_to_signed.
9519 Report values out of range.
9520
d1f3d2af
PE
9521 Check for buffer and string overflow more precisely.
9522 * buffer.h (BUF_BYTES_MAX): New macro.
9523 * lisp.h (STRING_BYTES_MAX): New macro.
9524 * alloc.c (Fmake_string):
9525 * character.c (string_escape_byte8):
9526 * coding.c (coding_alloc_by_realloc):
9527 * doprnt.c (doprnt):
9528 * editfns.c (Fformat):
9529 * eval.c (verror):
9530 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9531 since they may not be the same number.
9532 * editfns.c (Finsert_char):
9533 * fileio.c (Finsert_file_contents):
9534 Likewise for BUF_BYTES_MAX.
9535
dd52fcea
PE
9536 * image.c: Use ptrdiff_t, not int, for sizes.
9537 (slurp_file): Switch from int to ptrdiff_t.
9538 All uses changed.
9539 (slurp_file): Check that file size fits in both size_t (for
9540 malloc) and ptrdiff_t (for sanity and safety).
9541
7f9bbdbb
PE
9542 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9543 if b->modtime has its maximal value.
9544
dfe18f82
PE
9545 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9546
84acfcf0
PE
9547 Don't assume time_t can fit into int.
9548 * buffer.h (struct buffer.modtime): Now time_t, not int.
9549 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9550 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9551
ccd9a01a
PE
9552 Minor fixes for signed vs unsigned integers.
9553 * character.h (MAYBE_UNIFY_CHAR):
9554 * charset.c (maybe_unify_char):
9555 * keyboard.c (read_char, reorder_modifiers):
9556 XINT -> XFASTINT, since the integer must be nonnegative.
9557 * ftfont.c (ftfont_spec_pattern):
9558 * keymap.c (access_keymap, silly_event_symbol_error):
9559 XUINT -> XFASTINT, since the integer must be nonnegative.
9560 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9561 since it makes no difference and we prefer signed.
9562 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9563 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9564 nonnegative.
9565
d6d100dd
SM
95662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9567
9568 * window.h (Fwindow_frame): Declare.
9569
2b6148e4
PE
95702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9571
9572 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9573 (SPARE_MEMORY): Always define.
9574 (LARGE_REQUEST): Remove.
9575 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9576
f230ecc9
MR
95772011-06-06 Martin Rudalics <rudalics@gmx.at>
9578
727e958e
MR
9579 * lisp.h: Move EXFUNS for Fframe_root_window,
9580 Fframe_first_window and Fset_frame_selected_window to window.h.
9581
9582 * window.h: Move EXFUNS for Fframe_root_window,
9583 Fframe_first_window and Fset_frame_selected_window here from
9584 lisp.h.
9585
9586 * frame.c (Fwindow_frame, Fframe_first_window)
9587 (Fframe_root_window, Fframe_selected_window)
9588 (Fset_frame_selected_window): Move to window.c.
9589 (Factive_minibuffer_window): Move to minibuf.c.
9590 (Fother_visible_frames_p): New function.
9591
9592 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9593
f230ecc9
MR
9594 * window.c (decode_window, decode_any_window): Move up in code.
9595 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9596 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9597 (Fwindow_buffer): Move up and rewrite doc-string.
9598 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9599 (Fwindow_prev): New functions.
727e958e
MR
9600 (Fwindow_frame): Move here from frame.c. Accept any window as
9601 argument.
9602 (Fframe_root_window, Fframe_first_window)
9603 (Fframe_selected_window): Move here from frame.c. Accept frame
9604 or arbitrary window as argument. Update doc-strings.
9605 (Fminibuffer_window): Move up in code.
9606 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9607 (Fset_frame_selected_window): Move here from frame.c.
9608 Marginal rewrite.
727e958e
MR
9609 (Fselected_window, select_window, Fselect_window): Move up in
9610 code. Minor doc-string fixes.
f230ecc9 9611
4d09bcf6
PE
96122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9613
9614 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9615 Do not assume that spare memory exists; that assumption is valid
9616 only if SYSTEM_MALLOC.
9617 (LARGE_REQUEST): New macro, so that the issue of large requests
9618 is separated from the issue of spare memory.
9619
810928a2
AS
96202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9621
172418ad
AS
9622 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9623 format. (Bug#8806)
9624
43f862f7
AS
9625 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9626
810928a2
AS
9627 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9628 before statements.
9629
a059fe24
JD
96302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9631
9632 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9633
9634 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9635
9636 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9637 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9638
989bf368
JB
96392011-06-05 Juanma Barranquero <lekktu@gmail.com>
9640
9641 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9642
4b80f674
CY
96432011-06-04 Chong Yidong <cyd@stupidchicken.com>
9644
9645 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9646 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9647 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9648 New error handlers.
4b80f674
CY
9649 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9650 Obey Vx_select_enable_clipboard_manager. Catch errors in
9651 x_clipboard_manager_save (Bug#8779).
9652 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9653 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9654
99a33b77 96552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9656
9657 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9658
99a33b77 96592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9660
9661 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9662 in the current matrix if keep_current_p is non-zero.
9663
8264569d
EZ
96642011-06-04 Eli Zaretskii <eliz@gnu.org>
9665
9666 * bidi.c (bidi_level_of_next_char): Fix last change.
9667
57f97249
EZ
96682011-06-03 Eli Zaretskii <eliz@gnu.org>
9669
fec2107c 9670 Support bidi reordering of text covered by display properties.
57f97249 9671
fec2107c
EZ
9672 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9673 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9674 (bidi_cache_search, bidi_cache_iterator_state)
9675 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9676 (bidi_level_of_next_char, bidi_move_to_visually_next):
9677 Support character positions inside a run of characters covered by a
fec2107c
EZ
9678 display string.
9679 (bidi_paragraph_init, bidi_resolve_explicit_1)
9680 (bidi_level_of_next_char): Call bidi_fetch_char and
9681 bidi_fetch_char_advance instead of FETCH_CHAR and
9682 FETCH_CHAR_ADVANCE.
9683 (bidi_init_it): Initialize new members.
9684 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9685 definitions.
9686 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9687 instead of using explicit *_CHAR codes.
d6d100dd
SM
9688 (bidi_resolve_explicit, bidi_resolve_weak):
9689 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9690 bidirectional text is supported only in multibyte buffers.
9691 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9692 it to initialize the frame_window_p member of struct bidi_it.
9693 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9694 (bidi_resolve_explicit, bidi_resolve_weak)
9695 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9696 bidi_it->nchars is non-positive.
9697 (bidi_level_of_next_char): Don't try to lookup the cache for the
9698 next/previous character if nothing is cached there yet, or if we
9699 were just reseat()'ed to a new position.
c40e2fb2 9700
0e14fe90
EZ
9701 * xdisp.c (set_cursor_from_row): Set start and stop points
9702 according to the row's direction when priming the loop that looks
9703 for the glyph on which to display cursor.
9704 (single_display_spec_intangible_p): Function deleted.
9705 (display_prop_intangible_p): Reimplement to call
9706 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9707 Accept 3 additional arguments needed by handle_display_spec.
9708 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9709 values: lists, `(when COND...)' forms, etc.
9710 (single_display_spec_string_p): Support property values that are
9711 lists with the argument STRING its top-level element.
9712 (display_prop_string_p): Fix the condition for processing a
9713 property that is a list to be consistent with handle_display_spec.
fec2107c 9714 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9715 last portion of handle_display_prop.
9716 (compute_display_string_pos): Accept additional argument
9717 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9718 value of a `display' property is a "replacing spec".
9719 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9720 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9721 the display property, but just return a value indicating whether
9722 the display property will replace the characters it covers.
9723 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9724 frame_window_p members of struct bidi_it.
d6d100dd
SM
9725 (compute_display_string_pos, compute_display_string_end):
9726 New functions.
fec2107c
EZ
9727 (push_it): Accept second argument POSITION, where pop_it should
9728 jump to continue iteration.
9729 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9730
fec2107c
EZ
9731 * keyboard.c (adjust_point_for_property): Adjust the call to
9732 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9733
9734 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9735 (bidi_init_it): Update prototypes.
9736 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9737 (compute_display_string_pos, compute_display_string_end):
9738 Declare prototypes.
fec2107c
EZ
9739 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9740 EMACS_INT.
fc6f18ce 9741
40087514 97422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9743
57f53182
PE
9744 Malloc failure behavior now depends on size of allocation.
9745 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9746 * lisp.h: Change signatures accordingly.
9747 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9748 All callers changed. (Bug#8762)
9749
9750 * gnutls.c: Use Emacs's memory allocators.
9751 Without this change, the gnutls library would invoke malloc etc.
9752 directly, which causes problems on non-SYNC_INPUT hosts, and which
9753 runs afoul of improving memory_full behavior. (Bug#8761)
9754 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9755 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9756 xfree instead of the default malloc, realloc, free.
9757 (Fgnutls_boot): No need to check for memory allocation failure,
9758 since xmalloc does that for us.
9759
ac32cd99 9760 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9761 * category.c (hash_get_category_set):
9762 * ccl.c (ccl_driver):
9763 * charset.c (Fdefine_charset_internal):
9764 * charset.h (struct charset.hash_index):
9765 * composite.c (get_composition_id, gstring_lookup_cache)
9766 (composition_gstring_put_cache):
9767 * composite.h (struct composition.hash_index):
9768 * dispextern.h (struct image.hash):
9769 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9770 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9771 (hashfn_equal, hashfn_user_defined, make_hash_table)
9772 (maybe_resize_hash_table, hash_lookup, hash_put)
9773 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9774 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9775 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9776 * image.c (make_image, search_image_cache, lookup_image)
9777 (xpm_put_color_table_h):
9778 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9779 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9780 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9781 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9782 * alloc.c (allocate_vectorlike):
9783 Check for overflow in vector size calculations.
9784 * ccl.c (ccl_driver):
9785 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9786 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9787 need to be updated by these changes.
40087514
PE
9788 * fns.c (make_hash_table, maybe_resize_hash_table):
9789 Check for integer overflow with large hash tables.
0de4bb68
PE
9790 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9791 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9792 (SXHASH_REDUCE): New macro.
9793 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9794 Use it instead of discarding useful hash info with large hash values.
9795 (sxhash_float): New function.
9796 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9797 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9798 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9799 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9800 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9801 Adjust signatures to match updated version of code.
9802 (consing_since_gc): Now EMACS_INT, since a single hash table can
9803 use more than INT_MAX bytes.
9804
698d32e2
DN
98052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9806
9807 Make it possible to build with GCC-4.6+ -O2 -flto.
9808
9809 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9810
fd6fa53f
SM
98112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9812
9813 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9814 Call minibuffer-inactive-mode.
9815
864db017
JB
98162011-05-31 Juanma Barranquero <lekktu@gmail.com>
9817
9818 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9819 Update dependencies.
9820
2ad0baf4
DN
98212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9822
9823 * data.c (init_data): Remove code for UTS, this system is not
9824 supported anymore.
9825
4fcc2638
DN
98262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9827
9828 Don't force ./temacs to start in terminal mode.
9829
9830 * frame.c (make_initial_frame): Initialize faces in all cases, not
9831 only when CANNOT_DUMP is defined.
9832 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9833
c56e0fd5
DN
98342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9835
9836 * dispnew.c (add_window_display_history): Use const for the string
9837 pointer. Remove declaration, not needed.
9838
333d54da 98392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9840
55d4c1b2 9841 Use 'inline', not 'INLINE'.
333d54da 9842 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9843 * alloc.c, fontset.c (INLINE): Remove.
9844 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9845 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9846 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9847 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9848 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9849
738db178
DN
98502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9851
9852 Make it possible to run ./temacs.
9853
9854 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9855 syms_of_callproc does the same thing. Remove test for
9856 "initialized", do it in the caller.
9857 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9858
620c53a6
SM
98592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9860
9861 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9862 (read_minibuf): Use get_minibuffer.
9863 (syms_of_minibuf): Use DEFSYM.
9864 (Qmetadata): New var.
9865 * data.c (Qbuffer): Don't make it static.
9866 (syms_of_data): Use DEFSYM.
9867
e003a292
PE
98682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9869
9870 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9871 (CCL_CODE_MIN): New macro.
9872
ed008a6d
PE
98732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9874
3687c2ef
PE
9875 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9876
ed008a6d
PE
9877 * eval.c (Qdebug): Now static.
9878 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9879 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9880 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9881
d66c4c7c
CY
98822011-05-29 Chong Yidong <cyd@stupidchicken.com>
9883
9884 * image.c: Various fixes to ImageMagick code comments.
9885 (Fimagemagick_types): Doc fix.
9886
5fbc2025
PE
98872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9888
0196f88a
PE
9889 Minor fixes prompted by GCC 4.6.0 warnings.
9890
9891 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9892
5fbc2025
PE
9893 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9894 (x_clipboard_manager_save_all): Move extern decl to ...
9895 * xterm.h: ... here, so that it can be checked for consistency.
9896
1dd3c2d9
CY
98972011-05-29 Chong Yidong <cyd@stupidchicken.com>
9898
9899 * xselect.c (x_clipboard_manager_save_frame)
9900 (x_clipboard_manager_save_all): New functions.
9901 (Fx_clipboard_manager_save): Lisp function deleted.
9902
9903 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9904 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9905
9906 * xterm.h: Update prototype.
9907
5ba6571d
WX
99082011-05-28 William Xu <william.xwl@gmail.com>
9909
9910 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9911 exiting (Bug#8239).
9912
3eaff834
JM
99132011-05-28 Jim Meyering <meyering@redhat.com>
9914
e1900994 9915 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9916 * fns.c (to_uchar): Define.
9917 (crypto_hash_function): Use it to convert some newly-signed
9918 variables to unsigned, to avoid sign-extension bugs. For example,
9919 without this change, (md5 "truc") would evaluate to
9920 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9921 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9922 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9923
0f6990a7
PE
99242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9925
9926 Integer overflow fixes.
c8a9ca5a 9927
08686060
PE
9928 * dbusbind.c: Serial number integer overflow fixes.
9929 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9930 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9931 to hold a serial number that is too large for a fixnum.
9932 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9933 Check for serial numbers out of range. Decode any serial number
59568bf0 9934 that was so large that it became a float. (Bug#8722)
08686060 9935
2d1fc3c7
PE
9936 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9937 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9938 Use XFASTINT rather than XUINT when numbers are nonnegative.
9939 (xd_append_arg, Fdbus_method_return_internal):
9940 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9941 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9942 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9943 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9944 (Bug#8722)
2d1fc3c7 9945
c8a9ca5a
PE
9946 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9947
519e1d69
PE
9948 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9949
6df6ae42 9950 ccl: Add integer overflow checks.
30569699
PE
9951 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9952 (IN_INT_RANGE): New macros.
9953 (ccl_driver): Use them to check for integer overflow when
9954 decoding a CCL program. Many of the new checks are whether XINT (x)
9955 fits in int; it doesn't always, on 64-bit hosts. The new version
9956 doesn't catch all possible integer overflows, but it's an
847044ea 9957 improvement. (Bug#8719)
30569699 9958
c11285dc
PE
9959 * alloc.c (make_event_array): Use XINT, not XUINT.
9960 There's no need for unsigned here.
9961
fdccd48e
PE
9962 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9963 This follows up to the 2011-05-06 change that substituted uintptr_t
9964 for EMACS_INT. This case wasn't caught back then.
9965
37910ab2
PE
9966 Rework Fformat to avoid integer overflow issues.
9967 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9968 now (part of C89). Include <verify.h>.
9969 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9970 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9971 (Fformat): Avoid the prepass trying to compute sizes; it was only
9972 approximate and thus did not catch overflow reliably. Instead, walk
9973 through the format just once, formatting and computing sizes as we go,
9974 checking for integer overflow at every step, and allocating a larger
9975 buffer as needed. Keep track separately whether the format is
9976 multibyte. Keep only the most-recently calculated precision, rather
9977 than them all. Record whether each argument has been converted to
9978 string. Use EMACS_INT, not int, for byte and char and arg counts.
9979 Support field widths and precisions larger than INT_MAX. Avoid
9980 sprintf's undefined behavior with conversion specifications such as %#d
9981 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9982 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9983 formatting out-of-range floating point numbers with int
9173deec 9984 formats. (Bug#8668)
37910ab2 9985
2e6578fb
PE
9986 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9987
0ae6bdee
PE
9988 * data.c: Avoid integer truncation in expressions involving floats.
9989 * data.c: Include <intprops.h>.
9990 (arith_driver): When there's an integer overflow in an expression
9991 involving floating point, convert the integers to floating point
9992 so that the resulting value does not suffer from catastrophic
9993 integer truncation. For example, on a 64-bit host (* 4
9994 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9995 Do not rely on undefined behavior after integer overflow.
9996
de883a70
PE
9997 merge count_size_as_multibyte, parse_str_to_multibyte
9998 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9999 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10000 Check for integer overflow.
10001 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10002 since it's now a duplicate of the other. This is more of
10003 a character than a buffer op, so better that it's in character.c.
10004 * fns.c, print.c: Adjust to above changes.
10005
2ff916cb
PE
100062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10007
10008 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10009
f1b54466
PE
100102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10011
fb1ac845
PE
10012 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10013 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10014 (x_clipboard_manager_save): Now static.
10015 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10016
f1b54466
PE
10017 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10018 (crypto_hash_function): Now static.
10019 Fix pointer signedness problems. Avoid unnecessary initializations.
10020
a9f737ee
CY
100212011-05-27 Chong Yidong <cyd@stupidchicken.com>
10022
10023 * termhooks.h (Vselection_alist): Make it terminal-local.
10024
10025 * terminal.c (create_terminal): Initialize it.
10026
10027 * xselect.c: Support for clipboard managers.
10028 (Vselection_alist): Move to termhooks.h as terminal-local var.
10029 (LOCAL_SELECTION): New macro.
10030 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10031 (symbol_to_x_atom): Remove gratuitous arg.
10032 (x_handle_selection_request, lisp_data_to_selection_data)
10033 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10034 (x_own_selection, x_get_local_selection, x_convert_selection):
10035 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10036 (some_frame_on_display): Delete unused function.
10037 (Fx_own_selection_internal, Fx_get_selection_internal)
10038 (Fx_disown_selection_internal, Fx_selection_owner_p)
10039 (Fx_selection_exists_p): New optional frame arg.
10040 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10041 (x_handle_selection_clear): Don't treat other terminals with the
10042 same keyboard specially. Use the terminal-local Vselection_alist.
10043 (x_clear_frame_selections): Use Frun_hook_with_args.
10044
10045 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10046
10047 * xterm.h: Add support for those atoms.
10048
e067f0c1
CY
100492011-05-26 Chong Yidong <cyd@stupidchicken.com>
10050
10051 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10052 (converted_selections, conversion_fail_tag): New global variables.
10053 (x_selection_request_lisp_error): Free the above.
10054 (x_get_local_selection): Remove unnecessary code.
10055 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10056 of converted selections stored in converted_selections.
10057 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10058 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10059 (x_convert_selection): New function.
10060 (x_handle_selection_event): Simplify.
10061 (x_get_foreign_selection): Don't ignore incoming requests while
10062 waiting for an answer; this will fail when we implement
10063 SAVE_TARGETS, and seems unnecessary anyway.
10064 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10065 (Vx_sent_selection_functions): Doc fix.
10066
0f4aebc0
LL
100672011-05-26 Leo Liu <sdl.web@gmail.com>
10068
10069 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10070
e61124cd
YM
100712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10072
10073 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10074
10075 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10076 for fringe update if it has periodic bitmap.
ac389d0c 10077 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10078 and fringe_bitmap_periodic_p.
10079
10080 * fringe.c (get_fringe_bitmap_data): New function.
10081 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10082 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10083 row. Mark glyph row for fringe update if periodicity changed.
10084
10085 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10086 for fringe update unless it has periodic bitmap.
10087
f16d9837
KH
100882011-05-25 Kenichi Handa <handa@m17n.org>
10089
10090 * xdisp.c (get_next_display_element): Set correct it->face_id for
10091 a static composition.
10092
e1b90ef6
LL
100932011-05-24 Leo Liu <sdl.web@gmail.com>
10094
10095 * deps.mk (fns.o):
10096 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10097
10098 * fns.c (crypto_hash_function, Fsha1): New function.
10099 (Fmd5): Use crypto_hash_function.
10100 (syms_of_fns): Add Ssha1.
10101
7400048f
PE
101022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10103
10104 * gnutls.c: Remove unused macros.
10105 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10106 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10107 Remove macros that are defined and never used.
10108 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10109
abb71cf4
CY
101102011-05-22 Chong Yidong <cyd@stupidchicken.com>
10111
10112 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10113 (Fx_get_selection_internal): Minor cleanup.
10114 (Fx_own_selection_internal): Rename arguments for consistency with
10115 select.el.
10116
6307db39
PE
101172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10118
10119 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10120
f3d4e0a4
CY
101212011-05-22 Chong Yidong <cyd@stupidchicken.com>
10122
10123 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10124
4d8ade89
YM
101252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10126
10127 * dispnew.c (scrolling_window): Don't exclude the case that the
10128 last enabled row in the desired matrix touches the bottom boundary.
10129
32078c8d
GM
101302011-05-21 Glenn Morris <rgm@gnu.org>
10131
10132 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10133 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10134 and add some more files.
32078c8d 10135
7285dc67
EZ
101362011-05-20 Eli Zaretskii <eliz@gnu.org>
10137
10138 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10139 report_file_error introduced by the change from 2011-05-07.
10140
89d1bd22
PE
101412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10142
10143 * systime.h (Time): Define only if emacs is defined.
10144 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10145 where the include path doesn't have X11/X.h by default. See
10146 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10147
cd394be1 101482011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10149
10150 * composite.c (find_automatic_composition): Fix previous change.
10151
b9704ad9
GM
101522011-05-20 Glenn Morris <rgm@gnu.org>
10153
10154 * lisp.mk: New file, split from Makefile.in.
10155 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10156 (shortlisp): Remove.
10157 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10158
4a720484
GM
101592011-05-19 Glenn Morris <rgm@gnu.org>
10160
10161 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10162 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10163 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10164 (lisp): Set the order to that of loadup.el.
10165 (shortlisp): Make it a copy of $lisp.
10166 (SOME_MACHINE_LISP): Remove.
10167 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10168 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10169
a28d4396
KH
101702011-05-18 Kenichi Handa <handa@m17n.org>
10171
10172 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10173 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10174 (find_automatic_composition): Mostly rewrite for efficiency.
10175
a2b1fa8e
JB
101762011-05-18 Juanma Barranquero <lekktu@gmail.com>
10177
10178 * makefile.w32-in: Update dependencies.
10179
8e1f5610
CS
101802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10181
10182 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10183 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10184
7025ee00 101852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10186
cdfa6eab
PE
10187 Fix some integer overflow issues, such as string length overflow.
10188
06d6db33
PE
10189 * insdel.c (count_size_as_multibyte): Check for string overflow.
10190
2b4560a8
PE
10191 * character.c (lisp_string_width): Check for string overflow.
10192 Use EMACS_INT, not int, for string indexes and lengths; in
10193 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10194 the resulting string length overflows an EMACS_INT; instead,
10195 report a string overflow if no precision given. When checking for
10196 precision exhaustion, use a check that cannot possibly have
10197 integer overflow. (Bug#8675)
10198 * character.h (lisp_string_width): Adjust to new signature.
10199
cb93f9be
PE
10200 * alloc.c (string_overflow): New function.
10201 (Fmake_string): Use it. This doesn't change behavior, but saves
10202 a few bytes and will simplify future changes.
10203 * character.c (string_escape_byte8): Likewise.
10204 * lisp.h (string_overflow): New decl.
10205
1a1f3366
PE
10206 Fixups, following up to the user-interface timestamp change.
10207 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10208 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10209 * msdos.c (mouse_get_pos): Likewise.
10210 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10211 * w32gui.h (Time): Define by including "systime.h" rather than by
10212 declaring it ourselves. (Bug#8664)
10213
d4e3e4d3
PE
10214 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10215 * image.c (clear_image_cache): Likewise.
10216
f6a24d19
PE
10217 * term.c (term_mouse_position): Don't assume time_t wraparound.
10218
08dc5ae6
PE
10219 Be more systematic about user-interface timestamps.
10220 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10221 and sometimes 'EMACS_UINT', to represent these timestamps.
10222 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10223 This makes the code easier to follow, and makes it easier to catch
10224 integer overflow bugs such as Bug#8664.
10225 * frame.c (Fmouse_position, Fmouse_pixel_position):
10226 Use Time, not unsigned long, for user-interface timestamps.
10227 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10228 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10229 * keyboard.h (last_event_timestamp): Likewise.
10230 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10231 * menu.h (xmenu_show): Likewise.
10232 * term.c (term_mouse_position): Likewise.
10233 * termhooks.h (struct input_event.timestamp): Likewise.
10234 (struct terminal.mouse_position_hook): Likewise.
10235 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10236 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10237 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10238 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10239 what it was before.
10240 * menu.h, termhooks.h: Include "systime.h", for Time.
10241
8e55734a
PE
10242 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10243 Don't assume that the difference between two unsigned long values
10244 can fit into an integer. At this point, we know button_down_time
10245 <= event->timestamp, so the difference must be nonnegative, so
10246 there's no need to cast the result if double-click-time is
10247 nonnegative, as it should be; check that it's nonnegative, just in
10248 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10249 apart (about 25 days). (Bug#8664)
8e55734a 10250
841f1b75 10251 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10252 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10253
3e26f69c
PE
10254 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10255 that always fit in int. Use a sentinel instead of a counter, to
10256 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10257 * frame.h (struct frame): Use int for menu_bar_items_used
10258 instead of EMACS_INT, since it always fits in int.
3e26f69c 10259
5cc152c0
PE
10260 * menu.c (grow_menu_items): Check for int overflow.
10261
d89eb65e
PE
10262 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10263
5235bd3e
PE
10264 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10265 Before, the code was not consistent. These values cannot exceed
10266 2**31 - 1 so there's no need to make them unsigned.
10267 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10268 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10269 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10270 as modifiers.
10271 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10272
bc827e23
PE
10273 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10274 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10275 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10276 presumably because the widths might not match.
10277
78eb494e
PE
10278 * window.c (size_window): Avoid needless test at loop start.
10279
04f2d78b
CB
102802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10281
10282 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10283
d2fc7e3d 102842011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10285
10286 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10287
d2fc7e3d 102882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10289
10290 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10291 `width' to `bar_area_x' and `bar_area_width', respectively.
10292 (x_scroll_run): Take account of fringe background extension.
10293
04f2d78b
CB
10294 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10295 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10296 `bar_area_width', respectively.
10297 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10298 background extension.
10299
79b70037
GM
103002011-05-10 Jim Meyering <meyering@redhat.com>
10301
10302 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10303
2f142cc5
JB
103042011-05-10 Juanma Barranquero <lekktu@gmail.com>
10305
10306 * image.c (Finit_image_library): Return t for built-in image types,
10307 like pbm and xbm. (Bug#8640)
10308
57679c86
AS
103092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10310
10311 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10312
888c9e86
EZ
103132011-05-07 Eli Zaretskii <eliz@gnu.org>
10314
b0512a1d
EZ
10315 * w32console.c (Fset_screen_color): Doc fix.
10316 (Fget_screen_color): New function.
10317 (syms_of_ntterm): Defsubr it.
10318
7285dc67
EZ
10319 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10320 unlink the temporary file if Fcall_process didn't create it in the
10321 first place.
10322 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10323 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10324 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10325 cue to call_process_cleanup not to close that handle.
10326
4d3fcc8e
BK
103272011-05-07 Ben Key <bkey76@gmail.com>
10328
10329 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10330 one of two shell specific rules, either bootstrap-temacs-CMD or
10331 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10332 to the previous implementation of the bootstrap-temacs rule.
10333 The bootstrap-temacs-CMD rule is similar to the previous
10334 implementation of the bootstrap-temacs rule except that it
10335 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10336 variable.
10337
10338 These changes, along with some changes to nt/configure.bat,
10339 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10340 earlier fix to add support for --cflags and --ldflags options
10341 that include quotes so that it works whether make uses cmd or
10342 sh as the shell.
10343
b4289b64
MA
103442011-05-06 Michael Albinus <michael.albinus@gmx.de>
10345
10346 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10347 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10348 is a constant.
10349 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10350 a string. Handle both cases.
10351 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10352 (Fdbus_register_method): Use Qinvalid_function.
10353
af4c0e28
JB
103542011-05-06 Juanma Barranquero <lekktu@gmail.com>
10355
10356 * makefile.w32-in: Update dependencies.
10357 (LISP_H): Add inttypes.h and stdin.h.
10358 (PROCESS_H): Add unistd.h.
10359
c51453d9
EZ
103602011-05-06 Eli Zaretskii <eliz@gnu.org>
10361
10362 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10363 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10364
8ff0ac3c 103652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10366
4c4b566b
PE
10367 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10368
aab2b9b5
PE
10369 * term.c (vfatal): Remove stray call to va_end.
10370 It's not needed and the C Standard doesn't allow it here anyway.
10371
c378da0b
PE
10372 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10373 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10374
288b08c7
PE
10375 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10376 bytes.
10377
e3601888
PE
10378 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10379
db6c0e74
PE
10380 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10381
dd5963ea
PE
10382 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10383
88c9450f
PE
10384 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10385
2f9442b8
PE
10386 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10387
c032b5f8
PE
10388 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10389 * charset.c (Fdefine_charset_internal): Don't initialize
10390 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10391 32-bit int (Bug#8600).
a108c10b
PE
10392
10393 * lread.c (read_integer): Be more consistent with string-to-number.
10394 Use string_to_number to do the actual conversion; this avoids
10395 rounding errors and fixes some other screwups. Without this fix,
10396 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10397 (digit_to_number): Move earlier, for benefit of read_integer.
10398 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10399 not a digit in any supported base. (Bug#8602)
a108c10b 10400
ad5f9eea
PE
10401 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10402
aec1708a
PE
10403 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10404 to match comment at start of function. This also removes a
10405 GCC warning about overflow in a 32+64-bit port.
10406
47be4ab5
PE
10407 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10408
371cac43
PE
10409 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10410 Reported by Stefan Monnier in
10411 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10412 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10413 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10414
d01a7826
PE
10415 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10416 (EMACS_UINTPTR): Likewise, with uintptr_t.
10417
7fd47d5c
PE
10418 * lisp.h: Prefer 64-bit EMACS_INT if available.
10419 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10420 on 32-bit hosts that have 64-bit int, so that they can access
10421 large files.
122b0c86
PE
10422 However, temporarily disable this change unless the temporary
10423 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10424
8727937b
PE
10425 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10426
8ac068ac
PE
10427 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10428 This removes an assumption that EMACS_INT and long are the same
10429 width as pointers. The assumption is true for Emacs porting targets
10430 now, but we want to make other targets possible.
10431 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10432 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10433 In the rest of the code, change types of integers that hold casted
10434 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10435 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10436 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10437 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10438 No need to cast type when ORing.
10439 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10440 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10441 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10442 assume EMACS_INT is the same width as char *.
10443 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10444 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10445 Remove no-longer-needed casts.
10446 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10447 (xg_tool_bar_help_callback, xg_make_tool_item):
10448 Use EMACS_INTPTR to hold an integer
10449 that will be cast to void *; this can avoid a GCC warning
10450 if EMACS_INT is not the same width as void *.
10451 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10452 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10453 (current_message_1, set_message_1):
10454 Use a local to convert to proper width without a cast.
10455 * xmenu.c (dialog_selection_callback): Likewise.
10456
ede49d71
PE
10457 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10458 Also, don't assume VALBITS / RAND_BITS is less than 5,
10459 and don't rely on undefined behavior when shifting a 1 left into
10460 the sign bit.
10461 * lisp.h (get_random): Change signature to match.
10462
2f30ecd0
PE
10463 * lread.c (hash_string): Use size_t, not int, for hash computation.
10464 Normally we prefer signed values; but hashing is special, because
10465 it's better to use unsigned division on hash table sizes so that
10466 the remainder is nonnegative. Also, size_t is the natural width
10467 for hashing into memory. The previous code used 'int', which doesn't
10468 retain enough info to hash well into very large tables.
10469 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10470
2a866e7b
PE
10471 * dbusbind.c: Don't possibly lose pointer info when converting.
10472 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10473 Use XPNTR rather than XHASH, so that the high-order bits of
10474 the pointer aren't lost when converting through void *.
10475
51639eac
PE
10476 * eval.c (Fautoload): Don't double-shift a pointer.
10477
92394119
PE
10478 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10479
dbdb9a7c
JB
104802011-05-06 Juanma Barranquero <lekktu@gmail.com>
10481
10482 * gnutls.c (DEF_GNUTLS_FN):
10483 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10484
db7a0b4f
AS
104852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10486
10487 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10488 marker. (Bug#8610)
10489
cd394be1 104902011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10491
10492 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10493 New version that can reserve upto 2GB of heap space.
10494
f7ff1b0f 104952011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10496
10497 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10498
639c109b
TZ
104992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10500
10501 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10502 `gnutls_certificate_set_x509_key_file'.
10503
d2127135
JB
105042011-05-05 Juanma Barranquero <lekktu@gmail.com>
10505
10506 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10507 Update dependencies.
10508
e968f4f3
JB
105092011-05-04 Juanma Barranquero <lekktu@gmail.com>
10510
10511 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10512 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10513 Remove unused parameter `fildes'.
10514 * process.c (read_process_output, send_process): Don't pass it.
10515
84d358f0
JB
105162011-05-04 Juanma Barranquero <lekktu@gmail.com>
10517
10518 Fix previous change: the library cache is defined in w32.c.
10519 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10520 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10521
0898ca10
JB
105222011-05-04 Juanma Barranquero <lekktu@gmail.com>
10523
10524 Implement dynamic loading of GnuTLS on Windows.
10525
10526 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10527 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10528 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10529 Declare.
10530
10531 * gnutls.c (Qgnutls_dll): Define.
10532 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10533 (gnutls_*): Declare function pointers.
10534 (init_gnutls_functions): New function to initialize function pointers.
10535 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10536 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10537 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10538 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10539 (emacs_gnutls_write, emacs_gnutls_read)
10540 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10541 (Fgnutls_available_p): New function.
10542 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10543 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10544 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10545
10546 * image.c: Include w32.h.
10547 (Vimage_type_cache): Delete.
10548 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10549 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10550 (w32_delayed_load): Move to w32.c.
10551
10552 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10553
10554 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10555 (w32_delayed_load): Move from image.c. When loading a library, record
10556 its filename in the :loaded-from property of the library id.
10557 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10558 Initialize and staticpro them.
10559 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10560
10561 * process.c: Include lisp.h before w32.h, not after.
10562 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10563 instead of gnutls_record_check_pending.
10564
10565 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10566
ff4de4aa
TZ
105672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10568
10569 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10570 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10571 as passed in.
10572
abe95abb
JD
105732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10574
10575 * xterm.c (x_set_frame_alpha): Do not set property on anything
10576 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10577
e16e55d4
JB
105782011-05-02 Juanma Barranquero <lekktu@gmail.com>
10579
10580 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10581
bafcf6a5
JB
105822011-05-02 Juanma Barranquero <lekktu@gmail.com>
10583
10584 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10585 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10586 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10587 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10588 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10589 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10590 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10591 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10592 (Qgnutls_bootprop_callbacks_verify): Make static.
10593
e7a6747f
AS
105942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10595
19ed11ba
AS
10596 * callproc.c: Indentation fixup.
10597
e7a6747f 10598 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10599 (wait_for_termination, interruptible_wait_for_termination):
10600 Move after wait_for_termination_1.
e7a6747f 10601
1ef14cb4
LMI
106022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10603
10604 * sysdep.c (interruptible_wait_for_termination): New function
10605 which is like wait_for_termination, but allows keyboard
10606 interruptions.
10607
10608 * callproc.c (Fcall_process): Add (:file "file") as an option for
10609 the STDOUT buffer.
10610 (Fcall_process_region): Ditto.
10611
330d880c
EZ
106122011-04-30 Eli Zaretskii <eliz@gnu.org>
10613
8db90b73
EZ
10614 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10615 rather than `XVECTOR (FOO)->size'.
10616
330d880c
EZ
10617 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10618 inttypes.h, as a gnulib replacement is used if it not available in
10619 system headers.
10620
15cbd324
EZ
106212011-04-21 Eli Zaretskii <eliz@gnu.org>
10622
10623 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10624 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10625 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10626
10627 * coding.c (coding_alloc_by_realloc): Error out if destination
10628 will grow beyond MOST_POSITIVE_FIXNUM.
10629 (decode_coding_emacs_mule): Abort if there isn't enough place in
10630 charbuf for the composition carryover bytes. Reserve an extra
10631 space for up to 2 characters produced in a loop.
10632 (decode_coding_iso_2022): Abort if there isn't enough place in
10633 charbuf for the composition carryover bytes.
10634
106352011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10636
ae940cca
EZ
10637 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10638 aborting when %lld or %lll format is passed.
10639 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10640 %llo or %llx format is passed. (Bug#8545)
10641
03ab8921
EZ
10642 * window.c (window_scroll_line_based): Use a marker instead of
10643 simple variables to record original value of point. (Bug#7952)
10644
afda1437
EZ
10645 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10646 produced by %s or %c overflows available buffer space. (Bug#8545)
10647
f76dee0c
PE
106482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10649
10650 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10651 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10652
fdc5744d
JB
106532011-04-28 Juanma Barranquero <lekktu@gmail.com>
10654
10655 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10656
638f053a
JB
106572011-04-28 Juanma Barranquero <lekktu@gmail.com>
10658
10659 * keyboard.c (Qdelayed_warnings_hook): Define.
10660 (command_loop_1): Run `delayed-warnings-hook'
10661 if Vdelayed_warnings_list is non-nil.
10662 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10663 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10664
d178f871
EZ
106652011-04-28 Eli Zaretskii <eliz@gnu.org>
10666
10667 * doprnt.c (doprnt): Don't return value smaller than the buffer
10668 size if the message was truncated. (Bug#8545).
10669
b124fd93
JB
106702011-04-28 Juanma Barranquero <lekktu@gmail.com>
10671
10672 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10673 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10674
e810457d
PE
106752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10676
10677 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10678
ea51cceb
JB
106792011-04-27 Juanma Barranquero <lekktu@gmail.com>
10680
10681 * makefile.w32-in: Update dependencies.
10682
94dcfacf
EZ
106832011-04-27 Eli Zaretskii <eliz@gnu.org>
10684
10685 Improve `doprnt' and its usage. (Bug#8545)
10686 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10687 `format_end'. Remove support for %l as a conversion specifier.
10688 Don't use xrealloc. Improve diagnostics when the %l size modifier
10689 is used. Update the commentary.
10690
10691 * eval.c (verror): Simplify calculation of size_t.
10692
10693 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10694 messages.
10695
f61f41d7
PE
106962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10697
10698 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10699 change.
10700
96fb4434
PE
107012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10702
10703 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10704 This makes this file independent of the recent pseudovector change.
10705
671875da 107062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10707
69e9b5a3
PE
10708 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10709
b5f869a7 10710 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10711 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10712 Remove unused local.
c8926152 10713 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10714
841a1577 10715 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10716 GCC 4.6.0 optimizes based on type-based alias analysis.
10717 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10718 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10719 != &v->size, and therefore "v->size = 1; b->size = 2; return
10720 v->size;" must therefore return 1. This assumption is incorrect
10721 for Emacs, since it type-puns struct Lisp_Vector * with many other
10722 types. To fix this problem, this patch adds a new type struct
f904488f 10723 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10724 and pseudovectors, and helps optimizing compilers not get fooled
10725 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10726 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10727 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10728 the size member.
eab3844f
PE
10729 (XSETPVECTYPE): Rewrite in terms of new macro.
10730 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10731 This is a bit clearer, and further avoids the possibility of
10732 undesirable aliasing.
10733 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10734 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10735 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10736 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10737 (ASIZE): Now uses header.size rather than size.
10738 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10739 to avoid the hassle of writing XVECTOR (foo)->header.size.
10740 (struct vectorlike_header): New type.
eab3844f
PE
10741 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10742 object, to help avoid aliasing.
10743 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10744 (SUBRP): Likewise, since Lisp_Subr is a special case.
10745 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10746 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10747 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10748 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10749 changed to be "header.size" and "header.next".
10750 * buffer.h (struct buffer): Likewise.
10751 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10752 * frame.h (struct frame): Likewise.
10753 * process.h (struct Lisp_Process): Likewise.
10754 * termhooks.h (struct terminal): Likewise.
10755 * window.c (struct save_window_data, struct saved_window): Likewise.
10756 * window.h (struct window): Likewise.
10757 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10758 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10759 * buffer.c (init_buffer_once): Likewise.
10760 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10761 special case.
10762 * process.c (Fformat_network_address): Use local var for size,
10763 for brevity.
10764
0df1eac5
PE
10765 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10766
847ab9d1 10767 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10768 * data.c (atof): Remove decl; no longer used or needed.
10769 (digit_to_number): Move to lread.c.
10770 (Fstring_to_number): Use new string_to_number function, to be
10771 consistent with how the Lisp reader treats infinities and NaNs.
10772 Do not assume that floating-point numbers represent EMACS_INT
10773 without losing information; this is not true on most 64-bit hosts.
10774 Avoid double-rounding errors, by insisting on integers when
10775 parsing non-base-10 numbers, as the documentation specifies.
10776 * lisp.h (string_to_number): New decl, replacing ...
10777 (isfloat_string): Remove.
bc0a5c13 10778 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10779 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10780 appears to have been a coding error. Similarly, do not accept
10781 strings like +-1e0 as floating point numbers. Do not report
10782 overflow for integer overflows unless the base is not 10 which
10783 means we have no simple and reliable way to continue.
10784 Break out the floating-point parsing into a new
10785 function string_to_number, so that Fstring_to_number parses
10786 floating point numbers consistently with the Lisp reader.
04f2d78b 10787 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10788 (E_CHAR, EXP_INT): Remove, replacing with ...
10789 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10790 (string_to_number): New function, replacing isfloat_string.
10791 This function checks for valid syntax and produces the resulting
10792 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10793 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10794 so that overflow for non-base-10 numbers is reported only when
10795 there's no portable and simple way to convert to floating point.
452f4150 10796
67769ffc
PE
10797 * textprop.c (set_text_properties_1): Rewrite for clarity,
10798 and to avoid GCC warning about integer overflow.
10799
c20db43f
PE
10800 * intervals.h (struct interval): Use EMACS_INT for members
10801 where EMACS_UINT might cause problems. See
10802 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10803 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10804 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10805 All uses changed.
37aa2f85
PE
10806 (offset_intervals): Tell GCC not to worry about length overflow
10807 when negating a negative length.
c20db43f 10808
2538aa2f
PE
10809 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10810 (overrun_check_free): Likewise.
10811
f2d3008d
PE
10812 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10813 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10814 word size.
10815
ec8df744
PE
10816 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10817 (gnutls_make_error): Rename local to avoid shadowing.
10818 (gnutls_emacs_global_deinit): ifdef out; not used.
10819 (Fgnutls_boot): Use const for pointer to readonly storage.
10820 Comment out unused local. Fix pointer signedness problems.
10821
640ee02d
PE
10822 * lread.c (openp): Don't stuff size_t into an 'int'.
10823 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10824 about possible signed overflow.
10825
6048fb2a
PE
10826 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10827 (GDK_KEY_g): Don't define if already defined.
10828 (xg_prepare_tooltip): Avoid pointer signedness problem.
10829 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10830
fa3c87e1
PE
10831 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10832 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10833
2172544b
PE
10834 * xfns.c (Fx_window_property): Simplify a bit,
10835 to make a bit faster and to avoid GCC 4.6.0 warning.
10836 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10837
9b821a21
PE
10838 * fns.c (internal_equal): Don't assume size_t fits in int.
10839
3c616cfa
PE
10840 * alloc.c (compact_small_strings): Tighten assertion a little.
10841
c2982e87
PE
10842 Replace pEd with more-general pI, and fix some printf arg casts.
10843 * lisp.h (pI): New macro, generalizing old pEd macro to other
10844 conversion specifiers. For example, use "...%"pI"d..." rather
10845 than "...%"pEd"...".
10846 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10847 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10848 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10849 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10850 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10851 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10852 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10853 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10854 64-bit hosts.
10855 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10856 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10857 * print.c (safe_debug_print, print_object): Likewise.
10858 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10859 to int.
6f04d126
PE
10860 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10861 avoiding the 0 flag, which is not portable.
c2982e87
PE
10862 * process.c (Fmake_network_process): Use pI to avoid cast.
10863 * region-cache.c (pp_cache): Likewise.
10864 * xdisp.c (decode_mode_spec): Likewise.
10865 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10866 behavior on 64-bit hosts with printf arg.
6f04d126 10867 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10868 (x_stop_queuing_selection_requests): Likewise.
10869 (x_get_window_property): Don't truncate byte count to an 'int'
10870 when tracing.
0b432f21 10871
5e073ec7
PE
10872 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10873 here, since it parses constructs like leading '-' and spaces,
10874 which are not wanted; and it overflows with large numbers.
10875 Instead, simply match F[0-9]+, which is what is wanted anyway.
10876
36372bf9
PE
10877 * alloc.c: Remove unportable assumptions about struct layout.
10878 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10879 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10880 (allocate_vectorlike, make_pure_vector): Use the new macros,
10881 plus offsetof, to remove unportable assumptions about struct layout.
10882 These assumptions hold on all porting targets that I know of, but
10883 they are not guaranteed, they're easy to remove, and removing them
10884 makes further changes easier.
10885
0b432f21
PE
10886 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10887 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10888 (string_overrun_cookie): Now const. Use initializers that
10889 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10890 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10891 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10892 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10893 multiple of sizeof (EMACS_INT); it need not be, if
10894 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10895 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10896
895009e1
JB
108972011-04-26 Juanma Barranquero <lekktu@gmail.com>
10898
10899 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10900
6a7a1b0b
TZ
109012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10902
10903 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10904 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10905 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10906
841a1577 109072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10908
10909 * lisp.h (Qdebug): List symbol.
895009e1 10910 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10911 * keyboard.c (debug-on-event): New variable.
10912 (handle_user_signal): Break into debugger when debug-on-event
10913 matches the current signal symbol.
10914
f2d3ba6f
DN
109152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10916
10917 * alloc.c (check_sblock, check_string_bytes)
10918 (check_string_free_list): Convert to standard C.
10919
42ce4c63
TZ
109202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10921
10922 * w32.c (emacs_gnutls_push): Fix typo.
10923
825cd63c
EZ
109242011-04-25 Eli Zaretskii <eliz@gnu.org>
10925
fb11d64d
EZ
10926 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10927 "cast to pointer from integer of different size".
10928
825cd63c
EZ
10929 Improve doprnt and its use in verror. (Bug#8545)
10930 * doprnt.c (doprnt): Document the set of format control sequences
10931 supported by the function. Use SAFE_ALLOCA instead of always
10932 using `alloca'.
10933
10934 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10935 is one byte too soon. Don't use xrealloc; instead xfree and
10936 xmalloc anew.
10937
e061a11b
TZ
109382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10939
10940 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10941 callbacks stage.
10942
10943 * gnutls.c: Renamed global_initialized to
10944 gnutls_global_initialized. Added internals for the
10945 :verify-hostname-error, :verify-error, and :verify-flags
10946 parameters of `gnutls-boot' and documented those parameters in the
10947 docstring. Start callback support.
9173deec
JB
10948 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10949 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10950 on error. Return error code.
e061a11b
TZ
10951 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10952 (emacs_gnutls_read): Likewise.
10953 (Fgnutls_boot): Return handshake error code.
10954 (emacs_gnutls_handle_error): New function.
10955 (wsaerror_to_errno): Likewise.
10956
10957 * w32.h (emacs_gnutls_pull): Add prototype.
10958 (emacs_gnutls_push): Likewise.
10959
10960 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10961 (emacs_gnutls_push): Likewise.
10962
109632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10964
10965 * process.c (wait_reading_process_output): Check if GnuTLS
10966 buffered some data internally if no FDs are set for TLS
10967 connections.
10968
10969 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10970 (LIBS): Link to USER_LIBS.
10971 ($(BLD)/gnutls.$(0)): New target.
10972
fa6996bc
EZ
109732011-04-24 Eli Zaretskii <eliz@gnu.org>
10974
eb35682e
EZ
10975 * xdisp.c (handle_single_display_spec): Rename the
10976 display_replaced_before_p argument into display_replaced_p, to
10977 make it consistent with the commentary. Fix typos in the
10978 commentary.
10979
e2ad650c
EZ
10980 * textprop.c (syms_of_textprop): Remove dead code.
10981 (copy_text_properties): Delete obsolete commentary about an
10982 interface that was deleted long ago. Fix typos in the description
10983 of arguments.
10984
1b2de274
EZ
10985 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10986 to changes in oldXMenu/XMenu.h from 2011-04-16.
10987 <menu_help_message, prev_menu_help_message>: Constify.
10988 (IT_menu_make_room): menu->help_text is now `const char **';
10989 adjust.
10990
10991 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10992 to changes in oldXMenu/XMenu.h from 2011-04-16.
10993 (struct XMenu): Declare `help_text' `const char **'.
10994
10995 * xfaces.c <Qunspecified>: Make extern again.
10996
10997 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10998 required by POSIX.
1b2de274 10999
762b15be
EZ
11000 * doc.c (get_doc_string): Improve the format passed to `error'.
11001
11002 * doprnt.c (doprnt): Improve commentary.
11003
11004 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11005
11006 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11007 them with etags.
11008
f1052e5d
EZ
11009 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11010 changes in globals.h immediately force recompilation.
762b15be
EZ
11011 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11012 $(CURDIR)/s/ms-w32.h.
11013 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11014
fa6996bc
EZ
11015 * character.c (Fchar_direction): Function deleted.
11016 (syms_of_character): Don't defsubr it.
11017 <char-direction-table>: Deleted.
11018
e6c3da20
EZ
110192011-04-23 Eli Zaretskii <eliz@gnu.org>
11020
11021 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11022 * doprnt.c: Include limits.h.
11023 (SIZE_MAX): New macro.
04f2d78b
CB
11024 (doprnt): Return a size_t value. 2nd arg is now size_t.
11025 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11026 Improve overflow protection. Support `l' modifier for integer
11027 conversions. Support %l conversion. Don't assume an EMACS_INT
11028 argument for integer conversions and for %c.
11029
11030 * lisp.h (doprnt): Restore prototype.
11031
11032 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11033 $(SRC)/character.h.
11034
11035 * Makefile.in (base_obj): Add back doprnt.o.
11036
11037 * deps.mk (doprnt.o): Add back prerequisites.
11038 (callint.o): Depend on character.h.
11039
11040 * eval.c (internal_lisp_condition_case): Include the handler
11041 representation in the error message.
11042 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11043 when breaking from the loop.
11044
11045 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11046
11047 * callint.c (Fcall_interactively): When displaying error message
11048 about invalid control letter, pass the character's codepoint, not
11049 a pointer to its multibyte form. Improve display of the character
11050 in octal and display also its hex code.
11051
11052 * character.c (char_string): Use %x to display the (unsigned)
11053 codepoint of an invalid character, to avoid displaying a bogus
11054 negative value.
11055
11056 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11057 `error', not SYMBOL_NAME itself.
11058
11059 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11060 character arguments to `error'.
11061
11062 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11063 to `error' in error message about FINAL_CHAR argument. Make sure
11064 FINAL_CHAR is a character, and use %c when it is passed as
11065 argument to `error'.
11066
4ffd0d6b 110672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11068
11069 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11070
11071 * w32.c: Include <time.h>.
11072 (sys_localtime): New function.
11073
4ffd0d6b 110742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11075
11076 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11077
4ffd0d6b 11078 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11079
4ffd0d6b 110802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11081
4ffd0d6b
GM
11082 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11083 zombies (Bug#8467).
aac0c6e3 11084
04c56954
EZ
110852011-04-19 Eli Zaretskii <eliz@gnu.org>
11086
11087 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11088 gl_state.e_property when gl_state.object is Qt.
11089
11090 * insdel.c (make_gap_larger): Remove limitation of buffer size
11091 to <= INT_MAX.
11092
16a43933
CY
110932011-04-18 Chong Yidong <cyd@stupidchicken.com>
11094
11095 * xdisp.c (lookup_glyphless_char_display)
11096 (produce_glyphless_glyph): Handle cons cell entry in
11097 glyphless-char-display.
11098 (Vglyphless_char_display): Document it.
11099
11100 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11101 glyphless-char-display.
11102
4581706e
CY
111032011-04-17 Chong Yidong <cyd@stupidchicken.com>
11104
11105 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11106
11107 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11108
11109 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11110 definition for no-X builds.
11111
4887c6e2 111122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11113
fd35b6f9
PE
11114 Static checks with GCC 4.6.0 and non-default toolkits.
11115
5c1ccb01
PE
11116 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11117
006c5daa
PE
11118 * process.c (keyboard_bit_set): Define only if SIGIO.
11119 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11120 (send_process): Repair possible setjmp clobbering.
11121
efc736d3
PE
11122 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11123
4e2fe2e6
PE
11124 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11125
f97334a2
PE
11126 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11127
4e75f29d
PE
11128 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11129 Define only if needed.
11130
90efadd1
PE
11131 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11132 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11133 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11134
3c647824
PE
11135 * dispextern.h (struct redisplay_interface): Rename param
11136 to avoid shadowing.
e264f262 11137 * termhooks.h (struct terminal): Likewise.
761383f4 11138 * xterm.c (xembed_send_message): Likewise.
3c647824 11139
b58c5c4a
PE
11140 * insdel.c (make_gap_smaller): Define only if
11141 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11142
cad59032
PE
11143 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11144 it.
11145
c339dc2e
PE
11146 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11147 so that we aren't warned about unused symbols.
11148
91a3e27b
PE
11149 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11150
399c71d3 11151 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11152
8ffc96f5
PE
11153 * xfns.c (x_real_positions): Mark locals as initialized.
11154
eef9bc79
PE
11155 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11156
098db9dd
PE
11157 * xterm.c: Fix problems found by static analysis with other toolkits.
11158 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11159 (x_dispatch_event): Declare static if USE_GTK, and
11160 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11161 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11162 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11163 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11164 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11165
eb18f6cc
PE
11166 * xmenu.c (menu_help_callback): Pointer type fixes.
11167 Use const pointers when pointing at readonly data. Avoid pointer
11168 signedness clashes.
11169 (FALSE): Remove unused macro.
11170 (update_frame_menubar): Remove unused decl.
11171
1fe72bf8
PE
11172 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11173
60d9e1db
PE
11174 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11175 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11176 (single_menu_item): Rename local to avoid shadowing.
11177
39261c26
PE
11178 * keyboard.c (make_lispy_event): Remove unused local var.
11179
018c5e19
PE
11180 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11181 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11182
63d2b86e
PE
11183 * bitmaps: Change bitmaps from unsigned char back to the X11
11184 compatible char. Avoid the old compiler warnings about
11185 out-of-range initializers by using, for example, '\xab' rather
11186 than 0xab.
11187
aefd87e1
PE
11188 * xgselect.c (xgselect_initialize): Check vs interface
11189 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11190
bf501fb9
PE
11191 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11192
e9829fdf
PE
11193 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11194 to read-only memory.
11195
1086c095
PE
11196 * fns.c (vector): Remove; this old hack is no longer needed.
11197
2baccd04 11198 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11199 Remove unused var.
dde42981 11200 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11201
72391843 11202 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11203
436c16df 11204 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11205 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11206 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11207
92bb796d 11208 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11209 (x_term_init): Remove local to avoid shadowing.
92bb796d 11210
764430a3 11211 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11212
11213 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11214 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11215
d1dfb56c
EZ
112162011-04-16 Eli Zaretskii <eliz@gnu.org>
11217
c4354cb4
EZ
11218 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11219
d1dfb56c
EZ
11220 Fix regex.c, syntax.c and friends for buffers > 2GB.
11221 * syntax.h (struct gl_state_s): Declare character position members
11222 EMACS_INT.
11223
11224 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11225
04f2d78b
CB
11226 * textprop.c (verify_interval_modification, interval_of):
11227 Declare arguments EMACS_INT.
d1dfb56c
EZ
11228
11229 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11230 EMACS_INT.
11231
11232 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11233
11234 * indent.c (Fvertical_motion): Local variable it_start is now
11235 EMACS_INT.
11236
11237 * regex.c (re_match, re_match_2, re_match_2_internal)
11238 (bcmp_translate, regcomp, regexec, print_double_string)
11239 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11240 (re_compile_pattern, re_exec): Declare arguments and local
11241 variables `size_t' and `ssize_t' and return values `regoff_t', as
11242 appropriate.
11243 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11244 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11245 <compile_stack_type>: `size' and `avail' are now `size_t'.
11246
11247 * regex.h <regoff_t>: Use ssize_t, not int.
11248 (re_search, re_search_2, re_match, re_match_2): Arguments that
11249 specify buffer/string position and length are now ssize_t and
11250 size_t. Return type is regoff_t.
11251
613052cd
BK
112522011-04-16 Ben Key <bkey76@gmail.com>
11253
11254 * nsfont.m: Fixed bugs in ns_get_family and
11255 ns_descriptor_to_entity that were caused by using free to
11256 deallocate memory blocks that were allocated by xmalloc (via
11257 xstrdup). This caused Emacs to crash when compiled with
11258 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11259 --enable-checking=xmallocoverrun). xfree is now used to
11260 deallocate these memory blocks.
11261
4170f62f 112622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11263
71b41406
PE
11264 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11265
9587a89d
PE
11266 emacs_write: Accept and return EMACS_INT for sizes.
11267 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11268 et seq.
11269 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11270 Accept and return EMACS_INT.
11271 (emacs_gnutls_write): Return the number of bytes written on
11272 partial writes.
11273 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11274 (emacs_read, emacs_write): Remove check for negative size, as the
11275 Emacs source code has been audited now.
9587a89d
PE
11276 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11277 (emacs_read, emacs_write): Use it.
273a5f82
PE
11278 * process.c (send_process): Adjust to the new signatures of
11279 emacs_write and emacs_gnutls_write. Do not attempt to store
11280 a byte offset into an 'int'; it might overflow.
9587a89d 11281 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11282
3e047f51
PE
11283 * sound.c: Don't assume sizes fit in 'int'.
11284 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11285 Return EMACS_INT, not int.
3e047f51 11286 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11287 Accept EMACS_INT, not int.
11288 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11289 record read return values.
11290
cc39a9db
BK
112912011-04-15 Ben Key <bkey76@gmail.com>
11292
c9d0ec6d
JB
11293 * keyboard.c (Qundefined): Don't declare static since it is used
11294 in nsfns.m.
11295 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11296 static since they are used in nsfont.m.
cc39a9db 11297
6c60eb9f
SM
112982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11299
11300 * process.c (Qprocessp): Don't declare static.
11301 * lisp.h (Qprocessp): Declare again.
11302
7990b61a
JB
113032011-04-15 Juanma Barranquero <lekktu@gmail.com>
11304
11305 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11306
5d4cb038
PE
113072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11308
8bd7b830 11309 Improve C-level modularity by making more things 'static'.
cd64ea1d 11310
e3b27b31
PE
11311 Don't publish debugger-only interfaces to other modules.
11312 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11313 (verify_bytepos, count_markers): Move decls to the only modules
11314 that need them.
11315 * region-cache.h (pp_cache): Likewise.
11316 * window.h (check_all_windows): Likewise.
11317 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11318
5d4cb038
PE
11319 * sysdep.c (croak): Now static, if
11320 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11321 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11322
11323 * alloc.c (refill_memory_reserve): Now static if
11324 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11325 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11326
e87b6180
PE
11327 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11328 Define only if USE_LUCID.
11329
ac64929e
PE
11330 * xrdb.c (x_customization_string, x_rm_string): Now static.
11331
6f37259d
PE
11332 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11333 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11334
1683e3ab
PE
11335 * xdisp.c (draw_row_with_mouse_face): Now static.
11336 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11337
de9c2632
PE
11338 * window.h (check_all_windows): Mark externally visible.
11339
2b96acb7
PE
11340 * window.c (window_deletion_count): Now static.
11341
11342 * undo.c: Make symbols static if they're not exported.
11343 (last_undo_buffer, last_boundary_position, pending_boundary):
11344 Now static.
11345
50436f33
PE
11346 * textprop.c (interval_insert_behind_hooks): Now static.
11347 (interval_insert_in_front_hooks): Likewise.
11348
64520e5c
PE
11349 * term.c: Make symbols static if they're not exported.
11350 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11351 (max_frame_lines, tty_set_terminal_modes):
11352 (tty_reset_terminal_modes, tty_turn_off_highlight):
11353 (get_tty_terminal): Now static.
11354 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11355 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11356 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11357 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11358 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11359
1fa53021
PE
11360 * sysdep.c: Make symbols static if they're not exported.
11361 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11362 Now static.
11363 (sigprocmask_set, full_mask): Remove; unused.
11364 (wait_debugging): Mark as visible.
11365 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11366 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11367
d4b43b22
PE
11368 * syntax.c (syntax_temp): Define only if !__GNUC__.
11369
b7c513d0
PE
11370 * sound.c (current_sound_device, current_sound): Now static.
11371
989b29ad
PE
11372 * search.c (searchbufs, searchbuf_head): Now static.
11373
13a55a78
PE
11374 * scroll.c (scroll_cost): Remove; unused.
11375 * dispextern.h (scroll_cost): Remove decl.
11376
de68a1fc
PE
11377 * region-cache.h (pp_cache): Mark as externally visible.
11378
40ccffa6
PE
11379 * process.c: Make symbols static if they're not exported.
11380 (process_tick, update_tick, create_process, chan_process):
11381 (Vprocess_alist, proc_buffered_char, datagram_access):
11382 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11383 (deactivate_process): Mark defn as static, as well as decl.
11384 * lisp.h (create_process): Remove decl.
11385 * process.h (chan_process, Vprocess_alist): Remove decls.
11386
ad64fc97
PE
11387 * print.c: Make symbols static if they're not exported.
11388 (print_depth, new_backquote_output, being_printed, print_buffer):
11389 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11390 (print_interval, print_number_index, initial_stderr_stream):
11391 Now static.
11392 * lisp.h (Fprinc): Remove decl.
11393 (debug_output_compilation_hack): Mark as externally visible.
11394
adddb265
PE
11395 * sysdep.c (croak): Move decl from here to syssignal.h.
11396 * syssignal.h (croak): Put it here, so the API can be checked when
11397 'croak' is called from dissociate_if_controlling_tty.
11398
1717ede2
PE
11399 * minibuf.c: Make symbols static if they're not exported.
11400 (minibuf_save_list, choose_minibuf_frame): Now static.
11401 * lisp.h (choose_minibuf_frame): Remove decl.
11402
fa5fb2bc
PE
11403 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11404
1e3890d1
PE
11405 * lread.c: Make symbols static if they're not exported.
11406 (read_objects, initial_obarray, oblookup_last_bucket_number):
11407 Now static.
11408 (make_symbol): Remove; unused.
11409 * lisp.h (initial_obarray, make_symbol): Remove decls.
11410
8a1414fa
PE
11411 * keyboard.c: Make symbols static if they're not exported.
11412 (single_kboard, recent_keys_index, total_keys, recent_keys):
11413 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11414 (this_single_command_key_start, echoing, last_auto_save):
11415 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11416 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11417 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11418 (Vlispy_mouse_stem, double_click_count):
11419 Now static.
11420 (force_auto_save_soon): Define only if SIGDANGER.
11421 (ignore_mouse_drag_p): Now static if
11422 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11423 (print_help): Remove; unused.
11424 (stop_character, last_timer_event): Mark as externally visible.
11425 * keyboard.h (ignore_mouse_drag_p): Declare only if
11426 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11427 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11428 * lisp.h (echoing): Remove decl.
11429 (force_auto_save_soon): Declare only if SIGDANGER.
11430 * xdisp.c (redisplay_window): Simplify code, to make it more
11431 obvious that ignore_mouse_drag_p is not accessed if !defined
11432 USE_GTK && !defined HAVE_NS.
11433
93ea6e8f
PE
11434 * intervals.c: Make symbols static if they're not exported.
11435 (merge_properties_sticky, merge_interval_right, delete_interval):
11436 Now static.
11437 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11438
77382fcc
PE
11439 * insdel.c: Make symbols static if they're not exported.
11440 However, leave prepare_to_modify_buffer alone. It's never
11441 called from outside this function, but that appears to be a bug.
11442 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11443 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11444 (adjust_after_replace_noundo): Remove; unused.
11445 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11446 (signal_before_change): Remove decls.
77382fcc 11447
9306c32e
PE
11448 * indent.c (val_compute_motion, val_vmotion): Now static.
11449
cd44d2eb
PE
11450 * image.c: Make symbols static if they're not exported.
11451 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11452 if USE_GTK.
11453 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11454 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11455
ad9a7a06
PE
11456 * fringe.c (standard_bitmaps): Now static.
11457 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11458
81626931
PE
11459 * frame.c: Make symbols static if they're not exported.
11460 (x_report_frame_params, make_terminal_frame): Now static.
11461 (get_frame_param): Now static, unless HAVE_NS.
11462 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11463 (x_get_resource_string): Remove; not used.
11464 * frame.h (make_terminal_frame, x_report_frame_params):
11465 (x_get_resource_string); Remove decls.
11466 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11467 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11468
239f9db9
PE
11469 * font.c, fontset.c: Make symbols static if they're not exported.
11470 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11471 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11472 * font.c (font_close_object): Now static.
11473 * font.h (font_close_object): Remove.
11474 * fontset.c (FONTSET_OBJLIST): Remove.
11475 (free_realized_fontset) #if-0 the body, which does nothing.
11476 (face_suitable_for_char_p): #if-0, as it's never called.
11477 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11478 * xfaces.c (face_at_string_position):
11479 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11480 since 0 is always ASCII.
11481
dfcf3579
PE
11482 * fns.c (weak_hash_tables): Now static.
11483
5045092b
PE
11484 * fileio.c: Make symbols static if they're not exported.
11485 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11486 (Vwrite_region_annotation_buffers): Now static.
11487
57a96f5c
PE
11488 * eval.c: Make symbols static if they're not exported.
11489 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11490 * lisp.h (backtrace_list): Remove decl.
11491
35f08c38
PE
11492 * emacs.c: Make symbols static if they're not exported.
11493 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11494 (fatal_error_code, fatal_error_signal_hook, standard_args):
11495 Now static.
11496 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11497 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11498 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11499 * lisp.h (fatal_error_signal_hook): Remove decl.
11500 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11501
f44bd759
PE
11502 * editfns.c: Move a (normally-unused) function to its only use.
11503 * editfns.c, lisp.h (get_operating_system_release): Remove.
11504 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11505 worth the hassle of breaking this out.
11506
b532497d
PE
11507 * xterm.c: Make symbols static if they're not exported.
11508 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11509 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11510 (x_destroy_window, x_delete_display):
11511 Now static.
11512 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11513 (x_mouse_leave): Remove; unused.
11514 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11515 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11516 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11517 Remove decls.
11518 (x_mouse_leave): Declare only if WINDOWSNT.
11519 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11520 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11521 USE_X_TOOLKIT.
11522
1675728f
PE
11523 * ftxfont.c: Make symbols static if they're not exported.
11524 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11525 HAVE_FREETYPE.
11526 * font.h (ftxfont_driver): Likewise.
11527
e4cebfca
PE
11528 * xfns.c: Make symbols static if they're not exported.
11529 (x_last_font_name, x_display_info_for_name):
11530 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11531 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11532 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11533 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11534 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11535 (last_show_tip_args): Now static.
11536 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11537 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11538 (x_screen_planes): Remove; unused.
11539 * dispextern.h (x_screen_planes): Remove decl.
11540
5bf46f05
PE
11541 * dispnew.c: Make symbols static if they're not exported.
11542 * dispextern.h (redraw_garbaged_frames, scrolling):
11543 (increment_row_positions): Remove.
11544 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11545 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11546 Now static.
11547 (redraw_garbaged_frames): Remove; unused.
11548
435f4c28
PE
11549 * xfaces.c: Make symbols static if they're not exported.
11550 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11551 Remove decls.
11552 * xterm.h (defined_color): Remove decls.
11553 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11554 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11555 (menu_face_changed_default, defined_color, free_realized_face):
11556 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11557 (ascii_face_of_lisp_face): Remove; unused.
11558
8524aef3
PE
11559 * xdisp.c: Make symbols static if they're not exported.
11560 * dispextern.h (scratch_glyph_row, window_box_edges):
11561 (glyph_to_pixel_coords, set_cursor_from_row):
11562 (get_next_display_element, set_iterator_to_next):
11563 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11564 (show_mouse_face): Remove decls
11565 * frame.h (message_buf_print): Likewise.
11566 * lisp.h (pop_message, set_message, check_point_in_composition):
11567 Likewise.
11568 * xterm.h (set_vertical_scroll_bar): Likewise.
11569 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11570 (message_buf_print, scratch_glyph_row, displayed_buffer):
11571 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11572 (get_next_display_element, show_mouse_face, window_box_edges):
11573 (frame_to_window_pixel_xy, check_point_in_composition):
11574 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11575 (glyph_to_pixel_coords): Remove; unused.
11576
16390cd2
PE
11577 * dired.c (file_name_completion): Now static.
11578
11579 * dbusbind.c (xd_in_read_queued_messages): Now static.
11580
a25f4dfa
PE
11581 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11582 * data.c (circular_list_error): Remove.
11583
14a9c8df
PE
11584 * commands.h (last_point_position, last_point_position_buffer):
11585 (last_point_position_window): Remove decls.
11586 * keyboard.c: Make these variables static.
11587
04f2d78b
CB
11588 * coding.h (coding, code_convert_region, encode_coding_gap):
11589 Remove decls.
74ab6df5
PE
11590 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11591 (iso_code_class, detect_coding, code_convert_region): Now static.
11592 (encode_coding_gap): Remove; unused.
11593
38dfbee1
PE
11594 * chartab.c (chartab_chars, chartab_bits): Now static.
11595
a2cb4e63
PE
11596 * charset.h (charset_iso_8859_1): Remove decl.
11597 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11598 Now static.
11599
127198fd
PE
11600 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11601 * ccl.c (Vccl_program_table): Now static.
11602 (check_ccl_update): Remove; unused.
11603
d85b608f
PE
11604 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11605 * category.h: ... from here.
11606 * category.c (check_category_table, set_category_set): Now static.
11607
31cd66f3
PE
11608 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11609 * lisp.h: Remove these decls.
11610
c358e587
PE
11611 * buffer.c (buffer_count): Remove unused var.
11612
e78aecca
PE
11613 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11614 so that it's not optimized away.
11615 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11616 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11617 exported only to the debugger.
11618
e192d7d3 11619 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11620 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11621
92470028
PE
11622 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11623 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11624 was inaccessible from Lisp.
11625 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11626 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11627
244ed907
PE
11628 alloc.c: Import and export fewer symbols, and remove unused items.
11629 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11630 is defined.
11631 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11632 it's not optimized away by whole-program optimization.
11633 (message_enable_multibyte, free_misc): Remove.
11634 (catchlist, handlerlist, mark_backtrace):
11635 Declare only if BYTE_MARK_STACK.
11636 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11637 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11638 (message_enable_multibyte): Remove decl.
11639 (free_misc, interval_free_list, float_block, float_block_index):
11640 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11641 (cons_free_list, last_marked_index):
11642 Now static.
11643 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11644 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11645 (mark_backtrace): Define only if BYTE_MARK_STACK.
11646 * xdisp.c (message_enable_multibyte): Now static.
11647
61c2b50e 11648 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11649 This makes it easier for human readers (and static analyzers)
11650 to see whether these variables are used from other modules.
11651 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11652 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11653 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11654 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11655 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11656 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11657 * xmenu.c, xselect.c:
11658 Declare Q* vars static if they are not used in other modules.
11659 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11660 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11661 Remove decls of unexported vars.
11662 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11663
95c82688
PE
11664 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11665
16a97296
PE
11666 Make Emacs functions such as Fatom 'static' by default.
11667 This makes it easier for human readers (and static analyzers)
11668 to see whether these functions can be called from other modules.
11669 DEFUN now defines a static function. To make the function external
11670 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11671 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11672 (Finit_image_library):
16a97296
PE
11673 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11674 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11675 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11676 Remove decls, since these functions are now static.
11677 (Funintern, Fget_internal_run_time): New decls, since these functions
11678 were already external.
95c82688 11679
16a97296
PE
11680 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11681 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11682 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11683 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11684 * keyboard.c, keymap.c, lread.c:
11685 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11686 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11687 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11688 Mark functions with DEFUE instead of DEFUN,
11689 if they are used in other modules.
11690 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11691 decls for now-static functions.
11692 * buffer.h (Fdelete_overlay): Remove decl.
11693 * callproc.c (Fgetenv_internal): Mark as internal.
11694 * composite.c (Fremove_list_of_text_properties): Remove decl.
11695 (Fcomposition_get_gstring): New forward static decl.
11696 * composite.h (Fcomposite_get_gstring): Remove decl.
11697 * dired.c (Ffile_attributes): New forward static decl.
11698 * doc.c (Fdocumntation_property): New forward static decl.
11699 * eval.c (Ffetch_bytecode): New forward static decl.
11700 (Funintern): Remove extern decl; now in .h file where it belongs.
11701 * fileio.c (Fmake_symbolic_link): New forward static decl.
11702 * image.c (Finit_image_library): New forward static decl.
11703 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11704 * intervals.h (Fprevious_property_change):
11705 (Fremove_list_of_text_properties): Remove decls.
11706 * keyboard.c (Fthis_command_keys): Remove decl.
11707 (Fcommand_execute): New forward static decl.
11708 * keymap.c (Flookup_key): New forward static decl.
11709 (Fcopy_keymap): Now static.
11710 * keymap.h (Flookup_key): Remove decl.
11711 * process.c (Fget_process): New forward static decl.
11712 (Fprocess_datagram_address): Mark as internal.
11713 * syntax.c (Fsyntax_table_p): New forward static decl.
11714 (skip_chars): Remove duplicate decl.
11715 * textprop.c (Fprevious_property_change): New forward static decl.
11716 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11717 Now internal.
11718 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11719 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11720
785bbd42
PE
11721 * editfns.c (Fformat): Remove unreachable code.
11722
8b913b57
AS
117232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11724
11725 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11726 change. (Bug#8496)
11727
a6744a35
EZ
117282011-04-13 Eli Zaretskii <eliz@gnu.org>
11729
11730 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11731 when at ZV. (Bug#8487)
11732
e7974947
AS
117332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11734
baad03f0
AS
11735 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11736 (Bug#8437)
11737 * keyboard.c (parse_tool_bar_item): Likewise.
11738 * sound.c (sound_cleanup, alsa_close): Likewise.
11739 * termcap.c (tgetent): Likewise.
11740 * xfns.c (x_default_font_parameter): Likewise.
11741 * xsettings.c (read_and_apply_settings): Likewise.
11742
e7974947
AS
11743 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11744 (overrun_check_free): Protoize.
11745
28272684
PE
117462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11747
11748 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11749 since callers should never pass a negative size.
11750 Change the signature to match that of plain 'read' and 'write'; see
11751 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11752 * lisp.h: Update prototypes of emacs_write and emacs_read.
11753
11997c76
EZ
117542011-04-11 Eli Zaretskii <eliz@gnu.org>
11755
11756 * xdisp.c (redisplay_window): Don't try to determine the character
11757 position of the scroll margin if the window start point w->startp
e896f03c 11758 is outside the buffer's accessible region. (Bug#8468)
11997c76 11759
8a2cbd72
EZ
117602011-04-10 Eli Zaretskii <eliz@gnu.org>
11761
11762 Fix write-region and its subroutines for buffers > 2GB.
11763 * fileio.c (a_write, e_write): Modify declaration of arguments and
11764 local variables to support buffers larger than 2GB.
11765 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11766
11767 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11768 argument, local variables, and return value.
11769
11770 * lisp.h: Update prototypes of emacs_write and emacs_read.
11771
11772 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11773
4073e537 117742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11775
1ebfdcb6
PE
11776 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11777
b2ded58d
PE
11778 Fix more problems found by GCC 4.6.0's static checks.
11779
7d66342c
PE
11780 * xdisp.c (vmessage): Use a better test for character truncation.
11781
bbf47d44
PE
11782 * charset.c (load_charset_map): <, not <=, for optimization,
11783 and to avoid potential problems with integer overflow.
9248994d 11784 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11785 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11786 * editfns.c (Fformat): Likewise.
1e69125e 11787 * syntax.c (skip_chars): Likewise.
3befa583 11788
e3019616
PE
11789 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11790 This also lets GCC 4.6.0 generate slightly better loop code.
11791
becfa255
PE
11792 * callint.c (Fcall_interactively): <, not <=, for optimization.
11793 (Fcall_interactively): Count the number of arguments produced,
11794 not the number of arguments given. This is simpler and lets GCC
11795 4.6.0 generate slightly better code.
11796
dae0cd48
PE
11797 * ftfont.c: Distingish more carefully between FcChar8 and char.
11798 The previous code passed unsigned char * to a functions like
11799 strlen and xstrcasecmp that expect char *, which does not
11800 conform to the C standard.
11801 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11802 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11803 char * when the C standard requires it.
11804
76032d70
PE
11805 * keyboard.c (read_char): Remove unused var.
11806
eb3f1cc8
PE
11807 * eval.c: Port to Windows vsnprintf (Bug#8435).
11808 Include <limits.h>.
11809 (SIZE_MAX): Define if the headers do not.
11810 (verror): Do not give up if vsnprintf returns a negative count.
11811 Instead, grow the buffer. This ports to Windows vsnprintf, which
11812 does not conform to C99. Problem reported by Eli Zaretskii.
11813 Also, simplify the allocation scheme, by avoiding the need for
11814 calling realloc, and removing the ALLOCATED variable.
11815
70476b54
PE
11816 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11817
12020a9e
PE
11818 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11819 But keep the doprint source code for now, as we might revamp it
11820 and use it again (Bug#8435).
ea6c7ae6
PE
11821 * lisp.h (doprnt): Remove.
11822 * Makefile.in (base_obj): Remove doprnt.o.
11823 * deps.mk (doprnt.o): Remove.
11824
5fdb398c
PE
11825 error: Print 32- and 64-bit integers portably (Bug#8435).
11826 Without this change, on typical 64-bit hosts error ("...%d...", N)
11827 was used to print both 32- and 64-bit integers N, which relied on
11828 undefined behavior.
61bdb816 11829 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11830 * lisp.h (error, verror): Mark as printf-like functions.
11831 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11832 Report overflow in size calculations when allocating printf buffer.
11833 Do not truncate output string at its first null byte.
11834 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11835 Truncate the output at a character boundary, since vsnprintf does not
11836 do that.
11837 * charset.c (check_iso_charset_parameter): Convert internal
11838 character to string before calling 'error', since %c now has the
11839 printf meaning.
11840 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11841 overflow when computing char to be passed to 'error'. Do not
11842 pass Lisp_Object to 'error'; pass the integer instead.
11843 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11844 formatted with plain %d.
11845
b189fa66
PE
11846 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11847
bff87ef0
PE
11848 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11849
7e2cac20
PE
11850 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11851
ce4d90b5
PE
11852 * xterm.c (x_catch_errors): Remove duplicate declaration.
11853
266c9547
PE
11854 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11855
79c49ad2
PE
11856 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11857
368f4090
JM
118582011-04-10 Jim Meyering <meyering@redhat.com>
11859
11860 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11861 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11862 return ssize_t not "int", and use size_t as the buffer length.
11863 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11864 * gnutls.h: Update declarations.
11865 * process.c (read_process_output): Use ssize_t, to match.
11866 (send_process): Likewise.
11867
a32d4040
CY
118682011-04-09 Chong Yidong <cyd@stupidchicken.com>
11869
11870 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11871
8546720e 118722011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11873
04f2d78b
CB
11874 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11875 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11876
8546720e
GM
11877 * xterm.c (handle_one_xevent):
11878 * xmenu.c (create_and_show_popup_menu):
11879 * xselect.c (x_decline_selection_request)
11880 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11881
0a2f5c1a 118822011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11883
11884 Fix some uses of `int' instead of EMACS_INT.
11885 * search.c (string_match_1, fast_string_match)
11886 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11887 (scan_buffer, find_next_newline_no_quit)
11888 (find_before_next_newline, search_command, Freplace_match)
11889 (Fmatch_data): Make some `int' variables be EMACS_INT.
11890
11891 * xdisp.c (display_count_lines): 3rd argument and return value now
11892 EMACS_INT. All callers changed.
11893 (pint2hrstr): Last argument is now EMACS_INT.
11894
11895 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11896 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11897 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11898 (decode_coding_utf_16, decode_coding_emacs_mule)
11899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11900 (decode_coding_ccl, decode_coding_charset)
11901 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11902 (decode_coding_iso_2022, decode_coding_emacs_mule)
11903 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11904 <char_offset, last_offset>: Declare EMACS_INT.
11905 (encode_coding_utf_8, encode_coding_utf_16)
11906 (encode_coding_emacs_mule, encode_invocation_designation)
11907 (encode_designation_at_bol, encode_coding_iso_2022)
11908 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11909 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11910 Declare EMACS_INT.
11911 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11912 (encode_invocation_designation): Last argument P_NCHARS is now
11913 EMACS_INT.
11914 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11915 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11916
11917 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11918 All users changed.
11919
11920 * ccl.c (Fccl_execute_on_string): Declare some variables
11921 EMACS_INT.
11922
8546720e 119232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11924
11925 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11926
4e19a977
CS
119272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11928
11929 * process.c (Fformat_network_address): Doc fix.
11930
87302331
R
119312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11932
ee7683eb 11933 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11934
cbb59342
CY
119352011-04-08 Chong Yidong <cyd@stupidchicken.com>
11936
11937 * keyboard.c (read_char): Call Lisp function help-form-show,
11938 instead of using internal_with_output_to_temp_buffer.
11939 (Qhelp_form_show): New var.
e0d38eeb 11940 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11941
11942 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11943
11944 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11945
e67a13ab
CY
119462011-04-06 Chong Yidong <cyd@stupidchicken.com>
11947
04f2d78b
CB
11948 * process.c (Flist_processes): Remove to Lisp.
11949 (list_processes_1): Delete.
e67a13ab 11950
973f782d
EZ
119512011-04-06 Eli Zaretskii <eliz@gnu.org>
11952
7c106b1e
EZ
11953 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11954
973f782d
EZ
11955 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11956
41cf7d1a 119572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11958
ca23cc88
PE
11959 Fix more problems found by GCC 4.6.0's static checks.
11960
f390e2d5
PE
11961 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11962
42eea0d0
PE
11963 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11964
b69769da 11965 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11966
f9541e84
PE
11967 * xdisp.c (vmessage): Mark as a printf-like function.
11968
13841b55
PE
11969 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11970
c136c10f
PE
11971 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11972
5e2d4a30
PE
11973 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11974 printf-like functions.
11975 (tiff_load): Add casts to remove these marks before passing them
11976 to system-supplied API.
11977
583f48b9
PE
11978 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11979
b25d760e
PE
11980 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11981 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11982 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11983 directly, rather than having caller test rule sign. This avoids
11984 some unnecessary tests.
11985 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11986 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11987 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11988
bc7b6697 11989 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11990 (xfont_open): Avoid unnecessary tests.
bc7b6697 11991
27ccc379
PE
11992 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11993
dcd5c89a
PE
11994 * composite.h, composite.c (composition_gstring_put_cache):
11995 Use EMACS_INT, not int, for length.
11996
b13a45c6
PE
11997 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11998 breaking out part of COMPOSITION_DECODE_RULE.
11999 (COMPOSITION_DECODE_RULE): Use it.
12000 * composite.c (get_composition_id): Remove unused local vars,
12001 by using the new macro.
12002
1e792e4d
PE
12003 * textprop.c (set_text_properties_1): Change while to do-while,
12004 since the condition is always true at first.
12005
dc6c6455 12006 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12007 (interval_deletion_adjustment): Return unsigned value.
12008 All uses changed.
dc6c6455 12009
aba7731a
PE
12010 * process.c (list_processes_1, create_pty, read_process_output):
12011 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12012 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12013 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12014 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12015 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12016
fdfc4bf3
PE
12017 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12018
fca8fe46 12019 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12020 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12021
06a0259a 12022 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12023 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12024 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12025
e7b9e80f
PE
12026 * print.c (print_error_message): Avoid int overflow.
12027
56201685
PE
12028 * font.c (font_list_entities): Redo for clarity,
12029 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12030
78834453 12031 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12032 (font_score): Avoid potential overflow in diff calculation.
78834453 12033
0bc0b309 12034 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12035 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12036
e610eaca
PE
12037 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12038
b895abce
PE
12039 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12040 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12041 can always succeed if overflow has undefined behavior.
12042
1f1d9321 12043 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12044 (wordify): Omit three unnecessary tests.
1f1d9321 12045
c59478bc
PE
12046 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12047 All callers changed. This avoids the need for an unused var.
12048
79b73827
PE
12049 * casefiddle.c (casify_region): Remove var that is set but not used.
12050
a4db5dfe
PE
12051 * dired.c (file_name_completion): Remove var that is set but not used.
12052
43aae36e
PE
12053 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12054
2a47c44d 12055 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12056 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12057
a37c69bf
PE
12058 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12059 Check for integer overflow on size calculations.
12060
328ab8e7
PE
12061 * buffer.c (Fprevious_overlay_change): Remove var that is set
12062 but not used.
12063
e5a2a5cb
PE
12064 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12065 Remove vars that are set but not used.
8d84a6eb 12066 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12067 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12068
a60e5f68
PE
12069 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12070
f661cb61 12071 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12072 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12073
f0397f5a
PE
12074 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12075 that are set but not used.
12076
8664db06 12077 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12078 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12079
6abdaa4a
PE
12080 * xselect.c (x_get_local_selection, x_handle_property_notify):
12081 Remove vars that are set but not used.
12082
0ce7538d 12083 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12084 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12085
9ae848fc
PE
12086 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12087 Remove var that is set but not used.
0b918413
PE
12088 (scroll_bar_windows_size): Now size_t, not int.
12089 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12090 Check for overflow.
9ae848fc 12091
a5a62657
PE
12092 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12093 (map_tty_color) [!defined MSDOS]: Likewise.
12094
5c5cdd39
PE
12095 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12096
66ebf983
PE
12097 * coding.c: Remove vars that are set but not used.
12098 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12099 All callers changed.
12100 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12101 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12102 (decode_coding_charset): Remove vars that are set but not used.
12103
1be4d761
PE
12104 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12105 that is set but not used.
12106
47553fa8
PE
12107 * print.c (print_object): Remove var that is set but not used.
12108
1f7196bf 12109 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12110 The gnulib version avoids calling malloc in the usual case,
12111 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12112 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12113 * filelock.c (current_lock_owner): Likewise.
12114 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12115 * sysdep.c: Include allocator.h, careadlinkat.h.
12116 (emacs_no_realloc_allocator): New static constant.
12117 (emacs_readlink): New function.
fdb61804
PE
12118 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12119 ../lib/careadlinkat.h.
d1fdcab7 12120
f84c17c7
SM
121212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12122
12123 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12124 first non-nil return value).
12125
ef3862ad
JD
121262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12127
12128 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12129 if not defined (Bug#8403).
12130
376a7006
JB
121312011-04-02 Juanma Barranquero <lekktu@gmail.com>
12132
12133 * xdisp.c (display_count_lines): Remove parameter `start',
12134 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12135 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12136 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12137 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12138 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12139 and thereabouts. All callers changed.
12140 (get_per_char_metric): Remove parameter `f', unused since
12141 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12142
6ca3801d
JM
121432011-04-02 Jim Meyering <meyering@redhat.com>
12144
12145 do not dereference NULL upon failed strdup
12146 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12147 (ns_get_family): Likewise.
12148
d8e2b5ba
JB
121492011-04-02 Juanma Barranquero <lekktu@gmail.com>
12150
12151 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12152
8c74fcbd
JD
121532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12154
12155 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12156 later (Bug#8403).
12157
7200d79c
SM
121582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12159
03408648 12160 Add lexical binding.
7200d79c 12161
03408648
SM
12162 * window.c (Ftemp_output_buffer_show): New fun.
12163 (Fsave_window_excursion):
12164 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12165
12166 * lread.c (lisp_file_lexically_bound_p): New function.
12167 (Fload): Bind Qlexical_binding.
12168 (readevalloop): Remove `evalfun' arg.
12169 Bind Qinternal_interpreter_environment.
12170 (Feval_buffer): Bind Qlexical_binding.
12171 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12172 Mark as dynamic.
12173 (syms_of_lread): Declare `lexical-binding'.
12174
12175 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12176
12177 * keyboard.c (eval_dyn): New fun.
12178 (menu_item_eval_property): Use it.
ca105506
SM
12179
12180 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12181
03408648
SM
12182 * fns.c (concat, mapcar1): Accept byte-code-functions.
12183
12184 * eval.c (Fsetq): Handle lexical vars.
12185 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12186 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12187 (FletX, Flet): Obey lexical binding.
12188 (Fcommandp): Handle closures.
12189 (Feval): New `lexical' arg.
12190 (eval_sub): New function extracted from Feval. Use it almost
12191 everywhere where Feval was used. Look up vars in lexical env.
12192 Handle closures.
12193 (Ffunctionp): Move from subr.el.
12194 (Ffuncall): Handle closures.
12195 (apply_lambda): Remove `eval_flags'.
12196 (funcall_lambda): Handle closures and new byte-code-functions.
12197 (Fspecial_variable_p): New function.
12198 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12199 but without exporting it to Lisp.
23aba0ea 12200
23aba0ea 12201 * doc.c (Fdocumentation, store_function_docstring):
03408648 12202 * data.c (Finteractive_form): Handle closures.
23aba0ea 12203
03408648
SM
12204 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12205 interactive spec.
ba83908c 12206
04f2d78b
CB
12207 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12208 New byte-codes.
03408648
SM
12209 (exec_byte_code): New function extracted from Fbyte_code to handle new
12210 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12211
03408648 12212 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12213
03408648 12214 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12215
e2abce01
JB
122162011-03-31 Juanma Barranquero <lekktu@gmail.com>
12217
12218 * xdisp.c (redisplay_internal): Fix prototype.
12219
63696a73 122202011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12221
63696a73 12222 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12223 (try_scrolling): Use it when setting scroll_limit.
12224 Limit scrolling to 100 screen lines.
63696a73
EZ
12225 (redisplay_window): Even when falling back on "recentering",
12226 position point in the window according to scroll-conservatively,
12227 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12228
12229 (try_scrolling): When point is above the window, allow searching
12230 as far as scroll_max, or one screenful, to compute vertical
12231 distance from PT to the scroll margin position. This prevents
12232 try_scrolling from unnecessarily failing when
12233 scroll-conservatively is set to a value slightly larger than the
12234 window height. Clean up the case of PT below the margin at bottom
12235 of window: scroll_max can no longer be INT_MAX. When aggressive
12236 scrolling is in use, don't let point enter the opposite scroll
12237 margin as result of the scroll.
12238 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12239 threshold of 100 lines for never-recentering scrolling.
12240
e4cc2dfc
JB
122412011-03-31 Juanma Barranquero <lekktu@gmail.com>
12242
12243 * dispextern.h (move_it_by_lines):
12244 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12245 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12246 (message_log_check_duplicate): Remove parameters `prev_bol' and
12247 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12248 (redisplay_internal): Remove parameter `preserve_echo_area',
12249 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12250
12251 * indent.c (Fvertical_motion):
12252 * window.c (window_scroll_pixel_based, Frecenter):
12253 Don't pass `need_y_p' to `move_it_by_lines'.
12254
1c470562
SM
122552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12256
44f230aa
SM
12257 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12258 steal a few bits to be more compact.
12259 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12260 Remove unneeded casts.
12261
1c470562
SM
12262 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12263
888adce9
ZK
122642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12265
12266 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12267 binding" message (bug#7967).
12268
f838ed7b
PE
122692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12270
77861b95
PE
12271 Fix more problems found by GCC 4.6.0's static checks.
12272
de6dbc14
PE
12273 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12274 Remove unused local var.
12275
f838ed7b
PE
12276 * editfns.c (Fmessage_box): Remove unused local var.
12277
792c7b2b
PE
12278 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12279 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12280 Omit unused local vars.
c499e557 12281 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12282 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12283 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12284 Omit unused local var.
12285
ba0165e1
PE
12286 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12287 Don't assume string length fits in int.
32ad8845 12288 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12289 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12290
3c59b4c9
PE
12291 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12292 instead of alloca (Bug#8344).
12293
a3eed478 12294 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12295 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12296
eb4d412d
PE
12297 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12298
1658b401
PE
12299 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12300 concerns.
12301
12302 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12303
12304 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12305
9a2c6e05
PE
12306 * keyboard.c (syms_of_keyboard): Use the same style as later
12307 in this function when indexing through an array. This also
12308 works around GCC bug 48267.
12309
03d0a109
PE
12310 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12311
44f730c8
PE
12312 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12313
fe75f926
PE
12314 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12315 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12316
ffa8c828
PE
12317 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12318 This avoids undefined behavior on integer overflow, and is a bit
12319 more convenient anyway since it is compared to a size_t variable.
12320
c5101a77
PE
12321 Variadic C functions now count arguments with size_t, not int.
12322 This avoids an unnecessary limitation on 64-bit machines, which
12323 caused (substring ...) to crash on large vectors (Bug#8344).
12324 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12325 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12326 All variadic functions and their callers changed accordingly.
c5101a77
PE
12327 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12328 * data.c (arith_driver, float_arith_driver): Likewise.
12329 * editfns.c (general_insert_function): Likewise.
12330 * eval.c (struct backtrace.nargs, interactive_p)
12331 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12332 (funcall_lambda, mark_backtrace): Likewise.
12333 * fns.c (concat): Likewise.
12334 * frame.c (x_set_frame_parameters): Likewise.
12335 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12336 0 if not found, not -1. All callers changed.
12337
dd3f25f7
PE
12338 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12339 (stack_copy_size): Now size_t, not int.
12340 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12341
461c2ab9
JB
123422011-03-28 Juanma Barranquero <lekktu@gmail.com>
12343
12344 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12345 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12346 All callers changed.
12347
12348 * lisp.h (multibyte_char_to_unibyte):
12349 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12350 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12351 * character.h (CHAR_TO_BYTE8):
12352 * cmds.c (internal_self_insert):
12353 * editfns.c (general_insert_function):
12354 * keymap.c (push_key_description):
12355 * search.c (Freplace_match):
12356 * xdisp.c (message_dolog, set_message_1): All callers changed.
12357
f6d62986
SM
123582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12359
12360 * keyboard.c (safe_run_hook_funcall): New function.
12361 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12362 don't set the hook to nil, but remove the offending function instead.
12363 (Qcommand_hook_internal): Remove, unused.
12364 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12365 Vcommand_hook_internal.
12366
12367 * eval.c (enum run_hooks_condition): Remove.
12368 (funcall_nil, funcall_not): New functions.
12369 (run_hook_with_args): Call each function through a `funcall' argument.
12370 Remove `cond' argument, now redundant.
12371 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12372 (Frun_hook_with_args_until_failure): Adjust accordingly.
12373 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12374
1db5b1ad
JB
123752011-03-28 Juanma Barranquero <lekktu@gmail.com>
12376
12377 * dispextern.h (string_buffer_position): Remove declaration.
12378
12379 * print.c (strout): Remove parameter `multibyte', unused since
12380 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12381
12382 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12383 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12384 All callers changed.
12385
12386 * w32.c (_wsa_errlist): Use braces for struct initializers.
12387
12388 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12389 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12390 All callers changed.
12391 (string_buffer_position): Likewise. Also, make static (it's never
12392 used outside xdisp.c).
12393 (cursor_row_p): Remove parameter `w', unused since
12394 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12395 (decode_mode_spec): Remove parameter `precision', introduced during
12396 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12397 All callers changed.
12398
5ffb62aa
JD
123992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12400
12401 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12402
461c2ab9 124032011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12404
12405 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12406 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12407 (ns_update_auto_hide_menu_bar): New functions.
12408 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12409 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12410 ns_constrain_all_frames.
12411 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12412 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12413
5c380ffb
JD
124142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12415
12416 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12417
9af30bdf
GM
124182011-03-27 Glenn Morris <rgm@gnu.org>
12419
12420 * syssignal.h: Replace RETSIGTYPE with void.
12421 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12422 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12423 Replace SIGTYPE with void everywhere.
12424 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12425 * s/template.h (SIGTYPE): Remove commented out definition.
12426
e2abce01
JB
124272011-03-26 Eli Zaretskii <eliz@gnu.org>
12428
12429 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12430 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12431
f868cd8a
JB
124322011-03-26 Juanma Barranquero <lekktu@gmail.com>
12433
59eb0929
JB
12434 * w32.c (read_unc_volume): Use parameter `henum', instead of
12435 global variable `wget_enum_handle'.
12436
12437 * keymap.c (describe_vector): Remove parameters `indices' and
12438 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12439 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12440
f868cd8a
JB
12441 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12442
12443 * keyboard.c (timer_check): Remove parameter `do_it_now',
12444 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12445 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12446 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12447
12448 * keyboard.c (read_char):
12449 * w32menu.c (w32_menu_display_help):
12450 * xmenu.c (show_help_event, menu_help_callback):
12451 Adjust calls to `show_help_echo'.
12452
12453 * gtkutil.c (xg_maybe_add_timer):
12454 * keyboard.c (readable_events):
12455 * process.c (wait_reading_process_output):
12456 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12457
12458 * insdel.c (adjust_markers_gap_motion):
12459 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12460 (gap_left, gap_right): Don't call it.
12461
2ecf6fdb
CY
124622011-03-25 Chong Yidong <cyd@stupidchicken.com>
12463
12464 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12465 incurred during fontification.
12466
6b1f9ba4
JB
124672011-03-25 Juanma Barranquero <lekktu@gmail.com>
12468
12469 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12470 (DEFVAR_PER_BUFFER): Don't pass it.
12471
12472 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12473 (scrolling_window): Don't pass it.
12474
0f4a96b5
JB
124752011-03-25 Juanma Barranquero <lekktu@gmail.com>
12476
12477 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12478
12479 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12480 and `suffix'.
12481 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12482 of variables specific to SELinux and computation of `encoded_absname'.
12483
12484 * image.c (XPutPixel): Remove unused variable `height'.
12485
12486 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12487
12488 * unexw32.c (get_section_info): Remove unused variable `section'.
12489
12490 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12491 (system_process_attributes): Remove unused variable `sess'.
12492 (sys_read): Remove unused variable `err'.
12493
12494 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12495 (w32_wnd_proc): Remove unused variable `isdead'.
12496 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12497 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12498 (x_create_tip_frame): Remove unused variable `tem'.
12499
12500 * w32inevt.c (w32_console_read_socket):
12501 Remove unused variable `no_events'.
12502
12503 * w32term.c (x_draw_composite_glyph_string_foreground):
12504 Remove unused variable `width'.
12505
1149507c
JB
125062011-03-24 Juanma Barranquero <lekktu@gmail.com>
12507
12508 * w32term.c (x_set_glyph_string_clipping):
12509 Don't pass uninitialized region to CombineRgn.
12510
9c88f339
JB
125112011-03-23 Juanma Barranquero <lekktu@gmail.com>
12512
12513 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12514 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12515 (Fx_close_connection): Remove unused variable `i'.
12516
12517 * w32font.c (w32font_draw): Return number of glyphs.
12518 (w32font_open_internal): Remove unused variable `i'.
12519 (w32font_driver): Add missing initializer.
12520
12521 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12522 (fill_in_menu): Remove unused variable `items_added'.
12523
12524 * w32term.c (last_mouse_press_frame): Remove static global variable.
12525 (w32_clip_to_row): Remove unused variable `f'.
12526 (x_delete_terminal): Remove unused variable `i'.
12527
12528 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12529 (NOTHING): Remove unused static global variable.
12530 (uniscribe_check_otf): Remove unused variable `table'.
12531 (uniscribe_font_driver): Add missing initializers.
12532
dee091a3
JD
125332011-03-23 Julien Danjou <julien@danjou.info>
12534
12535 * term.c (Fsuspend_tty, Fresume_tty):
12536 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12537 * window.c (temp_output_buffer_show):
12538 * insdel.c (signal_before_change):
12539 * frame.c (Fhandle_switch_frame):
12540 * fileio.c (Fdo_auto_save):
12541 * emacs.c (Fkill_emacs):
12542 * editfns.c (save_excursion_restore):
12543 * cmds.c (internal_self_insert):
12544 * callint.c (Fcall_interactively):
12545 * buffer.c (Fkill_all_local_variables):
12546 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12547 Use Frun_hooks.
0f4a96b5 12548 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12549 unconditionally since it does the check itself.
dee091a3 12550
2c520ab5 125512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12552
c9c49752
PE
12553 Fix more problems found by GCC 4.5.2's static checks.
12554
8abc3f12
PE
12555 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12556 the first time through the loop, since we know p0 < p1 then.
12557 This also avoids a gcc -Wstrict-overflow warning.
12558
a2d26660
PE
12559 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12560 leading to a memory leak, possible in functions like
12561 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12562 of objects (Bug#8318).
a2d26660 12563
916c72e9
PE
12564 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12565 that could (at least in theory) be that large.
12566
19ab8a18
PE
12567 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12568 This is less likely to overflow, and avoids undefined behavior if
12569 overflow does occur. All callers changed. Use strtoul to scan
12570 for the unsigned long integer.
b7cbbd6f
PE
12571 (pint2hrstr): Simplify and tune code slightly.
12572 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12573
f0641eff
PE
12574 * scroll.c (do_scrolling): Work around GCC bug 48228.
12575 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12576
7f650bb9
PE
12577 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12578 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12579 (validate_x_resource_name): Simplify count usage.
12580 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12581
37dd57d1
PE
12582 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12583 fail (Bug#8306).
81e56e61 12584
699979fc 12585 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12586
401bf9b4
PE
12587 * process.c (Fmake_network_process): Use socklen_t, not int,
12588 where POSIX says socklen_t is required in portable programs.
12589 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12590 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12591 (Fmake_network_process, server_accept_connection):
12592 (wait_reading_process_output, read_process_output):
12593 Likewise.
12594
b93aacde
PE
12595 * process.c: Rename or move locals to avoid shadowing.
12596 (list_processes_1, Fmake_network_process):
12597 (read_process_output_error_handler, exec_sentinel_error_handler):
12598 Rename or move locals.
4dc343ee 12599 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12600 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12601 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12602 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12603 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12604
af8a867c 12605 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12606 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12607 Include tparam.h instead, since it declares them.
af8a867c
PE
12608 * cm.h (PC): Remove extern decl; tparam.h now does this.
12609 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12610 * terminfo.c: Include tparam.h, to check interfaces.
12611 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12612 (tparam): Adjust signature to match interface in tparam.h;
12613 this removes some undefined behavior. Check that outstring and len
12614 are zero, which they always are with Emacs.
12615 * tparam.h (PC, BC, UP): New extern decls.
12616
0248044d 12617 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12618 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12619
8ff096c1 12620 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12621 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12622 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12623 (ftfont_list): Remove unused local.
49eaafba
PE
12624 (get_adstyle_property, ftfont_pattern_entity):
12625 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12626 Rename locals to avoid shadowing.
8ff096c1 12627
e2be39f6
PE
12628 * xfont.c (xfont_list_family): Mark var as initialized.
12629
c9735e30
PE
12630 * xml.c (make_dom): Now static.
12631
8f5201ae
PE
12632 * composite.c (composition_compute_stop_pos): Rename local to
12633 avoid shadowing.
b246f932
PE
12634 (composition_reseat_it): Remove unused locals.
12635 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12636 (composition_update_it): Mark var as initialized.
11b61122
PE
12637 (find_automatic_composition): Mark vars as initialized,
12638 with a FIXME (Bug#8290).
8f5201ae 12639
760fbc2c
PE
12640 character.h: Rename locals to avoid shadowing.
12641 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12642 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12643 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12644 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12645 to avoid shadowing.
12646
ff08eb85
PE
12647 * textprop.c (property_change_between_p): Remove; unused.
12648
fc7bf025
PE
12649 * intervals.c (interval_start_pos): Now static.
12650
235d7abc
PE
12651 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12652
44f230aa
SM
12653 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12654 Rename locals to avoid shadowing.
3e7d6594 12655
50060332
PE
12656 * sound.c (wav_play, au_play, Fplay_sound_internal):
12657 Fix pointer signedness.
d01f234b 12658 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12659 (wav_play): Initialize a variable to 0, to prevent undefined
12660 behavior (Bug#8278).
50060332 12661
c4fc4e30
PE
12662 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12663
918436ed
PE
12664 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12665
c939f91b
PE
12666 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12667 clobbering (Bug#8298).
b9c7f648
PE
12668 * sysdep.c (sys_subshell): Likewise.
12669 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12670
6bd8c144
PE
12671 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12672 This should get cleaned up, so that child_setup has the
12673 same signature on all platforms.
12674
7710357c 12675 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12676 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12677
c59da222
CY
126782011-03-22 Chong Yidong <cyd@stupidchicken.com>
12679
12680 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12681 not to be necessary, and produces flickering.
12682
66b87493
GM
126832011-03-20 Glenn Morris <rgm@gnu.org>
12684
12685 * config.in: Remove file.
12686
45b6f6d5
JB
126872011-03-20 Juanma Barranquero <lekktu@gmail.com>
12688
12689 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12690 are now in src/globals.h.
12691 (syms_of_minibuf): Remove spurious & from previous change.
12692
cd394be1 126932011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12694
12695 * minibuf.c (completing-read-function): New variable.
12696 (completing-read-default): Rename from completing-read.
12697 (completing-read): Call completing-read-function.
12698
b14e3e21
CY
126992011-03-19 Juanma Barranquero <lekktu@gmail.com>
12700
12701 * xfaces.c (Fx_load_color_file):
12702 Read color file from absolute filename (bug#8250).
12703
f2b726e6
JB
127042011-03-19 Juanma Barranquero <lekktu@gmail.com>
12705
12706 * makefile.w32-in: Update dependencies.
12707
09f6ff02
EZ
127082011-03-17 Eli Zaretskii <eliz@gnu.org>
12709
12710 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12711
29a6015a
PE
127122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12713
a3a6c54e
PE
12714 Fix more problems found by GCC 4.5.2's static checks.
12715
b766f867
PE
12716 * process.c (make_serial_process_unwind, send_process_trap):
12717 (sigchld_handler): Now static.
12718
be02381c
PE
12719 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12720 That way, the code declares only the vars that it needs.
12721 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12722 * s/cygwin.h (PTY_ITERATION): Likewise.
12723 * s/darwin.h (PTY_ITERATION): Likewise.
12724 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12725
57048744
PE
12726 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12727 * process.c (allocate_pty): Don't declare stb unless it's needed.
12728
7914961c 12729 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12730 (CONSTANTLIM): Remove; unused.
12731 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12732 Define only if needed.
7914961c 12733
b3967b18
PE
12734 * unexelf.c (unexec): Name an expression,
12735 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12736 Use a different way to cause a compilation error if anyone uses
12737 n rather than nn, a way that does not involve shadowing.
73366a00 12738 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12739
29a6015a
PE
12740 * deps.mk (unexalpha.o): Remove; unused.
12741
43cfc33e 12742 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12743 * unexec.h: New file.
ce701a33
PE
12744 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12745 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12746 Depend on unexec.h.
12747 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12748 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12749 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12750 Change as necessary to match prototype in unexec.h.
ce701a33 12751
01f44d5a
PE
12752 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12753 shadowing.
4f63c6bb 12754 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12755
a6670b0b
PE
12756 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12757 Rename locals to avoid shadowing.
12758
cef2010d 12759 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12760 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12761
d4d7173a
PE
12762 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12763
f08b802a
PE
12764 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12765 warning when compiling print.c.
12766
3ddb0639
PE
12767 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12768 instead of using an uninitialized var.
5ad03b97 12769 (font_sort_entities): Mark var as initialized.
3ddb0639 12770
170a2692
PE
12771 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12772
e663c700
PE
12773 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12774 pointers to constants.
89bc529a 12775 (font_parse_fcname): Remove unused vars.
7b81e2d0 12776 (font_delete_unmatched): Now static.
ea838e10 12777 (font_get_spec): Remove; unused.
13a547c6
PE
12778 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12779 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12780 Rename or move locals to avoid shadowing.
e663c700 12781
2a80c887 12782 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12783 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12784
1384fa33 12785 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12786 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12787
8b2c52e9
PE
12788 * alloc.c (mark_backtrace): Move decl from here ...
12789 * lisp.h: ... to here, so that it can be checked.
12790
475545b5 12791 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12792 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12793 (lisp_indirect_variable): Name an expression,
12794 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12795 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12796
b1349114 12797 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12798 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12799 Use const pointer when appropriate.
b1349114 12800
a2928364
PE
12801 * lisp.h (get_system_name, get_operating_system_release):
12802 Move decls here, to check interfaces.
12803 * process.c (get_operating_system_release): Move decl to lisp.h.
12804 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12805 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12806 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12807 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12808 (Fformat_time_string, Fencode_time, Finsert_char):
12809 (Ftranslate_region_internal, Fformat):
12810 Rename or remove local vars to avoid shadowing.
9710023e 12811 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12812
a415e694
PE
12813 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12814 avoid shadowing.
12815
8ef4622d
PE
12816 * lisp.h (eassert): Check that the argument compiles, even if
12817 ENABLE_CHECKING is not defined.
12818
946f9a5b
PE
12819 * data.c (Findirect_variable): Name an expression, to avoid
12820 gcc -Wbad-function-cast warning.
112396d6 12821 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12822 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12823 (Fmake_variable_buffer_local, Fmake_local_variable):
12824 Mark variables as initialized.
52746918 12825 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12826
e5aab7e7 12827 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12828 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12829 Rename locals to avoid shadowing.
dff45157
PE
12830 (mark_stack): Move local variables into the #ifdef region where
12831 they're used.
7bc26fdb
PE
12832 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12833 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12834 needed otherwise.
12835 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12836 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12837 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12838
e5aab7e7
PE
12839 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12840 avoids undefined behavior in theory.
12841
4da60324
PE
12842 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12843
88043301
PE
12844 Use functions, not macros, for up- and down-casing (Bug#8254).
12845 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12846 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12847 to use the following functions instead of these macros.
12848 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12849 EMACS_INT, since callers assume the returned value fits in int.
12850 (upcase1): Likewise, for UPCASE_TABLE.
12851 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12852 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12853 the race-condition problem in the old DOWNCASE.
88043301 12854
19ed5445
PE
12855 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12856 Rename locals to avoid shadowing.
12857 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12858 (regex_compile, re_search_2, re_match_2_internal):
12859 Remove unused local vars.
952db0d7
PE
12860 (FREE_VAR): Rewrite so as not to use empty "else",
12861 which gcc can warn about.
da053e48 12862 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12863 (RETALLOC_IF): Define only if needed.
12864 (WORDCHAR_P): Likewise. This one is never needed, but is used
12865 only in a comment talking about a compiler bug, so put inside
12866 the #if 0 of that comment.
12867 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12868 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12869 Remove; unused.
19ed5445 12870
1f3561e4 12871 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12872 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12873 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12874
ded6f8f7
PE
12875 * search.c (simple_search): Remove unused var.
12876
dbd37a95
PE
12877 * dired.c (compile_pattern): Move decl from here ...
12878 * lisp.h: ... to here, so that it can be checked.
12879 (struct re_registers): New forward decl.
12880
7e47afad
PE
12881 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12882
85f24f61
PE
12883 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12884 All uses changed.
12885 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12886 Rename locals to avoid shadowing.
5671df8f 12887 (Fvertical_motion): Mark locals as initialized.
85f24f61 12888
181aa2be 12889 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12890 (casify_region): Mark local as initialized.
181aa2be 12891
930d429c
PE
12892 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12893
7082eac6
PE
12894 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12895 New macros, so that the caller can use some names other than
12896 gcpro1, gcpro2, etc.
12897 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12898 of the new macros.
12899 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12900 argument, for consistency with GCPRO2_VAR, etc: it is now the
12901 prefix of the variable, not the variable itself. All uses
12902 changed.
38b2c076
PE
12903 * dired.c (directory_files_internal, file_name_completion):
12904 Rename locals to avoid shadowing.
12905
15206ed9
PE
12906 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12907 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12908 dired.c's scmp function, had undefined behavior.
12909 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12910 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12911 * buffer.h: ... to here, because these macros use current_buffer,
12912 and the new implementation with inline functions needs to have
12913 current_buffer in scope now, rather than later when the macros
12914 are used.
12915 (downcase, upcase1): New static inline functions.
12916 (DOWNCASE, UPCASE1): Reimplement using these functions.
12917 This avoids undefined behavior in expressions like
12918 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12919 from race conditions in accessing the global variables
12920 case_temp1 and case_temp2.
12921 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12922 * lisp.h (case_temp1, case_temp2): Remove their decls.
12923 * character.h (ASCII_CHAR_P): Move from here ...
12924 * lisp.h: ... to here, so that the inline functions mentioned
12925 above can use them.
12926
4a6bea26
PE
12927 * dired.c (directory_files_internal_unwind): Now static.
12928
f14b7e14
PE
12929 * fileio.c (file_name_as_directory, directory_file_name):
12930 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12931 Now static.
2893f146
PE
12932 (file_name_as_directory): Use const pointers when appropriate.
12933 (Fexpand_file_name): Likewise. In particular, newdir might
12934 point at constant storage, so make it a const pointer.
fd4ead52 12935 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12936 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12937 signedness issues.
f839df0c
PE
12938 (Fset_file_times, Finsert_file_contents, auto_save_error):
12939 Rename locals to avoid shadowing.
f14b7e14 12940
5716756e 12941 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12942 (Ftry_completion, Fall_completions): Rename or remove locals
12943 to avoid shadowing.
5716756e 12944
b4c3046a
PE
12945 * marker.c (bytepos_to_charpos): Remove; unused.
12946
b45db522
PE
12947 * lisp.h (verify_bytepos, count_markers): New decls,
12948 so that gcc does not warn that these functions aren't declared.
12949
85876d07
PE
12950 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12951 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12952 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12953 (copy_text): Remove unused local var.
85876d07 12954
03d78a21 12955 * filelock.c (within_one_second): Now static.
b3dd38ab 12956 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12957
5df8f01b
PE
12958 * buffer.c (fix_overlays_before): Mark locals as initialized.
12959 (fix_start_end_in_overlays): Likewise. This function should be
12960 simplified by using pointers-to-pointers, but that's a different
12961 matter.
b1d876f1 12962 (switch_to_buffer_1): Now static.
8f54f30a
PE
12963 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12964 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12965
a70072c9 12966 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12967 Fix pointer signedness issue.
edced198
PE
12968 (sys_subshell): Mark local as volatile if checking for lint,
12969 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12970 (MAXPATHLEN): Define only if needed.
a70072c9 12971
a0977c44
PE
12972 * process.c (serial_open, serial_configure): Move decls from here ...
12973 * systty.h: ... to here, so that they can be checked.
12974
a884fdcc
PE
12975 * fns.c (get_random, seed_random): Move extern decls from here ...
12976 * lisp.h: ... to here, so that they can be checked.
12977
604efe86 12978 * sysdep.c (reset_io): Now static.
b8950c94 12979 (wait_for_termination_signal): Remove; unused.
604efe86 12980
38fc62d9
PE
12981 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12982 (copy_keymap_item, append_key, push_text_char_description):
12983 Now static.
1004a21a 12984 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12985 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12986 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12987 (describe_map_tree):
12988 Rename locals to avoid shadowing.
38fc62d9 12989
2f2650da
PE
12990 * keyboard.c: Declare functions static if they are not used elsewhere.
12991 (echo_char, echo_dash, cmd_error, top_level_2):
12992 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12993 (read_char, kbd_buffer_get_event, make_lispy_position):
12994 (make_lispy_event, make_lispy_movement, apply_modifiers):
12995 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12996 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12997 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12998 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12999 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13000
a053e86c 13001 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13002 (mark_kboards): Move decl here ...
13003 * alloc.c (mark_kboards): ... from here.
a053e86c 13004
4752793e
PE
13005 * lisp.h (force_auto_save_soon): New decl.
13006
74f10ca7 13007 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13008 (DEFINE_DUMMY_FUNCTION): New macro.
13009 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13010 Use it.
c03cd23f
PE
13011 (main): Add casts to avoid warnings
13012 if GCC considers string literals to be constants.
74f10ca7 13013
022e70d4
PE
13014 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13015
59d6fe83
PE
13016 * dbusbind.c: Pointer signedness fixes.
13017 (xd_signature, xd_append_arg, xd_initialize):
13018 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13019 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13020 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13021 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13022
78320123
PE
13023 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13024 if GCC considers string literals to be constants.
49cebcca 13025 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13026
35ac2a97
SM
130272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13028
fb103ca9
SM
13029 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13030 (print_preprocess, print_object): New macro to fix last change.
13031
35ac2a97
SM
13032 * print.c (print_preprocess): Don't forget font objects.
13033
62973b41
JB
130342011-03-16 Juanma Barranquero <lekktu@gmail.com>
13035
13036 * emacs.c (USAGE3): Doc fixes.
13037
0e48bb22
AS
130382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13039
13040 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13041 structure.
13042
7684e57b
JB
130432011-03-14 Juanma Barranquero <lekktu@gmail.com>
13044
13045 * lisp.h (VWindow_system, Qfile_name_history):
13046 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13047 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13048 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13049
13050 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13051 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13052
13053 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13054 * w32console.c (detect_input_pending, read_input_pending)
13055 (encode_terminal_code):
13056 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13057 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13058 (w32_system_caret_y, Qfile_name_history):
13059 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13060 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13061 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13062 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13063 * w32proc.c (Qlocal, report_file_error):
13064 * w32term.c (Vwindow_system, updating_frame):
13065 * w32uniscribe.c (initialized, uniscribe_font_driver):
13066 Remove unneeded extern declarations.
13067
2aa46d6c
CY
130682011-03-14 Chong Yidong <cyd@stupidchicken.com>
13069
c96bbc66 13070 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13071
cffc6f3b
CY
130722011-03-13 Chong Yidong <cyd@stupidchicken.com>
13073
13074 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13075 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13076 These macros can no longer be used for assignment.
13077
44f230aa
SM
13078 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13079 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13080 (record_buffer_markers, fetch_buffer_markers): New functions for
13081 recording and fetching special buffer markers.
13082 (set_buffer_internal_1, set_buffer_temp): Use them.
13083
13084 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13085
13086 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13087
13088 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13089 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13090
13091 * xdisp.c (hscroll_window_tree):
13092 (reconsider_clip_changes): Use PT instead of BUF_PT.
13093
d251f04b
EZ
130942011-03-13 Eli Zaretskii <eliz@gnu.org>
13095
13096 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13097 $(EMACS_ROOT)/lib/intprops.h.
13098
f0c77cd1
PE
130992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13100
3eca4629
PE
13101 Fix more problems found by GCC 4.5.2's static checks.
13102
7c86ee98
PE
13103 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13104 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13105 (xg_free_frame_widgets): Make it clear that a local variable is
13106 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13107 (gdk_window_get_screen): Make it clear that this macro is needed
13108 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13109 (int_gtk_range_get_value): New function, which avoids a diagnostic
13110 from gcc -Wbad-function-cast.
13111 (xg_set_toolkit_scroll_bar_thumb): Use it.
13112 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13113 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13114 (get_utf8_string, xg_get_file_with_chooser):
13115 Rename locals to avoid shadowing.
13116 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13117
41729b81
PE
13118 * xgselect.c (xg_select): Remove unused var.
13119
f0c77cd1
PE
13120 * image.c (four_corners_best): Mark locals as initialized.
13121 (gif_load): Initialize transparent_p to zero (Bug#8238).
13122 Mark another local as initialized.
ec6cf4c6 13123 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13124
ce0ad53d 13125 * image.c (clear_image_cache): Now static.
d5d5a617 13126 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13127 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13128 (x_edge_detection): Remove unnecessary cast that
13129 gcc -Wbad-function-cast diagnoses.
2037898d 13130 (gif_load): Fix pointer signedness.
6ae141d6
PE
13131 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13132 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13133
33383987 131342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13135
d32df629
PE
13136 Improve quality of tests for time stamp overflow.
13137 For example, without this patch (encode-time 0 0 0 1 1
13138 1152921504606846976) returns the obviously-bogus value (-948597
13139 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13140 reports time overflow. See
13141 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13142 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13143 * editfns.c: Include limits.h and intprops.h.
13144 (TIME_T_MIN, TIME_T_MAX): New macros.
13145 (time_overflow): Move earlier, to before first use.
13146 (hi_time, lo_time): New functions, for an accurate test for
13147 out-of-range times.
13148 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13149 (Fget_internal_run_time): Don't assume time_t fits in int.
13150 (make_time): Use list2 instead of Fcons twice.
13151 (Fdecode_time): More accurate test for out-of-range times.
13152 (check_tm_member): New function.
13153 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13154 (lisp_time_argument): Don't rely on undefined left-shift and
13155 right-shift behavior when checking for time stamp overflow.
8be6f318 13156
fe31d94c
PE
13157 * editfns.c (time_overflow): New function, refactoring common code.
13158 (Fformat_time_string, Fdecode_time, Fencode_time):
13159 (Fcurrent_time_string): Use it.
13160
8be6f318
PE
13161 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13162 * dired.c (make_time): Move to ...
13163 * editfns.c (make_time): ... here.
13164 * systime.h: Note the move.
13165
09d9db2c 131662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13167
126bc0dc
YM
13168 * fringe.c (update_window_fringes): Remove unused variables.
13169
c47cbdfd
YM
13170 * unexmacosx.c (copy_data_segment): Also copy __got section.
13171 (Bug#8223)
13172
7ac80be9
EZ
131732011-03-12 Eli Zaretskii <eliz@gnu.org>
13174
c96bbc66 13175 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13176 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13177 Constify `char *' arguments and their references according to
13178 prototypes in tparam.h.
13179
ecb0f94d 13180 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13181
7ac80be9
EZ
13182 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13183 Adapt all references accordingly.
13184
13185 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13186
ef1fd07e
TT
131872011-03-11 Tom Tromey <tromey@redhat.com>
13188
13189 * buffer.c (syms_of_buffer): Remove obsolete comment.
13190
7ef4b50c
EZ
131912011-03-11 Eli Zaretskii <eliz@gnu.org>
13192
13193 * termhooks.h (encode_terminal_code): Declare prototype.
13194
13195 * msdos.c (encode_terminal_code): Don't declare prototype.
13196
13197 * term.c (encode_terminal_code): Now external again, used by
13198 w32console.c and msdos.c.
13199
44f230aa
SM
13200 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13201 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13202
4b1ec863 132032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13204
1714f52b 13205 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13206
4b1ec863
PE
13207 * fringe.c (update_window_fringes): Mark locals as initialized
13208 (Bug#8227).
13209 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13210
524c7aa6
PE
13211 * alloc.c (mark_fringe_data): Move decl from here ...
13212 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13213 to check its interface.
13214 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13215
a5c0af81 13216 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13217 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13218 (fontset_font): Mark local as initialized.
a9a06e0b 13219 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13220
b4716021
PE
13221 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13222
811e9bac 13223 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13224 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13225 (x_own_selection, Fx_disown_selection_internal): Rename locals
13226 to avoid shadowing.
13227 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13228
7e3ab302
PE
13229 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13230 so that the caller can use some name other than gcpro1.
13231 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13232 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13233 (Fx_backspace_delete_keys_p):
13234 Use them to avoid shadowing, and rename vars to avoid shadowing.
13235 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13236 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13237 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13238 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13239 Remove unused locals.
7e3ab302
PE
13240 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13241 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13242 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13243 macros.
f78faa98 13244
e2b13473
PE
13245 * xterm.h (x_mouse_leave): New decl.
13246
77f23912
PE
13247 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13248 Remove unused functions.
cdf4ba58
PE
13249 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13250 (x_calc_absolute_position): Now static.
7411c686 13251 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13252 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13253 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13254 unless they are used.
38d0b34a
PE
13255 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13256 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13257 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13258 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13259 (x_error_catcher, x_connection_closed, x_error_handler):
13260 (x_error_quitter, xembed_send_message, x_iconify_frame):
13261 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13262 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13263 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13264
44f230aa
SM
13265 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13266 Rename or move locals to avoid shadowing.
6b463e58 13267 (tty_defined_color, merge_face_heights): Now static.
5967d051 13268 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13269 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13270 does not deduce is never used uninitialized.
73719eba
PE
13271 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13272 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13273
426994c3 13274 * terminal.c (store_terminal_param): Now static.
5489860b 13275
032f1620 13276 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13277 (set_frame_menubar): Remove unused local.
d4323972 13278 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13279 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13280 since they might point to immutable storage.
281585b0
PE
13281 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13282 since it's unused otherwise.
032f1620 13283
367c19e5 13284 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13285 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13286 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13287 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13288 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13289 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13290 does not deduce are never used uninitialized.
70739cbe 13291
07b48fa9
PE
13292 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13293
8868a238 13294 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13295 * window.c (window_loop, size_window):
13296 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13297
7e5cf297 13298 * window.c (display_buffer): Now static.
d6550a9f
PE
13299 (size_window): Mark variables that gcc -Wuninitialized
13300 does not deduce are never used uninitialized.
a586633d
PE
13301 * window.h (check_all_windows): New decl, to forestall
13302 gcc -Wmissing-prototypes diagnostic.
5b555da1 13303 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13304
f6095868
PE
13305 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13306 shadowing.
13307 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13308 Include <limits.h>.
13309 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13310 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13311 (load_charset_map): Mark variables that gcc -Wuninitialized
13312 does not deduce are never used uninitialized.
53df7c11 13313 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13314
f38b440c
PE
13315 * coding.c (coding_set_source, coding_set_destination):
13316 Use "else { /* comment */ }" rather than "else /* comment */;"
13317 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13318 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13319 a block, when the outer 'i' will do.
13320 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13321 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13322 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13323 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13324 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13325 Rename locals to avoid shadowing.
13326 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13327 * coding.c (emacs_mule_char, encode_invocation_designation):
13328 Now static, since they're not used elsewhere.
413bb2db 13329 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13330 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13331 (decode_coding_emacs_mule): Mark variables that gcc
13332 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13333 (detect_coding_iso_2022): Initialize a local variable that might
13334 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13335 this initialization is needed. (Bug#8211)
5f58e762
PE
13336 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13337 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13338 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13339 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13340 Remove unused macros.
f38b440c 13341
232b38b9 13342 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13343 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13344 * character.c (string_count_byte8): Likewise.
232b38b9 13345
fb90da1b
PE
13346 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13347 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13348
fb93dbc2
PE
13349 * chartab.c (copy_sub_char_table): Now static, since it's not used
13350 elsewhere.
5c156ace
PE
13351 (sub_char_table_ref_and_range, char_table_ref_and_range):
13352 Rename locals to avoid shadowing.
bbcd0949 13353 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13354
7d3b3862 13355 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13356 (BIDI_BOB): Remove unused macro.
7d3b3862 13357
6be7d3da
PE
13358 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13359 deduce are never used uninitialized.
c2ed9c8b 13360 * term.c (encode_terminal_code): Likewise.
6be7d3da 13361
75f8807f 13362 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13363
50938595
PE
13364 * tparam.h: New file.
13365 * term.c, tparam.h: Include it.
13366 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13367 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13368 Move these decls to tparam.h, and make them agree with what
13369 is actually in tparam.c. The previous trick of using incompatible
13370 decls in different modules does not conform to the C standard.
13371 All callers of tparam changed to use tparam's actual API.
13372 * tparam.c (tparam1, tparam, tgoto):
13373 Use const pointers where appropriate.
13374
fbceeba2
PE
13375 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13376 * cm.h (struct cm): Likewise.
13377 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13378 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13379 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13380 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13381 (turn_on_face, init_tty): Likewise.
13382 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13383
7f3f1250
PE
13384 * term.c (term_mouse_position): Rename local to avoid shadowing.
13385
e6ca6543
PE
13386 * alloc.c (mark_ttys): Move decl from here ...
13387 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13388
c40f8d15
AS
133892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13390
13391 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13392
cfe0661d
JB
133932011-03-09 Juanma Barranquero <lekktu@gmail.com>
13394
13395 * search.c (compile_pattern_1): Remove argument regp, unused since
13396 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13397 (compile_pattern): Don't pass it.
13398
0afb4571
J
133992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13400
13401 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13402 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13403 for ! HAVE_GTK3.
13404 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13405
13406 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13407
13408 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13409 gdk_window_get_screen, gdk_window_get_geometry,
13410 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13411 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13412 (xg_get_pixbuf_from_pixmap): New function.
13413 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13414 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13415 Call xg_get_pixbuf_from_pixmap instead of
13416 gdk_pixbuf_get_from_drawable.
13417 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13418 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13419 (xg_check_special_colors): Use GtkStyleContext and its functions
13420 for HAVE_GTK3.
13421 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13422 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13423 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13424 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13425 Call gtk_widget_get_preferred_size.
0afb4571
J
13426 (xg_frame_resized): gdk_window_get_geometry only takes 5
13427 parameters.
44f230aa
SM
13428 (xg_win_to_widget, xg_event_is_for_menubar):
13429 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13430 (xg_set_widget_bg): New function.
13431 (delete_cb): New function.
895009e1 13432 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13433 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13434 (xg_set_background_color): Call xg_set_widget_bg.
13435 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13436 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13437 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13438 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13439 if ! HAVE_GTK3.
13440 (update_frame_tool_bar): Call gtk_widget_hide.
13441 (xg_initialize): Use GDK_KEY_g.
13442
13443 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13444 if ! HAVE_GTK3
13445 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13446
13447 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13448 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13449 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13450
1c2cc4ef
JB
134512011-03-08 Juanma Barranquero <lekktu@gmail.com>
13452
13453 * w32xfns.c (select_palette): Check success of RealizePalette against
13454 GDI_ERROR, not zero.
13455
33383987 13456See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13457
13458;; Local Variables:
13459;; coding: utf-8
aac0c6e3
MR
13460;; End:
13461
2f097256 13462 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13463
13464 This file is part of GNU Emacs.
13465
13466 GNU Emacs is free software: you can redistribute it and/or modify
13467 it under the terms of the GNU General Public License as published by
13468 the Free Software Foundation, either version 3 of the License, or
13469 (at your option) any later version.
13470
13471 GNU Emacs is distributed in the hope that it will be useful,
13472 but WITHOUT ANY WARRANTY; without even the implied warranty of
13473 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13474 GNU General Public License for more details.
13475
13476 You should have received a copy of the GNU General Public License
13477 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.