* rect.el (copy-rectangle-as-kill): New command.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5b3f250f
GM
12012-07-14 Glenn Morris <rgm@gnu.org>
2
3 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
5 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
6
33d63ff4
GM
72012-07-13 Glenn Morris <rgm@gnu.org>
8
5b633342
GM
9 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
10
33d63ff4
GM
11 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
12 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
13
b55b9f85
JD
142012-07-13 Jan Djärv <jan.h.d@swipnet.se>
15
0dc8cf50
JD
16 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
17 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
18 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
19 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
20 where appropriate.
21 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
22 as boolean expression.
23 (x_set_window_size): Remove unused variable toolbar.
24 (ns_get_color_default, ns_mod_to_lisp): Remove.
25 (ns_mouse_position): Remove unused variables xchar and ychar.
26 (ns_compute_glyph_string_overhangs): Remove unused variable face.
27 (ns_set_vertical_scroll_bar): Remove unused variable count.
28 (ns_delete_terminal): Remove unused variable i.
29 (ns_term_init): Remove unused variables r, g and b.
30 (mouseDown): Remove unused variable window.
31 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
32 (initFrameFromEmacs): Remove unused variable vbextra.
33 (mouseEntered): Remove unused variables p and dpyinfo.
34 (mouseExited): Remove unused variables p and r.
35 (ns_define_frame_cursor, ns_clear_frame_area)
36 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
37 (menuDown): Assign [sender tag] to variable and cast the variable.
38
39 * nsterm.h (menuDown): Add id as type to argument sender.
40 (ns_display_info_for_name): Add Lisp_Object argument.
41 (ns_term_init): Add Lisp_Object argument.
42 (ns_map_event_to_object): Add void argument.
43 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
44 prototype with arguments and only declare if __OBJC__.
45 (nxatoms_of_nsselect): Add void argument.
46 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
47 (ns_alloc_autorelease_pool): Add void argument.
48 (ns_release_autorelease_pool): Add void* argument.
49 (ns_get_defaults_value): Add const char* argument.
50
51 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
52 (initFromContents): Use SSDATA where appropriate.
53 (ns_update_menubar): Add braces to ambigous if-else.
54 (initWithTitle): Put () around assignment in if statement.
55 (ns_menu_show): Remove unused variables window and keymap.
56 (update_frame_tool_bar): Remove unused variable selected_p.
57 (initWithContentRect): Remove unused variable this_cmd_name.
58
59 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
60 appropriate.
61 (setXBMColor): Remove unused variable len.
62 (setPixmapData): Put () around assignment in loop statement.
63
64 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
65 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
66 where appropriate.
67 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
68 around assignment in loop statement.
69 (nsfont_open): Remove unused variable i.
70 (nsfont_open): Remove unused variable len.
71 (nsfont_draw): Remove unused variable cs.
72
73 * nsfns.m (x_set_icon_name, ns_set_name_internal)
74 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
75 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
76 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
77 (Fns_font_name, Fns_perform_service)
78 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
79 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
80 (ns_set_name): Remove unused variable view.
81 (x_set_menu_bar_lines): Remove unused variable olines.
82 (x_set_tool_bar_lines): Remove unused variable root_window.
83 (Fns_list_colors): Put () around assignment in while statement.
84 (Fns_perform_service): Remove unused variable len.
85 (Fns_display_usable_bounds): Remove unused variable top.
86 (syms_of_nsfns): Remove unused variable i.
87
b55b9f85
JD
88 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
89 memcpy (Bug#11907).
90
ed9265fc 912012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
92
93 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
94 and free it with DestroyExceptionInfo (Bug#11558).
95
ef099b57
JB
962012-07-13 Juanma Barranquero <lekktu@gmail.com>
97
98 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
99 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
100 Set here, not in nt/config.nt.
101
ea814a5d
EZ
1022012-07-13 Eli Zaretskii <eliz@gnu.org>
103
104 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
105 cursor overflow into the last glyph on display line when the right
106 fringe is off. (Bug#11832)
107
1a952767
PE
1082012-07-13 Paul Eggert <eggert@cs.ucla.edu>
109
110 * xdisp.c (produce_special_glyphs): Now static.
111 * dispextern.h (produce_special_glyphs): Remove decl.
112
983188fd
GM
1132012-07-13 Glenn Morris <rgm@gnu.org>
114
32fb4bb6
GM
115 * s/bsd-common, s/cygwin.h: Remove empty files.
116 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
117
983188fd
GM
118 * s/usg5-4-common.h (USG, USG5):
119 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
120 * s/sol2-6.h (SOLARIS2):
121 * s/irix6-5.h (IRIX6_5):
122 * s/hpux10-20.h (USG, USG5, HPUX):
123 * s/gnu-linux.h (USG, GNU_LINUX):
124 * s/freebsd.h (BSD_SYSTEM):
125 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
126 * s/cygwin.h (CYGWIN):
127 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
128 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
129
d1e68667 1302012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
131
132 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 133
6de0e799
GM
1342012-07-13 Glenn Morris <rgm@gnu.org>
135
739ae010
GM
136 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
137
dbee5793
GM
138 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
139
6de0e799
GM
140 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
141 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
142
b82da769
GM
1432012-07-12 Glenn Morris <rgm@gnu.org>
144
4fae5a7a 145 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
146
147 * process.c (init_process_emacs): Rename from init_process.
148 The old name is also the name of a Mach system call.
149 * lisp.h, emacs.c: Update for this name change.
150 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
151 longer needed.
152
5a979817
EZ
1532012-07-12 Eli Zaretskii <eliz@gnu.org>
154
155 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
156 memmove call that removes glyphs covered by the left truncation
157 glyph. Improve commentary.
158 (display_line): Fix display of continuation glyphs on GUI frames
159 when the right fringe is turned off and variable-size fonts are
160 used in the window. Move the code that appends a stretch glyph to
161 produce_special_glyphs, so that it could be used for truncation
162 and continuation glyphs alike.
163 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
164 glyph of a suitably computed width, to align the special glyphs at
165 the window margin. Code moved from display_line. (Bug#11832)
166
3e91a053
GM
1672012-07-12 Glenn Morris <rgm@gnu.org>
168
ba9e4b84
GM
169 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
170
171 * s/gnu-linux.h, s/hpux10-20.h:
172 Do not unconditionally define HAVE_XRMSETDATABASE.
173
3e91a053
GM
174 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
175
b300b1f4
PE
1762012-07-12 Paul Eggert <eggert@cs.ucla.edu>
177
178 Fix typos that broke OS X build.
179 Reported by Randal L. Schwartz in
180 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
181 * nsterm.m (ns_timeout): Add missing local decl.
182 (ns_get_color): snprintf -> sprintf, to fix typo.
183
6e777848
GM
1842012-07-12 Glenn Morris <rgm@gnu.org>
185
3f922c37
GM
186 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
187 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
188 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
189 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
190
0ab7b23a
GM
191 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
192 Move PTY_OPEN to configure.
193
6e777848
GM
194 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
195 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
196 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
197
4a7edc24
DA
1982012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
199
200 Use empty_unibyte_string where applicable.
201 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
202 * lread.c (read1): Likewise.
203 * xsettings.c (syms_of_xsettings): Likewise.
204
308aab79
GM
2052012-07-12 Glenn Morris <rgm@gnu.org>
206
42bd1719
GM
207 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
208 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
209 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
210 * s/hpux10-20.h (RUN_TIME_REMAP):
211 * s/bsd-common.h (TABDLY): Move to configure.
212
213 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
214
215 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
216
ea0bbd17 217 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 218 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
219
220 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 221
308aab79
GM
222 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
223 * s/template.h: Move NARROWPROTO to configure.
224
ee1cf5cf
GM
2252012-07-11 Glenn Morris <rgm@gnu.org>
226
30fe9bf4
GM
227 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
228 unused since 2011-01-17 change to systty.h.
229
ee1cf5cf
GM
230 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
231 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
232 Move HAVE_PTYS and HAVE_SOCKETS to configure.
233
63e47e07
PE
2342012-07-11 Paul Eggert <eggert@cs.ucla.edu>
235
236 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
237
c43fb4c3
GM
2382012-07-11 Glenn Morris <rgm@gnu.org>
239
240 * s/darwin.h, s/gnu-linux.h, s/template.h:
241 Move INTERRUPT_INPUT to configure.
242
e8df9267
DA
2432012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
244
245 Minor adjustments to interning code.
246 * lisp.h (intern, intern_c_string): Redefine as static inline
247 wrappers for intern_1 and intern_c_string_1, respectively.
248 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
249 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
250 Vobarray checking.
e8df9267
DA
251 * font.c (font_intern_prop): Likewise. Adjust comment.
252 * w32font.c (intern_font_name): Likewise.
253
34348bd4
AS
2542012-07-11 Andreas Schwab <schwab@linux-m68k.org>
255
d96a1e0c
AS
256 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
257
34348bd4
AS
258 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
259 of Fcar/Fcdr if possible.
260 * font.c (check_otf_features): Likewise.
261 * fontset.c (Fnew_fontset): Likewise.
262 * gnutls.c (Fgnutls_boot): Likewise.
263 * minibuf.c (read_minibuf): Likewise.
264 * msdos.c (IT_set_frame_parameters): Likewise.
265 * xmenu.c (Fx_popup_dialog): Likewise.
266 * w32menu.c (Fx_popup_dialog): Likewise.
267
c8add24e
GM
2682012-07-11 Glenn Morris <rgm@gnu.org>
269
4b575b3c
GM
270 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
271 since nothing has defined it on these platforms.
272
09f4e3b0
GM
273 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
274 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
275
172bedef
GM
276 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
277 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
278 Move CLASH_DETECTION to configure.
279
249685df
GM
280 * s/gnu.h: Remove file, which is now empty.
281
c8add24e
GM
282 * s/gnu.h, s/gnu-linux.h:
283 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
284
b41253a3
JW
2852012-07-11 John Wiegley <johnw@newartisans.com>
286
287 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
288 function attribute, so we only use it if it exists in the
289 compiler.
290
d923b542
DA
2912012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Avoid call to strlen in fast_c_string_match_ignore_case.
294 * search.c (fast_c_string_match_ignore_case): Change to use
295 length argument. Adjust users accordingly.
296 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
297
5ebbef1d
PE
2982012-07-11 Paul Eggert <eggert@cs.ucla.edu>
299
bb352260
PE
300 Assume mkdir, rmdir.
301 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
302 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
303
57054ddd
PE
304 Assume rename.
305 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
306
b747d3f7
PE
307 Assume perror.
308 * s/hpux10-20.h (HAVE_PERROR): Remove.
309 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
310 Remove dummy definition, as this problem was obsolete long ago.
311
5ebbef1d
PE
312 Assume strerror.
313 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
314
984e7f30
DA
3152012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
316
317 Avoid calls to strlen in font processing functions.
318 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 319 (font_open_by_name): Change to use length argument. Adjust
984e7f30 320 users accordingly.
d923b542
DA
321 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
322 Adjust prototypes.
323 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
324 Change to return ptrdiff_t.
984e7f30
DA
325 (xfont_list_pattern, xfont_match): Use length returned by
326 xfont_decode_coding_xlfd.
327 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
328
20e94fdd
GM
3292012-07-11 Glenn Morris <rgm@gnu.org>
330
9d596af3
GM
331 * s/darwin.h, s/freebsd.h, s/netbsd.h:
332 Move DONT_REOPEN_PTY to configure.
333
20e94fdd
GM
334 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
335 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
336
e99a530f
PE
3372012-07-10 Paul Eggert <eggert@cs.ucla.edu>
338
22ffb973
PE
339 Remove "#define unix" that is no longer needed (Bug#11905).
340 * s/aix4-2.h (unix): Remove; no longer needed.
341
e9a9ae03
PE
342 EMACS_TIME simplification (Bug#11875).
343 This replaces macros (which typically do not work in GDB)
344 with functions, typedefs and enums, making the code easier to debug.
345 The functional style also makes code easier to read and maintain.
346 * systime.h: Include <sys/time.h> on all hosts, not just if
347 WINDOWSNT, since 'struct timeval' is needed in general.
348 (EMACS_TIME): Now a typedef, not a macro.
349 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
350 not macros.
351 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
352 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
353 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
354 (EMACS_TIME_LE): Now functions, not macros.
355 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
356 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
357 which are not functions. All uses rewritten to use:
358 (make_emacs_time): New function.
359 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
360 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
361 not functions. All uses rewritten to use the following, respectively:
362 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
363 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 364 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
365 * fileio.c (Fcopy_file):
366 * xterm.c (XTflash): Get the current time closer to when it's used.
367 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
368
ffacb126
PE
369 * bytecode.c (targets): Suppress -Woverride-init warnings.
370
e99a530f
PE
371 Simplify by avoiding confusing use of strncpy etc.
372 * doc.c (Fsnarf_documentation):
373 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
374 * frame.c (Fmake_terminal_frame):
375 * gtkutil.c (get_utf8_string):
376 * lread.c (openp):
377 * nsmenu.m (ns_update_menubar):
378 * regex.c (regerror):
379 Prefer memcpy to strncpy and strncat when either will do.
380 * fileio.c (Fsubstitute_in_file_name):
381 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
382 (menu_separator_name_p):
383 * nsmenu.m (ns_update_menubar):
384 Prefer memcmp to strncmp when either will do.
385 * nsterm.m: Include <ftoastr.h>.
386 (ns_get_color):
387 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
388 Prefer snprintf to strncpy.
389 * nsterm.m (ns_term_init):
390 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
391 * nsterm.m (ns_term_init):
392 Avoid the need for strncpy, by using build_string or
393 make_unibyte_string directly. Use dtoastr, not snprintf.
394 * process.c (Fmake_network_process): Diagnose service names that
395 are too long, rather than silently truncating them or creating
396 non-null-terminated names.
397 (Fnetwork_interface_info): Likewise, for interface names.
398 * sysdep.c (system_process_attributes) [GNU_LINUX]:
399 Prefer sprintf to strncat.
400 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
401 Prefer vsnprintf to vsprintf + strncpy.
402
c59592b3
GM
4032012-07-10 Glenn Morris <rgm@gnu.org>
404
405 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
406 Clarify fallback case.
407
7d7bbefd
DA
4082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
409
410 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
411 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
412 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 413 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
414 where argument type is known to be a Lisp_Cons.
415
3a4c8000
TT
4162012-07-10 Tom Tromey <tromey@redhat.com>
417
418 * bytecode.c (BYTE_CODE_THREADED): New macro.
419 (BYTE_CODES): New macro. Replaces all old byte-code defines.
420 (enum byte_code_op): New type.
421 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
422 (exec_byte_code): Use them. Use token threading when applicable.
423
2a0213a6
DA
4242012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
425
426 Optimize pure C strings initialization.
427 * lisp.h (make_pure_string): Fix prototype.
428 (build_pure_c_string): New function, defined as static inline. This
429 provides a better opportunity to optimize away calls to strlen when
430 the function is called with compile-time constant argument.
431 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
432 argument, adjust users accordingly. Use build_pure_c_string where
433 appropriate.
434 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
435 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
436 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
437
cb1caeaf
DA
4382012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
439
440 Avoid calls to strlen in miscellaneous functions.
441 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
442 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
443 * lread.c (openp): Likewise.
444
c293e30c
DA
4452012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
446
447 Avoid calls to strlen in path processing functions.
448 * fileio.c (file_name_as_directory): Add comment. Change to add
449 srclen argument and return the length of result. Adjust users
450 accordingly.
451 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 452 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
453 users accordingly.
454 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
455
9e059e3f
GM
4562012-07-10 Glenn Morris <rgm@gnu.org>
457
d02eb359
GM
458 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
459 Move PENDING_OUTPUT_COUNT definition to configure.
460
882cf227
GM
461 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
462 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
463 * s/gnu.h (DATA_START): Move definitions to configure.
464
af6e839f
GM
465 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
466 We include usg5-4-common.h, which defines them both.
467
40289a12
GM
468 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
469 O_RDONLY already includes it).
470
9e059e3f
GM
471 Stop ns builds setting the EMACSLOADPATH environment variable.
472 * nsterm.m (ns_load_path): Rename from ns_init_paths.
473 Now it does not set EMACSLOADPATH, just returns the load-path string.
474 * nsterm.h: Update accordingly.
475 * lread.c [HAVE_NS]: Include nsterm.h.
476 (init_lread) [HAVE_NS]: Use ns_load_path.
477 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
478
7c4e8ec0
GM
4792012-07-09 Glenn Morris <rgm@gnu.org>
480
d4f600ff
GM
481 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
482 since the included bsd-common.h does so.
483
cbb31951
GM
484 Stop ns builds setting the EMACSPATH environment variable.
485 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
486 (ns_init_paths): Do not set EMACSPATH.
487 * nsterm.h (ns_exec_path): Add it.
488 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
489 Use ns_exec_path.
490
7c4e8ec0
GM
491 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
492
26bccfae
PE
4932012-07-09 Paul Eggert <eggert@cs.ucla.edu>
494
a0bee46f
PE
495 * process.c (wait_reading_process_output): 'waitchannels' was unset
496 when read_kbd || !NILP (wait_for_cell); fix this.
497
5994c183
PE
498 Add GCC-style 'const' attribute to functions that can use it.
499 * character.h (char_resolve_modifier_mask):
500 * keyboard.h (make_ctrl_char):
501 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
502 (init_character_once, next_almost_prime, init_fns, init_image)
503 (flush_pending_output, init_sound):
504 * mem-limits.h (start_of_data):
505 * menu.h (finish_menu_items):
506 Add ATTRIBUTE_CONST.
507 * emacs.c (DEFINE_DUMMY_FUNCTION):
508 Declare the dummy function with ATTRIBUTE_CONST.
509 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
510 Add decls with ATTRIBUTE_CONST.
511
26bccfae
PE
512 Minor improvements to make_formatted_string.
513 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
514 where int is good enough, as vsprintf returns an int.
515 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
516
a8290ec3
DA
5172012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
518
519 Use make_formatted_string to avoid double length calculation.
520 * lisp.h (make_formatted_string): New prototype.
521 * alloc.c (make_formatted_string): New function.
522 * buffer.c (Fgenerate_new_buffer_name): Use it.
523 * dbus.c (syms_of_dbusbind): Likewise.
524 * editfns.c (Fcurrent_time_zone): Likewise.
525 * filelock.c (get_boot_time): Likewise.
526 * frame.c (make_terminal_frame, set_term_frame_name)
527 (x_report_frame_params): Likewise.
528 * image.c (gs_load): Likewise.
529 * minibuf.c (get_minibuffer): Likewise.
530 * msdos.c (dos_set_window_size): Likewise.
531 * process.c (make_process): Likewise.
532 * xdisp.c (ensure_echo_area_buffers): Likewise.
533 * xsettings.c (apply_xft_settings): Likewise.
534
d01ba2f1
GM
5352012-07-09 Glenn Morris <rgm@gnu.org>
536
537 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
538 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
539 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
540 * nsterm.h (ns_etc_directory): Add it.
541 * callproc.c [HAVE_NS]: Include nsterm.h.
542 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
543
f1f924b6
DA
5442012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
545
546 Move marker debugging code under MARKER_DEBUG.
547 * marker.c (MARKER_DEBUG): Move marker debugging code under
548 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
549 for bootstrap with --enable-checking (~3x slowdown reported
550 by Juanma Barranquero <lekktu@gmail.com>).
551 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
552
ab531b66
PE
5532012-07-08 Paul Eggert <eggert@cs.ucla.edu>
554
555 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
556 See <http://bugs.gnu.org/11825#29>.
557
c4b3bc8a
EZ
5582012-07-08 Eli Zaretskii <eliz@gnu.org>
559
560 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
561 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
562 (display_line): Add commentary about displaying truncation glyphs
563 on GUI frames.
564 (produce_special_glyphs): Move here from term.c.
565
566 * term.c (produce_special_glyphs): Move to xdisp.c.
567
568 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
569 section.
c4b3bc8a 570
b676b881
AS
5712012-07-07 Andreas Schwab <schwab@linux-m68k.org>
572
f17c5273
AS
573 * xdisp.c (display_line): Avoid warning about implicit declaration
574 of FRAME_FONT.
575
298819b9
AS
576 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
577
b676b881
AS
578 * lisp.h: Remove empty conditional.
579
6045c4fd
PE
5802012-07-07 Paul Eggert <eggert@cs.ucla.edu>
581
b3350bf9
PE
582 * lread.c (load_path_check): Now static.
583
6045c4fd
PE
584 Fix some minor --with-ns problems found by static checking.
585 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
586 (x_set_font) [!HAVE_X_WINDOWS]:
587 * image.c (xpm_load_image) [HAVE_NS]:
588 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
589 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
590 Remove unused local.
591 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
592 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
593 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
594 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
595 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
596 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
597 Fix pointer signedness problem.
598 * xfaces.c (FRAME_X_FONT_TABLE):
599 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
600
929e7845
GM
6012012-07-07 Glenn Morris <rgm@gnu.org>
602
603 * lread.c (load_path_check): New function, split from init_lread.
604 (init_lread): Reorganize. Motivation:
605 If EMACSLOADPATH is set, check/warn about that rather than the
606 defaults, which we are not going to use. Hence we can remove
607 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
608 Don't warn if site-lisp directories are missing.
609 If not installed, start from a blank load-path, since
610 PATH_LOADSEARCH refers to the eventual installation directories.
611
58dd0aa4
EZ
6122012-07-07 Eli Zaretskii <eliz@gnu.org>
613
614 Support truncation and continuation glyphs on GUI frames, when
615 fringes are disabled. (Bug#11832)
616 * xdisp.c (init_iterator): Get dimensions of truncation and
617 continuation glyphs even if on GUI frames. Adjust
618 it->last_visible_x on GUI frames when the left or right fringes,
619 or both, are absent.
620 (start_display, move_it_in_display_line_to): Handle the case of a
621 GUI frame without a fringe to display continuation or truncation
622 glyphs.
623 (insert_left_trunc_glyphs): Support GUI frames: make sure
624 truncation glyphs overwrite enough glyphs from the current line to
625 have sufficient space in pixels.
626 (display_line): Support truncation and continuation glyphs on GUI
627 frames. If some spare pixels are left on the line after inserting
628 the truncation glyphs, fill that space with a stretch glyph of a
629 suitably computed width.
630
631 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
632 produce_glyphs, to support GUI sessions.
633
31571fd7
PE
6342012-07-07 Paul Eggert <eggert@cs.ucla.edu>
635
5a16b9bc
PE
636 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
637
f3047c75
PE
638 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
639
31571fd7
PE
640 Do not require float-time's arg to fit in time_t (Bug#11825).
641 This works better on hosts where time_t is unsigned, and where
642 float-time is applied to the (negative) difference between two times.
643 * editfns.c (decode_time_components): Last arg is now double *,
644 not int *, and means to store all the result as a double, without
645 worrying about whether the seconds part fits in time_t.
646 All callers changed.
647 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
648 All callers changed.
649 (Ffloat_time): Do not fail merely because the specified time falls
650 outside of time_t range.
651
4516fbef
GM
6522012-07-07 Glenn Morris <rgm@gnu.org>
653
654 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
655 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
656 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
657
07adc2c6
JB
6582012-07-07 Juanma Barranquero <lekktu@gmail.com>
659
660 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
661 Update dependencies.
662
663 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
664
fd573f31
PE
6652012-07-06 Paul Eggert <eggert@cs.ucla.edu>
666
fee5959d
PE
667 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
668 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
669 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
670 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
671 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
672 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
673
fd573f31
PE
674 * xfont.c (compare_font_names): Redo to omit the need for casts.
675
ddadbc0e
AS
6762012-07-06 Andreas Schwab <schwab@linux-m68k.org>
677
fca8d6b6
AS
678 * xfns.c (Fx_change_window_property): Doc fix.
679 * w32fns.c (Fx_change_window_property): Doc fix.
680
ddadbc0e
AS
681 * w32fns.c (Fx_window_property): Accept the same arguments as the
682 X Windows version. Doc fix.
683 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
684
ed9265fc 6852012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
686 Eli Zaretskii <eliz@gnu.org>
687
688 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
689 Windows-specific code from nt/config.nt moved here.
690 Obsolete settings removed.
691
216ee680
PE
6922012-07-06 Paul Eggert <eggert@cs.ucla.edu>
693
694 * process.c: Avoid unnecessary calls to gettime.
695 (wait_reading_process_output): Don't get the time of day
696 when gobbling data immediately and not waiting, as there's no need
697 for it in that case. This removes a FIXME.
698
bdd091e4
JD
6992012-07-06 Jan Djärv <jan.h.d@swipnet.se>
700
701 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
702 is defined (Bug#11768).
703
9d44f8ce
DA
7042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
705
706 Fix marker debugging code.
707 * marker.c (byte_char_debug_check): Do not perform the check
708 if buffer is not multibyte.
090bd7cb
JB
709 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
710 Call byte_char_debug_check with correct arguments.
9d44f8ce 711
90fc4786
DA
7122012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
713
714 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
715 * marker.c (byte_char_debug_check, count_markers):
716 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
717 (byte_debug_flag): Remove.
718 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
719 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
720
7b7ae965
DA
7212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
722
4e57b342
DA
723 Avoid code repetition in marker-related functions.
724 * marker.c (attach_marker): New function.
725 (Fset_marker, set_marker_restricted, set_marker_both)
726 (set_marker_restricted_both): Use it.
727 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
728 Consistently rename charno to charpos.
729 (marker_position): Add eassert.
730 (marker_byte_position): Convert to eassert.
731
7322012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
733
734 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 735 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 736 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 737
657924ff
DA
7382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
739
740 Introduce fast path for the widely used marker operation.
741 * alloc.c (build_marker): New function.
742 * lisp.h (build_marker): New prototype.
743 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
744 * composite.c (autocmp_chars): Likewise.
745 * editfns.c (buildmark): Remove.
746 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
747 (save_restriction_save): Use build_marker.
748 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
749 * window.c (save_window_save): Likewise.
750
041a49a6
DA
7512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
752
753 Do not use Fdelete_overlay in delete_all_overlays
754 to avoid redundant calls to unchain_overlay.
755 * buffer.c (drop_overlay): New function.
756 (delete_all_overlays, Fdelete_overlay): Use it.
757 * minibuf.c (get_minibuffer): Fix comment.
758
7dca65a4
PE
7592012-07-06 Paul Eggert <eggert@cs.ucla.edu>
760
761 Port to OpenBSD 5.1 amd64.
762 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
763 This is needed for OpenBSD, and should be harmless on all BSD systems.
764 Also, include <sys/sysctl.h>, as it should be available on all
765 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
766 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
767 use p_pid member, not kp_proc.pid.
768
8eb876e2
GM
7692012-07-06 Glenn Morris <rgm@gnu.org>
770
771 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
772
38182d90
PE
7732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
774
775 More xmalloc and related cleanup.
776 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
777 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
778 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
779 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
780 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
781 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
782 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
783 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
784 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
785 * xterm.c:
786 Omit needless casts involving void * pointers and allocation.
787 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
788 as the former is more robust if P's type is changed.
789 Prefer xzalloc to xmalloc + memset 0.
790 Simplify malloc-or-realloc to realloc.
791 Don't worry about xmalloc returning a null pointer.
792 Prefer xstrdup to xmalloc + strcpy.
793 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
794 growing it.
795 * keyboard.c (apply_modifiers_uncached): Prefer local array to
796 alloca of a constant.
797
6dd5a677
EZ
7982012-07-05 Eli Zaretskii <eliz@gnu.org>
799
800 * xdisp.c (display_line): Fix horizontal pixel coordinates when
801 hscroll is larger than the line width. Fixes long and futile
802 looping inside extend_face_to_end_of_line (on a TTY) producing
803 glyphs that are not needed and thrown away.
804
6b312f0f
DA
8052012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
806
807 * marker.c (set_marker_restricted_both): Simplify by using
808 clip_to_bounds.
809
f520ef9b
PE
8102012-07-05 Paul Eggert <eggert@cs.ucla.edu>
811
812 * editfns.c (region_limit): Simplify by using clip_to_bounds.
813
383b7c95
JD
8142012-07-05 Jan Djärv <jan.h.d@swipnet.se>
815
816 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
817 not defined (Bug#11768).
818 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
819 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
820 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
821 followed by gtk_box_set_homogeneous (Bug#11768).
822 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
823 (update_theme_scrollbar_width, xg_create_scroll_bar):
824 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
825 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
826 (is_box_type): New function (Bug#11768).
827 (xg_tool_item_stale_p): Call is_box_type.
5293d758 828 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
829 with default display (Bug#11768).
830
d6e7bf45
EZ
8312012-07-05 Eli Zaretskii <eliz@gnu.org>
832
833 * xdisp.c (window_hscroll_limited): New function.
834 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
835 coordinates when window's hscroll is set to insanely large
836 values. (Bug#11857)
837
431391ec
JB
8382012-07-05 Juanma Barranquero <lekktu@gmail.com>
839
840 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
841 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
842
23f86fce
DA
8432012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
844
845 Cleanup xmalloc.
846 * lisp.h (xzalloc): New prototype. Omit needless casts.
847 * alloc.c (xzalloc): New function. Omit needless casts.
848 * charset.c: Omit needless casts. Convert all calls to
849 xmalloc with following memset to xzalloc.
850 * dispnew.c: Likewise.
851 * fringe.c: Likewise.
852 * image.c: Likewise.
853 * sound.c: Likewise.
854 * term.c: Likewise.
855 * w32fns.c: Likewise.
856 * w32font.c: Likewise.
857 * w32term.c: Likewise.
858 * xfaces.c: Likewise.
859 * xfns.c: Likewise.
860 * xterm.c: Likewise.
861 * atimer.c: Omit needless casts.
862 * buffer.c: Likewise.
863 * callproc.c: Likewise.
864 * ccl.c: Likewise.
865 * coding.c: Likewise.
866 * composite.c: Likewise.
867 * doc.c: Likewise.
868 * doprnt.c: Likewise.
869 * editfns.c: Likewise.
870 * emacs.c: Likewise.
871 * eval.c: Likewise.
872 * filelock.c: Likewise.
873 * fns.c: Likewise.
874 * gtkutil.c: Likewise.
875 * keyboard.c: Likewise.
876 * lisp.h: Likewise.
877 * lread.c: Likewise.
878 * minibuf.c: Likewise.
879 * msdos.c: Likewise.
880 * print.c: Likewise.
881 * process.c: Likewise.
882 * region-cache.c: Likewise.
883 * search.c: Likewise.
884 * sysdep.c: Likewise.
885 * termcap.c: Likewise.
886 * terminal.c: Likewise.
887 * tparam.c: Likewise.
888 * w16select.c: Likewise.
889 * w32.c: Likewise.
890 * w32reg.c: Likewise.
891 * w32select.c: Likewise.
892 * w32uniscribe.c: Likewise.
893 * widget.c: Likewise.
894 * xdisp.c: Likewise.
895 * xmenu.c: Likewise.
896 * xrdb.c: Likewise.
897 * xselect.c: Likewise.
898
0497dc44
PE
8992012-07-05 Paul Eggert <eggert@cs.ucla.edu>
900
901 * fileio.c (time_error_value): Check the right error number.
902 Problem reported by Troels Nielsen in
903 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
904
356e7178
PE
9052012-07-04 Paul Eggert <eggert@cs.ucla.edu>
906
4e71fd89
PE
907 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
908 This should be fixed in a better way; see Eli Zaretskii in
909 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
910 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
911
f0941253
PE
912 * fileio.c (time_error_value): Rename from special_mtime.
913 The old name's problems were noted by Eli Zaretskii in
914 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
915
065c9eb4
PE
916 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
917 This variable's comment says Emacs needs at least one GDB-visible
918 symbol of type enum pvec_type, to work around GDB problems.
919 The symbol's value doesn't matter.
920
356e7178
PE
921 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
922 that causes compilation to fail on pre-C99 compilers.
923
ed9265fc 9242012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
925
926 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
927 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
928
3884d954
DA
9292012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
930
d209e2fb 931 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
932 headers for buffer_defaults and buffer_local_symbols.
933 Reported by Juanma Barranquero <lekktu@gmail.com>.
934
ee28be33
SM
9352012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
938 * lisp.h (enum pvec_type): Use fewer bits.
939 (PSEUDOVECTOR_SIZE_BITS): New constant.
940 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
941 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
942 change in pvec_type.
943 (PSEUDOVECTOR_TYPEP): New macro.
944 (TYPED_PSEUDOVECTORP): Use it.
945 * fns.c (internal_equal): Adapt code to extract pvectype.
946 * emacs.c (gdb_pvec_type): Update type.
947 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
948 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
949 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
950 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
951 (sweep_vectors): Use it. Use local var `total_bytes' instead of
952 abusing vector->header.next.nbytes.
953 (live_vector_p): Use PVEC_TYPE.
954 (mark_object): Adapt code to extract pvectype. Use switch.
955
c7f2cd7f
PE
9562012-07-04 Paul Eggert <eggert@cs.ucla.edu>
957
958 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
959 Tighten new eassert a bit.
960
8ce70ed2
DA
9612012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
962
963 Fix compilation with --enable-gcc-warnings and -O1
964 optimization level.
965 * doprnt.c (doprnt): Change type of tem to int, initialize
966 to avoid compiler warning. Add eassert.
967 * search.c (simple_search): Initialize match_byte to avoid
968 compiler warning. Add eassert.
969
dea7f1e5
PE
9702012-07-04 Paul Eggert <eggert@cs.ucla.edu>
971
24a212eb
PE
972 Avoid weird behavior with large horizontal scrolls.
973 Without this change, for example, large hscroll values would
974 mess up Emacs's display on Fedora 15 x86, presumably due to
975 overflows in int calculations in the display code.
976 Also, if buffers had long lines, Emacs would freeze.
977 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
978 (set_window_hscroll): New function, containing the old guts of
979 Fset_window_hscroll. Return the clipped value.
980 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
981 This avoids the need to check against PTRDIFF_MAX.
982
dea7f1e5
PE
983 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
984
76046526
DA
9852012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
986
987 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
988
39adff0d
PE
9892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
990
63807d47
PE
991 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
992 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
993 since GCC 4.4.6 issues a bogus warning for them.
994
39adff0d
PE
995 Fix bugs in file timestamp newness comparisons.
996 * fileio.c (Ffile_newer_than_file_p):
997 * lread.c (Fload): Use full timestamp resolution of files,
998 not just the 1-second resolution, so that files that are only
999 slightly newer still count as newer.
1000 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1001 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1002
dbeed9a6
PE
10032012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 * fileio.c: Improve handling of file time marker. (Bug#11852)
1006 (special_mtime): New function.
1007 (Finsert_file_contents, Fverify_visited_file_modtime):
1008 Use it to set special mtime values consistently.
1009
636334d6
AS
10102012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1011
1012 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1013 marker for non-existing file. (Bug#11852)
1014
e2017fe2
GM
10152012-07-03 Glenn Morris <rgm@gnu.org>
1016
1017 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1018 and did not make it into globals.h).
1019
404dbd37
TT
10202012-07-03 Tom Tromey <tromey@redhat.com>
1021
1022 * window.c (Fset_window_margins, Fset_window_fringes)
1023 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1024 * textprop.c (Fprevious_property_change): No longer static.
1025 * syntax.c (Fsyntax_table_p): No longer static.
1026 * process.c (Fget_process, Fprocess_datagram_address): No longer
1027 static.
1028 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1029 * keyboard.c (Fcommand_execute): No longer static.
1030 Remove EXFUN.
1031 * insdel.c (Fcombine_after_change_execute): No longer static.
1032 * image.c (Finit_image_library): No longer static.
1033 * fileio.c (Fmake_symbolic_link): No longer static.
1034 * eval.c (Ffetch_bytecode): No longer static.
1035 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1036 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1037 No longer static.
404dbd37
TT
1038 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1039 static.
1040 * dired.c (Ffile_attributes): No longer static.
1041 * composite.c (Fcomposition_get_gstring): No longer static.
1042 * callproc.c (Fgetenv_internal): No longer static.
1043
1044 * ccl.h: Remove EXFUNs.
1045 * buffer.h: Remove EXFUNs.
1046 * dispextern.h: Remove EXFUNs.
1047 * intervals.h: Remove EXFUNs.
1048 * fontset.h: Remove EXFUN.
1049 * font.h: Remove EXFUNs.
1050 * dosfns.c (system_process_attributes): Remove EXFUN.
1051 * keymap.h: Remove EXFUNs.
1052 * lisp.h: Remove EXFUNs.
1053 * w32term.h: Remove EXFUNs.
1054 * window.h: Remove EXFUNs.
1055 * xsettings.h: Remove EXFUN.
1056 * xterm.h: Remove EXFUN.
1057
8e4fd1e1
GM
10582012-07-03 Glenn Morris <rgm@gnu.org>
1059
1060 * lisp.h (Frandom): Make it visible to C.
1061 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1062 buffer for invisible buffers. (Bug#1229)
1063
ca95b3eb
DA
10642012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1065
1066 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1067 values which aren't power of 2.
1068 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1069 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1070 accordingly.
1071
7555c33f
SM
10722012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1073
1074 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1075
1076 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1077
d12e8f5a
DA
10782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1079
1080 * alloc.c (allocate_vector_block): Remove redundant
1081 calls to mallopt if DOUG_LEA_MALLOC is defined.
1082 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1083 avoid calls to mallopt if zero_vector is returned.
1084
296094c3
DA
10852012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1086
1087 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1088 is enabled, avoid dereferencing NULL current_sblock if
1089 running undumped.
1090
36429c89
DA
10912012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1092
1093 Cleanup basic buffer management.
1094 * buffer.h (struct buffer): Change layout to use generic vector
1095 marking code. Fix some comments. Change type of 'clip_changed'
1096 to bitfield. Remove unused #ifndef old.
1097 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1098 (GET_OVERLAYS_AT): Fix indentation.
1099 (for_each_per_buffer_object_at): New macro.
1100 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1101 (Fbuffer_local_variables): Use it.
1102 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1103 * alloc.c (allocate_buffer): Adjust to match new layout of
1104 struct buffer. Fix comment.
1105 (mark_overlay): New function.
1106 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1107 Lisp area of struct buffer.
1108 (mark_object): Use it. Adjust marking of misc objects
1109 and related comments.
1110
3b3e4cac
PE
11112012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1112
1113 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1114 wrapper that is not needed because the wrapped code is a no-op (zero
1115 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1116 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1117
cf5c0175
DA
11182012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1119
1120 * alloc.c (mark_buffer): Simplify. Remove prototype.
1121 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1122 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1123 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1124 redundant calls to mark_vectorlike for bool vectors.
1125
ca26824c
GM
11262012-06-30 Glenn Morris <rgm@gnu.org>
1127
2e4c5312
GM
1128 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1129
ca26824c
GM
1130 * epaths.in (PATH_SITELOADSEARCH): New.
1131 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1132 This is rather than relying on --enable-locallisppath elements
1133 having "site-lisp" in their names. (Bug#10208#25, 11658)
1134
0d23c240
EZ
11352012-06-30 Eli Zaretskii <eliz@gnu.org>
1136
c9240d7a
EZ
1137 * w32proc.c (sys_select): Accept and ignore one more argument.
1138
1139 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1140
0d23c240 1141 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1142 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1143
1144 * sysdep.c: Don't include dos.h and dosfns.h.
1145
1146 * process.c (sys_select):
1147 * msdos.c (sys_select): Accept one more argument and ignore it.
1148
1149 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1150 adapt data types and code to that.
1151
1152 * dosfns.c:
1153 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1154 which clashes with the gnulib function of the same name.
1155
af5a5a98
AS
11562012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1157
c5e4379c
AS
1158 * font.c (font_style_to_value, font_style_symbolic)
1159 (font_prop_validate_style): Add type checks for values in
1160 font_style_table.
1161
af5a5a98
AS
1162 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1163 argument.
1164 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1165 uses.
1166
8d38f461
EZ
11672012-06-29 Eli Zaretskii <eliz@gnu.org>
1168
2e5a6631
EZ
1169 * xdisp.c (try_window_id): Undo last change.
1170
8d38f461
EZ
1171 * w32.c (getwd): Adjust commentary about startup_dir.
1172 (init_environment): Always call sys_access, even in non-MSVC
1173 builds. Don't chdir to the directory of the Emacs executable.
1174 This undoes code from 1997 which was justified by the need to
1175 "avoid conflicts when removing and renaming directories". But its
1176 downside was that every relative file name was being interpreted
1177 relative to the directory of the Emacs executable, which can never
1178 be TRT. In particular, it broke sys_access when called with
1179 relative file names.
1180 (sys_access): Map GetLastError to errno.
1181
2af3565e
DA
11822012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1183
1184 * window.h (struct window): Change type of 'fringes_outside_margins'
1185 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1186 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1187 Adjust comment.
1188 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1189 to ptrdiff_t.
1190
c8d3a25c 11912012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1192
c8d3a25c
GM
1193 * gnutls.c (emacs_gnutls_handshake):
1194 Add QUIT to make the loop interruptible.
57570cd3 1195
c8d3a25c 11962012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1197
c8d3a25c
GM
1198 * charset.c (init_charset): Make lack of etc/charsets fatal.
1199
3e984ee8
DA
12002012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1201
1202 * editfns.c (region_limit): Fix type mismatch.
1203
ef884f23
DA
12042012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1205
1206 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1207 undefined. Convert from xassert to eassert.
1208 * nsmenu.m: Convert from xassert to eassert.
1209 * nsterm.m: Likewise.
1210
7d7e0027
SM
12112012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1212
1213 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1214
aa754e6a
PE
12152012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1216
1217 Avoid integer overflow on scroll-left and scroll-right.
1218 * window.c (HSCROLL_MAX): New macro.
1219 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1220 overflow when requested scroll falls outside ptrdiff_t range.
1221
80b00b08
DA
12222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 * window.h (struct window): Change type of 'hscroll',
1225 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1226 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1227 Adjust users accordingly.
1228 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1229 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1230 from EMACS_INT to ptrdiff_t.
1231 (make_window): Omit redundant initialization.
1232
62b2bcf6
JB
12332012-06-28 Juanma Barranquero <lekktu@gmail.com>
1234
1235 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1236
45942c7d
DA
12372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1238
1239 * window.h (struct window): Change type of 'use_time' and
1240 'sequence_number' from Lisp_Object to int.
1241 * frame.c (make_frame): Adjust users accordingly.
1242 * print.c (print_object): Likewise.
1243 * window.c (select_window, Fwindow_use_time, make_parent_window)
1244 (make_window): Likewise.
1245
e509cfa6
DA
12462012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1247
1248 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1249 enabled with --enable-checking=[all,glyphs] configure option.
1250 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1251 adjust comments accordingly.
1252 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1253 undefined, adjust comments accordingly.
1254 * image.c: Likewise.
1255 * scroll.c: Likewise.
1256 * w32fns.c: Likewise.
1257 * w32term.c: Likewise.
1258 * xdisp.c: Likewise.
1259 * xfaces.c: Likewise.
1260 * xfns.c: Likewise.
1261 * xterm.c: Likewise.
1262
a54e2c05
DA
12632012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1264
1265 Generalize run-time debugging checks.
1266 * dispextern.h (XASSERTS): Remove.
1267 * fontset.c (xassert): Remove.
1268 Convert from xassert to eassert.
1269 * alloc.c: Convert from xassert to eassert.
1270 * bidi.c: Likewise.
1271 * dispnew.c: Likewise.
1272 * fns.c: Likewise.
1273 * fringe.c: Likewise.
1274 * ftfont.c: Likewise.
1275 * gtkutil.c: Likewise.
1276 * image.c: Likewise.
1277 * keyboard.c: Likewise.
1278 * menu.c: Likewise.
1279 * process.c: Likewise.
1280 * scroll.c: Likewise.
1281 * sound.c: Likewise.
1282 * term.c: Likewise.
1283 * w32console.c: Likewise.
1284 * w32fns.c: Likewise.
1285 * w32term.c: Likewise.
1286 * window.c: Likewise.
1287 * xdisp.c: Likewise.
1288 * xfaces.c: Likewise.
1289 * xfns.c: Likewise.
1290 * xselect.c: Likewise.
1291 * xterm.c: Likewise.
1292
1ec4b7b2
SM
12932012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1294
1295 * fns.c (maybe_resize_hash_table): Output message when growing the
1296 purify-hashtable.
1297
2014308a
DA
12982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1299
1300 * alloc.c (allocate_string_data): Remove dead code.
1301 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1302 avoid GCC warning about unused macro.
1303
246155eb
DA
13042012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1305
1306 * alloc.c (allocate_string): Omit intervals initialization.
1307 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1308 as in make_pure_string and make_pure_c_string.
1309
43184b7b
DA
13102012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1311
d209e2fb 1312 * alloc.c (allocate_string): Fix last change.
43184b7b 1313
3fe6dd74
DA
13142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1315
d209e2fb 1316 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1317 to memset, add explicit initialization where appropriate.
1318
1ba6038a
GM
13192012-06-27 Glenn Morris <rgm@gnu.org>
1320
1321 * lisp.mk (lisp): Remove paths.elc.
1322
c89926a5
CY
13232012-06-27 Chong Yidong <cyd@gnu.org>
1324
1325 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1326
ed6b3510
JW
13272012-06-26 John Wiegley <johnw@newartisans.com>
1328
1ec4b7b2 1329 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1330 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1331
ed6b3510
JW
1332 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1333 when building with Clang.
1334
8edd4a2b
SM
13352012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1336
1337 * eval.c (Fapply): Allow calling it with a single argument.
1338
f6f62d1b
EZ
13392012-06-26 Eli Zaretskii <eliz@gnu.org>
1340
1341 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1342 _stricmp and _strnicmp.
1343 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1344
62efea5e
DA
13452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1346
1347 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1348 allocated window.
1349 (allocate_process): Likewise for new process.
8edd4a2b 1350 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1351 (allocate_frame): Likewise.
1352 * frame.c (make_frame): Omit redundant initialization.
1353 * window.c (make_parent_window): Use memset.
1354 (make_window): Omit redundant initialization.
1355 * process.c (make_process): Omit redundant initialization.
1356 * terminal.c (create_terminal): Likewise.
1357
42997f4d
DA
13582012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1359
1360 * term.c (delete_tty): Remove redundant call to memset.
1361
1130ecfc
DA
13622012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1363
1364 * alloc.c: Remove build_string.
1365 * lisp.h: Define build_string as static inline. This provides
1366 a better opportunity to optimize away calls to strlen when the
1367 function is called with compile-time constant argument.
1368 * image.c (imagemagick_error): Convert to build_string.
1369 * w32proc.c (sys_spawnve): Likewise.
1370 * xterm.c (x_term_init): Likewise.
1371
cf38a720
PE
13722012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1373
99027bdd
PE
1374 Use sprintf return value instead of invoking strlen on result.
1375 In the old days this wasn't portable, since some sprintf
1376 implementations returned char *. But they died out years ago and
1377 Emacs already assumes sprintf returns int.
1378 Similarly for float_to_string.
1379 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1380 * ccl.c (ccl_driver):
1381 * character.c (string_escape_byte8):
1382 * data.c (Fnumber_to_string):
1383 * doprnt.c (doprnt):
1384 * print.c (print_object):
1385 * xdisp.c (message_dolog):
1386 * xfns.c (syms_of_xfns):
1387 Use sprintf or float_to_string result to avoid need to call strlen.
1388 * data.c (Fnumber_to_string):
1389 Use make_unibyte_string, since the string must be ASCII.
1390 * lisp.h, print.c (float_to_string): Now returns int length.
1391 * term.c (produce_glyphless_glyph):
1392 Use sprintf result rather than recomputing it.
1393
cf38a720
PE
1394 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1395 * Makefile.in (ALL_CFLAGS):
1396 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1397 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1398
3511c784
DA
13992012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1400
0a08eb21 1401 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1402 strcasecmp if available.
1403 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1404
fb7da12e
AS
14052012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1406
1407 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1408 Avoid comma operator.
1409 * menu.c (push_submenu_start, push_submenu_end)
1410 (push_left_right_boundary, push_menu_pane): Likewise.
1411 * msdos.c (dos_rawgetc): Likewise.
1412
afa2ffd8
DA
14132012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1414
1415 * xfns.c (xic_create_fontsetname): Remove redundant calls
1416 to memset.
1417
b3b4476b
PE
14182012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1419
4495ff38
PE
1420 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1421 sprintf already null-terminates its output.
1422
b3b4476b
PE
1423 * xfns.c (x_window): Remove redundant cast.
1424
b00876c9
DA
14252012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1426
1427 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1428 `const char *' to `char *' to avoid compiler warning.
1429
d188e26b
PE
14302012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1431
885d1d74
PE
1432 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1433 instead of truncating it to 63 (admittedly a generous limit).
1434
d188e26b
PE
1435 * process.c: Fix spelling and caps in comments.
1436
e2f560b1
DN
14372012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1438
e86db54b 1439 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1440 * sysdep.c (setpgrp): Remove definition, not used in this file.
1441
7583a3a1
JB
14422012-06-24 Juanma Barranquero <lekktu@gmail.com>
1443
1444 * makefile.w32-in: Update dependencies.
1445
696056c2
EZ
14462012-06-24 Eli Zaretskii <eliz@gnu.org>
1447
1448 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1449 (SYSTIME_H): Add nt/inc/sys/time.h.
1450
1451 * systime.h [WINDOWSNT]: Include sys/time.h.
1452
1453 * s/ms-w32.h (struct timespec): Definition moved from
1454 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1455
845ca893
PE
14562012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1457
1458 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1459 * buffer.h (buffer_slot_type_mismatch):
1460 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1461 * eval.c (unwind_to_catch):
1462 * image.c (my_png_error, my_error_exit):
1463 * keyboard.c (quit_throw_to_read_char, user_error)
1464 (Fexit_recursive_edit, Fabort_recursive_edit):
1465 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1466 (wrong_type_argument, buffer_overflow, __executable_start)
1467 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1468 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1469 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1470 (fatal):
1471 (child_setup) [!DOS_NT]:
1472 * lread.c (end_of_file_error, invalid_syntax):
1473 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1474 * puresize.h (pure_write_error):
1475 * search.c (matcher_overflow):
1476 * sound.c (sound_perror, alsa_sound_perror):
1477 * sysdep.c, syssignal.h (croak):
1478 * term.c (maybe_fatal, vfatal):
1479 * textprop.c (text_read_only):
1480 * undo.c (user_error):
1481 * unexmacosx.c (unexec_error):
1482 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1483 Use _Noreturn rather than NO_RETURN.
1484 No need for separate decl merely because of _Noreturn.
1485 * sound.c (sound_warning, parse_sound):
1486 Remove unnecessary forward decls.
1487
f1dd8073
PE
14882012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1491 * lisp.h (WAIT_READING_MAX): New macro.
1492 * dispnew.c (Fsleep_for, sit_for):
1493 * keyboard.c (kbd_buffer_get_event):
1494 * process.c (Faccept_process_output):
1495 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1496 This improves on the previous patch, which introduced a bug
1497 when time_t is unsigned and as wide as intmax_t.
1498 See <http://bugs.gnu.org/9000#51>.
1499
b82c1755
EZ
15002012-06-23 Eli Zaretskii <eliz@gnu.org>
1501
1502 * dispnew.c (sit_for, Fsleep_for):
1503 * keyboard.c (kbd_buffer_get_event):
1504 * process.c (Faccept_process_output): Avoid compiler warnings when
1505 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1506
ca300656
JB
15072012-06-23 Juanma Barranquero <lekktu@gmail.com>
1508
049ec95b
JB
1509 * makefile.w32-in: Update dependencies.
1510
ca300656
JB
1511 * w32.c (ltime): Add return type and declare static.
1512 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1513
db7b8d06
PE
15142012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1517 Privately reported by Herbert J. Skuhra.
1518 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1519 All uses changed.
1520 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1521 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1522
0bd8297f
EZ
15232012-06-23 Eli Zaretskii <eliz@gnu.org>
1524
96512555
EZ
1525 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1526 last argument of make_unibyte_string.
1527
0bd8297f
EZ
1528 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1529 language ID in the event parameters.
1530
1531 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1532 event.code, not the obscure "character set ID".
1533
63def6b6
CY
15342012-06-23 Chong Yidong <cyd@gnu.org>
1535
1536 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1537
e8a02204
EZ
15382012-06-23 Eli Zaretskii <eliz@gnu.org>
1539
388cdec0
EZ
1540 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1541 * w32.c (fdutimens): New function.
1542
1543 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1544
1545 * s/ms-w32.h (pselect): Redirect to sys_select.
1546
1547 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1548
e8a02204
EZ
1549 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1550 in the logic of incrementing and decrementing the value of
1551 use_relocatable_buffers.
1552
d054f3fb
PE
15532012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1556 Privately reported by Herbert J. Skuhra.
1557 [__FreeBSD__]: Remove "*/" typo after "#include".
1558 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1559 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1560 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1561 Don't assume EMACS_TIME and struct timeval are the same type.
1562
d35af63c
PE
15632012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1564
1565 Support higher-resolution time stamps (Bug#9000).
1566 The time stamps are only nanosecond-resolution at the C level,
1567 since that's the best that any real-world system supports now.
1568 But they are picosecond-resolution at the Lisp level, as that's
1569 easy, and leaves room for future OS improvements.
1570
1571 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1572 (LIBES): Use it.
1573
1574 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1575 Don't get current time unless it's needed.
1576
1577 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1578 now provides it if it's absent.
1579 (start_atimer): Port to higher-res time stamps.
1580 Check for time stamp overflow. Don't get current time more
1581 often than is needed.
1582
1583 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1584 Include systime.h, not time.h.
1585 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1586
1587 * dired.c: Include stat-time.h.
1588 (Ffile-attributes): File times now have higher resolution.
1589
1590 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1591 (struct image): Timestamp now has higher resolution.
1592
1593 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1594 has at least microseconds now. All uses removed.
1595 (update_frame, update_single_window, update_window, update_frame_1)
1596 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1597
1598 * editfns.c (time_overflow): Now extern.
1599 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1600 (float-time, Fformat_time_string, Fcurrent_time_string)
1601 (Fcurrent_time_zone): Accept and generate higher-resolution
1602 time stamps.
1603 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1604 (decode_time_components, lisp_seconds_argument): New functions.
1605 (make_time): Now static.
1606 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1607 Report an error if the time is invalid, rather than having the caller
1608 do that.
1609
1610 * fileio.c: Include <stat-time.h>
1611 (Fcopy_file): Copy higher-resolution time stamps.
1612 Prefer to set the time stamp via a file descriptor if that works.
1613 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1614 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1615 (Fvisited_file_modtime, Fset_visited_file_modtime):
1616 Support higher-resolution time stamps.
1617
1618 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1619
1620 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1621
1622 * image.c (prepare_image_for_display, clear_image_cache)
1623 (lookup_image): Port to higer-resolution time stamps.
1624
1625 * keyboard.c (start_polling, bind_polling_period):
1626 Check for time stamp overflow.
1627 (read_char, kbd_buffer_get_event, timer_start_idle)
1628 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1629 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1630 Port to higher-resolution time stamps. Do not assume time_t is signed.
1631 (decode_timer): New function. Timers are now vectors of length 9,
1632 not 8, to accommodate the picosecond component.
1633 (timer_check_2): Use it.
1634
1635 * nsterm.m (select_timeout, timeval_subtract): Remove.
1636 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1637 as they're a bit more accurate and handle overflow better.
1638 (ns_select): Change prototype to be compatible with pselect.
1639 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1640 * nsterm.h (ns_select): Adjust prototype.
1641
1642 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1643 us-resolution time stamps.
1644 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1645
1646 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1647
1648 * lisp.h (time_overflow): New decl.
1649 (wait_reading_process_output): First arg is now intmax_t, not int,
1650 to accommodate larger waits.
1651
1652 * process.h (struct Lisp_Process.read_output_delay):
1653 Now counts nanoseconds, not microseconds.
1654 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1655 EMACS_HAS_USECS.
1656 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1657 (wait_reading_process_output):
1658 Port to ns-resolution time stamps.
1659 (Faccept_process_output, wait_reading_process_output):
1660 Check for time stamp overflow. Do not assume time_t is signed.
1661 (select_wrapper): Remove; we now use pselect.
1662 (Fprocess_attributes): Now generates ns-resolution time stamps.
1663
1664 * sysdep.c: Include utimens.h. Don't include utime.h
1665 or worry about struct utimbuf; gnulib does that for us now.
1666 (gettimeofday): Remove; gnulib provides a substitute.
1667 (make_timeval): New function.
1668 (set_file_times): Now sets ns-resolution time stamps.
1669 New arg FD; all uses changed.
1670 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1671 (system_process_attributes):
1672 Now returns ns-resolution time stamp. All uses changed.
1673 Check for time stamp overflow.
1674
1675 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1676 provides a substitute now.
1677
1678 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1679 since it guarantees struct timespec.
1680 (EMACS_TIME): Now struct timespec, so that we can support
1681 ns-resolution time stamps.
1682 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1683 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1684 (EMACS_USECS): Remove.
1685 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1686 so multiply the arg by 1000 before storing it.
1687 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1688 New macros.
1689 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1690 Port to ns-resolution time stamps.
1691 (EMACS_TIME_NEG_P): Remove; replaced by....
1692 (EMACS_TIME_SIGN): New macro.
1693 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1694 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1695 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1696 (make_timeval, make_lisp_time, decode_time_components): New decls.
1697 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1698 that it mishandled time_t overflow. You can't compare by subtracting!
1699 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1700 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1701
1702 * term.c: Include <sys/time.h>.
1703 (timeval_to_Time): New function, for proper overflow wraparound.
1704 (term_mouse_position, term_mouse_click): Use it.
1705
1706 * undo.c (record_first_change): Support higher-resolution time stamps
1707 in the undo buffer.
1708 (Fprimitive_undo): Use them when restoring time stamps.
1709
1710 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1711 (w32_get_internal_run_time):
1712 Port to higher-resolution Emacs time stamps.
1713 (ltime): Now accepts single 64-bit integer, as that's more convenient
1714 for callers.
1715
1716 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1717
1718 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1719 for compatibility with pselect. Support ns-resolution time stamps.
1720
1721 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1722
1723 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1724 Check for time stamp overflow, and support ns-resolution time stamps.
1725
1726 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1727 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1728 (timeval_subtract): Remove; no longer needed.
1729 (XTflash, XTring_bell, x_wait_for_event):
1730 Port to ns-resolution time stamps. Don't assume time_t is signed.
1731
b6a92dfe
CY
17322012-06-22 Chong Yidong <cyd@gnu.org>
1733
1734 * xdisp.c (x_consider_frame_title): Revert last change.
1735
d251c37c
EZ
17362012-06-22 Eli Zaretskii <eliz@gnu.org>
1737
1738 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1739 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1740 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1741 staticidx goes up to 1597 out of 1600 = 0x640.)
1742
f10deafb
PE
17432012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1746 Otherwise, the umask might be mistakenly 0 while handling input signals.
1747
ec6de1e2
SM
17482012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1749
1750 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1751
28be1ada
DA
17522012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1753
1754 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1755 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1756 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1757 access to `contents' member of Lisp_Vector objects with AREF and ASET
1758 where appropriate.
1759
c6bf3022
CY
17602012-06-19 Chong Yidong <cyd@gnu.org>
1761
1762 * frame.c (delete_frame): When selecting a frame on a different
1763 text terminal, do not alter the terminal's top-frame.
1764
1765 * xdisp.c (format_mode_line_unwind_data): Record the target
1766 frame's selected window and its terminal's top-frame.
1767 (unwind_format_mode_line): Restore them.
1768 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1769 Callers changed.
1770 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1771 since tty frames can be explicitly named.
1772 (prepare_menu_bars): Likewise.
1773
1774 * term.c (Ftty_top_frame): New function.
1775
defd4196
PE
17762012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 Port byte-code-meter to modern targets.
1779 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1780 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1781 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1782 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1783 (METER_1, METER_2): Simplify.
1784
1053a871
SM
17852012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1786
1787 * data.c (Fdefalias): Return `symbol' (bug#11686).
1788
b7e8d081
MR
17892012-06-18 Martin Rudalics <rudalics@gmx.at>
1790
1791 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1792 gets killed during executing of this function (Bug#11665).
1793 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1794 (Vkill_buffer_query_functions): In doc-string say that functions
1795 run by this hook should not change the current buffer.
1796
7ea2b339
PE
17972012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 Fix recently-introduced process.c problems found by static checking.
1800 * process.c (write_queue_push, write_queue_pop, send_process):
1801 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1802 (write_queue_pop): Fix pointer signedness problem.
1803 (send_process): Remove unused local.
1804
96a313a1
CY
18052012-06-17 Chong Yidong <cyd@gnu.org>
1806
1807 * xdisp.c (redisplay_internal): No need to redisplay terminal
1808 frames that are not on top.
1809
20ca2e94
TN
18102012-06-17 Troels Nielsen <bn.troels@gmail.com>
1811
1812 * process.c (make_process): Initialize write_queue.
1813 (write_queue_push, write_queue_pop): New functions.
1814 (send_process): Use them to maintain correct ordering of process
1815 writes (Bug#10815).
1816
9a900ca9
PE
18172012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1818
310fbfa8
PE
1819 * lisp.h (eassert): Assume C89 or later.
1820 This removes the need for CHECK.
1821 (CHECK): Remove. Its comments about always evaluating its
1822 argument were confusing, as 'eassert' typically does not evaluate
1823 its argument.
1824
27bb1ca4
PE
1825 * coding.c (produce_chars): Use ptrdiff_t, not int.
1826
9a900ca9
PE
1827 * xterm.c (x_draw_underwave): Check for integer overflow.
1828 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1829
41b7f8bc 18302012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1831
1832 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1833 referenced (Bug#11583).
1834
9b0e3eba
AA
18352012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1836
1837 Implement wave-style variant of underlining.
1838 * dispextern.h (face_underline_type): New enum.
1839 (face): Add field for underline type.
1840 * nsterm.m (ns_draw_underwave): New function.
1841 (ns_draw_text_decoration): Use it.
1842 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1843 New functions.
1844 (x_draw_glyph_string): Use them.
1845 * xfaces.c (Qline, Qwave): New Lisp objects.
1846 (check_lface_attrs, merge_face_ref)
1053a871
SM
1847 (Finternal_set_lisp_face_attribute, realize_x_face):
1848 Handle wave-style underline face attributes.
9b0e3eba
AA
1849 * xterm.c (x_draw_underwave): New function.
1850 (x_draw_glyph_string): Use it.
1851
0fb52f11
JB
18522012-06-16 Juanma Barranquero <lekktu@gmail.com>
1853
1854 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1855 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1856 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1857 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1858 ($(BLD)/w32select.$(O)): Update dependencies.
1859
e5560ff7
AS
18602012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1861
1862 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1863 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1864 * character.c (_fetch_multibyte_char_p): Remove.
1865 * alloc.c: Include "character.h" before "buffer.h".
1866 * bidi.c: Likewise.
1867 * buffer.c: Likewise.
1868 * bytecode.c: Likewise.
1869 * callint.c: Likewise.
1870 * callproc.c: Likewise.
1871 * casefiddle.c: Likewise.
1872 * casetab.c: Likewise.
1873 * category.c: Likewise.
1874 * cmds.c: Likewise.
1875 * coding.c: Likewise.
1876 * composite.c: Likewise.
1877 * dired.c: Likewise.
1878 * dispnew.c: Likewise.
1879 * doc.c: Likewise.
1880 * dosfns.c: Likewise.
1881 * editfns.c: Likewise.
1882 * emacs.c: Likewise.
1883 * fileio.c: Likewise.
1884 * filelock.c: Likewise.
1885 * font.c: Likewise.
1886 * fontset.c: Likewise.
1887 * fringe.c: Likewise.
1888 * indent.c: Likewise.
1889 * insdel.c: Likewise.
1890 * intervals.c: Likewise.
1891 * keyboard.c: Likewise.
1892 * keymap.c: Likewise.
1893 * lread.c: Likewise.
1894 * macros.c: Likewise.
1895 * marker.c: Likewise.
1896 * minibuf.c: Likewise.
1897 * nsfns.m: Likewise.
1898 * nsmenu.m: Likewise.
1899 * print.c: Likewise.
1900 * process.c: Likewise.
1901 * regex.c: Likewise.
1902 * region-cache.c: Likewise.
1903 * search.c: Likewise.
1904 * syntax.c: Likewise.
1905 * term.c: Likewise.
1906 * textprop.c: Likewise.
1907 * undo.c: Likewise.
1908 * unexsol.c: Likewise.
1909 * w16select.c: Likewise.
1910 * w32fns.c: Likewise.
1911 * w32menu.c: Likewise.
1912 * window.c: Likewise.
1913 * xdisp.c: Likewise.
1914 * xfns.c: Likewise.
1915 * xmenu.c: Likewise.
1916 * xml.c: Likewise.
1917 * xselect.c: Likewise.
1918
2f07e6af
EZ
19192012-06-16 Eli Zaretskii <eliz@gnu.org>
1920
1053a871
SM
1921 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1922 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1923 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1924 row.
1925 (handle_face_prop): Use chunk-relative overlay string index when
1926 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1927 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1928 the rightmost. (Bug#11720)
2f07e6af 1929
29b83cec
AS
19302012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1931
1932 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1933 (CATEGORY_MEMBER): Enforce 1/0 value.
1934 * category.c (_temp_category_set): Remove.
1935
4c5501e9
EZ
19362012-06-16 Eli Zaretskii <eliz@gnu.org>
1937
1938 * window.c (Fdelete_other_windows_internal)
1939 (Fdelete_window_internal): Don't access frame's mouse highlight
1940 info of the initial frame. (Bug#11677)
1941
2b570124
PE
19422012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1943
e93864f9
PE
1944 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1945 Assume USE_2_TAGS_FOR_INTS.
1946 (xreload): Adjust $tagmask width to match recent lisp.h change.
1947
2b570124
PE
1948 Simplify lisp.h in minor ways that should not affect code.
1949 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1950 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1951 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1952 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1953 (INTTYPEBITS): New macro, for clarity.
1954 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1955 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1956 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1957 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1958 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1959
81755f69
JB
19602012-06-13 Juanma Barranquero <lekktu@gmail.com>
1961
1962 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1963
16192a57
GM
19642012-06-13 Glenn Morris <rgm@gnu.org>
1965
1966 * s/bsd-common.h (BSD4_3):
1967 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1968
646b5f55
AS
19692012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1970
1971 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1972 instead of union.
1973 (XLI, XIL): Define.
1053a871
SM
1974 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1975 Use them.
1976 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1977 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1978 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1979 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1980 * frame.c (delete_frame): Remove outdated comment.
1981 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1982 USE_LISP_UNION_TYPE.
1983 (Fw32_unregister_hot_key): Likewise.
1984 (Fw32_toggle_lock_key): Likewise.
1985 * w32menu.c (add_menu_item): Likewise.
1986 (w32_menu_display_help): Use XIL instead of checking
1987 USE_LISP_UNION_TYPE.
1988 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1989 (init_heap): Likewise.
1990 * w32term.c (w32_read_socket): Update comment.
1991
1d3823c9
GM
19922012-06-13 Glenn Morris <rgm@gnu.org>
1993
c62ff706
GM
1994 * s/usg5-4-common.h, src/s/unixware.h:
1995 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1996
1d3823c9
GM
1997 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1998
bfe3e0a2
PE
19992012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2002 * alloc.c (make_number) [!defined make_number]:
2003 Remove, as lisp.h always defines this now.
2004 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2005 (roundup_size): Verify that it is a power of 2.
2006 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2007 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2008 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2009 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2010 USE_LSB_TAG now is always defined to be either 0 or 1.
2011 All uses changed.
2012 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2013 code works fine either way, and efficiency is not a concern here,
2014 as the union type is for debugging, not for production.
2015 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2016 Use an inline function on all platforms when using the union type,
2017 since this is simpler and 'static inline' can be used portably
2018 within Emacs now.
2019 (LISP_INITIALLY_ZERO): New macro.
2020 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2021 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2022
45fa9c0f
GM
20232012-06-12 Glenn Morris <rgm@gnu.org>
2024
b4492cba
GM
2025 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2026
2027 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2028
45fa9c0f
GM
2029 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2030 Move BROKEN_SIGIO to configure.
2031
2032 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2033 Move NO_TERMIO to configure.
2034
0e25d334
CY
20352012-06-12 Chong Yidong <cyd@gnu.org>
2036
2037 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2038 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2039 MagickExportImagePixels is undefined.
2040
43682bb6
PE
20412012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2042
2043 * image.c (imagemagick_load_image): Remove unused label.
2044
a9be7d2b
GM
20452012-06-11 Glenn Morris <rgm@gnu.org>
2046
2047 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2048 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2049 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2050 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2051
3017f87f
SM
20522012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2053
2054 * alloc.c (make_byte_code): New function.
2055 (Fmake_byte_code): Use it. Don't purify here.
2056 * lread.c (read1): Use it as well to avoid extra allocation.
2057
1b9b4cf4
CY
20582012-06-11 Chong Yidong <cyd@gnu.org>
2059
2060 * image.c (imagemagick_load_image): Implement transparency.
2061
95988fcf
AS
20622012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2063
2064 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2065 account for preceding backslashes. (Bug#11663)
2066
cd4eb164
CY
20672012-06-09 Chong Yidong <cyd@gnu.org>
2068
2069 * term.c: Support italics in capable terminals (Bug#9652).
2070 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2071 (turn_on_face): Output using TS_enter_italic_mode if available.
2072 Don't handle unused blinking and alt-charset cases.
2073 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2074 and tty_alt_charset_p cases.
2075 (tty_capable_p, init_tty): Support italics.
2076
2077 * termchar.h (struct tty_display_info): Add field for italics.
2078 Remove unused blink field.
2079
2080 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2081 Handle slant.
2082
2083 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2084 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2085 tty_alt_charset_p. Add tty_italic_p.
2086
ff88beb8
MA
20872012-06-09 Michael Albinus <michael.albinus@gmx.de>
2088
2089 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2090 dbus_type_is_basic if available.
2091 (xd_extract_signed, xd_extract_unsigned): Rename from
2092 extract_signed and extract_unsigned, respectively. Adapt callers.
2093
44286096
CY
20942012-06-09 Chong Yidong <cyd@gnu.org>
2095
1682701f
CY
2096 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2097
44286096
CY
2098 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2099 case (Bug#9752).
2100
d86feb17
PE
21012012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2102
2103 * xdisp.c (vmessage): Treat frame message as multibyte.
2104 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2105 would generate the diagnostic "Making \302\247 buffer-local while
2106 let-bound!".
2107
d5c20fe8
EZ
21082012-06-08 Eli Zaretskii <eliz@gnu.org>
2109
2110 * dispnew.c (showing_window_margins_p): Undo last change, which
2111 was done due to an inadvertent commit.
2112 (adjust_frame_glyphs_for_frame_redisplay): Do call
2113 showing_window_margins_p.
2114
513749ee
SM
21152012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2116
2117 * eval.c (Fmake_var_non_special): New primitive.
2118 (syms_of_eval): Defsubr it.
2119 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2120
d4a8f5c1
JB
21212012-06-08 Juanma Barranquero <lekktu@gmail.com>
2122
2123 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2124 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2125
8bbbc977
EZ
21262012-06-08 Eli Zaretskii <eliz@gnu.org>
2127
2128 * alloc.c (allocate_vectorlike): Fix last change.
2129
f3372c87
DA
21302012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2131
2132 Block-based vector allocation of small vectors.
2133 * lisp.h (struct vectorlike_header): New field `nbytes',
2134 adjust comment accordingly.
2135 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2136 to denote vector blocks. Adjust users (live_vector_p,
2137 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2138 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2139 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2140 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2141 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2142 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2143 (roundup_size): New constant.
2144 (struct vector_block): New data type.
2145 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2146 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2147 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2148 (sweep_vectors): New functions.
2149 (allocate_vectorlike): Return `zero_vector' as the only vector of
2150 0 items. Allocate new vector from block if vector size is less than
2151 or equal to VBLOCK_BYTES_MAX.
2152 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2153 (init_alloc_once): Add call to init_vectors.
2154
4f18a4ed
SM
21552012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2156
2157 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2158
86f158bc
PE
21592012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 * doprnt.c (doprnt): Truncate multibyte char correctly.
2162 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2163 would mishandle a string argument "Xc" if X was a multibyte
2164 character of length 2: it would truncate after X's first byte
2165 rather than including all of X.
2166
c5cfcbe0
CY
21672012-06-06 Chong Yidong <cyd@gnu.org>
2168
2169 * buffer.c (word_wrap): Doc fix.
2170
c05cf390
PE
21712012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2172
2173 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2174
0c3461de
GM
21752012-06-03 Glenn Morris <rgm@gnu.org>
2176
2177 * xdisp.c (tool-bar-style): Doc fix.
2178
c71232db
UM
21792012-06-03 Ulrich Müller <ulm@gentoo.org>
2180
2181 * Makefile.in (PAXCTL): Define.
2182 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2183 binary via PaX flags if the paxctl utility is available.
2184 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2185 Restore PaX flags to their default. (Bug#11398)
2186
383f7350
CY
21872012-06-03 Chong Yidong <cyd@gnu.org>
2188
2189 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2190 buffer (Bug#11226).
2191
5f2c76c6
CY
21922012-06-03 Chong Yidong <cyd@gnu.org>
2193
2194 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2195 (note_mode_line_or_margin_highlight): If there is no help echo,
2196 use mode-line-default-help-echo. Handle the case where the mouse
2197 position is past the end of the mode line string.
2198
2199 * buffer.c (buffer_local_value_1): New function, split from
2200 Fbuffer_local_value; can return Qunbound.
2201 (Fbuffer_local_value): Use it.
2202 (Vmode_line_format): Docstring tweaks.
2203
773d47f6
PE
22042012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2205
2206 * sysdep.c (system_process_attributes): Improve comment.
2207
f2d6a3df
SM
22082012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2209
2210 * keyboard.c: Export real-this-command to Elisp.
2211 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2212 and DEFVAR it. Update all users.
2213
63810350
PE
22142012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2215
7bd5c1f4
PE
2216 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2217
63810350
PE
2218 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2219 Convert pctcpu and pctmem to Lisp float properly.
2220 Let the compiler fold better, as 100.0/0x8000 is exact.
2221
a2821611
AS
22222012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2223
2224 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2225 cons_block.
2226
5fceba1d
PE
22272012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2228
2229 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2230
c98ff5dd
DA
22312012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2232
2233 For a 'struct window', replace some Lisp_Object fields to
2234 bitfields where appropriate, remove unused fields.
2235 * window.h (struct window): Remove unused 'last_mark_x' and
2236 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2237 change it's type from Lisp_Object to bitfield.
2238 Change type of 'force_start', 'optional_new_start',
2239 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2240 fields from Lisp_Object to bitfield. Adjust users accordingly.
2241
ca34e0be
PE
22422012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2243
2244 Pacify gcc -Wdouble-precision when using Xaw.
2245 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2246 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2247 Use 'float' consistently, rather than 'float' in most places
2248 and 'double' in a couple of places.
2249
efc00ab1 22502012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2251
2252 * xdisp.c (handle_stop): Detect whether we have overlay strings
2253 loaded by testing it->current.overlay_string_index to be
2254 non-negative, instead of checking whether n_overlay_strings is
2255 positive. (Bug#11587)
2256
efc00ab1 22572012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2258
2259 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2260
2261 * doc.c (Fsubstitute_command_keys): Doc fix.
2262
efc00ab1 22632012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2264
2265 * search.c (search_buffer): Remove calls to
2266 r_alloc_inhibit_buffer_relocation, as it is now called by
2267 maybe_unify_char, which was the cause of relocation of buffer text
2268 in bug#11519.
2269
efc00ab1 22702012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2271
2272 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2273 for the duration of call to load_charset, to avoid problems with
2274 callers of maybe_unify_char that access buffer text through C
2275 pointers.
2276
2277 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2278 decrement the inhibition flag, instead of just setting or
2279 resetting it.
2280
ba93a187
PE
22812012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2282
2283 Remove obsolete '#define static' cruft.
2284 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2285 This #undef was "temporary" in 2000; it is no longer needed
2286 now that '#define static' has gone away.
2287 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2288 (gray_bitmap_bits): Remove; no longer needed.
2289 All uses replaced with definiens.
2290 * xterm.c: Include "bitmaps/gray.xbm".
2291
9e4bf381
PE
22922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 Clean up __executable_start, monstartup when --enable-profiling.
2295 The following changes affect the code only when profiling.
2296 * dispnew.c (__executable_start): Rename from safe_bcopy.
2297 Define only on platforms that need it.
2298 * emacs.c: Include <sys/gmon.h> when profiling.
2299 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2300 (__executable_start): Remove decl, since lisp.h does it now.
2301 (safe_bcopy): Remove decl; no longer has that name.
2302 (main): Coalesce #if into single bit of code, for simplicity.
2303 Cast pointers to uintptr_t, since standard libraries want integers
2304 and not pointers.
2305 * lisp.h (__executable_start): New decl.
2306
32d72c2f
GM
23072012-05-31 Glenn Morris <rgm@gnu.org>
2308
2309 * image.c (Fimagemagick_types): Doc fix.
2310
baac5bc7
JM
23112012-05-30 Jim Meyering <meyering@redhat.com>
2312
2313 * callproc.c (Fcall_process_region): Include directory component
2314 in mkstemp error message (Bug#11586).
2315
72cb32cf
PE
23162012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 * alloc.c, lisp.h (make_pure_vector): Now static.
2319
61b108cc
SM
23202012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2321
2322 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2323 Move to byte-run.el.
2324 (Fautoload): Do the hash-doc more carefully.
2325 * data.c (Fdefalias): Purify definition, except for keymaps.
2326 (Qdefun): Move from eval.c.
2327 * lisp.h (Qdefun): Remove.
2328 * lread.c (read1): Tiny simplification.
2329
471fe23d
TN
23302012-05-29 Troels Nielsen <bn.troels@gmail.com>
2331
934f3f58 2332 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2333 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2334 Bug#9642, but explicitly check that the buffer the overlay would
2335 be moved to is live and rearrange lines to make sure that errors
2336 will not put the overlay in an inconsistent state.
2337 (Fdelete_overlay): Cosmetics.
2338
85d0efd1
EZ
23392012-05-28 Eli Zaretskii <eliz@gnu.org>
2340
2341 * w32term.c (my_bring_window_to_top): New function.
2342 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2343 could be different from the original one.
2344 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2345 (Bug#11513)
2346
2347 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2348 by calling BringWindowToTop.
2349
2350 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2351 (WM_EMACS_END): Increase by one.
2352
da92a98c
PE
23532012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2356 This avoids undefined behavior that might cause the eassert
2357 to not catch an out-of-range value.
2358
74d1f848
JB
23592012-05-28 Juanma Barranquero <lekktu@gmail.com>
2360
2361 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2362 Update dependencies.
2363
9e1a06fc
EZ
23642012-05-27 Eli Zaretskii <eliz@gnu.org>
2365
2366 * bidi.c (bidi_mirror_char): Fix last change.
2367
f3dd7312
AS
23682012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2369
2370 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2371 when referring to sectname field in printf format.
2372
81899c91
PE
23732012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2374
57b81a9f
PE
2375 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2376 Only r_alloc_inhibit_buffer_relocation needed to be added;
2377 the others were already declared.
2378
81899c91
PE
2379 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2380 before checking whether it's out of range. Put the check inside
2381 eassert. See
2382 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2383
33017faf 23842012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2385
2386 * callproc.c (Fcall_process): Restore a line that was accidentally
2387 commented out in the 2011-02-13 change (bug#11547).
2388
33017faf 23892012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2390
2391 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2392 defined on ralloc.c.
2393
2394 * buffer.c [REL_ALLOC]: Remove prototypes of
2395 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2396 they are now on lisp.h.
2397
2398 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2399
2400 * search.c (search_buffer): Use it to inhibit relocation of buffer
2401 text while re_search_2 is doing its job, because re_search_2 is
2402 passed C pointers to buffer text. (Bug#11519)
2403
23415acf
EZ
2404 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2405 Update value to 24.
2406
44e27368
EZ
2407 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2408 state after an additional call to move_it_in_display_line_to, keep
2409 the values of it->max_ascent and it->max_descent found for the
2410 entire line.
2411 (pos_visible_p): Revert the comparison against bottom_y to what it
2412 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2413 (Bug#11464)
2414
c1892f11
PE
24152012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 Fix coding-related core dumps with gcc -ftrapv.
2418 The code was computing A - B, where A and B are pointers, and B is
2419 random garbage. This can lead to core dumps on platforms that
2420 have special pointer registers, and it also leads to core dumps on
2421 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2422 A - B only when B is initialized properly.
2423 * coding.c (coding_set_source, coding_set_destination): Return void.
2424 (coding_change_source, coding_change_destinations): New functions,
2425 with the old behaviors of coding_set_source and coding_set_destination.
2426 All callers that need an offset changed to use these new functions.
2427
eb7afdad
GM
24282012-05-26 Glenn Morris <rgm@gnu.org>
2429
2430 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2431
f12fdf02
EZ
24322012-05-26 Eli Zaretskii <eliz@gnu.org>
2433
53a63be6 2434 Extend mouse support on W32 text-mode console.
61b108cc
SM
2435 * xdisp.c (draw_row_with_mouse_face):
2436 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2437
eb3f6f01 2438 * w32console.c: Include window.h.
61b108cc
SM
2439 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2440 New functions.
eb3f6f01
EZ
2441 (initialize_w32_display): Initialize mouse-highlight data.
2442
53a63be6
EZ
2443 * w32inevt.c: Include termchar.h and window.h.
2444 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2445 moves, call note_mouse_highlight. If help_echo changed, call
2446 gen_help_event to produce help-echo message in the echo area.
2447 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2448 highlight info.
2449
4cfd81f6
PE
24502012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 * lread.c (read1): Simplify slightly to avoid an overflow warning
2453 with GCC 4.7.0 on x86-64.
2454
4446092a
EZ
24552012-05-26 Eli Zaretskii <eliz@gnu.org>
2456
2457 * bidi.c (bidi_mirror_char): Revert last change: an int is
2458 definitely wide enough here.
2459
42b2a986 24602012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2461
42b2a986 2462 Fix integer width and related bugs (Bug#9874).
eb106a49 2463 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2464 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2465 (string_bytes, check_sblock, allocate_string_data):
2466 (compact_small_strings, Fmake_bool_vector, make_string)
2467 (make_unibyte_string, make_multibyte_string)
2468 (make_string_from_bytes, make_specified_string)
2469 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2470 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2471 (mark_vectorlike):
2472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2473 (allocate_pseudovector):
2474 Use int, not EMACS_INT, where int is wide enough.
2475 (inhibit_garbage_collection, Fgarbage_collect):
2476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2477 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2478 int might not be wide enough.
2479 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2480 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2481 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2482 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2483 (bidi_level_of_next_char, bidi_move_to_visually_next):
2484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2485 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2486 (Fkill_buffer, Fset_buffer_major_mode)
2487 (advance_to_char_boundary, Fbuffer_swap_text)
2488 (Fset_buffer_multibyte, overlays_at, overlays_in)
2489 (overlay_touches_p, struct sortvec, record_overlay_string)
2490 (overlay_strings, recenter_overlay_lists)
2491 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2492 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2493 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2494 (Foverlay_recenter, last_overlay_modification_hooks_used)
2495 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2497 (validate_region): Omit unnecessary test for b <= e,
2498 since that's guaranteed by the previous test.
d311d28c
PE
2499 (adjust_overlays_for_delete): Avoid pos + length overflow.
2500 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2501 (report_overlay_modification):
2502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2503 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2504 Omit pointer cast, which isn't needed anyway, and doesn't work
2505 after the EMACS_INT -> ptrdiff_t change.
02481186 2506 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2507 * buffer.h: Adjust decls to match defn changes elsewhere.
2508 (struct buffer_text, struct buffer):
2509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2510 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2511 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2512 not int, to avoid needless 32-bit limit on 64-bit hosts.
2513 (exec_byte_code): Use tighter memory-full test, one that checks
2514 for alloca overflow. Don't compute the address of the object just
2515 before an array, as that's not portable. Use EMACS_INT, not
2516 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2517 * callint.c (Fcall_interactively):
2518 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2519 * callproc.c (call_process_kill, Fcall_process):
2520 Don't assume pid_t fits into an Emacs fixnum.
2521 (call_process_cleanup, Fcall_process, child_setup):
2522 Don't assume pid_t fits into int.
2523 (call_process_cleanup, Fcall_process, delete_temp_file)
2524 (Fcall_process_region):
2525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2526 (Fcall_process): Simplify handling of volatile integers.
2527 Use int, not EMACS_INT, where int will do.
2528 * casefiddle.c (casify_object, casify_region, operate_on_word)
2529 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2531 (casify_object): Avoid integer overflow when overallocating buffer.
2532 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2533 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2534 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2535 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2536 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2537 integers are now checked earlier. All uses replaced with XINT.
2538 (ccl_driver):
2539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2540 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2541 (ccl_driver, Fregister_code_conversion_map):
2542 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2543 (resolve_symbol_ccl_program): Check that vector header is in range.
2544 Always copy the vector, so that we can check its contents reliably
2545 now rather than having to recheck each instruction as it's being
2546 executed. Check that vector words fit in 'int'.
2547 (ccl_get_compiled_code, Fregister_ccl_program)
2548 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2549 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2550 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2551 contents are in range.
2552 (Fccl_execute_on_string): Check that status is in range.
2553 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2554 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2555 Accept and return EMACS_INT, not int, because callers can pass values
2556 out of 'int' range.
2557 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2558 (multibyte_chars_in_text, parse_str_as_multibyte)
2559 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2560 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2561 (string_escape_byte8, Fget_byte):
2562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2563 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2564 avoid mishandling large integers.
2565 * character.h: Adjust decls to match defn changes elsewhere.
2566 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2567 (Ffind_charset_region):
2568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2569 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2570 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2571 Don't assume fixnum fits in int.
d311d28c
PE
2572 (load_charset_map_from_vector, Fmap_charset_chars):
2573 Remove now-unnecessary CHECK_NATNUMs.
2574 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2575 Don't rely on undefined behavior with signed left shift overflow.
2576 Don't assume unsigned int fits into fixnum, or that fixnum fits
2577 into unsigned int. Don't require max_code to be a valid fixnum;
2578 that's not true for gb10830 4-byte on a 32-bit host. Allow
2579 invalid_code to be a cons, for the same reason. Require code_offset
2580 to be a character. Avoid int overflow if max_char is close
2581 to INT_MAX.
2582 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2583 this is intended anyway and avoids some undefined behavior.
2584 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2585 INDEX_TO_CODE_POINT, as that's what it expects.
2586 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2587 * charset.h (DECODE_CHAR): Return int, not unsigned;
2588 this is what was intended anyway, and it avoids undefined behavior.
2589 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2590 integer-overflow issues.
2591 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2592 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2593 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2594 * chartab.c (Fmake_char_table, Fset_char_table_range)
2595 (uniprop_get_decoder, uniprop_get_encoder):
2596 Don't assume fixnum fits in int.
2597 * cmds.c (move_point): New function, that does the gist of
2598 Fforward_char and Fbackward_char, but does so while checking
2599 for integer overflow more accurately.
c96e5d6a 2600 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2601 (Fforward_line, Fend_of_line, internal_self_insert)
2602 (internal_self_insert):
2603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2604 Fix a FIXME, by checking for integer overflow when calculating
2605 target_clm and actual_clm.
2606 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2607 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2608 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2609 (coding_alloc_by_making_gap, alloc_destination)
2610 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2611 (encode_coding_utf_16, detect_coding_emacs_mule)
2612 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2613 (detect_coding_iso_2022, decode_coding_iso_2022)
2614 (encode_invocation_designation, encode_designation_at_bol)
2615 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2616 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2617 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2618 (encode_coding_ccl, encode_coding_raw_text)
2619 (detect_coding_charset, decode_coding_charset)
2620 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2621 (produce_composition, produce_charset, produce_annotation)
2622 (decode_coding, handle_composition_annotation)
2623 (handle_charset_annotation, consume_chars, decode_coding_gap)
2624 (decode_coding_object, encode_coding_object, detect_coding_system)
2625 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2626 (code_convert_region, code_convert_string)
8f50130c
PE
2627 (Fdefine_coding_system_internal)
2628 (coding_set_source, coding_set_destination):
d311d28c
PE
2629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2630 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2631 (Fdefine_coding_system_internal):
2632 Don't assume fixnums fit in int.
2633 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2634 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2635 (Funencodable_char_position, Fcheck_coding_systems_region)
2636 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2638 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2639 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2640 Don't access memory outside of the args array.
d311d28c 2641 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2642 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2643 result of ENCODE_CHAR.
d311d28c
PE
2644 * coding.h: Adjust decls to match defn changes elsewhere.
2645 (struct coding_system):
2646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2647 * composite.c (get_composition_id, find_composition)
2648 (run_composition_function, update_compositions)
2649 (compose_text, composition_gstring_put_cache)
2650 (composition_gstring_p, composition_gstring_width)
2651 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2652 (composition_compute_stop_pos, composition_reseat_it)
2653 (composition_update_it, struct position_record)
2654 (find_automatic_composition, composition_adjust_point)
2655 (Fcomposition_get_gstring, Ffind_composition_internal):
2656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2657 (update_compositions):
2658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2659 * composite.h: Adjust decls to match defn changes elsewhere.
2660 (struct composition):
2661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2662 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2663 Do not attempt to compute the address of the object just before a
2664 buffer; this is not portable.
2665 (Faref, Faset):
2666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2667 (Faset): Use int, not EMACS_INT, where int is wide enough.
2668 (Fstring_to_number): Don't assume fixnums fit in int.
2669 (Frem): Don't assume arg is nonnegative.
2670 * dbusbind.c (xd_append_arg): Check for integers out of range.
2671 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2672 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2673 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2674 (xd_get_connection_references): Return ptrdiff_t, not int.
2675 All uses changed.
2676 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2677 (xd_read_message_1):
2678 Use int, not unsigned, where the dbus API uses int.
2679 (Fdbus_message_internal): Don't overflow mtype.
2680 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2681 * dired.c (directory_files_internal, file_name_completion, scmp)
2682 (file_name_completion_stat):
2683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2684 (file_name_completion): Don't overflow matchcount.
2685 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2686 * dispextern.h: Adjust decls to match defn changes elsewhere.
2687 (struct text_pos, struct glyph, struct bidi_saved_info)
2688 (struct bidi_string_data, struct bidi_it, struct composition_it)
2689 (struct it):
2690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2691 (struct display_pos, struct composition_it, struct it):
2692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2693 * dispnew.c (increment_matrix_positions)
2694 (increment_row_positions, mode_line_string)
2695 (marginal_area_string):
2696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2697 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2699 (duration_to_sec_usec): New function, to check for overflow better.
2700 (Fsleep_for, sit_for): Use it.
2701 * doc.c (get_doc_string, store_function_docstring):
2702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2703 (get_doc_string, Fsnarf_documentation):
2704 Use int, not EMACS_INT, where int is wide enough.
2705 (get_doc_string):
2706 Use SAFE_ALLOCA, not alloca.
2707 Check for overflow when converting EMACS_INT to off_t.
2708 * doprnt.c (doprnt):
2709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2710 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2711 Don't assume uid_t fits into fixnum.
2712 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2713 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2714 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2715 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2716 (general_insert_function)
2717 (Finsert_char, make_buffer_string, make_buffer_string_both)
2718 (update_buffer_properties, Fbuffer_substring)
2719 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2720 (Fsubst_char_in_region, check_translation)
2721 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2722 (transpose_markers, Ftranspose_regions):
2723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2724 (clip_to_bounds): Move to lisp.h as an inline function).
2725 (Fconstrain_to_field): Don't assume integers are nonnegative.
2726 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2727 (Fsubst_char_in_region, Fsave_restriction):
2728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2729 (Femacs_pid): Don't assume pid_t fits into fixnum.
2730 (lo_time): Use int, not EMACS_INT, when int suffices.
2731 (lisp_time_argument): Check for usec out of range.
2732 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2733 (Fuser_login_name, Fuser_full_name): Signal an error
2734 if a uid argument is out of range, rather than relying on
2735 undefined behavior.
c8d5c857
PE
2736 (Fformat_time_string): Remove now-unnecessary check.
2737 lisp_time_argument checks for out-of-range usec now.
243e0530 2738 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2739 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2740 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2741 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2742 (init_cmdargs, Fdump_emacs):
2743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2744 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2745 the bottom (typically) 32 bits of the fixnum.
2746 * eval.c (specpdl_size, call_debugger):
2747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2748 (when_entered_debugger, Fbacktrace_debug):
2749 Don't assume fixnum can fit in int.
2750 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2751 the object just before a buffer; this is not portable.
2752 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2753 (grow_specpdl, unbind_to):
2754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2755 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2756 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2757 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2758 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2759 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2761 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2762 (a_write, e_write):
2763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2764 (Fcopy_file, non_regular_nbytes, read_non_regular)
2765 (Finsert_file_contents):
2766 Use int, not EMACS_INT, where int is wide enough.
2767 (READ_BUF_SIZE): Verify that it fits in int.
2768 (Finsert_file_contents): Check that counts are in proper range,
2769 rather than assuming fixnums fit into ptrdiff_t etc.
2770 Don't assume fixnums fit into int.
125b3835 2771 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2772 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2773 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2774 (string_char_to_byte, string_byte_to_char)
2775 (string_make_multibyte, string_to_multibyte)
2776 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2777 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2778 (substring_both, Fdelete, internal_equal, Ffillarray)
2779 (Fclear_string, mapcar1)
2780 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2781 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2782 (larger_vector, make_hash_table, maybe_resize_hash_table)
2783 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2784 (Fmaphash, secure_hash):
2785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2786 (concat): Check for string index and length overflow.
2787 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2788 (Frequire):
2789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2790 (larger_vector): New API (vec, incr_min, size_max) replaces old
2791 one (vec, new_size, init). This catches size overflow.
2792 INIT was removed because it was always Qnil.
2793 All callers changed.
2794 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2795 the upper bound on a hash table index size.
2796 (make_hash_table, maybe_resize_hash_table): Use it.
2797 (secure_hash): Computer start_byte and end_byte only after
2798 they're known to be in ptrdiff_t range.
2799 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2800 (Ffont_get_glyphs, Ffont_at):
2801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2802 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2803 (Flist_fonts, Fopen_font):
2804 Don't assume fixnum can fit in int.
2805 (check_gstring): Don't assume index can fit in int.
2806 (font_match_p): Check that fixnum is a character, not a nonnegative
2807 fixnum, since the later code needs to stuff it into an int.
2808 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2809 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2810 conversion overflow issues.
2811 (Fopen_font): Check for integer out of range.
2812 (Ffont_get_glyphs): Don't assume index can fit in int.
2813 * font.h: Adjust decls to match defn changes elsewhere.
2814 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2815 integer overflow.
2816 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2817 printmax_t, where ptrdiff_t is wide enough.
2818 (Finternal_char_font):
2819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2820 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2821 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2822 (Fset_frame_position, x_set_frame_parameters)
2823 (x_set_line_spacing, x_set_border_width)
2824 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2825 Check that fixnums are in proper range for system types.
2826 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2828 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2829 Use SAFE_ALLOCA_LISP, not alloca.
2830 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2831 intptr_t is wide enough.
2832 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2833 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2834 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2835 Check for fixnum out of range.
2836 * ftfont.c (ftfont_list): Don't assume index fits in int.
2837 Check that fixnums are in proper range for system types.
2838 (ftfont_shape_by_flt):
2839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2840 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2842 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2843 Check that fixnums are in proper range for system types.
2844 * gnutls.h: Adjust decls to match defn changes elsewhere.
2845 * gtkutil.c (xg_dialog_run):
2846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2847 (update_frame_tool_bar):
2848 Check that fixnums are in proper range for system types.
2849 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2850 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2851 * indent.c (last_known_column, last_known_column_point):
2852 (current_column_bol_cache):
2853 (skip_invisible, current_column, check_display_width):
2854 (check_display_width, scan_for_column, current_column_1)
2855 (Findent_to, Fcurrent_indentation, position_indentation)
2856 (indented_beyond_p, Fmove_to_column, compute_motion):
2857 (Fcompute_motion, Fvertical_motion):
2858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2859 (last_known_column_modified): Use EMACS_INT, not int.
2860 (check_display_width):
2861 (Fcompute_motion):
2862 Check that fixnums and floats are in proper range for system types.
2863 (compute_motion): Don't assume index or fixnum fits in int.
2864 (compute_motion, Fcompute_motion):
2865 Use int, not EMACS_INT, when it is wide enough.
2866 (vmotion): Omit local var start_hpos that is always 0; that way
2867 we don't need to worry about overflow in expressions involving it.
2868 * indent.h: Adjust decls to match defn changes elsewhere.
2869 (struct position):
2870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2871 Use int, not EMACS_INT, where int is wide enough.
2872 Remove unused members ovstring_chars_done and tab_offset;
2873 all uses removed.
2874 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2875 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2876 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2877 (make_gap, copy_text, insert, insert_and_inherit)
2878 (insert_before_markers, insert_before_markers_and_inherit)
2879 (insert_1, count_combining_before, count_combining_after)
2880 (insert_1_both, insert_from_string)
2881 (insert_from_string_before_markers, insert_from_string_1)
2882 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2883 (adjust_after_replace, adjust_after_insert, replace_range)
2884 (replace_range_2, del_range, del_range_1, del_range_byte)
2885 (del_range_both, del_range_2, modify_region)
2886 (prepare_to_modify_buffer, signal_before_change)
2887 (signal_after_change, Fcombine_after_change_execute):
2888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2889 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2890 (balance_an_interval, split_interval_right, split_interval_left)
2891 (find_interval, next_interval, update_interval)
2892 (adjust_intervals_for_insertion, delete_node, delete_interval)
2893 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2894 (static_offset_intervals, offset_intervals)
2895 (merge_interval_right, merge_interval_left, make_new_interval)
2896 (graft_intervals_into_buffer, temp_set_point_both)
2897 (temp_set_point, set_point, adjust_for_invis_intang)
2898 (set_point_both, move_if_not_intangible, get_property_and_range)
2899 (get_local_map, copy_intervals, copy_intervals_to_string)
2900 (compare_string_intervals, set_intervals_multibyte_1):
2901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2902 * intervals.h: Adjust decls to match defn changes elsewhere.
2903 (struct interval):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 * keyboard.c (this_command_key_count, this_single_command_key_start)
2906 (before_command_key_count, before_command_echo_length, echo_now)
2907 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2908 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2909 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2910 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2912 (last_non_minibuf_size, last_point_position, echo_truncate)
2913 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2914 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2915 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2916 (stuff_buffered_input):
2917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2918 (last_auto_save, command_loop_1, read_char):
2919 Use EMACS_INT, not int, to avoid integer overflow.
2920 (record_char): Avoid overflow in total_keys computation.
2921 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2922 * keyboard.h: Adjust decls to match defn changes elsewhere.
2923 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2924 (Fkey_description, Fdescribe_vector, Flookup_key):
2925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2926 (click_position): New function, to check that positions are in range.
2927 (Fcurrent_active_maps):
2928 (describe_command):
2929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2930 (Faccessible_keymaps, Fkey_description):
2931 (preferred_sequence_p):
2932 Don't assume fixnum can fit into int.
2933 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2934 Check for integer overflow in size calculations.
2935 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2936 avoid mishandling large integers.
2937 * lisp.h: Adjust decls to match defn changes elsewhere.
2938 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2939 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2940 (struct Lisp_Marker):
2941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2942 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2943 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2944 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2945 All callers changed.
2946 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2947 Assume the arg has valid form, since it always does.
2948 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2949 unsigned integer system type.
2950 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2951 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2953 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2954 (duration_to_sec_usec): New decl.
2955 * lread.c (read_from_string_index, read_from_string_index_byte)
2956 (read_from_string_limit, readchar, unreadchar, openp)
2957 (read_internal_start, read1, oblookup):
2958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2959 (Fload, readevalloop, Feval_buffer, Feval_region):
2960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2961 (openp): Check for out-of-range argument to 'access'.
2962 (read1): Use int, not EMACS_INT, where int is wide enough.
2963 Don't assume fixnum fits into int.
6efdadfd 2964 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2965 (read_filtered_event): Use duration_to_sec_usec
2966 to do proper overflow checking on durations.
d311d28c
PE
2967 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2968 in size calculation.
2969 (Fexecute_kbd_macro):
2970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2971 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2972 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2973 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2974 (set_marker_both, set_marker_restricted_both, marker_position)
2975 (marker_byte_position, Fbuffer_has_markers_at):
2976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2977 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2978 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2979 It now merely ensures that the menu is large enough, without
2980 necessarily growing it, as this avoids some integer overflow issues.
2981 All callers changed.
2982 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2984 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2985 Use SAFE_ALLOCA_LISP, not alloca.
2986 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2987 to EMACS_INT. Check that fixnums are in proper range for system types.
2988 * minibuf.c (minibuf_prompt_width, string_to_object)
2989 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2990 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2992 (get_minibuffer, read_minibuf_unwind):
2993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2994 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2995 this simplifies overflow checking. All callers changed.
2996 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2997 (Ftest_completion):
2998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2999 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3000 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3001 Check that fixnums are in proper range for system types.
3002 (Fx_create_frame, Fx_show_tip):
3003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3004 * nsfont.m (ns_findfonts, nsfont_list_family):
3005 Don't assume fixnum fits in long.
3006 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3008 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3009 wide enough.
17fdb222 3010 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3012 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3013 (PRINTDECLARE, PRINTPREPARE):
3014 (strout, print_string):
3015 (print, print_preprocess, print_check_string_charset_prop)
3016 (print_object):
3017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3018 (PRINTDECLARE):
3019 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3021 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3022 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3023 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3024 (print_error_message): Use SAFE_ALLOCA, not alloca.
3025 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3026 (print_depth, new_backquote_output, print_number_index):
3027 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3028 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3029 (Fset_process_window_size, Fformat_network_address)
3030 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3031 (sigchld_handler):
d311d28c 3032 Check that fixnums are in proper range for system types.
d44287d4 3033 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3034 Check for process-ids out of pid_t range rather than relying on
3035 undefined behavior.
e4d81efc 3036 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3037 (Fformat_network_address, read_process_output, send_process)
3038 (Fprocess_send_region, status_notify):
3039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3040 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3041 (wait_reading_process_output, read_process_output, exec_sentinel):
3042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3043 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3044 (Faccept_process_output): Use duration_to_sec_usec to do proper
3045 overflow checking on durations.
dde14581
PE
3046 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3047 Don't assume pid_t fits in int.
02481186
PE
3048 * process.h (struct Lisp_Process): Members tick and update_tick
3049 are now of type EMACS_INT, not int.
b62b53e8
PE
3050 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3051 configured --with-wide-int.
d311d28c
PE
3052 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3053 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3054 * search.c (looking_at_1, string_match_1):
3055 (fast_string_match, fast_c_string_match_ignore_case)
3056 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3057 (scan_newline, find_before_next_newline, search_command)
3058 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3059 (set_search_regs, wordify):
3060 (Freplace_match):
3061 (Fmatch_data):
3062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3063 (string_match_1, search_buffer, set_search_regs):
3064 (Fmatch_data):
3065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3066 (wordify): Check for overflow in size calculation.
3067 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3068 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3069 Check that fixnums are in proper range for system types.
3070 * sound.c (struct sound_device)
3071 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3073 (Fplay_sound_internal):
3074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3075 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3076 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3077 (Fparse_partial_sexp):
3078 Don't assume fixnums can fit in int.
3079 (struct lisp_parse_state, find_start_pos, find_start_value)
3080 (find_start_value_byte, find_start_begv)
3081 (update_syntax_table, char_quoted, dec_bytepos)
3082 (find_defun_start, prev_char_comend_first, back_comment):
3083 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3084 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3086 (Finternal_describe_syntax_value): Check that match_lisp is a
3087 character, not an integer, since the code stuffs it into int.
3088 (scan_words, scan_sexps_forward):
3089 Check that fixnums are in proper range for system types.
3090 (Fforward_word):
3091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3092 (scan_sexps_forward):
3093 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3094 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3095 * syntax.h: Adjust decls to match defn changes elsewhere.
3096 (struct gl_state_s):
3097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3098 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3099 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3100 * sysdep.c (wait_for_termination_1, wait_for_termination)
3101 (interruptible_wait_for_termination, mkdir):
3102 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3103 (emacs_read, emacs_write):
3104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3105 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3106 and double all fit in int.
d311d28c
PE
3107 * term.c (set_tty_color_mode):
3108 Check that fixnums are in proper range for system types.
3109 * termhooks.h (struct input_event):
3110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3111 * textprop.c (validate_interval_range, interval_of)
3112 (Fadd_text_properties, set_text_properties_1)
3113 (Fremove_text_properties, Fremove_list_of_text_properties)
3114 (Ftext_property_any, Ftext_property_not_all)
3115 (copy_text_properties, text_property_list, extend_property_ranges)
3116 (verify_interval_modification):
3117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3118 (Fnext_single_char_property_change)
3119 (Fprevious_single_char_property_change):
3120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3121 (copy_text_properties):
3122 Check for integer overflow in index calculation.
d311d28c
PE
3123 * undo.c (last_boundary_position, record_point, record_insert)
3124 (record_delete, record_marker_adjustment, record_change)
3125 (record_property_change):
3126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3127 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3129 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3130 (Fx_hide_tip, Fx_file_dialog):
3131 * w32menu.c (set_frame_menubar):
3132 Use ptrdiff_t, not int, for consistency with rest of code.
3133 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3134 (select_window, Fdelete_other_windows_internal)
3135 (window_scroll_pixel_based, window_scroll_line_based)
3136 (Frecenter, Fset_window_configuration):
3137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3138 (Fset_window_hscroll, run_window_configuration_change_hook)
3139 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3140 (Fscroll_other_window, Frecenter):
d311d28c
PE
3141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3142 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3143 Don't assume fixnum fits in int.
3144 (Fset_window_scroll_bars):
3145 Check that fixnums are in proper range for system types.
3146 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3147 (string_pos, c_string_pos, number_of_chars, init_iterator)
3148 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3149 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3150 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3151 (face_before_or_after_it_pos, handle_invisible_prop)
3152 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3153 (display_prop_intangible_p, string_buffer_position_lim)
3154 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3155 (get_overlay_strings_1, get_overlay_strings)
3156 (iterate_out_of_display_property, forward_to_next_line_start)
3157 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3158 (get_next_display_element, set_iterator_to_next)
3159 (get_visually_first_element, compute_stop_pos_backwards)
3160 (handle_stop_backwards, next_element_from_buffer)
3161 (move_it_in_display_line_to, move_it_in_display_line)
3162 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3163 (add_to_log, message_dolog, message_log_check_duplicate)
3164 (message2, message2_nolog, message3, message3_nolog
3165 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3166 (current_message_1, truncate_echo_area, truncate_message_1)
3167 (set_message, set_message_1, store_mode_line_noprop)
3168 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3169 (text_outside_line_unchanged_p, check_point_in_composition)
3170 (reconsider_clip_changes)
3171 (redisplay_internal, set_cursor_from_row, try_scrolling)
3172 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3173 (redisplay_window, find_last_unchanged_at_beg_row)
3174 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3175 (trailing_whitespace_p, find_row_edges, display_line)
3176 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3177 (display_mode_element, store_mode_line_string)
3178 (pint2str, pint2hrstr, decode_mode_spec)
3179 (display_count_lines, display_string, draw_glyphs)
3180 (x_produce_glyphs, x_insert_glyphs)
3181 (rows_from_pos_range, mouse_face_from_buffer_pos)
3182 (fast_find_string_pos, mouse_face_from_string_pos)
3183 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3185 (safe_call, init_from_display_pos, handle_fontified_prop)
3186 (handle_single_display_spec, load_overlay_strings)
3187 (with_echo_area_buffer, setup_echo_area_for_printing)
3188 (display_echo_area, echo_area_display)
3189 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3190 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3191 (redisplay_window, dump_glyph_row, display_mode_line)
3192 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3193 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3195 (handle_single_display_spec, build_desired_tool_bar_string)
3196 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3197 (get_specified_cursor_type):
3198 Check that fixnums are in proper range for system types.
3199 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3200 (Flookup_image_map):
3201 Don't assume fixnums fit in int.
3202 (compare_overlay_entries):
3203 Avoid mishandling comparisons due to subtraction overflow.
3204 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3205 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3206 (handle_tool_bar_click):
3207 Use int, not unsigned, since we prefer signed and the signedness
3208 doesn't matter here.
3209 (get_next_display_element, next_element_from_display_vector):
3210 Use int, not EMACS_INT, when int is wide enough.
3211 (start_hourglass): Use duration_to_sec_usec to do proper
3212 overflow checking on durations.
3213 * xfaces.c (Fbitmap_spec_p):
3214 Check that fixnums are in proper range for system types.
3215 (compare_fonts_by_sort_order):
3216 Avoid mishandling comparisons due to subtraction overflow.
3217 (Fx_family_fonts, realize_basic_faces):
3218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3219 (Fx_family_fonts):
3220 Don't assume fixnum fits in int.
3221 Use SAFE_ALLOCA_LISP, not alloca.
3222 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3223 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3224 (face_at_buffer_position, face_for_overlay_string)
3225 (face_at_string_position):
3226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3227 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3228 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3229 (Fx_show_tip):
3230 Check that fixnums are in proper range for system types.
3231 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3232 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3234 (Fx_change_window_property): Don't assume fixnums fit in int.
3235 * xfont.c (xfont_chars_supported):
3236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3237 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3238 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3240 * xml.c (parse_region):
3241 * xrdb.c (magic_file_p):
3242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3243 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3244 (x_get_local_selection, x_reply_selection_request)
3245 (x_handle_selection_request, wait_for_property_change):
3246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3247 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3248 short is wide enough.
3249 (x_send_client_event): Don't assume fixnum fits in int.
3250 * xterm.c (x_x_to_emacs_modifiers):
3251 Don't assume EMACS_INT overflows nicely into int.
3252 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3253 may come from Lisp.
3254 (handle_one_xevent): NATNUMP can eval its arg twice.
3255 (x_connection_closed):
3256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3257 * xterm.h: Adjust decls to match defn changes elsewhere.
3258 (struct scroll_bar): Use struct vectorlike_header
3259 rather than rolling our own approximation.
3260 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3261
c6574eb5
GM
32622012-05-25 Glenn Morris <rgm@gnu.org>
3263
3264 * lisp.mk (lisp): Update for more files being compiled now.
3265
e8d32c7e
SM
32662012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3267
48def666
SM
3268 * lread.c: Remove `read_pure' which makes no difference.
3269 (read_pure): Remove var.
3270 (unreadpure): Remove function.
3271 (readevalloop): Don't call read_list with -1 flag.
3272 (read1, read_vector): Don't test read_pure any more.
3273 (read_list): Simplify.
3274
e8d32c7e
SM
3275 * fileio.c, character.h: Minor style tweaks.
3276
4b2addb7
DA
32772012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3278
3279 * window.h (clip_changed): Remove useless declaration.
3280
584461b2
JB
32812012-05-22 Juanma Barranquero <lekktu@gmail.com>
3282
3283 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3284 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3285
34374650
PE
32862012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 Remove src/m/*.
3289 This directory predates autoconf and is no longer needed nowadays.
3290 Move its few remaining bits of functionality to where they're needed.
3291 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3292 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3293 * m/template.h: Remove.
3294 * Makefile.in (M_FILE): Remove. All uses removed.
3295 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3296 * lisp.h (USE_LSB_TAG):
3297 * mem-limits.h (EXCEEDS_LISP_PTR):
3298 Use VAL_MAX, not VALBITS, in #if.
3299 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3300 (EMACS_UINT): Define unconditionally now.
3301 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3302 (BITS_PER_EMACS_INT): New constants, replacing
3303 what used to be in config.h, but not useful in #if.
3304 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3305 define them any more.
3306 (VAL_MAX): New macro.
3307 (VALMASK): Use it.
3308 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3309 BITS_PER_EMACS_INT, in #if.
3310 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3311 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3312 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3313 * s/ms-w32.h (DATA_START):
3314 Move here from removed file m/intel386.h.
3315 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3316 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3317
261cb4bb
PE
33182012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3319
3320 Assume C89 or later.
3321 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3322 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3323 (xrealloc):
3324 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3325 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3326 * textprop.c, tparam.c (NULL): Remove.
3327 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3328 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3329 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3330 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3331 * xterm.c (input_signal_count): Assume volatile works.
3332
ff23cd9f
KB
33332012-05-21 Ken Brown <kbrown@cornell.edu>
3334
3335 * xgselect.c (xg_select): Fix first argument in call to 'select'
3336 (bug#11508).
3337
1b170bc6
KB
33382012-05-20 Ken Brown <kbrown@cornell.edu>
3339
3340 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3341 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3342
b2f4d39f
KB
33432012-05-19 Ken Brown <kbrown@cornell.edu>
3344
3345 * xfns.c (x_in_use): Remove `static' qualifier.
3346 * xterm.h (x_in_use): Declare.
3347 * xgselect.c: Include xterm.h.
3348 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3349 and `display_arg' (bug#9754).
3350
003fdae2
PE
33512012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3352
9232a6d9
PE
3353 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3354
003fdae2
PE
3355 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3356 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3357
784b56e2
EZ
33582012-05-18 Eli Zaretskii <eliz@gnu.org>
3359
3360 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3361
3362 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3363 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3364
3365 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3366 reference to image_cache->refcount.
3367 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3368
a0a79cde
JL
33692012-05-17 Juri Linkov <juri@jurta.org>
3370
3371 * search.c (Fword_search_regexp, Fword_search_backward)
3372 (Fword_search_forward, Fword_search_backward_lax)
3373 (Fword_search_forward_lax): Move functions to isearch.el
3374 (bug#10145, bug#11381).
3375
b0572523
PE
33762012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3379
9660f5fc
SM
33802012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3381
3382 * lread.c (init_obarray): Declare Qt and Qnil as special.
3383
4374de83
GM
33842012-05-14 Glenn Morris <rgm@gnu.org>
3385
3386 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3387 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3388
dc44c39a
PE
33892012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3390
078c97cb
PE
3391 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3392
dc44c39a
PE
3393 * unexaix.c: Port to more-recent AIX compilers.
3394 (report_error, report_error_1, make_hdr, copy_sym)
3395 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3396 Make arguments const char *, not char *, to avoid violations of C
3397 standard and to fix some AIX warnings reported by Gilles Pion.
3398
e18afed7 33992012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3400
3401 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3402 already have overlays loaded.
3403 (handle_single_display_spec): Before returning without displaying
3404 fringe bitmap, synchronize the bidi iterator with the main display
3405 iterator, by calling iterate_out_of_display_property.
3406 (iterate_out_of_display_property): Detect buffer iteration by
3407 testing that it->string is a Lisp string.
3408 (get_next_display_element): When the current object is exhausted,
3409 and there's something on it->stack, call set_iterator_to_next to
3410 proceed with what's on the stack, instead of returning zero.
3411 (set_iterator_to_next): If called at the end of a Lisp string,
3412 proceed to consider_string_end without incrementing string
3413 position. Don't increment display vector index past the end of
3414 the display vector. (Bug#11417)
c8fb9dc6
EZ
3415 (pos_visible_p): Don't report a position visible when move_it_to
3416 stopped at the last line of window, which happens to be scanned
3417 backwards by the bidi iteration. (Bug#11464)
ac268e67 3418
e18afed7 34192012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3420
3421 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3422 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3423 are on a TTY, and thus unable to display on the fringes.
3424 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3425 so we need to signal to the caller that this is a "replacing"
3426 display spec. This fixes display when the spec is invalid or we
3427 are on a TTY.
3428
e18afed7 34292012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3430
3431 * unexaix.c (make_hdr): Fix typo in prototype.
3432 This bug broke the build on AIX. Problem reported by Gilles Pion.
3433
9d0a235a
MA
34342012-05-14 Michael Albinus <michael.albinus@gmx.de>
3435
3436 * keyboard.c (kbd_buffer_get_event): Read special events also in
3437 batch mode. (Bug#11415)
3438
9e6b06ed
GM
34392012-05-12 Glenn Morris <rgm@gnu.org>
3440
3441 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3442
c1a1d7a3
EZ
34432012-05-12 Eli Zaretskii <eliz@gnu.org>
3444
3445 * lisp.mk (lisp): Add newcomment.elc.
3446
3fe7cdc8
GM
34472012-05-12 Glenn Morris <rgm@gnu.org>
3448
3449 * Makefile.in (MKDIR_P): New, set by configure.
3450 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3451
53f7d2c0
PE
34522012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3453
3454 Remove unused function hourglass_started.
3455 * dispextern.h (hourglass_started):
3456 * w32fns.c (hourglass_started):
3457 * xdisp.c (hourglass_started): Remove.
3458
75aafb17
JB
34592012-05-10 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3462 Update dependencies.
3463
12959e8e
PE
34642012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3465
97107e2e
PE
3466 * xgselect.c (xg_select): Put maxfds+1 into a var.
3467 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3468
12959e8e
PE
3469 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3470
836d29b3
DA
34712012-05-10 Dave Abrahams <dave@boostpro.com>
3472
3473 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3474 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3475
5cb67954
MA
34762012-05-09 Michael Albinus <michael.albinus@gmx.de>
3477
3478 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3479 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3480 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3481 Initialize xd_registered_buses.
3482
3478ec45
PE
34832012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3484
b263a6b0
PE
3485 Untag more efficiently if USE_LSB_TAG.
3486 This is based on a proposal by YAMAMOTO Mitsuharu in
3487 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3488 For an admittedly artificial (nth 8000 longlist) benchmark on
3489 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3490 Emacs's overall text size by 1%.
3491 * lisp.h (XUNTAG): New macro.
3492 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3493 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3494 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3495 * eval.c (Fautoload):
3496 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3497 * frame.h (XFRAME): Use XUNTAG.
3498
3478ec45
PE
3499 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3500 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3501 Remove unportable assumptions about print widths of types like
3502 dbus_uint32_t.
3503 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3504 intptr_t when converting between pointer and integer, to avoid GCC
3505 warnings about wrong width.
3506
666b903b 35072012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3508
3509 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3510 stack for each reader_thread, instead of defaulting to 8MB
3511 determined by the linker. This avoids failures in creating
3512 subprocesses on Windows 7, see the discussion in this thread:
3513 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3514
b120cc17
JC
35152012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3516
3517 Fix up display of the *Minibuf-0* buffer in the mini window.
3518 * keyboard.c (read_char): Don't clear the echo area if there's no
3519 message to clear.
3520 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3521 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3522
9a4b36f8
MA
35232012-05-07 Michael Albinus <michael.albinus@gmx.de>
3524
3525 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3526 batch mode.
3527
e5f9458f
CY
35282012-05-06 Chong Yidong <cyd@gnu.org>
3529
3530 * lisp.mk (lisp): Update.
3531
eceeb5fc 35322012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3533
3534 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3535
71873e2b
SM
35362012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3537
3538 * data.c (PUT_ERROR): New macro.
3539 (syms_of_data): Use it. Add new error type `user-error'.
3540 * undo.c (user_error): New function.
3541 (Fprimitive_undo): Use it.
3542 * print.c (print_error_message): Adjust print style for `user-error'.
3543 * keyboard.c (user_error): New function.
3544 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3545
ab0fa4e4
PE
35462012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3547
3548 Do not limit current-time-string to years 1000..9999.
3549 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3550 (Fcurrent_time_string): Support any year that is supported by the
3551 underlying localtime representation. Don't use asctime, as it
3552 has undefined behavior for years outside the range -999..9999.
3553
7ed806a7
PE
35542012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 Fix race conditions involving setenv, gmtime, localtime, asctime.
3557 Without this fix, interrupts could mess up code that uses these
3558 nonreentrant functions, since setting TZ invalidates existing
3559 tm_zone or tzname values, and since most of these functions return
3560 pointers to static storage.
3561 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3562 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3563 Grow the critical sections to include not just invoking
3564 localtime/gmtime, but also accessing these functions' results
3565 including their tm_zone values if any, and any related TZ setting.
3566 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3567 so that the struct tm is saved in the critical section.
3568 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3569 motivated by the fact that memory allocation needs to be outside
3570 the critical section.
3571
0c16dfed
DA
35722012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3573
3574 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3575 with RESET_INTERVAL.
3576
3577 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3578 Remove duplicated buffer name initialization.
3579
3f83ace8
JM
35802012-05-02 Jim Meyering <jim@meyering.net>
3581
3582 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3583
c7b8541e
JM
3584 * xfns.c (x_window): Use xstrdup (Bug#11375).
3585
90207a15 35862012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3587
3588 * xdisp.c (pos_visible_p): If already at a newline from the
3589 display string before the 'while' loop, don't walk back the glyphs
3590 from it3.glyph_row. Solves assertion violation when the display
3591 string begins with a newline (egg.el). (Bug#11367)
3592
b593d6a9
AH
35932012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3594
3595 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3596 Move to simple.el.
3597
4737362e
GM
35982012-05-01 Glenn Morris <rgm@gnu.org>
3599
99cf43f9
GM
3600 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3601 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3602 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3603 All were removed before 23.1.
3604
9311dcff
GM
3605 * dispnew.c: Remove HAVE_LIBNCURSES test;
3606 it is always true on relevant platforms.
3607
4d5c6349
GM
3608 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3609 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3610
4737362e
GM
3611 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3612
74dd3a6b
AS
36132012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3614
3615 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3616 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3617 Remove.
3618
13c379ee
PE
36192012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3620
3621 Do not avoid creating empty evaporating overlays (Bug#9642).
3622 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3623 That is, do not delete an evaporating overlay if it becomes
3624 empty after its bounds are adjusted to fit within its buffer.
3625 This fix caused other problems, and I'm reverting it until we get
3626 to the bottom of them.
3627
a8e7d6d7 36282012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3629
3630 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3631
a8e7d6d7 36322012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3633
3634 * xdisp.c (pos_visible_p): If the window start position is beyond
3635 ZV, start the display from buffer beginning. Prevents assertion
3636 violation in init_iterator when the minibuffer window is scrolled
3637 via the scroll bar.
3638
3639 * window.c (window_scroll_pixel_based): Likewise.
3640
a8e7d6d7 36412012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3642
3643 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3644
a8e7d6d7 36452012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3646
3647 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3648 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3649
a8e7d6d7 36502012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3651
b593d6a9
AH
3652 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3653 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3654
1c6900d9
EZ
36552012-04-26 Eli Zaretskii <eliz@gnu.org>
3656
4c3fa1d9
EZ
3657 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3658 display element, check also the underlying string or buffer
3659 character. (Bug#11341)
3660
1c6900d9
EZ
3661 * w32menu.c: Include w32heap.h.
3662 (add_menu_item): If the call to AppendMenuW (via
3663 unicode_append_menu) fails, disable Unicode menus only if we are
3664 running on Windows 9X/Me.
3665
42bf8205
AS
36662012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3667
3668 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3669 (xgetint): Add missing shift for LSB tags.
3670
b1bac16e
MR
36712012-04-24 Martin Rudalics <rudalics@gmx.at>
3672
3673 * keyboard.c (read_char): Don't wipe echo area for select window
3674 events: These might get delayed via `mouse-autoselect-window'
3675 (Bug#11304).
3676
d69621cc
JB
36772012-04-24 Juanma Barranquero <lekktu@gmail.com>
3678
3679 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3680 manipulation of :loaded-from data.
3681
02fd101b
JB
36822012-04-23 Juanma Barranquero <lekktu@gmail.com>
3683
3684 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3685 now a cons (bug#11311).
3686
888bec30
PE
36872012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3688
89a438bd
PE
3689 Do not create empty overlays with the evaporate property (Bug#9642).
3690 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3691 if it becomes empty after its bounds are adjusted to fit within
3692 its buffer. Without this fix, in a nonempty buffer (let ((o
3693 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3694 yields an empty overlay that has the evaporate property, which is
3695 not supposed to happen.
3696
1068fe4d
PE
3697 Fix minor GTK3 problems found by static checking.
3698 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3699 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3700 (struct _EmacsFixedClass, emacs_fixed_get_type):
3701 Move decls here from emacsgtkfixed.h, since they needn't be public.
3702 (emacs_fixed_get_type): Now static.
3703 (emacs_fixed_class_init): Omit unused local.
3704 (emacs_fixed_child_type): Remove; unused.
3705 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3706 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3707 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3708 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3709 (EMACS_FIXED_GET_CLASS): Remove; unused.
3710 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3711
888bec30
PE
3712 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3713 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3714
de85e130
PE
37152012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3716
d0baac98 3717 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3718 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3719 (__malloc_size_t, __malloc_ptrdiff_t):
3720 Remove. All uses removed, replaced by the definiens if needed,
3721 since we can assume C89 or better now.
3722 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3723 (protect_malloc_state, align, get_contiguous_space)
3724 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3725 (malloc_atfork_handler_child, malloc_enable_thread)
3726 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3727 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3728 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3729 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3730 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3731 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3732 Define using prototypes, not old style.
3733 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3734 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3735 (align): Don't assume that signed integer overflow wraps around.
3736 Omit unused local var.
3737 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3738 (_free_internal_nolock, memalign, mallochook, reallochook):
3739 Omit no-longer-needed casts.
3740 (valloc): Use getpagesize, not __getpagesize.
3741 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3742 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3743
de85e130
PE
3744 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3745
dcbf5805
MA
37462012-04-22 Michael Albinus <michael.albinus@gmx.de>
3747
3748 Move functions from C to Lisp. Make non-blocking method calls
3749 the default. Implement further D-Bus standard interfaces.
3750
3751 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3752 (QCdbus_request_name_allow_replacement)
3753 (QCdbus_request_name_replace_existing)
3754 (QCdbus_request_name_do_not_queue)
3755 (QCdbus_request_name_reply_primary_owner)
3756 (QCdbus_request_name_reply_in_queue)
3757 (QCdbus_request_name_reply_exists)
3758 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3759 (QCdbus_registered_serial, QCdbus_registered_method)
3760 (QCdbus_registered_signal): New Lisp objects.
3761 (XD_DEBUG_MESSAGE): Use sizeof.
3762 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3763 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3764 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3765 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3766 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3767 (xd_signature, xd_append_arg): Allow float for integer types.
3768 (xd_get_connection_references): New function.
b593d6a9
AH
3769 (xd_get_connection_address): Rename from xd_initialize.
3770 Return cached address.
dcbf5805
MA
3771 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3772 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3773 level.
3774 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3775 Return number of refcounts.
dcbf5805
MA
3776 (Fdbus_get_unique_name): Make stronger parameter check.
3777 (Fdbus_message_internal): New defun.
3778 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3779 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3780 (Fdbus_send_signal, Fdbus_register_service)
3781 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3782 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3783 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3784 (Vdbus_compiled_version, Vdbus_runtime_version)
3785 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3786 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3787 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3788 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3789 Adapt docstring.
dcbf5805 3790
52828e02
PE
37912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3792
da05bc4c
PE
3793 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3794 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3795 Do not assume ptrdiff_t is the same width as 'int'.
3796
52828e02
PE
3797 * alloc.c: Handle unusual debugging option combinations.
3798 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3799 since the two debugging options are incompatible.
3800 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3801 is defined.
3802 (mem_init, mem_insert, mem_insert_fixup):
3803 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3804 (NEED_MEM_INSERT): Remove; no longer needed.
3805
f01769f9
LL
38062012-04-22 Leo Liu <sdl.web@gmail.com>
3807
3808 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3809
5790543d
PE
38102012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 * sysdep.c [__FreeBSD__]: Minor cleanups.
3813 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3814 Use Emacs indenting style more consistently. Avoid some casts.
3815 Use 'double' consistently rather than mixing 'float' and 'double'.
3816
b91b7e4d
EW
38172012-04-21 Eduard Wiebe <usenet@pusto.de>
3818
b593d6a9
AH
3819 * sysdep.c (list_system_processes, system_process_attributes):
3820 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3821
6114eb15
AS
38222012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3823
3824 * lisp.mk (lisp): Update.
3825
2f38dff7
PE
38262012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3829 It is never used otherwise.
3830
4ae29f89
SM
38312012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3832
3833 * print.c (print_preprocess): Only check print_depth if print-circle
3834 is nil.
3835 (print_object): Check for cycles even when print-circle is nil and
3836 print-gensym is t, but only check print_depth if print-circle is nil.
3837
f30d612a
CY
38382012-04-20 Chong Yidong <cyd@gnu.org>
3839
3840 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3841 set the status to "failed" and ensure that sentinel is run.
3842
c07a4c0b 38432012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3844
3845 * process.c (Fset_process_inherit_coding_system_flag)
3846 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3847 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3848
c07a4c0b 38492012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3850
3851 * xdisp.c (string_buffer_position_lim): Limit starting position to
3852 BEGV.
3853 (set_cursor_from_row): If called for a mode-line or header-line
3854 row, return zero immediately.
3855 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3856 farther than the first row after the header line, if any.
3857 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3858 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3859
c07a4c0b 38602012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3861
4ae29f89
SM
3862 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3863 (bug#11238).
ad3a2b41 3864
c07a4c0b 38652012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 38662012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3867
3868 configure: new option --enable-gcc-warnings (Bug#11207)
3869 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3870 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3871 (ALL_CFLAGS): Use new macros rather than old.
3872 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3873 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3874 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3875 -Wunused-result, -Wunused-variable. This should go away once
3876 the Emacs and Gnulib regex code is merged.
3877 (xmalloc, xrealloc): Now static.
3878
aba027e8
PE
38792012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 * dired.c (Fsystem_groups): Remove unused local.
3882
e5a36063
GM
38832012-04-17 Glenn Morris <rgm@gnu.org>
3884
3885 * dired.c (Fsystem_users): Doc fix.
3886
316411f0
DA
38872012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3888
3889 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3890 (syms_of_dired): Add them.
3891
9426aba4
PE
38922012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3893
b62a57be
PE
3894 Fix minor alloc.c problems found by static checking.
3895 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3896 New extern decls, to avoid calling undeclared functions.
3897 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3898 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3899 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3900 (NEED_MEM_INSERT): New macro.
3901 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3902 Remove one incorrect comment and fix another.
b62a57be 3903
3539f31f
PE
3904 Fix minor ralloc.c problems found by static checking.
3905 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3906 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3907 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3908 (r_alloc_sbrk): Now static.
3909
a041960a
PE
3910 Improve ralloc.c interface checking.
3911 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3912 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3913 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3914 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3915 [REL_ALLOC]: ... to here, to check interface.
3916 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3917 Remove decls. This fixes an "It stinks!".
3918
9426aba4
PE
3919 * alloc.c (which_symbols): Fix alignment issue / type clash.
3920
d55c12ed
AS
39212012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3922
3923 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3924 (struct Lisp_Misc_Any): Likewise.
3925 (struct Lisp_Free): Likewise.
3926 * alloc.c (union aligned_Lisp_Symbol): Define.
3927 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3928 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3929 (union aligned_Lisp_Misc): Define.
3930 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3931 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3932 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3933
b948ce8b
PE
39342012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3935
3936 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3937 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3938 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3939 * s/netbsd.h, s/sol2-6.h:
3940 Remove definition of GC_MARK_STACK, since the default now works.
3941 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3942 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3943 no longer the default.
3944 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3945
35dc09a1 39462012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3947
35dc09a1
GM
3948 * lread.c (lisp_file_lexically_bound_p):
3949 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3950
35dc09a1
GM
39512012-04-14 Eli Zaretskii <eliz@gnu.org>
3952
3953 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3954 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3955
39562012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3957
3958 * nsterm.m (constrainFrameRect): Always constrain when there is only
3959 one screen (Bug#10962).
3960
bcd86815
KB
39612012-04-13 Ken Brown <kbrown@cornell.edu>
3962
3963 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3964
c25df26e
RT
39652012-04-13 Reuben Thomas <rrt@sc3d.org>
3966
3967 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3968
0fc59f1e
DC
39692012-04-11 Daniel Colascione <dancol@dancol.org>
3970
3971 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3972 against is gone. It's better to use vfork now so that when Cygwin
3973 gains a new, working vfork, we use it automatically (bug#10398).
3974
de8c03dc
SM
39752012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3976
3977 * window.c (save_window_save): Obey window-point-insertion-type.
3978
2f097256
GM
39792012-04-11 Glenn Morris <rgm@gnu.org>
3980
3981 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3982
453b951e
SM
39832012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3984
3985 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3986
75f1671a 39872012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3988
3989 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3990 (force_quit_count): New var.
3991 (handle_interrupt): Use it.
3992
2a8ce227
JB
39932012-04-10 Juanma Barranquero <lekktu@gmail.com>
3994
3995 * w32.c (w32_delayed_load): Record the full path of the library
3996 being loaded (bug#10424).
3997
935396c0
GM
39982012-04-09 Glenn Morris <rgm@gnu.org>
3999
05920a43
GM
4000 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4001 not just in the obarray, before snarfing them. (Bug#11036)
4002
935396c0
GM
4003 * Makefile.in ($(leimdir)/leim-list.el):
4004 Pass EMACS rather than BUILT_EMACS.
4005
a18ecafa
TZ
40062012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4007
4008 * process.c (make_process):
4009 * process.h: Add integer `gnutls_handshakes_tried' member to
4010 process struct.
4011
6bbef4e5
JC
4012 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4013 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4014
4015 * gnutls.c (gnutls_log_function2i): Convenience log function.
4016 (emacs_gnutls_read): Use new log functions,
4017 `gnutls_handshakes_tried' process member, and
4018 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4019 attempts per process (connection).
4020
b4d3bc10
CY
40212012-04-09 Chong Yidong <cyd@gnu.org>
4022
4023 * eval.c (Fuser_variable_p, user_variable_p_eh)
4024 (lisp_indirect_variable): Functions deleted.
4025 (Fdefvar): Caller changed.
4026
4027 * callint.c (Finteractive, Fcall_interactively):
4028 * minibuf.c (Fread_variable): Callers changed.
4029
70f4d973
EZ
40302012-04-09 Eli Zaretskii <eliz@gnu.org>
4031
4032 * xdisp.c (set_cursor_from_row): If the display string appears in
4033 the buffer at position that is closer to point than the position
4034 after the display string, display the cursor on the first glyph of
4035 the display string. Fixes cursor display when a 'display' text
4036 property immediately follows invisible text. (Bug#11094)
4037
cb3c2e3e
PE
40382012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4039
4040 composite.c: use 'double' consistently
4041 * composite.c (get_composition_id): Use 'double' consistently
4042 instead of converting 'float' to 'double' and vice versa; this is
4043 easier to understand and avoids a GCC warning.
4044
fd06db5d
GM
40452012-04-09 Glenn Morris <rgm@gnu.org>
4046
50fe702a
GM
4047 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4048 preparation for dumping it with emacs. (Bug#4789)
4049 (leimdir): New variable.
4050 ($(leimdir)/leim-list.el): New rule.
4051 (emacs$(EXEEXT)): Depend on leim-list.el.
4052
fd06db5d
GM
4053 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4054 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4055 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4056
55c131ee
AS
40572012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4058
4059 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4060 proper alignment.
4061
9209588f
JB
40622012-04-07 Juanma Barranquero <lekktu@gmail.com>
4063
4064 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4065 Remove unused local variable.
4066
e3fb2efb
PE
40672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4070 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4071 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4072 objects, as mark_maybe_pointer will catch them otherwise.
4073 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4074 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4075
b5385551
PE
40762012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 Fix typo that broke non-Windows builds.
4079 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4080
9078ead6
EZ
40812012-04-07 Eli Zaretskii <eliz@gnu.org>
4082
4083 Support building on MS-Windows with libxml2.
4084
4085 * makefile.w32-in (OBJ2): Add xml.$(O).
4086 (GLOBAL_SOURCES): Add xml.c.
4087 ($(BLD)/xml.$(O)): New dependency list.
4088
4089 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4090 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4091 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4092 [!WINDOWSNT]: New macros.
4093 (init_libxml2_functions, libxml2_loaded_p): New functions.
4094 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4095 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4096 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4097 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4098 linked in).
6bbef4e5
JC
4099 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4100 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4101 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4102
4103 * emacs.c: Don't include libxml/parser.h.
4104 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4105 xmlCleanupParser directly.
4106
4107 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4108
3811fdf3
EZ
41092012-04-07 Eli Zaretskii <eliz@gnu.org>
4110
4111 * indent.c (Fvertical_motion): If there is a display string at
4112 point, use it.vpos to compute how many lines to backtrack after
4113 move_it_to point. (Bug#11133)
4114
2f8e16b2
EZ
41152012-04-06 Eli Zaretskii <eliz@gnu.org>
4116
4117 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4118 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4119 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4120 macros related to unification of CJK characters. For the details,
4121 see the discussion following the message here:
4122 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4123
3d439cd1
CY
41242012-04-04 Chong Yidong <cyd@gnu.org>
4125
4126 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4127
8bc53d00
EZ
41282012-04-01 Eli Zaretskii <eliz@gnu.org>
4129
4130 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4131 instead of alloca. (Bug#11138)
4132
3b0512a3
AS
41332012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4134
4135 * w32menu.c (is_simple_dialog): Properly check lisp types.
4136 (Bug#11141)
4137
8427ddd2
EZ
41382012-03-31 Eli Zaretskii <eliz@gnu.org>
4139
979022ef
EZ
4140 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4141 position we get to after a call to move_it_to fails the
4142 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4143 only if we wind up in a string from display property. (Bug#11063)
4144
a6b1c7cc
EZ
4145 * window.c (Fdelete_other_windows_internal): Invalidate the row
4146 and column information about mouse highlight, so that redisplay
4147 restores it after reallocating the glyph matrices. (Bug#7464)
4148
8427ddd2
EZ
4149 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4150 string comes from a `display' text property, use the buffer
4151 position of that property as if we actually saw that position in
4152 the row's glyphs.
697ba24b
EZ
4153 (move_it_by_lines): Remove the assertion that
4154 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4155 violated when there's a before-string at the beginning of a line.
4156 (Bug#11063)
8427ddd2 4157
65a0a738
EZ
41582012-03-30 Eli Zaretskii <eliz@gnu.org>
4159
4160 * xdisp.c (append_space_for_newline): If the default face was
4161 remapped, use the remapped face for the appended newline.
4162 (extend_face_to_end_of_line): Use the remapped default face for
4163 extending the face to the end of the line.
4164 (display_line): Call extend_face_to_end_of_line when the default
4165 face was remapped. (Bug#11068)
4166
581355cc
EZ
41672012-03-29 Eli Zaretskii <eliz@gnu.org>
4168
4169 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4170
e8fc049f
SM
41712012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4172
4173 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4174
4fb9a543
GM
41752012-03-27 Glenn Morris <rgm@gnu.org>
4176
4177 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4178 Doc fixes.
4179
679910f1
KH
41802012-03-26 Kenichi Handa <handa@m17n.org>
4181
4182 * dispextern.h (struct glyph): Fix previous change. Change the
4183 bit length of glyphless.ch to 25 (Bug#11082).
4184
90d49b7f
CY
41852012-03-26 Chong Yidong <cyd@gnu.org>
4186
4187 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4188 (command_loop_1): Use it; inhibit selection update for
4189 handle-select-window too (Bug#8996).
4190
f514f6f0
FP
41912012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4192
e8fc049f 4193 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4194
bf43fa51
KH
41952012-03-25 Kenichi Handa <handa@m17n.org>
4196
4197 * dispextern.h (struct glyph): Change the bit length of
4198 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4199
8a0c01dd
EZ
42002012-03-24 Eli Zaretskii <eliz@gnu.org>
4201
4202 * s/ms-w32.h (tzname): Include time.h before redirecting to
4203 _tzname. Fixes the MSVC build. (Bug#9960)
4204
7d1c3a76
AS
42052012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4206
8ed79523
AS
4207 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4208 characters.
4209
7d1c3a76
AS
4210 * xterm.c (XTread_socket): Only modify handling_signal if
4211 !SYNC_INPUT. (Bug#11080)
4212
e99a9b8b
EZ
42132012-03-23 Eli Zaretskii <eliz@gnu.org>
4214
4215 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4216 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4217 when fetching a multibyte character consumes more bytes than
4218 CHAR_BYTES returns, due to unification of CJK characters in
4219 string_char. (Bug#11073)
4220
5063c0e1
TN
42212012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4222
4223 * process.c (wait_reading_process_output): Handle pty disconnect
4224 by refraining from sending oneself a SIGCHLD (bug#10933).
4225
9f851fbd
CY
42262012-03-22 Chong Yidong <cyd@gnu.org>
4227
4228 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4229
5063c0e1 4230 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4231 Mark string as coming from a prefix property.
4232 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4233 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4234
fb5b8aca
CY
42352012-03-21 Chong Yidong <cyd@gnu.org>
4236
4237 * xfaces.c (Vface_remapping_alist): Doc fix.
4238
62356a1b
EZ
42392012-03-20 Eli Zaretskii <eliz@gnu.org>
4240
4241 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4242 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4243 Doc fixes.
62356a1b 4244
025de85b
CY
42452012-03-20 Chong Yidong <cyd@gnu.org>
4246
4247 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4248 to reflect default non-nil value of redisplay-dont-pause.
4249
4827f94e
KH
42502012-03-19 Kenichi Handa <handa@m17n.org>
4251
4252 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4253 it fit in a valid range (Bug#11003).
4254
e50a24a2
EZ
42552012-03-18 Eli Zaretskii <eliz@gnu.org>
4256
4257 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4258 that is not from display property, accept the row as a "cursor
4259 row" if one of the string's character has a non-nil `cursor'
4260 property. Fixes cursor positioning when there are newlines in
4261 overlay strings, e.g. in icomplete.el. (Bug#11035)
4262
9af5ed87
PE
42632012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4264
4265 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4266
d1f55f16
CY
42672012-03-12 Chong Yidong <cyd@gnu.org>
4268
4269 * eval.c (inhibit_lisp_code): Rename from
4270 inhibit_window_configuration_change_hook; move from window.c.
4271
4272 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4273 * window.c (run_window_configuration_change_hook)
4274 (syms_of_window): Callers changed.
4275
66c5eebd
CY
42762012-03-11 Chong Yidong <cyd@gnu.org>
4277
413df973
CY
4278 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4279
66c5eebd
CY
4280 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4281
1de11f56
CY
42822012-03-10 Chong Yidong <cyd@gnu.org>
4283
4284 * frame.c (other_visible_frames): Don't assume the selected frame
4285 is visible (Bug#10955).
4286
cae07000
SM
42872012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4288
4289 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4290
89c94350
JD
42912012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4292
4293 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4294 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4295 zero (Bug#10954).
4296
999dd333
GM
42972012-03-03 Glenn Morris <rgm@gnu.org>
4298
01a6dcc8 4299 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4300
de0100f2
EZ
43012012-03-02 Eli Zaretskii <eliz@gnu.org>
4302
4303 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4304 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4305 (redisplay_window, next_element_from_string): Fix typos in
4306 comments.
3e441275
EZ
4307 (redisplay_window): Pass to move_it_vertically the margin in
4308 pixels, not in screen lines.
de0100f2 4309
96a72ee9
GM
43102012-03-02 Glenn Morris <rgm@gnu.org>
4311
4312 * buffer.c (buffer-list-update-hook): Doc fix.
4313
312508d7
EZ
43142012-02-29 Eli Zaretskii <eliz@gnu.org>
4315
4316 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4317 push_it before setting up the iterator for the first overlay
4318 string, even if we have an empty string loaded.
4319 (next_overlay_string): If there's an empty string on the iterator
4320 stack, pop the stack. (Bug#10903)
4321
27f3c637
PE
43222012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4325 Suggested by Stefan Monnier in
4326 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4327 * alloc.c (widen_to_Lisp_Object): New static function.
4328 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4329 and widening them to Lisp_Objects. This would work even if
4330 USE_LSB_TAG is defined and wide integers are used, which might
4331 happen in a future version of Emacs.
4332
3c9dfce6
CY
43332012-02-25 Chong Yidong <cyd@gnu.org>
4334
fa74b241
CY
4335 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4336 Doc fix.
4337
3c9dfce6
CY
4338 * xselect.c (Fx_selection_exists_p): Doc fix.
4339 (x_clipboard_manager_save_all): Print an informative message
4340 before saving to clipboard manager.
4341
9486df08
CY
43422012-02-24 Chong Yidong <cyd@gnu.org>
4343
4344 * keyboard.c (process_special_events): Handle all X selection
4345 requests in kbd_buffer, not just the next one (Bug#8869).
4346
f01d3321
CY
43472012-02-23 Chong Yidong <cyd@gnu.org>
4348
4349 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4350 call when setting menu-bar-lines and tool-bar-lines parameters.
4351 (unwind_create_frame_1): New helper function.
4352
4353 * window.c (inhibit_window_configuration_change_hook): New var.
4354 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4355 (syms_of_window): Initialize it.
f01d3321 4356
86b847b6
CY
43572012-02-22 Chong Yidong <cyd@gnu.org>
4358
4359 * xterm.c (x_draw_image_relief): Add missing type check for
4360 Vtool_bar_button_margin (Bug#10743).
4361
a59225b1
CY
43622012-02-21 Chong Yidong <cyd@gnu.org>
4363
4364 * fileio.c (Vfile_name_handler_alist): Doc fix.
4365
4366 * buffer.c (Fget_file_buffer): Protect against invalid file
4367 handler return value.
4368
310f5bd4
PE
43692012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4370
cb3a28cc
PE
4371 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4372 when computing $valmask.
4373
310f5bd4
PE
4374 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4375 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4376 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4377 It's useless in that case, and it can cause problems on hosts
4378 that allocate halves of EMACS_INT values separately.
4379 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4380 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4381 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4382 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4383 it avoids undefined behavior on hosts where shifting right by more
4384 than the word width has undefined behavior.
4385
2375c96a
CY
43862012-02-19 Chong Yidong <cyd@gnu.org>
4387
4388 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4389 (Funhandled_file_name_directory, Ffile_name_as_directory)
4390 (Fdirectory_file_name, Fexpand_file_name)
4391 (Fsubstitute_in_file_name): Protect against invalid file handler
4392 return values (Bug#10845).
4393
3eb49e71
EZ
43942012-02-18 Eli Zaretskii <eliz@gnu.org>
4395
4396 * .gdbinit (pitx): Fix incorrect references to fields of the
4397 iterator stack.
4398
7b926f3f
CY
43992012-02-17 Chong Yidong <cyd@gnu.org>
4400
4401 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4402
11273115
PE
44032012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4404
4405 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4406 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4407
c3a70e2b
CY
44082012-02-15 Chong Yidong <cyd@gnu.org>
4409
4410 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4411 marked as special. Also, starting docstrings with * is obsolete.
4412
0ca43699
AS
44132012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4414
4415 * gnutls.c (emacs_gnutls_write): Fix last change.
4416
2e8f3c56
LI
44172012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4418
4419 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4420 send_process.
4421
af70074f
SM
44222012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4423
4424 * keymap.c (Fsingle_key_description): Handle char ranges.
4425
95986d52
CY
44262012-02-12 Chong Yidong <cyd@gnu.org>
4427
afd83bd1
CY
4428 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4429 as that creates a dangerous corner case.
4430
95986d52
CY
4431 * window.c (Fdelete_window_internal): Invalidate the mouse
4432 highlight (Bug#9904).
4433
bd7da63e
GM
44342012-02-12 Glenn Morris <rgm@gnu.org>
4435
4436 * xselect.c (Fx_own_selection_internal)
4437 (Fx_get_selection_internal, Fx_disown_selection_internal)
4438 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4439 * nsselect.m (Fx_own_selection_internal)
4440 (Fx_disown_selection_internal, Fx_selection_exists_p)
4441 (Fx_selection_owner_p, Fx_get_selection_internal):
4442 Sync docs and argument specs with the xselect.c versions.
4443
77abcbc2
LI
44442012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4445
4446 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4447
90b671e2
EZ
44482012-02-11 Eli Zaretskii <eliz@gnu.org>
4449
1c0ca0b7
EZ
4450 * w32select.c (Fx_selection_exists_p): Sync doc string and
4451 argument list with xselect.c. (Bug#10783)
4452
4453 * w16select.c (Fx_selection_exists_p): Sync doc string and
4454 argument list with xselect.c. (Bug#10783)
90b671e2 4455
49241268
GM
44562012-02-10 Glenn Morris <rgm@gnu.org>
4457
4458 * fns.c (Fsecure_hash): Doc fix.
4459
f998bbe7 44602012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4461
4462 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4463
0992bd9c
CY
44642012-02-07 Chong Yidong <cyd@gnu.org>
4465
4466 * buffer.c (Fbuffer_local_variables)
4467 (buffer_lisp_local_variables): Handle unbound vars correctly;
4468 don't let Qunbound leak into Lisp.
4469
af008560
GM
44702012-02-07 Glenn Morris <rgm@gnu.org>
4471
dd605cc4
GM
4472 * image.c (Fimagemagick_types): Doc fix.
4473
af008560
GM
4474 * image.c (imagemagick-render-type): Change it from a lisp object
4475 to an integer. Move the doc here from the lisp manual.
4476 Treat all values not equal to 0 the same.
4477
1449fa1d
CY
44782012-02-06 Chong Yidong <cyd@gnu.org>
4479
4480 * doc.c (store_function_docstring): Avoid applying docstring of
4481 alias to base function (Bug#2603).
4482
3723ec07
AS
44832012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4484
4485 * .gdbinit (pp1, pv1): Remove redundant defines.
4486 (pr): Use pp.
4487
79c1cc1e
CY
44882012-02-04 Chong Yidong <cyd@gnu.org>
4489
4490 * nsterm.m: Declare a global (Bug#10694).
4491
d7f29f8e
EZ
44922012-02-04 Eli Zaretskii <eliz@gnu.org>
4493
cae07000
SM
4494 * w32.c (get_emacs_configuration_options):
4495 Include --enable-checking, if specified, in the return value.
d7f29f8e 4496
3b95a6f9
MR
44972012-02-04 Martin Rudalics <rudalics@gmx.at>
4498
4499 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4500 after rounding frame sizes. (Bug#9723)
4501
d6fa96a6
EZ
45022012-02-04 Eli Zaretskii <eliz@gnu.org>
4503
4504 * keyboard.c (adjust_point_for_property): Don't position point
4505 before BEGV. (Bug#10696)
4506
df0b2940
PE
45072012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 Handle overflow when computing char display width (Bug#9496).
4510 * character.c (char_width): Return EMACS_INT, not int.
4511 (char_width, c_string_width): Check for overflow when
4512 computing the width; this is possible now that individual
4513 characters can have unbounded width. Problem introduced
4514 by merge from Emacs 23 on 2012-01-19.
4515
6bee44d6
MA
45162012-02-02 Michael Albinus <michael.albinus@gmx.de>
4517
4518 * dbusbind.c (Fdbus_register_method): Mention the return value
4519 :ignore in the docstring.
4520
44f92739
GM
45212012-02-02 Glenn Morris <rgm@gnu.org>
4522
1b9f60cc
GM
4523 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4524
44f92739
GM
4525 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4526 Unconditionally set to t. (Bug#10673)
4527 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4528 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4529 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4530
c5d3843c
KH
45312012-02-02 Kenichi Handa <handa@m17n.org>
4532
4533 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4534 0, do not call append_composite_glyph.
4535
159462d4 45362012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4537
4538 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4539 NULL (Bug#6988).
4540 (x_produce_glyphs): If the component of a composition is a null
4541 string, set it->pixel_width to 1 to avoid zero-width glyph.
4542
78cef877
EZ
45432012-02-01 Eli Zaretskii <eliz@gnu.org>
4544
4545 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4546 first 2 arguments are identical. This makes inserting large
4547 output from a subprocess an order of magnitude faster on
4548 MS-Windows, where all sbrk'ed memory is always contiguous.
4549
97897668
GM
45502012-01-31 Glenn Morris <rgm@gnu.org>
4551
4552 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4553 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4554 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4555
31fd3586
GM
45562012-01-29 Glenn Morris <rgm@gnu.org>
4557
4558 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4559
0e24a8b2
CY
45602012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4561
4562 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4563
cc0adcb0
CY
45642012-01-28 Chong Yidong <cyd@gnu.org>
4565
4566 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4567
acc28cb9
CY
45682012-01-26 Chong Yidong <cyd@gnu.org>
4569
9c69cfb7
CY
4570 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4571
acc28cb9
CY
4572 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4573 repeat counts (Bug#10507).
4574
48da7392
GM
45752012-01-26 Glenn Morris <rgm@gnu.org>
4576
4577 * lread.c (syms_of_lread): Doc fix.
4578
14af5f7f
CY
45792012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4580
4581 * coding.c (encode_designation_at_bol): Change return value to
4582 EMACS_INT.
4583
0b21c100
CY
45842012-01-25 Chong Yidong <cyd@gnu.org>
4585
4586 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4587
3c2907f7
CY
45882012-01-21 Chong Yidong <cyd@gnu.org>
4589
4590 * floatfns.c (Fcopysign): Make the second argument non-optional,
4591 since nil is not allowed anyway.
4592
959ad23f
AS
45932012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4594
4595 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4596 (send_process): Likewise.
4597
34a02f46
MR
45982012-01-19 Martin Rudalics <rudalics@gmx.at>
4599
4600 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4601 (Vwindow_persistent_parameters): Do not use Qstate.
4602 Rewrite doc-strings.
34a02f46 4603
1259009a 46042012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4605
4606 * character.c (char_width): New function.
70d4fdf6
GM
4607 (Fchar_width, c_string_width, lisp_string_width):
4608 Use char_width (Bug#9496).
25ed9e61 4609
6a6ee00d
MR
46102012-01-16 Martin Rudalics <rudalics@gmx.at>
4611
4612 * window.c (Vwindow_persistent_parameters): New variable.
4613 (Fset_window_configuration, save_window_save): Handle persistent
4614 window parameters.
4615
c85efaf7
EZ
46162012-01-14 Eli Zaretskii <eliz@gnu.org>
4617
4618 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4619 thrashing the stack of the thread. (Bug#9087)
4620
5944709e
PE
46212012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4622
4623 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4624
e71f5d99
EZ
46252012-01-11 Eli Zaretskii <eliz@gnu.org>
4626
4627 * xdisp.c (rows_from_pos_range): Handle the case where the
4628 highlight ends on a newline. (Bug#10464)
4629 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4630 he end column for display of highlight that ends on a newline
4631 before a R2L line.
4632
ce316182
GM
46332012-01-11 Glenn Morris <rgm@gnu.org>
4634
4635 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4636 from load-path also when installation-directory is nil. (Bug#10208)
4637
5b43da69
GM
46382012-01-10 Glenn Morris <rgm@gnu.org>
4639
74cc8ff9
GM
4640 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4641
7d8d6e4e
GM
4642 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4643 Update template values to be closer to their typical values these days.
5b43da69 4644
a0db8d43
EZ
46452012-01-09 Eli Zaretskii <eliz@gnu.org>
4646
4647 * xdisp.c (rows_from_pos_range): Accept additional argument
4648 DISP_STRING, and accept any glyph in a row whose object is that
4649 string as eligible for mouse highlight. Fixes mouse highlight of
4650 display strings from overlays. (Bug#10464)
4651
9a0115ab 46522012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4653
b9110d6a 4654 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4655 * fileio.c (auto_saving_dir_umask): New static var.
4656 (Fmake_directory_internal): Use it.
4657 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4658 creating the directory. The old code temporarily assigns
4659 too-generous permissions to the directory.
4660 (do_auto_save_eh): Clear it.
b9110d6a 4661 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4662 that the var is always cleared.
4663
6c1bd3f3
EZ
46642012-01-07 Eli Zaretskii <eliz@gnu.org>
4665
4666 * search.c (scan_buffer): Pass character positions to
4667 know_region_cache, not byte positions. (Bug#6540)
4668
069d2b50
L
46692012-01-07 LynX <_LynX@bk.ru> (tiny change)
4670
4671 * w32.c (sys_rename): Report EXDEV when rename of a directory
4672 fails because the target is on another logical disk. (Bug#10284)
4673
75bf0d33
DB
46742012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4675
4676 * xterm.c (x_embed_request_focus): New function.
4677
4678 * xterm.h: Add prototype.
4679
4680 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4681
1c6e5a32
GM
46822012-01-05 Glenn Morris <rgm@gnu.org>
4683
4684 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4685
651e947e
EZ
46862012-01-01 Eli Zaretskii <eliz@gnu.org>
4687
4688 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4689 Load gnutls_transport_set_lowat only if GnuTLS version is below
4690 2.11.1.
4691 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4692 GnuTLS versions below 2.11.1.
4693
3778cdd8
AL
46942011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4695
4696 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4697 to the doc string advising against its use for altering the way
4698 windows are scrolled.
4699
0e5317f7
KH
47002011-12-28 Kenichi Handa <handa@m17n.org>
4701
4702 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4703 coding-system ASCII compatible only when it does not produce BOM
4704 on encoding (Bug#10383).
4705
93d5ca1f
JD
47062011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4707
4708 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4709 can scroll.
4710 (create_and_show_popup_menu): Always use menu_position_func for
4711 Gtk3 (Bug#10361).
4712
ca22b785
AS
47132011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4714
4715 * callint.c (Fcall_interactively): Don't truncate prompt string.
4716
d048e1e6
EZ
47172011-12-23 Eli Zaretskii <eliz@gnu.org>
4718
4719 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4720 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4721 resumed from there (after widening). (Bug#10360)
d048e1e6 4722
5ccaba1f
JD
47232011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4724
4725 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4726
204ee57f
JD
47272011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4728
b81d40f0
JB
4729 * nsterm.m (x_free_frame_resources):
4730 Release f->output_data.ns->miniimage.
204ee57f
JD
4731 (ns_index_color): Fix indentation. Do not retain
4732 color_table->colors[i].
4733
4734 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4735 before returning.
4736
4737 * nsfns.m (x_set_background_color): Assign return value from
4738 ns_index_color to face-background instead of NSColor*.
4739 (ns_implicitly_set_icon_type): Fix indentation.
4740 Change assignment in for loop to comparison.
4741
4742 * emacs.c (ns_pool): New variable.
4743 (main): Assign ns_pool.
4744 (Fkill_emacs): Call ns_release_autorelease_pool.
4745
4746 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4747 autorelease fdesc, release fdAttrs and tdict.
4748 (ns_get_covering_families): Release charset.
4749 (ns_findfonts): Release NSFontDescriptor created with new.
4750 (ns_uni_to_glyphs): Fix indentation.
4751 (setString): Release attrStr before assigning new value.
4752
c803b2b7
JD
47532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4754
678f4426
JD
4755 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4756 and NS_IMPL_COCOA.
4757 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4758 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4759
cd394be1 47602011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4761
5fecd5fc
JD
4762 * nsterm.m (ns_term_init): Subscribe for notifications
4763 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4764 to method trackingNotification in EmacsMenu.
4765
4766 * nsmenu.m (trackingMenu): New variable.
3771cb17 4767 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4768 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4769 from Aquamacs (Bug#7030).
678f4426
JD
4770
47712011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4772
c803b2b7
JD
4773 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4774 (symbol_to_nsstring): Fix indentation.
4775 (ns_symbol_to_pb): New function.
cae07000
SM
4776 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4777 (Fns_rotate_cut_buffers_internal): Remove.
4778 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4779 Fns_store_cut_buffer_internal.
4780 (ns_get_foreign_selection, Fx_own_selection_internal)
4781 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4782 (Fns_get_selection_internal, Fns_store_selection_internal):
4783 Use ns_symbol_to_pb and check if return value is nil.
4784 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4785 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4786 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4787 renamed to Sns_store_selection_internal.
4788 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4789 and remove this function.
4790 (ns_handle_selection_clear): Remove, never used.
4791 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4792 here.
4793
e1b01a3a
KB
47942011-12-17 Ken Brown <kbrown@cornell.edu>
4795
4796 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4797 GID is unknown (Bug#10257).
4798
2adb6e85
PE
47992011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4800
4801 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4802 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4803 which caused a build failure on GNU/Linux IA-64. This problem was
4804 introduced by my 2011-10-07 patch.
4805
d1d7b339
JL
48062011-12-15 Juri Linkov <juri@jurta.org>
4807
4808 * image.c (imagemagick_error): New function. (Bug#10112)
4809 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4810 Use `imagemagick_error' where ImageMagick functions return
4811 `MagickFalse'.
4812 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4813 proper order.
4814
100d5755
KH
48152011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4816
4817 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4818 fill background (Bug#8992).
4819
454592a6
MR
48202011-12-13 Martin Rudalics <rudalics@gmx.at>
4821
4822 * window.c (Vwindow_combination_resize)
4823 (Vwindow_combination_limit): Use t instead of non-nil in
4824 doc-strings.
61d4b438
MR
4825 (Vrecenter_redisplay): Add first sentence of doc-string on
4826 separate line.
53524d93 4827 (Frecenter): Fix doc-string typo.
454592a6 4828
3633e3aa
KH
48292011-12-11 Kenichi Handa <handa@m17n.org>
4830
4831 * coding.c (Funencodable_char_position): Pay attention to the
4832 buffer text relocation (Bug#9389).
4833
7b9d523a 48342011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4835
7b9d523a
JD
4836 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4837 gtk_init (Bug#10100).
4838
b73189c6
EZ
48392011-12-10 Eli Zaretskii <eliz@gnu.org>
4840
4841 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4842 IT->string is nil. (Bug#10263)
4843
f7dfe5d6
JD
48442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4845
83faebb4
JD
4846 * nsterm.h (x_free_frame_resources): Declare.
4847
f7dfe5d6
JD
4848 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4849 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4850
4851 * nsterm.h (ns_get_defaults_value): Declare.
4852
4853 * nsterm.m (ns_default): Call ns_get_defaults_value.
4854
7cd4e72c
EZ
48552011-12-09 Eli Zaretskii <eliz@gnu.org>
4856
4857 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4858 (Bug#10170)
4859
b34d7317
YM
48602011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4861
4862 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4863 that where the value of an _OBJC_* symbol points to is in the .bss
4864 section (Bug#10240).
4865
76470ad1
KH
48662011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4867
4868 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4869 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4870
745fff94
KH
48712011-12-08 Kenichi Handa <handa@m17n.org>
4872
4873 * ftfont.c (get_adstyle_property): Fix previous change
4874 (Bug#10233).
4875
6e44397c
JB
48762011-12-07 Juanma Barranquero <lekktu@gmail.com>
4877
4878 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4879 dirs from the default value of EMACSLOADPATH (bug#10208).
4880
7efa6272
GM
48812011-12-07 Glenn Morris <rgm@gnu.org>
4882
4883 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4884 installation and source directories as well. (Bug#10208)
4885
f6fc4d87
CY
48862011-12-06 Chong Yidong <cyd@gnu.org>
4887
4888 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4889
2bf26180
GM
48902011-12-06 Glenn Morris <rgm@gnu.org>
4891
4892 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4893 as an error, not just -1. (Bug#10217)
4894
3a6ad4f0
CY
48952011-12-05 Chong Yidong <cyd@gnu.org>
4896
4897 * keyboard.c (process_special_events): New function.
4898 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4899
75a3b399
PE
49002011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4901
4902 * coding.c (encode_designation_at_bol): Don't use uninitialized
4903 local variable (Bug#9318).
4904
c3c9e25e
KH
49052011-12-05 Kenichi Handa <handa@m17n.org>
4906
4907 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4908 return Qnil (Bug#8046, Bug#10193).
4909
5eb05ea3
KH
49102011-12-05 Kenichi Handa <handa@m17n.org>
4911
4912 * coding.c (encode_designation_at_bol): New args charbuf_end and
4913 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4914 (coding_set_source): Return how many bytes coding->source was
4915 relocated.
4916 (coding_set_destination): Return how many bytes
4917 coding->destination was relocated.
4918 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4919 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4920
49212011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4922
4923 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4924 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4925 macro (Bug#9318).
4926
49272011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4928
4929 The following changes are to fix Bug#9318.
4930
a79703f5 4931 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4932 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4933 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4934 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4935
7dbda6df
JB
49362011-12-05 Juanma Barranquero <lekktu@gmail.com>
4937
4938 * lisp.h (process_quit_flag): Fix external declaration.
4939
6d5eb5b0
SM
49402011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4941
4942 Don't macro-inline non-performance-critical code.
4943 * eval.c (process_quit_flag): New function.
4944 * lisp.h (QUIT): Use it.
4945
a0c3fad0
JD
49462011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4947
4948 * nsfns.m (get_geometry_from_preferences): New function.
4949 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4950
6c07aac2
AS
49512011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4952
4953 * emacs.c (Qkill_emacs): Define.
4954 (syms_of_emacs): Initialize it.
4955 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4956 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4957 (quit_throw_to_read_char): Add parameter `from_signal'.
4958 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4959 * lisp.h (QUIT): Call Fkill_emacs if requested.
4960
c052ead4
JD
49612011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4962
4963 * widget.c (update_wm_hints): Return if wmshell is null.
4964 (widget_update_wm_size_hints): New function.
4965
4966 * widget.h (widget_update_wm_size_hints): Declare.
4967
4968 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4969 widget_update_wm_size_hints (Bug#10104).
4970
9e49252b
EZ
49712011-12-03 Eli Zaretskii <eliz@gnu.org>
4972
4973 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4974 before a newline, prepare the bidi iterator for consuming the
4975 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4976 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4977
02b16839
JL
49782011-12-02 Juri Linkov <juri@jurta.org>
4979
4980 * search.c (Fword_search_regexp): New Lisp function created from
4981 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4982 (Fword_search_backward, Fword_search_forward)
4983 (Fword_search_backward_lax, Fword_search_forward_lax):
4984 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4985 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4986
0068070e
SM
49872011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4988
4989 * fileio.c (Finsert_file_contents): Move after-change-function call
4990 to before the "handled:" label, since all "goto handled" appear in
4991 cases where the *-change-functions have already been properly called
4992 (bug#10117).
4993
3360a3fc
AS
49942011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4995
4996 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4997 waiting for input. (Bug#10169)
4998
73d6c093
EZ
49992011-11-30 Eli Zaretskii <eliz@gnu.org>
5000
5001 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5002 verifies glyph row's hash code--we have just reallocated the
5003 glyphs, so their contents can be complete garbage. (Bug#10164)
5004
febe6bea
JB
50052011-11-30 Juanma Barranquero <lekktu@gmail.com>
5006
5007 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5008
801a4313
EZ
50092011-11-30 Eli Zaretskii <eliz@gnu.org>
5010
5011 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5012 attributes are tested _before_ calling verify_row_hash, to protect
5013 against GCC re-ordering of the tests. (Bug#10164)
5014
2b56b87e
JD
50152011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5016
5017 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5018
5019 * xterm.c (handle_one_xevent): Only set async_visible and friends
5020 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5021 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5022 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5023
dbf31225
PE
50242011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5025
5026 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5027 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5028 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5029 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5030 All uses changed to use GCPRO1 etc.
5031 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5032 Revert to old implementation (i.e., before 2011-03-11).
5033
1305621b
YM
50342011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5035
5036 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5037 of scroll runs so as to avoid assigning disabled bogus rows and
5038 unnecessary graphics copy operations.
5039
8c9afb46
EZ
50402011-11-27 Eli Zaretskii <eliz@gnu.org>
5041
5042 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5043 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5044 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5045 (malloc, free, realloc, calloc): Redirect to e_* only when
5046 compiling Emacs.
5047
5048 * lisp.h (GCTYPEBITS): Move before first use.
5049 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5050 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5051 this macro definition.
5052
5053 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5054 _MSC_VER.
5055
54e9e3bf
JD
50562011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5057
6d5eb5b0
SM
5058 * gtkutil.c (xg_create_frame_widgets):
5059 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5060 present with Gtk+ 2.0.
5061
83aca1cb
PE
50622011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5063
5064 * fileio.c (Finsert_file_contents): Undo previous change; see
5065 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5066
5b76caa4
PE
50672011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 Rename locals to avoid shadowing.
5070 * fileio.c (Finsert_file_contents):
5071 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5072 * process.c (wait_reading_process_output):
5073 Rename inner 'proc' to 'p' to avoid shadowing.
5074 Indent for consistency with usual Emacs style.
5075
8c535114
EZ
50762011-11-25 Eli Zaretskii <eliz@gnu.org>
5077
5078 * xdisp.c (redisplay_window): If cursor row is not fully visible
5079 after recentering, and scroll-conservatively is set to a large
5080 number, scroll window by a few more lines to make the cursor fully
5081 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5082 (start_display): Don't move to the next line if the display should
5083 start at a newline that is part of a display vector or an overlay
5084 string. (Bug#10119)
8c535114 5085
fa4fdb5c
JL
50862011-11-24 Juri Linkov <juri@jurta.org>
5087
5088 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5089 after the `MagickPingImage' call. (Bug#10112)
5090
90ec88df
CY
50912011-11-23 Chong Yidong <cyd@gnu.org>
5092
5093 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5094
56e2e794
MR
50952011-11-23 Martin Rudalics <rudalics@gmx.at>
5096
5097 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5098 making another buffer current. (Bug#10114)
5099
b6e64c41
GM
51002011-11-23 Glenn Morris <rgm@gnu.org>
5101
5102 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5103
6b21de18
CY
51042011-11-23 Chong Yidong <cyd@gnu.org>
5105
5106 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5107 using it (Bug#5984).
5108
b12cd789
EZ
51092011-11-22 Eli Zaretskii <eliz@gnu.org>
5110
5111 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5112 and header-lines, as they don't have one computed for them.
5113 (Bug#10098)
5114
5115 * .gdbinit (prow): Make displayed values more self-explaining.
5116 Add row's hash code.
5117
261b6fd4
LMI
51182011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5119
5120 * process.c (wait_reading_process_output): Fix asynchrounous
5121 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5122 (wait_reading_process_output): Add comment and URL.
261b6fd4 5123
e7cfd277
JD
51242011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5125
5126 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5127
a9b9b7f5
CY
51282011-11-21 Chong Yidong <cyd@gnu.org>
5129
5130 * window.c (Fnext_window, Fprevious_window): Doc fix.
5131
b0d15b4f
SM
51322011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5133
5134 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5135
fe7a3057
JB
51362011-11-20 Juanma Barranquero <lekktu@gmail.com>
5137
5138 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5139
d2999b1a
MR
51402011-11-20 Martin Rudalics <rudalics@gmx.at>
5141
5142 * window.c (Fset_window_combination_limit): Rename argument
5143 STATUS to LIMIT.
5144 (Vwindow_combination_limit): Remove "status" from doc-string.
5145
d5ff9cd0
AS
51462011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5147
5148 * m/ibms390.h: Remove.
5149 * m/ibms390x.h: Don't include "ibms390.h".
5150
a5bb9bd3
SM
51512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5152
5153 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5154 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5155
cd1181db
JB
51562011-11-20 Juanma Barranquero <lekktu@gmail.com>
5157
5158 * casetab.c (Fset_case_table):
5159 * charset.c (Fcharset_after): Fix typos.
5160
615a3b8d 51612011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5162
17e845af
PE
5163 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5164 Otherwise, valgrind does not work on some platforms.
5165 Problem reported by Andreas Schwab in
6a0bf43d
PE
5166 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5167 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5168 is set, removing the need for VIRT_ADDRESS_VARIES.
5169 (PURE_P): Use a more-efficient implementation that needs just one
5170 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5171 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5172 to 4 (xorl, subq, cmpq, setbe).
5173 * alloc.c (pure): Always extern now, since that's the
5174 VIRT_ADDR_VARIES behavior.
5175 (PURE_POINTER_P): Use a single comparison, not two, for
5176 consistency with the new puresize.h.
5177 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5178 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5179 Remove VIRT_ADDR_VARIES no longer needed.
5180
f8fe6f96
EZ
51812011-11-19 Eli Zaretskii <eliz@gnu.org>
5182
5183 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5184 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5185 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5186 behave as if the cursor position were at the window margin.
5187
5188 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5189 and the cursor position is out of bounds, behave as if the cursor
5190 position were at the window margin. (Bug#10075)
5191
df05a53c
CY
51922011-11-18 Chong Yidong <cyd@gnu.org>
5193
5194 * window.c (Fwindow_combination_limit): Make first argument
5195 non-optional, since it is meaningless for live windows like the
5196 selected window.
61ccba97 5197
2071918e
DA
51982011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5199
5200 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5201
b50a28de
SM
52022011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5203
5204 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5205 (graft_intervals_into_buffer): Simplify.
5206
015137db
EZ
52072011-11-18 Eli Zaretskii <eliz@gnu.org>
5208
5209 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5210 hash values of the two rows.
5211 (copy_row_except_pointers): Preserve the used[] arrays and the
5212 hash values of the two rows. (Bug#10035)
68c95424 5213 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5214
5215 * xdisp.c (row_hash): New function, body extracted from
5216 compute_line_metrics.
5217 (compute_line_metrics): Call row_hash, instead of computing the
5218 hash code inline.
5219
5220 * dispnew.c (verify_row_hash): Call row_hash for computing the
5221 hash code of a row, instead of duplicating code from xdisp.c.
5222
5223 * dispextern.h (row_hash): Add prototype.
5224
a2addb04
TH
52252011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5226
5227 * frame.c (delete_frame): Don't delete the terminal when the last
5228 X frame is closed if emacs is built with GTK toolkit.
5229
df85d315
JB
52302011-11-17 Juanma Barranquero <lekktu@gmail.com>
5231
5232 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5233
a0c2d0ae
MR
52342011-11-17 Martin Rudalics <rudalics@gmx.at>
5235
5236 * window.c (Vwindow_splits): Rename to
5237 Vwindow_combination_resize. Suggested by Juri Linkov.
5238 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5239 of Vwindow_splits.
5240
58179cce
JB
52412011-11-16 Juanma Barranquero <lekktu@gmail.com>
5242
7877f373
JB
5243 * nsfns.m (Fns_font_name):
5244 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5245
b6f67890
MR
52462011-11-16 Martin Rudalics <rudalics@gmx.at>
5247
5248 * window.h (window): Rename slot "nest" to "combination_limit".
5249 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5250 (Fset_window_nest): Rename to Fset_window_combination_limit.
5251 (Vwindow_nest): Rename to Vwindow_combination_limit.
5252 (recombine_windows, make_parent_window, make_window)
5253 (Fsplit_window_internal, saved_window)
5254 (Fset_window_configuration, save_window_save): Rename all
5255 occurrences of window_nest to window_combination_limit.
5256
c7015153
JB
52572011-11-15 Juanma Barranquero <lekktu@gmail.com>
5258
5259 * image.c (imagemagick_load_image): Fix typo.
5260
322ad6ec
EZ
52612011-11-14 Eli Zaretskii <eliz@gnu.org>
5262
5263 * xdisp.c (display_line): Move the call to
5264 highlight_trailing_whitespace before the call to
5265 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5266 faces of all the glyphs to compute ROW's hash value.
5267 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5268
f067b8ec
JB
52692011-11-14 Juanma Barranquero <lekktu@gmail.com>
5270
5271 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5272 just return (bug#10044).
5273
1e5b2111
EZ
52742011-11-12 Eli Zaretskii <eliz@gnu.org>
5275
7ef3cbd5
EZ
5276 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5277 with user-defined heap size. Bump the default size of the temacs
5278 heap to 27MB, to avoid memory warning when running temacs.
5279 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5280
1e5b2111
EZ
5281 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5282 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5283 (verify_row_hash) [XASSERTS]: New function.
5284 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5285 that the hash value of glyph rows is correct.
1e5b2111 5286
89d61221
MR
52872011-11-12 Martin Rudalics <rudalics@gmx.at>
5288
5289 * window.h (window): Remove splits slot.
5290 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5291 (Fdelete_other_windows_internal, make_parent_window)
5292 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5293 (Fset_window_configuration, save_window_save): Don't deal with
5294 split status of windows.
5295 (saved_window): Remove splits slot.
5296 (Vwindow_splits): Rewrite doc-string.
5297
97f18cc8
JD
52982011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5299
5300 * xfns.c (unwind_create_frame):
5301 * nsfns.m (unwind_create_frame):
5302 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5303 Vframe_list (Bug#9999).
5304
22a648b4
DA
53052011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5306
0b381c7e 5307 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5308
659afede
KH
53092011-11-11 Kenichi Handa <handa@m17n.org>
5310
5311 * callproc.c (Fcall_process): Set the member dst_multibyte of
5312 process_coding.
5313
9ac0394b
KH
53142011-11-11 Johan Bockgård <bojohan@gnu.org>
5315
5316 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5317 avoid a crash (bug#9496).
5318
2fbdc249
CY
53192011-11-09 Chong Yidong <cyd@gnu.org>
5320
5321 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5322 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5323
ac6b1f81
PE
53242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5325
5326 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5327
09db192c
PE
53282011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5329
5330 Avoid some portability problems by eschewing 'extern inline' functions.
5331 The trivial performance wins aren't worth the portability hassles; see
5332 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5333 et seq.
5334 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5335 (window_box_width, window_box_left, window_box_left_offset)
5336 (window_box_right, window_box_right_offset): Undo previous change,
5337 by removing the "extern"s.
5338 * intervals.c (adjust_intervals_for_insertion)
5339 (adjust_intervals_for_deletion): Undo previous change,
5340 making these static again.
5341 (offset_intervals, temp_set_point_both, temp_set_point)
5342 (copy_intervals_to_string): No longer inline.
5343 * xdisp.c (window_text_bottom_y, window_box_width)
5344 (window_box_height, window_box_left_offset)
5345 (window_box_right_offset, window_box_left, window_box_right)
5346 (window_box): No longer inline.
5347
105216ed
CY
53482011-11-08 Chong Yidong <cyd@gnu.org>
5349
5350 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5351 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5352 Signal an error if not a live window.
105216ed
CY
5353 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5354 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5355
ae9e237f
JB
53562011-11-07 Juanma Barranquero <lekktu@gmail.com>
5357
5358 * lisp.h (syms_of_abbrev): Remove declaration.
5359 Reported by CHENG Gao <chenggao@royau.me>.
5360
c7aa8333
EZ
53612011-11-07 Eli Zaretskii <eliz@gnu.org>
5362
5363 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5364 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5365 of temacs in GUI mode.
5366
be7f5545
MR
53672011-11-07 Martin Rudalics <rudalics@gmx.at>
5368
5369 * window.h: Declare delete_all_child_windows instead of
5370 delete_all_subwindows.
5371 * window.c (Fwindow_nest, Fset_window_nest)
5372 (Fset_window_new_total, Fset_window_new_normal)
5373 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5374 (delete_all_subwindows): Rename to delete_all_child_windows.
5375 (Fdelete_other_windows_internal, Fset_window_configuration):
5376 Call delete_all_child_windows instead of delete_all_subwindows.
5377 * frame.c (delete_frame): Call delete_all_child_windows instead
5378 of delete_all_subwindows.
5379
ca78dc43
PE
53802011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5381
5382 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5383 This is also needed for porting to any host where GC_MARK_STACK is
5384 not GC_MAKE_GCPROS_NOOPS.
5385 (which_symbols): Use it.
5386
a0241d01
KH
53872011-11-07 Kenichi Handa <handa@m17n.org>
5388
5389 * coding.c (coding_set_destination): Check coding->src_pos only
5390 when coding->src_object is a buffer (bug#9910).
5391
5392 * process.c (send_process): Set the member src_multibyte of coding
5393 to 0 (bug#9911) when sending a unibyte text.
5394
5395 * callproc.c (Fcall_process): Set the member src_multibyte of
5396 process_coding to 0 (bug#9912).
5397
a64bfdfa 53982011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5399
5400 * xmenu.c (cleanup_widget_value_tree): New function.
5401 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5402 calling free_menubar_widget_value_tree directly (Bug#9830).
5403
cb41b32a
PE
54042011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5405
5406 Fix some portability problems with 'inline'.
5407 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5408 (window_box_width, window_box_left, window_box_left_offset)
5409 (window_box_right, window_box_right_offset): Declare extern.
5410 Otherwise, these inline functions do not conform to C99 and
5411 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5412 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5413 * intervals.c (adjust_intervals_for_insertion)
5414 (adjust_intervals_for_deletion): Now extern, because otherwise the
5415 extern inline functions 'offset_intervals' couldn't refer to it.
5416 (static_offset_intervals): Remove.
5417 (offset_intervals): Rewrite using the old contents of
5418 static_offset_intervals. The old version didn't conform to C99
5419 because an extern inline function contained a reference to an
5420 identifier with static linkage.
5421
b7041366
AS
54222011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5423
5424 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5425 GC.
5426
88a37c4d
EZ
54272011-11-06 Eli Zaretskii <eliz@gnu.org>
5428
5429 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5430 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5431 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5432 return Qleft_to_right.
5433
49745b39
CY
54342011-11-06 Chong Yidong <cyd@gnu.org>
5435
5436 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5437 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5438 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5439 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5440 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5441 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5442 (Fwindow_vscroll): Doc fix.
5443 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5444 argument, since it makes no sense to pass a live window and for
5445 consistency with window-child.
5446
1f05cd82
CS
54472011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5448
5449 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5450 support MSVC.
5451
22610910
JR
54522011-11-05 Jason Rumney <jasonr@gnu.org>
5453
5454 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5455 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5456 fonts (Bug#6029).
5457 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5458 bitwise arithmetic preventing use of unicode-sip and non-truetype
5459 opentype fonts.
5460
a06776b2
EZ
54612011-11-05 Eli Zaretskii <eliz@gnu.org>
5462
3ad924ba
EZ
5463 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5464 "emacs"-only part.
5465
a06776b2
EZ
5466 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5467 initialization code to keep similarity to xfns.c after changes
5468 from 2011-11-05.
5469
c9e7db78
JD
54702011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5471
a97f8f3f
JD
5472 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5473 (unwind_create_frame): New function (Bug#9943).
5474 (Fx_create_frame): Restructure code to be more similar to the one in
5475 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5476 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5477 Move terminal->reference_count++ just before making the frame official
5478 (Bug#9943).
5479
5480 * nsterm.m (x_free_frame_resources): New function.
5481 (x_destroy_window): Move code to x_free_frame_resources.
5482
c9e7db78 5483 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5484 (Fx_create_frame, x_create_tip_frame):
5485 Move terminal->reference_count++ just before making the frame
75f1671a 5486 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5487 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5488
a6fc3b5c
EZ
54892011-11-05 Eli Zaretskii <eliz@gnu.org>
5490
5491 Support MSVC build with newer versions of Visual Studio.
5492 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5493 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5494 nt/gmake.defs.
5495
5496 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5497 which are not supported by MSVC.
5498 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5499 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5500 bitfields.
5501 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5502 types in bitfields.
5503 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5504
5505 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5506
58179cce 55072011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5508
5509 Support MSVC build with newer versions of Visual Studio.
5510 * w32.c: Don't include w32api.h for MSVC.
5511 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5512
5513 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5514 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5515 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5516 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5517 e_* cousins.
5518 (alloca) [_MSC_VER]: Define to _alloca.
5519
5520 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5521
5522 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5523
a58c13ed
EZ
55242011-11-04 Eli Zaretskii <eliz@gnu.org>
5525
5526 * xdisp.c (note_mouse_highlight): If either of
5527 previous/next-single-property-change returns nil, treat that as
5528 the beginning or the end of the buffer. (Bug#9955)
5529
fe0b6370
JD
55302011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5531
a58c13ed 5532 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5533 label is not null (Bug#9951).
5534 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5535 may be NULL.
5536
89bd5ee1
EZ
55372011-11-04 Eli Zaretskii <eliz@gnu.org>
5538
5539 * window.c (Fwindow_body_size): Mention in the doc string that the
5540 return value is in frame's canonical units. (Bug#9949)
5541
84c3edb9
EZ
55422011-11-03 Eli Zaretskii <eliz@gnu.org>
5543
4e2fb5c7
EZ
5544 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5545
84c3edb9 5546 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5547 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5548 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5549
bc17a887
EZ
55502011-11-01 Eli Zaretskii <eliz@gnu.org>
5551
5552 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5553 Don't stop backward scan on the continuation glyph, even though
5554 its CHARPOS is positive.
6d5eb5b0
SM
5555 (mouse_face_from_buffer_pos, note_mouse_highlight):
5556 Rename cover_string to disp_string.
bc17a887 5557
4ee88440
MR
55582011-11-01 Martin Rudalics <rudalics@gmx.at>
5559
5560 * window.c (temp_output_buffer_show): Don't use
5561 Vtemp_buffer_show_specifiers.
5562 (Vtemp_buffer_show_specifiers): Remove unused variable.
5563
c2ff3c02
EZ
55642011-10-30 Eli Zaretskii <eliz@gnu.org>
5565
5566 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5567 past the beginning of the current glyph matrix.
5568
58179cce 55692011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5570
5571 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5572 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5573 HAVE_GTK3 (Bug#9869).
b77a6a7f 5574
3b574623
JD
5575 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5576 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5577
b77a6a7f
JD
5578 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5579
5580 * xterm.c: Declare x_handle_net_wm_state to return int.
5581 (handle_one_xevent): Check if we are iconified but don't have
5582 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5583 (get_current_wm_state): Return non-zero if not hidden,
5584 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5585 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5586 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5587 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5588
196e41e4
PE
55892011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5590
5591 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5592 so that this new function doesn't get optimized away by a
5593 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5594
021f2e1a
AS
55952011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5596
5597 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5598
8b058d44
EZ
55992011-10-29 Eli Zaretskii <eliz@gnu.org>
5600
5601 Fix the `xbytecode' command.
5602 * .gdbinit (xprintbytestr): New command.
b50a28de 5603 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5604 (xbytecode): Print the byte-code string as well.
5605
4452fb80
EZ
56062011-10-29 Kim Storm <storm@cua.dk>
5607
8b058d44
EZ
5608 * alloc.c (which_symbols): New function.
5609
21b72067
AS
56102011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5611
5612 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5613 line. (Bug#9903)
5614
83ed7b5c
GM
56152011-10-29 Glenn Morris <rgm@gnu.org>
5616
5617 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5618 Not clear what it was for, and it causes various bugs. (Bug#9839)
5619
5a7a728b
EZ
56202011-10-28 Eli Zaretskii <eliz@gnu.org>
5621
5622 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5623 possible random value that matches one of those tested as
5624 condition to clear the mouse face.
5625
d3d0842f
CY
56262011-10-28 Chong Yidong <cyd@gnu.org>
5627
5628 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5629
31b39d13
DN
56302011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5631
5632 * window.c (make_window): Initialize phys_cursor_on_p.
5633
9aba6043
SM
56342011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5635
5636 * lisp.h (struct Lisp_Symbol): Update comments.
5637
c20992f4
JB
56382011-10-28 Juanma Barranquero <lekktu@gmail.com>
5639
5640 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5641
db4f02f2
EZ
56422011-10-28 Eli Zaretskii <eliz@gnu.org>
5643
5644 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5645 <oslsachem@gmail.com> for helping to debug this.
5646
5647 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5648 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5649 (g_b_init_get_glyph_outline_w): New static variables.
5650 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5651 (GetGlyphOutlineW_Proc): New typedefs.
5652 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5653 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5654 New functions.
5655 (w32font_open_internal, compute_metrics):
5656 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5657 instead of calling the "wide" APIs directly.
5658
5659 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5660
5661 * w32.h (syms_of_w32font): Add prototype.
5662
87e68db4
JB
56632011-10-27 Juanma Barranquero <lekktu@gmail.com>
5664
5665 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5666 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5667 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5668 (Fmove_to_window_line): Doc fix.
5669
435c1d67
CY
56702011-10-27 Chong Yidong <cyd@gnu.org>
5671
5672 * process.c (make_process): Set gnutls_state to NULL.
5673
5674 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5675 non-NULL, regardless of GNUTLS_INITSTAGE.
5676 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5677 an error. Set process slots as soon as we allocate them.
5678
5679 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5680
9c6c6f49
CY
56812011-10-27 Chong Yidong <cyd@gnu.org>
5682
9aba6043
SM
5683 * gnutls.c (emacs_gnutls_deinit): New function.
5684 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5685 (Fgnutls_deinit, Fgnutls_boot): Use it.
5686
5687 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5688 (deactivate_process): Call emacs_gnutls_deinit.
5689
657d08d3
JB
56902011-10-27 Juanma Barranquero <lekktu@gmail.com>
5691
5692 * image.c (x_create_x_image_and_pixmap):
5693 * w32.c (sys_rename, w32_delayed_load):
5694 * w32font.c (fill_in_logfont):
5695 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5696
5430d399
JB
56972011-10-26 Juanma Barranquero <lekktu@gmail.com>
5698
5699 * w32fns.c (w32_default_color_map): New function,
5700 extracted from Fw32_default_color_map.
a7ef684b 5701 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5702
fe0055fa
PE
57032011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5704
5705 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5706
e6346438
SM
57072011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5708
5709 * keyboard.c (test_undefined): New function (bug#9751).
5710 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5711
e112cc37
ET
57122011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5713
5714 * sysdep.c (init_sys_modes): Fix the check for the controlling
5715 terminal (Bug#6649).
5716
7b5d6677
EZ
57172011-10-20 Eli Zaretskii <eliz@gnu.org>
5718
5719 * dispextern.h (struct bidi_it): New member next_en_type.
5720
5721 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5722 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5723 current character, check also for next_en_type being WEAK_EN.
5724 (bidi_resolve_weak): Don't enter the expensive loop if the current
5725 position is before next_en_pos. Record the bidi type of the first
5726 non-ET, non-BN character we find, in addition to its position.
5727 (bidi_level_of_next_char): Invalidate next_en_type when
5728 next_en_pos is over-stepped.
5729
7da0b018
PE
57302011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5731
5732 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5733 * editfns.c: Rewrite current-time-zone so that it invokes
5734 the equivalent of (format-time-string "%Z") to get the time zone name.
5735 This fixes a bug when the time zone name contains characters that
5736 need converting from the system time locale to Emacs internal format.
5737 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5738 that patch fixed format-time-string to do the conversion, but
5739 I forgot to fix current-time-zone.
5740 (format_time_string): New function, containing most of
5741 what Fformat_time_string used to contain.
5742 (Fformat_time_string): Rewrite in terms of format_time_string.
5743 This doesn't change this function's behavior.
5744 (current-time-zone): Rewrite to use format_time_string.
5745 This fixes the bug reported by Michael Schierl in
5746 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5747 Jason Rumney's 2007-06-07 change worked around this bug, but
5748 didn't fix it.
5749 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5750
8547b010
EZ
57512011-10-19 Eli Zaretskii <eliz@gnu.org>
5752
5753 * xdisp.c (start_display): If the character at POS is displayed
5754 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5755 (try_window_reusing_current_matrix): If a line ends in a display
5756 vector or the next line starts in a display vector, continue
5757 redrawing the window even though the character position of
5758 start_row was reached.
8547b010
EZ
5759 (Bug#9771, part 2)
5760
4e948d15
CY
57612011-10-18 Chong Yidong <cyd@gnu.org>
5762
5763 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5764 with nobreak-char-display too.
5765
4787455f
EZ
57662011-10-18 Eli Zaretskii <eliz@gnu.org>
5767
5768 Fix part 3 of bug#9771.
5769 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5770 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5771 non-neutral characters if the current character is a paragraph
5772 separator (a.k.a. Newline). This avoids running the same
5773 expensive loop twice, once when we consume the preceding newline
5774 and the other time when the line actually needs to be displayed.
5775 Avoid the loop when we see neutrals on the base embedding level
5776 following a character whose directionality is the same as the
5777 paragraph's. This avoids running the expensive loop when a line
5778 ends in a long sequence of neutrals, like control characters.
5779 Add assertion against STRONG_AL type. Slightly rearrange code
5780 that determines the type of a neutral given the first non-neutral
5781 that follows it.
5782 (bidi_level_of_next_char): Set next_en_pos to zero when
5783 invalidating its info.
5784
2c91f553
EZ
57852011-10-17 Eli Zaretskii <eliz@gnu.org>
5786
5787 * xdisp.c (push_display_prop): Determine whether to record string
5788 or buffer position by IT->string, not by IT->method. Allow
5789 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5790 (move_it_vertically_backward): Don't look for character position
5791 immediately after the newline when in a continuation line.
5792 (Bug#9771, part 1)
2c91f553 5793
c7b08b0d
MR
57942011-10-15 Martin Rudalics <rudalics@gmx.at>
5795
5796 * window.c (coordinates_in_window): Rewrite and delabelize
5797 vertical border check. (Bug#5357) (Bug#9618)
5798
6b02f655
SM
57992011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5800
5801 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5802 errors in XSetWindowBorder (bug#9310).
5803
81d40c92
DA
58042011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5805
5806 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5807 avoid crash when xmalloc overrun checking is enabled.
5808
d4172c3b
EZ
58092011-10-13 Eli Zaretskii <eliz@gnu.org>
5810
5811 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5812 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5813 cursor motion with <left> and <right> arrow keys.
5814
5815 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5816 some callers set that themselves.
5817
b00eea75
EZ
58182011-10-12 Eli Zaretskii <eliz@gnu.org>
5819
5820 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5821 display string and the previous row comes from the same string and
5822 is empty. (Bug#9739) (Bug#9738)
5823
8fe012c4
SM
58242011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5825
5826 * doc.c (get_doc_string): Encode file name (bug#9735).
5827
0074aef2
EZ
58282011-10-12 Eli Zaretskii <eliz@gnu.org>
5829
79beb178
EZ
5830 * bidi.c (bidi_level_of_next_char):
5831 * xdisp.c (get_visually_first_element): Remove old incorrect
5832 comments regarding the Unicode Line Separator character.
5833
0074aef2
EZ
5834 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5835
6e4b3fbe
DA
58362011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5837
5838 * alloc.c (Fgc_status): Do not access beyond zombies array
5839 boundary if nzombies > MAX_ZOMBIES.
5840 * alloc.c (dump_zombies): Add missing format specifier.
5841
0324f3af
PE
58422011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5843
b5525cac
PE
5844 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5845 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5846
0324f3af
PE
5847 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5848 Some packages use them to denote characters with modifiers.
5849
e9b5f888
AS
58502011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5851
5852 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5853 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5854 matching a pp-number. Rename parameter var to var1.
5855
127827c0
SM
58562011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5857
5858 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5859
c8fd3bd0
GM
58602011-10-08 Glenn Morris <rgm@gnu.org>
5861
5862 * callint.c (Fcall_interactively): Give a more explicit error for the
5863 'c' case with a non-character input. (Bug#8479)
5864
352ec8ff
EZ
58652011-10-08 Eli Zaretskii <eliz@gnu.org>
5866
03669ccb
EZ
5867 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5868 lines.
7061c986
EZ
5869 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5870 lines that are hscrolled on the left.
03669ccb 5871
352ec8ff
EZ
5872 * dispnew.c (buffer_posn_from_coords): Account for a possible
5873 presence of header-line. (Bug#4426)
5874
a66cfb1c
SM
58752011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5876
6b02f655
SM
5877 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5878 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5879
7c5ee88e
PE
58802011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5881
5882 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5883 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5884 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5885 this makes Emacs dump core during garbage collection on rare
5886 occasions. sizeof is obviously inferior to offsetof here, so
5887 stick with offsetof.
5888 (GC_POINTER_ALIGNMENT): New macro.
5889 (mark_memory): Omit 3rd (offset) arg; caller changed.
5890 Don't assume EMACS_INT alignment is the same as pointer alignment.
5891
df1bbe5b
SM
58922011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5893
5894 * keyboard.c (read_key_sequence_remapped): New var.
5895 (read_key_sequence): Compute remapping in the right buffer.
5896 (command_loop_1): Use read_key_sequence's remapping directly.
5897
51553db6
SM
58982011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5899
32c1fffd
SM
5900 * dired.c (file_name_completion): Don't expand file name.
5901 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5902 before checking file name handler.
5903
51553db6
SM
5904 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5905 they've been requested explicitly (bug#9591).
5906
b6bd1599 59072011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5908
5909 * keymap.c (Fsingle_key_description): Use make_specified_string
5910 instead of build_string to build string from push_key_description.
5911 (Bug#5193)
5912
f701dc2a
PE
59132011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5914
4222c55d
PE
5915 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5916 This fixes a Y2038 bug on 64-bit hosts.
5917 * buffer.c (reset_buffer):
5918 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5919 (Fclear_buffer_auto_save_failure):
5920 Use 0, not -1, to represent an unset failure time, since time_t
5921 might not be signed.
5922
f701dc2a
PE
5923 Remove dependency on glibc malloc internals.
5924 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5925 Move back here from lisp.h, but with their new implementations.
5926 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5927 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5928 * charset.c (charset_table_init): New static var.
5929 (syms_of_charset): Use it instead of xmalloc. This removes a
5930 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5931 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5932 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5933 Move back to alloc.c.
5934 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5935 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5936
9ceebf39
JD
59372011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5938
5939 * nsterm.m (windowDidResize): Call x_set_window_size only when
5940 ns_in_resize is true. Otherwise set pixelwidth/height and
5941 call change_frame_size (Bug#9628).
5942
cb993c58
PE
59432011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5944
3930c88b
PE
5945 Port --enable-checking=all to Fedora 14 x86-64.
5946 * charset.c (syms_of_charset): Also account for glibc malloc's
5947 internal overhead when calculating the initial malloc maximum.
5948
cb993c58
PE
5949 Port --enable-checking=all to Fedora 14 x86.
5950 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5951 Move to lisp.h.
5952 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5953 (overrun_check_realloc, overrun_check_free):
5954 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5955 That way, xmalloc returns a properly-aligned pointer even if
5956 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5957 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5958 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5959 into account when calculating the initial malloc maximum.
5960 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5961 Move here from alloc.c, so that charset.c can use it too.
5962 Properly align; the old code wasn't right for common 32-bit hosts
5963 when configured with --enable-checking=all.
5964 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5965 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5966
31bed486
EZ
59672011-09-29 Eli Zaretskii <eliz@gnu.org>
5968
04c70788 5969 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5970 use EDOM.
5971
fbcaa2f3
EZ
59722011-09-28 Eli Zaretskii <eliz@gnu.org>
5973
5974 * xdisp.c (compute_display_string_end): If there's no display
5975 string at CHARPOS, return -1.
5976
5977 * bidi.c (bidi_fetch_char): When compute_display_string_end
5978 returns a negative value, treat the character as a normal
5979 character not covered by a display string. (Bug#9624)
5980
a239d4e9
JB
59812011-09-28 Juanma Barranquero <lekktu@gmail.com>
5982
5983 * lread.c (Fread_from_string): Fix typo in docstring.
5984
88652fd5
EZ
59852011-09-27 Eli Zaretskii <eliz@gnu.org>
5986
5987 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5988 newline, reseat the iterator instead of bidi-iterating there one
5989 character at a time. (Bug#9610)
32c1fffd
SM
5990 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5991 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5992
ed497dd4
AS
59932011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5994
5995 * lread.c (readevalloop): Use correct code for NBSP.
5996 (read1): Likewise. (Bug#9608)
5997
b2bf61aa
MA
59982011-09-25 Michael Albinus <michael.albinus@gmx.de>
5999
6000 * dbusbind.c (Fdbus_register_signal): When service is not
6001 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6002
32bbb17c
GM
60032011-09-25 Glenn Morris <rgm@gnu.org>
6004
6005 * buffer.c (truncate-lines): Doc fix.
6006
94e0933e
CY
60072011-09-24 Chong Yidong <cyd@stupidchicken.com>
6008
6009 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6010 (Fset_window_next_buffers): Doc fix.
6011
cddde921
GM
60122011-09-24 Glenn Morris <rgm@gnu.org>
6013
6014 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6015
1260aef1
PE
60162011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6017
25b4bfa0
PE
6018 Fix minor problems found by static checking.
6019 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6020 * indent.c (Fvertical_motion): Fix == vs = typo.
6021
e3cbd34b
EZ
60222011-09-24 Eli Zaretskii <eliz@gnu.org>
6023
a66cfb1c
SM
6024 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6025 Default value is now t. Doc fix.
6bf7006f 6026
e3cbd34b 6027 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6028 logic when moving up, not only when moving down. Fix the
e3cbd34b 6029 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6030 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6031
6032 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6033 CHARPOS is covered by a display string which includes newlines.
6034 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6035 is covered by a display string with embedded newlines.
6036
a3de0cbd
MA
60372011-09-24 Michael Albinus <michael.albinus@gmx.de>
6038
6039 * dbusbind.c (Fdbus_register_signal): Add match rule to
6040 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6041 (Fdbus_register_method, Vdbus_registered_objects_table):
6042 Fix docstring.
a3de0cbd 6043
b260039d
JM
60442011-09-24 Jim Meyering <meyering@redhat.com>
6045
32c1fffd 6046 do not ignore write error for any output size
b260039d
JM
6047 The previous change was incomplete.
6048 While it makes emacs --batch detect the vast majority of stdout
6049 write failures, errors were still ignored whenever the output size is
6050 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6051 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6052 && echo FAIL: ignored write error
6053 FAIL: ignored write error
6054 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6055 && echo FAIL: ignored write error
6056 FAIL: ignored write error
6057 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6058
8eca8a7c
AS
60592011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6060
6061 * emacs.c (Fkill_emacs): In noninteractive mode exit
6062 non-successfully if a write error occurred on stdout. (Bug#9574)
6063
3341db62
EZ
60642011-09-21 Eli Zaretskii <eliz@gnu.org>
6065
6066 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6067 the xassert test.
6068
6069 * dispextern.h (struct it): Update the comment documenting what
6070 can it->OBJECT be.
6071
8c203dbf
EZ
60722011-09-20 Eli Zaretskii <eliz@gnu.org>
6073
6074 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6075 a display string, extend search for cursor position to end of row.
6076 (find_row_edges): If the row ends in a newline from a display
6077 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6078 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6079 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6080 non-empty line. Fixes confusing cursor motion with arrow keys at
6081 the beginning of a line that starts with whitespace.
8c203dbf 6082
a4824228
LMI
60832011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6084
6085 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6086 (bug#9493).
6087
33ed493b
CY
60882011-09-18 Chong Yidong <cyd@stupidchicken.com>
6089
6090 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6091 boolean (Bug#9154).
6092
56cd55c8
EZ
60932011-09-18 Eli Zaretskii <eliz@gnu.org>
6094
6095 * xdisp.c (display_line): Record maximum and minimum buffer
6096 positions even if no glyphs were produced (e.g., by a zero-width
6097 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6098 buffer positions that will be removed from the glyph row because
6099 they don't fit.
c02dcedf
EZ
6100 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6101 column is beyond frame width: don't subtract 1 "pixel" when
6102 computing width of the stretch.
3e62b7e0
EZ
6103 (reseat_at_next_visible_line_start): Undo the change made on
6104 2011-09-17 that saved paragraph information and restored it after
6105 the call to `reseat'. (Bug#9545)
56cd55c8 6106
5ed99d36 61072011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6108
6109 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6110 and turn window cursor on if cleared (Bug#9415).
6111
5ed99d36 61122011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6113
6114 * search.c (boyer_moore): Take unibyte characters from pattern
6115 literally. (Bug#9458)
6116
9bade7b2
EZ
61172011-09-18 Eli Zaretskii <eliz@gnu.org>
6118
6119 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6120
e5e9d610
PE
61212011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6122
87e4427a
PE
6123 Fix minor problem found by static checking.
6124 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6125 initialized, to pacify gcc -Wuninitialized.
6126
e5e9d610
PE
6127 * fileio.c: Report proper errno when syscall falls.
6128 (Finsert_file_contents): Save and restore errno,
6129 so that report_file_error outputs the correct diagnostic.
6130 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6131
a1674f0b
EZ
61322011-09-18 Eli Zaretskii <eliz@gnu.org>
6133
6134 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6135
fbfb6dd4
EZ
61362011-09-17 Eli Zaretskii <eliz@gnu.org>
6137
6138 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6139 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6140
bb187662
EZ
61412011-09-17 Eli Zaretskii <eliz@gnu.org>
6142
1137e8b8 6143 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6144 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6145
6146 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6147 (bidi_find_paragraph_start): Search back for paragraph beginning
6148 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6149 (bidi_move_to_visually_next): Only trigger paragraph-related
6150 computations when the last character is a newline or at EOB, not
6151 just any NEUTRAL_B. (Bug#9470)
6152
bb187662
EZ
6153 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6154 truncated lines if point is covered by a display string. (Bug#9524)
6155
2e621251
PE
61562011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6157
6158 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6159 (cons_to_x_long): New function.
6160 (lisp_data_to_selection_data): Use it. Correct the test for
6161 short-versus-long data; it was negated. Break out of vector
6162 loop, for efficiency, when a long datum is discovered.
6163
91a15bc6
SM
61642011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6165
6166 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6167
b41c3a35
EZ
61682011-09-16 Eli Zaretskii <eliz@gnu.org>
6169
6170 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6171 GCC PR/17406) by declaring this function with external scope.
6172
7812ba2d
PE
61732011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6174
6175 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6176 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6177
cf7edc2a
AS
61782011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6179
6180 * editfns.c (Fformat): Correctly handle text properties on "%%".
6181
bd01620e
EZ
61822011-09-15 Eli Zaretskii <eliz@gnu.org>
6183
6184 * xterm.c (x_draw_composite_glyph_string_foreground):
6185 * w32term.c (x_draw_composite_glyph_string_foreground):
6186 * term.c (encode_terminal_code):
6187 * composite.c (composition_update_it, get_composition_id):
6188 * xdisp.c (get_next_display_element)
6189 (fill_composite_glyph_string): Add comments about special meaning
6190 of TAB characters in a composition.
6191
a02719a3
PE
61922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6193
6194 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6195 This occurs when processing a multibyte format.
6196 Problem reported by Wolfgang Jenker.
a02719a3 6197
72589a3c
JB
61982011-09-15 Johan Bockgård <bojohan@gnu.org>
6199
6200 * xdisp.c (try_cursor_movement): Only check for exact match if
6201 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6202
1c14176c
PE
62032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6204
6205 Remove unused external symbols.
6206 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6207 * xdisp.c (calc_pixel_width_or_height): Now static.
6208 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6209 * indent.c (check_display_width):
6210 * w32term.c: Fix comment to match code.
6211 * xterm.c, xterm.h (x_catching_errors): Remove.
6212
d2eea5b5
PE
62132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6214
6215 * xselect.c: Use signed conversions more consistently (Bug#9498).
6216 (selection_data_to_lisp_data): Assume incoming selection data are
6217 signed integers, not unsigned. This is to be consistent with
6218 outgoing selection data, which was modified to use signed integers
6219 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6220 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6221 expects long, not unsigned long.
6222
46888499
EZ
62232011-09-14 Eli Zaretskii <eliz@gnu.org>
6224
6225 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6226 computation of loop end. Reported by Johan Bockgård
6227 <bojohan@gnu.org>.
6228
ef8ef9fb
CY
62292011-09-13 Chong Yidong <cyd@stupidchicken.com>
6230
6231 * frame.c (Fother_visible_frames_p): Function deleted.
6232
fa819fed
EZ
62332011-09-12 Eli Zaretskii <eliz@gnu.org>
6234
6235 * indent.c (compute_motion): Process display vector front to back
6236 rather than the other way around. (Bug#2496)
6237
2ba8e008
SM
62382011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6239
6240 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6241
20f53c69
CY
62422011-09-11 Chong Yidong <cyd@stupidchicken.com>
6243
6244 * minibuf.c (Fread_from_minibuffer): Doc fix.
6245
d562d7a4
EZ
62462011-09-11 Eli Zaretskii <eliz@gnu.org>
6247
6248 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6249 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6250
1c4d7f3d
LMI
62512011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6252
6253 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6254 value for non-existent files.
6255
b885bf36
EZ
62562011-09-11 Eli Zaretskii <eliz@gnu.org>
6257
6258 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6259 set its "size" to -1. This will set the modtime_size field of
6260 the corresponding buffer to -1, which is what
6261 verify-visited-file-modtime expects for files that do not exist.
6262 (Bug#9139)
6263
6612f0bf
PE
62642011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6265
6266 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6267 here ...
6268 * lisp.h: ... from here. push_key_description is no longer
6269 defined in keyboard.c, so its declaration should not be in
6270 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6271 logically belongs with push_key_description.
6272
dfb3f755
PE
62732011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6274
6275 * buffer.h: Include <sys/types.h> instead of <time.h>.
6276 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6277 Problem reported by Herbert J. Skuhra.
6278
3134906c
LMI
62792011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6280
6281 * xml.c (parse_region): Make the parsing work for
6282 non-comment-starting XML files again (bug#9144).
6283
8d903f4e
AS
62842011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6285
6286 * image.c (gif_load): Fix calculation of bottom and right corner.
6287 (Bug#9468)
6288
80ad64f4
EZ
62892011-09-10 Eli Zaretskii <eliz@gnu.org>
6290
6291 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6292 redisplay in small windows.
6293
208a048d
EZ
62942011-09-09 Eli Zaretskii <eliz@gnu.org>
6295
6296 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6297
9b1c252e
MR
62982011-09-08 Martin Rudalics <rudalics@gmx.at>
6299
6300 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6301 Operate on live windows only.
6302
2949f33b
JB
63032011-09-08 Juanma Barranquero <lekktu@gmail.com>
6304
6305 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6306
e08dcafd
EZ
63072011-09-07 Eli Zaretskii <eliz@gnu.org>
6308
6309 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6310 only under bidi iteration.
6311
115b96bd
JD
63122011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6313
6314 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6315
c8199d0f
PE
63162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6317
6318 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6319 Without this fix, the command to link temacs failed due to an
6320 undefined symbol __builtin_isnan. This is because
6321 /usr/include/iso/math_c99.h #defines isnan(x) to
6322 __builtin_isnan(x), but the bundled gcc, which identifies itself
6323 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6324 a __builtin_isnan.
6325 * floatfns.c (isnan): #undef, and then #define to a clone of
6326 what's in data.c.
6327 (Fisnan): Always define, since it's always available now.
6328 (syms_of_floatfns): Always define isnan at the Lisp level.
6329
e39b275c 63302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6331
6332 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6333
b2db44d9 63342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6335
f4af5137 6336 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6337 The previous code assumed that file offsets (off_t values) fit in
6338 EMACS_INT variables, which is not true on typical 32-bit hosts.
6339 The code messed up by falsely reporting buffer overflow in cases
6340 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6341 when "big" contains more than 2**29 bytes, even though this
6342 inserts just one byte and does not overflow the buffer.
6343 (Finsert_file_contents): Store file offsets as off_t
6344 values, not as EMACS_INT values. Check for overflow when
6345 converting between EMACS_INT and off_t. When checking for
6346 buffer overflow or for overlap, take the offsets into account.
6347 Don't use EMACS_INT for small values where int suffices.
6348 When checking for overlap, fix a typo: ZV was used where
6349 ZV_BYTE was intended.
6350 (Fwrite_region): Don't assume off_t fits into 'long'.
6351 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6352
ecfc0a49
MA
63532011-09-05 Michael Albinus <michael.albinus@gmx.de>
6354
6355 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6356
6511acf2 63572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6358
0999621a 6359 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6360
6361 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6362 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6363 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6364 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6365 (modify_event_symbol): Do not assume that the length of
6366 name_alist_or_stem is safe to alloca and fits in int.
6367 (Fexecute_extended_command): Likewise for function name and binding.
6368 (Frecursion_depth): Wrap around reliably on integer overflow.
6369 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6370 since some callers pass EMACS_INT values.
6371 (Fsingle_key_description): Don't crash if symbol name contains more
6372 than MAX_ALLOCA bytes.
6373 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6374 (get_minibuffer): Arg is now EMACS_INT, not int.
6375 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6376 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6377 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6378
2be7d702
PE
6379 * dbusbind.c (signature_cat): New function.
6380 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6381 Do not overrun buffer; instead, report string overflow.
6382
9d1df220
PE
6383 * dispnew.c (add_window_display_history): Don't overrun buffer.
6384 Truncate instead; this is OK since it's just a log.
6385
33ef5c64
PE
6386 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6387 even if the time zone offset is outlandishly large.
6388 Don't mishandle offset == INT_MIN.
6389
66c6fdd5
PE
6390 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6391 when creating daemon; the previous buffer-overflow check was incorrect.
6392
d749b01b
PE
6393 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6394 which has the guts of the old verror function.
6395
b5cd1905
PE
6396 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6397 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6398
6e1a67fb
PE
6399 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6400 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6401 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6402 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6403 length of string rather than counting it via multiple sprintfs;
6404 that's simpler and more reliable.
c21721cc
PE
6405 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6406 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6407 sprintf, in case result does not fit in int.
6408
c57b67fc
PE
6409 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6410 (fontset_from_font): Print it.
6411
8a401434
PE
6412 * frame.c (tty_frame_count): Now printmax_t, not int.
6413 (make_terminal_frame, set_term_frame_name): Print it.
6414 (x_report_frame_params): In X, window IDs are unsigned long,
6415 not signed long, so print them as unsigned.
6416 (validate_x_resource_name): Check for implausibly long names,
6417 and don't assume name length fits in 'int'.
6418 (x_get_resource_string): Don't blindly alloca invocation name;
6419 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6420 not fit in int.
6421
6e1a67fb
PE
6422 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6423 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6424 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6425
0df02bf3
PE
6426 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6427 Use esprintf, not sprintf, in case result does not fit in int.
6428
48e30793
PE
6429 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6430 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6431 it as a large positive number.
6432 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6433 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6434
a66ff6d8
PE
6435 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6436 in case result does not fit in int.
6437
aca216ff
PE
6438 * print.c (float_to_string): Detect width overflow more reliably.
6439 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6440 buffer overrun. Don't assume list length fits in 'int'. Treat
6441 print length of 0 as 0, not as infinity; to be consistent with other
6442 uses of print length in this function. Don't overflow print length
6443 index. Don't assume hash table size fits in 'long', or that
6444 vectorlike size fits in 'unsigned long'.
6445
31c286f7
PE
6446 * process.c (make_process): Use printmax_t, not int, to format
6447 process-name gensyms.
6448
55e5faa1
PE
6449 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6450
80f2e268
PE
6451 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6452 to avoid potential buffer overrun.
6453
670741ab
PE
6454 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6455 if X resource line is longer than 512 bytes.
6456
b7163a50
PE
6457 * xfns.c (x_window): Make sprintf buffer a bit bigger
6458 to avoid potential buffer overrun.
6459
ae58ff1f
PE
6460 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6461
c43c8a6a
PE
6462 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6463
3f8236f4
PE
64642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6465
53e9fe90 6466 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6467 Without these, Emacs silently mishandles large integers sometimes.
6468 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6469 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6470
6511acf2
PE
6471 * xdisp.c (try_window_id): Check Emacs fixnum range before
6472 converting to 'int'.
806add1d 6473
6511acf2 6474 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6475 Check that an Emacs fixnum is in range before assigning it to 'int'.
6476 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6477 values converted from Emacs fixnums.
6478 (Frecenter): Don't wrap around a line count if it is out of 'int'
6479 range; instead, treat it as an extreme value.
6480 (Fset_window_configuration, compare_window_configurations):
6481 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6482
6511acf2
PE
6483 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6484 that can exceed INT_MAX. Check that EMACS_INT value is in range
6485 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6486 (match_limit): Don't assume that a fixnum can fit in 'int'.
6487
6511acf2 6488 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6489 exceed INT_MAX.
6490
6511acf2 6491 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6492 (Fvertical_motion): Don't wrap around LINES values that don't fit
6493 in 'int'. Instead, treat them as extreme values. This is good
6494 enough for windows, which can't have more than INT_MAX lines anyway.
6495
fcb901a7
LMI
64962011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6497
0f2f6b6d
LMI
6498 * Require libxml/parser.h to avoid compilation warning.
6499
fcb901a7
LMI
6500 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6501
6502 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6503 since this reportedly can destroy thread storage.
6504
6e20a0d4
CY
65052011-08-30 Chong Yidong <cyd@stupidchicken.com>
6506
6507 * syntax.c (find_defun_start): Update all cache variables if
6508 exiting early (Bug#9401).
6509
148ae00e
EZ
65102011-08-30 Eli Zaretskii <eliz@gnu.org>
6511
f6cfbd8f
EZ
6512 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6513
148ae00e
EZ
6514 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6515 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6516 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6517
6518 * term.c (tty_append_glyph): New function.
6519 (produce_stretch_glyph): Static function and its prototype deleted.
6520
a66cfb1c
SM
6521 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6522 Add prototypes.
148ae00e 6523
c4a07a4c
PE
65242011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6525
6526 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6527 when checking :margin (Bug#9390).
6528 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6529 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6530 so that the name doesn't mislead. All uses changed.
6531
6bc8cd65
JB
65322011-08-28 Johan Bockgård <bojohan@gnu.org>
6533
6534 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6535 set_tty_hooks.
6536
dca4927e
EZ
65372011-08-27 Eli Zaretskii <eliz@gnu.org>
6538
6539 * xdisp.c (move_it_to): Don't bail out early when reaching
6540 position beyond to_charpos, if we are scanning backwards.
6541 (move_it_vertically_backward): When DY == 0, make sure we get to
6542 the first character in the line after the newline.
6543
f2cad773
PE
65442011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6545
6546 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6547 (ccl_driver): Do not generate an out-of-range pointer.
6548 (Fccl_execute_on_string): Remove unnecessary check for
6549 integer overflow, noted by Stefan Monnier in
6550 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6551 Remove a FIXME that didn't need fixing.
6552 Simplify the newly-introduced buffer reallocation code.
6553
0cae2cdb
JB
65542011-08-27 Juanma Barranquero <lekktu@gmail.com>
6555
6556 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6557
5fc295a4 65582011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6559
70c60eb2 6560 Integer and memory overflow issues (Bug#9196).
726e0ab1 6561
d31850da
PE
6562 * doc.c (get_doc_string): Rework so that
6563 get_doc_string_buffer_size is the actual buffer size, rather than
6564 being 1 less than the actual buffer size; this makes xpalloc more
6565 convenient.
6566
a69fbedb
PE
6567 * image.c (x_allocate_bitmap_record, cache_image):
6568 * xselect.c (Fx_register_dnd_atom):
6569 Simplify previous changes by using xpalloc.
6570
fe5c5d37
PE
6571 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6572 since either will do and ptrdiff_t is convenient with xpalloc.
6573
0065d054
PE
6574 * charset.c (charset_table_size)
6575 (struct charset_sort_data.priority): Now ptrdiff_t.
6576 (charset_compare): Don't overflow if priorities differ greatly.
6577 (Fsort_charsets): Don't assume list length fits in int.
6578 Check for size-calculation overflow when allocating sort data.
6579 (syms_of_charset): Allocate an initial charset table that is
6580 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6581
6582 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6583
6584 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6585 The actual value is always <= INT_MAX, and leaving it unsigned made
6586 overflow checking harder.
6587
6588 * dispextern.h (struct glyph_matrix.rows_allocated)
6589 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6590 with xpalloc. The values are still always <= INT_MAX.
6591
6592 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6593
6594 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6595 (SAFE_NALLOCA): New macro.
6596
6597 * region-cache.c (struct boundary.pos, find_cache_boundary)
6598 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6599 (set_cache_region, invalidate_region_cache)
6600 (revalidate_region_cache, know_region_cache, region_cache_forward)
6601 (region_cache_backward, pp_cache):
6602 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6603 so that ptrdiff_t * can be passed to xpalloc.
6604 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6605 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6606 (pp_cache): Don't assume cache_len fits in int.
6607 * region-cache.h: Adjust extern decls to match.
6608
6609 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6610 EMACS_INT, since either will do, for xpalloc.
6611
6612 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6613 (xnmalloc, xnrealloc, xpalloc): New functions.
6614
726e0ab1
PE
6615 * bidi.c (bidi_shelve_header_size): New constant.
6616 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6617 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6618
51f30bc5 6619 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6620 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6621 (overlay_strings):
6622 Don't update size of array until after memory allocation succeeds,
6623 because xmalloc/xrealloc may not return.
0065d054
PE
6624 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6625 now that we have proper integer overflow checking.
6626 (record_overlay_string, overlay_strings): Catch overflows when
6627 calculating size of overlay_str_buf.
726e0ab1 6628
0065d054
PE
6629 * callproc.c (Fcall_process): Check for size overflow when
6630 calculating size of args2.
6631 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6632 Normally we prefer signed values, but sticking with ptrdiff_t would
6633 require adding more-complicated checks.
726e0ab1
PE
6634
6635 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6636 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6637 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6638 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6639
6640 * character.c (Fstring): Check for size-calculation overflow.
6641
6642 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6643 unnecessary integer overflow. Check for size overflow.
6644 (encode_coding_object): Don't update size until xmalloc succeeds.
6645
6646 * composite.c (get_composition_id): Check for overflow in glyph
6647 length calculations.
6648
6649 Integer and memory overflow fixes for display code.
6650 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6651 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6652 (scrolling_window): Check for overflow in size calculations.
6653 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6654 Don't assume glyph table len fits in int.
6655 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6656 (row_table_size): Now ptrdiff_t, not int.
6657 (scrolling_window): Avoid overflow in size calculations.
6658 Don't update size until allocation succeeds.
6659 * fns.c (concat): Check for overflow in size calculations.
6660 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6661 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6662 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6663
6664 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6665 (get_doc_string): Check for size calculation overflow.
6666 Don't update size until allocation succeeds.
6667 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6668 EMACS_INT, where ptrdiff_t will do.
6669 (Fsubstitute_command_keys): Check for string overflow.
6670
6671 * editfns.c (set_time_zone_rule): Don't assume environment length
6672 fits in int.
6673 (message_length): Now ptrdiff_t, not int.
6674 (Fmessage_box): Don't update size until allocation succeeds.
6675 Don't assume message length fits in int.
6676 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6677
0065d054
PE
6678 * emacs.c (main): Do not reallocate argv, since there is a null at
6679 the end that can be overwritten, and this way there's no need to
6680 worry about size-calculation overflow.
6681 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6682
6683 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6684 alloc succeeds.
6685 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6686
6687 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6688 (x_set_scroll_bar_width, x_figure_window_size):
6689 Check for integer overflow.
6690 (x_set_alpha): Do not assume XINT fits in int.
6691
6692 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6693 This is for the members text_lines, text_cols, total_lines, total_cols,
6694 where the system imposes an 'int' limit.
6695
6696 * fringe.c (Fdefine_fringe_bitmap):
6697 Don't update size until alloc works.
6698
6699 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6700 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6701
6702 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6703 Check for size-calculation overflow.
6704 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6705 do, as we prefer signed integers.
6706 (id_to_widget.max_size, id_to_widget.used)
6707 (xg_store_widget_in_map, xg_remove_widget_from_map)
6708 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6709 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6710 Use and return ptrdiff_t, not int.
6711 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6712 * gtkutil.h: Change prototypes to match the above.
6713
6714 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6715 are duplicate now that they've been promoted to lisp.h.
6716 (x_allocate_bitmap_record, x_alloc_image_color)
6717 (make_image_cache, cache_image, xpm_load):
6718 Don't update size until alloc is done.
6719 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6720 (x_detect_edges):
3256efce 6721 Check for size calculation overflow.
726e0ab1
PE
6722 (ct_colors_allocated_max): New constant.
6723 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6724 overflow.
3256efce 6725
726e0ab1
PE
6726 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6727 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6728 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6729 Use ptrdiff_t, not int, to count maps.
6730 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6731 calculations. Don't update size until allocation succeeds.
6732 Redo calculations to avoid overflow.
726e0ab1
PE
6733 * keyboard.h: Change prototypes to match the above.
6734
6735 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6736 to count maps.
6737 (current_minor_maps): Check for size calculation overflow.
6738 * keymap.h: Change prototypes to match the above.
6739
6740 * lread.c (read1, init_obarray): Don't update size until alloc done.
6741
6742 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6743 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6744
726e0ab1
PE
6745 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6746 Now ptrdiff_t, not int.
6747 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6748 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6749
6750 * process.c (Fnetwork_interface_list): Check for overflow
6751 in size calculation.
6752
6753 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6754
6755 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6756 overflow. Don't bother calling xmalloc when xrealloc will do.
6757
6758 * search.c (Freplace_match): Check for size calculation overflow.
6759 (Fset_match_data): Don't assume list lengths fit in 'int'.
6760
6761 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6762 for command line length. Do not attempt to address one before the
6763 beginning of an array, as that's not portable.
6764
6765 * term.c (max_frame_lines): Remove; unused.
6766 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6767 not int.
6768 (encode_terminal_code, calculate_costs): Check for size
6769 calculation overflow.
6770 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6771 table lengths and related sizes. Don't update size until alloc
6772 done. Redo calculations to avoid overflow.
6773 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6774
6775 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6776 subtracting pointers.
6777 (gobble_line): Check for overflow more carefully. Don't update size
6778 until alloc done.
6779
6780 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6781 Don't update size until alloc done.
6782 Redo size calculations to avoid overflow.
6783 Check for size calculation overflow.
0065d054 6784 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6785
6786 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6787 Use ptrdiff_t, not int, for sizes.
6788 (store_mode_line_noprop_char): Don't update size until alloc done.
6789
0065d054
PE
6790 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6791 Use ptrdiff_t, not int, for sizes.
6792 (Finternal_make_lisp_face, cache_face):
6793 Check for size calculation overflow.
6794 (cache_face): Treat size calculation overflows as if they were
6795 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6796
6797 * xfns.c (x_encode_text, x_set_name_internal)
6798 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6799 sizes, since they can exceed INT_MAX in size. Check for size
6800 calculation overflow.
6801
0065d054
PE
6802 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6803 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6804 Don't update size until alloc done.
6805
0065d054 6806 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6807 as sprintf is limited to int lengths.
1d526e2f 6808
252c5ee1
PE
6809 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6810 (X_LONG_MIN): New macros.
864d7ce7
PE
6811 Use them to make the following changes clearer.
6812 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6813 This change doesn't affect the value now, but it may help remind
6814 future maintainers not to raise the value too much later.
6815 (SELECTION_QUANTUM): Remove, replacing with ...
6816 (selection_quantum): ... new function, which avoids overflow.
6817 All uses changed.
6818 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6819 assumption that selection length fits in 'int'.
6820 (x_reply_selection_request, x_handle_selection_request)
6821 (x_get_window_property, receive_incremental_selection)
6822 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6823 (lisp_data_to_selection_data, clean_local_selection_data):
6824 Use ptrdiff_t, not int, to record length of selection.
6825 (x_reply_selection_request, x_get_window_property)
6826 (receive_incremental_selection, x_property_data_to_lisp):
6827 Redo calculations to avoid overflow.
6828 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6829 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6830 something.
6831 (x_get_window_property, receive_incremental_selection)
6832 (lisp_data_to_selection_data, x_property_data_to_lisp):
6833 Check for size-calculation overflow.
6834 (x_get_window_property, receive_incremental_selection)
6835 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6836 Don't store size until memory allocation succeeds.
6837 (x_get_window_property): Plug memory leak on memory exhaustion.
6838 Don't double-block input; malloc is safe here. Don't assume 2**34
6839 - 4 fits in unsigned long. Add an xassert to check
6840 XGetWindowProperty overflow. Be more careful about overflow
6841 calculations, and distinguish size from memory overflow better.
6842 (receive_incremental_selection): When tracing, don't assume
6843 unsigned int is less than INT_MAX.
6844 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6845 harmful) conversions of unsigned short to int.
6846 (lisp_data_to_selection_data): Don't assume that integers
6847 in the range -65535 through -1 fit in an X unsigned short.
6848 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6849 result parameters unless successful. Rely on cons_to_unsigned
6850 to report problems with elements; the old code wasn't right anyway.
6851 (x_check_property_data): Check for int overflow; we cannot use
6852 a wider type due to X limits.
6853 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6854
726e0ab1 6855 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6856
0065d054
PE
6857 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6858 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6859 (x_color_cells): Don't store size until memory allocation succeeds.
6860 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6861 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6862 (x_term_init): Don't assume length fits in int (sprintf is limited
6863 to int size).
bc18e09d 6864
ebfa62c0
PE
6865 Use ptrdiff_t for composition IDs.
6866 * character.c (lisp_string_width):
6867 * composite.c (composition_table_size, n_compositions)
6868 (get_composition_id, composition_gstring_from_id):
6869 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6870 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6871 * window.c (Frecenter):
6872 Use ptrdiff_t, not int, for composition IDs.
6873 * composite.c (get_composition_id): Check for integer overflow.
6874 * composite.h: Adjust prototypes to match the above changes.
6875
d3411f89
PE
6876 Use ptrdiff_t for hash table indexes.
6877 * category.c (hash_get_category_set):
6878 * ccl.c (ccl_driver):
6879 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6880 * coding.c (coding_system_charset_list, detect_coding_system):
6881 * coding.h (struct coding_system.id):
6882 * composite.c (get_composition_id, gstring_lookup_cache):
6883 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6884 * image.c (xpm_get_color_table_h):
6885 * lisp.h (hash_lookup, hash_put):
6886 * minibuf.c (Ftest_completion):
6887 Use ptrdiff_t for hash table indexes, not int (which is too
6888 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6889 32-bit --with-wide-int hosts).
6890
e097a6fa
PE
6891 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6892 Add a FIXME comment about memory leaks.
6893 (syms_of_charset): Don't assume xmalloc returns.
6894
5637687f
PE
6895 Don't assume that stated character widths fit in int.
6896 * character.c (Fchar_width, c_string_width, lisp_string_width):
6897 * character.h (CHAR_WIDTH):
6898 * indent.c (MULTIBYTE_BYTES_WIDTH):
6899 Use sanitize_char_width to avoid undefined and/or bad behavior
6900 with outlandish widths.
a66cfb1c 6901 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6902 now that we have two such functions. All uses changed.
6903 (sanitize_char_width): New inline function.
6904
a2271ba2
PE
6905 Don't assume that tab-width fits in int.
6906 * character.h (sanitize_width): New inline function.
6907 (SANE_TAB_WIDTH): New macro.
6908 (ASCII_CHAR_WIDTH): Use it.
6909 * indent.c (sane_tab_width): Remove. All uses replaced by
6910 SANE_TAB_WIDTH (current_buffer).
6911 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6912
18c52557
PE
6913 * fileio.c: Integer overflow issues with file modes.
6914 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6915
caeeedc1
PE
6916 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6917 Remove unreachable code.
6918 (read_hex, load_charset_map_from_file): Check for integer overflow.
6919
6df6ae42 6920 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6921 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6922 (x_send_scroll_bar_event): Likewise. Check that the size does not
6923 exceed limits imposed by XClientMessageEvent, as well as the usual
6924 ptrdiff_t and size_t limits.
6925
b13995db
PE
6926 * keyboard.c: Overflow, signedness and related fixes.
6927 (make_lispy_movement): Use same integer type in forward decl
6928 that is used in the definition.
6929 (read_key_sequence, keyremap_step):
6930 Change bufsize argument back to int, undoing my 2011-03-30 change.
6931 We prefer signed types, and int is wide enough here.
6932 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6933 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6934 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6935 length, not size_t. Use ptrdiff_t for index, not int.
6936 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6937 possibility of integer overflow.
6938
13464394
PE
6939 Overflow, signedness and related fixes for images.
6940
6941 * dispextern.h (struct it.stack[0].u.image.image_id)
6942 (struct_it.image_id, struct image.id, struct image_cache.size)
6943 (struct image_cache.used, struct image_cache.ref_count):
6944 * gtkutil.c (update_frame_tool_bar):
6945 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6946 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6947 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6948 * nsmenu.m (update_frame_tool_bar):
6949 * xdisp.c (calc_pixel_width_or_height):
6950 * xfns.c (image_cache_refcount):
6951 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6952 on typical 64-bit hosts.
6953
6954 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6955 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6956 Omit unnecessary casts to int.
6957 (parse_image_spec): Check that integers fall into 'int' range
6958 when the callers expect that.
6959 (image_ascent): Redo ascent calculation to avoid int overflow.
6960 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6961 (lookup_image): Remove unnecessary tests.
6962 (xbm_image_p): Locals are now of int, not EMACS_INT,
6963 since parse_image_check makes sure they fit into int.
6964 (png_load, gif_load, svg_load_image):
6965 Prefer int to unsigned where either will do.
6966 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6967 old tiff_error_handler and tiff_warning_handler.
6968 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6969 stack buffer overflows. It uses only the features of vsnprintf
6970 that are common to both POSIX and native Microsoft.
6971 (tiff_error_handler, tiff_warning_handler): Use it.
6972 (tiff_load, gif_load, imagemagick_load_image):
6973 Don't assume :index value fits in 'int'.
6974 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6975 (imagemagick_load_image): Check that crop parameters fit into
6976 the integer types that MagickCropImage accepts. Don't assume
6977 Vimagemagick_render_type has a nonnegative value. Don't assume
6978 size_t fits in 'long'.
6979 (gs_load): Use printmax_t to print the widest integers possible.
6980 Check for integer overflow when computing image height and width.
6981
c11821d4
EZ
69822011-08-26 Eli Zaretskii <eliz@gnu.org>
6983
6984 * xdisp.c (redisplay_window): Don't force window start if point
6985 will be invisible in the resulting window. (Bug#9324)
6986
0c95fcf7
EZ
69872011-08-25 Eli Zaretskii <eliz@gnu.org>
6988
6989 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6990 the display spec is of the form `(space ...)'.
6991 (handle_display_spec): Return the value returned by
6992 handle_single_display_spec, not just 1 or zero.
6993 (handle_single_display_spec): If the display spec is of the form
6994 `(space ...)', and specifies display in the text area, return 2
6995 rather than 1.
fee65a97 6996 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6997 accurately, and prefer exact match for point under bidi.
6998 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6999
7000 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7001 into disp_prop; all users changed.
7002
7003 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7004 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7005 for the text covered by the display property.
7006
e4ed06f1
CY
70072011-08-25 Chong Yidong <cyd@stupidchicken.com>
7008
7009 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7010 Change return value to nil.
7011 (Frecord_buffer): Delete unused function.
7012
f67cdd7f
EZ
70132011-08-24 Eli Zaretskii <eliz@gnu.org>
7014
5980d4c6
EZ
7015 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7016 buffers, return left-to-right.
8610fe8b
EZ
7017 (set_cursor_from_row): Consider candidate row a win if its glyph
7018 represents a newline and point is on that newline. Fixes cursor
7019 positioning on the newline at EOL of R2L text within L2R
7020 paragraph, and vice versa.
7021 (try_cursor_movement): Check continued rows, in addition to
7022 continuation rows. Fixes unwarranted scroll when point enters a
7023 continued line of R2L text within an L2R paragraph, or vice versa.
7024 (cursor_row_p): Consider the case of point being equal to
7025 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7026 from the end of a short line to the beginning of a continued line
7027 of R2L text within L2R paragraph.
7028 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7029 composed characters.
5980d4c6 7030
f67cdd7f
EZ
7031 * bidi.c (bidi_check_type): Use xassert.
7032 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7033 members.
7034
bca633fb
EZ
70352011-08-23 Eli Zaretskii <eliz@gnu.org>
7036
7037 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7038 a character.
7039
4a5885a7
CY
70402011-08-23 Chong Yidong <cyd@stupidchicken.com>
7041
7042 * nsfont.m (ns_otf_to_script): Fix typo.
7043
0902a04e
KH
70442011-08-22 Kenichi Handa <handa@m17n.org>
7045
7046 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7047 extra slot even if the purpose is char-code-property-table.
7048
1a2e6670
EZ
70492011-08-23 Eli Zaretskii <eliz@gnu.org>
7050
8ddde651
EZ
7051 * xdisp.c (redisplay_window): When computing centering_position,
7052 account for the height of the header line. (Bug#8874)
7053
425cc014
EZ
7054 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7055 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7056 candidate is selected by the mouse, and that candidate has a
7057 composed character under the mouse.
7058
1a2e6670
EZ
7059 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7060 coordinates reported by pos-visible-in-window-p for a composed
7061 character in column zero.
7062
8b76d6f8
SM
70632011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7064
7065 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7066
dac347dd
EZ
70672011-08-22 Eli Zaretskii <eliz@gnu.org>
7068
7069 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7070 consider it a hit if to_charpos is anywhere in the range of the
7071 composed buffer positions.
7072
e013fb34
CY
70732011-08-22 Chong Yidong <cyd@stupidchicken.com>
7074
7075 * image.c (gif_load): Don't assume that each subimage has the same
7076 dimensions as the base image. Handle disposal method that is
7077 "undefined" by the gif spec (Bug#9335).
7078
bd1ba3e8
CY
70792011-08-20 Chong Yidong <cyd@stupidchicken.com>
7080
7081 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7082 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7083
54a1215b
EZ
70842011-08-19 Eli Zaretskii <eliz@gnu.org>
7085
823564e5
EZ
7086 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7087 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7088 from an Org mode buffer to a Speedbar frame.
7089
54a1215b
EZ
7090 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7091 a composition, take its buffer position from IT->cmp_it.charpos.
7092 Fixes cursor positioning at the beginning of a line that begins
7093 with a composed character.
7094
9778ebcc
EZ
70952011-08-18 Eli Zaretskii <eliz@gnu.org>
7096
0be6ee06
EZ
7097 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7098 character bidirectional type, use STRONG_L instead. Fixes crashes
7099 in a buffer produced by `describe-categories'.
7100
9778ebcc
EZ
7101 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7102 members before the level stack, so they would be saved and
7103 restored when copying iterator state. Fixes incorrect reordering
7104 around TABs covered by display properties.
7105
156bffbe
AS
71062011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7107
6b02f655 7108 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7109
72ad093b
CY
71102011-08-17 Chong Yidong <cyd@stupidchicken.com>
7111
7112 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7113 (internal_condition_case_2, internal_condition_case_n):
7114 Remove unnecessary aborts (Bug#9081).
72ad093b 7115
35774242
EZ
71162011-08-17 Eli Zaretskii <eliz@gnu.org>
7117
7118 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7119 has no `load' handler, try opening the file locally. (Bug#9311)
7120
db76dd85
KB
71212011-08-16 Ken Brown <kbrown@cornell.edu>
7122
7123 * gmalloc.c: Expand comment.
7124
b215eee5
EZ
71252011-08-16 Eli Zaretskii <eliz@gnu.org>
7126
7127 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7128 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7129
a4579d33
KB
71302011-08-16 Ken Brown <kbrown@cornell.edu>
7131
7132 Fix memory allocation problems in Cygwin build (Bug#9273).
7133
7134 * unexcw.c ( __malloc_initialized): Declare external variable.
7135 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7136
8b76d6f8
SM
7137 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7138 New variables.
a4579d33
KB
7139 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7140 dumped emacs.
7141 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7142 in the static heap.
7143 [CYGWIN] (special_realloc): New function.
7144 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7145 requests to realloc storage in the static heap.
7146
3ebec551
PE
71472011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7148
7149 * bidi.c (bidi_initialize): Remove unused local.
7150
9fd8be00
EZ
71512011-08-15 Eli Zaretskii <eliz@gnu.org>
7152
6b02f655
SM
7153 * bidimirror.h:
7154 * biditype.h: Remove file.
7155 * makefile.w32-in ($(BLD)/bidi.$(O)):
7156 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7157
7158 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7159
7160 * chartab.c: Improve commentary for the uniprop_table API.
7161
32413314
EZ
7162 * bidi.c (bidi_paragraph_init): Support zero value of
7163 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7164 (bidi_initialize): Use uniprop_table instead of including
7165 biditype.h and bidimirror.h.
32413314 7166
9fd8be00
EZ
7167 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7168 coordinates of the iterator when restoring from ppos_it.
7169 (Bug#9296)
7170
5cf2b69b
KH
71712011-08-14 Kenichi Handa <handa@m17n.org>
7172
7173 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7174 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7175
daf17d00
EZ
71762011-08-14 Eli Zaretskii <eliz@gnu.org>
7177
7178 * xdisp.c (move_it_in_display_line_to): Don't invoke
7179 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7180 ppos_it. Fixes vertical cursor motion when line beginning is
7181 covered by an image. (Bug#9296)
7182
08e3161a
JD
71832011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7184
7185 * nsterm.h (ns_run_ascript): Declare.
7186 (NSAPP_DATA2_RUNASSCRIPT): Define.
7187
7188 * nsfns.m (as_script, as_result, as_status): New static variables.
7189 (ns_run_ascript): New function.
5e617bc2 7190 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7191 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7192 the event loop. Get status from as_status (Bug#7276).
7193
7194 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7195 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7196 the event loop (Bug#7276).
7197
a3720aa2
AS
71982011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7199
7200 * gnutls.c (QCgnutls_bootprop_priority)
7201 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7202 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7203 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7204 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7205 (QCgnutls_bootprop_verify_hostname_error)
7206 (QCgnutls_bootprop_callbacks_verify): Rename from
7207 Qgnutls_bootprop_..., all uses changed.
7208
7209 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7210 uses changed.
7211
0a0d27fb
PE
72122011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7213
19d5c50c
PE
7214 * xfaces.c (Qframe_set_background_mode): Now static.
7215 * dispextern.h (Qframe_set_background_mode): Remove decl.
7216
0a0d27fb
PE
7217 * process.c (Fnetwork_interface_info): Declare local only if needed.
7218
377538cb
JD
72192011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7220
7221 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7222 (Fnetwork_interface_list): Allocate in increments of bytes instead
7223 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7224 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7225 sockaddr.
7226 (struct ifflag_def): notrailers is smart on OSX.
7227 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7228 Get hardware address with getifaddrs if available.
7229
08fff70c
EZ
72302011-08-12 Eli Zaretskii <eliz@gnu.org>
7231
7232 * xdisp.c (iterate_out_of_display_property): xassert that
7233 IT->position is set to within IT->object's boundaries. Break from
7234 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7235 when IT->position is set up wrongly due to some bug.
7236 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7237 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7238 entry. Force push_it to save on the stack the current
7239 buffer/string position, to be restored by pop_it. Fix flags in
7240 the iterator structure wrt the object coming from a display
7241 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7242 properties. (Bug#9284)
7243
7be1c708 72442011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7245
7be1c708
CY
7246 * fontset.c (fontset_get_font_group): Add proper type checks.
7247 (Bug#9172)
aac0c6e3 7248
7be1c708 72492011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7250
7be1c708
CY
7251 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7252 and LC_VERSION_MIN_MACOSX.
7253 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7254 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7255
97bb72a6
EZ
72562011-08-08 Eli Zaretskii <eliz@gnu.org>
7257
7258 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7259 no-display-properties-and-no-overlays under bidi display.
7260 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7261 properties and overlays.
97bb72a6 7262
d5617611
CY
72632011-08-08 Chong Yidong <cyd@stupidchicken.com>
7264
37e11a63
CY
7265 * editfns.c (Fset_time_zone_rule): Document relationship with the
7266 setenv function.
7267
d5617611
CY
7268 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7269 the font entity extracted from the cache (Bug#8109).
7270
58872834
CY
72712011-08-07 Chong Yidong <cyd@stupidchicken.com>
7272
7273 * composite.c (autocmp_chars): Don't reset point. That is done by
7274 restore_point_unwind (Bug#5984).
7275
75bfc667
JL
72762011-08-07 Juri Linkov <juri@jurta.org>
7277
7278 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7279 to show the arg `TIME' instead of `TIMEVAL'.
7280
d1410150
EZ
72812011-08-06 Eli Zaretskii <eliz@gnu.org>
7282
7283 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7284 display property strides EOL and includes a newline, as in
7285 longlines-mode. (Bug#9254)
75b771e4
EZ
7286 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7287 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7288
7289 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7290 is non-zero, even if the data buffer is NULL. Fixes a crash in
7291 vertical-motion with longlines-mode. (Bug#9254)
7292
35928349
EZ
72932011-08-05 Eli Zaretskii <eliz@gnu.org>
7294
ec7cc85b
EZ
7295 * bidi.c <bidi_cache_total_alloc>: Now static.
7296 (bidi_initialize): Initialize bidi_cache_total_alloc.
7297
8b76d6f8 7298 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7299 cache. (Bug#9221)
7300
7301 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7302 amount allocated this far in `bidi_cache_total_alloc'.
7303 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7304 non-zero, only free the data buffer without restoring the cache
7305 contents. All callers changed.
7306
7307 * dispextern.h (bidi_unshelve_cache): Update prototype.
7308
7309 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7310 (move_it_in_display_line, move_it_to)
7311 (move_it_vertically_backward, move_it_by_lines): Replace the call
7312 to xfree to an equivalent call to bidi_unshelve_cache.
7313 (move_it_in_display_line_to): Fix logic of returning
412b6358 7314 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7315
e2e2423b
EZ
73162011-08-05 Eli Zaretskii <eliz@gnu.org>
7317
7318 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7319 came from a string character with a `cursor' property. (Bug#9229)
7320
ae9e757a
JD
73212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7322
7323 * Makefile.in (LIB_PTHREAD): New variable.
7324 (LIBES): Add LIB_PTHREAD (Bug#9216).
7325
7326 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7327 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7328
213bd7f2
AS
73292011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7330
6b02f655 7331 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7332
99aaf75f
JD
73332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7334
7335 * xterm.c (x_find_topmost_parent): New function.
7336 (x_set_frame_alpha): Find topmost parent window with
7337 x_find_topmost_parent and set the property there also (bug#9181).
7338 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7339
c74e9d86
PE
73402011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7341
7342 * callproc.c (Fcall_process): Avoid vfork clobbering
7343 the local vars buffer, coding_systems, current_dir.
7344
640c8776
SM
73452011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7346
7347 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7348
f26d0e4c
PE
73492011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7350
8a10d76c
PE
7351 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7352 so that it is not optimized away.
7353
f26d0e4c
PE
7354 * xdisp.c (compute_display_string_pos): Remove unused local.
7355
55439c61
EZ
73562011-08-02 Eli Zaretskii <eliz@gnu.org>
7357
7358 Fix slow cursor motion and scrolling in large buffers with
7359 selective display, like Org Mode buffers. (Bug#9218)
7360
7361 * dispextern.h (struct bidi_it): New member disp_prop_p.
7362
7363 * xdisp.c: Remove one-slot cache of display string positions.
7364 (compute_display_string_pos): Accept an additional argument
5e617bc2 7365 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7366 for a display string or property. If found, set DISP_PROP_P
7367 non-zero.
7368
7369 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7370 DISP_PROP_P, and pass it to compute_display_string_pos.
7371 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7372 non-zero. All callers of bidi_fetch_char changed.
7373
fb33fa43
SM
73742011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7375
7376 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7377
b099e063
DM
73782010-12-03 Don March <don@ohspite.net>
7379
7380 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7381 last character M-[char] is translated to ESC [char] (bug#7541).
7382
5cc7f7af
KH
73832011-08-02 Kenichi Handa <handa@m17n.org>
7384
d0fffa3f 7385 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7386
7387 * chartab.c (uniprop_table): Make it non-static.
7388
525d5e6e
EZ
73892011-08-01 Eli Zaretskii <eliz@gnu.org>
7390
7391 * xdisp.c (forward_to_next_line_start): Accept additional argument
7392 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7393 on the newline.
7394 (reseat_at_next_visible_line_start): Use the bidi iterator state
7395 returned by forward_to_next_line_start to restore the state of
7396 it->bidi_it after backing up to previous newline. (Bug#9212)
7397
31011111
AS
73982011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7399
7400 * regex.c (re_comp): Protoize.
7401 (re_exec): Fix return type.
7402 (regexec): Fix type of `ret'. (Bug#9203)
7403
476371c4
PE
74042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7405
e5d76069
PE
7406 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7407 This is needed if max-image-size is a floating-point number.
7408
9a79b20c
AS
74092011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7410
7411 * print.c (print_object): Print empty symbol as ##.
7412
7413 * lread.c (read1): Read ## as empty symbol.
7414
d8c2fa78
AA
74152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7416
7417 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7418 setting frame foreground color (Bug#9175).
7419 (x_set_background_color): Likewise.
7420
ffe57a7a
AA
7421 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7422 contents (Bug#9176).
7423 (EmacsTooltip -init): Remove bezels and add shadows to
7424 tooltip windows.
7425
bf3492a5
AA
7426 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7427 or scroll bar (Bug#8470).
7428
d55e9c53
AA
7429 * nsfont.m (nsfont_open): Remove assignment to voffset and
7430 unnecessary vars hshink, expand, hd, full_height, min_height.
7431 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7432
7433 * nsterm.h (nsfont_info): Remove voffset field.
7434
d8c2fa78 74352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7436
7437 Implement strike-through and overline on NextStep (Bug#8863).
7438
7439 * nsfont.m (nsfont_open): Use underline position provided by font,
7440 instead of hard-coded value of 2.
7441 (nsfont_draw): Call ns_draw_text_decoration instead.
7442
7443 * nsterm.h: Add declaration for ns_draw_text_decoration.
7444
7445 * nsterm.m (ns_draw_text_decoration): New function for drawing
7446 underline, overline, and strike-through.
7447 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7448 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7449 accommodate underlining, etc.
4843aac3 7450
4cc60b9b
EZ
74512011-07-28 Eli Zaretskii <eliz@gnu.org>
7452
bc7ece87
EZ
7453 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7454 default.
4cc60b9b 7455
476371c4
PE
74562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7457
66606eea
PE
7458 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7459 Without this fix, if a signal arrives just after memory fills up,
7460 'malloc' might be invoked reentrantly.
7461
476371c4
PE
7462 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7463 In other words, assume that every image size is allowed, on non-X
7464 hosts. This assumption is probably wrong, but it lets Emacs compile.
7465
f3fcc40d
AS
74662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7467
7468 * regex.c (re_iswctype): Convert return values to boolean.
7469
350c992f
EZ
74702011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7471
7472 * xdisp.c (compute_display_string_pos): Don't use cached display
7473 string position if the buffer had its restriction changed.
7474 (Bug#9184)
7475
5266b4bb
PE
74762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7477
7478 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7479
2573a837 74802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7481
41f55ccd 7482 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7483
39e378da
PE
7484 * bidi.c: Integer size and overflow fixes.
7485 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7486 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7487 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7488 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7489 (bidi_find_other_level_edge):
7490 Use ptrdiff_t instead of EMACS_INT where either will do.
7491 This works better on 32-bit hosts configured --with-wide-int.
7492 (bidi_cache_ensure_space): Check for size-calculation overflow.
7493 Use % rather than repeated addition, for better worst-case speed.
7494 Don't set bidi_cache_size until after xrealloc returns, because it
7495 might not return.
7496 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7497 (bidi_cache_ensure_space): Also check that the bidi cache size
7498 does not exceed that of the largest Lisp string or buffer. See Eli
7499 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7500
5e927815
PE
7501 * alloc.c (__malloc_size_t): Remove.
7502 All uses replaced by size_t. See Andreas Schwab's note
7503 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7504
ca4aa935
PE
7505 * image.c: Improve checking for integer overflow.
7506 (check_image_size): Assume that f is nonnull, since
7507 it is always nonnull in practice. This is one less thing to
7508 worry about when checking for integer overflow later.
7509 (x_check_image_size): New function, which checks for integer
7510 overflow issues inside X.
7511 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7512 This removes the need for a memory_full check.
7513 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7514 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7515 (xbm_read_bitmap_data): Change locals back to 'int', since
7516 their values must fit in 'int'.
7517 (xpm_load_image, png_load, tiff_load):
7518 Invoke x_create_x_image_and_pixmap earlier,
7519 to avoid much needless work if the image is too large.
7520 (tiff_load): Treat overly large images as if
7521 x_create_x_image_and_pixmap failed, not as malloc failures.
7522 (gs_load): Use x_check_image_size.
7523
5f8f9cc2
PE
7524 * gtkutil.c: Omit integer casts.
7525 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7526 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7527
5adf60bc
PE
7528 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7529
c8907a93
PE
7530 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7531 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7532 would wrongly return t on a 64-bit host.
7533
e3c25c68
PE
7534 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7535 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7536 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7537 and therefore cause GCC to emit a bogus diagnostic in some cases.
7538
3f791afe
PE
7539 * image.c: Integer signedness and overflow and related fixes.
7540 This is not an exhaustive set of fixes, but it's time to
7541 record what I've got.
7542 (lookup_pixel_color, check_image_size): Remove redundant decls.
7543 (check_image_size): Don't assume that arbitrary EMACS_INT values
7544 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7545 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7546 (tiff_load, imagemagick_load_image):
7547 Check for overflow in size calculations.
7548 (x_create_x_image_and_pixmap): Remove unnecessary test for
7549 xmalloc returning NULL; that can't happen.
7550 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7551 (xpm_color_bucket): Use better integer hashing function.
7552 (xpm_cache_color): Don't possibly over-allocate memory.
7553 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7554 (gif_memory_source):
7555 Use ptrdiff_t, not int or size_t, to record sizes.
7556 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7557 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7558 either works, as we prefer signed integers.
7559 (tiff_read_from_memory, tiff_write_from_memory):
7560 Return tsize_t, not size_t, since that's what the TIFF API wants.
7561 (tiff_read_from_memory): Don't fail simply because the read would
7562 go past EOF; instead, return a short read.
7563 (tiff_load): Omit no-longer-needed casts.
7564 (Fimagemagick_types): Don't assume size fits into 'int'.
7565
3cc5a532
PE
7566 Improve hashing quality when configured --with-wide-int.
7567 * fns.c (hash_string): New function, taken from sxhash_string.
7568 Do not discard information about ASCII character case; this
7569 discarding is no longer needed.
7570 (sxhash-string): Use it. Change sig to match it. Caller changed.
7571 * lisp.h: Declare it.
7572 * lread.c (hash_string): Remove, since we now use fns.c's version.
7573 The fns.c version returns a wider integer if --with-wide-int is
7574 specified, so this should help the quality of the hashing a bit.
7575
b312a492
PE
7576 * emacs.c: Integer overflow minor fix.
7577 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7578 Define only if GNU_LINUX.
7579 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7580
dfd153ae
PE
7581 * dispnew.c: Integer signedness and overflow fixes.
7582 Remove unnecessary forward decls, that were a maintenance hassle.
7583 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7584 All uses changed.
7585 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7586 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7587 (prepare_desired_row, line_draw_cost):
7588 Use int, not unsigned, where either works.
7589 (save_current_matrix, restore_current_matrix):
7590 Use ptrdiff_t, not size_t, where either works.
7591 (init_display): Check for overflow more accurately, and without
7592 relying on undefined behavior.
7593
a81d11a3
PE
7594 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7595 Remove, replacing with the new symbols in lisp.h. All uses changed.
7596 * fileio.c (make_temp_name):
7597 * filelock.c (lock_file_1, lock_file):
7598 * xdisp.c (message_dolog):
7599 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7600 Use pMd etc. instead.
7601 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7602 replacing the pWIDE etc. symbols removed from editfns.c.
7603
3300e6fd
PE
7604 * keyboard.h (num_input_events): Now uintmax_t.
7605 This is (very slightly) less likely to mess up due to wraparound.
7606 All uses changed.
7607
fd05c7e9
PE
7608 * buffer.c: Integer signedness fixes.
7609 (alloc_buffer_text, enlarge_buffer_text):
7610 Use ptrdiff_t rather than size_t when either will do, as we prefer
7611 signed integers.
7612
903fe15d
PE
7613 * alloc.c: Integer signedness and overflow fixes.
7614 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7615 (__malloc_size_t): Default to size_t, not to int.
7616 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7617 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7618 Prefer ptrdiff_t to size_t when either would do, as we prefer
7619 signed integers.
7620 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7621 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7622 Now const. Initialize with values that are in range even if char
7623 is signed.
7624 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7625 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7626 These functions do the right thing with sizes > 2**32.
7627 (check_depth): Now ptrdiff_t, not int.
7628 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7629 Adjust to new way of storing sizes. Check for size overflow bugs
7630 in rest of code.
7631 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7632 slightly wrong anyway, as it missed one instance of
7633 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7634 (refill_memory_reserve): Omit needless cast to size_t.
7635 (mark_object_loop_halt): Mark as externally visible.
7636
ac82cc6a
PE
7637 * xselect.c: Integer signedness and overflow fixes.
7638 (Fx_register_dnd_atom, x_handle_dnd_message):
7639 Use ptrdiff_t, not size_t, since we prefer signed.
7640 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7641 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7642 x_dnd_atoms_size and x_dnd_atoms_length.
7643
c2d1e36d
PE
7644 * doprnt.c: Prefer signed to unsigned when either works.
7645 * eval.c (verror):
7646 * doprnt.c (doprnt):
7647 * lisp.h (doprnt):
7648 * xdisp.c (vmessage):
7649 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7650 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7651 prefer signed arithmetic to avoid comparison confusion.
7652 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7653 but is a bit tricky.
7654
0e926e56
PE
7655 Assume freestanding C89 headers, string.h, stdlib.h.
7656 * data.c, doprnt.c, floatfns.c, print.c:
7657 Include float.h unconditionally.
7658 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7659 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7660 * regex.c: Likewise for stddef.h, string.h.
7661 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7662 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7663 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7664 (STDC_HEADERS): Remove obsolete defines.
7665 * sysdep.c: Include limits.h unconditionally.
7666
9cfdb3ec
PE
7667 Assume support for memcmp, memcpy, memmove, memset.
7668 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7669 * regex.c (memcmp, memcpy):
7670 Remove; we assume C89 now.
7671
7672 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7673 (__malloc_safe_bcopy): Remove; no longer needed.
7674
cf950e6b 7675 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7676 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7677 well either way, and we prefer signed to unsigned.
7678
dbf38e02
LMI
76792011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7680
7681 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7682 closes the connection while we're reading (bug#9182).
7683
d6f0886c 76842011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7685
d6f0886c
JD
7686 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7687 are specified (Bug#9168).
24e0f6b1 7688
2eb1f9e6
PE
76892011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7690
7691 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7692 Found by GCC static checking and --with-wide-int on a 32-bit host.
7693
22381272 76942011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7695
7696 * xdisp.c (compute_display_string_pos): Fix logic of caching
7697 previous display string position. Initialize cached_prev_pos to
7698 -1. Fixes slow-down at the beginning of a buffer.
7699
f25e39b4
EZ
77002011-07-24 Eli Zaretskii <eliz@gnu.org>
7701
7702 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7703 for attrs[LFACE_FONTSET_INDEX].
7704
04c4b52e
PE
77052011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7706
7707 * xml.c (parse_region): Remove unused local
7708 that was recently introduced.
7709
c1734fbd
EZ
77102011-07-23 Eli Zaretskii <eliz@gnu.org>
7711
be18c5a5
EZ
7712 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7713 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7714
c1734fbd
EZ
7715 * xdisp.c (move_it_in_display_line_to): Record the best matching
7716 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7717 exit if none of the characters scanned was an exact match.
7718 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7719 when exact match is impossible due to invisible text, and the
7720 lines are truncated.
7721
a258d627
JD
77222011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7723
7724 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7725 for OSX >= 10.7.
7726
b6d5a689
EZ
77272011-07-22 Eli Zaretskii <eliz@gnu.org>
7728
0f74f785
EZ
7729 Fix a significant slow-down of cursor motion with C-n, C-p,
7730 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7731 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7732 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7733 (next_element_from_buffer): Call compute_stop_pos_backwards to
7734 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7735 base_level_stop.
7736 (reseat): Don't look for prev_stop, as that could mean a very long
7737 run.
7738 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7739 <cached_disp_overlay_modiff>: Cache for last found display string
7740 position.
551918c1 7741 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7742 about the same buffer in the same area of character positions, and
7743 the buffer wasn't changed since the time the display string
7744 position was cached.
551918c1 7745
b2d0c91a
EZ
77462011-07-22 Eli Zaretskii <eliz@gnu.org>
7747
7748 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7749 is an integer, which is important for empty lines. (Bug#9149)
7750
043604ee
CY
77512011-07-22 Chong Yidong <cyd@stupidchicken.com>
7752
7753 * frame.c (Fmodify_frame_parameters): In tty case, update the
7754 default face if necessary (Bug#4238).
7755
da4adb04
CY
77562011-07-21 Chong Yidong <cyd@stupidchicken.com>
7757
7758 * editfns.c (Fstring_to_char): No need to explain what a character
7759 is in the docstring (Bug#6576).
7760
9abd0532
LMI
77612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7762
7763 * xml.c (parse_region): Make sure we always return a tree.
7764
36881d16
HK
77652011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7766
7767 * xml.c (parse_region): If a document contains only comments,
7768 return that, too.
7769
1e98674d
LMI
77702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7771
7772 * xml.c (make_dom): Return comments, too.
7773
590bd467
PE
77742011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7775
7776 Port to OpenBSD.
7777 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7778 and the surrounding thread.
7779 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7780 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7781 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7782 timer goes off.
7783 * s/openbsd.h (BROKEN_SIGIO): Define.
7784 * unexelf.c (unexec) [__OpenBSD__]:
7785 Don't update the .mdebug section of the Alpha COFF symbol table.
7786
f41628b2
LMI
77872011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7788
7789 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7790 (bug#8460).
7791
b59b67c5
PE
77922011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7793
15e3a074
PE
7794 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7795 This fixes some race conditions on the permissions of any newly
7796 created file.
7797
41bed37d
PE
7798 * alloc.c (valid_pointer_p): Use pipe, not open.
7799 This fixes some permissions issues when debugging.
7800
b59b67c5
PE
7801 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7802 If fchown fails to set both uid and gid, try to set just gid,
7803 as that is sometimes allowed. Adjust the file's mode to eliminate
7804 setuid or setgid bits that are inappropriate if fchown fails.
7805
925a6be7
SM
78062011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7807
7808 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7809 to compare Lisp_Objects.
7810 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7811 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7812 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7813
52968808
AS
78142011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7815
0a6a104b
AS
7816 * lread.c (read_integer): Unread even EOF character.
7817 (read1): Likewise. Properly record start position of symbol.
7818
52968808
AS
7819 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7820 symbol character follows.
7821
9e381cdd
PE
78222011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7823
7824 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7825 This works around a problem with the previous change to Fcopy_file.
7826 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7827 and without this change, GCC might complain about discarding
7828 fchown's return value.
7829
b5641435
JB
78302011-07-16 Juanma Barranquero <lekktu@gmail.com>
7831
7832 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7833
a8031457
PE
78342011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7835
7836 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7837
dd889327
LMI
78382011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7839
750c33f7
LMI
7840 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7841 it's used from the C level.
7842
dd889327
LMI
7843 * process.c: Use the same condition for POLL_FOR_INPUT in both
7844 keyboard.c and process.c (bug#1858).
7845
87e86684
LM
78462011-07-09 Lawrence Mitchell <wence@gmx.li>
7847
7848 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7849 (Fgnutls_boot): Use it.
7850
64348f40
AS
78512011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7852
7853 * doc.c (Fsubstitute_command_keys): Revert last change.
7854
1d698799
LMI
78552011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7856
f863868c
LMI
7857 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7858 quotes the next character, and doesn't affect other longer
7859 sequences (bug#8935).
7860
1d698799
LMI
7861 * lread.c (syms_of_lread): Clarify that is isn't only
7862 `eval-buffer' and `eval-defun' that's affected by
7863 `lexical-binding' (bug#8460).
7864
aa4b6df6
EZ
78652011-07-15 Eli Zaretskii <eliz@gnu.org>
7866
7867 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7868 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7869
5d856da6
PE
78702011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7871
ad6042bb
PE
7872 Fix minor problems found by static checking.
7873 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7874 (elsz): Now a signed constant, not a size_t var. We prefer signed
7875 types to unsigned, to avoid integer comparison confusion. Without
7876 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7877 "cannot optimize loop, the loop counter may overflow", a symptom
7878 of the confusion.
f00bbb22 7879 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7880 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7881
6468f31c
LMI
78822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7883
49080b10
LMI
7884 * search.c (Fre_search_backward): Mention `case-fold-search' in
7885 all the re_search_* functions (bug#8138).
7886
6468f31c
LMI
7887 * keyboard.c (Fopen_dribble_file): Document when the file is
7888 closed (bug#8056).
7889
c965adc5
EZ
78902011-07-14 Eli Zaretskii <eliz@gnu.org>
7891
df9733bf
EZ
7892 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7893 bidi_cache_idx.
7894
0bb23927
EZ
7895 Support bidi reordering of display and overlay strings.
7896 * xdisp.c (compute_display_string_pos)
7897 (compute_display_string_end): Accept additional argument STRING.
7898 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7899 (reseat_to_string): Initialize bidi_it->string.s and
7900 bidi_it->string.schars.
7901 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7902 NULL (avoids a crash in bidi_paragraph_init).
7903 Initialize itb.string.lstring.
0bb23927
EZ
7904 (init_iterator): Call bidi_init_it only of a valid
7905 buffer position was specified. Initialize paragraph_embedding to
7906 L2R.
7907 (reseat_to_string): Initialize the bidi iterator.
7908 (display_string): If we need to ignore text properties of
7909 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7910 original value of -1 will not work with bidi.)
7911 (compute_display_string_pos): First arg is now struct
7912 `text_pos *'; all callers changed. Support display properties on
7913 Lisp strings.
7914 (compute_display_string_end): Support display properties on Lisp
7915 strings.
7916 (init_iterator, reseat_1, reseat_to_string): Initialize the
7917 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7918 when iterating on a string not from display properties).
640c8776
SM
7919 (compute_display_string_pos, compute_display_string_end):
7920 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7921 arrow keys.
7922 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7923 base_level_stop; instead, set base_level_stop to BEGV.
7924 Fixes crashes in vertical-motion.
0bb23927
EZ
7925 (next_element_from_buffer): Improve commentary for when
7926 the iterator is before prev_stop.
7927 (init_iterator): Initialize bidi_p from the default value of
7928 bidi-display-reordering, not from buffer-local value. Use the
7929 buffer-local value only if initializing for buffer iteration.
7930 (handle_invisible_prop): Support invisible properties on strings
7931 that are being bidi-reordered.
7932 (set_iterator_to_next): Support bidi reordering of C strings and
7933 Lisp strings.
7934 (next_element_from_string): Support bidi reordering of Lisp
7935 strings.
7936 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7937 (display_string): Support display of R2L glyph rows.
7938 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7939 (init_iterator): Don't initialize it->bidi_p for strings
7940 here.
7941 (reseat_to_string): Initialize it->bidi_p for strings here.
7942 (next_element_from_string, next_element_from_c_string)
7943 (next_element_from_buffer): Add xassert's for correspondence
7944 between IT's object being iterated and it->bidi_it.string
7945 structure.
7946 (face_before_or_after_it_pos): Support bidi iteration.
7947 (next_element_from_c_string): Handle the case of the first string
7948 character that is not the first one in the visual order.
7949 (get_visually_first_element): New function, refactored from common
7950 parts of next_element_from_buffer, next_element_from_string, and
7951 next_element_from_c_string.
7952 (tool_bar_lines_needed, redisplay_tool_bar)
7953 (display_menu_bar): Force left-to-right direction. Add a FIXME
7954 comment for making that be controlled by a user option.
7955 (push_it, pop_it): Save and restore the state of the
7956 bidi iterator. Save and restore the bidi_p flag.
7957 (pop_it): Iterate out of display property for string iteration as
7958 well.
7959 (iterate_out_of_display_property): Support iteration over strings.
7960 (handle_single_display_spec): Set up it->bidi_it for iteration
7961 over a display string, and call bidi_init_it.
7962 (handle_single_display_spec, next_overlay_string)
7963 (get_overlay_strings_1, push_display_prop): Set up the bidi
7964 iterator for displaying display or overlay strings.
7965 (forward_to_next_line_start): Don't use the shortcut if
7966 bidi-iterating.
7967 (back_to_previous_visible_line_start): If handle_display_prop
7968 pushed the iterator stack, restore the internal state of the bidi
7969 iterator by calling bidi_pop_it same number of times.
7970 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7971 and we are bidi-iterating, don't decrement the iterator position;
7972 instead, set the first_elt flag in the bidi iterator, to produce
7973 the same effect.
7974 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7975 (push_display_prop): xassert that we are iterating a buffer.
7976 (push_it, pop_it): Save and restore paragraph_embedding member.
7977 (handle_single_display_spec, next_overlay_string)
7978 (get_overlay_strings_1, reseat_1, reseat_to_string)
7979 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7980 correctly. Don't assume unibyte strings are not bidi-reordered.
7981 (compute_display_string_pos)
7982 (compute_display_string_end): Fix handling the case of C string.
7983 (push_it, pop_it): Save and restore from_disp_prop_p.
7984 (handle_single_display_spec, push_display_prop): Set the
7985 from_disp_prop_p flag.
7986 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7987 (pop_it): Call iterate_out_of_display_property only if we are
7988 popping after iteration over a string that came from a display
7989 property. Fix a typo in popping stretch info. Add an assertion
7990 for verifying that the iterator position is in sync with the bidi
7991 iterator.
7992 (handle_single_display_spec, get_overlay_strings_1)
7993 (push_display_prop): Fix initialization of paragraph direction for
7994 string when that of the parent object is not yet determined.
7995 (reseat_1): Call bidi_init_it to resync the bidi
7996 iterator with IT's position. (Bug#7616)
7997 (find_row_edges): If ROW->start.pos gives position
7998 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7999 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8000 Reset the from_disp_prop_p flag.
8001 (SAVE_IT, RESTORE_IT): New macros.
8002 (pos_visible_p, face_before_or_after_it_pos)
8003 (back_to_previous_visible_line_start)
8004 (move_it_in_display_line_to, move_it_in_display_line)
8005 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8006 (try_scrolling, redisplay_window, display_line): Use them when
8007 saving a temporary copy of the iterator and restoring it back.
8008 (back_to_previous_visible_line_start, reseat_1)
8009 (init_iterator): Empty the bidi cache "stack".
8010 (move_it_in_display_line_to): If iterator ended up at
8011 EOL, but we never saw any buffer positions smaller than
8012 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8013 motion in bidi-reordered lines.
8014 (move_it_in_display_line_to): Record prev_method and prev_pos
8015 immediately before the call to set_iterator_to_next. Fixes cursor
8016 motion in bidi-reordered lines with stretch glyphs and strings
8017 displayed in margins. (Bug#8133) (Bug#8867)
8018 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8019 TO_CHARPOS.
640c8776
SM
8020 (pos_visible_p): Support positions in bidi-reordered lines.
8021 Save and restore bidi cache.
0bb23927
EZ
8022
8023 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8024 (bidi_paragraph_info): Delete unused struct.
8025 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8026 (bidi_cache_start): New variable.
8027 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8028 to zero.
8029 (bidi_cache_fetch_state, bidi_cache_search)
8030 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8031 (bidi_cache_find, bidi_peek_at_next_level)
8032 (bidi_level_of_next_char, bidi_find_other_level_edge)
8033 (bidi_move_to_visually_next): Compare cache index with
8034 bidi_cache_start rather than with zero.
8035 (bidi_fetch_char): Accept new argument STRING; all callers
8036 changed. Support iteration over a string. Support strings with
8037 display properties. Support unibyte strings. Fix the type of
8038 `len' according to what STRING_CHAR_AND_LENGTH expects.
8039 (bidi_paragraph_init, bidi_resolve_explicit_1)
8040 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8041 (bidi_level_of_next_char, bidi_move_to_visually_next):
8042 Support iteration over a string.
0bb23927
EZ
8043 (bidi_set_sor_type, bidi_resolve_explicit_1)
8044 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8045 can now be zero (for strings); special values 0 and -1 were
8046 changed to -1 and -2, respectively.
8047 (bidi_char_at_pos): New function.
8048 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8049 Call it instead of FETCH_MULTIBYTE_CHAR.
8050 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8051 initialized to valid values.
8052 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8053 values.
8054 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8055 the test for valid cached positions. Fix the logic for looking up
8056 the sentinel state in the cache. GCPRO the Lisp string we are
8057 iterating.
8058 (bidi_push_it, bidi_pop_it): New functions.
8059 (bidi_initialize): Initialize the bidi cache start stack pointer.
8060 (bidi_cache_ensure_space): New function, refactored from part of
8061 bidi_cache_iterator_state. Don't assume the required size is just
8062 one BIDI_CACHE_CHUNK away.
8063 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8064 (bidi_count_bytes, bidi_char_at_pos): New functions.
8065 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8066 always valid if bidi_cache_idx is valid.
8067 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8068 is valid if it's going to be used.
8069 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8070 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8071 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8072 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8073 (bidi_find_other_level_edge, bidi_cache_start_stack):
8074 All variables related to cache indices are now EMACS_INT.
c965adc5 8075
0bb23927
EZ
8076 * dispextern.h (struct bidi_string_data): New structure.
8077 (struct bidi_it): New member `string'. Make flag members be 1-bit
8078 fields, and put them last in the struct.
640c8776
SM
8079 (compute_display_string_pos, compute_display_string_end):
8080 Update prototypes.
0bb23927
EZ
8081 (bidi_push_it, bidi_pop_it): Add prototypes.
8082 (struct iterator_stack_entry): New members bidi_p,
8083 paragraph_embedding, and from_disp_prop_p.
8084 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8085 (bidi_shelve_cache, bidi_unshelve_cache):
8086 Declare prototypes.
0bb23927
EZ
8087
8088 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8089 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8090 and vector-like objects.
8091
8092 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8093 cache around display iteration.
8094
8095 * window.c (Fwindow_end, window_scroll_pixel_based)
8096 (displayed_window_lines, Frecenter): Save and restore the bidi
8097 cache around display iteration.
8098
3bbd2265
LMI
80992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8100
8101 * editfns.c (Fdelete_region): Clarify the use of the named
8102 parameters (bug#6788).
8103
adc47434
MR
81042011-07-14 Martin Rudalics <rudalics@gmx.at>
8105
8106 * indent.c (Fvertical_motion): Set and restore w->pointm when
8107 saving and restoring the window's buffer (Bug#9006).
8108
837c31f8
LMI
81092011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8110
8111 * editfns.c (Fstring_to_char): Clarify just what is returned
8112 (bug#6576). Text by Eli Zaretskii.
8113
ac389d0c
JB
81142011-07-13 Juanma Barranquero <lekktu@gmail.com>
8115
8116 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8117
0be0ce47
EZ
81182011-07-13 Eli Zaretskii <eliz@gnu.org>
8119
8120 * buffer.c (mmap_find): Fix a typo.
8121
cd18e7e3
JB
81222011-07-13 Johan Bockgård <bojohan@gnu.org>
8123
8124 Fix execution of x selection hooks.
8125 * xselect.c (Qx_lost_selection_functions)
8126 (Qx_sent_selection_functions): New vars.
8127 (syms_of_xselect): DEFSYM them.
8128 (x_handle_selection_request): Pass Qx_sent_selection_functions
8129 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8130 (x_handle_selection_clear,x_clear_frame_selections):
8131 Pass Qx_lost_selection_functions rather than
8132 Vx_lost_selection_functions to Frun_hook_with_args.
8133
47ea7f44
PE
81342011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8135
ac389d0c 8136 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8137 The old code sometimes used this field without initializing it.
8138
47ea7f44
PE
8139 * alloc.c (gc_sweep): Don't read past end of array.
8140 In theory, the old code could also have corrupted Emacs internals,
8141 though it'd be very unlikely.
8142
bc985c87
AS
81432011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8144
8145 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8146 argument. (Bug#4026)
bc985c87 8147
0cf34688
LMI
81482011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8149
b3dadd76
LMI
8150 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8151 key" (bug#4257).
8152
0cf34688
LMI
8153 * window.c (Fset_window_start): Doc fix (bug#4199).
8154 (Fset_window_hscroll): Ditto.
8155
270768cd
PE
81562011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8157
077e3dda 8158 Fix minor new problems caught by GCC 4.6.1.
270768cd 8159 * term.c (init_tty): Remove unused local.
490011a6 8160 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8161 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8162 not used otherwise.
270768cd 8163
b1f58454
CY
81642011-07-12 Chong Yidong <cyd@stupidchicken.com>
8165
8166 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8167
22b9578d
LMI
81682011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8169
6e70ab07
LMI
8170 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8171 are the mini-buffer and the echo area (bug#3320).
8172
22b9578d
LMI
8173 * term.c (init_tty): Remove support for supdup, c10 and perq
8174 terminals, which are no longer supported (bug#1482).
8175
8974cc9f
JB
81762011-07-10 Johan Bockgård <bojohan@gnu.org>
8177
8178 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8179
a560d974
JD
81802011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8181
8182 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8183 for non-popups (Bug#3642).
8184
1dae0f0a
AS
81852011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8186
268c2c36 8187 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8188 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8189 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8190 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8191 * data.c (fmod): Likewise.
8192 * dispnew.c (swap_glyphs_in_rows): Likewise.
8193 * emacs.c (memory_warning_signal): Likewise.
8194 * floatfns.c (float_error): Likewise.
8195 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8196 (otf_open, font_otf_capability, generate_otf_features)
8197 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8198 Likewise.
8199 * image.c (pbm_read_file): Likewise.
8200 * indent.c (string_display_width): Likewise.
8201 * intervals.c (check_for_interval, search_for_interval)
8202 (inc_interval_count, count_intervals, root_interval)
8203 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8204 * lread.c (defalias): Likewise.
268c2c36 8205 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8206 * regex.c (set_image_of_range_1, set_image_of_range)
8207 (regex_grow_registers): Likewise.
8208 * sysdep.c (strerror): Likewise.
8209 * termcap.c (valid_filename_p, tprint, main): Likewise.
8210 * tparam.c (main): Likewise.
8211 * unexhp9k800.c (run_time_remap, save_data_space)
8212 (update_file_ptrs, read_header, write_header, calculate_checksum)
8213 (copy_file, copy_rest, display_header): Likewise.
8214 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8215 Likewise.
8216 * xdisp.c (check_it): Likewise.
8217 * xfaces.c (register_color, unregister_color, unregister_colors):
8218 Likewise.
8219 * xfns.c (print_fontset_result): Likewise.
8220 * xrdb.c (member, fatal, main): Likewise.
8221
99033785
PE
82222011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8223
8224 Fix minor problems found by static checking (Bug#9031).
8225 * chartab.c (char_table_set_range, map_sub_char_table):
8226 Remove unused locals.
8227 (uniprop_table): Now static.
8228 * composite.c (_work_char): Remove unused static var.
8229
9cb2ac56
JB
82302011-07-09 Juanma Barranquero <lekktu@gmail.com>
8231
8232 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8233
f25661f0
JD
82342011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8235
8236 * gtkutil.c (qttip_cb): Remove code without function.
8237
8278c4fe
EZ
82382011-07-09 Eli Zaretskii <eliz@gnu.org>
8239
8240 * w32.c (pthread_sigmask): New stub.
8241
1692ae2d 82422011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8243
8a6ebd58 8244 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8245 sigprocmask is portable only for single-threaded applications, and
8246 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8247 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8248 (LIBES): Use it.
8249 * callproc.c (Fcall_process):
8250 * process.c (create_process):
8251 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8252 Use pthread_sigmask, not sigprocmask.
123403e4 8253
1b854618
JD
82542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8255
8256 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8257 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8258 wrong (Bug#8591).
8259
3fe4b549
JD
82602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8261
0ce7e563
JD
8262 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8263 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8264 (xg_hide_tooltip): Fix comment.
8265
3fe4b549
JD
8266 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8267 in registerServicesMenuSendTypes.
8268 (validRequestorForSendType): Don't check ns_return_types.
8269
8270 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8271 ns_return_type.
8272
5df75e47
JR
82732011-07-08 Jason Rumney <jasonr@gnu.org>
8274
22610910
JR
8275 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8276 SH_SHOW for hidden windows (Bug#5482).
8277
5df75e47
JR
8278 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8279 frame struct members of non-existent frames (Bug#6284).
8280
699c10bd
JD
82812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8282
4393663b
JD
8283 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8284 variable firstTime not needed on OSX >= 10.6.
8285 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8286 >= 10.5. Use setKnobProportion, setDoubleValue.
8287
8288 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8289 (MAC_OS_X_VERSION_10_5): Define if not defined.
8290 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8291 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8292 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8293
8294 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8295 cString and lossyCString on OSX >= 10.4.
4393663b 8296
58179cce 8297 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8298 sizeToFit on OSX >= 10.2.
8299
8300 * nsimage.m (allocInitFromFile): Don't use deprecated method
8301 bestRepresentationForDevice on OSX >= 10.6.
8302
8303 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8304 to avoid warning.
8305
8306 * emacs.c: Declare unexec_init_emacs_zone.
8307
a63e0781
JD
8308 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8309
699c10bd
JD
8310 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8311
8312 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8313 on svcsMenu (Bug#8842).
8314
8315 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8316 ns_return_types.
8317 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8318
8319 * nsterm.m (QUTF8_STRING): Declare.
8320 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8321 (validRequestorForSendType): Return type is (id).
8322 Change indexOfObjectIdenticalTo to indexOfObject.
8323 Check if we have local selection before returning self (Bug#8842).
8324 (writeSelectionToPasteboard): Put local selection into paste board
8325 if we have a local selection (Bug#8842).
8326 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8327
8328 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8329 (ns_get_local_selection): Declare.
8330
54e10184
LMI
83312011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8332
9888ff71
LMI
8333 * keymap.c (describe_map_tree): Don't insert a double newline at
8334 the end of the buffer (bug#1169) and return whether we inserted
8335 something.
8336
54e10184
LMI
8337 * callint.c (Fcall_interactively): Change "reading args" to
8338 "providing args" to try to clarify what it does (bug#1010).
8339
15fa4783
KH
83402011-07-07 Kenichi Handa <handa@m17n.org>
8341
8342 * composite.c (composition_compute_stop_pos): Ignore a static
8343 composition starting before CHARPOS (Bug#8915).
8344
8345 * xdisp.c (handle_composition_prop): Likewise.
8346
a8815b00
EZ
83472011-07-07 Eli Zaretskii <eliz@gnu.org>
8348
8349 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8350 (Bug#9015)
8351
ef7b981d 83522011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8353
8354 * character.h (unicode_category_t): New enum type.
8355
8356 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8357 (Qchar_code_property_table): New variable.
8358 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8359 (UNIPROP_COMPRESSED_FORM_P): New macros.
8360 (char_table_ascii): Uncompress the compressed values.
8361 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8362 Uncompress the compressed values.
ac389d0c 8363 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8364 (char_table_ref_and_range): Uncompress the compressed values.
8365 (sub_char_table_set): New arg is_uniprop. Callers changed.
8366 Uncompress the compressed values.
8367 (sub_char_table_set_range): Args changed. Callers changed.
8368 (char_table_set_range): Adjuted for the above change.
8369 (map_sub_char_table): Delete args default_val and parent. Add arg
8370 top. Give decoded values to a Lisp function.
640c8776 8371 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8372 values to a Lisp function. Gcpro more variables.
8373 (uniprop_table_uncompress)
8374 (uniprop_decode_value_run_length): New functions.
8375 (uniprop_decoder, uniprop_decoder_count): New variables.
8376 (uniprop_get_decoder, uniprop_encode_value_character)
8377 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8378 New functions.
8379 (uniprop_encoder, uniprop_encoder_count): New variables.
8380 (uniprop_get_encoder, uniprop_table)
8381 (Funicode_property_table_internal, Fget_unicode_property_internal)
8382 (Fput_unicode_property_internal): New functions.
8383 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8384 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8385 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8386 char-code-property-alist.
8387
640c8776 8388 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8389 Vunicode_category_table.
8390
640c8776 8391 * font.c (font_range): Adjust for the change of
c805dec0
KH
8392 Vunicode_category_table.
8393
76b397fb
DN
83942011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8395
8396 * m/iris4d.h: Remove file, move contents ...
8397 * s/irix6-5.h: ... here.
8398
22b4128e
PE
83992011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8400
8401 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8402 * alloc.c (mark_buffer):
8403 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8404 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8405 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8406 This isn't true in general, and it's particularly not true
8407 if Emacs is configured with --with-wide-int.
8408 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8409 New macros, used in the buffer.c change.
8410
869795d6
JD
84112011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8412
8413 * xsettings.c: Use both GConf and GSettings if both are available.
8414 (store_config_changed_event): Add comment.
8415 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8416 (store_tool_bar_style_changed): New functions.
5e617bc2 8417 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8418 (struct xsettings): Move font inside HAVE_XFT.
8419 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8420 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8421 Move inside HAVE_XFT.
640c8776 8422 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8423 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8424 also.
8425 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8426 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8427 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8428 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8429 (parse_settings): Move check for font inside HAVE_XFT.
8430 (read_settings, apply_xft_settings): Add comment.
8431 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8432 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8433 call store_font_name_changed.
8434 (xft_settings_event): Add comment.
8435 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8436 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8437 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8438 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8439 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8440 (xsettings_get_system_font, xsettings_get_system_normal_font):
8441 Add comment.
869795d6 8442
d8ed26bd
PE
84432011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8444
8445 Random fixes. E.g., (random) never returned negative values.
8446 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8447 subseconds part to the entropy, as that's a bit more random.
8448 Prefer signed to unsigned, since the signedness doesn't matter and
8449 in general we prefer signed. When given a limit, use a
8450 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8451 latter isn't right if USE_2_TAGS_FOR_INTS.
8452 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8453 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8454
cabf1cac
SM
84552011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8456
8457 * textprop.c (text_property_stickiness):
8458 Obey Vtext_property_default_nonsticky.
8459 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8460 * w32fns.c (syms_of_w32fns):
8461 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8462
6e9b2be9
PE
84632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8464
8465 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8466 This is more efficient than Ffile_directory_p and avoids a minor race.
8467
90186c68
LMI
84682011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8469
7c301272
LMI
8470 * buffer.c (Foverlay_put): Say what the return value is
8471 (bug#7835).
8472
c4f2d8d4
LMI
8473 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8474 is a directory before asking whether to use the file name
8475 (bug#7564).
ad637907
LMI
8476 (barf_or_query_if_file_exists): Make the "File is a directory"
8477 error be more correct.
c4f2d8d4 8478
90186c68
LMI
8479 * fns.c (Frequire): Remove the mention of the .gz files, since
8480 that's installation-specific, but keep the mention of
8481 `get-load-suffixes'.
8482
da64016e
PE
84832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8484
8485 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8486 Report string overflow if the output is too long.
8487
7d47b580
JB
84882011-07-04 Juanma Barranquero <lekktu@gmail.com>
8489
a555cb87
JB
8490 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8491 (syms_of_gnutls): Remove duplicate DEFSYM for
8492 Qgnutls_bootprop_verify_hostname_error, an error for
8493 Qgnutls_bootprop_verify_error (which is no longer used).
8494
7d47b580
JB
8495 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8496 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8497 Also (re)move comments that are misplaced or no longer relevant.
8498
1e49bfab
LMI
84992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8500
8501 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8502
1485f4c0
CY
85032011-07-03 Chong Yidong <cyd@stupidchicken.com>
8504
8505 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8506 and background color parameters if they have been changed.
8507
a9ab721e
LMI
85082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8509
8510 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8511
cf7cff57
PE
85122011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8513
2e13213d
PE
8514 * xsettings.c (SYSTEM_FONT): Define only when used.
8515 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8516
cf7cff57
PE
8517 * keymap.c (access_keymap_1): Now static.
8518
7a8e04f7
CY
85192011-07-02 Chong Yidong <cyd@stupidchicken.com>
8520
8521 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8522 leave any prefix arg for the up event (Bug#1586).
8523
61352f62
LMI
85242011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8525
69bb1ef7
LMI
8526 * lread.c (syms_of_lread): Mention single symbols defined by
8527 `defvar' or `defconst' (bug#7154).
8528
61352f62 8529 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8530 (Frequire): Mention get-load-suffixes.
61352f62 8531
28545e04
MR
85322011-07-02 Martin Rudalics <rudalics@gmx.at>
8533
8534 * window.h (window): Remove clone_number slot.
8535 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8536 Remove.
8537 (make_parent_window, make_window, saved_window)
8538 (Fset_window_configuration, save_window_save): Don't deal with
8539 clone numbers.
8540 * buffer.c (Qclone_number): Remove declaration.
8541 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8542
3349e122
SM
85432011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8544
8545 Add multiple inheritance to keymaps.
8546 * keymap.c (Fmake_composed_keymap): New function.
8547 (Fset_keymap_parent): Simplify.
8548 (fix_submap_inheritance): Remove.
8549 (access_keymap_1): New function extracted from access_keymap to handle
8550 embedded parents and handle lists of maps.
8551 (access_keymap): Use it.
8552 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8553 (Fcopy_keymap): Handle embedded parents.
8554 (Fcommand_remapping, define_as_prefix): Simplify.
8555 (Fkey_binding): Simplify.
8556 (syms_of_keymap): Move minibuffer-local-completion-map,
8557 minibuffer-local-filename-completion-map,
8558 minibuffer-local-must-match-map, and
8559 minibuffer-local-filename-must-match-map to Elisp.
8560 (syms_of_keymap): Defsubr make-composed-keymap.
8561 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8562 (parse_menu_item): Trivial simplification.
8563
3279eb87
GM
85642011-07-01 Glenn Morris <rgm@gnu.org>
8565
8566 * Makefile.in (SETTINGS_LIBS): Fix typo.
8567
4550efdf
KI
85682011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8569
8570 * coding.c (Fencode_coding_string): Record the last coding system
8571 used, as the function doc string says (bug#8738).
8572
0949d2b6
JD
85732011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8574
8575 * xsettings.c (store_monospaced_changed): Take new font as arg and
8576 check for change against current_mono_font.
8577 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8578 (emacs_settings_constructor, emacs_settings_get_property)
8579 (emacs_settings_set_property, emacs_settings_class_init)
8580 (emacs_settings_init, gsettings_obj): Remove.
8581 (something_changedCB): New function for HAVE_GSETTINGS.
8582 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8583 with value as argument.
8584 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8585 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8586 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8587 "changed".
8588
8589 * xgselect.c: Add defined (HAVE_GSETTINGS).
8590 (xgselect_initialize): Ditto.
8591
8592 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8593 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8594 xg_select.
8595
bbc6b304
PE
85962011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8597
8598 * eval.c (struct backtrace): Simplify and port the data structure.
8599 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8600 signed bit field, as this assumption is not portable and it makes
8601 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8602 "char debug_on_exit : 1" as this is not portable either; instead,
8603 use the portable "unsigned int debug_on_exit : 1". Remove unused
8604 member evalargs. Remove obsolete comments about cc bombing out.
8605
9851bfc5
JD
86062011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8607
51bb811f 8608 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8609 Let HAVE_GSETTINGS override HAVE_GCONF.
8610 (store_monospaced_changed): New function.
8611 (EMACS_SETTINGS): A new type derived from GObject to handle
8612 GSettings notifications.
8613 (emacs_settings_constructor, emacs_settings_get_property)
8614 (emacs_settings_set_property, emacs_settings_class_init):
8615 New functions.
8616 (gsettings_client, gsettings_obj): New variables.
8617 (GSETTINGS_SCHEMA): New define.
8618 (something_changedCB): Call store_monospaced_changed.
8619 (init_gsettings): New function.
8620 (xsettings_initialize): Call init_gsettings.
8621 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8622 to NULL.
8623
640c8776 8624 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8625 GCONF_CFLAGS/LIBS.
8626
5386012d
MR
86272011-06-29 Martin Rudalics <rudalics@gmx.at>
8628
8629 * window.c (resize_root_window, grow_mini_window)
8630 (shrink_mini_window): Rename Qresize_root_window to
8631 Qwindow_resize_root_window and Qresize_root_window_vertically to
8632 Qwindow_resize_root_window_vertically.
8633
f13e0b08
PE
86342011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8635
8636 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8637
94515237
JB
86382011-06-27 Juanma Barranquero <lekktu@gmail.com>
8639
8640 * makefile.w32-in: Redesign dependencies so they reflect more
8641 clearly which files are directly included by each source file,
8642 and not through other includes.
8643
e43b6e43
MR
86442011-06-27 Martin Rudalics <rudalics@gmx.at>
8645
8646 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8647 (sort_overlays, overlay_strings): When an overlay's clone number
8648 matches the window's clone number process the overlay even if
8649 the overlay's window property doesn't match the current window.
8650
d68443dc
MR
8651 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8652 (Fwindow_hchild): Rename to Fwindow_left_child.
8653 (Fwindow_next): Rename to Fwindow_next_sibling.
8654 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8655 (resize_window_check): Rename to window_resize_check.
8656 (resize_window_apply): Rename to window_resize_apply.
8657 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8658 (Fdelete_other_windows_internal, resize_frame_windows)
8659 (Fsplit_window_internal, Fdelete_window_internal)
8660 (grow_mini_window, shrink_mini_window)
8661 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8662
c7e73be5
JD
86632011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8664
8665 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8666 (emacs_fixed_set_min_size): Remove.
8667 (emacs_fixed_new): Take frame as argument.
8668
8669 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8670 (_EmacsFixedPrivate): Remove minwidth/height.
8671 Add struct frame *f.
8672 (emacs_fixed_init): Initialize priv->f.
8673 (get_parent_class, emacs_fixed_set_min_size): Remove.
8674 (emacs_fixed_new): Set priv->f to argument.
8675 (emacs_fixed_get_preferred_width)
8676 (emacs_fixed_get_preferred_height): Use min_width/height from
8677 frames size_hint to set minimum and natural (Bug#8919).
8678 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8679 and use min_width/height from frames size_hint to set
8680 min_width/height (Bug#8919).
8681
8682 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8683 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8684 Fix indentation.
c7e73be5 8685
cf99dcf8
EZ
86862011-06-26 Eli Zaretskii <eliz@gnu.org>
8687
8688 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8689 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8690 called at ZV.
8691
029529ac
CY
86922011-06-26 Chong Yidong <cyd@stupidchicken.com>
8693
8694 * process.c (wait_reading_process_output): Bypass select if
8695 waiting for a cell while ignoring keyboard input, and input is
8696 pending. Suggested by Jan Djärv (Bug#8869).
8697
7a7ef429
PE
86982011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8699
8700 Use gnulib's dup2 module instead of rolling our own.
8701 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8702
11fdef7d 87032011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8704
8705 * dispnew.c (scrolling_window): Before scrolling, turn off a
8706 mouse-highlight in the window being scrolled.
8707
cd3520a4
JB
87082011-06-24 Juanma Barranquero <lekktu@gmail.com>
8709
8710 Move DEFSYM to lisp.h and use everywhere.
8711
8712 * character.h (DEFSYM): Move declaration...
8713 * lisp.h (DEFSYM): ...here.
8714
8715 * gnutls.c:
8716 * minibuf.c:
8717 * w32menu.c:
8718 * w32proc.c:
8719 * w32select.c: Don't include character.h.
8720
8721 * alloc.c (syms_of_alloc):
8722 * buffer.c (syms_of_buffer):
8723 * bytecode.c (syms_of_bytecode):
8724 * callint.c (syms_of_callint):
8725 * casefiddle.c (syms_of_casefiddle):
8726 * casetab.c (init_casetab_once):
8727 * category.c (init_category_once, syms_of_category):
8728 * ccl.c (syms_of_ccl):
8729 * cmds.c (syms_of_cmds):
8730 * composite.c (syms_of_composite):
8731 * dbusbind.c (syms_of_dbusbind):
8732 * dired.c (syms_of_dired):
8733 * dispnew.c (syms_of_display):
8734 * doc.c (syms_of_doc):
8735 * editfns.c (syms_of_editfns):
8736 * emacs.c (syms_of_emacs):
8737 * eval.c (syms_of_eval):
8738 * fileio.c (syms_of_fileio):
8739 * fns.c (syms_of_fns):
8740 * frame.c (syms_of_frame):
8741 * fringe.c (syms_of_fringe):
8742 * insdel.c (syms_of_insdel):
8743 * keymap.c (syms_of_keymap):
8744 * lread.c (init_obarray, syms_of_lread):
8745 * macros.c (syms_of_macros):
8746 * msdos.c (syms_of_msdos):
8747 * print.c (syms_of_print):
8748 * process.c (syms_of_process):
8749 * search.c (syms_of_search):
8750 * sound.c (syms_of_sound):
8751 * syntax.c (init_syntax_once, syms_of_syntax):
8752 * terminal.c (syms_of_terminal):
8753 * textprop.c (syms_of_textprop):
8754 * undo.c (syms_of_undo):
8755 * w32.c (globals_of_w32):
8756 * window.c (syms_of_window):
8757 * xdisp.c (syms_of_xdisp):
8758 * xfaces.c (syms_of_xfaces):
8759 * xfns.c (syms_of_xfns):
8760 * xmenu.c (syms_of_xmenu):
8761 * xsettings.c (syms_of_xsettings):
8762 * xterm.c (syms_of_xterm): Use DEFSYM.
8763
4228cf16
TZ
87642011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8765
cd3520a4 8766 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8767
7fcccf1e
PE
87682011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8769
7efb4e0e
PE
8770 Integer and buffer overflow fixes (Bug#8873).
8771
ff5844ad
PE
8772 * print.c (printchar, strout): Check for string overflow.
8773 (PRINTPREPARE, printchar, strout):
8774 Don't set size unless allocation succeeds.
8775
90532f02
PE
8776 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8777 for sizes. Check for string overflow more accurately.
8778 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8779
6d84508d
PE
8780 * macros.c: Integer and buffer overflow fixes.
8781 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8782 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8783 Use ptrdiff_t, not int, for sizes.
8784 Don't increment bufsize until after realloc succeeds.
8785 Check for size-calculation overflow.
8786 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8787
437b2cb4
PE
8788 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8789
8b9ac8b4
PE
8790 * lread.c: Integer overflow fixes.
8791 (read_integer): Radix is now EMACS_INT, not int,
8792 to improve quality of diagnostics for out-of-range radices.
8793 Calculate buffer size correctly for out-of-range radices.
8794 (read1): Check for integer overflow in radices, and in
8795 read-circle numbers.
82cb60d3
PE
8796 (read_escape): Avoid int overflow.
8797 (Fload, openp, read_buffer_size, read1)
8798 (substitute_object_recurse, read_vector, read_list, map_obarray):
8799 Use ptrdiff_t, not int, for sizes.
8800 (read1): Use EMACS_INT, not int, for sizes.
20270765 8801 Check for size overflow.
8b9ac8b4 8802
7fcccf1e
PE
8803 * image.c (cache_image): Check for size arithmetic overflow.
8804
bfbbd7e7
PE
8805 * lread.c: Integer overflow issues.
8806 (saved_doc_string_size, saved_doc_string_length)
8807 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8808 Now ptrdiff_t, not int.
8809 (read1): Don't assume doc string length fits in int. Check for
8810 out-of-range doc string lengths.
8811 (read_list): Don't assume file position fits in int.
39019e54 8812 (read_escape): Check for hex character overflow.
bfbbd7e7 8813
4e323265
LL
88142011-06-22 Leo Liu <sdl.web@gmail.com>
8815
8816 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8817 Move to minibuffer.el.
8818
85fece3e
PE
88192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8820
20b84ce9 8821 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8822 The following patches are for when GLYPH_DEBUG && !XASSERT.
8823 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8824 * dispnew.c (flush_stdout):
8825 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8826 Mark as externally visible.
8827 * dispnew.c (check_window_matrix_pointers): Now static.
8828 * dispnew.c (window_to_frame_vpos):
8829 * xfns.c (unwind_create_frame):
8830 * xterm.c (x_check_font): Remove unused local.
8831 * scroll.c (CHECK_BOUNDS):
8832 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8833 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8834 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8835 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8836 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8837 Now static.
8838 (debug_method_add): Use va_list and vsprintf rather than relying
8839 on undefined behavior with wrong number of arguments.
8840 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8841 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8842 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8843 since we're not interested in debugging glyphs with old libraries.
8844 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8845 GCC 4.6.0's static checking.
8846
0766b489
PE
88472011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8848
31fd4b32
PE
8849 Integer overflow and signedness fixes (Bug#8873).
8850 A few related buffer overrun fixes, too.
8851
b79e8648
PE
8852 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8853
0766b489
PE
8854 * dispextern.h (struct face.stipple):
8855 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8856 (x_bitmap_mask, x_allocate_bitmap_record)
8857 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8858 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8859 (x_create_bitmap_from_xpm_data):
8860 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8861 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8862 (.bitmaps_last):
8863 * xfaces.c (load_pixmap):
8864 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8865 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8866 (.bitmaps_last, struct x_output.icon_bitmap):
8867 Use ptrdiff_t, not int, for bitmap indexes.
8868 (x_allocate_bitmap_record): Check for size overflow.
8869 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8870
b081724f
PE
8871 Use ptrdiff_t, not int, for overlay counts.
8872 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8873 * editfns.c (overlays_around, get_pos_property):
8874 * textprop.c (get_char_property_and_overlay):
8875 * xdisp.c (next_overlay_change, note_mouse_highlight):
8876 * xfaces.c (face_at_buffer_position):
21514da7
PE
8877 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8878 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8879 (Fnext_overlay_change, Fprevious_overlay_change)
8880 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8881 Use ptrdiff_t, not int, for sizes.
21514da7 8882 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8883
3de73e5e
PE
8884 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8885
2606c57b
PE
8886 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8887 (x_session_initialize): Do not assume string length fits in int.
8888
aaafe47a
PE
8889 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8890 This is unlikely, but can occur if DPI is outlandish.
8891
2674ddc8 8892 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8893 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8894
28154962
PE
8895 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8896 * xrdb.c (magic_file_p, search_magic_path):
8897 Omit last arg SUFFIX; it was always 0. All callers changed.
8898 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8899
7de51af5
PE
8900 * xfont.c (xfont_match): Avoid need for strlen.
8901
25ed6cc3
PE
8902 * xfns.c: Don't assume strlen fits in int.
8903 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8904
4eab31dd
PE
8905 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8906 not unsigned long, as we prefer signed integers. All callers changed.
8907 Detect integer overflow in repeat count.
8908 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8909 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8910
171e2a58
PE
8911 * termcap.c: Don't assume sizes fit in int and never overflow.
8912 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8913 (gobble_line): Check for size-calculation overflow.
8914
ad39faca 8915 * minibuf.c (Fread_buffer):
6e5bb2dc 8916 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8917 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8918 Don't assume string length fits in int.
8919
52c61c22 8920 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8921 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8922
b5b8c9e5
PE
8923 * font.c: Don't assume string length fits in int.
8924 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8925 Use ptrdiff_t, not int.
ccd6111c
PE
8926 (font_intern_prop): Don't assume string length fits in int.
8927 Don't assume integer property fits in fixnum.
8928 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8929
882f0d81 8930 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8931 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8932 Reformulate so as not to need the command string.
8933 Invoke gzip -cd rather than gunzip, as it's more portable.
8934 (lock_info_type, lock_file_1, lock_file):
8935 Don't assume pid_t and time_t fit in unsigned long.
8936 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8937 (current_lock_owner): Prefer signed type for sizes.
8938 Use memcpy, not strncpy, where memcpy is what is really wanted.
8939 Don't assume (via atoi) that time_t and pid_t fit in int.
8940 Check for time_t and/or pid_t out of range, e.g., via a network share.
8941 Don't alloca where an auto var works fine.
8942
93f4cf88
PE
8943 * fileio.c: Fix some integer overflow issues.
8944 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8945 Don't assume string length fits in int.
8946 (directory_file_name): Don't assume string length fits in long.
8947 (make_temp_name): Don't assume pid fits in int, or that its print
8948 length is less than 20.
8949
f3e92b69
PE
8950 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8951
1bfdaf10
PE
8952 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8953
35016e9a
PE
8954 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8955
3d1e65a1
PE
8956 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8957 We prefer signed integers, even for size calculations.
8958
0b963a93
PE
8959 * emacs.c: Don't assume string length fits in 'int'.
8960 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8961 (main): Don't invoke strlen when not needed.
8962
573f4b54
PE
8963 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8964 (XD_DEBUG_MESSAGE): Don't waste a byte.
8965
989f33ba
PE
8966 * callproc.c (getenv_internal_1, getenv_internal)
8967 (Fgetenv_internal):
965d34eb
PE
8968 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8969
e4d29b33
PE
8970 * lread.c (invalid_syntax): Omit length argument.
8971 All uses changed. This doesn't fix a bug, but it simplifies the
8972 code away from its former Hollerith-constant appearance, and it's
8973 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8974 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8975
eb49b136
PE
8976 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8977 This didn't break anything, but it didn't help either.
8978 It's confusing to put a bogus integer in a place where the actual
8979 value does not matter.
9f62aeb1 8980 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8981 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8982
15375a22
PE
8983 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8984 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8985 implementation.
b61cc01c
PE
8986 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8987 We prefer signed types, and the value cannot exceed the EMACS_INT
8988 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8989 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8990 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8991 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8992
53b2623d
PE
8993 * indent.c (sane_tab_width): New function.
8994 (current_column, scan_for_column, Findent_to, position_indentation)
8995 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8996 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8997
51cab52b 8998 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8999
f2ed8a70
PE
9000 * lisp.h (lint_assume): New macro.
9001 * composite.c (composition_gstring_put_cache):
9002 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9003
abe80cc6
PE
9004 * editfns.c, insdel.c:
9005 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9006
b02c740e
PE
9007 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9008
ebc96716
PE
9009 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9010
b4e50fa0 9011 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9012 Use much-faster test for byte-length change.
311d5d7c 9013 Don't assume string byte-length fits in 'int'.
a4cf38e4 9014 Check that character arg fits in 'int'.
85461888 9015 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9016
c0c1ee9f
PE
9017 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9018
a498d7f4
PE
9019 * fns.c (concat): Catch string overflow earlier.
9020 Do not rely on integer wraparound.
9021
51cab52b
PE
9022 * dispextern.h (struct it.overlay_strings_charpos)
9023 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9024 * xdisp.c (forward_to_next_line_start)
9025 (back_to_previous_visible_line_start)
9026 (reseat_at_next_visible_line_start, next_element_from_buffer):
9027 Don't arbitrarily truncate the value of 'selective' to int.
9028
76031fad
PE
9029 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9030
5eb55db9
PE
9031 * composite.c: Don't truncate sizes to 'int'.
9032 (composition_gstring_p, composition_reseat_it)
9033 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9034 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9035 not EMACS_UINT, for indexes.
5eb55db9 9036
0703a717
PE
9037 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9038
d6202519
PE
9039 * buffer.c: Include <verify.h>.
9040 (struct sortvec.priority, struct sortstr.priority):
8961a454 9041 Now EMACS_INT, not int.
c20998a7 9042 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9043 (struct sortstr.size, record_overlay_string)
9044 (struct sortstrlist.size, struct sortlist.used):
9045 Don't truncate size to int.
9046 (record_overlay_string): Check for size-calculation overflow.
d6202519 9047 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9048
d5a19415
JM
90492011-06-22 Jim Meyering <meyering@redhat.com>
9050
029529ac 9051 Don't leak an XBM-image-sized buffer
d5a19415
JM
9052 * image.c (xbm_load): Free the image buffer after using it.
9053
a9041e6c
PE
90542011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9055
9056 Port to Sun C.
9057 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9058 that Sun C diagnosed.
9059 * fns.c (secure_hash): Fix pointer signedness issue.
9060 * intervals.c (static_offset_intervals): New function.
9061 (offset_intervals): Use it.
9062
7f3f739f
LL
90632011-06-21 Leo Liu <sdl.web@gmail.com>
9064
9065 * deps.mk (fns.o):
9066 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9067 sha512.h.
9068
9069 * fns.c (secure_hash): Rename from crypto_hash_function and change
9070 the first arg to accept symbols.
5b66d427 9071 (Fsecure_hash): New primitive.
7f3f739f
LL
9072 (syms_of_fns): New symbols.
9073
76147d94
DD
90742011-06-20 Deniz Dogan <deniz@dogan.se>
9075
9076 * process.c (Fset_process_buffer): Clarify return value in
9077 docstring.
9078
7d7d0045
CY
90792011-06-18 Chong Yidong <cyd@stupidchicken.com>
9080
9081 * dispnew.c (add_window_display_history): Use BVAR.
9082
9083 * xdisp.c (debug_method_add): Use BVAR.
9084 (check_window_end, dump_glyph_matrix, dump_glyph)
9085 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9086
9087 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9088 Likewise.
9089
9090 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9091 check till after the cache is created in init_frame_faces.
9092
ff2bc410
SM
90932011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9094
9095 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9096
28177add
PE
90972011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9098
dd3482fe
PE
9099 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9100 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9101 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9102
393d71f3 9103 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9104 * fileio.c (Finsert_file_contents):
9105 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9106 Remove the old (too-loose) buffer overflow checks.
9107 They weren't needed, since make_gap checks for buffer overflow.
9108 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9109 The old code merely checked for Emacs fixnum overflow, and relied
9110 on undefined (wraparound) behavior. The new code avoids undefined
9111 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9112
2e6813b0 9113 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9114 Tune. Don't use wider integers than needed. Don't use alloca.
9115 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9116
599a9e4f
PE
9117 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9118
99561444
PE
9119 * insdel.c, lisp.h (buffer_overflow): New function.
9120 (insert_from_buffer_1, replace_range, replace_range_2):
9121 * insdel.c (make_gap_larger):
9122 * editfns.c (Finsert_char):
9123 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9124
28177add
PE
9125 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9126
e69dafad
PE
91272011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9128
4baa020d 9129 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9130
b1c46f02
PE
9131 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9132 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9133
e69dafad
PE
9134 * fileio.c: Don't assume EMACS_INT fits in off_t.
9135 (emacs_lseek): New static function.
9136 (Finsert_file_contents, Fwrite_region): Use it.
9137 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9138
566684ea
PE
9139 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9140
e6966cd6
PE
9141 * fns.c: Don't overflow int when computing a list length.
9142 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9143 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9144 truncation on 64-bit hosts. Check for QUIT every
9145 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9146 faster and is responsive enough.
9147 (Flength): Report an error instead of overflowing an integer.
9148 (Fsafe_length): Return a float if the value is not representable
9149 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9150 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9151 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9152
dd0b0efb
PE
9153 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9154 (header_size, word_size): New constants.
9155 (allocate_vectorlike): Don't check size overflow here.
9156 (allocate_vector): Check it here instead, since this is the only
9157 caller of allocate_vectorlike that could cause overflow.
9158 Check that the new vector's length is representable as a fixnum.
9159
86fe5cfe
PE
9160 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9161 The previous code was bogus. For example, next_almost_prime (32)
9162 returned 39, which is undesirable as it is a multiple of 3; and
9163 next_almost_prime (24) returned 25, which is a multiple of 5 so
9164 why was the code bothering to check for multiples of 7?
9165
80e88859
PE
9166 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9167
4a2f0ad6
PE
9168 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9169
f66c7cf8
PE
9170 Variadic C functions now count arguments with ptrdiff_t.
9171 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9172 Back then I didn't know that the Emacs coding style prefers signed int.
9173 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9174 were being counted with int, which may truncate counts on 64-bit
9175 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9176 * lisp.h (struct Lisp_Subr.function.aMANY)
9177 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9178 Arg counts are now ptrdiff_t, not size_t.
9179 All variadic functions and their callers changed accordingly.
9180 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9181 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9182 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9183 * callint.c (Fcall_interactively): Check arg count for overflow,
9184 to avoid potential buffer overrun. Use signed char, not 'int',
9185 for 'varies' array, so that we needn't bother to check its size
9186 calculation for overflow.
9187 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9188 * eval.c (apply_lambda):
9189 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9190 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9191 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9192
a1759b76
PE
9193 * callint.c (Fcall_interactively): Don't use index var as event count.
9194
d96be9fc
PE
9195 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9196 * mem-limits.h (SIZE): Remove; no longer used.
9197
a690a978 9198 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9199
578c21e6
PE
9200 Remove unnecessary casts.
9201 * xterm.c (x_term_init):
9202 * xfns.c (x_set_border_pixel):
9203 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9204 These aren't needed now that we assume ANSI C.
9205
96f53c6c
PE
9206 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9207 It's more likely to cause problems (due to unsigned overflow)
9208 than to cure them.
9209
83c77d31
PE
9210 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9211
ee2079f1
PE
9212 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9213
6da65536
PE
9214 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9215
7147c4a4
PE
9216 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9217
193e32d9
PE
9218 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9219
e5533da6
PE
9220 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9221
9910e595
PE
9222 GLYPH_CODE_FACE returns EMACS_INT, not int.
9223 * dispextern.h (merge_faces):
9224 * xfaces.c (merge_faces):
01103c44
PE
9225 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9226 Don't assume EMACS_INT fits in int.
9910e595 9227
2638320e
PE
9228 * character.h (CHAR_VALID_P): Remove unused parameter.
9229 * fontset.c, lisp.h, xdisp.c: All uses changed.
9230
045eb8d9
PE
9231 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9232
c1f134b5
PE
9233 * fns.c (concat): Minor tuning based on overflow analysis.
9234 This doesn't fix any bugs. Use int to hold character, instead
9235 of constantly refetching from Emacs object. Use XFASTINT, not
9236 XINT, for value known to be a character. Don't bother comparing
9237 a single byte to 0400, as it's always less.
9238
395fcb93 9239 * floatfns.c (Fexpt):
327eeec8
PE
9240 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9241
abbd3d23
PE
9242 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9243 for characters.
9244
684a03ef
PE
9245 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9246
0fed43f3
PE
9247 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9248 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9249 incorrectly succeed when S was a string, because 4294967386 was
9250 truncated before it was used.
9251
8fd02eb7
PE
9252 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9253 Otherwise, an out-of-range integer could cause undefined behavior
9254 on a 64-bit host.
9255
f8c86b69
PE
9256 * composite.c: Use int, not EMACS_INT, for characters.
9257 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9258 EMACS_INT, for values that are known to be in character range.
9259 This doesn't fix any bugs but is the usual style inside Emacs and
9260 may generate better code on 32-bit machines.
9261
34206dd2
PE
9262 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9263 This is for reasons similar to the recent CHAR_STRING fix.
9264 * charset.c (Fencode_char): Check that character arg is actually
9265 a character. Pass an int to ENCODE_CHAR.
9266 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9267 wider than 'int', as a compile-time check to prevent future regressions
9268 in this area.
9269
c5958d4c 9270 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9271
9272 Make sure a 64-bit char is never passed to CHAR_STRING.
9273 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9274 by silently ignoring the top 32 bits, allowing some values
9275 that were far too large to be valid characters.
9276 * character.h: Include <verify.h>.
9277 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9278 arguments are no wider than unsigned, as a compile-time check
9279 to prevent future regressions in this area.
9280 * data.c (Faset):
01103c44 9281 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9282 (Fsubst_char_in_region):
9283 * fns.c (concat):
9284 * xdisp.c (decode_mode_spec_coding):
9285 Adjust to CHAR_STRING's new requirement.
9286 * editfns.c (Finsert_char, Fsubst_char_in_region):
9287 * fns.c (concat): Check that character args are actually
9288 characters. Without this test, these functions did the wrong
9289 thing with wildly out-of-range values on 64-bit hosts.
9290
d37ca623
PE
9291 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9292 These casts should not be needed on 32-bit hosts, either.
9293 * keyboard.c (read_char):
9294 * lread.c (Fload): Remove casts to unsigned.
9295
ea204efb
PE
9296 * lisp.h (UNSIGNED_CMP): New macro.
9297 This fixes comparison bugs on 64-bit hosts.
9298 (ASCII_CHAR_P): Use it.
9299 * casefiddle.c (casify_object):
01103c44 9300 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9301 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9302 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9303 * dispextern.h (FACE_FROM_ID):
9304 * keyboard.c (read_char): Use UNSIGNED_CMP.
9305
41cb286c
PE
9306 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9307 not to EMACS_INT, to avoid GCC warning.
9308
4a1b9832
PE
9309 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9310
55daad71
PE
9311 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9312 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9313 isn't needed on 32-bit machines.
8f95c75c 9314
01103c44
PE
9315 * buffer.c (Fgenerate_new_buffer_name):
9316 Use EMACS_INT for count, not int.
0ceccced 9317 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9318
9319 * data.c (Qcompiled_function): Now static.
9320
c6f072e7
PE
9321 * window.c (window_body_lines): Now static.
9322
20ce5912
PE
9323 * image.c (gif_load): Rename local to avoid shadowing.
9324
9c4c5f81
PE
9325 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9326 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9327 * alloc.c (make_save_value): Integer argument is now of type
9328 ptrdiff_t, not int.
9329 (mark_object): Use ptrdiff_t, not int.
9330 * lisp.h (pD): New macro.
9331 * print.c (print_object): Use it.
9332
c0c5c8ae
PE
9333 * alloc.c: Use EMACS_INT, not int, to count objects.
9334 (total_conses, total_markers, total_symbols, total_vector_size)
9335 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9336 (total_free_floats, total_floats, total_free_intervals)
9337 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9338 Now EMACS_INT, not int. All uses changed.
9339 (Fgarbage_collect): Compute overall total using a double, so that
9340 integer overflow is less likely to be a problem. Check for overflow
9341 when converting back to an integer.
5a25e253
PE
9342 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9343 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9344 These were 'int' variables that could overflow on 64-bit hosts;
9345 they were never used, so remove them instead of repairing them.
211a0b2a 9346 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9347 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9348 Previously, this ceilinged at INT_MAX, but that doesn't work on
9349 64-bit machines.
e46bb31a 9350 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9351
c78baabf 9352 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9353 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9354 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9355 when a (possibly-narrower) signed value would do just as well.
9356 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9357
c9d624c6
PE
9358 * alloc.c: Catch some string size overflows that we were missing.
9359 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9360 for convenience in STRING_BYTES_MAX.
9361 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9362 The definition here is exact; the one in lisp.h was approximate.
9363 (allocate_string_data): Check for string overflow. This catches
9364 some instances we weren't catching before. Also, it catches
9365 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9366 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9367 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9368
c9d624c6
PE
9369 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9370 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9371 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9372
353032ce
PE
9373 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9374
2bccce07
PE
9375 * alloc.c (Fmake_string): Check for out-of-range init.
9376
0ac30604
SM
93772011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9378
9379 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9380
c195f2de
JD
93812011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9382
9383 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9384 xg_get_default_scrollbar_width.
9385
9386 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9387 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9388 (style_changed_cb): Call update_theme_scrollbar_width and call
9389 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9390 all frames (Bug#8505).
9391 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9392 Call gtk_window_set_resizable if HAVE_GTK3.
9393 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9394 and height if HAVE_GTK3 (Bug#8505).
9395 (scroll_bar_width_for_theme): New variable.
9396 (update_theme_scrollbar_width): New function.
9397 (xg_get_default_scrollbar_width): Move code to
9398 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9399 (xg_initialize): Call update_theme_scrollbar_width.
9400
9401 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9402
9403 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9404
e10ac9f1
MR
94052011-06-12 Martin Rudalics <rudalics@gmx.at>
9406
9407 * frame.c (make_frame): Call other_buffer_safely instead of
9408 other_buffer.
9409
9410 * window.c (temp_output_buffer_show): Call display_buffer with
9411 second argument Vtemp_buffer_show_specifiers and reset latter
9412 immediately after the call.
9413 (Vtemp_buffer_show_specifiers): New variable.
9414 (auto_window_vscroll_p, next_screen_context_lines)
9415 (Vscroll_preserve_screen_position): Remove leading asterisks from
9416 doc-strings.
9417
2d3c217e 94182011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9419
7b7f97e8 9420 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9421 * buffer.c (Qclone_number): Remove for now, as it's unused.
9422 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9423 (record_buffer): Remove unused local.
9424 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9425 (set_frame_buffer_list): Remove; unused.
9426 * frame.h (other_visible_frames): Remove decl.
9427 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9428 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9429 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9430 if HAVE_GPM.
9431 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9432 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9433 Define only if HAVE_GPM.
9434 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9435 (update_hints_inhibit): Remove; never set. All uses removed.
9436 * widgetprv.h (emacsFrameClassRec): Remove decl.
9437 * window.c (delete_deletable_window): Now returns void, since it
9438 wasn't returning anything.
9439 (compare_window_configurations): Remove unused locals.
9440 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9441 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9442 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9443 the same widths as pointers. This follows up on the 2011-05-06 patch.
9444 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9445 * xterm.h: Likewise.
9446 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9447
1384b89e
JB
94482011-06-12 Juanma Barranquero <lekktu@gmail.com>
9449
9450 * makefile.w32-in: Update dependencies.
9451 (LISP_H): Add lib/intprops.h.
9452
1100a63c
CY
94532011-06-11 Chong Yidong <cyd@stupidchicken.com>
9454
9455 * image.c (gif_load): Add animation frame delay to the metadata.
9456 (syms_of_image): Use DEFSYM. New symbol `delay'.
9457
6198ccd0
MR
94582011-06-11 Martin Rudalics <rudalics@gmx.at>
9459
9460 * window.c (delete_deletable_window): Re-add.
9461 (Fset_window_configuration): Rewrite to handle dead buffers and
9462 consequently deletable windows.
9463 (window_tree, Fwindow_tree): Remove. Supply functionality in
9464 window.el.
9465 (compare_window_configurations): Simplify code.
9466
b6e3633c
AS
94672011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9468
1ab0dee5
AS
9469 * image.c (imagemagick_load_image): Fix type mismatch.
9470 (Fimagemagick_types): Likewise.
9471
b6e3633c
AS
9472 * window.h (replace_buffer_in_windows): Declare.
9473
9397e56f
MR
94742011-06-11 Martin Rudalics <rudalics@gmx.at>
9475
9476 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9477 Qclone_number. Remove external declaration of Qdelete_window.
9478 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9479 code.
640c8776
SM
9480 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9481 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9482 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9483 buffer list implementation.
9484 (other_buffer_safely): New function.
9485 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9486 calls to replace_buffer_in_windows and
9487 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9488 if allowed.
9489 (record_buffer): Inhibit quitting and rewrite using quittable
9490 functions. Run Qbuffer_list_update_hook if allowed.
9491 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9492 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9493 Move switch-to-buffer to window.el.
9397e56f
MR
9494 (bury-buffer): Move to window.el.
9495 (Vbuffer_list_update_hook): New variable.
9496
9497 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9498 section.
9499
9500 * window.h (resize_frame_windows): Move up in code.
9501 (Fwindow_frame): Remove EXFUN.
9502 (replace_buffer_in_all_windows): Remove prototype.
9503 (replace_buffer_in_windows_safely): Add prototype.
9504
9505 * window.c: Declare Qdelete_window static again. Move down
9506 declaration of select_count.
9507 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9508 (Fother_window): Move to window.el.
9509 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9510 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9511 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9512 window.el.
9513 (replace_buffer_in_windows): Implement by calling
9514 Qreplace_buffer_in_windows.
9515 (replace_buffer_in_all_windows): Remove with some functionality
9516 moved into replace_buffer_in_windows_safely.
9517 (replace_buffer_in_windows_safely): New function.
9518 (select_window_norecord, select_frame_norecord): Move in front
9519 of run_window_configuration_change_hook. Remove now obsolete
9520 declarations.
640c8776
SM
9521 (Fset_window_buffer): Rewrite doc-string.
9522 Call Qrecord_window_buffer.
9397e56f
MR
9523 (keys_of_window): Move binding for other-window to window.el.
9524
b50691aa
CY
95252011-06-11 Chong Yidong <cyd@stupidchicken.com>
9526
9527 * dispextern.h (struct image): Replace data member, whose int_val
9528 and ptr_val fields were not used by anything, with a single
9529 lisp_val object.
9530
9531 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9532 (gif_clear_image, gif_load, imagemagick_load_image)
9533 (gs_clear_image, gs_load): Callers changed.
9534
3f754b86
PE
95352011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9536
cca69397
PE
9537 * buffer.h: Include <time.h>, for time_t.
9538 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9539
109e28d0
PE
9540 Fix minor problems found by static checking.
9541
60737f02
PE
9542 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9543
4b66faf3
PE
9544 Make identifiers static if they are not used in other modules.
9545 * data.c (Qcompiled_function, Qframe, Qvector):
9546 * image.c (QimageMagick, Qsvg):
9547 * minibuf.c (Qmetadata):
9548 * window.c (resize_window_check, resize_root_window): Now static.
9549 * window.h (resize_window_check, resize_root_window): Remove decls.
9550
109e28d0
PE
9551 * window.c (window_deletion_count, delete_deletable_window):
9552 Remove; unused.
46a4ce9e
PE
9553 (window_body_lines): Now static.
9554 (Fdelete_other_windows_internal): Mark vars as initialized.
9555 Make sure 'resize_failed' is initialized.
9556 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9557 (resize_window_apply): Remove unused local.
9558 * window.h (delete_deletable_window): Remove decl.
9559
109e28d0 9560 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9561 (imagemagick_load_image): Fix pointer signedness problem by changing
9562 last arg from unsigned char * to char *. All uses changed.
9563 Also, fix a local for similar reasons.
9564 Remove unused locals. Remove locals to avoid shadowing.
9565 (fn_rsvg_handle_free): Remove; unused.
9566 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9567 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9568
3f754b86
PE
9569 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9570
2547adb1
CY
95712011-06-10 Chong Yidong <cyd@stupidchicken.com>
9572
9573 * image.c (gif_load): Fix omitted cast error introduced by
9574 2011-06-06 change.
9575
2c8e37d4
MR
95762011-06-10 Martin Rudalics <rudalics@gmx.at>
9577
9578 * window.h (resize_proportionally, orig_total_lines)
9579 (orig_top_line): Remove from window structure.
9580 (set_window_height, set_window_width, change_window_heights)
9581 (Fdelete_window): Remove prototypes.
9582 (resize_frame_windows): Remove duplicate declaration.
9583
440a42e3
EZ
95842011-06-10 Eli Zaretskii <eliz@gnu.org>
9585
9586 * window.h (resize_frame_windows, resize_window_check)
9587 (delete_deletable_window, resize_root_window)
9588 (resize_frame_windows): Declare prototypes.
9589
9590 * window.c (resize_window_apply): Make definition be "static" to
9591 match the prototype.
9592
562dd5e9
MR
95932011-06-10 Martin Rudalics <rudalics@gmx.at>
9594
9595 * window.c: Remove declarations of Qwindow_size_fixed,
9596 window_min_size_1, window_min_size_2, window_min_size,
9597 size_window, window_fixed_size_p, enlarge_window, delete_window.
9598 Remove static from declaration of Qdelete_window, it's
9599 temporarily needed by Fbury_buffer.
9600 (replace_window): Don't assign orig_top_line and
9601 orig_total_lines.
9602 (Fdelete_window, delete_window): Remove. Window deletion is
9603 handled by window.el.
640c8776
SM
9604 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9605 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9606 (Fdelete_other_windows): Remove. Deleting other windows is
9607 handled by window.el.
9608 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9609 handled in window.el.
9610 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9611 Window minimum sizes are handled in window.el.
9612 (shrink_windows, size_window, set_window_height)
9613 (set_window_width, change_window_heights, window_height)
9614 (window_width, CURBEG, CURSIZE, enlarge_window)
9615 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9616 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9617 handled in window.el.
9618 (make_dummy_parent): Rename to make_parent_window and give it a
9619 second argument horflag.
9620 (make_window): Don't set resize_proportionally any more.
9621 (Fsplit_window): Remove. Windows are split in window.el.
9622 (save_restore_action, save_restore_orig_size)
9623 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9624 Resize mini windows in window.el.
9625 (grow_mini_window, shrink_mini_window): Implement by calling
9626 Qresize_root_window_vertically, resize_window_check and
9627 resize_window_apply.
640c8776
SM
9628 (saved_window, Fset_window_configuration, save_window_save):
9629 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9630 resize_proportionally.
9631 (window_min_height, window_min_width): Move to window.el.
9632 (keys_of_window): Move bindings for delete-other-windows,
9633 split-window, delete-window and enlarge-window to window.el.
9634
9635 * buffer.c: Temporarily extern Qdelete_window.
9636 (Fbury_buffer): Temporarily call Qdelete_window instead of
9637 Fdelete_window (Fbury_buffer will move to window.el soon).
9638
9639 * frame.c (set_menu_bar_lines_1): Remove code handling
9640 orig_top_line and orig_total_lines.
9641
9642 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9643 set_window_height but set heights directly.
9644 (change_frame_size_1): Use resize_frame_windows.
9645
9646 * xdisp.c (init_xdisp): Don't use set_window_height but set
9647 heights directly.
9648
640c8776
SM
9649 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9650 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9651 run_window_configuration_change_hook.
9652
9653 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9654 instead of change_window_heights and run
9655 run_window_configuration_change_hook.
9656
1a13852e
MR
96572011-06-09 Martin Rudalics <rudalics@gmx.at>
9658
9659 * window.c (replace_window): Rename second argument REPLACEMENT to
9660 NEW. New third argument SETFLAG. Rewrite.
9661 (delete_window, make_dummy_parent): Call replace_window with
9662 third argument 1.
9663 (window_list_1): Move down in code.
9664 (run_window_configuration_change_hook): Move set_buffer part
9665 before select_frame_norecord part in order to unwind correctly.
9666 Rename count1 to count.
9667 (recombine_windows, delete_deletable_window, resize_root_window)
9668 (Fdelete_other_windows_internal)
9669 (Frun_window_configuration_change_hook, make_parent_window)
9670 (resize_window_check, resize_window_apply, Fresize_window_apply)
9671 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9672 (Fdelete_window_internal, Fresize_mini_window_internal):
9673 New functions.
1a13852e
MR
9674 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9675
f3d1777e
MR
96762011-06-08 Martin Rudalics <rudalics@gmx.at>
9677
496e208e
MR
9678 * window.h (window): Add some new members to window structure -
9679 normal_lines, normal_cols, new_total, new_normal, clone_number,
9680 splits, nest, prev_buffers, next_buffers.
9681 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9682 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9683
f3d1777e
MR
9684 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9685 Remove.
496e208e
MR
9686 (make_dummy_parent): Set new members of windows structure.
9687 (make_window): Move down in code. Handle new members of window
9688 structure.
9689 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9690 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9691 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9692 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9693 (Fset_window_next_buffers, Fset_window_clone_number):
9694 New functions.
496e208e
MR
9695 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9696 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9697 Doc-string fixes.
9698 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9699 Argument WINDOW can be now internal window too.
9700 (Fwindow_use_time): Move up in code.
9701 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9702 Rewrite doc-string.
9703 (Fset_window_configuration, saved_window)
9704 (Fcurrent_window_configuration, save_window_save): Handle new
9705 members of window structure.
b9e809c2
MR
9706 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9707 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9708 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9709 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9710 Qget_mru_window, Qresize_root_window,
9711 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9712 Qauto_buffer_name; staticpro them.
f3d1777e 9713
abde8f8c
MR
97142011-06-07 Martin Rudalics <rudalics@gmx.at>
9715
9716 * window.c (Fwindow_total_size, Fwindow_left_column)
9717 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9718 (Fwindow_list_1): New functions.
9719 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9720 (Fwindow_width, Fscroll_left, Fscroll_right):
9721 Use window_body_cols instead of window_box_text_cols.
9722 (delete_window, Fset_window_configuration):
9723 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9724 (delete_all_subwindows): Take a window as argument and not a
9725 structure. Rewrite.
190b47e6
MR
9726 (window_loop): Remove handling of GET_LRU_WINDOW and
9727 GET_LARGEST_WINDOW.
9728 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9729
9730 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9731 window_box_text_cols. delete_all_subwindows now takes a
9732 Lisp_Object as argument.
abde8f8c 9733
640c8776
SM
9734 * indent.c (compute_motion, Fcompute_motion):
9735 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9736
fa8a67e6
MR
9737 * frame.c (delete_frame): Call delete_all_subwindows with root
9738 window as argument.
9739
a54e3482
DC
97402011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9741
9742 * fns.c (Fputhash): Document return value.
9743
60002bf5
CY
97442011-06-06 Chong Yidong <cyd@stupidchicken.com>
9745
9746 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9747
0c671da6 97482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9749
b862a52a 9750 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9751
be44ca6c
PE
9752 Check for overflow when converting integer to cons and back.
9753 * charset.c (Fdefine_charset_internal, Fdecode_char):
9754 Use cons_to_unsigned to catch overflow.
9755 (Fencode_char): Use INTEGER_TO_CONS.
9756 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9757 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9758 * data.c (long_to_cons, cons_to_long): Remove.
9759 (cons_to_unsigned, cons_to_signed): New functions.
9760 These signal an error for invalid or out-of-range values.
9761 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9762 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9763 * font.c (Ffont_variation_glyphs):
9764 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9765 * lisp.h: Include <intprops.h>.
9766 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9767 (cons_to_signed, cons_to_unsigned): New decls.
9768 (long_to_cons, cons_to_long): Remove decls.
9769 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9770 (Fprimitive_undo): Use CONS_TO_INTEGER.
9771 * xfns.c (Fx_window_property): Likewise.
9772 * xselect.c: Include <limits.h>.
9773 (x_own_selection, selection_data_to_lisp_data):
9774 Use INTEGER_TO_CONS.
9775 (x_handle_selection_request, x_handle_selection_clear)
9776 (x_get_foreign_selection, Fx_disown_selection_internal)
9777 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9778 (lisp_data_to_selection_data): Use cons_to_unsigned.
9779 (x_fill_property_data): Use cons_to_signed.
9780 Report values out of range.
9781
d1f3d2af
PE
9782 Check for buffer and string overflow more precisely.
9783 * buffer.h (BUF_BYTES_MAX): New macro.
9784 * lisp.h (STRING_BYTES_MAX): New macro.
9785 * alloc.c (Fmake_string):
9786 * character.c (string_escape_byte8):
9787 * coding.c (coding_alloc_by_realloc):
9788 * doprnt.c (doprnt):
9789 * editfns.c (Fformat):
9790 * eval.c (verror):
9791 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9792 since they may not be the same number.
9793 * editfns.c (Finsert_char):
9794 * fileio.c (Finsert_file_contents):
9795 Likewise for BUF_BYTES_MAX.
9796
dd52fcea
PE
9797 * image.c: Use ptrdiff_t, not int, for sizes.
9798 (slurp_file): Switch from int to ptrdiff_t.
9799 All uses changed.
9800 (slurp_file): Check that file size fits in both size_t (for
9801 malloc) and ptrdiff_t (for sanity and safety).
9802
7f9bbdbb
PE
9803 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9804 if b->modtime has its maximal value.
9805
dfe18f82
PE
9806 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9807
84acfcf0
PE
9808 Don't assume time_t can fit into int.
9809 * buffer.h (struct buffer.modtime): Now time_t, not int.
9810 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9811 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9812
ccd9a01a
PE
9813 Minor fixes for signed vs unsigned integers.
9814 * character.h (MAYBE_UNIFY_CHAR):
9815 * charset.c (maybe_unify_char):
9816 * keyboard.c (read_char, reorder_modifiers):
9817 XINT -> XFASTINT, since the integer must be nonnegative.
9818 * ftfont.c (ftfont_spec_pattern):
9819 * keymap.c (access_keymap, silly_event_symbol_error):
9820 XUINT -> XFASTINT, since the integer must be nonnegative.
9821 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9822 since it makes no difference and we prefer signed.
9823 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9824 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9825 nonnegative.
9826
d6d100dd
SM
98272011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9828
9829 * window.h (Fwindow_frame): Declare.
9830
2b6148e4
PE
98312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9832
9833 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9834 (SPARE_MEMORY): Always define.
9835 (LARGE_REQUEST): Remove.
9836 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9837
f230ecc9
MR
98382011-06-06 Martin Rudalics <rudalics@gmx.at>
9839
727e958e
MR
9840 * lisp.h: Move EXFUNS for Fframe_root_window,
9841 Fframe_first_window and Fset_frame_selected_window to window.h.
9842
9843 * window.h: Move EXFUNS for Fframe_root_window,
9844 Fframe_first_window and Fset_frame_selected_window here from
9845 lisp.h.
9846
9847 * frame.c (Fwindow_frame, Fframe_first_window)
9848 (Fframe_root_window, Fframe_selected_window)
9849 (Fset_frame_selected_window): Move to window.c.
9850 (Factive_minibuffer_window): Move to minibuf.c.
9851 (Fother_visible_frames_p): New function.
9852
9853 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9854
f230ecc9
MR
9855 * window.c (decode_window, decode_any_window): Move up in code.
9856 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9857 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9858 (Fwindow_buffer): Move up and rewrite doc-string.
9859 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9860 (Fwindow_prev): New functions.
727e958e
MR
9861 (Fwindow_frame): Move here from frame.c. Accept any window as
9862 argument.
9863 (Fframe_root_window, Fframe_first_window)
9864 (Fframe_selected_window): Move here from frame.c. Accept frame
9865 or arbitrary window as argument. Update doc-strings.
9866 (Fminibuffer_window): Move up in code.
9867 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9868 (Fset_frame_selected_window): Move here from frame.c.
9869 Marginal rewrite.
727e958e
MR
9870 (Fselected_window, select_window, Fselect_window): Move up in
9871 code. Minor doc-string fixes.
f230ecc9 9872
4d09bcf6
PE
98732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9874
9875 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9876 Do not assume that spare memory exists; that assumption is valid
9877 only if SYSTEM_MALLOC.
9878 (LARGE_REQUEST): New macro, so that the issue of large requests
9879 is separated from the issue of spare memory.
9880
810928a2
AS
98812011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9882
172418ad
AS
9883 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9884 format. (Bug#8806)
9885
43f862f7
AS
9886 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9887
810928a2
AS
9888 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9889 before statements.
9890
a059fe24
JD
98912011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9892
9893 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9894
9895 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9896
9897 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9898 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9899
989bf368
JB
99002011-06-05 Juanma Barranquero <lekktu@gmail.com>
9901
9902 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9903
4b80f674
CY
99042011-06-04 Chong Yidong <cyd@stupidchicken.com>
9905
9906 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9907 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9908 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9909 New error handlers.
4b80f674
CY
9910 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9911 Obey Vx_select_enable_clipboard_manager. Catch errors in
9912 x_clipboard_manager_save (Bug#8779).
9913 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9914 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9915
99a33b77 99162011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9917
9918 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9919
99a33b77 99202011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9921
9922 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9923 in the current matrix if keep_current_p is non-zero.
9924
8264569d
EZ
99252011-06-04 Eli Zaretskii <eliz@gnu.org>
9926
9927 * bidi.c (bidi_level_of_next_char): Fix last change.
9928
57f97249
EZ
99292011-06-03 Eli Zaretskii <eliz@gnu.org>
9930
fec2107c 9931 Support bidi reordering of text covered by display properties.
57f97249 9932
fec2107c
EZ
9933 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9934 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9935 (bidi_cache_search, bidi_cache_iterator_state)
9936 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9937 (bidi_level_of_next_char, bidi_move_to_visually_next):
9938 Support character positions inside a run of characters covered by a
fec2107c
EZ
9939 display string.
9940 (bidi_paragraph_init, bidi_resolve_explicit_1)
9941 (bidi_level_of_next_char): Call bidi_fetch_char and
9942 bidi_fetch_char_advance instead of FETCH_CHAR and
9943 FETCH_CHAR_ADVANCE.
9944 (bidi_init_it): Initialize new members.
9945 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9946 definitions.
9947 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9948 instead of using explicit *_CHAR codes.
d6d100dd
SM
9949 (bidi_resolve_explicit, bidi_resolve_weak):
9950 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9951 bidirectional text is supported only in multibyte buffers.
9952 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9953 it to initialize the frame_window_p member of struct bidi_it.
9954 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9955 (bidi_resolve_explicit, bidi_resolve_weak)
9956 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9957 bidi_it->nchars is non-positive.
9958 (bidi_level_of_next_char): Don't try to lookup the cache for the
9959 next/previous character if nothing is cached there yet, or if we
9960 were just reseat()'ed to a new position.
c40e2fb2 9961
0e14fe90
EZ
9962 * xdisp.c (set_cursor_from_row): Set start and stop points
9963 according to the row's direction when priming the loop that looks
9964 for the glyph on which to display cursor.
9965 (single_display_spec_intangible_p): Function deleted.
9966 (display_prop_intangible_p): Reimplement to call
9967 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9968 Accept 3 additional arguments needed by handle_display_spec.
9969 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9970 values: lists, `(when COND...)' forms, etc.
9971 (single_display_spec_string_p): Support property values that are
9972 lists with the argument STRING its top-level element.
9973 (display_prop_string_p): Fix the condition for processing a
9974 property that is a list to be consistent with handle_display_spec.
fec2107c 9975 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9976 last portion of handle_display_prop.
9977 (compute_display_string_pos): Accept additional argument
9978 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9979 value of a `display' property is a "replacing spec".
9980 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9981 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9982 the display property, but just return a value indicating whether
9983 the display property will replace the characters it covers.
9984 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9985 frame_window_p members of struct bidi_it.
d6d100dd
SM
9986 (compute_display_string_pos, compute_display_string_end):
9987 New functions.
fec2107c
EZ
9988 (push_it): Accept second argument POSITION, where pop_it should
9989 jump to continue iteration.
9990 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9991
fec2107c
EZ
9992 * keyboard.c (adjust_point_for_property): Adjust the call to
9993 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9994
9995 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9996 (bidi_init_it): Update prototypes.
9997 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9998 (compute_display_string_pos, compute_display_string_end):
9999 Declare prototypes.
fec2107c
EZ
10000 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10001 EMACS_INT.
fc6f18ce 10002
40087514 100032011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10004
57f53182
PE
10005 Malloc failure behavior now depends on size of allocation.
10006 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10007 * lisp.h: Change signatures accordingly.
10008 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10009 All callers changed. (Bug#8762)
10010
10011 * gnutls.c: Use Emacs's memory allocators.
10012 Without this change, the gnutls library would invoke malloc etc.
10013 directly, which causes problems on non-SYNC_INPUT hosts, and which
10014 runs afoul of improving memory_full behavior. (Bug#8761)
10015 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10016 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10017 xfree instead of the default malloc, realloc, free.
10018 (Fgnutls_boot): No need to check for memory allocation failure,
10019 since xmalloc does that for us.
10020
ac32cd99 10021 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10022 * category.c (hash_get_category_set):
10023 * ccl.c (ccl_driver):
10024 * charset.c (Fdefine_charset_internal):
10025 * charset.h (struct charset.hash_index):
10026 * composite.c (get_composition_id, gstring_lookup_cache)
10027 (composition_gstring_put_cache):
10028 * composite.h (struct composition.hash_index):
10029 * dispextern.h (struct image.hash):
10030 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10031 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10032 (hashfn_equal, hashfn_user_defined, make_hash_table)
10033 (maybe_resize_hash_table, hash_lookup, hash_put)
10034 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10035 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10036 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10037 * image.c (make_image, search_image_cache, lookup_image)
10038 (xpm_put_color_table_h):
10039 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10040 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10041 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10042 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10043 * alloc.c (allocate_vectorlike):
10044 Check for overflow in vector size calculations.
10045 * ccl.c (ccl_driver):
10046 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10047 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10048 need to be updated by these changes.
40087514
PE
10049 * fns.c (make_hash_table, maybe_resize_hash_table):
10050 Check for integer overflow with large hash tables.
0de4bb68
PE
10051 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10052 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10053 (SXHASH_REDUCE): New macro.
10054 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10055 Use it instead of discarding useful hash info with large hash values.
10056 (sxhash_float): New function.
10057 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10058 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10059 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10060 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10061 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10062 Adjust signatures to match updated version of code.
10063 (consing_since_gc): Now EMACS_INT, since a single hash table can
10064 use more than INT_MAX bytes.
10065
698d32e2
DN
100662011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10067
10068 Make it possible to build with GCC-4.6+ -O2 -flto.
10069
10070 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10071
fd6fa53f
SM
100722011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10073
10074 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10075 Call minibuffer-inactive-mode.
10076
864db017
JB
100772011-05-31 Juanma Barranquero <lekktu@gmail.com>
10078
10079 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10080 Update dependencies.
10081
2ad0baf4
DN
100822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10083
10084 * data.c (init_data): Remove code for UTS, this system is not
10085 supported anymore.
10086
4fcc2638
DN
100872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10088
10089 Don't force ./temacs to start in terminal mode.
10090
10091 * frame.c (make_initial_frame): Initialize faces in all cases, not
10092 only when CANNOT_DUMP is defined.
10093 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10094
c56e0fd5
DN
100952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10096
10097 * dispnew.c (add_window_display_history): Use const for the string
10098 pointer. Remove declaration, not needed.
10099
333d54da 101002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10101
55d4c1b2 10102 Use 'inline', not 'INLINE'.
333d54da 10103 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10104 * alloc.c, fontset.c (INLINE): Remove.
10105 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10106 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10107 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10108 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10109 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10110
738db178
DN
101112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10112
10113 Make it possible to run ./temacs.
10114
10115 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10116 syms_of_callproc does the same thing. Remove test for
10117 "initialized", do it in the caller.
10118 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10119
620c53a6
SM
101202011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10121
10122 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10123 (read_minibuf): Use get_minibuffer.
10124 (syms_of_minibuf): Use DEFSYM.
10125 (Qmetadata): New var.
10126 * data.c (Qbuffer): Don't make it static.
10127 (syms_of_data): Use DEFSYM.
10128
e003a292
PE
101292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10130
10131 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10132 (CCL_CODE_MIN): New macro.
10133
ed008a6d
PE
101342011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10135
3687c2ef
PE
10136 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10137
ed008a6d
PE
10138 * eval.c (Qdebug): Now static.
10139 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10140 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10141 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10142
d66c4c7c
CY
101432011-05-29 Chong Yidong <cyd@stupidchicken.com>
10144
10145 * image.c: Various fixes to ImageMagick code comments.
10146 (Fimagemagick_types): Doc fix.
10147
5fbc2025
PE
101482011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10149
0196f88a
PE
10150 Minor fixes prompted by GCC 4.6.0 warnings.
10151
10152 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10153
5fbc2025
PE
10154 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10155 (x_clipboard_manager_save_all): Move extern decl to ...
10156 * xterm.h: ... here, so that it can be checked for consistency.
10157
1dd3c2d9
CY
101582011-05-29 Chong Yidong <cyd@stupidchicken.com>
10159
10160 * xselect.c (x_clipboard_manager_save_frame)
10161 (x_clipboard_manager_save_all): New functions.
10162 (Fx_clipboard_manager_save): Lisp function deleted.
10163
10164 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10165 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10166
10167 * xterm.h: Update prototype.
10168
5ba6571d
WX
101692011-05-28 William Xu <william.xwl@gmail.com>
10170
10171 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10172 exiting (Bug#8239).
10173
3eaff834
JM
101742011-05-28 Jim Meyering <meyering@redhat.com>
10175
e1900994 10176 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10177 * fns.c (to_uchar): Define.
10178 (crypto_hash_function): Use it to convert some newly-signed
10179 variables to unsigned, to avoid sign-extension bugs. For example,
10180 without this change, (md5 "truc") would evaluate to
10181 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10182 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10183 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10184
0f6990a7
PE
101852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10186
10187 Integer overflow fixes.
c8a9ca5a 10188
08686060
PE
10189 * dbusbind.c: Serial number integer overflow fixes.
10190 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10191 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10192 to hold a serial number that is too large for a fixnum.
10193 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10194 Check for serial numbers out of range. Decode any serial number
59568bf0 10195 that was so large that it became a float. (Bug#8722)
08686060 10196
2d1fc3c7
PE
10197 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10198 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10199 Use XFASTINT rather than XUINT when numbers are nonnegative.
10200 (xd_append_arg, Fdbus_method_return_internal):
10201 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10202 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10203 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10204 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10205 (Bug#8722)
2d1fc3c7 10206
c8a9ca5a
PE
10207 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10208
519e1d69
PE
10209 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10210
6df6ae42 10211 ccl: Add integer overflow checks.
30569699
PE
10212 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10213 (IN_INT_RANGE): New macros.
10214 (ccl_driver): Use them to check for integer overflow when
10215 decoding a CCL program. Many of the new checks are whether XINT (x)
10216 fits in int; it doesn't always, on 64-bit hosts. The new version
10217 doesn't catch all possible integer overflows, but it's an
847044ea 10218 improvement. (Bug#8719)
30569699 10219
c11285dc
PE
10220 * alloc.c (make_event_array): Use XINT, not XUINT.
10221 There's no need for unsigned here.
10222
fdccd48e
PE
10223 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10224 This follows up to the 2011-05-06 change that substituted uintptr_t
10225 for EMACS_INT. This case wasn't caught back then.
10226
37910ab2
PE
10227 Rework Fformat to avoid integer overflow issues.
10228 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10229 now (part of C89). Include <verify.h>.
10230 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10231 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10232 (Fformat): Avoid the prepass trying to compute sizes; it was only
10233 approximate and thus did not catch overflow reliably. Instead, walk
10234 through the format just once, formatting and computing sizes as we go,
10235 checking for integer overflow at every step, and allocating a larger
10236 buffer as needed. Keep track separately whether the format is
10237 multibyte. Keep only the most-recently calculated precision, rather
10238 than them all. Record whether each argument has been converted to
10239 string. Use EMACS_INT, not int, for byte and char and arg counts.
10240 Support field widths and precisions larger than INT_MAX. Avoid
10241 sprintf's undefined behavior with conversion specifications such as %#d
10242 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10243 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10244 formatting out-of-range floating point numbers with int
9173deec 10245 formats. (Bug#8668)
37910ab2 10246
2e6578fb
PE
10247 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10248
0ae6bdee
PE
10249 * data.c: Avoid integer truncation in expressions involving floats.
10250 * data.c: Include <intprops.h>.
10251 (arith_driver): When there's an integer overflow in an expression
10252 involving floating point, convert the integers to floating point
10253 so that the resulting value does not suffer from catastrophic
10254 integer truncation. For example, on a 64-bit host (* 4
10255 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10256 Do not rely on undefined behavior after integer overflow.
10257
de883a70
PE
10258 merge count_size_as_multibyte, parse_str_to_multibyte
10259 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10260 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10261 Check for integer overflow.
10262 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10263 since it's now a duplicate of the other. This is more of
10264 a character than a buffer op, so better that it's in character.c.
10265 * fns.c, print.c: Adjust to above changes.
10266
2ff916cb
PE
102672011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10268
10269 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10270
f1b54466
PE
102712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10272
fb1ac845
PE
10273 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10274 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10275 (x_clipboard_manager_save): Now static.
10276 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10277
f1b54466
PE
10278 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10279 (crypto_hash_function): Now static.
10280 Fix pointer signedness problems. Avoid unnecessary initializations.
10281
a9f737ee
CY
102822011-05-27 Chong Yidong <cyd@stupidchicken.com>
10283
10284 * termhooks.h (Vselection_alist): Make it terminal-local.
10285
10286 * terminal.c (create_terminal): Initialize it.
10287
10288 * xselect.c: Support for clipboard managers.
10289 (Vselection_alist): Move to termhooks.h as terminal-local var.
10290 (LOCAL_SELECTION): New macro.
10291 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10292 (symbol_to_x_atom): Remove gratuitous arg.
10293 (x_handle_selection_request, lisp_data_to_selection_data)
10294 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10295 (x_own_selection, x_get_local_selection, x_convert_selection):
10296 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10297 (some_frame_on_display): Delete unused function.
10298 (Fx_own_selection_internal, Fx_get_selection_internal)
10299 (Fx_disown_selection_internal, Fx_selection_owner_p)
10300 (Fx_selection_exists_p): New optional frame arg.
10301 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10302 (x_handle_selection_clear): Don't treat other terminals with the
10303 same keyboard specially. Use the terminal-local Vselection_alist.
10304 (x_clear_frame_selections): Use Frun_hook_with_args.
10305
10306 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10307
10308 * xterm.h: Add support for those atoms.
10309
e067f0c1
CY
103102011-05-26 Chong Yidong <cyd@stupidchicken.com>
10311
10312 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10313 (converted_selections, conversion_fail_tag): New global variables.
10314 (x_selection_request_lisp_error): Free the above.
10315 (x_get_local_selection): Remove unnecessary code.
10316 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10317 of converted selections stored in converted_selections.
10318 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10319 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10320 (x_convert_selection): New function.
10321 (x_handle_selection_event): Simplify.
10322 (x_get_foreign_selection): Don't ignore incoming requests while
10323 waiting for an answer; this will fail when we implement
10324 SAVE_TARGETS, and seems unnecessary anyway.
10325 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10326 (Vx_sent_selection_functions): Doc fix.
10327
0f4aebc0
LL
103282011-05-26 Leo Liu <sdl.web@gmail.com>
10329
10330 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10331
e61124cd
YM
103322011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10333
10334 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10335
10336 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10337 for fringe update if it has periodic bitmap.
ac389d0c 10338 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10339 and fringe_bitmap_periodic_p.
10340
10341 * fringe.c (get_fringe_bitmap_data): New function.
10342 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10343 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10344 row. Mark glyph row for fringe update if periodicity changed.
10345
10346 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10347 for fringe update unless it has periodic bitmap.
10348
f16d9837
KH
103492011-05-25 Kenichi Handa <handa@m17n.org>
10350
10351 * xdisp.c (get_next_display_element): Set correct it->face_id for
10352 a static composition.
10353
e1b90ef6
LL
103542011-05-24 Leo Liu <sdl.web@gmail.com>
10355
10356 * deps.mk (fns.o):
10357 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10358
10359 * fns.c (crypto_hash_function, Fsha1): New function.
10360 (Fmd5): Use crypto_hash_function.
10361 (syms_of_fns): Add Ssha1.
10362
7400048f
PE
103632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10364
10365 * gnutls.c: Remove unused macros.
10366 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10367 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10368 Remove macros that are defined and never used.
10369 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10370
abb71cf4
CY
103712011-05-22 Chong Yidong <cyd@stupidchicken.com>
10372
10373 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10374 (Fx_get_selection_internal): Minor cleanup.
10375 (Fx_own_selection_internal): Rename arguments for consistency with
10376 select.el.
10377
6307db39
PE
103782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10379
10380 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10381
f3d4e0a4
CY
103822011-05-22 Chong Yidong <cyd@stupidchicken.com>
10383
10384 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10385
4d8ade89
YM
103862011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10387
10388 * dispnew.c (scrolling_window): Don't exclude the case that the
10389 last enabled row in the desired matrix touches the bottom boundary.
10390
32078c8d
GM
103912011-05-21 Glenn Morris <rgm@gnu.org>
10392
10393 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10394 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10395 and add some more files.
32078c8d 10396
7285dc67
EZ
103972011-05-20 Eli Zaretskii <eliz@gnu.org>
10398
10399 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10400 report_file_error introduced by the change from 2011-05-07.
10401
89d1bd22
PE
104022011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10403
10404 * systime.h (Time): Define only if emacs is defined.
10405 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10406 where the include path doesn't have X11/X.h by default. See
10407 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10408
cd394be1 104092011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10410
10411 * composite.c (find_automatic_composition): Fix previous change.
10412
b9704ad9
GM
104132011-05-20 Glenn Morris <rgm@gnu.org>
10414
10415 * lisp.mk: New file, split from Makefile.in.
10416 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10417 (shortlisp): Remove.
10418 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10419
4a720484
GM
104202011-05-19 Glenn Morris <rgm@gnu.org>
10421
10422 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10423 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10424 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10425 (lisp): Set the order to that of loadup.el.
10426 (shortlisp): Make it a copy of $lisp.
10427 (SOME_MACHINE_LISP): Remove.
10428 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10429 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10430
a28d4396
KH
104312011-05-18 Kenichi Handa <handa@m17n.org>
10432
10433 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10434 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10435 (find_automatic_composition): Mostly rewrite for efficiency.
10436
a2b1fa8e
JB
104372011-05-18 Juanma Barranquero <lekktu@gmail.com>
10438
10439 * makefile.w32-in: Update dependencies.
10440
8e1f5610
CS
104412011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10442
10443 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10444 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10445
7025ee00 104462011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10447
cdfa6eab
PE
10448 Fix some integer overflow issues, such as string length overflow.
10449
06d6db33
PE
10450 * insdel.c (count_size_as_multibyte): Check for string overflow.
10451
2b4560a8
PE
10452 * character.c (lisp_string_width): Check for string overflow.
10453 Use EMACS_INT, not int, for string indexes and lengths; in
10454 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10455 the resulting string length overflows an EMACS_INT; instead,
10456 report a string overflow if no precision given. When checking for
10457 precision exhaustion, use a check that cannot possibly have
10458 integer overflow. (Bug#8675)
10459 * character.h (lisp_string_width): Adjust to new signature.
10460
cb93f9be
PE
10461 * alloc.c (string_overflow): New function.
10462 (Fmake_string): Use it. This doesn't change behavior, but saves
10463 a few bytes and will simplify future changes.
10464 * character.c (string_escape_byte8): Likewise.
10465 * lisp.h (string_overflow): New decl.
10466
1a1f3366
PE
10467 Fixups, following up to the user-interface timestamp change.
10468 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10469 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10470 * msdos.c (mouse_get_pos): Likewise.
10471 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10472 * w32gui.h (Time): Define by including "systime.h" rather than by
10473 declaring it ourselves. (Bug#8664)
10474
d4e3e4d3
PE
10475 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10476 * image.c (clear_image_cache): Likewise.
10477
f6a24d19
PE
10478 * term.c (term_mouse_position): Don't assume time_t wraparound.
10479
08dc5ae6
PE
10480 Be more systematic about user-interface timestamps.
10481 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10482 and sometimes 'EMACS_UINT', to represent these timestamps.
10483 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10484 This makes the code easier to follow, and makes it easier to catch
10485 integer overflow bugs such as Bug#8664.
10486 * frame.c (Fmouse_position, Fmouse_pixel_position):
10487 Use Time, not unsigned long, for user-interface timestamps.
10488 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10489 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10490 * keyboard.h (last_event_timestamp): Likewise.
10491 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10492 * menu.h (xmenu_show): Likewise.
10493 * term.c (term_mouse_position): Likewise.
10494 * termhooks.h (struct input_event.timestamp): Likewise.
10495 (struct terminal.mouse_position_hook): Likewise.
10496 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10497 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10498 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10499 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10500 what it was before.
10501 * menu.h, termhooks.h: Include "systime.h", for Time.
10502
8e55734a
PE
10503 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10504 Don't assume that the difference between two unsigned long values
10505 can fit into an integer. At this point, we know button_down_time
10506 <= event->timestamp, so the difference must be nonnegative, so
10507 there's no need to cast the result if double-click-time is
10508 nonnegative, as it should be; check that it's nonnegative, just in
10509 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10510 apart (about 25 days). (Bug#8664)
8e55734a 10511
841f1b75 10512 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10513 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10514
3e26f69c
PE
10515 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10516 that always fit in int. Use a sentinel instead of a counter, to
10517 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10518 * frame.h (struct frame): Use int for menu_bar_items_used
10519 instead of EMACS_INT, since it always fits in int.
3e26f69c 10520
5cc152c0
PE
10521 * menu.c (grow_menu_items): Check for int overflow.
10522
d89eb65e
PE
10523 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10524
5235bd3e
PE
10525 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10526 Before, the code was not consistent. These values cannot exceed
10527 2**31 - 1 so there's no need to make them unsigned.
10528 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10529 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10530 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10531 as modifiers.
10532 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10533
bc827e23
PE
10534 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10535 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10536 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10537 presumably because the widths might not match.
10538
78eb494e
PE
10539 * window.c (size_window): Avoid needless test at loop start.
10540
04f2d78b
CB
105412011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10542
10543 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10544
d2fc7e3d 105452011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10546
10547 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10548
d2fc7e3d 105492011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10550
10551 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10552 `width' to `bar_area_x' and `bar_area_width', respectively.
10553 (x_scroll_run): Take account of fringe background extension.
10554
04f2d78b
CB
10555 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10556 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10557 `bar_area_width', respectively.
10558 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10559 background extension.
10560
79b70037
GM
105612011-05-10 Jim Meyering <meyering@redhat.com>
10562
10563 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10564
2f142cc5
JB
105652011-05-10 Juanma Barranquero <lekktu@gmail.com>
10566
10567 * image.c (Finit_image_library): Return t for built-in image types,
10568 like pbm and xbm. (Bug#8640)
10569
57679c86
AS
105702011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10571
10572 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10573
888c9e86
EZ
105742011-05-07 Eli Zaretskii <eliz@gnu.org>
10575
b0512a1d
EZ
10576 * w32console.c (Fset_screen_color): Doc fix.
10577 (Fget_screen_color): New function.
10578 (syms_of_ntterm): Defsubr it.
10579
7285dc67
EZ
10580 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10581 unlink the temporary file if Fcall_process didn't create it in the
10582 first place.
10583 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10584 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10585 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10586 cue to call_process_cleanup not to close that handle.
10587
4d3fcc8e
BK
105882011-05-07 Ben Key <bkey76@gmail.com>
10589
10590 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10591 one of two shell specific rules, either bootstrap-temacs-CMD or
10592 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10593 to the previous implementation of the bootstrap-temacs rule.
10594 The bootstrap-temacs-CMD rule is similar to the previous
10595 implementation of the bootstrap-temacs rule except that it
10596 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10597 variable.
10598
10599 These changes, along with some changes to nt/configure.bat,
10600 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10601 earlier fix to add support for --cflags and --ldflags options
10602 that include quotes so that it works whether make uses cmd or
10603 sh as the shell.
10604
b4289b64
MA
106052011-05-06 Michael Albinus <michael.albinus@gmx.de>
10606
10607 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10608 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10609 is a constant.
10610 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10611 a string. Handle both cases.
10612 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10613 (Fdbus_register_method): Use Qinvalid_function.
10614
af4c0e28
JB
106152011-05-06 Juanma Barranquero <lekktu@gmail.com>
10616
10617 * makefile.w32-in: Update dependencies.
10618 (LISP_H): Add inttypes.h and stdin.h.
10619 (PROCESS_H): Add unistd.h.
10620
c51453d9
EZ
106212011-05-06 Eli Zaretskii <eliz@gnu.org>
10622
10623 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10624 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10625
8ff0ac3c 106262011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10627
4c4b566b
PE
10628 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10629
aab2b9b5
PE
10630 * term.c (vfatal): Remove stray call to va_end.
10631 It's not needed and the C Standard doesn't allow it here anyway.
10632
c378da0b
PE
10633 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10634 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10635
288b08c7
PE
10636 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10637 bytes.
10638
e3601888
PE
10639 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10640
db6c0e74
PE
10641 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10642
dd5963ea
PE
10643 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10644
88c9450f
PE
10645 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10646
2f9442b8
PE
10647 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10648
c032b5f8
PE
10649 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10650 * charset.c (Fdefine_charset_internal): Don't initialize
10651 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10652 32-bit int (Bug#8600).
a108c10b
PE
10653
10654 * lread.c (read_integer): Be more consistent with string-to-number.
10655 Use string_to_number to do the actual conversion; this avoids
10656 rounding errors and fixes some other screwups. Without this fix,
10657 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10658 (digit_to_number): Move earlier, for benefit of read_integer.
10659 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10660 not a digit in any supported base. (Bug#8602)
a108c10b 10661
ad5f9eea
PE
10662 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10663
aec1708a
PE
10664 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10665 to match comment at start of function. This also removes a
10666 GCC warning about overflow in a 32+64-bit port.
10667
47be4ab5
PE
10668 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10669
371cac43
PE
10670 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10671 Reported by Stefan Monnier in
10672 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10673 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10674 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10675
d01a7826
PE
10676 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10677 (EMACS_UINTPTR): Likewise, with uintptr_t.
10678
7fd47d5c
PE
10679 * lisp.h: Prefer 64-bit EMACS_INT if available.
10680 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10681 on 32-bit hosts that have 64-bit int, so that they can access
10682 large files.
122b0c86
PE
10683 However, temporarily disable this change unless the temporary
10684 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10685
8727937b
PE
10686 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10687
8ac068ac
PE
10688 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10689 This removes an assumption that EMACS_INT and long are the same
10690 width as pointers. The assumption is true for Emacs porting targets
10691 now, but we want to make other targets possible.
10692 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10693 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10694 In the rest of the code, change types of integers that hold casted
10695 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10696 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10697 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10698 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10699 No need to cast type when ORing.
10700 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10701 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10702 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10703 assume EMACS_INT is the same width as char *.
10704 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10705 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10706 Remove no-longer-needed casts.
10707 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10708 (xg_tool_bar_help_callback, xg_make_tool_item):
10709 Use EMACS_INTPTR to hold an integer
10710 that will be cast to void *; this can avoid a GCC warning
10711 if EMACS_INT is not the same width as void *.
10712 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10713 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10714 (current_message_1, set_message_1):
10715 Use a local to convert to proper width without a cast.
10716 * xmenu.c (dialog_selection_callback): Likewise.
10717
ede49d71
PE
10718 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10719 Also, don't assume VALBITS / RAND_BITS is less than 5,
10720 and don't rely on undefined behavior when shifting a 1 left into
10721 the sign bit.
10722 * lisp.h (get_random): Change signature to match.
10723
2f30ecd0
PE
10724 * lread.c (hash_string): Use size_t, not int, for hash computation.
10725 Normally we prefer signed values; but hashing is special, because
10726 it's better to use unsigned division on hash table sizes so that
10727 the remainder is nonnegative. Also, size_t is the natural width
10728 for hashing into memory. The previous code used 'int', which doesn't
10729 retain enough info to hash well into very large tables.
10730 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10731
2a866e7b
PE
10732 * dbusbind.c: Don't possibly lose pointer info when converting.
10733 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10734 Use XPNTR rather than XHASH, so that the high-order bits of
10735 the pointer aren't lost when converting through void *.
10736
51639eac
PE
10737 * eval.c (Fautoload): Don't double-shift a pointer.
10738
92394119
PE
10739 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10740
dbdb9a7c
JB
107412011-05-06 Juanma Barranquero <lekktu@gmail.com>
10742
10743 * gnutls.c (DEF_GNUTLS_FN):
10744 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10745
db7a0b4f
AS
107462011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10747
10748 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10749 marker. (Bug#8610)
10750
cd394be1 107512011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10752
10753 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10754 New version that can reserve upto 2GB of heap space.
10755
f7ff1b0f 107562011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10757
10758 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10759
639c109b
TZ
107602011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10761
10762 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10763 `gnutls_certificate_set_x509_key_file'.
10764
d2127135
JB
107652011-05-05 Juanma Barranquero <lekktu@gmail.com>
10766
10767 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10768 Update dependencies.
10769
e968f4f3
JB
107702011-05-04 Juanma Barranquero <lekktu@gmail.com>
10771
10772 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10773 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10774 Remove unused parameter `fildes'.
10775 * process.c (read_process_output, send_process): Don't pass it.
10776
84d358f0
JB
107772011-05-04 Juanma Barranquero <lekktu@gmail.com>
10778
10779 Fix previous change: the library cache is defined in w32.c.
10780 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10781 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10782
0898ca10
JB
107832011-05-04 Juanma Barranquero <lekktu@gmail.com>
10784
10785 Implement dynamic loading of GnuTLS on Windows.
10786
10787 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10788 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10789 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10790 Declare.
10791
10792 * gnutls.c (Qgnutls_dll): Define.
10793 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10794 (gnutls_*): Declare function pointers.
10795 (init_gnutls_functions): New function to initialize function pointers.
10796 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10797 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10798 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10799 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10800 (emacs_gnutls_write, emacs_gnutls_read)
10801 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10802 (Fgnutls_available_p): New function.
10803 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10804 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10805 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10806
10807 * image.c: Include w32.h.
10808 (Vimage_type_cache): Delete.
10809 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10810 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10811 (w32_delayed_load): Move to w32.c.
10812
10813 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10814
10815 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10816 (w32_delayed_load): Move from image.c. When loading a library, record
10817 its filename in the :loaded-from property of the library id.
10818 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10819 Initialize and staticpro them.
10820 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10821
10822 * process.c: Include lisp.h before w32.h, not after.
10823 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10824 instead of gnutls_record_check_pending.
10825
10826 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10827
ff4de4aa
TZ
108282011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10829
10830 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10831 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10832 as passed in.
10833
abe95abb
JD
108342011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10835
10836 * xterm.c (x_set_frame_alpha): Do not set property on anything
10837 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10838
e16e55d4
JB
108392011-05-02 Juanma Barranquero <lekktu@gmail.com>
10840
10841 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10842
bafcf6a5
JB
108432011-05-02 Juanma Barranquero <lekktu@gmail.com>
10844
10845 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10846 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10847 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10848 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10849 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10850 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10851 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10852 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10853 (Qgnutls_bootprop_callbacks_verify): Make static.
10854
e7a6747f
AS
108552011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10856
19ed11ba
AS
10857 * callproc.c: Indentation fixup.
10858
e7a6747f 10859 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10860 (wait_for_termination, interruptible_wait_for_termination):
10861 Move after wait_for_termination_1.
e7a6747f 10862
1ef14cb4
LMI
108632011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10864
10865 * sysdep.c (interruptible_wait_for_termination): New function
10866 which is like wait_for_termination, but allows keyboard
10867 interruptions.
10868
10869 * callproc.c (Fcall_process): Add (:file "file") as an option for
10870 the STDOUT buffer.
10871 (Fcall_process_region): Ditto.
10872
330d880c
EZ
108732011-04-30 Eli Zaretskii <eliz@gnu.org>
10874
8db90b73
EZ
10875 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10876 rather than `XVECTOR (FOO)->size'.
10877
330d880c
EZ
10878 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10879 inttypes.h, as a gnulib replacement is used if it not available in
10880 system headers.
10881
15cbd324
EZ
108822011-04-21 Eli Zaretskii <eliz@gnu.org>
10883
10884 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10885 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10886 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10887
10888 * coding.c (coding_alloc_by_realloc): Error out if destination
10889 will grow beyond MOST_POSITIVE_FIXNUM.
10890 (decode_coding_emacs_mule): Abort if there isn't enough place in
10891 charbuf for the composition carryover bytes. Reserve an extra
10892 space for up to 2 characters produced in a loop.
10893 (decode_coding_iso_2022): Abort if there isn't enough place in
10894 charbuf for the composition carryover bytes.
10895
108962011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10897
ae940cca
EZ
10898 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10899 aborting when %lld or %lll format is passed.
10900 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10901 %llo or %llx format is passed. (Bug#8545)
10902
03ab8921
EZ
10903 * window.c (window_scroll_line_based): Use a marker instead of
10904 simple variables to record original value of point. (Bug#7952)
10905
afda1437
EZ
10906 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10907 produced by %s or %c overflows available buffer space. (Bug#8545)
10908
f76dee0c
PE
109092011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10910
10911 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10912 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10913
fdc5744d
JB
109142011-04-28 Juanma Barranquero <lekktu@gmail.com>
10915
10916 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10917
638f053a
JB
109182011-04-28 Juanma Barranquero <lekktu@gmail.com>
10919
10920 * keyboard.c (Qdelayed_warnings_hook): Define.
10921 (command_loop_1): Run `delayed-warnings-hook'
10922 if Vdelayed_warnings_list is non-nil.
10923 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10924 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10925
d178f871
EZ
109262011-04-28 Eli Zaretskii <eliz@gnu.org>
10927
10928 * doprnt.c (doprnt): Don't return value smaller than the buffer
10929 size if the message was truncated. (Bug#8545).
10930
b124fd93
JB
109312011-04-28 Juanma Barranquero <lekktu@gmail.com>
10932
10933 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10934 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10935
e810457d
PE
109362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10937
10938 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10939
ea51cceb
JB
109402011-04-27 Juanma Barranquero <lekktu@gmail.com>
10941
10942 * makefile.w32-in: Update dependencies.
10943
94dcfacf
EZ
109442011-04-27 Eli Zaretskii <eliz@gnu.org>
10945
10946 Improve `doprnt' and its usage. (Bug#8545)
10947 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10948 `format_end'. Remove support for %l as a conversion specifier.
10949 Don't use xrealloc. Improve diagnostics when the %l size modifier
10950 is used. Update the commentary.
10951
10952 * eval.c (verror): Simplify calculation of size_t.
10953
10954 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10955 messages.
10956
f61f41d7
PE
109572011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10958
10959 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10960 change.
10961
96fb4434
PE
109622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10963
10964 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10965 This makes this file independent of the recent pseudovector change.
10966
671875da 109672011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10968
69e9b5a3
PE
10969 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10970
b5f869a7 10971 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10972 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10973 Remove unused local.
c8926152 10974 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10975
841a1577 10976 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10977 GCC 4.6.0 optimizes based on type-based alias analysis.
10978 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10979 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10980 != &v->size, and therefore "v->size = 1; b->size = 2; return
10981 v->size;" must therefore return 1. This assumption is incorrect
10982 for Emacs, since it type-puns struct Lisp_Vector * with many other
10983 types. To fix this problem, this patch adds a new type struct
f904488f 10984 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10985 and pseudovectors, and helps optimizing compilers not get fooled
10986 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10987 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10988 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10989 the size member.
eab3844f
PE
10990 (XSETPVECTYPE): Rewrite in terms of new macro.
10991 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10992 This is a bit clearer, and further avoids the possibility of
10993 undesirable aliasing.
10994 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10995 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10996 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10997 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10998 (ASIZE): Now uses header.size rather than size.
10999 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11000 to avoid the hassle of writing XVECTOR (foo)->header.size.
11001 (struct vectorlike_header): New type.
eab3844f
PE
11002 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11003 object, to help avoid aliasing.
11004 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11005 (SUBRP): Likewise, since Lisp_Subr is a special case.
11006 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11007 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11008 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11009 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11010 changed to be "header.size" and "header.next".
11011 * buffer.h (struct buffer): Likewise.
11012 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11013 * frame.h (struct frame): Likewise.
11014 * process.h (struct Lisp_Process): Likewise.
11015 * termhooks.h (struct terminal): Likewise.
11016 * window.c (struct save_window_data, struct saved_window): Likewise.
11017 * window.h (struct window): Likewise.
11018 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11019 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11020 * buffer.c (init_buffer_once): Likewise.
11021 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11022 special case.
11023 * process.c (Fformat_network_address): Use local var for size,
11024 for brevity.
11025
0df1eac5
PE
11026 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11027
847ab9d1 11028 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11029 * data.c (atof): Remove decl; no longer used or needed.
11030 (digit_to_number): Move to lread.c.
11031 (Fstring_to_number): Use new string_to_number function, to be
11032 consistent with how the Lisp reader treats infinities and NaNs.
11033 Do not assume that floating-point numbers represent EMACS_INT
11034 without losing information; this is not true on most 64-bit hosts.
11035 Avoid double-rounding errors, by insisting on integers when
11036 parsing non-base-10 numbers, as the documentation specifies.
11037 * lisp.h (string_to_number): New decl, replacing ...
11038 (isfloat_string): Remove.
bc0a5c13 11039 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11040 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11041 appears to have been a coding error. Similarly, do not accept
11042 strings like +-1e0 as floating point numbers. Do not report
11043 overflow for integer overflows unless the base is not 10 which
11044 means we have no simple and reliable way to continue.
11045 Break out the floating-point parsing into a new
11046 function string_to_number, so that Fstring_to_number parses
11047 floating point numbers consistently with the Lisp reader.
04f2d78b 11048 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11049 (E_CHAR, EXP_INT): Remove, replacing with ...
11050 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11051 (string_to_number): New function, replacing isfloat_string.
11052 This function checks for valid syntax and produces the resulting
11053 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11054 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11055 so that overflow for non-base-10 numbers is reported only when
11056 there's no portable and simple way to convert to floating point.
452f4150 11057
67769ffc
PE
11058 * textprop.c (set_text_properties_1): Rewrite for clarity,
11059 and to avoid GCC warning about integer overflow.
11060
c20db43f
PE
11061 * intervals.h (struct interval): Use EMACS_INT for members
11062 where EMACS_UINT might cause problems. See
11063 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11064 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11065 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11066 All uses changed.
37aa2f85
PE
11067 (offset_intervals): Tell GCC not to worry about length overflow
11068 when negating a negative length.
c20db43f 11069
2538aa2f
PE
11070 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11071 (overrun_check_free): Likewise.
11072
f2d3008d
PE
11073 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11074 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11075 word size.
11076
ec8df744
PE
11077 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11078 (gnutls_make_error): Rename local to avoid shadowing.
11079 (gnutls_emacs_global_deinit): ifdef out; not used.
11080 (Fgnutls_boot): Use const for pointer to readonly storage.
11081 Comment out unused local. Fix pointer signedness problems.
11082
640ee02d
PE
11083 * lread.c (openp): Don't stuff size_t into an 'int'.
11084 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11085 about possible signed overflow.
11086
6048fb2a
PE
11087 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11088 (GDK_KEY_g): Don't define if already defined.
11089 (xg_prepare_tooltip): Avoid pointer signedness problem.
11090 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11091
fa3c87e1
PE
11092 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11093 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11094
2172544b
PE
11095 * xfns.c (Fx_window_property): Simplify a bit,
11096 to make a bit faster and to avoid GCC 4.6.0 warning.
11097 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11098
9b821a21
PE
11099 * fns.c (internal_equal): Don't assume size_t fits in int.
11100
3c616cfa
PE
11101 * alloc.c (compact_small_strings): Tighten assertion a little.
11102
c2982e87
PE
11103 Replace pEd with more-general pI, and fix some printf arg casts.
11104 * lisp.h (pI): New macro, generalizing old pEd macro to other
11105 conversion specifiers. For example, use "...%"pI"d..." rather
11106 than "...%"pEd"...".
11107 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11108 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11109 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11110 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11111 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11112 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11113 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11114 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11115 64-bit hosts.
11116 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11117 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11118 * print.c (safe_debug_print, print_object): Likewise.
11119 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11120 to int.
6f04d126
PE
11121 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11122 avoiding the 0 flag, which is not portable.
c2982e87
PE
11123 * process.c (Fmake_network_process): Use pI to avoid cast.
11124 * region-cache.c (pp_cache): Likewise.
11125 * xdisp.c (decode_mode_spec): Likewise.
11126 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11127 behavior on 64-bit hosts with printf arg.
6f04d126 11128 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11129 (x_stop_queuing_selection_requests): Likewise.
11130 (x_get_window_property): Don't truncate byte count to an 'int'
11131 when tracing.
0b432f21 11132
5e073ec7
PE
11133 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11134 here, since it parses constructs like leading '-' and spaces,
11135 which are not wanted; and it overflows with large numbers.
11136 Instead, simply match F[0-9]+, which is what is wanted anyway.
11137
36372bf9
PE
11138 * alloc.c: Remove unportable assumptions about struct layout.
11139 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11140 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11141 (allocate_vectorlike, make_pure_vector): Use the new macros,
11142 plus offsetof, to remove unportable assumptions about struct layout.
11143 These assumptions hold on all porting targets that I know of, but
11144 they are not guaranteed, they're easy to remove, and removing them
11145 makes further changes easier.
11146
0b432f21
PE
11147 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11148 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11149 (string_overrun_cookie): Now const. Use initializers that
11150 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11151 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11152 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11153 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11154 multiple of sizeof (EMACS_INT); it need not be, if
11155 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11156 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11157
895009e1
JB
111582011-04-26 Juanma Barranquero <lekktu@gmail.com>
11159
11160 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11161
6a7a1b0b
TZ
111622011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11163
11164 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11165 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11166 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11167
841a1577 111682011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11169
11170 * lisp.h (Qdebug): List symbol.
895009e1 11171 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11172 * keyboard.c (debug-on-event): New variable.
11173 (handle_user_signal): Break into debugger when debug-on-event
11174 matches the current signal symbol.
11175
f2d3ba6f
DN
111762011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11177
11178 * alloc.c (check_sblock, check_string_bytes)
11179 (check_string_free_list): Convert to standard C.
11180
42ce4c63
TZ
111812011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11182
11183 * w32.c (emacs_gnutls_push): Fix typo.
11184
825cd63c
EZ
111852011-04-25 Eli Zaretskii <eliz@gnu.org>
11186
fb11d64d
EZ
11187 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11188 "cast to pointer from integer of different size".
11189
825cd63c
EZ
11190 Improve doprnt and its use in verror. (Bug#8545)
11191 * doprnt.c (doprnt): Document the set of format control sequences
11192 supported by the function. Use SAFE_ALLOCA instead of always
11193 using `alloca'.
11194
11195 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11196 is one byte too soon. Don't use xrealloc; instead xfree and
11197 xmalloc anew.
11198
e061a11b
TZ
111992011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11200
11201 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11202 callbacks stage.
11203
11204 * gnutls.c: Renamed global_initialized to
11205 gnutls_global_initialized. Added internals for the
11206 :verify-hostname-error, :verify-error, and :verify-flags
11207 parameters of `gnutls-boot' and documented those parameters in the
11208 docstring. Start callback support.
9173deec
JB
11209 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11210 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11211 on error. Return error code.
e061a11b
TZ
11212 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11213 (emacs_gnutls_read): Likewise.
11214 (Fgnutls_boot): Return handshake error code.
11215 (emacs_gnutls_handle_error): New function.
11216 (wsaerror_to_errno): Likewise.
11217
11218 * w32.h (emacs_gnutls_pull): Add prototype.
11219 (emacs_gnutls_push): Likewise.
11220
11221 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11222 (emacs_gnutls_push): Likewise.
11223
112242011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11225
11226 * process.c (wait_reading_process_output): Check if GnuTLS
11227 buffered some data internally if no FDs are set for TLS
11228 connections.
11229
11230 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11231 (LIBS): Link to USER_LIBS.
11232 ($(BLD)/gnutls.$(0)): New target.
11233
fa6996bc
EZ
112342011-04-24 Eli Zaretskii <eliz@gnu.org>
11235
eb35682e
EZ
11236 * xdisp.c (handle_single_display_spec): Rename the
11237 display_replaced_before_p argument into display_replaced_p, to
11238 make it consistent with the commentary. Fix typos in the
11239 commentary.
11240
e2ad650c
EZ
11241 * textprop.c (syms_of_textprop): Remove dead code.
11242 (copy_text_properties): Delete obsolete commentary about an
11243 interface that was deleted long ago. Fix typos in the description
11244 of arguments.
11245
1b2de274
EZ
11246 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11247 to changes in oldXMenu/XMenu.h from 2011-04-16.
11248 <menu_help_message, prev_menu_help_message>: Constify.
11249 (IT_menu_make_room): menu->help_text is now `const char **';
11250 adjust.
11251
11252 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11253 to changes in oldXMenu/XMenu.h from 2011-04-16.
11254 (struct XMenu): Declare `help_text' `const char **'.
11255
11256 * xfaces.c <Qunspecified>: Make extern again.
11257
11258 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11259 required by POSIX.
1b2de274 11260
762b15be
EZ
11261 * doc.c (get_doc_string): Improve the format passed to `error'.
11262
11263 * doprnt.c (doprnt): Improve commentary.
11264
11265 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11266
11267 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11268 them with etags.
11269
f1052e5d
EZ
11270 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11271 changes in globals.h immediately force recompilation.
762b15be
EZ
11272 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11273 $(CURDIR)/s/ms-w32.h.
11274 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11275
fa6996bc
EZ
11276 * character.c (Fchar_direction): Function deleted.
11277 (syms_of_character): Don't defsubr it.
11278 <char-direction-table>: Deleted.
11279
e6c3da20
EZ
112802011-04-23 Eli Zaretskii <eliz@gnu.org>
11281
11282 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11283 * doprnt.c: Include limits.h.
11284 (SIZE_MAX): New macro.
04f2d78b
CB
11285 (doprnt): Return a size_t value. 2nd arg is now size_t.
11286 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11287 Improve overflow protection. Support `l' modifier for integer
11288 conversions. Support %l conversion. Don't assume an EMACS_INT
11289 argument for integer conversions and for %c.
11290
11291 * lisp.h (doprnt): Restore prototype.
11292
11293 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11294 $(SRC)/character.h.
11295
11296 * Makefile.in (base_obj): Add back doprnt.o.
11297
11298 * deps.mk (doprnt.o): Add back prerequisites.
11299 (callint.o): Depend on character.h.
11300
11301 * eval.c (internal_lisp_condition_case): Include the handler
11302 representation in the error message.
11303 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11304 when breaking from the loop.
11305
11306 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11307
11308 * callint.c (Fcall_interactively): When displaying error message
11309 about invalid control letter, pass the character's codepoint, not
11310 a pointer to its multibyte form. Improve display of the character
11311 in octal and display also its hex code.
11312
11313 * character.c (char_string): Use %x to display the (unsigned)
11314 codepoint of an invalid character, to avoid displaying a bogus
11315 negative value.
11316
11317 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11318 `error', not SYMBOL_NAME itself.
11319
11320 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11321 character arguments to `error'.
11322
11323 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11324 to `error' in error message about FINAL_CHAR argument. Make sure
11325 FINAL_CHAR is a character, and use %c when it is passed as
11326 argument to `error'.
11327
4ffd0d6b 113282011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11329
11330 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11331
11332 * w32.c: Include <time.h>.
11333 (sys_localtime): New function.
11334
4ffd0d6b 113352011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11336
11337 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11338
4ffd0d6b 11339 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11340
4ffd0d6b 113412011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11342
4ffd0d6b
GM
11343 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11344 zombies (Bug#8467).
aac0c6e3 11345
04c56954
EZ
113462011-04-19 Eli Zaretskii <eliz@gnu.org>
11347
11348 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11349 gl_state.e_property when gl_state.object is Qt.
11350
11351 * insdel.c (make_gap_larger): Remove limitation of buffer size
11352 to <= INT_MAX.
11353
16a43933
CY
113542011-04-18 Chong Yidong <cyd@stupidchicken.com>
11355
11356 * xdisp.c (lookup_glyphless_char_display)
11357 (produce_glyphless_glyph): Handle cons cell entry in
11358 glyphless-char-display.
11359 (Vglyphless_char_display): Document it.
11360
11361 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11362 glyphless-char-display.
11363
4581706e
CY
113642011-04-17 Chong Yidong <cyd@stupidchicken.com>
11365
11366 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11367
11368 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11369
11370 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11371 definition for no-X builds.
11372
4887c6e2 113732011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11374
fd35b6f9
PE
11375 Static checks with GCC 4.6.0 and non-default toolkits.
11376
5c1ccb01
PE
11377 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11378
006c5daa
PE
11379 * process.c (keyboard_bit_set): Define only if SIGIO.
11380 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11381 (send_process): Repair possible setjmp clobbering.
11382
efc736d3
PE
11383 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11384
4e2fe2e6
PE
11385 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11386
f97334a2
PE
11387 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11388
4e75f29d
PE
11389 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11390 Define only if needed.
11391
90efadd1
PE
11392 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11393 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11394 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11395
3c647824
PE
11396 * dispextern.h (struct redisplay_interface): Rename param
11397 to avoid shadowing.
e264f262 11398 * termhooks.h (struct terminal): Likewise.
761383f4 11399 * xterm.c (xembed_send_message): Likewise.
3c647824 11400
b58c5c4a
PE
11401 * insdel.c (make_gap_smaller): Define only if
11402 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11403
cad59032
PE
11404 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11405 it.
11406
c339dc2e
PE
11407 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11408 so that we aren't warned about unused symbols.
11409
91a3e27b
PE
11410 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11411
399c71d3 11412 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11413
8ffc96f5
PE
11414 * xfns.c (x_real_positions): Mark locals as initialized.
11415
eef9bc79
PE
11416 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11417
098db9dd
PE
11418 * xterm.c: Fix problems found by static analysis with other toolkits.
11419 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11420 (x_dispatch_event): Declare static if USE_GTK, and
11421 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11422 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11423 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11424 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11425 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11426
eb18f6cc
PE
11427 * xmenu.c (menu_help_callback): Pointer type fixes.
11428 Use const pointers when pointing at readonly data. Avoid pointer
11429 signedness clashes.
11430 (FALSE): Remove unused macro.
11431 (update_frame_menubar): Remove unused decl.
11432
1fe72bf8
PE
11433 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11434
60d9e1db
PE
11435 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11436 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11437 (single_menu_item): Rename local to avoid shadowing.
11438
39261c26
PE
11439 * keyboard.c (make_lispy_event): Remove unused local var.
11440
018c5e19
PE
11441 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11442 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11443
63d2b86e
PE
11444 * bitmaps: Change bitmaps from unsigned char back to the X11
11445 compatible char. Avoid the old compiler warnings about
11446 out-of-range initializers by using, for example, '\xab' rather
11447 than 0xab.
11448
aefd87e1
PE
11449 * xgselect.c (xgselect_initialize): Check vs interface
11450 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11451
bf501fb9
PE
11452 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11453
e9829fdf
PE
11454 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11455 to read-only memory.
11456
1086c095
PE
11457 * fns.c (vector): Remove; this old hack is no longer needed.
11458
2baccd04 11459 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11460 Remove unused var.
dde42981 11461 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11462
72391843 11463 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11464
436c16df 11465 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11466 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11467 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11468
92bb796d 11469 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11470 (x_term_init): Remove local to avoid shadowing.
92bb796d 11471
764430a3 11472 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11473
11474 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11475 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11476
d1dfb56c
EZ
114772011-04-16 Eli Zaretskii <eliz@gnu.org>
11478
c4354cb4
EZ
11479 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11480
d1dfb56c
EZ
11481 Fix regex.c, syntax.c and friends for buffers > 2GB.
11482 * syntax.h (struct gl_state_s): Declare character position members
11483 EMACS_INT.
11484
11485 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11486
04f2d78b
CB
11487 * textprop.c (verify_interval_modification, interval_of):
11488 Declare arguments EMACS_INT.
d1dfb56c
EZ
11489
11490 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11491 EMACS_INT.
11492
11493 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11494
11495 * indent.c (Fvertical_motion): Local variable it_start is now
11496 EMACS_INT.
11497
11498 * regex.c (re_match, re_match_2, re_match_2_internal)
11499 (bcmp_translate, regcomp, regexec, print_double_string)
11500 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11501 (re_compile_pattern, re_exec): Declare arguments and local
11502 variables `size_t' and `ssize_t' and return values `regoff_t', as
11503 appropriate.
11504 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11505 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11506 <compile_stack_type>: `size' and `avail' are now `size_t'.
11507
11508 * regex.h <regoff_t>: Use ssize_t, not int.
11509 (re_search, re_search_2, re_match, re_match_2): Arguments that
11510 specify buffer/string position and length are now ssize_t and
11511 size_t. Return type is regoff_t.
11512
613052cd
BK
115132011-04-16 Ben Key <bkey76@gmail.com>
11514
11515 * nsfont.m: Fixed bugs in ns_get_family and
11516 ns_descriptor_to_entity that were caused by using free to
11517 deallocate memory blocks that were allocated by xmalloc (via
11518 xstrdup). This caused Emacs to crash when compiled with
11519 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11520 --enable-checking=xmallocoverrun). xfree is now used to
11521 deallocate these memory blocks.
11522
4170f62f 115232011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11524
71b41406
PE
11525 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11526
9587a89d
PE
11527 emacs_write: Accept and return EMACS_INT for sizes.
11528 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11529 et seq.
11530 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11531 Accept and return EMACS_INT.
11532 (emacs_gnutls_write): Return the number of bytes written on
11533 partial writes.
11534 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11535 (emacs_read, emacs_write): Remove check for negative size, as the
11536 Emacs source code has been audited now.
9587a89d
PE
11537 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11538 (emacs_read, emacs_write): Use it.
273a5f82
PE
11539 * process.c (send_process): Adjust to the new signatures of
11540 emacs_write and emacs_gnutls_write. Do not attempt to store
11541 a byte offset into an 'int'; it might overflow.
9587a89d 11542 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11543
3e047f51
PE
11544 * sound.c: Don't assume sizes fit in 'int'.
11545 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11546 Return EMACS_INT, not int.
3e047f51 11547 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11548 Accept EMACS_INT, not int.
11549 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11550 record read return values.
11551
cc39a9db
BK
115522011-04-15 Ben Key <bkey76@gmail.com>
11553
c9d0ec6d
JB
11554 * keyboard.c (Qundefined): Don't declare static since it is used
11555 in nsfns.m.
11556 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11557 static since they are used in nsfont.m.
cc39a9db 11558
6c60eb9f
SM
115592011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11560
11561 * process.c (Qprocessp): Don't declare static.
11562 * lisp.h (Qprocessp): Declare again.
11563
7990b61a
JB
115642011-04-15 Juanma Barranquero <lekktu@gmail.com>
11565
11566 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11567
5d4cb038
PE
115682011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11569
8bd7b830 11570 Improve C-level modularity by making more things 'static'.
cd64ea1d 11571
e3b27b31
PE
11572 Don't publish debugger-only interfaces to other modules.
11573 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11574 (verify_bytepos, count_markers): Move decls to the only modules
11575 that need them.
11576 * region-cache.h (pp_cache): Likewise.
11577 * window.h (check_all_windows): Likewise.
11578 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11579
5d4cb038
PE
11580 * sysdep.c (croak): Now static, if
11581 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11582 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11583
11584 * alloc.c (refill_memory_reserve): Now static if
11585 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11586 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11587
e87b6180
PE
11588 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11589 Define only if USE_LUCID.
11590
ac64929e
PE
11591 * xrdb.c (x_customization_string, x_rm_string): Now static.
11592
6f37259d
PE
11593 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11594 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11595
1683e3ab
PE
11596 * xdisp.c (draw_row_with_mouse_face): Now static.
11597 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11598
de9c2632
PE
11599 * window.h (check_all_windows): Mark externally visible.
11600
2b96acb7
PE
11601 * window.c (window_deletion_count): Now static.
11602
11603 * undo.c: Make symbols static if they're not exported.
11604 (last_undo_buffer, last_boundary_position, pending_boundary):
11605 Now static.
11606
50436f33
PE
11607 * textprop.c (interval_insert_behind_hooks): Now static.
11608 (interval_insert_in_front_hooks): Likewise.
11609
64520e5c
PE
11610 * term.c: Make symbols static if they're not exported.
11611 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11612 (max_frame_lines, tty_set_terminal_modes):
11613 (tty_reset_terminal_modes, tty_turn_off_highlight):
11614 (get_tty_terminal): Now static.
11615 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11616 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11617 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11618 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11619 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11620
1fa53021
PE
11621 * sysdep.c: Make symbols static if they're not exported.
11622 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11623 Now static.
11624 (sigprocmask_set, full_mask): Remove; unused.
11625 (wait_debugging): Mark as visible.
11626 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11627 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11628
d4b43b22
PE
11629 * syntax.c (syntax_temp): Define only if !__GNUC__.
11630
b7c513d0
PE
11631 * sound.c (current_sound_device, current_sound): Now static.
11632
989b29ad
PE
11633 * search.c (searchbufs, searchbuf_head): Now static.
11634
13a55a78
PE
11635 * scroll.c (scroll_cost): Remove; unused.
11636 * dispextern.h (scroll_cost): Remove decl.
11637
de68a1fc
PE
11638 * region-cache.h (pp_cache): Mark as externally visible.
11639
40ccffa6
PE
11640 * process.c: Make symbols static if they're not exported.
11641 (process_tick, update_tick, create_process, chan_process):
11642 (Vprocess_alist, proc_buffered_char, datagram_access):
11643 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11644 (deactivate_process): Mark defn as static, as well as decl.
11645 * lisp.h (create_process): Remove decl.
11646 * process.h (chan_process, Vprocess_alist): Remove decls.
11647
ad64fc97
PE
11648 * print.c: Make symbols static if they're not exported.
11649 (print_depth, new_backquote_output, being_printed, print_buffer):
11650 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11651 (print_interval, print_number_index, initial_stderr_stream):
11652 Now static.
11653 * lisp.h (Fprinc): Remove decl.
11654 (debug_output_compilation_hack): Mark as externally visible.
11655
adddb265
PE
11656 * sysdep.c (croak): Move decl from here to syssignal.h.
11657 * syssignal.h (croak): Put it here, so the API can be checked when
11658 'croak' is called from dissociate_if_controlling_tty.
11659
1717ede2
PE
11660 * minibuf.c: Make symbols static if they're not exported.
11661 (minibuf_save_list, choose_minibuf_frame): Now static.
11662 * lisp.h (choose_minibuf_frame): Remove decl.
11663
fa5fb2bc
PE
11664 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11665
1e3890d1
PE
11666 * lread.c: Make symbols static if they're not exported.
11667 (read_objects, initial_obarray, oblookup_last_bucket_number):
11668 Now static.
11669 (make_symbol): Remove; unused.
11670 * lisp.h (initial_obarray, make_symbol): Remove decls.
11671
8a1414fa
PE
11672 * keyboard.c: Make symbols static if they're not exported.
11673 (single_kboard, recent_keys_index, total_keys, recent_keys):
11674 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11675 (this_single_command_key_start, echoing, last_auto_save):
11676 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11677 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11678 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11679 (Vlispy_mouse_stem, double_click_count):
11680 Now static.
11681 (force_auto_save_soon): Define only if SIGDANGER.
11682 (ignore_mouse_drag_p): Now static if
11683 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11684 (print_help): Remove; unused.
11685 (stop_character, last_timer_event): Mark as externally visible.
11686 * keyboard.h (ignore_mouse_drag_p): Declare only if
11687 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11688 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11689 * lisp.h (echoing): Remove decl.
11690 (force_auto_save_soon): Declare only if SIGDANGER.
11691 * xdisp.c (redisplay_window): Simplify code, to make it more
11692 obvious that ignore_mouse_drag_p is not accessed if !defined
11693 USE_GTK && !defined HAVE_NS.
11694
93ea6e8f
PE
11695 * intervals.c: Make symbols static if they're not exported.
11696 (merge_properties_sticky, merge_interval_right, delete_interval):
11697 Now static.
11698 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11699
77382fcc
PE
11700 * insdel.c: Make symbols static if they're not exported.
11701 However, leave prepare_to_modify_buffer alone. It's never
11702 called from outside this function, but that appears to be a bug.
11703 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11704 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11705 (adjust_after_replace_noundo): Remove; unused.
11706 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11707 (signal_before_change): Remove decls.
77382fcc 11708
9306c32e
PE
11709 * indent.c (val_compute_motion, val_vmotion): Now static.
11710
cd44d2eb
PE
11711 * image.c: Make symbols static if they're not exported.
11712 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11713 if USE_GTK.
11714 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11715 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11716
ad9a7a06
PE
11717 * fringe.c (standard_bitmaps): Now static.
11718 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11719
81626931
PE
11720 * frame.c: Make symbols static if they're not exported.
11721 (x_report_frame_params, make_terminal_frame): Now static.
11722 (get_frame_param): Now static, unless HAVE_NS.
11723 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11724 (x_get_resource_string): Remove; not used.
11725 * frame.h (make_terminal_frame, x_report_frame_params):
11726 (x_get_resource_string); Remove decls.
11727 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11728 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11729
239f9db9
PE
11730 * font.c, fontset.c: Make symbols static if they're not exported.
11731 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11732 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11733 * font.c (font_close_object): Now static.
11734 * font.h (font_close_object): Remove.
11735 * fontset.c (FONTSET_OBJLIST): Remove.
11736 (free_realized_fontset) #if-0 the body, which does nothing.
11737 (face_suitable_for_char_p): #if-0, as it's never called.
11738 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11739 * xfaces.c (face_at_string_position):
11740 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11741 since 0 is always ASCII.
11742
dfcf3579
PE
11743 * fns.c (weak_hash_tables): Now static.
11744
5045092b
PE
11745 * fileio.c: Make symbols static if they're not exported.
11746 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11747 (Vwrite_region_annotation_buffers): Now static.
11748
57a96f5c
PE
11749 * eval.c: Make symbols static if they're not exported.
11750 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11751 * lisp.h (backtrace_list): Remove decl.
11752
35f08c38
PE
11753 * emacs.c: Make symbols static if they're not exported.
11754 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11755 (fatal_error_code, fatal_error_signal_hook, standard_args):
11756 Now static.
11757 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11758 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11759 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11760 * lisp.h (fatal_error_signal_hook): Remove decl.
11761 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11762
f44bd759
PE
11763 * editfns.c: Move a (normally-unused) function to its only use.
11764 * editfns.c, lisp.h (get_operating_system_release): Remove.
11765 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11766 worth the hassle of breaking this out.
11767
b532497d
PE
11768 * xterm.c: Make symbols static if they're not exported.
11769 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11770 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11771 (x_destroy_window, x_delete_display):
11772 Now static.
11773 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11774 (x_mouse_leave): Remove; unused.
11775 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11776 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11777 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11778 Remove decls.
11779 (x_mouse_leave): Declare only if WINDOWSNT.
11780 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11781 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11782 USE_X_TOOLKIT.
11783
1675728f
PE
11784 * ftxfont.c: Make symbols static if they're not exported.
11785 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11786 HAVE_FREETYPE.
11787 * font.h (ftxfont_driver): Likewise.
11788
e4cebfca
PE
11789 * xfns.c: Make symbols static if they're not exported.
11790 (x_last_font_name, x_display_info_for_name):
11791 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11792 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11793 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11794 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11795 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11796 (last_show_tip_args): Now static.
11797 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11798 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11799 (x_screen_planes): Remove; unused.
11800 * dispextern.h (x_screen_planes): Remove decl.
11801
5bf46f05
PE
11802 * dispnew.c: Make symbols static if they're not exported.
11803 * dispextern.h (redraw_garbaged_frames, scrolling):
11804 (increment_row_positions): Remove.
11805 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11806 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11807 Now static.
11808 (redraw_garbaged_frames): Remove; unused.
11809
435f4c28
PE
11810 * xfaces.c: Make symbols static if they're not exported.
11811 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11812 Remove decls.
11813 * xterm.h (defined_color): Remove decls.
11814 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11815 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11816 (menu_face_changed_default, defined_color, free_realized_face):
11817 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11818 (ascii_face_of_lisp_face): Remove; unused.
11819
8524aef3
PE
11820 * xdisp.c: Make symbols static if they're not exported.
11821 * dispextern.h (scratch_glyph_row, window_box_edges):
11822 (glyph_to_pixel_coords, set_cursor_from_row):
11823 (get_next_display_element, set_iterator_to_next):
11824 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11825 (show_mouse_face): Remove decls
11826 * frame.h (message_buf_print): Likewise.
11827 * lisp.h (pop_message, set_message, check_point_in_composition):
11828 Likewise.
11829 * xterm.h (set_vertical_scroll_bar): Likewise.
11830 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11831 (message_buf_print, scratch_glyph_row, displayed_buffer):
11832 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11833 (get_next_display_element, show_mouse_face, window_box_edges):
11834 (frame_to_window_pixel_xy, check_point_in_composition):
11835 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11836 (glyph_to_pixel_coords): Remove; unused.
11837
16390cd2
PE
11838 * dired.c (file_name_completion): Now static.
11839
11840 * dbusbind.c (xd_in_read_queued_messages): Now static.
11841
a25f4dfa
PE
11842 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11843 * data.c (circular_list_error): Remove.
11844
14a9c8df
PE
11845 * commands.h (last_point_position, last_point_position_buffer):
11846 (last_point_position_window): Remove decls.
11847 * keyboard.c: Make these variables static.
11848
04f2d78b
CB
11849 * coding.h (coding, code_convert_region, encode_coding_gap):
11850 Remove decls.
74ab6df5
PE
11851 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11852 (iso_code_class, detect_coding, code_convert_region): Now static.
11853 (encode_coding_gap): Remove; unused.
11854
38dfbee1
PE
11855 * chartab.c (chartab_chars, chartab_bits): Now static.
11856
a2cb4e63
PE
11857 * charset.h (charset_iso_8859_1): Remove decl.
11858 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11859 Now static.
11860
127198fd
PE
11861 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11862 * ccl.c (Vccl_program_table): Now static.
11863 (check_ccl_update): Remove; unused.
11864
d85b608f
PE
11865 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11866 * category.h: ... from here.
11867 * category.c (check_category_table, set_category_set): Now static.
11868
31cd66f3
PE
11869 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11870 * lisp.h: Remove these decls.
11871
c358e587
PE
11872 * buffer.c (buffer_count): Remove unused var.
11873
e78aecca
PE
11874 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11875 so that it's not optimized away.
11876 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11877 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11878 exported only to the debugger.
11879
e192d7d3 11880 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11881 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11882
92470028
PE
11883 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11884 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11885 was inaccessible from Lisp.
11886 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11887 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11888
244ed907
PE
11889 alloc.c: Import and export fewer symbols, and remove unused items.
11890 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11891 is defined.
11892 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11893 it's not optimized away by whole-program optimization.
11894 (message_enable_multibyte, free_misc): Remove.
11895 (catchlist, handlerlist, mark_backtrace):
11896 Declare only if BYTE_MARK_STACK.
11897 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11898 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11899 (message_enable_multibyte): Remove decl.
11900 (free_misc, interval_free_list, float_block, float_block_index):
11901 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11902 (cons_free_list, last_marked_index):
11903 Now static.
11904 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11905 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11906 (mark_backtrace): Define only if BYTE_MARK_STACK.
11907 * xdisp.c (message_enable_multibyte): Now static.
11908
61c2b50e 11909 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11910 This makes it easier for human readers (and static analyzers)
11911 to see whether these variables are used from other modules.
11912 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11913 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11914 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11915 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11916 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11917 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11918 * xmenu.c, xselect.c:
11919 Declare Q* vars static if they are not used in other modules.
11920 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11921 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11922 Remove decls of unexported vars.
11923 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11924
95c82688
PE
11925 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11926
16a97296
PE
11927 Make Emacs functions such as Fatom 'static' by default.
11928 This makes it easier for human readers (and static analyzers)
11929 to see whether these functions can be called from other modules.
11930 DEFUN now defines a static function. To make the function external
11931 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11932 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11933 (Finit_image_library):
16a97296
PE
11934 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11935 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11936 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11937 Remove decls, since these functions are now static.
11938 (Funintern, Fget_internal_run_time): New decls, since these functions
11939 were already external.
95c82688 11940
16a97296
PE
11941 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11942 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11943 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11944 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11945 * keyboard.c, keymap.c, lread.c:
11946 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11947 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11948 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11949 Mark functions with DEFUE instead of DEFUN,
11950 if they are used in other modules.
11951 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11952 decls for now-static functions.
11953 * buffer.h (Fdelete_overlay): Remove decl.
11954 * callproc.c (Fgetenv_internal): Mark as internal.
11955 * composite.c (Fremove_list_of_text_properties): Remove decl.
11956 (Fcomposition_get_gstring): New forward static decl.
11957 * composite.h (Fcomposite_get_gstring): Remove decl.
11958 * dired.c (Ffile_attributes): New forward static decl.
11959 * doc.c (Fdocumntation_property): New forward static decl.
11960 * eval.c (Ffetch_bytecode): New forward static decl.
11961 (Funintern): Remove extern decl; now in .h file where it belongs.
11962 * fileio.c (Fmake_symbolic_link): New forward static decl.
11963 * image.c (Finit_image_library): New forward static decl.
11964 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11965 * intervals.h (Fprevious_property_change):
11966 (Fremove_list_of_text_properties): Remove decls.
11967 * keyboard.c (Fthis_command_keys): Remove decl.
11968 (Fcommand_execute): New forward static decl.
11969 * keymap.c (Flookup_key): New forward static decl.
11970 (Fcopy_keymap): Now static.
11971 * keymap.h (Flookup_key): Remove decl.
11972 * process.c (Fget_process): New forward static decl.
11973 (Fprocess_datagram_address): Mark as internal.
11974 * syntax.c (Fsyntax_table_p): New forward static decl.
11975 (skip_chars): Remove duplicate decl.
11976 * textprop.c (Fprevious_property_change): New forward static decl.
11977 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11978 Now internal.
11979 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11980 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11981
785bbd42
PE
11982 * editfns.c (Fformat): Remove unreachable code.
11983
8b913b57
AS
119842011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11985
11986 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11987 change. (Bug#8496)
11988
a6744a35
EZ
119892011-04-13 Eli Zaretskii <eliz@gnu.org>
11990
11991 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11992 when at ZV. (Bug#8487)
11993
e7974947
AS
119942011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11995
baad03f0
AS
11996 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11997 (Bug#8437)
11998 * keyboard.c (parse_tool_bar_item): Likewise.
11999 * sound.c (sound_cleanup, alsa_close): Likewise.
12000 * termcap.c (tgetent): Likewise.
12001 * xfns.c (x_default_font_parameter): Likewise.
12002 * xsettings.c (read_and_apply_settings): Likewise.
12003
e7974947
AS
12004 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12005 (overrun_check_free): Protoize.
12006
28272684
PE
120072011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12008
12009 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12010 since callers should never pass a negative size.
12011 Change the signature to match that of plain 'read' and 'write'; see
12012 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12013 * lisp.h: Update prototypes of emacs_write and emacs_read.
12014
11997c76
EZ
120152011-04-11 Eli Zaretskii <eliz@gnu.org>
12016
12017 * xdisp.c (redisplay_window): Don't try to determine the character
12018 position of the scroll margin if the window start point w->startp
e896f03c 12019 is outside the buffer's accessible region. (Bug#8468)
11997c76 12020
8a2cbd72
EZ
120212011-04-10 Eli Zaretskii <eliz@gnu.org>
12022
12023 Fix write-region and its subroutines for buffers > 2GB.
12024 * fileio.c (a_write, e_write): Modify declaration of arguments and
12025 local variables to support buffers larger than 2GB.
12026 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12027
12028 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12029 argument, local variables, and return value.
12030
12031 * lisp.h: Update prototypes of emacs_write and emacs_read.
12032
12033 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12034
4073e537 120352011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12036
1ebfdcb6
PE
12037 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12038
b2ded58d
PE
12039 Fix more problems found by GCC 4.6.0's static checks.
12040
7d66342c
PE
12041 * xdisp.c (vmessage): Use a better test for character truncation.
12042
bbf47d44
PE
12043 * charset.c (load_charset_map): <, not <=, for optimization,
12044 and to avoid potential problems with integer overflow.
9248994d 12045 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12046 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12047 * editfns.c (Fformat): Likewise.
1e69125e 12048 * syntax.c (skip_chars): Likewise.
3befa583 12049
e3019616
PE
12050 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12051 This also lets GCC 4.6.0 generate slightly better loop code.
12052
becfa255
PE
12053 * callint.c (Fcall_interactively): <, not <=, for optimization.
12054 (Fcall_interactively): Count the number of arguments produced,
12055 not the number of arguments given. This is simpler and lets GCC
12056 4.6.0 generate slightly better code.
12057
dae0cd48
PE
12058 * ftfont.c: Distingish more carefully between FcChar8 and char.
12059 The previous code passed unsigned char * to a functions like
12060 strlen and xstrcasecmp that expect char *, which does not
12061 conform to the C standard.
12062 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12063 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12064 char * when the C standard requires it.
12065
76032d70
PE
12066 * keyboard.c (read_char): Remove unused var.
12067
eb3f1cc8
PE
12068 * eval.c: Port to Windows vsnprintf (Bug#8435).
12069 Include <limits.h>.
12070 (SIZE_MAX): Define if the headers do not.
12071 (verror): Do not give up if vsnprintf returns a negative count.
12072 Instead, grow the buffer. This ports to Windows vsnprintf, which
12073 does not conform to C99. Problem reported by Eli Zaretskii.
12074 Also, simplify the allocation scheme, by avoiding the need for
12075 calling realloc, and removing the ALLOCATED variable.
12076
70476b54
PE
12077 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12078
12020a9e
PE
12079 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12080 But keep the doprint source code for now, as we might revamp it
12081 and use it again (Bug#8435).
ea6c7ae6
PE
12082 * lisp.h (doprnt): Remove.
12083 * Makefile.in (base_obj): Remove doprnt.o.
12084 * deps.mk (doprnt.o): Remove.
12085
5fdb398c
PE
12086 error: Print 32- and 64-bit integers portably (Bug#8435).
12087 Without this change, on typical 64-bit hosts error ("...%d...", N)
12088 was used to print both 32- and 64-bit integers N, which relied on
12089 undefined behavior.
61bdb816 12090 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12091 * lisp.h (error, verror): Mark as printf-like functions.
12092 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12093 Report overflow in size calculations when allocating printf buffer.
12094 Do not truncate output string at its first null byte.
12095 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12096 Truncate the output at a character boundary, since vsnprintf does not
12097 do that.
12098 * charset.c (check_iso_charset_parameter): Convert internal
12099 character to string before calling 'error', since %c now has the
12100 printf meaning.
12101 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12102 overflow when computing char to be passed to 'error'. Do not
12103 pass Lisp_Object to 'error'; pass the integer instead.
12104 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12105 formatted with plain %d.
12106
b189fa66
PE
12107 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12108
bff87ef0
PE
12109 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12110
7e2cac20
PE
12111 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12112
ce4d90b5
PE
12113 * xterm.c (x_catch_errors): Remove duplicate declaration.
12114
266c9547
PE
12115 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12116
79c49ad2
PE
12117 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12118
368f4090
JM
121192011-04-10 Jim Meyering <meyering@redhat.com>
12120
12121 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12122 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12123 return ssize_t not "int", and use size_t as the buffer length.
12124 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12125 * gnutls.h: Update declarations.
12126 * process.c (read_process_output): Use ssize_t, to match.
12127 (send_process): Likewise.
12128
a32d4040
CY
121292011-04-09 Chong Yidong <cyd@stupidchicken.com>
12130
12131 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12132
8546720e 121332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12134
04f2d78b
CB
12135 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12136 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12137
8546720e
GM
12138 * xterm.c (handle_one_xevent):
12139 * xmenu.c (create_and_show_popup_menu):
12140 * xselect.c (x_decline_selection_request)
12141 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12142
0a2f5c1a 121432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12144
12145 Fix some uses of `int' instead of EMACS_INT.
12146 * search.c (string_match_1, fast_string_match)
12147 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12148 (scan_buffer, find_next_newline_no_quit)
12149 (find_before_next_newline, search_command, Freplace_match)
12150 (Fmatch_data): Make some `int' variables be EMACS_INT.
12151
12152 * xdisp.c (display_count_lines): 3rd argument and return value now
12153 EMACS_INT. All callers changed.
12154 (pint2hrstr): Last argument is now EMACS_INT.
12155
12156 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12157 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12158 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12159 (decode_coding_utf_16, decode_coding_emacs_mule)
12160 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12161 (decode_coding_ccl, decode_coding_charset)
12162 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12163 (decode_coding_iso_2022, decode_coding_emacs_mule)
12164 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12165 <char_offset, last_offset>: Declare EMACS_INT.
12166 (encode_coding_utf_8, encode_coding_utf_16)
12167 (encode_coding_emacs_mule, encode_invocation_designation)
12168 (encode_designation_at_bol, encode_coding_iso_2022)
12169 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12170 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12171 Declare EMACS_INT.
12172 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12173 (encode_invocation_designation): Last argument P_NCHARS is now
12174 EMACS_INT.
12175 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12176 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12177
12178 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12179 All users changed.
12180
12181 * ccl.c (Fccl_execute_on_string): Declare some variables
12182 EMACS_INT.
12183
8546720e 121842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12185
12186 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12187
4e19a977
CS
121882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12189
12190 * process.c (Fformat_network_address): Doc fix.
12191
87302331
R
121922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12193
ee7683eb 12194 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12195
cbb59342
CY
121962011-04-08 Chong Yidong <cyd@stupidchicken.com>
12197
12198 * keyboard.c (read_char): Call Lisp function help-form-show,
12199 instead of using internal_with_output_to_temp_buffer.
12200 (Qhelp_form_show): New var.
e0d38eeb 12201 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12202
12203 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12204
12205 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12206
e67a13ab
CY
122072011-04-06 Chong Yidong <cyd@stupidchicken.com>
12208
04f2d78b
CB
12209 * process.c (Flist_processes): Remove to Lisp.
12210 (list_processes_1): Delete.
e67a13ab 12211
973f782d
EZ
122122011-04-06 Eli Zaretskii <eliz@gnu.org>
12213
7c106b1e
EZ
12214 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12215
973f782d
EZ
12216 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12217
41cf7d1a 122182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12219
ca23cc88
PE
12220 Fix more problems found by GCC 4.6.0's static checks.
12221
f390e2d5
PE
12222 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12223
42eea0d0
PE
12224 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12225
b69769da 12226 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12227
f9541e84
PE
12228 * xdisp.c (vmessage): Mark as a printf-like function.
12229
13841b55
PE
12230 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12231
c136c10f
PE
12232 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12233
5e2d4a30
PE
12234 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12235 printf-like functions.
12236 (tiff_load): Add casts to remove these marks before passing them
12237 to system-supplied API.
12238
583f48b9
PE
12239 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12240
b25d760e
PE
12241 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12242 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12243 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12244 directly, rather than having caller test rule sign. This avoids
12245 some unnecessary tests.
12246 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12247 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12248 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12249
bc7b6697 12250 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12251 (xfont_open): Avoid unnecessary tests.
bc7b6697 12252
27ccc379
PE
12253 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12254
dcd5c89a
PE
12255 * composite.h, composite.c (composition_gstring_put_cache):
12256 Use EMACS_INT, not int, for length.
12257
b13a45c6
PE
12258 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12259 breaking out part of COMPOSITION_DECODE_RULE.
12260 (COMPOSITION_DECODE_RULE): Use it.
12261 * composite.c (get_composition_id): Remove unused local vars,
12262 by using the new macro.
12263
1e792e4d
PE
12264 * textprop.c (set_text_properties_1): Change while to do-while,
12265 since the condition is always true at first.
12266
dc6c6455 12267 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12268 (interval_deletion_adjustment): Return unsigned value.
12269 All uses changed.
dc6c6455 12270
aba7731a
PE
12271 * process.c (list_processes_1, create_pty, read_process_output):
12272 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12273 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12274 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12275 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12276 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12277
fdfc4bf3
PE
12278 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12279
fca8fe46 12280 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12281 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12282
06a0259a 12283 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12284 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12285 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12286
e7b9e80f
PE
12287 * print.c (print_error_message): Avoid int overflow.
12288
56201685
PE
12289 * font.c (font_list_entities): Redo for clarity,
12290 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12291
78834453 12292 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12293 (font_score): Avoid potential overflow in diff calculation.
78834453 12294
0bc0b309 12295 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12296 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12297
e610eaca
PE
12298 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12299
b895abce
PE
12300 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12301 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12302 can always succeed if overflow has undefined behavior.
12303
1f1d9321 12304 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12305 (wordify): Omit three unnecessary tests.
1f1d9321 12306
c59478bc
PE
12307 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12308 All callers changed. This avoids the need for an unused var.
12309
79b73827
PE
12310 * casefiddle.c (casify_region): Remove var that is set but not used.
12311
a4db5dfe
PE
12312 * dired.c (file_name_completion): Remove var that is set but not used.
12313
43aae36e
PE
12314 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12315
2a47c44d 12316 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12317 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12318
a37c69bf
PE
12319 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12320 Check for integer overflow on size calculations.
12321
328ab8e7
PE
12322 * buffer.c (Fprevious_overlay_change): Remove var that is set
12323 but not used.
12324
e5a2a5cb
PE
12325 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12326 Remove vars that are set but not used.
8d84a6eb 12327 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12328 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12329
a60e5f68
PE
12330 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12331
f661cb61 12332 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12333 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12334
f0397f5a
PE
12335 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12336 that are set but not used.
12337
8664db06 12338 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12339 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12340
6abdaa4a
PE
12341 * xselect.c (x_get_local_selection, x_handle_property_notify):
12342 Remove vars that are set but not used.
12343
0ce7538d 12344 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12345 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12346
9ae848fc
PE
12347 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12348 Remove var that is set but not used.
0b918413
PE
12349 (scroll_bar_windows_size): Now size_t, not int.
12350 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12351 Check for overflow.
9ae848fc 12352
a5a62657
PE
12353 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12354 (map_tty_color) [!defined MSDOS]: Likewise.
12355
5c5cdd39
PE
12356 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12357
66ebf983
PE
12358 * coding.c: Remove vars that are set but not used.
12359 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12360 All callers changed.
12361 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12362 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12363 (decode_coding_charset): Remove vars that are set but not used.
12364
1be4d761
PE
12365 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12366 that is set but not used.
12367
47553fa8
PE
12368 * print.c (print_object): Remove var that is set but not used.
12369
1f7196bf 12370 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12371 The gnulib version avoids calling malloc in the usual case,
12372 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12373 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12374 * filelock.c (current_lock_owner): Likewise.
12375 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12376 * sysdep.c: Include allocator.h, careadlinkat.h.
12377 (emacs_no_realloc_allocator): New static constant.
12378 (emacs_readlink): New function.
fdb61804
PE
12379 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12380 ../lib/careadlinkat.h.
d1fdcab7 12381
f84c17c7
SM
123822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12383
12384 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12385 first non-nil return value).
12386
ef3862ad
JD
123872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12388
12389 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12390 if not defined (Bug#8403).
12391
376a7006
JB
123922011-04-02 Juanma Barranquero <lekktu@gmail.com>
12393
12394 * xdisp.c (display_count_lines): Remove parameter `start',
12395 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12396 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12397 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12398 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12399 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12400 and thereabouts. All callers changed.
12401 (get_per_char_metric): Remove parameter `f', unused since
12402 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12403
6ca3801d
JM
124042011-04-02 Jim Meyering <meyering@redhat.com>
12405
12406 do not dereference NULL upon failed strdup
12407 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12408 (ns_get_family): Likewise.
12409
d8e2b5ba
JB
124102011-04-02 Juanma Barranquero <lekktu@gmail.com>
12411
12412 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12413
8c74fcbd
JD
124142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12415
12416 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12417 later (Bug#8403).
12418
7200d79c
SM
124192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12420
03408648 12421 Add lexical binding.
7200d79c 12422
03408648
SM
12423 * window.c (Ftemp_output_buffer_show): New fun.
12424 (Fsave_window_excursion):
12425 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12426
12427 * lread.c (lisp_file_lexically_bound_p): New function.
12428 (Fload): Bind Qlexical_binding.
12429 (readevalloop): Remove `evalfun' arg.
12430 Bind Qinternal_interpreter_environment.
12431 (Feval_buffer): Bind Qlexical_binding.
12432 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12433 Mark as dynamic.
12434 (syms_of_lread): Declare `lexical-binding'.
12435
12436 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12437
12438 * keyboard.c (eval_dyn): New fun.
12439 (menu_item_eval_property): Use it.
ca105506
SM
12440
12441 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12442
03408648
SM
12443 * fns.c (concat, mapcar1): Accept byte-code-functions.
12444
12445 * eval.c (Fsetq): Handle lexical vars.
12446 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12447 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12448 (FletX, Flet): Obey lexical binding.
12449 (Fcommandp): Handle closures.
12450 (Feval): New `lexical' arg.
12451 (eval_sub): New function extracted from Feval. Use it almost
12452 everywhere where Feval was used. Look up vars in lexical env.
12453 Handle closures.
12454 (Ffunctionp): Move from subr.el.
12455 (Ffuncall): Handle closures.
12456 (apply_lambda): Remove `eval_flags'.
12457 (funcall_lambda): Handle closures and new byte-code-functions.
12458 (Fspecial_variable_p): New function.
12459 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12460 but without exporting it to Lisp.
23aba0ea 12461
23aba0ea 12462 * doc.c (Fdocumentation, store_function_docstring):
03408648 12463 * data.c (Finteractive_form): Handle closures.
23aba0ea 12464
03408648
SM
12465 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12466 interactive spec.
ba83908c 12467
04f2d78b
CB
12468 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12469 New byte-codes.
03408648
SM
12470 (exec_byte_code): New function extracted from Fbyte_code to handle new
12471 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12472
03408648 12473 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12474
03408648 12475 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12476
e2abce01
JB
124772011-03-31 Juanma Barranquero <lekktu@gmail.com>
12478
12479 * xdisp.c (redisplay_internal): Fix prototype.
12480
63696a73 124812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12482
63696a73 12483 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12484 (try_scrolling): Use it when setting scroll_limit.
12485 Limit scrolling to 100 screen lines.
63696a73
EZ
12486 (redisplay_window): Even when falling back on "recentering",
12487 position point in the window according to scroll-conservatively,
12488 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12489
12490 (try_scrolling): When point is above the window, allow searching
12491 as far as scroll_max, or one screenful, to compute vertical
12492 distance from PT to the scroll margin position. This prevents
12493 try_scrolling from unnecessarily failing when
12494 scroll-conservatively is set to a value slightly larger than the
12495 window height. Clean up the case of PT below the margin at bottom
12496 of window: scroll_max can no longer be INT_MAX. When aggressive
12497 scrolling is in use, don't let point enter the opposite scroll
12498 margin as result of the scroll.
12499 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12500 threshold of 100 lines for never-recentering scrolling.
12501
e4cc2dfc
JB
125022011-03-31 Juanma Barranquero <lekktu@gmail.com>
12503
12504 * dispextern.h (move_it_by_lines):
12505 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12506 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12507 (message_log_check_duplicate): Remove parameters `prev_bol' and
12508 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12509 (redisplay_internal): Remove parameter `preserve_echo_area',
12510 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12511
12512 * indent.c (Fvertical_motion):
12513 * window.c (window_scroll_pixel_based, Frecenter):
12514 Don't pass `need_y_p' to `move_it_by_lines'.
12515
1c470562
SM
125162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12517
44f230aa
SM
12518 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12519 steal a few bits to be more compact.
12520 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12521 Remove unneeded casts.
12522
1c470562
SM
12523 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12524
888adce9
ZK
125252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12526
12527 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12528 binding" message (bug#7967).
12529
f838ed7b
PE
125302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12531
77861b95
PE
12532 Fix more problems found by GCC 4.6.0's static checks.
12533
de6dbc14
PE
12534 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12535 Remove unused local var.
12536
f838ed7b
PE
12537 * editfns.c (Fmessage_box): Remove unused local var.
12538
792c7b2b
PE
12539 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12540 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12541 Omit unused local vars.
c499e557 12542 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12543 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12544 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12545 Omit unused local var.
12546
ba0165e1
PE
12547 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12548 Don't assume string length fits in int.
32ad8845 12549 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12550 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12551
3c59b4c9
PE
12552 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12553 instead of alloca (Bug#8344).
12554
a3eed478 12555 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12556 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12557
eb4d412d
PE
12558 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12559
1658b401
PE
12560 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12561 concerns.
12562
12563 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12564
12565 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12566
9a2c6e05
PE
12567 * keyboard.c (syms_of_keyboard): Use the same style as later
12568 in this function when indexing through an array. This also
12569 works around GCC bug 48267.
12570
03d0a109
PE
12571 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12572
44f730c8
PE
12573 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12574
fe75f926
PE
12575 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12576 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12577
ffa8c828
PE
12578 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12579 This avoids undefined behavior on integer overflow, and is a bit
12580 more convenient anyway since it is compared to a size_t variable.
12581
c5101a77
PE
12582 Variadic C functions now count arguments with size_t, not int.
12583 This avoids an unnecessary limitation on 64-bit machines, which
12584 caused (substring ...) to crash on large vectors (Bug#8344).
12585 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12586 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12587 All variadic functions and their callers changed accordingly.
c5101a77
PE
12588 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12589 * data.c (arith_driver, float_arith_driver): Likewise.
12590 * editfns.c (general_insert_function): Likewise.
12591 * eval.c (struct backtrace.nargs, interactive_p)
12592 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12593 (funcall_lambda, mark_backtrace): Likewise.
12594 * fns.c (concat): Likewise.
12595 * frame.c (x_set_frame_parameters): Likewise.
12596 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12597 0 if not found, not -1. All callers changed.
12598
dd3f25f7
PE
12599 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12600 (stack_copy_size): Now size_t, not int.
12601 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12602
461c2ab9
JB
126032011-03-28 Juanma Barranquero <lekktu@gmail.com>
12604
12605 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12606 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12607 All callers changed.
12608
12609 * lisp.h (multibyte_char_to_unibyte):
12610 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12611 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12612 * character.h (CHAR_TO_BYTE8):
12613 * cmds.c (internal_self_insert):
12614 * editfns.c (general_insert_function):
12615 * keymap.c (push_key_description):
12616 * search.c (Freplace_match):
12617 * xdisp.c (message_dolog, set_message_1): All callers changed.
12618
f6d62986
SM
126192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12620
12621 * keyboard.c (safe_run_hook_funcall): New function.
12622 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12623 don't set the hook to nil, but remove the offending function instead.
12624 (Qcommand_hook_internal): Remove, unused.
12625 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12626 Vcommand_hook_internal.
12627
12628 * eval.c (enum run_hooks_condition): Remove.
12629 (funcall_nil, funcall_not): New functions.
12630 (run_hook_with_args): Call each function through a `funcall' argument.
12631 Remove `cond' argument, now redundant.
12632 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12633 (Frun_hook_with_args_until_failure): Adjust accordingly.
12634 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12635
1db5b1ad
JB
126362011-03-28 Juanma Barranquero <lekktu@gmail.com>
12637
12638 * dispextern.h (string_buffer_position): Remove declaration.
12639
12640 * print.c (strout): Remove parameter `multibyte', unused since
12641 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12642
12643 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12644 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12645 All callers changed.
12646
12647 * w32.c (_wsa_errlist): Use braces for struct initializers.
12648
12649 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12650 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12651 All callers changed.
12652 (string_buffer_position): Likewise. Also, make static (it's never
12653 used outside xdisp.c).
12654 (cursor_row_p): Remove parameter `w', unused since
12655 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12656 (decode_mode_spec): Remove parameter `precision', introduced during
12657 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12658 All callers changed.
12659
5ffb62aa
JD
126602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12661
12662 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12663
461c2ab9 126642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12665
12666 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12667 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12668 (ns_update_auto_hide_menu_bar): New functions.
12669 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12670 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12671 ns_constrain_all_frames.
12672 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12673 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12674
5c380ffb
JD
126752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12676
12677 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12678
9af30bdf
GM
126792011-03-27 Glenn Morris <rgm@gnu.org>
12680
12681 * syssignal.h: Replace RETSIGTYPE with void.
12682 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12683 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12684 Replace SIGTYPE with void everywhere.
12685 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12686 * s/template.h (SIGTYPE): Remove commented out definition.
12687
e2abce01
JB
126882011-03-26 Eli Zaretskii <eliz@gnu.org>
12689
12690 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12691 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12692
f868cd8a
JB
126932011-03-26 Juanma Barranquero <lekktu@gmail.com>
12694
59eb0929
JB
12695 * w32.c (read_unc_volume): Use parameter `henum', instead of
12696 global variable `wget_enum_handle'.
12697
12698 * keymap.c (describe_vector): Remove parameters `indices' and
12699 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12700 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12701
f868cd8a
JB
12702 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12703
12704 * keyboard.c (timer_check): Remove parameter `do_it_now',
12705 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12706 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12707 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12708
12709 * keyboard.c (read_char):
12710 * w32menu.c (w32_menu_display_help):
12711 * xmenu.c (show_help_event, menu_help_callback):
12712 Adjust calls to `show_help_echo'.
12713
12714 * gtkutil.c (xg_maybe_add_timer):
12715 * keyboard.c (readable_events):
12716 * process.c (wait_reading_process_output):
12717 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12718
12719 * insdel.c (adjust_markers_gap_motion):
12720 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12721 (gap_left, gap_right): Don't call it.
12722
2ecf6fdb
CY
127232011-03-25 Chong Yidong <cyd@stupidchicken.com>
12724
12725 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12726 incurred during fontification.
12727
6b1f9ba4
JB
127282011-03-25 Juanma Barranquero <lekktu@gmail.com>
12729
12730 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12731 (DEFVAR_PER_BUFFER): Don't pass it.
12732
12733 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12734 (scrolling_window): Don't pass it.
12735
0f4a96b5
JB
127362011-03-25 Juanma Barranquero <lekktu@gmail.com>
12737
12738 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12739
12740 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12741 and `suffix'.
12742 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12743 of variables specific to SELinux and computation of `encoded_absname'.
12744
12745 * image.c (XPutPixel): Remove unused variable `height'.
12746
12747 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12748
12749 * unexw32.c (get_section_info): Remove unused variable `section'.
12750
12751 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12752 (system_process_attributes): Remove unused variable `sess'.
12753 (sys_read): Remove unused variable `err'.
12754
12755 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12756 (w32_wnd_proc): Remove unused variable `isdead'.
12757 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12758 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12759 (x_create_tip_frame): Remove unused variable `tem'.
12760
12761 * w32inevt.c (w32_console_read_socket):
12762 Remove unused variable `no_events'.
12763
12764 * w32term.c (x_draw_composite_glyph_string_foreground):
12765 Remove unused variable `width'.
12766
1149507c
JB
127672011-03-24 Juanma Barranquero <lekktu@gmail.com>
12768
12769 * w32term.c (x_set_glyph_string_clipping):
12770 Don't pass uninitialized region to CombineRgn.
12771
9c88f339
JB
127722011-03-23 Juanma Barranquero <lekktu@gmail.com>
12773
12774 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12775 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12776 (Fx_close_connection): Remove unused variable `i'.
12777
12778 * w32font.c (w32font_draw): Return number of glyphs.
12779 (w32font_open_internal): Remove unused variable `i'.
12780 (w32font_driver): Add missing initializer.
12781
12782 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12783 (fill_in_menu): Remove unused variable `items_added'.
12784
12785 * w32term.c (last_mouse_press_frame): Remove static global variable.
12786 (w32_clip_to_row): Remove unused variable `f'.
12787 (x_delete_terminal): Remove unused variable `i'.
12788
12789 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12790 (NOTHING): Remove unused static global variable.
12791 (uniscribe_check_otf): Remove unused variable `table'.
12792 (uniscribe_font_driver): Add missing initializers.
12793
dee091a3
JD
127942011-03-23 Julien Danjou <julien@danjou.info>
12795
12796 * term.c (Fsuspend_tty, Fresume_tty):
12797 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12798 * window.c (temp_output_buffer_show):
12799 * insdel.c (signal_before_change):
12800 * frame.c (Fhandle_switch_frame):
12801 * fileio.c (Fdo_auto_save):
12802 * emacs.c (Fkill_emacs):
12803 * editfns.c (save_excursion_restore):
12804 * cmds.c (internal_self_insert):
12805 * callint.c (Fcall_interactively):
12806 * buffer.c (Fkill_all_local_variables):
12807 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12808 Use Frun_hooks.
0f4a96b5 12809 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12810 unconditionally since it does the check itself.
dee091a3 12811
2c520ab5 128122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12813
c9c49752
PE
12814 Fix more problems found by GCC 4.5.2's static checks.
12815
8abc3f12
PE
12816 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12817 the first time through the loop, since we know p0 < p1 then.
12818 This also avoids a gcc -Wstrict-overflow warning.
12819
a2d26660
PE
12820 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12821 leading to a memory leak, possible in functions like
12822 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12823 of objects (Bug#8318).
a2d26660 12824
916c72e9
PE
12825 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12826 that could (at least in theory) be that large.
12827
19ab8a18
PE
12828 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12829 This is less likely to overflow, and avoids undefined behavior if
12830 overflow does occur. All callers changed. Use strtoul to scan
12831 for the unsigned long integer.
b7cbbd6f
PE
12832 (pint2hrstr): Simplify and tune code slightly.
12833 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12834
f0641eff
PE
12835 * scroll.c (do_scrolling): Work around GCC bug 48228.
12836 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12837
7f650bb9
PE
12838 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12839 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12840 (validate_x_resource_name): Simplify count usage.
12841 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12842
37dd57d1
PE
12843 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12844 fail (Bug#8306).
81e56e61 12845
699979fc 12846 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12847
401bf9b4
PE
12848 * process.c (Fmake_network_process): Use socklen_t, not int,
12849 where POSIX says socklen_t is required in portable programs.
12850 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12851 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12852 (Fmake_network_process, server_accept_connection):
12853 (wait_reading_process_output, read_process_output):
12854 Likewise.
12855
b93aacde
PE
12856 * process.c: Rename or move locals to avoid shadowing.
12857 (list_processes_1, Fmake_network_process):
12858 (read_process_output_error_handler, exec_sentinel_error_handler):
12859 Rename or move locals.
4dc343ee 12860 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12861 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12862 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12863 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12864 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12865
af8a867c 12866 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12867 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12868 Include tparam.h instead, since it declares them.
af8a867c
PE
12869 * cm.h (PC): Remove extern decl; tparam.h now does this.
12870 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12871 * terminfo.c: Include tparam.h, to check interfaces.
12872 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12873 (tparam): Adjust signature to match interface in tparam.h;
12874 this removes some undefined behavior. Check that outstring and len
12875 are zero, which they always are with Emacs.
12876 * tparam.h (PC, BC, UP): New extern decls.
12877
0248044d 12878 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12879 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12880
8ff096c1 12881 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12882 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12883 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12884 (ftfont_list): Remove unused local.
49eaafba
PE
12885 (get_adstyle_property, ftfont_pattern_entity):
12886 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12887 Rename locals to avoid shadowing.
8ff096c1 12888
e2be39f6
PE
12889 * xfont.c (xfont_list_family): Mark var as initialized.
12890
c9735e30
PE
12891 * xml.c (make_dom): Now static.
12892
8f5201ae
PE
12893 * composite.c (composition_compute_stop_pos): Rename local to
12894 avoid shadowing.
b246f932
PE
12895 (composition_reseat_it): Remove unused locals.
12896 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12897 (composition_update_it): Mark var as initialized.
11b61122
PE
12898 (find_automatic_composition): Mark vars as initialized,
12899 with a FIXME (Bug#8290).
8f5201ae 12900
760fbc2c
PE
12901 character.h: Rename locals to avoid shadowing.
12902 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12903 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12904 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12905 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12906 to avoid shadowing.
12907
ff08eb85
PE
12908 * textprop.c (property_change_between_p): Remove; unused.
12909
fc7bf025
PE
12910 * intervals.c (interval_start_pos): Now static.
12911
235d7abc
PE
12912 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12913
44f230aa
SM
12914 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12915 Rename locals to avoid shadowing.
3e7d6594 12916
50060332
PE
12917 * sound.c (wav_play, au_play, Fplay_sound_internal):
12918 Fix pointer signedness.
d01f234b 12919 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12920 (wav_play): Initialize a variable to 0, to prevent undefined
12921 behavior (Bug#8278).
50060332 12922
c4fc4e30
PE
12923 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12924
918436ed
PE
12925 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12926
c939f91b
PE
12927 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12928 clobbering (Bug#8298).
b9c7f648
PE
12929 * sysdep.c (sys_subshell): Likewise.
12930 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12931
6bd8c144
PE
12932 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12933 This should get cleaned up, so that child_setup has the
12934 same signature on all platforms.
12935
7710357c 12936 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12937 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12938
c59da222
CY
129392011-03-22 Chong Yidong <cyd@stupidchicken.com>
12940
12941 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12942 not to be necessary, and produces flickering.
12943
66b87493
GM
129442011-03-20 Glenn Morris <rgm@gnu.org>
12945
12946 * config.in: Remove file.
12947
45b6f6d5
JB
129482011-03-20 Juanma Barranquero <lekktu@gmail.com>
12949
12950 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12951 are now in src/globals.h.
12952 (syms_of_minibuf): Remove spurious & from previous change.
12953
cd394be1 129542011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12955
12956 * minibuf.c (completing-read-function): New variable.
12957 (completing-read-default): Rename from completing-read.
12958 (completing-read): Call completing-read-function.
12959
b14e3e21
CY
129602011-03-19 Juanma Barranquero <lekktu@gmail.com>
12961
12962 * xfaces.c (Fx_load_color_file):
12963 Read color file from absolute filename (bug#8250).
12964
f2b726e6
JB
129652011-03-19 Juanma Barranquero <lekktu@gmail.com>
12966
12967 * makefile.w32-in: Update dependencies.
12968
09f6ff02
EZ
129692011-03-17 Eli Zaretskii <eliz@gnu.org>
12970
12971 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12972
29a6015a
PE
129732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12974
a3a6c54e
PE
12975 Fix more problems found by GCC 4.5.2's static checks.
12976
b766f867
PE
12977 * process.c (make_serial_process_unwind, send_process_trap):
12978 (sigchld_handler): Now static.
12979
be02381c
PE
12980 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12981 That way, the code declares only the vars that it needs.
12982 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12983 * s/cygwin.h (PTY_ITERATION): Likewise.
12984 * s/darwin.h (PTY_ITERATION): Likewise.
12985 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12986
57048744
PE
12987 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12988 * process.c (allocate_pty): Don't declare stb unless it's needed.
12989
7914961c 12990 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12991 (CONSTANTLIM): Remove; unused.
12992 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12993 Define only if needed.
7914961c 12994
b3967b18
PE
12995 * unexelf.c (unexec): Name an expression,
12996 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12997 Use a different way to cause a compilation error if anyone uses
12998 n rather than nn, a way that does not involve shadowing.
73366a00 12999 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13000
29a6015a
PE
13001 * deps.mk (unexalpha.o): Remove; unused.
13002
43cfc33e 13003 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13004 * unexec.h: New file.
ce701a33
PE
13005 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13006 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13007 Depend on unexec.h.
13008 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13009 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13010 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13011 Change as necessary to match prototype in unexec.h.
ce701a33 13012
01f44d5a
PE
13013 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13014 shadowing.
4f63c6bb 13015 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13016
a6670b0b
PE
13017 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13018 Rename locals to avoid shadowing.
13019
cef2010d 13020 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13021 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13022
d4d7173a
PE
13023 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13024
f08b802a
PE
13025 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13026 warning when compiling print.c.
13027
3ddb0639
PE
13028 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13029 instead of using an uninitialized var.
5ad03b97 13030 (font_sort_entities): Mark var as initialized.
3ddb0639 13031
170a2692
PE
13032 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13033
e663c700
PE
13034 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13035 pointers to constants.
89bc529a 13036 (font_parse_fcname): Remove unused vars.
7b81e2d0 13037 (font_delete_unmatched): Now static.
ea838e10 13038 (font_get_spec): Remove; unused.
13a547c6
PE
13039 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13040 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13041 Rename or move locals to avoid shadowing.
e663c700 13042
2a80c887 13043 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13044 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13045
1384fa33 13046 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13047 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13048
8b2c52e9
PE
13049 * alloc.c (mark_backtrace): Move decl from here ...
13050 * lisp.h: ... to here, so that it can be checked.
13051
475545b5 13052 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13053 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13054 (lisp_indirect_variable): Name an expression,
13055 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13056 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13057
b1349114 13058 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13059 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13060 Use const pointer when appropriate.
b1349114 13061
a2928364
PE
13062 * lisp.h (get_system_name, get_operating_system_release):
13063 Move decls here, to check interfaces.
13064 * process.c (get_operating_system_release): Move decl to lisp.h.
13065 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13066 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13067 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13068 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13069 (Fformat_time_string, Fencode_time, Finsert_char):
13070 (Ftranslate_region_internal, Fformat):
13071 Rename or remove local vars to avoid shadowing.
9710023e 13072 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13073
a415e694
PE
13074 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13075 avoid shadowing.
13076
8ef4622d
PE
13077 * lisp.h (eassert): Check that the argument compiles, even if
13078 ENABLE_CHECKING is not defined.
13079
946f9a5b
PE
13080 * data.c (Findirect_variable): Name an expression, to avoid
13081 gcc -Wbad-function-cast warning.
112396d6 13082 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13083 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13084 (Fmake_variable_buffer_local, Fmake_local_variable):
13085 Mark variables as initialized.
52746918 13086 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13087
e5aab7e7 13088 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13089 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13090 Rename locals to avoid shadowing.
dff45157
PE
13091 (mark_stack): Move local variables into the #ifdef region where
13092 they're used.
7bc26fdb
PE
13093 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13094 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13095 needed otherwise.
13096 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13097 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13098 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13099
e5aab7e7
PE
13100 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13101 avoids undefined behavior in theory.
13102
4da60324
PE
13103 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13104
88043301
PE
13105 Use functions, not macros, for up- and down-casing (Bug#8254).
13106 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13107 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13108 to use the following functions instead of these macros.
13109 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13110 EMACS_INT, since callers assume the returned value fits in int.
13111 (upcase1): Likewise, for UPCASE_TABLE.
13112 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13113 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13114 the race-condition problem in the old DOWNCASE.
88043301 13115
19ed5445
PE
13116 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13117 Rename locals to avoid shadowing.
13118 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13119 (regex_compile, re_search_2, re_match_2_internal):
13120 Remove unused local vars.
952db0d7
PE
13121 (FREE_VAR): Rewrite so as not to use empty "else",
13122 which gcc can warn about.
da053e48 13123 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13124 (RETALLOC_IF): Define only if needed.
13125 (WORDCHAR_P): Likewise. This one is never needed, but is used
13126 only in a comment talking about a compiler bug, so put inside
13127 the #if 0 of that comment.
13128 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13129 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13130 Remove; unused.
19ed5445 13131
1f3561e4 13132 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13133 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13134 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13135
ded6f8f7
PE
13136 * search.c (simple_search): Remove unused var.
13137
dbd37a95
PE
13138 * dired.c (compile_pattern): Move decl from here ...
13139 * lisp.h: ... to here, so that it can be checked.
13140 (struct re_registers): New forward decl.
13141
7e47afad
PE
13142 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13143
85f24f61
PE
13144 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13145 All uses changed.
13146 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13147 Rename locals to avoid shadowing.
5671df8f 13148 (Fvertical_motion): Mark locals as initialized.
85f24f61 13149
181aa2be 13150 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13151 (casify_region): Mark local as initialized.
181aa2be 13152
930d429c
PE
13153 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13154
7082eac6
PE
13155 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13156 New macros, so that the caller can use some names other than
13157 gcpro1, gcpro2, etc.
13158 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13159 of the new macros.
13160 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13161 argument, for consistency with GCPRO2_VAR, etc: it is now the
13162 prefix of the variable, not the variable itself. All uses
13163 changed.
38b2c076
PE
13164 * dired.c (directory_files_internal, file_name_completion):
13165 Rename locals to avoid shadowing.
13166
15206ed9
PE
13167 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13168 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13169 dired.c's scmp function, had undefined behavior.
13170 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13171 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13172 * buffer.h: ... to here, because these macros use current_buffer,
13173 and the new implementation with inline functions needs to have
13174 current_buffer in scope now, rather than later when the macros
13175 are used.
13176 (downcase, upcase1): New static inline functions.
13177 (DOWNCASE, UPCASE1): Reimplement using these functions.
13178 This avoids undefined behavior in expressions like
13179 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13180 from race conditions in accessing the global variables
13181 case_temp1 and case_temp2.
13182 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13183 * lisp.h (case_temp1, case_temp2): Remove their decls.
13184 * character.h (ASCII_CHAR_P): Move from here ...
13185 * lisp.h: ... to here, so that the inline functions mentioned
13186 above can use them.
13187
4a6bea26
PE
13188 * dired.c (directory_files_internal_unwind): Now static.
13189
f14b7e14
PE
13190 * fileio.c (file_name_as_directory, directory_file_name):
13191 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13192 Now static.
2893f146
PE
13193 (file_name_as_directory): Use const pointers when appropriate.
13194 (Fexpand_file_name): Likewise. In particular, newdir might
13195 point at constant storage, so make it a const pointer.
fd4ead52 13196 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13197 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13198 signedness issues.
f839df0c
PE
13199 (Fset_file_times, Finsert_file_contents, auto_save_error):
13200 Rename locals to avoid shadowing.
f14b7e14 13201
5716756e 13202 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13203 (Ftry_completion, Fall_completions): Rename or remove locals
13204 to avoid shadowing.
5716756e 13205
b4c3046a
PE
13206 * marker.c (bytepos_to_charpos): Remove; unused.
13207
b45db522
PE
13208 * lisp.h (verify_bytepos, count_markers): New decls,
13209 so that gcc does not warn that these functions aren't declared.
13210
85876d07
PE
13211 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13212 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13213 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13214 (copy_text): Remove unused local var.
85876d07 13215
03d78a21 13216 * filelock.c (within_one_second): Now static.
b3dd38ab 13217 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13218
5df8f01b
PE
13219 * buffer.c (fix_overlays_before): Mark locals as initialized.
13220 (fix_start_end_in_overlays): Likewise. This function should be
13221 simplified by using pointers-to-pointers, but that's a different
13222 matter.
b1d876f1 13223 (switch_to_buffer_1): Now static.
8f54f30a
PE
13224 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13225 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13226
a70072c9 13227 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13228 Fix pointer signedness issue.
edced198
PE
13229 (sys_subshell): Mark local as volatile if checking for lint,
13230 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13231 (MAXPATHLEN): Define only if needed.
a70072c9 13232
a0977c44
PE
13233 * process.c (serial_open, serial_configure): Move decls from here ...
13234 * systty.h: ... to here, so that they can be checked.
13235
a884fdcc
PE
13236 * fns.c (get_random, seed_random): Move extern decls from here ...
13237 * lisp.h: ... to here, so that they can be checked.
13238
604efe86 13239 * sysdep.c (reset_io): Now static.
b8950c94 13240 (wait_for_termination_signal): Remove; unused.
604efe86 13241
38fc62d9
PE
13242 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13243 (copy_keymap_item, append_key, push_text_char_description):
13244 Now static.
1004a21a 13245 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13246 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13247 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13248 (describe_map_tree):
13249 Rename locals to avoid shadowing.
38fc62d9 13250
2f2650da
PE
13251 * keyboard.c: Declare functions static if they are not used elsewhere.
13252 (echo_char, echo_dash, cmd_error, top_level_2):
13253 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13254 (read_char, kbd_buffer_get_event, make_lispy_position):
13255 (make_lispy_event, make_lispy_movement, apply_modifiers):
13256 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13257 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13258 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13259 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13260 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13261
a053e86c 13262 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13263 (mark_kboards): Move decl here ...
13264 * alloc.c (mark_kboards): ... from here.
a053e86c 13265
4752793e
PE
13266 * lisp.h (force_auto_save_soon): New decl.
13267
74f10ca7 13268 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13269 (DEFINE_DUMMY_FUNCTION): New macro.
13270 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13271 Use it.
c03cd23f
PE
13272 (main): Add casts to avoid warnings
13273 if GCC considers string literals to be constants.
74f10ca7 13274
022e70d4
PE
13275 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13276
59d6fe83
PE
13277 * dbusbind.c: Pointer signedness fixes.
13278 (xd_signature, xd_append_arg, xd_initialize):
13279 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13280 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13281 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13282 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13283
78320123
PE
13284 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13285 if GCC considers string literals to be constants.
49cebcca 13286 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13287
35ac2a97
SM
132882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13289
fb103ca9
SM
13290 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13291 (print_preprocess, print_object): New macro to fix last change.
13292
35ac2a97
SM
13293 * print.c (print_preprocess): Don't forget font objects.
13294
62973b41
JB
132952011-03-16 Juanma Barranquero <lekktu@gmail.com>
13296
13297 * emacs.c (USAGE3): Doc fixes.
13298
0e48bb22
AS
132992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13300
13301 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13302 structure.
13303
7684e57b
JB
133042011-03-14 Juanma Barranquero <lekktu@gmail.com>
13305
13306 * lisp.h (VWindow_system, Qfile_name_history):
13307 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13308 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13309 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13310
13311 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13312 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13313
13314 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13315 * w32console.c (detect_input_pending, read_input_pending)
13316 (encode_terminal_code):
13317 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13318 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13319 (w32_system_caret_y, Qfile_name_history):
13320 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13321 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13322 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13323 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13324 * w32proc.c (Qlocal, report_file_error):
13325 * w32term.c (Vwindow_system, updating_frame):
13326 * w32uniscribe.c (initialized, uniscribe_font_driver):
13327 Remove unneeded extern declarations.
13328
2aa46d6c
CY
133292011-03-14 Chong Yidong <cyd@stupidchicken.com>
13330
c96bbc66 13331 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13332
cffc6f3b
CY
133332011-03-13 Chong Yidong <cyd@stupidchicken.com>
13334
13335 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13336 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13337 These macros can no longer be used for assignment.
13338
44f230aa
SM
13339 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13340 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13341 (record_buffer_markers, fetch_buffer_markers): New functions for
13342 recording and fetching special buffer markers.
13343 (set_buffer_internal_1, set_buffer_temp): Use them.
13344
13345 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13346
13347 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13348
13349 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13350 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13351
13352 * xdisp.c (hscroll_window_tree):
13353 (reconsider_clip_changes): Use PT instead of BUF_PT.
13354
d251f04b
EZ
133552011-03-13 Eli Zaretskii <eliz@gnu.org>
13356
13357 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13358 $(EMACS_ROOT)/lib/intprops.h.
13359
f0c77cd1
PE
133602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13361
3eca4629
PE
13362 Fix more problems found by GCC 4.5.2's static checks.
13363
7c86ee98
PE
13364 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13365 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13366 (xg_free_frame_widgets): Make it clear that a local variable is
13367 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13368 (gdk_window_get_screen): Make it clear that this macro is needed
13369 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13370 (int_gtk_range_get_value): New function, which avoids a diagnostic
13371 from gcc -Wbad-function-cast.
13372 (xg_set_toolkit_scroll_bar_thumb): Use it.
13373 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13374 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13375 (get_utf8_string, xg_get_file_with_chooser):
13376 Rename locals to avoid shadowing.
13377 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13378
41729b81
PE
13379 * xgselect.c (xg_select): Remove unused var.
13380
f0c77cd1
PE
13381 * image.c (four_corners_best): Mark locals as initialized.
13382 (gif_load): Initialize transparent_p to zero (Bug#8238).
13383 Mark another local as initialized.
ec6cf4c6 13384 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13385
ce0ad53d 13386 * image.c (clear_image_cache): Now static.
d5d5a617 13387 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13388 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13389 (x_edge_detection): Remove unnecessary cast that
13390 gcc -Wbad-function-cast diagnoses.
2037898d 13391 (gif_load): Fix pointer signedness.
6ae141d6
PE
13392 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13393 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13394
33383987 133952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13396
d32df629
PE
13397 Improve quality of tests for time stamp overflow.
13398 For example, without this patch (encode-time 0 0 0 1 1
13399 1152921504606846976) returns the obviously-bogus value (-948597
13400 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13401 reports time overflow. See
13402 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13403 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13404 * editfns.c: Include limits.h and intprops.h.
13405 (TIME_T_MIN, TIME_T_MAX): New macros.
13406 (time_overflow): Move earlier, to before first use.
13407 (hi_time, lo_time): New functions, for an accurate test for
13408 out-of-range times.
13409 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13410 (Fget_internal_run_time): Don't assume time_t fits in int.
13411 (make_time): Use list2 instead of Fcons twice.
13412 (Fdecode_time): More accurate test for out-of-range times.
13413 (check_tm_member): New function.
13414 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13415 (lisp_time_argument): Don't rely on undefined left-shift and
13416 right-shift behavior when checking for time stamp overflow.
8be6f318 13417
fe31d94c
PE
13418 * editfns.c (time_overflow): New function, refactoring common code.
13419 (Fformat_time_string, Fdecode_time, Fencode_time):
13420 (Fcurrent_time_string): Use it.
13421
8be6f318
PE
13422 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13423 * dired.c (make_time): Move to ...
13424 * editfns.c (make_time): ... here.
13425 * systime.h: Note the move.
13426
09d9db2c 134272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13428
126bc0dc
YM
13429 * fringe.c (update_window_fringes): Remove unused variables.
13430
c47cbdfd
YM
13431 * unexmacosx.c (copy_data_segment): Also copy __got section.
13432 (Bug#8223)
13433
7ac80be9
EZ
134342011-03-12 Eli Zaretskii <eliz@gnu.org>
13435
c96bbc66 13436 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13437 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13438 Constify `char *' arguments and their references according to
13439 prototypes in tparam.h.
13440
ecb0f94d 13441 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13442
7ac80be9
EZ
13443 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13444 Adapt all references accordingly.
13445
13446 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13447
ef1fd07e
TT
134482011-03-11 Tom Tromey <tromey@redhat.com>
13449
13450 * buffer.c (syms_of_buffer): Remove obsolete comment.
13451
7ef4b50c
EZ
134522011-03-11 Eli Zaretskii <eliz@gnu.org>
13453
13454 * termhooks.h (encode_terminal_code): Declare prototype.
13455
13456 * msdos.c (encode_terminal_code): Don't declare prototype.
13457
13458 * term.c (encode_terminal_code): Now external again, used by
13459 w32console.c and msdos.c.
13460
44f230aa
SM
13461 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13462 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13463
4b1ec863 134642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13465
1714f52b 13466 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13467
4b1ec863
PE
13468 * fringe.c (update_window_fringes): Mark locals as initialized
13469 (Bug#8227).
13470 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13471
524c7aa6
PE
13472 * alloc.c (mark_fringe_data): Move decl from here ...
13473 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13474 to check its interface.
13475 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13476
a5c0af81 13477 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13478 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13479 (fontset_font): Mark local as initialized.
a9a06e0b 13480 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13481
b4716021
PE
13482 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13483
811e9bac 13484 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13485 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13486 (x_own_selection, Fx_disown_selection_internal): Rename locals
13487 to avoid shadowing.
13488 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13489
7e3ab302
PE
13490 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13491 so that the caller can use some name other than gcpro1.
13492 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13493 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13494 (Fx_backspace_delete_keys_p):
13495 Use them to avoid shadowing, and rename vars to avoid shadowing.
13496 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13497 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13498 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13499 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13500 Remove unused locals.
7e3ab302
PE
13501 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13502 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13503 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13504 macros.
f78faa98 13505
e2b13473
PE
13506 * xterm.h (x_mouse_leave): New decl.
13507
77f23912
PE
13508 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13509 Remove unused functions.
cdf4ba58
PE
13510 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13511 (x_calc_absolute_position): Now static.
7411c686 13512 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13513 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13514 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13515 unless they are used.
38d0b34a
PE
13516 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13517 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13518 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13519 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13520 (x_error_catcher, x_connection_closed, x_error_handler):
13521 (x_error_quitter, xembed_send_message, x_iconify_frame):
13522 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13523 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13524 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13525
44f230aa
SM
13526 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13527 Rename or move locals to avoid shadowing.
6b463e58 13528 (tty_defined_color, merge_face_heights): Now static.
5967d051 13529 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13530 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13531 does not deduce is never used uninitialized.
73719eba
PE
13532 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13533 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13534
426994c3 13535 * terminal.c (store_terminal_param): Now static.
5489860b 13536
032f1620 13537 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13538 (set_frame_menubar): Remove unused local.
d4323972 13539 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13540 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13541 since they might point to immutable storage.
281585b0
PE
13542 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13543 since it's unused otherwise.
032f1620 13544
367c19e5 13545 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13546 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13547 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13548 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13549 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13550 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13551 does not deduce are never used uninitialized.
70739cbe 13552
07b48fa9
PE
13553 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13554
8868a238 13555 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13556 * window.c (window_loop, size_window):
13557 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13558
7e5cf297 13559 * window.c (display_buffer): Now static.
d6550a9f
PE
13560 (size_window): Mark variables that gcc -Wuninitialized
13561 does not deduce are never used uninitialized.
a586633d
PE
13562 * window.h (check_all_windows): New decl, to forestall
13563 gcc -Wmissing-prototypes diagnostic.
5b555da1 13564 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13565
f6095868
PE
13566 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13567 shadowing.
13568 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13569 Include <limits.h>.
13570 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13571 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13572 (load_charset_map): Mark variables that gcc -Wuninitialized
13573 does not deduce are never used uninitialized.
53df7c11 13574 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13575
f38b440c
PE
13576 * coding.c (coding_set_source, coding_set_destination):
13577 Use "else { /* comment */ }" rather than "else /* comment */;"
13578 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13579 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13580 a block, when the outer 'i' will do.
13581 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13582 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13583 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13584 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13585 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13586 Rename locals to avoid shadowing.
13587 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13588 * coding.c (emacs_mule_char, encode_invocation_designation):
13589 Now static, since they're not used elsewhere.
413bb2db 13590 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13591 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13592 (decode_coding_emacs_mule): Mark variables that gcc
13593 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13594 (detect_coding_iso_2022): Initialize a local variable that might
13595 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13596 this initialization is needed. (Bug#8211)
5f58e762
PE
13597 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13598 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13599 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13600 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13601 Remove unused macros.
f38b440c 13602
232b38b9 13603 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13604 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13605 * character.c (string_count_byte8): Likewise.
232b38b9 13606
fb90da1b
PE
13607 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13608 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13609
fb93dbc2
PE
13610 * chartab.c (copy_sub_char_table): Now static, since it's not used
13611 elsewhere.
5c156ace
PE
13612 (sub_char_table_ref_and_range, char_table_ref_and_range):
13613 Rename locals to avoid shadowing.
bbcd0949 13614 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13615
7d3b3862 13616 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13617 (BIDI_BOB): Remove unused macro.
7d3b3862 13618
6be7d3da
PE
13619 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13620 deduce are never used uninitialized.
c2ed9c8b 13621 * term.c (encode_terminal_code): Likewise.
6be7d3da 13622
75f8807f 13623 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13624
50938595
PE
13625 * tparam.h: New file.
13626 * term.c, tparam.h: Include it.
13627 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13628 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13629 Move these decls to tparam.h, and make them agree with what
13630 is actually in tparam.c. The previous trick of using incompatible
13631 decls in different modules does not conform to the C standard.
13632 All callers of tparam changed to use tparam's actual API.
13633 * tparam.c (tparam1, tparam, tgoto):
13634 Use const pointers where appropriate.
13635
fbceeba2
PE
13636 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13637 * cm.h (struct cm): Likewise.
13638 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13639 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13640 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13641 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13642 (turn_on_face, init_tty): Likewise.
13643 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13644
7f3f1250
PE
13645 * term.c (term_mouse_position): Rename local to avoid shadowing.
13646
e6ca6543
PE
13647 * alloc.c (mark_ttys): Move decl from here ...
13648 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13649
c40f8d15
AS
136502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13651
13652 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13653
cfe0661d
JB
136542011-03-09 Juanma Barranquero <lekktu@gmail.com>
13655
13656 * search.c (compile_pattern_1): Remove argument regp, unused since
13657 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13658 (compile_pattern): Don't pass it.
13659
0afb4571
J
136602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13661
13662 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13663 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13664 for ! HAVE_GTK3.
13665 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13666
13667 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13668
13669 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13670 gdk_window_get_screen, gdk_window_get_geometry,
13671 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13672 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13673 (xg_get_pixbuf_from_pixmap): New function.
13674 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13675 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13676 Call xg_get_pixbuf_from_pixmap instead of
13677 gdk_pixbuf_get_from_drawable.
13678 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13679 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13680 (xg_check_special_colors): Use GtkStyleContext and its functions
13681 for HAVE_GTK3.
13682 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13683 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13684 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13685 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13686 Call gtk_widget_get_preferred_size.
0afb4571
J
13687 (xg_frame_resized): gdk_window_get_geometry only takes 5
13688 parameters.
44f230aa
SM
13689 (xg_win_to_widget, xg_event_is_for_menubar):
13690 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13691 (xg_set_widget_bg): New function.
13692 (delete_cb): New function.
895009e1 13693 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13694 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13695 (xg_set_background_color): Call xg_set_widget_bg.
13696 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13697 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13698 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13699 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13700 if ! HAVE_GTK3.
13701 (update_frame_tool_bar): Call gtk_widget_hide.
13702 (xg_initialize): Use GDK_KEY_g.
13703
13704 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13705 if ! HAVE_GTK3
13706 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13707
13708 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13709 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13710 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13711
1c2cc4ef
JB
137122011-03-08 Juanma Barranquero <lekktu@gmail.com>
13713
13714 * w32xfns.c (select_palette): Check success of RealizePalette against
13715 GDI_ERROR, not zero.
13716
33383987 13717See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13718
13719;; Local Variables:
13720;; coding: utf-8
aac0c6e3
MR
13721;; End:
13722
2f097256 13723 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13724
13725 This file is part of GNU Emacs.
13726
13727 GNU Emacs is free software: you can redistribute it and/or modify
13728 it under the terms of the GNU General Public License as published by
13729 the Free Software Foundation, either version 3 of the License, or
13730 (at your option) any later version.
13731
13732 GNU Emacs is distributed in the hope that it will be useful,
13733 but WITHOUT ANY WARRANTY; without even the implied warranty of
13734 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13735 GNU General Public License for more details.
13736
13737 You should have received a copy of the GNU General Public License
13738 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.