Prevent sluggish bidi redisplay in small windows.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
80ad64f4
EZ
12011-09-10 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4 redisplay in small windows.
5
208a048d
EZ
62011-09-09 Eli Zaretskii <eliz@gnu.org>
7
8 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
9
9b1c252e
MR
102011-09-08 Martin Rudalics <rudalics@gmx.at>
11
12 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
13 Operate on live windows only.
14
2949f33b
JB
152011-09-08 Juanma Barranquero <lekktu@gmail.com>
16
17 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
18
e08dcafd
EZ
192011-09-07 Eli Zaretskii <eliz@gnu.org>
20
21 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
22 only under bidi iteration.
23
115b96bd
JD
242011-09-07 Jan Djärv <jan.h.d@swipnet.se>
25
26 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
27
c8199d0f
PE
282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
29
30 isnan: Fix porting problem to Solaris 10 with bundled gcc.
31 Without this fix, the command to link temacs failed due to an
32 undefined symbol __builtin_isnan. This is because
33 /usr/include/iso/math_c99.h #defines isnan(x) to
34 __builtin_isnan(x), but the bundled gcc, which identifies itself
35 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
36 a __builtin_isnan.
37 * floatfns.c (isnan): #undef, and then #define to a clone of
38 what's in data.c.
39 (Fisnan): Always define, since it's always available now.
40 (syms_of_floatfns): Always define isnan at the Lisp level.
41
e39b275c 422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
43
44 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
45
b2db44d9 462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 47
f4af5137 48 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
49 The previous code assumed that file offsets (off_t values) fit in
50 EMACS_INT variables, which is not true on typical 32-bit hosts.
51 The code messed up by falsely reporting buffer overflow in cases
52 such as (insert-file-contents "big" nil 1 2) into an empty buffer
53 when "big" contains more than 2**29 bytes, even though this
54 inserts just one byte and does not overflow the buffer.
55 (Finsert_file_contents): Store file offsets as off_t
56 values, not as EMACS_INT values. Check for overflow when
57 converting between EMACS_INT and off_t. When checking for
58 buffer overflow or for overlap, take the offsets into account.
59 Don't use EMACS_INT for small values where int suffices.
60 When checking for overlap, fix a typo: ZV was used where
61 ZV_BYTE was intended.
62 (Fwrite_region): Don't assume off_t fits into 'long'.
63 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
64
ecfc0a49
MA
652011-09-05 Michael Albinus <michael.albinus@gmx.de>
66
67 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
68
6511acf2 692011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 70
0999621a 71 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
72
73 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 74 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
75 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
76 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
77 (modify_event_symbol): Do not assume that the length of
78 name_alist_or_stem is safe to alloca and fits in int.
79 (Fexecute_extended_command): Likewise for function name and binding.
80 (Frecursion_depth): Wrap around reliably on integer overflow.
81 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
82 since some callers pass EMACS_INT values.
83 (Fsingle_key_description): Don't crash if symbol name contains more
84 than MAX_ALLOCA bytes.
85 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
86 (get_minibuffer): Arg is now EMACS_INT, not int.
87 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 88 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
89 * window.h (command_loop_level, minibuf_level): Reflect API changes.
90
2be7d702
PE
91 * dbusbind.c (signature_cat): New function.
92 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
93 Do not overrun buffer; instead, report string overflow.
94
9d1df220
PE
95 * dispnew.c (add_window_display_history): Don't overrun buffer.
96 Truncate instead; this is OK since it's just a log.
97
33ef5c64
PE
98 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
99 even if the time zone offset is outlandishly large.
100 Don't mishandle offset == INT_MIN.
101
66c6fdd5
PE
102 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
103 when creating daemon; the previous buffer-overflow check was incorrect.
104
d749b01b
PE
105 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
106 which has the guts of the old verror function.
107
b5cd1905
PE
108 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
109 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
110
6e1a67fb
PE
111 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
112 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 113 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 114 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
115 length of string rather than counting it via multiple sprintfs;
116 that's simpler and more reliable.
c21721cc
PE
117 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
118 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
119 sprintf, in case result does not fit in int.
120
c57b67fc
PE
121 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
122 (fontset_from_font): Print it.
123
8a401434
PE
124 * frame.c (tty_frame_count): Now printmax_t, not int.
125 (make_terminal_frame, set_term_frame_name): Print it.
126 (x_report_frame_params): In X, window IDs are unsigned long,
127 not signed long, so print them as unsigned.
128 (validate_x_resource_name): Check for implausibly long names,
129 and don't assume name length fits in 'int'.
130 (x_get_resource_string): Don't blindly alloca invocation name;
131 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
132 not fit in int.
133
6e1a67fb
PE
134 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
135 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
136 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
137
0df02bf3
PE
138 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
139 Use esprintf, not sprintf, in case result does not fit in int.
140
48e30793
PE
141 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
142 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
143 it as a large positive number.
144 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
145 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
146
a66ff6d8
PE
147 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
148 in case result does not fit in int.
149
aca216ff
PE
150 * print.c (float_to_string): Detect width overflow more reliably.
151 (print_object): Make sprintf buffer a bit bigger, to avoid potential
152 buffer overrun. Don't assume list length fits in 'int'. Treat
153 print length of 0 as 0, not as infinity; to be consistent with other
154 uses of print length in this function. Don't overflow print length
155 index. Don't assume hash table size fits in 'long', or that
156 vectorlike size fits in 'unsigned long'.
157
31c286f7
PE
158 * process.c (make_process): Use printmax_t, not int, to format
159 process-name gensyms.
160
55e5faa1
PE
161 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
162
80f2e268
PE
163 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
164 to avoid potential buffer overrun.
165
670741ab
PE
166 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
167 if X resource line is longer than 512 bytes.
168
b7163a50
PE
169 * xfns.c (x_window): Make sprintf buffer a bit bigger
170 to avoid potential buffer overrun.
171
ae58ff1f
PE
172 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
173
c43c8a6a
PE
174 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
175
3f8236f4
PE
1762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
177
53e9fe90 178 Integer overflow fixes for scrolling, etc.
6511acf2
PE
179 Without these, Emacs silently mishandles large integers sometimes.
180 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
181 it were "C-u 1 M-x recenter" on a typical 64-bit host.
182
6511acf2
PE
183 * xdisp.c (try_window_id): Check Emacs fixnum range before
184 converting to 'int'.
806add1d 185
6511acf2 186 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
187 Check that an Emacs fixnum is in range before assigning it to 'int'.
188 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
189 values converted from Emacs fixnums.
190 (Frecenter): Don't wrap around a line count if it is out of 'int'
191 range; instead, treat it as an extreme value.
192 (Fset_window_configuration, compare_window_configurations):
193 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
194
6511acf2
PE
195 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
196 that can exceed INT_MAX. Check that EMACS_INT value is in range
197 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
198 (match_limit): Don't assume that a fixnum can fit in 'int'.
199
6511acf2 200 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
201 exceed INT_MAX.
202
6511acf2 203 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
204 (Fvertical_motion): Don't wrap around LINES values that don't fit
205 in 'int'. Instead, treat them as extreme values. This is good
206 enough for windows, which can't have more than INT_MAX lines anyway.
207
fcb901a7
LMI
2082011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
209
0f2f6b6d
LMI
210 * Require libxml/parser.h to avoid compilation warning.
211
fcb901a7
LMI
212 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
213
214 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
215 since this reportedly can destroy thread storage.
216
6e20a0d4
CY
2172011-08-30 Chong Yidong <cyd@stupidchicken.com>
218
219 * syntax.c (find_defun_start): Update all cache variables if
220 exiting early (Bug#9401).
221
148ae00e
EZ
2222011-08-30 Eli Zaretskii <eliz@gnu.org>
223
f6cfbd8f
EZ
224 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
225
148ae00e
EZ
226 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
227 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
228 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
229
230 * term.c (tty_append_glyph): New function.
231 (produce_stretch_glyph): Static function and its prototype deleted.
232
233 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
234 prototypes.
235
c4a07a4c
PE
2362011-08-29 Paul Eggert <eggert@cs.ucla.edu>
237
238 * image.c (parse_image_spec): Check for nonnegative, not for positive,
239 when checking :margin (Bug#9390).
240 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
241 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
242 so that the name doesn't mislead. All uses changed.
243
6bc8cd65
JB
2442011-08-28 Johan Bockgård <bojohan@gnu.org>
245
246 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
247 set_tty_hooks.
248
dca4927e
EZ
2492011-08-27 Eli Zaretskii <eliz@gnu.org>
250
251 * xdisp.c (move_it_to): Don't bail out early when reaching
252 position beyond to_charpos, if we are scanning backwards.
253 (move_it_vertically_backward): When DY == 0, make sure we get to
254 the first character in the line after the newline.
255
f2cad773
PE
2562011-08-27 Paul Eggert <eggert@cs.ucla.edu>
257
258 * ccl.c: Improve and simplify overflow checking (Bug#9196).
259 (ccl_driver): Do not generate an out-of-range pointer.
260 (Fccl_execute_on_string): Remove unnecessary check for
261 integer overflow, noted by Stefan Monnier in
262 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
263 Remove a FIXME that didn't need fixing.
264 Simplify the newly-introduced buffer reallocation code.
265
0cae2cdb
JB
2662011-08-27 Juanma Barranquero <lekktu@gmail.com>
267
268 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
269
5fc295a4 2702011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 271
70c60eb2 272 Integer and memory overflow issues (Bug#9196).
726e0ab1 273
d31850da
PE
274 * doc.c (get_doc_string): Rework so that
275 get_doc_string_buffer_size is the actual buffer size, rather than
276 being 1 less than the actual buffer size; this makes xpalloc more
277 convenient.
278
a69fbedb
PE
279 * image.c (x_allocate_bitmap_record, cache_image):
280 * xselect.c (Fx_register_dnd_atom):
281 Simplify previous changes by using xpalloc.
282
fe5c5d37
PE
283 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
284 since either will do and ptrdiff_t is convenient with xpalloc.
285
0065d054
PE
286 * charset.c (charset_table_size)
287 (struct charset_sort_data.priority): Now ptrdiff_t.
288 (charset_compare): Don't overflow if priorities differ greatly.
289 (Fsort_charsets): Don't assume list length fits in int.
290 Check for size-calculation overflow when allocating sort data.
291 (syms_of_charset): Allocate an initial charset table that is
292 just under 64 KiB, to avoid problems with glibc malloc and mmap.
293
294 * cmds.c (internal_self_insert): Check for size-calculation overflow.
295
296 * composite.h (struct composition.glyph_len): Now int, not unsigned.
297 The actual value is always <= INT_MAX, and leaving it unsigned made
298 overflow checking harder.
299
300 * dispextern.h (struct glyph_matrix.rows_allocated)
301 (struct face_cache.size): Now ptrdiff_t, for convenience in use
302 with xpalloc. The values are still always <= INT_MAX.
303
304 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
305
306 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
307 (SAFE_NALLOCA): New macro.
308
309 * region-cache.c (struct boundary.pos, find_cache_boundary)
310 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
311 (set_cache_region, invalidate_region_cache)
312 (revalidate_region_cache, know_region_cache, region_cache_forward)
313 (region_cache_backward, pp_cache):
314 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
315 so that ptrdiff_t * can be passed to xpalloc.
316 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
317 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
318 (pp_cache): Don't assume cache_len fits in int.
319 * region-cache.h: Adjust extern decls to match.
320
321 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
322 EMACS_INT, since either will do, for xpalloc.
323
324 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
325 (xnmalloc, xnrealloc, xpalloc): New functions.
326
726e0ab1
PE
327 * bidi.c (bidi_shelve_header_size): New constant.
328 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
329 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
330
51f30bc5 331 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
332 * buffer.c (overlays_at, overlays_in, record_overlay_string)
333 (overlay_strings):
334 Don't update size of array until after memory allocation succeeds,
335 because xmalloc/xrealloc may not return.
0065d054
PE
336 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
337 now that we have proper integer overflow checking.
338 (record_overlay_string, overlay_strings): Catch overflows when
339 calculating size of overlay_str_buf.
726e0ab1 340
0065d054
PE
341 * callproc.c (Fcall_process): Check for size overflow when
342 calculating size of args2.
343 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
344 Normally we prefer signed values, but sticking with ptrdiff_t would
345 require adding more-complicated checks.
726e0ab1
PE
346
347 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
348 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
349 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 350 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
351
352 * character.c (Fstring): Check for size-calculation overflow.
353
354 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
355 unnecessary integer overflow. Check for size overflow.
356 (encode_coding_object): Don't update size until xmalloc succeeds.
357
358 * composite.c (get_composition_id): Check for overflow in glyph
359 length calculations.
360
361 Integer and memory overflow fixes for display code.
362 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
363 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
364 (scrolling_window): Check for overflow in size calculations.
365 (line_draw_cost, realloc_glyph_pool, add_row_entry):
366 Don't assume glyph table len fits in int.
367 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
368 (row_table_size): Now ptrdiff_t, not int.
369 (scrolling_window): Avoid overflow in size calculations.
370 Don't update size until allocation succeeds.
371 * fns.c (concat): Check for overflow in size calculations.
372 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
373 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
374 (NEXT_ALMOST_PRIME_LIMIT): New constant.
375
376 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
377 (get_doc_string): Check for size calculation overflow.
378 Don't update size until allocation succeeds.
379 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
380 EMACS_INT, where ptrdiff_t will do.
381 (Fsubstitute_command_keys): Check for string overflow.
382
383 * editfns.c (set_time_zone_rule): Don't assume environment length
384 fits in int.
385 (message_length): Now ptrdiff_t, not int.
386 (Fmessage_box): Don't update size until allocation succeeds.
387 Don't assume message length fits in int.
388 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
389
0065d054
PE
390 * emacs.c (main): Do not reallocate argv, since there is a null at
391 the end that can be overwritten, and this way there's no need to
392 worry about size-calculation overflow.
393 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
394
395 * eval.c (init_eval_once, grow_specpdl): Don't update size until
396 alloc succeeds.
397 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
398
399 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
400 (x_set_scroll_bar_width, x_figure_window_size):
401 Check for integer overflow.
402 (x_set_alpha): Do not assume XINT fits in int.
403
404 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
405 This is for the members text_lines, text_cols, total_lines, total_cols,
406 where the system imposes an 'int' limit.
407
408 * fringe.c (Fdefine_fringe_bitmap):
409 Don't update size until alloc works.
410
411 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
412 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
413
414 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
415 Check for size-calculation overflow.
416 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
417 do, as we prefer signed integers.
418 (id_to_widget.max_size, id_to_widget.used)
419 (xg_store_widget_in_map, xg_remove_widget_from_map)
420 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
421 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
422 Use and return ptrdiff_t, not int.
423 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
424 * gtkutil.h: Change prototypes to match the above.
425
426 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
427 are duplicate now that they've been promoted to lisp.h.
428 (x_allocate_bitmap_record, x_alloc_image_color)
429 (make_image_cache, cache_image, xpm_load):
430 Don't update size until alloc is done.
431 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
432 (x_detect_edges):
3256efce 433 Check for size calculation overflow.
726e0ab1
PE
434 (ct_colors_allocated_max): New constant.
435 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
436 overflow.
3256efce 437
726e0ab1
PE
438 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
439 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
440 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
441 Use ptrdiff_t, not int, to count maps.
442 (read_char_minibuf_menu_prompt): Check for overflow in size
443 calculations. Don't update size until allocation succeeds. Redo
444 calculations to avoid overflow.
445 * keyboard.h: Change prototypes to match the above.
446
447 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
448 to count maps.
449 (current_minor_maps): Check for size calculation overflow.
450 * keymap.h: Change prototypes to match the above.
451
452 * lread.c (read1, init_obarray): Don't update size until alloc done.
453
454 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
455 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
456
726e0ab1
PE
457 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
458 Now ptrdiff_t, not int.
459 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
460 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
461
462 * process.c (Fnetwork_interface_list): Check for overflow
463 in size calculation.
464
465 * region-cache.c (move_cache_gap): Check for size calculation overflow.
466
467 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
468 overflow. Don't bother calling xmalloc when xrealloc will do.
469
470 * search.c (Freplace_match): Check for size calculation overflow.
471 (Fset_match_data): Don't assume list lengths fit in 'int'.
472
473 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
474 for command line length. Do not attempt to address one before the
475 beginning of an array, as that's not portable.
476
477 * term.c (max_frame_lines): Remove; unused.
478 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
479 not int.
480 (encode_terminal_code, calculate_costs): Check for size
481 calculation overflow.
482 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
483 table lengths and related sizes. Don't update size until alloc
484 done. Redo calculations to avoid overflow.
485 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
486
487 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
488 subtracting pointers.
489 (gobble_line): Check for overflow more carefully. Don't update size
490 until alloc done.
491
492 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
493 Don't update size until alloc done.
494 Redo size calculations to avoid overflow.
495 Check for size calculation overflow.
0065d054 496 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
497
498 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
499 Use ptrdiff_t, not int, for sizes.
500 (store_mode_line_noprop_char): Don't update size until alloc done.
501
0065d054
PE
502 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
503 Use ptrdiff_t, not int, for sizes.
504 (Finternal_make_lisp_face, cache_face):
505 Check for size calculation overflow.
506 (cache_face): Treat size calculation overflows as if they were
507 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
508
509 * xfns.c (x_encode_text, x_set_name_internal)
510 (Fx_change_window_property): Use ptrdiff_t, not int, to count
511 sizes, since they can exceed INT_MAX in size. Check for size
512 calculation overflow.
513
0065d054
PE
514 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
515 (xg_select): Check for size calculation overflow.
726e0ab1
PE
516 Don't update size until alloc done.
517
0065d054 518 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 519 as sprintf is limited to int lengths.
1d526e2f 520
252c5ee1
PE
521 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
522 (X_LONG_MIN): New macros.
864d7ce7
PE
523 Use them to make the following changes clearer.
524 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
525 This change doesn't affect the value now, but it may help remind
526 future maintainers not to raise the value too much later.
527 (SELECTION_QUANTUM): Remove, replacing with ...
528 (selection_quantum): ... new function, which avoids overflow.
529 All uses changed.
530 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
531 assumption that selection length fits in 'int'.
532 (x_reply_selection_request, x_handle_selection_request)
533 (x_get_window_property, receive_incremental_selection)
534 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
535 (lisp_data_to_selection_data, clean_local_selection_data):
536 Use ptrdiff_t, not int, to record length of selection.
537 (x_reply_selection_request, x_get_window_property)
538 (receive_incremental_selection, x_property_data_to_lisp):
539 Redo calculations to avoid overflow.
540 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 541 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
542 something.
543 (x_get_window_property, receive_incremental_selection)
544 (lisp_data_to_selection_data, x_property_data_to_lisp):
545 Check for size-calculation overflow.
546 (x_get_window_property, receive_incremental_selection)
547 (lisp_data_to_selection_data, Fx_register_dnd_atom):
548 Don't store size until memory allocation succeeds.
549 (x_get_window_property): Plug memory leak on memory exhaustion.
550 Don't double-block input; malloc is safe here. Don't assume 2**34
551 - 4 fits in unsigned long. Add an xassert to check
552 XGetWindowProperty overflow. Be more careful about overflow
553 calculations, and distinguish size from memory overflow better.
554 (receive_incremental_selection): When tracing, don't assume
555 unsigned int is less than INT_MAX.
556 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
557 harmful) conversions of unsigned short to int.
558 (lisp_data_to_selection_data): Don't assume that integers
559 in the range -65535 through -1 fit in an X unsigned short.
560 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
561 result parameters unless successful. Rely on cons_to_unsigned
562 to report problems with elements; the old code wasn't right anyway.
563 (x_check_property_data): Check for int overflow; we cannot use
564 a wider type due to X limits.
565 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
566
726e0ab1 567 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 568
0065d054
PE
569 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
570 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
571 (x_color_cells): Don't store size until memory allocation succeeds.
572 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 573 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
574 (x_term_init): Don't assume length fits in int (sprintf is limited
575 to int size).
bc18e09d 576
ebfa62c0
PE
577 Use ptrdiff_t for composition IDs.
578 * character.c (lisp_string_width):
579 * composite.c (composition_table_size, n_compositions)
580 (get_composition_id, composition_gstring_from_id):
581 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
582 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
583 * window.c (Frecenter):
584 Use ptrdiff_t, not int, for composition IDs.
585 * composite.c (get_composition_id): Check for integer overflow.
586 * composite.h: Adjust prototypes to match the above changes.
587
d3411f89
PE
588 Use ptrdiff_t for hash table indexes.
589 * category.c (hash_get_category_set):
590 * ccl.c (ccl_driver):
591 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
592 * coding.c (coding_system_charset_list, detect_coding_system):
593 * coding.h (struct coding_system.id):
594 * composite.c (get_composition_id, gstring_lookup_cache):
595 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
596 * image.c (xpm_get_color_table_h):
597 * lisp.h (hash_lookup, hash_put):
598 * minibuf.c (Ftest_completion):
599 Use ptrdiff_t for hash table indexes, not int (which is too
600 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
601 32-bit --with-wide-int hosts).
602
e097a6fa
PE
603 * charset.c (Fdefine_charset_internal): Check for integer overflow.
604 Add a FIXME comment about memory leaks.
605 (syms_of_charset): Don't assume xmalloc returns.
606
5637687f
PE
607 Don't assume that stated character widths fit in int.
608 * character.c (Fchar_width, c_string_width, lisp_string_width):
609 * character.h (CHAR_WIDTH):
610 * indent.c (MULTIBYTE_BYTES_WIDTH):
611 Use sanitize_char_width to avoid undefined and/or bad behavior
612 with outlandish widths.
613 * character.h (sanitize_tab_width): Renamed from sanitize_width,
614 now that we have two such functions. All uses changed.
615 (sanitize_char_width): New inline function.
616
a2271ba2
PE
617 Don't assume that tab-width fits in int.
618 * character.h (sanitize_width): New inline function.
619 (SANE_TAB_WIDTH): New macro.
620 (ASCII_CHAR_WIDTH): Use it.
621 * indent.c (sane_tab_width): Remove. All uses replaced by
622 SANE_TAB_WIDTH (current_buffer).
623 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
624
18c52557
PE
625 * fileio.c: Integer overflow issues with file modes.
626 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
627
caeeedc1
PE
628 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
629 Remove unreachable code.
630 (read_hex, load_charset_map_from_file): Check for integer overflow.
631
50849c52
PE
632 * xterm.c: don't go over XClientMessageEvent limit
633 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
634 (x_send_scroll_bar_event): Likewise. Check that the size does not
635 exceed limits imposed by XClientMessageEvent, as well as the usual
636 ptrdiff_t and size_t limits.
637
b13995db
PE
638 * keyboard.c: Overflow, signedness and related fixes.
639 (make_lispy_movement): Use same integer type in forward decl
640 that is used in the definition.
641 (read_key_sequence, keyremap_step):
642 Change bufsize argument back to int, undoing my 2011-03-30 change.
643 We prefer signed types, and int is wide enough here.
644 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
645 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
646 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
647 length, not size_t. Use ptrdiff_t for index, not int.
648 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
649 possibility of integer overflow.
650
13464394
PE
651 Overflow, signedness and related fixes for images.
652
653 * dispextern.h (struct it.stack[0].u.image.image_id)
654 (struct_it.image_id, struct image.id, struct image_cache.size)
655 (struct image_cache.used, struct image_cache.ref_count):
656 * gtkutil.c (update_frame_tool_bar):
657 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
658 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
659 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
660 * nsmenu.m (update_frame_tool_bar):
661 * xdisp.c (calc_pixel_width_or_height):
662 * xfns.c (image_cache_refcount):
663 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
664 on typical 64-bit hosts.
665
666 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
667 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
668 Omit unnecessary casts to int.
669 (parse_image_spec): Check that integers fall into 'int' range
670 when the callers expect that.
671 (image_ascent): Redo ascent calculation to avoid int overflow.
672 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
673 (lookup_image): Remove unnecessary tests.
674 (xbm_image_p): Locals are now of int, not EMACS_INT,
675 since parse_image_check makes sure they fit into int.
676 (png_load, gif_load, svg_load_image):
677 Prefer int to unsigned where either will do.
678 (tiff_handler): New function, combining the cores of the
679 old tiff_error_handler and tiff_warning_handler. This
680 function is rewritten to use vsnprintf and thereby avoid
681 stack buffer overflows. It uses only the features of vsnprintf
682 that are common to both POSIX and native Microsoft.
683 (tiff_error_handler, tiff_warning_handler): Use it.
684 (tiff_load, gif_load, imagemagick_load_image):
685 Don't assume :index value fits in 'int'.
686 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
687 (imagemagick_load_image): Check that crop parameters fit into
688 the integer types that MagickCropImage accepts. Don't assume
689 Vimagemagick_render_type has a nonnegative value. Don't assume
690 size_t fits in 'long'.
691 (gs_load): Use printmax_t to print the widest integers possible.
692 Check for integer overflow when computing image height and width.
693
c11821d4
EZ
6942011-08-26 Eli Zaretskii <eliz@gnu.org>
695
696 * xdisp.c (redisplay_window): Don't force window start if point
697 will be invisible in the resulting window. (Bug#9324)
698
0c95fcf7
EZ
6992011-08-25 Eli Zaretskii <eliz@gnu.org>
700
701 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
702 the display spec is of the form `(space ...)'.
703 (handle_display_spec): Return the value returned by
704 handle_single_display_spec, not just 1 or zero.
705 (handle_single_display_spec): If the display spec is of the form
706 `(space ...)', and specifies display in the text area, return 2
707 rather than 1.
fee65a97 708 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
709 accurately, and prefer exact match for point under bidi. Don't
710 advance `row' beyond the last row of the window.
0c95fcf7
EZ
711
712 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
713 into disp_prop; all users changed.
714
715 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
716 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
717 for the text covered by the display property.
718
e4ed06f1
CY
7192011-08-25 Chong Yidong <cyd@stupidchicken.com>
720
721 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
722 Change return value to nil.
723 (Frecord_buffer): Delete unused function.
724
f67cdd7f
EZ
7252011-08-24 Eli Zaretskii <eliz@gnu.org>
726
5980d4c6
EZ
727 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
728 buffers, return left-to-right.
8610fe8b
EZ
729 (set_cursor_from_row): Consider candidate row a win if its glyph
730 represents a newline and point is on that newline. Fixes cursor
731 positioning on the newline at EOL of R2L text within L2R
732 paragraph, and vice versa.
733 (try_cursor_movement): Check continued rows, in addition to
734 continuation rows. Fixes unwarranted scroll when point enters a
735 continued line of R2L text within an L2R paragraph, or vice versa.
736 (cursor_row_p): Consider the case of point being equal to
737 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
738 from the end of a short line to the beginning of a continued line
739 of R2L text within L2R paragraph.
740 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
741 composed characters.
5980d4c6 742
f67cdd7f
EZ
743 * bidi.c (bidi_check_type): Use xassert.
744 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
745 members.
746
bca633fb
EZ
7472011-08-23 Eli Zaretskii <eliz@gnu.org>
748
749 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
750 a character.
751
4a5885a7
CY
7522011-08-23 Chong Yidong <cyd@stupidchicken.com>
753
754 * nsfont.m (ns_otf_to_script): Fix typo.
755
0902a04e
KH
7562011-08-22 Kenichi Handa <handa@m17n.org>
757
758 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
759 extra slot even if the purpose is char-code-property-table.
760
1a2e6670
EZ
7612011-08-23 Eli Zaretskii <eliz@gnu.org>
762
8ddde651
EZ
763 * xdisp.c (redisplay_window): When computing centering_position,
764 account for the height of the header line. (Bug#8874)
765
425cc014
EZ
766 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
767 instead of CHAR_TO_BYTE. Fixes a crash when a completion
768 candidate is selected by the mouse, and that candidate has a
769 composed character under the mouse.
770
1a2e6670
EZ
771 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
772 coordinates reported by pos-visible-in-window-p for a composed
773 character in column zero.
774
8b76d6f8
SM
7752011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
776
777 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
778
dac347dd
EZ
7792011-08-22 Eli Zaretskii <eliz@gnu.org>
780
781 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
782 consider it a hit if to_charpos is anywhere in the range of the
783 composed buffer positions.
784
e013fb34
CY
7852011-08-22 Chong Yidong <cyd@stupidchicken.com>
786
787 * image.c (gif_load): Don't assume that each subimage has the same
788 dimensions as the base image. Handle disposal method that is
789 "undefined" by the gif spec (Bug#9335).
790
bd1ba3e8
CY
7912011-08-20 Chong Yidong <cyd@stupidchicken.com>
792
793 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 794 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 795
54a1215b
EZ
7962011-08-19 Eli Zaretskii <eliz@gnu.org>
797
823564e5
EZ
798 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
799 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
800 from an Org mode buffer to a Speedbar frame.
801
54a1215b
EZ
802 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
803 a composition, take its buffer position from IT->cmp_it.charpos.
804 Fixes cursor positioning at the beginning of a line that begins
805 with a composed character.
806
9778ebcc
EZ
8072011-08-18 Eli Zaretskii <eliz@gnu.org>
808
0be6ee06
EZ
809 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
810 character bidirectional type, use STRONG_L instead. Fixes crashes
811 in a buffer produced by `describe-categories'.
812
9778ebcc
EZ
813 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
814 members before the level stack, so they would be saved and
815 restored when copying iterator state. Fixes incorrect reordering
816 around TABs covered by display properties.
817
156bffbe
AS
8182011-08-18 Andreas Schwab <schwab@linux-m68k.org>
819
820 * process.c (Fnetwork_interface_list): Correctly determine buffer
821 size.
822
72ad093b
CY
8232011-08-17 Chong Yidong <cyd@stupidchicken.com>
824
825 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
826 (internal_condition_case_2, internal_condition_case_n):
827 Remove unnecessary aborts (Bug#9081).
72ad093b 828
35774242
EZ
8292011-08-17 Eli Zaretskii <eliz@gnu.org>
830
831 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
832 has no `load' handler, try opening the file locally. (Bug#9311)
833
db76dd85
KB
8342011-08-16 Ken Brown <kbrown@cornell.edu>
835
836 * gmalloc.c: Expand comment.
837
b215eee5
EZ
8382011-08-16 Eli Zaretskii <eliz@gnu.org>
839
840 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
841 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
842
a4579d33
KB
8432011-08-16 Ken Brown <kbrown@cornell.edu>
844
845 Fix memory allocation problems in Cygwin build (Bug#9273).
846
847 * unexcw.c ( __malloc_initialized): Declare external variable.
848 (fixup_executable): Force the dumped emacs to reinitialize malloc.
849
8b76d6f8
SM
850 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
851 New variables.
a4579d33
KB
852 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
853 dumped emacs.
854 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
855 in the static heap.
856 [CYGWIN] (special_realloc): New function.
857 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
858 requests to realloc storage in the static heap.
859
3ebec551
PE
8602011-08-15 Paul Eggert <eggert@cs.ucla.edu>
861
862 * bidi.c (bidi_initialize): Remove unused local.
863
9fd8be00
EZ
8642011-08-15 Eli Zaretskii <eliz@gnu.org>
865
474a8465
EZ
866 * biditype.h: File removed.
867
868 * bidimirror.h: File removed.
869
870 * deps.mk (bidi.o): Remove biditype.h and
871 bidimirror.h.
872
873 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
874 bidimirror.h.
875
876 * dispextern.h: Fix a typo in the comment to bidi_type_t.
877
878 * chartab.c: Improve commentary for the uniprop_table API.
879
32413314
EZ
880 * bidi.c (bidi_paragraph_init): Support zero value of
881 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
882 (bidi_initialize): Use uniprop_table instead of including
883 biditype.h and bidimirror.h.
32413314 884
9fd8be00
EZ
885 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
886 coordinates of the iterator when restoring from ppos_it.
887 (Bug#9296)
888
5cf2b69b
KH
8892011-08-14 Kenichi Handa <handa@m17n.org>
890
891 * process.c (create_process): Call setup_process_coding_systems
72ad093b 892 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 893
daf17d00
EZ
8942011-08-14 Eli Zaretskii <eliz@gnu.org>
895
896 * xdisp.c (move_it_in_display_line_to): Don't invoke
897 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
898 ppos_it. Fixes vertical cursor motion when line beginning is
899 covered by an image. (Bug#9296)
900
08e3161a
JD
9012011-08-14 Jan Djärv <jan.h.d@swipnet.se>
902
903 * nsterm.h (ns_run_ascript): Declare.
904 (NSAPP_DATA2_RUNASSCRIPT): Define.
905
906 * nsfns.m (as_script, as_result, as_status): New static variables.
907 (ns_run_ascript): New function.
5e617bc2 908 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
909 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
910 the event loop. Get status from as_status (Bug#7276).
911
912 * nsterm.m (sendEvent): If event is NSApplicationDefined and
913 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
914 the event loop (Bug#7276).
915
a3720aa2
AS
9162011-08-14 Andreas Schwab <schwab@linux-m68k.org>
917
918 * gnutls.c (QCgnutls_bootprop_priority)
919 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
920 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
921 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
922 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
923 (QCgnutls_bootprop_verify_hostname_error)
924 (QCgnutls_bootprop_callbacks_verify): Rename from
925 Qgnutls_bootprop_..., all uses changed.
926
927 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
928 uses changed.
929
0a0d27fb
PE
9302011-08-14 Paul Eggert <eggert@cs.ucla.edu>
931
19d5c50c
PE
932 * xfaces.c (Qframe_set_background_mode): Now static.
933 * dispextern.h (Qframe_set_background_mode): Remove decl.
934
0a0d27fb
PE
935 * process.c (Fnetwork_interface_info): Declare local only if needed.
936
377538cb
JD
9372011-08-13 Jan Djärv <jan.h.d@swipnet.se>
938
939 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
940 (Fnetwork_interface_list): Allocate in increments of bytes instead
941 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
942 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
943 sockaddr.
944 (struct ifflag_def): notrailers is smart on OSX.
945 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
946 Get hardware address with getifaddrs if available.
947
08fff70c
EZ
9482011-08-12 Eli Zaretskii <eliz@gnu.org>
949
950 * xdisp.c (iterate_out_of_display_property): xassert that
951 IT->position is set to within IT->object's boundaries. Break from
952 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
953 when IT->position is set up wrongly due to some bug.
954 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
955 (push_display_prop): Allow GET_FROM_STRING as IT->method on
956 entry. Force push_it to save on the stack the current
957 buffer/string position, to be restored by pop_it. Fix flags in
958 the iterator structure wrt the object coming from a display
959 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
960 properties. (Bug#9284)
961
7be1c708 9622011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 963
7be1c708
CY
964 * fontset.c (fontset_get_font_group): Add proper type checks.
965 (Bug#9172)
aac0c6e3 966
7be1c708 9672011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 968
7be1c708
CY
969 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
970 and LC_VERSION_MIN_MACOSX.
971 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
972 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 973
97bb72a6
EZ
9742011-08-08 Eli Zaretskii <eliz@gnu.org>
975
976 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
977 no-display-properties-and-no-overlays under bidi display.
978 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 979 properties and overlays.
97bb72a6 980
d5617611
CY
9812011-08-08 Chong Yidong <cyd@stupidchicken.com>
982
37e11a63
CY
983 * editfns.c (Fset_time_zone_rule): Document relationship with the
984 setenv function.
985
d5617611
CY
986 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
987 the font entity extracted from the cache (Bug#8109).
988
58872834
CY
9892011-08-07 Chong Yidong <cyd@stupidchicken.com>
990
991 * composite.c (autocmp_chars): Don't reset point. That is done by
992 restore_point_unwind (Bug#5984).
993
75bfc667
JL
9942011-08-07 Juri Linkov <juri@jurta.org>
995
996 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
997 to show the arg `TIME' instead of `TIMEVAL'.
998
d1410150
EZ
9992011-08-06 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1002 display property strides EOL and includes a newline, as in
1003 longlines-mode. (Bug#9254)
75b771e4
EZ
1004 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1005 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1006
1007 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1008 is non-zero, even if the data buffer is NULL. Fixes a crash in
1009 vertical-motion with longlines-mode. (Bug#9254)
1010
35928349
EZ
10112011-08-05 Eli Zaretskii <eliz@gnu.org>
1012
ec7cc85b
EZ
1013 * bidi.c <bidi_cache_total_alloc>: Now static.
1014 (bidi_initialize): Initialize bidi_cache_total_alloc.
1015
8b76d6f8 1016 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1017 cache. (Bug#9221)
1018
1019 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1020 amount allocated this far in `bidi_cache_total_alloc'.
1021 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1022 non-zero, only free the data buffer without restoring the cache
1023 contents. All callers changed.
1024
1025 * dispextern.h (bidi_unshelve_cache): Update prototype.
1026
1027 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1028 (move_it_in_display_line, move_it_to)
1029 (move_it_vertically_backward, move_it_by_lines): Replace the call
1030 to xfree to an equivalent call to bidi_unshelve_cache.
1031 (move_it_in_display_line_to): Fix logic of returning
412b6358 1032 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1033
e2e2423b
EZ
10342011-08-05 Eli Zaretskii <eliz@gnu.org>
1035
1036 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1037 came from a string character with a `cursor' property. (Bug#9229)
1038
ae9e757a
JD
10392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1040
1041 * Makefile.in (LIB_PTHREAD): New variable.
1042 (LIBES): Add LIB_PTHREAD (Bug#9216).
1043
1044 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1045 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1046
213bd7f2
AS
10472011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1048
1049 * regex.c (re_iswctype): Remove some redundant boolean
1050 conversions.
1051
99aaf75f
JD
10522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1053
1054 * xterm.c (x_find_topmost_parent): New function.
1055 (x_set_frame_alpha): Find topmost parent window with
1056 x_find_topmost_parent and set the property there also (bug#9181).
1057 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1058
c74e9d86
PE
10592011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 * callproc.c (Fcall_process): Avoid vfork clobbering
1062 the local vars buffer, coding_systems, current_dir.
1063
640c8776
SM
10642011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1065
1066 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1067
f26d0e4c
PE
10682011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1069
8a10d76c
PE
1070 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1071 so that it is not optimized away.
1072
f26d0e4c
PE
1073 * xdisp.c (compute_display_string_pos): Remove unused local.
1074
55439c61
EZ
10752011-08-02 Eli Zaretskii <eliz@gnu.org>
1076
1077 Fix slow cursor motion and scrolling in large buffers with
1078 selective display, like Org Mode buffers. (Bug#9218)
1079
1080 * dispextern.h (struct bidi_it): New member disp_prop_p.
1081
1082 * xdisp.c: Remove one-slot cache of display string positions.
1083 (compute_display_string_pos): Accept an additional argument
5e617bc2 1084 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1085 for a display string or property. If found, set DISP_PROP_P
1086 non-zero.
1087
1088 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1089 DISP_PROP_P, and pass it to compute_display_string_pos.
1090 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1091 non-zero. All callers of bidi_fetch_char changed.
1092
fb33fa43
SM
10932011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1094
1095 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1096
b099e063
DM
10972010-12-03 Don March <don@ohspite.net>
1098
1099 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1100 last character M-[char] is translated to ESC [char] (bug#7541).
1101
5cc7f7af
KH
11022011-08-02 Kenichi Handa <handa@m17n.org>
1103
d0fffa3f 1104 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1105
1106 * chartab.c (uniprop_table): Make it non-static.
1107
525d5e6e
EZ
11082011-08-01 Eli Zaretskii <eliz@gnu.org>
1109
1110 * xdisp.c (forward_to_next_line_start): Accept additional argument
1111 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1112 on the newline.
1113 (reseat_at_next_visible_line_start): Use the bidi iterator state
1114 returned by forward_to_next_line_start to restore the state of
1115 it->bidi_it after backing up to previous newline. (Bug#9212)
1116
31011111
AS
11172011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1118
1119 * regex.c (re_comp): Protoize.
1120 (re_exec): Fix return type.
1121 (regexec): Fix type of `ret'. (Bug#9203)
1122
476371c4
PE
11232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1124
e5d76069
PE
1125 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1126 This is needed if max-image-size is a floating-point number.
1127
9a79b20c
AS
11282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1129
1130 * print.c (print_object): Print empty symbol as ##.
1131
1132 * lread.c (read1): Read ## as empty symbol.
1133
d8c2fa78
AA
11342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1135
1136 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1137 setting frame foreground color (Bug#9175).
1138 (x_set_background_color): Likewise.
1139
ffe57a7a
AA
1140 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1141 contents (Bug#9176).
1142 (EmacsTooltip -init): Remove bezels and add shadows to
1143 tooltip windows.
1144
bf3492a5
AA
1145 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1146 or scroll bar (Bug#8470).
1147
d55e9c53
AA
1148 * nsfont.m (nsfont_open): Remove assignment to voffset and
1149 unnecessary vars hshink, expand, hd, full_height, min_height.
1150 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1151
1152 * nsterm.h (nsfont_info): Remove voffset field.
1153
d8c2fa78 11542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1155
1156 Implement strike-through and overline on NextStep (Bug#8863).
1157
1158 * nsfont.m (nsfont_open): Use underline position provided by font,
1159 instead of hard-coded value of 2.
1160 (nsfont_draw): Call ns_draw_text_decoration instead.
1161
1162 * nsterm.h: Add declaration for ns_draw_text_decoration.
1163
1164 * nsterm.m (ns_draw_text_decoration): New function for drawing
1165 underline, overline, and strike-through.
1166 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1167 ns_draw_text_decoration. Change treatment of cursor drawing to
1168 accomodate underlining, etc.
1169
4cc60b9b
EZ
11702011-07-28 Eli Zaretskii <eliz@gnu.org>
1171
bc7ece87
EZ
1172 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1173 default.
4cc60b9b 1174
476371c4
PE
11752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1176
66606eea
PE
1177 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1178 Without this fix, if a signal arrives just after memory fills up,
1179 'malloc' might be invoked reentrantly.
1180
476371c4
PE
1181 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1182 In other words, assume that every image size is allowed, on non-X
1183 hosts. This assumption is probably wrong, but it lets Emacs compile.
1184
f3fcc40d
AS
11852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1186
1187 * regex.c (re_iswctype): Convert return values to boolean.
1188
350c992f
EZ
11892011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1190
1191 * xdisp.c (compute_display_string_pos): Don't use cached display
1192 string position if the buffer had its restriction changed.
1193 (Bug#9184)
1194
5266b4bb
PE
11952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1198
2573a837 11992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1200
41f55ccd 1201 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1202
39e378da
PE
1203 * bidi.c: Integer size and overflow fixes.
1204 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1205 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1206 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1207 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1208 (bidi_find_other_level_edge):
1209 Use ptrdiff_t instead of EMACS_INT where either will do.
1210 This works better on 32-bit hosts configured --with-wide-int.
1211 (bidi_cache_ensure_space): Check for size-calculation overflow.
1212 Use % rather than repeated addition, for better worst-case speed.
1213 Don't set bidi_cache_size until after xrealloc returns, because it
1214 might not return.
1215 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1216 (bidi_cache_ensure_space): Also check that the bidi cache size
1217 does not exceed that of the largest Lisp string or buffer. See Eli
1218 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1219
5e927815
PE
1220 * alloc.c (__malloc_size_t): Remove.
1221 All uses replaced by size_t. See Andreas Schwab's note
1222 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1223
ca4aa935
PE
1224 * image.c: Improve checking for integer overflow.
1225 (check_image_size): Assume that f is nonnull, since
1226 it is always nonnull in practice. This is one less thing to
1227 worry about when checking for integer overflow later.
1228 (x_check_image_size): New function, which checks for integer
1229 overflow issues inside X.
1230 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1231 This removes the need for a memory_full check.
1232 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1233 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1234 (xbm_read_bitmap_data): Change locals back to 'int', since
1235 their values must fit in 'int'.
1236 (xpm_load_image, png_load, tiff_load):
1237 Invoke x_create_x_image_and_pixmap earlier,
1238 to avoid much needless work if the image is too large.
1239 (tiff_load): Treat overly large images as if
1240 x_create_x_image_and_pixmap failed, not as malloc failures.
1241 (gs_load): Use x_check_image_size.
1242
5f8f9cc2
PE
1243 * gtkutil.c: Omit integer casts.
1244 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1245 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1246
5adf60bc
PE
1247 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1248
c8907a93
PE
1249 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1250 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1251 would wrongly return t on a 64-bit host.
1252
e3c25c68
PE
1253 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1254 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1255 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1256 and therefore cause GCC to emit a bogus diagnostic in some cases.
1257
3f791afe
PE
1258 * image.c: Integer signedness and overflow and related fixes.
1259 This is not an exhaustive set of fixes, but it's time to
1260 record what I've got.
1261 (lookup_pixel_color, check_image_size): Remove redundant decls.
1262 (check_image_size): Don't assume that arbitrary EMACS_INT values
1263 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1264 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1265 (tiff_load, imagemagick_load_image):
1266 Check for overflow in size calculations.
1267 (x_create_x_image_and_pixmap): Remove unnecessary test for
1268 xmalloc returning NULL; that can't happen.
1269 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1270 (xpm_color_bucket): Use better integer hashing function.
1271 (xpm_cache_color): Don't possibly over-allocate memory.
1272 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1273 (gif_memory_source):
1274 Use ptrdiff_t, not int or size_t, to record sizes.
1275 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1276 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1277 either works, as we prefer signed integers.
1278 (tiff_read_from_memory, tiff_write_from_memory):
1279 Return tsize_t, not size_t, since that's what the TIFF API wants.
1280 (tiff_read_from_memory): Don't fail simply because the read would
1281 go past EOF; instead, return a short read.
1282 (tiff_load): Omit no-longer-needed casts.
1283 (Fimagemagick_types): Don't assume size fits into 'int'.
1284
3cc5a532
PE
1285 Improve hashing quality when configured --with-wide-int.
1286 * fns.c (hash_string): New function, taken from sxhash_string.
1287 Do not discard information about ASCII character case; this
1288 discarding is no longer needed.
1289 (sxhash-string): Use it. Change sig to match it. Caller changed.
1290 * lisp.h: Declare it.
1291 * lread.c (hash_string): Remove, since we now use fns.c's version.
1292 The fns.c version returns a wider integer if --with-wide-int is
1293 specified, so this should help the quality of the hashing a bit.
1294
b312a492
PE
1295 * emacs.c: Integer overflow minor fix.
1296 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1297 Define only if GNU_LINUX.
1298 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1299
dfd153ae
PE
1300 * dispnew.c: Integer signedness and overflow fixes.
1301 Remove unnecessary forward decls, that were a maintenance hassle.
1302 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1303 All uses changed.
1304 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1305 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1306 (prepare_desired_row, line_draw_cost):
1307 Use int, not unsigned, where either works.
1308 (save_current_matrix, restore_current_matrix):
1309 Use ptrdiff_t, not size_t, where either works.
1310 (init_display): Check for overflow more accurately, and without
1311 relying on undefined behavior.
1312
a81d11a3
PE
1313 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1314 Remove, replacing with the new symbols in lisp.h. All uses changed.
1315 * fileio.c (make_temp_name):
1316 * filelock.c (lock_file_1, lock_file):
1317 * xdisp.c (message_dolog):
1318 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1319 Use pMd etc. instead.
1320 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1321 replacing the pWIDE etc. symbols removed from editfns.c.
1322
3300e6fd
PE
1323 * keyboard.h (num_input_events): Now uintmax_t.
1324 This is (very slightly) less likely to mess up due to wraparound.
1325 All uses changed.
1326
fd05c7e9
PE
1327 * buffer.c: Integer signedness fixes.
1328 (alloc_buffer_text, enlarge_buffer_text):
1329 Use ptrdiff_t rather than size_t when either will do, as we prefer
1330 signed integers.
1331
903fe15d
PE
1332 * alloc.c: Integer signedness and overflow fixes.
1333 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1334 (__malloc_size_t): Default to size_t, not to int.
1335 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1336 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1337 Prefer ptrdiff_t to size_t when either would do, as we prefer
1338 signed integers.
1339 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1340 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1341 Now const. Initialize with values that are in range even if char
1342 is signed.
1343 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1344 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1345 These functions do the right thing with sizes > 2**32.
1346 (check_depth): Now ptrdiff_t, not int.
1347 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1348 Adjust to new way of storing sizes. Check for size overflow bugs
1349 in rest of code.
1350 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1351 slightly wrong anyway, as it missed one instance of
1352 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1353 (refill_memory_reserve): Omit needless cast to size_t.
1354 (mark_object_loop_halt): Mark as externally visible.
1355
ac82cc6a
PE
1356 * xselect.c: Integer signedness and overflow fixes.
1357 (Fx_register_dnd_atom, x_handle_dnd_message):
1358 Use ptrdiff_t, not size_t, since we prefer signed.
1359 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1360 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1361 x_dnd_atoms_size and x_dnd_atoms_length.
1362
c2d1e36d
PE
1363 * doprnt.c: Prefer signed to unsigned when either works.
1364 * eval.c (verror):
1365 * doprnt.c (doprnt):
1366 * lisp.h (doprnt):
1367 * xdisp.c (vmessage):
1368 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1369 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1370 prefer signed arithmetic to avoid comparison confusion.
1371 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1372 but is a bit tricky.
1373
0e926e56
PE
1374 Assume freestanding C89 headers, string.h, stdlib.h.
1375 * data.c, doprnt.c, floatfns.c, print.c:
1376 Include float.h unconditionally.
1377 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1378 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1379 * regex.c: Likewise for stddef.h, string.h.
1380 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1381 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1382 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1383 (STDC_HEADERS): Remove obsolete defines.
1384 * sysdep.c: Include limits.h unconditionally.
1385
9cfdb3ec
PE
1386 Assume support for memcmp, memcpy, memmove, memset.
1387 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1388 * regex.c (memcmp, memcpy):
1389 Remove; we assume C89 now.
1390
1391 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1392 (__malloc_safe_bcopy): Remove; no longer needed.
1393
cf950e6b 1394 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1395 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1396 well either way, and we prefer signed to unsigned.
1397
dbf38e02
LMI
13982011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1399
1400 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1401 closes the connection while we're reading (bug#9182).
1402
d6f0886c 14032011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1404
d6f0886c
JD
1405 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1406 are specified (Bug#9168).
24e0f6b1 1407
2eb1f9e6
PE
14082011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1411 Found by GCC static checking and --with-wide-int on a 32-bit host.
1412
22381272 14132011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1414
1415 * xdisp.c (compute_display_string_pos): Fix logic of caching
1416 previous display string position. Initialize cached_prev_pos to
1417 -1. Fixes slow-down at the beginning of a buffer.
1418
f25e39b4
EZ
14192011-07-24 Eli Zaretskii <eliz@gnu.org>
1420
1421 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1422 for attrs[LFACE_FONTSET_INDEX].
1423
04c4b52e
PE
14242011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 * xml.c (parse_region): Remove unused local
1427 that was recently introduced.
1428
c1734fbd
EZ
14292011-07-23 Eli Zaretskii <eliz@gnu.org>
1430
be18c5a5
EZ
1431 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1432 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1433
c1734fbd
EZ
1434 * xdisp.c (move_it_in_display_line_to): Record the best matching
1435 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1436 exit if none of the characters scanned was an exact match.
1437 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1438 when exact match is impossible due to invisible text, and the
1439 lines are truncated.
1440
a258d627
JD
14412011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1442
1443 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1444 for OSX >= 10.7.
1445
b6d5a689
EZ
14462011-07-22 Eli Zaretskii <eliz@gnu.org>
1447
0f74f785
EZ
1448 Fix a significant slow-down of cursor motion with C-n, C-p,
1449 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1450 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1451 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1452 (next_element_from_buffer): Call compute_stop_pos_backwards to
1453 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1454 base_level_stop.
1455 (reseat): Don't look for prev_stop, as that could mean a very long
1456 run.
1457 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1458 <cached_disp_overlay_modiff>: Cache for last found display string
1459 position.
551918c1 1460 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1461 about the same buffer in the same area of character positions, and
1462 the buffer wasn't changed since the time the display string
1463 position was cached.
551918c1 1464
b2d0c91a
EZ
14652011-07-22 Eli Zaretskii <eliz@gnu.org>
1466
1467 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1468 is an integer, which is important for empty lines. (Bug#9149)
1469
043604ee
CY
14702011-07-22 Chong Yidong <cyd@stupidchicken.com>
1471
1472 * frame.c (Fmodify_frame_parameters): In tty case, update the
1473 default face if necessary (Bug#4238).
1474
da4adb04
CY
14752011-07-21 Chong Yidong <cyd@stupidchicken.com>
1476
1477 * editfns.c (Fstring_to_char): No need to explain what a character
1478 is in the docstring (Bug#6576).
1479
9abd0532
LMI
14802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1481
1482 * xml.c (parse_region): Make sure we always return a tree.
1483
36881d16
HK
14842011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1485
1486 * xml.c (parse_region): If a document contains only comments,
1487 return that, too.
1488
1e98674d
LMI
14892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1490
1491 * xml.c (make_dom): Return comments, too.
1492
590bd467
PE
14932011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 Port to OpenBSD.
1496 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1497 and the surrounding thread.
1498 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1499 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1500 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1501 timer goes off.
1502 * s/openbsd.h (BROKEN_SIGIO): Define.
1503 * unexelf.c (unexec) [__OpenBSD__]:
1504 Don't update the .mdebug section of the Alpha COFF symbol table.
1505
f41628b2
LMI
15062011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1507
1508 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1509 (bug#8460).
1510
b59b67c5
PE
15112011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1512
15e3a074
PE
1513 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1514 This fixes some race conditions on the permissions of any newly
1515 created file.
1516
41bed37d
PE
1517 * alloc.c (valid_pointer_p): Use pipe, not open.
1518 This fixes some permissions issues when debugging.
1519
b59b67c5
PE
1520 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1521 If fchown fails to set both uid and gid, try to set just gid,
1522 as that is sometimes allowed. Adjust the file's mode to eliminate
1523 setuid or setgid bits that are inappropriate if fchown fails.
1524
925a6be7
SM
15252011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1526
1527 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1528 to compare Lisp_Objects.
1529 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1530 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1531 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1532
52968808
AS
15332011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1534
0a6a104b
AS
1535 * lread.c (read_integer): Unread even EOF character.
1536 (read1): Likewise. Properly record start position of symbol.
1537
52968808
AS
1538 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1539 symbol character follows.
1540
9e381cdd
PE
15412011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1544 This works around a problem with the previous change to Fcopy_file.
1545 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1546 and without this change, GCC might complain about discarding
1547 fchown's return value.
1548
b5641435
JB
15492011-07-16 Juanma Barranquero <lekktu@gmail.com>
1550
1551 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1552
a8031457
PE
15532011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1556
dd889327
LMI
15572011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1558
750c33f7
LMI
1559 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1560 it's used from the C level.
1561
dd889327
LMI
1562 * process.c: Use the same condition for POLL_FOR_INPUT in both
1563 keyboard.c and process.c (bug#1858).
1564
87e86684
LM
15652011-07-09 Lawrence Mitchell <wence@gmx.li>
1566
1567 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1568 (Fgnutls_boot): Use it.
1569
64348f40
AS
15702011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1571
1572 * doc.c (Fsubstitute_command_keys): Revert last change.
1573
1d698799
LMI
15742011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1575
f863868c
LMI
1576 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1577 quotes the next character, and doesn't affect other longer
1578 sequences (bug#8935).
1579
1d698799
LMI
1580 * lread.c (syms_of_lread): Clarify that is isn't only
1581 `eval-buffer' and `eval-defun' that's affected by
1582 `lexical-binding' (bug#8460).
1583
aa4b6df6
EZ
15842011-07-15 Eli Zaretskii <eliz@gnu.org>
1585
1586 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1587 bidi redisplay when a line includes both an image and is
1588 truncated.
1589
5d856da6
PE
15902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1591
ad6042bb
PE
1592 Fix minor problems found by static checking.
1593 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1594 (elsz): Now a signed constant, not a size_t var. We prefer signed
1595 types to unsigned, to avoid integer comparison confusion. Without
1596 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1597 "cannot optimize loop, the loop counter may overflow", a symptom
1598 of the confusion.
f00bbb22 1599 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1600 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1601
6468f31c
LMI
16022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1603
49080b10
LMI
1604 * search.c (Fre_search_backward): Mention `case-fold-search' in
1605 all the re_search_* functions (bug#8138).
1606
6468f31c
LMI
1607 * keyboard.c (Fopen_dribble_file): Document when the file is
1608 closed (bug#8056).
1609
c965adc5
EZ
16102011-07-14 Eli Zaretskii <eliz@gnu.org>
1611
df9733bf
EZ
1612 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1613 bidi_cache_idx.
1614
0bb23927
EZ
1615 Support bidi reordering of display and overlay strings.
1616 * xdisp.c (compute_display_string_pos)
1617 (compute_display_string_end): Accept additional argument STRING.
1618 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1619 (reseat_to_string): Initialize bidi_it->string.s and
1620 bidi_it->string.schars.
1621 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1622 NULL (avoids a crash in bidi_paragraph_init).
1623 Initialize itb.string.lstring.
0bb23927
EZ
1624 (init_iterator): Call bidi_init_it only of a valid
1625 buffer position was specified. Initialize paragraph_embedding to
1626 L2R.
1627 (reseat_to_string): Initialize the bidi iterator.
1628 (display_string): If we need to ignore text properties of
1629 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1630 original value of -1 will not work with bidi.)
1631 (compute_display_string_pos): First arg is now struct
1632 `text_pos *'; all callers changed. Support display properties on
1633 Lisp strings.
1634 (compute_display_string_end): Support display properties on Lisp
1635 strings.
1636 (init_iterator, reseat_1, reseat_to_string): Initialize the
1637 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1638 when iterating on a string not from display properties).
640c8776
SM
1639 (compute_display_string_pos, compute_display_string_end):
1640 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1641 arrow keys.
1642 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1643 base_level_stop; instead, set base_level_stop to BEGV.
1644 Fixes crashes in vertical-motion.
0bb23927
EZ
1645 (next_element_from_buffer): Improve commentary for when
1646 the iterator is before prev_stop.
1647 (init_iterator): Initialize bidi_p from the default value of
1648 bidi-display-reordering, not from buffer-local value. Use the
1649 buffer-local value only if initializing for buffer iteration.
1650 (handle_invisible_prop): Support invisible properties on strings
1651 that are being bidi-reordered.
1652 (set_iterator_to_next): Support bidi reordering of C strings and
1653 Lisp strings.
1654 (next_element_from_string): Support bidi reordering of Lisp
1655 strings.
1656 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1657 (display_string): Support display of R2L glyph rows.
1658 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1659 (init_iterator): Don't initialize it->bidi_p for strings
1660 here.
1661 (reseat_to_string): Initialize it->bidi_p for strings here.
1662 (next_element_from_string, next_element_from_c_string)
1663 (next_element_from_buffer): Add xassert's for correspondence
1664 between IT's object being iterated and it->bidi_it.string
1665 structure.
1666 (face_before_or_after_it_pos): Support bidi iteration.
1667 (next_element_from_c_string): Handle the case of the first string
1668 character that is not the first one in the visual order.
1669 (get_visually_first_element): New function, refactored from common
1670 parts of next_element_from_buffer, next_element_from_string, and
1671 next_element_from_c_string.
1672 (tool_bar_lines_needed, redisplay_tool_bar)
1673 (display_menu_bar): Force left-to-right direction. Add a FIXME
1674 comment for making that be controlled by a user option.
1675 (push_it, pop_it): Save and restore the state of the
1676 bidi iterator. Save and restore the bidi_p flag.
1677 (pop_it): Iterate out of display property for string iteration as
1678 well.
1679 (iterate_out_of_display_property): Support iteration over strings.
1680 (handle_single_display_spec): Set up it->bidi_it for iteration
1681 over a display string, and call bidi_init_it.
1682 (handle_single_display_spec, next_overlay_string)
1683 (get_overlay_strings_1, push_display_prop): Set up the bidi
1684 iterator for displaying display or overlay strings.
1685 (forward_to_next_line_start): Don't use the shortcut if
1686 bidi-iterating.
1687 (back_to_previous_visible_line_start): If handle_display_prop
1688 pushed the iterator stack, restore the internal state of the bidi
1689 iterator by calling bidi_pop_it same number of times.
1690 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1691 and we are bidi-iterating, don't decrement the iterator position;
1692 instead, set the first_elt flag in the bidi iterator, to produce
1693 the same effect.
1694 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1695 (push_display_prop): xassert that we are iterating a buffer.
1696 (push_it, pop_it): Save and restore paragraph_embedding member.
1697 (handle_single_display_spec, next_overlay_string)
1698 (get_overlay_strings_1, reseat_1, reseat_to_string)
1699 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1700 correctly. Don't assume unibyte strings are not bidi-reordered.
1701 (compute_display_string_pos)
1702 (compute_display_string_end): Fix handling the case of C string.
1703 (push_it, pop_it): Save and restore from_disp_prop_p.
1704 (handle_single_display_spec, push_display_prop): Set the
1705 from_disp_prop_p flag.
1706 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1707 (pop_it): Call iterate_out_of_display_property only if we are
1708 popping after iteration over a string that came from a display
1709 property. Fix a typo in popping stretch info. Add an assertion
1710 for verifying that the iterator position is in sync with the bidi
1711 iterator.
1712 (handle_single_display_spec, get_overlay_strings_1)
1713 (push_display_prop): Fix initialization of paragraph direction for
1714 string when that of the parent object is not yet determined.
1715 (reseat_1): Call bidi_init_it to resync the bidi
1716 iterator with IT's position. (Bug#7616)
1717 (find_row_edges): If ROW->start.pos gives position
1718 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1719 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1720 Reset the from_disp_prop_p flag.
1721 (SAVE_IT, RESTORE_IT): New macros.
1722 (pos_visible_p, face_before_or_after_it_pos)
1723 (back_to_previous_visible_line_start)
1724 (move_it_in_display_line_to, move_it_in_display_line)
1725 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1726 (try_scrolling, redisplay_window, display_line): Use them when
1727 saving a temporary copy of the iterator and restoring it back.
1728 (back_to_previous_visible_line_start, reseat_1)
1729 (init_iterator): Empty the bidi cache "stack".
1730 (move_it_in_display_line_to): If iterator ended up at
1731 EOL, but we never saw any buffer positions smaller than
1732 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1733 motion in bidi-reordered lines.
1734 (move_it_in_display_line_to): Record prev_method and prev_pos
1735 immediately before the call to set_iterator_to_next. Fixes cursor
1736 motion in bidi-reordered lines with stretch glyphs and strings
1737 displayed in margins. (Bug#8133) (Bug#8867)
1738 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1739 TO_CHARPOS.
640c8776
SM
1740 (pos_visible_p): Support positions in bidi-reordered lines.
1741 Save and restore bidi cache.
0bb23927
EZ
1742
1743 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1744 (bidi_paragraph_info): Delete unused struct.
1745 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1746 (bidi_cache_start): New variable.
1747 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1748 to zero.
1749 (bidi_cache_fetch_state, bidi_cache_search)
1750 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1751 (bidi_cache_find, bidi_peek_at_next_level)
1752 (bidi_level_of_next_char, bidi_find_other_level_edge)
1753 (bidi_move_to_visually_next): Compare cache index with
1754 bidi_cache_start rather than with zero.
1755 (bidi_fetch_char): Accept new argument STRING; all callers
1756 changed. Support iteration over a string. Support strings with
1757 display properties. Support unibyte strings. Fix the type of
1758 `len' according to what STRING_CHAR_AND_LENGTH expects.
1759 (bidi_paragraph_init, bidi_resolve_explicit_1)
1760 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1761 (bidi_level_of_next_char, bidi_move_to_visually_next):
1762 Support iteration over a string.
0bb23927
EZ
1763 (bidi_set_sor_type, bidi_resolve_explicit_1)
1764 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1765 can now be zero (for strings); special values 0 and -1 were
1766 changed to -1 and -2, respectively.
1767 (bidi_char_at_pos): New function.
1768 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1769 Call it instead of FETCH_MULTIBYTE_CHAR.
1770 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1771 initialized to valid values.
1772 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1773 values.
1774 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1775 the test for valid cached positions. Fix the logic for looking up
1776 the sentinel state in the cache. GCPRO the Lisp string we are
1777 iterating.
1778 (bidi_push_it, bidi_pop_it): New functions.
1779 (bidi_initialize): Initialize the bidi cache start stack pointer.
1780 (bidi_cache_ensure_space): New function, refactored from part of
1781 bidi_cache_iterator_state. Don't assume the required size is just
1782 one BIDI_CACHE_CHUNK away.
1783 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1784 (bidi_count_bytes, bidi_char_at_pos): New functions.
1785 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1786 always valid if bidi_cache_idx is valid.
1787 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1788 is valid if it's going to be used.
1789 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1790 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1791 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1792 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1793 (bidi_find_other_level_edge, bidi_cache_start_stack):
1794 All variables related to cache indices are now EMACS_INT.
c965adc5 1795
0bb23927
EZ
1796 * dispextern.h (struct bidi_string_data): New structure.
1797 (struct bidi_it): New member `string'. Make flag members be 1-bit
1798 fields, and put them last in the struct.
640c8776
SM
1799 (compute_display_string_pos, compute_display_string_end):
1800 Update prototypes.
0bb23927
EZ
1801 (bidi_push_it, bidi_pop_it): Add prototypes.
1802 (struct iterator_stack_entry): New members bidi_p,
1803 paragraph_embedding, and from_disp_prop_p.
1804 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1805 (bidi_shelve_cache, bidi_unshelve_cache):
1806 Declare prototypes.
0bb23927
EZ
1807
1808 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1809 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1810 and vector-like objects.
1811
1812 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1813 cache around display iteration.
1814
1815 * window.c (Fwindow_end, window_scroll_pixel_based)
1816 (displayed_window_lines, Frecenter): Save and restore the bidi
1817 cache around display iteration.
1818
3bbd2265
LMI
18192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1820
1821 * editfns.c (Fdelete_region): Clarify the use of the named
1822 parameters (bug#6788).
1823
adc47434
MR
18242011-07-14 Martin Rudalics <rudalics@gmx.at>
1825
1826 * indent.c (Fvertical_motion): Set and restore w->pointm when
1827 saving and restoring the window's buffer (Bug#9006).
1828
837c31f8
LMI
18292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1830
1831 * editfns.c (Fstring_to_char): Clarify just what is returned
1832 (bug#6576). Text by Eli Zaretskii.
1833
ac389d0c
JB
18342011-07-13 Juanma Barranquero <lekktu@gmail.com>
1835
1836 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1837
0be0ce47
EZ
18382011-07-13 Eli Zaretskii <eliz@gnu.org>
1839
1840 * buffer.c (mmap_find): Fix a typo.
1841
cd18e7e3
JB
18422011-07-13 Johan Bockgård <bojohan@gnu.org>
1843
1844 Fix execution of x selection hooks.
1845 * xselect.c (Qx_lost_selection_functions)
1846 (Qx_sent_selection_functions): New vars.
1847 (syms_of_xselect): DEFSYM them.
1848 (x_handle_selection_request): Pass Qx_sent_selection_functions
1849 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1850 (x_handle_selection_clear,x_clear_frame_selections):
1851 Pass Qx_lost_selection_functions rather than
1852 Vx_lost_selection_functions to Frun_hook_with_args.
1853
47ea7f44
PE
18542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1855
ac389d0c 1856 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1857 The old code sometimes used this field without initializing it.
1858
47ea7f44
PE
1859 * alloc.c (gc_sweep): Don't read past end of array.
1860 In theory, the old code could also have corrupted Emacs internals,
1861 though it'd be very unlikely.
1862
bc985c87
AS
18632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1864
1865 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1866 argument. (Bug#4026)
bc985c87 1867
0cf34688
LMI
18682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1869
b3dadd76
LMI
1870 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1871 key" (bug#4257).
1872
0cf34688
LMI
1873 * window.c (Fset_window_start): Doc fix (bug#4199).
1874 (Fset_window_hscroll): Ditto.
1875
270768cd
PE
18762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1877
077e3dda 1878 Fix minor new problems caught by GCC 4.6.1.
270768cd 1879 * term.c (init_tty): Remove unused local.
490011a6 1880 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1881 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1882 not used otherwise.
270768cd 1883
b1f58454
CY
18842011-07-12 Chong Yidong <cyd@stupidchicken.com>
1885
1886 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1887
22b9578d
LMI
18882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1889
6e70ab07
LMI
1890 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1891 are the mini-buffer and the echo area (bug#3320).
1892
22b9578d
LMI
1893 * term.c (init_tty): Remove support for supdup, c10 and perq
1894 terminals, which are no longer supported (bug#1482).
1895
8974cc9f
JB
18962011-07-10 Johan Bockgård <bojohan@gnu.org>
1897
1898 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1899
a560d974
JD
19002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1901
1902 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1903 for non-popups (Bug#3642).
1904
1dae0f0a
AS
19052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1906
268c2c36 1907 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1908 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1909 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1910 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1911 * data.c (fmod): Likewise.
1912 * dispnew.c (swap_glyphs_in_rows): Likewise.
1913 * emacs.c (memory_warning_signal): Likewise.
1914 * floatfns.c (float_error): Likewise.
1915 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1916 (otf_open, font_otf_capability, generate_otf_features)
1917 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1918 Likewise.
1919 * image.c (pbm_read_file): Likewise.
1920 * indent.c (string_display_width): Likewise.
1921 * intervals.c (check_for_interval, search_for_interval)
1922 (inc_interval_count, count_intervals, root_interval)
1923 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1924 * lread.c (defalias): Likewise.
268c2c36 1925 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1926 * regex.c (set_image_of_range_1, set_image_of_range)
1927 (regex_grow_registers): Likewise.
1928 * sysdep.c (strerror): Likewise.
1929 * termcap.c (valid_filename_p, tprint, main): Likewise.
1930 * tparam.c (main): Likewise.
1931 * unexhp9k800.c (run_time_remap, save_data_space)
1932 (update_file_ptrs, read_header, write_header, calculate_checksum)
1933 (copy_file, copy_rest, display_header): Likewise.
1934 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1935 Likewise.
1936 * xdisp.c (check_it): Likewise.
1937 * xfaces.c (register_color, unregister_color, unregister_colors):
1938 Likewise.
1939 * xfns.c (print_fontset_result): Likewise.
1940 * xrdb.c (member, fatal, main): Likewise.
1941
99033785
PE
19422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 Fix minor problems found by static checking (Bug#9031).
1945 * chartab.c (char_table_set_range, map_sub_char_table):
1946 Remove unused locals.
1947 (uniprop_table): Now static.
1948 * composite.c (_work_char): Remove unused static var.
1949
9cb2ac56
JB
19502011-07-09 Juanma Barranquero <lekktu@gmail.com>
1951
1952 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1953
f25661f0
JD
19542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1955
1956 * gtkutil.c (qttip_cb): Remove code without function.
1957
8278c4fe
EZ
19582011-07-09 Eli Zaretskii <eliz@gnu.org>
1959
1960 * w32.c (pthread_sigmask): New stub.
1961
1692ae2d 19622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1963
8a6ebd58 1964 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1965 sigprocmask is portable only for single-threaded applications, and
1966 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1967 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1968 (LIBES): Use it.
1969 * callproc.c (Fcall_process):
1970 * process.c (create_process):
1971 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1972 Use pthread_sigmask, not sigprocmask.
123403e4 1973
1b854618
JD
19742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1975
1976 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1977 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1978 wrong (Bug#8591).
1979
3fe4b549
JD
19802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1981
0ce7e563
JD
1982 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1983 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1984 (xg_hide_tooltip): Fix comment.
1985
3fe4b549
JD
1986 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1987 in registerServicesMenuSendTypes.
1988 (validRequestorForSendType): Don't check ns_return_types.
1989
1990 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1991 ns_return_type.
1992
5df75e47
JR
19932011-07-08 Jason Rumney <jasonr@gnu.org>
1994
1995 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1996 frame struct members of non-existent frames (Bug#6284).
1997
699c10bd
JD
19982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1999
4393663b
JD
2000 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2001 variable firstTime not needed on OSX >= 10.6.
2002 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2003 >= 10.5. Use setKnobProportion, setDoubleValue.
2004
2005 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2006 (MAC_OS_X_VERSION_10_5): Define if not defined.
2007 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2008 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2009 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2010
2011 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2012 cString and lossyCString on OSX >= 10.4
2013
2014 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2015 sizeToFit on OSX >= 10.2.
2016
2017 * nsimage.m (allocInitFromFile): Don't use deprecated method
2018 bestRepresentationForDevice on OSX >= 10.6.
2019
2020 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2021 to avoid warning.
2022
2023 * emacs.c: Declare unexec_init_emacs_zone.
2024
a63e0781
JD
2025 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2026
699c10bd
JD
2027 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2028
2029 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2030 on svcsMenu (Bug#8842).
2031
2032 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2033 ns_return_types.
2034 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2035
2036 * nsterm.m (QUTF8_STRING): Declare.
2037 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2038 (validRequestorForSendType): Return type is (id).
2039 Change indexOfObjectIdenticalTo to indexOfObject.
2040 Check if we have local selection before returning self (Bug#8842).
2041 (writeSelectionToPasteboard): Put local selection into paste board
2042 if we have a local selection (Bug#8842).
2043 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2044
2045 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2046 (ns_get_local_selection): Declare.
2047
54e10184
LMI
20482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2049
9888ff71
LMI
2050 * keymap.c (describe_map_tree): Don't insert a double newline at
2051 the end of the buffer (bug#1169) and return whether we inserted
2052 something.
2053
54e10184
LMI
2054 * callint.c (Fcall_interactively): Change "reading args" to
2055 "providing args" to try to clarify what it does (bug#1010).
2056
15fa4783
KH
20572011-07-07 Kenichi Handa <handa@m17n.org>
2058
2059 * composite.c (composition_compute_stop_pos): Ignore a static
2060 composition starting before CHARPOS (Bug#8915).
2061
2062 * xdisp.c (handle_composition_prop): Likewise.
2063
a8815b00
EZ
20642011-07-07 Eli Zaretskii <eliz@gnu.org>
2065
2066 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2067 (Bug#9015)
2068
ef7b981d 20692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2070
2071 * character.h (unicode_category_t): New enum type.
2072
2073 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2074 (Qchar_code_property_table): New variable.
2075 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2076 (UNIPROP_COMPRESSED_FORM_P): New macros.
2077 (char_table_ascii): Uncompress the compressed values.
2078 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2079 Uncompress the compressed values.
ac389d0c 2080 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2081 (char_table_ref_and_range): Uncompress the compressed values.
2082 (sub_char_table_set): New arg is_uniprop. Callers changed.
2083 Uncompress the compressed values.
2084 (sub_char_table_set_range): Args changed. Callers changed.
2085 (char_table_set_range): Adjuted for the above change.
2086 (map_sub_char_table): Delete args default_val and parent. Add arg
2087 top. Give decoded values to a Lisp function.
640c8776 2088 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2089 values to a Lisp function. Gcpro more variables.
2090 (uniprop_table_uncompress)
2091 (uniprop_decode_value_run_length): New functions.
2092 (uniprop_decoder, uniprop_decoder_count): New variables.
2093 (uniprop_get_decoder, uniprop_encode_value_character)
2094 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2095 New functions.
2096 (uniprop_encoder, uniprop_encoder_count): New variables.
2097 (uniprop_get_encoder, uniprop_table)
2098 (Funicode_property_table_internal, Fget_unicode_property_internal)
2099 (Fput_unicode_property_internal): New functions.
2100 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2101 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2102 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2103 char-code-property-alist.
2104
640c8776 2105 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2106 Vunicode_category_table.
2107
640c8776 2108 * font.c (font_range): Adjust for the change of
c805dec0
KH
2109 Vunicode_category_table.
2110
76b397fb
DN
21112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2112
2113 * m/iris4d.h: Remove file, move contents ...
2114 * s/irix6-5.h: ... here.
2115
22b4128e
PE
21162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2119 * alloc.c (mark_buffer):
2120 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2121 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2122 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2123 This isn't true in general, and it's particularly not true
2124 if Emacs is configured with --with-wide-int.
2125 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2126 New macros, used in the buffer.c change.
2127
869795d6
JD
21282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2129
2130 * xsettings.c: Use both GConf and GSettings if both are available.
2131 (store_config_changed_event): Add comment.
2132 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2133 (store_tool_bar_style_changed): New functions.
5e617bc2 2134 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2135 (struct xsettings): Move font inside HAVE_XFT.
2136 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2137 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2138 Move inside HAVE_XFT.
640c8776 2139 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2140 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2141 also.
2142 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2143 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2144 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2145 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2146 (parse_settings): Move check for font inside HAVE_XFT.
2147 (read_settings, apply_xft_settings): Add comment.
2148 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2149 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2150 call store_font_name_changed.
2151 (xft_settings_event): Add comment.
2152 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2153 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2154 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2155 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2156 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2157 (xsettings_get_system_font, xsettings_get_system_normal_font):
2158 Add comment.
869795d6 2159
d8ed26bd
PE
21602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2161
2162 Random fixes. E.g., (random) never returned negative values.
2163 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2164 subseconds part to the entropy, as that's a bit more random.
2165 Prefer signed to unsigned, since the signedness doesn't matter and
2166 in general we prefer signed. When given a limit, use a
2167 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2168 latter isn't right if USE_2_TAGS_FOR_INTS.
2169 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2170 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2171
cabf1cac
SM
21722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2173
2174 * textprop.c (text_property_stickiness):
2175 Obey Vtext_property_default_nonsticky.
2176 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2177 * w32fns.c (syms_of_w32fns):
2178 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2179
6e9b2be9
PE
21802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2183 This is more efficient than Ffile_directory_p and avoids a minor race.
2184
90186c68
LMI
21852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2186
7c301272
LMI
2187 * buffer.c (Foverlay_put): Say what the return value is
2188 (bug#7835).
2189
c4f2d8d4
LMI
2190 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2191 is a directory before asking whether to use the file name
2192 (bug#7564).
ad637907
LMI
2193 (barf_or_query_if_file_exists): Make the "File is a directory"
2194 error be more correct.
c4f2d8d4 2195
90186c68
LMI
2196 * fns.c (Frequire): Remove the mention of the .gz files, since
2197 that's installation-specific, but keep the mention of
2198 `get-load-suffixes'.
2199
da64016e
PE
22002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2201
2202 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2203 Report string overflow if the output is too long.
2204
7d47b580
JB
22052011-07-04 Juanma Barranquero <lekktu@gmail.com>
2206
a555cb87
JB
2207 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2208 (syms_of_gnutls): Remove duplicate DEFSYM for
2209 Qgnutls_bootprop_verify_hostname_error, an error for
2210 Qgnutls_bootprop_verify_error (which is no longer used).
2211
7d47b580
JB
2212 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2213 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2214 Also (re)move comments that are misplaced or no longer relevant.
2215
1e49bfab
LMI
22162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2217
2218 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2219
1485f4c0
CY
22202011-07-03 Chong Yidong <cyd@stupidchicken.com>
2221
2222 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2223 and background color parameters if they have been changed.
2224
a9ab721e
LMI
22252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2226
2227 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2228
cf7cff57
PE
22292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2230
2e13213d
PE
2231 * xsettings.c (SYSTEM_FONT): Define only when used.
2232 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2233
cf7cff57
PE
2234 * keymap.c (access_keymap_1): Now static.
2235
7a8e04f7
CY
22362011-07-02 Chong Yidong <cyd@stupidchicken.com>
2237
2238 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2239 leave any prefix arg for the up event (Bug#1586).
2240
61352f62
LMI
22412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2242
69bb1ef7
LMI
2243 * lread.c (syms_of_lread): Mention single symbols defined by
2244 `defvar' or `defconst' (bug#7154).
2245
61352f62 2246 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2247 (Frequire): Mention get-load-suffixes.
61352f62 2248
28545e04
MR
22492011-07-02 Martin Rudalics <rudalics@gmx.at>
2250
2251 * window.h (window): Remove clone_number slot.
2252 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2253 Remove.
2254 (make_parent_window, make_window, saved_window)
2255 (Fset_window_configuration, save_window_save): Don't deal with
2256 clone numbers.
2257 * buffer.c (Qclone_number): Remove declaration.
2258 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2259
3349e122
SM
22602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2261
2262 Add multiple inheritance to keymaps.
2263 * keymap.c (Fmake_composed_keymap): New function.
2264 (Fset_keymap_parent): Simplify.
2265 (fix_submap_inheritance): Remove.
2266 (access_keymap_1): New function extracted from access_keymap to handle
2267 embedded parents and handle lists of maps.
2268 (access_keymap): Use it.
2269 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2270 (Fcopy_keymap): Handle embedded parents.
2271 (Fcommand_remapping, define_as_prefix): Simplify.
2272 (Fkey_binding): Simplify.
2273 (syms_of_keymap): Move minibuffer-local-completion-map,
2274 minibuffer-local-filename-completion-map,
2275 minibuffer-local-must-match-map, and
2276 minibuffer-local-filename-must-match-map to Elisp.
2277 (syms_of_keymap): Defsubr make-composed-keymap.
2278 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2279 (parse_menu_item): Trivial simplification.
2280
3279eb87
GM
22812011-07-01 Glenn Morris <rgm@gnu.org>
2282
2283 * Makefile.in (SETTINGS_LIBS): Fix typo.
2284
4550efdf
KI
22852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2286
2287 * coding.c (Fencode_coding_string): Record the last coding system
2288 used, as the function doc string says (bug#8738).
2289
0949d2b6
JD
22902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2291
2292 * xsettings.c (store_monospaced_changed): Take new font as arg and
2293 check for change against current_mono_font.
2294 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2295 (emacs_settings_constructor, emacs_settings_get_property)
2296 (emacs_settings_set_property, emacs_settings_class_init)
2297 (emacs_settings_init, gsettings_obj): Remove.
2298 (something_changedCB): New function for HAVE_GSETTINGS.
2299 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2300 with value as argument.
2301 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2302 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2303 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2304 "changed".
2305
2306 * xgselect.c: Add defined (HAVE_GSETTINGS).
2307 (xgselect_initialize): Ditto.
2308
2309 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2310 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2311 xg_select.
2312
bbc6b304
PE
23132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 * eval.c (struct backtrace): Simplify and port the data structure.
2316 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2317 signed bit field, as this assumption is not portable and it makes
2318 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2319 "char debug_on_exit : 1" as this is not portable either; instead,
2320 use the portable "unsigned int debug_on_exit : 1". Remove unused
2321 member evalargs. Remove obsolete comments about cc bombing out.
2322
9851bfc5
JD
23232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2324
51bb811f 2325 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2326 Let HAVE_GSETTINGS override HAVE_GCONF.
2327 (store_monospaced_changed): New function.
2328 (EMACS_SETTINGS): A new type derived from GObject to handle
2329 GSettings notifications.
2330 (emacs_settings_constructor, emacs_settings_get_property)
2331 (emacs_settings_set_property, emacs_settings_class_init):
2332 New functions.
2333 (gsettings_client, gsettings_obj): New variables.
2334 (GSETTINGS_SCHEMA): New define.
2335 (something_changedCB): Call store_monospaced_changed.
2336 (init_gsettings): New function.
2337 (xsettings_initialize): Call init_gsettings.
2338 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2339 to NULL.
2340
640c8776 2341 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2342 GCONF_CFLAGS/LIBS.
2343
5386012d
MR
23442011-06-29 Martin Rudalics <rudalics@gmx.at>
2345
2346 * window.c (resize_root_window, grow_mini_window)
2347 (shrink_mini_window): Rename Qresize_root_window to
2348 Qwindow_resize_root_window and Qresize_root_window_vertically to
2349 Qwindow_resize_root_window_vertically.
2350
f13e0b08
PE
23512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2354
94515237
JB
23552011-06-27 Juanma Barranquero <lekktu@gmail.com>
2356
2357 * makefile.w32-in: Redesign dependencies so they reflect more
2358 clearly which files are directly included by each source file,
2359 and not through other includes.
2360
e43b6e43
MR
23612011-06-27 Martin Rudalics <rudalics@gmx.at>
2362
2363 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2364 (sort_overlays, overlay_strings): When an overlay's clone number
2365 matches the window's clone number process the overlay even if
2366 the overlay's window property doesn't match the current window.
2367
d68443dc
MR
2368 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2369 (Fwindow_hchild): Rename to Fwindow_left_child.
2370 (Fwindow_next): Rename to Fwindow_next_sibling.
2371 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2372 (resize_window_check): Rename to window_resize_check.
2373 (resize_window_apply): Rename to window_resize_apply.
2374 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2375 (Fdelete_other_windows_internal, resize_frame_windows)
2376 (Fsplit_window_internal, Fdelete_window_internal)
2377 (grow_mini_window, shrink_mini_window)
2378 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2379
c7e73be5
JD
23802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2381
2382 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2383 (emacs_fixed_set_min_size): Remove.
2384 (emacs_fixed_new): Take frame as argument.
2385
2386 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2387 (_EmacsFixedPrivate): Remove minwidth/height.
2388 Add struct frame *f.
2389 (emacs_fixed_init): Initialize priv->f.
2390 (get_parent_class, emacs_fixed_set_min_size): Remove.
2391 (emacs_fixed_new): Set priv->f to argument.
2392 (emacs_fixed_get_preferred_width)
2393 (emacs_fixed_get_preferred_height): Use min_width/height from
2394 frames size_hint to set minimum and natural (Bug#8919).
2395 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2396 and use min_width/height from frames size_hint to set
2397 min_width/height (Bug#8919).
2398
2399 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2400 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2401 Fix indentation.
c7e73be5 2402
cf99dcf8
EZ
24032011-06-26 Eli Zaretskii <eliz@gnu.org>
2404
2405 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2406 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2407 called at ZV.
2408
029529ac
CY
24092011-06-26 Chong Yidong <cyd@stupidchicken.com>
2410
2411 * process.c (wait_reading_process_output): Bypass select if
2412 waiting for a cell while ignoring keyboard input, and input is
2413 pending. Suggested by Jan Djärv (Bug#8869).
2414
7a7ef429
PE
24152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 Use gnulib's dup2 module instead of rolling our own.
2418 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2419
11fdef7d 24202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2421
2422 * dispnew.c (scrolling_window): Before scrolling, turn off a
2423 mouse-highlight in the window being scrolled.
2424
cd3520a4
JB
24252011-06-24 Juanma Barranquero <lekktu@gmail.com>
2426
2427 Move DEFSYM to lisp.h and use everywhere.
2428
2429 * character.h (DEFSYM): Move declaration...
2430 * lisp.h (DEFSYM): ...here.
2431
2432 * gnutls.c:
2433 * minibuf.c:
2434 * w32menu.c:
2435 * w32proc.c:
2436 * w32select.c: Don't include character.h.
2437
2438 * alloc.c (syms_of_alloc):
2439 * buffer.c (syms_of_buffer):
2440 * bytecode.c (syms_of_bytecode):
2441 * callint.c (syms_of_callint):
2442 * casefiddle.c (syms_of_casefiddle):
2443 * casetab.c (init_casetab_once):
2444 * category.c (init_category_once, syms_of_category):
2445 * ccl.c (syms_of_ccl):
2446 * cmds.c (syms_of_cmds):
2447 * composite.c (syms_of_composite):
2448 * dbusbind.c (syms_of_dbusbind):
2449 * dired.c (syms_of_dired):
2450 * dispnew.c (syms_of_display):
2451 * doc.c (syms_of_doc):
2452 * editfns.c (syms_of_editfns):
2453 * emacs.c (syms_of_emacs):
2454 * eval.c (syms_of_eval):
2455 * fileio.c (syms_of_fileio):
2456 * fns.c (syms_of_fns):
2457 * frame.c (syms_of_frame):
2458 * fringe.c (syms_of_fringe):
2459 * insdel.c (syms_of_insdel):
2460 * keymap.c (syms_of_keymap):
2461 * lread.c (init_obarray, syms_of_lread):
2462 * macros.c (syms_of_macros):
2463 * msdos.c (syms_of_msdos):
2464 * print.c (syms_of_print):
2465 * process.c (syms_of_process):
2466 * search.c (syms_of_search):
2467 * sound.c (syms_of_sound):
2468 * syntax.c (init_syntax_once, syms_of_syntax):
2469 * terminal.c (syms_of_terminal):
2470 * textprop.c (syms_of_textprop):
2471 * undo.c (syms_of_undo):
2472 * w32.c (globals_of_w32):
2473 * window.c (syms_of_window):
2474 * xdisp.c (syms_of_xdisp):
2475 * xfaces.c (syms_of_xfaces):
2476 * xfns.c (syms_of_xfns):
2477 * xmenu.c (syms_of_xmenu):
2478 * xsettings.c (syms_of_xsettings):
2479 * xterm.c (syms_of_xterm): Use DEFSYM.
2480
4228cf16
TZ
24812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2482
cd3520a4 2483 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2484
7fcccf1e
PE
24852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2486
7efb4e0e
PE
2487 Integer and buffer overflow fixes (Bug#8873).
2488
ff5844ad
PE
2489 * print.c (printchar, strout): Check for string overflow.
2490 (PRINTPREPARE, printchar, strout):
2491 Don't set size unless allocation succeeds.
2492
90532f02
PE
2493 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2494 for sizes. Check for string overflow more accurately.
2495 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2496
6d84508d
PE
2497 * macros.c: Integer and buffer overflow fixes.
2498 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2499 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2500 Use ptrdiff_t, not int, for sizes.
2501 Don't increment bufsize until after realloc succeeds.
2502 Check for size-calculation overflow.
2503 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2504
437b2cb4
PE
2505 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2506
8b9ac8b4
PE
2507 * lread.c: Integer overflow fixes.
2508 (read_integer): Radix is now EMACS_INT, not int,
2509 to improve quality of diagnostics for out-of-range radices.
2510 Calculate buffer size correctly for out-of-range radices.
2511 (read1): Check for integer overflow in radices, and in
2512 read-circle numbers.
82cb60d3
PE
2513 (read_escape): Avoid int overflow.
2514 (Fload, openp, read_buffer_size, read1)
2515 (substitute_object_recurse, read_vector, read_list, map_obarray):
2516 Use ptrdiff_t, not int, for sizes.
2517 (read1): Use EMACS_INT, not int, for sizes.
20270765 2518 Check for size overflow.
8b9ac8b4 2519
7fcccf1e
PE
2520 * image.c (cache_image): Check for size arithmetic overflow.
2521
bfbbd7e7
PE
2522 * lread.c: Integer overflow issues.
2523 (saved_doc_string_size, saved_doc_string_length)
2524 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2525 Now ptrdiff_t, not int.
2526 (read1): Don't assume doc string length fits in int. Check for
2527 out-of-range doc string lengths.
2528 (read_list): Don't assume file position fits in int.
39019e54 2529 (read_escape): Check for hex character overflow.
bfbbd7e7 2530
4e323265
LL
25312011-06-22 Leo Liu <sdl.web@gmail.com>
2532
2533 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2534 Move to minibuffer.el.
2535
85fece3e
PE
25362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2537
20b84ce9 2538 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2539 The following patches are for when GLYPH_DEBUG && !XASSERT.
2540 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2541 * dispnew.c (flush_stdout):
2542 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2543 Mark as externally visible.
2544 * dispnew.c (check_window_matrix_pointers): Now static.
2545 * dispnew.c (window_to_frame_vpos):
2546 * xfns.c (unwind_create_frame):
2547 * xterm.c (x_check_font): Remove unused local.
2548 * scroll.c (CHECK_BOUNDS):
2549 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2550 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2551 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2552 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2553 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2554 Now static.
2555 (debug_method_add): Use va_list and vsprintf rather than relying
2556 on undefined behavior with wrong number of arguments.
2557 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2558 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2559 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2560 since we're not interested in debugging glyphs with old libraries.
2561 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2562 GCC 4.6.0's static checking.
2563
0766b489
PE
25642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2565
31fd4b32
PE
2566 Integer overflow and signedness fixes (Bug#8873).
2567 A few related buffer overrun fixes, too.
2568
b79e8648
PE
2569 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2570
0766b489
PE
2571 * dispextern.h (struct face.stipple):
2572 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2573 (x_bitmap_mask, x_allocate_bitmap_record)
2574 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2575 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2576 (x_create_bitmap_from_xpm_data):
2577 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2578 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2579 (.bitmaps_last):
2580 * xfaces.c (load_pixmap):
2581 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2582 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2583 (.bitmaps_last, struct x_output.icon_bitmap):
2584 Use ptrdiff_t, not int, for bitmap indexes.
2585 (x_allocate_bitmap_record): Check for size overflow.
2586 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2587
b081724f
PE
2588 Use ptrdiff_t, not int, for overlay counts.
2589 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2590 * editfns.c (overlays_around, get_pos_property):
2591 * textprop.c (get_char_property_and_overlay):
2592 * xdisp.c (next_overlay_change, note_mouse_highlight):
2593 * xfaces.c (face_at_buffer_position):
21514da7
PE
2594 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2595 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2596 (Fnext_overlay_change, Fprevious_overlay_change)
2597 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2598 Use ptrdiff_t, not int, for sizes.
21514da7 2599 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2600
3de73e5e
PE
2601 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2602
2606c57b
PE
2603 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2604 (x_session_initialize): Do not assume string length fits in int.
2605
aaafe47a
PE
2606 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2607 This is unlikely, but can occur if DPI is outlandish.
2608
2674ddc8 2609 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2610 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2611
28154962
PE
2612 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2613 * xrdb.c (magic_file_p, search_magic_path):
2614 Omit last arg SUFFIX; it was always 0. All callers changed.
2615 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2616
7de51af5
PE
2617 * xfont.c (xfont_match): Avoid need for strlen.
2618
25ed6cc3
PE
2619 * xfns.c: Don't assume strlen fits in int.
2620 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2621
4eab31dd
PE
2622 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2623 not unsigned long, as we prefer signed integers. All callers changed.
2624 Detect integer overflow in repeat count.
2625 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2626 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2627
171e2a58
PE
2628 * termcap.c: Don't assume sizes fit in int and never overflow.
2629 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2630 (gobble_line): Check for size-calculation overflow.
2631
ad39faca 2632 * minibuf.c (Fread_buffer):
6e5bb2dc 2633 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2634 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2635 Don't assume string length fits in int.
2636
52c61c22 2637 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2638 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2639
b5b8c9e5
PE
2640 * font.c: Don't assume string length fits in int.
2641 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2642 Use ptrdiff_t, not int.
ccd6111c
PE
2643 (font_intern_prop): Don't assume string length fits in int.
2644 Don't assume integer property fits in fixnum.
2645 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2646
882f0d81 2647 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2648 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2649 Reformulate so as not to need the command string.
2650 Invoke gzip -cd rather than gunzip, as it's more portable.
2651 (lock_info_type, lock_file_1, lock_file):
2652 Don't assume pid_t and time_t fit in unsigned long.
2653 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2654 (current_lock_owner): Prefer signed type for sizes.
2655 Use memcpy, not strncpy, where memcpy is what is really wanted.
2656 Don't assume (via atoi) that time_t and pid_t fit in int.
2657 Check for time_t and/or pid_t out of range, e.g., via a network share.
2658 Don't alloca where an auto var works fine.
2659
93f4cf88
PE
2660 * fileio.c: Fix some integer overflow issues.
2661 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2662 Don't assume string length fits in int.
2663 (directory_file_name): Don't assume string length fits in long.
2664 (make_temp_name): Don't assume pid fits in int, or that its print
2665 length is less than 20.
2666
f3e92b69
PE
2667 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2668
1bfdaf10
PE
2669 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2670
35016e9a
PE
2671 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2672
3d1e65a1
PE
2673 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2674 We prefer signed integers, even for size calculations.
2675
0b963a93
PE
2676 * emacs.c: Don't assume string length fits in 'int'.
2677 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2678 (main): Don't invoke strlen when not needed.
2679
573f4b54
PE
2680 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2681 (XD_DEBUG_MESSAGE): Don't waste a byte.
2682
989f33ba
PE
2683 * callproc.c (getenv_internal_1, getenv_internal)
2684 (Fgetenv_internal):
965d34eb
PE
2685 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2686
e4d29b33
PE
2687 * lread.c (invalid_syntax): Omit length argument.
2688 All uses changed. This doesn't fix a bug, but it simplifies the
2689 code away from its former Hollerith-constant appearance, and it's
2690 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2691 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2692
eb49b136
PE
2693 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2694 This didn't break anything, but it didn't help either.
2695 It's confusing to put a bogus integer in a place where the actual
2696 value does not matter.
9f62aeb1 2697 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2698 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2699
15375a22
PE
2700 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2701 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2702 implementation.
b61cc01c
PE
2703 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2704 We prefer signed types, and the value cannot exceed the EMACS_INT
2705 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2706 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2707 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2708 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2709
53b2623d
PE
2710 * indent.c (sane_tab_width): New function.
2711 (current_column, scan_for_column, Findent_to, position_indentation)
2712 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2713 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2714
51cab52b 2715 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2716
f2ed8a70
PE
2717 * lisp.h (lint_assume): New macro.
2718 * composite.c (composition_gstring_put_cache):
2719 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2720
abe80cc6
PE
2721 * editfns.c, insdel.c:
2722 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2723
b02c740e
PE
2724 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2725
ebc96716
PE
2726 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2727
b4e50fa0 2728 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2729 Use much-faster test for byte-length change.
311d5d7c 2730 Don't assume string byte-length fits in 'int'.
a4cf38e4 2731 Check that character arg fits in 'int'.
85461888 2732 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2733
c0c1ee9f
PE
2734 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2735
a498d7f4
PE
2736 * fns.c (concat): Catch string overflow earlier.
2737 Do not rely on integer wraparound.
2738
51cab52b
PE
2739 * dispextern.h (struct it.overlay_strings_charpos)
2740 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2741 * xdisp.c (forward_to_next_line_start)
2742 (back_to_previous_visible_line_start)
2743 (reseat_at_next_visible_line_start, next_element_from_buffer):
2744 Don't arbitrarily truncate the value of 'selective' to int.
2745
76031fad
PE
2746 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2747
5eb55db9
PE
2748 * composite.c: Don't truncate sizes to 'int'.
2749 (composition_gstring_p, composition_reseat_it)
2750 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2751 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2752 not EMACS_UINT, for indexes.
5eb55db9 2753
0703a717
PE
2754 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2755
d6202519
PE
2756 * buffer.c: Include <verify.h>.
2757 (struct sortvec.priority, struct sortstr.priority):
8961a454 2758 Now EMACS_INT, not int.
c20998a7 2759 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2760 (struct sortstr.size, record_overlay_string)
2761 (struct sortstrlist.size, struct sortlist.used):
2762 Don't truncate size to int.
2763 (record_overlay_string): Check for size-calculation overflow.
d6202519 2764 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2765
d5a19415
JM
27662011-06-22 Jim Meyering <meyering@redhat.com>
2767
029529ac 2768 Don't leak an XBM-image-sized buffer
d5a19415
JM
2769 * image.c (xbm_load): Free the image buffer after using it.
2770
a9041e6c
PE
27712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 Port to Sun C.
2774 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2775 that Sun C diagnosed.
2776 * fns.c (secure_hash): Fix pointer signedness issue.
2777 * intervals.c (static_offset_intervals): New function.
2778 (offset_intervals): Use it.
2779
7f3f739f
LL
27802011-06-21 Leo Liu <sdl.web@gmail.com>
2781
2782 * deps.mk (fns.o):
2783 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2784 sha512.h.
2785
2786 * fns.c (secure_hash): Rename from crypto_hash_function and change
2787 the first arg to accept symbols.
5b66d427 2788 (Fsecure_hash): New primitive.
7f3f739f
LL
2789 (syms_of_fns): New symbols.
2790
76147d94
DD
27912011-06-20 Deniz Dogan <deniz@dogan.se>
2792
2793 * process.c (Fset_process_buffer): Clarify return value in
2794 docstring.
2795
7d7d0045
CY
27962011-06-18 Chong Yidong <cyd@stupidchicken.com>
2797
2798 * dispnew.c (add_window_display_history): Use BVAR.
2799
2800 * xdisp.c (debug_method_add): Use BVAR.
2801 (check_window_end, dump_glyph_matrix, dump_glyph)
2802 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2803
2804 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2805 Likewise.
2806
2807 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2808 check till after the cache is created in init_frame_faces.
2809
ff2bc410
SM
28102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2811
2812 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2813
28177add
PE
28142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2815
dd3482fe
PE
2816 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2817 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2818 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2819
393d71f3 2820 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2821 * fileio.c (Finsert_file_contents):
2822 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2823 Remove the old (too-loose) buffer overflow checks.
2824 They weren't needed, since make_gap checks for buffer overflow.
2825 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2826 The old code merely checked for Emacs fixnum overflow, and relied
2827 on undefined (wraparound) behavior. The new code avoids undefined
2828 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2829
2e6813b0 2830 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2831 Tune. Don't use wider integers than needed. Don't use alloca.
2832 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2833
599a9e4f
PE
2834 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2835
99561444
PE
2836 * insdel.c, lisp.h (buffer_overflow): New function.
2837 (insert_from_buffer_1, replace_range, replace_range_2):
2838 * insdel.c (make_gap_larger):
2839 * editfns.c (Finsert_char):
2840 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2841
28177add
PE
2842 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2843
e69dafad
PE
28442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2845
a7af7fde 2846 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2847
b1c46f02
PE
2848 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2849 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2850
e69dafad
PE
2851 * fileio.c: Don't assume EMACS_INT fits in off_t.
2852 (emacs_lseek): New static function.
2853 (Finsert_file_contents, Fwrite_region): Use it.
2854 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2855
566684ea
PE
2856 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2857
e6966cd6
PE
2858 * fns.c: Don't overflow int when computing a list length.
2859 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2860 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2861 truncation on 64-bit hosts. Check for QUIT every
2862 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2863 faster and is responsive enough.
2864 (Flength): Report an error instead of overflowing an integer.
2865 (Fsafe_length): Return a float if the value is not representable
2866 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2867 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2868 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2869
dd0b0efb
PE
2870 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2871 (header_size, word_size): New constants.
2872 (allocate_vectorlike): Don't check size overflow here.
2873 (allocate_vector): Check it here instead, since this is the only
2874 caller of allocate_vectorlike that could cause overflow.
2875 Check that the new vector's length is representable as a fixnum.
2876
86fe5cfe
PE
2877 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2878 The previous code was bogus. For example, next_almost_prime (32)
2879 returned 39, which is undesirable as it is a multiple of 3; and
2880 next_almost_prime (24) returned 25, which is a multiple of 5 so
2881 why was the code bothering to check for multiples of 7?
2882
80e88859
PE
2883 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2884
4a2f0ad6
PE
2885 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2886
f66c7cf8
PE
2887 Variadic C functions now count arguments with ptrdiff_t.
2888 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2889 Back then I didn't know that the Emacs coding style prefers signed int.
2890 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2891 were being counted with int, which may truncate counts on 64-bit
2892 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2893 * lisp.h (struct Lisp_Subr.function.aMANY)
2894 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2895 Arg counts are now ptrdiff_t, not size_t.
2896 All variadic functions and their callers changed accordingly.
2897 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2898 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2899 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2900 * callint.c (Fcall_interactively): Check arg count for overflow,
2901 to avoid potential buffer overrun. Use signed char, not 'int',
2902 for 'varies' array, so that we needn't bother to check its size
2903 calculation for overflow.
2904 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2905 * eval.c (apply_lambda):
2906 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2907 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2908 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2909
a1759b76
PE
2910 * callint.c (Fcall_interactively): Don't use index var as event count.
2911
d96be9fc
PE
2912 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2913 * mem-limits.h (SIZE): Remove; no longer used.
2914
a690a978 2915 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2916
578c21e6
PE
2917 Remove unnecessary casts.
2918 * xterm.c (x_term_init):
2919 * xfns.c (x_set_border_pixel):
2920 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2921 These aren't needed now that we assume ANSI C.
2922
96f53c6c
PE
2923 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2924 It's more likely to cause problems (due to unsigned overflow)
2925 than to cure them.
2926
83c77d31
PE
2927 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2928
ee2079f1
PE
2929 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2930
6da65536
PE
2931 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2932
7147c4a4
PE
2933 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2934
193e32d9
PE
2935 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2936
e5533da6
PE
2937 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2938
9910e595
PE
2939 GLYPH_CODE_FACE returns EMACS_INT, not int.
2940 * dispextern.h (merge_faces):
2941 * xfaces.c (merge_faces):
01103c44
PE
2942 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2943 Don't assume EMACS_INT fits in int.
9910e595 2944
2638320e
PE
2945 * character.h (CHAR_VALID_P): Remove unused parameter.
2946 * fontset.c, lisp.h, xdisp.c: All uses changed.
2947
045eb8d9
PE
2948 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2949
c1f134b5
PE
2950 * fns.c (concat): Minor tuning based on overflow analysis.
2951 This doesn't fix any bugs. Use int to hold character, instead
2952 of constantly refetching from Emacs object. Use XFASTINT, not
2953 XINT, for value known to be a character. Don't bother comparing
2954 a single byte to 0400, as it's always less.
2955
395fcb93 2956 * floatfns.c (Fexpt):
327eeec8
PE
2957 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2958
abbd3d23
PE
2959 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2960 for characters.
2961
684a03ef
PE
2962 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2963
0fed43f3
PE
2964 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2965 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2966 incorrectly succeed when S was a string, because 4294967386 was
2967 truncated before it was used.
2968
8fd02eb7
PE
2969 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2970 Otherwise, an out-of-range integer could cause undefined behavior
2971 on a 64-bit host.
2972
f8c86b69
PE
2973 * composite.c: Use int, not EMACS_INT, for characters.
2974 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2975 EMACS_INT, for values that are known to be in character range.
2976 This doesn't fix any bugs but is the usual style inside Emacs and
2977 may generate better code on 32-bit machines.
2978
34206dd2
PE
2979 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2980 This is for reasons similar to the recent CHAR_STRING fix.
2981 * charset.c (Fencode_char): Check that character arg is actually
2982 a character. Pass an int to ENCODE_CHAR.
2983 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2984 wider than 'int', as a compile-time check to prevent future regressions
2985 in this area.
2986
c5958d4c 2987 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2988
2989 Make sure a 64-bit char is never passed to CHAR_STRING.
2990 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2991 by silently ignoring the top 32 bits, allowing some values
2992 that were far too large to be valid characters.
2993 * character.h: Include <verify.h>.
2994 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2995 arguments are no wider than unsigned, as a compile-time check
2996 to prevent future regressions in this area.
2997 * data.c (Faset):
01103c44 2998 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2999 (Fsubst_char_in_region):
3000 * fns.c (concat):
3001 * xdisp.c (decode_mode_spec_coding):
3002 Adjust to CHAR_STRING's new requirement.
3003 * editfns.c (Finsert_char, Fsubst_char_in_region):
3004 * fns.c (concat): Check that character args are actually
3005 characters. Without this test, these functions did the wrong
3006 thing with wildly out-of-range values on 64-bit hosts.
3007
d37ca623
PE
3008 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3009 These casts should not be needed on 32-bit hosts, either.
3010 * keyboard.c (read_char):
3011 * lread.c (Fload): Remove casts to unsigned.
3012
ea204efb
PE
3013 * lisp.h (UNSIGNED_CMP): New macro.
3014 This fixes comparison bugs on 64-bit hosts.
3015 (ASCII_CHAR_P): Use it.
3016 * casefiddle.c (casify_object):
01103c44 3017 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3018 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3019 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3020 * dispextern.h (FACE_FROM_ID):
3021 * keyboard.c (read_char): Use UNSIGNED_CMP.
3022
41cb286c
PE
3023 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3024 not to EMACS_INT, to avoid GCC warning.
3025
4a1b9832
PE
3026 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3027
55daad71
PE
3028 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3029 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3030 isn't needed on 32-bit machines.
8f95c75c 3031
01103c44
PE
3032 * buffer.c (Fgenerate_new_buffer_name):
3033 Use EMACS_INT for count, not int.
0ceccced 3034 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3035
3036 * data.c (Qcompiled_function): Now static.
3037
c6f072e7
PE
3038 * window.c (window_body_lines): Now static.
3039
20ce5912
PE
3040 * image.c (gif_load): Rename local to avoid shadowing.
3041
9c4c5f81
PE
3042 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3043 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3044 * alloc.c (make_save_value): Integer argument is now of type
3045 ptrdiff_t, not int.
3046 (mark_object): Use ptrdiff_t, not int.
3047 * lisp.h (pD): New macro.
3048 * print.c (print_object): Use it.
3049
c0c5c8ae
PE
3050 * alloc.c: Use EMACS_INT, not int, to count objects.
3051 (total_conses, total_markers, total_symbols, total_vector_size)
3052 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3053 (total_free_floats, total_floats, total_free_intervals)
3054 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3055 Now EMACS_INT, not int. All uses changed.
3056 (Fgarbage_collect): Compute overall total using a double, so that
3057 integer overflow is less likely to be a problem. Check for overflow
3058 when converting back to an integer.
5a25e253
PE
3059 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3060 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3061 These were 'int' variables that could overflow on 64-bit hosts;
3062 they were never used, so remove them instead of repairing them.
211a0b2a 3063 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3064 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3065 Previously, this ceilinged at INT_MAX, but that doesn't work on
3066 64-bit machines.
e46bb31a 3067 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3068
c78baabf 3069 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3070 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3071 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3072 when a (possibly-narrower) signed value would do just as well.
3073 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3074
c9d624c6
PE
3075 * alloc.c: Catch some string size overflows that we were missing.
3076 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3077 for convenience in STRING_BYTES_MAX.
3078 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3079 The definition here is exact; the one in lisp.h was approximate.
3080 (allocate_string_data): Check for string overflow. This catches
3081 some instances we weren't catching before. Also, it catches
3082 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3083 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3084 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3085
c9d624c6
PE
3086 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3087 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3088 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3089
353032ce
PE
3090 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3091
2bccce07
PE
3092 * alloc.c (Fmake_string): Check for out-of-range init.
3093
0ac30604
SM
30942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3095
3096 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3097
c195f2de
JD
30982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3099
3100 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3101 xg_get_default_scrollbar_width.
3102
3103 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3104 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3105 (style_changed_cb): Call update_theme_scrollbar_width and call
3106 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3107 all frames (Bug#8505).
3108 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3109 Call gtk_window_set_resizable if HAVE_GTK3.
3110 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3111 and height if HAVE_GTK3 (Bug#8505).
3112 (scroll_bar_width_for_theme): New variable.
3113 (update_theme_scrollbar_width): New function.
3114 (xg_get_default_scrollbar_width): Move code to
3115 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3116 (xg_initialize): Call update_theme_scrollbar_width.
3117
3118 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3119
3120 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3121
e10ac9f1
MR
31222011-06-12 Martin Rudalics <rudalics@gmx.at>
3123
3124 * frame.c (make_frame): Call other_buffer_safely instead of
3125 other_buffer.
3126
3127 * window.c (temp_output_buffer_show): Call display_buffer with
3128 second argument Vtemp_buffer_show_specifiers and reset latter
3129 immediately after the call.
3130 (Vtemp_buffer_show_specifiers): New variable.
3131 (auto_window_vscroll_p, next_screen_context_lines)
3132 (Vscroll_preserve_screen_position): Remove leading asterisks from
3133 doc-strings.
3134
2d3c217e 31352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3136
7b7f97e8 3137 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3138 * buffer.c (Qclone_number): Remove for now, as it's unused.
3139 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3140 (record_buffer): Remove unused local.
3141 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3142 (set_frame_buffer_list): Remove; unused.
3143 * frame.h (other_visible_frames): Remove decl.
3144 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3145 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3146 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3147 if HAVE_GPM.
3148 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3149 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3150 Define only if HAVE_GPM.
3151 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3152 (update_hints_inhibit): Remove; never set. All uses removed.
3153 * widgetprv.h (emacsFrameClassRec): Remove decl.
3154 * window.c (delete_deletable_window): Now returns void, since it
3155 wasn't returning anything.
3156 (compare_window_configurations): Remove unused locals.
3157 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3158 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3159 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3160 the same widths as pointers. This follows up on the 2011-05-06 patch.
3161 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3162 * xterm.h: Likewise.
3163 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3164
1384b89e
JB
31652011-06-12 Juanma Barranquero <lekktu@gmail.com>
3166
3167 * makefile.w32-in: Update dependencies.
3168 (LISP_H): Add lib/intprops.h.
3169
1100a63c
CY
31702011-06-11 Chong Yidong <cyd@stupidchicken.com>
3171
3172 * image.c (gif_load): Add animation frame delay to the metadata.
3173 (syms_of_image): Use DEFSYM. New symbol `delay'.
3174
6198ccd0
MR
31752011-06-11 Martin Rudalics <rudalics@gmx.at>
3176
3177 * window.c (delete_deletable_window): Re-add.
3178 (Fset_window_configuration): Rewrite to handle dead buffers and
3179 consequently deletable windows.
3180 (window_tree, Fwindow_tree): Remove. Supply functionality in
3181 window.el.
3182 (compare_window_configurations): Simplify code.
3183
b6e3633c
AS
31842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3185
1ab0dee5
AS
3186 * image.c (imagemagick_load_image): Fix type mismatch.
3187 (Fimagemagick_types): Likewise.
3188
b6e3633c
AS
3189 * window.h (replace_buffer_in_windows): Declare.
3190
9397e56f
MR
31912011-06-11 Martin Rudalics <rudalics@gmx.at>
3192
3193 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3194 Qclone_number. Remove external declaration of Qdelete_window.
3195 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3196 code.
640c8776
SM
3197 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3198 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3199 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3200 buffer list implementation.
3201 (other_buffer_safely): New function.
3202 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3203 calls to replace_buffer_in_windows and
3204 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3205 if allowed.
3206 (record_buffer): Inhibit quitting and rewrite using quittable
3207 functions. Run Qbuffer_list_update_hook if allowed.
3208 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3209 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3210 Move switch-to-buffer to window.el.
9397e56f
MR
3211 (bury-buffer): Move to window.el.
3212 (Vbuffer_list_update_hook): New variable.
3213
3214 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3215 section.
3216
3217 * window.h (resize_frame_windows): Move up in code.
3218 (Fwindow_frame): Remove EXFUN.
3219 (replace_buffer_in_all_windows): Remove prototype.
3220 (replace_buffer_in_windows_safely): Add prototype.
3221
3222 * window.c: Declare Qdelete_window static again. Move down
3223 declaration of select_count.
3224 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3225 (Fother_window): Move to window.el.
3226 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3227 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3228 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3229 window.el.
3230 (replace_buffer_in_windows): Implement by calling
3231 Qreplace_buffer_in_windows.
3232 (replace_buffer_in_all_windows): Remove with some functionality
3233 moved into replace_buffer_in_windows_safely.
3234 (replace_buffer_in_windows_safely): New function.
3235 (select_window_norecord, select_frame_norecord): Move in front
3236 of run_window_configuration_change_hook. Remove now obsolete
3237 declarations.
640c8776
SM
3238 (Fset_window_buffer): Rewrite doc-string.
3239 Call Qrecord_window_buffer.
9397e56f
MR
3240 (keys_of_window): Move binding for other-window to window.el.
3241
b50691aa
CY
32422011-06-11 Chong Yidong <cyd@stupidchicken.com>
3243
3244 * dispextern.h (struct image): Replace data member, whose int_val
3245 and ptr_val fields were not used by anything, with a single
3246 lisp_val object.
3247
3248 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3249 (gif_clear_image, gif_load, imagemagick_load_image)
3250 (gs_clear_image, gs_load): Callers changed.
3251
3f754b86
PE
32522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3253
cca69397
PE
3254 * buffer.h: Include <time.h>, for time_t.
3255 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3256
109e28d0
PE
3257 Fix minor problems found by static checking.
3258
60737f02
PE
3259 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3260
4b66faf3
PE
3261 Make identifiers static if they are not used in other modules.
3262 * data.c (Qcompiled_function, Qframe, Qvector):
3263 * image.c (QimageMagick, Qsvg):
3264 * minibuf.c (Qmetadata):
3265 * window.c (resize_window_check, resize_root_window): Now static.
3266 * window.h (resize_window_check, resize_root_window): Remove decls.
3267
109e28d0
PE
3268 * window.c (window_deletion_count, delete_deletable_window):
3269 Remove; unused.
46a4ce9e
PE
3270 (window_body_lines): Now static.
3271 (Fdelete_other_windows_internal): Mark vars as initialized.
3272 Make sure 'resize_failed' is initialized.
3273 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3274 (resize_window_apply): Remove unused local.
3275 * window.h (delete_deletable_window): Remove decl.
3276
109e28d0 3277 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3278 (imagemagick_load_image): Fix pointer signedness problem by changing
3279 last arg from unsigned char * to char *. All uses changed.
3280 Also, fix a local for similar reasons.
3281 Remove unused locals. Remove locals to avoid shadowing.
3282 (fn_rsvg_handle_free): Remove; unused.
3283 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3284 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3285
3f754b86
PE
3286 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3287
2547adb1
CY
32882011-06-10 Chong Yidong <cyd@stupidchicken.com>
3289
3290 * image.c (gif_load): Fix omitted cast error introduced by
3291 2011-06-06 change.
3292
2c8e37d4
MR
32932011-06-10 Martin Rudalics <rudalics@gmx.at>
3294
3295 * window.h (resize_proportionally, orig_total_lines)
3296 (orig_top_line): Remove from window structure.
3297 (set_window_height, set_window_width, change_window_heights)
3298 (Fdelete_window): Remove prototypes.
3299 (resize_frame_windows): Remove duplicate declaration.
3300
440a42e3
EZ
33012011-06-10 Eli Zaretskii <eliz@gnu.org>
3302
3303 * window.h (resize_frame_windows, resize_window_check)
3304 (delete_deletable_window, resize_root_window)
3305 (resize_frame_windows): Declare prototypes.
3306
3307 * window.c (resize_window_apply): Make definition be "static" to
3308 match the prototype.
3309
562dd5e9
MR
33102011-06-10 Martin Rudalics <rudalics@gmx.at>
3311
3312 * window.c: Remove declarations of Qwindow_size_fixed,
3313 window_min_size_1, window_min_size_2, window_min_size,
3314 size_window, window_fixed_size_p, enlarge_window, delete_window.
3315 Remove static from declaration of Qdelete_window, it's
3316 temporarily needed by Fbury_buffer.
3317 (replace_window): Don't assign orig_top_line and
3318 orig_total_lines.
3319 (Fdelete_window, delete_window): Remove. Window deletion is
3320 handled by window.el.
640c8776
SM
3321 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3322 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3323 (Fdelete_other_windows): Remove. Deleting other windows is
3324 handled by window.el.
3325 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3326 handled in window.el.
3327 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3328 Window minimum sizes are handled in window.el.
3329 (shrink_windows, size_window, set_window_height)
3330 (set_window_width, change_window_heights, window_height)
3331 (window_width, CURBEG, CURSIZE, enlarge_window)
3332 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3333 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3334 handled in window.el.
3335 (make_dummy_parent): Rename to make_parent_window and give it a
3336 second argument horflag.
3337 (make_window): Don't set resize_proportionally any more.
3338 (Fsplit_window): Remove. Windows are split in window.el.
3339 (save_restore_action, save_restore_orig_size)
3340 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3341 Resize mini windows in window.el.
3342 (grow_mini_window, shrink_mini_window): Implement by calling
3343 Qresize_root_window_vertically, resize_window_check and
3344 resize_window_apply.
640c8776
SM
3345 (saved_window, Fset_window_configuration, save_window_save):
3346 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3347 resize_proportionally.
3348 (window_min_height, window_min_width): Move to window.el.
3349 (keys_of_window): Move bindings for delete-other-windows,
3350 split-window, delete-window and enlarge-window to window.el.
3351
3352 * buffer.c: Temporarily extern Qdelete_window.
3353 (Fbury_buffer): Temporarily call Qdelete_window instead of
3354 Fdelete_window (Fbury_buffer will move to window.el soon).
3355
3356 * frame.c (set_menu_bar_lines_1): Remove code handling
3357 orig_top_line and orig_total_lines.
3358
3359 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3360 set_window_height but set heights directly.
3361 (change_frame_size_1): Use resize_frame_windows.
3362
3363 * xdisp.c (init_xdisp): Don't use set_window_height but set
3364 heights directly.
3365
640c8776
SM
3366 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3367 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3368 run_window_configuration_change_hook.
3369
3370 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3371 instead of change_window_heights and run
3372 run_window_configuration_change_hook.
3373
1a13852e
MR
33742011-06-09 Martin Rudalics <rudalics@gmx.at>
3375
3376 * window.c (replace_window): Rename second argument REPLACEMENT to
3377 NEW. New third argument SETFLAG. Rewrite.
3378 (delete_window, make_dummy_parent): Call replace_window with
3379 third argument 1.
3380 (window_list_1): Move down in code.
3381 (run_window_configuration_change_hook): Move set_buffer part
3382 before select_frame_norecord part in order to unwind correctly.
3383 Rename count1 to count.
3384 (recombine_windows, delete_deletable_window, resize_root_window)
3385 (Fdelete_other_windows_internal)
3386 (Frun_window_configuration_change_hook, make_parent_window)
3387 (resize_window_check, resize_window_apply, Fresize_window_apply)
3388 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3389 (Fdelete_window_internal, Fresize_mini_window_internal):
3390 New functions.
1a13852e
MR
3391 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3392
f3d1777e
MR
33932011-06-08 Martin Rudalics <rudalics@gmx.at>
3394
496e208e
MR
3395 * window.h (window): Add some new members to window structure -
3396 normal_lines, normal_cols, new_total, new_normal, clone_number,
3397 splits, nest, prev_buffers, next_buffers.
3398 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3399 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3400
f3d1777e
MR
3401 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3402 Remove.
496e208e
MR
3403 (make_dummy_parent): Set new members of windows structure.
3404 (make_window): Move down in code. Handle new members of window
3405 structure.
3406 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3407 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3408 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3409 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3410 (Fset_window_next_buffers, Fset_window_clone_number):
3411 New functions.
496e208e
MR
3412 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3413 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3414 Doc-string fixes.
3415 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3416 Argument WINDOW can be now internal window too.
3417 (Fwindow_use_time): Move up in code.
3418 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3419 Rewrite doc-string.
3420 (Fset_window_configuration, saved_window)
3421 (Fcurrent_window_configuration, save_window_save): Handle new
3422 members of window structure.
b9e809c2
MR
3423 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3424 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3425 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3426 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3427 Qget_mru_window, Qresize_root_window,
3428 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3429 Qauto_buffer_name; staticpro them.
f3d1777e 3430
abde8f8c
MR
34312011-06-07 Martin Rudalics <rudalics@gmx.at>
3432
3433 * window.c (Fwindow_total_size, Fwindow_left_column)
3434 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3435 (Fwindow_list_1): New functions.
3436 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3437 (Fwindow_width, Fscroll_left, Fscroll_right):
3438 Use window_body_cols instead of window_box_text_cols.
3439 (delete_window, Fset_window_configuration):
3440 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3441 (delete_all_subwindows): Take a window as argument and not a
3442 structure. Rewrite.
190b47e6
MR
3443 (window_loop): Remove handling of GET_LRU_WINDOW and
3444 GET_LARGEST_WINDOW.
3445 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3446
3447 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3448 window_box_text_cols. delete_all_subwindows now takes a
3449 Lisp_Object as argument.
abde8f8c 3450
640c8776
SM
3451 * indent.c (compute_motion, Fcompute_motion):
3452 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3453
fa8a67e6
MR
3454 * frame.c (delete_frame): Call delete_all_subwindows with root
3455 window as argument.
3456
a54e3482
DC
34572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3458
3459 * fns.c (Fputhash): Document return value.
3460
60002bf5
CY
34612011-06-06 Chong Yidong <cyd@stupidchicken.com>
3462
3463 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3464
0c671da6 34652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3466
b862a52a 3467 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3468
be44ca6c
PE
3469 Check for overflow when converting integer to cons and back.
3470 * charset.c (Fdefine_charset_internal, Fdecode_char):
3471 Use cons_to_unsigned to catch overflow.
3472 (Fencode_char): Use INTEGER_TO_CONS.
3473 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3474 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3475 * data.c (long_to_cons, cons_to_long): Remove.
3476 (cons_to_unsigned, cons_to_signed): New functions.
3477 These signal an error for invalid or out-of-range values.
3478 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3479 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3480 * font.c (Ffont_variation_glyphs):
3481 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3482 * lisp.h: Include <intprops.h>.
3483 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3484 (cons_to_signed, cons_to_unsigned): New decls.
3485 (long_to_cons, cons_to_long): Remove decls.
3486 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3487 (Fprimitive_undo): Use CONS_TO_INTEGER.
3488 * xfns.c (Fx_window_property): Likewise.
3489 * xselect.c: Include <limits.h>.
3490 (x_own_selection, selection_data_to_lisp_data):
3491 Use INTEGER_TO_CONS.
3492 (x_handle_selection_request, x_handle_selection_clear)
3493 (x_get_foreign_selection, Fx_disown_selection_internal)
3494 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3495 (lisp_data_to_selection_data): Use cons_to_unsigned.
3496 (x_fill_property_data): Use cons_to_signed.
3497 Report values out of range.
3498
d1f3d2af
PE
3499 Check for buffer and string overflow more precisely.
3500 * buffer.h (BUF_BYTES_MAX): New macro.
3501 * lisp.h (STRING_BYTES_MAX): New macro.
3502 * alloc.c (Fmake_string):
3503 * character.c (string_escape_byte8):
3504 * coding.c (coding_alloc_by_realloc):
3505 * doprnt.c (doprnt):
3506 * editfns.c (Fformat):
3507 * eval.c (verror):
3508 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3509 since they may not be the same number.
3510 * editfns.c (Finsert_char):
3511 * fileio.c (Finsert_file_contents):
3512 Likewise for BUF_BYTES_MAX.
3513
dd52fcea
PE
3514 * image.c: Use ptrdiff_t, not int, for sizes.
3515 (slurp_file): Switch from int to ptrdiff_t.
3516 All uses changed.
3517 (slurp_file): Check that file size fits in both size_t (for
3518 malloc) and ptrdiff_t (for sanity and safety).
3519
7f9bbdbb
PE
3520 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3521 if b->modtime has its maximal value.
3522
dfe18f82
PE
3523 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3524
84acfcf0
PE
3525 Don't assume time_t can fit into int.
3526 * buffer.h (struct buffer.modtime): Now time_t, not int.
3527 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3528 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3529
ccd9a01a
PE
3530 Minor fixes for signed vs unsigned integers.
3531 * character.h (MAYBE_UNIFY_CHAR):
3532 * charset.c (maybe_unify_char):
3533 * keyboard.c (read_char, reorder_modifiers):
3534 XINT -> XFASTINT, since the integer must be nonnegative.
3535 * ftfont.c (ftfont_spec_pattern):
3536 * keymap.c (access_keymap, silly_event_symbol_error):
3537 XUINT -> XFASTINT, since the integer must be nonnegative.
3538 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3539 since it makes no difference and we prefer signed.
3540 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3541 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3542 nonnegative.
3543
d6d100dd
SM
35442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3545
3546 * window.h (Fwindow_frame): Declare.
3547
2b6148e4
PE
35482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3549
3550 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3551 (SPARE_MEMORY): Always define.
3552 (LARGE_REQUEST): Remove.
3553 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3554
f230ecc9
MR
35552011-06-06 Martin Rudalics <rudalics@gmx.at>
3556
727e958e
MR
3557 * lisp.h: Move EXFUNS for Fframe_root_window,
3558 Fframe_first_window and Fset_frame_selected_window to window.h.
3559
3560 * window.h: Move EXFUNS for Fframe_root_window,
3561 Fframe_first_window and Fset_frame_selected_window here from
3562 lisp.h.
3563
3564 * frame.c (Fwindow_frame, Fframe_first_window)
3565 (Fframe_root_window, Fframe_selected_window)
3566 (Fset_frame_selected_window): Move to window.c.
3567 (Factive_minibuffer_window): Move to minibuf.c.
3568 (Fother_visible_frames_p): New function.
3569
3570 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3571
f230ecc9
MR
3572 * window.c (decode_window, decode_any_window): Move up in code.
3573 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3574 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3575 (Fwindow_buffer): Move up and rewrite doc-string.
3576 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3577 (Fwindow_prev): New functions.
727e958e
MR
3578 (Fwindow_frame): Move here from frame.c. Accept any window as
3579 argument.
3580 (Fframe_root_window, Fframe_first_window)
3581 (Fframe_selected_window): Move here from frame.c. Accept frame
3582 or arbitrary window as argument. Update doc-strings.
3583 (Fminibuffer_window): Move up in code.
3584 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3585 (Fset_frame_selected_window): Move here from frame.c.
3586 Marginal rewrite.
727e958e
MR
3587 (Fselected_window, select_window, Fselect_window): Move up in
3588 code. Minor doc-string fixes.
f230ecc9 3589
4d09bcf6
PE
35902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3593 Do not assume that spare memory exists; that assumption is valid
3594 only if SYSTEM_MALLOC.
3595 (LARGE_REQUEST): New macro, so that the issue of large requests
3596 is separated from the issue of spare memory.
3597
810928a2
AS
35982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3599
172418ad
AS
3600 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3601 format. (Bug#8806)
3602
43f862f7
AS
3603 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3604
810928a2
AS
3605 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3606 before statements.
3607
a059fe24
JD
36082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3609
3610 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3611
3612 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3613
3614 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3615 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3616
989bf368
JB
36172011-06-05 Juanma Barranquero <lekktu@gmail.com>
3618
3619 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3620
4b80f674
CY
36212011-06-04 Chong Yidong <cyd@stupidchicken.com>
3622
3623 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3624 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3625 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3626 New error handlers.
4b80f674
CY
3627 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3628 Obey Vx_select_enable_clipboard_manager. Catch errors in
3629 x_clipboard_manager_save (Bug#8779).
3630 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3631 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3632
99a33b77 36332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3634
3635 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3636
99a33b77 36372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3638
3639 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3640 in the current matrix if keep_current_p is non-zero.
3641
8264569d
EZ
36422011-06-04 Eli Zaretskii <eliz@gnu.org>
3643
3644 * bidi.c (bidi_level_of_next_char): Fix last change.
3645
57f97249
EZ
36462011-06-03 Eli Zaretskii <eliz@gnu.org>
3647
fec2107c 3648 Support bidi reordering of text covered by display properties.
57f97249 3649
fec2107c
EZ
3650 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3651 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3652 (bidi_cache_search, bidi_cache_iterator_state)
3653 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3654 (bidi_level_of_next_char, bidi_move_to_visually_next):
3655 Support character positions inside a run of characters covered by a
fec2107c
EZ
3656 display string.
3657 (bidi_paragraph_init, bidi_resolve_explicit_1)
3658 (bidi_level_of_next_char): Call bidi_fetch_char and
3659 bidi_fetch_char_advance instead of FETCH_CHAR and
3660 FETCH_CHAR_ADVANCE.
3661 (bidi_init_it): Initialize new members.
3662 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3663 definitions.
3664 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3665 instead of using explicit *_CHAR codes.
d6d100dd
SM
3666 (bidi_resolve_explicit, bidi_resolve_weak):
3667 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3668 bidirectional text is supported only in multibyte buffers.
3669 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3670 it to initialize the frame_window_p member of struct bidi_it.
3671 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3672 (bidi_resolve_explicit, bidi_resolve_weak)
3673 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3674 bidi_it->nchars is non-positive.
3675 (bidi_level_of_next_char): Don't try to lookup the cache for the
3676 next/previous character if nothing is cached there yet, or if we
3677 were just reseat()'ed to a new position.
c40e2fb2 3678
0e14fe90
EZ
3679 * xdisp.c (set_cursor_from_row): Set start and stop points
3680 according to the row's direction when priming the loop that looks
3681 for the glyph on which to display cursor.
3682 (single_display_spec_intangible_p): Function deleted.
3683 (display_prop_intangible_p): Reimplement to call
3684 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3685 Accept 3 additional arguments needed by handle_display_spec.
3686 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3687 values: lists, `(when COND...)' forms, etc.
3688 (single_display_spec_string_p): Support property values that are
3689 lists with the argument STRING its top-level element.
3690 (display_prop_string_p): Fix the condition for processing a
3691 property that is a list to be consistent with handle_display_spec.
fec2107c 3692 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3693 last portion of handle_display_prop.
3694 (compute_display_string_pos): Accept additional argument
3695 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3696 value of a `display' property is a "replacing spec".
3697 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3698 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3699 the display property, but just return a value indicating whether
3700 the display property will replace the characters it covers.
3701 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3702 frame_window_p members of struct bidi_it.
d6d100dd
SM
3703 (compute_display_string_pos, compute_display_string_end):
3704 New functions.
fec2107c
EZ
3705 (push_it): Accept second argument POSITION, where pop_it should
3706 jump to continue iteration.
3707 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3708
fec2107c
EZ
3709 * keyboard.c (adjust_point_for_property): Adjust the call to
3710 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3711
3712 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3713 (bidi_init_it): Update prototypes.
3714 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3715 (compute_display_string_pos, compute_display_string_end):
3716 Declare prototypes.
fec2107c
EZ
3717 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3718 EMACS_INT.
fc6f18ce 3719
40087514 37202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3721
57f53182
PE
3722 Malloc failure behavior now depends on size of allocation.
3723 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3724 * lisp.h: Change signatures accordingly.
3725 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3726 All callers changed. (Bug#8762)
3727
3728 * gnutls.c: Use Emacs's memory allocators.
3729 Without this change, the gnutls library would invoke malloc etc.
3730 directly, which causes problems on non-SYNC_INPUT hosts, and which
3731 runs afoul of improving memory_full behavior. (Bug#8761)
3732 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3733 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3734 xfree instead of the default malloc, realloc, free.
3735 (Fgnutls_boot): No need to check for memory allocation failure,
3736 since xmalloc does that for us.
3737
ac32cd99 3738 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3739 * category.c (hash_get_category_set):
3740 * ccl.c (ccl_driver):
3741 * charset.c (Fdefine_charset_internal):
3742 * charset.h (struct charset.hash_index):
3743 * composite.c (get_composition_id, gstring_lookup_cache)
3744 (composition_gstring_put_cache):
3745 * composite.h (struct composition.hash_index):
3746 * dispextern.h (struct image.hash):
3747 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3748 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3749 (hashfn_equal, hashfn_user_defined, make_hash_table)
3750 (maybe_resize_hash_table, hash_lookup, hash_put)
3751 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3752 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3753 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3754 * image.c (make_image, search_image_cache, lookup_image)
3755 (xpm_put_color_table_h):
3756 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3757 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3758 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3759 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3760 * alloc.c (allocate_vectorlike):
3761 Check for overflow in vector size calculations.
3762 * ccl.c (ccl_driver):
3763 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3764 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3765 need to be updated by these changes.
40087514
PE
3766 * fns.c (make_hash_table, maybe_resize_hash_table):
3767 Check for integer overflow with large hash tables.
0de4bb68
PE
3768 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3769 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3770 (SXHASH_REDUCE): New macro.
3771 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3772 Use it instead of discarding useful hash info with large hash values.
3773 (sxhash_float): New function.
3774 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3775 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3776 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3777 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3778 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3779 Adjust signatures to match updated version of code.
3780 (consing_since_gc): Now EMACS_INT, since a single hash table can
3781 use more than INT_MAX bytes.
3782
698d32e2
DN
37832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3784
3785 Make it possible to build with GCC-4.6+ -O2 -flto.
3786
3787 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3788
fd6fa53f
SM
37892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3790
3791 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3792 Call minibuffer-inactive-mode.
3793
864db017
JB
37942011-05-31 Juanma Barranquero <lekktu@gmail.com>
3795
3796 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3797 Update dependencies.
3798
2ad0baf4
DN
37992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3800
3801 * data.c (init_data): Remove code for UTS, this system is not
3802 supported anymore.
3803
4fcc2638
DN
38042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3805
3806 Don't force ./temacs to start in terminal mode.
3807
3808 * frame.c (make_initial_frame): Initialize faces in all cases, not
3809 only when CANNOT_DUMP is defined.
3810 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3811
c56e0fd5
DN
38122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3813
3814 * dispnew.c (add_window_display_history): Use const for the string
3815 pointer. Remove declaration, not needed.
3816
333d54da 38172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3818
55d4c1b2 3819 Use 'inline', not 'INLINE'.
333d54da 3820 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3821 * alloc.c, fontset.c (INLINE): Remove.
3822 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3823 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3824 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3825 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3826 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3827
738db178
DN
38282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3829
3830 Make it possible to run ./temacs.
3831
3832 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3833 syms_of_callproc does the same thing. Remove test for
3834 "initialized", do it in the caller.
3835 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3836
620c53a6
SM
38372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3838
3839 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3840 (read_minibuf): Use get_minibuffer.
3841 (syms_of_minibuf): Use DEFSYM.
3842 (Qmetadata): New var.
3843 * data.c (Qbuffer): Don't make it static.
3844 (syms_of_data): Use DEFSYM.
3845
e003a292
PE
38462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3847
3848 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3849 (CCL_CODE_MIN): New macro.
3850
ed008a6d
PE
38512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3852
3687c2ef
PE
3853 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3854
ed008a6d
PE
3855 * eval.c (Qdebug): Now static.
3856 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3857 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3858 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3859
d66c4c7c
CY
38602011-05-29 Chong Yidong <cyd@stupidchicken.com>
3861
3862 * image.c: Various fixes to ImageMagick code comments.
3863 (Fimagemagick_types): Doc fix.
3864
5fbc2025
PE
38652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3866
0196f88a
PE
3867 Minor fixes prompted by GCC 4.6.0 warnings.
3868
3869 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3870
5fbc2025
PE
3871 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3872 (x_clipboard_manager_save_all): Move extern decl to ...
3873 * xterm.h: ... here, so that it can be checked for consistency.
3874
1dd3c2d9
CY
38752011-05-29 Chong Yidong <cyd@stupidchicken.com>
3876
3877 * xselect.c (x_clipboard_manager_save_frame)
3878 (x_clipboard_manager_save_all): New functions.
3879 (Fx_clipboard_manager_save): Lisp function deleted.
3880
3881 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3882 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3883
3884 * xterm.h: Update prototype.
3885
5ba6571d
WX
38862011-05-28 William Xu <william.xwl@gmail.com>
3887
3888 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3889 exiting (Bug#8239).
3890
3eaff834
JM
38912011-05-28 Jim Meyering <meyering@redhat.com>
3892
e1900994 3893 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3894 * fns.c (to_uchar): Define.
3895 (crypto_hash_function): Use it to convert some newly-signed
3896 variables to unsigned, to avoid sign-extension bugs. For example,
3897 without this change, (md5 "truc") would evaluate to
3898 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3899 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3900 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3901
0f6990a7
PE
39022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3903
3904 Integer overflow fixes.
c8a9ca5a 3905
08686060
PE
3906 * dbusbind.c: Serial number integer overflow fixes.
3907 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3908 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3909 to hold a serial number that is too large for a fixnum.
3910 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3911 Check for serial numbers out of range. Decode any serial number
59568bf0 3912 that was so large that it became a float. (Bug#8722)
08686060 3913
2d1fc3c7
PE
3914 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3915 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3916 Use XFASTINT rather than XUINT when numbers are nonnegative.
3917 (xd_append_arg, Fdbus_method_return_internal):
3918 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3919 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3920 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3921 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3922 (Bug#8722)
2d1fc3c7 3923
c8a9ca5a
PE
3924 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3925
519e1d69
PE
3926 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3927
30569699
PE
3928 ccl: add integer overflow checks
3929 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3930 (IN_INT_RANGE): New macros.
3931 (ccl_driver): Use them to check for integer overflow when
3932 decoding a CCL program. Many of the new checks are whether XINT (x)
3933 fits in int; it doesn't always, on 64-bit hosts. The new version
3934 doesn't catch all possible integer overflows, but it's an
847044ea 3935 improvement. (Bug#8719)
30569699 3936
c11285dc
PE
3937 * alloc.c (make_event_array): Use XINT, not XUINT.
3938 There's no need for unsigned here.
3939
fdccd48e
PE
3940 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3941 This follows up to the 2011-05-06 change that substituted uintptr_t
3942 for EMACS_INT. This case wasn't caught back then.
3943
37910ab2
PE
3944 Rework Fformat to avoid integer overflow issues.
3945 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3946 now (part of C89). Include <verify.h>.
3947 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3948 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3949 (Fformat): Avoid the prepass trying to compute sizes; it was only
3950 approximate and thus did not catch overflow reliably. Instead, walk
3951 through the format just once, formatting and computing sizes as we go,
3952 checking for integer overflow at every step, and allocating a larger
3953 buffer as needed. Keep track separately whether the format is
3954 multibyte. Keep only the most-recently calculated precision, rather
3955 than them all. Record whether each argument has been converted to
3956 string. Use EMACS_INT, not int, for byte and char and arg counts.
3957 Support field widths and precisions larger than INT_MAX. Avoid
3958 sprintf's undefined behavior with conversion specifications such as %#d
3959 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3960 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3961 formatting out-of-range floating point numbers with int
9173deec 3962 formats. (Bug#8668)
37910ab2 3963
2e6578fb
PE
3964 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3965
0ae6bdee
PE
3966 * data.c: Avoid integer truncation in expressions involving floats.
3967 * data.c: Include <intprops.h>.
3968 (arith_driver): When there's an integer overflow in an expression
3969 involving floating point, convert the integers to floating point
3970 so that the resulting value does not suffer from catastrophic
3971 integer truncation. For example, on a 64-bit host (* 4
3972 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3973 Do not rely on undefined behavior after integer overflow.
3974
de883a70
PE
3975 merge count_size_as_multibyte, parse_str_to_multibyte
3976 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3977 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3978 Check for integer overflow.
3979 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3980 since it's now a duplicate of the other. This is more of
3981 a character than a buffer op, so better that it's in character.c.
3982 * fns.c, print.c: Adjust to above changes.
3983
2ff916cb
PE
39842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3985
3986 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3987
f1b54466
PE
39882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3989
fb1ac845
PE
3990 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3991 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3992 (x_clipboard_manager_save): Now static.
3993 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3994
f1b54466
PE
3995 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3996 (crypto_hash_function): Now static.
3997 Fix pointer signedness problems. Avoid unnecessary initializations.
3998
a9f737ee
CY
39992011-05-27 Chong Yidong <cyd@stupidchicken.com>
4000
4001 * termhooks.h (Vselection_alist): Make it terminal-local.
4002
4003 * terminal.c (create_terminal): Initialize it.
4004
4005 * xselect.c: Support for clipboard managers.
4006 (Vselection_alist): Move to termhooks.h as terminal-local var.
4007 (LOCAL_SELECTION): New macro.
4008 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4009 (symbol_to_x_atom): Remove gratuitous arg.
4010 (x_handle_selection_request, lisp_data_to_selection_data)
4011 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4012 (x_own_selection, x_get_local_selection, x_convert_selection):
4013 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4014 (some_frame_on_display): Delete unused function.
4015 (Fx_own_selection_internal, Fx_get_selection_internal)
4016 (Fx_disown_selection_internal, Fx_selection_owner_p)
4017 (Fx_selection_exists_p): New optional frame arg.
4018 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4019 (x_handle_selection_clear): Don't treat other terminals with the
4020 same keyboard specially. Use the terminal-local Vselection_alist.
4021 (x_clear_frame_selections): Use Frun_hook_with_args.
4022
4023 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4024
4025 * xterm.h: Add support for those atoms.
4026
e067f0c1
CY
40272011-05-26 Chong Yidong <cyd@stupidchicken.com>
4028
4029 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4030 (converted_selections, conversion_fail_tag): New global variables.
4031 (x_selection_request_lisp_error): Free the above.
4032 (x_get_local_selection): Remove unnecessary code.
4033 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4034 of converted selections stored in converted_selections.
4035 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4036 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4037 (x_convert_selection): New function.
4038 (x_handle_selection_event): Simplify.
4039 (x_get_foreign_selection): Don't ignore incoming requests while
4040 waiting for an answer; this will fail when we implement
4041 SAVE_TARGETS, and seems unnecessary anyway.
4042 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4043 (Vx_sent_selection_functions): Doc fix.
4044
0f4aebc0
LL
40452011-05-26 Leo Liu <sdl.web@gmail.com>
4046
4047 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4048
e61124cd
YM
40492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4050
4051 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4052
4053 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4054 for fringe update if it has periodic bitmap.
ac389d0c 4055 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4056 and fringe_bitmap_periodic_p.
4057
4058 * fringe.c (get_fringe_bitmap_data): New function.
4059 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4060 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4061 row. Mark glyph row for fringe update if periodicity changed.
4062
4063 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4064 for fringe update unless it has periodic bitmap.
4065
f16d9837
KH
40662011-05-25 Kenichi Handa <handa@m17n.org>
4067
4068 * xdisp.c (get_next_display_element): Set correct it->face_id for
4069 a static composition.
4070
e1b90ef6
LL
40712011-05-24 Leo Liu <sdl.web@gmail.com>
4072
4073 * deps.mk (fns.o):
4074 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4075
4076 * fns.c (crypto_hash_function, Fsha1): New function.
4077 (Fmd5): Use crypto_hash_function.
4078 (syms_of_fns): Add Ssha1.
4079
7400048f
PE
40802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 * gnutls.c: Remove unused macros.
4083 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4084 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4085 Remove macros that are defined and never used.
4086 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4087
abb71cf4
CY
40882011-05-22 Chong Yidong <cyd@stupidchicken.com>
4089
4090 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4091 (Fx_get_selection_internal): Minor cleanup.
4092 (Fx_own_selection_internal): Rename arguments for consistency with
4093 select.el.
4094
6307db39
PE
40952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4096
4097 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4098
f3d4e0a4
CY
40992011-05-22 Chong Yidong <cyd@stupidchicken.com>
4100
4101 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4102
4d8ade89
YM
41032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4104
4105 * dispnew.c (scrolling_window): Don't exclude the case that the
4106 last enabled row in the desired matrix touches the bottom boundary.
4107
32078c8d
GM
41082011-05-21 Glenn Morris <rgm@gnu.org>
4109
4110 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4111 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4112 and add some more files.
32078c8d 4113
7285dc67
EZ
41142011-05-20 Eli Zaretskii <eliz@gnu.org>
4115
4116 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4117 report_file_error introduced by the change from 2011-05-07.
4118
89d1bd22
PE
41192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4120
4121 * systime.h (Time): Define only if emacs is defined.
4122 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4123 where the include path doesn't have X11/X.h by default. See
4124 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4125
e23640bb 41262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4127
4128 * composite.c (find_automatic_composition): Fix previous change.
4129
b9704ad9
GM
41302011-05-20 Glenn Morris <rgm@gnu.org>
4131
4132 * lisp.mk: New file, split from Makefile.in.
4133 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4134 (shortlisp): Remove.
4135 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4136
4a720484
GM
41372011-05-19 Glenn Morris <rgm@gnu.org>
4138
4139 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4140 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4141 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4142 (lisp): Set the order to that of loadup.el.
4143 (shortlisp): Make it a copy of $lisp.
4144 (SOME_MACHINE_LISP): Remove.
4145 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4146 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4147
a28d4396
KH
41482011-05-18 Kenichi Handa <handa@m17n.org>
4149
4150 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4151 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4152 (find_automatic_composition): Mostly rewrite for efficiency.
4153
a2b1fa8e
JB
41542011-05-18 Juanma Barranquero <lekktu@gmail.com>
4155
4156 * makefile.w32-in: Update dependencies.
4157
8e1f5610
CS
41582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4159
4160 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4161 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4162
7025ee00 41632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4164
cdfa6eab
PE
4165 Fix some integer overflow issues, such as string length overflow.
4166
06d6db33
PE
4167 * insdel.c (count_size_as_multibyte): Check for string overflow.
4168
2b4560a8
PE
4169 * character.c (lisp_string_width): Check for string overflow.
4170 Use EMACS_INT, not int, for string indexes and lengths; in
4171 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4172 the resulting string length overflows an EMACS_INT; instead,
4173 report a string overflow if no precision given. When checking for
4174 precision exhaustion, use a check that cannot possibly have
4175 integer overflow. (Bug#8675)
4176 * character.h (lisp_string_width): Adjust to new signature.
4177
cb93f9be
PE
4178 * alloc.c (string_overflow): New function.
4179 (Fmake_string): Use it. This doesn't change behavior, but saves
4180 a few bytes and will simplify future changes.
4181 * character.c (string_escape_byte8): Likewise.
4182 * lisp.h (string_overflow): New decl.
4183
1a1f3366
PE
4184 Fixups, following up to the user-interface timestamp change.
4185 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4186 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4187 * msdos.c (mouse_get_pos): Likewise.
4188 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4189 * w32gui.h (Time): Define by including "systime.h" rather than by
4190 declaring it ourselves. (Bug#8664)
4191
d4e3e4d3
PE
4192 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4193 * image.c (clear_image_cache): Likewise.
4194
f6a24d19
PE
4195 * term.c (term_mouse_position): Don't assume time_t wraparound.
4196
08dc5ae6
PE
4197 Be more systematic about user-interface timestamps.
4198 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4199 and sometimes 'EMACS_UINT', to represent these timestamps.
4200 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4201 This makes the code easier to follow, and makes it easier to catch
4202 integer overflow bugs such as Bug#8664.
4203 * frame.c (Fmouse_position, Fmouse_pixel_position):
4204 Use Time, not unsigned long, for user-interface timestamps.
4205 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4206 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4207 * keyboard.h (last_event_timestamp): Likewise.
4208 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4209 * menu.h (xmenu_show): Likewise.
4210 * term.c (term_mouse_position): Likewise.
4211 * termhooks.h (struct input_event.timestamp): Likewise.
4212 (struct terminal.mouse_position_hook): Likewise.
4213 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4214 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4215 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4216 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4217 what it was before.
4218 * menu.h, termhooks.h: Include "systime.h", for Time.
4219
8e55734a
PE
4220 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4221 Don't assume that the difference between two unsigned long values
4222 can fit into an integer. At this point, we know button_down_time
4223 <= event->timestamp, so the difference must be nonnegative, so
4224 there's no need to cast the result if double-click-time is
4225 nonnegative, as it should be; check that it's nonnegative, just in
4226 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4227 apart (about 25 days). (Bug#8664)
8e55734a 4228
841f1b75 4229 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4230 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4231
3e26f69c
PE
4232 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4233 that always fit in int. Use a sentinel instead of a counter, to
4234 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4235 * frame.h (struct frame): Use int for menu_bar_items_used
4236 instead of EMACS_INT, since it always fits in int.
3e26f69c 4237
5cc152c0
PE
4238 * menu.c (grow_menu_items): Check for int overflow.
4239
d89eb65e
PE
4240 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4241
5235bd3e
PE
4242 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4243 Before, the code was not consistent. These values cannot exceed
4244 2**31 - 1 so there's no need to make them unsigned.
4245 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4246 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4247 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4248 as modifiers.
4249 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4250
bc827e23
PE
4251 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4252 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4253 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4254 presumably because the widths might not match.
4255
78eb494e
PE
4256 * window.c (size_window): Avoid needless test at loop start.
4257
04f2d78b
CB
42582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4259
4260 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4261
d2fc7e3d 42622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4263
4264 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4265
d2fc7e3d 42662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4267
4268 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4269 `width' to `bar_area_x' and `bar_area_width', respectively.
4270 (x_scroll_run): Take account of fringe background extension.
4271
04f2d78b
CB
4272 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4273 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4274 `bar_area_width', respectively.
4275 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4276 background extension.
4277
79b70037
GM
42782011-05-10 Jim Meyering <meyering@redhat.com>
4279
4280 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4281
2f142cc5
JB
42822011-05-10 Juanma Barranquero <lekktu@gmail.com>
4283
4284 * image.c (Finit_image_library): Return t for built-in image types,
4285 like pbm and xbm. (Bug#8640)
4286
57679c86
AS
42872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4288
4289 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4290
888c9e86
EZ
42912011-05-07 Eli Zaretskii <eliz@gnu.org>
4292
b0512a1d
EZ
4293 * w32console.c (Fset_screen_color): Doc fix.
4294 (Fget_screen_color): New function.
4295 (syms_of_ntterm): Defsubr it.
4296
7285dc67
EZ
4297 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4298 unlink the temporary file if Fcall_process didn't create it in the
4299 first place.
4300 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4301 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4302 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4303 cue to call_process_cleanup not to close that handle.
4304
4d3fcc8e
BK
43052011-05-07 Ben Key <bkey76@gmail.com>
4306
4307 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4308 one of two shell specific rules, either bootstrap-temacs-CMD or
4309 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4310 to the previous implementation of the bootstrap-temacs rule.
4311 The bootstrap-temacs-CMD rule is similar to the previous
4312 implementation of the bootstrap-temacs rule except that it
4313 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4314 variable.
4315
4316 These changes, along with some changes to nt/configure.bat,
4317 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4318 earlier fix to add support for --cflags and --ldflags options
4319 that include quotes so that it works whether make uses cmd or
4320 sh as the shell.
4321
b4289b64
MA
43222011-05-06 Michael Albinus <michael.albinus@gmx.de>
4323
4324 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4325 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4326 is a constant.
4327 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4328 a string. Handle both cases.
4329 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4330 (Fdbus_register_method): Use Qinvalid_function.
4331
af4c0e28
JB
43322011-05-06 Juanma Barranquero <lekktu@gmail.com>
4333
4334 * makefile.w32-in: Update dependencies.
4335 (LISP_H): Add inttypes.h and stdin.h.
4336 (PROCESS_H): Add unistd.h.
4337
c51453d9
EZ
43382011-05-06 Eli Zaretskii <eliz@gnu.org>
4339
4340 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4341 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4342
8ff0ac3c 43432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4344
4c4b566b
PE
4345 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4346
aab2b9b5
PE
4347 * term.c (vfatal): Remove stray call to va_end.
4348 It's not needed and the C Standard doesn't allow it here anyway.
4349
c378da0b
PE
4350 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4351 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4352
288b08c7
PE
4353 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4354 bytes.
4355
e3601888
PE
4356 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4357
db6c0e74
PE
4358 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4359
dd5963ea
PE
4360 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4361
88c9450f
PE
4362 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4363
2f9442b8
PE
4364 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4365
c032b5f8
PE
4366 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4367 * charset.c (Fdefine_charset_internal): Don't initialize
4368 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4369 32-bit int (Bug#8600).
a108c10b
PE
4370
4371 * lread.c (read_integer): Be more consistent with string-to-number.
4372 Use string_to_number to do the actual conversion; this avoids
4373 rounding errors and fixes some other screwups. Without this fix,
4374 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4375 (digit_to_number): Move earlier, for benefit of read_integer.
4376 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4377 not a digit in any supported base. (Bug#8602)
a108c10b 4378
ad5f9eea
PE
4379 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4380
aec1708a
PE
4381 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4382 to match comment at start of function. This also removes a
4383 GCC warning about overflow in a 32+64-bit port.
4384
47be4ab5
PE
4385 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4386
371cac43
PE
4387 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4388 Reported by Stefan Monnier in
4389 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4390 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4391 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4392
d01a7826
PE
4393 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4394 (EMACS_UINTPTR): Likewise, with uintptr_t.
4395
7fd47d5c
PE
4396 * lisp.h: Prefer 64-bit EMACS_INT if available.
4397 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4398 on 32-bit hosts that have 64-bit int, so that they can access
4399 large files.
122b0c86
PE
4400 However, temporarily disable this change unless the temporary
4401 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4402
8727937b
PE
4403 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4404
8ac068ac
PE
4405 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4406 This removes an assumption that EMACS_INT and long are the same
4407 width as pointers. The assumption is true for Emacs porting targets
4408 now, but we want to make other targets possible.
4409 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4410 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4411 In the rest of the code, change types of integers that hold casted
4412 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4413 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4414 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4415 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4416 No need to cast type when ORing.
4417 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4418 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4419 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4420 assume EMACS_INT is the same width as char *.
4421 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4422 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4423 Remove no-longer-needed casts.
4424 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4425 (xg_tool_bar_help_callback, xg_make_tool_item):
4426 Use EMACS_INTPTR to hold an integer
4427 that will be cast to void *; this can avoid a GCC warning
4428 if EMACS_INT is not the same width as void *.
4429 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4430 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4431 (current_message_1, set_message_1):
4432 Use a local to convert to proper width without a cast.
4433 * xmenu.c (dialog_selection_callback): Likewise.
4434
ede49d71
PE
4435 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4436 Also, don't assume VALBITS / RAND_BITS is less than 5,
4437 and don't rely on undefined behavior when shifting a 1 left into
4438 the sign bit.
4439 * lisp.h (get_random): Change signature to match.
4440
2f30ecd0
PE
4441 * lread.c (hash_string): Use size_t, not int, for hash computation.
4442 Normally we prefer signed values; but hashing is special, because
4443 it's better to use unsigned division on hash table sizes so that
4444 the remainder is nonnegative. Also, size_t is the natural width
4445 for hashing into memory. The previous code used 'int', which doesn't
4446 retain enough info to hash well into very large tables.
4447 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4448
2a866e7b
PE
4449 * dbusbind.c: Don't possibly lose pointer info when converting.
4450 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4451 Use XPNTR rather than XHASH, so that the high-order bits of
4452 the pointer aren't lost when converting through void *.
4453
51639eac
PE
4454 * eval.c (Fautoload): Don't double-shift a pointer.
4455
92394119
PE
4456 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4457
dbdb9a7c
JB
44582011-05-06 Juanma Barranquero <lekktu@gmail.com>
4459
4460 * gnutls.c (DEF_GNUTLS_FN):
4461 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4462
db7a0b4f
AS
44632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4464
4465 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4466 marker. (Bug#8610)
4467
f7ff1b0f 44682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4469
4470 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4471 New version that can reserve upto 2GB of heap space.
4472
f7ff1b0f 44732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4474
4475 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4476
639c109b
TZ
44772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4478
4479 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4480 `gnutls_certificate_set_x509_key_file'.
4481
d2127135
JB
44822011-05-05 Juanma Barranquero <lekktu@gmail.com>
4483
4484 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4485 Update dependencies.
4486
e968f4f3
JB
44872011-05-04 Juanma Barranquero <lekktu@gmail.com>
4488
4489 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4490 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4491 Remove unused parameter `fildes'.
4492 * process.c (read_process_output, send_process): Don't pass it.
4493
84d358f0
JB
44942011-05-04 Juanma Barranquero <lekktu@gmail.com>
4495
4496 Fix previous change: the library cache is defined in w32.c.
4497 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4498 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4499
0898ca10
JB
45002011-05-04 Juanma Barranquero <lekktu@gmail.com>
4501
4502 Implement dynamic loading of GnuTLS on Windows.
4503
4504 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4505 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4506 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4507 Declare.
4508
4509 * gnutls.c (Qgnutls_dll): Define.
4510 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4511 (gnutls_*): Declare function pointers.
4512 (init_gnutls_functions): New function to initialize function pointers.
4513 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4514 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4515 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4516 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4517 (emacs_gnutls_write, emacs_gnutls_read)
4518 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4519 (Fgnutls_available_p): New function.
4520 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4521 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4522 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4523
4524 * image.c: Include w32.h.
4525 (Vimage_type_cache): Delete.
4526 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4527 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4528 (w32_delayed_load): Move to w32.c.
4529
4530 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4531
4532 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4533 (w32_delayed_load): Move from image.c. When loading a library, record
4534 its filename in the :loaded-from property of the library id.
4535 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4536 Initialize and staticpro them.
4537 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4538
4539 * process.c: Include lisp.h before w32.h, not after.
4540 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4541 instead of gnutls_record_check_pending.
4542
4543 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4544
ff4de4aa
TZ
45452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4546
4547 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4548 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4549 as passed in.
4550
abe95abb
JD
45512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4552
4553 * xterm.c (x_set_frame_alpha): Do not set property on anything
4554 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4555
e16e55d4
JB
45562011-05-02 Juanma Barranquero <lekktu@gmail.com>
4557
4558 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4559
bafcf6a5
JB
45602011-05-02 Juanma Barranquero <lekktu@gmail.com>
4561
4562 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4563 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4564 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4565 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4566 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4567 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4568 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4569 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4570 (Qgnutls_bootprop_callbacks_verify): Make static.
4571
e7a6747f
AS
45722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4573
19ed11ba
AS
4574 * callproc.c: Indentation fixup.
4575
e7a6747f 4576 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4577 (wait_for_termination, interruptible_wait_for_termination):
4578 Move after wait_for_termination_1.
e7a6747f 4579
1ef14cb4
LMI
45802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4581
4582 * sysdep.c (interruptible_wait_for_termination): New function
4583 which is like wait_for_termination, but allows keyboard
4584 interruptions.
4585
4586 * callproc.c (Fcall_process): Add (:file "file") as an option for
4587 the STDOUT buffer.
4588 (Fcall_process_region): Ditto.
4589
330d880c
EZ
45902011-04-30 Eli Zaretskii <eliz@gnu.org>
4591
8db90b73
EZ
4592 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4593 rather than `XVECTOR (FOO)->size'.
4594
330d880c
EZ
4595 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4596 inttypes.h, as a gnulib replacement is used if it not available in
4597 system headers.
4598
15cbd324
EZ
45992011-04-21 Eli Zaretskii <eliz@gnu.org>
4600
4601 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4602 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4603 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4604
4605 * coding.c (coding_alloc_by_realloc): Error out if destination
4606 will grow beyond MOST_POSITIVE_FIXNUM.
4607 (decode_coding_emacs_mule): Abort if there isn't enough place in
4608 charbuf for the composition carryover bytes. Reserve an extra
4609 space for up to 2 characters produced in a loop.
4610 (decode_coding_iso_2022): Abort if there isn't enough place in
4611 charbuf for the composition carryover bytes.
4612
46132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4614
ae940cca
EZ
4615 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4616 aborting when %lld or %lll format is passed.
4617 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4618 %llo or %llx format is passed. (Bug#8545)
4619
03ab8921
EZ
4620 * window.c (window_scroll_line_based): Use a marker instead of
4621 simple variables to record original value of point. (Bug#7952)
4622
afda1437
EZ
4623 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4624 produced by %s or %c overflows available buffer space. (Bug#8545)
4625
f76dee0c
PE
46262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4627
4628 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4629 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4630
fdc5744d
JB
46312011-04-28 Juanma Barranquero <lekktu@gmail.com>
4632
4633 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4634
638f053a
JB
46352011-04-28 Juanma Barranquero <lekktu@gmail.com>
4636
4637 * keyboard.c (Qdelayed_warnings_hook): Define.
4638 (command_loop_1): Run `delayed-warnings-hook'
4639 if Vdelayed_warnings_list is non-nil.
4640 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4641 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4642
d178f871
EZ
46432011-04-28 Eli Zaretskii <eliz@gnu.org>
4644
4645 * doprnt.c (doprnt): Don't return value smaller than the buffer
4646 size if the message was truncated. (Bug#8545).
4647
b124fd93
JB
46482011-04-28 Juanma Barranquero <lekktu@gmail.com>
4649
4650 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4651 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4652
e810457d
PE
46532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4656
ea51cceb
JB
46572011-04-27 Juanma Barranquero <lekktu@gmail.com>
4658
4659 * makefile.w32-in: Update dependencies.
4660
94dcfacf
EZ
46612011-04-27 Eli Zaretskii <eliz@gnu.org>
4662
4663 Improve `doprnt' and its usage. (Bug#8545)
4664 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4665 `format_end'. Remove support for %l as a conversion specifier.
4666 Don't use xrealloc. Improve diagnostics when the %l size modifier
4667 is used. Update the commentary.
4668
4669 * eval.c (verror): Simplify calculation of size_t.
4670
4671 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4672 messages.
4673
f61f41d7
PE
46742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4675
4676 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4677 change.
4678
96fb4434
PE
46792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4680
4681 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4682 This makes this file independent of the recent pseudovector change.
4683
671875da 46842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4685
69e9b5a3
PE
4686 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4687
b5f869a7 4688 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4689 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4690 Remove unused local.
c8926152 4691 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4692
841a1577 4693 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4694 GCC 4.6.0 optimizes based on type-based alias analysis.
4695 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4696 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4697 != &v->size, and therefore "v->size = 1; b->size = 2; return
4698 v->size;" must therefore return 1. This assumption is incorrect
4699 for Emacs, since it type-puns struct Lisp_Vector * with many other
4700 types. To fix this problem, this patch adds a new type struct
f904488f 4701 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4702 and pseudovectors, and helps optimizing compilers not get fooled
4703 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4704 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4705 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4706 the size member.
eab3844f
PE
4707 (XSETPVECTYPE): Rewrite in terms of new macro.
4708 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4709 This is a bit clearer, and further avoids the possibility of
4710 undesirable aliasing.
4711 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4712 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4713 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4714 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4715 (ASIZE): Now uses header.size rather than size.
4716 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4717 to avoid the hassle of writing XVECTOR (foo)->header.size.
4718 (struct vectorlike_header): New type.
eab3844f
PE
4719 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4720 object, to help avoid aliasing.
4721 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4722 (SUBRP): Likewise, since Lisp_Subr is a special case.
4723 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4724 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4725 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4726 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4727 changed to be "header.size" and "header.next".
4728 * buffer.h (struct buffer): Likewise.
4729 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4730 * frame.h (struct frame): Likewise.
4731 * process.h (struct Lisp_Process): Likewise.
4732 * termhooks.h (struct terminal): Likewise.
4733 * window.c (struct save_window_data, struct saved_window): Likewise.
4734 * window.h (struct window): Likewise.
4735 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4736 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4737 * buffer.c (init_buffer_once): Likewise.
4738 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4739 special case.
4740 * process.c (Fformat_network_address): Use local var for size,
4741 for brevity.
4742
0df1eac5
PE
4743 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4744
847ab9d1 4745 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4746 * data.c (atof): Remove decl; no longer used or needed.
4747 (digit_to_number): Move to lread.c.
4748 (Fstring_to_number): Use new string_to_number function, to be
4749 consistent with how the Lisp reader treats infinities and NaNs.
4750 Do not assume that floating-point numbers represent EMACS_INT
4751 without losing information; this is not true on most 64-bit hosts.
4752 Avoid double-rounding errors, by insisting on integers when
4753 parsing non-base-10 numbers, as the documentation specifies.
4754 * lisp.h (string_to_number): New decl, replacing ...
4755 (isfloat_string): Remove.
bc0a5c13 4756 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4757 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4758 appears to have been a coding error. Similarly, do not accept
4759 strings like +-1e0 as floating point numbers. Do not report
4760 overflow for integer overflows unless the base is not 10 which
4761 means we have no simple and reliable way to continue.
4762 Break out the floating-point parsing into a new
4763 function string_to_number, so that Fstring_to_number parses
4764 floating point numbers consistently with the Lisp reader.
04f2d78b 4765 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4766 (E_CHAR, EXP_INT): Remove, replacing with ...
4767 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4768 (string_to_number): New function, replacing isfloat_string.
4769 This function checks for valid syntax and produces the resulting
4770 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4771 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4772 so that overflow for non-base-10 numbers is reported only when
4773 there's no portable and simple way to convert to floating point.
452f4150 4774
67769ffc
PE
4775 * textprop.c (set_text_properties_1): Rewrite for clarity,
4776 and to avoid GCC warning about integer overflow.
4777
c20db43f
PE
4778 * intervals.h (struct interval): Use EMACS_INT for members
4779 where EMACS_UINT might cause problems. See
4780 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4781 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4782 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4783 All uses changed.
37aa2f85
PE
4784 (offset_intervals): Tell GCC not to worry about length overflow
4785 when negating a negative length.
c20db43f 4786
2538aa2f
PE
4787 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4788 (overrun_check_free): Likewise.
4789
f2d3008d
PE
4790 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4791 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4792 word size.
4793
ec8df744
PE
4794 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4795 (gnutls_make_error): Rename local to avoid shadowing.
4796 (gnutls_emacs_global_deinit): ifdef out; not used.
4797 (Fgnutls_boot): Use const for pointer to readonly storage.
4798 Comment out unused local. Fix pointer signedness problems.
4799
640ee02d
PE
4800 * lread.c (openp): Don't stuff size_t into an 'int'.
4801 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4802 about possible signed overflow.
4803
6048fb2a
PE
4804 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4805 (GDK_KEY_g): Don't define if already defined.
4806 (xg_prepare_tooltip): Avoid pointer signedness problem.
4807 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4808
fa3c87e1
PE
4809 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4810 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4811
2172544b
PE
4812 * xfns.c (Fx_window_property): Simplify a bit,
4813 to make a bit faster and to avoid GCC 4.6.0 warning.
4814 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4815
9b821a21
PE
4816 * fns.c (internal_equal): Don't assume size_t fits in int.
4817
3c616cfa
PE
4818 * alloc.c (compact_small_strings): Tighten assertion a little.
4819
c2982e87
PE
4820 Replace pEd with more-general pI, and fix some printf arg casts.
4821 * lisp.h (pI): New macro, generalizing old pEd macro to other
4822 conversion specifiers. For example, use "...%"pI"d..." rather
4823 than "...%"pEd"...".
4824 (pEd): Remove. All uses replaced with similar uses of pI.
4825 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4826 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4827 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4828 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4829 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4830 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4831 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4832 64-bit hosts.
4833 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4834 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4835 * print.c (safe_debug_print, print_object): Likewise.
4836 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4837 to int.
6f04d126
PE
4838 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4839 avoiding the 0 flag, which is not portable.
c2982e87
PE
4840 * process.c (Fmake_network_process): Use pI to avoid cast.
4841 * region-cache.c (pp_cache): Likewise.
4842 * xdisp.c (decode_mode_spec): Likewise.
4843 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4844 behavior on 64-bit hosts with printf arg.
6f04d126 4845 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4846 (x_stop_queuing_selection_requests): Likewise.
4847 (x_get_window_property): Don't truncate byte count to an 'int'
4848 when tracing.
0b432f21 4849
5e073ec7
PE
4850 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4851 here, since it parses constructs like leading '-' and spaces,
4852 which are not wanted; and it overflows with large numbers.
4853 Instead, simply match F[0-9]+, which is what is wanted anyway.
4854
36372bf9
PE
4855 * alloc.c: Remove unportable assumptions about struct layout.
4856 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4857 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4858 (allocate_vectorlike, make_pure_vector): Use the new macros,
4859 plus offsetof, to remove unportable assumptions about struct layout.
4860 These assumptions hold on all porting targets that I know of, but
4861 they are not guaranteed, they're easy to remove, and removing them
4862 makes further changes easier.
4863
0b432f21
PE
4864 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4865 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4866 (string_overrun_cookie): Now const. Use initializers that
4867 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4868 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4869 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4870 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4871 multiple of sizeof (EMACS_INT); it need not be, if
4872 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4873 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4874
895009e1
JB
48752011-04-26 Juanma Barranquero <lekktu@gmail.com>
4876
4877 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4878
6a7a1b0b
TZ
48792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4880
4881 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4882 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4883 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4884
841a1577 48852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4886
4887 * lisp.h (Qdebug): List symbol.
895009e1 4888 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4889 * keyboard.c (debug-on-event): New variable.
4890 (handle_user_signal): Break into debugger when debug-on-event
4891 matches the current signal symbol.
4892
f2d3ba6f
DN
48932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4894
4895 * alloc.c (check_sblock, check_string_bytes)
4896 (check_string_free_list): Convert to standard C.
4897
42ce4c63
TZ
48982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4899
4900 * w32.c (emacs_gnutls_push): Fix typo.
4901
825cd63c
EZ
49022011-04-25 Eli Zaretskii <eliz@gnu.org>
4903
fb11d64d
EZ
4904 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4905 "cast to pointer from integer of different size".
4906
825cd63c
EZ
4907 Improve doprnt and its use in verror. (Bug#8545)
4908 * doprnt.c (doprnt): Document the set of format control sequences
4909 supported by the function. Use SAFE_ALLOCA instead of always
4910 using `alloca'.
4911
4912 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4913 is one byte too soon. Don't use xrealloc; instead xfree and
4914 xmalloc anew.
4915
e061a11b
TZ
49162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4917
4918 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4919 callbacks stage.
4920
4921 * gnutls.c: Renamed global_initialized to
4922 gnutls_global_initialized. Added internals for the
4923 :verify-hostname-error, :verify-error, and :verify-flags
4924 parameters of `gnutls-boot' and documented those parameters in the
4925 docstring. Start callback support.
9173deec
JB
4926 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4927 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4928 on error. Return error code.
e061a11b
TZ
4929 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4930 (emacs_gnutls_read): Likewise.
4931 (Fgnutls_boot): Return handshake error code.
4932 (emacs_gnutls_handle_error): New function.
4933 (wsaerror_to_errno): Likewise.
4934
4935 * w32.h (emacs_gnutls_pull): Add prototype.
4936 (emacs_gnutls_push): Likewise.
4937
4938 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4939 (emacs_gnutls_push): Likewise.
4940
49412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4942
4943 * process.c (wait_reading_process_output): Check if GnuTLS
4944 buffered some data internally if no FDs are set for TLS
4945 connections.
4946
4947 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4948 (LIBS): Link to USER_LIBS.
4949 ($(BLD)/gnutls.$(0)): New target.
4950
fa6996bc
EZ
49512011-04-24 Eli Zaretskii <eliz@gnu.org>
4952
eb35682e
EZ
4953 * xdisp.c (handle_single_display_spec): Rename the
4954 display_replaced_before_p argument into display_replaced_p, to
4955 make it consistent with the commentary. Fix typos in the
4956 commentary.
4957
e2ad650c
EZ
4958 * textprop.c (syms_of_textprop): Remove dead code.
4959 (copy_text_properties): Delete obsolete commentary about an
4960 interface that was deleted long ago. Fix typos in the description
4961 of arguments.
4962
1b2de274
EZ
4963 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4964 to changes in oldXMenu/XMenu.h from 2011-04-16.
4965 <menu_help_message, prev_menu_help_message>: Constify.
4966 (IT_menu_make_room): menu->help_text is now `const char **';
4967 adjust.
4968
4969 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4970 to changes in oldXMenu/XMenu.h from 2011-04-16.
4971 (struct XMenu): Declare `help_text' `const char **'.
4972
4973 * xfaces.c <Qunspecified>: Make extern again.
4974
4975 * syntax.c: Include sys/types.h before including regex.h, as
4976 required by Posix.
4977
762b15be
EZ
4978 * doc.c (get_doc_string): Improve the format passed to `error'.
4979
4980 * doprnt.c (doprnt): Improve commentary.
4981
4982 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4983
4984 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4985 them with etags.
4986
f1052e5d
EZ
4987 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4988 changes in globals.h immediately force recompilation.
762b15be
EZ
4989 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4990 $(CURDIR)/s/ms-w32.h.
4991 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4992
fa6996bc
EZ
4993 * character.c (Fchar_direction): Function deleted.
4994 (syms_of_character): Don't defsubr it.
4995 <char-direction-table>: Deleted.
4996
e6c3da20
EZ
49972011-04-23 Eli Zaretskii <eliz@gnu.org>
4998
4999 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5000 * doprnt.c: Include limits.h.
5001 (SIZE_MAX): New macro.
04f2d78b
CB
5002 (doprnt): Return a size_t value. 2nd arg is now size_t.
5003 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5004 Improve overflow protection. Support `l' modifier for integer
5005 conversions. Support %l conversion. Don't assume an EMACS_INT
5006 argument for integer conversions and for %c.
5007
5008 * lisp.h (doprnt): Restore prototype.
5009
5010 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5011 $(SRC)/character.h.
5012
5013 * Makefile.in (base_obj): Add back doprnt.o.
5014
5015 * deps.mk (doprnt.o): Add back prerequisites.
5016 (callint.o): Depend on character.h.
5017
5018 * eval.c (internal_lisp_condition_case): Include the handler
5019 representation in the error message.
5020 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5021 when breaking from the loop.
5022
5023 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5024
5025 * callint.c (Fcall_interactively): When displaying error message
5026 about invalid control letter, pass the character's codepoint, not
5027 a pointer to its multibyte form. Improve display of the character
5028 in octal and display also its hex code.
5029
5030 * character.c (char_string): Use %x to display the (unsigned)
5031 codepoint of an invalid character, to avoid displaying a bogus
5032 negative value.
5033
5034 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5035 `error', not SYMBOL_NAME itself.
5036
5037 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5038 character arguments to `error'.
5039
5040 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5041 to `error' in error message about FINAL_CHAR argument. Make sure
5042 FINAL_CHAR is a character, and use %c when it is passed as
5043 argument to `error'.
5044
4ffd0d6b 50452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5046
5047 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5048
5049 * w32.c: Include <time.h>.
5050 (sys_localtime): New function.
5051
4ffd0d6b 50522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5053
5054 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5055
4ffd0d6b 5056 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5057
4ffd0d6b 50582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5059
4ffd0d6b
GM
5060 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5061 zombies (Bug#8467).
aac0c6e3 5062
04c56954
EZ
50632011-04-19 Eli Zaretskii <eliz@gnu.org>
5064
5065 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5066 gl_state.e_property when gl_state.object is Qt.
5067
5068 * insdel.c (make_gap_larger): Remove limitation of buffer size
5069 to <= INT_MAX.
5070
16a43933
CY
50712011-04-18 Chong Yidong <cyd@stupidchicken.com>
5072
5073 * xdisp.c (lookup_glyphless_char_display)
5074 (produce_glyphless_glyph): Handle cons cell entry in
5075 glyphless-char-display.
5076 (Vglyphless_char_display): Document it.
5077
5078 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5079 glyphless-char-display.
5080
4581706e
CY
50812011-04-17 Chong Yidong <cyd@stupidchicken.com>
5082
5083 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5084
5085 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5086
5087 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5088 definition for no-X builds.
5089
4887c6e2 50902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5091
fd35b6f9
PE
5092 Static checks with GCC 4.6.0 and non-default toolkits.
5093
5c1ccb01
PE
5094 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5095
006c5daa
PE
5096 * process.c (keyboard_bit_set): Define only if SIGIO.
5097 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5098 (send_process): Repair possible setjmp clobbering.
5099
efc736d3
PE
5100 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5101
4e2fe2e6
PE
5102 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5103
f97334a2
PE
5104 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5105
4e75f29d
PE
5106 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5107 Define only if needed.
5108
90efadd1
PE
5109 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5110 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5111 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5112
3c647824
PE
5113 * dispextern.h (struct redisplay_interface): Rename param
5114 to avoid shadowing.
e264f262 5115 * termhooks.h (struct terminal): Likewise.
761383f4 5116 * xterm.c (xembed_send_message): Likewise.
3c647824 5117
b58c5c4a
PE
5118 * insdel.c (make_gap_smaller): Define only if
5119 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5120
cad59032
PE
5121 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5122 it.
5123
c339dc2e
PE
5124 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5125 so that we aren't warned about unused symbols.
5126
91a3e27b
PE
5127 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5128
399c71d3 5129 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5130
8ffc96f5
PE
5131 * xfns.c (x_real_positions): Mark locals as initialized.
5132
eef9bc79
PE
5133 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5134
098db9dd
PE
5135 * xterm.c: Fix problems found by static analysis with other toolkits.
5136 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5137 (x_dispatch_event): Declare static if USE_GTK, and
5138 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5139 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5140 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5141 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5142 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5143
eb18f6cc
PE
5144 * xmenu.c (menu_help_callback): Pointer type fixes.
5145 Use const pointers when pointing at readonly data. Avoid pointer
5146 signedness clashes.
5147 (FALSE): Remove unused macro.
5148 (update_frame_menubar): Remove unused decl.
5149
1fe72bf8
PE
5150 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5151
60d9e1db
PE
5152 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5153 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5154 (single_menu_item): Rename local to avoid shadowing.
5155
39261c26
PE
5156 * keyboard.c (make_lispy_event): Remove unused local var.
5157
018c5e19
PE
5158 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5159 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5160
63d2b86e
PE
5161 * bitmaps: Change bitmaps from unsigned char back to the X11
5162 compatible char. Avoid the old compiler warnings about
5163 out-of-range initializers by using, for example, '\xab' rather
5164 than 0xab.
5165
aefd87e1
PE
5166 * xgselect.c (xgselect_initialize): Check vs interface
5167 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5168
bf501fb9
PE
5169 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5170
e9829fdf
PE
5171 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5172 to read-only memory.
5173
1086c095
PE
5174 * fns.c (vector): Remove; this old hack is no longer needed.
5175
2baccd04 5176 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5177 Remove unused var.
dde42981 5178 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5179
72391843 5180 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5181
436c16df 5182 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5183 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5184 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5185
92bb796d 5186 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5187 (x_term_init): Remove local to avoid shadowing.
92bb796d 5188
764430a3 5189 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5190
5191 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5192 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5193
d1dfb56c
EZ
51942011-04-16 Eli Zaretskii <eliz@gnu.org>
5195
c4354cb4
EZ
5196 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5197
d1dfb56c
EZ
5198 Fix regex.c, syntax.c and friends for buffers > 2GB.
5199 * syntax.h (struct gl_state_s): Declare character position members
5200 EMACS_INT.
5201
5202 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5203
04f2d78b
CB
5204 * textprop.c (verify_interval_modification, interval_of):
5205 Declare arguments EMACS_INT.
d1dfb56c
EZ
5206
5207 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5208 EMACS_INT.
5209
5210 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5211
5212 * indent.c (Fvertical_motion): Local variable it_start is now
5213 EMACS_INT.
5214
5215 * regex.c (re_match, re_match_2, re_match_2_internal)
5216 (bcmp_translate, regcomp, regexec, print_double_string)
5217 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5218 (re_compile_pattern, re_exec): Declare arguments and local
5219 variables `size_t' and `ssize_t' and return values `regoff_t', as
5220 appropriate.
5221 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5222 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5223 <compile_stack_type>: `size' and `avail' are now `size_t'.
5224
5225 * regex.h <regoff_t>: Use ssize_t, not int.
5226 (re_search, re_search_2, re_match, re_match_2): Arguments that
5227 specify buffer/string position and length are now ssize_t and
5228 size_t. Return type is regoff_t.
5229
613052cd
BK
52302011-04-16 Ben Key <bkey76@gmail.com>
5231
5232 * nsfont.m: Fixed bugs in ns_get_family and
5233 ns_descriptor_to_entity that were caused by using free to
5234 deallocate memory blocks that were allocated by xmalloc (via
5235 xstrdup). This caused Emacs to crash when compiled with
5236 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5237 --enable-checking=xmallocoverrun). xfree is now used to
5238 deallocate these memory blocks.
5239
4170f62f 52402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5241
71b41406
PE
5242 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5243
9587a89d
PE
5244 emacs_write: Accept and return EMACS_INT for sizes.
5245 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5246 et seq.
5247 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5248 Accept and return EMACS_INT.
5249 (emacs_gnutls_write): Return the number of bytes written on
5250 partial writes.
5251 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5252 (emacs_read, emacs_write): Remove check for negative size, as the
5253 Emacs source code has been audited now.
9587a89d
PE
5254 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5255 (emacs_read, emacs_write): Use it.
273a5f82
PE
5256 * process.c (send_process): Adjust to the new signatures of
5257 emacs_write and emacs_gnutls_write. Do not attempt to store
5258 a byte offset into an 'int'; it might overflow.
9587a89d 5259 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5260
3e047f51
PE
5261 * sound.c: Don't assume sizes fit in 'int'.
5262 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5263 Return EMACS_INT, not int.
3e047f51 5264 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5265 Accept EMACS_INT, not int.
5266 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5267 record read return values.
5268
cc39a9db
BK
52692011-04-15 Ben Key <bkey76@gmail.com>
5270
c9d0ec6d
JB
5271 * keyboard.c (Qundefined): Don't declare static since it is used
5272 in nsfns.m.
5273 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5274 static since they are used in nsfont.m.
cc39a9db 5275
6c60eb9f
SM
52762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5277
5278 * process.c (Qprocessp): Don't declare static.
5279 * lisp.h (Qprocessp): Declare again.
5280
7990b61a
JB
52812011-04-15 Juanma Barranquero <lekktu@gmail.com>
5282
5283 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5284
5d4cb038
PE
52852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5286
8bd7b830 5287 Improve C-level modularity by making more things 'static'.
cd64ea1d 5288
e3b27b31
PE
5289 Don't publish debugger-only interfaces to other modules.
5290 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5291 (verify_bytepos, count_markers): Move decls to the only modules
5292 that need them.
5293 * region-cache.h (pp_cache): Likewise.
5294 * window.h (check_all_windows): Likewise.
5295 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5296
5d4cb038
PE
5297 * sysdep.c (croak): Now static, if
5298 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5299 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5300
5301 * alloc.c (refill_memory_reserve): Now static if
5302 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5303 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5304
e87b6180
PE
5305 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5306 Define only if USE_LUCID.
5307
ac64929e
PE
5308 * xrdb.c (x_customization_string, x_rm_string): Now static.
5309
6f37259d
PE
5310 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5311 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5312
1683e3ab
PE
5313 * xdisp.c (draw_row_with_mouse_face): Now static.
5314 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5315
de9c2632
PE
5316 * window.h (check_all_windows): Mark externally visible.
5317
2b96acb7
PE
5318 * window.c (window_deletion_count): Now static.
5319
5320 * undo.c: Make symbols static if they're not exported.
5321 (last_undo_buffer, last_boundary_position, pending_boundary):
5322 Now static.
5323
50436f33
PE
5324 * textprop.c (interval_insert_behind_hooks): Now static.
5325 (interval_insert_in_front_hooks): Likewise.
5326
64520e5c
PE
5327 * term.c: Make symbols static if they're not exported.
5328 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5329 (max_frame_lines, tty_set_terminal_modes):
5330 (tty_reset_terminal_modes, tty_turn_off_highlight):
5331 (get_tty_terminal): Now static.
5332 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5333 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5334 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5335 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5336 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5337
1fa53021
PE
5338 * sysdep.c: Make symbols static if they're not exported.
5339 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5340 Now static.
5341 (sigprocmask_set, full_mask): Remove; unused.
5342 (wait_debugging): Mark as visible.
5343 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5344 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5345
d4b43b22
PE
5346 * syntax.c (syntax_temp): Define only if !__GNUC__.
5347
b7c513d0
PE
5348 * sound.c (current_sound_device, current_sound): Now static.
5349
989b29ad
PE
5350 * search.c (searchbufs, searchbuf_head): Now static.
5351
13a55a78
PE
5352 * scroll.c (scroll_cost): Remove; unused.
5353 * dispextern.h (scroll_cost): Remove decl.
5354
de68a1fc
PE
5355 * region-cache.h (pp_cache): Mark as externally visible.
5356
40ccffa6
PE
5357 * process.c: Make symbols static if they're not exported.
5358 (process_tick, update_tick, create_process, chan_process):
5359 (Vprocess_alist, proc_buffered_char, datagram_access):
5360 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5361 (deactivate_process): Mark defn as static, as well as decl.
5362 * lisp.h (create_process): Remove decl.
5363 * process.h (chan_process, Vprocess_alist): Remove decls.
5364
ad64fc97
PE
5365 * print.c: Make symbols static if they're not exported.
5366 (print_depth, new_backquote_output, being_printed, print_buffer):
5367 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5368 (print_interval, print_number_index, initial_stderr_stream):
5369 Now static.
5370 * lisp.h (Fprinc): Remove decl.
5371 (debug_output_compilation_hack): Mark as externally visible.
5372
adddb265
PE
5373 * sysdep.c (croak): Move decl from here to syssignal.h.
5374 * syssignal.h (croak): Put it here, so the API can be checked when
5375 'croak' is called from dissociate_if_controlling_tty.
5376
1717ede2
PE
5377 * minibuf.c: Make symbols static if they're not exported.
5378 (minibuf_save_list, choose_minibuf_frame): Now static.
5379 * lisp.h (choose_minibuf_frame): Remove decl.
5380
fa5fb2bc
PE
5381 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5382
1e3890d1
PE
5383 * lread.c: Make symbols static if they're not exported.
5384 (read_objects, initial_obarray, oblookup_last_bucket_number):
5385 Now static.
5386 (make_symbol): Remove; unused.
5387 * lisp.h (initial_obarray, make_symbol): Remove decls.
5388
8a1414fa
PE
5389 * keyboard.c: Make symbols static if they're not exported.
5390 (single_kboard, recent_keys_index, total_keys, recent_keys):
5391 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5392 (this_single_command_key_start, echoing, last_auto_save):
5393 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5394 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5395 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5396 (Vlispy_mouse_stem, double_click_count):
5397 Now static.
5398 (force_auto_save_soon): Define only if SIGDANGER.
5399 (ignore_mouse_drag_p): Now static if
5400 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5401 (print_help): Remove; unused.
5402 (stop_character, last_timer_event): Mark as externally visible.
5403 * keyboard.h (ignore_mouse_drag_p): Declare only if
5404 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5405 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5406 * lisp.h (echoing): Remove decl.
5407 (force_auto_save_soon): Declare only if SIGDANGER.
5408 * xdisp.c (redisplay_window): Simplify code, to make it more
5409 obvious that ignore_mouse_drag_p is not accessed if !defined
5410 USE_GTK && !defined HAVE_NS.
5411
93ea6e8f
PE
5412 * intervals.c: Make symbols static if they're not exported.
5413 (merge_properties_sticky, merge_interval_right, delete_interval):
5414 Now static.
5415 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5416
77382fcc
PE
5417 * insdel.c: Make symbols static if they're not exported.
5418 However, leave prepare_to_modify_buffer alone. It's never
5419 called from outside this function, but that appears to be a bug.
5420 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5421 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5422 (adjust_after_replace_noundo): Remove; unused.
5423 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5424 (signal_before_change): Remove decls.
77382fcc 5425
9306c32e
PE
5426 * indent.c (val_compute_motion, val_vmotion): Now static.
5427
cd44d2eb
PE
5428 * image.c: Make symbols static if they're not exported.
5429 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5430 if USE_GTK.
5431 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5432 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5433
ad9a7a06
PE
5434 * fringe.c (standard_bitmaps): Now static.
5435 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5436
81626931
PE
5437 * frame.c: Make symbols static if they're not exported.
5438 (x_report_frame_params, make_terminal_frame): Now static.
5439 (get_frame_param): Now static, unless HAVE_NS.
5440 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5441 (x_get_resource_string): Remove; not used.
5442 * frame.h (make_terminal_frame, x_report_frame_params):
5443 (x_get_resource_string); Remove decls.
5444 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5445 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5446
239f9db9
PE
5447 * font.c, fontset.c: Make symbols static if they're not exported.
5448 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5449 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5450 * font.c (font_close_object): Now static.
5451 * font.h (font_close_object): Remove.
5452 * fontset.c (FONTSET_OBJLIST): Remove.
5453 (free_realized_fontset) #if-0 the body, which does nothing.
5454 (face_suitable_for_char_p): #if-0, as it's never called.
5455 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5456 * xfaces.c (face_at_string_position):
5457 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5458 since 0 is always ASCII.
5459
dfcf3579
PE
5460 * fns.c (weak_hash_tables): Now static.
5461
5045092b
PE
5462 * fileio.c: Make symbols static if they're not exported.
5463 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5464 (Vwrite_region_annotation_buffers): Now static.
5465
57a96f5c
PE
5466 * eval.c: Make symbols static if they're not exported.
5467 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5468 * lisp.h (backtrace_list): Remove decl.
5469
35f08c38
PE
5470 * emacs.c: Make symbols static if they're not exported.
5471 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5472 (fatal_error_code, fatal_error_signal_hook, standard_args):
5473 Now static.
5474 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5475 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5476 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5477 * lisp.h (fatal_error_signal_hook): Remove decl.
5478 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5479
f44bd759
PE
5480 * editfns.c: Move a (normally-unused) function to its only use.
5481 * editfns.c, lisp.h (get_operating_system_release): Remove.
5482 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5483 worth the hassle of breaking this out.
5484
b532497d
PE
5485 * xterm.c: Make symbols static if they're not exported.
5486 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5487 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5488 (x_destroy_window, x_delete_display):
5489 Now static.
5490 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5491 (x_mouse_leave): Remove; unused.
5492 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5493 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5494 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5495 Remove decls.
5496 (x_mouse_leave): Declare only if WINDOWSNT.
5497 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5498 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5499 USE_X_TOOLKIT.
5500
1675728f
PE
5501 * ftxfont.c: Make symbols static if they're not exported.
5502 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5503 HAVE_FREETYPE.
5504 * font.h (ftxfont_driver): Likewise.
5505
e4cebfca
PE
5506 * xfns.c: Make symbols static if they're not exported.
5507 (x_last_font_name, x_display_info_for_name):
5508 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5509 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5510 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5511 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5512 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5513 (last_show_tip_args): Now static.
5514 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5515 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5516 (x_screen_planes): Remove; unused.
5517 * dispextern.h (x_screen_planes): Remove decl.
5518
5bf46f05
PE
5519 * dispnew.c: Make symbols static if they're not exported.
5520 * dispextern.h (redraw_garbaged_frames, scrolling):
5521 (increment_row_positions): Remove.
5522 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5523 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5524 Now static.
5525 (redraw_garbaged_frames): Remove; unused.
5526
435f4c28
PE
5527 * xfaces.c: Make symbols static if they're not exported.
5528 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5529 Remove decls.
5530 * xterm.h (defined_color): Remove decls.
5531 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5532 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5533 (menu_face_changed_default, defined_color, free_realized_face):
5534 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5535 (ascii_face_of_lisp_face): Remove; unused.
5536
8524aef3
PE
5537 * xdisp.c: Make symbols static if they're not exported.
5538 * dispextern.h (scratch_glyph_row, window_box_edges):
5539 (glyph_to_pixel_coords, set_cursor_from_row):
5540 (get_next_display_element, set_iterator_to_next):
5541 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5542 (show_mouse_face): Remove decls
5543 * frame.h (message_buf_print): Likewise.
5544 * lisp.h (pop_message, set_message, check_point_in_composition):
5545 Likewise.
5546 * xterm.h (set_vertical_scroll_bar): Likewise.
5547 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5548 (message_buf_print, scratch_glyph_row, displayed_buffer):
5549 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5550 (get_next_display_element, show_mouse_face, window_box_edges):
5551 (frame_to_window_pixel_xy, check_point_in_composition):
5552 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5553 (glyph_to_pixel_coords): Remove; unused.
5554
16390cd2
PE
5555 * dired.c (file_name_completion): Now static.
5556
5557 * dbusbind.c (xd_in_read_queued_messages): Now static.
5558
a25f4dfa
PE
5559 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5560 * data.c (circular_list_error): Remove.
5561
14a9c8df
PE
5562 * commands.h (last_point_position, last_point_position_buffer):
5563 (last_point_position_window): Remove decls.
5564 * keyboard.c: Make these variables static.
5565
04f2d78b
CB
5566 * coding.h (coding, code_convert_region, encode_coding_gap):
5567 Remove decls.
74ab6df5
PE
5568 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5569 (iso_code_class, detect_coding, code_convert_region): Now static.
5570 (encode_coding_gap): Remove; unused.
5571
38dfbee1
PE
5572 * chartab.c (chartab_chars, chartab_bits): Now static.
5573
a2cb4e63
PE
5574 * charset.h (charset_iso_8859_1): Remove decl.
5575 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5576 Now static.
5577
127198fd
PE
5578 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5579 * ccl.c (Vccl_program_table): Now static.
5580 (check_ccl_update): Remove; unused.
5581
d85b608f
PE
5582 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5583 * category.h: ... from here.
5584 * category.c (check_category_table, set_category_set): Now static.
5585
31cd66f3
PE
5586 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5587 * lisp.h: Remove these decls.
5588
c358e587
PE
5589 * buffer.c (buffer_count): Remove unused var.
5590
e78aecca
PE
5591 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5592 so that it's not optimized away.
5593 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5594 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5595 exported only to the debugger.
5596
e192d7d3 5597 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5598 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5599
92470028
PE
5600 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5601 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5602 was inaccessible from Lisp.
5603 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5604 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5605
244ed907
PE
5606 alloc.c: Import and export fewer symbols, and remove unused items.
5607 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5608 is defined.
5609 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5610 it's not optimized away by whole-program optimization.
5611 (message_enable_multibyte, free_misc): Remove.
5612 (catchlist, handlerlist, mark_backtrace):
5613 Declare only if BYTE_MARK_STACK.
5614 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5615 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5616 (message_enable_multibyte): Remove decl.
5617 (free_misc, interval_free_list, float_block, float_block_index):
5618 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5619 (cons_free_list, last_marked_index):
5620 Now static.
5621 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5622 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5623 (mark_backtrace): Define only if BYTE_MARK_STACK.
5624 * xdisp.c (message_enable_multibyte): Now static.
5625
61c2b50e 5626 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5627 This makes it easier for human readers (and static analyzers)
5628 to see whether these variables are used from other modules.
5629 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5630 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5631 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5632 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5633 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5634 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5635 * xmenu.c, xselect.c:
5636 Declare Q* vars static if they are not used in other modules.
5637 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5638 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5639 Remove decls of unexported vars.
5640 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5641
95c82688
PE
5642 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5643
16a97296
PE
5644 Make Emacs functions such as Fatom 'static' by default.
5645 This makes it easier for human readers (and static analyzers)
5646 to see whether these functions can be called from other modules.
5647 DEFUN now defines a static function. To make the function external
5648 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5649 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5650 (Finit_image_library):
16a97296
PE
5651 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5652 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5653 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5654 Remove decls, since these functions are now static.
5655 (Funintern, Fget_internal_run_time): New decls, since these functions
5656 were already external.
95c82688 5657
16a97296
PE
5658 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5659 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5660 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5661 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5662 * keyboard.c, keymap.c, lread.c:
5663 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5664 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5665 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5666 Mark functions with DEFUE instead of DEFUN,
5667 if they are used in other modules.
5668 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5669 decls for now-static functions.
5670 * buffer.h (Fdelete_overlay): Remove decl.
5671 * callproc.c (Fgetenv_internal): Mark as internal.
5672 * composite.c (Fremove_list_of_text_properties): Remove decl.
5673 (Fcomposition_get_gstring): New forward static decl.
5674 * composite.h (Fcomposite_get_gstring): Remove decl.
5675 * dired.c (Ffile_attributes): New forward static decl.
5676 * doc.c (Fdocumntation_property): New forward static decl.
5677 * eval.c (Ffetch_bytecode): New forward static decl.
5678 (Funintern): Remove extern decl; now in .h file where it belongs.
5679 * fileio.c (Fmake_symbolic_link): New forward static decl.
5680 * image.c (Finit_image_library): New forward static decl.
5681 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5682 * intervals.h (Fprevious_property_change):
5683 (Fremove_list_of_text_properties): Remove decls.
5684 * keyboard.c (Fthis_command_keys): Remove decl.
5685 (Fcommand_execute): New forward static decl.
5686 * keymap.c (Flookup_key): New forward static decl.
5687 (Fcopy_keymap): Now static.
5688 * keymap.h (Flookup_key): Remove decl.
5689 * process.c (Fget_process): New forward static decl.
5690 (Fprocess_datagram_address): Mark as internal.
5691 * syntax.c (Fsyntax_table_p): New forward static decl.
5692 (skip_chars): Remove duplicate decl.
5693 * textprop.c (Fprevious_property_change): New forward static decl.
5694 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5695 Now internal.
5696 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5697 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5698
785bbd42
PE
5699 * editfns.c (Fformat): Remove unreachable code.
5700
8b913b57
AS
57012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5702
5703 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5704 change. (Bug#8496)
5705
a6744a35
EZ
57062011-04-13 Eli Zaretskii <eliz@gnu.org>
5707
5708 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5709 when at ZV. (Bug#8487)
5710
e7974947
AS
57112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5712
baad03f0
AS
5713 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5714 (Bug#8437)
5715 * keyboard.c (parse_tool_bar_item): Likewise.
5716 * sound.c (sound_cleanup, alsa_close): Likewise.
5717 * termcap.c (tgetent): Likewise.
5718 * xfns.c (x_default_font_parameter): Likewise.
5719 * xsettings.c (read_and_apply_settings): Likewise.
5720
e7974947
AS
5721 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5722 (overrun_check_free): Protoize.
5723
28272684
PE
57242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5725
5726 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5727 since callers should never pass a negative size.
5728 Change the signature to match that of plain 'read' and 'write'; see
5729 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5730 * lisp.h: Update prototypes of emacs_write and emacs_read.
5731
11997c76
EZ
57322011-04-11 Eli Zaretskii <eliz@gnu.org>
5733
5734 * xdisp.c (redisplay_window): Don't try to determine the character
5735 position of the scroll margin if the window start point w->startp
e896f03c 5736 is outside the buffer's accessible region. (Bug#8468)
11997c76 5737
8a2cbd72
EZ
57382011-04-10 Eli Zaretskii <eliz@gnu.org>
5739
5740 Fix write-region and its subroutines for buffers > 2GB.
5741 * fileio.c (a_write, e_write): Modify declaration of arguments and
5742 local variables to support buffers larger than 2GB.
5743 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5744
5745 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5746 argument, local variables, and return value.
5747
5748 * lisp.h: Update prototypes of emacs_write and emacs_read.
5749
5750 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5751
4073e537 57522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5753
1ebfdcb6
PE
5754 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5755
b2ded58d
PE
5756 Fix more problems found by GCC 4.6.0's static checks.
5757
7d66342c
PE
5758 * xdisp.c (vmessage): Use a better test for character truncation.
5759
bbf47d44
PE
5760 * charset.c (load_charset_map): <, not <=, for optimization,
5761 and to avoid potential problems with integer overflow.
9248994d 5762 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5763 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5764 * editfns.c (Fformat): Likewise.
1e69125e 5765 * syntax.c (skip_chars): Likewise.
3befa583 5766
e3019616
PE
5767 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5768 This also lets GCC 4.6.0 generate slightly better loop code.
5769
becfa255
PE
5770 * callint.c (Fcall_interactively): <, not <=, for optimization.
5771 (Fcall_interactively): Count the number of arguments produced,
5772 not the number of arguments given. This is simpler and lets GCC
5773 4.6.0 generate slightly better code.
5774
dae0cd48
PE
5775 * ftfont.c: Distingish more carefully between FcChar8 and char.
5776 The previous code passed unsigned char * to a functions like
5777 strlen and xstrcasecmp that expect char *, which does not
5778 conform to the C standard.
5779 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5780 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5781 char * when the C standard requires it.
5782
76032d70
PE
5783 * keyboard.c (read_char): Remove unused var.
5784
eb3f1cc8
PE
5785 * eval.c: Port to Windows vsnprintf (Bug#8435).
5786 Include <limits.h>.
5787 (SIZE_MAX): Define if the headers do not.
5788 (verror): Do not give up if vsnprintf returns a negative count.
5789 Instead, grow the buffer. This ports to Windows vsnprintf, which
5790 does not conform to C99. Problem reported by Eli Zaretskii.
5791 Also, simplify the allocation scheme, by avoiding the need for
5792 calling realloc, and removing the ALLOCATED variable.
5793
70476b54
PE
5794 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5795
12020a9e
PE
5796 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5797 But keep the doprint source code for now, as we might revamp it
5798 and use it again (Bug#8435).
ea6c7ae6
PE
5799 * lisp.h (doprnt): Remove.
5800 * Makefile.in (base_obj): Remove doprnt.o.
5801 * deps.mk (doprnt.o): Remove.
5802
5fdb398c
PE
5803 error: Print 32- and 64-bit integers portably (Bug#8435).
5804 Without this change, on typical 64-bit hosts error ("...%d...", N)
5805 was used to print both 32- and 64-bit integers N, which relied on
5806 undefined behavior.
5807 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5808 New macro.
5809 * lisp.h (error, verror): Mark as printf-like functions.
5810 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5811 Report overflow in size calculations when allocating printf buffer.
5812 Do not truncate output string at its first null byte.
5813 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5814 Truncate the output at a character boundary, since vsnprintf does not
5815 do that.
5816 * charset.c (check_iso_charset_parameter): Convert internal
5817 character to string before calling 'error', since %c now has the
5818 printf meaning.
5819 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5820 overflow when computing char to be passed to 'error'. Do not
5821 pass Lisp_Object to 'error'; pass the integer instead.
5822 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5823 formatted with plain %d.
5824
b189fa66
PE
5825 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5826
bff87ef0
PE
5827 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5828
7e2cac20
PE
5829 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5830
ce4d90b5
PE
5831 * xterm.c (x_catch_errors): Remove duplicate declaration.
5832
266c9547
PE
5833 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5834
79c49ad2
PE
5835 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5836
368f4090
JM
58372011-04-10 Jim Meyering <meyering@redhat.com>
5838
5839 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5840 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5841 return ssize_t not "int", and use size_t as the buffer length.
5842 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5843 * gnutls.h: Update declarations.
5844 * process.c (read_process_output): Use ssize_t, to match.
5845 (send_process): Likewise.
5846
a32d4040
CY
58472011-04-09 Chong Yidong <cyd@stupidchicken.com>
5848
5849 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5850
8546720e 58512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5852
04f2d78b
CB
5853 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5854 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5855
8546720e
GM
5856 * xterm.c (handle_one_xevent):
5857 * xmenu.c (create_and_show_popup_menu):
5858 * xselect.c (x_decline_selection_request)
5859 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5860
0a2f5c1a 58612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5862
5863 Fix some uses of `int' instead of EMACS_INT.
5864 * search.c (string_match_1, fast_string_match)
5865 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5866 (scan_buffer, find_next_newline_no_quit)
5867 (find_before_next_newline, search_command, Freplace_match)
5868 (Fmatch_data): Make some `int' variables be EMACS_INT.
5869
5870 * xdisp.c (display_count_lines): 3rd argument and return value now
5871 EMACS_INT. All callers changed.
5872 (pint2hrstr): Last argument is now EMACS_INT.
5873
5874 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5875 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5876 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5877 (decode_coding_utf_16, decode_coding_emacs_mule)
5878 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5879 (decode_coding_ccl, decode_coding_charset)
5880 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5881 (decode_coding_iso_2022, decode_coding_emacs_mule)
5882 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5883 <char_offset, last_offset>: Declare EMACS_INT.
5884 (encode_coding_utf_8, encode_coding_utf_16)
5885 (encode_coding_emacs_mule, encode_invocation_designation)
5886 (encode_designation_at_bol, encode_coding_iso_2022)
5887 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5888 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5889 Declare EMACS_INT.
5890 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5891 (encode_invocation_designation): Last argument P_NCHARS is now
5892 EMACS_INT.
5893 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5894 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5895
5896 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5897 All users changed.
5898
5899 * ccl.c (Fccl_execute_on_string): Declare some variables
5900 EMACS_INT.
5901
8546720e 59022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5903
5904 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5905
4e19a977
CS
59062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5907
5908 * process.c (Fformat_network_address): Doc fix.
5909
87302331
R
59102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5911
5912 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5913
cbb59342
CY
59142011-04-08 Chong Yidong <cyd@stupidchicken.com>
5915
5916 * keyboard.c (read_char): Call Lisp function help-form-show,
5917 instead of using internal_with_output_to_temp_buffer.
5918 (Qhelp_form_show): New var.
e0d38eeb 5919 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5920
5921 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5922
5923 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5924
e67a13ab
CY
59252011-04-06 Chong Yidong <cyd@stupidchicken.com>
5926
04f2d78b
CB
5927 * process.c (Flist_processes): Remove to Lisp.
5928 (list_processes_1): Delete.
e67a13ab 5929
973f782d
EZ
59302011-04-06 Eli Zaretskii <eliz@gnu.org>
5931
7c106b1e
EZ
5932 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5933
973f782d
EZ
5934 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5935
41cf7d1a 59362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5937
ca23cc88
PE
5938 Fix more problems found by GCC 4.6.0's static checks.
5939
f390e2d5
PE
5940 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5941
42eea0d0
PE
5942 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5943
b69769da 5944 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5945
f9541e84
PE
5946 * xdisp.c (vmessage): Mark as a printf-like function.
5947
13841b55
PE
5948 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5949
c136c10f
PE
5950 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5951
5e2d4a30
PE
5952 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5953 printf-like functions.
5954 (tiff_load): Add casts to remove these marks before passing them
5955 to system-supplied API.
5956
583f48b9
PE
5957 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5958
b25d760e
PE
5959 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5960 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5961 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5962 directly, rather than having caller test rule sign. This avoids
5963 some unnecessary tests.
5964 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5965 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5966 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5967
bc7b6697 5968 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5969 (xfont_open): Avoid unnecessary tests.
bc7b6697 5970
27ccc379
PE
5971 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5972
dcd5c89a
PE
5973 * composite.h, composite.c (composition_gstring_put_cache):
5974 Use EMACS_INT, not int, for length.
5975
b13a45c6
PE
5976 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5977 breaking out part of COMPOSITION_DECODE_RULE.
5978 (COMPOSITION_DECODE_RULE): Use it.
5979 * composite.c (get_composition_id): Remove unused local vars,
5980 by using the new macro.
5981
1e792e4d
PE
5982 * textprop.c (set_text_properties_1): Change while to do-while,
5983 since the condition is always true at first.
5984
dc6c6455 5985 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5986 (interval_deletion_adjustment): Return unsigned value.
5987 All uses changed.
dc6c6455 5988
aba7731a
PE
5989 * process.c (list_processes_1, create_pty, read_process_output):
5990 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5991 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5992 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5993 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5994 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5995
fdfc4bf3
PE
5996 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5997
fca8fe46 5998 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5999 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6000
06a0259a 6001 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6002 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6003 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6004
e7b9e80f
PE
6005 * print.c (print_error_message): Avoid int overflow.
6006
56201685
PE
6007 * font.c (font_list_entities): Redo for clarity,
6008 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6009
78834453 6010 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6011 (font_score): Avoid potential overflow in diff calculation.
78834453 6012
0bc0b309 6013 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6014 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6015
e610eaca
PE
6016 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6017
b895abce
PE
6018 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6019 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6020 can always succeed if overflow has undefined behavior.
6021
1f1d9321 6022 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6023 (wordify): Omit three unnecessary tests.
1f1d9321 6024
c59478bc
PE
6025 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6026 All callers changed. This avoids the need for an unused var.
6027
79b73827
PE
6028 * casefiddle.c (casify_region): Remove var that is set but not used.
6029
a4db5dfe
PE
6030 * dired.c (file_name_completion): Remove var that is set but not used.
6031
43aae36e
PE
6032 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6033
2a47c44d 6034 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6035 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6036
a37c69bf
PE
6037 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6038 Check for integer overflow on size calculations.
6039
328ab8e7
PE
6040 * buffer.c (Fprevious_overlay_change): Remove var that is set
6041 but not used.
6042
e5a2a5cb
PE
6043 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6044 Remove vars that are set but not used.
8d84a6eb 6045 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6046 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6047
a60e5f68
PE
6048 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6049
f661cb61 6050 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6051 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6052
f0397f5a
PE
6053 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6054 that are set but not used.
6055
8664db06 6056 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6057 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6058
6abdaa4a
PE
6059 * xselect.c (x_get_local_selection, x_handle_property_notify):
6060 Remove vars that are set but not used.
6061
0ce7538d 6062 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6063 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6064
9ae848fc
PE
6065 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6066 Remove var that is set but not used.
0b918413
PE
6067 (scroll_bar_windows_size): Now size_t, not int.
6068 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6069 Check for overflow.
9ae848fc 6070
a5a62657
PE
6071 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6072 (map_tty_color) [!defined MSDOS]: Likewise.
6073
5c5cdd39
PE
6074 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6075
66ebf983
PE
6076 * coding.c: Remove vars that are set but not used.
6077 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6078 All callers changed.
6079 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6080 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6081 (decode_coding_charset): Remove vars that are set but not used.
6082
1be4d761
PE
6083 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6084 that is set but not used.
6085
47553fa8
PE
6086 * print.c (print_object): Remove var that is set but not used.
6087
1f7196bf 6088 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6089 The gnulib version avoids calling malloc in the usual case,
6090 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6091 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6092 * filelock.c (current_lock_owner): Likewise.
6093 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6094 * sysdep.c: Include allocator.h, careadlinkat.h.
6095 (emacs_no_realloc_allocator): New static constant.
6096 (emacs_readlink): New function.
fdb61804
PE
6097 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6098 ../lib/careadlinkat.h.
d1fdcab7 6099
f84c17c7
SM
61002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6101
6102 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6103 first non-nil return value).
6104
ef3862ad
JD
61052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6106
6107 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6108 if not defined (Bug#8403).
6109
376a7006
JB
61102011-04-02 Juanma Barranquero <lekktu@gmail.com>
6111
6112 * xdisp.c (display_count_lines): Remove parameter `start',
6113 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6114 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6115 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6116 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6117 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6118 and thereabouts. All callers changed.
6119 (get_per_char_metric): Remove parameter `f', unused since
6120 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6121
6ca3801d
JM
61222011-04-02 Jim Meyering <meyering@redhat.com>
6123
6124 do not dereference NULL upon failed strdup
6125 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6126 (ns_get_family): Likewise.
6127
d8e2b5ba
JB
61282011-04-02 Juanma Barranquero <lekktu@gmail.com>
6129
6130 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6131
8c74fcbd
JD
61322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6133
6134 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6135 later (Bug#8403).
6136
7200d79c
SM
61372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6138
03408648 6139 Add lexical binding.
7200d79c 6140
03408648
SM
6141 * window.c (Ftemp_output_buffer_show): New fun.
6142 (Fsave_window_excursion):
6143 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6144
6145 * lread.c (lisp_file_lexically_bound_p): New function.
6146 (Fload): Bind Qlexical_binding.
6147 (readevalloop): Remove `evalfun' arg.
6148 Bind Qinternal_interpreter_environment.
6149 (Feval_buffer): Bind Qlexical_binding.
6150 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6151 Mark as dynamic.
6152 (syms_of_lread): Declare `lexical-binding'.
6153
6154 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6155
6156 * keyboard.c (eval_dyn): New fun.
6157 (menu_item_eval_property): Use it.
ca105506
SM
6158
6159 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6160
03408648
SM
6161 * fns.c (concat, mapcar1): Accept byte-code-functions.
6162
6163 * eval.c (Fsetq): Handle lexical vars.
6164 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6165 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6166 (FletX, Flet): Obey lexical binding.
6167 (Fcommandp): Handle closures.
6168 (Feval): New `lexical' arg.
6169 (eval_sub): New function extracted from Feval. Use it almost
6170 everywhere where Feval was used. Look up vars in lexical env.
6171 Handle closures.
6172 (Ffunctionp): Move from subr.el.
6173 (Ffuncall): Handle closures.
6174 (apply_lambda): Remove `eval_flags'.
6175 (funcall_lambda): Handle closures and new byte-code-functions.
6176 (Fspecial_variable_p): New function.
6177 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6178 but without exporting it to Lisp.
23aba0ea 6179
23aba0ea 6180 * doc.c (Fdocumentation, store_function_docstring):
03408648 6181 * data.c (Finteractive_form): Handle closures.
23aba0ea 6182
03408648
SM
6183 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6184 interactive spec.
ba83908c 6185
04f2d78b
CB
6186 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6187 New byte-codes.
03408648
SM
6188 (exec_byte_code): New function extracted from Fbyte_code to handle new
6189 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6190
03408648 6191 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6192
03408648 6193 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6194
e2abce01
JB
61952011-03-31 Juanma Barranquero <lekktu@gmail.com>
6196
6197 * xdisp.c (redisplay_internal): Fix prototype.
6198
63696a73 61992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6200
63696a73 6201 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6202 (try_scrolling): Use it when setting scroll_limit.
6203 Limit scrolling to 100 screen lines.
63696a73
EZ
6204 (redisplay_window): Even when falling back on "recentering",
6205 position point in the window according to scroll-conservatively,
6206 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6207
6208 (try_scrolling): When point is above the window, allow searching
6209 as far as scroll_max, or one screenful, to compute vertical
6210 distance from PT to the scroll margin position. This prevents
6211 try_scrolling from unnecessarily failing when
6212 scroll-conservatively is set to a value slightly larger than the
6213 window height. Clean up the case of PT below the margin at bottom
6214 of window: scroll_max can no longer be INT_MAX. When aggressive
6215 scrolling is in use, don't let point enter the opposite scroll
6216 margin as result of the scroll.
6217 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6218 threshold of 100 lines for never-recentering scrolling.
6219
e4cc2dfc
JB
62202011-03-31 Juanma Barranquero <lekktu@gmail.com>
6221
6222 * dispextern.h (move_it_by_lines):
6223 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6224 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6225 (message_log_check_duplicate): Remove parameters `prev_bol' and
6226 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6227 (redisplay_internal): Remove parameter `preserve_echo_area',
6228 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6229
6230 * indent.c (Fvertical_motion):
6231 * window.c (window_scroll_pixel_based, Frecenter):
6232 Don't pass `need_y_p' to `move_it_by_lines'.
6233
1c470562
SM
62342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6235
44f230aa
SM
6236 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6237 steal a few bits to be more compact.
6238 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6239 Remove unneeded casts.
6240
1c470562
SM
6241 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6242
888adce9
ZK
62432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6244
6245 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6246 binding" message (bug#7967).
6247
f838ed7b
PE
62482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6249
77861b95
PE
6250 Fix more problems found by GCC 4.6.0's static checks.
6251
de6dbc14
PE
6252 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6253 Remove unused local var.
6254
f838ed7b
PE
6255 * editfns.c (Fmessage_box): Remove unused local var.
6256
792c7b2b
PE
6257 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6258 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6259 Omit unused local vars.
c499e557 6260 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6261 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6262 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6263 Omit unused local var.
6264
ba0165e1
PE
6265 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6266 Don't assume string length fits in int.
32ad8845 6267 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6268 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6269
3c59b4c9
PE
6270 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6271 instead of alloca (Bug#8344).
6272
a3eed478 6273 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6274 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6275
eb4d412d
PE
6276 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6277
1658b401
PE
6278 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6279 concerns.
6280
6281 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6282
6283 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6284
9a2c6e05
PE
6285 * keyboard.c (syms_of_keyboard): Use the same style as later
6286 in this function when indexing through an array. This also
6287 works around GCC bug 48267.
6288
03d0a109
PE
6289 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6290
44f730c8
PE
6291 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6292
fe75f926
PE
6293 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6294 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6295
ffa8c828
PE
6296 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6297 This avoids undefined behavior on integer overflow, and is a bit
6298 more convenient anyway since it is compared to a size_t variable.
6299
c5101a77
PE
6300 Variadic C functions now count arguments with size_t, not int.
6301 This avoids an unnecessary limitation on 64-bit machines, which
6302 caused (substring ...) to crash on large vectors (Bug#8344).
6303 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6304 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6305 All variadic functions and their callers changed accordingly.
c5101a77
PE
6306 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6307 * data.c (arith_driver, float_arith_driver): Likewise.
6308 * editfns.c (general_insert_function): Likewise.
6309 * eval.c (struct backtrace.nargs, interactive_p)
6310 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6311 (funcall_lambda, mark_backtrace): Likewise.
6312 * fns.c (concat): Likewise.
6313 * frame.c (x_set_frame_parameters): Likewise.
6314 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6315 0 if not found, not -1. All callers changed.
6316
dd3f25f7
PE
6317 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6318 (stack_copy_size): Now size_t, not int.
6319 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6320
461c2ab9
JB
63212011-03-28 Juanma Barranquero <lekktu@gmail.com>
6322
6323 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6324 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6325 All callers changed.
6326
6327 * lisp.h (multibyte_char_to_unibyte):
6328 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6329 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6330 * character.h (CHAR_TO_BYTE8):
6331 * cmds.c (internal_self_insert):
6332 * editfns.c (general_insert_function):
6333 * keymap.c (push_key_description):
6334 * search.c (Freplace_match):
6335 * xdisp.c (message_dolog, set_message_1): All callers changed.
6336
f6d62986
SM
63372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6338
6339 * keyboard.c (safe_run_hook_funcall): New function.
6340 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6341 don't set the hook to nil, but remove the offending function instead.
6342 (Qcommand_hook_internal): Remove, unused.
6343 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6344 Vcommand_hook_internal.
6345
6346 * eval.c (enum run_hooks_condition): Remove.
6347 (funcall_nil, funcall_not): New functions.
6348 (run_hook_with_args): Call each function through a `funcall' argument.
6349 Remove `cond' argument, now redundant.
6350 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6351 (Frun_hook_with_args_until_failure): Adjust accordingly.
6352 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6353
1db5b1ad
JB
63542011-03-28 Juanma Barranquero <lekktu@gmail.com>
6355
6356 * dispextern.h (string_buffer_position): Remove declaration.
6357
6358 * print.c (strout): Remove parameter `multibyte', unused since
6359 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6360
6361 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6362 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6363 All callers changed.
6364
6365 * w32.c (_wsa_errlist): Use braces for struct initializers.
6366
6367 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6368 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6369 All callers changed.
6370 (string_buffer_position): Likewise. Also, make static (it's never
6371 used outside xdisp.c).
6372 (cursor_row_p): Remove parameter `w', unused since
6373 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6374 (decode_mode_spec): Remove parameter `precision', introduced during
6375 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6376 All callers changed.
6377
5ffb62aa
JD
63782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6379
6380 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6381
461c2ab9 63822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6383
6384 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6385 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6386 (ns_update_auto_hide_menu_bar): New functions.
6387 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6388 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6389 ns_constrain_all_frames.
6390 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6391 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6392
5c380ffb
JD
63932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6394
6395 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6396
9af30bdf
GM
63972011-03-27 Glenn Morris <rgm@gnu.org>
6398
6399 * syssignal.h: Replace RETSIGTYPE with void.
6400 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6401 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6402 Replace SIGTYPE with void everywhere.
6403 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6404 * s/template.h (SIGTYPE): Remove commented out definition.
6405
e2abce01
JB
64062011-03-26 Eli Zaretskii <eliz@gnu.org>
6407
6408 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6409 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6410
f868cd8a
JB
64112011-03-26 Juanma Barranquero <lekktu@gmail.com>
6412
59eb0929
JB
6413 * w32.c (read_unc_volume): Use parameter `henum', instead of
6414 global variable `wget_enum_handle'.
6415
6416 * keymap.c (describe_vector): Remove parameters `indices' and
6417 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6418 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6419
f868cd8a
JB
6420 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6421
6422 * keyboard.c (timer_check): Remove parameter `do_it_now',
6423 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6424 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6425 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6426
6427 * keyboard.c (read_char):
6428 * w32menu.c (w32_menu_display_help):
6429 * xmenu.c (show_help_event, menu_help_callback):
6430 Adjust calls to `show_help_echo'.
6431
6432 * gtkutil.c (xg_maybe_add_timer):
6433 * keyboard.c (readable_events):
6434 * process.c (wait_reading_process_output):
6435 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6436
6437 * insdel.c (adjust_markers_gap_motion):
6438 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6439 (gap_left, gap_right): Don't call it.
6440
2ecf6fdb
CY
64412011-03-25 Chong Yidong <cyd@stupidchicken.com>
6442
6443 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6444 incurred during fontification.
6445
6b1f9ba4
JB
64462011-03-25 Juanma Barranquero <lekktu@gmail.com>
6447
6448 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6449 (DEFVAR_PER_BUFFER): Don't pass it.
6450
6451 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6452 (scrolling_window): Don't pass it.
6453
0f4a96b5
JB
64542011-03-25 Juanma Barranquero <lekktu@gmail.com>
6455
6456 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6457
6458 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6459 and `suffix'.
6460 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6461 of variables specific to SELinux and computation of `encoded_absname'.
6462
6463 * image.c (XPutPixel): Remove unused variable `height'.
6464
6465 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6466
6467 * unexw32.c (get_section_info): Remove unused variable `section'.
6468
6469 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6470 (system_process_attributes): Remove unused variable `sess'.
6471 (sys_read): Remove unused variable `err'.
6472
6473 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6474 (w32_wnd_proc): Remove unused variable `isdead'.
6475 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6476 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6477 (x_create_tip_frame): Remove unused variable `tem'.
6478
6479 * w32inevt.c (w32_console_read_socket):
6480 Remove unused variable `no_events'.
6481
6482 * w32term.c (x_draw_composite_glyph_string_foreground):
6483 Remove unused variable `width'.
6484
1149507c
JB
64852011-03-24 Juanma Barranquero <lekktu@gmail.com>
6486
6487 * w32term.c (x_set_glyph_string_clipping):
6488 Don't pass uninitialized region to CombineRgn.
6489
9c88f339
JB
64902011-03-23 Juanma Barranquero <lekktu@gmail.com>
6491
6492 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6493 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6494 (Fx_close_connection): Remove unused variable `i'.
6495
6496 * w32font.c (w32font_draw): Return number of glyphs.
6497 (w32font_open_internal): Remove unused variable `i'.
6498 (w32font_driver): Add missing initializer.
6499
6500 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6501 (fill_in_menu): Remove unused variable `items_added'.
6502
6503 * w32term.c (last_mouse_press_frame): Remove static global variable.
6504 (w32_clip_to_row): Remove unused variable `f'.
6505 (x_delete_terminal): Remove unused variable `i'.
6506
6507 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6508 (NOTHING): Remove unused static global variable.
6509 (uniscribe_check_otf): Remove unused variable `table'.
6510 (uniscribe_font_driver): Add missing initializers.
6511
dee091a3
JD
65122011-03-23 Julien Danjou <julien@danjou.info>
6513
6514 * term.c (Fsuspend_tty, Fresume_tty):
6515 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6516 * window.c (temp_output_buffer_show):
6517 * insdel.c (signal_before_change):
6518 * frame.c (Fhandle_switch_frame):
6519 * fileio.c (Fdo_auto_save):
6520 * emacs.c (Fkill_emacs):
6521 * editfns.c (save_excursion_restore):
6522 * cmds.c (internal_self_insert):
6523 * callint.c (Fcall_interactively):
6524 * buffer.c (Fkill_all_local_variables):
6525 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6526 Use Frun_hooks.
0f4a96b5 6527 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6528 unconditionnaly since it does the check itself.
6529
2c520ab5 65302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6531
c9c49752
PE
6532 Fix more problems found by GCC 4.5.2's static checks.
6533
8abc3f12
PE
6534 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6535 the first time through the loop, since we know p0 < p1 then.
6536 This also avoids a gcc -Wstrict-overflow warning.
6537
a2d26660
PE
6538 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6539 leading to a memory leak, possible in functions like
6540 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6541 of objects (Bug#8318).
a2d26660 6542
916c72e9
PE
6543 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6544 that could (at least in theory) be that large.
6545
19ab8a18
PE
6546 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6547 This is less likely to overflow, and avoids undefined behavior if
6548 overflow does occur. All callers changed. Use strtoul to scan
6549 for the unsigned long integer.
b7cbbd6f
PE
6550 (pint2hrstr): Simplify and tune code slightly.
6551 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6552
f0641eff
PE
6553 * scroll.c (do_scrolling): Work around GCC bug 48228.
6554 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6555
7f650bb9
PE
6556 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6557 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6558 (validate_x_resource_name): Simplify count usage.
6559 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6560
37dd57d1
PE
6561 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6562 fail (Bug#8306).
81e56e61 6563
699979fc 6564 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6565
401bf9b4
PE
6566 * process.c (Fmake_network_process): Use socklen_t, not int,
6567 where POSIX says socklen_t is required in portable programs.
6568 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6569 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6570 (Fmake_network_process, server_accept_connection):
6571 (wait_reading_process_output, read_process_output):
6572 Likewise.
6573
b93aacde
PE
6574 * process.c: Rename or move locals to avoid shadowing.
6575 (list_processes_1, Fmake_network_process):
6576 (read_process_output_error_handler, exec_sentinel_error_handler):
6577 Rename or move locals.
4dc343ee 6578 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6579 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6580 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6581 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6582 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6583
af8a867c 6584 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6585 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6586 Include tparam.h instead, since it declares them.
af8a867c
PE
6587 * cm.h (PC): Remove extern decl; tparam.h now does this.
6588 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6589 * terminfo.c: Include tparam.h, to check interfaces.
6590 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6591 (tparam): Adjust signature to match interface in tparam.h;
6592 this removes some undefined behavior. Check that outstring and len
6593 are zero, which they always are with Emacs.
6594 * tparam.h (PC, BC, UP): New extern decls.
6595
0248044d 6596 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6597 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6598
8ff096c1 6599 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6600 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6601 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6602 (ftfont_list): Remove unused local.
49eaafba
PE
6603 (get_adstyle_property, ftfont_pattern_entity):
6604 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6605 Rename locals to avoid shadowing.
8ff096c1 6606
e2be39f6
PE
6607 * xfont.c (xfont_list_family): Mark var as initialized.
6608
c9735e30
PE
6609 * xml.c (make_dom): Now static.
6610
8f5201ae
PE
6611 * composite.c (composition_compute_stop_pos): Rename local to
6612 avoid shadowing.
b246f932
PE
6613 (composition_reseat_it): Remove unused locals.
6614 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6615 (composition_update_it): Mark var as initialized.
11b61122
PE
6616 (find_automatic_composition): Mark vars as initialized,
6617 with a FIXME (Bug#8290).
8f5201ae 6618
760fbc2c
PE
6619 character.h: Rename locals to avoid shadowing.
6620 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6621 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6622 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6623 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6624 to avoid shadowing.
6625
ff08eb85
PE
6626 * textprop.c (property_change_between_p): Remove; unused.
6627
fc7bf025
PE
6628 * intervals.c (interval_start_pos): Now static.
6629
235d7abc
PE
6630 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6631
44f230aa
SM
6632 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6633 Rename locals to avoid shadowing.
3e7d6594 6634
50060332
PE
6635 * sound.c (wav_play, au_play, Fplay_sound_internal):
6636 Fix pointer signedness.
d01f234b 6637 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6638 (wav_play): Initialize a variable to 0, to prevent undefined
6639 behavior (Bug#8278).
50060332 6640
c4fc4e30
PE
6641 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6642
918436ed
PE
6643 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6644
c939f91b
PE
6645 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6646 clobbering (Bug#8298).
b9c7f648
PE
6647 * sysdep.c (sys_subshell): Likewise.
6648 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6649
6bd8c144
PE
6650 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6651 This should get cleaned up, so that child_setup has the
6652 same signature on all platforms.
6653
7710357c 6654 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6655 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6656
c59da222
CY
66572011-03-22 Chong Yidong <cyd@stupidchicken.com>
6658
6659 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6660 not to be necessary, and produces flickering.
6661
66b87493
GM
66622011-03-20 Glenn Morris <rgm@gnu.org>
6663
6664 * config.in: Remove file.
6665
45b6f6d5
JB
66662011-03-20 Juanma Barranquero <lekktu@gmail.com>
6667
6668 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6669 are now in src/globals.h.
6670 (syms_of_minibuf): Remove spurious & from previous change.
6671
3ec03f7e
LL
66722011-03-20 Leo <sdl.web@gmail.com>
6673
6674 * minibuf.c (completing-read-function): New variable.
6675 (completing-read-default): Rename from completing-read.
6676 (completing-read): Call completing-read-function.
6677
b14e3e21
CY
66782011-03-19 Juanma Barranquero <lekktu@gmail.com>
6679
6680 * xfaces.c (Fx_load_color_file):
6681 Read color file from absolute filename (bug#8250).
6682
f2b726e6
JB
66832011-03-19 Juanma Barranquero <lekktu@gmail.com>
6684
6685 * makefile.w32-in: Update dependencies.
6686
09f6ff02
EZ
66872011-03-17 Eli Zaretskii <eliz@gnu.org>
6688
6689 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6690
29a6015a
PE
66912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6692
a3a6c54e
PE
6693 Fix more problems found by GCC 4.5.2's static checks.
6694
b766f867
PE
6695 * process.c (make_serial_process_unwind, send_process_trap):
6696 (sigchld_handler): Now static.
6697
be02381c
PE
6698 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6699 That way, the code declares only the vars that it needs.
6700 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6701 * s/cygwin.h (PTY_ITERATION): Likewise.
6702 * s/darwin.h (PTY_ITERATION): Likewise.
6703 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6704
57048744
PE
6705 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6706 * process.c (allocate_pty): Don't declare stb unless it's needed.
6707
7914961c 6708 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6709 (CONSTANTLIM): Remove; unused.
6710 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6711 Define only if needed.
7914961c 6712
b3967b18
PE
6713 * unexelf.c (unexec): Name an expression,
6714 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6715 Use a different way to cause a compilation error if anyone uses
6716 n rather than nn, a way that does not involve shadowing.
73366a00 6717 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6718
29a6015a
PE
6719 * deps.mk (unexalpha.o): Remove; unused.
6720
43cfc33e 6721 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6722 * unexec.h: New file.
ce701a33
PE
6723 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6724 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6725 Depend on unexec.h.
6726 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6727 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6728 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6729 Change as necessary to match prototype in unexec.h.
ce701a33 6730
01f44d5a
PE
6731 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6732 shadowing.
4f63c6bb 6733 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6734
a6670b0b
PE
6735 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6736 Rename locals to avoid shadowing.
6737
cef2010d 6738 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6739 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6740
d4d7173a
PE
6741 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6742
f08b802a
PE
6743 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6744 warning when compiling print.c.
6745
3ddb0639
PE
6746 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6747 instead of using an uninitialized var.
5ad03b97 6748 (font_sort_entities): Mark var as initialized.
3ddb0639 6749
170a2692
PE
6750 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6751
e663c700
PE
6752 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6753 pointers to constants.
89bc529a 6754 (font_parse_fcname): Remove unused vars.
7b81e2d0 6755 (font_delete_unmatched): Now static.
ea838e10 6756 (font_get_spec): Remove; unused.
13a547c6
PE
6757 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6758 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6759 Rename or move locals to avoid shadowing.
e663c700 6760
2a80c887 6761 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6762 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6763
1384fa33 6764 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6765 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6766
8b2c52e9
PE
6767 * alloc.c (mark_backtrace): Move decl from here ...
6768 * lisp.h: ... to here, so that it can be checked.
6769
475545b5 6770 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6771 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6772 (lisp_indirect_variable): Name an expression,
6773 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6774 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6775
b1349114 6776 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6777 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6778 Use const pointer when appropriate.
b1349114 6779
a2928364
PE
6780 * lisp.h (get_system_name, get_operating_system_release):
6781 Move decls here, to check interfaces.
6782 * process.c (get_operating_system_release): Move decl to lisp.h.
6783 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6784 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6785 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6786 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6787 (Fformat_time_string, Fencode_time, Finsert_char):
6788 (Ftranslate_region_internal, Fformat):
6789 Rename or remove local vars to avoid shadowing.
9710023e 6790 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6791
a415e694
PE
6792 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6793 avoid shadowing.
6794
8ef4622d
PE
6795 * lisp.h (eassert): Check that the argument compiles, even if
6796 ENABLE_CHECKING is not defined.
6797
946f9a5b
PE
6798 * data.c (Findirect_variable): Name an expression, to avoid
6799 gcc -Wbad-function-cast warning.
112396d6 6800 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6801 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6802 (Fmake_variable_buffer_local, Fmake_local_variable):
6803 Mark variables as initialized.
52746918 6804 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6805
e5aab7e7 6806 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6807 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6808 Rename locals to avoid shadowing.
dff45157
PE
6809 (mark_stack): Move local variables into the #ifdef region where
6810 they're used.
7bc26fdb
PE
6811 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6812 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6813 needed otherwise.
6814 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6815 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6816 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6817
e5aab7e7
PE
6818 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6819 avoids undefined behavior in theory.
6820
4da60324
PE
6821 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6822
88043301
PE
6823 Use functions, not macros, for up- and down-casing (Bug#8254).
6824 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6825 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6826 to use the following functions instead of these macros.
6827 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6828 EMACS_INT, since callers assume the returned value fits in int.
6829 (upcase1): Likewise, for UPCASE_TABLE.
6830 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6831 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6832 the race-condition problem in the old DOWNCASE.
88043301 6833
19ed5445
PE
6834 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6835 Rename locals to avoid shadowing.
6836 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6837 (regex_compile, re_search_2, re_match_2_internal):
6838 Remove unused local vars.
952db0d7
PE
6839 (FREE_VAR): Rewrite so as not to use empty "else",
6840 which gcc can warn about.
da053e48 6841 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6842 (RETALLOC_IF): Define only if needed.
6843 (WORDCHAR_P): Likewise. This one is never needed, but is used
6844 only in a comment talking about a compiler bug, so put inside
6845 the #if 0 of that comment.
6846 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6847 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6848 Remove; unused.
19ed5445 6849
1f3561e4 6850 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6851 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6852 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6853
ded6f8f7
PE
6854 * search.c (simple_search): Remove unused var.
6855
dbd37a95
PE
6856 * dired.c (compile_pattern): Move decl from here ...
6857 * lisp.h: ... to here, so that it can be checked.
6858 (struct re_registers): New forward decl.
6859
7e47afad
PE
6860 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6861
85f24f61
PE
6862 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6863 All uses changed.
6864 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6865 Rename locals to avoid shadowing.
5671df8f 6866 (Fvertical_motion): Mark locals as initialized.
85f24f61 6867
181aa2be 6868 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6869 (casify_region): Mark local as initialized.
181aa2be 6870
930d429c
PE
6871 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6872
7082eac6
PE
6873 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6874 New macros, so that the caller can use some names other than
6875 gcpro1, gcpro2, etc.
6876 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6877 of the new macros.
6878 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6879 argument, for consistency with GCPRO2_VAR, etc: it is now the
6880 prefix of the variable, not the variable itself. All uses
6881 changed.
38b2c076
PE
6882 * dired.c (directory_files_internal, file_name_completion):
6883 Rename locals to avoid shadowing.
6884
15206ed9
PE
6885 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6886 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6887 dired.c's scmp function, had undefined behavior.
6888 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6889 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6890 * buffer.h: ... to here, because these macros use current_buffer,
6891 and the new implementation with inline functions needs to have
6892 current_buffer in scope now, rather than later when the macros
6893 are used.
6894 (downcase, upcase1): New static inline functions.
6895 (DOWNCASE, UPCASE1): Reimplement using these functions.
6896 This avoids undefined behavior in expressions like
6897 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6898 from race conditions in accessing the global variables
6899 case_temp1 and case_temp2.
6900 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6901 * lisp.h (case_temp1, case_temp2): Remove their decls.
6902 * character.h (ASCII_CHAR_P): Move from here ...
6903 * lisp.h: ... to here, so that the inline functions mentioned
6904 above can use them.
6905
4a6bea26
PE
6906 * dired.c (directory_files_internal_unwind): Now static.
6907
f14b7e14
PE
6908 * fileio.c (file_name_as_directory, directory_file_name):
6909 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6910 Now static.
2893f146
PE
6911 (file_name_as_directory): Use const pointers when appropriate.
6912 (Fexpand_file_name): Likewise. In particular, newdir might
6913 point at constant storage, so make it a const pointer.
fd4ead52 6914 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6915 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6916 signedness issues.
f839df0c
PE
6917 (Fset_file_times, Finsert_file_contents, auto_save_error):
6918 Rename locals to avoid shadowing.
f14b7e14 6919
5716756e 6920 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6921 (Ftry_completion, Fall_completions): Rename or remove locals
6922 to avoid shadowing.
5716756e 6923
b4c3046a
PE
6924 * marker.c (bytepos_to_charpos): Remove; unused.
6925
b45db522
PE
6926 * lisp.h (verify_bytepos, count_markers): New decls,
6927 so that gcc does not warn that these functions aren't declared.
6928
85876d07
PE
6929 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6930 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6931 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6932 (copy_text): Remove unused local var.
85876d07 6933
03d78a21 6934 * filelock.c (within_one_second): Now static.
b3dd38ab 6935 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6936
5df8f01b
PE
6937 * buffer.c (fix_overlays_before): Mark locals as initialized.
6938 (fix_start_end_in_overlays): Likewise. This function should be
6939 simplified by using pointers-to-pointers, but that's a different
6940 matter.
b1d876f1 6941 (switch_to_buffer_1): Now static.
8f54f30a
PE
6942 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6943 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6944
a70072c9 6945 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6946 Fix pointer signedness issue.
edced198
PE
6947 (sys_subshell): Mark local as volatile if checking for lint,
6948 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6949 (MAXPATHLEN): Define only if needed.
a70072c9 6950
a0977c44
PE
6951 * process.c (serial_open, serial_configure): Move decls from here ...
6952 * systty.h: ... to here, so that they can be checked.
6953
a884fdcc
PE
6954 * fns.c (get_random, seed_random): Move extern decls from here ...
6955 * lisp.h: ... to here, so that they can be checked.
6956
604efe86 6957 * sysdep.c (reset_io): Now static.
b8950c94 6958 (wait_for_termination_signal): Remove; unused.
604efe86 6959
38fc62d9
PE
6960 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6961 (copy_keymap_item, append_key, push_text_char_description):
6962 Now static.
1004a21a 6963 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6964 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6965 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6966 (describe_map_tree):
6967 Rename locals to avoid shadowing.
38fc62d9 6968
2f2650da
PE
6969 * keyboard.c: Declare functions static if they are not used elsewhere.
6970 (echo_char, echo_dash, cmd_error, top_level_2):
6971 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6972 (read_char, kbd_buffer_get_event, make_lispy_position):
6973 (make_lispy_event, make_lispy_movement, apply_modifiers):
6974 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6975 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6976 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6977 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6978 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6979
a053e86c 6980 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6981 (mark_kboards): Move decl here ...
6982 * alloc.c (mark_kboards): ... from here.
a053e86c 6983
4752793e
PE
6984 * lisp.h (force_auto_save_soon): New decl.
6985
74f10ca7 6986 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6987 (DEFINE_DUMMY_FUNCTION): New macro.
6988 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6989 Use it.
c03cd23f
PE
6990 (main): Add casts to avoid warnings
6991 if GCC considers string literals to be constants.
74f10ca7 6992
022e70d4
PE
6993 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6994
59d6fe83
PE
6995 * dbusbind.c: Pointer signedness fixes.
6996 (xd_signature, xd_append_arg, xd_initialize):
6997 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6998 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6999 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7000 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7001
78320123
PE
7002 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7003 if GCC considers string literals to be constants.
49cebcca 7004 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7005
35ac2a97
SM
70062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7007
fb103ca9
SM
7008 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7009 (print_preprocess, print_object): New macro to fix last change.
7010
35ac2a97
SM
7011 * print.c (print_preprocess): Don't forget font objects.
7012
62973b41
JB
70132011-03-16 Juanma Barranquero <lekktu@gmail.com>
7014
7015 * emacs.c (USAGE3): Doc fixes.
7016
0e48bb22
AS
70172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7018
7019 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7020 structure.
7021
7684e57b
JB
70222011-03-14 Juanma Barranquero <lekktu@gmail.com>
7023
7024 * lisp.h (VWindow_system, Qfile_name_history):
7025 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7026 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7027 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7028
7029 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7030 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7031
7032 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7033 * w32console.c (detect_input_pending, read_input_pending)
7034 (encode_terminal_code):
7035 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7036 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7037 (w32_system_caret_y, Qfile_name_history):
7038 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7039 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7040 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7041 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7042 * w32proc.c (Qlocal, report_file_error):
7043 * w32term.c (Vwindow_system, updating_frame):
7044 * w32uniscribe.c (initialized, uniscribe_font_driver):
7045 Remove unneeded extern declarations.
7046
2aa46d6c
CY
70472011-03-14 Chong Yidong <cyd@stupidchicken.com>
7048
c96bbc66 7049 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7050
cffc6f3b
CY
70512011-03-13 Chong Yidong <cyd@stupidchicken.com>
7052
7053 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7054 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7055 These macros can no longer be used for assignment.
7056
44f230aa
SM
7057 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7058 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7059 (record_buffer_markers, fetch_buffer_markers): New functions for
7060 recording and fetching special buffer markers.
7061 (set_buffer_internal_1, set_buffer_temp): Use them.
7062
7063 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7064
7065 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7066
7067 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7068 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7069
7070 * xdisp.c (hscroll_window_tree):
7071 (reconsider_clip_changes): Use PT instead of BUF_PT.
7072
d251f04b
EZ
70732011-03-13 Eli Zaretskii <eliz@gnu.org>
7074
7075 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7076 $(EMACS_ROOT)/lib/intprops.h.
7077
f0c77cd1
PE
70782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7079
3eca4629
PE
7080 Fix more problems found by GCC 4.5.2's static checks.
7081
7c86ee98
PE
7082 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7083 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7084 (xg_free_frame_widgets): Make it clear that a local variable is
7085 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7086 (gdk_window_get_screen): Make it clear that this macro is needed
7087 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7088 (int_gtk_range_get_value): New function, which avoids a diagnostic
7089 from gcc -Wbad-function-cast.
7090 (xg_set_toolkit_scroll_bar_thumb): Use it.
7091 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7092 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7093 (get_utf8_string, xg_get_file_with_chooser):
7094 Rename locals to avoid shadowing.
7095 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7096
41729b81
PE
7097 * xgselect.c (xg_select): Remove unused var.
7098
f0c77cd1
PE
7099 * image.c (four_corners_best): Mark locals as initialized.
7100 (gif_load): Initialize transparent_p to zero (Bug#8238).
7101 Mark another local as initialized.
ec6cf4c6 7102 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7103
ce0ad53d 7104 * image.c (clear_image_cache): Now static.
d5d5a617 7105 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7106 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7107 (x_edge_detection): Remove unnecessary cast that
7108 gcc -Wbad-function-cast diagnoses.
2037898d 7109 (gif_load): Fix pointer signedness.
6ae141d6
PE
7110 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7111 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7112
33383987 71132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7114
d32df629
PE
7115 Improve quality of tests for time stamp overflow.
7116 For example, without this patch (encode-time 0 0 0 1 1
7117 1152921504606846976) returns the obviously-bogus value (-948597
7118 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7119 reports time overflow. See
7120 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7121 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7122 * editfns.c: Include limits.h and intprops.h.
7123 (TIME_T_MIN, TIME_T_MAX): New macros.
7124 (time_overflow): Move earlier, to before first use.
7125 (hi_time, lo_time): New functions, for an accurate test for
7126 out-of-range times.
7127 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7128 (Fget_internal_run_time): Don't assume time_t fits in int.
7129 (make_time): Use list2 instead of Fcons twice.
7130 (Fdecode_time): More accurate test for out-of-range times.
7131 (check_tm_member): New function.
7132 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7133 (lisp_time_argument): Don't rely on undefined left-shift and
7134 right-shift behavior when checking for time stamp overflow.
8be6f318 7135
fe31d94c
PE
7136 * editfns.c (time_overflow): New function, refactoring common code.
7137 (Fformat_time_string, Fdecode_time, Fencode_time):
7138 (Fcurrent_time_string): Use it.
7139
8be6f318
PE
7140 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7141 * dired.c (make_time): Move to ...
7142 * editfns.c (make_time): ... here.
7143 * systime.h: Note the move.
7144
09d9db2c 71452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7146
126bc0dc
YM
7147 * fringe.c (update_window_fringes): Remove unused variables.
7148
c47cbdfd
YM
7149 * unexmacosx.c (copy_data_segment): Also copy __got section.
7150 (Bug#8223)
7151
7ac80be9
EZ
71522011-03-12 Eli Zaretskii <eliz@gnu.org>
7153
c96bbc66 7154 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7155 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7156 Constify `char *' arguments and their references according to
7157 prototypes in tparam.h.
7158
ecb0f94d 7159 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7160
7ac80be9
EZ
7161 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7162 Adapt all references accordingly.
7163
7164 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7165
ef1fd07e
TT
71662011-03-11 Tom Tromey <tromey@redhat.com>
7167
7168 * buffer.c (syms_of_buffer): Remove obsolete comment.
7169
7ef4b50c
EZ
71702011-03-11 Eli Zaretskii <eliz@gnu.org>
7171
7172 * termhooks.h (encode_terminal_code): Declare prototype.
7173
7174 * msdos.c (encode_terminal_code): Don't declare prototype.
7175
7176 * term.c (encode_terminal_code): Now external again, used by
7177 w32console.c and msdos.c.
7178
44f230aa
SM
7179 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7180 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7181
4b1ec863 71822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7183
1714f52b 7184 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7185
4b1ec863
PE
7186 * fringe.c (update_window_fringes): Mark locals as initialized
7187 (Bug#8227).
7188 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7189
524c7aa6
PE
7190 * alloc.c (mark_fringe_data): Move decl from here ...
7191 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7192 to check its interface.
7193 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7194
a5c0af81 7195 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7196 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7197 (fontset_font): Mark local as initialized.
a9a06e0b 7198 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7199
b4716021
PE
7200 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7201
811e9bac 7202 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7203 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7204 (x_own_selection, Fx_disown_selection_internal): Rename locals
7205 to avoid shadowing.
7206 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7207
7e3ab302
PE
7208 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7209 so that the caller can use some name other than gcpro1.
7210 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7211 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7212 (Fx_backspace_delete_keys_p):
7213 Use them to avoid shadowing, and rename vars to avoid shadowing.
7214 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7215 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7216 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7217 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7218 Remove unused locals.
7e3ab302
PE
7219 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7220 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7221 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7222 macros.
f78faa98 7223
e2b13473
PE
7224 * xterm.h (x_mouse_leave): New decl.
7225
77f23912
PE
7226 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7227 Remove unused functions.
cdf4ba58
PE
7228 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7229 (x_calc_absolute_position): Now static.
7411c686 7230 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7231 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7232 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7233 unless they are used.
38d0b34a
PE
7234 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7235 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7236 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7237 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7238 (x_error_catcher, x_connection_closed, x_error_handler):
7239 (x_error_quitter, xembed_send_message, x_iconify_frame):
7240 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7241 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7242 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7243
44f230aa
SM
7244 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7245 Rename or move locals to avoid shadowing.
6b463e58 7246 (tty_defined_color, merge_face_heights): Now static.
5967d051 7247 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7248 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7249 does not deduce is never used uninitialized.
73719eba
PE
7250 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7251 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7252
426994c3 7253 * terminal.c (store_terminal_param): Now static.
5489860b 7254
032f1620 7255 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7256 (set_frame_menubar): Remove unused local.
d4323972 7257 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7258 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7259 since they might point to immutable storage.
281585b0
PE
7260 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7261 since it's unused otherwise.
032f1620 7262
367c19e5 7263 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7264 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7265 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7266 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7267 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7268 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7269 does not deduce are never used uninitialized.
70739cbe 7270
07b48fa9
PE
7271 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7272
8868a238 7273 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7274 * window.c (window_loop, size_window):
7275 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7276
7e5cf297 7277 * window.c (display_buffer): Now static.
d6550a9f
PE
7278 (size_window): Mark variables that gcc -Wuninitialized
7279 does not deduce are never used uninitialized.
a586633d
PE
7280 * window.h (check_all_windows): New decl, to forestall
7281 gcc -Wmissing-prototypes diagnostic.
5b555da1 7282 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7283
f6095868
PE
7284 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7285 shadowing.
7286 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7287 Include <limits.h>.
7288 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7289 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7290 (load_charset_map): Mark variables that gcc -Wuninitialized
7291 does not deduce are never used uninitialized.
53df7c11 7292 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7293
f38b440c
PE
7294 * coding.c (coding_set_source, coding_set_destination):
7295 Use "else { /* comment */ }" rather than "else /* comment */;"
7296 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7297 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7298 a block, when the outer 'i' will do.
7299 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7300 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7301 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7302 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7303 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7304 Rename locals to avoid shadowing.
7305 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7306 * coding.c (emacs_mule_char, encode_invocation_designation):
7307 Now static, since they're not used elsewhere.
413bb2db 7308 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7309 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7310 (decode_coding_emacs_mule): Mark variables that gcc
7311 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7312 (detect_coding_iso_2022): Initialize a local variable that might
7313 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7314 this initialization is needed. (Bug#8211)
5f58e762
PE
7315 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7316 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7317 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7318 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7319 Remove unused macros.
f38b440c 7320
232b38b9 7321 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7322 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7323 * character.c (string_count_byte8): Likewise.
232b38b9 7324
fb90da1b
PE
7325 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7326 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7327
fb93dbc2
PE
7328 * chartab.c (copy_sub_char_table): Now static, since it's not used
7329 elsewhere.
5c156ace
PE
7330 (sub_char_table_ref_and_range, char_table_ref_and_range):
7331 Rename locals to avoid shadowing.
bbcd0949 7332 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7333
7d3b3862 7334 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7335 (BIDI_BOB): Remove unused macro.
7d3b3862 7336
6be7d3da
PE
7337 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7338 deduce are never used uninitialized.
c2ed9c8b 7339 * term.c (encode_terminal_code): Likewise.
6be7d3da 7340
75f8807f 7341 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7342
50938595
PE
7343 * tparam.h: New file.
7344 * term.c, tparam.h: Include it.
7345 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7346 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7347 Move these decls to tparam.h, and make them agree with what
7348 is actually in tparam.c. The previous trick of using incompatible
7349 decls in different modules does not conform to the C standard.
7350 All callers of tparam changed to use tparam's actual API.
7351 * tparam.c (tparam1, tparam, tgoto):
7352 Use const pointers where appropriate.
7353
fbceeba2
PE
7354 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7355 * cm.h (struct cm): Likewise.
7356 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7357 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7358 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7359 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7360 (turn_on_face, init_tty): Likewise.
7361 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7362
7f3f1250
PE
7363 * term.c (term_mouse_position): Rename local to avoid shadowing.
7364
e6ca6543
PE
7365 * alloc.c (mark_ttys): Move decl from here ...
7366 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7367
c40f8d15
AS
73682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7369
7370 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7371
cfe0661d
JB
73722011-03-09 Juanma Barranquero <lekktu@gmail.com>
7373
7374 * search.c (compile_pattern_1): Remove argument regp, unused since
7375 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7376 (compile_pattern): Don't pass it.
7377
0afb4571
J
73782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7379
7380 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7381 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7382 for ! HAVE_GTK3.
7383 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7384
7385 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7386
7387 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7388 gdk_window_get_screen, gdk_window_get_geometry,
7389 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7390 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7391 (xg_get_pixbuf_from_pixmap): New function.
7392 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7393 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7394 Call xg_get_pixbuf_from_pixmap instead of
7395 gdk_pixbuf_get_from_drawable.
7396 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7397 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7398 (xg_check_special_colors): Use GtkStyleContext and its functions
7399 for HAVE_GTK3.
7400 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7401 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7402 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7403 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7404 Call gtk_widget_get_preferred_size.
0afb4571
J
7405 (xg_frame_resized): gdk_window_get_geometry only takes 5
7406 parameters.
44f230aa
SM
7407 (xg_win_to_widget, xg_event_is_for_menubar):
7408 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7409 (xg_set_widget_bg): New function.
7410 (delete_cb): New function.
895009e1 7411 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7412 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7413 (xg_set_background_color): Call xg_set_widget_bg.
7414 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7415 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7416 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7417 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7418 if ! HAVE_GTK3.
7419 (update_frame_tool_bar): Call gtk_widget_hide.
7420 (xg_initialize): Use GDK_KEY_g.
7421
7422 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7423 if ! HAVE_GTK3
7424 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7425
7426 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7427 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7428 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7429
1c2cc4ef
JB
74302011-03-08 Juanma Barranquero <lekktu@gmail.com>
7431
7432 * w32xfns.c (select_palette): Check success of RealizePalette against
7433 GDI_ERROR, not zero.
7434
33383987 7435See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7436
7437;; Local Variables:
7438;; coding: utf-8
aac0c6e3
MR
7439;; End:
7440
33383987 7441 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7442
7443 This file is part of GNU Emacs.
7444
7445 GNU Emacs is free software: you can redistribute it and/or modify
7446 it under the terms of the GNU General Public License as published by
7447 the Free Software Foundation, either version 3 of the License, or
7448 (at your option) any later version.
7449
7450 GNU Emacs is distributed in the hope that it will be useful,
7451 but WITHOUT ANY WARRANTY; without even the implied warranty of
7452 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7453 GNU General Public License for more details.
7454
7455 You should have received a copy of the GNU General Public License
7456 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.