* sysdep.c (setpgrp): Remove definition, not used in this file.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e2f560b1
DN
12012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2
3 * sysdep.c (setpgrp): Remove definition, not used in this file.
4
7583a3a1
JB
52012-06-24 Juanma Barranquero <lekktu@gmail.com>
6
7 * makefile.w32-in: Update dependencies.
8
696056c2
EZ
92012-06-24 Eli Zaretskii <eliz@gnu.org>
10
11 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
12 (SYSTIME_H): Add nt/inc/sys/time.h.
13
14 * systime.h [WINDOWSNT]: Include sys/time.h.
15
16 * s/ms-w32.h (struct timespec): Definition moved from
17 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
18
845ca893
PE
192012-06-24 Paul Eggert <eggert@cs.ucla.edu>
20
21 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
22 * buffer.h (buffer_slot_type_mismatch):
23 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
24 * eval.c (unwind_to_catch):
25 * image.c (my_png_error, my_error_exit):
26 * keyboard.c (quit_throw_to_read_char, user_error)
27 (Fexit_recursive_edit, Fabort_recursive_edit):
28 * lisp.h (die, args_out_of_range, args_out_of_range_3)
29 (wrong_type_argument, buffer_overflow, __executable_start)
30 (memory_full, buffer_memory_full, string_overflow, Fthrow)
31 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
32 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
33 (fatal):
34 (child_setup) [!DOS_NT]:
35 * lread.c (end_of_file_error, invalid_syntax):
36 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
37 * puresize.h (pure_write_error):
38 * search.c (matcher_overflow):
39 * sound.c (sound_perror, alsa_sound_perror):
40 * sysdep.c, syssignal.h (croak):
41 * term.c (maybe_fatal, vfatal):
42 * textprop.c (text_read_only):
43 * undo.c (user_error):
44 * unexmacosx.c (unexec_error):
45 * xterm.c (x_ins_del_lines, x_delete_glyphs):
46 Use _Noreturn rather than NO_RETURN.
47 No need for separate decl merely because of _Noreturn.
48 * sound.c (sound_warning, parse_sound):
49 Remove unnecessary forward decls.
50
f1dd8073
PE
512012-06-24 Paul Eggert <eggert@cs.ucla.edu>
52
53 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
54 * lisp.h (WAIT_READING_MAX): New macro.
55 * dispnew.c (Fsleep_for, sit_for):
56 * keyboard.c (kbd_buffer_get_event):
57 * process.c (Faccept_process_output):
58 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
59 This improves on the previous patch, which introduced a bug
60 when time_t is unsigned and as wide as intmax_t.
61 See <http://bugs.gnu.org/9000#51>.
62
b82c1755
EZ
632012-06-23 Eli Zaretskii <eliz@gnu.org>
64
65 * dispnew.c (sit_for, Fsleep_for):
66 * keyboard.c (kbd_buffer_get_event):
67 * process.c (Faccept_process_output): Avoid compiler warnings when
68 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
69
ca300656
JB
702012-06-23 Juanma Barranquero <lekktu@gmail.com>
71
049ec95b
JB
72 * makefile.w32-in: Update dependencies.
73
ca300656
JB
74 * w32.c (ltime): Add return type and declare static.
75 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
76
db7b8d06
PE
772012-06-23 Paul Eggert <eggert@cs.ucla.edu>
78
79 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
80 Privately reported by Herbert J. Skuhra.
81 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
82 All uses changed.
83 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
84 not make_lisp_timeval, when the argument is of type EMACS_TIME.
85
0bd8297f
EZ
862012-06-23 Eli Zaretskii <eliz@gnu.org>
87
96512555
EZ
88 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
89 last argument of make_unibyte_string.
90
0bd8297f
EZ
91 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
92 language ID in the event parameters.
93
94 * w32term.c (w32_read_socket): Put the new keyboard codepage into
95 event.code, not the obscure "character set ID".
96
63def6b6
CY
972012-06-23 Chong Yidong <cyd@gnu.org>
98
99 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
100
e8a02204
EZ
1012012-06-23 Eli Zaretskii <eliz@gnu.org>
102
388cdec0
EZ
103 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
104 * w32.c (fdutimens): New function.
105
106 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
107
108 * s/ms-w32.h (pselect): Redirect to sys_select.
109
110 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
111
e8a02204
EZ
112 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
113 in the logic of incrementing and decrementing the value of
114 use_relocatable_buffers.
115
d054f3fb
PE
1162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
117
118 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
119 Privately reported by Herbert J. Skuhra.
120 [__FreeBSD__]: Remove "*/" typo after "#include".
121 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
122 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
123 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
124 Don't assume EMACS_TIME and struct timeval are the same type.
125
d35af63c
PE
1262012-06-22 Paul Eggert <eggert@cs.ucla.edu>
127
128 Support higher-resolution time stamps (Bug#9000).
129 The time stamps are only nanosecond-resolution at the C level,
130 since that's the best that any real-world system supports now.
131 But they are picosecond-resolution at the Lisp level, as that's
132 easy, and leaves room for future OS improvements.
133
134 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
135 (LIBES): Use it.
136
137 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
138 Don't get current time unless it's needed.
139
140 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
141 now provides it if it's absent.
142 (start_atimer): Port to higher-res time stamps.
143 Check for time stamp overflow. Don't get current time more
144 often than is needed.
145
146 * buffer.h (struct buffer): Buffer modtime now has high resolution.
147 Include systime.h, not time.h.
148 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
149
150 * dired.c: Include stat-time.h.
151 (Ffile-attributes): File times now have higher resolution.
152
153 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
154 (struct image): Timestamp now has higher resolution.
155
156 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
157 has at least microseconds now. All uses removed.
158 (update_frame, update_single_window, update_window, update_frame_1)
159 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
160
161 * editfns.c (time_overflow): Now extern.
162 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
163 (float-time, Fformat_time_string, Fcurrent_time_string)
164 (Fcurrent_time_zone): Accept and generate higher-resolution
165 time stamps.
166 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
167 (decode_time_components, lisp_seconds_argument): New functions.
168 (make_time): Now static.
169 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
170 Report an error if the time is invalid, rather than having the caller
171 do that.
172
173 * fileio.c: Include <stat-time.h>
174 (Fcopy_file): Copy higher-resolution time stamps.
175 Prefer to set the time stamp via a file descriptor if that works.
176 (Fset_file_times, Finsert_file_contents, Fwrite_region)
177 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
178 (Fvisited_file_modtime, Fset_visited_file_modtime):
179 Support higher-resolution time stamps.
180
181 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
182
183 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
184
185 * image.c (prepare_image_for_display, clear_image_cache)
186 (lookup_image): Port to higer-resolution time stamps.
187
188 * keyboard.c (start_polling, bind_polling_period):
189 Check for time stamp overflow.
190 (read_char, kbd_buffer_get_event, timer_start_idle)
191 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
192 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
193 Port to higher-resolution time stamps. Do not assume time_t is signed.
194 (decode_timer): New function. Timers are now vectors of length 9,
195 not 8, to accommodate the picosecond component.
196 (timer_check_2): Use it.
197
198 * nsterm.m (select_timeout, timeval_subtract): Remove.
199 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
200 as they're a bit more accurate and handle overflow better.
201 (ns_select): Change prototype to be compatible with pselect.
202 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
203 * nsterm.h (ns_select): Adjust prototype.
204
205 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
206 us-resolution time stamps.
207 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
208
209 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
210
211 * lisp.h (time_overflow): New decl.
212 (wait_reading_process_output): First arg is now intmax_t, not int,
213 to accommodate larger waits.
214
215 * process.h (struct Lisp_Process.read_output_delay):
216 Now counts nanoseconds, not microseconds.
217 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
218 EMACS_HAS_USECS.
219 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
220 (wait_reading_process_output):
221 Port to ns-resolution time stamps.
222 (Faccept_process_output, wait_reading_process_output):
223 Check for time stamp overflow. Do not assume time_t is signed.
224 (select_wrapper): Remove; we now use pselect.
225 (Fprocess_attributes): Now generates ns-resolution time stamps.
226
227 * sysdep.c: Include utimens.h. Don't include utime.h
228 or worry about struct utimbuf; gnulib does that for us now.
229 (gettimeofday): Remove; gnulib provides a substitute.
230 (make_timeval): New function.
231 (set_file_times): Now sets ns-resolution time stamps.
232 New arg FD; all uses changed.
233 (time_from_jiffies, ltime_from_jiffies, get_up_time)
234 (system_process_attributes):
235 Now returns ns-resolution time stamp. All uses changed.
236 Check for time stamp overflow.
237
238 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
239 provides a substitute now.
240
241 * systime.h: Include timespec.h rather than sys/time.h and time.h,
242 since it guarantees struct timespec.
243 (EMACS_TIME): Now struct timespec, so that we can support
244 ns-resolution time stamps.
245 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
246 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
247 (EMACS_USECS): Remove.
248 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
249 so multiply the arg by 1000 before storing it.
250 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
251 New macros.
252 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
253 Port to ns-resolution time stamps.
254 (EMACS_TIME_NEG_P): Remove; replaced by....
255 (EMACS_TIME_SIGN): New macro.
256 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
257 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
258 (set_file_times, make_time, lisp_time_argument): Adjust signature.
259 (make_timeval, make_lisp_time, decode_time_components): New decls.
260 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
261 that it mishandled time_t overflow. You can't compare by subtracting!
262 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
263 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
264
265 * term.c: Include <sys/time.h>.
266 (timeval_to_Time): New function, for proper overflow wraparound.
267 (term_mouse_position, term_mouse_click): Use it.
268
269 * undo.c (record_first_change): Support higher-resolution time stamps
270 in the undo buffer.
271 (Fprimitive_undo): Use them when restoring time stamps.
272
273 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
274 (w32_get_internal_run_time):
275 Port to higher-resolution Emacs time stamps.
276 (ltime): Now accepts single 64-bit integer, as that's more convenient
277 for callers.
278
279 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
280
281 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
282 for compatibility with pselect. Support ns-resolution time stamps.
283
284 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
285
286 * xselect.c (wait_for_property_change, x_get_foreign_selection):
287 Check for time stamp overflow, and support ns-resolution time stamps.
288
289 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
290 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
291 (timeval_subtract): Remove; no longer needed.
292 (XTflash, XTring_bell, x_wait_for_event):
293 Port to ns-resolution time stamps. Don't assume time_t is signed.
294
b6a92dfe
CY
2952012-06-22 Chong Yidong <cyd@gnu.org>
296
297 * xdisp.c (x_consider_frame_title): Revert last change.
298
d251c37c
EZ
2992012-06-22 Eli Zaretskii <eliz@gnu.org>
300
301 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
302 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
303 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
304 staticidx goes up to 1597 out of 1600 = 0x640.)
305
f10deafb
PE
3062012-06-20 Paul Eggert <eggert@cs.ucla.edu>
307
308 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
309 Otherwise, the umask might be mistakenly 0 while handling input signals.
310
ec6de1e2
SM
3112012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
312
313 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
314
28be1ada
DA
3152012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
316
317 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
318 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
319 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
320 access to `contents' member of Lisp_Vector objects with AREF and ASET
321 where appropriate.
322
c6bf3022
CY
3232012-06-19 Chong Yidong <cyd@gnu.org>
324
325 * frame.c (delete_frame): When selecting a frame on a different
326 text terminal, do not alter the terminal's top-frame.
327
328 * xdisp.c (format_mode_line_unwind_data): Record the target
329 frame's selected window and its terminal's top-frame.
330 (unwind_format_mode_line): Restore them.
331 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
332 Callers changed.
333 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
334 since tty frames can be explicitly named.
335 (prepare_menu_bars): Likewise.
336
337 * term.c (Ftty_top_frame): New function.
338
defd4196
PE
3392012-06-18 Paul Eggert <eggert@cs.ucla.edu>
340
341 Port byte-code-meter to modern targets.
342 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
343 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 344 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
345 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
346 (METER_1, METER_2): Simplify.
347
1053a871
SM
3482012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * data.c (Fdefalias): Return `symbol' (bug#11686).
351
b7e8d081
MR
3522012-06-18 Martin Rudalics <rudalics@gmx.at>
353
354 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
355 gets killed during executing of this function (Bug#11665).
356 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
357 (Vkill_buffer_query_functions): In doc-string say that functions
358 run by this hook should not change the current buffer.
359
7ea2b339
PE
3602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
361
362 Fix recently-introduced process.c problems found by static checking.
363 * process.c (write_queue_push, write_queue_pop, send_process):
364 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
365 (write_queue_pop): Fix pointer signedness problem.
366 (send_process): Remove unused local.
367
96a313a1
CY
3682012-06-17 Chong Yidong <cyd@gnu.org>
369
370 * xdisp.c (redisplay_internal): No need to redisplay terminal
371 frames that are not on top.
372
20ca2e94
TN
3732012-06-17 Troels Nielsen <bn.troels@gmail.com>
374
375 * process.c (make_process): Initialize write_queue.
376 (write_queue_push, write_queue_pop): New functions.
377 (send_process): Use them to maintain correct ordering of process
378 writes (Bug#10815).
379
9a900ca9
PE
3802012-06-17 Paul Eggert <eggert@cs.ucla.edu>
381
310fbfa8
PE
382 * lisp.h (eassert): Assume C89 or later.
383 This removes the need for CHECK.
384 (CHECK): Remove. Its comments about always evaluating its
385 argument were confusing, as 'eassert' typically does not evaluate
386 its argument.
387
27bb1ca4
PE
388 * coding.c (produce_chars): Use ptrdiff_t, not int.
389
9a900ca9
PE
390 * xterm.c (x_draw_underwave): Check for integer overflow.
391 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
392
41b7f8bc 3932012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
394
395 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
396 referenced (Bug#11583).
397
9b0e3eba
AA
3982012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
399
400 Implement wave-style variant of underlining.
401 * dispextern.h (face_underline_type): New enum.
402 (face): Add field for underline type.
403 * nsterm.m (ns_draw_underwave): New function.
404 (ns_draw_text_decoration): Use it.
405 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
406 New functions.
407 (x_draw_glyph_string): Use them.
408 * xfaces.c (Qline, Qwave): New Lisp objects.
409 (check_lface_attrs, merge_face_ref)
1053a871
SM
410 (Finternal_set_lisp_face_attribute, realize_x_face):
411 Handle wave-style underline face attributes.
9b0e3eba
AA
412 * xterm.c (x_draw_underwave): New function.
413 (x_draw_glyph_string): Use it.
414
0fb52f11
JB
4152012-06-16 Juanma Barranquero <lekktu@gmail.com>
416
417 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
418 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
419 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
420 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
421 ($(BLD)/w32select.$(O)): Update dependencies.
422
e5560ff7
AS
4232012-06-16 Andreas Schwab <schwab@linux-m68k.org>
424
425 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
426 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
427 * character.c (_fetch_multibyte_char_p): Remove.
428 * alloc.c: Include "character.h" before "buffer.h".
429 * bidi.c: Likewise.
430 * buffer.c: Likewise.
431 * bytecode.c: Likewise.
432 * callint.c: Likewise.
433 * callproc.c: Likewise.
434 * casefiddle.c: Likewise.
435 * casetab.c: Likewise.
436 * category.c: Likewise.
437 * cmds.c: Likewise.
438 * coding.c: Likewise.
439 * composite.c: Likewise.
440 * dired.c: Likewise.
441 * dispnew.c: Likewise.
442 * doc.c: Likewise.
443 * dosfns.c: Likewise.
444 * editfns.c: Likewise.
445 * emacs.c: Likewise.
446 * fileio.c: Likewise.
447 * filelock.c: Likewise.
448 * font.c: Likewise.
449 * fontset.c: Likewise.
450 * fringe.c: Likewise.
451 * indent.c: Likewise.
452 * insdel.c: Likewise.
453 * intervals.c: Likewise.
454 * keyboard.c: Likewise.
455 * keymap.c: Likewise.
456 * lread.c: Likewise.
457 * macros.c: Likewise.
458 * marker.c: Likewise.
459 * minibuf.c: Likewise.
460 * nsfns.m: Likewise.
461 * nsmenu.m: Likewise.
462 * print.c: Likewise.
463 * process.c: Likewise.
464 * regex.c: Likewise.
465 * region-cache.c: Likewise.
466 * search.c: Likewise.
467 * syntax.c: Likewise.
468 * term.c: Likewise.
469 * textprop.c: Likewise.
470 * undo.c: Likewise.
471 * unexsol.c: Likewise.
472 * w16select.c: Likewise.
473 * w32fns.c: Likewise.
474 * w32menu.c: Likewise.
475 * window.c: Likewise.
476 * xdisp.c: Likewise.
477 * xfns.c: Likewise.
478 * xmenu.c: Likewise.
479 * xml.c: Likewise.
480 * xselect.c: Likewise.
481
2f07e6af
EZ
4822012-06-16 Eli Zaretskii <eliz@gnu.org>
483
1053a871
SM
484 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
485 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 486 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
487 row.
488 (handle_face_prop): Use chunk-relative overlay string index when
489 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
490 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
491 the rightmost. (Bug#11720)
2f07e6af 492
29b83cec
AS
4932012-06-16 Andreas Schwab <schwab@linux-m68k.org>
494
495 * category.h (CHAR_HAS_CATEGORY): Define as inline.
496 (CATEGORY_MEMBER): Enforce 1/0 value.
497 * category.c (_temp_category_set): Remove.
498
4c5501e9
EZ
4992012-06-16 Eli Zaretskii <eliz@gnu.org>
500
501 * window.c (Fdelete_other_windows_internal)
502 (Fdelete_window_internal): Don't access frame's mouse highlight
503 info of the initial frame. (Bug#11677)
504
2b570124
PE
5052012-06-14 Paul Eggert <eggert@cs.ucla.edu>
506
e93864f9
PE
507 * .gdbinit (xgetint): Fix recently-introduced paren typo.
508 Assume USE_2_TAGS_FOR_INTS.
509 (xreload): Adjust $tagmask width to match recent lisp.h change.
510
2b570124
PE
511 Simplify lisp.h in minor ways that should not affect code.
512 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
513 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
514 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
515 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
516 (INTTYPEBITS): New macro, for clarity.
517 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
518 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
519 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
520 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
521 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
522
81755f69
JB
5232012-06-13 Juanma Barranquero <lekktu@gmail.com>
524
525 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
526
16192a57
GM
5272012-06-13 Glenn Morris <rgm@gnu.org>
528
529 * s/bsd-common.h (BSD4_3):
530 * s/usg5-4-common.h (USG5_4): No longer define; unused.
531
646b5f55
AS
5322012-06-13 Andreas Schwab <schwab@linux-m68k.org>
533
534 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
535 instead of union.
536 (XLI, XIL): Define.
1053a871
SM
537 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
538 Use them.
539 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 540 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 541 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
542 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
543 * frame.c (delete_frame): Remove outdated comment.
544 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
545 USE_LISP_UNION_TYPE.
546 (Fw32_unregister_hot_key): Likewise.
547 (Fw32_toggle_lock_key): Likewise.
548 * w32menu.c (add_menu_item): Likewise.
549 (w32_menu_display_help): Use XIL instead of checking
550 USE_LISP_UNION_TYPE.
551 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
552 (init_heap): Likewise.
553 * w32term.c (w32_read_socket): Update comment.
554
1d3823c9
GM
5552012-06-13 Glenn Morris <rgm@gnu.org>
556
c62ff706
GM
557 * s/usg5-4-common.h, src/s/unixware.h:
558 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
559
1d3823c9
GM
560 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
561
bfe3e0a2
PE
5622012-06-13 Paul Eggert <eggert@cs.ucla.edu>
563
564 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
565 * alloc.c (make_number) [!defined make_number]:
566 Remove, as lisp.h always defines this now.
567 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
568 (roundup_size): Verify that it is a power of 2.
569 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
570 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
571 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
572 -DUSE_LSB_TAG=0, to override the automatically-selected default.
573 USE_LSB_TAG now is always defined to be either 0 or 1.
574 All uses changed.
575 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
576 code works fine either way, and efficiency is not a concern here,
577 as the union type is for debugging, not for production.
578 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
579 Use an inline function on all platforms when using the union type,
580 since this is simpler and 'static inline' can be used portably
581 within Emacs now.
582 (LISP_INITIALLY_ZERO): New macro.
583 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
584 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
585
45fa9c0f
GM
5862012-06-12 Glenn Morris <rgm@gnu.org>
587
b4492cba
GM
588 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
589
590 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 591
45fa9c0f
GM
592 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
593 Move BROKEN_SIGIO to configure.
594
595 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
596 Move NO_TERMIO to configure.
597
0e25d334
CY
5982012-06-12 Chong Yidong <cyd@gnu.org>
599
600 * image.c (imagemagick_load_image): Use MagickFlattenImage if
601 MagickMergeImageLayers is undefined. Use pixel pusher loop if
602 MagickExportImagePixels is undefined.
603
43682bb6
PE
6042012-06-12 Paul Eggert <eggert@cs.ucla.edu>
605
606 * image.c (imagemagick_load_image): Remove unused label.
607
a9be7d2b
GM
6082012-06-11 Glenn Morris <rgm@gnu.org>
609
610 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
611 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
612 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
613 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
614
3017f87f
SM
6152012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
616
617 * alloc.c (make_byte_code): New function.
618 (Fmake_byte_code): Use it. Don't purify here.
619 * lread.c (read1): Use it as well to avoid extra allocation.
620
1b9b4cf4
CY
6212012-06-11 Chong Yidong <cyd@gnu.org>
622
623 * image.c (imagemagick_load_image): Implement transparency.
624
95988fcf
AS
6252012-06-10 Andreas Schwab <schwab@linux-m68k.org>
626
627 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
628 account for preceding backslashes. (Bug#11663)
629
cd4eb164
CY
6302012-06-09 Chong Yidong <cyd@gnu.org>
631
632 * term.c: Support italics in capable terminals (Bug#9652).
633 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
634 (turn_on_face): Output using TS_enter_italic_mode if available.
635 Don't handle unused blinking and alt-charset cases.
636 (turn_off_face): Handle italic case; discard unused tty_blinking_p
637 and tty_alt_charset_p cases.
638 (tty_capable_p, init_tty): Support italics.
639
640 * termchar.h (struct tty_display_info): Add field for italics.
641 Remove unused blink field.
642
643 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
644 Handle slant.
645
646 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
647 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
648 tty_alt_charset_p. Add tty_italic_p.
649
ff88beb8
MA
6502012-06-09 Michael Albinus <michael.albinus@gmx.de>
651
652 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
653 dbus_type_is_basic if available.
654 (xd_extract_signed, xd_extract_unsigned): Rename from
655 extract_signed and extract_unsigned, respectively. Adapt callers.
656
44286096
CY
6572012-06-09 Chong Yidong <cyd@gnu.org>
658
1682701f
CY
659 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
660
44286096
CY
661 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
662 case (Bug#9752).
663
d86feb17
PE
6642012-06-08 Paul Eggert <eggert@cs.ucla.edu>
665
666 * xdisp.c (vmessage): Treat frame message as multibyte.
667 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
668 would generate the diagnostic "Making \302\247 buffer-local while
669 let-bound!".
670
d5c20fe8
EZ
6712012-06-08 Eli Zaretskii <eliz@gnu.org>
672
673 * dispnew.c (showing_window_margins_p): Undo last change, which
674 was done due to an inadvertent commit.
675 (adjust_frame_glyphs_for_frame_redisplay): Do call
676 showing_window_margins_p.
677
513749ee
SM
6782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
679
680 * eval.c (Fmake_var_non_special): New primitive.
681 (syms_of_eval): Defsubr it.
682 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
683
d4a8f5c1
JB
6842012-06-08 Juanma Barranquero <lekktu@gmail.com>
685
686 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
687 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
688
8bbbc977
EZ
6892012-06-08 Eli Zaretskii <eliz@gnu.org>
690
691 * alloc.c (allocate_vectorlike): Fix last change.
692
f3372c87
DA
6932012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
694
695 Block-based vector allocation of small vectors.
696 * lisp.h (struct vectorlike_header): New field `nbytes',
697 adjust comment accordingly.
698 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
699 to denote vector blocks. Adjust users (live_vector_p,
700 mark_maybe_pointer, valid_lisp_object_p) accordingly.
701 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
702 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
703 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
704 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
705 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
706 (roundup_size): New constant.
707 (struct vector_block): New data type.
708 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 709 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
710 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
711 (sweep_vectors): New functions.
712 (allocate_vectorlike): Return `zero_vector' as the only vector of
713 0 items. Allocate new vector from block if vector size is less than
714 or equal to VBLOCK_BYTES_MAX.
715 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
716 (init_alloc_once): Add call to init_vectors.
717
4f18a4ed
SM
7182012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
719
720 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
721
86f158bc
PE
7222012-06-07 Paul Eggert <eggert@cs.ucla.edu>
723
724 * doprnt.c (doprnt): Truncate multibyte char correctly.
725 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
726 would mishandle a string argument "Xc" if X was a multibyte
727 character of length 2: it would truncate after X's first byte
728 rather than including all of X.
729
c5cfcbe0
CY
7302012-06-06 Chong Yidong <cyd@gnu.org>
731
732 * buffer.c (word_wrap): Doc fix.
733
c05cf390
PE
7342012-06-04 Paul Eggert <eggert@cs.ucla.edu>
735
736 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
737
0c3461de
GM
7382012-06-03 Glenn Morris <rgm@gnu.org>
739
740 * xdisp.c (tool-bar-style): Doc fix.
741
c71232db
UM
7422012-06-03 Ulrich Müller <ulm@gentoo.org>
743
744 * Makefile.in (PAXCTL): Define.
745 (temacs$(EXEEXT)): Disable memory randomization for the temacs
746 binary via PaX flags if the paxctl utility is available.
747 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
748 Restore PaX flags to their default. (Bug#11398)
749
383f7350
CY
7502012-06-03 Chong Yidong <cyd@gnu.org>
751
752 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
753 buffer (Bug#11226).
754
5f2c76c6
CY
7552012-06-03 Chong Yidong <cyd@gnu.org>
756
757 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
758 (note_mode_line_or_margin_highlight): If there is no help echo,
759 use mode-line-default-help-echo. Handle the case where the mouse
760 position is past the end of the mode line string.
761
762 * buffer.c (buffer_local_value_1): New function, split from
763 Fbuffer_local_value; can return Qunbound.
764 (Fbuffer_local_value): Use it.
765 (Vmode_line_format): Docstring tweaks.
766
773d47f6
PE
7672012-06-02 Paul Eggert <eggert@cs.ucla.edu>
768
769 * sysdep.c (system_process_attributes): Improve comment.
770
f2d6a3df
SM
7712012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
772
773 * keyboard.c: Export real-this-command to Elisp.
774 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
775 and DEFVAR it. Update all users.
776
63810350
PE
7772012-06-02 Paul Eggert <eggert@cs.ucla.edu>
778
7bd5c1f4
PE
779 * minibuf.c (Fassoc_string): Remove duplicate declaration.
780
63810350
PE
781 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
782 Convert pctcpu and pctmem to Lisp float properly.
783 Let the compiler fold better, as 100.0/0x8000 is exact.
784
a2821611
AS
7852012-06-02 Andreas Schwab <schwab@linux-m68k.org>
786
787 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
788 cons_block.
789
5fceba1d
PE
7902012-06-01 Paul Eggert <eggert@cs.ucla.edu>
791
792 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
793
c98ff5dd
DA
7942012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
795
796 For a 'struct window', replace some Lisp_Object fields to
797 bitfields where appropriate, remove unused fields.
798 * window.h (struct window): Remove unused 'last_mark_x' and
799 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
800 change it's type from Lisp_Object to bitfield.
801 Change type of 'force_start', 'optional_new_start',
802 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
803 fields from Lisp_Object to bitfield. Adjust users accordingly.
804
ca34e0be
PE
8052012-05-31 Paul Eggert <eggert@cs.ucla.edu>
806
807 Pacify gcc -Wdouble-precision when using Xaw.
808 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
809 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
810 Use 'float' consistently, rather than 'float' in most places
811 and 'double' in a couple of places.
812
efc00ab1 8132012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
814
815 * xdisp.c (handle_stop): Detect whether we have overlay strings
816 loaded by testing it->current.overlay_string_index to be
817 non-negative, instead of checking whether n_overlay_strings is
818 positive. (Bug#11587)
819
efc00ab1 8202012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
821
822 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
823
824 * doc.c (Fsubstitute_command_keys): Doc fix.
825
efc00ab1 8262012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
827
828 * search.c (search_buffer): Remove calls to
829 r_alloc_inhibit_buffer_relocation, as it is now called by
830 maybe_unify_char, which was the cause of relocation of buffer text
831 in bug#11519.
832
efc00ab1 8332012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
834
835 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
836 for the duration of call to load_charset, to avoid problems with
837 callers of maybe_unify_char that access buffer text through C
838 pointers.
839
840 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
841 decrement the inhibition flag, instead of just setting or
842 resetting it.
843
ba93a187
PE
8442012-05-31 Paul Eggert <eggert@cs.ucla.edu>
845
846 Remove obsolete '#define static' cruft.
847 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
848 This #undef was "temporary" in 2000; it is no longer needed
849 now that '#define static' has gone away.
850 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
851 (gray_bitmap_bits): Remove; no longer needed.
852 All uses replaced with definiens.
853 * xterm.c: Include "bitmaps/gray.xbm".
854
9e4bf381
PE
8552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
856
857 Clean up __executable_start, monstartup when --enable-profiling.
858 The following changes affect the code only when profiling.
859 * dispnew.c (__executable_start): Rename from safe_bcopy.
860 Define only on platforms that need it.
861 * emacs.c: Include <sys/gmon.h> when profiling.
862 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
863 (__executable_start): Remove decl, since lisp.h does it now.
864 (safe_bcopy): Remove decl; no longer has that name.
865 (main): Coalesce #if into single bit of code, for simplicity.
866 Cast pointers to uintptr_t, since standard libraries want integers
867 and not pointers.
868 * lisp.h (__executable_start): New decl.
869
32d72c2f
GM
8702012-05-31 Glenn Morris <rgm@gnu.org>
871
872 * image.c (Fimagemagick_types): Doc fix.
873
baac5bc7
JM
8742012-05-30 Jim Meyering <meyering@redhat.com>
875
876 * callproc.c (Fcall_process_region): Include directory component
877 in mkstemp error message (Bug#11586).
878
72cb32cf
PE
8792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
880
881 * alloc.c, lisp.h (make_pure_vector): Now static.
882
61b108cc
SM
8832012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
884
885 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
886 Move to byte-run.el.
887 (Fautoload): Do the hash-doc more carefully.
888 * data.c (Fdefalias): Purify definition, except for keymaps.
889 (Qdefun): Move from eval.c.
890 * lisp.h (Qdefun): Remove.
891 * lread.c (read1): Tiny simplification.
892
471fe23d
TN
8932012-05-29 Troels Nielsen <bn.troels@gmail.com>
894
934f3f58 895 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
896 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
897 Bug#9642, but explicitly check that the buffer the overlay would
898 be moved to is live and rearrange lines to make sure that errors
899 will not put the overlay in an inconsistent state.
900 (Fdelete_overlay): Cosmetics.
901
85d0efd1
EZ
9022012-05-28 Eli Zaretskii <eliz@gnu.org>
903
904 * w32term.c (my_bring_window_to_top): New function.
905 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
906 could be different from the original one.
907 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
908 (Bug#11513)
909
910 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
911 by calling BringWindowToTop.
912
913 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
914 (WM_EMACS_END): Increase by one.
915
da92a98c
PE
9162012-05-28 Paul Eggert <eggert@cs.ucla.edu>
917
918 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
919 This avoids undefined behavior that might cause the eassert
920 to not catch an out-of-range value.
921
74d1f848
JB
9222012-05-28 Juanma Barranquero <lekktu@gmail.com>
923
924 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
925 Update dependencies.
926
9e1a06fc
EZ
9272012-05-27 Eli Zaretskii <eliz@gnu.org>
928
929 * bidi.c (bidi_mirror_char): Fix last change.
930
f3dd7312
AS
9312012-05-27 Andreas Schwab <schwab@linux-m68k.org>
932
933 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
934 when referring to sectname field in printf format.
935
81899c91
PE
9362012-05-27 Paul Eggert <eggert@cs.ucla.edu>
937
57b81a9f
PE
938 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
939 Only r_alloc_inhibit_buffer_relocation needed to be added;
940 the others were already declared.
941
81899c91
PE
942 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
943 before checking whether it's out of range. Put the check inside
944 eassert. See
945 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
946
33017faf 9472012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
948
949 * callproc.c (Fcall_process): Restore a line that was accidentally
950 commented out in the 2011-02-13 change (bug#11547).
951
33017faf 9522012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
953
954 * lisp.h [REL_ALLOC]: Add prototypes for external functions
955 defined on ralloc.c.
956
957 * buffer.c [REL_ALLOC]: Remove prototypes of
958 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
959 they are now on lisp.h.
960
961 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
962
963 * search.c (search_buffer): Use it to inhibit relocation of buffer
964 text while re_search_2 is doing its job, because re_search_2 is
965 passed C pointers to buffer text. (Bug#11519)
966
23415acf
EZ
967 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
968 Update value to 24.
969
44e27368
EZ
970 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
971 state after an additional call to move_it_in_display_line_to, keep
972 the values of it->max_ascent and it->max_descent found for the
973 entire line.
974 (pos_visible_p): Revert the comparison against bottom_y to what it
975 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
976 (Bug#11464)
977
c1892f11
PE
9782012-05-26 Paul Eggert <eggert@cs.ucla.edu>
979
980 Fix coding-related core dumps with gcc -ftrapv.
981 The code was computing A - B, where A and B are pointers, and B is
982 random garbage. This can lead to core dumps on platforms that
983 have special pointer registers, and it also leads to core dumps on
984 x86-64 when compiled with gcc -ftrapv. The fix is to compute
985 A - B only when B is initialized properly.
986 * coding.c (coding_set_source, coding_set_destination): Return void.
987 (coding_change_source, coding_change_destinations): New functions,
988 with the old behaviors of coding_set_source and coding_set_destination.
989 All callers that need an offset changed to use these new functions.
990
eb7afdad
GM
9912012-05-26 Glenn Morris <rgm@gnu.org>
992
993 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
994
f12fdf02
EZ
9952012-05-26 Eli Zaretskii <eliz@gnu.org>
996
53a63be6 997 Extend mouse support on W32 text-mode console.
61b108cc
SM
998 * xdisp.c (draw_row_with_mouse_face):
999 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1000
eb3f6f01 1001 * w32console.c: Include window.h.
61b108cc
SM
1002 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1003 New functions.
eb3f6f01
EZ
1004 (initialize_w32_display): Initialize mouse-highlight data.
1005
53a63be6
EZ
1006 * w32inevt.c: Include termchar.h and window.h.
1007 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1008 moves, call note_mouse_highlight. If help_echo changed, call
1009 gen_help_event to produce help-echo message in the echo area.
1010 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1011 highlight info.
1012
4cfd81f6
PE
10132012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 * lread.c (read1): Simplify slightly to avoid an overflow warning
1016 with GCC 4.7.0 on x86-64.
1017
4446092a
EZ
10182012-05-26 Eli Zaretskii <eliz@gnu.org>
1019
1020 * bidi.c (bidi_mirror_char): Revert last change: an int is
1021 definitely wide enough here.
1022
42b2a986 10232012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1024
42b2a986 1025 Fix integer width and related bugs (Bug#9874).
eb106a49 1026 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1027 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1028 (string_bytes, check_sblock, allocate_string_data):
1029 (compact_small_strings, Fmake_bool_vector, make_string)
1030 (make_unibyte_string, make_multibyte_string)
1031 (make_string_from_bytes, make_specified_string)
1032 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1033 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1034 (mark_vectorlike):
1035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1036 (allocate_pseudovector):
1037 Use int, not EMACS_INT, where int is wide enough.
1038 (inhibit_garbage_collection, Fgarbage_collect):
1039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1040 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1041 int might not be wide enough.
1042 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1043 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1044 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1045 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1046 (bidi_level_of_next_char, bidi_move_to_visually_next):
1047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1048 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1049 (Fkill_buffer, Fset_buffer_major_mode)
1050 (advance_to_char_boundary, Fbuffer_swap_text)
1051 (Fset_buffer_multibyte, overlays_at, overlays_in)
1052 (overlay_touches_p, struct sortvec, record_overlay_string)
1053 (overlay_strings, recenter_overlay_lists)
1054 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1055 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1056 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1057 (Foverlay_recenter, last_overlay_modification_hooks_used)
1058 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1060 (validate_region): Omit unnecessary test for b <= e,
1061 since that's guaranteed by the previous test.
d311d28c
PE
1062 (adjust_overlays_for_delete): Avoid pos + length overflow.
1063 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1064 (report_overlay_modification):
1065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1066 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1067 Omit pointer cast, which isn't needed anyway, and doesn't work
1068 after the EMACS_INT -> ptrdiff_t change.
02481186 1069 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1070 * buffer.h: Adjust decls to match defn changes elsewhere.
1071 (struct buffer_text, struct buffer):
1072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1073 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1074 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1075 not int, to avoid needless 32-bit limit on 64-bit hosts.
1076 (exec_byte_code): Use tighter memory-full test, one that checks
1077 for alloca overflow. Don't compute the address of the object just
1078 before an array, as that's not portable. Use EMACS_INT, not
1079 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1080 * callint.c (Fcall_interactively):
1081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1082 * callproc.c (call_process_kill, Fcall_process):
1083 Don't assume pid_t fits into an Emacs fixnum.
1084 (call_process_cleanup, Fcall_process, child_setup):
1085 Don't assume pid_t fits into int.
1086 (call_process_cleanup, Fcall_process, delete_temp_file)
1087 (Fcall_process_region):
1088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1089 (Fcall_process): Simplify handling of volatile integers.
1090 Use int, not EMACS_INT, where int will do.
1091 * casefiddle.c (casify_object, casify_region, operate_on_word)
1092 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1094 (casify_object): Avoid integer overflow when overallocating buffer.
1095 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1096 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1097 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1098 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1099 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1100 integers are now checked earlier. All uses replaced with XINT.
1101 (ccl_driver):
1102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1103 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1104 (ccl_driver, Fregister_code_conversion_map):
1105 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1106 (resolve_symbol_ccl_program): Check that vector header is in range.
1107 Always copy the vector, so that we can check its contents reliably
1108 now rather than having to recheck each instruction as it's being
1109 executed. Check that vector words fit in 'int'.
1110 (ccl_get_compiled_code, Fregister_ccl_program)
1111 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1112 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1113 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1114 contents are in range.
1115 (Fccl_execute_on_string): Check that status is in range.
1116 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1117 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1118 Accept and return EMACS_INT, not int, because callers can pass values
1119 out of 'int' range.
1120 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1121 (multibyte_chars_in_text, parse_str_as_multibyte)
1122 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1123 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1124 (string_escape_byte8, Fget_byte):
1125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1126 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1127 avoid mishandling large integers.
1128 * character.h: Adjust decls to match defn changes elsewhere.
1129 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1130 (Ffind_charset_region):
1131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1132 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1133 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1134 Don't assume fixnum fits in int.
d311d28c
PE
1135 (load_charset_map_from_vector, Fmap_charset_chars):
1136 Remove now-unnecessary CHECK_NATNUMs.
1137 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1138 Don't rely on undefined behavior with signed left shift overflow.
1139 Don't assume unsigned int fits into fixnum, or that fixnum fits
1140 into unsigned int. Don't require max_code to be a valid fixnum;
1141 that's not true for gb10830 4-byte on a 32-bit host. Allow
1142 invalid_code to be a cons, for the same reason. Require code_offset
1143 to be a character. Avoid int overflow if max_char is close
1144 to INT_MAX.
1145 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1146 this is intended anyway and avoids some undefined behavior.
1147 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1148 INDEX_TO_CODE_POINT, as that's what it expects.
1149 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1150 * charset.h (DECODE_CHAR): Return int, not unsigned;
1151 this is what was intended anyway, and it avoids undefined behavior.
1152 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1153 integer-overflow issues.
1154 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1155 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1156 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1157 * chartab.c (Fmake_char_table, Fset_char_table_range)
1158 (uniprop_get_decoder, uniprop_get_encoder):
1159 Don't assume fixnum fits in int.
1160 * cmds.c (move_point): New function, that does the gist of
1161 Fforward_char and Fbackward_char, but does so while checking
1162 for integer overflow more accurately.
c96e5d6a 1163 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1164 (Fforward_line, Fend_of_line, internal_self_insert)
1165 (internal_self_insert):
1166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1167 Fix a FIXME, by checking for integer overflow when calculating
1168 target_clm and actual_clm.
1169 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1170 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1171 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1172 (coding_alloc_by_making_gap, alloc_destination)
1173 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1174 (encode_coding_utf_16, detect_coding_emacs_mule)
1175 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1176 (detect_coding_iso_2022, decode_coding_iso_2022)
1177 (encode_invocation_designation, encode_designation_at_bol)
1178 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1179 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1180 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1181 (encode_coding_ccl, encode_coding_raw_text)
1182 (detect_coding_charset, decode_coding_charset)
1183 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1184 (produce_composition, produce_charset, produce_annotation)
1185 (decode_coding, handle_composition_annotation)
1186 (handle_charset_annotation, consume_chars, decode_coding_gap)
1187 (decode_coding_object, encode_coding_object, detect_coding_system)
1188 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1189 (code_convert_region, code_convert_string)
8f50130c
PE
1190 (Fdefine_coding_system_internal)
1191 (coding_set_source, coding_set_destination):
d311d28c
PE
1192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1193 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1194 (Fdefine_coding_system_internal):
1195 Don't assume fixnums fit in int.
1196 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1197 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1198 (Funencodable_char_position, Fcheck_coding_systems_region)
1199 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1201 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1202 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1203 Don't access memory outside of the args array.
d311d28c 1204 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1205 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1206 result of ENCODE_CHAR.
d311d28c
PE
1207 * coding.h: Adjust decls to match defn changes elsewhere.
1208 (struct coding_system):
1209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1210 * composite.c (get_composition_id, find_composition)
1211 (run_composition_function, update_compositions)
1212 (compose_text, composition_gstring_put_cache)
1213 (composition_gstring_p, composition_gstring_width)
1214 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1215 (composition_compute_stop_pos, composition_reseat_it)
1216 (composition_update_it, struct position_record)
1217 (find_automatic_composition, composition_adjust_point)
1218 (Fcomposition_get_gstring, Ffind_composition_internal):
1219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1220 (update_compositions):
1221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1222 * composite.h: Adjust decls to match defn changes elsewhere.
1223 (struct composition):
1224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1225 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1226 Do not attempt to compute the address of the object just before a
1227 buffer; this is not portable.
1228 (Faref, Faset):
1229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1230 (Faset): Use int, not EMACS_INT, where int is wide enough.
1231 (Fstring_to_number): Don't assume fixnums fit in int.
1232 (Frem): Don't assume arg is nonnegative.
1233 * dbusbind.c (xd_append_arg): Check for integers out of range.
1234 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1235 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1236 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1237 (xd_get_connection_references): Return ptrdiff_t, not int.
1238 All uses changed.
1239 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1240 (xd_read_message_1):
1241 Use int, not unsigned, where the dbus API uses int.
1242 (Fdbus_message_internal): Don't overflow mtype.
1243 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1244 * dired.c (directory_files_internal, file_name_completion, scmp)
1245 (file_name_completion_stat):
1246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1247 (file_name_completion): Don't overflow matchcount.
1248 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1249 * dispextern.h: Adjust decls to match defn changes elsewhere.
1250 (struct text_pos, struct glyph, struct bidi_saved_info)
1251 (struct bidi_string_data, struct bidi_it, struct composition_it)
1252 (struct it):
1253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1254 (struct display_pos, struct composition_it, struct it):
1255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1256 * dispnew.c (increment_matrix_positions)
1257 (increment_row_positions, mode_line_string)
1258 (marginal_area_string):
1259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1260 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1262 (duration_to_sec_usec): New function, to check for overflow better.
1263 (Fsleep_for, sit_for): Use it.
1264 * doc.c (get_doc_string, store_function_docstring):
1265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1266 (get_doc_string, Fsnarf_documentation):
1267 Use int, not EMACS_INT, where int is wide enough.
1268 (get_doc_string):
1269 Use SAFE_ALLOCA, not alloca.
1270 Check for overflow when converting EMACS_INT to off_t.
1271 * doprnt.c (doprnt):
1272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1273 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1274 Don't assume uid_t fits into fixnum.
1275 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1276 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1277 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1278 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1279 (general_insert_function)
1280 (Finsert_char, make_buffer_string, make_buffer_string_both)
1281 (update_buffer_properties, Fbuffer_substring)
1282 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1283 (Fsubst_char_in_region, check_translation)
1284 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1285 (transpose_markers, Ftranspose_regions):
1286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1287 (clip_to_bounds): Move to lisp.h as an inline function).
1288 (Fconstrain_to_field): Don't assume integers are nonnegative.
1289 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1290 (Fsubst_char_in_region, Fsave_restriction):
1291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1292 (Femacs_pid): Don't assume pid_t fits into fixnum.
1293 (lo_time): Use int, not EMACS_INT, when int suffices.
1294 (lisp_time_argument): Check for usec out of range.
1295 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1296 (Fuser_login_name, Fuser_full_name): Signal an error
1297 if a uid argument is out of range, rather than relying on
1298 undefined behavior.
c8d5c857
PE
1299 (Fformat_time_string): Remove now-unnecessary check.
1300 lisp_time_argument checks for out-of-range usec now.
243e0530 1301 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1302 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1303 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1304 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1305 (init_cmdargs, Fdump_emacs):
1306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1307 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1308 the bottom (typically) 32 bits of the fixnum.
1309 * eval.c (specpdl_size, call_debugger):
1310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1311 (when_entered_debugger, Fbacktrace_debug):
1312 Don't assume fixnum can fit in int.
1313 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1314 the object just before a buffer; this is not portable.
1315 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1316 (grow_specpdl, unbind_to):
1317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1318 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1319 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1320 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1321 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1322 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1324 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1325 (a_write, e_write):
1326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1327 (Fcopy_file, non_regular_nbytes, read_non_regular)
1328 (Finsert_file_contents):
1329 Use int, not EMACS_INT, where int is wide enough.
1330 (READ_BUF_SIZE): Verify that it fits in int.
1331 (Finsert_file_contents): Check that counts are in proper range,
1332 rather than assuming fixnums fit into ptrdiff_t etc.
1333 Don't assume fixnums fit into int.
125b3835 1334 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1335 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1336 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1337 (string_char_to_byte, string_byte_to_char)
1338 (string_make_multibyte, string_to_multibyte)
1339 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1340 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1341 (substring_both, Fdelete, internal_equal, Ffillarray)
1342 (Fclear_string, mapcar1)
1343 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1344 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1345 (larger_vector, make_hash_table, maybe_resize_hash_table)
1346 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1347 (Fmaphash, secure_hash):
1348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1349 (concat): Check for string index and length overflow.
1350 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1351 (Frequire):
1352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1353 (larger_vector): New API (vec, incr_min, size_max) replaces old
1354 one (vec, new_size, init). This catches size overflow.
1355 INIT was removed because it was always Qnil.
1356 All callers changed.
1357 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1358 the upper bound on a hash table index size.
1359 (make_hash_table, maybe_resize_hash_table): Use it.
1360 (secure_hash): Computer start_byte and end_byte only after
1361 they're known to be in ptrdiff_t range.
1362 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1363 (Ffont_get_glyphs, Ffont_at):
1364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1365 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1366 (Flist_fonts, Fopen_font):
1367 Don't assume fixnum can fit in int.
1368 (check_gstring): Don't assume index can fit in int.
1369 (font_match_p): Check that fixnum is a character, not a nonnegative
1370 fixnum, since the later code needs to stuff it into an int.
1371 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1372 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1373 conversion overflow issues.
1374 (Fopen_font): Check for integer out of range.
1375 (Ffont_get_glyphs): Don't assume index can fit in int.
1376 * font.h: Adjust decls to match defn changes elsewhere.
1377 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1378 integer overflow.
1379 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1380 printmax_t, where ptrdiff_t is wide enough.
1381 (Finternal_char_font):
1382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1383 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1384 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1385 (Fset_frame_position, x_set_frame_parameters)
1386 (x_set_line_spacing, x_set_border_width)
1387 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1388 Check that fixnums are in proper range for system types.
1389 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1391 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1392 Use SAFE_ALLOCA_LISP, not alloca.
1393 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1394 intptr_t is wide enough.
1395 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1396 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1397 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1398 Check for fixnum out of range.
1399 * ftfont.c (ftfont_list): Don't assume index fits in int.
1400 Check that fixnums are in proper range for system types.
1401 (ftfont_shape_by_flt):
1402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1403 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1405 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1406 Check that fixnums are in proper range for system types.
1407 * gnutls.h: Adjust decls to match defn changes elsewhere.
1408 * gtkutil.c (xg_dialog_run):
1409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1410 (update_frame_tool_bar):
1411 Check that fixnums are in proper range for system types.
1412 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1413 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1414 * indent.c (last_known_column, last_known_column_point):
1415 (current_column_bol_cache):
1416 (skip_invisible, current_column, check_display_width):
1417 (check_display_width, scan_for_column, current_column_1)
1418 (Findent_to, Fcurrent_indentation, position_indentation)
1419 (indented_beyond_p, Fmove_to_column, compute_motion):
1420 (Fcompute_motion, Fvertical_motion):
1421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1422 (last_known_column_modified): Use EMACS_INT, not int.
1423 (check_display_width):
1424 (Fcompute_motion):
1425 Check that fixnums and floats are in proper range for system types.
1426 (compute_motion): Don't assume index or fixnum fits in int.
1427 (compute_motion, Fcompute_motion):
1428 Use int, not EMACS_INT, when it is wide enough.
1429 (vmotion): Omit local var start_hpos that is always 0; that way
1430 we don't need to worry about overflow in expressions involving it.
1431 * indent.h: Adjust decls to match defn changes elsewhere.
1432 (struct position):
1433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1434 Use int, not EMACS_INT, where int is wide enough.
1435 Remove unused members ovstring_chars_done and tab_offset;
1436 all uses removed.
1437 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1438 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1439 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1440 (make_gap, copy_text, insert, insert_and_inherit)
1441 (insert_before_markers, insert_before_markers_and_inherit)
1442 (insert_1, count_combining_before, count_combining_after)
1443 (insert_1_both, insert_from_string)
1444 (insert_from_string_before_markers, insert_from_string_1)
1445 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1446 (adjust_after_replace, adjust_after_insert, replace_range)
1447 (replace_range_2, del_range, del_range_1, del_range_byte)
1448 (del_range_both, del_range_2, modify_region)
1449 (prepare_to_modify_buffer, signal_before_change)
1450 (signal_after_change, Fcombine_after_change_execute):
1451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1452 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1453 (balance_an_interval, split_interval_right, split_interval_left)
1454 (find_interval, next_interval, update_interval)
1455 (adjust_intervals_for_insertion, delete_node, delete_interval)
1456 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1457 (static_offset_intervals, offset_intervals)
1458 (merge_interval_right, merge_interval_left, make_new_interval)
1459 (graft_intervals_into_buffer, temp_set_point_both)
1460 (temp_set_point, set_point, adjust_for_invis_intang)
1461 (set_point_both, move_if_not_intangible, get_property_and_range)
1462 (get_local_map, copy_intervals, copy_intervals_to_string)
1463 (compare_string_intervals, set_intervals_multibyte_1):
1464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1465 * intervals.h: Adjust decls to match defn changes elsewhere.
1466 (struct interval):
1467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1468 * keyboard.c (this_command_key_count, this_single_command_key_start)
1469 (before_command_key_count, before_command_echo_length, echo_now)
1470 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1471 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1472 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1473 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1475 (last_non_minibuf_size, last_point_position, echo_truncate)
1476 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1477 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1478 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1479 (stuff_buffered_input):
1480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1481 (last_auto_save, command_loop_1, read_char):
1482 Use EMACS_INT, not int, to avoid integer overflow.
1483 (record_char): Avoid overflow in total_keys computation.
1484 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1485 * keyboard.h: Adjust decls to match defn changes elsewhere.
1486 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1487 (Fkey_description, Fdescribe_vector, Flookup_key):
1488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1489 (click_position): New function, to check that positions are in range.
1490 (Fcurrent_active_maps):
1491 (describe_command):
1492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1493 (Faccessible_keymaps, Fkey_description):
1494 (preferred_sequence_p):
1495 Don't assume fixnum can fit into int.
1496 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1497 Check for integer overflow in size calculations.
1498 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1499 avoid mishandling large integers.
1500 * lisp.h: Adjust decls to match defn changes elsewhere.
1501 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1502 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1503 (struct Lisp_Marker):
1504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1505 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1506 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1507 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1508 All callers changed.
1509 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1510 Assume the arg has valid form, since it always does.
1511 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1512 unsigned integer system type.
1513 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1514 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1516 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1517 (duration_to_sec_usec): New decl.
1518 * lread.c (read_from_string_index, read_from_string_index_byte)
1519 (read_from_string_limit, readchar, unreadchar, openp)
1520 (read_internal_start, read1, oblookup):
1521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1522 (Fload, readevalloop, Feval_buffer, Feval_region):
1523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1524 (openp): Check for out-of-range argument to 'access'.
1525 (read1): Use int, not EMACS_INT, where int is wide enough.
1526 Don't assume fixnum fits into int.
6efdadfd 1527 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1528 (read_filtered_event): Use duration_to_sec_usec
1529 to do proper overflow checking on durations.
d311d28c
PE
1530 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1531 in size calculation.
1532 (Fexecute_kbd_macro):
1533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1534 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1535 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1536 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1537 (set_marker_both, set_marker_restricted_both, marker_position)
1538 (marker_byte_position, Fbuffer_has_markers_at):
1539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1540 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1541 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1542 It now merely ensures that the menu is large enough, without
1543 necessarily growing it, as this avoids some integer overflow issues.
1544 All callers changed.
1545 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1547 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1548 Use SAFE_ALLOCA_LISP, not alloca.
1549 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1550 to EMACS_INT. Check that fixnums are in proper range for system types.
1551 * minibuf.c (minibuf_prompt_width, string_to_object)
1552 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1553 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1555 (get_minibuffer, read_minibuf_unwind):
1556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1557 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1558 this simplifies overflow checking. All callers changed.
1559 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1560 (Ftest_completion):
1561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1562 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1563 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1564 Check that fixnums are in proper range for system types.
1565 (Fx_create_frame, Fx_show_tip):
1566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1567 * nsfont.m (ns_findfonts, nsfont_list_family):
1568 Don't assume fixnum fits in long.
1569 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1571 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1572 wide enough.
17fdb222 1573 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1575 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1576 (PRINTDECLARE, PRINTPREPARE):
1577 (strout, print_string):
1578 (print, print_preprocess, print_check_string_charset_prop)
1579 (print_object):
1580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1581 (PRINTDECLARE):
1582 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1584 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1585 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1586 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1587 (print_error_message): Use SAFE_ALLOCA, not alloca.
1588 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1589 (print_depth, new_backquote_output, print_number_index):
1590 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1591 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1592 (Fset_process_window_size, Fformat_network_address)
1593 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1594 (sigchld_handler):
d311d28c 1595 Check that fixnums are in proper range for system types.
d44287d4 1596 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1597 Check for process-ids out of pid_t range rather than relying on
1598 undefined behavior.
e4d81efc 1599 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1600 (Fformat_network_address, read_process_output, send_process)
1601 (Fprocess_send_region, status_notify):
1602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1603 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1604 (wait_reading_process_output, read_process_output, exec_sentinel):
1605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1606 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1607 (Faccept_process_output): Use duration_to_sec_usec to do proper
1608 overflow checking on durations.
dde14581
PE
1609 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1610 Don't assume pid_t fits in int.
02481186
PE
1611 * process.h (struct Lisp_Process): Members tick and update_tick
1612 are now of type EMACS_INT, not int.
b62b53e8
PE
1613 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1614 configured --with-wide-int.
d311d28c
PE
1615 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1616 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1617 * search.c (looking_at_1, string_match_1):
1618 (fast_string_match, fast_c_string_match_ignore_case)
1619 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1620 (scan_newline, find_before_next_newline, search_command)
1621 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1622 (set_search_regs, wordify):
1623 (Freplace_match):
1624 (Fmatch_data):
1625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1626 (string_match_1, search_buffer, set_search_regs):
1627 (Fmatch_data):
1628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1629 (wordify): Check for overflow in size calculation.
1630 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1631 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1632 Check that fixnums are in proper range for system types.
1633 * sound.c (struct sound_device)
1634 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1636 (Fplay_sound_internal):
1637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1638 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1639 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1640 (Fparse_partial_sexp):
1641 Don't assume fixnums can fit in int.
1642 (struct lisp_parse_state, find_start_pos, find_start_value)
1643 (find_start_value_byte, find_start_begv)
1644 (update_syntax_table, char_quoted, dec_bytepos)
1645 (find_defun_start, prev_char_comend_first, back_comment):
1646 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1647 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1649 (Finternal_describe_syntax_value): Check that match_lisp is a
1650 character, not an integer, since the code stuffs it into int.
1651 (scan_words, scan_sexps_forward):
1652 Check that fixnums are in proper range for system types.
1653 (Fforward_word):
1654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1655 (scan_sexps_forward):
1656 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1657 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1658 * syntax.h: Adjust decls to match defn changes elsewhere.
1659 (struct gl_state_s):
1660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1661 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1662 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1663 * sysdep.c (wait_for_termination_1, wait_for_termination)
1664 (interruptible_wait_for_termination, mkdir):
1665 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1666 (emacs_read, emacs_write):
1667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1668 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1669 and double all fit in int.
d311d28c
PE
1670 * term.c (set_tty_color_mode):
1671 Check that fixnums are in proper range for system types.
1672 * termhooks.h (struct input_event):
1673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1674 * textprop.c (validate_interval_range, interval_of)
1675 (Fadd_text_properties, set_text_properties_1)
1676 (Fremove_text_properties, Fremove_list_of_text_properties)
1677 (Ftext_property_any, Ftext_property_not_all)
1678 (copy_text_properties, text_property_list, extend_property_ranges)
1679 (verify_interval_modification):
1680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1681 (Fnext_single_char_property_change)
1682 (Fprevious_single_char_property_change):
1683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1684 (copy_text_properties):
1685 Check for integer overflow in index calculation.
d311d28c
PE
1686 * undo.c (last_boundary_position, record_point, record_insert)
1687 (record_delete, record_marker_adjustment, record_change)
1688 (record_property_change):
1689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1690 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1692 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1693 (Fx_hide_tip, Fx_file_dialog):
1694 * w32menu.c (set_frame_menubar):
1695 Use ptrdiff_t, not int, for consistency with rest of code.
1696 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1697 (select_window, Fdelete_other_windows_internal)
1698 (window_scroll_pixel_based, window_scroll_line_based)
1699 (Frecenter, Fset_window_configuration):
1700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1701 (Fset_window_hscroll, run_window_configuration_change_hook)
1702 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1703 (Fscroll_other_window, Frecenter):
d311d28c
PE
1704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1705 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1706 Don't assume fixnum fits in int.
1707 (Fset_window_scroll_bars):
1708 Check that fixnums are in proper range for system types.
1709 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1710 (string_pos, c_string_pos, number_of_chars, init_iterator)
1711 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1712 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1713 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1714 (face_before_or_after_it_pos, handle_invisible_prop)
1715 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1716 (display_prop_intangible_p, string_buffer_position_lim)
1717 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1718 (get_overlay_strings_1, get_overlay_strings)
1719 (iterate_out_of_display_property, forward_to_next_line_start)
1720 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1721 (get_next_display_element, set_iterator_to_next)
1722 (get_visually_first_element, compute_stop_pos_backwards)
1723 (handle_stop_backwards, next_element_from_buffer)
1724 (move_it_in_display_line_to, move_it_in_display_line)
1725 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1726 (add_to_log, message_dolog, message_log_check_duplicate)
1727 (message2, message2_nolog, message3, message3_nolog
1728 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1729 (current_message_1, truncate_echo_area, truncate_message_1)
1730 (set_message, set_message_1, store_mode_line_noprop)
1731 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1732 (text_outside_line_unchanged_p, check_point_in_composition)
1733 (reconsider_clip_changes)
1734 (redisplay_internal, set_cursor_from_row, try_scrolling)
1735 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1736 (redisplay_window, find_last_unchanged_at_beg_row)
1737 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1738 (trailing_whitespace_p, find_row_edges, display_line)
1739 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1740 (display_mode_element, store_mode_line_string)
1741 (pint2str, pint2hrstr, decode_mode_spec)
1742 (display_count_lines, display_string, draw_glyphs)
1743 (x_produce_glyphs, x_insert_glyphs)
1744 (rows_from_pos_range, mouse_face_from_buffer_pos)
1745 (fast_find_string_pos, mouse_face_from_string_pos)
1746 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1748 (safe_call, init_from_display_pos, handle_fontified_prop)
1749 (handle_single_display_spec, load_overlay_strings)
1750 (with_echo_area_buffer, setup_echo_area_for_printing)
1751 (display_echo_area, echo_area_display)
1752 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1753 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1754 (redisplay_window, dump_glyph_row, display_mode_line)
1755 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1756 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1758 (handle_single_display_spec, build_desired_tool_bar_string)
1759 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1760 (get_specified_cursor_type):
1761 Check that fixnums are in proper range for system types.
1762 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1763 (Flookup_image_map):
1764 Don't assume fixnums fit in int.
1765 (compare_overlay_entries):
1766 Avoid mishandling comparisons due to subtraction overflow.
1767 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1768 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1769 (handle_tool_bar_click):
1770 Use int, not unsigned, since we prefer signed and the signedness
1771 doesn't matter here.
1772 (get_next_display_element, next_element_from_display_vector):
1773 Use int, not EMACS_INT, when int is wide enough.
1774 (start_hourglass): Use duration_to_sec_usec to do proper
1775 overflow checking on durations.
1776 * xfaces.c (Fbitmap_spec_p):
1777 Check that fixnums are in proper range for system types.
1778 (compare_fonts_by_sort_order):
1779 Avoid mishandling comparisons due to subtraction overflow.
1780 (Fx_family_fonts, realize_basic_faces):
1781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1782 (Fx_family_fonts):
1783 Don't assume fixnum fits in int.
1784 Use SAFE_ALLOCA_LISP, not alloca.
1785 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1786 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1787 (face_at_buffer_position, face_for_overlay_string)
1788 (face_at_string_position):
1789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1790 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1791 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1792 (Fx_show_tip):
1793 Check that fixnums are in proper range for system types.
1794 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1795 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1797 (Fx_change_window_property): Don't assume fixnums fit in int.
1798 * xfont.c (xfont_chars_supported):
1799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1800 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1801 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1803 * xml.c (parse_region):
1804 * xrdb.c (magic_file_p):
1805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1806 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1807 (x_get_local_selection, x_reply_selection_request)
1808 (x_handle_selection_request, wait_for_property_change):
1809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1810 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1811 short is wide enough.
1812 (x_send_client_event): Don't assume fixnum fits in int.
1813 * xterm.c (x_x_to_emacs_modifiers):
1814 Don't assume EMACS_INT overflows nicely into int.
1815 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1816 may come from Lisp.
1817 (handle_one_xevent): NATNUMP can eval its arg twice.
1818 (x_connection_closed):
1819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1820 * xterm.h: Adjust decls to match defn changes elsewhere.
1821 (struct scroll_bar): Use struct vectorlike_header
1822 rather than rolling our own approximation.
1823 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1824
c6574eb5
GM
18252012-05-25 Glenn Morris <rgm@gnu.org>
1826
1827 * lisp.mk (lisp): Update for more files being compiled now.
1828
e8d32c7e
SM
18292012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1830
48def666
SM
1831 * lread.c: Remove `read_pure' which makes no difference.
1832 (read_pure): Remove var.
1833 (unreadpure): Remove function.
1834 (readevalloop): Don't call read_list with -1 flag.
1835 (read1, read_vector): Don't test read_pure any more.
1836 (read_list): Simplify.
1837
e8d32c7e
SM
1838 * fileio.c, character.h: Minor style tweaks.
1839
4b2addb7
DA
18402012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1841
1842 * window.h (clip_changed): Remove useless declaration.
1843
584461b2
JB
18442012-05-22 Juanma Barranquero <lekktu@gmail.com>
1845
1846 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1847 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1848
34374650
PE
18492012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1850
1851 Remove src/m/*.
1852 This directory predates autoconf and is no longer needed nowadays.
1853 Move its few remaining bits of functionality to where they're needed.
1854 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1855 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1856 * m/template.h: Remove.
1857 * Makefile.in (M_FILE): Remove. All uses removed.
1858 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1859 * lisp.h (USE_LSB_TAG):
1860 * mem-limits.h (EXCEEDS_LISP_PTR):
1861 Use VAL_MAX, not VALBITS, in #if.
1862 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1863 (EMACS_UINT): Define unconditionally now.
1864 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1865 (BITS_PER_EMACS_INT): New constants, replacing
1866 what used to be in config.h, but not useful in #if.
1867 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1868 define them any more.
1869 (VAL_MAX): New macro.
1870 (VALMASK): Use it.
1871 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1872 BITS_PER_EMACS_INT, in #if.
1873 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1874 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1875 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1876 * s/ms-w32.h (DATA_START):
1877 Move here from removed file m/intel386.h.
1878 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1879 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1880
261cb4bb
PE
18812012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 Assume C89 or later.
1884 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1885 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1886 (xrealloc):
1887 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1888 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1889 * textprop.c, tparam.c (NULL): Remove.
1890 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1891 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1892 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1893 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1894 * xterm.c (input_signal_count): Assume volatile works.
1895
ff23cd9f
KB
18962012-05-21 Ken Brown <kbrown@cornell.edu>
1897
1898 * xgselect.c (xg_select): Fix first argument in call to 'select'
1899 (bug#11508).
1900
1b170bc6
KB
19012012-05-20 Ken Brown <kbrown@cornell.edu>
1902
1903 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1904 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1905
b2f4d39f
KB
19062012-05-19 Ken Brown <kbrown@cornell.edu>
1907
1908 * xfns.c (x_in_use): Remove `static' qualifier.
1909 * xterm.h (x_in_use): Declare.
1910 * xgselect.c: Include xterm.h.
1911 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1912 and `display_arg' (bug#9754).
1913
003fdae2
PE
19142012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1915
9232a6d9
PE
1916 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1917
003fdae2
PE
1918 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1919 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1920
784b56e2
EZ
19212012-05-18 Eli Zaretskii <eliz@gnu.org>
1922
1923 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1924
1925 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1926 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1927
1928 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1929 reference to image_cache->refcount.
1930 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1931
a0a79cde
JL
19322012-05-17 Juri Linkov <juri@jurta.org>
1933
1934 * search.c (Fword_search_regexp, Fword_search_backward)
1935 (Fword_search_forward, Fword_search_backward_lax)
1936 (Fword_search_forward_lax): Move functions to isearch.el
1937 (bug#10145, bug#11381).
1938
b0572523
PE
19392012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1940
1941 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1942
9660f5fc
SM
19432012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1944
1945 * lread.c (init_obarray): Declare Qt and Qnil as special.
1946
4374de83
GM
19472012-05-14 Glenn Morris <rgm@gnu.org>
1948
1949 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1950 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1951
dc44c39a
PE
19522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1953
078c97cb
PE
1954 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1955
dc44c39a
PE
1956 * unexaix.c: Port to more-recent AIX compilers.
1957 (report_error, report_error_1, make_hdr, copy_sym)
1958 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1959 Make arguments const char *, not char *, to avoid violations of C
1960 standard and to fix some AIX warnings reported by Gilles Pion.
1961
e18afed7 19622012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1963
1964 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1965 already have overlays loaded.
1966 (handle_single_display_spec): Before returning without displaying
1967 fringe bitmap, synchronize the bidi iterator with the main display
1968 iterator, by calling iterate_out_of_display_property.
1969 (iterate_out_of_display_property): Detect buffer iteration by
1970 testing that it->string is a Lisp string.
1971 (get_next_display_element): When the current object is exhausted,
1972 and there's something on it->stack, call set_iterator_to_next to
1973 proceed with what's on the stack, instead of returning zero.
1974 (set_iterator_to_next): If called at the end of a Lisp string,
1975 proceed to consider_string_end without incrementing string
1976 position. Don't increment display vector index past the end of
1977 the display vector. (Bug#11417)
c8fb9dc6
EZ
1978 (pos_visible_p): Don't report a position visible when move_it_to
1979 stopped at the last line of window, which happens to be scanned
1980 backwards by the bidi iteration. (Bug#11464)
ac268e67 1981
e18afed7 19822012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1983
1984 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1985 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1986 are on a TTY, and thus unable to display on the fringes.
1987 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1988 so we need to signal to the caller that this is a "replacing"
1989 display spec. This fixes display when the spec is invalid or we
1990 are on a TTY.
1991
e18afed7 19922012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1993
1994 * unexaix.c (make_hdr): Fix typo in prototype.
1995 This bug broke the build on AIX. Problem reported by Gilles Pion.
1996
9d0a235a
MA
19972012-05-14 Michael Albinus <michael.albinus@gmx.de>
1998
1999 * keyboard.c (kbd_buffer_get_event): Read special events also in
2000 batch mode. (Bug#11415)
2001
9e6b06ed
GM
20022012-05-12 Glenn Morris <rgm@gnu.org>
2003
2004 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2005
c1a1d7a3
EZ
20062012-05-12 Eli Zaretskii <eliz@gnu.org>
2007
2008 * lisp.mk (lisp): Add newcomment.elc.
2009
3fe7cdc8
GM
20102012-05-12 Glenn Morris <rgm@gnu.org>
2011
2012 * Makefile.in (MKDIR_P): New, set by configure.
2013 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2014
53f7d2c0
PE
20152012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2016
2017 Remove unused function hourglass_started.
2018 * dispextern.h (hourglass_started):
2019 * w32fns.c (hourglass_started):
2020 * xdisp.c (hourglass_started): Remove.
2021
75aafb17
JB
20222012-05-10 Juanma Barranquero <lekktu@gmail.com>
2023
2024 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2025 Update dependencies.
2026
12959e8e
PE
20272012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2028
97107e2e
PE
2029 * xgselect.c (xg_select): Put maxfds+1 into a var.
2030 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2031
12959e8e
PE
2032 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2033
836d29b3
DA
20342012-05-10 Dave Abrahams <dave@boostpro.com>
2035
2036 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2037 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2038
5cb67954
MA
20392012-05-09 Michael Albinus <michael.albinus@gmx.de>
2040
2041 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2042 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2043 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2044 Initialize xd_registered_buses.
2045
3478ec45
PE
20462012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2047
b263a6b0
PE
2048 Untag more efficiently if USE_LSB_TAG.
2049 This is based on a proposal by YAMAMOTO Mitsuharu in
2050 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2051 For an admittedly artificial (nth 8000 longlist) benchmark on
2052 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2053 Emacs's overall text size by 1%.
2054 * lisp.h (XUNTAG): New macro.
2055 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2056 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2057 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2058 * eval.c (Fautoload):
2059 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2060 * frame.h (XFRAME): Use XUNTAG.
2061
3478ec45
PE
2062 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2063 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2064 Remove unportable assumptions about print widths of types like
2065 dbus_uint32_t.
2066 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2067 intptr_t when converting between pointer and integer, to avoid GCC
2068 warnings about wrong width.
2069
666b903b 20702012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2071
2072 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2073 stack for each reader_thread, instead of defaulting to 8MB
2074 determined by the linker. This avoids failures in creating
2075 subprocesses on Windows 7, see the discussion in this thread:
2076 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2077
b120cc17
JC
20782012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2079
2080 Fix up display of the *Minibuf-0* buffer in the mini window.
2081 * keyboard.c (read_char): Don't clear the echo area if there's no
2082 message to clear.
2083 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2084 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2085
9a4b36f8
MA
20862012-05-07 Michael Albinus <michael.albinus@gmx.de>
2087
2088 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2089 batch mode.
2090
e5f9458f
CY
20912012-05-06 Chong Yidong <cyd@gnu.org>
2092
2093 * lisp.mk (lisp): Update.
2094
eceeb5fc 20952012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2096
2097 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2098
71873e2b
SM
20992012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2100
2101 * data.c (PUT_ERROR): New macro.
2102 (syms_of_data): Use it. Add new error type `user-error'.
2103 * undo.c (user_error): New function.
2104 (Fprimitive_undo): Use it.
2105 * print.c (print_error_message): Adjust print style for `user-error'.
2106 * keyboard.c (user_error): New function.
2107 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2108
ab0fa4e4
PE
21092012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 Do not limit current-time-string to years 1000..9999.
2112 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2113 (Fcurrent_time_string): Support any year that is supported by the
2114 underlying localtime representation. Don't use asctime, as it
2115 has undefined behavior for years outside the range -999..9999.
2116
7ed806a7
PE
21172012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 Fix race conditions involving setenv, gmtime, localtime, asctime.
2120 Without this fix, interrupts could mess up code that uses these
2121 nonreentrant functions, since setting TZ invalidates existing
2122 tm_zone or tzname values, and since most of these functions return
2123 pointers to static storage.
2124 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2125 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2126 Grow the critical sections to include not just invoking
2127 localtime/gmtime, but also accessing these functions' results
2128 including their tm_zone values if any, and any related TZ setting.
2129 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2130 so that the struct tm is saved in the critical section.
2131 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2132 motivated by the fact that memory allocation needs to be outside
2133 the critical section.
2134
0c16dfed
DA
21352012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2136
2137 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2138 with RESET_INTERVAL.
2139
2140 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2141 Remove duplicated buffer name initialization.
2142
3f83ace8
JM
21432012-05-02 Jim Meyering <jim@meyering.net>
2144
2145 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2146
c7b8541e
JM
2147 * xfns.c (x_window): Use xstrdup (Bug#11375).
2148
90207a15 21492012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2150
2151 * xdisp.c (pos_visible_p): If already at a newline from the
2152 display string before the 'while' loop, don't walk back the glyphs
2153 from it3.glyph_row. Solves assertion violation when the display
2154 string begins with a newline (egg.el). (Bug#11367)
2155
b593d6a9
AH
21562012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2157
2158 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2159 Move to simple.el.
2160
4737362e
GM
21612012-05-01 Glenn Morris <rgm@gnu.org>
2162
99cf43f9
GM
2163 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2164 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2165 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2166 All were removed before 23.1.
2167
9311dcff
GM
2168 * dispnew.c: Remove HAVE_LIBNCURSES test;
2169 it is always true on relevant platforms.
2170
4d5c6349
GM
2171 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2172 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2173
4737362e
GM
2174 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2175
74dd3a6b
AS
21762012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2177
2178 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2179 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2180 Remove.
2181
13c379ee
PE
21822012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2183
2184 Do not avoid creating empty evaporating overlays (Bug#9642).
2185 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2186 That is, do not delete an evaporating overlay if it becomes
2187 empty after its bounds are adjusted to fit within its buffer.
2188 This fix caused other problems, and I'm reverting it until we get
2189 to the bottom of them.
2190
a8e7d6d7 21912012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2192
2193 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2194
a8e7d6d7 21952012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2196
2197 * xdisp.c (pos_visible_p): If the window start position is beyond
2198 ZV, start the display from buffer beginning. Prevents assertion
2199 violation in init_iterator when the minibuffer window is scrolled
2200 via the scroll bar.
2201
2202 * window.c (window_scroll_pixel_based): Likewise.
2203
a8e7d6d7 22042012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2205
2206 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2207
a8e7d6d7 22082012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2209
2210 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2211 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2212
a8e7d6d7 22132012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2214
b593d6a9
AH
2215 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2216 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2217
1c6900d9
EZ
22182012-04-26 Eli Zaretskii <eliz@gnu.org>
2219
4c3fa1d9
EZ
2220 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2221 display element, check also the underlying string or buffer
2222 character. (Bug#11341)
2223
1c6900d9
EZ
2224 * w32menu.c: Include w32heap.h.
2225 (add_menu_item): If the call to AppendMenuW (via
2226 unicode_append_menu) fails, disable Unicode menus only if we are
2227 running on Windows 9X/Me.
2228
42bf8205
AS
22292012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2230
2231 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2232 (xgetint): Add missing shift for LSB tags.
2233
b1bac16e
MR
22342012-04-24 Martin Rudalics <rudalics@gmx.at>
2235
2236 * keyboard.c (read_char): Don't wipe echo area for select window
2237 events: These might get delayed via `mouse-autoselect-window'
2238 (Bug#11304).
2239
d69621cc
JB
22402012-04-24 Juanma Barranquero <lekktu@gmail.com>
2241
2242 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2243 manipulation of :loaded-from data.
2244
02fd101b
JB
22452012-04-23 Juanma Barranquero <lekktu@gmail.com>
2246
2247 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2248 now a cons (bug#11311).
2249
888bec30
PE
22502012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2251
89a438bd
PE
2252 Do not create empty overlays with the evaporate property (Bug#9642).
2253 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2254 if it becomes empty after its bounds are adjusted to fit within
2255 its buffer. Without this fix, in a nonempty buffer (let ((o
2256 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2257 yields an empty overlay that has the evaporate property, which is
2258 not supposed to happen.
2259
1068fe4d
PE
2260 Fix minor GTK3 problems found by static checking.
2261 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2262 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2263 (struct _EmacsFixedClass, emacs_fixed_get_type):
2264 Move decls here from emacsgtkfixed.h, since they needn't be public.
2265 (emacs_fixed_get_type): Now static.
2266 (emacs_fixed_class_init): Omit unused local.
2267 (emacs_fixed_child_type): Remove; unused.
2268 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2269 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2270 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2271 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2272 (EMACS_FIXED_GET_CLASS): Remove; unused.
2273 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2274
888bec30
PE
2275 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2276 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2277
de85e130
PE
22782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2279
d0baac98 2280 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2281 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2282 (__malloc_size_t, __malloc_ptrdiff_t):
2283 Remove. All uses removed, replaced by the definiens if needed,
2284 since we can assume C89 or better now.
2285 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2286 (protect_malloc_state, align, get_contiguous_space)
2287 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2288 (malloc_atfork_handler_child, malloc_enable_thread)
2289 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2290 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2291 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2292 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2293 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2294 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2295 Define using prototypes, not old style.
2296 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2297 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2298 (align): Don't assume that signed integer overflow wraps around.
2299 Omit unused local var.
2300 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2301 (_free_internal_nolock, memalign, mallochook, reallochook):
2302 Omit no-longer-needed casts.
2303 (valloc): Use getpagesize, not __getpagesize.
2304 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2305 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2306
de85e130
PE
2307 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2308
dcbf5805
MA
23092012-04-22 Michael Albinus <michael.albinus@gmx.de>
2310
2311 Move functions from C to Lisp. Make non-blocking method calls
2312 the default. Implement further D-Bus standard interfaces.
2313
2314 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2315 (QCdbus_request_name_allow_replacement)
2316 (QCdbus_request_name_replace_existing)
2317 (QCdbus_request_name_do_not_queue)
2318 (QCdbus_request_name_reply_primary_owner)
2319 (QCdbus_request_name_reply_in_queue)
2320 (QCdbus_request_name_reply_exists)
2321 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2322 (QCdbus_registered_serial, QCdbus_registered_method)
2323 (QCdbus_registered_signal): New Lisp objects.
2324 (XD_DEBUG_MESSAGE): Use sizeof.
2325 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2326 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2327 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2328 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2329 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2330 (xd_signature, xd_append_arg): Allow float for integer types.
2331 (xd_get_connection_references): New function.
b593d6a9
AH
2332 (xd_get_connection_address): Rename from xd_initialize.
2333 Return cached address.
dcbf5805
MA
2334 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2335 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2336 level.
2337 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2338 Return number of refcounts.
dcbf5805
MA
2339 (Fdbus_get_unique_name): Make stronger parameter check.
2340 (Fdbus_message_internal): New defun.
2341 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2342 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2343 (Fdbus_send_signal, Fdbus_register_service)
2344 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2345 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2346 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2347 (Vdbus_compiled_version, Vdbus_runtime_version)
2348 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2349 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2350 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2351 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2352 Adapt docstring.
dcbf5805 2353
52828e02
PE
23542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2355
da05bc4c
PE
2356 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2357 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2358 Do not assume ptrdiff_t is the same width as 'int'.
2359
52828e02
PE
2360 * alloc.c: Handle unusual debugging option combinations.
2361 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2362 since the two debugging options are incompatible.
2363 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2364 is defined.
2365 (mem_init, mem_insert, mem_insert_fixup):
2366 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2367 (NEED_MEM_INSERT): Remove; no longer needed.
2368
f01769f9
LL
23692012-04-22 Leo Liu <sdl.web@gmail.com>
2370
2371 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2372
5790543d
PE
23732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * sysdep.c [__FreeBSD__]: Minor cleanups.
2376 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2377 Use Emacs indenting style more consistently. Avoid some casts.
2378 Use 'double' consistently rather than mixing 'float' and 'double'.
2379
b91b7e4d
EW
23802012-04-21 Eduard Wiebe <usenet@pusto.de>
2381
b593d6a9
AH
2382 * sysdep.c (list_system_processes, system_process_attributes):
2383 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2384
6114eb15
AS
23852012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2386
2387 * lisp.mk (lisp): Update.
2388
2f38dff7
PE
23892012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2390
2391 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2392 It is never used otherwise.
2393
4ae29f89
SM
23942012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2395
2396 * print.c (print_preprocess): Only check print_depth if print-circle
2397 is nil.
2398 (print_object): Check for cycles even when print-circle is nil and
2399 print-gensym is t, but only check print_depth if print-circle is nil.
2400
f30d612a
CY
24012012-04-20 Chong Yidong <cyd@gnu.org>
2402
2403 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2404 set the status to "failed" and ensure that sentinel is run.
2405
c07a4c0b 24062012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2407
2408 * process.c (Fset_process_inherit_coding_system_flag)
2409 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2410 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2411
c07a4c0b 24122012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2413
2414 * xdisp.c (string_buffer_position_lim): Limit starting position to
2415 BEGV.
2416 (set_cursor_from_row): If called for a mode-line or header-line
2417 row, return zero immediately.
2418 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2419 farther than the first row after the header line, if any.
2420 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2421 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2422
c07a4c0b 24232012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2424
4ae29f89
SM
2425 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2426 (bug#11238).
ad3a2b41 2427
c07a4c0b 24282012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 24292012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2430
2431 configure: new option --enable-gcc-warnings (Bug#11207)
2432 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2433 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2434 (ALL_CFLAGS): Use new macros rather than old.
2435 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2436 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2437 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2438 -Wunused-result, -Wunused-variable. This should go away once
2439 the Emacs and Gnulib regex code is merged.
2440 (xmalloc, xrealloc): Now static.
2441
aba027e8
PE
24422012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2443
2444 * dired.c (Fsystem_groups): Remove unused local.
2445
e5a36063
GM
24462012-04-17 Glenn Morris <rgm@gnu.org>
2447
2448 * dired.c (Fsystem_users): Doc fix.
2449
316411f0
DA
24502012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2451
2452 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2453 (syms_of_dired): Add them.
2454
9426aba4
PE
24552012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2456
b62a57be
PE
2457 Fix minor alloc.c problems found by static checking.
2458 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2459 New extern decls, to avoid calling undeclared functions.
2460 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2461 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2462 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2463 (NEED_MEM_INSERT): New macro.
2464 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2465 Remove one incorrect comment and fix another.
b62a57be 2466
3539f31f
PE
2467 Fix minor ralloc.c problems found by static checking.
2468 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2469 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2470 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2471 (r_alloc_sbrk): Now static.
2472
a041960a
PE
2473 Improve ralloc.c interface checking.
2474 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2475 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2476 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2477 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2478 [REL_ALLOC]: ... to here, to check interface.
2479 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2480 Remove decls. This fixes an "It stinks!".
2481
9426aba4
PE
2482 * alloc.c (which_symbols): Fix alignment issue / type clash.
2483
d55c12ed
AS
24842012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2485
2486 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2487 (struct Lisp_Misc_Any): Likewise.
2488 (struct Lisp_Free): Likewise.
2489 * alloc.c (union aligned_Lisp_Symbol): Define.
2490 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2491 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2492 (union aligned_Lisp_Misc): Define.
2493 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2494 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2495 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2496
b948ce8b
PE
24972012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2500 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2501 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2502 * s/netbsd.h, s/sol2-6.h:
2503 Remove definition of GC_MARK_STACK, since the default now works.
2504 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2505 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2506 no longer the default.
2507 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2508
35dc09a1 25092012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2510
35dc09a1
GM
2511 * lread.c (lisp_file_lexically_bound_p):
2512 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2513
35dc09a1
GM
25142012-04-14 Eli Zaretskii <eliz@gnu.org>
2515
2516 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2517 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2518
25192012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2520
2521 * nsterm.m (constrainFrameRect): Always constrain when there is only
2522 one screen (Bug#10962).
2523
bcd86815
KB
25242012-04-13 Ken Brown <kbrown@cornell.edu>
2525
2526 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2527
c25df26e
RT
25282012-04-13 Reuben Thomas <rrt@sc3d.org>
2529
2530 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2531
0fc59f1e
DC
25322012-04-11 Daniel Colascione <dancol@dancol.org>
2533
2534 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2535 against is gone. It's better to use vfork now so that when Cygwin
2536 gains a new, working vfork, we use it automatically (bug#10398).
2537
de8c03dc
SM
25382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2539
2540 * window.c (save_window_save): Obey window-point-insertion-type.
2541
2f097256
GM
25422012-04-11 Glenn Morris <rgm@gnu.org>
2543
2544 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2545
453b951e
SM
25462012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2547
2548 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2549
75f1671a 25502012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2551
2552 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2553 (force_quit_count): New var.
2554 (handle_interrupt): Use it.
2555
2a8ce227
JB
25562012-04-10 Juanma Barranquero <lekktu@gmail.com>
2557
2558 * w32.c (w32_delayed_load): Record the full path of the library
2559 being loaded (bug#10424).
2560
935396c0
GM
25612012-04-09 Glenn Morris <rgm@gnu.org>
2562
05920a43
GM
2563 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2564 not just in the obarray, before snarfing them. (Bug#11036)
2565
935396c0
GM
2566 * Makefile.in ($(leimdir)/leim-list.el):
2567 Pass EMACS rather than BUILT_EMACS.
2568
a18ecafa
TZ
25692012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2570
2571 * process.c (make_process):
2572 * process.h: Add integer `gnutls_handshakes_tried' member to
2573 process struct.
2574
6bbef4e5
JC
2575 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2576 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2577
2578 * gnutls.c (gnutls_log_function2i): Convenience log function.
2579 (emacs_gnutls_read): Use new log functions,
2580 `gnutls_handshakes_tried' process member, and
2581 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2582 attempts per process (connection).
2583
b4d3bc10
CY
25842012-04-09 Chong Yidong <cyd@gnu.org>
2585
2586 * eval.c (Fuser_variable_p, user_variable_p_eh)
2587 (lisp_indirect_variable): Functions deleted.
2588 (Fdefvar): Caller changed.
2589
2590 * callint.c (Finteractive, Fcall_interactively):
2591 * minibuf.c (Fread_variable): Callers changed.
2592
70f4d973
EZ
25932012-04-09 Eli Zaretskii <eliz@gnu.org>
2594
2595 * xdisp.c (set_cursor_from_row): If the display string appears in
2596 the buffer at position that is closer to point than the position
2597 after the display string, display the cursor on the first glyph of
2598 the display string. Fixes cursor display when a 'display' text
2599 property immediately follows invisible text. (Bug#11094)
2600
cb3c2e3e
PE
26012012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 composite.c: use 'double' consistently
2604 * composite.c (get_composition_id): Use 'double' consistently
2605 instead of converting 'float' to 'double' and vice versa; this is
2606 easier to understand and avoids a GCC warning.
2607
fd06db5d
GM
26082012-04-09 Glenn Morris <rgm@gnu.org>
2609
50fe702a
GM
2610 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2611 preparation for dumping it with emacs. (Bug#4789)
2612 (leimdir): New variable.
2613 ($(leimdir)/leim-list.el): New rule.
2614 (emacs$(EXEEXT)): Depend on leim-list.el.
2615
fd06db5d
GM
2616 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2617 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2618 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2619
55c131ee
AS
26202012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2621
2622 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2623 proper alignment.
2624
9209588f
JB
26252012-04-07 Juanma Barranquero <lekktu@gmail.com>
2626
2627 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2628 Remove unused local variable.
2629
e3fb2efb
PE
26302012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2631
2632 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2633 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2634 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2635 objects, as mark_maybe_pointer will catch them otherwise.
2636 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2637 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2638
b5385551
PE
26392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2640
2641 Fix typo that broke non-Windows builds.
2642 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2643
9078ead6
EZ
26442012-04-07 Eli Zaretskii <eliz@gnu.org>
2645
2646 Support building on MS-Windows with libxml2.
2647
2648 * makefile.w32-in (OBJ2): Add xml.$(O).
2649 (GLOBAL_SOURCES): Add xml.c.
2650 ($(BLD)/xml.$(O)): New dependency list.
2651
2652 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2653 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2654 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2655 [!WINDOWSNT]: New macros.
2656 (init_libxml2_functions, libxml2_loaded_p): New functions.
2657 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2658 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2659 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2660 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2661 linked in).
6bbef4e5
JC
2662 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2663 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2664 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2665
2666 * emacs.c: Don't include libxml/parser.h.
2667 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2668 xmlCleanupParser directly.
2669
2670 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2671
3811fdf3
EZ
26722012-04-07 Eli Zaretskii <eliz@gnu.org>
2673
2674 * indent.c (Fvertical_motion): If there is a display string at
2675 point, use it.vpos to compute how many lines to backtrack after
2676 move_it_to point. (Bug#11133)
2677
2f8e16b2
EZ
26782012-04-06 Eli Zaretskii <eliz@gnu.org>
2679
2680 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2681 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2682 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2683 macros related to unification of CJK characters. For the details,
2684 see the discussion following the message here:
2685 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2686
3d439cd1
CY
26872012-04-04 Chong Yidong <cyd@gnu.org>
2688
2689 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2690
8bc53d00
EZ
26912012-04-01 Eli Zaretskii <eliz@gnu.org>
2692
2693 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2694 instead of alloca. (Bug#11138)
2695
3b0512a3
AS
26962012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2697
2698 * w32menu.c (is_simple_dialog): Properly check lisp types.
2699 (Bug#11141)
2700
8427ddd2
EZ
27012012-03-31 Eli Zaretskii <eliz@gnu.org>
2702
979022ef
EZ
2703 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2704 position we get to after a call to move_it_to fails the
2705 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2706 only if we wind up in a string from display property. (Bug#11063)
2707
a6b1c7cc
EZ
2708 * window.c (Fdelete_other_windows_internal): Invalidate the row
2709 and column information about mouse highlight, so that redisplay
2710 restores it after reallocating the glyph matrices. (Bug#7464)
2711
8427ddd2
EZ
2712 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2713 string comes from a `display' text property, use the buffer
2714 position of that property as if we actually saw that position in
2715 the row's glyphs.
697ba24b
EZ
2716 (move_it_by_lines): Remove the assertion that
2717 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2718 violated when there's a before-string at the beginning of a line.
2719 (Bug#11063)
8427ddd2 2720
65a0a738
EZ
27212012-03-30 Eli Zaretskii <eliz@gnu.org>
2722
2723 * xdisp.c (append_space_for_newline): If the default face was
2724 remapped, use the remapped face for the appended newline.
2725 (extend_face_to_end_of_line): Use the remapped default face for
2726 extending the face to the end of the line.
2727 (display_line): Call extend_face_to_end_of_line when the default
2728 face was remapped. (Bug#11068)
2729
581355cc
EZ
27302012-03-29 Eli Zaretskii <eliz@gnu.org>
2731
2732 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2733
e8fc049f
SM
27342012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2735
2736 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2737
4fb9a543
GM
27382012-03-27 Glenn Morris <rgm@gnu.org>
2739
2740 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2741 Doc fixes.
2742
679910f1
KH
27432012-03-26 Kenichi Handa <handa@m17n.org>
2744
2745 * dispextern.h (struct glyph): Fix previous change. Change the
2746 bit length of glyphless.ch to 25 (Bug#11082).
2747
90d49b7f
CY
27482012-03-26 Chong Yidong <cyd@gnu.org>
2749
2750 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2751 (command_loop_1): Use it; inhibit selection update for
2752 handle-select-window too (Bug#8996).
2753
f514f6f0
FP
27542012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2755
e8fc049f 2756 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2757
bf43fa51
KH
27582012-03-25 Kenichi Handa <handa@m17n.org>
2759
2760 * dispextern.h (struct glyph): Change the bit length of
2761 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2762
8a0c01dd
EZ
27632012-03-24 Eli Zaretskii <eliz@gnu.org>
2764
2765 * s/ms-w32.h (tzname): Include time.h before redirecting to
2766 _tzname. Fixes the MSVC build. (Bug#9960)
2767
7d1c3a76
AS
27682012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2769
8ed79523
AS
2770 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2771 characters.
2772
7d1c3a76
AS
2773 * xterm.c (XTread_socket): Only modify handling_signal if
2774 !SYNC_INPUT. (Bug#11080)
2775
e99a9b8b
EZ
27762012-03-23 Eli Zaretskii <eliz@gnu.org>
2777
2778 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2779 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2780 when fetching a multibyte character consumes more bytes than
2781 CHAR_BYTES returns, due to unification of CJK characters in
2782 string_char. (Bug#11073)
2783
5063c0e1
TN
27842012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2785
2786 * process.c (wait_reading_process_output): Handle pty disconnect
2787 by refraining from sending oneself a SIGCHLD (bug#10933).
2788
9f851fbd
CY
27892012-03-22 Chong Yidong <cyd@gnu.org>
2790
2791 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2792
5063c0e1 2793 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2794 Mark string as coming from a prefix property.
2795 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2796 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2797
fb5b8aca
CY
27982012-03-21 Chong Yidong <cyd@gnu.org>
2799
2800 * xfaces.c (Vface_remapping_alist): Doc fix.
2801
62356a1b
EZ
28022012-03-20 Eli Zaretskii <eliz@gnu.org>
2803
2804 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2805 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2806 Doc fixes.
62356a1b 2807
025de85b
CY
28082012-03-20 Chong Yidong <cyd@gnu.org>
2809
2810 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2811 to reflect default non-nil value of redisplay-dont-pause.
2812
4827f94e
KH
28132012-03-19 Kenichi Handa <handa@m17n.org>
2814
2815 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2816 it fit in a valid range (Bug#11003).
2817
e50a24a2
EZ
28182012-03-18 Eli Zaretskii <eliz@gnu.org>
2819
2820 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2821 that is not from display property, accept the row as a "cursor
2822 row" if one of the string's character has a non-nil `cursor'
2823 property. Fixes cursor positioning when there are newlines in
2824 overlay strings, e.g. in icomplete.el. (Bug#11035)
2825
9af5ed87
PE
28262012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2829
d1f55f16
CY
28302012-03-12 Chong Yidong <cyd@gnu.org>
2831
2832 * eval.c (inhibit_lisp_code): Rename from
2833 inhibit_window_configuration_change_hook; move from window.c.
2834
2835 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2836 * window.c (run_window_configuration_change_hook)
2837 (syms_of_window): Callers changed.
2838
66c5eebd
CY
28392012-03-11 Chong Yidong <cyd@gnu.org>
2840
413df973
CY
2841 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2842
66c5eebd
CY
2843 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2844
1de11f56
CY
28452012-03-10 Chong Yidong <cyd@gnu.org>
2846
2847 * frame.c (other_visible_frames): Don't assume the selected frame
2848 is visible (Bug#10955).
2849
cae07000
SM
28502012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2851
2852 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2853
89c94350
JD
28542012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2855
2856 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2857 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2858 zero (Bug#10954).
2859
999dd333
GM
28602012-03-03 Glenn Morris <rgm@gnu.org>
2861
01a6dcc8 2862 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2863
de0100f2
EZ
28642012-03-02 Eli Zaretskii <eliz@gnu.org>
2865
2866 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2867 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2868 (redisplay_window, next_element_from_string): Fix typos in
2869 comments.
3e441275
EZ
2870 (redisplay_window): Pass to move_it_vertically the margin in
2871 pixels, not in screen lines.
de0100f2 2872
96a72ee9
GM
28732012-03-02 Glenn Morris <rgm@gnu.org>
2874
2875 * buffer.c (buffer-list-update-hook): Doc fix.
2876
312508d7
EZ
28772012-02-29 Eli Zaretskii <eliz@gnu.org>
2878
2879 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2880 push_it before setting up the iterator for the first overlay
2881 string, even if we have an empty string loaded.
2882 (next_overlay_string): If there's an empty string on the iterator
2883 stack, pop the stack. (Bug#10903)
2884
27f3c637
PE
28852012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2888 Suggested by Stefan Monnier in
2889 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2890 * alloc.c (widen_to_Lisp_Object): New static function.
2891 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2892 and widening them to Lisp_Objects. This would work even if
2893 USE_LSB_TAG is defined and wide integers are used, which might
2894 happen in a future version of Emacs.
2895
3c9dfce6
CY
28962012-02-25 Chong Yidong <cyd@gnu.org>
2897
fa74b241
CY
2898 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2899 Doc fix.
2900
3c9dfce6
CY
2901 * xselect.c (Fx_selection_exists_p): Doc fix.
2902 (x_clipboard_manager_save_all): Print an informative message
2903 before saving to clipboard manager.
2904
9486df08
CY
29052012-02-24 Chong Yidong <cyd@gnu.org>
2906
2907 * keyboard.c (process_special_events): Handle all X selection
2908 requests in kbd_buffer, not just the next one (Bug#8869).
2909
f01d3321
CY
29102012-02-23 Chong Yidong <cyd@gnu.org>
2911
2912 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2913 call when setting menu-bar-lines and tool-bar-lines parameters.
2914 (unwind_create_frame_1): New helper function.
2915
2916 * window.c (inhibit_window_configuration_change_hook): New var.
2917 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2918 (syms_of_window): Initialize it.
f01d3321 2919
86b847b6
CY
29202012-02-22 Chong Yidong <cyd@gnu.org>
2921
2922 * xterm.c (x_draw_image_relief): Add missing type check for
2923 Vtool_bar_button_margin (Bug#10743).
2924
a59225b1
CY
29252012-02-21 Chong Yidong <cyd@gnu.org>
2926
2927 * fileio.c (Vfile_name_handler_alist): Doc fix.
2928
2929 * buffer.c (Fget_file_buffer): Protect against invalid file
2930 handler return value.
2931
310f5bd4
PE
29322012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2933
cb3a28cc
PE
2934 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2935 when computing $valmask.
2936
310f5bd4
PE
2937 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2938 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2939 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2940 It's useless in that case, and it can cause problems on hosts
2941 that allocate halves of EMACS_INT values separately.
2942 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2943 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2944 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2945 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2946 it avoids undefined behavior on hosts where shifting right by more
2947 than the word width has undefined behavior.
2948
2375c96a
CY
29492012-02-19 Chong Yidong <cyd@gnu.org>
2950
2951 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2952 (Funhandled_file_name_directory, Ffile_name_as_directory)
2953 (Fdirectory_file_name, Fexpand_file_name)
2954 (Fsubstitute_in_file_name): Protect against invalid file handler
2955 return values (Bug#10845).
2956
3eb49e71
EZ
29572012-02-18 Eli Zaretskii <eliz@gnu.org>
2958
2959 * .gdbinit (pitx): Fix incorrect references to fields of the
2960 iterator stack.
2961
7b926f3f
CY
29622012-02-17 Chong Yidong <cyd@gnu.org>
2963
2964 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2965
11273115
PE
29662012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2969 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2970
c3a70e2b
CY
29712012-02-15 Chong Yidong <cyd@gnu.org>
2972
2973 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2974 marked as special. Also, starting docstrings with * is obsolete.
2975
0ca43699
AS
29762012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2977
2978 * gnutls.c (emacs_gnutls_write): Fix last change.
2979
2e8f3c56
LI
29802012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2981
2982 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2983 send_process.
2984
af70074f
SM
29852012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2986
2987 * keymap.c (Fsingle_key_description): Handle char ranges.
2988
95986d52
CY
29892012-02-12 Chong Yidong <cyd@gnu.org>
2990
afd83bd1
CY
2991 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2992 as that creates a dangerous corner case.
2993
95986d52
CY
2994 * window.c (Fdelete_window_internal): Invalidate the mouse
2995 highlight (Bug#9904).
2996
bd7da63e
GM
29972012-02-12 Glenn Morris <rgm@gnu.org>
2998
2999 * xselect.c (Fx_own_selection_internal)
3000 (Fx_get_selection_internal, Fx_disown_selection_internal)
3001 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3002 * nsselect.m (Fx_own_selection_internal)
3003 (Fx_disown_selection_internal, Fx_selection_exists_p)
3004 (Fx_selection_owner_p, Fx_get_selection_internal):
3005 Sync docs and argument specs with the xselect.c versions.
3006
77abcbc2
LI
30072012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3008
3009 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3010
90b671e2
EZ
30112012-02-11 Eli Zaretskii <eliz@gnu.org>
3012
1c0ca0b7
EZ
3013 * w32select.c (Fx_selection_exists_p): Sync doc string and
3014 argument list with xselect.c. (Bug#10783)
3015
3016 * w16select.c (Fx_selection_exists_p): Sync doc string and
3017 argument list with xselect.c. (Bug#10783)
90b671e2 3018
49241268
GM
30192012-02-10 Glenn Morris <rgm@gnu.org>
3020
3021 * fns.c (Fsecure_hash): Doc fix.
3022
f998bbe7 30232012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3024
3025 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3026
0992bd9c
CY
30272012-02-07 Chong Yidong <cyd@gnu.org>
3028
3029 * buffer.c (Fbuffer_local_variables)
3030 (buffer_lisp_local_variables): Handle unbound vars correctly;
3031 don't let Qunbound leak into Lisp.
3032
af008560
GM
30332012-02-07 Glenn Morris <rgm@gnu.org>
3034
dd605cc4
GM
3035 * image.c (Fimagemagick_types): Doc fix.
3036
af008560
GM
3037 * image.c (imagemagick-render-type): Change it from a lisp object
3038 to an integer. Move the doc here from the lisp manual.
3039 Treat all values not equal to 0 the same.
3040
1449fa1d
CY
30412012-02-06 Chong Yidong <cyd@gnu.org>
3042
3043 * doc.c (store_function_docstring): Avoid applying docstring of
3044 alias to base function (Bug#2603).
3045
3723ec07
AS
30462012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3047
3048 * .gdbinit (pp1, pv1): Remove redundant defines.
3049 (pr): Use pp.
3050
79c1cc1e
CY
30512012-02-04 Chong Yidong <cyd@gnu.org>
3052
3053 * nsterm.m: Declare a global (Bug#10694).
3054
d7f29f8e
EZ
30552012-02-04 Eli Zaretskii <eliz@gnu.org>
3056
cae07000
SM
3057 * w32.c (get_emacs_configuration_options):
3058 Include --enable-checking, if specified, in the return value.
d7f29f8e 3059
3b95a6f9
MR
30602012-02-04 Martin Rudalics <rudalics@gmx.at>
3061
3062 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3063 after rounding frame sizes. (Bug#9723)
3064
d6fa96a6
EZ
30652012-02-04 Eli Zaretskii <eliz@gnu.org>
3066
3067 * keyboard.c (adjust_point_for_property): Don't position point
3068 before BEGV. (Bug#10696)
3069
df0b2940
PE
30702012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3071
3072 Handle overflow when computing char display width (Bug#9496).
3073 * character.c (char_width): Return EMACS_INT, not int.
3074 (char_width, c_string_width): Check for overflow when
3075 computing the width; this is possible now that individual
3076 characters can have unbounded width. Problem introduced
3077 by merge from Emacs 23 on 2012-01-19.
3078
6bee44d6
MA
30792012-02-02 Michael Albinus <michael.albinus@gmx.de>
3080
3081 * dbusbind.c (Fdbus_register_method): Mention the return value
3082 :ignore in the docstring.
3083
44f92739
GM
30842012-02-02 Glenn Morris <rgm@gnu.org>
3085
1b9f60cc
GM
3086 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3087
44f92739
GM
3088 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3089 Unconditionally set to t. (Bug#10673)
3090 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3091 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3092 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3093
c5d3843c
KH
30942012-02-02 Kenichi Handa <handa@m17n.org>
3095
3096 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3097 0, do not call append_composite_glyph.
3098
159462d4 30992012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3100
3101 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3102 NULL (Bug#6988).
3103 (x_produce_glyphs): If the component of a composition is a null
3104 string, set it->pixel_width to 1 to avoid zero-width glyph.
3105
78cef877
EZ
31062012-02-01 Eli Zaretskii <eliz@gnu.org>
3107
3108 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3109 first 2 arguments are identical. This makes inserting large
3110 output from a subprocess an order of magnitude faster on
3111 MS-Windows, where all sbrk'ed memory is always contiguous.
3112
97897668
GM
31132012-01-31 Glenn Morris <rgm@gnu.org>
3114
3115 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3116 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3117 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3118
31fd3586
GM
31192012-01-29 Glenn Morris <rgm@gnu.org>
3120
3121 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3122
0e24a8b2
CY
31232012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3124
3125 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3126
cc0adcb0
CY
31272012-01-28 Chong Yidong <cyd@gnu.org>
3128
3129 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3130
acc28cb9
CY
31312012-01-26 Chong Yidong <cyd@gnu.org>
3132
9c69cfb7
CY
3133 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3134
acc28cb9
CY
3135 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3136 repeat counts (Bug#10507).
3137
48da7392
GM
31382012-01-26 Glenn Morris <rgm@gnu.org>
3139
3140 * lread.c (syms_of_lread): Doc fix.
3141
14af5f7f
CY
31422012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3143
3144 * coding.c (encode_designation_at_bol): Change return value to
3145 EMACS_INT.
3146
0b21c100
CY
31472012-01-25 Chong Yidong <cyd@gnu.org>
3148
3149 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3150
3c2907f7
CY
31512012-01-21 Chong Yidong <cyd@gnu.org>
3152
3153 * floatfns.c (Fcopysign): Make the second argument non-optional,
3154 since nil is not allowed anyway.
3155
959ad23f
AS
31562012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3157
3158 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3159 (send_process): Likewise.
3160
34a02f46
MR
31612012-01-19 Martin Rudalics <rudalics@gmx.at>
3162
3163 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3164 (Vwindow_persistent_parameters): Do not use Qstate.
3165 Rewrite doc-strings.
34a02f46 3166
1259009a 31672012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3168
3169 * character.c (char_width): New function.
70d4fdf6
GM
3170 (Fchar_width, c_string_width, lisp_string_width):
3171 Use char_width (Bug#9496).
25ed9e61 3172
6a6ee00d
MR
31732012-01-16 Martin Rudalics <rudalics@gmx.at>
3174
3175 * window.c (Vwindow_persistent_parameters): New variable.
3176 (Fset_window_configuration, save_window_save): Handle persistent
3177 window parameters.
3178
c85efaf7
EZ
31792012-01-14 Eli Zaretskii <eliz@gnu.org>
3180
3181 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3182 thrashing the stack of the thread. (Bug#9087)
3183
5944709e
PE
31842012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3187
e71f5d99
EZ
31882012-01-11 Eli Zaretskii <eliz@gnu.org>
3189
3190 * xdisp.c (rows_from_pos_range): Handle the case where the
3191 highlight ends on a newline. (Bug#10464)
3192 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3193 he end column for display of highlight that ends on a newline
3194 before a R2L line.
3195
ce316182
GM
31962012-01-11 Glenn Morris <rgm@gnu.org>
3197
3198 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3199 from load-path also when installation-directory is nil. (Bug#10208)
3200
5b43da69
GM
32012012-01-10 Glenn Morris <rgm@gnu.org>
3202
74cc8ff9
GM
3203 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3204
7d8d6e4e
GM
3205 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3206 Update template values to be closer to their typical values these days.
5b43da69 3207
a0db8d43
EZ
32082012-01-09 Eli Zaretskii <eliz@gnu.org>
3209
3210 * xdisp.c (rows_from_pos_range): Accept additional argument
3211 DISP_STRING, and accept any glyph in a row whose object is that
3212 string as eligible for mouse highlight. Fixes mouse highlight of
3213 display strings from overlays. (Bug#10464)
3214
9a0115ab 32152012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3216
b9110d6a 3217 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3218 * fileio.c (auto_saving_dir_umask): New static var.
3219 (Fmake_directory_internal): Use it.
3220 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3221 creating the directory. The old code temporarily assigns
3222 too-generous permissions to the directory.
3223 (do_auto_save_eh): Clear it.
b9110d6a 3224 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3225 that the var is always cleared.
3226
6c1bd3f3
EZ
32272012-01-07 Eli Zaretskii <eliz@gnu.org>
3228
3229 * search.c (scan_buffer): Pass character positions to
3230 know_region_cache, not byte positions. (Bug#6540)
3231
069d2b50
L
32322012-01-07 LynX <_LynX@bk.ru> (tiny change)
3233
3234 * w32.c (sys_rename): Report EXDEV when rename of a directory
3235 fails because the target is on another logical disk. (Bug#10284)
3236
75bf0d33
DB
32372012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3238
3239 * xterm.c (x_embed_request_focus): New function.
3240
3241 * xterm.h: Add prototype.
3242
3243 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3244
1c6e5a32
GM
32452012-01-05 Glenn Morris <rgm@gnu.org>
3246
3247 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3248
651e947e
EZ
32492012-01-01 Eli Zaretskii <eliz@gnu.org>
3250
3251 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3252 Load gnutls_transport_set_lowat only if GnuTLS version is below
3253 2.11.1.
3254 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3255 GnuTLS versions below 2.11.1.
3256
3778cdd8
AL
32572011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3258
3259 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3260 to the doc string advising against its use for altering the way
3261 windows are scrolled.
3262
0e5317f7
KH
32632011-12-28 Kenichi Handa <handa@m17n.org>
3264
3265 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3266 coding-system ASCII compatible only when it does not produce BOM
3267 on encoding (Bug#10383).
3268
93d5ca1f
JD
32692011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3270
3271 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3272 can scroll.
3273 (create_and_show_popup_menu): Always use menu_position_func for
3274 Gtk3 (Bug#10361).
3275
ca22b785
AS
32762011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3277
3278 * callint.c (Fcall_interactively): Don't truncate prompt string.
3279
d048e1e6
EZ
32802011-12-23 Eli Zaretskii <eliz@gnu.org>
3281
3282 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3283 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3284 resumed from there (after widening). (Bug#10360)
d048e1e6 3285
5ccaba1f
JD
32862011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3287
3288 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3289
204ee57f
JD
32902011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3291
b81d40f0
JB
3292 * nsterm.m (x_free_frame_resources):
3293 Release f->output_data.ns->miniimage.
204ee57f
JD
3294 (ns_index_color): Fix indentation. Do not retain
3295 color_table->colors[i].
3296
3297 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3298 before returning.
3299
3300 * nsfns.m (x_set_background_color): Assign return value from
3301 ns_index_color to face-background instead of NSColor*.
3302 (ns_implicitly_set_icon_type): Fix indentation.
3303 Change assignment in for loop to comparison.
3304
3305 * emacs.c (ns_pool): New variable.
3306 (main): Assign ns_pool.
3307 (Fkill_emacs): Call ns_release_autorelease_pool.
3308
3309 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3310 autorelease fdesc, release fdAttrs and tdict.
3311 (ns_get_covering_families): Release charset.
3312 (ns_findfonts): Release NSFontDescriptor created with new.
3313 (ns_uni_to_glyphs): Fix indentation.
3314 (setString): Release attrStr before assigning new value.
3315
c803b2b7
JD
33162011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3317
678f4426
JD
3318 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3319 and NS_IMPL_COCOA.
3320 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3321 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3322
cd394be1 33232011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3324
5fecd5fc
JD
3325 * nsterm.m (ns_term_init): Subscribe for notifications
3326 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3327 to method trackingNotification in EmacsMenu.
3328
3329 * nsmenu.m (trackingMenu): New variable.
3771cb17 3330 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3331 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3332 from Aquamacs (Bug#7030).
678f4426
JD
3333
33342011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3335
c803b2b7
JD
3336 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3337 (symbol_to_nsstring): Fix indentation.
3338 (ns_symbol_to_pb): New function.
cae07000
SM
3339 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3340 (Fns_rotate_cut_buffers_internal): Remove.
3341 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3342 Fns_store_cut_buffer_internal.
3343 (ns_get_foreign_selection, Fx_own_selection_internal)
3344 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3345 (Fns_get_selection_internal, Fns_store_selection_internal):
3346 Use ns_symbol_to_pb and check if return value is nil.
3347 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3348 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3349 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3350 renamed to Sns_store_selection_internal.
3351 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3352 and remove this function.
3353 (ns_handle_selection_clear): Remove, never used.
3354 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3355 here.
3356
e1b01a3a
KB
33572011-12-17 Ken Brown <kbrown@cornell.edu>
3358
3359 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3360 GID is unknown (Bug#10257).
3361
2adb6e85
PE
33622011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3363
3364 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3365 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3366 which caused a build failure on GNU/Linux IA-64. This problem was
3367 introduced by my 2011-10-07 patch.
3368
d1d7b339
JL
33692011-12-15 Juri Linkov <juri@jurta.org>
3370
3371 * image.c (imagemagick_error): New function. (Bug#10112)
3372 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3373 Use `imagemagick_error' where ImageMagick functions return
3374 `MagickFalse'.
3375 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3376 proper order.
3377
100d5755
KH
33782011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3379
3380 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3381 fill background (Bug#8992).
3382
454592a6
MR
33832011-12-13 Martin Rudalics <rudalics@gmx.at>
3384
3385 * window.c (Vwindow_combination_resize)
3386 (Vwindow_combination_limit): Use t instead of non-nil in
3387 doc-strings.
61d4b438
MR
3388 (Vrecenter_redisplay): Add first sentence of doc-string on
3389 separate line.
53524d93 3390 (Frecenter): Fix doc-string typo.
454592a6 3391
3633e3aa
KH
33922011-12-11 Kenichi Handa <handa@m17n.org>
3393
3394 * coding.c (Funencodable_char_position): Pay attention to the
3395 buffer text relocation (Bug#9389).
3396
7b9d523a 33972011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3398
7b9d523a
JD
3399 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3400 gtk_init (Bug#10100).
3401
b73189c6
EZ
34022011-12-10 Eli Zaretskii <eliz@gnu.org>
3403
3404 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3405 IT->string is nil. (Bug#10263)
3406
f7dfe5d6
JD
34072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3408
83faebb4
JD
3409 * nsterm.h (x_free_frame_resources): Declare.
3410
f7dfe5d6
JD
3411 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3412 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3413
3414 * nsterm.h (ns_get_defaults_value): Declare.
3415
3416 * nsterm.m (ns_default): Call ns_get_defaults_value.
3417
7cd4e72c
EZ
34182011-12-09 Eli Zaretskii <eliz@gnu.org>
3419
3420 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3421 (Bug#10170)
3422
b34d7317
YM
34232011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3424
3425 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3426 that where the value of an _OBJC_* symbol points to is in the .bss
3427 section (Bug#10240).
3428
76470ad1
KH
34292011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3430
3431 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3432 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3433
745fff94
KH
34342011-12-08 Kenichi Handa <handa@m17n.org>
3435
3436 * ftfont.c (get_adstyle_property): Fix previous change
3437 (Bug#10233).
3438
6e44397c
JB
34392011-12-07 Juanma Barranquero <lekktu@gmail.com>
3440
3441 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3442 dirs from the default value of EMACSLOADPATH (bug#10208).
3443
7efa6272
GM
34442011-12-07 Glenn Morris <rgm@gnu.org>
3445
3446 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3447 installation and source directories as well. (Bug#10208)
3448
f6fc4d87
CY
34492011-12-06 Chong Yidong <cyd@gnu.org>
3450
3451 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3452
2bf26180
GM
34532011-12-06 Glenn Morris <rgm@gnu.org>
3454
3455 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3456 as an error, not just -1. (Bug#10217)
3457
3a6ad4f0
CY
34582011-12-05 Chong Yidong <cyd@gnu.org>
3459
3460 * keyboard.c (process_special_events): New function.
3461 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3462
75a3b399
PE
34632011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3464
3465 * coding.c (encode_designation_at_bol): Don't use uninitialized
3466 local variable (Bug#9318).
3467
c3c9e25e
KH
34682011-12-05 Kenichi Handa <handa@m17n.org>
3469
3470 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3471 return Qnil (Bug#8046, Bug#10193).
3472
5eb05ea3
KH
34732011-12-05 Kenichi Handa <handa@m17n.org>
3474
3475 * coding.c (encode_designation_at_bol): New args charbuf_end and
3476 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3477 (coding_set_source): Return how many bytes coding->source was
3478 relocated.
3479 (coding_set_destination): Return how many bytes
3480 coding->destination was relocated.
3481 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3482 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3483
34842011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3485
3486 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3487 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3488 macro (Bug#9318).
3489
34902011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3491
3492 The following changes are to fix Bug#9318.
3493
a79703f5 3494 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3495 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3496 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3497 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3498
7dbda6df
JB
34992011-12-05 Juanma Barranquero <lekktu@gmail.com>
3500
3501 * lisp.h (process_quit_flag): Fix external declaration.
3502
6d5eb5b0
SM
35032011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3504
3505 Don't macro-inline non-performance-critical code.
3506 * eval.c (process_quit_flag): New function.
3507 * lisp.h (QUIT): Use it.
3508
a0c3fad0
JD
35092011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3510
3511 * nsfns.m (get_geometry_from_preferences): New function.
3512 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3513
6c07aac2
AS
35142011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3515
3516 * emacs.c (Qkill_emacs): Define.
3517 (syms_of_emacs): Initialize it.
3518 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3519 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3520 (quit_throw_to_read_char): Add parameter `from_signal'.
3521 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3522 * lisp.h (QUIT): Call Fkill_emacs if requested.
3523
c052ead4
JD
35242011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3525
3526 * widget.c (update_wm_hints): Return if wmshell is null.
3527 (widget_update_wm_size_hints): New function.
3528
3529 * widget.h (widget_update_wm_size_hints): Declare.
3530
3531 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3532 widget_update_wm_size_hints (Bug#10104).
3533
9e49252b
EZ
35342011-12-03 Eli Zaretskii <eliz@gnu.org>
3535
3536 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3537 before a newline, prepare the bidi iterator for consuming the
3538 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3539 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3540
02b16839
JL
35412011-12-02 Juri Linkov <juri@jurta.org>
3542
3543 * search.c (Fword_search_regexp): New Lisp function created from
3544 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3545 (Fword_search_backward, Fword_search_forward)
3546 (Fword_search_backward_lax, Fword_search_forward_lax):
3547 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3548 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3549
0068070e
SM
35502011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3551
3552 * fileio.c (Finsert_file_contents): Move after-change-function call
3553 to before the "handled:" label, since all "goto handled" appear in
3554 cases where the *-change-functions have already been properly called
3555 (bug#10117).
3556
3360a3fc
AS
35572011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3558
3559 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3560 waiting for input. (Bug#10169)
3561
73d6c093
EZ
35622011-11-30 Eli Zaretskii <eliz@gnu.org>
3563
3564 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3565 verifies glyph row's hash code--we have just reallocated the
3566 glyphs, so their contents can be complete garbage. (Bug#10164)
3567
febe6bea
JB
35682011-11-30 Juanma Barranquero <lekktu@gmail.com>
3569
3570 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3571
801a4313
EZ
35722011-11-30 Eli Zaretskii <eliz@gnu.org>
3573
3574 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3575 attributes are tested _before_ calling verify_row_hash, to protect
3576 against GCC re-ordering of the tests. (Bug#10164)
3577
2b56b87e
JD
35782011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3579
3580 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3581
3582 * xterm.c (handle_one_xevent): Only set async_visible and friends
3583 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3584 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3585 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3586
dbf31225
PE
35872011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3590 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3591 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3592 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3593 All uses changed to use GCPRO1 etc.
3594 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3595 Revert to old implementation (i.e., before 2011-03-11).
3596
1305621b
YM
35972011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3598
3599 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3600 of scroll runs so as to avoid assigning disabled bogus rows and
3601 unnecessary graphics copy operations.
3602
8c9afb46
EZ
36032011-11-27 Eli Zaretskii <eliz@gnu.org>
3604
3605 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3606 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3607 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3608 (malloc, free, realloc, calloc): Redirect to e_* only when
3609 compiling Emacs.
3610
3611 * lisp.h (GCTYPEBITS): Move before first use.
3612 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3613 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3614 this macro definition.
3615
3616 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3617 _MSC_VER.
3618
54e9e3bf
JD
36192011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3620
6d5eb5b0
SM
3621 * gtkutil.c (xg_create_frame_widgets):
3622 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3623 present with Gtk+ 2.0.
3624
83aca1cb
PE
36252011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3626
3627 * fileio.c (Finsert_file_contents): Undo previous change; see
3628 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3629
5b76caa4
PE
36302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 Rename locals to avoid shadowing.
3633 * fileio.c (Finsert_file_contents):
3634 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3635 * process.c (wait_reading_process_output):
3636 Rename inner 'proc' to 'p' to avoid shadowing.
3637 Indent for consistency with usual Emacs style.
3638
8c535114
EZ
36392011-11-25 Eli Zaretskii <eliz@gnu.org>
3640
3641 * xdisp.c (redisplay_window): If cursor row is not fully visible
3642 after recentering, and scroll-conservatively is set to a large
3643 number, scroll window by a few more lines to make the cursor fully
3644 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3645 (start_display): Don't move to the next line if the display should
3646 start at a newline that is part of a display vector or an overlay
3647 string. (Bug#10119)
8c535114 3648
fa4fdb5c
JL
36492011-11-24 Juri Linkov <juri@jurta.org>
3650
3651 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3652 after the `MagickPingImage' call. (Bug#10112)
3653
90ec88df
CY
36542011-11-23 Chong Yidong <cyd@gnu.org>
3655
3656 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3657
56e2e794
MR
36582011-11-23 Martin Rudalics <rudalics@gmx.at>
3659
3660 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3661 making another buffer current. (Bug#10114)
3662
b6e64c41
GM
36632011-11-23 Glenn Morris <rgm@gnu.org>
3664
3665 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3666
6b21de18
CY
36672011-11-23 Chong Yidong <cyd@gnu.org>
3668
3669 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3670 using it (Bug#5984).
3671
b12cd789
EZ
36722011-11-22 Eli Zaretskii <eliz@gnu.org>
3673
3674 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3675 and header-lines, as they don't have one computed for them.
3676 (Bug#10098)
3677
3678 * .gdbinit (prow): Make displayed values more self-explaining.
3679 Add row's hash code.
3680
261b6fd4
LMI
36812011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3682
3683 * process.c (wait_reading_process_output): Fix asynchrounous
3684 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3685 (wait_reading_process_output): Add comment and URL.
261b6fd4 3686
e7cfd277
JD
36872011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3688
3689 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3690
a9b9b7f5
CY
36912011-11-21 Chong Yidong <cyd@gnu.org>
3692
3693 * window.c (Fnext_window, Fprevious_window): Doc fix.
3694
b0d15b4f
SM
36952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3696
3697 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3698
fe7a3057
JB
36992011-11-20 Juanma Barranquero <lekktu@gmail.com>
3700
3701 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3702
d2999b1a
MR
37032011-11-20 Martin Rudalics <rudalics@gmx.at>
3704
3705 * window.c (Fset_window_combination_limit): Rename argument
3706 STATUS to LIMIT.
3707 (Vwindow_combination_limit): Remove "status" from doc-string.
3708
d5ff9cd0
AS
37092011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3710
3711 * m/ibms390.h: Remove.
3712 * m/ibms390x.h: Don't include "ibms390.h".
3713
a5bb9bd3
SM
37142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3715
3716 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3717 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3718
cd1181db
JB
37192011-11-20 Juanma Barranquero <lekktu@gmail.com>
3720
3721 * casetab.c (Fset_case_table):
3722 * charset.c (Fcharset_after): Fix typos.
3723
615a3b8d 37242011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3725
17e845af
PE
3726 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3727 Otherwise, valgrind does not work on some platforms.
3728 Problem reported by Andreas Schwab in
6a0bf43d
PE
3729 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3730 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3731 is set, removing the need for VIRT_ADDRESS_VARIES.
3732 (PURE_P): Use a more-efficient implementation that needs just one
3733 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3734 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3735 to 4 (xorl, subq, cmpq, setbe).
3736 * alloc.c (pure): Always extern now, since that's the
3737 VIRT_ADDR_VARIES behavior.
3738 (PURE_POINTER_P): Use a single comparison, not two, for
3739 consistency with the new puresize.h.
3740 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3741 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3742 Remove VIRT_ADDR_VARIES no longer needed.
3743
f8fe6f96
EZ
37442011-11-19 Eli Zaretskii <eliz@gnu.org>
3745
3746 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3747 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3748 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3749 behave as if the cursor position were at the window margin.
3750
3751 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3752 and the cursor position is out of bounds, behave as if the cursor
3753 position were at the window margin. (Bug#10075)
3754
df05a53c
CY
37552011-11-18 Chong Yidong <cyd@gnu.org>
3756
3757 * window.c (Fwindow_combination_limit): Make first argument
3758 non-optional, since it is meaningless for live windows like the
3759 selected window.
61ccba97 3760
2071918e
DA
37612011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3762
3763 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3764
b50a28de
SM
37652011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3766
3767 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3768 (graft_intervals_into_buffer): Simplify.
3769
015137db
EZ
37702011-11-18 Eli Zaretskii <eliz@gnu.org>
3771
3772 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3773 hash values of the two rows.
3774 (copy_row_except_pointers): Preserve the used[] arrays and the
3775 hash values of the two rows. (Bug#10035)
68c95424 3776 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3777
3778 * xdisp.c (row_hash): New function, body extracted from
3779 compute_line_metrics.
3780 (compute_line_metrics): Call row_hash, instead of computing the
3781 hash code inline.
3782
3783 * dispnew.c (verify_row_hash): Call row_hash for computing the
3784 hash code of a row, instead of duplicating code from xdisp.c.
3785
3786 * dispextern.h (row_hash): Add prototype.
3787
a2addb04
TH
37882011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3789
3790 * frame.c (delete_frame): Don't delete the terminal when the last
3791 X frame is closed if emacs is built with GTK toolkit.
3792
df85d315
JB
37932011-11-17 Juanma Barranquero <lekktu@gmail.com>
3794
3795 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3796
a0c2d0ae
MR
37972011-11-17 Martin Rudalics <rudalics@gmx.at>
3798
3799 * window.c (Vwindow_splits): Rename to
3800 Vwindow_combination_resize. Suggested by Juri Linkov.
3801 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3802 of Vwindow_splits.
3803
58179cce
JB
38042011-11-16 Juanma Barranquero <lekktu@gmail.com>
3805
7877f373
JB
3806 * nsfns.m (Fns_font_name):
3807 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3808
b6f67890
MR
38092011-11-16 Martin Rudalics <rudalics@gmx.at>
3810
3811 * window.h (window): Rename slot "nest" to "combination_limit".
3812 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3813 (Fset_window_nest): Rename to Fset_window_combination_limit.
3814 (Vwindow_nest): Rename to Vwindow_combination_limit.
3815 (recombine_windows, make_parent_window, make_window)
3816 (Fsplit_window_internal, saved_window)
3817 (Fset_window_configuration, save_window_save): Rename all
3818 occurrences of window_nest to window_combination_limit.
3819
c7015153
JB
38202011-11-15 Juanma Barranquero <lekktu@gmail.com>
3821
3822 * image.c (imagemagick_load_image): Fix typo.
3823
322ad6ec
EZ
38242011-11-14 Eli Zaretskii <eliz@gnu.org>
3825
3826 * xdisp.c (display_line): Move the call to
3827 highlight_trailing_whitespace before the call to
3828 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3829 faces of all the glyphs to compute ROW's hash value.
3830 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3831
f067b8ec
JB
38322011-11-14 Juanma Barranquero <lekktu@gmail.com>
3833
3834 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3835 just return (bug#10044).
3836
1e5b2111
EZ
38372011-11-12 Eli Zaretskii <eliz@gnu.org>
3838
7ef3cbd5
EZ
3839 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3840 with user-defined heap size. Bump the default size of the temacs
3841 heap to 27MB, to avoid memory warning when running temacs.
3842 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3843
1e5b2111
EZ
3844 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3845 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3846 (verify_row_hash) [XASSERTS]: New function.
3847 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3848 that the hash value of glyph rows is correct.
1e5b2111 3849
89d61221
MR
38502011-11-12 Martin Rudalics <rudalics@gmx.at>
3851
3852 * window.h (window): Remove splits slot.
3853 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3854 (Fdelete_other_windows_internal, make_parent_window)
3855 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3856 (Fset_window_configuration, save_window_save): Don't deal with
3857 split status of windows.
3858 (saved_window): Remove splits slot.
3859 (Vwindow_splits): Rewrite doc-string.
3860
97f18cc8
JD
38612011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3862
3863 * xfns.c (unwind_create_frame):
3864 * nsfns.m (unwind_create_frame):
3865 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3866 Vframe_list (Bug#9999).
3867
22a648b4
DA
38682011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3869
0b381c7e 3870 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3871
659afede
KH
38722011-11-11 Kenichi Handa <handa@m17n.org>
3873
3874 * callproc.c (Fcall_process): Set the member dst_multibyte of
3875 process_coding.
3876
9ac0394b
KH
38772011-11-11 Johan Bockgård <bojohan@gnu.org>
3878
3879 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3880 avoid a crash (bug#9496).
3881
2fbdc249
CY
38822011-11-09 Chong Yidong <cyd@gnu.org>
3883
3884 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3885 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3886
ac6b1f81
PE
38872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3888
3889 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3890
09db192c
PE
38912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 Avoid some portability problems by eschewing 'extern inline' functions.
3894 The trivial performance wins aren't worth the portability hassles; see
3895 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3896 et seq.
3897 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3898 (window_box_width, window_box_left, window_box_left_offset)
3899 (window_box_right, window_box_right_offset): Undo previous change,
3900 by removing the "extern"s.
3901 * intervals.c (adjust_intervals_for_insertion)
3902 (adjust_intervals_for_deletion): Undo previous change,
3903 making these static again.
3904 (offset_intervals, temp_set_point_both, temp_set_point)
3905 (copy_intervals_to_string): No longer inline.
3906 * xdisp.c (window_text_bottom_y, window_box_width)
3907 (window_box_height, window_box_left_offset)
3908 (window_box_right_offset, window_box_left, window_box_right)
3909 (window_box): No longer inline.
3910
105216ed
CY
39112011-11-08 Chong Yidong <cyd@gnu.org>
3912
3913 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3914 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3915 Signal an error if not a live window.
105216ed
CY
3916 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3917 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3918
ae9e237f
JB
39192011-11-07 Juanma Barranquero <lekktu@gmail.com>
3920
3921 * lisp.h (syms_of_abbrev): Remove declaration.
3922 Reported by CHENG Gao <chenggao@royau.me>.
3923
c7aa8333
EZ
39242011-11-07 Eli Zaretskii <eliz@gnu.org>
3925
3926 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3927 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3928 of temacs in GUI mode.
3929
be7f5545
MR
39302011-11-07 Martin Rudalics <rudalics@gmx.at>
3931
3932 * window.h: Declare delete_all_child_windows instead of
3933 delete_all_subwindows.
3934 * window.c (Fwindow_nest, Fset_window_nest)
3935 (Fset_window_new_total, Fset_window_new_normal)
3936 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3937 (delete_all_subwindows): Rename to delete_all_child_windows.
3938 (Fdelete_other_windows_internal, Fset_window_configuration):
3939 Call delete_all_child_windows instead of delete_all_subwindows.
3940 * frame.c (delete_frame): Call delete_all_child_windows instead
3941 of delete_all_subwindows.
3942
ca78dc43
PE
39432011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3946 This is also needed for porting to any host where GC_MARK_STACK is
3947 not GC_MAKE_GCPROS_NOOPS.
3948 (which_symbols): Use it.
3949
a0241d01
KH
39502011-11-07 Kenichi Handa <handa@m17n.org>
3951
3952 * coding.c (coding_set_destination): Check coding->src_pos only
3953 when coding->src_object is a buffer (bug#9910).
3954
3955 * process.c (send_process): Set the member src_multibyte of coding
3956 to 0 (bug#9911) when sending a unibyte text.
3957
3958 * callproc.c (Fcall_process): Set the member src_multibyte of
3959 process_coding to 0 (bug#9912).
3960
a64bfdfa 39612011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3962
3963 * xmenu.c (cleanup_widget_value_tree): New function.
3964 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3965 calling free_menubar_widget_value_tree directly (Bug#9830).
3966
cb41b32a
PE
39672011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3968
3969 Fix some portability problems with 'inline'.
3970 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3971 (window_box_width, window_box_left, window_box_left_offset)
3972 (window_box_right, window_box_right_offset): Declare extern.
3973 Otherwise, these inline functions do not conform to C99 and
3974 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3975 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3976 * intervals.c (adjust_intervals_for_insertion)
3977 (adjust_intervals_for_deletion): Now extern, because otherwise the
3978 extern inline functions 'offset_intervals' couldn't refer to it.
3979 (static_offset_intervals): Remove.
3980 (offset_intervals): Rewrite using the old contents of
3981 static_offset_intervals. The old version didn't conform to C99
3982 because an extern inline function contained a reference to an
3983 identifier with static linkage.
3984
b7041366
AS
39852011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3986
3987 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3988 GC.
3989
88a37c4d
EZ
39902011-11-06 Eli Zaretskii <eliz@gnu.org>
3991
3992 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3993 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3994 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3995 return Qleft_to_right.
3996
49745b39
CY
39972011-11-06 Chong Yidong <cyd@gnu.org>
3998
3999 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4000 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4001 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4002 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4003 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4004 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4005 (Fwindow_vscroll): Doc fix.
4006 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4007 argument, since it makes no sense to pass a live window and for
4008 consistency with window-child.
4009
1f05cd82
CS
40102011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4011
4012 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4013 support MSVC.
4014
22610910
JR
40152011-11-05 Jason Rumney <jasonr@gnu.org>
4016
4017 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4018 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4019 fonts (Bug#6029).
4020 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4021 bitwise arithmetic preventing use of unicode-sip and non-truetype
4022 opentype fonts.
4023
a06776b2
EZ
40242011-11-05 Eli Zaretskii <eliz@gnu.org>
4025
3ad924ba
EZ
4026 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4027 "emacs"-only part.
4028
a06776b2
EZ
4029 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4030 initialization code to keep similarity to xfns.c after changes
4031 from 2011-11-05.
4032
c9e7db78
JD
40332011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4034
a97f8f3f
JD
4035 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4036 (unwind_create_frame): New function (Bug#9943).
4037 (Fx_create_frame): Restructure code to be more similar to the one in
4038 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4039 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4040 Move terminal->reference_count++ just before making the frame official
4041 (Bug#9943).
4042
4043 * nsterm.m (x_free_frame_resources): New function.
4044 (x_destroy_window): Move code to x_free_frame_resources.
4045
c9e7db78 4046 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4047 (Fx_create_frame, x_create_tip_frame):
4048 Move terminal->reference_count++ just before making the frame
75f1671a 4049 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4050 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4051
a6fc3b5c
EZ
40522011-11-05 Eli Zaretskii <eliz@gnu.org>
4053
4054 Support MSVC build with newer versions of Visual Studio.
4055 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4056 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4057 nt/gmake.defs.
4058
4059 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4060 which are not supported by MSVC.
4061 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4062 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4063 bitfields.
4064 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4065 types in bitfields.
4066 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4067
4068 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4069
58179cce 40702011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4071
4072 Support MSVC build with newer versions of Visual Studio.
4073 * w32.c: Don't include w32api.h for MSVC.
4074 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4075
4076 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4077 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4078 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4079 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4080 e_* cousins.
4081 (alloca) [_MSC_VER]: Define to _alloca.
4082
4083 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4084
4085 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4086
a58c13ed
EZ
40872011-11-04 Eli Zaretskii <eliz@gnu.org>
4088
4089 * xdisp.c (note_mouse_highlight): If either of
4090 previous/next-single-property-change returns nil, treat that as
4091 the beginning or the end of the buffer. (Bug#9955)
4092
fe0b6370
JD
40932011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4094
a58c13ed 4095 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4096 label is not null (Bug#9951).
4097 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4098 may be NULL.
4099
89bd5ee1
EZ
41002011-11-04 Eli Zaretskii <eliz@gnu.org>
4101
4102 * window.c (Fwindow_body_size): Mention in the doc string that the
4103 return value is in frame's canonical units. (Bug#9949)
4104
84c3edb9
EZ
41052011-11-03 Eli Zaretskii <eliz@gnu.org>
4106
4e2fb5c7
EZ
4107 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4108
84c3edb9 4109 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4110 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4111 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4112
bc17a887
EZ
41132011-11-01 Eli Zaretskii <eliz@gnu.org>
4114
4115 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4116 Don't stop backward scan on the continuation glyph, even though
4117 its CHARPOS is positive.
6d5eb5b0
SM
4118 (mouse_face_from_buffer_pos, note_mouse_highlight):
4119 Rename cover_string to disp_string.
bc17a887 4120
4ee88440
MR
41212011-11-01 Martin Rudalics <rudalics@gmx.at>
4122
4123 * window.c (temp_output_buffer_show): Don't use
4124 Vtemp_buffer_show_specifiers.
4125 (Vtemp_buffer_show_specifiers): Remove unused variable.
4126
c2ff3c02
EZ
41272011-10-30 Eli Zaretskii <eliz@gnu.org>
4128
4129 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4130 past the beginning of the current glyph matrix.
4131
58179cce 41322011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4133
4134 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4135 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4136 HAVE_GTK3 (Bug#9869).
b77a6a7f 4137
3b574623
JD
4138 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4139 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4140
b77a6a7f
JD
4141 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4142
4143 * xterm.c: Declare x_handle_net_wm_state to return int.
4144 (handle_one_xevent): Check if we are iconified but don't have
4145 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4146 (get_current_wm_state): Return non-zero if not hidden,
4147 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4148 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4149 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4150 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4151
196e41e4
PE
41522011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4153
4154 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4155 so that this new function doesn't get optimized away by a
4156 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4157
021f2e1a
AS
41582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4159
4160 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4161
8b058d44
EZ
41622011-10-29 Eli Zaretskii <eliz@gnu.org>
4163
4164 Fix the `xbytecode' command.
4165 * .gdbinit (xprintbytestr): New command.
b50a28de 4166 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4167 (xbytecode): Print the byte-code string as well.
4168
4452fb80
EZ
41692011-10-29 Kim Storm <storm@cua.dk>
4170
8b058d44
EZ
4171 * alloc.c (which_symbols): New function.
4172
21b72067
AS
41732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4174
4175 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4176 line. (Bug#9903)
4177
83ed7b5c
GM
41782011-10-29 Glenn Morris <rgm@gnu.org>
4179
4180 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4181 Not clear what it was for, and it causes various bugs. (Bug#9839)
4182
5a7a728b
EZ
41832011-10-28 Eli Zaretskii <eliz@gnu.org>
4184
4185 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4186 possible random value that matches one of those tested as
4187 condition to clear the mouse face.
4188
d3d0842f
CY
41892011-10-28 Chong Yidong <cyd@gnu.org>
4190
4191 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4192
31b39d13
DN
41932011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4194
4195 * window.c (make_window): Initialize phys_cursor_on_p.
4196
9aba6043
SM
41972011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4198
4199 * lisp.h (struct Lisp_Symbol): Update comments.
4200
c20992f4
JB
42012011-10-28 Juanma Barranquero <lekktu@gmail.com>
4202
4203 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4204
db4f02f2
EZ
42052011-10-28 Eli Zaretskii <eliz@gnu.org>
4206
4207 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4208 <oslsachem@gmail.com> for helping to debug this.
4209
4210 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4211 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4212 (g_b_init_get_glyph_outline_w): New static variables.
4213 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4214 (GetGlyphOutlineW_Proc): New typedefs.
4215 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4216 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4217 New functions.
4218 (w32font_open_internal, compute_metrics):
4219 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4220 instead of calling the "wide" APIs directly.
4221
4222 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4223
4224 * w32.h (syms_of_w32font): Add prototype.
4225
87e68db4
JB
42262011-10-27 Juanma Barranquero <lekktu@gmail.com>
4227
4228 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4229 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4230 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4231 (Fmove_to_window_line): Doc fix.
4232
435c1d67
CY
42332011-10-27 Chong Yidong <cyd@gnu.org>
4234
4235 * process.c (make_process): Set gnutls_state to NULL.
4236
4237 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4238 non-NULL, regardless of GNUTLS_INITSTAGE.
4239 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4240 an error. Set process slots as soon as we allocate them.
4241
4242 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4243
9c6c6f49
CY
42442011-10-27 Chong Yidong <cyd@gnu.org>
4245
9aba6043
SM
4246 * gnutls.c (emacs_gnutls_deinit): New function.
4247 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4248 (Fgnutls_deinit, Fgnutls_boot): Use it.
4249
4250 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4251 (deactivate_process): Call emacs_gnutls_deinit.
4252
657d08d3
JB
42532011-10-27 Juanma Barranquero <lekktu@gmail.com>
4254
4255 * image.c (x_create_x_image_and_pixmap):
4256 * w32.c (sys_rename, w32_delayed_load):
4257 * w32font.c (fill_in_logfont):
4258 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4259
5430d399
JB
42602011-10-26 Juanma Barranquero <lekktu@gmail.com>
4261
4262 * w32fns.c (w32_default_color_map): New function,
4263 extracted from Fw32_default_color_map.
a7ef684b 4264 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4265
fe0055fa
PE
42662011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4267
4268 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4269
e6346438
SM
42702011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4271
4272 * keyboard.c (test_undefined): New function (bug#9751).
4273 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4274
e112cc37
ET
42752011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4276
4277 * sysdep.c (init_sys_modes): Fix the check for the controlling
4278 terminal (Bug#6649).
4279
7b5d6677
EZ
42802011-10-20 Eli Zaretskii <eliz@gnu.org>
4281
4282 * dispextern.h (struct bidi_it): New member next_en_type.
4283
4284 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4285 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4286 current character, check also for next_en_type being WEAK_EN.
4287 (bidi_resolve_weak): Don't enter the expensive loop if the current
4288 position is before next_en_pos. Record the bidi type of the first
4289 non-ET, non-BN character we find, in addition to its position.
4290 (bidi_level_of_next_char): Invalidate next_en_type when
4291 next_en_pos is over-stepped.
4292
7da0b018
PE
42932011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4296 * editfns.c: Rewrite current-time-zone so that it invokes
4297 the equivalent of (format-time-string "%Z") to get the time zone name.
4298 This fixes a bug when the time zone name contains characters that
4299 need converting from the system time locale to Emacs internal format.
4300 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4301 that patch fixed format-time-string to do the conversion, but
4302 I forgot to fix current-time-zone.
4303 (format_time_string): New function, containing most of
4304 what Fformat_time_string used to contain.
4305 (Fformat_time_string): Rewrite in terms of format_time_string.
4306 This doesn't change this function's behavior.
4307 (current-time-zone): Rewrite to use format_time_string.
4308 This fixes the bug reported by Michael Schierl in
4309 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4310 Jason Rumney's 2007-06-07 change worked around this bug, but
4311 didn't fix it.
4312 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4313
8547b010
EZ
43142011-10-19 Eli Zaretskii <eliz@gnu.org>
4315
4316 * xdisp.c (start_display): If the character at POS is displayed
4317 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4318 (try_window_reusing_current_matrix): If a line ends in a display
4319 vector or the next line starts in a display vector, continue
4320 redrawing the window even though the character position of
4321 start_row was reached.
8547b010
EZ
4322 (Bug#9771, part 2)
4323
4e948d15
CY
43242011-10-18 Chong Yidong <cyd@gnu.org>
4325
4326 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4327 with nobreak-char-display too.
4328
4787455f
EZ
43292011-10-18 Eli Zaretskii <eliz@gnu.org>
4330
4331 Fix part 3 of bug#9771.
4332 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4333 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4334 non-neutral characters if the current character is a paragraph
4335 separator (a.k.a. Newline). This avoids running the same
4336 expensive loop twice, once when we consume the preceding newline
4337 and the other time when the line actually needs to be displayed.
4338 Avoid the loop when we see neutrals on the base embedding level
4339 following a character whose directionality is the same as the
4340 paragraph's. This avoids running the expensive loop when a line
4341 ends in a long sequence of neutrals, like control characters.
4342 Add assertion against STRONG_AL type. Slightly rearrange code
4343 that determines the type of a neutral given the first non-neutral
4344 that follows it.
4345 (bidi_level_of_next_char): Set next_en_pos to zero when
4346 invalidating its info.
4347
2c91f553
EZ
43482011-10-17 Eli Zaretskii <eliz@gnu.org>
4349
4350 * xdisp.c (push_display_prop): Determine whether to record string
4351 or buffer position by IT->string, not by IT->method. Allow
4352 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4353 (move_it_vertically_backward): Don't look for character position
4354 immediately after the newline when in a continuation line.
4355 (Bug#9771, part 1)
2c91f553 4356
c7b08b0d
MR
43572011-10-15 Martin Rudalics <rudalics@gmx.at>
4358
4359 * window.c (coordinates_in_window): Rewrite and delabelize
4360 vertical border check. (Bug#5357) (Bug#9618)
4361
6b02f655
SM
43622011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4363
4364 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4365 errors in XSetWindowBorder (bug#9310).
4366
81d40c92
DA
43672011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4368
4369 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4370 avoid crash when xmalloc overrun checking is enabled.
4371
d4172c3b
EZ
43722011-10-13 Eli Zaretskii <eliz@gnu.org>
4373
4374 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4375 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4376 cursor motion with <left> and <right> arrow keys.
4377
4378 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4379 some callers set that themselves.
4380
b00eea75
EZ
43812011-10-12 Eli Zaretskii <eliz@gnu.org>
4382
4383 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4384 display string and the previous row comes from the same string and
4385 is empty. (Bug#9739) (Bug#9738)
4386
8fe012c4
SM
43872011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4388
4389 * doc.c (get_doc_string): Encode file name (bug#9735).
4390
0074aef2
EZ
43912011-10-12 Eli Zaretskii <eliz@gnu.org>
4392
79beb178
EZ
4393 * bidi.c (bidi_level_of_next_char):
4394 * xdisp.c (get_visually_first_element): Remove old incorrect
4395 comments regarding the Unicode Line Separator character.
4396
0074aef2
EZ
4397 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4398
6e4b3fbe
DA
43992011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4400
4401 * alloc.c (Fgc_status): Do not access beyond zombies array
4402 boundary if nzombies > MAX_ZOMBIES.
4403 * alloc.c (dump_zombies): Add missing format specifier.
4404
0324f3af
PE
44052011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4406
b5525cac
PE
4407 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4408 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4409
0324f3af
PE
4410 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4411 Some packages use them to denote characters with modifiers.
4412
e9b5f888
AS
44132011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4414
4415 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4416 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4417 matching a pp-number. Rename parameter var to var1.
4418
127827c0
SM
44192011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4420
4421 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4422
c8fd3bd0
GM
44232011-10-08 Glenn Morris <rgm@gnu.org>
4424
4425 * callint.c (Fcall_interactively): Give a more explicit error for the
4426 'c' case with a non-character input. (Bug#8479)
4427
352ec8ff
EZ
44282011-10-08 Eli Zaretskii <eliz@gnu.org>
4429
03669ccb
EZ
4430 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4431 lines.
7061c986
EZ
4432 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4433 lines that are hscrolled on the left.
03669ccb 4434
352ec8ff
EZ
4435 * dispnew.c (buffer_posn_from_coords): Account for a possible
4436 presence of header-line. (Bug#4426)
4437
a66cfb1c
SM
44382011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4439
6b02f655
SM
4440 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4441 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4442
7c5ee88e
PE
44432011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4444
4445 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4446 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4447 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4448 this makes Emacs dump core during garbage collection on rare
4449 occasions. sizeof is obviously inferior to offsetof here, so
4450 stick with offsetof.
4451 (GC_POINTER_ALIGNMENT): New macro.
4452 (mark_memory): Omit 3rd (offset) arg; caller changed.
4453 Don't assume EMACS_INT alignment is the same as pointer alignment.
4454
df1bbe5b
SM
44552011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4456
4457 * keyboard.c (read_key_sequence_remapped): New var.
4458 (read_key_sequence): Compute remapping in the right buffer.
4459 (command_loop_1): Use read_key_sequence's remapping directly.
4460
51553db6
SM
44612011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4462
32c1fffd
SM
4463 * dired.c (file_name_completion): Don't expand file name.
4464 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4465 before checking file name handler.
4466
51553db6
SM
4467 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4468 they've been requested explicitly (bug#9591).
4469
b6bd1599 44702011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4471
4472 * keymap.c (Fsingle_key_description): Use make_specified_string
4473 instead of build_string to build string from push_key_description.
4474 (Bug#5193)
4475
f701dc2a
PE
44762011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4477
4222c55d
PE
4478 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4479 This fixes a Y2038 bug on 64-bit hosts.
4480 * buffer.c (reset_buffer):
4481 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4482 (Fclear_buffer_auto_save_failure):
4483 Use 0, not -1, to represent an unset failure time, since time_t
4484 might not be signed.
4485
f701dc2a
PE
4486 Remove dependency on glibc malloc internals.
4487 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4488 Move back here from lisp.h, but with their new implementations.
4489 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4490 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4491 * charset.c (charset_table_init): New static var.
4492 (syms_of_charset): Use it instead of xmalloc. This removes a
4493 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4494 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4495 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4496 Move back to alloc.c.
4497 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4498 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4499
9ceebf39
JD
45002011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4501
4502 * nsterm.m (windowDidResize): Call x_set_window_size only when
4503 ns_in_resize is true. Otherwise set pixelwidth/height and
4504 call change_frame_size (Bug#9628).
4505
cb993c58
PE
45062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4507
3930c88b
PE
4508 Port --enable-checking=all to Fedora 14 x86-64.
4509 * charset.c (syms_of_charset): Also account for glibc malloc's
4510 internal overhead when calculating the initial malloc maximum.
4511
cb993c58
PE
4512 Port --enable-checking=all to Fedora 14 x86.
4513 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4514 Move to lisp.h.
4515 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4516 (overrun_check_realloc, overrun_check_free):
4517 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4518 That way, xmalloc returns a properly-aligned pointer even if
4519 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4520 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4521 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4522 into account when calculating the initial malloc maximum.
4523 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4524 Move here from alloc.c, so that charset.c can use it too.
4525 Properly align; the old code wasn't right for common 32-bit hosts
4526 when configured with --enable-checking=all.
4527 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4528 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4529
31bed486
EZ
45302011-09-29 Eli Zaretskii <eliz@gnu.org>
4531
04c70788 4532 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4533 use EDOM.
4534
fbcaa2f3
EZ
45352011-09-28 Eli Zaretskii <eliz@gnu.org>
4536
4537 * xdisp.c (compute_display_string_end): If there's no display
4538 string at CHARPOS, return -1.
4539
4540 * bidi.c (bidi_fetch_char): When compute_display_string_end
4541 returns a negative value, treat the character as a normal
4542 character not covered by a display string. (Bug#9624)
4543
a239d4e9
JB
45442011-09-28 Juanma Barranquero <lekktu@gmail.com>
4545
4546 * lread.c (Fread_from_string): Fix typo in docstring.
4547
88652fd5
EZ
45482011-09-27 Eli Zaretskii <eliz@gnu.org>
4549
4550 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4551 newline, reseat the iterator instead of bidi-iterating there one
4552 character at a time. (Bug#9610)
32c1fffd
SM
4553 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4554 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4555
ed497dd4
AS
45562011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4557
4558 * lread.c (readevalloop): Use correct code for NBSP.
4559 (read1): Likewise. (Bug#9608)
4560
b2bf61aa
MA
45612011-09-25 Michael Albinus <michael.albinus@gmx.de>
4562
4563 * dbusbind.c (Fdbus_register_signal): When service is not
4564 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4565
32bbb17c
GM
45662011-09-25 Glenn Morris <rgm@gnu.org>
4567
4568 * buffer.c (truncate-lines): Doc fix.
4569
94e0933e
CY
45702011-09-24 Chong Yidong <cyd@stupidchicken.com>
4571
4572 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4573 (Fset_window_next_buffers): Doc fix.
4574
cddde921
GM
45752011-09-24 Glenn Morris <rgm@gnu.org>
4576
4577 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4578
1260aef1
PE
45792011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4580
25b4bfa0
PE
4581 Fix minor problems found by static checking.
4582 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4583 * indent.c (Fvertical_motion): Fix == vs = typo.
4584
e3cbd34b
EZ
45852011-09-24 Eli Zaretskii <eliz@gnu.org>
4586
a66cfb1c
SM
4587 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4588 Default value is now t. Doc fix.
6bf7006f 4589
e3cbd34b 4590 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4591 logic when moving up, not only when moving down. Fix the
e3cbd34b 4592 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4593 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4594
4595 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4596 CHARPOS is covered by a display string which includes newlines.
4597 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4598 is covered by a display string with embedded newlines.
4599
a3de0cbd
MA
46002011-09-24 Michael Albinus <michael.albinus@gmx.de>
4601
4602 * dbusbind.c (Fdbus_register_signal): Add match rule to
4603 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4604 (Fdbus_register_method, Vdbus_registered_objects_table):
4605 Fix docstring.
a3de0cbd 4606
b260039d
JM
46072011-09-24 Jim Meyering <meyering@redhat.com>
4608
32c1fffd 4609 do not ignore write error for any output size
b260039d
JM
4610 The previous change was incomplete.
4611 While it makes emacs --batch detect the vast majority of stdout
4612 write failures, errors were still ignored whenever the output size is
4613 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4614 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4615 && echo FAIL: ignored write error
4616 FAIL: ignored write error
4617 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4618 && echo FAIL: ignored write error
4619 FAIL: ignored write error
4620 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4621
8eca8a7c
AS
46222011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4623
4624 * emacs.c (Fkill_emacs): In noninteractive mode exit
4625 non-successfully if a write error occurred on stdout. (Bug#9574)
4626
3341db62
EZ
46272011-09-21 Eli Zaretskii <eliz@gnu.org>
4628
4629 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4630 the xassert test.
4631
4632 * dispextern.h (struct it): Update the comment documenting what
4633 can it->OBJECT be.
4634
8c203dbf
EZ
46352011-09-20 Eli Zaretskii <eliz@gnu.org>
4636
4637 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4638 a display string, extend search for cursor position to end of row.
4639 (find_row_edges): If the row ends in a newline from a display
4640 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4641 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4642 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4643 non-empty line. Fixes confusing cursor motion with arrow keys at
4644 the beginning of a line that starts with whitespace.
8c203dbf 4645
a4824228
LMI
46462011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4647
4648 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4649 (bug#9493).
4650
33ed493b
CY
46512011-09-18 Chong Yidong <cyd@stupidchicken.com>
4652
4653 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4654 boolean (Bug#9154).
4655
56cd55c8
EZ
46562011-09-18 Eli Zaretskii <eliz@gnu.org>
4657
4658 * xdisp.c (display_line): Record maximum and minimum buffer
4659 positions even if no glyphs were produced (e.g., by a zero-width
4660 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4661 buffer positions that will be removed from the glyph row because
4662 they don't fit.
c02dcedf
EZ
4663 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4664 column is beyond frame width: don't subtract 1 "pixel" when
4665 computing width of the stretch.
3e62b7e0
EZ
4666 (reseat_at_next_visible_line_start): Undo the change made on
4667 2011-09-17 that saved paragraph information and restored it after
4668 the call to `reseat'. (Bug#9545)
56cd55c8 4669
5ed99d36 46702011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4671
4672 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4673 and turn window cursor on if cleared (Bug#9415).
4674
5ed99d36 46752011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4676
4677 * search.c (boyer_moore): Take unibyte characters from pattern
4678 literally. (Bug#9458)
4679
9bade7b2
EZ
46802011-09-18 Eli Zaretskii <eliz@gnu.org>
4681
4682 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4683
e5e9d610
PE
46842011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4685
87e4427a
PE
4686 Fix minor problem found by static checking.
4687 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4688 initialized, to pacify gcc -Wuninitialized.
4689
e5e9d610
PE
4690 * fileio.c: Report proper errno when syscall falls.
4691 (Finsert_file_contents): Save and restore errno,
4692 so that report_file_error outputs the correct diagnostic.
4693 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4694
a1674f0b
EZ
46952011-09-18 Eli Zaretskii <eliz@gnu.org>
4696
4697 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4698
fbfb6dd4
EZ
46992011-09-17 Eli Zaretskii <eliz@gnu.org>
4700
4701 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4702 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4703
bb187662
EZ
47042011-09-17 Eli Zaretskii <eliz@gnu.org>
4705
1137e8b8 4706 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4707 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4708
4709 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4710 (bidi_find_paragraph_start): Search back for paragraph beginning
4711 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4712 (bidi_move_to_visually_next): Only trigger paragraph-related
4713 computations when the last character is a newline or at EOB, not
4714 just any NEUTRAL_B. (Bug#9470)
4715
bb187662
EZ
4716 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4717 truncated lines if point is covered by a display string. (Bug#9524)
4718
2e621251
PE
47192011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4720
4721 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4722 (cons_to_x_long): New function.
4723 (lisp_data_to_selection_data): Use it. Correct the test for
4724 short-versus-long data; it was negated. Break out of vector
4725 loop, for efficiency, when a long datum is discovered.
4726
91a15bc6
SM
47272011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4728
4729 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4730
b41c3a35
EZ
47312011-09-16 Eli Zaretskii <eliz@gnu.org>
4732
4733 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4734 GCC PR/17406) by declaring this function with external scope.
4735
7812ba2d
PE
47362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4737
4738 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4739 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4740
cf7edc2a
AS
47412011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4742
4743 * editfns.c (Fformat): Correctly handle text properties on "%%".
4744
bd01620e
EZ
47452011-09-15 Eli Zaretskii <eliz@gnu.org>
4746
4747 * xterm.c (x_draw_composite_glyph_string_foreground):
4748 * w32term.c (x_draw_composite_glyph_string_foreground):
4749 * term.c (encode_terminal_code):
4750 * composite.c (composition_update_it, get_composition_id):
4751 * xdisp.c (get_next_display_element)
4752 (fill_composite_glyph_string): Add comments about special meaning
4753 of TAB characters in a composition.
4754
a02719a3
PE
47552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4756
4757 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4758 This occurs when processing a multibyte format.
4759 Problem reported by Wolfgang Jenker.
a02719a3 4760
72589a3c
JB
47612011-09-15 Johan Bockgård <bojohan@gnu.org>
4762
4763 * xdisp.c (try_cursor_movement): Only check for exact match if
4764 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4765
1c14176c
PE
47662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4767
4768 Remove unused external symbols.
4769 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4770 * xdisp.c (calc_pixel_width_or_height): Now static.
4771 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4772 * indent.c (check_display_width):
4773 * w32term.c: Fix comment to match code.
4774 * xterm.c, xterm.h (x_catching_errors): Remove.
4775
d2eea5b5
PE
47762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4777
4778 * xselect.c: Use signed conversions more consistently (Bug#9498).
4779 (selection_data_to_lisp_data): Assume incoming selection data are
4780 signed integers, not unsigned. This is to be consistent with
4781 outgoing selection data, which was modified to use signed integers
4782 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4783 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4784 expects long, not unsigned long.
4785
46888499
EZ
47862011-09-14 Eli Zaretskii <eliz@gnu.org>
4787
4788 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4789 computation of loop end. Reported by Johan Bockgård
4790 <bojohan@gnu.org>.
4791
ef8ef9fb
CY
47922011-09-13 Chong Yidong <cyd@stupidchicken.com>
4793
4794 * frame.c (Fother_visible_frames_p): Function deleted.
4795
fa819fed
EZ
47962011-09-12 Eli Zaretskii <eliz@gnu.org>
4797
4798 * indent.c (compute_motion): Process display vector front to back
4799 rather than the other way around. (Bug#2496)
4800
2ba8e008
SM
48012011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4802
4803 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4804
20f53c69
CY
48052011-09-11 Chong Yidong <cyd@stupidchicken.com>
4806
4807 * minibuf.c (Fread_from_minibuffer): Doc fix.
4808
d562d7a4
EZ
48092011-09-11 Eli Zaretskii <eliz@gnu.org>
4810
4811 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4812 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4813
1c4d7f3d
LMI
48142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4815
4816 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4817 value for non-existent files.
4818
b885bf36
EZ
48192011-09-11 Eli Zaretskii <eliz@gnu.org>
4820
4821 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4822 set its "size" to -1. This will set the modtime_size field of
4823 the corresponding buffer to -1, which is what
4824 verify-visited-file-modtime expects for files that do not exist.
4825 (Bug#9139)
4826
6612f0bf
PE
48272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4828
4829 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4830 here ...
4831 * lisp.h: ... from here. push_key_description is no longer
4832 defined in keyboard.c, so its declaration should not be in
4833 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4834 logically belongs with push_key_description.
4835
dfb3f755
PE
48362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 * buffer.h: Include <sys/types.h> instead of <time.h>.
4839 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4840 Problem reported by Herbert J. Skuhra.
4841
3134906c
LMI
48422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4843
4844 * xml.c (parse_region): Make the parsing work for
4845 non-comment-starting XML files again (bug#9144).
4846
8d903f4e
AS
48472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4848
4849 * image.c (gif_load): Fix calculation of bottom and right corner.
4850 (Bug#9468)
4851
80ad64f4
EZ
48522011-09-10 Eli Zaretskii <eliz@gnu.org>
4853
4854 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4855 redisplay in small windows.
4856
208a048d
EZ
48572011-09-09 Eli Zaretskii <eliz@gnu.org>
4858
4859 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4860
9b1c252e
MR
48612011-09-08 Martin Rudalics <rudalics@gmx.at>
4862
4863 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4864 Operate on live windows only.
4865
2949f33b
JB
48662011-09-08 Juanma Barranquero <lekktu@gmail.com>
4867
4868 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4869
e08dcafd
EZ
48702011-09-07 Eli Zaretskii <eliz@gnu.org>
4871
4872 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4873 only under bidi iteration.
4874
115b96bd
JD
48752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4876
4877 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4878
c8199d0f
PE
48792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4880
4881 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4882 Without this fix, the command to link temacs failed due to an
4883 undefined symbol __builtin_isnan. This is because
4884 /usr/include/iso/math_c99.h #defines isnan(x) to
4885 __builtin_isnan(x), but the bundled gcc, which identifies itself
4886 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4887 a __builtin_isnan.
4888 * floatfns.c (isnan): #undef, and then #define to a clone of
4889 what's in data.c.
4890 (Fisnan): Always define, since it's always available now.
4891 (syms_of_floatfns): Always define isnan at the Lisp level.
4892
e39b275c 48932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4894
4895 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4896
b2db44d9 48972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4898
f4af5137 4899 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4900 The previous code assumed that file offsets (off_t values) fit in
4901 EMACS_INT variables, which is not true on typical 32-bit hosts.
4902 The code messed up by falsely reporting buffer overflow in cases
4903 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4904 when "big" contains more than 2**29 bytes, even though this
4905 inserts just one byte and does not overflow the buffer.
4906 (Finsert_file_contents): Store file offsets as off_t
4907 values, not as EMACS_INT values. Check for overflow when
4908 converting between EMACS_INT and off_t. When checking for
4909 buffer overflow or for overlap, take the offsets into account.
4910 Don't use EMACS_INT for small values where int suffices.
4911 When checking for overlap, fix a typo: ZV was used where
4912 ZV_BYTE was intended.
4913 (Fwrite_region): Don't assume off_t fits into 'long'.
4914 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4915
ecfc0a49
MA
49162011-09-05 Michael Albinus <michael.albinus@gmx.de>
4917
4918 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4919
6511acf2 49202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4921
0999621a 4922 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4923
4924 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4925 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4926 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4927 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4928 (modify_event_symbol): Do not assume that the length of
4929 name_alist_or_stem is safe to alloca and fits in int.
4930 (Fexecute_extended_command): Likewise for function name and binding.
4931 (Frecursion_depth): Wrap around reliably on integer overflow.
4932 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4933 since some callers pass EMACS_INT values.
4934 (Fsingle_key_description): Don't crash if symbol name contains more
4935 than MAX_ALLOCA bytes.
4936 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4937 (get_minibuffer): Arg is now EMACS_INT, not int.
4938 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4939 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4940 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4941
2be7d702
PE
4942 * dbusbind.c (signature_cat): New function.
4943 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4944 Do not overrun buffer; instead, report string overflow.
4945
9d1df220
PE
4946 * dispnew.c (add_window_display_history): Don't overrun buffer.
4947 Truncate instead; this is OK since it's just a log.
4948
33ef5c64
PE
4949 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4950 even if the time zone offset is outlandishly large.
4951 Don't mishandle offset == INT_MIN.
4952
66c6fdd5
PE
4953 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4954 when creating daemon; the previous buffer-overflow check was incorrect.
4955
d749b01b
PE
4956 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4957 which has the guts of the old verror function.
4958
b5cd1905
PE
4959 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4960 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4961
6e1a67fb
PE
4962 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4963 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4964 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4965 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4966 length of string rather than counting it via multiple sprintfs;
4967 that's simpler and more reliable.
c21721cc
PE
4968 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4969 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4970 sprintf, in case result does not fit in int.
4971
c57b67fc
PE
4972 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4973 (fontset_from_font): Print it.
4974
8a401434
PE
4975 * frame.c (tty_frame_count): Now printmax_t, not int.
4976 (make_terminal_frame, set_term_frame_name): Print it.
4977 (x_report_frame_params): In X, window IDs are unsigned long,
4978 not signed long, so print them as unsigned.
4979 (validate_x_resource_name): Check for implausibly long names,
4980 and don't assume name length fits in 'int'.
4981 (x_get_resource_string): Don't blindly alloca invocation name;
4982 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4983 not fit in int.
4984
6e1a67fb
PE
4985 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4986 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4987 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4988
0df02bf3
PE
4989 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4990 Use esprintf, not sprintf, in case result does not fit in int.
4991
48e30793
PE
4992 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4993 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4994 it as a large positive number.
4995 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4996 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4997
a66ff6d8
PE
4998 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4999 in case result does not fit in int.
5000
aca216ff
PE
5001 * print.c (float_to_string): Detect width overflow more reliably.
5002 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5003 buffer overrun. Don't assume list length fits in 'int'. Treat
5004 print length of 0 as 0, not as infinity; to be consistent with other
5005 uses of print length in this function. Don't overflow print length
5006 index. Don't assume hash table size fits in 'long', or that
5007 vectorlike size fits in 'unsigned long'.
5008
31c286f7
PE
5009 * process.c (make_process): Use printmax_t, not int, to format
5010 process-name gensyms.
5011
55e5faa1
PE
5012 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5013
80f2e268
PE
5014 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5015 to avoid potential buffer overrun.
5016
670741ab
PE
5017 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5018 if X resource line is longer than 512 bytes.
5019
b7163a50
PE
5020 * xfns.c (x_window): Make sprintf buffer a bit bigger
5021 to avoid potential buffer overrun.
5022
ae58ff1f
PE
5023 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5024
c43c8a6a
PE
5025 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5026
3f8236f4
PE
50272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5028
53e9fe90 5029 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5030 Without these, Emacs silently mishandles large integers sometimes.
5031 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5032 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5033
6511acf2
PE
5034 * xdisp.c (try_window_id): Check Emacs fixnum range before
5035 converting to 'int'.
806add1d 5036
6511acf2 5037 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5038 Check that an Emacs fixnum is in range before assigning it to 'int'.
5039 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5040 values converted from Emacs fixnums.
5041 (Frecenter): Don't wrap around a line count if it is out of 'int'
5042 range; instead, treat it as an extreme value.
5043 (Fset_window_configuration, compare_window_configurations):
5044 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5045
6511acf2
PE
5046 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5047 that can exceed INT_MAX. Check that EMACS_INT value is in range
5048 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5049 (match_limit): Don't assume that a fixnum can fit in 'int'.
5050
6511acf2 5051 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5052 exceed INT_MAX.
5053
6511acf2 5054 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5055 (Fvertical_motion): Don't wrap around LINES values that don't fit
5056 in 'int'. Instead, treat them as extreme values. This is good
5057 enough for windows, which can't have more than INT_MAX lines anyway.
5058
fcb901a7
LMI
50592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5060
0f2f6b6d
LMI
5061 * Require libxml/parser.h to avoid compilation warning.
5062
fcb901a7
LMI
5063 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5064
5065 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5066 since this reportedly can destroy thread storage.
5067
6e20a0d4
CY
50682011-08-30 Chong Yidong <cyd@stupidchicken.com>
5069
5070 * syntax.c (find_defun_start): Update all cache variables if
5071 exiting early (Bug#9401).
5072
148ae00e
EZ
50732011-08-30 Eli Zaretskii <eliz@gnu.org>
5074
f6cfbd8f
EZ
5075 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5076
148ae00e
EZ
5077 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5078 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5079 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5080
5081 * term.c (tty_append_glyph): New function.
5082 (produce_stretch_glyph): Static function and its prototype deleted.
5083
a66cfb1c
SM
5084 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5085 Add prototypes.
148ae00e 5086
c4a07a4c
PE
50872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5088
5089 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5090 when checking :margin (Bug#9390).
5091 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5092 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5093 so that the name doesn't mislead. All uses changed.
5094
6bc8cd65
JB
50952011-08-28 Johan Bockgård <bojohan@gnu.org>
5096
5097 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5098 set_tty_hooks.
5099
dca4927e
EZ
51002011-08-27 Eli Zaretskii <eliz@gnu.org>
5101
5102 * xdisp.c (move_it_to): Don't bail out early when reaching
5103 position beyond to_charpos, if we are scanning backwards.
5104 (move_it_vertically_backward): When DY == 0, make sure we get to
5105 the first character in the line after the newline.
5106
f2cad773
PE
51072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5110 (ccl_driver): Do not generate an out-of-range pointer.
5111 (Fccl_execute_on_string): Remove unnecessary check for
5112 integer overflow, noted by Stefan Monnier in
5113 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5114 Remove a FIXME that didn't need fixing.
5115 Simplify the newly-introduced buffer reallocation code.
5116
0cae2cdb
JB
51172011-08-27 Juanma Barranquero <lekktu@gmail.com>
5118
5119 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5120
5fc295a4 51212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5122
70c60eb2 5123 Integer and memory overflow issues (Bug#9196).
726e0ab1 5124
d31850da
PE
5125 * doc.c (get_doc_string): Rework so that
5126 get_doc_string_buffer_size is the actual buffer size, rather than
5127 being 1 less than the actual buffer size; this makes xpalloc more
5128 convenient.
5129
a69fbedb
PE
5130 * image.c (x_allocate_bitmap_record, cache_image):
5131 * xselect.c (Fx_register_dnd_atom):
5132 Simplify previous changes by using xpalloc.
5133
fe5c5d37
PE
5134 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5135 since either will do and ptrdiff_t is convenient with xpalloc.
5136
0065d054
PE
5137 * charset.c (charset_table_size)
5138 (struct charset_sort_data.priority): Now ptrdiff_t.
5139 (charset_compare): Don't overflow if priorities differ greatly.
5140 (Fsort_charsets): Don't assume list length fits in int.
5141 Check for size-calculation overflow when allocating sort data.
5142 (syms_of_charset): Allocate an initial charset table that is
5143 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5144
5145 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5146
5147 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5148 The actual value is always <= INT_MAX, and leaving it unsigned made
5149 overflow checking harder.
5150
5151 * dispextern.h (struct glyph_matrix.rows_allocated)
5152 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5153 with xpalloc. The values are still always <= INT_MAX.
5154
5155 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5156
5157 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5158 (SAFE_NALLOCA): New macro.
5159
5160 * region-cache.c (struct boundary.pos, find_cache_boundary)
5161 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5162 (set_cache_region, invalidate_region_cache)
5163 (revalidate_region_cache, know_region_cache, region_cache_forward)
5164 (region_cache_backward, pp_cache):
5165 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5166 so that ptrdiff_t * can be passed to xpalloc.
5167 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5168 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5169 (pp_cache): Don't assume cache_len fits in int.
5170 * region-cache.h: Adjust extern decls to match.
5171
5172 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5173 EMACS_INT, since either will do, for xpalloc.
5174
5175 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5176 (xnmalloc, xnrealloc, xpalloc): New functions.
5177
726e0ab1
PE
5178 * bidi.c (bidi_shelve_header_size): New constant.
5179 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5180 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5181
51f30bc5 5182 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5183 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5184 (overlay_strings):
5185 Don't update size of array until after memory allocation succeeds,
5186 because xmalloc/xrealloc may not return.
0065d054
PE
5187 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5188 now that we have proper integer overflow checking.
5189 (record_overlay_string, overlay_strings): Catch overflows when
5190 calculating size of overlay_str_buf.
726e0ab1 5191
0065d054
PE
5192 * callproc.c (Fcall_process): Check for size overflow when
5193 calculating size of args2.
5194 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5195 Normally we prefer signed values, but sticking with ptrdiff_t would
5196 require adding more-complicated checks.
726e0ab1
PE
5197
5198 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5199 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5200 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5201 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5202
5203 * character.c (Fstring): Check for size-calculation overflow.
5204
5205 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5206 unnecessary integer overflow. Check for size overflow.
5207 (encode_coding_object): Don't update size until xmalloc succeeds.
5208
5209 * composite.c (get_composition_id): Check for overflow in glyph
5210 length calculations.
5211
5212 Integer and memory overflow fixes for display code.
5213 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5214 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5215 (scrolling_window): Check for overflow in size calculations.
5216 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5217 Don't assume glyph table len fits in int.
5218 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5219 (row_table_size): Now ptrdiff_t, not int.
5220 (scrolling_window): Avoid overflow in size calculations.
5221 Don't update size until allocation succeeds.
5222 * fns.c (concat): Check for overflow in size calculations.
5223 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5224 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5225 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5226
5227 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5228 (get_doc_string): Check for size calculation overflow.
5229 Don't update size until allocation succeeds.
5230 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5231 EMACS_INT, where ptrdiff_t will do.
5232 (Fsubstitute_command_keys): Check for string overflow.
5233
5234 * editfns.c (set_time_zone_rule): Don't assume environment length
5235 fits in int.
5236 (message_length): Now ptrdiff_t, not int.
5237 (Fmessage_box): Don't update size until allocation succeeds.
5238 Don't assume message length fits in int.
5239 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5240
0065d054
PE
5241 * emacs.c (main): Do not reallocate argv, since there is a null at
5242 the end that can be overwritten, and this way there's no need to
5243 worry about size-calculation overflow.
5244 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5245
5246 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5247 alloc succeeds.
5248 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5249
5250 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5251 (x_set_scroll_bar_width, x_figure_window_size):
5252 Check for integer overflow.
5253 (x_set_alpha): Do not assume XINT fits in int.
5254
5255 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5256 This is for the members text_lines, text_cols, total_lines, total_cols,
5257 where the system imposes an 'int' limit.
5258
5259 * fringe.c (Fdefine_fringe_bitmap):
5260 Don't update size until alloc works.
5261
5262 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5263 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5264
5265 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5266 Check for size-calculation overflow.
5267 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5268 do, as we prefer signed integers.
5269 (id_to_widget.max_size, id_to_widget.used)
5270 (xg_store_widget_in_map, xg_remove_widget_from_map)
5271 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5272 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5273 Use and return ptrdiff_t, not int.
5274 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5275 * gtkutil.h: Change prototypes to match the above.
5276
5277 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5278 are duplicate now that they've been promoted to lisp.h.
5279 (x_allocate_bitmap_record, x_alloc_image_color)
5280 (make_image_cache, cache_image, xpm_load):
5281 Don't update size until alloc is done.
5282 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5283 (x_detect_edges):
3256efce 5284 Check for size calculation overflow.
726e0ab1
PE
5285 (ct_colors_allocated_max): New constant.
5286 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5287 overflow.
3256efce 5288
726e0ab1
PE
5289 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5290 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5291 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5292 Use ptrdiff_t, not int, to count maps.
5293 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5294 calculations. Don't update size until allocation succeeds.
5295 Redo calculations to avoid overflow.
726e0ab1
PE
5296 * keyboard.h: Change prototypes to match the above.
5297
5298 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5299 to count maps.
5300 (current_minor_maps): Check for size calculation overflow.
5301 * keymap.h: Change prototypes to match the above.
5302
5303 * lread.c (read1, init_obarray): Don't update size until alloc done.
5304
5305 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5306 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5307
726e0ab1
PE
5308 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5309 Now ptrdiff_t, not int.
5310 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5311 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5312
5313 * process.c (Fnetwork_interface_list): Check for overflow
5314 in size calculation.
5315
5316 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5317
5318 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5319 overflow. Don't bother calling xmalloc when xrealloc will do.
5320
5321 * search.c (Freplace_match): Check for size calculation overflow.
5322 (Fset_match_data): Don't assume list lengths fit in 'int'.
5323
5324 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5325 for command line length. Do not attempt to address one before the
5326 beginning of an array, as that's not portable.
5327
5328 * term.c (max_frame_lines): Remove; unused.
5329 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5330 not int.
5331 (encode_terminal_code, calculate_costs): Check for size
5332 calculation overflow.
5333 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5334 table lengths and related sizes. Don't update size until alloc
5335 done. Redo calculations to avoid overflow.
5336 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5337
5338 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5339 subtracting pointers.
5340 (gobble_line): Check for overflow more carefully. Don't update size
5341 until alloc done.
5342
5343 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5344 Don't update size until alloc done.
5345 Redo size calculations to avoid overflow.
5346 Check for size calculation overflow.
0065d054 5347 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5348
5349 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5350 Use ptrdiff_t, not int, for sizes.
5351 (store_mode_line_noprop_char): Don't update size until alloc done.
5352
0065d054
PE
5353 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5354 Use ptrdiff_t, not int, for sizes.
5355 (Finternal_make_lisp_face, cache_face):
5356 Check for size calculation overflow.
5357 (cache_face): Treat size calculation overflows as if they were
5358 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5359
5360 * xfns.c (x_encode_text, x_set_name_internal)
5361 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5362 sizes, since they can exceed INT_MAX in size. Check for size
5363 calculation overflow.
5364
0065d054
PE
5365 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5366 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5367 Don't update size until alloc done.
5368
0065d054 5369 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5370 as sprintf is limited to int lengths.
1d526e2f 5371
252c5ee1
PE
5372 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5373 (X_LONG_MIN): New macros.
864d7ce7
PE
5374 Use them to make the following changes clearer.
5375 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5376 This change doesn't affect the value now, but it may help remind
5377 future maintainers not to raise the value too much later.
5378 (SELECTION_QUANTUM): Remove, replacing with ...
5379 (selection_quantum): ... new function, which avoids overflow.
5380 All uses changed.
5381 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5382 assumption that selection length fits in 'int'.
5383 (x_reply_selection_request, x_handle_selection_request)
5384 (x_get_window_property, receive_incremental_selection)
5385 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5386 (lisp_data_to_selection_data, clean_local_selection_data):
5387 Use ptrdiff_t, not int, to record length of selection.
5388 (x_reply_selection_request, x_get_window_property)
5389 (receive_incremental_selection, x_property_data_to_lisp):
5390 Redo calculations to avoid overflow.
5391 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5392 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5393 something.
5394 (x_get_window_property, receive_incremental_selection)
5395 (lisp_data_to_selection_data, x_property_data_to_lisp):
5396 Check for size-calculation overflow.
5397 (x_get_window_property, receive_incremental_selection)
5398 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5399 Don't store size until memory allocation succeeds.
5400 (x_get_window_property): Plug memory leak on memory exhaustion.
5401 Don't double-block input; malloc is safe here. Don't assume 2**34
5402 - 4 fits in unsigned long. Add an xassert to check
5403 XGetWindowProperty overflow. Be more careful about overflow
5404 calculations, and distinguish size from memory overflow better.
5405 (receive_incremental_selection): When tracing, don't assume
5406 unsigned int is less than INT_MAX.
5407 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5408 harmful) conversions of unsigned short to int.
5409 (lisp_data_to_selection_data): Don't assume that integers
5410 in the range -65535 through -1 fit in an X unsigned short.
5411 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5412 result parameters unless successful. Rely on cons_to_unsigned
5413 to report problems with elements; the old code wasn't right anyway.
5414 (x_check_property_data): Check for int overflow; we cannot use
5415 a wider type due to X limits.
5416 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5417
726e0ab1 5418 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5419
0065d054
PE
5420 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5421 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5422 (x_color_cells): Don't store size until memory allocation succeeds.
5423 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5424 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5425 (x_term_init): Don't assume length fits in int (sprintf is limited
5426 to int size).
bc18e09d 5427
ebfa62c0
PE
5428 Use ptrdiff_t for composition IDs.
5429 * character.c (lisp_string_width):
5430 * composite.c (composition_table_size, n_compositions)
5431 (get_composition_id, composition_gstring_from_id):
5432 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5433 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5434 * window.c (Frecenter):
5435 Use ptrdiff_t, not int, for composition IDs.
5436 * composite.c (get_composition_id): Check for integer overflow.
5437 * composite.h: Adjust prototypes to match the above changes.
5438
d3411f89
PE
5439 Use ptrdiff_t for hash table indexes.
5440 * category.c (hash_get_category_set):
5441 * ccl.c (ccl_driver):
5442 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5443 * coding.c (coding_system_charset_list, detect_coding_system):
5444 * coding.h (struct coding_system.id):
5445 * composite.c (get_composition_id, gstring_lookup_cache):
5446 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5447 * image.c (xpm_get_color_table_h):
5448 * lisp.h (hash_lookup, hash_put):
5449 * minibuf.c (Ftest_completion):
5450 Use ptrdiff_t for hash table indexes, not int (which is too
5451 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5452 32-bit --with-wide-int hosts).
5453
e097a6fa
PE
5454 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5455 Add a FIXME comment about memory leaks.
5456 (syms_of_charset): Don't assume xmalloc returns.
5457
5637687f
PE
5458 Don't assume that stated character widths fit in int.
5459 * character.c (Fchar_width, c_string_width, lisp_string_width):
5460 * character.h (CHAR_WIDTH):
5461 * indent.c (MULTIBYTE_BYTES_WIDTH):
5462 Use sanitize_char_width to avoid undefined and/or bad behavior
5463 with outlandish widths.
a66cfb1c 5464 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5465 now that we have two such functions. All uses changed.
5466 (sanitize_char_width): New inline function.
5467
a2271ba2
PE
5468 Don't assume that tab-width fits in int.
5469 * character.h (sanitize_width): New inline function.
5470 (SANE_TAB_WIDTH): New macro.
5471 (ASCII_CHAR_WIDTH): Use it.
5472 * indent.c (sane_tab_width): Remove. All uses replaced by
5473 SANE_TAB_WIDTH (current_buffer).
5474 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5475
18c52557
PE
5476 * fileio.c: Integer overflow issues with file modes.
5477 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5478
caeeedc1
PE
5479 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5480 Remove unreachable code.
5481 (read_hex, load_charset_map_from_file): Check for integer overflow.
5482
6df6ae42 5483 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5484 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5485 (x_send_scroll_bar_event): Likewise. Check that the size does not
5486 exceed limits imposed by XClientMessageEvent, as well as the usual
5487 ptrdiff_t and size_t limits.
5488
b13995db
PE
5489 * keyboard.c: Overflow, signedness and related fixes.
5490 (make_lispy_movement): Use same integer type in forward decl
5491 that is used in the definition.
5492 (read_key_sequence, keyremap_step):
5493 Change bufsize argument back to int, undoing my 2011-03-30 change.
5494 We prefer signed types, and int is wide enough here.
5495 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5496 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5497 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5498 length, not size_t. Use ptrdiff_t for index, not int.
5499 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5500 possibility of integer overflow.
5501
13464394
PE
5502 Overflow, signedness and related fixes for images.
5503
5504 * dispextern.h (struct it.stack[0].u.image.image_id)
5505 (struct_it.image_id, struct image.id, struct image_cache.size)
5506 (struct image_cache.used, struct image_cache.ref_count):
5507 * gtkutil.c (update_frame_tool_bar):
5508 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5509 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5510 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5511 * nsmenu.m (update_frame_tool_bar):
5512 * xdisp.c (calc_pixel_width_or_height):
5513 * xfns.c (image_cache_refcount):
5514 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5515 on typical 64-bit hosts.
5516
5517 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5518 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5519 Omit unnecessary casts to int.
5520 (parse_image_spec): Check that integers fall into 'int' range
5521 when the callers expect that.
5522 (image_ascent): Redo ascent calculation to avoid int overflow.
5523 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5524 (lookup_image): Remove unnecessary tests.
5525 (xbm_image_p): Locals are now of int, not EMACS_INT,
5526 since parse_image_check makes sure they fit into int.
5527 (png_load, gif_load, svg_load_image):
5528 Prefer int to unsigned where either will do.
5529 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5530 old tiff_error_handler and tiff_warning_handler.
5531 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5532 stack buffer overflows. It uses only the features of vsnprintf
5533 that are common to both POSIX and native Microsoft.
5534 (tiff_error_handler, tiff_warning_handler): Use it.
5535 (tiff_load, gif_load, imagemagick_load_image):
5536 Don't assume :index value fits in 'int'.
5537 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5538 (imagemagick_load_image): Check that crop parameters fit into
5539 the integer types that MagickCropImage accepts. Don't assume
5540 Vimagemagick_render_type has a nonnegative value. Don't assume
5541 size_t fits in 'long'.
5542 (gs_load): Use printmax_t to print the widest integers possible.
5543 Check for integer overflow when computing image height and width.
5544
c11821d4
EZ
55452011-08-26 Eli Zaretskii <eliz@gnu.org>
5546
5547 * xdisp.c (redisplay_window): Don't force window start if point
5548 will be invisible in the resulting window. (Bug#9324)
5549
0c95fcf7
EZ
55502011-08-25 Eli Zaretskii <eliz@gnu.org>
5551
5552 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5553 the display spec is of the form `(space ...)'.
5554 (handle_display_spec): Return the value returned by
5555 handle_single_display_spec, not just 1 or zero.
5556 (handle_single_display_spec): If the display spec is of the form
5557 `(space ...)', and specifies display in the text area, return 2
5558 rather than 1.
fee65a97 5559 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5560 accurately, and prefer exact match for point under bidi.
5561 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5562
5563 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5564 into disp_prop; all users changed.
5565
5566 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5567 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5568 for the text covered by the display property.
5569
e4ed06f1
CY
55702011-08-25 Chong Yidong <cyd@stupidchicken.com>
5571
5572 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5573 Change return value to nil.
5574 (Frecord_buffer): Delete unused function.
5575
f67cdd7f
EZ
55762011-08-24 Eli Zaretskii <eliz@gnu.org>
5577
5980d4c6
EZ
5578 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5579 buffers, return left-to-right.
8610fe8b
EZ
5580 (set_cursor_from_row): Consider candidate row a win if its glyph
5581 represents a newline and point is on that newline. Fixes cursor
5582 positioning on the newline at EOL of R2L text within L2R
5583 paragraph, and vice versa.
5584 (try_cursor_movement): Check continued rows, in addition to
5585 continuation rows. Fixes unwarranted scroll when point enters a
5586 continued line of R2L text within an L2R paragraph, or vice versa.
5587 (cursor_row_p): Consider the case of point being equal to
5588 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5589 from the end of a short line to the beginning of a continued line
5590 of R2L text within L2R paragraph.
5591 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5592 composed characters.
5980d4c6 5593
f67cdd7f
EZ
5594 * bidi.c (bidi_check_type): Use xassert.
5595 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5596 members.
5597
bca633fb
EZ
55982011-08-23 Eli Zaretskii <eliz@gnu.org>
5599
5600 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5601 a character.
5602
4a5885a7
CY
56032011-08-23 Chong Yidong <cyd@stupidchicken.com>
5604
5605 * nsfont.m (ns_otf_to_script): Fix typo.
5606
0902a04e
KH
56072011-08-22 Kenichi Handa <handa@m17n.org>
5608
5609 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5610 extra slot even if the purpose is char-code-property-table.
5611
1a2e6670
EZ
56122011-08-23 Eli Zaretskii <eliz@gnu.org>
5613
8ddde651
EZ
5614 * xdisp.c (redisplay_window): When computing centering_position,
5615 account for the height of the header line. (Bug#8874)
5616
425cc014
EZ
5617 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5618 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5619 candidate is selected by the mouse, and that candidate has a
5620 composed character under the mouse.
5621
1a2e6670
EZ
5622 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5623 coordinates reported by pos-visible-in-window-p for a composed
5624 character in column zero.
5625
8b76d6f8
SM
56262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5627
5628 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5629
dac347dd
EZ
56302011-08-22 Eli Zaretskii <eliz@gnu.org>
5631
5632 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5633 consider it a hit if to_charpos is anywhere in the range of the
5634 composed buffer positions.
5635
e013fb34
CY
56362011-08-22 Chong Yidong <cyd@stupidchicken.com>
5637
5638 * image.c (gif_load): Don't assume that each subimage has the same
5639 dimensions as the base image. Handle disposal method that is
5640 "undefined" by the gif spec (Bug#9335).
5641
bd1ba3e8
CY
56422011-08-20 Chong Yidong <cyd@stupidchicken.com>
5643
5644 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5645 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5646
54a1215b
EZ
56472011-08-19 Eli Zaretskii <eliz@gnu.org>
5648
823564e5
EZ
5649 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5650 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5651 from an Org mode buffer to a Speedbar frame.
5652
54a1215b
EZ
5653 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5654 a composition, take its buffer position from IT->cmp_it.charpos.
5655 Fixes cursor positioning at the beginning of a line that begins
5656 with a composed character.
5657
9778ebcc
EZ
56582011-08-18 Eli Zaretskii <eliz@gnu.org>
5659
0be6ee06
EZ
5660 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5661 character bidirectional type, use STRONG_L instead. Fixes crashes
5662 in a buffer produced by `describe-categories'.
5663
9778ebcc
EZ
5664 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5665 members before the level stack, so they would be saved and
5666 restored when copying iterator state. Fixes incorrect reordering
5667 around TABs covered by display properties.
5668
156bffbe
AS
56692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5670
6b02f655 5671 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5672
72ad093b
CY
56732011-08-17 Chong Yidong <cyd@stupidchicken.com>
5674
5675 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5676 (internal_condition_case_2, internal_condition_case_n):
5677 Remove unnecessary aborts (Bug#9081).
72ad093b 5678
35774242
EZ
56792011-08-17 Eli Zaretskii <eliz@gnu.org>
5680
5681 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5682 has no `load' handler, try opening the file locally. (Bug#9311)
5683
db76dd85
KB
56842011-08-16 Ken Brown <kbrown@cornell.edu>
5685
5686 * gmalloc.c: Expand comment.
5687
b215eee5
EZ
56882011-08-16 Eli Zaretskii <eliz@gnu.org>
5689
5690 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5691 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5692
a4579d33
KB
56932011-08-16 Ken Brown <kbrown@cornell.edu>
5694
5695 Fix memory allocation problems in Cygwin build (Bug#9273).
5696
5697 * unexcw.c ( __malloc_initialized): Declare external variable.
5698 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5699
8b76d6f8
SM
5700 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5701 New variables.
a4579d33
KB
5702 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5703 dumped emacs.
5704 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5705 in the static heap.
5706 [CYGWIN] (special_realloc): New function.
5707 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5708 requests to realloc storage in the static heap.
5709
3ebec551
PE
57102011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5711
5712 * bidi.c (bidi_initialize): Remove unused local.
5713
9fd8be00
EZ
57142011-08-15 Eli Zaretskii <eliz@gnu.org>
5715
6b02f655
SM
5716 * bidimirror.h:
5717 * biditype.h: Remove file.
5718 * makefile.w32-in ($(BLD)/bidi.$(O)):
5719 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5720
5721 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5722
5723 * chartab.c: Improve commentary for the uniprop_table API.
5724
32413314
EZ
5725 * bidi.c (bidi_paragraph_init): Support zero value of
5726 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5727 (bidi_initialize): Use uniprop_table instead of including
5728 biditype.h and bidimirror.h.
32413314 5729
9fd8be00
EZ
5730 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5731 coordinates of the iterator when restoring from ppos_it.
5732 (Bug#9296)
5733
5cf2b69b
KH
57342011-08-14 Kenichi Handa <handa@m17n.org>
5735
5736 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5737 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5738
daf17d00
EZ
57392011-08-14 Eli Zaretskii <eliz@gnu.org>
5740
5741 * xdisp.c (move_it_in_display_line_to): Don't invoke
5742 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5743 ppos_it. Fixes vertical cursor motion when line beginning is
5744 covered by an image. (Bug#9296)
5745
08e3161a
JD
57462011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5747
5748 * nsterm.h (ns_run_ascript): Declare.
5749 (NSAPP_DATA2_RUNASSCRIPT): Define.
5750
5751 * nsfns.m (as_script, as_result, as_status): New static variables.
5752 (ns_run_ascript): New function.
5e617bc2 5753 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5754 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5755 the event loop. Get status from as_status (Bug#7276).
5756
5757 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5758 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5759 the event loop (Bug#7276).
5760
a3720aa2
AS
57612011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5762
5763 * gnutls.c (QCgnutls_bootprop_priority)
5764 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5765 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5766 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5767 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5768 (QCgnutls_bootprop_verify_hostname_error)
5769 (QCgnutls_bootprop_callbacks_verify): Rename from
5770 Qgnutls_bootprop_..., all uses changed.
5771
5772 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5773 uses changed.
5774
0a0d27fb
PE
57752011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5776
19d5c50c
PE
5777 * xfaces.c (Qframe_set_background_mode): Now static.
5778 * dispextern.h (Qframe_set_background_mode): Remove decl.
5779
0a0d27fb
PE
5780 * process.c (Fnetwork_interface_info): Declare local only if needed.
5781
377538cb
JD
57822011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5783
5784 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5785 (Fnetwork_interface_list): Allocate in increments of bytes instead
5786 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5787 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5788 sockaddr.
5789 (struct ifflag_def): notrailers is smart on OSX.
5790 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5791 Get hardware address with getifaddrs if available.
5792
08fff70c
EZ
57932011-08-12 Eli Zaretskii <eliz@gnu.org>
5794
5795 * xdisp.c (iterate_out_of_display_property): xassert that
5796 IT->position is set to within IT->object's boundaries. Break from
5797 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5798 when IT->position is set up wrongly due to some bug.
5799 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5800 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5801 entry. Force push_it to save on the stack the current
5802 buffer/string position, to be restored by pop_it. Fix flags in
5803 the iterator structure wrt the object coming from a display
5804 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5805 properties. (Bug#9284)
5806
7be1c708 58072011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5808
7be1c708
CY
5809 * fontset.c (fontset_get_font_group): Add proper type checks.
5810 (Bug#9172)
aac0c6e3 5811
7be1c708 58122011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5813
7be1c708
CY
5814 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5815 and LC_VERSION_MIN_MACOSX.
5816 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5817 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5818
97bb72a6
EZ
58192011-08-08 Eli Zaretskii <eliz@gnu.org>
5820
5821 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5822 no-display-properties-and-no-overlays under bidi display.
5823 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5824 properties and overlays.
97bb72a6 5825
d5617611
CY
58262011-08-08 Chong Yidong <cyd@stupidchicken.com>
5827
37e11a63
CY
5828 * editfns.c (Fset_time_zone_rule): Document relationship with the
5829 setenv function.
5830
d5617611
CY
5831 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5832 the font entity extracted from the cache (Bug#8109).
5833
58872834
CY
58342011-08-07 Chong Yidong <cyd@stupidchicken.com>
5835
5836 * composite.c (autocmp_chars): Don't reset point. That is done by
5837 restore_point_unwind (Bug#5984).
5838
75bfc667
JL
58392011-08-07 Juri Linkov <juri@jurta.org>
5840
5841 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5842 to show the arg `TIME' instead of `TIMEVAL'.
5843
d1410150
EZ
58442011-08-06 Eli Zaretskii <eliz@gnu.org>
5845
5846 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5847 display property strides EOL and includes a newline, as in
5848 longlines-mode. (Bug#9254)
75b771e4
EZ
5849 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5850 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5851
5852 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5853 is non-zero, even if the data buffer is NULL. Fixes a crash in
5854 vertical-motion with longlines-mode. (Bug#9254)
5855
35928349
EZ
58562011-08-05 Eli Zaretskii <eliz@gnu.org>
5857
ec7cc85b
EZ
5858 * bidi.c <bidi_cache_total_alloc>: Now static.
5859 (bidi_initialize): Initialize bidi_cache_total_alloc.
5860
8b76d6f8 5861 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5862 cache. (Bug#9221)
5863
5864 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5865 amount allocated this far in `bidi_cache_total_alloc'.
5866 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5867 non-zero, only free the data buffer without restoring the cache
5868 contents. All callers changed.
5869
5870 * dispextern.h (bidi_unshelve_cache): Update prototype.
5871
5872 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5873 (move_it_in_display_line, move_it_to)
5874 (move_it_vertically_backward, move_it_by_lines): Replace the call
5875 to xfree to an equivalent call to bidi_unshelve_cache.
5876 (move_it_in_display_line_to): Fix logic of returning
412b6358 5877 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5878
e2e2423b
EZ
58792011-08-05 Eli Zaretskii <eliz@gnu.org>
5880
5881 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5882 came from a string character with a `cursor' property. (Bug#9229)
5883
ae9e757a
JD
58842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5885
5886 * Makefile.in (LIB_PTHREAD): New variable.
5887 (LIBES): Add LIB_PTHREAD (Bug#9216).
5888
5889 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5890 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5891
213bd7f2
AS
58922011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5893
6b02f655 5894 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5895
99aaf75f
JD
58962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5897
5898 * xterm.c (x_find_topmost_parent): New function.
5899 (x_set_frame_alpha): Find topmost parent window with
5900 x_find_topmost_parent and set the property there also (bug#9181).
5901 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5902
c74e9d86
PE
59032011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5904
5905 * callproc.c (Fcall_process): Avoid vfork clobbering
5906 the local vars buffer, coding_systems, current_dir.
5907
640c8776
SM
59082011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5909
5910 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5911
f26d0e4c
PE
59122011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5913
8a10d76c
PE
5914 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5915 so that it is not optimized away.
5916
f26d0e4c
PE
5917 * xdisp.c (compute_display_string_pos): Remove unused local.
5918
55439c61
EZ
59192011-08-02 Eli Zaretskii <eliz@gnu.org>
5920
5921 Fix slow cursor motion and scrolling in large buffers with
5922 selective display, like Org Mode buffers. (Bug#9218)
5923
5924 * dispextern.h (struct bidi_it): New member disp_prop_p.
5925
5926 * xdisp.c: Remove one-slot cache of display string positions.
5927 (compute_display_string_pos): Accept an additional argument
5e617bc2 5928 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5929 for a display string or property. If found, set DISP_PROP_P
5930 non-zero.
5931
5932 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5933 DISP_PROP_P, and pass it to compute_display_string_pos.
5934 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5935 non-zero. All callers of bidi_fetch_char changed.
5936
fb33fa43
SM
59372011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5938
5939 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5940
b099e063
DM
59412010-12-03 Don March <don@ohspite.net>
5942
5943 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5944 last character M-[char] is translated to ESC [char] (bug#7541).
5945
5cc7f7af
KH
59462011-08-02 Kenichi Handa <handa@m17n.org>
5947
d0fffa3f 5948 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5949
5950 * chartab.c (uniprop_table): Make it non-static.
5951
525d5e6e
EZ
59522011-08-01 Eli Zaretskii <eliz@gnu.org>
5953
5954 * xdisp.c (forward_to_next_line_start): Accept additional argument
5955 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5956 on the newline.
5957 (reseat_at_next_visible_line_start): Use the bidi iterator state
5958 returned by forward_to_next_line_start to restore the state of
5959 it->bidi_it after backing up to previous newline. (Bug#9212)
5960
31011111
AS
59612011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5962
5963 * regex.c (re_comp): Protoize.
5964 (re_exec): Fix return type.
5965 (regexec): Fix type of `ret'. (Bug#9203)
5966
476371c4
PE
59672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5968
e5d76069
PE
5969 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5970 This is needed if max-image-size is a floating-point number.
5971
9a79b20c
AS
59722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5973
5974 * print.c (print_object): Print empty symbol as ##.
5975
5976 * lread.c (read1): Read ## as empty symbol.
5977
d8c2fa78
AA
59782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5979
5980 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5981 setting frame foreground color (Bug#9175).
5982 (x_set_background_color): Likewise.
5983
ffe57a7a
AA
5984 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5985 contents (Bug#9176).
5986 (EmacsTooltip -init): Remove bezels and add shadows to
5987 tooltip windows.
5988
bf3492a5
AA
5989 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5990 or scroll bar (Bug#8470).
5991
d55e9c53
AA
5992 * nsfont.m (nsfont_open): Remove assignment to voffset and
5993 unnecessary vars hshink, expand, hd, full_height, min_height.
5994 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5995
5996 * nsterm.h (nsfont_info): Remove voffset field.
5997
d8c2fa78 59982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5999
6000 Implement strike-through and overline on NextStep (Bug#8863).
6001
6002 * nsfont.m (nsfont_open): Use underline position provided by font,
6003 instead of hard-coded value of 2.
6004 (nsfont_draw): Call ns_draw_text_decoration instead.
6005
6006 * nsterm.h: Add declaration for ns_draw_text_decoration.
6007
6008 * nsterm.m (ns_draw_text_decoration): New function for drawing
6009 underline, overline, and strike-through.
6010 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6011 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6012 accommodate underlining, etc.
4843aac3 6013
4cc60b9b
EZ
60142011-07-28 Eli Zaretskii <eliz@gnu.org>
6015
bc7ece87
EZ
6016 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6017 default.
4cc60b9b 6018
476371c4
PE
60192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6020
66606eea
PE
6021 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6022 Without this fix, if a signal arrives just after memory fills up,
6023 'malloc' might be invoked reentrantly.
6024
476371c4
PE
6025 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6026 In other words, assume that every image size is allowed, on non-X
6027 hosts. This assumption is probably wrong, but it lets Emacs compile.
6028
f3fcc40d
AS
60292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6030
6031 * regex.c (re_iswctype): Convert return values to boolean.
6032
350c992f
EZ
60332011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6034
6035 * xdisp.c (compute_display_string_pos): Don't use cached display
6036 string position if the buffer had its restriction changed.
6037 (Bug#9184)
6038
5266b4bb
PE
60392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6040
6041 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6042
2573a837 60432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6044
41f55ccd 6045 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6046
39e378da
PE
6047 * bidi.c: Integer size and overflow fixes.
6048 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6049 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6050 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6051 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6052 (bidi_find_other_level_edge):
6053 Use ptrdiff_t instead of EMACS_INT where either will do.
6054 This works better on 32-bit hosts configured --with-wide-int.
6055 (bidi_cache_ensure_space): Check for size-calculation overflow.
6056 Use % rather than repeated addition, for better worst-case speed.
6057 Don't set bidi_cache_size until after xrealloc returns, because it
6058 might not return.
6059 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6060 (bidi_cache_ensure_space): Also check that the bidi cache size
6061 does not exceed that of the largest Lisp string or buffer. See Eli
6062 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6063
5e927815
PE
6064 * alloc.c (__malloc_size_t): Remove.
6065 All uses replaced by size_t. See Andreas Schwab's note
6066 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6067
ca4aa935
PE
6068 * image.c: Improve checking for integer overflow.
6069 (check_image_size): Assume that f is nonnull, since
6070 it is always nonnull in practice. This is one less thing to
6071 worry about when checking for integer overflow later.
6072 (x_check_image_size): New function, which checks for integer
6073 overflow issues inside X.
6074 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6075 This removes the need for a memory_full check.
6076 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6077 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6078 (xbm_read_bitmap_data): Change locals back to 'int', since
6079 their values must fit in 'int'.
6080 (xpm_load_image, png_load, tiff_load):
6081 Invoke x_create_x_image_and_pixmap earlier,
6082 to avoid much needless work if the image is too large.
6083 (tiff_load): Treat overly large images as if
6084 x_create_x_image_and_pixmap failed, not as malloc failures.
6085 (gs_load): Use x_check_image_size.
6086
5f8f9cc2
PE
6087 * gtkutil.c: Omit integer casts.
6088 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6089 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6090
5adf60bc
PE
6091 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6092
c8907a93
PE
6093 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6094 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6095 would wrongly return t on a 64-bit host.
6096
e3c25c68
PE
6097 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6098 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6099 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6100 and therefore cause GCC to emit a bogus diagnostic in some cases.
6101
3f791afe
PE
6102 * image.c: Integer signedness and overflow and related fixes.
6103 This is not an exhaustive set of fixes, but it's time to
6104 record what I've got.
6105 (lookup_pixel_color, check_image_size): Remove redundant decls.
6106 (check_image_size): Don't assume that arbitrary EMACS_INT values
6107 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6108 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6109 (tiff_load, imagemagick_load_image):
6110 Check for overflow in size calculations.
6111 (x_create_x_image_and_pixmap): Remove unnecessary test for
6112 xmalloc returning NULL; that can't happen.
6113 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6114 (xpm_color_bucket): Use better integer hashing function.
6115 (xpm_cache_color): Don't possibly over-allocate memory.
6116 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6117 (gif_memory_source):
6118 Use ptrdiff_t, not int or size_t, to record sizes.
6119 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6120 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6121 either works, as we prefer signed integers.
6122 (tiff_read_from_memory, tiff_write_from_memory):
6123 Return tsize_t, not size_t, since that's what the TIFF API wants.
6124 (tiff_read_from_memory): Don't fail simply because the read would
6125 go past EOF; instead, return a short read.
6126 (tiff_load): Omit no-longer-needed casts.
6127 (Fimagemagick_types): Don't assume size fits into 'int'.
6128
3cc5a532
PE
6129 Improve hashing quality when configured --with-wide-int.
6130 * fns.c (hash_string): New function, taken from sxhash_string.
6131 Do not discard information about ASCII character case; this
6132 discarding is no longer needed.
6133 (sxhash-string): Use it. Change sig to match it. Caller changed.
6134 * lisp.h: Declare it.
6135 * lread.c (hash_string): Remove, since we now use fns.c's version.
6136 The fns.c version returns a wider integer if --with-wide-int is
6137 specified, so this should help the quality of the hashing a bit.
6138
b312a492
PE
6139 * emacs.c: Integer overflow minor fix.
6140 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6141 Define only if GNU_LINUX.
6142 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6143
dfd153ae
PE
6144 * dispnew.c: Integer signedness and overflow fixes.
6145 Remove unnecessary forward decls, that were a maintenance hassle.
6146 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6147 All uses changed.
6148 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6149 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6150 (prepare_desired_row, line_draw_cost):
6151 Use int, not unsigned, where either works.
6152 (save_current_matrix, restore_current_matrix):
6153 Use ptrdiff_t, not size_t, where either works.
6154 (init_display): Check for overflow more accurately, and without
6155 relying on undefined behavior.
6156
a81d11a3
PE
6157 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6158 Remove, replacing with the new symbols in lisp.h. All uses changed.
6159 * fileio.c (make_temp_name):
6160 * filelock.c (lock_file_1, lock_file):
6161 * xdisp.c (message_dolog):
6162 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6163 Use pMd etc. instead.
6164 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6165 replacing the pWIDE etc. symbols removed from editfns.c.
6166
3300e6fd
PE
6167 * keyboard.h (num_input_events): Now uintmax_t.
6168 This is (very slightly) less likely to mess up due to wraparound.
6169 All uses changed.
6170
fd05c7e9
PE
6171 * buffer.c: Integer signedness fixes.
6172 (alloc_buffer_text, enlarge_buffer_text):
6173 Use ptrdiff_t rather than size_t when either will do, as we prefer
6174 signed integers.
6175
903fe15d
PE
6176 * alloc.c: Integer signedness and overflow fixes.
6177 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6178 (__malloc_size_t): Default to size_t, not to int.
6179 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6180 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6181 Prefer ptrdiff_t to size_t when either would do, as we prefer
6182 signed integers.
6183 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6184 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6185 Now const. Initialize with values that are in range even if char
6186 is signed.
6187 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6188 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6189 These functions do the right thing with sizes > 2**32.
6190 (check_depth): Now ptrdiff_t, not int.
6191 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6192 Adjust to new way of storing sizes. Check for size overflow bugs
6193 in rest of code.
6194 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6195 slightly wrong anyway, as it missed one instance of
6196 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6197 (refill_memory_reserve): Omit needless cast to size_t.
6198 (mark_object_loop_halt): Mark as externally visible.
6199
ac82cc6a
PE
6200 * xselect.c: Integer signedness and overflow fixes.
6201 (Fx_register_dnd_atom, x_handle_dnd_message):
6202 Use ptrdiff_t, not size_t, since we prefer signed.
6203 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6204 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6205 x_dnd_atoms_size and x_dnd_atoms_length.
6206
c2d1e36d
PE
6207 * doprnt.c: Prefer signed to unsigned when either works.
6208 * eval.c (verror):
6209 * doprnt.c (doprnt):
6210 * lisp.h (doprnt):
6211 * xdisp.c (vmessage):
6212 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6213 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6214 prefer signed arithmetic to avoid comparison confusion.
6215 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6216 but is a bit tricky.
6217
0e926e56
PE
6218 Assume freestanding C89 headers, string.h, stdlib.h.
6219 * data.c, doprnt.c, floatfns.c, print.c:
6220 Include float.h unconditionally.
6221 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6222 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6223 * regex.c: Likewise for stddef.h, string.h.
6224 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6225 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6226 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6227 (STDC_HEADERS): Remove obsolete defines.
6228 * sysdep.c: Include limits.h unconditionally.
6229
9cfdb3ec
PE
6230 Assume support for memcmp, memcpy, memmove, memset.
6231 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6232 * regex.c (memcmp, memcpy):
6233 Remove; we assume C89 now.
6234
6235 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6236 (__malloc_safe_bcopy): Remove; no longer needed.
6237
cf950e6b 6238 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6239 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6240 well either way, and we prefer signed to unsigned.
6241
dbf38e02
LMI
62422011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6243
6244 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6245 closes the connection while we're reading (bug#9182).
6246
d6f0886c 62472011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6248
d6f0886c
JD
6249 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6250 are specified (Bug#9168).
24e0f6b1 6251
2eb1f9e6
PE
62522011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6253
6254 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6255 Found by GCC static checking and --with-wide-int on a 32-bit host.
6256
22381272 62572011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6258
6259 * xdisp.c (compute_display_string_pos): Fix logic of caching
6260 previous display string position. Initialize cached_prev_pos to
6261 -1. Fixes slow-down at the beginning of a buffer.
6262
f25e39b4
EZ
62632011-07-24 Eli Zaretskii <eliz@gnu.org>
6264
6265 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6266 for attrs[LFACE_FONTSET_INDEX].
6267
04c4b52e
PE
62682011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6269
6270 * xml.c (parse_region): Remove unused local
6271 that was recently introduced.
6272
c1734fbd
EZ
62732011-07-23 Eli Zaretskii <eliz@gnu.org>
6274
be18c5a5
EZ
6275 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6276 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6277
c1734fbd
EZ
6278 * xdisp.c (move_it_in_display_line_to): Record the best matching
6279 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6280 exit if none of the characters scanned was an exact match.
6281 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6282 when exact match is impossible due to invisible text, and the
6283 lines are truncated.
6284
a258d627
JD
62852011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6286
6287 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6288 for OSX >= 10.7.
6289
b6d5a689
EZ
62902011-07-22 Eli Zaretskii <eliz@gnu.org>
6291
0f74f785
EZ
6292 Fix a significant slow-down of cursor motion with C-n, C-p,
6293 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6294 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6295 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6296 (next_element_from_buffer): Call compute_stop_pos_backwards to
6297 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6298 base_level_stop.
6299 (reseat): Don't look for prev_stop, as that could mean a very long
6300 run.
6301 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6302 <cached_disp_overlay_modiff>: Cache for last found display string
6303 position.
551918c1 6304 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6305 about the same buffer in the same area of character positions, and
6306 the buffer wasn't changed since the time the display string
6307 position was cached.
551918c1 6308
b2d0c91a
EZ
63092011-07-22 Eli Zaretskii <eliz@gnu.org>
6310
6311 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6312 is an integer, which is important for empty lines. (Bug#9149)
6313
043604ee
CY
63142011-07-22 Chong Yidong <cyd@stupidchicken.com>
6315
6316 * frame.c (Fmodify_frame_parameters): In tty case, update the
6317 default face if necessary (Bug#4238).
6318
da4adb04
CY
63192011-07-21 Chong Yidong <cyd@stupidchicken.com>
6320
6321 * editfns.c (Fstring_to_char): No need to explain what a character
6322 is in the docstring (Bug#6576).
6323
9abd0532
LMI
63242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6325
6326 * xml.c (parse_region): Make sure we always return a tree.
6327
36881d16
HK
63282011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6329
6330 * xml.c (parse_region): If a document contains only comments,
6331 return that, too.
6332
1e98674d
LMI
63332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6334
6335 * xml.c (make_dom): Return comments, too.
6336
590bd467
PE
63372011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6338
6339 Port to OpenBSD.
6340 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6341 and the surrounding thread.
6342 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6343 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6344 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6345 timer goes off.
6346 * s/openbsd.h (BROKEN_SIGIO): Define.
6347 * unexelf.c (unexec) [__OpenBSD__]:
6348 Don't update the .mdebug section of the Alpha COFF symbol table.
6349
f41628b2
LMI
63502011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6351
6352 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6353 (bug#8460).
6354
b59b67c5
PE
63552011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6356
15e3a074
PE
6357 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6358 This fixes some race conditions on the permissions of any newly
6359 created file.
6360
41bed37d
PE
6361 * alloc.c (valid_pointer_p): Use pipe, not open.
6362 This fixes some permissions issues when debugging.
6363
b59b67c5
PE
6364 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6365 If fchown fails to set both uid and gid, try to set just gid,
6366 as that is sometimes allowed. Adjust the file's mode to eliminate
6367 setuid or setgid bits that are inappropriate if fchown fails.
6368
925a6be7
SM
63692011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6370
6371 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6372 to compare Lisp_Objects.
6373 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6374 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6375 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6376
52968808
AS
63772011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6378
0a6a104b
AS
6379 * lread.c (read_integer): Unread even EOF character.
6380 (read1): Likewise. Properly record start position of symbol.
6381
52968808
AS
6382 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6383 symbol character follows.
6384
9e381cdd
PE
63852011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6386
6387 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6388 This works around a problem with the previous change to Fcopy_file.
6389 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6390 and without this change, GCC might complain about discarding
6391 fchown's return value.
6392
b5641435
JB
63932011-07-16 Juanma Barranquero <lekktu@gmail.com>
6394
6395 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6396
a8031457
PE
63972011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6398
6399 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6400
dd889327
LMI
64012011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6402
750c33f7
LMI
6403 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6404 it's used from the C level.
6405
dd889327
LMI
6406 * process.c: Use the same condition for POLL_FOR_INPUT in both
6407 keyboard.c and process.c (bug#1858).
6408
87e86684
LM
64092011-07-09 Lawrence Mitchell <wence@gmx.li>
6410
6411 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6412 (Fgnutls_boot): Use it.
6413
64348f40
AS
64142011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6415
6416 * doc.c (Fsubstitute_command_keys): Revert last change.
6417
1d698799
LMI
64182011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6419
f863868c
LMI
6420 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6421 quotes the next character, and doesn't affect other longer
6422 sequences (bug#8935).
6423
1d698799
LMI
6424 * lread.c (syms_of_lread): Clarify that is isn't only
6425 `eval-buffer' and `eval-defun' that's affected by
6426 `lexical-binding' (bug#8460).
6427
aa4b6df6
EZ
64282011-07-15 Eli Zaretskii <eliz@gnu.org>
6429
6430 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6431 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6432
5d856da6
PE
64332011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6434
ad6042bb
PE
6435 Fix minor problems found by static checking.
6436 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6437 (elsz): Now a signed constant, not a size_t var. We prefer signed
6438 types to unsigned, to avoid integer comparison confusion. Without
6439 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6440 "cannot optimize loop, the loop counter may overflow", a symptom
6441 of the confusion.
f00bbb22 6442 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6443 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6444
6468f31c
LMI
64452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6446
49080b10
LMI
6447 * search.c (Fre_search_backward): Mention `case-fold-search' in
6448 all the re_search_* functions (bug#8138).
6449
6468f31c
LMI
6450 * keyboard.c (Fopen_dribble_file): Document when the file is
6451 closed (bug#8056).
6452
c965adc5
EZ
64532011-07-14 Eli Zaretskii <eliz@gnu.org>
6454
df9733bf
EZ
6455 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6456 bidi_cache_idx.
6457
0bb23927
EZ
6458 Support bidi reordering of display and overlay strings.
6459 * xdisp.c (compute_display_string_pos)
6460 (compute_display_string_end): Accept additional argument STRING.
6461 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6462 (reseat_to_string): Initialize bidi_it->string.s and
6463 bidi_it->string.schars.
6464 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6465 NULL (avoids a crash in bidi_paragraph_init).
6466 Initialize itb.string.lstring.
0bb23927
EZ
6467 (init_iterator): Call bidi_init_it only of a valid
6468 buffer position was specified. Initialize paragraph_embedding to
6469 L2R.
6470 (reseat_to_string): Initialize the bidi iterator.
6471 (display_string): If we need to ignore text properties of
6472 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6473 original value of -1 will not work with bidi.)
6474 (compute_display_string_pos): First arg is now struct
6475 `text_pos *'; all callers changed. Support display properties on
6476 Lisp strings.
6477 (compute_display_string_end): Support display properties on Lisp
6478 strings.
6479 (init_iterator, reseat_1, reseat_to_string): Initialize the
6480 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6481 when iterating on a string not from display properties).
640c8776
SM
6482 (compute_display_string_pos, compute_display_string_end):
6483 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6484 arrow keys.
6485 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6486 base_level_stop; instead, set base_level_stop to BEGV.
6487 Fixes crashes in vertical-motion.
0bb23927
EZ
6488 (next_element_from_buffer): Improve commentary for when
6489 the iterator is before prev_stop.
6490 (init_iterator): Initialize bidi_p from the default value of
6491 bidi-display-reordering, not from buffer-local value. Use the
6492 buffer-local value only if initializing for buffer iteration.
6493 (handle_invisible_prop): Support invisible properties on strings
6494 that are being bidi-reordered.
6495 (set_iterator_to_next): Support bidi reordering of C strings and
6496 Lisp strings.
6497 (next_element_from_string): Support bidi reordering of Lisp
6498 strings.
6499 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6500 (display_string): Support display of R2L glyph rows.
6501 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6502 (init_iterator): Don't initialize it->bidi_p for strings
6503 here.
6504 (reseat_to_string): Initialize it->bidi_p for strings here.
6505 (next_element_from_string, next_element_from_c_string)
6506 (next_element_from_buffer): Add xassert's for correspondence
6507 between IT's object being iterated and it->bidi_it.string
6508 structure.
6509 (face_before_or_after_it_pos): Support bidi iteration.
6510 (next_element_from_c_string): Handle the case of the first string
6511 character that is not the first one in the visual order.
6512 (get_visually_first_element): New function, refactored from common
6513 parts of next_element_from_buffer, next_element_from_string, and
6514 next_element_from_c_string.
6515 (tool_bar_lines_needed, redisplay_tool_bar)
6516 (display_menu_bar): Force left-to-right direction. Add a FIXME
6517 comment for making that be controlled by a user option.
6518 (push_it, pop_it): Save and restore the state of the
6519 bidi iterator. Save and restore the bidi_p flag.
6520 (pop_it): Iterate out of display property for string iteration as
6521 well.
6522 (iterate_out_of_display_property): Support iteration over strings.
6523 (handle_single_display_spec): Set up it->bidi_it for iteration
6524 over a display string, and call bidi_init_it.
6525 (handle_single_display_spec, next_overlay_string)
6526 (get_overlay_strings_1, push_display_prop): Set up the bidi
6527 iterator for displaying display or overlay strings.
6528 (forward_to_next_line_start): Don't use the shortcut if
6529 bidi-iterating.
6530 (back_to_previous_visible_line_start): If handle_display_prop
6531 pushed the iterator stack, restore the internal state of the bidi
6532 iterator by calling bidi_pop_it same number of times.
6533 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6534 and we are bidi-iterating, don't decrement the iterator position;
6535 instead, set the first_elt flag in the bidi iterator, to produce
6536 the same effect.
6537 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6538 (push_display_prop): xassert that we are iterating a buffer.
6539 (push_it, pop_it): Save and restore paragraph_embedding member.
6540 (handle_single_display_spec, next_overlay_string)
6541 (get_overlay_strings_1, reseat_1, reseat_to_string)
6542 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6543 correctly. Don't assume unibyte strings are not bidi-reordered.
6544 (compute_display_string_pos)
6545 (compute_display_string_end): Fix handling the case of C string.
6546 (push_it, pop_it): Save and restore from_disp_prop_p.
6547 (handle_single_display_spec, push_display_prop): Set the
6548 from_disp_prop_p flag.
6549 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6550 (pop_it): Call iterate_out_of_display_property only if we are
6551 popping after iteration over a string that came from a display
6552 property. Fix a typo in popping stretch info. Add an assertion
6553 for verifying that the iterator position is in sync with the bidi
6554 iterator.
6555 (handle_single_display_spec, get_overlay_strings_1)
6556 (push_display_prop): Fix initialization of paragraph direction for
6557 string when that of the parent object is not yet determined.
6558 (reseat_1): Call bidi_init_it to resync the bidi
6559 iterator with IT's position. (Bug#7616)
6560 (find_row_edges): If ROW->start.pos gives position
6561 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6562 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6563 Reset the from_disp_prop_p flag.
6564 (SAVE_IT, RESTORE_IT): New macros.
6565 (pos_visible_p, face_before_or_after_it_pos)
6566 (back_to_previous_visible_line_start)
6567 (move_it_in_display_line_to, move_it_in_display_line)
6568 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6569 (try_scrolling, redisplay_window, display_line): Use them when
6570 saving a temporary copy of the iterator and restoring it back.
6571 (back_to_previous_visible_line_start, reseat_1)
6572 (init_iterator): Empty the bidi cache "stack".
6573 (move_it_in_display_line_to): If iterator ended up at
6574 EOL, but we never saw any buffer positions smaller than
6575 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6576 motion in bidi-reordered lines.
6577 (move_it_in_display_line_to): Record prev_method and prev_pos
6578 immediately before the call to set_iterator_to_next. Fixes cursor
6579 motion in bidi-reordered lines with stretch glyphs and strings
6580 displayed in margins. (Bug#8133) (Bug#8867)
6581 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6582 TO_CHARPOS.
640c8776
SM
6583 (pos_visible_p): Support positions in bidi-reordered lines.
6584 Save and restore bidi cache.
0bb23927
EZ
6585
6586 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6587 (bidi_paragraph_info): Delete unused struct.
6588 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6589 (bidi_cache_start): New variable.
6590 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6591 to zero.
6592 (bidi_cache_fetch_state, bidi_cache_search)
6593 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6594 (bidi_cache_find, bidi_peek_at_next_level)
6595 (bidi_level_of_next_char, bidi_find_other_level_edge)
6596 (bidi_move_to_visually_next): Compare cache index with
6597 bidi_cache_start rather than with zero.
6598 (bidi_fetch_char): Accept new argument STRING; all callers
6599 changed. Support iteration over a string. Support strings with
6600 display properties. Support unibyte strings. Fix the type of
6601 `len' according to what STRING_CHAR_AND_LENGTH expects.
6602 (bidi_paragraph_init, bidi_resolve_explicit_1)
6603 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6604 (bidi_level_of_next_char, bidi_move_to_visually_next):
6605 Support iteration over a string.
0bb23927
EZ
6606 (bidi_set_sor_type, bidi_resolve_explicit_1)
6607 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6608 can now be zero (for strings); special values 0 and -1 were
6609 changed to -1 and -2, respectively.
6610 (bidi_char_at_pos): New function.
6611 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6612 Call it instead of FETCH_MULTIBYTE_CHAR.
6613 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6614 initialized to valid values.
6615 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6616 values.
6617 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6618 the test for valid cached positions. Fix the logic for looking up
6619 the sentinel state in the cache. GCPRO the Lisp string we are
6620 iterating.
6621 (bidi_push_it, bidi_pop_it): New functions.
6622 (bidi_initialize): Initialize the bidi cache start stack pointer.
6623 (bidi_cache_ensure_space): New function, refactored from part of
6624 bidi_cache_iterator_state. Don't assume the required size is just
6625 one BIDI_CACHE_CHUNK away.
6626 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6627 (bidi_count_bytes, bidi_char_at_pos): New functions.
6628 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6629 always valid if bidi_cache_idx is valid.
6630 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6631 is valid if it's going to be used.
6632 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6633 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6634 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6635 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6636 (bidi_find_other_level_edge, bidi_cache_start_stack):
6637 All variables related to cache indices are now EMACS_INT.
c965adc5 6638
0bb23927
EZ
6639 * dispextern.h (struct bidi_string_data): New structure.
6640 (struct bidi_it): New member `string'. Make flag members be 1-bit
6641 fields, and put them last in the struct.
640c8776
SM
6642 (compute_display_string_pos, compute_display_string_end):
6643 Update prototypes.
0bb23927
EZ
6644 (bidi_push_it, bidi_pop_it): Add prototypes.
6645 (struct iterator_stack_entry): New members bidi_p,
6646 paragraph_embedding, and from_disp_prop_p.
6647 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6648 (bidi_shelve_cache, bidi_unshelve_cache):
6649 Declare prototypes.
0bb23927
EZ
6650
6651 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6652 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6653 and vector-like objects.
6654
6655 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6656 cache around display iteration.
6657
6658 * window.c (Fwindow_end, window_scroll_pixel_based)
6659 (displayed_window_lines, Frecenter): Save and restore the bidi
6660 cache around display iteration.
6661
3bbd2265
LMI
66622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6663
6664 * editfns.c (Fdelete_region): Clarify the use of the named
6665 parameters (bug#6788).
6666
adc47434
MR
66672011-07-14 Martin Rudalics <rudalics@gmx.at>
6668
6669 * indent.c (Fvertical_motion): Set and restore w->pointm when
6670 saving and restoring the window's buffer (Bug#9006).
6671
837c31f8
LMI
66722011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6673
6674 * editfns.c (Fstring_to_char): Clarify just what is returned
6675 (bug#6576). Text by Eli Zaretskii.
6676
ac389d0c
JB
66772011-07-13 Juanma Barranquero <lekktu@gmail.com>
6678
6679 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6680
0be0ce47
EZ
66812011-07-13 Eli Zaretskii <eliz@gnu.org>
6682
6683 * buffer.c (mmap_find): Fix a typo.
6684
cd18e7e3
JB
66852011-07-13 Johan Bockgård <bojohan@gnu.org>
6686
6687 Fix execution of x selection hooks.
6688 * xselect.c (Qx_lost_selection_functions)
6689 (Qx_sent_selection_functions): New vars.
6690 (syms_of_xselect): DEFSYM them.
6691 (x_handle_selection_request): Pass Qx_sent_selection_functions
6692 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6693 (x_handle_selection_clear,x_clear_frame_selections):
6694 Pass Qx_lost_selection_functions rather than
6695 Vx_lost_selection_functions to Frun_hook_with_args.
6696
47ea7f44
PE
66972011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6698
ac389d0c 6699 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6700 The old code sometimes used this field without initializing it.
6701
47ea7f44
PE
6702 * alloc.c (gc_sweep): Don't read past end of array.
6703 In theory, the old code could also have corrupted Emacs internals,
6704 though it'd be very unlikely.
6705
bc985c87
AS
67062011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6707
6708 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6709 argument. (Bug#4026)
bc985c87 6710
0cf34688
LMI
67112011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6712
b3dadd76
LMI
6713 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6714 key" (bug#4257).
6715
0cf34688
LMI
6716 * window.c (Fset_window_start): Doc fix (bug#4199).
6717 (Fset_window_hscroll): Ditto.
6718
270768cd
PE
67192011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6720
077e3dda 6721 Fix minor new problems caught by GCC 4.6.1.
270768cd 6722 * term.c (init_tty): Remove unused local.
490011a6 6723 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6724 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6725 not used otherwise.
270768cd 6726
b1f58454
CY
67272011-07-12 Chong Yidong <cyd@stupidchicken.com>
6728
6729 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6730
22b9578d
LMI
67312011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6732
6e70ab07
LMI
6733 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6734 are the mini-buffer and the echo area (bug#3320).
6735
22b9578d
LMI
6736 * term.c (init_tty): Remove support for supdup, c10 and perq
6737 terminals, which are no longer supported (bug#1482).
6738
8974cc9f
JB
67392011-07-10 Johan Bockgård <bojohan@gnu.org>
6740
6741 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6742
a560d974
JD
67432011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6744
6745 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6746 for non-popups (Bug#3642).
6747
1dae0f0a
AS
67482011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6749
268c2c36 6750 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6751 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6752 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6753 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6754 * data.c (fmod): Likewise.
6755 * dispnew.c (swap_glyphs_in_rows): Likewise.
6756 * emacs.c (memory_warning_signal): Likewise.
6757 * floatfns.c (float_error): Likewise.
6758 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6759 (otf_open, font_otf_capability, generate_otf_features)
6760 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6761 Likewise.
6762 * image.c (pbm_read_file): Likewise.
6763 * indent.c (string_display_width): Likewise.
6764 * intervals.c (check_for_interval, search_for_interval)
6765 (inc_interval_count, count_intervals, root_interval)
6766 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6767 * lread.c (defalias): Likewise.
268c2c36 6768 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6769 * regex.c (set_image_of_range_1, set_image_of_range)
6770 (regex_grow_registers): Likewise.
6771 * sysdep.c (strerror): Likewise.
6772 * termcap.c (valid_filename_p, tprint, main): Likewise.
6773 * tparam.c (main): Likewise.
6774 * unexhp9k800.c (run_time_remap, save_data_space)
6775 (update_file_ptrs, read_header, write_header, calculate_checksum)
6776 (copy_file, copy_rest, display_header): Likewise.
6777 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6778 Likewise.
6779 * xdisp.c (check_it): Likewise.
6780 * xfaces.c (register_color, unregister_color, unregister_colors):
6781 Likewise.
6782 * xfns.c (print_fontset_result): Likewise.
6783 * xrdb.c (member, fatal, main): Likewise.
6784
99033785
PE
67852011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6786
6787 Fix minor problems found by static checking (Bug#9031).
6788 * chartab.c (char_table_set_range, map_sub_char_table):
6789 Remove unused locals.
6790 (uniprop_table): Now static.
6791 * composite.c (_work_char): Remove unused static var.
6792
9cb2ac56
JB
67932011-07-09 Juanma Barranquero <lekktu@gmail.com>
6794
6795 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6796
f25661f0
JD
67972011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6798
6799 * gtkutil.c (qttip_cb): Remove code without function.
6800
8278c4fe
EZ
68012011-07-09 Eli Zaretskii <eliz@gnu.org>
6802
6803 * w32.c (pthread_sigmask): New stub.
6804
1692ae2d 68052011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6806
8a6ebd58 6807 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6808 sigprocmask is portable only for single-threaded applications, and
6809 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6810 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6811 (LIBES): Use it.
6812 * callproc.c (Fcall_process):
6813 * process.c (create_process):
6814 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6815 Use pthread_sigmask, not sigprocmask.
123403e4 6816
1b854618
JD
68172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6818
6819 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6820 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6821 wrong (Bug#8591).
6822
3fe4b549
JD
68232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6824
0ce7e563
JD
6825 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6826 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6827 (xg_hide_tooltip): Fix comment.
6828
3fe4b549
JD
6829 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6830 in registerServicesMenuSendTypes.
6831 (validRequestorForSendType): Don't check ns_return_types.
6832
6833 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6834 ns_return_type.
6835
5df75e47
JR
68362011-07-08 Jason Rumney <jasonr@gnu.org>
6837
22610910
JR
6838 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6839 SH_SHOW for hidden windows (Bug#5482).
6840
5df75e47
JR
6841 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6842 frame struct members of non-existent frames (Bug#6284).
6843
699c10bd
JD
68442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6845
4393663b
JD
6846 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6847 variable firstTime not needed on OSX >= 10.6.
6848 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6849 >= 10.5. Use setKnobProportion, setDoubleValue.
6850
6851 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6852 (MAC_OS_X_VERSION_10_5): Define if not defined.
6853 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6854 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6855 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6856
6857 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6858 cString and lossyCString on OSX >= 10.4
6859
58179cce 6860 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6861 sizeToFit on OSX >= 10.2.
6862
6863 * nsimage.m (allocInitFromFile): Don't use deprecated method
6864 bestRepresentationForDevice on OSX >= 10.6.
6865
6866 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6867 to avoid warning.
6868
6869 * emacs.c: Declare unexec_init_emacs_zone.
6870
a63e0781
JD
6871 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6872
699c10bd
JD
6873 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6874
6875 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6876 on svcsMenu (Bug#8842).
6877
6878 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6879 ns_return_types.
6880 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6881
6882 * nsterm.m (QUTF8_STRING): Declare.
6883 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6884 (validRequestorForSendType): Return type is (id).
6885 Change indexOfObjectIdenticalTo to indexOfObject.
6886 Check if we have local selection before returning self (Bug#8842).
6887 (writeSelectionToPasteboard): Put local selection into paste board
6888 if we have a local selection (Bug#8842).
6889 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6890
6891 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6892 (ns_get_local_selection): Declare.
6893
54e10184
LMI
68942011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6895
9888ff71
LMI
6896 * keymap.c (describe_map_tree): Don't insert a double newline at
6897 the end of the buffer (bug#1169) and return whether we inserted
6898 something.
6899
54e10184
LMI
6900 * callint.c (Fcall_interactively): Change "reading args" to
6901 "providing args" to try to clarify what it does (bug#1010).
6902
15fa4783
KH
69032011-07-07 Kenichi Handa <handa@m17n.org>
6904
6905 * composite.c (composition_compute_stop_pos): Ignore a static
6906 composition starting before CHARPOS (Bug#8915).
6907
6908 * xdisp.c (handle_composition_prop): Likewise.
6909
a8815b00
EZ
69102011-07-07 Eli Zaretskii <eliz@gnu.org>
6911
6912 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6913 (Bug#9015)
6914
ef7b981d 69152011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6916
6917 * character.h (unicode_category_t): New enum type.
6918
6919 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6920 (Qchar_code_property_table): New variable.
6921 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6922 (UNIPROP_COMPRESSED_FORM_P): New macros.
6923 (char_table_ascii): Uncompress the compressed values.
6924 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6925 Uncompress the compressed values.
ac389d0c 6926 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6927 (char_table_ref_and_range): Uncompress the compressed values.
6928 (sub_char_table_set): New arg is_uniprop. Callers changed.
6929 Uncompress the compressed values.
6930 (sub_char_table_set_range): Args changed. Callers changed.
6931 (char_table_set_range): Adjuted for the above change.
6932 (map_sub_char_table): Delete args default_val and parent. Add arg
6933 top. Give decoded values to a Lisp function.
640c8776 6934 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6935 values to a Lisp function. Gcpro more variables.
6936 (uniprop_table_uncompress)
6937 (uniprop_decode_value_run_length): New functions.
6938 (uniprop_decoder, uniprop_decoder_count): New variables.
6939 (uniprop_get_decoder, uniprop_encode_value_character)
6940 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6941 New functions.
6942 (uniprop_encoder, uniprop_encoder_count): New variables.
6943 (uniprop_get_encoder, uniprop_table)
6944 (Funicode_property_table_internal, Fget_unicode_property_internal)
6945 (Fput_unicode_property_internal): New functions.
6946 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6947 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6948 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6949 char-code-property-alist.
6950
640c8776 6951 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6952 Vunicode_category_table.
6953
640c8776 6954 * font.c (font_range): Adjust for the change of
c805dec0
KH
6955 Vunicode_category_table.
6956
76b397fb
DN
69572011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6958
6959 * m/iris4d.h: Remove file, move contents ...
6960 * s/irix6-5.h: ... here.
6961
22b4128e
PE
69622011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6963
6964 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6965 * alloc.c (mark_buffer):
6966 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6967 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6968 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6969 This isn't true in general, and it's particularly not true
6970 if Emacs is configured with --with-wide-int.
6971 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6972 New macros, used in the buffer.c change.
6973
869795d6
JD
69742011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6975
6976 * xsettings.c: Use both GConf and GSettings if both are available.
6977 (store_config_changed_event): Add comment.
6978 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6979 (store_tool_bar_style_changed): New functions.
5e617bc2 6980 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6981 (struct xsettings): Move font inside HAVE_XFT.
6982 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6983 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6984 Move inside HAVE_XFT.
640c8776 6985 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6986 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6987 also.
6988 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6989 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6990 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6991 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6992 (parse_settings): Move check for font inside HAVE_XFT.
6993 (read_settings, apply_xft_settings): Add comment.
6994 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6995 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6996 call store_font_name_changed.
6997 (xft_settings_event): Add comment.
6998 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6999 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7000 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7001 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7002 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7003 (xsettings_get_system_font, xsettings_get_system_normal_font):
7004 Add comment.
869795d6 7005
d8ed26bd
PE
70062011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7007
7008 Random fixes. E.g., (random) never returned negative values.
7009 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7010 subseconds part to the entropy, as that's a bit more random.
7011 Prefer signed to unsigned, since the signedness doesn't matter and
7012 in general we prefer signed. When given a limit, use a
7013 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7014 latter isn't right if USE_2_TAGS_FOR_INTS.
7015 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7016 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7017
cabf1cac
SM
70182011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7019
7020 * textprop.c (text_property_stickiness):
7021 Obey Vtext_property_default_nonsticky.
7022 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7023 * w32fns.c (syms_of_w32fns):
7024 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7025
6e9b2be9
PE
70262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7027
7028 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7029 This is more efficient than Ffile_directory_p and avoids a minor race.
7030
90186c68
LMI
70312011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7032
7c301272
LMI
7033 * buffer.c (Foverlay_put): Say what the return value is
7034 (bug#7835).
7035
c4f2d8d4
LMI
7036 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7037 is a directory before asking whether to use the file name
7038 (bug#7564).
ad637907
LMI
7039 (barf_or_query_if_file_exists): Make the "File is a directory"
7040 error be more correct.
c4f2d8d4 7041
90186c68
LMI
7042 * fns.c (Frequire): Remove the mention of the .gz files, since
7043 that's installation-specific, but keep the mention of
7044 `get-load-suffixes'.
7045
da64016e
PE
70462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7047
7048 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7049 Report string overflow if the output is too long.
7050
7d47b580
JB
70512011-07-04 Juanma Barranquero <lekktu@gmail.com>
7052
a555cb87
JB
7053 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7054 (syms_of_gnutls): Remove duplicate DEFSYM for
7055 Qgnutls_bootprop_verify_hostname_error, an error for
7056 Qgnutls_bootprop_verify_error (which is no longer used).
7057
7d47b580
JB
7058 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7059 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7060 Also (re)move comments that are misplaced or no longer relevant.
7061
1e49bfab
LMI
70622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7063
7064 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7065
1485f4c0
CY
70662011-07-03 Chong Yidong <cyd@stupidchicken.com>
7067
7068 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7069 and background color parameters if they have been changed.
7070
a9ab721e
LMI
70712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7072
7073 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7074
cf7cff57
PE
70752011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7076
2e13213d
PE
7077 * xsettings.c (SYSTEM_FONT): Define only when used.
7078 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7079
cf7cff57
PE
7080 * keymap.c (access_keymap_1): Now static.
7081
7a8e04f7
CY
70822011-07-02 Chong Yidong <cyd@stupidchicken.com>
7083
7084 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7085 leave any prefix arg for the up event (Bug#1586).
7086
61352f62
LMI
70872011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7088
69bb1ef7
LMI
7089 * lread.c (syms_of_lread): Mention single symbols defined by
7090 `defvar' or `defconst' (bug#7154).
7091
61352f62 7092 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7093 (Frequire): Mention get-load-suffixes.
61352f62 7094
28545e04
MR
70952011-07-02 Martin Rudalics <rudalics@gmx.at>
7096
7097 * window.h (window): Remove clone_number slot.
7098 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7099 Remove.
7100 (make_parent_window, make_window, saved_window)
7101 (Fset_window_configuration, save_window_save): Don't deal with
7102 clone numbers.
7103 * buffer.c (Qclone_number): Remove declaration.
7104 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7105
3349e122
SM
71062011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7107
7108 Add multiple inheritance to keymaps.
7109 * keymap.c (Fmake_composed_keymap): New function.
7110 (Fset_keymap_parent): Simplify.
7111 (fix_submap_inheritance): Remove.
7112 (access_keymap_1): New function extracted from access_keymap to handle
7113 embedded parents and handle lists of maps.
7114 (access_keymap): Use it.
7115 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7116 (Fcopy_keymap): Handle embedded parents.
7117 (Fcommand_remapping, define_as_prefix): Simplify.
7118 (Fkey_binding): Simplify.
7119 (syms_of_keymap): Move minibuffer-local-completion-map,
7120 minibuffer-local-filename-completion-map,
7121 minibuffer-local-must-match-map, and
7122 minibuffer-local-filename-must-match-map to Elisp.
7123 (syms_of_keymap): Defsubr make-composed-keymap.
7124 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7125 (parse_menu_item): Trivial simplification.
7126
3279eb87
GM
71272011-07-01 Glenn Morris <rgm@gnu.org>
7128
7129 * Makefile.in (SETTINGS_LIBS): Fix typo.
7130
4550efdf
KI
71312011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7132
7133 * coding.c (Fencode_coding_string): Record the last coding system
7134 used, as the function doc string says (bug#8738).
7135
0949d2b6
JD
71362011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7137
7138 * xsettings.c (store_monospaced_changed): Take new font as arg and
7139 check for change against current_mono_font.
7140 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7141 (emacs_settings_constructor, emacs_settings_get_property)
7142 (emacs_settings_set_property, emacs_settings_class_init)
7143 (emacs_settings_init, gsettings_obj): Remove.
7144 (something_changedCB): New function for HAVE_GSETTINGS.
7145 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7146 with value as argument.
7147 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7148 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7149 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7150 "changed".
7151
7152 * xgselect.c: Add defined (HAVE_GSETTINGS).
7153 (xgselect_initialize): Ditto.
7154
7155 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7156 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7157 xg_select.
7158
bbc6b304
PE
71592011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7160
7161 * eval.c (struct backtrace): Simplify and port the data structure.
7162 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7163 signed bit field, as this assumption is not portable and it makes
7164 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7165 "char debug_on_exit : 1" as this is not portable either; instead,
7166 use the portable "unsigned int debug_on_exit : 1". Remove unused
7167 member evalargs. Remove obsolete comments about cc bombing out.
7168
9851bfc5
JD
71692011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7170
51bb811f 7171 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7172 Let HAVE_GSETTINGS override HAVE_GCONF.
7173 (store_monospaced_changed): New function.
7174 (EMACS_SETTINGS): A new type derived from GObject to handle
7175 GSettings notifications.
7176 (emacs_settings_constructor, emacs_settings_get_property)
7177 (emacs_settings_set_property, emacs_settings_class_init):
7178 New functions.
7179 (gsettings_client, gsettings_obj): New variables.
7180 (GSETTINGS_SCHEMA): New define.
7181 (something_changedCB): Call store_monospaced_changed.
7182 (init_gsettings): New function.
7183 (xsettings_initialize): Call init_gsettings.
7184 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7185 to NULL.
7186
640c8776 7187 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7188 GCONF_CFLAGS/LIBS.
7189
5386012d
MR
71902011-06-29 Martin Rudalics <rudalics@gmx.at>
7191
7192 * window.c (resize_root_window, grow_mini_window)
7193 (shrink_mini_window): Rename Qresize_root_window to
7194 Qwindow_resize_root_window and Qresize_root_window_vertically to
7195 Qwindow_resize_root_window_vertically.
7196
f13e0b08
PE
71972011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7198
7199 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7200
94515237
JB
72012011-06-27 Juanma Barranquero <lekktu@gmail.com>
7202
7203 * makefile.w32-in: Redesign dependencies so they reflect more
7204 clearly which files are directly included by each source file,
7205 and not through other includes.
7206
e43b6e43
MR
72072011-06-27 Martin Rudalics <rudalics@gmx.at>
7208
7209 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7210 (sort_overlays, overlay_strings): When an overlay's clone number
7211 matches the window's clone number process the overlay even if
7212 the overlay's window property doesn't match the current window.
7213
d68443dc
MR
7214 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7215 (Fwindow_hchild): Rename to Fwindow_left_child.
7216 (Fwindow_next): Rename to Fwindow_next_sibling.
7217 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7218 (resize_window_check): Rename to window_resize_check.
7219 (resize_window_apply): Rename to window_resize_apply.
7220 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7221 (Fdelete_other_windows_internal, resize_frame_windows)
7222 (Fsplit_window_internal, Fdelete_window_internal)
7223 (grow_mini_window, shrink_mini_window)
7224 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7225
c7e73be5
JD
72262011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7227
7228 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7229 (emacs_fixed_set_min_size): Remove.
7230 (emacs_fixed_new): Take frame as argument.
7231
7232 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7233 (_EmacsFixedPrivate): Remove minwidth/height.
7234 Add struct frame *f.
7235 (emacs_fixed_init): Initialize priv->f.
7236 (get_parent_class, emacs_fixed_set_min_size): Remove.
7237 (emacs_fixed_new): Set priv->f to argument.
7238 (emacs_fixed_get_preferred_width)
7239 (emacs_fixed_get_preferred_height): Use min_width/height from
7240 frames size_hint to set minimum and natural (Bug#8919).
7241 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7242 and use min_width/height from frames size_hint to set
7243 min_width/height (Bug#8919).
7244
7245 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7246 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7247 Fix indentation.
c7e73be5 7248
cf99dcf8
EZ
72492011-06-26 Eli Zaretskii <eliz@gnu.org>
7250
7251 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7252 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7253 called at ZV.
7254
029529ac
CY
72552011-06-26 Chong Yidong <cyd@stupidchicken.com>
7256
7257 * process.c (wait_reading_process_output): Bypass select if
7258 waiting for a cell while ignoring keyboard input, and input is
7259 pending. Suggested by Jan Djärv (Bug#8869).
7260
7a7ef429
PE
72612011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7262
7263 Use gnulib's dup2 module instead of rolling our own.
7264 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7265
11fdef7d 72662011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7267
7268 * dispnew.c (scrolling_window): Before scrolling, turn off a
7269 mouse-highlight in the window being scrolled.
7270
cd3520a4
JB
72712011-06-24 Juanma Barranquero <lekktu@gmail.com>
7272
7273 Move DEFSYM to lisp.h and use everywhere.
7274
7275 * character.h (DEFSYM): Move declaration...
7276 * lisp.h (DEFSYM): ...here.
7277
7278 * gnutls.c:
7279 * minibuf.c:
7280 * w32menu.c:
7281 * w32proc.c:
7282 * w32select.c: Don't include character.h.
7283
7284 * alloc.c (syms_of_alloc):
7285 * buffer.c (syms_of_buffer):
7286 * bytecode.c (syms_of_bytecode):
7287 * callint.c (syms_of_callint):
7288 * casefiddle.c (syms_of_casefiddle):
7289 * casetab.c (init_casetab_once):
7290 * category.c (init_category_once, syms_of_category):
7291 * ccl.c (syms_of_ccl):
7292 * cmds.c (syms_of_cmds):
7293 * composite.c (syms_of_composite):
7294 * dbusbind.c (syms_of_dbusbind):
7295 * dired.c (syms_of_dired):
7296 * dispnew.c (syms_of_display):
7297 * doc.c (syms_of_doc):
7298 * editfns.c (syms_of_editfns):
7299 * emacs.c (syms_of_emacs):
7300 * eval.c (syms_of_eval):
7301 * fileio.c (syms_of_fileio):
7302 * fns.c (syms_of_fns):
7303 * frame.c (syms_of_frame):
7304 * fringe.c (syms_of_fringe):
7305 * insdel.c (syms_of_insdel):
7306 * keymap.c (syms_of_keymap):
7307 * lread.c (init_obarray, syms_of_lread):
7308 * macros.c (syms_of_macros):
7309 * msdos.c (syms_of_msdos):
7310 * print.c (syms_of_print):
7311 * process.c (syms_of_process):
7312 * search.c (syms_of_search):
7313 * sound.c (syms_of_sound):
7314 * syntax.c (init_syntax_once, syms_of_syntax):
7315 * terminal.c (syms_of_terminal):
7316 * textprop.c (syms_of_textprop):
7317 * undo.c (syms_of_undo):
7318 * w32.c (globals_of_w32):
7319 * window.c (syms_of_window):
7320 * xdisp.c (syms_of_xdisp):
7321 * xfaces.c (syms_of_xfaces):
7322 * xfns.c (syms_of_xfns):
7323 * xmenu.c (syms_of_xmenu):
7324 * xsettings.c (syms_of_xsettings):
7325 * xterm.c (syms_of_xterm): Use DEFSYM.
7326
4228cf16
TZ
73272011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7328
cd3520a4 7329 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7330
7fcccf1e
PE
73312011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7332
7efb4e0e
PE
7333 Integer and buffer overflow fixes (Bug#8873).
7334
ff5844ad
PE
7335 * print.c (printchar, strout): Check for string overflow.
7336 (PRINTPREPARE, printchar, strout):
7337 Don't set size unless allocation succeeds.
7338
90532f02
PE
7339 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7340 for sizes. Check for string overflow more accurately.
7341 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7342
6d84508d
PE
7343 * macros.c: Integer and buffer overflow fixes.
7344 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7345 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7346 Use ptrdiff_t, not int, for sizes.
7347 Don't increment bufsize until after realloc succeeds.
7348 Check for size-calculation overflow.
7349 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7350
437b2cb4
PE
7351 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7352
8b9ac8b4
PE
7353 * lread.c: Integer overflow fixes.
7354 (read_integer): Radix is now EMACS_INT, not int,
7355 to improve quality of diagnostics for out-of-range radices.
7356 Calculate buffer size correctly for out-of-range radices.
7357 (read1): Check for integer overflow in radices, and in
7358 read-circle numbers.
82cb60d3
PE
7359 (read_escape): Avoid int overflow.
7360 (Fload, openp, read_buffer_size, read1)
7361 (substitute_object_recurse, read_vector, read_list, map_obarray):
7362 Use ptrdiff_t, not int, for sizes.
7363 (read1): Use EMACS_INT, not int, for sizes.
20270765 7364 Check for size overflow.
8b9ac8b4 7365
7fcccf1e
PE
7366 * image.c (cache_image): Check for size arithmetic overflow.
7367
bfbbd7e7
PE
7368 * lread.c: Integer overflow issues.
7369 (saved_doc_string_size, saved_doc_string_length)
7370 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7371 Now ptrdiff_t, not int.
7372 (read1): Don't assume doc string length fits in int. Check for
7373 out-of-range doc string lengths.
7374 (read_list): Don't assume file position fits in int.
39019e54 7375 (read_escape): Check for hex character overflow.
bfbbd7e7 7376
4e323265
LL
73772011-06-22 Leo Liu <sdl.web@gmail.com>
7378
7379 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7380 Move to minibuffer.el.
7381
85fece3e
PE
73822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7383
20b84ce9 7384 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7385 The following patches are for when GLYPH_DEBUG && !XASSERT.
7386 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7387 * dispnew.c (flush_stdout):
7388 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7389 Mark as externally visible.
7390 * dispnew.c (check_window_matrix_pointers): Now static.
7391 * dispnew.c (window_to_frame_vpos):
7392 * xfns.c (unwind_create_frame):
7393 * xterm.c (x_check_font): Remove unused local.
7394 * scroll.c (CHECK_BOUNDS):
7395 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7396 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7397 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7398 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7399 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7400 Now static.
7401 (debug_method_add): Use va_list and vsprintf rather than relying
7402 on undefined behavior with wrong number of arguments.
7403 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7404 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7405 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7406 since we're not interested in debugging glyphs with old libraries.
7407 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7408 GCC 4.6.0's static checking.
7409
0766b489
PE
74102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7411
31fd4b32
PE
7412 Integer overflow and signedness fixes (Bug#8873).
7413 A few related buffer overrun fixes, too.
7414
b79e8648
PE
7415 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7416
0766b489
PE
7417 * dispextern.h (struct face.stipple):
7418 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7419 (x_bitmap_mask, x_allocate_bitmap_record)
7420 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7421 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7422 (x_create_bitmap_from_xpm_data):
7423 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7424 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7425 (.bitmaps_last):
7426 * xfaces.c (load_pixmap):
7427 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7428 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7429 (.bitmaps_last, struct x_output.icon_bitmap):
7430 Use ptrdiff_t, not int, for bitmap indexes.
7431 (x_allocate_bitmap_record): Check for size overflow.
7432 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7433
b081724f
PE
7434 Use ptrdiff_t, not int, for overlay counts.
7435 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7436 * editfns.c (overlays_around, get_pos_property):
7437 * textprop.c (get_char_property_and_overlay):
7438 * xdisp.c (next_overlay_change, note_mouse_highlight):
7439 * xfaces.c (face_at_buffer_position):
21514da7
PE
7440 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7441 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7442 (Fnext_overlay_change, Fprevious_overlay_change)
7443 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7444 Use ptrdiff_t, not int, for sizes.
21514da7 7445 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7446
3de73e5e
PE
7447 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7448
2606c57b
PE
7449 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7450 (x_session_initialize): Do not assume string length fits in int.
7451
aaafe47a
PE
7452 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7453 This is unlikely, but can occur if DPI is outlandish.
7454
2674ddc8 7455 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7456 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7457
28154962
PE
7458 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7459 * xrdb.c (magic_file_p, search_magic_path):
7460 Omit last arg SUFFIX; it was always 0. All callers changed.
7461 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7462
7de51af5
PE
7463 * xfont.c (xfont_match): Avoid need for strlen.
7464
25ed6cc3
PE
7465 * xfns.c: Don't assume strlen fits in int.
7466 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7467
4eab31dd
PE
7468 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7469 not unsigned long, as we prefer signed integers. All callers changed.
7470 Detect integer overflow in repeat count.
7471 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7472 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7473
171e2a58
PE
7474 * termcap.c: Don't assume sizes fit in int and never overflow.
7475 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7476 (gobble_line): Check for size-calculation overflow.
7477
ad39faca 7478 * minibuf.c (Fread_buffer):
6e5bb2dc 7479 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7480 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7481 Don't assume string length fits in int.
7482
52c61c22 7483 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7484 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7485
b5b8c9e5
PE
7486 * font.c: Don't assume string length fits in int.
7487 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7488 Use ptrdiff_t, not int.
ccd6111c
PE
7489 (font_intern_prop): Don't assume string length fits in int.
7490 Don't assume integer property fits in fixnum.
7491 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7492
882f0d81 7493 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7494 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7495 Reformulate so as not to need the command string.
7496 Invoke gzip -cd rather than gunzip, as it's more portable.
7497 (lock_info_type, lock_file_1, lock_file):
7498 Don't assume pid_t and time_t fit in unsigned long.
7499 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7500 (current_lock_owner): Prefer signed type for sizes.
7501 Use memcpy, not strncpy, where memcpy is what is really wanted.
7502 Don't assume (via atoi) that time_t and pid_t fit in int.
7503 Check for time_t and/or pid_t out of range, e.g., via a network share.
7504 Don't alloca where an auto var works fine.
7505
93f4cf88
PE
7506 * fileio.c: Fix some integer overflow issues.
7507 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7508 Don't assume string length fits in int.
7509 (directory_file_name): Don't assume string length fits in long.
7510 (make_temp_name): Don't assume pid fits in int, or that its print
7511 length is less than 20.
7512
f3e92b69
PE
7513 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7514
1bfdaf10
PE
7515 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7516
35016e9a
PE
7517 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7518
3d1e65a1
PE
7519 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7520 We prefer signed integers, even for size calculations.
7521
0b963a93
PE
7522 * emacs.c: Don't assume string length fits in 'int'.
7523 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7524 (main): Don't invoke strlen when not needed.
7525
573f4b54
PE
7526 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7527 (XD_DEBUG_MESSAGE): Don't waste a byte.
7528
989f33ba
PE
7529 * callproc.c (getenv_internal_1, getenv_internal)
7530 (Fgetenv_internal):
965d34eb
PE
7531 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7532
e4d29b33
PE
7533 * lread.c (invalid_syntax): Omit length argument.
7534 All uses changed. This doesn't fix a bug, but it simplifies the
7535 code away from its former Hollerith-constant appearance, and it's
7536 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7537 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7538
eb49b136
PE
7539 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7540 This didn't break anything, but it didn't help either.
7541 It's confusing to put a bogus integer in a place where the actual
7542 value does not matter.
9f62aeb1 7543 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7544 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7545
15375a22
PE
7546 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7547 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7548 implementation.
b61cc01c
PE
7549 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7550 We prefer signed types, and the value cannot exceed the EMACS_INT
7551 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7552 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7553 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7554 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7555
53b2623d
PE
7556 * indent.c (sane_tab_width): New function.
7557 (current_column, scan_for_column, Findent_to, position_indentation)
7558 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7559 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7560
51cab52b 7561 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7562
f2ed8a70
PE
7563 * lisp.h (lint_assume): New macro.
7564 * composite.c (composition_gstring_put_cache):
7565 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7566
abe80cc6
PE
7567 * editfns.c, insdel.c:
7568 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7569
b02c740e
PE
7570 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7571
ebc96716
PE
7572 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7573
b4e50fa0 7574 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7575 Use much-faster test for byte-length change.
311d5d7c 7576 Don't assume string byte-length fits in 'int'.
a4cf38e4 7577 Check that character arg fits in 'int'.
85461888 7578 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7579
c0c1ee9f
PE
7580 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7581
a498d7f4
PE
7582 * fns.c (concat): Catch string overflow earlier.
7583 Do not rely on integer wraparound.
7584
51cab52b
PE
7585 * dispextern.h (struct it.overlay_strings_charpos)
7586 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7587 * xdisp.c (forward_to_next_line_start)
7588 (back_to_previous_visible_line_start)
7589 (reseat_at_next_visible_line_start, next_element_from_buffer):
7590 Don't arbitrarily truncate the value of 'selective' to int.
7591
76031fad
PE
7592 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7593
5eb55db9
PE
7594 * composite.c: Don't truncate sizes to 'int'.
7595 (composition_gstring_p, composition_reseat_it)
7596 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7597 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7598 not EMACS_UINT, for indexes.
5eb55db9 7599
0703a717
PE
7600 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7601
d6202519
PE
7602 * buffer.c: Include <verify.h>.
7603 (struct sortvec.priority, struct sortstr.priority):
8961a454 7604 Now EMACS_INT, not int.
c20998a7 7605 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7606 (struct sortstr.size, record_overlay_string)
7607 (struct sortstrlist.size, struct sortlist.used):
7608 Don't truncate size to int.
7609 (record_overlay_string): Check for size-calculation overflow.
d6202519 7610 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7611
d5a19415
JM
76122011-06-22 Jim Meyering <meyering@redhat.com>
7613
029529ac 7614 Don't leak an XBM-image-sized buffer
d5a19415
JM
7615 * image.c (xbm_load): Free the image buffer after using it.
7616
a9041e6c
PE
76172011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7618
7619 Port to Sun C.
7620 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7621 that Sun C diagnosed.
7622 * fns.c (secure_hash): Fix pointer signedness issue.
7623 * intervals.c (static_offset_intervals): New function.
7624 (offset_intervals): Use it.
7625
7f3f739f
LL
76262011-06-21 Leo Liu <sdl.web@gmail.com>
7627
7628 * deps.mk (fns.o):
7629 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7630 sha512.h.
7631
7632 * fns.c (secure_hash): Rename from crypto_hash_function and change
7633 the first arg to accept symbols.
5b66d427 7634 (Fsecure_hash): New primitive.
7f3f739f
LL
7635 (syms_of_fns): New symbols.
7636
76147d94
DD
76372011-06-20 Deniz Dogan <deniz@dogan.se>
7638
7639 * process.c (Fset_process_buffer): Clarify return value in
7640 docstring.
7641
7d7d0045
CY
76422011-06-18 Chong Yidong <cyd@stupidchicken.com>
7643
7644 * dispnew.c (add_window_display_history): Use BVAR.
7645
7646 * xdisp.c (debug_method_add): Use BVAR.
7647 (check_window_end, dump_glyph_matrix, dump_glyph)
7648 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7649
7650 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7651 Likewise.
7652
7653 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7654 check till after the cache is created in init_frame_faces.
7655
ff2bc410
SM
76562011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7657
7658 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7659
28177add
PE
76602011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7661
dd3482fe
PE
7662 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7663 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7664 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7665
393d71f3 7666 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7667 * fileio.c (Finsert_file_contents):
7668 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7669 Remove the old (too-loose) buffer overflow checks.
7670 They weren't needed, since make_gap checks for buffer overflow.
7671 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7672 The old code merely checked for Emacs fixnum overflow, and relied
7673 on undefined (wraparound) behavior. The new code avoids undefined
7674 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7675
2e6813b0 7676 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7677 Tune. Don't use wider integers than needed. Don't use alloca.
7678 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7679
599a9e4f
PE
7680 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7681
99561444
PE
7682 * insdel.c, lisp.h (buffer_overflow): New function.
7683 (insert_from_buffer_1, replace_range, replace_range_2):
7684 * insdel.c (make_gap_larger):
7685 * editfns.c (Finsert_char):
7686 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7687
28177add
PE
7688 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7689
e69dafad
PE
76902011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7691
4baa020d 7692 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7693
b1c46f02
PE
7694 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7695 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7696
e69dafad
PE
7697 * fileio.c: Don't assume EMACS_INT fits in off_t.
7698 (emacs_lseek): New static function.
7699 (Finsert_file_contents, Fwrite_region): Use it.
7700 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7701
566684ea
PE
7702 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7703
e6966cd6
PE
7704 * fns.c: Don't overflow int when computing a list length.
7705 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7706 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7707 truncation on 64-bit hosts. Check for QUIT every
7708 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7709 faster and is responsive enough.
7710 (Flength): Report an error instead of overflowing an integer.
7711 (Fsafe_length): Return a float if the value is not representable
7712 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7713 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7714 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7715
dd0b0efb
PE
7716 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7717 (header_size, word_size): New constants.
7718 (allocate_vectorlike): Don't check size overflow here.
7719 (allocate_vector): Check it here instead, since this is the only
7720 caller of allocate_vectorlike that could cause overflow.
7721 Check that the new vector's length is representable as a fixnum.
7722
86fe5cfe
PE
7723 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7724 The previous code was bogus. For example, next_almost_prime (32)
7725 returned 39, which is undesirable as it is a multiple of 3; and
7726 next_almost_prime (24) returned 25, which is a multiple of 5 so
7727 why was the code bothering to check for multiples of 7?
7728
80e88859
PE
7729 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7730
4a2f0ad6
PE
7731 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7732
f66c7cf8
PE
7733 Variadic C functions now count arguments with ptrdiff_t.
7734 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7735 Back then I didn't know that the Emacs coding style prefers signed int.
7736 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7737 were being counted with int, which may truncate counts on 64-bit
7738 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7739 * lisp.h (struct Lisp_Subr.function.aMANY)
7740 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7741 Arg counts are now ptrdiff_t, not size_t.
7742 All variadic functions and their callers changed accordingly.
7743 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7744 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7745 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7746 * callint.c (Fcall_interactively): Check arg count for overflow,
7747 to avoid potential buffer overrun. Use signed char, not 'int',
7748 for 'varies' array, so that we needn't bother to check its size
7749 calculation for overflow.
7750 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7751 * eval.c (apply_lambda):
7752 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7753 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7754 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7755
a1759b76
PE
7756 * callint.c (Fcall_interactively): Don't use index var as event count.
7757
d96be9fc
PE
7758 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7759 * mem-limits.h (SIZE): Remove; no longer used.
7760
a690a978 7761 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7762
578c21e6
PE
7763 Remove unnecessary casts.
7764 * xterm.c (x_term_init):
7765 * xfns.c (x_set_border_pixel):
7766 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7767 These aren't needed now that we assume ANSI C.
7768
96f53c6c
PE
7769 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7770 It's more likely to cause problems (due to unsigned overflow)
7771 than to cure them.
7772
83c77d31
PE
7773 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7774
ee2079f1
PE
7775 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7776
6da65536
PE
7777 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7778
7147c4a4
PE
7779 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7780
193e32d9
PE
7781 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7782
e5533da6
PE
7783 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7784
9910e595
PE
7785 GLYPH_CODE_FACE returns EMACS_INT, not int.
7786 * dispextern.h (merge_faces):
7787 * xfaces.c (merge_faces):
01103c44
PE
7788 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7789 Don't assume EMACS_INT fits in int.
9910e595 7790
2638320e
PE
7791 * character.h (CHAR_VALID_P): Remove unused parameter.
7792 * fontset.c, lisp.h, xdisp.c: All uses changed.
7793
045eb8d9
PE
7794 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7795
c1f134b5
PE
7796 * fns.c (concat): Minor tuning based on overflow analysis.
7797 This doesn't fix any bugs. Use int to hold character, instead
7798 of constantly refetching from Emacs object. Use XFASTINT, not
7799 XINT, for value known to be a character. Don't bother comparing
7800 a single byte to 0400, as it's always less.
7801
395fcb93 7802 * floatfns.c (Fexpt):
327eeec8
PE
7803 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7804
abbd3d23
PE
7805 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7806 for characters.
7807
684a03ef
PE
7808 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7809
0fed43f3
PE
7810 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7811 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7812 incorrectly succeed when S was a string, because 4294967386 was
7813 truncated before it was used.
7814
8fd02eb7
PE
7815 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7816 Otherwise, an out-of-range integer could cause undefined behavior
7817 on a 64-bit host.
7818
f8c86b69
PE
7819 * composite.c: Use int, not EMACS_INT, for characters.
7820 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7821 EMACS_INT, for values that are known to be in character range.
7822 This doesn't fix any bugs but is the usual style inside Emacs and
7823 may generate better code on 32-bit machines.
7824
34206dd2
PE
7825 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7826 This is for reasons similar to the recent CHAR_STRING fix.
7827 * charset.c (Fencode_char): Check that character arg is actually
7828 a character. Pass an int to ENCODE_CHAR.
7829 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7830 wider than 'int', as a compile-time check to prevent future regressions
7831 in this area.
7832
c5958d4c 7833 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7834
7835 Make sure a 64-bit char is never passed to CHAR_STRING.
7836 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7837 by silently ignoring the top 32 bits, allowing some values
7838 that were far too large to be valid characters.
7839 * character.h: Include <verify.h>.
7840 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7841 arguments are no wider than unsigned, as a compile-time check
7842 to prevent future regressions in this area.
7843 * data.c (Faset):
01103c44 7844 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7845 (Fsubst_char_in_region):
7846 * fns.c (concat):
7847 * xdisp.c (decode_mode_spec_coding):
7848 Adjust to CHAR_STRING's new requirement.
7849 * editfns.c (Finsert_char, Fsubst_char_in_region):
7850 * fns.c (concat): Check that character args are actually
7851 characters. Without this test, these functions did the wrong
7852 thing with wildly out-of-range values on 64-bit hosts.
7853
d37ca623
PE
7854 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7855 These casts should not be needed on 32-bit hosts, either.
7856 * keyboard.c (read_char):
7857 * lread.c (Fload): Remove casts to unsigned.
7858
ea204efb
PE
7859 * lisp.h (UNSIGNED_CMP): New macro.
7860 This fixes comparison bugs on 64-bit hosts.
7861 (ASCII_CHAR_P): Use it.
7862 * casefiddle.c (casify_object):
01103c44 7863 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7864 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7865 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7866 * dispextern.h (FACE_FROM_ID):
7867 * keyboard.c (read_char): Use UNSIGNED_CMP.
7868
41cb286c
PE
7869 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7870 not to EMACS_INT, to avoid GCC warning.
7871
4a1b9832
PE
7872 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7873
55daad71
PE
7874 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7875 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7876 isn't needed on 32-bit machines.
8f95c75c 7877
01103c44
PE
7878 * buffer.c (Fgenerate_new_buffer_name):
7879 Use EMACS_INT for count, not int.
0ceccced 7880 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7881
7882 * data.c (Qcompiled_function): Now static.
7883
c6f072e7
PE
7884 * window.c (window_body_lines): Now static.
7885
20ce5912
PE
7886 * image.c (gif_load): Rename local to avoid shadowing.
7887
9c4c5f81
PE
7888 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7889 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7890 * alloc.c (make_save_value): Integer argument is now of type
7891 ptrdiff_t, not int.
7892 (mark_object): Use ptrdiff_t, not int.
7893 * lisp.h (pD): New macro.
7894 * print.c (print_object): Use it.
7895
c0c5c8ae
PE
7896 * alloc.c: Use EMACS_INT, not int, to count objects.
7897 (total_conses, total_markers, total_symbols, total_vector_size)
7898 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7899 (total_free_floats, total_floats, total_free_intervals)
7900 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7901 Now EMACS_INT, not int. All uses changed.
7902 (Fgarbage_collect): Compute overall total using a double, so that
7903 integer overflow is less likely to be a problem. Check for overflow
7904 when converting back to an integer.
5a25e253
PE
7905 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7906 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7907 These were 'int' variables that could overflow on 64-bit hosts;
7908 they were never used, so remove them instead of repairing them.
211a0b2a 7909 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7910 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7911 Previously, this ceilinged at INT_MAX, but that doesn't work on
7912 64-bit machines.
e46bb31a 7913 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7914
c78baabf 7915 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7916 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7917 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7918 when a (possibly-narrower) signed value would do just as well.
7919 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7920
c9d624c6
PE
7921 * alloc.c: Catch some string size overflows that we were missing.
7922 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7923 for convenience in STRING_BYTES_MAX.
7924 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7925 The definition here is exact; the one in lisp.h was approximate.
7926 (allocate_string_data): Check for string overflow. This catches
7927 some instances we weren't catching before. Also, it catches
7928 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7929 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7930 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7931
c9d624c6
PE
7932 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7933 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7934 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7935
353032ce
PE
7936 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7937
2bccce07
PE
7938 * alloc.c (Fmake_string): Check for out-of-range init.
7939
0ac30604
SM
79402011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7941
7942 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7943
c195f2de
JD
79442011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7945
7946 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7947 xg_get_default_scrollbar_width.
7948
7949 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7950 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7951 (style_changed_cb): Call update_theme_scrollbar_width and call
7952 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7953 all frames (Bug#8505).
7954 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7955 Call gtk_window_set_resizable if HAVE_GTK3.
7956 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7957 and height if HAVE_GTK3 (Bug#8505).
7958 (scroll_bar_width_for_theme): New variable.
7959 (update_theme_scrollbar_width): New function.
7960 (xg_get_default_scrollbar_width): Move code to
7961 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7962 (xg_initialize): Call update_theme_scrollbar_width.
7963
7964 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7965
7966 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7967
e10ac9f1
MR
79682011-06-12 Martin Rudalics <rudalics@gmx.at>
7969
7970 * frame.c (make_frame): Call other_buffer_safely instead of
7971 other_buffer.
7972
7973 * window.c (temp_output_buffer_show): Call display_buffer with
7974 second argument Vtemp_buffer_show_specifiers and reset latter
7975 immediately after the call.
7976 (Vtemp_buffer_show_specifiers): New variable.
7977 (auto_window_vscroll_p, next_screen_context_lines)
7978 (Vscroll_preserve_screen_position): Remove leading asterisks from
7979 doc-strings.
7980
2d3c217e 79812011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7982
7b7f97e8 7983 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7984 * buffer.c (Qclone_number): Remove for now, as it's unused.
7985 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7986 (record_buffer): Remove unused local.
7987 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7988 (set_frame_buffer_list): Remove; unused.
7989 * frame.h (other_visible_frames): Remove decl.
7990 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7991 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7992 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7993 if HAVE_GPM.
7994 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7995 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7996 Define only if HAVE_GPM.
7997 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7998 (update_hints_inhibit): Remove; never set. All uses removed.
7999 * widgetprv.h (emacsFrameClassRec): Remove decl.
8000 * window.c (delete_deletable_window): Now returns void, since it
8001 wasn't returning anything.
8002 (compare_window_configurations): Remove unused locals.
8003 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8004 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8005 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8006 the same widths as pointers. This follows up on the 2011-05-06 patch.
8007 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8008 * xterm.h: Likewise.
8009 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8010
1384b89e
JB
80112011-06-12 Juanma Barranquero <lekktu@gmail.com>
8012
8013 * makefile.w32-in: Update dependencies.
8014 (LISP_H): Add lib/intprops.h.
8015
1100a63c
CY
80162011-06-11 Chong Yidong <cyd@stupidchicken.com>
8017
8018 * image.c (gif_load): Add animation frame delay to the metadata.
8019 (syms_of_image): Use DEFSYM. New symbol `delay'.
8020
6198ccd0
MR
80212011-06-11 Martin Rudalics <rudalics@gmx.at>
8022
8023 * window.c (delete_deletable_window): Re-add.
8024 (Fset_window_configuration): Rewrite to handle dead buffers and
8025 consequently deletable windows.
8026 (window_tree, Fwindow_tree): Remove. Supply functionality in
8027 window.el.
8028 (compare_window_configurations): Simplify code.
8029
b6e3633c
AS
80302011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8031
1ab0dee5
AS
8032 * image.c (imagemagick_load_image): Fix type mismatch.
8033 (Fimagemagick_types): Likewise.
8034
b6e3633c
AS
8035 * window.h (replace_buffer_in_windows): Declare.
8036
9397e56f
MR
80372011-06-11 Martin Rudalics <rudalics@gmx.at>
8038
8039 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8040 Qclone_number. Remove external declaration of Qdelete_window.
8041 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8042 code.
640c8776
SM
8043 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8044 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8045 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8046 buffer list implementation.
8047 (other_buffer_safely): New function.
8048 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8049 calls to replace_buffer_in_windows and
8050 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8051 if allowed.
8052 (record_buffer): Inhibit quitting and rewrite using quittable
8053 functions. Run Qbuffer_list_update_hook if allowed.
8054 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8055 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8056 Move switch-to-buffer to window.el.
9397e56f
MR
8057 (bury-buffer): Move to window.el.
8058 (Vbuffer_list_update_hook): New variable.
8059
8060 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8061 section.
8062
8063 * window.h (resize_frame_windows): Move up in code.
8064 (Fwindow_frame): Remove EXFUN.
8065 (replace_buffer_in_all_windows): Remove prototype.
8066 (replace_buffer_in_windows_safely): Add prototype.
8067
8068 * window.c: Declare Qdelete_window static again. Move down
8069 declaration of select_count.
8070 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8071 (Fother_window): Move to window.el.
8072 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8073 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8074 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8075 window.el.
8076 (replace_buffer_in_windows): Implement by calling
8077 Qreplace_buffer_in_windows.
8078 (replace_buffer_in_all_windows): Remove with some functionality
8079 moved into replace_buffer_in_windows_safely.
8080 (replace_buffer_in_windows_safely): New function.
8081 (select_window_norecord, select_frame_norecord): Move in front
8082 of run_window_configuration_change_hook. Remove now obsolete
8083 declarations.
640c8776
SM
8084 (Fset_window_buffer): Rewrite doc-string.
8085 Call Qrecord_window_buffer.
9397e56f
MR
8086 (keys_of_window): Move binding for other-window to window.el.
8087
b50691aa
CY
80882011-06-11 Chong Yidong <cyd@stupidchicken.com>
8089
8090 * dispextern.h (struct image): Replace data member, whose int_val
8091 and ptr_val fields were not used by anything, with a single
8092 lisp_val object.
8093
8094 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8095 (gif_clear_image, gif_load, imagemagick_load_image)
8096 (gs_clear_image, gs_load): Callers changed.
8097
3f754b86
PE
80982011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8099
cca69397
PE
8100 * buffer.h: Include <time.h>, for time_t.
8101 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8102
109e28d0
PE
8103 Fix minor problems found by static checking.
8104
60737f02
PE
8105 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8106
4b66faf3
PE
8107 Make identifiers static if they are not used in other modules.
8108 * data.c (Qcompiled_function, Qframe, Qvector):
8109 * image.c (QimageMagick, Qsvg):
8110 * minibuf.c (Qmetadata):
8111 * window.c (resize_window_check, resize_root_window): Now static.
8112 * window.h (resize_window_check, resize_root_window): Remove decls.
8113
109e28d0
PE
8114 * window.c (window_deletion_count, delete_deletable_window):
8115 Remove; unused.
46a4ce9e
PE
8116 (window_body_lines): Now static.
8117 (Fdelete_other_windows_internal): Mark vars as initialized.
8118 Make sure 'resize_failed' is initialized.
8119 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8120 (resize_window_apply): Remove unused local.
8121 * window.h (delete_deletable_window): Remove decl.
8122
109e28d0 8123 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8124 (imagemagick_load_image): Fix pointer signedness problem by changing
8125 last arg from unsigned char * to char *. All uses changed.
8126 Also, fix a local for similar reasons.
8127 Remove unused locals. Remove locals to avoid shadowing.
8128 (fn_rsvg_handle_free): Remove; unused.
8129 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8130 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8131
3f754b86
PE
8132 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8133
2547adb1
CY
81342011-06-10 Chong Yidong <cyd@stupidchicken.com>
8135
8136 * image.c (gif_load): Fix omitted cast error introduced by
8137 2011-06-06 change.
8138
2c8e37d4
MR
81392011-06-10 Martin Rudalics <rudalics@gmx.at>
8140
8141 * window.h (resize_proportionally, orig_total_lines)
8142 (orig_top_line): Remove from window structure.
8143 (set_window_height, set_window_width, change_window_heights)
8144 (Fdelete_window): Remove prototypes.
8145 (resize_frame_windows): Remove duplicate declaration.
8146
440a42e3
EZ
81472011-06-10 Eli Zaretskii <eliz@gnu.org>
8148
8149 * window.h (resize_frame_windows, resize_window_check)
8150 (delete_deletable_window, resize_root_window)
8151 (resize_frame_windows): Declare prototypes.
8152
8153 * window.c (resize_window_apply): Make definition be "static" to
8154 match the prototype.
8155
562dd5e9
MR
81562011-06-10 Martin Rudalics <rudalics@gmx.at>
8157
8158 * window.c: Remove declarations of Qwindow_size_fixed,
8159 window_min_size_1, window_min_size_2, window_min_size,
8160 size_window, window_fixed_size_p, enlarge_window, delete_window.
8161 Remove static from declaration of Qdelete_window, it's
8162 temporarily needed by Fbury_buffer.
8163 (replace_window): Don't assign orig_top_line and
8164 orig_total_lines.
8165 (Fdelete_window, delete_window): Remove. Window deletion is
8166 handled by window.el.
640c8776
SM
8167 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8168 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8169 (Fdelete_other_windows): Remove. Deleting other windows is
8170 handled by window.el.
8171 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8172 handled in window.el.
8173 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8174 Window minimum sizes are handled in window.el.
8175 (shrink_windows, size_window, set_window_height)
8176 (set_window_width, change_window_heights, window_height)
8177 (window_width, CURBEG, CURSIZE, enlarge_window)
8178 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8179 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8180 handled in window.el.
8181 (make_dummy_parent): Rename to make_parent_window and give it a
8182 second argument horflag.
8183 (make_window): Don't set resize_proportionally any more.
8184 (Fsplit_window): Remove. Windows are split in window.el.
8185 (save_restore_action, save_restore_orig_size)
8186 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8187 Resize mini windows in window.el.
8188 (grow_mini_window, shrink_mini_window): Implement by calling
8189 Qresize_root_window_vertically, resize_window_check and
8190 resize_window_apply.
640c8776
SM
8191 (saved_window, Fset_window_configuration, save_window_save):
8192 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8193 resize_proportionally.
8194 (window_min_height, window_min_width): Move to window.el.
8195 (keys_of_window): Move bindings for delete-other-windows,
8196 split-window, delete-window and enlarge-window to window.el.
8197
8198 * buffer.c: Temporarily extern Qdelete_window.
8199 (Fbury_buffer): Temporarily call Qdelete_window instead of
8200 Fdelete_window (Fbury_buffer will move to window.el soon).
8201
8202 * frame.c (set_menu_bar_lines_1): Remove code handling
8203 orig_top_line and orig_total_lines.
8204
8205 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8206 set_window_height but set heights directly.
8207 (change_frame_size_1): Use resize_frame_windows.
8208
8209 * xdisp.c (init_xdisp): Don't use set_window_height but set
8210 heights directly.
8211
640c8776
SM
8212 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8213 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8214 run_window_configuration_change_hook.
8215
8216 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8217 instead of change_window_heights and run
8218 run_window_configuration_change_hook.
8219
1a13852e
MR
82202011-06-09 Martin Rudalics <rudalics@gmx.at>
8221
8222 * window.c (replace_window): Rename second argument REPLACEMENT to
8223 NEW. New third argument SETFLAG. Rewrite.
8224 (delete_window, make_dummy_parent): Call replace_window with
8225 third argument 1.
8226 (window_list_1): Move down in code.
8227 (run_window_configuration_change_hook): Move set_buffer part
8228 before select_frame_norecord part in order to unwind correctly.
8229 Rename count1 to count.
8230 (recombine_windows, delete_deletable_window, resize_root_window)
8231 (Fdelete_other_windows_internal)
8232 (Frun_window_configuration_change_hook, make_parent_window)
8233 (resize_window_check, resize_window_apply, Fresize_window_apply)
8234 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8235 (Fdelete_window_internal, Fresize_mini_window_internal):
8236 New functions.
1a13852e
MR
8237 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8238
f3d1777e
MR
82392011-06-08 Martin Rudalics <rudalics@gmx.at>
8240
496e208e
MR
8241 * window.h (window): Add some new members to window structure -
8242 normal_lines, normal_cols, new_total, new_normal, clone_number,
8243 splits, nest, prev_buffers, next_buffers.
8244 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8245 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8246
f3d1777e
MR
8247 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8248 Remove.
496e208e
MR
8249 (make_dummy_parent): Set new members of windows structure.
8250 (make_window): Move down in code. Handle new members of window
8251 structure.
8252 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8253 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8254 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8255 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8256 (Fset_window_next_buffers, Fset_window_clone_number):
8257 New functions.
496e208e
MR
8258 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8259 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8260 Doc-string fixes.
8261 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8262 Argument WINDOW can be now internal window too.
8263 (Fwindow_use_time): Move up in code.
8264 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8265 Rewrite doc-string.
8266 (Fset_window_configuration, saved_window)
8267 (Fcurrent_window_configuration, save_window_save): Handle new
8268 members of window structure.
b9e809c2
MR
8269 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8270 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8271 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8272 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8273 Qget_mru_window, Qresize_root_window,
8274 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8275 Qauto_buffer_name; staticpro them.
f3d1777e 8276
abde8f8c
MR
82772011-06-07 Martin Rudalics <rudalics@gmx.at>
8278
8279 * window.c (Fwindow_total_size, Fwindow_left_column)
8280 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8281 (Fwindow_list_1): New functions.
8282 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8283 (Fwindow_width, Fscroll_left, Fscroll_right):
8284 Use window_body_cols instead of window_box_text_cols.
8285 (delete_window, Fset_window_configuration):
8286 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8287 (delete_all_subwindows): Take a window as argument and not a
8288 structure. Rewrite.
190b47e6
MR
8289 (window_loop): Remove handling of GET_LRU_WINDOW and
8290 GET_LARGEST_WINDOW.
8291 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8292
8293 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8294 window_box_text_cols. delete_all_subwindows now takes a
8295 Lisp_Object as argument.
abde8f8c 8296
640c8776
SM
8297 * indent.c (compute_motion, Fcompute_motion):
8298 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8299
fa8a67e6
MR
8300 * frame.c (delete_frame): Call delete_all_subwindows with root
8301 window as argument.
8302
a54e3482
DC
83032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8304
8305 * fns.c (Fputhash): Document return value.
8306
60002bf5
CY
83072011-06-06 Chong Yidong <cyd@stupidchicken.com>
8308
8309 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8310
0c671da6 83112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8312
b862a52a 8313 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8314
be44ca6c
PE
8315 Check for overflow when converting integer to cons and back.
8316 * charset.c (Fdefine_charset_internal, Fdecode_char):
8317 Use cons_to_unsigned to catch overflow.
8318 (Fencode_char): Use INTEGER_TO_CONS.
8319 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8320 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8321 * data.c (long_to_cons, cons_to_long): Remove.
8322 (cons_to_unsigned, cons_to_signed): New functions.
8323 These signal an error for invalid or out-of-range values.
8324 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8325 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8326 * font.c (Ffont_variation_glyphs):
8327 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8328 * lisp.h: Include <intprops.h>.
8329 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8330 (cons_to_signed, cons_to_unsigned): New decls.
8331 (long_to_cons, cons_to_long): Remove decls.
8332 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8333 (Fprimitive_undo): Use CONS_TO_INTEGER.
8334 * xfns.c (Fx_window_property): Likewise.
8335 * xselect.c: Include <limits.h>.
8336 (x_own_selection, selection_data_to_lisp_data):
8337 Use INTEGER_TO_CONS.
8338 (x_handle_selection_request, x_handle_selection_clear)
8339 (x_get_foreign_selection, Fx_disown_selection_internal)
8340 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8341 (lisp_data_to_selection_data): Use cons_to_unsigned.
8342 (x_fill_property_data): Use cons_to_signed.
8343 Report values out of range.
8344
d1f3d2af
PE
8345 Check for buffer and string overflow more precisely.
8346 * buffer.h (BUF_BYTES_MAX): New macro.
8347 * lisp.h (STRING_BYTES_MAX): New macro.
8348 * alloc.c (Fmake_string):
8349 * character.c (string_escape_byte8):
8350 * coding.c (coding_alloc_by_realloc):
8351 * doprnt.c (doprnt):
8352 * editfns.c (Fformat):
8353 * eval.c (verror):
8354 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8355 since they may not be the same number.
8356 * editfns.c (Finsert_char):
8357 * fileio.c (Finsert_file_contents):
8358 Likewise for BUF_BYTES_MAX.
8359
dd52fcea
PE
8360 * image.c: Use ptrdiff_t, not int, for sizes.
8361 (slurp_file): Switch from int to ptrdiff_t.
8362 All uses changed.
8363 (slurp_file): Check that file size fits in both size_t (for
8364 malloc) and ptrdiff_t (for sanity and safety).
8365
7f9bbdbb
PE
8366 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8367 if b->modtime has its maximal value.
8368
dfe18f82
PE
8369 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8370
84acfcf0
PE
8371 Don't assume time_t can fit into int.
8372 * buffer.h (struct buffer.modtime): Now time_t, not int.
8373 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8374 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8375
ccd9a01a
PE
8376 Minor fixes for signed vs unsigned integers.
8377 * character.h (MAYBE_UNIFY_CHAR):
8378 * charset.c (maybe_unify_char):
8379 * keyboard.c (read_char, reorder_modifiers):
8380 XINT -> XFASTINT, since the integer must be nonnegative.
8381 * ftfont.c (ftfont_spec_pattern):
8382 * keymap.c (access_keymap, silly_event_symbol_error):
8383 XUINT -> XFASTINT, since the integer must be nonnegative.
8384 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8385 since it makes no difference and we prefer signed.
8386 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8387 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8388 nonnegative.
8389
d6d100dd
SM
83902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8391
8392 * window.h (Fwindow_frame): Declare.
8393
2b6148e4
PE
83942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8395
8396 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8397 (SPARE_MEMORY): Always define.
8398 (LARGE_REQUEST): Remove.
8399 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8400
f230ecc9
MR
84012011-06-06 Martin Rudalics <rudalics@gmx.at>
8402
727e958e
MR
8403 * lisp.h: Move EXFUNS for Fframe_root_window,
8404 Fframe_first_window and Fset_frame_selected_window to window.h.
8405
8406 * window.h: Move EXFUNS for Fframe_root_window,
8407 Fframe_first_window and Fset_frame_selected_window here from
8408 lisp.h.
8409
8410 * frame.c (Fwindow_frame, Fframe_first_window)
8411 (Fframe_root_window, Fframe_selected_window)
8412 (Fset_frame_selected_window): Move to window.c.
8413 (Factive_minibuffer_window): Move to minibuf.c.
8414 (Fother_visible_frames_p): New function.
8415
8416 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8417
f230ecc9
MR
8418 * window.c (decode_window, decode_any_window): Move up in code.
8419 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8420 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8421 (Fwindow_buffer): Move up and rewrite doc-string.
8422 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8423 (Fwindow_prev): New functions.
727e958e
MR
8424 (Fwindow_frame): Move here from frame.c. Accept any window as
8425 argument.
8426 (Fframe_root_window, Fframe_first_window)
8427 (Fframe_selected_window): Move here from frame.c. Accept frame
8428 or arbitrary window as argument. Update doc-strings.
8429 (Fminibuffer_window): Move up in code.
8430 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8431 (Fset_frame_selected_window): Move here from frame.c.
8432 Marginal rewrite.
727e958e
MR
8433 (Fselected_window, select_window, Fselect_window): Move up in
8434 code. Minor doc-string fixes.
f230ecc9 8435
4d09bcf6
PE
84362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8437
8438 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8439 Do not assume that spare memory exists; that assumption is valid
8440 only if SYSTEM_MALLOC.
8441 (LARGE_REQUEST): New macro, so that the issue of large requests
8442 is separated from the issue of spare memory.
8443
810928a2
AS
84442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8445
172418ad
AS
8446 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8447 format. (Bug#8806)
8448
43f862f7
AS
8449 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8450
810928a2
AS
8451 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8452 before statements.
8453
a059fe24
JD
84542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8455
8456 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8457
8458 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8459
8460 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8461 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8462
989bf368
JB
84632011-06-05 Juanma Barranquero <lekktu@gmail.com>
8464
8465 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8466
4b80f674
CY
84672011-06-04 Chong Yidong <cyd@stupidchicken.com>
8468
8469 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8470 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8471 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8472 New error handlers.
4b80f674
CY
8473 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8474 Obey Vx_select_enable_clipboard_manager. Catch errors in
8475 x_clipboard_manager_save (Bug#8779).
8476 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8477 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8478
99a33b77 84792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8480
8481 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8482
99a33b77 84832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8484
8485 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8486 in the current matrix if keep_current_p is non-zero.
8487
8264569d
EZ
84882011-06-04 Eli Zaretskii <eliz@gnu.org>
8489
8490 * bidi.c (bidi_level_of_next_char): Fix last change.
8491
57f97249
EZ
84922011-06-03 Eli Zaretskii <eliz@gnu.org>
8493
fec2107c 8494 Support bidi reordering of text covered by display properties.
57f97249 8495
fec2107c
EZ
8496 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8497 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8498 (bidi_cache_search, bidi_cache_iterator_state)
8499 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8500 (bidi_level_of_next_char, bidi_move_to_visually_next):
8501 Support character positions inside a run of characters covered by a
fec2107c
EZ
8502 display string.
8503 (bidi_paragraph_init, bidi_resolve_explicit_1)
8504 (bidi_level_of_next_char): Call bidi_fetch_char and
8505 bidi_fetch_char_advance instead of FETCH_CHAR and
8506 FETCH_CHAR_ADVANCE.
8507 (bidi_init_it): Initialize new members.
8508 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8509 definitions.
8510 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8511 instead of using explicit *_CHAR codes.
d6d100dd
SM
8512 (bidi_resolve_explicit, bidi_resolve_weak):
8513 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8514 bidirectional text is supported only in multibyte buffers.
8515 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8516 it to initialize the frame_window_p member of struct bidi_it.
8517 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8518 (bidi_resolve_explicit, bidi_resolve_weak)
8519 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8520 bidi_it->nchars is non-positive.
8521 (bidi_level_of_next_char): Don't try to lookup the cache for the
8522 next/previous character if nothing is cached there yet, or if we
8523 were just reseat()'ed to a new position.
c40e2fb2 8524
0e14fe90
EZ
8525 * xdisp.c (set_cursor_from_row): Set start and stop points
8526 according to the row's direction when priming the loop that looks
8527 for the glyph on which to display cursor.
8528 (single_display_spec_intangible_p): Function deleted.
8529 (display_prop_intangible_p): Reimplement to call
8530 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8531 Accept 3 additional arguments needed by handle_display_spec.
8532 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8533 values: lists, `(when COND...)' forms, etc.
8534 (single_display_spec_string_p): Support property values that are
8535 lists with the argument STRING its top-level element.
8536 (display_prop_string_p): Fix the condition for processing a
8537 property that is a list to be consistent with handle_display_spec.
fec2107c 8538 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8539 last portion of handle_display_prop.
8540 (compute_display_string_pos): Accept additional argument
8541 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8542 value of a `display' property is a "replacing spec".
8543 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8544 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8545 the display property, but just return a value indicating whether
8546 the display property will replace the characters it covers.
8547 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8548 frame_window_p members of struct bidi_it.
d6d100dd
SM
8549 (compute_display_string_pos, compute_display_string_end):
8550 New functions.
fec2107c
EZ
8551 (push_it): Accept second argument POSITION, where pop_it should
8552 jump to continue iteration.
8553 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8554
fec2107c
EZ
8555 * keyboard.c (adjust_point_for_property): Adjust the call to
8556 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8557
8558 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8559 (bidi_init_it): Update prototypes.
8560 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8561 (compute_display_string_pos, compute_display_string_end):
8562 Declare prototypes.
fec2107c
EZ
8563 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8564 EMACS_INT.
fc6f18ce 8565
40087514 85662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8567
57f53182
PE
8568 Malloc failure behavior now depends on size of allocation.
8569 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8570 * lisp.h: Change signatures accordingly.
8571 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8572 All callers changed. (Bug#8762)
8573
8574 * gnutls.c: Use Emacs's memory allocators.
8575 Without this change, the gnutls library would invoke malloc etc.
8576 directly, which causes problems on non-SYNC_INPUT hosts, and which
8577 runs afoul of improving memory_full behavior. (Bug#8761)
8578 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8579 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8580 xfree instead of the default malloc, realloc, free.
8581 (Fgnutls_boot): No need to check for memory allocation failure,
8582 since xmalloc does that for us.
8583
ac32cd99 8584 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8585 * category.c (hash_get_category_set):
8586 * ccl.c (ccl_driver):
8587 * charset.c (Fdefine_charset_internal):
8588 * charset.h (struct charset.hash_index):
8589 * composite.c (get_composition_id, gstring_lookup_cache)
8590 (composition_gstring_put_cache):
8591 * composite.h (struct composition.hash_index):
8592 * dispextern.h (struct image.hash):
8593 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8594 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8595 (hashfn_equal, hashfn_user_defined, make_hash_table)
8596 (maybe_resize_hash_table, hash_lookup, hash_put)
8597 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8598 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8599 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8600 * image.c (make_image, search_image_cache, lookup_image)
8601 (xpm_put_color_table_h):
8602 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8603 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8604 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8605 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8606 * alloc.c (allocate_vectorlike):
8607 Check for overflow in vector size calculations.
8608 * ccl.c (ccl_driver):
8609 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8610 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8611 need to be updated by these changes.
40087514
PE
8612 * fns.c (make_hash_table, maybe_resize_hash_table):
8613 Check for integer overflow with large hash tables.
0de4bb68
PE
8614 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8615 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8616 (SXHASH_REDUCE): New macro.
8617 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8618 Use it instead of discarding useful hash info with large hash values.
8619 (sxhash_float): New function.
8620 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8621 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8622 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8623 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8624 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8625 Adjust signatures to match updated version of code.
8626 (consing_since_gc): Now EMACS_INT, since a single hash table can
8627 use more than INT_MAX bytes.
8628
698d32e2
DN
86292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8630
8631 Make it possible to build with GCC-4.6+ -O2 -flto.
8632
8633 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8634
fd6fa53f
SM
86352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8636
8637 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8638 Call minibuffer-inactive-mode.
8639
864db017
JB
86402011-05-31 Juanma Barranquero <lekktu@gmail.com>
8641
8642 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8643 Update dependencies.
8644
2ad0baf4
DN
86452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8646
8647 * data.c (init_data): Remove code for UTS, this system is not
8648 supported anymore.
8649
4fcc2638
DN
86502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8651
8652 Don't force ./temacs to start in terminal mode.
8653
8654 * frame.c (make_initial_frame): Initialize faces in all cases, not
8655 only when CANNOT_DUMP is defined.
8656 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8657
c56e0fd5
DN
86582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8659
8660 * dispnew.c (add_window_display_history): Use const for the string
8661 pointer. Remove declaration, not needed.
8662
333d54da 86632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8664
55d4c1b2 8665 Use 'inline', not 'INLINE'.
333d54da 8666 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8667 * alloc.c, fontset.c (INLINE): Remove.
8668 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8669 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8670 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8671 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8672 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8673
738db178
DN
86742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8675
8676 Make it possible to run ./temacs.
8677
8678 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8679 syms_of_callproc does the same thing. Remove test for
8680 "initialized", do it in the caller.
8681 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8682
620c53a6
SM
86832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8684
8685 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8686 (read_minibuf): Use get_minibuffer.
8687 (syms_of_minibuf): Use DEFSYM.
8688 (Qmetadata): New var.
8689 * data.c (Qbuffer): Don't make it static.
8690 (syms_of_data): Use DEFSYM.
8691
e003a292
PE
86922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8693
8694 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8695 (CCL_CODE_MIN): New macro.
8696
ed008a6d
PE
86972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8698
3687c2ef
PE
8699 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8700
ed008a6d
PE
8701 * eval.c (Qdebug): Now static.
8702 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8703 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8704 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8705
d66c4c7c
CY
87062011-05-29 Chong Yidong <cyd@stupidchicken.com>
8707
8708 * image.c: Various fixes to ImageMagick code comments.
8709 (Fimagemagick_types): Doc fix.
8710
5fbc2025
PE
87112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8712
0196f88a
PE
8713 Minor fixes prompted by GCC 4.6.0 warnings.
8714
8715 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8716
5fbc2025
PE
8717 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8718 (x_clipboard_manager_save_all): Move extern decl to ...
8719 * xterm.h: ... here, so that it can be checked for consistency.
8720
1dd3c2d9
CY
87212011-05-29 Chong Yidong <cyd@stupidchicken.com>
8722
8723 * xselect.c (x_clipboard_manager_save_frame)
8724 (x_clipboard_manager_save_all): New functions.
8725 (Fx_clipboard_manager_save): Lisp function deleted.
8726
8727 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8728 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8729
8730 * xterm.h: Update prototype.
8731
5ba6571d
WX
87322011-05-28 William Xu <william.xwl@gmail.com>
8733
8734 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8735 exiting (Bug#8239).
8736
3eaff834
JM
87372011-05-28 Jim Meyering <meyering@redhat.com>
8738
e1900994 8739 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8740 * fns.c (to_uchar): Define.
8741 (crypto_hash_function): Use it to convert some newly-signed
8742 variables to unsigned, to avoid sign-extension bugs. For example,
8743 without this change, (md5 "truc") would evaluate to
8744 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8745 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8746 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8747
0f6990a7
PE
87482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8749
8750 Integer overflow fixes.
c8a9ca5a 8751
08686060
PE
8752 * dbusbind.c: Serial number integer overflow fixes.
8753 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8754 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8755 to hold a serial number that is too large for a fixnum.
8756 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8757 Check for serial numbers out of range. Decode any serial number
59568bf0 8758 that was so large that it became a float. (Bug#8722)
08686060 8759
2d1fc3c7
PE
8760 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8761 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8762 Use XFASTINT rather than XUINT when numbers are nonnegative.
8763 (xd_append_arg, Fdbus_method_return_internal):
8764 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8765 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8766 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8767 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8768 (Bug#8722)
2d1fc3c7 8769
c8a9ca5a
PE
8770 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8771
519e1d69
PE
8772 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8773
6df6ae42 8774 ccl: Add integer overflow checks.
30569699
PE
8775 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8776 (IN_INT_RANGE): New macros.
8777 (ccl_driver): Use them to check for integer overflow when
8778 decoding a CCL program. Many of the new checks are whether XINT (x)
8779 fits in int; it doesn't always, on 64-bit hosts. The new version
8780 doesn't catch all possible integer overflows, but it's an
847044ea 8781 improvement. (Bug#8719)
30569699 8782
c11285dc
PE
8783 * alloc.c (make_event_array): Use XINT, not XUINT.
8784 There's no need for unsigned here.
8785
fdccd48e
PE
8786 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8787 This follows up to the 2011-05-06 change that substituted uintptr_t
8788 for EMACS_INT. This case wasn't caught back then.
8789
37910ab2
PE
8790 Rework Fformat to avoid integer overflow issues.
8791 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8792 now (part of C89). Include <verify.h>.
8793 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8794 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8795 (Fformat): Avoid the prepass trying to compute sizes; it was only
8796 approximate and thus did not catch overflow reliably. Instead, walk
8797 through the format just once, formatting and computing sizes as we go,
8798 checking for integer overflow at every step, and allocating a larger
8799 buffer as needed. Keep track separately whether the format is
8800 multibyte. Keep only the most-recently calculated precision, rather
8801 than them all. Record whether each argument has been converted to
8802 string. Use EMACS_INT, not int, for byte and char and arg counts.
8803 Support field widths and precisions larger than INT_MAX. Avoid
8804 sprintf's undefined behavior with conversion specifications such as %#d
8805 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8806 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8807 formatting out-of-range floating point numbers with int
9173deec 8808 formats. (Bug#8668)
37910ab2 8809
2e6578fb
PE
8810 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8811
0ae6bdee
PE
8812 * data.c: Avoid integer truncation in expressions involving floats.
8813 * data.c: Include <intprops.h>.
8814 (arith_driver): When there's an integer overflow in an expression
8815 involving floating point, convert the integers to floating point
8816 so that the resulting value does not suffer from catastrophic
8817 integer truncation. For example, on a 64-bit host (* 4
8818 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8819 Do not rely on undefined behavior after integer overflow.
8820
de883a70
PE
8821 merge count_size_as_multibyte, parse_str_to_multibyte
8822 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8823 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8824 Check for integer overflow.
8825 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8826 since it's now a duplicate of the other. This is more of
8827 a character than a buffer op, so better that it's in character.c.
8828 * fns.c, print.c: Adjust to above changes.
8829
2ff916cb
PE
88302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8831
8832 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8833
f1b54466
PE
88342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8835
fb1ac845
PE
8836 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8837 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8838 (x_clipboard_manager_save): Now static.
8839 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8840
f1b54466
PE
8841 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8842 (crypto_hash_function): Now static.
8843 Fix pointer signedness problems. Avoid unnecessary initializations.
8844
a9f737ee
CY
88452011-05-27 Chong Yidong <cyd@stupidchicken.com>
8846
8847 * termhooks.h (Vselection_alist): Make it terminal-local.
8848
8849 * terminal.c (create_terminal): Initialize it.
8850
8851 * xselect.c: Support for clipboard managers.
8852 (Vselection_alist): Move to termhooks.h as terminal-local var.
8853 (LOCAL_SELECTION): New macro.
8854 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8855 (symbol_to_x_atom): Remove gratuitous arg.
8856 (x_handle_selection_request, lisp_data_to_selection_data)
8857 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8858 (x_own_selection, x_get_local_selection, x_convert_selection):
8859 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8860 (some_frame_on_display): Delete unused function.
8861 (Fx_own_selection_internal, Fx_get_selection_internal)
8862 (Fx_disown_selection_internal, Fx_selection_owner_p)
8863 (Fx_selection_exists_p): New optional frame arg.
8864 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8865 (x_handle_selection_clear): Don't treat other terminals with the
8866 same keyboard specially. Use the terminal-local Vselection_alist.
8867 (x_clear_frame_selections): Use Frun_hook_with_args.
8868
8869 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8870
8871 * xterm.h: Add support for those atoms.
8872
e067f0c1
CY
88732011-05-26 Chong Yidong <cyd@stupidchicken.com>
8874
8875 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8876 (converted_selections, conversion_fail_tag): New global variables.
8877 (x_selection_request_lisp_error): Free the above.
8878 (x_get_local_selection): Remove unnecessary code.
8879 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8880 of converted selections stored in converted_selections.
8881 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8882 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8883 (x_convert_selection): New function.
8884 (x_handle_selection_event): Simplify.
8885 (x_get_foreign_selection): Don't ignore incoming requests while
8886 waiting for an answer; this will fail when we implement
8887 SAVE_TARGETS, and seems unnecessary anyway.
8888 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8889 (Vx_sent_selection_functions): Doc fix.
8890
0f4aebc0
LL
88912011-05-26 Leo Liu <sdl.web@gmail.com>
8892
8893 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8894
e61124cd
YM
88952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8896
8897 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8898
8899 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8900 for fringe update if it has periodic bitmap.
ac389d0c 8901 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8902 and fringe_bitmap_periodic_p.
8903
8904 * fringe.c (get_fringe_bitmap_data): New function.
8905 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8906 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8907 row. Mark glyph row for fringe update if periodicity changed.
8908
8909 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8910 for fringe update unless it has periodic bitmap.
8911
f16d9837
KH
89122011-05-25 Kenichi Handa <handa@m17n.org>
8913
8914 * xdisp.c (get_next_display_element): Set correct it->face_id for
8915 a static composition.
8916
e1b90ef6
LL
89172011-05-24 Leo Liu <sdl.web@gmail.com>
8918
8919 * deps.mk (fns.o):
8920 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8921
8922 * fns.c (crypto_hash_function, Fsha1): New function.
8923 (Fmd5): Use crypto_hash_function.
8924 (syms_of_fns): Add Ssha1.
8925
7400048f
PE
89262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8927
8928 * gnutls.c: Remove unused macros.
8929 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8930 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8931 Remove macros that are defined and never used.
8932 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8933
abb71cf4
CY
89342011-05-22 Chong Yidong <cyd@stupidchicken.com>
8935
8936 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8937 (Fx_get_selection_internal): Minor cleanup.
8938 (Fx_own_selection_internal): Rename arguments for consistency with
8939 select.el.
8940
6307db39
PE
89412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8942
8943 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8944
f3d4e0a4
CY
89452011-05-22 Chong Yidong <cyd@stupidchicken.com>
8946
8947 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8948
4d8ade89
YM
89492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8950
8951 * dispnew.c (scrolling_window): Don't exclude the case that the
8952 last enabled row in the desired matrix touches the bottom boundary.
8953
32078c8d
GM
89542011-05-21 Glenn Morris <rgm@gnu.org>
8955
8956 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8957 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8958 and add some more files.
32078c8d 8959
7285dc67
EZ
89602011-05-20 Eli Zaretskii <eliz@gnu.org>
8961
8962 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8963 report_file_error introduced by the change from 2011-05-07.
8964
89d1bd22
PE
89652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8966
8967 * systime.h (Time): Define only if emacs is defined.
8968 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8969 where the include path doesn't have X11/X.h by default. See
8970 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8971
cd394be1 89722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8973
8974 * composite.c (find_automatic_composition): Fix previous change.
8975
b9704ad9
GM
89762011-05-20 Glenn Morris <rgm@gnu.org>
8977
8978 * lisp.mk: New file, split from Makefile.in.
8979 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8980 (shortlisp): Remove.
8981 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8982
4a720484
GM
89832011-05-19 Glenn Morris <rgm@gnu.org>
8984
8985 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8986 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8987 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8988 (lisp): Set the order to that of loadup.el.
8989 (shortlisp): Make it a copy of $lisp.
8990 (SOME_MACHINE_LISP): Remove.
8991 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8992 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8993
a28d4396
KH
89942011-05-18 Kenichi Handa <handa@m17n.org>
8995
8996 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8997 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8998 (find_automatic_composition): Mostly rewrite for efficiency.
8999
a2b1fa8e
JB
90002011-05-18 Juanma Barranquero <lekktu@gmail.com>
9001
9002 * makefile.w32-in: Update dependencies.
9003
8e1f5610
CS
90042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9005
9006 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9007 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9008
7025ee00 90092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9010
cdfa6eab
PE
9011 Fix some integer overflow issues, such as string length overflow.
9012
06d6db33
PE
9013 * insdel.c (count_size_as_multibyte): Check for string overflow.
9014
2b4560a8
PE
9015 * character.c (lisp_string_width): Check for string overflow.
9016 Use EMACS_INT, not int, for string indexes and lengths; in
9017 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9018 the resulting string length overflows an EMACS_INT; instead,
9019 report a string overflow if no precision given. When checking for
9020 precision exhaustion, use a check that cannot possibly have
9021 integer overflow. (Bug#8675)
9022 * character.h (lisp_string_width): Adjust to new signature.
9023
cb93f9be
PE
9024 * alloc.c (string_overflow): New function.
9025 (Fmake_string): Use it. This doesn't change behavior, but saves
9026 a few bytes and will simplify future changes.
9027 * character.c (string_escape_byte8): Likewise.
9028 * lisp.h (string_overflow): New decl.
9029
1a1f3366
PE
9030 Fixups, following up to the user-interface timestamp change.
9031 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9032 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9033 * msdos.c (mouse_get_pos): Likewise.
9034 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9035 * w32gui.h (Time): Define by including "systime.h" rather than by
9036 declaring it ourselves. (Bug#8664)
9037
d4e3e4d3
PE
9038 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9039 * image.c (clear_image_cache): Likewise.
9040
f6a24d19
PE
9041 * term.c (term_mouse_position): Don't assume time_t wraparound.
9042
08dc5ae6
PE
9043 Be more systematic about user-interface timestamps.
9044 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9045 and sometimes 'EMACS_UINT', to represent these timestamps.
9046 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9047 This makes the code easier to follow, and makes it easier to catch
9048 integer overflow bugs such as Bug#8664.
9049 * frame.c (Fmouse_position, Fmouse_pixel_position):
9050 Use Time, not unsigned long, for user-interface timestamps.
9051 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9052 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9053 * keyboard.h (last_event_timestamp): Likewise.
9054 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9055 * menu.h (xmenu_show): Likewise.
9056 * term.c (term_mouse_position): Likewise.
9057 * termhooks.h (struct input_event.timestamp): Likewise.
9058 (struct terminal.mouse_position_hook): Likewise.
9059 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9060 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9061 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9062 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9063 what it was before.
9064 * menu.h, termhooks.h: Include "systime.h", for Time.
9065
8e55734a
PE
9066 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9067 Don't assume that the difference between two unsigned long values
9068 can fit into an integer. At this point, we know button_down_time
9069 <= event->timestamp, so the difference must be nonnegative, so
9070 there's no need to cast the result if double-click-time is
9071 nonnegative, as it should be; check that it's nonnegative, just in
9072 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9073 apart (about 25 days). (Bug#8664)
8e55734a 9074
841f1b75 9075 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9076 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9077
3e26f69c
PE
9078 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9079 that always fit in int. Use a sentinel instead of a counter, to
9080 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9081 * frame.h (struct frame): Use int for menu_bar_items_used
9082 instead of EMACS_INT, since it always fits in int.
3e26f69c 9083
5cc152c0
PE
9084 * menu.c (grow_menu_items): Check for int overflow.
9085
d89eb65e
PE
9086 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9087
5235bd3e
PE
9088 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9089 Before, the code was not consistent. These values cannot exceed
9090 2**31 - 1 so there's no need to make them unsigned.
9091 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9092 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9093 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9094 as modifiers.
9095 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9096
bc827e23
PE
9097 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9098 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9099 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9100 presumably because the widths might not match.
9101
78eb494e
PE
9102 * window.c (size_window): Avoid needless test at loop start.
9103
04f2d78b
CB
91042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9105
9106 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9107
d2fc7e3d 91082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9109
9110 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9111
d2fc7e3d 91122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9113
9114 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9115 `width' to `bar_area_x' and `bar_area_width', respectively.
9116 (x_scroll_run): Take account of fringe background extension.
9117
04f2d78b
CB
9118 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9119 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9120 `bar_area_width', respectively.
9121 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9122 background extension.
9123
79b70037
GM
91242011-05-10 Jim Meyering <meyering@redhat.com>
9125
9126 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9127
2f142cc5
JB
91282011-05-10 Juanma Barranquero <lekktu@gmail.com>
9129
9130 * image.c (Finit_image_library): Return t for built-in image types,
9131 like pbm and xbm. (Bug#8640)
9132
57679c86
AS
91332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9134
9135 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9136
888c9e86
EZ
91372011-05-07 Eli Zaretskii <eliz@gnu.org>
9138
b0512a1d
EZ
9139 * w32console.c (Fset_screen_color): Doc fix.
9140 (Fget_screen_color): New function.
9141 (syms_of_ntterm): Defsubr it.
9142
7285dc67
EZ
9143 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9144 unlink the temporary file if Fcall_process didn't create it in the
9145 first place.
9146 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9147 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9148 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9149 cue to call_process_cleanup not to close that handle.
9150
4d3fcc8e
BK
91512011-05-07 Ben Key <bkey76@gmail.com>
9152
9153 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9154 one of two shell specific rules, either bootstrap-temacs-CMD or
9155 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9156 to the previous implementation of the bootstrap-temacs rule.
9157 The bootstrap-temacs-CMD rule is similar to the previous
9158 implementation of the bootstrap-temacs rule except that it
9159 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9160 variable.
9161
9162 These changes, along with some changes to nt/configure.bat,
9163 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9164 earlier fix to add support for --cflags and --ldflags options
9165 that include quotes so that it works whether make uses cmd or
9166 sh as the shell.
9167
b4289b64
MA
91682011-05-06 Michael Albinus <michael.albinus@gmx.de>
9169
9170 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9171 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9172 is a constant.
9173 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9174 a string. Handle both cases.
9175 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9176 (Fdbus_register_method): Use Qinvalid_function.
9177
af4c0e28
JB
91782011-05-06 Juanma Barranquero <lekktu@gmail.com>
9179
9180 * makefile.w32-in: Update dependencies.
9181 (LISP_H): Add inttypes.h and stdin.h.
9182 (PROCESS_H): Add unistd.h.
9183
c51453d9
EZ
91842011-05-06 Eli Zaretskii <eliz@gnu.org>
9185
9186 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9187 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9188
8ff0ac3c 91892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9190
4c4b566b
PE
9191 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9192
aab2b9b5
PE
9193 * term.c (vfatal): Remove stray call to va_end.
9194 It's not needed and the C Standard doesn't allow it here anyway.
9195
c378da0b
PE
9196 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9197 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9198
288b08c7
PE
9199 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9200 bytes.
9201
e3601888
PE
9202 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9203
db6c0e74
PE
9204 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9205
dd5963ea
PE
9206 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9207
88c9450f
PE
9208 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9209
2f9442b8
PE
9210 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9211
c032b5f8
PE
9212 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9213 * charset.c (Fdefine_charset_internal): Don't initialize
9214 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9215 32-bit int (Bug#8600).
a108c10b
PE
9216
9217 * lread.c (read_integer): Be more consistent with string-to-number.
9218 Use string_to_number to do the actual conversion; this avoids
9219 rounding errors and fixes some other screwups. Without this fix,
9220 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9221 (digit_to_number): Move earlier, for benefit of read_integer.
9222 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9223 not a digit in any supported base. (Bug#8602)
a108c10b 9224
ad5f9eea
PE
9225 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9226
aec1708a
PE
9227 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9228 to match comment at start of function. This also removes a
9229 GCC warning about overflow in a 32+64-bit port.
9230
47be4ab5
PE
9231 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9232
371cac43
PE
9233 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9234 Reported by Stefan Monnier in
9235 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9236 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9237 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9238
d01a7826
PE
9239 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9240 (EMACS_UINTPTR): Likewise, with uintptr_t.
9241
7fd47d5c
PE
9242 * lisp.h: Prefer 64-bit EMACS_INT if available.
9243 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9244 on 32-bit hosts that have 64-bit int, so that they can access
9245 large files.
122b0c86
PE
9246 However, temporarily disable this change unless the temporary
9247 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9248
8727937b
PE
9249 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9250
8ac068ac
PE
9251 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9252 This removes an assumption that EMACS_INT and long are the same
9253 width as pointers. The assumption is true for Emacs porting targets
9254 now, but we want to make other targets possible.
9255 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9256 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9257 In the rest of the code, change types of integers that hold casted
9258 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9259 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9260 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9261 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9262 No need to cast type when ORing.
9263 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9264 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9265 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9266 assume EMACS_INT is the same width as char *.
9267 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9268 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9269 Remove no-longer-needed casts.
9270 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9271 (xg_tool_bar_help_callback, xg_make_tool_item):
9272 Use EMACS_INTPTR to hold an integer
9273 that will be cast to void *; this can avoid a GCC warning
9274 if EMACS_INT is not the same width as void *.
9275 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9276 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9277 (current_message_1, set_message_1):
9278 Use a local to convert to proper width without a cast.
9279 * xmenu.c (dialog_selection_callback): Likewise.
9280
ede49d71
PE
9281 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9282 Also, don't assume VALBITS / RAND_BITS is less than 5,
9283 and don't rely on undefined behavior when shifting a 1 left into
9284 the sign bit.
9285 * lisp.h (get_random): Change signature to match.
9286
2f30ecd0
PE
9287 * lread.c (hash_string): Use size_t, not int, for hash computation.
9288 Normally we prefer signed values; but hashing is special, because
9289 it's better to use unsigned division on hash table sizes so that
9290 the remainder is nonnegative. Also, size_t is the natural width
9291 for hashing into memory. The previous code used 'int', which doesn't
9292 retain enough info to hash well into very large tables.
9293 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9294
2a866e7b
PE
9295 * dbusbind.c: Don't possibly lose pointer info when converting.
9296 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9297 Use XPNTR rather than XHASH, so that the high-order bits of
9298 the pointer aren't lost when converting through void *.
9299
51639eac
PE
9300 * eval.c (Fautoload): Don't double-shift a pointer.
9301
92394119
PE
9302 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9303
dbdb9a7c
JB
93042011-05-06 Juanma Barranquero <lekktu@gmail.com>
9305
9306 * gnutls.c (DEF_GNUTLS_FN):
9307 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9308
db7a0b4f
AS
93092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9310
9311 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9312 marker. (Bug#8610)
9313
cd394be1 93142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9315
9316 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9317 New version that can reserve upto 2GB of heap space.
9318
f7ff1b0f 93192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9320
9321 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9322
639c109b
TZ
93232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9324
9325 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9326 `gnutls_certificate_set_x509_key_file'.
9327
d2127135
JB
93282011-05-05 Juanma Barranquero <lekktu@gmail.com>
9329
9330 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9331 Update dependencies.
9332
e968f4f3
JB
93332011-05-04 Juanma Barranquero <lekktu@gmail.com>
9334
9335 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9336 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9337 Remove unused parameter `fildes'.
9338 * process.c (read_process_output, send_process): Don't pass it.
9339
84d358f0
JB
93402011-05-04 Juanma Barranquero <lekktu@gmail.com>
9341
9342 Fix previous change: the library cache is defined in w32.c.
9343 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9344 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9345
0898ca10
JB
93462011-05-04 Juanma Barranquero <lekktu@gmail.com>
9347
9348 Implement dynamic loading of GnuTLS on Windows.
9349
9350 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9351 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9352 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9353 Declare.
9354
9355 * gnutls.c (Qgnutls_dll): Define.
9356 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9357 (gnutls_*): Declare function pointers.
9358 (init_gnutls_functions): New function to initialize function pointers.
9359 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9360 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9361 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9362 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9363 (emacs_gnutls_write, emacs_gnutls_read)
9364 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9365 (Fgnutls_available_p): New function.
9366 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9367 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9368 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9369
9370 * image.c: Include w32.h.
9371 (Vimage_type_cache): Delete.
9372 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9373 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9374 (w32_delayed_load): Move to w32.c.
9375
9376 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9377
9378 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9379 (w32_delayed_load): Move from image.c. When loading a library, record
9380 its filename in the :loaded-from property of the library id.
9381 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9382 Initialize and staticpro them.
9383 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9384
9385 * process.c: Include lisp.h before w32.h, not after.
9386 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9387 instead of gnutls_record_check_pending.
9388
9389 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9390
ff4de4aa
TZ
93912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9392
9393 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9394 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9395 as passed in.
9396
abe95abb
JD
93972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9398
9399 * xterm.c (x_set_frame_alpha): Do not set property on anything
9400 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9401
e16e55d4
JB
94022011-05-02 Juanma Barranquero <lekktu@gmail.com>
9403
9404 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9405
bafcf6a5
JB
94062011-05-02 Juanma Barranquero <lekktu@gmail.com>
9407
9408 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9409 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9410 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9411 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9412 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9413 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9414 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9415 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9416 (Qgnutls_bootprop_callbacks_verify): Make static.
9417
e7a6747f
AS
94182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9419
19ed11ba
AS
9420 * callproc.c: Indentation fixup.
9421
e7a6747f 9422 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9423 (wait_for_termination, interruptible_wait_for_termination):
9424 Move after wait_for_termination_1.
e7a6747f 9425
1ef14cb4
LMI
94262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9427
9428 * sysdep.c (interruptible_wait_for_termination): New function
9429 which is like wait_for_termination, but allows keyboard
9430 interruptions.
9431
9432 * callproc.c (Fcall_process): Add (:file "file") as an option for
9433 the STDOUT buffer.
9434 (Fcall_process_region): Ditto.
9435
330d880c
EZ
94362011-04-30 Eli Zaretskii <eliz@gnu.org>
9437
8db90b73
EZ
9438 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9439 rather than `XVECTOR (FOO)->size'.
9440
330d880c
EZ
9441 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9442 inttypes.h, as a gnulib replacement is used if it not available in
9443 system headers.
9444
15cbd324
EZ
94452011-04-21 Eli Zaretskii <eliz@gnu.org>
9446
9447 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9448 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9449 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9450
9451 * coding.c (coding_alloc_by_realloc): Error out if destination
9452 will grow beyond MOST_POSITIVE_FIXNUM.
9453 (decode_coding_emacs_mule): Abort if there isn't enough place in
9454 charbuf for the composition carryover bytes. Reserve an extra
9455 space for up to 2 characters produced in a loop.
9456 (decode_coding_iso_2022): Abort if there isn't enough place in
9457 charbuf for the composition carryover bytes.
9458
94592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9460
ae940cca
EZ
9461 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9462 aborting when %lld or %lll format is passed.
9463 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9464 %llo or %llx format is passed. (Bug#8545)
9465
03ab8921
EZ
9466 * window.c (window_scroll_line_based): Use a marker instead of
9467 simple variables to record original value of point. (Bug#7952)
9468
afda1437
EZ
9469 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9470 produced by %s or %c overflows available buffer space. (Bug#8545)
9471
f76dee0c
PE
94722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9473
9474 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9475 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9476
fdc5744d
JB
94772011-04-28 Juanma Barranquero <lekktu@gmail.com>
9478
9479 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9480
638f053a
JB
94812011-04-28 Juanma Barranquero <lekktu@gmail.com>
9482
9483 * keyboard.c (Qdelayed_warnings_hook): Define.
9484 (command_loop_1): Run `delayed-warnings-hook'
9485 if Vdelayed_warnings_list is non-nil.
9486 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9487 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9488
d178f871
EZ
94892011-04-28 Eli Zaretskii <eliz@gnu.org>
9490
9491 * doprnt.c (doprnt): Don't return value smaller than the buffer
9492 size if the message was truncated. (Bug#8545).
9493
b124fd93
JB
94942011-04-28 Juanma Barranquero <lekktu@gmail.com>
9495
9496 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9497 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9498
e810457d
PE
94992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9500
9501 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9502
ea51cceb
JB
95032011-04-27 Juanma Barranquero <lekktu@gmail.com>
9504
9505 * makefile.w32-in: Update dependencies.
9506
94dcfacf
EZ
95072011-04-27 Eli Zaretskii <eliz@gnu.org>
9508
9509 Improve `doprnt' and its usage. (Bug#8545)
9510 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9511 `format_end'. Remove support for %l as a conversion specifier.
9512 Don't use xrealloc. Improve diagnostics when the %l size modifier
9513 is used. Update the commentary.
9514
9515 * eval.c (verror): Simplify calculation of size_t.
9516
9517 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9518 messages.
9519
f61f41d7
PE
95202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9521
9522 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9523 change.
9524
96fb4434
PE
95252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9526
9527 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9528 This makes this file independent of the recent pseudovector change.
9529
671875da 95302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9531
69e9b5a3
PE
9532 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9533
b5f869a7 9534 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9535 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9536 Remove unused local.
c8926152 9537 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9538
841a1577 9539 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9540 GCC 4.6.0 optimizes based on type-based alias analysis.
9541 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9542 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9543 != &v->size, and therefore "v->size = 1; b->size = 2; return
9544 v->size;" must therefore return 1. This assumption is incorrect
9545 for Emacs, since it type-puns struct Lisp_Vector * with many other
9546 types. To fix this problem, this patch adds a new type struct
f904488f 9547 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9548 and pseudovectors, and helps optimizing compilers not get fooled
9549 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9550 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9551 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9552 the size member.
eab3844f
PE
9553 (XSETPVECTYPE): Rewrite in terms of new macro.
9554 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9555 This is a bit clearer, and further avoids the possibility of
9556 undesirable aliasing.
9557 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9558 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9559 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9560 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9561 (ASIZE): Now uses header.size rather than size.
9562 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9563 to avoid the hassle of writing XVECTOR (foo)->header.size.
9564 (struct vectorlike_header): New type.
eab3844f
PE
9565 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9566 object, to help avoid aliasing.
9567 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9568 (SUBRP): Likewise, since Lisp_Subr is a special case.
9569 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9570 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9571 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9572 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9573 changed to be "header.size" and "header.next".
9574 * buffer.h (struct buffer): Likewise.
9575 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9576 * frame.h (struct frame): Likewise.
9577 * process.h (struct Lisp_Process): Likewise.
9578 * termhooks.h (struct terminal): Likewise.
9579 * window.c (struct save_window_data, struct saved_window): Likewise.
9580 * window.h (struct window): Likewise.
9581 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9582 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9583 * buffer.c (init_buffer_once): Likewise.
9584 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9585 special case.
9586 * process.c (Fformat_network_address): Use local var for size,
9587 for brevity.
9588
0df1eac5
PE
9589 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9590
847ab9d1 9591 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9592 * data.c (atof): Remove decl; no longer used or needed.
9593 (digit_to_number): Move to lread.c.
9594 (Fstring_to_number): Use new string_to_number function, to be
9595 consistent with how the Lisp reader treats infinities and NaNs.
9596 Do not assume that floating-point numbers represent EMACS_INT
9597 without losing information; this is not true on most 64-bit hosts.
9598 Avoid double-rounding errors, by insisting on integers when
9599 parsing non-base-10 numbers, as the documentation specifies.
9600 * lisp.h (string_to_number): New decl, replacing ...
9601 (isfloat_string): Remove.
bc0a5c13 9602 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9603 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9604 appears to have been a coding error. Similarly, do not accept
9605 strings like +-1e0 as floating point numbers. Do not report
9606 overflow for integer overflows unless the base is not 10 which
9607 means we have no simple and reliable way to continue.
9608 Break out the floating-point parsing into a new
9609 function string_to_number, so that Fstring_to_number parses
9610 floating point numbers consistently with the Lisp reader.
04f2d78b 9611 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9612 (E_CHAR, EXP_INT): Remove, replacing with ...
9613 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9614 (string_to_number): New function, replacing isfloat_string.
9615 This function checks for valid syntax and produces the resulting
9616 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9617 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9618 so that overflow for non-base-10 numbers is reported only when
9619 there's no portable and simple way to convert to floating point.
452f4150 9620
67769ffc
PE
9621 * textprop.c (set_text_properties_1): Rewrite for clarity,
9622 and to avoid GCC warning about integer overflow.
9623
c20db43f
PE
9624 * intervals.h (struct interval): Use EMACS_INT for members
9625 where EMACS_UINT might cause problems. See
9626 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9627 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9628 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9629 All uses changed.
37aa2f85
PE
9630 (offset_intervals): Tell GCC not to worry about length overflow
9631 when negating a negative length.
c20db43f 9632
2538aa2f
PE
9633 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9634 (overrun_check_free): Likewise.
9635
f2d3008d
PE
9636 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9637 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9638 word size.
9639
ec8df744
PE
9640 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9641 (gnutls_make_error): Rename local to avoid shadowing.
9642 (gnutls_emacs_global_deinit): ifdef out; not used.
9643 (Fgnutls_boot): Use const for pointer to readonly storage.
9644 Comment out unused local. Fix pointer signedness problems.
9645
640ee02d
PE
9646 * lread.c (openp): Don't stuff size_t into an 'int'.
9647 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9648 about possible signed overflow.
9649
6048fb2a
PE
9650 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9651 (GDK_KEY_g): Don't define if already defined.
9652 (xg_prepare_tooltip): Avoid pointer signedness problem.
9653 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9654
fa3c87e1
PE
9655 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9656 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9657
2172544b
PE
9658 * xfns.c (Fx_window_property): Simplify a bit,
9659 to make a bit faster and to avoid GCC 4.6.0 warning.
9660 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9661
9b821a21
PE
9662 * fns.c (internal_equal): Don't assume size_t fits in int.
9663
3c616cfa
PE
9664 * alloc.c (compact_small_strings): Tighten assertion a little.
9665
c2982e87
PE
9666 Replace pEd with more-general pI, and fix some printf arg casts.
9667 * lisp.h (pI): New macro, generalizing old pEd macro to other
9668 conversion specifiers. For example, use "...%"pI"d..." rather
9669 than "...%"pEd"...".
9670 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9671 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9672 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9673 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9674 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9675 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9676 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9677 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9678 64-bit hosts.
9679 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9680 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9681 * print.c (safe_debug_print, print_object): Likewise.
9682 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9683 to int.
6f04d126
PE
9684 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9685 avoiding the 0 flag, which is not portable.
c2982e87
PE
9686 * process.c (Fmake_network_process): Use pI to avoid cast.
9687 * region-cache.c (pp_cache): Likewise.
9688 * xdisp.c (decode_mode_spec): Likewise.
9689 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9690 behavior on 64-bit hosts with printf arg.
6f04d126 9691 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9692 (x_stop_queuing_selection_requests): Likewise.
9693 (x_get_window_property): Don't truncate byte count to an 'int'
9694 when tracing.
0b432f21 9695
5e073ec7
PE
9696 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9697 here, since it parses constructs like leading '-' and spaces,
9698 which are not wanted; and it overflows with large numbers.
9699 Instead, simply match F[0-9]+, which is what is wanted anyway.
9700
36372bf9
PE
9701 * alloc.c: Remove unportable assumptions about struct layout.
9702 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9703 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9704 (allocate_vectorlike, make_pure_vector): Use the new macros,
9705 plus offsetof, to remove unportable assumptions about struct layout.
9706 These assumptions hold on all porting targets that I know of, but
9707 they are not guaranteed, they're easy to remove, and removing them
9708 makes further changes easier.
9709
0b432f21
PE
9710 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9711 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9712 (string_overrun_cookie): Now const. Use initializers that
9713 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9714 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9715 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9716 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9717 multiple of sizeof (EMACS_INT); it need not be, if
9718 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9719 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9720
895009e1
JB
97212011-04-26 Juanma Barranquero <lekktu@gmail.com>
9722
9723 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9724
6a7a1b0b
TZ
97252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9726
9727 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9728 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9729 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9730
841a1577 97312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9732
9733 * lisp.h (Qdebug): List symbol.
895009e1 9734 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9735 * keyboard.c (debug-on-event): New variable.
9736 (handle_user_signal): Break into debugger when debug-on-event
9737 matches the current signal symbol.
9738
f2d3ba6f
DN
97392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9740
9741 * alloc.c (check_sblock, check_string_bytes)
9742 (check_string_free_list): Convert to standard C.
9743
42ce4c63
TZ
97442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9745
9746 * w32.c (emacs_gnutls_push): Fix typo.
9747
825cd63c
EZ
97482011-04-25 Eli Zaretskii <eliz@gnu.org>
9749
fb11d64d
EZ
9750 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9751 "cast to pointer from integer of different size".
9752
825cd63c
EZ
9753 Improve doprnt and its use in verror. (Bug#8545)
9754 * doprnt.c (doprnt): Document the set of format control sequences
9755 supported by the function. Use SAFE_ALLOCA instead of always
9756 using `alloca'.
9757
9758 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9759 is one byte too soon. Don't use xrealloc; instead xfree and
9760 xmalloc anew.
9761
e061a11b
TZ
97622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9763
9764 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9765 callbacks stage.
9766
9767 * gnutls.c: Renamed global_initialized to
9768 gnutls_global_initialized. Added internals for the
9769 :verify-hostname-error, :verify-error, and :verify-flags
9770 parameters of `gnutls-boot' and documented those parameters in the
9771 docstring. Start callback support.
9173deec
JB
9772 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9773 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9774 on error. Return error code.
e061a11b
TZ
9775 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9776 (emacs_gnutls_read): Likewise.
9777 (Fgnutls_boot): Return handshake error code.
9778 (emacs_gnutls_handle_error): New function.
9779 (wsaerror_to_errno): Likewise.
9780
9781 * w32.h (emacs_gnutls_pull): Add prototype.
9782 (emacs_gnutls_push): Likewise.
9783
9784 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9785 (emacs_gnutls_push): Likewise.
9786
97872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9788
9789 * process.c (wait_reading_process_output): Check if GnuTLS
9790 buffered some data internally if no FDs are set for TLS
9791 connections.
9792
9793 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9794 (LIBS): Link to USER_LIBS.
9795 ($(BLD)/gnutls.$(0)): New target.
9796
fa6996bc
EZ
97972011-04-24 Eli Zaretskii <eliz@gnu.org>
9798
eb35682e
EZ
9799 * xdisp.c (handle_single_display_spec): Rename the
9800 display_replaced_before_p argument into display_replaced_p, to
9801 make it consistent with the commentary. Fix typos in the
9802 commentary.
9803
e2ad650c
EZ
9804 * textprop.c (syms_of_textprop): Remove dead code.
9805 (copy_text_properties): Delete obsolete commentary about an
9806 interface that was deleted long ago. Fix typos in the description
9807 of arguments.
9808
1b2de274
EZ
9809 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9810 to changes in oldXMenu/XMenu.h from 2011-04-16.
9811 <menu_help_message, prev_menu_help_message>: Constify.
9812 (IT_menu_make_room): menu->help_text is now `const char **';
9813 adjust.
9814
9815 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9816 to changes in oldXMenu/XMenu.h from 2011-04-16.
9817 (struct XMenu): Declare `help_text' `const char **'.
9818
9819 * xfaces.c <Qunspecified>: Make extern again.
9820
9821 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9822 required by POSIX.
1b2de274 9823
762b15be
EZ
9824 * doc.c (get_doc_string): Improve the format passed to `error'.
9825
9826 * doprnt.c (doprnt): Improve commentary.
9827
9828 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9829
9830 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9831 them with etags.
9832
f1052e5d
EZ
9833 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9834 changes in globals.h immediately force recompilation.
762b15be
EZ
9835 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9836 $(CURDIR)/s/ms-w32.h.
9837 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9838
fa6996bc
EZ
9839 * character.c (Fchar_direction): Function deleted.
9840 (syms_of_character): Don't defsubr it.
9841 <char-direction-table>: Deleted.
9842
e6c3da20
EZ
98432011-04-23 Eli Zaretskii <eliz@gnu.org>
9844
9845 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9846 * doprnt.c: Include limits.h.
9847 (SIZE_MAX): New macro.
04f2d78b
CB
9848 (doprnt): Return a size_t value. 2nd arg is now size_t.
9849 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9850 Improve overflow protection. Support `l' modifier for integer
9851 conversions. Support %l conversion. Don't assume an EMACS_INT
9852 argument for integer conversions and for %c.
9853
9854 * lisp.h (doprnt): Restore prototype.
9855
9856 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9857 $(SRC)/character.h.
9858
9859 * Makefile.in (base_obj): Add back doprnt.o.
9860
9861 * deps.mk (doprnt.o): Add back prerequisites.
9862 (callint.o): Depend on character.h.
9863
9864 * eval.c (internal_lisp_condition_case): Include the handler
9865 representation in the error message.
9866 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9867 when breaking from the loop.
9868
9869 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9870
9871 * callint.c (Fcall_interactively): When displaying error message
9872 about invalid control letter, pass the character's codepoint, not
9873 a pointer to its multibyte form. Improve display of the character
9874 in octal and display also its hex code.
9875
9876 * character.c (char_string): Use %x to display the (unsigned)
9877 codepoint of an invalid character, to avoid displaying a bogus
9878 negative value.
9879
9880 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9881 `error', not SYMBOL_NAME itself.
9882
9883 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9884 character arguments to `error'.
9885
9886 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9887 to `error' in error message about FINAL_CHAR argument. Make sure
9888 FINAL_CHAR is a character, and use %c when it is passed as
9889 argument to `error'.
9890
4ffd0d6b 98912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9892
9893 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9894
9895 * w32.c: Include <time.h>.
9896 (sys_localtime): New function.
9897
4ffd0d6b 98982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9899
9900 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9901
4ffd0d6b 9902 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9903
4ffd0d6b 99042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9905
4ffd0d6b
GM
9906 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9907 zombies (Bug#8467).
aac0c6e3 9908
04c56954
EZ
99092011-04-19 Eli Zaretskii <eliz@gnu.org>
9910
9911 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9912 gl_state.e_property when gl_state.object is Qt.
9913
9914 * insdel.c (make_gap_larger): Remove limitation of buffer size
9915 to <= INT_MAX.
9916
16a43933
CY
99172011-04-18 Chong Yidong <cyd@stupidchicken.com>
9918
9919 * xdisp.c (lookup_glyphless_char_display)
9920 (produce_glyphless_glyph): Handle cons cell entry in
9921 glyphless-char-display.
9922 (Vglyphless_char_display): Document it.
9923
9924 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9925 glyphless-char-display.
9926
4581706e
CY
99272011-04-17 Chong Yidong <cyd@stupidchicken.com>
9928
9929 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9930
9931 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9932
9933 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9934 definition for no-X builds.
9935
4887c6e2 99362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9937
fd35b6f9
PE
9938 Static checks with GCC 4.6.0 and non-default toolkits.
9939
5c1ccb01
PE
9940 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9941
006c5daa
PE
9942 * process.c (keyboard_bit_set): Define only if SIGIO.
9943 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9944 (send_process): Repair possible setjmp clobbering.
9945
efc736d3
PE
9946 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9947
4e2fe2e6
PE
9948 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9949
f97334a2
PE
9950 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9951
4e75f29d
PE
9952 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9953 Define only if needed.
9954
90efadd1
PE
9955 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9956 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9957 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9958
3c647824
PE
9959 * dispextern.h (struct redisplay_interface): Rename param
9960 to avoid shadowing.
e264f262 9961 * termhooks.h (struct terminal): Likewise.
761383f4 9962 * xterm.c (xembed_send_message): Likewise.
3c647824 9963
b58c5c4a
PE
9964 * insdel.c (make_gap_smaller): Define only if
9965 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9966
cad59032
PE
9967 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9968 it.
9969
c339dc2e
PE
9970 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9971 so that we aren't warned about unused symbols.
9972
91a3e27b
PE
9973 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9974
399c71d3 9975 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9976
8ffc96f5
PE
9977 * xfns.c (x_real_positions): Mark locals as initialized.
9978
eef9bc79
PE
9979 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9980
098db9dd
PE
9981 * xterm.c: Fix problems found by static analysis with other toolkits.
9982 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9983 (x_dispatch_event): Declare static if USE_GTK, and
9984 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9985 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9986 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9987 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9988 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9989
eb18f6cc
PE
9990 * xmenu.c (menu_help_callback): Pointer type fixes.
9991 Use const pointers when pointing at readonly data. Avoid pointer
9992 signedness clashes.
9993 (FALSE): Remove unused macro.
9994 (update_frame_menubar): Remove unused decl.
9995
1fe72bf8
PE
9996 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9997
60d9e1db
PE
9998 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9999 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10000 (single_menu_item): Rename local to avoid shadowing.
10001
39261c26
PE
10002 * keyboard.c (make_lispy_event): Remove unused local var.
10003
018c5e19
PE
10004 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10005 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10006
63d2b86e
PE
10007 * bitmaps: Change bitmaps from unsigned char back to the X11
10008 compatible char. Avoid the old compiler warnings about
10009 out-of-range initializers by using, for example, '\xab' rather
10010 than 0xab.
10011
aefd87e1
PE
10012 * xgselect.c (xgselect_initialize): Check vs interface
10013 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10014
bf501fb9
PE
10015 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10016
e9829fdf
PE
10017 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10018 to read-only memory.
10019
1086c095
PE
10020 * fns.c (vector): Remove; this old hack is no longer needed.
10021
2baccd04 10022 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10023 Remove unused var.
dde42981 10024 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10025
72391843 10026 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10027
436c16df 10028 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10029 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10030 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10031
92bb796d 10032 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10033 (x_term_init): Remove local to avoid shadowing.
92bb796d 10034
764430a3 10035 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10036
10037 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10038 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10039
d1dfb56c
EZ
100402011-04-16 Eli Zaretskii <eliz@gnu.org>
10041
c4354cb4
EZ
10042 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10043
d1dfb56c
EZ
10044 Fix regex.c, syntax.c and friends for buffers > 2GB.
10045 * syntax.h (struct gl_state_s): Declare character position members
10046 EMACS_INT.
10047
10048 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10049
04f2d78b
CB
10050 * textprop.c (verify_interval_modification, interval_of):
10051 Declare arguments EMACS_INT.
d1dfb56c
EZ
10052
10053 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10054 EMACS_INT.
10055
10056 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10057
10058 * indent.c (Fvertical_motion): Local variable it_start is now
10059 EMACS_INT.
10060
10061 * regex.c (re_match, re_match_2, re_match_2_internal)
10062 (bcmp_translate, regcomp, regexec, print_double_string)
10063 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10064 (re_compile_pattern, re_exec): Declare arguments and local
10065 variables `size_t' and `ssize_t' and return values `regoff_t', as
10066 appropriate.
10067 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10068 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10069 <compile_stack_type>: `size' and `avail' are now `size_t'.
10070
10071 * regex.h <regoff_t>: Use ssize_t, not int.
10072 (re_search, re_search_2, re_match, re_match_2): Arguments that
10073 specify buffer/string position and length are now ssize_t and
10074 size_t. Return type is regoff_t.
10075
613052cd
BK
100762011-04-16 Ben Key <bkey76@gmail.com>
10077
10078 * nsfont.m: Fixed bugs in ns_get_family and
10079 ns_descriptor_to_entity that were caused by using free to
10080 deallocate memory blocks that were allocated by xmalloc (via
10081 xstrdup). This caused Emacs to crash when compiled with
10082 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10083 --enable-checking=xmallocoverrun). xfree is now used to
10084 deallocate these memory blocks.
10085
4170f62f 100862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10087
71b41406
PE
10088 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10089
9587a89d
PE
10090 emacs_write: Accept and return EMACS_INT for sizes.
10091 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10092 et seq.
10093 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10094 Accept and return EMACS_INT.
10095 (emacs_gnutls_write): Return the number of bytes written on
10096 partial writes.
10097 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10098 (emacs_read, emacs_write): Remove check for negative size, as the
10099 Emacs source code has been audited now.
9587a89d
PE
10100 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10101 (emacs_read, emacs_write): Use it.
273a5f82
PE
10102 * process.c (send_process): Adjust to the new signatures of
10103 emacs_write and emacs_gnutls_write. Do not attempt to store
10104 a byte offset into an 'int'; it might overflow.
9587a89d 10105 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10106
3e047f51
PE
10107 * sound.c: Don't assume sizes fit in 'int'.
10108 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10109 Return EMACS_INT, not int.
3e047f51 10110 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10111 Accept EMACS_INT, not int.
10112 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10113 record read return values.
10114
cc39a9db
BK
101152011-04-15 Ben Key <bkey76@gmail.com>
10116
c9d0ec6d
JB
10117 * keyboard.c (Qundefined): Don't declare static since it is used
10118 in nsfns.m.
10119 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10120 static since they are used in nsfont.m.
cc39a9db 10121
6c60eb9f
SM
101222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10123
10124 * process.c (Qprocessp): Don't declare static.
10125 * lisp.h (Qprocessp): Declare again.
10126
7990b61a
JB
101272011-04-15 Juanma Barranquero <lekktu@gmail.com>
10128
10129 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10130
5d4cb038
PE
101312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10132
8bd7b830 10133 Improve C-level modularity by making more things 'static'.
cd64ea1d 10134
e3b27b31
PE
10135 Don't publish debugger-only interfaces to other modules.
10136 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10137 (verify_bytepos, count_markers): Move decls to the only modules
10138 that need them.
10139 * region-cache.h (pp_cache): Likewise.
10140 * window.h (check_all_windows): Likewise.
10141 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10142
5d4cb038
PE
10143 * sysdep.c (croak): Now static, if
10144 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10145 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10146
10147 * alloc.c (refill_memory_reserve): Now static if
10148 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10149 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10150
e87b6180
PE
10151 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10152 Define only if USE_LUCID.
10153
ac64929e
PE
10154 * xrdb.c (x_customization_string, x_rm_string): Now static.
10155
6f37259d
PE
10156 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10157 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10158
1683e3ab
PE
10159 * xdisp.c (draw_row_with_mouse_face): Now static.
10160 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10161
de9c2632
PE
10162 * window.h (check_all_windows): Mark externally visible.
10163
2b96acb7
PE
10164 * window.c (window_deletion_count): Now static.
10165
10166 * undo.c: Make symbols static if they're not exported.
10167 (last_undo_buffer, last_boundary_position, pending_boundary):
10168 Now static.
10169
50436f33
PE
10170 * textprop.c (interval_insert_behind_hooks): Now static.
10171 (interval_insert_in_front_hooks): Likewise.
10172
64520e5c
PE
10173 * term.c: Make symbols static if they're not exported.
10174 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10175 (max_frame_lines, tty_set_terminal_modes):
10176 (tty_reset_terminal_modes, tty_turn_off_highlight):
10177 (get_tty_terminal): Now static.
10178 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10179 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10180 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10181 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10182 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10183
1fa53021
PE
10184 * sysdep.c: Make symbols static if they're not exported.
10185 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10186 Now static.
10187 (sigprocmask_set, full_mask): Remove; unused.
10188 (wait_debugging): Mark as visible.
10189 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10190 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10191
d4b43b22
PE
10192 * syntax.c (syntax_temp): Define only if !__GNUC__.
10193
b7c513d0
PE
10194 * sound.c (current_sound_device, current_sound): Now static.
10195
989b29ad
PE
10196 * search.c (searchbufs, searchbuf_head): Now static.
10197
13a55a78
PE
10198 * scroll.c (scroll_cost): Remove; unused.
10199 * dispextern.h (scroll_cost): Remove decl.
10200
de68a1fc
PE
10201 * region-cache.h (pp_cache): Mark as externally visible.
10202
40ccffa6
PE
10203 * process.c: Make symbols static if they're not exported.
10204 (process_tick, update_tick, create_process, chan_process):
10205 (Vprocess_alist, proc_buffered_char, datagram_access):
10206 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10207 (deactivate_process): Mark defn as static, as well as decl.
10208 * lisp.h (create_process): Remove decl.
10209 * process.h (chan_process, Vprocess_alist): Remove decls.
10210
ad64fc97
PE
10211 * print.c: Make symbols static if they're not exported.
10212 (print_depth, new_backquote_output, being_printed, print_buffer):
10213 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10214 (print_interval, print_number_index, initial_stderr_stream):
10215 Now static.
10216 * lisp.h (Fprinc): Remove decl.
10217 (debug_output_compilation_hack): Mark as externally visible.
10218
adddb265
PE
10219 * sysdep.c (croak): Move decl from here to syssignal.h.
10220 * syssignal.h (croak): Put it here, so the API can be checked when
10221 'croak' is called from dissociate_if_controlling_tty.
10222
1717ede2
PE
10223 * minibuf.c: Make symbols static if they're not exported.
10224 (minibuf_save_list, choose_minibuf_frame): Now static.
10225 * lisp.h (choose_minibuf_frame): Remove decl.
10226
fa5fb2bc
PE
10227 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10228
1e3890d1
PE
10229 * lread.c: Make symbols static if they're not exported.
10230 (read_objects, initial_obarray, oblookup_last_bucket_number):
10231 Now static.
10232 (make_symbol): Remove; unused.
10233 * lisp.h (initial_obarray, make_symbol): Remove decls.
10234
8a1414fa
PE
10235 * keyboard.c: Make symbols static if they're not exported.
10236 (single_kboard, recent_keys_index, total_keys, recent_keys):
10237 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10238 (this_single_command_key_start, echoing, last_auto_save):
10239 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10240 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10241 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10242 (Vlispy_mouse_stem, double_click_count):
10243 Now static.
10244 (force_auto_save_soon): Define only if SIGDANGER.
10245 (ignore_mouse_drag_p): Now static if
10246 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10247 (print_help): Remove; unused.
10248 (stop_character, last_timer_event): Mark as externally visible.
10249 * keyboard.h (ignore_mouse_drag_p): Declare only if
10250 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10251 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10252 * lisp.h (echoing): Remove decl.
10253 (force_auto_save_soon): Declare only if SIGDANGER.
10254 * xdisp.c (redisplay_window): Simplify code, to make it more
10255 obvious that ignore_mouse_drag_p is not accessed if !defined
10256 USE_GTK && !defined HAVE_NS.
10257
93ea6e8f
PE
10258 * intervals.c: Make symbols static if they're not exported.
10259 (merge_properties_sticky, merge_interval_right, delete_interval):
10260 Now static.
10261 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10262
77382fcc
PE
10263 * insdel.c: Make symbols static if they're not exported.
10264 However, leave prepare_to_modify_buffer alone. It's never
10265 called from outside this function, but that appears to be a bug.
10266 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10267 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10268 (adjust_after_replace_noundo): Remove; unused.
10269 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10270 (signal_before_change): Remove decls.
77382fcc 10271
9306c32e
PE
10272 * indent.c (val_compute_motion, val_vmotion): Now static.
10273
cd44d2eb
PE
10274 * image.c: Make symbols static if they're not exported.
10275 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10276 if USE_GTK.
10277 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10278 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10279
ad9a7a06
PE
10280 * fringe.c (standard_bitmaps): Now static.
10281 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10282
81626931
PE
10283 * frame.c: Make symbols static if they're not exported.
10284 (x_report_frame_params, make_terminal_frame): Now static.
10285 (get_frame_param): Now static, unless HAVE_NS.
10286 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10287 (x_get_resource_string): Remove; not used.
10288 * frame.h (make_terminal_frame, x_report_frame_params):
10289 (x_get_resource_string); Remove decls.
10290 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10291 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10292
239f9db9
PE
10293 * font.c, fontset.c: Make symbols static if they're not exported.
10294 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10295 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10296 * font.c (font_close_object): Now static.
10297 * font.h (font_close_object): Remove.
10298 * fontset.c (FONTSET_OBJLIST): Remove.
10299 (free_realized_fontset) #if-0 the body, which does nothing.
10300 (face_suitable_for_char_p): #if-0, as it's never called.
10301 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10302 * xfaces.c (face_at_string_position):
10303 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10304 since 0 is always ASCII.
10305
dfcf3579
PE
10306 * fns.c (weak_hash_tables): Now static.
10307
5045092b
PE
10308 * fileio.c: Make symbols static if they're not exported.
10309 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10310 (Vwrite_region_annotation_buffers): Now static.
10311
57a96f5c
PE
10312 * eval.c: Make symbols static if they're not exported.
10313 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10314 * lisp.h (backtrace_list): Remove decl.
10315
35f08c38
PE
10316 * emacs.c: Make symbols static if they're not exported.
10317 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10318 (fatal_error_code, fatal_error_signal_hook, standard_args):
10319 Now static.
10320 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10321 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10322 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10323 * lisp.h (fatal_error_signal_hook): Remove decl.
10324 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10325
f44bd759
PE
10326 * editfns.c: Move a (normally-unused) function to its only use.
10327 * editfns.c, lisp.h (get_operating_system_release): Remove.
10328 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10329 worth the hassle of breaking this out.
10330
b532497d
PE
10331 * xterm.c: Make symbols static if they're not exported.
10332 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10333 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10334 (x_destroy_window, x_delete_display):
10335 Now static.
10336 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10337 (x_mouse_leave): Remove; unused.
10338 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10339 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10340 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10341 Remove decls.
10342 (x_mouse_leave): Declare only if WINDOWSNT.
10343 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10344 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10345 USE_X_TOOLKIT.
10346
1675728f
PE
10347 * ftxfont.c: Make symbols static if they're not exported.
10348 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10349 HAVE_FREETYPE.
10350 * font.h (ftxfont_driver): Likewise.
10351
e4cebfca
PE
10352 * xfns.c: Make symbols static if they're not exported.
10353 (x_last_font_name, x_display_info_for_name):
10354 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10355 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10356 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10357 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10358 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10359 (last_show_tip_args): Now static.
10360 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10361 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10362 (x_screen_planes): Remove; unused.
10363 * dispextern.h (x_screen_planes): Remove decl.
10364
5bf46f05
PE
10365 * dispnew.c: Make symbols static if they're not exported.
10366 * dispextern.h (redraw_garbaged_frames, scrolling):
10367 (increment_row_positions): Remove.
10368 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10369 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10370 Now static.
10371 (redraw_garbaged_frames): Remove; unused.
10372
435f4c28
PE
10373 * xfaces.c: Make symbols static if they're not exported.
10374 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10375 Remove decls.
10376 * xterm.h (defined_color): Remove decls.
10377 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10378 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10379 (menu_face_changed_default, defined_color, free_realized_face):
10380 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10381 (ascii_face_of_lisp_face): Remove; unused.
10382
8524aef3
PE
10383 * xdisp.c: Make symbols static if they're not exported.
10384 * dispextern.h (scratch_glyph_row, window_box_edges):
10385 (glyph_to_pixel_coords, set_cursor_from_row):
10386 (get_next_display_element, set_iterator_to_next):
10387 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10388 (show_mouse_face): Remove decls
10389 * frame.h (message_buf_print): Likewise.
10390 * lisp.h (pop_message, set_message, check_point_in_composition):
10391 Likewise.
10392 * xterm.h (set_vertical_scroll_bar): Likewise.
10393 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10394 (message_buf_print, scratch_glyph_row, displayed_buffer):
10395 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10396 (get_next_display_element, show_mouse_face, window_box_edges):
10397 (frame_to_window_pixel_xy, check_point_in_composition):
10398 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10399 (glyph_to_pixel_coords): Remove; unused.
10400
16390cd2
PE
10401 * dired.c (file_name_completion): Now static.
10402
10403 * dbusbind.c (xd_in_read_queued_messages): Now static.
10404
a25f4dfa
PE
10405 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10406 * data.c (circular_list_error): Remove.
10407
14a9c8df
PE
10408 * commands.h (last_point_position, last_point_position_buffer):
10409 (last_point_position_window): Remove decls.
10410 * keyboard.c: Make these variables static.
10411
04f2d78b
CB
10412 * coding.h (coding, code_convert_region, encode_coding_gap):
10413 Remove decls.
74ab6df5
PE
10414 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10415 (iso_code_class, detect_coding, code_convert_region): Now static.
10416 (encode_coding_gap): Remove; unused.
10417
38dfbee1
PE
10418 * chartab.c (chartab_chars, chartab_bits): Now static.
10419
a2cb4e63
PE
10420 * charset.h (charset_iso_8859_1): Remove decl.
10421 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10422 Now static.
10423
127198fd
PE
10424 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10425 * ccl.c (Vccl_program_table): Now static.
10426 (check_ccl_update): Remove; unused.
10427
d85b608f
PE
10428 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10429 * category.h: ... from here.
10430 * category.c (check_category_table, set_category_set): Now static.
10431
31cd66f3
PE
10432 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10433 * lisp.h: Remove these decls.
10434
c358e587
PE
10435 * buffer.c (buffer_count): Remove unused var.
10436
e78aecca
PE
10437 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10438 so that it's not optimized away.
10439 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10440 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10441 exported only to the debugger.
10442
e192d7d3 10443 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10444 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10445
92470028
PE
10446 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10447 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10448 was inaccessible from Lisp.
10449 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10450 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10451
244ed907
PE
10452 alloc.c: Import and export fewer symbols, and remove unused items.
10453 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10454 is defined.
10455 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10456 it's not optimized away by whole-program optimization.
10457 (message_enable_multibyte, free_misc): Remove.
10458 (catchlist, handlerlist, mark_backtrace):
10459 Declare only if BYTE_MARK_STACK.
10460 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10461 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10462 (message_enable_multibyte): Remove decl.
10463 (free_misc, interval_free_list, float_block, float_block_index):
10464 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10465 (cons_free_list, last_marked_index):
10466 Now static.
10467 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10468 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10469 (mark_backtrace): Define only if BYTE_MARK_STACK.
10470 * xdisp.c (message_enable_multibyte): Now static.
10471
61c2b50e 10472 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10473 This makes it easier for human readers (and static analyzers)
10474 to see whether these variables are used from other modules.
10475 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10476 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10477 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10478 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10479 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10480 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10481 * xmenu.c, xselect.c:
10482 Declare Q* vars static if they are not used in other modules.
10483 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10484 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10485 Remove decls of unexported vars.
10486 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10487
95c82688
PE
10488 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10489
16a97296
PE
10490 Make Emacs functions such as Fatom 'static' by default.
10491 This makes it easier for human readers (and static analyzers)
10492 to see whether these functions can be called from other modules.
10493 DEFUN now defines a static function. To make the function external
10494 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10495 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10496 (Finit_image_library):
16a97296
PE
10497 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10498 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10499 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10500 Remove decls, since these functions are now static.
10501 (Funintern, Fget_internal_run_time): New decls, since these functions
10502 were already external.
95c82688 10503
16a97296
PE
10504 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10505 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10506 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10507 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10508 * keyboard.c, keymap.c, lread.c:
10509 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10510 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10511 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10512 Mark functions with DEFUE instead of DEFUN,
10513 if they are used in other modules.
10514 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10515 decls for now-static functions.
10516 * buffer.h (Fdelete_overlay): Remove decl.
10517 * callproc.c (Fgetenv_internal): Mark as internal.
10518 * composite.c (Fremove_list_of_text_properties): Remove decl.
10519 (Fcomposition_get_gstring): New forward static decl.
10520 * composite.h (Fcomposite_get_gstring): Remove decl.
10521 * dired.c (Ffile_attributes): New forward static decl.
10522 * doc.c (Fdocumntation_property): New forward static decl.
10523 * eval.c (Ffetch_bytecode): New forward static decl.
10524 (Funintern): Remove extern decl; now in .h file where it belongs.
10525 * fileio.c (Fmake_symbolic_link): New forward static decl.
10526 * image.c (Finit_image_library): New forward static decl.
10527 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10528 * intervals.h (Fprevious_property_change):
10529 (Fremove_list_of_text_properties): Remove decls.
10530 * keyboard.c (Fthis_command_keys): Remove decl.
10531 (Fcommand_execute): New forward static decl.
10532 * keymap.c (Flookup_key): New forward static decl.
10533 (Fcopy_keymap): Now static.
10534 * keymap.h (Flookup_key): Remove decl.
10535 * process.c (Fget_process): New forward static decl.
10536 (Fprocess_datagram_address): Mark as internal.
10537 * syntax.c (Fsyntax_table_p): New forward static decl.
10538 (skip_chars): Remove duplicate decl.
10539 * textprop.c (Fprevious_property_change): New forward static decl.
10540 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10541 Now internal.
10542 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10543 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10544
785bbd42
PE
10545 * editfns.c (Fformat): Remove unreachable code.
10546
8b913b57
AS
105472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10548
10549 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10550 change. (Bug#8496)
10551
a6744a35
EZ
105522011-04-13 Eli Zaretskii <eliz@gnu.org>
10553
10554 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10555 when at ZV. (Bug#8487)
10556
e7974947
AS
105572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10558
baad03f0
AS
10559 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10560 (Bug#8437)
10561 * keyboard.c (parse_tool_bar_item): Likewise.
10562 * sound.c (sound_cleanup, alsa_close): Likewise.
10563 * termcap.c (tgetent): Likewise.
10564 * xfns.c (x_default_font_parameter): Likewise.
10565 * xsettings.c (read_and_apply_settings): Likewise.
10566
e7974947
AS
10567 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10568 (overrun_check_free): Protoize.
10569
28272684
PE
105702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10571
10572 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10573 since callers should never pass a negative size.
10574 Change the signature to match that of plain 'read' and 'write'; see
10575 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10576 * lisp.h: Update prototypes of emacs_write and emacs_read.
10577
11997c76
EZ
105782011-04-11 Eli Zaretskii <eliz@gnu.org>
10579
10580 * xdisp.c (redisplay_window): Don't try to determine the character
10581 position of the scroll margin if the window start point w->startp
e896f03c 10582 is outside the buffer's accessible region. (Bug#8468)
11997c76 10583
8a2cbd72
EZ
105842011-04-10 Eli Zaretskii <eliz@gnu.org>
10585
10586 Fix write-region and its subroutines for buffers > 2GB.
10587 * fileio.c (a_write, e_write): Modify declaration of arguments and
10588 local variables to support buffers larger than 2GB.
10589 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10590
10591 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10592 argument, local variables, and return value.
10593
10594 * lisp.h: Update prototypes of emacs_write and emacs_read.
10595
10596 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10597
4073e537 105982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10599
1ebfdcb6
PE
10600 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10601
b2ded58d
PE
10602 Fix more problems found by GCC 4.6.0's static checks.
10603
7d66342c
PE
10604 * xdisp.c (vmessage): Use a better test for character truncation.
10605
bbf47d44
PE
10606 * charset.c (load_charset_map): <, not <=, for optimization,
10607 and to avoid potential problems with integer overflow.
9248994d 10608 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10609 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10610 * editfns.c (Fformat): Likewise.
1e69125e 10611 * syntax.c (skip_chars): Likewise.
3befa583 10612
e3019616
PE
10613 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10614 This also lets GCC 4.6.0 generate slightly better loop code.
10615
becfa255
PE
10616 * callint.c (Fcall_interactively): <, not <=, for optimization.
10617 (Fcall_interactively): Count the number of arguments produced,
10618 not the number of arguments given. This is simpler and lets GCC
10619 4.6.0 generate slightly better code.
10620
dae0cd48
PE
10621 * ftfont.c: Distingish more carefully between FcChar8 and char.
10622 The previous code passed unsigned char * to a functions like
10623 strlen and xstrcasecmp that expect char *, which does not
10624 conform to the C standard.
10625 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10626 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10627 char * when the C standard requires it.
10628
76032d70
PE
10629 * keyboard.c (read_char): Remove unused var.
10630
eb3f1cc8
PE
10631 * eval.c: Port to Windows vsnprintf (Bug#8435).
10632 Include <limits.h>.
10633 (SIZE_MAX): Define if the headers do not.
10634 (verror): Do not give up if vsnprintf returns a negative count.
10635 Instead, grow the buffer. This ports to Windows vsnprintf, which
10636 does not conform to C99. Problem reported by Eli Zaretskii.
10637 Also, simplify the allocation scheme, by avoiding the need for
10638 calling realloc, and removing the ALLOCATED variable.
10639
70476b54
PE
10640 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10641
12020a9e
PE
10642 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10643 But keep the doprint source code for now, as we might revamp it
10644 and use it again (Bug#8435).
ea6c7ae6
PE
10645 * lisp.h (doprnt): Remove.
10646 * Makefile.in (base_obj): Remove doprnt.o.
10647 * deps.mk (doprnt.o): Remove.
10648
5fdb398c
PE
10649 error: Print 32- and 64-bit integers portably (Bug#8435).
10650 Without this change, on typical 64-bit hosts error ("...%d...", N)
10651 was used to print both 32- and 64-bit integers N, which relied on
10652 undefined behavior.
61bdb816 10653 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10654 * lisp.h (error, verror): Mark as printf-like functions.
10655 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10656 Report overflow in size calculations when allocating printf buffer.
10657 Do not truncate output string at its first null byte.
10658 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10659 Truncate the output at a character boundary, since vsnprintf does not
10660 do that.
10661 * charset.c (check_iso_charset_parameter): Convert internal
10662 character to string before calling 'error', since %c now has the
10663 printf meaning.
10664 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10665 overflow when computing char to be passed to 'error'. Do not
10666 pass Lisp_Object to 'error'; pass the integer instead.
10667 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10668 formatted with plain %d.
10669
b189fa66
PE
10670 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10671
bff87ef0
PE
10672 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10673
7e2cac20
PE
10674 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10675
ce4d90b5
PE
10676 * xterm.c (x_catch_errors): Remove duplicate declaration.
10677
266c9547
PE
10678 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10679
79c49ad2
PE
10680 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10681
368f4090
JM
106822011-04-10 Jim Meyering <meyering@redhat.com>
10683
10684 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10685 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10686 return ssize_t not "int", and use size_t as the buffer length.
10687 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10688 * gnutls.h: Update declarations.
10689 * process.c (read_process_output): Use ssize_t, to match.
10690 (send_process): Likewise.
10691
a32d4040
CY
106922011-04-09 Chong Yidong <cyd@stupidchicken.com>
10693
10694 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10695
8546720e 106962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10697
04f2d78b
CB
10698 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10699 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10700
8546720e
GM
10701 * xterm.c (handle_one_xevent):
10702 * xmenu.c (create_and_show_popup_menu):
10703 * xselect.c (x_decline_selection_request)
10704 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10705
0a2f5c1a 107062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10707
10708 Fix some uses of `int' instead of EMACS_INT.
10709 * search.c (string_match_1, fast_string_match)
10710 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10711 (scan_buffer, find_next_newline_no_quit)
10712 (find_before_next_newline, search_command, Freplace_match)
10713 (Fmatch_data): Make some `int' variables be EMACS_INT.
10714
10715 * xdisp.c (display_count_lines): 3rd argument and return value now
10716 EMACS_INT. All callers changed.
10717 (pint2hrstr): Last argument is now EMACS_INT.
10718
10719 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10720 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10721 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10722 (decode_coding_utf_16, decode_coding_emacs_mule)
10723 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10724 (decode_coding_ccl, decode_coding_charset)
10725 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10726 (decode_coding_iso_2022, decode_coding_emacs_mule)
10727 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10728 <char_offset, last_offset>: Declare EMACS_INT.
10729 (encode_coding_utf_8, encode_coding_utf_16)
10730 (encode_coding_emacs_mule, encode_invocation_designation)
10731 (encode_designation_at_bol, encode_coding_iso_2022)
10732 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10733 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10734 Declare EMACS_INT.
10735 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10736 (encode_invocation_designation): Last argument P_NCHARS is now
10737 EMACS_INT.
10738 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10739 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10740
10741 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10742 All users changed.
10743
10744 * ccl.c (Fccl_execute_on_string): Declare some variables
10745 EMACS_INT.
10746
8546720e 107472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10748
10749 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10750
4e19a977
CS
107512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10752
10753 * process.c (Fformat_network_address): Doc fix.
10754
87302331
R
107552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10756
ee7683eb 10757 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10758
cbb59342
CY
107592011-04-08 Chong Yidong <cyd@stupidchicken.com>
10760
10761 * keyboard.c (read_char): Call Lisp function help-form-show,
10762 instead of using internal_with_output_to_temp_buffer.
10763 (Qhelp_form_show): New var.
e0d38eeb 10764 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10765
10766 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10767
10768 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10769
e67a13ab
CY
107702011-04-06 Chong Yidong <cyd@stupidchicken.com>
10771
04f2d78b
CB
10772 * process.c (Flist_processes): Remove to Lisp.
10773 (list_processes_1): Delete.
e67a13ab 10774
973f782d
EZ
107752011-04-06 Eli Zaretskii <eliz@gnu.org>
10776
7c106b1e
EZ
10777 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10778
973f782d
EZ
10779 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10780
41cf7d1a 107812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10782
ca23cc88
PE
10783 Fix more problems found by GCC 4.6.0's static checks.
10784
f390e2d5
PE
10785 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10786
42eea0d0
PE
10787 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10788
b69769da 10789 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10790
f9541e84
PE
10791 * xdisp.c (vmessage): Mark as a printf-like function.
10792
13841b55
PE
10793 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10794
c136c10f
PE
10795 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10796
5e2d4a30
PE
10797 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10798 printf-like functions.
10799 (tiff_load): Add casts to remove these marks before passing them
10800 to system-supplied API.
10801
583f48b9
PE
10802 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10803
b25d760e
PE
10804 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10805 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10806 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10807 directly, rather than having caller test rule sign. This avoids
10808 some unnecessary tests.
10809 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10810 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10811 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10812
bc7b6697 10813 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10814 (xfont_open): Avoid unnecessary tests.
bc7b6697 10815
27ccc379
PE
10816 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10817
dcd5c89a
PE
10818 * composite.h, composite.c (composition_gstring_put_cache):
10819 Use EMACS_INT, not int, for length.
10820
b13a45c6
PE
10821 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10822 breaking out part of COMPOSITION_DECODE_RULE.
10823 (COMPOSITION_DECODE_RULE): Use it.
10824 * composite.c (get_composition_id): Remove unused local vars,
10825 by using the new macro.
10826
1e792e4d
PE
10827 * textprop.c (set_text_properties_1): Change while to do-while,
10828 since the condition is always true at first.
10829
dc6c6455 10830 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10831 (interval_deletion_adjustment): Return unsigned value.
10832 All uses changed.
dc6c6455 10833
aba7731a
PE
10834 * process.c (list_processes_1, create_pty, read_process_output):
10835 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10836 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10837 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10838 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10839 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10840
fdfc4bf3
PE
10841 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10842
fca8fe46 10843 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10844 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10845
06a0259a 10846 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10847 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10848 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10849
e7b9e80f
PE
10850 * print.c (print_error_message): Avoid int overflow.
10851
56201685
PE
10852 * font.c (font_list_entities): Redo for clarity,
10853 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10854
78834453 10855 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10856 (font_score): Avoid potential overflow in diff calculation.
78834453 10857
0bc0b309 10858 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10859 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10860
e610eaca
PE
10861 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10862
b895abce
PE
10863 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10864 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10865 can always succeed if overflow has undefined behavior.
10866
1f1d9321 10867 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10868 (wordify): Omit three unnecessary tests.
1f1d9321 10869
c59478bc
PE
10870 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10871 All callers changed. This avoids the need for an unused var.
10872
79b73827
PE
10873 * casefiddle.c (casify_region): Remove var that is set but not used.
10874
a4db5dfe
PE
10875 * dired.c (file_name_completion): Remove var that is set but not used.
10876
43aae36e
PE
10877 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10878
2a47c44d 10879 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10880 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10881
a37c69bf
PE
10882 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10883 Check for integer overflow on size calculations.
10884
328ab8e7
PE
10885 * buffer.c (Fprevious_overlay_change): Remove var that is set
10886 but not used.
10887
e5a2a5cb
PE
10888 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10889 Remove vars that are set but not used.
8d84a6eb 10890 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10891 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10892
a60e5f68
PE
10893 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10894
f661cb61 10895 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10896 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10897
f0397f5a
PE
10898 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10899 that are set but not used.
10900
8664db06 10901 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10902 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10903
6abdaa4a
PE
10904 * xselect.c (x_get_local_selection, x_handle_property_notify):
10905 Remove vars that are set but not used.
10906
0ce7538d 10907 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10908 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10909
9ae848fc
PE
10910 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10911 Remove var that is set but not used.
0b918413
PE
10912 (scroll_bar_windows_size): Now size_t, not int.
10913 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10914 Check for overflow.
9ae848fc 10915
a5a62657
PE
10916 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10917 (map_tty_color) [!defined MSDOS]: Likewise.
10918
5c5cdd39
PE
10919 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10920
66ebf983
PE
10921 * coding.c: Remove vars that are set but not used.
10922 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10923 All callers changed.
10924 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10925 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10926 (decode_coding_charset): Remove vars that are set but not used.
10927
1be4d761
PE
10928 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10929 that is set but not used.
10930
47553fa8
PE
10931 * print.c (print_object): Remove var that is set but not used.
10932
1f7196bf 10933 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10934 The gnulib version avoids calling malloc in the usual case,
10935 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10936 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10937 * filelock.c (current_lock_owner): Likewise.
10938 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10939 * sysdep.c: Include allocator.h, careadlinkat.h.
10940 (emacs_no_realloc_allocator): New static constant.
10941 (emacs_readlink): New function.
fdb61804
PE
10942 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10943 ../lib/careadlinkat.h.
d1fdcab7 10944
f84c17c7
SM
109452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10946
10947 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10948 first non-nil return value).
10949
ef3862ad
JD
109502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10951
10952 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10953 if not defined (Bug#8403).
10954
376a7006
JB
109552011-04-02 Juanma Barranquero <lekktu@gmail.com>
10956
10957 * xdisp.c (display_count_lines): Remove parameter `start',
10958 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10959 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10960 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10961 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10962 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10963 and thereabouts. All callers changed.
10964 (get_per_char_metric): Remove parameter `f', unused since
10965 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10966
6ca3801d
JM
109672011-04-02 Jim Meyering <meyering@redhat.com>
10968
10969 do not dereference NULL upon failed strdup
10970 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10971 (ns_get_family): Likewise.
10972
d8e2b5ba
JB
109732011-04-02 Juanma Barranquero <lekktu@gmail.com>
10974
10975 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10976
8c74fcbd
JD
109772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10978
10979 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10980 later (Bug#8403).
10981
7200d79c
SM
109822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10983
03408648 10984 Add lexical binding.
7200d79c 10985
03408648
SM
10986 * window.c (Ftemp_output_buffer_show): New fun.
10987 (Fsave_window_excursion):
10988 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10989
10990 * lread.c (lisp_file_lexically_bound_p): New function.
10991 (Fload): Bind Qlexical_binding.
10992 (readevalloop): Remove `evalfun' arg.
10993 Bind Qinternal_interpreter_environment.
10994 (Feval_buffer): Bind Qlexical_binding.
10995 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10996 Mark as dynamic.
10997 (syms_of_lread): Declare `lexical-binding'.
10998
10999 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11000
11001 * keyboard.c (eval_dyn): New fun.
11002 (menu_item_eval_property): Use it.
ca105506
SM
11003
11004 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11005
03408648
SM
11006 * fns.c (concat, mapcar1): Accept byte-code-functions.
11007
11008 * eval.c (Fsetq): Handle lexical vars.
11009 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11010 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11011 (FletX, Flet): Obey lexical binding.
11012 (Fcommandp): Handle closures.
11013 (Feval): New `lexical' arg.
11014 (eval_sub): New function extracted from Feval. Use it almost
11015 everywhere where Feval was used. Look up vars in lexical env.
11016 Handle closures.
11017 (Ffunctionp): Move from subr.el.
11018 (Ffuncall): Handle closures.
11019 (apply_lambda): Remove `eval_flags'.
11020 (funcall_lambda): Handle closures and new byte-code-functions.
11021 (Fspecial_variable_p): New function.
11022 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11023 but without exporting it to Lisp.
23aba0ea 11024
23aba0ea 11025 * doc.c (Fdocumentation, store_function_docstring):
03408648 11026 * data.c (Finteractive_form): Handle closures.
23aba0ea 11027
03408648
SM
11028 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11029 interactive spec.
ba83908c 11030
04f2d78b
CB
11031 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11032 New byte-codes.
03408648
SM
11033 (exec_byte_code): New function extracted from Fbyte_code to handle new
11034 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11035
03408648 11036 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11037
03408648 11038 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11039
e2abce01
JB
110402011-03-31 Juanma Barranquero <lekktu@gmail.com>
11041
11042 * xdisp.c (redisplay_internal): Fix prototype.
11043
63696a73 110442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11045
63696a73 11046 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11047 (try_scrolling): Use it when setting scroll_limit.
11048 Limit scrolling to 100 screen lines.
63696a73
EZ
11049 (redisplay_window): Even when falling back on "recentering",
11050 position point in the window according to scroll-conservatively,
11051 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11052
11053 (try_scrolling): When point is above the window, allow searching
11054 as far as scroll_max, or one screenful, to compute vertical
11055 distance from PT to the scroll margin position. This prevents
11056 try_scrolling from unnecessarily failing when
11057 scroll-conservatively is set to a value slightly larger than the
11058 window height. Clean up the case of PT below the margin at bottom
11059 of window: scroll_max can no longer be INT_MAX. When aggressive
11060 scrolling is in use, don't let point enter the opposite scroll
11061 margin as result of the scroll.
11062 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11063 threshold of 100 lines for never-recentering scrolling.
11064
e4cc2dfc
JB
110652011-03-31 Juanma Barranquero <lekktu@gmail.com>
11066
11067 * dispextern.h (move_it_by_lines):
11068 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11069 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11070 (message_log_check_duplicate): Remove parameters `prev_bol' and
11071 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11072 (redisplay_internal): Remove parameter `preserve_echo_area',
11073 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11074
11075 * indent.c (Fvertical_motion):
11076 * window.c (window_scroll_pixel_based, Frecenter):
11077 Don't pass `need_y_p' to `move_it_by_lines'.
11078
1c470562
SM
110792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11080
44f230aa
SM
11081 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11082 steal a few bits to be more compact.
11083 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11084 Remove unneeded casts.
11085
1c470562
SM
11086 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11087
888adce9
ZK
110882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11089
11090 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11091 binding" message (bug#7967).
11092
f838ed7b
PE
110932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11094
77861b95
PE
11095 Fix more problems found by GCC 4.6.0's static checks.
11096
de6dbc14
PE
11097 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11098 Remove unused local var.
11099
f838ed7b
PE
11100 * editfns.c (Fmessage_box): Remove unused local var.
11101
792c7b2b
PE
11102 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11103 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11104 Omit unused local vars.
c499e557 11105 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11106 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11107 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11108 Omit unused local var.
11109
ba0165e1
PE
11110 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11111 Don't assume string length fits in int.
32ad8845 11112 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11113 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11114
3c59b4c9
PE
11115 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11116 instead of alloca (Bug#8344).
11117
a3eed478 11118 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11119 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11120
eb4d412d
PE
11121 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11122
1658b401
PE
11123 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11124 concerns.
11125
11126 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11127
11128 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11129
9a2c6e05
PE
11130 * keyboard.c (syms_of_keyboard): Use the same style as later
11131 in this function when indexing through an array. This also
11132 works around GCC bug 48267.
11133
03d0a109
PE
11134 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11135
44f730c8
PE
11136 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11137
fe75f926
PE
11138 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11139 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11140
ffa8c828
PE
11141 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11142 This avoids undefined behavior on integer overflow, and is a bit
11143 more convenient anyway since it is compared to a size_t variable.
11144
c5101a77
PE
11145 Variadic C functions now count arguments with size_t, not int.
11146 This avoids an unnecessary limitation on 64-bit machines, which
11147 caused (substring ...) to crash on large vectors (Bug#8344).
11148 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11149 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11150 All variadic functions and their callers changed accordingly.
c5101a77
PE
11151 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11152 * data.c (arith_driver, float_arith_driver): Likewise.
11153 * editfns.c (general_insert_function): Likewise.
11154 * eval.c (struct backtrace.nargs, interactive_p)
11155 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11156 (funcall_lambda, mark_backtrace): Likewise.
11157 * fns.c (concat): Likewise.
11158 * frame.c (x_set_frame_parameters): Likewise.
11159 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11160 0 if not found, not -1. All callers changed.
11161
dd3f25f7
PE
11162 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11163 (stack_copy_size): Now size_t, not int.
11164 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11165
461c2ab9
JB
111662011-03-28 Juanma Barranquero <lekktu@gmail.com>
11167
11168 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11169 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11170 All callers changed.
11171
11172 * lisp.h (multibyte_char_to_unibyte):
11173 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11174 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11175 * character.h (CHAR_TO_BYTE8):
11176 * cmds.c (internal_self_insert):
11177 * editfns.c (general_insert_function):
11178 * keymap.c (push_key_description):
11179 * search.c (Freplace_match):
11180 * xdisp.c (message_dolog, set_message_1): All callers changed.
11181
f6d62986
SM
111822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11183
11184 * keyboard.c (safe_run_hook_funcall): New function.
11185 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11186 don't set the hook to nil, but remove the offending function instead.
11187 (Qcommand_hook_internal): Remove, unused.
11188 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11189 Vcommand_hook_internal.
11190
11191 * eval.c (enum run_hooks_condition): Remove.
11192 (funcall_nil, funcall_not): New functions.
11193 (run_hook_with_args): Call each function through a `funcall' argument.
11194 Remove `cond' argument, now redundant.
11195 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11196 (Frun_hook_with_args_until_failure): Adjust accordingly.
11197 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11198
1db5b1ad
JB
111992011-03-28 Juanma Barranquero <lekktu@gmail.com>
11200
11201 * dispextern.h (string_buffer_position): Remove declaration.
11202
11203 * print.c (strout): Remove parameter `multibyte', unused since
11204 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11205
11206 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11207 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11208 All callers changed.
11209
11210 * w32.c (_wsa_errlist): Use braces for struct initializers.
11211
11212 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11213 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11214 All callers changed.
11215 (string_buffer_position): Likewise. Also, make static (it's never
11216 used outside xdisp.c).
11217 (cursor_row_p): Remove parameter `w', unused since
11218 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11219 (decode_mode_spec): Remove parameter `precision', introduced during
11220 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11221 All callers changed.
11222
5ffb62aa
JD
112232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11224
11225 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11226
461c2ab9 112272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11228
11229 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11230 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11231 (ns_update_auto_hide_menu_bar): New functions.
11232 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11233 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11234 ns_constrain_all_frames.
11235 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11236 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11237
5c380ffb
JD
112382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11239
11240 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11241
9af30bdf
GM
112422011-03-27 Glenn Morris <rgm@gnu.org>
11243
11244 * syssignal.h: Replace RETSIGTYPE with void.
11245 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11246 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11247 Replace SIGTYPE with void everywhere.
11248 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11249 * s/template.h (SIGTYPE): Remove commented out definition.
11250
e2abce01
JB
112512011-03-26 Eli Zaretskii <eliz@gnu.org>
11252
11253 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11254 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11255
f868cd8a
JB
112562011-03-26 Juanma Barranquero <lekktu@gmail.com>
11257
59eb0929
JB
11258 * w32.c (read_unc_volume): Use parameter `henum', instead of
11259 global variable `wget_enum_handle'.
11260
11261 * keymap.c (describe_vector): Remove parameters `indices' and
11262 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11263 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11264
f868cd8a
JB
11265 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11266
11267 * keyboard.c (timer_check): Remove parameter `do_it_now',
11268 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11269 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11270 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11271
11272 * keyboard.c (read_char):
11273 * w32menu.c (w32_menu_display_help):
11274 * xmenu.c (show_help_event, menu_help_callback):
11275 Adjust calls to `show_help_echo'.
11276
11277 * gtkutil.c (xg_maybe_add_timer):
11278 * keyboard.c (readable_events):
11279 * process.c (wait_reading_process_output):
11280 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11281
11282 * insdel.c (adjust_markers_gap_motion):
11283 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11284 (gap_left, gap_right): Don't call it.
11285
2ecf6fdb
CY
112862011-03-25 Chong Yidong <cyd@stupidchicken.com>
11287
11288 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11289 incurred during fontification.
11290
6b1f9ba4
JB
112912011-03-25 Juanma Barranquero <lekktu@gmail.com>
11292
11293 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11294 (DEFVAR_PER_BUFFER): Don't pass it.
11295
11296 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11297 (scrolling_window): Don't pass it.
11298
0f4a96b5
JB
112992011-03-25 Juanma Barranquero <lekktu@gmail.com>
11300
11301 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11302
11303 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11304 and `suffix'.
11305 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11306 of variables specific to SELinux and computation of `encoded_absname'.
11307
11308 * image.c (XPutPixel): Remove unused variable `height'.
11309
11310 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11311
11312 * unexw32.c (get_section_info): Remove unused variable `section'.
11313
11314 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11315 (system_process_attributes): Remove unused variable `sess'.
11316 (sys_read): Remove unused variable `err'.
11317
11318 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11319 (w32_wnd_proc): Remove unused variable `isdead'.
11320 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11321 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11322 (x_create_tip_frame): Remove unused variable `tem'.
11323
11324 * w32inevt.c (w32_console_read_socket):
11325 Remove unused variable `no_events'.
11326
11327 * w32term.c (x_draw_composite_glyph_string_foreground):
11328 Remove unused variable `width'.
11329
1149507c
JB
113302011-03-24 Juanma Barranquero <lekktu@gmail.com>
11331
11332 * w32term.c (x_set_glyph_string_clipping):
11333 Don't pass uninitialized region to CombineRgn.
11334
9c88f339
JB
113352011-03-23 Juanma Barranquero <lekktu@gmail.com>
11336
11337 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11338 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11339 (Fx_close_connection): Remove unused variable `i'.
11340
11341 * w32font.c (w32font_draw): Return number of glyphs.
11342 (w32font_open_internal): Remove unused variable `i'.
11343 (w32font_driver): Add missing initializer.
11344
11345 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11346 (fill_in_menu): Remove unused variable `items_added'.
11347
11348 * w32term.c (last_mouse_press_frame): Remove static global variable.
11349 (w32_clip_to_row): Remove unused variable `f'.
11350 (x_delete_terminal): Remove unused variable `i'.
11351
11352 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11353 (NOTHING): Remove unused static global variable.
11354 (uniscribe_check_otf): Remove unused variable `table'.
11355 (uniscribe_font_driver): Add missing initializers.
11356
dee091a3
JD
113572011-03-23 Julien Danjou <julien@danjou.info>
11358
11359 * term.c (Fsuspend_tty, Fresume_tty):
11360 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11361 * window.c (temp_output_buffer_show):
11362 * insdel.c (signal_before_change):
11363 * frame.c (Fhandle_switch_frame):
11364 * fileio.c (Fdo_auto_save):
11365 * emacs.c (Fkill_emacs):
11366 * editfns.c (save_excursion_restore):
11367 * cmds.c (internal_self_insert):
11368 * callint.c (Fcall_interactively):
11369 * buffer.c (Fkill_all_local_variables):
11370 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11371 Use Frun_hooks.
0f4a96b5 11372 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11373 unconditionally since it does the check itself.
dee091a3 11374
2c520ab5 113752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11376
c9c49752
PE
11377 Fix more problems found by GCC 4.5.2's static checks.
11378
8abc3f12
PE
11379 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11380 the first time through the loop, since we know p0 < p1 then.
11381 This also avoids a gcc -Wstrict-overflow warning.
11382
a2d26660
PE
11383 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11384 leading to a memory leak, possible in functions like
11385 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11386 of objects (Bug#8318).
a2d26660 11387
916c72e9
PE
11388 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11389 that could (at least in theory) be that large.
11390
19ab8a18
PE
11391 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11392 This is less likely to overflow, and avoids undefined behavior if
11393 overflow does occur. All callers changed. Use strtoul to scan
11394 for the unsigned long integer.
b7cbbd6f
PE
11395 (pint2hrstr): Simplify and tune code slightly.
11396 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11397
f0641eff
PE
11398 * scroll.c (do_scrolling): Work around GCC bug 48228.
11399 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11400
7f650bb9
PE
11401 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11402 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11403 (validate_x_resource_name): Simplify count usage.
11404 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11405
37dd57d1
PE
11406 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11407 fail (Bug#8306).
81e56e61 11408
699979fc 11409 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11410
401bf9b4
PE
11411 * process.c (Fmake_network_process): Use socklen_t, not int,
11412 where POSIX says socklen_t is required in portable programs.
11413 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11414 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11415 (Fmake_network_process, server_accept_connection):
11416 (wait_reading_process_output, read_process_output):
11417 Likewise.
11418
b93aacde
PE
11419 * process.c: Rename or move locals to avoid shadowing.
11420 (list_processes_1, Fmake_network_process):
11421 (read_process_output_error_handler, exec_sentinel_error_handler):
11422 Rename or move locals.
4dc343ee 11423 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11424 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11425 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11426 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11427 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11428
af8a867c 11429 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11430 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11431 Include tparam.h instead, since it declares them.
af8a867c
PE
11432 * cm.h (PC): Remove extern decl; tparam.h now does this.
11433 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11434 * terminfo.c: Include tparam.h, to check interfaces.
11435 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11436 (tparam): Adjust signature to match interface in tparam.h;
11437 this removes some undefined behavior. Check that outstring and len
11438 are zero, which they always are with Emacs.
11439 * tparam.h (PC, BC, UP): New extern decls.
11440
0248044d 11441 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11442 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11443
8ff096c1 11444 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11445 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11446 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11447 (ftfont_list): Remove unused local.
49eaafba
PE
11448 (get_adstyle_property, ftfont_pattern_entity):
11449 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11450 Rename locals to avoid shadowing.
8ff096c1 11451
e2be39f6
PE
11452 * xfont.c (xfont_list_family): Mark var as initialized.
11453
c9735e30
PE
11454 * xml.c (make_dom): Now static.
11455
8f5201ae
PE
11456 * composite.c (composition_compute_stop_pos): Rename local to
11457 avoid shadowing.
b246f932
PE
11458 (composition_reseat_it): Remove unused locals.
11459 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11460 (composition_update_it): Mark var as initialized.
11b61122
PE
11461 (find_automatic_composition): Mark vars as initialized,
11462 with a FIXME (Bug#8290).
8f5201ae 11463
760fbc2c
PE
11464 character.h: Rename locals to avoid shadowing.
11465 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11466 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11467 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11468 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11469 to avoid shadowing.
11470
ff08eb85
PE
11471 * textprop.c (property_change_between_p): Remove; unused.
11472
fc7bf025
PE
11473 * intervals.c (interval_start_pos): Now static.
11474
235d7abc
PE
11475 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11476
44f230aa
SM
11477 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11478 Rename locals to avoid shadowing.
3e7d6594 11479
50060332
PE
11480 * sound.c (wav_play, au_play, Fplay_sound_internal):
11481 Fix pointer signedness.
d01f234b 11482 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11483 (wav_play): Initialize a variable to 0, to prevent undefined
11484 behavior (Bug#8278).
50060332 11485
c4fc4e30
PE
11486 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11487
918436ed
PE
11488 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11489
c939f91b
PE
11490 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11491 clobbering (Bug#8298).
b9c7f648
PE
11492 * sysdep.c (sys_subshell): Likewise.
11493 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11494
6bd8c144
PE
11495 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11496 This should get cleaned up, so that child_setup has the
11497 same signature on all platforms.
11498
7710357c 11499 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11500 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11501
c59da222
CY
115022011-03-22 Chong Yidong <cyd@stupidchicken.com>
11503
11504 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11505 not to be necessary, and produces flickering.
11506
66b87493
GM
115072011-03-20 Glenn Morris <rgm@gnu.org>
11508
11509 * config.in: Remove file.
11510
45b6f6d5
JB
115112011-03-20 Juanma Barranquero <lekktu@gmail.com>
11512
11513 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11514 are now in src/globals.h.
11515 (syms_of_minibuf): Remove spurious & from previous change.
11516
cd394be1 115172011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11518
11519 * minibuf.c (completing-read-function): New variable.
11520 (completing-read-default): Rename from completing-read.
11521 (completing-read): Call completing-read-function.
11522
b14e3e21
CY
115232011-03-19 Juanma Barranquero <lekktu@gmail.com>
11524
11525 * xfaces.c (Fx_load_color_file):
11526 Read color file from absolute filename (bug#8250).
11527
f2b726e6
JB
115282011-03-19 Juanma Barranquero <lekktu@gmail.com>
11529
11530 * makefile.w32-in: Update dependencies.
11531
09f6ff02
EZ
115322011-03-17 Eli Zaretskii <eliz@gnu.org>
11533
11534 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11535
29a6015a
PE
115362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11537
a3a6c54e
PE
11538 Fix more problems found by GCC 4.5.2's static checks.
11539
b766f867
PE
11540 * process.c (make_serial_process_unwind, send_process_trap):
11541 (sigchld_handler): Now static.
11542
be02381c
PE
11543 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11544 That way, the code declares only the vars that it needs.
11545 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11546 * s/cygwin.h (PTY_ITERATION): Likewise.
11547 * s/darwin.h (PTY_ITERATION): Likewise.
11548 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11549
57048744
PE
11550 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11551 * process.c (allocate_pty): Don't declare stb unless it's needed.
11552
7914961c 11553 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11554 (CONSTANTLIM): Remove; unused.
11555 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11556 Define only if needed.
7914961c 11557
b3967b18
PE
11558 * unexelf.c (unexec): Name an expression,
11559 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11560 Use a different way to cause a compilation error if anyone uses
11561 n rather than nn, a way that does not involve shadowing.
73366a00 11562 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11563
29a6015a
PE
11564 * deps.mk (unexalpha.o): Remove; unused.
11565
43cfc33e 11566 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11567 * unexec.h: New file.
ce701a33
PE
11568 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11569 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11570 Depend on unexec.h.
11571 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11572 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11573 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11574 Change as necessary to match prototype in unexec.h.
ce701a33 11575
01f44d5a
PE
11576 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11577 shadowing.
4f63c6bb 11578 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11579
a6670b0b
PE
11580 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11581 Rename locals to avoid shadowing.
11582
cef2010d 11583 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11584 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11585
d4d7173a
PE
11586 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11587
f08b802a
PE
11588 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11589 warning when compiling print.c.
11590
3ddb0639
PE
11591 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11592 instead of using an uninitialized var.
5ad03b97 11593 (font_sort_entities): Mark var as initialized.
3ddb0639 11594
170a2692
PE
11595 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11596
e663c700
PE
11597 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11598 pointers to constants.
89bc529a 11599 (font_parse_fcname): Remove unused vars.
7b81e2d0 11600 (font_delete_unmatched): Now static.
ea838e10 11601 (font_get_spec): Remove; unused.
13a547c6
PE
11602 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11603 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11604 Rename or move locals to avoid shadowing.
e663c700 11605
2a80c887 11606 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11607 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11608
1384fa33 11609 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11610 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11611
8b2c52e9
PE
11612 * alloc.c (mark_backtrace): Move decl from here ...
11613 * lisp.h: ... to here, so that it can be checked.
11614
475545b5 11615 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11616 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11617 (lisp_indirect_variable): Name an expression,
11618 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11619 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11620
b1349114 11621 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11622 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11623 Use const pointer when appropriate.
b1349114 11624
a2928364
PE
11625 * lisp.h (get_system_name, get_operating_system_release):
11626 Move decls here, to check interfaces.
11627 * process.c (get_operating_system_release): Move decl to lisp.h.
11628 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11629 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11630 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11631 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11632 (Fformat_time_string, Fencode_time, Finsert_char):
11633 (Ftranslate_region_internal, Fformat):
11634 Rename or remove local vars to avoid shadowing.
9710023e 11635 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11636
a415e694
PE
11637 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11638 avoid shadowing.
11639
8ef4622d
PE
11640 * lisp.h (eassert): Check that the argument compiles, even if
11641 ENABLE_CHECKING is not defined.
11642
946f9a5b
PE
11643 * data.c (Findirect_variable): Name an expression, to avoid
11644 gcc -Wbad-function-cast warning.
112396d6 11645 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11646 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11647 (Fmake_variable_buffer_local, Fmake_local_variable):
11648 Mark variables as initialized.
52746918 11649 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11650
e5aab7e7 11651 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11652 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11653 Rename locals to avoid shadowing.
dff45157
PE
11654 (mark_stack): Move local variables into the #ifdef region where
11655 they're used.
7bc26fdb
PE
11656 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11657 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11658 needed otherwise.
11659 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11660 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11661 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11662
e5aab7e7
PE
11663 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11664 avoids undefined behavior in theory.
11665
4da60324
PE
11666 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11667
88043301
PE
11668 Use functions, not macros, for up- and down-casing (Bug#8254).
11669 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11670 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11671 to use the following functions instead of these macros.
11672 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11673 EMACS_INT, since callers assume the returned value fits in int.
11674 (upcase1): Likewise, for UPCASE_TABLE.
11675 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11676 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11677 the race-condition problem in the old DOWNCASE.
88043301 11678
19ed5445
PE
11679 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11680 Rename locals to avoid shadowing.
11681 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11682 (regex_compile, re_search_2, re_match_2_internal):
11683 Remove unused local vars.
952db0d7
PE
11684 (FREE_VAR): Rewrite so as not to use empty "else",
11685 which gcc can warn about.
da053e48 11686 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11687 (RETALLOC_IF): Define only if needed.
11688 (WORDCHAR_P): Likewise. This one is never needed, but is used
11689 only in a comment talking about a compiler bug, so put inside
11690 the #if 0 of that comment.
11691 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11692 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11693 Remove; unused.
19ed5445 11694
1f3561e4 11695 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11696 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11697 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11698
ded6f8f7
PE
11699 * search.c (simple_search): Remove unused var.
11700
dbd37a95
PE
11701 * dired.c (compile_pattern): Move decl from here ...
11702 * lisp.h: ... to here, so that it can be checked.
11703 (struct re_registers): New forward decl.
11704
7e47afad
PE
11705 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11706
85f24f61
PE
11707 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11708 All uses changed.
11709 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11710 Rename locals to avoid shadowing.
5671df8f 11711 (Fvertical_motion): Mark locals as initialized.
85f24f61 11712
181aa2be 11713 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11714 (casify_region): Mark local as initialized.
181aa2be 11715
930d429c
PE
11716 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11717
7082eac6
PE
11718 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11719 New macros, so that the caller can use some names other than
11720 gcpro1, gcpro2, etc.
11721 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11722 of the new macros.
11723 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11724 argument, for consistency with GCPRO2_VAR, etc: it is now the
11725 prefix of the variable, not the variable itself. All uses
11726 changed.
38b2c076
PE
11727 * dired.c (directory_files_internal, file_name_completion):
11728 Rename locals to avoid shadowing.
11729
15206ed9
PE
11730 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11731 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11732 dired.c's scmp function, had undefined behavior.
11733 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11734 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11735 * buffer.h: ... to here, because these macros use current_buffer,
11736 and the new implementation with inline functions needs to have
11737 current_buffer in scope now, rather than later when the macros
11738 are used.
11739 (downcase, upcase1): New static inline functions.
11740 (DOWNCASE, UPCASE1): Reimplement using these functions.
11741 This avoids undefined behavior in expressions like
11742 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11743 from race conditions in accessing the global variables
11744 case_temp1 and case_temp2.
11745 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11746 * lisp.h (case_temp1, case_temp2): Remove their decls.
11747 * character.h (ASCII_CHAR_P): Move from here ...
11748 * lisp.h: ... to here, so that the inline functions mentioned
11749 above can use them.
11750
4a6bea26
PE
11751 * dired.c (directory_files_internal_unwind): Now static.
11752
f14b7e14
PE
11753 * fileio.c (file_name_as_directory, directory_file_name):
11754 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11755 Now static.
2893f146
PE
11756 (file_name_as_directory): Use const pointers when appropriate.
11757 (Fexpand_file_name): Likewise. In particular, newdir might
11758 point at constant storage, so make it a const pointer.
fd4ead52 11759 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11760 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11761 signedness issues.
f839df0c
PE
11762 (Fset_file_times, Finsert_file_contents, auto_save_error):
11763 Rename locals to avoid shadowing.
f14b7e14 11764
5716756e 11765 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11766 (Ftry_completion, Fall_completions): Rename or remove locals
11767 to avoid shadowing.
5716756e 11768
b4c3046a
PE
11769 * marker.c (bytepos_to_charpos): Remove; unused.
11770
b45db522
PE
11771 * lisp.h (verify_bytepos, count_markers): New decls,
11772 so that gcc does not warn that these functions aren't declared.
11773
85876d07
PE
11774 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11775 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11776 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11777 (copy_text): Remove unused local var.
85876d07 11778
03d78a21 11779 * filelock.c (within_one_second): Now static.
b3dd38ab 11780 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11781
5df8f01b
PE
11782 * buffer.c (fix_overlays_before): Mark locals as initialized.
11783 (fix_start_end_in_overlays): Likewise. This function should be
11784 simplified by using pointers-to-pointers, but that's a different
11785 matter.
b1d876f1 11786 (switch_to_buffer_1): Now static.
8f54f30a
PE
11787 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11788 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11789
a70072c9 11790 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11791 Fix pointer signedness issue.
edced198
PE
11792 (sys_subshell): Mark local as volatile if checking for lint,
11793 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11794 (MAXPATHLEN): Define only if needed.
a70072c9 11795
a0977c44
PE
11796 * process.c (serial_open, serial_configure): Move decls from here ...
11797 * systty.h: ... to here, so that they can be checked.
11798
a884fdcc
PE
11799 * fns.c (get_random, seed_random): Move extern decls from here ...
11800 * lisp.h: ... to here, so that they can be checked.
11801
604efe86 11802 * sysdep.c (reset_io): Now static.
b8950c94 11803 (wait_for_termination_signal): Remove; unused.
604efe86 11804
38fc62d9
PE
11805 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11806 (copy_keymap_item, append_key, push_text_char_description):
11807 Now static.
1004a21a 11808 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11809 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11810 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11811 (describe_map_tree):
11812 Rename locals to avoid shadowing.
38fc62d9 11813
2f2650da
PE
11814 * keyboard.c: Declare functions static if they are not used elsewhere.
11815 (echo_char, echo_dash, cmd_error, top_level_2):
11816 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11817 (read_char, kbd_buffer_get_event, make_lispy_position):
11818 (make_lispy_event, make_lispy_movement, apply_modifiers):
11819 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11820 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11821 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11822 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11823 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11824
a053e86c 11825 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11826 (mark_kboards): Move decl here ...
11827 * alloc.c (mark_kboards): ... from here.
a053e86c 11828
4752793e
PE
11829 * lisp.h (force_auto_save_soon): New decl.
11830
74f10ca7 11831 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11832 (DEFINE_DUMMY_FUNCTION): New macro.
11833 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11834 Use it.
c03cd23f
PE
11835 (main): Add casts to avoid warnings
11836 if GCC considers string literals to be constants.
74f10ca7 11837
022e70d4
PE
11838 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11839
59d6fe83
PE
11840 * dbusbind.c: Pointer signedness fixes.
11841 (xd_signature, xd_append_arg, xd_initialize):
11842 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11843 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11844 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11845 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11846
78320123
PE
11847 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11848 if GCC considers string literals to be constants.
49cebcca 11849 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11850
35ac2a97
SM
118512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11852
fb103ca9
SM
11853 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11854 (print_preprocess, print_object): New macro to fix last change.
11855
35ac2a97
SM
11856 * print.c (print_preprocess): Don't forget font objects.
11857
62973b41
JB
118582011-03-16 Juanma Barranquero <lekktu@gmail.com>
11859
11860 * emacs.c (USAGE3): Doc fixes.
11861
0e48bb22
AS
118622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11863
11864 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11865 structure.
11866
7684e57b
JB
118672011-03-14 Juanma Barranquero <lekktu@gmail.com>
11868
11869 * lisp.h (VWindow_system, Qfile_name_history):
11870 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11871 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11872 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11873
11874 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11875 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11876
11877 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11878 * w32console.c (detect_input_pending, read_input_pending)
11879 (encode_terminal_code):
11880 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11881 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11882 (w32_system_caret_y, Qfile_name_history):
11883 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11884 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11885 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11886 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11887 * w32proc.c (Qlocal, report_file_error):
11888 * w32term.c (Vwindow_system, updating_frame):
11889 * w32uniscribe.c (initialized, uniscribe_font_driver):
11890 Remove unneeded extern declarations.
11891
2aa46d6c
CY
118922011-03-14 Chong Yidong <cyd@stupidchicken.com>
11893
c96bbc66 11894 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11895
cffc6f3b
CY
118962011-03-13 Chong Yidong <cyd@stupidchicken.com>
11897
11898 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11899 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11900 These macros can no longer be used for assignment.
11901
44f230aa
SM
11902 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11903 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11904 (record_buffer_markers, fetch_buffer_markers): New functions for
11905 recording and fetching special buffer markers.
11906 (set_buffer_internal_1, set_buffer_temp): Use them.
11907
11908 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11909
11910 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11911
11912 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11913 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11914
11915 * xdisp.c (hscroll_window_tree):
11916 (reconsider_clip_changes): Use PT instead of BUF_PT.
11917
d251f04b
EZ
119182011-03-13 Eli Zaretskii <eliz@gnu.org>
11919
11920 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11921 $(EMACS_ROOT)/lib/intprops.h.
11922
f0c77cd1
PE
119232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11924
3eca4629
PE
11925 Fix more problems found by GCC 4.5.2's static checks.
11926
7c86ee98
PE
11927 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11928 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11929 (xg_free_frame_widgets): Make it clear that a local variable is
11930 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11931 (gdk_window_get_screen): Make it clear that this macro is needed
11932 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11933 (int_gtk_range_get_value): New function, which avoids a diagnostic
11934 from gcc -Wbad-function-cast.
11935 (xg_set_toolkit_scroll_bar_thumb): Use it.
11936 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11937 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11938 (get_utf8_string, xg_get_file_with_chooser):
11939 Rename locals to avoid shadowing.
11940 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11941
41729b81
PE
11942 * xgselect.c (xg_select): Remove unused var.
11943
f0c77cd1
PE
11944 * image.c (four_corners_best): Mark locals as initialized.
11945 (gif_load): Initialize transparent_p to zero (Bug#8238).
11946 Mark another local as initialized.
ec6cf4c6 11947 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11948
ce0ad53d 11949 * image.c (clear_image_cache): Now static.
d5d5a617 11950 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11951 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11952 (x_edge_detection): Remove unnecessary cast that
11953 gcc -Wbad-function-cast diagnoses.
2037898d 11954 (gif_load): Fix pointer signedness.
6ae141d6
PE
11955 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11956 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11957
33383987 119582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11959
d32df629
PE
11960 Improve quality of tests for time stamp overflow.
11961 For example, without this patch (encode-time 0 0 0 1 1
11962 1152921504606846976) returns the obviously-bogus value (-948597
11963 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11964 reports time overflow. See
11965 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11966 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11967 * editfns.c: Include limits.h and intprops.h.
11968 (TIME_T_MIN, TIME_T_MAX): New macros.
11969 (time_overflow): Move earlier, to before first use.
11970 (hi_time, lo_time): New functions, for an accurate test for
11971 out-of-range times.
11972 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11973 (Fget_internal_run_time): Don't assume time_t fits in int.
11974 (make_time): Use list2 instead of Fcons twice.
11975 (Fdecode_time): More accurate test for out-of-range times.
11976 (check_tm_member): New function.
11977 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11978 (lisp_time_argument): Don't rely on undefined left-shift and
11979 right-shift behavior when checking for time stamp overflow.
8be6f318 11980
fe31d94c
PE
11981 * editfns.c (time_overflow): New function, refactoring common code.
11982 (Fformat_time_string, Fdecode_time, Fencode_time):
11983 (Fcurrent_time_string): Use it.
11984
8be6f318
PE
11985 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11986 * dired.c (make_time): Move to ...
11987 * editfns.c (make_time): ... here.
11988 * systime.h: Note the move.
11989
09d9db2c 119902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11991
126bc0dc
YM
11992 * fringe.c (update_window_fringes): Remove unused variables.
11993
c47cbdfd
YM
11994 * unexmacosx.c (copy_data_segment): Also copy __got section.
11995 (Bug#8223)
11996
7ac80be9
EZ
119972011-03-12 Eli Zaretskii <eliz@gnu.org>
11998
c96bbc66 11999 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12000 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12001 Constify `char *' arguments and their references according to
12002 prototypes in tparam.h.
12003
ecb0f94d 12004 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12005
7ac80be9
EZ
12006 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12007 Adapt all references accordingly.
12008
12009 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12010
ef1fd07e
TT
120112011-03-11 Tom Tromey <tromey@redhat.com>
12012
12013 * buffer.c (syms_of_buffer): Remove obsolete comment.
12014
7ef4b50c
EZ
120152011-03-11 Eli Zaretskii <eliz@gnu.org>
12016
12017 * termhooks.h (encode_terminal_code): Declare prototype.
12018
12019 * msdos.c (encode_terminal_code): Don't declare prototype.
12020
12021 * term.c (encode_terminal_code): Now external again, used by
12022 w32console.c and msdos.c.
12023
44f230aa
SM
12024 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12025 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12026
4b1ec863 120272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12028
1714f52b 12029 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12030
4b1ec863
PE
12031 * fringe.c (update_window_fringes): Mark locals as initialized
12032 (Bug#8227).
12033 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12034
524c7aa6
PE
12035 * alloc.c (mark_fringe_data): Move decl from here ...
12036 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12037 to check its interface.
12038 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12039
a5c0af81 12040 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12041 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12042 (fontset_font): Mark local as initialized.
a9a06e0b 12043 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12044
b4716021
PE
12045 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12046
811e9bac 12047 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12048 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12049 (x_own_selection, Fx_disown_selection_internal): Rename locals
12050 to avoid shadowing.
12051 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12052
7e3ab302
PE
12053 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12054 so that the caller can use some name other than gcpro1.
12055 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12056 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12057 (Fx_backspace_delete_keys_p):
12058 Use them to avoid shadowing, and rename vars to avoid shadowing.
12059 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12060 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12061 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12062 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12063 Remove unused locals.
7e3ab302
PE
12064 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12065 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12066 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12067 macros.
f78faa98 12068
e2b13473
PE
12069 * xterm.h (x_mouse_leave): New decl.
12070
77f23912
PE
12071 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12072 Remove unused functions.
cdf4ba58
PE
12073 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12074 (x_calc_absolute_position): Now static.
7411c686 12075 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12076 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12077 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12078 unless they are used.
38d0b34a
PE
12079 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12080 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12081 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12082 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12083 (x_error_catcher, x_connection_closed, x_error_handler):
12084 (x_error_quitter, xembed_send_message, x_iconify_frame):
12085 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12086 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12087 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12088
44f230aa
SM
12089 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12090 Rename or move locals to avoid shadowing.
6b463e58 12091 (tty_defined_color, merge_face_heights): Now static.
5967d051 12092 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12093 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12094 does not deduce is never used uninitialized.
73719eba
PE
12095 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12096 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12097
426994c3 12098 * terminal.c (store_terminal_param): Now static.
5489860b 12099
032f1620 12100 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12101 (set_frame_menubar): Remove unused local.
d4323972 12102 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12103 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12104 since they might point to immutable storage.
281585b0
PE
12105 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12106 since it's unused otherwise.
032f1620 12107
367c19e5 12108 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12109 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12110 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12111 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12112 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12113 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12114 does not deduce are never used uninitialized.
70739cbe 12115
07b48fa9
PE
12116 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12117
8868a238 12118 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12119 * window.c (window_loop, size_window):
12120 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12121
7e5cf297 12122 * window.c (display_buffer): Now static.
d6550a9f
PE
12123 (size_window): Mark variables that gcc -Wuninitialized
12124 does not deduce are never used uninitialized.
a586633d
PE
12125 * window.h (check_all_windows): New decl, to forestall
12126 gcc -Wmissing-prototypes diagnostic.
5b555da1 12127 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12128
f6095868
PE
12129 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12130 shadowing.
12131 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12132 Include <limits.h>.
12133 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12134 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12135 (load_charset_map): Mark variables that gcc -Wuninitialized
12136 does not deduce are never used uninitialized.
53df7c11 12137 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12138
f38b440c
PE
12139 * coding.c (coding_set_source, coding_set_destination):
12140 Use "else { /* comment */ }" rather than "else /* comment */;"
12141 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12142 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12143 a block, when the outer 'i' will do.
12144 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12145 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12146 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12147 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12148 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12149 Rename locals to avoid shadowing.
12150 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12151 * coding.c (emacs_mule_char, encode_invocation_designation):
12152 Now static, since they're not used elsewhere.
413bb2db 12153 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12154 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12155 (decode_coding_emacs_mule): Mark variables that gcc
12156 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12157 (detect_coding_iso_2022): Initialize a local variable that might
12158 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12159 this initialization is needed. (Bug#8211)
5f58e762
PE
12160 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12161 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12162 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12163 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12164 Remove unused macros.
f38b440c 12165
232b38b9 12166 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12167 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12168 * character.c (string_count_byte8): Likewise.
232b38b9 12169
fb90da1b
PE
12170 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12171 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12172
fb93dbc2
PE
12173 * chartab.c (copy_sub_char_table): Now static, since it's not used
12174 elsewhere.
5c156ace
PE
12175 (sub_char_table_ref_and_range, char_table_ref_and_range):
12176 Rename locals to avoid shadowing.
bbcd0949 12177 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12178
7d3b3862 12179 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12180 (BIDI_BOB): Remove unused macro.
7d3b3862 12181
6be7d3da
PE
12182 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12183 deduce are never used uninitialized.
c2ed9c8b 12184 * term.c (encode_terminal_code): Likewise.
6be7d3da 12185
75f8807f 12186 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12187
50938595
PE
12188 * tparam.h: New file.
12189 * term.c, tparam.h: Include it.
12190 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12191 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12192 Move these decls to tparam.h, and make them agree with what
12193 is actually in tparam.c. The previous trick of using incompatible
12194 decls in different modules does not conform to the C standard.
12195 All callers of tparam changed to use tparam's actual API.
12196 * tparam.c (tparam1, tparam, tgoto):
12197 Use const pointers where appropriate.
12198
fbceeba2
PE
12199 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12200 * cm.h (struct cm): Likewise.
12201 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12202 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12203 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12204 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12205 (turn_on_face, init_tty): Likewise.
12206 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12207
7f3f1250
PE
12208 * term.c (term_mouse_position): Rename local to avoid shadowing.
12209
e6ca6543
PE
12210 * alloc.c (mark_ttys): Move decl from here ...
12211 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12212
c40f8d15
AS
122132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12214
12215 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12216
cfe0661d
JB
122172011-03-09 Juanma Barranquero <lekktu@gmail.com>
12218
12219 * search.c (compile_pattern_1): Remove argument regp, unused since
12220 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12221 (compile_pattern): Don't pass it.
12222
0afb4571
J
122232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12224
12225 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12226 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12227 for ! HAVE_GTK3.
12228 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12229
12230 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12231
12232 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12233 gdk_window_get_screen, gdk_window_get_geometry,
12234 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12235 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12236 (xg_get_pixbuf_from_pixmap): New function.
12237 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12238 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12239 Call xg_get_pixbuf_from_pixmap instead of
12240 gdk_pixbuf_get_from_drawable.
12241 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12242 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12243 (xg_check_special_colors): Use GtkStyleContext and its functions
12244 for HAVE_GTK3.
12245 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12246 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12247 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12248 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12249 Call gtk_widget_get_preferred_size.
0afb4571
J
12250 (xg_frame_resized): gdk_window_get_geometry only takes 5
12251 parameters.
44f230aa
SM
12252 (xg_win_to_widget, xg_event_is_for_menubar):
12253 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12254 (xg_set_widget_bg): New function.
12255 (delete_cb): New function.
895009e1 12256 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12257 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12258 (xg_set_background_color): Call xg_set_widget_bg.
12259 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12260 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12261 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12262 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12263 if ! HAVE_GTK3.
12264 (update_frame_tool_bar): Call gtk_widget_hide.
12265 (xg_initialize): Use GDK_KEY_g.
12266
12267 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12268 if ! HAVE_GTK3
12269 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12270
12271 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12272 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12273 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12274
1c2cc4ef
JB
122752011-03-08 Juanma Barranquero <lekktu@gmail.com>
12276
12277 * w32xfns.c (select_palette): Check success of RealizePalette against
12278 GDI_ERROR, not zero.
12279
33383987 12280See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12281
12282;; Local Variables:
12283;; coding: utf-8
aac0c6e3
MR
12284;; End:
12285
2f097256 12286 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12287
12288 This file is part of GNU Emacs.
12289
12290 GNU Emacs is free software: you can redistribute it and/or modify
12291 it under the terms of the GNU General Public License as published by
12292 the Free Software Foundation, either version 3 of the License, or
12293 (at your option) any later version.
12294
12295 GNU Emacs is distributed in the hope that it will be useful,
12296 but WITHOUT ANY WARRANTY; without even the implied warranty of
12297 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12298 GNU General Public License for more details.
12299
12300 You should have received a copy of the GNU General Public License
12301 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.