* vc-bzr.el (vc-bzr-rename-file): Don't pass ~ to Bzr in filename arg.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c803b2b7
JD
12011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2
678f4426
JD
3 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4 and NS_IMPL_COCOA.
5 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
7
82011-12-18 David Reitter <reitter@cmu.edu>
9
5fecd5fc
JD
10 * nsterm.m (ns_term_init): Subscribe for notifications
11 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
12 to method trackingNotification in EmacsMenu.
13
14 * nsmenu.m (trackingMenu): New variable.
3771cb17 15 (trackingNotification): New method (from Aquamacs).
5fecd5fc 16 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 17 from Aquamacs (Bug#7030).
678f4426
JD
18
192011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 20
c803b2b7
JD
21 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
22 (symbol_to_nsstring): Fix indentation.
23 (ns_symbol_to_pb): New function.
24 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
25 (Fns_rotate_cut_buffers_internal): Removed.
26 (Fns_store_selection_internal): Renamed from
27 Fns_store_cut_buffer_internal.
28 (ns_get_foreign_selection, Fx_own_selection_internal)
29 (Fx_disown_selection_internal, Fx_selection_exists_p)
30 (Fns_get_selection_internal, Fns_store_selection_internal): Use
31 ns_symbol_to_pb and check if return value is nil.
32 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove
33 defsubr Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
34 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
35 renamed to Sns_store_selection_internal.
36 (ns_handle_selection_request): Move code to Fx_own_selection_internal
37 and remove this function.
38 (ns_handle_selection_clear): Remove, never used.
39 (Fx_own_selection_internal): Move code from ns_handle_selection_request
40 here.
41
e1b01a3a
KB
422011-12-17 Ken Brown <kbrown@cornell.edu>
43
44 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
45 GID is unknown (Bug#10257).
46
2adb6e85
PE
472011-12-17 Paul Eggert <eggert@cs.ucla.edu>
48
49 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
50 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
51 which caused a build failure on GNU/Linux IA-64. This problem was
52 introduced by my 2011-10-07 patch.
53
d1d7b339
JL
542011-12-15 Juri Linkov <juri@jurta.org>
55
56 * image.c (imagemagick_error): New function. (Bug#10112)
57 (imagemagick_load_image): Comment out `MagickSetResolution' call.
58 Use `imagemagick_error' where ImageMagick functions return
59 `MagickFalse'.
60 (Fimagemagick_types): Add `Fnreverse' to return the list in the
61 proper order.
62
100d5755
KH
632011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
64
65 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
66 fill background (Bug#8992).
67
454592a6
MR
682011-12-13 Martin Rudalics <rudalics@gmx.at>
69
70 * window.c (Vwindow_combination_resize)
71 (Vwindow_combination_limit): Use t instead of non-nil in
72 doc-strings.
61d4b438
MR
73 (Vrecenter_redisplay): Add first sentence of doc-string on
74 separate line.
53524d93 75 (Frecenter): Fix doc-string typo.
454592a6 76
3633e3aa
KH
772011-12-11 Kenichi Handa <handa@m17n.org>
78
79 * coding.c (Funencodable_char_position): Pay attention to the
80 buffer text relocation (Bug#9389).
81
7b9d523a
JD
822011-12-10 Jan Djärv <jan.h.d@swipnet.se>
83
84 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
85 gtk_init (Bug#10100).
86
b73189c6
EZ
872011-12-10 Eli Zaretskii <eliz@gnu.org>
88
89 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
90 IT->string is nil. (Bug#10263)
91
f7dfe5d6
JD
922011-12-10 Jan Djärv <jan.h.d@swipnet.se>
93
83faebb4
JD
94 * nsterm.h (x_free_frame_resources): Declare.
95
f7dfe5d6
JD
96 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
97 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
98
99 * nsterm.h (ns_get_defaults_value): Declare.
100
101 * nsterm.m (ns_default): Call ns_get_defaults_value.
102
7cd4e72c
EZ
1032011-12-09 Eli Zaretskii <eliz@gnu.org>
104
105 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
106 (Bug#10170)
107
b34d7317
YM
1082011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
109
110 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
111 that where the value of an _OBJC_* symbol points to is in the .bss
112 section (Bug#10240).
113
76470ad1
KH
1142011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
115
116 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 117 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 118
745fff94
KH
1192011-12-08 Kenichi Handa <handa@m17n.org>
120
121 * ftfont.c (get_adstyle_property): Fix previous change
122 (Bug#10233).
123
6e44397c
JB
1242011-12-07 Juanma Barranquero <lekktu@gmail.com>
125
126 * w32.c (init_environment): If no_site_lisp, remove site-lisp
127 dirs from the default value of EMACSLOADPATH (bug#10208).
128
7efa6272
GM
1292011-12-07 Glenn Morris <rgm@gnu.org>
130
131 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
132 installation and source directories as well. (Bug#10208)
133
f6fc4d87
CY
1342011-12-06 Chong Yidong <cyd@gnu.org>
135
136 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
137
2bf26180
GM
1382011-12-06 Glenn Morris <rgm@gnu.org>
139
140 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
141 as an error, not just -1. (Bug#10217)
142
3a6ad4f0
CY
1432011-12-05 Chong Yidong <cyd@gnu.org>
144
145 * keyboard.c (process_special_events): New function.
146 (swallow_events, Finput_pending_p): Use it (Bug#10195).
147
75a3b399
PE
1482011-12-05 Paul Eggert <eggert@cs.ucla.edu>
149
150 * coding.c (encode_designation_at_bol): Don't use uninitialized
151 local variable (Bug#9318).
152
c3c9e25e
KH
1532011-12-05 Kenichi Handa <handa@m17n.org>
154
155 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
156 return Qnil (Bug#8046, Bug#10193).
157
5eb05ea3
KH
1582011-12-05 Kenichi Handa <handa@m17n.org>
159
160 * coding.c (encode_designation_at_bol): New args charbuf_end and
161 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
162 (coding_set_source): Return how many bytes coding->source was
163 relocated.
164 (coding_set_destination): Return how many bytes
165 coding->destination was relocated.
166 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
167 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
168
1692011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
170
171 * coding.c (CODING_CHAR_CHARSET_P): New macro.
172 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
173 macro (Bug#9318).
174
1752011-12-05 Andreas Schwab <schwab@linux-m68k.org>
176
177 The following changes are to fix Bug#9318.
178
a79703f5 179 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
180 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
181 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 182 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 183
7dbda6df
JB
1842011-12-05 Juanma Barranquero <lekktu@gmail.com>
185
186 * lisp.h (process_quit_flag): Fix external declaration.
187
6d5eb5b0
SM
1882011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
189
190 Don't macro-inline non-performance-critical code.
191 * eval.c (process_quit_flag): New function.
192 * lisp.h (QUIT): Use it.
193
a0c3fad0
JD
1942011-12-04 Jan Djärv <jan.h.d@swipnet.se>
195
196 * nsfns.m (get_geometry_from_preferences): New function.
197 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
198
6c07aac2
AS
1992011-12-04 Andreas Schwab <schwab@linux-m68k.org>
200
201 * emacs.c (Qkill_emacs): Define.
202 (syms_of_emacs): Initialize it.
203 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
204 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
205 (quit_throw_to_read_char): Add parameter `from_signal'.
206 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
207 * lisp.h (QUIT): Call Fkill_emacs if requested.
208
c052ead4
JD
2092011-12-03 Jan Djärv <jan.h.d@swipnet.se>
210
211 * widget.c (update_wm_hints): Return if wmshell is null.
212 (widget_update_wm_size_hints): New function.
213
214 * widget.h (widget_update_wm_size_hints): Declare.
215
216 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
217 widget_update_wm_size_hints (Bug#10104).
218
9e49252b
EZ
2192011-12-03 Eli Zaretskii <eliz@gnu.org>
220
221 * xdisp.c (handle_invisible_prop): If the invisible text ends just
222 before a newline, prepare the bidi iterator for consuming the
223 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 224 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 225
02b16839
JL
2262011-12-02 Juri Linkov <juri@jurta.org>
227
228 * search.c (Fword_search_regexp): New Lisp function created from
229 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
230 (Fword_search_backward, Fword_search_forward)
231 (Fword_search_backward_lax, Fword_search_forward_lax):
232 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
233 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
234
0068070e
SM
2352011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
236
237 * fileio.c (Finsert_file_contents): Move after-change-function call
238 to before the "handled:" label, since all "goto handled" appear in
239 cases where the *-change-functions have already been properly called
240 (bug#10117).
241
3360a3fc
AS
2422011-12-01 Andreas Schwab <schwab@linux-m68k.org>
243
244 * keyboard.c (interrupt_signal): Don't call kill-emacs when
245 waiting for input. (Bug#10169)
246
73d6c093
EZ
2472011-11-30 Eli Zaretskii <eliz@gnu.org>
248
249 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
250 verifies glyph row's hash code--we have just reallocated the
251 glyphs, so their contents can be complete garbage. (Bug#10164)
252
febe6bea
JB
2532011-11-30 Juanma Barranquero <lekktu@gmail.com>
254
255 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
256
801a4313
EZ
2572011-11-30 Eli Zaretskii <eliz@gnu.org>
258
259 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
260 attributes are tested _before_ calling verify_row_hash, to protect
261 against GCC re-ordering of the tests. (Bug#10164)
262
2b56b87e
JD
2632011-11-29 Jan Djärv <jan.h.d@swipnet.se>
264
265 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
266
267 * xterm.c (handle_one_xevent): Only set async_visible and friends
268 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 269 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
270 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
271
dbf31225
PE
2722011-11-28 Paul Eggert <eggert@cs.ucla.edu>
273
274 Remove GCPRO-related macros that exist only to avoid shadowing locals.
275 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
276 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
277 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
278 All uses changed to use GCPRO1 etc.
279 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
280 Revert to old implementation (i.e., before 2011-03-11).
281
1305621b
YM
2822011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
283
284 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
285 of scroll runs so as to avoid assigning disabled bogus rows and
286 unnecessary graphics copy operations.
287
8c9afb46
EZ
2882011-11-27 Eli Zaretskii <eliz@gnu.org>
289
290 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
291 (snprintf) [_MSC_VER]: Redirect to _snprintf.
292 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
293 (malloc, free, realloc, calloc): Redirect to e_* only when
294 compiling Emacs.
295
296 * lisp.h (GCTYPEBITS): Move before first use.
297 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
298 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
299 this macro definition.
300
301 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
302 _MSC_VER.
303
54e9e3bf
JD
3042011-11-27 Jan Djärv <jan.h.d@swipnet.se>
305
6d5eb5b0
SM
306 * gtkutil.c (xg_create_frame_widgets):
307 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
308 present with Gtk+ 2.0.
309
83aca1cb
PE
3102011-11-26 Paul Eggert <eggert@cs.ucla.edu>
311
312 * fileio.c (Finsert_file_contents): Undo previous change; see
313 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
314
5b76caa4
PE
3152011-11-26 Paul Eggert <eggert@cs.ucla.edu>
316
317 Rename locals to avoid shadowing.
318 * fileio.c (Finsert_file_contents):
319 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
320 * process.c (wait_reading_process_output):
321 Rename inner 'proc' to 'p' to avoid shadowing.
322 Indent for consistency with usual Emacs style.
323
8c535114
EZ
3242011-11-25 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (redisplay_window): If cursor row is not fully visible
327 after recentering, and scroll-conservatively is set to a large
328 number, scroll window by a few more lines to make the cursor fully
329 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
330 (start_display): Don't move to the next line if the display should
331 start at a newline that is part of a display vector or an overlay
332 string. (Bug#10119)
8c535114 333
fa4fdb5c
JL
3342011-11-24 Juri Linkov <juri@jurta.org>
335
336 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
337 after the `MagickPingImage' call. (Bug#10112)
338
90ec88df
CY
3392011-11-23 Chong Yidong <cyd@gnu.org>
340
341 * window.c (Fcoordinates_in_window_p): Accept only live windows.
342
56e2e794
MR
3432011-11-23 Martin Rudalics <rudalics@gmx.at>
344
345 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
346 making another buffer current. (Bug#10114)
347
b6e64c41
GM
3482011-11-23 Glenn Morris <rgm@gnu.org>
349
350 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
351
6b21de18
CY
3522011-11-23 Chong Yidong <cyd@gnu.org>
353
354 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
355 using it (Bug#5984).
356
b12cd789
EZ
3572011-11-22 Eli Zaretskii <eliz@gnu.org>
358
359 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
360 and header-lines, as they don't have one computed for them.
361 (Bug#10098)
362
363 * .gdbinit (prow): Make displayed values more self-explaining.
364 Add row's hash code.
365
261b6fd4
LMI
3662011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
367
368 * process.c (wait_reading_process_output): Fix asynchrounous
369 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 370 (wait_reading_process_output): Add comment and URL.
261b6fd4 371
e7cfd277
JD
3722011-11-21 Jan Djärv <jan.h.d@swipnet.se>
373
374 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
375
a9b9b7f5
CY
3762011-11-21 Chong Yidong <cyd@gnu.org>
377
378 * window.c (Fnext_window, Fprevious_window): Doc fix.
379
b0d15b4f
SM
3802011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
383
fe7a3057
JB
3842011-11-20 Juanma Barranquero <lekktu@gmail.com>
385
386 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
387
d2999b1a
MR
3882011-11-20 Martin Rudalics <rudalics@gmx.at>
389
390 * window.c (Fset_window_combination_limit): Rename argument
391 STATUS to LIMIT.
392 (Vwindow_combination_limit): Remove "status" from doc-string.
393
d5ff9cd0
AS
3942011-11-20 Andreas Schwab <schwab@linux-m68k.org>
395
396 * m/ibms390.h: Remove.
397 * m/ibms390x.h: Don't include "ibms390.h".
398
a5bb9bd3
SM
3992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
400
401 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
402 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
403
cd1181db
JB
4042011-11-20 Juanma Barranquero <lekktu@gmail.com>
405
406 * casetab.c (Fset_case_table):
407 * charset.c (Fcharset_after): Fix typos.
408
615a3b8d 4092011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 410
17e845af
PE
411 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
412 Otherwise, valgrind does not work on some platforms.
413 Problem reported by Andreas Schwab in
6a0bf43d
PE
414 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
415 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
416 is set, removing the need for VIRT_ADDRESS_VARIES.
417 (PURE_P): Use a more-efficient implementation that needs just one
418 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
419 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
420 to 4 (xorl, subq, cmpq, setbe).
421 * alloc.c (pure): Always extern now, since that's the
422 VIRT_ADDR_VARIES behavior.
423 (PURE_POINTER_P): Use a single comparison, not two, for
424 consistency with the new puresize.h.
425 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
426 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
427 Remove VIRT_ADDR_VARIES no longer needed.
428
f8fe6f96
EZ
4292011-11-19 Eli Zaretskii <eliz@gnu.org>
430
431 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
432 (erase_phys_cursor, update_window_cursor, show_mouse_face)
433 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
434 behave as if the cursor position were at the window margin.
435
436 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
437 and the cursor position is out of bounds, behave as if the cursor
438 position were at the window margin. (Bug#10075)
439
df05a53c
CY
4402011-11-18 Chong Yidong <cyd@gnu.org>
441
442 * window.c (Fwindow_combination_limit): Make first argument
443 non-optional, since it is meaningless for live windows like the
444 selected window.
445
2071918e
DA
4462011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
447
448 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
449
b50a28de
SM
4502011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
451
452 * intervals.c: Fix grafting over the whole buffer (bug#10071).
453 (graft_intervals_into_buffer): Simplify.
454
015137db
EZ
4552011-11-18 Eli Zaretskii <eliz@gnu.org>
456
457 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
458 hash values of the two rows.
459 (copy_row_except_pointers): Preserve the used[] arrays and the
460 hash values of the two rows. (Bug#10035)
68c95424 461 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
462
463 * xdisp.c (row_hash): New function, body extracted from
464 compute_line_metrics.
465 (compute_line_metrics): Call row_hash, instead of computing the
466 hash code inline.
467
468 * dispnew.c (verify_row_hash): Call row_hash for computing the
469 hash code of a row, instead of duplicating code from xdisp.c.
470
471 * dispextern.h (row_hash): Add prototype.
472
a2addb04
TH
4732011-11-18 Tassilo Horn <tassilo@member.fsf.org>
474
475 * frame.c (delete_frame): Don't delete the terminal when the last
476 X frame is closed if emacs is built with GTK toolkit.
477
df85d315
JB
4782011-11-17 Juanma Barranquero <lekktu@gmail.com>
479
480 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
481
a0c2d0ae
MR
4822011-11-17 Martin Rudalics <rudalics@gmx.at>
483
484 * window.c (Vwindow_splits): Rename to
485 Vwindow_combination_resize. Suggested by Juri Linkov.
486 (Fsplit_window_internal): Use Vwindow_combination_resize instead
487 of Vwindow_splits.
488
58179cce
JB
4892011-11-16 Juanma Barranquero <lekktu@gmail.com>
490
7877f373
JB
491 * nsfns.m (Fns_font_name):
492 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 493
b6f67890
MR
4942011-11-16 Martin Rudalics <rudalics@gmx.at>
495
496 * window.h (window): Rename slot "nest" to "combination_limit".
497 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
498 (Fset_window_nest): Rename to Fset_window_combination_limit.
499 (Vwindow_nest): Rename to Vwindow_combination_limit.
500 (recombine_windows, make_parent_window, make_window)
501 (Fsplit_window_internal, saved_window)
502 (Fset_window_configuration, save_window_save): Rename all
503 occurrences of window_nest to window_combination_limit.
504
c7015153
JB
5052011-11-15 Juanma Barranquero <lekktu@gmail.com>
506
507 * image.c (imagemagick_load_image): Fix typo.
508
322ad6ec
EZ
5092011-11-14 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (display_line): Move the call to
512 highlight_trailing_whitespace before the call to
513 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
514 faces of all the glyphs to compute ROW's hash value.
515 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 516
f067b8ec
JB
5172011-11-14 Juanma Barranquero <lekktu@gmail.com>
518
519 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
520 just return (bug#10044).
521
1e5b2111
EZ
5222011-11-12 Eli Zaretskii <eliz@gnu.org>
523
7ef3cbd5
EZ
524 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
525 with user-defined heap size. Bump the default size of the temacs
526 heap to 27MB, to avoid memory warning when running temacs.
527 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
528
1e5b2111
EZ
529 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
530 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
531 (verify_row_hash) [XASSERTS]: New function.
532 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
533 that the hash value of glyph rows is correct.
1e5b2111 534
89d61221
MR
5352011-11-12 Martin Rudalics <rudalics@gmx.at>
536
537 * window.h (window): Remove splits slot.
538 * window.c (Fwindow_splits, Fset_window_splits): Remove.
539 (Fdelete_other_windows_internal, make_parent_window)
540 (make_window, Fsplit_window_internal, Fdelete_window_internal)
541 (Fset_window_configuration, save_window_save): Don't deal with
542 split status of windows.
543 (saved_window): Remove splits slot.
544 (Vwindow_splits): Rewrite doc-string.
545
97f18cc8
JD
5462011-11-11 Jan Djärv <jan.h.d@swipnet.se>
547
548 * xfns.c (unwind_create_frame):
549 * nsfns.m (unwind_create_frame):
550 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
551 Vframe_list (Bug#9999).
552
22a648b4
DA
5532011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
554
0b381c7e 555 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 556
659afede
KH
5572011-11-11 Kenichi Handa <handa@m17n.org>
558
559 * callproc.c (Fcall_process): Set the member dst_multibyte of
560 process_coding.
561
9ac0394b
KH
5622011-11-11 Johan Bockgård <bojohan@gnu.org>
563
564 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
565 avoid a crash (bug#9496).
566
2fbdc249
CY
5672011-11-09 Chong Yidong <cyd@gnu.org>
568
569 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
570 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
571
ac6b1f81
PE
5722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
573
574 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
575
09db192c
PE
5762011-11-08 Paul Eggert <eggert@cs.ucla.edu>
577
578 Avoid some portability problems by eschewing 'extern inline' functions.
579 The trivial performance wins aren't worth the portability hassles; see
580 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
581 et seq.
582 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
583 (window_box_width, window_box_left, window_box_left_offset)
584 (window_box_right, window_box_right_offset): Undo previous change,
585 by removing the "extern"s.
586 * intervals.c (adjust_intervals_for_insertion)
587 (adjust_intervals_for_deletion): Undo previous change,
588 making these static again.
589 (offset_intervals, temp_set_point_both, temp_set_point)
590 (copy_intervals_to_string): No longer inline.
591 * xdisp.c (window_text_bottom_y, window_box_width)
592 (window_box_height, window_box_left_offset)
593 (window_box_right_offset, window_box_left, window_box_right)
594 (window_box): No longer inline.
595
105216ed
CY
5962011-11-08 Chong Yidong <cyd@gnu.org>
597
598 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
599 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
600 Signal an error if not a live window.
105216ed
CY
601 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
602 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
603
ae9e237f
JB
6042011-11-07 Juanma Barranquero <lekktu@gmail.com>
605
606 * lisp.h (syms_of_abbrev): Remove declaration.
607 Reported by CHENG Gao <chenggao@royau.me>.
608
c7aa8333
EZ
6092011-11-07 Eli Zaretskii <eliz@gnu.org>
610
611 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
612 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
613 of temacs in GUI mode.
614
be7f5545
MR
6152011-11-07 Martin Rudalics <rudalics@gmx.at>
616
617 * window.h: Declare delete_all_child_windows instead of
618 delete_all_subwindows.
619 * window.c (Fwindow_nest, Fset_window_nest)
620 (Fset_window_new_total, Fset_window_new_normal)
621 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
622 (delete_all_subwindows): Rename to delete_all_child_windows.
623 (Fdelete_other_windows_internal, Fset_window_configuration):
624 Call delete_all_child_windows instead of delete_all_subwindows.
625 * frame.c (delete_frame): Call delete_all_child_windows instead
626 of delete_all_subwindows.
627
ca78dc43
PE
6282011-11-07 Paul Eggert <eggert@cs.ucla.edu>
629
630 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
631 This is also needed for porting to any host where GC_MARK_STACK is
632 not GC_MAKE_GCPROS_NOOPS.
633 (which_symbols): Use it.
634
a0241d01
KH
6352011-11-07 Kenichi Handa <handa@m17n.org>
636
637 * coding.c (coding_set_destination): Check coding->src_pos only
638 when coding->src_object is a buffer (bug#9910).
639
640 * process.c (send_process): Set the member src_multibyte of coding
641 to 0 (bug#9911) when sending a unibyte text.
642
643 * callproc.c (Fcall_process): Set the member src_multibyte of
644 process_coding to 0 (bug#9912).
645
a64bfdfa 6462011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
647
648 * xmenu.c (cleanup_widget_value_tree): New function.
649 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
650 calling free_menubar_widget_value_tree directly (Bug#9830).
651
cb41b32a
PE
6522011-11-06 Paul Eggert <eggert@cs.ucla.edu>
653
654 Fix some portability problems with 'inline'.
655 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
656 (window_box_width, window_box_left, window_box_left_offset)
657 (window_box_right, window_box_right_offset): Declare extern.
658 Otherwise, these inline functions do not conform to C99 and
659 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
660 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
661 * intervals.c (adjust_intervals_for_insertion)
662 (adjust_intervals_for_deletion): Now extern, because otherwise the
663 extern inline functions 'offset_intervals' couldn't refer to it.
664 (static_offset_intervals): Remove.
665 (offset_intervals): Rewrite using the old contents of
666 static_offset_intervals. The old version didn't conform to C99
667 because an extern inline function contained a reference to an
668 identifier with static linkage.
669
b7041366
AS
6702011-11-06 Andreas Schwab <schwab@linux-m68k.org>
671
672 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
673 GC.
674
88a37c4d
EZ
6752011-11-06 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (init_iterator, reseat_to_string): Don't set the
678 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
679 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
680 return Qleft_to_right.
681
49745b39
CY
6822011-11-06 Chong Yidong <cyd@gnu.org>
683
684 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
685 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
686 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
687 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
688 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
689 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
690 (Fwindow_vscroll): Doc fix.
691 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
692 argument, since it makes no sense to pass a live window and for
693 consistency with window-child.
694
1f05cd82
CS
6952011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
696
697 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
698 support MSVC.
699
22610910
JR
7002011-11-05 Jason Rumney <jasonr@gnu.org>
701
702 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
703 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
704 fonts (Bug#6029).
705 (add_font_entity_to_list): Fix logic errors in mixed boolean and
706 bitwise arithmetic preventing use of unicode-sip and non-truetype
707 opentype fonts.
708
a06776b2
EZ
7092011-11-05 Eli Zaretskii <eliz@gnu.org>
710
3ad924ba
EZ
711 * s/ms-w32.h (fstat, stat, utime): Move redirections to
712 "emacs"-only part.
713
a06776b2
EZ
714 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
715 initialization code to keep similarity to xfns.c after changes
716 from 2011-11-05.
717
c9e7db78
JD
7182011-11-05 Jan Djärv <jan.h.d@swipnet.se>
719
a97f8f3f
JD
720 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
721 (unwind_create_frame): New function (Bug#9943).
722 (Fx_create_frame): Restructure code to be more similar to the one in
723 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
724 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
725 Move terminal->reference_count++ just before making the frame official
726 (Bug#9943).
727
728 * nsterm.m (x_free_frame_resources): New function.
729 (x_destroy_window): Move code to x_free_frame_resources.
730
c9e7db78 731 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
732 (Fx_create_frame, x_create_tip_frame):
733 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
734 official. Move initialization of image_cache_refcount and
735 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
736
a6fc3b5c
EZ
7372011-11-05 Eli Zaretskii <eliz@gnu.org>
738
739 Support MSVC build with newer versions of Visual Studio.
740 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
741 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
742 nt/gmake.defs.
743
744 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
745 which are not supported by MSVC.
746 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
747 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
748 bitfields.
749 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
750 types in bitfields.
751 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
752
753 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
754
58179cce 7552011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
756
757 Support MSVC build with newer versions of Visual Studio.
758 * w32.c: Don't include w32api.h for MSVC.
759 (init_environment) [_MSC_VER]: Call sys_access, not _access.
760
761 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
762 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
763 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
764 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
765 e_* cousins.
766 (alloca) [_MSC_VER]: Define to _alloca.
767
768 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
769
770 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
771
a58c13ed
EZ
7722011-11-04 Eli Zaretskii <eliz@gnu.org>
773
774 * xdisp.c (note_mouse_highlight): If either of
775 previous/next-single-property-change returns nil, treat that as
776 the beginning or the end of the buffer. (Bug#9955)
777
fe0b6370
JD
7782011-11-04 Jan Djärv <jan.h.d@swipnet.se>
779
a58c13ed 780 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
781 label is not null (Bug#9951).
782 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
783 may be NULL.
784
89bd5ee1
EZ
7852011-11-04 Eli Zaretskii <eliz@gnu.org>
786
787 * window.c (Fwindow_body_size): Mention in the doc string that the
788 return value is in frame's canonical units. (Bug#9949)
789
84c3edb9
EZ
7902011-11-03 Eli Zaretskii <eliz@gnu.org>
791
4e2fb5c7
EZ
792 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
793
84c3edb9 794 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 795 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 796 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 797
bc17a887
EZ
7982011-11-01 Eli Zaretskii <eliz@gnu.org>
799
800 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
801 Don't stop backward scan on the continuation glyph, even though
802 its CHARPOS is positive.
6d5eb5b0
SM
803 (mouse_face_from_buffer_pos, note_mouse_highlight):
804 Rename cover_string to disp_string.
bc17a887 805
4ee88440
MR
8062011-11-01 Martin Rudalics <rudalics@gmx.at>
807
808 * window.c (temp_output_buffer_show): Don't use
809 Vtemp_buffer_show_specifiers.
810 (Vtemp_buffer_show_specifiers): Remove unused variable.
811
c2ff3c02
EZ
8122011-10-30 Eli Zaretskii <eliz@gnu.org>
813
814 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
815 past the beginning of the current glyph matrix.
816
58179cce 8172011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
818
819 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
820 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
821 HAVE_GTK3 (Bug#9869).
b77a6a7f 822
3b574623
JD
823 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
824 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
825
b77a6a7f
JD
826 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
827
828 * xterm.c: Declare x_handle_net_wm_state to return int.
829 (handle_one_xevent): Check if we are iconified but don't have
830 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
831 (get_current_wm_state): Return non-zero if not hidden,
832 check for _NET_WM_STATE_HIDDEN (Bug#9893).
833 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
834 (x_handle_net_wm_state): Return what get_current_wm_state returns.
835 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
836
196e41e4
PE
8372011-10-29 Paul Eggert <eggert@cs.ucla.edu>
838
839 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
840 so that this new function doesn't get optimized away by a
841 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
842
021f2e1a
AS
8432011-10-29 Andreas Schwab <schwab@linux-m68k.org>
844
845 * frame.h (MOUSE_HL_INFO): Remove excess parens.
846
8b058d44
EZ
8472011-10-29 Eli Zaretskii <eliz@gnu.org>
848
849 Fix the `xbytecode' command.
850 * .gdbinit (xprintbytestr): New command.
b50a28de 851 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
852 (xbytecode): Print the byte-code string as well.
853
4452fb80
EZ
8542011-10-29 Kim Storm <storm@cua.dk>
855
8b058d44
EZ
856 * alloc.c (which_symbols): New function.
857
21b72067
AS
8582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
859
860 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
861 line. (Bug#9903)
862
83ed7b5c
GM
8632011-10-29 Glenn Morris <rgm@gnu.org>
864
865 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
866 Not clear what it was for, and it causes various bugs. (Bug#9839)
867
5a7a728b
EZ
8682011-10-28 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
871 possible random value that matches one of those tested as
872 condition to clear the mouse face.
873
d3d0842f
CY
8742011-10-28 Chong Yidong <cyd@gnu.org>
875
876 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
877
31b39d13
DN
8782011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
879
880 * window.c (make_window): Initialize phys_cursor_on_p.
881
9aba6043
SM
8822011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
883
884 * lisp.h (struct Lisp_Symbol): Update comments.
885
c20992f4
JB
8862011-10-28 Juanma Barranquero <lekktu@gmail.com>
887
888 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
889
db4f02f2
EZ
8902011-10-28 Eli Zaretskii <eliz@gnu.org>
891
892 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
893 <oslsachem@gmail.com> for helping to debug this.
894
895 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
896 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
897 (g_b_init_get_glyph_outline_w): New static variables.
898 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
899 (GetGlyphOutlineW_Proc): New typedefs.
900 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
901 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
902 New functions.
903 (w32font_open_internal, compute_metrics):
904 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
905 instead of calling the "wide" APIs directly.
906
907 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
908
909 * w32.h (syms_of_w32font): Add prototype.
910
87e68db4
JB
9112011-10-27 Juanma Barranquero <lekktu@gmail.com>
912
913 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
914 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
915 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
916 (Fmove_to_window_line): Doc fix.
917
435c1d67
CY
9182011-10-27 Chong Yidong <cyd@gnu.org>
919
920 * process.c (make_process): Set gnutls_state to NULL.
921
922 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
923 non-NULL, regardless of GNUTLS_INITSTAGE.
924 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
925 an error. Set process slots as soon as we allocate them.
926
927 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
928
9c6c6f49
CY
9292011-10-27 Chong Yidong <cyd@gnu.org>
930
9aba6043
SM
931 * gnutls.c (emacs_gnutls_deinit): New function.
932 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
933 (Fgnutls_deinit, Fgnutls_boot): Use it.
934
935 * process.c (make_process): Initialize GnuTLS credentials to NULL.
936 (deactivate_process): Call emacs_gnutls_deinit.
937
657d08d3
JB
9382011-10-27 Juanma Barranquero <lekktu@gmail.com>
939
940 * image.c (x_create_x_image_and_pixmap):
941 * w32.c (sys_rename, w32_delayed_load):
942 * w32font.c (fill_in_logfont):
943 * w32reg.c (x_get_string_resource): Silence compiler warnings.
944
5430d399
JB
9452011-10-26 Juanma Barranquero <lekktu@gmail.com>
946
947 * w32fns.c (w32_default_color_map): New function,
948 extracted from Fw32_default_color_map.
a7ef684b 949 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 950
fe0055fa
PE
9512011-10-25 Paul Eggert <eggert@cs.ucla.edu>
952
953 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
954
e6346438
SM
9552011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
956
957 * keyboard.c (test_undefined): New function (bug#9751).
958 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
959
e112cc37
ET
9602011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
961
962 * sysdep.c (init_sys_modes): Fix the check for the controlling
963 terminal (Bug#6649).
964
7b5d6677
EZ
9652011-10-20 Eli Zaretskii <eliz@gnu.org>
966
967 * dispextern.h (struct bidi_it): New member next_en_type.
968
969 * bidi.c (bidi_line_init): Initialize the next_en_type member.
970 (bidi_resolve_explicit_1): When next_en_pos is valid for the
971 current character, check also for next_en_type being WEAK_EN.
972 (bidi_resolve_weak): Don't enter the expensive loop if the current
973 position is before next_en_pos. Record the bidi type of the first
974 non-ET, non-BN character we find, in addition to its position.
975 (bidi_level_of_next_char): Invalidate next_en_type when
976 next_en_pos is over-stepped.
977
7da0b018
PE
9782011-10-20 Paul Eggert <eggert@cs.ucla.edu>
979
980 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
981 * editfns.c: Rewrite current-time-zone so that it invokes
982 the equivalent of (format-time-string "%Z") to get the time zone name.
983 This fixes a bug when the time zone name contains characters that
984 need converting from the system time locale to Emacs internal format.
985 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
986 that patch fixed format-time-string to do the conversion, but
987 I forgot to fix current-time-zone.
988 (format_time_string): New function, containing most of
989 what Fformat_time_string used to contain.
990 (Fformat_time_string): Rewrite in terms of format_time_string.
991 This doesn't change this function's behavior.
992 (current-time-zone): Rewrite to use format_time_string.
993 This fixes the bug reported by Michael Schierl in
994 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
995 Jason Rumney's 2007-06-07 change worked around this bug, but
996 didn't fix it.
997 * systime.h (tzname, timezone): Remove no-longer-used declarations.
998
8547b010
EZ
9992011-10-19 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (start_display): If the character at POS is displayed
1002 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1003 (try_window_reusing_current_matrix): If a line ends in a display
1004 vector or the next line starts in a display vector, continue
1005 redrawing the window even though the character position of
1006 start_row was reached.
8547b010
EZ
1007 (Bug#9771, part 2)
1008
4e948d15
CY
10092011-10-18 Chong Yidong <cyd@gnu.org>
1010
1011 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1012 with nobreak-char-display too.
1013
4787455f
EZ
10142011-10-18 Eli Zaretskii <eliz@gnu.org>
1015
1016 Fix part 3 of bug#9771.
1017 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1018 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1019 non-neutral characters if the current character is a paragraph
1020 separator (a.k.a. Newline). This avoids running the same
1021 expensive loop twice, once when we consume the preceding newline
1022 and the other time when the line actually needs to be displayed.
1023 Avoid the loop when we see neutrals on the base embedding level
1024 following a character whose directionality is the same as the
1025 paragraph's. This avoids running the expensive loop when a line
1026 ends in a long sequence of neutrals, like control characters.
1027 Add assertion against STRONG_AL type. Slightly rearrange code
1028 that determines the type of a neutral given the first non-neutral
1029 that follows it.
1030 (bidi_level_of_next_char): Set next_en_pos to zero when
1031 invalidating its info.
1032
2c91f553
EZ
10332011-10-17 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (push_display_prop): Determine whether to record string
1036 or buffer position by IT->string, not by IT->method. Allow
1037 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1038 (move_it_vertically_backward): Don't look for character position
1039 immediately after the newline when in a continuation line.
1040 (Bug#9771, part 1)
2c91f553 1041
c7b08b0d
MR
10422011-10-15 Martin Rudalics <rudalics@gmx.at>
1043
1044 * window.c (coordinates_in_window): Rewrite and delabelize
1045 vertical border check. (Bug#5357) (Bug#9618)
1046
6b02f655
SM
10472011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1050 errors in XSetWindowBorder (bug#9310).
1051
81d40c92
DA
10522011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1055 avoid crash when xmalloc overrun checking is enabled.
1056
d4172c3b
EZ
10572011-10-13 Eli Zaretskii <eliz@gnu.org>
1058
1059 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1060 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1061 cursor motion with <left> and <right> arrow keys.
1062
1063 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1064 some callers set that themselves.
1065
b00eea75
EZ
10662011-10-12 Eli Zaretskii <eliz@gnu.org>
1067
1068 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1069 display string and the previous row comes from the same string and
1070 is empty. (Bug#9739) (Bug#9738)
1071
8fe012c4
SM
10722011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1073
1074 * doc.c (get_doc_string): Encode file name (bug#9735).
1075
0074aef2
EZ
10762011-10-12 Eli Zaretskii <eliz@gnu.org>
1077
79beb178
EZ
1078 * bidi.c (bidi_level_of_next_char):
1079 * xdisp.c (get_visually_first_element): Remove old incorrect
1080 comments regarding the Unicode Line Separator character.
1081
0074aef2
EZ
1082 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1083
6e4b3fbe
DA
10842011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1085
1086 * alloc.c (Fgc_status): Do not access beyond zombies array
1087 boundary if nzombies > MAX_ZOMBIES.
1088 * alloc.c (dump_zombies): Add missing format specifier.
1089
0324f3af
PE
10902011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1091
b5525cac
PE
1092 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1093 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1094
0324f3af
PE
1095 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1096 Some packages use them to denote characters with modifiers.
1097
e9b5f888
AS
10982011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1099
1100 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1101 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1102 matching a pp-number. Rename parameter var to var1.
1103
127827c0
SM
11042011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1105
1106 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1107
c8fd3bd0
GM
11082011-10-08 Glenn Morris <rgm@gnu.org>
1109
1110 * callint.c (Fcall_interactively): Give a more explicit error for the
1111 'c' case with a non-character input. (Bug#8479)
1112
352ec8ff
EZ
11132011-10-08 Eli Zaretskii <eliz@gnu.org>
1114
03669ccb
EZ
1115 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1116 lines.
7061c986
EZ
1117 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1118 lines that are hscrolled on the left.
03669ccb 1119
352ec8ff
EZ
1120 * dispnew.c (buffer_posn_from_coords): Account for a possible
1121 presence of header-line. (Bug#4426)
1122
a66cfb1c
SM
11232011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1124
6b02f655
SM
1125 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1126 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1127
7c5ee88e
PE
11282011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1131 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1132 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1133 this makes Emacs dump core during garbage collection on rare
1134 occasions. sizeof is obviously inferior to offsetof here, so
1135 stick with offsetof.
1136 (GC_POINTER_ALIGNMENT): New macro.
1137 (mark_memory): Omit 3rd (offset) arg; caller changed.
1138 Don't assume EMACS_INT alignment is the same as pointer alignment.
1139
df1bbe5b
SM
11402011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1141
1142 * keyboard.c (read_key_sequence_remapped): New var.
1143 (read_key_sequence): Compute remapping in the right buffer.
1144 (command_loop_1): Use read_key_sequence's remapping directly.
1145
51553db6
SM
11462011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1147
32c1fffd
SM
1148 * dired.c (file_name_completion): Don't expand file name.
1149 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1150 before checking file name handler.
1151
51553db6
SM
1152 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1153 they've been requested explicitly (bug#9591).
1154
b6bd1599 11552011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1156
1157 * keymap.c (Fsingle_key_description): Use make_specified_string
1158 instead of build_string to build string from push_key_description.
1159 (Bug#5193)
1160
f701dc2a
PE
11612011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1162
4222c55d
PE
1163 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1164 This fixes a Y2038 bug on 64-bit hosts.
1165 * buffer.c (reset_buffer):
1166 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1167 (Fclear_buffer_auto_save_failure):
1168 Use 0, not -1, to represent an unset failure time, since time_t
1169 might not be signed.
1170
f701dc2a
PE
1171 Remove dependency on glibc malloc internals.
1172 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1173 Move back here from lisp.h, but with their new implementations.
1174 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1175 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1176 * charset.c (charset_table_init): New static var.
1177 (syms_of_charset): Use it instead of xmalloc. This removes a
1178 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1179 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1180 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1181 Move back to alloc.c.
1182 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1183 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1184
9ceebf39
JD
11852011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1186
1187 * nsterm.m (windowDidResize): Call x_set_window_size only when
1188 ns_in_resize is true. Otherwise set pixelwidth/height and
1189 call change_frame_size (Bug#9628).
1190
cb993c58
PE
11912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1192
3930c88b
PE
1193 Port --enable-checking=all to Fedora 14 x86-64.
1194 * charset.c (syms_of_charset): Also account for glibc malloc's
1195 internal overhead when calculating the initial malloc maximum.
1196
cb993c58
PE
1197 Port --enable-checking=all to Fedora 14 x86.
1198 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1199 Move to lisp.h.
1200 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1201 (overrun_check_realloc, overrun_check_free):
1202 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1203 That way, xmalloc returns a properly-aligned pointer even if
1204 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1205 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1206 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1207 into account when calculating the initial malloc maximum.
1208 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1209 Move here from alloc.c, so that charset.c can use it too.
1210 Properly align; the old code wasn't right for common 32-bit hosts
1211 when configured with --enable-checking=all.
1212 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1213 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1214
31bed486
EZ
12152011-09-29 Eli Zaretskii <eliz@gnu.org>
1216
04c70788 1217 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1218 use EDOM.
1219
fbcaa2f3
EZ
12202011-09-28 Eli Zaretskii <eliz@gnu.org>
1221
1222 * xdisp.c (compute_display_string_end): If there's no display
1223 string at CHARPOS, return -1.
1224
1225 * bidi.c (bidi_fetch_char): When compute_display_string_end
1226 returns a negative value, treat the character as a normal
1227 character not covered by a display string. (Bug#9624)
1228
a239d4e9
JB
12292011-09-28 Juanma Barranquero <lekktu@gmail.com>
1230
1231 * lread.c (Fread_from_string): Fix typo in docstring.
1232
88652fd5
EZ
12332011-09-27 Eli Zaretskii <eliz@gnu.org>
1234
1235 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1236 newline, reseat the iterator instead of bidi-iterating there one
1237 character at a time. (Bug#9610)
32c1fffd
SM
1238 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1239 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1240
ed497dd4
AS
12412011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1242
1243 * lread.c (readevalloop): Use correct code for NBSP.
1244 (read1): Likewise. (Bug#9608)
1245
b2bf61aa
MA
12462011-09-25 Michael Albinus <michael.albinus@gmx.de>
1247
1248 * dbusbind.c (Fdbus_register_signal): When service is not
1249 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1250
32bbb17c
GM
12512011-09-25 Glenn Morris <rgm@gnu.org>
1252
1253 * buffer.c (truncate-lines): Doc fix.
1254
94e0933e
CY
12552011-09-24 Chong Yidong <cyd@stupidchicken.com>
1256
1257 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1258 (Fset_window_next_buffers): Doc fix.
1259
cddde921
GM
12602011-09-24 Glenn Morris <rgm@gnu.org>
1261
1262 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1263
1260aef1
PE
12642011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1265
25b4bfa0
PE
1266 Fix minor problems found by static checking.
1267 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1268 * indent.c (Fvertical_motion): Fix == vs = typo.
1269
e3cbd34b
EZ
12702011-09-24 Eli Zaretskii <eliz@gnu.org>
1271
a66cfb1c
SM
1272 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1273 Default value is now t. Doc fix.
6bf7006f 1274
e3cbd34b 1275 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1276 logic when moving up, not only when moving down. Fix the
e3cbd34b 1277 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1278 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1279
1280 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1281 CHARPOS is covered by a display string which includes newlines.
1282 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1283 is covered by a display string with embedded newlines.
1284
a3de0cbd
MA
12852011-09-24 Michael Albinus <michael.albinus@gmx.de>
1286
1287 * dbusbind.c (Fdbus_register_signal): Add match rule to
1288 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1289 (Fdbus_register_method, Vdbus_registered_objects_table):
1290 Fix docstring.
a3de0cbd 1291
b260039d
JM
12922011-09-24 Jim Meyering <meyering@redhat.com>
1293
32c1fffd 1294 do not ignore write error for any output size
b260039d
JM
1295 The previous change was incomplete.
1296 While it makes emacs --batch detect the vast majority of stdout
1297 write failures, errors were still ignored whenever the output size is
1298 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1299 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1300 && echo FAIL: ignored write error
1301 FAIL: ignored write error
1302 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1303 && echo FAIL: ignored write error
1304 FAIL: ignored write error
1305 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1306
8eca8a7c
AS
13072011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1308
1309 * emacs.c (Fkill_emacs): In noninteractive mode exit
1310 non-successfully if a write error occurred on stdout. (Bug#9574)
1311
3341db62
EZ
13122011-09-21 Eli Zaretskii <eliz@gnu.org>
1313
1314 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1315 the xassert test.
1316
1317 * dispextern.h (struct it): Update the comment documenting what
1318 can it->OBJECT be.
1319
8c203dbf
EZ
13202011-09-20 Eli Zaretskii <eliz@gnu.org>
1321
1322 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1323 a display string, extend search for cursor position to end of row.
1324 (find_row_edges): If the row ends in a newline from a display
1325 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1326 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1327 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1328 non-empty line. Fixes confusing cursor motion with arrow keys at
1329 the beginning of a line that starts with whitespace.
8c203dbf 1330
a4824228
LMI
13312011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1332
1333 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1334 (bug#9493).
1335
33ed493b
CY
13362011-09-18 Chong Yidong <cyd@stupidchicken.com>
1337
1338 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1339 boolean (Bug#9154).
1340
56cd55c8
EZ
13412011-09-18 Eli Zaretskii <eliz@gnu.org>
1342
1343 * xdisp.c (display_line): Record maximum and minimum buffer
1344 positions even if no glyphs were produced (e.g., by a zero-width
1345 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1346 buffer positions that will be removed from the glyph row because
1347 they don't fit.
c02dcedf
EZ
1348 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1349 column is beyond frame width: don't subtract 1 "pixel" when
1350 computing width of the stretch.
3e62b7e0
EZ
1351 (reseat_at_next_visible_line_start): Undo the change made on
1352 2011-09-17 that saved paragraph information and restored it after
1353 the call to `reseat'. (Bug#9545)
56cd55c8 1354
5ed99d36 13552011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1356
1357 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1358 and turn window cursor on if cleared (Bug#9415).
1359
5ed99d36 13602011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1361
1362 * search.c (boyer_moore): Take unibyte characters from pattern
1363 literally. (Bug#9458)
1364
9bade7b2
EZ
13652011-09-18 Eli Zaretskii <eliz@gnu.org>
1366
1367 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1368
e5e9d610
PE
13692011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1370
87e4427a
PE
1371 Fix minor problem found by static checking.
1372 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1373 initialized, to pacify gcc -Wuninitialized.
1374
e5e9d610
PE
1375 * fileio.c: Report proper errno when syscall falls.
1376 (Finsert_file_contents): Save and restore errno,
1377 so that report_file_error outputs the correct diagnostic.
1378 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1379
a1674f0b
EZ
13802011-09-18 Eli Zaretskii <eliz@gnu.org>
1381
1382 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1383
fbfb6dd4
EZ
13842011-09-17 Eli Zaretskii <eliz@gnu.org>
1385
1386 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1387 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1388
bb187662
EZ
13892011-09-17 Eli Zaretskii <eliz@gnu.org>
1390
1137e8b8 1391 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1392 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1393
1394 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1395 (bidi_find_paragraph_start): Search back for paragraph beginning
1396 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1397 (bidi_move_to_visually_next): Only trigger paragraph-related
1398 computations when the last character is a newline or at EOB, not
1399 just any NEUTRAL_B. (Bug#9470)
1400
bb187662
EZ
1401 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1402 truncated lines if point is covered by a display string. (Bug#9524)
1403
2e621251
PE
14042011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1405
1406 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1407 (cons_to_x_long): New function.
1408 (lisp_data_to_selection_data): Use it. Correct the test for
1409 short-versus-long data; it was negated. Break out of vector
1410 loop, for efficiency, when a long datum is discovered.
1411
91a15bc6
SM
14122011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1413
1414 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1415
b41c3a35
EZ
14162011-09-16 Eli Zaretskii <eliz@gnu.org>
1417
1418 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1419 GCC PR/17406) by declaring this function with external scope.
1420
7812ba2d
PE
14212011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1424 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1425
cf7edc2a
AS
14262011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1427
1428 * editfns.c (Fformat): Correctly handle text properties on "%%".
1429
bd01620e
EZ
14302011-09-15 Eli Zaretskii <eliz@gnu.org>
1431
1432 * xterm.c (x_draw_composite_glyph_string_foreground):
1433 * w32term.c (x_draw_composite_glyph_string_foreground):
1434 * term.c (encode_terminal_code):
1435 * composite.c (composition_update_it, get_composition_id):
1436 * xdisp.c (get_next_display_element)
1437 (fill_composite_glyph_string): Add comments about special meaning
1438 of TAB characters in a composition.
1439
a02719a3
PE
14402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1443 This occurs when processing a multibyte format.
1444 Problem reported by Wolfgang Jenker.
a02719a3 1445
72589a3c
JB
14462011-09-15 Johan Bockgård <bojohan@gnu.org>
1447
1448 * xdisp.c (try_cursor_movement): Only check for exact match if
1449 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1450
1c14176c
PE
14512011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1452
1453 Remove unused external symbols.
1454 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1455 * xdisp.c (calc_pixel_width_or_height): Now static.
1456 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1457 * indent.c (check_display_width):
1458 * w32term.c: Fix comment to match code.
1459 * xterm.c, xterm.h (x_catching_errors): Remove.
1460
d2eea5b5
PE
14612011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 * xselect.c: Use signed conversions more consistently (Bug#9498).
1464 (selection_data_to_lisp_data): Assume incoming selection data are
1465 signed integers, not unsigned. This is to be consistent with
1466 outgoing selection data, which was modified to use signed integers
1467 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1468 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1469 expects long, not unsigned long.
1470
46888499
EZ
14712011-09-14 Eli Zaretskii <eliz@gnu.org>
1472
1473 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1474 computation of loop end. Reported by Johan Bockgård
1475 <bojohan@gnu.org>.
1476
ef8ef9fb
CY
14772011-09-13 Chong Yidong <cyd@stupidchicken.com>
1478
1479 * frame.c (Fother_visible_frames_p): Function deleted.
1480
fa819fed
EZ
14812011-09-12 Eli Zaretskii <eliz@gnu.org>
1482
1483 * indent.c (compute_motion): Process display vector front to back
1484 rather than the other way around. (Bug#2496)
1485
2ba8e008
SM
14862011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1487
1488 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1489
20f53c69
CY
14902011-09-11 Chong Yidong <cyd@stupidchicken.com>
1491
1492 * minibuf.c (Fread_from_minibuffer): Doc fix.
1493
d562d7a4
EZ
14942011-09-11 Eli Zaretskii <eliz@gnu.org>
1495
1496 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1497 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1498
1c4d7f3d
LMI
14992011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1500
1501 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1502 value for non-existent files.
1503
b885bf36
EZ
15042011-09-11 Eli Zaretskii <eliz@gnu.org>
1505
1506 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1507 set its "size" to -1. This will set the modtime_size field of
1508 the corresponding buffer to -1, which is what
1509 verify-visited-file-modtime expects for files that do not exist.
1510 (Bug#9139)
1511
6612f0bf
PE
15122011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1513
1514 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1515 here ...
1516 * lisp.h: ... from here. push_key_description is no longer
1517 defined in keyboard.c, so its declaration should not be in
1518 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1519 logically belongs with push_key_description.
1520
dfb3f755
PE
15212011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 * buffer.h: Include <sys/types.h> instead of <time.h>.
1524 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1525 Problem reported by Herbert J. Skuhra.
1526
3134906c
LMI
15272011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1528
1529 * xml.c (parse_region): Make the parsing work for
1530 non-comment-starting XML files again (bug#9144).
1531
8d903f4e
AS
15322011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1533
1534 * image.c (gif_load): Fix calculation of bottom and right corner.
1535 (Bug#9468)
1536
80ad64f4
EZ
15372011-09-10 Eli Zaretskii <eliz@gnu.org>
1538
1539 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1540 redisplay in small windows.
1541
208a048d
EZ
15422011-09-09 Eli Zaretskii <eliz@gnu.org>
1543
1544 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1545
9b1c252e
MR
15462011-09-08 Martin Rudalics <rudalics@gmx.at>
1547
1548 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1549 Operate on live windows only.
1550
2949f33b
JB
15512011-09-08 Juanma Barranquero <lekktu@gmail.com>
1552
1553 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1554
e08dcafd
EZ
15552011-09-07 Eli Zaretskii <eliz@gnu.org>
1556
1557 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1558 only under bidi iteration.
1559
115b96bd
JD
15602011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1561
1562 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1563
c8199d0f
PE
15642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1567 Without this fix, the command to link temacs failed due to an
1568 undefined symbol __builtin_isnan. This is because
1569 /usr/include/iso/math_c99.h #defines isnan(x) to
1570 __builtin_isnan(x), but the bundled gcc, which identifies itself
1571 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1572 a __builtin_isnan.
1573 * floatfns.c (isnan): #undef, and then #define to a clone of
1574 what's in data.c.
1575 (Fisnan): Always define, since it's always available now.
1576 (syms_of_floatfns): Always define isnan at the Lisp level.
1577
e39b275c 15782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1579
1580 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1581
b2db44d9 15822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1583
f4af5137 1584 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1585 The previous code assumed that file offsets (off_t values) fit in
1586 EMACS_INT variables, which is not true on typical 32-bit hosts.
1587 The code messed up by falsely reporting buffer overflow in cases
1588 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1589 when "big" contains more than 2**29 bytes, even though this
1590 inserts just one byte and does not overflow the buffer.
1591 (Finsert_file_contents): Store file offsets as off_t
1592 values, not as EMACS_INT values. Check for overflow when
1593 converting between EMACS_INT and off_t. When checking for
1594 buffer overflow or for overlap, take the offsets into account.
1595 Don't use EMACS_INT for small values where int suffices.
1596 When checking for overlap, fix a typo: ZV was used where
1597 ZV_BYTE was intended.
1598 (Fwrite_region): Don't assume off_t fits into 'long'.
1599 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1600
ecfc0a49
MA
16012011-09-05 Michael Albinus <michael.albinus@gmx.de>
1602
1603 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1604
6511acf2 16052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1606
0999621a 1607 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1608
1609 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1610 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1611 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1612 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1613 (modify_event_symbol): Do not assume that the length of
1614 name_alist_or_stem is safe to alloca and fits in int.
1615 (Fexecute_extended_command): Likewise for function name and binding.
1616 (Frecursion_depth): Wrap around reliably on integer overflow.
1617 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1618 since some callers pass EMACS_INT values.
1619 (Fsingle_key_description): Don't crash if symbol name contains more
1620 than MAX_ALLOCA bytes.
1621 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1622 (get_minibuffer): Arg is now EMACS_INT, not int.
1623 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1624 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1625 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1626
2be7d702
PE
1627 * dbusbind.c (signature_cat): New function.
1628 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1629 Do not overrun buffer; instead, report string overflow.
1630
9d1df220
PE
1631 * dispnew.c (add_window_display_history): Don't overrun buffer.
1632 Truncate instead; this is OK since it's just a log.
1633
33ef5c64
PE
1634 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1635 even if the time zone offset is outlandishly large.
1636 Don't mishandle offset == INT_MIN.
1637
66c6fdd5
PE
1638 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1639 when creating daemon; the previous buffer-overflow check was incorrect.
1640
d749b01b
PE
1641 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1642 which has the guts of the old verror function.
1643
b5cd1905
PE
1644 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1645 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1646
6e1a67fb
PE
1647 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1648 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1649 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1650 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1651 length of string rather than counting it via multiple sprintfs;
1652 that's simpler and more reliable.
c21721cc
PE
1653 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1654 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1655 sprintf, in case result does not fit in int.
1656
c57b67fc
PE
1657 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1658 (fontset_from_font): Print it.
1659
8a401434
PE
1660 * frame.c (tty_frame_count): Now printmax_t, not int.
1661 (make_terminal_frame, set_term_frame_name): Print it.
1662 (x_report_frame_params): In X, window IDs are unsigned long,
1663 not signed long, so print them as unsigned.
1664 (validate_x_resource_name): Check for implausibly long names,
1665 and don't assume name length fits in 'int'.
1666 (x_get_resource_string): Don't blindly alloca invocation name;
1667 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1668 not fit in int.
1669
6e1a67fb
PE
1670 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1671 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1672 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1673
0df02bf3
PE
1674 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1675 Use esprintf, not sprintf, in case result does not fit in int.
1676
48e30793
PE
1677 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1678 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1679 it as a large positive number.
1680 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1681 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1682
a66ff6d8
PE
1683 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1684 in case result does not fit in int.
1685
aca216ff
PE
1686 * print.c (float_to_string): Detect width overflow more reliably.
1687 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1688 buffer overrun. Don't assume list length fits in 'int'. Treat
1689 print length of 0 as 0, not as infinity; to be consistent with other
1690 uses of print length in this function. Don't overflow print length
1691 index. Don't assume hash table size fits in 'long', or that
1692 vectorlike size fits in 'unsigned long'.
1693
31c286f7
PE
1694 * process.c (make_process): Use printmax_t, not int, to format
1695 process-name gensyms.
1696
55e5faa1
PE
1697 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1698
80f2e268
PE
1699 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1700 to avoid potential buffer overrun.
1701
670741ab
PE
1702 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1703 if X resource line is longer than 512 bytes.
1704
b7163a50
PE
1705 * xfns.c (x_window): Make sprintf buffer a bit bigger
1706 to avoid potential buffer overrun.
1707
ae58ff1f
PE
1708 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1709
c43c8a6a
PE
1710 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1711
3f8236f4
PE
17122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1713
53e9fe90 1714 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1715 Without these, Emacs silently mishandles large integers sometimes.
1716 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1717 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1718
6511acf2
PE
1719 * xdisp.c (try_window_id): Check Emacs fixnum range before
1720 converting to 'int'.
806add1d 1721
6511acf2 1722 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1723 Check that an Emacs fixnum is in range before assigning it to 'int'.
1724 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1725 values converted from Emacs fixnums.
1726 (Frecenter): Don't wrap around a line count if it is out of 'int'
1727 range; instead, treat it as an extreme value.
1728 (Fset_window_configuration, compare_window_configurations):
1729 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1730
6511acf2
PE
1731 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1732 that can exceed INT_MAX. Check that EMACS_INT value is in range
1733 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1734 (match_limit): Don't assume that a fixnum can fit in 'int'.
1735
6511acf2 1736 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1737 exceed INT_MAX.
1738
6511acf2 1739 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1740 (Fvertical_motion): Don't wrap around LINES values that don't fit
1741 in 'int'. Instead, treat them as extreme values. This is good
1742 enough for windows, which can't have more than INT_MAX lines anyway.
1743
fcb901a7
LMI
17442011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1745
0f2f6b6d
LMI
1746 * Require libxml/parser.h to avoid compilation warning.
1747
fcb901a7
LMI
1748 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1749
1750 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1751 since this reportedly can destroy thread storage.
1752
6e20a0d4
CY
17532011-08-30 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * syntax.c (find_defun_start): Update all cache variables if
1756 exiting early (Bug#9401).
1757
148ae00e
EZ
17582011-08-30 Eli Zaretskii <eliz@gnu.org>
1759
f6cfbd8f
EZ
1760 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1761
148ae00e
EZ
1762 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1763 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1764 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1765
1766 * term.c (tty_append_glyph): New function.
1767 (produce_stretch_glyph): Static function and its prototype deleted.
1768
a66cfb1c
SM
1769 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1770 Add prototypes.
148ae00e 1771
c4a07a4c
PE
17722011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1775 when checking :margin (Bug#9390).
1776 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1777 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1778 so that the name doesn't mislead. All uses changed.
1779
6bc8cd65
JB
17802011-08-28 Johan Bockgård <bojohan@gnu.org>
1781
1782 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1783 set_tty_hooks.
1784
dca4927e
EZ
17852011-08-27 Eli Zaretskii <eliz@gnu.org>
1786
1787 * xdisp.c (move_it_to): Don't bail out early when reaching
1788 position beyond to_charpos, if we are scanning backwards.
1789 (move_it_vertically_backward): When DY == 0, make sure we get to
1790 the first character in the line after the newline.
1791
f2cad773
PE
17922011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1795 (ccl_driver): Do not generate an out-of-range pointer.
1796 (Fccl_execute_on_string): Remove unnecessary check for
1797 integer overflow, noted by Stefan Monnier in
1798 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1799 Remove a FIXME that didn't need fixing.
1800 Simplify the newly-introduced buffer reallocation code.
1801
0cae2cdb
JB
18022011-08-27 Juanma Barranquero <lekktu@gmail.com>
1803
1804 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1805
5fc295a4 18062011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1807
70c60eb2 1808 Integer and memory overflow issues (Bug#9196).
726e0ab1 1809
d31850da
PE
1810 * doc.c (get_doc_string): Rework so that
1811 get_doc_string_buffer_size is the actual buffer size, rather than
1812 being 1 less than the actual buffer size; this makes xpalloc more
1813 convenient.
1814
a69fbedb
PE
1815 * image.c (x_allocate_bitmap_record, cache_image):
1816 * xselect.c (Fx_register_dnd_atom):
1817 Simplify previous changes by using xpalloc.
1818
fe5c5d37
PE
1819 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1820 since either will do and ptrdiff_t is convenient with xpalloc.
1821
0065d054
PE
1822 * charset.c (charset_table_size)
1823 (struct charset_sort_data.priority): Now ptrdiff_t.
1824 (charset_compare): Don't overflow if priorities differ greatly.
1825 (Fsort_charsets): Don't assume list length fits in int.
1826 Check for size-calculation overflow when allocating sort data.
1827 (syms_of_charset): Allocate an initial charset table that is
1828 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1829
1830 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1831
1832 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1833 The actual value is always <= INT_MAX, and leaving it unsigned made
1834 overflow checking harder.
1835
1836 * dispextern.h (struct glyph_matrix.rows_allocated)
1837 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1838 with xpalloc. The values are still always <= INT_MAX.
1839
1840 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1841
1842 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1843 (SAFE_NALLOCA): New macro.
1844
1845 * region-cache.c (struct boundary.pos, find_cache_boundary)
1846 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1847 (set_cache_region, invalidate_region_cache)
1848 (revalidate_region_cache, know_region_cache, region_cache_forward)
1849 (region_cache_backward, pp_cache):
1850 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1851 so that ptrdiff_t * can be passed to xpalloc.
1852 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1853 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1854 (pp_cache): Don't assume cache_len fits in int.
1855 * region-cache.h: Adjust extern decls to match.
1856
1857 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1858 EMACS_INT, since either will do, for xpalloc.
1859
1860 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1861 (xnmalloc, xnrealloc, xpalloc): New functions.
1862
726e0ab1
PE
1863 * bidi.c (bidi_shelve_header_size): New constant.
1864 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1865 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1866
51f30bc5 1867 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1868 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1869 (overlay_strings):
1870 Don't update size of array until after memory allocation succeeds,
1871 because xmalloc/xrealloc may not return.
0065d054
PE
1872 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1873 now that we have proper integer overflow checking.
1874 (record_overlay_string, overlay_strings): Catch overflows when
1875 calculating size of overlay_str_buf.
726e0ab1 1876
0065d054
PE
1877 * callproc.c (Fcall_process): Check for size overflow when
1878 calculating size of args2.
1879 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1880 Normally we prefer signed values, but sticking with ptrdiff_t would
1881 require adding more-complicated checks.
726e0ab1
PE
1882
1883 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1884 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1885 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1886 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1887
1888 * character.c (Fstring): Check for size-calculation overflow.
1889
1890 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1891 unnecessary integer overflow. Check for size overflow.
1892 (encode_coding_object): Don't update size until xmalloc succeeds.
1893
1894 * composite.c (get_composition_id): Check for overflow in glyph
1895 length calculations.
1896
1897 Integer and memory overflow fixes for display code.
1898 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1899 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1900 (scrolling_window): Check for overflow in size calculations.
1901 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1902 Don't assume glyph table len fits in int.
1903 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1904 (row_table_size): Now ptrdiff_t, not int.
1905 (scrolling_window): Avoid overflow in size calculations.
1906 Don't update size until allocation succeeds.
1907 * fns.c (concat): Check for overflow in size calculations.
1908 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1909 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1910 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1911
1912 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1913 (get_doc_string): Check for size calculation overflow.
1914 Don't update size until allocation succeeds.
1915 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1916 EMACS_INT, where ptrdiff_t will do.
1917 (Fsubstitute_command_keys): Check for string overflow.
1918
1919 * editfns.c (set_time_zone_rule): Don't assume environment length
1920 fits in int.
1921 (message_length): Now ptrdiff_t, not int.
1922 (Fmessage_box): Don't update size until allocation succeeds.
1923 Don't assume message length fits in int.
1924 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1925
0065d054
PE
1926 * emacs.c (main): Do not reallocate argv, since there is a null at
1927 the end that can be overwritten, and this way there's no need to
1928 worry about size-calculation overflow.
1929 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1930
1931 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1932 alloc succeeds.
1933 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1934
1935 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1936 (x_set_scroll_bar_width, x_figure_window_size):
1937 Check for integer overflow.
1938 (x_set_alpha): Do not assume XINT fits in int.
1939
1940 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1941 This is for the members text_lines, text_cols, total_lines, total_cols,
1942 where the system imposes an 'int' limit.
1943
1944 * fringe.c (Fdefine_fringe_bitmap):
1945 Don't update size until alloc works.
1946
1947 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1948 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1949
1950 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1951 Check for size-calculation overflow.
1952 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1953 do, as we prefer signed integers.
1954 (id_to_widget.max_size, id_to_widget.used)
1955 (xg_store_widget_in_map, xg_remove_widget_from_map)
1956 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1957 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1958 Use and return ptrdiff_t, not int.
1959 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1960 * gtkutil.h: Change prototypes to match the above.
1961
1962 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1963 are duplicate now that they've been promoted to lisp.h.
1964 (x_allocate_bitmap_record, x_alloc_image_color)
1965 (make_image_cache, cache_image, xpm_load):
1966 Don't update size until alloc is done.
1967 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1968 (x_detect_edges):
3256efce 1969 Check for size calculation overflow.
726e0ab1
PE
1970 (ct_colors_allocated_max): New constant.
1971 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1972 overflow.
3256efce 1973
726e0ab1
PE
1974 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1975 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1976 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1977 Use ptrdiff_t, not int, to count maps.
1978 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1979 calculations. Don't update size until allocation succeeds.
1980 Redo calculations to avoid overflow.
726e0ab1
PE
1981 * keyboard.h: Change prototypes to match the above.
1982
1983 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1984 to count maps.
1985 (current_minor_maps): Check for size calculation overflow.
1986 * keymap.h: Change prototypes to match the above.
1987
1988 * lread.c (read1, init_obarray): Don't update size until alloc done.
1989
1990 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1991 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1992
726e0ab1
PE
1993 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1994 Now ptrdiff_t, not int.
1995 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1996 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1997
1998 * process.c (Fnetwork_interface_list): Check for overflow
1999 in size calculation.
2000
2001 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2002
2003 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2004 overflow. Don't bother calling xmalloc when xrealloc will do.
2005
2006 * search.c (Freplace_match): Check for size calculation overflow.
2007 (Fset_match_data): Don't assume list lengths fit in 'int'.
2008
2009 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2010 for command line length. Do not attempt to address one before the
2011 beginning of an array, as that's not portable.
2012
2013 * term.c (max_frame_lines): Remove; unused.
2014 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2015 not int.
2016 (encode_terminal_code, calculate_costs): Check for size
2017 calculation overflow.
2018 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2019 table lengths and related sizes. Don't update size until alloc
2020 done. Redo calculations to avoid overflow.
2021 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2022
2023 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2024 subtracting pointers.
2025 (gobble_line): Check for overflow more carefully. Don't update size
2026 until alloc done.
2027
2028 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2029 Don't update size until alloc done.
2030 Redo size calculations to avoid overflow.
2031 Check for size calculation overflow.
0065d054 2032 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2033
2034 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2035 Use ptrdiff_t, not int, for sizes.
2036 (store_mode_line_noprop_char): Don't update size until alloc done.
2037
0065d054
PE
2038 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2039 Use ptrdiff_t, not int, for sizes.
2040 (Finternal_make_lisp_face, cache_face):
2041 Check for size calculation overflow.
2042 (cache_face): Treat size calculation overflows as if they were
2043 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2044
2045 * xfns.c (x_encode_text, x_set_name_internal)
2046 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2047 sizes, since they can exceed INT_MAX in size. Check for size
2048 calculation overflow.
2049
0065d054
PE
2050 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2051 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2052 Don't update size until alloc done.
2053
0065d054 2054 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2055 as sprintf is limited to int lengths.
1d526e2f 2056
252c5ee1
PE
2057 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2058 (X_LONG_MIN): New macros.
864d7ce7
PE
2059 Use them to make the following changes clearer.
2060 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2061 This change doesn't affect the value now, but it may help remind
2062 future maintainers not to raise the value too much later.
2063 (SELECTION_QUANTUM): Remove, replacing with ...
2064 (selection_quantum): ... new function, which avoids overflow.
2065 All uses changed.
2066 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2067 assumption that selection length fits in 'int'.
2068 (x_reply_selection_request, x_handle_selection_request)
2069 (x_get_window_property, receive_incremental_selection)
2070 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2071 (lisp_data_to_selection_data, clean_local_selection_data):
2072 Use ptrdiff_t, not int, to record length of selection.
2073 (x_reply_selection_request, x_get_window_property)
2074 (receive_incremental_selection, x_property_data_to_lisp):
2075 Redo calculations to avoid overflow.
2076 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2077 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2078 something.
2079 (x_get_window_property, receive_incremental_selection)
2080 (lisp_data_to_selection_data, x_property_data_to_lisp):
2081 Check for size-calculation overflow.
2082 (x_get_window_property, receive_incremental_selection)
2083 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2084 Don't store size until memory allocation succeeds.
2085 (x_get_window_property): Plug memory leak on memory exhaustion.
2086 Don't double-block input; malloc is safe here. Don't assume 2**34
2087 - 4 fits in unsigned long. Add an xassert to check
2088 XGetWindowProperty overflow. Be more careful about overflow
2089 calculations, and distinguish size from memory overflow better.
2090 (receive_incremental_selection): When tracing, don't assume
2091 unsigned int is less than INT_MAX.
2092 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2093 harmful) conversions of unsigned short to int.
2094 (lisp_data_to_selection_data): Don't assume that integers
2095 in the range -65535 through -1 fit in an X unsigned short.
2096 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2097 result parameters unless successful. Rely on cons_to_unsigned
2098 to report problems with elements; the old code wasn't right anyway.
2099 (x_check_property_data): Check for int overflow; we cannot use
2100 a wider type due to X limits.
2101 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2102
726e0ab1 2103 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2104
0065d054
PE
2105 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2106 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2107 (x_color_cells): Don't store size until memory allocation succeeds.
2108 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2109 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2110 (x_term_init): Don't assume length fits in int (sprintf is limited
2111 to int size).
bc18e09d 2112
ebfa62c0
PE
2113 Use ptrdiff_t for composition IDs.
2114 * character.c (lisp_string_width):
2115 * composite.c (composition_table_size, n_compositions)
2116 (get_composition_id, composition_gstring_from_id):
2117 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2118 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2119 * window.c (Frecenter):
2120 Use ptrdiff_t, not int, for composition IDs.
2121 * composite.c (get_composition_id): Check for integer overflow.
2122 * composite.h: Adjust prototypes to match the above changes.
2123
d3411f89
PE
2124 Use ptrdiff_t for hash table indexes.
2125 * category.c (hash_get_category_set):
2126 * ccl.c (ccl_driver):
2127 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2128 * coding.c (coding_system_charset_list, detect_coding_system):
2129 * coding.h (struct coding_system.id):
2130 * composite.c (get_composition_id, gstring_lookup_cache):
2131 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2132 * image.c (xpm_get_color_table_h):
2133 * lisp.h (hash_lookup, hash_put):
2134 * minibuf.c (Ftest_completion):
2135 Use ptrdiff_t for hash table indexes, not int (which is too
2136 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2137 32-bit --with-wide-int hosts).
2138
e097a6fa
PE
2139 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2140 Add a FIXME comment about memory leaks.
2141 (syms_of_charset): Don't assume xmalloc returns.
2142
5637687f
PE
2143 Don't assume that stated character widths fit in int.
2144 * character.c (Fchar_width, c_string_width, lisp_string_width):
2145 * character.h (CHAR_WIDTH):
2146 * indent.c (MULTIBYTE_BYTES_WIDTH):
2147 Use sanitize_char_width to avoid undefined and/or bad behavior
2148 with outlandish widths.
a66cfb1c 2149 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2150 now that we have two such functions. All uses changed.
2151 (sanitize_char_width): New inline function.
2152
a2271ba2
PE
2153 Don't assume that tab-width fits in int.
2154 * character.h (sanitize_width): New inline function.
2155 (SANE_TAB_WIDTH): New macro.
2156 (ASCII_CHAR_WIDTH): Use it.
2157 * indent.c (sane_tab_width): Remove. All uses replaced by
2158 SANE_TAB_WIDTH (current_buffer).
2159 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2160
18c52557
PE
2161 * fileio.c: Integer overflow issues with file modes.
2162 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2163
caeeedc1
PE
2164 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2165 Remove unreachable code.
2166 (read_hex, load_charset_map_from_file): Check for integer overflow.
2167
50849c52
PE
2168 * xterm.c: don't go over XClientMessageEvent limit
2169 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2170 (x_send_scroll_bar_event): Likewise. Check that the size does not
2171 exceed limits imposed by XClientMessageEvent, as well as the usual
2172 ptrdiff_t and size_t limits.
2173
b13995db
PE
2174 * keyboard.c: Overflow, signedness and related fixes.
2175 (make_lispy_movement): Use same integer type in forward decl
2176 that is used in the definition.
2177 (read_key_sequence, keyremap_step):
2178 Change bufsize argument back to int, undoing my 2011-03-30 change.
2179 We prefer signed types, and int is wide enough here.
2180 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2181 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2182 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2183 length, not size_t. Use ptrdiff_t for index, not int.
2184 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2185 possibility of integer overflow.
2186
13464394
PE
2187 Overflow, signedness and related fixes for images.
2188
2189 * dispextern.h (struct it.stack[0].u.image.image_id)
2190 (struct_it.image_id, struct image.id, struct image_cache.size)
2191 (struct image_cache.used, struct image_cache.ref_count):
2192 * gtkutil.c (update_frame_tool_bar):
2193 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2194 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2195 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2196 * nsmenu.m (update_frame_tool_bar):
2197 * xdisp.c (calc_pixel_width_or_height):
2198 * xfns.c (image_cache_refcount):
2199 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2200 on typical 64-bit hosts.
2201
2202 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2203 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2204 Omit unnecessary casts to int.
2205 (parse_image_spec): Check that integers fall into 'int' range
2206 when the callers expect that.
2207 (image_ascent): Redo ascent calculation to avoid int overflow.
2208 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2209 (lookup_image): Remove unnecessary tests.
2210 (xbm_image_p): Locals are now of int, not EMACS_INT,
2211 since parse_image_check makes sure they fit into int.
2212 (png_load, gif_load, svg_load_image):
2213 Prefer int to unsigned where either will do.
2214 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2215 old tiff_error_handler and tiff_warning_handler.
2216 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2217 stack buffer overflows. It uses only the features of vsnprintf
2218 that are common to both POSIX and native Microsoft.
2219 (tiff_error_handler, tiff_warning_handler): Use it.
2220 (tiff_load, gif_load, imagemagick_load_image):
2221 Don't assume :index value fits in 'int'.
2222 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2223 (imagemagick_load_image): Check that crop parameters fit into
2224 the integer types that MagickCropImage accepts. Don't assume
2225 Vimagemagick_render_type has a nonnegative value. Don't assume
2226 size_t fits in 'long'.
2227 (gs_load): Use printmax_t to print the widest integers possible.
2228 Check for integer overflow when computing image height and width.
2229
c11821d4
EZ
22302011-08-26 Eli Zaretskii <eliz@gnu.org>
2231
2232 * xdisp.c (redisplay_window): Don't force window start if point
2233 will be invisible in the resulting window. (Bug#9324)
2234
0c95fcf7
EZ
22352011-08-25 Eli Zaretskii <eliz@gnu.org>
2236
2237 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2238 the display spec is of the form `(space ...)'.
2239 (handle_display_spec): Return the value returned by
2240 handle_single_display_spec, not just 1 or zero.
2241 (handle_single_display_spec): If the display spec is of the form
2242 `(space ...)', and specifies display in the text area, return 2
2243 rather than 1.
fee65a97 2244 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2245 accurately, and prefer exact match for point under bidi.
2246 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2247
2248 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2249 into disp_prop; all users changed.
2250
2251 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2252 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2253 for the text covered by the display property.
2254
e4ed06f1
CY
22552011-08-25 Chong Yidong <cyd@stupidchicken.com>
2256
2257 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2258 Change return value to nil.
2259 (Frecord_buffer): Delete unused function.
2260
f67cdd7f
EZ
22612011-08-24 Eli Zaretskii <eliz@gnu.org>
2262
5980d4c6
EZ
2263 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2264 buffers, return left-to-right.
8610fe8b
EZ
2265 (set_cursor_from_row): Consider candidate row a win if its glyph
2266 represents a newline and point is on that newline. Fixes cursor
2267 positioning on the newline at EOL of R2L text within L2R
2268 paragraph, and vice versa.
2269 (try_cursor_movement): Check continued rows, in addition to
2270 continuation rows. Fixes unwarranted scroll when point enters a
2271 continued line of R2L text within an L2R paragraph, or vice versa.
2272 (cursor_row_p): Consider the case of point being equal to
2273 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2274 from the end of a short line to the beginning of a continued line
2275 of R2L text within L2R paragraph.
2276 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2277 composed characters.
5980d4c6 2278
f67cdd7f
EZ
2279 * bidi.c (bidi_check_type): Use xassert.
2280 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2281 members.
2282
bca633fb
EZ
22832011-08-23 Eli Zaretskii <eliz@gnu.org>
2284
2285 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2286 a character.
2287
4a5885a7
CY
22882011-08-23 Chong Yidong <cyd@stupidchicken.com>
2289
2290 * nsfont.m (ns_otf_to_script): Fix typo.
2291
0902a04e
KH
22922011-08-22 Kenichi Handa <handa@m17n.org>
2293
2294 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2295 extra slot even if the purpose is char-code-property-table.
2296
1a2e6670
EZ
22972011-08-23 Eli Zaretskii <eliz@gnu.org>
2298
8ddde651
EZ
2299 * xdisp.c (redisplay_window): When computing centering_position,
2300 account for the height of the header line. (Bug#8874)
2301
425cc014
EZ
2302 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2303 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2304 candidate is selected by the mouse, and that candidate has a
2305 composed character under the mouse.
2306
1a2e6670
EZ
2307 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2308 coordinates reported by pos-visible-in-window-p for a composed
2309 character in column zero.
2310
8b76d6f8
SM
23112011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2312
2313 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2314
dac347dd
EZ
23152011-08-22 Eli Zaretskii <eliz@gnu.org>
2316
2317 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2318 consider it a hit if to_charpos is anywhere in the range of the
2319 composed buffer positions.
2320
e013fb34
CY
23212011-08-22 Chong Yidong <cyd@stupidchicken.com>
2322
2323 * image.c (gif_load): Don't assume that each subimage has the same
2324 dimensions as the base image. Handle disposal method that is
2325 "undefined" by the gif spec (Bug#9335).
2326
bd1ba3e8
CY
23272011-08-20 Chong Yidong <cyd@stupidchicken.com>
2328
2329 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2330 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2331
54a1215b
EZ
23322011-08-19 Eli Zaretskii <eliz@gnu.org>
2333
823564e5
EZ
2334 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2335 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2336 from an Org mode buffer to a Speedbar frame.
2337
54a1215b
EZ
2338 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2339 a composition, take its buffer position from IT->cmp_it.charpos.
2340 Fixes cursor positioning at the beginning of a line that begins
2341 with a composed character.
2342
9778ebcc
EZ
23432011-08-18 Eli Zaretskii <eliz@gnu.org>
2344
0be6ee06
EZ
2345 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2346 character bidirectional type, use STRONG_L instead. Fixes crashes
2347 in a buffer produced by `describe-categories'.
2348
9778ebcc
EZ
2349 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2350 members before the level stack, so they would be saved and
2351 restored when copying iterator state. Fixes incorrect reordering
2352 around TABs covered by display properties.
2353
156bffbe
AS
23542011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2355
6b02f655 2356 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2357
72ad093b
CY
23582011-08-17 Chong Yidong <cyd@stupidchicken.com>
2359
2360 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2361 (internal_condition_case_2, internal_condition_case_n):
2362 Remove unnecessary aborts (Bug#9081).
72ad093b 2363
35774242
EZ
23642011-08-17 Eli Zaretskii <eliz@gnu.org>
2365
2366 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2367 has no `load' handler, try opening the file locally. (Bug#9311)
2368
db76dd85
KB
23692011-08-16 Ken Brown <kbrown@cornell.edu>
2370
2371 * gmalloc.c: Expand comment.
2372
b215eee5
EZ
23732011-08-16 Eli Zaretskii <eliz@gnu.org>
2374
2375 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2376 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2377
a4579d33
KB
23782011-08-16 Ken Brown <kbrown@cornell.edu>
2379
2380 Fix memory allocation problems in Cygwin build (Bug#9273).
2381
2382 * unexcw.c ( __malloc_initialized): Declare external variable.
2383 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2384
8b76d6f8
SM
2385 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2386 New variables.
a4579d33
KB
2387 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2388 dumped emacs.
2389 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2390 in the static heap.
2391 [CYGWIN] (special_realloc): New function.
2392 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2393 requests to realloc storage in the static heap.
2394
3ebec551
PE
23952011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * bidi.c (bidi_initialize): Remove unused local.
2398
9fd8be00
EZ
23992011-08-15 Eli Zaretskii <eliz@gnu.org>
2400
6b02f655
SM
2401 * bidimirror.h:
2402 * biditype.h: Remove file.
2403 * makefile.w32-in ($(BLD)/bidi.$(O)):
2404 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2405
2406 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2407
2408 * chartab.c: Improve commentary for the uniprop_table API.
2409
32413314
EZ
2410 * bidi.c (bidi_paragraph_init): Support zero value of
2411 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2412 (bidi_initialize): Use uniprop_table instead of including
2413 biditype.h and bidimirror.h.
32413314 2414
9fd8be00
EZ
2415 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2416 coordinates of the iterator when restoring from ppos_it.
2417 (Bug#9296)
2418
5cf2b69b
KH
24192011-08-14 Kenichi Handa <handa@m17n.org>
2420
2421 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2422 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2423
daf17d00
EZ
24242011-08-14 Eli Zaretskii <eliz@gnu.org>
2425
2426 * xdisp.c (move_it_in_display_line_to): Don't invoke
2427 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2428 ppos_it. Fixes vertical cursor motion when line beginning is
2429 covered by an image. (Bug#9296)
2430
08e3161a
JD
24312011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2432
2433 * nsterm.h (ns_run_ascript): Declare.
2434 (NSAPP_DATA2_RUNASSCRIPT): Define.
2435
2436 * nsfns.m (as_script, as_result, as_status): New static variables.
2437 (ns_run_ascript): New function.
5e617bc2 2438 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2439 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2440 the event loop. Get status from as_status (Bug#7276).
2441
2442 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2443 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2444 the event loop (Bug#7276).
2445
a3720aa2
AS
24462011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2447
2448 * gnutls.c (QCgnutls_bootprop_priority)
2449 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2450 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2451 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2452 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2453 (QCgnutls_bootprop_verify_hostname_error)
2454 (QCgnutls_bootprop_callbacks_verify): Rename from
2455 Qgnutls_bootprop_..., all uses changed.
2456
2457 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2458 uses changed.
2459
0a0d27fb
PE
24602011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2461
19d5c50c
PE
2462 * xfaces.c (Qframe_set_background_mode): Now static.
2463 * dispextern.h (Qframe_set_background_mode): Remove decl.
2464
0a0d27fb
PE
2465 * process.c (Fnetwork_interface_info): Declare local only if needed.
2466
377538cb
JD
24672011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2468
2469 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2470 (Fnetwork_interface_list): Allocate in increments of bytes instead
2471 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2472 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2473 sockaddr.
2474 (struct ifflag_def): notrailers is smart on OSX.
2475 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2476 Get hardware address with getifaddrs if available.
2477
08fff70c
EZ
24782011-08-12 Eli Zaretskii <eliz@gnu.org>
2479
2480 * xdisp.c (iterate_out_of_display_property): xassert that
2481 IT->position is set to within IT->object's boundaries. Break from
2482 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2483 when IT->position is set up wrongly due to some bug.
2484 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2485 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2486 entry. Force push_it to save on the stack the current
2487 buffer/string position, to be restored by pop_it. Fix flags in
2488 the iterator structure wrt the object coming from a display
2489 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2490 properties. (Bug#9284)
2491
7be1c708 24922011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2493
7be1c708
CY
2494 * fontset.c (fontset_get_font_group): Add proper type checks.
2495 (Bug#9172)
aac0c6e3 2496
7be1c708 24972011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2498
7be1c708
CY
2499 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2500 and LC_VERSION_MIN_MACOSX.
2501 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2502 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2503
97bb72a6
EZ
25042011-08-08 Eli Zaretskii <eliz@gnu.org>
2505
2506 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2507 no-display-properties-and-no-overlays under bidi display.
2508 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2509 properties and overlays.
97bb72a6 2510
d5617611
CY
25112011-08-08 Chong Yidong <cyd@stupidchicken.com>
2512
37e11a63
CY
2513 * editfns.c (Fset_time_zone_rule): Document relationship with the
2514 setenv function.
2515
d5617611
CY
2516 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2517 the font entity extracted from the cache (Bug#8109).
2518
58872834
CY
25192011-08-07 Chong Yidong <cyd@stupidchicken.com>
2520
2521 * composite.c (autocmp_chars): Don't reset point. That is done by
2522 restore_point_unwind (Bug#5984).
2523
75bfc667
JL
25242011-08-07 Juri Linkov <juri@jurta.org>
2525
2526 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2527 to show the arg `TIME' instead of `TIMEVAL'.
2528
d1410150
EZ
25292011-08-06 Eli Zaretskii <eliz@gnu.org>
2530
2531 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2532 display property strides EOL and includes a newline, as in
2533 longlines-mode. (Bug#9254)
75b771e4
EZ
2534 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2535 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2536
2537 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2538 is non-zero, even if the data buffer is NULL. Fixes a crash in
2539 vertical-motion with longlines-mode. (Bug#9254)
2540
35928349
EZ
25412011-08-05 Eli Zaretskii <eliz@gnu.org>
2542
ec7cc85b
EZ
2543 * bidi.c <bidi_cache_total_alloc>: Now static.
2544 (bidi_initialize): Initialize bidi_cache_total_alloc.
2545
8b76d6f8 2546 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2547 cache. (Bug#9221)
2548
2549 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2550 amount allocated this far in `bidi_cache_total_alloc'.
2551 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2552 non-zero, only free the data buffer without restoring the cache
2553 contents. All callers changed.
2554
2555 * dispextern.h (bidi_unshelve_cache): Update prototype.
2556
2557 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2558 (move_it_in_display_line, move_it_to)
2559 (move_it_vertically_backward, move_it_by_lines): Replace the call
2560 to xfree to an equivalent call to bidi_unshelve_cache.
2561 (move_it_in_display_line_to): Fix logic of returning
412b6358 2562 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2563
e2e2423b
EZ
25642011-08-05 Eli Zaretskii <eliz@gnu.org>
2565
2566 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2567 came from a string character with a `cursor' property. (Bug#9229)
2568
ae9e757a
JD
25692011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2570
2571 * Makefile.in (LIB_PTHREAD): New variable.
2572 (LIBES): Add LIB_PTHREAD (Bug#9216).
2573
2574 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2575 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2576
213bd7f2
AS
25772011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2578
6b02f655 2579 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2580
99aaf75f
JD
25812011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2582
2583 * xterm.c (x_find_topmost_parent): New function.
2584 (x_set_frame_alpha): Find topmost parent window with
2585 x_find_topmost_parent and set the property there also (bug#9181).
2586 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2587
c74e9d86
PE
25882011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 * callproc.c (Fcall_process): Avoid vfork clobbering
2591 the local vars buffer, coding_systems, current_dir.
2592
640c8776
SM
25932011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2594
2595 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2596
f26d0e4c
PE
25972011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2598
8a10d76c
PE
2599 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2600 so that it is not optimized away.
2601
f26d0e4c
PE
2602 * xdisp.c (compute_display_string_pos): Remove unused local.
2603
55439c61
EZ
26042011-08-02 Eli Zaretskii <eliz@gnu.org>
2605
2606 Fix slow cursor motion and scrolling in large buffers with
2607 selective display, like Org Mode buffers. (Bug#9218)
2608
2609 * dispextern.h (struct bidi_it): New member disp_prop_p.
2610
2611 * xdisp.c: Remove one-slot cache of display string positions.
2612 (compute_display_string_pos): Accept an additional argument
5e617bc2 2613 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2614 for a display string or property. If found, set DISP_PROP_P
2615 non-zero.
2616
2617 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2618 DISP_PROP_P, and pass it to compute_display_string_pos.
2619 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2620 non-zero. All callers of bidi_fetch_char changed.
2621
fb33fa43
SM
26222011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2623
2624 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2625
b099e063
DM
26262010-12-03 Don March <don@ohspite.net>
2627
2628 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2629 last character M-[char] is translated to ESC [char] (bug#7541).
2630
5cc7f7af
KH
26312011-08-02 Kenichi Handa <handa@m17n.org>
2632
d0fffa3f 2633 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2634
2635 * chartab.c (uniprop_table): Make it non-static.
2636
525d5e6e
EZ
26372011-08-01 Eli Zaretskii <eliz@gnu.org>
2638
2639 * xdisp.c (forward_to_next_line_start): Accept additional argument
2640 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2641 on the newline.
2642 (reseat_at_next_visible_line_start): Use the bidi iterator state
2643 returned by forward_to_next_line_start to restore the state of
2644 it->bidi_it after backing up to previous newline. (Bug#9212)
2645
31011111
AS
26462011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2647
2648 * regex.c (re_comp): Protoize.
2649 (re_exec): Fix return type.
2650 (regexec): Fix type of `ret'. (Bug#9203)
2651
476371c4
PE
26522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2653
e5d76069
PE
2654 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2655 This is needed if max-image-size is a floating-point number.
2656
9a79b20c
AS
26572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2658
2659 * print.c (print_object): Print empty symbol as ##.
2660
2661 * lread.c (read1): Read ## as empty symbol.
2662
d8c2fa78
AA
26632011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2664
2665 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2666 setting frame foreground color (Bug#9175).
2667 (x_set_background_color): Likewise.
2668
ffe57a7a
AA
2669 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2670 contents (Bug#9176).
2671 (EmacsTooltip -init): Remove bezels and add shadows to
2672 tooltip windows.
2673
bf3492a5
AA
2674 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2675 or scroll bar (Bug#8470).
2676
d55e9c53
AA
2677 * nsfont.m (nsfont_open): Remove assignment to voffset and
2678 unnecessary vars hshink, expand, hd, full_height, min_height.
2679 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2680
2681 * nsterm.h (nsfont_info): Remove voffset field.
2682
d8c2fa78 26832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2684
2685 Implement strike-through and overline on NextStep (Bug#8863).
2686
2687 * nsfont.m (nsfont_open): Use underline position provided by font,
2688 instead of hard-coded value of 2.
2689 (nsfont_draw): Call ns_draw_text_decoration instead.
2690
2691 * nsterm.h: Add declaration for ns_draw_text_decoration.
2692
2693 * nsterm.m (ns_draw_text_decoration): New function for drawing
2694 underline, overline, and strike-through.
2695 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2696 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2697 accommodate underlining, etc.
4843aac3 2698
4cc60b9b
EZ
26992011-07-28 Eli Zaretskii <eliz@gnu.org>
2700
bc7ece87
EZ
2701 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2702 default.
4cc60b9b 2703
476371c4
PE
27042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2705
66606eea
PE
2706 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2707 Without this fix, if a signal arrives just after memory fills up,
2708 'malloc' might be invoked reentrantly.
2709
476371c4
PE
2710 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2711 In other words, assume that every image size is allowed, on non-X
2712 hosts. This assumption is probably wrong, but it lets Emacs compile.
2713
f3fcc40d
AS
27142011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2715
2716 * regex.c (re_iswctype): Convert return values to boolean.
2717
350c992f
EZ
27182011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2719
2720 * xdisp.c (compute_display_string_pos): Don't use cached display
2721 string position if the buffer had its restriction changed.
2722 (Bug#9184)
2723
5266b4bb
PE
27242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2727
2573a837 27282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2729
41f55ccd 2730 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2731
39e378da
PE
2732 * bidi.c: Integer size and overflow fixes.
2733 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2734 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2735 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2736 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2737 (bidi_find_other_level_edge):
2738 Use ptrdiff_t instead of EMACS_INT where either will do.
2739 This works better on 32-bit hosts configured --with-wide-int.
2740 (bidi_cache_ensure_space): Check for size-calculation overflow.
2741 Use % rather than repeated addition, for better worst-case speed.
2742 Don't set bidi_cache_size until after xrealloc returns, because it
2743 might not return.
2744 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2745 (bidi_cache_ensure_space): Also check that the bidi cache size
2746 does not exceed that of the largest Lisp string or buffer. See Eli
2747 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2748
5e927815
PE
2749 * alloc.c (__malloc_size_t): Remove.
2750 All uses replaced by size_t. See Andreas Schwab's note
2751 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2752
ca4aa935
PE
2753 * image.c: Improve checking for integer overflow.
2754 (check_image_size): Assume that f is nonnull, since
2755 it is always nonnull in practice. This is one less thing to
2756 worry about when checking for integer overflow later.
2757 (x_check_image_size): New function, which checks for integer
2758 overflow issues inside X.
2759 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2760 This removes the need for a memory_full check.
2761 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2762 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2763 (xbm_read_bitmap_data): Change locals back to 'int', since
2764 their values must fit in 'int'.
2765 (xpm_load_image, png_load, tiff_load):
2766 Invoke x_create_x_image_and_pixmap earlier,
2767 to avoid much needless work if the image is too large.
2768 (tiff_load): Treat overly large images as if
2769 x_create_x_image_and_pixmap failed, not as malloc failures.
2770 (gs_load): Use x_check_image_size.
2771
5f8f9cc2
PE
2772 * gtkutil.c: Omit integer casts.
2773 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2774 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2775
5adf60bc
PE
2776 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2777
c8907a93
PE
2778 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2779 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2780 would wrongly return t on a 64-bit host.
2781
e3c25c68
PE
2782 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2783 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2784 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2785 and therefore cause GCC to emit a bogus diagnostic in some cases.
2786
3f791afe
PE
2787 * image.c: Integer signedness and overflow and related fixes.
2788 This is not an exhaustive set of fixes, but it's time to
2789 record what I've got.
2790 (lookup_pixel_color, check_image_size): Remove redundant decls.
2791 (check_image_size): Don't assume that arbitrary EMACS_INT values
2792 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2793 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2794 (tiff_load, imagemagick_load_image):
2795 Check for overflow in size calculations.
2796 (x_create_x_image_and_pixmap): Remove unnecessary test for
2797 xmalloc returning NULL; that can't happen.
2798 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2799 (xpm_color_bucket): Use better integer hashing function.
2800 (xpm_cache_color): Don't possibly over-allocate memory.
2801 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2802 (gif_memory_source):
2803 Use ptrdiff_t, not int or size_t, to record sizes.
2804 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2805 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2806 either works, as we prefer signed integers.
2807 (tiff_read_from_memory, tiff_write_from_memory):
2808 Return tsize_t, not size_t, since that's what the TIFF API wants.
2809 (tiff_read_from_memory): Don't fail simply because the read would
2810 go past EOF; instead, return a short read.
2811 (tiff_load): Omit no-longer-needed casts.
2812 (Fimagemagick_types): Don't assume size fits into 'int'.
2813
3cc5a532
PE
2814 Improve hashing quality when configured --with-wide-int.
2815 * fns.c (hash_string): New function, taken from sxhash_string.
2816 Do not discard information about ASCII character case; this
2817 discarding is no longer needed.
2818 (sxhash-string): Use it. Change sig to match it. Caller changed.
2819 * lisp.h: Declare it.
2820 * lread.c (hash_string): Remove, since we now use fns.c's version.
2821 The fns.c version returns a wider integer if --with-wide-int is
2822 specified, so this should help the quality of the hashing a bit.
2823
b312a492
PE
2824 * emacs.c: Integer overflow minor fix.
2825 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2826 Define only if GNU_LINUX.
2827 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2828
dfd153ae
PE
2829 * dispnew.c: Integer signedness and overflow fixes.
2830 Remove unnecessary forward decls, that were a maintenance hassle.
2831 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2832 All uses changed.
2833 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2834 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2835 (prepare_desired_row, line_draw_cost):
2836 Use int, not unsigned, where either works.
2837 (save_current_matrix, restore_current_matrix):
2838 Use ptrdiff_t, not size_t, where either works.
2839 (init_display): Check for overflow more accurately, and without
2840 relying on undefined behavior.
2841
a81d11a3
PE
2842 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2843 Remove, replacing with the new symbols in lisp.h. All uses changed.
2844 * fileio.c (make_temp_name):
2845 * filelock.c (lock_file_1, lock_file):
2846 * xdisp.c (message_dolog):
2847 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2848 Use pMd etc. instead.
2849 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2850 replacing the pWIDE etc. symbols removed from editfns.c.
2851
3300e6fd
PE
2852 * keyboard.h (num_input_events): Now uintmax_t.
2853 This is (very slightly) less likely to mess up due to wraparound.
2854 All uses changed.
2855
fd05c7e9
PE
2856 * buffer.c: Integer signedness fixes.
2857 (alloc_buffer_text, enlarge_buffer_text):
2858 Use ptrdiff_t rather than size_t when either will do, as we prefer
2859 signed integers.
2860
903fe15d
PE
2861 * alloc.c: Integer signedness and overflow fixes.
2862 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2863 (__malloc_size_t): Default to size_t, not to int.
2864 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2865 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2866 Prefer ptrdiff_t to size_t when either would do, as we prefer
2867 signed integers.
2868 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2869 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2870 Now const. Initialize with values that are in range even if char
2871 is signed.
2872 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2873 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2874 These functions do the right thing with sizes > 2**32.
2875 (check_depth): Now ptrdiff_t, not int.
2876 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2877 Adjust to new way of storing sizes. Check for size overflow bugs
2878 in rest of code.
2879 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2880 slightly wrong anyway, as it missed one instance of
2881 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2882 (refill_memory_reserve): Omit needless cast to size_t.
2883 (mark_object_loop_halt): Mark as externally visible.
2884
ac82cc6a
PE
2885 * xselect.c: Integer signedness and overflow fixes.
2886 (Fx_register_dnd_atom, x_handle_dnd_message):
2887 Use ptrdiff_t, not size_t, since we prefer signed.
2888 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2889 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2890 x_dnd_atoms_size and x_dnd_atoms_length.
2891
c2d1e36d
PE
2892 * doprnt.c: Prefer signed to unsigned when either works.
2893 * eval.c (verror):
2894 * doprnt.c (doprnt):
2895 * lisp.h (doprnt):
2896 * xdisp.c (vmessage):
2897 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2898 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2899 prefer signed arithmetic to avoid comparison confusion.
2900 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2901 but is a bit tricky.
2902
0e926e56
PE
2903 Assume freestanding C89 headers, string.h, stdlib.h.
2904 * data.c, doprnt.c, floatfns.c, print.c:
2905 Include float.h unconditionally.
2906 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2907 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2908 * regex.c: Likewise for stddef.h, string.h.
2909 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2910 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2911 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2912 (STDC_HEADERS): Remove obsolete defines.
2913 * sysdep.c: Include limits.h unconditionally.
2914
9cfdb3ec
PE
2915 Assume support for memcmp, memcpy, memmove, memset.
2916 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2917 * regex.c (memcmp, memcpy):
2918 Remove; we assume C89 now.
2919
2920 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2921 (__malloc_safe_bcopy): Remove; no longer needed.
2922
cf950e6b 2923 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2924 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2925 well either way, and we prefer signed to unsigned.
2926
dbf38e02
LMI
29272011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2928
2929 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2930 closes the connection while we're reading (bug#9182).
2931
d6f0886c 29322011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2933
d6f0886c
JD
2934 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2935 are specified (Bug#9168).
24e0f6b1 2936
2eb1f9e6
PE
29372011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2938
2939 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2940 Found by GCC static checking and --with-wide-int on a 32-bit host.
2941
22381272 29422011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2943
2944 * xdisp.c (compute_display_string_pos): Fix logic of caching
2945 previous display string position. Initialize cached_prev_pos to
2946 -1. Fixes slow-down at the beginning of a buffer.
2947
f25e39b4
EZ
29482011-07-24 Eli Zaretskii <eliz@gnu.org>
2949
2950 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2951 for attrs[LFACE_FONTSET_INDEX].
2952
04c4b52e
PE
29532011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2954
2955 * xml.c (parse_region): Remove unused local
2956 that was recently introduced.
2957
c1734fbd
EZ
29582011-07-23 Eli Zaretskii <eliz@gnu.org>
2959
be18c5a5
EZ
2960 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2961 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2962
c1734fbd
EZ
2963 * xdisp.c (move_it_in_display_line_to): Record the best matching
2964 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2965 exit if none of the characters scanned was an exact match.
2966 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2967 when exact match is impossible due to invisible text, and the
2968 lines are truncated.
2969
a258d627
JD
29702011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2971
2972 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2973 for OSX >= 10.7.
2974
b6d5a689
EZ
29752011-07-22 Eli Zaretskii <eliz@gnu.org>
2976
0f74f785
EZ
2977 Fix a significant slow-down of cursor motion with C-n, C-p,
2978 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2979 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2980 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2981 (next_element_from_buffer): Call compute_stop_pos_backwards to
2982 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2983 base_level_stop.
2984 (reseat): Don't look for prev_stop, as that could mean a very long
2985 run.
2986 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2987 <cached_disp_overlay_modiff>: Cache for last found display string
2988 position.
551918c1 2989 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2990 about the same buffer in the same area of character positions, and
2991 the buffer wasn't changed since the time the display string
2992 position was cached.
551918c1 2993
b2d0c91a
EZ
29942011-07-22 Eli Zaretskii <eliz@gnu.org>
2995
2996 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2997 is an integer, which is important for empty lines. (Bug#9149)
2998
043604ee
CY
29992011-07-22 Chong Yidong <cyd@stupidchicken.com>
3000
3001 * frame.c (Fmodify_frame_parameters): In tty case, update the
3002 default face if necessary (Bug#4238).
3003
da4adb04
CY
30042011-07-21 Chong Yidong <cyd@stupidchicken.com>
3005
3006 * editfns.c (Fstring_to_char): No need to explain what a character
3007 is in the docstring (Bug#6576).
3008
9abd0532
LMI
30092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3010
3011 * xml.c (parse_region): Make sure we always return a tree.
3012
36881d16
HK
30132011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3014
3015 * xml.c (parse_region): If a document contains only comments,
3016 return that, too.
3017
1e98674d
LMI
30182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3019
3020 * xml.c (make_dom): Return comments, too.
3021
590bd467
PE
30222011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3023
3024 Port to OpenBSD.
3025 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3026 and the surrounding thread.
3027 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3028 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3029 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3030 timer goes off.
3031 * s/openbsd.h (BROKEN_SIGIO): Define.
3032 * unexelf.c (unexec) [__OpenBSD__]:
3033 Don't update the .mdebug section of the Alpha COFF symbol table.
3034
f41628b2
LMI
30352011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3036
3037 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3038 (bug#8460).
3039
b59b67c5
PE
30402011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3041
15e3a074
PE
3042 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3043 This fixes some race conditions on the permissions of any newly
3044 created file.
3045
41bed37d
PE
3046 * alloc.c (valid_pointer_p): Use pipe, not open.
3047 This fixes some permissions issues when debugging.
3048
b59b67c5
PE
3049 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3050 If fchown fails to set both uid and gid, try to set just gid,
3051 as that is sometimes allowed. Adjust the file's mode to eliminate
3052 setuid or setgid bits that are inappropriate if fchown fails.
3053
925a6be7
SM
30542011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3055
3056 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3057 to compare Lisp_Objects.
3058 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3059 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3060 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3061
52968808
AS
30622011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3063
0a6a104b
AS
3064 * lread.c (read_integer): Unread even EOF character.
3065 (read1): Likewise. Properly record start position of symbol.
3066
52968808
AS
3067 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3068 symbol character follows.
3069
9e381cdd
PE
30702011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3071
3072 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3073 This works around a problem with the previous change to Fcopy_file.
3074 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3075 and without this change, GCC might complain about discarding
3076 fchown's return value.
3077
b5641435
JB
30782011-07-16 Juanma Barranquero <lekktu@gmail.com>
3079
3080 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3081
a8031457
PE
30822011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3083
3084 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3085
dd889327
LMI
30862011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3087
750c33f7
LMI
3088 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3089 it's used from the C level.
3090
dd889327
LMI
3091 * process.c: Use the same condition for POLL_FOR_INPUT in both
3092 keyboard.c and process.c (bug#1858).
3093
87e86684
LM
30942011-07-09 Lawrence Mitchell <wence@gmx.li>
3095
3096 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3097 (Fgnutls_boot): Use it.
3098
64348f40
AS
30992011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3100
3101 * doc.c (Fsubstitute_command_keys): Revert last change.
3102
1d698799
LMI
31032011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3104
f863868c
LMI
3105 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3106 quotes the next character, and doesn't affect other longer
3107 sequences (bug#8935).
3108
1d698799
LMI
3109 * lread.c (syms_of_lread): Clarify that is isn't only
3110 `eval-buffer' and `eval-defun' that's affected by
3111 `lexical-binding' (bug#8460).
3112
aa4b6df6
EZ
31132011-07-15 Eli Zaretskii <eliz@gnu.org>
3114
3115 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3116 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3117
5d856da6
PE
31182011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3119
ad6042bb
PE
3120 Fix minor problems found by static checking.
3121 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3122 (elsz): Now a signed constant, not a size_t var. We prefer signed
3123 types to unsigned, to avoid integer comparison confusion. Without
3124 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3125 "cannot optimize loop, the loop counter may overflow", a symptom
3126 of the confusion.
f00bbb22 3127 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3128 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3129
6468f31c
LMI
31302011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3131
49080b10
LMI
3132 * search.c (Fre_search_backward): Mention `case-fold-search' in
3133 all the re_search_* functions (bug#8138).
3134
6468f31c
LMI
3135 * keyboard.c (Fopen_dribble_file): Document when the file is
3136 closed (bug#8056).
3137
c965adc5
EZ
31382011-07-14 Eli Zaretskii <eliz@gnu.org>
3139
df9733bf
EZ
3140 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3141 bidi_cache_idx.
3142
0bb23927
EZ
3143 Support bidi reordering of display and overlay strings.
3144 * xdisp.c (compute_display_string_pos)
3145 (compute_display_string_end): Accept additional argument STRING.
3146 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3147 (reseat_to_string): Initialize bidi_it->string.s and
3148 bidi_it->string.schars.
3149 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3150 NULL (avoids a crash in bidi_paragraph_init).
3151 Initialize itb.string.lstring.
0bb23927
EZ
3152 (init_iterator): Call bidi_init_it only of a valid
3153 buffer position was specified. Initialize paragraph_embedding to
3154 L2R.
3155 (reseat_to_string): Initialize the bidi iterator.
3156 (display_string): If we need to ignore text properties of
3157 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3158 original value of -1 will not work with bidi.)
3159 (compute_display_string_pos): First arg is now struct
3160 `text_pos *'; all callers changed. Support display properties on
3161 Lisp strings.
3162 (compute_display_string_end): Support display properties on Lisp
3163 strings.
3164 (init_iterator, reseat_1, reseat_to_string): Initialize the
3165 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3166 when iterating on a string not from display properties).
640c8776
SM
3167 (compute_display_string_pos, compute_display_string_end):
3168 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3169 arrow keys.
3170 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3171 base_level_stop; instead, set base_level_stop to BEGV.
3172 Fixes crashes in vertical-motion.
0bb23927
EZ
3173 (next_element_from_buffer): Improve commentary for when
3174 the iterator is before prev_stop.
3175 (init_iterator): Initialize bidi_p from the default value of
3176 bidi-display-reordering, not from buffer-local value. Use the
3177 buffer-local value only if initializing for buffer iteration.
3178 (handle_invisible_prop): Support invisible properties on strings
3179 that are being bidi-reordered.
3180 (set_iterator_to_next): Support bidi reordering of C strings and
3181 Lisp strings.
3182 (next_element_from_string): Support bidi reordering of Lisp
3183 strings.
3184 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3185 (display_string): Support display of R2L glyph rows.
3186 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3187 (init_iterator): Don't initialize it->bidi_p for strings
3188 here.
3189 (reseat_to_string): Initialize it->bidi_p for strings here.
3190 (next_element_from_string, next_element_from_c_string)
3191 (next_element_from_buffer): Add xassert's for correspondence
3192 between IT's object being iterated and it->bidi_it.string
3193 structure.
3194 (face_before_or_after_it_pos): Support bidi iteration.
3195 (next_element_from_c_string): Handle the case of the first string
3196 character that is not the first one in the visual order.
3197 (get_visually_first_element): New function, refactored from common
3198 parts of next_element_from_buffer, next_element_from_string, and
3199 next_element_from_c_string.
3200 (tool_bar_lines_needed, redisplay_tool_bar)
3201 (display_menu_bar): Force left-to-right direction. Add a FIXME
3202 comment for making that be controlled by a user option.
3203 (push_it, pop_it): Save and restore the state of the
3204 bidi iterator. Save and restore the bidi_p flag.
3205 (pop_it): Iterate out of display property for string iteration as
3206 well.
3207 (iterate_out_of_display_property): Support iteration over strings.
3208 (handle_single_display_spec): Set up it->bidi_it for iteration
3209 over a display string, and call bidi_init_it.
3210 (handle_single_display_spec, next_overlay_string)
3211 (get_overlay_strings_1, push_display_prop): Set up the bidi
3212 iterator for displaying display or overlay strings.
3213 (forward_to_next_line_start): Don't use the shortcut if
3214 bidi-iterating.
3215 (back_to_previous_visible_line_start): If handle_display_prop
3216 pushed the iterator stack, restore the internal state of the bidi
3217 iterator by calling bidi_pop_it same number of times.
3218 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3219 and we are bidi-iterating, don't decrement the iterator position;
3220 instead, set the first_elt flag in the bidi iterator, to produce
3221 the same effect.
3222 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3223 (push_display_prop): xassert that we are iterating a buffer.
3224 (push_it, pop_it): Save and restore paragraph_embedding member.
3225 (handle_single_display_spec, next_overlay_string)
3226 (get_overlay_strings_1, reseat_1, reseat_to_string)
3227 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3228 correctly. Don't assume unibyte strings are not bidi-reordered.
3229 (compute_display_string_pos)
3230 (compute_display_string_end): Fix handling the case of C string.
3231 (push_it, pop_it): Save and restore from_disp_prop_p.
3232 (handle_single_display_spec, push_display_prop): Set the
3233 from_disp_prop_p flag.
3234 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3235 (pop_it): Call iterate_out_of_display_property only if we are
3236 popping after iteration over a string that came from a display
3237 property. Fix a typo in popping stretch info. Add an assertion
3238 for verifying that the iterator position is in sync with the bidi
3239 iterator.
3240 (handle_single_display_spec, get_overlay_strings_1)
3241 (push_display_prop): Fix initialization of paragraph direction for
3242 string when that of the parent object is not yet determined.
3243 (reseat_1): Call bidi_init_it to resync the bidi
3244 iterator with IT's position. (Bug#7616)
3245 (find_row_edges): If ROW->start.pos gives position
3246 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3247 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3248 Reset the from_disp_prop_p flag.
3249 (SAVE_IT, RESTORE_IT): New macros.
3250 (pos_visible_p, face_before_or_after_it_pos)
3251 (back_to_previous_visible_line_start)
3252 (move_it_in_display_line_to, move_it_in_display_line)
3253 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3254 (try_scrolling, redisplay_window, display_line): Use them when
3255 saving a temporary copy of the iterator and restoring it back.
3256 (back_to_previous_visible_line_start, reseat_1)
3257 (init_iterator): Empty the bidi cache "stack".
3258 (move_it_in_display_line_to): If iterator ended up at
3259 EOL, but we never saw any buffer positions smaller than
3260 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3261 motion in bidi-reordered lines.
3262 (move_it_in_display_line_to): Record prev_method and prev_pos
3263 immediately before the call to set_iterator_to_next. Fixes cursor
3264 motion in bidi-reordered lines with stretch glyphs and strings
3265 displayed in margins. (Bug#8133) (Bug#8867)
3266 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3267 TO_CHARPOS.
640c8776
SM
3268 (pos_visible_p): Support positions in bidi-reordered lines.
3269 Save and restore bidi cache.
0bb23927
EZ
3270
3271 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3272 (bidi_paragraph_info): Delete unused struct.
3273 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3274 (bidi_cache_start): New variable.
3275 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3276 to zero.
3277 (bidi_cache_fetch_state, bidi_cache_search)
3278 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3279 (bidi_cache_find, bidi_peek_at_next_level)
3280 (bidi_level_of_next_char, bidi_find_other_level_edge)
3281 (bidi_move_to_visually_next): Compare cache index with
3282 bidi_cache_start rather than with zero.
3283 (bidi_fetch_char): Accept new argument STRING; all callers
3284 changed. Support iteration over a string. Support strings with
3285 display properties. Support unibyte strings. Fix the type of
3286 `len' according to what STRING_CHAR_AND_LENGTH expects.
3287 (bidi_paragraph_init, bidi_resolve_explicit_1)
3288 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3289 (bidi_level_of_next_char, bidi_move_to_visually_next):
3290 Support iteration over a string.
0bb23927
EZ
3291 (bidi_set_sor_type, bidi_resolve_explicit_1)
3292 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3293 can now be zero (for strings); special values 0 and -1 were
3294 changed to -1 and -2, respectively.
3295 (bidi_char_at_pos): New function.
3296 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3297 Call it instead of FETCH_MULTIBYTE_CHAR.
3298 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3299 initialized to valid values.
3300 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3301 values.
3302 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3303 the test for valid cached positions. Fix the logic for looking up
3304 the sentinel state in the cache. GCPRO the Lisp string we are
3305 iterating.
3306 (bidi_push_it, bidi_pop_it): New functions.
3307 (bidi_initialize): Initialize the bidi cache start stack pointer.
3308 (bidi_cache_ensure_space): New function, refactored from part of
3309 bidi_cache_iterator_state. Don't assume the required size is just
3310 one BIDI_CACHE_CHUNK away.
3311 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3312 (bidi_count_bytes, bidi_char_at_pos): New functions.
3313 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3314 always valid if bidi_cache_idx is valid.
3315 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3316 is valid if it's going to be used.
3317 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3318 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3319 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3320 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3321 (bidi_find_other_level_edge, bidi_cache_start_stack):
3322 All variables related to cache indices are now EMACS_INT.
c965adc5 3323
0bb23927
EZ
3324 * dispextern.h (struct bidi_string_data): New structure.
3325 (struct bidi_it): New member `string'. Make flag members be 1-bit
3326 fields, and put them last in the struct.
640c8776
SM
3327 (compute_display_string_pos, compute_display_string_end):
3328 Update prototypes.
0bb23927
EZ
3329 (bidi_push_it, bidi_pop_it): Add prototypes.
3330 (struct iterator_stack_entry): New members bidi_p,
3331 paragraph_embedding, and from_disp_prop_p.
3332 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3333 (bidi_shelve_cache, bidi_unshelve_cache):
3334 Declare prototypes.
0bb23927
EZ
3335
3336 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3337 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3338 and vector-like objects.
3339
3340 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3341 cache around display iteration.
3342
3343 * window.c (Fwindow_end, window_scroll_pixel_based)
3344 (displayed_window_lines, Frecenter): Save and restore the bidi
3345 cache around display iteration.
3346
3bbd2265
LMI
33472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3348
3349 * editfns.c (Fdelete_region): Clarify the use of the named
3350 parameters (bug#6788).
3351
adc47434
MR
33522011-07-14 Martin Rudalics <rudalics@gmx.at>
3353
3354 * indent.c (Fvertical_motion): Set and restore w->pointm when
3355 saving and restoring the window's buffer (Bug#9006).
3356
837c31f8
LMI
33572011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3358
3359 * editfns.c (Fstring_to_char): Clarify just what is returned
3360 (bug#6576). Text by Eli Zaretskii.
3361
ac389d0c
JB
33622011-07-13 Juanma Barranquero <lekktu@gmail.com>
3363
3364 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3365
0be0ce47
EZ
33662011-07-13 Eli Zaretskii <eliz@gnu.org>
3367
3368 * buffer.c (mmap_find): Fix a typo.
3369
cd18e7e3
JB
33702011-07-13 Johan Bockgård <bojohan@gnu.org>
3371
3372 Fix execution of x selection hooks.
3373 * xselect.c (Qx_lost_selection_functions)
3374 (Qx_sent_selection_functions): New vars.
3375 (syms_of_xselect): DEFSYM them.
3376 (x_handle_selection_request): Pass Qx_sent_selection_functions
3377 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3378 (x_handle_selection_clear,x_clear_frame_selections):
3379 Pass Qx_lost_selection_functions rather than
3380 Vx_lost_selection_functions to Frun_hook_with_args.
3381
47ea7f44
PE
33822011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3383
ac389d0c 3384 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3385 The old code sometimes used this field without initializing it.
3386
47ea7f44
PE
3387 * alloc.c (gc_sweep): Don't read past end of array.
3388 In theory, the old code could also have corrupted Emacs internals,
3389 though it'd be very unlikely.
3390
bc985c87
AS
33912011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3392
3393 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3394 argument. (Bug#4026)
bc985c87 3395
0cf34688
LMI
33962011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3397
b3dadd76
LMI
3398 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3399 key" (bug#4257).
3400
0cf34688
LMI
3401 * window.c (Fset_window_start): Doc fix (bug#4199).
3402 (Fset_window_hscroll): Ditto.
3403
270768cd
PE
34042011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3405
077e3dda 3406 Fix minor new problems caught by GCC 4.6.1.
270768cd 3407 * term.c (init_tty): Remove unused local.
490011a6 3408 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3409 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3410 not used otherwise.
270768cd 3411
b1f58454
CY
34122011-07-12 Chong Yidong <cyd@stupidchicken.com>
3413
3414 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3415
22b9578d
LMI
34162011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3417
6e70ab07
LMI
3418 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3419 are the mini-buffer and the echo area (bug#3320).
3420
22b9578d
LMI
3421 * term.c (init_tty): Remove support for supdup, c10 and perq
3422 terminals, which are no longer supported (bug#1482).
3423
8974cc9f
JB
34242011-07-10 Johan Bockgård <bojohan@gnu.org>
3425
3426 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3427
a560d974
JD
34282011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3429
3430 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3431 for non-popups (Bug#3642).
3432
1dae0f0a
AS
34332011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3434
268c2c36 3435 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3436 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3437 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3438 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3439 * data.c (fmod): Likewise.
3440 * dispnew.c (swap_glyphs_in_rows): Likewise.
3441 * emacs.c (memory_warning_signal): Likewise.
3442 * floatfns.c (float_error): Likewise.
3443 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3444 (otf_open, font_otf_capability, generate_otf_features)
3445 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3446 Likewise.
3447 * image.c (pbm_read_file): Likewise.
3448 * indent.c (string_display_width): Likewise.
3449 * intervals.c (check_for_interval, search_for_interval)
3450 (inc_interval_count, count_intervals, root_interval)
3451 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3452 * lread.c (defalias): Likewise.
268c2c36 3453 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3454 * regex.c (set_image_of_range_1, set_image_of_range)
3455 (regex_grow_registers): Likewise.
3456 * sysdep.c (strerror): Likewise.
3457 * termcap.c (valid_filename_p, tprint, main): Likewise.
3458 * tparam.c (main): Likewise.
3459 * unexhp9k800.c (run_time_remap, save_data_space)
3460 (update_file_ptrs, read_header, write_header, calculate_checksum)
3461 (copy_file, copy_rest, display_header): Likewise.
3462 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3463 Likewise.
3464 * xdisp.c (check_it): Likewise.
3465 * xfaces.c (register_color, unregister_color, unregister_colors):
3466 Likewise.
3467 * xfns.c (print_fontset_result): Likewise.
3468 * xrdb.c (member, fatal, main): Likewise.
3469
99033785
PE
34702011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3471
3472 Fix minor problems found by static checking (Bug#9031).
3473 * chartab.c (char_table_set_range, map_sub_char_table):
3474 Remove unused locals.
3475 (uniprop_table): Now static.
3476 * composite.c (_work_char): Remove unused static var.
3477
9cb2ac56
JB
34782011-07-09 Juanma Barranquero <lekktu@gmail.com>
3479
3480 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3481
f25661f0
JD
34822011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3483
3484 * gtkutil.c (qttip_cb): Remove code without function.
3485
8278c4fe
EZ
34862011-07-09 Eli Zaretskii <eliz@gnu.org>
3487
3488 * w32.c (pthread_sigmask): New stub.
3489
1692ae2d 34902011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3491
8a6ebd58 3492 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3493 sigprocmask is portable only for single-threaded applications, and
3494 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3495 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3496 (LIBES): Use it.
3497 * callproc.c (Fcall_process):
3498 * process.c (create_process):
3499 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3500 Use pthread_sigmask, not sigprocmask.
123403e4 3501
1b854618
JD
35022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3503
3504 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3505 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3506 wrong (Bug#8591).
3507
3fe4b549
JD
35082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3509
0ce7e563
JD
3510 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3511 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3512 (xg_hide_tooltip): Fix comment.
3513
3fe4b549
JD
3514 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3515 in registerServicesMenuSendTypes.
3516 (validRequestorForSendType): Don't check ns_return_types.
3517
3518 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3519 ns_return_type.
3520
5df75e47
JR
35212011-07-08 Jason Rumney <jasonr@gnu.org>
3522
22610910
JR
3523 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3524 SH_SHOW for hidden windows (Bug#5482).
3525
5df75e47
JR
3526 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3527 frame struct members of non-existent frames (Bug#6284).
3528
699c10bd
JD
35292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3530
4393663b
JD
3531 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3532 variable firstTime not needed on OSX >= 10.6.
3533 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3534 >= 10.5. Use setKnobProportion, setDoubleValue.
3535
3536 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3537 (MAC_OS_X_VERSION_10_5): Define if not defined.
3538 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3539 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3540 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3541
3542 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3543 cString and lossyCString on OSX >= 10.4
3544
58179cce 3545 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3546 sizeToFit on OSX >= 10.2.
3547
3548 * nsimage.m (allocInitFromFile): Don't use deprecated method
3549 bestRepresentationForDevice on OSX >= 10.6.
3550
3551 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3552 to avoid warning.
3553
3554 * emacs.c: Declare unexec_init_emacs_zone.
3555
a63e0781
JD
3556 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3557
699c10bd
JD
3558 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3559
3560 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3561 on svcsMenu (Bug#8842).
3562
3563 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3564 ns_return_types.
3565 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3566
3567 * nsterm.m (QUTF8_STRING): Declare.
3568 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3569 (validRequestorForSendType): Return type is (id).
3570 Change indexOfObjectIdenticalTo to indexOfObject.
3571 Check if we have local selection before returning self (Bug#8842).
3572 (writeSelectionToPasteboard): Put local selection into paste board
3573 if we have a local selection (Bug#8842).
3574 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3575
3576 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3577 (ns_get_local_selection): Declare.
3578
54e10184
LMI
35792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580
9888ff71
LMI
3581 * keymap.c (describe_map_tree): Don't insert a double newline at
3582 the end of the buffer (bug#1169) and return whether we inserted
3583 something.
3584
54e10184
LMI
3585 * callint.c (Fcall_interactively): Change "reading args" to
3586 "providing args" to try to clarify what it does (bug#1010).
3587
15fa4783
KH
35882011-07-07 Kenichi Handa <handa@m17n.org>
3589
3590 * composite.c (composition_compute_stop_pos): Ignore a static
3591 composition starting before CHARPOS (Bug#8915).
3592
3593 * xdisp.c (handle_composition_prop): Likewise.
3594
a8815b00
EZ
35952011-07-07 Eli Zaretskii <eliz@gnu.org>
3596
3597 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3598 (Bug#9015)
3599
ef7b981d 36002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3601
3602 * character.h (unicode_category_t): New enum type.
3603
3604 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3605 (Qchar_code_property_table): New variable.
3606 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3607 (UNIPROP_COMPRESSED_FORM_P): New macros.
3608 (char_table_ascii): Uncompress the compressed values.
3609 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3610 Uncompress the compressed values.
ac389d0c 3611 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3612 (char_table_ref_and_range): Uncompress the compressed values.
3613 (sub_char_table_set): New arg is_uniprop. Callers changed.
3614 Uncompress the compressed values.
3615 (sub_char_table_set_range): Args changed. Callers changed.
3616 (char_table_set_range): Adjuted for the above change.
3617 (map_sub_char_table): Delete args default_val and parent. Add arg
3618 top. Give decoded values to a Lisp function.
640c8776 3619 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3620 values to a Lisp function. Gcpro more variables.
3621 (uniprop_table_uncompress)
3622 (uniprop_decode_value_run_length): New functions.
3623 (uniprop_decoder, uniprop_decoder_count): New variables.
3624 (uniprop_get_decoder, uniprop_encode_value_character)
3625 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3626 New functions.
3627 (uniprop_encoder, uniprop_encoder_count): New variables.
3628 (uniprop_get_encoder, uniprop_table)
3629 (Funicode_property_table_internal, Fget_unicode_property_internal)
3630 (Fput_unicode_property_internal): New functions.
3631 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3632 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3633 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3634 char-code-property-alist.
3635
640c8776 3636 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3637 Vunicode_category_table.
3638
640c8776 3639 * font.c (font_range): Adjust for the change of
c805dec0
KH
3640 Vunicode_category_table.
3641
76b397fb
DN
36422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3643
3644 * m/iris4d.h: Remove file, move contents ...
3645 * s/irix6-5.h: ... here.
3646
22b4128e
PE
36472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3648
3649 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3650 * alloc.c (mark_buffer):
3651 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3652 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3653 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3654 This isn't true in general, and it's particularly not true
3655 if Emacs is configured with --with-wide-int.
3656 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3657 New macros, used in the buffer.c change.
3658
869795d6
JD
36592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3660
3661 * xsettings.c: Use both GConf and GSettings if both are available.
3662 (store_config_changed_event): Add comment.
3663 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3664 (store_tool_bar_style_changed): New functions.
5e617bc2 3665 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3666 (struct xsettings): Move font inside HAVE_XFT.
3667 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3668 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3669 Move inside HAVE_XFT.
640c8776 3670 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3671 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3672 also.
3673 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3674 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3675 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3676 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3677 (parse_settings): Move check for font inside HAVE_XFT.
3678 (read_settings, apply_xft_settings): Add comment.
3679 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3680 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3681 call store_font_name_changed.
3682 (xft_settings_event): Add comment.
3683 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3684 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3685 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3686 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3687 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3688 (xsettings_get_system_font, xsettings_get_system_normal_font):
3689 Add comment.
869795d6 3690
d8ed26bd
PE
36912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3692
3693 Random fixes. E.g., (random) never returned negative values.
3694 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3695 subseconds part to the entropy, as that's a bit more random.
3696 Prefer signed to unsigned, since the signedness doesn't matter and
3697 in general we prefer signed. When given a limit, use a
3698 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3699 latter isn't right if USE_2_TAGS_FOR_INTS.
3700 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3701 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3702
cabf1cac
SM
37032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3704
3705 * textprop.c (text_property_stickiness):
3706 Obey Vtext_property_default_nonsticky.
3707 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3708 * w32fns.c (syms_of_w32fns):
3709 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3710
6e9b2be9
PE
37112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3712
3713 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3714 This is more efficient than Ffile_directory_p and avoids a minor race.
3715
90186c68
LMI
37162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3717
7c301272
LMI
3718 * buffer.c (Foverlay_put): Say what the return value is
3719 (bug#7835).
3720
c4f2d8d4
LMI
3721 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3722 is a directory before asking whether to use the file name
3723 (bug#7564).
ad637907
LMI
3724 (barf_or_query_if_file_exists): Make the "File is a directory"
3725 error be more correct.
c4f2d8d4 3726
90186c68
LMI
3727 * fns.c (Frequire): Remove the mention of the .gz files, since
3728 that's installation-specific, but keep the mention of
3729 `get-load-suffixes'.
3730
da64016e
PE
37312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3734 Report string overflow if the output is too long.
3735
7d47b580
JB
37362011-07-04 Juanma Barranquero <lekktu@gmail.com>
3737
a555cb87
JB
3738 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3739 (syms_of_gnutls): Remove duplicate DEFSYM for
3740 Qgnutls_bootprop_verify_hostname_error, an error for
3741 Qgnutls_bootprop_verify_error (which is no longer used).
3742
7d47b580
JB
3743 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3744 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3745 Also (re)move comments that are misplaced or no longer relevant.
3746
1e49bfab
LMI
37472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3748
3749 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3750
1485f4c0
CY
37512011-07-03 Chong Yidong <cyd@stupidchicken.com>
3752
3753 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3754 and background color parameters if they have been changed.
3755
a9ab721e
LMI
37562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3757
3758 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3759
cf7cff57
PE
37602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3761
2e13213d
PE
3762 * xsettings.c (SYSTEM_FONT): Define only when used.
3763 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3764
cf7cff57
PE
3765 * keymap.c (access_keymap_1): Now static.
3766
7a8e04f7
CY
37672011-07-02 Chong Yidong <cyd@stupidchicken.com>
3768
3769 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3770 leave any prefix arg for the up event (Bug#1586).
3771
61352f62
LMI
37722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3773
69bb1ef7
LMI
3774 * lread.c (syms_of_lread): Mention single symbols defined by
3775 `defvar' or `defconst' (bug#7154).
3776
61352f62 3777 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3778 (Frequire): Mention get-load-suffixes.
61352f62 3779
28545e04
MR
37802011-07-02 Martin Rudalics <rudalics@gmx.at>
3781
3782 * window.h (window): Remove clone_number slot.
3783 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3784 Remove.
3785 (make_parent_window, make_window, saved_window)
3786 (Fset_window_configuration, save_window_save): Don't deal with
3787 clone numbers.
3788 * buffer.c (Qclone_number): Remove declaration.
3789 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3790
3349e122
SM
37912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3792
3793 Add multiple inheritance to keymaps.
3794 * keymap.c (Fmake_composed_keymap): New function.
3795 (Fset_keymap_parent): Simplify.
3796 (fix_submap_inheritance): Remove.
3797 (access_keymap_1): New function extracted from access_keymap to handle
3798 embedded parents and handle lists of maps.
3799 (access_keymap): Use it.
3800 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3801 (Fcopy_keymap): Handle embedded parents.
3802 (Fcommand_remapping, define_as_prefix): Simplify.
3803 (Fkey_binding): Simplify.
3804 (syms_of_keymap): Move minibuffer-local-completion-map,
3805 minibuffer-local-filename-completion-map,
3806 minibuffer-local-must-match-map, and
3807 minibuffer-local-filename-must-match-map to Elisp.
3808 (syms_of_keymap): Defsubr make-composed-keymap.
3809 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3810 (parse_menu_item): Trivial simplification.
3811
3279eb87
GM
38122011-07-01 Glenn Morris <rgm@gnu.org>
3813
3814 * Makefile.in (SETTINGS_LIBS): Fix typo.
3815
4550efdf
KI
38162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3817
3818 * coding.c (Fencode_coding_string): Record the last coding system
3819 used, as the function doc string says (bug#8738).
3820
0949d2b6
JD
38212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * xsettings.c (store_monospaced_changed): Take new font as arg and
3824 check for change against current_mono_font.
3825 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3826 (emacs_settings_constructor, emacs_settings_get_property)
3827 (emacs_settings_set_property, emacs_settings_class_init)
3828 (emacs_settings_init, gsettings_obj): Remove.
3829 (something_changedCB): New function for HAVE_GSETTINGS.
3830 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3831 with value as argument.
3832 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3833 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3834 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3835 "changed".
3836
3837 * xgselect.c: Add defined (HAVE_GSETTINGS).
3838 (xgselect_initialize): Ditto.
3839
3840 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3841 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3842 xg_select.
3843
bbc6b304
PE
38442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 * eval.c (struct backtrace): Simplify and port the data structure.
3847 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3848 signed bit field, as this assumption is not portable and it makes
3849 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3850 "char debug_on_exit : 1" as this is not portable either; instead,
3851 use the portable "unsigned int debug_on_exit : 1". Remove unused
3852 member evalargs. Remove obsolete comments about cc bombing out.
3853
9851bfc5
JD
38542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3855
51bb811f 3856 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3857 Let HAVE_GSETTINGS override HAVE_GCONF.
3858 (store_monospaced_changed): New function.
3859 (EMACS_SETTINGS): A new type derived from GObject to handle
3860 GSettings notifications.
3861 (emacs_settings_constructor, emacs_settings_get_property)
3862 (emacs_settings_set_property, emacs_settings_class_init):
3863 New functions.
3864 (gsettings_client, gsettings_obj): New variables.
3865 (GSETTINGS_SCHEMA): New define.
3866 (something_changedCB): Call store_monospaced_changed.
3867 (init_gsettings): New function.
3868 (xsettings_initialize): Call init_gsettings.
3869 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3870 to NULL.
3871
640c8776 3872 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3873 GCONF_CFLAGS/LIBS.
3874
5386012d
MR
38752011-06-29 Martin Rudalics <rudalics@gmx.at>
3876
3877 * window.c (resize_root_window, grow_mini_window)
3878 (shrink_mini_window): Rename Qresize_root_window to
3879 Qwindow_resize_root_window and Qresize_root_window_vertically to
3880 Qwindow_resize_root_window_vertically.
3881
f13e0b08
PE
38822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3883
3884 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3885
94515237
JB
38862011-06-27 Juanma Barranquero <lekktu@gmail.com>
3887
3888 * makefile.w32-in: Redesign dependencies so they reflect more
3889 clearly which files are directly included by each source file,
3890 and not through other includes.
3891
e43b6e43
MR
38922011-06-27 Martin Rudalics <rudalics@gmx.at>
3893
3894 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3895 (sort_overlays, overlay_strings): When an overlay's clone number
3896 matches the window's clone number process the overlay even if
3897 the overlay's window property doesn't match the current window.
3898
d68443dc
MR
3899 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3900 (Fwindow_hchild): Rename to Fwindow_left_child.
3901 (Fwindow_next): Rename to Fwindow_next_sibling.
3902 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3903 (resize_window_check): Rename to window_resize_check.
3904 (resize_window_apply): Rename to window_resize_apply.
3905 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3906 (Fdelete_other_windows_internal, resize_frame_windows)
3907 (Fsplit_window_internal, Fdelete_window_internal)
3908 (grow_mini_window, shrink_mini_window)
3909 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3910
c7e73be5
JD
39112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3912
3913 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3914 (emacs_fixed_set_min_size): Remove.
3915 (emacs_fixed_new): Take frame as argument.
3916
3917 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3918 (_EmacsFixedPrivate): Remove minwidth/height.
3919 Add struct frame *f.
3920 (emacs_fixed_init): Initialize priv->f.
3921 (get_parent_class, emacs_fixed_set_min_size): Remove.
3922 (emacs_fixed_new): Set priv->f to argument.
3923 (emacs_fixed_get_preferred_width)
3924 (emacs_fixed_get_preferred_height): Use min_width/height from
3925 frames size_hint to set minimum and natural (Bug#8919).
3926 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3927 and use min_width/height from frames size_hint to set
3928 min_width/height (Bug#8919).
3929
3930 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3931 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3932 Fix indentation.
c7e73be5 3933
cf99dcf8
EZ
39342011-06-26 Eli Zaretskii <eliz@gnu.org>
3935
3936 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3937 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3938 called at ZV.
3939
029529ac
CY
39402011-06-26 Chong Yidong <cyd@stupidchicken.com>
3941
3942 * process.c (wait_reading_process_output): Bypass select if
3943 waiting for a cell while ignoring keyboard input, and input is
3944 pending. Suggested by Jan Djärv (Bug#8869).
3945
7a7ef429
PE
39462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 Use gnulib's dup2 module instead of rolling our own.
3949 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3950
11fdef7d 39512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3952
3953 * dispnew.c (scrolling_window): Before scrolling, turn off a
3954 mouse-highlight in the window being scrolled.
3955
cd3520a4
JB
39562011-06-24 Juanma Barranquero <lekktu@gmail.com>
3957
3958 Move DEFSYM to lisp.h and use everywhere.
3959
3960 * character.h (DEFSYM): Move declaration...
3961 * lisp.h (DEFSYM): ...here.
3962
3963 * gnutls.c:
3964 * minibuf.c:
3965 * w32menu.c:
3966 * w32proc.c:
3967 * w32select.c: Don't include character.h.
3968
3969 * alloc.c (syms_of_alloc):
3970 * buffer.c (syms_of_buffer):
3971 * bytecode.c (syms_of_bytecode):
3972 * callint.c (syms_of_callint):
3973 * casefiddle.c (syms_of_casefiddle):
3974 * casetab.c (init_casetab_once):
3975 * category.c (init_category_once, syms_of_category):
3976 * ccl.c (syms_of_ccl):
3977 * cmds.c (syms_of_cmds):
3978 * composite.c (syms_of_composite):
3979 * dbusbind.c (syms_of_dbusbind):
3980 * dired.c (syms_of_dired):
3981 * dispnew.c (syms_of_display):
3982 * doc.c (syms_of_doc):
3983 * editfns.c (syms_of_editfns):
3984 * emacs.c (syms_of_emacs):
3985 * eval.c (syms_of_eval):
3986 * fileio.c (syms_of_fileio):
3987 * fns.c (syms_of_fns):
3988 * frame.c (syms_of_frame):
3989 * fringe.c (syms_of_fringe):
3990 * insdel.c (syms_of_insdel):
3991 * keymap.c (syms_of_keymap):
3992 * lread.c (init_obarray, syms_of_lread):
3993 * macros.c (syms_of_macros):
3994 * msdos.c (syms_of_msdos):
3995 * print.c (syms_of_print):
3996 * process.c (syms_of_process):
3997 * search.c (syms_of_search):
3998 * sound.c (syms_of_sound):
3999 * syntax.c (init_syntax_once, syms_of_syntax):
4000 * terminal.c (syms_of_terminal):
4001 * textprop.c (syms_of_textprop):
4002 * undo.c (syms_of_undo):
4003 * w32.c (globals_of_w32):
4004 * window.c (syms_of_window):
4005 * xdisp.c (syms_of_xdisp):
4006 * xfaces.c (syms_of_xfaces):
4007 * xfns.c (syms_of_xfns):
4008 * xmenu.c (syms_of_xmenu):
4009 * xsettings.c (syms_of_xsettings):
4010 * xterm.c (syms_of_xterm): Use DEFSYM.
4011
4228cf16
TZ
40122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4013
cd3520a4 4014 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4015
7fcccf1e
PE
40162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4017
7efb4e0e
PE
4018 Integer and buffer overflow fixes (Bug#8873).
4019
ff5844ad
PE
4020 * print.c (printchar, strout): Check for string overflow.
4021 (PRINTPREPARE, printchar, strout):
4022 Don't set size unless allocation succeeds.
4023
90532f02
PE
4024 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4025 for sizes. Check for string overflow more accurately.
4026 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4027
6d84508d
PE
4028 * macros.c: Integer and buffer overflow fixes.
4029 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4030 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4031 Use ptrdiff_t, not int, for sizes.
4032 Don't increment bufsize until after realloc succeeds.
4033 Check for size-calculation overflow.
4034 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4035
437b2cb4
PE
4036 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4037
8b9ac8b4
PE
4038 * lread.c: Integer overflow fixes.
4039 (read_integer): Radix is now EMACS_INT, not int,
4040 to improve quality of diagnostics for out-of-range radices.
4041 Calculate buffer size correctly for out-of-range radices.
4042 (read1): Check for integer overflow in radices, and in
4043 read-circle numbers.
82cb60d3
PE
4044 (read_escape): Avoid int overflow.
4045 (Fload, openp, read_buffer_size, read1)
4046 (substitute_object_recurse, read_vector, read_list, map_obarray):
4047 Use ptrdiff_t, not int, for sizes.
4048 (read1): Use EMACS_INT, not int, for sizes.
20270765 4049 Check for size overflow.
8b9ac8b4 4050
7fcccf1e
PE
4051 * image.c (cache_image): Check for size arithmetic overflow.
4052
bfbbd7e7
PE
4053 * lread.c: Integer overflow issues.
4054 (saved_doc_string_size, saved_doc_string_length)
4055 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4056 Now ptrdiff_t, not int.
4057 (read1): Don't assume doc string length fits in int. Check for
4058 out-of-range doc string lengths.
4059 (read_list): Don't assume file position fits in int.
39019e54 4060 (read_escape): Check for hex character overflow.
bfbbd7e7 4061
4e323265
LL
40622011-06-22 Leo Liu <sdl.web@gmail.com>
4063
4064 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4065 Move to minibuffer.el.
4066
85fece3e
PE
40672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4068
20b84ce9 4069 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4070 The following patches are for when GLYPH_DEBUG && !XASSERT.
4071 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4072 * dispnew.c (flush_stdout):
4073 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4074 Mark as externally visible.
4075 * dispnew.c (check_window_matrix_pointers): Now static.
4076 * dispnew.c (window_to_frame_vpos):
4077 * xfns.c (unwind_create_frame):
4078 * xterm.c (x_check_font): Remove unused local.
4079 * scroll.c (CHECK_BOUNDS):
4080 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4081 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4082 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4083 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4084 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4085 Now static.
4086 (debug_method_add): Use va_list and vsprintf rather than relying
4087 on undefined behavior with wrong number of arguments.
4088 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4089 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4090 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4091 since we're not interested in debugging glyphs with old libraries.
4092 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4093 GCC 4.6.0's static checking.
4094
0766b489
PE
40952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4096
31fd4b32
PE
4097 Integer overflow and signedness fixes (Bug#8873).
4098 A few related buffer overrun fixes, too.
4099
b79e8648
PE
4100 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4101
0766b489
PE
4102 * dispextern.h (struct face.stipple):
4103 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4104 (x_bitmap_mask, x_allocate_bitmap_record)
4105 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4106 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4107 (x_create_bitmap_from_xpm_data):
4108 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4109 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4110 (.bitmaps_last):
4111 * xfaces.c (load_pixmap):
4112 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4113 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4114 (.bitmaps_last, struct x_output.icon_bitmap):
4115 Use ptrdiff_t, not int, for bitmap indexes.
4116 (x_allocate_bitmap_record): Check for size overflow.
4117 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4118
b081724f
PE
4119 Use ptrdiff_t, not int, for overlay counts.
4120 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4121 * editfns.c (overlays_around, get_pos_property):
4122 * textprop.c (get_char_property_and_overlay):
4123 * xdisp.c (next_overlay_change, note_mouse_highlight):
4124 * xfaces.c (face_at_buffer_position):
21514da7
PE
4125 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4126 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4127 (Fnext_overlay_change, Fprevious_overlay_change)
4128 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4129 Use ptrdiff_t, not int, for sizes.
21514da7 4130 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4131
3de73e5e
PE
4132 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4133
2606c57b
PE
4134 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4135 (x_session_initialize): Do not assume string length fits in int.
4136
aaafe47a
PE
4137 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4138 This is unlikely, but can occur if DPI is outlandish.
4139
2674ddc8 4140 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4141 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4142
28154962
PE
4143 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4144 * xrdb.c (magic_file_p, search_magic_path):
4145 Omit last arg SUFFIX; it was always 0. All callers changed.
4146 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4147
7de51af5
PE
4148 * xfont.c (xfont_match): Avoid need for strlen.
4149
25ed6cc3
PE
4150 * xfns.c: Don't assume strlen fits in int.
4151 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4152
4eab31dd
PE
4153 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4154 not unsigned long, as we prefer signed integers. All callers changed.
4155 Detect integer overflow in repeat count.
4156 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4157 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4158
171e2a58
PE
4159 * termcap.c: Don't assume sizes fit in int and never overflow.
4160 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4161 (gobble_line): Check for size-calculation overflow.
4162
ad39faca 4163 * minibuf.c (Fread_buffer):
6e5bb2dc 4164 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4165 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4166 Don't assume string length fits in int.
4167
52c61c22 4168 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4169 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4170
b5b8c9e5
PE
4171 * font.c: Don't assume string length fits in int.
4172 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4173 Use ptrdiff_t, not int.
ccd6111c
PE
4174 (font_intern_prop): Don't assume string length fits in int.
4175 Don't assume integer property fits in fixnum.
4176 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4177
882f0d81 4178 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4179 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4180 Reformulate so as not to need the command string.
4181 Invoke gzip -cd rather than gunzip, as it's more portable.
4182 (lock_info_type, lock_file_1, lock_file):
4183 Don't assume pid_t and time_t fit in unsigned long.
4184 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4185 (current_lock_owner): Prefer signed type for sizes.
4186 Use memcpy, not strncpy, where memcpy is what is really wanted.
4187 Don't assume (via atoi) that time_t and pid_t fit in int.
4188 Check for time_t and/or pid_t out of range, e.g., via a network share.
4189 Don't alloca where an auto var works fine.
4190
93f4cf88
PE
4191 * fileio.c: Fix some integer overflow issues.
4192 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4193 Don't assume string length fits in int.
4194 (directory_file_name): Don't assume string length fits in long.
4195 (make_temp_name): Don't assume pid fits in int, or that its print
4196 length is less than 20.
4197
f3e92b69
PE
4198 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4199
1bfdaf10
PE
4200 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4201
35016e9a
PE
4202 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4203
3d1e65a1
PE
4204 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4205 We prefer signed integers, even for size calculations.
4206
0b963a93
PE
4207 * emacs.c: Don't assume string length fits in 'int'.
4208 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4209 (main): Don't invoke strlen when not needed.
4210
573f4b54
PE
4211 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4212 (XD_DEBUG_MESSAGE): Don't waste a byte.
4213
989f33ba
PE
4214 * callproc.c (getenv_internal_1, getenv_internal)
4215 (Fgetenv_internal):
965d34eb
PE
4216 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4217
e4d29b33
PE
4218 * lread.c (invalid_syntax): Omit length argument.
4219 All uses changed. This doesn't fix a bug, but it simplifies the
4220 code away from its former Hollerith-constant appearance, and it's
4221 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4222 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4223
eb49b136
PE
4224 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4225 This didn't break anything, but it didn't help either.
4226 It's confusing to put a bogus integer in a place where the actual
4227 value does not matter.
9f62aeb1 4228 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4229 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4230
15375a22
PE
4231 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4232 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4233 implementation.
b61cc01c
PE
4234 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4235 We prefer signed types, and the value cannot exceed the EMACS_INT
4236 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4237 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4238 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4239 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4240
53b2623d
PE
4241 * indent.c (sane_tab_width): New function.
4242 (current_column, scan_for_column, Findent_to, position_indentation)
4243 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4244 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4245
51cab52b 4246 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4247
f2ed8a70
PE
4248 * lisp.h (lint_assume): New macro.
4249 * composite.c (composition_gstring_put_cache):
4250 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4251
abe80cc6
PE
4252 * editfns.c, insdel.c:
4253 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4254
b02c740e
PE
4255 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4256
ebc96716
PE
4257 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4258
b4e50fa0 4259 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4260 Use much-faster test for byte-length change.
311d5d7c 4261 Don't assume string byte-length fits in 'int'.
a4cf38e4 4262 Check that character arg fits in 'int'.
85461888 4263 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4264
c0c1ee9f
PE
4265 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4266
a498d7f4
PE
4267 * fns.c (concat): Catch string overflow earlier.
4268 Do not rely on integer wraparound.
4269
51cab52b
PE
4270 * dispextern.h (struct it.overlay_strings_charpos)
4271 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4272 * xdisp.c (forward_to_next_line_start)
4273 (back_to_previous_visible_line_start)
4274 (reseat_at_next_visible_line_start, next_element_from_buffer):
4275 Don't arbitrarily truncate the value of 'selective' to int.
4276
76031fad
PE
4277 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4278
5eb55db9
PE
4279 * composite.c: Don't truncate sizes to 'int'.
4280 (composition_gstring_p, composition_reseat_it)
4281 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4282 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4283 not EMACS_UINT, for indexes.
5eb55db9 4284
0703a717
PE
4285 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4286
d6202519
PE
4287 * buffer.c: Include <verify.h>.
4288 (struct sortvec.priority, struct sortstr.priority):
8961a454 4289 Now EMACS_INT, not int.
c20998a7 4290 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4291 (struct sortstr.size, record_overlay_string)
4292 (struct sortstrlist.size, struct sortlist.used):
4293 Don't truncate size to int.
4294 (record_overlay_string): Check for size-calculation overflow.
d6202519 4295 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4296
d5a19415
JM
42972011-06-22 Jim Meyering <meyering@redhat.com>
4298
029529ac 4299 Don't leak an XBM-image-sized buffer
d5a19415
JM
4300 * image.c (xbm_load): Free the image buffer after using it.
4301
a9041e6c
PE
43022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4303
4304 Port to Sun C.
4305 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4306 that Sun C diagnosed.
4307 * fns.c (secure_hash): Fix pointer signedness issue.
4308 * intervals.c (static_offset_intervals): New function.
4309 (offset_intervals): Use it.
4310
7f3f739f
LL
43112011-06-21 Leo Liu <sdl.web@gmail.com>
4312
4313 * deps.mk (fns.o):
4314 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4315 sha512.h.
4316
4317 * fns.c (secure_hash): Rename from crypto_hash_function and change
4318 the first arg to accept symbols.
5b66d427 4319 (Fsecure_hash): New primitive.
7f3f739f
LL
4320 (syms_of_fns): New symbols.
4321
76147d94
DD
43222011-06-20 Deniz Dogan <deniz@dogan.se>
4323
4324 * process.c (Fset_process_buffer): Clarify return value in
4325 docstring.
4326
7d7d0045
CY
43272011-06-18 Chong Yidong <cyd@stupidchicken.com>
4328
4329 * dispnew.c (add_window_display_history): Use BVAR.
4330
4331 * xdisp.c (debug_method_add): Use BVAR.
4332 (check_window_end, dump_glyph_matrix, dump_glyph)
4333 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4334
4335 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4336 Likewise.
4337
4338 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4339 check till after the cache is created in init_frame_faces.
4340
ff2bc410
SM
43412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4342
4343 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4344
28177add
PE
43452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4346
dd3482fe
PE
4347 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4348 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4349 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4350
393d71f3 4351 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4352 * fileio.c (Finsert_file_contents):
4353 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4354 Remove the old (too-loose) buffer overflow checks.
4355 They weren't needed, since make_gap checks for buffer overflow.
4356 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4357 The old code merely checked for Emacs fixnum overflow, and relied
4358 on undefined (wraparound) behavior. The new code avoids undefined
4359 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4360
2e6813b0 4361 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4362 Tune. Don't use wider integers than needed. Don't use alloca.
4363 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4364
599a9e4f
PE
4365 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4366
99561444
PE
4367 * insdel.c, lisp.h (buffer_overflow): New function.
4368 (insert_from_buffer_1, replace_range, replace_range_2):
4369 * insdel.c (make_gap_larger):
4370 * editfns.c (Finsert_char):
4371 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4372
28177add
PE
4373 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4374
e69dafad
PE
43752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4376
a7af7fde 4377 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4378
b1c46f02
PE
4379 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4380 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4381
e69dafad
PE
4382 * fileio.c: Don't assume EMACS_INT fits in off_t.
4383 (emacs_lseek): New static function.
4384 (Finsert_file_contents, Fwrite_region): Use it.
4385 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4386
566684ea
PE
4387 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4388
e6966cd6
PE
4389 * fns.c: Don't overflow int when computing a list length.
4390 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4391 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4392 truncation on 64-bit hosts. Check for QUIT every
4393 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4394 faster and is responsive enough.
4395 (Flength): Report an error instead of overflowing an integer.
4396 (Fsafe_length): Return a float if the value is not representable
4397 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4398 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4399 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4400
dd0b0efb
PE
4401 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4402 (header_size, word_size): New constants.
4403 (allocate_vectorlike): Don't check size overflow here.
4404 (allocate_vector): Check it here instead, since this is the only
4405 caller of allocate_vectorlike that could cause overflow.
4406 Check that the new vector's length is representable as a fixnum.
4407
86fe5cfe
PE
4408 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4409 The previous code was bogus. For example, next_almost_prime (32)
4410 returned 39, which is undesirable as it is a multiple of 3; and
4411 next_almost_prime (24) returned 25, which is a multiple of 5 so
4412 why was the code bothering to check for multiples of 7?
4413
80e88859
PE
4414 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4415
4a2f0ad6
PE
4416 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4417
f66c7cf8
PE
4418 Variadic C functions now count arguments with ptrdiff_t.
4419 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4420 Back then I didn't know that the Emacs coding style prefers signed int.
4421 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4422 were being counted with int, which may truncate counts on 64-bit
4423 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4424 * lisp.h (struct Lisp_Subr.function.aMANY)
4425 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4426 Arg counts are now ptrdiff_t, not size_t.
4427 All variadic functions and their callers changed accordingly.
4428 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4429 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4430 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4431 * callint.c (Fcall_interactively): Check arg count for overflow,
4432 to avoid potential buffer overrun. Use signed char, not 'int',
4433 for 'varies' array, so that we needn't bother to check its size
4434 calculation for overflow.
4435 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4436 * eval.c (apply_lambda):
4437 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4438 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4439 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4440
a1759b76
PE
4441 * callint.c (Fcall_interactively): Don't use index var as event count.
4442
d96be9fc
PE
4443 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4444 * mem-limits.h (SIZE): Remove; no longer used.
4445
a690a978 4446 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4447
578c21e6
PE
4448 Remove unnecessary casts.
4449 * xterm.c (x_term_init):
4450 * xfns.c (x_set_border_pixel):
4451 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4452 These aren't needed now that we assume ANSI C.
4453
96f53c6c
PE
4454 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4455 It's more likely to cause problems (due to unsigned overflow)
4456 than to cure them.
4457
83c77d31
PE
4458 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4459
ee2079f1
PE
4460 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4461
6da65536
PE
4462 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4463
7147c4a4
PE
4464 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4465
193e32d9
PE
4466 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4467
e5533da6
PE
4468 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4469
9910e595
PE
4470 GLYPH_CODE_FACE returns EMACS_INT, not int.
4471 * dispextern.h (merge_faces):
4472 * xfaces.c (merge_faces):
01103c44
PE
4473 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4474 Don't assume EMACS_INT fits in int.
9910e595 4475
2638320e
PE
4476 * character.h (CHAR_VALID_P): Remove unused parameter.
4477 * fontset.c, lisp.h, xdisp.c: All uses changed.
4478
045eb8d9
PE
4479 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4480
c1f134b5
PE
4481 * fns.c (concat): Minor tuning based on overflow analysis.
4482 This doesn't fix any bugs. Use int to hold character, instead
4483 of constantly refetching from Emacs object. Use XFASTINT, not
4484 XINT, for value known to be a character. Don't bother comparing
4485 a single byte to 0400, as it's always less.
4486
395fcb93 4487 * floatfns.c (Fexpt):
327eeec8
PE
4488 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4489
abbd3d23
PE
4490 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4491 for characters.
4492
684a03ef
PE
4493 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4494
0fed43f3
PE
4495 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4496 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4497 incorrectly succeed when S was a string, because 4294967386 was
4498 truncated before it was used.
4499
8fd02eb7
PE
4500 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4501 Otherwise, an out-of-range integer could cause undefined behavior
4502 on a 64-bit host.
4503
f8c86b69
PE
4504 * composite.c: Use int, not EMACS_INT, for characters.
4505 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4506 EMACS_INT, for values that are known to be in character range.
4507 This doesn't fix any bugs but is the usual style inside Emacs and
4508 may generate better code on 32-bit machines.
4509
34206dd2
PE
4510 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4511 This is for reasons similar to the recent CHAR_STRING fix.
4512 * charset.c (Fencode_char): Check that character arg is actually
4513 a character. Pass an int to ENCODE_CHAR.
4514 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4515 wider than 'int', as a compile-time check to prevent future regressions
4516 in this area.
4517
c5958d4c 4518 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4519
4520 Make sure a 64-bit char is never passed to CHAR_STRING.
4521 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4522 by silently ignoring the top 32 bits, allowing some values
4523 that were far too large to be valid characters.
4524 * character.h: Include <verify.h>.
4525 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4526 arguments are no wider than unsigned, as a compile-time check
4527 to prevent future regressions in this area.
4528 * data.c (Faset):
01103c44 4529 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4530 (Fsubst_char_in_region):
4531 * fns.c (concat):
4532 * xdisp.c (decode_mode_spec_coding):
4533 Adjust to CHAR_STRING's new requirement.
4534 * editfns.c (Finsert_char, Fsubst_char_in_region):
4535 * fns.c (concat): Check that character args are actually
4536 characters. Without this test, these functions did the wrong
4537 thing with wildly out-of-range values on 64-bit hosts.
4538
d37ca623
PE
4539 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4540 These casts should not be needed on 32-bit hosts, either.
4541 * keyboard.c (read_char):
4542 * lread.c (Fload): Remove casts to unsigned.
4543
ea204efb
PE
4544 * lisp.h (UNSIGNED_CMP): New macro.
4545 This fixes comparison bugs on 64-bit hosts.
4546 (ASCII_CHAR_P): Use it.
4547 * casefiddle.c (casify_object):
01103c44 4548 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4549 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4550 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4551 * dispextern.h (FACE_FROM_ID):
4552 * keyboard.c (read_char): Use UNSIGNED_CMP.
4553
41cb286c
PE
4554 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4555 not to EMACS_INT, to avoid GCC warning.
4556
4a1b9832
PE
4557 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4558
55daad71
PE
4559 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4560 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4561 isn't needed on 32-bit machines.
8f95c75c 4562
01103c44
PE
4563 * buffer.c (Fgenerate_new_buffer_name):
4564 Use EMACS_INT for count, not int.
0ceccced 4565 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4566
4567 * data.c (Qcompiled_function): Now static.
4568
c6f072e7
PE
4569 * window.c (window_body_lines): Now static.
4570
20ce5912
PE
4571 * image.c (gif_load): Rename local to avoid shadowing.
4572
9c4c5f81
PE
4573 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4574 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4575 * alloc.c (make_save_value): Integer argument is now of type
4576 ptrdiff_t, not int.
4577 (mark_object): Use ptrdiff_t, not int.
4578 * lisp.h (pD): New macro.
4579 * print.c (print_object): Use it.
4580
c0c5c8ae
PE
4581 * alloc.c: Use EMACS_INT, not int, to count objects.
4582 (total_conses, total_markers, total_symbols, total_vector_size)
4583 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4584 (total_free_floats, total_floats, total_free_intervals)
4585 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4586 Now EMACS_INT, not int. All uses changed.
4587 (Fgarbage_collect): Compute overall total using a double, so that
4588 integer overflow is less likely to be a problem. Check for overflow
4589 when converting back to an integer.
5a25e253
PE
4590 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4591 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4592 These were 'int' variables that could overflow on 64-bit hosts;
4593 they were never used, so remove them instead of repairing them.
211a0b2a 4594 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4595 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4596 Previously, this ceilinged at INT_MAX, but that doesn't work on
4597 64-bit machines.
e46bb31a 4598 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4599
c78baabf 4600 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4601 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4602 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4603 when a (possibly-narrower) signed value would do just as well.
4604 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4605
c9d624c6
PE
4606 * alloc.c: Catch some string size overflows that we were missing.
4607 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4608 for convenience in STRING_BYTES_MAX.
4609 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4610 The definition here is exact; the one in lisp.h was approximate.
4611 (allocate_string_data): Check for string overflow. This catches
4612 some instances we weren't catching before. Also, it catches
4613 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4614 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4615 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4616
c9d624c6
PE
4617 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4618 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4619 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4620
353032ce
PE
4621 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4622
2bccce07
PE
4623 * alloc.c (Fmake_string): Check for out-of-range init.
4624
0ac30604
SM
46252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4626
4627 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4628
c195f2de
JD
46292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4630
4631 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4632 xg_get_default_scrollbar_width.
4633
4634 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4635 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4636 (style_changed_cb): Call update_theme_scrollbar_width and call
4637 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4638 all frames (Bug#8505).
4639 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4640 Call gtk_window_set_resizable if HAVE_GTK3.
4641 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4642 and height if HAVE_GTK3 (Bug#8505).
4643 (scroll_bar_width_for_theme): New variable.
4644 (update_theme_scrollbar_width): New function.
4645 (xg_get_default_scrollbar_width): Move code to
4646 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4647 (xg_initialize): Call update_theme_scrollbar_width.
4648
4649 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4650
4651 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4652
e10ac9f1
MR
46532011-06-12 Martin Rudalics <rudalics@gmx.at>
4654
4655 * frame.c (make_frame): Call other_buffer_safely instead of
4656 other_buffer.
4657
4658 * window.c (temp_output_buffer_show): Call display_buffer with
4659 second argument Vtemp_buffer_show_specifiers and reset latter
4660 immediately after the call.
4661 (Vtemp_buffer_show_specifiers): New variable.
4662 (auto_window_vscroll_p, next_screen_context_lines)
4663 (Vscroll_preserve_screen_position): Remove leading asterisks from
4664 doc-strings.
4665
2d3c217e 46662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4667
7b7f97e8 4668 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4669 * buffer.c (Qclone_number): Remove for now, as it's unused.
4670 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4671 (record_buffer): Remove unused local.
4672 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4673 (set_frame_buffer_list): Remove; unused.
4674 * frame.h (other_visible_frames): Remove decl.
4675 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4676 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4677 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4678 if HAVE_GPM.
4679 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4680 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4681 Define only if HAVE_GPM.
4682 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4683 (update_hints_inhibit): Remove; never set. All uses removed.
4684 * widgetprv.h (emacsFrameClassRec): Remove decl.
4685 * window.c (delete_deletable_window): Now returns void, since it
4686 wasn't returning anything.
4687 (compare_window_configurations): Remove unused locals.
4688 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4689 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4690 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4691 the same widths as pointers. This follows up on the 2011-05-06 patch.
4692 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4693 * xterm.h: Likewise.
4694 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4695
1384b89e
JB
46962011-06-12 Juanma Barranquero <lekktu@gmail.com>
4697
4698 * makefile.w32-in: Update dependencies.
4699 (LISP_H): Add lib/intprops.h.
4700
1100a63c
CY
47012011-06-11 Chong Yidong <cyd@stupidchicken.com>
4702
4703 * image.c (gif_load): Add animation frame delay to the metadata.
4704 (syms_of_image): Use DEFSYM. New symbol `delay'.
4705
6198ccd0
MR
47062011-06-11 Martin Rudalics <rudalics@gmx.at>
4707
4708 * window.c (delete_deletable_window): Re-add.
4709 (Fset_window_configuration): Rewrite to handle dead buffers and
4710 consequently deletable windows.
4711 (window_tree, Fwindow_tree): Remove. Supply functionality in
4712 window.el.
4713 (compare_window_configurations): Simplify code.
4714
b6e3633c
AS
47152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4716
1ab0dee5
AS
4717 * image.c (imagemagick_load_image): Fix type mismatch.
4718 (Fimagemagick_types): Likewise.
4719
b6e3633c
AS
4720 * window.h (replace_buffer_in_windows): Declare.
4721
9397e56f
MR
47222011-06-11 Martin Rudalics <rudalics@gmx.at>
4723
4724 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4725 Qclone_number. Remove external declaration of Qdelete_window.
4726 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4727 code.
640c8776
SM
4728 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4729 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4730 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4731 buffer list implementation.
4732 (other_buffer_safely): New function.
4733 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4734 calls to replace_buffer_in_windows and
4735 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4736 if allowed.
4737 (record_buffer): Inhibit quitting and rewrite using quittable
4738 functions. Run Qbuffer_list_update_hook if allowed.
4739 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4740 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4741 Move switch-to-buffer to window.el.
9397e56f
MR
4742 (bury-buffer): Move to window.el.
4743 (Vbuffer_list_update_hook): New variable.
4744
4745 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4746 section.
4747
4748 * window.h (resize_frame_windows): Move up in code.
4749 (Fwindow_frame): Remove EXFUN.
4750 (replace_buffer_in_all_windows): Remove prototype.
4751 (replace_buffer_in_windows_safely): Add prototype.
4752
4753 * window.c: Declare Qdelete_window static again. Move down
4754 declaration of select_count.
4755 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4756 (Fother_window): Move to window.el.
4757 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4758 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4759 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4760 window.el.
4761 (replace_buffer_in_windows): Implement by calling
4762 Qreplace_buffer_in_windows.
4763 (replace_buffer_in_all_windows): Remove with some functionality
4764 moved into replace_buffer_in_windows_safely.
4765 (replace_buffer_in_windows_safely): New function.
4766 (select_window_norecord, select_frame_norecord): Move in front
4767 of run_window_configuration_change_hook. Remove now obsolete
4768 declarations.
640c8776
SM
4769 (Fset_window_buffer): Rewrite doc-string.
4770 Call Qrecord_window_buffer.
9397e56f
MR
4771 (keys_of_window): Move binding for other-window to window.el.
4772
b50691aa
CY
47732011-06-11 Chong Yidong <cyd@stupidchicken.com>
4774
4775 * dispextern.h (struct image): Replace data member, whose int_val
4776 and ptr_val fields were not used by anything, with a single
4777 lisp_val object.
4778
4779 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4780 (gif_clear_image, gif_load, imagemagick_load_image)
4781 (gs_clear_image, gs_load): Callers changed.
4782
3f754b86
PE
47832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4784
cca69397
PE
4785 * buffer.h: Include <time.h>, for time_t.
4786 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4787
109e28d0
PE
4788 Fix minor problems found by static checking.
4789
60737f02
PE
4790 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4791
4b66faf3
PE
4792 Make identifiers static if they are not used in other modules.
4793 * data.c (Qcompiled_function, Qframe, Qvector):
4794 * image.c (QimageMagick, Qsvg):
4795 * minibuf.c (Qmetadata):
4796 * window.c (resize_window_check, resize_root_window): Now static.
4797 * window.h (resize_window_check, resize_root_window): Remove decls.
4798
109e28d0
PE
4799 * window.c (window_deletion_count, delete_deletable_window):
4800 Remove; unused.
46a4ce9e
PE
4801 (window_body_lines): Now static.
4802 (Fdelete_other_windows_internal): Mark vars as initialized.
4803 Make sure 'resize_failed' is initialized.
4804 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4805 (resize_window_apply): Remove unused local.
4806 * window.h (delete_deletable_window): Remove decl.
4807
109e28d0 4808 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4809 (imagemagick_load_image): Fix pointer signedness problem by changing
4810 last arg from unsigned char * to char *. All uses changed.
4811 Also, fix a local for similar reasons.
4812 Remove unused locals. Remove locals to avoid shadowing.
4813 (fn_rsvg_handle_free): Remove; unused.
4814 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4815 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4816
3f754b86
PE
4817 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4818
2547adb1
CY
48192011-06-10 Chong Yidong <cyd@stupidchicken.com>
4820
4821 * image.c (gif_load): Fix omitted cast error introduced by
4822 2011-06-06 change.
4823
2c8e37d4
MR
48242011-06-10 Martin Rudalics <rudalics@gmx.at>
4825
4826 * window.h (resize_proportionally, orig_total_lines)
4827 (orig_top_line): Remove from window structure.
4828 (set_window_height, set_window_width, change_window_heights)
4829 (Fdelete_window): Remove prototypes.
4830 (resize_frame_windows): Remove duplicate declaration.
4831
440a42e3
EZ
48322011-06-10 Eli Zaretskii <eliz@gnu.org>
4833
4834 * window.h (resize_frame_windows, resize_window_check)
4835 (delete_deletable_window, resize_root_window)
4836 (resize_frame_windows): Declare prototypes.
4837
4838 * window.c (resize_window_apply): Make definition be "static" to
4839 match the prototype.
4840
562dd5e9
MR
48412011-06-10 Martin Rudalics <rudalics@gmx.at>
4842
4843 * window.c: Remove declarations of Qwindow_size_fixed,
4844 window_min_size_1, window_min_size_2, window_min_size,
4845 size_window, window_fixed_size_p, enlarge_window, delete_window.
4846 Remove static from declaration of Qdelete_window, it's
4847 temporarily needed by Fbury_buffer.
4848 (replace_window): Don't assign orig_top_line and
4849 orig_total_lines.
4850 (Fdelete_window, delete_window): Remove. Window deletion is
4851 handled by window.el.
640c8776
SM
4852 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4853 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4854 (Fdelete_other_windows): Remove. Deleting other windows is
4855 handled by window.el.
4856 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4857 handled in window.el.
4858 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4859 Window minimum sizes are handled in window.el.
4860 (shrink_windows, size_window, set_window_height)
4861 (set_window_width, change_window_heights, window_height)
4862 (window_width, CURBEG, CURSIZE, enlarge_window)
4863 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4864 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4865 handled in window.el.
4866 (make_dummy_parent): Rename to make_parent_window and give it a
4867 second argument horflag.
4868 (make_window): Don't set resize_proportionally any more.
4869 (Fsplit_window): Remove. Windows are split in window.el.
4870 (save_restore_action, save_restore_orig_size)
4871 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4872 Resize mini windows in window.el.
4873 (grow_mini_window, shrink_mini_window): Implement by calling
4874 Qresize_root_window_vertically, resize_window_check and
4875 resize_window_apply.
640c8776
SM
4876 (saved_window, Fset_window_configuration, save_window_save):
4877 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4878 resize_proportionally.
4879 (window_min_height, window_min_width): Move to window.el.
4880 (keys_of_window): Move bindings for delete-other-windows,
4881 split-window, delete-window and enlarge-window to window.el.
4882
4883 * buffer.c: Temporarily extern Qdelete_window.
4884 (Fbury_buffer): Temporarily call Qdelete_window instead of
4885 Fdelete_window (Fbury_buffer will move to window.el soon).
4886
4887 * frame.c (set_menu_bar_lines_1): Remove code handling
4888 orig_top_line and orig_total_lines.
4889
4890 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4891 set_window_height but set heights directly.
4892 (change_frame_size_1): Use resize_frame_windows.
4893
4894 * xdisp.c (init_xdisp): Don't use set_window_height but set
4895 heights directly.
4896
640c8776
SM
4897 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4898 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4899 run_window_configuration_change_hook.
4900
4901 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4902 instead of change_window_heights and run
4903 run_window_configuration_change_hook.
4904
1a13852e
MR
49052011-06-09 Martin Rudalics <rudalics@gmx.at>
4906
4907 * window.c (replace_window): Rename second argument REPLACEMENT to
4908 NEW. New third argument SETFLAG. Rewrite.
4909 (delete_window, make_dummy_parent): Call replace_window with
4910 third argument 1.
4911 (window_list_1): Move down in code.
4912 (run_window_configuration_change_hook): Move set_buffer part
4913 before select_frame_norecord part in order to unwind correctly.
4914 Rename count1 to count.
4915 (recombine_windows, delete_deletable_window, resize_root_window)
4916 (Fdelete_other_windows_internal)
4917 (Frun_window_configuration_change_hook, make_parent_window)
4918 (resize_window_check, resize_window_apply, Fresize_window_apply)
4919 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4920 (Fdelete_window_internal, Fresize_mini_window_internal):
4921 New functions.
1a13852e
MR
4922 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4923
f3d1777e
MR
49242011-06-08 Martin Rudalics <rudalics@gmx.at>
4925
496e208e
MR
4926 * window.h (window): Add some new members to window structure -
4927 normal_lines, normal_cols, new_total, new_normal, clone_number,
4928 splits, nest, prev_buffers, next_buffers.
4929 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4930 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4931
f3d1777e
MR
4932 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4933 Remove.
496e208e
MR
4934 (make_dummy_parent): Set new members of windows structure.
4935 (make_window): Move down in code. Handle new members of window
4936 structure.
4937 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4938 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4939 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4940 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4941 (Fset_window_next_buffers, Fset_window_clone_number):
4942 New functions.
496e208e
MR
4943 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4944 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4945 Doc-string fixes.
4946 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4947 Argument WINDOW can be now internal window too.
4948 (Fwindow_use_time): Move up in code.
4949 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4950 Rewrite doc-string.
4951 (Fset_window_configuration, saved_window)
4952 (Fcurrent_window_configuration, save_window_save): Handle new
4953 members of window structure.
b9e809c2
MR
4954 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4955 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4956 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4957 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4958 Qget_mru_window, Qresize_root_window,
4959 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4960 Qauto_buffer_name; staticpro them.
f3d1777e 4961
abde8f8c
MR
49622011-06-07 Martin Rudalics <rudalics@gmx.at>
4963
4964 * window.c (Fwindow_total_size, Fwindow_left_column)
4965 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4966 (Fwindow_list_1): New functions.
4967 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4968 (Fwindow_width, Fscroll_left, Fscroll_right):
4969 Use window_body_cols instead of window_box_text_cols.
4970 (delete_window, Fset_window_configuration):
4971 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4972 (delete_all_subwindows): Take a window as argument and not a
4973 structure. Rewrite.
190b47e6
MR
4974 (window_loop): Remove handling of GET_LRU_WINDOW and
4975 GET_LARGEST_WINDOW.
4976 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4977
4978 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4979 window_box_text_cols. delete_all_subwindows now takes a
4980 Lisp_Object as argument.
abde8f8c 4981
640c8776
SM
4982 * indent.c (compute_motion, Fcompute_motion):
4983 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4984
fa8a67e6
MR
4985 * frame.c (delete_frame): Call delete_all_subwindows with root
4986 window as argument.
4987
a54e3482
DC
49882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4989
4990 * fns.c (Fputhash): Document return value.
4991
60002bf5
CY
49922011-06-06 Chong Yidong <cyd@stupidchicken.com>
4993
4994 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4995
0c671da6 49962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4997
b862a52a 4998 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4999
be44ca6c
PE
5000 Check for overflow when converting integer to cons and back.
5001 * charset.c (Fdefine_charset_internal, Fdecode_char):
5002 Use cons_to_unsigned to catch overflow.
5003 (Fencode_char): Use INTEGER_TO_CONS.
5004 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5005 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5006 * data.c (long_to_cons, cons_to_long): Remove.
5007 (cons_to_unsigned, cons_to_signed): New functions.
5008 These signal an error for invalid or out-of-range values.
5009 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5010 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5011 * font.c (Ffont_variation_glyphs):
5012 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5013 * lisp.h: Include <intprops.h>.
5014 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5015 (cons_to_signed, cons_to_unsigned): New decls.
5016 (long_to_cons, cons_to_long): Remove decls.
5017 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5018 (Fprimitive_undo): Use CONS_TO_INTEGER.
5019 * xfns.c (Fx_window_property): Likewise.
5020 * xselect.c: Include <limits.h>.
5021 (x_own_selection, selection_data_to_lisp_data):
5022 Use INTEGER_TO_CONS.
5023 (x_handle_selection_request, x_handle_selection_clear)
5024 (x_get_foreign_selection, Fx_disown_selection_internal)
5025 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5026 (lisp_data_to_selection_data): Use cons_to_unsigned.
5027 (x_fill_property_data): Use cons_to_signed.
5028 Report values out of range.
5029
d1f3d2af
PE
5030 Check for buffer and string overflow more precisely.
5031 * buffer.h (BUF_BYTES_MAX): New macro.
5032 * lisp.h (STRING_BYTES_MAX): New macro.
5033 * alloc.c (Fmake_string):
5034 * character.c (string_escape_byte8):
5035 * coding.c (coding_alloc_by_realloc):
5036 * doprnt.c (doprnt):
5037 * editfns.c (Fformat):
5038 * eval.c (verror):
5039 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5040 since they may not be the same number.
5041 * editfns.c (Finsert_char):
5042 * fileio.c (Finsert_file_contents):
5043 Likewise for BUF_BYTES_MAX.
5044
dd52fcea
PE
5045 * image.c: Use ptrdiff_t, not int, for sizes.
5046 (slurp_file): Switch from int to ptrdiff_t.
5047 All uses changed.
5048 (slurp_file): Check that file size fits in both size_t (for
5049 malloc) and ptrdiff_t (for sanity and safety).
5050
7f9bbdbb
PE
5051 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5052 if b->modtime has its maximal value.
5053
dfe18f82
PE
5054 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5055
84acfcf0
PE
5056 Don't assume time_t can fit into int.
5057 * buffer.h (struct buffer.modtime): Now time_t, not int.
5058 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5059 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5060
ccd9a01a
PE
5061 Minor fixes for signed vs unsigned integers.
5062 * character.h (MAYBE_UNIFY_CHAR):
5063 * charset.c (maybe_unify_char):
5064 * keyboard.c (read_char, reorder_modifiers):
5065 XINT -> XFASTINT, since the integer must be nonnegative.
5066 * ftfont.c (ftfont_spec_pattern):
5067 * keymap.c (access_keymap, silly_event_symbol_error):
5068 XUINT -> XFASTINT, since the integer must be nonnegative.
5069 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5070 since it makes no difference and we prefer signed.
5071 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5072 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5073 nonnegative.
5074
d6d100dd
SM
50752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5076
5077 * window.h (Fwindow_frame): Declare.
5078
2b6148e4
PE
50792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5080
5081 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5082 (SPARE_MEMORY): Always define.
5083 (LARGE_REQUEST): Remove.
5084 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5085
f230ecc9
MR
50862011-06-06 Martin Rudalics <rudalics@gmx.at>
5087
727e958e
MR
5088 * lisp.h: Move EXFUNS for Fframe_root_window,
5089 Fframe_first_window and Fset_frame_selected_window to window.h.
5090
5091 * window.h: Move EXFUNS for Fframe_root_window,
5092 Fframe_first_window and Fset_frame_selected_window here from
5093 lisp.h.
5094
5095 * frame.c (Fwindow_frame, Fframe_first_window)
5096 (Fframe_root_window, Fframe_selected_window)
5097 (Fset_frame_selected_window): Move to window.c.
5098 (Factive_minibuffer_window): Move to minibuf.c.
5099 (Fother_visible_frames_p): New function.
5100
5101 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5102
f230ecc9
MR
5103 * window.c (decode_window, decode_any_window): Move up in code.
5104 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5105 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5106 (Fwindow_buffer): Move up and rewrite doc-string.
5107 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5108 (Fwindow_prev): New functions.
727e958e
MR
5109 (Fwindow_frame): Move here from frame.c. Accept any window as
5110 argument.
5111 (Fframe_root_window, Fframe_first_window)
5112 (Fframe_selected_window): Move here from frame.c. Accept frame
5113 or arbitrary window as argument. Update doc-strings.
5114 (Fminibuffer_window): Move up in code.
5115 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5116 (Fset_frame_selected_window): Move here from frame.c.
5117 Marginal rewrite.
727e958e
MR
5118 (Fselected_window, select_window, Fselect_window): Move up in
5119 code. Minor doc-string fixes.
f230ecc9 5120
4d09bcf6
PE
51212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5122
5123 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5124 Do not assume that spare memory exists; that assumption is valid
5125 only if SYSTEM_MALLOC.
5126 (LARGE_REQUEST): New macro, so that the issue of large requests
5127 is separated from the issue of spare memory.
5128
810928a2
AS
51292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5130
172418ad
AS
5131 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5132 format. (Bug#8806)
5133
43f862f7
AS
5134 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5135
810928a2
AS
5136 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5137 before statements.
5138
a059fe24
JD
51392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5140
5141 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5142
5143 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5144
5145 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5146 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5147
989bf368
JB
51482011-06-05 Juanma Barranquero <lekktu@gmail.com>
5149
5150 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5151
4b80f674
CY
51522011-06-04 Chong Yidong <cyd@stupidchicken.com>
5153
5154 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5155 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5156 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5157 New error handlers.
4b80f674
CY
5158 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5159 Obey Vx_select_enable_clipboard_manager. Catch errors in
5160 x_clipboard_manager_save (Bug#8779).
5161 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5162 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5163
99a33b77 51642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5165
5166 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5167
99a33b77 51682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5169
5170 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5171 in the current matrix if keep_current_p is non-zero.
5172
8264569d
EZ
51732011-06-04 Eli Zaretskii <eliz@gnu.org>
5174
5175 * bidi.c (bidi_level_of_next_char): Fix last change.
5176
57f97249
EZ
51772011-06-03 Eli Zaretskii <eliz@gnu.org>
5178
fec2107c 5179 Support bidi reordering of text covered by display properties.
57f97249 5180
fec2107c
EZ
5181 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5182 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5183 (bidi_cache_search, bidi_cache_iterator_state)
5184 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5185 (bidi_level_of_next_char, bidi_move_to_visually_next):
5186 Support character positions inside a run of characters covered by a
fec2107c
EZ
5187 display string.
5188 (bidi_paragraph_init, bidi_resolve_explicit_1)
5189 (bidi_level_of_next_char): Call bidi_fetch_char and
5190 bidi_fetch_char_advance instead of FETCH_CHAR and
5191 FETCH_CHAR_ADVANCE.
5192 (bidi_init_it): Initialize new members.
5193 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5194 definitions.
5195 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5196 instead of using explicit *_CHAR codes.
d6d100dd
SM
5197 (bidi_resolve_explicit, bidi_resolve_weak):
5198 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5199 bidirectional text is supported only in multibyte buffers.
5200 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5201 it to initialize the frame_window_p member of struct bidi_it.
5202 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5203 (bidi_resolve_explicit, bidi_resolve_weak)
5204 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5205 bidi_it->nchars is non-positive.
5206 (bidi_level_of_next_char): Don't try to lookup the cache for the
5207 next/previous character if nothing is cached there yet, or if we
5208 were just reseat()'ed to a new position.
c40e2fb2 5209
0e14fe90
EZ
5210 * xdisp.c (set_cursor_from_row): Set start and stop points
5211 according to the row's direction when priming the loop that looks
5212 for the glyph on which to display cursor.
5213 (single_display_spec_intangible_p): Function deleted.
5214 (display_prop_intangible_p): Reimplement to call
5215 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5216 Accept 3 additional arguments needed by handle_display_spec.
5217 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5218 values: lists, `(when COND...)' forms, etc.
5219 (single_display_spec_string_p): Support property values that are
5220 lists with the argument STRING its top-level element.
5221 (display_prop_string_p): Fix the condition for processing a
5222 property that is a list to be consistent with handle_display_spec.
fec2107c 5223 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5224 last portion of handle_display_prop.
5225 (compute_display_string_pos): Accept additional argument
5226 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5227 value of a `display' property is a "replacing spec".
5228 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5229 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5230 the display property, but just return a value indicating whether
5231 the display property will replace the characters it covers.
5232 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5233 frame_window_p members of struct bidi_it.
d6d100dd
SM
5234 (compute_display_string_pos, compute_display_string_end):
5235 New functions.
fec2107c
EZ
5236 (push_it): Accept second argument POSITION, where pop_it should
5237 jump to continue iteration.
5238 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5239
fec2107c
EZ
5240 * keyboard.c (adjust_point_for_property): Adjust the call to
5241 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5242
5243 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5244 (bidi_init_it): Update prototypes.
5245 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5246 (compute_display_string_pos, compute_display_string_end):
5247 Declare prototypes.
fec2107c
EZ
5248 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5249 EMACS_INT.
fc6f18ce 5250
40087514 52512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5252
57f53182
PE
5253 Malloc failure behavior now depends on size of allocation.
5254 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5255 * lisp.h: Change signatures accordingly.
5256 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5257 All callers changed. (Bug#8762)
5258
5259 * gnutls.c: Use Emacs's memory allocators.
5260 Without this change, the gnutls library would invoke malloc etc.
5261 directly, which causes problems on non-SYNC_INPUT hosts, and which
5262 runs afoul of improving memory_full behavior. (Bug#8761)
5263 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5264 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5265 xfree instead of the default malloc, realloc, free.
5266 (Fgnutls_boot): No need to check for memory allocation failure,
5267 since xmalloc does that for us.
5268
ac32cd99 5269 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5270 * category.c (hash_get_category_set):
5271 * ccl.c (ccl_driver):
5272 * charset.c (Fdefine_charset_internal):
5273 * charset.h (struct charset.hash_index):
5274 * composite.c (get_composition_id, gstring_lookup_cache)
5275 (composition_gstring_put_cache):
5276 * composite.h (struct composition.hash_index):
5277 * dispextern.h (struct image.hash):
5278 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5279 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5280 (hashfn_equal, hashfn_user_defined, make_hash_table)
5281 (maybe_resize_hash_table, hash_lookup, hash_put)
5282 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5283 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5284 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5285 * image.c (make_image, search_image_cache, lookup_image)
5286 (xpm_put_color_table_h):
5287 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5288 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5289 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5290 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5291 * alloc.c (allocate_vectorlike):
5292 Check for overflow in vector size calculations.
5293 * ccl.c (ccl_driver):
5294 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5295 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5296 need to be updated by these changes.
40087514
PE
5297 * fns.c (make_hash_table, maybe_resize_hash_table):
5298 Check for integer overflow with large hash tables.
0de4bb68
PE
5299 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5300 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5301 (SXHASH_REDUCE): New macro.
5302 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5303 Use it instead of discarding useful hash info with large hash values.
5304 (sxhash_float): New function.
5305 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5306 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5307 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5308 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5309 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5310 Adjust signatures to match updated version of code.
5311 (consing_since_gc): Now EMACS_INT, since a single hash table can
5312 use more than INT_MAX bytes.
5313
698d32e2
DN
53142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5315
5316 Make it possible to build with GCC-4.6+ -O2 -flto.
5317
5318 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5319
fd6fa53f
SM
53202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5321
5322 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5323 Call minibuffer-inactive-mode.
5324
864db017
JB
53252011-05-31 Juanma Barranquero <lekktu@gmail.com>
5326
5327 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5328 Update dependencies.
5329
2ad0baf4
DN
53302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5331
5332 * data.c (init_data): Remove code for UTS, this system is not
5333 supported anymore.
5334
4fcc2638
DN
53352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5336
5337 Don't force ./temacs to start in terminal mode.
5338
5339 * frame.c (make_initial_frame): Initialize faces in all cases, not
5340 only when CANNOT_DUMP is defined.
5341 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5342
c56e0fd5
DN
53432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5344
5345 * dispnew.c (add_window_display_history): Use const for the string
5346 pointer. Remove declaration, not needed.
5347
333d54da 53482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5349
55d4c1b2 5350 Use 'inline', not 'INLINE'.
333d54da 5351 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5352 * alloc.c, fontset.c (INLINE): Remove.
5353 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5354 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5355 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5356 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5357 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5358
738db178
DN
53592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5360
5361 Make it possible to run ./temacs.
5362
5363 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5364 syms_of_callproc does the same thing. Remove test for
5365 "initialized", do it in the caller.
5366 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5367
620c53a6
SM
53682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5369
5370 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5371 (read_minibuf): Use get_minibuffer.
5372 (syms_of_minibuf): Use DEFSYM.
5373 (Qmetadata): New var.
5374 * data.c (Qbuffer): Don't make it static.
5375 (syms_of_data): Use DEFSYM.
5376
e003a292
PE
53772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5378
5379 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5380 (CCL_CODE_MIN): New macro.
5381
ed008a6d
PE
53822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5383
3687c2ef
PE
5384 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5385
ed008a6d
PE
5386 * eval.c (Qdebug): Now static.
5387 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5388 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5389 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5390
d66c4c7c
CY
53912011-05-29 Chong Yidong <cyd@stupidchicken.com>
5392
5393 * image.c: Various fixes to ImageMagick code comments.
5394 (Fimagemagick_types): Doc fix.
5395
5fbc2025
PE
53962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5397
0196f88a
PE
5398 Minor fixes prompted by GCC 4.6.0 warnings.
5399
5400 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5401
5fbc2025
PE
5402 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5403 (x_clipboard_manager_save_all): Move extern decl to ...
5404 * xterm.h: ... here, so that it can be checked for consistency.
5405
1dd3c2d9
CY
54062011-05-29 Chong Yidong <cyd@stupidchicken.com>
5407
5408 * xselect.c (x_clipboard_manager_save_frame)
5409 (x_clipboard_manager_save_all): New functions.
5410 (Fx_clipboard_manager_save): Lisp function deleted.
5411
5412 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5413 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5414
5415 * xterm.h: Update prototype.
5416
5ba6571d
WX
54172011-05-28 William Xu <william.xwl@gmail.com>
5418
5419 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5420 exiting (Bug#8239).
5421
3eaff834
JM
54222011-05-28 Jim Meyering <meyering@redhat.com>
5423
e1900994 5424 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5425 * fns.c (to_uchar): Define.
5426 (crypto_hash_function): Use it to convert some newly-signed
5427 variables to unsigned, to avoid sign-extension bugs. For example,
5428 without this change, (md5 "truc") would evaluate to
5429 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5430 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5431 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5432
0f6990a7
PE
54332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5434
5435 Integer overflow fixes.
c8a9ca5a 5436
08686060
PE
5437 * dbusbind.c: Serial number integer overflow fixes.
5438 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5439 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5440 to hold a serial number that is too large for a fixnum.
5441 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5442 Check for serial numbers out of range. Decode any serial number
59568bf0 5443 that was so large that it became a float. (Bug#8722)
08686060 5444
2d1fc3c7
PE
5445 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5446 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5447 Use XFASTINT rather than XUINT when numbers are nonnegative.
5448 (xd_append_arg, Fdbus_method_return_internal):
5449 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5450 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5451 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5452 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5453 (Bug#8722)
2d1fc3c7 5454
c8a9ca5a
PE
5455 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5456
519e1d69
PE
5457 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5458
30569699
PE
5459 ccl: add integer overflow checks
5460 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5461 (IN_INT_RANGE): New macros.
5462 (ccl_driver): Use them to check for integer overflow when
5463 decoding a CCL program. Many of the new checks are whether XINT (x)
5464 fits in int; it doesn't always, on 64-bit hosts. The new version
5465 doesn't catch all possible integer overflows, but it's an
847044ea 5466 improvement. (Bug#8719)
30569699 5467
c11285dc
PE
5468 * alloc.c (make_event_array): Use XINT, not XUINT.
5469 There's no need for unsigned here.
5470
fdccd48e
PE
5471 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5472 This follows up to the 2011-05-06 change that substituted uintptr_t
5473 for EMACS_INT. This case wasn't caught back then.
5474
37910ab2
PE
5475 Rework Fformat to avoid integer overflow issues.
5476 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5477 now (part of C89). Include <verify.h>.
5478 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5479 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5480 (Fformat): Avoid the prepass trying to compute sizes; it was only
5481 approximate and thus did not catch overflow reliably. Instead, walk
5482 through the format just once, formatting and computing sizes as we go,
5483 checking for integer overflow at every step, and allocating a larger
5484 buffer as needed. Keep track separately whether the format is
5485 multibyte. Keep only the most-recently calculated precision, rather
5486 than them all. Record whether each argument has been converted to
5487 string. Use EMACS_INT, not int, for byte and char and arg counts.
5488 Support field widths and precisions larger than INT_MAX. Avoid
5489 sprintf's undefined behavior with conversion specifications such as %#d
5490 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5491 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5492 formatting out-of-range floating point numbers with int
9173deec 5493 formats. (Bug#8668)
37910ab2 5494
2e6578fb
PE
5495 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5496
0ae6bdee
PE
5497 * data.c: Avoid integer truncation in expressions involving floats.
5498 * data.c: Include <intprops.h>.
5499 (arith_driver): When there's an integer overflow in an expression
5500 involving floating point, convert the integers to floating point
5501 so that the resulting value does not suffer from catastrophic
5502 integer truncation. For example, on a 64-bit host (* 4
5503 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5504 Do not rely on undefined behavior after integer overflow.
5505
de883a70
PE
5506 merge count_size_as_multibyte, parse_str_to_multibyte
5507 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5508 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5509 Check for integer overflow.
5510 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5511 since it's now a duplicate of the other. This is more of
5512 a character than a buffer op, so better that it's in character.c.
5513 * fns.c, print.c: Adjust to above changes.
5514
2ff916cb
PE
55152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5516
5517 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5518
f1b54466
PE
55192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5520
fb1ac845
PE
5521 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5522 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5523 (x_clipboard_manager_save): Now static.
5524 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5525
f1b54466
PE
5526 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5527 (crypto_hash_function): Now static.
5528 Fix pointer signedness problems. Avoid unnecessary initializations.
5529
a9f737ee
CY
55302011-05-27 Chong Yidong <cyd@stupidchicken.com>
5531
5532 * termhooks.h (Vselection_alist): Make it terminal-local.
5533
5534 * terminal.c (create_terminal): Initialize it.
5535
5536 * xselect.c: Support for clipboard managers.
5537 (Vselection_alist): Move to termhooks.h as terminal-local var.
5538 (LOCAL_SELECTION): New macro.
5539 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5540 (symbol_to_x_atom): Remove gratuitous arg.
5541 (x_handle_selection_request, lisp_data_to_selection_data)
5542 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5543 (x_own_selection, x_get_local_selection, x_convert_selection):
5544 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5545 (some_frame_on_display): Delete unused function.
5546 (Fx_own_selection_internal, Fx_get_selection_internal)
5547 (Fx_disown_selection_internal, Fx_selection_owner_p)
5548 (Fx_selection_exists_p): New optional frame arg.
5549 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5550 (x_handle_selection_clear): Don't treat other terminals with the
5551 same keyboard specially. Use the terminal-local Vselection_alist.
5552 (x_clear_frame_selections): Use Frun_hook_with_args.
5553
5554 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5555
5556 * xterm.h: Add support for those atoms.
5557
e067f0c1
CY
55582011-05-26 Chong Yidong <cyd@stupidchicken.com>
5559
5560 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5561 (converted_selections, conversion_fail_tag): New global variables.
5562 (x_selection_request_lisp_error): Free the above.
5563 (x_get_local_selection): Remove unnecessary code.
5564 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5565 of converted selections stored in converted_selections.
5566 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5567 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5568 (x_convert_selection): New function.
5569 (x_handle_selection_event): Simplify.
5570 (x_get_foreign_selection): Don't ignore incoming requests while
5571 waiting for an answer; this will fail when we implement
5572 SAVE_TARGETS, and seems unnecessary anyway.
5573 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5574 (Vx_sent_selection_functions): Doc fix.
5575
0f4aebc0
LL
55762011-05-26 Leo Liu <sdl.web@gmail.com>
5577
5578 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5579
e61124cd
YM
55802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5581
5582 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5583
5584 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5585 for fringe update if it has periodic bitmap.
ac389d0c 5586 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5587 and fringe_bitmap_periodic_p.
5588
5589 * fringe.c (get_fringe_bitmap_data): New function.
5590 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5591 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5592 row. Mark glyph row for fringe update if periodicity changed.
5593
5594 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5595 for fringe update unless it has periodic bitmap.
5596
f16d9837
KH
55972011-05-25 Kenichi Handa <handa@m17n.org>
5598
5599 * xdisp.c (get_next_display_element): Set correct it->face_id for
5600 a static composition.
5601
e1b90ef6
LL
56022011-05-24 Leo Liu <sdl.web@gmail.com>
5603
5604 * deps.mk (fns.o):
5605 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5606
5607 * fns.c (crypto_hash_function, Fsha1): New function.
5608 (Fmd5): Use crypto_hash_function.
5609 (syms_of_fns): Add Ssha1.
5610
7400048f
PE
56112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5612
5613 * gnutls.c: Remove unused macros.
5614 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5615 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5616 Remove macros that are defined and never used.
5617 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5618
abb71cf4
CY
56192011-05-22 Chong Yidong <cyd@stupidchicken.com>
5620
5621 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5622 (Fx_get_selection_internal): Minor cleanup.
5623 (Fx_own_selection_internal): Rename arguments for consistency with
5624 select.el.
5625
6307db39
PE
56262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5627
5628 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5629
f3d4e0a4
CY
56302011-05-22 Chong Yidong <cyd@stupidchicken.com>
5631
5632 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5633
4d8ade89
YM
56342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5635
5636 * dispnew.c (scrolling_window): Don't exclude the case that the
5637 last enabled row in the desired matrix touches the bottom boundary.
5638
32078c8d
GM
56392011-05-21 Glenn Morris <rgm@gnu.org>
5640
5641 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5642 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5643 and add some more files.
32078c8d 5644
7285dc67
EZ
56452011-05-20 Eli Zaretskii <eliz@gnu.org>
5646
5647 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5648 report_file_error introduced by the change from 2011-05-07.
5649
89d1bd22
PE
56502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5651
5652 * systime.h (Time): Define only if emacs is defined.
5653 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5654 where the include path doesn't have X11/X.h by default. See
5655 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5656
e23640bb 56572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5658
5659 * composite.c (find_automatic_composition): Fix previous change.
5660
b9704ad9
GM
56612011-05-20 Glenn Morris <rgm@gnu.org>
5662
5663 * lisp.mk: New file, split from Makefile.in.
5664 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5665 (shortlisp): Remove.
5666 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5667
4a720484
GM
56682011-05-19 Glenn Morris <rgm@gnu.org>
5669
5670 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5671 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5672 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5673 (lisp): Set the order to that of loadup.el.
5674 (shortlisp): Make it a copy of $lisp.
5675 (SOME_MACHINE_LISP): Remove.
5676 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5677 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5678
a28d4396
KH
56792011-05-18 Kenichi Handa <handa@m17n.org>
5680
5681 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5682 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5683 (find_automatic_composition): Mostly rewrite for efficiency.
5684
a2b1fa8e
JB
56852011-05-18 Juanma Barranquero <lekktu@gmail.com>
5686
5687 * makefile.w32-in: Update dependencies.
5688
8e1f5610
CS
56892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5690
5691 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5692 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5693
7025ee00 56942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5695
cdfa6eab
PE
5696 Fix some integer overflow issues, such as string length overflow.
5697
06d6db33
PE
5698 * insdel.c (count_size_as_multibyte): Check for string overflow.
5699
2b4560a8
PE
5700 * character.c (lisp_string_width): Check for string overflow.
5701 Use EMACS_INT, not int, for string indexes and lengths; in
5702 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5703 the resulting string length overflows an EMACS_INT; instead,
5704 report a string overflow if no precision given. When checking for
5705 precision exhaustion, use a check that cannot possibly have
5706 integer overflow. (Bug#8675)
5707 * character.h (lisp_string_width): Adjust to new signature.
5708
cb93f9be
PE
5709 * alloc.c (string_overflow): New function.
5710 (Fmake_string): Use it. This doesn't change behavior, but saves
5711 a few bytes and will simplify future changes.
5712 * character.c (string_escape_byte8): Likewise.
5713 * lisp.h (string_overflow): New decl.
5714
1a1f3366
PE
5715 Fixups, following up to the user-interface timestamp change.
5716 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5717 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5718 * msdos.c (mouse_get_pos): Likewise.
5719 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5720 * w32gui.h (Time): Define by including "systime.h" rather than by
5721 declaring it ourselves. (Bug#8664)
5722
d4e3e4d3
PE
5723 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5724 * image.c (clear_image_cache): Likewise.
5725
f6a24d19
PE
5726 * term.c (term_mouse_position): Don't assume time_t wraparound.
5727
08dc5ae6
PE
5728 Be more systematic about user-interface timestamps.
5729 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5730 and sometimes 'EMACS_UINT', to represent these timestamps.
5731 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5732 This makes the code easier to follow, and makes it easier to catch
5733 integer overflow bugs such as Bug#8664.
5734 * frame.c (Fmouse_position, Fmouse_pixel_position):
5735 Use Time, not unsigned long, for user-interface timestamps.
5736 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5737 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5738 * keyboard.h (last_event_timestamp): Likewise.
5739 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5740 * menu.h (xmenu_show): Likewise.
5741 * term.c (term_mouse_position): Likewise.
5742 * termhooks.h (struct input_event.timestamp): Likewise.
5743 (struct terminal.mouse_position_hook): Likewise.
5744 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5745 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5746 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5747 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5748 what it was before.
5749 * menu.h, termhooks.h: Include "systime.h", for Time.
5750
8e55734a
PE
5751 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5752 Don't assume that the difference between two unsigned long values
5753 can fit into an integer. At this point, we know button_down_time
5754 <= event->timestamp, so the difference must be nonnegative, so
5755 there's no need to cast the result if double-click-time is
5756 nonnegative, as it should be; check that it's nonnegative, just in
5757 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5758 apart (about 25 days). (Bug#8664)
8e55734a 5759
841f1b75 5760 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5761 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5762
3e26f69c
PE
5763 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5764 that always fit in int. Use a sentinel instead of a counter, to
5765 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5766 * frame.h (struct frame): Use int for menu_bar_items_used
5767 instead of EMACS_INT, since it always fits in int.
3e26f69c 5768
5cc152c0
PE
5769 * menu.c (grow_menu_items): Check for int overflow.
5770
d89eb65e
PE
5771 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5772
5235bd3e
PE
5773 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5774 Before, the code was not consistent. These values cannot exceed
5775 2**31 - 1 so there's no need to make them unsigned.
5776 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5777 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5778 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5779 as modifiers.
5780 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5781
bc827e23
PE
5782 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5783 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5784 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5785 presumably because the widths might not match.
5786
78eb494e
PE
5787 * window.c (size_window): Avoid needless test at loop start.
5788
04f2d78b
CB
57892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5790
5791 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5792
d2fc7e3d 57932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5794
5795 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5796
d2fc7e3d 57972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5798
5799 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5800 `width' to `bar_area_x' and `bar_area_width', respectively.
5801 (x_scroll_run): Take account of fringe background extension.
5802
04f2d78b
CB
5803 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5804 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5805 `bar_area_width', respectively.
5806 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5807 background extension.
5808
79b70037
GM
58092011-05-10 Jim Meyering <meyering@redhat.com>
5810
5811 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5812
2f142cc5
JB
58132011-05-10 Juanma Barranquero <lekktu@gmail.com>
5814
5815 * image.c (Finit_image_library): Return t for built-in image types,
5816 like pbm and xbm. (Bug#8640)
5817
57679c86
AS
58182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5819
5820 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5821
888c9e86
EZ
58222011-05-07 Eli Zaretskii <eliz@gnu.org>
5823
b0512a1d
EZ
5824 * w32console.c (Fset_screen_color): Doc fix.
5825 (Fget_screen_color): New function.
5826 (syms_of_ntterm): Defsubr it.
5827
7285dc67
EZ
5828 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5829 unlink the temporary file if Fcall_process didn't create it in the
5830 first place.
5831 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5832 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5833 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5834 cue to call_process_cleanup not to close that handle.
5835
4d3fcc8e
BK
58362011-05-07 Ben Key <bkey76@gmail.com>
5837
5838 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5839 one of two shell specific rules, either bootstrap-temacs-CMD or
5840 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5841 to the previous implementation of the bootstrap-temacs rule.
5842 The bootstrap-temacs-CMD rule is similar to the previous
5843 implementation of the bootstrap-temacs rule except that it
5844 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5845 variable.
5846
5847 These changes, along with some changes to nt/configure.bat,
5848 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5849 earlier fix to add support for --cflags and --ldflags options
5850 that include quotes so that it works whether make uses cmd or
5851 sh as the shell.
5852
b4289b64
MA
58532011-05-06 Michael Albinus <michael.albinus@gmx.de>
5854
5855 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5856 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5857 is a constant.
5858 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5859 a string. Handle both cases.
5860 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5861 (Fdbus_register_method): Use Qinvalid_function.
5862
af4c0e28
JB
58632011-05-06 Juanma Barranquero <lekktu@gmail.com>
5864
5865 * makefile.w32-in: Update dependencies.
5866 (LISP_H): Add inttypes.h and stdin.h.
5867 (PROCESS_H): Add unistd.h.
5868
c51453d9
EZ
58692011-05-06 Eli Zaretskii <eliz@gnu.org>
5870
5871 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5872 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5873
8ff0ac3c 58742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5875
4c4b566b
PE
5876 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5877
aab2b9b5
PE
5878 * term.c (vfatal): Remove stray call to va_end.
5879 It's not needed and the C Standard doesn't allow it here anyway.
5880
c378da0b
PE
5881 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5882 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5883
288b08c7
PE
5884 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5885 bytes.
5886
e3601888
PE
5887 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5888
db6c0e74
PE
5889 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5890
dd5963ea
PE
5891 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5892
88c9450f
PE
5893 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5894
2f9442b8
PE
5895 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5896
c032b5f8
PE
5897 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5898 * charset.c (Fdefine_charset_internal): Don't initialize
5899 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5900 32-bit int (Bug#8600).
a108c10b
PE
5901
5902 * lread.c (read_integer): Be more consistent with string-to-number.
5903 Use string_to_number to do the actual conversion; this avoids
5904 rounding errors and fixes some other screwups. Without this fix,
5905 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5906 (digit_to_number): Move earlier, for benefit of read_integer.
5907 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5908 not a digit in any supported base. (Bug#8602)
a108c10b 5909
ad5f9eea
PE
5910 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5911
aec1708a
PE
5912 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5913 to match comment at start of function. This also removes a
5914 GCC warning about overflow in a 32+64-bit port.
5915
47be4ab5
PE
5916 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5917
371cac43
PE
5918 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5919 Reported by Stefan Monnier in
5920 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5921 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5922 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5923
d01a7826
PE
5924 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5925 (EMACS_UINTPTR): Likewise, with uintptr_t.
5926
7fd47d5c
PE
5927 * lisp.h: Prefer 64-bit EMACS_INT if available.
5928 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5929 on 32-bit hosts that have 64-bit int, so that they can access
5930 large files.
122b0c86
PE
5931 However, temporarily disable this change unless the temporary
5932 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5933
8727937b
PE
5934 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5935
8ac068ac
PE
5936 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5937 This removes an assumption that EMACS_INT and long are the same
5938 width as pointers. The assumption is true for Emacs porting targets
5939 now, but we want to make other targets possible.
5940 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5941 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5942 In the rest of the code, change types of integers that hold casted
5943 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5944 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5945 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5946 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5947 No need to cast type when ORing.
5948 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5949 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5950 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5951 assume EMACS_INT is the same width as char *.
5952 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5953 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5954 Remove no-longer-needed casts.
5955 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5956 (xg_tool_bar_help_callback, xg_make_tool_item):
5957 Use EMACS_INTPTR to hold an integer
5958 that will be cast to void *; this can avoid a GCC warning
5959 if EMACS_INT is not the same width as void *.
5960 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5961 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5962 (current_message_1, set_message_1):
5963 Use a local to convert to proper width without a cast.
5964 * xmenu.c (dialog_selection_callback): Likewise.
5965
ede49d71
PE
5966 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5967 Also, don't assume VALBITS / RAND_BITS is less than 5,
5968 and don't rely on undefined behavior when shifting a 1 left into
5969 the sign bit.
5970 * lisp.h (get_random): Change signature to match.
5971
2f30ecd0
PE
5972 * lread.c (hash_string): Use size_t, not int, for hash computation.
5973 Normally we prefer signed values; but hashing is special, because
5974 it's better to use unsigned division on hash table sizes so that
5975 the remainder is nonnegative. Also, size_t is the natural width
5976 for hashing into memory. The previous code used 'int', which doesn't
5977 retain enough info to hash well into very large tables.
5978 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5979
2a866e7b
PE
5980 * dbusbind.c: Don't possibly lose pointer info when converting.
5981 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5982 Use XPNTR rather than XHASH, so that the high-order bits of
5983 the pointer aren't lost when converting through void *.
5984
51639eac
PE
5985 * eval.c (Fautoload): Don't double-shift a pointer.
5986
92394119
PE
5987 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5988
dbdb9a7c
JB
59892011-05-06 Juanma Barranquero <lekktu@gmail.com>
5990
5991 * gnutls.c (DEF_GNUTLS_FN):
5992 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5993
db7a0b4f
AS
59942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5995
5996 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5997 marker. (Bug#8610)
5998
f7ff1b0f 59992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6000
6001 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6002 New version that can reserve upto 2GB of heap space.
6003
f7ff1b0f 60042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6005
6006 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6007
639c109b
TZ
60082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6009
6010 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6011 `gnutls_certificate_set_x509_key_file'.
6012
d2127135
JB
60132011-05-05 Juanma Barranquero <lekktu@gmail.com>
6014
6015 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6016 Update dependencies.
6017
e968f4f3
JB
60182011-05-04 Juanma Barranquero <lekktu@gmail.com>
6019
6020 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6021 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6022 Remove unused parameter `fildes'.
6023 * process.c (read_process_output, send_process): Don't pass it.
6024
84d358f0
JB
60252011-05-04 Juanma Barranquero <lekktu@gmail.com>
6026
6027 Fix previous change: the library cache is defined in w32.c.
6028 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6029 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6030
0898ca10
JB
60312011-05-04 Juanma Barranquero <lekktu@gmail.com>
6032
6033 Implement dynamic loading of GnuTLS on Windows.
6034
6035 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6036 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6037 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6038 Declare.
6039
6040 * gnutls.c (Qgnutls_dll): Define.
6041 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6042 (gnutls_*): Declare function pointers.
6043 (init_gnutls_functions): New function to initialize function pointers.
6044 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6045 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6046 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6047 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6048 (emacs_gnutls_write, emacs_gnutls_read)
6049 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6050 (Fgnutls_available_p): New function.
6051 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6052 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6053 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6054
6055 * image.c: Include w32.h.
6056 (Vimage_type_cache): Delete.
6057 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6058 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6059 (w32_delayed_load): Move to w32.c.
6060
6061 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6062
6063 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6064 (w32_delayed_load): Move from image.c. When loading a library, record
6065 its filename in the :loaded-from property of the library id.
6066 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6067 Initialize and staticpro them.
6068 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6069
6070 * process.c: Include lisp.h before w32.h, not after.
6071 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6072 instead of gnutls_record_check_pending.
6073
6074 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6075
ff4de4aa
TZ
60762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6077
6078 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6079 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6080 as passed in.
6081
abe95abb
JD
60822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6083
6084 * xterm.c (x_set_frame_alpha): Do not set property on anything
6085 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6086
e16e55d4
JB
60872011-05-02 Juanma Barranquero <lekktu@gmail.com>
6088
6089 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6090
bafcf6a5
JB
60912011-05-02 Juanma Barranquero <lekktu@gmail.com>
6092
6093 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6094 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6095 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6096 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6097 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6098 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6099 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6100 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6101 (Qgnutls_bootprop_callbacks_verify): Make static.
6102
e7a6747f
AS
61032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6104
19ed11ba
AS
6105 * callproc.c: Indentation fixup.
6106
e7a6747f 6107 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6108 (wait_for_termination, interruptible_wait_for_termination):
6109 Move after wait_for_termination_1.
e7a6747f 6110
1ef14cb4
LMI
61112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6112
6113 * sysdep.c (interruptible_wait_for_termination): New function
6114 which is like wait_for_termination, but allows keyboard
6115 interruptions.
6116
6117 * callproc.c (Fcall_process): Add (:file "file") as an option for
6118 the STDOUT buffer.
6119 (Fcall_process_region): Ditto.
6120
330d880c
EZ
61212011-04-30 Eli Zaretskii <eliz@gnu.org>
6122
8db90b73
EZ
6123 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6124 rather than `XVECTOR (FOO)->size'.
6125
330d880c
EZ
6126 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6127 inttypes.h, as a gnulib replacement is used if it not available in
6128 system headers.
6129
15cbd324
EZ
61302011-04-21 Eli Zaretskii <eliz@gnu.org>
6131
6132 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6133 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6134 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6135
6136 * coding.c (coding_alloc_by_realloc): Error out if destination
6137 will grow beyond MOST_POSITIVE_FIXNUM.
6138 (decode_coding_emacs_mule): Abort if there isn't enough place in
6139 charbuf for the composition carryover bytes. Reserve an extra
6140 space for up to 2 characters produced in a loop.
6141 (decode_coding_iso_2022): Abort if there isn't enough place in
6142 charbuf for the composition carryover bytes.
6143
61442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6145
ae940cca
EZ
6146 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6147 aborting when %lld or %lll format is passed.
6148 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6149 %llo or %llx format is passed. (Bug#8545)
6150
03ab8921
EZ
6151 * window.c (window_scroll_line_based): Use a marker instead of
6152 simple variables to record original value of point. (Bug#7952)
6153
afda1437
EZ
6154 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6155 produced by %s or %c overflows available buffer space. (Bug#8545)
6156
f76dee0c
PE
61572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6158
6159 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6160 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6161
fdc5744d
JB
61622011-04-28 Juanma Barranquero <lekktu@gmail.com>
6163
6164 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6165
638f053a
JB
61662011-04-28 Juanma Barranquero <lekktu@gmail.com>
6167
6168 * keyboard.c (Qdelayed_warnings_hook): Define.
6169 (command_loop_1): Run `delayed-warnings-hook'
6170 if Vdelayed_warnings_list is non-nil.
6171 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6172 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6173
d178f871
EZ
61742011-04-28 Eli Zaretskii <eliz@gnu.org>
6175
6176 * doprnt.c (doprnt): Don't return value smaller than the buffer
6177 size if the message was truncated. (Bug#8545).
6178
b124fd93
JB
61792011-04-28 Juanma Barranquero <lekktu@gmail.com>
6180
6181 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6182 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6183
e810457d
PE
61842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6185
6186 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6187
ea51cceb
JB
61882011-04-27 Juanma Barranquero <lekktu@gmail.com>
6189
6190 * makefile.w32-in: Update dependencies.
6191
94dcfacf
EZ
61922011-04-27 Eli Zaretskii <eliz@gnu.org>
6193
6194 Improve `doprnt' and its usage. (Bug#8545)
6195 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6196 `format_end'. Remove support for %l as a conversion specifier.
6197 Don't use xrealloc. Improve diagnostics when the %l size modifier
6198 is used. Update the commentary.
6199
6200 * eval.c (verror): Simplify calculation of size_t.
6201
6202 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6203 messages.
6204
f61f41d7
PE
62052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6206
6207 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6208 change.
6209
96fb4434
PE
62102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6211
6212 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6213 This makes this file independent of the recent pseudovector change.
6214
671875da 62152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6216
69e9b5a3
PE
6217 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6218
b5f869a7 6219 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6220 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6221 Remove unused local.
c8926152 6222 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6223
841a1577 6224 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6225 GCC 4.6.0 optimizes based on type-based alias analysis.
6226 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6227 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6228 != &v->size, and therefore "v->size = 1; b->size = 2; return
6229 v->size;" must therefore return 1. This assumption is incorrect
6230 for Emacs, since it type-puns struct Lisp_Vector * with many other
6231 types. To fix this problem, this patch adds a new type struct
f904488f 6232 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6233 and pseudovectors, and helps optimizing compilers not get fooled
6234 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6235 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6236 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6237 the size member.
eab3844f
PE
6238 (XSETPVECTYPE): Rewrite in terms of new macro.
6239 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6240 This is a bit clearer, and further avoids the possibility of
6241 undesirable aliasing.
6242 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6243 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6244 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6245 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6246 (ASIZE): Now uses header.size rather than size.
6247 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6248 to avoid the hassle of writing XVECTOR (foo)->header.size.
6249 (struct vectorlike_header): New type.
eab3844f
PE
6250 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6251 object, to help avoid aliasing.
6252 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6253 (SUBRP): Likewise, since Lisp_Subr is a special case.
6254 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6255 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6256 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6257 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6258 changed to be "header.size" and "header.next".
6259 * buffer.h (struct buffer): Likewise.
6260 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6261 * frame.h (struct frame): Likewise.
6262 * process.h (struct Lisp_Process): Likewise.
6263 * termhooks.h (struct terminal): Likewise.
6264 * window.c (struct save_window_data, struct saved_window): Likewise.
6265 * window.h (struct window): Likewise.
6266 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6267 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6268 * buffer.c (init_buffer_once): Likewise.
6269 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6270 special case.
6271 * process.c (Fformat_network_address): Use local var for size,
6272 for brevity.
6273
0df1eac5
PE
6274 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6275
847ab9d1 6276 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6277 * data.c (atof): Remove decl; no longer used or needed.
6278 (digit_to_number): Move to lread.c.
6279 (Fstring_to_number): Use new string_to_number function, to be
6280 consistent with how the Lisp reader treats infinities and NaNs.
6281 Do not assume that floating-point numbers represent EMACS_INT
6282 without losing information; this is not true on most 64-bit hosts.
6283 Avoid double-rounding errors, by insisting on integers when
6284 parsing non-base-10 numbers, as the documentation specifies.
6285 * lisp.h (string_to_number): New decl, replacing ...
6286 (isfloat_string): Remove.
bc0a5c13 6287 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6288 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6289 appears to have been a coding error. Similarly, do not accept
6290 strings like +-1e0 as floating point numbers. Do not report
6291 overflow for integer overflows unless the base is not 10 which
6292 means we have no simple and reliable way to continue.
6293 Break out the floating-point parsing into a new
6294 function string_to_number, so that Fstring_to_number parses
6295 floating point numbers consistently with the Lisp reader.
04f2d78b 6296 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6297 (E_CHAR, EXP_INT): Remove, replacing with ...
6298 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6299 (string_to_number): New function, replacing isfloat_string.
6300 This function checks for valid syntax and produces the resulting
6301 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6302 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6303 so that overflow for non-base-10 numbers is reported only when
6304 there's no portable and simple way to convert to floating point.
452f4150 6305
67769ffc
PE
6306 * textprop.c (set_text_properties_1): Rewrite for clarity,
6307 and to avoid GCC warning about integer overflow.
6308
c20db43f
PE
6309 * intervals.h (struct interval): Use EMACS_INT for members
6310 where EMACS_UINT might cause problems. See
6311 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6312 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6313 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6314 All uses changed.
37aa2f85
PE
6315 (offset_intervals): Tell GCC not to worry about length overflow
6316 when negating a negative length.
c20db43f 6317
2538aa2f
PE
6318 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6319 (overrun_check_free): Likewise.
6320
f2d3008d
PE
6321 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6322 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6323 word size.
6324
ec8df744
PE
6325 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6326 (gnutls_make_error): Rename local to avoid shadowing.
6327 (gnutls_emacs_global_deinit): ifdef out; not used.
6328 (Fgnutls_boot): Use const for pointer to readonly storage.
6329 Comment out unused local. Fix pointer signedness problems.
6330
640ee02d
PE
6331 * lread.c (openp): Don't stuff size_t into an 'int'.
6332 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6333 about possible signed overflow.
6334
6048fb2a
PE
6335 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6336 (GDK_KEY_g): Don't define if already defined.
6337 (xg_prepare_tooltip): Avoid pointer signedness problem.
6338 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6339
fa3c87e1
PE
6340 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6341 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6342
2172544b
PE
6343 * xfns.c (Fx_window_property): Simplify a bit,
6344 to make a bit faster and to avoid GCC 4.6.0 warning.
6345 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6346
9b821a21
PE
6347 * fns.c (internal_equal): Don't assume size_t fits in int.
6348
3c616cfa
PE
6349 * alloc.c (compact_small_strings): Tighten assertion a little.
6350
c2982e87
PE
6351 Replace pEd with more-general pI, and fix some printf arg casts.
6352 * lisp.h (pI): New macro, generalizing old pEd macro to other
6353 conversion specifiers. For example, use "...%"pI"d..." rather
6354 than "...%"pEd"...".
6355 (pEd): Remove. All uses replaced with similar uses of pI.
6356 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6357 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6358 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6359 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6360 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6361 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6362 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6363 64-bit hosts.
6364 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6365 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6366 * print.c (safe_debug_print, print_object): Likewise.
6367 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6368 to int.
6f04d126
PE
6369 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6370 avoiding the 0 flag, which is not portable.
c2982e87
PE
6371 * process.c (Fmake_network_process): Use pI to avoid cast.
6372 * region-cache.c (pp_cache): Likewise.
6373 * xdisp.c (decode_mode_spec): Likewise.
6374 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6375 behavior on 64-bit hosts with printf arg.
6f04d126 6376 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6377 (x_stop_queuing_selection_requests): Likewise.
6378 (x_get_window_property): Don't truncate byte count to an 'int'
6379 when tracing.
0b432f21 6380
5e073ec7
PE
6381 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6382 here, since it parses constructs like leading '-' and spaces,
6383 which are not wanted; and it overflows with large numbers.
6384 Instead, simply match F[0-9]+, which is what is wanted anyway.
6385
36372bf9
PE
6386 * alloc.c: Remove unportable assumptions about struct layout.
6387 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6388 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6389 (allocate_vectorlike, make_pure_vector): Use the new macros,
6390 plus offsetof, to remove unportable assumptions about struct layout.
6391 These assumptions hold on all porting targets that I know of, but
6392 they are not guaranteed, they're easy to remove, and removing them
6393 makes further changes easier.
6394
0b432f21
PE
6395 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6396 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6397 (string_overrun_cookie): Now const. Use initializers that
6398 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6399 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6400 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6401 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6402 multiple of sizeof (EMACS_INT); it need not be, if
6403 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6404 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6405
895009e1
JB
64062011-04-26 Juanma Barranquero <lekktu@gmail.com>
6407
6408 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6409
6a7a1b0b
TZ
64102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6411
6412 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6413 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6414 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6415
841a1577 64162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6417
6418 * lisp.h (Qdebug): List symbol.
895009e1 6419 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6420 * keyboard.c (debug-on-event): New variable.
6421 (handle_user_signal): Break into debugger when debug-on-event
6422 matches the current signal symbol.
6423
f2d3ba6f
DN
64242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6425
6426 * alloc.c (check_sblock, check_string_bytes)
6427 (check_string_free_list): Convert to standard C.
6428
42ce4c63
TZ
64292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6430
6431 * w32.c (emacs_gnutls_push): Fix typo.
6432
825cd63c
EZ
64332011-04-25 Eli Zaretskii <eliz@gnu.org>
6434
fb11d64d
EZ
6435 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6436 "cast to pointer from integer of different size".
6437
825cd63c
EZ
6438 Improve doprnt and its use in verror. (Bug#8545)
6439 * doprnt.c (doprnt): Document the set of format control sequences
6440 supported by the function. Use SAFE_ALLOCA instead of always
6441 using `alloca'.
6442
6443 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6444 is one byte too soon. Don't use xrealloc; instead xfree and
6445 xmalloc anew.
6446
e061a11b
TZ
64472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6448
6449 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6450 callbacks stage.
6451
6452 * gnutls.c: Renamed global_initialized to
6453 gnutls_global_initialized. Added internals for the
6454 :verify-hostname-error, :verify-error, and :verify-flags
6455 parameters of `gnutls-boot' and documented those parameters in the
6456 docstring. Start callback support.
9173deec
JB
6457 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6458 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6459 on error. Return error code.
e061a11b
TZ
6460 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6461 (emacs_gnutls_read): Likewise.
6462 (Fgnutls_boot): Return handshake error code.
6463 (emacs_gnutls_handle_error): New function.
6464 (wsaerror_to_errno): Likewise.
6465
6466 * w32.h (emacs_gnutls_pull): Add prototype.
6467 (emacs_gnutls_push): Likewise.
6468
6469 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6470 (emacs_gnutls_push): Likewise.
6471
64722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6473
6474 * process.c (wait_reading_process_output): Check if GnuTLS
6475 buffered some data internally if no FDs are set for TLS
6476 connections.
6477
6478 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6479 (LIBS): Link to USER_LIBS.
6480 ($(BLD)/gnutls.$(0)): New target.
6481
fa6996bc
EZ
64822011-04-24 Eli Zaretskii <eliz@gnu.org>
6483
eb35682e
EZ
6484 * xdisp.c (handle_single_display_spec): Rename the
6485 display_replaced_before_p argument into display_replaced_p, to
6486 make it consistent with the commentary. Fix typos in the
6487 commentary.
6488
e2ad650c
EZ
6489 * textprop.c (syms_of_textprop): Remove dead code.
6490 (copy_text_properties): Delete obsolete commentary about an
6491 interface that was deleted long ago. Fix typos in the description
6492 of arguments.
6493
1b2de274
EZ
6494 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6495 to changes in oldXMenu/XMenu.h from 2011-04-16.
6496 <menu_help_message, prev_menu_help_message>: Constify.
6497 (IT_menu_make_room): menu->help_text is now `const char **';
6498 adjust.
6499
6500 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6501 to changes in oldXMenu/XMenu.h from 2011-04-16.
6502 (struct XMenu): Declare `help_text' `const char **'.
6503
6504 * xfaces.c <Qunspecified>: Make extern again.
6505
6506 * syntax.c: Include sys/types.h before including regex.h, as
6507 required by Posix.
6508
762b15be
EZ
6509 * doc.c (get_doc_string): Improve the format passed to `error'.
6510
6511 * doprnt.c (doprnt): Improve commentary.
6512
6513 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6514
6515 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6516 them with etags.
6517
f1052e5d
EZ
6518 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6519 changes in globals.h immediately force recompilation.
762b15be
EZ
6520 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6521 $(CURDIR)/s/ms-w32.h.
6522 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6523
fa6996bc
EZ
6524 * character.c (Fchar_direction): Function deleted.
6525 (syms_of_character): Don't defsubr it.
6526 <char-direction-table>: Deleted.
6527
e6c3da20
EZ
65282011-04-23 Eli Zaretskii <eliz@gnu.org>
6529
6530 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6531 * doprnt.c: Include limits.h.
6532 (SIZE_MAX): New macro.
04f2d78b
CB
6533 (doprnt): Return a size_t value. 2nd arg is now size_t.
6534 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6535 Improve overflow protection. Support `l' modifier for integer
6536 conversions. Support %l conversion. Don't assume an EMACS_INT
6537 argument for integer conversions and for %c.
6538
6539 * lisp.h (doprnt): Restore prototype.
6540
6541 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6542 $(SRC)/character.h.
6543
6544 * Makefile.in (base_obj): Add back doprnt.o.
6545
6546 * deps.mk (doprnt.o): Add back prerequisites.
6547 (callint.o): Depend on character.h.
6548
6549 * eval.c (internal_lisp_condition_case): Include the handler
6550 representation in the error message.
6551 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6552 when breaking from the loop.
6553
6554 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6555
6556 * callint.c (Fcall_interactively): When displaying error message
6557 about invalid control letter, pass the character's codepoint, not
6558 a pointer to its multibyte form. Improve display of the character
6559 in octal and display also its hex code.
6560
6561 * character.c (char_string): Use %x to display the (unsigned)
6562 codepoint of an invalid character, to avoid displaying a bogus
6563 negative value.
6564
6565 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6566 `error', not SYMBOL_NAME itself.
6567
6568 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6569 character arguments to `error'.
6570
6571 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6572 to `error' in error message about FINAL_CHAR argument. Make sure
6573 FINAL_CHAR is a character, and use %c when it is passed as
6574 argument to `error'.
6575
4ffd0d6b 65762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6577
6578 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6579
6580 * w32.c: Include <time.h>.
6581 (sys_localtime): New function.
6582
4ffd0d6b 65832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6584
6585 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6586
4ffd0d6b 6587 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6588
4ffd0d6b 65892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6590
4ffd0d6b
GM
6591 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6592 zombies (Bug#8467).
aac0c6e3 6593
04c56954
EZ
65942011-04-19 Eli Zaretskii <eliz@gnu.org>
6595
6596 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6597 gl_state.e_property when gl_state.object is Qt.
6598
6599 * insdel.c (make_gap_larger): Remove limitation of buffer size
6600 to <= INT_MAX.
6601
16a43933
CY
66022011-04-18 Chong Yidong <cyd@stupidchicken.com>
6603
6604 * xdisp.c (lookup_glyphless_char_display)
6605 (produce_glyphless_glyph): Handle cons cell entry in
6606 glyphless-char-display.
6607 (Vglyphless_char_display): Document it.
6608
6609 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6610 glyphless-char-display.
6611
4581706e
CY
66122011-04-17 Chong Yidong <cyd@stupidchicken.com>
6613
6614 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6615
6616 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6617
6618 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6619 definition for no-X builds.
6620
4887c6e2 66212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6622
fd35b6f9
PE
6623 Static checks with GCC 4.6.0 and non-default toolkits.
6624
5c1ccb01
PE
6625 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6626
006c5daa
PE
6627 * process.c (keyboard_bit_set): Define only if SIGIO.
6628 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6629 (send_process): Repair possible setjmp clobbering.
6630
efc736d3
PE
6631 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6632
4e2fe2e6
PE
6633 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6634
f97334a2
PE
6635 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6636
4e75f29d
PE
6637 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6638 Define only if needed.
6639
90efadd1
PE
6640 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6641 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6642 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6643
3c647824
PE
6644 * dispextern.h (struct redisplay_interface): Rename param
6645 to avoid shadowing.
e264f262 6646 * termhooks.h (struct terminal): Likewise.
761383f4 6647 * xterm.c (xembed_send_message): Likewise.
3c647824 6648
b58c5c4a
PE
6649 * insdel.c (make_gap_smaller): Define only if
6650 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6651
cad59032
PE
6652 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6653 it.
6654
c339dc2e
PE
6655 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6656 so that we aren't warned about unused symbols.
6657
91a3e27b
PE
6658 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6659
399c71d3 6660 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6661
8ffc96f5
PE
6662 * xfns.c (x_real_positions): Mark locals as initialized.
6663
eef9bc79
PE
6664 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6665
098db9dd
PE
6666 * xterm.c: Fix problems found by static analysis with other toolkits.
6667 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6668 (x_dispatch_event): Declare static if USE_GTK, and
6669 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6670 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6671 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6672 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6673 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6674
eb18f6cc
PE
6675 * xmenu.c (menu_help_callback): Pointer type fixes.
6676 Use const pointers when pointing at readonly data. Avoid pointer
6677 signedness clashes.
6678 (FALSE): Remove unused macro.
6679 (update_frame_menubar): Remove unused decl.
6680
1fe72bf8
PE
6681 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6682
60d9e1db
PE
6683 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6684 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6685 (single_menu_item): Rename local to avoid shadowing.
6686
39261c26
PE
6687 * keyboard.c (make_lispy_event): Remove unused local var.
6688
018c5e19
PE
6689 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6690 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6691
63d2b86e
PE
6692 * bitmaps: Change bitmaps from unsigned char back to the X11
6693 compatible char. Avoid the old compiler warnings about
6694 out-of-range initializers by using, for example, '\xab' rather
6695 than 0xab.
6696
aefd87e1
PE
6697 * xgselect.c (xgselect_initialize): Check vs interface
6698 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6699
bf501fb9
PE
6700 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6701
e9829fdf
PE
6702 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6703 to read-only memory.
6704
1086c095
PE
6705 * fns.c (vector): Remove; this old hack is no longer needed.
6706
2baccd04 6707 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6708 Remove unused var.
dde42981 6709 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6710
72391843 6711 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6712
436c16df 6713 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6714 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6715 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6716
92bb796d 6717 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6718 (x_term_init): Remove local to avoid shadowing.
92bb796d 6719
764430a3 6720 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6721
6722 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6723 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6724
d1dfb56c
EZ
67252011-04-16 Eli Zaretskii <eliz@gnu.org>
6726
c4354cb4
EZ
6727 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6728
d1dfb56c
EZ
6729 Fix regex.c, syntax.c and friends for buffers > 2GB.
6730 * syntax.h (struct gl_state_s): Declare character position members
6731 EMACS_INT.
6732
6733 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6734
04f2d78b
CB
6735 * textprop.c (verify_interval_modification, interval_of):
6736 Declare arguments EMACS_INT.
d1dfb56c
EZ
6737
6738 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6739 EMACS_INT.
6740
6741 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6742
6743 * indent.c (Fvertical_motion): Local variable it_start is now
6744 EMACS_INT.
6745
6746 * regex.c (re_match, re_match_2, re_match_2_internal)
6747 (bcmp_translate, regcomp, regexec, print_double_string)
6748 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6749 (re_compile_pattern, re_exec): Declare arguments and local
6750 variables `size_t' and `ssize_t' and return values `regoff_t', as
6751 appropriate.
6752 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6753 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6754 <compile_stack_type>: `size' and `avail' are now `size_t'.
6755
6756 * regex.h <regoff_t>: Use ssize_t, not int.
6757 (re_search, re_search_2, re_match, re_match_2): Arguments that
6758 specify buffer/string position and length are now ssize_t and
6759 size_t. Return type is regoff_t.
6760
613052cd
BK
67612011-04-16 Ben Key <bkey76@gmail.com>
6762
6763 * nsfont.m: Fixed bugs in ns_get_family and
6764 ns_descriptor_to_entity that were caused by using free to
6765 deallocate memory blocks that were allocated by xmalloc (via
6766 xstrdup). This caused Emacs to crash when compiled with
6767 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6768 --enable-checking=xmallocoverrun). xfree is now used to
6769 deallocate these memory blocks.
6770
4170f62f 67712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6772
71b41406
PE
6773 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6774
9587a89d
PE
6775 emacs_write: Accept and return EMACS_INT for sizes.
6776 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6777 et seq.
6778 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6779 Accept and return EMACS_INT.
6780 (emacs_gnutls_write): Return the number of bytes written on
6781 partial writes.
6782 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6783 (emacs_read, emacs_write): Remove check for negative size, as the
6784 Emacs source code has been audited now.
9587a89d
PE
6785 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6786 (emacs_read, emacs_write): Use it.
273a5f82
PE
6787 * process.c (send_process): Adjust to the new signatures of
6788 emacs_write and emacs_gnutls_write. Do not attempt to store
6789 a byte offset into an 'int'; it might overflow.
9587a89d 6790 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6791
3e047f51
PE
6792 * sound.c: Don't assume sizes fit in 'int'.
6793 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6794 Return EMACS_INT, not int.
3e047f51 6795 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6796 Accept EMACS_INT, not int.
6797 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6798 record read return values.
6799
cc39a9db
BK
68002011-04-15 Ben Key <bkey76@gmail.com>
6801
c9d0ec6d
JB
6802 * keyboard.c (Qundefined): Don't declare static since it is used
6803 in nsfns.m.
6804 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6805 static since they are used in nsfont.m.
cc39a9db 6806
6c60eb9f
SM
68072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6808
6809 * process.c (Qprocessp): Don't declare static.
6810 * lisp.h (Qprocessp): Declare again.
6811
7990b61a
JB
68122011-04-15 Juanma Barranquero <lekktu@gmail.com>
6813
6814 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6815
5d4cb038
PE
68162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6817
8bd7b830 6818 Improve C-level modularity by making more things 'static'.
cd64ea1d 6819
e3b27b31
PE
6820 Don't publish debugger-only interfaces to other modules.
6821 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6822 (verify_bytepos, count_markers): Move decls to the only modules
6823 that need them.
6824 * region-cache.h (pp_cache): Likewise.
6825 * window.h (check_all_windows): Likewise.
6826 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6827
5d4cb038
PE
6828 * sysdep.c (croak): Now static, if
6829 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6830 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6831
6832 * alloc.c (refill_memory_reserve): Now static if
6833 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6834 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6835
e87b6180
PE
6836 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6837 Define only if USE_LUCID.
6838
ac64929e
PE
6839 * xrdb.c (x_customization_string, x_rm_string): Now static.
6840
6f37259d
PE
6841 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6842 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6843
1683e3ab
PE
6844 * xdisp.c (draw_row_with_mouse_face): Now static.
6845 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6846
de9c2632
PE
6847 * window.h (check_all_windows): Mark externally visible.
6848
2b96acb7
PE
6849 * window.c (window_deletion_count): Now static.
6850
6851 * undo.c: Make symbols static if they're not exported.
6852 (last_undo_buffer, last_boundary_position, pending_boundary):
6853 Now static.
6854
50436f33
PE
6855 * textprop.c (interval_insert_behind_hooks): Now static.
6856 (interval_insert_in_front_hooks): Likewise.
6857
64520e5c
PE
6858 * term.c: Make symbols static if they're not exported.
6859 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6860 (max_frame_lines, tty_set_terminal_modes):
6861 (tty_reset_terminal_modes, tty_turn_off_highlight):
6862 (get_tty_terminal): Now static.
6863 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6864 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6865 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6866 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6867 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6868
1fa53021
PE
6869 * sysdep.c: Make symbols static if they're not exported.
6870 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6871 Now static.
6872 (sigprocmask_set, full_mask): Remove; unused.
6873 (wait_debugging): Mark as visible.
6874 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6875 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6876
d4b43b22
PE
6877 * syntax.c (syntax_temp): Define only if !__GNUC__.
6878
b7c513d0
PE
6879 * sound.c (current_sound_device, current_sound): Now static.
6880
989b29ad
PE
6881 * search.c (searchbufs, searchbuf_head): Now static.
6882
13a55a78
PE
6883 * scroll.c (scroll_cost): Remove; unused.
6884 * dispextern.h (scroll_cost): Remove decl.
6885
de68a1fc
PE
6886 * region-cache.h (pp_cache): Mark as externally visible.
6887
40ccffa6
PE
6888 * process.c: Make symbols static if they're not exported.
6889 (process_tick, update_tick, create_process, chan_process):
6890 (Vprocess_alist, proc_buffered_char, datagram_access):
6891 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6892 (deactivate_process): Mark defn as static, as well as decl.
6893 * lisp.h (create_process): Remove decl.
6894 * process.h (chan_process, Vprocess_alist): Remove decls.
6895
ad64fc97
PE
6896 * print.c: Make symbols static if they're not exported.
6897 (print_depth, new_backquote_output, being_printed, print_buffer):
6898 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6899 (print_interval, print_number_index, initial_stderr_stream):
6900 Now static.
6901 * lisp.h (Fprinc): Remove decl.
6902 (debug_output_compilation_hack): Mark as externally visible.
6903
adddb265
PE
6904 * sysdep.c (croak): Move decl from here to syssignal.h.
6905 * syssignal.h (croak): Put it here, so the API can be checked when
6906 'croak' is called from dissociate_if_controlling_tty.
6907
1717ede2
PE
6908 * minibuf.c: Make symbols static if they're not exported.
6909 (minibuf_save_list, choose_minibuf_frame): Now static.
6910 * lisp.h (choose_minibuf_frame): Remove decl.
6911
fa5fb2bc
PE
6912 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6913
1e3890d1
PE
6914 * lread.c: Make symbols static if they're not exported.
6915 (read_objects, initial_obarray, oblookup_last_bucket_number):
6916 Now static.
6917 (make_symbol): Remove; unused.
6918 * lisp.h (initial_obarray, make_symbol): Remove decls.
6919
8a1414fa
PE
6920 * keyboard.c: Make symbols static if they're not exported.
6921 (single_kboard, recent_keys_index, total_keys, recent_keys):
6922 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6923 (this_single_command_key_start, echoing, last_auto_save):
6924 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6925 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6926 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6927 (Vlispy_mouse_stem, double_click_count):
6928 Now static.
6929 (force_auto_save_soon): Define only if SIGDANGER.
6930 (ignore_mouse_drag_p): Now static if
6931 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6932 (print_help): Remove; unused.
6933 (stop_character, last_timer_event): Mark as externally visible.
6934 * keyboard.h (ignore_mouse_drag_p): Declare only if
6935 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6936 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6937 * lisp.h (echoing): Remove decl.
6938 (force_auto_save_soon): Declare only if SIGDANGER.
6939 * xdisp.c (redisplay_window): Simplify code, to make it more
6940 obvious that ignore_mouse_drag_p is not accessed if !defined
6941 USE_GTK && !defined HAVE_NS.
6942
93ea6e8f
PE
6943 * intervals.c: Make symbols static if they're not exported.
6944 (merge_properties_sticky, merge_interval_right, delete_interval):
6945 Now static.
6946 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6947
77382fcc
PE
6948 * insdel.c: Make symbols static if they're not exported.
6949 However, leave prepare_to_modify_buffer alone. It's never
6950 called from outside this function, but that appears to be a bug.
6951 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6952 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6953 (adjust_after_replace_noundo): Remove; unused.
6954 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6955 (signal_before_change): Remove decls.
77382fcc 6956
9306c32e
PE
6957 * indent.c (val_compute_motion, val_vmotion): Now static.
6958
cd44d2eb
PE
6959 * image.c: Make symbols static if they're not exported.
6960 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6961 if USE_GTK.
6962 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6963 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6964
ad9a7a06
PE
6965 * fringe.c (standard_bitmaps): Now static.
6966 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6967
81626931
PE
6968 * frame.c: Make symbols static if they're not exported.
6969 (x_report_frame_params, make_terminal_frame): Now static.
6970 (get_frame_param): Now static, unless HAVE_NS.
6971 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6972 (x_get_resource_string): Remove; not used.
6973 * frame.h (make_terminal_frame, x_report_frame_params):
6974 (x_get_resource_string); Remove decls.
6975 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6976 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6977
239f9db9
PE
6978 * font.c, fontset.c: Make symbols static if they're not exported.
6979 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6980 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6981 * font.c (font_close_object): Now static.
6982 * font.h (font_close_object): Remove.
6983 * fontset.c (FONTSET_OBJLIST): Remove.
6984 (free_realized_fontset) #if-0 the body, which does nothing.
6985 (face_suitable_for_char_p): #if-0, as it's never called.
6986 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6987 * xfaces.c (face_at_string_position):
6988 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6989 since 0 is always ASCII.
6990
dfcf3579
PE
6991 * fns.c (weak_hash_tables): Now static.
6992
5045092b
PE
6993 * fileio.c: Make symbols static if they're not exported.
6994 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6995 (Vwrite_region_annotation_buffers): Now static.
6996
57a96f5c
PE
6997 * eval.c: Make symbols static if they're not exported.
6998 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6999 * lisp.h (backtrace_list): Remove decl.
7000
35f08c38
PE
7001 * emacs.c: Make symbols static if they're not exported.
7002 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7003 (fatal_error_code, fatal_error_signal_hook, standard_args):
7004 Now static.
7005 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7006 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7007 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7008 * lisp.h (fatal_error_signal_hook): Remove decl.
7009 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7010
f44bd759
PE
7011 * editfns.c: Move a (normally-unused) function to its only use.
7012 * editfns.c, lisp.h (get_operating_system_release): Remove.
7013 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7014 worth the hassle of breaking this out.
7015
b532497d
PE
7016 * xterm.c: Make symbols static if they're not exported.
7017 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7018 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7019 (x_destroy_window, x_delete_display):
7020 Now static.
7021 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7022 (x_mouse_leave): Remove; unused.
7023 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7024 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7025 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7026 Remove decls.
7027 (x_mouse_leave): Declare only if WINDOWSNT.
7028 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7029 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7030 USE_X_TOOLKIT.
7031
1675728f
PE
7032 * ftxfont.c: Make symbols static if they're not exported.
7033 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7034 HAVE_FREETYPE.
7035 * font.h (ftxfont_driver): Likewise.
7036
e4cebfca
PE
7037 * xfns.c: Make symbols static if they're not exported.
7038 (x_last_font_name, x_display_info_for_name):
7039 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7040 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7041 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7042 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7043 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7044 (last_show_tip_args): Now static.
7045 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7046 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7047 (x_screen_planes): Remove; unused.
7048 * dispextern.h (x_screen_planes): Remove decl.
7049
5bf46f05
PE
7050 * dispnew.c: Make symbols static if they're not exported.
7051 * dispextern.h (redraw_garbaged_frames, scrolling):
7052 (increment_row_positions): Remove.
7053 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7054 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7055 Now static.
7056 (redraw_garbaged_frames): Remove; unused.
7057
435f4c28
PE
7058 * xfaces.c: Make symbols static if they're not exported.
7059 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7060 Remove decls.
7061 * xterm.h (defined_color): Remove decls.
7062 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7063 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7064 (menu_face_changed_default, defined_color, free_realized_face):
7065 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7066 (ascii_face_of_lisp_face): Remove; unused.
7067
8524aef3
PE
7068 * xdisp.c: Make symbols static if they're not exported.
7069 * dispextern.h (scratch_glyph_row, window_box_edges):
7070 (glyph_to_pixel_coords, set_cursor_from_row):
7071 (get_next_display_element, set_iterator_to_next):
7072 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7073 (show_mouse_face): Remove decls
7074 * frame.h (message_buf_print): Likewise.
7075 * lisp.h (pop_message, set_message, check_point_in_composition):
7076 Likewise.
7077 * xterm.h (set_vertical_scroll_bar): Likewise.
7078 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7079 (message_buf_print, scratch_glyph_row, displayed_buffer):
7080 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7081 (get_next_display_element, show_mouse_face, window_box_edges):
7082 (frame_to_window_pixel_xy, check_point_in_composition):
7083 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7084 (glyph_to_pixel_coords): Remove; unused.
7085
16390cd2
PE
7086 * dired.c (file_name_completion): Now static.
7087
7088 * dbusbind.c (xd_in_read_queued_messages): Now static.
7089
a25f4dfa
PE
7090 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7091 * data.c (circular_list_error): Remove.
7092
14a9c8df
PE
7093 * commands.h (last_point_position, last_point_position_buffer):
7094 (last_point_position_window): Remove decls.
7095 * keyboard.c: Make these variables static.
7096
04f2d78b
CB
7097 * coding.h (coding, code_convert_region, encode_coding_gap):
7098 Remove decls.
74ab6df5
PE
7099 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7100 (iso_code_class, detect_coding, code_convert_region): Now static.
7101 (encode_coding_gap): Remove; unused.
7102
38dfbee1
PE
7103 * chartab.c (chartab_chars, chartab_bits): Now static.
7104
a2cb4e63
PE
7105 * charset.h (charset_iso_8859_1): Remove decl.
7106 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7107 Now static.
7108
127198fd
PE
7109 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7110 * ccl.c (Vccl_program_table): Now static.
7111 (check_ccl_update): Remove; unused.
7112
d85b608f
PE
7113 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7114 * category.h: ... from here.
7115 * category.c (check_category_table, set_category_set): Now static.
7116
31cd66f3
PE
7117 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7118 * lisp.h: Remove these decls.
7119
c358e587
PE
7120 * buffer.c (buffer_count): Remove unused var.
7121
e78aecca
PE
7122 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7123 so that it's not optimized away.
7124 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7125 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7126 exported only to the debugger.
7127
e192d7d3 7128 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7129 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7130
92470028
PE
7131 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7132 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7133 was inaccessible from Lisp.
7134 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7135 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7136
244ed907
PE
7137 alloc.c: Import and export fewer symbols, and remove unused items.
7138 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7139 is defined.
7140 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7141 it's not optimized away by whole-program optimization.
7142 (message_enable_multibyte, free_misc): Remove.
7143 (catchlist, handlerlist, mark_backtrace):
7144 Declare only if BYTE_MARK_STACK.
7145 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7146 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7147 (message_enable_multibyte): Remove decl.
7148 (free_misc, interval_free_list, float_block, float_block_index):
7149 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7150 (cons_free_list, last_marked_index):
7151 Now static.
7152 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7153 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7154 (mark_backtrace): Define only if BYTE_MARK_STACK.
7155 * xdisp.c (message_enable_multibyte): Now static.
7156
61c2b50e 7157 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7158 This makes it easier for human readers (and static analyzers)
7159 to see whether these variables are used from other modules.
7160 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7161 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7162 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7163 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7164 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7165 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7166 * xmenu.c, xselect.c:
7167 Declare Q* vars static if they are not used in other modules.
7168 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7169 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7170 Remove decls of unexported vars.
7171 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7172
95c82688
PE
7173 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7174
16a97296
PE
7175 Make Emacs functions such as Fatom 'static' by default.
7176 This makes it easier for human readers (and static analyzers)
7177 to see whether these functions can be called from other modules.
7178 DEFUN now defines a static function. To make the function external
7179 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7180 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7181 (Finit_image_library):
16a97296
PE
7182 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7183 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7184 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7185 Remove decls, since these functions are now static.
7186 (Funintern, Fget_internal_run_time): New decls, since these functions
7187 were already external.
95c82688 7188
16a97296
PE
7189 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7190 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7191 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7192 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7193 * keyboard.c, keymap.c, lread.c:
7194 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7195 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7196 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7197 Mark functions with DEFUE instead of DEFUN,
7198 if they are used in other modules.
7199 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7200 decls for now-static functions.
7201 * buffer.h (Fdelete_overlay): Remove decl.
7202 * callproc.c (Fgetenv_internal): Mark as internal.
7203 * composite.c (Fremove_list_of_text_properties): Remove decl.
7204 (Fcomposition_get_gstring): New forward static decl.
7205 * composite.h (Fcomposite_get_gstring): Remove decl.
7206 * dired.c (Ffile_attributes): New forward static decl.
7207 * doc.c (Fdocumntation_property): New forward static decl.
7208 * eval.c (Ffetch_bytecode): New forward static decl.
7209 (Funintern): Remove extern decl; now in .h file where it belongs.
7210 * fileio.c (Fmake_symbolic_link): New forward static decl.
7211 * image.c (Finit_image_library): New forward static decl.
7212 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7213 * intervals.h (Fprevious_property_change):
7214 (Fremove_list_of_text_properties): Remove decls.
7215 * keyboard.c (Fthis_command_keys): Remove decl.
7216 (Fcommand_execute): New forward static decl.
7217 * keymap.c (Flookup_key): New forward static decl.
7218 (Fcopy_keymap): Now static.
7219 * keymap.h (Flookup_key): Remove decl.
7220 * process.c (Fget_process): New forward static decl.
7221 (Fprocess_datagram_address): Mark as internal.
7222 * syntax.c (Fsyntax_table_p): New forward static decl.
7223 (skip_chars): Remove duplicate decl.
7224 * textprop.c (Fprevious_property_change): New forward static decl.
7225 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7226 Now internal.
7227 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7228 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7229
785bbd42
PE
7230 * editfns.c (Fformat): Remove unreachable code.
7231
8b913b57
AS
72322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7233
7234 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7235 change. (Bug#8496)
7236
a6744a35
EZ
72372011-04-13 Eli Zaretskii <eliz@gnu.org>
7238
7239 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7240 when at ZV. (Bug#8487)
7241
e7974947
AS
72422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7243
baad03f0
AS
7244 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7245 (Bug#8437)
7246 * keyboard.c (parse_tool_bar_item): Likewise.
7247 * sound.c (sound_cleanup, alsa_close): Likewise.
7248 * termcap.c (tgetent): Likewise.
7249 * xfns.c (x_default_font_parameter): Likewise.
7250 * xsettings.c (read_and_apply_settings): Likewise.
7251
e7974947
AS
7252 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7253 (overrun_check_free): Protoize.
7254
28272684
PE
72552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7256
7257 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7258 since callers should never pass a negative size.
7259 Change the signature to match that of plain 'read' and 'write'; see
7260 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7261 * lisp.h: Update prototypes of emacs_write and emacs_read.
7262
11997c76
EZ
72632011-04-11 Eli Zaretskii <eliz@gnu.org>
7264
7265 * xdisp.c (redisplay_window): Don't try to determine the character
7266 position of the scroll margin if the window start point w->startp
e896f03c 7267 is outside the buffer's accessible region. (Bug#8468)
11997c76 7268
8a2cbd72
EZ
72692011-04-10 Eli Zaretskii <eliz@gnu.org>
7270
7271 Fix write-region and its subroutines for buffers > 2GB.
7272 * fileio.c (a_write, e_write): Modify declaration of arguments and
7273 local variables to support buffers larger than 2GB.
7274 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7275
7276 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7277 argument, local variables, and return value.
7278
7279 * lisp.h: Update prototypes of emacs_write and emacs_read.
7280
7281 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7282
4073e537 72832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7284
1ebfdcb6
PE
7285 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7286
b2ded58d
PE
7287 Fix more problems found by GCC 4.6.0's static checks.
7288
7d66342c
PE
7289 * xdisp.c (vmessage): Use a better test for character truncation.
7290
bbf47d44
PE
7291 * charset.c (load_charset_map): <, not <=, for optimization,
7292 and to avoid potential problems with integer overflow.
9248994d 7293 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7294 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7295 * editfns.c (Fformat): Likewise.
1e69125e 7296 * syntax.c (skip_chars): Likewise.
3befa583 7297
e3019616
PE
7298 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7299 This also lets GCC 4.6.0 generate slightly better loop code.
7300
becfa255
PE
7301 * callint.c (Fcall_interactively): <, not <=, for optimization.
7302 (Fcall_interactively): Count the number of arguments produced,
7303 not the number of arguments given. This is simpler and lets GCC
7304 4.6.0 generate slightly better code.
7305
dae0cd48
PE
7306 * ftfont.c: Distingish more carefully between FcChar8 and char.
7307 The previous code passed unsigned char * to a functions like
7308 strlen and xstrcasecmp that expect char *, which does not
7309 conform to the C standard.
7310 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7311 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7312 char * when the C standard requires it.
7313
76032d70
PE
7314 * keyboard.c (read_char): Remove unused var.
7315
eb3f1cc8
PE
7316 * eval.c: Port to Windows vsnprintf (Bug#8435).
7317 Include <limits.h>.
7318 (SIZE_MAX): Define if the headers do not.
7319 (verror): Do not give up if vsnprintf returns a negative count.
7320 Instead, grow the buffer. This ports to Windows vsnprintf, which
7321 does not conform to C99. Problem reported by Eli Zaretskii.
7322 Also, simplify the allocation scheme, by avoiding the need for
7323 calling realloc, and removing the ALLOCATED variable.
7324
70476b54
PE
7325 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7326
12020a9e
PE
7327 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7328 But keep the doprint source code for now, as we might revamp it
7329 and use it again (Bug#8435).
ea6c7ae6
PE
7330 * lisp.h (doprnt): Remove.
7331 * Makefile.in (base_obj): Remove doprnt.o.
7332 * deps.mk (doprnt.o): Remove.
7333
5fdb398c
PE
7334 error: Print 32- and 64-bit integers portably (Bug#8435).
7335 Without this change, on typical 64-bit hosts error ("...%d...", N)
7336 was used to print both 32- and 64-bit integers N, which relied on
7337 undefined behavior.
7338 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7339 New macro.
7340 * lisp.h (error, verror): Mark as printf-like functions.
7341 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7342 Report overflow in size calculations when allocating printf buffer.
7343 Do not truncate output string at its first null byte.
7344 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7345 Truncate the output at a character boundary, since vsnprintf does not
7346 do that.
7347 * charset.c (check_iso_charset_parameter): Convert internal
7348 character to string before calling 'error', since %c now has the
7349 printf meaning.
7350 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7351 overflow when computing char to be passed to 'error'. Do not
7352 pass Lisp_Object to 'error'; pass the integer instead.
7353 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7354 formatted with plain %d.
7355
b189fa66
PE
7356 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7357
bff87ef0
PE
7358 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7359
7e2cac20
PE
7360 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7361
ce4d90b5
PE
7362 * xterm.c (x_catch_errors): Remove duplicate declaration.
7363
266c9547
PE
7364 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7365
79c49ad2
PE
7366 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7367
368f4090
JM
73682011-04-10 Jim Meyering <meyering@redhat.com>
7369
7370 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7371 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7372 return ssize_t not "int", and use size_t as the buffer length.
7373 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7374 * gnutls.h: Update declarations.
7375 * process.c (read_process_output): Use ssize_t, to match.
7376 (send_process): Likewise.
7377
a32d4040
CY
73782011-04-09 Chong Yidong <cyd@stupidchicken.com>
7379
7380 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7381
8546720e 73822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7383
04f2d78b
CB
7384 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7385 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7386
8546720e
GM
7387 * xterm.c (handle_one_xevent):
7388 * xmenu.c (create_and_show_popup_menu):
7389 * xselect.c (x_decline_selection_request)
7390 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7391
0a2f5c1a 73922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7393
7394 Fix some uses of `int' instead of EMACS_INT.
7395 * search.c (string_match_1, fast_string_match)
7396 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7397 (scan_buffer, find_next_newline_no_quit)
7398 (find_before_next_newline, search_command, Freplace_match)
7399 (Fmatch_data): Make some `int' variables be EMACS_INT.
7400
7401 * xdisp.c (display_count_lines): 3rd argument and return value now
7402 EMACS_INT. All callers changed.
7403 (pint2hrstr): Last argument is now EMACS_INT.
7404
7405 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7406 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7407 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7408 (decode_coding_utf_16, decode_coding_emacs_mule)
7409 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7410 (decode_coding_ccl, decode_coding_charset)
7411 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7412 (decode_coding_iso_2022, decode_coding_emacs_mule)
7413 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7414 <char_offset, last_offset>: Declare EMACS_INT.
7415 (encode_coding_utf_8, encode_coding_utf_16)
7416 (encode_coding_emacs_mule, encode_invocation_designation)
7417 (encode_designation_at_bol, encode_coding_iso_2022)
7418 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7419 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7420 Declare EMACS_INT.
7421 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7422 (encode_invocation_designation): Last argument P_NCHARS is now
7423 EMACS_INT.
7424 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7425 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7426
7427 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7428 All users changed.
7429
7430 * ccl.c (Fccl_execute_on_string): Declare some variables
7431 EMACS_INT.
7432
8546720e 74332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7434
7435 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7436
4e19a977
CS
74372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7438
7439 * process.c (Fformat_network_address): Doc fix.
7440
87302331
R
74412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7442
ee7683eb 7443 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7444
cbb59342
CY
74452011-04-08 Chong Yidong <cyd@stupidchicken.com>
7446
7447 * keyboard.c (read_char): Call Lisp function help-form-show,
7448 instead of using internal_with_output_to_temp_buffer.
7449 (Qhelp_form_show): New var.
e0d38eeb 7450 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7451
7452 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7453
7454 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7455
e67a13ab
CY
74562011-04-06 Chong Yidong <cyd@stupidchicken.com>
7457
04f2d78b
CB
7458 * process.c (Flist_processes): Remove to Lisp.
7459 (list_processes_1): Delete.
e67a13ab 7460
973f782d
EZ
74612011-04-06 Eli Zaretskii <eliz@gnu.org>
7462
7c106b1e
EZ
7463 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7464
973f782d
EZ
7465 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7466
41cf7d1a 74672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7468
ca23cc88
PE
7469 Fix more problems found by GCC 4.6.0's static checks.
7470
f390e2d5
PE
7471 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7472
42eea0d0
PE
7473 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7474
b69769da 7475 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7476
f9541e84
PE
7477 * xdisp.c (vmessage): Mark as a printf-like function.
7478
13841b55
PE
7479 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7480
c136c10f
PE
7481 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7482
5e2d4a30
PE
7483 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7484 printf-like functions.
7485 (tiff_load): Add casts to remove these marks before passing them
7486 to system-supplied API.
7487
583f48b9
PE
7488 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7489
b25d760e
PE
7490 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7491 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7492 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7493 directly, rather than having caller test rule sign. This avoids
7494 some unnecessary tests.
7495 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7496 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7497 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7498
bc7b6697 7499 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7500 (xfont_open): Avoid unnecessary tests.
bc7b6697 7501
27ccc379
PE
7502 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7503
dcd5c89a
PE
7504 * composite.h, composite.c (composition_gstring_put_cache):
7505 Use EMACS_INT, not int, for length.
7506
b13a45c6
PE
7507 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7508 breaking out part of COMPOSITION_DECODE_RULE.
7509 (COMPOSITION_DECODE_RULE): Use it.
7510 * composite.c (get_composition_id): Remove unused local vars,
7511 by using the new macro.
7512
1e792e4d
PE
7513 * textprop.c (set_text_properties_1): Change while to do-while,
7514 since the condition is always true at first.
7515
dc6c6455 7516 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7517 (interval_deletion_adjustment): Return unsigned value.
7518 All uses changed.
dc6c6455 7519
aba7731a
PE
7520 * process.c (list_processes_1, create_pty, read_process_output):
7521 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7522 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7523 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7524 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7525 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7526
fdfc4bf3
PE
7527 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7528
fca8fe46 7529 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7530 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7531
06a0259a 7532 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7533 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7534 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7535
e7b9e80f
PE
7536 * print.c (print_error_message): Avoid int overflow.
7537
56201685
PE
7538 * font.c (font_list_entities): Redo for clarity,
7539 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7540
78834453 7541 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7542 (font_score): Avoid potential overflow in diff calculation.
78834453 7543
0bc0b309 7544 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7545 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7546
e610eaca
PE
7547 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7548
b895abce
PE
7549 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7550 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7551 can always succeed if overflow has undefined behavior.
7552
1f1d9321 7553 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7554 (wordify): Omit three unnecessary tests.
1f1d9321 7555
c59478bc
PE
7556 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7557 All callers changed. This avoids the need for an unused var.
7558
79b73827
PE
7559 * casefiddle.c (casify_region): Remove var that is set but not used.
7560
a4db5dfe
PE
7561 * dired.c (file_name_completion): Remove var that is set but not used.
7562
43aae36e
PE
7563 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7564
2a47c44d 7565 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7566 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7567
a37c69bf
PE
7568 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7569 Check for integer overflow on size calculations.
7570
328ab8e7
PE
7571 * buffer.c (Fprevious_overlay_change): Remove var that is set
7572 but not used.
7573
e5a2a5cb
PE
7574 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7575 Remove vars that are set but not used.
8d84a6eb 7576 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7577 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7578
a60e5f68
PE
7579 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7580
f661cb61 7581 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7582 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7583
f0397f5a
PE
7584 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7585 that are set but not used.
7586
8664db06 7587 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7588 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7589
6abdaa4a
PE
7590 * xselect.c (x_get_local_selection, x_handle_property_notify):
7591 Remove vars that are set but not used.
7592
0ce7538d 7593 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7594 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7595
9ae848fc
PE
7596 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7597 Remove var that is set but not used.
0b918413
PE
7598 (scroll_bar_windows_size): Now size_t, not int.
7599 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7600 Check for overflow.
9ae848fc 7601
a5a62657
PE
7602 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7603 (map_tty_color) [!defined MSDOS]: Likewise.
7604
5c5cdd39
PE
7605 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7606
66ebf983
PE
7607 * coding.c: Remove vars that are set but not used.
7608 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7609 All callers changed.
7610 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7611 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7612 (decode_coding_charset): Remove vars that are set but not used.
7613
1be4d761
PE
7614 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7615 that is set but not used.
7616
47553fa8
PE
7617 * print.c (print_object): Remove var that is set but not used.
7618
1f7196bf 7619 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7620 The gnulib version avoids calling malloc in the usual case,
7621 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7622 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7623 * filelock.c (current_lock_owner): Likewise.
7624 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7625 * sysdep.c: Include allocator.h, careadlinkat.h.
7626 (emacs_no_realloc_allocator): New static constant.
7627 (emacs_readlink): New function.
fdb61804
PE
7628 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7629 ../lib/careadlinkat.h.
d1fdcab7 7630
f84c17c7
SM
76312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7632
7633 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7634 first non-nil return value).
7635
ef3862ad
JD
76362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7637
7638 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7639 if not defined (Bug#8403).
7640
376a7006
JB
76412011-04-02 Juanma Barranquero <lekktu@gmail.com>
7642
7643 * xdisp.c (display_count_lines): Remove parameter `start',
7644 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7645 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7646 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7647 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7648 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7649 and thereabouts. All callers changed.
7650 (get_per_char_metric): Remove parameter `f', unused since
7651 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7652
6ca3801d
JM
76532011-04-02 Jim Meyering <meyering@redhat.com>
7654
7655 do not dereference NULL upon failed strdup
7656 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7657 (ns_get_family): Likewise.
7658
d8e2b5ba
JB
76592011-04-02 Juanma Barranquero <lekktu@gmail.com>
7660
7661 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7662
8c74fcbd
JD
76632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7664
7665 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7666 later (Bug#8403).
7667
7200d79c
SM
76682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7669
03408648 7670 Add lexical binding.
7200d79c 7671
03408648
SM
7672 * window.c (Ftemp_output_buffer_show): New fun.
7673 (Fsave_window_excursion):
7674 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7675
7676 * lread.c (lisp_file_lexically_bound_p): New function.
7677 (Fload): Bind Qlexical_binding.
7678 (readevalloop): Remove `evalfun' arg.
7679 Bind Qinternal_interpreter_environment.
7680 (Feval_buffer): Bind Qlexical_binding.
7681 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7682 Mark as dynamic.
7683 (syms_of_lread): Declare `lexical-binding'.
7684
7685 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7686
7687 * keyboard.c (eval_dyn): New fun.
7688 (menu_item_eval_property): Use it.
ca105506
SM
7689
7690 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7691
03408648
SM
7692 * fns.c (concat, mapcar1): Accept byte-code-functions.
7693
7694 * eval.c (Fsetq): Handle lexical vars.
7695 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7696 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7697 (FletX, Flet): Obey lexical binding.
7698 (Fcommandp): Handle closures.
7699 (Feval): New `lexical' arg.
7700 (eval_sub): New function extracted from Feval. Use it almost
7701 everywhere where Feval was used. Look up vars in lexical env.
7702 Handle closures.
7703 (Ffunctionp): Move from subr.el.
7704 (Ffuncall): Handle closures.
7705 (apply_lambda): Remove `eval_flags'.
7706 (funcall_lambda): Handle closures and new byte-code-functions.
7707 (Fspecial_variable_p): New function.
7708 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7709 but without exporting it to Lisp.
23aba0ea 7710
23aba0ea 7711 * doc.c (Fdocumentation, store_function_docstring):
03408648 7712 * data.c (Finteractive_form): Handle closures.
23aba0ea 7713
03408648
SM
7714 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7715 interactive spec.
ba83908c 7716
04f2d78b
CB
7717 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7718 New byte-codes.
03408648
SM
7719 (exec_byte_code): New function extracted from Fbyte_code to handle new
7720 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7721
03408648 7722 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7723
03408648 7724 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7725
e2abce01
JB
77262011-03-31 Juanma Barranquero <lekktu@gmail.com>
7727
7728 * xdisp.c (redisplay_internal): Fix prototype.
7729
63696a73 77302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7731
63696a73 7732 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7733 (try_scrolling): Use it when setting scroll_limit.
7734 Limit scrolling to 100 screen lines.
63696a73
EZ
7735 (redisplay_window): Even when falling back on "recentering",
7736 position point in the window according to scroll-conservatively,
7737 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7738
7739 (try_scrolling): When point is above the window, allow searching
7740 as far as scroll_max, or one screenful, to compute vertical
7741 distance from PT to the scroll margin position. This prevents
7742 try_scrolling from unnecessarily failing when
7743 scroll-conservatively is set to a value slightly larger than the
7744 window height. Clean up the case of PT below the margin at bottom
7745 of window: scroll_max can no longer be INT_MAX. When aggressive
7746 scrolling is in use, don't let point enter the opposite scroll
7747 margin as result of the scroll.
7748 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7749 threshold of 100 lines for never-recentering scrolling.
7750
e4cc2dfc
JB
77512011-03-31 Juanma Barranquero <lekktu@gmail.com>
7752
7753 * dispextern.h (move_it_by_lines):
7754 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7755 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7756 (message_log_check_duplicate): Remove parameters `prev_bol' and
7757 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7758 (redisplay_internal): Remove parameter `preserve_echo_area',
7759 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7760
7761 * indent.c (Fvertical_motion):
7762 * window.c (window_scroll_pixel_based, Frecenter):
7763 Don't pass `need_y_p' to `move_it_by_lines'.
7764
1c470562
SM
77652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7766
44f230aa
SM
7767 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7768 steal a few bits to be more compact.
7769 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7770 Remove unneeded casts.
7771
1c470562
SM
7772 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7773
888adce9
ZK
77742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7775
7776 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7777 binding" message (bug#7967).
7778
f838ed7b
PE
77792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7780
77861b95
PE
7781 Fix more problems found by GCC 4.6.0's static checks.
7782
de6dbc14
PE
7783 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7784 Remove unused local var.
7785
f838ed7b
PE
7786 * editfns.c (Fmessage_box): Remove unused local var.
7787
792c7b2b
PE
7788 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7789 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7790 Omit unused local vars.
c499e557 7791 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7792 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7793 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7794 Omit unused local var.
7795
ba0165e1
PE
7796 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7797 Don't assume string length fits in int.
32ad8845 7798 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7799 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7800
3c59b4c9
PE
7801 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7802 instead of alloca (Bug#8344).
7803
a3eed478 7804 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7805 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7806
eb4d412d
PE
7807 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7808
1658b401
PE
7809 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7810 concerns.
7811
7812 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7813
7814 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7815
9a2c6e05
PE
7816 * keyboard.c (syms_of_keyboard): Use the same style as later
7817 in this function when indexing through an array. This also
7818 works around GCC bug 48267.
7819
03d0a109
PE
7820 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7821
44f730c8
PE
7822 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7823
fe75f926
PE
7824 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7825 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7826
ffa8c828
PE
7827 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7828 This avoids undefined behavior on integer overflow, and is a bit
7829 more convenient anyway since it is compared to a size_t variable.
7830
c5101a77
PE
7831 Variadic C functions now count arguments with size_t, not int.
7832 This avoids an unnecessary limitation on 64-bit machines, which
7833 caused (substring ...) to crash on large vectors (Bug#8344).
7834 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7835 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7836 All variadic functions and their callers changed accordingly.
c5101a77
PE
7837 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7838 * data.c (arith_driver, float_arith_driver): Likewise.
7839 * editfns.c (general_insert_function): Likewise.
7840 * eval.c (struct backtrace.nargs, interactive_p)
7841 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7842 (funcall_lambda, mark_backtrace): Likewise.
7843 * fns.c (concat): Likewise.
7844 * frame.c (x_set_frame_parameters): Likewise.
7845 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7846 0 if not found, not -1. All callers changed.
7847
dd3f25f7
PE
7848 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7849 (stack_copy_size): Now size_t, not int.
7850 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7851
461c2ab9
JB
78522011-03-28 Juanma Barranquero <lekktu@gmail.com>
7853
7854 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7855 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7856 All callers changed.
7857
7858 * lisp.h (multibyte_char_to_unibyte):
7859 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7860 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7861 * character.h (CHAR_TO_BYTE8):
7862 * cmds.c (internal_self_insert):
7863 * editfns.c (general_insert_function):
7864 * keymap.c (push_key_description):
7865 * search.c (Freplace_match):
7866 * xdisp.c (message_dolog, set_message_1): All callers changed.
7867
f6d62986
SM
78682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7869
7870 * keyboard.c (safe_run_hook_funcall): New function.
7871 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7872 don't set the hook to nil, but remove the offending function instead.
7873 (Qcommand_hook_internal): Remove, unused.
7874 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7875 Vcommand_hook_internal.
7876
7877 * eval.c (enum run_hooks_condition): Remove.
7878 (funcall_nil, funcall_not): New functions.
7879 (run_hook_with_args): Call each function through a `funcall' argument.
7880 Remove `cond' argument, now redundant.
7881 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7882 (Frun_hook_with_args_until_failure): Adjust accordingly.
7883 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7884
1db5b1ad
JB
78852011-03-28 Juanma Barranquero <lekktu@gmail.com>
7886
7887 * dispextern.h (string_buffer_position): Remove declaration.
7888
7889 * print.c (strout): Remove parameter `multibyte', unused since
7890 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7891
7892 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7893 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7894 All callers changed.
7895
7896 * w32.c (_wsa_errlist): Use braces for struct initializers.
7897
7898 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7899 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7900 All callers changed.
7901 (string_buffer_position): Likewise. Also, make static (it's never
7902 used outside xdisp.c).
7903 (cursor_row_p): Remove parameter `w', unused since
7904 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7905 (decode_mode_spec): Remove parameter `precision', introduced during
7906 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7907 All callers changed.
7908
5ffb62aa
JD
79092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7910
7911 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7912
461c2ab9 79132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7914
7915 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7916 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7917 (ns_update_auto_hide_menu_bar): New functions.
7918 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7919 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7920 ns_constrain_all_frames.
7921 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7922 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7923
5c380ffb
JD
79242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7925
7926 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7927
9af30bdf
GM
79282011-03-27 Glenn Morris <rgm@gnu.org>
7929
7930 * syssignal.h: Replace RETSIGTYPE with void.
7931 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7932 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7933 Replace SIGTYPE with void everywhere.
7934 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7935 * s/template.h (SIGTYPE): Remove commented out definition.
7936
e2abce01
JB
79372011-03-26 Eli Zaretskii <eliz@gnu.org>
7938
7939 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7940 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7941
f868cd8a
JB
79422011-03-26 Juanma Barranquero <lekktu@gmail.com>
7943
59eb0929
JB
7944 * w32.c (read_unc_volume): Use parameter `henum', instead of
7945 global variable `wget_enum_handle'.
7946
7947 * keymap.c (describe_vector): Remove parameters `indices' and
7948 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7949 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7950
f868cd8a
JB
7951 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7952
7953 * keyboard.c (timer_check): Remove parameter `do_it_now',
7954 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7955 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7956 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7957
7958 * keyboard.c (read_char):
7959 * w32menu.c (w32_menu_display_help):
7960 * xmenu.c (show_help_event, menu_help_callback):
7961 Adjust calls to `show_help_echo'.
7962
7963 * gtkutil.c (xg_maybe_add_timer):
7964 * keyboard.c (readable_events):
7965 * process.c (wait_reading_process_output):
7966 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7967
7968 * insdel.c (adjust_markers_gap_motion):
7969 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7970 (gap_left, gap_right): Don't call it.
7971
2ecf6fdb
CY
79722011-03-25 Chong Yidong <cyd@stupidchicken.com>
7973
7974 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7975 incurred during fontification.
7976
6b1f9ba4
JB
79772011-03-25 Juanma Barranquero <lekktu@gmail.com>
7978
7979 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7980 (DEFVAR_PER_BUFFER): Don't pass it.
7981
7982 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7983 (scrolling_window): Don't pass it.
7984
0f4a96b5
JB
79852011-03-25 Juanma Barranquero <lekktu@gmail.com>
7986
7987 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7988
7989 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7990 and `suffix'.
7991 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7992 of variables specific to SELinux and computation of `encoded_absname'.
7993
7994 * image.c (XPutPixel): Remove unused variable `height'.
7995
7996 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7997
7998 * unexw32.c (get_section_info): Remove unused variable `section'.
7999
8000 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8001 (system_process_attributes): Remove unused variable `sess'.
8002 (sys_read): Remove unused variable `err'.
8003
8004 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8005 (w32_wnd_proc): Remove unused variable `isdead'.
8006 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8007 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8008 (x_create_tip_frame): Remove unused variable `tem'.
8009
8010 * w32inevt.c (w32_console_read_socket):
8011 Remove unused variable `no_events'.
8012
8013 * w32term.c (x_draw_composite_glyph_string_foreground):
8014 Remove unused variable `width'.
8015
1149507c
JB
80162011-03-24 Juanma Barranquero <lekktu@gmail.com>
8017
8018 * w32term.c (x_set_glyph_string_clipping):
8019 Don't pass uninitialized region to CombineRgn.
8020
9c88f339
JB
80212011-03-23 Juanma Barranquero <lekktu@gmail.com>
8022
8023 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8024 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8025 (Fx_close_connection): Remove unused variable `i'.
8026
8027 * w32font.c (w32font_draw): Return number of glyphs.
8028 (w32font_open_internal): Remove unused variable `i'.
8029 (w32font_driver): Add missing initializer.
8030
8031 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8032 (fill_in_menu): Remove unused variable `items_added'.
8033
8034 * w32term.c (last_mouse_press_frame): Remove static global variable.
8035 (w32_clip_to_row): Remove unused variable `f'.
8036 (x_delete_terminal): Remove unused variable `i'.
8037
8038 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8039 (NOTHING): Remove unused static global variable.
8040 (uniscribe_check_otf): Remove unused variable `table'.
8041 (uniscribe_font_driver): Add missing initializers.
8042
dee091a3
JD
80432011-03-23 Julien Danjou <julien@danjou.info>
8044
8045 * term.c (Fsuspend_tty, Fresume_tty):
8046 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8047 * window.c (temp_output_buffer_show):
8048 * insdel.c (signal_before_change):
8049 * frame.c (Fhandle_switch_frame):
8050 * fileio.c (Fdo_auto_save):
8051 * emacs.c (Fkill_emacs):
8052 * editfns.c (save_excursion_restore):
8053 * cmds.c (internal_self_insert):
8054 * callint.c (Fcall_interactively):
8055 * buffer.c (Fkill_all_local_variables):
8056 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8057 Use Frun_hooks.
0f4a96b5 8058 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8059 unconditionally since it does the check itself.
dee091a3 8060
2c520ab5 80612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8062
c9c49752
PE
8063 Fix more problems found by GCC 4.5.2's static checks.
8064
8abc3f12
PE
8065 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8066 the first time through the loop, since we know p0 < p1 then.
8067 This also avoids a gcc -Wstrict-overflow warning.
8068
a2d26660
PE
8069 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8070 leading to a memory leak, possible in functions like
8071 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8072 of objects (Bug#8318).
a2d26660 8073
916c72e9
PE
8074 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8075 that could (at least in theory) be that large.
8076
19ab8a18
PE
8077 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8078 This is less likely to overflow, and avoids undefined behavior if
8079 overflow does occur. All callers changed. Use strtoul to scan
8080 for the unsigned long integer.
b7cbbd6f
PE
8081 (pint2hrstr): Simplify and tune code slightly.
8082 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8083
f0641eff
PE
8084 * scroll.c (do_scrolling): Work around GCC bug 48228.
8085 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8086
7f650bb9
PE
8087 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8088 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8089 (validate_x_resource_name): Simplify count usage.
8090 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8091
37dd57d1
PE
8092 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8093 fail (Bug#8306).
81e56e61 8094
699979fc 8095 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8096
401bf9b4
PE
8097 * process.c (Fmake_network_process): Use socklen_t, not int,
8098 where POSIX says socklen_t is required in portable programs.
8099 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8100 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8101 (Fmake_network_process, server_accept_connection):
8102 (wait_reading_process_output, read_process_output):
8103 Likewise.
8104
b93aacde
PE
8105 * process.c: Rename or move locals to avoid shadowing.
8106 (list_processes_1, Fmake_network_process):
8107 (read_process_output_error_handler, exec_sentinel_error_handler):
8108 Rename or move locals.
4dc343ee 8109 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8110 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8111 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8112 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8113 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8114
af8a867c 8115 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8116 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8117 Include tparam.h instead, since it declares them.
af8a867c
PE
8118 * cm.h (PC): Remove extern decl; tparam.h now does this.
8119 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8120 * terminfo.c: Include tparam.h, to check interfaces.
8121 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8122 (tparam): Adjust signature to match interface in tparam.h;
8123 this removes some undefined behavior. Check that outstring and len
8124 are zero, which they always are with Emacs.
8125 * tparam.h (PC, BC, UP): New extern decls.
8126
0248044d 8127 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8128 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8129
8ff096c1 8130 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8131 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8132 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8133 (ftfont_list): Remove unused local.
49eaafba
PE
8134 (get_adstyle_property, ftfont_pattern_entity):
8135 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8136 Rename locals to avoid shadowing.
8ff096c1 8137
e2be39f6
PE
8138 * xfont.c (xfont_list_family): Mark var as initialized.
8139
c9735e30
PE
8140 * xml.c (make_dom): Now static.
8141
8f5201ae
PE
8142 * composite.c (composition_compute_stop_pos): Rename local to
8143 avoid shadowing.
b246f932
PE
8144 (composition_reseat_it): Remove unused locals.
8145 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8146 (composition_update_it): Mark var as initialized.
11b61122
PE
8147 (find_automatic_composition): Mark vars as initialized,
8148 with a FIXME (Bug#8290).
8f5201ae 8149
760fbc2c
PE
8150 character.h: Rename locals to avoid shadowing.
8151 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8152 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8153 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8154 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8155 to avoid shadowing.
8156
ff08eb85
PE
8157 * textprop.c (property_change_between_p): Remove; unused.
8158
fc7bf025
PE
8159 * intervals.c (interval_start_pos): Now static.
8160
235d7abc
PE
8161 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8162
44f230aa
SM
8163 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8164 Rename locals to avoid shadowing.
3e7d6594 8165
50060332
PE
8166 * sound.c (wav_play, au_play, Fplay_sound_internal):
8167 Fix pointer signedness.
d01f234b 8168 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8169 (wav_play): Initialize a variable to 0, to prevent undefined
8170 behavior (Bug#8278).
50060332 8171
c4fc4e30
PE
8172 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8173
918436ed
PE
8174 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8175
c939f91b
PE
8176 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8177 clobbering (Bug#8298).
b9c7f648
PE
8178 * sysdep.c (sys_subshell): Likewise.
8179 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8180
6bd8c144
PE
8181 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8182 This should get cleaned up, so that child_setup has the
8183 same signature on all platforms.
8184
7710357c 8185 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8186 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8187
c59da222
CY
81882011-03-22 Chong Yidong <cyd@stupidchicken.com>
8189
8190 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8191 not to be necessary, and produces flickering.
8192
66b87493
GM
81932011-03-20 Glenn Morris <rgm@gnu.org>
8194
8195 * config.in: Remove file.
8196
45b6f6d5
JB
81972011-03-20 Juanma Barranquero <lekktu@gmail.com>
8198
8199 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8200 are now in src/globals.h.
8201 (syms_of_minibuf): Remove spurious & from previous change.
8202
3ec03f7e
LL
82032011-03-20 Leo <sdl.web@gmail.com>
8204
8205 * minibuf.c (completing-read-function): New variable.
8206 (completing-read-default): Rename from completing-read.
8207 (completing-read): Call completing-read-function.
8208
b14e3e21
CY
82092011-03-19 Juanma Barranquero <lekktu@gmail.com>
8210
8211 * xfaces.c (Fx_load_color_file):
8212 Read color file from absolute filename (bug#8250).
8213
f2b726e6
JB
82142011-03-19 Juanma Barranquero <lekktu@gmail.com>
8215
8216 * makefile.w32-in: Update dependencies.
8217
09f6ff02
EZ
82182011-03-17 Eli Zaretskii <eliz@gnu.org>
8219
8220 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8221
29a6015a
PE
82222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8223
a3a6c54e
PE
8224 Fix more problems found by GCC 4.5.2's static checks.
8225
b766f867
PE
8226 * process.c (make_serial_process_unwind, send_process_trap):
8227 (sigchld_handler): Now static.
8228
be02381c
PE
8229 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8230 That way, the code declares only the vars that it needs.
8231 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8232 * s/cygwin.h (PTY_ITERATION): Likewise.
8233 * s/darwin.h (PTY_ITERATION): Likewise.
8234 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8235
57048744
PE
8236 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8237 * process.c (allocate_pty): Don't declare stb unless it's needed.
8238
7914961c 8239 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8240 (CONSTANTLIM): Remove; unused.
8241 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8242 Define only if needed.
7914961c 8243
b3967b18
PE
8244 * unexelf.c (unexec): Name an expression,
8245 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8246 Use a different way to cause a compilation error if anyone uses
8247 n rather than nn, a way that does not involve shadowing.
73366a00 8248 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8249
29a6015a
PE
8250 * deps.mk (unexalpha.o): Remove; unused.
8251
43cfc33e 8252 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8253 * unexec.h: New file.
ce701a33
PE
8254 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8255 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8256 Depend on unexec.h.
8257 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8258 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8259 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8260 Change as necessary to match prototype in unexec.h.
ce701a33 8261
01f44d5a
PE
8262 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8263 shadowing.
4f63c6bb 8264 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8265
a6670b0b
PE
8266 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8267 Rename locals to avoid shadowing.
8268
cef2010d 8269 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8270 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8271
d4d7173a
PE
8272 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8273
f08b802a
PE
8274 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8275 warning when compiling print.c.
8276
3ddb0639
PE
8277 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8278 instead of using an uninitialized var.
5ad03b97 8279 (font_sort_entities): Mark var as initialized.
3ddb0639 8280
170a2692
PE
8281 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8282
e663c700
PE
8283 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8284 pointers to constants.
89bc529a 8285 (font_parse_fcname): Remove unused vars.
7b81e2d0 8286 (font_delete_unmatched): Now static.
ea838e10 8287 (font_get_spec): Remove; unused.
13a547c6
PE
8288 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8289 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8290 Rename or move locals to avoid shadowing.
e663c700 8291
2a80c887 8292 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8293 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8294
1384fa33 8295 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8296 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8297
8b2c52e9
PE
8298 * alloc.c (mark_backtrace): Move decl from here ...
8299 * lisp.h: ... to here, so that it can be checked.
8300
475545b5 8301 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8302 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8303 (lisp_indirect_variable): Name an expression,
8304 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8305 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8306
b1349114 8307 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8308 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8309 Use const pointer when appropriate.
b1349114 8310
a2928364
PE
8311 * lisp.h (get_system_name, get_operating_system_release):
8312 Move decls here, to check interfaces.
8313 * process.c (get_operating_system_release): Move decl to lisp.h.
8314 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8315 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8316 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8317 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8318 (Fformat_time_string, Fencode_time, Finsert_char):
8319 (Ftranslate_region_internal, Fformat):
8320 Rename or remove local vars to avoid shadowing.
9710023e 8321 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8322
a415e694
PE
8323 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8324 avoid shadowing.
8325
8ef4622d
PE
8326 * lisp.h (eassert): Check that the argument compiles, even if
8327 ENABLE_CHECKING is not defined.
8328
946f9a5b
PE
8329 * data.c (Findirect_variable): Name an expression, to avoid
8330 gcc -Wbad-function-cast warning.
112396d6 8331 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8332 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8333 (Fmake_variable_buffer_local, Fmake_local_variable):
8334 Mark variables as initialized.
52746918 8335 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8336
e5aab7e7 8337 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8338 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8339 Rename locals to avoid shadowing.
dff45157
PE
8340 (mark_stack): Move local variables into the #ifdef region where
8341 they're used.
7bc26fdb
PE
8342 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8343 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8344 needed otherwise.
8345 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8346 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8347 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8348
e5aab7e7
PE
8349 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8350 avoids undefined behavior in theory.
8351
4da60324
PE
8352 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8353
88043301
PE
8354 Use functions, not macros, for up- and down-casing (Bug#8254).
8355 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8356 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8357 to use the following functions instead of these macros.
8358 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8359 EMACS_INT, since callers assume the returned value fits in int.
8360 (upcase1): Likewise, for UPCASE_TABLE.
8361 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8362 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8363 the race-condition problem in the old DOWNCASE.
88043301 8364
19ed5445
PE
8365 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8366 Rename locals to avoid shadowing.
8367 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8368 (regex_compile, re_search_2, re_match_2_internal):
8369 Remove unused local vars.
952db0d7
PE
8370 (FREE_VAR): Rewrite so as not to use empty "else",
8371 which gcc can warn about.
da053e48 8372 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8373 (RETALLOC_IF): Define only if needed.
8374 (WORDCHAR_P): Likewise. This one is never needed, but is used
8375 only in a comment talking about a compiler bug, so put inside
8376 the #if 0 of that comment.
8377 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8378 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8379 Remove; unused.
19ed5445 8380
1f3561e4 8381 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8382 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8383 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8384
ded6f8f7
PE
8385 * search.c (simple_search): Remove unused var.
8386
dbd37a95
PE
8387 * dired.c (compile_pattern): Move decl from here ...
8388 * lisp.h: ... to here, so that it can be checked.
8389 (struct re_registers): New forward decl.
8390
7e47afad
PE
8391 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8392
85f24f61
PE
8393 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8394 All uses changed.
8395 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8396 Rename locals to avoid shadowing.
5671df8f 8397 (Fvertical_motion): Mark locals as initialized.
85f24f61 8398
181aa2be 8399 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8400 (casify_region): Mark local as initialized.
181aa2be 8401
930d429c
PE
8402 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8403
7082eac6
PE
8404 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8405 New macros, so that the caller can use some names other than
8406 gcpro1, gcpro2, etc.
8407 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8408 of the new macros.
8409 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8410 argument, for consistency with GCPRO2_VAR, etc: it is now the
8411 prefix of the variable, not the variable itself. All uses
8412 changed.
38b2c076
PE
8413 * dired.c (directory_files_internal, file_name_completion):
8414 Rename locals to avoid shadowing.
8415
15206ed9
PE
8416 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8417 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8418 dired.c's scmp function, had undefined behavior.
8419 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8420 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8421 * buffer.h: ... to here, because these macros use current_buffer,
8422 and the new implementation with inline functions needs to have
8423 current_buffer in scope now, rather than later when the macros
8424 are used.
8425 (downcase, upcase1): New static inline functions.
8426 (DOWNCASE, UPCASE1): Reimplement using these functions.
8427 This avoids undefined behavior in expressions like
8428 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8429 from race conditions in accessing the global variables
8430 case_temp1 and case_temp2.
8431 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8432 * lisp.h (case_temp1, case_temp2): Remove their decls.
8433 * character.h (ASCII_CHAR_P): Move from here ...
8434 * lisp.h: ... to here, so that the inline functions mentioned
8435 above can use them.
8436
4a6bea26
PE
8437 * dired.c (directory_files_internal_unwind): Now static.
8438
f14b7e14
PE
8439 * fileio.c (file_name_as_directory, directory_file_name):
8440 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8441 Now static.
2893f146
PE
8442 (file_name_as_directory): Use const pointers when appropriate.
8443 (Fexpand_file_name): Likewise. In particular, newdir might
8444 point at constant storage, so make it a const pointer.
fd4ead52 8445 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8446 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8447 signedness issues.
f839df0c
PE
8448 (Fset_file_times, Finsert_file_contents, auto_save_error):
8449 Rename locals to avoid shadowing.
f14b7e14 8450
5716756e 8451 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8452 (Ftry_completion, Fall_completions): Rename or remove locals
8453 to avoid shadowing.
5716756e 8454
b4c3046a
PE
8455 * marker.c (bytepos_to_charpos): Remove; unused.
8456
b45db522
PE
8457 * lisp.h (verify_bytepos, count_markers): New decls,
8458 so that gcc does not warn that these functions aren't declared.
8459
85876d07
PE
8460 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8461 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8462 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8463 (copy_text): Remove unused local var.
85876d07 8464
03d78a21 8465 * filelock.c (within_one_second): Now static.
b3dd38ab 8466 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8467
5df8f01b
PE
8468 * buffer.c (fix_overlays_before): Mark locals as initialized.
8469 (fix_start_end_in_overlays): Likewise. This function should be
8470 simplified by using pointers-to-pointers, but that's a different
8471 matter.
b1d876f1 8472 (switch_to_buffer_1): Now static.
8f54f30a
PE
8473 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8474 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8475
a70072c9 8476 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8477 Fix pointer signedness issue.
edced198
PE
8478 (sys_subshell): Mark local as volatile if checking for lint,
8479 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8480 (MAXPATHLEN): Define only if needed.
a70072c9 8481
a0977c44
PE
8482 * process.c (serial_open, serial_configure): Move decls from here ...
8483 * systty.h: ... to here, so that they can be checked.
8484
a884fdcc
PE
8485 * fns.c (get_random, seed_random): Move extern decls from here ...
8486 * lisp.h: ... to here, so that they can be checked.
8487
604efe86 8488 * sysdep.c (reset_io): Now static.
b8950c94 8489 (wait_for_termination_signal): Remove; unused.
604efe86 8490
38fc62d9
PE
8491 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8492 (copy_keymap_item, append_key, push_text_char_description):
8493 Now static.
1004a21a 8494 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8495 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8496 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8497 (describe_map_tree):
8498 Rename locals to avoid shadowing.
38fc62d9 8499
2f2650da
PE
8500 * keyboard.c: Declare functions static if they are not used elsewhere.
8501 (echo_char, echo_dash, cmd_error, top_level_2):
8502 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8503 (read_char, kbd_buffer_get_event, make_lispy_position):
8504 (make_lispy_event, make_lispy_movement, apply_modifiers):
8505 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8506 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8507 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8508 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8509 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8510
a053e86c 8511 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8512 (mark_kboards): Move decl here ...
8513 * alloc.c (mark_kboards): ... from here.
a053e86c 8514
4752793e
PE
8515 * lisp.h (force_auto_save_soon): New decl.
8516
74f10ca7 8517 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8518 (DEFINE_DUMMY_FUNCTION): New macro.
8519 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8520 Use it.
c03cd23f
PE
8521 (main): Add casts to avoid warnings
8522 if GCC considers string literals to be constants.
74f10ca7 8523
022e70d4
PE
8524 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8525
59d6fe83
PE
8526 * dbusbind.c: Pointer signedness fixes.
8527 (xd_signature, xd_append_arg, xd_initialize):
8528 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8529 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8530 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8531 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8532
78320123
PE
8533 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8534 if GCC considers string literals to be constants.
49cebcca 8535 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8536
35ac2a97
SM
85372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8538
fb103ca9
SM
8539 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8540 (print_preprocess, print_object): New macro to fix last change.
8541
35ac2a97
SM
8542 * print.c (print_preprocess): Don't forget font objects.
8543
62973b41
JB
85442011-03-16 Juanma Barranquero <lekktu@gmail.com>
8545
8546 * emacs.c (USAGE3): Doc fixes.
8547
0e48bb22
AS
85482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8549
8550 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8551 structure.
8552
7684e57b
JB
85532011-03-14 Juanma Barranquero <lekktu@gmail.com>
8554
8555 * lisp.h (VWindow_system, Qfile_name_history):
8556 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8557 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8558 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8559
8560 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8561 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8562
8563 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8564 * w32console.c (detect_input_pending, read_input_pending)
8565 (encode_terminal_code):
8566 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8567 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8568 (w32_system_caret_y, Qfile_name_history):
8569 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8570 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8571 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8572 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8573 * w32proc.c (Qlocal, report_file_error):
8574 * w32term.c (Vwindow_system, updating_frame):
8575 * w32uniscribe.c (initialized, uniscribe_font_driver):
8576 Remove unneeded extern declarations.
8577
2aa46d6c
CY
85782011-03-14 Chong Yidong <cyd@stupidchicken.com>
8579
c96bbc66 8580 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8581
cffc6f3b
CY
85822011-03-13 Chong Yidong <cyd@stupidchicken.com>
8583
8584 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8585 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8586 These macros can no longer be used for assignment.
8587
44f230aa
SM
8588 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8589 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8590 (record_buffer_markers, fetch_buffer_markers): New functions for
8591 recording and fetching special buffer markers.
8592 (set_buffer_internal_1, set_buffer_temp): Use them.
8593
8594 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8595
8596 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8597
8598 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8599 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8600
8601 * xdisp.c (hscroll_window_tree):
8602 (reconsider_clip_changes): Use PT instead of BUF_PT.
8603
d251f04b
EZ
86042011-03-13 Eli Zaretskii <eliz@gnu.org>
8605
8606 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8607 $(EMACS_ROOT)/lib/intprops.h.
8608
f0c77cd1
PE
86092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8610
3eca4629
PE
8611 Fix more problems found by GCC 4.5.2's static checks.
8612
7c86ee98
PE
8613 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8614 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8615 (xg_free_frame_widgets): Make it clear that a local variable is
8616 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8617 (gdk_window_get_screen): Make it clear that this macro is needed
8618 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8619 (int_gtk_range_get_value): New function, which avoids a diagnostic
8620 from gcc -Wbad-function-cast.
8621 (xg_set_toolkit_scroll_bar_thumb): Use it.
8622 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8623 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8624 (get_utf8_string, xg_get_file_with_chooser):
8625 Rename locals to avoid shadowing.
8626 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8627
41729b81
PE
8628 * xgselect.c (xg_select): Remove unused var.
8629
f0c77cd1
PE
8630 * image.c (four_corners_best): Mark locals as initialized.
8631 (gif_load): Initialize transparent_p to zero (Bug#8238).
8632 Mark another local as initialized.
ec6cf4c6 8633 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8634
ce0ad53d 8635 * image.c (clear_image_cache): Now static.
d5d5a617 8636 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8637 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8638 (x_edge_detection): Remove unnecessary cast that
8639 gcc -Wbad-function-cast diagnoses.
2037898d 8640 (gif_load): Fix pointer signedness.
6ae141d6
PE
8641 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8642 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8643
33383987 86442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8645
d32df629
PE
8646 Improve quality of tests for time stamp overflow.
8647 For example, without this patch (encode-time 0 0 0 1 1
8648 1152921504606846976) returns the obviously-bogus value (-948597
8649 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8650 reports time overflow. See
8651 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8652 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8653 * editfns.c: Include limits.h and intprops.h.
8654 (TIME_T_MIN, TIME_T_MAX): New macros.
8655 (time_overflow): Move earlier, to before first use.
8656 (hi_time, lo_time): New functions, for an accurate test for
8657 out-of-range times.
8658 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8659 (Fget_internal_run_time): Don't assume time_t fits in int.
8660 (make_time): Use list2 instead of Fcons twice.
8661 (Fdecode_time): More accurate test for out-of-range times.
8662 (check_tm_member): New function.
8663 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8664 (lisp_time_argument): Don't rely on undefined left-shift and
8665 right-shift behavior when checking for time stamp overflow.
8be6f318 8666
fe31d94c
PE
8667 * editfns.c (time_overflow): New function, refactoring common code.
8668 (Fformat_time_string, Fdecode_time, Fencode_time):
8669 (Fcurrent_time_string): Use it.
8670
8be6f318
PE
8671 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8672 * dired.c (make_time): Move to ...
8673 * editfns.c (make_time): ... here.
8674 * systime.h: Note the move.
8675
09d9db2c 86762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8677
126bc0dc
YM
8678 * fringe.c (update_window_fringes): Remove unused variables.
8679
c47cbdfd
YM
8680 * unexmacosx.c (copy_data_segment): Also copy __got section.
8681 (Bug#8223)
8682
7ac80be9
EZ
86832011-03-12 Eli Zaretskii <eliz@gnu.org>
8684
c96bbc66 8685 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8686 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8687 Constify `char *' arguments and their references according to
8688 prototypes in tparam.h.
8689
ecb0f94d 8690 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8691
7ac80be9
EZ
8692 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8693 Adapt all references accordingly.
8694
8695 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8696
ef1fd07e
TT
86972011-03-11 Tom Tromey <tromey@redhat.com>
8698
8699 * buffer.c (syms_of_buffer): Remove obsolete comment.
8700
7ef4b50c
EZ
87012011-03-11 Eli Zaretskii <eliz@gnu.org>
8702
8703 * termhooks.h (encode_terminal_code): Declare prototype.
8704
8705 * msdos.c (encode_terminal_code): Don't declare prototype.
8706
8707 * term.c (encode_terminal_code): Now external again, used by
8708 w32console.c and msdos.c.
8709
44f230aa
SM
8710 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8711 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8712
4b1ec863 87132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8714
1714f52b 8715 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8716
4b1ec863
PE
8717 * fringe.c (update_window_fringes): Mark locals as initialized
8718 (Bug#8227).
8719 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8720
524c7aa6
PE
8721 * alloc.c (mark_fringe_data): Move decl from here ...
8722 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8723 to check its interface.
8724 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8725
a5c0af81 8726 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8727 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8728 (fontset_font): Mark local as initialized.
a9a06e0b 8729 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8730
b4716021
PE
8731 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8732
811e9bac 8733 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8734 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8735 (x_own_selection, Fx_disown_selection_internal): Rename locals
8736 to avoid shadowing.
8737 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8738
7e3ab302
PE
8739 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8740 so that the caller can use some name other than gcpro1.
8741 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8742 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8743 (Fx_backspace_delete_keys_p):
8744 Use them to avoid shadowing, and rename vars to avoid shadowing.
8745 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8746 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8747 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8748 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8749 Remove unused locals.
7e3ab302
PE
8750 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8751 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8752 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8753 macros.
f78faa98 8754
e2b13473
PE
8755 * xterm.h (x_mouse_leave): New decl.
8756
77f23912
PE
8757 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8758 Remove unused functions.
cdf4ba58
PE
8759 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8760 (x_calc_absolute_position): Now static.
7411c686 8761 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8762 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8763 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8764 unless they are used.
38d0b34a
PE
8765 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8766 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8767 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8768 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8769 (x_error_catcher, x_connection_closed, x_error_handler):
8770 (x_error_quitter, xembed_send_message, x_iconify_frame):
8771 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8772 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8773 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8774
44f230aa
SM
8775 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8776 Rename or move locals to avoid shadowing.
6b463e58 8777 (tty_defined_color, merge_face_heights): Now static.
5967d051 8778 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8779 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8780 does not deduce is never used uninitialized.
73719eba
PE
8781 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8782 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8783
426994c3 8784 * terminal.c (store_terminal_param): Now static.
5489860b 8785
032f1620 8786 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8787 (set_frame_menubar): Remove unused local.
d4323972 8788 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8789 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8790 since they might point to immutable storage.
281585b0
PE
8791 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8792 since it's unused otherwise.
032f1620 8793
367c19e5 8794 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8795 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8796 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8797 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8798 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8799 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8800 does not deduce are never used uninitialized.
70739cbe 8801
07b48fa9
PE
8802 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8803
8868a238 8804 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8805 * window.c (window_loop, size_window):
8806 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8807
7e5cf297 8808 * window.c (display_buffer): Now static.
d6550a9f
PE
8809 (size_window): Mark variables that gcc -Wuninitialized
8810 does not deduce are never used uninitialized.
a586633d
PE
8811 * window.h (check_all_windows): New decl, to forestall
8812 gcc -Wmissing-prototypes diagnostic.
5b555da1 8813 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8814
f6095868
PE
8815 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8816 shadowing.
8817 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8818 Include <limits.h>.
8819 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8820 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8821 (load_charset_map): Mark variables that gcc -Wuninitialized
8822 does not deduce are never used uninitialized.
53df7c11 8823 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8824
f38b440c
PE
8825 * coding.c (coding_set_source, coding_set_destination):
8826 Use "else { /* comment */ }" rather than "else /* comment */;"
8827 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8828 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8829 a block, when the outer 'i' will do.
8830 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8831 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8832 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8833 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8834 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8835 Rename locals to avoid shadowing.
8836 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8837 * coding.c (emacs_mule_char, encode_invocation_designation):
8838 Now static, since they're not used elsewhere.
413bb2db 8839 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8840 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8841 (decode_coding_emacs_mule): Mark variables that gcc
8842 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8843 (detect_coding_iso_2022): Initialize a local variable that might
8844 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8845 this initialization is needed. (Bug#8211)
5f58e762
PE
8846 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8847 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8848 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8849 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8850 Remove unused macros.
f38b440c 8851
232b38b9 8852 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8853 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8854 * character.c (string_count_byte8): Likewise.
232b38b9 8855
fb90da1b
PE
8856 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8857 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8858
fb93dbc2
PE
8859 * chartab.c (copy_sub_char_table): Now static, since it's not used
8860 elsewhere.
5c156ace
PE
8861 (sub_char_table_ref_and_range, char_table_ref_and_range):
8862 Rename locals to avoid shadowing.
bbcd0949 8863 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8864
7d3b3862 8865 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8866 (BIDI_BOB): Remove unused macro.
7d3b3862 8867
6be7d3da
PE
8868 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8869 deduce are never used uninitialized.
c2ed9c8b 8870 * term.c (encode_terminal_code): Likewise.
6be7d3da 8871
75f8807f 8872 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8873
50938595
PE
8874 * tparam.h: New file.
8875 * term.c, tparam.h: Include it.
8876 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8877 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8878 Move these decls to tparam.h, and make them agree with what
8879 is actually in tparam.c. The previous trick of using incompatible
8880 decls in different modules does not conform to the C standard.
8881 All callers of tparam changed to use tparam's actual API.
8882 * tparam.c (tparam1, tparam, tgoto):
8883 Use const pointers where appropriate.
8884
fbceeba2
PE
8885 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8886 * cm.h (struct cm): Likewise.
8887 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8888 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8889 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8890 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8891 (turn_on_face, init_tty): Likewise.
8892 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8893
7f3f1250
PE
8894 * term.c (term_mouse_position): Rename local to avoid shadowing.
8895
e6ca6543
PE
8896 * alloc.c (mark_ttys): Move decl from here ...
8897 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8898
c40f8d15
AS
88992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8900
8901 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8902
cfe0661d
JB
89032011-03-09 Juanma Barranquero <lekktu@gmail.com>
8904
8905 * search.c (compile_pattern_1): Remove argument regp, unused since
8906 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8907 (compile_pattern): Don't pass it.
8908
0afb4571
J
89092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8910
8911 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8912 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8913 for ! HAVE_GTK3.
8914 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8915
8916 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8917
8918 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8919 gdk_window_get_screen, gdk_window_get_geometry,
8920 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8921 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8922 (xg_get_pixbuf_from_pixmap): New function.
8923 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8924 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8925 Call xg_get_pixbuf_from_pixmap instead of
8926 gdk_pixbuf_get_from_drawable.
8927 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8928 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8929 (xg_check_special_colors): Use GtkStyleContext and its functions
8930 for HAVE_GTK3.
8931 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8932 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8933 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8934 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8935 Call gtk_widget_get_preferred_size.
0afb4571
J
8936 (xg_frame_resized): gdk_window_get_geometry only takes 5
8937 parameters.
44f230aa
SM
8938 (xg_win_to_widget, xg_event_is_for_menubar):
8939 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8940 (xg_set_widget_bg): New function.
8941 (delete_cb): New function.
895009e1 8942 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8943 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8944 (xg_set_background_color): Call xg_set_widget_bg.
8945 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8946 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8947 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8948 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8949 if ! HAVE_GTK3.
8950 (update_frame_tool_bar): Call gtk_widget_hide.
8951 (xg_initialize): Use GDK_KEY_g.
8952
8953 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8954 if ! HAVE_GTK3
8955 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8956
8957 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8958 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8959 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8960
1c2cc4ef
JB
89612011-03-08 Juanma Barranquero <lekktu@gmail.com>
8962
8963 * w32xfns.c (select_palette): Check success of RealizePalette against
8964 GDI_ERROR, not zero.
8965
33383987 8966See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8967
8968;; Local Variables:
8969;; coding: utf-8
aac0c6e3
MR
8970;; End:
8971
33383987 8972 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8973
8974 This file is part of GNU Emacs.
8975
8976 GNU Emacs is free software: you can redistribute it and/or modify
8977 it under the terms of the GNU General Public License as published by
8978 the Free Software Foundation, either version 3 of the License, or
8979 (at your option) any later version.
8980
8981 GNU Emacs is distributed in the hope that it will be useful,
8982 but WITHOUT ANY WARRANTY; without even the implied warranty of
8983 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8984 GNU General Public License for more details.
8985
8986 You should have received a copy of the GNU General Public License
8987 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.