Improve documentation of special events and of the "e" interactive spec.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2d5c5f7d
EZ
12012-07-21 Eli Zaretskii <eliz@gnu.org>
2
07fb592e
EZ
3 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
4 in special-event-map. See the discussion at
5 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
6 for the reasons.
7
2d5c5f7d
EZ
8 * w32menu.c (add_menu_item): Cast to UINT_PTR when assigning
9 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
10 Fabrice Popineau <fabrice.popineau@supelec.fr>.
11
c4328746
JD
122012-07-21 Jan Djärv <jan.h.d@swipnet.se>
13
14 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 15 (conversationIdentifier): Return value is NSInteger.
784051c4 16 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 17
6e5d1c12
CY
182012-07-21 Chong Yidong <cyd@gnu.org>
19
20 * window.c (decode_any_window): Signal an error if the window is
21 on a dead frame (Bug#11984).
22
9928463d
DA
232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
24
25 Add indirection counting to speed up Fkill_buffer.
26 * buffer.h (struct buffer): New member.
27 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
28 (Fmake_indirect_buffer): Set indirection counter to -1, increment
29 base buffer indirection counter.
30 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
31 (Fkill_buffer): Adjust indirection counters as needed, don't walk
32 through buffer list if indirection counter is 0.
33
f8643a6b
DA
342012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
35
36 Extend the value returned by Fgarbage_collect with heap statistics.
37 * alloc.c (Qheap): New symbol.
38 (syms_of_alloc): DEFSYM it.
39 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
40 (Fmemory_free): Remove.
41 (syms_of_alloc): Don't defsubr it.
42 * buffer.c (Fcompact_buffer): Remove.
43 (syms_of_buffer): Don't defsubr it.
44
dac616ff
DA
452012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
46
47 Make maybe_gc inline.
48 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
49 * lisp.h (consing_since_gc, gc_relative_threshold)
50 (memory_full_cons_threshold): Revert declaration.
51 (maybe_gc): Remove prototype, define as inline.
52 * alloc.c: Remove old commented-out code.
53 (consing_since_gc, gc_relative_threshold)
54 (memory_full_cons_threshold): Revert to global.
55 (maybe_gc): Remove.
56
d7ea76b4
DA
572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
58
59 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
60 * lisp.h (build_unibyte_string): New function.
61 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
62 * sysdep.c, w32fns.c, xfns.c: Use it.
63 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
64 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
65 Adjust users accordingly.
66 * font.h (font_open_by_name): Adjust prototype.
67
765e61e3
DA
682012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
69
70 Cleanup calls to Fgarbage_collect.
71 * lisp.h (maybe_gc): New prototype.
72 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
73 Remove declarations.
74 * alloc.c (maybe_gc): New function.
75 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
76 Make them static.
77 * bytecode.c (MAYBE_GC): Use maybe_gc.
78 * eval.c (eval_sub, Ffuncall): Likewise.
79 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
80 to avoid dependency from auto-save feature.
81
52b852c7
PE
822012-07-19 Paul Eggert <eggert@cs.ucla.edu>
83
84 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
85 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
86 'for_each_per_buffer_object_at'.
87 All uses changed. It's better to use upper-case for macros that
88 cannot be implemented as functions, to give the reader a clue
89 that they're special.
90
5db81e33
SM
912012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
92
93 * alloc.c (Fgarbage_collect): Tweak docstring.
94
5b835e1d
DA
952012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
96
97 Tweak the value returned from Fgarbage_collect again.
98 * alloc.c (Fgarbage_collect): New return value, as confirmed in
99 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
100 Adjust documentation.
101 (total_vector_bytes): Rename to total_vector_slots, adjust
102 accounting.
103 (total_free_vector_bytes): Rename to total_free_vector_slots,
104 adjust accounting.
105 (Qstring_bytes, Qvector_slots): New symbols.
106 (syms_of_alloc): DEFSYM them.
107
9cd47b72
DA
1082012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Buffer compaction primitive which may be used from Lisp.
111 * buffer.c (compact_buffer, Fcompact_buffer): New function.
112 (syms_of_buffer): Register Fcompact_buffer.
113 * alloc.c (Fgarbage_collect): Use compact_buffer.
114 * buffer.h (compact_buffer): New prototype.
115 (struct buffer_text): New member.
116
d17337e5
DA
1172012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
118
119 New macro to iterate over all buffers, miscellaneous cleanups.
120 * lisp.h (all_buffers): Remove declaration.
121 * buffer.h (all_buffers): Add declaration, with comment.
122 (for_each_buffer): New macro.
123 * alloc.c (Fgarbage_collect, mark_object): Use it.
124 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
125 (init_buffer): Likewise.
126 * data.c (Fset_default): Likewise.
127 * coding.c (code_conversion_restore): Remove redundant check
128 for dead buffer.
129 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
130
60cfd278
AS
1312012-07-18 Andreas Schwab <schwab@linux-m68k.org>
132
133 Fix bug that created negative-length intervals.
134 * intervals.c (merge_interval_right, merge_interval_left):
135 Do not zero out this interval if it is absorbed by its children,
136 as this interval's total length doesn't change in that case. See
137 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
138
d06714cb
PE
1392012-07-18 Paul Eggert <eggert@cs.ucla.edu>
140
83713154
PE
141 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
142 when invoking (make-bool-vector N t) and N is a positive
143 multiple of 8 -- the last 8 bits were mistakenly cleared.
144
d06714cb
PE
145 Remove some struct layout assumptions in bool vectors.
146 * alloc.c (bool_header_size): New constant.
147 (header_size, word_size): Move earlier, as they're now used earlier.
148 Use 'word_size' in a few more places, where it's appropriate.
149 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
150 padding before the data member of a bool vector.
151 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
152 than doing the check by hand with an abort ().
153
464d5a5e
SM
1542012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
155
5fbc0409
SM
156 * eval.c (Fdefvar): Don't check constants since we only set the var if
157 it's not yet defined anyway (bug#11904).
158
464d5a5e
SM
159 * lisp.h (last_undo_boundary): Declare new var.
160 * keyboard.c (command_loop_1): Set it.
161 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
162 were auto-added by the command loop (bug#11774).
163
8dc2e44a
AS
1642012-07-18 Andreas Schwab <schwab@linux-m68k.org>
165
166 * w32font.c (Qsymbol): Remove local definition.
167 (syms_of_w32font): Don't DEFSYM it.
168
169925ec
DA
1692012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
170
171 Fix sweep_vectors to handle large bool vectors correctly.
172 * alloc.c (sweep_vectors): Account total_vector_bytes for
173 bool vectors larger than VBLOCK_BYTES_MAX.
174
5fbfb018
CY
1752012-07-18 Chong Yidong <cyd@gnu.org>
176
177 * frame.c (x_set_frame_parameters): Revert bogus change introduced
178 in 2012-05-25 commit by Paul Eggert (Bug#11738).
179
3ab6e069
DA
1802012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
181
182 Return more descriptive data from Fgarbage_collect.
183 Suggested by Stefan Monnier in
184 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
185 * alloc.c (bounded_number): New function.
186 (total_buffers, total_vectors): New variable.
187 (total_string_size): Rename to total_string_bytes, adjust users.
188 (total_vector_size): Rename to total_vector_bytes, adjust users.
189 (sweep_vectors): Account total_vectors and total_vector_bytes.
190 (Fgarbage_collect): New return value. Adjust documentation.
191 (gc_sweep): Account total_buffers.
192 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
193 (VECTOR_SIZE): Remove.
194 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
195 (Qinterval, Qmisc): New symbols.
196 (syms_of_data): Initialize them.
197 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
198 (Qcons, Qbuffer): New declarations.
199
6d02fe5b
PE
2002012-07-17 Paul Eggert <eggert@cs.ucla.edu>
201
202 * alloc.c (Fmemory_free): Account for memory-free's own storage.
203 Round up, not down. Improve doc.
204
b7ffe040
DA
2052012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
206
207 Restore old code in allocate_string_data to avoid Faset breakage.
208 Reported by Julien Danjou <julien@danjou.info> in
209 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
210 * alloc.c (allocate_string_data): Restore old code with minor
211 adjustments, fix comment to explain this subtle issue.
212
4dc7c8d5
SM
2132012-07-17 Eli Zaretskii <eliz@gnu.org>
214
215 Remove FILE_SYSTEM_CASE.
216 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
217
218 * fileio.c (FILE_SYSTEM_CASE): Don't define.
219 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
220 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
221 call-process-region passes it through expand-file-name.
222
223 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
224
2252012-07-17 Andreas Schwab <schwab@linux-m68k.org>
226
227 Fix crash when creating indirect buffer (Bug#11917)
228 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
229 Don't handle unbound variables specially if non-zero.
230 (Fbuffer_local_variables): Pass zero.
231 (clone_per_buffer_values): Pass non-zero.
232
2332012-07-17 Andreas Schwab <schwab@linux-m68k.org>
234
235 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
236 to make the loop interruptible.
237
2382012-07-17 Andreas Schwab <schwab@linux-m68k.org>
239
240 * gnutls.c (emacs_gnutls_handshake): Only retry if
241 GNUTLS_E_INTERRUPTED.
242
cce7fefc
DA
2432012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
244
245 Cleanup and convert miscellaneous checks to eassert.
246 * alloc.c (mark_interval): Fix comment, partially rephrase
247 old comment from intervals.h (see below).
248 * intervals.c (find_interval, adjust_intervals_for_insertion)
249 (delete_interval, adjust_intervals_for_deletion)
250 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
251 Convert to eassert.
252 (adjust_intervals_for_insertion, make_new_interval):
253 Remove obsolete and unused code.
254 * intervals.h (struct interval): Remove obsolete comment.
255 * textprotp.c (erase_properties): Remove unused code.
256 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
257 (Fremove_list_of_text_properties): Convert to eassert.
258
9ea10cc3
CY
2592012-07-17 Chong Yidong <cyd@gnu.org>
260
261 * editfns.c (Finsert_char): Doc fix.
262
3900d5de
DA
2632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Fix previous change to make Fmemory_free always accurate.
266 * alloc.c (make_interval): Update total_free_intervals.
267 (make_float): Likewise for total_free_floats.
268 (free_cons, Fcons): Likewise for total_free_conses.
269 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
270 Likewise for total_free_vector_bytes.
271 (Fmake_symbol): Likewise for total_free_symbols.
272 (bytes_free): Remove.
273
7098646f
DA
2742012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
275
276 Simple free memory accounting feature.
277 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
278 (sweep_vectors): Accumulate size of free vectors.
279 (Fgarbage_collect): Setup bytes_free.
280 (Fmemory_free): New function.
281 (syms_of_alloc): Register it.
282
22657b40
DA
2832012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
284
285 Cleanup overlays checking.
286 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
287 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
288 eassert and OVERLAYP.
289 (sort_overlays): Change to use OVERLAYP.
290
ddfc8813
RK
2912012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
292
293 * editfns.c (Finsert_char): Make it interactive, and make the
294 second arg optional. Copy interactive spec and docstring from
295 ucs-insert.
296
7c26cf3c
PE
2972012-07-17 Paul Eggert <eggert@cs.ucla.edu>
298
299 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
300 Unlike the other wrapped functions, fabs has an unspecified
301 effect on errno.
302
5d127af9
JD
3032012-07-16 Jan Djärv <jan.h.d@swipnet.se>
304
305 * nsterm.m (keyDown): Interpret flags without left/right bits
306 as the left key (Bug#11670).
307
6a0dd1d7
DA
3082012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
309
310 Remove empty and useless init functions.
311 * lisp.h (init_character_once, init_fns, init_image)
312 (init_filelock, init_sound): Remove prototype.
313 * character.c (init_character_once): Remove.
314 * filelock.c (init_filelock): Likewise.
315 * fns.c (init_fns): Likewise.
316 * image.c (init_image): Likewise.
317 * sound.c (init_sound): Likewise.
318 * emacs.c (main): Adjust accordingly.
319
7a6136fd
DA
3202012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
321
322 * gtkutil.h: Tiny cleanups.
323 (use_old_gtk_file_dialog): Remove useless declaration.
324 (xg_uses_old_file_dialog): Add suggested const attribute.
325
ce811ad9
EZ
3262012-07-15 Eli Zaretskii <eliz@gnu.org>
327
328 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
329 (bidi_paragraph_init): Use it to limit search forward for a strong
330 directional character in abnormally large paragraphs full of
331 neutral or weak characters. (Bug#11943)
332
c9adfeaa
SF
3332012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
334
335 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
336 the toolbar (Bug#9451).
337 (xg_make_tool_item): Give the widget event box a transparent
338 background.
339
fff62aa9
DA
3402012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
341
342 Cleanup basic allocation variables and functions.
343 * alloc.c (ignore_warnings, init_intervals, init_float)
344 (init_cons, init_symbol, init_marker): Remove.
345 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
346 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
347 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
348 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
349 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
350 (staticidx, init_alloc_once, init_strings, free_ablock):
351 Remove redundant initialization.
352 * fns.c (init_weak_hash_tables): Remove.
353 * lisp.h (init_weak_hash_tables): Remove prototype.
354
9730daca
DA
3552012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Use zero_vector where appropriate.
358 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
359 accordingly.
360 * lisp.h (zero_vector): New declaration.
361 * font.c (null_vector): Remove.
362 (syms_of_font): Remove initialization and staticpro.
363 (font_list_entities, font_find_for_lface): Change to use zero_vector.
364 * keymap.c (Faccessible_keymaps): Likewise.
365
2e2d2a13
LL
3662012-07-15 Leo Liu <sdl.web@gmail.com>
367
368 * fringe.c: Fix typo in comments.
369
cd276f6e
LL
3702012-07-14 Leo Liu <sdl.web@gmail.com>
371
372 * fringe.c: Add a new bitmap exclamation-mark.
373
5a1131d9
EZ
3742012-07-14 Eli Zaretskii <eliz@gnu.org>
375
376 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
377
378 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
379 (HAVE_MENUS): Don't define, defined by editing config.in with
380 msdos/sed2v2.inp.
381 (GMALLOC_INHIBIT_VALLOC): Don't define.
382 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
383
22e983b7
JB
3842012-07-14 Juanma Barranquero <lekktu@gmail.com>
385
386 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
387
5b3f250f
GM
3882012-07-14 Glenn Morris <rgm@gnu.org>
389
390 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
391 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
392 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
393
33d63ff4
GM
3942012-07-13 Glenn Morris <rgm@gnu.org>
395
5b633342
GM
396 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
397
33d63ff4
GM
398 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
399 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
400
b55b9f85
JD
4012012-07-13 Jan Djärv <jan.h.d@swipnet.se>
402
0dc8cf50
JD
403 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
404 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
405 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
406 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
407 where appropriate.
408 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
409 as boolean expression.
410 (x_set_window_size): Remove unused variable toolbar.
411 (ns_get_color_default, ns_mod_to_lisp): Remove.
412 (ns_mouse_position): Remove unused variables xchar and ychar.
413 (ns_compute_glyph_string_overhangs): Remove unused variable face.
414 (ns_set_vertical_scroll_bar): Remove unused variable count.
415 (ns_delete_terminal): Remove unused variable i.
416 (ns_term_init): Remove unused variables r, g and b.
417 (mouseDown): Remove unused variable window.
418 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
419 (initFrameFromEmacs): Remove unused variable vbextra.
420 (mouseEntered): Remove unused variables p and dpyinfo.
421 (mouseExited): Remove unused variables p and r.
422 (ns_define_frame_cursor, ns_clear_frame_area)
423 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
424 (menuDown): Assign [sender tag] to variable and cast the variable.
425
426 * nsterm.h (menuDown): Add id as type to argument sender.
427 (ns_display_info_for_name): Add Lisp_Object argument.
428 (ns_term_init): Add Lisp_Object argument.
429 (ns_map_event_to_object): Add void argument.
430 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
431 prototype with arguments and only declare if __OBJC__.
432 (nxatoms_of_nsselect): Add void argument.
433 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
434 (ns_alloc_autorelease_pool): Add void argument.
435 (ns_release_autorelease_pool): Add void* argument.
436 (ns_get_defaults_value): Add const char* argument.
437
438 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
439 (initFromContents): Use SSDATA where appropriate.
440 (ns_update_menubar): Add braces to ambigous if-else.
441 (initWithTitle): Put () around assignment in if statement.
442 (ns_menu_show): Remove unused variables window and keymap.
443 (update_frame_tool_bar): Remove unused variable selected_p.
444 (initWithContentRect): Remove unused variable this_cmd_name.
445
446 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
447 appropriate.
448 (setXBMColor): Remove unused variable len.
449 (setPixmapData): Put () around assignment in loop statement.
450
451 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
452 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
453 where appropriate.
454 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
455 around assignment in loop statement.
456 (nsfont_open): Remove unused variable i.
457 (nsfont_open): Remove unused variable len.
458 (nsfont_draw): Remove unused variable cs.
459
460 * nsfns.m (x_set_icon_name, ns_set_name_internal)
461 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
462 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
463 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
464 (Fns_font_name, Fns_perform_service)
465 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
466 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
467 (ns_set_name): Remove unused variable view.
468 (x_set_menu_bar_lines): Remove unused variable olines.
469 (x_set_tool_bar_lines): Remove unused variable root_window.
470 (Fns_list_colors): Put () around assignment in while statement.
471 (Fns_perform_service): Remove unused variable len.
472 (Fns_display_usable_bounds): Remove unused variable top.
473 (syms_of_nsfns): Remove unused variable i.
474
b55b9f85
JD
475 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
476 memcpy (Bug#11907).
477
ed9265fc 4782012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
479
480 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
481 and free it with DestroyExceptionInfo (Bug#11558).
482
ef099b57
JB
4832012-07-13 Juanma Barranquero <lekktu@gmail.com>
484
485 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
486 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
487 Set here, not in nt/config.nt.
488
ea814a5d
EZ
4892012-07-13 Eli Zaretskii <eliz@gnu.org>
490
491 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
492 cursor overflow into the last glyph on display line when the right
493 fringe is off. (Bug#11832)
494
1a952767
PE
4952012-07-13 Paul Eggert <eggert@cs.ucla.edu>
496
497 * xdisp.c (produce_special_glyphs): Now static.
498 * dispextern.h (produce_special_glyphs): Remove decl.
499
983188fd
GM
5002012-07-13 Glenn Morris <rgm@gnu.org>
501
32fb4bb6
GM
502 * s/bsd-common, s/cygwin.h: Remove empty files.
503 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
504
983188fd
GM
505 * s/usg5-4-common.h (USG, USG5):
506 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
507 * s/sol2-6.h (SOLARIS2):
508 * s/irix6-5.h (IRIX6_5):
509 * s/hpux10-20.h (USG, USG5, HPUX):
510 * s/gnu-linux.h (USG, GNU_LINUX):
511 * s/freebsd.h (BSD_SYSTEM):
512 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
513 * s/cygwin.h (CYGWIN):
514 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
515 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
516
d1e68667 5172012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
518
519 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 520
6de0e799
GM
5212012-07-13 Glenn Morris <rgm@gnu.org>
522
739ae010
GM
523 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
524
dbee5793
GM
525 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
526
6de0e799
GM
527 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
528 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
529
b82da769
GM
5302012-07-12 Glenn Morris <rgm@gnu.org>
531
4fae5a7a 532 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
533
534 * process.c (init_process_emacs): Rename from init_process.
535 The old name is also the name of a Mach system call.
536 * lisp.h, emacs.c: Update for this name change.
537 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
538 longer needed.
539
5a979817
EZ
5402012-07-12 Eli Zaretskii <eliz@gnu.org>
541
542 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
543 memmove call that removes glyphs covered by the left truncation
544 glyph. Improve commentary.
545 (display_line): Fix display of continuation glyphs on GUI frames
546 when the right fringe is turned off and variable-size fonts are
547 used in the window. Move the code that appends a stretch glyph to
548 produce_special_glyphs, so that it could be used for truncation
549 and continuation glyphs alike.
550 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
551 glyph of a suitably computed width, to align the special glyphs at
552 the window margin. Code moved from display_line. (Bug#11832)
553
3e91a053
GM
5542012-07-12 Glenn Morris <rgm@gnu.org>
555
ba9e4b84
GM
556 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
557
558 * s/gnu-linux.h, s/hpux10-20.h:
559 Do not unconditionally define HAVE_XRMSETDATABASE.
560
3e91a053
GM
561 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
562
b300b1f4
PE
5632012-07-12 Paul Eggert <eggert@cs.ucla.edu>
564
565 Fix typos that broke OS X build.
566 Reported by Randal L. Schwartz in
567 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
568 * nsterm.m (ns_timeout): Add missing local decl.
569 (ns_get_color): snprintf -> sprintf, to fix typo.
570
6e777848
GM
5712012-07-12 Glenn Morris <rgm@gnu.org>
572
3f922c37
GM
573 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
574 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
575 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
576 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
577
0ab7b23a
GM
578 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
579 Move PTY_OPEN to configure.
580
6e777848
GM
581 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
582 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
583 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
584
4a7edc24
DA
5852012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
586
587 Use empty_unibyte_string where applicable.
588 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
589 * lread.c (read1): Likewise.
590 * xsettings.c (syms_of_xsettings): Likewise.
591
308aab79
GM
5922012-07-12 Glenn Morris <rgm@gnu.org>
593
42bd1719
GM
594 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
595 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
596 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
597 * s/hpux10-20.h (RUN_TIME_REMAP):
598 * s/bsd-common.h (TABDLY): Move to configure.
599
600 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
601
602 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
603
ea0bbd17 604 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 605 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
606
607 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 608
308aab79
GM
609 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
610 * s/template.h: Move NARROWPROTO to configure.
611
ee1cf5cf
GM
6122012-07-11 Glenn Morris <rgm@gnu.org>
613
30fe9bf4
GM
614 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
615 unused since 2011-01-17 change to systty.h.
616
ee1cf5cf
GM
617 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
618 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
619 Move HAVE_PTYS and HAVE_SOCKETS to configure.
620
63e47e07
PE
6212012-07-11 Paul Eggert <eggert@cs.ucla.edu>
622
623 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
624
c43fb4c3
GM
6252012-07-11 Glenn Morris <rgm@gnu.org>
626
627 * s/darwin.h, s/gnu-linux.h, s/template.h:
628 Move INTERRUPT_INPUT to configure.
629
e8df9267
DA
6302012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
631
632 Minor adjustments to interning code.
633 * lisp.h (intern, intern_c_string): Redefine as static inline
634 wrappers for intern_1 and intern_c_string_1, respectively.
635 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
636 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
637 Vobarray checking.
e8df9267
DA
638 * font.c (font_intern_prop): Likewise. Adjust comment.
639 * w32font.c (intern_font_name): Likewise.
640
34348bd4
AS
6412012-07-11 Andreas Schwab <schwab@linux-m68k.org>
642
d96a1e0c
AS
643 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
644
34348bd4
AS
645 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
646 of Fcar/Fcdr if possible.
647 * font.c (check_otf_features): Likewise.
648 * fontset.c (Fnew_fontset): Likewise.
649 * gnutls.c (Fgnutls_boot): Likewise.
650 * minibuf.c (read_minibuf): Likewise.
651 * msdos.c (IT_set_frame_parameters): Likewise.
652 * xmenu.c (Fx_popup_dialog): Likewise.
653 * w32menu.c (Fx_popup_dialog): Likewise.
654
c8add24e
GM
6552012-07-11 Glenn Morris <rgm@gnu.org>
656
4b575b3c
GM
657 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
658 since nothing has defined it on these platforms.
659
09f4e3b0
GM
660 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
661 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
662
172bedef
GM
663 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
664 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
665 Move CLASH_DETECTION to configure.
666
249685df
GM
667 * s/gnu.h: Remove file, which is now empty.
668
c8add24e
GM
669 * s/gnu.h, s/gnu-linux.h:
670 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
671
b41253a3
JW
6722012-07-11 John Wiegley <johnw@newartisans.com>
673
674 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
675 function attribute, so we only use it if it exists in the
676 compiler.
677
d923b542
DA
6782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
679
680 Avoid call to strlen in fast_c_string_match_ignore_case.
681 * search.c (fast_c_string_match_ignore_case): Change to use
682 length argument. Adjust users accordingly.
683 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
684
5ebbef1d
PE
6852012-07-11 Paul Eggert <eggert@cs.ucla.edu>
686
bb352260
PE
687 Assume mkdir, rmdir.
688 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
689 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
690
57054ddd
PE
691 Assume rename.
692 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
693
b747d3f7
PE
694 Assume perror.
695 * s/hpux10-20.h (HAVE_PERROR): Remove.
696 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
697 Remove dummy definition, as this problem was obsolete long ago.
698
5ebbef1d
PE
699 Assume strerror.
700 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
701
984e7f30
DA
7022012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
703
704 Avoid calls to strlen in font processing functions.
705 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 706 (font_open_by_name): Change to use length argument. Adjust
984e7f30 707 users accordingly.
d923b542
DA
708 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
709 Adjust prototypes.
710 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
711 Change to return ptrdiff_t.
984e7f30
DA
712 (xfont_list_pattern, xfont_match): Use length returned by
713 xfont_decode_coding_xlfd.
714 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
715
20e94fdd
GM
7162012-07-11 Glenn Morris <rgm@gnu.org>
717
9d596af3
GM
718 * s/darwin.h, s/freebsd.h, s/netbsd.h:
719 Move DONT_REOPEN_PTY to configure.
720
20e94fdd
GM
721 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
722 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
723
e99a530f
PE
7242012-07-10 Paul Eggert <eggert@cs.ucla.edu>
725
22ffb973
PE
726 Remove "#define unix" that is no longer needed (Bug#11905).
727 * s/aix4-2.h (unix): Remove; no longer needed.
728
e9a9ae03
PE
729 EMACS_TIME simplification (Bug#11875).
730 This replaces macros (which typically do not work in GDB)
731 with functions, typedefs and enums, making the code easier to debug.
732 The functional style also makes code easier to read and maintain.
733 * systime.h: Include <sys/time.h> on all hosts, not just if
734 WINDOWSNT, since 'struct timeval' is needed in general.
735 (EMACS_TIME): Now a typedef, not a macro.
736 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
737 not macros.
738 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
739 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
740 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
741 (EMACS_TIME_LE): Now functions, not macros.
742 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
743 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
744 which are not functions. All uses rewritten to use:
745 (make_emacs_time): New function.
746 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
747 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
748 not functions. All uses rewritten to use the following, respectively:
749 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
750 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 751 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
752 * fileio.c (Fcopy_file):
753 * xterm.c (XTflash): Get the current time closer to when it's used.
754 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
755
ffacb126
PE
756 * bytecode.c (targets): Suppress -Woverride-init warnings.
757
e99a530f
PE
758 Simplify by avoiding confusing use of strncpy etc.
759 * doc.c (Fsnarf_documentation):
760 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
761 * frame.c (Fmake_terminal_frame):
762 * gtkutil.c (get_utf8_string):
763 * lread.c (openp):
764 * nsmenu.m (ns_update_menubar):
765 * regex.c (regerror):
766 Prefer memcpy to strncpy and strncat when either will do.
767 * fileio.c (Fsubstitute_in_file_name):
768 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
769 (menu_separator_name_p):
770 * nsmenu.m (ns_update_menubar):
771 Prefer memcmp to strncmp when either will do.
772 * nsterm.m: Include <ftoastr.h>.
773 (ns_get_color):
774 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
775 Prefer snprintf to strncpy.
776 * nsterm.m (ns_term_init):
777 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
778 * nsterm.m (ns_term_init):
779 Avoid the need for strncpy, by using build_string or
780 make_unibyte_string directly. Use dtoastr, not snprintf.
781 * process.c (Fmake_network_process): Diagnose service names that
782 are too long, rather than silently truncating them or creating
783 non-null-terminated names.
784 (Fnetwork_interface_info): Likewise, for interface names.
785 * sysdep.c (system_process_attributes) [GNU_LINUX]:
786 Prefer sprintf to strncat.
787 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
788 Prefer vsnprintf to vsprintf + strncpy.
789
c59592b3
GM
7902012-07-10 Glenn Morris <rgm@gnu.org>
791
792 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
793 Clarify fallback case.
794
7d7bbefd
DA
7952012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
796
797 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
798 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
799 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 800 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
801 where argument type is known to be a Lisp_Cons.
802
3a4c8000
TT
8032012-07-10 Tom Tromey <tromey@redhat.com>
804
805 * bytecode.c (BYTE_CODE_THREADED): New macro.
806 (BYTE_CODES): New macro. Replaces all old byte-code defines.
807 (enum byte_code_op): New type.
808 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
809 (exec_byte_code): Use them. Use token threading when applicable.
810
2a0213a6
DA
8112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
812
813 Optimize pure C strings initialization.
814 * lisp.h (make_pure_string): Fix prototype.
815 (build_pure_c_string): New function, defined as static inline. This
816 provides a better opportunity to optimize away calls to strlen when
817 the function is called with compile-time constant argument.
818 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
819 argument, adjust users accordingly. Use build_pure_c_string where
820 appropriate.
821 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
822 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
823 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
824
cb1caeaf
DA
8252012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
826
827 Avoid calls to strlen in miscellaneous functions.
828 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
829 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
830 * lread.c (openp): Likewise.
831
c293e30c
DA
8322012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
833
834 Avoid calls to strlen in path processing functions.
835 * fileio.c (file_name_as_directory): Add comment. Change to add
836 srclen argument and return the length of result. Adjust users
837 accordingly.
838 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 839 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
840 users accordingly.
841 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
842
9e059e3f
GM
8432012-07-10 Glenn Morris <rgm@gnu.org>
844
d02eb359
GM
845 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
846 Move PENDING_OUTPUT_COUNT definition to configure.
847
882cf227
GM
848 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
849 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
850 * s/gnu.h (DATA_START): Move definitions to configure.
851
af6e839f
GM
852 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
853 We include usg5-4-common.h, which defines them both.
854
40289a12
GM
855 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
856 O_RDONLY already includes it).
857
9e059e3f
GM
858 Stop ns builds setting the EMACSLOADPATH environment variable.
859 * nsterm.m (ns_load_path): Rename from ns_init_paths.
860 Now it does not set EMACSLOADPATH, just returns the load-path string.
861 * nsterm.h: Update accordingly.
862 * lread.c [HAVE_NS]: Include nsterm.h.
863 (init_lread) [HAVE_NS]: Use ns_load_path.
864 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
865
7c4e8ec0
GM
8662012-07-09 Glenn Morris <rgm@gnu.org>
867
d4f600ff
GM
868 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
869 since the included bsd-common.h does so.
870
cbb31951
GM
871 Stop ns builds setting the EMACSPATH environment variable.
872 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
873 (ns_init_paths): Do not set EMACSPATH.
874 * nsterm.h (ns_exec_path): Add it.
875 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
876 Use ns_exec_path.
877
7c4e8ec0
GM
878 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
879
26bccfae
PE
8802012-07-09 Paul Eggert <eggert@cs.ucla.edu>
881
a0bee46f
PE
882 * process.c (wait_reading_process_output): 'waitchannels' was unset
883 when read_kbd || !NILP (wait_for_cell); fix this.
884
5994c183
PE
885 Add GCC-style 'const' attribute to functions that can use it.
886 * character.h (char_resolve_modifier_mask):
887 * keyboard.h (make_ctrl_char):
888 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
889 (init_character_once, next_almost_prime, init_fns, init_image)
890 (flush_pending_output, init_sound):
891 * mem-limits.h (start_of_data):
892 * menu.h (finish_menu_items):
893 Add ATTRIBUTE_CONST.
894 * emacs.c (DEFINE_DUMMY_FUNCTION):
895 Declare the dummy function with ATTRIBUTE_CONST.
896 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
897 Add decls with ATTRIBUTE_CONST.
898
26bccfae
PE
899 Minor improvements to make_formatted_string.
900 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
901 where int is good enough, as vsprintf returns an int.
902 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
903
a8290ec3
DA
9042012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
905
906 Use make_formatted_string to avoid double length calculation.
907 * lisp.h (make_formatted_string): New prototype.
908 * alloc.c (make_formatted_string): New function.
909 * buffer.c (Fgenerate_new_buffer_name): Use it.
910 * dbus.c (syms_of_dbusbind): Likewise.
911 * editfns.c (Fcurrent_time_zone): Likewise.
912 * filelock.c (get_boot_time): Likewise.
913 * frame.c (make_terminal_frame, set_term_frame_name)
914 (x_report_frame_params): Likewise.
915 * image.c (gs_load): Likewise.
916 * minibuf.c (get_minibuffer): Likewise.
917 * msdos.c (dos_set_window_size): Likewise.
918 * process.c (make_process): Likewise.
919 * xdisp.c (ensure_echo_area_buffers): Likewise.
920 * xsettings.c (apply_xft_settings): Likewise.
921
d01ba2f1
GM
9222012-07-09 Glenn Morris <rgm@gnu.org>
923
924 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
925 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
926 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
927 * nsterm.h (ns_etc_directory): Add it.
928 * callproc.c [HAVE_NS]: Include nsterm.h.
929 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
930
f1f924b6
DA
9312012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
932
933 Move marker debugging code under MARKER_DEBUG.
934 * marker.c (MARKER_DEBUG): Move marker debugging code under
935 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
936 for bootstrap with --enable-checking (~3x slowdown reported
937 by Juanma Barranquero <lekktu@gmail.com>).
938 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
939
ab531b66
PE
9402012-07-08 Paul Eggert <eggert@cs.ucla.edu>
941
942 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
943 See <http://bugs.gnu.org/11825#29>.
944
c4b3bc8a
EZ
9452012-07-08 Eli Zaretskii <eliz@gnu.org>
946
947 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
948 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
949 (display_line): Add commentary about displaying truncation glyphs
950 on GUI frames.
951 (produce_special_glyphs): Move here from term.c.
952
953 * term.c (produce_special_glyphs): Move to xdisp.c.
954
955 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
956 section.
c4b3bc8a 957
b676b881
AS
9582012-07-07 Andreas Schwab <schwab@linux-m68k.org>
959
f17c5273
AS
960 * xdisp.c (display_line): Avoid warning about implicit declaration
961 of FRAME_FONT.
962
298819b9
AS
963 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
964
b676b881
AS
965 * lisp.h: Remove empty conditional.
966
6045c4fd
PE
9672012-07-07 Paul Eggert <eggert@cs.ucla.edu>
968
b3350bf9
PE
969 * lread.c (load_path_check): Now static.
970
6045c4fd
PE
971 Fix some minor --with-ns problems found by static checking.
972 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
973 (x_set_font) [!HAVE_X_WINDOWS]:
974 * image.c (xpm_load_image) [HAVE_NS]:
975 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
976 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
977 Remove unused local.
978 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
979 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
980 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
981 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
982 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
983 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
984 Fix pointer signedness problem.
985 * xfaces.c (FRAME_X_FONT_TABLE):
986 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
987
929e7845
GM
9882012-07-07 Glenn Morris <rgm@gnu.org>
989
990 * lread.c (load_path_check): New function, split from init_lread.
991 (init_lread): Reorganize. Motivation:
992 If EMACSLOADPATH is set, check/warn about that rather than the
993 defaults, which we are not going to use. Hence we can remove
994 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
995 Don't warn if site-lisp directories are missing.
996 If not installed, start from a blank load-path, since
997 PATH_LOADSEARCH refers to the eventual installation directories.
998
58dd0aa4
EZ
9992012-07-07 Eli Zaretskii <eliz@gnu.org>
1000
1001 Support truncation and continuation glyphs on GUI frames, when
1002 fringes are disabled. (Bug#11832)
1003 * xdisp.c (init_iterator): Get dimensions of truncation and
1004 continuation glyphs even if on GUI frames. Adjust
1005 it->last_visible_x on GUI frames when the left or right fringes,
1006 or both, are absent.
1007 (start_display, move_it_in_display_line_to): Handle the case of a
1008 GUI frame without a fringe to display continuation or truncation
1009 glyphs.
1010 (insert_left_trunc_glyphs): Support GUI frames: make sure
1011 truncation glyphs overwrite enough glyphs from the current line to
1012 have sufficient space in pixels.
1013 (display_line): Support truncation and continuation glyphs on GUI
1014 frames. If some spare pixels are left on the line after inserting
1015 the truncation glyphs, fill that space with a stretch glyph of a
1016 suitably computed width.
1017
1018 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1019 produce_glyphs, to support GUI sessions.
1020
31571fd7
PE
10212012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1022
5a16b9bc
PE
1023 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1024
f3047c75
PE
1025 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1026
31571fd7
PE
1027 Do not require float-time's arg to fit in time_t (Bug#11825).
1028 This works better on hosts where time_t is unsigned, and where
1029 float-time is applied to the (negative) difference between two times.
1030 * editfns.c (decode_time_components): Last arg is now double *,
1031 not int *, and means to store all the result as a double, without
1032 worrying about whether the seconds part fits in time_t.
1033 All callers changed.
1034 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1035 All callers changed.
1036 (Ffloat_time): Do not fail merely because the specified time falls
1037 outside of time_t range.
1038
4516fbef
GM
10392012-07-07 Glenn Morris <rgm@gnu.org>
1040
1041 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1042 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1043 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1044
07adc2c6
JB
10452012-07-07 Juanma Barranquero <lekktu@gmail.com>
1046
1047 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1048 Update dependencies.
1049
1050 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1051
fd573f31
PE
10522012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1053
fee5959d
PE
1054 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1055 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1056 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1057 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1058 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1059 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1060
fd573f31
PE
1061 * xfont.c (compare_font_names): Redo to omit the need for casts.
1062
ddadbc0e
AS
10632012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1064
fca8d6b6
AS
1065 * xfns.c (Fx_change_window_property): Doc fix.
1066 * w32fns.c (Fx_change_window_property): Doc fix.
1067
ddadbc0e
AS
1068 * w32fns.c (Fx_window_property): Accept the same arguments as the
1069 X Windows version. Doc fix.
1070 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1071
ed9265fc 10722012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1073 Eli Zaretskii <eliz@gnu.org>
1074
1075 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1076 Windows-specific code from nt/config.nt moved here.
1077 Obsolete settings removed.
1078
216ee680
PE
10792012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 * process.c: Avoid unnecessary calls to gettime.
1082 (wait_reading_process_output): Don't get the time of day
1083 when gobbling data immediately and not waiting, as there's no need
1084 for it in that case. This removes a FIXME.
1085
bdd091e4
JD
10862012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1087
1088 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1089 is defined (Bug#11768).
1090
9d44f8ce
DA
10912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1092
1093 Fix marker debugging code.
1094 * marker.c (byte_char_debug_check): Do not perform the check
1095 if buffer is not multibyte.
090bd7cb
JB
1096 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1097 Call byte_char_debug_check with correct arguments.
9d44f8ce 1098
90fc4786
DA
10992012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1100
1101 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1102 * marker.c (byte_char_debug_check, count_markers):
1103 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1104 (byte_debug_flag): Remove.
1105 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1106 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1107
7b7ae965
DA
11082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1109
4e57b342
DA
1110 Avoid code repetition in marker-related functions.
1111 * marker.c (attach_marker): New function.
1112 (Fset_marker, set_marker_restricted, set_marker_both)
1113 (set_marker_restricted_both): Use it.
1114 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1115 Consistently rename charno to charpos.
1116 (marker_position): Add eassert.
1117 (marker_byte_position): Convert to eassert.
1118
11192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1120
1121 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1122 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1123 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1124
657924ff
DA
11252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1126
1127 Introduce fast path for the widely used marker operation.
1128 * alloc.c (build_marker): New function.
1129 * lisp.h (build_marker): New prototype.
1130 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1131 * composite.c (autocmp_chars): Likewise.
1132 * editfns.c (buildmark): Remove.
1133 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1134 (save_restriction_save): Use build_marker.
1135 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1136 * window.c (save_window_save): Likewise.
1137
041a49a6
DA
11382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1139
1140 Do not use Fdelete_overlay in delete_all_overlays
1141 to avoid redundant calls to unchain_overlay.
1142 * buffer.c (drop_overlay): New function.
1143 (delete_all_overlays, Fdelete_overlay): Use it.
1144 * minibuf.c (get_minibuffer): Fix comment.
1145
7dca65a4
PE
11462012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 Port to OpenBSD 5.1 amd64.
1149 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1150 This is needed for OpenBSD, and should be harmless on all BSD systems.
1151 Also, include <sys/sysctl.h>, as it should be available on all
1152 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1153 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1154 use p_pid member, not kp_proc.pid.
1155
8eb876e2
GM
11562012-07-06 Glenn Morris <rgm@gnu.org>
1157
1158 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1159
38182d90
PE
11602012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1161
1162 More xmalloc and related cleanup.
1163 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1164 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1165 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1166 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1167 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1168 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1169 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1170 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1171 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1172 * xterm.c:
1173 Omit needless casts involving void * pointers and allocation.
1174 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1175 as the former is more robust if P's type is changed.
1176 Prefer xzalloc to xmalloc + memset 0.
1177 Simplify malloc-or-realloc to realloc.
1178 Don't worry about xmalloc returning a null pointer.
1179 Prefer xstrdup to xmalloc + strcpy.
1180 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1181 growing it.
1182 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1183 alloca of a constant.
1184
6dd5a677
EZ
11852012-07-05 Eli Zaretskii <eliz@gnu.org>
1186
1187 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1188 hscroll is larger than the line width. Fixes long and futile
1189 looping inside extend_face_to_end_of_line (on a TTY) producing
1190 glyphs that are not needed and thrown away.
1191
6b312f0f
DA
11922012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1193
1194 * marker.c (set_marker_restricted_both): Simplify by using
1195 clip_to_bounds.
1196
f520ef9b
PE
11972012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1200
383b7c95
JD
12012012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1202
1203 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1204 not defined (Bug#11768).
1205 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1206 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1207 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1208 followed by gtk_box_set_homogeneous (Bug#11768).
1209 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1210 (update_theme_scrollbar_width, xg_create_scroll_bar):
1211 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1212 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1213 (is_box_type): New function (Bug#11768).
1214 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1215 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1216 with default display (Bug#11768).
1217
d6e7bf45
EZ
12182012-07-05 Eli Zaretskii <eliz@gnu.org>
1219
1220 * xdisp.c (window_hscroll_limited): New function.
1221 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1222 coordinates when window's hscroll is set to insanely large
1223 values. (Bug#11857)
1224
431391ec
JB
12252012-07-05 Juanma Barranquero <lekktu@gmail.com>
1226
1227 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1228 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1229
23f86fce
DA
12302012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 Cleanup xmalloc.
1233 * lisp.h (xzalloc): New prototype. Omit needless casts.
1234 * alloc.c (xzalloc): New function. Omit needless casts.
1235 * charset.c: Omit needless casts. Convert all calls to
1236 xmalloc with following memset to xzalloc.
1237 * dispnew.c: Likewise.
1238 * fringe.c: Likewise.
1239 * image.c: Likewise.
1240 * sound.c: Likewise.
1241 * term.c: Likewise.
1242 * w32fns.c: Likewise.
1243 * w32font.c: Likewise.
1244 * w32term.c: Likewise.
1245 * xfaces.c: Likewise.
1246 * xfns.c: Likewise.
1247 * xterm.c: Likewise.
1248 * atimer.c: Omit needless casts.
1249 * buffer.c: Likewise.
1250 * callproc.c: Likewise.
1251 * ccl.c: Likewise.
1252 * coding.c: Likewise.
1253 * composite.c: Likewise.
1254 * doc.c: Likewise.
1255 * doprnt.c: Likewise.
1256 * editfns.c: Likewise.
1257 * emacs.c: Likewise.
1258 * eval.c: Likewise.
1259 * filelock.c: Likewise.
1260 * fns.c: Likewise.
1261 * gtkutil.c: Likewise.
1262 * keyboard.c: Likewise.
1263 * lisp.h: Likewise.
1264 * lread.c: Likewise.
1265 * minibuf.c: Likewise.
1266 * msdos.c: Likewise.
1267 * print.c: Likewise.
1268 * process.c: Likewise.
1269 * region-cache.c: Likewise.
1270 * search.c: Likewise.
1271 * sysdep.c: Likewise.
1272 * termcap.c: Likewise.
1273 * terminal.c: Likewise.
1274 * tparam.c: Likewise.
1275 * w16select.c: Likewise.
1276 * w32.c: Likewise.
1277 * w32reg.c: Likewise.
1278 * w32select.c: Likewise.
1279 * w32uniscribe.c: Likewise.
1280 * widget.c: Likewise.
1281 * xdisp.c: Likewise.
1282 * xmenu.c: Likewise.
1283 * xrdb.c: Likewise.
1284 * xselect.c: Likewise.
1285
0497dc44
PE
12862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 * fileio.c (time_error_value): Check the right error number.
1289 Problem reported by Troels Nielsen in
1290 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1291
356e7178
PE
12922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1293
4e71fd89
PE
1294 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1295 This should be fixed in a better way; see Eli Zaretskii in
1296 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1297 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1298
f0941253
PE
1299 * fileio.c (time_error_value): Rename from special_mtime.
1300 The old name's problems were noted by Eli Zaretskii in
1301 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1302
065c9eb4
PE
1303 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1304 This variable's comment says Emacs needs at least one GDB-visible
1305 symbol of type enum pvec_type, to work around GDB problems.
1306 The symbol's value doesn't matter.
1307
356e7178
PE
1308 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1309 that causes compilation to fail on pre-C99 compilers.
1310
ed9265fc 13112012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1312
1313 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1314 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1315
3884d954
DA
13162012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1317
d209e2fb 1318 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1319 headers for buffer_defaults and buffer_local_symbols.
1320 Reported by Juanma Barranquero <lekktu@gmail.com>.
1321
ee28be33
SM
13222012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1323
1324 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1325 * lisp.h (enum pvec_type): Use fewer bits.
1326 (PSEUDOVECTOR_SIZE_BITS): New constant.
1327 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1328 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1329 change in pvec_type.
1330 (PSEUDOVECTOR_TYPEP): New macro.
1331 (TYPED_PSEUDOVECTORP): Use it.
1332 * fns.c (internal_equal): Adapt code to extract pvectype.
1333 * emacs.c (gdb_pvec_type): Update type.
1334 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1335 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1336 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1337 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1338 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1339 abusing vector->header.next.nbytes.
1340 (live_vector_p): Use PVEC_TYPE.
1341 (mark_object): Adapt code to extract pvectype. Use switch.
1342
c7f2cd7f
PE
13432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1346 Tighten new eassert a bit.
1347
8ce70ed2
DA
13482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1349
1350 Fix compilation with --enable-gcc-warnings and -O1
1351 optimization level.
1352 * doprnt.c (doprnt): Change type of tem to int, initialize
1353 to avoid compiler warning. Add eassert.
1354 * search.c (simple_search): Initialize match_byte to avoid
1355 compiler warning. Add eassert.
1356
dea7f1e5
PE
13572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1358
24a212eb
PE
1359 Avoid weird behavior with large horizontal scrolls.
1360 Without this change, for example, large hscroll values would
1361 mess up Emacs's display on Fedora 15 x86, presumably due to
1362 overflows in int calculations in the display code.
1363 Also, if buffers had long lines, Emacs would freeze.
1364 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1365 (set_window_hscroll): New function, containing the old guts of
1366 Fset_window_hscroll. Return the clipped value.
1367 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1368 This avoids the need to check against PTRDIFF_MAX.
1369
dea7f1e5
PE
1370 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1371
76046526
DA
13722012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1375
39adff0d
PE
13762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1377
63807d47
PE
1378 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1379 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1380 since GCC 4.4.6 issues a bogus warning for them.
1381
39adff0d
PE
1382 Fix bugs in file timestamp newness comparisons.
1383 * fileio.c (Ffile_newer_than_file_p):
1384 * lread.c (Fload): Use full timestamp resolution of files,
1385 not just the 1-second resolution, so that files that are only
1386 slightly newer still count as newer.
1387 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1388 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1389
dbeed9a6
PE
13902012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 * fileio.c: Improve handling of file time marker. (Bug#11852)
1393 (special_mtime): New function.
1394 (Finsert_file_contents, Fverify_visited_file_modtime):
1395 Use it to set special mtime values consistently.
1396
636334d6
AS
13972012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1398
1399 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1400 marker for non-existing file. (Bug#11852)
1401
e2017fe2
GM
14022012-07-03 Glenn Morris <rgm@gnu.org>
1403
1404 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1405 and did not make it into globals.h).
1406
404dbd37
TT
14072012-07-03 Tom Tromey <tromey@redhat.com>
1408
1409 * window.c (Fset_window_margins, Fset_window_fringes)
1410 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1411 * textprop.c (Fprevious_property_change): No longer static.
1412 * syntax.c (Fsyntax_table_p): No longer static.
1413 * process.c (Fget_process, Fprocess_datagram_address): No longer
1414 static.
1415 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1416 * keyboard.c (Fcommand_execute): No longer static.
1417 Remove EXFUN.
1418 * insdel.c (Fcombine_after_change_execute): No longer static.
1419 * image.c (Finit_image_library): No longer static.
1420 * fileio.c (Fmake_symbolic_link): No longer static.
1421 * eval.c (Ffetch_bytecode): No longer static.
1422 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1423 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1424 No longer static.
404dbd37
TT
1425 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1426 static.
1427 * dired.c (Ffile_attributes): No longer static.
1428 * composite.c (Fcomposition_get_gstring): No longer static.
1429 * callproc.c (Fgetenv_internal): No longer static.
1430
1431 * ccl.h: Remove EXFUNs.
1432 * buffer.h: Remove EXFUNs.
1433 * dispextern.h: Remove EXFUNs.
1434 * intervals.h: Remove EXFUNs.
1435 * fontset.h: Remove EXFUN.
1436 * font.h: Remove EXFUNs.
1437 * dosfns.c (system_process_attributes): Remove EXFUN.
1438 * keymap.h: Remove EXFUNs.
1439 * lisp.h: Remove EXFUNs.
1440 * w32term.h: Remove EXFUNs.
1441 * window.h: Remove EXFUNs.
1442 * xsettings.h: Remove EXFUN.
1443 * xterm.h: Remove EXFUN.
1444
8e4fd1e1
GM
14452012-07-03 Glenn Morris <rgm@gnu.org>
1446
1447 * lisp.h (Frandom): Make it visible to C.
1448 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1449 buffer for invisible buffers. (Bug#1229)
1450
ca95b3eb
DA
14512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1452
1453 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1454 values which aren't power of 2.
1455 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1456 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1457 accordingly.
1458
7555c33f
SM
14592012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1460
1461 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1462
1463 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1464
d12e8f5a
DA
14652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1466
1467 * alloc.c (allocate_vector_block): Remove redundant
1468 calls to mallopt if DOUG_LEA_MALLOC is defined.
1469 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1470 avoid calls to mallopt if zero_vector is returned.
1471
296094c3
DA
14722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1473
1474 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1475 is enabled, avoid dereferencing NULL current_sblock if
1476 running undumped.
1477
36429c89
DA
14782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1479
1480 Cleanup basic buffer management.
1481 * buffer.h (struct buffer): Change layout to use generic vector
1482 marking code. Fix some comments. Change type of 'clip_changed'
1483 to bitfield. Remove unused #ifndef old.
1484 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1485 (GET_OVERLAYS_AT): Fix indentation.
1486 (for_each_per_buffer_object_at): New macro.
1487 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1488 (Fbuffer_local_variables): Use it.
1489 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1490 * alloc.c (allocate_buffer): Adjust to match new layout of
1491 struct buffer. Fix comment.
1492 (mark_overlay): New function.
1493 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1494 Lisp area of struct buffer.
1495 (mark_object): Use it. Adjust marking of misc objects
1496 and related comments.
1497
3b3e4cac
PE
14982012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1501 wrapper that is not needed because the wrapped code is a no-op (zero
1502 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1503 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1504
cf5c0175
DA
15052012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1506
1507 * alloc.c (mark_buffer): Simplify. Remove prototype.
1508 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1509 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1510 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1511 redundant calls to mark_vectorlike for bool vectors.
1512
ca26824c
GM
15132012-06-30 Glenn Morris <rgm@gnu.org>
1514
2e4c5312
GM
1515 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1516
ca26824c
GM
1517 * epaths.in (PATH_SITELOADSEARCH): New.
1518 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1519 This is rather than relying on --enable-locallisppath elements
1520 having "site-lisp" in their names. (Bug#10208#25, 11658)
1521
0d23c240
EZ
15222012-06-30 Eli Zaretskii <eliz@gnu.org>
1523
c9240d7a
EZ
1524 * w32proc.c (sys_select): Accept and ignore one more argument.
1525
1526 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1527
0d23c240 1528 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1529 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1530
1531 * sysdep.c: Don't include dos.h and dosfns.h.
1532
1533 * process.c (sys_select):
1534 * msdos.c (sys_select): Accept one more argument and ignore it.
1535
1536 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1537 adapt data types and code to that.
1538
1539 * dosfns.c:
1540 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1541 which clashes with the gnulib function of the same name.
1542
af5a5a98
AS
15432012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1544
c5e4379c
AS
1545 * font.c (font_style_to_value, font_style_symbolic)
1546 (font_prop_validate_style): Add type checks for values in
1547 font_style_table.
1548
af5a5a98
AS
1549 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1550 argument.
1551 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1552 uses.
1553
8d38f461
EZ
15542012-06-29 Eli Zaretskii <eliz@gnu.org>
1555
2e5a6631
EZ
1556 * xdisp.c (try_window_id): Undo last change.
1557
8d38f461
EZ
1558 * w32.c (getwd): Adjust commentary about startup_dir.
1559 (init_environment): Always call sys_access, even in non-MSVC
1560 builds. Don't chdir to the directory of the Emacs executable.
1561 This undoes code from 1997 which was justified by the need to
1562 "avoid conflicts when removing and renaming directories". But its
1563 downside was that every relative file name was being interpreted
1564 relative to the directory of the Emacs executable, which can never
1565 be TRT. In particular, it broke sys_access when called with
1566 relative file names.
1567 (sys_access): Map GetLastError to errno.
1568
2af3565e
DA
15692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1570
1571 * window.h (struct window): Change type of 'fringes_outside_margins'
1572 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1573 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1574 Adjust comment.
1575 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1576 to ptrdiff_t.
1577
c8d3a25c 15782012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1579
c8d3a25c
GM
1580 * gnutls.c (emacs_gnutls_handshake):
1581 Add QUIT to make the loop interruptible.
57570cd3 1582
c8d3a25c 15832012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1584
c8d3a25c
GM
1585 * charset.c (init_charset): Make lack of etc/charsets fatal.
1586
3e984ee8
DA
15872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1588
1589 * editfns.c (region_limit): Fix type mismatch.
1590
ef884f23
DA
15912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1592
1593 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1594 undefined. Convert from xassert to eassert.
1595 * nsmenu.m: Convert from xassert to eassert.
1596 * nsterm.m: Likewise.
1597
7d7e0027
SM
15982012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1599
1600 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1601
aa754e6a
PE
16022012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1603
1604 Avoid integer overflow on scroll-left and scroll-right.
1605 * window.c (HSCROLL_MAX): New macro.
1606 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1607 overflow when requested scroll falls outside ptrdiff_t range.
1608
80b00b08
DA
16092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1610
1611 * window.h (struct window): Change type of 'hscroll',
1612 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1613 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1614 Adjust users accordingly.
1615 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1616 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1617 from EMACS_INT to ptrdiff_t.
1618 (make_window): Omit redundant initialization.
1619
62b2bcf6
JB
16202012-06-28 Juanma Barranquero <lekktu@gmail.com>
1621
1622 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1623
45942c7d
DA
16242012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 * window.h (struct window): Change type of 'use_time' and
1627 'sequence_number' from Lisp_Object to int.
1628 * frame.c (make_frame): Adjust users accordingly.
1629 * print.c (print_object): Likewise.
1630 * window.c (select_window, Fwindow_use_time, make_parent_window)
1631 (make_window): Likewise.
1632
e509cfa6
DA
16332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1634
1635 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1636 enabled with --enable-checking=[all,glyphs] configure option.
1637 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1638 adjust comments accordingly.
1639 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1640 undefined, adjust comments accordingly.
1641 * image.c: Likewise.
1642 * scroll.c: Likewise.
1643 * w32fns.c: Likewise.
1644 * w32term.c: Likewise.
1645 * xdisp.c: Likewise.
1646 * xfaces.c: Likewise.
1647 * xfns.c: Likewise.
1648 * xterm.c: Likewise.
1649
a54e2c05
DA
16502012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1651
1652 Generalize run-time debugging checks.
1653 * dispextern.h (XASSERTS): Remove.
1654 * fontset.c (xassert): Remove.
1655 Convert from xassert to eassert.
1656 * alloc.c: Convert from xassert to eassert.
1657 * bidi.c: Likewise.
1658 * dispnew.c: Likewise.
1659 * fns.c: Likewise.
1660 * fringe.c: Likewise.
1661 * ftfont.c: Likewise.
1662 * gtkutil.c: Likewise.
1663 * image.c: Likewise.
1664 * keyboard.c: Likewise.
1665 * menu.c: Likewise.
1666 * process.c: Likewise.
1667 * scroll.c: Likewise.
1668 * sound.c: Likewise.
1669 * term.c: Likewise.
1670 * w32console.c: Likewise.
1671 * w32fns.c: Likewise.
1672 * w32term.c: Likewise.
1673 * window.c: Likewise.
1674 * xdisp.c: Likewise.
1675 * xfaces.c: Likewise.
1676 * xfns.c: Likewise.
1677 * xselect.c: Likewise.
1678 * xterm.c: Likewise.
1679
1ec4b7b2
SM
16802012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1681
1682 * fns.c (maybe_resize_hash_table): Output message when growing the
1683 purify-hashtable.
1684
2014308a
DA
16852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1686
1687 * alloc.c (allocate_string_data): Remove dead code.
1688 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1689 avoid GCC warning about unused macro.
1690
246155eb
DA
16912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1692
1693 * alloc.c (allocate_string): Omit intervals initialization.
1694 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1695 as in make_pure_string and make_pure_c_string.
1696
43184b7b
DA
16972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1698
d209e2fb 1699 * alloc.c (allocate_string): Fix last change.
43184b7b 1700
3fe6dd74
DA
17012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1702
d209e2fb 1703 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1704 to memset, add explicit initialization where appropriate.
1705
1ba6038a
GM
17062012-06-27 Glenn Morris <rgm@gnu.org>
1707
1708 * lisp.mk (lisp): Remove paths.elc.
1709
c89926a5
CY
17102012-06-27 Chong Yidong <cyd@gnu.org>
1711
1712 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1713
ed6b3510
JW
17142012-06-26 John Wiegley <johnw@newartisans.com>
1715
1ec4b7b2 1716 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1717 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1718
ed6b3510
JW
1719 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1720 when building with Clang.
1721
8edd4a2b
SM
17222012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * eval.c (Fapply): Allow calling it with a single argument.
1725
f6f62d1b
EZ
17262012-06-26 Eli Zaretskii <eliz@gnu.org>
1727
1728 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1729 _stricmp and _strnicmp.
1730 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1731
62efea5e
DA
17322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1733
1734 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1735 allocated window.
1736 (allocate_process): Likewise for new process.
8edd4a2b 1737 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1738 (allocate_frame): Likewise.
1739 * frame.c (make_frame): Omit redundant initialization.
1740 * window.c (make_parent_window): Use memset.
1741 (make_window): Omit redundant initialization.
1742 * process.c (make_process): Omit redundant initialization.
1743 * terminal.c (create_terminal): Likewise.
1744
42997f4d
DA
17452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1746
1747 * term.c (delete_tty): Remove redundant call to memset.
1748
1130ecfc
DA
17492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1750
1751 * alloc.c: Remove build_string.
1752 * lisp.h: Define build_string as static inline. This provides
1753 a better opportunity to optimize away calls to strlen when the
1754 function is called with compile-time constant argument.
1755 * image.c (imagemagick_error): Convert to build_string.
1756 * w32proc.c (sys_spawnve): Likewise.
1757 * xterm.c (x_term_init): Likewise.
1758
cf38a720
PE
17592012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1760
99027bdd
PE
1761 Use sprintf return value instead of invoking strlen on result.
1762 In the old days this wasn't portable, since some sprintf
1763 implementations returned char *. But they died out years ago and
1764 Emacs already assumes sprintf returns int.
1765 Similarly for float_to_string.
1766 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1767 * ccl.c (ccl_driver):
1768 * character.c (string_escape_byte8):
1769 * data.c (Fnumber_to_string):
1770 * doprnt.c (doprnt):
1771 * print.c (print_object):
1772 * xdisp.c (message_dolog):
1773 * xfns.c (syms_of_xfns):
1774 Use sprintf or float_to_string result to avoid need to call strlen.
1775 * data.c (Fnumber_to_string):
1776 Use make_unibyte_string, since the string must be ASCII.
1777 * lisp.h, print.c (float_to_string): Now returns int length.
1778 * term.c (produce_glyphless_glyph):
1779 Use sprintf result rather than recomputing it.
1780
cf38a720
PE
1781 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1782 * Makefile.in (ALL_CFLAGS):
1783 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1784 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1785
3511c784
DA
17862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1787
0a08eb21 1788 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1789 strcasecmp if available.
1790 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1791
fb7da12e
AS
17922012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1793
1794 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1795 Avoid comma operator.
1796 * menu.c (push_submenu_start, push_submenu_end)
1797 (push_left_right_boundary, push_menu_pane): Likewise.
1798 * msdos.c (dos_rawgetc): Likewise.
1799
afa2ffd8
DA
18002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 * xfns.c (xic_create_fontsetname): Remove redundant calls
1803 to memset.
1804
b3b4476b
PE
18052012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1806
4495ff38
PE
1807 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1808 sprintf already null-terminates its output.
1809
b3b4476b
PE
1810 * xfns.c (x_window): Remove redundant cast.
1811
b00876c9
DA
18122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1813
1814 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1815 `const char *' to `char *' to avoid compiler warning.
1816
d188e26b
PE
18172012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1818
885d1d74
PE
1819 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1820 instead of truncating it to 63 (admittedly a generous limit).
1821
d188e26b
PE
1822 * process.c: Fix spelling and caps in comments.
1823
e2f560b1
DN
18242012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1825
e86db54b 1826 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1827 * sysdep.c (setpgrp): Remove definition, not used in this file.
1828
7583a3a1
JB
18292012-06-24 Juanma Barranquero <lekktu@gmail.com>
1830
1831 * makefile.w32-in: Update dependencies.
1832
696056c2
EZ
18332012-06-24 Eli Zaretskii <eliz@gnu.org>
1834
1835 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1836 (SYSTIME_H): Add nt/inc/sys/time.h.
1837
1838 * systime.h [WINDOWSNT]: Include sys/time.h.
1839
1840 * s/ms-w32.h (struct timespec): Definition moved from
1841 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1842
845ca893
PE
18432012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1846 * buffer.h (buffer_slot_type_mismatch):
1847 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1848 * eval.c (unwind_to_catch):
1849 * image.c (my_png_error, my_error_exit):
1850 * keyboard.c (quit_throw_to_read_char, user_error)
1851 (Fexit_recursive_edit, Fabort_recursive_edit):
1852 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1853 (wrong_type_argument, buffer_overflow, __executable_start)
1854 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1855 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1856 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1857 (fatal):
1858 (child_setup) [!DOS_NT]:
1859 * lread.c (end_of_file_error, invalid_syntax):
1860 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1861 * puresize.h (pure_write_error):
1862 * search.c (matcher_overflow):
1863 * sound.c (sound_perror, alsa_sound_perror):
1864 * sysdep.c, syssignal.h (croak):
1865 * term.c (maybe_fatal, vfatal):
1866 * textprop.c (text_read_only):
1867 * undo.c (user_error):
1868 * unexmacosx.c (unexec_error):
1869 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1870 Use _Noreturn rather than NO_RETURN.
1871 No need for separate decl merely because of _Noreturn.
1872 * sound.c (sound_warning, parse_sound):
1873 Remove unnecessary forward decls.
1874
f1dd8073
PE
18752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1878 * lisp.h (WAIT_READING_MAX): New macro.
1879 * dispnew.c (Fsleep_for, sit_for):
1880 * keyboard.c (kbd_buffer_get_event):
1881 * process.c (Faccept_process_output):
1882 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1883 This improves on the previous patch, which introduced a bug
1884 when time_t is unsigned and as wide as intmax_t.
1885 See <http://bugs.gnu.org/9000#51>.
1886
b82c1755
EZ
18872012-06-23 Eli Zaretskii <eliz@gnu.org>
1888
1889 * dispnew.c (sit_for, Fsleep_for):
1890 * keyboard.c (kbd_buffer_get_event):
1891 * process.c (Faccept_process_output): Avoid compiler warnings when
1892 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1893
ca300656
JB
18942012-06-23 Juanma Barranquero <lekktu@gmail.com>
1895
049ec95b
JB
1896 * makefile.w32-in: Update dependencies.
1897
ca300656
JB
1898 * w32.c (ltime): Add return type and declare static.
1899 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1900
db7b8d06
PE
19012012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1904 Privately reported by Herbert J. Skuhra.
1905 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1906 All uses changed.
1907 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1908 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1909
0bd8297f
EZ
19102012-06-23 Eli Zaretskii <eliz@gnu.org>
1911
96512555
EZ
1912 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1913 last argument of make_unibyte_string.
1914
0bd8297f
EZ
1915 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1916 language ID in the event parameters.
1917
1918 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1919 event.code, not the obscure "character set ID".
1920
63def6b6
CY
19212012-06-23 Chong Yidong <cyd@gnu.org>
1922
1923 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1924
e8a02204
EZ
19252012-06-23 Eli Zaretskii <eliz@gnu.org>
1926
388cdec0
EZ
1927 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1928 * w32.c (fdutimens): New function.
1929
1930 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1931
1932 * s/ms-w32.h (pselect): Redirect to sys_select.
1933
1934 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1935
e8a02204
EZ
1936 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1937 in the logic of incrementing and decrementing the value of
1938 use_relocatable_buffers.
1939
d054f3fb
PE
19402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1943 Privately reported by Herbert J. Skuhra.
1944 [__FreeBSD__]: Remove "*/" typo after "#include".
1945 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1946 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1947 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1948 Don't assume EMACS_TIME and struct timeval are the same type.
1949
d35af63c
PE
19502012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 Support higher-resolution time stamps (Bug#9000).
1953 The time stamps are only nanosecond-resolution at the C level,
1954 since that's the best that any real-world system supports now.
1955 But they are picosecond-resolution at the Lisp level, as that's
1956 easy, and leaves room for future OS improvements.
1957
1958 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1959 (LIBES): Use it.
1960
1961 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1962 Don't get current time unless it's needed.
1963
1964 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1965 now provides it if it's absent.
1966 (start_atimer): Port to higher-res time stamps.
1967 Check for time stamp overflow. Don't get current time more
1968 often than is needed.
1969
1970 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1971 Include systime.h, not time.h.
1972 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1973
1974 * dired.c: Include stat-time.h.
1975 (Ffile-attributes): File times now have higher resolution.
1976
1977 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1978 (struct image): Timestamp now has higher resolution.
1979
1980 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1981 has at least microseconds now. All uses removed.
1982 (update_frame, update_single_window, update_window, update_frame_1)
1983 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1984
1985 * editfns.c (time_overflow): Now extern.
1986 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1987 (float-time, Fformat_time_string, Fcurrent_time_string)
1988 (Fcurrent_time_zone): Accept and generate higher-resolution
1989 time stamps.
1990 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1991 (decode_time_components, lisp_seconds_argument): New functions.
1992 (make_time): Now static.
1993 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1994 Report an error if the time is invalid, rather than having the caller
1995 do that.
1996
1997 * fileio.c: Include <stat-time.h>
1998 (Fcopy_file): Copy higher-resolution time stamps.
1999 Prefer to set the time stamp via a file descriptor if that works.
2000 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2001 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2002 (Fvisited_file_modtime, Fset_visited_file_modtime):
2003 Support higher-resolution time stamps.
2004
2005 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2006
2007 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2008
2009 * image.c (prepare_image_for_display, clear_image_cache)
2010 (lookup_image): Port to higer-resolution time stamps.
2011
2012 * keyboard.c (start_polling, bind_polling_period):
2013 Check for time stamp overflow.
2014 (read_char, kbd_buffer_get_event, timer_start_idle)
2015 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2016 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2017 Port to higher-resolution time stamps. Do not assume time_t is signed.
2018 (decode_timer): New function. Timers are now vectors of length 9,
2019 not 8, to accommodate the picosecond component.
2020 (timer_check_2): Use it.
2021
2022 * nsterm.m (select_timeout, timeval_subtract): Remove.
2023 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2024 as they're a bit more accurate and handle overflow better.
2025 (ns_select): Change prototype to be compatible with pselect.
2026 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2027 * nsterm.h (ns_select): Adjust prototype.
2028
2029 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2030 us-resolution time stamps.
2031 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2032
2033 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2034
2035 * lisp.h (time_overflow): New decl.
2036 (wait_reading_process_output): First arg is now intmax_t, not int,
2037 to accommodate larger waits.
2038
2039 * process.h (struct Lisp_Process.read_output_delay):
2040 Now counts nanoseconds, not microseconds.
2041 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2042 EMACS_HAS_USECS.
2043 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2044 (wait_reading_process_output):
2045 Port to ns-resolution time stamps.
2046 (Faccept_process_output, wait_reading_process_output):
2047 Check for time stamp overflow. Do not assume time_t is signed.
2048 (select_wrapper): Remove; we now use pselect.
2049 (Fprocess_attributes): Now generates ns-resolution time stamps.
2050
2051 * sysdep.c: Include utimens.h. Don't include utime.h
2052 or worry about struct utimbuf; gnulib does that for us now.
2053 (gettimeofday): Remove; gnulib provides a substitute.
2054 (make_timeval): New function.
2055 (set_file_times): Now sets ns-resolution time stamps.
2056 New arg FD; all uses changed.
2057 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2058 (system_process_attributes):
2059 Now returns ns-resolution time stamp. All uses changed.
2060 Check for time stamp overflow.
2061
2062 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2063 provides a substitute now.
2064
2065 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2066 since it guarantees struct timespec.
2067 (EMACS_TIME): Now struct timespec, so that we can support
2068 ns-resolution time stamps.
2069 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2070 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2071 (EMACS_USECS): Remove.
2072 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2073 so multiply the arg by 1000 before storing it.
2074 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2075 New macros.
2076 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2077 Port to ns-resolution time stamps.
2078 (EMACS_TIME_NEG_P): Remove; replaced by....
2079 (EMACS_TIME_SIGN): New macro.
2080 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2081 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2082 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2083 (make_timeval, make_lisp_time, decode_time_components): New decls.
2084 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2085 that it mishandled time_t overflow. You can't compare by subtracting!
2086 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2087 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2088
2089 * term.c: Include <sys/time.h>.
2090 (timeval_to_Time): New function, for proper overflow wraparound.
2091 (term_mouse_position, term_mouse_click): Use it.
2092
2093 * undo.c (record_first_change): Support higher-resolution time stamps
2094 in the undo buffer.
2095 (Fprimitive_undo): Use them when restoring time stamps.
2096
2097 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2098 (w32_get_internal_run_time):
2099 Port to higher-resolution Emacs time stamps.
2100 (ltime): Now accepts single 64-bit integer, as that's more convenient
2101 for callers.
2102
2103 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2104
2105 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2106 for compatibility with pselect. Support ns-resolution time stamps.
2107
2108 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2109
2110 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2111 Check for time stamp overflow, and support ns-resolution time stamps.
2112
2113 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2114 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2115 (timeval_subtract): Remove; no longer needed.
2116 (XTflash, XTring_bell, x_wait_for_event):
2117 Port to ns-resolution time stamps. Don't assume time_t is signed.
2118
b6a92dfe
CY
21192012-06-22 Chong Yidong <cyd@gnu.org>
2120
2121 * xdisp.c (x_consider_frame_title): Revert last change.
2122
d251c37c
EZ
21232012-06-22 Eli Zaretskii <eliz@gnu.org>
2124
2125 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2126 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2127 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2128 staticidx goes up to 1597 out of 1600 = 0x640.)
2129
f10deafb
PE
21302012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2131
2132 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2133 Otherwise, the umask might be mistakenly 0 while handling input signals.
2134
ec6de1e2
SM
21352012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2136
2137 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2138
28be1ada
DA
21392012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2140
2141 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2142 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2143 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2144 access to `contents' member of Lisp_Vector objects with AREF and ASET
2145 where appropriate.
2146
c6bf3022
CY
21472012-06-19 Chong Yidong <cyd@gnu.org>
2148
2149 * frame.c (delete_frame): When selecting a frame on a different
2150 text terminal, do not alter the terminal's top-frame.
2151
2152 * xdisp.c (format_mode_line_unwind_data): Record the target
2153 frame's selected window and its terminal's top-frame.
2154 (unwind_format_mode_line): Restore them.
2155 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2156 Callers changed.
2157 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2158 since tty frames can be explicitly named.
2159 (prepare_menu_bars): Likewise.
2160
2161 * term.c (Ftty_top_frame): New function.
2162
defd4196
PE
21632012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 Port byte-code-meter to modern targets.
2166 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2167 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2168 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2169 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2170 (METER_1, METER_2): Simplify.
2171
1053a871
SM
21722012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2173
2174 * data.c (Fdefalias): Return `symbol' (bug#11686).
2175
b7e8d081
MR
21762012-06-18 Martin Rudalics <rudalics@gmx.at>
2177
2178 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2179 gets killed during executing of this function (Bug#11665).
2180 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2181 (Vkill_buffer_query_functions): In doc-string say that functions
2182 run by this hook should not change the current buffer.
2183
7ea2b339
PE
21842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 Fix recently-introduced process.c problems found by static checking.
2187 * process.c (write_queue_push, write_queue_pop, send_process):
2188 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2189 (write_queue_pop): Fix pointer signedness problem.
2190 (send_process): Remove unused local.
2191
96a313a1
CY
21922012-06-17 Chong Yidong <cyd@gnu.org>
2193
2194 * xdisp.c (redisplay_internal): No need to redisplay terminal
2195 frames that are not on top.
2196
20ca2e94
TN
21972012-06-17 Troels Nielsen <bn.troels@gmail.com>
2198
2199 * process.c (make_process): Initialize write_queue.
2200 (write_queue_push, write_queue_pop): New functions.
2201 (send_process): Use them to maintain correct ordering of process
2202 writes (Bug#10815).
2203
9a900ca9
PE
22042012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2205
310fbfa8
PE
2206 * lisp.h (eassert): Assume C89 or later.
2207 This removes the need for CHECK.
2208 (CHECK): Remove. Its comments about always evaluating its
2209 argument were confusing, as 'eassert' typically does not evaluate
2210 its argument.
2211
27bb1ca4
PE
2212 * coding.c (produce_chars): Use ptrdiff_t, not int.
2213
9a900ca9
PE
2214 * xterm.c (x_draw_underwave): Check for integer overflow.
2215 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2216
41b7f8bc 22172012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2218
2219 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2220 referenced (Bug#11583).
2221
9b0e3eba
AA
22222012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2223
2224 Implement wave-style variant of underlining.
2225 * dispextern.h (face_underline_type): New enum.
2226 (face): Add field for underline type.
2227 * nsterm.m (ns_draw_underwave): New function.
2228 (ns_draw_text_decoration): Use it.
2229 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2230 New functions.
2231 (x_draw_glyph_string): Use them.
2232 * xfaces.c (Qline, Qwave): New Lisp objects.
2233 (check_lface_attrs, merge_face_ref)
1053a871
SM
2234 (Finternal_set_lisp_face_attribute, realize_x_face):
2235 Handle wave-style underline face attributes.
9b0e3eba
AA
2236 * xterm.c (x_draw_underwave): New function.
2237 (x_draw_glyph_string): Use it.
2238
0fb52f11
JB
22392012-06-16 Juanma Barranquero <lekktu@gmail.com>
2240
2241 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2242 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2243 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2244 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2245 ($(BLD)/w32select.$(O)): Update dependencies.
2246
e5560ff7
AS
22472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2248
2249 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2250 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2251 * character.c (_fetch_multibyte_char_p): Remove.
2252 * alloc.c: Include "character.h" before "buffer.h".
2253 * bidi.c: Likewise.
2254 * buffer.c: Likewise.
2255 * bytecode.c: Likewise.
2256 * callint.c: Likewise.
2257 * callproc.c: Likewise.
2258 * casefiddle.c: Likewise.
2259 * casetab.c: Likewise.
2260 * category.c: Likewise.
2261 * cmds.c: Likewise.
2262 * coding.c: Likewise.
2263 * composite.c: Likewise.
2264 * dired.c: Likewise.
2265 * dispnew.c: Likewise.
2266 * doc.c: Likewise.
2267 * dosfns.c: Likewise.
2268 * editfns.c: Likewise.
2269 * emacs.c: Likewise.
2270 * fileio.c: Likewise.
2271 * filelock.c: Likewise.
2272 * font.c: Likewise.
2273 * fontset.c: Likewise.
2274 * fringe.c: Likewise.
2275 * indent.c: Likewise.
2276 * insdel.c: Likewise.
2277 * intervals.c: Likewise.
2278 * keyboard.c: Likewise.
2279 * keymap.c: Likewise.
2280 * lread.c: Likewise.
2281 * macros.c: Likewise.
2282 * marker.c: Likewise.
2283 * minibuf.c: Likewise.
2284 * nsfns.m: Likewise.
2285 * nsmenu.m: Likewise.
2286 * print.c: Likewise.
2287 * process.c: Likewise.
2288 * regex.c: Likewise.
2289 * region-cache.c: Likewise.
2290 * search.c: Likewise.
2291 * syntax.c: Likewise.
2292 * term.c: Likewise.
2293 * textprop.c: Likewise.
2294 * undo.c: Likewise.
2295 * unexsol.c: Likewise.
2296 * w16select.c: Likewise.
2297 * w32fns.c: Likewise.
2298 * w32menu.c: Likewise.
2299 * window.c: Likewise.
2300 * xdisp.c: Likewise.
2301 * xfns.c: Likewise.
2302 * xmenu.c: Likewise.
2303 * xml.c: Likewise.
2304 * xselect.c: Likewise.
2305
2f07e6af
EZ
23062012-06-16 Eli Zaretskii <eliz@gnu.org>
2307
1053a871
SM
2308 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2309 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2310 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2311 row.
2312 (handle_face_prop): Use chunk-relative overlay string index when
2313 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2314 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2315 the rightmost. (Bug#11720)
2f07e6af 2316
29b83cec
AS
23172012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2318
2319 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2320 (CATEGORY_MEMBER): Enforce 1/0 value.
2321 * category.c (_temp_category_set): Remove.
2322
4c5501e9
EZ
23232012-06-16 Eli Zaretskii <eliz@gnu.org>
2324
2325 * window.c (Fdelete_other_windows_internal)
2326 (Fdelete_window_internal): Don't access frame's mouse highlight
2327 info of the initial frame. (Bug#11677)
2328
2b570124
PE
23292012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2330
e93864f9
PE
2331 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2332 Assume USE_2_TAGS_FOR_INTS.
2333 (xreload): Adjust $tagmask width to match recent lisp.h change.
2334
2b570124
PE
2335 Simplify lisp.h in minor ways that should not affect code.
2336 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2337 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2338 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2339 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2340 (INTTYPEBITS): New macro, for clarity.
2341 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2342 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2343 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2344 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2345 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2346
81755f69
JB
23472012-06-13 Juanma Barranquero <lekktu@gmail.com>
2348
2349 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2350
16192a57
GM
23512012-06-13 Glenn Morris <rgm@gnu.org>
2352
2353 * s/bsd-common.h (BSD4_3):
2354 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2355
646b5f55
AS
23562012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2357
2358 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2359 instead of union.
2360 (XLI, XIL): Define.
1053a871
SM
2361 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2362 Use them.
2363 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2364 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2365 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2366 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2367 * frame.c (delete_frame): Remove outdated comment.
2368 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2369 USE_LISP_UNION_TYPE.
2370 (Fw32_unregister_hot_key): Likewise.
2371 (Fw32_toggle_lock_key): Likewise.
2372 * w32menu.c (add_menu_item): Likewise.
2373 (w32_menu_display_help): Use XIL instead of checking
2374 USE_LISP_UNION_TYPE.
2375 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2376 (init_heap): Likewise.
2377 * w32term.c (w32_read_socket): Update comment.
2378
1d3823c9
GM
23792012-06-13 Glenn Morris <rgm@gnu.org>
2380
c62ff706
GM
2381 * s/usg5-4-common.h, src/s/unixware.h:
2382 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2383
1d3823c9
GM
2384 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2385
bfe3e0a2
PE
23862012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2389 * alloc.c (make_number) [!defined make_number]:
2390 Remove, as lisp.h always defines this now.
2391 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2392 (roundup_size): Verify that it is a power of 2.
2393 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2394 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2395 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2396 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2397 USE_LSB_TAG now is always defined to be either 0 or 1.
2398 All uses changed.
2399 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2400 code works fine either way, and efficiency is not a concern here,
2401 as the union type is for debugging, not for production.
2402 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2403 Use an inline function on all platforms when using the union type,
2404 since this is simpler and 'static inline' can be used portably
2405 within Emacs now.
2406 (LISP_INITIALLY_ZERO): New macro.
2407 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2408 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2409
45fa9c0f
GM
24102012-06-12 Glenn Morris <rgm@gnu.org>
2411
b4492cba
GM
2412 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2413
2414 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2415
45fa9c0f
GM
2416 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2417 Move BROKEN_SIGIO to configure.
2418
2419 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2420 Move NO_TERMIO to configure.
2421
0e25d334
CY
24222012-06-12 Chong Yidong <cyd@gnu.org>
2423
2424 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2425 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2426 MagickExportImagePixels is undefined.
2427
43682bb6
PE
24282012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2429
2430 * image.c (imagemagick_load_image): Remove unused label.
2431
a9be7d2b
GM
24322012-06-11 Glenn Morris <rgm@gnu.org>
2433
2434 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2435 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2436 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2437 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2438
3017f87f
SM
24392012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2440
2441 * alloc.c (make_byte_code): New function.
2442 (Fmake_byte_code): Use it. Don't purify here.
2443 * lread.c (read1): Use it as well to avoid extra allocation.
2444
1b9b4cf4
CY
24452012-06-11 Chong Yidong <cyd@gnu.org>
2446
2447 * image.c (imagemagick_load_image): Implement transparency.
2448
95988fcf
AS
24492012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2450
2451 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2452 account for preceding backslashes. (Bug#11663)
2453
cd4eb164
CY
24542012-06-09 Chong Yidong <cyd@gnu.org>
2455
2456 * term.c: Support italics in capable terminals (Bug#9652).
2457 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2458 (turn_on_face): Output using TS_enter_italic_mode if available.
2459 Don't handle unused blinking and alt-charset cases.
2460 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2461 and tty_alt_charset_p cases.
2462 (tty_capable_p, init_tty): Support italics.
2463
2464 * termchar.h (struct tty_display_info): Add field for italics.
2465 Remove unused blink field.
2466
2467 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2468 Handle slant.
2469
2470 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2471 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2472 tty_alt_charset_p. Add tty_italic_p.
2473
ff88beb8
MA
24742012-06-09 Michael Albinus <michael.albinus@gmx.de>
2475
2476 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2477 dbus_type_is_basic if available.
2478 (xd_extract_signed, xd_extract_unsigned): Rename from
2479 extract_signed and extract_unsigned, respectively. Adapt callers.
2480
44286096
CY
24812012-06-09 Chong Yidong <cyd@gnu.org>
2482
1682701f
CY
2483 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2484
44286096
CY
2485 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2486 case (Bug#9752).
2487
d86feb17
PE
24882012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 * xdisp.c (vmessage): Treat frame message as multibyte.
2491 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2492 would generate the diagnostic "Making \302\247 buffer-local while
2493 let-bound!".
2494
d5c20fe8
EZ
24952012-06-08 Eli Zaretskii <eliz@gnu.org>
2496
2497 * dispnew.c (showing_window_margins_p): Undo last change, which
2498 was done due to an inadvertent commit.
2499 (adjust_frame_glyphs_for_frame_redisplay): Do call
2500 showing_window_margins_p.
2501
513749ee
SM
25022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2503
2504 * eval.c (Fmake_var_non_special): New primitive.
2505 (syms_of_eval): Defsubr it.
2506 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2507
d4a8f5c1
JB
25082012-06-08 Juanma Barranquero <lekktu@gmail.com>
2509
2510 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2511 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2512
8bbbc977
EZ
25132012-06-08 Eli Zaretskii <eliz@gnu.org>
2514
2515 * alloc.c (allocate_vectorlike): Fix last change.
2516
f3372c87
DA
25172012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2518
2519 Block-based vector allocation of small vectors.
2520 * lisp.h (struct vectorlike_header): New field `nbytes',
2521 adjust comment accordingly.
2522 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2523 to denote vector blocks. Adjust users (live_vector_p,
2524 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2525 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2526 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2527 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2528 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2529 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2530 (roundup_size): New constant.
2531 (struct vector_block): New data type.
2532 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2533 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2534 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2535 (sweep_vectors): New functions.
2536 (allocate_vectorlike): Return `zero_vector' as the only vector of
2537 0 items. Allocate new vector from block if vector size is less than
2538 or equal to VBLOCK_BYTES_MAX.
2539 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2540 (init_alloc_once): Add call to init_vectors.
2541
4f18a4ed
SM
25422012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2543
2544 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2545
86f158bc
PE
25462012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2547
2548 * doprnt.c (doprnt): Truncate multibyte char correctly.
2549 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2550 would mishandle a string argument "Xc" if X was a multibyte
2551 character of length 2: it would truncate after X's first byte
2552 rather than including all of X.
2553
c5cfcbe0
CY
25542012-06-06 Chong Yidong <cyd@gnu.org>
2555
2556 * buffer.c (word_wrap): Doc fix.
2557
c05cf390
PE
25582012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2559
2560 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2561
0c3461de
GM
25622012-06-03 Glenn Morris <rgm@gnu.org>
2563
2564 * xdisp.c (tool-bar-style): Doc fix.
2565
c71232db
UM
25662012-06-03 Ulrich Müller <ulm@gentoo.org>
2567
2568 * Makefile.in (PAXCTL): Define.
2569 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2570 binary via PaX flags if the paxctl utility is available.
2571 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2572 Restore PaX flags to their default. (Bug#11398)
2573
383f7350
CY
25742012-06-03 Chong Yidong <cyd@gnu.org>
2575
2576 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2577 buffer (Bug#11226).
2578
5f2c76c6
CY
25792012-06-03 Chong Yidong <cyd@gnu.org>
2580
2581 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2582 (note_mode_line_or_margin_highlight): If there is no help echo,
2583 use mode-line-default-help-echo. Handle the case where the mouse
2584 position is past the end of the mode line string.
2585
2586 * buffer.c (buffer_local_value_1): New function, split from
2587 Fbuffer_local_value; can return Qunbound.
2588 (Fbuffer_local_value): Use it.
2589 (Vmode_line_format): Docstring tweaks.
2590
773d47f6
PE
25912012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 * sysdep.c (system_process_attributes): Improve comment.
2594
f2d6a3df
SM
25952012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2596
2597 * keyboard.c: Export real-this-command to Elisp.
2598 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2599 and DEFVAR it. Update all users.
2600
63810350
PE
26012012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2602
7bd5c1f4
PE
2603 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2604
63810350
PE
2605 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2606 Convert pctcpu and pctmem to Lisp float properly.
2607 Let the compiler fold better, as 100.0/0x8000 is exact.
2608
a2821611
AS
26092012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2610
2611 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2612 cons_block.
2613
5fceba1d
PE
26142012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2617
c98ff5dd
DA
26182012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2619
2620 For a 'struct window', replace some Lisp_Object fields to
2621 bitfields where appropriate, remove unused fields.
2622 * window.h (struct window): Remove unused 'last_mark_x' and
2623 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2624 change it's type from Lisp_Object to bitfield.
2625 Change type of 'force_start', 'optional_new_start',
2626 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2627 fields from Lisp_Object to bitfield. Adjust users accordingly.
2628
ca34e0be
PE
26292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2630
2631 Pacify gcc -Wdouble-precision when using Xaw.
2632 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2633 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2634 Use 'float' consistently, rather than 'float' in most places
2635 and 'double' in a couple of places.
2636
efc00ab1 26372012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2638
2639 * xdisp.c (handle_stop): Detect whether we have overlay strings
2640 loaded by testing it->current.overlay_string_index to be
2641 non-negative, instead of checking whether n_overlay_strings is
2642 positive. (Bug#11587)
2643
efc00ab1 26442012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2645
2646 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2647
2648 * doc.c (Fsubstitute_command_keys): Doc fix.
2649
efc00ab1 26502012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2651
2652 * search.c (search_buffer): Remove calls to
2653 r_alloc_inhibit_buffer_relocation, as it is now called by
2654 maybe_unify_char, which was the cause of relocation of buffer text
2655 in bug#11519.
2656
efc00ab1 26572012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2658
2659 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2660 for the duration of call to load_charset, to avoid problems with
2661 callers of maybe_unify_char that access buffer text through C
2662 pointers.
2663
2664 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2665 decrement the inhibition flag, instead of just setting or
2666 resetting it.
2667
ba93a187
PE
26682012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 Remove obsolete '#define static' cruft.
2671 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2672 This #undef was "temporary" in 2000; it is no longer needed
2673 now that '#define static' has gone away.
2674 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2675 (gray_bitmap_bits): Remove; no longer needed.
2676 All uses replaced with definiens.
2677 * xterm.c: Include "bitmaps/gray.xbm".
2678
9e4bf381
PE
26792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 Clean up __executable_start, monstartup when --enable-profiling.
2682 The following changes affect the code only when profiling.
2683 * dispnew.c (__executable_start): Rename from safe_bcopy.
2684 Define only on platforms that need it.
2685 * emacs.c: Include <sys/gmon.h> when profiling.
2686 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2687 (__executable_start): Remove decl, since lisp.h does it now.
2688 (safe_bcopy): Remove decl; no longer has that name.
2689 (main): Coalesce #if into single bit of code, for simplicity.
2690 Cast pointers to uintptr_t, since standard libraries want integers
2691 and not pointers.
2692 * lisp.h (__executable_start): New decl.
2693
32d72c2f
GM
26942012-05-31 Glenn Morris <rgm@gnu.org>
2695
2696 * image.c (Fimagemagick_types): Doc fix.
2697
baac5bc7
JM
26982012-05-30 Jim Meyering <meyering@redhat.com>
2699
2700 * callproc.c (Fcall_process_region): Include directory component
2701 in mkstemp error message (Bug#11586).
2702
72cb32cf
PE
27032012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2704
2705 * alloc.c, lisp.h (make_pure_vector): Now static.
2706
61b108cc
SM
27072012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2708
2709 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2710 Move to byte-run.el.
2711 (Fautoload): Do the hash-doc more carefully.
2712 * data.c (Fdefalias): Purify definition, except for keymaps.
2713 (Qdefun): Move from eval.c.
2714 * lisp.h (Qdefun): Remove.
2715 * lread.c (read1): Tiny simplification.
2716
471fe23d
TN
27172012-05-29 Troels Nielsen <bn.troels@gmail.com>
2718
934f3f58 2719 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2720 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2721 Bug#9642, but explicitly check that the buffer the overlay would
2722 be moved to is live and rearrange lines to make sure that errors
2723 will not put the overlay in an inconsistent state.
2724 (Fdelete_overlay): Cosmetics.
2725
85d0efd1
EZ
27262012-05-28 Eli Zaretskii <eliz@gnu.org>
2727
2728 * w32term.c (my_bring_window_to_top): New function.
2729 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2730 could be different from the original one.
2731 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2732 (Bug#11513)
2733
2734 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2735 by calling BringWindowToTop.
2736
2737 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2738 (WM_EMACS_END): Increase by one.
2739
da92a98c
PE
27402012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2741
2742 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2743 This avoids undefined behavior that might cause the eassert
2744 to not catch an out-of-range value.
2745
74d1f848
JB
27462012-05-28 Juanma Barranquero <lekktu@gmail.com>
2747
2748 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2749 Update dependencies.
2750
9e1a06fc
EZ
27512012-05-27 Eli Zaretskii <eliz@gnu.org>
2752
2753 * bidi.c (bidi_mirror_char): Fix last change.
2754
f3dd7312
AS
27552012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2756
2757 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2758 when referring to sectname field in printf format.
2759
81899c91
PE
27602012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2761
57b81a9f
PE
2762 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2763 Only r_alloc_inhibit_buffer_relocation needed to be added;
2764 the others were already declared.
2765
81899c91
PE
2766 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2767 before checking whether it's out of range. Put the check inside
2768 eassert. See
2769 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2770
33017faf 27712012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2772
2773 * callproc.c (Fcall_process): Restore a line that was accidentally
2774 commented out in the 2011-02-13 change (bug#11547).
2775
33017faf 27762012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2777
2778 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2779 defined on ralloc.c.
2780
2781 * buffer.c [REL_ALLOC]: Remove prototypes of
2782 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2783 they are now on lisp.h.
2784
2785 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2786
2787 * search.c (search_buffer): Use it to inhibit relocation of buffer
2788 text while re_search_2 is doing its job, because re_search_2 is
2789 passed C pointers to buffer text. (Bug#11519)
2790
23415acf
EZ
2791 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2792 Update value to 24.
2793
44e27368
EZ
2794 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2795 state after an additional call to move_it_in_display_line_to, keep
2796 the values of it->max_ascent and it->max_descent found for the
2797 entire line.
2798 (pos_visible_p): Revert the comparison against bottom_y to what it
2799 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2800 (Bug#11464)
2801
c1892f11
PE
28022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 Fix coding-related core dumps with gcc -ftrapv.
2805 The code was computing A - B, where A and B are pointers, and B is
2806 random garbage. This can lead to core dumps on platforms that
2807 have special pointer registers, and it also leads to core dumps on
2808 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2809 A - B only when B is initialized properly.
2810 * coding.c (coding_set_source, coding_set_destination): Return void.
2811 (coding_change_source, coding_change_destinations): New functions,
2812 with the old behaviors of coding_set_source and coding_set_destination.
2813 All callers that need an offset changed to use these new functions.
2814
eb7afdad
GM
28152012-05-26 Glenn Morris <rgm@gnu.org>
2816
2817 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2818
f12fdf02
EZ
28192012-05-26 Eli Zaretskii <eliz@gnu.org>
2820
53a63be6 2821 Extend mouse support on W32 text-mode console.
61b108cc
SM
2822 * xdisp.c (draw_row_with_mouse_face):
2823 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2824
eb3f6f01 2825 * w32console.c: Include window.h.
61b108cc
SM
2826 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2827 New functions.
eb3f6f01
EZ
2828 (initialize_w32_display): Initialize mouse-highlight data.
2829
53a63be6
EZ
2830 * w32inevt.c: Include termchar.h and window.h.
2831 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2832 moves, call note_mouse_highlight. If help_echo changed, call
2833 gen_help_event to produce help-echo message in the echo area.
2834 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2835 highlight info.
2836
4cfd81f6
PE
28372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 * lread.c (read1): Simplify slightly to avoid an overflow warning
2840 with GCC 4.7.0 on x86-64.
2841
4446092a
EZ
28422012-05-26 Eli Zaretskii <eliz@gnu.org>
2843
2844 * bidi.c (bidi_mirror_char): Revert last change: an int is
2845 definitely wide enough here.
2846
42b2a986 28472012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2848
42b2a986 2849 Fix integer width and related bugs (Bug#9874).
eb106a49 2850 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2851 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2852 (string_bytes, check_sblock, allocate_string_data):
2853 (compact_small_strings, Fmake_bool_vector, make_string)
2854 (make_unibyte_string, make_multibyte_string)
2855 (make_string_from_bytes, make_specified_string)
2856 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2857 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2858 (mark_vectorlike):
2859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2860 (allocate_pseudovector):
2861 Use int, not EMACS_INT, where int is wide enough.
2862 (inhibit_garbage_collection, Fgarbage_collect):
2863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2864 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2865 int might not be wide enough.
2866 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2867 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2868 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2869 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2870 (bidi_level_of_next_char, bidi_move_to_visually_next):
2871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2872 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2873 (Fkill_buffer, Fset_buffer_major_mode)
2874 (advance_to_char_boundary, Fbuffer_swap_text)
2875 (Fset_buffer_multibyte, overlays_at, overlays_in)
2876 (overlay_touches_p, struct sortvec, record_overlay_string)
2877 (overlay_strings, recenter_overlay_lists)
2878 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2879 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2880 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2881 (Foverlay_recenter, last_overlay_modification_hooks_used)
2882 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2884 (validate_region): Omit unnecessary test for b <= e,
2885 since that's guaranteed by the previous test.
d311d28c
PE
2886 (adjust_overlays_for_delete): Avoid pos + length overflow.
2887 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2888 (report_overlay_modification):
2889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2890 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2891 Omit pointer cast, which isn't needed anyway, and doesn't work
2892 after the EMACS_INT -> ptrdiff_t change.
02481186 2893 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2894 * buffer.h: Adjust decls to match defn changes elsewhere.
2895 (struct buffer_text, struct buffer):
2896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2897 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2898 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2899 not int, to avoid needless 32-bit limit on 64-bit hosts.
2900 (exec_byte_code): Use tighter memory-full test, one that checks
2901 for alloca overflow. Don't compute the address of the object just
2902 before an array, as that's not portable. Use EMACS_INT, not
2903 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2904 * callint.c (Fcall_interactively):
2905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2906 * callproc.c (call_process_kill, Fcall_process):
2907 Don't assume pid_t fits into an Emacs fixnum.
2908 (call_process_cleanup, Fcall_process, child_setup):
2909 Don't assume pid_t fits into int.
2910 (call_process_cleanup, Fcall_process, delete_temp_file)
2911 (Fcall_process_region):
2912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2913 (Fcall_process): Simplify handling of volatile integers.
2914 Use int, not EMACS_INT, where int will do.
2915 * casefiddle.c (casify_object, casify_region, operate_on_word)
2916 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2918 (casify_object): Avoid integer overflow when overallocating buffer.
2919 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2920 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2921 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2922 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2923 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2924 integers are now checked earlier. All uses replaced with XINT.
2925 (ccl_driver):
2926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2927 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2928 (ccl_driver, Fregister_code_conversion_map):
2929 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2930 (resolve_symbol_ccl_program): Check that vector header is in range.
2931 Always copy the vector, so that we can check its contents reliably
2932 now rather than having to recheck each instruction as it's being
2933 executed. Check that vector words fit in 'int'.
2934 (ccl_get_compiled_code, Fregister_ccl_program)
2935 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2936 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2937 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2938 contents are in range.
2939 (Fccl_execute_on_string): Check that status is in range.
2940 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2941 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2942 Accept and return EMACS_INT, not int, because callers can pass values
2943 out of 'int' range.
2944 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2945 (multibyte_chars_in_text, parse_str_as_multibyte)
2946 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2947 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2948 (string_escape_byte8, Fget_byte):
2949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2950 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2951 avoid mishandling large integers.
2952 * character.h: Adjust decls to match defn changes elsewhere.
2953 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2954 (Ffind_charset_region):
2955 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2956 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2957 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2958 Don't assume fixnum fits in int.
d311d28c
PE
2959 (load_charset_map_from_vector, Fmap_charset_chars):
2960 Remove now-unnecessary CHECK_NATNUMs.
2961 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2962 Don't rely on undefined behavior with signed left shift overflow.
2963 Don't assume unsigned int fits into fixnum, or that fixnum fits
2964 into unsigned int. Don't require max_code to be a valid fixnum;
2965 that's not true for gb10830 4-byte on a 32-bit host. Allow
2966 invalid_code to be a cons, for the same reason. Require code_offset
2967 to be a character. Avoid int overflow if max_char is close
2968 to INT_MAX.
2969 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2970 this is intended anyway and avoids some undefined behavior.
2971 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2972 INDEX_TO_CODE_POINT, as that's what it expects.
2973 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2974 * charset.h (DECODE_CHAR): Return int, not unsigned;
2975 this is what was intended anyway, and it avoids undefined behavior.
2976 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2977 integer-overflow issues.
2978 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2979 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2980 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2981 * chartab.c (Fmake_char_table, Fset_char_table_range)
2982 (uniprop_get_decoder, uniprop_get_encoder):
2983 Don't assume fixnum fits in int.
2984 * cmds.c (move_point): New function, that does the gist of
2985 Fforward_char and Fbackward_char, but does so while checking
2986 for integer overflow more accurately.
c96e5d6a 2987 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2988 (Fforward_line, Fend_of_line, internal_self_insert)
2989 (internal_self_insert):
2990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2991 Fix a FIXME, by checking for integer overflow when calculating
2992 target_clm and actual_clm.
2993 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2994 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2995 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2996 (coding_alloc_by_making_gap, alloc_destination)
2997 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2998 (encode_coding_utf_16, detect_coding_emacs_mule)
2999 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3000 (detect_coding_iso_2022, decode_coding_iso_2022)
3001 (encode_invocation_designation, encode_designation_at_bol)
3002 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3003 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3004 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3005 (encode_coding_ccl, encode_coding_raw_text)
3006 (detect_coding_charset, decode_coding_charset)
3007 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3008 (produce_composition, produce_charset, produce_annotation)
3009 (decode_coding, handle_composition_annotation)
3010 (handle_charset_annotation, consume_chars, decode_coding_gap)
3011 (decode_coding_object, encode_coding_object, detect_coding_system)
3012 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3013 (code_convert_region, code_convert_string)
8f50130c
PE
3014 (Fdefine_coding_system_internal)
3015 (coding_set_source, coding_set_destination):
d311d28c
PE
3016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3017 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3018 (Fdefine_coding_system_internal):
3019 Don't assume fixnums fit in int.
3020 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3021 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3022 (Funencodable_char_position, Fcheck_coding_systems_region)
3023 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3025 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3026 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3027 Don't access memory outside of the args array.
d311d28c 3028 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3029 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3030 result of ENCODE_CHAR.
d311d28c
PE
3031 * coding.h: Adjust decls to match defn changes elsewhere.
3032 (struct coding_system):
3033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3034 * composite.c (get_composition_id, find_composition)
3035 (run_composition_function, update_compositions)
3036 (compose_text, composition_gstring_put_cache)
3037 (composition_gstring_p, composition_gstring_width)
3038 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3039 (composition_compute_stop_pos, composition_reseat_it)
3040 (composition_update_it, struct position_record)
3041 (find_automatic_composition, composition_adjust_point)
3042 (Fcomposition_get_gstring, Ffind_composition_internal):
3043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3044 (update_compositions):
3045 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3046 * composite.h: Adjust decls to match defn changes elsewhere.
3047 (struct composition):
3048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3049 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3050 Do not attempt to compute the address of the object just before a
3051 buffer; this is not portable.
3052 (Faref, Faset):
3053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3054 (Faset): Use int, not EMACS_INT, where int is wide enough.
3055 (Fstring_to_number): Don't assume fixnums fit in int.
3056 (Frem): Don't assume arg is nonnegative.
3057 * dbusbind.c (xd_append_arg): Check for integers out of range.
3058 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3059 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3060 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3061 (xd_get_connection_references): Return ptrdiff_t, not int.
3062 All uses changed.
3063 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3064 (xd_read_message_1):
3065 Use int, not unsigned, where the dbus API uses int.
3066 (Fdbus_message_internal): Don't overflow mtype.
3067 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3068 * dired.c (directory_files_internal, file_name_completion, scmp)
3069 (file_name_completion_stat):
3070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3071 (file_name_completion): Don't overflow matchcount.
3072 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3073 * dispextern.h: Adjust decls to match defn changes elsewhere.
3074 (struct text_pos, struct glyph, struct bidi_saved_info)
3075 (struct bidi_string_data, struct bidi_it, struct composition_it)
3076 (struct it):
3077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3078 (struct display_pos, struct composition_it, struct it):
3079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3080 * dispnew.c (increment_matrix_positions)
3081 (increment_row_positions, mode_line_string)
3082 (marginal_area_string):
3083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3084 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3086 (duration_to_sec_usec): New function, to check for overflow better.
3087 (Fsleep_for, sit_for): Use it.
3088 * doc.c (get_doc_string, store_function_docstring):
3089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3090 (get_doc_string, Fsnarf_documentation):
3091 Use int, not EMACS_INT, where int is wide enough.
3092 (get_doc_string):
3093 Use SAFE_ALLOCA, not alloca.
3094 Check for overflow when converting EMACS_INT to off_t.
3095 * doprnt.c (doprnt):
3096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3097 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3098 Don't assume uid_t fits into fixnum.
3099 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3100 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3101 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3102 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3103 (general_insert_function)
3104 (Finsert_char, make_buffer_string, make_buffer_string_both)
3105 (update_buffer_properties, Fbuffer_substring)
3106 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3107 (Fsubst_char_in_region, check_translation)
3108 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3109 (transpose_markers, Ftranspose_regions):
3110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3111 (clip_to_bounds): Move to lisp.h as an inline function).
3112 (Fconstrain_to_field): Don't assume integers are nonnegative.
3113 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3114 (Fsubst_char_in_region, Fsave_restriction):
3115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3116 (Femacs_pid): Don't assume pid_t fits into fixnum.
3117 (lo_time): Use int, not EMACS_INT, when int suffices.
3118 (lisp_time_argument): Check for usec out of range.
3119 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3120 (Fuser_login_name, Fuser_full_name): Signal an error
3121 if a uid argument is out of range, rather than relying on
3122 undefined behavior.
c8d5c857
PE
3123 (Fformat_time_string): Remove now-unnecessary check.
3124 lisp_time_argument checks for out-of-range usec now.
243e0530 3125 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3126 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3127 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3128 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3129 (init_cmdargs, Fdump_emacs):
3130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3131 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3132 the bottom (typically) 32 bits of the fixnum.
3133 * eval.c (specpdl_size, call_debugger):
3134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3135 (when_entered_debugger, Fbacktrace_debug):
3136 Don't assume fixnum can fit in int.
3137 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3138 the object just before a buffer; this is not portable.
3139 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3140 (grow_specpdl, unbind_to):
3141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3142 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3143 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3144 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3145 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3146 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3148 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3149 (a_write, e_write):
3150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3151 (Fcopy_file, non_regular_nbytes, read_non_regular)
3152 (Finsert_file_contents):
3153 Use int, not EMACS_INT, where int is wide enough.
3154 (READ_BUF_SIZE): Verify that it fits in int.
3155 (Finsert_file_contents): Check that counts are in proper range,
3156 rather than assuming fixnums fit into ptrdiff_t etc.
3157 Don't assume fixnums fit into int.
125b3835 3158 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3159 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3160 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3161 (string_char_to_byte, string_byte_to_char)
3162 (string_make_multibyte, string_to_multibyte)
3163 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3164 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3165 (substring_both, Fdelete, internal_equal, Ffillarray)
3166 (Fclear_string, mapcar1)
3167 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3168 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3169 (larger_vector, make_hash_table, maybe_resize_hash_table)
3170 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3171 (Fmaphash, secure_hash):
3172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3173 (concat): Check for string index and length overflow.
3174 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3175 (Frequire):
3176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3177 (larger_vector): New API (vec, incr_min, size_max) replaces old
3178 one (vec, new_size, init). This catches size overflow.
3179 INIT was removed because it was always Qnil.
3180 All callers changed.
3181 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3182 the upper bound on a hash table index size.
3183 (make_hash_table, maybe_resize_hash_table): Use it.
3184 (secure_hash): Computer start_byte and end_byte only after
3185 they're known to be in ptrdiff_t range.
3186 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3187 (Ffont_get_glyphs, Ffont_at):
3188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3189 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3190 (Flist_fonts, Fopen_font):
3191 Don't assume fixnum can fit in int.
3192 (check_gstring): Don't assume index can fit in int.
3193 (font_match_p): Check that fixnum is a character, not a nonnegative
3194 fixnum, since the later code needs to stuff it into an int.
3195 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3196 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3197 conversion overflow issues.
3198 (Fopen_font): Check for integer out of range.
3199 (Ffont_get_glyphs): Don't assume index can fit in int.
3200 * font.h: Adjust decls to match defn changes elsewhere.
3201 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3202 integer overflow.
3203 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3204 printmax_t, where ptrdiff_t is wide enough.
3205 (Finternal_char_font):
3206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3207 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3208 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3209 (Fset_frame_position, x_set_frame_parameters)
3210 (x_set_line_spacing, x_set_border_width)
3211 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3212 Check that fixnums are in proper range for system types.
3213 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3215 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3216 Use SAFE_ALLOCA_LISP, not alloca.
3217 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3218 intptr_t is wide enough.
3219 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3220 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3221 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3222 Check for fixnum out of range.
3223 * ftfont.c (ftfont_list): Don't assume index fits in int.
3224 Check that fixnums are in proper range for system types.
3225 (ftfont_shape_by_flt):
3226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3227 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3229 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3230 Check that fixnums are in proper range for system types.
3231 * gnutls.h: Adjust decls to match defn changes elsewhere.
3232 * gtkutil.c (xg_dialog_run):
3233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3234 (update_frame_tool_bar):
3235 Check that fixnums are in proper range for system types.
3236 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3237 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3238 * indent.c (last_known_column, last_known_column_point):
3239 (current_column_bol_cache):
3240 (skip_invisible, current_column, check_display_width):
3241 (check_display_width, scan_for_column, current_column_1)
3242 (Findent_to, Fcurrent_indentation, position_indentation)
3243 (indented_beyond_p, Fmove_to_column, compute_motion):
3244 (Fcompute_motion, Fvertical_motion):
3245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3246 (last_known_column_modified): Use EMACS_INT, not int.
3247 (check_display_width):
3248 (Fcompute_motion):
3249 Check that fixnums and floats are in proper range for system types.
3250 (compute_motion): Don't assume index or fixnum fits in int.
3251 (compute_motion, Fcompute_motion):
3252 Use int, not EMACS_INT, when it is wide enough.
3253 (vmotion): Omit local var start_hpos that is always 0; that way
3254 we don't need to worry about overflow in expressions involving it.
3255 * indent.h: Adjust decls to match defn changes elsewhere.
3256 (struct position):
3257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3258 Use int, not EMACS_INT, where int is wide enough.
3259 Remove unused members ovstring_chars_done and tab_offset;
3260 all uses removed.
3261 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3262 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3263 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3264 (make_gap, copy_text, insert, insert_and_inherit)
3265 (insert_before_markers, insert_before_markers_and_inherit)
3266 (insert_1, count_combining_before, count_combining_after)
3267 (insert_1_both, insert_from_string)
3268 (insert_from_string_before_markers, insert_from_string_1)
3269 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3270 (adjust_after_replace, adjust_after_insert, replace_range)
3271 (replace_range_2, del_range, del_range_1, del_range_byte)
3272 (del_range_both, del_range_2, modify_region)
3273 (prepare_to_modify_buffer, signal_before_change)
3274 (signal_after_change, Fcombine_after_change_execute):
3275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3276 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3277 (balance_an_interval, split_interval_right, split_interval_left)
3278 (find_interval, next_interval, update_interval)
3279 (adjust_intervals_for_insertion, delete_node, delete_interval)
3280 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3281 (static_offset_intervals, offset_intervals)
3282 (merge_interval_right, merge_interval_left, make_new_interval)
3283 (graft_intervals_into_buffer, temp_set_point_both)
3284 (temp_set_point, set_point, adjust_for_invis_intang)
3285 (set_point_both, move_if_not_intangible, get_property_and_range)
3286 (get_local_map, copy_intervals, copy_intervals_to_string)
3287 (compare_string_intervals, set_intervals_multibyte_1):
3288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3289 * intervals.h: Adjust decls to match defn changes elsewhere.
3290 (struct interval):
3291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3292 * keyboard.c (this_command_key_count, this_single_command_key_start)
3293 (before_command_key_count, before_command_echo_length, echo_now)
3294 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3295 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3296 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3297 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3299 (last_non_minibuf_size, last_point_position, echo_truncate)
3300 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3301 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3302 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3303 (stuff_buffered_input):
3304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3305 (last_auto_save, command_loop_1, read_char):
3306 Use EMACS_INT, not int, to avoid integer overflow.
3307 (record_char): Avoid overflow in total_keys computation.
3308 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3309 * keyboard.h: Adjust decls to match defn changes elsewhere.
3310 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3311 (Fkey_description, Fdescribe_vector, Flookup_key):
3312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3313 (click_position): New function, to check that positions are in range.
3314 (Fcurrent_active_maps):
3315 (describe_command):
3316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3317 (Faccessible_keymaps, Fkey_description):
3318 (preferred_sequence_p):
3319 Don't assume fixnum can fit into int.
3320 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3321 Check for integer overflow in size calculations.
3322 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3323 avoid mishandling large integers.
3324 * lisp.h: Adjust decls to match defn changes elsewhere.
3325 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3326 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3327 (struct Lisp_Marker):
3328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3329 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3330 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3331 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3332 All callers changed.
3333 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3334 Assume the arg has valid form, since it always does.
3335 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3336 unsigned integer system type.
3337 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3338 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3340 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3341 (duration_to_sec_usec): New decl.
3342 * lread.c (read_from_string_index, read_from_string_index_byte)
3343 (read_from_string_limit, readchar, unreadchar, openp)
3344 (read_internal_start, read1, oblookup):
3345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3346 (Fload, readevalloop, Feval_buffer, Feval_region):
3347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3348 (openp): Check for out-of-range argument to 'access'.
3349 (read1): Use int, not EMACS_INT, where int is wide enough.
3350 Don't assume fixnum fits into int.
6efdadfd 3351 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3352 (read_filtered_event): Use duration_to_sec_usec
3353 to do proper overflow checking on durations.
d311d28c
PE
3354 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3355 in size calculation.
3356 (Fexecute_kbd_macro):
3357 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3358 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3359 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3360 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3361 (set_marker_both, set_marker_restricted_both, marker_position)
3362 (marker_byte_position, Fbuffer_has_markers_at):
3363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3364 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3365 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3366 It now merely ensures that the menu is large enough, without
3367 necessarily growing it, as this avoids some integer overflow issues.
3368 All callers changed.
3369 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3371 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3372 Use SAFE_ALLOCA_LISP, not alloca.
3373 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3374 to EMACS_INT. Check that fixnums are in proper range for system types.
3375 * minibuf.c (minibuf_prompt_width, string_to_object)
3376 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3377 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3379 (get_minibuffer, read_minibuf_unwind):
3380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3381 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3382 this simplifies overflow checking. All callers changed.
3383 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3384 (Ftest_completion):
3385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3387 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3388 Check that fixnums are in proper range for system types.
3389 (Fx_create_frame, Fx_show_tip):
3390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3391 * nsfont.m (ns_findfonts, nsfont_list_family):
3392 Don't assume fixnum fits in long.
3393 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3395 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3396 wide enough.
17fdb222 3397 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3399 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3400 (PRINTDECLARE, PRINTPREPARE):
3401 (strout, print_string):
3402 (print, print_preprocess, print_check_string_charset_prop)
3403 (print_object):
3404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3405 (PRINTDECLARE):
3406 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3408 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3409 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3410 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3411 (print_error_message): Use SAFE_ALLOCA, not alloca.
3412 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3413 (print_depth, new_backquote_output, print_number_index):
3414 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3415 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3416 (Fset_process_window_size, Fformat_network_address)
3417 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3418 (sigchld_handler):
d311d28c 3419 Check that fixnums are in proper range for system types.
d44287d4 3420 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3421 Check for process-ids out of pid_t range rather than relying on
3422 undefined behavior.
e4d81efc 3423 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3424 (Fformat_network_address, read_process_output, send_process)
3425 (Fprocess_send_region, status_notify):
3426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3427 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3428 (wait_reading_process_output, read_process_output, exec_sentinel):
3429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3430 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3431 (Faccept_process_output): Use duration_to_sec_usec to do proper
3432 overflow checking on durations.
dde14581
PE
3433 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3434 Don't assume pid_t fits in int.
02481186
PE
3435 * process.h (struct Lisp_Process): Members tick and update_tick
3436 are now of type EMACS_INT, not int.
b62b53e8
PE
3437 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3438 configured --with-wide-int.
d311d28c
PE
3439 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3440 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3441 * search.c (looking_at_1, string_match_1):
3442 (fast_string_match, fast_c_string_match_ignore_case)
3443 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3444 (scan_newline, find_before_next_newline, search_command)
3445 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3446 (set_search_regs, wordify):
3447 (Freplace_match):
3448 (Fmatch_data):
3449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3450 (string_match_1, search_buffer, set_search_regs):
3451 (Fmatch_data):
3452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3453 (wordify): Check for overflow in size calculation.
3454 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3455 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3456 Check that fixnums are in proper range for system types.
3457 * sound.c (struct sound_device)
3458 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3460 (Fplay_sound_internal):
3461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3462 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3463 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3464 (Fparse_partial_sexp):
3465 Don't assume fixnums can fit in int.
3466 (struct lisp_parse_state, find_start_pos, find_start_value)
3467 (find_start_value_byte, find_start_begv)
3468 (update_syntax_table, char_quoted, dec_bytepos)
3469 (find_defun_start, prev_char_comend_first, back_comment):
3470 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3471 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3473 (Finternal_describe_syntax_value): Check that match_lisp is a
3474 character, not an integer, since the code stuffs it into int.
3475 (scan_words, scan_sexps_forward):
3476 Check that fixnums are in proper range for system types.
3477 (Fforward_word):
3478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3479 (scan_sexps_forward):
3480 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3481 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3482 * syntax.h: Adjust decls to match defn changes elsewhere.
3483 (struct gl_state_s):
3484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3485 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3486 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3487 * sysdep.c (wait_for_termination_1, wait_for_termination)
3488 (interruptible_wait_for_termination, mkdir):
3489 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3490 (emacs_read, emacs_write):
3491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3492 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3493 and double all fit in int.
d311d28c
PE
3494 * term.c (set_tty_color_mode):
3495 Check that fixnums are in proper range for system types.
3496 * termhooks.h (struct input_event):
3497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3498 * textprop.c (validate_interval_range, interval_of)
3499 (Fadd_text_properties, set_text_properties_1)
3500 (Fremove_text_properties, Fremove_list_of_text_properties)
3501 (Ftext_property_any, Ftext_property_not_all)
3502 (copy_text_properties, text_property_list, extend_property_ranges)
3503 (verify_interval_modification):
3504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3505 (Fnext_single_char_property_change)
3506 (Fprevious_single_char_property_change):
3507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3508 (copy_text_properties):
3509 Check for integer overflow in index calculation.
d311d28c
PE
3510 * undo.c (last_boundary_position, record_point, record_insert)
3511 (record_delete, record_marker_adjustment, record_change)
3512 (record_property_change):
3513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3514 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3516 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3517 (Fx_hide_tip, Fx_file_dialog):
3518 * w32menu.c (set_frame_menubar):
3519 Use ptrdiff_t, not int, for consistency with rest of code.
3520 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3521 (select_window, Fdelete_other_windows_internal)
3522 (window_scroll_pixel_based, window_scroll_line_based)
3523 (Frecenter, Fset_window_configuration):
3524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3525 (Fset_window_hscroll, run_window_configuration_change_hook)
3526 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3527 (Fscroll_other_window, Frecenter):
d311d28c
PE
3528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3529 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3530 Don't assume fixnum fits in int.
3531 (Fset_window_scroll_bars):
3532 Check that fixnums are in proper range for system types.
3533 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3534 (string_pos, c_string_pos, number_of_chars, init_iterator)
3535 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3536 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3537 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3538 (face_before_or_after_it_pos, handle_invisible_prop)
3539 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3540 (display_prop_intangible_p, string_buffer_position_lim)
3541 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3542 (get_overlay_strings_1, get_overlay_strings)
3543 (iterate_out_of_display_property, forward_to_next_line_start)
3544 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3545 (get_next_display_element, set_iterator_to_next)
3546 (get_visually_first_element, compute_stop_pos_backwards)
3547 (handle_stop_backwards, next_element_from_buffer)
3548 (move_it_in_display_line_to, move_it_in_display_line)
3549 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3550 (add_to_log, message_dolog, message_log_check_duplicate)
3551 (message2, message2_nolog, message3, message3_nolog
3552 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3553 (current_message_1, truncate_echo_area, truncate_message_1)
3554 (set_message, set_message_1, store_mode_line_noprop)
3555 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3556 (text_outside_line_unchanged_p, check_point_in_composition)
3557 (reconsider_clip_changes)
3558 (redisplay_internal, set_cursor_from_row, try_scrolling)
3559 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3560 (redisplay_window, find_last_unchanged_at_beg_row)
3561 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3562 (trailing_whitespace_p, find_row_edges, display_line)
3563 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3564 (display_mode_element, store_mode_line_string)
3565 (pint2str, pint2hrstr, decode_mode_spec)
3566 (display_count_lines, display_string, draw_glyphs)
3567 (x_produce_glyphs, x_insert_glyphs)
3568 (rows_from_pos_range, mouse_face_from_buffer_pos)
3569 (fast_find_string_pos, mouse_face_from_string_pos)
3570 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3572 (safe_call, init_from_display_pos, handle_fontified_prop)
3573 (handle_single_display_spec, load_overlay_strings)
3574 (with_echo_area_buffer, setup_echo_area_for_printing)
3575 (display_echo_area, echo_area_display)
3576 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3577 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3578 (redisplay_window, dump_glyph_row, display_mode_line)
3579 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3580 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3582 (handle_single_display_spec, build_desired_tool_bar_string)
3583 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3584 (get_specified_cursor_type):
3585 Check that fixnums are in proper range for system types.
3586 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3587 (Flookup_image_map):
3588 Don't assume fixnums fit in int.
3589 (compare_overlay_entries):
3590 Avoid mishandling comparisons due to subtraction overflow.
3591 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3592 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3593 (handle_tool_bar_click):
3594 Use int, not unsigned, since we prefer signed and the signedness
3595 doesn't matter here.
3596 (get_next_display_element, next_element_from_display_vector):
3597 Use int, not EMACS_INT, when int is wide enough.
3598 (start_hourglass): Use duration_to_sec_usec to do proper
3599 overflow checking on durations.
3600 * xfaces.c (Fbitmap_spec_p):
3601 Check that fixnums are in proper range for system types.
3602 (compare_fonts_by_sort_order):
3603 Avoid mishandling comparisons due to subtraction overflow.
3604 (Fx_family_fonts, realize_basic_faces):
3605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3606 (Fx_family_fonts):
3607 Don't assume fixnum fits in int.
3608 Use SAFE_ALLOCA_LISP, not alloca.
3609 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3610 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3611 (face_at_buffer_position, face_for_overlay_string)
3612 (face_at_string_position):
3613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3614 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3615 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3616 (Fx_show_tip):
3617 Check that fixnums are in proper range for system types.
3618 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3619 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3621 (Fx_change_window_property): Don't assume fixnums fit in int.
3622 * xfont.c (xfont_chars_supported):
3623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3624 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3625 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3627 * xml.c (parse_region):
3628 * xrdb.c (magic_file_p):
3629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3630 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3631 (x_get_local_selection, x_reply_selection_request)
3632 (x_handle_selection_request, wait_for_property_change):
3633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3634 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3635 short is wide enough.
3636 (x_send_client_event): Don't assume fixnum fits in int.
3637 * xterm.c (x_x_to_emacs_modifiers):
3638 Don't assume EMACS_INT overflows nicely into int.
3639 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3640 may come from Lisp.
3641 (handle_one_xevent): NATNUMP can eval its arg twice.
3642 (x_connection_closed):
3643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3644 * xterm.h: Adjust decls to match defn changes elsewhere.
3645 (struct scroll_bar): Use struct vectorlike_header
3646 rather than rolling our own approximation.
3647 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3648
c6574eb5
GM
36492012-05-25 Glenn Morris <rgm@gnu.org>
3650
3651 * lisp.mk (lisp): Update for more files being compiled now.
3652
e8d32c7e
SM
36532012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3654
48def666
SM
3655 * lread.c: Remove `read_pure' which makes no difference.
3656 (read_pure): Remove var.
3657 (unreadpure): Remove function.
3658 (readevalloop): Don't call read_list with -1 flag.
3659 (read1, read_vector): Don't test read_pure any more.
3660 (read_list): Simplify.
3661
e8d32c7e
SM
3662 * fileio.c, character.h: Minor style tweaks.
3663
4b2addb7
DA
36642012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3665
3666 * window.h (clip_changed): Remove useless declaration.
3667
584461b2
JB
36682012-05-22 Juanma Barranquero <lekktu@gmail.com>
3669
3670 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3671 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3672
34374650
PE
36732012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3674
3675 Remove src/m/*.
3676 This directory predates autoconf and is no longer needed nowadays.
3677 Move its few remaining bits of functionality to where they're needed.
3678 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3679 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3680 * m/template.h: Remove.
3681 * Makefile.in (M_FILE): Remove. All uses removed.
3682 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3683 * lisp.h (USE_LSB_TAG):
3684 * mem-limits.h (EXCEEDS_LISP_PTR):
3685 Use VAL_MAX, not VALBITS, in #if.
3686 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3687 (EMACS_UINT): Define unconditionally now.
3688 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3689 (BITS_PER_EMACS_INT): New constants, replacing
3690 what used to be in config.h, but not useful in #if.
3691 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3692 define them any more.
3693 (VAL_MAX): New macro.
3694 (VALMASK): Use it.
3695 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3696 BITS_PER_EMACS_INT, in #if.
3697 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3698 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3699 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3700 * s/ms-w32.h (DATA_START):
3701 Move here from removed file m/intel386.h.
3702 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3703 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3704
261cb4bb
PE
37052012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 Assume C89 or later.
3708 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3709 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3710 (xrealloc):
3711 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3712 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3713 * textprop.c, tparam.c (NULL): Remove.
3714 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3715 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3716 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3717 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3718 * xterm.c (input_signal_count): Assume volatile works.
3719
ff23cd9f
KB
37202012-05-21 Ken Brown <kbrown@cornell.edu>
3721
3722 * xgselect.c (xg_select): Fix first argument in call to 'select'
3723 (bug#11508).
3724
1b170bc6
KB
37252012-05-20 Ken Brown <kbrown@cornell.edu>
3726
3727 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3728 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3729
b2f4d39f
KB
37302012-05-19 Ken Brown <kbrown@cornell.edu>
3731
3732 * xfns.c (x_in_use): Remove `static' qualifier.
3733 * xterm.h (x_in_use): Declare.
3734 * xgselect.c: Include xterm.h.
3735 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3736 and `display_arg' (bug#9754).
3737
003fdae2
PE
37382012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3739
9232a6d9
PE
3740 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3741
003fdae2
PE
3742 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3743 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3744
784b56e2
EZ
37452012-05-18 Eli Zaretskii <eliz@gnu.org>
3746
3747 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3748
3749 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3750 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3751
3752 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3753 reference to image_cache->refcount.
3754 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3755
a0a79cde
JL
37562012-05-17 Juri Linkov <juri@jurta.org>
3757
3758 * search.c (Fword_search_regexp, Fword_search_backward)
3759 (Fword_search_forward, Fword_search_backward_lax)
3760 (Fword_search_forward_lax): Move functions to isearch.el
3761 (bug#10145, bug#11381).
3762
b0572523
PE
37632012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3764
3765 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3766
9660f5fc
SM
37672012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3768
3769 * lread.c (init_obarray): Declare Qt and Qnil as special.
3770
4374de83
GM
37712012-05-14 Glenn Morris <rgm@gnu.org>
3772
3773 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3774 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3775
dc44c39a
PE
37762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3777
078c97cb
PE
3778 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3779
dc44c39a
PE
3780 * unexaix.c: Port to more-recent AIX compilers.
3781 (report_error, report_error_1, make_hdr, copy_sym)
3782 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3783 Make arguments const char *, not char *, to avoid violations of C
3784 standard and to fix some AIX warnings reported by Gilles Pion.
3785
e18afed7 37862012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3787
3788 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3789 already have overlays loaded.
3790 (handle_single_display_spec): Before returning without displaying
3791 fringe bitmap, synchronize the bidi iterator with the main display
3792 iterator, by calling iterate_out_of_display_property.
3793 (iterate_out_of_display_property): Detect buffer iteration by
3794 testing that it->string is a Lisp string.
3795 (get_next_display_element): When the current object is exhausted,
3796 and there's something on it->stack, call set_iterator_to_next to
3797 proceed with what's on the stack, instead of returning zero.
3798 (set_iterator_to_next): If called at the end of a Lisp string,
3799 proceed to consider_string_end without incrementing string
3800 position. Don't increment display vector index past the end of
3801 the display vector. (Bug#11417)
c8fb9dc6
EZ
3802 (pos_visible_p): Don't report a position visible when move_it_to
3803 stopped at the last line of window, which happens to be scanned
3804 backwards by the bidi iteration. (Bug#11464)
ac268e67 3805
e18afed7 38062012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3807
3808 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3809 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3810 are on a TTY, and thus unable to display on the fringes.
3811 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3812 so we need to signal to the caller that this is a "replacing"
3813 display spec. This fixes display when the spec is invalid or we
3814 are on a TTY.
3815
e18afed7 38162012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3817
3818 * unexaix.c (make_hdr): Fix typo in prototype.
3819 This bug broke the build on AIX. Problem reported by Gilles Pion.
3820
9d0a235a
MA
38212012-05-14 Michael Albinus <michael.albinus@gmx.de>
3822
3823 * keyboard.c (kbd_buffer_get_event): Read special events also in
3824 batch mode. (Bug#11415)
3825
9e6b06ed
GM
38262012-05-12 Glenn Morris <rgm@gnu.org>
3827
3828 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3829
c1a1d7a3
EZ
38302012-05-12 Eli Zaretskii <eliz@gnu.org>
3831
3832 * lisp.mk (lisp): Add newcomment.elc.
3833
3fe7cdc8
GM
38342012-05-12 Glenn Morris <rgm@gnu.org>
3835
3836 * Makefile.in (MKDIR_P): New, set by configure.
3837 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3838
53f7d2c0
PE
38392012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3840
3841 Remove unused function hourglass_started.
3842 * dispextern.h (hourglass_started):
3843 * w32fns.c (hourglass_started):
3844 * xdisp.c (hourglass_started): Remove.
3845
75aafb17
JB
38462012-05-10 Juanma Barranquero <lekktu@gmail.com>
3847
3848 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3849 Update dependencies.
3850
12959e8e
PE
38512012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3852
97107e2e
PE
3853 * xgselect.c (xg_select): Put maxfds+1 into a var.
3854 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3855
12959e8e
PE
3856 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3857
836d29b3
DA
38582012-05-10 Dave Abrahams <dave@boostpro.com>
3859
3860 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3861 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3862
5cb67954
MA
38632012-05-09 Michael Albinus <michael.albinus@gmx.de>
3864
3865 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3866 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3867 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3868 Initialize xd_registered_buses.
3869
3478ec45
PE
38702012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3871
b263a6b0
PE
3872 Untag more efficiently if USE_LSB_TAG.
3873 This is based on a proposal by YAMAMOTO Mitsuharu in
3874 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3875 For an admittedly artificial (nth 8000 longlist) benchmark on
3876 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3877 Emacs's overall text size by 1%.
3878 * lisp.h (XUNTAG): New macro.
3879 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3880 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3881 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3882 * eval.c (Fautoload):
3883 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3884 * frame.h (XFRAME): Use XUNTAG.
3885
3478ec45
PE
3886 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3887 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3888 Remove unportable assumptions about print widths of types like
3889 dbus_uint32_t.
3890 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3891 intptr_t when converting between pointer and integer, to avoid GCC
3892 warnings about wrong width.
3893
666b903b 38942012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3895
3896 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3897 stack for each reader_thread, instead of defaulting to 8MB
3898 determined by the linker. This avoids failures in creating
3899 subprocesses on Windows 7, see the discussion in this thread:
3900 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3901
b120cc17
JC
39022012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3903
3904 Fix up display of the *Minibuf-0* buffer in the mini window.
3905 * keyboard.c (read_char): Don't clear the echo area if there's no
3906 message to clear.
3907 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3908 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3909
9a4b36f8
MA
39102012-05-07 Michael Albinus <michael.albinus@gmx.de>
3911
3912 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3913 batch mode.
3914
e5f9458f
CY
39152012-05-06 Chong Yidong <cyd@gnu.org>
3916
3917 * lisp.mk (lisp): Update.
3918
eceeb5fc 39192012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3920
3921 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3922
71873e2b
SM
39232012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3924
3925 * data.c (PUT_ERROR): New macro.
3926 (syms_of_data): Use it. Add new error type `user-error'.
3927 * undo.c (user_error): New function.
3928 (Fprimitive_undo): Use it.
3929 * print.c (print_error_message): Adjust print style for `user-error'.
3930 * keyboard.c (user_error): New function.
3931 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3932
ab0fa4e4
PE
39332012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 Do not limit current-time-string to years 1000..9999.
3936 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3937 (Fcurrent_time_string): Support any year that is supported by the
3938 underlying localtime representation. Don't use asctime, as it
3939 has undefined behavior for years outside the range -999..9999.
3940
7ed806a7
PE
39412012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 Fix race conditions involving setenv, gmtime, localtime, asctime.
3944 Without this fix, interrupts could mess up code that uses these
3945 nonreentrant functions, since setting TZ invalidates existing
3946 tm_zone or tzname values, and since most of these functions return
3947 pointers to static storage.
3948 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3949 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3950 Grow the critical sections to include not just invoking
3951 localtime/gmtime, but also accessing these functions' results
3952 including their tm_zone values if any, and any related TZ setting.
3953 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3954 so that the struct tm is saved in the critical section.
3955 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3956 motivated by the fact that memory allocation needs to be outside
3957 the critical section.
3958
0c16dfed
DA
39592012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3960
3961 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3962 with RESET_INTERVAL.
3963
3964 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3965 Remove duplicated buffer name initialization.
3966
3f83ace8
JM
39672012-05-02 Jim Meyering <jim@meyering.net>
3968
3969 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3970
c7b8541e
JM
3971 * xfns.c (x_window): Use xstrdup (Bug#11375).
3972
90207a15 39732012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3974
3975 * xdisp.c (pos_visible_p): If already at a newline from the
3976 display string before the 'while' loop, don't walk back the glyphs
3977 from it3.glyph_row. Solves assertion violation when the display
3978 string begins with a newline (egg.el). (Bug#11367)
3979
b593d6a9
AH
39802012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3981
3982 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3983 Move to simple.el.
3984
4737362e
GM
39852012-05-01 Glenn Morris <rgm@gnu.org>
3986
99cf43f9
GM
3987 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3988 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3989 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3990 All were removed before 23.1.
3991
9311dcff
GM
3992 * dispnew.c: Remove HAVE_LIBNCURSES test;
3993 it is always true on relevant platforms.
3994
4d5c6349
GM
3995 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3996 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3997
4737362e
GM
3998 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3999
74dd3a6b
AS
40002012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4001
4002 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4003 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4004 Remove.
4005
13c379ee
PE
40062012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 Do not avoid creating empty evaporating overlays (Bug#9642).
4009 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4010 That is, do not delete an evaporating overlay if it becomes
4011 empty after its bounds are adjusted to fit within its buffer.
4012 This fix caused other problems, and I'm reverting it until we get
4013 to the bottom of them.
4014
a8e7d6d7 40152012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4016
4017 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4018
a8e7d6d7 40192012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4020
4021 * xdisp.c (pos_visible_p): If the window start position is beyond
4022 ZV, start the display from buffer beginning. Prevents assertion
4023 violation in init_iterator when the minibuffer window is scrolled
4024 via the scroll bar.
4025
4026 * window.c (window_scroll_pixel_based): Likewise.
4027
a8e7d6d7 40282012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4029
4030 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4031
a8e7d6d7 40322012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4033
4034 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4035 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4036
a8e7d6d7 40372012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4038
b593d6a9
AH
4039 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4040 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4041
1c6900d9
EZ
40422012-04-26 Eli Zaretskii <eliz@gnu.org>
4043
4c3fa1d9
EZ
4044 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4045 display element, check also the underlying string or buffer
4046 character. (Bug#11341)
4047
1c6900d9
EZ
4048 * w32menu.c: Include w32heap.h.
4049 (add_menu_item): If the call to AppendMenuW (via
4050 unicode_append_menu) fails, disable Unicode menus only if we are
4051 running on Windows 9X/Me.
4052
42bf8205
AS
40532012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4054
4055 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4056 (xgetint): Add missing shift for LSB tags.
4057
b1bac16e
MR
40582012-04-24 Martin Rudalics <rudalics@gmx.at>
4059
4060 * keyboard.c (read_char): Don't wipe echo area for select window
4061 events: These might get delayed via `mouse-autoselect-window'
4062 (Bug#11304).
4063
d69621cc
JB
40642012-04-24 Juanma Barranquero <lekktu@gmail.com>
4065
4066 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4067 manipulation of :loaded-from data.
4068
02fd101b
JB
40692012-04-23 Juanma Barranquero <lekktu@gmail.com>
4070
4071 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4072 now a cons (bug#11311).
4073
888bec30
PE
40742012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4075
89a438bd
PE
4076 Do not create empty overlays with the evaporate property (Bug#9642).
4077 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4078 if it becomes empty after its bounds are adjusted to fit within
4079 its buffer. Without this fix, in a nonempty buffer (let ((o
4080 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4081 yields an empty overlay that has the evaporate property, which is
4082 not supposed to happen.
4083
1068fe4d
PE
4084 Fix minor GTK3 problems found by static checking.
4085 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4086 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4087 (struct _EmacsFixedClass, emacs_fixed_get_type):
4088 Move decls here from emacsgtkfixed.h, since they needn't be public.
4089 (emacs_fixed_get_type): Now static.
4090 (emacs_fixed_class_init): Omit unused local.
4091 (emacs_fixed_child_type): Remove; unused.
4092 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4093 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4094 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4095 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4096 (EMACS_FIXED_GET_CLASS): Remove; unused.
4097 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4098
888bec30
PE
4099 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4100 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4101
de85e130
PE
41022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4103
d0baac98 4104 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4105 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4106 (__malloc_size_t, __malloc_ptrdiff_t):
4107 Remove. All uses removed, replaced by the definiens if needed,
4108 since we can assume C89 or better now.
4109 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4110 (protect_malloc_state, align, get_contiguous_space)
4111 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4112 (malloc_atfork_handler_child, malloc_enable_thread)
4113 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4114 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4115 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4116 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4117 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4118 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4119 Define using prototypes, not old style.
4120 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4121 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4122 (align): Don't assume that signed integer overflow wraps around.
4123 Omit unused local var.
4124 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4125 (_free_internal_nolock, memalign, mallochook, reallochook):
4126 Omit no-longer-needed casts.
4127 (valloc): Use getpagesize, not __getpagesize.
4128 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4129 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4130
de85e130
PE
4131 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4132
dcbf5805
MA
41332012-04-22 Michael Albinus <michael.albinus@gmx.de>
4134
4135 Move functions from C to Lisp. Make non-blocking method calls
4136 the default. Implement further D-Bus standard interfaces.
4137
4138 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4139 (QCdbus_request_name_allow_replacement)
4140 (QCdbus_request_name_replace_existing)
4141 (QCdbus_request_name_do_not_queue)
4142 (QCdbus_request_name_reply_primary_owner)
4143 (QCdbus_request_name_reply_in_queue)
4144 (QCdbus_request_name_reply_exists)
4145 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4146 (QCdbus_registered_serial, QCdbus_registered_method)
4147 (QCdbus_registered_signal): New Lisp objects.
4148 (XD_DEBUG_MESSAGE): Use sizeof.
4149 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4150 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4151 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4152 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4153 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4154 (xd_signature, xd_append_arg): Allow float for integer types.
4155 (xd_get_connection_references): New function.
b593d6a9
AH
4156 (xd_get_connection_address): Rename from xd_initialize.
4157 Return cached address.
dcbf5805
MA
4158 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4159 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4160 level.
4161 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4162 Return number of refcounts.
dcbf5805
MA
4163 (Fdbus_get_unique_name): Make stronger parameter check.
4164 (Fdbus_message_internal): New defun.
4165 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4166 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4167 (Fdbus_send_signal, Fdbus_register_service)
4168 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4169 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4170 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4171 (Vdbus_compiled_version, Vdbus_runtime_version)
4172 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4173 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4174 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4175 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4176 Adapt docstring.
dcbf5805 4177
52828e02
PE
41782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4179
da05bc4c
PE
4180 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4181 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4182 Do not assume ptrdiff_t is the same width as 'int'.
4183
52828e02
PE
4184 * alloc.c: Handle unusual debugging option combinations.
4185 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4186 since the two debugging options are incompatible.
4187 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4188 is defined.
4189 (mem_init, mem_insert, mem_insert_fixup):
4190 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4191 (NEED_MEM_INSERT): Remove; no longer needed.
4192
f01769f9
LL
41932012-04-22 Leo Liu <sdl.web@gmail.com>
4194
4195 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4196
5790543d
PE
41972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 * sysdep.c [__FreeBSD__]: Minor cleanups.
4200 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4201 Use Emacs indenting style more consistently. Avoid some casts.
4202 Use 'double' consistently rather than mixing 'float' and 'double'.
4203
b91b7e4d
EW
42042012-04-21 Eduard Wiebe <usenet@pusto.de>
4205
b593d6a9
AH
4206 * sysdep.c (list_system_processes, system_process_attributes):
4207 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4208
6114eb15
AS
42092012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4210
4211 * lisp.mk (lisp): Update.
4212
2f38dff7
PE
42132012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4214
4215 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4216 It is never used otherwise.
4217
4ae29f89
SM
42182012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4219
4220 * print.c (print_preprocess): Only check print_depth if print-circle
4221 is nil.
4222 (print_object): Check for cycles even when print-circle is nil and
4223 print-gensym is t, but only check print_depth if print-circle is nil.
4224
f30d612a
CY
42252012-04-20 Chong Yidong <cyd@gnu.org>
4226
4227 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4228 set the status to "failed" and ensure that sentinel is run.
4229
c07a4c0b 42302012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4231
4232 * process.c (Fset_process_inherit_coding_system_flag)
4233 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4234 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4235
c07a4c0b 42362012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4237
4238 * xdisp.c (string_buffer_position_lim): Limit starting position to
4239 BEGV.
4240 (set_cursor_from_row): If called for a mode-line or header-line
4241 row, return zero immediately.
4242 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4243 farther than the first row after the header line, if any.
4244 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4245 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4246
c07a4c0b 42472012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4248
4ae29f89
SM
4249 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4250 (bug#11238).
ad3a2b41 4251
c07a4c0b 42522012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 42532012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4254
4255 configure: new option --enable-gcc-warnings (Bug#11207)
4256 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4257 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4258 (ALL_CFLAGS): Use new macros rather than old.
4259 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4260 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4261 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4262 -Wunused-result, -Wunused-variable. This should go away once
4263 the Emacs and Gnulib regex code is merged.
4264 (xmalloc, xrealloc): Now static.
4265
aba027e8
PE
42662012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4267
4268 * dired.c (Fsystem_groups): Remove unused local.
4269
e5a36063
GM
42702012-04-17 Glenn Morris <rgm@gnu.org>
4271
4272 * dired.c (Fsystem_users): Doc fix.
4273
316411f0
DA
42742012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4275
4276 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4277 (syms_of_dired): Add them.
4278
9426aba4
PE
42792012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4280
b62a57be
PE
4281 Fix minor alloc.c problems found by static checking.
4282 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4283 New extern decls, to avoid calling undeclared functions.
4284 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4285 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4286 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4287 (NEED_MEM_INSERT): New macro.
4288 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4289 Remove one incorrect comment and fix another.
b62a57be 4290
3539f31f
PE
4291 Fix minor ralloc.c problems found by static checking.
4292 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4293 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4294 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4295 (r_alloc_sbrk): Now static.
4296
a041960a
PE
4297 Improve ralloc.c interface checking.
4298 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4299 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4300 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4301 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4302 [REL_ALLOC]: ... to here, to check interface.
4303 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4304 Remove decls. This fixes an "It stinks!".
4305
9426aba4
PE
4306 * alloc.c (which_symbols): Fix alignment issue / type clash.
4307
d55c12ed
AS
43082012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4309
4310 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4311 (struct Lisp_Misc_Any): Likewise.
4312 (struct Lisp_Free): Likewise.
4313 * alloc.c (union aligned_Lisp_Symbol): Define.
4314 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4315 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4316 (union aligned_Lisp_Misc): Define.
4317 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4318 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4319 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4320
b948ce8b
PE
43212012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4322
4323 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4324 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4325 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4326 * s/netbsd.h, s/sol2-6.h:
4327 Remove definition of GC_MARK_STACK, since the default now works.
4328 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4329 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4330 no longer the default.
4331 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4332
35dc09a1 43332012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4334
35dc09a1
GM
4335 * lread.c (lisp_file_lexically_bound_p):
4336 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4337
35dc09a1
GM
43382012-04-14 Eli Zaretskii <eliz@gnu.org>
4339
4340 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4341 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4342
43432012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4344
4345 * nsterm.m (constrainFrameRect): Always constrain when there is only
4346 one screen (Bug#10962).
4347
bcd86815
KB
43482012-04-13 Ken Brown <kbrown@cornell.edu>
4349
4350 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4351
c25df26e
RT
43522012-04-13 Reuben Thomas <rrt@sc3d.org>
4353
4354 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4355
0fc59f1e
DC
43562012-04-11 Daniel Colascione <dancol@dancol.org>
4357
4358 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4359 against is gone. It's better to use vfork now so that when Cygwin
4360 gains a new, working vfork, we use it automatically (bug#10398).
4361
de8c03dc
SM
43622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4363
4364 * window.c (save_window_save): Obey window-point-insertion-type.
4365
2f097256
GM
43662012-04-11 Glenn Morris <rgm@gnu.org>
4367
4368 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4369
453b951e
SM
43702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4371
4372 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4373
75f1671a 43742012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4375
4376 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4377 (force_quit_count): New var.
4378 (handle_interrupt): Use it.
4379
2a8ce227
JB
43802012-04-10 Juanma Barranquero <lekktu@gmail.com>
4381
4382 * w32.c (w32_delayed_load): Record the full path of the library
4383 being loaded (bug#10424).
4384
935396c0
GM
43852012-04-09 Glenn Morris <rgm@gnu.org>
4386
05920a43
GM
4387 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4388 not just in the obarray, before snarfing them. (Bug#11036)
4389
935396c0
GM
4390 * Makefile.in ($(leimdir)/leim-list.el):
4391 Pass EMACS rather than BUILT_EMACS.
4392
a18ecafa
TZ
43932012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4394
4395 * process.c (make_process):
4396 * process.h: Add integer `gnutls_handshakes_tried' member to
4397 process struct.
4398
6bbef4e5
JC
4399 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4400 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4401
4402 * gnutls.c (gnutls_log_function2i): Convenience log function.
4403 (emacs_gnutls_read): Use new log functions,
4404 `gnutls_handshakes_tried' process member, and
4405 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4406 attempts per process (connection).
4407
b4d3bc10
CY
44082012-04-09 Chong Yidong <cyd@gnu.org>
4409
4410 * eval.c (Fuser_variable_p, user_variable_p_eh)
4411 (lisp_indirect_variable): Functions deleted.
4412 (Fdefvar): Caller changed.
4413
4414 * callint.c (Finteractive, Fcall_interactively):
4415 * minibuf.c (Fread_variable): Callers changed.
4416
70f4d973
EZ
44172012-04-09 Eli Zaretskii <eliz@gnu.org>
4418
4419 * xdisp.c (set_cursor_from_row): If the display string appears in
4420 the buffer at position that is closer to point than the position
4421 after the display string, display the cursor on the first glyph of
4422 the display string. Fixes cursor display when a 'display' text
4423 property immediately follows invisible text. (Bug#11094)
4424
cb3c2e3e
PE
44252012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4426
4427 composite.c: use 'double' consistently
4428 * composite.c (get_composition_id): Use 'double' consistently
4429 instead of converting 'float' to 'double' and vice versa; this is
4430 easier to understand and avoids a GCC warning.
4431
fd06db5d
GM
44322012-04-09 Glenn Morris <rgm@gnu.org>
4433
50fe702a
GM
4434 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4435 preparation for dumping it with emacs. (Bug#4789)
4436 (leimdir): New variable.
4437 ($(leimdir)/leim-list.el): New rule.
4438 (emacs$(EXEEXT)): Depend on leim-list.el.
4439
fd06db5d
GM
4440 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4441 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4442 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4443
55c131ee
AS
44442012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4445
4446 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4447 proper alignment.
4448
9209588f
JB
44492012-04-07 Juanma Barranquero <lekktu@gmail.com>
4450
4451 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4452 Remove unused local variable.
4453
e3fb2efb
PE
44542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4455
4456 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4457 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4458 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4459 objects, as mark_maybe_pointer will catch them otherwise.
4460 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4461 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4462
b5385551
PE
44632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 Fix typo that broke non-Windows builds.
4466 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4467
9078ead6
EZ
44682012-04-07 Eli Zaretskii <eliz@gnu.org>
4469
4470 Support building on MS-Windows with libxml2.
4471
4472 * makefile.w32-in (OBJ2): Add xml.$(O).
4473 (GLOBAL_SOURCES): Add xml.c.
4474 ($(BLD)/xml.$(O)): New dependency list.
4475
4476 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4477 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4478 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4479 [!WINDOWSNT]: New macros.
4480 (init_libxml2_functions, libxml2_loaded_p): New functions.
4481 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4482 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4483 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4484 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4485 linked in).
6bbef4e5
JC
4486 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4487 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4488 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4489
4490 * emacs.c: Don't include libxml/parser.h.
4491 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4492 xmlCleanupParser directly.
4493
4494 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4495
3811fdf3
EZ
44962012-04-07 Eli Zaretskii <eliz@gnu.org>
4497
4498 * indent.c (Fvertical_motion): If there is a display string at
4499 point, use it.vpos to compute how many lines to backtrack after
4500 move_it_to point. (Bug#11133)
4501
2f8e16b2
EZ
45022012-04-06 Eli Zaretskii <eliz@gnu.org>
4503
4504 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4505 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4506 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4507 macros related to unification of CJK characters. For the details,
4508 see the discussion following the message here:
4509 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4510
3d439cd1
CY
45112012-04-04 Chong Yidong <cyd@gnu.org>
4512
4513 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4514
8bc53d00
EZ
45152012-04-01 Eli Zaretskii <eliz@gnu.org>
4516
4517 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4518 instead of alloca. (Bug#11138)
4519
3b0512a3
AS
45202012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4521
4522 * w32menu.c (is_simple_dialog): Properly check lisp types.
4523 (Bug#11141)
4524
8427ddd2
EZ
45252012-03-31 Eli Zaretskii <eliz@gnu.org>
4526
979022ef
EZ
4527 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4528 position we get to after a call to move_it_to fails the
4529 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4530 only if we wind up in a string from display property. (Bug#11063)
4531
a6b1c7cc
EZ
4532 * window.c (Fdelete_other_windows_internal): Invalidate the row
4533 and column information about mouse highlight, so that redisplay
4534 restores it after reallocating the glyph matrices. (Bug#7464)
4535
8427ddd2
EZ
4536 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4537 string comes from a `display' text property, use the buffer
4538 position of that property as if we actually saw that position in
4539 the row's glyphs.
697ba24b
EZ
4540 (move_it_by_lines): Remove the assertion that
4541 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4542 violated when there's a before-string at the beginning of a line.
4543 (Bug#11063)
8427ddd2 4544
65a0a738
EZ
45452012-03-30 Eli Zaretskii <eliz@gnu.org>
4546
4547 * xdisp.c (append_space_for_newline): If the default face was
4548 remapped, use the remapped face for the appended newline.
4549 (extend_face_to_end_of_line): Use the remapped default face for
4550 extending the face to the end of the line.
4551 (display_line): Call extend_face_to_end_of_line when the default
4552 face was remapped. (Bug#11068)
4553
581355cc
EZ
45542012-03-29 Eli Zaretskii <eliz@gnu.org>
4555
4556 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4557
e8fc049f
SM
45582012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4559
4560 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4561
4fb9a543
GM
45622012-03-27 Glenn Morris <rgm@gnu.org>
4563
4564 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4565 Doc fixes.
4566
679910f1
KH
45672012-03-26 Kenichi Handa <handa@m17n.org>
4568
4569 * dispextern.h (struct glyph): Fix previous change. Change the
4570 bit length of glyphless.ch to 25 (Bug#11082).
4571
90d49b7f
CY
45722012-03-26 Chong Yidong <cyd@gnu.org>
4573
4574 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4575 (command_loop_1): Use it; inhibit selection update for
4576 handle-select-window too (Bug#8996).
4577
f514f6f0
FP
45782012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4579
e8fc049f 4580 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4581
bf43fa51
KH
45822012-03-25 Kenichi Handa <handa@m17n.org>
4583
4584 * dispextern.h (struct glyph): Change the bit length of
4585 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4586
8a0c01dd
EZ
45872012-03-24 Eli Zaretskii <eliz@gnu.org>
4588
4589 * s/ms-w32.h (tzname): Include time.h before redirecting to
4590 _tzname. Fixes the MSVC build. (Bug#9960)
4591
7d1c3a76
AS
45922012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4593
8ed79523
AS
4594 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4595 characters.
4596
7d1c3a76
AS
4597 * xterm.c (XTread_socket): Only modify handling_signal if
4598 !SYNC_INPUT. (Bug#11080)
4599
e99a9b8b
EZ
46002012-03-23 Eli Zaretskii <eliz@gnu.org>
4601
4602 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4603 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4604 when fetching a multibyte character consumes more bytes than
4605 CHAR_BYTES returns, due to unification of CJK characters in
4606 string_char. (Bug#11073)
4607
5063c0e1
TN
46082012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4609
4610 * process.c (wait_reading_process_output): Handle pty disconnect
4611 by refraining from sending oneself a SIGCHLD (bug#10933).
4612
9f851fbd
CY
46132012-03-22 Chong Yidong <cyd@gnu.org>
4614
4615 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4616
5063c0e1 4617 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4618 Mark string as coming from a prefix property.
4619 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4620 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4621
fb5b8aca
CY
46222012-03-21 Chong Yidong <cyd@gnu.org>
4623
4624 * xfaces.c (Vface_remapping_alist): Doc fix.
4625
62356a1b
EZ
46262012-03-20 Eli Zaretskii <eliz@gnu.org>
4627
4628 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4629 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4630 Doc fixes.
62356a1b 4631
025de85b
CY
46322012-03-20 Chong Yidong <cyd@gnu.org>
4633
4634 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4635 to reflect default non-nil value of redisplay-dont-pause.
4636
4827f94e
KH
46372012-03-19 Kenichi Handa <handa@m17n.org>
4638
4639 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4640 it fit in a valid range (Bug#11003).
4641
e50a24a2
EZ
46422012-03-18 Eli Zaretskii <eliz@gnu.org>
4643
4644 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4645 that is not from display property, accept the row as a "cursor
4646 row" if one of the string's character has a non-nil `cursor'
4647 property. Fixes cursor positioning when there are newlines in
4648 overlay strings, e.g. in icomplete.el. (Bug#11035)
4649
9af5ed87
PE
46502012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4651
4652 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4653
d1f55f16
CY
46542012-03-12 Chong Yidong <cyd@gnu.org>
4655
4656 * eval.c (inhibit_lisp_code): Rename from
4657 inhibit_window_configuration_change_hook; move from window.c.
4658
4659 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4660 * window.c (run_window_configuration_change_hook)
4661 (syms_of_window): Callers changed.
4662
66c5eebd
CY
46632012-03-11 Chong Yidong <cyd@gnu.org>
4664
413df973
CY
4665 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4666
66c5eebd
CY
4667 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4668
1de11f56
CY
46692012-03-10 Chong Yidong <cyd@gnu.org>
4670
4671 * frame.c (other_visible_frames): Don't assume the selected frame
4672 is visible (Bug#10955).
4673
cae07000
SM
46742012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4675
4676 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4677
89c94350
JD
46782012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4679
4680 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4681 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4682 zero (Bug#10954).
4683
999dd333
GM
46842012-03-03 Glenn Morris <rgm@gnu.org>
4685
01a6dcc8 4686 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4687
de0100f2
EZ
46882012-03-02 Eli Zaretskii <eliz@gnu.org>
4689
4690 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4691 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4692 (redisplay_window, next_element_from_string): Fix typos in
4693 comments.
3e441275
EZ
4694 (redisplay_window): Pass to move_it_vertically the margin in
4695 pixels, not in screen lines.
de0100f2 4696
96a72ee9
GM
46972012-03-02 Glenn Morris <rgm@gnu.org>
4698
4699 * buffer.c (buffer-list-update-hook): Doc fix.
4700
312508d7
EZ
47012012-02-29 Eli Zaretskii <eliz@gnu.org>
4702
4703 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4704 push_it before setting up the iterator for the first overlay
4705 string, even if we have an empty string loaded.
4706 (next_overlay_string): If there's an empty string on the iterator
4707 stack, pop the stack. (Bug#10903)
4708
27f3c637
PE
47092012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4710
4711 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4712 Suggested by Stefan Monnier in
4713 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4714 * alloc.c (widen_to_Lisp_Object): New static function.
4715 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4716 and widening them to Lisp_Objects. This would work even if
4717 USE_LSB_TAG is defined and wide integers are used, which might
4718 happen in a future version of Emacs.
4719
3c9dfce6
CY
47202012-02-25 Chong Yidong <cyd@gnu.org>
4721
fa74b241
CY
4722 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4723 Doc fix.
4724
3c9dfce6
CY
4725 * xselect.c (Fx_selection_exists_p): Doc fix.
4726 (x_clipboard_manager_save_all): Print an informative message
4727 before saving to clipboard manager.
4728
9486df08
CY
47292012-02-24 Chong Yidong <cyd@gnu.org>
4730
4731 * keyboard.c (process_special_events): Handle all X selection
4732 requests in kbd_buffer, not just the next one (Bug#8869).
4733
f01d3321
CY
47342012-02-23 Chong Yidong <cyd@gnu.org>
4735
4736 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4737 call when setting menu-bar-lines and tool-bar-lines parameters.
4738 (unwind_create_frame_1): New helper function.
4739
4740 * window.c (inhibit_window_configuration_change_hook): New var.
4741 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4742 (syms_of_window): Initialize it.
f01d3321 4743
86b847b6
CY
47442012-02-22 Chong Yidong <cyd@gnu.org>
4745
4746 * xterm.c (x_draw_image_relief): Add missing type check for
4747 Vtool_bar_button_margin (Bug#10743).
4748
a59225b1
CY
47492012-02-21 Chong Yidong <cyd@gnu.org>
4750
4751 * fileio.c (Vfile_name_handler_alist): Doc fix.
4752
4753 * buffer.c (Fget_file_buffer): Protect against invalid file
4754 handler return value.
4755
310f5bd4
PE
47562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4757
cb3a28cc
PE
4758 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4759 when computing $valmask.
4760
310f5bd4
PE
4761 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4762 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4763 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4764 It's useless in that case, and it can cause problems on hosts
4765 that allocate halves of EMACS_INT values separately.
4766 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4767 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4768 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4769 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4770 it avoids undefined behavior on hosts where shifting right by more
4771 than the word width has undefined behavior.
4772
2375c96a
CY
47732012-02-19 Chong Yidong <cyd@gnu.org>
4774
4775 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4776 (Funhandled_file_name_directory, Ffile_name_as_directory)
4777 (Fdirectory_file_name, Fexpand_file_name)
4778 (Fsubstitute_in_file_name): Protect against invalid file handler
4779 return values (Bug#10845).
4780
3eb49e71
EZ
47812012-02-18 Eli Zaretskii <eliz@gnu.org>
4782
4783 * .gdbinit (pitx): Fix incorrect references to fields of the
4784 iterator stack.
4785
7b926f3f
CY
47862012-02-17 Chong Yidong <cyd@gnu.org>
4787
4788 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4789
11273115
PE
47902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4791
4792 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4793 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4794
c3a70e2b
CY
47952012-02-15 Chong Yidong <cyd@gnu.org>
4796
4797 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4798 marked as special. Also, starting docstrings with * is obsolete.
4799
0ca43699
AS
48002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4801
4802 * gnutls.c (emacs_gnutls_write): Fix last change.
4803
2e8f3c56
LI
48042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4805
4806 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4807 send_process.
4808
af70074f
SM
48092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4810
4811 * keymap.c (Fsingle_key_description): Handle char ranges.
4812
95986d52
CY
48132012-02-12 Chong Yidong <cyd@gnu.org>
4814
afd83bd1
CY
4815 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4816 as that creates a dangerous corner case.
4817
95986d52
CY
4818 * window.c (Fdelete_window_internal): Invalidate the mouse
4819 highlight (Bug#9904).
4820
bd7da63e
GM
48212012-02-12 Glenn Morris <rgm@gnu.org>
4822
4823 * xselect.c (Fx_own_selection_internal)
4824 (Fx_get_selection_internal, Fx_disown_selection_internal)
4825 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4826 * nsselect.m (Fx_own_selection_internal)
4827 (Fx_disown_selection_internal, Fx_selection_exists_p)
4828 (Fx_selection_owner_p, Fx_get_selection_internal):
4829 Sync docs and argument specs with the xselect.c versions.
4830
77abcbc2
LI
48312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4832
4833 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4834
90b671e2
EZ
48352012-02-11 Eli Zaretskii <eliz@gnu.org>
4836
1c0ca0b7
EZ
4837 * w32select.c (Fx_selection_exists_p): Sync doc string and
4838 argument list with xselect.c. (Bug#10783)
4839
4840 * w16select.c (Fx_selection_exists_p): Sync doc string and
4841 argument list with xselect.c. (Bug#10783)
90b671e2 4842
49241268
GM
48432012-02-10 Glenn Morris <rgm@gnu.org>
4844
4845 * fns.c (Fsecure_hash): Doc fix.
4846
f998bbe7 48472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4848
4849 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4850
0992bd9c
CY
48512012-02-07 Chong Yidong <cyd@gnu.org>
4852
4853 * buffer.c (Fbuffer_local_variables)
4854 (buffer_lisp_local_variables): Handle unbound vars correctly;
4855 don't let Qunbound leak into Lisp.
4856
af008560
GM
48572012-02-07 Glenn Morris <rgm@gnu.org>
4858
dd605cc4
GM
4859 * image.c (Fimagemagick_types): Doc fix.
4860
af008560
GM
4861 * image.c (imagemagick-render-type): Change it from a lisp object
4862 to an integer. Move the doc here from the lisp manual.
4863 Treat all values not equal to 0 the same.
4864
1449fa1d
CY
48652012-02-06 Chong Yidong <cyd@gnu.org>
4866
4867 * doc.c (store_function_docstring): Avoid applying docstring of
4868 alias to base function (Bug#2603).
4869
3723ec07
AS
48702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4871
4872 * .gdbinit (pp1, pv1): Remove redundant defines.
4873 (pr): Use pp.
4874
79c1cc1e
CY
48752012-02-04 Chong Yidong <cyd@gnu.org>
4876
4877 * nsterm.m: Declare a global (Bug#10694).
4878
d7f29f8e
EZ
48792012-02-04 Eli Zaretskii <eliz@gnu.org>
4880
cae07000
SM
4881 * w32.c (get_emacs_configuration_options):
4882 Include --enable-checking, if specified, in the return value.
d7f29f8e 4883
3b95a6f9
MR
48842012-02-04 Martin Rudalics <rudalics@gmx.at>
4885
4886 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4887 after rounding frame sizes. (Bug#9723)
4888
d6fa96a6
EZ
48892012-02-04 Eli Zaretskii <eliz@gnu.org>
4890
4891 * keyboard.c (adjust_point_for_property): Don't position point
4892 before BEGV. (Bug#10696)
4893
df0b2940
PE
48942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4895
4896 Handle overflow when computing char display width (Bug#9496).
4897 * character.c (char_width): Return EMACS_INT, not int.
4898 (char_width, c_string_width): Check for overflow when
4899 computing the width; this is possible now that individual
4900 characters can have unbounded width. Problem introduced
4901 by merge from Emacs 23 on 2012-01-19.
4902
6bee44d6
MA
49032012-02-02 Michael Albinus <michael.albinus@gmx.de>
4904
4905 * dbusbind.c (Fdbus_register_method): Mention the return value
4906 :ignore in the docstring.
4907
44f92739
GM
49082012-02-02 Glenn Morris <rgm@gnu.org>
4909
1b9f60cc
GM
4910 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4911
44f92739
GM
4912 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4913 Unconditionally set to t. (Bug#10673)
4914 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4915 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4916 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4917
c5d3843c
KH
49182012-02-02 Kenichi Handa <handa@m17n.org>
4919
4920 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4921 0, do not call append_composite_glyph.
4922
159462d4 49232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4924
4925 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4926 NULL (Bug#6988).
4927 (x_produce_glyphs): If the component of a composition is a null
4928 string, set it->pixel_width to 1 to avoid zero-width glyph.
4929
78cef877
EZ
49302012-02-01 Eli Zaretskii <eliz@gnu.org>
4931
4932 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4933 first 2 arguments are identical. This makes inserting large
4934 output from a subprocess an order of magnitude faster on
4935 MS-Windows, where all sbrk'ed memory is always contiguous.
4936
97897668
GM
49372012-01-31 Glenn Morris <rgm@gnu.org>
4938
4939 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4940 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4941 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4942
31fd3586
GM
49432012-01-29 Glenn Morris <rgm@gnu.org>
4944
4945 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4946
0e24a8b2
CY
49472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4948
4949 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4950
cc0adcb0
CY
49512012-01-28 Chong Yidong <cyd@gnu.org>
4952
4953 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4954
acc28cb9
CY
49552012-01-26 Chong Yidong <cyd@gnu.org>
4956
9c69cfb7
CY
4957 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4958
acc28cb9
CY
4959 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4960 repeat counts (Bug#10507).
4961
48da7392
GM
49622012-01-26 Glenn Morris <rgm@gnu.org>
4963
4964 * lread.c (syms_of_lread): Doc fix.
4965
14af5f7f
CY
49662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4967
4968 * coding.c (encode_designation_at_bol): Change return value to
4969 EMACS_INT.
4970
0b21c100
CY
49712012-01-25 Chong Yidong <cyd@gnu.org>
4972
4973 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4974
3c2907f7
CY
49752012-01-21 Chong Yidong <cyd@gnu.org>
4976
4977 * floatfns.c (Fcopysign): Make the second argument non-optional,
4978 since nil is not allowed anyway.
4979
959ad23f
AS
49802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4981
4982 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4983 (send_process): Likewise.
4984
34a02f46
MR
49852012-01-19 Martin Rudalics <rudalics@gmx.at>
4986
4987 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4988 (Vwindow_persistent_parameters): Do not use Qstate.
4989 Rewrite doc-strings.
34a02f46 4990
1259009a 49912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4992
4993 * character.c (char_width): New function.
70d4fdf6
GM
4994 (Fchar_width, c_string_width, lisp_string_width):
4995 Use char_width (Bug#9496).
25ed9e61 4996
6a6ee00d
MR
49972012-01-16 Martin Rudalics <rudalics@gmx.at>
4998
4999 * window.c (Vwindow_persistent_parameters): New variable.
5000 (Fset_window_configuration, save_window_save): Handle persistent
5001 window parameters.
5002
c85efaf7
EZ
50032012-01-14 Eli Zaretskii <eliz@gnu.org>
5004
5005 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5006 thrashing the stack of the thread. (Bug#9087)
5007
5944709e
PE
50082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5009
5010 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5011
e71f5d99
EZ
50122012-01-11 Eli Zaretskii <eliz@gnu.org>
5013
5014 * xdisp.c (rows_from_pos_range): Handle the case where the
5015 highlight ends on a newline. (Bug#10464)
5016 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5017 he end column for display of highlight that ends on a newline
5018 before a R2L line.
5019
ce316182
GM
50202012-01-11 Glenn Morris <rgm@gnu.org>
5021
5022 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5023 from load-path also when installation-directory is nil. (Bug#10208)
5024
5b43da69
GM
50252012-01-10 Glenn Morris <rgm@gnu.org>
5026
74cc8ff9
GM
5027 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5028
7d8d6e4e
GM
5029 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5030 Update template values to be closer to their typical values these days.
5b43da69 5031
a0db8d43
EZ
50322012-01-09 Eli Zaretskii <eliz@gnu.org>
5033
5034 * xdisp.c (rows_from_pos_range): Accept additional argument
5035 DISP_STRING, and accept any glyph in a row whose object is that
5036 string as eligible for mouse highlight. Fixes mouse highlight of
5037 display strings from overlays. (Bug#10464)
5038
9a0115ab 50392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5040
b9110d6a 5041 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5042 * fileio.c (auto_saving_dir_umask): New static var.
5043 (Fmake_directory_internal): Use it.
5044 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5045 creating the directory. The old code temporarily assigns
5046 too-generous permissions to the directory.
5047 (do_auto_save_eh): Clear it.
b9110d6a 5048 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5049 that the var is always cleared.
5050
6c1bd3f3
EZ
50512012-01-07 Eli Zaretskii <eliz@gnu.org>
5052
5053 * search.c (scan_buffer): Pass character positions to
5054 know_region_cache, not byte positions. (Bug#6540)
5055
069d2b50
L
50562012-01-07 LynX <_LynX@bk.ru> (tiny change)
5057
5058 * w32.c (sys_rename): Report EXDEV when rename of a directory
5059 fails because the target is on another logical disk. (Bug#10284)
5060
75bf0d33
DB
50612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5062
5063 * xterm.c (x_embed_request_focus): New function.
5064
5065 * xterm.h: Add prototype.
5066
5067 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5068
1c6e5a32
GM
50692012-01-05 Glenn Morris <rgm@gnu.org>
5070
5071 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5072
651e947e
EZ
50732012-01-01 Eli Zaretskii <eliz@gnu.org>
5074
5075 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5076 Load gnutls_transport_set_lowat only if GnuTLS version is below
5077 2.11.1.
5078 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5079 GnuTLS versions below 2.11.1.
5080
3778cdd8
AL
50812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5082
5083 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5084 to the doc string advising against its use for altering the way
5085 windows are scrolled.
5086
0e5317f7
KH
50872011-12-28 Kenichi Handa <handa@m17n.org>
5088
5089 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5090 coding-system ASCII compatible only when it does not produce BOM
5091 on encoding (Bug#10383).
5092
93d5ca1f
JD
50932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5094
5095 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5096 can scroll.
5097 (create_and_show_popup_menu): Always use menu_position_func for
5098 Gtk3 (Bug#10361).
5099
ca22b785
AS
51002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5101
5102 * callint.c (Fcall_interactively): Don't truncate prompt string.
5103
d048e1e6
EZ
51042011-12-23 Eli Zaretskii <eliz@gnu.org>
5105
5106 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5107 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5108 resumed from there (after widening). (Bug#10360)
d048e1e6 5109
5ccaba1f
JD
51102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5111
5112 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5113
204ee57f
JD
51142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5115
b81d40f0
JB
5116 * nsterm.m (x_free_frame_resources):
5117 Release f->output_data.ns->miniimage.
204ee57f
JD
5118 (ns_index_color): Fix indentation. Do not retain
5119 color_table->colors[i].
5120
5121 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5122 before returning.
5123
5124 * nsfns.m (x_set_background_color): Assign return value from
5125 ns_index_color to face-background instead of NSColor*.
5126 (ns_implicitly_set_icon_type): Fix indentation.
5127 Change assignment in for loop to comparison.
5128
5129 * emacs.c (ns_pool): New variable.
5130 (main): Assign ns_pool.
5131 (Fkill_emacs): Call ns_release_autorelease_pool.
5132
5133 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5134 autorelease fdesc, release fdAttrs and tdict.
5135 (ns_get_covering_families): Release charset.
5136 (ns_findfonts): Release NSFontDescriptor created with new.
5137 (ns_uni_to_glyphs): Fix indentation.
5138 (setString): Release attrStr before assigning new value.
5139
c803b2b7
JD
51402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5141
678f4426
JD
5142 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5143 and NS_IMPL_COCOA.
5144 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5145 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5146
cd394be1 51472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5148
5fecd5fc
JD
5149 * nsterm.m (ns_term_init): Subscribe for notifications
5150 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5151 to method trackingNotification in EmacsMenu.
5152
5153 * nsmenu.m (trackingMenu): New variable.
3771cb17 5154 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5155 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5156 from Aquamacs (Bug#7030).
678f4426
JD
5157
51582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5159
c803b2b7
JD
5160 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5161 (symbol_to_nsstring): Fix indentation.
5162 (ns_symbol_to_pb): New function.
cae07000
SM
5163 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5164 (Fns_rotate_cut_buffers_internal): Remove.
5165 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5166 Fns_store_cut_buffer_internal.
5167 (ns_get_foreign_selection, Fx_own_selection_internal)
5168 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5169 (Fns_get_selection_internal, Fns_store_selection_internal):
5170 Use ns_symbol_to_pb and check if return value is nil.
5171 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5172 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5173 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5174 renamed to Sns_store_selection_internal.
5175 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5176 and remove this function.
5177 (ns_handle_selection_clear): Remove, never used.
5178 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5179 here.
5180
e1b01a3a
KB
51812011-12-17 Ken Brown <kbrown@cornell.edu>
5182
5183 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5184 GID is unknown (Bug#10257).
5185
2adb6e85
PE
51862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5187
5188 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5189 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5190 which caused a build failure on GNU/Linux IA-64. This problem was
5191 introduced by my 2011-10-07 patch.
5192
d1d7b339
JL
51932011-12-15 Juri Linkov <juri@jurta.org>
5194
5195 * image.c (imagemagick_error): New function. (Bug#10112)
5196 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5197 Use `imagemagick_error' where ImageMagick functions return
5198 `MagickFalse'.
5199 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5200 proper order.
5201
100d5755
KH
52022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5203
5204 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5205 fill background (Bug#8992).
5206
454592a6
MR
52072011-12-13 Martin Rudalics <rudalics@gmx.at>
5208
5209 * window.c (Vwindow_combination_resize)
5210 (Vwindow_combination_limit): Use t instead of non-nil in
5211 doc-strings.
61d4b438
MR
5212 (Vrecenter_redisplay): Add first sentence of doc-string on
5213 separate line.
53524d93 5214 (Frecenter): Fix doc-string typo.
454592a6 5215
3633e3aa
KH
52162011-12-11 Kenichi Handa <handa@m17n.org>
5217
5218 * coding.c (Funencodable_char_position): Pay attention to the
5219 buffer text relocation (Bug#9389).
5220
7b9d523a 52212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5222
7b9d523a
JD
5223 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5224 gtk_init (Bug#10100).
5225
b73189c6
EZ
52262011-12-10 Eli Zaretskii <eliz@gnu.org>
5227
5228 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5229 IT->string is nil. (Bug#10263)
5230
f7dfe5d6
JD
52312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5232
83faebb4
JD
5233 * nsterm.h (x_free_frame_resources): Declare.
5234
f7dfe5d6
JD
5235 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5236 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5237
5238 * nsterm.h (ns_get_defaults_value): Declare.
5239
5240 * nsterm.m (ns_default): Call ns_get_defaults_value.
5241
7cd4e72c
EZ
52422011-12-09 Eli Zaretskii <eliz@gnu.org>
5243
5244 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5245 (Bug#10170)
5246
b34d7317
YM
52472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5248
5249 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5250 that where the value of an _OBJC_* symbol points to is in the .bss
5251 section (Bug#10240).
5252
76470ad1
KH
52532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5254
5255 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5256 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5257
745fff94
KH
52582011-12-08 Kenichi Handa <handa@m17n.org>
5259
5260 * ftfont.c (get_adstyle_property): Fix previous change
5261 (Bug#10233).
5262
6e44397c
JB
52632011-12-07 Juanma Barranquero <lekktu@gmail.com>
5264
5265 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5266 dirs from the default value of EMACSLOADPATH (bug#10208).
5267
7efa6272
GM
52682011-12-07 Glenn Morris <rgm@gnu.org>
5269
5270 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5271 installation and source directories as well. (Bug#10208)
5272
f6fc4d87
CY
52732011-12-06 Chong Yidong <cyd@gnu.org>
5274
5275 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5276
2bf26180
GM
52772011-12-06 Glenn Morris <rgm@gnu.org>
5278
5279 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5280 as an error, not just -1. (Bug#10217)
5281
3a6ad4f0
CY
52822011-12-05 Chong Yidong <cyd@gnu.org>
5283
5284 * keyboard.c (process_special_events): New function.
5285 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5286
75a3b399
PE
52872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5288
5289 * coding.c (encode_designation_at_bol): Don't use uninitialized
5290 local variable (Bug#9318).
5291
c3c9e25e
KH
52922011-12-05 Kenichi Handa <handa@m17n.org>
5293
5294 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5295 return Qnil (Bug#8046, Bug#10193).
5296
5eb05ea3
KH
52972011-12-05 Kenichi Handa <handa@m17n.org>
5298
5299 * coding.c (encode_designation_at_bol): New args charbuf_end and
5300 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5301 (coding_set_source): Return how many bytes coding->source was
5302 relocated.
5303 (coding_set_destination): Return how many bytes
5304 coding->destination was relocated.
5305 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5306 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5307
53082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5309
5310 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5311 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5312 macro (Bug#9318).
5313
53142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5315
5316 The following changes are to fix Bug#9318.
5317
a79703f5 5318 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5319 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5320 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5321 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5322
7dbda6df
JB
53232011-12-05 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * lisp.h (process_quit_flag): Fix external declaration.
5326
6d5eb5b0
SM
53272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5328
5329 Don't macro-inline non-performance-critical code.
5330 * eval.c (process_quit_flag): New function.
5331 * lisp.h (QUIT): Use it.
5332
a0c3fad0
JD
53332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5334
5335 * nsfns.m (get_geometry_from_preferences): New function.
5336 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5337
6c07aac2
AS
53382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5339
5340 * emacs.c (Qkill_emacs): Define.
5341 (syms_of_emacs): Initialize it.
5342 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5343 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5344 (quit_throw_to_read_char): Add parameter `from_signal'.
5345 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5346 * lisp.h (QUIT): Call Fkill_emacs if requested.
5347
c052ead4
JD
53482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5349
5350 * widget.c (update_wm_hints): Return if wmshell is null.
5351 (widget_update_wm_size_hints): New function.
5352
5353 * widget.h (widget_update_wm_size_hints): Declare.
5354
5355 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5356 widget_update_wm_size_hints (Bug#10104).
5357
9e49252b
EZ
53582011-12-03 Eli Zaretskii <eliz@gnu.org>
5359
5360 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5361 before a newline, prepare the bidi iterator for consuming the
5362 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5363 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5364
02b16839
JL
53652011-12-02 Juri Linkov <juri@jurta.org>
5366
5367 * search.c (Fword_search_regexp): New Lisp function created from
5368 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5369 (Fword_search_backward, Fword_search_forward)
5370 (Fword_search_backward_lax, Fword_search_forward_lax):
5371 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5372 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5373
0068070e
SM
53742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5375
5376 * fileio.c (Finsert_file_contents): Move after-change-function call
5377 to before the "handled:" label, since all "goto handled" appear in
5378 cases where the *-change-functions have already been properly called
5379 (bug#10117).
5380
3360a3fc
AS
53812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5382
5383 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5384 waiting for input. (Bug#10169)
5385
73d6c093
EZ
53862011-11-30 Eli Zaretskii <eliz@gnu.org>
5387
5388 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5389 verifies glyph row's hash code--we have just reallocated the
5390 glyphs, so their contents can be complete garbage. (Bug#10164)
5391
febe6bea
JB
53922011-11-30 Juanma Barranquero <lekktu@gmail.com>
5393
5394 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5395
801a4313
EZ
53962011-11-30 Eli Zaretskii <eliz@gnu.org>
5397
5398 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5399 attributes are tested _before_ calling verify_row_hash, to protect
5400 against GCC re-ordering of the tests. (Bug#10164)
5401
2b56b87e
JD
54022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5403
5404 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5405
5406 * xterm.c (handle_one_xevent): Only set async_visible and friends
5407 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5408 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5409 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5410
dbf31225
PE
54112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5412
5413 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5414 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5415 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5416 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5417 All uses changed to use GCPRO1 etc.
5418 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5419 Revert to old implementation (i.e., before 2011-03-11).
5420
1305621b
YM
54212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5422
5423 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5424 of scroll runs so as to avoid assigning disabled bogus rows and
5425 unnecessary graphics copy operations.
5426
8c9afb46
EZ
54272011-11-27 Eli Zaretskii <eliz@gnu.org>
5428
5429 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5430 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5431 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5432 (malloc, free, realloc, calloc): Redirect to e_* only when
5433 compiling Emacs.
5434
5435 * lisp.h (GCTYPEBITS): Move before first use.
5436 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5437 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5438 this macro definition.
5439
5440 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5441 _MSC_VER.
5442
54e9e3bf
JD
54432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5444
6d5eb5b0
SM
5445 * gtkutil.c (xg_create_frame_widgets):
5446 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5447 present with Gtk+ 2.0.
5448
83aca1cb
PE
54492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5450
5451 * fileio.c (Finsert_file_contents): Undo previous change; see
5452 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5453
5b76caa4
PE
54542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5455
5456 Rename locals to avoid shadowing.
5457 * fileio.c (Finsert_file_contents):
5458 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5459 * process.c (wait_reading_process_output):
5460 Rename inner 'proc' to 'p' to avoid shadowing.
5461 Indent for consistency with usual Emacs style.
5462
8c535114
EZ
54632011-11-25 Eli Zaretskii <eliz@gnu.org>
5464
5465 * xdisp.c (redisplay_window): If cursor row is not fully visible
5466 after recentering, and scroll-conservatively is set to a large
5467 number, scroll window by a few more lines to make the cursor fully
5468 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5469 (start_display): Don't move to the next line if the display should
5470 start at a newline that is part of a display vector or an overlay
5471 string. (Bug#10119)
8c535114 5472
fa4fdb5c
JL
54732011-11-24 Juri Linkov <juri@jurta.org>
5474
5475 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5476 after the `MagickPingImage' call. (Bug#10112)
5477
90ec88df
CY
54782011-11-23 Chong Yidong <cyd@gnu.org>
5479
5480 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5481
56e2e794
MR
54822011-11-23 Martin Rudalics <rudalics@gmx.at>
5483
5484 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5485 making another buffer current. (Bug#10114)
5486
b6e64c41
GM
54872011-11-23 Glenn Morris <rgm@gnu.org>
5488
5489 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5490
6b21de18
CY
54912011-11-23 Chong Yidong <cyd@gnu.org>
5492
5493 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5494 using it (Bug#5984).
5495
b12cd789
EZ
54962011-11-22 Eli Zaretskii <eliz@gnu.org>
5497
5498 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5499 and header-lines, as they don't have one computed for them.
5500 (Bug#10098)
5501
5502 * .gdbinit (prow): Make displayed values more self-explaining.
5503 Add row's hash code.
5504
261b6fd4
LMI
55052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5506
5507 * process.c (wait_reading_process_output): Fix asynchrounous
5508 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5509 (wait_reading_process_output): Add comment and URL.
261b6fd4 5510
e7cfd277
JD
55112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5512
5513 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5514
a9b9b7f5
CY
55152011-11-21 Chong Yidong <cyd@gnu.org>
5516
5517 * window.c (Fnext_window, Fprevious_window): Doc fix.
5518
b0d15b4f
SM
55192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5520
5521 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5522
fe7a3057
JB
55232011-11-20 Juanma Barranquero <lekktu@gmail.com>
5524
5525 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5526
d2999b1a
MR
55272011-11-20 Martin Rudalics <rudalics@gmx.at>
5528
5529 * window.c (Fset_window_combination_limit): Rename argument
5530 STATUS to LIMIT.
5531 (Vwindow_combination_limit): Remove "status" from doc-string.
5532
d5ff9cd0
AS
55332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5534
5535 * m/ibms390.h: Remove.
5536 * m/ibms390x.h: Don't include "ibms390.h".
5537
a5bb9bd3
SM
55382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5539
5540 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5541 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5542
cd1181db
JB
55432011-11-20 Juanma Barranquero <lekktu@gmail.com>
5544
5545 * casetab.c (Fset_case_table):
5546 * charset.c (Fcharset_after): Fix typos.
5547
615a3b8d 55482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5549
17e845af
PE
5550 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5551 Otherwise, valgrind does not work on some platforms.
5552 Problem reported by Andreas Schwab in
6a0bf43d
PE
5553 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5554 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5555 is set, removing the need for VIRT_ADDRESS_VARIES.
5556 (PURE_P): Use a more-efficient implementation that needs just one
5557 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5558 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5559 to 4 (xorl, subq, cmpq, setbe).
5560 * alloc.c (pure): Always extern now, since that's the
5561 VIRT_ADDR_VARIES behavior.
5562 (PURE_POINTER_P): Use a single comparison, not two, for
5563 consistency with the new puresize.h.
5564 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5565 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5566 Remove VIRT_ADDR_VARIES no longer needed.
5567
f8fe6f96
EZ
55682011-11-19 Eli Zaretskii <eliz@gnu.org>
5569
5570 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5571 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5572 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5573 behave as if the cursor position were at the window margin.
5574
5575 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5576 and the cursor position is out of bounds, behave as if the cursor
5577 position were at the window margin. (Bug#10075)
5578
df05a53c
CY
55792011-11-18 Chong Yidong <cyd@gnu.org>
5580
5581 * window.c (Fwindow_combination_limit): Make first argument
5582 non-optional, since it is meaningless for live windows like the
5583 selected window.
61ccba97 5584
2071918e
DA
55852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5586
5587 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5588
b50a28de
SM
55892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5590
5591 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5592 (graft_intervals_into_buffer): Simplify.
5593
015137db
EZ
55942011-11-18 Eli Zaretskii <eliz@gnu.org>
5595
5596 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5597 hash values of the two rows.
5598 (copy_row_except_pointers): Preserve the used[] arrays and the
5599 hash values of the two rows. (Bug#10035)
68c95424 5600 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5601
5602 * xdisp.c (row_hash): New function, body extracted from
5603 compute_line_metrics.
5604 (compute_line_metrics): Call row_hash, instead of computing the
5605 hash code inline.
5606
5607 * dispnew.c (verify_row_hash): Call row_hash for computing the
5608 hash code of a row, instead of duplicating code from xdisp.c.
5609
5610 * dispextern.h (row_hash): Add prototype.
5611
a2addb04
TH
56122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5613
5614 * frame.c (delete_frame): Don't delete the terminal when the last
5615 X frame is closed if emacs is built with GTK toolkit.
5616
df85d315
JB
56172011-11-17 Juanma Barranquero <lekktu@gmail.com>
5618
5619 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5620
a0c2d0ae
MR
56212011-11-17 Martin Rudalics <rudalics@gmx.at>
5622
5623 * window.c (Vwindow_splits): Rename to
5624 Vwindow_combination_resize. Suggested by Juri Linkov.
5625 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5626 of Vwindow_splits.
5627
58179cce
JB
56282011-11-16 Juanma Barranquero <lekktu@gmail.com>
5629
7877f373
JB
5630 * nsfns.m (Fns_font_name):
5631 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5632
b6f67890
MR
56332011-11-16 Martin Rudalics <rudalics@gmx.at>
5634
5635 * window.h (window): Rename slot "nest" to "combination_limit".
5636 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5637 (Fset_window_nest): Rename to Fset_window_combination_limit.
5638 (Vwindow_nest): Rename to Vwindow_combination_limit.
5639 (recombine_windows, make_parent_window, make_window)
5640 (Fsplit_window_internal, saved_window)
5641 (Fset_window_configuration, save_window_save): Rename all
5642 occurrences of window_nest to window_combination_limit.
5643
c7015153
JB
56442011-11-15 Juanma Barranquero <lekktu@gmail.com>
5645
5646 * image.c (imagemagick_load_image): Fix typo.
5647
322ad6ec
EZ
56482011-11-14 Eli Zaretskii <eliz@gnu.org>
5649
5650 * xdisp.c (display_line): Move the call to
5651 highlight_trailing_whitespace before the call to
5652 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5653 faces of all the glyphs to compute ROW's hash value.
5654 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5655
f067b8ec
JB
56562011-11-14 Juanma Barranquero <lekktu@gmail.com>
5657
5658 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5659 just return (bug#10044).
5660
1e5b2111
EZ
56612011-11-12 Eli Zaretskii <eliz@gnu.org>
5662
7ef3cbd5
EZ
5663 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5664 with user-defined heap size. Bump the default size of the temacs
5665 heap to 27MB, to avoid memory warning when running temacs.
5666 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5667
1e5b2111
EZ
5668 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5669 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5670 (verify_row_hash) [XASSERTS]: New function.
5671 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5672 that the hash value of glyph rows is correct.
1e5b2111 5673
89d61221
MR
56742011-11-12 Martin Rudalics <rudalics@gmx.at>
5675
5676 * window.h (window): Remove splits slot.
5677 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5678 (Fdelete_other_windows_internal, make_parent_window)
5679 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5680 (Fset_window_configuration, save_window_save): Don't deal with
5681 split status of windows.
5682 (saved_window): Remove splits slot.
5683 (Vwindow_splits): Rewrite doc-string.
5684
97f18cc8
JD
56852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5686
5687 * xfns.c (unwind_create_frame):
5688 * nsfns.m (unwind_create_frame):
5689 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5690 Vframe_list (Bug#9999).
5691
22a648b4
DA
56922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5693
0b381c7e 5694 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5695
659afede
KH
56962011-11-11 Kenichi Handa <handa@m17n.org>
5697
5698 * callproc.c (Fcall_process): Set the member dst_multibyte of
5699 process_coding.
5700
9ac0394b
KH
57012011-11-11 Johan Bockgård <bojohan@gnu.org>
5702
5703 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5704 avoid a crash (bug#9496).
5705
2fbdc249
CY
57062011-11-09 Chong Yidong <cyd@gnu.org>
5707
5708 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5709 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5710
ac6b1f81
PE
57112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5712
5713 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5714
09db192c
PE
57152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5716
5717 Avoid some portability problems by eschewing 'extern inline' functions.
5718 The trivial performance wins aren't worth the portability hassles; see
5719 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5720 et seq.
5721 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5722 (window_box_width, window_box_left, window_box_left_offset)
5723 (window_box_right, window_box_right_offset): Undo previous change,
5724 by removing the "extern"s.
5725 * intervals.c (adjust_intervals_for_insertion)
5726 (adjust_intervals_for_deletion): Undo previous change,
5727 making these static again.
5728 (offset_intervals, temp_set_point_both, temp_set_point)
5729 (copy_intervals_to_string): No longer inline.
5730 * xdisp.c (window_text_bottom_y, window_box_width)
5731 (window_box_height, window_box_left_offset)
5732 (window_box_right_offset, window_box_left, window_box_right)
5733 (window_box): No longer inline.
5734
105216ed
CY
57352011-11-08 Chong Yidong <cyd@gnu.org>
5736
5737 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5738 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5739 Signal an error if not a live window.
105216ed
CY
5740 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5741 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5742
ae9e237f
JB
57432011-11-07 Juanma Barranquero <lekktu@gmail.com>
5744
5745 * lisp.h (syms_of_abbrev): Remove declaration.
5746 Reported by CHENG Gao <chenggao@royau.me>.
5747
c7aa8333
EZ
57482011-11-07 Eli Zaretskii <eliz@gnu.org>
5749
5750 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5751 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5752 of temacs in GUI mode.
5753
be7f5545
MR
57542011-11-07 Martin Rudalics <rudalics@gmx.at>
5755
5756 * window.h: Declare delete_all_child_windows instead of
5757 delete_all_subwindows.
5758 * window.c (Fwindow_nest, Fset_window_nest)
5759 (Fset_window_new_total, Fset_window_new_normal)
5760 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5761 (delete_all_subwindows): Rename to delete_all_child_windows.
5762 (Fdelete_other_windows_internal, Fset_window_configuration):
5763 Call delete_all_child_windows instead of delete_all_subwindows.
5764 * frame.c (delete_frame): Call delete_all_child_windows instead
5765 of delete_all_subwindows.
5766
ca78dc43
PE
57672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5768
5769 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5770 This is also needed for porting to any host where GC_MARK_STACK is
5771 not GC_MAKE_GCPROS_NOOPS.
5772 (which_symbols): Use it.
5773
a0241d01
KH
57742011-11-07 Kenichi Handa <handa@m17n.org>
5775
5776 * coding.c (coding_set_destination): Check coding->src_pos only
5777 when coding->src_object is a buffer (bug#9910).
5778
5779 * process.c (send_process): Set the member src_multibyte of coding
5780 to 0 (bug#9911) when sending a unibyte text.
5781
5782 * callproc.c (Fcall_process): Set the member src_multibyte of
5783 process_coding to 0 (bug#9912).
5784
a64bfdfa 57852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5786
5787 * xmenu.c (cleanup_widget_value_tree): New function.
5788 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5789 calling free_menubar_widget_value_tree directly (Bug#9830).
5790
cb41b32a
PE
57912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5792
5793 Fix some portability problems with 'inline'.
5794 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5795 (window_box_width, window_box_left, window_box_left_offset)
5796 (window_box_right, window_box_right_offset): Declare extern.
5797 Otherwise, these inline functions do not conform to C99 and
5798 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5799 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5800 * intervals.c (adjust_intervals_for_insertion)
5801 (adjust_intervals_for_deletion): Now extern, because otherwise the
5802 extern inline functions 'offset_intervals' couldn't refer to it.
5803 (static_offset_intervals): Remove.
5804 (offset_intervals): Rewrite using the old contents of
5805 static_offset_intervals. The old version didn't conform to C99
5806 because an extern inline function contained a reference to an
5807 identifier with static linkage.
5808
b7041366
AS
58092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5810
5811 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5812 GC.
5813
88a37c4d
EZ
58142011-11-06 Eli Zaretskii <eliz@gnu.org>
5815
5816 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5817 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5818 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5819 return Qleft_to_right.
5820
49745b39
CY
58212011-11-06 Chong Yidong <cyd@gnu.org>
5822
5823 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5824 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5825 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5826 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5827 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5828 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5829 (Fwindow_vscroll): Doc fix.
5830 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5831 argument, since it makes no sense to pass a live window and for
5832 consistency with window-child.
5833
1f05cd82
CS
58342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5835
5836 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5837 support MSVC.
5838
22610910
JR
58392011-11-05 Jason Rumney <jasonr@gnu.org>
5840
5841 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5842 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5843 fonts (Bug#6029).
5844 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5845 bitwise arithmetic preventing use of unicode-sip and non-truetype
5846 opentype fonts.
5847
a06776b2
EZ
58482011-11-05 Eli Zaretskii <eliz@gnu.org>
5849
3ad924ba
EZ
5850 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5851 "emacs"-only part.
5852
a06776b2
EZ
5853 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5854 initialization code to keep similarity to xfns.c after changes
5855 from 2011-11-05.
5856
c9e7db78
JD
58572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5858
a97f8f3f
JD
5859 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5860 (unwind_create_frame): New function (Bug#9943).
5861 (Fx_create_frame): Restructure code to be more similar to the one in
5862 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5863 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5864 Move terminal->reference_count++ just before making the frame official
5865 (Bug#9943).
5866
5867 * nsterm.m (x_free_frame_resources): New function.
5868 (x_destroy_window): Move code to x_free_frame_resources.
5869
c9e7db78 5870 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5871 (Fx_create_frame, x_create_tip_frame):
5872 Move terminal->reference_count++ just before making the frame
75f1671a 5873 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5874 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5875
a6fc3b5c
EZ
58762011-11-05 Eli Zaretskii <eliz@gnu.org>
5877
5878 Support MSVC build with newer versions of Visual Studio.
5879 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5880 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5881 nt/gmake.defs.
5882
5883 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5884 which are not supported by MSVC.
5885 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5886 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5887 bitfields.
5888 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5889 types in bitfields.
5890 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5891
5892 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5893
58179cce 58942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5895
5896 Support MSVC build with newer versions of Visual Studio.
5897 * w32.c: Don't include w32api.h for MSVC.
5898 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5899
5900 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5901 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5902 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5903 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5904 e_* cousins.
5905 (alloca) [_MSC_VER]: Define to _alloca.
5906
5907 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5908
5909 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5910
a58c13ed
EZ
59112011-11-04 Eli Zaretskii <eliz@gnu.org>
5912
5913 * xdisp.c (note_mouse_highlight): If either of
5914 previous/next-single-property-change returns nil, treat that as
5915 the beginning or the end of the buffer. (Bug#9955)
5916
fe0b6370
JD
59172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5918
a58c13ed 5919 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5920 label is not null (Bug#9951).
5921 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5922 may be NULL.
5923
89bd5ee1
EZ
59242011-11-04 Eli Zaretskii <eliz@gnu.org>
5925
5926 * window.c (Fwindow_body_size): Mention in the doc string that the
5927 return value is in frame's canonical units. (Bug#9949)
5928
84c3edb9
EZ
59292011-11-03 Eli Zaretskii <eliz@gnu.org>
5930
4e2fb5c7
EZ
5931 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5932
84c3edb9 5933 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5934 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5935 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5936
bc17a887
EZ
59372011-11-01 Eli Zaretskii <eliz@gnu.org>
5938
5939 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5940 Don't stop backward scan on the continuation glyph, even though
5941 its CHARPOS is positive.
6d5eb5b0
SM
5942 (mouse_face_from_buffer_pos, note_mouse_highlight):
5943 Rename cover_string to disp_string.
bc17a887 5944
4ee88440
MR
59452011-11-01 Martin Rudalics <rudalics@gmx.at>
5946
5947 * window.c (temp_output_buffer_show): Don't use
5948 Vtemp_buffer_show_specifiers.
5949 (Vtemp_buffer_show_specifiers): Remove unused variable.
5950
c2ff3c02
EZ
59512011-10-30 Eli Zaretskii <eliz@gnu.org>
5952
5953 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5954 past the beginning of the current glyph matrix.
5955
58179cce 59562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5957
5958 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5959 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5960 HAVE_GTK3 (Bug#9869).
b77a6a7f 5961
3b574623
JD
5962 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5963 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5964
b77a6a7f
JD
5965 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5966
5967 * xterm.c: Declare x_handle_net_wm_state to return int.
5968 (handle_one_xevent): Check if we are iconified but don't have
5969 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5970 (get_current_wm_state): Return non-zero if not hidden,
5971 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5972 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5973 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5974 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5975
196e41e4
PE
59762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5977
5978 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5979 so that this new function doesn't get optimized away by a
5980 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5981
021f2e1a
AS
59822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5983
5984 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5985
8b058d44
EZ
59862011-10-29 Eli Zaretskii <eliz@gnu.org>
5987
5988 Fix the `xbytecode' command.
5989 * .gdbinit (xprintbytestr): New command.
b50a28de 5990 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5991 (xbytecode): Print the byte-code string as well.
5992
4452fb80
EZ
59932011-10-29 Kim Storm <storm@cua.dk>
5994
8b058d44
EZ
5995 * alloc.c (which_symbols): New function.
5996
21b72067
AS
59972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5998
5999 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6000 line. (Bug#9903)
6001
83ed7b5c
GM
60022011-10-29 Glenn Morris <rgm@gnu.org>
6003
6004 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6005 Not clear what it was for, and it causes various bugs. (Bug#9839)
6006
5a7a728b
EZ
60072011-10-28 Eli Zaretskii <eliz@gnu.org>
6008
6009 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6010 possible random value that matches one of those tested as
6011 condition to clear the mouse face.
6012
d3d0842f
CY
60132011-10-28 Chong Yidong <cyd@gnu.org>
6014
6015 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6016
31b39d13
DN
60172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6018
6019 * window.c (make_window): Initialize phys_cursor_on_p.
6020
9aba6043
SM
60212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6022
6023 * lisp.h (struct Lisp_Symbol): Update comments.
6024
c20992f4
JB
60252011-10-28 Juanma Barranquero <lekktu@gmail.com>
6026
6027 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6028
db4f02f2
EZ
60292011-10-28 Eli Zaretskii <eliz@gnu.org>
6030
6031 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6032 <oslsachem@gmail.com> for helping to debug this.
6033
6034 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6035 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6036 (g_b_init_get_glyph_outline_w): New static variables.
6037 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6038 (GetGlyphOutlineW_Proc): New typedefs.
6039 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6040 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6041 New functions.
6042 (w32font_open_internal, compute_metrics):
6043 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6044 instead of calling the "wide" APIs directly.
6045
6046 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6047
6048 * w32.h (syms_of_w32font): Add prototype.
6049
87e68db4
JB
60502011-10-27 Juanma Barranquero <lekktu@gmail.com>
6051
6052 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6053 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6054 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6055 (Fmove_to_window_line): Doc fix.
6056
435c1d67
CY
60572011-10-27 Chong Yidong <cyd@gnu.org>
6058
6059 * process.c (make_process): Set gnutls_state to NULL.
6060
6061 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6062 non-NULL, regardless of GNUTLS_INITSTAGE.
6063 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6064 an error. Set process slots as soon as we allocate them.
6065
6066 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6067
9c6c6f49
CY
60682011-10-27 Chong Yidong <cyd@gnu.org>
6069
9aba6043
SM
6070 * gnutls.c (emacs_gnutls_deinit): New function.
6071 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6072 (Fgnutls_deinit, Fgnutls_boot): Use it.
6073
6074 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6075 (deactivate_process): Call emacs_gnutls_deinit.
6076
657d08d3
JB
60772011-10-27 Juanma Barranquero <lekktu@gmail.com>
6078
6079 * image.c (x_create_x_image_and_pixmap):
6080 * w32.c (sys_rename, w32_delayed_load):
6081 * w32font.c (fill_in_logfont):
6082 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6083
5430d399
JB
60842011-10-26 Juanma Barranquero <lekktu@gmail.com>
6085
6086 * w32fns.c (w32_default_color_map): New function,
6087 extracted from Fw32_default_color_map.
a7ef684b 6088 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6089
fe0055fa
PE
60902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6091
6092 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6093
e6346438
SM
60942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6095
6096 * keyboard.c (test_undefined): New function (bug#9751).
6097 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6098
e112cc37
ET
60992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6100
6101 * sysdep.c (init_sys_modes): Fix the check for the controlling
6102 terminal (Bug#6649).
6103
7b5d6677
EZ
61042011-10-20 Eli Zaretskii <eliz@gnu.org>
6105
6106 * dispextern.h (struct bidi_it): New member next_en_type.
6107
6108 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6109 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6110 current character, check also for next_en_type being WEAK_EN.
6111 (bidi_resolve_weak): Don't enter the expensive loop if the current
6112 position is before next_en_pos. Record the bidi type of the first
6113 non-ET, non-BN character we find, in addition to its position.
6114 (bidi_level_of_next_char): Invalidate next_en_type when
6115 next_en_pos is over-stepped.
6116
7da0b018
PE
61172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6118
6119 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6120 * editfns.c: Rewrite current-time-zone so that it invokes
6121 the equivalent of (format-time-string "%Z") to get the time zone name.
6122 This fixes a bug when the time zone name contains characters that
6123 need converting from the system time locale to Emacs internal format.
6124 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6125 that patch fixed format-time-string to do the conversion, but
6126 I forgot to fix current-time-zone.
6127 (format_time_string): New function, containing most of
6128 what Fformat_time_string used to contain.
6129 (Fformat_time_string): Rewrite in terms of format_time_string.
6130 This doesn't change this function's behavior.
6131 (current-time-zone): Rewrite to use format_time_string.
6132 This fixes the bug reported by Michael Schierl in
6133 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6134 Jason Rumney's 2007-06-07 change worked around this bug, but
6135 didn't fix it.
6136 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6137
8547b010
EZ
61382011-10-19 Eli Zaretskii <eliz@gnu.org>
6139
6140 * xdisp.c (start_display): If the character at POS is displayed
6141 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6142 (try_window_reusing_current_matrix): If a line ends in a display
6143 vector or the next line starts in a display vector, continue
6144 redrawing the window even though the character position of
6145 start_row was reached.
8547b010
EZ
6146 (Bug#9771, part 2)
6147
4e948d15
CY
61482011-10-18 Chong Yidong <cyd@gnu.org>
6149
6150 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6151 with nobreak-char-display too.
6152
4787455f
EZ
61532011-10-18 Eli Zaretskii <eliz@gnu.org>
6154
6155 Fix part 3 of bug#9771.
6156 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6157 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6158 non-neutral characters if the current character is a paragraph
6159 separator (a.k.a. Newline). This avoids running the same
6160 expensive loop twice, once when we consume the preceding newline
6161 and the other time when the line actually needs to be displayed.
6162 Avoid the loop when we see neutrals on the base embedding level
6163 following a character whose directionality is the same as the
6164 paragraph's. This avoids running the expensive loop when a line
6165 ends in a long sequence of neutrals, like control characters.
6166 Add assertion against STRONG_AL type. Slightly rearrange code
6167 that determines the type of a neutral given the first non-neutral
6168 that follows it.
6169 (bidi_level_of_next_char): Set next_en_pos to zero when
6170 invalidating its info.
6171
2c91f553
EZ
61722011-10-17 Eli Zaretskii <eliz@gnu.org>
6173
6174 * xdisp.c (push_display_prop): Determine whether to record string
6175 or buffer position by IT->string, not by IT->method. Allow
6176 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6177 (move_it_vertically_backward): Don't look for character position
6178 immediately after the newline when in a continuation line.
6179 (Bug#9771, part 1)
2c91f553 6180
c7b08b0d
MR
61812011-10-15 Martin Rudalics <rudalics@gmx.at>
6182
6183 * window.c (coordinates_in_window): Rewrite and delabelize
6184 vertical border check. (Bug#5357) (Bug#9618)
6185
6b02f655
SM
61862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6187
6188 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6189 errors in XSetWindowBorder (bug#9310).
6190
81d40c92
DA
61912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6192
6193 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6194 avoid crash when xmalloc overrun checking is enabled.
6195
d4172c3b
EZ
61962011-10-13 Eli Zaretskii <eliz@gnu.org>
6197
6198 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6199 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6200 cursor motion with <left> and <right> arrow keys.
6201
6202 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6203 some callers set that themselves.
6204
b00eea75
EZ
62052011-10-12 Eli Zaretskii <eliz@gnu.org>
6206
6207 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6208 display string and the previous row comes from the same string and
6209 is empty. (Bug#9739) (Bug#9738)
6210
8fe012c4
SM
62112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6212
6213 * doc.c (get_doc_string): Encode file name (bug#9735).
6214
0074aef2
EZ
62152011-10-12 Eli Zaretskii <eliz@gnu.org>
6216
79beb178
EZ
6217 * bidi.c (bidi_level_of_next_char):
6218 * xdisp.c (get_visually_first_element): Remove old incorrect
6219 comments regarding the Unicode Line Separator character.
6220
0074aef2
EZ
6221 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6222
6e4b3fbe
DA
62232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6224
6225 * alloc.c (Fgc_status): Do not access beyond zombies array
6226 boundary if nzombies > MAX_ZOMBIES.
6227 * alloc.c (dump_zombies): Add missing format specifier.
6228
0324f3af
PE
62292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6230
b5525cac
PE
6231 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6232 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6233
0324f3af
PE
6234 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6235 Some packages use them to denote characters with modifiers.
6236
e9b5f888
AS
62372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6238
6239 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6240 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6241 matching a pp-number. Rename parameter var to var1.
6242
127827c0
SM
62432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6244
6245 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6246
c8fd3bd0
GM
62472011-10-08 Glenn Morris <rgm@gnu.org>
6248
6249 * callint.c (Fcall_interactively): Give a more explicit error for the
6250 'c' case with a non-character input. (Bug#8479)
6251
352ec8ff
EZ
62522011-10-08 Eli Zaretskii <eliz@gnu.org>
6253
03669ccb
EZ
6254 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6255 lines.
7061c986
EZ
6256 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6257 lines that are hscrolled on the left.
03669ccb 6258
352ec8ff
EZ
6259 * dispnew.c (buffer_posn_from_coords): Account for a possible
6260 presence of header-line. (Bug#4426)
6261
a66cfb1c
SM
62622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6263
6b02f655
SM
6264 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6265 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6266
7c5ee88e
PE
62672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6268
6269 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6270 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6271 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6272 this makes Emacs dump core during garbage collection on rare
6273 occasions. sizeof is obviously inferior to offsetof here, so
6274 stick with offsetof.
6275 (GC_POINTER_ALIGNMENT): New macro.
6276 (mark_memory): Omit 3rd (offset) arg; caller changed.
6277 Don't assume EMACS_INT alignment is the same as pointer alignment.
6278
df1bbe5b
SM
62792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6280
6281 * keyboard.c (read_key_sequence_remapped): New var.
6282 (read_key_sequence): Compute remapping in the right buffer.
6283 (command_loop_1): Use read_key_sequence's remapping directly.
6284
51553db6
SM
62852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6286
32c1fffd
SM
6287 * dired.c (file_name_completion): Don't expand file name.
6288 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6289 before checking file name handler.
6290
51553db6
SM
6291 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6292 they've been requested explicitly (bug#9591).
6293
b6bd1599 62942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6295
6296 * keymap.c (Fsingle_key_description): Use make_specified_string
6297 instead of build_string to build string from push_key_description.
6298 (Bug#5193)
6299
f701dc2a
PE
63002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6301
4222c55d
PE
6302 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6303 This fixes a Y2038 bug on 64-bit hosts.
6304 * buffer.c (reset_buffer):
6305 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6306 (Fclear_buffer_auto_save_failure):
6307 Use 0, not -1, to represent an unset failure time, since time_t
6308 might not be signed.
6309
f701dc2a
PE
6310 Remove dependency on glibc malloc internals.
6311 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6312 Move back here from lisp.h, but with their new implementations.
6313 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6314 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6315 * charset.c (charset_table_init): New static var.
6316 (syms_of_charset): Use it instead of xmalloc. This removes a
6317 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6318 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6319 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6320 Move back to alloc.c.
6321 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6322 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6323
9ceebf39
JD
63242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6325
6326 * nsterm.m (windowDidResize): Call x_set_window_size only when
6327 ns_in_resize is true. Otherwise set pixelwidth/height and
6328 call change_frame_size (Bug#9628).
6329
cb993c58
PE
63302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6331
3930c88b
PE
6332 Port --enable-checking=all to Fedora 14 x86-64.
6333 * charset.c (syms_of_charset): Also account for glibc malloc's
6334 internal overhead when calculating the initial malloc maximum.
6335
cb993c58
PE
6336 Port --enable-checking=all to Fedora 14 x86.
6337 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6338 Move to lisp.h.
6339 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6340 (overrun_check_realloc, overrun_check_free):
6341 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6342 That way, xmalloc returns a properly-aligned pointer even if
6343 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6344 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6345 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6346 into account when calculating the initial malloc maximum.
6347 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6348 Move here from alloc.c, so that charset.c can use it too.
6349 Properly align; the old code wasn't right for common 32-bit hosts
6350 when configured with --enable-checking=all.
6351 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6352 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6353
31bed486
EZ
63542011-09-29 Eli Zaretskii <eliz@gnu.org>
6355
04c70788 6356 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6357 use EDOM.
6358
fbcaa2f3
EZ
63592011-09-28 Eli Zaretskii <eliz@gnu.org>
6360
6361 * xdisp.c (compute_display_string_end): If there's no display
6362 string at CHARPOS, return -1.
6363
6364 * bidi.c (bidi_fetch_char): When compute_display_string_end
6365 returns a negative value, treat the character as a normal
6366 character not covered by a display string. (Bug#9624)
6367
a239d4e9
JB
63682011-09-28 Juanma Barranquero <lekktu@gmail.com>
6369
6370 * lread.c (Fread_from_string): Fix typo in docstring.
6371
88652fd5
EZ
63722011-09-27 Eli Zaretskii <eliz@gnu.org>
6373
6374 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6375 newline, reseat the iterator instead of bidi-iterating there one
6376 character at a time. (Bug#9610)
32c1fffd
SM
6377 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6378 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6379
ed497dd4
AS
63802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6381
6382 * lread.c (readevalloop): Use correct code for NBSP.
6383 (read1): Likewise. (Bug#9608)
6384
b2bf61aa
MA
63852011-09-25 Michael Albinus <michael.albinus@gmx.de>
6386
6387 * dbusbind.c (Fdbus_register_signal): When service is not
6388 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6389
32bbb17c
GM
63902011-09-25 Glenn Morris <rgm@gnu.org>
6391
6392 * buffer.c (truncate-lines): Doc fix.
6393
94e0933e
CY
63942011-09-24 Chong Yidong <cyd@stupidchicken.com>
6395
6396 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6397 (Fset_window_next_buffers): Doc fix.
6398
cddde921
GM
63992011-09-24 Glenn Morris <rgm@gnu.org>
6400
6401 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6402
1260aef1
PE
64032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6404
25b4bfa0
PE
6405 Fix minor problems found by static checking.
6406 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6407 * indent.c (Fvertical_motion): Fix == vs = typo.
6408
e3cbd34b
EZ
64092011-09-24 Eli Zaretskii <eliz@gnu.org>
6410
a66cfb1c
SM
6411 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6412 Default value is now t. Doc fix.
6bf7006f 6413
e3cbd34b 6414 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6415 logic when moving up, not only when moving down. Fix the
e3cbd34b 6416 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6417 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6418
6419 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6420 CHARPOS is covered by a display string which includes newlines.
6421 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6422 is covered by a display string with embedded newlines.
6423
a3de0cbd
MA
64242011-09-24 Michael Albinus <michael.albinus@gmx.de>
6425
6426 * dbusbind.c (Fdbus_register_signal): Add match rule to
6427 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6428 (Fdbus_register_method, Vdbus_registered_objects_table):
6429 Fix docstring.
a3de0cbd 6430
b260039d
JM
64312011-09-24 Jim Meyering <meyering@redhat.com>
6432
32c1fffd 6433 do not ignore write error for any output size
b260039d
JM
6434 The previous change was incomplete.
6435 While it makes emacs --batch detect the vast majority of stdout
6436 write failures, errors were still ignored whenever the output size is
6437 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6438 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6439 && echo FAIL: ignored write error
6440 FAIL: ignored write error
6441 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6442 && echo FAIL: ignored write error
6443 FAIL: ignored write error
6444 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6445
8eca8a7c
AS
64462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6447
6448 * emacs.c (Fkill_emacs): In noninteractive mode exit
6449 non-successfully if a write error occurred on stdout. (Bug#9574)
6450
3341db62
EZ
64512011-09-21 Eli Zaretskii <eliz@gnu.org>
6452
6453 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6454 the xassert test.
6455
6456 * dispextern.h (struct it): Update the comment documenting what
6457 can it->OBJECT be.
6458
8c203dbf
EZ
64592011-09-20 Eli Zaretskii <eliz@gnu.org>
6460
6461 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6462 a display string, extend search for cursor position to end of row.
6463 (find_row_edges): If the row ends in a newline from a display
6464 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6465 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6466 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6467 non-empty line. Fixes confusing cursor motion with arrow keys at
6468 the beginning of a line that starts with whitespace.
8c203dbf 6469
a4824228
LMI
64702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6471
6472 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6473 (bug#9493).
6474
33ed493b
CY
64752011-09-18 Chong Yidong <cyd@stupidchicken.com>
6476
6477 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6478 boolean (Bug#9154).
6479
56cd55c8
EZ
64802011-09-18 Eli Zaretskii <eliz@gnu.org>
6481
6482 * xdisp.c (display_line): Record maximum and minimum buffer
6483 positions even if no glyphs were produced (e.g., by a zero-width
6484 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6485 buffer positions that will be removed from the glyph row because
6486 they don't fit.
c02dcedf
EZ
6487 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6488 column is beyond frame width: don't subtract 1 "pixel" when
6489 computing width of the stretch.
3e62b7e0
EZ
6490 (reseat_at_next_visible_line_start): Undo the change made on
6491 2011-09-17 that saved paragraph information and restored it after
6492 the call to `reseat'. (Bug#9545)
56cd55c8 6493
5ed99d36 64942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6495
6496 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6497 and turn window cursor on if cleared (Bug#9415).
6498
5ed99d36 64992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6500
6501 * search.c (boyer_moore): Take unibyte characters from pattern
6502 literally. (Bug#9458)
6503
9bade7b2
EZ
65042011-09-18 Eli Zaretskii <eliz@gnu.org>
6505
6506 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6507
e5e9d610
PE
65082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6509
87e4427a
PE
6510 Fix minor problem found by static checking.
6511 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6512 initialized, to pacify gcc -Wuninitialized.
6513
e5e9d610
PE
6514 * fileio.c: Report proper errno when syscall falls.
6515 (Finsert_file_contents): Save and restore errno,
6516 so that report_file_error outputs the correct diagnostic.
6517 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6518
a1674f0b
EZ
65192011-09-18 Eli Zaretskii <eliz@gnu.org>
6520
6521 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6522
fbfb6dd4
EZ
65232011-09-17 Eli Zaretskii <eliz@gnu.org>
6524
6525 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6526 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6527
bb187662
EZ
65282011-09-17 Eli Zaretskii <eliz@gnu.org>
6529
1137e8b8 6530 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6531 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6532
6533 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6534 (bidi_find_paragraph_start): Search back for paragraph beginning
6535 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6536 (bidi_move_to_visually_next): Only trigger paragraph-related
6537 computations when the last character is a newline or at EOB, not
6538 just any NEUTRAL_B. (Bug#9470)
6539
bb187662
EZ
6540 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6541 truncated lines if point is covered by a display string. (Bug#9524)
6542
2e621251
PE
65432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6544
6545 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6546 (cons_to_x_long): New function.
6547 (lisp_data_to_selection_data): Use it. Correct the test for
6548 short-versus-long data; it was negated. Break out of vector
6549 loop, for efficiency, when a long datum is discovered.
6550
91a15bc6
SM
65512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6552
6553 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6554
b41c3a35
EZ
65552011-09-16 Eli Zaretskii <eliz@gnu.org>
6556
6557 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6558 GCC PR/17406) by declaring this function with external scope.
6559
7812ba2d
PE
65602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6561
6562 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6563 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6564
cf7edc2a
AS
65652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6566
6567 * editfns.c (Fformat): Correctly handle text properties on "%%".
6568
bd01620e
EZ
65692011-09-15 Eli Zaretskii <eliz@gnu.org>
6570
6571 * xterm.c (x_draw_composite_glyph_string_foreground):
6572 * w32term.c (x_draw_composite_glyph_string_foreground):
6573 * term.c (encode_terminal_code):
6574 * composite.c (composition_update_it, get_composition_id):
6575 * xdisp.c (get_next_display_element)
6576 (fill_composite_glyph_string): Add comments about special meaning
6577 of TAB characters in a composition.
6578
a02719a3
PE
65792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6580
6581 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6582 This occurs when processing a multibyte format.
6583 Problem reported by Wolfgang Jenker.
a02719a3 6584
72589a3c
JB
65852011-09-15 Johan Bockgård <bojohan@gnu.org>
6586
6587 * xdisp.c (try_cursor_movement): Only check for exact match if
6588 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6589
1c14176c
PE
65902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6591
6592 Remove unused external symbols.
6593 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6594 * xdisp.c (calc_pixel_width_or_height): Now static.
6595 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6596 * indent.c (check_display_width):
6597 * w32term.c: Fix comment to match code.
6598 * xterm.c, xterm.h (x_catching_errors): Remove.
6599
d2eea5b5
PE
66002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6601
6602 * xselect.c: Use signed conversions more consistently (Bug#9498).
6603 (selection_data_to_lisp_data): Assume incoming selection data are
6604 signed integers, not unsigned. This is to be consistent with
6605 outgoing selection data, which was modified to use signed integers
6606 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6607 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6608 expects long, not unsigned long.
6609
46888499
EZ
66102011-09-14 Eli Zaretskii <eliz@gnu.org>
6611
6612 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6613 computation of loop end. Reported by Johan Bockgård
6614 <bojohan@gnu.org>.
6615
ef8ef9fb
CY
66162011-09-13 Chong Yidong <cyd@stupidchicken.com>
6617
6618 * frame.c (Fother_visible_frames_p): Function deleted.
6619
fa819fed
EZ
66202011-09-12 Eli Zaretskii <eliz@gnu.org>
6621
6622 * indent.c (compute_motion): Process display vector front to back
6623 rather than the other way around. (Bug#2496)
6624
2ba8e008
SM
66252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6626
6627 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6628
20f53c69
CY
66292011-09-11 Chong Yidong <cyd@stupidchicken.com>
6630
6631 * minibuf.c (Fread_from_minibuffer): Doc fix.
6632
d562d7a4
EZ
66332011-09-11 Eli Zaretskii <eliz@gnu.org>
6634
6635 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6636 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6637
1c4d7f3d
LMI
66382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6639
6640 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6641 value for non-existent files.
6642
b885bf36
EZ
66432011-09-11 Eli Zaretskii <eliz@gnu.org>
6644
6645 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6646 set its "size" to -1. This will set the modtime_size field of
6647 the corresponding buffer to -1, which is what
6648 verify-visited-file-modtime expects for files that do not exist.
6649 (Bug#9139)
6650
6612f0bf
PE
66512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6652
6653 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6654 here ...
6655 * lisp.h: ... from here. push_key_description is no longer
6656 defined in keyboard.c, so its declaration should not be in
6657 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6658 logically belongs with push_key_description.
6659
dfb3f755
PE
66602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6661
6662 * buffer.h: Include <sys/types.h> instead of <time.h>.
6663 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6664 Problem reported by Herbert J. Skuhra.
6665
3134906c
LMI
66662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6667
6668 * xml.c (parse_region): Make the parsing work for
6669 non-comment-starting XML files again (bug#9144).
6670
8d903f4e
AS
66712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6672
6673 * image.c (gif_load): Fix calculation of bottom and right corner.
6674 (Bug#9468)
6675
80ad64f4
EZ
66762011-09-10 Eli Zaretskii <eliz@gnu.org>
6677
6678 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6679 redisplay in small windows.
6680
208a048d
EZ
66812011-09-09 Eli Zaretskii <eliz@gnu.org>
6682
6683 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6684
9b1c252e
MR
66852011-09-08 Martin Rudalics <rudalics@gmx.at>
6686
6687 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6688 Operate on live windows only.
6689
2949f33b
JB
66902011-09-08 Juanma Barranquero <lekktu@gmail.com>
6691
6692 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6693
e08dcafd
EZ
66942011-09-07 Eli Zaretskii <eliz@gnu.org>
6695
6696 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6697 only under bidi iteration.
6698
115b96bd
JD
66992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6700
6701 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6702
c8199d0f
PE
67032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6704
6705 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6706 Without this fix, the command to link temacs failed due to an
6707 undefined symbol __builtin_isnan. This is because
6708 /usr/include/iso/math_c99.h #defines isnan(x) to
6709 __builtin_isnan(x), but the bundled gcc, which identifies itself
6710 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6711 a __builtin_isnan.
6712 * floatfns.c (isnan): #undef, and then #define to a clone of
6713 what's in data.c.
6714 (Fisnan): Always define, since it's always available now.
6715 (syms_of_floatfns): Always define isnan at the Lisp level.
6716
e39b275c 67172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6718
6719 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6720
b2db44d9 67212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6722
f4af5137 6723 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6724 The previous code assumed that file offsets (off_t values) fit in
6725 EMACS_INT variables, which is not true on typical 32-bit hosts.
6726 The code messed up by falsely reporting buffer overflow in cases
6727 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6728 when "big" contains more than 2**29 bytes, even though this
6729 inserts just one byte and does not overflow the buffer.
6730 (Finsert_file_contents): Store file offsets as off_t
6731 values, not as EMACS_INT values. Check for overflow when
6732 converting between EMACS_INT and off_t. When checking for
6733 buffer overflow or for overlap, take the offsets into account.
6734 Don't use EMACS_INT for small values where int suffices.
6735 When checking for overlap, fix a typo: ZV was used where
6736 ZV_BYTE was intended.
6737 (Fwrite_region): Don't assume off_t fits into 'long'.
6738 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6739
ecfc0a49
MA
67402011-09-05 Michael Albinus <michael.albinus@gmx.de>
6741
6742 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6743
6511acf2 67442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6745
0999621a 6746 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6747
6748 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6749 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6750 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6751 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6752 (modify_event_symbol): Do not assume that the length of
6753 name_alist_or_stem is safe to alloca and fits in int.
6754 (Fexecute_extended_command): Likewise for function name and binding.
6755 (Frecursion_depth): Wrap around reliably on integer overflow.
6756 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6757 since some callers pass EMACS_INT values.
6758 (Fsingle_key_description): Don't crash if symbol name contains more
6759 than MAX_ALLOCA bytes.
6760 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6761 (get_minibuffer): Arg is now EMACS_INT, not int.
6762 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6763 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6764 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6765
2be7d702
PE
6766 * dbusbind.c (signature_cat): New function.
6767 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6768 Do not overrun buffer; instead, report string overflow.
6769
9d1df220
PE
6770 * dispnew.c (add_window_display_history): Don't overrun buffer.
6771 Truncate instead; this is OK since it's just a log.
6772
33ef5c64
PE
6773 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6774 even if the time zone offset is outlandishly large.
6775 Don't mishandle offset == INT_MIN.
6776
66c6fdd5
PE
6777 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6778 when creating daemon; the previous buffer-overflow check was incorrect.
6779
d749b01b
PE
6780 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6781 which has the guts of the old verror function.
6782
b5cd1905
PE
6783 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6784 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6785
6e1a67fb
PE
6786 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6787 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6788 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6789 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6790 length of string rather than counting it via multiple sprintfs;
6791 that's simpler and more reliable.
c21721cc
PE
6792 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6793 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6794 sprintf, in case result does not fit in int.
6795
c57b67fc
PE
6796 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6797 (fontset_from_font): Print it.
6798
8a401434
PE
6799 * frame.c (tty_frame_count): Now printmax_t, not int.
6800 (make_terminal_frame, set_term_frame_name): Print it.
6801 (x_report_frame_params): In X, window IDs are unsigned long,
6802 not signed long, so print them as unsigned.
6803 (validate_x_resource_name): Check for implausibly long names,
6804 and don't assume name length fits in 'int'.
6805 (x_get_resource_string): Don't blindly alloca invocation name;
6806 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6807 not fit in int.
6808
6e1a67fb
PE
6809 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6810 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6811 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6812
0df02bf3
PE
6813 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6814 Use esprintf, not sprintf, in case result does not fit in int.
6815
48e30793
PE
6816 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6817 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6818 it as a large positive number.
6819 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6820 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6821
a66ff6d8
PE
6822 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6823 in case result does not fit in int.
6824
aca216ff
PE
6825 * print.c (float_to_string): Detect width overflow more reliably.
6826 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6827 buffer overrun. Don't assume list length fits in 'int'. Treat
6828 print length of 0 as 0, not as infinity; to be consistent with other
6829 uses of print length in this function. Don't overflow print length
6830 index. Don't assume hash table size fits in 'long', or that
6831 vectorlike size fits in 'unsigned long'.
6832
31c286f7
PE
6833 * process.c (make_process): Use printmax_t, not int, to format
6834 process-name gensyms.
6835
55e5faa1
PE
6836 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6837
80f2e268
PE
6838 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6839 to avoid potential buffer overrun.
6840
670741ab
PE
6841 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6842 if X resource line is longer than 512 bytes.
6843
b7163a50
PE
6844 * xfns.c (x_window): Make sprintf buffer a bit bigger
6845 to avoid potential buffer overrun.
6846
ae58ff1f
PE
6847 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6848
c43c8a6a
PE
6849 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6850
3f8236f4
PE
68512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6852
53e9fe90 6853 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6854 Without these, Emacs silently mishandles large integers sometimes.
6855 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6856 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6857
6511acf2
PE
6858 * xdisp.c (try_window_id): Check Emacs fixnum range before
6859 converting to 'int'.
806add1d 6860
6511acf2 6861 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6862 Check that an Emacs fixnum is in range before assigning it to 'int'.
6863 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6864 values converted from Emacs fixnums.
6865 (Frecenter): Don't wrap around a line count if it is out of 'int'
6866 range; instead, treat it as an extreme value.
6867 (Fset_window_configuration, compare_window_configurations):
6868 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6869
6511acf2
PE
6870 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6871 that can exceed INT_MAX. Check that EMACS_INT value is in range
6872 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6873 (match_limit): Don't assume that a fixnum can fit in 'int'.
6874
6511acf2 6875 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6876 exceed INT_MAX.
6877
6511acf2 6878 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6879 (Fvertical_motion): Don't wrap around LINES values that don't fit
6880 in 'int'. Instead, treat them as extreme values. This is good
6881 enough for windows, which can't have more than INT_MAX lines anyway.
6882
fcb901a7
LMI
68832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6884
0f2f6b6d
LMI
6885 * Require libxml/parser.h to avoid compilation warning.
6886
fcb901a7
LMI
6887 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6888
6889 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6890 since this reportedly can destroy thread storage.
6891
6e20a0d4
CY
68922011-08-30 Chong Yidong <cyd@stupidchicken.com>
6893
6894 * syntax.c (find_defun_start): Update all cache variables if
6895 exiting early (Bug#9401).
6896
148ae00e
EZ
68972011-08-30 Eli Zaretskii <eliz@gnu.org>
6898
f6cfbd8f
EZ
6899 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6900
148ae00e
EZ
6901 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6902 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6903 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6904
6905 * term.c (tty_append_glyph): New function.
6906 (produce_stretch_glyph): Static function and its prototype deleted.
6907
a66cfb1c
SM
6908 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6909 Add prototypes.
148ae00e 6910
c4a07a4c
PE
69112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6912
6913 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6914 when checking :margin (Bug#9390).
6915 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6916 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6917 so that the name doesn't mislead. All uses changed.
6918
6bc8cd65
JB
69192011-08-28 Johan Bockgård <bojohan@gnu.org>
6920
6921 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6922 set_tty_hooks.
6923
dca4927e
EZ
69242011-08-27 Eli Zaretskii <eliz@gnu.org>
6925
6926 * xdisp.c (move_it_to): Don't bail out early when reaching
6927 position beyond to_charpos, if we are scanning backwards.
6928 (move_it_vertically_backward): When DY == 0, make sure we get to
6929 the first character in the line after the newline.
6930
f2cad773
PE
69312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6932
6933 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6934 (ccl_driver): Do not generate an out-of-range pointer.
6935 (Fccl_execute_on_string): Remove unnecessary check for
6936 integer overflow, noted by Stefan Monnier in
6937 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6938 Remove a FIXME that didn't need fixing.
6939 Simplify the newly-introduced buffer reallocation code.
6940
0cae2cdb
JB
69412011-08-27 Juanma Barranquero <lekktu@gmail.com>
6942
6943 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6944
5fc295a4 69452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6946
70c60eb2 6947 Integer and memory overflow issues (Bug#9196).
726e0ab1 6948
d31850da
PE
6949 * doc.c (get_doc_string): Rework so that
6950 get_doc_string_buffer_size is the actual buffer size, rather than
6951 being 1 less than the actual buffer size; this makes xpalloc more
6952 convenient.
6953
a69fbedb
PE
6954 * image.c (x_allocate_bitmap_record, cache_image):
6955 * xselect.c (Fx_register_dnd_atom):
6956 Simplify previous changes by using xpalloc.
6957
fe5c5d37
PE
6958 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6959 since either will do and ptrdiff_t is convenient with xpalloc.
6960
0065d054
PE
6961 * charset.c (charset_table_size)
6962 (struct charset_sort_data.priority): Now ptrdiff_t.
6963 (charset_compare): Don't overflow if priorities differ greatly.
6964 (Fsort_charsets): Don't assume list length fits in int.
6965 Check for size-calculation overflow when allocating sort data.
6966 (syms_of_charset): Allocate an initial charset table that is
6967 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6968
6969 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6970
6971 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6972 The actual value is always <= INT_MAX, and leaving it unsigned made
6973 overflow checking harder.
6974
6975 * dispextern.h (struct glyph_matrix.rows_allocated)
6976 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6977 with xpalloc. The values are still always <= INT_MAX.
6978
6979 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6980
6981 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6982 (SAFE_NALLOCA): New macro.
6983
6984 * region-cache.c (struct boundary.pos, find_cache_boundary)
6985 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6986 (set_cache_region, invalidate_region_cache)
6987 (revalidate_region_cache, know_region_cache, region_cache_forward)
6988 (region_cache_backward, pp_cache):
6989 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6990 so that ptrdiff_t * can be passed to xpalloc.
6991 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6992 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6993 (pp_cache): Don't assume cache_len fits in int.
6994 * region-cache.h: Adjust extern decls to match.
6995
6996 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6997 EMACS_INT, since either will do, for xpalloc.
6998
6999 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7000 (xnmalloc, xnrealloc, xpalloc): New functions.
7001
726e0ab1
PE
7002 * bidi.c (bidi_shelve_header_size): New constant.
7003 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7004 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7005
51f30bc5 7006 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7007 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7008 (overlay_strings):
7009 Don't update size of array until after memory allocation succeeds,
7010 because xmalloc/xrealloc may not return.
0065d054
PE
7011 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7012 now that we have proper integer overflow checking.
7013 (record_overlay_string, overlay_strings): Catch overflows when
7014 calculating size of overlay_str_buf.
726e0ab1 7015
0065d054
PE
7016 * callproc.c (Fcall_process): Check for size overflow when
7017 calculating size of args2.
7018 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7019 Normally we prefer signed values, but sticking with ptrdiff_t would
7020 require adding more-complicated checks.
726e0ab1
PE
7021
7022 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7023 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7024 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7025 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7026
7027 * character.c (Fstring): Check for size-calculation overflow.
7028
7029 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7030 unnecessary integer overflow. Check for size overflow.
7031 (encode_coding_object): Don't update size until xmalloc succeeds.
7032
7033 * composite.c (get_composition_id): Check for overflow in glyph
7034 length calculations.
7035
7036 Integer and memory overflow fixes for display code.
7037 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7038 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7039 (scrolling_window): Check for overflow in size calculations.
7040 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7041 Don't assume glyph table len fits in int.
7042 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7043 (row_table_size): Now ptrdiff_t, not int.
7044 (scrolling_window): Avoid overflow in size calculations.
7045 Don't update size until allocation succeeds.
7046 * fns.c (concat): Check for overflow in size calculations.
7047 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7048 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7049 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7050
7051 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7052 (get_doc_string): Check for size calculation overflow.
7053 Don't update size until allocation succeeds.
7054 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7055 EMACS_INT, where ptrdiff_t will do.
7056 (Fsubstitute_command_keys): Check for string overflow.
7057
7058 * editfns.c (set_time_zone_rule): Don't assume environment length
7059 fits in int.
7060 (message_length): Now ptrdiff_t, not int.
7061 (Fmessage_box): Don't update size until allocation succeeds.
7062 Don't assume message length fits in int.
7063 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7064
0065d054
PE
7065 * emacs.c (main): Do not reallocate argv, since there is a null at
7066 the end that can be overwritten, and this way there's no need to
7067 worry about size-calculation overflow.
7068 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7069
7070 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7071 alloc succeeds.
7072 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7073
7074 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7075 (x_set_scroll_bar_width, x_figure_window_size):
7076 Check for integer overflow.
7077 (x_set_alpha): Do not assume XINT fits in int.
7078
7079 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7080 This is for the members text_lines, text_cols, total_lines, total_cols,
7081 where the system imposes an 'int' limit.
7082
7083 * fringe.c (Fdefine_fringe_bitmap):
7084 Don't update size until alloc works.
7085
7086 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7087 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7088
7089 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7090 Check for size-calculation overflow.
7091 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7092 do, as we prefer signed integers.
7093 (id_to_widget.max_size, id_to_widget.used)
7094 (xg_store_widget_in_map, xg_remove_widget_from_map)
7095 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7096 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7097 Use and return ptrdiff_t, not int.
7098 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7099 * gtkutil.h: Change prototypes to match the above.
7100
7101 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7102 are duplicate now that they've been promoted to lisp.h.
7103 (x_allocate_bitmap_record, x_alloc_image_color)
7104 (make_image_cache, cache_image, xpm_load):
7105 Don't update size until alloc is done.
7106 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7107 (x_detect_edges):
3256efce 7108 Check for size calculation overflow.
726e0ab1
PE
7109 (ct_colors_allocated_max): New constant.
7110 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7111 overflow.
3256efce 7112
726e0ab1
PE
7113 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7114 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7115 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7116 Use ptrdiff_t, not int, to count maps.
7117 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7118 calculations. Don't update size until allocation succeeds.
7119 Redo calculations to avoid overflow.
726e0ab1
PE
7120 * keyboard.h: Change prototypes to match the above.
7121
7122 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7123 to count maps.
7124 (current_minor_maps): Check for size calculation overflow.
7125 * keymap.h: Change prototypes to match the above.
7126
7127 * lread.c (read1, init_obarray): Don't update size until alloc done.
7128
7129 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7130 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7131
726e0ab1
PE
7132 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7133 Now ptrdiff_t, not int.
7134 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7135 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7136
7137 * process.c (Fnetwork_interface_list): Check for overflow
7138 in size calculation.
7139
7140 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7141
7142 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7143 overflow. Don't bother calling xmalloc when xrealloc will do.
7144
7145 * search.c (Freplace_match): Check for size calculation overflow.
7146 (Fset_match_data): Don't assume list lengths fit in 'int'.
7147
7148 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7149 for command line length. Do not attempt to address one before the
7150 beginning of an array, as that's not portable.
7151
7152 * term.c (max_frame_lines): Remove; unused.
7153 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7154 not int.
7155 (encode_terminal_code, calculate_costs): Check for size
7156 calculation overflow.
7157 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7158 table lengths and related sizes. Don't update size until alloc
7159 done. Redo calculations to avoid overflow.
7160 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7161
7162 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7163 subtracting pointers.
7164 (gobble_line): Check for overflow more carefully. Don't update size
7165 until alloc done.
7166
7167 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7168 Don't update size until alloc done.
7169 Redo size calculations to avoid overflow.
7170 Check for size calculation overflow.
0065d054 7171 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7172
7173 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7174 Use ptrdiff_t, not int, for sizes.
7175 (store_mode_line_noprop_char): Don't update size until alloc done.
7176
0065d054
PE
7177 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7178 Use ptrdiff_t, not int, for sizes.
7179 (Finternal_make_lisp_face, cache_face):
7180 Check for size calculation overflow.
7181 (cache_face): Treat size calculation overflows as if they were
7182 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7183
7184 * xfns.c (x_encode_text, x_set_name_internal)
7185 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7186 sizes, since they can exceed INT_MAX in size. Check for size
7187 calculation overflow.
7188
0065d054
PE
7189 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7190 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7191 Don't update size until alloc done.
7192
0065d054 7193 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7194 as sprintf is limited to int lengths.
1d526e2f 7195
252c5ee1
PE
7196 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7197 (X_LONG_MIN): New macros.
864d7ce7
PE
7198 Use them to make the following changes clearer.
7199 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7200 This change doesn't affect the value now, but it may help remind
7201 future maintainers not to raise the value too much later.
7202 (SELECTION_QUANTUM): Remove, replacing with ...
7203 (selection_quantum): ... new function, which avoids overflow.
7204 All uses changed.
7205 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7206 assumption that selection length fits in 'int'.
7207 (x_reply_selection_request, x_handle_selection_request)
7208 (x_get_window_property, receive_incremental_selection)
7209 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7210 (lisp_data_to_selection_data, clean_local_selection_data):
7211 Use ptrdiff_t, not int, to record length of selection.
7212 (x_reply_selection_request, x_get_window_property)
7213 (receive_incremental_selection, x_property_data_to_lisp):
7214 Redo calculations to avoid overflow.
7215 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7216 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7217 something.
7218 (x_get_window_property, receive_incremental_selection)
7219 (lisp_data_to_selection_data, x_property_data_to_lisp):
7220 Check for size-calculation overflow.
7221 (x_get_window_property, receive_incremental_selection)
7222 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7223 Don't store size until memory allocation succeeds.
7224 (x_get_window_property): Plug memory leak on memory exhaustion.
7225 Don't double-block input; malloc is safe here. Don't assume 2**34
7226 - 4 fits in unsigned long. Add an xassert to check
7227 XGetWindowProperty overflow. Be more careful about overflow
7228 calculations, and distinguish size from memory overflow better.
7229 (receive_incremental_selection): When tracing, don't assume
7230 unsigned int is less than INT_MAX.
7231 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7232 harmful) conversions of unsigned short to int.
7233 (lisp_data_to_selection_data): Don't assume that integers
7234 in the range -65535 through -1 fit in an X unsigned short.
7235 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7236 result parameters unless successful. Rely on cons_to_unsigned
7237 to report problems with elements; the old code wasn't right anyway.
7238 (x_check_property_data): Check for int overflow; we cannot use
7239 a wider type due to X limits.
7240 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7241
726e0ab1 7242 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7243
0065d054
PE
7244 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7245 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7246 (x_color_cells): Don't store size until memory allocation succeeds.
7247 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7248 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7249 (x_term_init): Don't assume length fits in int (sprintf is limited
7250 to int size).
bc18e09d 7251
ebfa62c0
PE
7252 Use ptrdiff_t for composition IDs.
7253 * character.c (lisp_string_width):
7254 * composite.c (composition_table_size, n_compositions)
7255 (get_composition_id, composition_gstring_from_id):
7256 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7257 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7258 * window.c (Frecenter):
7259 Use ptrdiff_t, not int, for composition IDs.
7260 * composite.c (get_composition_id): Check for integer overflow.
7261 * composite.h: Adjust prototypes to match the above changes.
7262
d3411f89
PE
7263 Use ptrdiff_t for hash table indexes.
7264 * category.c (hash_get_category_set):
7265 * ccl.c (ccl_driver):
7266 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7267 * coding.c (coding_system_charset_list, detect_coding_system):
7268 * coding.h (struct coding_system.id):
7269 * composite.c (get_composition_id, gstring_lookup_cache):
7270 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7271 * image.c (xpm_get_color_table_h):
7272 * lisp.h (hash_lookup, hash_put):
7273 * minibuf.c (Ftest_completion):
7274 Use ptrdiff_t for hash table indexes, not int (which is too
7275 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7276 32-bit --with-wide-int hosts).
7277
e097a6fa
PE
7278 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7279 Add a FIXME comment about memory leaks.
7280 (syms_of_charset): Don't assume xmalloc returns.
7281
5637687f
PE
7282 Don't assume that stated character widths fit in int.
7283 * character.c (Fchar_width, c_string_width, lisp_string_width):
7284 * character.h (CHAR_WIDTH):
7285 * indent.c (MULTIBYTE_BYTES_WIDTH):
7286 Use sanitize_char_width to avoid undefined and/or bad behavior
7287 with outlandish widths.
a66cfb1c 7288 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7289 now that we have two such functions. All uses changed.
7290 (sanitize_char_width): New inline function.
7291
a2271ba2
PE
7292 Don't assume that tab-width fits in int.
7293 * character.h (sanitize_width): New inline function.
7294 (SANE_TAB_WIDTH): New macro.
7295 (ASCII_CHAR_WIDTH): Use it.
7296 * indent.c (sane_tab_width): Remove. All uses replaced by
7297 SANE_TAB_WIDTH (current_buffer).
7298 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7299
18c52557
PE
7300 * fileio.c: Integer overflow issues with file modes.
7301 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7302
caeeedc1
PE
7303 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7304 Remove unreachable code.
7305 (read_hex, load_charset_map_from_file): Check for integer overflow.
7306
6df6ae42 7307 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7308 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7309 (x_send_scroll_bar_event): Likewise. Check that the size does not
7310 exceed limits imposed by XClientMessageEvent, as well as the usual
7311 ptrdiff_t and size_t limits.
7312
b13995db
PE
7313 * keyboard.c: Overflow, signedness and related fixes.
7314 (make_lispy_movement): Use same integer type in forward decl
7315 that is used in the definition.
7316 (read_key_sequence, keyremap_step):
7317 Change bufsize argument back to int, undoing my 2011-03-30 change.
7318 We prefer signed types, and int is wide enough here.
7319 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7320 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7321 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7322 length, not size_t. Use ptrdiff_t for index, not int.
7323 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7324 possibility of integer overflow.
7325
13464394
PE
7326 Overflow, signedness and related fixes for images.
7327
7328 * dispextern.h (struct it.stack[0].u.image.image_id)
7329 (struct_it.image_id, struct image.id, struct image_cache.size)
7330 (struct image_cache.used, struct image_cache.ref_count):
7331 * gtkutil.c (update_frame_tool_bar):
7332 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7333 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7334 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7335 * nsmenu.m (update_frame_tool_bar):
7336 * xdisp.c (calc_pixel_width_or_height):
7337 * xfns.c (image_cache_refcount):
7338 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7339 on typical 64-bit hosts.
7340
7341 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7342 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7343 Omit unnecessary casts to int.
7344 (parse_image_spec): Check that integers fall into 'int' range
7345 when the callers expect that.
7346 (image_ascent): Redo ascent calculation to avoid int overflow.
7347 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7348 (lookup_image): Remove unnecessary tests.
7349 (xbm_image_p): Locals are now of int, not EMACS_INT,
7350 since parse_image_check makes sure they fit into int.
7351 (png_load, gif_load, svg_load_image):
7352 Prefer int to unsigned where either will do.
7353 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7354 old tiff_error_handler and tiff_warning_handler.
7355 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7356 stack buffer overflows. It uses only the features of vsnprintf
7357 that are common to both POSIX and native Microsoft.
7358 (tiff_error_handler, tiff_warning_handler): Use it.
7359 (tiff_load, gif_load, imagemagick_load_image):
7360 Don't assume :index value fits in 'int'.
7361 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7362 (imagemagick_load_image): Check that crop parameters fit into
7363 the integer types that MagickCropImage accepts. Don't assume
7364 Vimagemagick_render_type has a nonnegative value. Don't assume
7365 size_t fits in 'long'.
7366 (gs_load): Use printmax_t to print the widest integers possible.
7367 Check for integer overflow when computing image height and width.
7368
c11821d4
EZ
73692011-08-26 Eli Zaretskii <eliz@gnu.org>
7370
7371 * xdisp.c (redisplay_window): Don't force window start if point
7372 will be invisible in the resulting window. (Bug#9324)
7373
0c95fcf7
EZ
73742011-08-25 Eli Zaretskii <eliz@gnu.org>
7375
7376 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7377 the display spec is of the form `(space ...)'.
7378 (handle_display_spec): Return the value returned by
7379 handle_single_display_spec, not just 1 or zero.
7380 (handle_single_display_spec): If the display spec is of the form
7381 `(space ...)', and specifies display in the text area, return 2
7382 rather than 1.
fee65a97 7383 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7384 accurately, and prefer exact match for point under bidi.
7385 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7386
7387 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7388 into disp_prop; all users changed.
7389
7390 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7391 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7392 for the text covered by the display property.
7393
e4ed06f1
CY
73942011-08-25 Chong Yidong <cyd@stupidchicken.com>
7395
7396 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7397 Change return value to nil.
7398 (Frecord_buffer): Delete unused function.
7399
f67cdd7f
EZ
74002011-08-24 Eli Zaretskii <eliz@gnu.org>
7401
5980d4c6
EZ
7402 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7403 buffers, return left-to-right.
8610fe8b
EZ
7404 (set_cursor_from_row): Consider candidate row a win if its glyph
7405 represents a newline and point is on that newline. Fixes cursor
7406 positioning on the newline at EOL of R2L text within L2R
7407 paragraph, and vice versa.
7408 (try_cursor_movement): Check continued rows, in addition to
7409 continuation rows. Fixes unwarranted scroll when point enters a
7410 continued line of R2L text within an L2R paragraph, or vice versa.
7411 (cursor_row_p): Consider the case of point being equal to
7412 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7413 from the end of a short line to the beginning of a continued line
7414 of R2L text within L2R paragraph.
7415 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7416 composed characters.
5980d4c6 7417
f67cdd7f
EZ
7418 * bidi.c (bidi_check_type): Use xassert.
7419 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7420 members.
7421
bca633fb
EZ
74222011-08-23 Eli Zaretskii <eliz@gnu.org>
7423
7424 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7425 a character.
7426
4a5885a7
CY
74272011-08-23 Chong Yidong <cyd@stupidchicken.com>
7428
7429 * nsfont.m (ns_otf_to_script): Fix typo.
7430
0902a04e
KH
74312011-08-22 Kenichi Handa <handa@m17n.org>
7432
7433 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7434 extra slot even if the purpose is char-code-property-table.
7435
1a2e6670
EZ
74362011-08-23 Eli Zaretskii <eliz@gnu.org>
7437
8ddde651
EZ
7438 * xdisp.c (redisplay_window): When computing centering_position,
7439 account for the height of the header line. (Bug#8874)
7440
425cc014
EZ
7441 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7442 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7443 candidate is selected by the mouse, and that candidate has a
7444 composed character under the mouse.
7445
1a2e6670
EZ
7446 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7447 coordinates reported by pos-visible-in-window-p for a composed
7448 character in column zero.
7449
8b76d6f8
SM
74502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7451
7452 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7453
dac347dd
EZ
74542011-08-22 Eli Zaretskii <eliz@gnu.org>
7455
7456 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7457 consider it a hit if to_charpos is anywhere in the range of the
7458 composed buffer positions.
7459
e013fb34
CY
74602011-08-22 Chong Yidong <cyd@stupidchicken.com>
7461
7462 * image.c (gif_load): Don't assume that each subimage has the same
7463 dimensions as the base image. Handle disposal method that is
7464 "undefined" by the gif spec (Bug#9335).
7465
bd1ba3e8
CY
74662011-08-20 Chong Yidong <cyd@stupidchicken.com>
7467
7468 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7469 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7470
54a1215b
EZ
74712011-08-19 Eli Zaretskii <eliz@gnu.org>
7472
823564e5
EZ
7473 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7474 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7475 from an Org mode buffer to a Speedbar frame.
7476
54a1215b
EZ
7477 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7478 a composition, take its buffer position from IT->cmp_it.charpos.
7479 Fixes cursor positioning at the beginning of a line that begins
7480 with a composed character.
7481
9778ebcc
EZ
74822011-08-18 Eli Zaretskii <eliz@gnu.org>
7483
0be6ee06
EZ
7484 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7485 character bidirectional type, use STRONG_L instead. Fixes crashes
7486 in a buffer produced by `describe-categories'.
7487
9778ebcc
EZ
7488 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7489 members before the level stack, so they would be saved and
7490 restored when copying iterator state. Fixes incorrect reordering
7491 around TABs covered by display properties.
7492
156bffbe
AS
74932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7494
6b02f655 7495 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7496
72ad093b
CY
74972011-08-17 Chong Yidong <cyd@stupidchicken.com>
7498
7499 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7500 (internal_condition_case_2, internal_condition_case_n):
7501 Remove unnecessary aborts (Bug#9081).
72ad093b 7502
35774242
EZ
75032011-08-17 Eli Zaretskii <eliz@gnu.org>
7504
7505 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7506 has no `load' handler, try opening the file locally. (Bug#9311)
7507
db76dd85
KB
75082011-08-16 Ken Brown <kbrown@cornell.edu>
7509
7510 * gmalloc.c: Expand comment.
7511
b215eee5
EZ
75122011-08-16 Eli Zaretskii <eliz@gnu.org>
7513
7514 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7515 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7516
a4579d33
KB
75172011-08-16 Ken Brown <kbrown@cornell.edu>
7518
7519 Fix memory allocation problems in Cygwin build (Bug#9273).
7520
7521 * unexcw.c ( __malloc_initialized): Declare external variable.
7522 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7523
8b76d6f8
SM
7524 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7525 New variables.
a4579d33
KB
7526 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7527 dumped emacs.
7528 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7529 in the static heap.
7530 [CYGWIN] (special_realloc): New function.
7531 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7532 requests to realloc storage in the static heap.
7533
3ebec551
PE
75342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7535
7536 * bidi.c (bidi_initialize): Remove unused local.
7537
9fd8be00
EZ
75382011-08-15 Eli Zaretskii <eliz@gnu.org>
7539
6b02f655
SM
7540 * bidimirror.h:
7541 * biditype.h: Remove file.
7542 * makefile.w32-in ($(BLD)/bidi.$(O)):
7543 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7544
7545 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7546
7547 * chartab.c: Improve commentary for the uniprop_table API.
7548
32413314
EZ
7549 * bidi.c (bidi_paragraph_init): Support zero value of
7550 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7551 (bidi_initialize): Use uniprop_table instead of including
7552 biditype.h and bidimirror.h.
32413314 7553
9fd8be00
EZ
7554 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7555 coordinates of the iterator when restoring from ppos_it.
7556 (Bug#9296)
7557
5cf2b69b
KH
75582011-08-14 Kenichi Handa <handa@m17n.org>
7559
7560 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7561 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7562
daf17d00
EZ
75632011-08-14 Eli Zaretskii <eliz@gnu.org>
7564
7565 * xdisp.c (move_it_in_display_line_to): Don't invoke
7566 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7567 ppos_it. Fixes vertical cursor motion when line beginning is
7568 covered by an image. (Bug#9296)
7569
08e3161a
JD
75702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7571
7572 * nsterm.h (ns_run_ascript): Declare.
7573 (NSAPP_DATA2_RUNASSCRIPT): Define.
7574
7575 * nsfns.m (as_script, as_result, as_status): New static variables.
7576 (ns_run_ascript): New function.
5e617bc2 7577 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7578 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7579 the event loop. Get status from as_status (Bug#7276).
7580
7581 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7582 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7583 the event loop (Bug#7276).
7584
a3720aa2
AS
75852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7586
7587 * gnutls.c (QCgnutls_bootprop_priority)
7588 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7589 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7590 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7591 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7592 (QCgnutls_bootprop_verify_hostname_error)
7593 (QCgnutls_bootprop_callbacks_verify): Rename from
7594 Qgnutls_bootprop_..., all uses changed.
7595
7596 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7597 uses changed.
7598
0a0d27fb
PE
75992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7600
19d5c50c
PE
7601 * xfaces.c (Qframe_set_background_mode): Now static.
7602 * dispextern.h (Qframe_set_background_mode): Remove decl.
7603
0a0d27fb
PE
7604 * process.c (Fnetwork_interface_info): Declare local only if needed.
7605
377538cb
JD
76062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7607
7608 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7609 (Fnetwork_interface_list): Allocate in increments of bytes instead
7610 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7611 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7612 sockaddr.
7613 (struct ifflag_def): notrailers is smart on OSX.
7614 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7615 Get hardware address with getifaddrs if available.
7616
08fff70c
EZ
76172011-08-12 Eli Zaretskii <eliz@gnu.org>
7618
7619 * xdisp.c (iterate_out_of_display_property): xassert that
7620 IT->position is set to within IT->object's boundaries. Break from
7621 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7622 when IT->position is set up wrongly due to some bug.
7623 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7624 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7625 entry. Force push_it to save on the stack the current
7626 buffer/string position, to be restored by pop_it. Fix flags in
7627 the iterator structure wrt the object coming from a display
7628 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7629 properties. (Bug#9284)
7630
7be1c708 76312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7632
7be1c708
CY
7633 * fontset.c (fontset_get_font_group): Add proper type checks.
7634 (Bug#9172)
aac0c6e3 7635
7be1c708 76362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7637
7be1c708
CY
7638 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7639 and LC_VERSION_MIN_MACOSX.
7640 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7641 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7642
97bb72a6
EZ
76432011-08-08 Eli Zaretskii <eliz@gnu.org>
7644
7645 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7646 no-display-properties-and-no-overlays under bidi display.
7647 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7648 properties and overlays.
97bb72a6 7649
d5617611
CY
76502011-08-08 Chong Yidong <cyd@stupidchicken.com>
7651
37e11a63
CY
7652 * editfns.c (Fset_time_zone_rule): Document relationship with the
7653 setenv function.
7654
d5617611
CY
7655 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7656 the font entity extracted from the cache (Bug#8109).
7657
58872834
CY
76582011-08-07 Chong Yidong <cyd@stupidchicken.com>
7659
7660 * composite.c (autocmp_chars): Don't reset point. That is done by
7661 restore_point_unwind (Bug#5984).
7662
75bfc667
JL
76632011-08-07 Juri Linkov <juri@jurta.org>
7664
7665 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7666 to show the arg `TIME' instead of `TIMEVAL'.
7667
d1410150
EZ
76682011-08-06 Eli Zaretskii <eliz@gnu.org>
7669
7670 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7671 display property strides EOL and includes a newline, as in
7672 longlines-mode. (Bug#9254)
75b771e4
EZ
7673 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7674 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7675
7676 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7677 is non-zero, even if the data buffer is NULL. Fixes a crash in
7678 vertical-motion with longlines-mode. (Bug#9254)
7679
35928349
EZ
76802011-08-05 Eli Zaretskii <eliz@gnu.org>
7681
ec7cc85b
EZ
7682 * bidi.c <bidi_cache_total_alloc>: Now static.
7683 (bidi_initialize): Initialize bidi_cache_total_alloc.
7684
8b76d6f8 7685 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7686 cache. (Bug#9221)
7687
7688 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7689 amount allocated this far in `bidi_cache_total_alloc'.
7690 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7691 non-zero, only free the data buffer without restoring the cache
7692 contents. All callers changed.
7693
7694 * dispextern.h (bidi_unshelve_cache): Update prototype.
7695
7696 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7697 (move_it_in_display_line, move_it_to)
7698 (move_it_vertically_backward, move_it_by_lines): Replace the call
7699 to xfree to an equivalent call to bidi_unshelve_cache.
7700 (move_it_in_display_line_to): Fix logic of returning
412b6358 7701 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7702
e2e2423b
EZ
77032011-08-05 Eli Zaretskii <eliz@gnu.org>
7704
7705 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7706 came from a string character with a `cursor' property. (Bug#9229)
7707
ae9e757a
JD
77082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7709
7710 * Makefile.in (LIB_PTHREAD): New variable.
7711 (LIBES): Add LIB_PTHREAD (Bug#9216).
7712
7713 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7714 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7715
213bd7f2
AS
77162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7717
6b02f655 7718 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7719
99aaf75f
JD
77202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7721
7722 * xterm.c (x_find_topmost_parent): New function.
7723 (x_set_frame_alpha): Find topmost parent window with
7724 x_find_topmost_parent and set the property there also (bug#9181).
7725 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7726
c74e9d86
PE
77272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7728
7729 * callproc.c (Fcall_process): Avoid vfork clobbering
7730 the local vars buffer, coding_systems, current_dir.
7731
640c8776
SM
77322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7733
7734 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7735
f26d0e4c
PE
77362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7737
8a10d76c
PE
7738 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7739 so that it is not optimized away.
7740
f26d0e4c
PE
7741 * xdisp.c (compute_display_string_pos): Remove unused local.
7742
55439c61
EZ
77432011-08-02 Eli Zaretskii <eliz@gnu.org>
7744
7745 Fix slow cursor motion and scrolling in large buffers with
7746 selective display, like Org Mode buffers. (Bug#9218)
7747
7748 * dispextern.h (struct bidi_it): New member disp_prop_p.
7749
7750 * xdisp.c: Remove one-slot cache of display string positions.
7751 (compute_display_string_pos): Accept an additional argument
5e617bc2 7752 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7753 for a display string or property. If found, set DISP_PROP_P
7754 non-zero.
7755
7756 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7757 DISP_PROP_P, and pass it to compute_display_string_pos.
7758 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7759 non-zero. All callers of bidi_fetch_char changed.
7760
fb33fa43
SM
77612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7762
7763 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7764
b099e063
DM
77652010-12-03 Don March <don@ohspite.net>
7766
7767 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7768 last character M-[char] is translated to ESC [char] (bug#7541).
7769
5cc7f7af
KH
77702011-08-02 Kenichi Handa <handa@m17n.org>
7771
d0fffa3f 7772 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7773
7774 * chartab.c (uniprop_table): Make it non-static.
7775
525d5e6e
EZ
77762011-08-01 Eli Zaretskii <eliz@gnu.org>
7777
7778 * xdisp.c (forward_to_next_line_start): Accept additional argument
7779 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7780 on the newline.
7781 (reseat_at_next_visible_line_start): Use the bidi iterator state
7782 returned by forward_to_next_line_start to restore the state of
7783 it->bidi_it after backing up to previous newline. (Bug#9212)
7784
31011111
AS
77852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7786
7787 * regex.c (re_comp): Protoize.
7788 (re_exec): Fix return type.
7789 (regexec): Fix type of `ret'. (Bug#9203)
7790
476371c4
PE
77912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7792
e5d76069
PE
7793 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7794 This is needed if max-image-size is a floating-point number.
7795
9a79b20c
AS
77962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7797
7798 * print.c (print_object): Print empty symbol as ##.
7799
7800 * lread.c (read1): Read ## as empty symbol.
7801
d8c2fa78
AA
78022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7803
7804 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7805 setting frame foreground color (Bug#9175).
7806 (x_set_background_color): Likewise.
7807
ffe57a7a
AA
7808 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7809 contents (Bug#9176).
7810 (EmacsTooltip -init): Remove bezels and add shadows to
7811 tooltip windows.
7812
bf3492a5
AA
7813 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7814 or scroll bar (Bug#8470).
7815
d55e9c53
AA
7816 * nsfont.m (nsfont_open): Remove assignment to voffset and
7817 unnecessary vars hshink, expand, hd, full_height, min_height.
7818 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7819
7820 * nsterm.h (nsfont_info): Remove voffset field.
7821
d8c2fa78 78222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7823
7824 Implement strike-through and overline on NextStep (Bug#8863).
7825
7826 * nsfont.m (nsfont_open): Use underline position provided by font,
7827 instead of hard-coded value of 2.
7828 (nsfont_draw): Call ns_draw_text_decoration instead.
7829
7830 * nsterm.h: Add declaration for ns_draw_text_decoration.
7831
7832 * nsterm.m (ns_draw_text_decoration): New function for drawing
7833 underline, overline, and strike-through.
7834 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7835 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7836 accommodate underlining, etc.
4843aac3 7837
4cc60b9b
EZ
78382011-07-28 Eli Zaretskii <eliz@gnu.org>
7839
bc7ece87
EZ
7840 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7841 default.
4cc60b9b 7842
476371c4
PE
78432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7844
66606eea
PE
7845 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7846 Without this fix, if a signal arrives just after memory fills up,
7847 'malloc' might be invoked reentrantly.
7848
476371c4
PE
7849 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7850 In other words, assume that every image size is allowed, on non-X
7851 hosts. This assumption is probably wrong, but it lets Emacs compile.
7852
f3fcc40d
AS
78532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7854
7855 * regex.c (re_iswctype): Convert return values to boolean.
7856
350c992f
EZ
78572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7858
7859 * xdisp.c (compute_display_string_pos): Don't use cached display
7860 string position if the buffer had its restriction changed.
7861 (Bug#9184)
7862
5266b4bb
PE
78632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7864
7865 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7866
2573a837 78672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7868
41f55ccd 7869 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7870
39e378da
PE
7871 * bidi.c: Integer size and overflow fixes.
7872 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7873 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7874 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7875 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7876 (bidi_find_other_level_edge):
7877 Use ptrdiff_t instead of EMACS_INT where either will do.
7878 This works better on 32-bit hosts configured --with-wide-int.
7879 (bidi_cache_ensure_space): Check for size-calculation overflow.
7880 Use % rather than repeated addition, for better worst-case speed.
7881 Don't set bidi_cache_size until after xrealloc returns, because it
7882 might not return.
7883 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7884 (bidi_cache_ensure_space): Also check that the bidi cache size
7885 does not exceed that of the largest Lisp string or buffer. See Eli
7886 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7887
5e927815
PE
7888 * alloc.c (__malloc_size_t): Remove.
7889 All uses replaced by size_t. See Andreas Schwab's note
7890 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7891
ca4aa935
PE
7892 * image.c: Improve checking for integer overflow.
7893 (check_image_size): Assume that f is nonnull, since
7894 it is always nonnull in practice. This is one less thing to
7895 worry about when checking for integer overflow later.
7896 (x_check_image_size): New function, which checks for integer
7897 overflow issues inside X.
7898 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7899 This removes the need for a memory_full check.
7900 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7901 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7902 (xbm_read_bitmap_data): Change locals back to 'int', since
7903 their values must fit in 'int'.
7904 (xpm_load_image, png_load, tiff_load):
7905 Invoke x_create_x_image_and_pixmap earlier,
7906 to avoid much needless work if the image is too large.
7907 (tiff_load): Treat overly large images as if
7908 x_create_x_image_and_pixmap failed, not as malloc failures.
7909 (gs_load): Use x_check_image_size.
7910
5f8f9cc2
PE
7911 * gtkutil.c: Omit integer casts.
7912 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7913 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7914
5adf60bc
PE
7915 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7916
c8907a93
PE
7917 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7918 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7919 would wrongly return t on a 64-bit host.
7920
e3c25c68
PE
7921 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7922 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7923 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7924 and therefore cause GCC to emit a bogus diagnostic in some cases.
7925
3f791afe
PE
7926 * image.c: Integer signedness and overflow and related fixes.
7927 This is not an exhaustive set of fixes, but it's time to
7928 record what I've got.
7929 (lookup_pixel_color, check_image_size): Remove redundant decls.
7930 (check_image_size): Don't assume that arbitrary EMACS_INT values
7931 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7932 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7933 (tiff_load, imagemagick_load_image):
7934 Check for overflow in size calculations.
7935 (x_create_x_image_and_pixmap): Remove unnecessary test for
7936 xmalloc returning NULL; that can't happen.
7937 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7938 (xpm_color_bucket): Use better integer hashing function.
7939 (xpm_cache_color): Don't possibly over-allocate memory.
7940 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7941 (gif_memory_source):
7942 Use ptrdiff_t, not int or size_t, to record sizes.
7943 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7944 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7945 either works, as we prefer signed integers.
7946 (tiff_read_from_memory, tiff_write_from_memory):
7947 Return tsize_t, not size_t, since that's what the TIFF API wants.
7948 (tiff_read_from_memory): Don't fail simply because the read would
7949 go past EOF; instead, return a short read.
7950 (tiff_load): Omit no-longer-needed casts.
7951 (Fimagemagick_types): Don't assume size fits into 'int'.
7952
3cc5a532
PE
7953 Improve hashing quality when configured --with-wide-int.
7954 * fns.c (hash_string): New function, taken from sxhash_string.
7955 Do not discard information about ASCII character case; this
7956 discarding is no longer needed.
7957 (sxhash-string): Use it. Change sig to match it. Caller changed.
7958 * lisp.h: Declare it.
7959 * lread.c (hash_string): Remove, since we now use fns.c's version.
7960 The fns.c version returns a wider integer if --with-wide-int is
7961 specified, so this should help the quality of the hashing a bit.
7962
b312a492
PE
7963 * emacs.c: Integer overflow minor fix.
7964 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7965 Define only if GNU_LINUX.
7966 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7967
dfd153ae
PE
7968 * dispnew.c: Integer signedness and overflow fixes.
7969 Remove unnecessary forward decls, that were a maintenance hassle.
7970 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7971 All uses changed.
7972 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7973 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7974 (prepare_desired_row, line_draw_cost):
7975 Use int, not unsigned, where either works.
7976 (save_current_matrix, restore_current_matrix):
7977 Use ptrdiff_t, not size_t, where either works.
7978 (init_display): Check for overflow more accurately, and without
7979 relying on undefined behavior.
7980
a81d11a3
PE
7981 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7982 Remove, replacing with the new symbols in lisp.h. All uses changed.
7983 * fileio.c (make_temp_name):
7984 * filelock.c (lock_file_1, lock_file):
7985 * xdisp.c (message_dolog):
7986 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7987 Use pMd etc. instead.
7988 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7989 replacing the pWIDE etc. symbols removed from editfns.c.
7990
3300e6fd
PE
7991 * keyboard.h (num_input_events): Now uintmax_t.
7992 This is (very slightly) less likely to mess up due to wraparound.
7993 All uses changed.
7994
fd05c7e9
PE
7995 * buffer.c: Integer signedness fixes.
7996 (alloc_buffer_text, enlarge_buffer_text):
7997 Use ptrdiff_t rather than size_t when either will do, as we prefer
7998 signed integers.
7999
903fe15d
PE
8000 * alloc.c: Integer signedness and overflow fixes.
8001 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8002 (__malloc_size_t): Default to size_t, not to int.
8003 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8004 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8005 Prefer ptrdiff_t to size_t when either would do, as we prefer
8006 signed integers.
8007 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8008 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8009 Now const. Initialize with values that are in range even if char
8010 is signed.
8011 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8012 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8013 These functions do the right thing with sizes > 2**32.
8014 (check_depth): Now ptrdiff_t, not int.
8015 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8016 Adjust to new way of storing sizes. Check for size overflow bugs
8017 in rest of code.
8018 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8019 slightly wrong anyway, as it missed one instance of
8020 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8021 (refill_memory_reserve): Omit needless cast to size_t.
8022 (mark_object_loop_halt): Mark as externally visible.
8023
ac82cc6a
PE
8024 * xselect.c: Integer signedness and overflow fixes.
8025 (Fx_register_dnd_atom, x_handle_dnd_message):
8026 Use ptrdiff_t, not size_t, since we prefer signed.
8027 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8028 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8029 x_dnd_atoms_size and x_dnd_atoms_length.
8030
c2d1e36d
PE
8031 * doprnt.c: Prefer signed to unsigned when either works.
8032 * eval.c (verror):
8033 * doprnt.c (doprnt):
8034 * lisp.h (doprnt):
8035 * xdisp.c (vmessage):
8036 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8037 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8038 prefer signed arithmetic to avoid comparison confusion.
8039 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8040 but is a bit tricky.
8041
0e926e56
PE
8042 Assume freestanding C89 headers, string.h, stdlib.h.
8043 * data.c, doprnt.c, floatfns.c, print.c:
8044 Include float.h unconditionally.
8045 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8046 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8047 * regex.c: Likewise for stddef.h, string.h.
8048 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8049 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8050 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8051 (STDC_HEADERS): Remove obsolete defines.
8052 * sysdep.c: Include limits.h unconditionally.
8053
9cfdb3ec
PE
8054 Assume support for memcmp, memcpy, memmove, memset.
8055 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8056 * regex.c (memcmp, memcpy):
8057 Remove; we assume C89 now.
8058
8059 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8060 (__malloc_safe_bcopy): Remove; no longer needed.
8061
cf950e6b 8062 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8063 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8064 well either way, and we prefer signed to unsigned.
8065
dbf38e02
LMI
80662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8067
8068 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8069 closes the connection while we're reading (bug#9182).
8070
d6f0886c 80712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8072
d6f0886c
JD
8073 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8074 are specified (Bug#9168).
24e0f6b1 8075
2eb1f9e6
PE
80762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8077
8078 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8079 Found by GCC static checking and --with-wide-int on a 32-bit host.
8080
22381272 80812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8082
8083 * xdisp.c (compute_display_string_pos): Fix logic of caching
8084 previous display string position. Initialize cached_prev_pos to
8085 -1. Fixes slow-down at the beginning of a buffer.
8086
f25e39b4
EZ
80872011-07-24 Eli Zaretskii <eliz@gnu.org>
8088
8089 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8090 for attrs[LFACE_FONTSET_INDEX].
8091
04c4b52e
PE
80922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8093
8094 * xml.c (parse_region): Remove unused local
8095 that was recently introduced.
8096
c1734fbd
EZ
80972011-07-23 Eli Zaretskii <eliz@gnu.org>
8098
be18c5a5
EZ
8099 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8100 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8101
c1734fbd
EZ
8102 * xdisp.c (move_it_in_display_line_to): Record the best matching
8103 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8104 exit if none of the characters scanned was an exact match.
8105 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8106 when exact match is impossible due to invisible text, and the
8107 lines are truncated.
8108
a258d627
JD
81092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8110
8111 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8112 for OSX >= 10.7.
8113
b6d5a689
EZ
81142011-07-22 Eli Zaretskii <eliz@gnu.org>
8115
0f74f785
EZ
8116 Fix a significant slow-down of cursor motion with C-n, C-p,
8117 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8118 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8119 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8120 (next_element_from_buffer): Call compute_stop_pos_backwards to
8121 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8122 base_level_stop.
8123 (reseat): Don't look for prev_stop, as that could mean a very long
8124 run.
8125 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8126 <cached_disp_overlay_modiff>: Cache for last found display string
8127 position.
551918c1 8128 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8129 about the same buffer in the same area of character positions, and
8130 the buffer wasn't changed since the time the display string
8131 position was cached.
551918c1 8132
b2d0c91a
EZ
81332011-07-22 Eli Zaretskii <eliz@gnu.org>
8134
8135 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8136 is an integer, which is important for empty lines. (Bug#9149)
8137
043604ee
CY
81382011-07-22 Chong Yidong <cyd@stupidchicken.com>
8139
8140 * frame.c (Fmodify_frame_parameters): In tty case, update the
8141 default face if necessary (Bug#4238).
8142
da4adb04
CY
81432011-07-21 Chong Yidong <cyd@stupidchicken.com>
8144
8145 * editfns.c (Fstring_to_char): No need to explain what a character
8146 is in the docstring (Bug#6576).
8147
9abd0532
LMI
81482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8149
8150 * xml.c (parse_region): Make sure we always return a tree.
8151
36881d16
HK
81522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8153
8154 * xml.c (parse_region): If a document contains only comments,
8155 return that, too.
8156
1e98674d
LMI
81572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8158
8159 * xml.c (make_dom): Return comments, too.
8160
590bd467
PE
81612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8162
8163 Port to OpenBSD.
8164 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8165 and the surrounding thread.
8166 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8167 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8168 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8169 timer goes off.
8170 * s/openbsd.h (BROKEN_SIGIO): Define.
8171 * unexelf.c (unexec) [__OpenBSD__]:
8172 Don't update the .mdebug section of the Alpha COFF symbol table.
8173
f41628b2
LMI
81742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8175
8176 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8177 (bug#8460).
8178
b59b67c5
PE
81792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8180
15e3a074
PE
8181 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8182 This fixes some race conditions on the permissions of any newly
8183 created file.
8184
41bed37d
PE
8185 * alloc.c (valid_pointer_p): Use pipe, not open.
8186 This fixes some permissions issues when debugging.
8187
b59b67c5
PE
8188 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8189 If fchown fails to set both uid and gid, try to set just gid,
8190 as that is sometimes allowed. Adjust the file's mode to eliminate
8191 setuid or setgid bits that are inappropriate if fchown fails.
8192
925a6be7
SM
81932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8194
8195 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8196 to compare Lisp_Objects.
8197 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8198 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8199 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8200
52968808
AS
82012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8202
0a6a104b
AS
8203 * lread.c (read_integer): Unread even EOF character.
8204 (read1): Likewise. Properly record start position of symbol.
8205
52968808
AS
8206 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8207 symbol character follows.
8208
9e381cdd
PE
82092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8210
8211 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8212 This works around a problem with the previous change to Fcopy_file.
8213 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8214 and without this change, GCC might complain about discarding
8215 fchown's return value.
8216
b5641435
JB
82172011-07-16 Juanma Barranquero <lekktu@gmail.com>
8218
8219 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8220
a8031457
PE
82212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8222
8223 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8224
dd889327
LMI
82252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8226
750c33f7
LMI
8227 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8228 it's used from the C level.
8229
dd889327
LMI
8230 * process.c: Use the same condition for POLL_FOR_INPUT in both
8231 keyboard.c and process.c (bug#1858).
8232
87e86684
LM
82332011-07-09 Lawrence Mitchell <wence@gmx.li>
8234
8235 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8236 (Fgnutls_boot): Use it.
8237
64348f40
AS
82382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8239
8240 * doc.c (Fsubstitute_command_keys): Revert last change.
8241
1d698799
LMI
82422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8243
f863868c
LMI
8244 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8245 quotes the next character, and doesn't affect other longer
8246 sequences (bug#8935).
8247
1d698799
LMI
8248 * lread.c (syms_of_lread): Clarify that is isn't only
8249 `eval-buffer' and `eval-defun' that's affected by
8250 `lexical-binding' (bug#8460).
8251
aa4b6df6
EZ
82522011-07-15 Eli Zaretskii <eliz@gnu.org>
8253
8254 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8255 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8256
5d856da6
PE
82572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8258
ad6042bb
PE
8259 Fix minor problems found by static checking.
8260 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8261 (elsz): Now a signed constant, not a size_t var. We prefer signed
8262 types to unsigned, to avoid integer comparison confusion. Without
8263 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8264 "cannot optimize loop, the loop counter may overflow", a symptom
8265 of the confusion.
f00bbb22 8266 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8267 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8268
6468f31c
LMI
82692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8270
49080b10
LMI
8271 * search.c (Fre_search_backward): Mention `case-fold-search' in
8272 all the re_search_* functions (bug#8138).
8273
6468f31c
LMI
8274 * keyboard.c (Fopen_dribble_file): Document when the file is
8275 closed (bug#8056).
8276
c965adc5
EZ
82772011-07-14 Eli Zaretskii <eliz@gnu.org>
8278
df9733bf
EZ
8279 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8280 bidi_cache_idx.
8281
0bb23927
EZ
8282 Support bidi reordering of display and overlay strings.
8283 * xdisp.c (compute_display_string_pos)
8284 (compute_display_string_end): Accept additional argument STRING.
8285 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8286 (reseat_to_string): Initialize bidi_it->string.s and
8287 bidi_it->string.schars.
8288 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8289 NULL (avoids a crash in bidi_paragraph_init).
8290 Initialize itb.string.lstring.
0bb23927
EZ
8291 (init_iterator): Call bidi_init_it only of a valid
8292 buffer position was specified. Initialize paragraph_embedding to
8293 L2R.
8294 (reseat_to_string): Initialize the bidi iterator.
8295 (display_string): If we need to ignore text properties of
8296 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8297 original value of -1 will not work with bidi.)
8298 (compute_display_string_pos): First arg is now struct
8299 `text_pos *'; all callers changed. Support display properties on
8300 Lisp strings.
8301 (compute_display_string_end): Support display properties on Lisp
8302 strings.
8303 (init_iterator, reseat_1, reseat_to_string): Initialize the
8304 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8305 when iterating on a string not from display properties).
640c8776
SM
8306 (compute_display_string_pos, compute_display_string_end):
8307 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8308 arrow keys.
8309 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8310 base_level_stop; instead, set base_level_stop to BEGV.
8311 Fixes crashes in vertical-motion.
0bb23927
EZ
8312 (next_element_from_buffer): Improve commentary for when
8313 the iterator is before prev_stop.
8314 (init_iterator): Initialize bidi_p from the default value of
8315 bidi-display-reordering, not from buffer-local value. Use the
8316 buffer-local value only if initializing for buffer iteration.
8317 (handle_invisible_prop): Support invisible properties on strings
8318 that are being bidi-reordered.
8319 (set_iterator_to_next): Support bidi reordering of C strings and
8320 Lisp strings.
8321 (next_element_from_string): Support bidi reordering of Lisp
8322 strings.
8323 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8324 (display_string): Support display of R2L glyph rows.
8325 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8326 (init_iterator): Don't initialize it->bidi_p for strings
8327 here.
8328 (reseat_to_string): Initialize it->bidi_p for strings here.
8329 (next_element_from_string, next_element_from_c_string)
8330 (next_element_from_buffer): Add xassert's for correspondence
8331 between IT's object being iterated and it->bidi_it.string
8332 structure.
8333 (face_before_or_after_it_pos): Support bidi iteration.
8334 (next_element_from_c_string): Handle the case of the first string
8335 character that is not the first one in the visual order.
8336 (get_visually_first_element): New function, refactored from common
8337 parts of next_element_from_buffer, next_element_from_string, and
8338 next_element_from_c_string.
8339 (tool_bar_lines_needed, redisplay_tool_bar)
8340 (display_menu_bar): Force left-to-right direction. Add a FIXME
8341 comment for making that be controlled by a user option.
8342 (push_it, pop_it): Save and restore the state of the
8343 bidi iterator. Save and restore the bidi_p flag.
8344 (pop_it): Iterate out of display property for string iteration as
8345 well.
8346 (iterate_out_of_display_property): Support iteration over strings.
8347 (handle_single_display_spec): Set up it->bidi_it for iteration
8348 over a display string, and call bidi_init_it.
8349 (handle_single_display_spec, next_overlay_string)
8350 (get_overlay_strings_1, push_display_prop): Set up the bidi
8351 iterator for displaying display or overlay strings.
8352 (forward_to_next_line_start): Don't use the shortcut if
8353 bidi-iterating.
8354 (back_to_previous_visible_line_start): If handle_display_prop
8355 pushed the iterator stack, restore the internal state of the bidi
8356 iterator by calling bidi_pop_it same number of times.
8357 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8358 and we are bidi-iterating, don't decrement the iterator position;
8359 instead, set the first_elt flag in the bidi iterator, to produce
8360 the same effect.
8361 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8362 (push_display_prop): xassert that we are iterating a buffer.
8363 (push_it, pop_it): Save and restore paragraph_embedding member.
8364 (handle_single_display_spec, next_overlay_string)
8365 (get_overlay_strings_1, reseat_1, reseat_to_string)
8366 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8367 correctly. Don't assume unibyte strings are not bidi-reordered.
8368 (compute_display_string_pos)
8369 (compute_display_string_end): Fix handling the case of C string.
8370 (push_it, pop_it): Save and restore from_disp_prop_p.
8371 (handle_single_display_spec, push_display_prop): Set the
8372 from_disp_prop_p flag.
8373 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8374 (pop_it): Call iterate_out_of_display_property only if we are
8375 popping after iteration over a string that came from a display
8376 property. Fix a typo in popping stretch info. Add an assertion
8377 for verifying that the iterator position is in sync with the bidi
8378 iterator.
8379 (handle_single_display_spec, get_overlay_strings_1)
8380 (push_display_prop): Fix initialization of paragraph direction for
8381 string when that of the parent object is not yet determined.
8382 (reseat_1): Call bidi_init_it to resync the bidi
8383 iterator with IT's position. (Bug#7616)
8384 (find_row_edges): If ROW->start.pos gives position
8385 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8386 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8387 Reset the from_disp_prop_p flag.
8388 (SAVE_IT, RESTORE_IT): New macros.
8389 (pos_visible_p, face_before_or_after_it_pos)
8390 (back_to_previous_visible_line_start)
8391 (move_it_in_display_line_to, move_it_in_display_line)
8392 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8393 (try_scrolling, redisplay_window, display_line): Use them when
8394 saving a temporary copy of the iterator and restoring it back.
8395 (back_to_previous_visible_line_start, reseat_1)
8396 (init_iterator): Empty the bidi cache "stack".
8397 (move_it_in_display_line_to): If iterator ended up at
8398 EOL, but we never saw any buffer positions smaller than
8399 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8400 motion in bidi-reordered lines.
8401 (move_it_in_display_line_to): Record prev_method and prev_pos
8402 immediately before the call to set_iterator_to_next. Fixes cursor
8403 motion in bidi-reordered lines with stretch glyphs and strings
8404 displayed in margins. (Bug#8133) (Bug#8867)
8405 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8406 TO_CHARPOS.
640c8776
SM
8407 (pos_visible_p): Support positions in bidi-reordered lines.
8408 Save and restore bidi cache.
0bb23927
EZ
8409
8410 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8411 (bidi_paragraph_info): Delete unused struct.
8412 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8413 (bidi_cache_start): New variable.
8414 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8415 to zero.
8416 (bidi_cache_fetch_state, bidi_cache_search)
8417 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8418 (bidi_cache_find, bidi_peek_at_next_level)
8419 (bidi_level_of_next_char, bidi_find_other_level_edge)
8420 (bidi_move_to_visually_next): Compare cache index with
8421 bidi_cache_start rather than with zero.
8422 (bidi_fetch_char): Accept new argument STRING; all callers
8423 changed. Support iteration over a string. Support strings with
8424 display properties. Support unibyte strings. Fix the type of
8425 `len' according to what STRING_CHAR_AND_LENGTH expects.
8426 (bidi_paragraph_init, bidi_resolve_explicit_1)
8427 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8428 (bidi_level_of_next_char, bidi_move_to_visually_next):
8429 Support iteration over a string.
0bb23927
EZ
8430 (bidi_set_sor_type, bidi_resolve_explicit_1)
8431 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8432 can now be zero (for strings); special values 0 and -1 were
8433 changed to -1 and -2, respectively.
8434 (bidi_char_at_pos): New function.
8435 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8436 Call it instead of FETCH_MULTIBYTE_CHAR.
8437 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8438 initialized to valid values.
8439 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8440 values.
8441 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8442 the test for valid cached positions. Fix the logic for looking up
8443 the sentinel state in the cache. GCPRO the Lisp string we are
8444 iterating.
8445 (bidi_push_it, bidi_pop_it): New functions.
8446 (bidi_initialize): Initialize the bidi cache start stack pointer.
8447 (bidi_cache_ensure_space): New function, refactored from part of
8448 bidi_cache_iterator_state. Don't assume the required size is just
8449 one BIDI_CACHE_CHUNK away.
8450 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8451 (bidi_count_bytes, bidi_char_at_pos): New functions.
8452 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8453 always valid if bidi_cache_idx is valid.
8454 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8455 is valid if it's going to be used.
8456 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8457 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8458 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8459 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8460 (bidi_find_other_level_edge, bidi_cache_start_stack):
8461 All variables related to cache indices are now EMACS_INT.
c965adc5 8462
0bb23927
EZ
8463 * dispextern.h (struct bidi_string_data): New structure.
8464 (struct bidi_it): New member `string'. Make flag members be 1-bit
8465 fields, and put them last in the struct.
640c8776
SM
8466 (compute_display_string_pos, compute_display_string_end):
8467 Update prototypes.
0bb23927
EZ
8468 (bidi_push_it, bidi_pop_it): Add prototypes.
8469 (struct iterator_stack_entry): New members bidi_p,
8470 paragraph_embedding, and from_disp_prop_p.
8471 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8472 (bidi_shelve_cache, bidi_unshelve_cache):
8473 Declare prototypes.
0bb23927
EZ
8474
8475 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8476 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8477 and vector-like objects.
8478
8479 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8480 cache around display iteration.
8481
8482 * window.c (Fwindow_end, window_scroll_pixel_based)
8483 (displayed_window_lines, Frecenter): Save and restore the bidi
8484 cache around display iteration.
8485
3bbd2265
LMI
84862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8487
8488 * editfns.c (Fdelete_region): Clarify the use of the named
8489 parameters (bug#6788).
8490
adc47434
MR
84912011-07-14 Martin Rudalics <rudalics@gmx.at>
8492
8493 * indent.c (Fvertical_motion): Set and restore w->pointm when
8494 saving and restoring the window's buffer (Bug#9006).
8495
837c31f8
LMI
84962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8497
8498 * editfns.c (Fstring_to_char): Clarify just what is returned
8499 (bug#6576). Text by Eli Zaretskii.
8500
ac389d0c
JB
85012011-07-13 Juanma Barranquero <lekktu@gmail.com>
8502
8503 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8504
0be0ce47
EZ
85052011-07-13 Eli Zaretskii <eliz@gnu.org>
8506
8507 * buffer.c (mmap_find): Fix a typo.
8508
cd18e7e3
JB
85092011-07-13 Johan Bockgård <bojohan@gnu.org>
8510
8511 Fix execution of x selection hooks.
8512 * xselect.c (Qx_lost_selection_functions)
8513 (Qx_sent_selection_functions): New vars.
8514 (syms_of_xselect): DEFSYM them.
8515 (x_handle_selection_request): Pass Qx_sent_selection_functions
8516 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8517 (x_handle_selection_clear,x_clear_frame_selections):
8518 Pass Qx_lost_selection_functions rather than
8519 Vx_lost_selection_functions to Frun_hook_with_args.
8520
47ea7f44
PE
85212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8522
ac389d0c 8523 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8524 The old code sometimes used this field without initializing it.
8525
47ea7f44
PE
8526 * alloc.c (gc_sweep): Don't read past end of array.
8527 In theory, the old code could also have corrupted Emacs internals,
8528 though it'd be very unlikely.
8529
bc985c87
AS
85302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8531
8532 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8533 argument. (Bug#4026)
bc985c87 8534
0cf34688
LMI
85352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8536
b3dadd76
LMI
8537 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8538 key" (bug#4257).
8539
0cf34688
LMI
8540 * window.c (Fset_window_start): Doc fix (bug#4199).
8541 (Fset_window_hscroll): Ditto.
8542
270768cd
PE
85432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8544
077e3dda 8545 Fix minor new problems caught by GCC 4.6.1.
270768cd 8546 * term.c (init_tty): Remove unused local.
490011a6 8547 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8548 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8549 not used otherwise.
270768cd 8550
b1f58454
CY
85512011-07-12 Chong Yidong <cyd@stupidchicken.com>
8552
8553 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8554
22b9578d
LMI
85552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8556
6e70ab07
LMI
8557 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8558 are the mini-buffer and the echo area (bug#3320).
8559
22b9578d
LMI
8560 * term.c (init_tty): Remove support for supdup, c10 and perq
8561 terminals, which are no longer supported (bug#1482).
8562
8974cc9f
JB
85632011-07-10 Johan Bockgård <bojohan@gnu.org>
8564
8565 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8566
a560d974
JD
85672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8568
8569 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8570 for non-popups (Bug#3642).
8571
1dae0f0a
AS
85722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8573
268c2c36 8574 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8575 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8576 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8577 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8578 * data.c (fmod): Likewise.
8579 * dispnew.c (swap_glyphs_in_rows): Likewise.
8580 * emacs.c (memory_warning_signal): Likewise.
8581 * floatfns.c (float_error): Likewise.
8582 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8583 (otf_open, font_otf_capability, generate_otf_features)
8584 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8585 Likewise.
8586 * image.c (pbm_read_file): Likewise.
8587 * indent.c (string_display_width): Likewise.
8588 * intervals.c (check_for_interval, search_for_interval)
8589 (inc_interval_count, count_intervals, root_interval)
8590 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8591 * lread.c (defalias): Likewise.
268c2c36 8592 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8593 * regex.c (set_image_of_range_1, set_image_of_range)
8594 (regex_grow_registers): Likewise.
8595 * sysdep.c (strerror): Likewise.
8596 * termcap.c (valid_filename_p, tprint, main): Likewise.
8597 * tparam.c (main): Likewise.
8598 * unexhp9k800.c (run_time_remap, save_data_space)
8599 (update_file_ptrs, read_header, write_header, calculate_checksum)
8600 (copy_file, copy_rest, display_header): Likewise.
8601 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8602 Likewise.
8603 * xdisp.c (check_it): Likewise.
8604 * xfaces.c (register_color, unregister_color, unregister_colors):
8605 Likewise.
8606 * xfns.c (print_fontset_result): Likewise.
8607 * xrdb.c (member, fatal, main): Likewise.
8608
99033785
PE
86092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8610
8611 Fix minor problems found by static checking (Bug#9031).
8612 * chartab.c (char_table_set_range, map_sub_char_table):
8613 Remove unused locals.
8614 (uniprop_table): Now static.
8615 * composite.c (_work_char): Remove unused static var.
8616
9cb2ac56
JB
86172011-07-09 Juanma Barranquero <lekktu@gmail.com>
8618
8619 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8620
f25661f0
JD
86212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8622
8623 * gtkutil.c (qttip_cb): Remove code without function.
8624
8278c4fe
EZ
86252011-07-09 Eli Zaretskii <eliz@gnu.org>
8626
8627 * w32.c (pthread_sigmask): New stub.
8628
1692ae2d 86292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8630
8a6ebd58 8631 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8632 sigprocmask is portable only for single-threaded applications, and
8633 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8634 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8635 (LIBES): Use it.
8636 * callproc.c (Fcall_process):
8637 * process.c (create_process):
8638 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8639 Use pthread_sigmask, not sigprocmask.
123403e4 8640
1b854618
JD
86412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8642
8643 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8644 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8645 wrong (Bug#8591).
8646
3fe4b549
JD
86472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8648
0ce7e563
JD
8649 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8650 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8651 (xg_hide_tooltip): Fix comment.
8652
3fe4b549
JD
8653 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8654 in registerServicesMenuSendTypes.
8655 (validRequestorForSendType): Don't check ns_return_types.
8656
8657 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8658 ns_return_type.
8659
5df75e47
JR
86602011-07-08 Jason Rumney <jasonr@gnu.org>
8661
22610910
JR
8662 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8663 SH_SHOW for hidden windows (Bug#5482).
8664
5df75e47
JR
8665 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8666 frame struct members of non-existent frames (Bug#6284).
8667
699c10bd
JD
86682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8669
4393663b
JD
8670 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8671 variable firstTime not needed on OSX >= 10.6.
8672 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8673 >= 10.5. Use setKnobProportion, setDoubleValue.
8674
8675 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8676 (MAC_OS_X_VERSION_10_5): Define if not defined.
8677 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8678 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8679 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8680
8681 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8682 cString and lossyCString on OSX >= 10.4.
4393663b 8683
58179cce 8684 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8685 sizeToFit on OSX >= 10.2.
8686
8687 * nsimage.m (allocInitFromFile): Don't use deprecated method
8688 bestRepresentationForDevice on OSX >= 10.6.
8689
8690 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8691 to avoid warning.
8692
8693 * emacs.c: Declare unexec_init_emacs_zone.
8694
a63e0781
JD
8695 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8696
699c10bd
JD
8697 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8698
8699 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8700 on svcsMenu (Bug#8842).
8701
8702 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8703 ns_return_types.
8704 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8705
8706 * nsterm.m (QUTF8_STRING): Declare.
8707 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8708 (validRequestorForSendType): Return type is (id).
8709 Change indexOfObjectIdenticalTo to indexOfObject.
8710 Check if we have local selection before returning self (Bug#8842).
8711 (writeSelectionToPasteboard): Put local selection into paste board
8712 if we have a local selection (Bug#8842).
8713 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8714
8715 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8716 (ns_get_local_selection): Declare.
8717
54e10184
LMI
87182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8719
9888ff71
LMI
8720 * keymap.c (describe_map_tree): Don't insert a double newline at
8721 the end of the buffer (bug#1169) and return whether we inserted
8722 something.
8723
54e10184
LMI
8724 * callint.c (Fcall_interactively): Change "reading args" to
8725 "providing args" to try to clarify what it does (bug#1010).
8726
15fa4783
KH
87272011-07-07 Kenichi Handa <handa@m17n.org>
8728
8729 * composite.c (composition_compute_stop_pos): Ignore a static
8730 composition starting before CHARPOS (Bug#8915).
8731
8732 * xdisp.c (handle_composition_prop): Likewise.
8733
a8815b00
EZ
87342011-07-07 Eli Zaretskii <eliz@gnu.org>
8735
8736 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8737 (Bug#9015)
8738
ef7b981d 87392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8740
8741 * character.h (unicode_category_t): New enum type.
8742
8743 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8744 (Qchar_code_property_table): New variable.
8745 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8746 (UNIPROP_COMPRESSED_FORM_P): New macros.
8747 (char_table_ascii): Uncompress the compressed values.
8748 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8749 Uncompress the compressed values.
ac389d0c 8750 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8751 (char_table_ref_and_range): Uncompress the compressed values.
8752 (sub_char_table_set): New arg is_uniprop. Callers changed.
8753 Uncompress the compressed values.
8754 (sub_char_table_set_range): Args changed. Callers changed.
8755 (char_table_set_range): Adjuted for the above change.
8756 (map_sub_char_table): Delete args default_val and parent. Add arg
8757 top. Give decoded values to a Lisp function.
640c8776 8758 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8759 values to a Lisp function. Gcpro more variables.
8760 (uniprop_table_uncompress)
8761 (uniprop_decode_value_run_length): New functions.
8762 (uniprop_decoder, uniprop_decoder_count): New variables.
8763 (uniprop_get_decoder, uniprop_encode_value_character)
8764 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8765 New functions.
8766 (uniprop_encoder, uniprop_encoder_count): New variables.
8767 (uniprop_get_encoder, uniprop_table)
8768 (Funicode_property_table_internal, Fget_unicode_property_internal)
8769 (Fput_unicode_property_internal): New functions.
8770 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8771 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8772 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8773 char-code-property-alist.
8774
640c8776 8775 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8776 Vunicode_category_table.
8777
640c8776 8778 * font.c (font_range): Adjust for the change of
c805dec0
KH
8779 Vunicode_category_table.
8780
76b397fb
DN
87812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8782
8783 * m/iris4d.h: Remove file, move contents ...
8784 * s/irix6-5.h: ... here.
8785
22b4128e
PE
87862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8787
8788 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8789 * alloc.c (mark_buffer):
8790 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8791 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8792 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8793 This isn't true in general, and it's particularly not true
8794 if Emacs is configured with --with-wide-int.
8795 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8796 New macros, used in the buffer.c change.
8797
869795d6
JD
87982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8799
8800 * xsettings.c: Use both GConf and GSettings if both are available.
8801 (store_config_changed_event): Add comment.
8802 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8803 (store_tool_bar_style_changed): New functions.
5e617bc2 8804 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8805 (struct xsettings): Move font inside HAVE_XFT.
8806 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8807 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8808 Move inside HAVE_XFT.
640c8776 8809 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8810 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8811 also.
8812 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8813 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8814 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8815 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8816 (parse_settings): Move check for font inside HAVE_XFT.
8817 (read_settings, apply_xft_settings): Add comment.
8818 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8819 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8820 call store_font_name_changed.
8821 (xft_settings_event): Add comment.
8822 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8823 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8824 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8825 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8826 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8827 (xsettings_get_system_font, xsettings_get_system_normal_font):
8828 Add comment.
869795d6 8829
d8ed26bd
PE
88302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8831
8832 Random fixes. E.g., (random) never returned negative values.
8833 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8834 subseconds part to the entropy, as that's a bit more random.
8835 Prefer signed to unsigned, since the signedness doesn't matter and
8836 in general we prefer signed. When given a limit, use a
8837 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8838 latter isn't right if USE_2_TAGS_FOR_INTS.
8839 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8840 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8841
cabf1cac
SM
88422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8843
8844 * textprop.c (text_property_stickiness):
8845 Obey Vtext_property_default_nonsticky.
8846 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8847 * w32fns.c (syms_of_w32fns):
8848 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8849
6e9b2be9
PE
88502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8851
8852 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8853 This is more efficient than Ffile_directory_p and avoids a minor race.
8854
90186c68
LMI
88552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8856
7c301272
LMI
8857 * buffer.c (Foverlay_put): Say what the return value is
8858 (bug#7835).
8859
c4f2d8d4
LMI
8860 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8861 is a directory before asking whether to use the file name
8862 (bug#7564).
ad637907
LMI
8863 (barf_or_query_if_file_exists): Make the "File is a directory"
8864 error be more correct.
c4f2d8d4 8865
90186c68
LMI
8866 * fns.c (Frequire): Remove the mention of the .gz files, since
8867 that's installation-specific, but keep the mention of
8868 `get-load-suffixes'.
8869
da64016e
PE
88702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8871
8872 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8873 Report string overflow if the output is too long.
8874
7d47b580
JB
88752011-07-04 Juanma Barranquero <lekktu@gmail.com>
8876
a555cb87
JB
8877 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8878 (syms_of_gnutls): Remove duplicate DEFSYM for
8879 Qgnutls_bootprop_verify_hostname_error, an error for
8880 Qgnutls_bootprop_verify_error (which is no longer used).
8881
7d47b580
JB
8882 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8883 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8884 Also (re)move comments that are misplaced or no longer relevant.
8885
1e49bfab
LMI
88862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8887
8888 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8889
1485f4c0
CY
88902011-07-03 Chong Yidong <cyd@stupidchicken.com>
8891
8892 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8893 and background color parameters if they have been changed.
8894
a9ab721e
LMI
88952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8896
8897 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8898
cf7cff57
PE
88992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8900
2e13213d
PE
8901 * xsettings.c (SYSTEM_FONT): Define only when used.
8902 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8903
cf7cff57
PE
8904 * keymap.c (access_keymap_1): Now static.
8905
7a8e04f7
CY
89062011-07-02 Chong Yidong <cyd@stupidchicken.com>
8907
8908 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8909 leave any prefix arg for the up event (Bug#1586).
8910
61352f62
LMI
89112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8912
69bb1ef7
LMI
8913 * lread.c (syms_of_lread): Mention single symbols defined by
8914 `defvar' or `defconst' (bug#7154).
8915
61352f62 8916 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8917 (Frequire): Mention get-load-suffixes.
61352f62 8918
28545e04
MR
89192011-07-02 Martin Rudalics <rudalics@gmx.at>
8920
8921 * window.h (window): Remove clone_number slot.
8922 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8923 Remove.
8924 (make_parent_window, make_window, saved_window)
8925 (Fset_window_configuration, save_window_save): Don't deal with
8926 clone numbers.
8927 * buffer.c (Qclone_number): Remove declaration.
8928 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8929
3349e122
SM
89302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8931
8932 Add multiple inheritance to keymaps.
8933 * keymap.c (Fmake_composed_keymap): New function.
8934 (Fset_keymap_parent): Simplify.
8935 (fix_submap_inheritance): Remove.
8936 (access_keymap_1): New function extracted from access_keymap to handle
8937 embedded parents and handle lists of maps.
8938 (access_keymap): Use it.
8939 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8940 (Fcopy_keymap): Handle embedded parents.
8941 (Fcommand_remapping, define_as_prefix): Simplify.
8942 (Fkey_binding): Simplify.
8943 (syms_of_keymap): Move minibuffer-local-completion-map,
8944 minibuffer-local-filename-completion-map,
8945 minibuffer-local-must-match-map, and
8946 minibuffer-local-filename-must-match-map to Elisp.
8947 (syms_of_keymap): Defsubr make-composed-keymap.
8948 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8949 (parse_menu_item): Trivial simplification.
8950
3279eb87
GM
89512011-07-01 Glenn Morris <rgm@gnu.org>
8952
8953 * Makefile.in (SETTINGS_LIBS): Fix typo.
8954
4550efdf
KI
89552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8956
8957 * coding.c (Fencode_coding_string): Record the last coding system
8958 used, as the function doc string says (bug#8738).
8959
0949d2b6
JD
89602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8961
8962 * xsettings.c (store_monospaced_changed): Take new font as arg and
8963 check for change against current_mono_font.
8964 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8965 (emacs_settings_constructor, emacs_settings_get_property)
8966 (emacs_settings_set_property, emacs_settings_class_init)
8967 (emacs_settings_init, gsettings_obj): Remove.
8968 (something_changedCB): New function for HAVE_GSETTINGS.
8969 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8970 with value as argument.
8971 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8972 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8973 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8974 "changed".
8975
8976 * xgselect.c: Add defined (HAVE_GSETTINGS).
8977 (xgselect_initialize): Ditto.
8978
8979 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8980 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8981 xg_select.
8982
bbc6b304
PE
89832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8984
8985 * eval.c (struct backtrace): Simplify and port the data structure.
8986 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8987 signed bit field, as this assumption is not portable and it makes
8988 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8989 "char debug_on_exit : 1" as this is not portable either; instead,
8990 use the portable "unsigned int debug_on_exit : 1". Remove unused
8991 member evalargs. Remove obsolete comments about cc bombing out.
8992
9851bfc5
JD
89932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8994
51bb811f 8995 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8996 Let HAVE_GSETTINGS override HAVE_GCONF.
8997 (store_monospaced_changed): New function.
8998 (EMACS_SETTINGS): A new type derived from GObject to handle
8999 GSettings notifications.
9000 (emacs_settings_constructor, emacs_settings_get_property)
9001 (emacs_settings_set_property, emacs_settings_class_init):
9002 New functions.
9003 (gsettings_client, gsettings_obj): New variables.
9004 (GSETTINGS_SCHEMA): New define.
9005 (something_changedCB): Call store_monospaced_changed.
9006 (init_gsettings): New function.
9007 (xsettings_initialize): Call init_gsettings.
9008 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9009 to NULL.
9010
640c8776 9011 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9012 GCONF_CFLAGS/LIBS.
9013
5386012d
MR
90142011-06-29 Martin Rudalics <rudalics@gmx.at>
9015
9016 * window.c (resize_root_window, grow_mini_window)
9017 (shrink_mini_window): Rename Qresize_root_window to
9018 Qwindow_resize_root_window and Qresize_root_window_vertically to
9019 Qwindow_resize_root_window_vertically.
9020
f13e0b08
PE
90212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9022
9023 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9024
94515237
JB
90252011-06-27 Juanma Barranquero <lekktu@gmail.com>
9026
9027 * makefile.w32-in: Redesign dependencies so they reflect more
9028 clearly which files are directly included by each source file,
9029 and not through other includes.
9030
e43b6e43
MR
90312011-06-27 Martin Rudalics <rudalics@gmx.at>
9032
9033 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9034 (sort_overlays, overlay_strings): When an overlay's clone number
9035 matches the window's clone number process the overlay even if
9036 the overlay's window property doesn't match the current window.
9037
d68443dc
MR
9038 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9039 (Fwindow_hchild): Rename to Fwindow_left_child.
9040 (Fwindow_next): Rename to Fwindow_next_sibling.
9041 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9042 (resize_window_check): Rename to window_resize_check.
9043 (resize_window_apply): Rename to window_resize_apply.
9044 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9045 (Fdelete_other_windows_internal, resize_frame_windows)
9046 (Fsplit_window_internal, Fdelete_window_internal)
9047 (grow_mini_window, shrink_mini_window)
9048 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9049
c7e73be5
JD
90502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9051
9052 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9053 (emacs_fixed_set_min_size): Remove.
9054 (emacs_fixed_new): Take frame as argument.
9055
9056 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9057 (_EmacsFixedPrivate): Remove minwidth/height.
9058 Add struct frame *f.
9059 (emacs_fixed_init): Initialize priv->f.
9060 (get_parent_class, emacs_fixed_set_min_size): Remove.
9061 (emacs_fixed_new): Set priv->f to argument.
9062 (emacs_fixed_get_preferred_width)
9063 (emacs_fixed_get_preferred_height): Use min_width/height from
9064 frames size_hint to set minimum and natural (Bug#8919).
9065 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9066 and use min_width/height from frames size_hint to set
9067 min_width/height (Bug#8919).
9068
9069 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9070 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9071 Fix indentation.
c7e73be5 9072
cf99dcf8
EZ
90732011-06-26 Eli Zaretskii <eliz@gnu.org>
9074
9075 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9076 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9077 called at ZV.
9078
029529ac
CY
90792011-06-26 Chong Yidong <cyd@stupidchicken.com>
9080
9081 * process.c (wait_reading_process_output): Bypass select if
9082 waiting for a cell while ignoring keyboard input, and input is
9083 pending. Suggested by Jan Djärv (Bug#8869).
9084
7a7ef429
PE
90852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9086
9087 Use gnulib's dup2 module instead of rolling our own.
9088 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9089
11fdef7d 90902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9091
9092 * dispnew.c (scrolling_window): Before scrolling, turn off a
9093 mouse-highlight in the window being scrolled.
9094
cd3520a4
JB
90952011-06-24 Juanma Barranquero <lekktu@gmail.com>
9096
9097 Move DEFSYM to lisp.h and use everywhere.
9098
9099 * character.h (DEFSYM): Move declaration...
9100 * lisp.h (DEFSYM): ...here.
9101
9102 * gnutls.c:
9103 * minibuf.c:
9104 * w32menu.c:
9105 * w32proc.c:
9106 * w32select.c: Don't include character.h.
9107
9108 * alloc.c (syms_of_alloc):
9109 * buffer.c (syms_of_buffer):
9110 * bytecode.c (syms_of_bytecode):
9111 * callint.c (syms_of_callint):
9112 * casefiddle.c (syms_of_casefiddle):
9113 * casetab.c (init_casetab_once):
9114 * category.c (init_category_once, syms_of_category):
9115 * ccl.c (syms_of_ccl):
9116 * cmds.c (syms_of_cmds):
9117 * composite.c (syms_of_composite):
9118 * dbusbind.c (syms_of_dbusbind):
9119 * dired.c (syms_of_dired):
9120 * dispnew.c (syms_of_display):
9121 * doc.c (syms_of_doc):
9122 * editfns.c (syms_of_editfns):
9123 * emacs.c (syms_of_emacs):
9124 * eval.c (syms_of_eval):
9125 * fileio.c (syms_of_fileio):
9126 * fns.c (syms_of_fns):
9127 * frame.c (syms_of_frame):
9128 * fringe.c (syms_of_fringe):
9129 * insdel.c (syms_of_insdel):
9130 * keymap.c (syms_of_keymap):
9131 * lread.c (init_obarray, syms_of_lread):
9132 * macros.c (syms_of_macros):
9133 * msdos.c (syms_of_msdos):
9134 * print.c (syms_of_print):
9135 * process.c (syms_of_process):
9136 * search.c (syms_of_search):
9137 * sound.c (syms_of_sound):
9138 * syntax.c (init_syntax_once, syms_of_syntax):
9139 * terminal.c (syms_of_terminal):
9140 * textprop.c (syms_of_textprop):
9141 * undo.c (syms_of_undo):
9142 * w32.c (globals_of_w32):
9143 * window.c (syms_of_window):
9144 * xdisp.c (syms_of_xdisp):
9145 * xfaces.c (syms_of_xfaces):
9146 * xfns.c (syms_of_xfns):
9147 * xmenu.c (syms_of_xmenu):
9148 * xsettings.c (syms_of_xsettings):
9149 * xterm.c (syms_of_xterm): Use DEFSYM.
9150
4228cf16
TZ
91512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9152
cd3520a4 9153 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9154
7fcccf1e
PE
91552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9156
7efb4e0e
PE
9157 Integer and buffer overflow fixes (Bug#8873).
9158
ff5844ad
PE
9159 * print.c (printchar, strout): Check for string overflow.
9160 (PRINTPREPARE, printchar, strout):
9161 Don't set size unless allocation succeeds.
9162
90532f02
PE
9163 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9164 for sizes. Check for string overflow more accurately.
9165 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9166
6d84508d
PE
9167 * macros.c: Integer and buffer overflow fixes.
9168 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9169 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9170 Use ptrdiff_t, not int, for sizes.
9171 Don't increment bufsize until after realloc succeeds.
9172 Check for size-calculation overflow.
9173 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9174
437b2cb4
PE
9175 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9176
8b9ac8b4
PE
9177 * lread.c: Integer overflow fixes.
9178 (read_integer): Radix is now EMACS_INT, not int,
9179 to improve quality of diagnostics for out-of-range radices.
9180 Calculate buffer size correctly for out-of-range radices.
9181 (read1): Check for integer overflow in radices, and in
9182 read-circle numbers.
82cb60d3
PE
9183 (read_escape): Avoid int overflow.
9184 (Fload, openp, read_buffer_size, read1)
9185 (substitute_object_recurse, read_vector, read_list, map_obarray):
9186 Use ptrdiff_t, not int, for sizes.
9187 (read1): Use EMACS_INT, not int, for sizes.
20270765 9188 Check for size overflow.
8b9ac8b4 9189
7fcccf1e
PE
9190 * image.c (cache_image): Check for size arithmetic overflow.
9191
bfbbd7e7
PE
9192 * lread.c: Integer overflow issues.
9193 (saved_doc_string_size, saved_doc_string_length)
9194 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9195 Now ptrdiff_t, not int.
9196 (read1): Don't assume doc string length fits in int. Check for
9197 out-of-range doc string lengths.
9198 (read_list): Don't assume file position fits in int.
39019e54 9199 (read_escape): Check for hex character overflow.
bfbbd7e7 9200
4e323265
LL
92012011-06-22 Leo Liu <sdl.web@gmail.com>
9202
9203 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9204 Move to minibuffer.el.
9205
85fece3e
PE
92062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9207
20b84ce9 9208 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9209 The following patches are for when GLYPH_DEBUG && !XASSERT.
9210 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9211 * dispnew.c (flush_stdout):
9212 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9213 Mark as externally visible.
9214 * dispnew.c (check_window_matrix_pointers): Now static.
9215 * dispnew.c (window_to_frame_vpos):
9216 * xfns.c (unwind_create_frame):
9217 * xterm.c (x_check_font): Remove unused local.
9218 * scroll.c (CHECK_BOUNDS):
9219 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9220 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9221 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9222 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9223 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9224 Now static.
9225 (debug_method_add): Use va_list and vsprintf rather than relying
9226 on undefined behavior with wrong number of arguments.
9227 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9228 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9229 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9230 since we're not interested in debugging glyphs with old libraries.
9231 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9232 GCC 4.6.0's static checking.
9233
0766b489
PE
92342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9235
31fd4b32
PE
9236 Integer overflow and signedness fixes (Bug#8873).
9237 A few related buffer overrun fixes, too.
9238
b79e8648
PE
9239 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9240
0766b489
PE
9241 * dispextern.h (struct face.stipple):
9242 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9243 (x_bitmap_mask, x_allocate_bitmap_record)
9244 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9245 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9246 (x_create_bitmap_from_xpm_data):
9247 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9248 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9249 (.bitmaps_last):
9250 * xfaces.c (load_pixmap):
9251 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9252 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9253 (.bitmaps_last, struct x_output.icon_bitmap):
9254 Use ptrdiff_t, not int, for bitmap indexes.
9255 (x_allocate_bitmap_record): Check for size overflow.
9256 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9257
b081724f
PE
9258 Use ptrdiff_t, not int, for overlay counts.
9259 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9260 * editfns.c (overlays_around, get_pos_property):
9261 * textprop.c (get_char_property_and_overlay):
9262 * xdisp.c (next_overlay_change, note_mouse_highlight):
9263 * xfaces.c (face_at_buffer_position):
21514da7
PE
9264 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9265 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9266 (Fnext_overlay_change, Fprevious_overlay_change)
9267 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9268 Use ptrdiff_t, not int, for sizes.
21514da7 9269 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9270
3de73e5e
PE
9271 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9272
2606c57b
PE
9273 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9274 (x_session_initialize): Do not assume string length fits in int.
9275
aaafe47a
PE
9276 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9277 This is unlikely, but can occur if DPI is outlandish.
9278
2674ddc8 9279 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9280 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9281
28154962
PE
9282 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9283 * xrdb.c (magic_file_p, search_magic_path):
9284 Omit last arg SUFFIX; it was always 0. All callers changed.
9285 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9286
7de51af5
PE
9287 * xfont.c (xfont_match): Avoid need for strlen.
9288
25ed6cc3
PE
9289 * xfns.c: Don't assume strlen fits in int.
9290 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9291
4eab31dd
PE
9292 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9293 not unsigned long, as we prefer signed integers. All callers changed.
9294 Detect integer overflow in repeat count.
9295 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9296 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9297
171e2a58
PE
9298 * termcap.c: Don't assume sizes fit in int and never overflow.
9299 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9300 (gobble_line): Check for size-calculation overflow.
9301
ad39faca 9302 * minibuf.c (Fread_buffer):
6e5bb2dc 9303 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9304 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9305 Don't assume string length fits in int.
9306
52c61c22 9307 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9308 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9309
b5b8c9e5
PE
9310 * font.c: Don't assume string length fits in int.
9311 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9312 Use ptrdiff_t, not int.
ccd6111c
PE
9313 (font_intern_prop): Don't assume string length fits in int.
9314 Don't assume integer property fits in fixnum.
9315 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9316
882f0d81 9317 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9318 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9319 Reformulate so as not to need the command string.
9320 Invoke gzip -cd rather than gunzip, as it's more portable.
9321 (lock_info_type, lock_file_1, lock_file):
9322 Don't assume pid_t and time_t fit in unsigned long.
9323 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9324 (current_lock_owner): Prefer signed type for sizes.
9325 Use memcpy, not strncpy, where memcpy is what is really wanted.
9326 Don't assume (via atoi) that time_t and pid_t fit in int.
9327 Check for time_t and/or pid_t out of range, e.g., via a network share.
9328 Don't alloca where an auto var works fine.
9329
93f4cf88
PE
9330 * fileio.c: Fix some integer overflow issues.
9331 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9332 Don't assume string length fits in int.
9333 (directory_file_name): Don't assume string length fits in long.
9334 (make_temp_name): Don't assume pid fits in int, or that its print
9335 length is less than 20.
9336
f3e92b69
PE
9337 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9338
1bfdaf10
PE
9339 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9340
35016e9a
PE
9341 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9342
3d1e65a1
PE
9343 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9344 We prefer signed integers, even for size calculations.
9345
0b963a93
PE
9346 * emacs.c: Don't assume string length fits in 'int'.
9347 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9348 (main): Don't invoke strlen when not needed.
9349
573f4b54
PE
9350 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9351 (XD_DEBUG_MESSAGE): Don't waste a byte.
9352
989f33ba
PE
9353 * callproc.c (getenv_internal_1, getenv_internal)
9354 (Fgetenv_internal):
965d34eb
PE
9355 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9356
e4d29b33
PE
9357 * lread.c (invalid_syntax): Omit length argument.
9358 All uses changed. This doesn't fix a bug, but it simplifies the
9359 code away from its former Hollerith-constant appearance, and it's
9360 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9361 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9362
eb49b136
PE
9363 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9364 This didn't break anything, but it didn't help either.
9365 It's confusing to put a bogus integer in a place where the actual
9366 value does not matter.
9f62aeb1 9367 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9368 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9369
15375a22
PE
9370 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9371 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9372 implementation.
b61cc01c
PE
9373 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9374 We prefer signed types, and the value cannot exceed the EMACS_INT
9375 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9376 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9377 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9378 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9379
53b2623d
PE
9380 * indent.c (sane_tab_width): New function.
9381 (current_column, scan_for_column, Findent_to, position_indentation)
9382 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9383 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9384
51cab52b 9385 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9386
f2ed8a70
PE
9387 * lisp.h (lint_assume): New macro.
9388 * composite.c (composition_gstring_put_cache):
9389 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9390
abe80cc6
PE
9391 * editfns.c, insdel.c:
9392 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9393
b02c740e
PE
9394 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9395
ebc96716
PE
9396 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9397
b4e50fa0 9398 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9399 Use much-faster test for byte-length change.
311d5d7c 9400 Don't assume string byte-length fits in 'int'.
a4cf38e4 9401 Check that character arg fits in 'int'.
85461888 9402 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9403
c0c1ee9f
PE
9404 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9405
a498d7f4
PE
9406 * fns.c (concat): Catch string overflow earlier.
9407 Do not rely on integer wraparound.
9408
51cab52b
PE
9409 * dispextern.h (struct it.overlay_strings_charpos)
9410 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9411 * xdisp.c (forward_to_next_line_start)
9412 (back_to_previous_visible_line_start)
9413 (reseat_at_next_visible_line_start, next_element_from_buffer):
9414 Don't arbitrarily truncate the value of 'selective' to int.
9415
76031fad
PE
9416 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9417
5eb55db9
PE
9418 * composite.c: Don't truncate sizes to 'int'.
9419 (composition_gstring_p, composition_reseat_it)
9420 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9421 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9422 not EMACS_UINT, for indexes.
5eb55db9 9423
0703a717
PE
9424 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9425
d6202519
PE
9426 * buffer.c: Include <verify.h>.
9427 (struct sortvec.priority, struct sortstr.priority):
8961a454 9428 Now EMACS_INT, not int.
c20998a7 9429 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9430 (struct sortstr.size, record_overlay_string)
9431 (struct sortstrlist.size, struct sortlist.used):
9432 Don't truncate size to int.
9433 (record_overlay_string): Check for size-calculation overflow.
d6202519 9434 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9435
d5a19415
JM
94362011-06-22 Jim Meyering <meyering@redhat.com>
9437
029529ac 9438 Don't leak an XBM-image-sized buffer
d5a19415
JM
9439 * image.c (xbm_load): Free the image buffer after using it.
9440
a9041e6c
PE
94412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9442
9443 Port to Sun C.
9444 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9445 that Sun C diagnosed.
9446 * fns.c (secure_hash): Fix pointer signedness issue.
9447 * intervals.c (static_offset_intervals): New function.
9448 (offset_intervals): Use it.
9449
7f3f739f
LL
94502011-06-21 Leo Liu <sdl.web@gmail.com>
9451
9452 * deps.mk (fns.o):
9453 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9454 sha512.h.
9455
9456 * fns.c (secure_hash): Rename from crypto_hash_function and change
9457 the first arg to accept symbols.
5b66d427 9458 (Fsecure_hash): New primitive.
7f3f739f
LL
9459 (syms_of_fns): New symbols.
9460
76147d94
DD
94612011-06-20 Deniz Dogan <deniz@dogan.se>
9462
9463 * process.c (Fset_process_buffer): Clarify return value in
9464 docstring.
9465
7d7d0045
CY
94662011-06-18 Chong Yidong <cyd@stupidchicken.com>
9467
9468 * dispnew.c (add_window_display_history): Use BVAR.
9469
9470 * xdisp.c (debug_method_add): Use BVAR.
9471 (check_window_end, dump_glyph_matrix, dump_glyph)
9472 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9473
9474 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9475 Likewise.
9476
9477 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9478 check till after the cache is created in init_frame_faces.
9479
ff2bc410
SM
94802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9481
9482 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9483
28177add
PE
94842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9485
dd3482fe
PE
9486 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9487 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9488 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9489
393d71f3 9490 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9491 * fileio.c (Finsert_file_contents):
9492 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9493 Remove the old (too-loose) buffer overflow checks.
9494 They weren't needed, since make_gap checks for buffer overflow.
9495 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9496 The old code merely checked for Emacs fixnum overflow, and relied
9497 on undefined (wraparound) behavior. The new code avoids undefined
9498 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9499
2e6813b0 9500 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9501 Tune. Don't use wider integers than needed. Don't use alloca.
9502 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9503
599a9e4f
PE
9504 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9505
99561444
PE
9506 * insdel.c, lisp.h (buffer_overflow): New function.
9507 (insert_from_buffer_1, replace_range, replace_range_2):
9508 * insdel.c (make_gap_larger):
9509 * editfns.c (Finsert_char):
9510 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9511
28177add
PE
9512 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9513
e69dafad
PE
95142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9515
4baa020d 9516 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9517
b1c46f02
PE
9518 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9519 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9520
e69dafad
PE
9521 * fileio.c: Don't assume EMACS_INT fits in off_t.
9522 (emacs_lseek): New static function.
9523 (Finsert_file_contents, Fwrite_region): Use it.
9524 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9525
566684ea
PE
9526 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9527
e6966cd6
PE
9528 * fns.c: Don't overflow int when computing a list length.
9529 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9530 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9531 truncation on 64-bit hosts. Check for QUIT every
9532 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9533 faster and is responsive enough.
9534 (Flength): Report an error instead of overflowing an integer.
9535 (Fsafe_length): Return a float if the value is not representable
9536 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9537 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9538 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9539
dd0b0efb
PE
9540 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9541 (header_size, word_size): New constants.
9542 (allocate_vectorlike): Don't check size overflow here.
9543 (allocate_vector): Check it here instead, since this is the only
9544 caller of allocate_vectorlike that could cause overflow.
9545 Check that the new vector's length is representable as a fixnum.
9546
86fe5cfe
PE
9547 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9548 The previous code was bogus. For example, next_almost_prime (32)
9549 returned 39, which is undesirable as it is a multiple of 3; and
9550 next_almost_prime (24) returned 25, which is a multiple of 5 so
9551 why was the code bothering to check for multiples of 7?
9552
80e88859
PE
9553 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9554
4a2f0ad6
PE
9555 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9556
f66c7cf8
PE
9557 Variadic C functions now count arguments with ptrdiff_t.
9558 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9559 Back then I didn't know that the Emacs coding style prefers signed int.
9560 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9561 were being counted with int, which may truncate counts on 64-bit
9562 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9563 * lisp.h (struct Lisp_Subr.function.aMANY)
9564 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9565 Arg counts are now ptrdiff_t, not size_t.
9566 All variadic functions and their callers changed accordingly.
9567 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9568 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9569 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9570 * callint.c (Fcall_interactively): Check arg count for overflow,
9571 to avoid potential buffer overrun. Use signed char, not 'int',
9572 for 'varies' array, so that we needn't bother to check its size
9573 calculation for overflow.
9574 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9575 * eval.c (apply_lambda):
9576 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9577 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9578 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9579
a1759b76
PE
9580 * callint.c (Fcall_interactively): Don't use index var as event count.
9581
d96be9fc
PE
9582 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9583 * mem-limits.h (SIZE): Remove; no longer used.
9584
a690a978 9585 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9586
578c21e6
PE
9587 Remove unnecessary casts.
9588 * xterm.c (x_term_init):
9589 * xfns.c (x_set_border_pixel):
9590 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9591 These aren't needed now that we assume ANSI C.
9592
96f53c6c
PE
9593 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9594 It's more likely to cause problems (due to unsigned overflow)
9595 than to cure them.
9596
83c77d31
PE
9597 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9598
ee2079f1
PE
9599 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9600
6da65536
PE
9601 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9602
7147c4a4
PE
9603 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9604
193e32d9
PE
9605 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9606
e5533da6
PE
9607 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9608
9910e595
PE
9609 GLYPH_CODE_FACE returns EMACS_INT, not int.
9610 * dispextern.h (merge_faces):
9611 * xfaces.c (merge_faces):
01103c44
PE
9612 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9613 Don't assume EMACS_INT fits in int.
9910e595 9614
2638320e
PE
9615 * character.h (CHAR_VALID_P): Remove unused parameter.
9616 * fontset.c, lisp.h, xdisp.c: All uses changed.
9617
045eb8d9
PE
9618 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9619
c1f134b5
PE
9620 * fns.c (concat): Minor tuning based on overflow analysis.
9621 This doesn't fix any bugs. Use int to hold character, instead
9622 of constantly refetching from Emacs object. Use XFASTINT, not
9623 XINT, for value known to be a character. Don't bother comparing
9624 a single byte to 0400, as it's always less.
9625
395fcb93 9626 * floatfns.c (Fexpt):
327eeec8
PE
9627 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9628
abbd3d23
PE
9629 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9630 for characters.
9631
684a03ef
PE
9632 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9633
0fed43f3
PE
9634 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9635 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9636 incorrectly succeed when S was a string, because 4294967386 was
9637 truncated before it was used.
9638
8fd02eb7
PE
9639 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9640 Otherwise, an out-of-range integer could cause undefined behavior
9641 on a 64-bit host.
9642
f8c86b69
PE
9643 * composite.c: Use int, not EMACS_INT, for characters.
9644 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9645 EMACS_INT, for values that are known to be in character range.
9646 This doesn't fix any bugs but is the usual style inside Emacs and
9647 may generate better code on 32-bit machines.
9648
34206dd2
PE
9649 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9650 This is for reasons similar to the recent CHAR_STRING fix.
9651 * charset.c (Fencode_char): Check that character arg is actually
9652 a character. Pass an int to ENCODE_CHAR.
9653 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9654 wider than 'int', as a compile-time check to prevent future regressions
9655 in this area.
9656
c5958d4c 9657 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9658
9659 Make sure a 64-bit char is never passed to CHAR_STRING.
9660 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9661 by silently ignoring the top 32 bits, allowing some values
9662 that were far too large to be valid characters.
9663 * character.h: Include <verify.h>.
9664 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9665 arguments are no wider than unsigned, as a compile-time check
9666 to prevent future regressions in this area.
9667 * data.c (Faset):
01103c44 9668 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9669 (Fsubst_char_in_region):
9670 * fns.c (concat):
9671 * xdisp.c (decode_mode_spec_coding):
9672 Adjust to CHAR_STRING's new requirement.
9673 * editfns.c (Finsert_char, Fsubst_char_in_region):
9674 * fns.c (concat): Check that character args are actually
9675 characters. Without this test, these functions did the wrong
9676 thing with wildly out-of-range values on 64-bit hosts.
9677
d37ca623
PE
9678 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9679 These casts should not be needed on 32-bit hosts, either.
9680 * keyboard.c (read_char):
9681 * lread.c (Fload): Remove casts to unsigned.
9682
ea204efb
PE
9683 * lisp.h (UNSIGNED_CMP): New macro.
9684 This fixes comparison bugs on 64-bit hosts.
9685 (ASCII_CHAR_P): Use it.
9686 * casefiddle.c (casify_object):
01103c44 9687 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9688 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9689 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9690 * dispextern.h (FACE_FROM_ID):
9691 * keyboard.c (read_char): Use UNSIGNED_CMP.
9692
41cb286c
PE
9693 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9694 not to EMACS_INT, to avoid GCC warning.
9695
4a1b9832
PE
9696 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9697
55daad71
PE
9698 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9699 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9700 isn't needed on 32-bit machines.
8f95c75c 9701
01103c44
PE
9702 * buffer.c (Fgenerate_new_buffer_name):
9703 Use EMACS_INT for count, not int.
0ceccced 9704 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9705
9706 * data.c (Qcompiled_function): Now static.
9707
c6f072e7
PE
9708 * window.c (window_body_lines): Now static.
9709
20ce5912
PE
9710 * image.c (gif_load): Rename local to avoid shadowing.
9711
9c4c5f81
PE
9712 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9713 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9714 * alloc.c (make_save_value): Integer argument is now of type
9715 ptrdiff_t, not int.
9716 (mark_object): Use ptrdiff_t, not int.
9717 * lisp.h (pD): New macro.
9718 * print.c (print_object): Use it.
9719
c0c5c8ae
PE
9720 * alloc.c: Use EMACS_INT, not int, to count objects.
9721 (total_conses, total_markers, total_symbols, total_vector_size)
9722 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9723 (total_free_floats, total_floats, total_free_intervals)
9724 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9725 Now EMACS_INT, not int. All uses changed.
9726 (Fgarbage_collect): Compute overall total using a double, so that
9727 integer overflow is less likely to be a problem. Check for overflow
9728 when converting back to an integer.
5a25e253
PE
9729 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9730 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9731 These were 'int' variables that could overflow on 64-bit hosts;
9732 they were never used, so remove them instead of repairing them.
211a0b2a 9733 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9734 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9735 Previously, this ceilinged at INT_MAX, but that doesn't work on
9736 64-bit machines.
e46bb31a 9737 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9738
c78baabf 9739 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9740 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9741 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9742 when a (possibly-narrower) signed value would do just as well.
9743 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9744
c9d624c6
PE
9745 * alloc.c: Catch some string size overflows that we were missing.
9746 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9747 for convenience in STRING_BYTES_MAX.
9748 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9749 The definition here is exact; the one in lisp.h was approximate.
9750 (allocate_string_data): Check for string overflow. This catches
9751 some instances we weren't catching before. Also, it catches
9752 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9753 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9754 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9755
c9d624c6
PE
9756 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9757 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9758 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9759
353032ce
PE
9760 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9761
2bccce07
PE
9762 * alloc.c (Fmake_string): Check for out-of-range init.
9763
0ac30604
SM
97642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9765
9766 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9767
c195f2de
JD
97682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9769
9770 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9771 xg_get_default_scrollbar_width.
9772
9773 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9774 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9775 (style_changed_cb): Call update_theme_scrollbar_width and call
9776 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9777 all frames (Bug#8505).
9778 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9779 Call gtk_window_set_resizable if HAVE_GTK3.
9780 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9781 and height if HAVE_GTK3 (Bug#8505).
9782 (scroll_bar_width_for_theme): New variable.
9783 (update_theme_scrollbar_width): New function.
9784 (xg_get_default_scrollbar_width): Move code to
9785 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9786 (xg_initialize): Call update_theme_scrollbar_width.
9787
9788 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9789
9790 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9791
e10ac9f1
MR
97922011-06-12 Martin Rudalics <rudalics@gmx.at>
9793
9794 * frame.c (make_frame): Call other_buffer_safely instead of
9795 other_buffer.
9796
9797 * window.c (temp_output_buffer_show): Call display_buffer with
9798 second argument Vtemp_buffer_show_specifiers and reset latter
9799 immediately after the call.
9800 (Vtemp_buffer_show_specifiers): New variable.
9801 (auto_window_vscroll_p, next_screen_context_lines)
9802 (Vscroll_preserve_screen_position): Remove leading asterisks from
9803 doc-strings.
9804
2d3c217e 98052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9806
7b7f97e8 9807 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9808 * buffer.c (Qclone_number): Remove for now, as it's unused.
9809 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9810 (record_buffer): Remove unused local.
9811 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9812 (set_frame_buffer_list): Remove; unused.
9813 * frame.h (other_visible_frames): Remove decl.
9814 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9815 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9816 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9817 if HAVE_GPM.
9818 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9819 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9820 Define only if HAVE_GPM.
9821 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9822 (update_hints_inhibit): Remove; never set. All uses removed.
9823 * widgetprv.h (emacsFrameClassRec): Remove decl.
9824 * window.c (delete_deletable_window): Now returns void, since it
9825 wasn't returning anything.
9826 (compare_window_configurations): Remove unused locals.
9827 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9828 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9829 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9830 the same widths as pointers. This follows up on the 2011-05-06 patch.
9831 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9832 * xterm.h: Likewise.
9833 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9834
1384b89e
JB
98352011-06-12 Juanma Barranquero <lekktu@gmail.com>
9836
9837 * makefile.w32-in: Update dependencies.
9838 (LISP_H): Add lib/intprops.h.
9839
1100a63c
CY
98402011-06-11 Chong Yidong <cyd@stupidchicken.com>
9841
9842 * image.c (gif_load): Add animation frame delay to the metadata.
9843 (syms_of_image): Use DEFSYM. New symbol `delay'.
9844
6198ccd0
MR
98452011-06-11 Martin Rudalics <rudalics@gmx.at>
9846
9847 * window.c (delete_deletable_window): Re-add.
9848 (Fset_window_configuration): Rewrite to handle dead buffers and
9849 consequently deletable windows.
9850 (window_tree, Fwindow_tree): Remove. Supply functionality in
9851 window.el.
9852 (compare_window_configurations): Simplify code.
9853
b6e3633c
AS
98542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9855
1ab0dee5
AS
9856 * image.c (imagemagick_load_image): Fix type mismatch.
9857 (Fimagemagick_types): Likewise.
9858
b6e3633c
AS
9859 * window.h (replace_buffer_in_windows): Declare.
9860
9397e56f
MR
98612011-06-11 Martin Rudalics <rudalics@gmx.at>
9862
9863 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9864 Qclone_number. Remove external declaration of Qdelete_window.
9865 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9866 code.
640c8776
SM
9867 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9868 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9869 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9870 buffer list implementation.
9871 (other_buffer_safely): New function.
9872 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9873 calls to replace_buffer_in_windows and
9874 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9875 if allowed.
9876 (record_buffer): Inhibit quitting and rewrite using quittable
9877 functions. Run Qbuffer_list_update_hook if allowed.
9878 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9879 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9880 Move switch-to-buffer to window.el.
9397e56f
MR
9881 (bury-buffer): Move to window.el.
9882 (Vbuffer_list_update_hook): New variable.
9883
9884 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9885 section.
9886
9887 * window.h (resize_frame_windows): Move up in code.
9888 (Fwindow_frame): Remove EXFUN.
9889 (replace_buffer_in_all_windows): Remove prototype.
9890 (replace_buffer_in_windows_safely): Add prototype.
9891
9892 * window.c: Declare Qdelete_window static again. Move down
9893 declaration of select_count.
9894 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9895 (Fother_window): Move to window.el.
9896 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9897 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9898 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9899 window.el.
9900 (replace_buffer_in_windows): Implement by calling
9901 Qreplace_buffer_in_windows.
9902 (replace_buffer_in_all_windows): Remove with some functionality
9903 moved into replace_buffer_in_windows_safely.
9904 (replace_buffer_in_windows_safely): New function.
9905 (select_window_norecord, select_frame_norecord): Move in front
9906 of run_window_configuration_change_hook. Remove now obsolete
9907 declarations.
640c8776
SM
9908 (Fset_window_buffer): Rewrite doc-string.
9909 Call Qrecord_window_buffer.
9397e56f
MR
9910 (keys_of_window): Move binding for other-window to window.el.
9911
b50691aa
CY
99122011-06-11 Chong Yidong <cyd@stupidchicken.com>
9913
9914 * dispextern.h (struct image): Replace data member, whose int_val
9915 and ptr_val fields were not used by anything, with a single
9916 lisp_val object.
9917
9918 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9919 (gif_clear_image, gif_load, imagemagick_load_image)
9920 (gs_clear_image, gs_load): Callers changed.
9921
3f754b86
PE
99222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9923
cca69397
PE
9924 * buffer.h: Include <time.h>, for time_t.
9925 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9926
109e28d0
PE
9927 Fix minor problems found by static checking.
9928
60737f02
PE
9929 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9930
4b66faf3
PE
9931 Make identifiers static if they are not used in other modules.
9932 * data.c (Qcompiled_function, Qframe, Qvector):
9933 * image.c (QimageMagick, Qsvg):
9934 * minibuf.c (Qmetadata):
9935 * window.c (resize_window_check, resize_root_window): Now static.
9936 * window.h (resize_window_check, resize_root_window): Remove decls.
9937
109e28d0
PE
9938 * window.c (window_deletion_count, delete_deletable_window):
9939 Remove; unused.
46a4ce9e
PE
9940 (window_body_lines): Now static.
9941 (Fdelete_other_windows_internal): Mark vars as initialized.
9942 Make sure 'resize_failed' is initialized.
9943 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9944 (resize_window_apply): Remove unused local.
9945 * window.h (delete_deletable_window): Remove decl.
9946
109e28d0 9947 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9948 (imagemagick_load_image): Fix pointer signedness problem by changing
9949 last arg from unsigned char * to char *. All uses changed.
9950 Also, fix a local for similar reasons.
9951 Remove unused locals. Remove locals to avoid shadowing.
9952 (fn_rsvg_handle_free): Remove; unused.
9953 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9954 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9955
3f754b86
PE
9956 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9957
2547adb1
CY
99582011-06-10 Chong Yidong <cyd@stupidchicken.com>
9959
9960 * image.c (gif_load): Fix omitted cast error introduced by
9961 2011-06-06 change.
9962
2c8e37d4
MR
99632011-06-10 Martin Rudalics <rudalics@gmx.at>
9964
9965 * window.h (resize_proportionally, orig_total_lines)
9966 (orig_top_line): Remove from window structure.
9967 (set_window_height, set_window_width, change_window_heights)
9968 (Fdelete_window): Remove prototypes.
9969 (resize_frame_windows): Remove duplicate declaration.
9970
440a42e3
EZ
99712011-06-10 Eli Zaretskii <eliz@gnu.org>
9972
9973 * window.h (resize_frame_windows, resize_window_check)
9974 (delete_deletable_window, resize_root_window)
9975 (resize_frame_windows): Declare prototypes.
9976
9977 * window.c (resize_window_apply): Make definition be "static" to
9978 match the prototype.
9979
562dd5e9
MR
99802011-06-10 Martin Rudalics <rudalics@gmx.at>
9981
9982 * window.c: Remove declarations of Qwindow_size_fixed,
9983 window_min_size_1, window_min_size_2, window_min_size,
9984 size_window, window_fixed_size_p, enlarge_window, delete_window.
9985 Remove static from declaration of Qdelete_window, it's
9986 temporarily needed by Fbury_buffer.
9987 (replace_window): Don't assign orig_top_line and
9988 orig_total_lines.
9989 (Fdelete_window, delete_window): Remove. Window deletion is
9990 handled by window.el.
640c8776
SM
9991 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9992 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9993 (Fdelete_other_windows): Remove. Deleting other windows is
9994 handled by window.el.
9995 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9996 handled in window.el.
9997 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9998 Window minimum sizes are handled in window.el.
9999 (shrink_windows, size_window, set_window_height)
10000 (set_window_width, change_window_heights, window_height)
10001 (window_width, CURBEG, CURSIZE, enlarge_window)
10002 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10003 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10004 handled in window.el.
10005 (make_dummy_parent): Rename to make_parent_window and give it a
10006 second argument horflag.
10007 (make_window): Don't set resize_proportionally any more.
10008 (Fsplit_window): Remove. Windows are split in window.el.
10009 (save_restore_action, save_restore_orig_size)
10010 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10011 Resize mini windows in window.el.
10012 (grow_mini_window, shrink_mini_window): Implement by calling
10013 Qresize_root_window_vertically, resize_window_check and
10014 resize_window_apply.
640c8776
SM
10015 (saved_window, Fset_window_configuration, save_window_save):
10016 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10017 resize_proportionally.
10018 (window_min_height, window_min_width): Move to window.el.
10019 (keys_of_window): Move bindings for delete-other-windows,
10020 split-window, delete-window and enlarge-window to window.el.
10021
10022 * buffer.c: Temporarily extern Qdelete_window.
10023 (Fbury_buffer): Temporarily call Qdelete_window instead of
10024 Fdelete_window (Fbury_buffer will move to window.el soon).
10025
10026 * frame.c (set_menu_bar_lines_1): Remove code handling
10027 orig_top_line and orig_total_lines.
10028
10029 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10030 set_window_height but set heights directly.
10031 (change_frame_size_1): Use resize_frame_windows.
10032
10033 * xdisp.c (init_xdisp): Don't use set_window_height but set
10034 heights directly.
10035
640c8776
SM
10036 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10037 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10038 run_window_configuration_change_hook.
10039
10040 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10041 instead of change_window_heights and run
10042 run_window_configuration_change_hook.
10043
1a13852e
MR
100442011-06-09 Martin Rudalics <rudalics@gmx.at>
10045
10046 * window.c (replace_window): Rename second argument REPLACEMENT to
10047 NEW. New third argument SETFLAG. Rewrite.
10048 (delete_window, make_dummy_parent): Call replace_window with
10049 third argument 1.
10050 (window_list_1): Move down in code.
10051 (run_window_configuration_change_hook): Move set_buffer part
10052 before select_frame_norecord part in order to unwind correctly.
10053 Rename count1 to count.
10054 (recombine_windows, delete_deletable_window, resize_root_window)
10055 (Fdelete_other_windows_internal)
10056 (Frun_window_configuration_change_hook, make_parent_window)
10057 (resize_window_check, resize_window_apply, Fresize_window_apply)
10058 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10059 (Fdelete_window_internal, Fresize_mini_window_internal):
10060 New functions.
1a13852e
MR
10061 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10062
f3d1777e
MR
100632011-06-08 Martin Rudalics <rudalics@gmx.at>
10064
496e208e
MR
10065 * window.h (window): Add some new members to window structure -
10066 normal_lines, normal_cols, new_total, new_normal, clone_number,
10067 splits, nest, prev_buffers, next_buffers.
10068 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10069 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10070
f3d1777e
MR
10071 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10072 Remove.
496e208e
MR
10073 (make_dummy_parent): Set new members of windows structure.
10074 (make_window): Move down in code. Handle new members of window
10075 structure.
10076 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10077 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10078 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10079 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10080 (Fset_window_next_buffers, Fset_window_clone_number):
10081 New functions.
496e208e
MR
10082 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10083 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10084 Doc-string fixes.
10085 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10086 Argument WINDOW can be now internal window too.
10087 (Fwindow_use_time): Move up in code.
10088 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10089 Rewrite doc-string.
10090 (Fset_window_configuration, saved_window)
10091 (Fcurrent_window_configuration, save_window_save): Handle new
10092 members of window structure.
b9e809c2
MR
10093 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10094 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10095 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10096 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10097 Qget_mru_window, Qresize_root_window,
10098 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10099 Qauto_buffer_name; staticpro them.
f3d1777e 10100
abde8f8c
MR
101012011-06-07 Martin Rudalics <rudalics@gmx.at>
10102
10103 * window.c (Fwindow_total_size, Fwindow_left_column)
10104 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10105 (Fwindow_list_1): New functions.
10106 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10107 (Fwindow_width, Fscroll_left, Fscroll_right):
10108 Use window_body_cols instead of window_box_text_cols.
10109 (delete_window, Fset_window_configuration):
10110 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10111 (delete_all_subwindows): Take a window as argument and not a
10112 structure. Rewrite.
190b47e6
MR
10113 (window_loop): Remove handling of GET_LRU_WINDOW and
10114 GET_LARGEST_WINDOW.
10115 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10116
10117 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10118 window_box_text_cols. delete_all_subwindows now takes a
10119 Lisp_Object as argument.
abde8f8c 10120
640c8776
SM
10121 * indent.c (compute_motion, Fcompute_motion):
10122 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10123
fa8a67e6
MR
10124 * frame.c (delete_frame): Call delete_all_subwindows with root
10125 window as argument.
10126
a54e3482
DC
101272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10128
10129 * fns.c (Fputhash): Document return value.
10130
60002bf5
CY
101312011-06-06 Chong Yidong <cyd@stupidchicken.com>
10132
10133 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10134
0c671da6 101352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10136
b862a52a 10137 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10138
be44ca6c
PE
10139 Check for overflow when converting integer to cons and back.
10140 * charset.c (Fdefine_charset_internal, Fdecode_char):
10141 Use cons_to_unsigned to catch overflow.
10142 (Fencode_char): Use INTEGER_TO_CONS.
10143 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10144 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10145 * data.c (long_to_cons, cons_to_long): Remove.
10146 (cons_to_unsigned, cons_to_signed): New functions.
10147 These signal an error for invalid or out-of-range values.
10148 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10149 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10150 * font.c (Ffont_variation_glyphs):
10151 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10152 * lisp.h: Include <intprops.h>.
10153 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10154 (cons_to_signed, cons_to_unsigned): New decls.
10155 (long_to_cons, cons_to_long): Remove decls.
10156 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10157 (Fprimitive_undo): Use CONS_TO_INTEGER.
10158 * xfns.c (Fx_window_property): Likewise.
10159 * xselect.c: Include <limits.h>.
10160 (x_own_selection, selection_data_to_lisp_data):
10161 Use INTEGER_TO_CONS.
10162 (x_handle_selection_request, x_handle_selection_clear)
10163 (x_get_foreign_selection, Fx_disown_selection_internal)
10164 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10165 (lisp_data_to_selection_data): Use cons_to_unsigned.
10166 (x_fill_property_data): Use cons_to_signed.
10167 Report values out of range.
10168
d1f3d2af
PE
10169 Check for buffer and string overflow more precisely.
10170 * buffer.h (BUF_BYTES_MAX): New macro.
10171 * lisp.h (STRING_BYTES_MAX): New macro.
10172 * alloc.c (Fmake_string):
10173 * character.c (string_escape_byte8):
10174 * coding.c (coding_alloc_by_realloc):
10175 * doprnt.c (doprnt):
10176 * editfns.c (Fformat):
10177 * eval.c (verror):
10178 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10179 since they may not be the same number.
10180 * editfns.c (Finsert_char):
10181 * fileio.c (Finsert_file_contents):
10182 Likewise for BUF_BYTES_MAX.
10183
dd52fcea
PE
10184 * image.c: Use ptrdiff_t, not int, for sizes.
10185 (slurp_file): Switch from int to ptrdiff_t.
10186 All uses changed.
10187 (slurp_file): Check that file size fits in both size_t (for
10188 malloc) and ptrdiff_t (for sanity and safety).
10189
7f9bbdbb
PE
10190 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10191 if b->modtime has its maximal value.
10192
dfe18f82
PE
10193 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10194
84acfcf0
PE
10195 Don't assume time_t can fit into int.
10196 * buffer.h (struct buffer.modtime): Now time_t, not int.
10197 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10198 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10199
ccd9a01a
PE
10200 Minor fixes for signed vs unsigned integers.
10201 * character.h (MAYBE_UNIFY_CHAR):
10202 * charset.c (maybe_unify_char):
10203 * keyboard.c (read_char, reorder_modifiers):
10204 XINT -> XFASTINT, since the integer must be nonnegative.
10205 * ftfont.c (ftfont_spec_pattern):
10206 * keymap.c (access_keymap, silly_event_symbol_error):
10207 XUINT -> XFASTINT, since the integer must be nonnegative.
10208 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10209 since it makes no difference and we prefer signed.
10210 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10211 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10212 nonnegative.
10213
d6d100dd
SM
102142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10215
10216 * window.h (Fwindow_frame): Declare.
10217
2b6148e4
PE
102182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10219
10220 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10221 (SPARE_MEMORY): Always define.
10222 (LARGE_REQUEST): Remove.
10223 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10224
f230ecc9
MR
102252011-06-06 Martin Rudalics <rudalics@gmx.at>
10226
727e958e
MR
10227 * lisp.h: Move EXFUNS for Fframe_root_window,
10228 Fframe_first_window and Fset_frame_selected_window to window.h.
10229
10230 * window.h: Move EXFUNS for Fframe_root_window,
10231 Fframe_first_window and Fset_frame_selected_window here from
10232 lisp.h.
10233
10234 * frame.c (Fwindow_frame, Fframe_first_window)
10235 (Fframe_root_window, Fframe_selected_window)
10236 (Fset_frame_selected_window): Move to window.c.
10237 (Factive_minibuffer_window): Move to minibuf.c.
10238 (Fother_visible_frames_p): New function.
10239
10240 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10241
f230ecc9
MR
10242 * window.c (decode_window, decode_any_window): Move up in code.
10243 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10244 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10245 (Fwindow_buffer): Move up and rewrite doc-string.
10246 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10247 (Fwindow_prev): New functions.
727e958e
MR
10248 (Fwindow_frame): Move here from frame.c. Accept any window as
10249 argument.
10250 (Fframe_root_window, Fframe_first_window)
10251 (Fframe_selected_window): Move here from frame.c. Accept frame
10252 or arbitrary window as argument. Update doc-strings.
10253 (Fminibuffer_window): Move up in code.
10254 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10255 (Fset_frame_selected_window): Move here from frame.c.
10256 Marginal rewrite.
727e958e
MR
10257 (Fselected_window, select_window, Fselect_window): Move up in
10258 code. Minor doc-string fixes.
f230ecc9 10259
4d09bcf6
PE
102602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10261
10262 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10263 Do not assume that spare memory exists; that assumption is valid
10264 only if SYSTEM_MALLOC.
10265 (LARGE_REQUEST): New macro, so that the issue of large requests
10266 is separated from the issue of spare memory.
10267
810928a2
AS
102682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10269
172418ad
AS
10270 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10271 format. (Bug#8806)
10272
43f862f7
AS
10273 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10274
810928a2
AS
10275 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10276 before statements.
10277
a059fe24
JD
102782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10279
10280 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10281
10282 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10283
10284 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10285 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10286
989bf368
JB
102872011-06-05 Juanma Barranquero <lekktu@gmail.com>
10288
10289 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10290
4b80f674
CY
102912011-06-04 Chong Yidong <cyd@stupidchicken.com>
10292
10293 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10294 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10295 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10296 New error handlers.
4b80f674
CY
10297 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10298 Obey Vx_select_enable_clipboard_manager. Catch errors in
10299 x_clipboard_manager_save (Bug#8779).
10300 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10301 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10302
99a33b77 103032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10304
10305 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10306
99a33b77 103072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10308
10309 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10310 in the current matrix if keep_current_p is non-zero.
10311
8264569d
EZ
103122011-06-04 Eli Zaretskii <eliz@gnu.org>
10313
10314 * bidi.c (bidi_level_of_next_char): Fix last change.
10315
57f97249
EZ
103162011-06-03 Eli Zaretskii <eliz@gnu.org>
10317
fec2107c 10318 Support bidi reordering of text covered by display properties.
57f97249 10319
fec2107c
EZ
10320 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10321 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10322 (bidi_cache_search, bidi_cache_iterator_state)
10323 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10324 (bidi_level_of_next_char, bidi_move_to_visually_next):
10325 Support character positions inside a run of characters covered by a
fec2107c
EZ
10326 display string.
10327 (bidi_paragraph_init, bidi_resolve_explicit_1)
10328 (bidi_level_of_next_char): Call bidi_fetch_char and
10329 bidi_fetch_char_advance instead of FETCH_CHAR and
10330 FETCH_CHAR_ADVANCE.
10331 (bidi_init_it): Initialize new members.
10332 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10333 definitions.
10334 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10335 instead of using explicit *_CHAR codes.
d6d100dd
SM
10336 (bidi_resolve_explicit, bidi_resolve_weak):
10337 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10338 bidirectional text is supported only in multibyte buffers.
10339 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10340 it to initialize the frame_window_p member of struct bidi_it.
10341 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10342 (bidi_resolve_explicit, bidi_resolve_weak)
10343 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10344 bidi_it->nchars is non-positive.
10345 (bidi_level_of_next_char): Don't try to lookup the cache for the
10346 next/previous character if nothing is cached there yet, or if we
10347 were just reseat()'ed to a new position.
c40e2fb2 10348
0e14fe90
EZ
10349 * xdisp.c (set_cursor_from_row): Set start and stop points
10350 according to the row's direction when priming the loop that looks
10351 for the glyph on which to display cursor.
10352 (single_display_spec_intangible_p): Function deleted.
10353 (display_prop_intangible_p): Reimplement to call
10354 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10355 Accept 3 additional arguments needed by handle_display_spec.
10356 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10357 values: lists, `(when COND...)' forms, etc.
10358 (single_display_spec_string_p): Support property values that are
10359 lists with the argument STRING its top-level element.
10360 (display_prop_string_p): Fix the condition for processing a
10361 property that is a list to be consistent with handle_display_spec.
fec2107c 10362 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10363 last portion of handle_display_prop.
10364 (compute_display_string_pos): Accept additional argument
10365 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10366 value of a `display' property is a "replacing spec".
10367 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10368 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10369 the display property, but just return a value indicating whether
10370 the display property will replace the characters it covers.
10371 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10372 frame_window_p members of struct bidi_it.
d6d100dd
SM
10373 (compute_display_string_pos, compute_display_string_end):
10374 New functions.
fec2107c
EZ
10375 (push_it): Accept second argument POSITION, where pop_it should
10376 jump to continue iteration.
10377 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10378
fec2107c
EZ
10379 * keyboard.c (adjust_point_for_property): Adjust the call to
10380 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10381
10382 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10383 (bidi_init_it): Update prototypes.
10384 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10385 (compute_display_string_pos, compute_display_string_end):
10386 Declare prototypes.
fec2107c
EZ
10387 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10388 EMACS_INT.
fc6f18ce 10389
40087514 103902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10391
57f53182
PE
10392 Malloc failure behavior now depends on size of allocation.
10393 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10394 * lisp.h: Change signatures accordingly.
10395 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10396 All callers changed. (Bug#8762)
10397
10398 * gnutls.c: Use Emacs's memory allocators.
10399 Without this change, the gnutls library would invoke malloc etc.
10400 directly, which causes problems on non-SYNC_INPUT hosts, and which
10401 runs afoul of improving memory_full behavior. (Bug#8761)
10402 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10403 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10404 xfree instead of the default malloc, realloc, free.
10405 (Fgnutls_boot): No need to check for memory allocation failure,
10406 since xmalloc does that for us.
10407
ac32cd99 10408 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10409 * category.c (hash_get_category_set):
10410 * ccl.c (ccl_driver):
10411 * charset.c (Fdefine_charset_internal):
10412 * charset.h (struct charset.hash_index):
10413 * composite.c (get_composition_id, gstring_lookup_cache)
10414 (composition_gstring_put_cache):
10415 * composite.h (struct composition.hash_index):
10416 * dispextern.h (struct image.hash):
10417 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10418 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10419 (hashfn_equal, hashfn_user_defined, make_hash_table)
10420 (maybe_resize_hash_table, hash_lookup, hash_put)
10421 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10422 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10423 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10424 * image.c (make_image, search_image_cache, lookup_image)
10425 (xpm_put_color_table_h):
10426 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10427 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10428 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10429 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10430 * alloc.c (allocate_vectorlike):
10431 Check for overflow in vector size calculations.
10432 * ccl.c (ccl_driver):
10433 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10434 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10435 need to be updated by these changes.
40087514
PE
10436 * fns.c (make_hash_table, maybe_resize_hash_table):
10437 Check for integer overflow with large hash tables.
0de4bb68
PE
10438 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10439 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10440 (SXHASH_REDUCE): New macro.
10441 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10442 Use it instead of discarding useful hash info with large hash values.
10443 (sxhash_float): New function.
10444 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10445 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10446 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10447 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10448 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10449 Adjust signatures to match updated version of code.
10450 (consing_since_gc): Now EMACS_INT, since a single hash table can
10451 use more than INT_MAX bytes.
10452
698d32e2
DN
104532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10454
10455 Make it possible to build with GCC-4.6+ -O2 -flto.
10456
10457 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10458
fd6fa53f
SM
104592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10460
10461 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10462 Call minibuffer-inactive-mode.
10463
864db017
JB
104642011-05-31 Juanma Barranquero <lekktu@gmail.com>
10465
10466 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10467 Update dependencies.
10468
2ad0baf4
DN
104692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10470
10471 * data.c (init_data): Remove code for UTS, this system is not
10472 supported anymore.
10473
4fcc2638
DN
104742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10475
10476 Don't force ./temacs to start in terminal mode.
10477
10478 * frame.c (make_initial_frame): Initialize faces in all cases, not
10479 only when CANNOT_DUMP is defined.
10480 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10481
c56e0fd5
DN
104822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10483
10484 * dispnew.c (add_window_display_history): Use const for the string
10485 pointer. Remove declaration, not needed.
10486
333d54da 104872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10488
55d4c1b2 10489 Use 'inline', not 'INLINE'.
333d54da 10490 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10491 * alloc.c, fontset.c (INLINE): Remove.
10492 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10493 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10494 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10495 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10496 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10497
738db178
DN
104982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10499
10500 Make it possible to run ./temacs.
10501
10502 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10503 syms_of_callproc does the same thing. Remove test for
10504 "initialized", do it in the caller.
10505 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10506
620c53a6
SM
105072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10508
10509 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10510 (read_minibuf): Use get_minibuffer.
10511 (syms_of_minibuf): Use DEFSYM.
10512 (Qmetadata): New var.
10513 * data.c (Qbuffer): Don't make it static.
10514 (syms_of_data): Use DEFSYM.
10515
e003a292
PE
105162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10517
10518 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10519 (CCL_CODE_MIN): New macro.
10520
ed008a6d
PE
105212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10522
3687c2ef
PE
10523 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10524
ed008a6d
PE
10525 * eval.c (Qdebug): Now static.
10526 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10527 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10528 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10529
d66c4c7c
CY
105302011-05-29 Chong Yidong <cyd@stupidchicken.com>
10531
10532 * image.c: Various fixes to ImageMagick code comments.
10533 (Fimagemagick_types): Doc fix.
10534
5fbc2025
PE
105352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10536
0196f88a
PE
10537 Minor fixes prompted by GCC 4.6.0 warnings.
10538
10539 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10540
5fbc2025
PE
10541 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10542 (x_clipboard_manager_save_all): Move extern decl to ...
10543 * xterm.h: ... here, so that it can be checked for consistency.
10544
1dd3c2d9
CY
105452011-05-29 Chong Yidong <cyd@stupidchicken.com>
10546
10547 * xselect.c (x_clipboard_manager_save_frame)
10548 (x_clipboard_manager_save_all): New functions.
10549 (Fx_clipboard_manager_save): Lisp function deleted.
10550
10551 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10552 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10553
10554 * xterm.h: Update prototype.
10555
5ba6571d
WX
105562011-05-28 William Xu <william.xwl@gmail.com>
10557
10558 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10559 exiting (Bug#8239).
10560
3eaff834
JM
105612011-05-28 Jim Meyering <meyering@redhat.com>
10562
e1900994 10563 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10564 * fns.c (to_uchar): Define.
10565 (crypto_hash_function): Use it to convert some newly-signed
10566 variables to unsigned, to avoid sign-extension bugs. For example,
10567 without this change, (md5 "truc") would evaluate to
10568 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10569 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10570 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10571
0f6990a7
PE
105722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10573
10574 Integer overflow fixes.
c8a9ca5a 10575
08686060
PE
10576 * dbusbind.c: Serial number integer overflow fixes.
10577 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10578 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10579 to hold a serial number that is too large for a fixnum.
10580 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10581 Check for serial numbers out of range. Decode any serial number
59568bf0 10582 that was so large that it became a float. (Bug#8722)
08686060 10583
2d1fc3c7
PE
10584 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10585 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10586 Use XFASTINT rather than XUINT when numbers are nonnegative.
10587 (xd_append_arg, Fdbus_method_return_internal):
10588 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10589 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10590 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10591 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10592 (Bug#8722)
2d1fc3c7 10593
c8a9ca5a
PE
10594 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10595
519e1d69
PE
10596 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10597
6df6ae42 10598 ccl: Add integer overflow checks.
30569699
PE
10599 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10600 (IN_INT_RANGE): New macros.
10601 (ccl_driver): Use them to check for integer overflow when
10602 decoding a CCL program. Many of the new checks are whether XINT (x)
10603 fits in int; it doesn't always, on 64-bit hosts. The new version
10604 doesn't catch all possible integer overflows, but it's an
847044ea 10605 improvement. (Bug#8719)
30569699 10606
c11285dc
PE
10607 * alloc.c (make_event_array): Use XINT, not XUINT.
10608 There's no need for unsigned here.
10609
fdccd48e
PE
10610 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10611 This follows up to the 2011-05-06 change that substituted uintptr_t
10612 for EMACS_INT. This case wasn't caught back then.
10613
37910ab2
PE
10614 Rework Fformat to avoid integer overflow issues.
10615 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10616 now (part of C89). Include <verify.h>.
10617 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10618 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10619 (Fformat): Avoid the prepass trying to compute sizes; it was only
10620 approximate and thus did not catch overflow reliably. Instead, walk
10621 through the format just once, formatting and computing sizes as we go,
10622 checking for integer overflow at every step, and allocating a larger
10623 buffer as needed. Keep track separately whether the format is
10624 multibyte. Keep only the most-recently calculated precision, rather
10625 than them all. Record whether each argument has been converted to
10626 string. Use EMACS_INT, not int, for byte and char and arg counts.
10627 Support field widths and precisions larger than INT_MAX. Avoid
10628 sprintf's undefined behavior with conversion specifications such as %#d
10629 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10630 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10631 formatting out-of-range floating point numbers with int
9173deec 10632 formats. (Bug#8668)
37910ab2 10633
2e6578fb
PE
10634 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10635
0ae6bdee
PE
10636 * data.c: Avoid integer truncation in expressions involving floats.
10637 * data.c: Include <intprops.h>.
10638 (arith_driver): When there's an integer overflow in an expression
10639 involving floating point, convert the integers to floating point
10640 so that the resulting value does not suffer from catastrophic
10641 integer truncation. For example, on a 64-bit host (* 4
10642 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10643 Do not rely on undefined behavior after integer overflow.
10644
de883a70
PE
10645 merge count_size_as_multibyte, parse_str_to_multibyte
10646 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10647 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10648 Check for integer overflow.
10649 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10650 since it's now a duplicate of the other. This is more of
10651 a character than a buffer op, so better that it's in character.c.
10652 * fns.c, print.c: Adjust to above changes.
10653
2ff916cb
PE
106542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10655
10656 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10657
f1b54466
PE
106582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10659
fb1ac845
PE
10660 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10661 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10662 (x_clipboard_manager_save): Now static.
10663 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10664
f1b54466
PE
10665 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10666 (crypto_hash_function): Now static.
10667 Fix pointer signedness problems. Avoid unnecessary initializations.
10668
a9f737ee
CY
106692011-05-27 Chong Yidong <cyd@stupidchicken.com>
10670
10671 * termhooks.h (Vselection_alist): Make it terminal-local.
10672
10673 * terminal.c (create_terminal): Initialize it.
10674
10675 * xselect.c: Support for clipboard managers.
10676 (Vselection_alist): Move to termhooks.h as terminal-local var.
10677 (LOCAL_SELECTION): New macro.
10678 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10679 (symbol_to_x_atom): Remove gratuitous arg.
10680 (x_handle_selection_request, lisp_data_to_selection_data)
10681 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10682 (x_own_selection, x_get_local_selection, x_convert_selection):
10683 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10684 (some_frame_on_display): Delete unused function.
10685 (Fx_own_selection_internal, Fx_get_selection_internal)
10686 (Fx_disown_selection_internal, Fx_selection_owner_p)
10687 (Fx_selection_exists_p): New optional frame arg.
10688 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10689 (x_handle_selection_clear): Don't treat other terminals with the
10690 same keyboard specially. Use the terminal-local Vselection_alist.
10691 (x_clear_frame_selections): Use Frun_hook_with_args.
10692
10693 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10694
10695 * xterm.h: Add support for those atoms.
10696
e067f0c1
CY
106972011-05-26 Chong Yidong <cyd@stupidchicken.com>
10698
10699 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10700 (converted_selections, conversion_fail_tag): New global variables.
10701 (x_selection_request_lisp_error): Free the above.
10702 (x_get_local_selection): Remove unnecessary code.
10703 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10704 of converted selections stored in converted_selections.
10705 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10706 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10707 (x_convert_selection): New function.
10708 (x_handle_selection_event): Simplify.
10709 (x_get_foreign_selection): Don't ignore incoming requests while
10710 waiting for an answer; this will fail when we implement
10711 SAVE_TARGETS, and seems unnecessary anyway.
10712 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10713 (Vx_sent_selection_functions): Doc fix.
10714
0f4aebc0
LL
107152011-05-26 Leo Liu <sdl.web@gmail.com>
10716
10717 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10718
e61124cd
YM
107192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10720
10721 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10722
10723 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10724 for fringe update if it has periodic bitmap.
ac389d0c 10725 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10726 and fringe_bitmap_periodic_p.
10727
10728 * fringe.c (get_fringe_bitmap_data): New function.
10729 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10730 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10731 row. Mark glyph row for fringe update if periodicity changed.
10732
10733 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10734 for fringe update unless it has periodic bitmap.
10735
f16d9837
KH
107362011-05-25 Kenichi Handa <handa@m17n.org>
10737
10738 * xdisp.c (get_next_display_element): Set correct it->face_id for
10739 a static composition.
10740
e1b90ef6
LL
107412011-05-24 Leo Liu <sdl.web@gmail.com>
10742
10743 * deps.mk (fns.o):
10744 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10745
10746 * fns.c (crypto_hash_function, Fsha1): New function.
10747 (Fmd5): Use crypto_hash_function.
10748 (syms_of_fns): Add Ssha1.
10749
7400048f
PE
107502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10751
10752 * gnutls.c: Remove unused macros.
10753 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10754 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10755 Remove macros that are defined and never used.
10756 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10757
abb71cf4
CY
107582011-05-22 Chong Yidong <cyd@stupidchicken.com>
10759
10760 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10761 (Fx_get_selection_internal): Minor cleanup.
10762 (Fx_own_selection_internal): Rename arguments for consistency with
10763 select.el.
10764
6307db39
PE
107652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10766
10767 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10768
f3d4e0a4
CY
107692011-05-22 Chong Yidong <cyd@stupidchicken.com>
10770
10771 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10772
4d8ade89
YM
107732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10774
10775 * dispnew.c (scrolling_window): Don't exclude the case that the
10776 last enabled row in the desired matrix touches the bottom boundary.
10777
32078c8d
GM
107782011-05-21 Glenn Morris <rgm@gnu.org>
10779
10780 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10781 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10782 and add some more files.
32078c8d 10783
7285dc67
EZ
107842011-05-20 Eli Zaretskii <eliz@gnu.org>
10785
10786 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10787 report_file_error introduced by the change from 2011-05-07.
10788
89d1bd22
PE
107892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10790
10791 * systime.h (Time): Define only if emacs is defined.
10792 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10793 where the include path doesn't have X11/X.h by default. See
10794 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10795
cd394be1 107962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10797
10798 * composite.c (find_automatic_composition): Fix previous change.
10799
b9704ad9
GM
108002011-05-20 Glenn Morris <rgm@gnu.org>
10801
10802 * lisp.mk: New file, split from Makefile.in.
10803 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10804 (shortlisp): Remove.
10805 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10806
4a720484
GM
108072011-05-19 Glenn Morris <rgm@gnu.org>
10808
10809 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10810 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10811 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10812 (lisp): Set the order to that of loadup.el.
10813 (shortlisp): Make it a copy of $lisp.
10814 (SOME_MACHINE_LISP): Remove.
10815 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10816 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10817
a28d4396
KH
108182011-05-18 Kenichi Handa <handa@m17n.org>
10819
10820 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10821 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10822 (find_automatic_composition): Mostly rewrite for efficiency.
10823
a2b1fa8e
JB
108242011-05-18 Juanma Barranquero <lekktu@gmail.com>
10825
10826 * makefile.w32-in: Update dependencies.
10827
8e1f5610
CS
108282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10829
10830 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10831 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10832
7025ee00 108332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10834
cdfa6eab
PE
10835 Fix some integer overflow issues, such as string length overflow.
10836
06d6db33
PE
10837 * insdel.c (count_size_as_multibyte): Check for string overflow.
10838
2b4560a8
PE
10839 * character.c (lisp_string_width): Check for string overflow.
10840 Use EMACS_INT, not int, for string indexes and lengths; in
10841 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10842 the resulting string length overflows an EMACS_INT; instead,
10843 report a string overflow if no precision given. When checking for
10844 precision exhaustion, use a check that cannot possibly have
10845 integer overflow. (Bug#8675)
10846 * character.h (lisp_string_width): Adjust to new signature.
10847
cb93f9be
PE
10848 * alloc.c (string_overflow): New function.
10849 (Fmake_string): Use it. This doesn't change behavior, but saves
10850 a few bytes and will simplify future changes.
10851 * character.c (string_escape_byte8): Likewise.
10852 * lisp.h (string_overflow): New decl.
10853
1a1f3366
PE
10854 Fixups, following up to the user-interface timestamp change.
10855 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10856 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10857 * msdos.c (mouse_get_pos): Likewise.
10858 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10859 * w32gui.h (Time): Define by including "systime.h" rather than by
10860 declaring it ourselves. (Bug#8664)
10861
d4e3e4d3
PE
10862 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10863 * image.c (clear_image_cache): Likewise.
10864
f6a24d19
PE
10865 * term.c (term_mouse_position): Don't assume time_t wraparound.
10866
08dc5ae6
PE
10867 Be more systematic about user-interface timestamps.
10868 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10869 and sometimes 'EMACS_UINT', to represent these timestamps.
10870 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10871 This makes the code easier to follow, and makes it easier to catch
10872 integer overflow bugs such as Bug#8664.
10873 * frame.c (Fmouse_position, Fmouse_pixel_position):
10874 Use Time, not unsigned long, for user-interface timestamps.
10875 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10876 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10877 * keyboard.h (last_event_timestamp): Likewise.
10878 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10879 * menu.h (xmenu_show): Likewise.
10880 * term.c (term_mouse_position): Likewise.
10881 * termhooks.h (struct input_event.timestamp): Likewise.
10882 (struct terminal.mouse_position_hook): Likewise.
10883 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10884 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10885 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10886 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10887 what it was before.
10888 * menu.h, termhooks.h: Include "systime.h", for Time.
10889
8e55734a
PE
10890 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10891 Don't assume that the difference between two unsigned long values
10892 can fit into an integer. At this point, we know button_down_time
10893 <= event->timestamp, so the difference must be nonnegative, so
10894 there's no need to cast the result if double-click-time is
10895 nonnegative, as it should be; check that it's nonnegative, just in
10896 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10897 apart (about 25 days). (Bug#8664)
8e55734a 10898
841f1b75 10899 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10900 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10901
3e26f69c
PE
10902 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10903 that always fit in int. Use a sentinel instead of a counter, to
10904 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10905 * frame.h (struct frame): Use int for menu_bar_items_used
10906 instead of EMACS_INT, since it always fits in int.
3e26f69c 10907
5cc152c0
PE
10908 * menu.c (grow_menu_items): Check for int overflow.
10909
d89eb65e
PE
10910 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10911
5235bd3e
PE
10912 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10913 Before, the code was not consistent. These values cannot exceed
10914 2**31 - 1 so there's no need to make them unsigned.
10915 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10916 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10917 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10918 as modifiers.
10919 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10920
bc827e23
PE
10921 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10922 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10923 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10924 presumably because the widths might not match.
10925
78eb494e
PE
10926 * window.c (size_window): Avoid needless test at loop start.
10927
04f2d78b
CB
109282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10929
10930 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10931
d2fc7e3d 109322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10933
10934 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10935
d2fc7e3d 109362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10937
10938 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10939 `width' to `bar_area_x' and `bar_area_width', respectively.
10940 (x_scroll_run): Take account of fringe background extension.
10941
04f2d78b
CB
10942 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10943 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10944 `bar_area_width', respectively.
10945 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10946 background extension.
10947
79b70037
GM
109482011-05-10 Jim Meyering <meyering@redhat.com>
10949
10950 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10951
2f142cc5
JB
109522011-05-10 Juanma Barranquero <lekktu@gmail.com>
10953
10954 * image.c (Finit_image_library): Return t for built-in image types,
10955 like pbm and xbm. (Bug#8640)
10956
57679c86
AS
109572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10958
10959 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10960
888c9e86
EZ
109612011-05-07 Eli Zaretskii <eliz@gnu.org>
10962
b0512a1d
EZ
10963 * w32console.c (Fset_screen_color): Doc fix.
10964 (Fget_screen_color): New function.
10965 (syms_of_ntterm): Defsubr it.
10966
7285dc67
EZ
10967 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10968 unlink the temporary file if Fcall_process didn't create it in the
10969 first place.
10970 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10971 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10972 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10973 cue to call_process_cleanup not to close that handle.
10974
4d3fcc8e
BK
109752011-05-07 Ben Key <bkey76@gmail.com>
10976
10977 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10978 one of two shell specific rules, either bootstrap-temacs-CMD or
10979 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10980 to the previous implementation of the bootstrap-temacs rule.
10981 The bootstrap-temacs-CMD rule is similar to the previous
10982 implementation of the bootstrap-temacs rule except that it
10983 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10984 variable.
10985
10986 These changes, along with some changes to nt/configure.bat,
10987 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10988 earlier fix to add support for --cflags and --ldflags options
10989 that include quotes so that it works whether make uses cmd or
10990 sh as the shell.
10991
b4289b64
MA
109922011-05-06 Michael Albinus <michael.albinus@gmx.de>
10993
10994 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10995 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10996 is a constant.
10997 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10998 a string. Handle both cases.
10999 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11000 (Fdbus_register_method): Use Qinvalid_function.
11001
af4c0e28
JB
110022011-05-06 Juanma Barranquero <lekktu@gmail.com>
11003
11004 * makefile.w32-in: Update dependencies.
11005 (LISP_H): Add inttypes.h and stdin.h.
11006 (PROCESS_H): Add unistd.h.
11007
c51453d9
EZ
110082011-05-06 Eli Zaretskii <eliz@gnu.org>
11009
11010 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11011 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11012
8ff0ac3c 110132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11014
4c4b566b
PE
11015 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11016
aab2b9b5
PE
11017 * term.c (vfatal): Remove stray call to va_end.
11018 It's not needed and the C Standard doesn't allow it here anyway.
11019
c378da0b
PE
11020 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11021 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11022
288b08c7
PE
11023 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11024 bytes.
11025
e3601888
PE
11026 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11027
db6c0e74
PE
11028 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11029
dd5963ea
PE
11030 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11031
88c9450f
PE
11032 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11033
2f9442b8
PE
11034 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11035
c032b5f8
PE
11036 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11037 * charset.c (Fdefine_charset_internal): Don't initialize
11038 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11039 32-bit int (Bug#8600).
a108c10b
PE
11040
11041 * lread.c (read_integer): Be more consistent with string-to-number.
11042 Use string_to_number to do the actual conversion; this avoids
11043 rounding errors and fixes some other screwups. Without this fix,
11044 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11045 (digit_to_number): Move earlier, for benefit of read_integer.
11046 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11047 not a digit in any supported base. (Bug#8602)
a108c10b 11048
ad5f9eea
PE
11049 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11050
aec1708a
PE
11051 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11052 to match comment at start of function. This also removes a
11053 GCC warning about overflow in a 32+64-bit port.
11054
47be4ab5
PE
11055 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11056
371cac43
PE
11057 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11058 Reported by Stefan Monnier in
11059 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11060 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11061 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11062
d01a7826
PE
11063 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11064 (EMACS_UINTPTR): Likewise, with uintptr_t.
11065
7fd47d5c
PE
11066 * lisp.h: Prefer 64-bit EMACS_INT if available.
11067 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11068 on 32-bit hosts that have 64-bit int, so that they can access
11069 large files.
122b0c86
PE
11070 However, temporarily disable this change unless the temporary
11071 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11072
8727937b
PE
11073 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11074
8ac068ac
PE
11075 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11076 This removes an assumption that EMACS_INT and long are the same
11077 width as pointers. The assumption is true for Emacs porting targets
11078 now, but we want to make other targets possible.
11079 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11080 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11081 In the rest of the code, change types of integers that hold casted
11082 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11083 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11084 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11085 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11086 No need to cast type when ORing.
11087 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11088 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11089 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11090 assume EMACS_INT is the same width as char *.
11091 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11092 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11093 Remove no-longer-needed casts.
11094 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11095 (xg_tool_bar_help_callback, xg_make_tool_item):
11096 Use EMACS_INTPTR to hold an integer
11097 that will be cast to void *; this can avoid a GCC warning
11098 if EMACS_INT is not the same width as void *.
11099 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11100 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11101 (current_message_1, set_message_1):
11102 Use a local to convert to proper width without a cast.
11103 * xmenu.c (dialog_selection_callback): Likewise.
11104
ede49d71
PE
11105 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11106 Also, don't assume VALBITS / RAND_BITS is less than 5,
11107 and don't rely on undefined behavior when shifting a 1 left into
11108 the sign bit.
11109 * lisp.h (get_random): Change signature to match.
11110
2f30ecd0
PE
11111 * lread.c (hash_string): Use size_t, not int, for hash computation.
11112 Normally we prefer signed values; but hashing is special, because
11113 it's better to use unsigned division on hash table sizes so that
11114 the remainder is nonnegative. Also, size_t is the natural width
11115 for hashing into memory. The previous code used 'int', which doesn't
11116 retain enough info to hash well into very large tables.
11117 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11118
2a866e7b
PE
11119 * dbusbind.c: Don't possibly lose pointer info when converting.
11120 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11121 Use XPNTR rather than XHASH, so that the high-order bits of
11122 the pointer aren't lost when converting through void *.
11123
51639eac
PE
11124 * eval.c (Fautoload): Don't double-shift a pointer.
11125
92394119
PE
11126 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11127
dbdb9a7c
JB
111282011-05-06 Juanma Barranquero <lekktu@gmail.com>
11129
11130 * gnutls.c (DEF_GNUTLS_FN):
11131 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11132
db7a0b4f
AS
111332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11134
11135 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11136 marker. (Bug#8610)
11137
cd394be1 111382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11139
11140 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11141 New version that can reserve upto 2GB of heap space.
11142
f7ff1b0f 111432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11144
11145 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11146
639c109b
TZ
111472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11148
11149 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11150 `gnutls_certificate_set_x509_key_file'.
11151
d2127135
JB
111522011-05-05 Juanma Barranquero <lekktu@gmail.com>
11153
11154 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11155 Update dependencies.
11156
e968f4f3
JB
111572011-05-04 Juanma Barranquero <lekktu@gmail.com>
11158
11159 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11160 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11161 Remove unused parameter `fildes'.
11162 * process.c (read_process_output, send_process): Don't pass it.
11163
84d358f0
JB
111642011-05-04 Juanma Barranquero <lekktu@gmail.com>
11165
11166 Fix previous change: the library cache is defined in w32.c.
11167 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11168 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11169
0898ca10
JB
111702011-05-04 Juanma Barranquero <lekktu@gmail.com>
11171
11172 Implement dynamic loading of GnuTLS on Windows.
11173
11174 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11175 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11176 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11177 Declare.
11178
11179 * gnutls.c (Qgnutls_dll): Define.
11180 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11181 (gnutls_*): Declare function pointers.
11182 (init_gnutls_functions): New function to initialize function pointers.
11183 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11184 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11185 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11186 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11187 (emacs_gnutls_write, emacs_gnutls_read)
11188 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11189 (Fgnutls_available_p): New function.
11190 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11191 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11192 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11193
11194 * image.c: Include w32.h.
11195 (Vimage_type_cache): Delete.
11196 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11197 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11198 (w32_delayed_load): Move to w32.c.
11199
11200 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11201
11202 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11203 (w32_delayed_load): Move from image.c. When loading a library, record
11204 its filename in the :loaded-from property of the library id.
11205 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11206 Initialize and staticpro them.
11207 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11208
11209 * process.c: Include lisp.h before w32.h, not after.
11210 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11211 instead of gnutls_record_check_pending.
11212
11213 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11214
ff4de4aa
TZ
112152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11216
11217 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11218 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11219 as passed in.
11220
abe95abb
JD
112212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11222
11223 * xterm.c (x_set_frame_alpha): Do not set property on anything
11224 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11225
e16e55d4
JB
112262011-05-02 Juanma Barranquero <lekktu@gmail.com>
11227
11228 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11229
bafcf6a5
JB
112302011-05-02 Juanma Barranquero <lekktu@gmail.com>
11231
11232 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11233 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11234 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11235 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11236 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11237 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11238 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11239 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11240 (Qgnutls_bootprop_callbacks_verify): Make static.
11241
e7a6747f
AS
112422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11243
19ed11ba
AS
11244 * callproc.c: Indentation fixup.
11245
e7a6747f 11246 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11247 (wait_for_termination, interruptible_wait_for_termination):
11248 Move after wait_for_termination_1.
e7a6747f 11249
1ef14cb4
LMI
112502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11251
11252 * sysdep.c (interruptible_wait_for_termination): New function
11253 which is like wait_for_termination, but allows keyboard
11254 interruptions.
11255
11256 * callproc.c (Fcall_process): Add (:file "file") as an option for
11257 the STDOUT buffer.
11258 (Fcall_process_region): Ditto.
11259
330d880c
EZ
112602011-04-30 Eli Zaretskii <eliz@gnu.org>
11261
8db90b73
EZ
11262 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11263 rather than `XVECTOR (FOO)->size'.
11264
330d880c
EZ
11265 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11266 inttypes.h, as a gnulib replacement is used if it not available in
11267 system headers.
11268
15cbd324
EZ
112692011-04-21 Eli Zaretskii <eliz@gnu.org>
11270
11271 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11272 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11273 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11274
11275 * coding.c (coding_alloc_by_realloc): Error out if destination
11276 will grow beyond MOST_POSITIVE_FIXNUM.
11277 (decode_coding_emacs_mule): Abort if there isn't enough place in
11278 charbuf for the composition carryover bytes. Reserve an extra
11279 space for up to 2 characters produced in a loop.
11280 (decode_coding_iso_2022): Abort if there isn't enough place in
11281 charbuf for the composition carryover bytes.
11282
112832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11284
ae940cca
EZ
11285 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11286 aborting when %lld or %lll format is passed.
11287 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11288 %llo or %llx format is passed. (Bug#8545)
11289
03ab8921
EZ
11290 * window.c (window_scroll_line_based): Use a marker instead of
11291 simple variables to record original value of point. (Bug#7952)
11292
afda1437
EZ
11293 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11294 produced by %s or %c overflows available buffer space. (Bug#8545)
11295
f76dee0c
PE
112962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11297
11298 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11299 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11300
fdc5744d
JB
113012011-04-28 Juanma Barranquero <lekktu@gmail.com>
11302
11303 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11304
638f053a
JB
113052011-04-28 Juanma Barranquero <lekktu@gmail.com>
11306
11307 * keyboard.c (Qdelayed_warnings_hook): Define.
11308 (command_loop_1): Run `delayed-warnings-hook'
11309 if Vdelayed_warnings_list is non-nil.
11310 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11311 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11312
d178f871
EZ
113132011-04-28 Eli Zaretskii <eliz@gnu.org>
11314
11315 * doprnt.c (doprnt): Don't return value smaller than the buffer
11316 size if the message was truncated. (Bug#8545).
11317
b124fd93
JB
113182011-04-28 Juanma Barranquero <lekktu@gmail.com>
11319
11320 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11321 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11322
e810457d
PE
113232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11324
11325 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11326
ea51cceb
JB
113272011-04-27 Juanma Barranquero <lekktu@gmail.com>
11328
11329 * makefile.w32-in: Update dependencies.
11330
94dcfacf
EZ
113312011-04-27 Eli Zaretskii <eliz@gnu.org>
11332
11333 Improve `doprnt' and its usage. (Bug#8545)
11334 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11335 `format_end'. Remove support for %l as a conversion specifier.
11336 Don't use xrealloc. Improve diagnostics when the %l size modifier
11337 is used. Update the commentary.
11338
11339 * eval.c (verror): Simplify calculation of size_t.
11340
11341 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11342 messages.
11343
f61f41d7
PE
113442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11345
11346 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11347 change.
11348
96fb4434
PE
113492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11350
11351 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11352 This makes this file independent of the recent pseudovector change.
11353
671875da 113542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11355
69e9b5a3
PE
11356 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11357
b5f869a7 11358 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11359 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11360 Remove unused local.
c8926152 11361 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11362
841a1577 11363 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11364 GCC 4.6.0 optimizes based on type-based alias analysis.
11365 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11366 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11367 != &v->size, and therefore "v->size = 1; b->size = 2; return
11368 v->size;" must therefore return 1. This assumption is incorrect
11369 for Emacs, since it type-puns struct Lisp_Vector * with many other
11370 types. To fix this problem, this patch adds a new type struct
f904488f 11371 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11372 and pseudovectors, and helps optimizing compilers not get fooled
11373 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11374 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11375 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11376 the size member.
eab3844f
PE
11377 (XSETPVECTYPE): Rewrite in terms of new macro.
11378 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11379 This is a bit clearer, and further avoids the possibility of
11380 undesirable aliasing.
11381 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11382 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11383 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11384 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11385 (ASIZE): Now uses header.size rather than size.
11386 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11387 to avoid the hassle of writing XVECTOR (foo)->header.size.
11388 (struct vectorlike_header): New type.
eab3844f
PE
11389 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11390 object, to help avoid aliasing.
11391 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11392 (SUBRP): Likewise, since Lisp_Subr is a special case.
11393 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11394 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11395 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11396 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11397 changed to be "header.size" and "header.next".
11398 * buffer.h (struct buffer): Likewise.
11399 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11400 * frame.h (struct frame): Likewise.
11401 * process.h (struct Lisp_Process): Likewise.
11402 * termhooks.h (struct terminal): Likewise.
11403 * window.c (struct save_window_data, struct saved_window): Likewise.
11404 * window.h (struct window): Likewise.
11405 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11406 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11407 * buffer.c (init_buffer_once): Likewise.
11408 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11409 special case.
11410 * process.c (Fformat_network_address): Use local var for size,
11411 for brevity.
11412
0df1eac5
PE
11413 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11414
847ab9d1 11415 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11416 * data.c (atof): Remove decl; no longer used or needed.
11417 (digit_to_number): Move to lread.c.
11418 (Fstring_to_number): Use new string_to_number function, to be
11419 consistent with how the Lisp reader treats infinities and NaNs.
11420 Do not assume that floating-point numbers represent EMACS_INT
11421 without losing information; this is not true on most 64-bit hosts.
11422 Avoid double-rounding errors, by insisting on integers when
11423 parsing non-base-10 numbers, as the documentation specifies.
11424 * lisp.h (string_to_number): New decl, replacing ...
11425 (isfloat_string): Remove.
bc0a5c13 11426 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11427 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11428 appears to have been a coding error. Similarly, do not accept
11429 strings like +-1e0 as floating point numbers. Do not report
11430 overflow for integer overflows unless the base is not 10 which
11431 means we have no simple and reliable way to continue.
11432 Break out the floating-point parsing into a new
11433 function string_to_number, so that Fstring_to_number parses
11434 floating point numbers consistently with the Lisp reader.
04f2d78b 11435 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11436 (E_CHAR, EXP_INT): Remove, replacing with ...
11437 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11438 (string_to_number): New function, replacing isfloat_string.
11439 This function checks for valid syntax and produces the resulting
11440 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11441 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11442 so that overflow for non-base-10 numbers is reported only when
11443 there's no portable and simple way to convert to floating point.
452f4150 11444
67769ffc
PE
11445 * textprop.c (set_text_properties_1): Rewrite for clarity,
11446 and to avoid GCC warning about integer overflow.
11447
c20db43f
PE
11448 * intervals.h (struct interval): Use EMACS_INT for members
11449 where EMACS_UINT might cause problems. See
11450 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11451 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11452 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11453 All uses changed.
37aa2f85
PE
11454 (offset_intervals): Tell GCC not to worry about length overflow
11455 when negating a negative length.
c20db43f 11456
2538aa2f
PE
11457 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11458 (overrun_check_free): Likewise.
11459
f2d3008d
PE
11460 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11461 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11462 word size.
11463
ec8df744
PE
11464 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11465 (gnutls_make_error): Rename local to avoid shadowing.
11466 (gnutls_emacs_global_deinit): ifdef out; not used.
11467 (Fgnutls_boot): Use const for pointer to readonly storage.
11468 Comment out unused local. Fix pointer signedness problems.
11469
640ee02d
PE
11470 * lread.c (openp): Don't stuff size_t into an 'int'.
11471 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11472 about possible signed overflow.
11473
6048fb2a
PE
11474 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11475 (GDK_KEY_g): Don't define if already defined.
11476 (xg_prepare_tooltip): Avoid pointer signedness problem.
11477 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11478
fa3c87e1
PE
11479 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11480 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11481
2172544b
PE
11482 * xfns.c (Fx_window_property): Simplify a bit,
11483 to make a bit faster and to avoid GCC 4.6.0 warning.
11484 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11485
9b821a21
PE
11486 * fns.c (internal_equal): Don't assume size_t fits in int.
11487
3c616cfa
PE
11488 * alloc.c (compact_small_strings): Tighten assertion a little.
11489
c2982e87
PE
11490 Replace pEd with more-general pI, and fix some printf arg casts.
11491 * lisp.h (pI): New macro, generalizing old pEd macro to other
11492 conversion specifiers. For example, use "...%"pI"d..." rather
11493 than "...%"pEd"...".
11494 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11495 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11496 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11497 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11498 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11499 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11500 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11501 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11502 64-bit hosts.
11503 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11504 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11505 * print.c (safe_debug_print, print_object): Likewise.
11506 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11507 to int.
6f04d126
PE
11508 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11509 avoiding the 0 flag, which is not portable.
c2982e87
PE
11510 * process.c (Fmake_network_process): Use pI to avoid cast.
11511 * region-cache.c (pp_cache): Likewise.
11512 * xdisp.c (decode_mode_spec): Likewise.
11513 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11514 behavior on 64-bit hosts with printf arg.
6f04d126 11515 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11516 (x_stop_queuing_selection_requests): Likewise.
11517 (x_get_window_property): Don't truncate byte count to an 'int'
11518 when tracing.
0b432f21 11519
5e073ec7
PE
11520 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11521 here, since it parses constructs like leading '-' and spaces,
11522 which are not wanted; and it overflows with large numbers.
11523 Instead, simply match F[0-9]+, which is what is wanted anyway.
11524
36372bf9
PE
11525 * alloc.c: Remove unportable assumptions about struct layout.
11526 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11527 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11528 (allocate_vectorlike, make_pure_vector): Use the new macros,
11529 plus offsetof, to remove unportable assumptions about struct layout.
11530 These assumptions hold on all porting targets that I know of, but
11531 they are not guaranteed, they're easy to remove, and removing them
11532 makes further changes easier.
11533
0b432f21
PE
11534 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11535 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11536 (string_overrun_cookie): Now const. Use initializers that
11537 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11538 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11539 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11540 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11541 multiple of sizeof (EMACS_INT); it need not be, if
11542 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11543 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11544
895009e1
JB
115452011-04-26 Juanma Barranquero <lekktu@gmail.com>
11546
11547 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11548
6a7a1b0b
TZ
115492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11550
11551 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11552 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11553 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11554
841a1577 115552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11556
11557 * lisp.h (Qdebug): List symbol.
895009e1 11558 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11559 * keyboard.c (debug-on-event): New variable.
11560 (handle_user_signal): Break into debugger when debug-on-event
11561 matches the current signal symbol.
11562
f2d3ba6f
DN
115632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11564
11565 * alloc.c (check_sblock, check_string_bytes)
11566 (check_string_free_list): Convert to standard C.
11567
42ce4c63
TZ
115682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11569
11570 * w32.c (emacs_gnutls_push): Fix typo.
11571
825cd63c
EZ
115722011-04-25 Eli Zaretskii <eliz@gnu.org>
11573
fb11d64d
EZ
11574 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11575 "cast to pointer from integer of different size".
11576
825cd63c
EZ
11577 Improve doprnt and its use in verror. (Bug#8545)
11578 * doprnt.c (doprnt): Document the set of format control sequences
11579 supported by the function. Use SAFE_ALLOCA instead of always
11580 using `alloca'.
11581
11582 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11583 is one byte too soon. Don't use xrealloc; instead xfree and
11584 xmalloc anew.
11585
e061a11b
TZ
115862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11587
11588 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11589 callbacks stage.
11590
11591 * gnutls.c: Renamed global_initialized to
11592 gnutls_global_initialized. Added internals for the
11593 :verify-hostname-error, :verify-error, and :verify-flags
11594 parameters of `gnutls-boot' and documented those parameters in the
11595 docstring. Start callback support.
9173deec
JB
11596 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11597 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11598 on error. Return error code.
e061a11b
TZ
11599 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11600 (emacs_gnutls_read): Likewise.
11601 (Fgnutls_boot): Return handshake error code.
11602 (emacs_gnutls_handle_error): New function.
11603 (wsaerror_to_errno): Likewise.
11604
11605 * w32.h (emacs_gnutls_pull): Add prototype.
11606 (emacs_gnutls_push): Likewise.
11607
11608 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11609 (emacs_gnutls_push): Likewise.
11610
116112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11612
11613 * process.c (wait_reading_process_output): Check if GnuTLS
11614 buffered some data internally if no FDs are set for TLS
11615 connections.
11616
11617 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11618 (LIBS): Link to USER_LIBS.
11619 ($(BLD)/gnutls.$(0)): New target.
11620
fa6996bc
EZ
116212011-04-24 Eli Zaretskii <eliz@gnu.org>
11622
eb35682e
EZ
11623 * xdisp.c (handle_single_display_spec): Rename the
11624 display_replaced_before_p argument into display_replaced_p, to
11625 make it consistent with the commentary. Fix typos in the
11626 commentary.
11627
e2ad650c
EZ
11628 * textprop.c (syms_of_textprop): Remove dead code.
11629 (copy_text_properties): Delete obsolete commentary about an
11630 interface that was deleted long ago. Fix typos in the description
11631 of arguments.
11632
1b2de274
EZ
11633 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11634 to changes in oldXMenu/XMenu.h from 2011-04-16.
11635 <menu_help_message, prev_menu_help_message>: Constify.
11636 (IT_menu_make_room): menu->help_text is now `const char **';
11637 adjust.
11638
11639 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11640 to changes in oldXMenu/XMenu.h from 2011-04-16.
11641 (struct XMenu): Declare `help_text' `const char **'.
11642
11643 * xfaces.c <Qunspecified>: Make extern again.
11644
11645 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11646 required by POSIX.
1b2de274 11647
762b15be
EZ
11648 * doc.c (get_doc_string): Improve the format passed to `error'.
11649
11650 * doprnt.c (doprnt): Improve commentary.
11651
11652 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11653
11654 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11655 them with etags.
11656
f1052e5d
EZ
11657 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11658 changes in globals.h immediately force recompilation.
762b15be
EZ
11659 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11660 $(CURDIR)/s/ms-w32.h.
11661 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11662
fa6996bc
EZ
11663 * character.c (Fchar_direction): Function deleted.
11664 (syms_of_character): Don't defsubr it.
11665 <char-direction-table>: Deleted.
11666
e6c3da20
EZ
116672011-04-23 Eli Zaretskii <eliz@gnu.org>
11668
11669 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11670 * doprnt.c: Include limits.h.
11671 (SIZE_MAX): New macro.
04f2d78b
CB
11672 (doprnt): Return a size_t value. 2nd arg is now size_t.
11673 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11674 Improve overflow protection. Support `l' modifier for integer
11675 conversions. Support %l conversion. Don't assume an EMACS_INT
11676 argument for integer conversions and for %c.
11677
11678 * lisp.h (doprnt): Restore prototype.
11679
11680 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11681 $(SRC)/character.h.
11682
11683 * Makefile.in (base_obj): Add back doprnt.o.
11684
11685 * deps.mk (doprnt.o): Add back prerequisites.
11686 (callint.o): Depend on character.h.
11687
11688 * eval.c (internal_lisp_condition_case): Include the handler
11689 representation in the error message.
11690 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11691 when breaking from the loop.
11692
11693 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11694
11695 * callint.c (Fcall_interactively): When displaying error message
11696 about invalid control letter, pass the character's codepoint, not
11697 a pointer to its multibyte form. Improve display of the character
11698 in octal and display also its hex code.
11699
11700 * character.c (char_string): Use %x to display the (unsigned)
11701 codepoint of an invalid character, to avoid displaying a bogus
11702 negative value.
11703
11704 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11705 `error', not SYMBOL_NAME itself.
11706
11707 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11708 character arguments to `error'.
11709
11710 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11711 to `error' in error message about FINAL_CHAR argument. Make sure
11712 FINAL_CHAR is a character, and use %c when it is passed as
11713 argument to `error'.
11714
4ffd0d6b 117152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11716
11717 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11718
11719 * w32.c: Include <time.h>.
11720 (sys_localtime): New function.
11721
4ffd0d6b 117222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11723
11724 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11725
4ffd0d6b 11726 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11727
4ffd0d6b 117282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11729
4ffd0d6b
GM
11730 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11731 zombies (Bug#8467).
aac0c6e3 11732
04c56954
EZ
117332011-04-19 Eli Zaretskii <eliz@gnu.org>
11734
11735 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11736 gl_state.e_property when gl_state.object is Qt.
11737
11738 * insdel.c (make_gap_larger): Remove limitation of buffer size
11739 to <= INT_MAX.
11740
16a43933
CY
117412011-04-18 Chong Yidong <cyd@stupidchicken.com>
11742
11743 * xdisp.c (lookup_glyphless_char_display)
11744 (produce_glyphless_glyph): Handle cons cell entry in
11745 glyphless-char-display.
11746 (Vglyphless_char_display): Document it.
11747
11748 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11749 glyphless-char-display.
11750
4581706e
CY
117512011-04-17 Chong Yidong <cyd@stupidchicken.com>
11752
11753 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11754
11755 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11756
11757 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11758 definition for no-X builds.
11759
4887c6e2 117602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11761
fd35b6f9
PE
11762 Static checks with GCC 4.6.0 and non-default toolkits.
11763
5c1ccb01
PE
11764 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11765
006c5daa
PE
11766 * process.c (keyboard_bit_set): Define only if SIGIO.
11767 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11768 (send_process): Repair possible setjmp clobbering.
11769
efc736d3
PE
11770 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11771
4e2fe2e6
PE
11772 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11773
f97334a2
PE
11774 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11775
4e75f29d
PE
11776 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11777 Define only if needed.
11778
90efadd1
PE
11779 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11780 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11781 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11782
3c647824
PE
11783 * dispextern.h (struct redisplay_interface): Rename param
11784 to avoid shadowing.
e264f262 11785 * termhooks.h (struct terminal): Likewise.
761383f4 11786 * xterm.c (xembed_send_message): Likewise.
3c647824 11787
b58c5c4a
PE
11788 * insdel.c (make_gap_smaller): Define only if
11789 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11790
cad59032
PE
11791 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11792 it.
11793
c339dc2e
PE
11794 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11795 so that we aren't warned about unused symbols.
11796
91a3e27b
PE
11797 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11798
399c71d3 11799 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11800
8ffc96f5
PE
11801 * xfns.c (x_real_positions): Mark locals as initialized.
11802
eef9bc79
PE
11803 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11804
098db9dd
PE
11805 * xterm.c: Fix problems found by static analysis with other toolkits.
11806 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11807 (x_dispatch_event): Declare static if USE_GTK, and
11808 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11809 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11810 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11811 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11812 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11813
eb18f6cc
PE
11814 * xmenu.c (menu_help_callback): Pointer type fixes.
11815 Use const pointers when pointing at readonly data. Avoid pointer
11816 signedness clashes.
11817 (FALSE): Remove unused macro.
11818 (update_frame_menubar): Remove unused decl.
11819
1fe72bf8
PE
11820 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11821
60d9e1db
PE
11822 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11823 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11824 (single_menu_item): Rename local to avoid shadowing.
11825
39261c26
PE
11826 * keyboard.c (make_lispy_event): Remove unused local var.
11827
018c5e19
PE
11828 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11829 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11830
63d2b86e
PE
11831 * bitmaps: Change bitmaps from unsigned char back to the X11
11832 compatible char. Avoid the old compiler warnings about
11833 out-of-range initializers by using, for example, '\xab' rather
11834 than 0xab.
11835
aefd87e1
PE
11836 * xgselect.c (xgselect_initialize): Check vs interface
11837 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11838
bf501fb9
PE
11839 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11840
e9829fdf
PE
11841 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11842 to read-only memory.
11843
1086c095
PE
11844 * fns.c (vector): Remove; this old hack is no longer needed.
11845
2baccd04 11846 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11847 Remove unused var.
dde42981 11848 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11849
72391843 11850 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11851
436c16df 11852 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11853 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11854 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11855
92bb796d 11856 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11857 (x_term_init): Remove local to avoid shadowing.
92bb796d 11858
764430a3 11859 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11860
11861 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11862 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11863
d1dfb56c
EZ
118642011-04-16 Eli Zaretskii <eliz@gnu.org>
11865
c4354cb4
EZ
11866 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11867
d1dfb56c
EZ
11868 Fix regex.c, syntax.c and friends for buffers > 2GB.
11869 * syntax.h (struct gl_state_s): Declare character position members
11870 EMACS_INT.
11871
11872 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11873
04f2d78b
CB
11874 * textprop.c (verify_interval_modification, interval_of):
11875 Declare arguments EMACS_INT.
d1dfb56c
EZ
11876
11877 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11878 EMACS_INT.
11879
11880 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11881
11882 * indent.c (Fvertical_motion): Local variable it_start is now
11883 EMACS_INT.
11884
11885 * regex.c (re_match, re_match_2, re_match_2_internal)
11886 (bcmp_translate, regcomp, regexec, print_double_string)
11887 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11888 (re_compile_pattern, re_exec): Declare arguments and local
11889 variables `size_t' and `ssize_t' and return values `regoff_t', as
11890 appropriate.
11891 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11892 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11893 <compile_stack_type>: `size' and `avail' are now `size_t'.
11894
11895 * regex.h <regoff_t>: Use ssize_t, not int.
11896 (re_search, re_search_2, re_match, re_match_2): Arguments that
11897 specify buffer/string position and length are now ssize_t and
11898 size_t. Return type is regoff_t.
11899
613052cd
BK
119002011-04-16 Ben Key <bkey76@gmail.com>
11901
11902 * nsfont.m: Fixed bugs in ns_get_family and
11903 ns_descriptor_to_entity that were caused by using free to
11904 deallocate memory blocks that were allocated by xmalloc (via
11905 xstrdup). This caused Emacs to crash when compiled with
11906 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11907 --enable-checking=xmallocoverrun). xfree is now used to
11908 deallocate these memory blocks.
11909
4170f62f 119102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11911
71b41406
PE
11912 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11913
9587a89d
PE
11914 emacs_write: Accept and return EMACS_INT for sizes.
11915 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11916 et seq.
11917 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11918 Accept and return EMACS_INT.
11919 (emacs_gnutls_write): Return the number of bytes written on
11920 partial writes.
11921 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11922 (emacs_read, emacs_write): Remove check for negative size, as the
11923 Emacs source code has been audited now.
9587a89d
PE
11924 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11925 (emacs_read, emacs_write): Use it.
273a5f82
PE
11926 * process.c (send_process): Adjust to the new signatures of
11927 emacs_write and emacs_gnutls_write. Do not attempt to store
11928 a byte offset into an 'int'; it might overflow.
9587a89d 11929 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11930
3e047f51
PE
11931 * sound.c: Don't assume sizes fit in 'int'.
11932 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11933 Return EMACS_INT, not int.
3e047f51 11934 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11935 Accept EMACS_INT, not int.
11936 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11937 record read return values.
11938
cc39a9db
BK
119392011-04-15 Ben Key <bkey76@gmail.com>
11940
c9d0ec6d
JB
11941 * keyboard.c (Qundefined): Don't declare static since it is used
11942 in nsfns.m.
11943 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11944 static since they are used in nsfont.m.
cc39a9db 11945
6c60eb9f
SM
119462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11947
11948 * process.c (Qprocessp): Don't declare static.
11949 * lisp.h (Qprocessp): Declare again.
11950
7990b61a
JB
119512011-04-15 Juanma Barranquero <lekktu@gmail.com>
11952
11953 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11954
5d4cb038
PE
119552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11956
8bd7b830 11957 Improve C-level modularity by making more things 'static'.
cd64ea1d 11958
e3b27b31
PE
11959 Don't publish debugger-only interfaces to other modules.
11960 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11961 (verify_bytepos, count_markers): Move decls to the only modules
11962 that need them.
11963 * region-cache.h (pp_cache): Likewise.
11964 * window.h (check_all_windows): Likewise.
11965 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11966
5d4cb038
PE
11967 * sysdep.c (croak): Now static, if
11968 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11969 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11970
11971 * alloc.c (refill_memory_reserve): Now static if
11972 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11973 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11974
e87b6180
PE
11975 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11976 Define only if USE_LUCID.
11977
ac64929e
PE
11978 * xrdb.c (x_customization_string, x_rm_string): Now static.
11979
6f37259d
PE
11980 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11981 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11982
1683e3ab
PE
11983 * xdisp.c (draw_row_with_mouse_face): Now static.
11984 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11985
de9c2632
PE
11986 * window.h (check_all_windows): Mark externally visible.
11987
2b96acb7
PE
11988 * window.c (window_deletion_count): Now static.
11989
11990 * undo.c: Make symbols static if they're not exported.
11991 (last_undo_buffer, last_boundary_position, pending_boundary):
11992 Now static.
11993
50436f33
PE
11994 * textprop.c (interval_insert_behind_hooks): Now static.
11995 (interval_insert_in_front_hooks): Likewise.
11996
64520e5c
PE
11997 * term.c: Make symbols static if they're not exported.
11998 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11999 (max_frame_lines, tty_set_terminal_modes):
12000 (tty_reset_terminal_modes, tty_turn_off_highlight):
12001 (get_tty_terminal): Now static.
12002 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12003 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12004 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12005 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12006 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12007
1fa53021
PE
12008 * sysdep.c: Make symbols static if they're not exported.
12009 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12010 Now static.
12011 (sigprocmask_set, full_mask): Remove; unused.
12012 (wait_debugging): Mark as visible.
12013 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12014 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12015
d4b43b22
PE
12016 * syntax.c (syntax_temp): Define only if !__GNUC__.
12017
b7c513d0
PE
12018 * sound.c (current_sound_device, current_sound): Now static.
12019
989b29ad
PE
12020 * search.c (searchbufs, searchbuf_head): Now static.
12021
13a55a78
PE
12022 * scroll.c (scroll_cost): Remove; unused.
12023 * dispextern.h (scroll_cost): Remove decl.
12024
de68a1fc
PE
12025 * region-cache.h (pp_cache): Mark as externally visible.
12026
40ccffa6
PE
12027 * process.c: Make symbols static if they're not exported.
12028 (process_tick, update_tick, create_process, chan_process):
12029 (Vprocess_alist, proc_buffered_char, datagram_access):
12030 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12031 (deactivate_process): Mark defn as static, as well as decl.
12032 * lisp.h (create_process): Remove decl.
12033 * process.h (chan_process, Vprocess_alist): Remove decls.
12034
ad64fc97
PE
12035 * print.c: Make symbols static if they're not exported.
12036 (print_depth, new_backquote_output, being_printed, print_buffer):
12037 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12038 (print_interval, print_number_index, initial_stderr_stream):
12039 Now static.
12040 * lisp.h (Fprinc): Remove decl.
12041 (debug_output_compilation_hack): Mark as externally visible.
12042
adddb265
PE
12043 * sysdep.c (croak): Move decl from here to syssignal.h.
12044 * syssignal.h (croak): Put it here, so the API can be checked when
12045 'croak' is called from dissociate_if_controlling_tty.
12046
1717ede2
PE
12047 * minibuf.c: Make symbols static if they're not exported.
12048 (minibuf_save_list, choose_minibuf_frame): Now static.
12049 * lisp.h (choose_minibuf_frame): Remove decl.
12050
fa5fb2bc
PE
12051 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12052
1e3890d1
PE
12053 * lread.c: Make symbols static if they're not exported.
12054 (read_objects, initial_obarray, oblookup_last_bucket_number):
12055 Now static.
12056 (make_symbol): Remove; unused.
12057 * lisp.h (initial_obarray, make_symbol): Remove decls.
12058
8a1414fa
PE
12059 * keyboard.c: Make symbols static if they're not exported.
12060 (single_kboard, recent_keys_index, total_keys, recent_keys):
12061 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12062 (this_single_command_key_start, echoing, last_auto_save):
12063 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12064 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12065 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12066 (Vlispy_mouse_stem, double_click_count):
12067 Now static.
12068 (force_auto_save_soon): Define only if SIGDANGER.
12069 (ignore_mouse_drag_p): Now static if
12070 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12071 (print_help): Remove; unused.
12072 (stop_character, last_timer_event): Mark as externally visible.
12073 * keyboard.h (ignore_mouse_drag_p): Declare only if
12074 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12075 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12076 * lisp.h (echoing): Remove decl.
12077 (force_auto_save_soon): Declare only if SIGDANGER.
12078 * xdisp.c (redisplay_window): Simplify code, to make it more
12079 obvious that ignore_mouse_drag_p is not accessed if !defined
12080 USE_GTK && !defined HAVE_NS.
12081
93ea6e8f
PE
12082 * intervals.c: Make symbols static if they're not exported.
12083 (merge_properties_sticky, merge_interval_right, delete_interval):
12084 Now static.
12085 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12086
77382fcc
PE
12087 * insdel.c: Make symbols static if they're not exported.
12088 However, leave prepare_to_modify_buffer alone. It's never
12089 called from outside this function, but that appears to be a bug.
12090 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12091 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12092 (adjust_after_replace_noundo): Remove; unused.
12093 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12094 (signal_before_change): Remove decls.
77382fcc 12095
9306c32e
PE
12096 * indent.c (val_compute_motion, val_vmotion): Now static.
12097
cd44d2eb
PE
12098 * image.c: Make symbols static if they're not exported.
12099 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12100 if USE_GTK.
12101 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12102 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12103
ad9a7a06
PE
12104 * fringe.c (standard_bitmaps): Now static.
12105 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12106
81626931
PE
12107 * frame.c: Make symbols static if they're not exported.
12108 (x_report_frame_params, make_terminal_frame): Now static.
12109 (get_frame_param): Now static, unless HAVE_NS.
12110 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12111 (x_get_resource_string): Remove; not used.
12112 * frame.h (make_terminal_frame, x_report_frame_params):
12113 (x_get_resource_string); Remove decls.
12114 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12115 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12116
239f9db9
PE
12117 * font.c, fontset.c: Make symbols static if they're not exported.
12118 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12119 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12120 * font.c (font_close_object): Now static.
12121 * font.h (font_close_object): Remove.
12122 * fontset.c (FONTSET_OBJLIST): Remove.
12123 (free_realized_fontset) #if-0 the body, which does nothing.
12124 (face_suitable_for_char_p): #if-0, as it's never called.
12125 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12126 * xfaces.c (face_at_string_position):
12127 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12128 since 0 is always ASCII.
12129
dfcf3579
PE
12130 * fns.c (weak_hash_tables): Now static.
12131
5045092b
PE
12132 * fileio.c: Make symbols static if they're not exported.
12133 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12134 (Vwrite_region_annotation_buffers): Now static.
12135
57a96f5c
PE
12136 * eval.c: Make symbols static if they're not exported.
12137 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12138 * lisp.h (backtrace_list): Remove decl.
12139
35f08c38
PE
12140 * emacs.c: Make symbols static if they're not exported.
12141 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12142 (fatal_error_code, fatal_error_signal_hook, standard_args):
12143 Now static.
12144 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12145 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12146 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12147 * lisp.h (fatal_error_signal_hook): Remove decl.
12148 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12149
f44bd759
PE
12150 * editfns.c: Move a (normally-unused) function to its only use.
12151 * editfns.c, lisp.h (get_operating_system_release): Remove.
12152 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12153 worth the hassle of breaking this out.
12154
b532497d
PE
12155 * xterm.c: Make symbols static if they're not exported.
12156 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12157 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12158 (x_destroy_window, x_delete_display):
12159 Now static.
12160 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12161 (x_mouse_leave): Remove; unused.
12162 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12163 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12164 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12165 Remove decls.
12166 (x_mouse_leave): Declare only if WINDOWSNT.
12167 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12168 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12169 USE_X_TOOLKIT.
12170
1675728f
PE
12171 * ftxfont.c: Make symbols static if they're not exported.
12172 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12173 HAVE_FREETYPE.
12174 * font.h (ftxfont_driver): Likewise.
12175
e4cebfca
PE
12176 * xfns.c: Make symbols static if they're not exported.
12177 (x_last_font_name, x_display_info_for_name):
12178 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12179 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12180 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12181 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12182 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12183 (last_show_tip_args): Now static.
12184 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12185 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12186 (x_screen_planes): Remove; unused.
12187 * dispextern.h (x_screen_planes): Remove decl.
12188
5bf46f05
PE
12189 * dispnew.c: Make symbols static if they're not exported.
12190 * dispextern.h (redraw_garbaged_frames, scrolling):
12191 (increment_row_positions): Remove.
12192 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12193 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12194 Now static.
12195 (redraw_garbaged_frames): Remove; unused.
12196
435f4c28
PE
12197 * xfaces.c: Make symbols static if they're not exported.
12198 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12199 Remove decls.
12200 * xterm.h (defined_color): Remove decls.
12201 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12202 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12203 (menu_face_changed_default, defined_color, free_realized_face):
12204 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12205 (ascii_face_of_lisp_face): Remove; unused.
12206
8524aef3
PE
12207 * xdisp.c: Make symbols static if they're not exported.
12208 * dispextern.h (scratch_glyph_row, window_box_edges):
12209 (glyph_to_pixel_coords, set_cursor_from_row):
12210 (get_next_display_element, set_iterator_to_next):
12211 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12212 (show_mouse_face): Remove decls
12213 * frame.h (message_buf_print): Likewise.
12214 * lisp.h (pop_message, set_message, check_point_in_composition):
12215 Likewise.
12216 * xterm.h (set_vertical_scroll_bar): Likewise.
12217 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12218 (message_buf_print, scratch_glyph_row, displayed_buffer):
12219 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12220 (get_next_display_element, show_mouse_face, window_box_edges):
12221 (frame_to_window_pixel_xy, check_point_in_composition):
12222 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12223 (glyph_to_pixel_coords): Remove; unused.
12224
16390cd2
PE
12225 * dired.c (file_name_completion): Now static.
12226
12227 * dbusbind.c (xd_in_read_queued_messages): Now static.
12228
a25f4dfa
PE
12229 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12230 * data.c (circular_list_error): Remove.
12231
14a9c8df
PE
12232 * commands.h (last_point_position, last_point_position_buffer):
12233 (last_point_position_window): Remove decls.
12234 * keyboard.c: Make these variables static.
12235
04f2d78b
CB
12236 * coding.h (coding, code_convert_region, encode_coding_gap):
12237 Remove decls.
74ab6df5
PE
12238 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12239 (iso_code_class, detect_coding, code_convert_region): Now static.
12240 (encode_coding_gap): Remove; unused.
12241
38dfbee1
PE
12242 * chartab.c (chartab_chars, chartab_bits): Now static.
12243
a2cb4e63
PE
12244 * charset.h (charset_iso_8859_1): Remove decl.
12245 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12246 Now static.
12247
127198fd
PE
12248 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12249 * ccl.c (Vccl_program_table): Now static.
12250 (check_ccl_update): Remove; unused.
12251
d85b608f
PE
12252 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12253 * category.h: ... from here.
12254 * category.c (check_category_table, set_category_set): Now static.
12255
31cd66f3
PE
12256 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12257 * lisp.h: Remove these decls.
12258
c358e587
PE
12259 * buffer.c (buffer_count): Remove unused var.
12260
e78aecca
PE
12261 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12262 so that it's not optimized away.
12263 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12264 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12265 exported only to the debugger.
12266
e192d7d3 12267 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12268 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12269
92470028
PE
12270 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12271 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12272 was inaccessible from Lisp.
12273 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12274 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12275
244ed907
PE
12276 alloc.c: Import and export fewer symbols, and remove unused items.
12277 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12278 is defined.
12279 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12280 it's not optimized away by whole-program optimization.
12281 (message_enable_multibyte, free_misc): Remove.
12282 (catchlist, handlerlist, mark_backtrace):
12283 Declare only if BYTE_MARK_STACK.
12284 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12285 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12286 (message_enable_multibyte): Remove decl.
12287 (free_misc, interval_free_list, float_block, float_block_index):
12288 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12289 (cons_free_list, last_marked_index):
12290 Now static.
12291 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12292 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12293 (mark_backtrace): Define only if BYTE_MARK_STACK.
12294 * xdisp.c (message_enable_multibyte): Now static.
12295
61c2b50e 12296 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12297 This makes it easier for human readers (and static analyzers)
12298 to see whether these variables are used from other modules.
12299 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12300 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12301 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12302 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12303 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12304 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12305 * xmenu.c, xselect.c:
12306 Declare Q* vars static if they are not used in other modules.
12307 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12308 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12309 Remove decls of unexported vars.
12310 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12311
95c82688
PE
12312 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12313
16a97296
PE
12314 Make Emacs functions such as Fatom 'static' by default.
12315 This makes it easier for human readers (and static analyzers)
12316 to see whether these functions can be called from other modules.
12317 DEFUN now defines a static function. To make the function external
12318 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12319 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12320 (Finit_image_library):
16a97296
PE
12321 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12322 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12323 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12324 Remove decls, since these functions are now static.
12325 (Funintern, Fget_internal_run_time): New decls, since these functions
12326 were already external.
95c82688 12327
16a97296
PE
12328 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12329 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12330 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12331 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12332 * keyboard.c, keymap.c, lread.c:
12333 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12334 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12335 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12336 Mark functions with DEFUE instead of DEFUN,
12337 if they are used in other modules.
12338 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12339 decls for now-static functions.
12340 * buffer.h (Fdelete_overlay): Remove decl.
12341 * callproc.c (Fgetenv_internal): Mark as internal.
12342 * composite.c (Fremove_list_of_text_properties): Remove decl.
12343 (Fcomposition_get_gstring): New forward static decl.
12344 * composite.h (Fcomposite_get_gstring): Remove decl.
12345 * dired.c (Ffile_attributes): New forward static decl.
12346 * doc.c (Fdocumntation_property): New forward static decl.
12347 * eval.c (Ffetch_bytecode): New forward static decl.
12348 (Funintern): Remove extern decl; now in .h file where it belongs.
12349 * fileio.c (Fmake_symbolic_link): New forward static decl.
12350 * image.c (Finit_image_library): New forward static decl.
12351 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12352 * intervals.h (Fprevious_property_change):
12353 (Fremove_list_of_text_properties): Remove decls.
12354 * keyboard.c (Fthis_command_keys): Remove decl.
12355 (Fcommand_execute): New forward static decl.
12356 * keymap.c (Flookup_key): New forward static decl.
12357 (Fcopy_keymap): Now static.
12358 * keymap.h (Flookup_key): Remove decl.
12359 * process.c (Fget_process): New forward static decl.
12360 (Fprocess_datagram_address): Mark as internal.
12361 * syntax.c (Fsyntax_table_p): New forward static decl.
12362 (skip_chars): Remove duplicate decl.
12363 * textprop.c (Fprevious_property_change): New forward static decl.
12364 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12365 Now internal.
12366 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12367 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12368
785bbd42
PE
12369 * editfns.c (Fformat): Remove unreachable code.
12370
8b913b57
AS
123712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12372
12373 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12374 change. (Bug#8496)
12375
a6744a35
EZ
123762011-04-13 Eli Zaretskii <eliz@gnu.org>
12377
12378 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12379 when at ZV. (Bug#8487)
12380
e7974947
AS
123812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12382
baad03f0
AS
12383 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12384 (Bug#8437)
12385 * keyboard.c (parse_tool_bar_item): Likewise.
12386 * sound.c (sound_cleanup, alsa_close): Likewise.
12387 * termcap.c (tgetent): Likewise.
12388 * xfns.c (x_default_font_parameter): Likewise.
12389 * xsettings.c (read_and_apply_settings): Likewise.
12390
e7974947
AS
12391 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12392 (overrun_check_free): Protoize.
12393
28272684
PE
123942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12395
12396 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12397 since callers should never pass a negative size.
12398 Change the signature to match that of plain 'read' and 'write'; see
12399 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12400 * lisp.h: Update prototypes of emacs_write and emacs_read.
12401
11997c76
EZ
124022011-04-11 Eli Zaretskii <eliz@gnu.org>
12403
12404 * xdisp.c (redisplay_window): Don't try to determine the character
12405 position of the scroll margin if the window start point w->startp
e896f03c 12406 is outside the buffer's accessible region. (Bug#8468)
11997c76 12407
8a2cbd72
EZ
124082011-04-10 Eli Zaretskii <eliz@gnu.org>
12409
12410 Fix write-region and its subroutines for buffers > 2GB.
12411 * fileio.c (a_write, e_write): Modify declaration of arguments and
12412 local variables to support buffers larger than 2GB.
12413 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12414
12415 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12416 argument, local variables, and return value.
12417
12418 * lisp.h: Update prototypes of emacs_write and emacs_read.
12419
12420 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12421
4073e537 124222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12423
1ebfdcb6
PE
12424 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12425
b2ded58d
PE
12426 Fix more problems found by GCC 4.6.0's static checks.
12427
7d66342c
PE
12428 * xdisp.c (vmessage): Use a better test for character truncation.
12429
bbf47d44
PE
12430 * charset.c (load_charset_map): <, not <=, for optimization,
12431 and to avoid potential problems with integer overflow.
9248994d 12432 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12433 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12434 * editfns.c (Fformat): Likewise.
1e69125e 12435 * syntax.c (skip_chars): Likewise.
3befa583 12436
e3019616
PE
12437 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12438 This also lets GCC 4.6.0 generate slightly better loop code.
12439
becfa255
PE
12440 * callint.c (Fcall_interactively): <, not <=, for optimization.
12441 (Fcall_interactively): Count the number of arguments produced,
12442 not the number of arguments given. This is simpler and lets GCC
12443 4.6.0 generate slightly better code.
12444
dae0cd48
PE
12445 * ftfont.c: Distingish more carefully between FcChar8 and char.
12446 The previous code passed unsigned char * to a functions like
12447 strlen and xstrcasecmp that expect char *, which does not
12448 conform to the C standard.
12449 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12450 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12451 char * when the C standard requires it.
12452
76032d70
PE
12453 * keyboard.c (read_char): Remove unused var.
12454
eb3f1cc8
PE
12455 * eval.c: Port to Windows vsnprintf (Bug#8435).
12456 Include <limits.h>.
12457 (SIZE_MAX): Define if the headers do not.
12458 (verror): Do not give up if vsnprintf returns a negative count.
12459 Instead, grow the buffer. This ports to Windows vsnprintf, which
12460 does not conform to C99. Problem reported by Eli Zaretskii.
12461 Also, simplify the allocation scheme, by avoiding the need for
12462 calling realloc, and removing the ALLOCATED variable.
12463
70476b54
PE
12464 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12465
12020a9e
PE
12466 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12467 But keep the doprint source code for now, as we might revamp it
12468 and use it again (Bug#8435).
ea6c7ae6
PE
12469 * lisp.h (doprnt): Remove.
12470 * Makefile.in (base_obj): Remove doprnt.o.
12471 * deps.mk (doprnt.o): Remove.
12472
5fdb398c
PE
12473 error: Print 32- and 64-bit integers portably (Bug#8435).
12474 Without this change, on typical 64-bit hosts error ("...%d...", N)
12475 was used to print both 32- and 64-bit integers N, which relied on
12476 undefined behavior.
61bdb816 12477 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12478 * lisp.h (error, verror): Mark as printf-like functions.
12479 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12480 Report overflow in size calculations when allocating printf buffer.
12481 Do not truncate output string at its first null byte.
12482 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12483 Truncate the output at a character boundary, since vsnprintf does not
12484 do that.
12485 * charset.c (check_iso_charset_parameter): Convert internal
12486 character to string before calling 'error', since %c now has the
12487 printf meaning.
12488 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12489 overflow when computing char to be passed to 'error'. Do not
12490 pass Lisp_Object to 'error'; pass the integer instead.
12491 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12492 formatted with plain %d.
12493
b189fa66
PE
12494 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12495
bff87ef0
PE
12496 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12497
7e2cac20
PE
12498 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12499
ce4d90b5
PE
12500 * xterm.c (x_catch_errors): Remove duplicate declaration.
12501
266c9547
PE
12502 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12503
79c49ad2
PE
12504 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12505
368f4090
JM
125062011-04-10 Jim Meyering <meyering@redhat.com>
12507
12508 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12509 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12510 return ssize_t not "int", and use size_t as the buffer length.
12511 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12512 * gnutls.h: Update declarations.
12513 * process.c (read_process_output): Use ssize_t, to match.
12514 (send_process): Likewise.
12515
a32d4040
CY
125162011-04-09 Chong Yidong <cyd@stupidchicken.com>
12517
12518 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12519
8546720e 125202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12521
04f2d78b
CB
12522 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12523 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12524
8546720e
GM
12525 * xterm.c (handle_one_xevent):
12526 * xmenu.c (create_and_show_popup_menu):
12527 * xselect.c (x_decline_selection_request)
12528 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12529
0a2f5c1a 125302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12531
12532 Fix some uses of `int' instead of EMACS_INT.
12533 * search.c (string_match_1, fast_string_match)
12534 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12535 (scan_buffer, find_next_newline_no_quit)
12536 (find_before_next_newline, search_command, Freplace_match)
12537 (Fmatch_data): Make some `int' variables be EMACS_INT.
12538
12539 * xdisp.c (display_count_lines): 3rd argument and return value now
12540 EMACS_INT. All callers changed.
12541 (pint2hrstr): Last argument is now EMACS_INT.
12542
12543 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12544 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12545 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12546 (decode_coding_utf_16, decode_coding_emacs_mule)
12547 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12548 (decode_coding_ccl, decode_coding_charset)
12549 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12550 (decode_coding_iso_2022, decode_coding_emacs_mule)
12551 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12552 <char_offset, last_offset>: Declare EMACS_INT.
12553 (encode_coding_utf_8, encode_coding_utf_16)
12554 (encode_coding_emacs_mule, encode_invocation_designation)
12555 (encode_designation_at_bol, encode_coding_iso_2022)
12556 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12557 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12558 Declare EMACS_INT.
12559 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12560 (encode_invocation_designation): Last argument P_NCHARS is now
12561 EMACS_INT.
12562 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12563 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12564
12565 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12566 All users changed.
12567
12568 * ccl.c (Fccl_execute_on_string): Declare some variables
12569 EMACS_INT.
12570
8546720e 125712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12572
12573 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12574
4e19a977
CS
125752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12576
12577 * process.c (Fformat_network_address): Doc fix.
12578
87302331
R
125792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12580
ee7683eb 12581 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12582
cbb59342
CY
125832011-04-08 Chong Yidong <cyd@stupidchicken.com>
12584
12585 * keyboard.c (read_char): Call Lisp function help-form-show,
12586 instead of using internal_with_output_to_temp_buffer.
12587 (Qhelp_form_show): New var.
e0d38eeb 12588 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12589
12590 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12591
12592 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12593
e67a13ab
CY
125942011-04-06 Chong Yidong <cyd@stupidchicken.com>
12595
04f2d78b
CB
12596 * process.c (Flist_processes): Remove to Lisp.
12597 (list_processes_1): Delete.
e67a13ab 12598
973f782d
EZ
125992011-04-06 Eli Zaretskii <eliz@gnu.org>
12600
7c106b1e
EZ
12601 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12602
973f782d
EZ
12603 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12604
41cf7d1a 126052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12606
ca23cc88
PE
12607 Fix more problems found by GCC 4.6.0's static checks.
12608
f390e2d5
PE
12609 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12610
42eea0d0
PE
12611 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12612
b69769da 12613 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12614
f9541e84
PE
12615 * xdisp.c (vmessage): Mark as a printf-like function.
12616
13841b55
PE
12617 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12618
c136c10f
PE
12619 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12620
5e2d4a30
PE
12621 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12622 printf-like functions.
12623 (tiff_load): Add casts to remove these marks before passing them
12624 to system-supplied API.
12625
583f48b9
PE
12626 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12627
b25d760e
PE
12628 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12629 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12630 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12631 directly, rather than having caller test rule sign. This avoids
12632 some unnecessary tests.
12633 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12634 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12635 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12636
bc7b6697 12637 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12638 (xfont_open): Avoid unnecessary tests.
bc7b6697 12639
27ccc379
PE
12640 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12641
dcd5c89a
PE
12642 * composite.h, composite.c (composition_gstring_put_cache):
12643 Use EMACS_INT, not int, for length.
12644
b13a45c6
PE
12645 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12646 breaking out part of COMPOSITION_DECODE_RULE.
12647 (COMPOSITION_DECODE_RULE): Use it.
12648 * composite.c (get_composition_id): Remove unused local vars,
12649 by using the new macro.
12650
1e792e4d
PE
12651 * textprop.c (set_text_properties_1): Change while to do-while,
12652 since the condition is always true at first.
12653
dc6c6455 12654 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12655 (interval_deletion_adjustment): Return unsigned value.
12656 All uses changed.
dc6c6455 12657
aba7731a
PE
12658 * process.c (list_processes_1, create_pty, read_process_output):
12659 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12660 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12661 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12662 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12663 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12664
fdfc4bf3
PE
12665 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12666
fca8fe46 12667 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12668 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12669
06a0259a 12670 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12671 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12672 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12673
e7b9e80f
PE
12674 * print.c (print_error_message): Avoid int overflow.
12675
56201685
PE
12676 * font.c (font_list_entities): Redo for clarity,
12677 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12678
78834453 12679 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12680 (font_score): Avoid potential overflow in diff calculation.
78834453 12681
0bc0b309 12682 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12683 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12684
e610eaca
PE
12685 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12686
b895abce
PE
12687 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12688 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12689 can always succeed if overflow has undefined behavior.
12690
1f1d9321 12691 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12692 (wordify): Omit three unnecessary tests.
1f1d9321 12693
c59478bc
PE
12694 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12695 All callers changed. This avoids the need for an unused var.
12696
79b73827
PE
12697 * casefiddle.c (casify_region): Remove var that is set but not used.
12698
a4db5dfe
PE
12699 * dired.c (file_name_completion): Remove var that is set but not used.
12700
43aae36e
PE
12701 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12702
2a47c44d 12703 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12704 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12705
a37c69bf
PE
12706 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12707 Check for integer overflow on size calculations.
12708
328ab8e7
PE
12709 * buffer.c (Fprevious_overlay_change): Remove var that is set
12710 but not used.
12711
e5a2a5cb
PE
12712 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12713 Remove vars that are set but not used.
8d84a6eb 12714 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12715 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12716
a60e5f68
PE
12717 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12718
f661cb61 12719 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12720 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12721
f0397f5a
PE
12722 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12723 that are set but not used.
12724
8664db06 12725 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12726 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12727
6abdaa4a
PE
12728 * xselect.c (x_get_local_selection, x_handle_property_notify):
12729 Remove vars that are set but not used.
12730
0ce7538d 12731 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12732 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12733
9ae848fc
PE
12734 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12735 Remove var that is set but not used.
0b918413
PE
12736 (scroll_bar_windows_size): Now size_t, not int.
12737 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12738 Check for overflow.
9ae848fc 12739
a5a62657
PE
12740 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12741 (map_tty_color) [!defined MSDOS]: Likewise.
12742
5c5cdd39
PE
12743 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12744
66ebf983
PE
12745 * coding.c: Remove vars that are set but not used.
12746 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12747 All callers changed.
12748 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12749 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12750 (decode_coding_charset): Remove vars that are set but not used.
12751
1be4d761
PE
12752 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12753 that is set but not used.
12754
47553fa8
PE
12755 * print.c (print_object): Remove var that is set but not used.
12756
1f7196bf 12757 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12758 The gnulib version avoids calling malloc in the usual case,
12759 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12760 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12761 * filelock.c (current_lock_owner): Likewise.
12762 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12763 * sysdep.c: Include allocator.h, careadlinkat.h.
12764 (emacs_no_realloc_allocator): New static constant.
12765 (emacs_readlink): New function.
fdb61804
PE
12766 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12767 ../lib/careadlinkat.h.
d1fdcab7 12768
f84c17c7
SM
127692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12770
12771 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12772 first non-nil return value).
12773
ef3862ad
JD
127742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12775
12776 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12777 if not defined (Bug#8403).
12778
376a7006
JB
127792011-04-02 Juanma Barranquero <lekktu@gmail.com>
12780
12781 * xdisp.c (display_count_lines): Remove parameter `start',
12782 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12783 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12784 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12785 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12786 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12787 and thereabouts. All callers changed.
12788 (get_per_char_metric): Remove parameter `f', unused since
12789 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12790
6ca3801d
JM
127912011-04-02 Jim Meyering <meyering@redhat.com>
12792
12793 do not dereference NULL upon failed strdup
12794 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12795 (ns_get_family): Likewise.
12796
d8e2b5ba
JB
127972011-04-02 Juanma Barranquero <lekktu@gmail.com>
12798
12799 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12800
8c74fcbd
JD
128012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12802
12803 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12804 later (Bug#8403).
12805
7200d79c
SM
128062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12807
03408648 12808 Add lexical binding.
7200d79c 12809
03408648
SM
12810 * window.c (Ftemp_output_buffer_show): New fun.
12811 (Fsave_window_excursion):
12812 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12813
12814 * lread.c (lisp_file_lexically_bound_p): New function.
12815 (Fload): Bind Qlexical_binding.
12816 (readevalloop): Remove `evalfun' arg.
12817 Bind Qinternal_interpreter_environment.
12818 (Feval_buffer): Bind Qlexical_binding.
12819 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12820 Mark as dynamic.
12821 (syms_of_lread): Declare `lexical-binding'.
12822
12823 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12824
12825 * keyboard.c (eval_dyn): New fun.
12826 (menu_item_eval_property): Use it.
ca105506
SM
12827
12828 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12829
03408648
SM
12830 * fns.c (concat, mapcar1): Accept byte-code-functions.
12831
12832 * eval.c (Fsetq): Handle lexical vars.
12833 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12834 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12835 (FletX, Flet): Obey lexical binding.
12836 (Fcommandp): Handle closures.
12837 (Feval): New `lexical' arg.
12838 (eval_sub): New function extracted from Feval. Use it almost
12839 everywhere where Feval was used. Look up vars in lexical env.
12840 Handle closures.
12841 (Ffunctionp): Move from subr.el.
12842 (Ffuncall): Handle closures.
12843 (apply_lambda): Remove `eval_flags'.
12844 (funcall_lambda): Handle closures and new byte-code-functions.
12845 (Fspecial_variable_p): New function.
12846 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12847 but without exporting it to Lisp.
23aba0ea 12848
23aba0ea 12849 * doc.c (Fdocumentation, store_function_docstring):
03408648 12850 * data.c (Finteractive_form): Handle closures.
23aba0ea 12851
03408648
SM
12852 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12853 interactive spec.
ba83908c 12854
04f2d78b
CB
12855 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12856 New byte-codes.
03408648
SM
12857 (exec_byte_code): New function extracted from Fbyte_code to handle new
12858 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12859
03408648 12860 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12861
03408648 12862 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12863
e2abce01
JB
128642011-03-31 Juanma Barranquero <lekktu@gmail.com>
12865
12866 * xdisp.c (redisplay_internal): Fix prototype.
12867
63696a73 128682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12869
63696a73 12870 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12871 (try_scrolling): Use it when setting scroll_limit.
12872 Limit scrolling to 100 screen lines.
63696a73
EZ
12873 (redisplay_window): Even when falling back on "recentering",
12874 position point in the window according to scroll-conservatively,
12875 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12876
12877 (try_scrolling): When point is above the window, allow searching
12878 as far as scroll_max, or one screenful, to compute vertical
12879 distance from PT to the scroll margin position. This prevents
12880 try_scrolling from unnecessarily failing when
12881 scroll-conservatively is set to a value slightly larger than the
12882 window height. Clean up the case of PT below the margin at bottom
12883 of window: scroll_max can no longer be INT_MAX. When aggressive
12884 scrolling is in use, don't let point enter the opposite scroll
12885 margin as result of the scroll.
12886 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12887 threshold of 100 lines for never-recentering scrolling.
12888
e4cc2dfc
JB
128892011-03-31 Juanma Barranquero <lekktu@gmail.com>
12890
12891 * dispextern.h (move_it_by_lines):
12892 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12893 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12894 (message_log_check_duplicate): Remove parameters `prev_bol' and
12895 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12896 (redisplay_internal): Remove parameter `preserve_echo_area',
12897 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12898
12899 * indent.c (Fvertical_motion):
12900 * window.c (window_scroll_pixel_based, Frecenter):
12901 Don't pass `need_y_p' to `move_it_by_lines'.
12902
1c470562
SM
129032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12904
44f230aa
SM
12905 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12906 steal a few bits to be more compact.
12907 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12908 Remove unneeded casts.
12909
1c470562
SM
12910 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12911
888adce9
ZK
129122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12913
12914 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12915 binding" message (bug#7967).
12916
f838ed7b
PE
129172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12918
77861b95
PE
12919 Fix more problems found by GCC 4.6.0's static checks.
12920
de6dbc14
PE
12921 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12922 Remove unused local var.
12923
f838ed7b
PE
12924 * editfns.c (Fmessage_box): Remove unused local var.
12925
792c7b2b
PE
12926 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12927 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12928 Omit unused local vars.
c499e557 12929 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12930 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12931 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12932 Omit unused local var.
12933
ba0165e1
PE
12934 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12935 Don't assume string length fits in int.
32ad8845 12936 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12937 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12938
3c59b4c9
PE
12939 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12940 instead of alloca (Bug#8344).
12941
a3eed478 12942 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12943 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12944
eb4d412d
PE
12945 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12946
1658b401
PE
12947 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12948 concerns.
12949
12950 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12951
12952 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12953
9a2c6e05
PE
12954 * keyboard.c (syms_of_keyboard): Use the same style as later
12955 in this function when indexing through an array. This also
12956 works around GCC bug 48267.
12957
03d0a109
PE
12958 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12959
44f730c8
PE
12960 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12961
fe75f926
PE
12962 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12963 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12964
ffa8c828
PE
12965 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12966 This avoids undefined behavior on integer overflow, and is a bit
12967 more convenient anyway since it is compared to a size_t variable.
12968
c5101a77
PE
12969 Variadic C functions now count arguments with size_t, not int.
12970 This avoids an unnecessary limitation on 64-bit machines, which
12971 caused (substring ...) to crash on large vectors (Bug#8344).
12972 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12973 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12974 All variadic functions and their callers changed accordingly.
c5101a77
PE
12975 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12976 * data.c (arith_driver, float_arith_driver): Likewise.
12977 * editfns.c (general_insert_function): Likewise.
12978 * eval.c (struct backtrace.nargs, interactive_p)
12979 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12980 (funcall_lambda, mark_backtrace): Likewise.
12981 * fns.c (concat): Likewise.
12982 * frame.c (x_set_frame_parameters): Likewise.
12983 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12984 0 if not found, not -1. All callers changed.
12985
dd3f25f7
PE
12986 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12987 (stack_copy_size): Now size_t, not int.
12988 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12989
461c2ab9
JB
129902011-03-28 Juanma Barranquero <lekktu@gmail.com>
12991
12992 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12993 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12994 All callers changed.
12995
12996 * lisp.h (multibyte_char_to_unibyte):
12997 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12998 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12999 * character.h (CHAR_TO_BYTE8):
13000 * cmds.c (internal_self_insert):
13001 * editfns.c (general_insert_function):
13002 * keymap.c (push_key_description):
13003 * search.c (Freplace_match):
13004 * xdisp.c (message_dolog, set_message_1): All callers changed.
13005
f6d62986
SM
130062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13007
13008 * keyboard.c (safe_run_hook_funcall): New function.
13009 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13010 don't set the hook to nil, but remove the offending function instead.
13011 (Qcommand_hook_internal): Remove, unused.
13012 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13013 Vcommand_hook_internal.
13014
13015 * eval.c (enum run_hooks_condition): Remove.
13016 (funcall_nil, funcall_not): New functions.
13017 (run_hook_with_args): Call each function through a `funcall' argument.
13018 Remove `cond' argument, now redundant.
13019 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13020 (Frun_hook_with_args_until_failure): Adjust accordingly.
13021 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13022
1db5b1ad
JB
130232011-03-28 Juanma Barranquero <lekktu@gmail.com>
13024
13025 * dispextern.h (string_buffer_position): Remove declaration.
13026
13027 * print.c (strout): Remove parameter `multibyte', unused since
13028 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13029
13030 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13031 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13032 All callers changed.
13033
13034 * w32.c (_wsa_errlist): Use braces for struct initializers.
13035
13036 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13037 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13038 All callers changed.
13039 (string_buffer_position): Likewise. Also, make static (it's never
13040 used outside xdisp.c).
13041 (cursor_row_p): Remove parameter `w', unused since
13042 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13043 (decode_mode_spec): Remove parameter `precision', introduced during
13044 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13045 All callers changed.
13046
5ffb62aa
JD
130472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13048
13049 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13050
461c2ab9 130512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13052
13053 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13054 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13055 (ns_update_auto_hide_menu_bar): New functions.
13056 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13057 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13058 ns_constrain_all_frames.
13059 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13060 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13061
5c380ffb
JD
130622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13063
13064 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13065
9af30bdf
GM
130662011-03-27 Glenn Morris <rgm@gnu.org>
13067
13068 * syssignal.h: Replace RETSIGTYPE with void.
13069 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13070 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13071 Replace SIGTYPE with void everywhere.
13072 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13073 * s/template.h (SIGTYPE): Remove commented out definition.
13074
e2abce01
JB
130752011-03-26 Eli Zaretskii <eliz@gnu.org>
13076
13077 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13078 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13079
f868cd8a
JB
130802011-03-26 Juanma Barranquero <lekktu@gmail.com>
13081
59eb0929
JB
13082 * w32.c (read_unc_volume): Use parameter `henum', instead of
13083 global variable `wget_enum_handle'.
13084
13085 * keymap.c (describe_vector): Remove parameters `indices' and
13086 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13087 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13088
f868cd8a
JB
13089 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13090
13091 * keyboard.c (timer_check): Remove parameter `do_it_now',
13092 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13093 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13094 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13095
13096 * keyboard.c (read_char):
13097 * w32menu.c (w32_menu_display_help):
13098 * xmenu.c (show_help_event, menu_help_callback):
13099 Adjust calls to `show_help_echo'.
13100
13101 * gtkutil.c (xg_maybe_add_timer):
13102 * keyboard.c (readable_events):
13103 * process.c (wait_reading_process_output):
13104 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13105
13106 * insdel.c (adjust_markers_gap_motion):
13107 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13108 (gap_left, gap_right): Don't call it.
13109
2ecf6fdb
CY
131102011-03-25 Chong Yidong <cyd@stupidchicken.com>
13111
13112 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13113 incurred during fontification.
13114
6b1f9ba4
JB
131152011-03-25 Juanma Barranquero <lekktu@gmail.com>
13116
13117 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13118 (DEFVAR_PER_BUFFER): Don't pass it.
13119
13120 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13121 (scrolling_window): Don't pass it.
13122
0f4a96b5
JB
131232011-03-25 Juanma Barranquero <lekktu@gmail.com>
13124
13125 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13126
13127 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13128 and `suffix'.
13129 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13130 of variables specific to SELinux and computation of `encoded_absname'.
13131
13132 * image.c (XPutPixel): Remove unused variable `height'.
13133
13134 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13135
13136 * unexw32.c (get_section_info): Remove unused variable `section'.
13137
13138 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13139 (system_process_attributes): Remove unused variable `sess'.
13140 (sys_read): Remove unused variable `err'.
13141
13142 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13143 (w32_wnd_proc): Remove unused variable `isdead'.
13144 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13145 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13146 (x_create_tip_frame): Remove unused variable `tem'.
13147
13148 * w32inevt.c (w32_console_read_socket):
13149 Remove unused variable `no_events'.
13150
13151 * w32term.c (x_draw_composite_glyph_string_foreground):
13152 Remove unused variable `width'.
13153
1149507c
JB
131542011-03-24 Juanma Barranquero <lekktu@gmail.com>
13155
13156 * w32term.c (x_set_glyph_string_clipping):
13157 Don't pass uninitialized region to CombineRgn.
13158
9c88f339
JB
131592011-03-23 Juanma Barranquero <lekktu@gmail.com>
13160
13161 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13162 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13163 (Fx_close_connection): Remove unused variable `i'.
13164
13165 * w32font.c (w32font_draw): Return number of glyphs.
13166 (w32font_open_internal): Remove unused variable `i'.
13167 (w32font_driver): Add missing initializer.
13168
13169 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13170 (fill_in_menu): Remove unused variable `items_added'.
13171
13172 * w32term.c (last_mouse_press_frame): Remove static global variable.
13173 (w32_clip_to_row): Remove unused variable `f'.
13174 (x_delete_terminal): Remove unused variable `i'.
13175
13176 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13177 (NOTHING): Remove unused static global variable.
13178 (uniscribe_check_otf): Remove unused variable `table'.
13179 (uniscribe_font_driver): Add missing initializers.
13180
dee091a3
JD
131812011-03-23 Julien Danjou <julien@danjou.info>
13182
13183 * term.c (Fsuspend_tty, Fresume_tty):
13184 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13185 * window.c (temp_output_buffer_show):
13186 * insdel.c (signal_before_change):
13187 * frame.c (Fhandle_switch_frame):
13188 * fileio.c (Fdo_auto_save):
13189 * emacs.c (Fkill_emacs):
13190 * editfns.c (save_excursion_restore):
13191 * cmds.c (internal_self_insert):
13192 * callint.c (Fcall_interactively):
13193 * buffer.c (Fkill_all_local_variables):
13194 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13195 Use Frun_hooks.
0f4a96b5 13196 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13197 unconditionally since it does the check itself.
dee091a3 13198
2c520ab5 131992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13200
c9c49752
PE
13201 Fix more problems found by GCC 4.5.2's static checks.
13202
8abc3f12
PE
13203 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13204 the first time through the loop, since we know p0 < p1 then.
13205 This also avoids a gcc -Wstrict-overflow warning.
13206
a2d26660
PE
13207 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13208 leading to a memory leak, possible in functions like
13209 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13210 of objects (Bug#8318).
a2d26660 13211
916c72e9
PE
13212 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13213 that could (at least in theory) be that large.
13214
19ab8a18
PE
13215 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13216 This is less likely to overflow, and avoids undefined behavior if
13217 overflow does occur. All callers changed. Use strtoul to scan
13218 for the unsigned long integer.
b7cbbd6f
PE
13219 (pint2hrstr): Simplify and tune code slightly.
13220 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13221
f0641eff
PE
13222 * scroll.c (do_scrolling): Work around GCC bug 48228.
13223 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13224
7f650bb9
PE
13225 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13226 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13227 (validate_x_resource_name): Simplify count usage.
13228 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13229
37dd57d1
PE
13230 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13231 fail (Bug#8306).
81e56e61 13232
699979fc 13233 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13234
401bf9b4
PE
13235 * process.c (Fmake_network_process): Use socklen_t, not int,
13236 where POSIX says socklen_t is required in portable programs.
13237 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13238 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13239 (Fmake_network_process, server_accept_connection):
13240 (wait_reading_process_output, read_process_output):
13241 Likewise.
13242
b93aacde
PE
13243 * process.c: Rename or move locals to avoid shadowing.
13244 (list_processes_1, Fmake_network_process):
13245 (read_process_output_error_handler, exec_sentinel_error_handler):
13246 Rename or move locals.
4dc343ee 13247 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13248 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13249 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13250 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13251 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13252
af8a867c 13253 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13254 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13255 Include tparam.h instead, since it declares them.
af8a867c
PE
13256 * cm.h (PC): Remove extern decl; tparam.h now does this.
13257 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13258 * terminfo.c: Include tparam.h, to check interfaces.
13259 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13260 (tparam): Adjust signature to match interface in tparam.h;
13261 this removes some undefined behavior. Check that outstring and len
13262 are zero, which they always are with Emacs.
13263 * tparam.h (PC, BC, UP): New extern decls.
13264
0248044d 13265 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13266 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13267
8ff096c1 13268 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13269 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13270 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13271 (ftfont_list): Remove unused local.
49eaafba
PE
13272 (get_adstyle_property, ftfont_pattern_entity):
13273 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13274 Rename locals to avoid shadowing.
8ff096c1 13275
e2be39f6
PE
13276 * xfont.c (xfont_list_family): Mark var as initialized.
13277
c9735e30
PE
13278 * xml.c (make_dom): Now static.
13279
8f5201ae
PE
13280 * composite.c (composition_compute_stop_pos): Rename local to
13281 avoid shadowing.
b246f932
PE
13282 (composition_reseat_it): Remove unused locals.
13283 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13284 (composition_update_it): Mark var as initialized.
11b61122
PE
13285 (find_automatic_composition): Mark vars as initialized,
13286 with a FIXME (Bug#8290).
8f5201ae 13287
760fbc2c
PE
13288 character.h: Rename locals to avoid shadowing.
13289 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13290 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13291 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13292 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13293 to avoid shadowing.
13294
ff08eb85
PE
13295 * textprop.c (property_change_between_p): Remove; unused.
13296
fc7bf025
PE
13297 * intervals.c (interval_start_pos): Now static.
13298
235d7abc
PE
13299 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13300
44f230aa
SM
13301 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13302 Rename locals to avoid shadowing.
3e7d6594 13303
50060332
PE
13304 * sound.c (wav_play, au_play, Fplay_sound_internal):
13305 Fix pointer signedness.
d01f234b 13306 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13307 (wav_play): Initialize a variable to 0, to prevent undefined
13308 behavior (Bug#8278).
50060332 13309
c4fc4e30
PE
13310 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13311
918436ed
PE
13312 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13313
c939f91b
PE
13314 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13315 clobbering (Bug#8298).
b9c7f648
PE
13316 * sysdep.c (sys_subshell): Likewise.
13317 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13318
6bd8c144
PE
13319 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13320 This should get cleaned up, so that child_setup has the
13321 same signature on all platforms.
13322
7710357c 13323 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13324 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13325
c59da222
CY
133262011-03-22 Chong Yidong <cyd@stupidchicken.com>
13327
13328 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13329 not to be necessary, and produces flickering.
13330
66b87493
GM
133312011-03-20 Glenn Morris <rgm@gnu.org>
13332
13333 * config.in: Remove file.
13334
45b6f6d5
JB
133352011-03-20 Juanma Barranquero <lekktu@gmail.com>
13336
13337 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13338 are now in src/globals.h.
13339 (syms_of_minibuf): Remove spurious & from previous change.
13340
cd394be1 133412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13342
13343 * minibuf.c (completing-read-function): New variable.
13344 (completing-read-default): Rename from completing-read.
13345 (completing-read): Call completing-read-function.
13346
b14e3e21
CY
133472011-03-19 Juanma Barranquero <lekktu@gmail.com>
13348
13349 * xfaces.c (Fx_load_color_file):
13350 Read color file from absolute filename (bug#8250).
13351
f2b726e6
JB
133522011-03-19 Juanma Barranquero <lekktu@gmail.com>
13353
13354 * makefile.w32-in: Update dependencies.
13355
09f6ff02
EZ
133562011-03-17 Eli Zaretskii <eliz@gnu.org>
13357
13358 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13359
29a6015a
PE
133602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13361
a3a6c54e
PE
13362 Fix more problems found by GCC 4.5.2's static checks.
13363
b766f867
PE
13364 * process.c (make_serial_process_unwind, send_process_trap):
13365 (sigchld_handler): Now static.
13366
be02381c
PE
13367 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13368 That way, the code declares only the vars that it needs.
13369 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13370 * s/cygwin.h (PTY_ITERATION): Likewise.
13371 * s/darwin.h (PTY_ITERATION): Likewise.
13372 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13373
57048744
PE
13374 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13375 * process.c (allocate_pty): Don't declare stb unless it's needed.
13376
7914961c 13377 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13378 (CONSTANTLIM): Remove; unused.
13379 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13380 Define only if needed.
7914961c 13381
b3967b18
PE
13382 * unexelf.c (unexec): Name an expression,
13383 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13384 Use a different way to cause a compilation error if anyone uses
13385 n rather than nn, a way that does not involve shadowing.
73366a00 13386 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13387
29a6015a
PE
13388 * deps.mk (unexalpha.o): Remove; unused.
13389
43cfc33e 13390 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13391 * unexec.h: New file.
ce701a33
PE
13392 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13393 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13394 Depend on unexec.h.
13395 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13396 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13397 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13398 Change as necessary to match prototype in unexec.h.
ce701a33 13399
01f44d5a
PE
13400 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13401 shadowing.
4f63c6bb 13402 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13403
a6670b0b
PE
13404 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13405 Rename locals to avoid shadowing.
13406
cef2010d 13407 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13408 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13409
d4d7173a
PE
13410 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13411
f08b802a
PE
13412 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13413 warning when compiling print.c.
13414
3ddb0639
PE
13415 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13416 instead of using an uninitialized var.
5ad03b97 13417 (font_sort_entities): Mark var as initialized.
3ddb0639 13418
170a2692
PE
13419 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13420
e663c700
PE
13421 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13422 pointers to constants.
89bc529a 13423 (font_parse_fcname): Remove unused vars.
7b81e2d0 13424 (font_delete_unmatched): Now static.
ea838e10 13425 (font_get_spec): Remove; unused.
13a547c6
PE
13426 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13427 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13428 Rename or move locals to avoid shadowing.
e663c700 13429
2a80c887 13430 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13431 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13432
1384fa33 13433 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13434 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13435
8b2c52e9
PE
13436 * alloc.c (mark_backtrace): Move decl from here ...
13437 * lisp.h: ... to here, so that it can be checked.
13438
475545b5 13439 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13440 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13441 (lisp_indirect_variable): Name an expression,
13442 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13443 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13444
b1349114 13445 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13446 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13447 Use const pointer when appropriate.
b1349114 13448
a2928364
PE
13449 * lisp.h (get_system_name, get_operating_system_release):
13450 Move decls here, to check interfaces.
13451 * process.c (get_operating_system_release): Move decl to lisp.h.
13452 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13453 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13454 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13455 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13456 (Fformat_time_string, Fencode_time, Finsert_char):
13457 (Ftranslate_region_internal, Fformat):
13458 Rename or remove local vars to avoid shadowing.
9710023e 13459 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13460
a415e694
PE
13461 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13462 avoid shadowing.
13463
8ef4622d
PE
13464 * lisp.h (eassert): Check that the argument compiles, even if
13465 ENABLE_CHECKING is not defined.
13466
946f9a5b
PE
13467 * data.c (Findirect_variable): Name an expression, to avoid
13468 gcc -Wbad-function-cast warning.
112396d6 13469 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13470 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13471 (Fmake_variable_buffer_local, Fmake_local_variable):
13472 Mark variables as initialized.
52746918 13473 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13474
e5aab7e7 13475 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13476 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13477 Rename locals to avoid shadowing.
dff45157
PE
13478 (mark_stack): Move local variables into the #ifdef region where
13479 they're used.
7bc26fdb
PE
13480 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13481 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13482 needed otherwise.
13483 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13484 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13485 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13486
e5aab7e7
PE
13487 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13488 avoids undefined behavior in theory.
13489
4da60324
PE
13490 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13491
88043301
PE
13492 Use functions, not macros, for up- and down-casing (Bug#8254).
13493 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13494 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13495 to use the following functions instead of these macros.
13496 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13497 EMACS_INT, since callers assume the returned value fits in int.
13498 (upcase1): Likewise, for UPCASE_TABLE.
13499 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13500 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13501 the race-condition problem in the old DOWNCASE.
88043301 13502
19ed5445
PE
13503 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13504 Rename locals to avoid shadowing.
13505 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13506 (regex_compile, re_search_2, re_match_2_internal):
13507 Remove unused local vars.
952db0d7
PE
13508 (FREE_VAR): Rewrite so as not to use empty "else",
13509 which gcc can warn about.
da053e48 13510 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13511 (RETALLOC_IF): Define only if needed.
13512 (WORDCHAR_P): Likewise. This one is never needed, but is used
13513 only in a comment talking about a compiler bug, so put inside
13514 the #if 0 of that comment.
13515 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13516 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13517 Remove; unused.
19ed5445 13518
1f3561e4 13519 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13520 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13521 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13522
ded6f8f7
PE
13523 * search.c (simple_search): Remove unused var.
13524
dbd37a95
PE
13525 * dired.c (compile_pattern): Move decl from here ...
13526 * lisp.h: ... to here, so that it can be checked.
13527 (struct re_registers): New forward decl.
13528
7e47afad
PE
13529 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13530
85f24f61
PE
13531 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13532 All uses changed.
13533 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13534 Rename locals to avoid shadowing.
5671df8f 13535 (Fvertical_motion): Mark locals as initialized.
85f24f61 13536
181aa2be 13537 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13538 (casify_region): Mark local as initialized.
181aa2be 13539
930d429c
PE
13540 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13541
7082eac6
PE
13542 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13543 New macros, so that the caller can use some names other than
13544 gcpro1, gcpro2, etc.
13545 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13546 of the new macros.
13547 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13548 argument, for consistency with GCPRO2_VAR, etc: it is now the
13549 prefix of the variable, not the variable itself. All uses
13550 changed.
38b2c076
PE
13551 * dired.c (directory_files_internal, file_name_completion):
13552 Rename locals to avoid shadowing.
13553
15206ed9
PE
13554 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13555 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13556 dired.c's scmp function, had undefined behavior.
13557 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13558 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13559 * buffer.h: ... to here, because these macros use current_buffer,
13560 and the new implementation with inline functions needs to have
13561 current_buffer in scope now, rather than later when the macros
13562 are used.
13563 (downcase, upcase1): New static inline functions.
13564 (DOWNCASE, UPCASE1): Reimplement using these functions.
13565 This avoids undefined behavior in expressions like
13566 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13567 from race conditions in accessing the global variables
13568 case_temp1 and case_temp2.
13569 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13570 * lisp.h (case_temp1, case_temp2): Remove their decls.
13571 * character.h (ASCII_CHAR_P): Move from here ...
13572 * lisp.h: ... to here, so that the inline functions mentioned
13573 above can use them.
13574
4a6bea26
PE
13575 * dired.c (directory_files_internal_unwind): Now static.
13576
f14b7e14
PE
13577 * fileio.c (file_name_as_directory, directory_file_name):
13578 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13579 Now static.
2893f146
PE
13580 (file_name_as_directory): Use const pointers when appropriate.
13581 (Fexpand_file_name): Likewise. In particular, newdir might
13582 point at constant storage, so make it a const pointer.
fd4ead52 13583 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13584 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13585 signedness issues.
f839df0c
PE
13586 (Fset_file_times, Finsert_file_contents, auto_save_error):
13587 Rename locals to avoid shadowing.
f14b7e14 13588
5716756e 13589 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13590 (Ftry_completion, Fall_completions): Rename or remove locals
13591 to avoid shadowing.
5716756e 13592
b4c3046a
PE
13593 * marker.c (bytepos_to_charpos): Remove; unused.
13594
b45db522
PE
13595 * lisp.h (verify_bytepos, count_markers): New decls,
13596 so that gcc does not warn that these functions aren't declared.
13597
85876d07
PE
13598 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13599 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13600 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13601 (copy_text): Remove unused local var.
85876d07 13602
03d78a21 13603 * filelock.c (within_one_second): Now static.
b3dd38ab 13604 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13605
5df8f01b
PE
13606 * buffer.c (fix_overlays_before): Mark locals as initialized.
13607 (fix_start_end_in_overlays): Likewise. This function should be
13608 simplified by using pointers-to-pointers, but that's a different
13609 matter.
b1d876f1 13610 (switch_to_buffer_1): Now static.
8f54f30a
PE
13611 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13612 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13613
a70072c9 13614 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13615 Fix pointer signedness issue.
edced198
PE
13616 (sys_subshell): Mark local as volatile if checking for lint,
13617 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13618 (MAXPATHLEN): Define only if needed.
a70072c9 13619
a0977c44
PE
13620 * process.c (serial_open, serial_configure): Move decls from here ...
13621 * systty.h: ... to here, so that they can be checked.
13622
a884fdcc
PE
13623 * fns.c (get_random, seed_random): Move extern decls from here ...
13624 * lisp.h: ... to here, so that they can be checked.
13625
604efe86 13626 * sysdep.c (reset_io): Now static.
b8950c94 13627 (wait_for_termination_signal): Remove; unused.
604efe86 13628
38fc62d9
PE
13629 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13630 (copy_keymap_item, append_key, push_text_char_description):
13631 Now static.
1004a21a 13632 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13633 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13634 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13635 (describe_map_tree):
13636 Rename locals to avoid shadowing.
38fc62d9 13637
2f2650da
PE
13638 * keyboard.c: Declare functions static if they are not used elsewhere.
13639 (echo_char, echo_dash, cmd_error, top_level_2):
13640 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13641 (read_char, kbd_buffer_get_event, make_lispy_position):
13642 (make_lispy_event, make_lispy_movement, apply_modifiers):
13643 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13644 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13645 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13646 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13647 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13648
a053e86c 13649 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13650 (mark_kboards): Move decl here ...
13651 * alloc.c (mark_kboards): ... from here.
a053e86c 13652
4752793e
PE
13653 * lisp.h (force_auto_save_soon): New decl.
13654
74f10ca7 13655 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13656 (DEFINE_DUMMY_FUNCTION): New macro.
13657 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13658 Use it.
c03cd23f
PE
13659 (main): Add casts to avoid warnings
13660 if GCC considers string literals to be constants.
74f10ca7 13661
022e70d4
PE
13662 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13663
59d6fe83
PE
13664 * dbusbind.c: Pointer signedness fixes.
13665 (xd_signature, xd_append_arg, xd_initialize):
13666 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13667 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13668 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13669 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13670
78320123
PE
13671 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13672 if GCC considers string literals to be constants.
49cebcca 13673 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13674
35ac2a97
SM
136752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13676
fb103ca9
SM
13677 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13678 (print_preprocess, print_object): New macro to fix last change.
13679
35ac2a97
SM
13680 * print.c (print_preprocess): Don't forget font objects.
13681
62973b41
JB
136822011-03-16 Juanma Barranquero <lekktu@gmail.com>
13683
13684 * emacs.c (USAGE3): Doc fixes.
13685
0e48bb22
AS
136862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13687
13688 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13689 structure.
13690
7684e57b
JB
136912011-03-14 Juanma Barranquero <lekktu@gmail.com>
13692
13693 * lisp.h (VWindow_system, Qfile_name_history):
13694 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13695 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13696 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13697
13698 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13699 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13700
13701 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13702 * w32console.c (detect_input_pending, read_input_pending)
13703 (encode_terminal_code):
13704 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13705 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13706 (w32_system_caret_y, Qfile_name_history):
13707 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13708 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13709 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13710 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13711 * w32proc.c (Qlocal, report_file_error):
13712 * w32term.c (Vwindow_system, updating_frame):
13713 * w32uniscribe.c (initialized, uniscribe_font_driver):
13714 Remove unneeded extern declarations.
13715
2aa46d6c
CY
137162011-03-14 Chong Yidong <cyd@stupidchicken.com>
13717
c96bbc66 13718 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13719
cffc6f3b
CY
137202011-03-13 Chong Yidong <cyd@stupidchicken.com>
13721
13722 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13723 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13724 These macros can no longer be used for assignment.
13725
44f230aa
SM
13726 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13727 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13728 (record_buffer_markers, fetch_buffer_markers): New functions for
13729 recording and fetching special buffer markers.
13730 (set_buffer_internal_1, set_buffer_temp): Use them.
13731
13732 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13733
13734 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13735
13736 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13737 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13738
13739 * xdisp.c (hscroll_window_tree):
13740 (reconsider_clip_changes): Use PT instead of BUF_PT.
13741
d251f04b
EZ
137422011-03-13 Eli Zaretskii <eliz@gnu.org>
13743
13744 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13745 $(EMACS_ROOT)/lib/intprops.h.
13746
f0c77cd1
PE
137472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13748
3eca4629
PE
13749 Fix more problems found by GCC 4.5.2's static checks.
13750
7c86ee98
PE
13751 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13752 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13753 (xg_free_frame_widgets): Make it clear that a local variable is
13754 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13755 (gdk_window_get_screen): Make it clear that this macro is needed
13756 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13757 (int_gtk_range_get_value): New function, which avoids a diagnostic
13758 from gcc -Wbad-function-cast.
13759 (xg_set_toolkit_scroll_bar_thumb): Use it.
13760 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13761 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13762 (get_utf8_string, xg_get_file_with_chooser):
13763 Rename locals to avoid shadowing.
13764 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13765
41729b81
PE
13766 * xgselect.c (xg_select): Remove unused var.
13767
f0c77cd1
PE
13768 * image.c (four_corners_best): Mark locals as initialized.
13769 (gif_load): Initialize transparent_p to zero (Bug#8238).
13770 Mark another local as initialized.
ec6cf4c6 13771 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13772
ce0ad53d 13773 * image.c (clear_image_cache): Now static.
d5d5a617 13774 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13775 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13776 (x_edge_detection): Remove unnecessary cast that
13777 gcc -Wbad-function-cast diagnoses.
2037898d 13778 (gif_load): Fix pointer signedness.
6ae141d6
PE
13779 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13780 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13781
33383987 137822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13783
d32df629
PE
13784 Improve quality of tests for time stamp overflow.
13785 For example, without this patch (encode-time 0 0 0 1 1
13786 1152921504606846976) returns the obviously-bogus value (-948597
13787 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13788 reports time overflow. See
13789 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13790 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13791 * editfns.c: Include limits.h and intprops.h.
13792 (TIME_T_MIN, TIME_T_MAX): New macros.
13793 (time_overflow): Move earlier, to before first use.
13794 (hi_time, lo_time): New functions, for an accurate test for
13795 out-of-range times.
13796 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13797 (Fget_internal_run_time): Don't assume time_t fits in int.
13798 (make_time): Use list2 instead of Fcons twice.
13799 (Fdecode_time): More accurate test for out-of-range times.
13800 (check_tm_member): New function.
13801 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13802 (lisp_time_argument): Don't rely on undefined left-shift and
13803 right-shift behavior when checking for time stamp overflow.
8be6f318 13804
fe31d94c
PE
13805 * editfns.c (time_overflow): New function, refactoring common code.
13806 (Fformat_time_string, Fdecode_time, Fencode_time):
13807 (Fcurrent_time_string): Use it.
13808
8be6f318
PE
13809 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13810 * dired.c (make_time): Move to ...
13811 * editfns.c (make_time): ... here.
13812 * systime.h: Note the move.
13813
09d9db2c 138142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13815
126bc0dc
YM
13816 * fringe.c (update_window_fringes): Remove unused variables.
13817
c47cbdfd
YM
13818 * unexmacosx.c (copy_data_segment): Also copy __got section.
13819 (Bug#8223)
13820
7ac80be9
EZ
138212011-03-12 Eli Zaretskii <eliz@gnu.org>
13822
c96bbc66 13823 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13824 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13825 Constify `char *' arguments and their references according to
13826 prototypes in tparam.h.
13827
ecb0f94d 13828 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13829
7ac80be9
EZ
13830 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13831 Adapt all references accordingly.
13832
13833 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13834
ef1fd07e
TT
138352011-03-11 Tom Tromey <tromey@redhat.com>
13836
13837 * buffer.c (syms_of_buffer): Remove obsolete comment.
13838
7ef4b50c
EZ
138392011-03-11 Eli Zaretskii <eliz@gnu.org>
13840
13841 * termhooks.h (encode_terminal_code): Declare prototype.
13842
13843 * msdos.c (encode_terminal_code): Don't declare prototype.
13844
13845 * term.c (encode_terminal_code): Now external again, used by
13846 w32console.c and msdos.c.
13847
44f230aa
SM
13848 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13849 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13850
4b1ec863 138512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13852
1714f52b 13853 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13854
4b1ec863
PE
13855 * fringe.c (update_window_fringes): Mark locals as initialized
13856 (Bug#8227).
13857 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13858
524c7aa6
PE
13859 * alloc.c (mark_fringe_data): Move decl from here ...
13860 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13861 to check its interface.
13862 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13863
a5c0af81 13864 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13865 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13866 (fontset_font): Mark local as initialized.
a9a06e0b 13867 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13868
b4716021
PE
13869 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13870
811e9bac 13871 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13872 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13873 (x_own_selection, Fx_disown_selection_internal): Rename locals
13874 to avoid shadowing.
13875 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13876
7e3ab302
PE
13877 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13878 so that the caller can use some name other than gcpro1.
13879 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13880 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13881 (Fx_backspace_delete_keys_p):
13882 Use them to avoid shadowing, and rename vars to avoid shadowing.
13883 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13884 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13885 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13886 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13887 Remove unused locals.
7e3ab302
PE
13888 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13889 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13890 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13891 macros.
f78faa98 13892
e2b13473
PE
13893 * xterm.h (x_mouse_leave): New decl.
13894
77f23912
PE
13895 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13896 Remove unused functions.
cdf4ba58
PE
13897 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13898 (x_calc_absolute_position): Now static.
7411c686 13899 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13900 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13901 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13902 unless they are used.
38d0b34a
PE
13903 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13904 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13905 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13906 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13907 (x_error_catcher, x_connection_closed, x_error_handler):
13908 (x_error_quitter, xembed_send_message, x_iconify_frame):
13909 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13910 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13911 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13912
44f230aa
SM
13913 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13914 Rename or move locals to avoid shadowing.
6b463e58 13915 (tty_defined_color, merge_face_heights): Now static.
5967d051 13916 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13917 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13918 does not deduce is never used uninitialized.
73719eba
PE
13919 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13920 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13921
426994c3 13922 * terminal.c (store_terminal_param): Now static.
5489860b 13923
032f1620 13924 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13925 (set_frame_menubar): Remove unused local.
d4323972 13926 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13927 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13928 since they might point to immutable storage.
281585b0
PE
13929 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13930 since it's unused otherwise.
032f1620 13931
367c19e5 13932 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13933 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13934 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13935 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13936 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13937 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13938 does not deduce are never used uninitialized.
70739cbe 13939
07b48fa9
PE
13940 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13941
8868a238 13942 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13943 * window.c (window_loop, size_window):
13944 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13945
7e5cf297 13946 * window.c (display_buffer): Now static.
d6550a9f
PE
13947 (size_window): Mark variables that gcc -Wuninitialized
13948 does not deduce are never used uninitialized.
a586633d
PE
13949 * window.h (check_all_windows): New decl, to forestall
13950 gcc -Wmissing-prototypes diagnostic.
5b555da1 13951 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13952
f6095868
PE
13953 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13954 shadowing.
13955 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13956 Include <limits.h>.
13957 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13958 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13959 (load_charset_map): Mark variables that gcc -Wuninitialized
13960 does not deduce are never used uninitialized.
53df7c11 13961 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13962
f38b440c
PE
13963 * coding.c (coding_set_source, coding_set_destination):
13964 Use "else { /* comment */ }" rather than "else /* comment */;"
13965 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13966 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13967 a block, when the outer 'i' will do.
13968 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13969 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13970 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13971 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13972 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13973 Rename locals to avoid shadowing.
13974 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13975 * coding.c (emacs_mule_char, encode_invocation_designation):
13976 Now static, since they're not used elsewhere.
413bb2db 13977 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13978 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13979 (decode_coding_emacs_mule): Mark variables that gcc
13980 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13981 (detect_coding_iso_2022): Initialize a local variable that might
13982 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13983 this initialization is needed. (Bug#8211)
5f58e762
PE
13984 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13985 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13986 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13987 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13988 Remove unused macros.
f38b440c 13989
232b38b9 13990 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13991 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13992 * character.c (string_count_byte8): Likewise.
232b38b9 13993
fb90da1b
PE
13994 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13995 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13996
fb93dbc2
PE
13997 * chartab.c (copy_sub_char_table): Now static, since it's not used
13998 elsewhere.
5c156ace
PE
13999 (sub_char_table_ref_and_range, char_table_ref_and_range):
14000 Rename locals to avoid shadowing.
bbcd0949 14001 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14002
7d3b3862 14003 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14004 (BIDI_BOB): Remove unused macro.
7d3b3862 14005
6be7d3da
PE
14006 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14007 deduce are never used uninitialized.
c2ed9c8b 14008 * term.c (encode_terminal_code): Likewise.
6be7d3da 14009
75f8807f 14010 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14011
50938595
PE
14012 * tparam.h: New file.
14013 * term.c, tparam.h: Include it.
14014 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14015 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14016 Move these decls to tparam.h, and make them agree with what
14017 is actually in tparam.c. The previous trick of using incompatible
14018 decls in different modules does not conform to the C standard.
14019 All callers of tparam changed to use tparam's actual API.
14020 * tparam.c (tparam1, tparam, tgoto):
14021 Use const pointers where appropriate.
14022
fbceeba2
PE
14023 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14024 * cm.h (struct cm): Likewise.
14025 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14026 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14027 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14028 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14029 (turn_on_face, init_tty): Likewise.
14030 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14031
7f3f1250
PE
14032 * term.c (term_mouse_position): Rename local to avoid shadowing.
14033
e6ca6543
PE
14034 * alloc.c (mark_ttys): Move decl from here ...
14035 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14036
c40f8d15
AS
140372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14038
14039 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14040
cfe0661d
JB
140412011-03-09 Juanma Barranquero <lekktu@gmail.com>
14042
14043 * search.c (compile_pattern_1): Remove argument regp, unused since
14044 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14045 (compile_pattern): Don't pass it.
14046
0afb4571
J
140472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14048
14049 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14050 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14051 for ! HAVE_GTK3.
14052 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14053
14054 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14055
14056 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14057 gdk_window_get_screen, gdk_window_get_geometry,
14058 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14059 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14060 (xg_get_pixbuf_from_pixmap): New function.
14061 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14062 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14063 Call xg_get_pixbuf_from_pixmap instead of
14064 gdk_pixbuf_get_from_drawable.
14065 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14066 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14067 (xg_check_special_colors): Use GtkStyleContext and its functions
14068 for HAVE_GTK3.
14069 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14070 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14071 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14072 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14073 Call gtk_widget_get_preferred_size.
0afb4571
J
14074 (xg_frame_resized): gdk_window_get_geometry only takes 5
14075 parameters.
44f230aa
SM
14076 (xg_win_to_widget, xg_event_is_for_menubar):
14077 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14078 (xg_set_widget_bg): New function.
14079 (delete_cb): New function.
895009e1 14080 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14081 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14082 (xg_set_background_color): Call xg_set_widget_bg.
14083 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14084 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14085 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14086 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14087 if ! HAVE_GTK3.
14088 (update_frame_tool_bar): Call gtk_widget_hide.
14089 (xg_initialize): Use GDK_KEY_g.
14090
14091 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14092 if ! HAVE_GTK3
14093 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14094
14095 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14096 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14097 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14098
1c2cc4ef
JB
140992011-03-08 Juanma Barranquero <lekktu@gmail.com>
14100
14101 * w32xfns.c (select_palette): Check success of RealizePalette against
14102 GDI_ERROR, not zero.
14103
33383987 14104See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14105
14106;; Local Variables:
14107;; coding: utf-8
aac0c6e3
MR
14108;; End:
14109
2f097256 14110 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14111
14112 This file is part of GNU Emacs.
14113
14114 GNU Emacs is free software: you can redistribute it and/or modify
14115 it under the terms of the GNU General Public License as published by
14116 the Free Software Foundation, either version 3 of the License, or
14117 (at your option) any later version.
14118
14119 GNU Emacs is distributed in the hope that it will be useful,
14120 but WITHOUT ANY WARRANTY; without even the implied warranty of
14121 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14122 GNU General Public License for more details.
14123
14124 You should have received a copy of the GNU General Public License
14125 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.