* minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7fcccf1e
PE
12011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2
90532f02
PE
3 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4 for sizes. Check for string overflow more accurately.
5 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6
6d84508d
PE
7 * macros.c: Integer and buffer overflow fixes.
8 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10 Use ptrdiff_t, not int, for sizes.
11 Don't increment bufsize until after realloc succeeds.
12 Check for size-calculation overflow.
13 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
14
437b2cb4
PE
15 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
16
8b9ac8b4
PE
17 * lread.c: Integer overflow fixes.
18 (read_integer): Radix is now EMACS_INT, not int,
19 to improve quality of diagnostics for out-of-range radices.
20 Calculate buffer size correctly for out-of-range radices.
21 (read1): Check for integer overflow in radices, and in
22 read-circle numbers.
82cb60d3
PE
23 (read_escape): Avoid int overflow.
24 (Fload, openp, read_buffer_size, read1)
25 (substitute_object_recurse, read_vector, read_list, map_obarray):
26 Use ptrdiff_t, not int, for sizes.
27 (read1): Use EMACS_INT, not int, for sizes.
20270765 28 Check for size overflow.
8b9ac8b4 29
7fcccf1e
PE
30 * image.c (cache_image): Check for size arithmetic overflow.
31
85fece3e
PE
322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
33
bfbbd7e7
PE
34 * lread.c: Integer overflow issues.
35 (saved_doc_string_size, saved_doc_string_length)
36 (prev_saved_doc_string_size, prev_saved_doc_string_length):
37 Now ptrdiff_t, not int.
38 (read1): Don't assume doc string length fits in int. Check for
39 out-of-range doc string lengths.
40 (read_list): Don't assume file position fits in int.
39019e54 41 (read_escape): Check for hex character overflow.
bfbbd7e7 42
20b84ce9 43 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
44 The following patches are for when GLYPH_DEBUG && !XASSERT.
45 * dispextern.h (trace_redisplay_p, dump_glyph_string):
46 * dispnew.c (flush_stdout):
47 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
48 Mark as externally visible.
49 * dispnew.c (check_window_matrix_pointers): Now static.
50 * dispnew.c (window_to_frame_vpos):
51 * xfns.c (unwind_create_frame):
52 * xterm.c (x_check_font): Remove unused local.
53 * scroll.c (CHECK_BOUNDS):
54 * xfaces.c (cache_fache): Rename local to avoid shadowing.
55 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
56 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
57 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
58 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
59 Now static.
60 (debug_method_add): Use va_list and vsprintf rather than relying
61 on undefined behavior with wrong number of arguments.
62 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
63 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
64 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
65 since we're not interested in debugging glyphs with old libraries.
66 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
67 GCC 4.6.0's static checking.
68
0766b489
PE
692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
70
31fd4b32
PE
71 Integer overflow and signedness fixes (Bug#8873).
72 A few related buffer overrun fixes, too.
73
b79e8648
PE
74 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
75
0766b489
PE
76 * dispextern.h (struct face.stipple):
77 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
78 (x_bitmap_mask, x_allocate_bitmap_record)
79 (x_create_bitmap_from_data, x_create_bitmap_from_file)
80 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
81 (x_create_bitmap_from_xpm_data):
82 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
83 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
84 (.bitmaps_last):
85 * xfaces.c (load_pixmap):
86 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
87 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
88 (.bitmaps_last, struct x_output.icon_bitmap):
89 Use ptrdiff_t, not int, for bitmap indexes.
90 (x_allocate_bitmap_record): Check for size overflow.
91 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
92
b081724f
PE
93 Use ptrdiff_t, not int, for overlay counts.
94 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
95 * editfns.c (overlays_around, get_pos_property):
96 * textprop.c (get_char_property_and_overlay):
97 * xdisp.c (next_overlay_change, note_mouse_highlight):
98 * xfaces.c (face_at_buffer_position):
21514da7
PE
99 * buffer.c (OVERLAY_COUNT_MAX): New macro.
100 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
101 (Fnext_overlay_change, Fprevious_overlay_change)
102 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 103 Use ptrdiff_t, not int, for sizes.
21514da7 104 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 105
3de73e5e
PE
106 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
107
2606c57b
PE
108 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
109 (x_session_initialize): Do not assume string length fits in int.
110
aaafe47a
PE
111 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
112 This is unlikely, but can occur if DPI is outlandish.
113
2674ddc8 114 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
115 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
116
28154962
PE
117 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
118 * xrdb.c (magic_file_p, search_magic_path):
119 Omit last arg SUFFIX; it was always 0. All callers changed.
120 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
121
7de51af5
PE
122 * xfont.c (xfont_match): Avoid need for strlen.
123
25ed6cc3
PE
124 * xfns.c: Don't assume strlen fits in int.
125 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
126
4eab31dd
PE
127 * xdisp.c (message_log_check_duplicate): Return intmax_t,
128 not unsigned long, as we prefer signed integers. All callers changed.
129 Detect integer overflow in repeat count.
130 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 131 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 132
171e2a58
PE
133 * termcap.c: Don't assume sizes fit in int and never overflow.
134 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
135 (gobble_line): Check for size-calculation overflow.
136
ad39faca 137 * minibuf.c (Fread_buffer):
6e5bb2dc 138 * lread.c (intern, intern_c_string):
74ca2eb3
PE
139 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
140 Don't assume string length fits in int.
141
52c61c22 142 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
143 * gtkutil.c (style_changed_cb): Avoid need for strlen.
144
b5b8c9e5
PE
145 * font.c: Don't assume string length fits in int.
146 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
147 Use ptrdiff_t, not int.
ccd6111c
PE
148 (font_intern_prop): Don't assume string length fits in int.
149 Don't assume integer property fits in fixnum.
150 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 151
882f0d81 152 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 153 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
154 Reformulate so as not to need the command string.
155 Invoke gzip -cd rather than gunzip, as it's more portable.
156 (lock_info_type, lock_file_1, lock_file):
157 Don't assume pid_t and time_t fit in unsigned long.
158 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
159 (current_lock_owner): Prefer signed type for sizes.
160 Use memcpy, not strncpy, where memcpy is what is really wanted.
161 Don't assume (via atoi) that time_t and pid_t fit in int.
162 Check for time_t and/or pid_t out of range, e.g., via a network share.
163 Don't alloca where an auto var works fine.
164
93f4cf88
PE
165 * fileio.c: Fix some integer overflow issues.
166 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
167 Don't assume string length fits in int.
168 (directory_file_name): Don't assume string length fits in long.
169 (make_temp_name): Don't assume pid fits in int, or that its print
170 length is less than 20.
171
f3e92b69
PE
172 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
173
1bfdaf10
PE
174 * coding.c (make_subsidiaries): Don't assume string length fits in int.
175
35016e9a
PE
176 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
177
3d1e65a1
PE
178 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
179 We prefer signed integers, even for size calculations.
180
0b963a93
PE
181 * emacs.c: Don't assume string length fits in 'int'.
182 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
183 (main): Don't invoke strlen when not needed.
184
573f4b54
PE
185 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
186 (XD_DEBUG_MESSAGE): Don't waste a byte.
187
989f33ba
PE
188 * callproc.c (getenv_internal_1, getenv_internal)
189 (Fgetenv_internal):
965d34eb
PE
190 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
191
e4d29b33
PE
192 * lread.c (invalid_syntax): Omit length argument.
193 All uses changed. This doesn't fix a bug, but it simplifies the
194 code away from its former Hollerith-constant appearance, and it's
195 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 196 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 197
eb49b136
PE
198 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
199 This didn't break anything, but it didn't help either.
200 It's confusing to put a bogus integer in a place where the actual
201 value does not matter.
9f62aeb1 202 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 203 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 204
15375a22
PE
205 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
206 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
207 implementation.
b61cc01c
PE
208 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
209 We prefer signed types, and the value cannot exceed the EMACS_INT
210 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
211 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
212 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
213 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 214
53b2623d
PE
215 * indent.c (sane_tab_width): New function.
216 (current_column, scan_for_column, Findent_to, position_indentation)
217 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 218 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 219
51cab52b 220 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 221
f2ed8a70
PE
222 * lisp.h (lint_assume): New macro.
223 * composite.c (composition_gstring_put_cache):
224 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
225
abe80cc6
PE
226 * editfns.c, insdel.c:
227 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 228
b02c740e
PE
229 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
230
ebc96716
PE
231 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
232
b4e50fa0 233 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 234 Use much-faster test for byte-length change.
311d5d7c 235 Don't assume string byte-length fits in 'int'.
a4cf38e4 236 Check that character arg fits in 'int'.
85461888 237 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 238
c0c1ee9f
PE
239 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
240
a498d7f4
PE
241 * fns.c (concat): Catch string overflow earlier.
242 Do not rely on integer wraparound.
243
51cab52b
PE
244 * dispextern.h (struct it.overlay_strings_charpos)
245 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
246 * xdisp.c (forward_to_next_line_start)
247 (back_to_previous_visible_line_start)
248 (reseat_at_next_visible_line_start, next_element_from_buffer):
249 Don't arbitrarily truncate the value of 'selective' to int.
250
76031fad
PE
251 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
252
5eb55db9
PE
253 * composite.c: Don't truncate sizes to 'int'.
254 (composition_gstring_p, composition_reseat_it)
255 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
256 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
257 not EMACS_UINT, for indexes.
5eb55db9 258
0703a717
PE
259 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
260
d6202519
PE
261 * buffer.c: Include <verify.h>.
262 (struct sortvec.priority, struct sortstr.priority):
8961a454 263 Now EMACS_INT, not int.
c20998a7 264 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
265 (struct sortstr.size, record_overlay_string)
266 (struct sortstrlist.size, struct sortlist.used):
267 Don't truncate size to int.
268 (record_overlay_string): Check for size-calculation overflow.
d6202519 269 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 270
d5a19415
JM
2712011-06-22 Jim Meyering <meyering@redhat.com>
272
273 don't leak an XBM-image-sized buffer
274 * image.c (xbm_load): Free the image buffer after using it.
275
a9041e6c
PE
2762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
277
278 Port to Sun C.
279 * composite.c (find_automatic_composition): Omit needless 'return 0;'
280 that Sun C diagnosed.
281 * fns.c (secure_hash): Fix pointer signedness issue.
282 * intervals.c (static_offset_intervals): New function.
283 (offset_intervals): Use it.
284
7f3f739f
LL
2852011-06-21 Leo Liu <sdl.web@gmail.com>
286
287 * deps.mk (fns.o):
288 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
289 sha512.h.
290
291 * fns.c (secure_hash): Rename from crypto_hash_function and change
292 the first arg to accept symbols.
293 (Fsecure_hash): New primtive.
294 (syms_of_fns): New symbols.
295
76147d94
DD
2962011-06-20 Deniz Dogan <deniz@dogan.se>
297
298 * process.c (Fset_process_buffer): Clarify return value in
299 docstring.
300
7d7d0045
CY
3012011-06-18 Chong Yidong <cyd@stupidchicken.com>
302
303 * dispnew.c (add_window_display_history): Use BVAR.
304
305 * xdisp.c (debug_method_add): Use BVAR.
306 (check_window_end, dump_glyph_matrix, dump_glyph)
307 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
308
309 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
310 Likewise.
311
312 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
313 check till after the cache is created in init_frame_faces.
314
ff2bc410
SM
3152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
316
317 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
318
28177add
PE
3192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
320
dd3482fe
PE
321 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
322 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
323 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
324
393d71f3 325 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
326 * fileio.c (Finsert_file_contents):
327 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
328 Remove the old (too-loose) buffer overflow checks.
329 They weren't needed, since make_gap checks for buffer overflow.
330 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
331 The old code merely checked for Emacs fixnum overflow, and relied
332 on undefined (wraparound) behavior. The new code avoids undefined
333 behavior, and also checks for ptrdiff_t and/or size_t overflow.
334
2e6813b0 335 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
336 Tune. Don't use wider integers than needed. Don't use alloca.
337 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 338
599a9e4f
PE
339 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
340
99561444
PE
341 * insdel.c, lisp.h (buffer_overflow): New function.
342 (insert_from_buffer_1, replace_range, replace_range_2):
343 * insdel.c (make_gap_larger):
344 * editfns.c (Finsert_char):
345 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
346
28177add
PE
347 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
348
e69dafad
PE
3492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
350
a7af7fde 351 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 352
b1c46f02
PE
353 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
354 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
355
e69dafad
PE
356 * fileio.c: Don't assume EMACS_INT fits in off_t.
357 (emacs_lseek): New static function.
358 (Finsert_file_contents, Fwrite_region): Use it.
359 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
360
566684ea
PE
361 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
362
e6966cd6
PE
363 * fns.c: Don't overflow int when computing a list length.
364 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
365 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
366 truncation on 64-bit hosts. Check for QUIT every
367 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
368 faster and is responsive enough.
369 (Flength): Report an error instead of overflowing an integer.
370 (Fsafe_length): Return a float if the value is not representable
371 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 372 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 373 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 374
dd0b0efb
PE
375 * alloc.c: Check that resized vectors' lengths fit in fixnums.
376 (header_size, word_size): New constants.
377 (allocate_vectorlike): Don't check size overflow here.
378 (allocate_vector): Check it here instead, since this is the only
379 caller of allocate_vectorlike that could cause overflow.
380 Check that the new vector's length is representable as a fixnum.
381
86fe5cfe
PE
382 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
383 The previous code was bogus. For example, next_almost_prime (32)
384 returned 39, which is undesirable as it is a multiple of 3; and
385 next_almost_prime (24) returned 25, which is a multiple of 5 so
386 why was the code bothering to check for multiples of 7?
387
80e88859
PE
388 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
389
4a2f0ad6
PE
390 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
391
f66c7cf8
PE
392 Variadic C functions now count arguments with ptrdiff_t.
393 This partly undoes my 2011-03-30 change, which replaced int with size_t.
394 Back then I didn't know that the Emacs coding style prefers signed int.
395 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
396 were being counted with int, which may truncate counts on 64-bit
397 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
398 * lisp.h (struct Lisp_Subr.function.aMANY)
399 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
400 Arg counts are now ptrdiff_t, not size_t.
401 All variadic functions and their callers changed accordingly.
402 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
403 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
404 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
405 * callint.c (Fcall_interactively): Check arg count for overflow,
406 to avoid potential buffer overrun. Use signed char, not 'int',
407 for 'varies' array, so that we needn't bother to check its size
408 calculation for overflow.
409 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
410 * eval.c (apply_lambda):
411 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
412 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
413 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
414
a1759b76
PE
415 * callint.c (Fcall_interactively): Don't use index var as event count.
416
d96be9fc
PE
417 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
418 * mem-limits.h (SIZE): Remove; no longer used.
419
a690a978 420 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 421
578c21e6
PE
422 Remove unnecessary casts.
423 * xterm.c (x_term_init):
424 * xfns.c (x_set_border_pixel):
425 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
426 These aren't needed now that we assume ANSI C.
427
96f53c6c
PE
428 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
429 It's more likely to cause problems (due to unsigned overflow)
430 than to cure them.
431
83c77d31
PE
432 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
433
ee2079f1
PE
434 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
435
6da65536
PE
436 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
437
7147c4a4
PE
438 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
439
193e32d9
PE
440 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
441
e5533da6
PE
442 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
443
9910e595
PE
444 GLYPH_CODE_FACE returns EMACS_INT, not int.
445 * dispextern.h (merge_faces):
446 * xfaces.c (merge_faces):
01103c44
PE
447 * xdisp.c (get_next_display_element, next_element_from_display_vector):
448 Don't assume EMACS_INT fits in int.
9910e595 449
2638320e
PE
450 * character.h (CHAR_VALID_P): Remove unused parameter.
451 * fontset.c, lisp.h, xdisp.c: All uses changed.
452
045eb8d9
PE
453 * editfns.c (Ftranslate_region_internal): Omit redundant test.
454
c1f134b5
PE
455 * fns.c (concat): Minor tuning based on overflow analysis.
456 This doesn't fix any bugs. Use int to hold character, instead
457 of constantly refetching from Emacs object. Use XFASTINT, not
458 XINT, for value known to be a character. Don't bother comparing
459 a single byte to 0400, as it's always less.
460
395fcb93 461 * floatfns.c (Fexpt):
327eeec8
PE
462 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
463
abbd3d23
PE
464 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
465 for characters.
466
684a03ef
PE
467 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
468
0fed43f3
PE
469 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
470 Without this fix, on a 64-bit host (aset S 0 4294967386) would
471 incorrectly succeed when S was a string, because 4294967386 was
472 truncated before it was used.
473
8fd02eb7
PE
474 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
475 Otherwise, an out-of-range integer could cause undefined behavior
476 on a 64-bit host.
477
f8c86b69
PE
478 * composite.c: Use int, not EMACS_INT, for characters.
479 (fill_gstring_body, composition_compute_stop_pos): Use int, not
480 EMACS_INT, for values that are known to be in character range.
481 This doesn't fix any bugs but is the usual style inside Emacs and
482 may generate better code on 32-bit machines.
483
34206dd2
PE
484 Make sure a 64-bit char is never passed to ENCODE_CHAR.
485 This is for reasons similar to the recent CHAR_STRING fix.
486 * charset.c (Fencode_char): Check that character arg is actually
487 a character. Pass an int to ENCODE_CHAR.
488 * charset.h (ENCODE_CHAR): Verify that the character argument is no
489 wider than 'int', as a compile-time check to prevent future regressions
490 in this area.
491
c5958d4c 492 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
493
494 Make sure a 64-bit char is never passed to CHAR_STRING.
495 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
496 by silently ignoring the top 32 bits, allowing some values
497 that were far too large to be valid characters.
498 * character.h: Include <verify.h>.
499 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
500 arguments are no wider than unsigned, as a compile-time check
501 to prevent future regressions in this area.
502 * data.c (Faset):
01103c44 503 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
504 (Fsubst_char_in_region):
505 * fns.c (concat):
506 * xdisp.c (decode_mode_spec_coding):
507 Adjust to CHAR_STRING's new requirement.
508 * editfns.c (Finsert_char, Fsubst_char_in_region):
509 * fns.c (concat): Check that character args are actually
510 characters. Without this test, these functions did the wrong
511 thing with wildly out-of-range values on 64-bit hosts.
512
d37ca623
PE
513 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
514 These casts should not be needed on 32-bit hosts, either.
515 * keyboard.c (read_char):
516 * lread.c (Fload): Remove casts to unsigned.
517
ea204efb
PE
518 * lisp.h (UNSIGNED_CMP): New macro.
519 This fixes comparison bugs on 64-bit hosts.
520 (ASCII_CHAR_P): Use it.
521 * casefiddle.c (casify_object):
01103c44 522 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
523 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
524 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
525 * dispextern.h (FACE_FROM_ID):
526 * keyboard.c (read_char): Use UNSIGNED_CMP.
527
41cb286c
PE
528 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
529 not to EMACS_INT, to avoid GCC warning.
530
4a1b9832
PE
531 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
532
55daad71
PE
533 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
534 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
535 isn't needed on 32-bit machines.
8f95c75c 536
01103c44
PE
537 * buffer.c (Fgenerate_new_buffer_name):
538 Use EMACS_INT for count, not int.
0ceccced 539 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
540
541 * data.c (Qcompiled_function): Now static.
542
c6f072e7
PE
543 * window.c (window_body_lines): Now static.
544
20ce5912
PE
545 * image.c (gif_load): Rename local to avoid shadowing.
546
9c4c5f81
PE
547 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
548 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
549 * alloc.c (make_save_value): Integer argument is now of type
550 ptrdiff_t, not int.
551 (mark_object): Use ptrdiff_t, not int.
552 * lisp.h (pD): New macro.
553 * print.c (print_object): Use it.
554
c0c5c8ae
PE
555 * alloc.c: Use EMACS_INT, not int, to count objects.
556 (total_conses, total_markers, total_symbols, total_vector_size)
557 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
558 (total_free_floats, total_floats, total_free_intervals)
559 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
560 Now EMACS_INT, not int. All uses changed.
561 (Fgarbage_collect): Compute overall total using a double, so that
562 integer overflow is less likely to be a problem. Check for overflow
563 when converting back to an integer.
5a25e253
PE
564 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
565 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
566 These were 'int' variables that could overflow on 64-bit hosts;
567 they were never used, so remove them instead of repairing them.
211a0b2a 568 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
569 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
570 Previously, this ceilinged at INT_MAX, but that doesn't work on
571 64-bit machines.
e46bb31a 572 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 573
c78baabf 574 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 575 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
576 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
577 when a (possibly-narrower) signed value would do just as well.
578 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 579
c9d624c6
PE
580 * alloc.c: Catch some string size overflows that we were missing.
581 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
582 for convenience in STRING_BYTES_MAX.
583 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
584 The definition here is exact; the one in lisp.h was approximate.
585 (allocate_string_data): Check for string overflow. This catches
586 some instances we weren't catching before. Also, it catches
587 size_t overflow on (unusual) hosts where SIZE_MAX <= min
588 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
589 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 590
c9d624c6
PE
591 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
592 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
593 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
594
353032ce
PE
595 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
596
2bccce07
PE
597 * alloc.c (Fmake_string): Check for out-of-range init.
598
0ac30604
SM
5992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
600
601 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
602
c195f2de
JD
6032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
604
605 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
606 xg_get_default_scrollbar_width.
607
608 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
609 (int_gtk_range_get_value): Move to the scroll bar part of the file.
610 (style_changed_cb): Call update_theme_scrollbar_width and call
611 x_set_scroll_bar_default_width and xg_frame_set_char_size for
612 all frames (Bug#8505).
613 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
614 Call gtk_window_set_resizable if HAVE_GTK3.
615 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
616 and height if HAVE_GTK3 (Bug#8505).
617 (scroll_bar_width_for_theme): New variable.
618 (update_theme_scrollbar_width): New function.
619 (xg_get_default_scrollbar_width): Move code to
620 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
621 (xg_initialize): Call update_theme_scrollbar_width.
622
623 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
624
625 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
626
e10ac9f1
MR
6272011-06-12 Martin Rudalics <rudalics@gmx.at>
628
629 * frame.c (make_frame): Call other_buffer_safely instead of
630 other_buffer.
631
632 * window.c (temp_output_buffer_show): Call display_buffer with
633 second argument Vtemp_buffer_show_specifiers and reset latter
634 immediately after the call.
635 (Vtemp_buffer_show_specifiers): New variable.
636 (auto_window_vscroll_p, next_screen_context_lines)
637 (Vscroll_preserve_screen_position): Remove leading asterisks from
638 doc-strings.
639
2d3c217e 6402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 641
7b7f97e8 642 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
643 * buffer.c (Qclone_number): Remove for now, as it's unused.
644 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
645 (record_buffer): Remove unused local.
646 * frame.c (other_visible_frames, frame_buffer_list): Now static.
647 (set_frame_buffer_list): Remove; unused.
648 * frame.h (other_visible_frames): Remove decl.
649 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
650 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
651 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
652 if HAVE_GPM.
653 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
654 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
655 Define only if HAVE_GPM.
656 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
657 (update_hints_inhibit): Remove; never set. All uses removed.
658 * widgetprv.h (emacsFrameClassRec): Remove decl.
659 * window.c (delete_deletable_window): Now returns void, since it
660 wasn't returning anything.
661 (compare_window_configurations): Remove unused locals.
662 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
663 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
664 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
665 the same widths as pointers. This follows up on the 2011-05-06 patch.
666 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
667 * xterm.h: Likewise.
668 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
669
1384b89e
JB
6702011-06-12 Juanma Barranquero <lekktu@gmail.com>
671
672 * makefile.w32-in: Update dependencies.
673 (LISP_H): Add lib/intprops.h.
674
1100a63c
CY
6752011-06-11 Chong Yidong <cyd@stupidchicken.com>
676
677 * image.c (gif_load): Add animation frame delay to the metadata.
678 (syms_of_image): Use DEFSYM. New symbol `delay'.
679
6198ccd0
MR
6802011-06-11 Martin Rudalics <rudalics@gmx.at>
681
682 * window.c (delete_deletable_window): Re-add.
683 (Fset_window_configuration): Rewrite to handle dead buffers and
684 consequently deletable windows.
685 (window_tree, Fwindow_tree): Remove. Supply functionality in
686 window.el.
687 (compare_window_configurations): Simplify code.
688
b6e3633c
AS
6892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
690
1ab0dee5
AS
691 * image.c (imagemagick_load_image): Fix type mismatch.
692 (Fimagemagick_types): Likewise.
693
b6e3633c
AS
694 * window.h (replace_buffer_in_windows): Declare.
695
9397e56f
MR
6962011-06-11 Martin Rudalics <rudalics@gmx.at>
697
698 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
699 Qclone_number. Remove external declaration of Qdelete_window.
700 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
701 code.
702 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
703 Qbuffer_list_update_hook if allowed.
704 (Fother_buffer): Rewrite doc-string. Major rewrite for new
705 buffer list implementation.
706 (other_buffer_safely): New function.
707 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
708 calls to replace_buffer_in_windows and
709 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
710 if allowed.
711 (record_buffer): Inhibit quitting and rewrite using quittable
712 functions. Run Qbuffer_list_update_hook if allowed.
713 (Frecord_buffer, Funrecord_buffer): New functions.
714 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
715 switch-to-buffer to window.el.
716 (bury-buffer): Move to window.el.
717 (Vbuffer_list_update_hook): New variable.
718
719 * lisp.h (other_buffer_safely): Add prototype in buffer.c
720 section.
721
722 * window.h (resize_frame_windows): Move up in code.
723 (Fwindow_frame): Remove EXFUN.
724 (replace_buffer_in_all_windows): Remove prototype.
725 (replace_buffer_in_windows_safely): Add prototype.
726
727 * window.c: Declare Qdelete_window static again. Move down
728 declaration of select_count.
729 (Fnext_window, Fprevious_window): Rewrite doc-strings.
730 (Fother_window): Move to window.el.
731 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
732 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
733 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
734 window.el.
735 (replace_buffer_in_windows): Implement by calling
736 Qreplace_buffer_in_windows.
737 (replace_buffer_in_all_windows): Remove with some functionality
738 moved into replace_buffer_in_windows_safely.
739 (replace_buffer_in_windows_safely): New function.
740 (select_window_norecord, select_frame_norecord): Move in front
741 of run_window_configuration_change_hook. Remove now obsolete
742 declarations.
743 (Fset_window_buffer): Rewrite doc-string. Call
744 Qrecord_window_buffer.
745 (keys_of_window): Move binding for other-window to window.el.
746
b50691aa
CY
7472011-06-11 Chong Yidong <cyd@stupidchicken.com>
748
749 * dispextern.h (struct image): Replace data member, whose int_val
750 and ptr_val fields were not used by anything, with a single
751 lisp_val object.
752
753 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
754 (gif_clear_image, gif_load, imagemagick_load_image)
755 (gs_clear_image, gs_load): Callers changed.
756
3f754b86
PE
7572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
758
cca69397
PE
759 * buffer.h: Include <time.h>, for time_t.
760 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
761
109e28d0
PE
762 Fix minor problems found by static checking.
763
60737f02
PE
764 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
765
4b66faf3
PE
766 Make identifiers static if they are not used in other modules.
767 * data.c (Qcompiled_function, Qframe, Qvector):
768 * image.c (QimageMagick, Qsvg):
769 * minibuf.c (Qmetadata):
770 * window.c (resize_window_check, resize_root_window): Now static.
771 * window.h (resize_window_check, resize_root_window): Remove decls.
772
109e28d0
PE
773 * window.c (window_deletion_count, delete_deletable_window):
774 Remove; unused.
46a4ce9e
PE
775 (window_body_lines): Now static.
776 (Fdelete_other_windows_internal): Mark vars as initialized.
777 Make sure 'resize_failed' is initialized.
778 (run_window_configuration_change_hook): Rename local to avoid shadowing.
779 (resize_window_apply): Remove unused local.
780 * window.h (delete_deletable_window): Remove decl.
781
109e28d0 782 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
783 (imagemagick_load_image): Fix pointer signedness problem by changing
784 last arg from unsigned char * to char *. All uses changed.
785 Also, fix a local for similar reasons.
786 Remove unused locals. Remove locals to avoid shadowing.
787 (fn_rsvg_handle_free): Remove; unused.
788 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 789 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 790
3f754b86
PE
791 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
792
2547adb1
CY
7932011-06-10 Chong Yidong <cyd@stupidchicken.com>
794
795 * image.c (gif_load): Fix omitted cast error introduced by
796 2011-06-06 change.
797
2c8e37d4
MR
7982011-06-10 Martin Rudalics <rudalics@gmx.at>
799
800 * window.h (resize_proportionally, orig_total_lines)
801 (orig_top_line): Remove from window structure.
802 (set_window_height, set_window_width, change_window_heights)
803 (Fdelete_window): Remove prototypes.
804 (resize_frame_windows): Remove duplicate declaration.
805
440a42e3
EZ
8062011-06-10 Eli Zaretskii <eliz@gnu.org>
807
808 * window.h (resize_frame_windows, resize_window_check)
809 (delete_deletable_window, resize_root_window)
810 (resize_frame_windows): Declare prototypes.
811
812 * window.c (resize_window_apply): Make definition be "static" to
813 match the prototype.
814
562dd5e9
MR
8152011-06-10 Martin Rudalics <rudalics@gmx.at>
816
817 * window.c: Remove declarations of Qwindow_size_fixed,
818 window_min_size_1, window_min_size_2, window_min_size,
819 size_window, window_fixed_size_p, enlarge_window, delete_window.
820 Remove static from declaration of Qdelete_window, it's
821 temporarily needed by Fbury_buffer.
822 (replace_window): Don't assign orig_top_line and
823 orig_total_lines.
824 (Fdelete_window, delete_window): Remove. Window deletion is
825 handled by window.el.
826 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
827 Fdelete_window calls with calls to Qdelete_window.
828 (Fdelete_other_windows): Remove. Deleting other windows is
829 handled by window.el.
830 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
831 handled in window.el.
832 (window_min_size_2, window_min_size_1, window_min_size): Remove.
833 Window minimum sizes are handled in window.el.
834 (shrink_windows, size_window, set_window_height)
835 (set_window_width, change_window_heights, window_height)
836 (window_width, CURBEG, CURSIZE, enlarge_window)
837 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
838 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
839 handled in window.el.
840 (make_dummy_parent): Rename to make_parent_window and give it a
841 second argument horflag.
842 (make_window): Don't set resize_proportionally any more.
843 (Fsplit_window): Remove. Windows are split in window.el.
844 (save_restore_action, save_restore_orig_size)
845 (shrink_window_lowest_first, save_restore_orig_size): Remove.
846 Resize mini windows in window.el.
847 (grow_mini_window, shrink_mini_window): Implement by calling
848 Qresize_root_window_vertically, resize_window_check and
849 resize_window_apply.
850 (saved_window, Fset_window_configuration, save_window_save): Do
851 not handle orig_top_line, orig_total_lines, and
852 resize_proportionally.
853 (window_min_height, window_min_width): Move to window.el.
854 (keys_of_window): Move bindings for delete-other-windows,
855 split-window, delete-window and enlarge-window to window.el.
856
857 * buffer.c: Temporarily extern Qdelete_window.
858 (Fbury_buffer): Temporarily call Qdelete_window instead of
859 Fdelete_window (Fbury_buffer will move to window.el soon).
860
861 * frame.c (set_menu_bar_lines_1): Remove code handling
862 orig_top_line and orig_total_lines.
863
864 * dispnew.c (adjust_frame_glyphs_initially): Don't use
865 set_window_height but set heights directly.
866 (change_frame_size_1): Use resize_frame_windows.
867
868 * xdisp.c (init_xdisp): Don't use set_window_height but set
869 heights directly.
870
871 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
872 resize_frame_windows instead of change_window_heights and run
873 run_window_configuration_change_hook.
874
875 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
876 instead of change_window_heights and run
877 run_window_configuration_change_hook.
878
1a13852e
MR
8792011-06-09 Martin Rudalics <rudalics@gmx.at>
880
881 * window.c (replace_window): Rename second argument REPLACEMENT to
882 NEW. New third argument SETFLAG. Rewrite.
883 (delete_window, make_dummy_parent): Call replace_window with
884 third argument 1.
885 (window_list_1): Move down in code.
886 (run_window_configuration_change_hook): Move set_buffer part
887 before select_frame_norecord part in order to unwind correctly.
888 Rename count1 to count.
889 (recombine_windows, delete_deletable_window, resize_root_window)
890 (Fdelete_other_windows_internal)
891 (Frun_window_configuration_change_hook, make_parent_window)
892 (resize_window_check, resize_window_apply, Fresize_window_apply)
893 (resize_frame_windows, Fsplit_window_internal)
894 (Fdelete_window_internal, Fresize_mini_window_internal): New
895 functions.
896 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
897
f3d1777e
MR
8982011-06-08 Martin Rudalics <rudalics@gmx.at>
899
496e208e
MR
900 * window.h (window): Add some new members to window structure -
901 normal_lines, normal_cols, new_total, new_normal, clone_number,
902 splits, nest, prev_buffers, next_buffers.
903 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 904 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 905
f3d1777e
MR
906 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
907 Remove.
496e208e
MR
908 (make_dummy_parent): Set new members of windows structure.
909 (make_window): Move down in code. Handle new members of window
910 structure.
911 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
912 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
913 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
914 (Fset_window_prev_buffers, Fwindow_next_buffers)
915 (Fset_window_next_buffers, Fset_window_clone_number): New
916 functions.
917 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
918 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
919 Doc-string fixes.
920 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
921 Argument WINDOW can be now internal window too.
922 (Fwindow_use_time): Move up in code.
923 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
924 Rewrite doc-string.
925 (Fset_window_configuration, saved_window)
926 (Fcurrent_window_configuration, save_window_save): Handle new
927 members of window structure.
b9e809c2
MR
928 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
929 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
930 (syms_of_window): New Lisp objects Qrecord_window_buffer,
931 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
932 Qget_mru_window, Qresize_root_window,
933 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
934 Qauto_buffer_name; staticpro them.
f3d1777e 935
abde8f8c
MR
9362011-06-07 Martin Rudalics <rudalics@gmx.at>
937
938 * window.c (Fwindow_total_size, Fwindow_left_column)
939 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
940 (Fwindow_list_1): New functions.
941 (window_box_text_cols): Replace with window_body_cols.
942 (Fwindow_width, Fscroll_left, Fscroll_right): Use
943 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
944 (delete_window, Fset_window_configuration): Call
945 delete_all_subwindows with window as argument.
946 (delete_all_subwindows): Take a window as argument and not a
947 structure. Rewrite.
190b47e6
MR
948 (window_loop): Remove handling of GET_LRU_WINDOW and
949 GET_LARGEST_WINDOW.
950 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
951
952 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
953 window_box_text_cols. delete_all_subwindows now takes a
954 Lisp_Object as argument.
abde8f8c
MR
955
956 * indent.c (compute_motion, Fcompute_motion): Use
957 window_body_cols instead of window_box_text_cols.
958
fa8a67e6
MR
959 * frame.c (delete_frame): Call delete_all_subwindows with root
960 window as argument.
961
a54e3482
DC
9622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
963
964 * fns.c (Fputhash): Document return value.
965
60002bf5
CY
9662011-06-06 Chong Yidong <cyd@stupidchicken.com>
967
968 * image.c (gif_load): Implement gif89a spec "no disposal" method.
969
0c671da6 9702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 971
b862a52a 972 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 973
be44ca6c
PE
974 Check for overflow when converting integer to cons and back.
975 * charset.c (Fdefine_charset_internal, Fdecode_char):
976 Use cons_to_unsigned to catch overflow.
977 (Fencode_char): Use INTEGER_TO_CONS.
978 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
979 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
980 * data.c (long_to_cons, cons_to_long): Remove.
981 (cons_to_unsigned, cons_to_signed): New functions.
982 These signal an error for invalid or out-of-range values.
983 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
984 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
985 * font.c (Ffont_variation_glyphs):
986 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
987 * lisp.h: Include <intprops.h>.
988 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
989 (cons_to_signed, cons_to_unsigned): New decls.
990 (long_to_cons, cons_to_long): Remove decls.
991 * undo.c (record_first_change): Use INTEGER_TO_CONS.
992 (Fprimitive_undo): Use CONS_TO_INTEGER.
993 * xfns.c (Fx_window_property): Likewise.
994 * xselect.c: Include <limits.h>.
995 (x_own_selection, selection_data_to_lisp_data):
996 Use INTEGER_TO_CONS.
997 (x_handle_selection_request, x_handle_selection_clear)
998 (x_get_foreign_selection, Fx_disown_selection_internal)
999 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1000 (lisp_data_to_selection_data): Use cons_to_unsigned.
1001 (x_fill_property_data): Use cons_to_signed.
1002 Report values out of range.
1003
d1f3d2af
PE
1004 Check for buffer and string overflow more precisely.
1005 * buffer.h (BUF_BYTES_MAX): New macro.
1006 * lisp.h (STRING_BYTES_MAX): New macro.
1007 * alloc.c (Fmake_string):
1008 * character.c (string_escape_byte8):
1009 * coding.c (coding_alloc_by_realloc):
1010 * doprnt.c (doprnt):
1011 * editfns.c (Fformat):
1012 * eval.c (verror):
1013 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1014 since they may not be the same number.
1015 * editfns.c (Finsert_char):
1016 * fileio.c (Finsert_file_contents):
1017 Likewise for BUF_BYTES_MAX.
1018
dd52fcea
PE
1019 * image.c: Use ptrdiff_t, not int, for sizes.
1020 (slurp_file): Switch from int to ptrdiff_t.
1021 All uses changed.
1022 (slurp_file): Check that file size fits in both size_t (for
1023 malloc) and ptrdiff_t (for sanity and safety).
1024
7f9bbdbb
PE
1025 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1026 if b->modtime has its maximal value.
1027
dfe18f82
PE
1028 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1029
84acfcf0
PE
1030 Don't assume time_t can fit into int.
1031 * buffer.h (struct buffer.modtime): Now time_t, not int.
1032 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1033 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1034
ccd9a01a
PE
1035 Minor fixes for signed vs unsigned integers.
1036 * character.h (MAYBE_UNIFY_CHAR):
1037 * charset.c (maybe_unify_char):
1038 * keyboard.c (read_char, reorder_modifiers):
1039 XINT -> XFASTINT, since the integer must be nonnegative.
1040 * ftfont.c (ftfont_spec_pattern):
1041 * keymap.c (access_keymap, silly_event_symbol_error):
1042 XUINT -> XFASTINT, since the integer must be nonnegative.
1043 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1044 since it makes no difference and we prefer signed.
1045 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1046 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1047 nonnegative.
1048
d6d100dd
SM
10492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1050
1051 * window.h (Fwindow_frame): Declare.
1052
2b6148e4
PE
10532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1056 (SPARE_MEMORY): Always define.
1057 (LARGE_REQUEST): Remove.
1058 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1059
f230ecc9
MR
10602011-06-06 Martin Rudalics <rudalics@gmx.at>
1061
727e958e
MR
1062 * lisp.h: Move EXFUNS for Fframe_root_window,
1063 Fframe_first_window and Fset_frame_selected_window to window.h.
1064
1065 * window.h: Move EXFUNS for Fframe_root_window,
1066 Fframe_first_window and Fset_frame_selected_window here from
1067 lisp.h.
1068
1069 * frame.c (Fwindow_frame, Fframe_first_window)
1070 (Fframe_root_window, Fframe_selected_window)
1071 (Fset_frame_selected_window): Move to window.c.
1072 (Factive_minibuffer_window): Move to minibuf.c.
1073 (Fother_visible_frames_p): New function.
1074
1075 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1076
f230ecc9
MR
1077 * window.c (decode_window, decode_any_window): Move up in code.
1078 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1079 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1080 (Fwindow_buffer): Move up and rewrite doc-string.
1081 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1082 (Fwindow_prev): New functions.
727e958e
MR
1083 (Fwindow_frame): Move here from frame.c. Accept any window as
1084 argument.
1085 (Fframe_root_window, Fframe_first_window)
1086 (Fframe_selected_window): Move here from frame.c. Accept frame
1087 or arbitrary window as argument. Update doc-strings.
1088 (Fminibuffer_window): Move up in code.
1089 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1090 (Fset_frame_selected_window): Move here from frame.c.
1091 Marginal rewrite.
727e958e
MR
1092 (Fselected_window, select_window, Fselect_window): Move up in
1093 code. Minor doc-string fixes.
f230ecc9 1094
4d09bcf6
PE
10952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1098 Do not assume that spare memory exists; that assumption is valid
1099 only if SYSTEM_MALLOC.
1100 (LARGE_REQUEST): New macro, so that the issue of large requests
1101 is separated from the issue of spare memory.
1102
810928a2
AS
11032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1104
172418ad
AS
1105 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1106 format. (Bug#8806)
1107
43f862f7
AS
1108 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1109
810928a2
AS
1110 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1111 before statements.
1112
a059fe24
JD
11132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1114
1115 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1116
1117 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1118
1119 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1120 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1121
989bf368
JB
11222011-06-05 Juanma Barranquero <lekktu@gmail.com>
1123
1124 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1125
4b80f674
CY
11262011-06-04 Chong Yidong <cyd@stupidchicken.com>
1127
1128 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1129 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1130 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1131 New error handlers.
4b80f674
CY
1132 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1133 Obey Vx_select_enable_clipboard_manager. Catch errors in
1134 x_clipboard_manager_save (Bug#8779).
1135 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1136 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1137
99a33b77 11382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1139
1140 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1141
99a33b77 11422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1143
1144 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1145 in the current matrix if keep_current_p is non-zero.
1146
8264569d
EZ
11472011-06-04 Eli Zaretskii <eliz@gnu.org>
1148
1149 * bidi.c (bidi_level_of_next_char): Fix last change.
1150
57f97249
EZ
11512011-06-03 Eli Zaretskii <eliz@gnu.org>
1152
fec2107c 1153 Support bidi reordering of text covered by display properties.
57f97249 1154
fec2107c
EZ
1155 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1156 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1157 (bidi_cache_search, bidi_cache_iterator_state)
1158 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1159 (bidi_level_of_next_char, bidi_move_to_visually_next):
1160 Support character positions inside a run of characters covered by a
fec2107c
EZ
1161 display string.
1162 (bidi_paragraph_init, bidi_resolve_explicit_1)
1163 (bidi_level_of_next_char): Call bidi_fetch_char and
1164 bidi_fetch_char_advance instead of FETCH_CHAR and
1165 FETCH_CHAR_ADVANCE.
1166 (bidi_init_it): Initialize new members.
1167 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1168 definitions.
1169 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1170 instead of using explicit *_CHAR codes.
d6d100dd
SM
1171 (bidi_resolve_explicit, bidi_resolve_weak):
1172 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1173 bidirectional text is supported only in multibyte buffers.
1174 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1175 it to initialize the frame_window_p member of struct bidi_it.
1176 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1177 (bidi_resolve_explicit, bidi_resolve_weak)
1178 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1179 bidi_it->nchars is non-positive.
1180 (bidi_level_of_next_char): Don't try to lookup the cache for the
1181 next/previous character if nothing is cached there yet, or if we
1182 were just reseat()'ed to a new position.
c40e2fb2 1183
0e14fe90
EZ
1184 * xdisp.c (set_cursor_from_row): Set start and stop points
1185 according to the row's direction when priming the loop that looks
1186 for the glyph on which to display cursor.
1187 (single_display_spec_intangible_p): Function deleted.
1188 (display_prop_intangible_p): Reimplement to call
1189 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1190 Accept 3 additional arguments needed by handle_display_spec.
1191 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1192 values: lists, `(when COND...)' forms, etc.
1193 (single_display_spec_string_p): Support property values that are
1194 lists with the argument STRING its top-level element.
1195 (display_prop_string_p): Fix the condition for processing a
1196 property that is a list to be consistent with handle_display_spec.
fec2107c 1197 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1198 last portion of handle_display_prop.
1199 (compute_display_string_pos): Accept additional argument
1200 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1201 value of a `display' property is a "replacing spec".
1202 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1203 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1204 the display property, but just return a value indicating whether
1205 the display property will replace the characters it covers.
1206 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1207 frame_window_p members of struct bidi_it.
d6d100dd
SM
1208 (compute_display_string_pos, compute_display_string_end):
1209 New functions.
fec2107c
EZ
1210 (push_it): Accept second argument POSITION, where pop_it should
1211 jump to continue iteration.
1212 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1213
fec2107c
EZ
1214 * keyboard.c (adjust_point_for_property): Adjust the call to
1215 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1216
1217 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1218 (bidi_init_it): Update prototypes.
1219 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1220 (compute_display_string_pos, compute_display_string_end):
1221 Declare prototypes.
fec2107c
EZ
1222 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1223 EMACS_INT.
fc6f18ce 1224
40087514 12252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1226
57f53182
PE
1227 Malloc failure behavior now depends on size of allocation.
1228 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1229 * lisp.h: Change signatures accordingly.
1230 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1231 All callers changed. (Bug#8762)
1232
1233 * gnutls.c: Use Emacs's memory allocators.
1234 Without this change, the gnutls library would invoke malloc etc.
1235 directly, which causes problems on non-SYNC_INPUT hosts, and which
1236 runs afoul of improving memory_full behavior. (Bug#8761)
1237 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1238 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1239 xfree instead of the default malloc, realloc, free.
1240 (Fgnutls_boot): No need to check for memory allocation failure,
1241 since xmalloc does that for us.
1242
ac32cd99 1243 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1244 * category.c (hash_get_category_set):
1245 * ccl.c (ccl_driver):
1246 * charset.c (Fdefine_charset_internal):
1247 * charset.h (struct charset.hash_index):
1248 * composite.c (get_composition_id, gstring_lookup_cache)
1249 (composition_gstring_put_cache):
1250 * composite.h (struct composition.hash_index):
1251 * dispextern.h (struct image.hash):
1252 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1253 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1254 (hashfn_equal, hashfn_user_defined, make_hash_table)
1255 (maybe_resize_hash_table, hash_lookup, hash_put)
1256 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1257 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1258 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1259 * image.c (make_image, search_image_cache, lookup_image)
1260 (xpm_put_color_table_h):
1261 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1262 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1263 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1264 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1265 * alloc.c (allocate_vectorlike):
1266 Check for overflow in vector size calculations.
1267 * ccl.c (ccl_driver):
1268 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1269 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1270 need to be updated by these changes.
40087514
PE
1271 * fns.c (make_hash_table, maybe_resize_hash_table):
1272 Check for integer overflow with large hash tables.
0de4bb68
PE
1273 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1274 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1275 (SXHASH_REDUCE): New macro.
1276 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1277 Use it instead of discarding useful hash info with large hash values.
1278 (sxhash_float): New function.
1279 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1280 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1281 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1282 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1283 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1284 Adjust signatures to match updated version of code.
1285 (consing_since_gc): Now EMACS_INT, since a single hash table can
1286 use more than INT_MAX bytes.
1287
698d32e2
DN
12882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1289
1290 Make it possible to build with GCC-4.6+ -O2 -flto.
1291
1292 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1293
fd6fa53f
SM
12942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1295
1296 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1297 Call minibuffer-inactive-mode.
1298
864db017
JB
12992011-05-31 Juanma Barranquero <lekktu@gmail.com>
1300
1301 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1302 Update dependencies.
1303
2ad0baf4
DN
13042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1305
1306 * data.c (init_data): Remove code for UTS, this system is not
1307 supported anymore.
1308
4fcc2638
DN
13092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1310
1311 Don't force ./temacs to start in terminal mode.
1312
1313 * frame.c (make_initial_frame): Initialize faces in all cases, not
1314 only when CANNOT_DUMP is defined.
1315 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1316
c56e0fd5
DN
13172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1318
1319 * dispnew.c (add_window_display_history): Use const for the string
1320 pointer. Remove declaration, not needed.
1321
333d54da 13222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1323
55d4c1b2 1324 Use 'inline', not 'INLINE'.
333d54da 1325 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1326 * alloc.c, fontset.c (INLINE): Remove.
1327 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1328 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1329 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1330 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1331 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1332
738db178
DN
13332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1334
1335 Make it possible to run ./temacs.
1336
1337 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1338 syms_of_callproc does the same thing. Remove test for
1339 "initialized", do it in the caller.
1340 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1341
620c53a6
SM
13422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1343
1344 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1345 (read_minibuf): Use get_minibuffer.
1346 (syms_of_minibuf): Use DEFSYM.
1347 (Qmetadata): New var.
1348 * data.c (Qbuffer): Don't make it static.
1349 (syms_of_data): Use DEFSYM.
1350
e003a292
PE
13512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1352
1353 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1354 (CCL_CODE_MIN): New macro.
1355
ed008a6d
PE
13562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1357
3687c2ef
PE
1358 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1359
ed008a6d
PE
1360 * eval.c (Qdebug): Now static.
1361 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1362 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1363 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1364
d66c4c7c
CY
13652011-05-29 Chong Yidong <cyd@stupidchicken.com>
1366
1367 * image.c: Various fixes to ImageMagick code comments.
1368 (Fimagemagick_types): Doc fix.
1369
5fbc2025
PE
13702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1371
0196f88a
PE
1372 Minor fixes prompted by GCC 4.6.0 warnings.
1373
1374 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1375
5fbc2025
PE
1376 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1377 (x_clipboard_manager_save_all): Move extern decl to ...
1378 * xterm.h: ... here, so that it can be checked for consistency.
1379
1dd3c2d9
CY
13802011-05-29 Chong Yidong <cyd@stupidchicken.com>
1381
1382 * xselect.c (x_clipboard_manager_save_frame)
1383 (x_clipboard_manager_save_all): New functions.
1384 (Fx_clipboard_manager_save): Lisp function deleted.
1385
1386 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1387 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1388
1389 * xterm.h: Update prototype.
1390
5ba6571d
WX
13912011-05-28 William Xu <william.xwl@gmail.com>
1392
1393 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1394 exiting (Bug#8239).
1395
3eaff834
JM
13962011-05-28 Jim Meyering <meyering@redhat.com>
1397
e1900994 1398 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1399 * fns.c (to_uchar): Define.
1400 (crypto_hash_function): Use it to convert some newly-signed
1401 variables to unsigned, to avoid sign-extension bugs. For example,
1402 without this change, (md5 "truc") would evaluate to
1403 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1404 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1405 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1406
0f6990a7
PE
14072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1408
1409 Integer overflow fixes.
c8a9ca5a 1410
08686060
PE
1411 * dbusbind.c: Serial number integer overflow fixes.
1412 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1413 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1414 to hold a serial number that is too large for a fixnum.
1415 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1416 Check for serial numbers out of range. Decode any serial number
59568bf0 1417 that was so large that it became a float. (Bug#8722)
08686060 1418
2d1fc3c7
PE
1419 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1420 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1421 Use XFASTINT rather than XUINT when numbers are nonnegative.
1422 (xd_append_arg, Fdbus_method_return_internal):
1423 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1424 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1425 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1426 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1427 (Bug#8722)
2d1fc3c7 1428
c8a9ca5a
PE
1429 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1430
519e1d69
PE
1431 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1432
30569699
PE
1433 ccl: add integer overflow checks
1434 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1435 (IN_INT_RANGE): New macros.
1436 (ccl_driver): Use them to check for integer overflow when
1437 decoding a CCL program. Many of the new checks are whether XINT (x)
1438 fits in int; it doesn't always, on 64-bit hosts. The new version
1439 doesn't catch all possible integer overflows, but it's an
847044ea 1440 improvement. (Bug#8719)
30569699 1441
c11285dc
PE
1442 * alloc.c (make_event_array): Use XINT, not XUINT.
1443 There's no need for unsigned here.
1444
fdccd48e
PE
1445 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1446 This follows up to the 2011-05-06 change that substituted uintptr_t
1447 for EMACS_INT. This case wasn't caught back then.
1448
37910ab2
PE
1449 Rework Fformat to avoid integer overflow issues.
1450 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1451 now (part of C89). Include <verify.h>.
1452 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1453 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1454 (Fformat): Avoid the prepass trying to compute sizes; it was only
1455 approximate and thus did not catch overflow reliably. Instead, walk
1456 through the format just once, formatting and computing sizes as we go,
1457 checking for integer overflow at every step, and allocating a larger
1458 buffer as needed. Keep track separately whether the format is
1459 multibyte. Keep only the most-recently calculated precision, rather
1460 than them all. Record whether each argument has been converted to
1461 string. Use EMACS_INT, not int, for byte and char and arg counts.
1462 Support field widths and precisions larger than INT_MAX. Avoid
1463 sprintf's undefined behavior with conversion specifications such as %#d
1464 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1465 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1466 formatting out-of-range floating point numbers with int
1467 formats. (Bug#8668)
1468
2e6578fb
PE
1469 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1470
0ae6bdee
PE
1471 * data.c: Avoid integer truncation in expressions involving floats.
1472 * data.c: Include <intprops.h>.
1473 (arith_driver): When there's an integer overflow in an expression
1474 involving floating point, convert the integers to floating point
1475 so that the resulting value does not suffer from catastrophic
1476 integer truncation. For example, on a 64-bit host (* 4
1477 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1478 Do not rely on undefined behavior after integer overflow.
1479
de883a70
PE
1480 merge count_size_as_multibyte, parse_str_to_multibyte
1481 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1482 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1483 Check for integer overflow.
1484 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1485 since it's now a duplicate of the other. This is more of
1486 a character than a buffer op, so better that it's in character.c.
1487 * fns.c, print.c: Adjust to above changes.
1488
2ff916cb
PE
14892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1490
1491 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1492
f1b54466
PE
14932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1494
fb1ac845
PE
1495 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1496 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1497 (x_clipboard_manager_save): Now static.
1498 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1499
f1b54466
PE
1500 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1501 (crypto_hash_function): Now static.
1502 Fix pointer signedness problems. Avoid unnecessary initializations.
1503
a9f737ee
CY
15042011-05-27 Chong Yidong <cyd@stupidchicken.com>
1505
1506 * termhooks.h (Vselection_alist): Make it terminal-local.
1507
1508 * terminal.c (create_terminal): Initialize it.
1509
1510 * xselect.c: Support for clipboard managers.
1511 (Vselection_alist): Move to termhooks.h as terminal-local var.
1512 (LOCAL_SELECTION): New macro.
1513 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1514 (symbol_to_x_atom): Remove gratuitous arg.
1515 (x_handle_selection_request, lisp_data_to_selection_data)
1516 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1517 (x_own_selection, x_get_local_selection, x_convert_selection):
1518 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1519 (some_frame_on_display): Delete unused function.
1520 (Fx_own_selection_internal, Fx_get_selection_internal)
1521 (Fx_disown_selection_internal, Fx_selection_owner_p)
1522 (Fx_selection_exists_p): New optional frame arg.
1523 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1524 (x_handle_selection_clear): Don't treat other terminals with the
1525 same keyboard specially. Use the terminal-local Vselection_alist.
1526 (x_clear_frame_selections): Use Frun_hook_with_args.
1527
1528 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1529
1530 * xterm.h: Add support for those atoms.
1531
e067f0c1
CY
15322011-05-26 Chong Yidong <cyd@stupidchicken.com>
1533
1534 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1535 (converted_selections, conversion_fail_tag): New global variables.
1536 (x_selection_request_lisp_error): Free the above.
1537 (x_get_local_selection): Remove unnecessary code.
1538 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1539 of converted selections stored in converted_selections.
1540 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1541 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1542 (x_convert_selection): New function.
1543 (x_handle_selection_event): Simplify.
1544 (x_get_foreign_selection): Don't ignore incoming requests while
1545 waiting for an answer; this will fail when we implement
1546 SAVE_TARGETS, and seems unnecessary anyway.
1547 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1548 (Vx_sent_selection_functions): Doc fix.
1549
0f4aebc0
LL
15502011-05-26 Leo Liu <sdl.web@gmail.com>
1551
1552 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1553
e61124cd
YM
15542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1555
1556 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1557
1558 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1559 for fringe update if it has periodic bitmap.
1560 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1561 and fringe_bitmap_periodic_p.
1562
1563 * fringe.c (get_fringe_bitmap_data): New function.
1564 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1565 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1566 row. Mark glyph row for fringe update if periodicity changed.
1567
1568 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1569 for fringe update unless it has periodic bitmap.
1570
f16d9837
KH
15712011-05-25 Kenichi Handa <handa@m17n.org>
1572
1573 * xdisp.c (get_next_display_element): Set correct it->face_id for
1574 a static composition.
1575
e1b90ef6
LL
15762011-05-24 Leo Liu <sdl.web@gmail.com>
1577
1578 * deps.mk (fns.o):
1579 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1580
1581 * fns.c (crypto_hash_function, Fsha1): New function.
1582 (Fmd5): Use crypto_hash_function.
1583 (syms_of_fns): Add Ssha1.
1584
7400048f
PE
15852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 * gnutls.c: Remove unused macros.
1588 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1589 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1590 Remove macros that are defined and never used.
1591 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1592
abb71cf4
CY
15932011-05-22 Chong Yidong <cyd@stupidchicken.com>
1594
1595 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1596 (Fx_get_selection_internal): Minor cleanup.
1597 (Fx_own_selection_internal): Rename arguments for consistency with
1598 select.el.
1599
6307db39
PE
16002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1603
f3d4e0a4
CY
16042011-05-22 Chong Yidong <cyd@stupidchicken.com>
1605
1606 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1607
4d8ade89
YM
16082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1609
1610 * dispnew.c (scrolling_window): Don't exclude the case that the
1611 last enabled row in the desired matrix touches the bottom boundary.
1612
32078c8d
GM
16132011-05-21 Glenn Morris <rgm@gnu.org>
1614
1615 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1616 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1617 and add some more files.
32078c8d 1618
7285dc67
EZ
16192011-05-20 Eli Zaretskii <eliz@gnu.org>
1620
1621 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1622 report_file_error introduced by the change from 2011-05-07.
1623
89d1bd22
PE
16242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 * systime.h (Time): Define only if emacs is defined.
1627 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1628 where the include path doesn't have X11/X.h by default. See
1629 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1630
e23640bb 16312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1632
1633 * composite.c (find_automatic_composition): Fix previous change.
1634
b9704ad9
GM
16352011-05-20 Glenn Morris <rgm@gnu.org>
1636
1637 * lisp.mk: New file, split from Makefile.in.
1638 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1639 (shortlisp): Remove.
1640 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1641
4a720484
GM
16422011-05-19 Glenn Morris <rgm@gnu.org>
1643
1644 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1645 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1646 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1647 (lisp): Set the order to that of loadup.el.
1648 (shortlisp): Make it a copy of $lisp.
1649 (SOME_MACHINE_LISP): Remove.
1650 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1651 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1652
a28d4396
KH
16532011-05-18 Kenichi Handa <handa@m17n.org>
1654
1655 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1656 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1657 (find_automatic_composition): Mostly rewrite for efficiency.
1658
a2b1fa8e
JB
16592011-05-18 Juanma Barranquero <lekktu@gmail.com>
1660
1661 * makefile.w32-in: Update dependencies.
1662
8e1f5610
CS
16632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1664
1665 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1666 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1667
7025ee00 16682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1669
cdfa6eab
PE
1670 Fix some integer overflow issues, such as string length overflow.
1671
06d6db33
PE
1672 * insdel.c (count_size_as_multibyte): Check for string overflow.
1673
2b4560a8
PE
1674 * character.c (lisp_string_width): Check for string overflow.
1675 Use EMACS_INT, not int, for string indexes and lengths; in
1676 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1677 the resulting string length overflows an EMACS_INT; instead,
1678 report a string overflow if no precision given. When checking for
1679 precision exhaustion, use a check that cannot possibly have
1680 integer overflow. (Bug#8675)
1681 * character.h (lisp_string_width): Adjust to new signature.
1682
cb93f9be
PE
1683 * alloc.c (string_overflow): New function.
1684 (Fmake_string): Use it. This doesn't change behavior, but saves
1685 a few bytes and will simplify future changes.
1686 * character.c (string_escape_byte8): Likewise.
1687 * lisp.h (string_overflow): New decl.
1688
1a1f3366
PE
1689 Fixups, following up to the user-interface timestamp change.
1690 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1691 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1692 * msdos.c (mouse_get_pos): Likewise.
1693 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1694 * w32gui.h (Time): Define by including "systime.h" rather than by
1695 declaring it ourselves. (Bug#8664)
1696
d4e3e4d3
PE
1697 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1698 * image.c (clear_image_cache): Likewise.
1699
f6a24d19
PE
1700 * term.c (term_mouse_position): Don't assume time_t wraparound.
1701
08dc5ae6
PE
1702 Be more systematic about user-interface timestamps.
1703 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1704 and sometimes 'EMACS_UINT', to represent these timestamps.
1705 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1706 This makes the code easier to follow, and makes it easier to catch
1707 integer overflow bugs such as Bug#8664.
1708 * frame.c (Fmouse_position, Fmouse_pixel_position):
1709 Use Time, not unsigned long, for user-interface timestamps.
1710 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1711 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1712 * keyboard.h (last_event_timestamp): Likewise.
1713 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1714 * menu.h (xmenu_show): Likewise.
1715 * term.c (term_mouse_position): Likewise.
1716 * termhooks.h (struct input_event.timestamp): Likewise.
1717 (struct terminal.mouse_position_hook): Likewise.
1718 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1719 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1720 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1721 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1722 what it was before.
1723 * menu.h, termhooks.h: Include "systime.h", for Time.
1724
8e55734a
PE
1725 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1726 Don't assume that the difference between two unsigned long values
1727 can fit into an integer. At this point, we know button_down_time
1728 <= event->timestamp, so the difference must be nonnegative, so
1729 there's no need to cast the result if double-click-time is
1730 nonnegative, as it should be; check that it's nonnegative, just in
1731 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1732 apart (about 25 days). (Bug#8664)
8e55734a 1733
841f1b75 1734 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1735 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1736
3e26f69c
PE
1737 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1738 that always fit in int. Use a sentinel instead of a counter, to
1739 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1740 * frame.h (struct frame): Use int for menu_bar_items_used
1741 instead of EMACS_INT, since it always fits in int.
3e26f69c 1742
5cc152c0
PE
1743 * menu.c (grow_menu_items): Check for int overflow.
1744
d89eb65e
PE
1745 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1746
5235bd3e
PE
1747 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1748 Before, the code was not consistent. These values cannot exceed
1749 2**31 - 1 so there's no need to make them unsigned.
1750 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1751 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1752 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1753 as modifiers.
1754 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1755
bc827e23
PE
1756 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1757 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1758 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1759 presumably because the widths might not match.
1760
78eb494e
PE
1761 * window.c (size_window): Avoid needless test at loop start.
1762
04f2d78b
CB
17632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1764
1765 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1766
d2fc7e3d 17672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1768
1769 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1770
d2fc7e3d 17712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1772
1773 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1774 `width' to `bar_area_x' and `bar_area_width', respectively.
1775 (x_scroll_run): Take account of fringe background extension.
1776
04f2d78b
CB
1777 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1778 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1779 `bar_area_width', respectively.
1780 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1781 background extension.
1782
79b70037
GM
17832011-05-10 Jim Meyering <meyering@redhat.com>
1784
1785 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1786
2f142cc5
JB
17872011-05-10 Juanma Barranquero <lekktu@gmail.com>
1788
1789 * image.c (Finit_image_library): Return t for built-in image types,
1790 like pbm and xbm. (Bug#8640)
1791
57679c86
AS
17922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1793
1794 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1795
888c9e86
EZ
17962011-05-07 Eli Zaretskii <eliz@gnu.org>
1797
b0512a1d
EZ
1798 * w32console.c (Fset_screen_color): Doc fix.
1799 (Fget_screen_color): New function.
1800 (syms_of_ntterm): Defsubr it.
1801
7285dc67
EZ
1802 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1803 unlink the temporary file if Fcall_process didn't create it in the
1804 first place.
1805 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1806 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1807 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1808 cue to call_process_cleanup not to close that handle.
1809
4d3fcc8e
BK
18102011-05-07 Ben Key <bkey76@gmail.com>
1811
1812 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1813 one of two shell specific rules, either bootstrap-temacs-CMD or
1814 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1815 to the previous implementation of the bootstrap-temacs rule.
1816 The bootstrap-temacs-CMD rule is similar to the previous
1817 implementation of the bootstrap-temacs rule except that it
1818 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1819 variable.
1820
1821 These changes, along with some changes to nt/configure.bat,
1822 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1823 earlier fix to add support for --cflags and --ldflags options
1824 that include quotes so that it works whether make uses cmd or
1825 sh as the shell.
1826
b4289b64
MA
18272011-05-06 Michael Albinus <michael.albinus@gmx.de>
1828
1829 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1830 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1831 is a constant.
1832 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1833 a string. Handle both cases.
1834 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1835 (Fdbus_register_method): Use Qinvalid_function.
1836
af4c0e28
JB
18372011-05-06 Juanma Barranquero <lekktu@gmail.com>
1838
1839 * makefile.w32-in: Update dependencies.
1840 (LISP_H): Add inttypes.h and stdin.h.
1841 (PROCESS_H): Add unistd.h.
1842
c51453d9
EZ
18432011-05-06 Eli Zaretskii <eliz@gnu.org>
1844
1845 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1846 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1847
8ff0ac3c 18482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1849
4c4b566b
PE
1850 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1851
aab2b9b5
PE
1852 * term.c (vfatal): Remove stray call to va_end.
1853 It's not needed and the C Standard doesn't allow it here anyway.
1854
c378da0b
PE
1855 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1856 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1857
288b08c7
PE
1858 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1859 bytes.
1860
e3601888
PE
1861 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1862
db6c0e74
PE
1863 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1864
dd5963ea
PE
1865 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1866
88c9450f
PE
1867 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1868
2f9442b8
PE
1869 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1870
c032b5f8
PE
1871 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1872 * charset.c (Fdefine_charset_internal): Don't initialize
1873 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1874 32-bit int (Bug#8600).
a108c10b
PE
1875
1876 * lread.c (read_integer): Be more consistent with string-to-number.
1877 Use string_to_number to do the actual conversion; this avoids
1878 rounding errors and fixes some other screwups. Without this fix,
1879 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1880 (digit_to_number): Move earlier, for benefit of read_integer.
1881 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1882 not a digit in any supported base. (Bug#8602)
a108c10b 1883
ad5f9eea
PE
1884 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1885
aec1708a
PE
1886 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1887 to match comment at start of function. This also removes a
1888 GCC warning about overflow in a 32+64-bit port.
1889
47be4ab5
PE
1890 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1891
371cac43
PE
1892 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1893 Reported by Stefan Monnier in
1894 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1895 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1896 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1897
d01a7826
PE
1898 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1899 (EMACS_UINTPTR): Likewise, with uintptr_t.
1900
7fd47d5c
PE
1901 * lisp.h: Prefer 64-bit EMACS_INT if available.
1902 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1903 on 32-bit hosts that have 64-bit int, so that they can access
1904 large files.
122b0c86
PE
1905 However, temporarily disable this change unless the temporary
1906 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1907
8727937b
PE
1908 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1909
8ac068ac
PE
1910 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1911 This removes an assumption that EMACS_INT and long are the same
1912 width as pointers. The assumption is true for Emacs porting targets
1913 now, but we want to make other targets possible.
1914 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1915 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1916 In the rest of the code, change types of integers that hold casted
1917 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1918 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1919 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1920 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1921 No need to cast type when ORing.
1922 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1923 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1924 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1925 assume EMACS_INT is the same width as char *.
1926 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1927 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1928 Remove no-longer-needed casts.
1929 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1930 (xg_tool_bar_help_callback, xg_make_tool_item):
1931 Use EMACS_INTPTR to hold an integer
1932 that will be cast to void *; this can avoid a GCC warning
1933 if EMACS_INT is not the same width as void *.
1934 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1935 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1936 (current_message_1, set_message_1):
1937 Use a local to convert to proper width without a cast.
1938 * xmenu.c (dialog_selection_callback): Likewise.
1939
ede49d71
PE
1940 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1941 Also, don't assume VALBITS / RAND_BITS is less than 5,
1942 and don't rely on undefined behavior when shifting a 1 left into
1943 the sign bit.
1944 * lisp.h (get_random): Change signature to match.
1945
2f30ecd0
PE
1946 * lread.c (hash_string): Use size_t, not int, for hash computation.
1947 Normally we prefer signed values; but hashing is special, because
1948 it's better to use unsigned division on hash table sizes so that
1949 the remainder is nonnegative. Also, size_t is the natural width
1950 for hashing into memory. The previous code used 'int', which doesn't
1951 retain enough info to hash well into very large tables.
1952 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1953
2a866e7b
PE
1954 * dbusbind.c: Don't possibly lose pointer info when converting.
1955 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1956 Use XPNTR rather than XHASH, so that the high-order bits of
1957 the pointer aren't lost when converting through void *.
1958
51639eac
PE
1959 * eval.c (Fautoload): Don't double-shift a pointer.
1960
92394119
PE
1961 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1962
dbdb9a7c
JB
19632011-05-06 Juanma Barranquero <lekktu@gmail.com>
1964
1965 * gnutls.c (DEF_GNUTLS_FN):
1966 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1967
db7a0b4f
AS
19682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1969
1970 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1971 marker. (Bug#8610)
1972
f7ff1b0f 19732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1974
1975 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1976 New version that can reserve upto 2GB of heap space.
1977
f7ff1b0f 19782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1979
1980 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1981
639c109b
TZ
19822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1983
1984 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1985 `gnutls_certificate_set_x509_key_file'.
1986
d2127135
JB
19872011-05-05 Juanma Barranquero <lekktu@gmail.com>
1988
1989 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1990 Update dependencies.
1991
e968f4f3
JB
19922011-05-04 Juanma Barranquero <lekktu@gmail.com>
1993
1994 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1995 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1996 Remove unused parameter `fildes'.
1997 * process.c (read_process_output, send_process): Don't pass it.
1998
84d358f0
JB
19992011-05-04 Juanma Barranquero <lekktu@gmail.com>
2000
2001 Fix previous change: the library cache is defined in w32.c.
2002 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2003 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2004
0898ca10
JB
20052011-05-04 Juanma Barranquero <lekktu@gmail.com>
2006
2007 Implement dynamic loading of GnuTLS on Windows.
2008
2009 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2010 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2011 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2012 Declare.
2013
2014 * gnutls.c (Qgnutls_dll): Define.
2015 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2016 (gnutls_*): Declare function pointers.
2017 (init_gnutls_functions): New function to initialize function pointers.
2018 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2019 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2020 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2021 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2022 (emacs_gnutls_write, emacs_gnutls_read)
2023 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2024 (Fgnutls_available_p): New function.
2025 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2026 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2027 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2028
2029 * image.c: Include w32.h.
2030 (Vimage_type_cache): Delete.
2031 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2032 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2033 (w32_delayed_load): Move to w32.c.
2034
2035 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2036
2037 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2038 (w32_delayed_load): Move from image.c. When loading a library, record
2039 its filename in the :loaded-from property of the library id.
2040 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2041 Initialize and staticpro them.
2042 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2043
2044 * process.c: Include lisp.h before w32.h, not after.
2045 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2046 instead of gnutls_record_check_pending.
2047
2048 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2049
ff4de4aa
TZ
20502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2051
2052 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2053 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2054 as passed in.
2055
abe95abb
JD
20562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2057
2058 * xterm.c (x_set_frame_alpha): Do not set property on anything
2059 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2060
e16e55d4
JB
20612011-05-02 Juanma Barranquero <lekktu@gmail.com>
2062
2063 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2064
bafcf6a5
JB
20652011-05-02 Juanma Barranquero <lekktu@gmail.com>
2066
2067 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2068 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2069 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2070 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2071 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2072 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2073 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2074 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2075 (Qgnutls_bootprop_callbacks_verify): Make static.
2076
e7a6747f
AS
20772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2078
19ed11ba
AS
2079 * callproc.c: Indentation fixup.
2080
e7a6747f 2081 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2082 (wait_for_termination, interruptible_wait_for_termination):
2083 Move after wait_for_termination_1.
e7a6747f 2084
1ef14cb4
LMI
20852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2086
2087 * sysdep.c (interruptible_wait_for_termination): New function
2088 which is like wait_for_termination, but allows keyboard
2089 interruptions.
2090
2091 * callproc.c (Fcall_process): Add (:file "file") as an option for
2092 the STDOUT buffer.
2093 (Fcall_process_region): Ditto.
2094
330d880c
EZ
20952011-04-30 Eli Zaretskii <eliz@gnu.org>
2096
8db90b73
EZ
2097 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2098 rather than `XVECTOR (FOO)->size'.
2099
330d880c
EZ
2100 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2101 inttypes.h, as a gnulib replacement is used if it not available in
2102 system headers.
2103
15cbd324
EZ
21042011-04-21 Eli Zaretskii <eliz@gnu.org>
2105
2106 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2107 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2108 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2109
2110 * coding.c (coding_alloc_by_realloc): Error out if destination
2111 will grow beyond MOST_POSITIVE_FIXNUM.
2112 (decode_coding_emacs_mule): Abort if there isn't enough place in
2113 charbuf for the composition carryover bytes. Reserve an extra
2114 space for up to 2 characters produced in a loop.
2115 (decode_coding_iso_2022): Abort if there isn't enough place in
2116 charbuf for the composition carryover bytes.
2117
21182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2119
ae940cca
EZ
2120 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2121 aborting when %lld or %lll format is passed.
2122 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2123 %llo or %llx format is passed. (Bug#8545)
2124
03ab8921
EZ
2125 * window.c (window_scroll_line_based): Use a marker instead of
2126 simple variables to record original value of point. (Bug#7952)
2127
afda1437
EZ
2128 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2129 produced by %s or %c overflows available buffer space. (Bug#8545)
2130
f76dee0c
PE
21312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2132
2133 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2134 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2135
fdc5744d
JB
21362011-04-28 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2139
638f053a
JB
21402011-04-28 Juanma Barranquero <lekktu@gmail.com>
2141
2142 * keyboard.c (Qdelayed_warnings_hook): Define.
2143 (command_loop_1): Run `delayed-warnings-hook'
2144 if Vdelayed_warnings_list is non-nil.
2145 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2146 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2147
d178f871
EZ
21482011-04-28 Eli Zaretskii <eliz@gnu.org>
2149
2150 * doprnt.c (doprnt): Don't return value smaller than the buffer
2151 size if the message was truncated. (Bug#8545).
2152
b124fd93
JB
21532011-04-28 Juanma Barranquero <lekktu@gmail.com>
2154
2155 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2156 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2157
e810457d
PE
21582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2161
ea51cceb
JB
21622011-04-27 Juanma Barranquero <lekktu@gmail.com>
2163
2164 * makefile.w32-in: Update dependencies.
2165
94dcfacf
EZ
21662011-04-27 Eli Zaretskii <eliz@gnu.org>
2167
2168 Improve `doprnt' and its usage. (Bug#8545)
2169 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2170 `format_end'. Remove support for %l as a conversion specifier.
2171 Don't use xrealloc. Improve diagnostics when the %l size modifier
2172 is used. Update the commentary.
2173
2174 * eval.c (verror): Simplify calculation of size_t.
2175
2176 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2177 messages.
2178
f61f41d7
PE
21792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2180
2181 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2182 change.
2183
96fb4434
PE
21842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2187 This makes this file independent of the recent pseudovector change.
2188
671875da 21892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2190
69e9b5a3
PE
2191 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2192
b5f869a7 2193 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2194 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2195 Remove unused local.
c8926152 2196 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2197
841a1577 2198 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2199 GCC 4.6.0 optimizes based on type-based alias analysis.
2200 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2201 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2202 != &v->size, and therefore "v->size = 1; b->size = 2; return
2203 v->size;" must therefore return 1. This assumption is incorrect
2204 for Emacs, since it type-puns struct Lisp_Vector * with many other
2205 types. To fix this problem, this patch adds a new type struct
f904488f 2206 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2207 and pseudovectors, and helps optimizing compilers not get fooled
2208 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2209 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2210 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2211 the size member.
eab3844f
PE
2212 (XSETPVECTYPE): Rewrite in terms of new macro.
2213 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2214 This is a bit clearer, and further avoids the possibility of
2215 undesirable aliasing.
2216 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2217 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2218 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2219 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2220 (ASIZE): Now uses header.size rather than size.
2221 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2222 to avoid the hassle of writing XVECTOR (foo)->header.size.
2223 (struct vectorlike_header): New type.
eab3844f
PE
2224 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2225 object, to help avoid aliasing.
2226 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2227 (SUBRP): Likewise, since Lisp_Subr is a special case.
2228 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2229 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2230 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2231 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2232 changed to be "header.size" and "header.next".
2233 * buffer.h (struct buffer): Likewise.
2234 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2235 * frame.h (struct frame): Likewise.
2236 * process.h (struct Lisp_Process): Likewise.
2237 * termhooks.h (struct terminal): Likewise.
2238 * window.c (struct save_window_data, struct saved_window): Likewise.
2239 * window.h (struct window): Likewise.
2240 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2241 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2242 * buffer.c (init_buffer_once): Likewise.
2243 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2244 special case.
2245 * process.c (Fformat_network_address): Use local var for size,
2246 for brevity.
2247
0df1eac5
PE
2248 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2249
847ab9d1 2250 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2251 * data.c (atof): Remove decl; no longer used or needed.
2252 (digit_to_number): Move to lread.c.
2253 (Fstring_to_number): Use new string_to_number function, to be
2254 consistent with how the Lisp reader treats infinities and NaNs.
2255 Do not assume that floating-point numbers represent EMACS_INT
2256 without losing information; this is not true on most 64-bit hosts.
2257 Avoid double-rounding errors, by insisting on integers when
2258 parsing non-base-10 numbers, as the documentation specifies.
2259 * lisp.h (string_to_number): New decl, replacing ...
2260 (isfloat_string): Remove.
bc0a5c13 2261 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2262 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2263 appears to have been a coding error. Similarly, do not accept
2264 strings like +-1e0 as floating point numbers. Do not report
2265 overflow for integer overflows unless the base is not 10 which
2266 means we have no simple and reliable way to continue.
2267 Break out the floating-point parsing into a new
2268 function string_to_number, so that Fstring_to_number parses
2269 floating point numbers consistently with the Lisp reader.
04f2d78b 2270 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2271 (E_CHAR, EXP_INT): Remove, replacing with ...
2272 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2273 (string_to_number): New function, replacing isfloat_string.
2274 This function checks for valid syntax and produces the resulting
2275 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2276 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2277 so that overflow for non-base-10 numbers is reported only when
2278 there's no portable and simple way to convert to floating point.
452f4150 2279
67769ffc
PE
2280 * textprop.c (set_text_properties_1): Rewrite for clarity,
2281 and to avoid GCC warning about integer overflow.
2282
c20db43f
PE
2283 * intervals.h (struct interval): Use EMACS_INT for members
2284 where EMACS_UINT might cause problems. See
2285 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2286 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2287 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2288 All uses changed.
37aa2f85
PE
2289 (offset_intervals): Tell GCC not to worry about length overflow
2290 when negating a negative length.
c20db43f 2291
2538aa2f
PE
2292 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2293 (overrun_check_free): Likewise.
2294
f2d3008d
PE
2295 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2296 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2297 word size.
2298
ec8df744
PE
2299 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2300 (gnutls_make_error): Rename local to avoid shadowing.
2301 (gnutls_emacs_global_deinit): ifdef out; not used.
2302 (Fgnutls_boot): Use const for pointer to readonly storage.
2303 Comment out unused local. Fix pointer signedness problems.
2304
640ee02d
PE
2305 * lread.c (openp): Don't stuff size_t into an 'int'.
2306 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2307 about possible signed overflow.
2308
6048fb2a
PE
2309 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2310 (GDK_KEY_g): Don't define if already defined.
2311 (xg_prepare_tooltip): Avoid pointer signedness problem.
2312 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2313
fa3c87e1
PE
2314 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2315 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2316
2172544b
PE
2317 * xfns.c (Fx_window_property): Simplify a bit,
2318 to make a bit faster and to avoid GCC 4.6.0 warning.
2319 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2320
9b821a21
PE
2321 * fns.c (internal_equal): Don't assume size_t fits in int.
2322
3c616cfa
PE
2323 * alloc.c (compact_small_strings): Tighten assertion a little.
2324
c2982e87
PE
2325 Replace pEd with more-general pI, and fix some printf arg casts.
2326 * lisp.h (pI): New macro, generalizing old pEd macro to other
2327 conversion specifiers. For example, use "...%"pI"d..." rather
2328 than "...%"pEd"...".
2329 (pEd): Remove. All uses replaced with similar uses of pI.
2330 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2331 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2332 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2333 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2334 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2335 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2336 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2337 64-bit hosts.
2338 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2339 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2340 * print.c (safe_debug_print, print_object): Likewise.
2341 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2342 to int.
6f04d126
PE
2343 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2344 avoiding the 0 flag, which is not portable.
c2982e87
PE
2345 * process.c (Fmake_network_process): Use pI to avoid cast.
2346 * region-cache.c (pp_cache): Likewise.
2347 * xdisp.c (decode_mode_spec): Likewise.
2348 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2349 behavior on 64-bit hosts with printf arg.
6f04d126 2350 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2351 (x_stop_queuing_selection_requests): Likewise.
2352 (x_get_window_property): Don't truncate byte count to an 'int'
2353 when tracing.
0b432f21 2354
5e073ec7
PE
2355 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2356 here, since it parses constructs like leading '-' and spaces,
2357 which are not wanted; and it overflows with large numbers.
2358 Instead, simply match F[0-9]+, which is what is wanted anyway.
2359
36372bf9
PE
2360 * alloc.c: Remove unportable assumptions about struct layout.
2361 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2362 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2363 (allocate_vectorlike, make_pure_vector): Use the new macros,
2364 plus offsetof, to remove unportable assumptions about struct layout.
2365 These assumptions hold on all porting targets that I know of, but
2366 they are not guaranteed, they're easy to remove, and removing them
2367 makes further changes easier.
2368
0b432f21
PE
2369 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2370 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2371 (string_overrun_cookie): Now const. Use initializers that
2372 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2373 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2374 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2375 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2376 multiple of sizeof (EMACS_INT); it need not be, if
2377 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2378 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2379
895009e1
JB
23802011-04-26 Juanma Barranquero <lekktu@gmail.com>
2381
2382 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2383
6a7a1b0b
TZ
23842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2385
2386 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2387 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2388 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2389
841a1577 23902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2391
2392 * lisp.h (Qdebug): List symbol.
895009e1 2393 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2394 * keyboard.c (debug-on-event): New variable.
2395 (handle_user_signal): Break into debugger when debug-on-event
2396 matches the current signal symbol.
2397
f2d3ba6f
DN
23982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2399
2400 * alloc.c (check_sblock, check_string_bytes)
2401 (check_string_free_list): Convert to standard C.
2402
42ce4c63
TZ
24032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2404
2405 * w32.c (emacs_gnutls_push): Fix typo.
2406
825cd63c
EZ
24072011-04-25 Eli Zaretskii <eliz@gnu.org>
2408
fb11d64d
EZ
2409 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2410 "cast to pointer from integer of different size".
2411
825cd63c
EZ
2412 Improve doprnt and its use in verror. (Bug#8545)
2413 * doprnt.c (doprnt): Document the set of format control sequences
2414 supported by the function. Use SAFE_ALLOCA instead of always
2415 using `alloca'.
2416
2417 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2418 is one byte too soon. Don't use xrealloc; instead xfree and
2419 xmalloc anew.
2420
e061a11b
TZ
24212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2422
2423 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2424 callbacks stage.
2425
2426 * gnutls.c: Renamed global_initialized to
2427 gnutls_global_initialized. Added internals for the
2428 :verify-hostname-error, :verify-error, and :verify-flags
2429 parameters of `gnutls-boot' and documented those parameters in the
2430 docstring. Start callback support.
2431 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2432 unless a fatal error occured. Call gnutls_alert_send_appropriate
2433 on error. Return error code.
2434 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2435 (emacs_gnutls_read): Likewise.
2436 (Fgnutls_boot): Return handshake error code.
2437 (emacs_gnutls_handle_error): New function.
2438 (wsaerror_to_errno): Likewise.
2439
2440 * w32.h (emacs_gnutls_pull): Add prototype.
2441 (emacs_gnutls_push): Likewise.
2442
2443 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2444 (emacs_gnutls_push): Likewise.
2445
24462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2447
2448 * process.c (wait_reading_process_output): Check if GnuTLS
2449 buffered some data internally if no FDs are set for TLS
2450 connections.
2451
2452 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2453 (LIBS): Link to USER_LIBS.
2454 ($(BLD)/gnutls.$(0)): New target.
2455
fa6996bc
EZ
24562011-04-24 Eli Zaretskii <eliz@gnu.org>
2457
eb35682e
EZ
2458 * xdisp.c (handle_single_display_spec): Rename the
2459 display_replaced_before_p argument into display_replaced_p, to
2460 make it consistent with the commentary. Fix typos in the
2461 commentary.
2462
e2ad650c
EZ
2463 * textprop.c (syms_of_textprop): Remove dead code.
2464 (copy_text_properties): Delete obsolete commentary about an
2465 interface that was deleted long ago. Fix typos in the description
2466 of arguments.
2467
1b2de274
EZ
2468 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2469 to changes in oldXMenu/XMenu.h from 2011-04-16.
2470 <menu_help_message, prev_menu_help_message>: Constify.
2471 (IT_menu_make_room): menu->help_text is now `const char **';
2472 adjust.
2473
2474 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2475 to changes in oldXMenu/XMenu.h from 2011-04-16.
2476 (struct XMenu): Declare `help_text' `const char **'.
2477
2478 * xfaces.c <Qunspecified>: Make extern again.
2479
2480 * syntax.c: Include sys/types.h before including regex.h, as
2481 required by Posix.
2482
762b15be
EZ
2483 * doc.c (get_doc_string): Improve the format passed to `error'.
2484
2485 * doprnt.c (doprnt): Improve commentary.
2486
2487 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2488
2489 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2490 them with etags.
2491
f1052e5d
EZ
2492 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2493 changes in globals.h immediately force recompilation.
762b15be
EZ
2494 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2495 $(CURDIR)/s/ms-w32.h.
2496 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2497
fa6996bc
EZ
2498 * character.c (Fchar_direction): Function deleted.
2499 (syms_of_character): Don't defsubr it.
2500 <char-direction-table>: Deleted.
2501
e6c3da20
EZ
25022011-04-23 Eli Zaretskii <eliz@gnu.org>
2503
2504 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2505 * doprnt.c: Include limits.h.
2506 (SIZE_MAX): New macro.
04f2d78b
CB
2507 (doprnt): Return a size_t value. 2nd arg is now size_t.
2508 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2509 Improve overflow protection. Support `l' modifier for integer
2510 conversions. Support %l conversion. Don't assume an EMACS_INT
2511 argument for integer conversions and for %c.
2512
2513 * lisp.h (doprnt): Restore prototype.
2514
2515 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2516 $(SRC)/character.h.
2517
2518 * Makefile.in (base_obj): Add back doprnt.o.
2519
2520 * deps.mk (doprnt.o): Add back prerequisites.
2521 (callint.o): Depend on character.h.
2522
2523 * eval.c (internal_lisp_condition_case): Include the handler
2524 representation in the error message.
2525 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2526 when breaking from the loop.
2527
2528 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2529
2530 * callint.c (Fcall_interactively): When displaying error message
2531 about invalid control letter, pass the character's codepoint, not
2532 a pointer to its multibyte form. Improve display of the character
2533 in octal and display also its hex code.
2534
2535 * character.c (char_string): Use %x to display the (unsigned)
2536 codepoint of an invalid character, to avoid displaying a bogus
2537 negative value.
2538
2539 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2540 `error', not SYMBOL_NAME itself.
2541
2542 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2543 character arguments to `error'.
2544
2545 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2546 to `error' in error message about FINAL_CHAR argument. Make sure
2547 FINAL_CHAR is a character, and use %c when it is passed as
2548 argument to `error'.
2549
4ffd0d6b 25502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2551
2552 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2553
2554 * w32.c: Include <time.h>.
2555 (sys_localtime): New function.
2556
4ffd0d6b 25572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2558
2559 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2560
4ffd0d6b 2561 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2562
4ffd0d6b 25632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2564
4ffd0d6b
GM
2565 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2566 zombies (Bug#8467).
aac0c6e3 2567
04c56954
EZ
25682011-04-19 Eli Zaretskii <eliz@gnu.org>
2569
2570 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2571 gl_state.e_property when gl_state.object is Qt.
2572
2573 * insdel.c (make_gap_larger): Remove limitation of buffer size
2574 to <= INT_MAX.
2575
16a43933
CY
25762011-04-18 Chong Yidong <cyd@stupidchicken.com>
2577
2578 * xdisp.c (lookup_glyphless_char_display)
2579 (produce_glyphless_glyph): Handle cons cell entry in
2580 glyphless-char-display.
2581 (Vglyphless_char_display): Document it.
2582
2583 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2584 glyphless-char-display.
2585
4581706e
CY
25862011-04-17 Chong Yidong <cyd@stupidchicken.com>
2587
2588 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2589
2590 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2591
2592 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2593 definition for no-X builds.
2594
4887c6e2 25952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2596
fd35b6f9
PE
2597 Static checks with GCC 4.6.0 and non-default toolkits.
2598
5c1ccb01
PE
2599 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2600
006c5daa
PE
2601 * process.c (keyboard_bit_set): Define only if SIGIO.
2602 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2603 (send_process): Repair possible setjmp clobbering.
2604
efc736d3
PE
2605 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2606
4e2fe2e6
PE
2607 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2608
f97334a2
PE
2609 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2610
4e75f29d
PE
2611 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2612 Define only if needed.
2613
90efadd1
PE
2614 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2615 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2616 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2617
3c647824
PE
2618 * dispextern.h (struct redisplay_interface): Rename param
2619 to avoid shadowing.
e264f262 2620 * termhooks.h (struct terminal): Likewise.
761383f4 2621 * xterm.c (xembed_send_message): Likewise.
3c647824 2622
b58c5c4a
PE
2623 * insdel.c (make_gap_smaller): Define only if
2624 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2625
cad59032
PE
2626 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2627 it.
2628
c339dc2e
PE
2629 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2630 so that we aren't warned about unused symbols.
2631
91a3e27b
PE
2632 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2633
399c71d3 2634 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2635
8ffc96f5
PE
2636 * xfns.c (x_real_positions): Mark locals as initialized.
2637
eef9bc79
PE
2638 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2639
098db9dd
PE
2640 * xterm.c: Fix problems found by static analysis with other toolkits.
2641 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2642 (x_dispatch_event): Declare static if USE_GTK, and
2643 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2644 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2645 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2646 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2647 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2648
eb18f6cc
PE
2649 * xmenu.c (menu_help_callback): Pointer type fixes.
2650 Use const pointers when pointing at readonly data. Avoid pointer
2651 signedness clashes.
2652 (FALSE): Remove unused macro.
2653 (update_frame_menubar): Remove unused decl.
2654
1fe72bf8
PE
2655 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2656
60d9e1db
PE
2657 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2658 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2659 (single_menu_item): Rename local to avoid shadowing.
2660
39261c26
PE
2661 * keyboard.c (make_lispy_event): Remove unused local var.
2662
018c5e19
PE
2663 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2664 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2665
63d2b86e
PE
2666 * bitmaps: Change bitmaps from unsigned char back to the X11
2667 compatible char. Avoid the old compiler warnings about
2668 out-of-range initializers by using, for example, '\xab' rather
2669 than 0xab.
2670
aefd87e1
PE
2671 * xgselect.c (xgselect_initialize): Check vs interface
2672 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2673
bf501fb9
PE
2674 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2675
e9829fdf
PE
2676 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2677 to read-only memory.
2678
1086c095
PE
2679 * fns.c (vector): Remove; this old hack is no longer needed.
2680
2baccd04 2681 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2682 Remove unused var.
dde42981 2683 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2684
72391843 2685 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2686
436c16df 2687 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2688 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2689 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2690
92bb796d 2691 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2692 (x_term_init): Remove local to avoid shadowing.
92bb796d 2693
764430a3 2694 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2695
2696 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2697 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2698
d1dfb56c
EZ
26992011-04-16 Eli Zaretskii <eliz@gnu.org>
2700
c4354cb4
EZ
2701 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2702
d1dfb56c
EZ
2703 Fix regex.c, syntax.c and friends for buffers > 2GB.
2704 * syntax.h (struct gl_state_s): Declare character position members
2705 EMACS_INT.
2706
2707 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2708
04f2d78b
CB
2709 * textprop.c (verify_interval_modification, interval_of):
2710 Declare arguments EMACS_INT.
d1dfb56c
EZ
2711
2712 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2713 EMACS_INT.
2714
2715 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2716
2717 * indent.c (Fvertical_motion): Local variable it_start is now
2718 EMACS_INT.
2719
2720 * regex.c (re_match, re_match_2, re_match_2_internal)
2721 (bcmp_translate, regcomp, regexec, print_double_string)
2722 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2723 (re_compile_pattern, re_exec): Declare arguments and local
2724 variables `size_t' and `ssize_t' and return values `regoff_t', as
2725 appropriate.
2726 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2727 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2728 <compile_stack_type>: `size' and `avail' are now `size_t'.
2729
2730 * regex.h <regoff_t>: Use ssize_t, not int.
2731 (re_search, re_search_2, re_match, re_match_2): Arguments that
2732 specify buffer/string position and length are now ssize_t and
2733 size_t. Return type is regoff_t.
2734
613052cd
BK
27352011-04-16 Ben Key <bkey76@gmail.com>
2736
2737 * nsfont.m: Fixed bugs in ns_get_family and
2738 ns_descriptor_to_entity that were caused by using free to
2739 deallocate memory blocks that were allocated by xmalloc (via
2740 xstrdup). This caused Emacs to crash when compiled with
2741 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2742 --enable-checking=xmallocoverrun). xfree is now used to
2743 deallocate these memory blocks.
2744
4170f62f 27452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2746
71b41406
PE
2747 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2748
9587a89d
PE
2749 emacs_write: Accept and return EMACS_INT for sizes.
2750 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2751 et seq.
2752 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2753 Accept and return EMACS_INT.
2754 (emacs_gnutls_write): Return the number of bytes written on
2755 partial writes.
2756 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2757 (emacs_read, emacs_write): Remove check for negative size, as the
2758 Emacs source code has been audited now.
9587a89d
PE
2759 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2760 (emacs_read, emacs_write): Use it.
273a5f82
PE
2761 * process.c (send_process): Adjust to the new signatures of
2762 emacs_write and emacs_gnutls_write. Do not attempt to store
2763 a byte offset into an 'int'; it might overflow.
9587a89d 2764 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2765
3e047f51
PE
2766 * sound.c: Don't assume sizes fit in 'int'.
2767 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2768 Return EMACS_INT, not int.
3e047f51 2769 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2770 Accept EMACS_INT, not int.
2771 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2772 record read return values.
2773
cc39a9db
BK
27742011-04-15 Ben Key <bkey76@gmail.com>
2775
c9d0ec6d
JB
2776 * keyboard.c (Qundefined): Don't declare static since it is used
2777 in nsfns.m.
2778 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2779 static since they are used in nsfont.m.
cc39a9db 2780
6c60eb9f
SM
27812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2782
2783 * process.c (Qprocessp): Don't declare static.
2784 * lisp.h (Qprocessp): Declare again.
2785
7990b61a
JB
27862011-04-15 Juanma Barranquero <lekktu@gmail.com>
2787
2788 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2789
5d4cb038
PE
27902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2791
8bd7b830 2792 Improve C-level modularity by making more things 'static'.
cd64ea1d 2793
e3b27b31
PE
2794 Don't publish debugger-only interfaces to other modules.
2795 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2796 (verify_bytepos, count_markers): Move decls to the only modules
2797 that need them.
2798 * region-cache.h (pp_cache): Likewise.
2799 * window.h (check_all_windows): Likewise.
2800 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2801
5d4cb038
PE
2802 * sysdep.c (croak): Now static, if
2803 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2804 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2805
2806 * alloc.c (refill_memory_reserve): Now static if
2807 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2808 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2809
e87b6180
PE
2810 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2811 Define only if USE_LUCID.
2812
ac64929e
PE
2813 * xrdb.c (x_customization_string, x_rm_string): Now static.
2814
6f37259d
PE
2815 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2816 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2817
1683e3ab
PE
2818 * xdisp.c (draw_row_with_mouse_face): Now static.
2819 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2820
de9c2632
PE
2821 * window.h (check_all_windows): Mark externally visible.
2822
2b96acb7
PE
2823 * window.c (window_deletion_count): Now static.
2824
2825 * undo.c: Make symbols static if they're not exported.
2826 (last_undo_buffer, last_boundary_position, pending_boundary):
2827 Now static.
2828
50436f33
PE
2829 * textprop.c (interval_insert_behind_hooks): Now static.
2830 (interval_insert_in_front_hooks): Likewise.
2831
64520e5c
PE
2832 * term.c: Make symbols static if they're not exported.
2833 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2834 (max_frame_lines, tty_set_terminal_modes):
2835 (tty_reset_terminal_modes, tty_turn_off_highlight):
2836 (get_tty_terminal): Now static.
2837 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2838 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2839 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2840 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2841 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2842
1fa53021
PE
2843 * sysdep.c: Make symbols static if they're not exported.
2844 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2845 Now static.
2846 (sigprocmask_set, full_mask): Remove; unused.
2847 (wait_debugging): Mark as visible.
2848 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2849 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2850
d4b43b22
PE
2851 * syntax.c (syntax_temp): Define only if !__GNUC__.
2852
b7c513d0
PE
2853 * sound.c (current_sound_device, current_sound): Now static.
2854
989b29ad
PE
2855 * search.c (searchbufs, searchbuf_head): Now static.
2856
13a55a78
PE
2857 * scroll.c (scroll_cost): Remove; unused.
2858 * dispextern.h (scroll_cost): Remove decl.
2859
de68a1fc
PE
2860 * region-cache.h (pp_cache): Mark as externally visible.
2861
40ccffa6
PE
2862 * process.c: Make symbols static if they're not exported.
2863 (process_tick, update_tick, create_process, chan_process):
2864 (Vprocess_alist, proc_buffered_char, datagram_access):
2865 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2866 (deactivate_process): Mark defn as static, as well as decl.
2867 * lisp.h (create_process): Remove decl.
2868 * process.h (chan_process, Vprocess_alist): Remove decls.
2869
ad64fc97
PE
2870 * print.c: Make symbols static if they're not exported.
2871 (print_depth, new_backquote_output, being_printed, print_buffer):
2872 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2873 (print_interval, print_number_index, initial_stderr_stream):
2874 Now static.
2875 * lisp.h (Fprinc): Remove decl.
2876 (debug_output_compilation_hack): Mark as externally visible.
2877
adddb265
PE
2878 * sysdep.c (croak): Move decl from here to syssignal.h.
2879 * syssignal.h (croak): Put it here, so the API can be checked when
2880 'croak' is called from dissociate_if_controlling_tty.
2881
1717ede2
PE
2882 * minibuf.c: Make symbols static if they're not exported.
2883 (minibuf_save_list, choose_minibuf_frame): Now static.
2884 * lisp.h (choose_minibuf_frame): Remove decl.
2885
fa5fb2bc
PE
2886 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2887
1e3890d1
PE
2888 * lread.c: Make symbols static if they're not exported.
2889 (read_objects, initial_obarray, oblookup_last_bucket_number):
2890 Now static.
2891 (make_symbol): Remove; unused.
2892 * lisp.h (initial_obarray, make_symbol): Remove decls.
2893
8a1414fa
PE
2894 * keyboard.c: Make symbols static if they're not exported.
2895 (single_kboard, recent_keys_index, total_keys, recent_keys):
2896 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2897 (this_single_command_key_start, echoing, last_auto_save):
2898 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2899 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2900 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2901 (Vlispy_mouse_stem, double_click_count):
2902 Now static.
2903 (force_auto_save_soon): Define only if SIGDANGER.
2904 (ignore_mouse_drag_p): Now static if
2905 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2906 (print_help): Remove; unused.
2907 (stop_character, last_timer_event): Mark as externally visible.
2908 * keyboard.h (ignore_mouse_drag_p): Declare only if
2909 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2910 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2911 * lisp.h (echoing): Remove decl.
2912 (force_auto_save_soon): Declare only if SIGDANGER.
2913 * xdisp.c (redisplay_window): Simplify code, to make it more
2914 obvious that ignore_mouse_drag_p is not accessed if !defined
2915 USE_GTK && !defined HAVE_NS.
2916
93ea6e8f
PE
2917 * intervals.c: Make symbols static if they're not exported.
2918 (merge_properties_sticky, merge_interval_right, delete_interval):
2919 Now static.
2920 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2921
77382fcc
PE
2922 * insdel.c: Make symbols static if they're not exported.
2923 However, leave prepare_to_modify_buffer alone. It's never
2924 called from outside this function, but that appears to be a bug.
2925 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2926 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2927 (adjust_after_replace_noundo): Remove; unused.
2928 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2929 (signal_before_change): Remove decls.
77382fcc 2930
9306c32e
PE
2931 * indent.c (val_compute_motion, val_vmotion): Now static.
2932
cd44d2eb
PE
2933 * image.c: Make symbols static if they're not exported.
2934 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2935 if USE_GTK.
2936 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2937 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2938
ad9a7a06
PE
2939 * fringe.c (standard_bitmaps): Now static.
2940 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2941
81626931
PE
2942 * frame.c: Make symbols static if they're not exported.
2943 (x_report_frame_params, make_terminal_frame): Now static.
2944 (get_frame_param): Now static, unless HAVE_NS.
2945 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2946 (x_get_resource_string): Remove; not used.
2947 * frame.h (make_terminal_frame, x_report_frame_params):
2948 (x_get_resource_string); Remove decls.
2949 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2950 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2951
239f9db9
PE
2952 * font.c, fontset.c: Make symbols static if they're not exported.
2953 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2954 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2955 * font.c (font_close_object): Now static.
2956 * font.h (font_close_object): Remove.
2957 * fontset.c (FONTSET_OBJLIST): Remove.
2958 (free_realized_fontset) #if-0 the body, which does nothing.
2959 (face_suitable_for_char_p): #if-0, as it's never called.
2960 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2961 * xfaces.c (face_at_string_position):
2962 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2963 since 0 is always ASCII.
2964
dfcf3579
PE
2965 * fns.c (weak_hash_tables): Now static.
2966
5045092b
PE
2967 * fileio.c: Make symbols static if they're not exported.
2968 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2969 (Vwrite_region_annotation_buffers): Now static.
2970
57a96f5c
PE
2971 * eval.c: Make symbols static if they're not exported.
2972 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2973 * lisp.h (backtrace_list): Remove decl.
2974
35f08c38
PE
2975 * emacs.c: Make symbols static if they're not exported.
2976 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2977 (fatal_error_code, fatal_error_signal_hook, standard_args):
2978 Now static.
2979 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2980 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2981 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2982 * lisp.h (fatal_error_signal_hook): Remove decl.
2983 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2984
f44bd759
PE
2985 * editfns.c: Move a (normally-unused) function to its only use.
2986 * editfns.c, lisp.h (get_operating_system_release): Remove.
2987 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2988 worth the hassle of breaking this out.
2989
b532497d
PE
2990 * xterm.c: Make symbols static if they're not exported.
2991 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2992 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2993 (x_destroy_window, x_delete_display):
2994 Now static.
2995 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2996 (x_mouse_leave): Remove; unused.
2997 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2998 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2999 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3000 Remove decls.
3001 (x_mouse_leave): Declare only if WINDOWSNT.
3002 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3003 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3004 USE_X_TOOLKIT.
3005
1675728f
PE
3006 * ftxfont.c: Make symbols static if they're not exported.
3007 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3008 HAVE_FREETYPE.
3009 * font.h (ftxfont_driver): Likewise.
3010
e4cebfca
PE
3011 * xfns.c: Make symbols static if they're not exported.
3012 (x_last_font_name, x_display_info_for_name):
3013 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3014 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3015 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3016 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3017 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3018 (last_show_tip_args): Now static.
3019 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3020 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3021 (x_screen_planes): Remove; unused.
3022 * dispextern.h (x_screen_planes): Remove decl.
3023
5bf46f05
PE
3024 * dispnew.c: Make symbols static if they're not exported.
3025 * dispextern.h (redraw_garbaged_frames, scrolling):
3026 (increment_row_positions): Remove.
3027 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3028 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3029 Now static.
3030 (redraw_garbaged_frames): Remove; unused.
3031
435f4c28
PE
3032 * xfaces.c: Make symbols static if they're not exported.
3033 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3034 Remove decls.
3035 * xterm.h (defined_color): Remove decls.
3036 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3037 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3038 (menu_face_changed_default, defined_color, free_realized_face):
3039 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3040 (ascii_face_of_lisp_face): Remove; unused.
3041
8524aef3
PE
3042 * xdisp.c: Make symbols static if they're not exported.
3043 * dispextern.h (scratch_glyph_row, window_box_edges):
3044 (glyph_to_pixel_coords, set_cursor_from_row):
3045 (get_next_display_element, set_iterator_to_next):
3046 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3047 (show_mouse_face): Remove decls
3048 * frame.h (message_buf_print): Likewise.
3049 * lisp.h (pop_message, set_message, check_point_in_composition):
3050 Likewise.
3051 * xterm.h (set_vertical_scroll_bar): Likewise.
3052 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3053 (message_buf_print, scratch_glyph_row, displayed_buffer):
3054 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3055 (get_next_display_element, show_mouse_face, window_box_edges):
3056 (frame_to_window_pixel_xy, check_point_in_composition):
3057 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3058 (glyph_to_pixel_coords): Remove; unused.
3059
16390cd2
PE
3060 * dired.c (file_name_completion): Now static.
3061
3062 * dbusbind.c (xd_in_read_queued_messages): Now static.
3063
a25f4dfa
PE
3064 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3065 * data.c (circular_list_error): Remove.
3066
14a9c8df
PE
3067 * commands.h (last_point_position, last_point_position_buffer):
3068 (last_point_position_window): Remove decls.
3069 * keyboard.c: Make these variables static.
3070
04f2d78b
CB
3071 * coding.h (coding, code_convert_region, encode_coding_gap):
3072 Remove decls.
74ab6df5
PE
3073 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3074 (iso_code_class, detect_coding, code_convert_region): Now static.
3075 (encode_coding_gap): Remove; unused.
3076
38dfbee1
PE
3077 * chartab.c (chartab_chars, chartab_bits): Now static.
3078
a2cb4e63
PE
3079 * charset.h (charset_iso_8859_1): Remove decl.
3080 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3081 Now static.
3082
127198fd
PE
3083 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3084 * ccl.c (Vccl_program_table): Now static.
3085 (check_ccl_update): Remove; unused.
3086
d85b608f
PE
3087 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3088 * category.h: ... from here.
3089 * category.c (check_category_table, set_category_set): Now static.
3090
31cd66f3
PE
3091 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3092 * lisp.h: Remove these decls.
3093
c358e587
PE
3094 * buffer.c (buffer_count): Remove unused var.
3095
e78aecca
PE
3096 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3097 so that it's not optimized away.
3098 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3099 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3100 exported only to the debugger.
3101
e192d7d3 3102 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3103 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3104
92470028
PE
3105 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3106 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3107 was inaccessible from Lisp.
3108 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3109 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3110
244ed907
PE
3111 alloc.c: Import and export fewer symbols, and remove unused items.
3112 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3113 is defined.
3114 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3115 it's not optimized away by whole-program optimization.
3116 (message_enable_multibyte, free_misc): Remove.
3117 (catchlist, handlerlist, mark_backtrace):
3118 Declare only if BYTE_MARK_STACK.
3119 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3120 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3121 (message_enable_multibyte): Remove decl.
3122 (free_misc, interval_free_list, float_block, float_block_index):
3123 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3124 (cons_free_list, last_marked_index):
3125 Now static.
3126 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3127 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3128 (mark_backtrace): Define only if BYTE_MARK_STACK.
3129 * xdisp.c (message_enable_multibyte): Now static.
3130
61c2b50e 3131 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3132 This makes it easier for human readers (and static analyzers)
3133 to see whether these variables are used from other modules.
3134 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3135 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3136 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3137 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3138 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3139 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3140 * xmenu.c, xselect.c:
3141 Declare Q* vars static if they are not used in other modules.
3142 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3143 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3144 Remove decls of unexported vars.
3145 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3146
95c82688
PE
3147 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3148
16a97296
PE
3149 Make Emacs functions such as Fatom 'static' by default.
3150 This makes it easier for human readers (and static analyzers)
3151 to see whether these functions can be called from other modules.
3152 DEFUN now defines a static function. To make the function external
3153 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3154 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3155 (Finit_image_library):
16a97296
PE
3156 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3157 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3158 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3159 Remove decls, since these functions are now static.
3160 (Funintern, Fget_internal_run_time): New decls, since these functions
3161 were already external.
95c82688 3162
16a97296
PE
3163 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3164 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3165 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3166 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3167 * keyboard.c, keymap.c, lread.c:
3168 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3169 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3170 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3171 Mark functions with DEFUE instead of DEFUN,
3172 if they are used in other modules.
3173 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3174 decls for now-static functions.
3175 * buffer.h (Fdelete_overlay): Remove decl.
3176 * callproc.c (Fgetenv_internal): Mark as internal.
3177 * composite.c (Fremove_list_of_text_properties): Remove decl.
3178 (Fcomposition_get_gstring): New forward static decl.
3179 * composite.h (Fcomposite_get_gstring): Remove decl.
3180 * dired.c (Ffile_attributes): New forward static decl.
3181 * doc.c (Fdocumntation_property): New forward static decl.
3182 * eval.c (Ffetch_bytecode): New forward static decl.
3183 (Funintern): Remove extern decl; now in .h file where it belongs.
3184 * fileio.c (Fmake_symbolic_link): New forward static decl.
3185 * image.c (Finit_image_library): New forward static decl.
3186 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3187 * intervals.h (Fprevious_property_change):
3188 (Fremove_list_of_text_properties): Remove decls.
3189 * keyboard.c (Fthis_command_keys): Remove decl.
3190 (Fcommand_execute): New forward static decl.
3191 * keymap.c (Flookup_key): New forward static decl.
3192 (Fcopy_keymap): Now static.
3193 * keymap.h (Flookup_key): Remove decl.
3194 * process.c (Fget_process): New forward static decl.
3195 (Fprocess_datagram_address): Mark as internal.
3196 * syntax.c (Fsyntax_table_p): New forward static decl.
3197 (skip_chars): Remove duplicate decl.
3198 * textprop.c (Fprevious_property_change): New forward static decl.
3199 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3200 Now internal.
3201 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3202 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3203
785bbd42
PE
3204 * editfns.c (Fformat): Remove unreachable code.
3205
8b913b57
AS
32062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3207
3208 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3209 change. (Bug#8496)
3210
a6744a35
EZ
32112011-04-13 Eli Zaretskii <eliz@gnu.org>
3212
3213 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3214 when at ZV. (Bug#8487)
3215
e7974947
AS
32162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3217
baad03f0
AS
3218 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3219 (Bug#8437)
3220 * keyboard.c (parse_tool_bar_item): Likewise.
3221 * sound.c (sound_cleanup, alsa_close): Likewise.
3222 * termcap.c (tgetent): Likewise.
3223 * xfns.c (x_default_font_parameter): Likewise.
3224 * xsettings.c (read_and_apply_settings): Likewise.
3225
e7974947
AS
3226 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3227 (overrun_check_free): Protoize.
3228
28272684
PE
32292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3232 since callers should never pass a negative size.
3233 Change the signature to match that of plain 'read' and 'write'; see
3234 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3235 * lisp.h: Update prototypes of emacs_write and emacs_read.
3236
11997c76
EZ
32372011-04-11 Eli Zaretskii <eliz@gnu.org>
3238
3239 * xdisp.c (redisplay_window): Don't try to determine the character
3240 position of the scroll margin if the window start point w->startp
e896f03c 3241 is outside the buffer's accessible region. (Bug#8468)
11997c76 3242
8a2cbd72
EZ
32432011-04-10 Eli Zaretskii <eliz@gnu.org>
3244
3245 Fix write-region and its subroutines for buffers > 2GB.
3246 * fileio.c (a_write, e_write): Modify declaration of arguments and
3247 local variables to support buffers larger than 2GB.
3248 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3249
3250 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3251 argument, local variables, and return value.
3252
3253 * lisp.h: Update prototypes of emacs_write and emacs_read.
3254
3255 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3256
4073e537 32572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3258
1ebfdcb6
PE
3259 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3260
b2ded58d
PE
3261 Fix more problems found by GCC 4.6.0's static checks.
3262
7d66342c
PE
3263 * xdisp.c (vmessage): Use a better test for character truncation.
3264
bbf47d44
PE
3265 * charset.c (load_charset_map): <, not <=, for optimization,
3266 and to avoid potential problems with integer overflow.
9248994d 3267 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3268 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3269 * editfns.c (Fformat): Likewise.
1e69125e 3270 * syntax.c (skip_chars): Likewise.
3befa583 3271
e3019616
PE
3272 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3273 This also lets GCC 4.6.0 generate slightly better loop code.
3274
becfa255
PE
3275 * callint.c (Fcall_interactively): <, not <=, for optimization.
3276 (Fcall_interactively): Count the number of arguments produced,
3277 not the number of arguments given. This is simpler and lets GCC
3278 4.6.0 generate slightly better code.
3279
dae0cd48
PE
3280 * ftfont.c: Distingish more carefully between FcChar8 and char.
3281 The previous code passed unsigned char * to a functions like
3282 strlen and xstrcasecmp that expect char *, which does not
3283 conform to the C standard.
3284 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3285 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3286 char * when the C standard requires it.
3287
76032d70
PE
3288 * keyboard.c (read_char): Remove unused var.
3289
eb3f1cc8
PE
3290 * eval.c: Port to Windows vsnprintf (Bug#8435).
3291 Include <limits.h>.
3292 (SIZE_MAX): Define if the headers do not.
3293 (verror): Do not give up if vsnprintf returns a negative count.
3294 Instead, grow the buffer. This ports to Windows vsnprintf, which
3295 does not conform to C99. Problem reported by Eli Zaretskii.
3296 Also, simplify the allocation scheme, by avoiding the need for
3297 calling realloc, and removing the ALLOCATED variable.
3298
70476b54
PE
3299 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3300
12020a9e
PE
3301 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3302 But keep the doprint source code for now, as we might revamp it
3303 and use it again (Bug#8435).
ea6c7ae6
PE
3304 * lisp.h (doprnt): Remove.
3305 * Makefile.in (base_obj): Remove doprnt.o.
3306 * deps.mk (doprnt.o): Remove.
3307
5fdb398c
PE
3308 error: Print 32- and 64-bit integers portably (Bug#8435).
3309 Without this change, on typical 64-bit hosts error ("...%d...", N)
3310 was used to print both 32- and 64-bit integers N, which relied on
3311 undefined behavior.
3312 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3313 New macro.
3314 * lisp.h (error, verror): Mark as printf-like functions.
3315 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3316 Report overflow in size calculations when allocating printf buffer.
3317 Do not truncate output string at its first null byte.
3318 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3319 Truncate the output at a character boundary, since vsnprintf does not
3320 do that.
3321 * charset.c (check_iso_charset_parameter): Convert internal
3322 character to string before calling 'error', since %c now has the
3323 printf meaning.
3324 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3325 overflow when computing char to be passed to 'error'. Do not
3326 pass Lisp_Object to 'error'; pass the integer instead.
3327 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3328 formatted with plain %d.
3329
b189fa66
PE
3330 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3331
bff87ef0
PE
3332 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3333
7e2cac20
PE
3334 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3335
ce4d90b5
PE
3336 * xterm.c (x_catch_errors): Remove duplicate declaration.
3337
266c9547
PE
3338 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3339
79c49ad2
PE
3340 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3341
368f4090
JM
33422011-04-10 Jim Meyering <meyering@redhat.com>
3343
3344 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3345 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3346 return ssize_t not "int", and use size_t as the buffer length.
3347 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3348 * gnutls.h: Update declarations.
3349 * process.c (read_process_output): Use ssize_t, to match.
3350 (send_process): Likewise.
3351
a32d4040
CY
33522011-04-09 Chong Yidong <cyd@stupidchicken.com>
3353
3354 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3355
8546720e 33562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3357
04f2d78b
CB
3358 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3359 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3360
8546720e
GM
3361 * xterm.c (handle_one_xevent):
3362 * xmenu.c (create_and_show_popup_menu):
3363 * xselect.c (x_decline_selection_request)
3364 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3365
0a2f5c1a 33662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3367
3368 Fix some uses of `int' instead of EMACS_INT.
3369 * search.c (string_match_1, fast_string_match)
3370 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3371 (scan_buffer, find_next_newline_no_quit)
3372 (find_before_next_newline, search_command, Freplace_match)
3373 (Fmatch_data): Make some `int' variables be EMACS_INT.
3374
3375 * xdisp.c (display_count_lines): 3rd argument and return value now
3376 EMACS_INT. All callers changed.
3377 (pint2hrstr): Last argument is now EMACS_INT.
3378
3379 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3380 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3381 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3382 (decode_coding_utf_16, decode_coding_emacs_mule)
3383 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3384 (decode_coding_ccl, decode_coding_charset)
3385 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3386 (decode_coding_iso_2022, decode_coding_emacs_mule)
3387 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3388 <char_offset, last_offset>: Declare EMACS_INT.
3389 (encode_coding_utf_8, encode_coding_utf_16)
3390 (encode_coding_emacs_mule, encode_invocation_designation)
3391 (encode_designation_at_bol, encode_coding_iso_2022)
3392 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3393 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3394 Declare EMACS_INT.
3395 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3396 (encode_invocation_designation): Last argument P_NCHARS is now
3397 EMACS_INT.
3398 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3399 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3400
3401 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3402 All users changed.
3403
3404 * ccl.c (Fccl_execute_on_string): Declare some variables
3405 EMACS_INT.
3406
8546720e 34072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3408
3409 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3410
4e19a977
CS
34112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3412
3413 * process.c (Fformat_network_address): Doc fix.
3414
87302331
R
34152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3416
3417 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3418
cbb59342
CY
34192011-04-08 Chong Yidong <cyd@stupidchicken.com>
3420
3421 * keyboard.c (read_char): Call Lisp function help-form-show,
3422 instead of using internal_with_output_to_temp_buffer.
3423 (Qhelp_form_show): New var.
e0d38eeb 3424 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3425
3426 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3427
3428 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3429
e67a13ab
CY
34302011-04-06 Chong Yidong <cyd@stupidchicken.com>
3431
04f2d78b
CB
3432 * process.c (Flist_processes): Remove to Lisp.
3433 (list_processes_1): Delete.
e67a13ab 3434
973f782d
EZ
34352011-04-06 Eli Zaretskii <eliz@gnu.org>
3436
7c106b1e
EZ
3437 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3438
973f782d
EZ
3439 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3440
41cf7d1a 34412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3442
ca23cc88
PE
3443 Fix more problems found by GCC 4.6.0's static checks.
3444
f390e2d5
PE
3445 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3446
42eea0d0
PE
3447 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3448
b69769da 3449 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3450
f9541e84
PE
3451 * xdisp.c (vmessage): Mark as a printf-like function.
3452
13841b55
PE
3453 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3454
c136c10f
PE
3455 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3456
5e2d4a30
PE
3457 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3458 printf-like functions.
3459 (tiff_load): Add casts to remove these marks before passing them
3460 to system-supplied API.
3461
583f48b9
PE
3462 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3463
b25d760e
PE
3464 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3465 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3466 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3467 directly, rather than having caller test rule sign. This avoids
3468 some unnecessary tests.
3469 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3470 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3471 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3472
bc7b6697 3473 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3474 (xfont_open): Avoid unnecessary tests.
bc7b6697 3475
27ccc379
PE
3476 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3477
dcd5c89a
PE
3478 * composite.h, composite.c (composition_gstring_put_cache):
3479 Use EMACS_INT, not int, for length.
3480
b13a45c6
PE
3481 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3482 breaking out part of COMPOSITION_DECODE_RULE.
3483 (COMPOSITION_DECODE_RULE): Use it.
3484 * composite.c (get_composition_id): Remove unused local vars,
3485 by using the new macro.
3486
1e792e4d
PE
3487 * textprop.c (set_text_properties_1): Change while to do-while,
3488 since the condition is always true at first.
3489
dc6c6455 3490 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3491 (interval_deletion_adjustment): Return unsigned value.
3492 All uses changed.
dc6c6455 3493
aba7731a
PE
3494 * process.c (list_processes_1, create_pty, read_process_output):
3495 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3496 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3497 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3498 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3499 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3500
fdfc4bf3
PE
3501 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3502
fca8fe46 3503 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3504 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3505
06a0259a 3506 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3507 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3508 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3509
e7b9e80f
PE
3510 * print.c (print_error_message): Avoid int overflow.
3511
56201685
PE
3512 * font.c (font_list_entities): Redo for clarity,
3513 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3514
78834453 3515 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3516 (font_score): Avoid potential overflow in diff calculation.
78834453 3517
0bc0b309 3518 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3519 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3520
e610eaca
PE
3521 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3522
b895abce
PE
3523 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3524 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3525 can always succeed if overflow has undefined behavior.
3526
1f1d9321 3527 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3528 (wordify): Omit three unnecessary tests.
1f1d9321 3529
c59478bc
PE
3530 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3531 All callers changed. This avoids the need for an unused var.
3532
79b73827
PE
3533 * casefiddle.c (casify_region): Remove var that is set but not used.
3534
a4db5dfe
PE
3535 * dired.c (file_name_completion): Remove var that is set but not used.
3536
43aae36e
PE
3537 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3538
2a47c44d 3539 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3540 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3541
a37c69bf
PE
3542 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3543 Check for integer overflow on size calculations.
3544
328ab8e7
PE
3545 * buffer.c (Fprevious_overlay_change): Remove var that is set
3546 but not used.
3547
e5a2a5cb
PE
3548 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3549 Remove vars that are set but not used.
8d84a6eb 3550 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3551 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3552
a60e5f68
PE
3553 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3554
f661cb61 3555 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3556 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3557
f0397f5a
PE
3558 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3559 that are set but not used.
3560
8664db06 3561 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3562 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3563
6abdaa4a
PE
3564 * xselect.c (x_get_local_selection, x_handle_property_notify):
3565 Remove vars that are set but not used.
3566
0ce7538d 3567 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3568 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3569
9ae848fc
PE
3570 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3571 Remove var that is set but not used.
0b918413
PE
3572 (scroll_bar_windows_size): Now size_t, not int.
3573 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3574 Check for overflow.
9ae848fc 3575
a5a62657
PE
3576 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3577 (map_tty_color) [!defined MSDOS]: Likewise.
3578
5c5cdd39
PE
3579 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3580
66ebf983
PE
3581 * coding.c: Remove vars that are set but not used.
3582 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3583 All callers changed.
3584 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3585 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3586 (decode_coding_charset): Remove vars that are set but not used.
3587
1be4d761
PE
3588 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3589 that is set but not used.
3590
47553fa8
PE
3591 * print.c (print_object): Remove var that is set but not used.
3592
1f7196bf 3593 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3594 The gnulib version avoids calling malloc in the usual case,
3595 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3596 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3597 * filelock.c (current_lock_owner): Likewise.
3598 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3599 * sysdep.c: Include allocator.h, careadlinkat.h.
3600 (emacs_no_realloc_allocator): New static constant.
3601 (emacs_readlink): New function.
fdb61804
PE
3602 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3603 ../lib/careadlinkat.h.
d1fdcab7 3604
f84c17c7
SM
36052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3606
3607 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3608 first non-nil return value).
3609
ef3862ad
JD
36102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3611
3612 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3613 if not defined (Bug#8403).
3614
376a7006
JB
36152011-04-02 Juanma Barranquero <lekktu@gmail.com>
3616
3617 * xdisp.c (display_count_lines): Remove parameter `start',
3618 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3619 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3620 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3621 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3622 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3623 and thereabouts. All callers changed.
3624 (get_per_char_metric): Remove parameter `f', unused since
3625 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3626
6ca3801d
JM
36272011-04-02 Jim Meyering <meyering@redhat.com>
3628
3629 do not dereference NULL upon failed strdup
3630 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3631 (ns_get_family): Likewise.
3632
d8e2b5ba
JB
36332011-04-02 Juanma Barranquero <lekktu@gmail.com>
3634
3635 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3636
8c74fcbd
JD
36372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3638
3639 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3640 later (Bug#8403).
3641
7200d79c
SM
36422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3643
03408648 3644 Add lexical binding.
7200d79c 3645
03408648
SM
3646 * window.c (Ftemp_output_buffer_show): New fun.
3647 (Fsave_window_excursion):
3648 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3649
3650 * lread.c (lisp_file_lexically_bound_p): New function.
3651 (Fload): Bind Qlexical_binding.
3652 (readevalloop): Remove `evalfun' arg.
3653 Bind Qinternal_interpreter_environment.
3654 (Feval_buffer): Bind Qlexical_binding.
3655 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3656 Mark as dynamic.
3657 (syms_of_lread): Declare `lexical-binding'.
3658
3659 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3660
3661 * keyboard.c (eval_dyn): New fun.
3662 (menu_item_eval_property): Use it.
ca105506
SM
3663
3664 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3665
03408648
SM
3666 * fns.c (concat, mapcar1): Accept byte-code-functions.
3667
3668 * eval.c (Fsetq): Handle lexical vars.
3669 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3670 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3671 (FletX, Flet): Obey lexical binding.
3672 (Fcommandp): Handle closures.
3673 (Feval): New `lexical' arg.
3674 (eval_sub): New function extracted from Feval. Use it almost
3675 everywhere where Feval was used. Look up vars in lexical env.
3676 Handle closures.
3677 (Ffunctionp): Move from subr.el.
3678 (Ffuncall): Handle closures.
3679 (apply_lambda): Remove `eval_flags'.
3680 (funcall_lambda): Handle closures and new byte-code-functions.
3681 (Fspecial_variable_p): New function.
3682 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3683 but without exporting it to Lisp.
23aba0ea 3684
23aba0ea 3685 * doc.c (Fdocumentation, store_function_docstring):
03408648 3686 * data.c (Finteractive_form): Handle closures.
23aba0ea 3687
03408648
SM
3688 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3689 interactive spec.
ba83908c 3690
04f2d78b
CB
3691 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3692 New byte-codes.
03408648
SM
3693 (exec_byte_code): New function extracted from Fbyte_code to handle new
3694 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3695
03408648 3696 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3697
03408648 3698 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3699
e2abce01
JB
37002011-03-31 Juanma Barranquero <lekktu@gmail.com>
3701
3702 * xdisp.c (redisplay_internal): Fix prototype.
3703
63696a73 37042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3705
63696a73 3706 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3707 (try_scrolling): Use it when setting scroll_limit.
3708 Limit scrolling to 100 screen lines.
63696a73
EZ
3709 (redisplay_window): Even when falling back on "recentering",
3710 position point in the window according to scroll-conservatively,
3711 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3712
3713 (try_scrolling): When point is above the window, allow searching
3714 as far as scroll_max, or one screenful, to compute vertical
3715 distance from PT to the scroll margin position. This prevents
3716 try_scrolling from unnecessarily failing when
3717 scroll-conservatively is set to a value slightly larger than the
3718 window height. Clean up the case of PT below the margin at bottom
3719 of window: scroll_max can no longer be INT_MAX. When aggressive
3720 scrolling is in use, don't let point enter the opposite scroll
3721 margin as result of the scroll.
3722 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3723 threshold of 100 lines for never-recentering scrolling.
3724
e4cc2dfc
JB
37252011-03-31 Juanma Barranquero <lekktu@gmail.com>
3726
3727 * dispextern.h (move_it_by_lines):
3728 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3729 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3730 (message_log_check_duplicate): Remove parameters `prev_bol' and
3731 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3732 (redisplay_internal): Remove parameter `preserve_echo_area',
3733 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3734
3735 * indent.c (Fvertical_motion):
3736 * window.c (window_scroll_pixel_based, Frecenter):
3737 Don't pass `need_y_p' to `move_it_by_lines'.
3738
1c470562
SM
37392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3740
44f230aa
SM
3741 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3742 steal a few bits to be more compact.
3743 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3744 Remove unneeded casts.
3745
1c470562
SM
3746 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3747
888adce9
ZK
37482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3749
3750 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3751 binding" message (bug#7967).
3752
f838ed7b
PE
37532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3754
77861b95
PE
3755 Fix more problems found by GCC 4.6.0's static checks.
3756
de6dbc14
PE
3757 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3758 Remove unused local var.
3759
f838ed7b
PE
3760 * editfns.c (Fmessage_box): Remove unused local var.
3761
792c7b2b
PE
3762 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3763 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3764 Omit unused local vars.
c499e557 3765 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3766 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3767 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3768 Omit unused local var.
3769
ba0165e1
PE
3770 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3771 Don't assume string length fits in int.
32ad8845 3772 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3773 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3774
3c59b4c9
PE
3775 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3776 instead of alloca (Bug#8344).
3777
a3eed478 3778 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3779 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3780
eb4d412d
PE
3781 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3782
1658b401
PE
3783 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3784 concerns.
3785
3786 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3787
3788 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3789
9a2c6e05
PE
3790 * keyboard.c (syms_of_keyboard): Use the same style as later
3791 in this function when indexing through an array. This also
3792 works around GCC bug 48267.
3793
03d0a109
PE
3794 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3795
44f730c8
PE
3796 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3797
fe75f926
PE
3798 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3799 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3800
ffa8c828
PE
3801 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3802 This avoids undefined behavior on integer overflow, and is a bit
3803 more convenient anyway since it is compared to a size_t variable.
3804
c5101a77
PE
3805 Variadic C functions now count arguments with size_t, not int.
3806 This avoids an unnecessary limitation on 64-bit machines, which
3807 caused (substring ...) to crash on large vectors (Bug#8344).
3808 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3809 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3810 All variadic functions and their callers changed accordingly.
c5101a77
PE
3811 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3812 * data.c (arith_driver, float_arith_driver): Likewise.
3813 * editfns.c (general_insert_function): Likewise.
3814 * eval.c (struct backtrace.nargs, interactive_p)
3815 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3816 (funcall_lambda, mark_backtrace): Likewise.
3817 * fns.c (concat): Likewise.
3818 * frame.c (x_set_frame_parameters): Likewise.
3819 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3820 0 if not found, not -1. All callers changed.
3821
dd3f25f7
PE
3822 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3823 (stack_copy_size): Now size_t, not int.
3824 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3825
461c2ab9
JB
38262011-03-28 Juanma Barranquero <lekktu@gmail.com>
3827
3828 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3829 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3830 All callers changed.
3831
3832 * lisp.h (multibyte_char_to_unibyte):
3833 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3834 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3835 * character.h (CHAR_TO_BYTE8):
3836 * cmds.c (internal_self_insert):
3837 * editfns.c (general_insert_function):
3838 * keymap.c (push_key_description):
3839 * search.c (Freplace_match):
3840 * xdisp.c (message_dolog, set_message_1): All callers changed.
3841
f6d62986
SM
38422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3843
3844 * keyboard.c (safe_run_hook_funcall): New function.
3845 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3846 don't set the hook to nil, but remove the offending function instead.
3847 (Qcommand_hook_internal): Remove, unused.
3848 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3849 Vcommand_hook_internal.
3850
3851 * eval.c (enum run_hooks_condition): Remove.
3852 (funcall_nil, funcall_not): New functions.
3853 (run_hook_with_args): Call each function through a `funcall' argument.
3854 Remove `cond' argument, now redundant.
3855 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3856 (Frun_hook_with_args_until_failure): Adjust accordingly.
3857 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3858
1db5b1ad
JB
38592011-03-28 Juanma Barranquero <lekktu@gmail.com>
3860
3861 * dispextern.h (string_buffer_position): Remove declaration.
3862
3863 * print.c (strout): Remove parameter `multibyte', unused since
3864 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3865
3866 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3867 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3868 All callers changed.
3869
3870 * w32.c (_wsa_errlist): Use braces for struct initializers.
3871
3872 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3873 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3874 All callers changed.
3875 (string_buffer_position): Likewise. Also, make static (it's never
3876 used outside xdisp.c).
3877 (cursor_row_p): Remove parameter `w', unused since
3878 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3879 (decode_mode_spec): Remove parameter `precision', introduced during
3880 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3881 All callers changed.
3882
5ffb62aa
JD
38832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3884
3885 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3886
461c2ab9 38872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3888
3889 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3890 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3891 (ns_update_auto_hide_menu_bar): New functions.
3892 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3893 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3894 ns_constrain_all_frames.
3895 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3896 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3897
5c380ffb
JD
38982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3899
3900 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3901
9af30bdf
GM
39022011-03-27 Glenn Morris <rgm@gnu.org>
3903
3904 * syssignal.h: Replace RETSIGTYPE with void.
3905 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3906 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3907 Replace SIGTYPE with void everywhere.
3908 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3909 * s/template.h (SIGTYPE): Remove commented out definition.
3910
e2abce01
JB
39112011-03-26 Eli Zaretskii <eliz@gnu.org>
3912
3913 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3914 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3915
f868cd8a
JB
39162011-03-26 Juanma Barranquero <lekktu@gmail.com>
3917
59eb0929
JB
3918 * w32.c (read_unc_volume): Use parameter `henum', instead of
3919 global variable `wget_enum_handle'.
3920
3921 * keymap.c (describe_vector): Remove parameters `indices' and
3922 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3923 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3924
f868cd8a
JB
3925 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3926
3927 * keyboard.c (timer_check): Remove parameter `do_it_now',
3928 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3929 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3930 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3931
3932 * keyboard.c (read_char):
3933 * w32menu.c (w32_menu_display_help):
3934 * xmenu.c (show_help_event, menu_help_callback):
3935 Adjust calls to `show_help_echo'.
3936
3937 * gtkutil.c (xg_maybe_add_timer):
3938 * keyboard.c (readable_events):
3939 * process.c (wait_reading_process_output):
3940 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3941
3942 * insdel.c (adjust_markers_gap_motion):
3943 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3944 (gap_left, gap_right): Don't call it.
3945
2ecf6fdb
CY
39462011-03-25 Chong Yidong <cyd@stupidchicken.com>
3947
3948 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3949 incurred during fontification.
3950
6b1f9ba4
JB
39512011-03-25 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3954 (DEFVAR_PER_BUFFER): Don't pass it.
3955
3956 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3957 (scrolling_window): Don't pass it.
3958
0f4a96b5
JB
39592011-03-25 Juanma Barranquero <lekktu@gmail.com>
3960
3961 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3962
3963 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3964 and `suffix'.
3965 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3966 of variables specific to SELinux and computation of `encoded_absname'.
3967
3968 * image.c (XPutPixel): Remove unused variable `height'.
3969
3970 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3971
3972 * unexw32.c (get_section_info): Remove unused variable `section'.
3973
3974 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3975 (system_process_attributes): Remove unused variable `sess'.
3976 (sys_read): Remove unused variable `err'.
3977
3978 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3979 (w32_wnd_proc): Remove unused variable `isdead'.
3980 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3981 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3982 (x_create_tip_frame): Remove unused variable `tem'.
3983
3984 * w32inevt.c (w32_console_read_socket):
3985 Remove unused variable `no_events'.
3986
3987 * w32term.c (x_draw_composite_glyph_string_foreground):
3988 Remove unused variable `width'.
3989
1149507c
JB
39902011-03-24 Juanma Barranquero <lekktu@gmail.com>
3991
3992 * w32term.c (x_set_glyph_string_clipping):
3993 Don't pass uninitialized region to CombineRgn.
3994
9c88f339
JB
39952011-03-23 Juanma Barranquero <lekktu@gmail.com>
3996
3997 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3998 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3999 (Fx_close_connection): Remove unused variable `i'.
4000
4001 * w32font.c (w32font_draw): Return number of glyphs.
4002 (w32font_open_internal): Remove unused variable `i'.
4003 (w32font_driver): Add missing initializer.
4004
4005 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4006 (fill_in_menu): Remove unused variable `items_added'.
4007
4008 * w32term.c (last_mouse_press_frame): Remove static global variable.
4009 (w32_clip_to_row): Remove unused variable `f'.
4010 (x_delete_terminal): Remove unused variable `i'.
4011
4012 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4013 (NOTHING): Remove unused static global variable.
4014 (uniscribe_check_otf): Remove unused variable `table'.
4015 (uniscribe_font_driver): Add missing initializers.
4016
dee091a3
JD
40172011-03-23 Julien Danjou <julien@danjou.info>
4018
4019 * term.c (Fsuspend_tty, Fresume_tty):
4020 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4021 * window.c (temp_output_buffer_show):
4022 * insdel.c (signal_before_change):
4023 * frame.c (Fhandle_switch_frame):
4024 * fileio.c (Fdo_auto_save):
4025 * emacs.c (Fkill_emacs):
4026 * editfns.c (save_excursion_restore):
4027 * cmds.c (internal_self_insert):
4028 * callint.c (Fcall_interactively):
4029 * buffer.c (Fkill_all_local_variables):
4030 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4031 Use Frun_hooks.
0f4a96b5 4032 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4033 unconditionnaly since it does the check itself.
4034
2c520ab5 40352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4036
c9c49752
PE
4037 Fix more problems found by GCC 4.5.2's static checks.
4038
8abc3f12
PE
4039 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4040 the first time through the loop, since we know p0 < p1 then.
4041 This also avoids a gcc -Wstrict-overflow warning.
4042
a2d26660
PE
4043 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4044 leading to a memory leak, possible in functions like
4045 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4046 of objects (Bug#8318).
a2d26660 4047
916c72e9
PE
4048 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4049 that could (at least in theory) be that large.
4050
19ab8a18
PE
4051 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4052 This is less likely to overflow, and avoids undefined behavior if
4053 overflow does occur. All callers changed. Use strtoul to scan
4054 for the unsigned long integer.
b7cbbd6f
PE
4055 (pint2hrstr): Simplify and tune code slightly.
4056 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4057
f0641eff
PE
4058 * scroll.c (do_scrolling): Work around GCC bug 48228.
4059 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4060
7f650bb9
PE
4061 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4062 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4063 (validate_x_resource_name): Simplify count usage.
4064 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4065
37dd57d1
PE
4066 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4067 fail (Bug#8306).
81e56e61 4068
699979fc 4069 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4070
401bf9b4
PE
4071 * process.c (Fmake_network_process): Use socklen_t, not int,
4072 where POSIX says socklen_t is required in portable programs.
4073 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4074 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4075 (Fmake_network_process, server_accept_connection):
4076 (wait_reading_process_output, read_process_output):
4077 Likewise.
4078
b93aacde
PE
4079 * process.c: Rename or move locals to avoid shadowing.
4080 (list_processes_1, Fmake_network_process):
4081 (read_process_output_error_handler, exec_sentinel_error_handler):
4082 Rename or move locals.
4dc343ee 4083 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4084 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4085 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4086 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4087 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4088
af8a867c 4089 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4090 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4091 Include tparam.h instead, since it declares them.
af8a867c
PE
4092 * cm.h (PC): Remove extern decl; tparam.h now does this.
4093 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4094 * terminfo.c: Include tparam.h, to check interfaces.
4095 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4096 (tparam): Adjust signature to match interface in tparam.h;
4097 this removes some undefined behavior. Check that outstring and len
4098 are zero, which they always are with Emacs.
4099 * tparam.h (PC, BC, UP): New extern decls.
4100
0248044d 4101 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4102 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4103
8ff096c1 4104 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4105 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4106 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4107 (ftfont_list): Remove unused local.
49eaafba
PE
4108 (get_adstyle_property, ftfont_pattern_entity):
4109 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4110 Rename locals to avoid shadowing.
8ff096c1 4111
e2be39f6
PE
4112 * xfont.c (xfont_list_family): Mark var as initialized.
4113
c9735e30
PE
4114 * xml.c (make_dom): Now static.
4115
8f5201ae
PE
4116 * composite.c (composition_compute_stop_pos): Rename local to
4117 avoid shadowing.
b246f932
PE
4118 (composition_reseat_it): Remove unused locals.
4119 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4120 (composition_update_it): Mark var as initialized.
11b61122
PE
4121 (find_automatic_composition): Mark vars as initialized,
4122 with a FIXME (Bug#8290).
8f5201ae 4123
760fbc2c
PE
4124 character.h: Rename locals to avoid shadowing.
4125 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4126 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4127 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4128 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4129 to avoid shadowing.
4130
ff08eb85
PE
4131 * textprop.c (property_change_between_p): Remove; unused.
4132
fc7bf025
PE
4133 * intervals.c (interval_start_pos): Now static.
4134
235d7abc
PE
4135 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4136
44f230aa
SM
4137 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4138 Rename locals to avoid shadowing.
3e7d6594 4139
50060332
PE
4140 * sound.c (wav_play, au_play, Fplay_sound_internal):
4141 Fix pointer signedness.
d01f234b 4142 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4143 (wav_play): Initialize a variable to 0, to prevent undefined
4144 behavior (Bug#8278).
50060332 4145
c4fc4e30
PE
4146 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4147
918436ed
PE
4148 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4149
c939f91b
PE
4150 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4151 clobbering (Bug#8298).
b9c7f648
PE
4152 * sysdep.c (sys_subshell): Likewise.
4153 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4154
6bd8c144
PE
4155 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4156 This should get cleaned up, so that child_setup has the
4157 same signature on all platforms.
4158
7710357c 4159 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4160 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4161
c59da222
CY
41622011-03-22 Chong Yidong <cyd@stupidchicken.com>
4163
4164 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4165 not to be necessary, and produces flickering.
4166
66b87493
GM
41672011-03-20 Glenn Morris <rgm@gnu.org>
4168
4169 * config.in: Remove file.
4170
45b6f6d5
JB
41712011-03-20 Juanma Barranquero <lekktu@gmail.com>
4172
4173 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4174 are now in src/globals.h.
4175 (syms_of_minibuf): Remove spurious & from previous change.
4176
3ec03f7e
LL
41772011-03-20 Leo <sdl.web@gmail.com>
4178
4179 * minibuf.c (completing-read-function): New variable.
4180 (completing-read-default): Rename from completing-read.
4181 (completing-read): Call completing-read-function.
4182
b14e3e21
CY
41832011-03-19 Juanma Barranquero <lekktu@gmail.com>
4184
4185 * xfaces.c (Fx_load_color_file):
4186 Read color file from absolute filename (bug#8250).
4187
f2b726e6
JB
41882011-03-19 Juanma Barranquero <lekktu@gmail.com>
4189
4190 * makefile.w32-in: Update dependencies.
4191
09f6ff02
EZ
41922011-03-17 Eli Zaretskii <eliz@gnu.org>
4193
4194 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4195
29a6015a
PE
41962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4197
a3a6c54e
PE
4198 Fix more problems found by GCC 4.5.2's static checks.
4199
b766f867
PE
4200 * process.c (make_serial_process_unwind, send_process_trap):
4201 (sigchld_handler): Now static.
4202
be02381c
PE
4203 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4204 That way, the code declares only the vars that it needs.
4205 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4206 * s/cygwin.h (PTY_ITERATION): Likewise.
4207 * s/darwin.h (PTY_ITERATION): Likewise.
4208 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4209
57048744
PE
4210 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4211 * process.c (allocate_pty): Don't declare stb unless it's needed.
4212
7914961c 4213 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4214 (CONSTANTLIM): Remove; unused.
4215 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4216 Define only if needed.
7914961c 4217
b3967b18
PE
4218 * unexelf.c (unexec): Name an expression,
4219 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4220 Use a different way to cause a compilation error if anyone uses
4221 n rather than nn, a way that does not involve shadowing.
73366a00 4222 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4223
29a6015a
PE
4224 * deps.mk (unexalpha.o): Remove; unused.
4225
43cfc33e 4226 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4227 * unexec.h: New file.
ce701a33
PE
4228 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4229 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4230 Depend on unexec.h.
4231 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4232 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4233 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4234 Change as necessary to match prototype in unexec.h.
ce701a33 4235
01f44d5a
PE
4236 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4237 shadowing.
4f63c6bb 4238 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4239
a6670b0b
PE
4240 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4241 Rename locals to avoid shadowing.
4242
cef2010d 4243 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4244 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4245
d4d7173a
PE
4246 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4247
f08b802a
PE
4248 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4249 warning when compiling print.c.
4250
3ddb0639
PE
4251 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4252 instead of using an uninitialized var.
5ad03b97 4253 (font_sort_entities): Mark var as initialized.
3ddb0639 4254
170a2692
PE
4255 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4256
e663c700
PE
4257 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4258 pointers to constants.
89bc529a 4259 (font_parse_fcname): Remove unused vars.
7b81e2d0 4260 (font_delete_unmatched): Now static.
ea838e10 4261 (font_get_spec): Remove; unused.
13a547c6
PE
4262 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4263 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4264 Rename or move locals to avoid shadowing.
e663c700 4265
2a80c887 4266 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4267 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4268
1384fa33 4269 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4270 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4271
8b2c52e9
PE
4272 * alloc.c (mark_backtrace): Move decl from here ...
4273 * lisp.h: ... to here, so that it can be checked.
4274
475545b5 4275 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4276 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4277 (lisp_indirect_variable): Name an expression,
4278 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4279 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4280
b1349114 4281 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4282 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4283 Use const pointer when appropriate.
b1349114 4284
a2928364
PE
4285 * lisp.h (get_system_name, get_operating_system_release):
4286 Move decls here, to check interfaces.
4287 * process.c (get_operating_system_release): Move decl to lisp.h.
4288 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4289 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4290 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4291 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4292 (Fformat_time_string, Fencode_time, Finsert_char):
4293 (Ftranslate_region_internal, Fformat):
4294 Rename or remove local vars to avoid shadowing.
9710023e 4295 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4296
a415e694
PE
4297 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4298 avoid shadowing.
4299
8ef4622d
PE
4300 * lisp.h (eassert): Check that the argument compiles, even if
4301 ENABLE_CHECKING is not defined.
4302
946f9a5b
PE
4303 * data.c (Findirect_variable): Name an expression, to avoid
4304 gcc -Wbad-function-cast warning.
112396d6 4305 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4306 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4307 (Fmake_variable_buffer_local, Fmake_local_variable):
4308 Mark variables as initialized.
52746918 4309 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4310
e5aab7e7 4311 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4312 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4313 Rename locals to avoid shadowing.
dff45157
PE
4314 (mark_stack): Move local variables into the #ifdef region where
4315 they're used.
7bc26fdb
PE
4316 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4317 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4318 needed otherwise.
4319 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4320 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4321 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4322
e5aab7e7
PE
4323 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4324 avoids undefined behavior in theory.
4325
4da60324
PE
4326 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4327
88043301
PE
4328 Use functions, not macros, for up- and down-casing (Bug#8254).
4329 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4330 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4331 to use the following functions instead of these macros.
4332 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4333 EMACS_INT, since callers assume the returned value fits in int.
4334 (upcase1): Likewise, for UPCASE_TABLE.
4335 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4336 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4337 the race-condition problem in the old DOWNCASE.
88043301 4338
19ed5445
PE
4339 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4340 Rename locals to avoid shadowing.
4341 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4342 (regex_compile, re_search_2, re_match_2_internal):
4343 Remove unused local vars.
952db0d7
PE
4344 (FREE_VAR): Rewrite so as not to use empty "else",
4345 which gcc can warn about.
da053e48 4346 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4347 (RETALLOC_IF): Define only if needed.
4348 (WORDCHAR_P): Likewise. This one is never needed, but is used
4349 only in a comment talking about a compiler bug, so put inside
4350 the #if 0 of that comment.
4351 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4352 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4353 Remove; unused.
19ed5445 4354
1f3561e4 4355 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4356 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4357 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4358
ded6f8f7
PE
4359 * search.c (simple_search): Remove unused var.
4360
dbd37a95
PE
4361 * dired.c (compile_pattern): Move decl from here ...
4362 * lisp.h: ... to here, so that it can be checked.
4363 (struct re_registers): New forward decl.
4364
7e47afad
PE
4365 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4366
85f24f61
PE
4367 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4368 All uses changed.
4369 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4370 Rename locals to avoid shadowing.
5671df8f 4371 (Fvertical_motion): Mark locals as initialized.
85f24f61 4372
181aa2be 4373 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4374 (casify_region): Mark local as initialized.
181aa2be 4375
930d429c
PE
4376 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4377
7082eac6
PE
4378 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4379 New macros, so that the caller can use some names other than
4380 gcpro1, gcpro2, etc.
4381 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4382 of the new macros.
4383 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4384 argument, for consistency with GCPRO2_VAR, etc: it is now the
4385 prefix of the variable, not the variable itself. All uses
4386 changed.
38b2c076
PE
4387 * dired.c (directory_files_internal, file_name_completion):
4388 Rename locals to avoid shadowing.
4389
15206ed9
PE
4390 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4391 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4392 dired.c's scmp function, had undefined behavior.
4393 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4394 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4395 * buffer.h: ... to here, because these macros use current_buffer,
4396 and the new implementation with inline functions needs to have
4397 current_buffer in scope now, rather than later when the macros
4398 are used.
4399 (downcase, upcase1): New static inline functions.
4400 (DOWNCASE, UPCASE1): Reimplement using these functions.
4401 This avoids undefined behavior in expressions like
4402 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4403 from race conditions in accessing the global variables
4404 case_temp1 and case_temp2.
4405 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4406 * lisp.h (case_temp1, case_temp2): Remove their decls.
4407 * character.h (ASCII_CHAR_P): Move from here ...
4408 * lisp.h: ... to here, so that the inline functions mentioned
4409 above can use them.
4410
4a6bea26
PE
4411 * dired.c (directory_files_internal_unwind): Now static.
4412
f14b7e14
PE
4413 * fileio.c (file_name_as_directory, directory_file_name):
4414 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4415 Now static.
2893f146
PE
4416 (file_name_as_directory): Use const pointers when appropriate.
4417 (Fexpand_file_name): Likewise. In particular, newdir might
4418 point at constant storage, so make it a const pointer.
fd4ead52 4419 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4420 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4421 signedness issues.
f839df0c
PE
4422 (Fset_file_times, Finsert_file_contents, auto_save_error):
4423 Rename locals to avoid shadowing.
f14b7e14 4424
5716756e 4425 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4426 (Ftry_completion, Fall_completions): Rename or remove locals
4427 to avoid shadowing.
5716756e 4428
b4c3046a
PE
4429 * marker.c (bytepos_to_charpos): Remove; unused.
4430
b45db522
PE
4431 * lisp.h (verify_bytepos, count_markers): New decls,
4432 so that gcc does not warn that these functions aren't declared.
4433
85876d07
PE
4434 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4435 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4436 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4437 (copy_text): Remove unused local var.
85876d07 4438
03d78a21 4439 * filelock.c (within_one_second): Now static.
b3dd38ab 4440 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4441
5df8f01b
PE
4442 * buffer.c (fix_overlays_before): Mark locals as initialized.
4443 (fix_start_end_in_overlays): Likewise. This function should be
4444 simplified by using pointers-to-pointers, but that's a different
4445 matter.
b1d876f1 4446 (switch_to_buffer_1): Now static.
8f54f30a
PE
4447 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4448 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4449
a70072c9 4450 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4451 Fix pointer signedness issue.
edced198
PE
4452 (sys_subshell): Mark local as volatile if checking for lint,
4453 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4454 (MAXPATHLEN): Define only if needed.
a70072c9 4455
a0977c44
PE
4456 * process.c (serial_open, serial_configure): Move decls from here ...
4457 * systty.h: ... to here, so that they can be checked.
4458
a884fdcc
PE
4459 * fns.c (get_random, seed_random): Move extern decls from here ...
4460 * lisp.h: ... to here, so that they can be checked.
4461
604efe86 4462 * sysdep.c (reset_io): Now static.
b8950c94 4463 (wait_for_termination_signal): Remove; unused.
604efe86 4464
38fc62d9
PE
4465 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4466 (copy_keymap_item, append_key, push_text_char_description):
4467 Now static.
1004a21a 4468 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4469 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4470 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4471 (describe_map_tree):
4472 Rename locals to avoid shadowing.
38fc62d9 4473
2f2650da
PE
4474 * keyboard.c: Declare functions static if they are not used elsewhere.
4475 (echo_char, echo_dash, cmd_error, top_level_2):
4476 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4477 (read_char, kbd_buffer_get_event, make_lispy_position):
4478 (make_lispy_event, make_lispy_movement, apply_modifiers):
4479 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4480 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4481 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4482 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4483 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4484
a053e86c 4485 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4486 (mark_kboards): Move decl here ...
4487 * alloc.c (mark_kboards): ... from here.
a053e86c 4488
4752793e
PE
4489 * lisp.h (force_auto_save_soon): New decl.
4490
74f10ca7 4491 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4492 (DEFINE_DUMMY_FUNCTION): New macro.
4493 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4494 Use it.
c03cd23f
PE
4495 (main): Add casts to avoid warnings
4496 if GCC considers string literals to be constants.
74f10ca7 4497
022e70d4
PE
4498 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4499
59d6fe83
PE
4500 * dbusbind.c: Pointer signedness fixes.
4501 (xd_signature, xd_append_arg, xd_initialize):
4502 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4503 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4504 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4505 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4506
78320123
PE
4507 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4508 if GCC considers string literals to be constants.
49cebcca 4509 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4510
35ac2a97
SM
45112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4512
fb103ca9
SM
4513 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4514 (print_preprocess, print_object): New macro to fix last change.
4515
35ac2a97
SM
4516 * print.c (print_preprocess): Don't forget font objects.
4517
62973b41
JB
45182011-03-16 Juanma Barranquero <lekktu@gmail.com>
4519
4520 * emacs.c (USAGE3): Doc fixes.
4521
0e48bb22
AS
45222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4523
4524 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4525 structure.
4526
7684e57b
JB
45272011-03-14 Juanma Barranquero <lekktu@gmail.com>
4528
4529 * lisp.h (VWindow_system, Qfile_name_history):
4530 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4531 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4532 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4533
4534 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4535 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4536
4537 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4538 * w32console.c (detect_input_pending, read_input_pending)
4539 (encode_terminal_code):
4540 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4541 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4542 (w32_system_caret_y, Qfile_name_history):
4543 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4544 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4545 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4546 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4547 * w32proc.c (Qlocal, report_file_error):
4548 * w32term.c (Vwindow_system, updating_frame):
4549 * w32uniscribe.c (initialized, uniscribe_font_driver):
4550 Remove unneeded extern declarations.
4551
2aa46d6c
CY
45522011-03-14 Chong Yidong <cyd@stupidchicken.com>
4553
c96bbc66 4554 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4555
cffc6f3b
CY
45562011-03-13 Chong Yidong <cyd@stupidchicken.com>
4557
4558 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4559 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4560 These macros can no longer be used for assignment.
4561
44f230aa
SM
4562 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4563 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4564 (record_buffer_markers, fetch_buffer_markers): New functions for
4565 recording and fetching special buffer markers.
4566 (set_buffer_internal_1, set_buffer_temp): Use them.
4567
4568 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4569
4570 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4571
4572 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4573 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4574
4575 * xdisp.c (hscroll_window_tree):
4576 (reconsider_clip_changes): Use PT instead of BUF_PT.
4577
d251f04b
EZ
45782011-03-13 Eli Zaretskii <eliz@gnu.org>
4579
4580 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4581 $(EMACS_ROOT)/lib/intprops.h.
4582
f0c77cd1
PE
45832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4584
3eca4629
PE
4585 Fix more problems found by GCC 4.5.2's static checks.
4586
7c86ee98
PE
4587 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4588 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4589 (xg_free_frame_widgets): Make it clear that a local variable is
4590 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4591 (gdk_window_get_screen): Make it clear that this macro is needed
4592 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4593 (int_gtk_range_get_value): New function, which avoids a diagnostic
4594 from gcc -Wbad-function-cast.
4595 (xg_set_toolkit_scroll_bar_thumb): Use it.
4596 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4597 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4598 (get_utf8_string, xg_get_file_with_chooser):
4599 Rename locals to avoid shadowing.
4600 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4601
41729b81
PE
4602 * xgselect.c (xg_select): Remove unused var.
4603
f0c77cd1
PE
4604 * image.c (four_corners_best): Mark locals as initialized.
4605 (gif_load): Initialize transparent_p to zero (Bug#8238).
4606 Mark another local as initialized.
ec6cf4c6 4607 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4608
ce0ad53d 4609 * image.c (clear_image_cache): Now static.
d5d5a617 4610 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4611 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4612 (x_edge_detection): Remove unnecessary cast that
4613 gcc -Wbad-function-cast diagnoses.
2037898d 4614 (gif_load): Fix pointer signedness.
6ae141d6
PE
4615 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4616 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4617
33383987 46182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4619
d32df629
PE
4620 Improve quality of tests for time stamp overflow.
4621 For example, without this patch (encode-time 0 0 0 1 1
4622 1152921504606846976) returns the obviously-bogus value (-948597
4623 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4624 reports time overflow. See
4625 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4626 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4627 * editfns.c: Include limits.h and intprops.h.
4628 (TIME_T_MIN, TIME_T_MAX): New macros.
4629 (time_overflow): Move earlier, to before first use.
4630 (hi_time, lo_time): New functions, for an accurate test for
4631 out-of-range times.
4632 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4633 (Fget_internal_run_time): Don't assume time_t fits in int.
4634 (make_time): Use list2 instead of Fcons twice.
4635 (Fdecode_time): More accurate test for out-of-range times.
4636 (check_tm_member): New function.
4637 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4638 (lisp_time_argument): Don't rely on undefined left-shift and
4639 right-shift behavior when checking for time stamp overflow.
8be6f318 4640
fe31d94c
PE
4641 * editfns.c (time_overflow): New function, refactoring common code.
4642 (Fformat_time_string, Fdecode_time, Fencode_time):
4643 (Fcurrent_time_string): Use it.
4644
8be6f318
PE
4645 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4646 * dired.c (make_time): Move to ...
4647 * editfns.c (make_time): ... here.
4648 * systime.h: Note the move.
4649
09d9db2c 46502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4651
126bc0dc
YM
4652 * fringe.c (update_window_fringes): Remove unused variables.
4653
c47cbdfd
YM
4654 * unexmacosx.c (copy_data_segment): Also copy __got section.
4655 (Bug#8223)
4656
7ac80be9
EZ
46572011-03-12 Eli Zaretskii <eliz@gnu.org>
4658
c96bbc66 4659 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4660 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4661 Constify `char *' arguments and their references according to
4662 prototypes in tparam.h.
4663
ecb0f94d 4664 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4665
7ac80be9
EZ
4666 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4667 Adapt all references accordingly.
4668
4669 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4670
ef1fd07e
TT
46712011-03-11 Tom Tromey <tromey@redhat.com>
4672
4673 * buffer.c (syms_of_buffer): Remove obsolete comment.
4674
7ef4b50c
EZ
46752011-03-11 Eli Zaretskii <eliz@gnu.org>
4676
4677 * termhooks.h (encode_terminal_code): Declare prototype.
4678
4679 * msdos.c (encode_terminal_code): Don't declare prototype.
4680
4681 * term.c (encode_terminal_code): Now external again, used by
4682 w32console.c and msdos.c.
4683
44f230aa
SM
4684 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4685 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4686
4b1ec863 46872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4688
1714f52b 4689 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4690
4b1ec863
PE
4691 * fringe.c (update_window_fringes): Mark locals as initialized
4692 (Bug#8227).
4693 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4694
524c7aa6
PE
4695 * alloc.c (mark_fringe_data): Move decl from here ...
4696 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4697 to check its interface.
4698 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4699
a5c0af81 4700 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4701 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4702 (fontset_font): Mark local as initialized.
a9a06e0b 4703 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4704
b4716021
PE
4705 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4706
811e9bac 4707 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4708 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4709 (x_own_selection, Fx_disown_selection_internal): Rename locals
4710 to avoid shadowing.
4711 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4712
7e3ab302
PE
4713 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4714 so that the caller can use some name other than gcpro1.
4715 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4716 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4717 (Fx_backspace_delete_keys_p):
4718 Use them to avoid shadowing, and rename vars to avoid shadowing.
4719 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4720 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4721 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4722 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4723 Remove unused locals.
7e3ab302
PE
4724 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4725 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4726 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4727 macros.
f78faa98 4728
e2b13473
PE
4729 * xterm.h (x_mouse_leave): New decl.
4730
77f23912
PE
4731 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4732 Remove unused functions.
cdf4ba58
PE
4733 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4734 (x_calc_absolute_position): Now static.
7411c686 4735 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4736 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4737 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4738 unless they are used.
38d0b34a
PE
4739 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4740 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4741 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4742 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4743 (x_error_catcher, x_connection_closed, x_error_handler):
4744 (x_error_quitter, xembed_send_message, x_iconify_frame):
4745 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4746 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4747 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4748
44f230aa
SM
4749 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4750 Rename or move locals to avoid shadowing.
6b463e58 4751 (tty_defined_color, merge_face_heights): Now static.
5967d051 4752 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4753 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4754 does not deduce is never used uninitialized.
73719eba
PE
4755 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4756 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4757
426994c3 4758 * terminal.c (store_terminal_param): Now static.
5489860b 4759
032f1620 4760 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4761 (set_frame_menubar): Remove unused local.
d4323972 4762 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4763 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4764 since they might point to immutable storage.
281585b0
PE
4765 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4766 since it's unused otherwise.
032f1620 4767
367c19e5 4768 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4769 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4770 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4771 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4772 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4773 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4774 does not deduce are never used uninitialized.
70739cbe 4775
07b48fa9
PE
4776 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4777
8868a238 4778 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4779 * window.c (window_loop, size_window):
4780 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4781
7e5cf297 4782 * window.c (display_buffer): Now static.
d6550a9f
PE
4783 (size_window): Mark variables that gcc -Wuninitialized
4784 does not deduce are never used uninitialized.
a586633d
PE
4785 * window.h (check_all_windows): New decl, to forestall
4786 gcc -Wmissing-prototypes diagnostic.
5b555da1 4787 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4788
f6095868
PE
4789 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4790 shadowing.
4791 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4792 Include <limits.h>.
4793 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4794 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4795 (load_charset_map): Mark variables that gcc -Wuninitialized
4796 does not deduce are never used uninitialized.
53df7c11 4797 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4798
f38b440c
PE
4799 * coding.c (coding_set_source, coding_set_destination):
4800 Use "else { /* comment */ }" rather than "else /* comment */;"
4801 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4802 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4803 a block, when the outer 'i' will do.
4804 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4805 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4806 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4807 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4808 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4809 Rename locals to avoid shadowing.
4810 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4811 * coding.c (emacs_mule_char, encode_invocation_designation):
4812 Now static, since they're not used elsewhere.
413bb2db 4813 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4814 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4815 (decode_coding_emacs_mule): Mark variables that gcc
4816 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4817 (detect_coding_iso_2022): Initialize a local variable that might
4818 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4819 this initialization is needed. (Bug#8211)
5f58e762
PE
4820 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4821 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4822 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4823 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4824 Remove unused macros.
f38b440c 4825
232b38b9 4826 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4827 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4828 * character.c (string_count_byte8): Likewise.
232b38b9 4829
fb90da1b
PE
4830 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4831 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4832
fb93dbc2
PE
4833 * chartab.c (copy_sub_char_table): Now static, since it's not used
4834 elsewhere.
5c156ace
PE
4835 (sub_char_table_ref_and_range, char_table_ref_and_range):
4836 Rename locals to avoid shadowing.
bbcd0949 4837 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4838
7d3b3862 4839 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4840 (BIDI_BOB): Remove unused macro.
7d3b3862 4841
6be7d3da
PE
4842 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4843 deduce are never used uninitialized.
c2ed9c8b 4844 * term.c (encode_terminal_code): Likewise.
6be7d3da 4845
75f8807f 4846 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4847
50938595
PE
4848 * tparam.h: New file.
4849 * term.c, tparam.h: Include it.
4850 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4851 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4852 Move these decls to tparam.h, and make them agree with what
4853 is actually in tparam.c. The previous trick of using incompatible
4854 decls in different modules does not conform to the C standard.
4855 All callers of tparam changed to use tparam's actual API.
4856 * tparam.c (tparam1, tparam, tgoto):
4857 Use const pointers where appropriate.
4858
fbceeba2
PE
4859 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4860 * cm.h (struct cm): Likewise.
4861 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4862 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4863 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4864 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4865 (turn_on_face, init_tty): Likewise.
4866 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4867
7f3f1250
PE
4868 * term.c (term_mouse_position): Rename local to avoid shadowing.
4869
e6ca6543
PE
4870 * alloc.c (mark_ttys): Move decl from here ...
4871 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4872
c40f8d15
AS
48732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4874
4875 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4876
cfe0661d
JB
48772011-03-09 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * search.c (compile_pattern_1): Remove argument regp, unused since
4880 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4881 (compile_pattern): Don't pass it.
4882
0afb4571
J
48832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4884
4885 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4886 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4887 for ! HAVE_GTK3.
4888 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4889
4890 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4891
4892 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4893 gdk_window_get_screen, gdk_window_get_geometry,
4894 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4895 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4896 (xg_get_pixbuf_from_pixmap): New function.
4897 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4898 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4899 Call xg_get_pixbuf_from_pixmap instead of
4900 gdk_pixbuf_get_from_drawable.
4901 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4902 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4903 (xg_check_special_colors): Use GtkStyleContext and its functions
4904 for HAVE_GTK3.
4905 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4906 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4907 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4908 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4909 Call gtk_widget_get_preferred_size.
0afb4571
J
4910 (xg_frame_resized): gdk_window_get_geometry only takes 5
4911 parameters.
44f230aa
SM
4912 (xg_win_to_widget, xg_event_is_for_menubar):
4913 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4914 (xg_set_widget_bg): New function.
4915 (delete_cb): New function.
895009e1 4916 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4917 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4918 (xg_set_background_color): Call xg_set_widget_bg.
4919 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4920 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4921 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4922 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4923 if ! HAVE_GTK3.
4924 (update_frame_tool_bar): Call gtk_widget_hide.
4925 (xg_initialize): Use GDK_KEY_g.
4926
4927 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4928 if ! HAVE_GTK3
4929 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4930
4931 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4932 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4933 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4934
1c2cc4ef
JB
49352011-03-08 Juanma Barranquero <lekktu@gmail.com>
4936
4937 * w32xfns.c (select_palette): Check success of RealizePalette against
4938 GDI_ERROR, not zero.
4939
33383987 4940See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4941
4942;; Local Variables:
4943;; coding: utf-8
aac0c6e3
MR
4944;; End:
4945
33383987 4946 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4947
4948 This file is part of GNU Emacs.
4949
4950 GNU Emacs is free software: you can redistribute it and/or modify
4951 it under the terms of the GNU General Public License as published by
4952 the Free Software Foundation, either version 3 of the License, or
4953 (at your option) any later version.
4954
4955 GNU Emacs is distributed in the hope that it will be useful,
4956 but WITHOUT ANY WARRANTY; without even the implied warranty of
4957 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4958 GNU General Public License for more details.
4959
4960 You should have received a copy of the GNU General Public License
4961 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.