Fix bug#10044
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f067b8ec
JB
12011-11-14 Juanma Barranquero <lekktu@gmail.com>
2
3 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4 just return (bug#10044).
5
1e5b2111
EZ
62011-11-12 Eli Zaretskii <eliz@gnu.org>
7
7ef3cbd5
EZ
8 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
9 with user-defined heap size. Bump the default size of the temacs
10 heap to 27MB, to avoid memory warning when running temacs.
11 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
12
1e5b2111
EZ
13 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
14 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
15 (verify_row_hash) [XASSERTS]: New function.
16 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
17 that the hash value of glyph rows is correct.
1e5b2111 18
89d61221
MR
192011-11-12 Martin Rudalics <rudalics@gmx.at>
20
21 * window.h (window): Remove splits slot.
22 * window.c (Fwindow_splits, Fset_window_splits): Remove.
23 (Fdelete_other_windows_internal, make_parent_window)
24 (make_window, Fsplit_window_internal, Fdelete_window_internal)
25 (Fset_window_configuration, save_window_save): Don't deal with
26 split status of windows.
27 (saved_window): Remove splits slot.
28 (Vwindow_splits): Rewrite doc-string.
29
97f18cc8
JD
302011-11-11 Jan Djärv <jan.h.d@swipnet.se>
31
32 * xfns.c (unwind_create_frame):
33 * nsfns.m (unwind_create_frame):
34 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
35 Vframe_list (Bug#9999).
36
22a648b4
DA
372011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
38
39 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
40
659afede
KH
412011-11-11 Kenichi Handa <handa@m17n.org>
42
43 * callproc.c (Fcall_process): Set the member dst_multibyte of
44 process_coding.
45
9ac0394b
KH
462011-11-11 Johan Bockgård <bojohan@gnu.org>
47
48 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
49 avoid a crash (bug#9496).
50
2fbdc249
CY
512011-11-09 Chong Yidong <cyd@gnu.org>
52
53 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
54 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
55
ac6b1f81
PE
562011-11-08 Paul Eggert <eggert@cs.ucla.edu>
57
58 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
59
09db192c
PE
602011-11-08 Paul Eggert <eggert@cs.ucla.edu>
61
62 Avoid some portability problems by eschewing 'extern inline' functions.
63 The trivial performance wins aren't worth the portability hassles; see
64 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
65 et seq.
66 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
67 (window_box_width, window_box_left, window_box_left_offset)
68 (window_box_right, window_box_right_offset): Undo previous change,
69 by removing the "extern"s.
70 * intervals.c (adjust_intervals_for_insertion)
71 (adjust_intervals_for_deletion): Undo previous change,
72 making these static again.
73 (offset_intervals, temp_set_point_both, temp_set_point)
74 (copy_intervals_to_string): No longer inline.
75 * xdisp.c (window_text_bottom_y, window_box_width)
76 (window_box_height, window_box_left_offset)
77 (window_box_right_offset, window_box_left, window_box_right)
78 (window_box): No longer inline.
79
105216ed
CY
802011-11-08 Chong Yidong <cyd@gnu.org>
81
82 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
83 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
84 an error if not a live window.
85 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
86 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
87
ae9e237f
JB
882011-11-07 Juanma Barranquero <lekktu@gmail.com>
89
90 * lisp.h (syms_of_abbrev): Remove declaration.
91 Reported by CHENG Gao <chenggao@royau.me>.
92
c7aa8333
EZ
932011-11-07 Eli Zaretskii <eliz@gnu.org>
94
95 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
96 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
97 of temacs in GUI mode.
98
be7f5545
MR
992011-11-07 Martin Rudalics <rudalics@gmx.at>
100
101 * window.h: Declare delete_all_child_windows instead of
102 delete_all_subwindows.
103 * window.c (Fwindow_nest, Fset_window_nest)
104 (Fset_window_new_total, Fset_window_new_normal)
105 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
106 (delete_all_subwindows): Rename to delete_all_child_windows.
107 (Fdelete_other_windows_internal, Fset_window_configuration):
108 Call delete_all_child_windows instead of delete_all_subwindows.
109 * frame.c (delete_frame): Call delete_all_child_windows instead
110 of delete_all_subwindows.
111
ca78dc43
PE
1122011-11-07 Paul Eggert <eggert@cs.ucla.edu>
113
114 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
115 This is also needed for porting to any host where GC_MARK_STACK is
116 not GC_MAKE_GCPROS_NOOPS.
117 (which_symbols): Use it.
118
a0241d01
KH
1192011-11-07 Kenichi Handa <handa@m17n.org>
120
121 * coding.c (coding_set_destination): Check coding->src_pos only
122 when coding->src_object is a buffer (bug#9910).
123
124 * process.c (send_process): Set the member src_multibyte of coding
125 to 0 (bug#9911) when sending a unibyte text.
126
127 * callproc.c (Fcall_process): Set the member src_multibyte of
128 process_coding to 0 (bug#9912).
129
a64bfdfa 1302011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
131
132 * xmenu.c (cleanup_widget_value_tree): New function.
133 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
134 calling free_menubar_widget_value_tree directly (Bug#9830).
135
cb41b32a
PE
1362011-11-06 Paul Eggert <eggert@cs.ucla.edu>
137
138 Fix some portability problems with 'inline'.
139 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
140 (window_box_width, window_box_left, window_box_left_offset)
141 (window_box_right, window_box_right_offset): Declare extern.
142 Otherwise, these inline functions do not conform to C99 and
143 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
144 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
145 * intervals.c (adjust_intervals_for_insertion)
146 (adjust_intervals_for_deletion): Now extern, because otherwise the
147 extern inline functions 'offset_intervals' couldn't refer to it.
148 (static_offset_intervals): Remove.
149 (offset_intervals): Rewrite using the old contents of
150 static_offset_intervals. The old version didn't conform to C99
151 because an extern inline function contained a reference to an
152 identifier with static linkage.
153
b7041366
AS
1542011-11-06 Andreas Schwab <schwab@linux-m68k.org>
155
156 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
157 GC.
158
88a37c4d
EZ
1592011-11-06 Eli Zaretskii <eliz@gnu.org>
160
161 * xdisp.c (init_iterator, reseat_to_string): Don't set the
162 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
163 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
164 return Qleft_to_right.
165
49745b39
CY
1662011-11-06 Chong Yidong <cyd@gnu.org>
167
168 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
169 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
170 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
171 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
172 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
173 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
174 (Fwindow_vscroll): Doc fix.
175 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
176 argument, since it makes no sense to pass a live window and for
177 consistency with window-child.
178
1f05cd82
CS
1792011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
180
181 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
182 support MSVC.
183
22610910
JR
1842011-11-05 Jason Rumney <jasonr@gnu.org>
185
186 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
187 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
188 fonts (Bug#6029).
189 (add_font_entity_to_list): Fix logic errors in mixed boolean and
190 bitwise arithmetic preventing use of unicode-sip and non-truetype
191 opentype fonts.
192
a06776b2
EZ
1932011-11-05 Eli Zaretskii <eliz@gnu.org>
194
3ad924ba
EZ
195 * s/ms-w32.h (fstat, stat, utime): Move redirections to
196 "emacs"-only part.
197
a06776b2
EZ
198 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
199 initialization code to keep similarity to xfns.c after changes
200 from 2011-11-05.
201
c9e7db78
JD
2022011-11-05 Jan Djärv <jan.h.d@swipnet.se>
203
a97f8f3f
JD
204 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
205 (unwind_create_frame): New function (Bug#9943).
206 (Fx_create_frame): Restructure code to be more similar to the one in
207 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
208 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
209 Move terminal->reference_count++ just before making the frame official
210 (Bug#9943).
211
212 * nsterm.m (x_free_frame_resources): New function.
213 (x_destroy_window): Move code to x_free_frame_resources.
214
c9e7db78
JD
215 * xfns.c (unwind_create_frame): Fix comment.
216 (Fx_create_frame, x_create_tip_frame): Move
217 terminal->reference_count++ just before making the frame
218 official. Move initialization of image_cache_refcount and
219 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
220
a6fc3b5c
EZ
2212011-11-05 Eli Zaretskii <eliz@gnu.org>
222
223 Support MSVC build with newer versions of Visual Studio.
224 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
225 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
226 nt/gmake.defs.
227
228 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
229 which are not supported by MSVC.
230 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
231 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
232 bitfields.
233 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
234 types in bitfields.
235 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
236
237 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
238
2392011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
240
241 Support MSVC build with newer versions of Visual Studio.
242 * w32.c: Don't include w32api.h for MSVC.
243 (init_environment) [_MSC_VER]: Call sys_access, not _access.
244
245 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
246 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
247 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
248 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
249 e_* cousins.
250 (alloca) [_MSC_VER]: Define to _alloca.
251
252 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
253
254 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
255
a58c13ed
EZ
2562011-11-04 Eli Zaretskii <eliz@gnu.org>
257
258 * xdisp.c (note_mouse_highlight): If either of
259 previous/next-single-property-change returns nil, treat that as
260 the beginning or the end of the buffer. (Bug#9955)
261
fe0b6370
JD
2622011-11-04 Jan Djärv <jan.h.d@swipnet.se>
263
a58c13ed 264 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
265 label is not null (Bug#9951).
266 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
267 may be NULL.
268
89bd5ee1
EZ
2692011-11-04 Eli Zaretskii <eliz@gnu.org>
270
271 * window.c (Fwindow_body_size): Mention in the doc string that the
272 return value is in frame's canonical units. (Bug#9949)
273
84c3edb9
EZ
2742011-11-03 Eli Zaretskii <eliz@gnu.org>
275
4e2fb5c7
EZ
276 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
277
84c3edb9 278 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 279 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 280 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 281
bc17a887
EZ
2822011-11-01 Eli Zaretskii <eliz@gnu.org>
283
284 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
285 Don't stop backward scan on the continuation glyph, even though
286 its CHARPOS is positive.
26b46e51
EZ
287 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
288 cover_string to disp_string.
bc17a887 289
4ee88440
MR
2902011-11-01 Martin Rudalics <rudalics@gmx.at>
291
292 * window.c (temp_output_buffer_show): Don't use
293 Vtemp_buffer_show_specifiers.
294 (Vtemp_buffer_show_specifiers): Remove unused variable.
295
c2ff3c02
EZ
2962011-10-30 Eli Zaretskii <eliz@gnu.org>
297
298 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
299 past the beginning of the current glyph matrix.
300
6e56383b
JD
3012011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
302
303 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
304 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
305 HAVE_GTK3 (Bug#9869).
b77a6a7f 306
3b574623
JD
307 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
308 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
309
b77a6a7f
JD
310 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
311
312 * xterm.c: Declare x_handle_net_wm_state to return int.
313 (handle_one_xevent): Check if we are iconified but don't have
314 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
315 (get_current_wm_state): Return non-zero if not hidden,
316 check for _NET_WM_STATE_HIDDEN (Bug#9893).
317 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
318 (x_handle_net_wm_state): Return what get_current_wm_state returns.
319 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
320
196e41e4
PE
3212011-10-29 Paul Eggert <eggert@cs.ucla.edu>
322
323 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
324 so that this new function doesn't get optimized away by a
325 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
326
021f2e1a
AS
3272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
328
329 * frame.h (MOUSE_HL_INFO): Remove excess parens.
330
8b058d44
EZ
3312011-10-29 Eli Zaretskii <eliz@gnu.org>
332
333 Fix the `xbytecode' command.
334 * .gdbinit (xprintbytestr): New command.
335 (xwhichsymbols): Renamed from `which'; all callers changed.
336 (xbytecode): Print the byte-code string as well.
337
4452fb80
EZ
3382011-10-29 Kim Storm <storm@cua.dk>
339
8b058d44
EZ
340 * alloc.c (which_symbols): New function.
341
21b72067
AS
3422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
343
344 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
345 line. (Bug#9903)
346
83ed7b5c
GM
3472011-10-29 Glenn Morris <rgm@gnu.org>
348
349 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
350 Not clear what it was for, and it causes various bugs. (Bug#9839)
351
5a7a728b
EZ
3522011-10-28 Eli Zaretskii <eliz@gnu.org>
353
354 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
355 possible random value that matches one of those tested as
356 condition to clear the mouse face.
357
d3d0842f
CY
3582011-10-28 Chong Yidong <cyd@gnu.org>
359
360 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
361
31b39d13
DN
3622011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
363
364 * window.c (make_window): Initialize phys_cursor_on_p.
365
9aba6043
SM
3662011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
367
368 * lisp.h (struct Lisp_Symbol): Update comments.
369
c20992f4
JB
3702011-10-28 Juanma Barranquero <lekktu@gmail.com>
371
372 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
373
db4f02f2
EZ
3742011-10-28 Eli Zaretskii <eliz@gnu.org>
375
376 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
377 <oslsachem@gmail.com> for helping to debug this.
378
379 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
380 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
381 (g_b_init_get_glyph_outline_w): New static variables.
382 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
383 (GetGlyphOutlineW_Proc): New typedefs.
384 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
385 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
386 New functions.
387 (w32font_open_internal, compute_metrics):
388 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
389 instead of calling the "wide" APIs directly.
390
391 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
392
393 * w32.h (syms_of_w32font): Add prototype.
394
87e68db4
JB
3952011-10-27 Juanma Barranquero <lekktu@gmail.com>
396
397 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
398 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
399 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
400 (Fmove_to_window_line): Doc fix.
401
435c1d67
CY
4022011-10-27 Chong Yidong <cyd@gnu.org>
403
404 * process.c (make_process): Set gnutls_state to NULL.
405
406 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
407 non-NULL, regardless of GNUTLS_INITSTAGE.
408 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
409 an error. Set process slots as soon as we allocate them.
410
411 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
412
9c6c6f49
CY
4132011-10-27 Chong Yidong <cyd@gnu.org>
414
9aba6043
SM
415 * gnutls.c (emacs_gnutls_deinit): New function.
416 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
417 (Fgnutls_deinit, Fgnutls_boot): Use it.
418
419 * process.c (make_process): Initialize GnuTLS credentials to NULL.
420 (deactivate_process): Call emacs_gnutls_deinit.
421
657d08d3
JB
4222011-10-27 Juanma Barranquero <lekktu@gmail.com>
423
424 * image.c (x_create_x_image_and_pixmap):
425 * w32.c (sys_rename, w32_delayed_load):
426 * w32font.c (fill_in_logfont):
427 * w32reg.c (x_get_string_resource): Silence compiler warnings.
428
5430d399
JB
4292011-10-26 Juanma Barranquero <lekktu@gmail.com>
430
431 * w32fns.c (w32_default_color_map): New function,
432 extracted from Fw32_default_color_map.
a7ef684b 433 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 434
fe0055fa
PE
4352011-10-25 Paul Eggert <eggert@cs.ucla.edu>
436
437 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
438
e6346438
SM
4392011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
440
441 * keyboard.c (test_undefined): New function (bug#9751).
442 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
443
e112cc37
ET
4442011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
445
446 * sysdep.c (init_sys_modes): Fix the check for the controlling
447 terminal (Bug#6649).
448
7b5d6677
EZ
4492011-10-20 Eli Zaretskii <eliz@gnu.org>
450
451 * dispextern.h (struct bidi_it): New member next_en_type.
452
453 * bidi.c (bidi_line_init): Initialize the next_en_type member.
454 (bidi_resolve_explicit_1): When next_en_pos is valid for the
455 current character, check also for next_en_type being WEAK_EN.
456 (bidi_resolve_weak): Don't enter the expensive loop if the current
457 position is before next_en_pos. Record the bidi type of the first
458 non-ET, non-BN character we find, in addition to its position.
459 (bidi_level_of_next_char): Invalidate next_en_type when
460 next_en_pos is over-stepped.
461
7da0b018
PE
4622011-10-20 Paul Eggert <eggert@cs.ucla.edu>
463
464 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
465 * editfns.c: Rewrite current-time-zone so that it invokes
466 the equivalent of (format-time-string "%Z") to get the time zone name.
467 This fixes a bug when the time zone name contains characters that
468 need converting from the system time locale to Emacs internal format.
469 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
470 that patch fixed format-time-string to do the conversion, but
471 I forgot to fix current-time-zone.
472 (format_time_string): New function, containing most of
473 what Fformat_time_string used to contain.
474 (Fformat_time_string): Rewrite in terms of format_time_string.
475 This doesn't change this function's behavior.
476 (current-time-zone): Rewrite to use format_time_string.
477 This fixes the bug reported by Michael Schierl in
478 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
479 Jason Rumney's 2007-06-07 change worked around this bug, but
480 didn't fix it.
481 * systime.h (tzname, timezone): Remove no-longer-used declarations.
482
8547b010
EZ
4832011-10-19 Eli Zaretskii <eliz@gnu.org>
484
485 * xdisp.c (start_display): If the character at POS is displayed
486 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
487 (try_window_reusing_current_matrix): If a line ends in a display
488 vector or the next line starts in a display vector, continue
489 redrawing the window even though the character position of
490 start_row was reached.
8547b010
EZ
491 (Bug#9771, part 2)
492
4e948d15
CY
4932011-10-18 Chong Yidong <cyd@gnu.org>
494
495 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
496 with nobreak-char-display too.
497
4787455f
EZ
4982011-10-18 Eli Zaretskii <eliz@gnu.org>
499
500 Fix part 3 of bug#9771.
501 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
502 (bidi_resolve_neutral): Don't enter the expensive loop looking for
503 non-neutral characters if the current character is a paragraph
504 separator (a.k.a. Newline). This avoids running the same
505 expensive loop twice, once when we consume the preceding newline
506 and the other time when the line actually needs to be displayed.
507 Avoid the loop when we see neutrals on the base embedding level
508 following a character whose directionality is the same as the
509 paragraph's. This avoids running the expensive loop when a line
510 ends in a long sequence of neutrals, like control characters.
511 Add assertion against STRONG_AL type. Slightly rearrange code
512 that determines the type of a neutral given the first non-neutral
513 that follows it.
514 (bidi_level_of_next_char): Set next_en_pos to zero when
515 invalidating its info.
516
2c91f553
EZ
5172011-10-17 Eli Zaretskii <eliz@gnu.org>
518
519 * xdisp.c (push_display_prop): Determine whether to record string
520 or buffer position by IT->string, not by IT->method. Allow
521 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
522 (move_it_vertically_backward): Don't look for character position
523 immediately after the newline when in a continuation line.
524 (Bug#9771, part 1)
2c91f553 525
c7b08b0d
MR
5262011-10-15 Martin Rudalics <rudalics@gmx.at>
527
528 * window.c (coordinates_in_window): Rewrite and delabelize
529 vertical border check. (Bug#5357) (Bug#9618)
530
6b02f655
SM
5312011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
532
533 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
534 errors in XSetWindowBorder (bug#9310).
535
81d40c92
DA
5362011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
537
538 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
539 avoid crash when xmalloc overrun checking is enabled.
540
d4172c3b
EZ
5412011-10-13 Eli Zaretskii <eliz@gnu.org>
542
543 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
544 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
545 cursor motion with <left> and <right> arrow keys.
546
547 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
548 some callers set that themselves.
549
b00eea75
EZ
5502011-10-12 Eli Zaretskii <eliz@gnu.org>
551
552 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
553 display string and the previous row comes from the same string and
554 is empty. (Bug#9739) (Bug#9738)
555
8fe012c4
SM
5562011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
557
558 * doc.c (get_doc_string): Encode file name (bug#9735).
559
0074aef2
EZ
5602011-10-12 Eli Zaretskii <eliz@gnu.org>
561
79beb178
EZ
562 * bidi.c (bidi_level_of_next_char):
563 * xdisp.c (get_visually_first_element): Remove old incorrect
564 comments regarding the Unicode Line Separator character.
565
0074aef2
EZ
566 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
567
6e4b3fbe
DA
5682011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
569
570 * alloc.c (Fgc_status): Do not access beyond zombies array
571 boundary if nzombies > MAX_ZOMBIES.
572 * alloc.c (dump_zombies): Add missing format specifier.
573
0324f3af
PE
5742011-10-12 Paul Eggert <eggert@cs.ucla.edu>
575
b5525cac
PE
576 * xdisp.c (set_cursor_from_row): Simplify conditionals,
577 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
578
0324f3af
PE
579 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
580 Some packages use them to denote characters with modifiers.
581
e9b5f888
AS
5822011-10-11 Andreas Schwab <schwab@linux-m68k.org>
583
584 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
585 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
586 matching a pp-number. Rename parameter var to var1.
587
127827c0
SM
5882011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
589
590 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
591
c8fd3bd0
GM
5922011-10-08 Glenn Morris <rgm@gnu.org>
593
594 * callint.c (Fcall_interactively): Give a more explicit error for the
595 'c' case with a non-character input. (Bug#8479)
596
352ec8ff
EZ
5972011-10-08 Eli Zaretskii <eliz@gnu.org>
598
03669ccb
EZ
599 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
600 lines.
7061c986
EZ
601 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
602 lines that are hscrolled on the left.
03669ccb 603
352ec8ff
EZ
604 * dispnew.c (buffer_posn_from_coords): Account for a possible
605 presence of header-line. (Bug#4426)
606
a66cfb1c
SM
6072011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
608
6b02f655
SM
609 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
610 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 611
7c5ee88e
PE
6122011-10-07 Paul Eggert <eggert@cs.ucla.edu>
613
614 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
615 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
616 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
617 this makes Emacs dump core during garbage collection on rare
618 occasions. sizeof is obviously inferior to offsetof here, so
619 stick with offsetof.
620 (GC_POINTER_ALIGNMENT): New macro.
621 (mark_memory): Omit 3rd (offset) arg; caller changed.
622 Don't assume EMACS_INT alignment is the same as pointer alignment.
623
df1bbe5b
SM
6242011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
625
626 * keyboard.c (read_key_sequence_remapped): New var.
627 (read_key_sequence): Compute remapping in the right buffer.
628 (command_loop_1): Use read_key_sequence's remapping directly.
629
51553db6
SM
6302011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
631
32c1fffd
SM
632 * dired.c (file_name_completion): Don't expand file name.
633 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
634 before checking file name handler.
635
51553db6
SM
636 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
637 they've been requested explicitly (bug#9591).
638
b6bd1599 6392011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
640
641 * keymap.c (Fsingle_key_description): Use make_specified_string
642 instead of build_string to build string from push_key_description.
643 (Bug#5193)
644
f701dc2a
PE
6452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
646
4222c55d
PE
647 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
648 This fixes a Y2038 bug on 64-bit hosts.
649 * buffer.c (reset_buffer):
650 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
651 (Fclear_buffer_auto_save_failure):
652 Use 0, not -1, to represent an unset failure time, since time_t
653 might not be signed.
654
f701dc2a
PE
655 Remove dependency on glibc malloc internals.
656 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
657 Move back here from lisp.h, but with their new implementations.
658 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
659 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
660 * charset.c (charset_table_init): New static var.
661 (syms_of_charset): Use it instead of xmalloc. This removes a
662 dependency on glibc malloc internals. See Eli Zaretskii's comment in
663 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
664 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
665 Move back to alloc.c.
666 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
667 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
668
9ceebf39
JD
6692011-09-30 Jan Djärv <jan.h.d@swipnet.se>
670
671 * nsterm.m (windowDidResize): Call x_set_window_size only when
672 ns_in_resize is true. Otherwise set pixelwidth/height and
673 call change_frame_size (Bug#9628).
674
cb993c58
PE
6752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
676
3930c88b
PE
677 Port --enable-checking=all to Fedora 14 x86-64.
678 * charset.c (syms_of_charset): Also account for glibc malloc's
679 internal overhead when calculating the initial malloc maximum.
680
cb993c58
PE
681 Port --enable-checking=all to Fedora 14 x86.
682 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
683 Move to lisp.h.
684 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
685 (overrun_check_realloc, overrun_check_free):
686 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
687 That way, xmalloc returns a properly-aligned pointer even if
688 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
689 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
690 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
691 into account when calculating the initial malloc maximum.
692 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
693 Move here from alloc.c, so that charset.c can use it too.
694 Properly align; the old code wasn't right for common 32-bit hosts
695 when configured with --enable-checking=all.
696 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
697 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
698
31bed486
EZ
6992011-09-29 Eli Zaretskii <eliz@gnu.org>
700
04c70788 701 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
702 use EDOM.
703
fbcaa2f3
EZ
7042011-09-28 Eli Zaretskii <eliz@gnu.org>
705
706 * xdisp.c (compute_display_string_end): If there's no display
707 string at CHARPOS, return -1.
708
709 * bidi.c (bidi_fetch_char): When compute_display_string_end
710 returns a negative value, treat the character as a normal
711 character not covered by a display string. (Bug#9624)
712
a239d4e9
JB
7132011-09-28 Juanma Barranquero <lekktu@gmail.com>
714
715 * lread.c (Fread_from_string): Fix typo in docstring.
716
88652fd5
EZ
7172011-09-27 Eli Zaretskii <eliz@gnu.org>
718
719 * xdisp.c (handle_invisible_prop): If invisible text ends on a
720 newline, reseat the iterator instead of bidi-iterating there one
721 character at a time. (Bug#9610)
32c1fffd
SM
722 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
723 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 724
ed497dd4
AS
7252011-09-27 Andreas Schwab <schwab@linux-m68k.org>
726
727 * lread.c (readevalloop): Use correct code for NBSP.
728 (read1): Likewise. (Bug#9608)
729
b2bf61aa
MA
7302011-09-25 Michael Albinus <michael.albinus@gmx.de>
731
732 * dbusbind.c (Fdbus_register_signal): When service is not
733 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
734
32bbb17c
GM
7352011-09-25 Glenn Morris <rgm@gnu.org>
736
737 * buffer.c (truncate-lines): Doc fix.
738
94e0933e
CY
7392011-09-24 Chong Yidong <cyd@stupidchicken.com>
740
741 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
742 (Fset_window_next_buffers): Doc fix.
743
cddde921
GM
7442011-09-24 Glenn Morris <rgm@gnu.org>
745
746 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
747
1260aef1
PE
7482011-09-24 Paul Eggert <eggert@cs.ucla.edu>
749
25b4bfa0
PE
750 Fix minor problems found by static checking.
751 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
752 * indent.c (Fvertical_motion): Fix == vs = typo.
753
e3cbd34b
EZ
7542011-09-24 Eli Zaretskii <eliz@gnu.org>
755
a66cfb1c
SM
756 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
757 Default value is now t. Doc fix.
6bf7006f 758
e3cbd34b 759 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 760 logic when moving up, not only when moving down. Fix the
e3cbd34b 761 confusing name and values of the it_overshoot_expected variable;
32c1fffd 762 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
763
764 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
765 CHARPOS is covered by a display string which includes newlines.
766 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
767 is covered by a display string with embedded newlines.
768
a3de0cbd
MA
7692011-09-24 Michael Albinus <michael.albinus@gmx.de>
770
771 * dbusbind.c (Fdbus_register_signal): Add match rule to
772 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
773 (Fdbus_register_method, Vdbus_registered_objects_table):
774 Fix docstring.
a3de0cbd 775
b260039d
JM
7762011-09-24 Jim Meyering <meyering@redhat.com>
777
32c1fffd 778 do not ignore write error for any output size
b260039d
JM
779 The previous change was incomplete.
780 While it makes emacs --batch detect the vast majority of stdout
781 write failures, errors were still ignored whenever the output size is
782 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
783 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
784 && echo FAIL: ignored write error
785 FAIL: ignored write error
786 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
787 && echo FAIL: ignored write error
788 FAIL: ignored write error
789 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
790
8eca8a7c
AS
7912011-09-23 Andreas Schwab <schwab@linux-m68k.org>
792
793 * emacs.c (Fkill_emacs): In noninteractive mode exit
794 non-successfully if a write error occurred on stdout. (Bug#9574)
795
3341db62
EZ
7962011-09-21 Eli Zaretskii <eliz@gnu.org>
797
798 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
799 the xassert test.
800
801 * dispextern.h (struct it): Update the comment documenting what
802 can it->OBJECT be.
803
8c203dbf
EZ
8042011-09-20 Eli Zaretskii <eliz@gnu.org>
805
806 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
807 a display string, extend search for cursor position to end of row.
808 (find_row_edges): If the row ends in a newline from a display
809 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
810 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
811 (Fcurrent_bidi_paragraph_direction): Fix search for previous
812 non-empty line. Fixes confusing cursor motion with arrow keys at
813 the beginning of a line that starts with whitespace.
8c203dbf 814
a4824228
LMI
8152011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
816
817 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
818 (bug#9493).
819
33ed493b
CY
8202011-09-18 Chong Yidong <cyd@stupidchicken.com>
821
822 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
823 boolean (Bug#9154).
824
56cd55c8
EZ
8252011-09-18 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (display_line): Record maximum and minimum buffer
828 positions even if no glyphs were produced (e.g., by a zero-width
829 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
830 buffer positions that will be removed from the glyph row because
831 they don't fit.
c02dcedf
EZ
832 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
833 column is beyond frame width: don't subtract 1 "pixel" when
834 computing width of the stretch.
3e62b7e0
EZ
835 (reseat_at_next_visible_line_start): Undo the change made on
836 2011-09-17 that saved paragraph information and restored it after
837 the call to `reseat'. (Bug#9545)
56cd55c8 838
5ed99d36 8392011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
840
841 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
842 and turn window cursor on if cleared (Bug#9415).
843
5ed99d36 8442011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
845
846 * search.c (boyer_moore): Take unibyte characters from pattern
847 literally. (Bug#9458)
848
9bade7b2
EZ
8492011-09-18 Eli Zaretskii <eliz@gnu.org>
850
851 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
852
e5e9d610
PE
8532011-09-18 Paul Eggert <eggert@cs.ucla.edu>
854
87e4427a
PE
855 Fix minor problem found by static checking.
856 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
857 initialized, to pacify gcc -Wuninitialized.
858
e5e9d610
PE
859 * fileio.c: Report proper errno when syscall falls.
860 (Finsert_file_contents): Save and restore errno,
861 so that report_file_error outputs the correct diagnostic.
862 (Fwrite_region) [CLASH_DETECTION]: Likewise.
863
a1674f0b
EZ
8642011-09-18 Eli Zaretskii <eliz@gnu.org>
865
866 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
867
fbfb6dd4
EZ
8682011-09-17 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
871 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
872
bb187662
EZ
8732011-09-17 Eli Zaretskii <eliz@gnu.org>
874
1137e8b8 875 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 876 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
877
878 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
879 (bidi_find_paragraph_start): Search back for paragraph beginning
880 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
881 (bidi_move_to_visually_next): Only trigger paragraph-related
882 computations when the last character is a newline or at EOB, not
883 just any NEUTRAL_B. (Bug#9470)
884
bb187662
EZ
885 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
886 truncated lines if point is covered by a display string. (Bug#9524)
887
2e621251
PE
8882011-09-16 Paul Eggert <eggert@cs.ucla.edu>
889
890 * xselect.c: Relax test for outgoing X longs (Bug#9498).
891 (cons_to_x_long): New function.
892 (lisp_data_to_selection_data): Use it. Correct the test for
893 short-versus-long data; it was negated. Break out of vector
894 loop, for efficiency, when a long datum is discovered.
895
91a15bc6
SM
8962011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
897
898 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
899
b41c3a35
EZ
9002011-09-16 Eli Zaretskii <eliz@gnu.org>
901
902 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
903 GCC PR/17406) by declaring this function with external scope.
904
7812ba2d
PE
9052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
906
907 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
908 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
909
cf7edc2a
AS
9102011-09-15 Andreas Schwab <schwab@linux-m68k.org>
911
912 * editfns.c (Fformat): Correctly handle text properties on "%%".
913
bd01620e
EZ
9142011-09-15 Eli Zaretskii <eliz@gnu.org>
915
916 * xterm.c (x_draw_composite_glyph_string_foreground):
917 * w32term.c (x_draw_composite_glyph_string_foreground):
918 * term.c (encode_terminal_code):
919 * composite.c (composition_update_it, get_composition_id):
920 * xdisp.c (get_next_display_element)
921 (fill_composite_glyph_string): Add comments about special meaning
922 of TAB characters in a composition.
923
a02719a3
PE
9242011-09-15 Paul Eggert <eggert@cs.ucla.edu>
925
926 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
927 This occurs when processing a multibyte format.
928 Problem reported by Wolfgang Jenker.
a02719a3 929
72589a3c
JB
9302011-09-15 Johan Bockgård <bojohan@gnu.org>
931
932 * xdisp.c (try_cursor_movement): Only check for exact match if
933 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
934
1c14176c
PE
9352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
936
937 Remove unused external symbols.
938 * dispextern.h (calc_pixel_width_or_height): Remove decl.
939 * xdisp.c (calc_pixel_width_or_height): Now static.
940 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
941 * indent.c (check_display_width):
942 * w32term.c: Fix comment to match code.
943 * xterm.c, xterm.h (x_catching_errors): Remove.
944
d2eea5b5
PE
9452011-09-14 Paul Eggert <eggert@cs.ucla.edu>
946
947 * xselect.c: Use signed conversions more consistently (Bug#9498).
948 (selection_data_to_lisp_data): Assume incoming selection data are
949 signed integers, not unsigned. This is to be consistent with
950 outgoing selection data, which was modified to use signed integers
951 in as part of the fix to Bug#9196 in response to Jan D.'s comment
952 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
953 expects long, not unsigned long.
954
46888499
EZ
9552011-09-14 Eli Zaretskii <eliz@gnu.org>
956
957 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
958 computation of loop end. Reported by Johan Bockgård
959 <bojohan@gnu.org>.
960
ef8ef9fb
CY
9612011-09-13 Chong Yidong <cyd@stupidchicken.com>
962
963 * frame.c (Fother_visible_frames_p): Function deleted.
964
fa819fed
EZ
9652011-09-12 Eli Zaretskii <eliz@gnu.org>
966
967 * indent.c (compute_motion): Process display vector front to back
968 rather than the other way around. (Bug#2496)
969
2ba8e008
SM
9702011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
971
972 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
973
20f53c69
CY
9742011-09-11 Chong Yidong <cyd@stupidchicken.com>
975
976 * minibuf.c (Fread_from_minibuffer): Doc fix.
977
d562d7a4
EZ
9782011-09-11 Eli Zaretskii <eliz@gnu.org>
979
980 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
981 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
982
1c4d7f3d
LMI
9832011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
984
985 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
986 value for non-existent files.
987
b885bf36
EZ
9882011-09-11 Eli Zaretskii <eliz@gnu.org>
989
990 * fileio.c (Finsert_file_contents): If the file cannot be opened,
991 set its "size" to -1. This will set the modtime_size field of
992 the corresponding buffer to -1, which is what
993 verify-visited-file-modtime expects for files that do not exist.
994 (Bug#9139)
995
6612f0bf
PE
9962011-09-11 Paul Eggert <eggert@cs.ucla.edu>
997
998 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
999 here ...
1000 * lisp.h: ... from here. push_key_description is no longer
1001 defined in keyboard.c, so its declaration should not be in
1002 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1003 logically belongs with push_key_description.
1004
dfb3f755
PE
10052011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 * buffer.h: Include <sys/types.h> instead of <time.h>.
1008 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1009 Problem reported by Herbert J. Skuhra.
1010
3134906c
LMI
10112011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1012
1013 * xml.c (parse_region): Make the parsing work for
1014 non-comment-starting XML files again (bug#9144).
1015
8d903f4e
AS
10162011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1017
1018 * image.c (gif_load): Fix calculation of bottom and right corner.
1019 (Bug#9468)
1020
80ad64f4
EZ
10212011-09-10 Eli Zaretskii <eliz@gnu.org>
1022
1023 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1024 redisplay in small windows.
1025
208a048d
EZ
10262011-09-09 Eli Zaretskii <eliz@gnu.org>
1027
1028 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1029
9b1c252e
MR
10302011-09-08 Martin Rudalics <rudalics@gmx.at>
1031
1032 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1033 Operate on live windows only.
1034
2949f33b
JB
10352011-09-08 Juanma Barranquero <lekktu@gmail.com>
1036
1037 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1038
e08dcafd
EZ
10392011-09-07 Eli Zaretskii <eliz@gnu.org>
1040
1041 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1042 only under bidi iteration.
1043
115b96bd
JD
10442011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1045
1046 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1047
c8199d0f
PE
10482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1051 Without this fix, the command to link temacs failed due to an
1052 undefined symbol __builtin_isnan. This is because
1053 /usr/include/iso/math_c99.h #defines isnan(x) to
1054 __builtin_isnan(x), but the bundled gcc, which identifies itself
1055 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1056 a __builtin_isnan.
1057 * floatfns.c (isnan): #undef, and then #define to a clone of
1058 what's in data.c.
1059 (Fisnan): Always define, since it's always available now.
1060 (syms_of_floatfns): Always define isnan at the Lisp level.
1061
e39b275c 10622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1063
1064 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1065
b2db44d9 10662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1067
f4af5137 1068 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1069 The previous code assumed that file offsets (off_t values) fit in
1070 EMACS_INT variables, which is not true on typical 32-bit hosts.
1071 The code messed up by falsely reporting buffer overflow in cases
1072 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1073 when "big" contains more than 2**29 bytes, even though this
1074 inserts just one byte and does not overflow the buffer.
1075 (Finsert_file_contents): Store file offsets as off_t
1076 values, not as EMACS_INT values. Check for overflow when
1077 converting between EMACS_INT and off_t. When checking for
1078 buffer overflow or for overlap, take the offsets into account.
1079 Don't use EMACS_INT for small values where int suffices.
1080 When checking for overlap, fix a typo: ZV was used where
1081 ZV_BYTE was intended.
1082 (Fwrite_region): Don't assume off_t fits into 'long'.
1083 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1084
ecfc0a49
MA
10852011-09-05 Michael Albinus <michael.albinus@gmx.de>
1086
1087 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1088
6511acf2 10892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1090
0999621a 1091 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1092
1093 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1094 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1095 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1096 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1097 (modify_event_symbol): Do not assume that the length of
1098 name_alist_or_stem is safe to alloca and fits in int.
1099 (Fexecute_extended_command): Likewise for function name and binding.
1100 (Frecursion_depth): Wrap around reliably on integer overflow.
1101 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1102 since some callers pass EMACS_INT values.
1103 (Fsingle_key_description): Don't crash if symbol name contains more
1104 than MAX_ALLOCA bytes.
1105 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1106 (get_minibuffer): Arg is now EMACS_INT, not int.
1107 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1108 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1109 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1110
2be7d702
PE
1111 * dbusbind.c (signature_cat): New function.
1112 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1113 Do not overrun buffer; instead, report string overflow.
1114
9d1df220
PE
1115 * dispnew.c (add_window_display_history): Don't overrun buffer.
1116 Truncate instead; this is OK since it's just a log.
1117
33ef5c64
PE
1118 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1119 even if the time zone offset is outlandishly large.
1120 Don't mishandle offset == INT_MIN.
1121
66c6fdd5
PE
1122 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1123 when creating daemon; the previous buffer-overflow check was incorrect.
1124
d749b01b
PE
1125 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1126 which has the guts of the old verror function.
1127
b5cd1905
PE
1128 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1129 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1130
6e1a67fb
PE
1131 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1132 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1133 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1134 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1135 length of string rather than counting it via multiple sprintfs;
1136 that's simpler and more reliable.
c21721cc
PE
1137 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1138 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1139 sprintf, in case result does not fit in int.
1140
c57b67fc
PE
1141 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1142 (fontset_from_font): Print it.
1143
8a401434
PE
1144 * frame.c (tty_frame_count): Now printmax_t, not int.
1145 (make_terminal_frame, set_term_frame_name): Print it.
1146 (x_report_frame_params): In X, window IDs are unsigned long,
1147 not signed long, so print them as unsigned.
1148 (validate_x_resource_name): Check for implausibly long names,
1149 and don't assume name length fits in 'int'.
1150 (x_get_resource_string): Don't blindly alloca invocation name;
1151 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1152 not fit in int.
1153
6e1a67fb
PE
1154 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1155 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1156 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1157
0df02bf3
PE
1158 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1159 Use esprintf, not sprintf, in case result does not fit in int.
1160
48e30793
PE
1161 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1162 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1163 it as a large positive number.
1164 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1165 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1166
a66ff6d8
PE
1167 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1168 in case result does not fit in int.
1169
aca216ff
PE
1170 * print.c (float_to_string): Detect width overflow more reliably.
1171 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1172 buffer overrun. Don't assume list length fits in 'int'. Treat
1173 print length of 0 as 0, not as infinity; to be consistent with other
1174 uses of print length in this function. Don't overflow print length
1175 index. Don't assume hash table size fits in 'long', or that
1176 vectorlike size fits in 'unsigned long'.
1177
31c286f7
PE
1178 * process.c (make_process): Use printmax_t, not int, to format
1179 process-name gensyms.
1180
55e5faa1
PE
1181 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1182
80f2e268
PE
1183 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1184 to avoid potential buffer overrun.
1185
670741ab
PE
1186 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1187 if X resource line is longer than 512 bytes.
1188
b7163a50
PE
1189 * xfns.c (x_window): Make sprintf buffer a bit bigger
1190 to avoid potential buffer overrun.
1191
ae58ff1f
PE
1192 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1193
c43c8a6a
PE
1194 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1195
3f8236f4
PE
11962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1197
53e9fe90 1198 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1199 Without these, Emacs silently mishandles large integers sometimes.
1200 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1201 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1202
6511acf2
PE
1203 * xdisp.c (try_window_id): Check Emacs fixnum range before
1204 converting to 'int'.
806add1d 1205
6511acf2 1206 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1207 Check that an Emacs fixnum is in range before assigning it to 'int'.
1208 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1209 values converted from Emacs fixnums.
1210 (Frecenter): Don't wrap around a line count if it is out of 'int'
1211 range; instead, treat it as an extreme value.
1212 (Fset_window_configuration, compare_window_configurations):
1213 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1214
6511acf2
PE
1215 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1216 that can exceed INT_MAX. Check that EMACS_INT value is in range
1217 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1218 (match_limit): Don't assume that a fixnum can fit in 'int'.
1219
6511acf2 1220 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1221 exceed INT_MAX.
1222
6511acf2 1223 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1224 (Fvertical_motion): Don't wrap around LINES values that don't fit
1225 in 'int'. Instead, treat them as extreme values. This is good
1226 enough for windows, which can't have more than INT_MAX lines anyway.
1227
fcb901a7
LMI
12282011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1229
0f2f6b6d
LMI
1230 * Require libxml/parser.h to avoid compilation warning.
1231
fcb901a7
LMI
1232 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1233
1234 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1235 since this reportedly can destroy thread storage.
1236
6e20a0d4
CY
12372011-08-30 Chong Yidong <cyd@stupidchicken.com>
1238
1239 * syntax.c (find_defun_start): Update all cache variables if
1240 exiting early (Bug#9401).
1241
148ae00e
EZ
12422011-08-30 Eli Zaretskii <eliz@gnu.org>
1243
f6cfbd8f
EZ
1244 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1245
148ae00e
EZ
1246 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1247 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1248 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1249
1250 * term.c (tty_append_glyph): New function.
1251 (produce_stretch_glyph): Static function and its prototype deleted.
1252
a66cfb1c
SM
1253 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1254 Add prototypes.
148ae00e 1255
c4a07a4c
PE
12562011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1259 when checking :margin (Bug#9390).
1260 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1261 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1262 so that the name doesn't mislead. All uses changed.
1263
6bc8cd65
JB
12642011-08-28 Johan Bockgård <bojohan@gnu.org>
1265
1266 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1267 set_tty_hooks.
1268
dca4927e
EZ
12692011-08-27 Eli Zaretskii <eliz@gnu.org>
1270
1271 * xdisp.c (move_it_to): Don't bail out early when reaching
1272 position beyond to_charpos, if we are scanning backwards.
1273 (move_it_vertically_backward): When DY == 0, make sure we get to
1274 the first character in the line after the newline.
1275
f2cad773
PE
12762011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1279 (ccl_driver): Do not generate an out-of-range pointer.
1280 (Fccl_execute_on_string): Remove unnecessary check for
1281 integer overflow, noted by Stefan Monnier in
1282 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1283 Remove a FIXME that didn't need fixing.
1284 Simplify the newly-introduced buffer reallocation code.
1285
0cae2cdb
JB
12862011-08-27 Juanma Barranquero <lekktu@gmail.com>
1287
1288 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1289
5fc295a4 12902011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1291
70c60eb2 1292 Integer and memory overflow issues (Bug#9196).
726e0ab1 1293
d31850da
PE
1294 * doc.c (get_doc_string): Rework so that
1295 get_doc_string_buffer_size is the actual buffer size, rather than
1296 being 1 less than the actual buffer size; this makes xpalloc more
1297 convenient.
1298
a69fbedb
PE
1299 * image.c (x_allocate_bitmap_record, cache_image):
1300 * xselect.c (Fx_register_dnd_atom):
1301 Simplify previous changes by using xpalloc.
1302
fe5c5d37
PE
1303 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1304 since either will do and ptrdiff_t is convenient with xpalloc.
1305
0065d054
PE
1306 * charset.c (charset_table_size)
1307 (struct charset_sort_data.priority): Now ptrdiff_t.
1308 (charset_compare): Don't overflow if priorities differ greatly.
1309 (Fsort_charsets): Don't assume list length fits in int.
1310 Check for size-calculation overflow when allocating sort data.
1311 (syms_of_charset): Allocate an initial charset table that is
1312 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1313
1314 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1315
1316 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1317 The actual value is always <= INT_MAX, and leaving it unsigned made
1318 overflow checking harder.
1319
1320 * dispextern.h (struct glyph_matrix.rows_allocated)
1321 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1322 with xpalloc. The values are still always <= INT_MAX.
1323
1324 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1325
1326 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1327 (SAFE_NALLOCA): New macro.
1328
1329 * region-cache.c (struct boundary.pos, find_cache_boundary)
1330 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1331 (set_cache_region, invalidate_region_cache)
1332 (revalidate_region_cache, know_region_cache, region_cache_forward)
1333 (region_cache_backward, pp_cache):
1334 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1335 so that ptrdiff_t * can be passed to xpalloc.
1336 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1337 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1338 (pp_cache): Don't assume cache_len fits in int.
1339 * region-cache.h: Adjust extern decls to match.
1340
1341 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1342 EMACS_INT, since either will do, for xpalloc.
1343
1344 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1345 (xnmalloc, xnrealloc, xpalloc): New functions.
1346
726e0ab1
PE
1347 * bidi.c (bidi_shelve_header_size): New constant.
1348 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1349 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1350
51f30bc5 1351 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1352 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1353 (overlay_strings):
1354 Don't update size of array until after memory allocation succeeds,
1355 because xmalloc/xrealloc may not return.
0065d054
PE
1356 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1357 now that we have proper integer overflow checking.
1358 (record_overlay_string, overlay_strings): Catch overflows when
1359 calculating size of overlay_str_buf.
726e0ab1 1360
0065d054
PE
1361 * callproc.c (Fcall_process): Check for size overflow when
1362 calculating size of args2.
1363 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1364 Normally we prefer signed values, but sticking with ptrdiff_t would
1365 require adding more-complicated checks.
726e0ab1
PE
1366
1367 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1368 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1369 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1370 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1371
1372 * character.c (Fstring): Check for size-calculation overflow.
1373
1374 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1375 unnecessary integer overflow. Check for size overflow.
1376 (encode_coding_object): Don't update size until xmalloc succeeds.
1377
1378 * composite.c (get_composition_id): Check for overflow in glyph
1379 length calculations.
1380
1381 Integer and memory overflow fixes for display code.
1382 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1383 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1384 (scrolling_window): Check for overflow in size calculations.
1385 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1386 Don't assume glyph table len fits in int.
1387 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1388 (row_table_size): Now ptrdiff_t, not int.
1389 (scrolling_window): Avoid overflow in size calculations.
1390 Don't update size until allocation succeeds.
1391 * fns.c (concat): Check for overflow in size calculations.
1392 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1393 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1394 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1395
1396 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1397 (get_doc_string): Check for size calculation overflow.
1398 Don't update size until allocation succeeds.
1399 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1400 EMACS_INT, where ptrdiff_t will do.
1401 (Fsubstitute_command_keys): Check for string overflow.
1402
1403 * editfns.c (set_time_zone_rule): Don't assume environment length
1404 fits in int.
1405 (message_length): Now ptrdiff_t, not int.
1406 (Fmessage_box): Don't update size until allocation succeeds.
1407 Don't assume message length fits in int.
1408 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1409
0065d054
PE
1410 * emacs.c (main): Do not reallocate argv, since there is a null at
1411 the end that can be overwritten, and this way there's no need to
1412 worry about size-calculation overflow.
1413 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1414
1415 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1416 alloc succeeds.
1417 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1418
1419 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1420 (x_set_scroll_bar_width, x_figure_window_size):
1421 Check for integer overflow.
1422 (x_set_alpha): Do not assume XINT fits in int.
1423
1424 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1425 This is for the members text_lines, text_cols, total_lines, total_cols,
1426 where the system imposes an 'int' limit.
1427
1428 * fringe.c (Fdefine_fringe_bitmap):
1429 Don't update size until alloc works.
1430
1431 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1432 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1433
1434 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1435 Check for size-calculation overflow.
1436 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1437 do, as we prefer signed integers.
1438 (id_to_widget.max_size, id_to_widget.used)
1439 (xg_store_widget_in_map, xg_remove_widget_from_map)
1440 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1441 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1442 Use and return ptrdiff_t, not int.
1443 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1444 * gtkutil.h: Change prototypes to match the above.
1445
1446 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1447 are duplicate now that they've been promoted to lisp.h.
1448 (x_allocate_bitmap_record, x_alloc_image_color)
1449 (make_image_cache, cache_image, xpm_load):
1450 Don't update size until alloc is done.
1451 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1452 (x_detect_edges):
3256efce 1453 Check for size calculation overflow.
726e0ab1
PE
1454 (ct_colors_allocated_max): New constant.
1455 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1456 overflow.
3256efce 1457
726e0ab1
PE
1458 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1459 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1460 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1461 Use ptrdiff_t, not int, to count maps.
1462 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1463 calculations. Don't update size until allocation succeeds.
1464 Redo calculations to avoid overflow.
726e0ab1
PE
1465 * keyboard.h: Change prototypes to match the above.
1466
1467 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1468 to count maps.
1469 (current_minor_maps): Check for size calculation overflow.
1470 * keymap.h: Change prototypes to match the above.
1471
1472 * lread.c (read1, init_obarray): Don't update size until alloc done.
1473
1474 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1475 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1476
726e0ab1
PE
1477 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1478 Now ptrdiff_t, not int.
1479 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1480 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1481
1482 * process.c (Fnetwork_interface_list): Check for overflow
1483 in size calculation.
1484
1485 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1486
1487 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1488 overflow. Don't bother calling xmalloc when xrealloc will do.
1489
1490 * search.c (Freplace_match): Check for size calculation overflow.
1491 (Fset_match_data): Don't assume list lengths fit in 'int'.
1492
1493 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1494 for command line length. Do not attempt to address one before the
1495 beginning of an array, as that's not portable.
1496
1497 * term.c (max_frame_lines): Remove; unused.
1498 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1499 not int.
1500 (encode_terminal_code, calculate_costs): Check for size
1501 calculation overflow.
1502 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1503 table lengths and related sizes. Don't update size until alloc
1504 done. Redo calculations to avoid overflow.
1505 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1506
1507 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1508 subtracting pointers.
1509 (gobble_line): Check for overflow more carefully. Don't update size
1510 until alloc done.
1511
1512 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1513 Don't update size until alloc done.
1514 Redo size calculations to avoid overflow.
1515 Check for size calculation overflow.
0065d054 1516 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1517
1518 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1519 Use ptrdiff_t, not int, for sizes.
1520 (store_mode_line_noprop_char): Don't update size until alloc done.
1521
0065d054
PE
1522 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1523 Use ptrdiff_t, not int, for sizes.
1524 (Finternal_make_lisp_face, cache_face):
1525 Check for size calculation overflow.
1526 (cache_face): Treat size calculation overflows as if they were
1527 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1528
1529 * xfns.c (x_encode_text, x_set_name_internal)
1530 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1531 sizes, since they can exceed INT_MAX in size. Check for size
1532 calculation overflow.
1533
0065d054
PE
1534 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1535 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1536 Don't update size until alloc done.
1537
0065d054 1538 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1539 as sprintf is limited to int lengths.
1d526e2f 1540
252c5ee1
PE
1541 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1542 (X_LONG_MIN): New macros.
864d7ce7
PE
1543 Use them to make the following changes clearer.
1544 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1545 This change doesn't affect the value now, but it may help remind
1546 future maintainers not to raise the value too much later.
1547 (SELECTION_QUANTUM): Remove, replacing with ...
1548 (selection_quantum): ... new function, which avoids overflow.
1549 All uses changed.
1550 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1551 assumption that selection length fits in 'int'.
1552 (x_reply_selection_request, x_handle_selection_request)
1553 (x_get_window_property, receive_incremental_selection)
1554 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1555 (lisp_data_to_selection_data, clean_local_selection_data):
1556 Use ptrdiff_t, not int, to record length of selection.
1557 (x_reply_selection_request, x_get_window_property)
1558 (receive_incremental_selection, x_property_data_to_lisp):
1559 Redo calculations to avoid overflow.
1560 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1561 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1562 something.
1563 (x_get_window_property, receive_incremental_selection)
1564 (lisp_data_to_selection_data, x_property_data_to_lisp):
1565 Check for size-calculation overflow.
1566 (x_get_window_property, receive_incremental_selection)
1567 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1568 Don't store size until memory allocation succeeds.
1569 (x_get_window_property): Plug memory leak on memory exhaustion.
1570 Don't double-block input; malloc is safe here. Don't assume 2**34
1571 - 4 fits in unsigned long. Add an xassert to check
1572 XGetWindowProperty overflow. Be more careful about overflow
1573 calculations, and distinguish size from memory overflow better.
1574 (receive_incremental_selection): When tracing, don't assume
1575 unsigned int is less than INT_MAX.
1576 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1577 harmful) conversions of unsigned short to int.
1578 (lisp_data_to_selection_data): Don't assume that integers
1579 in the range -65535 through -1 fit in an X unsigned short.
1580 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1581 result parameters unless successful. Rely on cons_to_unsigned
1582 to report problems with elements; the old code wasn't right anyway.
1583 (x_check_property_data): Check for int overflow; we cannot use
1584 a wider type due to X limits.
1585 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1586
726e0ab1 1587 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1588
0065d054
PE
1589 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1590 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1591 (x_color_cells): Don't store size until memory allocation succeeds.
1592 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1593 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1594 (x_term_init): Don't assume length fits in int (sprintf is limited
1595 to int size).
bc18e09d 1596
ebfa62c0
PE
1597 Use ptrdiff_t for composition IDs.
1598 * character.c (lisp_string_width):
1599 * composite.c (composition_table_size, n_compositions)
1600 (get_composition_id, composition_gstring_from_id):
1601 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1602 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1603 * window.c (Frecenter):
1604 Use ptrdiff_t, not int, for composition IDs.
1605 * composite.c (get_composition_id): Check for integer overflow.
1606 * composite.h: Adjust prototypes to match the above changes.
1607
d3411f89
PE
1608 Use ptrdiff_t for hash table indexes.
1609 * category.c (hash_get_category_set):
1610 * ccl.c (ccl_driver):
1611 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1612 * coding.c (coding_system_charset_list, detect_coding_system):
1613 * coding.h (struct coding_system.id):
1614 * composite.c (get_composition_id, gstring_lookup_cache):
1615 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1616 * image.c (xpm_get_color_table_h):
1617 * lisp.h (hash_lookup, hash_put):
1618 * minibuf.c (Ftest_completion):
1619 Use ptrdiff_t for hash table indexes, not int (which is too
1620 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1621 32-bit --with-wide-int hosts).
1622
e097a6fa
PE
1623 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1624 Add a FIXME comment about memory leaks.
1625 (syms_of_charset): Don't assume xmalloc returns.
1626
5637687f
PE
1627 Don't assume that stated character widths fit in int.
1628 * character.c (Fchar_width, c_string_width, lisp_string_width):
1629 * character.h (CHAR_WIDTH):
1630 * indent.c (MULTIBYTE_BYTES_WIDTH):
1631 Use sanitize_char_width to avoid undefined and/or bad behavior
1632 with outlandish widths.
a66cfb1c 1633 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1634 now that we have two such functions. All uses changed.
1635 (sanitize_char_width): New inline function.
1636
a2271ba2
PE
1637 Don't assume that tab-width fits in int.
1638 * character.h (sanitize_width): New inline function.
1639 (SANE_TAB_WIDTH): New macro.
1640 (ASCII_CHAR_WIDTH): Use it.
1641 * indent.c (sane_tab_width): Remove. All uses replaced by
1642 SANE_TAB_WIDTH (current_buffer).
1643 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1644
18c52557
PE
1645 * fileio.c: Integer overflow issues with file modes.
1646 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1647
caeeedc1
PE
1648 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1649 Remove unreachable code.
1650 (read_hex, load_charset_map_from_file): Check for integer overflow.
1651
50849c52
PE
1652 * xterm.c: don't go over XClientMessageEvent limit
1653 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1654 (x_send_scroll_bar_event): Likewise. Check that the size does not
1655 exceed limits imposed by XClientMessageEvent, as well as the usual
1656 ptrdiff_t and size_t limits.
1657
b13995db
PE
1658 * keyboard.c: Overflow, signedness and related fixes.
1659 (make_lispy_movement): Use same integer type in forward decl
1660 that is used in the definition.
1661 (read_key_sequence, keyremap_step):
1662 Change bufsize argument back to int, undoing my 2011-03-30 change.
1663 We prefer signed types, and int is wide enough here.
1664 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1665 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1666 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1667 length, not size_t. Use ptrdiff_t for index, not int.
1668 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1669 possibility of integer overflow.
1670
13464394
PE
1671 Overflow, signedness and related fixes for images.
1672
1673 * dispextern.h (struct it.stack[0].u.image.image_id)
1674 (struct_it.image_id, struct image.id, struct image_cache.size)
1675 (struct image_cache.used, struct image_cache.ref_count):
1676 * gtkutil.c (update_frame_tool_bar):
1677 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1678 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1679 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1680 * nsmenu.m (update_frame_tool_bar):
1681 * xdisp.c (calc_pixel_width_or_height):
1682 * xfns.c (image_cache_refcount):
1683 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1684 on typical 64-bit hosts.
1685
1686 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1687 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1688 Omit unnecessary casts to int.
1689 (parse_image_spec): Check that integers fall into 'int' range
1690 when the callers expect that.
1691 (image_ascent): Redo ascent calculation to avoid int overflow.
1692 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1693 (lookup_image): Remove unnecessary tests.
1694 (xbm_image_p): Locals are now of int, not EMACS_INT,
1695 since parse_image_check makes sure they fit into int.
1696 (png_load, gif_load, svg_load_image):
1697 Prefer int to unsigned where either will do.
1698 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1699 old tiff_error_handler and tiff_warning_handler.
1700 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1701 stack buffer overflows. It uses only the features of vsnprintf
1702 that are common to both POSIX and native Microsoft.
1703 (tiff_error_handler, tiff_warning_handler): Use it.
1704 (tiff_load, gif_load, imagemagick_load_image):
1705 Don't assume :index value fits in 'int'.
1706 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1707 (imagemagick_load_image): Check that crop parameters fit into
1708 the integer types that MagickCropImage accepts. Don't assume
1709 Vimagemagick_render_type has a nonnegative value. Don't assume
1710 size_t fits in 'long'.
1711 (gs_load): Use printmax_t to print the widest integers possible.
1712 Check for integer overflow when computing image height and width.
1713
c11821d4
EZ
17142011-08-26 Eli Zaretskii <eliz@gnu.org>
1715
1716 * xdisp.c (redisplay_window): Don't force window start if point
1717 will be invisible in the resulting window. (Bug#9324)
1718
0c95fcf7
EZ
17192011-08-25 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1722 the display spec is of the form `(space ...)'.
1723 (handle_display_spec): Return the value returned by
1724 handle_single_display_spec, not just 1 or zero.
1725 (handle_single_display_spec): If the display spec is of the form
1726 `(space ...)', and specifies display in the text area, return 2
1727 rather than 1.
fee65a97 1728 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1729 accurately, and prefer exact match for point under bidi.
1730 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1731
1732 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1733 into disp_prop; all users changed.
1734
1735 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1736 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1737 for the text covered by the display property.
1738
e4ed06f1
CY
17392011-08-25 Chong Yidong <cyd@stupidchicken.com>
1740
1741 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1742 Change return value to nil.
1743 (Frecord_buffer): Delete unused function.
1744
f67cdd7f
EZ
17452011-08-24 Eli Zaretskii <eliz@gnu.org>
1746
5980d4c6
EZ
1747 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1748 buffers, return left-to-right.
8610fe8b
EZ
1749 (set_cursor_from_row): Consider candidate row a win if its glyph
1750 represents a newline and point is on that newline. Fixes cursor
1751 positioning on the newline at EOL of R2L text within L2R
1752 paragraph, and vice versa.
1753 (try_cursor_movement): Check continued rows, in addition to
1754 continuation rows. Fixes unwarranted scroll when point enters a
1755 continued line of R2L text within an L2R paragraph, or vice versa.
1756 (cursor_row_p): Consider the case of point being equal to
1757 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1758 from the end of a short line to the beginning of a continued line
1759 of R2L text within L2R paragraph.
1760 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1761 composed characters.
5980d4c6 1762
f67cdd7f
EZ
1763 * bidi.c (bidi_check_type): Use xassert.
1764 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1765 members.
1766
bca633fb
EZ
17672011-08-23 Eli Zaretskii <eliz@gnu.org>
1768
1769 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1770 a character.
1771
4a5885a7
CY
17722011-08-23 Chong Yidong <cyd@stupidchicken.com>
1773
1774 * nsfont.m (ns_otf_to_script): Fix typo.
1775
0902a04e
KH
17762011-08-22 Kenichi Handa <handa@m17n.org>
1777
1778 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1779 extra slot even if the purpose is char-code-property-table.
1780
1a2e6670
EZ
17812011-08-23 Eli Zaretskii <eliz@gnu.org>
1782
8ddde651
EZ
1783 * xdisp.c (redisplay_window): When computing centering_position,
1784 account for the height of the header line. (Bug#8874)
1785
425cc014
EZ
1786 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1787 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1788 candidate is selected by the mouse, and that candidate has a
1789 composed character under the mouse.
1790
1a2e6670
EZ
1791 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1792 coordinates reported by pos-visible-in-window-p for a composed
1793 character in column zero.
1794
8b76d6f8
SM
17952011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1796
1797 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1798
dac347dd
EZ
17992011-08-22 Eli Zaretskii <eliz@gnu.org>
1800
1801 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1802 consider it a hit if to_charpos is anywhere in the range of the
1803 composed buffer positions.
1804
e013fb34
CY
18052011-08-22 Chong Yidong <cyd@stupidchicken.com>
1806
1807 * image.c (gif_load): Don't assume that each subimage has the same
1808 dimensions as the base image. Handle disposal method that is
1809 "undefined" by the gif spec (Bug#9335).
1810
bd1ba3e8
CY
18112011-08-20 Chong Yidong <cyd@stupidchicken.com>
1812
1813 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1814 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1815
54a1215b
EZ
18162011-08-19 Eli Zaretskii <eliz@gnu.org>
1817
823564e5
EZ
1818 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1819 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1820 from an Org mode buffer to a Speedbar frame.
1821
54a1215b
EZ
1822 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1823 a composition, take its buffer position from IT->cmp_it.charpos.
1824 Fixes cursor positioning at the beginning of a line that begins
1825 with a composed character.
1826
9778ebcc
EZ
18272011-08-18 Eli Zaretskii <eliz@gnu.org>
1828
0be6ee06
EZ
1829 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1830 character bidirectional type, use STRONG_L instead. Fixes crashes
1831 in a buffer produced by `describe-categories'.
1832
9778ebcc
EZ
1833 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1834 members before the level stack, so they would be saved and
1835 restored when copying iterator state. Fixes incorrect reordering
1836 around TABs covered by display properties.
1837
156bffbe
AS
18382011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1839
6b02f655 1840 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1841
72ad093b
CY
18422011-08-17 Chong Yidong <cyd@stupidchicken.com>
1843
1844 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1845 (internal_condition_case_2, internal_condition_case_n):
1846 Remove unnecessary aborts (Bug#9081).
72ad093b 1847
35774242
EZ
18482011-08-17 Eli Zaretskii <eliz@gnu.org>
1849
1850 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1851 has no `load' handler, try opening the file locally. (Bug#9311)
1852
db76dd85
KB
18532011-08-16 Ken Brown <kbrown@cornell.edu>
1854
1855 * gmalloc.c: Expand comment.
1856
b215eee5
EZ
18572011-08-16 Eli Zaretskii <eliz@gnu.org>
1858
1859 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1860 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1861
a4579d33
KB
18622011-08-16 Ken Brown <kbrown@cornell.edu>
1863
1864 Fix memory allocation problems in Cygwin build (Bug#9273).
1865
1866 * unexcw.c ( __malloc_initialized): Declare external variable.
1867 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1868
8b76d6f8
SM
1869 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1870 New variables.
a4579d33
KB
1871 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1872 dumped emacs.
1873 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1874 in the static heap.
1875 [CYGWIN] (special_realloc): New function.
1876 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1877 requests to realloc storage in the static heap.
1878
3ebec551
PE
18792011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 * bidi.c (bidi_initialize): Remove unused local.
1882
9fd8be00
EZ
18832011-08-15 Eli Zaretskii <eliz@gnu.org>
1884
6b02f655
SM
1885 * bidimirror.h:
1886 * biditype.h: Remove file.
1887 * makefile.w32-in ($(BLD)/bidi.$(O)):
1888 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1889
1890 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1891
1892 * chartab.c: Improve commentary for the uniprop_table API.
1893
32413314
EZ
1894 * bidi.c (bidi_paragraph_init): Support zero value of
1895 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1896 (bidi_initialize): Use uniprop_table instead of including
1897 biditype.h and bidimirror.h.
32413314 1898
9fd8be00
EZ
1899 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1900 coordinates of the iterator when restoring from ppos_it.
1901 (Bug#9296)
1902
5cf2b69b
KH
19032011-08-14 Kenichi Handa <handa@m17n.org>
1904
1905 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1906 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1907
daf17d00
EZ
19082011-08-14 Eli Zaretskii <eliz@gnu.org>
1909
1910 * xdisp.c (move_it_in_display_line_to): Don't invoke
1911 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1912 ppos_it. Fixes vertical cursor motion when line beginning is
1913 covered by an image. (Bug#9296)
1914
08e3161a
JD
19152011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1916
1917 * nsterm.h (ns_run_ascript): Declare.
1918 (NSAPP_DATA2_RUNASSCRIPT): Define.
1919
1920 * nsfns.m (as_script, as_result, as_status): New static variables.
1921 (ns_run_ascript): New function.
5e617bc2 1922 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1923 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1924 the event loop. Get status from as_status (Bug#7276).
1925
1926 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1927 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1928 the event loop (Bug#7276).
1929
a3720aa2
AS
19302011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1931
1932 * gnutls.c (QCgnutls_bootprop_priority)
1933 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1934 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1935 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1936 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1937 (QCgnutls_bootprop_verify_hostname_error)
1938 (QCgnutls_bootprop_callbacks_verify): Rename from
1939 Qgnutls_bootprop_..., all uses changed.
1940
1941 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1942 uses changed.
1943
0a0d27fb
PE
19442011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1945
19d5c50c
PE
1946 * xfaces.c (Qframe_set_background_mode): Now static.
1947 * dispextern.h (Qframe_set_background_mode): Remove decl.
1948
0a0d27fb
PE
1949 * process.c (Fnetwork_interface_info): Declare local only if needed.
1950
377538cb
JD
19512011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1952
1953 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1954 (Fnetwork_interface_list): Allocate in increments of bytes instead
1955 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1956 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1957 sockaddr.
1958 (struct ifflag_def): notrailers is smart on OSX.
1959 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1960 Get hardware address with getifaddrs if available.
1961
08fff70c
EZ
19622011-08-12 Eli Zaretskii <eliz@gnu.org>
1963
1964 * xdisp.c (iterate_out_of_display_property): xassert that
1965 IT->position is set to within IT->object's boundaries. Break from
1966 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1967 when IT->position is set up wrongly due to some bug.
1968 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1969 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1970 entry. Force push_it to save on the stack the current
1971 buffer/string position, to be restored by pop_it. Fix flags in
1972 the iterator structure wrt the object coming from a display
1973 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1974 properties. (Bug#9284)
1975
7be1c708 19762011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1977
7be1c708
CY
1978 * fontset.c (fontset_get_font_group): Add proper type checks.
1979 (Bug#9172)
aac0c6e3 1980
7be1c708 19812011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1982
7be1c708
CY
1983 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1984 and LC_VERSION_MIN_MACOSX.
1985 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1986 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1987
97bb72a6
EZ
19882011-08-08 Eli Zaretskii <eliz@gnu.org>
1989
1990 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1991 no-display-properties-and-no-overlays under bidi display.
1992 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1993 properties and overlays.
97bb72a6 1994
d5617611
CY
19952011-08-08 Chong Yidong <cyd@stupidchicken.com>
1996
37e11a63
CY
1997 * editfns.c (Fset_time_zone_rule): Document relationship with the
1998 setenv function.
1999
d5617611
CY
2000 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2001 the font entity extracted from the cache (Bug#8109).
2002
58872834
CY
20032011-08-07 Chong Yidong <cyd@stupidchicken.com>
2004
2005 * composite.c (autocmp_chars): Don't reset point. That is done by
2006 restore_point_unwind (Bug#5984).
2007
75bfc667
JL
20082011-08-07 Juri Linkov <juri@jurta.org>
2009
2010 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2011 to show the arg `TIME' instead of `TIMEVAL'.
2012
d1410150
EZ
20132011-08-06 Eli Zaretskii <eliz@gnu.org>
2014
2015 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2016 display property strides EOL and includes a newline, as in
2017 longlines-mode. (Bug#9254)
75b771e4
EZ
2018 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2019 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2020
2021 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2022 is non-zero, even if the data buffer is NULL. Fixes a crash in
2023 vertical-motion with longlines-mode. (Bug#9254)
2024
35928349
EZ
20252011-08-05 Eli Zaretskii <eliz@gnu.org>
2026
ec7cc85b
EZ
2027 * bidi.c <bidi_cache_total_alloc>: Now static.
2028 (bidi_initialize): Initialize bidi_cache_total_alloc.
2029
8b76d6f8 2030 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2031 cache. (Bug#9221)
2032
2033 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2034 amount allocated this far in `bidi_cache_total_alloc'.
2035 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2036 non-zero, only free the data buffer without restoring the cache
2037 contents. All callers changed.
2038
2039 * dispextern.h (bidi_unshelve_cache): Update prototype.
2040
2041 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2042 (move_it_in_display_line, move_it_to)
2043 (move_it_vertically_backward, move_it_by_lines): Replace the call
2044 to xfree to an equivalent call to bidi_unshelve_cache.
2045 (move_it_in_display_line_to): Fix logic of returning
412b6358 2046 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2047
e2e2423b
EZ
20482011-08-05 Eli Zaretskii <eliz@gnu.org>
2049
2050 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2051 came from a string character with a `cursor' property. (Bug#9229)
2052
ae9e757a
JD
20532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2054
2055 * Makefile.in (LIB_PTHREAD): New variable.
2056 (LIBES): Add LIB_PTHREAD (Bug#9216).
2057
2058 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2059 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2060
213bd7f2
AS
20612011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2062
6b02f655 2063 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2064
99aaf75f
JD
20652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2066
2067 * xterm.c (x_find_topmost_parent): New function.
2068 (x_set_frame_alpha): Find topmost parent window with
2069 x_find_topmost_parent and set the property there also (bug#9181).
2070 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2071
c74e9d86
PE
20722011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 * callproc.c (Fcall_process): Avoid vfork clobbering
2075 the local vars buffer, coding_systems, current_dir.
2076
640c8776
SM
20772011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2078
2079 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2080
f26d0e4c
PE
20812011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2082
8a10d76c
PE
2083 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2084 so that it is not optimized away.
2085
f26d0e4c
PE
2086 * xdisp.c (compute_display_string_pos): Remove unused local.
2087
55439c61
EZ
20882011-08-02 Eli Zaretskii <eliz@gnu.org>
2089
2090 Fix slow cursor motion and scrolling in large buffers with
2091 selective display, like Org Mode buffers. (Bug#9218)
2092
2093 * dispextern.h (struct bidi_it): New member disp_prop_p.
2094
2095 * xdisp.c: Remove one-slot cache of display string positions.
2096 (compute_display_string_pos): Accept an additional argument
5e617bc2 2097 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2098 for a display string or property. If found, set DISP_PROP_P
2099 non-zero.
2100
2101 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2102 DISP_PROP_P, and pass it to compute_display_string_pos.
2103 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2104 non-zero. All callers of bidi_fetch_char changed.
2105
fb33fa43
SM
21062011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2107
2108 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2109
b099e063
DM
21102010-12-03 Don March <don@ohspite.net>
2111
2112 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2113 last character M-[char] is translated to ESC [char] (bug#7541).
2114
5cc7f7af
KH
21152011-08-02 Kenichi Handa <handa@m17n.org>
2116
d0fffa3f 2117 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2118
2119 * chartab.c (uniprop_table): Make it non-static.
2120
525d5e6e
EZ
21212011-08-01 Eli Zaretskii <eliz@gnu.org>
2122
2123 * xdisp.c (forward_to_next_line_start): Accept additional argument
2124 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2125 on the newline.
2126 (reseat_at_next_visible_line_start): Use the bidi iterator state
2127 returned by forward_to_next_line_start to restore the state of
2128 it->bidi_it after backing up to previous newline. (Bug#9212)
2129
31011111
AS
21302011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2131
2132 * regex.c (re_comp): Protoize.
2133 (re_exec): Fix return type.
2134 (regexec): Fix type of `ret'. (Bug#9203)
2135
476371c4
PE
21362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2137
e5d76069
PE
2138 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2139 This is needed if max-image-size is a floating-point number.
2140
9a79b20c
AS
21412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2142
2143 * print.c (print_object): Print empty symbol as ##.
2144
2145 * lread.c (read1): Read ## as empty symbol.
2146
d8c2fa78
AA
21472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2148
2149 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2150 setting frame foreground color (Bug#9175).
2151 (x_set_background_color): Likewise.
2152
ffe57a7a
AA
2153 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2154 contents (Bug#9176).
2155 (EmacsTooltip -init): Remove bezels and add shadows to
2156 tooltip windows.
2157
bf3492a5
AA
2158 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2159 or scroll bar (Bug#8470).
2160
d55e9c53
AA
2161 * nsfont.m (nsfont_open): Remove assignment to voffset and
2162 unnecessary vars hshink, expand, hd, full_height, min_height.
2163 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2164
2165 * nsterm.h (nsfont_info): Remove voffset field.
2166
d8c2fa78 21672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2168
2169 Implement strike-through and overline on NextStep (Bug#8863).
2170
2171 * nsfont.m (nsfont_open): Use underline position provided by font,
2172 instead of hard-coded value of 2.
2173 (nsfont_draw): Call ns_draw_text_decoration instead.
2174
2175 * nsterm.h: Add declaration for ns_draw_text_decoration.
2176
2177 * nsterm.m (ns_draw_text_decoration): New function for drawing
2178 underline, overline, and strike-through.
2179 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2180 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2181 accommodate underlining, etc.
4843aac3 2182
4cc60b9b
EZ
21832011-07-28 Eli Zaretskii <eliz@gnu.org>
2184
bc7ece87
EZ
2185 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2186 default.
4cc60b9b 2187
476371c4
PE
21882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2189
66606eea
PE
2190 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2191 Without this fix, if a signal arrives just after memory fills up,
2192 'malloc' might be invoked reentrantly.
2193
476371c4
PE
2194 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2195 In other words, assume that every image size is allowed, on non-X
2196 hosts. This assumption is probably wrong, but it lets Emacs compile.
2197
f3fcc40d
AS
21982011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2199
2200 * regex.c (re_iswctype): Convert return values to boolean.
2201
350c992f
EZ
22022011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2203
2204 * xdisp.c (compute_display_string_pos): Don't use cached display
2205 string position if the buffer had its restriction changed.
2206 (Bug#9184)
2207
5266b4bb
PE
22082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2211
2573a837 22122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2213
41f55ccd 2214 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2215
39e378da
PE
2216 * bidi.c: Integer size and overflow fixes.
2217 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2218 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2219 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2220 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2221 (bidi_find_other_level_edge):
2222 Use ptrdiff_t instead of EMACS_INT where either will do.
2223 This works better on 32-bit hosts configured --with-wide-int.
2224 (bidi_cache_ensure_space): Check for size-calculation overflow.
2225 Use % rather than repeated addition, for better worst-case speed.
2226 Don't set bidi_cache_size until after xrealloc returns, because it
2227 might not return.
2228 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2229 (bidi_cache_ensure_space): Also check that the bidi cache size
2230 does not exceed that of the largest Lisp string or buffer. See Eli
2231 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2232
5e927815
PE
2233 * alloc.c (__malloc_size_t): Remove.
2234 All uses replaced by size_t. See Andreas Schwab's note
2235 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2236
ca4aa935
PE
2237 * image.c: Improve checking for integer overflow.
2238 (check_image_size): Assume that f is nonnull, since
2239 it is always nonnull in practice. This is one less thing to
2240 worry about when checking for integer overflow later.
2241 (x_check_image_size): New function, which checks for integer
2242 overflow issues inside X.
2243 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2244 This removes the need for a memory_full check.
2245 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2246 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2247 (xbm_read_bitmap_data): Change locals back to 'int', since
2248 their values must fit in 'int'.
2249 (xpm_load_image, png_load, tiff_load):
2250 Invoke x_create_x_image_and_pixmap earlier,
2251 to avoid much needless work if the image is too large.
2252 (tiff_load): Treat overly large images as if
2253 x_create_x_image_and_pixmap failed, not as malloc failures.
2254 (gs_load): Use x_check_image_size.
2255
5f8f9cc2
PE
2256 * gtkutil.c: Omit integer casts.
2257 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2258 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2259
5adf60bc
PE
2260 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2261
c8907a93
PE
2262 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2263 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2264 would wrongly return t on a 64-bit host.
2265
e3c25c68
PE
2266 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2267 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2268 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2269 and therefore cause GCC to emit a bogus diagnostic in some cases.
2270
3f791afe
PE
2271 * image.c: Integer signedness and overflow and related fixes.
2272 This is not an exhaustive set of fixes, but it's time to
2273 record what I've got.
2274 (lookup_pixel_color, check_image_size): Remove redundant decls.
2275 (check_image_size): Don't assume that arbitrary EMACS_INT values
2276 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2277 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2278 (tiff_load, imagemagick_load_image):
2279 Check for overflow in size calculations.
2280 (x_create_x_image_and_pixmap): Remove unnecessary test for
2281 xmalloc returning NULL; that can't happen.
2282 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2283 (xpm_color_bucket): Use better integer hashing function.
2284 (xpm_cache_color): Don't possibly over-allocate memory.
2285 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2286 (gif_memory_source):
2287 Use ptrdiff_t, not int or size_t, to record sizes.
2288 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2289 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2290 either works, as we prefer signed integers.
2291 (tiff_read_from_memory, tiff_write_from_memory):
2292 Return tsize_t, not size_t, since that's what the TIFF API wants.
2293 (tiff_read_from_memory): Don't fail simply because the read would
2294 go past EOF; instead, return a short read.
2295 (tiff_load): Omit no-longer-needed casts.
2296 (Fimagemagick_types): Don't assume size fits into 'int'.
2297
3cc5a532
PE
2298 Improve hashing quality when configured --with-wide-int.
2299 * fns.c (hash_string): New function, taken from sxhash_string.
2300 Do not discard information about ASCII character case; this
2301 discarding is no longer needed.
2302 (sxhash-string): Use it. Change sig to match it. Caller changed.
2303 * lisp.h: Declare it.
2304 * lread.c (hash_string): Remove, since we now use fns.c's version.
2305 The fns.c version returns a wider integer if --with-wide-int is
2306 specified, so this should help the quality of the hashing a bit.
2307
b312a492
PE
2308 * emacs.c: Integer overflow minor fix.
2309 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2310 Define only if GNU_LINUX.
2311 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2312
dfd153ae
PE
2313 * dispnew.c: Integer signedness and overflow fixes.
2314 Remove unnecessary forward decls, that were a maintenance hassle.
2315 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2316 All uses changed.
2317 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2318 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2319 (prepare_desired_row, line_draw_cost):
2320 Use int, not unsigned, where either works.
2321 (save_current_matrix, restore_current_matrix):
2322 Use ptrdiff_t, not size_t, where either works.
2323 (init_display): Check for overflow more accurately, and without
2324 relying on undefined behavior.
2325
a81d11a3
PE
2326 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2327 Remove, replacing with the new symbols in lisp.h. All uses changed.
2328 * fileio.c (make_temp_name):
2329 * filelock.c (lock_file_1, lock_file):
2330 * xdisp.c (message_dolog):
2331 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2332 Use pMd etc. instead.
2333 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2334 replacing the pWIDE etc. symbols removed from editfns.c.
2335
3300e6fd
PE
2336 * keyboard.h (num_input_events): Now uintmax_t.
2337 This is (very slightly) less likely to mess up due to wraparound.
2338 All uses changed.
2339
fd05c7e9
PE
2340 * buffer.c: Integer signedness fixes.
2341 (alloc_buffer_text, enlarge_buffer_text):
2342 Use ptrdiff_t rather than size_t when either will do, as we prefer
2343 signed integers.
2344
903fe15d
PE
2345 * alloc.c: Integer signedness and overflow fixes.
2346 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2347 (__malloc_size_t): Default to size_t, not to int.
2348 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2349 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2350 Prefer ptrdiff_t to size_t when either would do, as we prefer
2351 signed integers.
2352 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2353 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2354 Now const. Initialize with values that are in range even if char
2355 is signed.
2356 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2357 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2358 These functions do the right thing with sizes > 2**32.
2359 (check_depth): Now ptrdiff_t, not int.
2360 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2361 Adjust to new way of storing sizes. Check for size overflow bugs
2362 in rest of code.
2363 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2364 slightly wrong anyway, as it missed one instance of
2365 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2366 (refill_memory_reserve): Omit needless cast to size_t.
2367 (mark_object_loop_halt): Mark as externally visible.
2368
ac82cc6a
PE
2369 * xselect.c: Integer signedness and overflow fixes.
2370 (Fx_register_dnd_atom, x_handle_dnd_message):
2371 Use ptrdiff_t, not size_t, since we prefer signed.
2372 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2373 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2374 x_dnd_atoms_size and x_dnd_atoms_length.
2375
c2d1e36d
PE
2376 * doprnt.c: Prefer signed to unsigned when either works.
2377 * eval.c (verror):
2378 * doprnt.c (doprnt):
2379 * lisp.h (doprnt):
2380 * xdisp.c (vmessage):
2381 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2382 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2383 prefer signed arithmetic to avoid comparison confusion.
2384 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2385 but is a bit tricky.
2386
0e926e56
PE
2387 Assume freestanding C89 headers, string.h, stdlib.h.
2388 * data.c, doprnt.c, floatfns.c, print.c:
2389 Include float.h unconditionally.
2390 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2391 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2392 * regex.c: Likewise for stddef.h, string.h.
2393 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2394 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2395 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2396 (STDC_HEADERS): Remove obsolete defines.
2397 * sysdep.c: Include limits.h unconditionally.
2398
9cfdb3ec
PE
2399 Assume support for memcmp, memcpy, memmove, memset.
2400 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2401 * regex.c (memcmp, memcpy):
2402 Remove; we assume C89 now.
2403
2404 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2405 (__malloc_safe_bcopy): Remove; no longer needed.
2406
cf950e6b 2407 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2408 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2409 well either way, and we prefer signed to unsigned.
2410
dbf38e02
LMI
24112011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2412
2413 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2414 closes the connection while we're reading (bug#9182).
2415
d6f0886c 24162011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2417
d6f0886c
JD
2418 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2419 are specified (Bug#9168).
24e0f6b1 2420
2eb1f9e6
PE
24212011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2424 Found by GCC static checking and --with-wide-int on a 32-bit host.
2425
22381272 24262011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2427
2428 * xdisp.c (compute_display_string_pos): Fix logic of caching
2429 previous display string position. Initialize cached_prev_pos to
2430 -1. Fixes slow-down at the beginning of a buffer.
2431
f25e39b4
EZ
24322011-07-24 Eli Zaretskii <eliz@gnu.org>
2433
2434 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2435 for attrs[LFACE_FONTSET_INDEX].
2436
04c4b52e
PE
24372011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * xml.c (parse_region): Remove unused local
2440 that was recently introduced.
2441
c1734fbd
EZ
24422011-07-23 Eli Zaretskii <eliz@gnu.org>
2443
be18c5a5
EZ
2444 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2445 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2446
c1734fbd
EZ
2447 * xdisp.c (move_it_in_display_line_to): Record the best matching
2448 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2449 exit if none of the characters scanned was an exact match.
2450 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2451 when exact match is impossible due to invisible text, and the
2452 lines are truncated.
2453
a258d627
JD
24542011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2455
2456 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2457 for OSX >= 10.7.
2458
b6d5a689
EZ
24592011-07-22 Eli Zaretskii <eliz@gnu.org>
2460
0f74f785
EZ
2461 Fix a significant slow-down of cursor motion with C-n, C-p,
2462 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2463 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2464 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2465 (next_element_from_buffer): Call compute_stop_pos_backwards to
2466 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2467 base_level_stop.
2468 (reseat): Don't look for prev_stop, as that could mean a very long
2469 run.
2470 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2471 <cached_disp_overlay_modiff>: Cache for last found display string
2472 position.
551918c1 2473 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2474 about the same buffer in the same area of character positions, and
2475 the buffer wasn't changed since the time the display string
2476 position was cached.
551918c1 2477
b2d0c91a
EZ
24782011-07-22 Eli Zaretskii <eliz@gnu.org>
2479
2480 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2481 is an integer, which is important for empty lines. (Bug#9149)
2482
043604ee
CY
24832011-07-22 Chong Yidong <cyd@stupidchicken.com>
2484
2485 * frame.c (Fmodify_frame_parameters): In tty case, update the
2486 default face if necessary (Bug#4238).
2487
da4adb04
CY
24882011-07-21 Chong Yidong <cyd@stupidchicken.com>
2489
2490 * editfns.c (Fstring_to_char): No need to explain what a character
2491 is in the docstring (Bug#6576).
2492
9abd0532
LMI
24932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2494
2495 * xml.c (parse_region): Make sure we always return a tree.
2496
36881d16
HK
24972011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2498
2499 * xml.c (parse_region): If a document contains only comments,
2500 return that, too.
2501
1e98674d
LMI
25022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2503
2504 * xml.c (make_dom): Return comments, too.
2505
590bd467
PE
25062011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 Port to OpenBSD.
2509 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2510 and the surrounding thread.
2511 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2512 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2513 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2514 timer goes off.
2515 * s/openbsd.h (BROKEN_SIGIO): Define.
2516 * unexelf.c (unexec) [__OpenBSD__]:
2517 Don't update the .mdebug section of the Alpha COFF symbol table.
2518
f41628b2
LMI
25192011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2520
2521 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2522 (bug#8460).
2523
b59b67c5
PE
25242011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2525
15e3a074
PE
2526 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2527 This fixes some race conditions on the permissions of any newly
2528 created file.
2529
41bed37d
PE
2530 * alloc.c (valid_pointer_p): Use pipe, not open.
2531 This fixes some permissions issues when debugging.
2532
b59b67c5
PE
2533 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2534 If fchown fails to set both uid and gid, try to set just gid,
2535 as that is sometimes allowed. Adjust the file's mode to eliminate
2536 setuid or setgid bits that are inappropriate if fchown fails.
2537
925a6be7
SM
25382011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2539
2540 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2541 to compare Lisp_Objects.
2542 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2543 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2544 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2545
52968808
AS
25462011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2547
0a6a104b
AS
2548 * lread.c (read_integer): Unread even EOF character.
2549 (read1): Likewise. Properly record start position of symbol.
2550
52968808
AS
2551 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2552 symbol character follows.
2553
9e381cdd
PE
25542011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2555
2556 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2557 This works around a problem with the previous change to Fcopy_file.
2558 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2559 and without this change, GCC might complain about discarding
2560 fchown's return value.
2561
b5641435
JB
25622011-07-16 Juanma Barranquero <lekktu@gmail.com>
2563
2564 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2565
a8031457
PE
25662011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2569
dd889327
LMI
25702011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2571
750c33f7
LMI
2572 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2573 it's used from the C level.
2574
dd889327
LMI
2575 * process.c: Use the same condition for POLL_FOR_INPUT in both
2576 keyboard.c and process.c (bug#1858).
2577
87e86684
LM
25782011-07-09 Lawrence Mitchell <wence@gmx.li>
2579
2580 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2581 (Fgnutls_boot): Use it.
2582
64348f40
AS
25832011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2584
2585 * doc.c (Fsubstitute_command_keys): Revert last change.
2586
1d698799
LMI
25872011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2588
f863868c
LMI
2589 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2590 quotes the next character, and doesn't affect other longer
2591 sequences (bug#8935).
2592
1d698799
LMI
2593 * lread.c (syms_of_lread): Clarify that is isn't only
2594 `eval-buffer' and `eval-defun' that's affected by
2595 `lexical-binding' (bug#8460).
2596
aa4b6df6
EZ
25972011-07-15 Eli Zaretskii <eliz@gnu.org>
2598
2599 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2600 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2601
5d856da6
PE
26022011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2603
ad6042bb
PE
2604 Fix minor problems found by static checking.
2605 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2606 (elsz): Now a signed constant, not a size_t var. We prefer signed
2607 types to unsigned, to avoid integer comparison confusion. Without
2608 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2609 "cannot optimize loop, the loop counter may overflow", a symptom
2610 of the confusion.
f00bbb22 2611 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2612 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2613
6468f31c
LMI
26142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2615
49080b10
LMI
2616 * search.c (Fre_search_backward): Mention `case-fold-search' in
2617 all the re_search_* functions (bug#8138).
2618
6468f31c
LMI
2619 * keyboard.c (Fopen_dribble_file): Document when the file is
2620 closed (bug#8056).
2621
c965adc5
EZ
26222011-07-14 Eli Zaretskii <eliz@gnu.org>
2623
df9733bf
EZ
2624 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2625 bidi_cache_idx.
2626
0bb23927
EZ
2627 Support bidi reordering of display and overlay strings.
2628 * xdisp.c (compute_display_string_pos)
2629 (compute_display_string_end): Accept additional argument STRING.
2630 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2631 (reseat_to_string): Initialize bidi_it->string.s and
2632 bidi_it->string.schars.
2633 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2634 NULL (avoids a crash in bidi_paragraph_init).
2635 Initialize itb.string.lstring.
0bb23927
EZ
2636 (init_iterator): Call bidi_init_it only of a valid
2637 buffer position was specified. Initialize paragraph_embedding to
2638 L2R.
2639 (reseat_to_string): Initialize the bidi iterator.
2640 (display_string): If we need to ignore text properties of
2641 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2642 original value of -1 will not work with bidi.)
2643 (compute_display_string_pos): First arg is now struct
2644 `text_pos *'; all callers changed. Support display properties on
2645 Lisp strings.
2646 (compute_display_string_end): Support display properties on Lisp
2647 strings.
2648 (init_iterator, reseat_1, reseat_to_string): Initialize the
2649 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2650 when iterating on a string not from display properties).
640c8776
SM
2651 (compute_display_string_pos, compute_display_string_end):
2652 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2653 arrow keys.
2654 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2655 base_level_stop; instead, set base_level_stop to BEGV.
2656 Fixes crashes in vertical-motion.
0bb23927
EZ
2657 (next_element_from_buffer): Improve commentary for when
2658 the iterator is before prev_stop.
2659 (init_iterator): Initialize bidi_p from the default value of
2660 bidi-display-reordering, not from buffer-local value. Use the
2661 buffer-local value only if initializing for buffer iteration.
2662 (handle_invisible_prop): Support invisible properties on strings
2663 that are being bidi-reordered.
2664 (set_iterator_to_next): Support bidi reordering of C strings and
2665 Lisp strings.
2666 (next_element_from_string): Support bidi reordering of Lisp
2667 strings.
2668 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2669 (display_string): Support display of R2L glyph rows.
2670 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2671 (init_iterator): Don't initialize it->bidi_p for strings
2672 here.
2673 (reseat_to_string): Initialize it->bidi_p for strings here.
2674 (next_element_from_string, next_element_from_c_string)
2675 (next_element_from_buffer): Add xassert's for correspondence
2676 between IT's object being iterated and it->bidi_it.string
2677 structure.
2678 (face_before_or_after_it_pos): Support bidi iteration.
2679 (next_element_from_c_string): Handle the case of the first string
2680 character that is not the first one in the visual order.
2681 (get_visually_first_element): New function, refactored from common
2682 parts of next_element_from_buffer, next_element_from_string, and
2683 next_element_from_c_string.
2684 (tool_bar_lines_needed, redisplay_tool_bar)
2685 (display_menu_bar): Force left-to-right direction. Add a FIXME
2686 comment for making that be controlled by a user option.
2687 (push_it, pop_it): Save and restore the state of the
2688 bidi iterator. Save and restore the bidi_p flag.
2689 (pop_it): Iterate out of display property for string iteration as
2690 well.
2691 (iterate_out_of_display_property): Support iteration over strings.
2692 (handle_single_display_spec): Set up it->bidi_it for iteration
2693 over a display string, and call bidi_init_it.
2694 (handle_single_display_spec, next_overlay_string)
2695 (get_overlay_strings_1, push_display_prop): Set up the bidi
2696 iterator for displaying display or overlay strings.
2697 (forward_to_next_line_start): Don't use the shortcut if
2698 bidi-iterating.
2699 (back_to_previous_visible_line_start): If handle_display_prop
2700 pushed the iterator stack, restore the internal state of the bidi
2701 iterator by calling bidi_pop_it same number of times.
2702 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2703 and we are bidi-iterating, don't decrement the iterator position;
2704 instead, set the first_elt flag in the bidi iterator, to produce
2705 the same effect.
2706 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2707 (push_display_prop): xassert that we are iterating a buffer.
2708 (push_it, pop_it): Save and restore paragraph_embedding member.
2709 (handle_single_display_spec, next_overlay_string)
2710 (get_overlay_strings_1, reseat_1, reseat_to_string)
2711 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2712 correctly. Don't assume unibyte strings are not bidi-reordered.
2713 (compute_display_string_pos)
2714 (compute_display_string_end): Fix handling the case of C string.
2715 (push_it, pop_it): Save and restore from_disp_prop_p.
2716 (handle_single_display_spec, push_display_prop): Set the
2717 from_disp_prop_p flag.
2718 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2719 (pop_it): Call iterate_out_of_display_property only if we are
2720 popping after iteration over a string that came from a display
2721 property. Fix a typo in popping stretch info. Add an assertion
2722 for verifying that the iterator position is in sync with the bidi
2723 iterator.
2724 (handle_single_display_spec, get_overlay_strings_1)
2725 (push_display_prop): Fix initialization of paragraph direction for
2726 string when that of the parent object is not yet determined.
2727 (reseat_1): Call bidi_init_it to resync the bidi
2728 iterator with IT's position. (Bug#7616)
2729 (find_row_edges): If ROW->start.pos gives position
2730 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2731 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2732 Reset the from_disp_prop_p flag.
2733 (SAVE_IT, RESTORE_IT): New macros.
2734 (pos_visible_p, face_before_or_after_it_pos)
2735 (back_to_previous_visible_line_start)
2736 (move_it_in_display_line_to, move_it_in_display_line)
2737 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2738 (try_scrolling, redisplay_window, display_line): Use them when
2739 saving a temporary copy of the iterator and restoring it back.
2740 (back_to_previous_visible_line_start, reseat_1)
2741 (init_iterator): Empty the bidi cache "stack".
2742 (move_it_in_display_line_to): If iterator ended up at
2743 EOL, but we never saw any buffer positions smaller than
2744 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2745 motion in bidi-reordered lines.
2746 (move_it_in_display_line_to): Record prev_method and prev_pos
2747 immediately before the call to set_iterator_to_next. Fixes cursor
2748 motion in bidi-reordered lines with stretch glyphs and strings
2749 displayed in margins. (Bug#8133) (Bug#8867)
2750 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2751 TO_CHARPOS.
640c8776
SM
2752 (pos_visible_p): Support positions in bidi-reordered lines.
2753 Save and restore bidi cache.
0bb23927
EZ
2754
2755 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2756 (bidi_paragraph_info): Delete unused struct.
2757 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2758 (bidi_cache_start): New variable.
2759 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2760 to zero.
2761 (bidi_cache_fetch_state, bidi_cache_search)
2762 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2763 (bidi_cache_find, bidi_peek_at_next_level)
2764 (bidi_level_of_next_char, bidi_find_other_level_edge)
2765 (bidi_move_to_visually_next): Compare cache index with
2766 bidi_cache_start rather than with zero.
2767 (bidi_fetch_char): Accept new argument STRING; all callers
2768 changed. Support iteration over a string. Support strings with
2769 display properties. Support unibyte strings. Fix the type of
2770 `len' according to what STRING_CHAR_AND_LENGTH expects.
2771 (bidi_paragraph_init, bidi_resolve_explicit_1)
2772 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2773 (bidi_level_of_next_char, bidi_move_to_visually_next):
2774 Support iteration over a string.
0bb23927
EZ
2775 (bidi_set_sor_type, bidi_resolve_explicit_1)
2776 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2777 can now be zero (for strings); special values 0 and -1 were
2778 changed to -1 and -2, respectively.
2779 (bidi_char_at_pos): New function.
2780 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2781 Call it instead of FETCH_MULTIBYTE_CHAR.
2782 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2783 initialized to valid values.
2784 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2785 values.
2786 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2787 the test for valid cached positions. Fix the logic for looking up
2788 the sentinel state in the cache. GCPRO the Lisp string we are
2789 iterating.
2790 (bidi_push_it, bidi_pop_it): New functions.
2791 (bidi_initialize): Initialize the bidi cache start stack pointer.
2792 (bidi_cache_ensure_space): New function, refactored from part of
2793 bidi_cache_iterator_state. Don't assume the required size is just
2794 one BIDI_CACHE_CHUNK away.
2795 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2796 (bidi_count_bytes, bidi_char_at_pos): New functions.
2797 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2798 always valid if bidi_cache_idx is valid.
2799 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2800 is valid if it's going to be used.
2801 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2802 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2803 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2804 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2805 (bidi_find_other_level_edge, bidi_cache_start_stack):
2806 All variables related to cache indices are now EMACS_INT.
c965adc5 2807
0bb23927
EZ
2808 * dispextern.h (struct bidi_string_data): New structure.
2809 (struct bidi_it): New member `string'. Make flag members be 1-bit
2810 fields, and put them last in the struct.
640c8776
SM
2811 (compute_display_string_pos, compute_display_string_end):
2812 Update prototypes.
0bb23927
EZ
2813 (bidi_push_it, bidi_pop_it): Add prototypes.
2814 (struct iterator_stack_entry): New members bidi_p,
2815 paragraph_embedding, and from_disp_prop_p.
2816 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2817 (bidi_shelve_cache, bidi_unshelve_cache):
2818 Declare prototypes.
0bb23927
EZ
2819
2820 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2821 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2822 and vector-like objects.
2823
2824 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2825 cache around display iteration.
2826
2827 * window.c (Fwindow_end, window_scroll_pixel_based)
2828 (displayed_window_lines, Frecenter): Save and restore the bidi
2829 cache around display iteration.
2830
3bbd2265
LMI
28312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2832
2833 * editfns.c (Fdelete_region): Clarify the use of the named
2834 parameters (bug#6788).
2835
adc47434
MR
28362011-07-14 Martin Rudalics <rudalics@gmx.at>
2837
2838 * indent.c (Fvertical_motion): Set and restore w->pointm when
2839 saving and restoring the window's buffer (Bug#9006).
2840
837c31f8
LMI
28412011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2842
2843 * editfns.c (Fstring_to_char): Clarify just what is returned
2844 (bug#6576). Text by Eli Zaretskii.
2845
ac389d0c
JB
28462011-07-13 Juanma Barranquero <lekktu@gmail.com>
2847
2848 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2849
0be0ce47
EZ
28502011-07-13 Eli Zaretskii <eliz@gnu.org>
2851
2852 * buffer.c (mmap_find): Fix a typo.
2853
cd18e7e3
JB
28542011-07-13 Johan Bockgård <bojohan@gnu.org>
2855
2856 Fix execution of x selection hooks.
2857 * xselect.c (Qx_lost_selection_functions)
2858 (Qx_sent_selection_functions): New vars.
2859 (syms_of_xselect): DEFSYM them.
2860 (x_handle_selection_request): Pass Qx_sent_selection_functions
2861 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2862 (x_handle_selection_clear,x_clear_frame_selections):
2863 Pass Qx_lost_selection_functions rather than
2864 Vx_lost_selection_functions to Frun_hook_with_args.
2865
47ea7f44
PE
28662011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2867
ac389d0c 2868 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2869 The old code sometimes used this field without initializing it.
2870
47ea7f44
PE
2871 * alloc.c (gc_sweep): Don't read past end of array.
2872 In theory, the old code could also have corrupted Emacs internals,
2873 though it'd be very unlikely.
2874
bc985c87
AS
28752011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2876
2877 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2878 argument. (Bug#4026)
bc985c87 2879
0cf34688
LMI
28802011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2881
b3dadd76
LMI
2882 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2883 key" (bug#4257).
2884
0cf34688
LMI
2885 * window.c (Fset_window_start): Doc fix (bug#4199).
2886 (Fset_window_hscroll): Ditto.
2887
270768cd
PE
28882011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2889
077e3dda 2890 Fix minor new problems caught by GCC 4.6.1.
270768cd 2891 * term.c (init_tty): Remove unused local.
490011a6 2892 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2893 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2894 not used otherwise.
270768cd 2895
b1f58454
CY
28962011-07-12 Chong Yidong <cyd@stupidchicken.com>
2897
2898 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2899
22b9578d
LMI
29002011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2901
6e70ab07
LMI
2902 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2903 are the mini-buffer and the echo area (bug#3320).
2904
22b9578d
LMI
2905 * term.c (init_tty): Remove support for supdup, c10 and perq
2906 terminals, which are no longer supported (bug#1482).
2907
8974cc9f
JB
29082011-07-10 Johan Bockgård <bojohan@gnu.org>
2909
2910 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2911
a560d974
JD
29122011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2913
2914 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2915 for non-popups (Bug#3642).
2916
1dae0f0a
AS
29172011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2918
268c2c36 2919 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2920 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2921 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2922 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2923 * data.c (fmod): Likewise.
2924 * dispnew.c (swap_glyphs_in_rows): Likewise.
2925 * emacs.c (memory_warning_signal): Likewise.
2926 * floatfns.c (float_error): Likewise.
2927 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2928 (otf_open, font_otf_capability, generate_otf_features)
2929 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2930 Likewise.
2931 * image.c (pbm_read_file): Likewise.
2932 * indent.c (string_display_width): Likewise.
2933 * intervals.c (check_for_interval, search_for_interval)
2934 (inc_interval_count, count_intervals, root_interval)
2935 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2936 * lread.c (defalias): Likewise.
268c2c36 2937 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2938 * regex.c (set_image_of_range_1, set_image_of_range)
2939 (regex_grow_registers): Likewise.
2940 * sysdep.c (strerror): Likewise.
2941 * termcap.c (valid_filename_p, tprint, main): Likewise.
2942 * tparam.c (main): Likewise.
2943 * unexhp9k800.c (run_time_remap, save_data_space)
2944 (update_file_ptrs, read_header, write_header, calculate_checksum)
2945 (copy_file, copy_rest, display_header): Likewise.
2946 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2947 Likewise.
2948 * xdisp.c (check_it): Likewise.
2949 * xfaces.c (register_color, unregister_color, unregister_colors):
2950 Likewise.
2951 * xfns.c (print_fontset_result): Likewise.
2952 * xrdb.c (member, fatal, main): Likewise.
2953
99033785
PE
29542011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2955
2956 Fix minor problems found by static checking (Bug#9031).
2957 * chartab.c (char_table_set_range, map_sub_char_table):
2958 Remove unused locals.
2959 (uniprop_table): Now static.
2960 * composite.c (_work_char): Remove unused static var.
2961
9cb2ac56
JB
29622011-07-09 Juanma Barranquero <lekktu@gmail.com>
2963
2964 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2965
f25661f0
JD
29662011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2967
2968 * gtkutil.c (qttip_cb): Remove code without function.
2969
8278c4fe
EZ
29702011-07-09 Eli Zaretskii <eliz@gnu.org>
2971
2972 * w32.c (pthread_sigmask): New stub.
2973
1692ae2d 29742011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2975
8a6ebd58 2976 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2977 sigprocmask is portable only for single-threaded applications, and
2978 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2979 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2980 (LIBES): Use it.
2981 * callproc.c (Fcall_process):
2982 * process.c (create_process):
2983 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2984 Use pthread_sigmask, not sigprocmask.
123403e4 2985
1b854618
JD
29862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2987
2988 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2989 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2990 wrong (Bug#8591).
2991
3fe4b549
JD
29922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2993
0ce7e563
JD
2994 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2995 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2996 (xg_hide_tooltip): Fix comment.
2997
3fe4b549
JD
2998 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2999 in registerServicesMenuSendTypes.
3000 (validRequestorForSendType): Don't check ns_return_types.
3001
3002 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3003 ns_return_type.
3004
5df75e47
JR
30052011-07-08 Jason Rumney <jasonr@gnu.org>
3006
22610910
JR
3007 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3008 SH_SHOW for hidden windows (Bug#5482).
3009
5df75e47
JR
3010 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3011 frame struct members of non-existent frames (Bug#6284).
3012
699c10bd
JD
30132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3014
4393663b
JD
3015 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3016 variable firstTime not needed on OSX >= 10.6.
3017 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3018 >= 10.5. Use setKnobProportion, setDoubleValue.
3019
3020 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3021 (MAC_OS_X_VERSION_10_5): Define if not defined.
3022 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3023 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3024 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3025
3026 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3027 cString and lossyCString on OSX >= 10.4
3028
3029 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3030 sizeToFit on OSX >= 10.2.
3031
3032 * nsimage.m (allocInitFromFile): Don't use deprecated method
3033 bestRepresentationForDevice on OSX >= 10.6.
3034
3035 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3036 to avoid warning.
3037
3038 * emacs.c: Declare unexec_init_emacs_zone.
3039
a63e0781
JD
3040 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3041
699c10bd
JD
3042 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3043
3044 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3045 on svcsMenu (Bug#8842).
3046
3047 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3048 ns_return_types.
3049 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3050
3051 * nsterm.m (QUTF8_STRING): Declare.
3052 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3053 (validRequestorForSendType): Return type is (id).
3054 Change indexOfObjectIdenticalTo to indexOfObject.
3055 Check if we have local selection before returning self (Bug#8842).
3056 (writeSelectionToPasteboard): Put local selection into paste board
3057 if we have a local selection (Bug#8842).
3058 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3059
3060 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3061 (ns_get_local_selection): Declare.
3062
54e10184
LMI
30632011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3064
9888ff71
LMI
3065 * keymap.c (describe_map_tree): Don't insert a double newline at
3066 the end of the buffer (bug#1169) and return whether we inserted
3067 something.
3068
54e10184
LMI
3069 * callint.c (Fcall_interactively): Change "reading args" to
3070 "providing args" to try to clarify what it does (bug#1010).
3071
15fa4783
KH
30722011-07-07 Kenichi Handa <handa@m17n.org>
3073
3074 * composite.c (composition_compute_stop_pos): Ignore a static
3075 composition starting before CHARPOS (Bug#8915).
3076
3077 * xdisp.c (handle_composition_prop): Likewise.
3078
a8815b00
EZ
30792011-07-07 Eli Zaretskii <eliz@gnu.org>
3080
3081 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3082 (Bug#9015)
3083
ef7b981d 30842011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3085
3086 * character.h (unicode_category_t): New enum type.
3087
3088 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3089 (Qchar_code_property_table): New variable.
3090 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3091 (UNIPROP_COMPRESSED_FORM_P): New macros.
3092 (char_table_ascii): Uncompress the compressed values.
3093 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3094 Uncompress the compressed values.
ac389d0c 3095 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3096 (char_table_ref_and_range): Uncompress the compressed values.
3097 (sub_char_table_set): New arg is_uniprop. Callers changed.
3098 Uncompress the compressed values.
3099 (sub_char_table_set_range): Args changed. Callers changed.
3100 (char_table_set_range): Adjuted for the above change.
3101 (map_sub_char_table): Delete args default_val and parent. Add arg
3102 top. Give decoded values to a Lisp function.
640c8776 3103 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3104 values to a Lisp function. Gcpro more variables.
3105 (uniprop_table_uncompress)
3106 (uniprop_decode_value_run_length): New functions.
3107 (uniprop_decoder, uniprop_decoder_count): New variables.
3108 (uniprop_get_decoder, uniprop_encode_value_character)
3109 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3110 New functions.
3111 (uniprop_encoder, uniprop_encoder_count): New variables.
3112 (uniprop_get_encoder, uniprop_table)
3113 (Funicode_property_table_internal, Fget_unicode_property_internal)
3114 (Fput_unicode_property_internal): New functions.
3115 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3116 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3117 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3118 char-code-property-alist.
3119
640c8776 3120 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3121 Vunicode_category_table.
3122
640c8776 3123 * font.c (font_range): Adjust for the change of
c805dec0
KH
3124 Vunicode_category_table.
3125
76b397fb
DN
31262011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3127
3128 * m/iris4d.h: Remove file, move contents ...
3129 * s/irix6-5.h: ... here.
3130
22b4128e
PE
31312011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3134 * alloc.c (mark_buffer):
3135 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3136 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3137 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3138 This isn't true in general, and it's particularly not true
3139 if Emacs is configured with --with-wide-int.
3140 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3141 New macros, used in the buffer.c change.
3142
869795d6
JD
31432011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3144
3145 * xsettings.c: Use both GConf and GSettings if both are available.
3146 (store_config_changed_event): Add comment.
3147 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3148 (store_tool_bar_style_changed): New functions.
5e617bc2 3149 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3150 (struct xsettings): Move font inside HAVE_XFT.
3151 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3152 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3153 Move inside HAVE_XFT.
640c8776 3154 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3155 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3156 also.
3157 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3158 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3159 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3160 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3161 (parse_settings): Move check for font inside HAVE_XFT.
3162 (read_settings, apply_xft_settings): Add comment.
3163 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3164 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3165 call store_font_name_changed.
3166 (xft_settings_event): Add comment.
3167 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3168 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3169 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3170 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3171 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3172 (xsettings_get_system_font, xsettings_get_system_normal_font):
3173 Add comment.
869795d6 3174
d8ed26bd
PE
31752011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 Random fixes. E.g., (random) never returned negative values.
3178 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3179 subseconds part to the entropy, as that's a bit more random.
3180 Prefer signed to unsigned, since the signedness doesn't matter and
3181 in general we prefer signed. When given a limit, use a
3182 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3183 latter isn't right if USE_2_TAGS_FOR_INTS.
3184 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3185 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3186
cabf1cac
SM
31872011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3188
3189 * textprop.c (text_property_stickiness):
3190 Obey Vtext_property_default_nonsticky.
3191 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3192 * w32fns.c (syms_of_w32fns):
3193 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3194
6e9b2be9
PE
31952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3196
3197 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3198 This is more efficient than Ffile_directory_p and avoids a minor race.
3199
90186c68
LMI
32002011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3201
7c301272
LMI
3202 * buffer.c (Foverlay_put): Say what the return value is
3203 (bug#7835).
3204
c4f2d8d4
LMI
3205 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3206 is a directory before asking whether to use the file name
3207 (bug#7564).
ad637907
LMI
3208 (barf_or_query_if_file_exists): Make the "File is a directory"
3209 error be more correct.
c4f2d8d4 3210
90186c68
LMI
3211 * fns.c (Frequire): Remove the mention of the .gz files, since
3212 that's installation-specific, but keep the mention of
3213 `get-load-suffixes'.
3214
da64016e
PE
32152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3218 Report string overflow if the output is too long.
3219
7d47b580
JB
32202011-07-04 Juanma Barranquero <lekktu@gmail.com>
3221
a555cb87
JB
3222 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3223 (syms_of_gnutls): Remove duplicate DEFSYM for
3224 Qgnutls_bootprop_verify_hostname_error, an error for
3225 Qgnutls_bootprop_verify_error (which is no longer used).
3226
7d47b580
JB
3227 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3228 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3229 Also (re)move comments that are misplaced or no longer relevant.
3230
1e49bfab
LMI
32312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3232
3233 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3234
1485f4c0
CY
32352011-07-03 Chong Yidong <cyd@stupidchicken.com>
3236
3237 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3238 and background color parameters if they have been changed.
3239
a9ab721e
LMI
32402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3241
3242 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3243
cf7cff57
PE
32442011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3245
2e13213d
PE
3246 * xsettings.c (SYSTEM_FONT): Define only when used.
3247 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3248
cf7cff57
PE
3249 * keymap.c (access_keymap_1): Now static.
3250
7a8e04f7
CY
32512011-07-02 Chong Yidong <cyd@stupidchicken.com>
3252
3253 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3254 leave any prefix arg for the up event (Bug#1586).
3255
61352f62
LMI
32562011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3257
69bb1ef7
LMI
3258 * lread.c (syms_of_lread): Mention single symbols defined by
3259 `defvar' or `defconst' (bug#7154).
3260
61352f62 3261 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3262 (Frequire): Mention get-load-suffixes.
61352f62 3263
28545e04
MR
32642011-07-02 Martin Rudalics <rudalics@gmx.at>
3265
3266 * window.h (window): Remove clone_number slot.
3267 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3268 Remove.
3269 (make_parent_window, make_window, saved_window)
3270 (Fset_window_configuration, save_window_save): Don't deal with
3271 clone numbers.
3272 * buffer.c (Qclone_number): Remove declaration.
3273 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3274
3349e122
SM
32752011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3276
3277 Add multiple inheritance to keymaps.
3278 * keymap.c (Fmake_composed_keymap): New function.
3279 (Fset_keymap_parent): Simplify.
3280 (fix_submap_inheritance): Remove.
3281 (access_keymap_1): New function extracted from access_keymap to handle
3282 embedded parents and handle lists of maps.
3283 (access_keymap): Use it.
3284 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3285 (Fcopy_keymap): Handle embedded parents.
3286 (Fcommand_remapping, define_as_prefix): Simplify.
3287 (Fkey_binding): Simplify.
3288 (syms_of_keymap): Move minibuffer-local-completion-map,
3289 minibuffer-local-filename-completion-map,
3290 minibuffer-local-must-match-map, and
3291 minibuffer-local-filename-must-match-map to Elisp.
3292 (syms_of_keymap): Defsubr make-composed-keymap.
3293 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3294 (parse_menu_item): Trivial simplification.
3295
3279eb87
GM
32962011-07-01 Glenn Morris <rgm@gnu.org>
3297
3298 * Makefile.in (SETTINGS_LIBS): Fix typo.
3299
4550efdf
KI
33002011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3301
3302 * coding.c (Fencode_coding_string): Record the last coding system
3303 used, as the function doc string says (bug#8738).
3304
0949d2b6
JD
33052011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3306
3307 * xsettings.c (store_monospaced_changed): Take new font as arg and
3308 check for change against current_mono_font.
3309 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3310 (emacs_settings_constructor, emacs_settings_get_property)
3311 (emacs_settings_set_property, emacs_settings_class_init)
3312 (emacs_settings_init, gsettings_obj): Remove.
3313 (something_changedCB): New function for HAVE_GSETTINGS.
3314 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3315 with value as argument.
3316 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3317 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3318 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3319 "changed".
3320
3321 * xgselect.c: Add defined (HAVE_GSETTINGS).
3322 (xgselect_initialize): Ditto.
3323
3324 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3325 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3326 xg_select.
3327
bbc6b304
PE
33282011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3329
3330 * eval.c (struct backtrace): Simplify and port the data structure.
3331 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3332 signed bit field, as this assumption is not portable and it makes
3333 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3334 "char debug_on_exit : 1" as this is not portable either; instead,
3335 use the portable "unsigned int debug_on_exit : 1". Remove unused
3336 member evalargs. Remove obsolete comments about cc bombing out.
3337
9851bfc5
JD
33382011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3339
51bb811f 3340 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3341 Let HAVE_GSETTINGS override HAVE_GCONF.
3342 (store_monospaced_changed): New function.
3343 (EMACS_SETTINGS): A new type derived from GObject to handle
3344 GSettings notifications.
3345 (emacs_settings_constructor, emacs_settings_get_property)
3346 (emacs_settings_set_property, emacs_settings_class_init):
3347 New functions.
3348 (gsettings_client, gsettings_obj): New variables.
3349 (GSETTINGS_SCHEMA): New define.
3350 (something_changedCB): Call store_monospaced_changed.
3351 (init_gsettings): New function.
3352 (xsettings_initialize): Call init_gsettings.
3353 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3354 to NULL.
3355
640c8776 3356 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3357 GCONF_CFLAGS/LIBS.
3358
5386012d
MR
33592011-06-29 Martin Rudalics <rudalics@gmx.at>
3360
3361 * window.c (resize_root_window, grow_mini_window)
3362 (shrink_mini_window): Rename Qresize_root_window to
3363 Qwindow_resize_root_window and Qresize_root_window_vertically to
3364 Qwindow_resize_root_window_vertically.
3365
f13e0b08
PE
33662011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3367
3368 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3369
94515237
JB
33702011-06-27 Juanma Barranquero <lekktu@gmail.com>
3371
3372 * makefile.w32-in: Redesign dependencies so they reflect more
3373 clearly which files are directly included by each source file,
3374 and not through other includes.
3375
e43b6e43
MR
33762011-06-27 Martin Rudalics <rudalics@gmx.at>
3377
3378 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3379 (sort_overlays, overlay_strings): When an overlay's clone number
3380 matches the window's clone number process the overlay even if
3381 the overlay's window property doesn't match the current window.
3382
d68443dc
MR
3383 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3384 (Fwindow_hchild): Rename to Fwindow_left_child.
3385 (Fwindow_next): Rename to Fwindow_next_sibling.
3386 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3387 (resize_window_check): Rename to window_resize_check.
3388 (resize_window_apply): Rename to window_resize_apply.
3389 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3390 (Fdelete_other_windows_internal, resize_frame_windows)
3391 (Fsplit_window_internal, Fdelete_window_internal)
3392 (grow_mini_window, shrink_mini_window)
3393 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3394
c7e73be5
JD
33952011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3396
3397 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3398 (emacs_fixed_set_min_size): Remove.
3399 (emacs_fixed_new): Take frame as argument.
3400
3401 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3402 (_EmacsFixedPrivate): Remove minwidth/height.
3403 Add struct frame *f.
3404 (emacs_fixed_init): Initialize priv->f.
3405 (get_parent_class, emacs_fixed_set_min_size): Remove.
3406 (emacs_fixed_new): Set priv->f to argument.
3407 (emacs_fixed_get_preferred_width)
3408 (emacs_fixed_get_preferred_height): Use min_width/height from
3409 frames size_hint to set minimum and natural (Bug#8919).
3410 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3411 and use min_width/height from frames size_hint to set
3412 min_width/height (Bug#8919).
3413
3414 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3415 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3416 Fix indentation.
c7e73be5 3417
cf99dcf8
EZ
34182011-06-26 Eli Zaretskii <eliz@gnu.org>
3419
3420 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3421 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3422 called at ZV.
3423
029529ac
CY
34242011-06-26 Chong Yidong <cyd@stupidchicken.com>
3425
3426 * process.c (wait_reading_process_output): Bypass select if
3427 waiting for a cell while ignoring keyboard input, and input is
3428 pending. Suggested by Jan Djärv (Bug#8869).
3429
7a7ef429
PE
34302011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3431
3432 Use gnulib's dup2 module instead of rolling our own.
3433 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3434
11fdef7d 34352011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3436
3437 * dispnew.c (scrolling_window): Before scrolling, turn off a
3438 mouse-highlight in the window being scrolled.
3439
cd3520a4
JB
34402011-06-24 Juanma Barranquero <lekktu@gmail.com>
3441
3442 Move DEFSYM to lisp.h and use everywhere.
3443
3444 * character.h (DEFSYM): Move declaration...
3445 * lisp.h (DEFSYM): ...here.
3446
3447 * gnutls.c:
3448 * minibuf.c:
3449 * w32menu.c:
3450 * w32proc.c:
3451 * w32select.c: Don't include character.h.
3452
3453 * alloc.c (syms_of_alloc):
3454 * buffer.c (syms_of_buffer):
3455 * bytecode.c (syms_of_bytecode):
3456 * callint.c (syms_of_callint):
3457 * casefiddle.c (syms_of_casefiddle):
3458 * casetab.c (init_casetab_once):
3459 * category.c (init_category_once, syms_of_category):
3460 * ccl.c (syms_of_ccl):
3461 * cmds.c (syms_of_cmds):
3462 * composite.c (syms_of_composite):
3463 * dbusbind.c (syms_of_dbusbind):
3464 * dired.c (syms_of_dired):
3465 * dispnew.c (syms_of_display):
3466 * doc.c (syms_of_doc):
3467 * editfns.c (syms_of_editfns):
3468 * emacs.c (syms_of_emacs):
3469 * eval.c (syms_of_eval):
3470 * fileio.c (syms_of_fileio):
3471 * fns.c (syms_of_fns):
3472 * frame.c (syms_of_frame):
3473 * fringe.c (syms_of_fringe):
3474 * insdel.c (syms_of_insdel):
3475 * keymap.c (syms_of_keymap):
3476 * lread.c (init_obarray, syms_of_lread):
3477 * macros.c (syms_of_macros):
3478 * msdos.c (syms_of_msdos):
3479 * print.c (syms_of_print):
3480 * process.c (syms_of_process):
3481 * search.c (syms_of_search):
3482 * sound.c (syms_of_sound):
3483 * syntax.c (init_syntax_once, syms_of_syntax):
3484 * terminal.c (syms_of_terminal):
3485 * textprop.c (syms_of_textprop):
3486 * undo.c (syms_of_undo):
3487 * w32.c (globals_of_w32):
3488 * window.c (syms_of_window):
3489 * xdisp.c (syms_of_xdisp):
3490 * xfaces.c (syms_of_xfaces):
3491 * xfns.c (syms_of_xfns):
3492 * xmenu.c (syms_of_xmenu):
3493 * xsettings.c (syms_of_xsettings):
3494 * xterm.c (syms_of_xterm): Use DEFSYM.
3495
4228cf16
TZ
34962011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3497
cd3520a4 3498 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3499
7fcccf1e
PE
35002011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3501
7efb4e0e
PE
3502 Integer and buffer overflow fixes (Bug#8873).
3503
ff5844ad
PE
3504 * print.c (printchar, strout): Check for string overflow.
3505 (PRINTPREPARE, printchar, strout):
3506 Don't set size unless allocation succeeds.
3507
90532f02
PE
3508 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3509 for sizes. Check for string overflow more accurately.
3510 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3511
6d84508d
PE
3512 * macros.c: Integer and buffer overflow fixes.
3513 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3514 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3515 Use ptrdiff_t, not int, for sizes.
3516 Don't increment bufsize until after realloc succeeds.
3517 Check for size-calculation overflow.
3518 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3519
437b2cb4
PE
3520 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3521
8b9ac8b4
PE
3522 * lread.c: Integer overflow fixes.
3523 (read_integer): Radix is now EMACS_INT, not int,
3524 to improve quality of diagnostics for out-of-range radices.
3525 Calculate buffer size correctly for out-of-range radices.
3526 (read1): Check for integer overflow in radices, and in
3527 read-circle numbers.
82cb60d3
PE
3528 (read_escape): Avoid int overflow.
3529 (Fload, openp, read_buffer_size, read1)
3530 (substitute_object_recurse, read_vector, read_list, map_obarray):
3531 Use ptrdiff_t, not int, for sizes.
3532 (read1): Use EMACS_INT, not int, for sizes.
20270765 3533 Check for size overflow.
8b9ac8b4 3534
7fcccf1e
PE
3535 * image.c (cache_image): Check for size arithmetic overflow.
3536
bfbbd7e7
PE
3537 * lread.c: Integer overflow issues.
3538 (saved_doc_string_size, saved_doc_string_length)
3539 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3540 Now ptrdiff_t, not int.
3541 (read1): Don't assume doc string length fits in int. Check for
3542 out-of-range doc string lengths.
3543 (read_list): Don't assume file position fits in int.
39019e54 3544 (read_escape): Check for hex character overflow.
bfbbd7e7 3545
4e323265
LL
35462011-06-22 Leo Liu <sdl.web@gmail.com>
3547
3548 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3549 Move to minibuffer.el.
3550
85fece3e
PE
35512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3552
20b84ce9 3553 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3554 The following patches are for when GLYPH_DEBUG && !XASSERT.
3555 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3556 * dispnew.c (flush_stdout):
3557 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3558 Mark as externally visible.
3559 * dispnew.c (check_window_matrix_pointers): Now static.
3560 * dispnew.c (window_to_frame_vpos):
3561 * xfns.c (unwind_create_frame):
3562 * xterm.c (x_check_font): Remove unused local.
3563 * scroll.c (CHECK_BOUNDS):
3564 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3565 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3566 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3567 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3568 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3569 Now static.
3570 (debug_method_add): Use va_list and vsprintf rather than relying
3571 on undefined behavior with wrong number of arguments.
3572 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3573 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3574 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3575 since we're not interested in debugging glyphs with old libraries.
3576 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3577 GCC 4.6.0's static checking.
3578
0766b489
PE
35792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3580
31fd4b32
PE
3581 Integer overflow and signedness fixes (Bug#8873).
3582 A few related buffer overrun fixes, too.
3583
b79e8648
PE
3584 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3585
0766b489
PE
3586 * dispextern.h (struct face.stipple):
3587 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3588 (x_bitmap_mask, x_allocate_bitmap_record)
3589 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3590 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3591 (x_create_bitmap_from_xpm_data):
3592 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3593 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3594 (.bitmaps_last):
3595 * xfaces.c (load_pixmap):
3596 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3597 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3598 (.bitmaps_last, struct x_output.icon_bitmap):
3599 Use ptrdiff_t, not int, for bitmap indexes.
3600 (x_allocate_bitmap_record): Check for size overflow.
3601 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3602
b081724f
PE
3603 Use ptrdiff_t, not int, for overlay counts.
3604 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3605 * editfns.c (overlays_around, get_pos_property):
3606 * textprop.c (get_char_property_and_overlay):
3607 * xdisp.c (next_overlay_change, note_mouse_highlight):
3608 * xfaces.c (face_at_buffer_position):
21514da7
PE
3609 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3610 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3611 (Fnext_overlay_change, Fprevious_overlay_change)
3612 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3613 Use ptrdiff_t, not int, for sizes.
21514da7 3614 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3615
3de73e5e
PE
3616 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3617
2606c57b
PE
3618 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3619 (x_session_initialize): Do not assume string length fits in int.
3620
aaafe47a
PE
3621 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3622 This is unlikely, but can occur if DPI is outlandish.
3623
2674ddc8 3624 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3625 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3626
28154962
PE
3627 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3628 * xrdb.c (magic_file_p, search_magic_path):
3629 Omit last arg SUFFIX; it was always 0. All callers changed.
3630 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3631
7de51af5
PE
3632 * xfont.c (xfont_match): Avoid need for strlen.
3633
25ed6cc3
PE
3634 * xfns.c: Don't assume strlen fits in int.
3635 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3636
4eab31dd
PE
3637 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3638 not unsigned long, as we prefer signed integers. All callers changed.
3639 Detect integer overflow in repeat count.
3640 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3641 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3642
171e2a58
PE
3643 * termcap.c: Don't assume sizes fit in int and never overflow.
3644 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3645 (gobble_line): Check for size-calculation overflow.
3646
ad39faca 3647 * minibuf.c (Fread_buffer):
6e5bb2dc 3648 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3649 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3650 Don't assume string length fits in int.
3651
52c61c22 3652 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3653 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3654
b5b8c9e5
PE
3655 * font.c: Don't assume string length fits in int.
3656 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3657 Use ptrdiff_t, not int.
ccd6111c
PE
3658 (font_intern_prop): Don't assume string length fits in int.
3659 Don't assume integer property fits in fixnum.
3660 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3661
882f0d81 3662 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3663 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3664 Reformulate so as not to need the command string.
3665 Invoke gzip -cd rather than gunzip, as it's more portable.
3666 (lock_info_type, lock_file_1, lock_file):
3667 Don't assume pid_t and time_t fit in unsigned long.
3668 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3669 (current_lock_owner): Prefer signed type for sizes.
3670 Use memcpy, not strncpy, where memcpy is what is really wanted.
3671 Don't assume (via atoi) that time_t and pid_t fit in int.
3672 Check for time_t and/or pid_t out of range, e.g., via a network share.
3673 Don't alloca where an auto var works fine.
3674
93f4cf88
PE
3675 * fileio.c: Fix some integer overflow issues.
3676 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3677 Don't assume string length fits in int.
3678 (directory_file_name): Don't assume string length fits in long.
3679 (make_temp_name): Don't assume pid fits in int, or that its print
3680 length is less than 20.
3681
f3e92b69
PE
3682 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3683
1bfdaf10
PE
3684 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3685
35016e9a
PE
3686 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3687
3d1e65a1
PE
3688 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3689 We prefer signed integers, even for size calculations.
3690
0b963a93
PE
3691 * emacs.c: Don't assume string length fits in 'int'.
3692 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3693 (main): Don't invoke strlen when not needed.
3694
573f4b54
PE
3695 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3696 (XD_DEBUG_MESSAGE): Don't waste a byte.
3697
989f33ba
PE
3698 * callproc.c (getenv_internal_1, getenv_internal)
3699 (Fgetenv_internal):
965d34eb
PE
3700 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3701
e4d29b33
PE
3702 * lread.c (invalid_syntax): Omit length argument.
3703 All uses changed. This doesn't fix a bug, but it simplifies the
3704 code away from its former Hollerith-constant appearance, and it's
3705 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3706 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3707
eb49b136
PE
3708 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3709 This didn't break anything, but it didn't help either.
3710 It's confusing to put a bogus integer in a place where the actual
3711 value does not matter.
9f62aeb1 3712 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3713 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3714
15375a22
PE
3715 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3716 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3717 implementation.
b61cc01c
PE
3718 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3719 We prefer signed types, and the value cannot exceed the EMACS_INT
3720 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3721 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3722 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3723 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3724
53b2623d
PE
3725 * indent.c (sane_tab_width): New function.
3726 (current_column, scan_for_column, Findent_to, position_indentation)
3727 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3728 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3729
51cab52b 3730 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3731
f2ed8a70
PE
3732 * lisp.h (lint_assume): New macro.
3733 * composite.c (composition_gstring_put_cache):
3734 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3735
abe80cc6
PE
3736 * editfns.c, insdel.c:
3737 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3738
b02c740e
PE
3739 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3740
ebc96716
PE
3741 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3742
b4e50fa0 3743 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3744 Use much-faster test for byte-length change.
311d5d7c 3745 Don't assume string byte-length fits in 'int'.
a4cf38e4 3746 Check that character arg fits in 'int'.
85461888 3747 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3748
c0c1ee9f
PE
3749 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3750
a498d7f4
PE
3751 * fns.c (concat): Catch string overflow earlier.
3752 Do not rely on integer wraparound.
3753
51cab52b
PE
3754 * dispextern.h (struct it.overlay_strings_charpos)
3755 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3756 * xdisp.c (forward_to_next_line_start)
3757 (back_to_previous_visible_line_start)
3758 (reseat_at_next_visible_line_start, next_element_from_buffer):
3759 Don't arbitrarily truncate the value of 'selective' to int.
3760
76031fad
PE
3761 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3762
5eb55db9
PE
3763 * composite.c: Don't truncate sizes to 'int'.
3764 (composition_gstring_p, composition_reseat_it)
3765 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3766 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3767 not EMACS_UINT, for indexes.
5eb55db9 3768
0703a717
PE
3769 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3770
d6202519
PE
3771 * buffer.c: Include <verify.h>.
3772 (struct sortvec.priority, struct sortstr.priority):
8961a454 3773 Now EMACS_INT, not int.
c20998a7 3774 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3775 (struct sortstr.size, record_overlay_string)
3776 (struct sortstrlist.size, struct sortlist.used):
3777 Don't truncate size to int.
3778 (record_overlay_string): Check for size-calculation overflow.
d6202519 3779 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3780
d5a19415
JM
37812011-06-22 Jim Meyering <meyering@redhat.com>
3782
029529ac 3783 Don't leak an XBM-image-sized buffer
d5a19415
JM
3784 * image.c (xbm_load): Free the image buffer after using it.
3785
a9041e6c
PE
37862011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3787
3788 Port to Sun C.
3789 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3790 that Sun C diagnosed.
3791 * fns.c (secure_hash): Fix pointer signedness issue.
3792 * intervals.c (static_offset_intervals): New function.
3793 (offset_intervals): Use it.
3794
7f3f739f
LL
37952011-06-21 Leo Liu <sdl.web@gmail.com>
3796
3797 * deps.mk (fns.o):
3798 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3799 sha512.h.
3800
3801 * fns.c (secure_hash): Rename from crypto_hash_function and change
3802 the first arg to accept symbols.
5b66d427 3803 (Fsecure_hash): New primitive.
7f3f739f
LL
3804 (syms_of_fns): New symbols.
3805
76147d94
DD
38062011-06-20 Deniz Dogan <deniz@dogan.se>
3807
3808 * process.c (Fset_process_buffer): Clarify return value in
3809 docstring.
3810
7d7d0045
CY
38112011-06-18 Chong Yidong <cyd@stupidchicken.com>
3812
3813 * dispnew.c (add_window_display_history): Use BVAR.
3814
3815 * xdisp.c (debug_method_add): Use BVAR.
3816 (check_window_end, dump_glyph_matrix, dump_glyph)
3817 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3818
3819 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3820 Likewise.
3821
3822 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3823 check till after the cache is created in init_frame_faces.
3824
ff2bc410
SM
38252011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3826
3827 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3828
28177add
PE
38292011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3830
dd3482fe
PE
3831 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3832 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3833 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3834
393d71f3 3835 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3836 * fileio.c (Finsert_file_contents):
3837 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3838 Remove the old (too-loose) buffer overflow checks.
3839 They weren't needed, since make_gap checks for buffer overflow.
3840 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3841 The old code merely checked for Emacs fixnum overflow, and relied
3842 on undefined (wraparound) behavior. The new code avoids undefined
3843 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3844
2e6813b0 3845 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3846 Tune. Don't use wider integers than needed. Don't use alloca.
3847 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3848
599a9e4f
PE
3849 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3850
99561444
PE
3851 * insdel.c, lisp.h (buffer_overflow): New function.
3852 (insert_from_buffer_1, replace_range, replace_range_2):
3853 * insdel.c (make_gap_larger):
3854 * editfns.c (Finsert_char):
3855 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3856
28177add
PE
3857 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3858
e69dafad
PE
38592011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3860
a7af7fde 3861 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3862
b1c46f02
PE
3863 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3864 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3865
e69dafad
PE
3866 * fileio.c: Don't assume EMACS_INT fits in off_t.
3867 (emacs_lseek): New static function.
3868 (Finsert_file_contents, Fwrite_region): Use it.
3869 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3870
566684ea
PE
3871 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3872
e6966cd6
PE
3873 * fns.c: Don't overflow int when computing a list length.
3874 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3875 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3876 truncation on 64-bit hosts. Check for QUIT every
3877 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3878 faster and is responsive enough.
3879 (Flength): Report an error instead of overflowing an integer.
3880 (Fsafe_length): Return a float if the value is not representable
3881 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3882 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3883 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3884
dd0b0efb
PE
3885 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3886 (header_size, word_size): New constants.
3887 (allocate_vectorlike): Don't check size overflow here.
3888 (allocate_vector): Check it here instead, since this is the only
3889 caller of allocate_vectorlike that could cause overflow.
3890 Check that the new vector's length is representable as a fixnum.
3891
86fe5cfe
PE
3892 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3893 The previous code was bogus. For example, next_almost_prime (32)
3894 returned 39, which is undesirable as it is a multiple of 3; and
3895 next_almost_prime (24) returned 25, which is a multiple of 5 so
3896 why was the code bothering to check for multiples of 7?
3897
80e88859
PE
3898 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3899
4a2f0ad6
PE
3900 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3901
f66c7cf8
PE
3902 Variadic C functions now count arguments with ptrdiff_t.
3903 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3904 Back then I didn't know that the Emacs coding style prefers signed int.
3905 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3906 were being counted with int, which may truncate counts on 64-bit
3907 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3908 * lisp.h (struct Lisp_Subr.function.aMANY)
3909 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3910 Arg counts are now ptrdiff_t, not size_t.
3911 All variadic functions and their callers changed accordingly.
3912 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3913 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3914 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3915 * callint.c (Fcall_interactively): Check arg count for overflow,
3916 to avoid potential buffer overrun. Use signed char, not 'int',
3917 for 'varies' array, so that we needn't bother to check its size
3918 calculation for overflow.
3919 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3920 * eval.c (apply_lambda):
3921 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3922 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3923 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3924
a1759b76
PE
3925 * callint.c (Fcall_interactively): Don't use index var as event count.
3926
d96be9fc
PE
3927 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3928 * mem-limits.h (SIZE): Remove; no longer used.
3929
a690a978 3930 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3931
578c21e6
PE
3932 Remove unnecessary casts.
3933 * xterm.c (x_term_init):
3934 * xfns.c (x_set_border_pixel):
3935 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3936 These aren't needed now that we assume ANSI C.
3937
96f53c6c
PE
3938 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3939 It's more likely to cause problems (due to unsigned overflow)
3940 than to cure them.
3941
83c77d31
PE
3942 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3943
ee2079f1
PE
3944 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3945
6da65536
PE
3946 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3947
7147c4a4
PE
3948 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3949
193e32d9
PE
3950 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3951
e5533da6
PE
3952 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3953
9910e595
PE
3954 GLYPH_CODE_FACE returns EMACS_INT, not int.
3955 * dispextern.h (merge_faces):
3956 * xfaces.c (merge_faces):
01103c44
PE
3957 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3958 Don't assume EMACS_INT fits in int.
9910e595 3959
2638320e
PE
3960 * character.h (CHAR_VALID_P): Remove unused parameter.
3961 * fontset.c, lisp.h, xdisp.c: All uses changed.
3962
045eb8d9
PE
3963 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3964
c1f134b5
PE
3965 * fns.c (concat): Minor tuning based on overflow analysis.
3966 This doesn't fix any bugs. Use int to hold character, instead
3967 of constantly refetching from Emacs object. Use XFASTINT, not
3968 XINT, for value known to be a character. Don't bother comparing
3969 a single byte to 0400, as it's always less.
3970
395fcb93 3971 * floatfns.c (Fexpt):
327eeec8
PE
3972 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3973
abbd3d23
PE
3974 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3975 for characters.
3976
684a03ef
PE
3977 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3978
0fed43f3
PE
3979 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3980 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3981 incorrectly succeed when S was a string, because 4294967386 was
3982 truncated before it was used.
3983
8fd02eb7
PE
3984 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3985 Otherwise, an out-of-range integer could cause undefined behavior
3986 on a 64-bit host.
3987
f8c86b69
PE
3988 * composite.c: Use int, not EMACS_INT, for characters.
3989 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3990 EMACS_INT, for values that are known to be in character range.
3991 This doesn't fix any bugs but is the usual style inside Emacs and
3992 may generate better code on 32-bit machines.
3993
34206dd2
PE
3994 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3995 This is for reasons similar to the recent CHAR_STRING fix.
3996 * charset.c (Fencode_char): Check that character arg is actually
3997 a character. Pass an int to ENCODE_CHAR.
3998 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3999 wider than 'int', as a compile-time check to prevent future regressions
4000 in this area.
4001
c5958d4c 4002 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4003
4004 Make sure a 64-bit char is never passed to CHAR_STRING.
4005 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4006 by silently ignoring the top 32 bits, allowing some values
4007 that were far too large to be valid characters.
4008 * character.h: Include <verify.h>.
4009 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4010 arguments are no wider than unsigned, as a compile-time check
4011 to prevent future regressions in this area.
4012 * data.c (Faset):
01103c44 4013 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4014 (Fsubst_char_in_region):
4015 * fns.c (concat):
4016 * xdisp.c (decode_mode_spec_coding):
4017 Adjust to CHAR_STRING's new requirement.
4018 * editfns.c (Finsert_char, Fsubst_char_in_region):
4019 * fns.c (concat): Check that character args are actually
4020 characters. Without this test, these functions did the wrong
4021 thing with wildly out-of-range values on 64-bit hosts.
4022
d37ca623
PE
4023 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4024 These casts should not be needed on 32-bit hosts, either.
4025 * keyboard.c (read_char):
4026 * lread.c (Fload): Remove casts to unsigned.
4027
ea204efb
PE
4028 * lisp.h (UNSIGNED_CMP): New macro.
4029 This fixes comparison bugs on 64-bit hosts.
4030 (ASCII_CHAR_P): Use it.
4031 * casefiddle.c (casify_object):
01103c44 4032 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4033 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4034 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4035 * dispextern.h (FACE_FROM_ID):
4036 * keyboard.c (read_char): Use UNSIGNED_CMP.
4037
41cb286c
PE
4038 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4039 not to EMACS_INT, to avoid GCC warning.
4040
4a1b9832
PE
4041 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4042
55daad71
PE
4043 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4044 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4045 isn't needed on 32-bit machines.
8f95c75c 4046
01103c44
PE
4047 * buffer.c (Fgenerate_new_buffer_name):
4048 Use EMACS_INT for count, not int.
0ceccced 4049 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4050
4051 * data.c (Qcompiled_function): Now static.
4052
c6f072e7
PE
4053 * window.c (window_body_lines): Now static.
4054
20ce5912
PE
4055 * image.c (gif_load): Rename local to avoid shadowing.
4056
9c4c5f81
PE
4057 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4058 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4059 * alloc.c (make_save_value): Integer argument is now of type
4060 ptrdiff_t, not int.
4061 (mark_object): Use ptrdiff_t, not int.
4062 * lisp.h (pD): New macro.
4063 * print.c (print_object): Use it.
4064
c0c5c8ae
PE
4065 * alloc.c: Use EMACS_INT, not int, to count objects.
4066 (total_conses, total_markers, total_symbols, total_vector_size)
4067 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4068 (total_free_floats, total_floats, total_free_intervals)
4069 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4070 Now EMACS_INT, not int. All uses changed.
4071 (Fgarbage_collect): Compute overall total using a double, so that
4072 integer overflow is less likely to be a problem. Check for overflow
4073 when converting back to an integer.
5a25e253
PE
4074 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4075 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4076 These were 'int' variables that could overflow on 64-bit hosts;
4077 they were never used, so remove them instead of repairing them.
211a0b2a 4078 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4079 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4080 Previously, this ceilinged at INT_MAX, but that doesn't work on
4081 64-bit machines.
e46bb31a 4082 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4083
c78baabf 4084 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4085 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4086 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4087 when a (possibly-narrower) signed value would do just as well.
4088 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4089
c9d624c6
PE
4090 * alloc.c: Catch some string size overflows that we were missing.
4091 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4092 for convenience in STRING_BYTES_MAX.
4093 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4094 The definition here is exact; the one in lisp.h was approximate.
4095 (allocate_string_data): Check for string overflow. This catches
4096 some instances we weren't catching before. Also, it catches
4097 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4098 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4099 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4100
c9d624c6
PE
4101 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4102 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4103 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4104
353032ce
PE
4105 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4106
2bccce07
PE
4107 * alloc.c (Fmake_string): Check for out-of-range init.
4108
0ac30604
SM
41092011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4112
c195f2de
JD
41132011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4114
4115 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4116 xg_get_default_scrollbar_width.
4117
4118 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4119 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4120 (style_changed_cb): Call update_theme_scrollbar_width and call
4121 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4122 all frames (Bug#8505).
4123 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4124 Call gtk_window_set_resizable if HAVE_GTK3.
4125 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4126 and height if HAVE_GTK3 (Bug#8505).
4127 (scroll_bar_width_for_theme): New variable.
4128 (update_theme_scrollbar_width): New function.
4129 (xg_get_default_scrollbar_width): Move code to
4130 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4131 (xg_initialize): Call update_theme_scrollbar_width.
4132
4133 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4134
4135 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4136
e10ac9f1
MR
41372011-06-12 Martin Rudalics <rudalics@gmx.at>
4138
4139 * frame.c (make_frame): Call other_buffer_safely instead of
4140 other_buffer.
4141
4142 * window.c (temp_output_buffer_show): Call display_buffer with
4143 second argument Vtemp_buffer_show_specifiers and reset latter
4144 immediately after the call.
4145 (Vtemp_buffer_show_specifiers): New variable.
4146 (auto_window_vscroll_p, next_screen_context_lines)
4147 (Vscroll_preserve_screen_position): Remove leading asterisks from
4148 doc-strings.
4149
2d3c217e 41502011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4151
7b7f97e8 4152 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4153 * buffer.c (Qclone_number): Remove for now, as it's unused.
4154 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4155 (record_buffer): Remove unused local.
4156 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4157 (set_frame_buffer_list): Remove; unused.
4158 * frame.h (other_visible_frames): Remove decl.
4159 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4160 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4161 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4162 if HAVE_GPM.
4163 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4164 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4165 Define only if HAVE_GPM.
4166 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4167 (update_hints_inhibit): Remove; never set. All uses removed.
4168 * widgetprv.h (emacsFrameClassRec): Remove decl.
4169 * window.c (delete_deletable_window): Now returns void, since it
4170 wasn't returning anything.
4171 (compare_window_configurations): Remove unused locals.
4172 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4173 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4174 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4175 the same widths as pointers. This follows up on the 2011-05-06 patch.
4176 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4177 * xterm.h: Likewise.
4178 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4179
1384b89e
JB
41802011-06-12 Juanma Barranquero <lekktu@gmail.com>
4181
4182 * makefile.w32-in: Update dependencies.
4183 (LISP_H): Add lib/intprops.h.
4184
1100a63c
CY
41852011-06-11 Chong Yidong <cyd@stupidchicken.com>
4186
4187 * image.c (gif_load): Add animation frame delay to the metadata.
4188 (syms_of_image): Use DEFSYM. New symbol `delay'.
4189
6198ccd0
MR
41902011-06-11 Martin Rudalics <rudalics@gmx.at>
4191
4192 * window.c (delete_deletable_window): Re-add.
4193 (Fset_window_configuration): Rewrite to handle dead buffers and
4194 consequently deletable windows.
4195 (window_tree, Fwindow_tree): Remove. Supply functionality in
4196 window.el.
4197 (compare_window_configurations): Simplify code.
4198
b6e3633c
AS
41992011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4200
1ab0dee5
AS
4201 * image.c (imagemagick_load_image): Fix type mismatch.
4202 (Fimagemagick_types): Likewise.
4203
b6e3633c
AS
4204 * window.h (replace_buffer_in_windows): Declare.
4205
9397e56f
MR
42062011-06-11 Martin Rudalics <rudalics@gmx.at>
4207
4208 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4209 Qclone_number. Remove external declaration of Qdelete_window.
4210 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4211 code.
640c8776
SM
4212 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4213 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4214 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4215 buffer list implementation.
4216 (other_buffer_safely): New function.
4217 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4218 calls to replace_buffer_in_windows and
4219 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4220 if allowed.
4221 (record_buffer): Inhibit quitting and rewrite using quittable
4222 functions. Run Qbuffer_list_update_hook if allowed.
4223 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4224 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4225 Move switch-to-buffer to window.el.
9397e56f
MR
4226 (bury-buffer): Move to window.el.
4227 (Vbuffer_list_update_hook): New variable.
4228
4229 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4230 section.
4231
4232 * window.h (resize_frame_windows): Move up in code.
4233 (Fwindow_frame): Remove EXFUN.
4234 (replace_buffer_in_all_windows): Remove prototype.
4235 (replace_buffer_in_windows_safely): Add prototype.
4236
4237 * window.c: Declare Qdelete_window static again. Move down
4238 declaration of select_count.
4239 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4240 (Fother_window): Move to window.el.
4241 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4242 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4243 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4244 window.el.
4245 (replace_buffer_in_windows): Implement by calling
4246 Qreplace_buffer_in_windows.
4247 (replace_buffer_in_all_windows): Remove with some functionality
4248 moved into replace_buffer_in_windows_safely.
4249 (replace_buffer_in_windows_safely): New function.
4250 (select_window_norecord, select_frame_norecord): Move in front
4251 of run_window_configuration_change_hook. Remove now obsolete
4252 declarations.
640c8776
SM
4253 (Fset_window_buffer): Rewrite doc-string.
4254 Call Qrecord_window_buffer.
9397e56f
MR
4255 (keys_of_window): Move binding for other-window to window.el.
4256
b50691aa
CY
42572011-06-11 Chong Yidong <cyd@stupidchicken.com>
4258
4259 * dispextern.h (struct image): Replace data member, whose int_val
4260 and ptr_val fields were not used by anything, with a single
4261 lisp_val object.
4262
4263 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4264 (gif_clear_image, gif_load, imagemagick_load_image)
4265 (gs_clear_image, gs_load): Callers changed.
4266
3f754b86
PE
42672011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4268
cca69397
PE
4269 * buffer.h: Include <time.h>, for time_t.
4270 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4271
109e28d0
PE
4272 Fix minor problems found by static checking.
4273
60737f02
PE
4274 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4275
4b66faf3
PE
4276 Make identifiers static if they are not used in other modules.
4277 * data.c (Qcompiled_function, Qframe, Qvector):
4278 * image.c (QimageMagick, Qsvg):
4279 * minibuf.c (Qmetadata):
4280 * window.c (resize_window_check, resize_root_window): Now static.
4281 * window.h (resize_window_check, resize_root_window): Remove decls.
4282
109e28d0
PE
4283 * window.c (window_deletion_count, delete_deletable_window):
4284 Remove; unused.
46a4ce9e
PE
4285 (window_body_lines): Now static.
4286 (Fdelete_other_windows_internal): Mark vars as initialized.
4287 Make sure 'resize_failed' is initialized.
4288 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4289 (resize_window_apply): Remove unused local.
4290 * window.h (delete_deletable_window): Remove decl.
4291
109e28d0 4292 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4293 (imagemagick_load_image): Fix pointer signedness problem by changing
4294 last arg from unsigned char * to char *. All uses changed.
4295 Also, fix a local for similar reasons.
4296 Remove unused locals. Remove locals to avoid shadowing.
4297 (fn_rsvg_handle_free): Remove; unused.
4298 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4299 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4300
3f754b86
PE
4301 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4302
2547adb1
CY
43032011-06-10 Chong Yidong <cyd@stupidchicken.com>
4304
4305 * image.c (gif_load): Fix omitted cast error introduced by
4306 2011-06-06 change.
4307
2c8e37d4
MR
43082011-06-10 Martin Rudalics <rudalics@gmx.at>
4309
4310 * window.h (resize_proportionally, orig_total_lines)
4311 (orig_top_line): Remove from window structure.
4312 (set_window_height, set_window_width, change_window_heights)
4313 (Fdelete_window): Remove prototypes.
4314 (resize_frame_windows): Remove duplicate declaration.
4315
440a42e3
EZ
43162011-06-10 Eli Zaretskii <eliz@gnu.org>
4317
4318 * window.h (resize_frame_windows, resize_window_check)
4319 (delete_deletable_window, resize_root_window)
4320 (resize_frame_windows): Declare prototypes.
4321
4322 * window.c (resize_window_apply): Make definition be "static" to
4323 match the prototype.
4324
562dd5e9
MR
43252011-06-10 Martin Rudalics <rudalics@gmx.at>
4326
4327 * window.c: Remove declarations of Qwindow_size_fixed,
4328 window_min_size_1, window_min_size_2, window_min_size,
4329 size_window, window_fixed_size_p, enlarge_window, delete_window.
4330 Remove static from declaration of Qdelete_window, it's
4331 temporarily needed by Fbury_buffer.
4332 (replace_window): Don't assign orig_top_line and
4333 orig_total_lines.
4334 (Fdelete_window, delete_window): Remove. Window deletion is
4335 handled by window.el.
640c8776
SM
4336 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4337 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4338 (Fdelete_other_windows): Remove. Deleting other windows is
4339 handled by window.el.
4340 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4341 handled in window.el.
4342 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4343 Window minimum sizes are handled in window.el.
4344 (shrink_windows, size_window, set_window_height)
4345 (set_window_width, change_window_heights, window_height)
4346 (window_width, CURBEG, CURSIZE, enlarge_window)
4347 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4348 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4349 handled in window.el.
4350 (make_dummy_parent): Rename to make_parent_window and give it a
4351 second argument horflag.
4352 (make_window): Don't set resize_proportionally any more.
4353 (Fsplit_window): Remove. Windows are split in window.el.
4354 (save_restore_action, save_restore_orig_size)
4355 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4356 Resize mini windows in window.el.
4357 (grow_mini_window, shrink_mini_window): Implement by calling
4358 Qresize_root_window_vertically, resize_window_check and
4359 resize_window_apply.
640c8776
SM
4360 (saved_window, Fset_window_configuration, save_window_save):
4361 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4362 resize_proportionally.
4363 (window_min_height, window_min_width): Move to window.el.
4364 (keys_of_window): Move bindings for delete-other-windows,
4365 split-window, delete-window and enlarge-window to window.el.
4366
4367 * buffer.c: Temporarily extern Qdelete_window.
4368 (Fbury_buffer): Temporarily call Qdelete_window instead of
4369 Fdelete_window (Fbury_buffer will move to window.el soon).
4370
4371 * frame.c (set_menu_bar_lines_1): Remove code handling
4372 orig_top_line and orig_total_lines.
4373
4374 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4375 set_window_height but set heights directly.
4376 (change_frame_size_1): Use resize_frame_windows.
4377
4378 * xdisp.c (init_xdisp): Don't use set_window_height but set
4379 heights directly.
4380
640c8776
SM
4381 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4382 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4383 run_window_configuration_change_hook.
4384
4385 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4386 instead of change_window_heights and run
4387 run_window_configuration_change_hook.
4388
1a13852e
MR
43892011-06-09 Martin Rudalics <rudalics@gmx.at>
4390
4391 * window.c (replace_window): Rename second argument REPLACEMENT to
4392 NEW. New third argument SETFLAG. Rewrite.
4393 (delete_window, make_dummy_parent): Call replace_window with
4394 third argument 1.
4395 (window_list_1): Move down in code.
4396 (run_window_configuration_change_hook): Move set_buffer part
4397 before select_frame_norecord part in order to unwind correctly.
4398 Rename count1 to count.
4399 (recombine_windows, delete_deletable_window, resize_root_window)
4400 (Fdelete_other_windows_internal)
4401 (Frun_window_configuration_change_hook, make_parent_window)
4402 (resize_window_check, resize_window_apply, Fresize_window_apply)
4403 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4404 (Fdelete_window_internal, Fresize_mini_window_internal):
4405 New functions.
1a13852e
MR
4406 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4407
f3d1777e
MR
44082011-06-08 Martin Rudalics <rudalics@gmx.at>
4409
496e208e
MR
4410 * window.h (window): Add some new members to window structure -
4411 normal_lines, normal_cols, new_total, new_normal, clone_number,
4412 splits, nest, prev_buffers, next_buffers.
4413 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4414 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4415
f3d1777e
MR
4416 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4417 Remove.
496e208e
MR
4418 (make_dummy_parent): Set new members of windows structure.
4419 (make_window): Move down in code. Handle new members of window
4420 structure.
4421 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4422 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4423 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4424 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4425 (Fset_window_next_buffers, Fset_window_clone_number):
4426 New functions.
496e208e
MR
4427 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4428 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4429 Doc-string fixes.
4430 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4431 Argument WINDOW can be now internal window too.
4432 (Fwindow_use_time): Move up in code.
4433 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4434 Rewrite doc-string.
4435 (Fset_window_configuration, saved_window)
4436 (Fcurrent_window_configuration, save_window_save): Handle new
4437 members of window structure.
b9e809c2
MR
4438 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4439 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4440 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4441 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4442 Qget_mru_window, Qresize_root_window,
4443 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4444 Qauto_buffer_name; staticpro them.
f3d1777e 4445
abde8f8c
MR
44462011-06-07 Martin Rudalics <rudalics@gmx.at>
4447
4448 * window.c (Fwindow_total_size, Fwindow_left_column)
4449 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4450 (Fwindow_list_1): New functions.
4451 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4452 (Fwindow_width, Fscroll_left, Fscroll_right):
4453 Use window_body_cols instead of window_box_text_cols.
4454 (delete_window, Fset_window_configuration):
4455 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4456 (delete_all_subwindows): Take a window as argument and not a
4457 structure. Rewrite.
190b47e6
MR
4458 (window_loop): Remove handling of GET_LRU_WINDOW and
4459 GET_LARGEST_WINDOW.
4460 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4461
4462 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4463 window_box_text_cols. delete_all_subwindows now takes a
4464 Lisp_Object as argument.
abde8f8c 4465
640c8776
SM
4466 * indent.c (compute_motion, Fcompute_motion):
4467 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4468
fa8a67e6
MR
4469 * frame.c (delete_frame): Call delete_all_subwindows with root
4470 window as argument.
4471
a54e3482
DC
44722011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4473
4474 * fns.c (Fputhash): Document return value.
4475
60002bf5
CY
44762011-06-06 Chong Yidong <cyd@stupidchicken.com>
4477
4478 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4479
0c671da6 44802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4481
b862a52a 4482 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4483
be44ca6c
PE
4484 Check for overflow when converting integer to cons and back.
4485 * charset.c (Fdefine_charset_internal, Fdecode_char):
4486 Use cons_to_unsigned to catch overflow.
4487 (Fencode_char): Use INTEGER_TO_CONS.
4488 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4489 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4490 * data.c (long_to_cons, cons_to_long): Remove.
4491 (cons_to_unsigned, cons_to_signed): New functions.
4492 These signal an error for invalid or out-of-range values.
4493 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4494 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4495 * font.c (Ffont_variation_glyphs):
4496 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4497 * lisp.h: Include <intprops.h>.
4498 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4499 (cons_to_signed, cons_to_unsigned): New decls.
4500 (long_to_cons, cons_to_long): Remove decls.
4501 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4502 (Fprimitive_undo): Use CONS_TO_INTEGER.
4503 * xfns.c (Fx_window_property): Likewise.
4504 * xselect.c: Include <limits.h>.
4505 (x_own_selection, selection_data_to_lisp_data):
4506 Use INTEGER_TO_CONS.
4507 (x_handle_selection_request, x_handle_selection_clear)
4508 (x_get_foreign_selection, Fx_disown_selection_internal)
4509 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4510 (lisp_data_to_selection_data): Use cons_to_unsigned.
4511 (x_fill_property_data): Use cons_to_signed.
4512 Report values out of range.
4513
d1f3d2af
PE
4514 Check for buffer and string overflow more precisely.
4515 * buffer.h (BUF_BYTES_MAX): New macro.
4516 * lisp.h (STRING_BYTES_MAX): New macro.
4517 * alloc.c (Fmake_string):
4518 * character.c (string_escape_byte8):
4519 * coding.c (coding_alloc_by_realloc):
4520 * doprnt.c (doprnt):
4521 * editfns.c (Fformat):
4522 * eval.c (verror):
4523 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4524 since they may not be the same number.
4525 * editfns.c (Finsert_char):
4526 * fileio.c (Finsert_file_contents):
4527 Likewise for BUF_BYTES_MAX.
4528
dd52fcea
PE
4529 * image.c: Use ptrdiff_t, not int, for sizes.
4530 (slurp_file): Switch from int to ptrdiff_t.
4531 All uses changed.
4532 (slurp_file): Check that file size fits in both size_t (for
4533 malloc) and ptrdiff_t (for sanity and safety).
4534
7f9bbdbb
PE
4535 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4536 if b->modtime has its maximal value.
4537
dfe18f82
PE
4538 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4539
84acfcf0
PE
4540 Don't assume time_t can fit into int.
4541 * buffer.h (struct buffer.modtime): Now time_t, not int.
4542 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4543 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4544
ccd9a01a
PE
4545 Minor fixes for signed vs unsigned integers.
4546 * character.h (MAYBE_UNIFY_CHAR):
4547 * charset.c (maybe_unify_char):
4548 * keyboard.c (read_char, reorder_modifiers):
4549 XINT -> XFASTINT, since the integer must be nonnegative.
4550 * ftfont.c (ftfont_spec_pattern):
4551 * keymap.c (access_keymap, silly_event_symbol_error):
4552 XUINT -> XFASTINT, since the integer must be nonnegative.
4553 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4554 since it makes no difference and we prefer signed.
4555 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4556 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4557 nonnegative.
4558
d6d100dd
SM
45592011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4560
4561 * window.h (Fwindow_frame): Declare.
4562
2b6148e4
PE
45632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4564
4565 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4566 (SPARE_MEMORY): Always define.
4567 (LARGE_REQUEST): Remove.
4568 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4569
f230ecc9
MR
45702011-06-06 Martin Rudalics <rudalics@gmx.at>
4571
727e958e
MR
4572 * lisp.h: Move EXFUNS for Fframe_root_window,
4573 Fframe_first_window and Fset_frame_selected_window to window.h.
4574
4575 * window.h: Move EXFUNS for Fframe_root_window,
4576 Fframe_first_window and Fset_frame_selected_window here from
4577 lisp.h.
4578
4579 * frame.c (Fwindow_frame, Fframe_first_window)
4580 (Fframe_root_window, Fframe_selected_window)
4581 (Fset_frame_selected_window): Move to window.c.
4582 (Factive_minibuffer_window): Move to minibuf.c.
4583 (Fother_visible_frames_p): New function.
4584
4585 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4586
f230ecc9
MR
4587 * window.c (decode_window, decode_any_window): Move up in code.
4588 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4589 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4590 (Fwindow_buffer): Move up and rewrite doc-string.
4591 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4592 (Fwindow_prev): New functions.
727e958e
MR
4593 (Fwindow_frame): Move here from frame.c. Accept any window as
4594 argument.
4595 (Fframe_root_window, Fframe_first_window)
4596 (Fframe_selected_window): Move here from frame.c. Accept frame
4597 or arbitrary window as argument. Update doc-strings.
4598 (Fminibuffer_window): Move up in code.
4599 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4600 (Fset_frame_selected_window): Move here from frame.c.
4601 Marginal rewrite.
727e958e
MR
4602 (Fselected_window, select_window, Fselect_window): Move up in
4603 code. Minor doc-string fixes.
f230ecc9 4604
4d09bcf6
PE
46052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4606
4607 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4608 Do not assume that spare memory exists; that assumption is valid
4609 only if SYSTEM_MALLOC.
4610 (LARGE_REQUEST): New macro, so that the issue of large requests
4611 is separated from the issue of spare memory.
4612
810928a2
AS
46132011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4614
172418ad
AS
4615 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4616 format. (Bug#8806)
4617
43f862f7
AS
4618 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4619
810928a2
AS
4620 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4621 before statements.
4622
a059fe24
JD
46232011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4624
4625 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4626
4627 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4628
4629 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4630 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4631
989bf368
JB
46322011-06-05 Juanma Barranquero <lekktu@gmail.com>
4633
4634 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4635
4b80f674
CY
46362011-06-04 Chong Yidong <cyd@stupidchicken.com>
4637
4638 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4639 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4640 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4641 New error handlers.
4b80f674
CY
4642 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4643 Obey Vx_select_enable_clipboard_manager. Catch errors in
4644 x_clipboard_manager_save (Bug#8779).
4645 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4646 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4647
99a33b77 46482011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4649
4650 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4651
99a33b77 46522011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4653
4654 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4655 in the current matrix if keep_current_p is non-zero.
4656
8264569d
EZ
46572011-06-04 Eli Zaretskii <eliz@gnu.org>
4658
4659 * bidi.c (bidi_level_of_next_char): Fix last change.
4660
57f97249
EZ
46612011-06-03 Eli Zaretskii <eliz@gnu.org>
4662
fec2107c 4663 Support bidi reordering of text covered by display properties.
57f97249 4664
fec2107c
EZ
4665 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4666 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4667 (bidi_cache_search, bidi_cache_iterator_state)
4668 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4669 (bidi_level_of_next_char, bidi_move_to_visually_next):
4670 Support character positions inside a run of characters covered by a
fec2107c
EZ
4671 display string.
4672 (bidi_paragraph_init, bidi_resolve_explicit_1)
4673 (bidi_level_of_next_char): Call bidi_fetch_char and
4674 bidi_fetch_char_advance instead of FETCH_CHAR and
4675 FETCH_CHAR_ADVANCE.
4676 (bidi_init_it): Initialize new members.
4677 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4678 definitions.
4679 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4680 instead of using explicit *_CHAR codes.
d6d100dd
SM
4681 (bidi_resolve_explicit, bidi_resolve_weak):
4682 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4683 bidirectional text is supported only in multibyte buffers.
4684 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4685 it to initialize the frame_window_p member of struct bidi_it.
4686 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4687 (bidi_resolve_explicit, bidi_resolve_weak)
4688 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4689 bidi_it->nchars is non-positive.
4690 (bidi_level_of_next_char): Don't try to lookup the cache for the
4691 next/previous character if nothing is cached there yet, or if we
4692 were just reseat()'ed to a new position.
c40e2fb2 4693
0e14fe90
EZ
4694 * xdisp.c (set_cursor_from_row): Set start and stop points
4695 according to the row's direction when priming the loop that looks
4696 for the glyph on which to display cursor.
4697 (single_display_spec_intangible_p): Function deleted.
4698 (display_prop_intangible_p): Reimplement to call
4699 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4700 Accept 3 additional arguments needed by handle_display_spec.
4701 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4702 values: lists, `(when COND...)' forms, etc.
4703 (single_display_spec_string_p): Support property values that are
4704 lists with the argument STRING its top-level element.
4705 (display_prop_string_p): Fix the condition for processing a
4706 property that is a list to be consistent with handle_display_spec.
fec2107c 4707 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4708 last portion of handle_display_prop.
4709 (compute_display_string_pos): Accept additional argument
4710 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4711 value of a `display' property is a "replacing spec".
4712 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4713 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4714 the display property, but just return a value indicating whether
4715 the display property will replace the characters it covers.
4716 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4717 frame_window_p members of struct bidi_it.
d6d100dd
SM
4718 (compute_display_string_pos, compute_display_string_end):
4719 New functions.
fec2107c
EZ
4720 (push_it): Accept second argument POSITION, where pop_it should
4721 jump to continue iteration.
4722 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4723
fec2107c
EZ
4724 * keyboard.c (adjust_point_for_property): Adjust the call to
4725 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4726
4727 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4728 (bidi_init_it): Update prototypes.
4729 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4730 (compute_display_string_pos, compute_display_string_end):
4731 Declare prototypes.
fec2107c
EZ
4732 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4733 EMACS_INT.
fc6f18ce 4734
40087514 47352011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4736
57f53182
PE
4737 Malloc failure behavior now depends on size of allocation.
4738 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4739 * lisp.h: Change signatures accordingly.
4740 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4741 All callers changed. (Bug#8762)
4742
4743 * gnutls.c: Use Emacs's memory allocators.
4744 Without this change, the gnutls library would invoke malloc etc.
4745 directly, which causes problems on non-SYNC_INPUT hosts, and which
4746 runs afoul of improving memory_full behavior. (Bug#8761)
4747 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4748 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4749 xfree instead of the default malloc, realloc, free.
4750 (Fgnutls_boot): No need to check for memory allocation failure,
4751 since xmalloc does that for us.
4752
ac32cd99 4753 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4754 * category.c (hash_get_category_set):
4755 * ccl.c (ccl_driver):
4756 * charset.c (Fdefine_charset_internal):
4757 * charset.h (struct charset.hash_index):
4758 * composite.c (get_composition_id, gstring_lookup_cache)
4759 (composition_gstring_put_cache):
4760 * composite.h (struct composition.hash_index):
4761 * dispextern.h (struct image.hash):
4762 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4763 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4764 (hashfn_equal, hashfn_user_defined, make_hash_table)
4765 (maybe_resize_hash_table, hash_lookup, hash_put)
4766 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4767 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4768 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4769 * image.c (make_image, search_image_cache, lookup_image)
4770 (xpm_put_color_table_h):
4771 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4772 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4773 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4774 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4775 * alloc.c (allocate_vectorlike):
4776 Check for overflow in vector size calculations.
4777 * ccl.c (ccl_driver):
4778 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4779 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4780 need to be updated by these changes.
40087514
PE
4781 * fns.c (make_hash_table, maybe_resize_hash_table):
4782 Check for integer overflow with large hash tables.
0de4bb68
PE
4783 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4784 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4785 (SXHASH_REDUCE): New macro.
4786 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4787 Use it instead of discarding useful hash info with large hash values.
4788 (sxhash_float): New function.
4789 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4790 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4791 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4792 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4793 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4794 Adjust signatures to match updated version of code.
4795 (consing_since_gc): Now EMACS_INT, since a single hash table can
4796 use more than INT_MAX bytes.
4797
698d32e2
DN
47982011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4799
4800 Make it possible to build with GCC-4.6+ -O2 -flto.
4801
4802 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4803
fd6fa53f
SM
48042011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4805
4806 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4807 Call minibuffer-inactive-mode.
4808
864db017
JB
48092011-05-31 Juanma Barranquero <lekktu@gmail.com>
4810
4811 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4812 Update dependencies.
4813
2ad0baf4
DN
48142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4815
4816 * data.c (init_data): Remove code for UTS, this system is not
4817 supported anymore.
4818
4fcc2638
DN
48192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4820
4821 Don't force ./temacs to start in terminal mode.
4822
4823 * frame.c (make_initial_frame): Initialize faces in all cases, not
4824 only when CANNOT_DUMP is defined.
4825 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4826
c56e0fd5
DN
48272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4828
4829 * dispnew.c (add_window_display_history): Use const for the string
4830 pointer. Remove declaration, not needed.
4831
333d54da 48322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4833
55d4c1b2 4834 Use 'inline', not 'INLINE'.
333d54da 4835 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4836 * alloc.c, fontset.c (INLINE): Remove.
4837 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4838 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4839 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4840 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4841 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4842
738db178
DN
48432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4844
4845 Make it possible to run ./temacs.
4846
4847 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4848 syms_of_callproc does the same thing. Remove test for
4849 "initialized", do it in the caller.
4850 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4851
620c53a6
SM
48522011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4853
4854 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4855 (read_minibuf): Use get_minibuffer.
4856 (syms_of_minibuf): Use DEFSYM.
4857 (Qmetadata): New var.
4858 * data.c (Qbuffer): Don't make it static.
4859 (syms_of_data): Use DEFSYM.
4860
e003a292
PE
48612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4862
4863 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4864 (CCL_CODE_MIN): New macro.
4865
ed008a6d
PE
48662011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4867
3687c2ef
PE
4868 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4869
ed008a6d
PE
4870 * eval.c (Qdebug): Now static.
4871 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4872 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4873 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4874
d66c4c7c
CY
48752011-05-29 Chong Yidong <cyd@stupidchicken.com>
4876
4877 * image.c: Various fixes to ImageMagick code comments.
4878 (Fimagemagick_types): Doc fix.
4879
5fbc2025
PE
48802011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4881
0196f88a
PE
4882 Minor fixes prompted by GCC 4.6.0 warnings.
4883
4884 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4885
5fbc2025
PE
4886 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4887 (x_clipboard_manager_save_all): Move extern decl to ...
4888 * xterm.h: ... here, so that it can be checked for consistency.
4889
1dd3c2d9
CY
48902011-05-29 Chong Yidong <cyd@stupidchicken.com>
4891
4892 * xselect.c (x_clipboard_manager_save_frame)
4893 (x_clipboard_manager_save_all): New functions.
4894 (Fx_clipboard_manager_save): Lisp function deleted.
4895
4896 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4897 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4898
4899 * xterm.h: Update prototype.
4900
5ba6571d
WX
49012011-05-28 William Xu <william.xwl@gmail.com>
4902
4903 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4904 exiting (Bug#8239).
4905
3eaff834
JM
49062011-05-28 Jim Meyering <meyering@redhat.com>
4907
e1900994 4908 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4909 * fns.c (to_uchar): Define.
4910 (crypto_hash_function): Use it to convert some newly-signed
4911 variables to unsigned, to avoid sign-extension bugs. For example,
4912 without this change, (md5 "truc") would evaluate to
4913 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4914 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4915 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4916
0f6990a7
PE
49172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4918
4919 Integer overflow fixes.
c8a9ca5a 4920
08686060
PE
4921 * dbusbind.c: Serial number integer overflow fixes.
4922 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4923 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4924 to hold a serial number that is too large for a fixnum.
4925 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4926 Check for serial numbers out of range. Decode any serial number
59568bf0 4927 that was so large that it became a float. (Bug#8722)
08686060 4928
2d1fc3c7
PE
4929 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4930 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4931 Use XFASTINT rather than XUINT when numbers are nonnegative.
4932 (xd_append_arg, Fdbus_method_return_internal):
4933 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4934 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4935 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4936 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4937 (Bug#8722)
2d1fc3c7 4938
c8a9ca5a
PE
4939 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4940
519e1d69
PE
4941 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4942
30569699
PE
4943 ccl: add integer overflow checks
4944 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4945 (IN_INT_RANGE): New macros.
4946 (ccl_driver): Use them to check for integer overflow when
4947 decoding a CCL program. Many of the new checks are whether XINT (x)
4948 fits in int; it doesn't always, on 64-bit hosts. The new version
4949 doesn't catch all possible integer overflows, but it's an
847044ea 4950 improvement. (Bug#8719)
30569699 4951
c11285dc
PE
4952 * alloc.c (make_event_array): Use XINT, not XUINT.
4953 There's no need for unsigned here.
4954
fdccd48e
PE
4955 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4956 This follows up to the 2011-05-06 change that substituted uintptr_t
4957 for EMACS_INT. This case wasn't caught back then.
4958
37910ab2
PE
4959 Rework Fformat to avoid integer overflow issues.
4960 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4961 now (part of C89). Include <verify.h>.
4962 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4963 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4964 (Fformat): Avoid the prepass trying to compute sizes; it was only
4965 approximate and thus did not catch overflow reliably. Instead, walk
4966 through the format just once, formatting and computing sizes as we go,
4967 checking for integer overflow at every step, and allocating a larger
4968 buffer as needed. Keep track separately whether the format is
4969 multibyte. Keep only the most-recently calculated precision, rather
4970 than them all. Record whether each argument has been converted to
4971 string. Use EMACS_INT, not int, for byte and char and arg counts.
4972 Support field widths and precisions larger than INT_MAX. Avoid
4973 sprintf's undefined behavior with conversion specifications such as %#d
4974 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4975 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4976 formatting out-of-range floating point numbers with int
9173deec 4977 formats. (Bug#8668)
37910ab2 4978
2e6578fb
PE
4979 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4980
0ae6bdee
PE
4981 * data.c: Avoid integer truncation in expressions involving floats.
4982 * data.c: Include <intprops.h>.
4983 (arith_driver): When there's an integer overflow in an expression
4984 involving floating point, convert the integers to floating point
4985 so that the resulting value does not suffer from catastrophic
4986 integer truncation. For example, on a 64-bit host (* 4
4987 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4988 Do not rely on undefined behavior after integer overflow.
4989
de883a70
PE
4990 merge count_size_as_multibyte, parse_str_to_multibyte
4991 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4992 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4993 Check for integer overflow.
4994 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4995 since it's now a duplicate of the other. This is more of
4996 a character than a buffer op, so better that it's in character.c.
4997 * fns.c, print.c: Adjust to above changes.
4998
2ff916cb
PE
49992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5000
5001 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5002
f1b54466
PE
50032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5004
fb1ac845
PE
5005 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5006 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5007 (x_clipboard_manager_save): Now static.
5008 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5009
f1b54466
PE
5010 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5011 (crypto_hash_function): Now static.
5012 Fix pointer signedness problems. Avoid unnecessary initializations.
5013
a9f737ee
CY
50142011-05-27 Chong Yidong <cyd@stupidchicken.com>
5015
5016 * termhooks.h (Vselection_alist): Make it terminal-local.
5017
5018 * terminal.c (create_terminal): Initialize it.
5019
5020 * xselect.c: Support for clipboard managers.
5021 (Vselection_alist): Move to termhooks.h as terminal-local var.
5022 (LOCAL_SELECTION): New macro.
5023 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5024 (symbol_to_x_atom): Remove gratuitous arg.
5025 (x_handle_selection_request, lisp_data_to_selection_data)
5026 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5027 (x_own_selection, x_get_local_selection, x_convert_selection):
5028 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5029 (some_frame_on_display): Delete unused function.
5030 (Fx_own_selection_internal, Fx_get_selection_internal)
5031 (Fx_disown_selection_internal, Fx_selection_owner_p)
5032 (Fx_selection_exists_p): New optional frame arg.
5033 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5034 (x_handle_selection_clear): Don't treat other terminals with the
5035 same keyboard specially. Use the terminal-local Vselection_alist.
5036 (x_clear_frame_selections): Use Frun_hook_with_args.
5037
5038 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5039
5040 * xterm.h: Add support for those atoms.
5041
e067f0c1
CY
50422011-05-26 Chong Yidong <cyd@stupidchicken.com>
5043
5044 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5045 (converted_selections, conversion_fail_tag): New global variables.
5046 (x_selection_request_lisp_error): Free the above.
5047 (x_get_local_selection): Remove unnecessary code.
5048 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5049 of converted selections stored in converted_selections.
5050 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5051 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5052 (x_convert_selection): New function.
5053 (x_handle_selection_event): Simplify.
5054 (x_get_foreign_selection): Don't ignore incoming requests while
5055 waiting for an answer; this will fail when we implement
5056 SAVE_TARGETS, and seems unnecessary anyway.
5057 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5058 (Vx_sent_selection_functions): Doc fix.
5059
0f4aebc0
LL
50602011-05-26 Leo Liu <sdl.web@gmail.com>
5061
5062 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5063
e61124cd
YM
50642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5065
5066 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5067
5068 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5069 for fringe update if it has periodic bitmap.
ac389d0c 5070 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5071 and fringe_bitmap_periodic_p.
5072
5073 * fringe.c (get_fringe_bitmap_data): New function.
5074 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5075 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5076 row. Mark glyph row for fringe update if periodicity changed.
5077
5078 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5079 for fringe update unless it has periodic bitmap.
5080
f16d9837
KH
50812011-05-25 Kenichi Handa <handa@m17n.org>
5082
5083 * xdisp.c (get_next_display_element): Set correct it->face_id for
5084 a static composition.
5085
e1b90ef6
LL
50862011-05-24 Leo Liu <sdl.web@gmail.com>
5087
5088 * deps.mk (fns.o):
5089 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5090
5091 * fns.c (crypto_hash_function, Fsha1): New function.
5092 (Fmd5): Use crypto_hash_function.
5093 (syms_of_fns): Add Ssha1.
5094
7400048f
PE
50952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5096
5097 * gnutls.c: Remove unused macros.
5098 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5099 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5100 Remove macros that are defined and never used.
5101 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5102
abb71cf4
CY
51032011-05-22 Chong Yidong <cyd@stupidchicken.com>
5104
5105 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5106 (Fx_get_selection_internal): Minor cleanup.
5107 (Fx_own_selection_internal): Rename arguments for consistency with
5108 select.el.
5109
6307db39
PE
51102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5111
5112 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5113
f3d4e0a4
CY
51142011-05-22 Chong Yidong <cyd@stupidchicken.com>
5115
5116 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5117
4d8ade89
YM
51182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5119
5120 * dispnew.c (scrolling_window): Don't exclude the case that the
5121 last enabled row in the desired matrix touches the bottom boundary.
5122
32078c8d
GM
51232011-05-21 Glenn Morris <rgm@gnu.org>
5124
5125 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5126 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5127 and add some more files.
32078c8d 5128
7285dc67
EZ
51292011-05-20 Eli Zaretskii <eliz@gnu.org>
5130
5131 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5132 report_file_error introduced by the change from 2011-05-07.
5133
89d1bd22
PE
51342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5135
5136 * systime.h (Time): Define only if emacs is defined.
5137 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5138 where the include path doesn't have X11/X.h by default. See
5139 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5140
e23640bb 51412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5142
5143 * composite.c (find_automatic_composition): Fix previous change.
5144
b9704ad9
GM
51452011-05-20 Glenn Morris <rgm@gnu.org>
5146
5147 * lisp.mk: New file, split from Makefile.in.
5148 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5149 (shortlisp): Remove.
5150 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5151
4a720484
GM
51522011-05-19 Glenn Morris <rgm@gnu.org>
5153
5154 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5155 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5156 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5157 (lisp): Set the order to that of loadup.el.
5158 (shortlisp): Make it a copy of $lisp.
5159 (SOME_MACHINE_LISP): Remove.
5160 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5161 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5162
a28d4396
KH
51632011-05-18 Kenichi Handa <handa@m17n.org>
5164
5165 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5166 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5167 (find_automatic_composition): Mostly rewrite for efficiency.
5168
a2b1fa8e
JB
51692011-05-18 Juanma Barranquero <lekktu@gmail.com>
5170
5171 * makefile.w32-in: Update dependencies.
5172
8e1f5610
CS
51732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5174
5175 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5176 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5177
7025ee00 51782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5179
cdfa6eab
PE
5180 Fix some integer overflow issues, such as string length overflow.
5181
06d6db33
PE
5182 * insdel.c (count_size_as_multibyte): Check for string overflow.
5183
2b4560a8
PE
5184 * character.c (lisp_string_width): Check for string overflow.
5185 Use EMACS_INT, not int, for string indexes and lengths; in
5186 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5187 the resulting string length overflows an EMACS_INT; instead,
5188 report a string overflow if no precision given. When checking for
5189 precision exhaustion, use a check that cannot possibly have
5190 integer overflow. (Bug#8675)
5191 * character.h (lisp_string_width): Adjust to new signature.
5192
cb93f9be
PE
5193 * alloc.c (string_overflow): New function.
5194 (Fmake_string): Use it. This doesn't change behavior, but saves
5195 a few bytes and will simplify future changes.
5196 * character.c (string_escape_byte8): Likewise.
5197 * lisp.h (string_overflow): New decl.
5198
1a1f3366
PE
5199 Fixups, following up to the user-interface timestamp change.
5200 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5201 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5202 * msdos.c (mouse_get_pos): Likewise.
5203 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5204 * w32gui.h (Time): Define by including "systime.h" rather than by
5205 declaring it ourselves. (Bug#8664)
5206
d4e3e4d3
PE
5207 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5208 * image.c (clear_image_cache): Likewise.
5209
f6a24d19
PE
5210 * term.c (term_mouse_position): Don't assume time_t wraparound.
5211
08dc5ae6
PE
5212 Be more systematic about user-interface timestamps.
5213 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5214 and sometimes 'EMACS_UINT', to represent these timestamps.
5215 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5216 This makes the code easier to follow, and makes it easier to catch
5217 integer overflow bugs such as Bug#8664.
5218 * frame.c (Fmouse_position, Fmouse_pixel_position):
5219 Use Time, not unsigned long, for user-interface timestamps.
5220 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5221 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5222 * keyboard.h (last_event_timestamp): Likewise.
5223 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5224 * menu.h (xmenu_show): Likewise.
5225 * term.c (term_mouse_position): Likewise.
5226 * termhooks.h (struct input_event.timestamp): Likewise.
5227 (struct terminal.mouse_position_hook): Likewise.
5228 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5229 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5230 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5231 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5232 what it was before.
5233 * menu.h, termhooks.h: Include "systime.h", for Time.
5234
8e55734a
PE
5235 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5236 Don't assume that the difference between two unsigned long values
5237 can fit into an integer. At this point, we know button_down_time
5238 <= event->timestamp, so the difference must be nonnegative, so
5239 there's no need to cast the result if double-click-time is
5240 nonnegative, as it should be; check that it's nonnegative, just in
5241 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5242 apart (about 25 days). (Bug#8664)
8e55734a 5243
841f1b75 5244 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5245 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5246
3e26f69c
PE
5247 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5248 that always fit in int. Use a sentinel instead of a counter, to
5249 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5250 * frame.h (struct frame): Use int for menu_bar_items_used
5251 instead of EMACS_INT, since it always fits in int.
3e26f69c 5252
5cc152c0
PE
5253 * menu.c (grow_menu_items): Check for int overflow.
5254
d89eb65e
PE
5255 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5256
5235bd3e
PE
5257 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5258 Before, the code was not consistent. These values cannot exceed
5259 2**31 - 1 so there's no need to make them unsigned.
5260 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5261 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5262 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5263 as modifiers.
5264 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5265
bc827e23
PE
5266 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5267 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5268 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5269 presumably because the widths might not match.
5270
78eb494e
PE
5271 * window.c (size_window): Avoid needless test at loop start.
5272
04f2d78b
CB
52732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5274
5275 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5276
d2fc7e3d 52772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5278
5279 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5280
d2fc7e3d 52812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5282
5283 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5284 `width' to `bar_area_x' and `bar_area_width', respectively.
5285 (x_scroll_run): Take account of fringe background extension.
5286
04f2d78b
CB
5287 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5288 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5289 `bar_area_width', respectively.
5290 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5291 background extension.
5292
79b70037
GM
52932011-05-10 Jim Meyering <meyering@redhat.com>
5294
5295 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5296
2f142cc5
JB
52972011-05-10 Juanma Barranquero <lekktu@gmail.com>
5298
5299 * image.c (Finit_image_library): Return t for built-in image types,
5300 like pbm and xbm. (Bug#8640)
5301
57679c86
AS
53022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5303
5304 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5305
888c9e86
EZ
53062011-05-07 Eli Zaretskii <eliz@gnu.org>
5307
b0512a1d
EZ
5308 * w32console.c (Fset_screen_color): Doc fix.
5309 (Fget_screen_color): New function.
5310 (syms_of_ntterm): Defsubr it.
5311
7285dc67
EZ
5312 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5313 unlink the temporary file if Fcall_process didn't create it in the
5314 first place.
5315 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5316 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5317 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5318 cue to call_process_cleanup not to close that handle.
5319
4d3fcc8e
BK
53202011-05-07 Ben Key <bkey76@gmail.com>
5321
5322 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5323 one of two shell specific rules, either bootstrap-temacs-CMD or
5324 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5325 to the previous implementation of the bootstrap-temacs rule.
5326 The bootstrap-temacs-CMD rule is similar to the previous
5327 implementation of the bootstrap-temacs rule except that it
5328 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5329 variable.
5330
5331 These changes, along with some changes to nt/configure.bat,
5332 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5333 earlier fix to add support for --cflags and --ldflags options
5334 that include quotes so that it works whether make uses cmd or
5335 sh as the shell.
5336
b4289b64
MA
53372011-05-06 Michael Albinus <michael.albinus@gmx.de>
5338
5339 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5340 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5341 is a constant.
5342 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5343 a string. Handle both cases.
5344 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5345 (Fdbus_register_method): Use Qinvalid_function.
5346
af4c0e28
JB
53472011-05-06 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * makefile.w32-in: Update dependencies.
5350 (LISP_H): Add inttypes.h and stdin.h.
5351 (PROCESS_H): Add unistd.h.
5352
c51453d9
EZ
53532011-05-06 Eli Zaretskii <eliz@gnu.org>
5354
5355 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5356 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5357
8ff0ac3c 53582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5359
4c4b566b
PE
5360 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5361
aab2b9b5
PE
5362 * term.c (vfatal): Remove stray call to va_end.
5363 It's not needed and the C Standard doesn't allow it here anyway.
5364
c378da0b
PE
5365 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5366 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5367
288b08c7
PE
5368 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5369 bytes.
5370
e3601888
PE
5371 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5372
db6c0e74
PE
5373 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5374
dd5963ea
PE
5375 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5376
88c9450f
PE
5377 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5378
2f9442b8
PE
5379 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5380
c032b5f8
PE
5381 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5382 * charset.c (Fdefine_charset_internal): Don't initialize
5383 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5384 32-bit int (Bug#8600).
a108c10b
PE
5385
5386 * lread.c (read_integer): Be more consistent with string-to-number.
5387 Use string_to_number to do the actual conversion; this avoids
5388 rounding errors and fixes some other screwups. Without this fix,
5389 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5390 (digit_to_number): Move earlier, for benefit of read_integer.
5391 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5392 not a digit in any supported base. (Bug#8602)
a108c10b 5393
ad5f9eea
PE
5394 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5395
aec1708a
PE
5396 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5397 to match comment at start of function. This also removes a
5398 GCC warning about overflow in a 32+64-bit port.
5399
47be4ab5
PE
5400 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5401
371cac43
PE
5402 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5403 Reported by Stefan Monnier in
5404 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5405 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5406 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5407
d01a7826
PE
5408 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5409 (EMACS_UINTPTR): Likewise, with uintptr_t.
5410
7fd47d5c
PE
5411 * lisp.h: Prefer 64-bit EMACS_INT if available.
5412 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5413 on 32-bit hosts that have 64-bit int, so that they can access
5414 large files.
122b0c86
PE
5415 However, temporarily disable this change unless the temporary
5416 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5417
8727937b
PE
5418 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5419
8ac068ac
PE
5420 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5421 This removes an assumption that EMACS_INT and long are the same
5422 width as pointers. The assumption is true for Emacs porting targets
5423 now, but we want to make other targets possible.
5424 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5425 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5426 In the rest of the code, change types of integers that hold casted
5427 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5428 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5429 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5430 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5431 No need to cast type when ORing.
5432 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5433 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5434 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5435 assume EMACS_INT is the same width as char *.
5436 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5437 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5438 Remove no-longer-needed casts.
5439 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5440 (xg_tool_bar_help_callback, xg_make_tool_item):
5441 Use EMACS_INTPTR to hold an integer
5442 that will be cast to void *; this can avoid a GCC warning
5443 if EMACS_INT is not the same width as void *.
5444 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5445 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5446 (current_message_1, set_message_1):
5447 Use a local to convert to proper width without a cast.
5448 * xmenu.c (dialog_selection_callback): Likewise.
5449
ede49d71
PE
5450 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5451 Also, don't assume VALBITS / RAND_BITS is less than 5,
5452 and don't rely on undefined behavior when shifting a 1 left into
5453 the sign bit.
5454 * lisp.h (get_random): Change signature to match.
5455
2f30ecd0
PE
5456 * lread.c (hash_string): Use size_t, not int, for hash computation.
5457 Normally we prefer signed values; but hashing is special, because
5458 it's better to use unsigned division on hash table sizes so that
5459 the remainder is nonnegative. Also, size_t is the natural width
5460 for hashing into memory. The previous code used 'int', which doesn't
5461 retain enough info to hash well into very large tables.
5462 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5463
2a866e7b
PE
5464 * dbusbind.c: Don't possibly lose pointer info when converting.
5465 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5466 Use XPNTR rather than XHASH, so that the high-order bits of
5467 the pointer aren't lost when converting through void *.
5468
51639eac
PE
5469 * eval.c (Fautoload): Don't double-shift a pointer.
5470
92394119
PE
5471 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5472
dbdb9a7c
JB
54732011-05-06 Juanma Barranquero <lekktu@gmail.com>
5474
5475 * gnutls.c (DEF_GNUTLS_FN):
5476 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5477
db7a0b4f
AS
54782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5479
5480 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5481 marker. (Bug#8610)
5482
f7ff1b0f 54832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5484
5485 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5486 New version that can reserve upto 2GB of heap space.
5487
f7ff1b0f 54882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5489
5490 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5491
639c109b
TZ
54922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5493
5494 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5495 `gnutls_certificate_set_x509_key_file'.
5496
d2127135
JB
54972011-05-05 Juanma Barranquero <lekktu@gmail.com>
5498
5499 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5500 Update dependencies.
5501
e968f4f3
JB
55022011-05-04 Juanma Barranquero <lekktu@gmail.com>
5503
5504 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5505 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5506 Remove unused parameter `fildes'.
5507 * process.c (read_process_output, send_process): Don't pass it.
5508
84d358f0
JB
55092011-05-04 Juanma Barranquero <lekktu@gmail.com>
5510
5511 Fix previous change: the library cache is defined in w32.c.
5512 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5513 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5514
0898ca10
JB
55152011-05-04 Juanma Barranquero <lekktu@gmail.com>
5516
5517 Implement dynamic loading of GnuTLS on Windows.
5518
5519 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5520 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5521 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5522 Declare.
5523
5524 * gnutls.c (Qgnutls_dll): Define.
5525 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5526 (gnutls_*): Declare function pointers.
5527 (init_gnutls_functions): New function to initialize function pointers.
5528 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5529 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5530 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5531 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5532 (emacs_gnutls_write, emacs_gnutls_read)
5533 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5534 (Fgnutls_available_p): New function.
5535 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5536 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5537 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5538
5539 * image.c: Include w32.h.
5540 (Vimage_type_cache): Delete.
5541 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5542 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5543 (w32_delayed_load): Move to w32.c.
5544
5545 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5546
5547 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5548 (w32_delayed_load): Move from image.c. When loading a library, record
5549 its filename in the :loaded-from property of the library id.
5550 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5551 Initialize and staticpro them.
5552 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5553
5554 * process.c: Include lisp.h before w32.h, not after.
5555 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5556 instead of gnutls_record_check_pending.
5557
5558 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5559
ff4de4aa
TZ
55602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5561
5562 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5563 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5564 as passed in.
5565
abe95abb
JD
55662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5567
5568 * xterm.c (x_set_frame_alpha): Do not set property on anything
5569 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5570
e16e55d4
JB
55712011-05-02 Juanma Barranquero <lekktu@gmail.com>
5572
5573 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5574
bafcf6a5
JB
55752011-05-02 Juanma Barranquero <lekktu@gmail.com>
5576
5577 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5578 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5579 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5580 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5581 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5582 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5583 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5584 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5585 (Qgnutls_bootprop_callbacks_verify): Make static.
5586
e7a6747f
AS
55872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5588
19ed11ba
AS
5589 * callproc.c: Indentation fixup.
5590
e7a6747f 5591 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5592 (wait_for_termination, interruptible_wait_for_termination):
5593 Move after wait_for_termination_1.
e7a6747f 5594
1ef14cb4
LMI
55952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5596
5597 * sysdep.c (interruptible_wait_for_termination): New function
5598 which is like wait_for_termination, but allows keyboard
5599 interruptions.
5600
5601 * callproc.c (Fcall_process): Add (:file "file") as an option for
5602 the STDOUT buffer.
5603 (Fcall_process_region): Ditto.
5604
330d880c
EZ
56052011-04-30 Eli Zaretskii <eliz@gnu.org>
5606
8db90b73
EZ
5607 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5608 rather than `XVECTOR (FOO)->size'.
5609
330d880c
EZ
5610 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5611 inttypes.h, as a gnulib replacement is used if it not available in
5612 system headers.
5613
15cbd324
EZ
56142011-04-21 Eli Zaretskii <eliz@gnu.org>
5615
5616 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5617 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5618 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5619
5620 * coding.c (coding_alloc_by_realloc): Error out if destination
5621 will grow beyond MOST_POSITIVE_FIXNUM.
5622 (decode_coding_emacs_mule): Abort if there isn't enough place in
5623 charbuf for the composition carryover bytes. Reserve an extra
5624 space for up to 2 characters produced in a loop.
5625 (decode_coding_iso_2022): Abort if there isn't enough place in
5626 charbuf for the composition carryover bytes.
5627
56282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5629
ae940cca
EZ
5630 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5631 aborting when %lld or %lll format is passed.
5632 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5633 %llo or %llx format is passed. (Bug#8545)
5634
03ab8921
EZ
5635 * window.c (window_scroll_line_based): Use a marker instead of
5636 simple variables to record original value of point. (Bug#7952)
5637
afda1437
EZ
5638 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5639 produced by %s or %c overflows available buffer space. (Bug#8545)
5640
f76dee0c
PE
56412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5642
5643 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5644 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5645
fdc5744d
JB
56462011-04-28 Juanma Barranquero <lekktu@gmail.com>
5647
5648 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5649
638f053a
JB
56502011-04-28 Juanma Barranquero <lekktu@gmail.com>
5651
5652 * keyboard.c (Qdelayed_warnings_hook): Define.
5653 (command_loop_1): Run `delayed-warnings-hook'
5654 if Vdelayed_warnings_list is non-nil.
5655 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5656 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5657
d178f871
EZ
56582011-04-28 Eli Zaretskii <eliz@gnu.org>
5659
5660 * doprnt.c (doprnt): Don't return value smaller than the buffer
5661 size if the message was truncated. (Bug#8545).
5662
b124fd93
JB
56632011-04-28 Juanma Barranquero <lekktu@gmail.com>
5664
5665 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5666 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5667
e810457d
PE
56682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5669
5670 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5671
ea51cceb
JB
56722011-04-27 Juanma Barranquero <lekktu@gmail.com>
5673
5674 * makefile.w32-in: Update dependencies.
5675
94dcfacf
EZ
56762011-04-27 Eli Zaretskii <eliz@gnu.org>
5677
5678 Improve `doprnt' and its usage. (Bug#8545)
5679 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5680 `format_end'. Remove support for %l as a conversion specifier.
5681 Don't use xrealloc. Improve diagnostics when the %l size modifier
5682 is used. Update the commentary.
5683
5684 * eval.c (verror): Simplify calculation of size_t.
5685
5686 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5687 messages.
5688
f61f41d7
PE
56892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5690
5691 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5692 change.
5693
96fb4434
PE
56942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5695
5696 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5697 This makes this file independent of the recent pseudovector change.
5698
671875da 56992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5700
69e9b5a3
PE
5701 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5702
b5f869a7 5703 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5704 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5705 Remove unused local.
c8926152 5706 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5707
841a1577 5708 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5709 GCC 4.6.0 optimizes based on type-based alias analysis.
5710 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5711 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5712 != &v->size, and therefore "v->size = 1; b->size = 2; return
5713 v->size;" must therefore return 1. This assumption is incorrect
5714 for Emacs, since it type-puns struct Lisp_Vector * with many other
5715 types. To fix this problem, this patch adds a new type struct
f904488f 5716 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5717 and pseudovectors, and helps optimizing compilers not get fooled
5718 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5719 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5720 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5721 the size member.
eab3844f
PE
5722 (XSETPVECTYPE): Rewrite in terms of new macro.
5723 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5724 This is a bit clearer, and further avoids the possibility of
5725 undesirable aliasing.
5726 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5727 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5728 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5729 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5730 (ASIZE): Now uses header.size rather than size.
5731 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5732 to avoid the hassle of writing XVECTOR (foo)->header.size.
5733 (struct vectorlike_header): New type.
eab3844f
PE
5734 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5735 object, to help avoid aliasing.
5736 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5737 (SUBRP): Likewise, since Lisp_Subr is a special case.
5738 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5739 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5740 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5741 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5742 changed to be "header.size" and "header.next".
5743 * buffer.h (struct buffer): Likewise.
5744 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5745 * frame.h (struct frame): Likewise.
5746 * process.h (struct Lisp_Process): Likewise.
5747 * termhooks.h (struct terminal): Likewise.
5748 * window.c (struct save_window_data, struct saved_window): Likewise.
5749 * window.h (struct window): Likewise.
5750 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5751 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5752 * buffer.c (init_buffer_once): Likewise.
5753 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5754 special case.
5755 * process.c (Fformat_network_address): Use local var for size,
5756 for brevity.
5757
0df1eac5
PE
5758 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5759
847ab9d1 5760 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5761 * data.c (atof): Remove decl; no longer used or needed.
5762 (digit_to_number): Move to lread.c.
5763 (Fstring_to_number): Use new string_to_number function, to be
5764 consistent with how the Lisp reader treats infinities and NaNs.
5765 Do not assume that floating-point numbers represent EMACS_INT
5766 without losing information; this is not true on most 64-bit hosts.
5767 Avoid double-rounding errors, by insisting on integers when
5768 parsing non-base-10 numbers, as the documentation specifies.
5769 * lisp.h (string_to_number): New decl, replacing ...
5770 (isfloat_string): Remove.
bc0a5c13 5771 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5772 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5773 appears to have been a coding error. Similarly, do not accept
5774 strings like +-1e0 as floating point numbers. Do not report
5775 overflow for integer overflows unless the base is not 10 which
5776 means we have no simple and reliable way to continue.
5777 Break out the floating-point parsing into a new
5778 function string_to_number, so that Fstring_to_number parses
5779 floating point numbers consistently with the Lisp reader.
04f2d78b 5780 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5781 (E_CHAR, EXP_INT): Remove, replacing with ...
5782 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5783 (string_to_number): New function, replacing isfloat_string.
5784 This function checks for valid syntax and produces the resulting
5785 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5786 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5787 so that overflow for non-base-10 numbers is reported only when
5788 there's no portable and simple way to convert to floating point.
452f4150 5789
67769ffc
PE
5790 * textprop.c (set_text_properties_1): Rewrite for clarity,
5791 and to avoid GCC warning about integer overflow.
5792
c20db43f
PE
5793 * intervals.h (struct interval): Use EMACS_INT for members
5794 where EMACS_UINT might cause problems. See
5795 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5796 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5797 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5798 All uses changed.
37aa2f85
PE
5799 (offset_intervals): Tell GCC not to worry about length overflow
5800 when negating a negative length.
c20db43f 5801
2538aa2f
PE
5802 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5803 (overrun_check_free): Likewise.
5804
f2d3008d
PE
5805 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5806 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5807 word size.
5808
ec8df744
PE
5809 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5810 (gnutls_make_error): Rename local to avoid shadowing.
5811 (gnutls_emacs_global_deinit): ifdef out; not used.
5812 (Fgnutls_boot): Use const for pointer to readonly storage.
5813 Comment out unused local. Fix pointer signedness problems.
5814
640ee02d
PE
5815 * lread.c (openp): Don't stuff size_t into an 'int'.
5816 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5817 about possible signed overflow.
5818
6048fb2a
PE
5819 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5820 (GDK_KEY_g): Don't define if already defined.
5821 (xg_prepare_tooltip): Avoid pointer signedness problem.
5822 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5823
fa3c87e1
PE
5824 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5825 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5826
2172544b
PE
5827 * xfns.c (Fx_window_property): Simplify a bit,
5828 to make a bit faster and to avoid GCC 4.6.0 warning.
5829 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5830
9b821a21
PE
5831 * fns.c (internal_equal): Don't assume size_t fits in int.
5832
3c616cfa
PE
5833 * alloc.c (compact_small_strings): Tighten assertion a little.
5834
c2982e87
PE
5835 Replace pEd with more-general pI, and fix some printf arg casts.
5836 * lisp.h (pI): New macro, generalizing old pEd macro to other
5837 conversion specifiers. For example, use "...%"pI"d..." rather
5838 than "...%"pEd"...".
5839 (pEd): Remove. All uses replaced with similar uses of pI.
5840 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5841 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5842 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5843 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5844 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5845 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5846 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5847 64-bit hosts.
5848 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5849 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5850 * print.c (safe_debug_print, print_object): Likewise.
5851 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5852 to int.
6f04d126
PE
5853 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5854 avoiding the 0 flag, which is not portable.
c2982e87
PE
5855 * process.c (Fmake_network_process): Use pI to avoid cast.
5856 * region-cache.c (pp_cache): Likewise.
5857 * xdisp.c (decode_mode_spec): Likewise.
5858 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5859 behavior on 64-bit hosts with printf arg.
6f04d126 5860 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5861 (x_stop_queuing_selection_requests): Likewise.
5862 (x_get_window_property): Don't truncate byte count to an 'int'
5863 when tracing.
0b432f21 5864
5e073ec7
PE
5865 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5866 here, since it parses constructs like leading '-' and spaces,
5867 which are not wanted; and it overflows with large numbers.
5868 Instead, simply match F[0-9]+, which is what is wanted anyway.
5869
36372bf9
PE
5870 * alloc.c: Remove unportable assumptions about struct layout.
5871 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5872 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5873 (allocate_vectorlike, make_pure_vector): Use the new macros,
5874 plus offsetof, to remove unportable assumptions about struct layout.
5875 These assumptions hold on all porting targets that I know of, but
5876 they are not guaranteed, they're easy to remove, and removing them
5877 makes further changes easier.
5878
0b432f21
PE
5879 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5880 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5881 (string_overrun_cookie): Now const. Use initializers that
5882 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5883 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5884 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5885 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5886 multiple of sizeof (EMACS_INT); it need not be, if
5887 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5888 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5889
895009e1
JB
58902011-04-26 Juanma Barranquero <lekktu@gmail.com>
5891
5892 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5893
6a7a1b0b
TZ
58942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5895
5896 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5897 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5898 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5899
841a1577 59002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5901
5902 * lisp.h (Qdebug): List symbol.
895009e1 5903 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5904 * keyboard.c (debug-on-event): New variable.
5905 (handle_user_signal): Break into debugger when debug-on-event
5906 matches the current signal symbol.
5907
f2d3ba6f
DN
59082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5909
5910 * alloc.c (check_sblock, check_string_bytes)
5911 (check_string_free_list): Convert to standard C.
5912
42ce4c63
TZ
59132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5914
5915 * w32.c (emacs_gnutls_push): Fix typo.
5916
825cd63c
EZ
59172011-04-25 Eli Zaretskii <eliz@gnu.org>
5918
fb11d64d
EZ
5919 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5920 "cast to pointer from integer of different size".
5921
825cd63c
EZ
5922 Improve doprnt and its use in verror. (Bug#8545)
5923 * doprnt.c (doprnt): Document the set of format control sequences
5924 supported by the function. Use SAFE_ALLOCA instead of always
5925 using `alloca'.
5926
5927 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5928 is one byte too soon. Don't use xrealloc; instead xfree and
5929 xmalloc anew.
5930
e061a11b
TZ
59312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5932
5933 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5934 callbacks stage.
5935
5936 * gnutls.c: Renamed global_initialized to
5937 gnutls_global_initialized. Added internals for the
5938 :verify-hostname-error, :verify-error, and :verify-flags
5939 parameters of `gnutls-boot' and documented those parameters in the
5940 docstring. Start callback support.
9173deec
JB
5941 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5942 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5943 on error. Return error code.
e061a11b
TZ
5944 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5945 (emacs_gnutls_read): Likewise.
5946 (Fgnutls_boot): Return handshake error code.
5947 (emacs_gnutls_handle_error): New function.
5948 (wsaerror_to_errno): Likewise.
5949
5950 * w32.h (emacs_gnutls_pull): Add prototype.
5951 (emacs_gnutls_push): Likewise.
5952
5953 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5954 (emacs_gnutls_push): Likewise.
5955
59562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5957
5958 * process.c (wait_reading_process_output): Check if GnuTLS
5959 buffered some data internally if no FDs are set for TLS
5960 connections.
5961
5962 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5963 (LIBS): Link to USER_LIBS.
5964 ($(BLD)/gnutls.$(0)): New target.
5965
fa6996bc
EZ
59662011-04-24 Eli Zaretskii <eliz@gnu.org>
5967
eb35682e
EZ
5968 * xdisp.c (handle_single_display_spec): Rename the
5969 display_replaced_before_p argument into display_replaced_p, to
5970 make it consistent with the commentary. Fix typos in the
5971 commentary.
5972
e2ad650c
EZ
5973 * textprop.c (syms_of_textprop): Remove dead code.
5974 (copy_text_properties): Delete obsolete commentary about an
5975 interface that was deleted long ago. Fix typos in the description
5976 of arguments.
5977
1b2de274
EZ
5978 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5979 to changes in oldXMenu/XMenu.h from 2011-04-16.
5980 <menu_help_message, prev_menu_help_message>: Constify.
5981 (IT_menu_make_room): menu->help_text is now `const char **';
5982 adjust.
5983
5984 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5985 to changes in oldXMenu/XMenu.h from 2011-04-16.
5986 (struct XMenu): Declare `help_text' `const char **'.
5987
5988 * xfaces.c <Qunspecified>: Make extern again.
5989
5990 * syntax.c: Include sys/types.h before including regex.h, as
5991 required by Posix.
5992
762b15be
EZ
5993 * doc.c (get_doc_string): Improve the format passed to `error'.
5994
5995 * doprnt.c (doprnt): Improve commentary.
5996
5997 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5998
5999 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6000 them with etags.
6001
f1052e5d
EZ
6002 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6003 changes in globals.h immediately force recompilation.
762b15be
EZ
6004 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6005 $(CURDIR)/s/ms-w32.h.
6006 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6007
fa6996bc
EZ
6008 * character.c (Fchar_direction): Function deleted.
6009 (syms_of_character): Don't defsubr it.
6010 <char-direction-table>: Deleted.
6011
e6c3da20
EZ
60122011-04-23 Eli Zaretskii <eliz@gnu.org>
6013
6014 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6015 * doprnt.c: Include limits.h.
6016 (SIZE_MAX): New macro.
04f2d78b
CB
6017 (doprnt): Return a size_t value. 2nd arg is now size_t.
6018 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6019 Improve overflow protection. Support `l' modifier for integer
6020 conversions. Support %l conversion. Don't assume an EMACS_INT
6021 argument for integer conversions and for %c.
6022
6023 * lisp.h (doprnt): Restore prototype.
6024
6025 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6026 $(SRC)/character.h.
6027
6028 * Makefile.in (base_obj): Add back doprnt.o.
6029
6030 * deps.mk (doprnt.o): Add back prerequisites.
6031 (callint.o): Depend on character.h.
6032
6033 * eval.c (internal_lisp_condition_case): Include the handler
6034 representation in the error message.
6035 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6036 when breaking from the loop.
6037
6038 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6039
6040 * callint.c (Fcall_interactively): When displaying error message
6041 about invalid control letter, pass the character's codepoint, not
6042 a pointer to its multibyte form. Improve display of the character
6043 in octal and display also its hex code.
6044
6045 * character.c (char_string): Use %x to display the (unsigned)
6046 codepoint of an invalid character, to avoid displaying a bogus
6047 negative value.
6048
6049 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6050 `error', not SYMBOL_NAME itself.
6051
6052 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6053 character arguments to `error'.
6054
6055 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6056 to `error' in error message about FINAL_CHAR argument. Make sure
6057 FINAL_CHAR is a character, and use %c when it is passed as
6058 argument to `error'.
6059
4ffd0d6b 60602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6061
6062 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6063
6064 * w32.c: Include <time.h>.
6065 (sys_localtime): New function.
6066
4ffd0d6b 60672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6068
6069 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6070
4ffd0d6b 6071 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6072
4ffd0d6b 60732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6074
4ffd0d6b
GM
6075 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6076 zombies (Bug#8467).
aac0c6e3 6077
04c56954
EZ
60782011-04-19 Eli Zaretskii <eliz@gnu.org>
6079
6080 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6081 gl_state.e_property when gl_state.object is Qt.
6082
6083 * insdel.c (make_gap_larger): Remove limitation of buffer size
6084 to <= INT_MAX.
6085
16a43933
CY
60862011-04-18 Chong Yidong <cyd@stupidchicken.com>
6087
6088 * xdisp.c (lookup_glyphless_char_display)
6089 (produce_glyphless_glyph): Handle cons cell entry in
6090 glyphless-char-display.
6091 (Vglyphless_char_display): Document it.
6092
6093 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6094 glyphless-char-display.
6095
4581706e
CY
60962011-04-17 Chong Yidong <cyd@stupidchicken.com>
6097
6098 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6099
6100 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6101
6102 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6103 definition for no-X builds.
6104
4887c6e2 61052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6106
fd35b6f9
PE
6107 Static checks with GCC 4.6.0 and non-default toolkits.
6108
5c1ccb01
PE
6109 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6110
006c5daa
PE
6111 * process.c (keyboard_bit_set): Define only if SIGIO.
6112 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6113 (send_process): Repair possible setjmp clobbering.
6114
efc736d3
PE
6115 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6116
4e2fe2e6
PE
6117 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6118
f97334a2
PE
6119 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6120
4e75f29d
PE
6121 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6122 Define only if needed.
6123
90efadd1
PE
6124 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6125 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6126 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6127
3c647824
PE
6128 * dispextern.h (struct redisplay_interface): Rename param
6129 to avoid shadowing.
e264f262 6130 * termhooks.h (struct terminal): Likewise.
761383f4 6131 * xterm.c (xembed_send_message): Likewise.
3c647824 6132
b58c5c4a
PE
6133 * insdel.c (make_gap_smaller): Define only if
6134 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6135
cad59032
PE
6136 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6137 it.
6138
c339dc2e
PE
6139 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6140 so that we aren't warned about unused symbols.
6141
91a3e27b
PE
6142 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6143
399c71d3 6144 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6145
8ffc96f5
PE
6146 * xfns.c (x_real_positions): Mark locals as initialized.
6147
eef9bc79
PE
6148 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6149
098db9dd
PE
6150 * xterm.c: Fix problems found by static analysis with other toolkits.
6151 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6152 (x_dispatch_event): Declare static if USE_GTK, and
6153 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6154 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6155 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6156 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6157 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6158
eb18f6cc
PE
6159 * xmenu.c (menu_help_callback): Pointer type fixes.
6160 Use const pointers when pointing at readonly data. Avoid pointer
6161 signedness clashes.
6162 (FALSE): Remove unused macro.
6163 (update_frame_menubar): Remove unused decl.
6164
1fe72bf8
PE
6165 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6166
60d9e1db
PE
6167 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6168 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6169 (single_menu_item): Rename local to avoid shadowing.
6170
39261c26
PE
6171 * keyboard.c (make_lispy_event): Remove unused local var.
6172
018c5e19
PE
6173 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6174 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6175
63d2b86e
PE
6176 * bitmaps: Change bitmaps from unsigned char back to the X11
6177 compatible char. Avoid the old compiler warnings about
6178 out-of-range initializers by using, for example, '\xab' rather
6179 than 0xab.
6180
aefd87e1
PE
6181 * xgselect.c (xgselect_initialize): Check vs interface
6182 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6183
bf501fb9
PE
6184 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6185
e9829fdf
PE
6186 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6187 to read-only memory.
6188
1086c095
PE
6189 * fns.c (vector): Remove; this old hack is no longer needed.
6190
2baccd04 6191 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6192 Remove unused var.
dde42981 6193 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6194
72391843 6195 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6196
436c16df 6197 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6198 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6199 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6200
92bb796d 6201 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6202 (x_term_init): Remove local to avoid shadowing.
92bb796d 6203
764430a3 6204 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6205
6206 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6207 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6208
d1dfb56c
EZ
62092011-04-16 Eli Zaretskii <eliz@gnu.org>
6210
c4354cb4
EZ
6211 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6212
d1dfb56c
EZ
6213 Fix regex.c, syntax.c and friends for buffers > 2GB.
6214 * syntax.h (struct gl_state_s): Declare character position members
6215 EMACS_INT.
6216
6217 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6218
04f2d78b
CB
6219 * textprop.c (verify_interval_modification, interval_of):
6220 Declare arguments EMACS_INT.
d1dfb56c
EZ
6221
6222 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6223 EMACS_INT.
6224
6225 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6226
6227 * indent.c (Fvertical_motion): Local variable it_start is now
6228 EMACS_INT.
6229
6230 * regex.c (re_match, re_match_2, re_match_2_internal)
6231 (bcmp_translate, regcomp, regexec, print_double_string)
6232 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6233 (re_compile_pattern, re_exec): Declare arguments and local
6234 variables `size_t' and `ssize_t' and return values `regoff_t', as
6235 appropriate.
6236 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6237 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6238 <compile_stack_type>: `size' and `avail' are now `size_t'.
6239
6240 * regex.h <regoff_t>: Use ssize_t, not int.
6241 (re_search, re_search_2, re_match, re_match_2): Arguments that
6242 specify buffer/string position and length are now ssize_t and
6243 size_t. Return type is regoff_t.
6244
613052cd
BK
62452011-04-16 Ben Key <bkey76@gmail.com>
6246
6247 * nsfont.m: Fixed bugs in ns_get_family and
6248 ns_descriptor_to_entity that were caused by using free to
6249 deallocate memory blocks that were allocated by xmalloc (via
6250 xstrdup). This caused Emacs to crash when compiled with
6251 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6252 --enable-checking=xmallocoverrun). xfree is now used to
6253 deallocate these memory blocks.
6254
4170f62f 62552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6256
71b41406
PE
6257 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6258
9587a89d
PE
6259 emacs_write: Accept and return EMACS_INT for sizes.
6260 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6261 et seq.
6262 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6263 Accept and return EMACS_INT.
6264 (emacs_gnutls_write): Return the number of bytes written on
6265 partial writes.
6266 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6267 (emacs_read, emacs_write): Remove check for negative size, as the
6268 Emacs source code has been audited now.
9587a89d
PE
6269 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6270 (emacs_read, emacs_write): Use it.
273a5f82
PE
6271 * process.c (send_process): Adjust to the new signatures of
6272 emacs_write and emacs_gnutls_write. Do not attempt to store
6273 a byte offset into an 'int'; it might overflow.
9587a89d 6274 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6275
3e047f51
PE
6276 * sound.c: Don't assume sizes fit in 'int'.
6277 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6278 Return EMACS_INT, not int.
3e047f51 6279 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6280 Accept EMACS_INT, not int.
6281 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6282 record read return values.
6283
cc39a9db
BK
62842011-04-15 Ben Key <bkey76@gmail.com>
6285
c9d0ec6d
JB
6286 * keyboard.c (Qundefined): Don't declare static since it is used
6287 in nsfns.m.
6288 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6289 static since they are used in nsfont.m.
cc39a9db 6290
6c60eb9f
SM
62912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6292
6293 * process.c (Qprocessp): Don't declare static.
6294 * lisp.h (Qprocessp): Declare again.
6295
7990b61a
JB
62962011-04-15 Juanma Barranquero <lekktu@gmail.com>
6297
6298 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6299
5d4cb038
PE
63002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6301
8bd7b830 6302 Improve C-level modularity by making more things 'static'.
cd64ea1d 6303
e3b27b31
PE
6304 Don't publish debugger-only interfaces to other modules.
6305 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6306 (verify_bytepos, count_markers): Move decls to the only modules
6307 that need them.
6308 * region-cache.h (pp_cache): Likewise.
6309 * window.h (check_all_windows): Likewise.
6310 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6311
5d4cb038
PE
6312 * sysdep.c (croak): Now static, if
6313 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6314 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6315
6316 * alloc.c (refill_memory_reserve): Now static if
6317 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6318 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6319
e87b6180
PE
6320 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6321 Define only if USE_LUCID.
6322
ac64929e
PE
6323 * xrdb.c (x_customization_string, x_rm_string): Now static.
6324
6f37259d
PE
6325 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6326 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6327
1683e3ab
PE
6328 * xdisp.c (draw_row_with_mouse_face): Now static.
6329 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6330
de9c2632
PE
6331 * window.h (check_all_windows): Mark externally visible.
6332
2b96acb7
PE
6333 * window.c (window_deletion_count): Now static.
6334
6335 * undo.c: Make symbols static if they're not exported.
6336 (last_undo_buffer, last_boundary_position, pending_boundary):
6337 Now static.
6338
50436f33
PE
6339 * textprop.c (interval_insert_behind_hooks): Now static.
6340 (interval_insert_in_front_hooks): Likewise.
6341
64520e5c
PE
6342 * term.c: Make symbols static if they're not exported.
6343 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6344 (max_frame_lines, tty_set_terminal_modes):
6345 (tty_reset_terminal_modes, tty_turn_off_highlight):
6346 (get_tty_terminal): Now static.
6347 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6348 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6349 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6350 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6351 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6352
1fa53021
PE
6353 * sysdep.c: Make symbols static if they're not exported.
6354 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6355 Now static.
6356 (sigprocmask_set, full_mask): Remove; unused.
6357 (wait_debugging): Mark as visible.
6358 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6359 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6360
d4b43b22
PE
6361 * syntax.c (syntax_temp): Define only if !__GNUC__.
6362
b7c513d0
PE
6363 * sound.c (current_sound_device, current_sound): Now static.
6364
989b29ad
PE
6365 * search.c (searchbufs, searchbuf_head): Now static.
6366
13a55a78
PE
6367 * scroll.c (scroll_cost): Remove; unused.
6368 * dispextern.h (scroll_cost): Remove decl.
6369
de68a1fc
PE
6370 * region-cache.h (pp_cache): Mark as externally visible.
6371
40ccffa6
PE
6372 * process.c: Make symbols static if they're not exported.
6373 (process_tick, update_tick, create_process, chan_process):
6374 (Vprocess_alist, proc_buffered_char, datagram_access):
6375 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6376 (deactivate_process): Mark defn as static, as well as decl.
6377 * lisp.h (create_process): Remove decl.
6378 * process.h (chan_process, Vprocess_alist): Remove decls.
6379
ad64fc97
PE
6380 * print.c: Make symbols static if they're not exported.
6381 (print_depth, new_backquote_output, being_printed, print_buffer):
6382 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6383 (print_interval, print_number_index, initial_stderr_stream):
6384 Now static.
6385 * lisp.h (Fprinc): Remove decl.
6386 (debug_output_compilation_hack): Mark as externally visible.
6387
adddb265
PE
6388 * sysdep.c (croak): Move decl from here to syssignal.h.
6389 * syssignal.h (croak): Put it here, so the API can be checked when
6390 'croak' is called from dissociate_if_controlling_tty.
6391
1717ede2
PE
6392 * minibuf.c: Make symbols static if they're not exported.
6393 (minibuf_save_list, choose_minibuf_frame): Now static.
6394 * lisp.h (choose_minibuf_frame): Remove decl.
6395
fa5fb2bc
PE
6396 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6397
1e3890d1
PE
6398 * lread.c: Make symbols static if they're not exported.
6399 (read_objects, initial_obarray, oblookup_last_bucket_number):
6400 Now static.
6401 (make_symbol): Remove; unused.
6402 * lisp.h (initial_obarray, make_symbol): Remove decls.
6403
8a1414fa
PE
6404 * keyboard.c: Make symbols static if they're not exported.
6405 (single_kboard, recent_keys_index, total_keys, recent_keys):
6406 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6407 (this_single_command_key_start, echoing, last_auto_save):
6408 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6409 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6410 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6411 (Vlispy_mouse_stem, double_click_count):
6412 Now static.
6413 (force_auto_save_soon): Define only if SIGDANGER.
6414 (ignore_mouse_drag_p): Now static if
6415 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6416 (print_help): Remove; unused.
6417 (stop_character, last_timer_event): Mark as externally visible.
6418 * keyboard.h (ignore_mouse_drag_p): Declare only if
6419 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6420 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6421 * lisp.h (echoing): Remove decl.
6422 (force_auto_save_soon): Declare only if SIGDANGER.
6423 * xdisp.c (redisplay_window): Simplify code, to make it more
6424 obvious that ignore_mouse_drag_p is not accessed if !defined
6425 USE_GTK && !defined HAVE_NS.
6426
93ea6e8f
PE
6427 * intervals.c: Make symbols static if they're not exported.
6428 (merge_properties_sticky, merge_interval_right, delete_interval):
6429 Now static.
6430 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6431
77382fcc
PE
6432 * insdel.c: Make symbols static if they're not exported.
6433 However, leave prepare_to_modify_buffer alone. It's never
6434 called from outside this function, but that appears to be a bug.
6435 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6436 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6437 (adjust_after_replace_noundo): Remove; unused.
6438 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6439 (signal_before_change): Remove decls.
77382fcc 6440
9306c32e
PE
6441 * indent.c (val_compute_motion, val_vmotion): Now static.
6442
cd44d2eb
PE
6443 * image.c: Make symbols static if they're not exported.
6444 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6445 if USE_GTK.
6446 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6447 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6448
ad9a7a06
PE
6449 * fringe.c (standard_bitmaps): Now static.
6450 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6451
81626931
PE
6452 * frame.c: Make symbols static if they're not exported.
6453 (x_report_frame_params, make_terminal_frame): Now static.
6454 (get_frame_param): Now static, unless HAVE_NS.
6455 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6456 (x_get_resource_string): Remove; not used.
6457 * frame.h (make_terminal_frame, x_report_frame_params):
6458 (x_get_resource_string); Remove decls.
6459 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6460 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6461
239f9db9
PE
6462 * font.c, fontset.c: Make symbols static if they're not exported.
6463 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6464 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6465 * font.c (font_close_object): Now static.
6466 * font.h (font_close_object): Remove.
6467 * fontset.c (FONTSET_OBJLIST): Remove.
6468 (free_realized_fontset) #if-0 the body, which does nothing.
6469 (face_suitable_for_char_p): #if-0, as it's never called.
6470 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6471 * xfaces.c (face_at_string_position):
6472 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6473 since 0 is always ASCII.
6474
dfcf3579
PE
6475 * fns.c (weak_hash_tables): Now static.
6476
5045092b
PE
6477 * fileio.c: Make symbols static if they're not exported.
6478 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6479 (Vwrite_region_annotation_buffers): Now static.
6480
57a96f5c
PE
6481 * eval.c: Make symbols static if they're not exported.
6482 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6483 * lisp.h (backtrace_list): Remove decl.
6484
35f08c38
PE
6485 * emacs.c: Make symbols static if they're not exported.
6486 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6487 (fatal_error_code, fatal_error_signal_hook, standard_args):
6488 Now static.
6489 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6490 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6491 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6492 * lisp.h (fatal_error_signal_hook): Remove decl.
6493 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6494
f44bd759
PE
6495 * editfns.c: Move a (normally-unused) function to its only use.
6496 * editfns.c, lisp.h (get_operating_system_release): Remove.
6497 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6498 worth the hassle of breaking this out.
6499
b532497d
PE
6500 * xterm.c: Make symbols static if they're not exported.
6501 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6502 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6503 (x_destroy_window, x_delete_display):
6504 Now static.
6505 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6506 (x_mouse_leave): Remove; unused.
6507 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6508 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6509 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6510 Remove decls.
6511 (x_mouse_leave): Declare only if WINDOWSNT.
6512 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6513 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6514 USE_X_TOOLKIT.
6515
1675728f
PE
6516 * ftxfont.c: Make symbols static if they're not exported.
6517 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6518 HAVE_FREETYPE.
6519 * font.h (ftxfont_driver): Likewise.
6520
e4cebfca
PE
6521 * xfns.c: Make symbols static if they're not exported.
6522 (x_last_font_name, x_display_info_for_name):
6523 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6524 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6525 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6526 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6527 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6528 (last_show_tip_args): Now static.
6529 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6530 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6531 (x_screen_planes): Remove; unused.
6532 * dispextern.h (x_screen_planes): Remove decl.
6533
5bf46f05
PE
6534 * dispnew.c: Make symbols static if they're not exported.
6535 * dispextern.h (redraw_garbaged_frames, scrolling):
6536 (increment_row_positions): Remove.
6537 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6538 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6539 Now static.
6540 (redraw_garbaged_frames): Remove; unused.
6541
435f4c28
PE
6542 * xfaces.c: Make symbols static if they're not exported.
6543 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6544 Remove decls.
6545 * xterm.h (defined_color): Remove decls.
6546 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6547 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6548 (menu_face_changed_default, defined_color, free_realized_face):
6549 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6550 (ascii_face_of_lisp_face): Remove; unused.
6551
8524aef3
PE
6552 * xdisp.c: Make symbols static if they're not exported.
6553 * dispextern.h (scratch_glyph_row, window_box_edges):
6554 (glyph_to_pixel_coords, set_cursor_from_row):
6555 (get_next_display_element, set_iterator_to_next):
6556 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6557 (show_mouse_face): Remove decls
6558 * frame.h (message_buf_print): Likewise.
6559 * lisp.h (pop_message, set_message, check_point_in_composition):
6560 Likewise.
6561 * xterm.h (set_vertical_scroll_bar): Likewise.
6562 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6563 (message_buf_print, scratch_glyph_row, displayed_buffer):
6564 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6565 (get_next_display_element, show_mouse_face, window_box_edges):
6566 (frame_to_window_pixel_xy, check_point_in_composition):
6567 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6568 (glyph_to_pixel_coords): Remove; unused.
6569
16390cd2
PE
6570 * dired.c (file_name_completion): Now static.
6571
6572 * dbusbind.c (xd_in_read_queued_messages): Now static.
6573
a25f4dfa
PE
6574 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6575 * data.c (circular_list_error): Remove.
6576
14a9c8df
PE
6577 * commands.h (last_point_position, last_point_position_buffer):
6578 (last_point_position_window): Remove decls.
6579 * keyboard.c: Make these variables static.
6580
04f2d78b
CB
6581 * coding.h (coding, code_convert_region, encode_coding_gap):
6582 Remove decls.
74ab6df5
PE
6583 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6584 (iso_code_class, detect_coding, code_convert_region): Now static.
6585 (encode_coding_gap): Remove; unused.
6586
38dfbee1
PE
6587 * chartab.c (chartab_chars, chartab_bits): Now static.
6588
a2cb4e63
PE
6589 * charset.h (charset_iso_8859_1): Remove decl.
6590 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6591 Now static.
6592
127198fd
PE
6593 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6594 * ccl.c (Vccl_program_table): Now static.
6595 (check_ccl_update): Remove; unused.
6596
d85b608f
PE
6597 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6598 * category.h: ... from here.
6599 * category.c (check_category_table, set_category_set): Now static.
6600
31cd66f3
PE
6601 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6602 * lisp.h: Remove these decls.
6603
c358e587
PE
6604 * buffer.c (buffer_count): Remove unused var.
6605
e78aecca
PE
6606 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6607 so that it's not optimized away.
6608 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6609 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6610 exported only to the debugger.
6611
e192d7d3 6612 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6613 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6614
92470028
PE
6615 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6616 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6617 was inaccessible from Lisp.
6618 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6619 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6620
244ed907
PE
6621 alloc.c: Import and export fewer symbols, and remove unused items.
6622 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6623 is defined.
6624 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6625 it's not optimized away by whole-program optimization.
6626 (message_enable_multibyte, free_misc): Remove.
6627 (catchlist, handlerlist, mark_backtrace):
6628 Declare only if BYTE_MARK_STACK.
6629 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6630 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6631 (message_enable_multibyte): Remove decl.
6632 (free_misc, interval_free_list, float_block, float_block_index):
6633 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6634 (cons_free_list, last_marked_index):
6635 Now static.
6636 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6637 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6638 (mark_backtrace): Define only if BYTE_MARK_STACK.
6639 * xdisp.c (message_enable_multibyte): Now static.
6640
61c2b50e 6641 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6642 This makes it easier for human readers (and static analyzers)
6643 to see whether these variables are used from other modules.
6644 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6645 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6646 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6647 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6648 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6649 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6650 * xmenu.c, xselect.c:
6651 Declare Q* vars static if they are not used in other modules.
6652 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6653 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6654 Remove decls of unexported vars.
6655 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6656
95c82688
PE
6657 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6658
16a97296
PE
6659 Make Emacs functions such as Fatom 'static' by default.
6660 This makes it easier for human readers (and static analyzers)
6661 to see whether these functions can be called from other modules.
6662 DEFUN now defines a static function. To make the function external
6663 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6664 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6665 (Finit_image_library):
16a97296
PE
6666 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6667 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6668 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6669 Remove decls, since these functions are now static.
6670 (Funintern, Fget_internal_run_time): New decls, since these functions
6671 were already external.
95c82688 6672
16a97296
PE
6673 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6674 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6675 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6676 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6677 * keyboard.c, keymap.c, lread.c:
6678 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6679 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6680 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6681 Mark functions with DEFUE instead of DEFUN,
6682 if they are used in other modules.
6683 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6684 decls for now-static functions.
6685 * buffer.h (Fdelete_overlay): Remove decl.
6686 * callproc.c (Fgetenv_internal): Mark as internal.
6687 * composite.c (Fremove_list_of_text_properties): Remove decl.
6688 (Fcomposition_get_gstring): New forward static decl.
6689 * composite.h (Fcomposite_get_gstring): Remove decl.
6690 * dired.c (Ffile_attributes): New forward static decl.
6691 * doc.c (Fdocumntation_property): New forward static decl.
6692 * eval.c (Ffetch_bytecode): New forward static decl.
6693 (Funintern): Remove extern decl; now in .h file where it belongs.
6694 * fileio.c (Fmake_symbolic_link): New forward static decl.
6695 * image.c (Finit_image_library): New forward static decl.
6696 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6697 * intervals.h (Fprevious_property_change):
6698 (Fremove_list_of_text_properties): Remove decls.
6699 * keyboard.c (Fthis_command_keys): Remove decl.
6700 (Fcommand_execute): New forward static decl.
6701 * keymap.c (Flookup_key): New forward static decl.
6702 (Fcopy_keymap): Now static.
6703 * keymap.h (Flookup_key): Remove decl.
6704 * process.c (Fget_process): New forward static decl.
6705 (Fprocess_datagram_address): Mark as internal.
6706 * syntax.c (Fsyntax_table_p): New forward static decl.
6707 (skip_chars): Remove duplicate decl.
6708 * textprop.c (Fprevious_property_change): New forward static decl.
6709 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6710 Now internal.
6711 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6712 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6713
785bbd42
PE
6714 * editfns.c (Fformat): Remove unreachable code.
6715
8b913b57
AS
67162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6717
6718 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6719 change. (Bug#8496)
6720
a6744a35
EZ
67212011-04-13 Eli Zaretskii <eliz@gnu.org>
6722
6723 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6724 when at ZV. (Bug#8487)
6725
e7974947
AS
67262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6727
baad03f0
AS
6728 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6729 (Bug#8437)
6730 * keyboard.c (parse_tool_bar_item): Likewise.
6731 * sound.c (sound_cleanup, alsa_close): Likewise.
6732 * termcap.c (tgetent): Likewise.
6733 * xfns.c (x_default_font_parameter): Likewise.
6734 * xsettings.c (read_and_apply_settings): Likewise.
6735
e7974947
AS
6736 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6737 (overrun_check_free): Protoize.
6738
28272684
PE
67392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6740
6741 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6742 since callers should never pass a negative size.
6743 Change the signature to match that of plain 'read' and 'write'; see
6744 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6745 * lisp.h: Update prototypes of emacs_write and emacs_read.
6746
11997c76
EZ
67472011-04-11 Eli Zaretskii <eliz@gnu.org>
6748
6749 * xdisp.c (redisplay_window): Don't try to determine the character
6750 position of the scroll margin if the window start point w->startp
e896f03c 6751 is outside the buffer's accessible region. (Bug#8468)
11997c76 6752
8a2cbd72
EZ
67532011-04-10 Eli Zaretskii <eliz@gnu.org>
6754
6755 Fix write-region and its subroutines for buffers > 2GB.
6756 * fileio.c (a_write, e_write): Modify declaration of arguments and
6757 local variables to support buffers larger than 2GB.
6758 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6759
6760 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6761 argument, local variables, and return value.
6762
6763 * lisp.h: Update prototypes of emacs_write and emacs_read.
6764
6765 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6766
4073e537 67672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6768
1ebfdcb6
PE
6769 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6770
b2ded58d
PE
6771 Fix more problems found by GCC 4.6.0's static checks.
6772
7d66342c
PE
6773 * xdisp.c (vmessage): Use a better test for character truncation.
6774
bbf47d44
PE
6775 * charset.c (load_charset_map): <, not <=, for optimization,
6776 and to avoid potential problems with integer overflow.
9248994d 6777 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6778 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6779 * editfns.c (Fformat): Likewise.
1e69125e 6780 * syntax.c (skip_chars): Likewise.
3befa583 6781
e3019616
PE
6782 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6783 This also lets GCC 4.6.0 generate slightly better loop code.
6784
becfa255
PE
6785 * callint.c (Fcall_interactively): <, not <=, for optimization.
6786 (Fcall_interactively): Count the number of arguments produced,
6787 not the number of arguments given. This is simpler and lets GCC
6788 4.6.0 generate slightly better code.
6789
dae0cd48
PE
6790 * ftfont.c: Distingish more carefully between FcChar8 and char.
6791 The previous code passed unsigned char * to a functions like
6792 strlen and xstrcasecmp that expect char *, which does not
6793 conform to the C standard.
6794 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6795 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6796 char * when the C standard requires it.
6797
76032d70
PE
6798 * keyboard.c (read_char): Remove unused var.
6799
eb3f1cc8
PE
6800 * eval.c: Port to Windows vsnprintf (Bug#8435).
6801 Include <limits.h>.
6802 (SIZE_MAX): Define if the headers do not.
6803 (verror): Do not give up if vsnprintf returns a negative count.
6804 Instead, grow the buffer. This ports to Windows vsnprintf, which
6805 does not conform to C99. Problem reported by Eli Zaretskii.
6806 Also, simplify the allocation scheme, by avoiding the need for
6807 calling realloc, and removing the ALLOCATED variable.
6808
70476b54
PE
6809 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6810
12020a9e
PE
6811 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6812 But keep the doprint source code for now, as we might revamp it
6813 and use it again (Bug#8435).
ea6c7ae6
PE
6814 * lisp.h (doprnt): Remove.
6815 * Makefile.in (base_obj): Remove doprnt.o.
6816 * deps.mk (doprnt.o): Remove.
6817
5fdb398c
PE
6818 error: Print 32- and 64-bit integers portably (Bug#8435).
6819 Without this change, on typical 64-bit hosts error ("...%d...", N)
6820 was used to print both 32- and 64-bit integers N, which relied on
6821 undefined behavior.
6822 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6823 New macro.
6824 * lisp.h (error, verror): Mark as printf-like functions.
6825 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6826 Report overflow in size calculations when allocating printf buffer.
6827 Do not truncate output string at its first null byte.
6828 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6829 Truncate the output at a character boundary, since vsnprintf does not
6830 do that.
6831 * charset.c (check_iso_charset_parameter): Convert internal
6832 character to string before calling 'error', since %c now has the
6833 printf meaning.
6834 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6835 overflow when computing char to be passed to 'error'. Do not
6836 pass Lisp_Object to 'error'; pass the integer instead.
6837 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6838 formatted with plain %d.
6839
b189fa66
PE
6840 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6841
bff87ef0
PE
6842 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6843
7e2cac20
PE
6844 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6845
ce4d90b5
PE
6846 * xterm.c (x_catch_errors): Remove duplicate declaration.
6847
266c9547
PE
6848 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6849
79c49ad2
PE
6850 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6851
368f4090
JM
68522011-04-10 Jim Meyering <meyering@redhat.com>
6853
6854 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6855 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6856 return ssize_t not "int", and use size_t as the buffer length.
6857 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6858 * gnutls.h: Update declarations.
6859 * process.c (read_process_output): Use ssize_t, to match.
6860 (send_process): Likewise.
6861
a32d4040
CY
68622011-04-09 Chong Yidong <cyd@stupidchicken.com>
6863
6864 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6865
8546720e 68662011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6867
04f2d78b
CB
6868 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6869 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6870
8546720e
GM
6871 * xterm.c (handle_one_xevent):
6872 * xmenu.c (create_and_show_popup_menu):
6873 * xselect.c (x_decline_selection_request)
6874 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6875
0a2f5c1a 68762011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6877
6878 Fix some uses of `int' instead of EMACS_INT.
6879 * search.c (string_match_1, fast_string_match)
6880 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6881 (scan_buffer, find_next_newline_no_quit)
6882 (find_before_next_newline, search_command, Freplace_match)
6883 (Fmatch_data): Make some `int' variables be EMACS_INT.
6884
6885 * xdisp.c (display_count_lines): 3rd argument and return value now
6886 EMACS_INT. All callers changed.
6887 (pint2hrstr): Last argument is now EMACS_INT.
6888
6889 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6890 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6891 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6892 (decode_coding_utf_16, decode_coding_emacs_mule)
6893 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6894 (decode_coding_ccl, decode_coding_charset)
6895 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6896 (decode_coding_iso_2022, decode_coding_emacs_mule)
6897 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6898 <char_offset, last_offset>: Declare EMACS_INT.
6899 (encode_coding_utf_8, encode_coding_utf_16)
6900 (encode_coding_emacs_mule, encode_invocation_designation)
6901 (encode_designation_at_bol, encode_coding_iso_2022)
6902 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6903 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6904 Declare EMACS_INT.
6905 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6906 (encode_invocation_designation): Last argument P_NCHARS is now
6907 EMACS_INT.
6908 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6909 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6910
6911 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6912 All users changed.
6913
6914 * ccl.c (Fccl_execute_on_string): Declare some variables
6915 EMACS_INT.
6916
8546720e 69172011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6918
6919 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6920
4e19a977
CS
69212011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6922
6923 * process.c (Fformat_network_address): Doc fix.
6924
87302331
R
69252011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6926
6927 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6928
cbb59342
CY
69292011-04-08 Chong Yidong <cyd@stupidchicken.com>
6930
6931 * keyboard.c (read_char): Call Lisp function help-form-show,
6932 instead of using internal_with_output_to_temp_buffer.
6933 (Qhelp_form_show): New var.
e0d38eeb 6934 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6935
6936 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6937
6938 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6939
e67a13ab
CY
69402011-04-06 Chong Yidong <cyd@stupidchicken.com>
6941
04f2d78b
CB
6942 * process.c (Flist_processes): Remove to Lisp.
6943 (list_processes_1): Delete.
e67a13ab 6944
973f782d
EZ
69452011-04-06 Eli Zaretskii <eliz@gnu.org>
6946
7c106b1e
EZ
6947 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6948
973f782d
EZ
6949 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6950
41cf7d1a 69512011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6952
ca23cc88
PE
6953 Fix more problems found by GCC 4.6.0's static checks.
6954
f390e2d5
PE
6955 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6956
42eea0d0
PE
6957 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6958
b69769da 6959 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6960
f9541e84
PE
6961 * xdisp.c (vmessage): Mark as a printf-like function.
6962
13841b55
PE
6963 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6964
c136c10f
PE
6965 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6966
5e2d4a30
PE
6967 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6968 printf-like functions.
6969 (tiff_load): Add casts to remove these marks before passing them
6970 to system-supplied API.
6971
583f48b9
PE
6972 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6973
b25d760e
PE
6974 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6975 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6976 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6977 directly, rather than having caller test rule sign. This avoids
6978 some unnecessary tests.
6979 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6980 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6981 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6982
bc7b6697 6983 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6984 (xfont_open): Avoid unnecessary tests.
bc7b6697 6985
27ccc379
PE
6986 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6987
dcd5c89a
PE
6988 * composite.h, composite.c (composition_gstring_put_cache):
6989 Use EMACS_INT, not int, for length.
6990
b13a45c6
PE
6991 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6992 breaking out part of COMPOSITION_DECODE_RULE.
6993 (COMPOSITION_DECODE_RULE): Use it.
6994 * composite.c (get_composition_id): Remove unused local vars,
6995 by using the new macro.
6996
1e792e4d
PE
6997 * textprop.c (set_text_properties_1): Change while to do-while,
6998 since the condition is always true at first.
6999
dc6c6455 7000 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7001 (interval_deletion_adjustment): Return unsigned value.
7002 All uses changed.
dc6c6455 7003
aba7731a
PE
7004 * process.c (list_processes_1, create_pty, read_process_output):
7005 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7006 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7007 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7008 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7009 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7010
fdfc4bf3
PE
7011 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7012
fca8fe46 7013 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7014 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7015
06a0259a 7016 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7017 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7018 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7019
e7b9e80f
PE
7020 * print.c (print_error_message): Avoid int overflow.
7021
56201685
PE
7022 * font.c (font_list_entities): Redo for clarity,
7023 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7024
78834453 7025 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7026 (font_score): Avoid potential overflow in diff calculation.
78834453 7027
0bc0b309 7028 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7029 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7030
e610eaca
PE
7031 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7032
b895abce
PE
7033 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7034 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7035 can always succeed if overflow has undefined behavior.
7036
1f1d9321 7037 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7038 (wordify): Omit three unnecessary tests.
1f1d9321 7039
c59478bc
PE
7040 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7041 All callers changed. This avoids the need for an unused var.
7042
79b73827
PE
7043 * casefiddle.c (casify_region): Remove var that is set but not used.
7044
a4db5dfe
PE
7045 * dired.c (file_name_completion): Remove var that is set but not used.
7046
43aae36e
PE
7047 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7048
2a47c44d 7049 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7050 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7051
a37c69bf
PE
7052 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7053 Check for integer overflow on size calculations.
7054
328ab8e7
PE
7055 * buffer.c (Fprevious_overlay_change): Remove var that is set
7056 but not used.
7057
e5a2a5cb
PE
7058 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7059 Remove vars that are set but not used.
8d84a6eb 7060 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7061 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7062
a60e5f68
PE
7063 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7064
f661cb61 7065 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7066 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7067
f0397f5a
PE
7068 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7069 that are set but not used.
7070
8664db06 7071 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7072 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7073
6abdaa4a
PE
7074 * xselect.c (x_get_local_selection, x_handle_property_notify):
7075 Remove vars that are set but not used.
7076
0ce7538d 7077 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7078 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7079
9ae848fc
PE
7080 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7081 Remove var that is set but not used.
0b918413
PE
7082 (scroll_bar_windows_size): Now size_t, not int.
7083 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7084 Check for overflow.
9ae848fc 7085
a5a62657
PE
7086 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7087 (map_tty_color) [!defined MSDOS]: Likewise.
7088
5c5cdd39
PE
7089 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7090
66ebf983
PE
7091 * coding.c: Remove vars that are set but not used.
7092 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7093 All callers changed.
7094 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7095 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7096 (decode_coding_charset): Remove vars that are set but not used.
7097
1be4d761
PE
7098 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7099 that is set but not used.
7100
47553fa8
PE
7101 * print.c (print_object): Remove var that is set but not used.
7102
1f7196bf 7103 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7104 The gnulib version avoids calling malloc in the usual case,
7105 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7106 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7107 * filelock.c (current_lock_owner): Likewise.
7108 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7109 * sysdep.c: Include allocator.h, careadlinkat.h.
7110 (emacs_no_realloc_allocator): New static constant.
7111 (emacs_readlink): New function.
fdb61804
PE
7112 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7113 ../lib/careadlinkat.h.
d1fdcab7 7114
f84c17c7
SM
71152011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7116
7117 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7118 first non-nil return value).
7119
ef3862ad
JD
71202011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7121
7122 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7123 if not defined (Bug#8403).
7124
376a7006
JB
71252011-04-02 Juanma Barranquero <lekktu@gmail.com>
7126
7127 * xdisp.c (display_count_lines): Remove parameter `start',
7128 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7129 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7130 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7131 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7132 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7133 and thereabouts. All callers changed.
7134 (get_per_char_metric): Remove parameter `f', unused since
7135 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7136
6ca3801d
JM
71372011-04-02 Jim Meyering <meyering@redhat.com>
7138
7139 do not dereference NULL upon failed strdup
7140 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7141 (ns_get_family): Likewise.
7142
d8e2b5ba
JB
71432011-04-02 Juanma Barranquero <lekktu@gmail.com>
7144
7145 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7146
8c74fcbd
JD
71472011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7148
7149 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7150 later (Bug#8403).
7151
7200d79c
SM
71522011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7153
03408648 7154 Add lexical binding.
7200d79c 7155
03408648
SM
7156 * window.c (Ftemp_output_buffer_show): New fun.
7157 (Fsave_window_excursion):
7158 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7159
7160 * lread.c (lisp_file_lexically_bound_p): New function.
7161 (Fload): Bind Qlexical_binding.
7162 (readevalloop): Remove `evalfun' arg.
7163 Bind Qinternal_interpreter_environment.
7164 (Feval_buffer): Bind Qlexical_binding.
7165 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7166 Mark as dynamic.
7167 (syms_of_lread): Declare `lexical-binding'.
7168
7169 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7170
7171 * keyboard.c (eval_dyn): New fun.
7172 (menu_item_eval_property): Use it.
ca105506
SM
7173
7174 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7175
03408648
SM
7176 * fns.c (concat, mapcar1): Accept byte-code-functions.
7177
7178 * eval.c (Fsetq): Handle lexical vars.
7179 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7180 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7181 (FletX, Flet): Obey lexical binding.
7182 (Fcommandp): Handle closures.
7183 (Feval): New `lexical' arg.
7184 (eval_sub): New function extracted from Feval. Use it almost
7185 everywhere where Feval was used. Look up vars in lexical env.
7186 Handle closures.
7187 (Ffunctionp): Move from subr.el.
7188 (Ffuncall): Handle closures.
7189 (apply_lambda): Remove `eval_flags'.
7190 (funcall_lambda): Handle closures and new byte-code-functions.
7191 (Fspecial_variable_p): New function.
7192 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7193 but without exporting it to Lisp.
23aba0ea 7194
23aba0ea 7195 * doc.c (Fdocumentation, store_function_docstring):
03408648 7196 * data.c (Finteractive_form): Handle closures.
23aba0ea 7197
03408648
SM
7198 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7199 interactive spec.
ba83908c 7200
04f2d78b
CB
7201 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7202 New byte-codes.
03408648
SM
7203 (exec_byte_code): New function extracted from Fbyte_code to handle new
7204 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7205
03408648 7206 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7207
03408648 7208 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7209
e2abce01
JB
72102011-03-31 Juanma Barranquero <lekktu@gmail.com>
7211
7212 * xdisp.c (redisplay_internal): Fix prototype.
7213
63696a73 72142011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7215
63696a73 7216 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7217 (try_scrolling): Use it when setting scroll_limit.
7218 Limit scrolling to 100 screen lines.
63696a73
EZ
7219 (redisplay_window): Even when falling back on "recentering",
7220 position point in the window according to scroll-conservatively,
7221 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7222
7223 (try_scrolling): When point is above the window, allow searching
7224 as far as scroll_max, or one screenful, to compute vertical
7225 distance from PT to the scroll margin position. This prevents
7226 try_scrolling from unnecessarily failing when
7227 scroll-conservatively is set to a value slightly larger than the
7228 window height. Clean up the case of PT below the margin at bottom
7229 of window: scroll_max can no longer be INT_MAX. When aggressive
7230 scrolling is in use, don't let point enter the opposite scroll
7231 margin as result of the scroll.
7232 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7233 threshold of 100 lines for never-recentering scrolling.
7234
e4cc2dfc
JB
72352011-03-31 Juanma Barranquero <lekktu@gmail.com>
7236
7237 * dispextern.h (move_it_by_lines):
7238 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7239 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7240 (message_log_check_duplicate): Remove parameters `prev_bol' and
7241 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7242 (redisplay_internal): Remove parameter `preserve_echo_area',
7243 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7244
7245 * indent.c (Fvertical_motion):
7246 * window.c (window_scroll_pixel_based, Frecenter):
7247 Don't pass `need_y_p' to `move_it_by_lines'.
7248
1c470562
SM
72492011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7250
44f230aa
SM
7251 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7252 steal a few bits to be more compact.
7253 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7254 Remove unneeded casts.
7255
1c470562
SM
7256 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7257
888adce9
ZK
72582011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7259
7260 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7261 binding" message (bug#7967).
7262
f838ed7b
PE
72632011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7264
77861b95
PE
7265 Fix more problems found by GCC 4.6.0's static checks.
7266
de6dbc14
PE
7267 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7268 Remove unused local var.
7269
f838ed7b
PE
7270 * editfns.c (Fmessage_box): Remove unused local var.
7271
792c7b2b
PE
7272 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7273 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7274 Omit unused local vars.
c499e557 7275 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7276 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7277 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7278 Omit unused local var.
7279
ba0165e1
PE
7280 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7281 Don't assume string length fits in int.
32ad8845 7282 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7283 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7284
3c59b4c9
PE
7285 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7286 instead of alloca (Bug#8344).
7287
a3eed478 7288 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7289 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7290
eb4d412d
PE
7291 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7292
1658b401
PE
7293 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7294 concerns.
7295
7296 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7297
7298 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7299
9a2c6e05
PE
7300 * keyboard.c (syms_of_keyboard): Use the same style as later
7301 in this function when indexing through an array. This also
7302 works around GCC bug 48267.
7303
03d0a109
PE
7304 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7305
44f730c8
PE
7306 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7307
fe75f926
PE
7308 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7309 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7310
ffa8c828
PE
7311 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7312 This avoids undefined behavior on integer overflow, and is a bit
7313 more convenient anyway since it is compared to a size_t variable.
7314
c5101a77
PE
7315 Variadic C functions now count arguments with size_t, not int.
7316 This avoids an unnecessary limitation on 64-bit machines, which
7317 caused (substring ...) to crash on large vectors (Bug#8344).
7318 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7319 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7320 All variadic functions and their callers changed accordingly.
c5101a77
PE
7321 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7322 * data.c (arith_driver, float_arith_driver): Likewise.
7323 * editfns.c (general_insert_function): Likewise.
7324 * eval.c (struct backtrace.nargs, interactive_p)
7325 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7326 (funcall_lambda, mark_backtrace): Likewise.
7327 * fns.c (concat): Likewise.
7328 * frame.c (x_set_frame_parameters): Likewise.
7329 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7330 0 if not found, not -1. All callers changed.
7331
dd3f25f7
PE
7332 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7333 (stack_copy_size): Now size_t, not int.
7334 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7335
461c2ab9
JB
73362011-03-28 Juanma Barranquero <lekktu@gmail.com>
7337
7338 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7339 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7340 All callers changed.
7341
7342 * lisp.h (multibyte_char_to_unibyte):
7343 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7344 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7345 * character.h (CHAR_TO_BYTE8):
7346 * cmds.c (internal_self_insert):
7347 * editfns.c (general_insert_function):
7348 * keymap.c (push_key_description):
7349 * search.c (Freplace_match):
7350 * xdisp.c (message_dolog, set_message_1): All callers changed.
7351
f6d62986
SM
73522011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7353
7354 * keyboard.c (safe_run_hook_funcall): New function.
7355 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7356 don't set the hook to nil, but remove the offending function instead.
7357 (Qcommand_hook_internal): Remove, unused.
7358 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7359 Vcommand_hook_internal.
7360
7361 * eval.c (enum run_hooks_condition): Remove.
7362 (funcall_nil, funcall_not): New functions.
7363 (run_hook_with_args): Call each function through a `funcall' argument.
7364 Remove `cond' argument, now redundant.
7365 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7366 (Frun_hook_with_args_until_failure): Adjust accordingly.
7367 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7368
1db5b1ad
JB
73692011-03-28 Juanma Barranquero <lekktu@gmail.com>
7370
7371 * dispextern.h (string_buffer_position): Remove declaration.
7372
7373 * print.c (strout): Remove parameter `multibyte', unused since
7374 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7375
7376 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7377 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7378 All callers changed.
7379
7380 * w32.c (_wsa_errlist): Use braces for struct initializers.
7381
7382 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7383 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7384 All callers changed.
7385 (string_buffer_position): Likewise. Also, make static (it's never
7386 used outside xdisp.c).
7387 (cursor_row_p): Remove parameter `w', unused since
7388 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7389 (decode_mode_spec): Remove parameter `precision', introduced during
7390 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7391 All callers changed.
7392
5ffb62aa
JD
73932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7394
7395 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7396
461c2ab9 73972011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7398
7399 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7400 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7401 (ns_update_auto_hide_menu_bar): New functions.
7402 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7403 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7404 ns_constrain_all_frames.
7405 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7406 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7407
5c380ffb
JD
74082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7409
7410 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7411
9af30bdf
GM
74122011-03-27 Glenn Morris <rgm@gnu.org>
7413
7414 * syssignal.h: Replace RETSIGTYPE with void.
7415 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7416 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7417 Replace SIGTYPE with void everywhere.
7418 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7419 * s/template.h (SIGTYPE): Remove commented out definition.
7420
e2abce01
JB
74212011-03-26 Eli Zaretskii <eliz@gnu.org>
7422
7423 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7424 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7425
f868cd8a
JB
74262011-03-26 Juanma Barranquero <lekktu@gmail.com>
7427
59eb0929
JB
7428 * w32.c (read_unc_volume): Use parameter `henum', instead of
7429 global variable `wget_enum_handle'.
7430
7431 * keymap.c (describe_vector): Remove parameters `indices' and
7432 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7433 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7434
f868cd8a
JB
7435 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7436
7437 * keyboard.c (timer_check): Remove parameter `do_it_now',
7438 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7439 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7440 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7441
7442 * keyboard.c (read_char):
7443 * w32menu.c (w32_menu_display_help):
7444 * xmenu.c (show_help_event, menu_help_callback):
7445 Adjust calls to `show_help_echo'.
7446
7447 * gtkutil.c (xg_maybe_add_timer):
7448 * keyboard.c (readable_events):
7449 * process.c (wait_reading_process_output):
7450 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7451
7452 * insdel.c (adjust_markers_gap_motion):
7453 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7454 (gap_left, gap_right): Don't call it.
7455
2ecf6fdb
CY
74562011-03-25 Chong Yidong <cyd@stupidchicken.com>
7457
7458 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7459 incurred during fontification.
7460
6b1f9ba4
JB
74612011-03-25 Juanma Barranquero <lekktu@gmail.com>
7462
7463 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7464 (DEFVAR_PER_BUFFER): Don't pass it.
7465
7466 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7467 (scrolling_window): Don't pass it.
7468
0f4a96b5
JB
74692011-03-25 Juanma Barranquero <lekktu@gmail.com>
7470
7471 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7472
7473 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7474 and `suffix'.
7475 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7476 of variables specific to SELinux and computation of `encoded_absname'.
7477
7478 * image.c (XPutPixel): Remove unused variable `height'.
7479
7480 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7481
7482 * unexw32.c (get_section_info): Remove unused variable `section'.
7483
7484 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7485 (system_process_attributes): Remove unused variable `sess'.
7486 (sys_read): Remove unused variable `err'.
7487
7488 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7489 (w32_wnd_proc): Remove unused variable `isdead'.
7490 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7491 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7492 (x_create_tip_frame): Remove unused variable `tem'.
7493
7494 * w32inevt.c (w32_console_read_socket):
7495 Remove unused variable `no_events'.
7496
7497 * w32term.c (x_draw_composite_glyph_string_foreground):
7498 Remove unused variable `width'.
7499
1149507c
JB
75002011-03-24 Juanma Barranquero <lekktu@gmail.com>
7501
7502 * w32term.c (x_set_glyph_string_clipping):
7503 Don't pass uninitialized region to CombineRgn.
7504
9c88f339
JB
75052011-03-23 Juanma Barranquero <lekktu@gmail.com>
7506
7507 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7508 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7509 (Fx_close_connection): Remove unused variable `i'.
7510
7511 * w32font.c (w32font_draw): Return number of glyphs.
7512 (w32font_open_internal): Remove unused variable `i'.
7513 (w32font_driver): Add missing initializer.
7514
7515 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7516 (fill_in_menu): Remove unused variable `items_added'.
7517
7518 * w32term.c (last_mouse_press_frame): Remove static global variable.
7519 (w32_clip_to_row): Remove unused variable `f'.
7520 (x_delete_terminal): Remove unused variable `i'.
7521
7522 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7523 (NOTHING): Remove unused static global variable.
7524 (uniscribe_check_otf): Remove unused variable `table'.
7525 (uniscribe_font_driver): Add missing initializers.
7526
dee091a3
JD
75272011-03-23 Julien Danjou <julien@danjou.info>
7528
7529 * term.c (Fsuspend_tty, Fresume_tty):
7530 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7531 * window.c (temp_output_buffer_show):
7532 * insdel.c (signal_before_change):
7533 * frame.c (Fhandle_switch_frame):
7534 * fileio.c (Fdo_auto_save):
7535 * emacs.c (Fkill_emacs):
7536 * editfns.c (save_excursion_restore):
7537 * cmds.c (internal_self_insert):
7538 * callint.c (Fcall_interactively):
7539 * buffer.c (Fkill_all_local_variables):
7540 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7541 Use Frun_hooks.
0f4a96b5 7542 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7543 unconditionnaly since it does the check itself.
7544
2c520ab5 75452011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7546
c9c49752
PE
7547 Fix more problems found by GCC 4.5.2's static checks.
7548
8abc3f12
PE
7549 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7550 the first time through the loop, since we know p0 < p1 then.
7551 This also avoids a gcc -Wstrict-overflow warning.
7552
a2d26660
PE
7553 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7554 leading to a memory leak, possible in functions like
7555 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7556 of objects (Bug#8318).
a2d26660 7557
916c72e9
PE
7558 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7559 that could (at least in theory) be that large.
7560
19ab8a18
PE
7561 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7562 This is less likely to overflow, and avoids undefined behavior if
7563 overflow does occur. All callers changed. Use strtoul to scan
7564 for the unsigned long integer.
b7cbbd6f
PE
7565 (pint2hrstr): Simplify and tune code slightly.
7566 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7567
f0641eff
PE
7568 * scroll.c (do_scrolling): Work around GCC bug 48228.
7569 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7570
7f650bb9
PE
7571 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7572 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7573 (validate_x_resource_name): Simplify count usage.
7574 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7575
37dd57d1
PE
7576 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7577 fail (Bug#8306).
81e56e61 7578
699979fc 7579 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7580
401bf9b4
PE
7581 * process.c (Fmake_network_process): Use socklen_t, not int,
7582 where POSIX says socklen_t is required in portable programs.
7583 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7584 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7585 (Fmake_network_process, server_accept_connection):
7586 (wait_reading_process_output, read_process_output):
7587 Likewise.
7588
b93aacde
PE
7589 * process.c: Rename or move locals to avoid shadowing.
7590 (list_processes_1, Fmake_network_process):
7591 (read_process_output_error_handler, exec_sentinel_error_handler):
7592 Rename or move locals.
4dc343ee 7593 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7594 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7595 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7596 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7597 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7598
af8a867c 7599 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7600 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7601 Include tparam.h instead, since it declares them.
af8a867c
PE
7602 * cm.h (PC): Remove extern decl; tparam.h now does this.
7603 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7604 * terminfo.c: Include tparam.h, to check interfaces.
7605 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7606 (tparam): Adjust signature to match interface in tparam.h;
7607 this removes some undefined behavior. Check that outstring and len
7608 are zero, which they always are with Emacs.
7609 * tparam.h (PC, BC, UP): New extern decls.
7610
0248044d 7611 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7612 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7613
8ff096c1 7614 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7615 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7616 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7617 (ftfont_list): Remove unused local.
49eaafba
PE
7618 (get_adstyle_property, ftfont_pattern_entity):
7619 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7620 Rename locals to avoid shadowing.
8ff096c1 7621
e2be39f6
PE
7622 * xfont.c (xfont_list_family): Mark var as initialized.
7623
c9735e30
PE
7624 * xml.c (make_dom): Now static.
7625
8f5201ae
PE
7626 * composite.c (composition_compute_stop_pos): Rename local to
7627 avoid shadowing.
b246f932
PE
7628 (composition_reseat_it): Remove unused locals.
7629 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7630 (composition_update_it): Mark var as initialized.
11b61122
PE
7631 (find_automatic_composition): Mark vars as initialized,
7632 with a FIXME (Bug#8290).
8f5201ae 7633
760fbc2c
PE
7634 character.h: Rename locals to avoid shadowing.
7635 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7636 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7637 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7638 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7639 to avoid shadowing.
7640
ff08eb85
PE
7641 * textprop.c (property_change_between_p): Remove; unused.
7642
fc7bf025
PE
7643 * intervals.c (interval_start_pos): Now static.
7644
235d7abc
PE
7645 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7646
44f230aa
SM
7647 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7648 Rename locals to avoid shadowing.
3e7d6594 7649
50060332
PE
7650 * sound.c (wav_play, au_play, Fplay_sound_internal):
7651 Fix pointer signedness.
d01f234b 7652 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7653 (wav_play): Initialize a variable to 0, to prevent undefined
7654 behavior (Bug#8278).
50060332 7655
c4fc4e30
PE
7656 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7657
918436ed
PE
7658 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7659
c939f91b
PE
7660 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7661 clobbering (Bug#8298).
b9c7f648
PE
7662 * sysdep.c (sys_subshell): Likewise.
7663 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7664
6bd8c144
PE
7665 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7666 This should get cleaned up, so that child_setup has the
7667 same signature on all platforms.
7668
7710357c 7669 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7670 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7671
c59da222
CY
76722011-03-22 Chong Yidong <cyd@stupidchicken.com>
7673
7674 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7675 not to be necessary, and produces flickering.
7676
66b87493
GM
76772011-03-20 Glenn Morris <rgm@gnu.org>
7678
7679 * config.in: Remove file.
7680
45b6f6d5
JB
76812011-03-20 Juanma Barranquero <lekktu@gmail.com>
7682
7683 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7684 are now in src/globals.h.
7685 (syms_of_minibuf): Remove spurious & from previous change.
7686
3ec03f7e
LL
76872011-03-20 Leo <sdl.web@gmail.com>
7688
7689 * minibuf.c (completing-read-function): New variable.
7690 (completing-read-default): Rename from completing-read.
7691 (completing-read): Call completing-read-function.
7692
b14e3e21
CY
76932011-03-19 Juanma Barranquero <lekktu@gmail.com>
7694
7695 * xfaces.c (Fx_load_color_file):
7696 Read color file from absolute filename (bug#8250).
7697
f2b726e6
JB
76982011-03-19 Juanma Barranquero <lekktu@gmail.com>
7699
7700 * makefile.w32-in: Update dependencies.
7701
09f6ff02
EZ
77022011-03-17 Eli Zaretskii <eliz@gnu.org>
7703
7704 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7705
29a6015a
PE
77062011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7707
a3a6c54e
PE
7708 Fix more problems found by GCC 4.5.2's static checks.
7709
b766f867
PE
7710 * process.c (make_serial_process_unwind, send_process_trap):
7711 (sigchld_handler): Now static.
7712
be02381c
PE
7713 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7714 That way, the code declares only the vars that it needs.
7715 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7716 * s/cygwin.h (PTY_ITERATION): Likewise.
7717 * s/darwin.h (PTY_ITERATION): Likewise.
7718 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7719
57048744
PE
7720 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7721 * process.c (allocate_pty): Don't declare stb unless it's needed.
7722
7914961c 7723 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7724 (CONSTANTLIM): Remove; unused.
7725 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7726 Define only if needed.
7914961c 7727
b3967b18
PE
7728 * unexelf.c (unexec): Name an expression,
7729 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7730 Use a different way to cause a compilation error if anyone uses
7731 n rather than nn, a way that does not involve shadowing.
73366a00 7732 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7733
29a6015a
PE
7734 * deps.mk (unexalpha.o): Remove; unused.
7735
43cfc33e 7736 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7737 * unexec.h: New file.
ce701a33
PE
7738 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7739 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7740 Depend on unexec.h.
7741 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7742 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7743 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7744 Change as necessary to match prototype in unexec.h.
ce701a33 7745
01f44d5a
PE
7746 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7747 shadowing.
4f63c6bb 7748 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7749
a6670b0b
PE
7750 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7751 Rename locals to avoid shadowing.
7752
cef2010d 7753 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7754 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7755
d4d7173a
PE
7756 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7757
f08b802a
PE
7758 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7759 warning when compiling print.c.
7760
3ddb0639
PE
7761 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7762 instead of using an uninitialized var.
5ad03b97 7763 (font_sort_entities): Mark var as initialized.
3ddb0639 7764
170a2692
PE
7765 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7766
e663c700
PE
7767 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7768 pointers to constants.
89bc529a 7769 (font_parse_fcname): Remove unused vars.
7b81e2d0 7770 (font_delete_unmatched): Now static.
ea838e10 7771 (font_get_spec): Remove; unused.
13a547c6
PE
7772 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7773 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7774 Rename or move locals to avoid shadowing.
e663c700 7775
2a80c887 7776 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7777 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7778
1384fa33 7779 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7780 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7781
8b2c52e9
PE
7782 * alloc.c (mark_backtrace): Move decl from here ...
7783 * lisp.h: ... to here, so that it can be checked.
7784
475545b5 7785 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7786 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7787 (lisp_indirect_variable): Name an expression,
7788 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7789 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7790
b1349114 7791 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7792 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7793 Use const pointer when appropriate.
b1349114 7794
a2928364
PE
7795 * lisp.h (get_system_name, get_operating_system_release):
7796 Move decls here, to check interfaces.
7797 * process.c (get_operating_system_release): Move decl to lisp.h.
7798 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7799 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7800 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7801 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7802 (Fformat_time_string, Fencode_time, Finsert_char):
7803 (Ftranslate_region_internal, Fformat):
7804 Rename or remove local vars to avoid shadowing.
9710023e 7805 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7806
a415e694
PE
7807 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7808 avoid shadowing.
7809
8ef4622d
PE
7810 * lisp.h (eassert): Check that the argument compiles, even if
7811 ENABLE_CHECKING is not defined.
7812
946f9a5b
PE
7813 * data.c (Findirect_variable): Name an expression, to avoid
7814 gcc -Wbad-function-cast warning.
112396d6 7815 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7816 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7817 (Fmake_variable_buffer_local, Fmake_local_variable):
7818 Mark variables as initialized.
52746918 7819 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7820
e5aab7e7 7821 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7822 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7823 Rename locals to avoid shadowing.
dff45157
PE
7824 (mark_stack): Move local variables into the #ifdef region where
7825 they're used.
7bc26fdb
PE
7826 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7827 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7828 needed otherwise.
7829 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7830 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7831 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7832
e5aab7e7
PE
7833 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7834 avoids undefined behavior in theory.
7835
4da60324
PE
7836 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7837
88043301
PE
7838 Use functions, not macros, for up- and down-casing (Bug#8254).
7839 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7840 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7841 to use the following functions instead of these macros.
7842 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7843 EMACS_INT, since callers assume the returned value fits in int.
7844 (upcase1): Likewise, for UPCASE_TABLE.
7845 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7846 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7847 the race-condition problem in the old DOWNCASE.
88043301 7848
19ed5445
PE
7849 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7850 Rename locals to avoid shadowing.
7851 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7852 (regex_compile, re_search_2, re_match_2_internal):
7853 Remove unused local vars.
952db0d7
PE
7854 (FREE_VAR): Rewrite so as not to use empty "else",
7855 which gcc can warn about.
da053e48 7856 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7857 (RETALLOC_IF): Define only if needed.
7858 (WORDCHAR_P): Likewise. This one is never needed, but is used
7859 only in a comment talking about a compiler bug, so put inside
7860 the #if 0 of that comment.
7861 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7862 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7863 Remove; unused.
19ed5445 7864
1f3561e4 7865 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7866 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7867 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7868
ded6f8f7
PE
7869 * search.c (simple_search): Remove unused var.
7870
dbd37a95
PE
7871 * dired.c (compile_pattern): Move decl from here ...
7872 * lisp.h: ... to here, so that it can be checked.
7873 (struct re_registers): New forward decl.
7874
7e47afad
PE
7875 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7876
85f24f61
PE
7877 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7878 All uses changed.
7879 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7880 Rename locals to avoid shadowing.
5671df8f 7881 (Fvertical_motion): Mark locals as initialized.
85f24f61 7882
181aa2be 7883 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7884 (casify_region): Mark local as initialized.
181aa2be 7885
930d429c
PE
7886 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7887
7082eac6
PE
7888 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7889 New macros, so that the caller can use some names other than
7890 gcpro1, gcpro2, etc.
7891 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7892 of the new macros.
7893 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7894 argument, for consistency with GCPRO2_VAR, etc: it is now the
7895 prefix of the variable, not the variable itself. All uses
7896 changed.
38b2c076
PE
7897 * dired.c (directory_files_internal, file_name_completion):
7898 Rename locals to avoid shadowing.
7899
15206ed9
PE
7900 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7901 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7902 dired.c's scmp function, had undefined behavior.
7903 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7904 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7905 * buffer.h: ... to here, because these macros use current_buffer,
7906 and the new implementation with inline functions needs to have
7907 current_buffer in scope now, rather than later when the macros
7908 are used.
7909 (downcase, upcase1): New static inline functions.
7910 (DOWNCASE, UPCASE1): Reimplement using these functions.
7911 This avoids undefined behavior in expressions like
7912 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7913 from race conditions in accessing the global variables
7914 case_temp1 and case_temp2.
7915 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7916 * lisp.h (case_temp1, case_temp2): Remove their decls.
7917 * character.h (ASCII_CHAR_P): Move from here ...
7918 * lisp.h: ... to here, so that the inline functions mentioned
7919 above can use them.
7920
4a6bea26
PE
7921 * dired.c (directory_files_internal_unwind): Now static.
7922
f14b7e14
PE
7923 * fileio.c (file_name_as_directory, directory_file_name):
7924 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7925 Now static.
2893f146
PE
7926 (file_name_as_directory): Use const pointers when appropriate.
7927 (Fexpand_file_name): Likewise. In particular, newdir might
7928 point at constant storage, so make it a const pointer.
fd4ead52 7929 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7930 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7931 signedness issues.
f839df0c
PE
7932 (Fset_file_times, Finsert_file_contents, auto_save_error):
7933 Rename locals to avoid shadowing.
f14b7e14 7934
5716756e 7935 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7936 (Ftry_completion, Fall_completions): Rename or remove locals
7937 to avoid shadowing.
5716756e 7938
b4c3046a
PE
7939 * marker.c (bytepos_to_charpos): Remove; unused.
7940
b45db522
PE
7941 * lisp.h (verify_bytepos, count_markers): New decls,
7942 so that gcc does not warn that these functions aren't declared.
7943
85876d07
PE
7944 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7945 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7946 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7947 (copy_text): Remove unused local var.
85876d07 7948
03d78a21 7949 * filelock.c (within_one_second): Now static.
b3dd38ab 7950 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7951
5df8f01b
PE
7952 * buffer.c (fix_overlays_before): Mark locals as initialized.
7953 (fix_start_end_in_overlays): Likewise. This function should be
7954 simplified by using pointers-to-pointers, but that's a different
7955 matter.
b1d876f1 7956 (switch_to_buffer_1): Now static.
8f54f30a
PE
7957 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7958 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7959
a70072c9 7960 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7961 Fix pointer signedness issue.
edced198
PE
7962 (sys_subshell): Mark local as volatile if checking for lint,
7963 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7964 (MAXPATHLEN): Define only if needed.
a70072c9 7965
a0977c44
PE
7966 * process.c (serial_open, serial_configure): Move decls from here ...
7967 * systty.h: ... to here, so that they can be checked.
7968
a884fdcc
PE
7969 * fns.c (get_random, seed_random): Move extern decls from here ...
7970 * lisp.h: ... to here, so that they can be checked.
7971
604efe86 7972 * sysdep.c (reset_io): Now static.
b8950c94 7973 (wait_for_termination_signal): Remove; unused.
604efe86 7974
38fc62d9
PE
7975 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7976 (copy_keymap_item, append_key, push_text_char_description):
7977 Now static.
1004a21a 7978 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7979 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7980 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7981 (describe_map_tree):
7982 Rename locals to avoid shadowing.
38fc62d9 7983
2f2650da
PE
7984 * keyboard.c: Declare functions static if they are not used elsewhere.
7985 (echo_char, echo_dash, cmd_error, top_level_2):
7986 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7987 (read_char, kbd_buffer_get_event, make_lispy_position):
7988 (make_lispy_event, make_lispy_movement, apply_modifiers):
7989 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7990 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7991 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7992 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7993 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7994
a053e86c 7995 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7996 (mark_kboards): Move decl here ...
7997 * alloc.c (mark_kboards): ... from here.
a053e86c 7998
4752793e
PE
7999 * lisp.h (force_auto_save_soon): New decl.
8000
74f10ca7 8001 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8002 (DEFINE_DUMMY_FUNCTION): New macro.
8003 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8004 Use it.
c03cd23f
PE
8005 (main): Add casts to avoid warnings
8006 if GCC considers string literals to be constants.
74f10ca7 8007
022e70d4
PE
8008 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8009
59d6fe83
PE
8010 * dbusbind.c: Pointer signedness fixes.
8011 (xd_signature, xd_append_arg, xd_initialize):
8012 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8013 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8014 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8015 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8016
78320123
PE
8017 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8018 if GCC considers string literals to be constants.
49cebcca 8019 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8020
35ac2a97
SM
80212011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8022
fb103ca9
SM
8023 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8024 (print_preprocess, print_object): New macro to fix last change.
8025
35ac2a97
SM
8026 * print.c (print_preprocess): Don't forget font objects.
8027
62973b41
JB
80282011-03-16 Juanma Barranquero <lekktu@gmail.com>
8029
8030 * emacs.c (USAGE3): Doc fixes.
8031
0e48bb22
AS
80322011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8033
8034 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8035 structure.
8036
7684e57b
JB
80372011-03-14 Juanma Barranquero <lekktu@gmail.com>
8038
8039 * lisp.h (VWindow_system, Qfile_name_history):
8040 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8041 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8042 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8043
8044 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8045 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8046
8047 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8048 * w32console.c (detect_input_pending, read_input_pending)
8049 (encode_terminal_code):
8050 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8051 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8052 (w32_system_caret_y, Qfile_name_history):
8053 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8054 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8055 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8056 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8057 * w32proc.c (Qlocal, report_file_error):
8058 * w32term.c (Vwindow_system, updating_frame):
8059 * w32uniscribe.c (initialized, uniscribe_font_driver):
8060 Remove unneeded extern declarations.
8061
2aa46d6c
CY
80622011-03-14 Chong Yidong <cyd@stupidchicken.com>
8063
c96bbc66 8064 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8065
cffc6f3b
CY
80662011-03-13 Chong Yidong <cyd@stupidchicken.com>
8067
8068 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8069 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8070 These macros can no longer be used for assignment.
8071
44f230aa
SM
8072 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8073 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8074 (record_buffer_markers, fetch_buffer_markers): New functions for
8075 recording and fetching special buffer markers.
8076 (set_buffer_internal_1, set_buffer_temp): Use them.
8077
8078 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8079
8080 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8081
8082 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8083 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8084
8085 * xdisp.c (hscroll_window_tree):
8086 (reconsider_clip_changes): Use PT instead of BUF_PT.
8087
d251f04b
EZ
80882011-03-13 Eli Zaretskii <eliz@gnu.org>
8089
8090 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8091 $(EMACS_ROOT)/lib/intprops.h.
8092
f0c77cd1
PE
80932011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8094
3eca4629
PE
8095 Fix more problems found by GCC 4.5.2's static checks.
8096
7c86ee98
PE
8097 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8098 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8099 (xg_free_frame_widgets): Make it clear that a local variable is
8100 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8101 (gdk_window_get_screen): Make it clear that this macro is needed
8102 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8103 (int_gtk_range_get_value): New function, which avoids a diagnostic
8104 from gcc -Wbad-function-cast.
8105 (xg_set_toolkit_scroll_bar_thumb): Use it.
8106 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8107 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8108 (get_utf8_string, xg_get_file_with_chooser):
8109 Rename locals to avoid shadowing.
8110 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8111
41729b81
PE
8112 * xgselect.c (xg_select): Remove unused var.
8113
f0c77cd1
PE
8114 * image.c (four_corners_best): Mark locals as initialized.
8115 (gif_load): Initialize transparent_p to zero (Bug#8238).
8116 Mark another local as initialized.
ec6cf4c6 8117 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8118
ce0ad53d 8119 * image.c (clear_image_cache): Now static.
d5d5a617 8120 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8121 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8122 (x_edge_detection): Remove unnecessary cast that
8123 gcc -Wbad-function-cast diagnoses.
2037898d 8124 (gif_load): Fix pointer signedness.
6ae141d6
PE
8125 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8126 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8127
33383987 81282011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8129
d32df629
PE
8130 Improve quality of tests for time stamp overflow.
8131 For example, without this patch (encode-time 0 0 0 1 1
8132 1152921504606846976) returns the obviously-bogus value (-948597
8133 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8134 reports time overflow. See
8135 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8136 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8137 * editfns.c: Include limits.h and intprops.h.
8138 (TIME_T_MIN, TIME_T_MAX): New macros.
8139 (time_overflow): Move earlier, to before first use.
8140 (hi_time, lo_time): New functions, for an accurate test for
8141 out-of-range times.
8142 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8143 (Fget_internal_run_time): Don't assume time_t fits in int.
8144 (make_time): Use list2 instead of Fcons twice.
8145 (Fdecode_time): More accurate test for out-of-range times.
8146 (check_tm_member): New function.
8147 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8148 (lisp_time_argument): Don't rely on undefined left-shift and
8149 right-shift behavior when checking for time stamp overflow.
8be6f318 8150
fe31d94c
PE
8151 * editfns.c (time_overflow): New function, refactoring common code.
8152 (Fformat_time_string, Fdecode_time, Fencode_time):
8153 (Fcurrent_time_string): Use it.
8154
8be6f318
PE
8155 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8156 * dired.c (make_time): Move to ...
8157 * editfns.c (make_time): ... here.
8158 * systime.h: Note the move.
8159
09d9db2c 81602011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8161
126bc0dc
YM
8162 * fringe.c (update_window_fringes): Remove unused variables.
8163
c47cbdfd
YM
8164 * unexmacosx.c (copy_data_segment): Also copy __got section.
8165 (Bug#8223)
8166
7ac80be9
EZ
81672011-03-12 Eli Zaretskii <eliz@gnu.org>
8168
c96bbc66 8169 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8170 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8171 Constify `char *' arguments and their references according to
8172 prototypes in tparam.h.
8173
ecb0f94d 8174 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8175
7ac80be9
EZ
8176 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8177 Adapt all references accordingly.
8178
8179 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8180
ef1fd07e
TT
81812011-03-11 Tom Tromey <tromey@redhat.com>
8182
8183 * buffer.c (syms_of_buffer): Remove obsolete comment.
8184
7ef4b50c
EZ
81852011-03-11 Eli Zaretskii <eliz@gnu.org>
8186
8187 * termhooks.h (encode_terminal_code): Declare prototype.
8188
8189 * msdos.c (encode_terminal_code): Don't declare prototype.
8190
8191 * term.c (encode_terminal_code): Now external again, used by
8192 w32console.c and msdos.c.
8193
44f230aa
SM
8194 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8195 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8196
4b1ec863 81972011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8198
1714f52b 8199 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8200
4b1ec863
PE
8201 * fringe.c (update_window_fringes): Mark locals as initialized
8202 (Bug#8227).
8203 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8204
524c7aa6
PE
8205 * alloc.c (mark_fringe_data): Move decl from here ...
8206 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8207 to check its interface.
8208 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8209
a5c0af81 8210 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8211 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8212 (fontset_font): Mark local as initialized.
a9a06e0b 8213 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8214
b4716021
PE
8215 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8216
811e9bac 8217 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8218 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8219 (x_own_selection, Fx_disown_selection_internal): Rename locals
8220 to avoid shadowing.
8221 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8222
7e3ab302
PE
8223 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8224 so that the caller can use some name other than gcpro1.
8225 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8226 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8227 (Fx_backspace_delete_keys_p):
8228 Use them to avoid shadowing, and rename vars to avoid shadowing.
8229 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8230 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8231 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8232 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8233 Remove unused locals.
7e3ab302
PE
8234 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8235 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8236 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8237 macros.
f78faa98 8238
e2b13473
PE
8239 * xterm.h (x_mouse_leave): New decl.
8240
77f23912
PE
8241 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8242 Remove unused functions.
cdf4ba58
PE
8243 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8244 (x_calc_absolute_position): Now static.
7411c686 8245 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8246 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8247 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8248 unless they are used.
38d0b34a
PE
8249 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8250 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8251 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8252 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8253 (x_error_catcher, x_connection_closed, x_error_handler):
8254 (x_error_quitter, xembed_send_message, x_iconify_frame):
8255 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8256 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8257 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8258
44f230aa
SM
8259 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8260 Rename or move locals to avoid shadowing.
6b463e58 8261 (tty_defined_color, merge_face_heights): Now static.
5967d051 8262 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8263 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8264 does not deduce is never used uninitialized.
73719eba
PE
8265 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8266 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8267
426994c3 8268 * terminal.c (store_terminal_param): Now static.
5489860b 8269
032f1620 8270 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8271 (set_frame_menubar): Remove unused local.
d4323972 8272 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8273 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8274 since they might point to immutable storage.
281585b0
PE
8275 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8276 since it's unused otherwise.
032f1620 8277
367c19e5 8278 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8279 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8280 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8281 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8282 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8283 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8284 does not deduce are never used uninitialized.
70739cbe 8285
07b48fa9
PE
8286 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8287
8868a238 8288 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8289 * window.c (window_loop, size_window):
8290 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8291
7e5cf297 8292 * window.c (display_buffer): Now static.
d6550a9f
PE
8293 (size_window): Mark variables that gcc -Wuninitialized
8294 does not deduce are never used uninitialized.
a586633d
PE
8295 * window.h (check_all_windows): New decl, to forestall
8296 gcc -Wmissing-prototypes diagnostic.
5b555da1 8297 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8298
f6095868
PE
8299 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8300 shadowing.
8301 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8302 Include <limits.h>.
8303 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8304 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8305 (load_charset_map): Mark variables that gcc -Wuninitialized
8306 does not deduce are never used uninitialized.
53df7c11 8307 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8308
f38b440c
PE
8309 * coding.c (coding_set_source, coding_set_destination):
8310 Use "else { /* comment */ }" rather than "else /* comment */;"
8311 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8312 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8313 a block, when the outer 'i' will do.
8314 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8315 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8316 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8317 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8318 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8319 Rename locals to avoid shadowing.
8320 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8321 * coding.c (emacs_mule_char, encode_invocation_designation):
8322 Now static, since they're not used elsewhere.
413bb2db 8323 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8324 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8325 (decode_coding_emacs_mule): Mark variables that gcc
8326 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8327 (detect_coding_iso_2022): Initialize a local variable that might
8328 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8329 this initialization is needed. (Bug#8211)
5f58e762
PE
8330 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8331 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8332 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8333 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8334 Remove unused macros.
f38b440c 8335
232b38b9 8336 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8337 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8338 * character.c (string_count_byte8): Likewise.
232b38b9 8339
fb90da1b
PE
8340 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8341 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8342
fb93dbc2
PE
8343 * chartab.c (copy_sub_char_table): Now static, since it's not used
8344 elsewhere.
5c156ace
PE
8345 (sub_char_table_ref_and_range, char_table_ref_and_range):
8346 Rename locals to avoid shadowing.
bbcd0949 8347 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8348
7d3b3862 8349 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8350 (BIDI_BOB): Remove unused macro.
7d3b3862 8351
6be7d3da
PE
8352 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8353 deduce are never used uninitialized.
c2ed9c8b 8354 * term.c (encode_terminal_code): Likewise.
6be7d3da 8355
75f8807f 8356 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8357
50938595
PE
8358 * tparam.h: New file.
8359 * term.c, tparam.h: Include it.
8360 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8361 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8362 Move these decls to tparam.h, and make them agree with what
8363 is actually in tparam.c. The previous trick of using incompatible
8364 decls in different modules does not conform to the C standard.
8365 All callers of tparam changed to use tparam's actual API.
8366 * tparam.c (tparam1, tparam, tgoto):
8367 Use const pointers where appropriate.
8368
fbceeba2
PE
8369 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8370 * cm.h (struct cm): Likewise.
8371 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8372 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8373 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8374 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8375 (turn_on_face, init_tty): Likewise.
8376 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8377
7f3f1250
PE
8378 * term.c (term_mouse_position): Rename local to avoid shadowing.
8379
e6ca6543
PE
8380 * alloc.c (mark_ttys): Move decl from here ...
8381 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8382
c40f8d15
AS
83832011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8384
8385 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8386
cfe0661d
JB
83872011-03-09 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * search.c (compile_pattern_1): Remove argument regp, unused since
8390 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8391 (compile_pattern): Don't pass it.
8392
0afb4571
J
83932011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8394
8395 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8396 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8397 for ! HAVE_GTK3.
8398 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8399
8400 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8401
8402 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8403 gdk_window_get_screen, gdk_window_get_geometry,
8404 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8405 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8406 (xg_get_pixbuf_from_pixmap): New function.
8407 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8408 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8409 Call xg_get_pixbuf_from_pixmap instead of
8410 gdk_pixbuf_get_from_drawable.
8411 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8412 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8413 (xg_check_special_colors): Use GtkStyleContext and its functions
8414 for HAVE_GTK3.
8415 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8416 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8417 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8418 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8419 Call gtk_widget_get_preferred_size.
0afb4571
J
8420 (xg_frame_resized): gdk_window_get_geometry only takes 5
8421 parameters.
44f230aa
SM
8422 (xg_win_to_widget, xg_event_is_for_menubar):
8423 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8424 (xg_set_widget_bg): New function.
8425 (delete_cb): New function.
895009e1 8426 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8427 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8428 (xg_set_background_color): Call xg_set_widget_bg.
8429 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8430 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8431 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8432 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8433 if ! HAVE_GTK3.
8434 (update_frame_tool_bar): Call gtk_widget_hide.
8435 (xg_initialize): Use GDK_KEY_g.
8436
8437 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8438 if ! HAVE_GTK3
8439 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8440
8441 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8442 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8443 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8444
1c2cc4ef
JB
84452011-03-08 Juanma Barranquero <lekktu@gmail.com>
8446
8447 * w32xfns.c (select_palette): Check success of RealizePalette against
8448 GDI_ERROR, not zero.
8449
33383987 8450See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8451
8452;; Local Variables:
8453;; coding: utf-8
aac0c6e3
MR
8454;; End:
8455
33383987 8456 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8457
8458 This file is part of GNU Emacs.
8459
8460 GNU Emacs is free software: you can redistribute it and/or modify
8461 it under the terms of the GNU General Public License as published by
8462 the Free Software Foundation, either version 3 of the License, or
8463 (at your option) any later version.
8464
8465 GNU Emacs is distributed in the hope that it will be useful,
8466 but WITHOUT ANY WARRANTY; without even the implied warranty of
8467 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8468 GNU General Public License for more details.
8469
8470 You should have received a copy of the GNU General Public License
8471 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.