* alloc.c (allocate_string): Remove two redundant calls
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3fe6dd74
DA
12012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * alloc.c (allocate_string): Remove two redundant calls
4 to memset, add explicit initialization where appropriate.
5
1ba6038a
GM
62012-06-27 Glenn Morris <rgm@gnu.org>
7
8 * lisp.mk (lisp): Remove paths.elc.
9
c89926a5
CY
102012-06-27 Chong Yidong <cyd@gnu.org>
11
12 * doc.c (Fsubstitute_command_keys): Fix punctuation.
13
ed6b3510
JW
142012-06-26 John Wiegley <johnw@newartisans.com>
15
157e99e4
JW
16 * unexmacosx.c (copy_data_segment): Added two section names used
17 on Mac OS X Lion: __mod_init_func and __mod_term_func.
18
ed6b3510
JW
19 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
20 when building with Clang.
21
8edd4a2b
SM
222012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
23
24 * eval.c (Fapply): Allow calling it with a single argument.
25
f6f62d1b
EZ
262012-06-26 Eli Zaretskii <eliz@gnu.org>
27
28 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
29 _stricmp and _strnicmp.
30 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
31
62efea5e
DA
322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
33
34 * alloc.c (allocate_window): Zero out non-Lisp part of newly
35 allocated window.
36 (allocate_process): Likewise for new process.
8edd4a2b 37 (allocate_terminal): Change to use offsetof.
62efea5e
DA
38 (allocate_frame): Likewise.
39 * frame.c (make_frame): Omit redundant initialization.
40 * window.c (make_parent_window): Use memset.
41 (make_window): Omit redundant initialization.
42 * process.c (make_process): Omit redundant initialization.
43 * terminal.c (create_terminal): Likewise.
44
42997f4d
DA
452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
46
47 * term.c (delete_tty): Remove redundant call to memset.
48
1130ecfc
DA
492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
50
51 * alloc.c: Remove build_string.
52 * lisp.h: Define build_string as static inline. This provides
53 a better opportunity to optimize away calls to strlen when the
54 function is called with compile-time constant argument.
55 * image.c (imagemagick_error): Convert to build_string.
56 * w32proc.c (sys_spawnve): Likewise.
57 * xterm.c (x_term_init): Likewise.
58
cf38a720
PE
592012-06-26 Paul Eggert <eggert@cs.ucla.edu>
60
99027bdd
PE
61 Use sprintf return value instead of invoking strlen on result.
62 In the old days this wasn't portable, since some sprintf
63 implementations returned char *. But they died out years ago and
64 Emacs already assumes sprintf returns int.
65 Similarly for float_to_string.
66 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
67 * ccl.c (ccl_driver):
68 * character.c (string_escape_byte8):
69 * data.c (Fnumber_to_string):
70 * doprnt.c (doprnt):
71 * print.c (print_object):
72 * xdisp.c (message_dolog):
73 * xfns.c (syms_of_xfns):
74 Use sprintf or float_to_string result to avoid need to call strlen.
75 * data.c (Fnumber_to_string):
76 Use make_unibyte_string, since the string must be ASCII.
77 * lisp.h, print.c (float_to_string): Now returns int length.
78 * term.c (produce_glyphless_glyph):
79 Use sprintf result rather than recomputing it.
80
cf38a720
PE
81 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
82 * Makefile.in (ALL_CFLAGS):
83 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
84 * gmalloc.c, regex.c: Include <config.h> unconditionally.
85
3511c784
DA
862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
87
0a08eb21 88 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
89 strcasecmp if available.
90 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
91
fb7da12e
AS
922012-06-25 Andreas Schwab <schwab@linux-m68k.org>
93
94 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
95 Avoid comma operator.
96 * menu.c (push_submenu_start, push_submenu_end)
97 (push_left_right_boundary, push_menu_pane): Likewise.
98 * msdos.c (dos_rawgetc): Likewise.
99
afa2ffd8
DA
1002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
101
102 * xfns.c (xic_create_fontsetname): Remove redundant calls
103 to memset.
104
b3b4476b
PE
1052012-06-25 Paul Eggert <eggert@cs.ucla.edu>
106
4495ff38
PE
107 * gtkutil.c (get_utf8_string): Remove redundant assignment.
108 sprintf already null-terminates its output.
109
b3b4476b
PE
110 * xfns.c (x_window): Remove redundant cast.
111
b00876c9
DA
1122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
115 `const char *' to `char *' to avoid compiler warning.
116
d188e26b
PE
1172012-06-24 Paul Eggert <eggert@cs.ucla.edu>
118
885d1d74
PE
119 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
120 instead of truncating it to 63 (admittedly a generous limit).
121
d188e26b
PE
122 * process.c: Fix spelling and caps in comments.
123
e2f560b1
DN
1242012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
125
e86db54b 126 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
127 * sysdep.c (setpgrp): Remove definition, not used in this file.
128
7583a3a1
JB
1292012-06-24 Juanma Barranquero <lekktu@gmail.com>
130
131 * makefile.w32-in: Update dependencies.
132
696056c2
EZ
1332012-06-24 Eli Zaretskii <eliz@gnu.org>
134
135 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
136 (SYSTIME_H): Add nt/inc/sys/time.h.
137
138 * systime.h [WINDOWSNT]: Include sys/time.h.
139
140 * s/ms-w32.h (struct timespec): Definition moved from
141 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
142
845ca893
PE
1432012-06-24 Paul Eggert <eggert@cs.ucla.edu>
144
145 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
146 * buffer.h (buffer_slot_type_mismatch):
147 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
148 * eval.c (unwind_to_catch):
149 * image.c (my_png_error, my_error_exit):
150 * keyboard.c (quit_throw_to_read_char, user_error)
151 (Fexit_recursive_edit, Fabort_recursive_edit):
152 * lisp.h (die, args_out_of_range, args_out_of_range_3)
153 (wrong_type_argument, buffer_overflow, __executable_start)
154 (memory_full, buffer_memory_full, string_overflow, Fthrow)
155 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
156 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
157 (fatal):
158 (child_setup) [!DOS_NT]:
159 * lread.c (end_of_file_error, invalid_syntax):
160 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
161 * puresize.h (pure_write_error):
162 * search.c (matcher_overflow):
163 * sound.c (sound_perror, alsa_sound_perror):
164 * sysdep.c, syssignal.h (croak):
165 * term.c (maybe_fatal, vfatal):
166 * textprop.c (text_read_only):
167 * undo.c (user_error):
168 * unexmacosx.c (unexec_error):
169 * xterm.c (x_ins_del_lines, x_delete_glyphs):
170 Use _Noreturn rather than NO_RETURN.
171 No need for separate decl merely because of _Noreturn.
172 * sound.c (sound_warning, parse_sound):
173 Remove unnecessary forward decls.
174
f1dd8073
PE
1752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
176
177 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
178 * lisp.h (WAIT_READING_MAX): New macro.
179 * dispnew.c (Fsleep_for, sit_for):
180 * keyboard.c (kbd_buffer_get_event):
181 * process.c (Faccept_process_output):
182 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
183 This improves on the previous patch, which introduced a bug
184 when time_t is unsigned and as wide as intmax_t.
185 See <http://bugs.gnu.org/9000#51>.
186
b82c1755
EZ
1872012-06-23 Eli Zaretskii <eliz@gnu.org>
188
189 * dispnew.c (sit_for, Fsleep_for):
190 * keyboard.c (kbd_buffer_get_event):
191 * process.c (Faccept_process_output): Avoid compiler warnings when
192 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
193
ca300656
JB
1942012-06-23 Juanma Barranquero <lekktu@gmail.com>
195
049ec95b
JB
196 * makefile.w32-in: Update dependencies.
197
ca300656
JB
198 * w32.c (ltime): Add return type and declare static.
199 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
200
db7b8d06
PE
2012012-06-23 Paul Eggert <eggert@cs.ucla.edu>
202
203 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
204 Privately reported by Herbert J. Skuhra.
205 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
206 All uses changed.
207 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
208 not make_lisp_timeval, when the argument is of type EMACS_TIME.
209
0bd8297f
EZ
2102012-06-23 Eli Zaretskii <eliz@gnu.org>
211
96512555
EZ
212 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
213 last argument of make_unibyte_string.
214
0bd8297f
EZ
215 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
216 language ID in the event parameters.
217
218 * w32term.c (w32_read_socket): Put the new keyboard codepage into
219 event.code, not the obscure "character set ID".
220
63def6b6
CY
2212012-06-23 Chong Yidong <cyd@gnu.org>
222
223 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
224
e8a02204
EZ
2252012-06-23 Eli Zaretskii <eliz@gnu.org>
226
388cdec0
EZ
227 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
228 * w32.c (fdutimens): New function.
229
230 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
231
232 * s/ms-w32.h (pselect): Redirect to sys_select.
233
234 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
235
e8a02204
EZ
236 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
237 in the logic of incrementing and decrementing the value of
238 use_relocatable_buffers.
239
d054f3fb
PE
2402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
241
242 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
243 Privately reported by Herbert J. Skuhra.
244 [__FreeBSD__]: Remove "*/" typo after "#include".
245 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
246 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
247 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
248 Don't assume EMACS_TIME and struct timeval are the same type.
249
d35af63c
PE
2502012-06-22 Paul Eggert <eggert@cs.ucla.edu>
251
252 Support higher-resolution time stamps (Bug#9000).
253 The time stamps are only nanosecond-resolution at the C level,
254 since that's the best that any real-world system supports now.
255 But they are picosecond-resolution at the Lisp level, as that's
256 easy, and leaves room for future OS improvements.
257
258 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
259 (LIBES): Use it.
260
261 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
262 Don't get current time unless it's needed.
263
264 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
265 now provides it if it's absent.
266 (start_atimer): Port to higher-res time stamps.
267 Check for time stamp overflow. Don't get current time more
268 often than is needed.
269
270 * buffer.h (struct buffer): Buffer modtime now has high resolution.
271 Include systime.h, not time.h.
272 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
273
274 * dired.c: Include stat-time.h.
275 (Ffile-attributes): File times now have higher resolution.
276
277 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
278 (struct image): Timestamp now has higher resolution.
279
280 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
281 has at least microseconds now. All uses removed.
282 (update_frame, update_single_window, update_window, update_frame_1)
283 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
284
285 * editfns.c (time_overflow): Now extern.
286 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
287 (float-time, Fformat_time_string, Fcurrent_time_string)
288 (Fcurrent_time_zone): Accept and generate higher-resolution
289 time stamps.
290 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
291 (decode_time_components, lisp_seconds_argument): New functions.
292 (make_time): Now static.
293 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
294 Report an error if the time is invalid, rather than having the caller
295 do that.
296
297 * fileio.c: Include <stat-time.h>
298 (Fcopy_file): Copy higher-resolution time stamps.
299 Prefer to set the time stamp via a file descriptor if that works.
300 (Fset_file_times, Finsert_file_contents, Fwrite_region)
301 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
302 (Fvisited_file_modtime, Fset_visited_file_modtime):
303 Support higher-resolution time stamps.
304
305 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
306
307 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
308
309 * image.c (prepare_image_for_display, clear_image_cache)
310 (lookup_image): Port to higer-resolution time stamps.
311
312 * keyboard.c (start_polling, bind_polling_period):
313 Check for time stamp overflow.
314 (read_char, kbd_buffer_get_event, timer_start_idle)
315 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
316 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
317 Port to higher-resolution time stamps. Do not assume time_t is signed.
318 (decode_timer): New function. Timers are now vectors of length 9,
319 not 8, to accommodate the picosecond component.
320 (timer_check_2): Use it.
321
322 * nsterm.m (select_timeout, timeval_subtract): Remove.
323 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
324 as they're a bit more accurate and handle overflow better.
325 (ns_select): Change prototype to be compatible with pselect.
326 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
327 * nsterm.h (ns_select): Adjust prototype.
328
329 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
330 us-resolution time stamps.
331 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
332
333 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
334
335 * lisp.h (time_overflow): New decl.
336 (wait_reading_process_output): First arg is now intmax_t, not int,
337 to accommodate larger waits.
338
339 * process.h (struct Lisp_Process.read_output_delay):
340 Now counts nanoseconds, not microseconds.
341 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
342 EMACS_HAS_USECS.
343 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
344 (wait_reading_process_output):
345 Port to ns-resolution time stamps.
346 (Faccept_process_output, wait_reading_process_output):
347 Check for time stamp overflow. Do not assume time_t is signed.
348 (select_wrapper): Remove; we now use pselect.
349 (Fprocess_attributes): Now generates ns-resolution time stamps.
350
351 * sysdep.c: Include utimens.h. Don't include utime.h
352 or worry about struct utimbuf; gnulib does that for us now.
353 (gettimeofday): Remove; gnulib provides a substitute.
354 (make_timeval): New function.
355 (set_file_times): Now sets ns-resolution time stamps.
356 New arg FD; all uses changed.
357 (time_from_jiffies, ltime_from_jiffies, get_up_time)
358 (system_process_attributes):
359 Now returns ns-resolution time stamp. All uses changed.
360 Check for time stamp overflow.
361
362 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
363 provides a substitute now.
364
365 * systime.h: Include timespec.h rather than sys/time.h and time.h,
366 since it guarantees struct timespec.
367 (EMACS_TIME): Now struct timespec, so that we can support
368 ns-resolution time stamps.
369 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
370 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
371 (EMACS_USECS): Remove.
372 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
373 so multiply the arg by 1000 before storing it.
374 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
375 New macros.
376 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
377 Port to ns-resolution time stamps.
378 (EMACS_TIME_NEG_P): Remove; replaced by....
379 (EMACS_TIME_SIGN): New macro.
380 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
381 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
382 (set_file_times, make_time, lisp_time_argument): Adjust signature.
383 (make_timeval, make_lisp_time, decode_time_components): New decls.
384 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
385 that it mishandled time_t overflow. You can't compare by subtracting!
386 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
387 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
388
389 * term.c: Include <sys/time.h>.
390 (timeval_to_Time): New function, for proper overflow wraparound.
391 (term_mouse_position, term_mouse_click): Use it.
392
393 * undo.c (record_first_change): Support higher-resolution time stamps
394 in the undo buffer.
395 (Fprimitive_undo): Use them when restoring time stamps.
396
397 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
398 (w32_get_internal_run_time):
399 Port to higher-resolution Emacs time stamps.
400 (ltime): Now accepts single 64-bit integer, as that's more convenient
401 for callers.
402
403 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
404
405 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
406 for compatibility with pselect. Support ns-resolution time stamps.
407
408 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
409
410 * xselect.c (wait_for_property_change, x_get_foreign_selection):
411 Check for time stamp overflow, and support ns-resolution time stamps.
412
413 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
414 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
415 (timeval_subtract): Remove; no longer needed.
416 (XTflash, XTring_bell, x_wait_for_event):
417 Port to ns-resolution time stamps. Don't assume time_t is signed.
418
b6a92dfe
CY
4192012-06-22 Chong Yidong <cyd@gnu.org>
420
421 * xdisp.c (x_consider_frame_title): Revert last change.
422
d251c37c
EZ
4232012-06-22 Eli Zaretskii <eliz@gnu.org>
424
425 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
426 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
427 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
428 staticidx goes up to 1597 out of 1600 = 0x640.)
429
f10deafb
PE
4302012-06-20 Paul Eggert <eggert@cs.ucla.edu>
431
432 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
433 Otherwise, the umask might be mistakenly 0 while handling input signals.
434
ec6de1e2
SM
4352012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
436
437 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
438
28be1ada
DA
4392012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
440
441 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
442 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
443 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
444 access to `contents' member of Lisp_Vector objects with AREF and ASET
445 where appropriate.
446
c6bf3022
CY
4472012-06-19 Chong Yidong <cyd@gnu.org>
448
449 * frame.c (delete_frame): When selecting a frame on a different
450 text terminal, do not alter the terminal's top-frame.
451
452 * xdisp.c (format_mode_line_unwind_data): Record the target
453 frame's selected window and its terminal's top-frame.
454 (unwind_format_mode_line): Restore them.
455 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
456 Callers changed.
457 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
458 since tty frames can be explicitly named.
459 (prepare_menu_bars): Likewise.
460
461 * term.c (Ftty_top_frame): New function.
462
defd4196
PE
4632012-06-18 Paul Eggert <eggert@cs.ucla.edu>
464
465 Port byte-code-meter to modern targets.
466 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
467 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 468 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
469 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
470 (METER_1, METER_2): Simplify.
471
1053a871
SM
4722012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
473
474 * data.c (Fdefalias): Return `symbol' (bug#11686).
475
b7e8d081
MR
4762012-06-18 Martin Rudalics <rudalics@gmx.at>
477
478 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
479 gets killed during executing of this function (Bug#11665).
480 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
481 (Vkill_buffer_query_functions): In doc-string say that functions
482 run by this hook should not change the current buffer.
483
7ea2b339
PE
4842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
485
486 Fix recently-introduced process.c problems found by static checking.
487 * process.c (write_queue_push, write_queue_pop, send_process):
488 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
489 (write_queue_pop): Fix pointer signedness problem.
490 (send_process): Remove unused local.
491
96a313a1
CY
4922012-06-17 Chong Yidong <cyd@gnu.org>
493
494 * xdisp.c (redisplay_internal): No need to redisplay terminal
495 frames that are not on top.
496
20ca2e94
TN
4972012-06-17 Troels Nielsen <bn.troels@gmail.com>
498
499 * process.c (make_process): Initialize write_queue.
500 (write_queue_push, write_queue_pop): New functions.
501 (send_process): Use them to maintain correct ordering of process
502 writes (Bug#10815).
503
9a900ca9
PE
5042012-06-17 Paul Eggert <eggert@cs.ucla.edu>
505
310fbfa8
PE
506 * lisp.h (eassert): Assume C89 or later.
507 This removes the need for CHECK.
508 (CHECK): Remove. Its comments about always evaluating its
509 argument were confusing, as 'eassert' typically does not evaluate
510 its argument.
511
27bb1ca4
PE
512 * coding.c (produce_chars): Use ptrdiff_t, not int.
513
9a900ca9
PE
514 * xterm.c (x_draw_underwave): Check for integer overflow.
515 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
516
41b7f8bc 5172012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
518
519 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
520 referenced (Bug#11583).
521
9b0e3eba
AA
5222012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
523
524 Implement wave-style variant of underlining.
525 * dispextern.h (face_underline_type): New enum.
526 (face): Add field for underline type.
527 * nsterm.m (ns_draw_underwave): New function.
528 (ns_draw_text_decoration): Use it.
529 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
530 New functions.
531 (x_draw_glyph_string): Use them.
532 * xfaces.c (Qline, Qwave): New Lisp objects.
533 (check_lface_attrs, merge_face_ref)
1053a871
SM
534 (Finternal_set_lisp_face_attribute, realize_x_face):
535 Handle wave-style underline face attributes.
9b0e3eba
AA
536 * xterm.c (x_draw_underwave): New function.
537 (x_draw_glyph_string): Use it.
538
0fb52f11
JB
5392012-06-16 Juanma Barranquero <lekktu@gmail.com>
540
541 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
542 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
543 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
544 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
545 ($(BLD)/w32select.$(O)): Update dependencies.
546
e5560ff7
AS
5472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
548
549 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
550 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
551 * character.c (_fetch_multibyte_char_p): Remove.
552 * alloc.c: Include "character.h" before "buffer.h".
553 * bidi.c: Likewise.
554 * buffer.c: Likewise.
555 * bytecode.c: Likewise.
556 * callint.c: Likewise.
557 * callproc.c: Likewise.
558 * casefiddle.c: Likewise.
559 * casetab.c: Likewise.
560 * category.c: Likewise.
561 * cmds.c: Likewise.
562 * coding.c: Likewise.
563 * composite.c: Likewise.
564 * dired.c: Likewise.
565 * dispnew.c: Likewise.
566 * doc.c: Likewise.
567 * dosfns.c: Likewise.
568 * editfns.c: Likewise.
569 * emacs.c: Likewise.
570 * fileio.c: Likewise.
571 * filelock.c: Likewise.
572 * font.c: Likewise.
573 * fontset.c: Likewise.
574 * fringe.c: Likewise.
575 * indent.c: Likewise.
576 * insdel.c: Likewise.
577 * intervals.c: Likewise.
578 * keyboard.c: Likewise.
579 * keymap.c: Likewise.
580 * lread.c: Likewise.
581 * macros.c: Likewise.
582 * marker.c: Likewise.
583 * minibuf.c: Likewise.
584 * nsfns.m: Likewise.
585 * nsmenu.m: Likewise.
586 * print.c: Likewise.
587 * process.c: Likewise.
588 * regex.c: Likewise.
589 * region-cache.c: Likewise.
590 * search.c: Likewise.
591 * syntax.c: Likewise.
592 * term.c: Likewise.
593 * textprop.c: Likewise.
594 * undo.c: Likewise.
595 * unexsol.c: Likewise.
596 * w16select.c: Likewise.
597 * w32fns.c: Likewise.
598 * w32menu.c: Likewise.
599 * window.c: Likewise.
600 * xdisp.c: Likewise.
601 * xfns.c: Likewise.
602 * xmenu.c: Likewise.
603 * xml.c: Likewise.
604 * xselect.c: Likewise.
605
2f07e6af
EZ
6062012-06-16 Eli Zaretskii <eliz@gnu.org>
607
1053a871
SM
608 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
609 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 610 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
611 row.
612 (handle_face_prop): Use chunk-relative overlay string index when
613 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
614 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
615 the rightmost. (Bug#11720)
2f07e6af 616
29b83cec
AS
6172012-06-16 Andreas Schwab <schwab@linux-m68k.org>
618
619 * category.h (CHAR_HAS_CATEGORY): Define as inline.
620 (CATEGORY_MEMBER): Enforce 1/0 value.
621 * category.c (_temp_category_set): Remove.
622
4c5501e9
EZ
6232012-06-16 Eli Zaretskii <eliz@gnu.org>
624
625 * window.c (Fdelete_other_windows_internal)
626 (Fdelete_window_internal): Don't access frame's mouse highlight
627 info of the initial frame. (Bug#11677)
628
2b570124
PE
6292012-06-14 Paul Eggert <eggert@cs.ucla.edu>
630
e93864f9
PE
631 * .gdbinit (xgetint): Fix recently-introduced paren typo.
632 Assume USE_2_TAGS_FOR_INTS.
633 (xreload): Adjust $tagmask width to match recent lisp.h change.
634
2b570124
PE
635 Simplify lisp.h in minor ways that should not affect code.
636 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
637 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
638 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
639 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
640 (INTTYPEBITS): New macro, for clarity.
641 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
642 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
643 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
644 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
645 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
646
81755f69
JB
6472012-06-13 Juanma Barranquero <lekktu@gmail.com>
648
649 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
650
16192a57
GM
6512012-06-13 Glenn Morris <rgm@gnu.org>
652
653 * s/bsd-common.h (BSD4_3):
654 * s/usg5-4-common.h (USG5_4): No longer define; unused.
655
646b5f55
AS
6562012-06-13 Andreas Schwab <schwab@linux-m68k.org>
657
658 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
659 instead of union.
660 (XLI, XIL): Define.
1053a871
SM
661 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
662 Use them.
663 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 664 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 665 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
666 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
667 * frame.c (delete_frame): Remove outdated comment.
668 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
669 USE_LISP_UNION_TYPE.
670 (Fw32_unregister_hot_key): Likewise.
671 (Fw32_toggle_lock_key): Likewise.
672 * w32menu.c (add_menu_item): Likewise.
673 (w32_menu_display_help): Use XIL instead of checking
674 USE_LISP_UNION_TYPE.
675 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
676 (init_heap): Likewise.
677 * w32term.c (w32_read_socket): Update comment.
678
1d3823c9
GM
6792012-06-13 Glenn Morris <rgm@gnu.org>
680
c62ff706
GM
681 * s/usg5-4-common.h, src/s/unixware.h:
682 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
683
1d3823c9
GM
684 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
685
bfe3e0a2
PE
6862012-06-13 Paul Eggert <eggert@cs.ucla.edu>
687
688 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
689 * alloc.c (make_number) [!defined make_number]:
690 Remove, as lisp.h always defines this now.
691 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
692 (roundup_size): Verify that it is a power of 2.
693 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
694 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
695 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
696 -DUSE_LSB_TAG=0, to override the automatically-selected default.
697 USE_LSB_TAG now is always defined to be either 0 or 1.
698 All uses changed.
699 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
700 code works fine either way, and efficiency is not a concern here,
701 as the union type is for debugging, not for production.
702 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
703 Use an inline function on all platforms when using the union type,
704 since this is simpler and 'static inline' can be used portably
705 within Emacs now.
706 (LISP_INITIALLY_ZERO): New macro.
707 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
708 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
709
45fa9c0f
GM
7102012-06-12 Glenn Morris <rgm@gnu.org>
711
b4492cba
GM
712 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
713
714 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 715
45fa9c0f
GM
716 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
717 Move BROKEN_SIGIO to configure.
718
719 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
720 Move NO_TERMIO to configure.
721
0e25d334
CY
7222012-06-12 Chong Yidong <cyd@gnu.org>
723
724 * image.c (imagemagick_load_image): Use MagickFlattenImage if
725 MagickMergeImageLayers is undefined. Use pixel pusher loop if
726 MagickExportImagePixels is undefined.
727
43682bb6
PE
7282012-06-12 Paul Eggert <eggert@cs.ucla.edu>
729
730 * image.c (imagemagick_load_image): Remove unused label.
731
a9be7d2b
GM
7322012-06-11 Glenn Morris <rgm@gnu.org>
733
734 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
735 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
736 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
737 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
738
3017f87f
SM
7392012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
740
741 * alloc.c (make_byte_code): New function.
742 (Fmake_byte_code): Use it. Don't purify here.
743 * lread.c (read1): Use it as well to avoid extra allocation.
744
1b9b4cf4
CY
7452012-06-11 Chong Yidong <cyd@gnu.org>
746
747 * image.c (imagemagick_load_image): Implement transparency.
748
95988fcf
AS
7492012-06-10 Andreas Schwab <schwab@linux-m68k.org>
750
751 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
752 account for preceding backslashes. (Bug#11663)
753
cd4eb164
CY
7542012-06-09 Chong Yidong <cyd@gnu.org>
755
756 * term.c: Support italics in capable terminals (Bug#9652).
757 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
758 (turn_on_face): Output using TS_enter_italic_mode if available.
759 Don't handle unused blinking and alt-charset cases.
760 (turn_off_face): Handle italic case; discard unused tty_blinking_p
761 and tty_alt_charset_p cases.
762 (tty_capable_p, init_tty): Support italics.
763
764 * termchar.h (struct tty_display_info): Add field for italics.
765 Remove unused blink field.
766
767 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
768 Handle slant.
769
770 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
771 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
772 tty_alt_charset_p. Add tty_italic_p.
773
ff88beb8
MA
7742012-06-09 Michael Albinus <michael.albinus@gmx.de>
775
776 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
777 dbus_type_is_basic if available.
778 (xd_extract_signed, xd_extract_unsigned): Rename from
779 extract_signed and extract_unsigned, respectively. Adapt callers.
780
44286096
CY
7812012-06-09 Chong Yidong <cyd@gnu.org>
782
1682701f
CY
783 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
784
44286096
CY
785 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
786 case (Bug#9752).
787
d86feb17
PE
7882012-06-08 Paul Eggert <eggert@cs.ucla.edu>
789
790 * xdisp.c (vmessage): Treat frame message as multibyte.
791 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
792 would generate the diagnostic "Making \302\247 buffer-local while
793 let-bound!".
794
d5c20fe8
EZ
7952012-06-08 Eli Zaretskii <eliz@gnu.org>
796
797 * dispnew.c (showing_window_margins_p): Undo last change, which
798 was done due to an inadvertent commit.
799 (adjust_frame_glyphs_for_frame_redisplay): Do call
800 showing_window_margins_p.
801
513749ee
SM
8022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
803
804 * eval.c (Fmake_var_non_special): New primitive.
805 (syms_of_eval): Defsubr it.
806 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
807
d4a8f5c1
JB
8082012-06-08 Juanma Barranquero <lekktu@gmail.com>
809
810 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
811 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
812
8bbbc977
EZ
8132012-06-08 Eli Zaretskii <eliz@gnu.org>
814
815 * alloc.c (allocate_vectorlike): Fix last change.
816
f3372c87
DA
8172012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
818
819 Block-based vector allocation of small vectors.
820 * lisp.h (struct vectorlike_header): New field `nbytes',
821 adjust comment accordingly.
822 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
823 to denote vector blocks. Adjust users (live_vector_p,
824 mark_maybe_pointer, valid_lisp_object_p) accordingly.
825 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
826 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
827 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
828 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
829 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
830 (roundup_size): New constant.
831 (struct vector_block): New data type.
832 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 833 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
834 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
835 (sweep_vectors): New functions.
836 (allocate_vectorlike): Return `zero_vector' as the only vector of
837 0 items. Allocate new vector from block if vector size is less than
838 or equal to VBLOCK_BYTES_MAX.
839 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
840 (init_alloc_once): Add call to init_vectors.
841
4f18a4ed
SM
8422012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
845
86f158bc
PE
8462012-06-07 Paul Eggert <eggert@cs.ucla.edu>
847
848 * doprnt.c (doprnt): Truncate multibyte char correctly.
849 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
850 would mishandle a string argument "Xc" if X was a multibyte
851 character of length 2: it would truncate after X's first byte
852 rather than including all of X.
853
c5cfcbe0
CY
8542012-06-06 Chong Yidong <cyd@gnu.org>
855
856 * buffer.c (word_wrap): Doc fix.
857
c05cf390
PE
8582012-06-04 Paul Eggert <eggert@cs.ucla.edu>
859
860 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
861
0c3461de
GM
8622012-06-03 Glenn Morris <rgm@gnu.org>
863
864 * xdisp.c (tool-bar-style): Doc fix.
865
c71232db
UM
8662012-06-03 Ulrich Müller <ulm@gentoo.org>
867
868 * Makefile.in (PAXCTL): Define.
869 (temacs$(EXEEXT)): Disable memory randomization for the temacs
870 binary via PaX flags if the paxctl utility is available.
871 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
872 Restore PaX flags to their default. (Bug#11398)
873
383f7350
CY
8742012-06-03 Chong Yidong <cyd@gnu.org>
875
876 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
877 buffer (Bug#11226).
878
5f2c76c6
CY
8792012-06-03 Chong Yidong <cyd@gnu.org>
880
881 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
882 (note_mode_line_or_margin_highlight): If there is no help echo,
883 use mode-line-default-help-echo. Handle the case where the mouse
884 position is past the end of the mode line string.
885
886 * buffer.c (buffer_local_value_1): New function, split from
887 Fbuffer_local_value; can return Qunbound.
888 (Fbuffer_local_value): Use it.
889 (Vmode_line_format): Docstring tweaks.
890
773d47f6
PE
8912012-06-02 Paul Eggert <eggert@cs.ucla.edu>
892
893 * sysdep.c (system_process_attributes): Improve comment.
894
f2d6a3df
SM
8952012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
896
897 * keyboard.c: Export real-this-command to Elisp.
898 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
899 and DEFVAR it. Update all users.
900
63810350
PE
9012012-06-02 Paul Eggert <eggert@cs.ucla.edu>
902
7bd5c1f4
PE
903 * minibuf.c (Fassoc_string): Remove duplicate declaration.
904
63810350
PE
905 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
906 Convert pctcpu and pctmem to Lisp float properly.
907 Let the compiler fold better, as 100.0/0x8000 is exact.
908
a2821611
AS
9092012-06-02 Andreas Schwab <schwab@linux-m68k.org>
910
911 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
912 cons_block.
913
5fceba1d
PE
9142012-06-01 Paul Eggert <eggert@cs.ucla.edu>
915
916 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
917
c98ff5dd
DA
9182012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
919
920 For a 'struct window', replace some Lisp_Object fields to
921 bitfields where appropriate, remove unused fields.
922 * window.h (struct window): Remove unused 'last_mark_x' and
923 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
924 change it's type from Lisp_Object to bitfield.
925 Change type of 'force_start', 'optional_new_start',
926 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
927 fields from Lisp_Object to bitfield. Adjust users accordingly.
928
ca34e0be
PE
9292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
930
931 Pacify gcc -Wdouble-precision when using Xaw.
932 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
933 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
934 Use 'float' consistently, rather than 'float' in most places
935 and 'double' in a couple of places.
936
efc00ab1 9372012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
938
939 * xdisp.c (handle_stop): Detect whether we have overlay strings
940 loaded by testing it->current.overlay_string_index to be
941 non-negative, instead of checking whether n_overlay_strings is
942 positive. (Bug#11587)
943
efc00ab1 9442012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
945
946 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
947
948 * doc.c (Fsubstitute_command_keys): Doc fix.
949
efc00ab1 9502012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
951
952 * search.c (search_buffer): Remove calls to
953 r_alloc_inhibit_buffer_relocation, as it is now called by
954 maybe_unify_char, which was the cause of relocation of buffer text
955 in bug#11519.
956
efc00ab1 9572012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
958
959 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
960 for the duration of call to load_charset, to avoid problems with
961 callers of maybe_unify_char that access buffer text through C
962 pointers.
963
964 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
965 decrement the inhibition flag, instead of just setting or
966 resetting it.
967
ba93a187
PE
9682012-05-31 Paul Eggert <eggert@cs.ucla.edu>
969
970 Remove obsolete '#define static' cruft.
971 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
972 This #undef was "temporary" in 2000; it is no longer needed
973 now that '#define static' has gone away.
974 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
975 (gray_bitmap_bits): Remove; no longer needed.
976 All uses replaced with definiens.
977 * xterm.c: Include "bitmaps/gray.xbm".
978
9e4bf381
PE
9792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
980
981 Clean up __executable_start, monstartup when --enable-profiling.
982 The following changes affect the code only when profiling.
983 * dispnew.c (__executable_start): Rename from safe_bcopy.
984 Define only on platforms that need it.
985 * emacs.c: Include <sys/gmon.h> when profiling.
986 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
987 (__executable_start): Remove decl, since lisp.h does it now.
988 (safe_bcopy): Remove decl; no longer has that name.
989 (main): Coalesce #if into single bit of code, for simplicity.
990 Cast pointers to uintptr_t, since standard libraries want integers
991 and not pointers.
992 * lisp.h (__executable_start): New decl.
993
32d72c2f
GM
9942012-05-31 Glenn Morris <rgm@gnu.org>
995
996 * image.c (Fimagemagick_types): Doc fix.
997
baac5bc7
JM
9982012-05-30 Jim Meyering <meyering@redhat.com>
999
1000 * callproc.c (Fcall_process_region): Include directory component
1001 in mkstemp error message (Bug#11586).
1002
72cb32cf
PE
10032012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 * alloc.c, lisp.h (make_pure_vector): Now static.
1006
61b108cc
SM
10072012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1008
1009 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1010 Move to byte-run.el.
1011 (Fautoload): Do the hash-doc more carefully.
1012 * data.c (Fdefalias): Purify definition, except for keymaps.
1013 (Qdefun): Move from eval.c.
1014 * lisp.h (Qdefun): Remove.
1015 * lread.c (read1): Tiny simplification.
1016
471fe23d
TN
10172012-05-29 Troels Nielsen <bn.troels@gmail.com>
1018
934f3f58 1019 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1020 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1021 Bug#9642, but explicitly check that the buffer the overlay would
1022 be moved to is live and rearrange lines to make sure that errors
1023 will not put the overlay in an inconsistent state.
1024 (Fdelete_overlay): Cosmetics.
1025
85d0efd1
EZ
10262012-05-28 Eli Zaretskii <eliz@gnu.org>
1027
1028 * w32term.c (my_bring_window_to_top): New function.
1029 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1030 could be different from the original one.
1031 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1032 (Bug#11513)
1033
1034 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1035 by calling BringWindowToTop.
1036
1037 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1038 (WM_EMACS_END): Increase by one.
1039
da92a98c
PE
10402012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1041
1042 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1043 This avoids undefined behavior that might cause the eassert
1044 to not catch an out-of-range value.
1045
74d1f848
JB
10462012-05-28 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1049 Update dependencies.
1050
9e1a06fc
EZ
10512012-05-27 Eli Zaretskii <eliz@gnu.org>
1052
1053 * bidi.c (bidi_mirror_char): Fix last change.
1054
f3dd7312
AS
10552012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1056
1057 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1058 when referring to sectname field in printf format.
1059
81899c91
PE
10602012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1061
57b81a9f
PE
1062 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1063 Only r_alloc_inhibit_buffer_relocation needed to be added;
1064 the others were already declared.
1065
81899c91
PE
1066 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1067 before checking whether it's out of range. Put the check inside
1068 eassert. See
1069 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1070
33017faf 10712012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1072
1073 * callproc.c (Fcall_process): Restore a line that was accidentally
1074 commented out in the 2011-02-13 change (bug#11547).
1075
33017faf 10762012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1077
1078 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1079 defined on ralloc.c.
1080
1081 * buffer.c [REL_ALLOC]: Remove prototypes of
1082 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1083 they are now on lisp.h.
1084
1085 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1086
1087 * search.c (search_buffer): Use it to inhibit relocation of buffer
1088 text while re_search_2 is doing its job, because re_search_2 is
1089 passed C pointers to buffer text. (Bug#11519)
1090
23415acf
EZ
1091 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1092 Update value to 24.
1093
44e27368
EZ
1094 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1095 state after an additional call to move_it_in_display_line_to, keep
1096 the values of it->max_ascent and it->max_descent found for the
1097 entire line.
1098 (pos_visible_p): Revert the comparison against bottom_y to what it
1099 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1100 (Bug#11464)
1101
c1892f11
PE
11022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 Fix coding-related core dumps with gcc -ftrapv.
1105 The code was computing A - B, where A and B are pointers, and B is
1106 random garbage. This can lead to core dumps on platforms that
1107 have special pointer registers, and it also leads to core dumps on
1108 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1109 A - B only when B is initialized properly.
1110 * coding.c (coding_set_source, coding_set_destination): Return void.
1111 (coding_change_source, coding_change_destinations): New functions,
1112 with the old behaviors of coding_set_source and coding_set_destination.
1113 All callers that need an offset changed to use these new functions.
1114
eb7afdad
GM
11152012-05-26 Glenn Morris <rgm@gnu.org>
1116
1117 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1118
f12fdf02
EZ
11192012-05-26 Eli Zaretskii <eliz@gnu.org>
1120
53a63be6 1121 Extend mouse support on W32 text-mode console.
61b108cc
SM
1122 * xdisp.c (draw_row_with_mouse_face):
1123 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1124
eb3f6f01 1125 * w32console.c: Include window.h.
61b108cc
SM
1126 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1127 New functions.
eb3f6f01
EZ
1128 (initialize_w32_display): Initialize mouse-highlight data.
1129
53a63be6
EZ
1130 * w32inevt.c: Include termchar.h and window.h.
1131 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1132 moves, call note_mouse_highlight. If help_echo changed, call
1133 gen_help_event to produce help-echo message in the echo area.
1134 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1135 highlight info.
1136
4cfd81f6
PE
11372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * lread.c (read1): Simplify slightly to avoid an overflow warning
1140 with GCC 4.7.0 on x86-64.
1141
4446092a
EZ
11422012-05-26 Eli Zaretskii <eliz@gnu.org>
1143
1144 * bidi.c (bidi_mirror_char): Revert last change: an int is
1145 definitely wide enough here.
1146
42b2a986 11472012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1148
42b2a986 1149 Fix integer width and related bugs (Bug#9874).
eb106a49 1150 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1151 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1152 (string_bytes, check_sblock, allocate_string_data):
1153 (compact_small_strings, Fmake_bool_vector, make_string)
1154 (make_unibyte_string, make_multibyte_string)
1155 (make_string_from_bytes, make_specified_string)
1156 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1157 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1158 (mark_vectorlike):
1159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1160 (allocate_pseudovector):
1161 Use int, not EMACS_INT, where int is wide enough.
1162 (inhibit_garbage_collection, Fgarbage_collect):
1163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1164 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1165 int might not be wide enough.
1166 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1167 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1168 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1169 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1170 (bidi_level_of_next_char, bidi_move_to_visually_next):
1171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1172 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1173 (Fkill_buffer, Fset_buffer_major_mode)
1174 (advance_to_char_boundary, Fbuffer_swap_text)
1175 (Fset_buffer_multibyte, overlays_at, overlays_in)
1176 (overlay_touches_p, struct sortvec, record_overlay_string)
1177 (overlay_strings, recenter_overlay_lists)
1178 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1179 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1180 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1181 (Foverlay_recenter, last_overlay_modification_hooks_used)
1182 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1184 (validate_region): Omit unnecessary test for b <= e,
1185 since that's guaranteed by the previous test.
d311d28c
PE
1186 (adjust_overlays_for_delete): Avoid pos + length overflow.
1187 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1188 (report_overlay_modification):
1189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1190 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1191 Omit pointer cast, which isn't needed anyway, and doesn't work
1192 after the EMACS_INT -> ptrdiff_t change.
02481186 1193 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1194 * buffer.h: Adjust decls to match defn changes elsewhere.
1195 (struct buffer_text, struct buffer):
1196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1197 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1198 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1199 not int, to avoid needless 32-bit limit on 64-bit hosts.
1200 (exec_byte_code): Use tighter memory-full test, one that checks
1201 for alloca overflow. Don't compute the address of the object just
1202 before an array, as that's not portable. Use EMACS_INT, not
1203 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1204 * callint.c (Fcall_interactively):
1205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1206 * callproc.c (call_process_kill, Fcall_process):
1207 Don't assume pid_t fits into an Emacs fixnum.
1208 (call_process_cleanup, Fcall_process, child_setup):
1209 Don't assume pid_t fits into int.
1210 (call_process_cleanup, Fcall_process, delete_temp_file)
1211 (Fcall_process_region):
1212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1213 (Fcall_process): Simplify handling of volatile integers.
1214 Use int, not EMACS_INT, where int will do.
1215 * casefiddle.c (casify_object, casify_region, operate_on_word)
1216 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1218 (casify_object): Avoid integer overflow when overallocating buffer.
1219 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1220 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1221 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1222 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1223 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1224 integers are now checked earlier. All uses replaced with XINT.
1225 (ccl_driver):
1226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1227 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1228 (ccl_driver, Fregister_code_conversion_map):
1229 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1230 (resolve_symbol_ccl_program): Check that vector header is in range.
1231 Always copy the vector, so that we can check its contents reliably
1232 now rather than having to recheck each instruction as it's being
1233 executed. Check that vector words fit in 'int'.
1234 (ccl_get_compiled_code, Fregister_ccl_program)
1235 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1236 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1237 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1238 contents are in range.
1239 (Fccl_execute_on_string): Check that status is in range.
1240 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1241 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1242 Accept and return EMACS_INT, not int, because callers can pass values
1243 out of 'int' range.
1244 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1245 (multibyte_chars_in_text, parse_str_as_multibyte)
1246 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1247 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1248 (string_escape_byte8, Fget_byte):
1249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1250 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1251 avoid mishandling large integers.
1252 * character.h: Adjust decls to match defn changes elsewhere.
1253 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1254 (Ffind_charset_region):
1255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1256 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1257 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1258 Don't assume fixnum fits in int.
d311d28c
PE
1259 (load_charset_map_from_vector, Fmap_charset_chars):
1260 Remove now-unnecessary CHECK_NATNUMs.
1261 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1262 Don't rely on undefined behavior with signed left shift overflow.
1263 Don't assume unsigned int fits into fixnum, or that fixnum fits
1264 into unsigned int. Don't require max_code to be a valid fixnum;
1265 that's not true for gb10830 4-byte on a 32-bit host. Allow
1266 invalid_code to be a cons, for the same reason. Require code_offset
1267 to be a character. Avoid int overflow if max_char is close
1268 to INT_MAX.
1269 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1270 this is intended anyway and avoids some undefined behavior.
1271 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1272 INDEX_TO_CODE_POINT, as that's what it expects.
1273 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1274 * charset.h (DECODE_CHAR): Return int, not unsigned;
1275 this is what was intended anyway, and it avoids undefined behavior.
1276 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1277 integer-overflow issues.
1278 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1279 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1280 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1281 * chartab.c (Fmake_char_table, Fset_char_table_range)
1282 (uniprop_get_decoder, uniprop_get_encoder):
1283 Don't assume fixnum fits in int.
1284 * cmds.c (move_point): New function, that does the gist of
1285 Fforward_char and Fbackward_char, but does so while checking
1286 for integer overflow more accurately.
c96e5d6a 1287 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1288 (Fforward_line, Fend_of_line, internal_self_insert)
1289 (internal_self_insert):
1290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1291 Fix a FIXME, by checking for integer overflow when calculating
1292 target_clm and actual_clm.
1293 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1294 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1295 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1296 (coding_alloc_by_making_gap, alloc_destination)
1297 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1298 (encode_coding_utf_16, detect_coding_emacs_mule)
1299 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1300 (detect_coding_iso_2022, decode_coding_iso_2022)
1301 (encode_invocation_designation, encode_designation_at_bol)
1302 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1303 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1304 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1305 (encode_coding_ccl, encode_coding_raw_text)
1306 (detect_coding_charset, decode_coding_charset)
1307 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1308 (produce_composition, produce_charset, produce_annotation)
1309 (decode_coding, handle_composition_annotation)
1310 (handle_charset_annotation, consume_chars, decode_coding_gap)
1311 (decode_coding_object, encode_coding_object, detect_coding_system)
1312 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1313 (code_convert_region, code_convert_string)
8f50130c
PE
1314 (Fdefine_coding_system_internal)
1315 (coding_set_source, coding_set_destination):
d311d28c
PE
1316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1317 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1318 (Fdefine_coding_system_internal):
1319 Don't assume fixnums fit in int.
1320 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1321 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1322 (Funencodable_char_position, Fcheck_coding_systems_region)
1323 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1325 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1326 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1327 Don't access memory outside of the args array.
d311d28c 1328 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1329 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1330 result of ENCODE_CHAR.
d311d28c
PE
1331 * coding.h: Adjust decls to match defn changes elsewhere.
1332 (struct coding_system):
1333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1334 * composite.c (get_composition_id, find_composition)
1335 (run_composition_function, update_compositions)
1336 (compose_text, composition_gstring_put_cache)
1337 (composition_gstring_p, composition_gstring_width)
1338 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1339 (composition_compute_stop_pos, composition_reseat_it)
1340 (composition_update_it, struct position_record)
1341 (find_automatic_composition, composition_adjust_point)
1342 (Fcomposition_get_gstring, Ffind_composition_internal):
1343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1344 (update_compositions):
1345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1346 * composite.h: Adjust decls to match defn changes elsewhere.
1347 (struct composition):
1348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1349 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1350 Do not attempt to compute the address of the object just before a
1351 buffer; this is not portable.
1352 (Faref, Faset):
1353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1354 (Faset): Use int, not EMACS_INT, where int is wide enough.
1355 (Fstring_to_number): Don't assume fixnums fit in int.
1356 (Frem): Don't assume arg is nonnegative.
1357 * dbusbind.c (xd_append_arg): Check for integers out of range.
1358 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1359 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1360 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1361 (xd_get_connection_references): Return ptrdiff_t, not int.
1362 All uses changed.
1363 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1364 (xd_read_message_1):
1365 Use int, not unsigned, where the dbus API uses int.
1366 (Fdbus_message_internal): Don't overflow mtype.
1367 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1368 * dired.c (directory_files_internal, file_name_completion, scmp)
1369 (file_name_completion_stat):
1370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1371 (file_name_completion): Don't overflow matchcount.
1372 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1373 * dispextern.h: Adjust decls to match defn changes elsewhere.
1374 (struct text_pos, struct glyph, struct bidi_saved_info)
1375 (struct bidi_string_data, struct bidi_it, struct composition_it)
1376 (struct it):
1377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1378 (struct display_pos, struct composition_it, struct it):
1379 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1380 * dispnew.c (increment_matrix_positions)
1381 (increment_row_positions, mode_line_string)
1382 (marginal_area_string):
1383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1384 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1386 (duration_to_sec_usec): New function, to check for overflow better.
1387 (Fsleep_for, sit_for): Use it.
1388 * doc.c (get_doc_string, store_function_docstring):
1389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1390 (get_doc_string, Fsnarf_documentation):
1391 Use int, not EMACS_INT, where int is wide enough.
1392 (get_doc_string):
1393 Use SAFE_ALLOCA, not alloca.
1394 Check for overflow when converting EMACS_INT to off_t.
1395 * doprnt.c (doprnt):
1396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1397 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1398 Don't assume uid_t fits into fixnum.
1399 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1400 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1401 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1402 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1403 (general_insert_function)
1404 (Finsert_char, make_buffer_string, make_buffer_string_both)
1405 (update_buffer_properties, Fbuffer_substring)
1406 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1407 (Fsubst_char_in_region, check_translation)
1408 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1409 (transpose_markers, Ftranspose_regions):
1410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1411 (clip_to_bounds): Move to lisp.h as an inline function).
1412 (Fconstrain_to_field): Don't assume integers are nonnegative.
1413 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1414 (Fsubst_char_in_region, Fsave_restriction):
1415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1416 (Femacs_pid): Don't assume pid_t fits into fixnum.
1417 (lo_time): Use int, not EMACS_INT, when int suffices.
1418 (lisp_time_argument): Check for usec out of range.
1419 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1420 (Fuser_login_name, Fuser_full_name): Signal an error
1421 if a uid argument is out of range, rather than relying on
1422 undefined behavior.
c8d5c857
PE
1423 (Fformat_time_string): Remove now-unnecessary check.
1424 lisp_time_argument checks for out-of-range usec now.
243e0530 1425 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1426 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1427 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1428 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1429 (init_cmdargs, Fdump_emacs):
1430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1431 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1432 the bottom (typically) 32 bits of the fixnum.
1433 * eval.c (specpdl_size, call_debugger):
1434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1435 (when_entered_debugger, Fbacktrace_debug):
1436 Don't assume fixnum can fit in int.
1437 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1438 the object just before a buffer; this is not portable.
1439 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1440 (grow_specpdl, unbind_to):
1441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1442 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1443 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1444 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1445 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1446 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1449 (a_write, e_write):
1450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1451 (Fcopy_file, non_regular_nbytes, read_non_regular)
1452 (Finsert_file_contents):
1453 Use int, not EMACS_INT, where int is wide enough.
1454 (READ_BUF_SIZE): Verify that it fits in int.
1455 (Finsert_file_contents): Check that counts are in proper range,
1456 rather than assuming fixnums fit into ptrdiff_t etc.
1457 Don't assume fixnums fit into int.
125b3835 1458 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1459 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1460 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1461 (string_char_to_byte, string_byte_to_char)
1462 (string_make_multibyte, string_to_multibyte)
1463 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1464 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1465 (substring_both, Fdelete, internal_equal, Ffillarray)
1466 (Fclear_string, mapcar1)
1467 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1468 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1469 (larger_vector, make_hash_table, maybe_resize_hash_table)
1470 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1471 (Fmaphash, secure_hash):
1472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1473 (concat): Check for string index and length overflow.
1474 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1475 (Frequire):
1476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1477 (larger_vector): New API (vec, incr_min, size_max) replaces old
1478 one (vec, new_size, init). This catches size overflow.
1479 INIT was removed because it was always Qnil.
1480 All callers changed.
1481 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1482 the upper bound on a hash table index size.
1483 (make_hash_table, maybe_resize_hash_table): Use it.
1484 (secure_hash): Computer start_byte and end_byte only after
1485 they're known to be in ptrdiff_t range.
1486 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1487 (Ffont_get_glyphs, Ffont_at):
1488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1489 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1490 (Flist_fonts, Fopen_font):
1491 Don't assume fixnum can fit in int.
1492 (check_gstring): Don't assume index can fit in int.
1493 (font_match_p): Check that fixnum is a character, not a nonnegative
1494 fixnum, since the later code needs to stuff it into an int.
1495 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1496 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1497 conversion overflow issues.
1498 (Fopen_font): Check for integer out of range.
1499 (Ffont_get_glyphs): Don't assume index can fit in int.
1500 * font.h: Adjust decls to match defn changes elsewhere.
1501 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1502 integer overflow.
1503 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1504 printmax_t, where ptrdiff_t is wide enough.
1505 (Finternal_char_font):
1506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1507 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1508 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1509 (Fset_frame_position, x_set_frame_parameters)
1510 (x_set_line_spacing, x_set_border_width)
1511 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1512 Check that fixnums are in proper range for system types.
1513 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1515 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1516 Use SAFE_ALLOCA_LISP, not alloca.
1517 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1518 intptr_t is wide enough.
1519 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1520 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1521 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1522 Check for fixnum out of range.
1523 * ftfont.c (ftfont_list): Don't assume index fits in int.
1524 Check that fixnums are in proper range for system types.
1525 (ftfont_shape_by_flt):
1526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1527 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1529 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1530 Check that fixnums are in proper range for system types.
1531 * gnutls.h: Adjust decls to match defn changes elsewhere.
1532 * gtkutil.c (xg_dialog_run):
1533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1534 (update_frame_tool_bar):
1535 Check that fixnums are in proper range for system types.
1536 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1537 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1538 * indent.c (last_known_column, last_known_column_point):
1539 (current_column_bol_cache):
1540 (skip_invisible, current_column, check_display_width):
1541 (check_display_width, scan_for_column, current_column_1)
1542 (Findent_to, Fcurrent_indentation, position_indentation)
1543 (indented_beyond_p, Fmove_to_column, compute_motion):
1544 (Fcompute_motion, Fvertical_motion):
1545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1546 (last_known_column_modified): Use EMACS_INT, not int.
1547 (check_display_width):
1548 (Fcompute_motion):
1549 Check that fixnums and floats are in proper range for system types.
1550 (compute_motion): Don't assume index or fixnum fits in int.
1551 (compute_motion, Fcompute_motion):
1552 Use int, not EMACS_INT, when it is wide enough.
1553 (vmotion): Omit local var start_hpos that is always 0; that way
1554 we don't need to worry about overflow in expressions involving it.
1555 * indent.h: Adjust decls to match defn changes elsewhere.
1556 (struct position):
1557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1558 Use int, not EMACS_INT, where int is wide enough.
1559 Remove unused members ovstring_chars_done and tab_offset;
1560 all uses removed.
1561 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1562 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1563 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1564 (make_gap, copy_text, insert, insert_and_inherit)
1565 (insert_before_markers, insert_before_markers_and_inherit)
1566 (insert_1, count_combining_before, count_combining_after)
1567 (insert_1_both, insert_from_string)
1568 (insert_from_string_before_markers, insert_from_string_1)
1569 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1570 (adjust_after_replace, adjust_after_insert, replace_range)
1571 (replace_range_2, del_range, del_range_1, del_range_byte)
1572 (del_range_both, del_range_2, modify_region)
1573 (prepare_to_modify_buffer, signal_before_change)
1574 (signal_after_change, Fcombine_after_change_execute):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1576 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1577 (balance_an_interval, split_interval_right, split_interval_left)
1578 (find_interval, next_interval, update_interval)
1579 (adjust_intervals_for_insertion, delete_node, delete_interval)
1580 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1581 (static_offset_intervals, offset_intervals)
1582 (merge_interval_right, merge_interval_left, make_new_interval)
1583 (graft_intervals_into_buffer, temp_set_point_both)
1584 (temp_set_point, set_point, adjust_for_invis_intang)
1585 (set_point_both, move_if_not_intangible, get_property_and_range)
1586 (get_local_map, copy_intervals, copy_intervals_to_string)
1587 (compare_string_intervals, set_intervals_multibyte_1):
1588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1589 * intervals.h: Adjust decls to match defn changes elsewhere.
1590 (struct interval):
1591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1592 * keyboard.c (this_command_key_count, this_single_command_key_start)
1593 (before_command_key_count, before_command_echo_length, echo_now)
1594 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1595 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1596 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1597 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1599 (last_non_minibuf_size, last_point_position, echo_truncate)
1600 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1601 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1602 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1603 (stuff_buffered_input):
1604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1605 (last_auto_save, command_loop_1, read_char):
1606 Use EMACS_INT, not int, to avoid integer overflow.
1607 (record_char): Avoid overflow in total_keys computation.
1608 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1609 * keyboard.h: Adjust decls to match defn changes elsewhere.
1610 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1611 (Fkey_description, Fdescribe_vector, Flookup_key):
1612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1613 (click_position): New function, to check that positions are in range.
1614 (Fcurrent_active_maps):
1615 (describe_command):
1616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1617 (Faccessible_keymaps, Fkey_description):
1618 (preferred_sequence_p):
1619 Don't assume fixnum can fit into int.
1620 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1621 Check for integer overflow in size calculations.
1622 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1623 avoid mishandling large integers.
1624 * lisp.h: Adjust decls to match defn changes elsewhere.
1625 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1626 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1627 (struct Lisp_Marker):
1628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1629 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1630 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1631 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1632 All callers changed.
1633 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1634 Assume the arg has valid form, since it always does.
1635 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1636 unsigned integer system type.
1637 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1638 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1640 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1641 (duration_to_sec_usec): New decl.
1642 * lread.c (read_from_string_index, read_from_string_index_byte)
1643 (read_from_string_limit, readchar, unreadchar, openp)
1644 (read_internal_start, read1, oblookup):
1645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1646 (Fload, readevalloop, Feval_buffer, Feval_region):
1647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1648 (openp): Check for out-of-range argument to 'access'.
1649 (read1): Use int, not EMACS_INT, where int is wide enough.
1650 Don't assume fixnum fits into int.
6efdadfd 1651 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1652 (read_filtered_event): Use duration_to_sec_usec
1653 to do proper overflow checking on durations.
d311d28c
PE
1654 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1655 in size calculation.
1656 (Fexecute_kbd_macro):
1657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1658 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1659 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1660 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1661 (set_marker_both, set_marker_restricted_both, marker_position)
1662 (marker_byte_position, Fbuffer_has_markers_at):
1663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1664 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1665 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1666 It now merely ensures that the menu is large enough, without
1667 necessarily growing it, as this avoids some integer overflow issues.
1668 All callers changed.
1669 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1671 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1672 Use SAFE_ALLOCA_LISP, not alloca.
1673 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1674 to EMACS_INT. Check that fixnums are in proper range for system types.
1675 * minibuf.c (minibuf_prompt_width, string_to_object)
1676 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1677 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1679 (get_minibuffer, read_minibuf_unwind):
1680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1681 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1682 this simplifies overflow checking. All callers changed.
1683 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1684 (Ftest_completion):
1685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1686 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1687 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1688 Check that fixnums are in proper range for system types.
1689 (Fx_create_frame, Fx_show_tip):
1690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1691 * nsfont.m (ns_findfonts, nsfont_list_family):
1692 Don't assume fixnum fits in long.
1693 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1695 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1696 wide enough.
17fdb222 1697 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1699 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1700 (PRINTDECLARE, PRINTPREPARE):
1701 (strout, print_string):
1702 (print, print_preprocess, print_check_string_charset_prop)
1703 (print_object):
1704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1705 (PRINTDECLARE):
1706 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1708 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1709 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1710 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1711 (print_error_message): Use SAFE_ALLOCA, not alloca.
1712 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1713 (print_depth, new_backquote_output, print_number_index):
1714 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1715 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1716 (Fset_process_window_size, Fformat_network_address)
1717 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1718 (sigchld_handler):
d311d28c 1719 Check that fixnums are in proper range for system types.
d44287d4 1720 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1721 Check for process-ids out of pid_t range rather than relying on
1722 undefined behavior.
e4d81efc 1723 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1724 (Fformat_network_address, read_process_output, send_process)
1725 (Fprocess_send_region, status_notify):
1726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1727 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1728 (wait_reading_process_output, read_process_output, exec_sentinel):
1729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1730 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1731 (Faccept_process_output): Use duration_to_sec_usec to do proper
1732 overflow checking on durations.
dde14581
PE
1733 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1734 Don't assume pid_t fits in int.
02481186
PE
1735 * process.h (struct Lisp_Process): Members tick and update_tick
1736 are now of type EMACS_INT, not int.
b62b53e8
PE
1737 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1738 configured --with-wide-int.
d311d28c
PE
1739 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1740 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1741 * search.c (looking_at_1, string_match_1):
1742 (fast_string_match, fast_c_string_match_ignore_case)
1743 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1744 (scan_newline, find_before_next_newline, search_command)
1745 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1746 (set_search_regs, wordify):
1747 (Freplace_match):
1748 (Fmatch_data):
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1750 (string_match_1, search_buffer, set_search_regs):
1751 (Fmatch_data):
1752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1753 (wordify): Check for overflow in size calculation.
1754 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1755 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1756 Check that fixnums are in proper range for system types.
1757 * sound.c (struct sound_device)
1758 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1760 (Fplay_sound_internal):
1761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1762 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1763 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1764 (Fparse_partial_sexp):
1765 Don't assume fixnums can fit in int.
1766 (struct lisp_parse_state, find_start_pos, find_start_value)
1767 (find_start_value_byte, find_start_begv)
1768 (update_syntax_table, char_quoted, dec_bytepos)
1769 (find_defun_start, prev_char_comend_first, back_comment):
1770 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1771 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1773 (Finternal_describe_syntax_value): Check that match_lisp is a
1774 character, not an integer, since the code stuffs it into int.
1775 (scan_words, scan_sexps_forward):
1776 Check that fixnums are in proper range for system types.
1777 (Fforward_word):
1778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1779 (scan_sexps_forward):
1780 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1781 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1782 * syntax.h: Adjust decls to match defn changes elsewhere.
1783 (struct gl_state_s):
1784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1785 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1786 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1787 * sysdep.c (wait_for_termination_1, wait_for_termination)
1788 (interruptible_wait_for_termination, mkdir):
1789 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1790 (emacs_read, emacs_write):
1791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1792 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1793 and double all fit in int.
d311d28c
PE
1794 * term.c (set_tty_color_mode):
1795 Check that fixnums are in proper range for system types.
1796 * termhooks.h (struct input_event):
1797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1798 * textprop.c (validate_interval_range, interval_of)
1799 (Fadd_text_properties, set_text_properties_1)
1800 (Fremove_text_properties, Fremove_list_of_text_properties)
1801 (Ftext_property_any, Ftext_property_not_all)
1802 (copy_text_properties, text_property_list, extend_property_ranges)
1803 (verify_interval_modification):
1804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1805 (Fnext_single_char_property_change)
1806 (Fprevious_single_char_property_change):
1807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1808 (copy_text_properties):
1809 Check for integer overflow in index calculation.
d311d28c
PE
1810 * undo.c (last_boundary_position, record_point, record_insert)
1811 (record_delete, record_marker_adjustment, record_change)
1812 (record_property_change):
1813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1814 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1816 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1817 (Fx_hide_tip, Fx_file_dialog):
1818 * w32menu.c (set_frame_menubar):
1819 Use ptrdiff_t, not int, for consistency with rest of code.
1820 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1821 (select_window, Fdelete_other_windows_internal)
1822 (window_scroll_pixel_based, window_scroll_line_based)
1823 (Frecenter, Fset_window_configuration):
1824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1825 (Fset_window_hscroll, run_window_configuration_change_hook)
1826 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1827 (Fscroll_other_window, Frecenter):
d311d28c
PE
1828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1829 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1830 Don't assume fixnum fits in int.
1831 (Fset_window_scroll_bars):
1832 Check that fixnums are in proper range for system types.
1833 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1834 (string_pos, c_string_pos, number_of_chars, init_iterator)
1835 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1836 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1837 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1838 (face_before_or_after_it_pos, handle_invisible_prop)
1839 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1840 (display_prop_intangible_p, string_buffer_position_lim)
1841 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1842 (get_overlay_strings_1, get_overlay_strings)
1843 (iterate_out_of_display_property, forward_to_next_line_start)
1844 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1845 (get_next_display_element, set_iterator_to_next)
1846 (get_visually_first_element, compute_stop_pos_backwards)
1847 (handle_stop_backwards, next_element_from_buffer)
1848 (move_it_in_display_line_to, move_it_in_display_line)
1849 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1850 (add_to_log, message_dolog, message_log_check_duplicate)
1851 (message2, message2_nolog, message3, message3_nolog
1852 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1853 (current_message_1, truncate_echo_area, truncate_message_1)
1854 (set_message, set_message_1, store_mode_line_noprop)
1855 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1856 (text_outside_line_unchanged_p, check_point_in_composition)
1857 (reconsider_clip_changes)
1858 (redisplay_internal, set_cursor_from_row, try_scrolling)
1859 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1860 (redisplay_window, find_last_unchanged_at_beg_row)
1861 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1862 (trailing_whitespace_p, find_row_edges, display_line)
1863 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1864 (display_mode_element, store_mode_line_string)
1865 (pint2str, pint2hrstr, decode_mode_spec)
1866 (display_count_lines, display_string, draw_glyphs)
1867 (x_produce_glyphs, x_insert_glyphs)
1868 (rows_from_pos_range, mouse_face_from_buffer_pos)
1869 (fast_find_string_pos, mouse_face_from_string_pos)
1870 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1872 (safe_call, init_from_display_pos, handle_fontified_prop)
1873 (handle_single_display_spec, load_overlay_strings)
1874 (with_echo_area_buffer, setup_echo_area_for_printing)
1875 (display_echo_area, echo_area_display)
1876 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1877 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1878 (redisplay_window, dump_glyph_row, display_mode_line)
1879 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1880 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1882 (handle_single_display_spec, build_desired_tool_bar_string)
1883 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1884 (get_specified_cursor_type):
1885 Check that fixnums are in proper range for system types.
1886 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1887 (Flookup_image_map):
1888 Don't assume fixnums fit in int.
1889 (compare_overlay_entries):
1890 Avoid mishandling comparisons due to subtraction overflow.
1891 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1892 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1893 (handle_tool_bar_click):
1894 Use int, not unsigned, since we prefer signed and the signedness
1895 doesn't matter here.
1896 (get_next_display_element, next_element_from_display_vector):
1897 Use int, not EMACS_INT, when int is wide enough.
1898 (start_hourglass): Use duration_to_sec_usec to do proper
1899 overflow checking on durations.
1900 * xfaces.c (Fbitmap_spec_p):
1901 Check that fixnums are in proper range for system types.
1902 (compare_fonts_by_sort_order):
1903 Avoid mishandling comparisons due to subtraction overflow.
1904 (Fx_family_fonts, realize_basic_faces):
1905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1906 (Fx_family_fonts):
1907 Don't assume fixnum fits in int.
1908 Use SAFE_ALLOCA_LISP, not alloca.
1909 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1910 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1911 (face_at_buffer_position, face_for_overlay_string)
1912 (face_at_string_position):
1913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1914 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1915 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1916 (Fx_show_tip):
1917 Check that fixnums are in proper range for system types.
1918 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1919 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1921 (Fx_change_window_property): Don't assume fixnums fit in int.
1922 * xfont.c (xfont_chars_supported):
1923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1924 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1925 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1927 * xml.c (parse_region):
1928 * xrdb.c (magic_file_p):
1929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1930 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1931 (x_get_local_selection, x_reply_selection_request)
1932 (x_handle_selection_request, wait_for_property_change):
1933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1934 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1935 short is wide enough.
1936 (x_send_client_event): Don't assume fixnum fits in int.
1937 * xterm.c (x_x_to_emacs_modifiers):
1938 Don't assume EMACS_INT overflows nicely into int.
1939 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1940 may come from Lisp.
1941 (handle_one_xevent): NATNUMP can eval its arg twice.
1942 (x_connection_closed):
1943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1944 * xterm.h: Adjust decls to match defn changes elsewhere.
1945 (struct scroll_bar): Use struct vectorlike_header
1946 rather than rolling our own approximation.
1947 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1948
c6574eb5
GM
19492012-05-25 Glenn Morris <rgm@gnu.org>
1950
1951 * lisp.mk (lisp): Update for more files being compiled now.
1952
e8d32c7e
SM
19532012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1954
48def666
SM
1955 * lread.c: Remove `read_pure' which makes no difference.
1956 (read_pure): Remove var.
1957 (unreadpure): Remove function.
1958 (readevalloop): Don't call read_list with -1 flag.
1959 (read1, read_vector): Don't test read_pure any more.
1960 (read_list): Simplify.
1961
e8d32c7e
SM
1962 * fileio.c, character.h: Minor style tweaks.
1963
4b2addb7
DA
19642012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1965
1966 * window.h (clip_changed): Remove useless declaration.
1967
584461b2
JB
19682012-05-22 Juanma Barranquero <lekktu@gmail.com>
1969
1970 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1971 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1972
34374650
PE
19732012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1974
1975 Remove src/m/*.
1976 This directory predates autoconf and is no longer needed nowadays.
1977 Move its few remaining bits of functionality to where they're needed.
1978 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1979 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1980 * m/template.h: Remove.
1981 * Makefile.in (M_FILE): Remove. All uses removed.
1982 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1983 * lisp.h (USE_LSB_TAG):
1984 * mem-limits.h (EXCEEDS_LISP_PTR):
1985 Use VAL_MAX, not VALBITS, in #if.
1986 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1987 (EMACS_UINT): Define unconditionally now.
1988 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1989 (BITS_PER_EMACS_INT): New constants, replacing
1990 what used to be in config.h, but not useful in #if.
1991 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1992 define them any more.
1993 (VAL_MAX): New macro.
1994 (VALMASK): Use it.
1995 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1996 BITS_PER_EMACS_INT, in #if.
1997 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1998 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1999 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2000 * s/ms-w32.h (DATA_START):
2001 Move here from removed file m/intel386.h.
2002 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2003 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2004
261cb4bb
PE
20052012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2006
2007 Assume C89 or later.
2008 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2009 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2010 (xrealloc):
2011 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2012 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2013 * textprop.c, tparam.c (NULL): Remove.
2014 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2015 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2016 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2017 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2018 * xterm.c (input_signal_count): Assume volatile works.
2019
ff23cd9f
KB
20202012-05-21 Ken Brown <kbrown@cornell.edu>
2021
2022 * xgselect.c (xg_select): Fix first argument in call to 'select'
2023 (bug#11508).
2024
1b170bc6
KB
20252012-05-20 Ken Brown <kbrown@cornell.edu>
2026
2027 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2028 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2029
b2f4d39f
KB
20302012-05-19 Ken Brown <kbrown@cornell.edu>
2031
2032 * xfns.c (x_in_use): Remove `static' qualifier.
2033 * xterm.h (x_in_use): Declare.
2034 * xgselect.c: Include xterm.h.
2035 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2036 and `display_arg' (bug#9754).
2037
003fdae2
PE
20382012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2039
9232a6d9
PE
2040 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2041
003fdae2
PE
2042 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2043 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2044
784b56e2
EZ
20452012-05-18 Eli Zaretskii <eliz@gnu.org>
2046
2047 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2048
2049 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2050 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2051
2052 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2053 reference to image_cache->refcount.
2054 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2055
a0a79cde
JL
20562012-05-17 Juri Linkov <juri@jurta.org>
2057
2058 * search.c (Fword_search_regexp, Fword_search_backward)
2059 (Fword_search_forward, Fword_search_backward_lax)
2060 (Fword_search_forward_lax): Move functions to isearch.el
2061 (bug#10145, bug#11381).
2062
b0572523
PE
20632012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2066
9660f5fc
SM
20672012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2068
2069 * lread.c (init_obarray): Declare Qt and Qnil as special.
2070
4374de83
GM
20712012-05-14 Glenn Morris <rgm@gnu.org>
2072
2073 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2074 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2075
dc44c39a
PE
20762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2077
078c97cb
PE
2078 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2079
dc44c39a
PE
2080 * unexaix.c: Port to more-recent AIX compilers.
2081 (report_error, report_error_1, make_hdr, copy_sym)
2082 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2083 Make arguments const char *, not char *, to avoid violations of C
2084 standard and to fix some AIX warnings reported by Gilles Pion.
2085
e18afed7 20862012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2087
2088 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2089 already have overlays loaded.
2090 (handle_single_display_spec): Before returning without displaying
2091 fringe bitmap, synchronize the bidi iterator with the main display
2092 iterator, by calling iterate_out_of_display_property.
2093 (iterate_out_of_display_property): Detect buffer iteration by
2094 testing that it->string is a Lisp string.
2095 (get_next_display_element): When the current object is exhausted,
2096 and there's something on it->stack, call set_iterator_to_next to
2097 proceed with what's on the stack, instead of returning zero.
2098 (set_iterator_to_next): If called at the end of a Lisp string,
2099 proceed to consider_string_end without incrementing string
2100 position. Don't increment display vector index past the end of
2101 the display vector. (Bug#11417)
c8fb9dc6
EZ
2102 (pos_visible_p): Don't report a position visible when move_it_to
2103 stopped at the last line of window, which happens to be scanned
2104 backwards by the bidi iteration. (Bug#11464)
ac268e67 2105
e18afed7 21062012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2107
2108 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2109 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2110 are on a TTY, and thus unable to display on the fringes.
2111 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2112 so we need to signal to the caller that this is a "replacing"
2113 display spec. This fixes display when the spec is invalid or we
2114 are on a TTY.
2115
e18afed7 21162012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2117
2118 * unexaix.c (make_hdr): Fix typo in prototype.
2119 This bug broke the build on AIX. Problem reported by Gilles Pion.
2120
9d0a235a
MA
21212012-05-14 Michael Albinus <michael.albinus@gmx.de>
2122
2123 * keyboard.c (kbd_buffer_get_event): Read special events also in
2124 batch mode. (Bug#11415)
2125
9e6b06ed
GM
21262012-05-12 Glenn Morris <rgm@gnu.org>
2127
2128 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2129
c1a1d7a3
EZ
21302012-05-12 Eli Zaretskii <eliz@gnu.org>
2131
2132 * lisp.mk (lisp): Add newcomment.elc.
2133
3fe7cdc8
GM
21342012-05-12 Glenn Morris <rgm@gnu.org>
2135
2136 * Makefile.in (MKDIR_P): New, set by configure.
2137 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2138
53f7d2c0
PE
21392012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 Remove unused function hourglass_started.
2142 * dispextern.h (hourglass_started):
2143 * w32fns.c (hourglass_started):
2144 * xdisp.c (hourglass_started): Remove.
2145
75aafb17
JB
21462012-05-10 Juanma Barranquero <lekktu@gmail.com>
2147
2148 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2149 Update dependencies.
2150
12959e8e
PE
21512012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2152
97107e2e
PE
2153 * xgselect.c (xg_select): Put maxfds+1 into a var.
2154 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2155
12959e8e
PE
2156 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2157
836d29b3
DA
21582012-05-10 Dave Abrahams <dave@boostpro.com>
2159
2160 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2161 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2162
5cb67954
MA
21632012-05-09 Michael Albinus <michael.albinus@gmx.de>
2164
2165 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2166 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2167 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2168 Initialize xd_registered_buses.
2169
3478ec45
PE
21702012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2171
b263a6b0
PE
2172 Untag more efficiently if USE_LSB_TAG.
2173 This is based on a proposal by YAMAMOTO Mitsuharu in
2174 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2175 For an admittedly artificial (nth 8000 longlist) benchmark on
2176 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2177 Emacs's overall text size by 1%.
2178 * lisp.h (XUNTAG): New macro.
2179 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2180 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2181 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2182 * eval.c (Fautoload):
2183 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2184 * frame.h (XFRAME): Use XUNTAG.
2185
3478ec45
PE
2186 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2187 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2188 Remove unportable assumptions about print widths of types like
2189 dbus_uint32_t.
2190 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2191 intptr_t when converting between pointer and integer, to avoid GCC
2192 warnings about wrong width.
2193
666b903b 21942012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2195
2196 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2197 stack for each reader_thread, instead of defaulting to 8MB
2198 determined by the linker. This avoids failures in creating
2199 subprocesses on Windows 7, see the discussion in this thread:
2200 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2201
b120cc17
JC
22022012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2203
2204 Fix up display of the *Minibuf-0* buffer in the mini window.
2205 * keyboard.c (read_char): Don't clear the echo area if there's no
2206 message to clear.
2207 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2208 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2209
9a4b36f8
MA
22102012-05-07 Michael Albinus <michael.albinus@gmx.de>
2211
2212 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2213 batch mode.
2214
e5f9458f
CY
22152012-05-06 Chong Yidong <cyd@gnu.org>
2216
2217 * lisp.mk (lisp): Update.
2218
eceeb5fc 22192012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2220
2221 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2222
71873e2b
SM
22232012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2224
2225 * data.c (PUT_ERROR): New macro.
2226 (syms_of_data): Use it. Add new error type `user-error'.
2227 * undo.c (user_error): New function.
2228 (Fprimitive_undo): Use it.
2229 * print.c (print_error_message): Adjust print style for `user-error'.
2230 * keyboard.c (user_error): New function.
2231 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2232
ab0fa4e4
PE
22332012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 Do not limit current-time-string to years 1000..9999.
2236 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2237 (Fcurrent_time_string): Support any year that is supported by the
2238 underlying localtime representation. Don't use asctime, as it
2239 has undefined behavior for years outside the range -999..9999.
2240
7ed806a7
PE
22412012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 Fix race conditions involving setenv, gmtime, localtime, asctime.
2244 Without this fix, interrupts could mess up code that uses these
2245 nonreentrant functions, since setting TZ invalidates existing
2246 tm_zone or tzname values, and since most of these functions return
2247 pointers to static storage.
2248 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2249 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2250 Grow the critical sections to include not just invoking
2251 localtime/gmtime, but also accessing these functions' results
2252 including their tm_zone values if any, and any related TZ setting.
2253 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2254 so that the struct tm is saved in the critical section.
2255 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2256 motivated by the fact that memory allocation needs to be outside
2257 the critical section.
2258
0c16dfed
DA
22592012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2260
2261 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2262 with RESET_INTERVAL.
2263
2264 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2265 Remove duplicated buffer name initialization.
2266
3f83ace8
JM
22672012-05-02 Jim Meyering <jim@meyering.net>
2268
2269 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2270
c7b8541e
JM
2271 * xfns.c (x_window): Use xstrdup (Bug#11375).
2272
90207a15 22732012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2274
2275 * xdisp.c (pos_visible_p): If already at a newline from the
2276 display string before the 'while' loop, don't walk back the glyphs
2277 from it3.glyph_row. Solves assertion violation when the display
2278 string begins with a newline (egg.el). (Bug#11367)
2279
b593d6a9
AH
22802012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2281
2282 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2283 Move to simple.el.
2284
4737362e
GM
22852012-05-01 Glenn Morris <rgm@gnu.org>
2286
99cf43f9
GM
2287 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2288 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2289 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2290 All were removed before 23.1.
2291
9311dcff
GM
2292 * dispnew.c: Remove HAVE_LIBNCURSES test;
2293 it is always true on relevant platforms.
2294
4d5c6349
GM
2295 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2296 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2297
4737362e
GM
2298 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2299
74dd3a6b
AS
23002012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2301
2302 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2303 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2304 Remove.
2305
13c379ee
PE
23062012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2307
2308 Do not avoid creating empty evaporating overlays (Bug#9642).
2309 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2310 That is, do not delete an evaporating overlay if it becomes
2311 empty after its bounds are adjusted to fit within its buffer.
2312 This fix caused other problems, and I'm reverting it until we get
2313 to the bottom of them.
2314
a8e7d6d7 23152012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2316
2317 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2318
a8e7d6d7 23192012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2320
2321 * xdisp.c (pos_visible_p): If the window start position is beyond
2322 ZV, start the display from buffer beginning. Prevents assertion
2323 violation in init_iterator when the minibuffer window is scrolled
2324 via the scroll bar.
2325
2326 * window.c (window_scroll_pixel_based): Likewise.
2327
a8e7d6d7 23282012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2329
2330 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2331
a8e7d6d7 23322012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2333
2334 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2335 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2336
a8e7d6d7 23372012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2338
b593d6a9
AH
2339 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2340 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2341
1c6900d9
EZ
23422012-04-26 Eli Zaretskii <eliz@gnu.org>
2343
4c3fa1d9
EZ
2344 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2345 display element, check also the underlying string or buffer
2346 character. (Bug#11341)
2347
1c6900d9
EZ
2348 * w32menu.c: Include w32heap.h.
2349 (add_menu_item): If the call to AppendMenuW (via
2350 unicode_append_menu) fails, disable Unicode menus only if we are
2351 running on Windows 9X/Me.
2352
42bf8205
AS
23532012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2354
2355 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2356 (xgetint): Add missing shift for LSB tags.
2357
b1bac16e
MR
23582012-04-24 Martin Rudalics <rudalics@gmx.at>
2359
2360 * keyboard.c (read_char): Don't wipe echo area for select window
2361 events: These might get delayed via `mouse-autoselect-window'
2362 (Bug#11304).
2363
d69621cc
JB
23642012-04-24 Juanma Barranquero <lekktu@gmail.com>
2365
2366 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2367 manipulation of :loaded-from data.
2368
02fd101b
JB
23692012-04-23 Juanma Barranquero <lekktu@gmail.com>
2370
2371 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2372 now a cons (bug#11311).
2373
888bec30
PE
23742012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2375
89a438bd
PE
2376 Do not create empty overlays with the evaporate property (Bug#9642).
2377 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2378 if it becomes empty after its bounds are adjusted to fit within
2379 its buffer. Without this fix, in a nonempty buffer (let ((o
2380 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2381 yields an empty overlay that has the evaporate property, which is
2382 not supposed to happen.
2383
1068fe4d
PE
2384 Fix minor GTK3 problems found by static checking.
2385 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2386 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2387 (struct _EmacsFixedClass, emacs_fixed_get_type):
2388 Move decls here from emacsgtkfixed.h, since they needn't be public.
2389 (emacs_fixed_get_type): Now static.
2390 (emacs_fixed_class_init): Omit unused local.
2391 (emacs_fixed_child_type): Remove; unused.
2392 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2393 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2394 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2395 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2396 (EMACS_FIXED_GET_CLASS): Remove; unused.
2397 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2398
888bec30
PE
2399 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2400 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2401
de85e130
PE
24022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2403
d0baac98 2404 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2405 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2406 (__malloc_size_t, __malloc_ptrdiff_t):
2407 Remove. All uses removed, replaced by the definiens if needed,
2408 since we can assume C89 or better now.
2409 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2410 (protect_malloc_state, align, get_contiguous_space)
2411 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2412 (malloc_atfork_handler_child, malloc_enable_thread)
2413 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2414 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2415 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2416 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2417 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2418 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2419 Define using prototypes, not old style.
2420 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2421 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2422 (align): Don't assume that signed integer overflow wraps around.
2423 Omit unused local var.
2424 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2425 (_free_internal_nolock, memalign, mallochook, reallochook):
2426 Omit no-longer-needed casts.
2427 (valloc): Use getpagesize, not __getpagesize.
2428 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2429 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2430
de85e130
PE
2431 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2432
dcbf5805
MA
24332012-04-22 Michael Albinus <michael.albinus@gmx.de>
2434
2435 Move functions from C to Lisp. Make non-blocking method calls
2436 the default. Implement further D-Bus standard interfaces.
2437
2438 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2439 (QCdbus_request_name_allow_replacement)
2440 (QCdbus_request_name_replace_existing)
2441 (QCdbus_request_name_do_not_queue)
2442 (QCdbus_request_name_reply_primary_owner)
2443 (QCdbus_request_name_reply_in_queue)
2444 (QCdbus_request_name_reply_exists)
2445 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2446 (QCdbus_registered_serial, QCdbus_registered_method)
2447 (QCdbus_registered_signal): New Lisp objects.
2448 (XD_DEBUG_MESSAGE): Use sizeof.
2449 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2450 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2451 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2452 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2453 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2454 (xd_signature, xd_append_arg): Allow float for integer types.
2455 (xd_get_connection_references): New function.
b593d6a9
AH
2456 (xd_get_connection_address): Rename from xd_initialize.
2457 Return cached address.
dcbf5805
MA
2458 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2459 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2460 level.
2461 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2462 Return number of refcounts.
dcbf5805
MA
2463 (Fdbus_get_unique_name): Make stronger parameter check.
2464 (Fdbus_message_internal): New defun.
2465 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2466 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2467 (Fdbus_send_signal, Fdbus_register_service)
2468 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2469 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2470 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2471 (Vdbus_compiled_version, Vdbus_runtime_version)
2472 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2473 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2474 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2475 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2476 Adapt docstring.
dcbf5805 2477
52828e02
PE
24782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2479
da05bc4c
PE
2480 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2481 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2482 Do not assume ptrdiff_t is the same width as 'int'.
2483
52828e02
PE
2484 * alloc.c: Handle unusual debugging option combinations.
2485 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2486 since the two debugging options are incompatible.
2487 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2488 is defined.
2489 (mem_init, mem_insert, mem_insert_fixup):
2490 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2491 (NEED_MEM_INSERT): Remove; no longer needed.
2492
f01769f9
LL
24932012-04-22 Leo Liu <sdl.web@gmail.com>
2494
2495 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2496
5790543d
PE
24972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 * sysdep.c [__FreeBSD__]: Minor cleanups.
2500 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2501 Use Emacs indenting style more consistently. Avoid some casts.
2502 Use 'double' consistently rather than mixing 'float' and 'double'.
2503
b91b7e4d
EW
25042012-04-21 Eduard Wiebe <usenet@pusto.de>
2505
b593d6a9
AH
2506 * sysdep.c (list_system_processes, system_process_attributes):
2507 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2508
6114eb15
AS
25092012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2510
2511 * lisp.mk (lisp): Update.
2512
2f38dff7
PE
25132012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2514
2515 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2516 It is never used otherwise.
2517
4ae29f89
SM
25182012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2519
2520 * print.c (print_preprocess): Only check print_depth if print-circle
2521 is nil.
2522 (print_object): Check for cycles even when print-circle is nil and
2523 print-gensym is t, but only check print_depth if print-circle is nil.
2524
f30d612a
CY
25252012-04-20 Chong Yidong <cyd@gnu.org>
2526
2527 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2528 set the status to "failed" and ensure that sentinel is run.
2529
c07a4c0b 25302012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2531
2532 * process.c (Fset_process_inherit_coding_system_flag)
2533 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2534 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2535
c07a4c0b 25362012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2537
2538 * xdisp.c (string_buffer_position_lim): Limit starting position to
2539 BEGV.
2540 (set_cursor_from_row): If called for a mode-line or header-line
2541 row, return zero immediately.
2542 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2543 farther than the first row after the header line, if any.
2544 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2545 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2546
c07a4c0b 25472012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2548
4ae29f89
SM
2549 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2550 (bug#11238).
ad3a2b41 2551
c07a4c0b 25522012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 25532012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2554
2555 configure: new option --enable-gcc-warnings (Bug#11207)
2556 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2557 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2558 (ALL_CFLAGS): Use new macros rather than old.
2559 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2560 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2561 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2562 -Wunused-result, -Wunused-variable. This should go away once
2563 the Emacs and Gnulib regex code is merged.
2564 (xmalloc, xrealloc): Now static.
2565
aba027e8
PE
25662012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 * dired.c (Fsystem_groups): Remove unused local.
2569
e5a36063
GM
25702012-04-17 Glenn Morris <rgm@gnu.org>
2571
2572 * dired.c (Fsystem_users): Doc fix.
2573
316411f0
DA
25742012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2575
2576 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2577 (syms_of_dired): Add them.
2578
9426aba4
PE
25792012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2580
b62a57be
PE
2581 Fix minor alloc.c problems found by static checking.
2582 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2583 New extern decls, to avoid calling undeclared functions.
2584 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2585 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2586 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2587 (NEED_MEM_INSERT): New macro.
2588 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2589 Remove one incorrect comment and fix another.
b62a57be 2590
3539f31f
PE
2591 Fix minor ralloc.c problems found by static checking.
2592 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2593 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2594 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2595 (r_alloc_sbrk): Now static.
2596
a041960a
PE
2597 Improve ralloc.c interface checking.
2598 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2599 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2600 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2601 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2602 [REL_ALLOC]: ... to here, to check interface.
2603 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2604 Remove decls. This fixes an "It stinks!".
2605
9426aba4
PE
2606 * alloc.c (which_symbols): Fix alignment issue / type clash.
2607
d55c12ed
AS
26082012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2609
2610 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2611 (struct Lisp_Misc_Any): Likewise.
2612 (struct Lisp_Free): Likewise.
2613 * alloc.c (union aligned_Lisp_Symbol): Define.
2614 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2615 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2616 (union aligned_Lisp_Misc): Define.
2617 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2618 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2619 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2620
b948ce8b
PE
26212012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2624 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2625 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2626 * s/netbsd.h, s/sol2-6.h:
2627 Remove definition of GC_MARK_STACK, since the default now works.
2628 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2629 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2630 no longer the default.
2631 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2632
35dc09a1 26332012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2634
35dc09a1
GM
2635 * lread.c (lisp_file_lexically_bound_p):
2636 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2637
35dc09a1
GM
26382012-04-14 Eli Zaretskii <eliz@gnu.org>
2639
2640 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2641 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2642
26432012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2644
2645 * nsterm.m (constrainFrameRect): Always constrain when there is only
2646 one screen (Bug#10962).
2647
bcd86815
KB
26482012-04-13 Ken Brown <kbrown@cornell.edu>
2649
2650 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2651
c25df26e
RT
26522012-04-13 Reuben Thomas <rrt@sc3d.org>
2653
2654 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2655
0fc59f1e
DC
26562012-04-11 Daniel Colascione <dancol@dancol.org>
2657
2658 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2659 against is gone. It's better to use vfork now so that when Cygwin
2660 gains a new, working vfork, we use it automatically (bug#10398).
2661
de8c03dc
SM
26622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2663
2664 * window.c (save_window_save): Obey window-point-insertion-type.
2665
2f097256
GM
26662012-04-11 Glenn Morris <rgm@gnu.org>
2667
2668 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2669
453b951e
SM
26702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2671
2672 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2673
75f1671a 26742012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2675
2676 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2677 (force_quit_count): New var.
2678 (handle_interrupt): Use it.
2679
2a8ce227
JB
26802012-04-10 Juanma Barranquero <lekktu@gmail.com>
2681
2682 * w32.c (w32_delayed_load): Record the full path of the library
2683 being loaded (bug#10424).
2684
935396c0
GM
26852012-04-09 Glenn Morris <rgm@gnu.org>
2686
05920a43
GM
2687 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2688 not just in the obarray, before snarfing them. (Bug#11036)
2689
935396c0
GM
2690 * Makefile.in ($(leimdir)/leim-list.el):
2691 Pass EMACS rather than BUILT_EMACS.
2692
a18ecafa
TZ
26932012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2694
2695 * process.c (make_process):
2696 * process.h: Add integer `gnutls_handshakes_tried' member to
2697 process struct.
2698
6bbef4e5
JC
2699 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2700 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2701
2702 * gnutls.c (gnutls_log_function2i): Convenience log function.
2703 (emacs_gnutls_read): Use new log functions,
2704 `gnutls_handshakes_tried' process member, and
2705 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2706 attempts per process (connection).
2707
b4d3bc10
CY
27082012-04-09 Chong Yidong <cyd@gnu.org>
2709
2710 * eval.c (Fuser_variable_p, user_variable_p_eh)
2711 (lisp_indirect_variable): Functions deleted.
2712 (Fdefvar): Caller changed.
2713
2714 * callint.c (Finteractive, Fcall_interactively):
2715 * minibuf.c (Fread_variable): Callers changed.
2716
70f4d973
EZ
27172012-04-09 Eli Zaretskii <eliz@gnu.org>
2718
2719 * xdisp.c (set_cursor_from_row): If the display string appears in
2720 the buffer at position that is closer to point than the position
2721 after the display string, display the cursor on the first glyph of
2722 the display string. Fixes cursor display when a 'display' text
2723 property immediately follows invisible text. (Bug#11094)
2724
cb3c2e3e
PE
27252012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2726
2727 composite.c: use 'double' consistently
2728 * composite.c (get_composition_id): Use 'double' consistently
2729 instead of converting 'float' to 'double' and vice versa; this is
2730 easier to understand and avoids a GCC warning.
2731
fd06db5d
GM
27322012-04-09 Glenn Morris <rgm@gnu.org>
2733
50fe702a
GM
2734 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2735 preparation for dumping it with emacs. (Bug#4789)
2736 (leimdir): New variable.
2737 ($(leimdir)/leim-list.el): New rule.
2738 (emacs$(EXEEXT)): Depend on leim-list.el.
2739
fd06db5d
GM
2740 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2741 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2742 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2743
55c131ee
AS
27442012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2745
2746 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2747 proper alignment.
2748
9209588f
JB
27492012-04-07 Juanma Barranquero <lekktu@gmail.com>
2750
2751 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2752 Remove unused local variable.
2753
e3fb2efb
PE
27542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2757 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2758 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2759 objects, as mark_maybe_pointer will catch them otherwise.
2760 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2761 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2762
b5385551
PE
27632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2764
2765 Fix typo that broke non-Windows builds.
2766 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2767
9078ead6
EZ
27682012-04-07 Eli Zaretskii <eliz@gnu.org>
2769
2770 Support building on MS-Windows with libxml2.
2771
2772 * makefile.w32-in (OBJ2): Add xml.$(O).
2773 (GLOBAL_SOURCES): Add xml.c.
2774 ($(BLD)/xml.$(O)): New dependency list.
2775
2776 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2777 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2778 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2779 [!WINDOWSNT]: New macros.
2780 (init_libxml2_functions, libxml2_loaded_p): New functions.
2781 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2782 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2783 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2784 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2785 linked in).
6bbef4e5
JC
2786 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2787 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2788 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2789
2790 * emacs.c: Don't include libxml/parser.h.
2791 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2792 xmlCleanupParser directly.
2793
2794 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2795
3811fdf3
EZ
27962012-04-07 Eli Zaretskii <eliz@gnu.org>
2797
2798 * indent.c (Fvertical_motion): If there is a display string at
2799 point, use it.vpos to compute how many lines to backtrack after
2800 move_it_to point. (Bug#11133)
2801
2f8e16b2
EZ
28022012-04-06 Eli Zaretskii <eliz@gnu.org>
2803
2804 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2805 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2806 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2807 macros related to unification of CJK characters. For the details,
2808 see the discussion following the message here:
2809 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2810
3d439cd1
CY
28112012-04-04 Chong Yidong <cyd@gnu.org>
2812
2813 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2814
8bc53d00
EZ
28152012-04-01 Eli Zaretskii <eliz@gnu.org>
2816
2817 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2818 instead of alloca. (Bug#11138)
2819
3b0512a3
AS
28202012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2821
2822 * w32menu.c (is_simple_dialog): Properly check lisp types.
2823 (Bug#11141)
2824
8427ddd2
EZ
28252012-03-31 Eli Zaretskii <eliz@gnu.org>
2826
979022ef
EZ
2827 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2828 position we get to after a call to move_it_to fails the
2829 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2830 only if we wind up in a string from display property. (Bug#11063)
2831
a6b1c7cc
EZ
2832 * window.c (Fdelete_other_windows_internal): Invalidate the row
2833 and column information about mouse highlight, so that redisplay
2834 restores it after reallocating the glyph matrices. (Bug#7464)
2835
8427ddd2
EZ
2836 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2837 string comes from a `display' text property, use the buffer
2838 position of that property as if we actually saw that position in
2839 the row's glyphs.
697ba24b
EZ
2840 (move_it_by_lines): Remove the assertion that
2841 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2842 violated when there's a before-string at the beginning of a line.
2843 (Bug#11063)
8427ddd2 2844
65a0a738
EZ
28452012-03-30 Eli Zaretskii <eliz@gnu.org>
2846
2847 * xdisp.c (append_space_for_newline): If the default face was
2848 remapped, use the remapped face for the appended newline.
2849 (extend_face_to_end_of_line): Use the remapped default face for
2850 extending the face to the end of the line.
2851 (display_line): Call extend_face_to_end_of_line when the default
2852 face was remapped. (Bug#11068)
2853
581355cc
EZ
28542012-03-29 Eli Zaretskii <eliz@gnu.org>
2855
2856 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2857
e8fc049f
SM
28582012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2861
4fb9a543
GM
28622012-03-27 Glenn Morris <rgm@gnu.org>
2863
2864 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2865 Doc fixes.
2866
679910f1
KH
28672012-03-26 Kenichi Handa <handa@m17n.org>
2868
2869 * dispextern.h (struct glyph): Fix previous change. Change the
2870 bit length of glyphless.ch to 25 (Bug#11082).
2871
90d49b7f
CY
28722012-03-26 Chong Yidong <cyd@gnu.org>
2873
2874 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2875 (command_loop_1): Use it; inhibit selection update for
2876 handle-select-window too (Bug#8996).
2877
f514f6f0
FP
28782012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2879
e8fc049f 2880 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2881
bf43fa51
KH
28822012-03-25 Kenichi Handa <handa@m17n.org>
2883
2884 * dispextern.h (struct glyph): Change the bit length of
2885 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2886
8a0c01dd
EZ
28872012-03-24 Eli Zaretskii <eliz@gnu.org>
2888
2889 * s/ms-w32.h (tzname): Include time.h before redirecting to
2890 _tzname. Fixes the MSVC build. (Bug#9960)
2891
7d1c3a76
AS
28922012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2893
8ed79523
AS
2894 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2895 characters.
2896
7d1c3a76
AS
2897 * xterm.c (XTread_socket): Only modify handling_signal if
2898 !SYNC_INPUT. (Bug#11080)
2899
e99a9b8b
EZ
29002012-03-23 Eli Zaretskii <eliz@gnu.org>
2901
2902 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2903 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2904 when fetching a multibyte character consumes more bytes than
2905 CHAR_BYTES returns, due to unification of CJK characters in
2906 string_char. (Bug#11073)
2907
5063c0e1
TN
29082012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2909
2910 * process.c (wait_reading_process_output): Handle pty disconnect
2911 by refraining from sending oneself a SIGCHLD (bug#10933).
2912
9f851fbd
CY
29132012-03-22 Chong Yidong <cyd@gnu.org>
2914
2915 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2916
5063c0e1 2917 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2918 Mark string as coming from a prefix property.
2919 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2920 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2921
fb5b8aca
CY
29222012-03-21 Chong Yidong <cyd@gnu.org>
2923
2924 * xfaces.c (Vface_remapping_alist): Doc fix.
2925
62356a1b
EZ
29262012-03-20 Eli Zaretskii <eliz@gnu.org>
2927
2928 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2929 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2930 Doc fixes.
62356a1b 2931
025de85b
CY
29322012-03-20 Chong Yidong <cyd@gnu.org>
2933
2934 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2935 to reflect default non-nil value of redisplay-dont-pause.
2936
4827f94e
KH
29372012-03-19 Kenichi Handa <handa@m17n.org>
2938
2939 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2940 it fit in a valid range (Bug#11003).
2941
e50a24a2
EZ
29422012-03-18 Eli Zaretskii <eliz@gnu.org>
2943
2944 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2945 that is not from display property, accept the row as a "cursor
2946 row" if one of the string's character has a non-nil `cursor'
2947 property. Fixes cursor positioning when there are newlines in
2948 overlay strings, e.g. in icomplete.el. (Bug#11035)
2949
9af5ed87
PE
29502012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2953
d1f55f16
CY
29542012-03-12 Chong Yidong <cyd@gnu.org>
2955
2956 * eval.c (inhibit_lisp_code): Rename from
2957 inhibit_window_configuration_change_hook; move from window.c.
2958
2959 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2960 * window.c (run_window_configuration_change_hook)
2961 (syms_of_window): Callers changed.
2962
66c5eebd
CY
29632012-03-11 Chong Yidong <cyd@gnu.org>
2964
413df973
CY
2965 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2966
66c5eebd
CY
2967 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2968
1de11f56
CY
29692012-03-10 Chong Yidong <cyd@gnu.org>
2970
2971 * frame.c (other_visible_frames): Don't assume the selected frame
2972 is visible (Bug#10955).
2973
cae07000
SM
29742012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2975
2976 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2977
89c94350
JD
29782012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2979
2980 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2981 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2982 zero (Bug#10954).
2983
999dd333
GM
29842012-03-03 Glenn Morris <rgm@gnu.org>
2985
01a6dcc8 2986 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2987
de0100f2
EZ
29882012-03-02 Eli Zaretskii <eliz@gnu.org>
2989
2990 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2991 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2992 (redisplay_window, next_element_from_string): Fix typos in
2993 comments.
3e441275
EZ
2994 (redisplay_window): Pass to move_it_vertically the margin in
2995 pixels, not in screen lines.
de0100f2 2996
96a72ee9
GM
29972012-03-02 Glenn Morris <rgm@gnu.org>
2998
2999 * buffer.c (buffer-list-update-hook): Doc fix.
3000
312508d7
EZ
30012012-02-29 Eli Zaretskii <eliz@gnu.org>
3002
3003 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3004 push_it before setting up the iterator for the first overlay
3005 string, even if we have an empty string loaded.
3006 (next_overlay_string): If there's an empty string on the iterator
3007 stack, pop the stack. (Bug#10903)
3008
27f3c637
PE
30092012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3010
3011 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3012 Suggested by Stefan Monnier in
3013 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3014 * alloc.c (widen_to_Lisp_Object): New static function.
3015 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3016 and widening them to Lisp_Objects. This would work even if
3017 USE_LSB_TAG is defined and wide integers are used, which might
3018 happen in a future version of Emacs.
3019
3c9dfce6
CY
30202012-02-25 Chong Yidong <cyd@gnu.org>
3021
fa74b241
CY
3022 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3023 Doc fix.
3024
3c9dfce6
CY
3025 * xselect.c (Fx_selection_exists_p): Doc fix.
3026 (x_clipboard_manager_save_all): Print an informative message
3027 before saving to clipboard manager.
3028
9486df08
CY
30292012-02-24 Chong Yidong <cyd@gnu.org>
3030
3031 * keyboard.c (process_special_events): Handle all X selection
3032 requests in kbd_buffer, not just the next one (Bug#8869).
3033
f01d3321
CY
30342012-02-23 Chong Yidong <cyd@gnu.org>
3035
3036 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3037 call when setting menu-bar-lines and tool-bar-lines parameters.
3038 (unwind_create_frame_1): New helper function.
3039
3040 * window.c (inhibit_window_configuration_change_hook): New var.
3041 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3042 (syms_of_window): Initialize it.
f01d3321 3043
86b847b6
CY
30442012-02-22 Chong Yidong <cyd@gnu.org>
3045
3046 * xterm.c (x_draw_image_relief): Add missing type check for
3047 Vtool_bar_button_margin (Bug#10743).
3048
a59225b1
CY
30492012-02-21 Chong Yidong <cyd@gnu.org>
3050
3051 * fileio.c (Vfile_name_handler_alist): Doc fix.
3052
3053 * buffer.c (Fget_file_buffer): Protect against invalid file
3054 handler return value.
3055
310f5bd4
PE
30562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3057
cb3a28cc
PE
3058 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3059 when computing $valmask.
3060
310f5bd4
PE
3061 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3062 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3063 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3064 It's useless in that case, and it can cause problems on hosts
3065 that allocate halves of EMACS_INT values separately.
3066 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3067 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3068 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3069 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3070 it avoids undefined behavior on hosts where shifting right by more
3071 than the word width has undefined behavior.
3072
2375c96a
CY
30732012-02-19 Chong Yidong <cyd@gnu.org>
3074
3075 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3076 (Funhandled_file_name_directory, Ffile_name_as_directory)
3077 (Fdirectory_file_name, Fexpand_file_name)
3078 (Fsubstitute_in_file_name): Protect against invalid file handler
3079 return values (Bug#10845).
3080
3eb49e71
EZ
30812012-02-18 Eli Zaretskii <eliz@gnu.org>
3082
3083 * .gdbinit (pitx): Fix incorrect references to fields of the
3084 iterator stack.
3085
7b926f3f
CY
30862012-02-17 Chong Yidong <cyd@gnu.org>
3087
3088 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3089
11273115
PE
30902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3093 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3094
c3a70e2b
CY
30952012-02-15 Chong Yidong <cyd@gnu.org>
3096
3097 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3098 marked as special. Also, starting docstrings with * is obsolete.
3099
0ca43699
AS
31002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3101
3102 * gnutls.c (emacs_gnutls_write): Fix last change.
3103
2e8f3c56
LI
31042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3105
3106 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3107 send_process.
3108
af70074f
SM
31092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3110
3111 * keymap.c (Fsingle_key_description): Handle char ranges.
3112
95986d52
CY
31132012-02-12 Chong Yidong <cyd@gnu.org>
3114
afd83bd1
CY
3115 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3116 as that creates a dangerous corner case.
3117
95986d52
CY
3118 * window.c (Fdelete_window_internal): Invalidate the mouse
3119 highlight (Bug#9904).
3120
bd7da63e
GM
31212012-02-12 Glenn Morris <rgm@gnu.org>
3122
3123 * xselect.c (Fx_own_selection_internal)
3124 (Fx_get_selection_internal, Fx_disown_selection_internal)
3125 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3126 * nsselect.m (Fx_own_selection_internal)
3127 (Fx_disown_selection_internal, Fx_selection_exists_p)
3128 (Fx_selection_owner_p, Fx_get_selection_internal):
3129 Sync docs and argument specs with the xselect.c versions.
3130
77abcbc2
LI
31312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3132
3133 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3134
90b671e2
EZ
31352012-02-11 Eli Zaretskii <eliz@gnu.org>
3136
1c0ca0b7
EZ
3137 * w32select.c (Fx_selection_exists_p): Sync doc string and
3138 argument list with xselect.c. (Bug#10783)
3139
3140 * w16select.c (Fx_selection_exists_p): Sync doc string and
3141 argument list with xselect.c. (Bug#10783)
90b671e2 3142
49241268
GM
31432012-02-10 Glenn Morris <rgm@gnu.org>
3144
3145 * fns.c (Fsecure_hash): Doc fix.
3146
f998bbe7 31472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3148
3149 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3150
0992bd9c
CY
31512012-02-07 Chong Yidong <cyd@gnu.org>
3152
3153 * buffer.c (Fbuffer_local_variables)
3154 (buffer_lisp_local_variables): Handle unbound vars correctly;
3155 don't let Qunbound leak into Lisp.
3156
af008560
GM
31572012-02-07 Glenn Morris <rgm@gnu.org>
3158
dd605cc4
GM
3159 * image.c (Fimagemagick_types): Doc fix.
3160
af008560
GM
3161 * image.c (imagemagick-render-type): Change it from a lisp object
3162 to an integer. Move the doc here from the lisp manual.
3163 Treat all values not equal to 0 the same.
3164
1449fa1d
CY
31652012-02-06 Chong Yidong <cyd@gnu.org>
3166
3167 * doc.c (store_function_docstring): Avoid applying docstring of
3168 alias to base function (Bug#2603).
3169
3723ec07
AS
31702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3171
3172 * .gdbinit (pp1, pv1): Remove redundant defines.
3173 (pr): Use pp.
3174
79c1cc1e
CY
31752012-02-04 Chong Yidong <cyd@gnu.org>
3176
3177 * nsterm.m: Declare a global (Bug#10694).
3178
d7f29f8e
EZ
31792012-02-04 Eli Zaretskii <eliz@gnu.org>
3180
cae07000
SM
3181 * w32.c (get_emacs_configuration_options):
3182 Include --enable-checking, if specified, in the return value.
d7f29f8e 3183
3b95a6f9
MR
31842012-02-04 Martin Rudalics <rudalics@gmx.at>
3185
3186 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3187 after rounding frame sizes. (Bug#9723)
3188
d6fa96a6
EZ
31892012-02-04 Eli Zaretskii <eliz@gnu.org>
3190
3191 * keyboard.c (adjust_point_for_property): Don't position point
3192 before BEGV. (Bug#10696)
3193
df0b2940
PE
31942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 Handle overflow when computing char display width (Bug#9496).
3197 * character.c (char_width): Return EMACS_INT, not int.
3198 (char_width, c_string_width): Check for overflow when
3199 computing the width; this is possible now that individual
3200 characters can have unbounded width. Problem introduced
3201 by merge from Emacs 23 on 2012-01-19.
3202
6bee44d6
MA
32032012-02-02 Michael Albinus <michael.albinus@gmx.de>
3204
3205 * dbusbind.c (Fdbus_register_method): Mention the return value
3206 :ignore in the docstring.
3207
44f92739
GM
32082012-02-02 Glenn Morris <rgm@gnu.org>
3209
1b9f60cc
GM
3210 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3211
44f92739
GM
3212 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3213 Unconditionally set to t. (Bug#10673)
3214 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3215 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3216 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3217
c5d3843c
KH
32182012-02-02 Kenichi Handa <handa@m17n.org>
3219
3220 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3221 0, do not call append_composite_glyph.
3222
159462d4 32232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3224
3225 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3226 NULL (Bug#6988).
3227 (x_produce_glyphs): If the component of a composition is a null
3228 string, set it->pixel_width to 1 to avoid zero-width glyph.
3229
78cef877
EZ
32302012-02-01 Eli Zaretskii <eliz@gnu.org>
3231
3232 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3233 first 2 arguments are identical. This makes inserting large
3234 output from a subprocess an order of magnitude faster on
3235 MS-Windows, where all sbrk'ed memory is always contiguous.
3236
97897668
GM
32372012-01-31 Glenn Morris <rgm@gnu.org>
3238
3239 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3240 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3241 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3242
31fd3586
GM
32432012-01-29 Glenn Morris <rgm@gnu.org>
3244
3245 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3246
0e24a8b2
CY
32472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3248
3249 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3250
cc0adcb0
CY
32512012-01-28 Chong Yidong <cyd@gnu.org>
3252
3253 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3254
acc28cb9
CY
32552012-01-26 Chong Yidong <cyd@gnu.org>
3256
9c69cfb7
CY
3257 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3258
acc28cb9
CY
3259 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3260 repeat counts (Bug#10507).
3261
48da7392
GM
32622012-01-26 Glenn Morris <rgm@gnu.org>
3263
3264 * lread.c (syms_of_lread): Doc fix.
3265
14af5f7f
CY
32662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3267
3268 * coding.c (encode_designation_at_bol): Change return value to
3269 EMACS_INT.
3270
0b21c100
CY
32712012-01-25 Chong Yidong <cyd@gnu.org>
3272
3273 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3274
3c2907f7
CY
32752012-01-21 Chong Yidong <cyd@gnu.org>
3276
3277 * floatfns.c (Fcopysign): Make the second argument non-optional,
3278 since nil is not allowed anyway.
3279
959ad23f
AS
32802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3281
3282 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3283 (send_process): Likewise.
3284
34a02f46
MR
32852012-01-19 Martin Rudalics <rudalics@gmx.at>
3286
3287 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3288 (Vwindow_persistent_parameters): Do not use Qstate.
3289 Rewrite doc-strings.
34a02f46 3290
1259009a 32912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3292
3293 * character.c (char_width): New function.
70d4fdf6
GM
3294 (Fchar_width, c_string_width, lisp_string_width):
3295 Use char_width (Bug#9496).
25ed9e61 3296
6a6ee00d
MR
32972012-01-16 Martin Rudalics <rudalics@gmx.at>
3298
3299 * window.c (Vwindow_persistent_parameters): New variable.
3300 (Fset_window_configuration, save_window_save): Handle persistent
3301 window parameters.
3302
c85efaf7
EZ
33032012-01-14 Eli Zaretskii <eliz@gnu.org>
3304
3305 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3306 thrashing the stack of the thread. (Bug#9087)
3307
5944709e
PE
33082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3311
e71f5d99
EZ
33122012-01-11 Eli Zaretskii <eliz@gnu.org>
3313
3314 * xdisp.c (rows_from_pos_range): Handle the case where the
3315 highlight ends on a newline. (Bug#10464)
3316 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3317 he end column for display of highlight that ends on a newline
3318 before a R2L line.
3319
ce316182
GM
33202012-01-11 Glenn Morris <rgm@gnu.org>
3321
3322 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3323 from load-path also when installation-directory is nil. (Bug#10208)
3324
5b43da69
GM
33252012-01-10 Glenn Morris <rgm@gnu.org>
3326
74cc8ff9
GM
3327 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3328
7d8d6e4e
GM
3329 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3330 Update template values to be closer to their typical values these days.
5b43da69 3331
a0db8d43
EZ
33322012-01-09 Eli Zaretskii <eliz@gnu.org>
3333
3334 * xdisp.c (rows_from_pos_range): Accept additional argument
3335 DISP_STRING, and accept any glyph in a row whose object is that
3336 string as eligible for mouse highlight. Fixes mouse highlight of
3337 display strings from overlays. (Bug#10464)
3338
9a0115ab 33392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3340
b9110d6a 3341 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3342 * fileio.c (auto_saving_dir_umask): New static var.
3343 (Fmake_directory_internal): Use it.
3344 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3345 creating the directory. The old code temporarily assigns
3346 too-generous permissions to the directory.
3347 (do_auto_save_eh): Clear it.
b9110d6a 3348 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3349 that the var is always cleared.
3350
6c1bd3f3
EZ
33512012-01-07 Eli Zaretskii <eliz@gnu.org>
3352
3353 * search.c (scan_buffer): Pass character positions to
3354 know_region_cache, not byte positions. (Bug#6540)
3355
069d2b50
L
33562012-01-07 LynX <_LynX@bk.ru> (tiny change)
3357
3358 * w32.c (sys_rename): Report EXDEV when rename of a directory
3359 fails because the target is on another logical disk. (Bug#10284)
3360
75bf0d33
DB
33612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3362
3363 * xterm.c (x_embed_request_focus): New function.
3364
3365 * xterm.h: Add prototype.
3366
3367 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3368
1c6e5a32
GM
33692012-01-05 Glenn Morris <rgm@gnu.org>
3370
3371 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3372
651e947e
EZ
33732012-01-01 Eli Zaretskii <eliz@gnu.org>
3374
3375 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3376 Load gnutls_transport_set_lowat only if GnuTLS version is below
3377 2.11.1.
3378 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3379 GnuTLS versions below 2.11.1.
3380
3778cdd8
AL
33812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3382
3383 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3384 to the doc string advising against its use for altering the way
3385 windows are scrolled.
3386
0e5317f7
KH
33872011-12-28 Kenichi Handa <handa@m17n.org>
3388
3389 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3390 coding-system ASCII compatible only when it does not produce BOM
3391 on encoding (Bug#10383).
3392
93d5ca1f
JD
33932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3394
3395 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3396 can scroll.
3397 (create_and_show_popup_menu): Always use menu_position_func for
3398 Gtk3 (Bug#10361).
3399
ca22b785
AS
34002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3401
3402 * callint.c (Fcall_interactively): Don't truncate prompt string.
3403
d048e1e6
EZ
34042011-12-23 Eli Zaretskii <eliz@gnu.org>
3405
3406 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3407 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3408 resumed from there (after widening). (Bug#10360)
d048e1e6 3409
5ccaba1f
JD
34102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3411
3412 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3413
204ee57f
JD
34142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3415
b81d40f0
JB
3416 * nsterm.m (x_free_frame_resources):
3417 Release f->output_data.ns->miniimage.
204ee57f
JD
3418 (ns_index_color): Fix indentation. Do not retain
3419 color_table->colors[i].
3420
3421 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3422 before returning.
3423
3424 * nsfns.m (x_set_background_color): Assign return value from
3425 ns_index_color to face-background instead of NSColor*.
3426 (ns_implicitly_set_icon_type): Fix indentation.
3427 Change assignment in for loop to comparison.
3428
3429 * emacs.c (ns_pool): New variable.
3430 (main): Assign ns_pool.
3431 (Fkill_emacs): Call ns_release_autorelease_pool.
3432
3433 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3434 autorelease fdesc, release fdAttrs and tdict.
3435 (ns_get_covering_families): Release charset.
3436 (ns_findfonts): Release NSFontDescriptor created with new.
3437 (ns_uni_to_glyphs): Fix indentation.
3438 (setString): Release attrStr before assigning new value.
3439
c803b2b7
JD
34402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3441
678f4426
JD
3442 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3443 and NS_IMPL_COCOA.
3444 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3445 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3446
cd394be1 34472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3448
5fecd5fc
JD
3449 * nsterm.m (ns_term_init): Subscribe for notifications
3450 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3451 to method trackingNotification in EmacsMenu.
3452
3453 * nsmenu.m (trackingMenu): New variable.
3771cb17 3454 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3455 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3456 from Aquamacs (Bug#7030).
678f4426
JD
3457
34582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3459
c803b2b7
JD
3460 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3461 (symbol_to_nsstring): Fix indentation.
3462 (ns_symbol_to_pb): New function.
cae07000
SM
3463 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3464 (Fns_rotate_cut_buffers_internal): Remove.
3465 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3466 Fns_store_cut_buffer_internal.
3467 (ns_get_foreign_selection, Fx_own_selection_internal)
3468 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3469 (Fns_get_selection_internal, Fns_store_selection_internal):
3470 Use ns_symbol_to_pb and check if return value is nil.
3471 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3472 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3473 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3474 renamed to Sns_store_selection_internal.
3475 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3476 and remove this function.
3477 (ns_handle_selection_clear): Remove, never used.
3478 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3479 here.
3480
e1b01a3a
KB
34812011-12-17 Ken Brown <kbrown@cornell.edu>
3482
3483 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3484 GID is unknown (Bug#10257).
3485
2adb6e85
PE
34862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3487
3488 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3489 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3490 which caused a build failure on GNU/Linux IA-64. This problem was
3491 introduced by my 2011-10-07 patch.
3492
d1d7b339
JL
34932011-12-15 Juri Linkov <juri@jurta.org>
3494
3495 * image.c (imagemagick_error): New function. (Bug#10112)
3496 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3497 Use `imagemagick_error' where ImageMagick functions return
3498 `MagickFalse'.
3499 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3500 proper order.
3501
100d5755
KH
35022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3503
3504 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3505 fill background (Bug#8992).
3506
454592a6
MR
35072011-12-13 Martin Rudalics <rudalics@gmx.at>
3508
3509 * window.c (Vwindow_combination_resize)
3510 (Vwindow_combination_limit): Use t instead of non-nil in
3511 doc-strings.
61d4b438
MR
3512 (Vrecenter_redisplay): Add first sentence of doc-string on
3513 separate line.
53524d93 3514 (Frecenter): Fix doc-string typo.
454592a6 3515
3633e3aa
KH
35162011-12-11 Kenichi Handa <handa@m17n.org>
3517
3518 * coding.c (Funencodable_char_position): Pay attention to the
3519 buffer text relocation (Bug#9389).
3520
7b9d523a 35212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3522
7b9d523a
JD
3523 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3524 gtk_init (Bug#10100).
3525
b73189c6
EZ
35262011-12-10 Eli Zaretskii <eliz@gnu.org>
3527
3528 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3529 IT->string is nil. (Bug#10263)
3530
f7dfe5d6
JD
35312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3532
83faebb4
JD
3533 * nsterm.h (x_free_frame_resources): Declare.
3534
f7dfe5d6
JD
3535 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3536 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3537
3538 * nsterm.h (ns_get_defaults_value): Declare.
3539
3540 * nsterm.m (ns_default): Call ns_get_defaults_value.
3541
7cd4e72c
EZ
35422011-12-09 Eli Zaretskii <eliz@gnu.org>
3543
3544 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3545 (Bug#10170)
3546
b34d7317
YM
35472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3548
3549 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3550 that where the value of an _OBJC_* symbol points to is in the .bss
3551 section (Bug#10240).
3552
76470ad1
KH
35532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3554
3555 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3556 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3557
745fff94
KH
35582011-12-08 Kenichi Handa <handa@m17n.org>
3559
3560 * ftfont.c (get_adstyle_property): Fix previous change
3561 (Bug#10233).
3562
6e44397c
JB
35632011-12-07 Juanma Barranquero <lekktu@gmail.com>
3564
3565 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3566 dirs from the default value of EMACSLOADPATH (bug#10208).
3567
7efa6272
GM
35682011-12-07 Glenn Morris <rgm@gnu.org>
3569
3570 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3571 installation and source directories as well. (Bug#10208)
3572
f6fc4d87
CY
35732011-12-06 Chong Yidong <cyd@gnu.org>
3574
3575 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3576
2bf26180
GM
35772011-12-06 Glenn Morris <rgm@gnu.org>
3578
3579 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3580 as an error, not just -1. (Bug#10217)
3581
3a6ad4f0
CY
35822011-12-05 Chong Yidong <cyd@gnu.org>
3583
3584 * keyboard.c (process_special_events): New function.
3585 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3586
75a3b399
PE
35872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 * coding.c (encode_designation_at_bol): Don't use uninitialized
3590 local variable (Bug#9318).
3591
c3c9e25e
KH
35922011-12-05 Kenichi Handa <handa@m17n.org>
3593
3594 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3595 return Qnil (Bug#8046, Bug#10193).
3596
5eb05ea3
KH
35972011-12-05 Kenichi Handa <handa@m17n.org>
3598
3599 * coding.c (encode_designation_at_bol): New args charbuf_end and
3600 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3601 (coding_set_source): Return how many bytes coding->source was
3602 relocated.
3603 (coding_set_destination): Return how many bytes
3604 coding->destination was relocated.
3605 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3606 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3607
36082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3609
3610 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3611 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3612 macro (Bug#9318).
3613
36142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3615
3616 The following changes are to fix Bug#9318.
3617
a79703f5 3618 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3619 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3620 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3621 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3622
7dbda6df
JB
36232011-12-05 Juanma Barranquero <lekktu@gmail.com>
3624
3625 * lisp.h (process_quit_flag): Fix external declaration.
3626
6d5eb5b0
SM
36272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3628
3629 Don't macro-inline non-performance-critical code.
3630 * eval.c (process_quit_flag): New function.
3631 * lisp.h (QUIT): Use it.
3632
a0c3fad0
JD
36332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3634
3635 * nsfns.m (get_geometry_from_preferences): New function.
3636 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3637
6c07aac2
AS
36382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * emacs.c (Qkill_emacs): Define.
3641 (syms_of_emacs): Initialize it.
3642 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3643 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3644 (quit_throw_to_read_char): Add parameter `from_signal'.
3645 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3646 * lisp.h (QUIT): Call Fkill_emacs if requested.
3647
c052ead4
JD
36482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3649
3650 * widget.c (update_wm_hints): Return if wmshell is null.
3651 (widget_update_wm_size_hints): New function.
3652
3653 * widget.h (widget_update_wm_size_hints): Declare.
3654
3655 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3656 widget_update_wm_size_hints (Bug#10104).
3657
9e49252b
EZ
36582011-12-03 Eli Zaretskii <eliz@gnu.org>
3659
3660 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3661 before a newline, prepare the bidi iterator for consuming the
3662 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3663 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3664
02b16839
JL
36652011-12-02 Juri Linkov <juri@jurta.org>
3666
3667 * search.c (Fword_search_regexp): New Lisp function created from
3668 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3669 (Fword_search_backward, Fword_search_forward)
3670 (Fword_search_backward_lax, Fword_search_forward_lax):
3671 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3672 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3673
0068070e
SM
36742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3675
3676 * fileio.c (Finsert_file_contents): Move after-change-function call
3677 to before the "handled:" label, since all "goto handled" appear in
3678 cases where the *-change-functions have already been properly called
3679 (bug#10117).
3680
3360a3fc
AS
36812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3682
3683 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3684 waiting for input. (Bug#10169)
3685
73d6c093
EZ
36862011-11-30 Eli Zaretskii <eliz@gnu.org>
3687
3688 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3689 verifies glyph row's hash code--we have just reallocated the
3690 glyphs, so their contents can be complete garbage. (Bug#10164)
3691
febe6bea
JB
36922011-11-30 Juanma Barranquero <lekktu@gmail.com>
3693
3694 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3695
801a4313
EZ
36962011-11-30 Eli Zaretskii <eliz@gnu.org>
3697
3698 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3699 attributes are tested _before_ calling verify_row_hash, to protect
3700 against GCC re-ordering of the tests. (Bug#10164)
3701
2b56b87e
JD
37022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3703
3704 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3705
3706 * xterm.c (handle_one_xevent): Only set async_visible and friends
3707 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3708 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3709 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3710
dbf31225
PE
37112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3712
3713 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3714 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3715 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3716 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3717 All uses changed to use GCPRO1 etc.
3718 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3719 Revert to old implementation (i.e., before 2011-03-11).
3720
1305621b
YM
37212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3722
3723 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3724 of scroll runs so as to avoid assigning disabled bogus rows and
3725 unnecessary graphics copy operations.
3726
8c9afb46
EZ
37272011-11-27 Eli Zaretskii <eliz@gnu.org>
3728
3729 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3730 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3731 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3732 (malloc, free, realloc, calloc): Redirect to e_* only when
3733 compiling Emacs.
3734
3735 * lisp.h (GCTYPEBITS): Move before first use.
3736 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3737 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3738 this macro definition.
3739
3740 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3741 _MSC_VER.
3742
54e9e3bf
JD
37432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3744
6d5eb5b0
SM
3745 * gtkutil.c (xg_create_frame_widgets):
3746 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3747 present with Gtk+ 2.0.
3748
83aca1cb
PE
37492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3750
3751 * fileio.c (Finsert_file_contents): Undo previous change; see
3752 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3753
5b76caa4
PE
37542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3755
3756 Rename locals to avoid shadowing.
3757 * fileio.c (Finsert_file_contents):
3758 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3759 * process.c (wait_reading_process_output):
3760 Rename inner 'proc' to 'p' to avoid shadowing.
3761 Indent for consistency with usual Emacs style.
3762
8c535114
EZ
37632011-11-25 Eli Zaretskii <eliz@gnu.org>
3764
3765 * xdisp.c (redisplay_window): If cursor row is not fully visible
3766 after recentering, and scroll-conservatively is set to a large
3767 number, scroll window by a few more lines to make the cursor fully
3768 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3769 (start_display): Don't move to the next line if the display should
3770 start at a newline that is part of a display vector or an overlay
3771 string. (Bug#10119)
8c535114 3772
fa4fdb5c
JL
37732011-11-24 Juri Linkov <juri@jurta.org>
3774
3775 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3776 after the `MagickPingImage' call. (Bug#10112)
3777
90ec88df
CY
37782011-11-23 Chong Yidong <cyd@gnu.org>
3779
3780 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3781
56e2e794
MR
37822011-11-23 Martin Rudalics <rudalics@gmx.at>
3783
3784 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3785 making another buffer current. (Bug#10114)
3786
b6e64c41
GM
37872011-11-23 Glenn Morris <rgm@gnu.org>
3788
3789 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3790
6b21de18
CY
37912011-11-23 Chong Yidong <cyd@gnu.org>
3792
3793 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3794 using it (Bug#5984).
3795
b12cd789
EZ
37962011-11-22 Eli Zaretskii <eliz@gnu.org>
3797
3798 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3799 and header-lines, as they don't have one computed for them.
3800 (Bug#10098)
3801
3802 * .gdbinit (prow): Make displayed values more self-explaining.
3803 Add row's hash code.
3804
261b6fd4
LMI
38052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3806
3807 * process.c (wait_reading_process_output): Fix asynchrounous
3808 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3809 (wait_reading_process_output): Add comment and URL.
261b6fd4 3810
e7cfd277
JD
38112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3812
3813 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3814
a9b9b7f5
CY
38152011-11-21 Chong Yidong <cyd@gnu.org>
3816
3817 * window.c (Fnext_window, Fprevious_window): Doc fix.
3818
b0d15b4f
SM
38192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3820
3821 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3822
fe7a3057
JB
38232011-11-20 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3826
d2999b1a
MR
38272011-11-20 Martin Rudalics <rudalics@gmx.at>
3828
3829 * window.c (Fset_window_combination_limit): Rename argument
3830 STATUS to LIMIT.
3831 (Vwindow_combination_limit): Remove "status" from doc-string.
3832
d5ff9cd0
AS
38332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3834
3835 * m/ibms390.h: Remove.
3836 * m/ibms390x.h: Don't include "ibms390.h".
3837
a5bb9bd3
SM
38382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3839
3840 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3841 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3842
cd1181db
JB
38432011-11-20 Juanma Barranquero <lekktu@gmail.com>
3844
3845 * casetab.c (Fset_case_table):
3846 * charset.c (Fcharset_after): Fix typos.
3847
615a3b8d 38482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3849
17e845af
PE
3850 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3851 Otherwise, valgrind does not work on some platforms.
3852 Problem reported by Andreas Schwab in
6a0bf43d
PE
3853 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3854 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3855 is set, removing the need for VIRT_ADDRESS_VARIES.
3856 (PURE_P): Use a more-efficient implementation that needs just one
3857 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3858 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3859 to 4 (xorl, subq, cmpq, setbe).
3860 * alloc.c (pure): Always extern now, since that's the
3861 VIRT_ADDR_VARIES behavior.
3862 (PURE_POINTER_P): Use a single comparison, not two, for
3863 consistency with the new puresize.h.
3864 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3865 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3866 Remove VIRT_ADDR_VARIES no longer needed.
3867
f8fe6f96
EZ
38682011-11-19 Eli Zaretskii <eliz@gnu.org>
3869
3870 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3871 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3872 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3873 behave as if the cursor position were at the window margin.
3874
3875 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3876 and the cursor position is out of bounds, behave as if the cursor
3877 position were at the window margin. (Bug#10075)
3878
df05a53c
CY
38792011-11-18 Chong Yidong <cyd@gnu.org>
3880
3881 * window.c (Fwindow_combination_limit): Make first argument
3882 non-optional, since it is meaningless for live windows like the
3883 selected window.
61ccba97 3884
2071918e
DA
38852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3886
3887 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3888
b50a28de
SM
38892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3890
3891 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3892 (graft_intervals_into_buffer): Simplify.
3893
015137db
EZ
38942011-11-18 Eli Zaretskii <eliz@gnu.org>
3895
3896 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3897 hash values of the two rows.
3898 (copy_row_except_pointers): Preserve the used[] arrays and the
3899 hash values of the two rows. (Bug#10035)
68c95424 3900 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3901
3902 * xdisp.c (row_hash): New function, body extracted from
3903 compute_line_metrics.
3904 (compute_line_metrics): Call row_hash, instead of computing the
3905 hash code inline.
3906
3907 * dispnew.c (verify_row_hash): Call row_hash for computing the
3908 hash code of a row, instead of duplicating code from xdisp.c.
3909
3910 * dispextern.h (row_hash): Add prototype.
3911
a2addb04
TH
39122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3913
3914 * frame.c (delete_frame): Don't delete the terminal when the last
3915 X frame is closed if emacs is built with GTK toolkit.
3916
df85d315
JB
39172011-11-17 Juanma Barranquero <lekktu@gmail.com>
3918
3919 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3920
a0c2d0ae
MR
39212011-11-17 Martin Rudalics <rudalics@gmx.at>
3922
3923 * window.c (Vwindow_splits): Rename to
3924 Vwindow_combination_resize. Suggested by Juri Linkov.
3925 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3926 of Vwindow_splits.
3927
58179cce
JB
39282011-11-16 Juanma Barranquero <lekktu@gmail.com>
3929
7877f373
JB
3930 * nsfns.m (Fns_font_name):
3931 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3932
b6f67890
MR
39332011-11-16 Martin Rudalics <rudalics@gmx.at>
3934
3935 * window.h (window): Rename slot "nest" to "combination_limit".
3936 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3937 (Fset_window_nest): Rename to Fset_window_combination_limit.
3938 (Vwindow_nest): Rename to Vwindow_combination_limit.
3939 (recombine_windows, make_parent_window, make_window)
3940 (Fsplit_window_internal, saved_window)
3941 (Fset_window_configuration, save_window_save): Rename all
3942 occurrences of window_nest to window_combination_limit.
3943
c7015153
JB
39442011-11-15 Juanma Barranquero <lekktu@gmail.com>
3945
3946 * image.c (imagemagick_load_image): Fix typo.
3947
322ad6ec
EZ
39482011-11-14 Eli Zaretskii <eliz@gnu.org>
3949
3950 * xdisp.c (display_line): Move the call to
3951 highlight_trailing_whitespace before the call to
3952 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3953 faces of all the glyphs to compute ROW's hash value.
3954 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3955
f067b8ec
JB
39562011-11-14 Juanma Barranquero <lekktu@gmail.com>
3957
3958 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3959 just return (bug#10044).
3960
1e5b2111
EZ
39612011-11-12 Eli Zaretskii <eliz@gnu.org>
3962
7ef3cbd5
EZ
3963 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3964 with user-defined heap size. Bump the default size of the temacs
3965 heap to 27MB, to avoid memory warning when running temacs.
3966 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3967
1e5b2111
EZ
3968 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3969 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3970 (verify_row_hash) [XASSERTS]: New function.
3971 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3972 that the hash value of glyph rows is correct.
1e5b2111 3973
89d61221
MR
39742011-11-12 Martin Rudalics <rudalics@gmx.at>
3975
3976 * window.h (window): Remove splits slot.
3977 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3978 (Fdelete_other_windows_internal, make_parent_window)
3979 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3980 (Fset_window_configuration, save_window_save): Don't deal with
3981 split status of windows.
3982 (saved_window): Remove splits slot.
3983 (Vwindow_splits): Rewrite doc-string.
3984
97f18cc8
JD
39852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3986
3987 * xfns.c (unwind_create_frame):
3988 * nsfns.m (unwind_create_frame):
3989 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3990 Vframe_list (Bug#9999).
3991
22a648b4
DA
39922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3993
0b381c7e 3994 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3995
659afede
KH
39962011-11-11 Kenichi Handa <handa@m17n.org>
3997
3998 * callproc.c (Fcall_process): Set the member dst_multibyte of
3999 process_coding.
4000
9ac0394b
KH
40012011-11-11 Johan Bockgård <bojohan@gnu.org>
4002
4003 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4004 avoid a crash (bug#9496).
4005
2fbdc249
CY
40062011-11-09 Chong Yidong <cyd@gnu.org>
4007
4008 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4009 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4010
ac6b1f81
PE
40112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4012
4013 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4014
09db192c
PE
40152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4016
4017 Avoid some portability problems by eschewing 'extern inline' functions.
4018 The trivial performance wins aren't worth the portability hassles; see
4019 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4020 et seq.
4021 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4022 (window_box_width, window_box_left, window_box_left_offset)
4023 (window_box_right, window_box_right_offset): Undo previous change,
4024 by removing the "extern"s.
4025 * intervals.c (adjust_intervals_for_insertion)
4026 (adjust_intervals_for_deletion): Undo previous change,
4027 making these static again.
4028 (offset_intervals, temp_set_point_both, temp_set_point)
4029 (copy_intervals_to_string): No longer inline.
4030 * xdisp.c (window_text_bottom_y, window_box_width)
4031 (window_box_height, window_box_left_offset)
4032 (window_box_right_offset, window_box_left, window_box_right)
4033 (window_box): No longer inline.
4034
105216ed
CY
40352011-11-08 Chong Yidong <cyd@gnu.org>
4036
4037 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4038 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4039 Signal an error if not a live window.
105216ed
CY
4040 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4041 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4042
ae9e237f
JB
40432011-11-07 Juanma Barranquero <lekktu@gmail.com>
4044
4045 * lisp.h (syms_of_abbrev): Remove declaration.
4046 Reported by CHENG Gao <chenggao@royau.me>.
4047
c7aa8333
EZ
40482011-11-07 Eli Zaretskii <eliz@gnu.org>
4049
4050 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4051 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4052 of temacs in GUI mode.
4053
be7f5545
MR
40542011-11-07 Martin Rudalics <rudalics@gmx.at>
4055
4056 * window.h: Declare delete_all_child_windows instead of
4057 delete_all_subwindows.
4058 * window.c (Fwindow_nest, Fset_window_nest)
4059 (Fset_window_new_total, Fset_window_new_normal)
4060 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4061 (delete_all_subwindows): Rename to delete_all_child_windows.
4062 (Fdelete_other_windows_internal, Fset_window_configuration):
4063 Call delete_all_child_windows instead of delete_all_subwindows.
4064 * frame.c (delete_frame): Call delete_all_child_windows instead
4065 of delete_all_subwindows.
4066
ca78dc43
PE
40672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4070 This is also needed for porting to any host where GC_MARK_STACK is
4071 not GC_MAKE_GCPROS_NOOPS.
4072 (which_symbols): Use it.
4073
a0241d01
KH
40742011-11-07 Kenichi Handa <handa@m17n.org>
4075
4076 * coding.c (coding_set_destination): Check coding->src_pos only
4077 when coding->src_object is a buffer (bug#9910).
4078
4079 * process.c (send_process): Set the member src_multibyte of coding
4080 to 0 (bug#9911) when sending a unibyte text.
4081
4082 * callproc.c (Fcall_process): Set the member src_multibyte of
4083 process_coding to 0 (bug#9912).
4084
a64bfdfa 40852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4086
4087 * xmenu.c (cleanup_widget_value_tree): New function.
4088 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4089 calling free_menubar_widget_value_tree directly (Bug#9830).
4090
cb41b32a
PE
40912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4092
4093 Fix some portability problems with 'inline'.
4094 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4095 (window_box_width, window_box_left, window_box_left_offset)
4096 (window_box_right, window_box_right_offset): Declare extern.
4097 Otherwise, these inline functions do not conform to C99 and
4098 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4099 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4100 * intervals.c (adjust_intervals_for_insertion)
4101 (adjust_intervals_for_deletion): Now extern, because otherwise the
4102 extern inline functions 'offset_intervals' couldn't refer to it.
4103 (static_offset_intervals): Remove.
4104 (offset_intervals): Rewrite using the old contents of
4105 static_offset_intervals. The old version didn't conform to C99
4106 because an extern inline function contained a reference to an
4107 identifier with static linkage.
4108
b7041366
AS
41092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4110
4111 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4112 GC.
4113
88a37c4d
EZ
41142011-11-06 Eli Zaretskii <eliz@gnu.org>
4115
4116 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4117 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4118 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4119 return Qleft_to_right.
4120
49745b39
CY
41212011-11-06 Chong Yidong <cyd@gnu.org>
4122
4123 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4124 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4125 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4126 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4127 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4128 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4129 (Fwindow_vscroll): Doc fix.
4130 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4131 argument, since it makes no sense to pass a live window and for
4132 consistency with window-child.
4133
1f05cd82
CS
41342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4135
4136 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4137 support MSVC.
4138
22610910
JR
41392011-11-05 Jason Rumney <jasonr@gnu.org>
4140
4141 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4142 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4143 fonts (Bug#6029).
4144 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4145 bitwise arithmetic preventing use of unicode-sip and non-truetype
4146 opentype fonts.
4147
a06776b2
EZ
41482011-11-05 Eli Zaretskii <eliz@gnu.org>
4149
3ad924ba
EZ
4150 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4151 "emacs"-only part.
4152
a06776b2
EZ
4153 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4154 initialization code to keep similarity to xfns.c after changes
4155 from 2011-11-05.
4156
c9e7db78
JD
41572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4158
a97f8f3f
JD
4159 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4160 (unwind_create_frame): New function (Bug#9943).
4161 (Fx_create_frame): Restructure code to be more similar to the one in
4162 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4163 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4164 Move terminal->reference_count++ just before making the frame official
4165 (Bug#9943).
4166
4167 * nsterm.m (x_free_frame_resources): New function.
4168 (x_destroy_window): Move code to x_free_frame_resources.
4169
c9e7db78 4170 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4171 (Fx_create_frame, x_create_tip_frame):
4172 Move terminal->reference_count++ just before making the frame
75f1671a 4173 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4174 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4175
a6fc3b5c
EZ
41762011-11-05 Eli Zaretskii <eliz@gnu.org>
4177
4178 Support MSVC build with newer versions of Visual Studio.
4179 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4180 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4181 nt/gmake.defs.
4182
4183 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4184 which are not supported by MSVC.
4185 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4186 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4187 bitfields.
4188 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4189 types in bitfields.
4190 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4191
4192 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4193
58179cce 41942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4195
4196 Support MSVC build with newer versions of Visual Studio.
4197 * w32.c: Don't include w32api.h for MSVC.
4198 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4199
4200 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4201 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4202 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4203 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4204 e_* cousins.
4205 (alloca) [_MSC_VER]: Define to _alloca.
4206
4207 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4208
4209 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4210
a58c13ed
EZ
42112011-11-04 Eli Zaretskii <eliz@gnu.org>
4212
4213 * xdisp.c (note_mouse_highlight): If either of
4214 previous/next-single-property-change returns nil, treat that as
4215 the beginning or the end of the buffer. (Bug#9955)
4216
fe0b6370
JD
42172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4218
a58c13ed 4219 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4220 label is not null (Bug#9951).
4221 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4222 may be NULL.
4223
89bd5ee1
EZ
42242011-11-04 Eli Zaretskii <eliz@gnu.org>
4225
4226 * window.c (Fwindow_body_size): Mention in the doc string that the
4227 return value is in frame's canonical units. (Bug#9949)
4228
84c3edb9
EZ
42292011-11-03 Eli Zaretskii <eliz@gnu.org>
4230
4e2fb5c7
EZ
4231 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4232
84c3edb9 4233 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4234 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4235 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4236
bc17a887
EZ
42372011-11-01 Eli Zaretskii <eliz@gnu.org>
4238
4239 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4240 Don't stop backward scan on the continuation glyph, even though
4241 its CHARPOS is positive.
6d5eb5b0
SM
4242 (mouse_face_from_buffer_pos, note_mouse_highlight):
4243 Rename cover_string to disp_string.
bc17a887 4244
4ee88440
MR
42452011-11-01 Martin Rudalics <rudalics@gmx.at>
4246
4247 * window.c (temp_output_buffer_show): Don't use
4248 Vtemp_buffer_show_specifiers.
4249 (Vtemp_buffer_show_specifiers): Remove unused variable.
4250
c2ff3c02
EZ
42512011-10-30 Eli Zaretskii <eliz@gnu.org>
4252
4253 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4254 past the beginning of the current glyph matrix.
4255
58179cce 42562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4257
4258 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4259 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4260 HAVE_GTK3 (Bug#9869).
b77a6a7f 4261
3b574623
JD
4262 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4263 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4264
b77a6a7f
JD
4265 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4266
4267 * xterm.c: Declare x_handle_net_wm_state to return int.
4268 (handle_one_xevent): Check if we are iconified but don't have
4269 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4270 (get_current_wm_state): Return non-zero if not hidden,
4271 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4272 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4273 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4274 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4275
196e41e4
PE
42762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4277
4278 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4279 so that this new function doesn't get optimized away by a
4280 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4281
021f2e1a
AS
42822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4283
4284 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4285
8b058d44
EZ
42862011-10-29 Eli Zaretskii <eliz@gnu.org>
4287
4288 Fix the `xbytecode' command.
4289 * .gdbinit (xprintbytestr): New command.
b50a28de 4290 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4291 (xbytecode): Print the byte-code string as well.
4292
4452fb80
EZ
42932011-10-29 Kim Storm <storm@cua.dk>
4294
8b058d44
EZ
4295 * alloc.c (which_symbols): New function.
4296
21b72067
AS
42972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4298
4299 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4300 line. (Bug#9903)
4301
83ed7b5c
GM
43022011-10-29 Glenn Morris <rgm@gnu.org>
4303
4304 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4305 Not clear what it was for, and it causes various bugs. (Bug#9839)
4306
5a7a728b
EZ
43072011-10-28 Eli Zaretskii <eliz@gnu.org>
4308
4309 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4310 possible random value that matches one of those tested as
4311 condition to clear the mouse face.
4312
d3d0842f
CY
43132011-10-28 Chong Yidong <cyd@gnu.org>
4314
4315 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4316
31b39d13
DN
43172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4318
4319 * window.c (make_window): Initialize phys_cursor_on_p.
4320
9aba6043
SM
43212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4322
4323 * lisp.h (struct Lisp_Symbol): Update comments.
4324
c20992f4
JB
43252011-10-28 Juanma Barranquero <lekktu@gmail.com>
4326
4327 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4328
db4f02f2
EZ
43292011-10-28 Eli Zaretskii <eliz@gnu.org>
4330
4331 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4332 <oslsachem@gmail.com> for helping to debug this.
4333
4334 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4335 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4336 (g_b_init_get_glyph_outline_w): New static variables.
4337 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4338 (GetGlyphOutlineW_Proc): New typedefs.
4339 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4340 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4341 New functions.
4342 (w32font_open_internal, compute_metrics):
4343 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4344 instead of calling the "wide" APIs directly.
4345
4346 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4347
4348 * w32.h (syms_of_w32font): Add prototype.
4349
87e68db4
JB
43502011-10-27 Juanma Barranquero <lekktu@gmail.com>
4351
4352 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4353 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4354 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4355 (Fmove_to_window_line): Doc fix.
4356
435c1d67
CY
43572011-10-27 Chong Yidong <cyd@gnu.org>
4358
4359 * process.c (make_process): Set gnutls_state to NULL.
4360
4361 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4362 non-NULL, regardless of GNUTLS_INITSTAGE.
4363 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4364 an error. Set process slots as soon as we allocate them.
4365
4366 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4367
9c6c6f49
CY
43682011-10-27 Chong Yidong <cyd@gnu.org>
4369
9aba6043
SM
4370 * gnutls.c (emacs_gnutls_deinit): New function.
4371 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4372 (Fgnutls_deinit, Fgnutls_boot): Use it.
4373
4374 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4375 (deactivate_process): Call emacs_gnutls_deinit.
4376
657d08d3
JB
43772011-10-27 Juanma Barranquero <lekktu@gmail.com>
4378
4379 * image.c (x_create_x_image_and_pixmap):
4380 * w32.c (sys_rename, w32_delayed_load):
4381 * w32font.c (fill_in_logfont):
4382 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4383
5430d399
JB
43842011-10-26 Juanma Barranquero <lekktu@gmail.com>
4385
4386 * w32fns.c (w32_default_color_map): New function,
4387 extracted from Fw32_default_color_map.
a7ef684b 4388 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4389
fe0055fa
PE
43902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4391
4392 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4393
e6346438
SM
43942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4395
4396 * keyboard.c (test_undefined): New function (bug#9751).
4397 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4398
e112cc37
ET
43992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4400
4401 * sysdep.c (init_sys_modes): Fix the check for the controlling
4402 terminal (Bug#6649).
4403
7b5d6677
EZ
44042011-10-20 Eli Zaretskii <eliz@gnu.org>
4405
4406 * dispextern.h (struct bidi_it): New member next_en_type.
4407
4408 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4409 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4410 current character, check also for next_en_type being WEAK_EN.
4411 (bidi_resolve_weak): Don't enter the expensive loop if the current
4412 position is before next_en_pos. Record the bidi type of the first
4413 non-ET, non-BN character we find, in addition to its position.
4414 (bidi_level_of_next_char): Invalidate next_en_type when
4415 next_en_pos is over-stepped.
4416
7da0b018
PE
44172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4420 * editfns.c: Rewrite current-time-zone so that it invokes
4421 the equivalent of (format-time-string "%Z") to get the time zone name.
4422 This fixes a bug when the time zone name contains characters that
4423 need converting from the system time locale to Emacs internal format.
4424 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4425 that patch fixed format-time-string to do the conversion, but
4426 I forgot to fix current-time-zone.
4427 (format_time_string): New function, containing most of
4428 what Fformat_time_string used to contain.
4429 (Fformat_time_string): Rewrite in terms of format_time_string.
4430 This doesn't change this function's behavior.
4431 (current-time-zone): Rewrite to use format_time_string.
4432 This fixes the bug reported by Michael Schierl in
4433 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4434 Jason Rumney's 2007-06-07 change worked around this bug, but
4435 didn't fix it.
4436 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4437
8547b010
EZ
44382011-10-19 Eli Zaretskii <eliz@gnu.org>
4439
4440 * xdisp.c (start_display): If the character at POS is displayed
4441 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4442 (try_window_reusing_current_matrix): If a line ends in a display
4443 vector or the next line starts in a display vector, continue
4444 redrawing the window even though the character position of
4445 start_row was reached.
8547b010
EZ
4446 (Bug#9771, part 2)
4447
4e948d15
CY
44482011-10-18 Chong Yidong <cyd@gnu.org>
4449
4450 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4451 with nobreak-char-display too.
4452
4787455f
EZ
44532011-10-18 Eli Zaretskii <eliz@gnu.org>
4454
4455 Fix part 3 of bug#9771.
4456 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4457 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4458 non-neutral characters if the current character is a paragraph
4459 separator (a.k.a. Newline). This avoids running the same
4460 expensive loop twice, once when we consume the preceding newline
4461 and the other time when the line actually needs to be displayed.
4462 Avoid the loop when we see neutrals on the base embedding level
4463 following a character whose directionality is the same as the
4464 paragraph's. This avoids running the expensive loop when a line
4465 ends in a long sequence of neutrals, like control characters.
4466 Add assertion against STRONG_AL type. Slightly rearrange code
4467 that determines the type of a neutral given the first non-neutral
4468 that follows it.
4469 (bidi_level_of_next_char): Set next_en_pos to zero when
4470 invalidating its info.
4471
2c91f553
EZ
44722011-10-17 Eli Zaretskii <eliz@gnu.org>
4473
4474 * xdisp.c (push_display_prop): Determine whether to record string
4475 or buffer position by IT->string, not by IT->method. Allow
4476 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4477 (move_it_vertically_backward): Don't look for character position
4478 immediately after the newline when in a continuation line.
4479 (Bug#9771, part 1)
2c91f553 4480
c7b08b0d
MR
44812011-10-15 Martin Rudalics <rudalics@gmx.at>
4482
4483 * window.c (coordinates_in_window): Rewrite and delabelize
4484 vertical border check. (Bug#5357) (Bug#9618)
4485
6b02f655
SM
44862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4487
4488 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4489 errors in XSetWindowBorder (bug#9310).
4490
81d40c92
DA
44912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4492
4493 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4494 avoid crash when xmalloc overrun checking is enabled.
4495
d4172c3b
EZ
44962011-10-13 Eli Zaretskii <eliz@gnu.org>
4497
4498 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4499 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4500 cursor motion with <left> and <right> arrow keys.
4501
4502 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4503 some callers set that themselves.
4504
b00eea75
EZ
45052011-10-12 Eli Zaretskii <eliz@gnu.org>
4506
4507 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4508 display string and the previous row comes from the same string and
4509 is empty. (Bug#9739) (Bug#9738)
4510
8fe012c4
SM
45112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4512
4513 * doc.c (get_doc_string): Encode file name (bug#9735).
4514
0074aef2
EZ
45152011-10-12 Eli Zaretskii <eliz@gnu.org>
4516
79beb178
EZ
4517 * bidi.c (bidi_level_of_next_char):
4518 * xdisp.c (get_visually_first_element): Remove old incorrect
4519 comments regarding the Unicode Line Separator character.
4520
0074aef2
EZ
4521 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4522
6e4b3fbe
DA
45232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4524
4525 * alloc.c (Fgc_status): Do not access beyond zombies array
4526 boundary if nzombies > MAX_ZOMBIES.
4527 * alloc.c (dump_zombies): Add missing format specifier.
4528
0324f3af
PE
45292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4530
b5525cac
PE
4531 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4532 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4533
0324f3af
PE
4534 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4535 Some packages use them to denote characters with modifiers.
4536
e9b5f888
AS
45372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4538
4539 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4540 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4541 matching a pp-number. Rename parameter var to var1.
4542
127827c0
SM
45432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4544
4545 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4546
c8fd3bd0
GM
45472011-10-08 Glenn Morris <rgm@gnu.org>
4548
4549 * callint.c (Fcall_interactively): Give a more explicit error for the
4550 'c' case with a non-character input. (Bug#8479)
4551
352ec8ff
EZ
45522011-10-08 Eli Zaretskii <eliz@gnu.org>
4553
03669ccb
EZ
4554 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4555 lines.
7061c986
EZ
4556 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4557 lines that are hscrolled on the left.
03669ccb 4558
352ec8ff
EZ
4559 * dispnew.c (buffer_posn_from_coords): Account for a possible
4560 presence of header-line. (Bug#4426)
4561
a66cfb1c
SM
45622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4563
6b02f655
SM
4564 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4565 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4566
7c5ee88e
PE
45672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4570 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4571 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4572 this makes Emacs dump core during garbage collection on rare
4573 occasions. sizeof is obviously inferior to offsetof here, so
4574 stick with offsetof.
4575 (GC_POINTER_ALIGNMENT): New macro.
4576 (mark_memory): Omit 3rd (offset) arg; caller changed.
4577 Don't assume EMACS_INT alignment is the same as pointer alignment.
4578
df1bbe5b
SM
45792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4580
4581 * keyboard.c (read_key_sequence_remapped): New var.
4582 (read_key_sequence): Compute remapping in the right buffer.
4583 (command_loop_1): Use read_key_sequence's remapping directly.
4584
51553db6
SM
45852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4586
32c1fffd
SM
4587 * dired.c (file_name_completion): Don't expand file name.
4588 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4589 before checking file name handler.
4590
51553db6
SM
4591 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4592 they've been requested explicitly (bug#9591).
4593
b6bd1599 45942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4595
4596 * keymap.c (Fsingle_key_description): Use make_specified_string
4597 instead of build_string to build string from push_key_description.
4598 (Bug#5193)
4599
f701dc2a
PE
46002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4601
4222c55d
PE
4602 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4603 This fixes a Y2038 bug on 64-bit hosts.
4604 * buffer.c (reset_buffer):
4605 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4606 (Fclear_buffer_auto_save_failure):
4607 Use 0, not -1, to represent an unset failure time, since time_t
4608 might not be signed.
4609
f701dc2a
PE
4610 Remove dependency on glibc malloc internals.
4611 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4612 Move back here from lisp.h, but with their new implementations.
4613 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4614 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4615 * charset.c (charset_table_init): New static var.
4616 (syms_of_charset): Use it instead of xmalloc. This removes a
4617 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4618 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4619 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4620 Move back to alloc.c.
4621 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4622 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4623
9ceebf39
JD
46242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4625
4626 * nsterm.m (windowDidResize): Call x_set_window_size only when
4627 ns_in_resize is true. Otherwise set pixelwidth/height and
4628 call change_frame_size (Bug#9628).
4629
cb993c58
PE
46302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4631
3930c88b
PE
4632 Port --enable-checking=all to Fedora 14 x86-64.
4633 * charset.c (syms_of_charset): Also account for glibc malloc's
4634 internal overhead when calculating the initial malloc maximum.
4635
cb993c58
PE
4636 Port --enable-checking=all to Fedora 14 x86.
4637 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4638 Move to lisp.h.
4639 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4640 (overrun_check_realloc, overrun_check_free):
4641 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4642 That way, xmalloc returns a properly-aligned pointer even if
4643 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4644 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4645 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4646 into account when calculating the initial malloc maximum.
4647 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4648 Move here from alloc.c, so that charset.c can use it too.
4649 Properly align; the old code wasn't right for common 32-bit hosts
4650 when configured with --enable-checking=all.
4651 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4652 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4653
31bed486
EZ
46542011-09-29 Eli Zaretskii <eliz@gnu.org>
4655
04c70788 4656 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4657 use EDOM.
4658
fbcaa2f3
EZ
46592011-09-28 Eli Zaretskii <eliz@gnu.org>
4660
4661 * xdisp.c (compute_display_string_end): If there's no display
4662 string at CHARPOS, return -1.
4663
4664 * bidi.c (bidi_fetch_char): When compute_display_string_end
4665 returns a negative value, treat the character as a normal
4666 character not covered by a display string. (Bug#9624)
4667
a239d4e9
JB
46682011-09-28 Juanma Barranquero <lekktu@gmail.com>
4669
4670 * lread.c (Fread_from_string): Fix typo in docstring.
4671
88652fd5
EZ
46722011-09-27 Eli Zaretskii <eliz@gnu.org>
4673
4674 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4675 newline, reseat the iterator instead of bidi-iterating there one
4676 character at a time. (Bug#9610)
32c1fffd
SM
4677 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4678 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4679
ed497dd4
AS
46802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4681
4682 * lread.c (readevalloop): Use correct code for NBSP.
4683 (read1): Likewise. (Bug#9608)
4684
b2bf61aa
MA
46852011-09-25 Michael Albinus <michael.albinus@gmx.de>
4686
4687 * dbusbind.c (Fdbus_register_signal): When service is not
4688 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4689
32bbb17c
GM
46902011-09-25 Glenn Morris <rgm@gnu.org>
4691
4692 * buffer.c (truncate-lines): Doc fix.
4693
94e0933e
CY
46942011-09-24 Chong Yidong <cyd@stupidchicken.com>
4695
4696 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4697 (Fset_window_next_buffers): Doc fix.
4698
cddde921
GM
46992011-09-24 Glenn Morris <rgm@gnu.org>
4700
4701 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4702
1260aef1
PE
47032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4704
25b4bfa0
PE
4705 Fix minor problems found by static checking.
4706 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4707 * indent.c (Fvertical_motion): Fix == vs = typo.
4708
e3cbd34b
EZ
47092011-09-24 Eli Zaretskii <eliz@gnu.org>
4710
a66cfb1c
SM
4711 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4712 Default value is now t. Doc fix.
6bf7006f 4713
e3cbd34b 4714 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4715 logic when moving up, not only when moving down. Fix the
e3cbd34b 4716 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4717 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4718
4719 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4720 CHARPOS is covered by a display string which includes newlines.
4721 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4722 is covered by a display string with embedded newlines.
4723
a3de0cbd
MA
47242011-09-24 Michael Albinus <michael.albinus@gmx.de>
4725
4726 * dbusbind.c (Fdbus_register_signal): Add match rule to
4727 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4728 (Fdbus_register_method, Vdbus_registered_objects_table):
4729 Fix docstring.
a3de0cbd 4730
b260039d
JM
47312011-09-24 Jim Meyering <meyering@redhat.com>
4732
32c1fffd 4733 do not ignore write error for any output size
b260039d
JM
4734 The previous change was incomplete.
4735 While it makes emacs --batch detect the vast majority of stdout
4736 write failures, errors were still ignored whenever the output size is
4737 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4738 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4739 && echo FAIL: ignored write error
4740 FAIL: ignored write error
4741 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4742 && echo FAIL: ignored write error
4743 FAIL: ignored write error
4744 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4745
8eca8a7c
AS
47462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4747
4748 * emacs.c (Fkill_emacs): In noninteractive mode exit
4749 non-successfully if a write error occurred on stdout. (Bug#9574)
4750
3341db62
EZ
47512011-09-21 Eli Zaretskii <eliz@gnu.org>
4752
4753 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4754 the xassert test.
4755
4756 * dispextern.h (struct it): Update the comment documenting what
4757 can it->OBJECT be.
4758
8c203dbf
EZ
47592011-09-20 Eli Zaretskii <eliz@gnu.org>
4760
4761 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4762 a display string, extend search for cursor position to end of row.
4763 (find_row_edges): If the row ends in a newline from a display
4764 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4765 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4766 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4767 non-empty line. Fixes confusing cursor motion with arrow keys at
4768 the beginning of a line that starts with whitespace.
8c203dbf 4769
a4824228
LMI
47702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4771
4772 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4773 (bug#9493).
4774
33ed493b
CY
47752011-09-18 Chong Yidong <cyd@stupidchicken.com>
4776
4777 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4778 boolean (Bug#9154).
4779
56cd55c8
EZ
47802011-09-18 Eli Zaretskii <eliz@gnu.org>
4781
4782 * xdisp.c (display_line): Record maximum and minimum buffer
4783 positions even if no glyphs were produced (e.g., by a zero-width
4784 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4785 buffer positions that will be removed from the glyph row because
4786 they don't fit.
c02dcedf
EZ
4787 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4788 column is beyond frame width: don't subtract 1 "pixel" when
4789 computing width of the stretch.
3e62b7e0
EZ
4790 (reseat_at_next_visible_line_start): Undo the change made on
4791 2011-09-17 that saved paragraph information and restored it after
4792 the call to `reseat'. (Bug#9545)
56cd55c8 4793
5ed99d36 47942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4795
4796 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4797 and turn window cursor on if cleared (Bug#9415).
4798
5ed99d36 47992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4800
4801 * search.c (boyer_moore): Take unibyte characters from pattern
4802 literally. (Bug#9458)
4803
9bade7b2
EZ
48042011-09-18 Eli Zaretskii <eliz@gnu.org>
4805
4806 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4807
e5e9d610
PE
48082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4809
87e4427a
PE
4810 Fix minor problem found by static checking.
4811 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4812 initialized, to pacify gcc -Wuninitialized.
4813
e5e9d610
PE
4814 * fileio.c: Report proper errno when syscall falls.
4815 (Finsert_file_contents): Save and restore errno,
4816 so that report_file_error outputs the correct diagnostic.
4817 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4818
a1674f0b
EZ
48192011-09-18 Eli Zaretskii <eliz@gnu.org>
4820
4821 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4822
fbfb6dd4
EZ
48232011-09-17 Eli Zaretskii <eliz@gnu.org>
4824
4825 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4826 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4827
bb187662
EZ
48282011-09-17 Eli Zaretskii <eliz@gnu.org>
4829
1137e8b8 4830 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4831 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4832
4833 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4834 (bidi_find_paragraph_start): Search back for paragraph beginning
4835 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4836 (bidi_move_to_visually_next): Only trigger paragraph-related
4837 computations when the last character is a newline or at EOB, not
4838 just any NEUTRAL_B. (Bug#9470)
4839
bb187662
EZ
4840 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4841 truncated lines if point is covered by a display string. (Bug#9524)
4842
2e621251
PE
48432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4844
4845 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4846 (cons_to_x_long): New function.
4847 (lisp_data_to_selection_data): Use it. Correct the test for
4848 short-versus-long data; it was negated. Break out of vector
4849 loop, for efficiency, when a long datum is discovered.
4850
91a15bc6
SM
48512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4852
4853 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4854
b41c3a35
EZ
48552011-09-16 Eli Zaretskii <eliz@gnu.org>
4856
4857 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4858 GCC PR/17406) by declaring this function with external scope.
4859
7812ba2d
PE
48602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4861
4862 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4863 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4864
cf7edc2a
AS
48652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4866
4867 * editfns.c (Fformat): Correctly handle text properties on "%%".
4868
bd01620e
EZ
48692011-09-15 Eli Zaretskii <eliz@gnu.org>
4870
4871 * xterm.c (x_draw_composite_glyph_string_foreground):
4872 * w32term.c (x_draw_composite_glyph_string_foreground):
4873 * term.c (encode_terminal_code):
4874 * composite.c (composition_update_it, get_composition_id):
4875 * xdisp.c (get_next_display_element)
4876 (fill_composite_glyph_string): Add comments about special meaning
4877 of TAB characters in a composition.
4878
a02719a3
PE
48792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4880
4881 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4882 This occurs when processing a multibyte format.
4883 Problem reported by Wolfgang Jenker.
a02719a3 4884
72589a3c
JB
48852011-09-15 Johan Bockgård <bojohan@gnu.org>
4886
4887 * xdisp.c (try_cursor_movement): Only check for exact match if
4888 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4889
1c14176c
PE
48902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4891
4892 Remove unused external symbols.
4893 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4894 * xdisp.c (calc_pixel_width_or_height): Now static.
4895 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4896 * indent.c (check_display_width):
4897 * w32term.c: Fix comment to match code.
4898 * xterm.c, xterm.h (x_catching_errors): Remove.
4899
d2eea5b5
PE
49002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4901
4902 * xselect.c: Use signed conversions more consistently (Bug#9498).
4903 (selection_data_to_lisp_data): Assume incoming selection data are
4904 signed integers, not unsigned. This is to be consistent with
4905 outgoing selection data, which was modified to use signed integers
4906 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4907 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4908 expects long, not unsigned long.
4909
46888499
EZ
49102011-09-14 Eli Zaretskii <eliz@gnu.org>
4911
4912 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4913 computation of loop end. Reported by Johan Bockgård
4914 <bojohan@gnu.org>.
4915
ef8ef9fb
CY
49162011-09-13 Chong Yidong <cyd@stupidchicken.com>
4917
4918 * frame.c (Fother_visible_frames_p): Function deleted.
4919
fa819fed
EZ
49202011-09-12 Eli Zaretskii <eliz@gnu.org>
4921
4922 * indent.c (compute_motion): Process display vector front to back
4923 rather than the other way around. (Bug#2496)
4924
2ba8e008
SM
49252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4926
4927 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4928
20f53c69
CY
49292011-09-11 Chong Yidong <cyd@stupidchicken.com>
4930
4931 * minibuf.c (Fread_from_minibuffer): Doc fix.
4932
d562d7a4
EZ
49332011-09-11 Eli Zaretskii <eliz@gnu.org>
4934
4935 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4936 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4937
1c4d7f3d
LMI
49382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4939
4940 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4941 value for non-existent files.
4942
b885bf36
EZ
49432011-09-11 Eli Zaretskii <eliz@gnu.org>
4944
4945 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4946 set its "size" to -1. This will set the modtime_size field of
4947 the corresponding buffer to -1, which is what
4948 verify-visited-file-modtime expects for files that do not exist.
4949 (Bug#9139)
4950
6612f0bf
PE
49512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4952
4953 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4954 here ...
4955 * lisp.h: ... from here. push_key_description is no longer
4956 defined in keyboard.c, so its declaration should not be in
4957 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4958 logically belongs with push_key_description.
4959
dfb3f755
PE
49602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4961
4962 * buffer.h: Include <sys/types.h> instead of <time.h>.
4963 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4964 Problem reported by Herbert J. Skuhra.
4965
3134906c
LMI
49662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4967
4968 * xml.c (parse_region): Make the parsing work for
4969 non-comment-starting XML files again (bug#9144).
4970
8d903f4e
AS
49712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4972
4973 * image.c (gif_load): Fix calculation of bottom and right corner.
4974 (Bug#9468)
4975
80ad64f4
EZ
49762011-09-10 Eli Zaretskii <eliz@gnu.org>
4977
4978 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4979 redisplay in small windows.
4980
208a048d
EZ
49812011-09-09 Eli Zaretskii <eliz@gnu.org>
4982
4983 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4984
9b1c252e
MR
49852011-09-08 Martin Rudalics <rudalics@gmx.at>
4986
4987 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4988 Operate on live windows only.
4989
2949f33b
JB
49902011-09-08 Juanma Barranquero <lekktu@gmail.com>
4991
4992 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4993
e08dcafd
EZ
49942011-09-07 Eli Zaretskii <eliz@gnu.org>
4995
4996 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4997 only under bidi iteration.
4998
115b96bd
JD
49992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5000
5001 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5002
c8199d0f
PE
50032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5004
5005 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5006 Without this fix, the command to link temacs failed due to an
5007 undefined symbol __builtin_isnan. This is because
5008 /usr/include/iso/math_c99.h #defines isnan(x) to
5009 __builtin_isnan(x), but the bundled gcc, which identifies itself
5010 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5011 a __builtin_isnan.
5012 * floatfns.c (isnan): #undef, and then #define to a clone of
5013 what's in data.c.
5014 (Fisnan): Always define, since it's always available now.
5015 (syms_of_floatfns): Always define isnan at the Lisp level.
5016
e39b275c 50172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5018
5019 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5020
b2db44d9 50212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5022
f4af5137 5023 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5024 The previous code assumed that file offsets (off_t values) fit in
5025 EMACS_INT variables, which is not true on typical 32-bit hosts.
5026 The code messed up by falsely reporting buffer overflow in cases
5027 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5028 when "big" contains more than 2**29 bytes, even though this
5029 inserts just one byte and does not overflow the buffer.
5030 (Finsert_file_contents): Store file offsets as off_t
5031 values, not as EMACS_INT values. Check for overflow when
5032 converting between EMACS_INT and off_t. When checking for
5033 buffer overflow or for overlap, take the offsets into account.
5034 Don't use EMACS_INT for small values where int suffices.
5035 When checking for overlap, fix a typo: ZV was used where
5036 ZV_BYTE was intended.
5037 (Fwrite_region): Don't assume off_t fits into 'long'.
5038 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5039
ecfc0a49
MA
50402011-09-05 Michael Albinus <michael.albinus@gmx.de>
5041
5042 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5043
6511acf2 50442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5045
0999621a 5046 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5047
5048 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5049 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5050 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5051 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5052 (modify_event_symbol): Do not assume that the length of
5053 name_alist_or_stem is safe to alloca and fits in int.
5054 (Fexecute_extended_command): Likewise for function name and binding.
5055 (Frecursion_depth): Wrap around reliably on integer overflow.
5056 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5057 since some callers pass EMACS_INT values.
5058 (Fsingle_key_description): Don't crash if symbol name contains more
5059 than MAX_ALLOCA bytes.
5060 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5061 (get_minibuffer): Arg is now EMACS_INT, not int.
5062 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5063 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5064 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5065
2be7d702
PE
5066 * dbusbind.c (signature_cat): New function.
5067 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5068 Do not overrun buffer; instead, report string overflow.
5069
9d1df220
PE
5070 * dispnew.c (add_window_display_history): Don't overrun buffer.
5071 Truncate instead; this is OK since it's just a log.
5072
33ef5c64
PE
5073 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5074 even if the time zone offset is outlandishly large.
5075 Don't mishandle offset == INT_MIN.
5076
66c6fdd5
PE
5077 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5078 when creating daemon; the previous buffer-overflow check was incorrect.
5079
d749b01b
PE
5080 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5081 which has the guts of the old verror function.
5082
b5cd1905
PE
5083 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5084 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5085
6e1a67fb
PE
5086 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5087 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5088 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5089 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5090 length of string rather than counting it via multiple sprintfs;
5091 that's simpler and more reliable.
c21721cc
PE
5092 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5093 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5094 sprintf, in case result does not fit in int.
5095
c57b67fc
PE
5096 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5097 (fontset_from_font): Print it.
5098
8a401434
PE
5099 * frame.c (tty_frame_count): Now printmax_t, not int.
5100 (make_terminal_frame, set_term_frame_name): Print it.
5101 (x_report_frame_params): In X, window IDs are unsigned long,
5102 not signed long, so print them as unsigned.
5103 (validate_x_resource_name): Check for implausibly long names,
5104 and don't assume name length fits in 'int'.
5105 (x_get_resource_string): Don't blindly alloca invocation name;
5106 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5107 not fit in int.
5108
6e1a67fb
PE
5109 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5110 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5111 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5112
0df02bf3
PE
5113 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5114 Use esprintf, not sprintf, in case result does not fit in int.
5115
48e30793
PE
5116 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5117 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5118 it as a large positive number.
5119 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5120 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5121
a66ff6d8
PE
5122 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5123 in case result does not fit in int.
5124
aca216ff
PE
5125 * print.c (float_to_string): Detect width overflow more reliably.
5126 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5127 buffer overrun. Don't assume list length fits in 'int'. Treat
5128 print length of 0 as 0, not as infinity; to be consistent with other
5129 uses of print length in this function. Don't overflow print length
5130 index. Don't assume hash table size fits in 'long', or that
5131 vectorlike size fits in 'unsigned long'.
5132
31c286f7
PE
5133 * process.c (make_process): Use printmax_t, not int, to format
5134 process-name gensyms.
5135
55e5faa1
PE
5136 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5137
80f2e268
PE
5138 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5139 to avoid potential buffer overrun.
5140
670741ab
PE
5141 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5142 if X resource line is longer than 512 bytes.
5143
b7163a50
PE
5144 * xfns.c (x_window): Make sprintf buffer a bit bigger
5145 to avoid potential buffer overrun.
5146
ae58ff1f
PE
5147 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5148
c43c8a6a
PE
5149 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5150
3f8236f4
PE
51512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5152
53e9fe90 5153 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5154 Without these, Emacs silently mishandles large integers sometimes.
5155 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5156 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5157
6511acf2
PE
5158 * xdisp.c (try_window_id): Check Emacs fixnum range before
5159 converting to 'int'.
806add1d 5160
6511acf2 5161 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5162 Check that an Emacs fixnum is in range before assigning it to 'int'.
5163 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5164 values converted from Emacs fixnums.
5165 (Frecenter): Don't wrap around a line count if it is out of 'int'
5166 range; instead, treat it as an extreme value.
5167 (Fset_window_configuration, compare_window_configurations):
5168 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5169
6511acf2
PE
5170 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5171 that can exceed INT_MAX. Check that EMACS_INT value is in range
5172 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5173 (match_limit): Don't assume that a fixnum can fit in 'int'.
5174
6511acf2 5175 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5176 exceed INT_MAX.
5177
6511acf2 5178 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5179 (Fvertical_motion): Don't wrap around LINES values that don't fit
5180 in 'int'. Instead, treat them as extreme values. This is good
5181 enough for windows, which can't have more than INT_MAX lines anyway.
5182
fcb901a7
LMI
51832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5184
0f2f6b6d
LMI
5185 * Require libxml/parser.h to avoid compilation warning.
5186
fcb901a7
LMI
5187 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5188
5189 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5190 since this reportedly can destroy thread storage.
5191
6e20a0d4
CY
51922011-08-30 Chong Yidong <cyd@stupidchicken.com>
5193
5194 * syntax.c (find_defun_start): Update all cache variables if
5195 exiting early (Bug#9401).
5196
148ae00e
EZ
51972011-08-30 Eli Zaretskii <eliz@gnu.org>
5198
f6cfbd8f
EZ
5199 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5200
148ae00e
EZ
5201 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5202 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5203 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5204
5205 * term.c (tty_append_glyph): New function.
5206 (produce_stretch_glyph): Static function and its prototype deleted.
5207
a66cfb1c
SM
5208 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5209 Add prototypes.
148ae00e 5210
c4a07a4c
PE
52112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5212
5213 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5214 when checking :margin (Bug#9390).
5215 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5216 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5217 so that the name doesn't mislead. All uses changed.
5218
6bc8cd65
JB
52192011-08-28 Johan Bockgård <bojohan@gnu.org>
5220
5221 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5222 set_tty_hooks.
5223
dca4927e
EZ
52242011-08-27 Eli Zaretskii <eliz@gnu.org>
5225
5226 * xdisp.c (move_it_to): Don't bail out early when reaching
5227 position beyond to_charpos, if we are scanning backwards.
5228 (move_it_vertically_backward): When DY == 0, make sure we get to
5229 the first character in the line after the newline.
5230
f2cad773
PE
52312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5232
5233 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5234 (ccl_driver): Do not generate an out-of-range pointer.
5235 (Fccl_execute_on_string): Remove unnecessary check for
5236 integer overflow, noted by Stefan Monnier in
5237 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5238 Remove a FIXME that didn't need fixing.
5239 Simplify the newly-introduced buffer reallocation code.
5240
0cae2cdb
JB
52412011-08-27 Juanma Barranquero <lekktu@gmail.com>
5242
5243 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5244
5fc295a4 52452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5246
70c60eb2 5247 Integer and memory overflow issues (Bug#9196).
726e0ab1 5248
d31850da
PE
5249 * doc.c (get_doc_string): Rework so that
5250 get_doc_string_buffer_size is the actual buffer size, rather than
5251 being 1 less than the actual buffer size; this makes xpalloc more
5252 convenient.
5253
a69fbedb
PE
5254 * image.c (x_allocate_bitmap_record, cache_image):
5255 * xselect.c (Fx_register_dnd_atom):
5256 Simplify previous changes by using xpalloc.
5257
fe5c5d37
PE
5258 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5259 since either will do and ptrdiff_t is convenient with xpalloc.
5260
0065d054
PE
5261 * charset.c (charset_table_size)
5262 (struct charset_sort_data.priority): Now ptrdiff_t.
5263 (charset_compare): Don't overflow if priorities differ greatly.
5264 (Fsort_charsets): Don't assume list length fits in int.
5265 Check for size-calculation overflow when allocating sort data.
5266 (syms_of_charset): Allocate an initial charset table that is
5267 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5268
5269 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5270
5271 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5272 The actual value is always <= INT_MAX, and leaving it unsigned made
5273 overflow checking harder.
5274
5275 * dispextern.h (struct glyph_matrix.rows_allocated)
5276 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5277 with xpalloc. The values are still always <= INT_MAX.
5278
5279 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5280
5281 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5282 (SAFE_NALLOCA): New macro.
5283
5284 * region-cache.c (struct boundary.pos, find_cache_boundary)
5285 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5286 (set_cache_region, invalidate_region_cache)
5287 (revalidate_region_cache, know_region_cache, region_cache_forward)
5288 (region_cache_backward, pp_cache):
5289 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5290 so that ptrdiff_t * can be passed to xpalloc.
5291 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5292 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5293 (pp_cache): Don't assume cache_len fits in int.
5294 * region-cache.h: Adjust extern decls to match.
5295
5296 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5297 EMACS_INT, since either will do, for xpalloc.
5298
5299 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5300 (xnmalloc, xnrealloc, xpalloc): New functions.
5301
726e0ab1
PE
5302 * bidi.c (bidi_shelve_header_size): New constant.
5303 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5304 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5305
51f30bc5 5306 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5307 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5308 (overlay_strings):
5309 Don't update size of array until after memory allocation succeeds,
5310 because xmalloc/xrealloc may not return.
0065d054
PE
5311 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5312 now that we have proper integer overflow checking.
5313 (record_overlay_string, overlay_strings): Catch overflows when
5314 calculating size of overlay_str_buf.
726e0ab1 5315
0065d054
PE
5316 * callproc.c (Fcall_process): Check for size overflow when
5317 calculating size of args2.
5318 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5319 Normally we prefer signed values, but sticking with ptrdiff_t would
5320 require adding more-complicated checks.
726e0ab1
PE
5321
5322 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5323 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5324 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5325 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5326
5327 * character.c (Fstring): Check for size-calculation overflow.
5328
5329 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5330 unnecessary integer overflow. Check for size overflow.
5331 (encode_coding_object): Don't update size until xmalloc succeeds.
5332
5333 * composite.c (get_composition_id): Check for overflow in glyph
5334 length calculations.
5335
5336 Integer and memory overflow fixes for display code.
5337 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5338 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5339 (scrolling_window): Check for overflow in size calculations.
5340 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5341 Don't assume glyph table len fits in int.
5342 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5343 (row_table_size): Now ptrdiff_t, not int.
5344 (scrolling_window): Avoid overflow in size calculations.
5345 Don't update size until allocation succeeds.
5346 * fns.c (concat): Check for overflow in size calculations.
5347 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5348 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5349 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5350
5351 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5352 (get_doc_string): Check for size calculation overflow.
5353 Don't update size until allocation succeeds.
5354 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5355 EMACS_INT, where ptrdiff_t will do.
5356 (Fsubstitute_command_keys): Check for string overflow.
5357
5358 * editfns.c (set_time_zone_rule): Don't assume environment length
5359 fits in int.
5360 (message_length): Now ptrdiff_t, not int.
5361 (Fmessage_box): Don't update size until allocation succeeds.
5362 Don't assume message length fits in int.
5363 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5364
0065d054
PE
5365 * emacs.c (main): Do not reallocate argv, since there is a null at
5366 the end that can be overwritten, and this way there's no need to
5367 worry about size-calculation overflow.
5368 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5369
5370 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5371 alloc succeeds.
5372 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5373
5374 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5375 (x_set_scroll_bar_width, x_figure_window_size):
5376 Check for integer overflow.
5377 (x_set_alpha): Do not assume XINT fits in int.
5378
5379 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5380 This is for the members text_lines, text_cols, total_lines, total_cols,
5381 where the system imposes an 'int' limit.
5382
5383 * fringe.c (Fdefine_fringe_bitmap):
5384 Don't update size until alloc works.
5385
5386 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5387 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5388
5389 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5390 Check for size-calculation overflow.
5391 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5392 do, as we prefer signed integers.
5393 (id_to_widget.max_size, id_to_widget.used)
5394 (xg_store_widget_in_map, xg_remove_widget_from_map)
5395 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5396 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5397 Use and return ptrdiff_t, not int.
5398 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5399 * gtkutil.h: Change prototypes to match the above.
5400
5401 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5402 are duplicate now that they've been promoted to lisp.h.
5403 (x_allocate_bitmap_record, x_alloc_image_color)
5404 (make_image_cache, cache_image, xpm_load):
5405 Don't update size until alloc is done.
5406 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5407 (x_detect_edges):
3256efce 5408 Check for size calculation overflow.
726e0ab1
PE
5409 (ct_colors_allocated_max): New constant.
5410 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5411 overflow.
3256efce 5412
726e0ab1
PE
5413 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5414 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5415 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5416 Use ptrdiff_t, not int, to count maps.
5417 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5418 calculations. Don't update size until allocation succeeds.
5419 Redo calculations to avoid overflow.
726e0ab1
PE
5420 * keyboard.h: Change prototypes to match the above.
5421
5422 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5423 to count maps.
5424 (current_minor_maps): Check for size calculation overflow.
5425 * keymap.h: Change prototypes to match the above.
5426
5427 * lread.c (read1, init_obarray): Don't update size until alloc done.
5428
5429 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5430 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5431
726e0ab1
PE
5432 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5433 Now ptrdiff_t, not int.
5434 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5435 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5436
5437 * process.c (Fnetwork_interface_list): Check for overflow
5438 in size calculation.
5439
5440 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5441
5442 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5443 overflow. Don't bother calling xmalloc when xrealloc will do.
5444
5445 * search.c (Freplace_match): Check for size calculation overflow.
5446 (Fset_match_data): Don't assume list lengths fit in 'int'.
5447
5448 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5449 for command line length. Do not attempt to address one before the
5450 beginning of an array, as that's not portable.
5451
5452 * term.c (max_frame_lines): Remove; unused.
5453 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5454 not int.
5455 (encode_terminal_code, calculate_costs): Check for size
5456 calculation overflow.
5457 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5458 table lengths and related sizes. Don't update size until alloc
5459 done. Redo calculations to avoid overflow.
5460 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5461
5462 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5463 subtracting pointers.
5464 (gobble_line): Check for overflow more carefully. Don't update size
5465 until alloc done.
5466
5467 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5468 Don't update size until alloc done.
5469 Redo size calculations to avoid overflow.
5470 Check for size calculation overflow.
0065d054 5471 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5472
5473 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5474 Use ptrdiff_t, not int, for sizes.
5475 (store_mode_line_noprop_char): Don't update size until alloc done.
5476
0065d054
PE
5477 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5478 Use ptrdiff_t, not int, for sizes.
5479 (Finternal_make_lisp_face, cache_face):
5480 Check for size calculation overflow.
5481 (cache_face): Treat size calculation overflows as if they were
5482 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5483
5484 * xfns.c (x_encode_text, x_set_name_internal)
5485 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5486 sizes, since they can exceed INT_MAX in size. Check for size
5487 calculation overflow.
5488
0065d054
PE
5489 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5490 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5491 Don't update size until alloc done.
5492
0065d054 5493 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5494 as sprintf is limited to int lengths.
1d526e2f 5495
252c5ee1
PE
5496 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5497 (X_LONG_MIN): New macros.
864d7ce7
PE
5498 Use them to make the following changes clearer.
5499 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5500 This change doesn't affect the value now, but it may help remind
5501 future maintainers not to raise the value too much later.
5502 (SELECTION_QUANTUM): Remove, replacing with ...
5503 (selection_quantum): ... new function, which avoids overflow.
5504 All uses changed.
5505 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5506 assumption that selection length fits in 'int'.
5507 (x_reply_selection_request, x_handle_selection_request)
5508 (x_get_window_property, receive_incremental_selection)
5509 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5510 (lisp_data_to_selection_data, clean_local_selection_data):
5511 Use ptrdiff_t, not int, to record length of selection.
5512 (x_reply_selection_request, x_get_window_property)
5513 (receive_incremental_selection, x_property_data_to_lisp):
5514 Redo calculations to avoid overflow.
5515 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5516 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5517 something.
5518 (x_get_window_property, receive_incremental_selection)
5519 (lisp_data_to_selection_data, x_property_data_to_lisp):
5520 Check for size-calculation overflow.
5521 (x_get_window_property, receive_incremental_selection)
5522 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5523 Don't store size until memory allocation succeeds.
5524 (x_get_window_property): Plug memory leak on memory exhaustion.
5525 Don't double-block input; malloc is safe here. Don't assume 2**34
5526 - 4 fits in unsigned long. Add an xassert to check
5527 XGetWindowProperty overflow. Be more careful about overflow
5528 calculations, and distinguish size from memory overflow better.
5529 (receive_incremental_selection): When tracing, don't assume
5530 unsigned int is less than INT_MAX.
5531 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5532 harmful) conversions of unsigned short to int.
5533 (lisp_data_to_selection_data): Don't assume that integers
5534 in the range -65535 through -1 fit in an X unsigned short.
5535 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5536 result parameters unless successful. Rely on cons_to_unsigned
5537 to report problems with elements; the old code wasn't right anyway.
5538 (x_check_property_data): Check for int overflow; we cannot use
5539 a wider type due to X limits.
5540 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5541
726e0ab1 5542 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5543
0065d054
PE
5544 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5545 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5546 (x_color_cells): Don't store size until memory allocation succeeds.
5547 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5548 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5549 (x_term_init): Don't assume length fits in int (sprintf is limited
5550 to int size).
bc18e09d 5551
ebfa62c0
PE
5552 Use ptrdiff_t for composition IDs.
5553 * character.c (lisp_string_width):
5554 * composite.c (composition_table_size, n_compositions)
5555 (get_composition_id, composition_gstring_from_id):
5556 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5557 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5558 * window.c (Frecenter):
5559 Use ptrdiff_t, not int, for composition IDs.
5560 * composite.c (get_composition_id): Check for integer overflow.
5561 * composite.h: Adjust prototypes to match the above changes.
5562
d3411f89
PE
5563 Use ptrdiff_t for hash table indexes.
5564 * category.c (hash_get_category_set):
5565 * ccl.c (ccl_driver):
5566 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5567 * coding.c (coding_system_charset_list, detect_coding_system):
5568 * coding.h (struct coding_system.id):
5569 * composite.c (get_composition_id, gstring_lookup_cache):
5570 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5571 * image.c (xpm_get_color_table_h):
5572 * lisp.h (hash_lookup, hash_put):
5573 * minibuf.c (Ftest_completion):
5574 Use ptrdiff_t for hash table indexes, not int (which is too
5575 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5576 32-bit --with-wide-int hosts).
5577
e097a6fa
PE
5578 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5579 Add a FIXME comment about memory leaks.
5580 (syms_of_charset): Don't assume xmalloc returns.
5581
5637687f
PE
5582 Don't assume that stated character widths fit in int.
5583 * character.c (Fchar_width, c_string_width, lisp_string_width):
5584 * character.h (CHAR_WIDTH):
5585 * indent.c (MULTIBYTE_BYTES_WIDTH):
5586 Use sanitize_char_width to avoid undefined and/or bad behavior
5587 with outlandish widths.
a66cfb1c 5588 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5589 now that we have two such functions. All uses changed.
5590 (sanitize_char_width): New inline function.
5591
a2271ba2
PE
5592 Don't assume that tab-width fits in int.
5593 * character.h (sanitize_width): New inline function.
5594 (SANE_TAB_WIDTH): New macro.
5595 (ASCII_CHAR_WIDTH): Use it.
5596 * indent.c (sane_tab_width): Remove. All uses replaced by
5597 SANE_TAB_WIDTH (current_buffer).
5598 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5599
18c52557
PE
5600 * fileio.c: Integer overflow issues with file modes.
5601 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5602
caeeedc1
PE
5603 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5604 Remove unreachable code.
5605 (read_hex, load_charset_map_from_file): Check for integer overflow.
5606
6df6ae42 5607 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5608 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5609 (x_send_scroll_bar_event): Likewise. Check that the size does not
5610 exceed limits imposed by XClientMessageEvent, as well as the usual
5611 ptrdiff_t and size_t limits.
5612
b13995db
PE
5613 * keyboard.c: Overflow, signedness and related fixes.
5614 (make_lispy_movement): Use same integer type in forward decl
5615 that is used in the definition.
5616 (read_key_sequence, keyremap_step):
5617 Change bufsize argument back to int, undoing my 2011-03-30 change.
5618 We prefer signed types, and int is wide enough here.
5619 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5620 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5621 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5622 length, not size_t. Use ptrdiff_t for index, not int.
5623 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5624 possibility of integer overflow.
5625
13464394
PE
5626 Overflow, signedness and related fixes for images.
5627
5628 * dispextern.h (struct it.stack[0].u.image.image_id)
5629 (struct_it.image_id, struct image.id, struct image_cache.size)
5630 (struct image_cache.used, struct image_cache.ref_count):
5631 * gtkutil.c (update_frame_tool_bar):
5632 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5633 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5634 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5635 * nsmenu.m (update_frame_tool_bar):
5636 * xdisp.c (calc_pixel_width_or_height):
5637 * xfns.c (image_cache_refcount):
5638 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5639 on typical 64-bit hosts.
5640
5641 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5642 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5643 Omit unnecessary casts to int.
5644 (parse_image_spec): Check that integers fall into 'int' range
5645 when the callers expect that.
5646 (image_ascent): Redo ascent calculation to avoid int overflow.
5647 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5648 (lookup_image): Remove unnecessary tests.
5649 (xbm_image_p): Locals are now of int, not EMACS_INT,
5650 since parse_image_check makes sure they fit into int.
5651 (png_load, gif_load, svg_load_image):
5652 Prefer int to unsigned where either will do.
5653 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5654 old tiff_error_handler and tiff_warning_handler.
5655 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5656 stack buffer overflows. It uses only the features of vsnprintf
5657 that are common to both POSIX and native Microsoft.
5658 (tiff_error_handler, tiff_warning_handler): Use it.
5659 (tiff_load, gif_load, imagemagick_load_image):
5660 Don't assume :index value fits in 'int'.
5661 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5662 (imagemagick_load_image): Check that crop parameters fit into
5663 the integer types that MagickCropImage accepts. Don't assume
5664 Vimagemagick_render_type has a nonnegative value. Don't assume
5665 size_t fits in 'long'.
5666 (gs_load): Use printmax_t to print the widest integers possible.
5667 Check for integer overflow when computing image height and width.
5668
c11821d4
EZ
56692011-08-26 Eli Zaretskii <eliz@gnu.org>
5670
5671 * xdisp.c (redisplay_window): Don't force window start if point
5672 will be invisible in the resulting window. (Bug#9324)
5673
0c95fcf7
EZ
56742011-08-25 Eli Zaretskii <eliz@gnu.org>
5675
5676 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5677 the display spec is of the form `(space ...)'.
5678 (handle_display_spec): Return the value returned by
5679 handle_single_display_spec, not just 1 or zero.
5680 (handle_single_display_spec): If the display spec is of the form
5681 `(space ...)', and specifies display in the text area, return 2
5682 rather than 1.
fee65a97 5683 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5684 accurately, and prefer exact match for point under bidi.
5685 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5686
5687 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5688 into disp_prop; all users changed.
5689
5690 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5691 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5692 for the text covered by the display property.
5693
e4ed06f1
CY
56942011-08-25 Chong Yidong <cyd@stupidchicken.com>
5695
5696 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5697 Change return value to nil.
5698 (Frecord_buffer): Delete unused function.
5699
f67cdd7f
EZ
57002011-08-24 Eli Zaretskii <eliz@gnu.org>
5701
5980d4c6
EZ
5702 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5703 buffers, return left-to-right.
8610fe8b
EZ
5704 (set_cursor_from_row): Consider candidate row a win if its glyph
5705 represents a newline and point is on that newline. Fixes cursor
5706 positioning on the newline at EOL of R2L text within L2R
5707 paragraph, and vice versa.
5708 (try_cursor_movement): Check continued rows, in addition to
5709 continuation rows. Fixes unwarranted scroll when point enters a
5710 continued line of R2L text within an L2R paragraph, or vice versa.
5711 (cursor_row_p): Consider the case of point being equal to
5712 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5713 from the end of a short line to the beginning of a continued line
5714 of R2L text within L2R paragraph.
5715 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5716 composed characters.
5980d4c6 5717
f67cdd7f
EZ
5718 * bidi.c (bidi_check_type): Use xassert.
5719 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5720 members.
5721
bca633fb
EZ
57222011-08-23 Eli Zaretskii <eliz@gnu.org>
5723
5724 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5725 a character.
5726
4a5885a7
CY
57272011-08-23 Chong Yidong <cyd@stupidchicken.com>
5728
5729 * nsfont.m (ns_otf_to_script): Fix typo.
5730
0902a04e
KH
57312011-08-22 Kenichi Handa <handa@m17n.org>
5732
5733 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5734 extra slot even if the purpose is char-code-property-table.
5735
1a2e6670
EZ
57362011-08-23 Eli Zaretskii <eliz@gnu.org>
5737
8ddde651
EZ
5738 * xdisp.c (redisplay_window): When computing centering_position,
5739 account for the height of the header line. (Bug#8874)
5740
425cc014
EZ
5741 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5742 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5743 candidate is selected by the mouse, and that candidate has a
5744 composed character under the mouse.
5745
1a2e6670
EZ
5746 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5747 coordinates reported by pos-visible-in-window-p for a composed
5748 character in column zero.
5749
8b76d6f8
SM
57502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5751
5752 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5753
dac347dd
EZ
57542011-08-22 Eli Zaretskii <eliz@gnu.org>
5755
5756 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5757 consider it a hit if to_charpos is anywhere in the range of the
5758 composed buffer positions.
5759
e013fb34
CY
57602011-08-22 Chong Yidong <cyd@stupidchicken.com>
5761
5762 * image.c (gif_load): Don't assume that each subimage has the same
5763 dimensions as the base image. Handle disposal method that is
5764 "undefined" by the gif spec (Bug#9335).
5765
bd1ba3e8
CY
57662011-08-20 Chong Yidong <cyd@stupidchicken.com>
5767
5768 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5769 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5770
54a1215b
EZ
57712011-08-19 Eli Zaretskii <eliz@gnu.org>
5772
823564e5
EZ
5773 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5774 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5775 from an Org mode buffer to a Speedbar frame.
5776
54a1215b
EZ
5777 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5778 a composition, take its buffer position from IT->cmp_it.charpos.
5779 Fixes cursor positioning at the beginning of a line that begins
5780 with a composed character.
5781
9778ebcc
EZ
57822011-08-18 Eli Zaretskii <eliz@gnu.org>
5783
0be6ee06
EZ
5784 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5785 character bidirectional type, use STRONG_L instead. Fixes crashes
5786 in a buffer produced by `describe-categories'.
5787
9778ebcc
EZ
5788 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5789 members before the level stack, so they would be saved and
5790 restored when copying iterator state. Fixes incorrect reordering
5791 around TABs covered by display properties.
5792
156bffbe
AS
57932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5794
6b02f655 5795 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5796
72ad093b
CY
57972011-08-17 Chong Yidong <cyd@stupidchicken.com>
5798
5799 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5800 (internal_condition_case_2, internal_condition_case_n):
5801 Remove unnecessary aborts (Bug#9081).
72ad093b 5802
35774242
EZ
58032011-08-17 Eli Zaretskii <eliz@gnu.org>
5804
5805 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5806 has no `load' handler, try opening the file locally. (Bug#9311)
5807
db76dd85
KB
58082011-08-16 Ken Brown <kbrown@cornell.edu>
5809
5810 * gmalloc.c: Expand comment.
5811
b215eee5
EZ
58122011-08-16 Eli Zaretskii <eliz@gnu.org>
5813
5814 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5815 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5816
a4579d33
KB
58172011-08-16 Ken Brown <kbrown@cornell.edu>
5818
5819 Fix memory allocation problems in Cygwin build (Bug#9273).
5820
5821 * unexcw.c ( __malloc_initialized): Declare external variable.
5822 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5823
8b76d6f8
SM
5824 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5825 New variables.
a4579d33
KB
5826 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5827 dumped emacs.
5828 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5829 in the static heap.
5830 [CYGWIN] (special_realloc): New function.
5831 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5832 requests to realloc storage in the static heap.
5833
3ebec551
PE
58342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5835
5836 * bidi.c (bidi_initialize): Remove unused local.
5837
9fd8be00
EZ
58382011-08-15 Eli Zaretskii <eliz@gnu.org>
5839
6b02f655
SM
5840 * bidimirror.h:
5841 * biditype.h: Remove file.
5842 * makefile.w32-in ($(BLD)/bidi.$(O)):
5843 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5844
5845 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5846
5847 * chartab.c: Improve commentary for the uniprop_table API.
5848
32413314
EZ
5849 * bidi.c (bidi_paragraph_init): Support zero value of
5850 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5851 (bidi_initialize): Use uniprop_table instead of including
5852 biditype.h and bidimirror.h.
32413314 5853
9fd8be00
EZ
5854 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5855 coordinates of the iterator when restoring from ppos_it.
5856 (Bug#9296)
5857
5cf2b69b
KH
58582011-08-14 Kenichi Handa <handa@m17n.org>
5859
5860 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5861 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5862
daf17d00
EZ
58632011-08-14 Eli Zaretskii <eliz@gnu.org>
5864
5865 * xdisp.c (move_it_in_display_line_to): Don't invoke
5866 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5867 ppos_it. Fixes vertical cursor motion when line beginning is
5868 covered by an image. (Bug#9296)
5869
08e3161a
JD
58702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5871
5872 * nsterm.h (ns_run_ascript): Declare.
5873 (NSAPP_DATA2_RUNASSCRIPT): Define.
5874
5875 * nsfns.m (as_script, as_result, as_status): New static variables.
5876 (ns_run_ascript): New function.
5e617bc2 5877 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5878 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5879 the event loop. Get status from as_status (Bug#7276).
5880
5881 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5882 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5883 the event loop (Bug#7276).
5884
a3720aa2
AS
58852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5886
5887 * gnutls.c (QCgnutls_bootprop_priority)
5888 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5889 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5890 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5891 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5892 (QCgnutls_bootprop_verify_hostname_error)
5893 (QCgnutls_bootprop_callbacks_verify): Rename from
5894 Qgnutls_bootprop_..., all uses changed.
5895
5896 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5897 uses changed.
5898
0a0d27fb
PE
58992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5900
19d5c50c
PE
5901 * xfaces.c (Qframe_set_background_mode): Now static.
5902 * dispextern.h (Qframe_set_background_mode): Remove decl.
5903
0a0d27fb
PE
5904 * process.c (Fnetwork_interface_info): Declare local only if needed.
5905
377538cb
JD
59062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5907
5908 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5909 (Fnetwork_interface_list): Allocate in increments of bytes instead
5910 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5911 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5912 sockaddr.
5913 (struct ifflag_def): notrailers is smart on OSX.
5914 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5915 Get hardware address with getifaddrs if available.
5916
08fff70c
EZ
59172011-08-12 Eli Zaretskii <eliz@gnu.org>
5918
5919 * xdisp.c (iterate_out_of_display_property): xassert that
5920 IT->position is set to within IT->object's boundaries. Break from
5921 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5922 when IT->position is set up wrongly due to some bug.
5923 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5924 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5925 entry. Force push_it to save on the stack the current
5926 buffer/string position, to be restored by pop_it. Fix flags in
5927 the iterator structure wrt the object coming from a display
5928 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5929 properties. (Bug#9284)
5930
7be1c708 59312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5932
7be1c708
CY
5933 * fontset.c (fontset_get_font_group): Add proper type checks.
5934 (Bug#9172)
aac0c6e3 5935
7be1c708 59362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5937
7be1c708
CY
5938 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5939 and LC_VERSION_MIN_MACOSX.
5940 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5941 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5942
97bb72a6
EZ
59432011-08-08 Eli Zaretskii <eliz@gnu.org>
5944
5945 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5946 no-display-properties-and-no-overlays under bidi display.
5947 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5948 properties and overlays.
97bb72a6 5949
d5617611
CY
59502011-08-08 Chong Yidong <cyd@stupidchicken.com>
5951
37e11a63
CY
5952 * editfns.c (Fset_time_zone_rule): Document relationship with the
5953 setenv function.
5954
d5617611
CY
5955 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5956 the font entity extracted from the cache (Bug#8109).
5957
58872834
CY
59582011-08-07 Chong Yidong <cyd@stupidchicken.com>
5959
5960 * composite.c (autocmp_chars): Don't reset point. That is done by
5961 restore_point_unwind (Bug#5984).
5962
75bfc667
JL
59632011-08-07 Juri Linkov <juri@jurta.org>
5964
5965 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5966 to show the arg `TIME' instead of `TIMEVAL'.
5967
d1410150
EZ
59682011-08-06 Eli Zaretskii <eliz@gnu.org>
5969
5970 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5971 display property strides EOL and includes a newline, as in
5972 longlines-mode. (Bug#9254)
75b771e4
EZ
5973 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5974 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5975
5976 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5977 is non-zero, even if the data buffer is NULL. Fixes a crash in
5978 vertical-motion with longlines-mode. (Bug#9254)
5979
35928349
EZ
59802011-08-05 Eli Zaretskii <eliz@gnu.org>
5981
ec7cc85b
EZ
5982 * bidi.c <bidi_cache_total_alloc>: Now static.
5983 (bidi_initialize): Initialize bidi_cache_total_alloc.
5984
8b76d6f8 5985 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5986 cache. (Bug#9221)
5987
5988 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5989 amount allocated this far in `bidi_cache_total_alloc'.
5990 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5991 non-zero, only free the data buffer without restoring the cache
5992 contents. All callers changed.
5993
5994 * dispextern.h (bidi_unshelve_cache): Update prototype.
5995
5996 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5997 (move_it_in_display_line, move_it_to)
5998 (move_it_vertically_backward, move_it_by_lines): Replace the call
5999 to xfree to an equivalent call to bidi_unshelve_cache.
6000 (move_it_in_display_line_to): Fix logic of returning
412b6358 6001 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6002
e2e2423b
EZ
60032011-08-05 Eli Zaretskii <eliz@gnu.org>
6004
6005 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6006 came from a string character with a `cursor' property. (Bug#9229)
6007
ae9e757a
JD
60082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6009
6010 * Makefile.in (LIB_PTHREAD): New variable.
6011 (LIBES): Add LIB_PTHREAD (Bug#9216).
6012
6013 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6014 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6015
213bd7f2
AS
60162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6017
6b02f655 6018 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6019
99aaf75f
JD
60202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6021
6022 * xterm.c (x_find_topmost_parent): New function.
6023 (x_set_frame_alpha): Find topmost parent window with
6024 x_find_topmost_parent and set the property there also (bug#9181).
6025 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6026
c74e9d86
PE
60272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 * callproc.c (Fcall_process): Avoid vfork clobbering
6030 the local vars buffer, coding_systems, current_dir.
6031
640c8776
SM
60322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6033
6034 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6035
f26d0e4c
PE
60362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6037
8a10d76c
PE
6038 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6039 so that it is not optimized away.
6040
f26d0e4c
PE
6041 * xdisp.c (compute_display_string_pos): Remove unused local.
6042
55439c61
EZ
60432011-08-02 Eli Zaretskii <eliz@gnu.org>
6044
6045 Fix slow cursor motion and scrolling in large buffers with
6046 selective display, like Org Mode buffers. (Bug#9218)
6047
6048 * dispextern.h (struct bidi_it): New member disp_prop_p.
6049
6050 * xdisp.c: Remove one-slot cache of display string positions.
6051 (compute_display_string_pos): Accept an additional argument
5e617bc2 6052 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6053 for a display string or property. If found, set DISP_PROP_P
6054 non-zero.
6055
6056 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6057 DISP_PROP_P, and pass it to compute_display_string_pos.
6058 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6059 non-zero. All callers of bidi_fetch_char changed.
6060
fb33fa43
SM
60612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6062
6063 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6064
b099e063
DM
60652010-12-03 Don March <don@ohspite.net>
6066
6067 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6068 last character M-[char] is translated to ESC [char] (bug#7541).
6069
5cc7f7af
KH
60702011-08-02 Kenichi Handa <handa@m17n.org>
6071
d0fffa3f 6072 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6073
6074 * chartab.c (uniprop_table): Make it non-static.
6075
525d5e6e
EZ
60762011-08-01 Eli Zaretskii <eliz@gnu.org>
6077
6078 * xdisp.c (forward_to_next_line_start): Accept additional argument
6079 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6080 on the newline.
6081 (reseat_at_next_visible_line_start): Use the bidi iterator state
6082 returned by forward_to_next_line_start to restore the state of
6083 it->bidi_it after backing up to previous newline. (Bug#9212)
6084
31011111
AS
60852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6086
6087 * regex.c (re_comp): Protoize.
6088 (re_exec): Fix return type.
6089 (regexec): Fix type of `ret'. (Bug#9203)
6090
476371c4
PE
60912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6092
e5d76069
PE
6093 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6094 This is needed if max-image-size is a floating-point number.
6095
9a79b20c
AS
60962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6097
6098 * print.c (print_object): Print empty symbol as ##.
6099
6100 * lread.c (read1): Read ## as empty symbol.
6101
d8c2fa78
AA
61022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6103
6104 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6105 setting frame foreground color (Bug#9175).
6106 (x_set_background_color): Likewise.
6107
ffe57a7a
AA
6108 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6109 contents (Bug#9176).
6110 (EmacsTooltip -init): Remove bezels and add shadows to
6111 tooltip windows.
6112
bf3492a5
AA
6113 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6114 or scroll bar (Bug#8470).
6115
d55e9c53
AA
6116 * nsfont.m (nsfont_open): Remove assignment to voffset and
6117 unnecessary vars hshink, expand, hd, full_height, min_height.
6118 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6119
6120 * nsterm.h (nsfont_info): Remove voffset field.
6121
d8c2fa78 61222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6123
6124 Implement strike-through and overline on NextStep (Bug#8863).
6125
6126 * nsfont.m (nsfont_open): Use underline position provided by font,
6127 instead of hard-coded value of 2.
6128 (nsfont_draw): Call ns_draw_text_decoration instead.
6129
6130 * nsterm.h: Add declaration for ns_draw_text_decoration.
6131
6132 * nsterm.m (ns_draw_text_decoration): New function for drawing
6133 underline, overline, and strike-through.
6134 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6135 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6136 accommodate underlining, etc.
4843aac3 6137
4cc60b9b
EZ
61382011-07-28 Eli Zaretskii <eliz@gnu.org>
6139
bc7ece87
EZ
6140 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6141 default.
4cc60b9b 6142
476371c4
PE
61432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6144
66606eea
PE
6145 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6146 Without this fix, if a signal arrives just after memory fills up,
6147 'malloc' might be invoked reentrantly.
6148
476371c4
PE
6149 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6150 In other words, assume that every image size is allowed, on non-X
6151 hosts. This assumption is probably wrong, but it lets Emacs compile.
6152
f3fcc40d
AS
61532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6154
6155 * regex.c (re_iswctype): Convert return values to boolean.
6156
350c992f
EZ
61572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6158
6159 * xdisp.c (compute_display_string_pos): Don't use cached display
6160 string position if the buffer had its restriction changed.
6161 (Bug#9184)
6162
5266b4bb
PE
61632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6164
6165 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6166
2573a837 61672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6168
41f55ccd 6169 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6170
39e378da
PE
6171 * bidi.c: Integer size and overflow fixes.
6172 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6173 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6174 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6175 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6176 (bidi_find_other_level_edge):
6177 Use ptrdiff_t instead of EMACS_INT where either will do.
6178 This works better on 32-bit hosts configured --with-wide-int.
6179 (bidi_cache_ensure_space): Check for size-calculation overflow.
6180 Use % rather than repeated addition, for better worst-case speed.
6181 Don't set bidi_cache_size until after xrealloc returns, because it
6182 might not return.
6183 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6184 (bidi_cache_ensure_space): Also check that the bidi cache size
6185 does not exceed that of the largest Lisp string or buffer. See Eli
6186 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6187
5e927815
PE
6188 * alloc.c (__malloc_size_t): Remove.
6189 All uses replaced by size_t. See Andreas Schwab's note
6190 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6191
ca4aa935
PE
6192 * image.c: Improve checking for integer overflow.
6193 (check_image_size): Assume that f is nonnull, since
6194 it is always nonnull in practice. This is one less thing to
6195 worry about when checking for integer overflow later.
6196 (x_check_image_size): New function, which checks for integer
6197 overflow issues inside X.
6198 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6199 This removes the need for a memory_full check.
6200 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6201 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6202 (xbm_read_bitmap_data): Change locals back to 'int', since
6203 their values must fit in 'int'.
6204 (xpm_load_image, png_load, tiff_load):
6205 Invoke x_create_x_image_and_pixmap earlier,
6206 to avoid much needless work if the image is too large.
6207 (tiff_load): Treat overly large images as if
6208 x_create_x_image_and_pixmap failed, not as malloc failures.
6209 (gs_load): Use x_check_image_size.
6210
5f8f9cc2
PE
6211 * gtkutil.c: Omit integer casts.
6212 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6213 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6214
5adf60bc
PE
6215 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6216
c8907a93
PE
6217 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6218 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6219 would wrongly return t on a 64-bit host.
6220
e3c25c68
PE
6221 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6222 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6223 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6224 and therefore cause GCC to emit a bogus diagnostic in some cases.
6225
3f791afe
PE
6226 * image.c: Integer signedness and overflow and related fixes.
6227 This is not an exhaustive set of fixes, but it's time to
6228 record what I've got.
6229 (lookup_pixel_color, check_image_size): Remove redundant decls.
6230 (check_image_size): Don't assume that arbitrary EMACS_INT values
6231 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6232 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6233 (tiff_load, imagemagick_load_image):
6234 Check for overflow in size calculations.
6235 (x_create_x_image_and_pixmap): Remove unnecessary test for
6236 xmalloc returning NULL; that can't happen.
6237 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6238 (xpm_color_bucket): Use better integer hashing function.
6239 (xpm_cache_color): Don't possibly over-allocate memory.
6240 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6241 (gif_memory_source):
6242 Use ptrdiff_t, not int or size_t, to record sizes.
6243 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6244 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6245 either works, as we prefer signed integers.
6246 (tiff_read_from_memory, tiff_write_from_memory):
6247 Return tsize_t, not size_t, since that's what the TIFF API wants.
6248 (tiff_read_from_memory): Don't fail simply because the read would
6249 go past EOF; instead, return a short read.
6250 (tiff_load): Omit no-longer-needed casts.
6251 (Fimagemagick_types): Don't assume size fits into 'int'.
6252
3cc5a532
PE
6253 Improve hashing quality when configured --with-wide-int.
6254 * fns.c (hash_string): New function, taken from sxhash_string.
6255 Do not discard information about ASCII character case; this
6256 discarding is no longer needed.
6257 (sxhash-string): Use it. Change sig to match it. Caller changed.
6258 * lisp.h: Declare it.
6259 * lread.c (hash_string): Remove, since we now use fns.c's version.
6260 The fns.c version returns a wider integer if --with-wide-int is
6261 specified, so this should help the quality of the hashing a bit.
6262
b312a492
PE
6263 * emacs.c: Integer overflow minor fix.
6264 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6265 Define only if GNU_LINUX.
6266 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6267
dfd153ae
PE
6268 * dispnew.c: Integer signedness and overflow fixes.
6269 Remove unnecessary forward decls, that were a maintenance hassle.
6270 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6271 All uses changed.
6272 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6273 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6274 (prepare_desired_row, line_draw_cost):
6275 Use int, not unsigned, where either works.
6276 (save_current_matrix, restore_current_matrix):
6277 Use ptrdiff_t, not size_t, where either works.
6278 (init_display): Check for overflow more accurately, and without
6279 relying on undefined behavior.
6280
a81d11a3
PE
6281 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6282 Remove, replacing with the new symbols in lisp.h. All uses changed.
6283 * fileio.c (make_temp_name):
6284 * filelock.c (lock_file_1, lock_file):
6285 * xdisp.c (message_dolog):
6286 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6287 Use pMd etc. instead.
6288 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6289 replacing the pWIDE etc. symbols removed from editfns.c.
6290
3300e6fd
PE
6291 * keyboard.h (num_input_events): Now uintmax_t.
6292 This is (very slightly) less likely to mess up due to wraparound.
6293 All uses changed.
6294
fd05c7e9
PE
6295 * buffer.c: Integer signedness fixes.
6296 (alloc_buffer_text, enlarge_buffer_text):
6297 Use ptrdiff_t rather than size_t when either will do, as we prefer
6298 signed integers.
6299
903fe15d
PE
6300 * alloc.c: Integer signedness and overflow fixes.
6301 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6302 (__malloc_size_t): Default to size_t, not to int.
6303 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6304 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6305 Prefer ptrdiff_t to size_t when either would do, as we prefer
6306 signed integers.
6307 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6308 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6309 Now const. Initialize with values that are in range even if char
6310 is signed.
6311 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6312 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6313 These functions do the right thing with sizes > 2**32.
6314 (check_depth): Now ptrdiff_t, not int.
6315 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6316 Adjust to new way of storing sizes. Check for size overflow bugs
6317 in rest of code.
6318 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6319 slightly wrong anyway, as it missed one instance of
6320 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6321 (refill_memory_reserve): Omit needless cast to size_t.
6322 (mark_object_loop_halt): Mark as externally visible.
6323
ac82cc6a
PE
6324 * xselect.c: Integer signedness and overflow fixes.
6325 (Fx_register_dnd_atom, x_handle_dnd_message):
6326 Use ptrdiff_t, not size_t, since we prefer signed.
6327 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6328 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6329 x_dnd_atoms_size and x_dnd_atoms_length.
6330
c2d1e36d
PE
6331 * doprnt.c: Prefer signed to unsigned when either works.
6332 * eval.c (verror):
6333 * doprnt.c (doprnt):
6334 * lisp.h (doprnt):
6335 * xdisp.c (vmessage):
6336 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6337 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6338 prefer signed arithmetic to avoid comparison confusion.
6339 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6340 but is a bit tricky.
6341
0e926e56
PE
6342 Assume freestanding C89 headers, string.h, stdlib.h.
6343 * data.c, doprnt.c, floatfns.c, print.c:
6344 Include float.h unconditionally.
6345 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6346 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6347 * regex.c: Likewise for stddef.h, string.h.
6348 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6349 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6350 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6351 (STDC_HEADERS): Remove obsolete defines.
6352 * sysdep.c: Include limits.h unconditionally.
6353
9cfdb3ec
PE
6354 Assume support for memcmp, memcpy, memmove, memset.
6355 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6356 * regex.c (memcmp, memcpy):
6357 Remove; we assume C89 now.
6358
6359 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6360 (__malloc_safe_bcopy): Remove; no longer needed.
6361
cf950e6b 6362 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6363 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6364 well either way, and we prefer signed to unsigned.
6365
dbf38e02
LMI
63662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6367
6368 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6369 closes the connection while we're reading (bug#9182).
6370
d6f0886c 63712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6372
d6f0886c
JD
6373 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6374 are specified (Bug#9168).
24e0f6b1 6375
2eb1f9e6
PE
63762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6379 Found by GCC static checking and --with-wide-int on a 32-bit host.
6380
22381272 63812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6382
6383 * xdisp.c (compute_display_string_pos): Fix logic of caching
6384 previous display string position. Initialize cached_prev_pos to
6385 -1. Fixes slow-down at the beginning of a buffer.
6386
f25e39b4
EZ
63872011-07-24 Eli Zaretskii <eliz@gnu.org>
6388
6389 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6390 for attrs[LFACE_FONTSET_INDEX].
6391
04c4b52e
PE
63922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6393
6394 * xml.c (parse_region): Remove unused local
6395 that was recently introduced.
6396
c1734fbd
EZ
63972011-07-23 Eli Zaretskii <eliz@gnu.org>
6398
be18c5a5
EZ
6399 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6400 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6401
c1734fbd
EZ
6402 * xdisp.c (move_it_in_display_line_to): Record the best matching
6403 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6404 exit if none of the characters scanned was an exact match.
6405 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6406 when exact match is impossible due to invisible text, and the
6407 lines are truncated.
6408
a258d627
JD
64092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6410
6411 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6412 for OSX >= 10.7.
6413
b6d5a689
EZ
64142011-07-22 Eli Zaretskii <eliz@gnu.org>
6415
0f74f785
EZ
6416 Fix a significant slow-down of cursor motion with C-n, C-p,
6417 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6418 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6419 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6420 (next_element_from_buffer): Call compute_stop_pos_backwards to
6421 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6422 base_level_stop.
6423 (reseat): Don't look for prev_stop, as that could mean a very long
6424 run.
6425 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6426 <cached_disp_overlay_modiff>: Cache for last found display string
6427 position.
551918c1 6428 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6429 about the same buffer in the same area of character positions, and
6430 the buffer wasn't changed since the time the display string
6431 position was cached.
551918c1 6432
b2d0c91a
EZ
64332011-07-22 Eli Zaretskii <eliz@gnu.org>
6434
6435 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6436 is an integer, which is important for empty lines. (Bug#9149)
6437
043604ee
CY
64382011-07-22 Chong Yidong <cyd@stupidchicken.com>
6439
6440 * frame.c (Fmodify_frame_parameters): In tty case, update the
6441 default face if necessary (Bug#4238).
6442
da4adb04
CY
64432011-07-21 Chong Yidong <cyd@stupidchicken.com>
6444
6445 * editfns.c (Fstring_to_char): No need to explain what a character
6446 is in the docstring (Bug#6576).
6447
9abd0532
LMI
64482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6449
6450 * xml.c (parse_region): Make sure we always return a tree.
6451
36881d16
HK
64522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6453
6454 * xml.c (parse_region): If a document contains only comments,
6455 return that, too.
6456
1e98674d
LMI
64572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6458
6459 * xml.c (make_dom): Return comments, too.
6460
590bd467
PE
64612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6462
6463 Port to OpenBSD.
6464 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6465 and the surrounding thread.
6466 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6467 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6468 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6469 timer goes off.
6470 * s/openbsd.h (BROKEN_SIGIO): Define.
6471 * unexelf.c (unexec) [__OpenBSD__]:
6472 Don't update the .mdebug section of the Alpha COFF symbol table.
6473
f41628b2
LMI
64742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6475
6476 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6477 (bug#8460).
6478
b59b67c5
PE
64792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6480
15e3a074
PE
6481 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6482 This fixes some race conditions on the permissions of any newly
6483 created file.
6484
41bed37d
PE
6485 * alloc.c (valid_pointer_p): Use pipe, not open.
6486 This fixes some permissions issues when debugging.
6487
b59b67c5
PE
6488 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6489 If fchown fails to set both uid and gid, try to set just gid,
6490 as that is sometimes allowed. Adjust the file's mode to eliminate
6491 setuid or setgid bits that are inappropriate if fchown fails.
6492
925a6be7
SM
64932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6494
6495 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6496 to compare Lisp_Objects.
6497 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6498 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6499 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6500
52968808
AS
65012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6502
0a6a104b
AS
6503 * lread.c (read_integer): Unread even EOF character.
6504 (read1): Likewise. Properly record start position of symbol.
6505
52968808
AS
6506 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6507 symbol character follows.
6508
9e381cdd
PE
65092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6510
6511 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6512 This works around a problem with the previous change to Fcopy_file.
6513 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6514 and without this change, GCC might complain about discarding
6515 fchown's return value.
6516
b5641435
JB
65172011-07-16 Juanma Barranquero <lekktu@gmail.com>
6518
6519 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6520
a8031457
PE
65212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6522
6523 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6524
dd889327
LMI
65252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6526
750c33f7
LMI
6527 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6528 it's used from the C level.
6529
dd889327
LMI
6530 * process.c: Use the same condition for POLL_FOR_INPUT in both
6531 keyboard.c and process.c (bug#1858).
6532
87e86684
LM
65332011-07-09 Lawrence Mitchell <wence@gmx.li>
6534
6535 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6536 (Fgnutls_boot): Use it.
6537
64348f40
AS
65382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6539
6540 * doc.c (Fsubstitute_command_keys): Revert last change.
6541
1d698799
LMI
65422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6543
f863868c
LMI
6544 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6545 quotes the next character, and doesn't affect other longer
6546 sequences (bug#8935).
6547
1d698799
LMI
6548 * lread.c (syms_of_lread): Clarify that is isn't only
6549 `eval-buffer' and `eval-defun' that's affected by
6550 `lexical-binding' (bug#8460).
6551
aa4b6df6
EZ
65522011-07-15 Eli Zaretskii <eliz@gnu.org>
6553
6554 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6555 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6556
5d856da6
PE
65572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6558
ad6042bb
PE
6559 Fix minor problems found by static checking.
6560 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6561 (elsz): Now a signed constant, not a size_t var. We prefer signed
6562 types to unsigned, to avoid integer comparison confusion. Without
6563 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6564 "cannot optimize loop, the loop counter may overflow", a symptom
6565 of the confusion.
f00bbb22 6566 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6567 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6568
6468f31c
LMI
65692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6570
49080b10
LMI
6571 * search.c (Fre_search_backward): Mention `case-fold-search' in
6572 all the re_search_* functions (bug#8138).
6573
6468f31c
LMI
6574 * keyboard.c (Fopen_dribble_file): Document when the file is
6575 closed (bug#8056).
6576
c965adc5
EZ
65772011-07-14 Eli Zaretskii <eliz@gnu.org>
6578
df9733bf
EZ
6579 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6580 bidi_cache_idx.
6581
0bb23927
EZ
6582 Support bidi reordering of display and overlay strings.
6583 * xdisp.c (compute_display_string_pos)
6584 (compute_display_string_end): Accept additional argument STRING.
6585 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6586 (reseat_to_string): Initialize bidi_it->string.s and
6587 bidi_it->string.schars.
6588 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6589 NULL (avoids a crash in bidi_paragraph_init).
6590 Initialize itb.string.lstring.
0bb23927
EZ
6591 (init_iterator): Call bidi_init_it only of a valid
6592 buffer position was specified. Initialize paragraph_embedding to
6593 L2R.
6594 (reseat_to_string): Initialize the bidi iterator.
6595 (display_string): If we need to ignore text properties of
6596 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6597 original value of -1 will not work with bidi.)
6598 (compute_display_string_pos): First arg is now struct
6599 `text_pos *'; all callers changed. Support display properties on
6600 Lisp strings.
6601 (compute_display_string_end): Support display properties on Lisp
6602 strings.
6603 (init_iterator, reseat_1, reseat_to_string): Initialize the
6604 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6605 when iterating on a string not from display properties).
640c8776
SM
6606 (compute_display_string_pos, compute_display_string_end):
6607 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6608 arrow keys.
6609 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6610 base_level_stop; instead, set base_level_stop to BEGV.
6611 Fixes crashes in vertical-motion.
0bb23927
EZ
6612 (next_element_from_buffer): Improve commentary for when
6613 the iterator is before prev_stop.
6614 (init_iterator): Initialize bidi_p from the default value of
6615 bidi-display-reordering, not from buffer-local value. Use the
6616 buffer-local value only if initializing for buffer iteration.
6617 (handle_invisible_prop): Support invisible properties on strings
6618 that are being bidi-reordered.
6619 (set_iterator_to_next): Support bidi reordering of C strings and
6620 Lisp strings.
6621 (next_element_from_string): Support bidi reordering of Lisp
6622 strings.
6623 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6624 (display_string): Support display of R2L glyph rows.
6625 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6626 (init_iterator): Don't initialize it->bidi_p for strings
6627 here.
6628 (reseat_to_string): Initialize it->bidi_p for strings here.
6629 (next_element_from_string, next_element_from_c_string)
6630 (next_element_from_buffer): Add xassert's for correspondence
6631 between IT's object being iterated and it->bidi_it.string
6632 structure.
6633 (face_before_or_after_it_pos): Support bidi iteration.
6634 (next_element_from_c_string): Handle the case of the first string
6635 character that is not the first one in the visual order.
6636 (get_visually_first_element): New function, refactored from common
6637 parts of next_element_from_buffer, next_element_from_string, and
6638 next_element_from_c_string.
6639 (tool_bar_lines_needed, redisplay_tool_bar)
6640 (display_menu_bar): Force left-to-right direction. Add a FIXME
6641 comment for making that be controlled by a user option.
6642 (push_it, pop_it): Save and restore the state of the
6643 bidi iterator. Save and restore the bidi_p flag.
6644 (pop_it): Iterate out of display property for string iteration as
6645 well.
6646 (iterate_out_of_display_property): Support iteration over strings.
6647 (handle_single_display_spec): Set up it->bidi_it for iteration
6648 over a display string, and call bidi_init_it.
6649 (handle_single_display_spec, next_overlay_string)
6650 (get_overlay_strings_1, push_display_prop): Set up the bidi
6651 iterator for displaying display or overlay strings.
6652 (forward_to_next_line_start): Don't use the shortcut if
6653 bidi-iterating.
6654 (back_to_previous_visible_line_start): If handle_display_prop
6655 pushed the iterator stack, restore the internal state of the bidi
6656 iterator by calling bidi_pop_it same number of times.
6657 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6658 and we are bidi-iterating, don't decrement the iterator position;
6659 instead, set the first_elt flag in the bidi iterator, to produce
6660 the same effect.
6661 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6662 (push_display_prop): xassert that we are iterating a buffer.
6663 (push_it, pop_it): Save and restore paragraph_embedding member.
6664 (handle_single_display_spec, next_overlay_string)
6665 (get_overlay_strings_1, reseat_1, reseat_to_string)
6666 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6667 correctly. Don't assume unibyte strings are not bidi-reordered.
6668 (compute_display_string_pos)
6669 (compute_display_string_end): Fix handling the case of C string.
6670 (push_it, pop_it): Save and restore from_disp_prop_p.
6671 (handle_single_display_spec, push_display_prop): Set the
6672 from_disp_prop_p flag.
6673 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6674 (pop_it): Call iterate_out_of_display_property only if we are
6675 popping after iteration over a string that came from a display
6676 property. Fix a typo in popping stretch info. Add an assertion
6677 for verifying that the iterator position is in sync with the bidi
6678 iterator.
6679 (handle_single_display_spec, get_overlay_strings_1)
6680 (push_display_prop): Fix initialization of paragraph direction for
6681 string when that of the parent object is not yet determined.
6682 (reseat_1): Call bidi_init_it to resync the bidi
6683 iterator with IT's position. (Bug#7616)
6684 (find_row_edges): If ROW->start.pos gives position
6685 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6686 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6687 Reset the from_disp_prop_p flag.
6688 (SAVE_IT, RESTORE_IT): New macros.
6689 (pos_visible_p, face_before_or_after_it_pos)
6690 (back_to_previous_visible_line_start)
6691 (move_it_in_display_line_to, move_it_in_display_line)
6692 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6693 (try_scrolling, redisplay_window, display_line): Use them when
6694 saving a temporary copy of the iterator and restoring it back.
6695 (back_to_previous_visible_line_start, reseat_1)
6696 (init_iterator): Empty the bidi cache "stack".
6697 (move_it_in_display_line_to): If iterator ended up at
6698 EOL, but we never saw any buffer positions smaller than
6699 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6700 motion in bidi-reordered lines.
6701 (move_it_in_display_line_to): Record prev_method and prev_pos
6702 immediately before the call to set_iterator_to_next. Fixes cursor
6703 motion in bidi-reordered lines with stretch glyphs and strings
6704 displayed in margins. (Bug#8133) (Bug#8867)
6705 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6706 TO_CHARPOS.
640c8776
SM
6707 (pos_visible_p): Support positions in bidi-reordered lines.
6708 Save and restore bidi cache.
0bb23927
EZ
6709
6710 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6711 (bidi_paragraph_info): Delete unused struct.
6712 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6713 (bidi_cache_start): New variable.
6714 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6715 to zero.
6716 (bidi_cache_fetch_state, bidi_cache_search)
6717 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6718 (bidi_cache_find, bidi_peek_at_next_level)
6719 (bidi_level_of_next_char, bidi_find_other_level_edge)
6720 (bidi_move_to_visually_next): Compare cache index with
6721 bidi_cache_start rather than with zero.
6722 (bidi_fetch_char): Accept new argument STRING; all callers
6723 changed. Support iteration over a string. Support strings with
6724 display properties. Support unibyte strings. Fix the type of
6725 `len' according to what STRING_CHAR_AND_LENGTH expects.
6726 (bidi_paragraph_init, bidi_resolve_explicit_1)
6727 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6728 (bidi_level_of_next_char, bidi_move_to_visually_next):
6729 Support iteration over a string.
0bb23927
EZ
6730 (bidi_set_sor_type, bidi_resolve_explicit_1)
6731 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6732 can now be zero (for strings); special values 0 and -1 were
6733 changed to -1 and -2, respectively.
6734 (bidi_char_at_pos): New function.
6735 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6736 Call it instead of FETCH_MULTIBYTE_CHAR.
6737 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6738 initialized to valid values.
6739 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6740 values.
6741 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6742 the test for valid cached positions. Fix the logic for looking up
6743 the sentinel state in the cache. GCPRO the Lisp string we are
6744 iterating.
6745 (bidi_push_it, bidi_pop_it): New functions.
6746 (bidi_initialize): Initialize the bidi cache start stack pointer.
6747 (bidi_cache_ensure_space): New function, refactored from part of
6748 bidi_cache_iterator_state. Don't assume the required size is just
6749 one BIDI_CACHE_CHUNK away.
6750 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6751 (bidi_count_bytes, bidi_char_at_pos): New functions.
6752 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6753 always valid if bidi_cache_idx is valid.
6754 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6755 is valid if it's going to be used.
6756 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6757 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6758 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6759 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6760 (bidi_find_other_level_edge, bidi_cache_start_stack):
6761 All variables related to cache indices are now EMACS_INT.
c965adc5 6762
0bb23927
EZ
6763 * dispextern.h (struct bidi_string_data): New structure.
6764 (struct bidi_it): New member `string'. Make flag members be 1-bit
6765 fields, and put them last in the struct.
640c8776
SM
6766 (compute_display_string_pos, compute_display_string_end):
6767 Update prototypes.
0bb23927
EZ
6768 (bidi_push_it, bidi_pop_it): Add prototypes.
6769 (struct iterator_stack_entry): New members bidi_p,
6770 paragraph_embedding, and from_disp_prop_p.
6771 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6772 (bidi_shelve_cache, bidi_unshelve_cache):
6773 Declare prototypes.
0bb23927
EZ
6774
6775 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6776 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6777 and vector-like objects.
6778
6779 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6780 cache around display iteration.
6781
6782 * window.c (Fwindow_end, window_scroll_pixel_based)
6783 (displayed_window_lines, Frecenter): Save and restore the bidi
6784 cache around display iteration.
6785
3bbd2265
LMI
67862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6787
6788 * editfns.c (Fdelete_region): Clarify the use of the named
6789 parameters (bug#6788).
6790
adc47434
MR
67912011-07-14 Martin Rudalics <rudalics@gmx.at>
6792
6793 * indent.c (Fvertical_motion): Set and restore w->pointm when
6794 saving and restoring the window's buffer (Bug#9006).
6795
837c31f8
LMI
67962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6797
6798 * editfns.c (Fstring_to_char): Clarify just what is returned
6799 (bug#6576). Text by Eli Zaretskii.
6800
ac389d0c
JB
68012011-07-13 Juanma Barranquero <lekktu@gmail.com>
6802
6803 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6804
0be0ce47
EZ
68052011-07-13 Eli Zaretskii <eliz@gnu.org>
6806
6807 * buffer.c (mmap_find): Fix a typo.
6808
cd18e7e3
JB
68092011-07-13 Johan Bockgård <bojohan@gnu.org>
6810
6811 Fix execution of x selection hooks.
6812 * xselect.c (Qx_lost_selection_functions)
6813 (Qx_sent_selection_functions): New vars.
6814 (syms_of_xselect): DEFSYM them.
6815 (x_handle_selection_request): Pass Qx_sent_selection_functions
6816 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6817 (x_handle_selection_clear,x_clear_frame_selections):
6818 Pass Qx_lost_selection_functions rather than
6819 Vx_lost_selection_functions to Frun_hook_with_args.
6820
47ea7f44
PE
68212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6822
ac389d0c 6823 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6824 The old code sometimes used this field without initializing it.
6825
47ea7f44
PE
6826 * alloc.c (gc_sweep): Don't read past end of array.
6827 In theory, the old code could also have corrupted Emacs internals,
6828 though it'd be very unlikely.
6829
bc985c87
AS
68302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6831
6832 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6833 argument. (Bug#4026)
bc985c87 6834
0cf34688
LMI
68352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6836
b3dadd76
LMI
6837 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6838 key" (bug#4257).
6839
0cf34688
LMI
6840 * window.c (Fset_window_start): Doc fix (bug#4199).
6841 (Fset_window_hscroll): Ditto.
6842
270768cd
PE
68432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6844
077e3dda 6845 Fix minor new problems caught by GCC 4.6.1.
270768cd 6846 * term.c (init_tty): Remove unused local.
490011a6 6847 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6848 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6849 not used otherwise.
270768cd 6850
b1f58454
CY
68512011-07-12 Chong Yidong <cyd@stupidchicken.com>
6852
6853 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6854
22b9578d
LMI
68552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6856
6e70ab07
LMI
6857 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6858 are the mini-buffer and the echo area (bug#3320).
6859
22b9578d
LMI
6860 * term.c (init_tty): Remove support for supdup, c10 and perq
6861 terminals, which are no longer supported (bug#1482).
6862
8974cc9f
JB
68632011-07-10 Johan Bockgård <bojohan@gnu.org>
6864
6865 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6866
a560d974
JD
68672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6868
6869 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6870 for non-popups (Bug#3642).
6871
1dae0f0a
AS
68722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6873
268c2c36 6874 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6875 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6876 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6877 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6878 * data.c (fmod): Likewise.
6879 * dispnew.c (swap_glyphs_in_rows): Likewise.
6880 * emacs.c (memory_warning_signal): Likewise.
6881 * floatfns.c (float_error): Likewise.
6882 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6883 (otf_open, font_otf_capability, generate_otf_features)
6884 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6885 Likewise.
6886 * image.c (pbm_read_file): Likewise.
6887 * indent.c (string_display_width): Likewise.
6888 * intervals.c (check_for_interval, search_for_interval)
6889 (inc_interval_count, count_intervals, root_interval)
6890 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6891 * lread.c (defalias): Likewise.
268c2c36 6892 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6893 * regex.c (set_image_of_range_1, set_image_of_range)
6894 (regex_grow_registers): Likewise.
6895 * sysdep.c (strerror): Likewise.
6896 * termcap.c (valid_filename_p, tprint, main): Likewise.
6897 * tparam.c (main): Likewise.
6898 * unexhp9k800.c (run_time_remap, save_data_space)
6899 (update_file_ptrs, read_header, write_header, calculate_checksum)
6900 (copy_file, copy_rest, display_header): Likewise.
6901 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6902 Likewise.
6903 * xdisp.c (check_it): Likewise.
6904 * xfaces.c (register_color, unregister_color, unregister_colors):
6905 Likewise.
6906 * xfns.c (print_fontset_result): Likewise.
6907 * xrdb.c (member, fatal, main): Likewise.
6908
99033785
PE
69092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6910
6911 Fix minor problems found by static checking (Bug#9031).
6912 * chartab.c (char_table_set_range, map_sub_char_table):
6913 Remove unused locals.
6914 (uniprop_table): Now static.
6915 * composite.c (_work_char): Remove unused static var.
6916
9cb2ac56
JB
69172011-07-09 Juanma Barranquero <lekktu@gmail.com>
6918
6919 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6920
f25661f0
JD
69212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6922
6923 * gtkutil.c (qttip_cb): Remove code without function.
6924
8278c4fe
EZ
69252011-07-09 Eli Zaretskii <eliz@gnu.org>
6926
6927 * w32.c (pthread_sigmask): New stub.
6928
1692ae2d 69292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6930
8a6ebd58 6931 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6932 sigprocmask is portable only for single-threaded applications, and
6933 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6934 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6935 (LIBES): Use it.
6936 * callproc.c (Fcall_process):
6937 * process.c (create_process):
6938 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6939 Use pthread_sigmask, not sigprocmask.
123403e4 6940
1b854618
JD
69412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6942
6943 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6944 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6945 wrong (Bug#8591).
6946
3fe4b549
JD
69472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6948
0ce7e563
JD
6949 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6950 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6951 (xg_hide_tooltip): Fix comment.
6952
3fe4b549
JD
6953 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6954 in registerServicesMenuSendTypes.
6955 (validRequestorForSendType): Don't check ns_return_types.
6956
6957 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6958 ns_return_type.
6959
5df75e47
JR
69602011-07-08 Jason Rumney <jasonr@gnu.org>
6961
22610910
JR
6962 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6963 SH_SHOW for hidden windows (Bug#5482).
6964
5df75e47
JR
6965 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6966 frame struct members of non-existent frames (Bug#6284).
6967
699c10bd
JD
69682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6969
4393663b
JD
6970 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6971 variable firstTime not needed on OSX >= 10.6.
6972 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6973 >= 10.5. Use setKnobProportion, setDoubleValue.
6974
6975 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6976 (MAC_OS_X_VERSION_10_5): Define if not defined.
6977 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6978 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6979 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6980
6981 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6982 cString and lossyCString on OSX >= 10.4
6983
58179cce 6984 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6985 sizeToFit on OSX >= 10.2.
6986
6987 * nsimage.m (allocInitFromFile): Don't use deprecated method
6988 bestRepresentationForDevice on OSX >= 10.6.
6989
6990 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6991 to avoid warning.
6992
6993 * emacs.c: Declare unexec_init_emacs_zone.
6994
a63e0781
JD
6995 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6996
699c10bd
JD
6997 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6998
6999 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7000 on svcsMenu (Bug#8842).
7001
7002 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7003 ns_return_types.
7004 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7005
7006 * nsterm.m (QUTF8_STRING): Declare.
7007 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7008 (validRequestorForSendType): Return type is (id).
7009 Change indexOfObjectIdenticalTo to indexOfObject.
7010 Check if we have local selection before returning self (Bug#8842).
7011 (writeSelectionToPasteboard): Put local selection into paste board
7012 if we have a local selection (Bug#8842).
7013 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7014
7015 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7016 (ns_get_local_selection): Declare.
7017
54e10184
LMI
70182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7019
9888ff71
LMI
7020 * keymap.c (describe_map_tree): Don't insert a double newline at
7021 the end of the buffer (bug#1169) and return whether we inserted
7022 something.
7023
54e10184
LMI
7024 * callint.c (Fcall_interactively): Change "reading args" to
7025 "providing args" to try to clarify what it does (bug#1010).
7026
15fa4783
KH
70272011-07-07 Kenichi Handa <handa@m17n.org>
7028
7029 * composite.c (composition_compute_stop_pos): Ignore a static
7030 composition starting before CHARPOS (Bug#8915).
7031
7032 * xdisp.c (handle_composition_prop): Likewise.
7033
a8815b00
EZ
70342011-07-07 Eli Zaretskii <eliz@gnu.org>
7035
7036 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7037 (Bug#9015)
7038
ef7b981d 70392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7040
7041 * character.h (unicode_category_t): New enum type.
7042
7043 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7044 (Qchar_code_property_table): New variable.
7045 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7046 (UNIPROP_COMPRESSED_FORM_P): New macros.
7047 (char_table_ascii): Uncompress the compressed values.
7048 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7049 Uncompress the compressed values.
ac389d0c 7050 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7051 (char_table_ref_and_range): Uncompress the compressed values.
7052 (sub_char_table_set): New arg is_uniprop. Callers changed.
7053 Uncompress the compressed values.
7054 (sub_char_table_set_range): Args changed. Callers changed.
7055 (char_table_set_range): Adjuted for the above change.
7056 (map_sub_char_table): Delete args default_val and parent. Add arg
7057 top. Give decoded values to a Lisp function.
640c8776 7058 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7059 values to a Lisp function. Gcpro more variables.
7060 (uniprop_table_uncompress)
7061 (uniprop_decode_value_run_length): New functions.
7062 (uniprop_decoder, uniprop_decoder_count): New variables.
7063 (uniprop_get_decoder, uniprop_encode_value_character)
7064 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7065 New functions.
7066 (uniprop_encoder, uniprop_encoder_count): New variables.
7067 (uniprop_get_encoder, uniprop_table)
7068 (Funicode_property_table_internal, Fget_unicode_property_internal)
7069 (Fput_unicode_property_internal): New functions.
7070 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7071 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7072 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7073 char-code-property-alist.
7074
640c8776 7075 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7076 Vunicode_category_table.
7077
640c8776 7078 * font.c (font_range): Adjust for the change of
c805dec0
KH
7079 Vunicode_category_table.
7080
76b397fb
DN
70812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7082
7083 * m/iris4d.h: Remove file, move contents ...
7084 * s/irix6-5.h: ... here.
7085
22b4128e
PE
70862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7087
7088 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7089 * alloc.c (mark_buffer):
7090 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7091 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7092 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7093 This isn't true in general, and it's particularly not true
7094 if Emacs is configured with --with-wide-int.
7095 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7096 New macros, used in the buffer.c change.
7097
869795d6
JD
70982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7099
7100 * xsettings.c: Use both GConf and GSettings if both are available.
7101 (store_config_changed_event): Add comment.
7102 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7103 (store_tool_bar_style_changed): New functions.
5e617bc2 7104 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7105 (struct xsettings): Move font inside HAVE_XFT.
7106 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7107 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7108 Move inside HAVE_XFT.
640c8776 7109 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7110 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7111 also.
7112 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7113 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7114 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7115 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7116 (parse_settings): Move check for font inside HAVE_XFT.
7117 (read_settings, apply_xft_settings): Add comment.
7118 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7119 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7120 call store_font_name_changed.
7121 (xft_settings_event): Add comment.
7122 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7123 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7124 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7125 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7126 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7127 (xsettings_get_system_font, xsettings_get_system_normal_font):
7128 Add comment.
869795d6 7129
d8ed26bd
PE
71302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7131
7132 Random fixes. E.g., (random) never returned negative values.
7133 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7134 subseconds part to the entropy, as that's a bit more random.
7135 Prefer signed to unsigned, since the signedness doesn't matter and
7136 in general we prefer signed. When given a limit, use a
7137 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7138 latter isn't right if USE_2_TAGS_FOR_INTS.
7139 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7140 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7141
cabf1cac
SM
71422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7143
7144 * textprop.c (text_property_stickiness):
7145 Obey Vtext_property_default_nonsticky.
7146 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7147 * w32fns.c (syms_of_w32fns):
7148 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7149
6e9b2be9
PE
71502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7151
7152 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7153 This is more efficient than Ffile_directory_p and avoids a minor race.
7154
90186c68
LMI
71552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7156
7c301272
LMI
7157 * buffer.c (Foverlay_put): Say what the return value is
7158 (bug#7835).
7159
c4f2d8d4
LMI
7160 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7161 is a directory before asking whether to use the file name
7162 (bug#7564).
ad637907
LMI
7163 (barf_or_query_if_file_exists): Make the "File is a directory"
7164 error be more correct.
c4f2d8d4 7165
90186c68
LMI
7166 * fns.c (Frequire): Remove the mention of the .gz files, since
7167 that's installation-specific, but keep the mention of
7168 `get-load-suffixes'.
7169
da64016e
PE
71702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7171
7172 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7173 Report string overflow if the output is too long.
7174
7d47b580
JB
71752011-07-04 Juanma Barranquero <lekktu@gmail.com>
7176
a555cb87
JB
7177 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7178 (syms_of_gnutls): Remove duplicate DEFSYM for
7179 Qgnutls_bootprop_verify_hostname_error, an error for
7180 Qgnutls_bootprop_verify_error (which is no longer used).
7181
7d47b580
JB
7182 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7183 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7184 Also (re)move comments that are misplaced or no longer relevant.
7185
1e49bfab
LMI
71862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7187
7188 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7189
1485f4c0
CY
71902011-07-03 Chong Yidong <cyd@stupidchicken.com>
7191
7192 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7193 and background color parameters if they have been changed.
7194
a9ab721e
LMI
71952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7196
7197 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7198
cf7cff57
PE
71992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7200
2e13213d
PE
7201 * xsettings.c (SYSTEM_FONT): Define only when used.
7202 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7203
cf7cff57
PE
7204 * keymap.c (access_keymap_1): Now static.
7205
7a8e04f7
CY
72062011-07-02 Chong Yidong <cyd@stupidchicken.com>
7207
7208 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7209 leave any prefix arg for the up event (Bug#1586).
7210
61352f62
LMI
72112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7212
69bb1ef7
LMI
7213 * lread.c (syms_of_lread): Mention single symbols defined by
7214 `defvar' or `defconst' (bug#7154).
7215
61352f62 7216 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7217 (Frequire): Mention get-load-suffixes.
61352f62 7218
28545e04
MR
72192011-07-02 Martin Rudalics <rudalics@gmx.at>
7220
7221 * window.h (window): Remove clone_number slot.
7222 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7223 Remove.
7224 (make_parent_window, make_window, saved_window)
7225 (Fset_window_configuration, save_window_save): Don't deal with
7226 clone numbers.
7227 * buffer.c (Qclone_number): Remove declaration.
7228 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7229
3349e122
SM
72302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7231
7232 Add multiple inheritance to keymaps.
7233 * keymap.c (Fmake_composed_keymap): New function.
7234 (Fset_keymap_parent): Simplify.
7235 (fix_submap_inheritance): Remove.
7236 (access_keymap_1): New function extracted from access_keymap to handle
7237 embedded parents and handle lists of maps.
7238 (access_keymap): Use it.
7239 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7240 (Fcopy_keymap): Handle embedded parents.
7241 (Fcommand_remapping, define_as_prefix): Simplify.
7242 (Fkey_binding): Simplify.
7243 (syms_of_keymap): Move minibuffer-local-completion-map,
7244 minibuffer-local-filename-completion-map,
7245 minibuffer-local-must-match-map, and
7246 minibuffer-local-filename-must-match-map to Elisp.
7247 (syms_of_keymap): Defsubr make-composed-keymap.
7248 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7249 (parse_menu_item): Trivial simplification.
7250
3279eb87
GM
72512011-07-01 Glenn Morris <rgm@gnu.org>
7252
7253 * Makefile.in (SETTINGS_LIBS): Fix typo.
7254
4550efdf
KI
72552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7256
7257 * coding.c (Fencode_coding_string): Record the last coding system
7258 used, as the function doc string says (bug#8738).
7259
0949d2b6
JD
72602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7261
7262 * xsettings.c (store_monospaced_changed): Take new font as arg and
7263 check for change against current_mono_font.
7264 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7265 (emacs_settings_constructor, emacs_settings_get_property)
7266 (emacs_settings_set_property, emacs_settings_class_init)
7267 (emacs_settings_init, gsettings_obj): Remove.
7268 (something_changedCB): New function for HAVE_GSETTINGS.
7269 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7270 with value as argument.
7271 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7272 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7273 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7274 "changed".
7275
7276 * xgselect.c: Add defined (HAVE_GSETTINGS).
7277 (xgselect_initialize): Ditto.
7278
7279 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7280 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7281 xg_select.
7282
bbc6b304
PE
72832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7284
7285 * eval.c (struct backtrace): Simplify and port the data structure.
7286 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7287 signed bit field, as this assumption is not portable and it makes
7288 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7289 "char debug_on_exit : 1" as this is not portable either; instead,
7290 use the portable "unsigned int debug_on_exit : 1". Remove unused
7291 member evalargs. Remove obsolete comments about cc bombing out.
7292
9851bfc5
JD
72932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7294
51bb811f 7295 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7296 Let HAVE_GSETTINGS override HAVE_GCONF.
7297 (store_monospaced_changed): New function.
7298 (EMACS_SETTINGS): A new type derived from GObject to handle
7299 GSettings notifications.
7300 (emacs_settings_constructor, emacs_settings_get_property)
7301 (emacs_settings_set_property, emacs_settings_class_init):
7302 New functions.
7303 (gsettings_client, gsettings_obj): New variables.
7304 (GSETTINGS_SCHEMA): New define.
7305 (something_changedCB): Call store_monospaced_changed.
7306 (init_gsettings): New function.
7307 (xsettings_initialize): Call init_gsettings.
7308 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7309 to NULL.
7310
640c8776 7311 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7312 GCONF_CFLAGS/LIBS.
7313
5386012d
MR
73142011-06-29 Martin Rudalics <rudalics@gmx.at>
7315
7316 * window.c (resize_root_window, grow_mini_window)
7317 (shrink_mini_window): Rename Qresize_root_window to
7318 Qwindow_resize_root_window and Qresize_root_window_vertically to
7319 Qwindow_resize_root_window_vertically.
7320
f13e0b08
PE
73212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7322
7323 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7324
94515237
JB
73252011-06-27 Juanma Barranquero <lekktu@gmail.com>
7326
7327 * makefile.w32-in: Redesign dependencies so they reflect more
7328 clearly which files are directly included by each source file,
7329 and not through other includes.
7330
e43b6e43
MR
73312011-06-27 Martin Rudalics <rudalics@gmx.at>
7332
7333 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7334 (sort_overlays, overlay_strings): When an overlay's clone number
7335 matches the window's clone number process the overlay even if
7336 the overlay's window property doesn't match the current window.
7337
d68443dc
MR
7338 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7339 (Fwindow_hchild): Rename to Fwindow_left_child.
7340 (Fwindow_next): Rename to Fwindow_next_sibling.
7341 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7342 (resize_window_check): Rename to window_resize_check.
7343 (resize_window_apply): Rename to window_resize_apply.
7344 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7345 (Fdelete_other_windows_internal, resize_frame_windows)
7346 (Fsplit_window_internal, Fdelete_window_internal)
7347 (grow_mini_window, shrink_mini_window)
7348 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7349
c7e73be5
JD
73502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7351
7352 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7353 (emacs_fixed_set_min_size): Remove.
7354 (emacs_fixed_new): Take frame as argument.
7355
7356 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7357 (_EmacsFixedPrivate): Remove minwidth/height.
7358 Add struct frame *f.
7359 (emacs_fixed_init): Initialize priv->f.
7360 (get_parent_class, emacs_fixed_set_min_size): Remove.
7361 (emacs_fixed_new): Set priv->f to argument.
7362 (emacs_fixed_get_preferred_width)
7363 (emacs_fixed_get_preferred_height): Use min_width/height from
7364 frames size_hint to set minimum and natural (Bug#8919).
7365 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7366 and use min_width/height from frames size_hint to set
7367 min_width/height (Bug#8919).
7368
7369 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7370 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7371 Fix indentation.
c7e73be5 7372
cf99dcf8
EZ
73732011-06-26 Eli Zaretskii <eliz@gnu.org>
7374
7375 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7376 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7377 called at ZV.
7378
029529ac
CY
73792011-06-26 Chong Yidong <cyd@stupidchicken.com>
7380
7381 * process.c (wait_reading_process_output): Bypass select if
7382 waiting for a cell while ignoring keyboard input, and input is
7383 pending. Suggested by Jan Djärv (Bug#8869).
7384
7a7ef429
PE
73852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7386
7387 Use gnulib's dup2 module instead of rolling our own.
7388 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7389
11fdef7d 73902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7391
7392 * dispnew.c (scrolling_window): Before scrolling, turn off a
7393 mouse-highlight in the window being scrolled.
7394
cd3520a4
JB
73952011-06-24 Juanma Barranquero <lekktu@gmail.com>
7396
7397 Move DEFSYM to lisp.h and use everywhere.
7398
7399 * character.h (DEFSYM): Move declaration...
7400 * lisp.h (DEFSYM): ...here.
7401
7402 * gnutls.c:
7403 * minibuf.c:
7404 * w32menu.c:
7405 * w32proc.c:
7406 * w32select.c: Don't include character.h.
7407
7408 * alloc.c (syms_of_alloc):
7409 * buffer.c (syms_of_buffer):
7410 * bytecode.c (syms_of_bytecode):
7411 * callint.c (syms_of_callint):
7412 * casefiddle.c (syms_of_casefiddle):
7413 * casetab.c (init_casetab_once):
7414 * category.c (init_category_once, syms_of_category):
7415 * ccl.c (syms_of_ccl):
7416 * cmds.c (syms_of_cmds):
7417 * composite.c (syms_of_composite):
7418 * dbusbind.c (syms_of_dbusbind):
7419 * dired.c (syms_of_dired):
7420 * dispnew.c (syms_of_display):
7421 * doc.c (syms_of_doc):
7422 * editfns.c (syms_of_editfns):
7423 * emacs.c (syms_of_emacs):
7424 * eval.c (syms_of_eval):
7425 * fileio.c (syms_of_fileio):
7426 * fns.c (syms_of_fns):
7427 * frame.c (syms_of_frame):
7428 * fringe.c (syms_of_fringe):
7429 * insdel.c (syms_of_insdel):
7430 * keymap.c (syms_of_keymap):
7431 * lread.c (init_obarray, syms_of_lread):
7432 * macros.c (syms_of_macros):
7433 * msdos.c (syms_of_msdos):
7434 * print.c (syms_of_print):
7435 * process.c (syms_of_process):
7436 * search.c (syms_of_search):
7437 * sound.c (syms_of_sound):
7438 * syntax.c (init_syntax_once, syms_of_syntax):
7439 * terminal.c (syms_of_terminal):
7440 * textprop.c (syms_of_textprop):
7441 * undo.c (syms_of_undo):
7442 * w32.c (globals_of_w32):
7443 * window.c (syms_of_window):
7444 * xdisp.c (syms_of_xdisp):
7445 * xfaces.c (syms_of_xfaces):
7446 * xfns.c (syms_of_xfns):
7447 * xmenu.c (syms_of_xmenu):
7448 * xsettings.c (syms_of_xsettings):
7449 * xterm.c (syms_of_xterm): Use DEFSYM.
7450
4228cf16
TZ
74512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7452
cd3520a4 7453 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7454
7fcccf1e
PE
74552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7456
7efb4e0e
PE
7457 Integer and buffer overflow fixes (Bug#8873).
7458
ff5844ad
PE
7459 * print.c (printchar, strout): Check for string overflow.
7460 (PRINTPREPARE, printchar, strout):
7461 Don't set size unless allocation succeeds.
7462
90532f02
PE
7463 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7464 for sizes. Check for string overflow more accurately.
7465 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7466
6d84508d
PE
7467 * macros.c: Integer and buffer overflow fixes.
7468 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7469 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7470 Use ptrdiff_t, not int, for sizes.
7471 Don't increment bufsize until after realloc succeeds.
7472 Check for size-calculation overflow.
7473 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7474
437b2cb4
PE
7475 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7476
8b9ac8b4
PE
7477 * lread.c: Integer overflow fixes.
7478 (read_integer): Radix is now EMACS_INT, not int,
7479 to improve quality of diagnostics for out-of-range radices.
7480 Calculate buffer size correctly for out-of-range radices.
7481 (read1): Check for integer overflow in radices, and in
7482 read-circle numbers.
82cb60d3
PE
7483 (read_escape): Avoid int overflow.
7484 (Fload, openp, read_buffer_size, read1)
7485 (substitute_object_recurse, read_vector, read_list, map_obarray):
7486 Use ptrdiff_t, not int, for sizes.
7487 (read1): Use EMACS_INT, not int, for sizes.
20270765 7488 Check for size overflow.
8b9ac8b4 7489
7fcccf1e
PE
7490 * image.c (cache_image): Check for size arithmetic overflow.
7491
bfbbd7e7
PE
7492 * lread.c: Integer overflow issues.
7493 (saved_doc_string_size, saved_doc_string_length)
7494 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7495 Now ptrdiff_t, not int.
7496 (read1): Don't assume doc string length fits in int. Check for
7497 out-of-range doc string lengths.
7498 (read_list): Don't assume file position fits in int.
39019e54 7499 (read_escape): Check for hex character overflow.
bfbbd7e7 7500
4e323265
LL
75012011-06-22 Leo Liu <sdl.web@gmail.com>
7502
7503 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7504 Move to minibuffer.el.
7505
85fece3e
PE
75062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7507
20b84ce9 7508 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7509 The following patches are for when GLYPH_DEBUG && !XASSERT.
7510 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7511 * dispnew.c (flush_stdout):
7512 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7513 Mark as externally visible.
7514 * dispnew.c (check_window_matrix_pointers): Now static.
7515 * dispnew.c (window_to_frame_vpos):
7516 * xfns.c (unwind_create_frame):
7517 * xterm.c (x_check_font): Remove unused local.
7518 * scroll.c (CHECK_BOUNDS):
7519 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7520 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7521 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7522 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7523 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7524 Now static.
7525 (debug_method_add): Use va_list and vsprintf rather than relying
7526 on undefined behavior with wrong number of arguments.
7527 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7528 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7529 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7530 since we're not interested in debugging glyphs with old libraries.
7531 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7532 GCC 4.6.0's static checking.
7533
0766b489
PE
75342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7535
31fd4b32
PE
7536 Integer overflow and signedness fixes (Bug#8873).
7537 A few related buffer overrun fixes, too.
7538
b79e8648
PE
7539 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7540
0766b489
PE
7541 * dispextern.h (struct face.stipple):
7542 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7543 (x_bitmap_mask, x_allocate_bitmap_record)
7544 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7545 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7546 (x_create_bitmap_from_xpm_data):
7547 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7548 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7549 (.bitmaps_last):
7550 * xfaces.c (load_pixmap):
7551 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7552 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7553 (.bitmaps_last, struct x_output.icon_bitmap):
7554 Use ptrdiff_t, not int, for bitmap indexes.
7555 (x_allocate_bitmap_record): Check for size overflow.
7556 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7557
b081724f
PE
7558 Use ptrdiff_t, not int, for overlay counts.
7559 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7560 * editfns.c (overlays_around, get_pos_property):
7561 * textprop.c (get_char_property_and_overlay):
7562 * xdisp.c (next_overlay_change, note_mouse_highlight):
7563 * xfaces.c (face_at_buffer_position):
21514da7
PE
7564 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7565 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7566 (Fnext_overlay_change, Fprevious_overlay_change)
7567 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7568 Use ptrdiff_t, not int, for sizes.
21514da7 7569 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7570
3de73e5e
PE
7571 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7572
2606c57b
PE
7573 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7574 (x_session_initialize): Do not assume string length fits in int.
7575
aaafe47a
PE
7576 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7577 This is unlikely, but can occur if DPI is outlandish.
7578
2674ddc8 7579 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7580 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7581
28154962
PE
7582 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7583 * xrdb.c (magic_file_p, search_magic_path):
7584 Omit last arg SUFFIX; it was always 0. All callers changed.
7585 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7586
7de51af5
PE
7587 * xfont.c (xfont_match): Avoid need for strlen.
7588
25ed6cc3
PE
7589 * xfns.c: Don't assume strlen fits in int.
7590 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7591
4eab31dd
PE
7592 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7593 not unsigned long, as we prefer signed integers. All callers changed.
7594 Detect integer overflow in repeat count.
7595 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7596 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7597
171e2a58
PE
7598 * termcap.c: Don't assume sizes fit in int and never overflow.
7599 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7600 (gobble_line): Check for size-calculation overflow.
7601
ad39faca 7602 * minibuf.c (Fread_buffer):
6e5bb2dc 7603 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7604 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7605 Don't assume string length fits in int.
7606
52c61c22 7607 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7608 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7609
b5b8c9e5
PE
7610 * font.c: Don't assume string length fits in int.
7611 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7612 Use ptrdiff_t, not int.
ccd6111c
PE
7613 (font_intern_prop): Don't assume string length fits in int.
7614 Don't assume integer property fits in fixnum.
7615 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7616
882f0d81 7617 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7618 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7619 Reformulate so as not to need the command string.
7620 Invoke gzip -cd rather than gunzip, as it's more portable.
7621 (lock_info_type, lock_file_1, lock_file):
7622 Don't assume pid_t and time_t fit in unsigned long.
7623 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7624 (current_lock_owner): Prefer signed type for sizes.
7625 Use memcpy, not strncpy, where memcpy is what is really wanted.
7626 Don't assume (via atoi) that time_t and pid_t fit in int.
7627 Check for time_t and/or pid_t out of range, e.g., via a network share.
7628 Don't alloca where an auto var works fine.
7629
93f4cf88
PE
7630 * fileio.c: Fix some integer overflow issues.
7631 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7632 Don't assume string length fits in int.
7633 (directory_file_name): Don't assume string length fits in long.
7634 (make_temp_name): Don't assume pid fits in int, or that its print
7635 length is less than 20.
7636
f3e92b69
PE
7637 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7638
1bfdaf10
PE
7639 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7640
35016e9a
PE
7641 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7642
3d1e65a1
PE
7643 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7644 We prefer signed integers, even for size calculations.
7645
0b963a93
PE
7646 * emacs.c: Don't assume string length fits in 'int'.
7647 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7648 (main): Don't invoke strlen when not needed.
7649
573f4b54
PE
7650 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7651 (XD_DEBUG_MESSAGE): Don't waste a byte.
7652
989f33ba
PE
7653 * callproc.c (getenv_internal_1, getenv_internal)
7654 (Fgetenv_internal):
965d34eb
PE
7655 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7656
e4d29b33
PE
7657 * lread.c (invalid_syntax): Omit length argument.
7658 All uses changed. This doesn't fix a bug, but it simplifies the
7659 code away from its former Hollerith-constant appearance, and it's
7660 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7661 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7662
eb49b136
PE
7663 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7664 This didn't break anything, but it didn't help either.
7665 It's confusing to put a bogus integer in a place where the actual
7666 value does not matter.
9f62aeb1 7667 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7668 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7669
15375a22
PE
7670 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7671 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7672 implementation.
b61cc01c
PE
7673 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7674 We prefer signed types, and the value cannot exceed the EMACS_INT
7675 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7676 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7677 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7678 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7679
53b2623d
PE
7680 * indent.c (sane_tab_width): New function.
7681 (current_column, scan_for_column, Findent_to, position_indentation)
7682 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7683 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7684
51cab52b 7685 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7686
f2ed8a70
PE
7687 * lisp.h (lint_assume): New macro.
7688 * composite.c (composition_gstring_put_cache):
7689 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7690
abe80cc6
PE
7691 * editfns.c, insdel.c:
7692 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7693
b02c740e
PE
7694 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7695
ebc96716
PE
7696 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7697
b4e50fa0 7698 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7699 Use much-faster test for byte-length change.
311d5d7c 7700 Don't assume string byte-length fits in 'int'.
a4cf38e4 7701 Check that character arg fits in 'int'.
85461888 7702 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7703
c0c1ee9f
PE
7704 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7705
a498d7f4
PE
7706 * fns.c (concat): Catch string overflow earlier.
7707 Do not rely on integer wraparound.
7708
51cab52b
PE
7709 * dispextern.h (struct it.overlay_strings_charpos)
7710 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7711 * xdisp.c (forward_to_next_line_start)
7712 (back_to_previous_visible_line_start)
7713 (reseat_at_next_visible_line_start, next_element_from_buffer):
7714 Don't arbitrarily truncate the value of 'selective' to int.
7715
76031fad
PE
7716 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7717
5eb55db9
PE
7718 * composite.c: Don't truncate sizes to 'int'.
7719 (composition_gstring_p, composition_reseat_it)
7720 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7721 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7722 not EMACS_UINT, for indexes.
5eb55db9 7723
0703a717
PE
7724 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7725
d6202519
PE
7726 * buffer.c: Include <verify.h>.
7727 (struct sortvec.priority, struct sortstr.priority):
8961a454 7728 Now EMACS_INT, not int.
c20998a7 7729 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7730 (struct sortstr.size, record_overlay_string)
7731 (struct sortstrlist.size, struct sortlist.used):
7732 Don't truncate size to int.
7733 (record_overlay_string): Check for size-calculation overflow.
d6202519 7734 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7735
d5a19415
JM
77362011-06-22 Jim Meyering <meyering@redhat.com>
7737
029529ac 7738 Don't leak an XBM-image-sized buffer
d5a19415
JM
7739 * image.c (xbm_load): Free the image buffer after using it.
7740
a9041e6c
PE
77412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7742
7743 Port to Sun C.
7744 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7745 that Sun C diagnosed.
7746 * fns.c (secure_hash): Fix pointer signedness issue.
7747 * intervals.c (static_offset_intervals): New function.
7748 (offset_intervals): Use it.
7749
7f3f739f
LL
77502011-06-21 Leo Liu <sdl.web@gmail.com>
7751
7752 * deps.mk (fns.o):
7753 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7754 sha512.h.
7755
7756 * fns.c (secure_hash): Rename from crypto_hash_function and change
7757 the first arg to accept symbols.
5b66d427 7758 (Fsecure_hash): New primitive.
7f3f739f
LL
7759 (syms_of_fns): New symbols.
7760
76147d94
DD
77612011-06-20 Deniz Dogan <deniz@dogan.se>
7762
7763 * process.c (Fset_process_buffer): Clarify return value in
7764 docstring.
7765
7d7d0045
CY
77662011-06-18 Chong Yidong <cyd@stupidchicken.com>
7767
7768 * dispnew.c (add_window_display_history): Use BVAR.
7769
7770 * xdisp.c (debug_method_add): Use BVAR.
7771 (check_window_end, dump_glyph_matrix, dump_glyph)
7772 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7773
7774 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7775 Likewise.
7776
7777 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7778 check till after the cache is created in init_frame_faces.
7779
ff2bc410
SM
77802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7781
7782 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7783
28177add
PE
77842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7785
dd3482fe
PE
7786 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7787 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7788 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7789
393d71f3 7790 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7791 * fileio.c (Finsert_file_contents):
7792 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7793 Remove the old (too-loose) buffer overflow checks.
7794 They weren't needed, since make_gap checks for buffer overflow.
7795 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7796 The old code merely checked for Emacs fixnum overflow, and relied
7797 on undefined (wraparound) behavior. The new code avoids undefined
7798 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7799
2e6813b0 7800 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7801 Tune. Don't use wider integers than needed. Don't use alloca.
7802 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7803
599a9e4f
PE
7804 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7805
99561444
PE
7806 * insdel.c, lisp.h (buffer_overflow): New function.
7807 (insert_from_buffer_1, replace_range, replace_range_2):
7808 * insdel.c (make_gap_larger):
7809 * editfns.c (Finsert_char):
7810 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7811
28177add
PE
7812 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7813
e69dafad
PE
78142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7815
4baa020d 7816 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7817
b1c46f02
PE
7818 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7819 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7820
e69dafad
PE
7821 * fileio.c: Don't assume EMACS_INT fits in off_t.
7822 (emacs_lseek): New static function.
7823 (Finsert_file_contents, Fwrite_region): Use it.
7824 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7825
566684ea
PE
7826 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7827
e6966cd6
PE
7828 * fns.c: Don't overflow int when computing a list length.
7829 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7830 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7831 truncation on 64-bit hosts. Check for QUIT every
7832 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7833 faster and is responsive enough.
7834 (Flength): Report an error instead of overflowing an integer.
7835 (Fsafe_length): Return a float if the value is not representable
7836 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7837 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7838 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7839
dd0b0efb
PE
7840 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7841 (header_size, word_size): New constants.
7842 (allocate_vectorlike): Don't check size overflow here.
7843 (allocate_vector): Check it here instead, since this is the only
7844 caller of allocate_vectorlike that could cause overflow.
7845 Check that the new vector's length is representable as a fixnum.
7846
86fe5cfe
PE
7847 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7848 The previous code was bogus. For example, next_almost_prime (32)
7849 returned 39, which is undesirable as it is a multiple of 3; and
7850 next_almost_prime (24) returned 25, which is a multiple of 5 so
7851 why was the code bothering to check for multiples of 7?
7852
80e88859
PE
7853 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7854
4a2f0ad6
PE
7855 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7856
f66c7cf8
PE
7857 Variadic C functions now count arguments with ptrdiff_t.
7858 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7859 Back then I didn't know that the Emacs coding style prefers signed int.
7860 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7861 were being counted with int, which may truncate counts on 64-bit
7862 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7863 * lisp.h (struct Lisp_Subr.function.aMANY)
7864 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7865 Arg counts are now ptrdiff_t, not size_t.
7866 All variadic functions and their callers changed accordingly.
7867 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7868 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7869 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7870 * callint.c (Fcall_interactively): Check arg count for overflow,
7871 to avoid potential buffer overrun. Use signed char, not 'int',
7872 for 'varies' array, so that we needn't bother to check its size
7873 calculation for overflow.
7874 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7875 * eval.c (apply_lambda):
7876 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7877 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7878 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7879
a1759b76
PE
7880 * callint.c (Fcall_interactively): Don't use index var as event count.
7881
d96be9fc
PE
7882 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7883 * mem-limits.h (SIZE): Remove; no longer used.
7884
a690a978 7885 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7886
578c21e6
PE
7887 Remove unnecessary casts.
7888 * xterm.c (x_term_init):
7889 * xfns.c (x_set_border_pixel):
7890 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7891 These aren't needed now that we assume ANSI C.
7892
96f53c6c
PE
7893 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7894 It's more likely to cause problems (due to unsigned overflow)
7895 than to cure them.
7896
83c77d31
PE
7897 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7898
ee2079f1
PE
7899 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7900
6da65536
PE
7901 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7902
7147c4a4
PE
7903 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7904
193e32d9
PE
7905 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7906
e5533da6
PE
7907 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7908
9910e595
PE
7909 GLYPH_CODE_FACE returns EMACS_INT, not int.
7910 * dispextern.h (merge_faces):
7911 * xfaces.c (merge_faces):
01103c44
PE
7912 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7913 Don't assume EMACS_INT fits in int.
9910e595 7914
2638320e
PE
7915 * character.h (CHAR_VALID_P): Remove unused parameter.
7916 * fontset.c, lisp.h, xdisp.c: All uses changed.
7917
045eb8d9
PE
7918 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7919
c1f134b5
PE
7920 * fns.c (concat): Minor tuning based on overflow analysis.
7921 This doesn't fix any bugs. Use int to hold character, instead
7922 of constantly refetching from Emacs object. Use XFASTINT, not
7923 XINT, for value known to be a character. Don't bother comparing
7924 a single byte to 0400, as it's always less.
7925
395fcb93 7926 * floatfns.c (Fexpt):
327eeec8
PE
7927 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7928
abbd3d23
PE
7929 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7930 for characters.
7931
684a03ef
PE
7932 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7933
0fed43f3
PE
7934 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7935 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7936 incorrectly succeed when S was a string, because 4294967386 was
7937 truncated before it was used.
7938
8fd02eb7
PE
7939 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7940 Otherwise, an out-of-range integer could cause undefined behavior
7941 on a 64-bit host.
7942
f8c86b69
PE
7943 * composite.c: Use int, not EMACS_INT, for characters.
7944 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7945 EMACS_INT, for values that are known to be in character range.
7946 This doesn't fix any bugs but is the usual style inside Emacs and
7947 may generate better code on 32-bit machines.
7948
34206dd2
PE
7949 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7950 This is for reasons similar to the recent CHAR_STRING fix.
7951 * charset.c (Fencode_char): Check that character arg is actually
7952 a character. Pass an int to ENCODE_CHAR.
7953 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7954 wider than 'int', as a compile-time check to prevent future regressions
7955 in this area.
7956
c5958d4c 7957 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7958
7959 Make sure a 64-bit char is never passed to CHAR_STRING.
7960 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7961 by silently ignoring the top 32 bits, allowing some values
7962 that were far too large to be valid characters.
7963 * character.h: Include <verify.h>.
7964 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7965 arguments are no wider than unsigned, as a compile-time check
7966 to prevent future regressions in this area.
7967 * data.c (Faset):
01103c44 7968 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7969 (Fsubst_char_in_region):
7970 * fns.c (concat):
7971 * xdisp.c (decode_mode_spec_coding):
7972 Adjust to CHAR_STRING's new requirement.
7973 * editfns.c (Finsert_char, Fsubst_char_in_region):
7974 * fns.c (concat): Check that character args are actually
7975 characters. Without this test, these functions did the wrong
7976 thing with wildly out-of-range values on 64-bit hosts.
7977
d37ca623
PE
7978 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7979 These casts should not be needed on 32-bit hosts, either.
7980 * keyboard.c (read_char):
7981 * lread.c (Fload): Remove casts to unsigned.
7982
ea204efb
PE
7983 * lisp.h (UNSIGNED_CMP): New macro.
7984 This fixes comparison bugs on 64-bit hosts.
7985 (ASCII_CHAR_P): Use it.
7986 * casefiddle.c (casify_object):
01103c44 7987 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7988 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7989 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7990 * dispextern.h (FACE_FROM_ID):
7991 * keyboard.c (read_char): Use UNSIGNED_CMP.
7992
41cb286c
PE
7993 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7994 not to EMACS_INT, to avoid GCC warning.
7995
4a1b9832
PE
7996 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7997
55daad71
PE
7998 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7999 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8000 isn't needed on 32-bit machines.
8f95c75c 8001
01103c44
PE
8002 * buffer.c (Fgenerate_new_buffer_name):
8003 Use EMACS_INT for count, not int.
0ceccced 8004 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8005
8006 * data.c (Qcompiled_function): Now static.
8007
c6f072e7
PE
8008 * window.c (window_body_lines): Now static.
8009
20ce5912
PE
8010 * image.c (gif_load): Rename local to avoid shadowing.
8011
9c4c5f81
PE
8012 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8013 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8014 * alloc.c (make_save_value): Integer argument is now of type
8015 ptrdiff_t, not int.
8016 (mark_object): Use ptrdiff_t, not int.
8017 * lisp.h (pD): New macro.
8018 * print.c (print_object): Use it.
8019
c0c5c8ae
PE
8020 * alloc.c: Use EMACS_INT, not int, to count objects.
8021 (total_conses, total_markers, total_symbols, total_vector_size)
8022 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8023 (total_free_floats, total_floats, total_free_intervals)
8024 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8025 Now EMACS_INT, not int. All uses changed.
8026 (Fgarbage_collect): Compute overall total using a double, so that
8027 integer overflow is less likely to be a problem. Check for overflow
8028 when converting back to an integer.
5a25e253
PE
8029 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8030 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8031 These were 'int' variables that could overflow on 64-bit hosts;
8032 they were never used, so remove them instead of repairing them.
211a0b2a 8033 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8034 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8035 Previously, this ceilinged at INT_MAX, but that doesn't work on
8036 64-bit machines.
e46bb31a 8037 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8038
c78baabf 8039 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8040 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8041 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8042 when a (possibly-narrower) signed value would do just as well.
8043 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8044
c9d624c6
PE
8045 * alloc.c: Catch some string size overflows that we were missing.
8046 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8047 for convenience in STRING_BYTES_MAX.
8048 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8049 The definition here is exact; the one in lisp.h was approximate.
8050 (allocate_string_data): Check for string overflow. This catches
8051 some instances we weren't catching before. Also, it catches
8052 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8053 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8054 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8055
c9d624c6
PE
8056 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8057 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8058 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8059
353032ce
PE
8060 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8061
2bccce07
PE
8062 * alloc.c (Fmake_string): Check for out-of-range init.
8063
0ac30604
SM
80642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8065
8066 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8067
c195f2de
JD
80682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8069
8070 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8071 xg_get_default_scrollbar_width.
8072
8073 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8074 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8075 (style_changed_cb): Call update_theme_scrollbar_width and call
8076 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8077 all frames (Bug#8505).
8078 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8079 Call gtk_window_set_resizable if HAVE_GTK3.
8080 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8081 and height if HAVE_GTK3 (Bug#8505).
8082 (scroll_bar_width_for_theme): New variable.
8083 (update_theme_scrollbar_width): New function.
8084 (xg_get_default_scrollbar_width): Move code to
8085 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8086 (xg_initialize): Call update_theme_scrollbar_width.
8087
8088 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8089
8090 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8091
e10ac9f1
MR
80922011-06-12 Martin Rudalics <rudalics@gmx.at>
8093
8094 * frame.c (make_frame): Call other_buffer_safely instead of
8095 other_buffer.
8096
8097 * window.c (temp_output_buffer_show): Call display_buffer with
8098 second argument Vtemp_buffer_show_specifiers and reset latter
8099 immediately after the call.
8100 (Vtemp_buffer_show_specifiers): New variable.
8101 (auto_window_vscroll_p, next_screen_context_lines)
8102 (Vscroll_preserve_screen_position): Remove leading asterisks from
8103 doc-strings.
8104
2d3c217e 81052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8106
7b7f97e8 8107 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8108 * buffer.c (Qclone_number): Remove for now, as it's unused.
8109 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8110 (record_buffer): Remove unused local.
8111 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8112 (set_frame_buffer_list): Remove; unused.
8113 * frame.h (other_visible_frames): Remove decl.
8114 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8115 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8116 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8117 if HAVE_GPM.
8118 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8119 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8120 Define only if HAVE_GPM.
8121 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8122 (update_hints_inhibit): Remove; never set. All uses removed.
8123 * widgetprv.h (emacsFrameClassRec): Remove decl.
8124 * window.c (delete_deletable_window): Now returns void, since it
8125 wasn't returning anything.
8126 (compare_window_configurations): Remove unused locals.
8127 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8128 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8129 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8130 the same widths as pointers. This follows up on the 2011-05-06 patch.
8131 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8132 * xterm.h: Likewise.
8133 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8134
1384b89e
JB
81352011-06-12 Juanma Barranquero <lekktu@gmail.com>
8136
8137 * makefile.w32-in: Update dependencies.
8138 (LISP_H): Add lib/intprops.h.
8139
1100a63c
CY
81402011-06-11 Chong Yidong <cyd@stupidchicken.com>
8141
8142 * image.c (gif_load): Add animation frame delay to the metadata.
8143 (syms_of_image): Use DEFSYM. New symbol `delay'.
8144
6198ccd0
MR
81452011-06-11 Martin Rudalics <rudalics@gmx.at>
8146
8147 * window.c (delete_deletable_window): Re-add.
8148 (Fset_window_configuration): Rewrite to handle dead buffers and
8149 consequently deletable windows.
8150 (window_tree, Fwindow_tree): Remove. Supply functionality in
8151 window.el.
8152 (compare_window_configurations): Simplify code.
8153
b6e3633c
AS
81542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8155
1ab0dee5
AS
8156 * image.c (imagemagick_load_image): Fix type mismatch.
8157 (Fimagemagick_types): Likewise.
8158
b6e3633c
AS
8159 * window.h (replace_buffer_in_windows): Declare.
8160
9397e56f
MR
81612011-06-11 Martin Rudalics <rudalics@gmx.at>
8162
8163 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8164 Qclone_number. Remove external declaration of Qdelete_window.
8165 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8166 code.
640c8776
SM
8167 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8168 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8169 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8170 buffer list implementation.
8171 (other_buffer_safely): New function.
8172 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8173 calls to replace_buffer_in_windows and
8174 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8175 if allowed.
8176 (record_buffer): Inhibit quitting and rewrite using quittable
8177 functions. Run Qbuffer_list_update_hook if allowed.
8178 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8179 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8180 Move switch-to-buffer to window.el.
9397e56f
MR
8181 (bury-buffer): Move to window.el.
8182 (Vbuffer_list_update_hook): New variable.
8183
8184 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8185 section.
8186
8187 * window.h (resize_frame_windows): Move up in code.
8188 (Fwindow_frame): Remove EXFUN.
8189 (replace_buffer_in_all_windows): Remove prototype.
8190 (replace_buffer_in_windows_safely): Add prototype.
8191
8192 * window.c: Declare Qdelete_window static again. Move down
8193 declaration of select_count.
8194 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8195 (Fother_window): Move to window.el.
8196 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8197 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8198 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8199 window.el.
8200 (replace_buffer_in_windows): Implement by calling
8201 Qreplace_buffer_in_windows.
8202 (replace_buffer_in_all_windows): Remove with some functionality
8203 moved into replace_buffer_in_windows_safely.
8204 (replace_buffer_in_windows_safely): New function.
8205 (select_window_norecord, select_frame_norecord): Move in front
8206 of run_window_configuration_change_hook. Remove now obsolete
8207 declarations.
640c8776
SM
8208 (Fset_window_buffer): Rewrite doc-string.
8209 Call Qrecord_window_buffer.
9397e56f
MR
8210 (keys_of_window): Move binding for other-window to window.el.
8211
b50691aa
CY
82122011-06-11 Chong Yidong <cyd@stupidchicken.com>
8213
8214 * dispextern.h (struct image): Replace data member, whose int_val
8215 and ptr_val fields were not used by anything, with a single
8216 lisp_val object.
8217
8218 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8219 (gif_clear_image, gif_load, imagemagick_load_image)
8220 (gs_clear_image, gs_load): Callers changed.
8221
3f754b86
PE
82222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8223
cca69397
PE
8224 * buffer.h: Include <time.h>, for time_t.
8225 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8226
109e28d0
PE
8227 Fix minor problems found by static checking.
8228
60737f02
PE
8229 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8230
4b66faf3
PE
8231 Make identifiers static if they are not used in other modules.
8232 * data.c (Qcompiled_function, Qframe, Qvector):
8233 * image.c (QimageMagick, Qsvg):
8234 * minibuf.c (Qmetadata):
8235 * window.c (resize_window_check, resize_root_window): Now static.
8236 * window.h (resize_window_check, resize_root_window): Remove decls.
8237
109e28d0
PE
8238 * window.c (window_deletion_count, delete_deletable_window):
8239 Remove; unused.
46a4ce9e
PE
8240 (window_body_lines): Now static.
8241 (Fdelete_other_windows_internal): Mark vars as initialized.
8242 Make sure 'resize_failed' is initialized.
8243 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8244 (resize_window_apply): Remove unused local.
8245 * window.h (delete_deletable_window): Remove decl.
8246
109e28d0 8247 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8248 (imagemagick_load_image): Fix pointer signedness problem by changing
8249 last arg from unsigned char * to char *. All uses changed.
8250 Also, fix a local for similar reasons.
8251 Remove unused locals. Remove locals to avoid shadowing.
8252 (fn_rsvg_handle_free): Remove; unused.
8253 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8254 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8255
3f754b86
PE
8256 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8257
2547adb1
CY
82582011-06-10 Chong Yidong <cyd@stupidchicken.com>
8259
8260 * image.c (gif_load): Fix omitted cast error introduced by
8261 2011-06-06 change.
8262
2c8e37d4
MR
82632011-06-10 Martin Rudalics <rudalics@gmx.at>
8264
8265 * window.h (resize_proportionally, orig_total_lines)
8266 (orig_top_line): Remove from window structure.
8267 (set_window_height, set_window_width, change_window_heights)
8268 (Fdelete_window): Remove prototypes.
8269 (resize_frame_windows): Remove duplicate declaration.
8270
440a42e3
EZ
82712011-06-10 Eli Zaretskii <eliz@gnu.org>
8272
8273 * window.h (resize_frame_windows, resize_window_check)
8274 (delete_deletable_window, resize_root_window)
8275 (resize_frame_windows): Declare prototypes.
8276
8277 * window.c (resize_window_apply): Make definition be "static" to
8278 match the prototype.
8279
562dd5e9
MR
82802011-06-10 Martin Rudalics <rudalics@gmx.at>
8281
8282 * window.c: Remove declarations of Qwindow_size_fixed,
8283 window_min_size_1, window_min_size_2, window_min_size,
8284 size_window, window_fixed_size_p, enlarge_window, delete_window.
8285 Remove static from declaration of Qdelete_window, it's
8286 temporarily needed by Fbury_buffer.
8287 (replace_window): Don't assign orig_top_line and
8288 orig_total_lines.
8289 (Fdelete_window, delete_window): Remove. Window deletion is
8290 handled by window.el.
640c8776
SM
8291 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8292 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8293 (Fdelete_other_windows): Remove. Deleting other windows is
8294 handled by window.el.
8295 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8296 handled in window.el.
8297 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8298 Window minimum sizes are handled in window.el.
8299 (shrink_windows, size_window, set_window_height)
8300 (set_window_width, change_window_heights, window_height)
8301 (window_width, CURBEG, CURSIZE, enlarge_window)
8302 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8303 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8304 handled in window.el.
8305 (make_dummy_parent): Rename to make_parent_window and give it a
8306 second argument horflag.
8307 (make_window): Don't set resize_proportionally any more.
8308 (Fsplit_window): Remove. Windows are split in window.el.
8309 (save_restore_action, save_restore_orig_size)
8310 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8311 Resize mini windows in window.el.
8312 (grow_mini_window, shrink_mini_window): Implement by calling
8313 Qresize_root_window_vertically, resize_window_check and
8314 resize_window_apply.
640c8776
SM
8315 (saved_window, Fset_window_configuration, save_window_save):
8316 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8317 resize_proportionally.
8318 (window_min_height, window_min_width): Move to window.el.
8319 (keys_of_window): Move bindings for delete-other-windows,
8320 split-window, delete-window and enlarge-window to window.el.
8321
8322 * buffer.c: Temporarily extern Qdelete_window.
8323 (Fbury_buffer): Temporarily call Qdelete_window instead of
8324 Fdelete_window (Fbury_buffer will move to window.el soon).
8325
8326 * frame.c (set_menu_bar_lines_1): Remove code handling
8327 orig_top_line and orig_total_lines.
8328
8329 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8330 set_window_height but set heights directly.
8331 (change_frame_size_1): Use resize_frame_windows.
8332
8333 * xdisp.c (init_xdisp): Don't use set_window_height but set
8334 heights directly.
8335
640c8776
SM
8336 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8337 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8338 run_window_configuration_change_hook.
8339
8340 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8341 instead of change_window_heights and run
8342 run_window_configuration_change_hook.
8343
1a13852e
MR
83442011-06-09 Martin Rudalics <rudalics@gmx.at>
8345
8346 * window.c (replace_window): Rename second argument REPLACEMENT to
8347 NEW. New third argument SETFLAG. Rewrite.
8348 (delete_window, make_dummy_parent): Call replace_window with
8349 third argument 1.
8350 (window_list_1): Move down in code.
8351 (run_window_configuration_change_hook): Move set_buffer part
8352 before select_frame_norecord part in order to unwind correctly.
8353 Rename count1 to count.
8354 (recombine_windows, delete_deletable_window, resize_root_window)
8355 (Fdelete_other_windows_internal)
8356 (Frun_window_configuration_change_hook, make_parent_window)
8357 (resize_window_check, resize_window_apply, Fresize_window_apply)
8358 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8359 (Fdelete_window_internal, Fresize_mini_window_internal):
8360 New functions.
1a13852e
MR
8361 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8362
f3d1777e
MR
83632011-06-08 Martin Rudalics <rudalics@gmx.at>
8364
496e208e
MR
8365 * window.h (window): Add some new members to window structure -
8366 normal_lines, normal_cols, new_total, new_normal, clone_number,
8367 splits, nest, prev_buffers, next_buffers.
8368 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8369 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8370
f3d1777e
MR
8371 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8372 Remove.
496e208e
MR
8373 (make_dummy_parent): Set new members of windows structure.
8374 (make_window): Move down in code. Handle new members of window
8375 structure.
8376 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8377 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8378 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8379 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8380 (Fset_window_next_buffers, Fset_window_clone_number):
8381 New functions.
496e208e
MR
8382 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8383 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8384 Doc-string fixes.
8385 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8386 Argument WINDOW can be now internal window too.
8387 (Fwindow_use_time): Move up in code.
8388 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8389 Rewrite doc-string.
8390 (Fset_window_configuration, saved_window)
8391 (Fcurrent_window_configuration, save_window_save): Handle new
8392 members of window structure.
b9e809c2
MR
8393 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8394 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8395 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8396 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8397 Qget_mru_window, Qresize_root_window,
8398 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8399 Qauto_buffer_name; staticpro them.
f3d1777e 8400
abde8f8c
MR
84012011-06-07 Martin Rudalics <rudalics@gmx.at>
8402
8403 * window.c (Fwindow_total_size, Fwindow_left_column)
8404 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8405 (Fwindow_list_1): New functions.
8406 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8407 (Fwindow_width, Fscroll_left, Fscroll_right):
8408 Use window_body_cols instead of window_box_text_cols.
8409 (delete_window, Fset_window_configuration):
8410 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8411 (delete_all_subwindows): Take a window as argument and not a
8412 structure. Rewrite.
190b47e6
MR
8413 (window_loop): Remove handling of GET_LRU_WINDOW and
8414 GET_LARGEST_WINDOW.
8415 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8416
8417 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8418 window_box_text_cols. delete_all_subwindows now takes a
8419 Lisp_Object as argument.
abde8f8c 8420
640c8776
SM
8421 * indent.c (compute_motion, Fcompute_motion):
8422 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8423
fa8a67e6
MR
8424 * frame.c (delete_frame): Call delete_all_subwindows with root
8425 window as argument.
8426
a54e3482
DC
84272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8428
8429 * fns.c (Fputhash): Document return value.
8430
60002bf5
CY
84312011-06-06 Chong Yidong <cyd@stupidchicken.com>
8432
8433 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8434
0c671da6 84352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8436
b862a52a 8437 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8438
be44ca6c
PE
8439 Check for overflow when converting integer to cons and back.
8440 * charset.c (Fdefine_charset_internal, Fdecode_char):
8441 Use cons_to_unsigned to catch overflow.
8442 (Fencode_char): Use INTEGER_TO_CONS.
8443 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8444 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8445 * data.c (long_to_cons, cons_to_long): Remove.
8446 (cons_to_unsigned, cons_to_signed): New functions.
8447 These signal an error for invalid or out-of-range values.
8448 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8449 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8450 * font.c (Ffont_variation_glyphs):
8451 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8452 * lisp.h: Include <intprops.h>.
8453 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8454 (cons_to_signed, cons_to_unsigned): New decls.
8455 (long_to_cons, cons_to_long): Remove decls.
8456 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8457 (Fprimitive_undo): Use CONS_TO_INTEGER.
8458 * xfns.c (Fx_window_property): Likewise.
8459 * xselect.c: Include <limits.h>.
8460 (x_own_selection, selection_data_to_lisp_data):
8461 Use INTEGER_TO_CONS.
8462 (x_handle_selection_request, x_handle_selection_clear)
8463 (x_get_foreign_selection, Fx_disown_selection_internal)
8464 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8465 (lisp_data_to_selection_data): Use cons_to_unsigned.
8466 (x_fill_property_data): Use cons_to_signed.
8467 Report values out of range.
8468
d1f3d2af
PE
8469 Check for buffer and string overflow more precisely.
8470 * buffer.h (BUF_BYTES_MAX): New macro.
8471 * lisp.h (STRING_BYTES_MAX): New macro.
8472 * alloc.c (Fmake_string):
8473 * character.c (string_escape_byte8):
8474 * coding.c (coding_alloc_by_realloc):
8475 * doprnt.c (doprnt):
8476 * editfns.c (Fformat):
8477 * eval.c (verror):
8478 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8479 since they may not be the same number.
8480 * editfns.c (Finsert_char):
8481 * fileio.c (Finsert_file_contents):
8482 Likewise for BUF_BYTES_MAX.
8483
dd52fcea
PE
8484 * image.c: Use ptrdiff_t, not int, for sizes.
8485 (slurp_file): Switch from int to ptrdiff_t.
8486 All uses changed.
8487 (slurp_file): Check that file size fits in both size_t (for
8488 malloc) and ptrdiff_t (for sanity and safety).
8489
7f9bbdbb
PE
8490 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8491 if b->modtime has its maximal value.
8492
dfe18f82
PE
8493 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8494
84acfcf0
PE
8495 Don't assume time_t can fit into int.
8496 * buffer.h (struct buffer.modtime): Now time_t, not int.
8497 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8498 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8499
ccd9a01a
PE
8500 Minor fixes for signed vs unsigned integers.
8501 * character.h (MAYBE_UNIFY_CHAR):
8502 * charset.c (maybe_unify_char):
8503 * keyboard.c (read_char, reorder_modifiers):
8504 XINT -> XFASTINT, since the integer must be nonnegative.
8505 * ftfont.c (ftfont_spec_pattern):
8506 * keymap.c (access_keymap, silly_event_symbol_error):
8507 XUINT -> XFASTINT, since the integer must be nonnegative.
8508 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8509 since it makes no difference and we prefer signed.
8510 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8511 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8512 nonnegative.
8513
d6d100dd
SM
85142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8515
8516 * window.h (Fwindow_frame): Declare.
8517
2b6148e4
PE
85182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8519
8520 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8521 (SPARE_MEMORY): Always define.
8522 (LARGE_REQUEST): Remove.
8523 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8524
f230ecc9
MR
85252011-06-06 Martin Rudalics <rudalics@gmx.at>
8526
727e958e
MR
8527 * lisp.h: Move EXFUNS for Fframe_root_window,
8528 Fframe_first_window and Fset_frame_selected_window to window.h.
8529
8530 * window.h: Move EXFUNS for Fframe_root_window,
8531 Fframe_first_window and Fset_frame_selected_window here from
8532 lisp.h.
8533
8534 * frame.c (Fwindow_frame, Fframe_first_window)
8535 (Fframe_root_window, Fframe_selected_window)
8536 (Fset_frame_selected_window): Move to window.c.
8537 (Factive_minibuffer_window): Move to minibuf.c.
8538 (Fother_visible_frames_p): New function.
8539
8540 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8541
f230ecc9
MR
8542 * window.c (decode_window, decode_any_window): Move up in code.
8543 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8544 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8545 (Fwindow_buffer): Move up and rewrite doc-string.
8546 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8547 (Fwindow_prev): New functions.
727e958e
MR
8548 (Fwindow_frame): Move here from frame.c. Accept any window as
8549 argument.
8550 (Fframe_root_window, Fframe_first_window)
8551 (Fframe_selected_window): Move here from frame.c. Accept frame
8552 or arbitrary window as argument. Update doc-strings.
8553 (Fminibuffer_window): Move up in code.
8554 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8555 (Fset_frame_selected_window): Move here from frame.c.
8556 Marginal rewrite.
727e958e
MR
8557 (Fselected_window, select_window, Fselect_window): Move up in
8558 code. Minor doc-string fixes.
f230ecc9 8559
4d09bcf6
PE
85602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8561
8562 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8563 Do not assume that spare memory exists; that assumption is valid
8564 only if SYSTEM_MALLOC.
8565 (LARGE_REQUEST): New macro, so that the issue of large requests
8566 is separated from the issue of spare memory.
8567
810928a2
AS
85682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8569
172418ad
AS
8570 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8571 format. (Bug#8806)
8572
43f862f7
AS
8573 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8574
810928a2
AS
8575 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8576 before statements.
8577
a059fe24
JD
85782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8579
8580 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8581
8582 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8583
8584 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8585 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8586
989bf368
JB
85872011-06-05 Juanma Barranquero <lekktu@gmail.com>
8588
8589 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8590
4b80f674
CY
85912011-06-04 Chong Yidong <cyd@stupidchicken.com>
8592
8593 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8594 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8595 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8596 New error handlers.
4b80f674
CY
8597 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8598 Obey Vx_select_enable_clipboard_manager. Catch errors in
8599 x_clipboard_manager_save (Bug#8779).
8600 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8601 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8602
99a33b77 86032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8604
8605 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8606
99a33b77 86072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8608
8609 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8610 in the current matrix if keep_current_p is non-zero.
8611
8264569d
EZ
86122011-06-04 Eli Zaretskii <eliz@gnu.org>
8613
8614 * bidi.c (bidi_level_of_next_char): Fix last change.
8615
57f97249
EZ
86162011-06-03 Eli Zaretskii <eliz@gnu.org>
8617
fec2107c 8618 Support bidi reordering of text covered by display properties.
57f97249 8619
fec2107c
EZ
8620 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8621 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8622 (bidi_cache_search, bidi_cache_iterator_state)
8623 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8624 (bidi_level_of_next_char, bidi_move_to_visually_next):
8625 Support character positions inside a run of characters covered by a
fec2107c
EZ
8626 display string.
8627 (bidi_paragraph_init, bidi_resolve_explicit_1)
8628 (bidi_level_of_next_char): Call bidi_fetch_char and
8629 bidi_fetch_char_advance instead of FETCH_CHAR and
8630 FETCH_CHAR_ADVANCE.
8631 (bidi_init_it): Initialize new members.
8632 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8633 definitions.
8634 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8635 instead of using explicit *_CHAR codes.
d6d100dd
SM
8636 (bidi_resolve_explicit, bidi_resolve_weak):
8637 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8638 bidirectional text is supported only in multibyte buffers.
8639 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8640 it to initialize the frame_window_p member of struct bidi_it.
8641 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8642 (bidi_resolve_explicit, bidi_resolve_weak)
8643 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8644 bidi_it->nchars is non-positive.
8645 (bidi_level_of_next_char): Don't try to lookup the cache for the
8646 next/previous character if nothing is cached there yet, or if we
8647 were just reseat()'ed to a new position.
c40e2fb2 8648
0e14fe90
EZ
8649 * xdisp.c (set_cursor_from_row): Set start and stop points
8650 according to the row's direction when priming the loop that looks
8651 for the glyph on which to display cursor.
8652 (single_display_spec_intangible_p): Function deleted.
8653 (display_prop_intangible_p): Reimplement to call
8654 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8655 Accept 3 additional arguments needed by handle_display_spec.
8656 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8657 values: lists, `(when COND...)' forms, etc.
8658 (single_display_spec_string_p): Support property values that are
8659 lists with the argument STRING its top-level element.
8660 (display_prop_string_p): Fix the condition for processing a
8661 property that is a list to be consistent with handle_display_spec.
fec2107c 8662 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8663 last portion of handle_display_prop.
8664 (compute_display_string_pos): Accept additional argument
8665 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8666 value of a `display' property is a "replacing spec".
8667 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8668 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8669 the display property, but just return a value indicating whether
8670 the display property will replace the characters it covers.
8671 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8672 frame_window_p members of struct bidi_it.
d6d100dd
SM
8673 (compute_display_string_pos, compute_display_string_end):
8674 New functions.
fec2107c
EZ
8675 (push_it): Accept second argument POSITION, where pop_it should
8676 jump to continue iteration.
8677 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8678
fec2107c
EZ
8679 * keyboard.c (adjust_point_for_property): Adjust the call to
8680 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8681
8682 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8683 (bidi_init_it): Update prototypes.
8684 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8685 (compute_display_string_pos, compute_display_string_end):
8686 Declare prototypes.
fec2107c
EZ
8687 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8688 EMACS_INT.
fc6f18ce 8689
40087514 86902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8691
57f53182
PE
8692 Malloc failure behavior now depends on size of allocation.
8693 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8694 * lisp.h: Change signatures accordingly.
8695 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8696 All callers changed. (Bug#8762)
8697
8698 * gnutls.c: Use Emacs's memory allocators.
8699 Without this change, the gnutls library would invoke malloc etc.
8700 directly, which causes problems on non-SYNC_INPUT hosts, and which
8701 runs afoul of improving memory_full behavior. (Bug#8761)
8702 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8703 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8704 xfree instead of the default malloc, realloc, free.
8705 (Fgnutls_boot): No need to check for memory allocation failure,
8706 since xmalloc does that for us.
8707
ac32cd99 8708 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8709 * category.c (hash_get_category_set):
8710 * ccl.c (ccl_driver):
8711 * charset.c (Fdefine_charset_internal):
8712 * charset.h (struct charset.hash_index):
8713 * composite.c (get_composition_id, gstring_lookup_cache)
8714 (composition_gstring_put_cache):
8715 * composite.h (struct composition.hash_index):
8716 * dispextern.h (struct image.hash):
8717 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8718 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8719 (hashfn_equal, hashfn_user_defined, make_hash_table)
8720 (maybe_resize_hash_table, hash_lookup, hash_put)
8721 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8723 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8724 * image.c (make_image, search_image_cache, lookup_image)
8725 (xpm_put_color_table_h):
8726 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8727 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8728 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8729 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8730 * alloc.c (allocate_vectorlike):
8731 Check for overflow in vector size calculations.
8732 * ccl.c (ccl_driver):
8733 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8734 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8735 need to be updated by these changes.
40087514
PE
8736 * fns.c (make_hash_table, maybe_resize_hash_table):
8737 Check for integer overflow with large hash tables.
0de4bb68
PE
8738 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8739 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8740 (SXHASH_REDUCE): New macro.
8741 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8742 Use it instead of discarding useful hash info with large hash values.
8743 (sxhash_float): New function.
8744 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8745 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8746 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8747 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8748 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8749 Adjust signatures to match updated version of code.
8750 (consing_since_gc): Now EMACS_INT, since a single hash table can
8751 use more than INT_MAX bytes.
8752
698d32e2
DN
87532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8754
8755 Make it possible to build with GCC-4.6+ -O2 -flto.
8756
8757 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8758
fd6fa53f
SM
87592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8760
8761 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8762 Call minibuffer-inactive-mode.
8763
864db017
JB
87642011-05-31 Juanma Barranquero <lekktu@gmail.com>
8765
8766 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8767 Update dependencies.
8768
2ad0baf4
DN
87692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8770
8771 * data.c (init_data): Remove code for UTS, this system is not
8772 supported anymore.
8773
4fcc2638
DN
87742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8775
8776 Don't force ./temacs to start in terminal mode.
8777
8778 * frame.c (make_initial_frame): Initialize faces in all cases, not
8779 only when CANNOT_DUMP is defined.
8780 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8781
c56e0fd5
DN
87822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8783
8784 * dispnew.c (add_window_display_history): Use const for the string
8785 pointer. Remove declaration, not needed.
8786
333d54da 87872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8788
55d4c1b2 8789 Use 'inline', not 'INLINE'.
333d54da 8790 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8791 * alloc.c, fontset.c (INLINE): Remove.
8792 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8793 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8794 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8795 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8796 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8797
738db178
DN
87982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8799
8800 Make it possible to run ./temacs.
8801
8802 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8803 syms_of_callproc does the same thing. Remove test for
8804 "initialized", do it in the caller.
8805 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8806
620c53a6
SM
88072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8808
8809 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8810 (read_minibuf): Use get_minibuffer.
8811 (syms_of_minibuf): Use DEFSYM.
8812 (Qmetadata): New var.
8813 * data.c (Qbuffer): Don't make it static.
8814 (syms_of_data): Use DEFSYM.
8815
e003a292
PE
88162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8817
8818 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8819 (CCL_CODE_MIN): New macro.
8820
ed008a6d
PE
88212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8822
3687c2ef
PE
8823 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8824
ed008a6d
PE
8825 * eval.c (Qdebug): Now static.
8826 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8827 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8828 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8829
d66c4c7c
CY
88302011-05-29 Chong Yidong <cyd@stupidchicken.com>
8831
8832 * image.c: Various fixes to ImageMagick code comments.
8833 (Fimagemagick_types): Doc fix.
8834
5fbc2025
PE
88352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8836
0196f88a
PE
8837 Minor fixes prompted by GCC 4.6.0 warnings.
8838
8839 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8840
5fbc2025
PE
8841 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8842 (x_clipboard_manager_save_all): Move extern decl to ...
8843 * xterm.h: ... here, so that it can be checked for consistency.
8844
1dd3c2d9
CY
88452011-05-29 Chong Yidong <cyd@stupidchicken.com>
8846
8847 * xselect.c (x_clipboard_manager_save_frame)
8848 (x_clipboard_manager_save_all): New functions.
8849 (Fx_clipboard_manager_save): Lisp function deleted.
8850
8851 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8852 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8853
8854 * xterm.h: Update prototype.
8855
5ba6571d
WX
88562011-05-28 William Xu <william.xwl@gmail.com>
8857
8858 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8859 exiting (Bug#8239).
8860
3eaff834
JM
88612011-05-28 Jim Meyering <meyering@redhat.com>
8862
e1900994 8863 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8864 * fns.c (to_uchar): Define.
8865 (crypto_hash_function): Use it to convert some newly-signed
8866 variables to unsigned, to avoid sign-extension bugs. For example,
8867 without this change, (md5 "truc") would evaluate to
8868 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8869 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8870 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8871
0f6990a7
PE
88722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8873
8874 Integer overflow fixes.
c8a9ca5a 8875
08686060
PE
8876 * dbusbind.c: Serial number integer overflow fixes.
8877 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8878 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8879 to hold a serial number that is too large for a fixnum.
8880 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8881 Check for serial numbers out of range. Decode any serial number
59568bf0 8882 that was so large that it became a float. (Bug#8722)
08686060 8883
2d1fc3c7
PE
8884 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8885 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8886 Use XFASTINT rather than XUINT when numbers are nonnegative.
8887 (xd_append_arg, Fdbus_method_return_internal):
8888 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8889 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8890 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8891 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8892 (Bug#8722)
2d1fc3c7 8893
c8a9ca5a
PE
8894 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8895
519e1d69
PE
8896 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8897
6df6ae42 8898 ccl: Add integer overflow checks.
30569699
PE
8899 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8900 (IN_INT_RANGE): New macros.
8901 (ccl_driver): Use them to check for integer overflow when
8902 decoding a CCL program. Many of the new checks are whether XINT (x)
8903 fits in int; it doesn't always, on 64-bit hosts. The new version
8904 doesn't catch all possible integer overflows, but it's an
847044ea 8905 improvement. (Bug#8719)
30569699 8906
c11285dc
PE
8907 * alloc.c (make_event_array): Use XINT, not XUINT.
8908 There's no need for unsigned here.
8909
fdccd48e
PE
8910 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8911 This follows up to the 2011-05-06 change that substituted uintptr_t
8912 for EMACS_INT. This case wasn't caught back then.
8913
37910ab2
PE
8914 Rework Fformat to avoid integer overflow issues.
8915 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8916 now (part of C89). Include <verify.h>.
8917 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8918 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8919 (Fformat): Avoid the prepass trying to compute sizes; it was only
8920 approximate and thus did not catch overflow reliably. Instead, walk
8921 through the format just once, formatting and computing sizes as we go,
8922 checking for integer overflow at every step, and allocating a larger
8923 buffer as needed. Keep track separately whether the format is
8924 multibyte. Keep only the most-recently calculated precision, rather
8925 than them all. Record whether each argument has been converted to
8926 string. Use EMACS_INT, not int, for byte and char and arg counts.
8927 Support field widths and precisions larger than INT_MAX. Avoid
8928 sprintf's undefined behavior with conversion specifications such as %#d
8929 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8930 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8931 formatting out-of-range floating point numbers with int
9173deec 8932 formats. (Bug#8668)
37910ab2 8933
2e6578fb
PE
8934 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8935
0ae6bdee
PE
8936 * data.c: Avoid integer truncation in expressions involving floats.
8937 * data.c: Include <intprops.h>.
8938 (arith_driver): When there's an integer overflow in an expression
8939 involving floating point, convert the integers to floating point
8940 so that the resulting value does not suffer from catastrophic
8941 integer truncation. For example, on a 64-bit host (* 4
8942 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8943 Do not rely on undefined behavior after integer overflow.
8944
de883a70
PE
8945 merge count_size_as_multibyte, parse_str_to_multibyte
8946 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8947 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8948 Check for integer overflow.
8949 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8950 since it's now a duplicate of the other. This is more of
8951 a character than a buffer op, so better that it's in character.c.
8952 * fns.c, print.c: Adjust to above changes.
8953
2ff916cb
PE
89542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8955
8956 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8957
f1b54466
PE
89582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8959
fb1ac845
PE
8960 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8961 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8962 (x_clipboard_manager_save): Now static.
8963 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8964
f1b54466
PE
8965 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8966 (crypto_hash_function): Now static.
8967 Fix pointer signedness problems. Avoid unnecessary initializations.
8968
a9f737ee
CY
89692011-05-27 Chong Yidong <cyd@stupidchicken.com>
8970
8971 * termhooks.h (Vselection_alist): Make it terminal-local.
8972
8973 * terminal.c (create_terminal): Initialize it.
8974
8975 * xselect.c: Support for clipboard managers.
8976 (Vselection_alist): Move to termhooks.h as terminal-local var.
8977 (LOCAL_SELECTION): New macro.
8978 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8979 (symbol_to_x_atom): Remove gratuitous arg.
8980 (x_handle_selection_request, lisp_data_to_selection_data)
8981 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8982 (x_own_selection, x_get_local_selection, x_convert_selection):
8983 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8984 (some_frame_on_display): Delete unused function.
8985 (Fx_own_selection_internal, Fx_get_selection_internal)
8986 (Fx_disown_selection_internal, Fx_selection_owner_p)
8987 (Fx_selection_exists_p): New optional frame arg.
8988 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8989 (x_handle_selection_clear): Don't treat other terminals with the
8990 same keyboard specially. Use the terminal-local Vselection_alist.
8991 (x_clear_frame_selections): Use Frun_hook_with_args.
8992
8993 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8994
8995 * xterm.h: Add support for those atoms.
8996
e067f0c1
CY
89972011-05-26 Chong Yidong <cyd@stupidchicken.com>
8998
8999 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9000 (converted_selections, conversion_fail_tag): New global variables.
9001 (x_selection_request_lisp_error): Free the above.
9002 (x_get_local_selection): Remove unnecessary code.
9003 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9004 of converted selections stored in converted_selections.
9005 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9006 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9007 (x_convert_selection): New function.
9008 (x_handle_selection_event): Simplify.
9009 (x_get_foreign_selection): Don't ignore incoming requests while
9010 waiting for an answer; this will fail when we implement
9011 SAVE_TARGETS, and seems unnecessary anyway.
9012 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9013 (Vx_sent_selection_functions): Doc fix.
9014
0f4aebc0
LL
90152011-05-26 Leo Liu <sdl.web@gmail.com>
9016
9017 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9018
e61124cd
YM
90192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9020
9021 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9022
9023 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9024 for fringe update if it has periodic bitmap.
ac389d0c 9025 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9026 and fringe_bitmap_periodic_p.
9027
9028 * fringe.c (get_fringe_bitmap_data): New function.
9029 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9030 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9031 row. Mark glyph row for fringe update if periodicity changed.
9032
9033 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9034 for fringe update unless it has periodic bitmap.
9035
f16d9837
KH
90362011-05-25 Kenichi Handa <handa@m17n.org>
9037
9038 * xdisp.c (get_next_display_element): Set correct it->face_id for
9039 a static composition.
9040
e1b90ef6
LL
90412011-05-24 Leo Liu <sdl.web@gmail.com>
9042
9043 * deps.mk (fns.o):
9044 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9045
9046 * fns.c (crypto_hash_function, Fsha1): New function.
9047 (Fmd5): Use crypto_hash_function.
9048 (syms_of_fns): Add Ssha1.
9049
7400048f
PE
90502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9051
9052 * gnutls.c: Remove unused macros.
9053 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9054 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9055 Remove macros that are defined and never used.
9056 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9057
abb71cf4
CY
90582011-05-22 Chong Yidong <cyd@stupidchicken.com>
9059
9060 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9061 (Fx_get_selection_internal): Minor cleanup.
9062 (Fx_own_selection_internal): Rename arguments for consistency with
9063 select.el.
9064
6307db39
PE
90652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9066
9067 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9068
f3d4e0a4
CY
90692011-05-22 Chong Yidong <cyd@stupidchicken.com>
9070
9071 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9072
4d8ade89
YM
90732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9074
9075 * dispnew.c (scrolling_window): Don't exclude the case that the
9076 last enabled row in the desired matrix touches the bottom boundary.
9077
32078c8d
GM
90782011-05-21 Glenn Morris <rgm@gnu.org>
9079
9080 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9081 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9082 and add some more files.
32078c8d 9083
7285dc67
EZ
90842011-05-20 Eli Zaretskii <eliz@gnu.org>
9085
9086 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9087 report_file_error introduced by the change from 2011-05-07.
9088
89d1bd22
PE
90892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9090
9091 * systime.h (Time): Define only if emacs is defined.
9092 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9093 where the include path doesn't have X11/X.h by default. See
9094 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9095
cd394be1 90962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9097
9098 * composite.c (find_automatic_composition): Fix previous change.
9099
b9704ad9
GM
91002011-05-20 Glenn Morris <rgm@gnu.org>
9101
9102 * lisp.mk: New file, split from Makefile.in.
9103 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9104 (shortlisp): Remove.
9105 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9106
4a720484
GM
91072011-05-19 Glenn Morris <rgm@gnu.org>
9108
9109 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9110 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9111 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9112 (lisp): Set the order to that of loadup.el.
9113 (shortlisp): Make it a copy of $lisp.
9114 (SOME_MACHINE_LISP): Remove.
9115 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9116 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9117
a28d4396
KH
91182011-05-18 Kenichi Handa <handa@m17n.org>
9119
9120 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9121 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9122 (find_automatic_composition): Mostly rewrite for efficiency.
9123
a2b1fa8e
JB
91242011-05-18 Juanma Barranquero <lekktu@gmail.com>
9125
9126 * makefile.w32-in: Update dependencies.
9127
8e1f5610
CS
91282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9129
9130 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9131 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9132
7025ee00 91332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9134
cdfa6eab
PE
9135 Fix some integer overflow issues, such as string length overflow.
9136
06d6db33
PE
9137 * insdel.c (count_size_as_multibyte): Check for string overflow.
9138
2b4560a8
PE
9139 * character.c (lisp_string_width): Check for string overflow.
9140 Use EMACS_INT, not int, for string indexes and lengths; in
9141 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9142 the resulting string length overflows an EMACS_INT; instead,
9143 report a string overflow if no precision given. When checking for
9144 precision exhaustion, use a check that cannot possibly have
9145 integer overflow. (Bug#8675)
9146 * character.h (lisp_string_width): Adjust to new signature.
9147
cb93f9be
PE
9148 * alloc.c (string_overflow): New function.
9149 (Fmake_string): Use it. This doesn't change behavior, but saves
9150 a few bytes and will simplify future changes.
9151 * character.c (string_escape_byte8): Likewise.
9152 * lisp.h (string_overflow): New decl.
9153
1a1f3366
PE
9154 Fixups, following up to the user-interface timestamp change.
9155 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9156 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9157 * msdos.c (mouse_get_pos): Likewise.
9158 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9159 * w32gui.h (Time): Define by including "systime.h" rather than by
9160 declaring it ourselves. (Bug#8664)
9161
d4e3e4d3
PE
9162 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9163 * image.c (clear_image_cache): Likewise.
9164
f6a24d19
PE
9165 * term.c (term_mouse_position): Don't assume time_t wraparound.
9166
08dc5ae6
PE
9167 Be more systematic about user-interface timestamps.
9168 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9169 and sometimes 'EMACS_UINT', to represent these timestamps.
9170 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9171 This makes the code easier to follow, and makes it easier to catch
9172 integer overflow bugs such as Bug#8664.
9173 * frame.c (Fmouse_position, Fmouse_pixel_position):
9174 Use Time, not unsigned long, for user-interface timestamps.
9175 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9176 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9177 * keyboard.h (last_event_timestamp): Likewise.
9178 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9179 * menu.h (xmenu_show): Likewise.
9180 * term.c (term_mouse_position): Likewise.
9181 * termhooks.h (struct input_event.timestamp): Likewise.
9182 (struct terminal.mouse_position_hook): Likewise.
9183 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9184 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9185 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9186 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9187 what it was before.
9188 * menu.h, termhooks.h: Include "systime.h", for Time.
9189
8e55734a
PE
9190 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9191 Don't assume that the difference between two unsigned long values
9192 can fit into an integer. At this point, we know button_down_time
9193 <= event->timestamp, so the difference must be nonnegative, so
9194 there's no need to cast the result if double-click-time is
9195 nonnegative, as it should be; check that it's nonnegative, just in
9196 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9197 apart (about 25 days). (Bug#8664)
8e55734a 9198
841f1b75 9199 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9200 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9201
3e26f69c
PE
9202 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9203 that always fit in int. Use a sentinel instead of a counter, to
9204 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9205 * frame.h (struct frame): Use int for menu_bar_items_used
9206 instead of EMACS_INT, since it always fits in int.
3e26f69c 9207
5cc152c0
PE
9208 * menu.c (grow_menu_items): Check for int overflow.
9209
d89eb65e
PE
9210 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9211
5235bd3e
PE
9212 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9213 Before, the code was not consistent. These values cannot exceed
9214 2**31 - 1 so there's no need to make them unsigned.
9215 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9216 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9217 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9218 as modifiers.
9219 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9220
bc827e23
PE
9221 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9222 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9223 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9224 presumably because the widths might not match.
9225
78eb494e
PE
9226 * window.c (size_window): Avoid needless test at loop start.
9227
04f2d78b
CB
92282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9229
9230 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9231
d2fc7e3d 92322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9233
9234 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9235
d2fc7e3d 92362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9237
9238 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9239 `width' to `bar_area_x' and `bar_area_width', respectively.
9240 (x_scroll_run): Take account of fringe background extension.
9241
04f2d78b
CB
9242 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9243 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9244 `bar_area_width', respectively.
9245 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9246 background extension.
9247
79b70037
GM
92482011-05-10 Jim Meyering <meyering@redhat.com>
9249
9250 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9251
2f142cc5
JB
92522011-05-10 Juanma Barranquero <lekktu@gmail.com>
9253
9254 * image.c (Finit_image_library): Return t for built-in image types,
9255 like pbm and xbm. (Bug#8640)
9256
57679c86
AS
92572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9258
9259 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9260
888c9e86
EZ
92612011-05-07 Eli Zaretskii <eliz@gnu.org>
9262
b0512a1d
EZ
9263 * w32console.c (Fset_screen_color): Doc fix.
9264 (Fget_screen_color): New function.
9265 (syms_of_ntterm): Defsubr it.
9266
7285dc67
EZ
9267 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9268 unlink the temporary file if Fcall_process didn't create it in the
9269 first place.
9270 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9271 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9272 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9273 cue to call_process_cleanup not to close that handle.
9274
4d3fcc8e
BK
92752011-05-07 Ben Key <bkey76@gmail.com>
9276
9277 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9278 one of two shell specific rules, either bootstrap-temacs-CMD or
9279 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9280 to the previous implementation of the bootstrap-temacs rule.
9281 The bootstrap-temacs-CMD rule is similar to the previous
9282 implementation of the bootstrap-temacs rule except that it
9283 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9284 variable.
9285
9286 These changes, along with some changes to nt/configure.bat,
9287 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9288 earlier fix to add support for --cflags and --ldflags options
9289 that include quotes so that it works whether make uses cmd or
9290 sh as the shell.
9291
b4289b64
MA
92922011-05-06 Michael Albinus <michael.albinus@gmx.de>
9293
9294 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9295 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9296 is a constant.
9297 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9298 a string. Handle both cases.
9299 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9300 (Fdbus_register_method): Use Qinvalid_function.
9301
af4c0e28
JB
93022011-05-06 Juanma Barranquero <lekktu@gmail.com>
9303
9304 * makefile.w32-in: Update dependencies.
9305 (LISP_H): Add inttypes.h and stdin.h.
9306 (PROCESS_H): Add unistd.h.
9307
c51453d9
EZ
93082011-05-06 Eli Zaretskii <eliz@gnu.org>
9309
9310 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9311 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9312
8ff0ac3c 93132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9314
4c4b566b
PE
9315 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9316
aab2b9b5
PE
9317 * term.c (vfatal): Remove stray call to va_end.
9318 It's not needed and the C Standard doesn't allow it here anyway.
9319
c378da0b
PE
9320 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9321 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9322
288b08c7
PE
9323 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9324 bytes.
9325
e3601888
PE
9326 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9327
db6c0e74
PE
9328 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9329
dd5963ea
PE
9330 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9331
88c9450f
PE
9332 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9333
2f9442b8
PE
9334 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9335
c032b5f8
PE
9336 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9337 * charset.c (Fdefine_charset_internal): Don't initialize
9338 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9339 32-bit int (Bug#8600).
a108c10b
PE
9340
9341 * lread.c (read_integer): Be more consistent with string-to-number.
9342 Use string_to_number to do the actual conversion; this avoids
9343 rounding errors and fixes some other screwups. Without this fix,
9344 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9345 (digit_to_number): Move earlier, for benefit of read_integer.
9346 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9347 not a digit in any supported base. (Bug#8602)
a108c10b 9348
ad5f9eea
PE
9349 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9350
aec1708a
PE
9351 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9352 to match comment at start of function. This also removes a
9353 GCC warning about overflow in a 32+64-bit port.
9354
47be4ab5
PE
9355 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9356
371cac43
PE
9357 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9358 Reported by Stefan Monnier in
9359 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9360 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9361 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9362
d01a7826
PE
9363 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9364 (EMACS_UINTPTR): Likewise, with uintptr_t.
9365
7fd47d5c
PE
9366 * lisp.h: Prefer 64-bit EMACS_INT if available.
9367 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9368 on 32-bit hosts that have 64-bit int, so that they can access
9369 large files.
122b0c86
PE
9370 However, temporarily disable this change unless the temporary
9371 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9372
8727937b
PE
9373 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9374
8ac068ac
PE
9375 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9376 This removes an assumption that EMACS_INT and long are the same
9377 width as pointers. The assumption is true for Emacs porting targets
9378 now, but we want to make other targets possible.
9379 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9380 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9381 In the rest of the code, change types of integers that hold casted
9382 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9383 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9384 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9385 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9386 No need to cast type when ORing.
9387 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9388 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9389 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9390 assume EMACS_INT is the same width as char *.
9391 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9392 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9393 Remove no-longer-needed casts.
9394 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9395 (xg_tool_bar_help_callback, xg_make_tool_item):
9396 Use EMACS_INTPTR to hold an integer
9397 that will be cast to void *; this can avoid a GCC warning
9398 if EMACS_INT is not the same width as void *.
9399 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9400 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9401 (current_message_1, set_message_1):
9402 Use a local to convert to proper width without a cast.
9403 * xmenu.c (dialog_selection_callback): Likewise.
9404
ede49d71
PE
9405 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9406 Also, don't assume VALBITS / RAND_BITS is less than 5,
9407 and don't rely on undefined behavior when shifting a 1 left into
9408 the sign bit.
9409 * lisp.h (get_random): Change signature to match.
9410
2f30ecd0
PE
9411 * lread.c (hash_string): Use size_t, not int, for hash computation.
9412 Normally we prefer signed values; but hashing is special, because
9413 it's better to use unsigned division on hash table sizes so that
9414 the remainder is nonnegative. Also, size_t is the natural width
9415 for hashing into memory. The previous code used 'int', which doesn't
9416 retain enough info to hash well into very large tables.
9417 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9418
2a866e7b
PE
9419 * dbusbind.c: Don't possibly lose pointer info when converting.
9420 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9421 Use XPNTR rather than XHASH, so that the high-order bits of
9422 the pointer aren't lost when converting through void *.
9423
51639eac
PE
9424 * eval.c (Fautoload): Don't double-shift a pointer.
9425
92394119
PE
9426 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9427
dbdb9a7c
JB
94282011-05-06 Juanma Barranquero <lekktu@gmail.com>
9429
9430 * gnutls.c (DEF_GNUTLS_FN):
9431 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9432
db7a0b4f
AS
94332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9434
9435 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9436 marker. (Bug#8610)
9437
cd394be1 94382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9439
9440 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9441 New version that can reserve upto 2GB of heap space.
9442
f7ff1b0f 94432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9444
9445 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9446
639c109b
TZ
94472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9448
9449 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9450 `gnutls_certificate_set_x509_key_file'.
9451
d2127135
JB
94522011-05-05 Juanma Barranquero <lekktu@gmail.com>
9453
9454 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9455 Update dependencies.
9456
e968f4f3
JB
94572011-05-04 Juanma Barranquero <lekktu@gmail.com>
9458
9459 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9460 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9461 Remove unused parameter `fildes'.
9462 * process.c (read_process_output, send_process): Don't pass it.
9463
84d358f0
JB
94642011-05-04 Juanma Barranquero <lekktu@gmail.com>
9465
9466 Fix previous change: the library cache is defined in w32.c.
9467 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9468 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9469
0898ca10
JB
94702011-05-04 Juanma Barranquero <lekktu@gmail.com>
9471
9472 Implement dynamic loading of GnuTLS on Windows.
9473
9474 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9475 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9476 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9477 Declare.
9478
9479 * gnutls.c (Qgnutls_dll): Define.
9480 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9481 (gnutls_*): Declare function pointers.
9482 (init_gnutls_functions): New function to initialize function pointers.
9483 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9484 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9485 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9486 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9487 (emacs_gnutls_write, emacs_gnutls_read)
9488 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9489 (Fgnutls_available_p): New function.
9490 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9491 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9492 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9493
9494 * image.c: Include w32.h.
9495 (Vimage_type_cache): Delete.
9496 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9497 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9498 (w32_delayed_load): Move to w32.c.
9499
9500 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9501
9502 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9503 (w32_delayed_load): Move from image.c. When loading a library, record
9504 its filename in the :loaded-from property of the library id.
9505 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9506 Initialize and staticpro them.
9507 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9508
9509 * process.c: Include lisp.h before w32.h, not after.
9510 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9511 instead of gnutls_record_check_pending.
9512
9513 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9514
ff4de4aa
TZ
95152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9516
9517 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9518 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9519 as passed in.
9520
abe95abb
JD
95212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9522
9523 * xterm.c (x_set_frame_alpha): Do not set property on anything
9524 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9525
e16e55d4
JB
95262011-05-02 Juanma Barranquero <lekktu@gmail.com>
9527
9528 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9529
bafcf6a5
JB
95302011-05-02 Juanma Barranquero <lekktu@gmail.com>
9531
9532 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9533 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9534 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9535 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9536 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9537 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9538 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9539 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9540 (Qgnutls_bootprop_callbacks_verify): Make static.
9541
e7a6747f
AS
95422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9543
19ed11ba
AS
9544 * callproc.c: Indentation fixup.
9545
e7a6747f 9546 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9547 (wait_for_termination, interruptible_wait_for_termination):
9548 Move after wait_for_termination_1.
e7a6747f 9549
1ef14cb4
LMI
95502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9551
9552 * sysdep.c (interruptible_wait_for_termination): New function
9553 which is like wait_for_termination, but allows keyboard
9554 interruptions.
9555
9556 * callproc.c (Fcall_process): Add (:file "file") as an option for
9557 the STDOUT buffer.
9558 (Fcall_process_region): Ditto.
9559
330d880c
EZ
95602011-04-30 Eli Zaretskii <eliz@gnu.org>
9561
8db90b73
EZ
9562 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9563 rather than `XVECTOR (FOO)->size'.
9564
330d880c
EZ
9565 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9566 inttypes.h, as a gnulib replacement is used if it not available in
9567 system headers.
9568
15cbd324
EZ
95692011-04-21 Eli Zaretskii <eliz@gnu.org>
9570
9571 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9572 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9573 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9574
9575 * coding.c (coding_alloc_by_realloc): Error out if destination
9576 will grow beyond MOST_POSITIVE_FIXNUM.
9577 (decode_coding_emacs_mule): Abort if there isn't enough place in
9578 charbuf for the composition carryover bytes. Reserve an extra
9579 space for up to 2 characters produced in a loop.
9580 (decode_coding_iso_2022): Abort if there isn't enough place in
9581 charbuf for the composition carryover bytes.
9582
95832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9584
ae940cca
EZ
9585 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9586 aborting when %lld or %lll format is passed.
9587 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9588 %llo or %llx format is passed. (Bug#8545)
9589
03ab8921
EZ
9590 * window.c (window_scroll_line_based): Use a marker instead of
9591 simple variables to record original value of point. (Bug#7952)
9592
afda1437
EZ
9593 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9594 produced by %s or %c overflows available buffer space. (Bug#8545)
9595
f76dee0c
PE
95962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9597
9598 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9599 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9600
fdc5744d
JB
96012011-04-28 Juanma Barranquero <lekktu@gmail.com>
9602
9603 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9604
638f053a
JB
96052011-04-28 Juanma Barranquero <lekktu@gmail.com>
9606
9607 * keyboard.c (Qdelayed_warnings_hook): Define.
9608 (command_loop_1): Run `delayed-warnings-hook'
9609 if Vdelayed_warnings_list is non-nil.
9610 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9611 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9612
d178f871
EZ
96132011-04-28 Eli Zaretskii <eliz@gnu.org>
9614
9615 * doprnt.c (doprnt): Don't return value smaller than the buffer
9616 size if the message was truncated. (Bug#8545).
9617
b124fd93
JB
96182011-04-28 Juanma Barranquero <lekktu@gmail.com>
9619
9620 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9621 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9622
e810457d
PE
96232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9624
9625 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9626
ea51cceb
JB
96272011-04-27 Juanma Barranquero <lekktu@gmail.com>
9628
9629 * makefile.w32-in: Update dependencies.
9630
94dcfacf
EZ
96312011-04-27 Eli Zaretskii <eliz@gnu.org>
9632
9633 Improve `doprnt' and its usage. (Bug#8545)
9634 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9635 `format_end'. Remove support for %l as a conversion specifier.
9636 Don't use xrealloc. Improve diagnostics when the %l size modifier
9637 is used. Update the commentary.
9638
9639 * eval.c (verror): Simplify calculation of size_t.
9640
9641 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9642 messages.
9643
f61f41d7
PE
96442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9645
9646 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9647 change.
9648
96fb4434
PE
96492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9650
9651 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9652 This makes this file independent of the recent pseudovector change.
9653
671875da 96542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9655
69e9b5a3
PE
9656 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9657
b5f869a7 9658 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9659 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9660 Remove unused local.
c8926152 9661 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9662
841a1577 9663 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9664 GCC 4.6.0 optimizes based on type-based alias analysis.
9665 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9666 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9667 != &v->size, and therefore "v->size = 1; b->size = 2; return
9668 v->size;" must therefore return 1. This assumption is incorrect
9669 for Emacs, since it type-puns struct Lisp_Vector * with many other
9670 types. To fix this problem, this patch adds a new type struct
f904488f 9671 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9672 and pseudovectors, and helps optimizing compilers not get fooled
9673 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9674 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9675 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9676 the size member.
eab3844f
PE
9677 (XSETPVECTYPE): Rewrite in terms of new macro.
9678 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9679 This is a bit clearer, and further avoids the possibility of
9680 undesirable aliasing.
9681 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9682 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9683 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9684 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9685 (ASIZE): Now uses header.size rather than size.
9686 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9687 to avoid the hassle of writing XVECTOR (foo)->header.size.
9688 (struct vectorlike_header): New type.
eab3844f
PE
9689 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9690 object, to help avoid aliasing.
9691 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9692 (SUBRP): Likewise, since Lisp_Subr is a special case.
9693 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9694 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9695 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9696 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9697 changed to be "header.size" and "header.next".
9698 * buffer.h (struct buffer): Likewise.
9699 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9700 * frame.h (struct frame): Likewise.
9701 * process.h (struct Lisp_Process): Likewise.
9702 * termhooks.h (struct terminal): Likewise.
9703 * window.c (struct save_window_data, struct saved_window): Likewise.
9704 * window.h (struct window): Likewise.
9705 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9706 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9707 * buffer.c (init_buffer_once): Likewise.
9708 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9709 special case.
9710 * process.c (Fformat_network_address): Use local var for size,
9711 for brevity.
9712
0df1eac5
PE
9713 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9714
847ab9d1 9715 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9716 * data.c (atof): Remove decl; no longer used or needed.
9717 (digit_to_number): Move to lread.c.
9718 (Fstring_to_number): Use new string_to_number function, to be
9719 consistent with how the Lisp reader treats infinities and NaNs.
9720 Do not assume that floating-point numbers represent EMACS_INT
9721 without losing information; this is not true on most 64-bit hosts.
9722 Avoid double-rounding errors, by insisting on integers when
9723 parsing non-base-10 numbers, as the documentation specifies.
9724 * lisp.h (string_to_number): New decl, replacing ...
9725 (isfloat_string): Remove.
bc0a5c13 9726 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9727 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9728 appears to have been a coding error. Similarly, do not accept
9729 strings like +-1e0 as floating point numbers. Do not report
9730 overflow for integer overflows unless the base is not 10 which
9731 means we have no simple and reliable way to continue.
9732 Break out the floating-point parsing into a new
9733 function string_to_number, so that Fstring_to_number parses
9734 floating point numbers consistently with the Lisp reader.
04f2d78b 9735 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9736 (E_CHAR, EXP_INT): Remove, replacing with ...
9737 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9738 (string_to_number): New function, replacing isfloat_string.
9739 This function checks for valid syntax and produces the resulting
9740 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9741 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9742 so that overflow for non-base-10 numbers is reported only when
9743 there's no portable and simple way to convert to floating point.
452f4150 9744
67769ffc
PE
9745 * textprop.c (set_text_properties_1): Rewrite for clarity,
9746 and to avoid GCC warning about integer overflow.
9747
c20db43f
PE
9748 * intervals.h (struct interval): Use EMACS_INT for members
9749 where EMACS_UINT might cause problems. See
9750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9751 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9752 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9753 All uses changed.
37aa2f85
PE
9754 (offset_intervals): Tell GCC not to worry about length overflow
9755 when negating a negative length.
c20db43f 9756
2538aa2f
PE
9757 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9758 (overrun_check_free): Likewise.
9759
f2d3008d
PE
9760 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9761 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9762 word size.
9763
ec8df744
PE
9764 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9765 (gnutls_make_error): Rename local to avoid shadowing.
9766 (gnutls_emacs_global_deinit): ifdef out; not used.
9767 (Fgnutls_boot): Use const for pointer to readonly storage.
9768 Comment out unused local. Fix pointer signedness problems.
9769
640ee02d
PE
9770 * lread.c (openp): Don't stuff size_t into an 'int'.
9771 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9772 about possible signed overflow.
9773
6048fb2a
PE
9774 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9775 (GDK_KEY_g): Don't define if already defined.
9776 (xg_prepare_tooltip): Avoid pointer signedness problem.
9777 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9778
fa3c87e1
PE
9779 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9780 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9781
2172544b
PE
9782 * xfns.c (Fx_window_property): Simplify a bit,
9783 to make a bit faster and to avoid GCC 4.6.0 warning.
9784 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9785
9b821a21
PE
9786 * fns.c (internal_equal): Don't assume size_t fits in int.
9787
3c616cfa
PE
9788 * alloc.c (compact_small_strings): Tighten assertion a little.
9789
c2982e87
PE
9790 Replace pEd with more-general pI, and fix some printf arg casts.
9791 * lisp.h (pI): New macro, generalizing old pEd macro to other
9792 conversion specifiers. For example, use "...%"pI"d..." rather
9793 than "...%"pEd"...".
9794 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9795 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9796 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9797 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9798 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9799 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9800 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9801 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9802 64-bit hosts.
9803 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9804 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9805 * print.c (safe_debug_print, print_object): Likewise.
9806 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9807 to int.
6f04d126
PE
9808 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9809 avoiding the 0 flag, which is not portable.
c2982e87
PE
9810 * process.c (Fmake_network_process): Use pI to avoid cast.
9811 * region-cache.c (pp_cache): Likewise.
9812 * xdisp.c (decode_mode_spec): Likewise.
9813 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9814 behavior on 64-bit hosts with printf arg.
6f04d126 9815 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9816 (x_stop_queuing_selection_requests): Likewise.
9817 (x_get_window_property): Don't truncate byte count to an 'int'
9818 when tracing.
0b432f21 9819
5e073ec7
PE
9820 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9821 here, since it parses constructs like leading '-' and spaces,
9822 which are not wanted; and it overflows with large numbers.
9823 Instead, simply match F[0-9]+, which is what is wanted anyway.
9824
36372bf9
PE
9825 * alloc.c: Remove unportable assumptions about struct layout.
9826 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9827 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9828 (allocate_vectorlike, make_pure_vector): Use the new macros,
9829 plus offsetof, to remove unportable assumptions about struct layout.
9830 These assumptions hold on all porting targets that I know of, but
9831 they are not guaranteed, they're easy to remove, and removing them
9832 makes further changes easier.
9833
0b432f21
PE
9834 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9835 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9836 (string_overrun_cookie): Now const. Use initializers that
9837 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9838 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9839 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9840 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9841 multiple of sizeof (EMACS_INT); it need not be, if
9842 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9843 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9844
895009e1
JB
98452011-04-26 Juanma Barranquero <lekktu@gmail.com>
9846
9847 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9848
6a7a1b0b
TZ
98492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9850
9851 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9852 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9853 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9854
841a1577 98552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9856
9857 * lisp.h (Qdebug): List symbol.
895009e1 9858 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9859 * keyboard.c (debug-on-event): New variable.
9860 (handle_user_signal): Break into debugger when debug-on-event
9861 matches the current signal symbol.
9862
f2d3ba6f
DN
98632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9864
9865 * alloc.c (check_sblock, check_string_bytes)
9866 (check_string_free_list): Convert to standard C.
9867
42ce4c63
TZ
98682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9869
9870 * w32.c (emacs_gnutls_push): Fix typo.
9871
825cd63c
EZ
98722011-04-25 Eli Zaretskii <eliz@gnu.org>
9873
fb11d64d
EZ
9874 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9875 "cast to pointer from integer of different size".
9876
825cd63c
EZ
9877 Improve doprnt and its use in verror. (Bug#8545)
9878 * doprnt.c (doprnt): Document the set of format control sequences
9879 supported by the function. Use SAFE_ALLOCA instead of always
9880 using `alloca'.
9881
9882 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9883 is one byte too soon. Don't use xrealloc; instead xfree and
9884 xmalloc anew.
9885
e061a11b
TZ
98862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9887
9888 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9889 callbacks stage.
9890
9891 * gnutls.c: Renamed global_initialized to
9892 gnutls_global_initialized. Added internals for the
9893 :verify-hostname-error, :verify-error, and :verify-flags
9894 parameters of `gnutls-boot' and documented those parameters in the
9895 docstring. Start callback support.
9173deec
JB
9896 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9897 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9898 on error. Return error code.
e061a11b
TZ
9899 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9900 (emacs_gnutls_read): Likewise.
9901 (Fgnutls_boot): Return handshake error code.
9902 (emacs_gnutls_handle_error): New function.
9903 (wsaerror_to_errno): Likewise.
9904
9905 * w32.h (emacs_gnutls_pull): Add prototype.
9906 (emacs_gnutls_push): Likewise.
9907
9908 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9909 (emacs_gnutls_push): Likewise.
9910
99112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9912
9913 * process.c (wait_reading_process_output): Check if GnuTLS
9914 buffered some data internally if no FDs are set for TLS
9915 connections.
9916
9917 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9918 (LIBS): Link to USER_LIBS.
9919 ($(BLD)/gnutls.$(0)): New target.
9920
fa6996bc
EZ
99212011-04-24 Eli Zaretskii <eliz@gnu.org>
9922
eb35682e
EZ
9923 * xdisp.c (handle_single_display_spec): Rename the
9924 display_replaced_before_p argument into display_replaced_p, to
9925 make it consistent with the commentary. Fix typos in the
9926 commentary.
9927
e2ad650c
EZ
9928 * textprop.c (syms_of_textprop): Remove dead code.
9929 (copy_text_properties): Delete obsolete commentary about an
9930 interface that was deleted long ago. Fix typos in the description
9931 of arguments.
9932
1b2de274
EZ
9933 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9934 to changes in oldXMenu/XMenu.h from 2011-04-16.
9935 <menu_help_message, prev_menu_help_message>: Constify.
9936 (IT_menu_make_room): menu->help_text is now `const char **';
9937 adjust.
9938
9939 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9940 to changes in oldXMenu/XMenu.h from 2011-04-16.
9941 (struct XMenu): Declare `help_text' `const char **'.
9942
9943 * xfaces.c <Qunspecified>: Make extern again.
9944
9945 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9946 required by POSIX.
1b2de274 9947
762b15be
EZ
9948 * doc.c (get_doc_string): Improve the format passed to `error'.
9949
9950 * doprnt.c (doprnt): Improve commentary.
9951
9952 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9953
9954 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9955 them with etags.
9956
f1052e5d
EZ
9957 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9958 changes in globals.h immediately force recompilation.
762b15be
EZ
9959 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9960 $(CURDIR)/s/ms-w32.h.
9961 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9962
fa6996bc
EZ
9963 * character.c (Fchar_direction): Function deleted.
9964 (syms_of_character): Don't defsubr it.
9965 <char-direction-table>: Deleted.
9966
e6c3da20
EZ
99672011-04-23 Eli Zaretskii <eliz@gnu.org>
9968
9969 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9970 * doprnt.c: Include limits.h.
9971 (SIZE_MAX): New macro.
04f2d78b
CB
9972 (doprnt): Return a size_t value. 2nd arg is now size_t.
9973 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9974 Improve overflow protection. Support `l' modifier for integer
9975 conversions. Support %l conversion. Don't assume an EMACS_INT
9976 argument for integer conversions and for %c.
9977
9978 * lisp.h (doprnt): Restore prototype.
9979
9980 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9981 $(SRC)/character.h.
9982
9983 * Makefile.in (base_obj): Add back doprnt.o.
9984
9985 * deps.mk (doprnt.o): Add back prerequisites.
9986 (callint.o): Depend on character.h.
9987
9988 * eval.c (internal_lisp_condition_case): Include the handler
9989 representation in the error message.
9990 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9991 when breaking from the loop.
9992
9993 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9994
9995 * callint.c (Fcall_interactively): When displaying error message
9996 about invalid control letter, pass the character's codepoint, not
9997 a pointer to its multibyte form. Improve display of the character
9998 in octal and display also its hex code.
9999
10000 * character.c (char_string): Use %x to display the (unsigned)
10001 codepoint of an invalid character, to avoid displaying a bogus
10002 negative value.
10003
10004 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10005 `error', not SYMBOL_NAME itself.
10006
10007 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10008 character arguments to `error'.
10009
10010 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10011 to `error' in error message about FINAL_CHAR argument. Make sure
10012 FINAL_CHAR is a character, and use %c when it is passed as
10013 argument to `error'.
10014
4ffd0d6b 100152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10016
10017 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10018
10019 * w32.c: Include <time.h>.
10020 (sys_localtime): New function.
10021
4ffd0d6b 100222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10023
10024 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10025
4ffd0d6b 10026 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10027
4ffd0d6b 100282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10029
4ffd0d6b
GM
10030 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10031 zombies (Bug#8467).
aac0c6e3 10032
04c56954
EZ
100332011-04-19 Eli Zaretskii <eliz@gnu.org>
10034
10035 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10036 gl_state.e_property when gl_state.object is Qt.
10037
10038 * insdel.c (make_gap_larger): Remove limitation of buffer size
10039 to <= INT_MAX.
10040
16a43933
CY
100412011-04-18 Chong Yidong <cyd@stupidchicken.com>
10042
10043 * xdisp.c (lookup_glyphless_char_display)
10044 (produce_glyphless_glyph): Handle cons cell entry in
10045 glyphless-char-display.
10046 (Vglyphless_char_display): Document it.
10047
10048 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10049 glyphless-char-display.
10050
4581706e
CY
100512011-04-17 Chong Yidong <cyd@stupidchicken.com>
10052
10053 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10054
10055 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10056
10057 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10058 definition for no-X builds.
10059
4887c6e2 100602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10061
fd35b6f9
PE
10062 Static checks with GCC 4.6.0 and non-default toolkits.
10063
5c1ccb01
PE
10064 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10065
006c5daa
PE
10066 * process.c (keyboard_bit_set): Define only if SIGIO.
10067 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10068 (send_process): Repair possible setjmp clobbering.
10069
efc736d3
PE
10070 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10071
4e2fe2e6
PE
10072 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10073
f97334a2
PE
10074 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10075
4e75f29d
PE
10076 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10077 Define only if needed.
10078
90efadd1
PE
10079 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10080 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10081 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10082
3c647824
PE
10083 * dispextern.h (struct redisplay_interface): Rename param
10084 to avoid shadowing.
e264f262 10085 * termhooks.h (struct terminal): Likewise.
761383f4 10086 * xterm.c (xembed_send_message): Likewise.
3c647824 10087
b58c5c4a
PE
10088 * insdel.c (make_gap_smaller): Define only if
10089 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10090
cad59032
PE
10091 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10092 it.
10093
c339dc2e
PE
10094 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10095 so that we aren't warned about unused symbols.
10096
91a3e27b
PE
10097 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10098
399c71d3 10099 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10100
8ffc96f5
PE
10101 * xfns.c (x_real_positions): Mark locals as initialized.
10102
eef9bc79
PE
10103 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10104
098db9dd
PE
10105 * xterm.c: Fix problems found by static analysis with other toolkits.
10106 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10107 (x_dispatch_event): Declare static if USE_GTK, and
10108 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10109 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10110 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10111 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10112 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10113
eb18f6cc
PE
10114 * xmenu.c (menu_help_callback): Pointer type fixes.
10115 Use const pointers when pointing at readonly data. Avoid pointer
10116 signedness clashes.
10117 (FALSE): Remove unused macro.
10118 (update_frame_menubar): Remove unused decl.
10119
1fe72bf8
PE
10120 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10121
60d9e1db
PE
10122 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10123 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10124 (single_menu_item): Rename local to avoid shadowing.
10125
39261c26
PE
10126 * keyboard.c (make_lispy_event): Remove unused local var.
10127
018c5e19
PE
10128 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10129 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10130
63d2b86e
PE
10131 * bitmaps: Change bitmaps from unsigned char back to the X11
10132 compatible char. Avoid the old compiler warnings about
10133 out-of-range initializers by using, for example, '\xab' rather
10134 than 0xab.
10135
aefd87e1
PE
10136 * xgselect.c (xgselect_initialize): Check vs interface
10137 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10138
bf501fb9
PE
10139 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10140
e9829fdf
PE
10141 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10142 to read-only memory.
10143
1086c095
PE
10144 * fns.c (vector): Remove; this old hack is no longer needed.
10145
2baccd04 10146 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10147 Remove unused var.
dde42981 10148 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10149
72391843 10150 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10151
436c16df 10152 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10153 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10154 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10155
92bb796d 10156 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10157 (x_term_init): Remove local to avoid shadowing.
92bb796d 10158
764430a3 10159 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10160
10161 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10162 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10163
d1dfb56c
EZ
101642011-04-16 Eli Zaretskii <eliz@gnu.org>
10165
c4354cb4
EZ
10166 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10167
d1dfb56c
EZ
10168 Fix regex.c, syntax.c and friends for buffers > 2GB.
10169 * syntax.h (struct gl_state_s): Declare character position members
10170 EMACS_INT.
10171
10172 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10173
04f2d78b
CB
10174 * textprop.c (verify_interval_modification, interval_of):
10175 Declare arguments EMACS_INT.
d1dfb56c
EZ
10176
10177 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10178 EMACS_INT.
10179
10180 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10181
10182 * indent.c (Fvertical_motion): Local variable it_start is now
10183 EMACS_INT.
10184
10185 * regex.c (re_match, re_match_2, re_match_2_internal)
10186 (bcmp_translate, regcomp, regexec, print_double_string)
10187 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10188 (re_compile_pattern, re_exec): Declare arguments and local
10189 variables `size_t' and `ssize_t' and return values `regoff_t', as
10190 appropriate.
10191 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10192 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10193 <compile_stack_type>: `size' and `avail' are now `size_t'.
10194
10195 * regex.h <regoff_t>: Use ssize_t, not int.
10196 (re_search, re_search_2, re_match, re_match_2): Arguments that
10197 specify buffer/string position and length are now ssize_t and
10198 size_t. Return type is regoff_t.
10199
613052cd
BK
102002011-04-16 Ben Key <bkey76@gmail.com>
10201
10202 * nsfont.m: Fixed bugs in ns_get_family and
10203 ns_descriptor_to_entity that were caused by using free to
10204 deallocate memory blocks that were allocated by xmalloc (via
10205 xstrdup). This caused Emacs to crash when compiled with
10206 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10207 --enable-checking=xmallocoverrun). xfree is now used to
10208 deallocate these memory blocks.
10209
4170f62f 102102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10211
71b41406
PE
10212 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10213
9587a89d
PE
10214 emacs_write: Accept and return EMACS_INT for sizes.
10215 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10216 et seq.
10217 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10218 Accept and return EMACS_INT.
10219 (emacs_gnutls_write): Return the number of bytes written on
10220 partial writes.
10221 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10222 (emacs_read, emacs_write): Remove check for negative size, as the
10223 Emacs source code has been audited now.
9587a89d
PE
10224 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10225 (emacs_read, emacs_write): Use it.
273a5f82
PE
10226 * process.c (send_process): Adjust to the new signatures of
10227 emacs_write and emacs_gnutls_write. Do not attempt to store
10228 a byte offset into an 'int'; it might overflow.
9587a89d 10229 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10230
3e047f51
PE
10231 * sound.c: Don't assume sizes fit in 'int'.
10232 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10233 Return EMACS_INT, not int.
3e047f51 10234 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10235 Accept EMACS_INT, not int.
10236 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10237 record read return values.
10238
cc39a9db
BK
102392011-04-15 Ben Key <bkey76@gmail.com>
10240
c9d0ec6d
JB
10241 * keyboard.c (Qundefined): Don't declare static since it is used
10242 in nsfns.m.
10243 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10244 static since they are used in nsfont.m.
cc39a9db 10245
6c60eb9f
SM
102462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10247
10248 * process.c (Qprocessp): Don't declare static.
10249 * lisp.h (Qprocessp): Declare again.
10250
7990b61a
JB
102512011-04-15 Juanma Barranquero <lekktu@gmail.com>
10252
10253 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10254
5d4cb038
PE
102552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10256
8bd7b830 10257 Improve C-level modularity by making more things 'static'.
cd64ea1d 10258
e3b27b31
PE
10259 Don't publish debugger-only interfaces to other modules.
10260 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10261 (verify_bytepos, count_markers): Move decls to the only modules
10262 that need them.
10263 * region-cache.h (pp_cache): Likewise.
10264 * window.h (check_all_windows): Likewise.
10265 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10266
5d4cb038
PE
10267 * sysdep.c (croak): Now static, if
10268 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10269 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10270
10271 * alloc.c (refill_memory_reserve): Now static if
10272 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10273 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10274
e87b6180
PE
10275 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10276 Define only if USE_LUCID.
10277
ac64929e
PE
10278 * xrdb.c (x_customization_string, x_rm_string): Now static.
10279
6f37259d
PE
10280 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10281 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10282
1683e3ab
PE
10283 * xdisp.c (draw_row_with_mouse_face): Now static.
10284 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10285
de9c2632
PE
10286 * window.h (check_all_windows): Mark externally visible.
10287
2b96acb7
PE
10288 * window.c (window_deletion_count): Now static.
10289
10290 * undo.c: Make symbols static if they're not exported.
10291 (last_undo_buffer, last_boundary_position, pending_boundary):
10292 Now static.
10293
50436f33
PE
10294 * textprop.c (interval_insert_behind_hooks): Now static.
10295 (interval_insert_in_front_hooks): Likewise.
10296
64520e5c
PE
10297 * term.c: Make symbols static if they're not exported.
10298 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10299 (max_frame_lines, tty_set_terminal_modes):
10300 (tty_reset_terminal_modes, tty_turn_off_highlight):
10301 (get_tty_terminal): Now static.
10302 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10303 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10304 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10305 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10306 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10307
1fa53021
PE
10308 * sysdep.c: Make symbols static if they're not exported.
10309 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10310 Now static.
10311 (sigprocmask_set, full_mask): Remove; unused.
10312 (wait_debugging): Mark as visible.
10313 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10314 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10315
d4b43b22
PE
10316 * syntax.c (syntax_temp): Define only if !__GNUC__.
10317
b7c513d0
PE
10318 * sound.c (current_sound_device, current_sound): Now static.
10319
989b29ad
PE
10320 * search.c (searchbufs, searchbuf_head): Now static.
10321
13a55a78
PE
10322 * scroll.c (scroll_cost): Remove; unused.
10323 * dispextern.h (scroll_cost): Remove decl.
10324
de68a1fc
PE
10325 * region-cache.h (pp_cache): Mark as externally visible.
10326
40ccffa6
PE
10327 * process.c: Make symbols static if they're not exported.
10328 (process_tick, update_tick, create_process, chan_process):
10329 (Vprocess_alist, proc_buffered_char, datagram_access):
10330 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10331 (deactivate_process): Mark defn as static, as well as decl.
10332 * lisp.h (create_process): Remove decl.
10333 * process.h (chan_process, Vprocess_alist): Remove decls.
10334
ad64fc97
PE
10335 * print.c: Make symbols static if they're not exported.
10336 (print_depth, new_backquote_output, being_printed, print_buffer):
10337 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10338 (print_interval, print_number_index, initial_stderr_stream):
10339 Now static.
10340 * lisp.h (Fprinc): Remove decl.
10341 (debug_output_compilation_hack): Mark as externally visible.
10342
adddb265
PE
10343 * sysdep.c (croak): Move decl from here to syssignal.h.
10344 * syssignal.h (croak): Put it here, so the API can be checked when
10345 'croak' is called from dissociate_if_controlling_tty.
10346
1717ede2
PE
10347 * minibuf.c: Make symbols static if they're not exported.
10348 (minibuf_save_list, choose_minibuf_frame): Now static.
10349 * lisp.h (choose_minibuf_frame): Remove decl.
10350
fa5fb2bc
PE
10351 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10352
1e3890d1
PE
10353 * lread.c: Make symbols static if they're not exported.
10354 (read_objects, initial_obarray, oblookup_last_bucket_number):
10355 Now static.
10356 (make_symbol): Remove; unused.
10357 * lisp.h (initial_obarray, make_symbol): Remove decls.
10358
8a1414fa
PE
10359 * keyboard.c: Make symbols static if they're not exported.
10360 (single_kboard, recent_keys_index, total_keys, recent_keys):
10361 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10362 (this_single_command_key_start, echoing, last_auto_save):
10363 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10364 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10365 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10366 (Vlispy_mouse_stem, double_click_count):
10367 Now static.
10368 (force_auto_save_soon): Define only if SIGDANGER.
10369 (ignore_mouse_drag_p): Now static if
10370 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10371 (print_help): Remove; unused.
10372 (stop_character, last_timer_event): Mark as externally visible.
10373 * keyboard.h (ignore_mouse_drag_p): Declare only if
10374 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10375 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10376 * lisp.h (echoing): Remove decl.
10377 (force_auto_save_soon): Declare only if SIGDANGER.
10378 * xdisp.c (redisplay_window): Simplify code, to make it more
10379 obvious that ignore_mouse_drag_p is not accessed if !defined
10380 USE_GTK && !defined HAVE_NS.
10381
93ea6e8f
PE
10382 * intervals.c: Make symbols static if they're not exported.
10383 (merge_properties_sticky, merge_interval_right, delete_interval):
10384 Now static.
10385 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10386
77382fcc
PE
10387 * insdel.c: Make symbols static if they're not exported.
10388 However, leave prepare_to_modify_buffer alone. It's never
10389 called from outside this function, but that appears to be a bug.
10390 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10391 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10392 (adjust_after_replace_noundo): Remove; unused.
10393 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10394 (signal_before_change): Remove decls.
77382fcc 10395
9306c32e
PE
10396 * indent.c (val_compute_motion, val_vmotion): Now static.
10397
cd44d2eb
PE
10398 * image.c: Make symbols static if they're not exported.
10399 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10400 if USE_GTK.
10401 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10402 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10403
ad9a7a06
PE
10404 * fringe.c (standard_bitmaps): Now static.
10405 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10406
81626931
PE
10407 * frame.c: Make symbols static if they're not exported.
10408 (x_report_frame_params, make_terminal_frame): Now static.
10409 (get_frame_param): Now static, unless HAVE_NS.
10410 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10411 (x_get_resource_string): Remove; not used.
10412 * frame.h (make_terminal_frame, x_report_frame_params):
10413 (x_get_resource_string); Remove decls.
10414 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10415 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10416
239f9db9
PE
10417 * font.c, fontset.c: Make symbols static if they're not exported.
10418 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10419 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10420 * font.c (font_close_object): Now static.
10421 * font.h (font_close_object): Remove.
10422 * fontset.c (FONTSET_OBJLIST): Remove.
10423 (free_realized_fontset) #if-0 the body, which does nothing.
10424 (face_suitable_for_char_p): #if-0, as it's never called.
10425 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10426 * xfaces.c (face_at_string_position):
10427 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10428 since 0 is always ASCII.
10429
dfcf3579
PE
10430 * fns.c (weak_hash_tables): Now static.
10431
5045092b
PE
10432 * fileio.c: Make symbols static if they're not exported.
10433 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10434 (Vwrite_region_annotation_buffers): Now static.
10435
57a96f5c
PE
10436 * eval.c: Make symbols static if they're not exported.
10437 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10438 * lisp.h (backtrace_list): Remove decl.
10439
35f08c38
PE
10440 * emacs.c: Make symbols static if they're not exported.
10441 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10442 (fatal_error_code, fatal_error_signal_hook, standard_args):
10443 Now static.
10444 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10445 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10446 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10447 * lisp.h (fatal_error_signal_hook): Remove decl.
10448 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10449
f44bd759
PE
10450 * editfns.c: Move a (normally-unused) function to its only use.
10451 * editfns.c, lisp.h (get_operating_system_release): Remove.
10452 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10453 worth the hassle of breaking this out.
10454
b532497d
PE
10455 * xterm.c: Make symbols static if they're not exported.
10456 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10457 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10458 (x_destroy_window, x_delete_display):
10459 Now static.
10460 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10461 (x_mouse_leave): Remove; unused.
10462 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10463 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10464 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10465 Remove decls.
10466 (x_mouse_leave): Declare only if WINDOWSNT.
10467 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10468 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10469 USE_X_TOOLKIT.
10470
1675728f
PE
10471 * ftxfont.c: Make symbols static if they're not exported.
10472 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10473 HAVE_FREETYPE.
10474 * font.h (ftxfont_driver): Likewise.
10475
e4cebfca
PE
10476 * xfns.c: Make symbols static if they're not exported.
10477 (x_last_font_name, x_display_info_for_name):
10478 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10479 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10480 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10481 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10482 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10483 (last_show_tip_args): Now static.
10484 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10485 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10486 (x_screen_planes): Remove; unused.
10487 * dispextern.h (x_screen_planes): Remove decl.
10488
5bf46f05
PE
10489 * dispnew.c: Make symbols static if they're not exported.
10490 * dispextern.h (redraw_garbaged_frames, scrolling):
10491 (increment_row_positions): Remove.
10492 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10493 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10494 Now static.
10495 (redraw_garbaged_frames): Remove; unused.
10496
435f4c28
PE
10497 * xfaces.c: Make symbols static if they're not exported.
10498 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10499 Remove decls.
10500 * xterm.h (defined_color): Remove decls.
10501 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10502 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10503 (menu_face_changed_default, defined_color, free_realized_face):
10504 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10505 (ascii_face_of_lisp_face): Remove; unused.
10506
8524aef3
PE
10507 * xdisp.c: Make symbols static if they're not exported.
10508 * dispextern.h (scratch_glyph_row, window_box_edges):
10509 (glyph_to_pixel_coords, set_cursor_from_row):
10510 (get_next_display_element, set_iterator_to_next):
10511 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10512 (show_mouse_face): Remove decls
10513 * frame.h (message_buf_print): Likewise.
10514 * lisp.h (pop_message, set_message, check_point_in_composition):
10515 Likewise.
10516 * xterm.h (set_vertical_scroll_bar): Likewise.
10517 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10518 (message_buf_print, scratch_glyph_row, displayed_buffer):
10519 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10520 (get_next_display_element, show_mouse_face, window_box_edges):
10521 (frame_to_window_pixel_xy, check_point_in_composition):
10522 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10523 (glyph_to_pixel_coords): Remove; unused.
10524
16390cd2
PE
10525 * dired.c (file_name_completion): Now static.
10526
10527 * dbusbind.c (xd_in_read_queued_messages): Now static.
10528
a25f4dfa
PE
10529 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10530 * data.c (circular_list_error): Remove.
10531
14a9c8df
PE
10532 * commands.h (last_point_position, last_point_position_buffer):
10533 (last_point_position_window): Remove decls.
10534 * keyboard.c: Make these variables static.
10535
04f2d78b
CB
10536 * coding.h (coding, code_convert_region, encode_coding_gap):
10537 Remove decls.
74ab6df5
PE
10538 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10539 (iso_code_class, detect_coding, code_convert_region): Now static.
10540 (encode_coding_gap): Remove; unused.
10541
38dfbee1
PE
10542 * chartab.c (chartab_chars, chartab_bits): Now static.
10543
a2cb4e63
PE
10544 * charset.h (charset_iso_8859_1): Remove decl.
10545 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10546 Now static.
10547
127198fd
PE
10548 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10549 * ccl.c (Vccl_program_table): Now static.
10550 (check_ccl_update): Remove; unused.
10551
d85b608f
PE
10552 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10553 * category.h: ... from here.
10554 * category.c (check_category_table, set_category_set): Now static.
10555
31cd66f3
PE
10556 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10557 * lisp.h: Remove these decls.
10558
c358e587
PE
10559 * buffer.c (buffer_count): Remove unused var.
10560
e78aecca
PE
10561 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10562 so that it's not optimized away.
10563 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10564 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10565 exported only to the debugger.
10566
e192d7d3 10567 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10568 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10569
92470028
PE
10570 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10571 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10572 was inaccessible from Lisp.
10573 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10574 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10575
244ed907
PE
10576 alloc.c: Import and export fewer symbols, and remove unused items.
10577 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10578 is defined.
10579 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10580 it's not optimized away by whole-program optimization.
10581 (message_enable_multibyte, free_misc): Remove.
10582 (catchlist, handlerlist, mark_backtrace):
10583 Declare only if BYTE_MARK_STACK.
10584 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10585 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10586 (message_enable_multibyte): Remove decl.
10587 (free_misc, interval_free_list, float_block, float_block_index):
10588 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10589 (cons_free_list, last_marked_index):
10590 Now static.
10591 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10592 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10593 (mark_backtrace): Define only if BYTE_MARK_STACK.
10594 * xdisp.c (message_enable_multibyte): Now static.
10595
61c2b50e 10596 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10597 This makes it easier for human readers (and static analyzers)
10598 to see whether these variables are used from other modules.
10599 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10600 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10601 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10602 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10603 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10604 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10605 * xmenu.c, xselect.c:
10606 Declare Q* vars static if they are not used in other modules.
10607 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10608 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10609 Remove decls of unexported vars.
10610 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10611
95c82688
PE
10612 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10613
16a97296
PE
10614 Make Emacs functions such as Fatom 'static' by default.
10615 This makes it easier for human readers (and static analyzers)
10616 to see whether these functions can be called from other modules.
10617 DEFUN now defines a static function. To make the function external
10618 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10619 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10620 (Finit_image_library):
16a97296
PE
10621 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10622 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10623 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10624 Remove decls, since these functions are now static.
10625 (Funintern, Fget_internal_run_time): New decls, since these functions
10626 were already external.
95c82688 10627
16a97296
PE
10628 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10629 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10630 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10631 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10632 * keyboard.c, keymap.c, lread.c:
10633 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10634 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10635 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10636 Mark functions with DEFUE instead of DEFUN,
10637 if they are used in other modules.
10638 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10639 decls for now-static functions.
10640 * buffer.h (Fdelete_overlay): Remove decl.
10641 * callproc.c (Fgetenv_internal): Mark as internal.
10642 * composite.c (Fremove_list_of_text_properties): Remove decl.
10643 (Fcomposition_get_gstring): New forward static decl.
10644 * composite.h (Fcomposite_get_gstring): Remove decl.
10645 * dired.c (Ffile_attributes): New forward static decl.
10646 * doc.c (Fdocumntation_property): New forward static decl.
10647 * eval.c (Ffetch_bytecode): New forward static decl.
10648 (Funintern): Remove extern decl; now in .h file where it belongs.
10649 * fileio.c (Fmake_symbolic_link): New forward static decl.
10650 * image.c (Finit_image_library): New forward static decl.
10651 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10652 * intervals.h (Fprevious_property_change):
10653 (Fremove_list_of_text_properties): Remove decls.
10654 * keyboard.c (Fthis_command_keys): Remove decl.
10655 (Fcommand_execute): New forward static decl.
10656 * keymap.c (Flookup_key): New forward static decl.
10657 (Fcopy_keymap): Now static.
10658 * keymap.h (Flookup_key): Remove decl.
10659 * process.c (Fget_process): New forward static decl.
10660 (Fprocess_datagram_address): Mark as internal.
10661 * syntax.c (Fsyntax_table_p): New forward static decl.
10662 (skip_chars): Remove duplicate decl.
10663 * textprop.c (Fprevious_property_change): New forward static decl.
10664 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10665 Now internal.
10666 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10667 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10668
785bbd42
PE
10669 * editfns.c (Fformat): Remove unreachable code.
10670
8b913b57
AS
106712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10672
10673 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10674 change. (Bug#8496)
10675
a6744a35
EZ
106762011-04-13 Eli Zaretskii <eliz@gnu.org>
10677
10678 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10679 when at ZV. (Bug#8487)
10680
e7974947
AS
106812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10682
baad03f0
AS
10683 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10684 (Bug#8437)
10685 * keyboard.c (parse_tool_bar_item): Likewise.
10686 * sound.c (sound_cleanup, alsa_close): Likewise.
10687 * termcap.c (tgetent): Likewise.
10688 * xfns.c (x_default_font_parameter): Likewise.
10689 * xsettings.c (read_and_apply_settings): Likewise.
10690
e7974947
AS
10691 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10692 (overrun_check_free): Protoize.
10693
28272684
PE
106942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10695
10696 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10697 since callers should never pass a negative size.
10698 Change the signature to match that of plain 'read' and 'write'; see
10699 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10700 * lisp.h: Update prototypes of emacs_write and emacs_read.
10701
11997c76
EZ
107022011-04-11 Eli Zaretskii <eliz@gnu.org>
10703
10704 * xdisp.c (redisplay_window): Don't try to determine the character
10705 position of the scroll margin if the window start point w->startp
e896f03c 10706 is outside the buffer's accessible region. (Bug#8468)
11997c76 10707
8a2cbd72
EZ
107082011-04-10 Eli Zaretskii <eliz@gnu.org>
10709
10710 Fix write-region and its subroutines for buffers > 2GB.
10711 * fileio.c (a_write, e_write): Modify declaration of arguments and
10712 local variables to support buffers larger than 2GB.
10713 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10714
10715 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10716 argument, local variables, and return value.
10717
10718 * lisp.h: Update prototypes of emacs_write and emacs_read.
10719
10720 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10721
4073e537 107222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10723
1ebfdcb6
PE
10724 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10725
b2ded58d
PE
10726 Fix more problems found by GCC 4.6.0's static checks.
10727
7d66342c
PE
10728 * xdisp.c (vmessage): Use a better test for character truncation.
10729
bbf47d44
PE
10730 * charset.c (load_charset_map): <, not <=, for optimization,
10731 and to avoid potential problems with integer overflow.
9248994d 10732 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10733 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10734 * editfns.c (Fformat): Likewise.
1e69125e 10735 * syntax.c (skip_chars): Likewise.
3befa583 10736
e3019616
PE
10737 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10738 This also lets GCC 4.6.0 generate slightly better loop code.
10739
becfa255
PE
10740 * callint.c (Fcall_interactively): <, not <=, for optimization.
10741 (Fcall_interactively): Count the number of arguments produced,
10742 not the number of arguments given. This is simpler and lets GCC
10743 4.6.0 generate slightly better code.
10744
dae0cd48
PE
10745 * ftfont.c: Distingish more carefully between FcChar8 and char.
10746 The previous code passed unsigned char * to a functions like
10747 strlen and xstrcasecmp that expect char *, which does not
10748 conform to the C standard.
10749 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10750 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10751 char * when the C standard requires it.
10752
76032d70
PE
10753 * keyboard.c (read_char): Remove unused var.
10754
eb3f1cc8
PE
10755 * eval.c: Port to Windows vsnprintf (Bug#8435).
10756 Include <limits.h>.
10757 (SIZE_MAX): Define if the headers do not.
10758 (verror): Do not give up if vsnprintf returns a negative count.
10759 Instead, grow the buffer. This ports to Windows vsnprintf, which
10760 does not conform to C99. Problem reported by Eli Zaretskii.
10761 Also, simplify the allocation scheme, by avoiding the need for
10762 calling realloc, and removing the ALLOCATED variable.
10763
70476b54
PE
10764 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10765
12020a9e
PE
10766 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10767 But keep the doprint source code for now, as we might revamp it
10768 and use it again (Bug#8435).
ea6c7ae6
PE
10769 * lisp.h (doprnt): Remove.
10770 * Makefile.in (base_obj): Remove doprnt.o.
10771 * deps.mk (doprnt.o): Remove.
10772
5fdb398c
PE
10773 error: Print 32- and 64-bit integers portably (Bug#8435).
10774 Without this change, on typical 64-bit hosts error ("...%d...", N)
10775 was used to print both 32- and 64-bit integers N, which relied on
10776 undefined behavior.
61bdb816 10777 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10778 * lisp.h (error, verror): Mark as printf-like functions.
10779 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10780 Report overflow in size calculations when allocating printf buffer.
10781 Do not truncate output string at its first null byte.
10782 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10783 Truncate the output at a character boundary, since vsnprintf does not
10784 do that.
10785 * charset.c (check_iso_charset_parameter): Convert internal
10786 character to string before calling 'error', since %c now has the
10787 printf meaning.
10788 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10789 overflow when computing char to be passed to 'error'. Do not
10790 pass Lisp_Object to 'error'; pass the integer instead.
10791 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10792 formatted with plain %d.
10793
b189fa66
PE
10794 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10795
bff87ef0
PE
10796 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10797
7e2cac20
PE
10798 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10799
ce4d90b5
PE
10800 * xterm.c (x_catch_errors): Remove duplicate declaration.
10801
266c9547
PE
10802 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10803
79c49ad2
PE
10804 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10805
368f4090
JM
108062011-04-10 Jim Meyering <meyering@redhat.com>
10807
10808 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10809 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10810 return ssize_t not "int", and use size_t as the buffer length.
10811 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10812 * gnutls.h: Update declarations.
10813 * process.c (read_process_output): Use ssize_t, to match.
10814 (send_process): Likewise.
10815
a32d4040
CY
108162011-04-09 Chong Yidong <cyd@stupidchicken.com>
10817
10818 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10819
8546720e 108202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10821
04f2d78b
CB
10822 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10823 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10824
8546720e
GM
10825 * xterm.c (handle_one_xevent):
10826 * xmenu.c (create_and_show_popup_menu):
10827 * xselect.c (x_decline_selection_request)
10828 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10829
0a2f5c1a 108302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10831
10832 Fix some uses of `int' instead of EMACS_INT.
10833 * search.c (string_match_1, fast_string_match)
10834 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10835 (scan_buffer, find_next_newline_no_quit)
10836 (find_before_next_newline, search_command, Freplace_match)
10837 (Fmatch_data): Make some `int' variables be EMACS_INT.
10838
10839 * xdisp.c (display_count_lines): 3rd argument and return value now
10840 EMACS_INT. All callers changed.
10841 (pint2hrstr): Last argument is now EMACS_INT.
10842
10843 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10844 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10845 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10846 (decode_coding_utf_16, decode_coding_emacs_mule)
10847 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10848 (decode_coding_ccl, decode_coding_charset)
10849 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10850 (decode_coding_iso_2022, decode_coding_emacs_mule)
10851 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10852 <char_offset, last_offset>: Declare EMACS_INT.
10853 (encode_coding_utf_8, encode_coding_utf_16)
10854 (encode_coding_emacs_mule, encode_invocation_designation)
10855 (encode_designation_at_bol, encode_coding_iso_2022)
10856 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10857 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10858 Declare EMACS_INT.
10859 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10860 (encode_invocation_designation): Last argument P_NCHARS is now
10861 EMACS_INT.
10862 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10863 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10864
10865 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10866 All users changed.
10867
10868 * ccl.c (Fccl_execute_on_string): Declare some variables
10869 EMACS_INT.
10870
8546720e 108712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10872
10873 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10874
4e19a977
CS
108752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10876
10877 * process.c (Fformat_network_address): Doc fix.
10878
87302331
R
108792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10880
ee7683eb 10881 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10882
cbb59342
CY
108832011-04-08 Chong Yidong <cyd@stupidchicken.com>
10884
10885 * keyboard.c (read_char): Call Lisp function help-form-show,
10886 instead of using internal_with_output_to_temp_buffer.
10887 (Qhelp_form_show): New var.
e0d38eeb 10888 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10889
10890 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10891
10892 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10893
e67a13ab
CY
108942011-04-06 Chong Yidong <cyd@stupidchicken.com>
10895
04f2d78b
CB
10896 * process.c (Flist_processes): Remove to Lisp.
10897 (list_processes_1): Delete.
e67a13ab 10898
973f782d
EZ
108992011-04-06 Eli Zaretskii <eliz@gnu.org>
10900
7c106b1e
EZ
10901 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10902
973f782d
EZ
10903 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10904
41cf7d1a 109052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10906
ca23cc88
PE
10907 Fix more problems found by GCC 4.6.0's static checks.
10908
f390e2d5
PE
10909 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10910
42eea0d0
PE
10911 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10912
b69769da 10913 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10914
f9541e84
PE
10915 * xdisp.c (vmessage): Mark as a printf-like function.
10916
13841b55
PE
10917 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10918
c136c10f
PE
10919 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10920
5e2d4a30
PE
10921 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10922 printf-like functions.
10923 (tiff_load): Add casts to remove these marks before passing them
10924 to system-supplied API.
10925
583f48b9
PE
10926 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10927
b25d760e
PE
10928 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10929 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10930 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10931 directly, rather than having caller test rule sign. This avoids
10932 some unnecessary tests.
10933 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10934 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10935 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10936
bc7b6697 10937 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10938 (xfont_open): Avoid unnecessary tests.
bc7b6697 10939
27ccc379
PE
10940 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10941
dcd5c89a
PE
10942 * composite.h, composite.c (composition_gstring_put_cache):
10943 Use EMACS_INT, not int, for length.
10944
b13a45c6
PE
10945 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10946 breaking out part of COMPOSITION_DECODE_RULE.
10947 (COMPOSITION_DECODE_RULE): Use it.
10948 * composite.c (get_composition_id): Remove unused local vars,
10949 by using the new macro.
10950
1e792e4d
PE
10951 * textprop.c (set_text_properties_1): Change while to do-while,
10952 since the condition is always true at first.
10953
dc6c6455 10954 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10955 (interval_deletion_adjustment): Return unsigned value.
10956 All uses changed.
dc6c6455 10957
aba7731a
PE
10958 * process.c (list_processes_1, create_pty, read_process_output):
10959 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10960 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10961 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10962 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10963 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10964
fdfc4bf3
PE
10965 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10966
fca8fe46 10967 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10968 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10969
06a0259a 10970 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10971 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10972 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10973
e7b9e80f
PE
10974 * print.c (print_error_message): Avoid int overflow.
10975
56201685
PE
10976 * font.c (font_list_entities): Redo for clarity,
10977 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10978
78834453 10979 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10980 (font_score): Avoid potential overflow in diff calculation.
78834453 10981
0bc0b309 10982 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10983 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10984
e610eaca
PE
10985 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10986
b895abce
PE
10987 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10988 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10989 can always succeed if overflow has undefined behavior.
10990
1f1d9321 10991 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10992 (wordify): Omit three unnecessary tests.
1f1d9321 10993
c59478bc
PE
10994 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10995 All callers changed. This avoids the need for an unused var.
10996
79b73827
PE
10997 * casefiddle.c (casify_region): Remove var that is set but not used.
10998
a4db5dfe
PE
10999 * dired.c (file_name_completion): Remove var that is set but not used.
11000
43aae36e
PE
11001 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11002
2a47c44d 11003 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11004 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11005
a37c69bf
PE
11006 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11007 Check for integer overflow on size calculations.
11008
328ab8e7
PE
11009 * buffer.c (Fprevious_overlay_change): Remove var that is set
11010 but not used.
11011
e5a2a5cb
PE
11012 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11013 Remove vars that are set but not used.
8d84a6eb 11014 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11015 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11016
a60e5f68
PE
11017 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11018
f661cb61 11019 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11020 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11021
f0397f5a
PE
11022 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11023 that are set but not used.
11024
8664db06 11025 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11026 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11027
6abdaa4a
PE
11028 * xselect.c (x_get_local_selection, x_handle_property_notify):
11029 Remove vars that are set but not used.
11030
0ce7538d 11031 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11032 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11033
9ae848fc
PE
11034 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11035 Remove var that is set but not used.
0b918413
PE
11036 (scroll_bar_windows_size): Now size_t, not int.
11037 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11038 Check for overflow.
9ae848fc 11039
a5a62657
PE
11040 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11041 (map_tty_color) [!defined MSDOS]: Likewise.
11042
5c5cdd39
PE
11043 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11044
66ebf983
PE
11045 * coding.c: Remove vars that are set but not used.
11046 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11047 All callers changed.
11048 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11049 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11050 (decode_coding_charset): Remove vars that are set but not used.
11051
1be4d761
PE
11052 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11053 that is set but not used.
11054
47553fa8
PE
11055 * print.c (print_object): Remove var that is set but not used.
11056
1f7196bf 11057 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11058 The gnulib version avoids calling malloc in the usual case,
11059 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11060 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11061 * filelock.c (current_lock_owner): Likewise.
11062 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11063 * sysdep.c: Include allocator.h, careadlinkat.h.
11064 (emacs_no_realloc_allocator): New static constant.
11065 (emacs_readlink): New function.
fdb61804
PE
11066 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11067 ../lib/careadlinkat.h.
d1fdcab7 11068
f84c17c7
SM
110692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11070
11071 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11072 first non-nil return value).
11073
ef3862ad
JD
110742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11075
11076 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11077 if not defined (Bug#8403).
11078
376a7006
JB
110792011-04-02 Juanma Barranquero <lekktu@gmail.com>
11080
11081 * xdisp.c (display_count_lines): Remove parameter `start',
11082 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11083 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11084 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11085 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11086 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11087 and thereabouts. All callers changed.
11088 (get_per_char_metric): Remove parameter `f', unused since
11089 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11090
6ca3801d
JM
110912011-04-02 Jim Meyering <meyering@redhat.com>
11092
11093 do not dereference NULL upon failed strdup
11094 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11095 (ns_get_family): Likewise.
11096
d8e2b5ba
JB
110972011-04-02 Juanma Barranquero <lekktu@gmail.com>
11098
11099 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11100
8c74fcbd
JD
111012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11102
11103 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11104 later (Bug#8403).
11105
7200d79c
SM
111062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11107
03408648 11108 Add lexical binding.
7200d79c 11109
03408648
SM
11110 * window.c (Ftemp_output_buffer_show): New fun.
11111 (Fsave_window_excursion):
11112 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11113
11114 * lread.c (lisp_file_lexically_bound_p): New function.
11115 (Fload): Bind Qlexical_binding.
11116 (readevalloop): Remove `evalfun' arg.
11117 Bind Qinternal_interpreter_environment.
11118 (Feval_buffer): Bind Qlexical_binding.
11119 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11120 Mark as dynamic.
11121 (syms_of_lread): Declare `lexical-binding'.
11122
11123 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11124
11125 * keyboard.c (eval_dyn): New fun.
11126 (menu_item_eval_property): Use it.
ca105506
SM
11127
11128 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11129
03408648
SM
11130 * fns.c (concat, mapcar1): Accept byte-code-functions.
11131
11132 * eval.c (Fsetq): Handle lexical vars.
11133 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11134 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11135 (FletX, Flet): Obey lexical binding.
11136 (Fcommandp): Handle closures.
11137 (Feval): New `lexical' arg.
11138 (eval_sub): New function extracted from Feval. Use it almost
11139 everywhere where Feval was used. Look up vars in lexical env.
11140 Handle closures.
11141 (Ffunctionp): Move from subr.el.
11142 (Ffuncall): Handle closures.
11143 (apply_lambda): Remove `eval_flags'.
11144 (funcall_lambda): Handle closures and new byte-code-functions.
11145 (Fspecial_variable_p): New function.
11146 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11147 but without exporting it to Lisp.
23aba0ea 11148
23aba0ea 11149 * doc.c (Fdocumentation, store_function_docstring):
03408648 11150 * data.c (Finteractive_form): Handle closures.
23aba0ea 11151
03408648
SM
11152 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11153 interactive spec.
ba83908c 11154
04f2d78b
CB
11155 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11156 New byte-codes.
03408648
SM
11157 (exec_byte_code): New function extracted from Fbyte_code to handle new
11158 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11159
03408648 11160 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11161
03408648 11162 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11163
e2abce01
JB
111642011-03-31 Juanma Barranquero <lekktu@gmail.com>
11165
11166 * xdisp.c (redisplay_internal): Fix prototype.
11167
63696a73 111682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11169
63696a73 11170 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11171 (try_scrolling): Use it when setting scroll_limit.
11172 Limit scrolling to 100 screen lines.
63696a73
EZ
11173 (redisplay_window): Even when falling back on "recentering",
11174 position point in the window according to scroll-conservatively,
11175 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11176
11177 (try_scrolling): When point is above the window, allow searching
11178 as far as scroll_max, or one screenful, to compute vertical
11179 distance from PT to the scroll margin position. This prevents
11180 try_scrolling from unnecessarily failing when
11181 scroll-conservatively is set to a value slightly larger than the
11182 window height. Clean up the case of PT below the margin at bottom
11183 of window: scroll_max can no longer be INT_MAX. When aggressive
11184 scrolling is in use, don't let point enter the opposite scroll
11185 margin as result of the scroll.
11186 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11187 threshold of 100 lines for never-recentering scrolling.
11188
e4cc2dfc
JB
111892011-03-31 Juanma Barranquero <lekktu@gmail.com>
11190
11191 * dispextern.h (move_it_by_lines):
11192 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11193 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11194 (message_log_check_duplicate): Remove parameters `prev_bol' and
11195 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11196 (redisplay_internal): Remove parameter `preserve_echo_area',
11197 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11198
11199 * indent.c (Fvertical_motion):
11200 * window.c (window_scroll_pixel_based, Frecenter):
11201 Don't pass `need_y_p' to `move_it_by_lines'.
11202
1c470562
SM
112032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11204
44f230aa
SM
11205 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11206 steal a few bits to be more compact.
11207 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11208 Remove unneeded casts.
11209
1c470562
SM
11210 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11211
888adce9
ZK
112122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11213
11214 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11215 binding" message (bug#7967).
11216
f838ed7b
PE
112172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11218
77861b95
PE
11219 Fix more problems found by GCC 4.6.0's static checks.
11220
de6dbc14
PE
11221 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11222 Remove unused local var.
11223
f838ed7b
PE
11224 * editfns.c (Fmessage_box): Remove unused local var.
11225
792c7b2b
PE
11226 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11227 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11228 Omit unused local vars.
c499e557 11229 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11230 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11231 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11232 Omit unused local var.
11233
ba0165e1
PE
11234 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11235 Don't assume string length fits in int.
32ad8845 11236 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11237 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11238
3c59b4c9
PE
11239 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11240 instead of alloca (Bug#8344).
11241
a3eed478 11242 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11243 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11244
eb4d412d
PE
11245 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11246
1658b401
PE
11247 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11248 concerns.
11249
11250 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11251
11252 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11253
9a2c6e05
PE
11254 * keyboard.c (syms_of_keyboard): Use the same style as later
11255 in this function when indexing through an array. This also
11256 works around GCC bug 48267.
11257
03d0a109
PE
11258 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11259
44f730c8
PE
11260 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11261
fe75f926
PE
11262 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11263 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11264
ffa8c828
PE
11265 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11266 This avoids undefined behavior on integer overflow, and is a bit
11267 more convenient anyway since it is compared to a size_t variable.
11268
c5101a77
PE
11269 Variadic C functions now count arguments with size_t, not int.
11270 This avoids an unnecessary limitation on 64-bit machines, which
11271 caused (substring ...) to crash on large vectors (Bug#8344).
11272 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11273 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11274 All variadic functions and their callers changed accordingly.
c5101a77
PE
11275 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11276 * data.c (arith_driver, float_arith_driver): Likewise.
11277 * editfns.c (general_insert_function): Likewise.
11278 * eval.c (struct backtrace.nargs, interactive_p)
11279 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11280 (funcall_lambda, mark_backtrace): Likewise.
11281 * fns.c (concat): Likewise.
11282 * frame.c (x_set_frame_parameters): Likewise.
11283 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11284 0 if not found, not -1. All callers changed.
11285
dd3f25f7
PE
11286 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11287 (stack_copy_size): Now size_t, not int.
11288 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11289
461c2ab9
JB
112902011-03-28 Juanma Barranquero <lekktu@gmail.com>
11291
11292 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11293 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11294 All callers changed.
11295
11296 * lisp.h (multibyte_char_to_unibyte):
11297 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11298 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11299 * character.h (CHAR_TO_BYTE8):
11300 * cmds.c (internal_self_insert):
11301 * editfns.c (general_insert_function):
11302 * keymap.c (push_key_description):
11303 * search.c (Freplace_match):
11304 * xdisp.c (message_dolog, set_message_1): All callers changed.
11305
f6d62986
SM
113062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11307
11308 * keyboard.c (safe_run_hook_funcall): New function.
11309 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11310 don't set the hook to nil, but remove the offending function instead.
11311 (Qcommand_hook_internal): Remove, unused.
11312 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11313 Vcommand_hook_internal.
11314
11315 * eval.c (enum run_hooks_condition): Remove.
11316 (funcall_nil, funcall_not): New functions.
11317 (run_hook_with_args): Call each function through a `funcall' argument.
11318 Remove `cond' argument, now redundant.
11319 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11320 (Frun_hook_with_args_until_failure): Adjust accordingly.
11321 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11322
1db5b1ad
JB
113232011-03-28 Juanma Barranquero <lekktu@gmail.com>
11324
11325 * dispextern.h (string_buffer_position): Remove declaration.
11326
11327 * print.c (strout): Remove parameter `multibyte', unused since
11328 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11329
11330 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11331 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11332 All callers changed.
11333
11334 * w32.c (_wsa_errlist): Use braces for struct initializers.
11335
11336 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11337 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11338 All callers changed.
11339 (string_buffer_position): Likewise. Also, make static (it's never
11340 used outside xdisp.c).
11341 (cursor_row_p): Remove parameter `w', unused since
11342 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11343 (decode_mode_spec): Remove parameter `precision', introduced during
11344 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11345 All callers changed.
11346
5ffb62aa
JD
113472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11348
11349 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11350
461c2ab9 113512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11352
11353 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11354 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11355 (ns_update_auto_hide_menu_bar): New functions.
11356 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11357 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11358 ns_constrain_all_frames.
11359 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11360 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11361
5c380ffb
JD
113622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11363
11364 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11365
9af30bdf
GM
113662011-03-27 Glenn Morris <rgm@gnu.org>
11367
11368 * syssignal.h: Replace RETSIGTYPE with void.
11369 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11370 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11371 Replace SIGTYPE with void everywhere.
11372 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11373 * s/template.h (SIGTYPE): Remove commented out definition.
11374
e2abce01
JB
113752011-03-26 Eli Zaretskii <eliz@gnu.org>
11376
11377 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11378 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11379
f868cd8a
JB
113802011-03-26 Juanma Barranquero <lekktu@gmail.com>
11381
59eb0929
JB
11382 * w32.c (read_unc_volume): Use parameter `henum', instead of
11383 global variable `wget_enum_handle'.
11384
11385 * keymap.c (describe_vector): Remove parameters `indices' and
11386 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11387 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11388
f868cd8a
JB
11389 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11390
11391 * keyboard.c (timer_check): Remove parameter `do_it_now',
11392 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11393 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11394 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11395
11396 * keyboard.c (read_char):
11397 * w32menu.c (w32_menu_display_help):
11398 * xmenu.c (show_help_event, menu_help_callback):
11399 Adjust calls to `show_help_echo'.
11400
11401 * gtkutil.c (xg_maybe_add_timer):
11402 * keyboard.c (readable_events):
11403 * process.c (wait_reading_process_output):
11404 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11405
11406 * insdel.c (adjust_markers_gap_motion):
11407 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11408 (gap_left, gap_right): Don't call it.
11409
2ecf6fdb
CY
114102011-03-25 Chong Yidong <cyd@stupidchicken.com>
11411
11412 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11413 incurred during fontification.
11414
6b1f9ba4
JB
114152011-03-25 Juanma Barranquero <lekktu@gmail.com>
11416
11417 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11418 (DEFVAR_PER_BUFFER): Don't pass it.
11419
11420 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11421 (scrolling_window): Don't pass it.
11422
0f4a96b5
JB
114232011-03-25 Juanma Barranquero <lekktu@gmail.com>
11424
11425 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11426
11427 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11428 and `suffix'.
11429 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11430 of variables specific to SELinux and computation of `encoded_absname'.
11431
11432 * image.c (XPutPixel): Remove unused variable `height'.
11433
11434 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11435
11436 * unexw32.c (get_section_info): Remove unused variable `section'.
11437
11438 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11439 (system_process_attributes): Remove unused variable `sess'.
11440 (sys_read): Remove unused variable `err'.
11441
11442 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11443 (w32_wnd_proc): Remove unused variable `isdead'.
11444 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11445 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11446 (x_create_tip_frame): Remove unused variable `tem'.
11447
11448 * w32inevt.c (w32_console_read_socket):
11449 Remove unused variable `no_events'.
11450
11451 * w32term.c (x_draw_composite_glyph_string_foreground):
11452 Remove unused variable `width'.
11453
1149507c
JB
114542011-03-24 Juanma Barranquero <lekktu@gmail.com>
11455
11456 * w32term.c (x_set_glyph_string_clipping):
11457 Don't pass uninitialized region to CombineRgn.
11458
9c88f339
JB
114592011-03-23 Juanma Barranquero <lekktu@gmail.com>
11460
11461 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11462 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11463 (Fx_close_connection): Remove unused variable `i'.
11464
11465 * w32font.c (w32font_draw): Return number of glyphs.
11466 (w32font_open_internal): Remove unused variable `i'.
11467 (w32font_driver): Add missing initializer.
11468
11469 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11470 (fill_in_menu): Remove unused variable `items_added'.
11471
11472 * w32term.c (last_mouse_press_frame): Remove static global variable.
11473 (w32_clip_to_row): Remove unused variable `f'.
11474 (x_delete_terminal): Remove unused variable `i'.
11475
11476 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11477 (NOTHING): Remove unused static global variable.
11478 (uniscribe_check_otf): Remove unused variable `table'.
11479 (uniscribe_font_driver): Add missing initializers.
11480
dee091a3
JD
114812011-03-23 Julien Danjou <julien@danjou.info>
11482
11483 * term.c (Fsuspend_tty, Fresume_tty):
11484 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11485 * window.c (temp_output_buffer_show):
11486 * insdel.c (signal_before_change):
11487 * frame.c (Fhandle_switch_frame):
11488 * fileio.c (Fdo_auto_save):
11489 * emacs.c (Fkill_emacs):
11490 * editfns.c (save_excursion_restore):
11491 * cmds.c (internal_self_insert):
11492 * callint.c (Fcall_interactively):
11493 * buffer.c (Fkill_all_local_variables):
11494 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11495 Use Frun_hooks.
0f4a96b5 11496 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11497 unconditionally since it does the check itself.
dee091a3 11498
2c520ab5 114992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11500
c9c49752
PE
11501 Fix more problems found by GCC 4.5.2's static checks.
11502
8abc3f12
PE
11503 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11504 the first time through the loop, since we know p0 < p1 then.
11505 This also avoids a gcc -Wstrict-overflow warning.
11506
a2d26660
PE
11507 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11508 leading to a memory leak, possible in functions like
11509 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11510 of objects (Bug#8318).
a2d26660 11511
916c72e9
PE
11512 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11513 that could (at least in theory) be that large.
11514
19ab8a18
PE
11515 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11516 This is less likely to overflow, and avoids undefined behavior if
11517 overflow does occur. All callers changed. Use strtoul to scan
11518 for the unsigned long integer.
b7cbbd6f
PE
11519 (pint2hrstr): Simplify and tune code slightly.
11520 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11521
f0641eff
PE
11522 * scroll.c (do_scrolling): Work around GCC bug 48228.
11523 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11524
7f650bb9
PE
11525 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11526 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11527 (validate_x_resource_name): Simplify count usage.
11528 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11529
37dd57d1
PE
11530 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11531 fail (Bug#8306).
81e56e61 11532
699979fc 11533 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11534
401bf9b4
PE
11535 * process.c (Fmake_network_process): Use socklen_t, not int,
11536 where POSIX says socklen_t is required in portable programs.
11537 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11538 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11539 (Fmake_network_process, server_accept_connection):
11540 (wait_reading_process_output, read_process_output):
11541 Likewise.
11542
b93aacde
PE
11543 * process.c: Rename or move locals to avoid shadowing.
11544 (list_processes_1, Fmake_network_process):
11545 (read_process_output_error_handler, exec_sentinel_error_handler):
11546 Rename or move locals.
4dc343ee 11547 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11548 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11549 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11550 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11551 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11552
af8a867c 11553 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11554 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11555 Include tparam.h instead, since it declares them.
af8a867c
PE
11556 * cm.h (PC): Remove extern decl; tparam.h now does this.
11557 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11558 * terminfo.c: Include tparam.h, to check interfaces.
11559 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11560 (tparam): Adjust signature to match interface in tparam.h;
11561 this removes some undefined behavior. Check that outstring and len
11562 are zero, which they always are with Emacs.
11563 * tparam.h (PC, BC, UP): New extern decls.
11564
0248044d 11565 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11566 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11567
8ff096c1 11568 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11569 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11570 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11571 (ftfont_list): Remove unused local.
49eaafba
PE
11572 (get_adstyle_property, ftfont_pattern_entity):
11573 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11574 Rename locals to avoid shadowing.
8ff096c1 11575
e2be39f6
PE
11576 * xfont.c (xfont_list_family): Mark var as initialized.
11577
c9735e30
PE
11578 * xml.c (make_dom): Now static.
11579
8f5201ae
PE
11580 * composite.c (composition_compute_stop_pos): Rename local to
11581 avoid shadowing.
b246f932
PE
11582 (composition_reseat_it): Remove unused locals.
11583 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11584 (composition_update_it): Mark var as initialized.
11b61122
PE
11585 (find_automatic_composition): Mark vars as initialized,
11586 with a FIXME (Bug#8290).
8f5201ae 11587
760fbc2c
PE
11588 character.h: Rename locals to avoid shadowing.
11589 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11590 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11591 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11592 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11593 to avoid shadowing.
11594
ff08eb85
PE
11595 * textprop.c (property_change_between_p): Remove; unused.
11596
fc7bf025
PE
11597 * intervals.c (interval_start_pos): Now static.
11598
235d7abc
PE
11599 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11600
44f230aa
SM
11601 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11602 Rename locals to avoid shadowing.
3e7d6594 11603
50060332
PE
11604 * sound.c (wav_play, au_play, Fplay_sound_internal):
11605 Fix pointer signedness.
d01f234b 11606 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11607 (wav_play): Initialize a variable to 0, to prevent undefined
11608 behavior (Bug#8278).
50060332 11609
c4fc4e30
PE
11610 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11611
918436ed
PE
11612 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11613
c939f91b
PE
11614 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11615 clobbering (Bug#8298).
b9c7f648
PE
11616 * sysdep.c (sys_subshell): Likewise.
11617 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11618
6bd8c144
PE
11619 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11620 This should get cleaned up, so that child_setup has the
11621 same signature on all platforms.
11622
7710357c 11623 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11624 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11625
c59da222
CY
116262011-03-22 Chong Yidong <cyd@stupidchicken.com>
11627
11628 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11629 not to be necessary, and produces flickering.
11630
66b87493
GM
116312011-03-20 Glenn Morris <rgm@gnu.org>
11632
11633 * config.in: Remove file.
11634
45b6f6d5
JB
116352011-03-20 Juanma Barranquero <lekktu@gmail.com>
11636
11637 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11638 are now in src/globals.h.
11639 (syms_of_minibuf): Remove spurious & from previous change.
11640
cd394be1 116412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11642
11643 * minibuf.c (completing-read-function): New variable.
11644 (completing-read-default): Rename from completing-read.
11645 (completing-read): Call completing-read-function.
11646
b14e3e21
CY
116472011-03-19 Juanma Barranquero <lekktu@gmail.com>
11648
11649 * xfaces.c (Fx_load_color_file):
11650 Read color file from absolute filename (bug#8250).
11651
f2b726e6
JB
116522011-03-19 Juanma Barranquero <lekktu@gmail.com>
11653
11654 * makefile.w32-in: Update dependencies.
11655
09f6ff02
EZ
116562011-03-17 Eli Zaretskii <eliz@gnu.org>
11657
11658 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11659
29a6015a
PE
116602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11661
a3a6c54e
PE
11662 Fix more problems found by GCC 4.5.2's static checks.
11663
b766f867
PE
11664 * process.c (make_serial_process_unwind, send_process_trap):
11665 (sigchld_handler): Now static.
11666
be02381c
PE
11667 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11668 That way, the code declares only the vars that it needs.
11669 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11670 * s/cygwin.h (PTY_ITERATION): Likewise.
11671 * s/darwin.h (PTY_ITERATION): Likewise.
11672 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11673
57048744
PE
11674 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11675 * process.c (allocate_pty): Don't declare stb unless it's needed.
11676
7914961c 11677 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11678 (CONSTANTLIM): Remove; unused.
11679 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11680 Define only if needed.
7914961c 11681
b3967b18
PE
11682 * unexelf.c (unexec): Name an expression,
11683 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11684 Use a different way to cause a compilation error if anyone uses
11685 n rather than nn, a way that does not involve shadowing.
73366a00 11686 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11687
29a6015a
PE
11688 * deps.mk (unexalpha.o): Remove; unused.
11689
43cfc33e 11690 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11691 * unexec.h: New file.
ce701a33
PE
11692 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11693 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11694 Depend on unexec.h.
11695 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11696 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11697 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11698 Change as necessary to match prototype in unexec.h.
ce701a33 11699
01f44d5a
PE
11700 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11701 shadowing.
4f63c6bb 11702 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11703
a6670b0b
PE
11704 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11705 Rename locals to avoid shadowing.
11706
cef2010d 11707 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11708 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11709
d4d7173a
PE
11710 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11711
f08b802a
PE
11712 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11713 warning when compiling print.c.
11714
3ddb0639
PE
11715 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11716 instead of using an uninitialized var.
5ad03b97 11717 (font_sort_entities): Mark var as initialized.
3ddb0639 11718
170a2692
PE
11719 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11720
e663c700
PE
11721 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11722 pointers to constants.
89bc529a 11723 (font_parse_fcname): Remove unused vars.
7b81e2d0 11724 (font_delete_unmatched): Now static.
ea838e10 11725 (font_get_spec): Remove; unused.
13a547c6
PE
11726 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11727 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11728 Rename or move locals to avoid shadowing.
e663c700 11729
2a80c887 11730 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11731 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11732
1384fa33 11733 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11734 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11735
8b2c52e9
PE
11736 * alloc.c (mark_backtrace): Move decl from here ...
11737 * lisp.h: ... to here, so that it can be checked.
11738
475545b5 11739 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11740 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11741 (lisp_indirect_variable): Name an expression,
11742 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11743 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11744
b1349114 11745 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11746 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11747 Use const pointer when appropriate.
b1349114 11748
a2928364
PE
11749 * lisp.h (get_system_name, get_operating_system_release):
11750 Move decls here, to check interfaces.
11751 * process.c (get_operating_system_release): Move decl to lisp.h.
11752 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11753 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11754 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11755 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11756 (Fformat_time_string, Fencode_time, Finsert_char):
11757 (Ftranslate_region_internal, Fformat):
11758 Rename or remove local vars to avoid shadowing.
9710023e 11759 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11760
a415e694
PE
11761 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11762 avoid shadowing.
11763
8ef4622d
PE
11764 * lisp.h (eassert): Check that the argument compiles, even if
11765 ENABLE_CHECKING is not defined.
11766
946f9a5b
PE
11767 * data.c (Findirect_variable): Name an expression, to avoid
11768 gcc -Wbad-function-cast warning.
112396d6 11769 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11770 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11771 (Fmake_variable_buffer_local, Fmake_local_variable):
11772 Mark variables as initialized.
52746918 11773 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11774
e5aab7e7 11775 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11776 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11777 Rename locals to avoid shadowing.
dff45157
PE
11778 (mark_stack): Move local variables into the #ifdef region where
11779 they're used.
7bc26fdb
PE
11780 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11781 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11782 needed otherwise.
11783 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11784 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11785 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11786
e5aab7e7
PE
11787 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11788 avoids undefined behavior in theory.
11789
4da60324
PE
11790 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11791
88043301
PE
11792 Use functions, not macros, for up- and down-casing (Bug#8254).
11793 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11794 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11795 to use the following functions instead of these macros.
11796 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11797 EMACS_INT, since callers assume the returned value fits in int.
11798 (upcase1): Likewise, for UPCASE_TABLE.
11799 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11800 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11801 the race-condition problem in the old DOWNCASE.
88043301 11802
19ed5445
PE
11803 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11804 Rename locals to avoid shadowing.
11805 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11806 (regex_compile, re_search_2, re_match_2_internal):
11807 Remove unused local vars.
952db0d7
PE
11808 (FREE_VAR): Rewrite so as not to use empty "else",
11809 which gcc can warn about.
da053e48 11810 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11811 (RETALLOC_IF): Define only if needed.
11812 (WORDCHAR_P): Likewise. This one is never needed, but is used
11813 only in a comment talking about a compiler bug, so put inside
11814 the #if 0 of that comment.
11815 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11816 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11817 Remove; unused.
19ed5445 11818
1f3561e4 11819 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11820 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11821 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11822
ded6f8f7
PE
11823 * search.c (simple_search): Remove unused var.
11824
dbd37a95
PE
11825 * dired.c (compile_pattern): Move decl from here ...
11826 * lisp.h: ... to here, so that it can be checked.
11827 (struct re_registers): New forward decl.
11828
7e47afad
PE
11829 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11830
85f24f61
PE
11831 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11832 All uses changed.
11833 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11834 Rename locals to avoid shadowing.
5671df8f 11835 (Fvertical_motion): Mark locals as initialized.
85f24f61 11836
181aa2be 11837 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11838 (casify_region): Mark local as initialized.
181aa2be 11839
930d429c
PE
11840 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11841
7082eac6
PE
11842 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11843 New macros, so that the caller can use some names other than
11844 gcpro1, gcpro2, etc.
11845 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11846 of the new macros.
11847 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11848 argument, for consistency with GCPRO2_VAR, etc: it is now the
11849 prefix of the variable, not the variable itself. All uses
11850 changed.
38b2c076
PE
11851 * dired.c (directory_files_internal, file_name_completion):
11852 Rename locals to avoid shadowing.
11853
15206ed9
PE
11854 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11855 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11856 dired.c's scmp function, had undefined behavior.
11857 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11858 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11859 * buffer.h: ... to here, because these macros use current_buffer,
11860 and the new implementation with inline functions needs to have
11861 current_buffer in scope now, rather than later when the macros
11862 are used.
11863 (downcase, upcase1): New static inline functions.
11864 (DOWNCASE, UPCASE1): Reimplement using these functions.
11865 This avoids undefined behavior in expressions like
11866 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11867 from race conditions in accessing the global variables
11868 case_temp1 and case_temp2.
11869 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11870 * lisp.h (case_temp1, case_temp2): Remove their decls.
11871 * character.h (ASCII_CHAR_P): Move from here ...
11872 * lisp.h: ... to here, so that the inline functions mentioned
11873 above can use them.
11874
4a6bea26
PE
11875 * dired.c (directory_files_internal_unwind): Now static.
11876
f14b7e14
PE
11877 * fileio.c (file_name_as_directory, directory_file_name):
11878 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11879 Now static.
2893f146
PE
11880 (file_name_as_directory): Use const pointers when appropriate.
11881 (Fexpand_file_name): Likewise. In particular, newdir might
11882 point at constant storage, so make it a const pointer.
fd4ead52 11883 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11884 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11885 signedness issues.
f839df0c
PE
11886 (Fset_file_times, Finsert_file_contents, auto_save_error):
11887 Rename locals to avoid shadowing.
f14b7e14 11888
5716756e 11889 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11890 (Ftry_completion, Fall_completions): Rename or remove locals
11891 to avoid shadowing.
5716756e 11892
b4c3046a
PE
11893 * marker.c (bytepos_to_charpos): Remove; unused.
11894
b45db522
PE
11895 * lisp.h (verify_bytepos, count_markers): New decls,
11896 so that gcc does not warn that these functions aren't declared.
11897
85876d07
PE
11898 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11899 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11900 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11901 (copy_text): Remove unused local var.
85876d07 11902
03d78a21 11903 * filelock.c (within_one_second): Now static.
b3dd38ab 11904 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11905
5df8f01b
PE
11906 * buffer.c (fix_overlays_before): Mark locals as initialized.
11907 (fix_start_end_in_overlays): Likewise. This function should be
11908 simplified by using pointers-to-pointers, but that's a different
11909 matter.
b1d876f1 11910 (switch_to_buffer_1): Now static.
8f54f30a
PE
11911 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11912 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11913
a70072c9 11914 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11915 Fix pointer signedness issue.
edced198
PE
11916 (sys_subshell): Mark local as volatile if checking for lint,
11917 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11918 (MAXPATHLEN): Define only if needed.
a70072c9 11919
a0977c44
PE
11920 * process.c (serial_open, serial_configure): Move decls from here ...
11921 * systty.h: ... to here, so that they can be checked.
11922
a884fdcc
PE
11923 * fns.c (get_random, seed_random): Move extern decls from here ...
11924 * lisp.h: ... to here, so that they can be checked.
11925
604efe86 11926 * sysdep.c (reset_io): Now static.
b8950c94 11927 (wait_for_termination_signal): Remove; unused.
604efe86 11928
38fc62d9
PE
11929 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11930 (copy_keymap_item, append_key, push_text_char_description):
11931 Now static.
1004a21a 11932 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11933 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11934 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11935 (describe_map_tree):
11936 Rename locals to avoid shadowing.
38fc62d9 11937
2f2650da
PE
11938 * keyboard.c: Declare functions static if they are not used elsewhere.
11939 (echo_char, echo_dash, cmd_error, top_level_2):
11940 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11941 (read_char, kbd_buffer_get_event, make_lispy_position):
11942 (make_lispy_event, make_lispy_movement, apply_modifiers):
11943 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11944 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11945 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11946 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11947 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11948
a053e86c 11949 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11950 (mark_kboards): Move decl here ...
11951 * alloc.c (mark_kboards): ... from here.
a053e86c 11952
4752793e
PE
11953 * lisp.h (force_auto_save_soon): New decl.
11954
74f10ca7 11955 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11956 (DEFINE_DUMMY_FUNCTION): New macro.
11957 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11958 Use it.
c03cd23f
PE
11959 (main): Add casts to avoid warnings
11960 if GCC considers string literals to be constants.
74f10ca7 11961
022e70d4
PE
11962 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11963
59d6fe83
PE
11964 * dbusbind.c: Pointer signedness fixes.
11965 (xd_signature, xd_append_arg, xd_initialize):
11966 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11967 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11968 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11969 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11970
78320123
PE
11971 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11972 if GCC considers string literals to be constants.
49cebcca 11973 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11974
35ac2a97
SM
119752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11976
fb103ca9
SM
11977 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11978 (print_preprocess, print_object): New macro to fix last change.
11979
35ac2a97
SM
11980 * print.c (print_preprocess): Don't forget font objects.
11981
62973b41
JB
119822011-03-16 Juanma Barranquero <lekktu@gmail.com>
11983
11984 * emacs.c (USAGE3): Doc fixes.
11985
0e48bb22
AS
119862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11987
11988 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11989 structure.
11990
7684e57b
JB
119912011-03-14 Juanma Barranquero <lekktu@gmail.com>
11992
11993 * lisp.h (VWindow_system, Qfile_name_history):
11994 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11995 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11996 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11997
11998 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11999 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12000
12001 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12002 * w32console.c (detect_input_pending, read_input_pending)
12003 (encode_terminal_code):
12004 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12005 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12006 (w32_system_caret_y, Qfile_name_history):
12007 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12008 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12009 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12010 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12011 * w32proc.c (Qlocal, report_file_error):
12012 * w32term.c (Vwindow_system, updating_frame):
12013 * w32uniscribe.c (initialized, uniscribe_font_driver):
12014 Remove unneeded extern declarations.
12015
2aa46d6c
CY
120162011-03-14 Chong Yidong <cyd@stupidchicken.com>
12017
c96bbc66 12018 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12019
cffc6f3b
CY
120202011-03-13 Chong Yidong <cyd@stupidchicken.com>
12021
12022 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12023 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12024 These macros can no longer be used for assignment.
12025
44f230aa
SM
12026 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12027 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12028 (record_buffer_markers, fetch_buffer_markers): New functions for
12029 recording and fetching special buffer markers.
12030 (set_buffer_internal_1, set_buffer_temp): Use them.
12031
12032 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12033
12034 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12035
12036 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12037 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12038
12039 * xdisp.c (hscroll_window_tree):
12040 (reconsider_clip_changes): Use PT instead of BUF_PT.
12041
d251f04b
EZ
120422011-03-13 Eli Zaretskii <eliz@gnu.org>
12043
12044 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12045 $(EMACS_ROOT)/lib/intprops.h.
12046
f0c77cd1
PE
120472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12048
3eca4629
PE
12049 Fix more problems found by GCC 4.5.2's static checks.
12050
7c86ee98
PE
12051 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12052 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12053 (xg_free_frame_widgets): Make it clear that a local variable is
12054 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12055 (gdk_window_get_screen): Make it clear that this macro is needed
12056 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12057 (int_gtk_range_get_value): New function, which avoids a diagnostic
12058 from gcc -Wbad-function-cast.
12059 (xg_set_toolkit_scroll_bar_thumb): Use it.
12060 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12061 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12062 (get_utf8_string, xg_get_file_with_chooser):
12063 Rename locals to avoid shadowing.
12064 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12065
41729b81
PE
12066 * xgselect.c (xg_select): Remove unused var.
12067
f0c77cd1
PE
12068 * image.c (four_corners_best): Mark locals as initialized.
12069 (gif_load): Initialize transparent_p to zero (Bug#8238).
12070 Mark another local as initialized.
ec6cf4c6 12071 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12072
ce0ad53d 12073 * image.c (clear_image_cache): Now static.
d5d5a617 12074 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12075 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12076 (x_edge_detection): Remove unnecessary cast that
12077 gcc -Wbad-function-cast diagnoses.
2037898d 12078 (gif_load): Fix pointer signedness.
6ae141d6
PE
12079 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12080 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12081
33383987 120822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12083
d32df629
PE
12084 Improve quality of tests for time stamp overflow.
12085 For example, without this patch (encode-time 0 0 0 1 1
12086 1152921504606846976) returns the obviously-bogus value (-948597
12087 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12088 reports time overflow. See
12089 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12090 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12091 * editfns.c: Include limits.h and intprops.h.
12092 (TIME_T_MIN, TIME_T_MAX): New macros.
12093 (time_overflow): Move earlier, to before first use.
12094 (hi_time, lo_time): New functions, for an accurate test for
12095 out-of-range times.
12096 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12097 (Fget_internal_run_time): Don't assume time_t fits in int.
12098 (make_time): Use list2 instead of Fcons twice.
12099 (Fdecode_time): More accurate test for out-of-range times.
12100 (check_tm_member): New function.
12101 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12102 (lisp_time_argument): Don't rely on undefined left-shift and
12103 right-shift behavior when checking for time stamp overflow.
8be6f318 12104
fe31d94c
PE
12105 * editfns.c (time_overflow): New function, refactoring common code.
12106 (Fformat_time_string, Fdecode_time, Fencode_time):
12107 (Fcurrent_time_string): Use it.
12108
8be6f318
PE
12109 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12110 * dired.c (make_time): Move to ...
12111 * editfns.c (make_time): ... here.
12112 * systime.h: Note the move.
12113
09d9db2c 121142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12115
126bc0dc
YM
12116 * fringe.c (update_window_fringes): Remove unused variables.
12117
c47cbdfd
YM
12118 * unexmacosx.c (copy_data_segment): Also copy __got section.
12119 (Bug#8223)
12120
7ac80be9
EZ
121212011-03-12 Eli Zaretskii <eliz@gnu.org>
12122
c96bbc66 12123 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12124 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12125 Constify `char *' arguments and their references according to
12126 prototypes in tparam.h.
12127
ecb0f94d 12128 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12129
7ac80be9
EZ
12130 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12131 Adapt all references accordingly.
12132
12133 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12134
ef1fd07e
TT
121352011-03-11 Tom Tromey <tromey@redhat.com>
12136
12137 * buffer.c (syms_of_buffer): Remove obsolete comment.
12138
7ef4b50c
EZ
121392011-03-11 Eli Zaretskii <eliz@gnu.org>
12140
12141 * termhooks.h (encode_terminal_code): Declare prototype.
12142
12143 * msdos.c (encode_terminal_code): Don't declare prototype.
12144
12145 * term.c (encode_terminal_code): Now external again, used by
12146 w32console.c and msdos.c.
12147
44f230aa
SM
12148 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12149 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12150
4b1ec863 121512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12152
1714f52b 12153 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12154
4b1ec863
PE
12155 * fringe.c (update_window_fringes): Mark locals as initialized
12156 (Bug#8227).
12157 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12158
524c7aa6
PE
12159 * alloc.c (mark_fringe_data): Move decl from here ...
12160 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12161 to check its interface.
12162 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12163
a5c0af81 12164 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12165 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12166 (fontset_font): Mark local as initialized.
a9a06e0b 12167 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12168
b4716021
PE
12169 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12170
811e9bac 12171 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12172 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12173 (x_own_selection, Fx_disown_selection_internal): Rename locals
12174 to avoid shadowing.
12175 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12176
7e3ab302
PE
12177 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12178 so that the caller can use some name other than gcpro1.
12179 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12180 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12181 (Fx_backspace_delete_keys_p):
12182 Use them to avoid shadowing, and rename vars to avoid shadowing.
12183 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12184 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12185 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12186 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12187 Remove unused locals.
7e3ab302
PE
12188 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12189 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12190 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12191 macros.
f78faa98 12192
e2b13473
PE
12193 * xterm.h (x_mouse_leave): New decl.
12194
77f23912
PE
12195 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12196 Remove unused functions.
cdf4ba58
PE
12197 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12198 (x_calc_absolute_position): Now static.
7411c686 12199 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12200 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12201 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12202 unless they are used.
38d0b34a
PE
12203 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12204 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12205 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12206 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12207 (x_error_catcher, x_connection_closed, x_error_handler):
12208 (x_error_quitter, xembed_send_message, x_iconify_frame):
12209 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12210 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12211 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12212
44f230aa
SM
12213 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12214 Rename or move locals to avoid shadowing.
6b463e58 12215 (tty_defined_color, merge_face_heights): Now static.
5967d051 12216 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12217 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12218 does not deduce is never used uninitialized.
73719eba
PE
12219 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12220 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12221
426994c3 12222 * terminal.c (store_terminal_param): Now static.
5489860b 12223
032f1620 12224 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12225 (set_frame_menubar): Remove unused local.
d4323972 12226 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12227 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12228 since they might point to immutable storage.
281585b0
PE
12229 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12230 since it's unused otherwise.
032f1620 12231
367c19e5 12232 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12233 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12234 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12235 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12236 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12237 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12238 does not deduce are never used uninitialized.
70739cbe 12239
07b48fa9
PE
12240 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12241
8868a238 12242 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12243 * window.c (window_loop, size_window):
12244 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12245
7e5cf297 12246 * window.c (display_buffer): Now static.
d6550a9f
PE
12247 (size_window): Mark variables that gcc -Wuninitialized
12248 does not deduce are never used uninitialized.
a586633d
PE
12249 * window.h (check_all_windows): New decl, to forestall
12250 gcc -Wmissing-prototypes diagnostic.
5b555da1 12251 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12252
f6095868
PE
12253 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12254 shadowing.
12255 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12256 Include <limits.h>.
12257 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12258 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12259 (load_charset_map): Mark variables that gcc -Wuninitialized
12260 does not deduce are never used uninitialized.
53df7c11 12261 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12262
f38b440c
PE
12263 * coding.c (coding_set_source, coding_set_destination):
12264 Use "else { /* comment */ }" rather than "else /* comment */;"
12265 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12266 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12267 a block, when the outer 'i' will do.
12268 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12269 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12270 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12271 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12272 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12273 Rename locals to avoid shadowing.
12274 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12275 * coding.c (emacs_mule_char, encode_invocation_designation):
12276 Now static, since they're not used elsewhere.
413bb2db 12277 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12278 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12279 (decode_coding_emacs_mule): Mark variables that gcc
12280 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12281 (detect_coding_iso_2022): Initialize a local variable that might
12282 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12283 this initialization is needed. (Bug#8211)
5f58e762
PE
12284 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12285 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12286 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12287 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12288 Remove unused macros.
f38b440c 12289
232b38b9 12290 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12291 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12292 * character.c (string_count_byte8): Likewise.
232b38b9 12293
fb90da1b
PE
12294 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12295 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12296
fb93dbc2
PE
12297 * chartab.c (copy_sub_char_table): Now static, since it's not used
12298 elsewhere.
5c156ace
PE
12299 (sub_char_table_ref_and_range, char_table_ref_and_range):
12300 Rename locals to avoid shadowing.
bbcd0949 12301 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12302
7d3b3862 12303 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12304 (BIDI_BOB): Remove unused macro.
7d3b3862 12305
6be7d3da
PE
12306 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12307 deduce are never used uninitialized.
c2ed9c8b 12308 * term.c (encode_terminal_code): Likewise.
6be7d3da 12309
75f8807f 12310 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12311
50938595
PE
12312 * tparam.h: New file.
12313 * term.c, tparam.h: Include it.
12314 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12315 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12316 Move these decls to tparam.h, and make them agree with what
12317 is actually in tparam.c. The previous trick of using incompatible
12318 decls in different modules does not conform to the C standard.
12319 All callers of tparam changed to use tparam's actual API.
12320 * tparam.c (tparam1, tparam, tgoto):
12321 Use const pointers where appropriate.
12322
fbceeba2
PE
12323 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12324 * cm.h (struct cm): Likewise.
12325 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12326 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12327 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12328 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12329 (turn_on_face, init_tty): Likewise.
12330 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12331
7f3f1250
PE
12332 * term.c (term_mouse_position): Rename local to avoid shadowing.
12333
e6ca6543
PE
12334 * alloc.c (mark_ttys): Move decl from here ...
12335 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12336
c40f8d15
AS
123372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12338
12339 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12340
cfe0661d
JB
123412011-03-09 Juanma Barranquero <lekktu@gmail.com>
12342
12343 * search.c (compile_pattern_1): Remove argument regp, unused since
12344 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12345 (compile_pattern): Don't pass it.
12346
0afb4571
J
123472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12348
12349 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12350 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12351 for ! HAVE_GTK3.
12352 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12353
12354 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12355
12356 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12357 gdk_window_get_screen, gdk_window_get_geometry,
12358 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12359 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12360 (xg_get_pixbuf_from_pixmap): New function.
12361 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12362 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12363 Call xg_get_pixbuf_from_pixmap instead of
12364 gdk_pixbuf_get_from_drawable.
12365 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12366 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12367 (xg_check_special_colors): Use GtkStyleContext and its functions
12368 for HAVE_GTK3.
12369 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12370 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12371 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12372 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12373 Call gtk_widget_get_preferred_size.
0afb4571
J
12374 (xg_frame_resized): gdk_window_get_geometry only takes 5
12375 parameters.
44f230aa
SM
12376 (xg_win_to_widget, xg_event_is_for_menubar):
12377 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12378 (xg_set_widget_bg): New function.
12379 (delete_cb): New function.
895009e1 12380 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12381 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12382 (xg_set_background_color): Call xg_set_widget_bg.
12383 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12384 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12385 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12386 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12387 if ! HAVE_GTK3.
12388 (update_frame_tool_bar): Call gtk_widget_hide.
12389 (xg_initialize): Use GDK_KEY_g.
12390
12391 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12392 if ! HAVE_GTK3
12393 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12394
12395 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12396 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12397 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12398
1c2cc4ef
JB
123992011-03-08 Juanma Barranquero <lekktu@gmail.com>
12400
12401 * w32xfns.c (select_palette): Check success of RealizePalette against
12402 GDI_ERROR, not zero.
12403
33383987 12404See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12405
12406;; Local Variables:
12407;; coding: utf-8
aac0c6e3
MR
12408;; End:
12409
2f097256 12410 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12411
12412 This file is part of GNU Emacs.
12413
12414 GNU Emacs is free software: you can redistribute it and/or modify
12415 it under the terms of the GNU General Public License as published by
12416 the Free Software Foundation, either version 3 of the License, or
12417 (at your option) any later version.
12418
12419 GNU Emacs is distributed in the hope that it will be useful,
12420 but WITHOUT ANY WARRANTY; without even the implied warranty of
12421 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12422 GNU General Public License for more details.
12423
12424 You should have received a copy of the GNU General Public License
12425 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.