Protoize
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1dae0f0a
AS
12011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2
3 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Protoize.
5 * data.c (fmod): Likewise.
6 * dispnew.c (swap_glyphs_in_rows): Likewise.
7 * emacs.c (memory_warning_signal): Likewise.
8 * floatfns.c (float_error): Likewise.
9 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10 (otf_open, font_otf_capability, generate_otf_features)
11 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
12 Likewise.
13 * image.c (pbm_read_file): Likewise.
14 * indent.c (string_display_width): Likewise.
15 * intervals.c (check_for_interval, search_for_interval)
16 (inc_interval_count, count_intervals, root_interval)
17 (adjust_intervals_for_insertion, make_new_interval): Likewise.
18 * lread.c (defalias): Likewise.
19 * regex.c (set_image_of_range_1, set_image_of_range)
20 (regex_grow_registers): Likewise.
21 * sysdep.c (strerror): Likewise.
22 * termcap.c (valid_filename_p, tprint, main): Likewise.
23 * tparam.c (main): Likewise.
24 * unexhp9k800.c (run_time_remap, save_data_space)
25 (update_file_ptrs, read_header, write_header, calculate_checksum)
26 (copy_file, copy_rest, display_header): Likewise.
27 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
28 Likewise.
29 * xdisp.c (check_it): Likewise.
30 * xfaces.c (register_color, unregister_color, unregister_colors):
31 Likewise.
32 * xfns.c (print_fontset_result): Likewise.
33 * xrdb.c (member, fatal, main): Likewise.
34
99033785
PE
352011-07-10 Paul Eggert <eggert@cs.ucla.edu>
36
37 Fix minor problems found by static checking (Bug#9031).
38 * chartab.c (char_table_set_range, map_sub_char_table):
39 Remove unused locals.
40 (uniprop_table): Now static.
41 * composite.c (_work_char): Remove unused static var.
42
9cb2ac56
JB
432011-07-09 Juanma Barranquero <lekktu@gmail.com>
44
45 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
46
f25661f0
JD
472011-07-09 Jan Djärv <jan.h.d@swipnet.se>
48
49 * gtkutil.c (qttip_cb): Remove code without function.
50
8278c4fe
EZ
512011-07-09 Eli Zaretskii <eliz@gnu.org>
52
53 * w32.c (pthread_sigmask): New stub.
54
1692ae2d 552011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 56
8a6ebd58 57 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
58 sigprocmask is portable only for single-threaded applications, and
59 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
60 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
61 (LIBES): Use it.
62 * callproc.c (Fcall_process):
63 * process.c (create_process):
64 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
65 Use pthread_sigmask, not sigprocmask.
123403e4 66
1b854618
JD
672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
68
69 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
70 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
71 wrong (Bug#8591).
72
3fe4b549
JD
732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
74
0ce7e563
JD
75 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
76 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
77 (xg_hide_tooltip): Fix comment.
78
3fe4b549
JD
79 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
80 in registerServicesMenuSendTypes.
81 (validRequestorForSendType): Don't check ns_return_types.
82
83 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
84 ns_return_type.
85
5df75e47
JR
862011-07-08 Jason Rumney <jasonr@gnu.org>
87
88 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
89 frame struct members of non-existent frames (Bug#6284).
90
699c10bd
JD
912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
92
4393663b
JD
93 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
94 variable firstTime not needed on OSX >= 10.6.
95 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
96 >= 10.5. Use setKnobProportion, setDoubleValue.
97
98 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
99 (MAC_OS_X_VERSION_10_5): Define if not defined.
100 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
101 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
102 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
103
104 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
105 cString and lossyCString on OSX >= 10.4
106
107 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
108 sizeToFit on OSX >= 10.2.
109
110 * nsimage.m (allocInitFromFile): Don't use deprecated method
111 bestRepresentationForDevice on OSX >= 10.6.
112
113 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
114 to avoid warning.
115
116 * emacs.c: Declare unexec_init_emacs_zone.
117
a63e0781
JD
118 * nsgui.h: Fix compiler warning about gnulib redefining verify.
119
699c10bd
JD
120 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
121
122 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
123 on svcsMenu (Bug#8842).
124
125 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
126 ns_return_types.
127 (Fns_list_services): Just return Qnil on 10.6, code not working there.
128
129 * nsterm.m (QUTF8_STRING): Declare.
130 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
131 (validRequestorForSendType): Return type is (id).
132 Change indexOfObjectIdenticalTo to indexOfObject.
133 Check if we have local selection before returning self (Bug#8842).
134 (writeSelectionToPasteboard): Put local selection into paste board
135 if we have a local selection (Bug#8842).
136 (syms_of_nsterm): DEFSYM QUTF8_STRING.
137
138 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
139 (ns_get_local_selection): Declare.
140
54e10184
LMI
1412011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
142
9888ff71
LMI
143 * keymap.c (describe_map_tree): Don't insert a double newline at
144 the end of the buffer (bug#1169) and return whether we inserted
145 something.
146
54e10184
LMI
147 * callint.c (Fcall_interactively): Change "reading args" to
148 "providing args" to try to clarify what it does (bug#1010).
149
15fa4783
KH
1502011-07-07 Kenichi Handa <handa@m17n.org>
151
152 * composite.c (composition_compute_stop_pos): Ignore a static
153 composition starting before CHARPOS (Bug#8915).
154
155 * xdisp.c (handle_composition_prop): Likewise.
156
a8815b00
EZ
1572011-07-07 Eli Zaretskii <eliz@gnu.org>
158
159 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
160 (Bug#9015)
161
ef7b981d 1622011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
163
164 * character.h (unicode_category_t): New enum type.
165
166 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
167 (Qchar_code_property_table): New variable.
168 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
169 (UNIPROP_COMPRESSED_FORM_P): New macros.
170 (char_table_ascii): Uncompress the compressed values.
171 (sub_char_table_ref): New arg is_uniprop. Callers changed.
172 Uncompress the compressed values.
173 (sub_char_table_ref_and_range): Likewise.
174 (char_table_ref_and_range): Uncompress the compressed values.
175 (sub_char_table_set): New arg is_uniprop. Callers changed.
176 Uncompress the compressed values.
177 (sub_char_table_set_range): Args changed. Callers changed.
178 (char_table_set_range): Adjuted for the above change.
179 (map_sub_char_table): Delete args default_val and parent. Add arg
180 top. Give decoded values to a Lisp function.
181 (map_char_table): Adjusted for the above change. Give decoded
182 values to a Lisp function. Gcpro more variables.
183 (uniprop_table_uncompress)
184 (uniprop_decode_value_run_length): New functions.
185 (uniprop_decoder, uniprop_decoder_count): New variables.
186 (uniprop_get_decoder, uniprop_encode_value_character)
187 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
188 New functions.
189 (uniprop_encoder, uniprop_encoder_count): New variables.
190 (uniprop_get_encoder, uniprop_table)
191 (Funicode_property_table_internal, Fget_unicode_property_internal)
192 (Fput_unicode_property_internal): New functions.
193 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
194 Sunicode_property_table_internal, Sget_unicode_property_internal,
195 and Sput_unicode_property_internal. Defvar_lisp
196 char-code-property-alist.
197
198 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
199 Vunicode_category_table.
200
201 * font.c (font_range): Adjusted for the change of
202 Vunicode_category_table.
203
76b397fb
DN
2042011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
205
206 * m/iris4d.h: Remove file, move contents ...
207 * s/irix6-5.h: ... here.
208
22b4128e
PE
2092011-07-06 Paul Eggert <eggert@cs.ucla.edu>
210
211 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
212 * alloc.c (mark_buffer):
213 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
214 (clone_per_buffer_values): Don't assume that
22b4128e
PE
215 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
216 This isn't true in general, and it's particularly not true
217 if Emacs is configured with --with-wide-int.
218 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
219 New macros, used in the buffer.c change.
220
869795d6
JD
2212011-07-05 Jan Djärv <jan.h.d@swipnet.se>
222
223 * xsettings.c: Use both GConf and GSettings if both are available.
224 (store_config_changed_event): Add comment.
225 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
226 (store_tool_bar_style_changed): New functions.
227 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
228 (struct xsettings): Move font inside HAVE_XFT.
229 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
230 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
231 Move inside HAVE_XFT.
232 (something_changed_gsettingsCB): Renamed from something_changedCB.
233 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
234 also.
235 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
236 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
237 (something_changed_gconfCB): Renamed from something_changedCB.
238 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
239 (parse_settings): Move check for font inside HAVE_XFT.
240 (read_settings, apply_xft_settings): Add comment.
241 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
242 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
243 call store_font_name_changed.
244 (xft_settings_event): Add comment.
245 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
246 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
247 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
248 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
249 (xsettings_initialize): Call init_gsettings last.
250 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
251 comment.
252
d8ed26bd
PE
2532011-07-05 Paul Eggert <eggert@cs.ucla.edu>
254
255 Random fixes. E.g., (random) never returned negative values.
256 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
257 subseconds part to the entropy, as that's a bit more random.
258 Prefer signed to unsigned, since the signedness doesn't matter and
259 in general we prefer signed. When given a limit, use a
260 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
261 latter isn't right if USE_2_TAGS_FOR_INTS.
262 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
263 not 0..VALMASK. Don't discard "excess" bits that random () returns.
264
cabf1cac
SM
2652011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
266
267 * textprop.c (text_property_stickiness):
268 Obey Vtext_property_default_nonsticky.
269 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
270 * w32fns.c (syms_of_w32fns):
271 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
272
6e9b2be9
PE
2732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
274
275 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
276 This is more efficient than Ffile_directory_p and avoids a minor race.
277
90186c68
LMI
2782011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
279
7c301272
LMI
280 * buffer.c (Foverlay_put): Say what the return value is
281 (bug#7835).
282
c4f2d8d4
LMI
283 * fileio.c (barf_or_query_if_file_exists): Check first if the file
284 is a directory before asking whether to use the file name
285 (bug#7564).
ad637907
LMI
286 (barf_or_query_if_file_exists): Make the "File is a directory"
287 error be more correct.
c4f2d8d4 288
90186c68
LMI
289 * fns.c (Frequire): Remove the mention of the .gz files, since
290 that's installation-specific, but keep the mention of
291 `get-load-suffixes'.
292
da64016e
PE
2932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
294
295 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
296 Report string overflow if the output is too long.
297
7d47b580
JB
2982011-07-04 Juanma Barranquero <lekktu@gmail.com>
299
a555cb87
JB
300 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
301 (syms_of_gnutls): Remove duplicate DEFSYM for
302 Qgnutls_bootprop_verify_hostname_error, an error for
303 Qgnutls_bootprop_verify_error (which is no longer used).
304
7d47b580
JB
305 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
306 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
307 Also (re)move comments that are misplaced or no longer relevant.
308
1e49bfab
LMI
3092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
310
311 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
312
1485f4c0
CY
3132011-07-03 Chong Yidong <cyd@stupidchicken.com>
314
315 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
316 and background color parameters if they have been changed.
317
a9ab721e
LMI
3182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
319
320 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
321
cf7cff57
PE
3222011-07-03 Paul Eggert <eggert@cs.ucla.edu>
323
2e13213d
PE
324 * xsettings.c (SYSTEM_FONT): Define only when used.
325 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
326
cf7cff57
PE
327 * keymap.c (access_keymap_1): Now static.
328
7a8e04f7
CY
3292011-07-02 Chong Yidong <cyd@stupidchicken.com>
330
331 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
332 leave any prefix arg for the up event (Bug#1586).
333
61352f62
LMI
3342011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
335
69bb1ef7
LMI
336 * lread.c (syms_of_lread): Mention single symbols defined by
337 `defvar' or `defconst' (bug#7154).
338
61352f62 339 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 340 (Frequire): Mention get-load-suffixes.
61352f62 341
28545e04
MR
3422011-07-02 Martin Rudalics <rudalics@gmx.at>
343
344 * window.h (window): Remove clone_number slot.
345 * window.c (Fwindow_clone_number, Fset_window_clone_number):
346 Remove.
347 (make_parent_window, make_window, saved_window)
348 (Fset_window_configuration, save_window_save): Don't deal with
349 clone numbers.
350 * buffer.c (Qclone_number): Remove declaration.
351 (sort_overlays, overlay_strings): Don't deal with clone numbers.
352
3349e122
SM
3532011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
354
355 Add multiple inheritance to keymaps.
356 * keymap.c (Fmake_composed_keymap): New function.
357 (Fset_keymap_parent): Simplify.
358 (fix_submap_inheritance): Remove.
359 (access_keymap_1): New function extracted from access_keymap to handle
360 embedded parents and handle lists of maps.
361 (access_keymap): Use it.
362 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
363 (Fcopy_keymap): Handle embedded parents.
364 (Fcommand_remapping, define_as_prefix): Simplify.
365 (Fkey_binding): Simplify.
366 (syms_of_keymap): Move minibuffer-local-completion-map,
367 minibuffer-local-filename-completion-map,
368 minibuffer-local-must-match-map, and
369 minibuffer-local-filename-must-match-map to Elisp.
370 (syms_of_keymap): Defsubr make-composed-keymap.
371 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
372 (parse_menu_item): Trivial simplification.
373
3279eb87
GM
3742011-07-01 Glenn Morris <rgm@gnu.org>
375
376 * Makefile.in (SETTINGS_LIBS): Fix typo.
377
4550efdf
KI
3782011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
379
380 * coding.c (Fencode_coding_string): Record the last coding system
381 used, as the function doc string says (bug#8738).
382
0949d2b6
JD
3832011-07-01 Jan Djärv <jan.h.d@swipnet.se>
384
385 * xsettings.c (store_monospaced_changed): Take new font as arg and
386 check for change against current_mono_font.
387 (EMACS_TYPE_SETTINGS): Remove this and related defines.
388 (emacs_settings_constructor, emacs_settings_get_property)
389 (emacs_settings_set_property, emacs_settings_class_init)
390 (emacs_settings_init, gsettings_obj): Remove.
391 (something_changedCB): New function for HAVE_GSETTINGS.
392 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
393 with value as argument.
394 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
395 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 396 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
397 "changed".
398
399 * xgselect.c: Add defined (HAVE_GSETTINGS).
400 (xgselect_initialize): Ditto.
401
402 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
403 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
404 xg_select.
405
bbc6b304
PE
4062011-07-01 Paul Eggert <eggert@cs.ucla.edu>
407
408 * eval.c (struct backtrace): Simplify and port the data structure.
409 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
410 signed bit field, as this assumption is not portable and it makes
411 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
412 "char debug_on_exit : 1" as this is not portable either; instead,
413 use the portable "unsigned int debug_on_exit : 1". Remove unused
414 member evalargs. Remove obsolete comments about cc bombing out.
415
9851bfc5
JD
4162011-06-30 Jan Djärv <jan.h.d@swipnet.se>
417
51bb811f 418 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
419 Let HAVE_GSETTINGS override HAVE_GCONF.
420 (store_monospaced_changed): New function.
421 (EMACS_SETTINGS): A new type derived from GObject to handle
422 GSettings notifications.
423 (emacs_settings_constructor, emacs_settings_get_property)
424 (emacs_settings_set_property, emacs_settings_class_init):
425 New functions.
426 (gsettings_client, gsettings_obj): New variables.
427 (GSETTINGS_SCHEMA): New define.
428 (something_changedCB): Call store_monospaced_changed.
429 (init_gsettings): New function.
430 (xsettings_initialize): Call init_gsettings.
431 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
432 to NULL.
433
434 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
435 GCONF_CFLAGS/LIBS.
436
5386012d
MR
4372011-06-29 Martin Rudalics <rudalics@gmx.at>
438
439 * window.c (resize_root_window, grow_mini_window)
440 (shrink_mini_window): Rename Qresize_root_window to
441 Qwindow_resize_root_window and Qresize_root_window_vertically to
442 Qwindow_resize_root_window_vertically.
443
f13e0b08
PE
4442011-06-28 Paul Eggert <eggert@cs.ucla.edu>
445
446 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
447
94515237
JB
4482011-06-27 Juanma Barranquero <lekktu@gmail.com>
449
450 * makefile.w32-in: Redesign dependencies so they reflect more
451 clearly which files are directly included by each source file,
452 and not through other includes.
453
e43b6e43
MR
4542011-06-27 Martin Rudalics <rudalics@gmx.at>
455
456 * buffer.c (Qclone_number): Declare static and DEFSYM it.
457 (sort_overlays, overlay_strings): When an overlay's clone number
458 matches the window's clone number process the overlay even if
459 the overlay's window property doesn't match the current window.
460
d68443dc
MR
461 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
462 (Fwindow_hchild): Rename to Fwindow_left_child.
463 (Fwindow_next): Rename to Fwindow_next_sibling.
464 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
465 (resize_window_check): Rename to window_resize_check.
466 (resize_window_apply): Rename to window_resize_apply.
467 (Fresize_window_apply): Rename to Fwindow_resize_apply.
468 (Fdelete_other_windows_internal, resize_frame_windows)
469 (Fsplit_window_internal, Fdelete_window_internal)
470 (grow_mini_window, shrink_mini_window)
471 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 472
c7e73be5
JD
4732011-06-26 Jan Djärv <jan.h.d@swipnet.se>
474
475 * emacsgtkfixed.h: State that this is only used with Gtk+3.
476 (emacs_fixed_set_min_size): Remove.
477 (emacs_fixed_new): Take frame as argument.
478
479 * emacsgtkfixed.c: State that this is only used with Gtk+3.
480 (_EmacsFixedPrivate): Remove minwidth/height.
481 Add struct frame *f.
482 (emacs_fixed_init): Initialize priv->f.
483 (get_parent_class, emacs_fixed_set_min_size): Remove.
484 (emacs_fixed_new): Set priv->f to argument.
485 (emacs_fixed_get_preferred_width)
486 (emacs_fixed_get_preferred_height): Use min_width/height from
487 frames size_hint to set minimum and natural (Bug#8919).
488 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
489 and use min_width/height from frames size_hint to set
490 min_width/height (Bug#8919).
491
492 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
493 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
494 Fix indentation.
c7e73be5 495
cf99dcf8
EZ
4962011-06-26 Eli Zaretskii <eliz@gnu.org>
497
498 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
499 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
500 called at ZV.
501
029529ac
CY
5022011-06-26 Chong Yidong <cyd@stupidchicken.com>
503
504 * process.c (wait_reading_process_output): Bypass select if
505 waiting for a cell while ignoring keyboard input, and input is
506 pending. Suggested by Jan Djärv (Bug#8869).
507
7a7ef429
PE
5082011-06-25 Paul Eggert <eggert@cs.ucla.edu>
509
510 Use gnulib's dup2 module instead of rolling our own.
511 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
512
11fdef7d 5132011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
514
515 * dispnew.c (scrolling_window): Before scrolling, turn off a
516 mouse-highlight in the window being scrolled.
517
cd3520a4
JB
5182011-06-24 Juanma Barranquero <lekktu@gmail.com>
519
520 Move DEFSYM to lisp.h and use everywhere.
521
522 * character.h (DEFSYM): Move declaration...
523 * lisp.h (DEFSYM): ...here.
524
525 * gnutls.c:
526 * minibuf.c:
527 * w32menu.c:
528 * w32proc.c:
529 * w32select.c: Don't include character.h.
530
531 * alloc.c (syms_of_alloc):
532 * buffer.c (syms_of_buffer):
533 * bytecode.c (syms_of_bytecode):
534 * callint.c (syms_of_callint):
535 * casefiddle.c (syms_of_casefiddle):
536 * casetab.c (init_casetab_once):
537 * category.c (init_category_once, syms_of_category):
538 * ccl.c (syms_of_ccl):
539 * cmds.c (syms_of_cmds):
540 * composite.c (syms_of_composite):
541 * dbusbind.c (syms_of_dbusbind):
542 * dired.c (syms_of_dired):
543 * dispnew.c (syms_of_display):
544 * doc.c (syms_of_doc):
545 * editfns.c (syms_of_editfns):
546 * emacs.c (syms_of_emacs):
547 * eval.c (syms_of_eval):
548 * fileio.c (syms_of_fileio):
549 * fns.c (syms_of_fns):
550 * frame.c (syms_of_frame):
551 * fringe.c (syms_of_fringe):
552 * insdel.c (syms_of_insdel):
553 * keymap.c (syms_of_keymap):
554 * lread.c (init_obarray, syms_of_lread):
555 * macros.c (syms_of_macros):
556 * msdos.c (syms_of_msdos):
557 * print.c (syms_of_print):
558 * process.c (syms_of_process):
559 * search.c (syms_of_search):
560 * sound.c (syms_of_sound):
561 * syntax.c (init_syntax_once, syms_of_syntax):
562 * terminal.c (syms_of_terminal):
563 * textprop.c (syms_of_textprop):
564 * undo.c (syms_of_undo):
565 * w32.c (globals_of_w32):
566 * window.c (syms_of_window):
567 * xdisp.c (syms_of_xdisp):
568 * xfaces.c (syms_of_xfaces):
569 * xfns.c (syms_of_xfns):
570 * xmenu.c (syms_of_xmenu):
571 * xsettings.c (syms_of_xsettings):
572 * xterm.c (syms_of_xterm): Use DEFSYM.
573
4228cf16
TZ
5742011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
575
cd3520a4 576 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 577
7fcccf1e
PE
5782011-06-23 Paul Eggert <eggert@cs.ucla.edu>
579
7efb4e0e
PE
580 Integer and buffer overflow fixes (Bug#8873).
581
ff5844ad
PE
582 * print.c (printchar, strout): Check for string overflow.
583 (PRINTPREPARE, printchar, strout):
584 Don't set size unless allocation succeeds.
585
90532f02
PE
586 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
587 for sizes. Check for string overflow more accurately.
588 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
589
6d84508d
PE
590 * macros.c: Integer and buffer overflow fixes.
591 * keyboard.h (struct keyboard.kbd_macro_bufsize):
592 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
593 Use ptrdiff_t, not int, for sizes.
594 Don't increment bufsize until after realloc succeeds.
595 Check for size-calculation overflow.
596 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
597
437b2cb4
PE
598 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
599
8b9ac8b4
PE
600 * lread.c: Integer overflow fixes.
601 (read_integer): Radix is now EMACS_INT, not int,
602 to improve quality of diagnostics for out-of-range radices.
603 Calculate buffer size correctly for out-of-range radices.
604 (read1): Check for integer overflow in radices, and in
605 read-circle numbers.
82cb60d3
PE
606 (read_escape): Avoid int overflow.
607 (Fload, openp, read_buffer_size, read1)
608 (substitute_object_recurse, read_vector, read_list, map_obarray):
609 Use ptrdiff_t, not int, for sizes.
610 (read1): Use EMACS_INT, not int, for sizes.
20270765 611 Check for size overflow.
8b9ac8b4 612
7fcccf1e
PE
613 * image.c (cache_image): Check for size arithmetic overflow.
614
bfbbd7e7
PE
615 * lread.c: Integer overflow issues.
616 (saved_doc_string_size, saved_doc_string_length)
617 (prev_saved_doc_string_size, prev_saved_doc_string_length):
618 Now ptrdiff_t, not int.
619 (read1): Don't assume doc string length fits in int. Check for
620 out-of-range doc string lengths.
621 (read_list): Don't assume file position fits in int.
39019e54 622 (read_escape): Check for hex character overflow.
bfbbd7e7 623
4e323265
LL
6242011-06-22 Leo Liu <sdl.web@gmail.com>
625
626 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
627 Move to minibuffer.el.
628
85fece3e
PE
6292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
630
20b84ce9 631 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
632 The following patches are for when GLYPH_DEBUG && !XASSERT.
633 * dispextern.h (trace_redisplay_p, dump_glyph_string):
634 * dispnew.c (flush_stdout):
635 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
636 Mark as externally visible.
637 * dispnew.c (check_window_matrix_pointers): Now static.
638 * dispnew.c (window_to_frame_vpos):
639 * xfns.c (unwind_create_frame):
640 * xterm.c (x_check_font): Remove unused local.
641 * scroll.c (CHECK_BOUNDS):
642 * xfaces.c (cache_fache): Rename local to avoid shadowing.
643 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
644 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
645 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
646 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
647 Now static.
648 (debug_method_add): Use va_list and vsprintf rather than relying
649 on undefined behavior with wrong number of arguments.
650 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
651 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
652 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
653 since we're not interested in debugging glyphs with old libraries.
654 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
655 GCC 4.6.0's static checking.
656
0766b489
PE
6572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
658
31fd4b32
PE
659 Integer overflow and signedness fixes (Bug#8873).
660 A few related buffer overrun fixes, too.
661
b79e8648
PE
662 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
663
0766b489
PE
664 * dispextern.h (struct face.stipple):
665 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
666 (x_bitmap_mask, x_allocate_bitmap_record)
667 (x_create_bitmap_from_data, x_create_bitmap_from_file)
668 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
669 (x_create_bitmap_from_xpm_data):
670 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
671 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
672 (.bitmaps_last):
673 * xfaces.c (load_pixmap):
674 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
675 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
676 (.bitmaps_last, struct x_output.icon_bitmap):
677 Use ptrdiff_t, not int, for bitmap indexes.
678 (x_allocate_bitmap_record): Check for size overflow.
679 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
680
b081724f
PE
681 Use ptrdiff_t, not int, for overlay counts.
682 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
683 * editfns.c (overlays_around, get_pos_property):
684 * textprop.c (get_char_property_and_overlay):
685 * xdisp.c (next_overlay_change, note_mouse_highlight):
686 * xfaces.c (face_at_buffer_position):
21514da7
PE
687 * buffer.c (OVERLAY_COUNT_MAX): New macro.
688 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
689 (Fnext_overlay_change, Fprevious_overlay_change)
690 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 691 Use ptrdiff_t, not int, for sizes.
21514da7 692 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 693
3de73e5e
PE
694 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
695
2606c57b
PE
696 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
697 (x_session_initialize): Do not assume string length fits in int.
698
aaafe47a
PE
699 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
700 This is unlikely, but can occur if DPI is outlandish.
701
2674ddc8 702 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
703 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
704
28154962
PE
705 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
706 * xrdb.c (magic_file_p, search_magic_path):
707 Omit last arg SUFFIX; it was always 0. All callers changed.
708 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
709
7de51af5
PE
710 * xfont.c (xfont_match): Avoid need for strlen.
711
25ed6cc3
PE
712 * xfns.c: Don't assume strlen fits in int.
713 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
714
4eab31dd
PE
715 * xdisp.c (message_log_check_duplicate): Return intmax_t,
716 not unsigned long, as we prefer signed integers. All callers changed.
717 Detect integer overflow in repeat count.
718 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 719 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 720
171e2a58
PE
721 * termcap.c: Don't assume sizes fit in int and never overflow.
722 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
723 (gobble_line): Check for size-calculation overflow.
724
ad39faca 725 * minibuf.c (Fread_buffer):
6e5bb2dc 726 * lread.c (intern, intern_c_string):
74ca2eb3
PE
727 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
728 Don't assume string length fits in int.
729
52c61c22 730 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
731 * gtkutil.c (style_changed_cb): Avoid need for strlen.
732
b5b8c9e5
PE
733 * font.c: Don't assume string length fits in int.
734 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
735 Use ptrdiff_t, not int.
ccd6111c
PE
736 (font_intern_prop): Don't assume string length fits in int.
737 Don't assume integer property fits in fixnum.
738 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 739
882f0d81 740 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 741 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
742 Reformulate so as not to need the command string.
743 Invoke gzip -cd rather than gunzip, as it's more portable.
744 (lock_info_type, lock_file_1, lock_file):
745 Don't assume pid_t and time_t fit in unsigned long.
746 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
747 (current_lock_owner): Prefer signed type for sizes.
748 Use memcpy, not strncpy, where memcpy is what is really wanted.
749 Don't assume (via atoi) that time_t and pid_t fit in int.
750 Check for time_t and/or pid_t out of range, e.g., via a network share.
751 Don't alloca where an auto var works fine.
752
93f4cf88
PE
753 * fileio.c: Fix some integer overflow issues.
754 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
755 Don't assume string length fits in int.
756 (directory_file_name): Don't assume string length fits in long.
757 (make_temp_name): Don't assume pid fits in int, or that its print
758 length is less than 20.
759
f3e92b69
PE
760 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
761
1bfdaf10
PE
762 * coding.c (make_subsidiaries): Don't assume string length fits in int.
763
35016e9a
PE
764 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
765
3d1e65a1
PE
766 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
767 We prefer signed integers, even for size calculations.
768
0b963a93
PE
769 * emacs.c: Don't assume string length fits in 'int'.
770 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
771 (main): Don't invoke strlen when not needed.
772
573f4b54
PE
773 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
774 (XD_DEBUG_MESSAGE): Don't waste a byte.
775
989f33ba
PE
776 * callproc.c (getenv_internal_1, getenv_internal)
777 (Fgetenv_internal):
965d34eb
PE
778 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
779
e4d29b33
PE
780 * lread.c (invalid_syntax): Omit length argument.
781 All uses changed. This doesn't fix a bug, but it simplifies the
782 code away from its former Hollerith-constant appearance, and it's
783 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 784 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 785
eb49b136
PE
786 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
787 This didn't break anything, but it didn't help either.
788 It's confusing to put a bogus integer in a place where the actual
789 value does not matter.
9f62aeb1 790 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 791 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 792
15375a22
PE
793 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
794 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
795 implementation.
b61cc01c
PE
796 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
797 We prefer signed types, and the value cannot exceed the EMACS_INT
798 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
799 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
800 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
801 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 802
53b2623d
PE
803 * indent.c (sane_tab_width): New function.
804 (current_column, scan_for_column, Findent_to, position_indentation)
805 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 806 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 807
51cab52b 808 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 809
f2ed8a70
PE
810 * lisp.h (lint_assume): New macro.
811 * composite.c (composition_gstring_put_cache):
812 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
813
abe80cc6
PE
814 * editfns.c, insdel.c:
815 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 816
b02c740e
PE
817 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
818
ebc96716
PE
819 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
820
b4e50fa0 821 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 822 Use much-faster test for byte-length change.
311d5d7c 823 Don't assume string byte-length fits in 'int'.
a4cf38e4 824 Check that character arg fits in 'int'.
85461888 825 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 826
c0c1ee9f
PE
827 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
828
a498d7f4
PE
829 * fns.c (concat): Catch string overflow earlier.
830 Do not rely on integer wraparound.
831
51cab52b
PE
832 * dispextern.h (struct it.overlay_strings_charpos)
833 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
834 * xdisp.c (forward_to_next_line_start)
835 (back_to_previous_visible_line_start)
836 (reseat_at_next_visible_line_start, next_element_from_buffer):
837 Don't arbitrarily truncate the value of 'selective' to int.
838
76031fad
PE
839 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
840
5eb55db9
PE
841 * composite.c: Don't truncate sizes to 'int'.
842 (composition_gstring_p, composition_reseat_it)
843 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
844 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
845 not EMACS_UINT, for indexes.
5eb55db9 846
0703a717
PE
847 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
848
d6202519
PE
849 * buffer.c: Include <verify.h>.
850 (struct sortvec.priority, struct sortstr.priority):
8961a454 851 Now EMACS_INT, not int.
c20998a7 852 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
853 (struct sortstr.size, record_overlay_string)
854 (struct sortstrlist.size, struct sortlist.used):
855 Don't truncate size to int.
856 (record_overlay_string): Check for size-calculation overflow.
d6202519 857 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 858
d5a19415
JM
8592011-06-22 Jim Meyering <meyering@redhat.com>
860
029529ac 861 Don't leak an XBM-image-sized buffer
d5a19415
JM
862 * image.c (xbm_load): Free the image buffer after using it.
863
a9041e6c
PE
8642011-06-21 Paul Eggert <eggert@cs.ucla.edu>
865
866 Port to Sun C.
867 * composite.c (find_automatic_composition): Omit needless 'return 0;'
868 that Sun C diagnosed.
869 * fns.c (secure_hash): Fix pointer signedness issue.
870 * intervals.c (static_offset_intervals): New function.
871 (offset_intervals): Use it.
872
7f3f739f
LL
8732011-06-21 Leo Liu <sdl.web@gmail.com>
874
875 * deps.mk (fns.o):
876 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
877 sha512.h.
878
879 * fns.c (secure_hash): Rename from crypto_hash_function and change
880 the first arg to accept symbols.
5b66d427 881 (Fsecure_hash): New primitive.
7f3f739f
LL
882 (syms_of_fns): New symbols.
883
76147d94
DD
8842011-06-20 Deniz Dogan <deniz@dogan.se>
885
886 * process.c (Fset_process_buffer): Clarify return value in
887 docstring.
888
7d7d0045
CY
8892011-06-18 Chong Yidong <cyd@stupidchicken.com>
890
891 * dispnew.c (add_window_display_history): Use BVAR.
892
893 * xdisp.c (debug_method_add): Use BVAR.
894 (check_window_end, dump_glyph_matrix, dump_glyph)
895 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
896
897 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
898 Likewise.
899
900 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
901 check till after the cache is created in init_frame_faces.
902
ff2bc410
SM
9032011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
904
905 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
906
28177add
PE
9072011-06-16 Paul Eggert <eggert@cs.ucla.edu>
908
dd3482fe
PE
909 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
910 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
911 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
912
393d71f3 913 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
914 * fileio.c (Finsert_file_contents):
915 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
916 Remove the old (too-loose) buffer overflow checks.
917 They weren't needed, since make_gap checks for buffer overflow.
918 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
919 The old code merely checked for Emacs fixnum overflow, and relied
920 on undefined (wraparound) behavior. The new code avoids undefined
921 behavior, and also checks for ptrdiff_t and/or size_t overflow.
922
2e6813b0 923 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
924 Tune. Don't use wider integers than needed. Don't use alloca.
925 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 926
599a9e4f
PE
927 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
928
99561444
PE
929 * insdel.c, lisp.h (buffer_overflow): New function.
930 (insert_from_buffer_1, replace_range, replace_range_2):
931 * insdel.c (make_gap_larger):
932 * editfns.c (Finsert_char):
933 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
934
28177add
PE
935 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
936
e69dafad
PE
9372011-06-15 Paul Eggert <eggert@cs.ucla.edu>
938
a7af7fde 939 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 940
b1c46f02
PE
941 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
942 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
943
e69dafad
PE
944 * fileio.c: Don't assume EMACS_INT fits in off_t.
945 (emacs_lseek): New static function.
946 (Finsert_file_contents, Fwrite_region): Use it.
947 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
948
566684ea
PE
949 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
950
e6966cd6
PE
951 * fns.c: Don't overflow int when computing a list length.
952 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
953 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
954 truncation on 64-bit hosts. Check for QUIT every
955 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
956 faster and is responsive enough.
957 (Flength): Report an error instead of overflowing an integer.
958 (Fsafe_length): Return a float if the value is not representable
959 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 960 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 961 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 962
dd0b0efb
PE
963 * alloc.c: Check that resized vectors' lengths fit in fixnums.
964 (header_size, word_size): New constants.
965 (allocate_vectorlike): Don't check size overflow here.
966 (allocate_vector): Check it here instead, since this is the only
967 caller of allocate_vectorlike that could cause overflow.
968 Check that the new vector's length is representable as a fixnum.
969
86fe5cfe
PE
970 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
971 The previous code was bogus. For example, next_almost_prime (32)
972 returned 39, which is undesirable as it is a multiple of 3; and
973 next_almost_prime (24) returned 25, which is a multiple of 5 so
974 why was the code bothering to check for multiples of 7?
975
80e88859
PE
976 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
977
4a2f0ad6
PE
978 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
979
f66c7cf8
PE
980 Variadic C functions now count arguments with ptrdiff_t.
981 This partly undoes my 2011-03-30 change, which replaced int with size_t.
982 Back then I didn't know that the Emacs coding style prefers signed int.
983 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
984 were being counted with int, which may truncate counts on 64-bit
985 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
986 * lisp.h (struct Lisp_Subr.function.aMANY)
987 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
988 Arg counts are now ptrdiff_t, not size_t.
989 All variadic functions and their callers changed accordingly.
990 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
991 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
992 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
993 * callint.c (Fcall_interactively): Check arg count for overflow,
994 to avoid potential buffer overrun. Use signed char, not 'int',
995 for 'varies' array, so that we needn't bother to check its size
996 calculation for overflow.
997 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
998 * eval.c (apply_lambda):
999 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1000 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1001 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1002
a1759b76
PE
1003 * callint.c (Fcall_interactively): Don't use index var as event count.
1004
d96be9fc
PE
1005 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1006 * mem-limits.h (SIZE): Remove; no longer used.
1007
a690a978 1008 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1009
578c21e6
PE
1010 Remove unnecessary casts.
1011 * xterm.c (x_term_init):
1012 * xfns.c (x_set_border_pixel):
1013 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1014 These aren't needed now that we assume ANSI C.
1015
96f53c6c
PE
1016 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1017 It's more likely to cause problems (due to unsigned overflow)
1018 than to cure them.
1019
83c77d31
PE
1020 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1021
ee2079f1
PE
1022 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1023
6da65536
PE
1024 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1025
7147c4a4
PE
1026 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1027
193e32d9
PE
1028 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1029
e5533da6
PE
1030 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1031
9910e595
PE
1032 GLYPH_CODE_FACE returns EMACS_INT, not int.
1033 * dispextern.h (merge_faces):
1034 * xfaces.c (merge_faces):
01103c44
PE
1035 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1036 Don't assume EMACS_INT fits in int.
9910e595 1037
2638320e
PE
1038 * character.h (CHAR_VALID_P): Remove unused parameter.
1039 * fontset.c, lisp.h, xdisp.c: All uses changed.
1040
045eb8d9
PE
1041 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1042
c1f134b5
PE
1043 * fns.c (concat): Minor tuning based on overflow analysis.
1044 This doesn't fix any bugs. Use int to hold character, instead
1045 of constantly refetching from Emacs object. Use XFASTINT, not
1046 XINT, for value known to be a character. Don't bother comparing
1047 a single byte to 0400, as it's always less.
1048
395fcb93 1049 * floatfns.c (Fexpt):
327eeec8
PE
1050 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1051
abbd3d23
PE
1052 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1053 for characters.
1054
684a03ef
PE
1055 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1056
0fed43f3
PE
1057 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1058 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1059 incorrectly succeed when S was a string, because 4294967386 was
1060 truncated before it was used.
1061
8fd02eb7
PE
1062 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1063 Otherwise, an out-of-range integer could cause undefined behavior
1064 on a 64-bit host.
1065
f8c86b69
PE
1066 * composite.c: Use int, not EMACS_INT, for characters.
1067 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1068 EMACS_INT, for values that are known to be in character range.
1069 This doesn't fix any bugs but is the usual style inside Emacs and
1070 may generate better code on 32-bit machines.
1071
34206dd2
PE
1072 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1073 This is for reasons similar to the recent CHAR_STRING fix.
1074 * charset.c (Fencode_char): Check that character arg is actually
1075 a character. Pass an int to ENCODE_CHAR.
1076 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1077 wider than 'int', as a compile-time check to prevent future regressions
1078 in this area.
1079
c5958d4c 1080 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1081
1082 Make sure a 64-bit char is never passed to CHAR_STRING.
1083 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1084 by silently ignoring the top 32 bits, allowing some values
1085 that were far too large to be valid characters.
1086 * character.h: Include <verify.h>.
1087 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1088 arguments are no wider than unsigned, as a compile-time check
1089 to prevent future regressions in this area.
1090 * data.c (Faset):
01103c44 1091 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1092 (Fsubst_char_in_region):
1093 * fns.c (concat):
1094 * xdisp.c (decode_mode_spec_coding):
1095 Adjust to CHAR_STRING's new requirement.
1096 * editfns.c (Finsert_char, Fsubst_char_in_region):
1097 * fns.c (concat): Check that character args are actually
1098 characters. Without this test, these functions did the wrong
1099 thing with wildly out-of-range values on 64-bit hosts.
1100
d37ca623
PE
1101 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1102 These casts should not be needed on 32-bit hosts, either.
1103 * keyboard.c (read_char):
1104 * lread.c (Fload): Remove casts to unsigned.
1105
ea204efb
PE
1106 * lisp.h (UNSIGNED_CMP): New macro.
1107 This fixes comparison bugs on 64-bit hosts.
1108 (ASCII_CHAR_P): Use it.
1109 * casefiddle.c (casify_object):
01103c44 1110 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1111 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1112 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1113 * dispextern.h (FACE_FROM_ID):
1114 * keyboard.c (read_char): Use UNSIGNED_CMP.
1115
41cb286c
PE
1116 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1117 not to EMACS_INT, to avoid GCC warning.
1118
4a1b9832
PE
1119 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1120
55daad71
PE
1121 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1122 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1123 isn't needed on 32-bit machines.
8f95c75c 1124
01103c44
PE
1125 * buffer.c (Fgenerate_new_buffer_name):
1126 Use EMACS_INT for count, not int.
0ceccced 1127 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1128
1129 * data.c (Qcompiled_function): Now static.
1130
c6f072e7
PE
1131 * window.c (window_body_lines): Now static.
1132
20ce5912
PE
1133 * image.c (gif_load): Rename local to avoid shadowing.
1134
9c4c5f81
PE
1135 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1136 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1137 * alloc.c (make_save_value): Integer argument is now of type
1138 ptrdiff_t, not int.
1139 (mark_object): Use ptrdiff_t, not int.
1140 * lisp.h (pD): New macro.
1141 * print.c (print_object): Use it.
1142
c0c5c8ae
PE
1143 * alloc.c: Use EMACS_INT, not int, to count objects.
1144 (total_conses, total_markers, total_symbols, total_vector_size)
1145 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1146 (total_free_floats, total_floats, total_free_intervals)
1147 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1148 Now EMACS_INT, not int. All uses changed.
1149 (Fgarbage_collect): Compute overall total using a double, so that
1150 integer overflow is less likely to be a problem. Check for overflow
1151 when converting back to an integer.
5a25e253
PE
1152 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1153 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1154 These were 'int' variables that could overflow on 64-bit hosts;
1155 they were never used, so remove them instead of repairing them.
211a0b2a 1156 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1157 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1158 Previously, this ceilinged at INT_MAX, but that doesn't work on
1159 64-bit machines.
e46bb31a 1160 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1161
c78baabf 1162 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1163 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1164 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1165 when a (possibly-narrower) signed value would do just as well.
1166 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1167
c9d624c6
PE
1168 * alloc.c: Catch some string size overflows that we were missing.
1169 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1170 for convenience in STRING_BYTES_MAX.
1171 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1172 The definition here is exact; the one in lisp.h was approximate.
1173 (allocate_string_data): Check for string overflow. This catches
1174 some instances we weren't catching before. Also, it catches
1175 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1176 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1177 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1178
c9d624c6
PE
1179 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1180 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1181 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1182
353032ce
PE
1183 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1184
2bccce07
PE
1185 * alloc.c (Fmake_string): Check for out-of-range init.
1186
0ac30604
SM
11872011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1188
1189 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1190
c195f2de
JD
11912011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1192
1193 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1194 xg_get_default_scrollbar_width.
1195
1196 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1197 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1198 (style_changed_cb): Call update_theme_scrollbar_width and call
1199 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1200 all frames (Bug#8505).
1201 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1202 Call gtk_window_set_resizable if HAVE_GTK3.
1203 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1204 and height if HAVE_GTK3 (Bug#8505).
1205 (scroll_bar_width_for_theme): New variable.
1206 (update_theme_scrollbar_width): New function.
1207 (xg_get_default_scrollbar_width): Move code to
1208 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1209 (xg_initialize): Call update_theme_scrollbar_width.
1210
1211 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1212
1213 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1214
e10ac9f1
MR
12152011-06-12 Martin Rudalics <rudalics@gmx.at>
1216
1217 * frame.c (make_frame): Call other_buffer_safely instead of
1218 other_buffer.
1219
1220 * window.c (temp_output_buffer_show): Call display_buffer with
1221 second argument Vtemp_buffer_show_specifiers and reset latter
1222 immediately after the call.
1223 (Vtemp_buffer_show_specifiers): New variable.
1224 (auto_window_vscroll_p, next_screen_context_lines)
1225 (Vscroll_preserve_screen_position): Remove leading asterisks from
1226 doc-strings.
1227
2d3c217e 12282011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1229
7b7f97e8 1230 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1231 * buffer.c (Qclone_number): Remove for now, as it's unused.
1232 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1233 (record_buffer): Remove unused local.
1234 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1235 (set_frame_buffer_list): Remove; unused.
1236 * frame.h (other_visible_frames): Remove decl.
1237 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1238 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1239 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1240 if HAVE_GPM.
1241 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1242 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1243 Define only if HAVE_GPM.
1244 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1245 (update_hints_inhibit): Remove; never set. All uses removed.
1246 * widgetprv.h (emacsFrameClassRec): Remove decl.
1247 * window.c (delete_deletable_window): Now returns void, since it
1248 wasn't returning anything.
1249 (compare_window_configurations): Remove unused locals.
1250 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1251 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1252 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1253 the same widths as pointers. This follows up on the 2011-05-06 patch.
1254 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1255 * xterm.h: Likewise.
1256 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1257
1384b89e
JB
12582011-06-12 Juanma Barranquero <lekktu@gmail.com>
1259
1260 * makefile.w32-in: Update dependencies.
1261 (LISP_H): Add lib/intprops.h.
1262
1100a63c
CY
12632011-06-11 Chong Yidong <cyd@stupidchicken.com>
1264
1265 * image.c (gif_load): Add animation frame delay to the metadata.
1266 (syms_of_image): Use DEFSYM. New symbol `delay'.
1267
6198ccd0
MR
12682011-06-11 Martin Rudalics <rudalics@gmx.at>
1269
1270 * window.c (delete_deletable_window): Re-add.
1271 (Fset_window_configuration): Rewrite to handle dead buffers and
1272 consequently deletable windows.
1273 (window_tree, Fwindow_tree): Remove. Supply functionality in
1274 window.el.
1275 (compare_window_configurations): Simplify code.
1276
b6e3633c
AS
12772011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1278
1ab0dee5
AS
1279 * image.c (imagemagick_load_image): Fix type mismatch.
1280 (Fimagemagick_types): Likewise.
1281
b6e3633c
AS
1282 * window.h (replace_buffer_in_windows): Declare.
1283
9397e56f
MR
12842011-06-11 Martin Rudalics <rudalics@gmx.at>
1285
1286 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1287 Qclone_number. Remove external declaration of Qdelete_window.
1288 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1289 code.
1290 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1291 Qbuffer_list_update_hook if allowed.
1292 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1293 buffer list implementation.
1294 (other_buffer_safely): New function.
1295 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1296 calls to replace_buffer_in_windows and
1297 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1298 if allowed.
1299 (record_buffer): Inhibit quitting and rewrite using quittable
1300 functions. Run Qbuffer_list_update_hook if allowed.
1301 (Frecord_buffer, Funrecord_buffer): New functions.
1302 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1303 switch-to-buffer to window.el.
1304 (bury-buffer): Move to window.el.
1305 (Vbuffer_list_update_hook): New variable.
1306
1307 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1308 section.
1309
1310 * window.h (resize_frame_windows): Move up in code.
1311 (Fwindow_frame): Remove EXFUN.
1312 (replace_buffer_in_all_windows): Remove prototype.
1313 (replace_buffer_in_windows_safely): Add prototype.
1314
1315 * window.c: Declare Qdelete_window static again. Move down
1316 declaration of select_count.
1317 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1318 (Fother_window): Move to window.el.
1319 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1320 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1321 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1322 window.el.
1323 (replace_buffer_in_windows): Implement by calling
1324 Qreplace_buffer_in_windows.
1325 (replace_buffer_in_all_windows): Remove with some functionality
1326 moved into replace_buffer_in_windows_safely.
1327 (replace_buffer_in_windows_safely): New function.
1328 (select_window_norecord, select_frame_norecord): Move in front
1329 of run_window_configuration_change_hook. Remove now obsolete
1330 declarations.
1331 (Fset_window_buffer): Rewrite doc-string. Call
1332 Qrecord_window_buffer.
1333 (keys_of_window): Move binding for other-window to window.el.
1334
b50691aa
CY
13352011-06-11 Chong Yidong <cyd@stupidchicken.com>
1336
1337 * dispextern.h (struct image): Replace data member, whose int_val
1338 and ptr_val fields were not used by anything, with a single
1339 lisp_val object.
1340
1341 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1342 (gif_clear_image, gif_load, imagemagick_load_image)
1343 (gs_clear_image, gs_load): Callers changed.
1344
3f754b86
PE
13452011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1346
cca69397
PE
1347 * buffer.h: Include <time.h>, for time_t.
1348 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1349
109e28d0
PE
1350 Fix minor problems found by static checking.
1351
60737f02
PE
1352 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1353
4b66faf3
PE
1354 Make identifiers static if they are not used in other modules.
1355 * data.c (Qcompiled_function, Qframe, Qvector):
1356 * image.c (QimageMagick, Qsvg):
1357 * minibuf.c (Qmetadata):
1358 * window.c (resize_window_check, resize_root_window): Now static.
1359 * window.h (resize_window_check, resize_root_window): Remove decls.
1360
109e28d0
PE
1361 * window.c (window_deletion_count, delete_deletable_window):
1362 Remove; unused.
46a4ce9e
PE
1363 (window_body_lines): Now static.
1364 (Fdelete_other_windows_internal): Mark vars as initialized.
1365 Make sure 'resize_failed' is initialized.
1366 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1367 (resize_window_apply): Remove unused local.
1368 * window.h (delete_deletable_window): Remove decl.
1369
109e28d0 1370 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1371 (imagemagick_load_image): Fix pointer signedness problem by changing
1372 last arg from unsigned char * to char *. All uses changed.
1373 Also, fix a local for similar reasons.
1374 Remove unused locals. Remove locals to avoid shadowing.
1375 (fn_rsvg_handle_free): Remove; unused.
1376 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1377 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1378
3f754b86
PE
1379 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1380
2547adb1
CY
13812011-06-10 Chong Yidong <cyd@stupidchicken.com>
1382
1383 * image.c (gif_load): Fix omitted cast error introduced by
1384 2011-06-06 change.
1385
2c8e37d4
MR
13862011-06-10 Martin Rudalics <rudalics@gmx.at>
1387
1388 * window.h (resize_proportionally, orig_total_lines)
1389 (orig_top_line): Remove from window structure.
1390 (set_window_height, set_window_width, change_window_heights)
1391 (Fdelete_window): Remove prototypes.
1392 (resize_frame_windows): Remove duplicate declaration.
1393
440a42e3
EZ
13942011-06-10 Eli Zaretskii <eliz@gnu.org>
1395
1396 * window.h (resize_frame_windows, resize_window_check)
1397 (delete_deletable_window, resize_root_window)
1398 (resize_frame_windows): Declare prototypes.
1399
1400 * window.c (resize_window_apply): Make definition be "static" to
1401 match the prototype.
1402
562dd5e9
MR
14032011-06-10 Martin Rudalics <rudalics@gmx.at>
1404
1405 * window.c: Remove declarations of Qwindow_size_fixed,
1406 window_min_size_1, window_min_size_2, window_min_size,
1407 size_window, window_fixed_size_p, enlarge_window, delete_window.
1408 Remove static from declaration of Qdelete_window, it's
1409 temporarily needed by Fbury_buffer.
1410 (replace_window): Don't assign orig_top_line and
1411 orig_total_lines.
1412 (Fdelete_window, delete_window): Remove. Window deletion is
1413 handled by window.el.
1414 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1415 Fdelete_window calls with calls to Qdelete_window.
1416 (Fdelete_other_windows): Remove. Deleting other windows is
1417 handled by window.el.
1418 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1419 handled in window.el.
1420 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1421 Window minimum sizes are handled in window.el.
1422 (shrink_windows, size_window, set_window_height)
1423 (set_window_width, change_window_heights, window_height)
1424 (window_width, CURBEG, CURSIZE, enlarge_window)
1425 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1426 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1427 handled in window.el.
1428 (make_dummy_parent): Rename to make_parent_window and give it a
1429 second argument horflag.
1430 (make_window): Don't set resize_proportionally any more.
1431 (Fsplit_window): Remove. Windows are split in window.el.
1432 (save_restore_action, save_restore_orig_size)
1433 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1434 Resize mini windows in window.el.
1435 (grow_mini_window, shrink_mini_window): Implement by calling
1436 Qresize_root_window_vertically, resize_window_check and
1437 resize_window_apply.
1438 (saved_window, Fset_window_configuration, save_window_save): Do
1439 not handle orig_top_line, orig_total_lines, and
1440 resize_proportionally.
1441 (window_min_height, window_min_width): Move to window.el.
1442 (keys_of_window): Move bindings for delete-other-windows,
1443 split-window, delete-window and enlarge-window to window.el.
1444
1445 * buffer.c: Temporarily extern Qdelete_window.
1446 (Fbury_buffer): Temporarily call Qdelete_window instead of
1447 Fdelete_window (Fbury_buffer will move to window.el soon).
1448
1449 * frame.c (set_menu_bar_lines_1): Remove code handling
1450 orig_top_line and orig_total_lines.
1451
1452 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1453 set_window_height but set heights directly.
1454 (change_frame_size_1): Use resize_frame_windows.
1455
1456 * xdisp.c (init_xdisp): Don't use set_window_height but set
1457 heights directly.
1458
1459 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1460 resize_frame_windows instead of change_window_heights and run
1461 run_window_configuration_change_hook.
1462
1463 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1464 instead of change_window_heights and run
1465 run_window_configuration_change_hook.
1466
1a13852e
MR
14672011-06-09 Martin Rudalics <rudalics@gmx.at>
1468
1469 * window.c (replace_window): Rename second argument REPLACEMENT to
1470 NEW. New third argument SETFLAG. Rewrite.
1471 (delete_window, make_dummy_parent): Call replace_window with
1472 third argument 1.
1473 (window_list_1): Move down in code.
1474 (run_window_configuration_change_hook): Move set_buffer part
1475 before select_frame_norecord part in order to unwind correctly.
1476 Rename count1 to count.
1477 (recombine_windows, delete_deletable_window, resize_root_window)
1478 (Fdelete_other_windows_internal)
1479 (Frun_window_configuration_change_hook, make_parent_window)
1480 (resize_window_check, resize_window_apply, Fresize_window_apply)
1481 (resize_frame_windows, Fsplit_window_internal)
1482 (Fdelete_window_internal, Fresize_mini_window_internal): New
1483 functions.
1484 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1485
f3d1777e
MR
14862011-06-08 Martin Rudalics <rudalics@gmx.at>
1487
496e208e
MR
1488 * window.h (window): Add some new members to window structure -
1489 normal_lines, normal_cols, new_total, new_normal, clone_number,
1490 splits, nest, prev_buffers, next_buffers.
1491 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1492 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1493
f3d1777e
MR
1494 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1495 Remove.
496e208e
MR
1496 (make_dummy_parent): Set new members of windows structure.
1497 (make_window): Move down in code. Handle new members of window
1498 structure.
1499 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1500 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1501 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1502 (Fset_window_prev_buffers, Fwindow_next_buffers)
1503 (Fset_window_next_buffers, Fset_window_clone_number): New
1504 functions.
1505 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1506 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1507 Doc-string fixes.
1508 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1509 Argument WINDOW can be now internal window too.
1510 (Fwindow_use_time): Move up in code.
1511 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1512 Rewrite doc-string.
1513 (Fset_window_configuration, saved_window)
1514 (Fcurrent_window_configuration, save_window_save): Handle new
1515 members of window structure.
b9e809c2
MR
1516 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1517 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1518 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1519 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1520 Qget_mru_window, Qresize_root_window,
1521 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1522 Qauto_buffer_name; staticpro them.
f3d1777e 1523
abde8f8c
MR
15242011-06-07 Martin Rudalics <rudalics@gmx.at>
1525
1526 * window.c (Fwindow_total_size, Fwindow_left_column)
1527 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1528 (Fwindow_list_1): New functions.
1529 (window_box_text_cols): Replace with window_body_cols.
1530 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1531 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1532 (delete_window, Fset_window_configuration): Call
1533 delete_all_subwindows with window as argument.
1534 (delete_all_subwindows): Take a window as argument and not a
1535 structure. Rewrite.
190b47e6
MR
1536 (window_loop): Remove handling of GET_LRU_WINDOW and
1537 GET_LARGEST_WINDOW.
1538 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1539
1540 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1541 window_box_text_cols. delete_all_subwindows now takes a
1542 Lisp_Object as argument.
abde8f8c
MR
1543
1544 * indent.c (compute_motion, Fcompute_motion): Use
1545 window_body_cols instead of window_box_text_cols.
1546
fa8a67e6
MR
1547 * frame.c (delete_frame): Call delete_all_subwindows with root
1548 window as argument.
1549
a54e3482
DC
15502011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1551
1552 * fns.c (Fputhash): Document return value.
1553
60002bf5
CY
15542011-06-06 Chong Yidong <cyd@stupidchicken.com>
1555
1556 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1557
0c671da6 15582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1559
b862a52a 1560 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1561
be44ca6c
PE
1562 Check for overflow when converting integer to cons and back.
1563 * charset.c (Fdefine_charset_internal, Fdecode_char):
1564 Use cons_to_unsigned to catch overflow.
1565 (Fencode_char): Use INTEGER_TO_CONS.
1566 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1567 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1568 * data.c (long_to_cons, cons_to_long): Remove.
1569 (cons_to_unsigned, cons_to_signed): New functions.
1570 These signal an error for invalid or out-of-range values.
1571 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1572 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1573 * font.c (Ffont_variation_glyphs):
1574 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1575 * lisp.h: Include <intprops.h>.
1576 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1577 (cons_to_signed, cons_to_unsigned): New decls.
1578 (long_to_cons, cons_to_long): Remove decls.
1579 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1580 (Fprimitive_undo): Use CONS_TO_INTEGER.
1581 * xfns.c (Fx_window_property): Likewise.
1582 * xselect.c: Include <limits.h>.
1583 (x_own_selection, selection_data_to_lisp_data):
1584 Use INTEGER_TO_CONS.
1585 (x_handle_selection_request, x_handle_selection_clear)
1586 (x_get_foreign_selection, Fx_disown_selection_internal)
1587 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1588 (lisp_data_to_selection_data): Use cons_to_unsigned.
1589 (x_fill_property_data): Use cons_to_signed.
1590 Report values out of range.
1591
d1f3d2af
PE
1592 Check for buffer and string overflow more precisely.
1593 * buffer.h (BUF_BYTES_MAX): New macro.
1594 * lisp.h (STRING_BYTES_MAX): New macro.
1595 * alloc.c (Fmake_string):
1596 * character.c (string_escape_byte8):
1597 * coding.c (coding_alloc_by_realloc):
1598 * doprnt.c (doprnt):
1599 * editfns.c (Fformat):
1600 * eval.c (verror):
1601 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1602 since they may not be the same number.
1603 * editfns.c (Finsert_char):
1604 * fileio.c (Finsert_file_contents):
1605 Likewise for BUF_BYTES_MAX.
1606
dd52fcea
PE
1607 * image.c: Use ptrdiff_t, not int, for sizes.
1608 (slurp_file): Switch from int to ptrdiff_t.
1609 All uses changed.
1610 (slurp_file): Check that file size fits in both size_t (for
1611 malloc) and ptrdiff_t (for sanity and safety).
1612
7f9bbdbb
PE
1613 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1614 if b->modtime has its maximal value.
1615
dfe18f82
PE
1616 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1617
84acfcf0
PE
1618 Don't assume time_t can fit into int.
1619 * buffer.h (struct buffer.modtime): Now time_t, not int.
1620 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1621 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1622
ccd9a01a
PE
1623 Minor fixes for signed vs unsigned integers.
1624 * character.h (MAYBE_UNIFY_CHAR):
1625 * charset.c (maybe_unify_char):
1626 * keyboard.c (read_char, reorder_modifiers):
1627 XINT -> XFASTINT, since the integer must be nonnegative.
1628 * ftfont.c (ftfont_spec_pattern):
1629 * keymap.c (access_keymap, silly_event_symbol_error):
1630 XUINT -> XFASTINT, since the integer must be nonnegative.
1631 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1632 since it makes no difference and we prefer signed.
1633 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1634 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1635 nonnegative.
1636
d6d100dd
SM
16372011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1638
1639 * window.h (Fwindow_frame): Declare.
1640
2b6148e4
PE
16412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1644 (SPARE_MEMORY): Always define.
1645 (LARGE_REQUEST): Remove.
1646 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1647
f230ecc9
MR
16482011-06-06 Martin Rudalics <rudalics@gmx.at>
1649
727e958e
MR
1650 * lisp.h: Move EXFUNS for Fframe_root_window,
1651 Fframe_first_window and Fset_frame_selected_window to window.h.
1652
1653 * window.h: Move EXFUNS for Fframe_root_window,
1654 Fframe_first_window and Fset_frame_selected_window here from
1655 lisp.h.
1656
1657 * frame.c (Fwindow_frame, Fframe_first_window)
1658 (Fframe_root_window, Fframe_selected_window)
1659 (Fset_frame_selected_window): Move to window.c.
1660 (Factive_minibuffer_window): Move to minibuf.c.
1661 (Fother_visible_frames_p): New function.
1662
1663 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1664
f230ecc9
MR
1665 * window.c (decode_window, decode_any_window): Move up in code.
1666 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1667 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1668 (Fwindow_buffer): Move up and rewrite doc-string.
1669 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1670 (Fwindow_prev): New functions.
727e958e
MR
1671 (Fwindow_frame): Move here from frame.c. Accept any window as
1672 argument.
1673 (Fframe_root_window, Fframe_first_window)
1674 (Fframe_selected_window): Move here from frame.c. Accept frame
1675 or arbitrary window as argument. Update doc-strings.
1676 (Fminibuffer_window): Move up in code.
1677 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1678 (Fset_frame_selected_window): Move here from frame.c.
1679 Marginal rewrite.
727e958e
MR
1680 (Fselected_window, select_window, Fselect_window): Move up in
1681 code. Minor doc-string fixes.
f230ecc9 1682
4d09bcf6
PE
16832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1686 Do not assume that spare memory exists; that assumption is valid
1687 only if SYSTEM_MALLOC.
1688 (LARGE_REQUEST): New macro, so that the issue of large requests
1689 is separated from the issue of spare memory.
1690
810928a2
AS
16912011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1692
172418ad
AS
1693 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1694 format. (Bug#8806)
1695
43f862f7
AS
1696 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1697
810928a2
AS
1698 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1699 before statements.
1700
a059fe24
JD
17012011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1702
1703 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1704
1705 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1706
1707 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1708 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1709
989bf368
JB
17102011-06-05 Juanma Barranquero <lekktu@gmail.com>
1711
1712 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1713
4b80f674
CY
17142011-06-04 Chong Yidong <cyd@stupidchicken.com>
1715
1716 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1717 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1718 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1719 New error handlers.
4b80f674
CY
1720 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1721 Obey Vx_select_enable_clipboard_manager. Catch errors in
1722 x_clipboard_manager_save (Bug#8779).
1723 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1724 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1725
99a33b77 17262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1727
1728 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1729
99a33b77 17302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1731
1732 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1733 in the current matrix if keep_current_p is non-zero.
1734
8264569d
EZ
17352011-06-04 Eli Zaretskii <eliz@gnu.org>
1736
1737 * bidi.c (bidi_level_of_next_char): Fix last change.
1738
57f97249
EZ
17392011-06-03 Eli Zaretskii <eliz@gnu.org>
1740
fec2107c 1741 Support bidi reordering of text covered by display properties.
57f97249 1742
fec2107c
EZ
1743 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1744 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1745 (bidi_cache_search, bidi_cache_iterator_state)
1746 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1747 (bidi_level_of_next_char, bidi_move_to_visually_next):
1748 Support character positions inside a run of characters covered by a
fec2107c
EZ
1749 display string.
1750 (bidi_paragraph_init, bidi_resolve_explicit_1)
1751 (bidi_level_of_next_char): Call bidi_fetch_char and
1752 bidi_fetch_char_advance instead of FETCH_CHAR and
1753 FETCH_CHAR_ADVANCE.
1754 (bidi_init_it): Initialize new members.
1755 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1756 definitions.
1757 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1758 instead of using explicit *_CHAR codes.
d6d100dd
SM
1759 (bidi_resolve_explicit, bidi_resolve_weak):
1760 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1761 bidirectional text is supported only in multibyte buffers.
1762 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1763 it to initialize the frame_window_p member of struct bidi_it.
1764 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1765 (bidi_resolve_explicit, bidi_resolve_weak)
1766 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1767 bidi_it->nchars is non-positive.
1768 (bidi_level_of_next_char): Don't try to lookup the cache for the
1769 next/previous character if nothing is cached there yet, or if we
1770 were just reseat()'ed to a new position.
c40e2fb2 1771
0e14fe90
EZ
1772 * xdisp.c (set_cursor_from_row): Set start and stop points
1773 according to the row's direction when priming the loop that looks
1774 for the glyph on which to display cursor.
1775 (single_display_spec_intangible_p): Function deleted.
1776 (display_prop_intangible_p): Reimplement to call
1777 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1778 Accept 3 additional arguments needed by handle_display_spec.
1779 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1780 values: lists, `(when COND...)' forms, etc.
1781 (single_display_spec_string_p): Support property values that are
1782 lists with the argument STRING its top-level element.
1783 (display_prop_string_p): Fix the condition for processing a
1784 property that is a list to be consistent with handle_display_spec.
fec2107c 1785 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1786 last portion of handle_display_prop.
1787 (compute_display_string_pos): Accept additional argument
1788 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1789 value of a `display' property is a "replacing spec".
1790 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1791 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1792 the display property, but just return a value indicating whether
1793 the display property will replace the characters it covers.
1794 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1795 frame_window_p members of struct bidi_it.
d6d100dd
SM
1796 (compute_display_string_pos, compute_display_string_end):
1797 New functions.
fec2107c
EZ
1798 (push_it): Accept second argument POSITION, where pop_it should
1799 jump to continue iteration.
1800 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1801
fec2107c
EZ
1802 * keyboard.c (adjust_point_for_property): Adjust the call to
1803 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1804
1805 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1806 (bidi_init_it): Update prototypes.
1807 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1808 (compute_display_string_pos, compute_display_string_end):
1809 Declare prototypes.
fec2107c
EZ
1810 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1811 EMACS_INT.
fc6f18ce 1812
40087514 18132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1814
57f53182
PE
1815 Malloc failure behavior now depends on size of allocation.
1816 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1817 * lisp.h: Change signatures accordingly.
1818 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1819 All callers changed. (Bug#8762)
1820
1821 * gnutls.c: Use Emacs's memory allocators.
1822 Without this change, the gnutls library would invoke malloc etc.
1823 directly, which causes problems on non-SYNC_INPUT hosts, and which
1824 runs afoul of improving memory_full behavior. (Bug#8761)
1825 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1826 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1827 xfree instead of the default malloc, realloc, free.
1828 (Fgnutls_boot): No need to check for memory allocation failure,
1829 since xmalloc does that for us.
1830
ac32cd99 1831 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1832 * category.c (hash_get_category_set):
1833 * ccl.c (ccl_driver):
1834 * charset.c (Fdefine_charset_internal):
1835 * charset.h (struct charset.hash_index):
1836 * composite.c (get_composition_id, gstring_lookup_cache)
1837 (composition_gstring_put_cache):
1838 * composite.h (struct composition.hash_index):
1839 * dispextern.h (struct image.hash):
1840 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1841 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1842 (hashfn_equal, hashfn_user_defined, make_hash_table)
1843 (maybe_resize_hash_table, hash_lookup, hash_put)
1844 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1845 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1846 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1847 * image.c (make_image, search_image_cache, lookup_image)
1848 (xpm_put_color_table_h):
1849 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1850 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1851 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1852 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1853 * alloc.c (allocate_vectorlike):
1854 Check for overflow in vector size calculations.
1855 * ccl.c (ccl_driver):
1856 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1857 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1858 need to be updated by these changes.
40087514
PE
1859 * fns.c (make_hash_table, maybe_resize_hash_table):
1860 Check for integer overflow with large hash tables.
0de4bb68
PE
1861 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1862 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1863 (SXHASH_REDUCE): New macro.
1864 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1865 Use it instead of discarding useful hash info with large hash values.
1866 (sxhash_float): New function.
1867 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1868 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1869 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1870 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1871 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1872 Adjust signatures to match updated version of code.
1873 (consing_since_gc): Now EMACS_INT, since a single hash table can
1874 use more than INT_MAX bytes.
1875
698d32e2
DN
18762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1877
1878 Make it possible to build with GCC-4.6+ -O2 -flto.
1879
1880 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1881
fd6fa53f
SM
18822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1883
1884 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1885 Call minibuffer-inactive-mode.
1886
864db017
JB
18872011-05-31 Juanma Barranquero <lekktu@gmail.com>
1888
1889 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1890 Update dependencies.
1891
2ad0baf4
DN
18922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1893
1894 * data.c (init_data): Remove code for UTS, this system is not
1895 supported anymore.
1896
4fcc2638
DN
18972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1898
1899 Don't force ./temacs to start in terminal mode.
1900
1901 * frame.c (make_initial_frame): Initialize faces in all cases, not
1902 only when CANNOT_DUMP is defined.
1903 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1904
c56e0fd5
DN
19052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1906
1907 * dispnew.c (add_window_display_history): Use const for the string
1908 pointer. Remove declaration, not needed.
1909
333d54da 19102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1911
55d4c1b2 1912 Use 'inline', not 'INLINE'.
333d54da 1913 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1914 * alloc.c, fontset.c (INLINE): Remove.
1915 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1916 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1917 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1918 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1919 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1920
738db178
DN
19212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1922
1923 Make it possible to run ./temacs.
1924
1925 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1926 syms_of_callproc does the same thing. Remove test for
1927 "initialized", do it in the caller.
1928 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1929
620c53a6
SM
19302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1931
1932 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1933 (read_minibuf): Use get_minibuffer.
1934 (syms_of_minibuf): Use DEFSYM.
1935 (Qmetadata): New var.
1936 * data.c (Qbuffer): Don't make it static.
1937 (syms_of_data): Use DEFSYM.
1938
e003a292
PE
19392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1940
1941 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1942 (CCL_CODE_MIN): New macro.
1943
ed008a6d
PE
19442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1945
3687c2ef
PE
1946 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1947
ed008a6d
PE
1948 * eval.c (Qdebug): Now static.
1949 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1950 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1951 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1952
d66c4c7c
CY
19532011-05-29 Chong Yidong <cyd@stupidchicken.com>
1954
1955 * image.c: Various fixes to ImageMagick code comments.
1956 (Fimagemagick_types): Doc fix.
1957
5fbc2025
PE
19582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1959
0196f88a
PE
1960 Minor fixes prompted by GCC 4.6.0 warnings.
1961
1962 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1963
5fbc2025
PE
1964 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1965 (x_clipboard_manager_save_all): Move extern decl to ...
1966 * xterm.h: ... here, so that it can be checked for consistency.
1967
1dd3c2d9
CY
19682011-05-29 Chong Yidong <cyd@stupidchicken.com>
1969
1970 * xselect.c (x_clipboard_manager_save_frame)
1971 (x_clipboard_manager_save_all): New functions.
1972 (Fx_clipboard_manager_save): Lisp function deleted.
1973
1974 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1975 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1976
1977 * xterm.h: Update prototype.
1978
5ba6571d
WX
19792011-05-28 William Xu <william.xwl@gmail.com>
1980
1981 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1982 exiting (Bug#8239).
1983
3eaff834
JM
19842011-05-28 Jim Meyering <meyering@redhat.com>
1985
e1900994 1986 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1987 * fns.c (to_uchar): Define.
1988 (crypto_hash_function): Use it to convert some newly-signed
1989 variables to unsigned, to avoid sign-extension bugs. For example,
1990 without this change, (md5 "truc") would evaluate to
1991 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1992 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1993 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1994
0f6990a7
PE
19952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 Integer overflow fixes.
c8a9ca5a 1998
08686060
PE
1999 * dbusbind.c: Serial number integer overflow fixes.
2000 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2001 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2002 to hold a serial number that is too large for a fixnum.
2003 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2004 Check for serial numbers out of range. Decode any serial number
59568bf0 2005 that was so large that it became a float. (Bug#8722)
08686060 2006
2d1fc3c7
PE
2007 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2008 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2009 Use XFASTINT rather than XUINT when numbers are nonnegative.
2010 (xd_append_arg, Fdbus_method_return_internal):
2011 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2012 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2013 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2014 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2015 (Bug#8722)
2d1fc3c7 2016
c8a9ca5a
PE
2017 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2018
519e1d69
PE
2019 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2020
30569699
PE
2021 ccl: add integer overflow checks
2022 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2023 (IN_INT_RANGE): New macros.
2024 (ccl_driver): Use them to check for integer overflow when
2025 decoding a CCL program. Many of the new checks are whether XINT (x)
2026 fits in int; it doesn't always, on 64-bit hosts. The new version
2027 doesn't catch all possible integer overflows, but it's an
847044ea 2028 improvement. (Bug#8719)
30569699 2029
c11285dc
PE
2030 * alloc.c (make_event_array): Use XINT, not XUINT.
2031 There's no need for unsigned here.
2032
fdccd48e
PE
2033 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2034 This follows up to the 2011-05-06 change that substituted uintptr_t
2035 for EMACS_INT. This case wasn't caught back then.
2036
37910ab2
PE
2037 Rework Fformat to avoid integer overflow issues.
2038 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2039 now (part of C89). Include <verify.h>.
2040 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2041 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2042 (Fformat): Avoid the prepass trying to compute sizes; it was only
2043 approximate and thus did not catch overflow reliably. Instead, walk
2044 through the format just once, formatting and computing sizes as we go,
2045 checking for integer overflow at every step, and allocating a larger
2046 buffer as needed. Keep track separately whether the format is
2047 multibyte. Keep only the most-recently calculated precision, rather
2048 than them all. Record whether each argument has been converted to
2049 string. Use EMACS_INT, not int, for byte and char and arg counts.
2050 Support field widths and precisions larger than INT_MAX. Avoid
2051 sprintf's undefined behavior with conversion specifications such as %#d
2052 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2053 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2054 formatting out-of-range floating point numbers with int
9173deec 2055 formats. (Bug#8668)
37910ab2 2056
2e6578fb
PE
2057 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2058
0ae6bdee
PE
2059 * data.c: Avoid integer truncation in expressions involving floats.
2060 * data.c: Include <intprops.h>.
2061 (arith_driver): When there's an integer overflow in an expression
2062 involving floating point, convert the integers to floating point
2063 so that the resulting value does not suffer from catastrophic
2064 integer truncation. For example, on a 64-bit host (* 4
2065 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2066 Do not rely on undefined behavior after integer overflow.
2067
de883a70
PE
2068 merge count_size_as_multibyte, parse_str_to_multibyte
2069 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2070 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2071 Check for integer overflow.
2072 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2073 since it's now a duplicate of the other. This is more of
2074 a character than a buffer op, so better that it's in character.c.
2075 * fns.c, print.c: Adjust to above changes.
2076
2ff916cb
PE
20772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2078
2079 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2080
f1b54466
PE
20812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2082
fb1ac845
PE
2083 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2084 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2085 (x_clipboard_manager_save): Now static.
2086 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2087
f1b54466
PE
2088 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2089 (crypto_hash_function): Now static.
2090 Fix pointer signedness problems. Avoid unnecessary initializations.
2091
a9f737ee
CY
20922011-05-27 Chong Yidong <cyd@stupidchicken.com>
2093
2094 * termhooks.h (Vselection_alist): Make it terminal-local.
2095
2096 * terminal.c (create_terminal): Initialize it.
2097
2098 * xselect.c: Support for clipboard managers.
2099 (Vselection_alist): Move to termhooks.h as terminal-local var.
2100 (LOCAL_SELECTION): New macro.
2101 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2102 (symbol_to_x_atom): Remove gratuitous arg.
2103 (x_handle_selection_request, lisp_data_to_selection_data)
2104 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2105 (x_own_selection, x_get_local_selection, x_convert_selection):
2106 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2107 (some_frame_on_display): Delete unused function.
2108 (Fx_own_selection_internal, Fx_get_selection_internal)
2109 (Fx_disown_selection_internal, Fx_selection_owner_p)
2110 (Fx_selection_exists_p): New optional frame arg.
2111 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2112 (x_handle_selection_clear): Don't treat other terminals with the
2113 same keyboard specially. Use the terminal-local Vselection_alist.
2114 (x_clear_frame_selections): Use Frun_hook_with_args.
2115
2116 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2117
2118 * xterm.h: Add support for those atoms.
2119
e067f0c1
CY
21202011-05-26 Chong Yidong <cyd@stupidchicken.com>
2121
2122 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2123 (converted_selections, conversion_fail_tag): New global variables.
2124 (x_selection_request_lisp_error): Free the above.
2125 (x_get_local_selection): Remove unnecessary code.
2126 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2127 of converted selections stored in converted_selections.
2128 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2129 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2130 (x_convert_selection): New function.
2131 (x_handle_selection_event): Simplify.
2132 (x_get_foreign_selection): Don't ignore incoming requests while
2133 waiting for an answer; this will fail when we implement
2134 SAVE_TARGETS, and seems unnecessary anyway.
2135 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2136 (Vx_sent_selection_functions): Doc fix.
2137
0f4aebc0
LL
21382011-05-26 Leo Liu <sdl.web@gmail.com>
2139
2140 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2141
e61124cd
YM
21422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2143
2144 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2145
2146 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2147 for fringe update if it has periodic bitmap.
2148 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2149 and fringe_bitmap_periodic_p.
2150
2151 * fringe.c (get_fringe_bitmap_data): New function.
2152 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2153 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2154 row. Mark glyph row for fringe update if periodicity changed.
2155
2156 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2157 for fringe update unless it has periodic bitmap.
2158
f16d9837
KH
21592011-05-25 Kenichi Handa <handa@m17n.org>
2160
2161 * xdisp.c (get_next_display_element): Set correct it->face_id for
2162 a static composition.
2163
e1b90ef6
LL
21642011-05-24 Leo Liu <sdl.web@gmail.com>
2165
2166 * deps.mk (fns.o):
2167 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2168
2169 * fns.c (crypto_hash_function, Fsha1): New function.
2170 (Fmd5): Use crypto_hash_function.
2171 (syms_of_fns): Add Ssha1.
2172
7400048f
PE
21732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2174
2175 * gnutls.c: Remove unused macros.
2176 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2177 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2178 Remove macros that are defined and never used.
2179 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2180
abb71cf4
CY
21812011-05-22 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2184 (Fx_get_selection_internal): Minor cleanup.
2185 (Fx_own_selection_internal): Rename arguments for consistency with
2186 select.el.
2187
6307db39
PE
21882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2191
f3d4e0a4
CY
21922011-05-22 Chong Yidong <cyd@stupidchicken.com>
2193
2194 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2195
4d8ade89
YM
21962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2197
2198 * dispnew.c (scrolling_window): Don't exclude the case that the
2199 last enabled row in the desired matrix touches the bottom boundary.
2200
32078c8d
GM
22012011-05-21 Glenn Morris <rgm@gnu.org>
2202
2203 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2204 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2205 and add some more files.
32078c8d 2206
7285dc67
EZ
22072011-05-20 Eli Zaretskii <eliz@gnu.org>
2208
2209 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2210 report_file_error introduced by the change from 2011-05-07.
2211
89d1bd22
PE
22122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 * systime.h (Time): Define only if emacs is defined.
2215 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2216 where the include path doesn't have X11/X.h by default. See
2217 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2218
e23640bb 22192011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2220
2221 * composite.c (find_automatic_composition): Fix previous change.
2222
b9704ad9
GM
22232011-05-20 Glenn Morris <rgm@gnu.org>
2224
2225 * lisp.mk: New file, split from Makefile.in.
2226 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2227 (shortlisp): Remove.
2228 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2229
4a720484
GM
22302011-05-19 Glenn Morris <rgm@gnu.org>
2231
2232 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2233 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2234 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2235 (lisp): Set the order to that of loadup.el.
2236 (shortlisp): Make it a copy of $lisp.
2237 (SOME_MACHINE_LISP): Remove.
2238 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2239 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2240
a28d4396
KH
22412011-05-18 Kenichi Handa <handa@m17n.org>
2242
2243 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2244 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2245 (find_automatic_composition): Mostly rewrite for efficiency.
2246
a2b1fa8e
JB
22472011-05-18 Juanma Barranquero <lekktu@gmail.com>
2248
2249 * makefile.w32-in: Update dependencies.
2250
8e1f5610
CS
22512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2252
2253 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2254 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2255
7025ee00 22562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2257
cdfa6eab
PE
2258 Fix some integer overflow issues, such as string length overflow.
2259
06d6db33
PE
2260 * insdel.c (count_size_as_multibyte): Check for string overflow.
2261
2b4560a8
PE
2262 * character.c (lisp_string_width): Check for string overflow.
2263 Use EMACS_INT, not int, for string indexes and lengths; in
2264 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2265 the resulting string length overflows an EMACS_INT; instead,
2266 report a string overflow if no precision given. When checking for
2267 precision exhaustion, use a check that cannot possibly have
2268 integer overflow. (Bug#8675)
2269 * character.h (lisp_string_width): Adjust to new signature.
2270
cb93f9be
PE
2271 * alloc.c (string_overflow): New function.
2272 (Fmake_string): Use it. This doesn't change behavior, but saves
2273 a few bytes and will simplify future changes.
2274 * character.c (string_escape_byte8): Likewise.
2275 * lisp.h (string_overflow): New decl.
2276
1a1f3366
PE
2277 Fixups, following up to the user-interface timestamp change.
2278 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2279 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2280 * msdos.c (mouse_get_pos): Likewise.
2281 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2282 * w32gui.h (Time): Define by including "systime.h" rather than by
2283 declaring it ourselves. (Bug#8664)
2284
d4e3e4d3
PE
2285 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2286 * image.c (clear_image_cache): Likewise.
2287
f6a24d19
PE
2288 * term.c (term_mouse_position): Don't assume time_t wraparound.
2289
08dc5ae6
PE
2290 Be more systematic about user-interface timestamps.
2291 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2292 and sometimes 'EMACS_UINT', to represent these timestamps.
2293 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2294 This makes the code easier to follow, and makes it easier to catch
2295 integer overflow bugs such as Bug#8664.
2296 * frame.c (Fmouse_position, Fmouse_pixel_position):
2297 Use Time, not unsigned long, for user-interface timestamps.
2298 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2299 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2300 * keyboard.h (last_event_timestamp): Likewise.
2301 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2302 * menu.h (xmenu_show): Likewise.
2303 * term.c (term_mouse_position): Likewise.
2304 * termhooks.h (struct input_event.timestamp): Likewise.
2305 (struct terminal.mouse_position_hook): Likewise.
2306 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2307 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2308 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2309 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2310 what it was before.
2311 * menu.h, termhooks.h: Include "systime.h", for Time.
2312
8e55734a
PE
2313 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2314 Don't assume that the difference between two unsigned long values
2315 can fit into an integer. At this point, we know button_down_time
2316 <= event->timestamp, so the difference must be nonnegative, so
2317 there's no need to cast the result if double-click-time is
2318 nonnegative, as it should be; check that it's nonnegative, just in
2319 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2320 apart (about 25 days). (Bug#8664)
8e55734a 2321
841f1b75 2322 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2323 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2324
3e26f69c
PE
2325 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2326 that always fit in int. Use a sentinel instead of a counter, to
2327 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2328 * frame.h (struct frame): Use int for menu_bar_items_used
2329 instead of EMACS_INT, since it always fits in int.
3e26f69c 2330
5cc152c0
PE
2331 * menu.c (grow_menu_items): Check for int overflow.
2332
d89eb65e
PE
2333 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2334
5235bd3e
PE
2335 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2336 Before, the code was not consistent. These values cannot exceed
2337 2**31 - 1 so there's no need to make them unsigned.
2338 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2339 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2340 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2341 as modifiers.
2342 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2343
bc827e23
PE
2344 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2345 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2346 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2347 presumably because the widths might not match.
2348
78eb494e
PE
2349 * window.c (size_window): Avoid needless test at loop start.
2350
04f2d78b
CB
23512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2352
2353 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2354
d2fc7e3d 23552011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2356
2357 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2358
d2fc7e3d 23592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2360
2361 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2362 `width' to `bar_area_x' and `bar_area_width', respectively.
2363 (x_scroll_run): Take account of fringe background extension.
2364
04f2d78b
CB
2365 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2366 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2367 `bar_area_width', respectively.
2368 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2369 background extension.
2370
79b70037
GM
23712011-05-10 Jim Meyering <meyering@redhat.com>
2372
2373 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2374
2f142cc5
JB
23752011-05-10 Juanma Barranquero <lekktu@gmail.com>
2376
2377 * image.c (Finit_image_library): Return t for built-in image types,
2378 like pbm and xbm. (Bug#8640)
2379
57679c86
AS
23802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2381
2382 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2383
888c9e86
EZ
23842011-05-07 Eli Zaretskii <eliz@gnu.org>
2385
b0512a1d
EZ
2386 * w32console.c (Fset_screen_color): Doc fix.
2387 (Fget_screen_color): New function.
2388 (syms_of_ntterm): Defsubr it.
2389
7285dc67
EZ
2390 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2391 unlink the temporary file if Fcall_process didn't create it in the
2392 first place.
2393 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2394 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2395 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2396 cue to call_process_cleanup not to close that handle.
2397
4d3fcc8e
BK
23982011-05-07 Ben Key <bkey76@gmail.com>
2399
2400 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2401 one of two shell specific rules, either bootstrap-temacs-CMD or
2402 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2403 to the previous implementation of the bootstrap-temacs rule.
2404 The bootstrap-temacs-CMD rule is similar to the previous
2405 implementation of the bootstrap-temacs rule except that it
2406 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2407 variable.
2408
2409 These changes, along with some changes to nt/configure.bat,
2410 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2411 earlier fix to add support for --cflags and --ldflags options
2412 that include quotes so that it works whether make uses cmd or
2413 sh as the shell.
2414
b4289b64
MA
24152011-05-06 Michael Albinus <michael.albinus@gmx.de>
2416
2417 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2418 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2419 is a constant.
2420 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2421 a string. Handle both cases.
2422 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2423 (Fdbus_register_method): Use Qinvalid_function.
2424
af4c0e28
JB
24252011-05-06 Juanma Barranquero <lekktu@gmail.com>
2426
2427 * makefile.w32-in: Update dependencies.
2428 (LISP_H): Add inttypes.h and stdin.h.
2429 (PROCESS_H): Add unistd.h.
2430
c51453d9
EZ
24312011-05-06 Eli Zaretskii <eliz@gnu.org>
2432
2433 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2434 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2435
8ff0ac3c 24362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2437
4c4b566b
PE
2438 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2439
aab2b9b5
PE
2440 * term.c (vfatal): Remove stray call to va_end.
2441 It's not needed and the C Standard doesn't allow it here anyway.
2442
c378da0b
PE
2443 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2444 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2445
288b08c7
PE
2446 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2447 bytes.
2448
e3601888
PE
2449 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2450
db6c0e74
PE
2451 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2452
dd5963ea
PE
2453 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2454
88c9450f
PE
2455 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2456
2f9442b8
PE
2457 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2458
c032b5f8
PE
2459 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2460 * charset.c (Fdefine_charset_internal): Don't initialize
2461 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2462 32-bit int (Bug#8600).
a108c10b
PE
2463
2464 * lread.c (read_integer): Be more consistent with string-to-number.
2465 Use string_to_number to do the actual conversion; this avoids
2466 rounding errors and fixes some other screwups. Without this fix,
2467 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2468 (digit_to_number): Move earlier, for benefit of read_integer.
2469 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2470 not a digit in any supported base. (Bug#8602)
a108c10b 2471
ad5f9eea
PE
2472 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2473
aec1708a
PE
2474 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2475 to match comment at start of function. This also removes a
2476 GCC warning about overflow in a 32+64-bit port.
2477
47be4ab5
PE
2478 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2479
371cac43
PE
2480 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2481 Reported by Stefan Monnier in
2482 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2483 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2484 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2485
d01a7826
PE
2486 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2487 (EMACS_UINTPTR): Likewise, with uintptr_t.
2488
7fd47d5c
PE
2489 * lisp.h: Prefer 64-bit EMACS_INT if available.
2490 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2491 on 32-bit hosts that have 64-bit int, so that they can access
2492 large files.
122b0c86
PE
2493 However, temporarily disable this change unless the temporary
2494 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2495
8727937b
PE
2496 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2497
8ac068ac
PE
2498 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2499 This removes an assumption that EMACS_INT and long are the same
2500 width as pointers. The assumption is true for Emacs porting targets
2501 now, but we want to make other targets possible.
2502 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2503 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2504 In the rest of the code, change types of integers that hold casted
2505 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2506 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2507 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2508 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2509 No need to cast type when ORing.
2510 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2511 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2512 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2513 assume EMACS_INT is the same width as char *.
2514 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2515 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2516 Remove no-longer-needed casts.
2517 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2518 (xg_tool_bar_help_callback, xg_make_tool_item):
2519 Use EMACS_INTPTR to hold an integer
2520 that will be cast to void *; this can avoid a GCC warning
2521 if EMACS_INT is not the same width as void *.
2522 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2523 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2524 (current_message_1, set_message_1):
2525 Use a local to convert to proper width without a cast.
2526 * xmenu.c (dialog_selection_callback): Likewise.
2527
ede49d71
PE
2528 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2529 Also, don't assume VALBITS / RAND_BITS is less than 5,
2530 and don't rely on undefined behavior when shifting a 1 left into
2531 the sign bit.
2532 * lisp.h (get_random): Change signature to match.
2533
2f30ecd0
PE
2534 * lread.c (hash_string): Use size_t, not int, for hash computation.
2535 Normally we prefer signed values; but hashing is special, because
2536 it's better to use unsigned division on hash table sizes so that
2537 the remainder is nonnegative. Also, size_t is the natural width
2538 for hashing into memory. The previous code used 'int', which doesn't
2539 retain enough info to hash well into very large tables.
2540 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2541
2a866e7b
PE
2542 * dbusbind.c: Don't possibly lose pointer info when converting.
2543 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2544 Use XPNTR rather than XHASH, so that the high-order bits of
2545 the pointer aren't lost when converting through void *.
2546
51639eac
PE
2547 * eval.c (Fautoload): Don't double-shift a pointer.
2548
92394119
PE
2549 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2550
dbdb9a7c
JB
25512011-05-06 Juanma Barranquero <lekktu@gmail.com>
2552
2553 * gnutls.c (DEF_GNUTLS_FN):
2554 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2555
db7a0b4f
AS
25562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2557
2558 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2559 marker. (Bug#8610)
2560
f7ff1b0f 25612011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2562
2563 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2564 New version that can reserve upto 2GB of heap space.
2565
f7ff1b0f 25662011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2567
2568 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2569
639c109b
TZ
25702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2571
2572 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2573 `gnutls_certificate_set_x509_key_file'.
2574
d2127135
JB
25752011-05-05 Juanma Barranquero <lekktu@gmail.com>
2576
2577 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2578 Update dependencies.
2579
e968f4f3
JB
25802011-05-04 Juanma Barranquero <lekktu@gmail.com>
2581
2582 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2583 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2584 Remove unused parameter `fildes'.
2585 * process.c (read_process_output, send_process): Don't pass it.
2586
84d358f0
JB
25872011-05-04 Juanma Barranquero <lekktu@gmail.com>
2588
2589 Fix previous change: the library cache is defined in w32.c.
2590 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2591 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2592
0898ca10
JB
25932011-05-04 Juanma Barranquero <lekktu@gmail.com>
2594
2595 Implement dynamic loading of GnuTLS on Windows.
2596
2597 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2598 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2599 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2600 Declare.
2601
2602 * gnutls.c (Qgnutls_dll): Define.
2603 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2604 (gnutls_*): Declare function pointers.
2605 (init_gnutls_functions): New function to initialize function pointers.
2606 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2607 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2608 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2609 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2610 (emacs_gnutls_write, emacs_gnutls_read)
2611 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2612 (Fgnutls_available_p): New function.
2613 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2614 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2615 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2616
2617 * image.c: Include w32.h.
2618 (Vimage_type_cache): Delete.
2619 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2620 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2621 (w32_delayed_load): Move to w32.c.
2622
2623 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2624
2625 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2626 (w32_delayed_load): Move from image.c. When loading a library, record
2627 its filename in the :loaded-from property of the library id.
2628 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2629 Initialize and staticpro them.
2630 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2631
2632 * process.c: Include lisp.h before w32.h, not after.
2633 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2634 instead of gnutls_record_check_pending.
2635
2636 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2637
ff4de4aa
TZ
26382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2639
2640 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2641 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2642 as passed in.
2643
abe95abb
JD
26442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2645
2646 * xterm.c (x_set_frame_alpha): Do not set property on anything
2647 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2648
e16e55d4
JB
26492011-05-02 Juanma Barranquero <lekktu@gmail.com>
2650
2651 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2652
bafcf6a5
JB
26532011-05-02 Juanma Barranquero <lekktu@gmail.com>
2654
2655 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2656 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2657 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2658 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2659 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2660 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2661 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2662 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2663 (Qgnutls_bootprop_callbacks_verify): Make static.
2664
e7a6747f
AS
26652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2666
19ed11ba
AS
2667 * callproc.c: Indentation fixup.
2668
e7a6747f 2669 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2670 (wait_for_termination, interruptible_wait_for_termination):
2671 Move after wait_for_termination_1.
e7a6747f 2672
1ef14cb4
LMI
26732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2674
2675 * sysdep.c (interruptible_wait_for_termination): New function
2676 which is like wait_for_termination, but allows keyboard
2677 interruptions.
2678
2679 * callproc.c (Fcall_process): Add (:file "file") as an option for
2680 the STDOUT buffer.
2681 (Fcall_process_region): Ditto.
2682
330d880c
EZ
26832011-04-30 Eli Zaretskii <eliz@gnu.org>
2684
8db90b73
EZ
2685 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2686 rather than `XVECTOR (FOO)->size'.
2687
330d880c
EZ
2688 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2689 inttypes.h, as a gnulib replacement is used if it not available in
2690 system headers.
2691
15cbd324
EZ
26922011-04-21 Eli Zaretskii <eliz@gnu.org>
2693
2694 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2695 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2696 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2697
2698 * coding.c (coding_alloc_by_realloc): Error out if destination
2699 will grow beyond MOST_POSITIVE_FIXNUM.
2700 (decode_coding_emacs_mule): Abort if there isn't enough place in
2701 charbuf for the composition carryover bytes. Reserve an extra
2702 space for up to 2 characters produced in a loop.
2703 (decode_coding_iso_2022): Abort if there isn't enough place in
2704 charbuf for the composition carryover bytes.
2705
27062011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2707
ae940cca
EZ
2708 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2709 aborting when %lld or %lll format is passed.
2710 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2711 %llo or %llx format is passed. (Bug#8545)
2712
03ab8921
EZ
2713 * window.c (window_scroll_line_based): Use a marker instead of
2714 simple variables to record original value of point. (Bug#7952)
2715
afda1437
EZ
2716 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2717 produced by %s or %c overflows available buffer space. (Bug#8545)
2718
f76dee0c
PE
27192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2722 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2723
fdc5744d
JB
27242011-04-28 Juanma Barranquero <lekktu@gmail.com>
2725
2726 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2727
638f053a
JB
27282011-04-28 Juanma Barranquero <lekktu@gmail.com>
2729
2730 * keyboard.c (Qdelayed_warnings_hook): Define.
2731 (command_loop_1): Run `delayed-warnings-hook'
2732 if Vdelayed_warnings_list is non-nil.
2733 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2734 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2735
d178f871
EZ
27362011-04-28 Eli Zaretskii <eliz@gnu.org>
2737
2738 * doprnt.c (doprnt): Don't return value smaller than the buffer
2739 size if the message was truncated. (Bug#8545).
2740
b124fd93
JB
27412011-04-28 Juanma Barranquero <lekktu@gmail.com>
2742
2743 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2744 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2745
e810457d
PE
27462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2747
2748 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2749
ea51cceb
JB
27502011-04-27 Juanma Barranquero <lekktu@gmail.com>
2751
2752 * makefile.w32-in: Update dependencies.
2753
94dcfacf
EZ
27542011-04-27 Eli Zaretskii <eliz@gnu.org>
2755
2756 Improve `doprnt' and its usage. (Bug#8545)
2757 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2758 `format_end'. Remove support for %l as a conversion specifier.
2759 Don't use xrealloc. Improve diagnostics when the %l size modifier
2760 is used. Update the commentary.
2761
2762 * eval.c (verror): Simplify calculation of size_t.
2763
2764 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2765 messages.
2766
f61f41d7
PE
27672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2768
2769 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2770 change.
2771
96fb4434
PE
27722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2773
2774 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2775 This makes this file independent of the recent pseudovector change.
2776
671875da 27772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2778
69e9b5a3
PE
2779 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2780
b5f869a7 2781 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2782 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2783 Remove unused local.
c8926152 2784 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2785
841a1577 2786 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2787 GCC 4.6.0 optimizes based on type-based alias analysis.
2788 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2789 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2790 != &v->size, and therefore "v->size = 1; b->size = 2; return
2791 v->size;" must therefore return 1. This assumption is incorrect
2792 for Emacs, since it type-puns struct Lisp_Vector * with many other
2793 types. To fix this problem, this patch adds a new type struct
f904488f 2794 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2795 and pseudovectors, and helps optimizing compilers not get fooled
2796 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2797 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2798 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2799 the size member.
eab3844f
PE
2800 (XSETPVECTYPE): Rewrite in terms of new macro.
2801 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2802 This is a bit clearer, and further avoids the possibility of
2803 undesirable aliasing.
2804 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2805 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2806 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2807 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2808 (ASIZE): Now uses header.size rather than size.
2809 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2810 to avoid the hassle of writing XVECTOR (foo)->header.size.
2811 (struct vectorlike_header): New type.
eab3844f
PE
2812 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2813 object, to help avoid aliasing.
2814 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2815 (SUBRP): Likewise, since Lisp_Subr is a special case.
2816 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2817 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2818 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2819 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2820 changed to be "header.size" and "header.next".
2821 * buffer.h (struct buffer): Likewise.
2822 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2823 * frame.h (struct frame): Likewise.
2824 * process.h (struct Lisp_Process): Likewise.
2825 * termhooks.h (struct terminal): Likewise.
2826 * window.c (struct save_window_data, struct saved_window): Likewise.
2827 * window.h (struct window): Likewise.
2828 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2829 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2830 * buffer.c (init_buffer_once): Likewise.
2831 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2832 special case.
2833 * process.c (Fformat_network_address): Use local var for size,
2834 for brevity.
2835
0df1eac5
PE
2836 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2837
847ab9d1 2838 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2839 * data.c (atof): Remove decl; no longer used or needed.
2840 (digit_to_number): Move to lread.c.
2841 (Fstring_to_number): Use new string_to_number function, to be
2842 consistent with how the Lisp reader treats infinities and NaNs.
2843 Do not assume that floating-point numbers represent EMACS_INT
2844 without losing information; this is not true on most 64-bit hosts.
2845 Avoid double-rounding errors, by insisting on integers when
2846 parsing non-base-10 numbers, as the documentation specifies.
2847 * lisp.h (string_to_number): New decl, replacing ...
2848 (isfloat_string): Remove.
bc0a5c13 2849 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2850 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2851 appears to have been a coding error. Similarly, do not accept
2852 strings like +-1e0 as floating point numbers. Do not report
2853 overflow for integer overflows unless the base is not 10 which
2854 means we have no simple and reliable way to continue.
2855 Break out the floating-point parsing into a new
2856 function string_to_number, so that Fstring_to_number parses
2857 floating point numbers consistently with the Lisp reader.
04f2d78b 2858 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2859 (E_CHAR, EXP_INT): Remove, replacing with ...
2860 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2861 (string_to_number): New function, replacing isfloat_string.
2862 This function checks for valid syntax and produces the resulting
2863 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2864 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2865 so that overflow for non-base-10 numbers is reported only when
2866 there's no portable and simple way to convert to floating point.
452f4150 2867
67769ffc
PE
2868 * textprop.c (set_text_properties_1): Rewrite for clarity,
2869 and to avoid GCC warning about integer overflow.
2870
c20db43f
PE
2871 * intervals.h (struct interval): Use EMACS_INT for members
2872 where EMACS_UINT might cause problems. See
2873 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2874 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2875 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2876 All uses changed.
37aa2f85
PE
2877 (offset_intervals): Tell GCC not to worry about length overflow
2878 when negating a negative length.
c20db43f 2879
2538aa2f
PE
2880 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2881 (overrun_check_free): Likewise.
2882
f2d3008d
PE
2883 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2884 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2885 word size.
2886
ec8df744
PE
2887 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2888 (gnutls_make_error): Rename local to avoid shadowing.
2889 (gnutls_emacs_global_deinit): ifdef out; not used.
2890 (Fgnutls_boot): Use const for pointer to readonly storage.
2891 Comment out unused local. Fix pointer signedness problems.
2892
640ee02d
PE
2893 * lread.c (openp): Don't stuff size_t into an 'int'.
2894 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2895 about possible signed overflow.
2896
6048fb2a
PE
2897 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2898 (GDK_KEY_g): Don't define if already defined.
2899 (xg_prepare_tooltip): Avoid pointer signedness problem.
2900 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2901
fa3c87e1
PE
2902 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2903 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2904
2172544b
PE
2905 * xfns.c (Fx_window_property): Simplify a bit,
2906 to make a bit faster and to avoid GCC 4.6.0 warning.
2907 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2908
9b821a21
PE
2909 * fns.c (internal_equal): Don't assume size_t fits in int.
2910
3c616cfa
PE
2911 * alloc.c (compact_small_strings): Tighten assertion a little.
2912
c2982e87
PE
2913 Replace pEd with more-general pI, and fix some printf arg casts.
2914 * lisp.h (pI): New macro, generalizing old pEd macro to other
2915 conversion specifiers. For example, use "...%"pI"d..." rather
2916 than "...%"pEd"...".
2917 (pEd): Remove. All uses replaced with similar uses of pI.
2918 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2919 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2920 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2921 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2922 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2923 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2924 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2925 64-bit hosts.
2926 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2927 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2928 * print.c (safe_debug_print, print_object): Likewise.
2929 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2930 to int.
6f04d126
PE
2931 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2932 avoiding the 0 flag, which is not portable.
c2982e87
PE
2933 * process.c (Fmake_network_process): Use pI to avoid cast.
2934 * region-cache.c (pp_cache): Likewise.
2935 * xdisp.c (decode_mode_spec): Likewise.
2936 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2937 behavior on 64-bit hosts with printf arg.
6f04d126 2938 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2939 (x_stop_queuing_selection_requests): Likewise.
2940 (x_get_window_property): Don't truncate byte count to an 'int'
2941 when tracing.
0b432f21 2942
5e073ec7
PE
2943 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2944 here, since it parses constructs like leading '-' and spaces,
2945 which are not wanted; and it overflows with large numbers.
2946 Instead, simply match F[0-9]+, which is what is wanted anyway.
2947
36372bf9
PE
2948 * alloc.c: Remove unportable assumptions about struct layout.
2949 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2950 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2951 (allocate_vectorlike, make_pure_vector): Use the new macros,
2952 plus offsetof, to remove unportable assumptions about struct layout.
2953 These assumptions hold on all porting targets that I know of, but
2954 they are not guaranteed, they're easy to remove, and removing them
2955 makes further changes easier.
2956
0b432f21
PE
2957 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2958 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2959 (string_overrun_cookie): Now const. Use initializers that
2960 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2961 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2962 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2963 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2964 multiple of sizeof (EMACS_INT); it need not be, if
2965 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2966 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2967
895009e1
JB
29682011-04-26 Juanma Barranquero <lekktu@gmail.com>
2969
2970 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2971
6a7a1b0b
TZ
29722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2973
2974 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2975 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2976 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2977
841a1577 29782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2979
2980 * lisp.h (Qdebug): List symbol.
895009e1 2981 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2982 * keyboard.c (debug-on-event): New variable.
2983 (handle_user_signal): Break into debugger when debug-on-event
2984 matches the current signal symbol.
2985
f2d3ba6f
DN
29862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2987
2988 * alloc.c (check_sblock, check_string_bytes)
2989 (check_string_free_list): Convert to standard C.
2990
42ce4c63
TZ
29912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2992
2993 * w32.c (emacs_gnutls_push): Fix typo.
2994
825cd63c
EZ
29952011-04-25 Eli Zaretskii <eliz@gnu.org>
2996
fb11d64d
EZ
2997 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2998 "cast to pointer from integer of different size".
2999
825cd63c
EZ
3000 Improve doprnt and its use in verror. (Bug#8545)
3001 * doprnt.c (doprnt): Document the set of format control sequences
3002 supported by the function. Use SAFE_ALLOCA instead of always
3003 using `alloca'.
3004
3005 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3006 is one byte too soon. Don't use xrealloc; instead xfree and
3007 xmalloc anew.
3008
e061a11b
TZ
30092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3010
3011 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3012 callbacks stage.
3013
3014 * gnutls.c: Renamed global_initialized to
3015 gnutls_global_initialized. Added internals for the
3016 :verify-hostname-error, :verify-error, and :verify-flags
3017 parameters of `gnutls-boot' and documented those parameters in the
3018 docstring. Start callback support.
9173deec
JB
3019 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3020 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3021 on error. Return error code.
e061a11b
TZ
3022 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3023 (emacs_gnutls_read): Likewise.
3024 (Fgnutls_boot): Return handshake error code.
3025 (emacs_gnutls_handle_error): New function.
3026 (wsaerror_to_errno): Likewise.
3027
3028 * w32.h (emacs_gnutls_pull): Add prototype.
3029 (emacs_gnutls_push): Likewise.
3030
3031 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3032 (emacs_gnutls_push): Likewise.
3033
30342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3035
3036 * process.c (wait_reading_process_output): Check if GnuTLS
3037 buffered some data internally if no FDs are set for TLS
3038 connections.
3039
3040 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3041 (LIBS): Link to USER_LIBS.
3042 ($(BLD)/gnutls.$(0)): New target.
3043
fa6996bc
EZ
30442011-04-24 Eli Zaretskii <eliz@gnu.org>
3045
eb35682e
EZ
3046 * xdisp.c (handle_single_display_spec): Rename the
3047 display_replaced_before_p argument into display_replaced_p, to
3048 make it consistent with the commentary. Fix typos in the
3049 commentary.
3050
e2ad650c
EZ
3051 * textprop.c (syms_of_textprop): Remove dead code.
3052 (copy_text_properties): Delete obsolete commentary about an
3053 interface that was deleted long ago. Fix typos in the description
3054 of arguments.
3055
1b2de274
EZ
3056 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3057 to changes in oldXMenu/XMenu.h from 2011-04-16.
3058 <menu_help_message, prev_menu_help_message>: Constify.
3059 (IT_menu_make_room): menu->help_text is now `const char **';
3060 adjust.
3061
3062 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3063 to changes in oldXMenu/XMenu.h from 2011-04-16.
3064 (struct XMenu): Declare `help_text' `const char **'.
3065
3066 * xfaces.c <Qunspecified>: Make extern again.
3067
3068 * syntax.c: Include sys/types.h before including regex.h, as
3069 required by Posix.
3070
762b15be
EZ
3071 * doc.c (get_doc_string): Improve the format passed to `error'.
3072
3073 * doprnt.c (doprnt): Improve commentary.
3074
3075 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3076
3077 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3078 them with etags.
3079
f1052e5d
EZ
3080 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3081 changes in globals.h immediately force recompilation.
762b15be
EZ
3082 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3083 $(CURDIR)/s/ms-w32.h.
3084 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3085
fa6996bc
EZ
3086 * character.c (Fchar_direction): Function deleted.
3087 (syms_of_character): Don't defsubr it.
3088 <char-direction-table>: Deleted.
3089
e6c3da20
EZ
30902011-04-23 Eli Zaretskii <eliz@gnu.org>
3091
3092 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3093 * doprnt.c: Include limits.h.
3094 (SIZE_MAX): New macro.
04f2d78b
CB
3095 (doprnt): Return a size_t value. 2nd arg is now size_t.
3096 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3097 Improve overflow protection. Support `l' modifier for integer
3098 conversions. Support %l conversion. Don't assume an EMACS_INT
3099 argument for integer conversions and for %c.
3100
3101 * lisp.h (doprnt): Restore prototype.
3102
3103 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3104 $(SRC)/character.h.
3105
3106 * Makefile.in (base_obj): Add back doprnt.o.
3107
3108 * deps.mk (doprnt.o): Add back prerequisites.
3109 (callint.o): Depend on character.h.
3110
3111 * eval.c (internal_lisp_condition_case): Include the handler
3112 representation in the error message.
3113 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3114 when breaking from the loop.
3115
3116 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3117
3118 * callint.c (Fcall_interactively): When displaying error message
3119 about invalid control letter, pass the character's codepoint, not
3120 a pointer to its multibyte form. Improve display of the character
3121 in octal and display also its hex code.
3122
3123 * character.c (char_string): Use %x to display the (unsigned)
3124 codepoint of an invalid character, to avoid displaying a bogus
3125 negative value.
3126
3127 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3128 `error', not SYMBOL_NAME itself.
3129
3130 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3131 character arguments to `error'.
3132
3133 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3134 to `error' in error message about FINAL_CHAR argument. Make sure
3135 FINAL_CHAR is a character, and use %c when it is passed as
3136 argument to `error'.
3137
4ffd0d6b 31382011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3139
3140 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3141
3142 * w32.c: Include <time.h>.
3143 (sys_localtime): New function.
3144
4ffd0d6b 31452011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3146
3147 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3148
4ffd0d6b 3149 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3150
4ffd0d6b 31512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3152
4ffd0d6b
GM
3153 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3154 zombies (Bug#8467).
aac0c6e3 3155
04c56954
EZ
31562011-04-19 Eli Zaretskii <eliz@gnu.org>
3157
3158 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3159 gl_state.e_property when gl_state.object is Qt.
3160
3161 * insdel.c (make_gap_larger): Remove limitation of buffer size
3162 to <= INT_MAX.
3163
16a43933
CY
31642011-04-18 Chong Yidong <cyd@stupidchicken.com>
3165
3166 * xdisp.c (lookup_glyphless_char_display)
3167 (produce_glyphless_glyph): Handle cons cell entry in
3168 glyphless-char-display.
3169 (Vglyphless_char_display): Document it.
3170
3171 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3172 glyphless-char-display.
3173
4581706e
CY
31742011-04-17 Chong Yidong <cyd@stupidchicken.com>
3175
3176 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3177
3178 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3179
3180 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3181 definition for no-X builds.
3182
4887c6e2 31832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3184
fd35b6f9
PE
3185 Static checks with GCC 4.6.0 and non-default toolkits.
3186
5c1ccb01
PE
3187 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3188
006c5daa
PE
3189 * process.c (keyboard_bit_set): Define only if SIGIO.
3190 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3191 (send_process): Repair possible setjmp clobbering.
3192
efc736d3
PE
3193 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3194
4e2fe2e6
PE
3195 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3196
f97334a2
PE
3197 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3198
4e75f29d
PE
3199 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3200 Define only if needed.
3201
90efadd1
PE
3202 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3203 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3204 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3205
3c647824
PE
3206 * dispextern.h (struct redisplay_interface): Rename param
3207 to avoid shadowing.
e264f262 3208 * termhooks.h (struct terminal): Likewise.
761383f4 3209 * xterm.c (xembed_send_message): Likewise.
3c647824 3210
b58c5c4a
PE
3211 * insdel.c (make_gap_smaller): Define only if
3212 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3213
cad59032
PE
3214 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3215 it.
3216
c339dc2e
PE
3217 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3218 so that we aren't warned about unused symbols.
3219
91a3e27b
PE
3220 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3221
399c71d3 3222 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3223
8ffc96f5
PE
3224 * xfns.c (x_real_positions): Mark locals as initialized.
3225
eef9bc79
PE
3226 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3227
098db9dd
PE
3228 * xterm.c: Fix problems found by static analysis with other toolkits.
3229 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3230 (x_dispatch_event): Declare static if USE_GTK, and
3231 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3232 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3233 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3234 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3235 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3236
eb18f6cc
PE
3237 * xmenu.c (menu_help_callback): Pointer type fixes.
3238 Use const pointers when pointing at readonly data. Avoid pointer
3239 signedness clashes.
3240 (FALSE): Remove unused macro.
3241 (update_frame_menubar): Remove unused decl.
3242
1fe72bf8
PE
3243 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3244
60d9e1db
PE
3245 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3246 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3247 (single_menu_item): Rename local to avoid shadowing.
3248
39261c26
PE
3249 * keyboard.c (make_lispy_event): Remove unused local var.
3250
018c5e19
PE
3251 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3252 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3253
63d2b86e
PE
3254 * bitmaps: Change bitmaps from unsigned char back to the X11
3255 compatible char. Avoid the old compiler warnings about
3256 out-of-range initializers by using, for example, '\xab' rather
3257 than 0xab.
3258
aefd87e1
PE
3259 * xgselect.c (xgselect_initialize): Check vs interface
3260 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3261
bf501fb9
PE
3262 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3263
e9829fdf
PE
3264 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3265 to read-only memory.
3266
1086c095
PE
3267 * fns.c (vector): Remove; this old hack is no longer needed.
3268
2baccd04 3269 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3270 Remove unused var.
dde42981 3271 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3272
72391843 3273 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3274
436c16df 3275 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3276 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3277 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3278
92bb796d 3279 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3280 (x_term_init): Remove local to avoid shadowing.
92bb796d 3281
764430a3 3282 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3283
3284 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3285 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3286
d1dfb56c
EZ
32872011-04-16 Eli Zaretskii <eliz@gnu.org>
3288
c4354cb4
EZ
3289 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3290
d1dfb56c
EZ
3291 Fix regex.c, syntax.c and friends for buffers > 2GB.
3292 * syntax.h (struct gl_state_s): Declare character position members
3293 EMACS_INT.
3294
3295 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3296
04f2d78b
CB
3297 * textprop.c (verify_interval_modification, interval_of):
3298 Declare arguments EMACS_INT.
d1dfb56c
EZ
3299
3300 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3301 EMACS_INT.
3302
3303 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3304
3305 * indent.c (Fvertical_motion): Local variable it_start is now
3306 EMACS_INT.
3307
3308 * regex.c (re_match, re_match_2, re_match_2_internal)
3309 (bcmp_translate, regcomp, regexec, print_double_string)
3310 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3311 (re_compile_pattern, re_exec): Declare arguments and local
3312 variables `size_t' and `ssize_t' and return values `regoff_t', as
3313 appropriate.
3314 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3315 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3316 <compile_stack_type>: `size' and `avail' are now `size_t'.
3317
3318 * regex.h <regoff_t>: Use ssize_t, not int.
3319 (re_search, re_search_2, re_match, re_match_2): Arguments that
3320 specify buffer/string position and length are now ssize_t and
3321 size_t. Return type is regoff_t.
3322
613052cd
BK
33232011-04-16 Ben Key <bkey76@gmail.com>
3324
3325 * nsfont.m: Fixed bugs in ns_get_family and
3326 ns_descriptor_to_entity that were caused by using free to
3327 deallocate memory blocks that were allocated by xmalloc (via
3328 xstrdup). This caused Emacs to crash when compiled with
3329 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3330 --enable-checking=xmallocoverrun). xfree is now used to
3331 deallocate these memory blocks.
3332
4170f62f 33332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3334
71b41406
PE
3335 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3336
9587a89d
PE
3337 emacs_write: Accept and return EMACS_INT for sizes.
3338 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3339 et seq.
3340 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3341 Accept and return EMACS_INT.
3342 (emacs_gnutls_write): Return the number of bytes written on
3343 partial writes.
3344 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3345 (emacs_read, emacs_write): Remove check for negative size, as the
3346 Emacs source code has been audited now.
9587a89d
PE
3347 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3348 (emacs_read, emacs_write): Use it.
273a5f82
PE
3349 * process.c (send_process): Adjust to the new signatures of
3350 emacs_write and emacs_gnutls_write. Do not attempt to store
3351 a byte offset into an 'int'; it might overflow.
9587a89d 3352 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3353
3e047f51
PE
3354 * sound.c: Don't assume sizes fit in 'int'.
3355 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3356 Return EMACS_INT, not int.
3e047f51 3357 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3358 Accept EMACS_INT, not int.
3359 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3360 record read return values.
3361
cc39a9db
BK
33622011-04-15 Ben Key <bkey76@gmail.com>
3363
c9d0ec6d
JB
3364 * keyboard.c (Qundefined): Don't declare static since it is used
3365 in nsfns.m.
3366 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3367 static since they are used in nsfont.m.
cc39a9db 3368
6c60eb9f
SM
33692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3370
3371 * process.c (Qprocessp): Don't declare static.
3372 * lisp.h (Qprocessp): Declare again.
3373
7990b61a
JB
33742011-04-15 Juanma Barranquero <lekktu@gmail.com>
3375
3376 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3377
5d4cb038
PE
33782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3379
8bd7b830 3380 Improve C-level modularity by making more things 'static'.
cd64ea1d 3381
e3b27b31
PE
3382 Don't publish debugger-only interfaces to other modules.
3383 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3384 (verify_bytepos, count_markers): Move decls to the only modules
3385 that need them.
3386 * region-cache.h (pp_cache): Likewise.
3387 * window.h (check_all_windows): Likewise.
3388 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3389
5d4cb038
PE
3390 * sysdep.c (croak): Now static, if
3391 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3392 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3393
3394 * alloc.c (refill_memory_reserve): Now static if
3395 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3396 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3397
e87b6180
PE
3398 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3399 Define only if USE_LUCID.
3400
ac64929e
PE
3401 * xrdb.c (x_customization_string, x_rm_string): Now static.
3402
6f37259d
PE
3403 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3404 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3405
1683e3ab
PE
3406 * xdisp.c (draw_row_with_mouse_face): Now static.
3407 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3408
de9c2632
PE
3409 * window.h (check_all_windows): Mark externally visible.
3410
2b96acb7
PE
3411 * window.c (window_deletion_count): Now static.
3412
3413 * undo.c: Make symbols static if they're not exported.
3414 (last_undo_buffer, last_boundary_position, pending_boundary):
3415 Now static.
3416
50436f33
PE
3417 * textprop.c (interval_insert_behind_hooks): Now static.
3418 (interval_insert_in_front_hooks): Likewise.
3419
64520e5c
PE
3420 * term.c: Make symbols static if they're not exported.
3421 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3422 (max_frame_lines, tty_set_terminal_modes):
3423 (tty_reset_terminal_modes, tty_turn_off_highlight):
3424 (get_tty_terminal): Now static.
3425 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3426 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3427 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3428 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3429 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3430
1fa53021
PE
3431 * sysdep.c: Make symbols static if they're not exported.
3432 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3433 Now static.
3434 (sigprocmask_set, full_mask): Remove; unused.
3435 (wait_debugging): Mark as visible.
3436 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3437 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3438
d4b43b22
PE
3439 * syntax.c (syntax_temp): Define only if !__GNUC__.
3440
b7c513d0
PE
3441 * sound.c (current_sound_device, current_sound): Now static.
3442
989b29ad
PE
3443 * search.c (searchbufs, searchbuf_head): Now static.
3444
13a55a78
PE
3445 * scroll.c (scroll_cost): Remove; unused.
3446 * dispextern.h (scroll_cost): Remove decl.
3447
de68a1fc
PE
3448 * region-cache.h (pp_cache): Mark as externally visible.
3449
40ccffa6
PE
3450 * process.c: Make symbols static if they're not exported.
3451 (process_tick, update_tick, create_process, chan_process):
3452 (Vprocess_alist, proc_buffered_char, datagram_access):
3453 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3454 (deactivate_process): Mark defn as static, as well as decl.
3455 * lisp.h (create_process): Remove decl.
3456 * process.h (chan_process, Vprocess_alist): Remove decls.
3457
ad64fc97
PE
3458 * print.c: Make symbols static if they're not exported.
3459 (print_depth, new_backquote_output, being_printed, print_buffer):
3460 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3461 (print_interval, print_number_index, initial_stderr_stream):
3462 Now static.
3463 * lisp.h (Fprinc): Remove decl.
3464 (debug_output_compilation_hack): Mark as externally visible.
3465
adddb265
PE
3466 * sysdep.c (croak): Move decl from here to syssignal.h.
3467 * syssignal.h (croak): Put it here, so the API can be checked when
3468 'croak' is called from dissociate_if_controlling_tty.
3469
1717ede2
PE
3470 * minibuf.c: Make symbols static if they're not exported.
3471 (minibuf_save_list, choose_minibuf_frame): Now static.
3472 * lisp.h (choose_minibuf_frame): Remove decl.
3473
fa5fb2bc
PE
3474 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3475
1e3890d1
PE
3476 * lread.c: Make symbols static if they're not exported.
3477 (read_objects, initial_obarray, oblookup_last_bucket_number):
3478 Now static.
3479 (make_symbol): Remove; unused.
3480 * lisp.h (initial_obarray, make_symbol): Remove decls.
3481
8a1414fa
PE
3482 * keyboard.c: Make symbols static if they're not exported.
3483 (single_kboard, recent_keys_index, total_keys, recent_keys):
3484 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3485 (this_single_command_key_start, echoing, last_auto_save):
3486 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3487 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3488 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3489 (Vlispy_mouse_stem, double_click_count):
3490 Now static.
3491 (force_auto_save_soon): Define only if SIGDANGER.
3492 (ignore_mouse_drag_p): Now static if
3493 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3494 (print_help): Remove; unused.
3495 (stop_character, last_timer_event): Mark as externally visible.
3496 * keyboard.h (ignore_mouse_drag_p): Declare only if
3497 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3498 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3499 * lisp.h (echoing): Remove decl.
3500 (force_auto_save_soon): Declare only if SIGDANGER.
3501 * xdisp.c (redisplay_window): Simplify code, to make it more
3502 obvious that ignore_mouse_drag_p is not accessed if !defined
3503 USE_GTK && !defined HAVE_NS.
3504
93ea6e8f
PE
3505 * intervals.c: Make symbols static if they're not exported.
3506 (merge_properties_sticky, merge_interval_right, delete_interval):
3507 Now static.
3508 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3509
77382fcc
PE
3510 * insdel.c: Make symbols static if they're not exported.
3511 However, leave prepare_to_modify_buffer alone. It's never
3512 called from outside this function, but that appears to be a bug.
3513 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3514 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3515 (adjust_after_replace_noundo): Remove; unused.
3516 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3517 (signal_before_change): Remove decls.
77382fcc 3518
9306c32e
PE
3519 * indent.c (val_compute_motion, val_vmotion): Now static.
3520
cd44d2eb
PE
3521 * image.c: Make symbols static if they're not exported.
3522 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3523 if USE_GTK.
3524 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3525 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3526
ad9a7a06
PE
3527 * fringe.c (standard_bitmaps): Now static.
3528 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3529
81626931
PE
3530 * frame.c: Make symbols static if they're not exported.
3531 (x_report_frame_params, make_terminal_frame): Now static.
3532 (get_frame_param): Now static, unless HAVE_NS.
3533 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3534 (x_get_resource_string): Remove; not used.
3535 * frame.h (make_terminal_frame, x_report_frame_params):
3536 (x_get_resource_string); Remove decls.
3537 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3538 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3539
239f9db9
PE
3540 * font.c, fontset.c: Make symbols static if they're not exported.
3541 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3542 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3543 * font.c (font_close_object): Now static.
3544 * font.h (font_close_object): Remove.
3545 * fontset.c (FONTSET_OBJLIST): Remove.
3546 (free_realized_fontset) #if-0 the body, which does nothing.
3547 (face_suitable_for_char_p): #if-0, as it's never called.
3548 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3549 * xfaces.c (face_at_string_position):
3550 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3551 since 0 is always ASCII.
3552
dfcf3579
PE
3553 * fns.c (weak_hash_tables): Now static.
3554
5045092b
PE
3555 * fileio.c: Make symbols static if they're not exported.
3556 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3557 (Vwrite_region_annotation_buffers): Now static.
3558
57a96f5c
PE
3559 * eval.c: Make symbols static if they're not exported.
3560 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3561 * lisp.h (backtrace_list): Remove decl.
3562
35f08c38
PE
3563 * emacs.c: Make symbols static if they're not exported.
3564 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3565 (fatal_error_code, fatal_error_signal_hook, standard_args):
3566 Now static.
3567 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3568 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3569 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3570 * lisp.h (fatal_error_signal_hook): Remove decl.
3571 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3572
f44bd759
PE
3573 * editfns.c: Move a (normally-unused) function to its only use.
3574 * editfns.c, lisp.h (get_operating_system_release): Remove.
3575 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3576 worth the hassle of breaking this out.
3577
b532497d
PE
3578 * xterm.c: Make symbols static if they're not exported.
3579 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3580 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3581 (x_destroy_window, x_delete_display):
3582 Now static.
3583 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3584 (x_mouse_leave): Remove; unused.
3585 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3586 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3587 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3588 Remove decls.
3589 (x_mouse_leave): Declare only if WINDOWSNT.
3590 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3591 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3592 USE_X_TOOLKIT.
3593
1675728f
PE
3594 * ftxfont.c: Make symbols static if they're not exported.
3595 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3596 HAVE_FREETYPE.
3597 * font.h (ftxfont_driver): Likewise.
3598
e4cebfca
PE
3599 * xfns.c: Make symbols static if they're not exported.
3600 (x_last_font_name, x_display_info_for_name):
3601 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3602 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3603 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3604 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3605 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3606 (last_show_tip_args): Now static.
3607 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3608 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3609 (x_screen_planes): Remove; unused.
3610 * dispextern.h (x_screen_planes): Remove decl.
3611
5bf46f05
PE
3612 * dispnew.c: Make symbols static if they're not exported.
3613 * dispextern.h (redraw_garbaged_frames, scrolling):
3614 (increment_row_positions): Remove.
3615 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3616 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3617 Now static.
3618 (redraw_garbaged_frames): Remove; unused.
3619
435f4c28
PE
3620 * xfaces.c: Make symbols static if they're not exported.
3621 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3622 Remove decls.
3623 * xterm.h (defined_color): Remove decls.
3624 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3625 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3626 (menu_face_changed_default, defined_color, free_realized_face):
3627 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3628 (ascii_face_of_lisp_face): Remove; unused.
3629
8524aef3
PE
3630 * xdisp.c: Make symbols static if they're not exported.
3631 * dispextern.h (scratch_glyph_row, window_box_edges):
3632 (glyph_to_pixel_coords, set_cursor_from_row):
3633 (get_next_display_element, set_iterator_to_next):
3634 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3635 (show_mouse_face): Remove decls
3636 * frame.h (message_buf_print): Likewise.
3637 * lisp.h (pop_message, set_message, check_point_in_composition):
3638 Likewise.
3639 * xterm.h (set_vertical_scroll_bar): Likewise.
3640 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3641 (message_buf_print, scratch_glyph_row, displayed_buffer):
3642 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3643 (get_next_display_element, show_mouse_face, window_box_edges):
3644 (frame_to_window_pixel_xy, check_point_in_composition):
3645 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3646 (glyph_to_pixel_coords): Remove; unused.
3647
16390cd2
PE
3648 * dired.c (file_name_completion): Now static.
3649
3650 * dbusbind.c (xd_in_read_queued_messages): Now static.
3651
a25f4dfa
PE
3652 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3653 * data.c (circular_list_error): Remove.
3654
14a9c8df
PE
3655 * commands.h (last_point_position, last_point_position_buffer):
3656 (last_point_position_window): Remove decls.
3657 * keyboard.c: Make these variables static.
3658
04f2d78b
CB
3659 * coding.h (coding, code_convert_region, encode_coding_gap):
3660 Remove decls.
74ab6df5
PE
3661 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3662 (iso_code_class, detect_coding, code_convert_region): Now static.
3663 (encode_coding_gap): Remove; unused.
3664
38dfbee1
PE
3665 * chartab.c (chartab_chars, chartab_bits): Now static.
3666
a2cb4e63
PE
3667 * charset.h (charset_iso_8859_1): Remove decl.
3668 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3669 Now static.
3670
127198fd
PE
3671 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3672 * ccl.c (Vccl_program_table): Now static.
3673 (check_ccl_update): Remove; unused.
3674
d85b608f
PE
3675 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3676 * category.h: ... from here.
3677 * category.c (check_category_table, set_category_set): Now static.
3678
31cd66f3
PE
3679 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3680 * lisp.h: Remove these decls.
3681
c358e587
PE
3682 * buffer.c (buffer_count): Remove unused var.
3683
e78aecca
PE
3684 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3685 so that it's not optimized away.
3686 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3687 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3688 exported only to the debugger.
3689
e192d7d3 3690 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3691 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3692
92470028
PE
3693 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3694 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3695 was inaccessible from Lisp.
3696 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3697 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3698
244ed907
PE
3699 alloc.c: Import and export fewer symbols, and remove unused items.
3700 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3701 is defined.
3702 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3703 it's not optimized away by whole-program optimization.
3704 (message_enable_multibyte, free_misc): Remove.
3705 (catchlist, handlerlist, mark_backtrace):
3706 Declare only if BYTE_MARK_STACK.
3707 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3708 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3709 (message_enable_multibyte): Remove decl.
3710 (free_misc, interval_free_list, float_block, float_block_index):
3711 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3712 (cons_free_list, last_marked_index):
3713 Now static.
3714 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3715 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3716 (mark_backtrace): Define only if BYTE_MARK_STACK.
3717 * xdisp.c (message_enable_multibyte): Now static.
3718
61c2b50e 3719 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3720 This makes it easier for human readers (and static analyzers)
3721 to see whether these variables are used from other modules.
3722 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3723 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3724 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3725 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3726 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3727 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3728 * xmenu.c, xselect.c:
3729 Declare Q* vars static if they are not used in other modules.
3730 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3731 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3732 Remove decls of unexported vars.
3733 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3734
95c82688
PE
3735 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3736
16a97296
PE
3737 Make Emacs functions such as Fatom 'static' by default.
3738 This makes it easier for human readers (and static analyzers)
3739 to see whether these functions can be called from other modules.
3740 DEFUN now defines a static function. To make the function external
3741 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3742 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3743 (Finit_image_library):
16a97296
PE
3744 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3745 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3746 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3747 Remove decls, since these functions are now static.
3748 (Funintern, Fget_internal_run_time): New decls, since these functions
3749 were already external.
95c82688 3750
16a97296
PE
3751 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3752 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3753 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3754 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3755 * keyboard.c, keymap.c, lread.c:
3756 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3757 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3758 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3759 Mark functions with DEFUE instead of DEFUN,
3760 if they are used in other modules.
3761 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3762 decls for now-static functions.
3763 * buffer.h (Fdelete_overlay): Remove decl.
3764 * callproc.c (Fgetenv_internal): Mark as internal.
3765 * composite.c (Fremove_list_of_text_properties): Remove decl.
3766 (Fcomposition_get_gstring): New forward static decl.
3767 * composite.h (Fcomposite_get_gstring): Remove decl.
3768 * dired.c (Ffile_attributes): New forward static decl.
3769 * doc.c (Fdocumntation_property): New forward static decl.
3770 * eval.c (Ffetch_bytecode): New forward static decl.
3771 (Funintern): Remove extern decl; now in .h file where it belongs.
3772 * fileio.c (Fmake_symbolic_link): New forward static decl.
3773 * image.c (Finit_image_library): New forward static decl.
3774 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3775 * intervals.h (Fprevious_property_change):
3776 (Fremove_list_of_text_properties): Remove decls.
3777 * keyboard.c (Fthis_command_keys): Remove decl.
3778 (Fcommand_execute): New forward static decl.
3779 * keymap.c (Flookup_key): New forward static decl.
3780 (Fcopy_keymap): Now static.
3781 * keymap.h (Flookup_key): Remove decl.
3782 * process.c (Fget_process): New forward static decl.
3783 (Fprocess_datagram_address): Mark as internal.
3784 * syntax.c (Fsyntax_table_p): New forward static decl.
3785 (skip_chars): Remove duplicate decl.
3786 * textprop.c (Fprevious_property_change): New forward static decl.
3787 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3788 Now internal.
3789 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3790 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3791
785bbd42
PE
3792 * editfns.c (Fformat): Remove unreachable code.
3793
8b913b57
AS
37942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3795
3796 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3797 change. (Bug#8496)
3798
a6744a35
EZ
37992011-04-13 Eli Zaretskii <eliz@gnu.org>
3800
3801 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3802 when at ZV. (Bug#8487)
3803
e7974947
AS
38042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3805
baad03f0
AS
3806 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3807 (Bug#8437)
3808 * keyboard.c (parse_tool_bar_item): Likewise.
3809 * sound.c (sound_cleanup, alsa_close): Likewise.
3810 * termcap.c (tgetent): Likewise.
3811 * xfns.c (x_default_font_parameter): Likewise.
3812 * xsettings.c (read_and_apply_settings): Likewise.
3813
e7974947
AS
3814 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3815 (overrun_check_free): Protoize.
3816
28272684
PE
38172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3818
3819 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3820 since callers should never pass a negative size.
3821 Change the signature to match that of plain 'read' and 'write'; see
3822 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3823 * lisp.h: Update prototypes of emacs_write and emacs_read.
3824
11997c76
EZ
38252011-04-11 Eli Zaretskii <eliz@gnu.org>
3826
3827 * xdisp.c (redisplay_window): Don't try to determine the character
3828 position of the scroll margin if the window start point w->startp
e896f03c 3829 is outside the buffer's accessible region. (Bug#8468)
11997c76 3830
8a2cbd72
EZ
38312011-04-10 Eli Zaretskii <eliz@gnu.org>
3832
3833 Fix write-region and its subroutines for buffers > 2GB.
3834 * fileio.c (a_write, e_write): Modify declaration of arguments and
3835 local variables to support buffers larger than 2GB.
3836 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3837
3838 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3839 argument, local variables, and return value.
3840
3841 * lisp.h: Update prototypes of emacs_write and emacs_read.
3842
3843 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3844
4073e537 38452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3846
1ebfdcb6
PE
3847 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3848
b2ded58d
PE
3849 Fix more problems found by GCC 4.6.0's static checks.
3850
7d66342c
PE
3851 * xdisp.c (vmessage): Use a better test for character truncation.
3852
bbf47d44
PE
3853 * charset.c (load_charset_map): <, not <=, for optimization,
3854 and to avoid potential problems with integer overflow.
9248994d 3855 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3856 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3857 * editfns.c (Fformat): Likewise.
1e69125e 3858 * syntax.c (skip_chars): Likewise.
3befa583 3859
e3019616
PE
3860 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3861 This also lets GCC 4.6.0 generate slightly better loop code.
3862
becfa255
PE
3863 * callint.c (Fcall_interactively): <, not <=, for optimization.
3864 (Fcall_interactively): Count the number of arguments produced,
3865 not the number of arguments given. This is simpler and lets GCC
3866 4.6.0 generate slightly better code.
3867
dae0cd48
PE
3868 * ftfont.c: Distingish more carefully between FcChar8 and char.
3869 The previous code passed unsigned char * to a functions like
3870 strlen and xstrcasecmp that expect char *, which does not
3871 conform to the C standard.
3872 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3873 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3874 char * when the C standard requires it.
3875
76032d70
PE
3876 * keyboard.c (read_char): Remove unused var.
3877
eb3f1cc8
PE
3878 * eval.c: Port to Windows vsnprintf (Bug#8435).
3879 Include <limits.h>.
3880 (SIZE_MAX): Define if the headers do not.
3881 (verror): Do not give up if vsnprintf returns a negative count.
3882 Instead, grow the buffer. This ports to Windows vsnprintf, which
3883 does not conform to C99. Problem reported by Eli Zaretskii.
3884 Also, simplify the allocation scheme, by avoiding the need for
3885 calling realloc, and removing the ALLOCATED variable.
3886
70476b54
PE
3887 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3888
12020a9e
PE
3889 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3890 But keep the doprint source code for now, as we might revamp it
3891 and use it again (Bug#8435).
ea6c7ae6
PE
3892 * lisp.h (doprnt): Remove.
3893 * Makefile.in (base_obj): Remove doprnt.o.
3894 * deps.mk (doprnt.o): Remove.
3895
5fdb398c
PE
3896 error: Print 32- and 64-bit integers portably (Bug#8435).
3897 Without this change, on typical 64-bit hosts error ("...%d...", N)
3898 was used to print both 32- and 64-bit integers N, which relied on
3899 undefined behavior.
3900 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3901 New macro.
3902 * lisp.h (error, verror): Mark as printf-like functions.
3903 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3904 Report overflow in size calculations when allocating printf buffer.
3905 Do not truncate output string at its first null byte.
3906 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3907 Truncate the output at a character boundary, since vsnprintf does not
3908 do that.
3909 * charset.c (check_iso_charset_parameter): Convert internal
3910 character to string before calling 'error', since %c now has the
3911 printf meaning.
3912 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3913 overflow when computing char to be passed to 'error'. Do not
3914 pass Lisp_Object to 'error'; pass the integer instead.
3915 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3916 formatted with plain %d.
3917
b189fa66
PE
3918 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3919
bff87ef0
PE
3920 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3921
7e2cac20
PE
3922 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3923
ce4d90b5
PE
3924 * xterm.c (x_catch_errors): Remove duplicate declaration.
3925
266c9547
PE
3926 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3927
79c49ad2
PE
3928 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3929
368f4090
JM
39302011-04-10 Jim Meyering <meyering@redhat.com>
3931
3932 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3933 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3934 return ssize_t not "int", and use size_t as the buffer length.
3935 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3936 * gnutls.h: Update declarations.
3937 * process.c (read_process_output): Use ssize_t, to match.
3938 (send_process): Likewise.
3939
a32d4040
CY
39402011-04-09 Chong Yidong <cyd@stupidchicken.com>
3941
3942 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3943
8546720e 39442011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3945
04f2d78b
CB
3946 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3947 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3948
8546720e
GM
3949 * xterm.c (handle_one_xevent):
3950 * xmenu.c (create_and_show_popup_menu):
3951 * xselect.c (x_decline_selection_request)
3952 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3953
0a2f5c1a 39542011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3955
3956 Fix some uses of `int' instead of EMACS_INT.
3957 * search.c (string_match_1, fast_string_match)
3958 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3959 (scan_buffer, find_next_newline_no_quit)
3960 (find_before_next_newline, search_command, Freplace_match)
3961 (Fmatch_data): Make some `int' variables be EMACS_INT.
3962
3963 * xdisp.c (display_count_lines): 3rd argument and return value now
3964 EMACS_INT. All callers changed.
3965 (pint2hrstr): Last argument is now EMACS_INT.
3966
3967 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3968 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3969 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3970 (decode_coding_utf_16, decode_coding_emacs_mule)
3971 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3972 (decode_coding_ccl, decode_coding_charset)
3973 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3974 (decode_coding_iso_2022, decode_coding_emacs_mule)
3975 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3976 <char_offset, last_offset>: Declare EMACS_INT.
3977 (encode_coding_utf_8, encode_coding_utf_16)
3978 (encode_coding_emacs_mule, encode_invocation_designation)
3979 (encode_designation_at_bol, encode_coding_iso_2022)
3980 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3981 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3982 Declare EMACS_INT.
3983 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3984 (encode_invocation_designation): Last argument P_NCHARS is now
3985 EMACS_INT.
3986 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3987 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3988
3989 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3990 All users changed.
3991
3992 * ccl.c (Fccl_execute_on_string): Declare some variables
3993 EMACS_INT.
3994
8546720e 39952011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3996
3997 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3998
4e19a977
CS
39992011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4000
4001 * process.c (Fformat_network_address): Doc fix.
4002
87302331
R
40032011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4004
4005 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4006
cbb59342
CY
40072011-04-08 Chong Yidong <cyd@stupidchicken.com>
4008
4009 * keyboard.c (read_char): Call Lisp function help-form-show,
4010 instead of using internal_with_output_to_temp_buffer.
4011 (Qhelp_form_show): New var.
e0d38eeb 4012 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4013
4014 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4015
4016 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4017
e67a13ab
CY
40182011-04-06 Chong Yidong <cyd@stupidchicken.com>
4019
04f2d78b
CB
4020 * process.c (Flist_processes): Remove to Lisp.
4021 (list_processes_1): Delete.
e67a13ab 4022
973f782d
EZ
40232011-04-06 Eli Zaretskii <eliz@gnu.org>
4024
7c106b1e
EZ
4025 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4026
973f782d
EZ
4027 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4028
41cf7d1a 40292011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4030
ca23cc88
PE
4031 Fix more problems found by GCC 4.6.0's static checks.
4032
f390e2d5
PE
4033 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4034
42eea0d0
PE
4035 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4036
b69769da 4037 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4038
f9541e84
PE
4039 * xdisp.c (vmessage): Mark as a printf-like function.
4040
13841b55
PE
4041 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4042
c136c10f
PE
4043 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4044
5e2d4a30
PE
4045 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4046 printf-like functions.
4047 (tiff_load): Add casts to remove these marks before passing them
4048 to system-supplied API.
4049
583f48b9
PE
4050 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4051
b25d760e
PE
4052 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4053 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4054 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4055 directly, rather than having caller test rule sign. This avoids
4056 some unnecessary tests.
4057 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4058 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4059 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4060
bc7b6697 4061 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4062 (xfont_open): Avoid unnecessary tests.
bc7b6697 4063
27ccc379
PE
4064 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4065
dcd5c89a
PE
4066 * composite.h, composite.c (composition_gstring_put_cache):
4067 Use EMACS_INT, not int, for length.
4068
b13a45c6
PE
4069 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4070 breaking out part of COMPOSITION_DECODE_RULE.
4071 (COMPOSITION_DECODE_RULE): Use it.
4072 * composite.c (get_composition_id): Remove unused local vars,
4073 by using the new macro.
4074
1e792e4d
PE
4075 * textprop.c (set_text_properties_1): Change while to do-while,
4076 since the condition is always true at first.
4077
dc6c6455 4078 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4079 (interval_deletion_adjustment): Return unsigned value.
4080 All uses changed.
dc6c6455 4081
aba7731a
PE
4082 * process.c (list_processes_1, create_pty, read_process_output):
4083 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4084 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4085 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4086 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4087 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4088
fdfc4bf3
PE
4089 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4090
fca8fe46 4091 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4092 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4093
06a0259a 4094 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4095 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4096 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4097
e7b9e80f
PE
4098 * print.c (print_error_message): Avoid int overflow.
4099
56201685
PE
4100 * font.c (font_list_entities): Redo for clarity,
4101 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4102
78834453 4103 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4104 (font_score): Avoid potential overflow in diff calculation.
78834453 4105
0bc0b309 4106 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4107 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4108
e610eaca
PE
4109 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4110
b895abce
PE
4111 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4112 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4113 can always succeed if overflow has undefined behavior.
4114
1f1d9321 4115 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4116 (wordify): Omit three unnecessary tests.
1f1d9321 4117
c59478bc
PE
4118 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4119 All callers changed. This avoids the need for an unused var.
4120
79b73827
PE
4121 * casefiddle.c (casify_region): Remove var that is set but not used.
4122
a4db5dfe
PE
4123 * dired.c (file_name_completion): Remove var that is set but not used.
4124
43aae36e
PE
4125 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4126
2a47c44d 4127 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4128 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4129
a37c69bf
PE
4130 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4131 Check for integer overflow on size calculations.
4132
328ab8e7
PE
4133 * buffer.c (Fprevious_overlay_change): Remove var that is set
4134 but not used.
4135
e5a2a5cb
PE
4136 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4137 Remove vars that are set but not used.
8d84a6eb 4138 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4139 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4140
a60e5f68
PE
4141 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4142
f661cb61 4143 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4144 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4145
f0397f5a
PE
4146 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4147 that are set but not used.
4148
8664db06 4149 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4150 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4151
6abdaa4a
PE
4152 * xselect.c (x_get_local_selection, x_handle_property_notify):
4153 Remove vars that are set but not used.
4154
0ce7538d 4155 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4156 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4157
9ae848fc
PE
4158 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4159 Remove var that is set but not used.
0b918413
PE
4160 (scroll_bar_windows_size): Now size_t, not int.
4161 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4162 Check for overflow.
9ae848fc 4163
a5a62657
PE
4164 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4165 (map_tty_color) [!defined MSDOS]: Likewise.
4166
5c5cdd39
PE
4167 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4168
66ebf983
PE
4169 * coding.c: Remove vars that are set but not used.
4170 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4171 All callers changed.
4172 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4173 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4174 (decode_coding_charset): Remove vars that are set but not used.
4175
1be4d761
PE
4176 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4177 that is set but not used.
4178
47553fa8
PE
4179 * print.c (print_object): Remove var that is set but not used.
4180
1f7196bf 4181 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4182 The gnulib version avoids calling malloc in the usual case,
4183 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4184 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4185 * filelock.c (current_lock_owner): Likewise.
4186 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4187 * sysdep.c: Include allocator.h, careadlinkat.h.
4188 (emacs_no_realloc_allocator): New static constant.
4189 (emacs_readlink): New function.
fdb61804
PE
4190 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4191 ../lib/careadlinkat.h.
d1fdcab7 4192
f84c17c7
SM
41932011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4194
4195 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4196 first non-nil return value).
4197
ef3862ad
JD
41982011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4199
4200 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4201 if not defined (Bug#8403).
4202
376a7006
JB
42032011-04-02 Juanma Barranquero <lekktu@gmail.com>
4204
4205 * xdisp.c (display_count_lines): Remove parameter `start',
4206 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4207 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4208 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4209 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4210 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4211 and thereabouts. All callers changed.
4212 (get_per_char_metric): Remove parameter `f', unused since
4213 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4214
6ca3801d
JM
42152011-04-02 Jim Meyering <meyering@redhat.com>
4216
4217 do not dereference NULL upon failed strdup
4218 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4219 (ns_get_family): Likewise.
4220
d8e2b5ba
JB
42212011-04-02 Juanma Barranquero <lekktu@gmail.com>
4222
4223 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4224
8c74fcbd
JD
42252011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4226
4227 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4228 later (Bug#8403).
4229
7200d79c
SM
42302011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4231
03408648 4232 Add lexical binding.
7200d79c 4233
03408648
SM
4234 * window.c (Ftemp_output_buffer_show): New fun.
4235 (Fsave_window_excursion):
4236 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4237
4238 * lread.c (lisp_file_lexically_bound_p): New function.
4239 (Fload): Bind Qlexical_binding.
4240 (readevalloop): Remove `evalfun' arg.
4241 Bind Qinternal_interpreter_environment.
4242 (Feval_buffer): Bind Qlexical_binding.
4243 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4244 Mark as dynamic.
4245 (syms_of_lread): Declare `lexical-binding'.
4246
4247 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4248
4249 * keyboard.c (eval_dyn): New fun.
4250 (menu_item_eval_property): Use it.
ca105506
SM
4251
4252 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4253
03408648
SM
4254 * fns.c (concat, mapcar1): Accept byte-code-functions.
4255
4256 * eval.c (Fsetq): Handle lexical vars.
4257 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4258 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4259 (FletX, Flet): Obey lexical binding.
4260 (Fcommandp): Handle closures.
4261 (Feval): New `lexical' arg.
4262 (eval_sub): New function extracted from Feval. Use it almost
4263 everywhere where Feval was used. Look up vars in lexical env.
4264 Handle closures.
4265 (Ffunctionp): Move from subr.el.
4266 (Ffuncall): Handle closures.
4267 (apply_lambda): Remove `eval_flags'.
4268 (funcall_lambda): Handle closures and new byte-code-functions.
4269 (Fspecial_variable_p): New function.
4270 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4271 but without exporting it to Lisp.
23aba0ea 4272
23aba0ea 4273 * doc.c (Fdocumentation, store_function_docstring):
03408648 4274 * data.c (Finteractive_form): Handle closures.
23aba0ea 4275
03408648
SM
4276 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4277 interactive spec.
ba83908c 4278
04f2d78b
CB
4279 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4280 New byte-codes.
03408648
SM
4281 (exec_byte_code): New function extracted from Fbyte_code to handle new
4282 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4283
03408648 4284 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4285
03408648 4286 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4287
e2abce01
JB
42882011-03-31 Juanma Barranquero <lekktu@gmail.com>
4289
4290 * xdisp.c (redisplay_internal): Fix prototype.
4291
63696a73 42922011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4293
63696a73 4294 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4295 (try_scrolling): Use it when setting scroll_limit.
4296 Limit scrolling to 100 screen lines.
63696a73
EZ
4297 (redisplay_window): Even when falling back on "recentering",
4298 position point in the window according to scroll-conservatively,
4299 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4300
4301 (try_scrolling): When point is above the window, allow searching
4302 as far as scroll_max, or one screenful, to compute vertical
4303 distance from PT to the scroll margin position. This prevents
4304 try_scrolling from unnecessarily failing when
4305 scroll-conservatively is set to a value slightly larger than the
4306 window height. Clean up the case of PT below the margin at bottom
4307 of window: scroll_max can no longer be INT_MAX. When aggressive
4308 scrolling is in use, don't let point enter the opposite scroll
4309 margin as result of the scroll.
4310 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4311 threshold of 100 lines for never-recentering scrolling.
4312
e4cc2dfc
JB
43132011-03-31 Juanma Barranquero <lekktu@gmail.com>
4314
4315 * dispextern.h (move_it_by_lines):
4316 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4317 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4318 (message_log_check_duplicate): Remove parameters `prev_bol' and
4319 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4320 (redisplay_internal): Remove parameter `preserve_echo_area',
4321 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4322
4323 * indent.c (Fvertical_motion):
4324 * window.c (window_scroll_pixel_based, Frecenter):
4325 Don't pass `need_y_p' to `move_it_by_lines'.
4326
1c470562
SM
43272011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4328
44f230aa
SM
4329 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4330 steal a few bits to be more compact.
4331 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4332 Remove unneeded casts.
4333
1c470562
SM
4334 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4335
888adce9
ZK
43362011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4337
4338 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4339 binding" message (bug#7967).
4340
f838ed7b
PE
43412011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4342
77861b95
PE
4343 Fix more problems found by GCC 4.6.0's static checks.
4344
de6dbc14
PE
4345 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4346 Remove unused local var.
4347
f838ed7b
PE
4348 * editfns.c (Fmessage_box): Remove unused local var.
4349
792c7b2b
PE
4350 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4351 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4352 Omit unused local vars.
c499e557 4353 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4354 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4355 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4356 Omit unused local var.
4357
ba0165e1
PE
4358 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4359 Don't assume string length fits in int.
32ad8845 4360 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4361 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4362
3c59b4c9
PE
4363 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4364 instead of alloca (Bug#8344).
4365
a3eed478 4366 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4367 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4368
eb4d412d
PE
4369 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4370
1658b401
PE
4371 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4372 concerns.
4373
4374 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4375
4376 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4377
9a2c6e05
PE
4378 * keyboard.c (syms_of_keyboard): Use the same style as later
4379 in this function when indexing through an array. This also
4380 works around GCC bug 48267.
4381
03d0a109
PE
4382 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4383
44f730c8
PE
4384 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4385
fe75f926
PE
4386 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4387 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4388
ffa8c828
PE
4389 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4390 This avoids undefined behavior on integer overflow, and is a bit
4391 more convenient anyway since it is compared to a size_t variable.
4392
c5101a77
PE
4393 Variadic C functions now count arguments with size_t, not int.
4394 This avoids an unnecessary limitation on 64-bit machines, which
4395 caused (substring ...) to crash on large vectors (Bug#8344).
4396 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4397 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4398 All variadic functions and their callers changed accordingly.
c5101a77
PE
4399 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4400 * data.c (arith_driver, float_arith_driver): Likewise.
4401 * editfns.c (general_insert_function): Likewise.
4402 * eval.c (struct backtrace.nargs, interactive_p)
4403 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4404 (funcall_lambda, mark_backtrace): Likewise.
4405 * fns.c (concat): Likewise.
4406 * frame.c (x_set_frame_parameters): Likewise.
4407 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4408 0 if not found, not -1. All callers changed.
4409
dd3f25f7
PE
4410 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4411 (stack_copy_size): Now size_t, not int.
4412 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4413
461c2ab9
JB
44142011-03-28 Juanma Barranquero <lekktu@gmail.com>
4415
4416 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4417 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4418 All callers changed.
4419
4420 * lisp.h (multibyte_char_to_unibyte):
4421 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4422 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4423 * character.h (CHAR_TO_BYTE8):
4424 * cmds.c (internal_self_insert):
4425 * editfns.c (general_insert_function):
4426 * keymap.c (push_key_description):
4427 * search.c (Freplace_match):
4428 * xdisp.c (message_dolog, set_message_1): All callers changed.
4429
f6d62986
SM
44302011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4431
4432 * keyboard.c (safe_run_hook_funcall): New function.
4433 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4434 don't set the hook to nil, but remove the offending function instead.
4435 (Qcommand_hook_internal): Remove, unused.
4436 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4437 Vcommand_hook_internal.
4438
4439 * eval.c (enum run_hooks_condition): Remove.
4440 (funcall_nil, funcall_not): New functions.
4441 (run_hook_with_args): Call each function through a `funcall' argument.
4442 Remove `cond' argument, now redundant.
4443 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4444 (Frun_hook_with_args_until_failure): Adjust accordingly.
4445 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4446
1db5b1ad
JB
44472011-03-28 Juanma Barranquero <lekktu@gmail.com>
4448
4449 * dispextern.h (string_buffer_position): Remove declaration.
4450
4451 * print.c (strout): Remove parameter `multibyte', unused since
4452 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4453
4454 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4455 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4456 All callers changed.
4457
4458 * w32.c (_wsa_errlist): Use braces for struct initializers.
4459
4460 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4461 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4462 All callers changed.
4463 (string_buffer_position): Likewise. Also, make static (it's never
4464 used outside xdisp.c).
4465 (cursor_row_p): Remove parameter `w', unused since
4466 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4467 (decode_mode_spec): Remove parameter `precision', introduced during
4468 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4469 All callers changed.
4470
5ffb62aa
JD
44712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4472
4473 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4474
461c2ab9 44752011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4476
4477 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4478 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4479 (ns_update_auto_hide_menu_bar): New functions.
4480 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4481 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4482 ns_constrain_all_frames.
4483 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4484 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4485
5c380ffb
JD
44862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4487
4488 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4489
9af30bdf
GM
44902011-03-27 Glenn Morris <rgm@gnu.org>
4491
4492 * syssignal.h: Replace RETSIGTYPE with void.
4493 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4494 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4495 Replace SIGTYPE with void everywhere.
4496 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4497 * s/template.h (SIGTYPE): Remove commented out definition.
4498
e2abce01
JB
44992011-03-26 Eli Zaretskii <eliz@gnu.org>
4500
4501 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4502 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4503
f868cd8a
JB
45042011-03-26 Juanma Barranquero <lekktu@gmail.com>
4505
59eb0929
JB
4506 * w32.c (read_unc_volume): Use parameter `henum', instead of
4507 global variable `wget_enum_handle'.
4508
4509 * keymap.c (describe_vector): Remove parameters `indices' and
4510 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4511 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4512
f868cd8a
JB
4513 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4514
4515 * keyboard.c (timer_check): Remove parameter `do_it_now',
4516 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4517 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4518 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4519
4520 * keyboard.c (read_char):
4521 * w32menu.c (w32_menu_display_help):
4522 * xmenu.c (show_help_event, menu_help_callback):
4523 Adjust calls to `show_help_echo'.
4524
4525 * gtkutil.c (xg_maybe_add_timer):
4526 * keyboard.c (readable_events):
4527 * process.c (wait_reading_process_output):
4528 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4529
4530 * insdel.c (adjust_markers_gap_motion):
4531 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4532 (gap_left, gap_right): Don't call it.
4533
2ecf6fdb
CY
45342011-03-25 Chong Yidong <cyd@stupidchicken.com>
4535
4536 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4537 incurred during fontification.
4538
6b1f9ba4
JB
45392011-03-25 Juanma Barranquero <lekktu@gmail.com>
4540
4541 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4542 (DEFVAR_PER_BUFFER): Don't pass it.
4543
4544 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4545 (scrolling_window): Don't pass it.
4546
0f4a96b5
JB
45472011-03-25 Juanma Barranquero <lekktu@gmail.com>
4548
4549 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4550
4551 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4552 and `suffix'.
4553 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4554 of variables specific to SELinux and computation of `encoded_absname'.
4555
4556 * image.c (XPutPixel): Remove unused variable `height'.
4557
4558 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4559
4560 * unexw32.c (get_section_info): Remove unused variable `section'.
4561
4562 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4563 (system_process_attributes): Remove unused variable `sess'.
4564 (sys_read): Remove unused variable `err'.
4565
4566 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4567 (w32_wnd_proc): Remove unused variable `isdead'.
4568 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4569 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4570 (x_create_tip_frame): Remove unused variable `tem'.
4571
4572 * w32inevt.c (w32_console_read_socket):
4573 Remove unused variable `no_events'.
4574
4575 * w32term.c (x_draw_composite_glyph_string_foreground):
4576 Remove unused variable `width'.
4577
1149507c
JB
45782011-03-24 Juanma Barranquero <lekktu@gmail.com>
4579
4580 * w32term.c (x_set_glyph_string_clipping):
4581 Don't pass uninitialized region to CombineRgn.
4582
9c88f339
JB
45832011-03-23 Juanma Barranquero <lekktu@gmail.com>
4584
4585 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4586 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4587 (Fx_close_connection): Remove unused variable `i'.
4588
4589 * w32font.c (w32font_draw): Return number of glyphs.
4590 (w32font_open_internal): Remove unused variable `i'.
4591 (w32font_driver): Add missing initializer.
4592
4593 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4594 (fill_in_menu): Remove unused variable `items_added'.
4595
4596 * w32term.c (last_mouse_press_frame): Remove static global variable.
4597 (w32_clip_to_row): Remove unused variable `f'.
4598 (x_delete_terminal): Remove unused variable `i'.
4599
4600 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4601 (NOTHING): Remove unused static global variable.
4602 (uniscribe_check_otf): Remove unused variable `table'.
4603 (uniscribe_font_driver): Add missing initializers.
4604
dee091a3
JD
46052011-03-23 Julien Danjou <julien@danjou.info>
4606
4607 * term.c (Fsuspend_tty, Fresume_tty):
4608 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4609 * window.c (temp_output_buffer_show):
4610 * insdel.c (signal_before_change):
4611 * frame.c (Fhandle_switch_frame):
4612 * fileio.c (Fdo_auto_save):
4613 * emacs.c (Fkill_emacs):
4614 * editfns.c (save_excursion_restore):
4615 * cmds.c (internal_self_insert):
4616 * callint.c (Fcall_interactively):
4617 * buffer.c (Fkill_all_local_variables):
4618 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4619 Use Frun_hooks.
0f4a96b5 4620 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4621 unconditionnaly since it does the check itself.
4622
2c520ab5 46232011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4624
c9c49752
PE
4625 Fix more problems found by GCC 4.5.2's static checks.
4626
8abc3f12
PE
4627 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4628 the first time through the loop, since we know p0 < p1 then.
4629 This also avoids a gcc -Wstrict-overflow warning.
4630
a2d26660
PE
4631 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4632 leading to a memory leak, possible in functions like
4633 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4634 of objects (Bug#8318).
a2d26660 4635
916c72e9
PE
4636 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4637 that could (at least in theory) be that large.
4638
19ab8a18
PE
4639 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4640 This is less likely to overflow, and avoids undefined behavior if
4641 overflow does occur. All callers changed. Use strtoul to scan
4642 for the unsigned long integer.
b7cbbd6f
PE
4643 (pint2hrstr): Simplify and tune code slightly.
4644 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4645
f0641eff
PE
4646 * scroll.c (do_scrolling): Work around GCC bug 48228.
4647 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4648
7f650bb9
PE
4649 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4650 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4651 (validate_x_resource_name): Simplify count usage.
4652 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4653
37dd57d1
PE
4654 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4655 fail (Bug#8306).
81e56e61 4656
699979fc 4657 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4658
401bf9b4
PE
4659 * process.c (Fmake_network_process): Use socklen_t, not int,
4660 where POSIX says socklen_t is required in portable programs.
4661 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4662 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4663 (Fmake_network_process, server_accept_connection):
4664 (wait_reading_process_output, read_process_output):
4665 Likewise.
4666
b93aacde
PE
4667 * process.c: Rename or move locals to avoid shadowing.
4668 (list_processes_1, Fmake_network_process):
4669 (read_process_output_error_handler, exec_sentinel_error_handler):
4670 Rename or move locals.
4dc343ee 4671 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4672 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4673 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4674 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4675 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4676
af8a867c 4677 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4678 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4679 Include tparam.h instead, since it declares them.
af8a867c
PE
4680 * cm.h (PC): Remove extern decl; tparam.h now does this.
4681 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4682 * terminfo.c: Include tparam.h, to check interfaces.
4683 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4684 (tparam): Adjust signature to match interface in tparam.h;
4685 this removes some undefined behavior. Check that outstring and len
4686 are zero, which they always are with Emacs.
4687 * tparam.h (PC, BC, UP): New extern decls.
4688
0248044d 4689 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4690 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4691
8ff096c1 4692 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4693 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4694 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4695 (ftfont_list): Remove unused local.
49eaafba
PE
4696 (get_adstyle_property, ftfont_pattern_entity):
4697 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4698 Rename locals to avoid shadowing.
8ff096c1 4699
e2be39f6
PE
4700 * xfont.c (xfont_list_family): Mark var as initialized.
4701
c9735e30
PE
4702 * xml.c (make_dom): Now static.
4703
8f5201ae
PE
4704 * composite.c (composition_compute_stop_pos): Rename local to
4705 avoid shadowing.
b246f932
PE
4706 (composition_reseat_it): Remove unused locals.
4707 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4708 (composition_update_it): Mark var as initialized.
11b61122
PE
4709 (find_automatic_composition): Mark vars as initialized,
4710 with a FIXME (Bug#8290).
8f5201ae 4711
760fbc2c
PE
4712 character.h: Rename locals to avoid shadowing.
4713 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4714 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4715 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4716 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4717 to avoid shadowing.
4718
ff08eb85
PE
4719 * textprop.c (property_change_between_p): Remove; unused.
4720
fc7bf025
PE
4721 * intervals.c (interval_start_pos): Now static.
4722
235d7abc
PE
4723 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4724
44f230aa
SM
4725 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4726 Rename locals to avoid shadowing.
3e7d6594 4727
50060332
PE
4728 * sound.c (wav_play, au_play, Fplay_sound_internal):
4729 Fix pointer signedness.
d01f234b 4730 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4731 (wav_play): Initialize a variable to 0, to prevent undefined
4732 behavior (Bug#8278).
50060332 4733
c4fc4e30
PE
4734 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4735
918436ed
PE
4736 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4737
c939f91b
PE
4738 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4739 clobbering (Bug#8298).
b9c7f648
PE
4740 * sysdep.c (sys_subshell): Likewise.
4741 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4742
6bd8c144
PE
4743 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4744 This should get cleaned up, so that child_setup has the
4745 same signature on all platforms.
4746
7710357c 4747 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4748 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4749
c59da222
CY
47502011-03-22 Chong Yidong <cyd@stupidchicken.com>
4751
4752 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4753 not to be necessary, and produces flickering.
4754
66b87493
GM
47552011-03-20 Glenn Morris <rgm@gnu.org>
4756
4757 * config.in: Remove file.
4758
45b6f6d5
JB
47592011-03-20 Juanma Barranquero <lekktu@gmail.com>
4760
4761 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4762 are now in src/globals.h.
4763 (syms_of_minibuf): Remove spurious & from previous change.
4764
3ec03f7e
LL
47652011-03-20 Leo <sdl.web@gmail.com>
4766
4767 * minibuf.c (completing-read-function): New variable.
4768 (completing-read-default): Rename from completing-read.
4769 (completing-read): Call completing-read-function.
4770
b14e3e21
CY
47712011-03-19 Juanma Barranquero <lekktu@gmail.com>
4772
4773 * xfaces.c (Fx_load_color_file):
4774 Read color file from absolute filename (bug#8250).
4775
f2b726e6
JB
47762011-03-19 Juanma Barranquero <lekktu@gmail.com>
4777
4778 * makefile.w32-in: Update dependencies.
4779
09f6ff02
EZ
47802011-03-17 Eli Zaretskii <eliz@gnu.org>
4781
4782 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4783
29a6015a
PE
47842011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4785
a3a6c54e
PE
4786 Fix more problems found by GCC 4.5.2's static checks.
4787
b766f867
PE
4788 * process.c (make_serial_process_unwind, send_process_trap):
4789 (sigchld_handler): Now static.
4790
be02381c
PE
4791 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4792 That way, the code declares only the vars that it needs.
4793 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4794 * s/cygwin.h (PTY_ITERATION): Likewise.
4795 * s/darwin.h (PTY_ITERATION): Likewise.
4796 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4797
57048744
PE
4798 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4799 * process.c (allocate_pty): Don't declare stb unless it's needed.
4800
7914961c 4801 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4802 (CONSTANTLIM): Remove; unused.
4803 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4804 Define only if needed.
7914961c 4805
b3967b18
PE
4806 * unexelf.c (unexec): Name an expression,
4807 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4808 Use a different way to cause a compilation error if anyone uses
4809 n rather than nn, a way that does not involve shadowing.
73366a00 4810 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4811
29a6015a
PE
4812 * deps.mk (unexalpha.o): Remove; unused.
4813
43cfc33e 4814 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4815 * unexec.h: New file.
ce701a33
PE
4816 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4817 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4818 Depend on unexec.h.
4819 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4820 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4821 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4822 Change as necessary to match prototype in unexec.h.
ce701a33 4823
01f44d5a
PE
4824 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4825 shadowing.
4f63c6bb 4826 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4827
a6670b0b
PE
4828 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4829 Rename locals to avoid shadowing.
4830
cef2010d 4831 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4832 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4833
d4d7173a
PE
4834 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4835
f08b802a
PE
4836 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4837 warning when compiling print.c.
4838
3ddb0639
PE
4839 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4840 instead of using an uninitialized var.
5ad03b97 4841 (font_sort_entities): Mark var as initialized.
3ddb0639 4842
170a2692
PE
4843 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4844
e663c700
PE
4845 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4846 pointers to constants.
89bc529a 4847 (font_parse_fcname): Remove unused vars.
7b81e2d0 4848 (font_delete_unmatched): Now static.
ea838e10 4849 (font_get_spec): Remove; unused.
13a547c6
PE
4850 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4851 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4852 Rename or move locals to avoid shadowing.
e663c700 4853
2a80c887 4854 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4855 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4856
1384fa33 4857 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4858 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4859
8b2c52e9
PE
4860 * alloc.c (mark_backtrace): Move decl from here ...
4861 * lisp.h: ... to here, so that it can be checked.
4862
475545b5 4863 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4864 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4865 (lisp_indirect_variable): Name an expression,
4866 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4867 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4868
b1349114 4869 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4870 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4871 Use const pointer when appropriate.
b1349114 4872
a2928364
PE
4873 * lisp.h (get_system_name, get_operating_system_release):
4874 Move decls here, to check interfaces.
4875 * process.c (get_operating_system_release): Move decl to lisp.h.
4876 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4877 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4878 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4879 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4880 (Fformat_time_string, Fencode_time, Finsert_char):
4881 (Ftranslate_region_internal, Fformat):
4882 Rename or remove local vars to avoid shadowing.
9710023e 4883 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4884
a415e694
PE
4885 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4886 avoid shadowing.
4887
8ef4622d
PE
4888 * lisp.h (eassert): Check that the argument compiles, even if
4889 ENABLE_CHECKING is not defined.
4890
946f9a5b
PE
4891 * data.c (Findirect_variable): Name an expression, to avoid
4892 gcc -Wbad-function-cast warning.
112396d6 4893 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4894 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4895 (Fmake_variable_buffer_local, Fmake_local_variable):
4896 Mark variables as initialized.
52746918 4897 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4898
e5aab7e7 4899 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4900 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4901 Rename locals to avoid shadowing.
dff45157
PE
4902 (mark_stack): Move local variables into the #ifdef region where
4903 they're used.
7bc26fdb
PE
4904 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4905 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4906 needed otherwise.
4907 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4908 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4909 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4910
e5aab7e7
PE
4911 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4912 avoids undefined behavior in theory.
4913
4da60324
PE
4914 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4915
88043301
PE
4916 Use functions, not macros, for up- and down-casing (Bug#8254).
4917 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4918 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4919 to use the following functions instead of these macros.
4920 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4921 EMACS_INT, since callers assume the returned value fits in int.
4922 (upcase1): Likewise, for UPCASE_TABLE.
4923 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4924 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4925 the race-condition problem in the old DOWNCASE.
88043301 4926
19ed5445
PE
4927 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4928 Rename locals to avoid shadowing.
4929 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4930 (regex_compile, re_search_2, re_match_2_internal):
4931 Remove unused local vars.
952db0d7
PE
4932 (FREE_VAR): Rewrite so as not to use empty "else",
4933 which gcc can warn about.
da053e48 4934 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4935 (RETALLOC_IF): Define only if needed.
4936 (WORDCHAR_P): Likewise. This one is never needed, but is used
4937 only in a comment talking about a compiler bug, so put inside
4938 the #if 0 of that comment.
4939 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4940 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4941 Remove; unused.
19ed5445 4942
1f3561e4 4943 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4944 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4945 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4946
ded6f8f7
PE
4947 * search.c (simple_search): Remove unused var.
4948
dbd37a95
PE
4949 * dired.c (compile_pattern): Move decl from here ...
4950 * lisp.h: ... to here, so that it can be checked.
4951 (struct re_registers): New forward decl.
4952
7e47afad
PE
4953 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4954
85f24f61
PE
4955 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4956 All uses changed.
4957 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4958 Rename locals to avoid shadowing.
5671df8f 4959 (Fvertical_motion): Mark locals as initialized.
85f24f61 4960
181aa2be 4961 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4962 (casify_region): Mark local as initialized.
181aa2be 4963
930d429c
PE
4964 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4965
7082eac6
PE
4966 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4967 New macros, so that the caller can use some names other than
4968 gcpro1, gcpro2, etc.
4969 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4970 of the new macros.
4971 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4972 argument, for consistency with GCPRO2_VAR, etc: it is now the
4973 prefix of the variable, not the variable itself. All uses
4974 changed.
38b2c076
PE
4975 * dired.c (directory_files_internal, file_name_completion):
4976 Rename locals to avoid shadowing.
4977
15206ed9
PE
4978 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4979 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4980 dired.c's scmp function, had undefined behavior.
4981 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4982 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4983 * buffer.h: ... to here, because these macros use current_buffer,
4984 and the new implementation with inline functions needs to have
4985 current_buffer in scope now, rather than later when the macros
4986 are used.
4987 (downcase, upcase1): New static inline functions.
4988 (DOWNCASE, UPCASE1): Reimplement using these functions.
4989 This avoids undefined behavior in expressions like
4990 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4991 from race conditions in accessing the global variables
4992 case_temp1 and case_temp2.
4993 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4994 * lisp.h (case_temp1, case_temp2): Remove their decls.
4995 * character.h (ASCII_CHAR_P): Move from here ...
4996 * lisp.h: ... to here, so that the inline functions mentioned
4997 above can use them.
4998
4a6bea26
PE
4999 * dired.c (directory_files_internal_unwind): Now static.
5000
f14b7e14
PE
5001 * fileio.c (file_name_as_directory, directory_file_name):
5002 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5003 Now static.
2893f146
PE
5004 (file_name_as_directory): Use const pointers when appropriate.
5005 (Fexpand_file_name): Likewise. In particular, newdir might
5006 point at constant storage, so make it a const pointer.
fd4ead52 5007 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5008 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5009 signedness issues.
f839df0c
PE
5010 (Fset_file_times, Finsert_file_contents, auto_save_error):
5011 Rename locals to avoid shadowing.
f14b7e14 5012
5716756e 5013 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5014 (Ftry_completion, Fall_completions): Rename or remove locals
5015 to avoid shadowing.
5716756e 5016
b4c3046a
PE
5017 * marker.c (bytepos_to_charpos): Remove; unused.
5018
b45db522
PE
5019 * lisp.h (verify_bytepos, count_markers): New decls,
5020 so that gcc does not warn that these functions aren't declared.
5021
85876d07
PE
5022 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5023 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5024 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5025 (copy_text): Remove unused local var.
85876d07 5026
03d78a21 5027 * filelock.c (within_one_second): Now static.
b3dd38ab 5028 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5029
5df8f01b
PE
5030 * buffer.c (fix_overlays_before): Mark locals as initialized.
5031 (fix_start_end_in_overlays): Likewise. This function should be
5032 simplified by using pointers-to-pointers, but that's a different
5033 matter.
b1d876f1 5034 (switch_to_buffer_1): Now static.
8f54f30a
PE
5035 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5036 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5037
a70072c9 5038 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5039 Fix pointer signedness issue.
edced198
PE
5040 (sys_subshell): Mark local as volatile if checking for lint,
5041 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5042 (MAXPATHLEN): Define only if needed.
a70072c9 5043
a0977c44
PE
5044 * process.c (serial_open, serial_configure): Move decls from here ...
5045 * systty.h: ... to here, so that they can be checked.
5046
a884fdcc
PE
5047 * fns.c (get_random, seed_random): Move extern decls from here ...
5048 * lisp.h: ... to here, so that they can be checked.
5049
604efe86 5050 * sysdep.c (reset_io): Now static.
b8950c94 5051 (wait_for_termination_signal): Remove; unused.
604efe86 5052
38fc62d9
PE
5053 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5054 (copy_keymap_item, append_key, push_text_char_description):
5055 Now static.
1004a21a 5056 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5057 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5058 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5059 (describe_map_tree):
5060 Rename locals to avoid shadowing.
38fc62d9 5061
2f2650da
PE
5062 * keyboard.c: Declare functions static if they are not used elsewhere.
5063 (echo_char, echo_dash, cmd_error, top_level_2):
5064 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5065 (read_char, kbd_buffer_get_event, make_lispy_position):
5066 (make_lispy_event, make_lispy_movement, apply_modifiers):
5067 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5068 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5069 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5070 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5071 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5072
a053e86c 5073 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5074 (mark_kboards): Move decl here ...
5075 * alloc.c (mark_kboards): ... from here.
a053e86c 5076
4752793e
PE
5077 * lisp.h (force_auto_save_soon): New decl.
5078
74f10ca7 5079 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5080 (DEFINE_DUMMY_FUNCTION): New macro.
5081 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5082 Use it.
c03cd23f
PE
5083 (main): Add casts to avoid warnings
5084 if GCC considers string literals to be constants.
74f10ca7 5085
022e70d4
PE
5086 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5087
59d6fe83
PE
5088 * dbusbind.c: Pointer signedness fixes.
5089 (xd_signature, xd_append_arg, xd_initialize):
5090 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5091 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5092 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5093 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5094
78320123
PE
5095 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5096 if GCC considers string literals to be constants.
49cebcca 5097 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5098
35ac2a97
SM
50992011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5100
fb103ca9
SM
5101 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5102 (print_preprocess, print_object): New macro to fix last change.
5103
35ac2a97
SM
5104 * print.c (print_preprocess): Don't forget font objects.
5105
62973b41
JB
51062011-03-16 Juanma Barranquero <lekktu@gmail.com>
5107
5108 * emacs.c (USAGE3): Doc fixes.
5109
0e48bb22
AS
51102011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5111
5112 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5113 structure.
5114
7684e57b
JB
51152011-03-14 Juanma Barranquero <lekktu@gmail.com>
5116
5117 * lisp.h (VWindow_system, Qfile_name_history):
5118 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5119 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5120 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5121
5122 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5123 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5124
5125 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5126 * w32console.c (detect_input_pending, read_input_pending)
5127 (encode_terminal_code):
5128 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5129 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5130 (w32_system_caret_y, Qfile_name_history):
5131 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5132 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5133 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5134 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5135 * w32proc.c (Qlocal, report_file_error):
5136 * w32term.c (Vwindow_system, updating_frame):
5137 * w32uniscribe.c (initialized, uniscribe_font_driver):
5138 Remove unneeded extern declarations.
5139
2aa46d6c
CY
51402011-03-14 Chong Yidong <cyd@stupidchicken.com>
5141
c96bbc66 5142 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5143
cffc6f3b
CY
51442011-03-13 Chong Yidong <cyd@stupidchicken.com>
5145
5146 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5147 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5148 These macros can no longer be used for assignment.
5149
44f230aa
SM
5150 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5151 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5152 (record_buffer_markers, fetch_buffer_markers): New functions for
5153 recording and fetching special buffer markers.
5154 (set_buffer_internal_1, set_buffer_temp): Use them.
5155
5156 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5157
5158 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5159
5160 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5161 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5162
5163 * xdisp.c (hscroll_window_tree):
5164 (reconsider_clip_changes): Use PT instead of BUF_PT.
5165
d251f04b
EZ
51662011-03-13 Eli Zaretskii <eliz@gnu.org>
5167
5168 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5169 $(EMACS_ROOT)/lib/intprops.h.
5170
f0c77cd1
PE
51712011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5172
3eca4629
PE
5173 Fix more problems found by GCC 4.5.2's static checks.
5174
7c86ee98
PE
5175 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5176 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5177 (xg_free_frame_widgets): Make it clear that a local variable is
5178 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5179 (gdk_window_get_screen): Make it clear that this macro is needed
5180 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5181 (int_gtk_range_get_value): New function, which avoids a diagnostic
5182 from gcc -Wbad-function-cast.
5183 (xg_set_toolkit_scroll_bar_thumb): Use it.
5184 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5185 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5186 (get_utf8_string, xg_get_file_with_chooser):
5187 Rename locals to avoid shadowing.
5188 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5189
41729b81
PE
5190 * xgselect.c (xg_select): Remove unused var.
5191
f0c77cd1
PE
5192 * image.c (four_corners_best): Mark locals as initialized.
5193 (gif_load): Initialize transparent_p to zero (Bug#8238).
5194 Mark another local as initialized.
ec6cf4c6 5195 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5196
ce0ad53d 5197 * image.c (clear_image_cache): Now static.
d5d5a617 5198 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5199 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5200 (x_edge_detection): Remove unnecessary cast that
5201 gcc -Wbad-function-cast diagnoses.
2037898d 5202 (gif_load): Fix pointer signedness.
6ae141d6
PE
5203 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5204 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5205
33383987 52062011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5207
d32df629
PE
5208 Improve quality of tests for time stamp overflow.
5209 For example, without this patch (encode-time 0 0 0 1 1
5210 1152921504606846976) returns the obviously-bogus value (-948597
5211 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5212 reports time overflow. See
5213 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5214 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5215 * editfns.c: Include limits.h and intprops.h.
5216 (TIME_T_MIN, TIME_T_MAX): New macros.
5217 (time_overflow): Move earlier, to before first use.
5218 (hi_time, lo_time): New functions, for an accurate test for
5219 out-of-range times.
5220 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5221 (Fget_internal_run_time): Don't assume time_t fits in int.
5222 (make_time): Use list2 instead of Fcons twice.
5223 (Fdecode_time): More accurate test for out-of-range times.
5224 (check_tm_member): New function.
5225 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5226 (lisp_time_argument): Don't rely on undefined left-shift and
5227 right-shift behavior when checking for time stamp overflow.
8be6f318 5228
fe31d94c
PE
5229 * editfns.c (time_overflow): New function, refactoring common code.
5230 (Fformat_time_string, Fdecode_time, Fencode_time):
5231 (Fcurrent_time_string): Use it.
5232
8be6f318
PE
5233 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5234 * dired.c (make_time): Move to ...
5235 * editfns.c (make_time): ... here.
5236 * systime.h: Note the move.
5237
09d9db2c 52382011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5239
126bc0dc
YM
5240 * fringe.c (update_window_fringes): Remove unused variables.
5241
c47cbdfd
YM
5242 * unexmacosx.c (copy_data_segment): Also copy __got section.
5243 (Bug#8223)
5244
7ac80be9
EZ
52452011-03-12 Eli Zaretskii <eliz@gnu.org>
5246
c96bbc66 5247 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5248 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5249 Constify `char *' arguments and their references according to
5250 prototypes in tparam.h.
5251
ecb0f94d 5252 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5253
7ac80be9
EZ
5254 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5255 Adapt all references accordingly.
5256
5257 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5258
ef1fd07e
TT
52592011-03-11 Tom Tromey <tromey@redhat.com>
5260
5261 * buffer.c (syms_of_buffer): Remove obsolete comment.
5262
7ef4b50c
EZ
52632011-03-11 Eli Zaretskii <eliz@gnu.org>
5264
5265 * termhooks.h (encode_terminal_code): Declare prototype.
5266
5267 * msdos.c (encode_terminal_code): Don't declare prototype.
5268
5269 * term.c (encode_terminal_code): Now external again, used by
5270 w32console.c and msdos.c.
5271
44f230aa
SM
5272 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5273 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5274
4b1ec863 52752011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5276
1714f52b 5277 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5278
4b1ec863
PE
5279 * fringe.c (update_window_fringes): Mark locals as initialized
5280 (Bug#8227).
5281 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5282
524c7aa6
PE
5283 * alloc.c (mark_fringe_data): Move decl from here ...
5284 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5285 to check its interface.
5286 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5287
a5c0af81 5288 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5289 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5290 (fontset_font): Mark local as initialized.
a9a06e0b 5291 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5292
b4716021
PE
5293 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5294
811e9bac 5295 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5296 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5297 (x_own_selection, Fx_disown_selection_internal): Rename locals
5298 to avoid shadowing.
5299 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5300
7e3ab302
PE
5301 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5302 so that the caller can use some name other than gcpro1.
5303 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5304 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5305 (Fx_backspace_delete_keys_p):
5306 Use them to avoid shadowing, and rename vars to avoid shadowing.
5307 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5308 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5309 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5310 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5311 Remove unused locals.
7e3ab302
PE
5312 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5313 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5314 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5315 macros.
f78faa98 5316
e2b13473
PE
5317 * xterm.h (x_mouse_leave): New decl.
5318
77f23912
PE
5319 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5320 Remove unused functions.
cdf4ba58
PE
5321 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5322 (x_calc_absolute_position): Now static.
7411c686 5323 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5324 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5325 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5326 unless they are used.
38d0b34a
PE
5327 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5328 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5329 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5330 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5331 (x_error_catcher, x_connection_closed, x_error_handler):
5332 (x_error_quitter, xembed_send_message, x_iconify_frame):
5333 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5334 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5335 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5336
44f230aa
SM
5337 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5338 Rename or move locals to avoid shadowing.
6b463e58 5339 (tty_defined_color, merge_face_heights): Now static.
5967d051 5340 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5341 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5342 does not deduce is never used uninitialized.
73719eba
PE
5343 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5344 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5345
426994c3 5346 * terminal.c (store_terminal_param): Now static.
5489860b 5347
032f1620 5348 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5349 (set_frame_menubar): Remove unused local.
d4323972 5350 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5351 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5352 since they might point to immutable storage.
281585b0
PE
5353 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5354 since it's unused otherwise.
032f1620 5355
367c19e5 5356 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5357 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5358 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5359 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5360 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5361 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5362 does not deduce are never used uninitialized.
70739cbe 5363
07b48fa9
PE
5364 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5365
8868a238 5366 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5367 * window.c (window_loop, size_window):
5368 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5369
7e5cf297 5370 * window.c (display_buffer): Now static.
d6550a9f
PE
5371 (size_window): Mark variables that gcc -Wuninitialized
5372 does not deduce are never used uninitialized.
a586633d
PE
5373 * window.h (check_all_windows): New decl, to forestall
5374 gcc -Wmissing-prototypes diagnostic.
5b555da1 5375 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5376
f6095868
PE
5377 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5378 shadowing.
5379 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5380 Include <limits.h>.
5381 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5382 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5383 (load_charset_map): Mark variables that gcc -Wuninitialized
5384 does not deduce are never used uninitialized.
53df7c11 5385 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5386
f38b440c
PE
5387 * coding.c (coding_set_source, coding_set_destination):
5388 Use "else { /* comment */ }" rather than "else /* comment */;"
5389 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5390 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5391 a block, when the outer 'i' will do.
5392 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5393 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5394 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5395 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5396 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5397 Rename locals to avoid shadowing.
5398 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5399 * coding.c (emacs_mule_char, encode_invocation_designation):
5400 Now static, since they're not used elsewhere.
413bb2db 5401 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5402 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5403 (decode_coding_emacs_mule): Mark variables that gcc
5404 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5405 (detect_coding_iso_2022): Initialize a local variable that might
5406 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5407 this initialization is needed. (Bug#8211)
5f58e762
PE
5408 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5409 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5410 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5411 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5412 Remove unused macros.
f38b440c 5413
232b38b9 5414 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5415 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5416 * character.c (string_count_byte8): Likewise.
232b38b9 5417
fb90da1b
PE
5418 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5419 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5420
fb93dbc2
PE
5421 * chartab.c (copy_sub_char_table): Now static, since it's not used
5422 elsewhere.
5c156ace
PE
5423 (sub_char_table_ref_and_range, char_table_ref_and_range):
5424 Rename locals to avoid shadowing.
bbcd0949 5425 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5426
7d3b3862 5427 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5428 (BIDI_BOB): Remove unused macro.
7d3b3862 5429
6be7d3da
PE
5430 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5431 deduce are never used uninitialized.
c2ed9c8b 5432 * term.c (encode_terminal_code): Likewise.
6be7d3da 5433
75f8807f 5434 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5435
50938595
PE
5436 * tparam.h: New file.
5437 * term.c, tparam.h: Include it.
5438 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5439 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5440 Move these decls to tparam.h, and make them agree with what
5441 is actually in tparam.c. The previous trick of using incompatible
5442 decls in different modules does not conform to the C standard.
5443 All callers of tparam changed to use tparam's actual API.
5444 * tparam.c (tparam1, tparam, tgoto):
5445 Use const pointers where appropriate.
5446
fbceeba2
PE
5447 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5448 * cm.h (struct cm): Likewise.
5449 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5450 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5451 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5452 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5453 (turn_on_face, init_tty): Likewise.
5454 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5455
7f3f1250
PE
5456 * term.c (term_mouse_position): Rename local to avoid shadowing.
5457
e6ca6543
PE
5458 * alloc.c (mark_ttys): Move decl from here ...
5459 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5460
c40f8d15
AS
54612011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5462
5463 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5464
cfe0661d
JB
54652011-03-09 Juanma Barranquero <lekktu@gmail.com>
5466
5467 * search.c (compile_pattern_1): Remove argument regp, unused since
5468 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5469 (compile_pattern): Don't pass it.
5470
0afb4571
J
54712011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5472
5473 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5474 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5475 for ! HAVE_GTK3.
5476 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5477
5478 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5479
5480 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5481 gdk_window_get_screen, gdk_window_get_geometry,
5482 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5483 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5484 (xg_get_pixbuf_from_pixmap): New function.
5485 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5486 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5487 Call xg_get_pixbuf_from_pixmap instead of
5488 gdk_pixbuf_get_from_drawable.
5489 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5490 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5491 (xg_check_special_colors): Use GtkStyleContext and its functions
5492 for HAVE_GTK3.
5493 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5494 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5495 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5496 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5497 Call gtk_widget_get_preferred_size.
0afb4571
J
5498 (xg_frame_resized): gdk_window_get_geometry only takes 5
5499 parameters.
44f230aa
SM
5500 (xg_win_to_widget, xg_event_is_for_menubar):
5501 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5502 (xg_set_widget_bg): New function.
5503 (delete_cb): New function.
895009e1 5504 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5505 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5506 (xg_set_background_color): Call xg_set_widget_bg.
5507 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5508 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5509 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5510 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5511 if ! HAVE_GTK3.
5512 (update_frame_tool_bar): Call gtk_widget_hide.
5513 (xg_initialize): Use GDK_KEY_g.
5514
5515 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5516 if ! HAVE_GTK3
5517 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5518
5519 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5520 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5521 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5522
1c2cc4ef
JB
55232011-03-08 Juanma Barranquero <lekktu@gmail.com>
5524
5525 * w32xfns.c (select_palette): Check success of RealizePalette against
5526 GDI_ERROR, not zero.
5527
33383987 5528See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5529
5530;; Local Variables:
5531;; coding: utf-8
aac0c6e3
MR
5532;; End:
5533
33383987 5534 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5535
5536 This file is part of GNU Emacs.
5537
5538 GNU Emacs is free software: you can redistribute it and/or modify
5539 it under the terms of the GNU General Public License as published by
5540 the Free Software Foundation, either version 3 of the License, or
5541 (at your option) any later version.
5542
5543 GNU Emacs is distributed in the hope that it will be useful,
5544 but WITHOUT ANY WARRANTY; without even the implied warranty of
5545 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5546 GNU General Public License for more details.
5547
5548 You should have received a copy of the GNU General Public License
5549 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.