* gtkutil.c (get_utf8_string): Remove redundant assignment.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b3b4476b
PE
12012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2
4495ff38
PE
3 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4 sprintf already null-terminates its output.
5
b3b4476b
PE
6 * xfns.c (x_window): Remove redundant cast.
7
b00876c9
DA
82012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
9
10 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
11 `const char *' to `char *' to avoid compiler warning.
12
d188e26b
PE
132012-06-24 Paul Eggert <eggert@cs.ucla.edu>
14
885d1d74
PE
15 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
16 instead of truncating it to 63 (admittedly a generous limit).
17
d188e26b
PE
18 * process.c: Fix spelling and caps in comments.
19
e2f560b1
DN
202012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
21
e86db54b 22 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
23 * sysdep.c (setpgrp): Remove definition, not used in this file.
24
7583a3a1
JB
252012-06-24 Juanma Barranquero <lekktu@gmail.com>
26
27 * makefile.w32-in: Update dependencies.
28
696056c2
EZ
292012-06-24 Eli Zaretskii <eliz@gnu.org>
30
31 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
32 (SYSTIME_H): Add nt/inc/sys/time.h.
33
34 * systime.h [WINDOWSNT]: Include sys/time.h.
35
36 * s/ms-w32.h (struct timespec): Definition moved from
37 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
38
845ca893
PE
392012-06-24 Paul Eggert <eggert@cs.ucla.edu>
40
41 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
42 * buffer.h (buffer_slot_type_mismatch):
43 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
44 * eval.c (unwind_to_catch):
45 * image.c (my_png_error, my_error_exit):
46 * keyboard.c (quit_throw_to_read_char, user_error)
47 (Fexit_recursive_edit, Fabort_recursive_edit):
48 * lisp.h (die, args_out_of_range, args_out_of_range_3)
49 (wrong_type_argument, buffer_overflow, __executable_start)
50 (memory_full, buffer_memory_full, string_overflow, Fthrow)
51 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
52 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
53 (fatal):
54 (child_setup) [!DOS_NT]:
55 * lread.c (end_of_file_error, invalid_syntax):
56 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
57 * puresize.h (pure_write_error):
58 * search.c (matcher_overflow):
59 * sound.c (sound_perror, alsa_sound_perror):
60 * sysdep.c, syssignal.h (croak):
61 * term.c (maybe_fatal, vfatal):
62 * textprop.c (text_read_only):
63 * undo.c (user_error):
64 * unexmacosx.c (unexec_error):
65 * xterm.c (x_ins_del_lines, x_delete_glyphs):
66 Use _Noreturn rather than NO_RETURN.
67 No need for separate decl merely because of _Noreturn.
68 * sound.c (sound_warning, parse_sound):
69 Remove unnecessary forward decls.
70
f1dd8073
PE
712012-06-24 Paul Eggert <eggert@cs.ucla.edu>
72
73 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
74 * lisp.h (WAIT_READING_MAX): New macro.
75 * dispnew.c (Fsleep_for, sit_for):
76 * keyboard.c (kbd_buffer_get_event):
77 * process.c (Faccept_process_output):
78 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
79 This improves on the previous patch, which introduced a bug
80 when time_t is unsigned and as wide as intmax_t.
81 See <http://bugs.gnu.org/9000#51>.
82
b82c1755
EZ
832012-06-23 Eli Zaretskii <eliz@gnu.org>
84
85 * dispnew.c (sit_for, Fsleep_for):
86 * keyboard.c (kbd_buffer_get_event):
87 * process.c (Faccept_process_output): Avoid compiler warnings when
88 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
89
ca300656
JB
902012-06-23 Juanma Barranquero <lekktu@gmail.com>
91
049ec95b
JB
92 * makefile.w32-in: Update dependencies.
93
ca300656
JB
94 * w32.c (ltime): Add return type and declare static.
95 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
96
db7b8d06
PE
972012-06-23 Paul Eggert <eggert@cs.ucla.edu>
98
99 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
100 Privately reported by Herbert J. Skuhra.
101 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
102 All uses changed.
103 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
104 not make_lisp_timeval, when the argument is of type EMACS_TIME.
105
0bd8297f
EZ
1062012-06-23 Eli Zaretskii <eliz@gnu.org>
107
96512555
EZ
108 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
109 last argument of make_unibyte_string.
110
0bd8297f
EZ
111 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
112 language ID in the event parameters.
113
114 * w32term.c (w32_read_socket): Put the new keyboard codepage into
115 event.code, not the obscure "character set ID".
116
63def6b6
CY
1172012-06-23 Chong Yidong <cyd@gnu.org>
118
119 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
120
e8a02204
EZ
1212012-06-23 Eli Zaretskii <eliz@gnu.org>
122
388cdec0
EZ
123 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
124 * w32.c (fdutimens): New function.
125
126 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
127
128 * s/ms-w32.h (pselect): Redirect to sys_select.
129
130 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
131
e8a02204
EZ
132 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
133 in the logic of incrementing and decrementing the value of
134 use_relocatable_buffers.
135
d054f3fb
PE
1362012-06-23 Paul Eggert <eggert@cs.ucla.edu>
137
138 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
139 Privately reported by Herbert J. Skuhra.
140 [__FreeBSD__]: Remove "*/" typo after "#include".
141 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
142 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
143 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
144 Don't assume EMACS_TIME and struct timeval are the same type.
145
d35af63c
PE
1462012-06-22 Paul Eggert <eggert@cs.ucla.edu>
147
148 Support higher-resolution time stamps (Bug#9000).
149 The time stamps are only nanosecond-resolution at the C level,
150 since that's the best that any real-world system supports now.
151 But they are picosecond-resolution at the Lisp level, as that's
152 easy, and leaves room for future OS improvements.
153
154 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
155 (LIBES): Use it.
156
157 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
158 Don't get current time unless it's needed.
159
160 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
161 now provides it if it's absent.
162 (start_atimer): Port to higher-res time stamps.
163 Check for time stamp overflow. Don't get current time more
164 often than is needed.
165
166 * buffer.h (struct buffer): Buffer modtime now has high resolution.
167 Include systime.h, not time.h.
168 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
169
170 * dired.c: Include stat-time.h.
171 (Ffile-attributes): File times now have higher resolution.
172
173 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
174 (struct image): Timestamp now has higher resolution.
175
176 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
177 has at least microseconds now. All uses removed.
178 (update_frame, update_single_window, update_window, update_frame_1)
179 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
180
181 * editfns.c (time_overflow): Now extern.
182 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
183 (float-time, Fformat_time_string, Fcurrent_time_string)
184 (Fcurrent_time_zone): Accept and generate higher-resolution
185 time stamps.
186 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
187 (decode_time_components, lisp_seconds_argument): New functions.
188 (make_time): Now static.
189 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
190 Report an error if the time is invalid, rather than having the caller
191 do that.
192
193 * fileio.c: Include <stat-time.h>
194 (Fcopy_file): Copy higher-resolution time stamps.
195 Prefer to set the time stamp via a file descriptor if that works.
196 (Fset_file_times, Finsert_file_contents, Fwrite_region)
197 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
198 (Fvisited_file_modtime, Fset_visited_file_modtime):
199 Support higher-resolution time stamps.
200
201 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
202
203 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
204
205 * image.c (prepare_image_for_display, clear_image_cache)
206 (lookup_image): Port to higer-resolution time stamps.
207
208 * keyboard.c (start_polling, bind_polling_period):
209 Check for time stamp overflow.
210 (read_char, kbd_buffer_get_event, timer_start_idle)
211 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
212 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
213 Port to higher-resolution time stamps. Do not assume time_t is signed.
214 (decode_timer): New function. Timers are now vectors of length 9,
215 not 8, to accommodate the picosecond component.
216 (timer_check_2): Use it.
217
218 * nsterm.m (select_timeout, timeval_subtract): Remove.
219 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
220 as they're a bit more accurate and handle overflow better.
221 (ns_select): Change prototype to be compatible with pselect.
222 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
223 * nsterm.h (ns_select): Adjust prototype.
224
225 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
226 us-resolution time stamps.
227 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
228
229 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
230
231 * lisp.h (time_overflow): New decl.
232 (wait_reading_process_output): First arg is now intmax_t, not int,
233 to accommodate larger waits.
234
235 * process.h (struct Lisp_Process.read_output_delay):
236 Now counts nanoseconds, not microseconds.
237 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
238 EMACS_HAS_USECS.
239 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
240 (wait_reading_process_output):
241 Port to ns-resolution time stamps.
242 (Faccept_process_output, wait_reading_process_output):
243 Check for time stamp overflow. Do not assume time_t is signed.
244 (select_wrapper): Remove; we now use pselect.
245 (Fprocess_attributes): Now generates ns-resolution time stamps.
246
247 * sysdep.c: Include utimens.h. Don't include utime.h
248 or worry about struct utimbuf; gnulib does that for us now.
249 (gettimeofday): Remove; gnulib provides a substitute.
250 (make_timeval): New function.
251 (set_file_times): Now sets ns-resolution time stamps.
252 New arg FD; all uses changed.
253 (time_from_jiffies, ltime_from_jiffies, get_up_time)
254 (system_process_attributes):
255 Now returns ns-resolution time stamp. All uses changed.
256 Check for time stamp overflow.
257
258 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
259 provides a substitute now.
260
261 * systime.h: Include timespec.h rather than sys/time.h and time.h,
262 since it guarantees struct timespec.
263 (EMACS_TIME): Now struct timespec, so that we can support
264 ns-resolution time stamps.
265 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
266 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
267 (EMACS_USECS): Remove.
268 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
269 so multiply the arg by 1000 before storing it.
270 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
271 New macros.
272 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
273 Port to ns-resolution time stamps.
274 (EMACS_TIME_NEG_P): Remove; replaced by....
275 (EMACS_TIME_SIGN): New macro.
276 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
277 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
278 (set_file_times, make_time, lisp_time_argument): Adjust signature.
279 (make_timeval, make_lisp_time, decode_time_components): New decls.
280 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
281 that it mishandled time_t overflow. You can't compare by subtracting!
282 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
283 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
284
285 * term.c: Include <sys/time.h>.
286 (timeval_to_Time): New function, for proper overflow wraparound.
287 (term_mouse_position, term_mouse_click): Use it.
288
289 * undo.c (record_first_change): Support higher-resolution time stamps
290 in the undo buffer.
291 (Fprimitive_undo): Use them when restoring time stamps.
292
293 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
294 (w32_get_internal_run_time):
295 Port to higher-resolution Emacs time stamps.
296 (ltime): Now accepts single 64-bit integer, as that's more convenient
297 for callers.
298
299 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
300
301 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
302 for compatibility with pselect. Support ns-resolution time stamps.
303
304 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
305
306 * xselect.c (wait_for_property_change, x_get_foreign_selection):
307 Check for time stamp overflow, and support ns-resolution time stamps.
308
309 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
310 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
311 (timeval_subtract): Remove; no longer needed.
312 (XTflash, XTring_bell, x_wait_for_event):
313 Port to ns-resolution time stamps. Don't assume time_t is signed.
314
b6a92dfe
CY
3152012-06-22 Chong Yidong <cyd@gnu.org>
316
317 * xdisp.c (x_consider_frame_title): Revert last change.
318
d251c37c
EZ
3192012-06-22 Eli Zaretskii <eliz@gnu.org>
320
321 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
322 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
323 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
324 staticidx goes up to 1597 out of 1600 = 0x640.)
325
f10deafb
PE
3262012-06-20 Paul Eggert <eggert@cs.ucla.edu>
327
328 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
329 Otherwise, the umask might be mistakenly 0 while handling input signals.
330
ec6de1e2
SM
3312012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
332
333 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
334
28be1ada
DA
3352012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
336
337 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
338 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
339 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
340 access to `contents' member of Lisp_Vector objects with AREF and ASET
341 where appropriate.
342
c6bf3022
CY
3432012-06-19 Chong Yidong <cyd@gnu.org>
344
345 * frame.c (delete_frame): When selecting a frame on a different
346 text terminal, do not alter the terminal's top-frame.
347
348 * xdisp.c (format_mode_line_unwind_data): Record the target
349 frame's selected window and its terminal's top-frame.
350 (unwind_format_mode_line): Restore them.
351 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
352 Callers changed.
353 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
354 since tty frames can be explicitly named.
355 (prepare_menu_bars): Likewise.
356
357 * term.c (Ftty_top_frame): New function.
358
defd4196
PE
3592012-06-18 Paul Eggert <eggert@cs.ucla.edu>
360
361 Port byte-code-meter to modern targets.
362 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
363 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 364 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
365 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
366 (METER_1, METER_2): Simplify.
367
1053a871
SM
3682012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
369
370 * data.c (Fdefalias): Return `symbol' (bug#11686).
371
b7e8d081
MR
3722012-06-18 Martin Rudalics <rudalics@gmx.at>
373
374 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
375 gets killed during executing of this function (Bug#11665).
376 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
377 (Vkill_buffer_query_functions): In doc-string say that functions
378 run by this hook should not change the current buffer.
379
7ea2b339
PE
3802012-06-18 Paul Eggert <eggert@cs.ucla.edu>
381
382 Fix recently-introduced process.c problems found by static checking.
383 * process.c (write_queue_push, write_queue_pop, send_process):
384 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
385 (write_queue_pop): Fix pointer signedness problem.
386 (send_process): Remove unused local.
387
96a313a1
CY
3882012-06-17 Chong Yidong <cyd@gnu.org>
389
390 * xdisp.c (redisplay_internal): No need to redisplay terminal
391 frames that are not on top.
392
20ca2e94
TN
3932012-06-17 Troels Nielsen <bn.troels@gmail.com>
394
395 * process.c (make_process): Initialize write_queue.
396 (write_queue_push, write_queue_pop): New functions.
397 (send_process): Use them to maintain correct ordering of process
398 writes (Bug#10815).
399
9a900ca9
PE
4002012-06-17 Paul Eggert <eggert@cs.ucla.edu>
401
310fbfa8
PE
402 * lisp.h (eassert): Assume C89 or later.
403 This removes the need for CHECK.
404 (CHECK): Remove. Its comments about always evaluating its
405 argument were confusing, as 'eassert' typically does not evaluate
406 its argument.
407
27bb1ca4
PE
408 * coding.c (produce_chars): Use ptrdiff_t, not int.
409
9a900ca9
PE
410 * xterm.c (x_draw_underwave): Check for integer overflow.
411 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
412
41b7f8bc 4132012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
414
415 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
416 referenced (Bug#11583).
417
9b0e3eba
AA
4182012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
419
420 Implement wave-style variant of underlining.
421 * dispextern.h (face_underline_type): New enum.
422 (face): Add field for underline type.
423 * nsterm.m (ns_draw_underwave): New function.
424 (ns_draw_text_decoration): Use it.
425 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
426 New functions.
427 (x_draw_glyph_string): Use them.
428 * xfaces.c (Qline, Qwave): New Lisp objects.
429 (check_lface_attrs, merge_face_ref)
1053a871
SM
430 (Finternal_set_lisp_face_attribute, realize_x_face):
431 Handle wave-style underline face attributes.
9b0e3eba
AA
432 * xterm.c (x_draw_underwave): New function.
433 (x_draw_glyph_string): Use it.
434
0fb52f11
JB
4352012-06-16 Juanma Barranquero <lekktu@gmail.com>
436
437 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
438 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
439 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
440 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
441 ($(BLD)/w32select.$(O)): Update dependencies.
442
e5560ff7
AS
4432012-06-16 Andreas Schwab <schwab@linux-m68k.org>
444
445 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
446 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
447 * character.c (_fetch_multibyte_char_p): Remove.
448 * alloc.c: Include "character.h" before "buffer.h".
449 * bidi.c: Likewise.
450 * buffer.c: Likewise.
451 * bytecode.c: Likewise.
452 * callint.c: Likewise.
453 * callproc.c: Likewise.
454 * casefiddle.c: Likewise.
455 * casetab.c: Likewise.
456 * category.c: Likewise.
457 * cmds.c: Likewise.
458 * coding.c: Likewise.
459 * composite.c: Likewise.
460 * dired.c: Likewise.
461 * dispnew.c: Likewise.
462 * doc.c: Likewise.
463 * dosfns.c: Likewise.
464 * editfns.c: Likewise.
465 * emacs.c: Likewise.
466 * fileio.c: Likewise.
467 * filelock.c: Likewise.
468 * font.c: Likewise.
469 * fontset.c: Likewise.
470 * fringe.c: Likewise.
471 * indent.c: Likewise.
472 * insdel.c: Likewise.
473 * intervals.c: Likewise.
474 * keyboard.c: Likewise.
475 * keymap.c: Likewise.
476 * lread.c: Likewise.
477 * macros.c: Likewise.
478 * marker.c: Likewise.
479 * minibuf.c: Likewise.
480 * nsfns.m: Likewise.
481 * nsmenu.m: Likewise.
482 * print.c: Likewise.
483 * process.c: Likewise.
484 * regex.c: Likewise.
485 * region-cache.c: Likewise.
486 * search.c: Likewise.
487 * syntax.c: Likewise.
488 * term.c: Likewise.
489 * textprop.c: Likewise.
490 * undo.c: Likewise.
491 * unexsol.c: Likewise.
492 * w16select.c: Likewise.
493 * w32fns.c: Likewise.
494 * w32menu.c: Likewise.
495 * window.c: Likewise.
496 * xdisp.c: Likewise.
497 * xfns.c: Likewise.
498 * xmenu.c: Likewise.
499 * xml.c: Likewise.
500 * xselect.c: Likewise.
501
2f07e6af
EZ
5022012-06-16 Eli Zaretskii <eliz@gnu.org>
503
1053a871
SM
504 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
505 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 506 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
507 row.
508 (handle_face_prop): Use chunk-relative overlay string index when
509 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
510 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
511 the rightmost. (Bug#11720)
2f07e6af 512
29b83cec
AS
5132012-06-16 Andreas Schwab <schwab@linux-m68k.org>
514
515 * category.h (CHAR_HAS_CATEGORY): Define as inline.
516 (CATEGORY_MEMBER): Enforce 1/0 value.
517 * category.c (_temp_category_set): Remove.
518
4c5501e9
EZ
5192012-06-16 Eli Zaretskii <eliz@gnu.org>
520
521 * window.c (Fdelete_other_windows_internal)
522 (Fdelete_window_internal): Don't access frame's mouse highlight
523 info of the initial frame. (Bug#11677)
524
2b570124
PE
5252012-06-14 Paul Eggert <eggert@cs.ucla.edu>
526
e93864f9
PE
527 * .gdbinit (xgetint): Fix recently-introduced paren typo.
528 Assume USE_2_TAGS_FOR_INTS.
529 (xreload): Adjust $tagmask width to match recent lisp.h change.
530
2b570124
PE
531 Simplify lisp.h in minor ways that should not affect code.
532 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
533 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
534 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
535 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
536 (INTTYPEBITS): New macro, for clarity.
537 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
538 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
539 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
540 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
541 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
542
81755f69
JB
5432012-06-13 Juanma Barranquero <lekktu@gmail.com>
544
545 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
546
16192a57
GM
5472012-06-13 Glenn Morris <rgm@gnu.org>
548
549 * s/bsd-common.h (BSD4_3):
550 * s/usg5-4-common.h (USG5_4): No longer define; unused.
551
646b5f55
AS
5522012-06-13 Andreas Schwab <schwab@linux-m68k.org>
553
554 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
555 instead of union.
556 (XLI, XIL): Define.
1053a871
SM
557 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
558 Use them.
559 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 560 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 561 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
562 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
563 * frame.c (delete_frame): Remove outdated comment.
564 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
565 USE_LISP_UNION_TYPE.
566 (Fw32_unregister_hot_key): Likewise.
567 (Fw32_toggle_lock_key): Likewise.
568 * w32menu.c (add_menu_item): Likewise.
569 (w32_menu_display_help): Use XIL instead of checking
570 USE_LISP_UNION_TYPE.
571 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
572 (init_heap): Likewise.
573 * w32term.c (w32_read_socket): Update comment.
574
1d3823c9
GM
5752012-06-13 Glenn Morris <rgm@gnu.org>
576
c62ff706
GM
577 * s/usg5-4-common.h, src/s/unixware.h:
578 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
579
1d3823c9
GM
580 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
581
bfe3e0a2
PE
5822012-06-13 Paul Eggert <eggert@cs.ucla.edu>
583
584 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
585 * alloc.c (make_number) [!defined make_number]:
586 Remove, as lisp.h always defines this now.
587 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
588 (roundup_size): Verify that it is a power of 2.
589 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
590 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
591 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
592 -DUSE_LSB_TAG=0, to override the automatically-selected default.
593 USE_LSB_TAG now is always defined to be either 0 or 1.
594 All uses changed.
595 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
596 code works fine either way, and efficiency is not a concern here,
597 as the union type is for debugging, not for production.
598 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
599 Use an inline function on all platforms when using the union type,
600 since this is simpler and 'static inline' can be used portably
601 within Emacs now.
602 (LISP_INITIALLY_ZERO): New macro.
603 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
604 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
605
45fa9c0f
GM
6062012-06-12 Glenn Morris <rgm@gnu.org>
607
b4492cba
GM
608 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
609
610 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 611
45fa9c0f
GM
612 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
613 Move BROKEN_SIGIO to configure.
614
615 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
616 Move NO_TERMIO to configure.
617
0e25d334
CY
6182012-06-12 Chong Yidong <cyd@gnu.org>
619
620 * image.c (imagemagick_load_image): Use MagickFlattenImage if
621 MagickMergeImageLayers is undefined. Use pixel pusher loop if
622 MagickExportImagePixels is undefined.
623
43682bb6
PE
6242012-06-12 Paul Eggert <eggert@cs.ucla.edu>
625
626 * image.c (imagemagick_load_image): Remove unused label.
627
a9be7d2b
GM
6282012-06-11 Glenn Morris <rgm@gnu.org>
629
630 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
631 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
632 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
633 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
634
3017f87f
SM
6352012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
636
637 * alloc.c (make_byte_code): New function.
638 (Fmake_byte_code): Use it. Don't purify here.
639 * lread.c (read1): Use it as well to avoid extra allocation.
640
1b9b4cf4
CY
6412012-06-11 Chong Yidong <cyd@gnu.org>
642
643 * image.c (imagemagick_load_image): Implement transparency.
644
95988fcf
AS
6452012-06-10 Andreas Schwab <schwab@linux-m68k.org>
646
647 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
648 account for preceding backslashes. (Bug#11663)
649
cd4eb164
CY
6502012-06-09 Chong Yidong <cyd@gnu.org>
651
652 * term.c: Support italics in capable terminals (Bug#9652).
653 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
654 (turn_on_face): Output using TS_enter_italic_mode if available.
655 Don't handle unused blinking and alt-charset cases.
656 (turn_off_face): Handle italic case; discard unused tty_blinking_p
657 and tty_alt_charset_p cases.
658 (tty_capable_p, init_tty): Support italics.
659
660 * termchar.h (struct tty_display_info): Add field for italics.
661 Remove unused blink field.
662
663 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
664 Handle slant.
665
666 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
667 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
668 tty_alt_charset_p. Add tty_italic_p.
669
ff88beb8
MA
6702012-06-09 Michael Albinus <michael.albinus@gmx.de>
671
672 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
673 dbus_type_is_basic if available.
674 (xd_extract_signed, xd_extract_unsigned): Rename from
675 extract_signed and extract_unsigned, respectively. Adapt callers.
676
44286096
CY
6772012-06-09 Chong Yidong <cyd@gnu.org>
678
1682701f
CY
679 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
680
44286096
CY
681 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
682 case (Bug#9752).
683
d86feb17
PE
6842012-06-08 Paul Eggert <eggert@cs.ucla.edu>
685
686 * xdisp.c (vmessage): Treat frame message as multibyte.
687 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
688 would generate the diagnostic "Making \302\247 buffer-local while
689 let-bound!".
690
d5c20fe8
EZ
6912012-06-08 Eli Zaretskii <eliz@gnu.org>
692
693 * dispnew.c (showing_window_margins_p): Undo last change, which
694 was done due to an inadvertent commit.
695 (adjust_frame_glyphs_for_frame_redisplay): Do call
696 showing_window_margins_p.
697
513749ee
SM
6982012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
699
700 * eval.c (Fmake_var_non_special): New primitive.
701 (syms_of_eval): Defsubr it.
702 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
703
d4a8f5c1
JB
7042012-06-08 Juanma Barranquero <lekktu@gmail.com>
705
706 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
707 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
708
8bbbc977
EZ
7092012-06-08 Eli Zaretskii <eliz@gnu.org>
710
711 * alloc.c (allocate_vectorlike): Fix last change.
712
f3372c87
DA
7132012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
714
715 Block-based vector allocation of small vectors.
716 * lisp.h (struct vectorlike_header): New field `nbytes',
717 adjust comment accordingly.
718 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
719 to denote vector blocks. Adjust users (live_vector_p,
720 mark_maybe_pointer, valid_lisp_object_p) accordingly.
721 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
722 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
723 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
724 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
725 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
726 (roundup_size): New constant.
727 (struct vector_block): New data type.
728 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 729 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
730 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
731 (sweep_vectors): New functions.
732 (allocate_vectorlike): Return `zero_vector' as the only vector of
733 0 items. Allocate new vector from block if vector size is less than
734 or equal to VBLOCK_BYTES_MAX.
735 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
736 (init_alloc_once): Add call to init_vectors.
737
4f18a4ed
SM
7382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
739
740 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
741
86f158bc
PE
7422012-06-07 Paul Eggert <eggert@cs.ucla.edu>
743
744 * doprnt.c (doprnt): Truncate multibyte char correctly.
745 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
746 would mishandle a string argument "Xc" if X was a multibyte
747 character of length 2: it would truncate after X's first byte
748 rather than including all of X.
749
c5cfcbe0
CY
7502012-06-06 Chong Yidong <cyd@gnu.org>
751
752 * buffer.c (word_wrap): Doc fix.
753
c05cf390
PE
7542012-06-04 Paul Eggert <eggert@cs.ucla.edu>
755
756 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
757
0c3461de
GM
7582012-06-03 Glenn Morris <rgm@gnu.org>
759
760 * xdisp.c (tool-bar-style): Doc fix.
761
c71232db
UM
7622012-06-03 Ulrich Müller <ulm@gentoo.org>
763
764 * Makefile.in (PAXCTL): Define.
765 (temacs$(EXEEXT)): Disable memory randomization for the temacs
766 binary via PaX flags if the paxctl utility is available.
767 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
768 Restore PaX flags to their default. (Bug#11398)
769
383f7350
CY
7702012-06-03 Chong Yidong <cyd@gnu.org>
771
772 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
773 buffer (Bug#11226).
774
5f2c76c6
CY
7752012-06-03 Chong Yidong <cyd@gnu.org>
776
777 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
778 (note_mode_line_or_margin_highlight): If there is no help echo,
779 use mode-line-default-help-echo. Handle the case where the mouse
780 position is past the end of the mode line string.
781
782 * buffer.c (buffer_local_value_1): New function, split from
783 Fbuffer_local_value; can return Qunbound.
784 (Fbuffer_local_value): Use it.
785 (Vmode_line_format): Docstring tweaks.
786
773d47f6
PE
7872012-06-02 Paul Eggert <eggert@cs.ucla.edu>
788
789 * sysdep.c (system_process_attributes): Improve comment.
790
f2d6a3df
SM
7912012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 * keyboard.c: Export real-this-command to Elisp.
794 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
795 and DEFVAR it. Update all users.
796
63810350
PE
7972012-06-02 Paul Eggert <eggert@cs.ucla.edu>
798
7bd5c1f4
PE
799 * minibuf.c (Fassoc_string): Remove duplicate declaration.
800
63810350
PE
801 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
802 Convert pctcpu and pctmem to Lisp float properly.
803 Let the compiler fold better, as 100.0/0x8000 is exact.
804
a2821611
AS
8052012-06-02 Andreas Schwab <schwab@linux-m68k.org>
806
807 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
808 cons_block.
809
5fceba1d
PE
8102012-06-01 Paul Eggert <eggert@cs.ucla.edu>
811
812 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
813
c98ff5dd
DA
8142012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
815
816 For a 'struct window', replace some Lisp_Object fields to
817 bitfields where appropriate, remove unused fields.
818 * window.h (struct window): Remove unused 'last_mark_x' and
819 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
820 change it's type from Lisp_Object to bitfield.
821 Change type of 'force_start', 'optional_new_start',
822 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
823 fields from Lisp_Object to bitfield. Adjust users accordingly.
824
ca34e0be
PE
8252012-05-31 Paul Eggert <eggert@cs.ucla.edu>
826
827 Pacify gcc -Wdouble-precision when using Xaw.
828 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
829 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
830 Use 'float' consistently, rather than 'float' in most places
831 and 'double' in a couple of places.
832
efc00ab1 8332012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
834
835 * xdisp.c (handle_stop): Detect whether we have overlay strings
836 loaded by testing it->current.overlay_string_index to be
837 non-negative, instead of checking whether n_overlay_strings is
838 positive. (Bug#11587)
839
efc00ab1 8402012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
841
842 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
843
844 * doc.c (Fsubstitute_command_keys): Doc fix.
845
efc00ab1 8462012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
847
848 * search.c (search_buffer): Remove calls to
849 r_alloc_inhibit_buffer_relocation, as it is now called by
850 maybe_unify_char, which was the cause of relocation of buffer text
851 in bug#11519.
852
efc00ab1 8532012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
854
855 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
856 for the duration of call to load_charset, to avoid problems with
857 callers of maybe_unify_char that access buffer text through C
858 pointers.
859
860 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
861 decrement the inhibition flag, instead of just setting or
862 resetting it.
863
ba93a187
PE
8642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
865
866 Remove obsolete '#define static' cruft.
867 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
868 This #undef was "temporary" in 2000; it is no longer needed
869 now that '#define static' has gone away.
870 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
871 (gray_bitmap_bits): Remove; no longer needed.
872 All uses replaced with definiens.
873 * xterm.c: Include "bitmaps/gray.xbm".
874
9e4bf381
PE
8752012-05-30 Paul Eggert <eggert@cs.ucla.edu>
876
877 Clean up __executable_start, monstartup when --enable-profiling.
878 The following changes affect the code only when profiling.
879 * dispnew.c (__executable_start): Rename from safe_bcopy.
880 Define only on platforms that need it.
881 * emacs.c: Include <sys/gmon.h> when profiling.
882 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
883 (__executable_start): Remove decl, since lisp.h does it now.
884 (safe_bcopy): Remove decl; no longer has that name.
885 (main): Coalesce #if into single bit of code, for simplicity.
886 Cast pointers to uintptr_t, since standard libraries want integers
887 and not pointers.
888 * lisp.h (__executable_start): New decl.
889
32d72c2f
GM
8902012-05-31 Glenn Morris <rgm@gnu.org>
891
892 * image.c (Fimagemagick_types): Doc fix.
893
baac5bc7
JM
8942012-05-30 Jim Meyering <meyering@redhat.com>
895
896 * callproc.c (Fcall_process_region): Include directory component
897 in mkstemp error message (Bug#11586).
898
72cb32cf
PE
8992012-05-30 Paul Eggert <eggert@cs.ucla.edu>
900
901 * alloc.c, lisp.h (make_pure_vector): Now static.
902
61b108cc
SM
9032012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
904
905 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
906 Move to byte-run.el.
907 (Fautoload): Do the hash-doc more carefully.
908 * data.c (Fdefalias): Purify definition, except for keymaps.
909 (Qdefun): Move from eval.c.
910 * lisp.h (Qdefun): Remove.
911 * lread.c (read1): Tiny simplification.
912
471fe23d
TN
9132012-05-29 Troels Nielsen <bn.troels@gmail.com>
914
934f3f58 915 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
916 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
917 Bug#9642, but explicitly check that the buffer the overlay would
918 be moved to is live and rearrange lines to make sure that errors
919 will not put the overlay in an inconsistent state.
920 (Fdelete_overlay): Cosmetics.
921
85d0efd1
EZ
9222012-05-28 Eli Zaretskii <eliz@gnu.org>
923
924 * w32term.c (my_bring_window_to_top): New function.
925 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
926 could be different from the original one.
927 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
928 (Bug#11513)
929
930 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
931 by calling BringWindowToTop.
932
933 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
934 (WM_EMACS_END): Increase by one.
935
da92a98c
PE
9362012-05-28 Paul Eggert <eggert@cs.ucla.edu>
937
938 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
939 This avoids undefined behavior that might cause the eassert
940 to not catch an out-of-range value.
941
74d1f848
JB
9422012-05-28 Juanma Barranquero <lekktu@gmail.com>
943
944 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
945 Update dependencies.
946
9e1a06fc
EZ
9472012-05-27 Eli Zaretskii <eliz@gnu.org>
948
949 * bidi.c (bidi_mirror_char): Fix last change.
950
f3dd7312
AS
9512012-05-27 Andreas Schwab <schwab@linux-m68k.org>
952
953 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
954 when referring to sectname field in printf format.
955
81899c91
PE
9562012-05-27 Paul Eggert <eggert@cs.ucla.edu>
957
57b81a9f
PE
958 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
959 Only r_alloc_inhibit_buffer_relocation needed to be added;
960 the others were already declared.
961
81899c91
PE
962 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
963 before checking whether it's out of range. Put the check inside
964 eassert. See
965 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
966
33017faf 9672012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
968
969 * callproc.c (Fcall_process): Restore a line that was accidentally
970 commented out in the 2011-02-13 change (bug#11547).
971
33017faf 9722012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
973
974 * lisp.h [REL_ALLOC]: Add prototypes for external functions
975 defined on ralloc.c.
976
977 * buffer.c [REL_ALLOC]: Remove prototypes of
978 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
979 they are now on lisp.h.
980
981 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
982
983 * search.c (search_buffer): Use it to inhibit relocation of buffer
984 text while re_search_2 is doing its job, because re_search_2 is
985 passed C pointers to buffer text. (Bug#11519)
986
23415acf
EZ
987 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
988 Update value to 24.
989
44e27368
EZ
990 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
991 state after an additional call to move_it_in_display_line_to, keep
992 the values of it->max_ascent and it->max_descent found for the
993 entire line.
994 (pos_visible_p): Revert the comparison against bottom_y to what it
995 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
996 (Bug#11464)
997
c1892f11
PE
9982012-05-26 Paul Eggert <eggert@cs.ucla.edu>
999
1000 Fix coding-related core dumps with gcc -ftrapv.
1001 The code was computing A - B, where A and B are pointers, and B is
1002 random garbage. This can lead to core dumps on platforms that
1003 have special pointer registers, and it also leads to core dumps on
1004 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1005 A - B only when B is initialized properly.
1006 * coding.c (coding_set_source, coding_set_destination): Return void.
1007 (coding_change_source, coding_change_destinations): New functions,
1008 with the old behaviors of coding_set_source and coding_set_destination.
1009 All callers that need an offset changed to use these new functions.
1010
eb7afdad
GM
10112012-05-26 Glenn Morris <rgm@gnu.org>
1012
1013 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1014
f12fdf02
EZ
10152012-05-26 Eli Zaretskii <eliz@gnu.org>
1016
53a63be6 1017 Extend mouse support on W32 text-mode console.
61b108cc
SM
1018 * xdisp.c (draw_row_with_mouse_face):
1019 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1020
eb3f6f01 1021 * w32console.c: Include window.h.
61b108cc
SM
1022 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1023 New functions.
eb3f6f01
EZ
1024 (initialize_w32_display): Initialize mouse-highlight data.
1025
53a63be6
EZ
1026 * w32inevt.c: Include termchar.h and window.h.
1027 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1028 moves, call note_mouse_highlight. If help_echo changed, call
1029 gen_help_event to produce help-echo message in the echo area.
1030 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1031 highlight info.
1032
4cfd81f6
PE
10332012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * lread.c (read1): Simplify slightly to avoid an overflow warning
1036 with GCC 4.7.0 on x86-64.
1037
4446092a
EZ
10382012-05-26 Eli Zaretskii <eliz@gnu.org>
1039
1040 * bidi.c (bidi_mirror_char): Revert last change: an int is
1041 definitely wide enough here.
1042
42b2a986 10432012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1044
42b2a986 1045 Fix integer width and related bugs (Bug#9874).
eb106a49 1046 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1047 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1048 (string_bytes, check_sblock, allocate_string_data):
1049 (compact_small_strings, Fmake_bool_vector, make_string)
1050 (make_unibyte_string, make_multibyte_string)
1051 (make_string_from_bytes, make_specified_string)
1052 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1053 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1054 (mark_vectorlike):
1055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1056 (allocate_pseudovector):
1057 Use int, not EMACS_INT, where int is wide enough.
1058 (inhibit_garbage_collection, Fgarbage_collect):
1059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1060 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1061 int might not be wide enough.
1062 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1063 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1064 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1065 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1066 (bidi_level_of_next_char, bidi_move_to_visually_next):
1067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1068 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1069 (Fkill_buffer, Fset_buffer_major_mode)
1070 (advance_to_char_boundary, Fbuffer_swap_text)
1071 (Fset_buffer_multibyte, overlays_at, overlays_in)
1072 (overlay_touches_p, struct sortvec, record_overlay_string)
1073 (overlay_strings, recenter_overlay_lists)
1074 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1075 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1076 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1077 (Foverlay_recenter, last_overlay_modification_hooks_used)
1078 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1080 (validate_region): Omit unnecessary test for b <= e,
1081 since that's guaranteed by the previous test.
d311d28c
PE
1082 (adjust_overlays_for_delete): Avoid pos + length overflow.
1083 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1084 (report_overlay_modification):
1085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1086 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1087 Omit pointer cast, which isn't needed anyway, and doesn't work
1088 after the EMACS_INT -> ptrdiff_t change.
02481186 1089 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1090 * buffer.h: Adjust decls to match defn changes elsewhere.
1091 (struct buffer_text, struct buffer):
1092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1093 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1094 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1095 not int, to avoid needless 32-bit limit on 64-bit hosts.
1096 (exec_byte_code): Use tighter memory-full test, one that checks
1097 for alloca overflow. Don't compute the address of the object just
1098 before an array, as that's not portable. Use EMACS_INT, not
1099 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1100 * callint.c (Fcall_interactively):
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 * callproc.c (call_process_kill, Fcall_process):
1103 Don't assume pid_t fits into an Emacs fixnum.
1104 (call_process_cleanup, Fcall_process, child_setup):
1105 Don't assume pid_t fits into int.
1106 (call_process_cleanup, Fcall_process, delete_temp_file)
1107 (Fcall_process_region):
1108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1109 (Fcall_process): Simplify handling of volatile integers.
1110 Use int, not EMACS_INT, where int will do.
1111 * casefiddle.c (casify_object, casify_region, operate_on_word)
1112 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1114 (casify_object): Avoid integer overflow when overallocating buffer.
1115 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1116 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1117 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1118 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1119 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1120 integers are now checked earlier. All uses replaced with XINT.
1121 (ccl_driver):
1122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1123 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1124 (ccl_driver, Fregister_code_conversion_map):
1125 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1126 (resolve_symbol_ccl_program): Check that vector header is in range.
1127 Always copy the vector, so that we can check its contents reliably
1128 now rather than having to recheck each instruction as it's being
1129 executed. Check that vector words fit in 'int'.
1130 (ccl_get_compiled_code, Fregister_ccl_program)
1131 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1132 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1133 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1134 contents are in range.
1135 (Fccl_execute_on_string): Check that status is in range.
1136 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1137 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1138 Accept and return EMACS_INT, not int, because callers can pass values
1139 out of 'int' range.
1140 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1141 (multibyte_chars_in_text, parse_str_as_multibyte)
1142 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1143 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1144 (string_escape_byte8, Fget_byte):
1145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1146 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1147 avoid mishandling large integers.
1148 * character.h: Adjust decls to match defn changes elsewhere.
1149 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1150 (Ffind_charset_region):
1151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1152 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1153 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1154 Don't assume fixnum fits in int.
d311d28c
PE
1155 (load_charset_map_from_vector, Fmap_charset_chars):
1156 Remove now-unnecessary CHECK_NATNUMs.
1157 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1158 Don't rely on undefined behavior with signed left shift overflow.
1159 Don't assume unsigned int fits into fixnum, or that fixnum fits
1160 into unsigned int. Don't require max_code to be a valid fixnum;
1161 that's not true for gb10830 4-byte on a 32-bit host. Allow
1162 invalid_code to be a cons, for the same reason. Require code_offset
1163 to be a character. Avoid int overflow if max_char is close
1164 to INT_MAX.
1165 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1166 this is intended anyway and avoids some undefined behavior.
1167 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1168 INDEX_TO_CODE_POINT, as that's what it expects.
1169 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1170 * charset.h (DECODE_CHAR): Return int, not unsigned;
1171 this is what was intended anyway, and it avoids undefined behavior.
1172 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1173 integer-overflow issues.
1174 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1175 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1176 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1177 * chartab.c (Fmake_char_table, Fset_char_table_range)
1178 (uniprop_get_decoder, uniprop_get_encoder):
1179 Don't assume fixnum fits in int.
1180 * cmds.c (move_point): New function, that does the gist of
1181 Fforward_char and Fbackward_char, but does so while checking
1182 for integer overflow more accurately.
c96e5d6a 1183 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1184 (Fforward_line, Fend_of_line, internal_self_insert)
1185 (internal_self_insert):
1186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1187 Fix a FIXME, by checking for integer overflow when calculating
1188 target_clm and actual_clm.
1189 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1190 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1191 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1192 (coding_alloc_by_making_gap, alloc_destination)
1193 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1194 (encode_coding_utf_16, detect_coding_emacs_mule)
1195 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1196 (detect_coding_iso_2022, decode_coding_iso_2022)
1197 (encode_invocation_designation, encode_designation_at_bol)
1198 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1199 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1200 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1201 (encode_coding_ccl, encode_coding_raw_text)
1202 (detect_coding_charset, decode_coding_charset)
1203 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1204 (produce_composition, produce_charset, produce_annotation)
1205 (decode_coding, handle_composition_annotation)
1206 (handle_charset_annotation, consume_chars, decode_coding_gap)
1207 (decode_coding_object, encode_coding_object, detect_coding_system)
1208 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1209 (code_convert_region, code_convert_string)
8f50130c
PE
1210 (Fdefine_coding_system_internal)
1211 (coding_set_source, coding_set_destination):
d311d28c
PE
1212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1213 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1214 (Fdefine_coding_system_internal):
1215 Don't assume fixnums fit in int.
1216 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1217 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1218 (Funencodable_char_position, Fcheck_coding_systems_region)
1219 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1221 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1222 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1223 Don't access memory outside of the args array.
d311d28c 1224 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1225 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1226 result of ENCODE_CHAR.
d311d28c
PE
1227 * coding.h: Adjust decls to match defn changes elsewhere.
1228 (struct coding_system):
1229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1230 * composite.c (get_composition_id, find_composition)
1231 (run_composition_function, update_compositions)
1232 (compose_text, composition_gstring_put_cache)
1233 (composition_gstring_p, composition_gstring_width)
1234 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1235 (composition_compute_stop_pos, composition_reseat_it)
1236 (composition_update_it, struct position_record)
1237 (find_automatic_composition, composition_adjust_point)
1238 (Fcomposition_get_gstring, Ffind_composition_internal):
1239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1240 (update_compositions):
1241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1242 * composite.h: Adjust decls to match defn changes elsewhere.
1243 (struct composition):
1244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1245 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1246 Do not attempt to compute the address of the object just before a
1247 buffer; this is not portable.
1248 (Faref, Faset):
1249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1250 (Faset): Use int, not EMACS_INT, where int is wide enough.
1251 (Fstring_to_number): Don't assume fixnums fit in int.
1252 (Frem): Don't assume arg is nonnegative.
1253 * dbusbind.c (xd_append_arg): Check for integers out of range.
1254 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1255 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1256 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1257 (xd_get_connection_references): Return ptrdiff_t, not int.
1258 All uses changed.
1259 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1260 (xd_read_message_1):
1261 Use int, not unsigned, where the dbus API uses int.
1262 (Fdbus_message_internal): Don't overflow mtype.
1263 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1264 * dired.c (directory_files_internal, file_name_completion, scmp)
1265 (file_name_completion_stat):
1266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1267 (file_name_completion): Don't overflow matchcount.
1268 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1269 * dispextern.h: Adjust decls to match defn changes elsewhere.
1270 (struct text_pos, struct glyph, struct bidi_saved_info)
1271 (struct bidi_string_data, struct bidi_it, struct composition_it)
1272 (struct it):
1273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1274 (struct display_pos, struct composition_it, struct it):
1275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1276 * dispnew.c (increment_matrix_positions)
1277 (increment_row_positions, mode_line_string)
1278 (marginal_area_string):
1279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1280 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1282 (duration_to_sec_usec): New function, to check for overflow better.
1283 (Fsleep_for, sit_for): Use it.
1284 * doc.c (get_doc_string, store_function_docstring):
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 (get_doc_string, Fsnarf_documentation):
1287 Use int, not EMACS_INT, where int is wide enough.
1288 (get_doc_string):
1289 Use SAFE_ALLOCA, not alloca.
1290 Check for overflow when converting EMACS_INT to off_t.
1291 * doprnt.c (doprnt):
1292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1293 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1294 Don't assume uid_t fits into fixnum.
1295 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1296 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1297 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1298 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1299 (general_insert_function)
1300 (Finsert_char, make_buffer_string, make_buffer_string_both)
1301 (update_buffer_properties, Fbuffer_substring)
1302 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1303 (Fsubst_char_in_region, check_translation)
1304 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1305 (transpose_markers, Ftranspose_regions):
1306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1307 (clip_to_bounds): Move to lisp.h as an inline function).
1308 (Fconstrain_to_field): Don't assume integers are nonnegative.
1309 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1310 (Fsubst_char_in_region, Fsave_restriction):
1311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1312 (Femacs_pid): Don't assume pid_t fits into fixnum.
1313 (lo_time): Use int, not EMACS_INT, when int suffices.
1314 (lisp_time_argument): Check for usec out of range.
1315 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1316 (Fuser_login_name, Fuser_full_name): Signal an error
1317 if a uid argument is out of range, rather than relying on
1318 undefined behavior.
c8d5c857
PE
1319 (Fformat_time_string): Remove now-unnecessary check.
1320 lisp_time_argument checks for out-of-range usec now.
243e0530 1321 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1322 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1323 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1324 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1325 (init_cmdargs, Fdump_emacs):
1326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1327 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1328 the bottom (typically) 32 bits of the fixnum.
1329 * eval.c (specpdl_size, call_debugger):
1330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1331 (when_entered_debugger, Fbacktrace_debug):
1332 Don't assume fixnum can fit in int.
1333 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1334 the object just before a buffer; this is not portable.
1335 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1336 (grow_specpdl, unbind_to):
1337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1338 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1339 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1340 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1341 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1342 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1344 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1345 (a_write, e_write):
1346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1347 (Fcopy_file, non_regular_nbytes, read_non_regular)
1348 (Finsert_file_contents):
1349 Use int, not EMACS_INT, where int is wide enough.
1350 (READ_BUF_SIZE): Verify that it fits in int.
1351 (Finsert_file_contents): Check that counts are in proper range,
1352 rather than assuming fixnums fit into ptrdiff_t etc.
1353 Don't assume fixnums fit into int.
125b3835 1354 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1355 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1356 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1357 (string_char_to_byte, string_byte_to_char)
1358 (string_make_multibyte, string_to_multibyte)
1359 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1360 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1361 (substring_both, Fdelete, internal_equal, Ffillarray)
1362 (Fclear_string, mapcar1)
1363 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1364 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1365 (larger_vector, make_hash_table, maybe_resize_hash_table)
1366 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1367 (Fmaphash, secure_hash):
1368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1369 (concat): Check for string index and length overflow.
1370 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1371 (Frequire):
1372 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1373 (larger_vector): New API (vec, incr_min, size_max) replaces old
1374 one (vec, new_size, init). This catches size overflow.
1375 INIT was removed because it was always Qnil.
1376 All callers changed.
1377 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1378 the upper bound on a hash table index size.
1379 (make_hash_table, maybe_resize_hash_table): Use it.
1380 (secure_hash): Computer start_byte and end_byte only after
1381 they're known to be in ptrdiff_t range.
1382 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1383 (Ffont_get_glyphs, Ffont_at):
1384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1385 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1386 (Flist_fonts, Fopen_font):
1387 Don't assume fixnum can fit in int.
1388 (check_gstring): Don't assume index can fit in int.
1389 (font_match_p): Check that fixnum is a character, not a nonnegative
1390 fixnum, since the later code needs to stuff it into an int.
1391 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1392 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1393 conversion overflow issues.
1394 (Fopen_font): Check for integer out of range.
1395 (Ffont_get_glyphs): Don't assume index can fit in int.
1396 * font.h: Adjust decls to match defn changes elsewhere.
1397 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1398 integer overflow.
1399 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1400 printmax_t, where ptrdiff_t is wide enough.
1401 (Finternal_char_font):
1402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1403 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1404 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1405 (Fset_frame_position, x_set_frame_parameters)
1406 (x_set_line_spacing, x_set_border_width)
1407 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1408 Check that fixnums are in proper range for system types.
1409 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1411 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1412 Use SAFE_ALLOCA_LISP, not alloca.
1413 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1414 intptr_t is wide enough.
1415 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1416 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1417 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1418 Check for fixnum out of range.
1419 * ftfont.c (ftfont_list): Don't assume index fits in int.
1420 Check that fixnums are in proper range for system types.
1421 (ftfont_shape_by_flt):
1422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1423 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1425 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1426 Check that fixnums are in proper range for system types.
1427 * gnutls.h: Adjust decls to match defn changes elsewhere.
1428 * gtkutil.c (xg_dialog_run):
1429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1430 (update_frame_tool_bar):
1431 Check that fixnums are in proper range for system types.
1432 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1433 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1434 * indent.c (last_known_column, last_known_column_point):
1435 (current_column_bol_cache):
1436 (skip_invisible, current_column, check_display_width):
1437 (check_display_width, scan_for_column, current_column_1)
1438 (Findent_to, Fcurrent_indentation, position_indentation)
1439 (indented_beyond_p, Fmove_to_column, compute_motion):
1440 (Fcompute_motion, Fvertical_motion):
1441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1442 (last_known_column_modified): Use EMACS_INT, not int.
1443 (check_display_width):
1444 (Fcompute_motion):
1445 Check that fixnums and floats are in proper range for system types.
1446 (compute_motion): Don't assume index or fixnum fits in int.
1447 (compute_motion, Fcompute_motion):
1448 Use int, not EMACS_INT, when it is wide enough.
1449 (vmotion): Omit local var start_hpos that is always 0; that way
1450 we don't need to worry about overflow in expressions involving it.
1451 * indent.h: Adjust decls to match defn changes elsewhere.
1452 (struct position):
1453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1454 Use int, not EMACS_INT, where int is wide enough.
1455 Remove unused members ovstring_chars_done and tab_offset;
1456 all uses removed.
1457 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1458 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1459 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1460 (make_gap, copy_text, insert, insert_and_inherit)
1461 (insert_before_markers, insert_before_markers_and_inherit)
1462 (insert_1, count_combining_before, count_combining_after)
1463 (insert_1_both, insert_from_string)
1464 (insert_from_string_before_markers, insert_from_string_1)
1465 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1466 (adjust_after_replace, adjust_after_insert, replace_range)
1467 (replace_range_2, del_range, del_range_1, del_range_byte)
1468 (del_range_both, del_range_2, modify_region)
1469 (prepare_to_modify_buffer, signal_before_change)
1470 (signal_after_change, Fcombine_after_change_execute):
1471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1472 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1473 (balance_an_interval, split_interval_right, split_interval_left)
1474 (find_interval, next_interval, update_interval)
1475 (adjust_intervals_for_insertion, delete_node, delete_interval)
1476 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1477 (static_offset_intervals, offset_intervals)
1478 (merge_interval_right, merge_interval_left, make_new_interval)
1479 (graft_intervals_into_buffer, temp_set_point_both)
1480 (temp_set_point, set_point, adjust_for_invis_intang)
1481 (set_point_both, move_if_not_intangible, get_property_and_range)
1482 (get_local_map, copy_intervals, copy_intervals_to_string)
1483 (compare_string_intervals, set_intervals_multibyte_1):
1484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1485 * intervals.h: Adjust decls to match defn changes elsewhere.
1486 (struct interval):
1487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1488 * keyboard.c (this_command_key_count, this_single_command_key_start)
1489 (before_command_key_count, before_command_echo_length, echo_now)
1490 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1491 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1492 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1493 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1495 (last_non_minibuf_size, last_point_position, echo_truncate)
1496 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1497 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1498 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1499 (stuff_buffered_input):
1500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1501 (last_auto_save, command_loop_1, read_char):
1502 Use EMACS_INT, not int, to avoid integer overflow.
1503 (record_char): Avoid overflow in total_keys computation.
1504 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1505 * keyboard.h: Adjust decls to match defn changes elsewhere.
1506 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1507 (Fkey_description, Fdescribe_vector, Flookup_key):
1508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1509 (click_position): New function, to check that positions are in range.
1510 (Fcurrent_active_maps):
1511 (describe_command):
1512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1513 (Faccessible_keymaps, Fkey_description):
1514 (preferred_sequence_p):
1515 Don't assume fixnum can fit into int.
1516 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1517 Check for integer overflow in size calculations.
1518 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1519 avoid mishandling large integers.
1520 * lisp.h: Adjust decls to match defn changes elsewhere.
1521 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1522 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1523 (struct Lisp_Marker):
1524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1525 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1526 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1527 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1528 All callers changed.
1529 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1530 Assume the arg has valid form, since it always does.
1531 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1532 unsigned integer system type.
1533 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1534 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1536 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1537 (duration_to_sec_usec): New decl.
1538 * lread.c (read_from_string_index, read_from_string_index_byte)
1539 (read_from_string_limit, readchar, unreadchar, openp)
1540 (read_internal_start, read1, oblookup):
1541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1542 (Fload, readevalloop, Feval_buffer, Feval_region):
1543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1544 (openp): Check for out-of-range argument to 'access'.
1545 (read1): Use int, not EMACS_INT, where int is wide enough.
1546 Don't assume fixnum fits into int.
6efdadfd 1547 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1548 (read_filtered_event): Use duration_to_sec_usec
1549 to do proper overflow checking on durations.
d311d28c
PE
1550 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1551 in size calculation.
1552 (Fexecute_kbd_macro):
1553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1554 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1555 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1556 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1557 (set_marker_both, set_marker_restricted_both, marker_position)
1558 (marker_byte_position, Fbuffer_has_markers_at):
1559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1560 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1561 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1562 It now merely ensures that the menu is large enough, without
1563 necessarily growing it, as this avoids some integer overflow issues.
1564 All callers changed.
1565 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1567 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1568 Use SAFE_ALLOCA_LISP, not alloca.
1569 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1570 to EMACS_INT. Check that fixnums are in proper range for system types.
1571 * minibuf.c (minibuf_prompt_width, string_to_object)
1572 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1573 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1575 (get_minibuffer, read_minibuf_unwind):
1576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1577 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1578 this simplifies overflow checking. All callers changed.
1579 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1580 (Ftest_completion):
1581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1582 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1583 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1584 Check that fixnums are in proper range for system types.
1585 (Fx_create_frame, Fx_show_tip):
1586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1587 * nsfont.m (ns_findfonts, nsfont_list_family):
1588 Don't assume fixnum fits in long.
1589 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1591 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1592 wide enough.
17fdb222 1593 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1595 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1596 (PRINTDECLARE, PRINTPREPARE):
1597 (strout, print_string):
1598 (print, print_preprocess, print_check_string_charset_prop)
1599 (print_object):
1600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1601 (PRINTDECLARE):
1602 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1604 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1605 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1606 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1607 (print_error_message): Use SAFE_ALLOCA, not alloca.
1608 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1609 (print_depth, new_backquote_output, print_number_index):
1610 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1611 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1612 (Fset_process_window_size, Fformat_network_address)
1613 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1614 (sigchld_handler):
d311d28c 1615 Check that fixnums are in proper range for system types.
d44287d4 1616 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1617 Check for process-ids out of pid_t range rather than relying on
1618 undefined behavior.
e4d81efc 1619 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1620 (Fformat_network_address, read_process_output, send_process)
1621 (Fprocess_send_region, status_notify):
1622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1623 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1624 (wait_reading_process_output, read_process_output, exec_sentinel):
1625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1626 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1627 (Faccept_process_output): Use duration_to_sec_usec to do proper
1628 overflow checking on durations.
dde14581
PE
1629 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1630 Don't assume pid_t fits in int.
02481186
PE
1631 * process.h (struct Lisp_Process): Members tick and update_tick
1632 are now of type EMACS_INT, not int.
b62b53e8
PE
1633 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1634 configured --with-wide-int.
d311d28c
PE
1635 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1636 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1637 * search.c (looking_at_1, string_match_1):
1638 (fast_string_match, fast_c_string_match_ignore_case)
1639 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1640 (scan_newline, find_before_next_newline, search_command)
1641 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1642 (set_search_regs, wordify):
1643 (Freplace_match):
1644 (Fmatch_data):
1645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1646 (string_match_1, search_buffer, set_search_regs):
1647 (Fmatch_data):
1648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1649 (wordify): Check for overflow in size calculation.
1650 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1651 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1652 Check that fixnums are in proper range for system types.
1653 * sound.c (struct sound_device)
1654 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1656 (Fplay_sound_internal):
1657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1658 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1659 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1660 (Fparse_partial_sexp):
1661 Don't assume fixnums can fit in int.
1662 (struct lisp_parse_state, find_start_pos, find_start_value)
1663 (find_start_value_byte, find_start_begv)
1664 (update_syntax_table, char_quoted, dec_bytepos)
1665 (find_defun_start, prev_char_comend_first, back_comment):
1666 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1667 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1669 (Finternal_describe_syntax_value): Check that match_lisp is a
1670 character, not an integer, since the code stuffs it into int.
1671 (scan_words, scan_sexps_forward):
1672 Check that fixnums are in proper range for system types.
1673 (Fforward_word):
1674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1675 (scan_sexps_forward):
1676 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1677 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1678 * syntax.h: Adjust decls to match defn changes elsewhere.
1679 (struct gl_state_s):
1680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1681 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1682 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1683 * sysdep.c (wait_for_termination_1, wait_for_termination)
1684 (interruptible_wait_for_termination, mkdir):
1685 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1686 (emacs_read, emacs_write):
1687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1688 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1689 and double all fit in int.
d311d28c
PE
1690 * term.c (set_tty_color_mode):
1691 Check that fixnums are in proper range for system types.
1692 * termhooks.h (struct input_event):
1693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1694 * textprop.c (validate_interval_range, interval_of)
1695 (Fadd_text_properties, set_text_properties_1)
1696 (Fremove_text_properties, Fremove_list_of_text_properties)
1697 (Ftext_property_any, Ftext_property_not_all)
1698 (copy_text_properties, text_property_list, extend_property_ranges)
1699 (verify_interval_modification):
1700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1701 (Fnext_single_char_property_change)
1702 (Fprevious_single_char_property_change):
1703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1704 (copy_text_properties):
1705 Check for integer overflow in index calculation.
d311d28c
PE
1706 * undo.c (last_boundary_position, record_point, record_insert)
1707 (record_delete, record_marker_adjustment, record_change)
1708 (record_property_change):
1709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1710 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1712 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1713 (Fx_hide_tip, Fx_file_dialog):
1714 * w32menu.c (set_frame_menubar):
1715 Use ptrdiff_t, not int, for consistency with rest of code.
1716 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1717 (select_window, Fdelete_other_windows_internal)
1718 (window_scroll_pixel_based, window_scroll_line_based)
1719 (Frecenter, Fset_window_configuration):
1720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1721 (Fset_window_hscroll, run_window_configuration_change_hook)
1722 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1723 (Fscroll_other_window, Frecenter):
d311d28c
PE
1724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1725 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1726 Don't assume fixnum fits in int.
1727 (Fset_window_scroll_bars):
1728 Check that fixnums are in proper range for system types.
1729 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1730 (string_pos, c_string_pos, number_of_chars, init_iterator)
1731 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1732 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1733 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1734 (face_before_or_after_it_pos, handle_invisible_prop)
1735 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1736 (display_prop_intangible_p, string_buffer_position_lim)
1737 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1738 (get_overlay_strings_1, get_overlay_strings)
1739 (iterate_out_of_display_property, forward_to_next_line_start)
1740 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1741 (get_next_display_element, set_iterator_to_next)
1742 (get_visually_first_element, compute_stop_pos_backwards)
1743 (handle_stop_backwards, next_element_from_buffer)
1744 (move_it_in_display_line_to, move_it_in_display_line)
1745 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1746 (add_to_log, message_dolog, message_log_check_duplicate)
1747 (message2, message2_nolog, message3, message3_nolog
1748 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1749 (current_message_1, truncate_echo_area, truncate_message_1)
1750 (set_message, set_message_1, store_mode_line_noprop)
1751 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1752 (text_outside_line_unchanged_p, check_point_in_composition)
1753 (reconsider_clip_changes)
1754 (redisplay_internal, set_cursor_from_row, try_scrolling)
1755 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1756 (redisplay_window, find_last_unchanged_at_beg_row)
1757 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1758 (trailing_whitespace_p, find_row_edges, display_line)
1759 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1760 (display_mode_element, store_mode_line_string)
1761 (pint2str, pint2hrstr, decode_mode_spec)
1762 (display_count_lines, display_string, draw_glyphs)
1763 (x_produce_glyphs, x_insert_glyphs)
1764 (rows_from_pos_range, mouse_face_from_buffer_pos)
1765 (fast_find_string_pos, mouse_face_from_string_pos)
1766 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1768 (safe_call, init_from_display_pos, handle_fontified_prop)
1769 (handle_single_display_spec, load_overlay_strings)
1770 (with_echo_area_buffer, setup_echo_area_for_printing)
1771 (display_echo_area, echo_area_display)
1772 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1773 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1774 (redisplay_window, dump_glyph_row, display_mode_line)
1775 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1776 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1778 (handle_single_display_spec, build_desired_tool_bar_string)
1779 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1780 (get_specified_cursor_type):
1781 Check that fixnums are in proper range for system types.
1782 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1783 (Flookup_image_map):
1784 Don't assume fixnums fit in int.
1785 (compare_overlay_entries):
1786 Avoid mishandling comparisons due to subtraction overflow.
1787 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1788 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1789 (handle_tool_bar_click):
1790 Use int, not unsigned, since we prefer signed and the signedness
1791 doesn't matter here.
1792 (get_next_display_element, next_element_from_display_vector):
1793 Use int, not EMACS_INT, when int is wide enough.
1794 (start_hourglass): Use duration_to_sec_usec to do proper
1795 overflow checking on durations.
1796 * xfaces.c (Fbitmap_spec_p):
1797 Check that fixnums are in proper range for system types.
1798 (compare_fonts_by_sort_order):
1799 Avoid mishandling comparisons due to subtraction overflow.
1800 (Fx_family_fonts, realize_basic_faces):
1801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1802 (Fx_family_fonts):
1803 Don't assume fixnum fits in int.
1804 Use SAFE_ALLOCA_LISP, not alloca.
1805 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1806 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1807 (face_at_buffer_position, face_for_overlay_string)
1808 (face_at_string_position):
1809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1810 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1811 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1812 (Fx_show_tip):
1813 Check that fixnums are in proper range for system types.
1814 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1815 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1817 (Fx_change_window_property): Don't assume fixnums fit in int.
1818 * xfont.c (xfont_chars_supported):
1819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1820 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1821 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1823 * xml.c (parse_region):
1824 * xrdb.c (magic_file_p):
1825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1826 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1827 (x_get_local_selection, x_reply_selection_request)
1828 (x_handle_selection_request, wait_for_property_change):
1829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1830 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1831 short is wide enough.
1832 (x_send_client_event): Don't assume fixnum fits in int.
1833 * xterm.c (x_x_to_emacs_modifiers):
1834 Don't assume EMACS_INT overflows nicely into int.
1835 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1836 may come from Lisp.
1837 (handle_one_xevent): NATNUMP can eval its arg twice.
1838 (x_connection_closed):
1839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1840 * xterm.h: Adjust decls to match defn changes elsewhere.
1841 (struct scroll_bar): Use struct vectorlike_header
1842 rather than rolling our own approximation.
1843 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1844
c6574eb5
GM
18452012-05-25 Glenn Morris <rgm@gnu.org>
1846
1847 * lisp.mk (lisp): Update for more files being compiled now.
1848
e8d32c7e
SM
18492012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1850
48def666
SM
1851 * lread.c: Remove `read_pure' which makes no difference.
1852 (read_pure): Remove var.
1853 (unreadpure): Remove function.
1854 (readevalloop): Don't call read_list with -1 flag.
1855 (read1, read_vector): Don't test read_pure any more.
1856 (read_list): Simplify.
1857
e8d32c7e
SM
1858 * fileio.c, character.h: Minor style tweaks.
1859
4b2addb7
DA
18602012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1861
1862 * window.h (clip_changed): Remove useless declaration.
1863
584461b2
JB
18642012-05-22 Juanma Barranquero <lekktu@gmail.com>
1865
1866 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1867 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1868
34374650
PE
18692012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1870
1871 Remove src/m/*.
1872 This directory predates autoconf and is no longer needed nowadays.
1873 Move its few remaining bits of functionality to where they're needed.
1874 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1875 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1876 * m/template.h: Remove.
1877 * Makefile.in (M_FILE): Remove. All uses removed.
1878 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1879 * lisp.h (USE_LSB_TAG):
1880 * mem-limits.h (EXCEEDS_LISP_PTR):
1881 Use VAL_MAX, not VALBITS, in #if.
1882 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1883 (EMACS_UINT): Define unconditionally now.
1884 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1885 (BITS_PER_EMACS_INT): New constants, replacing
1886 what used to be in config.h, but not useful in #if.
1887 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1888 define them any more.
1889 (VAL_MAX): New macro.
1890 (VALMASK): Use it.
1891 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1892 BITS_PER_EMACS_INT, in #if.
1893 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1894 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1895 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1896 * s/ms-w32.h (DATA_START):
1897 Move here from removed file m/intel386.h.
1898 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1899 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1900
261cb4bb
PE
19012012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 Assume C89 or later.
1904 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1905 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1906 (xrealloc):
1907 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1908 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1909 * textprop.c, tparam.c (NULL): Remove.
1910 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1911 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1912 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1913 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1914 * xterm.c (input_signal_count): Assume volatile works.
1915
ff23cd9f
KB
19162012-05-21 Ken Brown <kbrown@cornell.edu>
1917
1918 * xgselect.c (xg_select): Fix first argument in call to 'select'
1919 (bug#11508).
1920
1b170bc6
KB
19212012-05-20 Ken Brown <kbrown@cornell.edu>
1922
1923 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1924 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1925
b2f4d39f
KB
19262012-05-19 Ken Brown <kbrown@cornell.edu>
1927
1928 * xfns.c (x_in_use): Remove `static' qualifier.
1929 * xterm.h (x_in_use): Declare.
1930 * xgselect.c: Include xterm.h.
1931 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1932 and `display_arg' (bug#9754).
1933
003fdae2
PE
19342012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1935
9232a6d9
PE
1936 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1937
003fdae2
PE
1938 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1939 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1940
784b56e2
EZ
19412012-05-18 Eli Zaretskii <eliz@gnu.org>
1942
1943 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1944
1945 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1946 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1947
1948 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1949 reference to image_cache->refcount.
1950 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1951
a0a79cde
JL
19522012-05-17 Juri Linkov <juri@jurta.org>
1953
1954 * search.c (Fword_search_regexp, Fword_search_backward)
1955 (Fword_search_forward, Fword_search_backward_lax)
1956 (Fword_search_forward_lax): Move functions to isearch.el
1957 (bug#10145, bug#11381).
1958
b0572523
PE
19592012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1962
9660f5fc
SM
19632012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1964
1965 * lread.c (init_obarray): Declare Qt and Qnil as special.
1966
4374de83
GM
19672012-05-14 Glenn Morris <rgm@gnu.org>
1968
1969 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1970 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1971
dc44c39a
PE
19722012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1973
078c97cb
PE
1974 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1975
dc44c39a
PE
1976 * unexaix.c: Port to more-recent AIX compilers.
1977 (report_error, report_error_1, make_hdr, copy_sym)
1978 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1979 Make arguments const char *, not char *, to avoid violations of C
1980 standard and to fix some AIX warnings reported by Gilles Pion.
1981
e18afed7 19822012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1983
1984 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1985 already have overlays loaded.
1986 (handle_single_display_spec): Before returning without displaying
1987 fringe bitmap, synchronize the bidi iterator with the main display
1988 iterator, by calling iterate_out_of_display_property.
1989 (iterate_out_of_display_property): Detect buffer iteration by
1990 testing that it->string is a Lisp string.
1991 (get_next_display_element): When the current object is exhausted,
1992 and there's something on it->stack, call set_iterator_to_next to
1993 proceed with what's on the stack, instead of returning zero.
1994 (set_iterator_to_next): If called at the end of a Lisp string,
1995 proceed to consider_string_end without incrementing string
1996 position. Don't increment display vector index past the end of
1997 the display vector. (Bug#11417)
c8fb9dc6
EZ
1998 (pos_visible_p): Don't report a position visible when move_it_to
1999 stopped at the last line of window, which happens to be scanned
2000 backwards by the bidi iteration. (Bug#11464)
ac268e67 2001
e18afed7 20022012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2003
2004 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2005 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2006 are on a TTY, and thus unable to display on the fringes.
2007 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2008 so we need to signal to the caller that this is a "replacing"
2009 display spec. This fixes display when the spec is invalid or we
2010 are on a TTY.
2011
e18afed7 20122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2013
2014 * unexaix.c (make_hdr): Fix typo in prototype.
2015 This bug broke the build on AIX. Problem reported by Gilles Pion.
2016
9d0a235a
MA
20172012-05-14 Michael Albinus <michael.albinus@gmx.de>
2018
2019 * keyboard.c (kbd_buffer_get_event): Read special events also in
2020 batch mode. (Bug#11415)
2021
9e6b06ed
GM
20222012-05-12 Glenn Morris <rgm@gnu.org>
2023
2024 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2025
c1a1d7a3
EZ
20262012-05-12 Eli Zaretskii <eliz@gnu.org>
2027
2028 * lisp.mk (lisp): Add newcomment.elc.
2029
3fe7cdc8
GM
20302012-05-12 Glenn Morris <rgm@gnu.org>
2031
2032 * Makefile.in (MKDIR_P): New, set by configure.
2033 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2034
53f7d2c0
PE
20352012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2036
2037 Remove unused function hourglass_started.
2038 * dispextern.h (hourglass_started):
2039 * w32fns.c (hourglass_started):
2040 * xdisp.c (hourglass_started): Remove.
2041
75aafb17
JB
20422012-05-10 Juanma Barranquero <lekktu@gmail.com>
2043
2044 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2045 Update dependencies.
2046
12959e8e
PE
20472012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2048
97107e2e
PE
2049 * xgselect.c (xg_select): Put maxfds+1 into a var.
2050 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2051
12959e8e
PE
2052 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2053
836d29b3
DA
20542012-05-10 Dave Abrahams <dave@boostpro.com>
2055
2056 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2057 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2058
5cb67954
MA
20592012-05-09 Michael Albinus <michael.albinus@gmx.de>
2060
2061 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2062 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2063 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2064 Initialize xd_registered_buses.
2065
3478ec45
PE
20662012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2067
b263a6b0
PE
2068 Untag more efficiently if USE_LSB_TAG.
2069 This is based on a proposal by YAMAMOTO Mitsuharu in
2070 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2071 For an admittedly artificial (nth 8000 longlist) benchmark on
2072 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2073 Emacs's overall text size by 1%.
2074 * lisp.h (XUNTAG): New macro.
2075 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2076 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2077 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2078 * eval.c (Fautoload):
2079 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2080 * frame.h (XFRAME): Use XUNTAG.
2081
3478ec45
PE
2082 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2083 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2084 Remove unportable assumptions about print widths of types like
2085 dbus_uint32_t.
2086 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2087 intptr_t when converting between pointer and integer, to avoid GCC
2088 warnings about wrong width.
2089
666b903b 20902012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2091
2092 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2093 stack for each reader_thread, instead of defaulting to 8MB
2094 determined by the linker. This avoids failures in creating
2095 subprocesses on Windows 7, see the discussion in this thread:
2096 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2097
b120cc17
JC
20982012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2099
2100 Fix up display of the *Minibuf-0* buffer in the mini window.
2101 * keyboard.c (read_char): Don't clear the echo area if there's no
2102 message to clear.
2103 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2104 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2105
9a4b36f8
MA
21062012-05-07 Michael Albinus <michael.albinus@gmx.de>
2107
2108 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2109 batch mode.
2110
e5f9458f
CY
21112012-05-06 Chong Yidong <cyd@gnu.org>
2112
2113 * lisp.mk (lisp): Update.
2114
eceeb5fc 21152012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2116
2117 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2118
71873e2b
SM
21192012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2120
2121 * data.c (PUT_ERROR): New macro.
2122 (syms_of_data): Use it. Add new error type `user-error'.
2123 * undo.c (user_error): New function.
2124 (Fprimitive_undo): Use it.
2125 * print.c (print_error_message): Adjust print style for `user-error'.
2126 * keyboard.c (user_error): New function.
2127 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2128
ab0fa4e4
PE
21292012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2130
2131 Do not limit current-time-string to years 1000..9999.
2132 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2133 (Fcurrent_time_string): Support any year that is supported by the
2134 underlying localtime representation. Don't use asctime, as it
2135 has undefined behavior for years outside the range -999..9999.
2136
7ed806a7
PE
21372012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 Fix race conditions involving setenv, gmtime, localtime, asctime.
2140 Without this fix, interrupts could mess up code that uses these
2141 nonreentrant functions, since setting TZ invalidates existing
2142 tm_zone or tzname values, and since most of these functions return
2143 pointers to static storage.
2144 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2145 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2146 Grow the critical sections to include not just invoking
2147 localtime/gmtime, but also accessing these functions' results
2148 including their tm_zone values if any, and any related TZ setting.
2149 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2150 so that the struct tm is saved in the critical section.
2151 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2152 motivated by the fact that memory allocation needs to be outside
2153 the critical section.
2154
0c16dfed
DA
21552012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2156
2157 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2158 with RESET_INTERVAL.
2159
2160 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2161 Remove duplicated buffer name initialization.
2162
3f83ace8
JM
21632012-05-02 Jim Meyering <jim@meyering.net>
2164
2165 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2166
c7b8541e
JM
2167 * xfns.c (x_window): Use xstrdup (Bug#11375).
2168
90207a15 21692012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2170
2171 * xdisp.c (pos_visible_p): If already at a newline from the
2172 display string before the 'while' loop, don't walk back the glyphs
2173 from it3.glyph_row. Solves assertion violation when the display
2174 string begins with a newline (egg.el). (Bug#11367)
2175
b593d6a9
AH
21762012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2177
2178 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2179 Move to simple.el.
2180
4737362e
GM
21812012-05-01 Glenn Morris <rgm@gnu.org>
2182
99cf43f9
GM
2183 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2184 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2185 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2186 All were removed before 23.1.
2187
9311dcff
GM
2188 * dispnew.c: Remove HAVE_LIBNCURSES test;
2189 it is always true on relevant platforms.
2190
4d5c6349
GM
2191 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2192 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2193
4737362e
GM
2194 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2195
74dd3a6b
AS
21962012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2197
2198 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2199 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2200 Remove.
2201
13c379ee
PE
22022012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 Do not avoid creating empty evaporating overlays (Bug#9642).
2205 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2206 That is, do not delete an evaporating overlay if it becomes
2207 empty after its bounds are adjusted to fit within its buffer.
2208 This fix caused other problems, and I'm reverting it until we get
2209 to the bottom of them.
2210
a8e7d6d7 22112012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2212
2213 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2214
a8e7d6d7 22152012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2216
2217 * xdisp.c (pos_visible_p): If the window start position is beyond
2218 ZV, start the display from buffer beginning. Prevents assertion
2219 violation in init_iterator when the minibuffer window is scrolled
2220 via the scroll bar.
2221
2222 * window.c (window_scroll_pixel_based): Likewise.
2223
a8e7d6d7 22242012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2225
2226 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2227
a8e7d6d7 22282012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2229
2230 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2231 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2232
a8e7d6d7 22332012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2234
b593d6a9
AH
2235 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2236 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2237
1c6900d9
EZ
22382012-04-26 Eli Zaretskii <eliz@gnu.org>
2239
4c3fa1d9
EZ
2240 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2241 display element, check also the underlying string or buffer
2242 character. (Bug#11341)
2243
1c6900d9
EZ
2244 * w32menu.c: Include w32heap.h.
2245 (add_menu_item): If the call to AppendMenuW (via
2246 unicode_append_menu) fails, disable Unicode menus only if we are
2247 running on Windows 9X/Me.
2248
42bf8205
AS
22492012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2250
2251 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2252 (xgetint): Add missing shift for LSB tags.
2253
b1bac16e
MR
22542012-04-24 Martin Rudalics <rudalics@gmx.at>
2255
2256 * keyboard.c (read_char): Don't wipe echo area for select window
2257 events: These might get delayed via `mouse-autoselect-window'
2258 (Bug#11304).
2259
d69621cc
JB
22602012-04-24 Juanma Barranquero <lekktu@gmail.com>
2261
2262 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2263 manipulation of :loaded-from data.
2264
02fd101b
JB
22652012-04-23 Juanma Barranquero <lekktu@gmail.com>
2266
2267 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2268 now a cons (bug#11311).
2269
888bec30
PE
22702012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2271
89a438bd
PE
2272 Do not create empty overlays with the evaporate property (Bug#9642).
2273 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2274 if it becomes empty after its bounds are adjusted to fit within
2275 its buffer. Without this fix, in a nonempty buffer (let ((o
2276 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2277 yields an empty overlay that has the evaporate property, which is
2278 not supposed to happen.
2279
1068fe4d
PE
2280 Fix minor GTK3 problems found by static checking.
2281 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2282 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2283 (struct _EmacsFixedClass, emacs_fixed_get_type):
2284 Move decls here from emacsgtkfixed.h, since they needn't be public.
2285 (emacs_fixed_get_type): Now static.
2286 (emacs_fixed_class_init): Omit unused local.
2287 (emacs_fixed_child_type): Remove; unused.
2288 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2289 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2290 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2291 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2292 (EMACS_FIXED_GET_CLASS): Remove; unused.
2293 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2294
888bec30
PE
2295 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2296 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2297
de85e130
PE
22982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2299
d0baac98 2300 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2301 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2302 (__malloc_size_t, __malloc_ptrdiff_t):
2303 Remove. All uses removed, replaced by the definiens if needed,
2304 since we can assume C89 or better now.
2305 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2306 (protect_malloc_state, align, get_contiguous_space)
2307 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2308 (malloc_atfork_handler_child, malloc_enable_thread)
2309 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2310 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2311 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2312 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2313 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2314 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2315 Define using prototypes, not old style.
2316 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2317 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2318 (align): Don't assume that signed integer overflow wraps around.
2319 Omit unused local var.
2320 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2321 (_free_internal_nolock, memalign, mallochook, reallochook):
2322 Omit no-longer-needed casts.
2323 (valloc): Use getpagesize, not __getpagesize.
2324 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2325 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2326
de85e130
PE
2327 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2328
dcbf5805
MA
23292012-04-22 Michael Albinus <michael.albinus@gmx.de>
2330
2331 Move functions from C to Lisp. Make non-blocking method calls
2332 the default. Implement further D-Bus standard interfaces.
2333
2334 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2335 (QCdbus_request_name_allow_replacement)
2336 (QCdbus_request_name_replace_existing)
2337 (QCdbus_request_name_do_not_queue)
2338 (QCdbus_request_name_reply_primary_owner)
2339 (QCdbus_request_name_reply_in_queue)
2340 (QCdbus_request_name_reply_exists)
2341 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2342 (QCdbus_registered_serial, QCdbus_registered_method)
2343 (QCdbus_registered_signal): New Lisp objects.
2344 (XD_DEBUG_MESSAGE): Use sizeof.
2345 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2346 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2347 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2348 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2349 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2350 (xd_signature, xd_append_arg): Allow float for integer types.
2351 (xd_get_connection_references): New function.
b593d6a9
AH
2352 (xd_get_connection_address): Rename from xd_initialize.
2353 Return cached address.
dcbf5805
MA
2354 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2355 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2356 level.
2357 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2358 Return number of refcounts.
dcbf5805
MA
2359 (Fdbus_get_unique_name): Make stronger parameter check.
2360 (Fdbus_message_internal): New defun.
2361 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2362 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2363 (Fdbus_send_signal, Fdbus_register_service)
2364 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2365 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2366 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2367 (Vdbus_compiled_version, Vdbus_runtime_version)
2368 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2369 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2370 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2371 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2372 Adapt docstring.
dcbf5805 2373
52828e02
PE
23742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2375
da05bc4c
PE
2376 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2377 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2378 Do not assume ptrdiff_t is the same width as 'int'.
2379
52828e02
PE
2380 * alloc.c: Handle unusual debugging option combinations.
2381 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2382 since the two debugging options are incompatible.
2383 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2384 is defined.
2385 (mem_init, mem_insert, mem_insert_fixup):
2386 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2387 (NEED_MEM_INSERT): Remove; no longer needed.
2388
f01769f9
LL
23892012-04-22 Leo Liu <sdl.web@gmail.com>
2390
2391 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2392
5790543d
PE
23932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 * sysdep.c [__FreeBSD__]: Minor cleanups.
2396 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2397 Use Emacs indenting style more consistently. Avoid some casts.
2398 Use 'double' consistently rather than mixing 'float' and 'double'.
2399
b91b7e4d
EW
24002012-04-21 Eduard Wiebe <usenet@pusto.de>
2401
b593d6a9
AH
2402 * sysdep.c (list_system_processes, system_process_attributes):
2403 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2404
6114eb15
AS
24052012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2406
2407 * lisp.mk (lisp): Update.
2408
2f38dff7
PE
24092012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2410
2411 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2412 It is never used otherwise.
2413
4ae29f89
SM
24142012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2415
2416 * print.c (print_preprocess): Only check print_depth if print-circle
2417 is nil.
2418 (print_object): Check for cycles even when print-circle is nil and
2419 print-gensym is t, but only check print_depth if print-circle is nil.
2420
f30d612a
CY
24212012-04-20 Chong Yidong <cyd@gnu.org>
2422
2423 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2424 set the status to "failed" and ensure that sentinel is run.
2425
c07a4c0b 24262012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2427
2428 * process.c (Fset_process_inherit_coding_system_flag)
2429 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2430 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2431
c07a4c0b 24322012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2433
2434 * xdisp.c (string_buffer_position_lim): Limit starting position to
2435 BEGV.
2436 (set_cursor_from_row): If called for a mode-line or header-line
2437 row, return zero immediately.
2438 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2439 farther than the first row after the header line, if any.
2440 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2441 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2442
c07a4c0b 24432012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2444
4ae29f89
SM
2445 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2446 (bug#11238).
ad3a2b41 2447
c07a4c0b 24482012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 24492012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2450
2451 configure: new option --enable-gcc-warnings (Bug#11207)
2452 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2453 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2454 (ALL_CFLAGS): Use new macros rather than old.
2455 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2456 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2457 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2458 -Wunused-result, -Wunused-variable. This should go away once
2459 the Emacs and Gnulib regex code is merged.
2460 (xmalloc, xrealloc): Now static.
2461
aba027e8
PE
24622012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * dired.c (Fsystem_groups): Remove unused local.
2465
e5a36063
GM
24662012-04-17 Glenn Morris <rgm@gnu.org>
2467
2468 * dired.c (Fsystem_users): Doc fix.
2469
316411f0
DA
24702012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2471
2472 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2473 (syms_of_dired): Add them.
2474
9426aba4
PE
24752012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2476
b62a57be
PE
2477 Fix minor alloc.c problems found by static checking.
2478 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2479 New extern decls, to avoid calling undeclared functions.
2480 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2481 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2482 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2483 (NEED_MEM_INSERT): New macro.
2484 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2485 Remove one incorrect comment and fix another.
b62a57be 2486
3539f31f
PE
2487 Fix minor ralloc.c problems found by static checking.
2488 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2489 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2490 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2491 (r_alloc_sbrk): Now static.
2492
a041960a
PE
2493 Improve ralloc.c interface checking.
2494 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2495 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2496 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2497 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2498 [REL_ALLOC]: ... to here, to check interface.
2499 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2500 Remove decls. This fixes an "It stinks!".
2501
9426aba4
PE
2502 * alloc.c (which_symbols): Fix alignment issue / type clash.
2503
d55c12ed
AS
25042012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2505
2506 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2507 (struct Lisp_Misc_Any): Likewise.
2508 (struct Lisp_Free): Likewise.
2509 * alloc.c (union aligned_Lisp_Symbol): Define.
2510 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2511 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2512 (union aligned_Lisp_Misc): Define.
2513 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2514 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2515 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2516
b948ce8b
PE
25172012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2518
2519 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2520 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2521 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2522 * s/netbsd.h, s/sol2-6.h:
2523 Remove definition of GC_MARK_STACK, since the default now works.
2524 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2525 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2526 no longer the default.
2527 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2528
35dc09a1 25292012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2530
35dc09a1
GM
2531 * lread.c (lisp_file_lexically_bound_p):
2532 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2533
35dc09a1
GM
25342012-04-14 Eli Zaretskii <eliz@gnu.org>
2535
2536 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2537 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2538
25392012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2540
2541 * nsterm.m (constrainFrameRect): Always constrain when there is only
2542 one screen (Bug#10962).
2543
bcd86815
KB
25442012-04-13 Ken Brown <kbrown@cornell.edu>
2545
2546 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2547
c25df26e
RT
25482012-04-13 Reuben Thomas <rrt@sc3d.org>
2549
2550 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2551
0fc59f1e
DC
25522012-04-11 Daniel Colascione <dancol@dancol.org>
2553
2554 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2555 against is gone. It's better to use vfork now so that when Cygwin
2556 gains a new, working vfork, we use it automatically (bug#10398).
2557
de8c03dc
SM
25582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2559
2560 * window.c (save_window_save): Obey window-point-insertion-type.
2561
2f097256
GM
25622012-04-11 Glenn Morris <rgm@gnu.org>
2563
2564 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2565
453b951e
SM
25662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2567
2568 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2569
75f1671a 25702012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2571
2572 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2573 (force_quit_count): New var.
2574 (handle_interrupt): Use it.
2575
2a8ce227
JB
25762012-04-10 Juanma Barranquero <lekktu@gmail.com>
2577
2578 * w32.c (w32_delayed_load): Record the full path of the library
2579 being loaded (bug#10424).
2580
935396c0
GM
25812012-04-09 Glenn Morris <rgm@gnu.org>
2582
05920a43
GM
2583 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2584 not just in the obarray, before snarfing them. (Bug#11036)
2585
935396c0
GM
2586 * Makefile.in ($(leimdir)/leim-list.el):
2587 Pass EMACS rather than BUILT_EMACS.
2588
a18ecafa
TZ
25892012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2590
2591 * process.c (make_process):
2592 * process.h: Add integer `gnutls_handshakes_tried' member to
2593 process struct.
2594
6bbef4e5
JC
2595 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2596 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2597
2598 * gnutls.c (gnutls_log_function2i): Convenience log function.
2599 (emacs_gnutls_read): Use new log functions,
2600 `gnutls_handshakes_tried' process member, and
2601 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2602 attempts per process (connection).
2603
b4d3bc10
CY
26042012-04-09 Chong Yidong <cyd@gnu.org>
2605
2606 * eval.c (Fuser_variable_p, user_variable_p_eh)
2607 (lisp_indirect_variable): Functions deleted.
2608 (Fdefvar): Caller changed.
2609
2610 * callint.c (Finteractive, Fcall_interactively):
2611 * minibuf.c (Fread_variable): Callers changed.
2612
70f4d973
EZ
26132012-04-09 Eli Zaretskii <eliz@gnu.org>
2614
2615 * xdisp.c (set_cursor_from_row): If the display string appears in
2616 the buffer at position that is closer to point than the position
2617 after the display string, display the cursor on the first glyph of
2618 the display string. Fixes cursor display when a 'display' text
2619 property immediately follows invisible text. (Bug#11094)
2620
cb3c2e3e
PE
26212012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 composite.c: use 'double' consistently
2624 * composite.c (get_composition_id): Use 'double' consistently
2625 instead of converting 'float' to 'double' and vice versa; this is
2626 easier to understand and avoids a GCC warning.
2627
fd06db5d
GM
26282012-04-09 Glenn Morris <rgm@gnu.org>
2629
50fe702a
GM
2630 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2631 preparation for dumping it with emacs. (Bug#4789)
2632 (leimdir): New variable.
2633 ($(leimdir)/leim-list.el): New rule.
2634 (emacs$(EXEEXT)): Depend on leim-list.el.
2635
fd06db5d
GM
2636 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2637 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2638 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2639
55c131ee
AS
26402012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2641
2642 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2643 proper alignment.
2644
9209588f
JB
26452012-04-07 Juanma Barranquero <lekktu@gmail.com>
2646
2647 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2648 Remove unused local variable.
2649
e3fb2efb
PE
26502012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2651
2652 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2653 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2654 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2655 objects, as mark_maybe_pointer will catch them otherwise.
2656 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2657 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2658
b5385551
PE
26592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 Fix typo that broke non-Windows builds.
2662 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2663
9078ead6
EZ
26642012-04-07 Eli Zaretskii <eliz@gnu.org>
2665
2666 Support building on MS-Windows with libxml2.
2667
2668 * makefile.w32-in (OBJ2): Add xml.$(O).
2669 (GLOBAL_SOURCES): Add xml.c.
2670 ($(BLD)/xml.$(O)): New dependency list.
2671
2672 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2673 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2674 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2675 [!WINDOWSNT]: New macros.
2676 (init_libxml2_functions, libxml2_loaded_p): New functions.
2677 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2678 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2679 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2680 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2681 linked in).
6bbef4e5
JC
2682 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2683 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2684 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2685
2686 * emacs.c: Don't include libxml/parser.h.
2687 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2688 xmlCleanupParser directly.
2689
2690 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2691
3811fdf3
EZ
26922012-04-07 Eli Zaretskii <eliz@gnu.org>
2693
2694 * indent.c (Fvertical_motion): If there is a display string at
2695 point, use it.vpos to compute how many lines to backtrack after
2696 move_it_to point. (Bug#11133)
2697
2f8e16b2
EZ
26982012-04-06 Eli Zaretskii <eliz@gnu.org>
2699
2700 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2701 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2702 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2703 macros related to unification of CJK characters. For the details,
2704 see the discussion following the message here:
2705 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2706
3d439cd1
CY
27072012-04-04 Chong Yidong <cyd@gnu.org>
2708
2709 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2710
8bc53d00
EZ
27112012-04-01 Eli Zaretskii <eliz@gnu.org>
2712
2713 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2714 instead of alloca. (Bug#11138)
2715
3b0512a3
AS
27162012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2717
2718 * w32menu.c (is_simple_dialog): Properly check lisp types.
2719 (Bug#11141)
2720
8427ddd2
EZ
27212012-03-31 Eli Zaretskii <eliz@gnu.org>
2722
979022ef
EZ
2723 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2724 position we get to after a call to move_it_to fails the
2725 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2726 only if we wind up in a string from display property. (Bug#11063)
2727
a6b1c7cc
EZ
2728 * window.c (Fdelete_other_windows_internal): Invalidate the row
2729 and column information about mouse highlight, so that redisplay
2730 restores it after reallocating the glyph matrices. (Bug#7464)
2731
8427ddd2
EZ
2732 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2733 string comes from a `display' text property, use the buffer
2734 position of that property as if we actually saw that position in
2735 the row's glyphs.
697ba24b
EZ
2736 (move_it_by_lines): Remove the assertion that
2737 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2738 violated when there's a before-string at the beginning of a line.
2739 (Bug#11063)
8427ddd2 2740
65a0a738
EZ
27412012-03-30 Eli Zaretskii <eliz@gnu.org>
2742
2743 * xdisp.c (append_space_for_newline): If the default face was
2744 remapped, use the remapped face for the appended newline.
2745 (extend_face_to_end_of_line): Use the remapped default face for
2746 extending the face to the end of the line.
2747 (display_line): Call extend_face_to_end_of_line when the default
2748 face was remapped. (Bug#11068)
2749
581355cc
EZ
27502012-03-29 Eli Zaretskii <eliz@gnu.org>
2751
2752 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2753
e8fc049f
SM
27542012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2755
2756 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2757
4fb9a543
GM
27582012-03-27 Glenn Morris <rgm@gnu.org>
2759
2760 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2761 Doc fixes.
2762
679910f1
KH
27632012-03-26 Kenichi Handa <handa@m17n.org>
2764
2765 * dispextern.h (struct glyph): Fix previous change. Change the
2766 bit length of glyphless.ch to 25 (Bug#11082).
2767
90d49b7f
CY
27682012-03-26 Chong Yidong <cyd@gnu.org>
2769
2770 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2771 (command_loop_1): Use it; inhibit selection update for
2772 handle-select-window too (Bug#8996).
2773
f514f6f0
FP
27742012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2775
e8fc049f 2776 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2777
bf43fa51
KH
27782012-03-25 Kenichi Handa <handa@m17n.org>
2779
2780 * dispextern.h (struct glyph): Change the bit length of
2781 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2782
8a0c01dd
EZ
27832012-03-24 Eli Zaretskii <eliz@gnu.org>
2784
2785 * s/ms-w32.h (tzname): Include time.h before redirecting to
2786 _tzname. Fixes the MSVC build. (Bug#9960)
2787
7d1c3a76
AS
27882012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2789
8ed79523
AS
2790 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2791 characters.
2792
7d1c3a76
AS
2793 * xterm.c (XTread_socket): Only modify handling_signal if
2794 !SYNC_INPUT. (Bug#11080)
2795
e99a9b8b
EZ
27962012-03-23 Eli Zaretskii <eliz@gnu.org>
2797
2798 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2799 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2800 when fetching a multibyte character consumes more bytes than
2801 CHAR_BYTES returns, due to unification of CJK characters in
2802 string_char. (Bug#11073)
2803
5063c0e1
TN
28042012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2805
2806 * process.c (wait_reading_process_output): Handle pty disconnect
2807 by refraining from sending oneself a SIGCHLD (bug#10933).
2808
9f851fbd
CY
28092012-03-22 Chong Yidong <cyd@gnu.org>
2810
2811 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2812
5063c0e1 2813 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2814 Mark string as coming from a prefix property.
2815 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2816 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2817
fb5b8aca
CY
28182012-03-21 Chong Yidong <cyd@gnu.org>
2819
2820 * xfaces.c (Vface_remapping_alist): Doc fix.
2821
62356a1b
EZ
28222012-03-20 Eli Zaretskii <eliz@gnu.org>
2823
2824 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2825 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2826 Doc fixes.
62356a1b 2827
025de85b
CY
28282012-03-20 Chong Yidong <cyd@gnu.org>
2829
2830 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2831 to reflect default non-nil value of redisplay-dont-pause.
2832
4827f94e
KH
28332012-03-19 Kenichi Handa <handa@m17n.org>
2834
2835 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2836 it fit in a valid range (Bug#11003).
2837
e50a24a2
EZ
28382012-03-18 Eli Zaretskii <eliz@gnu.org>
2839
2840 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2841 that is not from display property, accept the row as a "cursor
2842 row" if one of the string's character has a non-nil `cursor'
2843 property. Fixes cursor positioning when there are newlines in
2844 overlay strings, e.g. in icomplete.el. (Bug#11035)
2845
9af5ed87
PE
28462012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2849
d1f55f16
CY
28502012-03-12 Chong Yidong <cyd@gnu.org>
2851
2852 * eval.c (inhibit_lisp_code): Rename from
2853 inhibit_window_configuration_change_hook; move from window.c.
2854
2855 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2856 * window.c (run_window_configuration_change_hook)
2857 (syms_of_window): Callers changed.
2858
66c5eebd
CY
28592012-03-11 Chong Yidong <cyd@gnu.org>
2860
413df973
CY
2861 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2862
66c5eebd
CY
2863 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2864
1de11f56
CY
28652012-03-10 Chong Yidong <cyd@gnu.org>
2866
2867 * frame.c (other_visible_frames): Don't assume the selected frame
2868 is visible (Bug#10955).
2869
cae07000
SM
28702012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2871
2872 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2873
89c94350
JD
28742012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2875
2876 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2877 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2878 zero (Bug#10954).
2879
999dd333
GM
28802012-03-03 Glenn Morris <rgm@gnu.org>
2881
01a6dcc8 2882 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2883
de0100f2
EZ
28842012-03-02 Eli Zaretskii <eliz@gnu.org>
2885
2886 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2887 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2888 (redisplay_window, next_element_from_string): Fix typos in
2889 comments.
3e441275
EZ
2890 (redisplay_window): Pass to move_it_vertically the margin in
2891 pixels, not in screen lines.
de0100f2 2892
96a72ee9
GM
28932012-03-02 Glenn Morris <rgm@gnu.org>
2894
2895 * buffer.c (buffer-list-update-hook): Doc fix.
2896
312508d7
EZ
28972012-02-29 Eli Zaretskii <eliz@gnu.org>
2898
2899 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2900 push_it before setting up the iterator for the first overlay
2901 string, even if we have an empty string loaded.
2902 (next_overlay_string): If there's an empty string on the iterator
2903 stack, pop the stack. (Bug#10903)
2904
27f3c637
PE
29052012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2906
2907 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2908 Suggested by Stefan Monnier in
2909 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2910 * alloc.c (widen_to_Lisp_Object): New static function.
2911 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2912 and widening them to Lisp_Objects. This would work even if
2913 USE_LSB_TAG is defined and wide integers are used, which might
2914 happen in a future version of Emacs.
2915
3c9dfce6
CY
29162012-02-25 Chong Yidong <cyd@gnu.org>
2917
fa74b241
CY
2918 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2919 Doc fix.
2920
3c9dfce6
CY
2921 * xselect.c (Fx_selection_exists_p): Doc fix.
2922 (x_clipboard_manager_save_all): Print an informative message
2923 before saving to clipboard manager.
2924
9486df08
CY
29252012-02-24 Chong Yidong <cyd@gnu.org>
2926
2927 * keyboard.c (process_special_events): Handle all X selection
2928 requests in kbd_buffer, not just the next one (Bug#8869).
2929
f01d3321
CY
29302012-02-23 Chong Yidong <cyd@gnu.org>
2931
2932 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2933 call when setting menu-bar-lines and tool-bar-lines parameters.
2934 (unwind_create_frame_1): New helper function.
2935
2936 * window.c (inhibit_window_configuration_change_hook): New var.
2937 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2938 (syms_of_window): Initialize it.
f01d3321 2939
86b847b6
CY
29402012-02-22 Chong Yidong <cyd@gnu.org>
2941
2942 * xterm.c (x_draw_image_relief): Add missing type check for
2943 Vtool_bar_button_margin (Bug#10743).
2944
a59225b1
CY
29452012-02-21 Chong Yidong <cyd@gnu.org>
2946
2947 * fileio.c (Vfile_name_handler_alist): Doc fix.
2948
2949 * buffer.c (Fget_file_buffer): Protect against invalid file
2950 handler return value.
2951
310f5bd4
PE
29522012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2953
cb3a28cc
PE
2954 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2955 when computing $valmask.
2956
310f5bd4
PE
2957 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2958 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2959 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2960 It's useless in that case, and it can cause problems on hosts
2961 that allocate halves of EMACS_INT values separately.
2962 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2963 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2964 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2965 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2966 it avoids undefined behavior on hosts where shifting right by more
2967 than the word width has undefined behavior.
2968
2375c96a
CY
29692012-02-19 Chong Yidong <cyd@gnu.org>
2970
2971 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2972 (Funhandled_file_name_directory, Ffile_name_as_directory)
2973 (Fdirectory_file_name, Fexpand_file_name)
2974 (Fsubstitute_in_file_name): Protect against invalid file handler
2975 return values (Bug#10845).
2976
3eb49e71
EZ
29772012-02-18 Eli Zaretskii <eliz@gnu.org>
2978
2979 * .gdbinit (pitx): Fix incorrect references to fields of the
2980 iterator stack.
2981
7b926f3f
CY
29822012-02-17 Chong Yidong <cyd@gnu.org>
2983
2984 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2985
11273115
PE
29862012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2989 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2990
c3a70e2b
CY
29912012-02-15 Chong Yidong <cyd@gnu.org>
2992
2993 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2994 marked as special. Also, starting docstrings with * is obsolete.
2995
0ca43699
AS
29962012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2997
2998 * gnutls.c (emacs_gnutls_write): Fix last change.
2999
2e8f3c56
LI
30002012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3001
3002 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3003 send_process.
3004
af70074f
SM
30052012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3006
3007 * keymap.c (Fsingle_key_description): Handle char ranges.
3008
95986d52
CY
30092012-02-12 Chong Yidong <cyd@gnu.org>
3010
afd83bd1
CY
3011 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3012 as that creates a dangerous corner case.
3013
95986d52
CY
3014 * window.c (Fdelete_window_internal): Invalidate the mouse
3015 highlight (Bug#9904).
3016
bd7da63e
GM
30172012-02-12 Glenn Morris <rgm@gnu.org>
3018
3019 * xselect.c (Fx_own_selection_internal)
3020 (Fx_get_selection_internal, Fx_disown_selection_internal)
3021 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3022 * nsselect.m (Fx_own_selection_internal)
3023 (Fx_disown_selection_internal, Fx_selection_exists_p)
3024 (Fx_selection_owner_p, Fx_get_selection_internal):
3025 Sync docs and argument specs with the xselect.c versions.
3026
77abcbc2
LI
30272012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3028
3029 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3030
90b671e2
EZ
30312012-02-11 Eli Zaretskii <eliz@gnu.org>
3032
1c0ca0b7
EZ
3033 * w32select.c (Fx_selection_exists_p): Sync doc string and
3034 argument list with xselect.c. (Bug#10783)
3035
3036 * w16select.c (Fx_selection_exists_p): Sync doc string and
3037 argument list with xselect.c. (Bug#10783)
90b671e2 3038
49241268
GM
30392012-02-10 Glenn Morris <rgm@gnu.org>
3040
3041 * fns.c (Fsecure_hash): Doc fix.
3042
f998bbe7 30432012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3044
3045 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3046
0992bd9c
CY
30472012-02-07 Chong Yidong <cyd@gnu.org>
3048
3049 * buffer.c (Fbuffer_local_variables)
3050 (buffer_lisp_local_variables): Handle unbound vars correctly;
3051 don't let Qunbound leak into Lisp.
3052
af008560
GM
30532012-02-07 Glenn Morris <rgm@gnu.org>
3054
dd605cc4
GM
3055 * image.c (Fimagemagick_types): Doc fix.
3056
af008560
GM
3057 * image.c (imagemagick-render-type): Change it from a lisp object
3058 to an integer. Move the doc here from the lisp manual.
3059 Treat all values not equal to 0 the same.
3060
1449fa1d
CY
30612012-02-06 Chong Yidong <cyd@gnu.org>
3062
3063 * doc.c (store_function_docstring): Avoid applying docstring of
3064 alias to base function (Bug#2603).
3065
3723ec07
AS
30662012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3067
3068 * .gdbinit (pp1, pv1): Remove redundant defines.
3069 (pr): Use pp.
3070
79c1cc1e
CY
30712012-02-04 Chong Yidong <cyd@gnu.org>
3072
3073 * nsterm.m: Declare a global (Bug#10694).
3074
d7f29f8e
EZ
30752012-02-04 Eli Zaretskii <eliz@gnu.org>
3076
cae07000
SM
3077 * w32.c (get_emacs_configuration_options):
3078 Include --enable-checking, if specified, in the return value.
d7f29f8e 3079
3b95a6f9
MR
30802012-02-04 Martin Rudalics <rudalics@gmx.at>
3081
3082 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3083 after rounding frame sizes. (Bug#9723)
3084
d6fa96a6
EZ
30852012-02-04 Eli Zaretskii <eliz@gnu.org>
3086
3087 * keyboard.c (adjust_point_for_property): Don't position point
3088 before BEGV. (Bug#10696)
3089
df0b2940
PE
30902012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 Handle overflow when computing char display width (Bug#9496).
3093 * character.c (char_width): Return EMACS_INT, not int.
3094 (char_width, c_string_width): Check for overflow when
3095 computing the width; this is possible now that individual
3096 characters can have unbounded width. Problem introduced
3097 by merge from Emacs 23 on 2012-01-19.
3098
6bee44d6
MA
30992012-02-02 Michael Albinus <michael.albinus@gmx.de>
3100
3101 * dbusbind.c (Fdbus_register_method): Mention the return value
3102 :ignore in the docstring.
3103
44f92739
GM
31042012-02-02 Glenn Morris <rgm@gnu.org>
3105
1b9f60cc
GM
3106 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3107
44f92739
GM
3108 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3109 Unconditionally set to t. (Bug#10673)
3110 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3111 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3112 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3113
c5d3843c
KH
31142012-02-02 Kenichi Handa <handa@m17n.org>
3115
3116 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3117 0, do not call append_composite_glyph.
3118
159462d4 31192012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3120
3121 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3122 NULL (Bug#6988).
3123 (x_produce_glyphs): If the component of a composition is a null
3124 string, set it->pixel_width to 1 to avoid zero-width glyph.
3125
78cef877
EZ
31262012-02-01 Eli Zaretskii <eliz@gnu.org>
3127
3128 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3129 first 2 arguments are identical. This makes inserting large
3130 output from a subprocess an order of magnitude faster on
3131 MS-Windows, where all sbrk'ed memory is always contiguous.
3132
97897668
GM
31332012-01-31 Glenn Morris <rgm@gnu.org>
3134
3135 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3136 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3137 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3138
31fd3586
GM
31392012-01-29 Glenn Morris <rgm@gnu.org>
3140
3141 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3142
0e24a8b2
CY
31432012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3144
3145 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3146
cc0adcb0
CY
31472012-01-28 Chong Yidong <cyd@gnu.org>
3148
3149 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3150
acc28cb9
CY
31512012-01-26 Chong Yidong <cyd@gnu.org>
3152
9c69cfb7
CY
3153 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3154
acc28cb9
CY
3155 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3156 repeat counts (Bug#10507).
3157
48da7392
GM
31582012-01-26 Glenn Morris <rgm@gnu.org>
3159
3160 * lread.c (syms_of_lread): Doc fix.
3161
14af5f7f
CY
31622012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3163
3164 * coding.c (encode_designation_at_bol): Change return value to
3165 EMACS_INT.
3166
0b21c100
CY
31672012-01-25 Chong Yidong <cyd@gnu.org>
3168
3169 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3170
3c2907f7
CY
31712012-01-21 Chong Yidong <cyd@gnu.org>
3172
3173 * floatfns.c (Fcopysign): Make the second argument non-optional,
3174 since nil is not allowed anyway.
3175
959ad23f
AS
31762012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3177
3178 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3179 (send_process): Likewise.
3180
34a02f46
MR
31812012-01-19 Martin Rudalics <rudalics@gmx.at>
3182
3183 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3184 (Vwindow_persistent_parameters): Do not use Qstate.
3185 Rewrite doc-strings.
34a02f46 3186
1259009a 31872012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3188
3189 * character.c (char_width): New function.
70d4fdf6
GM
3190 (Fchar_width, c_string_width, lisp_string_width):
3191 Use char_width (Bug#9496).
25ed9e61 3192
6a6ee00d
MR
31932012-01-16 Martin Rudalics <rudalics@gmx.at>
3194
3195 * window.c (Vwindow_persistent_parameters): New variable.
3196 (Fset_window_configuration, save_window_save): Handle persistent
3197 window parameters.
3198
c85efaf7
EZ
31992012-01-14 Eli Zaretskii <eliz@gnu.org>
3200
3201 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3202 thrashing the stack of the thread. (Bug#9087)
3203
5944709e
PE
32042012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3205
3206 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3207
e71f5d99
EZ
32082012-01-11 Eli Zaretskii <eliz@gnu.org>
3209
3210 * xdisp.c (rows_from_pos_range): Handle the case where the
3211 highlight ends on a newline. (Bug#10464)
3212 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3213 he end column for display of highlight that ends on a newline
3214 before a R2L line.
3215
ce316182
GM
32162012-01-11 Glenn Morris <rgm@gnu.org>
3217
3218 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3219 from load-path also when installation-directory is nil. (Bug#10208)
3220
5b43da69
GM
32212012-01-10 Glenn Morris <rgm@gnu.org>
3222
74cc8ff9
GM
3223 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3224
7d8d6e4e
GM
3225 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3226 Update template values to be closer to their typical values these days.
5b43da69 3227
a0db8d43
EZ
32282012-01-09 Eli Zaretskii <eliz@gnu.org>
3229
3230 * xdisp.c (rows_from_pos_range): Accept additional argument
3231 DISP_STRING, and accept any glyph in a row whose object is that
3232 string as eligible for mouse highlight. Fixes mouse highlight of
3233 display strings from overlays. (Bug#10464)
3234
9a0115ab 32352012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3236
b9110d6a 3237 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3238 * fileio.c (auto_saving_dir_umask): New static var.
3239 (Fmake_directory_internal): Use it.
3240 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3241 creating the directory. The old code temporarily assigns
3242 too-generous permissions to the directory.
3243 (do_auto_save_eh): Clear it.
b9110d6a 3244 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3245 that the var is always cleared.
3246
6c1bd3f3
EZ
32472012-01-07 Eli Zaretskii <eliz@gnu.org>
3248
3249 * search.c (scan_buffer): Pass character positions to
3250 know_region_cache, not byte positions. (Bug#6540)
3251
069d2b50
L
32522012-01-07 LynX <_LynX@bk.ru> (tiny change)
3253
3254 * w32.c (sys_rename): Report EXDEV when rename of a directory
3255 fails because the target is on another logical disk. (Bug#10284)
3256
75bf0d33
DB
32572012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3258
3259 * xterm.c (x_embed_request_focus): New function.
3260
3261 * xterm.h: Add prototype.
3262
3263 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3264
1c6e5a32
GM
32652012-01-05 Glenn Morris <rgm@gnu.org>
3266
3267 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3268
651e947e
EZ
32692012-01-01 Eli Zaretskii <eliz@gnu.org>
3270
3271 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3272 Load gnutls_transport_set_lowat only if GnuTLS version is below
3273 2.11.1.
3274 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3275 GnuTLS versions below 2.11.1.
3276
3778cdd8
AL
32772011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3278
3279 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3280 to the doc string advising against its use for altering the way
3281 windows are scrolled.
3282
0e5317f7
KH
32832011-12-28 Kenichi Handa <handa@m17n.org>
3284
3285 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3286 coding-system ASCII compatible only when it does not produce BOM
3287 on encoding (Bug#10383).
3288
93d5ca1f
JD
32892011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3290
3291 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3292 can scroll.
3293 (create_and_show_popup_menu): Always use menu_position_func for
3294 Gtk3 (Bug#10361).
3295
ca22b785
AS
32962011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3297
3298 * callint.c (Fcall_interactively): Don't truncate prompt string.
3299
d048e1e6
EZ
33002011-12-23 Eli Zaretskii <eliz@gnu.org>
3301
3302 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3303 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3304 resumed from there (after widening). (Bug#10360)
d048e1e6 3305
5ccaba1f
JD
33062011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3307
3308 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3309
204ee57f
JD
33102011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3311
b81d40f0
JB
3312 * nsterm.m (x_free_frame_resources):
3313 Release f->output_data.ns->miniimage.
204ee57f
JD
3314 (ns_index_color): Fix indentation. Do not retain
3315 color_table->colors[i].
3316
3317 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3318 before returning.
3319
3320 * nsfns.m (x_set_background_color): Assign return value from
3321 ns_index_color to face-background instead of NSColor*.
3322 (ns_implicitly_set_icon_type): Fix indentation.
3323 Change assignment in for loop to comparison.
3324
3325 * emacs.c (ns_pool): New variable.
3326 (main): Assign ns_pool.
3327 (Fkill_emacs): Call ns_release_autorelease_pool.
3328
3329 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3330 autorelease fdesc, release fdAttrs and tdict.
3331 (ns_get_covering_families): Release charset.
3332 (ns_findfonts): Release NSFontDescriptor created with new.
3333 (ns_uni_to_glyphs): Fix indentation.
3334 (setString): Release attrStr before assigning new value.
3335
c803b2b7
JD
33362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3337
678f4426
JD
3338 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3339 and NS_IMPL_COCOA.
3340 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3341 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3342
cd394be1 33432011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3344
5fecd5fc
JD
3345 * nsterm.m (ns_term_init): Subscribe for notifications
3346 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3347 to method trackingNotification in EmacsMenu.
3348
3349 * nsmenu.m (trackingMenu): New variable.
3771cb17 3350 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3351 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3352 from Aquamacs (Bug#7030).
678f4426
JD
3353
33542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3355
c803b2b7
JD
3356 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3357 (symbol_to_nsstring): Fix indentation.
3358 (ns_symbol_to_pb): New function.
cae07000
SM
3359 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3360 (Fns_rotate_cut_buffers_internal): Remove.
3361 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3362 Fns_store_cut_buffer_internal.
3363 (ns_get_foreign_selection, Fx_own_selection_internal)
3364 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3365 (Fns_get_selection_internal, Fns_store_selection_internal):
3366 Use ns_symbol_to_pb and check if return value is nil.
3367 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3368 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3369 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3370 renamed to Sns_store_selection_internal.
3371 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3372 and remove this function.
3373 (ns_handle_selection_clear): Remove, never used.
3374 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3375 here.
3376
e1b01a3a
KB
33772011-12-17 Ken Brown <kbrown@cornell.edu>
3378
3379 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3380 GID is unknown (Bug#10257).
3381
2adb6e85
PE
33822011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3385 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3386 which caused a build failure on GNU/Linux IA-64. This problem was
3387 introduced by my 2011-10-07 patch.
3388
d1d7b339
JL
33892011-12-15 Juri Linkov <juri@jurta.org>
3390
3391 * image.c (imagemagick_error): New function. (Bug#10112)
3392 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3393 Use `imagemagick_error' where ImageMagick functions return
3394 `MagickFalse'.
3395 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3396 proper order.
3397
100d5755
KH
33982011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3399
3400 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3401 fill background (Bug#8992).
3402
454592a6
MR
34032011-12-13 Martin Rudalics <rudalics@gmx.at>
3404
3405 * window.c (Vwindow_combination_resize)
3406 (Vwindow_combination_limit): Use t instead of non-nil in
3407 doc-strings.
61d4b438
MR
3408 (Vrecenter_redisplay): Add first sentence of doc-string on
3409 separate line.
53524d93 3410 (Frecenter): Fix doc-string typo.
454592a6 3411
3633e3aa
KH
34122011-12-11 Kenichi Handa <handa@m17n.org>
3413
3414 * coding.c (Funencodable_char_position): Pay attention to the
3415 buffer text relocation (Bug#9389).
3416
7b9d523a 34172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3418
7b9d523a
JD
3419 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3420 gtk_init (Bug#10100).
3421
b73189c6
EZ
34222011-12-10 Eli Zaretskii <eliz@gnu.org>
3423
3424 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3425 IT->string is nil. (Bug#10263)
3426
f7dfe5d6
JD
34272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3428
83faebb4
JD
3429 * nsterm.h (x_free_frame_resources): Declare.
3430
f7dfe5d6
JD
3431 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3432 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3433
3434 * nsterm.h (ns_get_defaults_value): Declare.
3435
3436 * nsterm.m (ns_default): Call ns_get_defaults_value.
3437
7cd4e72c
EZ
34382011-12-09 Eli Zaretskii <eliz@gnu.org>
3439
3440 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3441 (Bug#10170)
3442
b34d7317
YM
34432011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3444
3445 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3446 that where the value of an _OBJC_* symbol points to is in the .bss
3447 section (Bug#10240).
3448
76470ad1
KH
34492011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3450
3451 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3452 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3453
745fff94
KH
34542011-12-08 Kenichi Handa <handa@m17n.org>
3455
3456 * ftfont.c (get_adstyle_property): Fix previous change
3457 (Bug#10233).
3458
6e44397c
JB
34592011-12-07 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3462 dirs from the default value of EMACSLOADPATH (bug#10208).
3463
7efa6272
GM
34642011-12-07 Glenn Morris <rgm@gnu.org>
3465
3466 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3467 installation and source directories as well. (Bug#10208)
3468
f6fc4d87
CY
34692011-12-06 Chong Yidong <cyd@gnu.org>
3470
3471 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3472
2bf26180
GM
34732011-12-06 Glenn Morris <rgm@gnu.org>
3474
3475 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3476 as an error, not just -1. (Bug#10217)
3477
3a6ad4f0
CY
34782011-12-05 Chong Yidong <cyd@gnu.org>
3479
3480 * keyboard.c (process_special_events): New function.
3481 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3482
75a3b399
PE
34832011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3484
3485 * coding.c (encode_designation_at_bol): Don't use uninitialized
3486 local variable (Bug#9318).
3487
c3c9e25e
KH
34882011-12-05 Kenichi Handa <handa@m17n.org>
3489
3490 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3491 return Qnil (Bug#8046, Bug#10193).
3492
5eb05ea3
KH
34932011-12-05 Kenichi Handa <handa@m17n.org>
3494
3495 * coding.c (encode_designation_at_bol): New args charbuf_end and
3496 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3497 (coding_set_source): Return how many bytes coding->source was
3498 relocated.
3499 (coding_set_destination): Return how many bytes
3500 coding->destination was relocated.
3501 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3502 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3503
35042011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3505
3506 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3507 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3508 macro (Bug#9318).
3509
35102011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3511
3512 The following changes are to fix Bug#9318.
3513
a79703f5 3514 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3515 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3516 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3517 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3518
7dbda6df
JB
35192011-12-05 Juanma Barranquero <lekktu@gmail.com>
3520
3521 * lisp.h (process_quit_flag): Fix external declaration.
3522
6d5eb5b0
SM
35232011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3524
3525 Don't macro-inline non-performance-critical code.
3526 * eval.c (process_quit_flag): New function.
3527 * lisp.h (QUIT): Use it.
3528
a0c3fad0
JD
35292011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3530
3531 * nsfns.m (get_geometry_from_preferences): New function.
3532 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3533
6c07aac2
AS
35342011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3535
3536 * emacs.c (Qkill_emacs): Define.
3537 (syms_of_emacs): Initialize it.
3538 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3539 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3540 (quit_throw_to_read_char): Add parameter `from_signal'.
3541 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3542 * lisp.h (QUIT): Call Fkill_emacs if requested.
3543
c052ead4
JD
35442011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3545
3546 * widget.c (update_wm_hints): Return if wmshell is null.
3547 (widget_update_wm_size_hints): New function.
3548
3549 * widget.h (widget_update_wm_size_hints): Declare.
3550
3551 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3552 widget_update_wm_size_hints (Bug#10104).
3553
9e49252b
EZ
35542011-12-03 Eli Zaretskii <eliz@gnu.org>
3555
3556 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3557 before a newline, prepare the bidi iterator for consuming the
3558 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3559 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3560
02b16839
JL
35612011-12-02 Juri Linkov <juri@jurta.org>
3562
3563 * search.c (Fword_search_regexp): New Lisp function created from
3564 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3565 (Fword_search_backward, Fword_search_forward)
3566 (Fword_search_backward_lax, Fword_search_forward_lax):
3567 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3568 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3569
0068070e
SM
35702011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3571
3572 * fileio.c (Finsert_file_contents): Move after-change-function call
3573 to before the "handled:" label, since all "goto handled" appear in
3574 cases where the *-change-functions have already been properly called
3575 (bug#10117).
3576
3360a3fc
AS
35772011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3578
3579 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3580 waiting for input. (Bug#10169)
3581
73d6c093
EZ
35822011-11-30 Eli Zaretskii <eliz@gnu.org>
3583
3584 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3585 verifies glyph row's hash code--we have just reallocated the
3586 glyphs, so their contents can be complete garbage. (Bug#10164)
3587
febe6bea
JB
35882011-11-30 Juanma Barranquero <lekktu@gmail.com>
3589
3590 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3591
801a4313
EZ
35922011-11-30 Eli Zaretskii <eliz@gnu.org>
3593
3594 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3595 attributes are tested _before_ calling verify_row_hash, to protect
3596 against GCC re-ordering of the tests. (Bug#10164)
3597
2b56b87e
JD
35982011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3599
3600 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3601
3602 * xterm.c (handle_one_xevent): Only set async_visible and friends
3603 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3604 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3605 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3606
dbf31225
PE
36072011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3608
3609 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3610 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3611 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3612 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3613 All uses changed to use GCPRO1 etc.
3614 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3615 Revert to old implementation (i.e., before 2011-03-11).
3616
1305621b
YM
36172011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3618
3619 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3620 of scroll runs so as to avoid assigning disabled bogus rows and
3621 unnecessary graphics copy operations.
3622
8c9afb46
EZ
36232011-11-27 Eli Zaretskii <eliz@gnu.org>
3624
3625 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3626 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3627 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3628 (malloc, free, realloc, calloc): Redirect to e_* only when
3629 compiling Emacs.
3630
3631 * lisp.h (GCTYPEBITS): Move before first use.
3632 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3633 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3634 this macro definition.
3635
3636 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3637 _MSC_VER.
3638
54e9e3bf
JD
36392011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3640
6d5eb5b0
SM
3641 * gtkutil.c (xg_create_frame_widgets):
3642 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3643 present with Gtk+ 2.0.
3644
83aca1cb
PE
36452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3646
3647 * fileio.c (Finsert_file_contents): Undo previous change; see
3648 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3649
5b76caa4
PE
36502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3651
3652 Rename locals to avoid shadowing.
3653 * fileio.c (Finsert_file_contents):
3654 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3655 * process.c (wait_reading_process_output):
3656 Rename inner 'proc' to 'p' to avoid shadowing.
3657 Indent for consistency with usual Emacs style.
3658
8c535114
EZ
36592011-11-25 Eli Zaretskii <eliz@gnu.org>
3660
3661 * xdisp.c (redisplay_window): If cursor row is not fully visible
3662 after recentering, and scroll-conservatively is set to a large
3663 number, scroll window by a few more lines to make the cursor fully
3664 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3665 (start_display): Don't move to the next line if the display should
3666 start at a newline that is part of a display vector or an overlay
3667 string. (Bug#10119)
8c535114 3668
fa4fdb5c
JL
36692011-11-24 Juri Linkov <juri@jurta.org>
3670
3671 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3672 after the `MagickPingImage' call. (Bug#10112)
3673
90ec88df
CY
36742011-11-23 Chong Yidong <cyd@gnu.org>
3675
3676 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3677
56e2e794
MR
36782011-11-23 Martin Rudalics <rudalics@gmx.at>
3679
3680 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3681 making another buffer current. (Bug#10114)
3682
b6e64c41
GM
36832011-11-23 Glenn Morris <rgm@gnu.org>
3684
3685 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3686
6b21de18
CY
36872011-11-23 Chong Yidong <cyd@gnu.org>
3688
3689 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3690 using it (Bug#5984).
3691
b12cd789
EZ
36922011-11-22 Eli Zaretskii <eliz@gnu.org>
3693
3694 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3695 and header-lines, as they don't have one computed for them.
3696 (Bug#10098)
3697
3698 * .gdbinit (prow): Make displayed values more self-explaining.
3699 Add row's hash code.
3700
261b6fd4
LMI
37012011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3702
3703 * process.c (wait_reading_process_output): Fix asynchrounous
3704 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3705 (wait_reading_process_output): Add comment and URL.
261b6fd4 3706
e7cfd277
JD
37072011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3708
3709 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3710
a9b9b7f5
CY
37112011-11-21 Chong Yidong <cyd@gnu.org>
3712
3713 * window.c (Fnext_window, Fprevious_window): Doc fix.
3714
b0d15b4f
SM
37152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3716
3717 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3718
fe7a3057
JB
37192011-11-20 Juanma Barranquero <lekktu@gmail.com>
3720
3721 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3722
d2999b1a
MR
37232011-11-20 Martin Rudalics <rudalics@gmx.at>
3724
3725 * window.c (Fset_window_combination_limit): Rename argument
3726 STATUS to LIMIT.
3727 (Vwindow_combination_limit): Remove "status" from doc-string.
3728
d5ff9cd0
AS
37292011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3730
3731 * m/ibms390.h: Remove.
3732 * m/ibms390x.h: Don't include "ibms390.h".
3733
a5bb9bd3
SM
37342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3735
3736 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3737 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3738
cd1181db
JB
37392011-11-20 Juanma Barranquero <lekktu@gmail.com>
3740
3741 * casetab.c (Fset_case_table):
3742 * charset.c (Fcharset_after): Fix typos.
3743
615a3b8d 37442011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3745
17e845af
PE
3746 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3747 Otherwise, valgrind does not work on some platforms.
3748 Problem reported by Andreas Schwab in
6a0bf43d
PE
3749 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3750 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3751 is set, removing the need for VIRT_ADDRESS_VARIES.
3752 (PURE_P): Use a more-efficient implementation that needs just one
3753 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3754 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3755 to 4 (xorl, subq, cmpq, setbe).
3756 * alloc.c (pure): Always extern now, since that's the
3757 VIRT_ADDR_VARIES behavior.
3758 (PURE_POINTER_P): Use a single comparison, not two, for
3759 consistency with the new puresize.h.
3760 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3761 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3762 Remove VIRT_ADDR_VARIES no longer needed.
3763
f8fe6f96
EZ
37642011-11-19 Eli Zaretskii <eliz@gnu.org>
3765
3766 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3767 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3768 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3769 behave as if the cursor position were at the window margin.
3770
3771 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3772 and the cursor position is out of bounds, behave as if the cursor
3773 position were at the window margin. (Bug#10075)
3774
df05a53c
CY
37752011-11-18 Chong Yidong <cyd@gnu.org>
3776
3777 * window.c (Fwindow_combination_limit): Make first argument
3778 non-optional, since it is meaningless for live windows like the
3779 selected window.
61ccba97 3780
2071918e
DA
37812011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3782
3783 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3784
b50a28de
SM
37852011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3786
3787 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3788 (graft_intervals_into_buffer): Simplify.
3789
015137db
EZ
37902011-11-18 Eli Zaretskii <eliz@gnu.org>
3791
3792 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3793 hash values of the two rows.
3794 (copy_row_except_pointers): Preserve the used[] arrays and the
3795 hash values of the two rows. (Bug#10035)
68c95424 3796 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3797
3798 * xdisp.c (row_hash): New function, body extracted from
3799 compute_line_metrics.
3800 (compute_line_metrics): Call row_hash, instead of computing the
3801 hash code inline.
3802
3803 * dispnew.c (verify_row_hash): Call row_hash for computing the
3804 hash code of a row, instead of duplicating code from xdisp.c.
3805
3806 * dispextern.h (row_hash): Add prototype.
3807
a2addb04
TH
38082011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3809
3810 * frame.c (delete_frame): Don't delete the terminal when the last
3811 X frame is closed if emacs is built with GTK toolkit.
3812
df85d315
JB
38132011-11-17 Juanma Barranquero <lekktu@gmail.com>
3814
3815 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3816
a0c2d0ae
MR
38172011-11-17 Martin Rudalics <rudalics@gmx.at>
3818
3819 * window.c (Vwindow_splits): Rename to
3820 Vwindow_combination_resize. Suggested by Juri Linkov.
3821 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3822 of Vwindow_splits.
3823
58179cce
JB
38242011-11-16 Juanma Barranquero <lekktu@gmail.com>
3825
7877f373
JB
3826 * nsfns.m (Fns_font_name):
3827 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3828
b6f67890
MR
38292011-11-16 Martin Rudalics <rudalics@gmx.at>
3830
3831 * window.h (window): Rename slot "nest" to "combination_limit".
3832 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3833 (Fset_window_nest): Rename to Fset_window_combination_limit.
3834 (Vwindow_nest): Rename to Vwindow_combination_limit.
3835 (recombine_windows, make_parent_window, make_window)
3836 (Fsplit_window_internal, saved_window)
3837 (Fset_window_configuration, save_window_save): Rename all
3838 occurrences of window_nest to window_combination_limit.
3839
c7015153
JB
38402011-11-15 Juanma Barranquero <lekktu@gmail.com>
3841
3842 * image.c (imagemagick_load_image): Fix typo.
3843
322ad6ec
EZ
38442011-11-14 Eli Zaretskii <eliz@gnu.org>
3845
3846 * xdisp.c (display_line): Move the call to
3847 highlight_trailing_whitespace before the call to
3848 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3849 faces of all the glyphs to compute ROW's hash value.
3850 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3851
f067b8ec
JB
38522011-11-14 Juanma Barranquero <lekktu@gmail.com>
3853
3854 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3855 just return (bug#10044).
3856
1e5b2111
EZ
38572011-11-12 Eli Zaretskii <eliz@gnu.org>
3858
7ef3cbd5
EZ
3859 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3860 with user-defined heap size. Bump the default size of the temacs
3861 heap to 27MB, to avoid memory warning when running temacs.
3862 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3863
1e5b2111
EZ
3864 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3865 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3866 (verify_row_hash) [XASSERTS]: New function.
3867 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3868 that the hash value of glyph rows is correct.
1e5b2111 3869
89d61221
MR
38702011-11-12 Martin Rudalics <rudalics@gmx.at>
3871
3872 * window.h (window): Remove splits slot.
3873 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3874 (Fdelete_other_windows_internal, make_parent_window)
3875 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3876 (Fset_window_configuration, save_window_save): Don't deal with
3877 split status of windows.
3878 (saved_window): Remove splits slot.
3879 (Vwindow_splits): Rewrite doc-string.
3880
97f18cc8
JD
38812011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3882
3883 * xfns.c (unwind_create_frame):
3884 * nsfns.m (unwind_create_frame):
3885 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3886 Vframe_list (Bug#9999).
3887
22a648b4
DA
38882011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3889
0b381c7e 3890 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3891
659afede
KH
38922011-11-11 Kenichi Handa <handa@m17n.org>
3893
3894 * callproc.c (Fcall_process): Set the member dst_multibyte of
3895 process_coding.
3896
9ac0394b
KH
38972011-11-11 Johan Bockgård <bojohan@gnu.org>
3898
3899 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3900 avoid a crash (bug#9496).
3901
2fbdc249
CY
39022011-11-09 Chong Yidong <cyd@gnu.org>
3903
3904 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3905 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3906
ac6b1f81
PE
39072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3910
09db192c
PE
39112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 Avoid some portability problems by eschewing 'extern inline' functions.
3914 The trivial performance wins aren't worth the portability hassles; see
3915 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3916 et seq.
3917 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3918 (window_box_width, window_box_left, window_box_left_offset)
3919 (window_box_right, window_box_right_offset): Undo previous change,
3920 by removing the "extern"s.
3921 * intervals.c (adjust_intervals_for_insertion)
3922 (adjust_intervals_for_deletion): Undo previous change,
3923 making these static again.
3924 (offset_intervals, temp_set_point_both, temp_set_point)
3925 (copy_intervals_to_string): No longer inline.
3926 * xdisp.c (window_text_bottom_y, window_box_width)
3927 (window_box_height, window_box_left_offset)
3928 (window_box_right_offset, window_box_left, window_box_right)
3929 (window_box): No longer inline.
3930
105216ed
CY
39312011-11-08 Chong Yidong <cyd@gnu.org>
3932
3933 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3934 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3935 Signal an error if not a live window.
105216ed
CY
3936 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3937 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3938
ae9e237f
JB
39392011-11-07 Juanma Barranquero <lekktu@gmail.com>
3940
3941 * lisp.h (syms_of_abbrev): Remove declaration.
3942 Reported by CHENG Gao <chenggao@royau.me>.
3943
c7aa8333
EZ
39442011-11-07 Eli Zaretskii <eliz@gnu.org>
3945
3946 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3947 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3948 of temacs in GUI mode.
3949
be7f5545
MR
39502011-11-07 Martin Rudalics <rudalics@gmx.at>
3951
3952 * window.h: Declare delete_all_child_windows instead of
3953 delete_all_subwindows.
3954 * window.c (Fwindow_nest, Fset_window_nest)
3955 (Fset_window_new_total, Fset_window_new_normal)
3956 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3957 (delete_all_subwindows): Rename to delete_all_child_windows.
3958 (Fdelete_other_windows_internal, Fset_window_configuration):
3959 Call delete_all_child_windows instead of delete_all_subwindows.
3960 * frame.c (delete_frame): Call delete_all_child_windows instead
3961 of delete_all_subwindows.
3962
ca78dc43
PE
39632011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3964
3965 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3966 This is also needed for porting to any host where GC_MARK_STACK is
3967 not GC_MAKE_GCPROS_NOOPS.
3968 (which_symbols): Use it.
3969
a0241d01
KH
39702011-11-07 Kenichi Handa <handa@m17n.org>
3971
3972 * coding.c (coding_set_destination): Check coding->src_pos only
3973 when coding->src_object is a buffer (bug#9910).
3974
3975 * process.c (send_process): Set the member src_multibyte of coding
3976 to 0 (bug#9911) when sending a unibyte text.
3977
3978 * callproc.c (Fcall_process): Set the member src_multibyte of
3979 process_coding to 0 (bug#9912).
3980
a64bfdfa 39812011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3982
3983 * xmenu.c (cleanup_widget_value_tree): New function.
3984 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3985 calling free_menubar_widget_value_tree directly (Bug#9830).
3986
cb41b32a
PE
39872011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 Fix some portability problems with 'inline'.
3990 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3991 (window_box_width, window_box_left, window_box_left_offset)
3992 (window_box_right, window_box_right_offset): Declare extern.
3993 Otherwise, these inline functions do not conform to C99 and
3994 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3995 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3996 * intervals.c (adjust_intervals_for_insertion)
3997 (adjust_intervals_for_deletion): Now extern, because otherwise the
3998 extern inline functions 'offset_intervals' couldn't refer to it.
3999 (static_offset_intervals): Remove.
4000 (offset_intervals): Rewrite using the old contents of
4001 static_offset_intervals. The old version didn't conform to C99
4002 because an extern inline function contained a reference to an
4003 identifier with static linkage.
4004
b7041366
AS
40052011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4006
4007 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4008 GC.
4009
88a37c4d
EZ
40102011-11-06 Eli Zaretskii <eliz@gnu.org>
4011
4012 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4013 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4014 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4015 return Qleft_to_right.
4016
49745b39
CY
40172011-11-06 Chong Yidong <cyd@gnu.org>
4018
4019 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4020 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4021 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4022 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4023 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4024 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4025 (Fwindow_vscroll): Doc fix.
4026 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4027 argument, since it makes no sense to pass a live window and for
4028 consistency with window-child.
4029
1f05cd82
CS
40302011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4031
4032 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4033 support MSVC.
4034
22610910
JR
40352011-11-05 Jason Rumney <jasonr@gnu.org>
4036
4037 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4038 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4039 fonts (Bug#6029).
4040 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4041 bitwise arithmetic preventing use of unicode-sip and non-truetype
4042 opentype fonts.
4043
a06776b2
EZ
40442011-11-05 Eli Zaretskii <eliz@gnu.org>
4045
3ad924ba
EZ
4046 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4047 "emacs"-only part.
4048
a06776b2
EZ
4049 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4050 initialization code to keep similarity to xfns.c after changes
4051 from 2011-11-05.
4052
c9e7db78
JD
40532011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4054
a97f8f3f
JD
4055 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4056 (unwind_create_frame): New function (Bug#9943).
4057 (Fx_create_frame): Restructure code to be more similar to the one in
4058 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4059 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4060 Move terminal->reference_count++ just before making the frame official
4061 (Bug#9943).
4062
4063 * nsterm.m (x_free_frame_resources): New function.
4064 (x_destroy_window): Move code to x_free_frame_resources.
4065
c9e7db78 4066 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4067 (Fx_create_frame, x_create_tip_frame):
4068 Move terminal->reference_count++ just before making the frame
75f1671a 4069 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4070 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4071
a6fc3b5c
EZ
40722011-11-05 Eli Zaretskii <eliz@gnu.org>
4073
4074 Support MSVC build with newer versions of Visual Studio.
4075 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4076 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4077 nt/gmake.defs.
4078
4079 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4080 which are not supported by MSVC.
4081 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4082 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4083 bitfields.
4084 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4085 types in bitfields.
4086 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4087
4088 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4089
58179cce 40902011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4091
4092 Support MSVC build with newer versions of Visual Studio.
4093 * w32.c: Don't include w32api.h for MSVC.
4094 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4095
4096 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4097 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4098 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4099 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4100 e_* cousins.
4101 (alloca) [_MSC_VER]: Define to _alloca.
4102
4103 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4104
4105 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4106
a58c13ed
EZ
41072011-11-04 Eli Zaretskii <eliz@gnu.org>
4108
4109 * xdisp.c (note_mouse_highlight): If either of
4110 previous/next-single-property-change returns nil, treat that as
4111 the beginning or the end of the buffer. (Bug#9955)
4112
fe0b6370
JD
41132011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4114
a58c13ed 4115 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4116 label is not null (Bug#9951).
4117 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4118 may be NULL.
4119
89bd5ee1
EZ
41202011-11-04 Eli Zaretskii <eliz@gnu.org>
4121
4122 * window.c (Fwindow_body_size): Mention in the doc string that the
4123 return value is in frame's canonical units. (Bug#9949)
4124
84c3edb9
EZ
41252011-11-03 Eli Zaretskii <eliz@gnu.org>
4126
4e2fb5c7
EZ
4127 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4128
84c3edb9 4129 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4130 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4131 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4132
bc17a887
EZ
41332011-11-01 Eli Zaretskii <eliz@gnu.org>
4134
4135 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4136 Don't stop backward scan on the continuation glyph, even though
4137 its CHARPOS is positive.
6d5eb5b0
SM
4138 (mouse_face_from_buffer_pos, note_mouse_highlight):
4139 Rename cover_string to disp_string.
bc17a887 4140
4ee88440
MR
41412011-11-01 Martin Rudalics <rudalics@gmx.at>
4142
4143 * window.c (temp_output_buffer_show): Don't use
4144 Vtemp_buffer_show_specifiers.
4145 (Vtemp_buffer_show_specifiers): Remove unused variable.
4146
c2ff3c02
EZ
41472011-10-30 Eli Zaretskii <eliz@gnu.org>
4148
4149 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4150 past the beginning of the current glyph matrix.
4151
58179cce 41522011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4153
4154 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4155 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4156 HAVE_GTK3 (Bug#9869).
b77a6a7f 4157
3b574623
JD
4158 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4159 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4160
b77a6a7f
JD
4161 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4162
4163 * xterm.c: Declare x_handle_net_wm_state to return int.
4164 (handle_one_xevent): Check if we are iconified but don't have
4165 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4166 (get_current_wm_state): Return non-zero if not hidden,
4167 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4168 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4169 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4170 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4171
196e41e4
PE
41722011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4173
4174 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4175 so that this new function doesn't get optimized away by a
4176 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4177
021f2e1a
AS
41782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4179
4180 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4181
8b058d44
EZ
41822011-10-29 Eli Zaretskii <eliz@gnu.org>
4183
4184 Fix the `xbytecode' command.
4185 * .gdbinit (xprintbytestr): New command.
b50a28de 4186 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4187 (xbytecode): Print the byte-code string as well.
4188
4452fb80
EZ
41892011-10-29 Kim Storm <storm@cua.dk>
4190
8b058d44
EZ
4191 * alloc.c (which_symbols): New function.
4192
21b72067
AS
41932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4194
4195 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4196 line. (Bug#9903)
4197
83ed7b5c
GM
41982011-10-29 Glenn Morris <rgm@gnu.org>
4199
4200 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4201 Not clear what it was for, and it causes various bugs. (Bug#9839)
4202
5a7a728b
EZ
42032011-10-28 Eli Zaretskii <eliz@gnu.org>
4204
4205 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4206 possible random value that matches one of those tested as
4207 condition to clear the mouse face.
4208
d3d0842f
CY
42092011-10-28 Chong Yidong <cyd@gnu.org>
4210
4211 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4212
31b39d13
DN
42132011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4214
4215 * window.c (make_window): Initialize phys_cursor_on_p.
4216
9aba6043
SM
42172011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4218
4219 * lisp.h (struct Lisp_Symbol): Update comments.
4220
c20992f4
JB
42212011-10-28 Juanma Barranquero <lekktu@gmail.com>
4222
4223 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4224
db4f02f2
EZ
42252011-10-28 Eli Zaretskii <eliz@gnu.org>
4226
4227 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4228 <oslsachem@gmail.com> for helping to debug this.
4229
4230 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4231 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4232 (g_b_init_get_glyph_outline_w): New static variables.
4233 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4234 (GetGlyphOutlineW_Proc): New typedefs.
4235 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4236 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4237 New functions.
4238 (w32font_open_internal, compute_metrics):
4239 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4240 instead of calling the "wide" APIs directly.
4241
4242 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4243
4244 * w32.h (syms_of_w32font): Add prototype.
4245
87e68db4
JB
42462011-10-27 Juanma Barranquero <lekktu@gmail.com>
4247
4248 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4249 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4250 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4251 (Fmove_to_window_line): Doc fix.
4252
435c1d67
CY
42532011-10-27 Chong Yidong <cyd@gnu.org>
4254
4255 * process.c (make_process): Set gnutls_state to NULL.
4256
4257 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4258 non-NULL, regardless of GNUTLS_INITSTAGE.
4259 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4260 an error. Set process slots as soon as we allocate them.
4261
4262 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4263
9c6c6f49
CY
42642011-10-27 Chong Yidong <cyd@gnu.org>
4265
9aba6043
SM
4266 * gnutls.c (emacs_gnutls_deinit): New function.
4267 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4268 (Fgnutls_deinit, Fgnutls_boot): Use it.
4269
4270 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4271 (deactivate_process): Call emacs_gnutls_deinit.
4272
657d08d3
JB
42732011-10-27 Juanma Barranquero <lekktu@gmail.com>
4274
4275 * image.c (x_create_x_image_and_pixmap):
4276 * w32.c (sys_rename, w32_delayed_load):
4277 * w32font.c (fill_in_logfont):
4278 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4279
5430d399
JB
42802011-10-26 Juanma Barranquero <lekktu@gmail.com>
4281
4282 * w32fns.c (w32_default_color_map): New function,
4283 extracted from Fw32_default_color_map.
a7ef684b 4284 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4285
fe0055fa
PE
42862011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4287
4288 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4289
e6346438
SM
42902011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4291
4292 * keyboard.c (test_undefined): New function (bug#9751).
4293 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4294
e112cc37
ET
42952011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4296
4297 * sysdep.c (init_sys_modes): Fix the check for the controlling
4298 terminal (Bug#6649).
4299
7b5d6677
EZ
43002011-10-20 Eli Zaretskii <eliz@gnu.org>
4301
4302 * dispextern.h (struct bidi_it): New member next_en_type.
4303
4304 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4305 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4306 current character, check also for next_en_type being WEAK_EN.
4307 (bidi_resolve_weak): Don't enter the expensive loop if the current
4308 position is before next_en_pos. Record the bidi type of the first
4309 non-ET, non-BN character we find, in addition to its position.
4310 (bidi_level_of_next_char): Invalidate next_en_type when
4311 next_en_pos is over-stepped.
4312
7da0b018
PE
43132011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4314
4315 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4316 * editfns.c: Rewrite current-time-zone so that it invokes
4317 the equivalent of (format-time-string "%Z") to get the time zone name.
4318 This fixes a bug when the time zone name contains characters that
4319 need converting from the system time locale to Emacs internal format.
4320 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4321 that patch fixed format-time-string to do the conversion, but
4322 I forgot to fix current-time-zone.
4323 (format_time_string): New function, containing most of
4324 what Fformat_time_string used to contain.
4325 (Fformat_time_string): Rewrite in terms of format_time_string.
4326 This doesn't change this function's behavior.
4327 (current-time-zone): Rewrite to use format_time_string.
4328 This fixes the bug reported by Michael Schierl in
4329 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4330 Jason Rumney's 2007-06-07 change worked around this bug, but
4331 didn't fix it.
4332 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4333
8547b010
EZ
43342011-10-19 Eli Zaretskii <eliz@gnu.org>
4335
4336 * xdisp.c (start_display): If the character at POS is displayed
4337 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4338 (try_window_reusing_current_matrix): If a line ends in a display
4339 vector or the next line starts in a display vector, continue
4340 redrawing the window even though the character position of
4341 start_row was reached.
8547b010
EZ
4342 (Bug#9771, part 2)
4343
4e948d15
CY
43442011-10-18 Chong Yidong <cyd@gnu.org>
4345
4346 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4347 with nobreak-char-display too.
4348
4787455f
EZ
43492011-10-18 Eli Zaretskii <eliz@gnu.org>
4350
4351 Fix part 3 of bug#9771.
4352 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4353 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4354 non-neutral characters if the current character is a paragraph
4355 separator (a.k.a. Newline). This avoids running the same
4356 expensive loop twice, once when we consume the preceding newline
4357 and the other time when the line actually needs to be displayed.
4358 Avoid the loop when we see neutrals on the base embedding level
4359 following a character whose directionality is the same as the
4360 paragraph's. This avoids running the expensive loop when a line
4361 ends in a long sequence of neutrals, like control characters.
4362 Add assertion against STRONG_AL type. Slightly rearrange code
4363 that determines the type of a neutral given the first non-neutral
4364 that follows it.
4365 (bidi_level_of_next_char): Set next_en_pos to zero when
4366 invalidating its info.
4367
2c91f553
EZ
43682011-10-17 Eli Zaretskii <eliz@gnu.org>
4369
4370 * xdisp.c (push_display_prop): Determine whether to record string
4371 or buffer position by IT->string, not by IT->method. Allow
4372 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4373 (move_it_vertically_backward): Don't look for character position
4374 immediately after the newline when in a continuation line.
4375 (Bug#9771, part 1)
2c91f553 4376
c7b08b0d
MR
43772011-10-15 Martin Rudalics <rudalics@gmx.at>
4378
4379 * window.c (coordinates_in_window): Rewrite and delabelize
4380 vertical border check. (Bug#5357) (Bug#9618)
4381
6b02f655
SM
43822011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4383
4384 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4385 errors in XSetWindowBorder (bug#9310).
4386
81d40c92
DA
43872011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4388
4389 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4390 avoid crash when xmalloc overrun checking is enabled.
4391
d4172c3b
EZ
43922011-10-13 Eli Zaretskii <eliz@gnu.org>
4393
4394 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4395 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4396 cursor motion with <left> and <right> arrow keys.
4397
4398 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4399 some callers set that themselves.
4400
b00eea75
EZ
44012011-10-12 Eli Zaretskii <eliz@gnu.org>
4402
4403 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4404 display string and the previous row comes from the same string and
4405 is empty. (Bug#9739) (Bug#9738)
4406
8fe012c4
SM
44072011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4408
4409 * doc.c (get_doc_string): Encode file name (bug#9735).
4410
0074aef2
EZ
44112011-10-12 Eli Zaretskii <eliz@gnu.org>
4412
79beb178
EZ
4413 * bidi.c (bidi_level_of_next_char):
4414 * xdisp.c (get_visually_first_element): Remove old incorrect
4415 comments regarding the Unicode Line Separator character.
4416
0074aef2
EZ
4417 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4418
6e4b3fbe
DA
44192011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4420
4421 * alloc.c (Fgc_status): Do not access beyond zombies array
4422 boundary if nzombies > MAX_ZOMBIES.
4423 * alloc.c (dump_zombies): Add missing format specifier.
4424
0324f3af
PE
44252011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4426
b5525cac
PE
4427 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4428 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4429
0324f3af
PE
4430 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4431 Some packages use them to denote characters with modifiers.
4432
e9b5f888
AS
44332011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4434
4435 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4436 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4437 matching a pp-number. Rename parameter var to var1.
4438
127827c0
SM
44392011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4440
4441 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4442
c8fd3bd0
GM
44432011-10-08 Glenn Morris <rgm@gnu.org>
4444
4445 * callint.c (Fcall_interactively): Give a more explicit error for the
4446 'c' case with a non-character input. (Bug#8479)
4447
352ec8ff
EZ
44482011-10-08 Eli Zaretskii <eliz@gnu.org>
4449
03669ccb
EZ
4450 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4451 lines.
7061c986
EZ
4452 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4453 lines that are hscrolled on the left.
03669ccb 4454
352ec8ff
EZ
4455 * dispnew.c (buffer_posn_from_coords): Account for a possible
4456 presence of header-line. (Bug#4426)
4457
a66cfb1c
SM
44582011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4459
6b02f655
SM
4460 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4461 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4462
7c5ee88e
PE
44632011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4466 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4467 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4468 this makes Emacs dump core during garbage collection on rare
4469 occasions. sizeof is obviously inferior to offsetof here, so
4470 stick with offsetof.
4471 (GC_POINTER_ALIGNMENT): New macro.
4472 (mark_memory): Omit 3rd (offset) arg; caller changed.
4473 Don't assume EMACS_INT alignment is the same as pointer alignment.
4474
df1bbe5b
SM
44752011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4476
4477 * keyboard.c (read_key_sequence_remapped): New var.
4478 (read_key_sequence): Compute remapping in the right buffer.
4479 (command_loop_1): Use read_key_sequence's remapping directly.
4480
51553db6
SM
44812011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4482
32c1fffd
SM
4483 * dired.c (file_name_completion): Don't expand file name.
4484 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4485 before checking file name handler.
4486
51553db6
SM
4487 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4488 they've been requested explicitly (bug#9591).
4489
b6bd1599 44902011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4491
4492 * keymap.c (Fsingle_key_description): Use make_specified_string
4493 instead of build_string to build string from push_key_description.
4494 (Bug#5193)
4495
f701dc2a
PE
44962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4497
4222c55d
PE
4498 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4499 This fixes a Y2038 bug on 64-bit hosts.
4500 * buffer.c (reset_buffer):
4501 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4502 (Fclear_buffer_auto_save_failure):
4503 Use 0, not -1, to represent an unset failure time, since time_t
4504 might not be signed.
4505
f701dc2a
PE
4506 Remove dependency on glibc malloc internals.
4507 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4508 Move back here from lisp.h, but with their new implementations.
4509 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4510 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4511 * charset.c (charset_table_init): New static var.
4512 (syms_of_charset): Use it instead of xmalloc. This removes a
4513 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4514 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4515 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4516 Move back to alloc.c.
4517 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4518 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4519
9ceebf39
JD
45202011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4521
4522 * nsterm.m (windowDidResize): Call x_set_window_size only when
4523 ns_in_resize is true. Otherwise set pixelwidth/height and
4524 call change_frame_size (Bug#9628).
4525
cb993c58
PE
45262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4527
3930c88b
PE
4528 Port --enable-checking=all to Fedora 14 x86-64.
4529 * charset.c (syms_of_charset): Also account for glibc malloc's
4530 internal overhead when calculating the initial malloc maximum.
4531
cb993c58
PE
4532 Port --enable-checking=all to Fedora 14 x86.
4533 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4534 Move to lisp.h.
4535 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4536 (overrun_check_realloc, overrun_check_free):
4537 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4538 That way, xmalloc returns a properly-aligned pointer even if
4539 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4540 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4541 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4542 into account when calculating the initial malloc maximum.
4543 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4544 Move here from alloc.c, so that charset.c can use it too.
4545 Properly align; the old code wasn't right for common 32-bit hosts
4546 when configured with --enable-checking=all.
4547 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4548 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4549
31bed486
EZ
45502011-09-29 Eli Zaretskii <eliz@gnu.org>
4551
04c70788 4552 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4553 use EDOM.
4554
fbcaa2f3
EZ
45552011-09-28 Eli Zaretskii <eliz@gnu.org>
4556
4557 * xdisp.c (compute_display_string_end): If there's no display
4558 string at CHARPOS, return -1.
4559
4560 * bidi.c (bidi_fetch_char): When compute_display_string_end
4561 returns a negative value, treat the character as a normal
4562 character not covered by a display string. (Bug#9624)
4563
a239d4e9
JB
45642011-09-28 Juanma Barranquero <lekktu@gmail.com>
4565
4566 * lread.c (Fread_from_string): Fix typo in docstring.
4567
88652fd5
EZ
45682011-09-27 Eli Zaretskii <eliz@gnu.org>
4569
4570 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4571 newline, reseat the iterator instead of bidi-iterating there one
4572 character at a time. (Bug#9610)
32c1fffd
SM
4573 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4574 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4575
ed497dd4
AS
45762011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4577
4578 * lread.c (readevalloop): Use correct code for NBSP.
4579 (read1): Likewise. (Bug#9608)
4580
b2bf61aa
MA
45812011-09-25 Michael Albinus <michael.albinus@gmx.de>
4582
4583 * dbusbind.c (Fdbus_register_signal): When service is not
4584 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4585
32bbb17c
GM
45862011-09-25 Glenn Morris <rgm@gnu.org>
4587
4588 * buffer.c (truncate-lines): Doc fix.
4589
94e0933e
CY
45902011-09-24 Chong Yidong <cyd@stupidchicken.com>
4591
4592 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4593 (Fset_window_next_buffers): Doc fix.
4594
cddde921
GM
45952011-09-24 Glenn Morris <rgm@gnu.org>
4596
4597 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4598
1260aef1
PE
45992011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4600
25b4bfa0
PE
4601 Fix minor problems found by static checking.
4602 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4603 * indent.c (Fvertical_motion): Fix == vs = typo.
4604
e3cbd34b
EZ
46052011-09-24 Eli Zaretskii <eliz@gnu.org>
4606
a66cfb1c
SM
4607 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4608 Default value is now t. Doc fix.
6bf7006f 4609
e3cbd34b 4610 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4611 logic when moving up, not only when moving down. Fix the
e3cbd34b 4612 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4613 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4614
4615 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4616 CHARPOS is covered by a display string which includes newlines.
4617 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4618 is covered by a display string with embedded newlines.
4619
a3de0cbd
MA
46202011-09-24 Michael Albinus <michael.albinus@gmx.de>
4621
4622 * dbusbind.c (Fdbus_register_signal): Add match rule to
4623 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4624 (Fdbus_register_method, Vdbus_registered_objects_table):
4625 Fix docstring.
a3de0cbd 4626
b260039d
JM
46272011-09-24 Jim Meyering <meyering@redhat.com>
4628
32c1fffd 4629 do not ignore write error for any output size
b260039d
JM
4630 The previous change was incomplete.
4631 While it makes emacs --batch detect the vast majority of stdout
4632 write failures, errors were still ignored whenever the output size is
4633 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4634 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4635 && echo FAIL: ignored write error
4636 FAIL: ignored write error
4637 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4638 && echo FAIL: ignored write error
4639 FAIL: ignored write error
4640 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4641
8eca8a7c
AS
46422011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4643
4644 * emacs.c (Fkill_emacs): In noninteractive mode exit
4645 non-successfully if a write error occurred on stdout. (Bug#9574)
4646
3341db62
EZ
46472011-09-21 Eli Zaretskii <eliz@gnu.org>
4648
4649 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4650 the xassert test.
4651
4652 * dispextern.h (struct it): Update the comment documenting what
4653 can it->OBJECT be.
4654
8c203dbf
EZ
46552011-09-20 Eli Zaretskii <eliz@gnu.org>
4656
4657 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4658 a display string, extend search for cursor position to end of row.
4659 (find_row_edges): If the row ends in a newline from a display
4660 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4661 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4662 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4663 non-empty line. Fixes confusing cursor motion with arrow keys at
4664 the beginning of a line that starts with whitespace.
8c203dbf 4665
a4824228
LMI
46662011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4667
4668 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4669 (bug#9493).
4670
33ed493b
CY
46712011-09-18 Chong Yidong <cyd@stupidchicken.com>
4672
4673 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4674 boolean (Bug#9154).
4675
56cd55c8
EZ
46762011-09-18 Eli Zaretskii <eliz@gnu.org>
4677
4678 * xdisp.c (display_line): Record maximum and minimum buffer
4679 positions even if no glyphs were produced (e.g., by a zero-width
4680 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4681 buffer positions that will be removed from the glyph row because
4682 they don't fit.
c02dcedf
EZ
4683 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4684 column is beyond frame width: don't subtract 1 "pixel" when
4685 computing width of the stretch.
3e62b7e0
EZ
4686 (reseat_at_next_visible_line_start): Undo the change made on
4687 2011-09-17 that saved paragraph information and restored it after
4688 the call to `reseat'. (Bug#9545)
56cd55c8 4689
5ed99d36 46902011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4691
4692 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4693 and turn window cursor on if cleared (Bug#9415).
4694
5ed99d36 46952011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4696
4697 * search.c (boyer_moore): Take unibyte characters from pattern
4698 literally. (Bug#9458)
4699
9bade7b2
EZ
47002011-09-18 Eli Zaretskii <eliz@gnu.org>
4701
4702 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4703
e5e9d610
PE
47042011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4705
87e4427a
PE
4706 Fix minor problem found by static checking.
4707 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4708 initialized, to pacify gcc -Wuninitialized.
4709
e5e9d610
PE
4710 * fileio.c: Report proper errno when syscall falls.
4711 (Finsert_file_contents): Save and restore errno,
4712 so that report_file_error outputs the correct diagnostic.
4713 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4714
a1674f0b
EZ
47152011-09-18 Eli Zaretskii <eliz@gnu.org>
4716
4717 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4718
fbfb6dd4
EZ
47192011-09-17 Eli Zaretskii <eliz@gnu.org>
4720
4721 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4722 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4723
bb187662
EZ
47242011-09-17 Eli Zaretskii <eliz@gnu.org>
4725
1137e8b8 4726 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4727 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4728
4729 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4730 (bidi_find_paragraph_start): Search back for paragraph beginning
4731 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4732 (bidi_move_to_visually_next): Only trigger paragraph-related
4733 computations when the last character is a newline or at EOB, not
4734 just any NEUTRAL_B. (Bug#9470)
4735
bb187662
EZ
4736 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4737 truncated lines if point is covered by a display string. (Bug#9524)
4738
2e621251
PE
47392011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4740
4741 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4742 (cons_to_x_long): New function.
4743 (lisp_data_to_selection_data): Use it. Correct the test for
4744 short-versus-long data; it was negated. Break out of vector
4745 loop, for efficiency, when a long datum is discovered.
4746
91a15bc6
SM
47472011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4748
4749 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4750
b41c3a35
EZ
47512011-09-16 Eli Zaretskii <eliz@gnu.org>
4752
4753 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4754 GCC PR/17406) by declaring this function with external scope.
4755
7812ba2d
PE
47562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4757
4758 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4759 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4760
cf7edc2a
AS
47612011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4762
4763 * editfns.c (Fformat): Correctly handle text properties on "%%".
4764
bd01620e
EZ
47652011-09-15 Eli Zaretskii <eliz@gnu.org>
4766
4767 * xterm.c (x_draw_composite_glyph_string_foreground):
4768 * w32term.c (x_draw_composite_glyph_string_foreground):
4769 * term.c (encode_terminal_code):
4770 * composite.c (composition_update_it, get_composition_id):
4771 * xdisp.c (get_next_display_element)
4772 (fill_composite_glyph_string): Add comments about special meaning
4773 of TAB characters in a composition.
4774
a02719a3
PE
47752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4776
4777 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4778 This occurs when processing a multibyte format.
4779 Problem reported by Wolfgang Jenker.
a02719a3 4780
72589a3c
JB
47812011-09-15 Johan Bockgård <bojohan@gnu.org>
4782
4783 * xdisp.c (try_cursor_movement): Only check for exact match if
4784 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4785
1c14176c
PE
47862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4787
4788 Remove unused external symbols.
4789 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4790 * xdisp.c (calc_pixel_width_or_height): Now static.
4791 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4792 * indent.c (check_display_width):
4793 * w32term.c: Fix comment to match code.
4794 * xterm.c, xterm.h (x_catching_errors): Remove.
4795
d2eea5b5
PE
47962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4797
4798 * xselect.c: Use signed conversions more consistently (Bug#9498).
4799 (selection_data_to_lisp_data): Assume incoming selection data are
4800 signed integers, not unsigned. This is to be consistent with
4801 outgoing selection data, which was modified to use signed integers
4802 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4803 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4804 expects long, not unsigned long.
4805
46888499
EZ
48062011-09-14 Eli Zaretskii <eliz@gnu.org>
4807
4808 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4809 computation of loop end. Reported by Johan Bockgård
4810 <bojohan@gnu.org>.
4811
ef8ef9fb
CY
48122011-09-13 Chong Yidong <cyd@stupidchicken.com>
4813
4814 * frame.c (Fother_visible_frames_p): Function deleted.
4815
fa819fed
EZ
48162011-09-12 Eli Zaretskii <eliz@gnu.org>
4817
4818 * indent.c (compute_motion): Process display vector front to back
4819 rather than the other way around. (Bug#2496)
4820
2ba8e008
SM
48212011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4822
4823 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4824
20f53c69
CY
48252011-09-11 Chong Yidong <cyd@stupidchicken.com>
4826
4827 * minibuf.c (Fread_from_minibuffer): Doc fix.
4828
d562d7a4
EZ
48292011-09-11 Eli Zaretskii <eliz@gnu.org>
4830
4831 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4832 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4833
1c4d7f3d
LMI
48342011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4835
4836 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4837 value for non-existent files.
4838
b885bf36
EZ
48392011-09-11 Eli Zaretskii <eliz@gnu.org>
4840
4841 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4842 set its "size" to -1. This will set the modtime_size field of
4843 the corresponding buffer to -1, which is what
4844 verify-visited-file-modtime expects for files that do not exist.
4845 (Bug#9139)
4846
6612f0bf
PE
48472011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4848
4849 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4850 here ...
4851 * lisp.h: ... from here. push_key_description is no longer
4852 defined in keyboard.c, so its declaration should not be in
4853 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4854 logically belongs with push_key_description.
4855
dfb3f755
PE
48562011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4857
4858 * buffer.h: Include <sys/types.h> instead of <time.h>.
4859 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4860 Problem reported by Herbert J. Skuhra.
4861
3134906c
LMI
48622011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4863
4864 * xml.c (parse_region): Make the parsing work for
4865 non-comment-starting XML files again (bug#9144).
4866
8d903f4e
AS
48672011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4868
4869 * image.c (gif_load): Fix calculation of bottom and right corner.
4870 (Bug#9468)
4871
80ad64f4
EZ
48722011-09-10 Eli Zaretskii <eliz@gnu.org>
4873
4874 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4875 redisplay in small windows.
4876
208a048d
EZ
48772011-09-09 Eli Zaretskii <eliz@gnu.org>
4878
4879 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4880
9b1c252e
MR
48812011-09-08 Martin Rudalics <rudalics@gmx.at>
4882
4883 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4884 Operate on live windows only.
4885
2949f33b
JB
48862011-09-08 Juanma Barranquero <lekktu@gmail.com>
4887
4888 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4889
e08dcafd
EZ
48902011-09-07 Eli Zaretskii <eliz@gnu.org>
4891
4892 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4893 only under bidi iteration.
4894
115b96bd
JD
48952011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4896
4897 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4898
c8199d0f
PE
48992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4900
4901 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4902 Without this fix, the command to link temacs failed due to an
4903 undefined symbol __builtin_isnan. This is because
4904 /usr/include/iso/math_c99.h #defines isnan(x) to
4905 __builtin_isnan(x), but the bundled gcc, which identifies itself
4906 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4907 a __builtin_isnan.
4908 * floatfns.c (isnan): #undef, and then #define to a clone of
4909 what's in data.c.
4910 (Fisnan): Always define, since it's always available now.
4911 (syms_of_floatfns): Always define isnan at the Lisp level.
4912
e39b275c 49132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4914
4915 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4916
b2db44d9 49172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4918
f4af5137 4919 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4920 The previous code assumed that file offsets (off_t values) fit in
4921 EMACS_INT variables, which is not true on typical 32-bit hosts.
4922 The code messed up by falsely reporting buffer overflow in cases
4923 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4924 when "big" contains more than 2**29 bytes, even though this
4925 inserts just one byte and does not overflow the buffer.
4926 (Finsert_file_contents): Store file offsets as off_t
4927 values, not as EMACS_INT values. Check for overflow when
4928 converting between EMACS_INT and off_t. When checking for
4929 buffer overflow or for overlap, take the offsets into account.
4930 Don't use EMACS_INT for small values where int suffices.
4931 When checking for overlap, fix a typo: ZV was used where
4932 ZV_BYTE was intended.
4933 (Fwrite_region): Don't assume off_t fits into 'long'.
4934 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4935
ecfc0a49
MA
49362011-09-05 Michael Albinus <michael.albinus@gmx.de>
4937
4938 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4939
6511acf2 49402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4941
0999621a 4942 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4943
4944 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4945 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4946 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4947 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4948 (modify_event_symbol): Do not assume that the length of
4949 name_alist_or_stem is safe to alloca and fits in int.
4950 (Fexecute_extended_command): Likewise for function name and binding.
4951 (Frecursion_depth): Wrap around reliably on integer overflow.
4952 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4953 since some callers pass EMACS_INT values.
4954 (Fsingle_key_description): Don't crash if symbol name contains more
4955 than MAX_ALLOCA bytes.
4956 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4957 (get_minibuffer): Arg is now EMACS_INT, not int.
4958 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4959 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4960 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4961
2be7d702
PE
4962 * dbusbind.c (signature_cat): New function.
4963 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4964 Do not overrun buffer; instead, report string overflow.
4965
9d1df220
PE
4966 * dispnew.c (add_window_display_history): Don't overrun buffer.
4967 Truncate instead; this is OK since it's just a log.
4968
33ef5c64
PE
4969 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4970 even if the time zone offset is outlandishly large.
4971 Don't mishandle offset == INT_MIN.
4972
66c6fdd5
PE
4973 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4974 when creating daemon; the previous buffer-overflow check was incorrect.
4975
d749b01b
PE
4976 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4977 which has the guts of the old verror function.
4978
b5cd1905
PE
4979 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4980 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4981
6e1a67fb
PE
4982 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4983 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4984 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4985 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4986 length of string rather than counting it via multiple sprintfs;
4987 that's simpler and more reliable.
c21721cc
PE
4988 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4989 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4990 sprintf, in case result does not fit in int.
4991
c57b67fc
PE
4992 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4993 (fontset_from_font): Print it.
4994
8a401434
PE
4995 * frame.c (tty_frame_count): Now printmax_t, not int.
4996 (make_terminal_frame, set_term_frame_name): Print it.
4997 (x_report_frame_params): In X, window IDs are unsigned long,
4998 not signed long, so print them as unsigned.
4999 (validate_x_resource_name): Check for implausibly long names,
5000 and don't assume name length fits in 'int'.
5001 (x_get_resource_string): Don't blindly alloca invocation name;
5002 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5003 not fit in int.
5004
6e1a67fb
PE
5005 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5006 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5007 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5008
0df02bf3
PE
5009 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5010 Use esprintf, not sprintf, in case result does not fit in int.
5011
48e30793
PE
5012 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5013 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5014 it as a large positive number.
5015 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5016 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5017
a66ff6d8
PE
5018 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5019 in case result does not fit in int.
5020
aca216ff
PE
5021 * print.c (float_to_string): Detect width overflow more reliably.
5022 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5023 buffer overrun. Don't assume list length fits in 'int'. Treat
5024 print length of 0 as 0, not as infinity; to be consistent with other
5025 uses of print length in this function. Don't overflow print length
5026 index. Don't assume hash table size fits in 'long', or that
5027 vectorlike size fits in 'unsigned long'.
5028
31c286f7
PE
5029 * process.c (make_process): Use printmax_t, not int, to format
5030 process-name gensyms.
5031
55e5faa1
PE
5032 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5033
80f2e268
PE
5034 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5035 to avoid potential buffer overrun.
5036
670741ab
PE
5037 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5038 if X resource line is longer than 512 bytes.
5039
b7163a50
PE
5040 * xfns.c (x_window): Make sprintf buffer a bit bigger
5041 to avoid potential buffer overrun.
5042
ae58ff1f
PE
5043 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5044
c43c8a6a
PE
5045 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5046
3f8236f4
PE
50472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5048
53e9fe90 5049 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5050 Without these, Emacs silently mishandles large integers sometimes.
5051 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5052 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5053
6511acf2
PE
5054 * xdisp.c (try_window_id): Check Emacs fixnum range before
5055 converting to 'int'.
806add1d 5056
6511acf2 5057 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5058 Check that an Emacs fixnum is in range before assigning it to 'int'.
5059 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5060 values converted from Emacs fixnums.
5061 (Frecenter): Don't wrap around a line count if it is out of 'int'
5062 range; instead, treat it as an extreme value.
5063 (Fset_window_configuration, compare_window_configurations):
5064 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5065
6511acf2
PE
5066 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5067 that can exceed INT_MAX. Check that EMACS_INT value is in range
5068 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5069 (match_limit): Don't assume that a fixnum can fit in 'int'.
5070
6511acf2 5071 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5072 exceed INT_MAX.
5073
6511acf2 5074 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5075 (Fvertical_motion): Don't wrap around LINES values that don't fit
5076 in 'int'. Instead, treat them as extreme values. This is good
5077 enough for windows, which can't have more than INT_MAX lines anyway.
5078
fcb901a7
LMI
50792011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5080
0f2f6b6d
LMI
5081 * Require libxml/parser.h to avoid compilation warning.
5082
fcb901a7
LMI
5083 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5084
5085 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5086 since this reportedly can destroy thread storage.
5087
6e20a0d4
CY
50882011-08-30 Chong Yidong <cyd@stupidchicken.com>
5089
5090 * syntax.c (find_defun_start): Update all cache variables if
5091 exiting early (Bug#9401).
5092
148ae00e
EZ
50932011-08-30 Eli Zaretskii <eliz@gnu.org>
5094
f6cfbd8f
EZ
5095 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5096
148ae00e
EZ
5097 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5098 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5099 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5100
5101 * term.c (tty_append_glyph): New function.
5102 (produce_stretch_glyph): Static function and its prototype deleted.
5103
a66cfb1c
SM
5104 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5105 Add prototypes.
148ae00e 5106
c4a07a4c
PE
51072011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5110 when checking :margin (Bug#9390).
5111 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5112 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5113 so that the name doesn't mislead. All uses changed.
5114
6bc8cd65
JB
51152011-08-28 Johan Bockgård <bojohan@gnu.org>
5116
5117 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5118 set_tty_hooks.
5119
dca4927e
EZ
51202011-08-27 Eli Zaretskii <eliz@gnu.org>
5121
5122 * xdisp.c (move_it_to): Don't bail out early when reaching
5123 position beyond to_charpos, if we are scanning backwards.
5124 (move_it_vertically_backward): When DY == 0, make sure we get to
5125 the first character in the line after the newline.
5126
f2cad773
PE
51272011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5128
5129 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5130 (ccl_driver): Do not generate an out-of-range pointer.
5131 (Fccl_execute_on_string): Remove unnecessary check for
5132 integer overflow, noted by Stefan Monnier in
5133 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5134 Remove a FIXME that didn't need fixing.
5135 Simplify the newly-introduced buffer reallocation code.
5136
0cae2cdb
JB
51372011-08-27 Juanma Barranquero <lekktu@gmail.com>
5138
5139 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5140
5fc295a4 51412011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5142
70c60eb2 5143 Integer and memory overflow issues (Bug#9196).
726e0ab1 5144
d31850da
PE
5145 * doc.c (get_doc_string): Rework so that
5146 get_doc_string_buffer_size is the actual buffer size, rather than
5147 being 1 less than the actual buffer size; this makes xpalloc more
5148 convenient.
5149
a69fbedb
PE
5150 * image.c (x_allocate_bitmap_record, cache_image):
5151 * xselect.c (Fx_register_dnd_atom):
5152 Simplify previous changes by using xpalloc.
5153
fe5c5d37
PE
5154 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5155 since either will do and ptrdiff_t is convenient with xpalloc.
5156
0065d054
PE
5157 * charset.c (charset_table_size)
5158 (struct charset_sort_data.priority): Now ptrdiff_t.
5159 (charset_compare): Don't overflow if priorities differ greatly.
5160 (Fsort_charsets): Don't assume list length fits in int.
5161 Check for size-calculation overflow when allocating sort data.
5162 (syms_of_charset): Allocate an initial charset table that is
5163 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5164
5165 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5166
5167 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5168 The actual value is always <= INT_MAX, and leaving it unsigned made
5169 overflow checking harder.
5170
5171 * dispextern.h (struct glyph_matrix.rows_allocated)
5172 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5173 with xpalloc. The values are still always <= INT_MAX.
5174
5175 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5176
5177 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5178 (SAFE_NALLOCA): New macro.
5179
5180 * region-cache.c (struct boundary.pos, find_cache_boundary)
5181 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5182 (set_cache_region, invalidate_region_cache)
5183 (revalidate_region_cache, know_region_cache, region_cache_forward)
5184 (region_cache_backward, pp_cache):
5185 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5186 so that ptrdiff_t * can be passed to xpalloc.
5187 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5188 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5189 (pp_cache): Don't assume cache_len fits in int.
5190 * region-cache.h: Adjust extern decls to match.
5191
5192 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5193 EMACS_INT, since either will do, for xpalloc.
5194
5195 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5196 (xnmalloc, xnrealloc, xpalloc): New functions.
5197
726e0ab1
PE
5198 * bidi.c (bidi_shelve_header_size): New constant.
5199 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5200 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5201
51f30bc5 5202 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5203 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5204 (overlay_strings):
5205 Don't update size of array until after memory allocation succeeds,
5206 because xmalloc/xrealloc may not return.
0065d054
PE
5207 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5208 now that we have proper integer overflow checking.
5209 (record_overlay_string, overlay_strings): Catch overflows when
5210 calculating size of overlay_str_buf.
726e0ab1 5211
0065d054
PE
5212 * callproc.c (Fcall_process): Check for size overflow when
5213 calculating size of args2.
5214 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5215 Normally we prefer signed values, but sticking with ptrdiff_t would
5216 require adding more-complicated checks.
726e0ab1
PE
5217
5218 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5219 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5220 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5221 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5222
5223 * character.c (Fstring): Check for size-calculation overflow.
5224
5225 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5226 unnecessary integer overflow. Check for size overflow.
5227 (encode_coding_object): Don't update size until xmalloc succeeds.
5228
5229 * composite.c (get_composition_id): Check for overflow in glyph
5230 length calculations.
5231
5232 Integer and memory overflow fixes for display code.
5233 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5234 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5235 (scrolling_window): Check for overflow in size calculations.
5236 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5237 Don't assume glyph table len fits in int.
5238 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5239 (row_table_size): Now ptrdiff_t, not int.
5240 (scrolling_window): Avoid overflow in size calculations.
5241 Don't update size until allocation succeeds.
5242 * fns.c (concat): Check for overflow in size calculations.
5243 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5244 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5245 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5246
5247 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5248 (get_doc_string): Check for size calculation overflow.
5249 Don't update size until allocation succeeds.
5250 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5251 EMACS_INT, where ptrdiff_t will do.
5252 (Fsubstitute_command_keys): Check for string overflow.
5253
5254 * editfns.c (set_time_zone_rule): Don't assume environment length
5255 fits in int.
5256 (message_length): Now ptrdiff_t, not int.
5257 (Fmessage_box): Don't update size until allocation succeeds.
5258 Don't assume message length fits in int.
5259 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5260
0065d054
PE
5261 * emacs.c (main): Do not reallocate argv, since there is a null at
5262 the end that can be overwritten, and this way there's no need to
5263 worry about size-calculation overflow.
5264 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5265
5266 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5267 alloc succeeds.
5268 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5269
5270 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5271 (x_set_scroll_bar_width, x_figure_window_size):
5272 Check for integer overflow.
5273 (x_set_alpha): Do not assume XINT fits in int.
5274
5275 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5276 This is for the members text_lines, text_cols, total_lines, total_cols,
5277 where the system imposes an 'int' limit.
5278
5279 * fringe.c (Fdefine_fringe_bitmap):
5280 Don't update size until alloc works.
5281
5282 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5283 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5284
5285 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5286 Check for size-calculation overflow.
5287 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5288 do, as we prefer signed integers.
5289 (id_to_widget.max_size, id_to_widget.used)
5290 (xg_store_widget_in_map, xg_remove_widget_from_map)
5291 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5292 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5293 Use and return ptrdiff_t, not int.
5294 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5295 * gtkutil.h: Change prototypes to match the above.
5296
5297 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5298 are duplicate now that they've been promoted to lisp.h.
5299 (x_allocate_bitmap_record, x_alloc_image_color)
5300 (make_image_cache, cache_image, xpm_load):
5301 Don't update size until alloc is done.
5302 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5303 (x_detect_edges):
3256efce 5304 Check for size calculation overflow.
726e0ab1
PE
5305 (ct_colors_allocated_max): New constant.
5306 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5307 overflow.
3256efce 5308
726e0ab1
PE
5309 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5310 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5311 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5312 Use ptrdiff_t, not int, to count maps.
5313 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5314 calculations. Don't update size until allocation succeeds.
5315 Redo calculations to avoid overflow.
726e0ab1
PE
5316 * keyboard.h: Change prototypes to match the above.
5317
5318 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5319 to count maps.
5320 (current_minor_maps): Check for size calculation overflow.
5321 * keymap.h: Change prototypes to match the above.
5322
5323 * lread.c (read1, init_obarray): Don't update size until alloc done.
5324
5325 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5326 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5327
726e0ab1
PE
5328 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5329 Now ptrdiff_t, not int.
5330 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5331 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5332
5333 * process.c (Fnetwork_interface_list): Check for overflow
5334 in size calculation.
5335
5336 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5337
5338 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5339 overflow. Don't bother calling xmalloc when xrealloc will do.
5340
5341 * search.c (Freplace_match): Check for size calculation overflow.
5342 (Fset_match_data): Don't assume list lengths fit in 'int'.
5343
5344 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5345 for command line length. Do not attempt to address one before the
5346 beginning of an array, as that's not portable.
5347
5348 * term.c (max_frame_lines): Remove; unused.
5349 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5350 not int.
5351 (encode_terminal_code, calculate_costs): Check for size
5352 calculation overflow.
5353 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5354 table lengths and related sizes. Don't update size until alloc
5355 done. Redo calculations to avoid overflow.
5356 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5357
5358 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5359 subtracting pointers.
5360 (gobble_line): Check for overflow more carefully. Don't update size
5361 until alloc done.
5362
5363 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5364 Don't update size until alloc done.
5365 Redo size calculations to avoid overflow.
5366 Check for size calculation overflow.
0065d054 5367 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5368
5369 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5370 Use ptrdiff_t, not int, for sizes.
5371 (store_mode_line_noprop_char): Don't update size until alloc done.
5372
0065d054
PE
5373 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5374 Use ptrdiff_t, not int, for sizes.
5375 (Finternal_make_lisp_face, cache_face):
5376 Check for size calculation overflow.
5377 (cache_face): Treat size calculation overflows as if they were
5378 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5379
5380 * xfns.c (x_encode_text, x_set_name_internal)
5381 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5382 sizes, since they can exceed INT_MAX in size. Check for size
5383 calculation overflow.
5384
0065d054
PE
5385 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5386 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5387 Don't update size until alloc done.
5388
0065d054 5389 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5390 as sprintf is limited to int lengths.
1d526e2f 5391
252c5ee1
PE
5392 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5393 (X_LONG_MIN): New macros.
864d7ce7
PE
5394 Use them to make the following changes clearer.
5395 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5396 This change doesn't affect the value now, but it may help remind
5397 future maintainers not to raise the value too much later.
5398 (SELECTION_QUANTUM): Remove, replacing with ...
5399 (selection_quantum): ... new function, which avoids overflow.
5400 All uses changed.
5401 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5402 assumption that selection length fits in 'int'.
5403 (x_reply_selection_request, x_handle_selection_request)
5404 (x_get_window_property, receive_incremental_selection)
5405 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5406 (lisp_data_to_selection_data, clean_local_selection_data):
5407 Use ptrdiff_t, not int, to record length of selection.
5408 (x_reply_selection_request, x_get_window_property)
5409 (receive_incremental_selection, x_property_data_to_lisp):
5410 Redo calculations to avoid overflow.
5411 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5412 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5413 something.
5414 (x_get_window_property, receive_incremental_selection)
5415 (lisp_data_to_selection_data, x_property_data_to_lisp):
5416 Check for size-calculation overflow.
5417 (x_get_window_property, receive_incremental_selection)
5418 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5419 Don't store size until memory allocation succeeds.
5420 (x_get_window_property): Plug memory leak on memory exhaustion.
5421 Don't double-block input; malloc is safe here. Don't assume 2**34
5422 - 4 fits in unsigned long. Add an xassert to check
5423 XGetWindowProperty overflow. Be more careful about overflow
5424 calculations, and distinguish size from memory overflow better.
5425 (receive_incremental_selection): When tracing, don't assume
5426 unsigned int is less than INT_MAX.
5427 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5428 harmful) conversions of unsigned short to int.
5429 (lisp_data_to_selection_data): Don't assume that integers
5430 in the range -65535 through -1 fit in an X unsigned short.
5431 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5432 result parameters unless successful. Rely on cons_to_unsigned
5433 to report problems with elements; the old code wasn't right anyway.
5434 (x_check_property_data): Check for int overflow; we cannot use
5435 a wider type due to X limits.
5436 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5437
726e0ab1 5438 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5439
0065d054
PE
5440 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5441 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5442 (x_color_cells): Don't store size until memory allocation succeeds.
5443 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5444 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5445 (x_term_init): Don't assume length fits in int (sprintf is limited
5446 to int size).
bc18e09d 5447
ebfa62c0
PE
5448 Use ptrdiff_t for composition IDs.
5449 * character.c (lisp_string_width):
5450 * composite.c (composition_table_size, n_compositions)
5451 (get_composition_id, composition_gstring_from_id):
5452 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5453 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5454 * window.c (Frecenter):
5455 Use ptrdiff_t, not int, for composition IDs.
5456 * composite.c (get_composition_id): Check for integer overflow.
5457 * composite.h: Adjust prototypes to match the above changes.
5458
d3411f89
PE
5459 Use ptrdiff_t for hash table indexes.
5460 * category.c (hash_get_category_set):
5461 * ccl.c (ccl_driver):
5462 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5463 * coding.c (coding_system_charset_list, detect_coding_system):
5464 * coding.h (struct coding_system.id):
5465 * composite.c (get_composition_id, gstring_lookup_cache):
5466 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5467 * image.c (xpm_get_color_table_h):
5468 * lisp.h (hash_lookup, hash_put):
5469 * minibuf.c (Ftest_completion):
5470 Use ptrdiff_t for hash table indexes, not int (which is too
5471 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5472 32-bit --with-wide-int hosts).
5473
e097a6fa
PE
5474 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5475 Add a FIXME comment about memory leaks.
5476 (syms_of_charset): Don't assume xmalloc returns.
5477
5637687f
PE
5478 Don't assume that stated character widths fit in int.
5479 * character.c (Fchar_width, c_string_width, lisp_string_width):
5480 * character.h (CHAR_WIDTH):
5481 * indent.c (MULTIBYTE_BYTES_WIDTH):
5482 Use sanitize_char_width to avoid undefined and/or bad behavior
5483 with outlandish widths.
a66cfb1c 5484 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5485 now that we have two such functions. All uses changed.
5486 (sanitize_char_width): New inline function.
5487
a2271ba2
PE
5488 Don't assume that tab-width fits in int.
5489 * character.h (sanitize_width): New inline function.
5490 (SANE_TAB_WIDTH): New macro.
5491 (ASCII_CHAR_WIDTH): Use it.
5492 * indent.c (sane_tab_width): Remove. All uses replaced by
5493 SANE_TAB_WIDTH (current_buffer).
5494 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5495
18c52557
PE
5496 * fileio.c: Integer overflow issues with file modes.
5497 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5498
caeeedc1
PE
5499 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5500 Remove unreachable code.
5501 (read_hex, load_charset_map_from_file): Check for integer overflow.
5502
6df6ae42 5503 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5504 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5505 (x_send_scroll_bar_event): Likewise. Check that the size does not
5506 exceed limits imposed by XClientMessageEvent, as well as the usual
5507 ptrdiff_t and size_t limits.
5508
b13995db
PE
5509 * keyboard.c: Overflow, signedness and related fixes.
5510 (make_lispy_movement): Use same integer type in forward decl
5511 that is used in the definition.
5512 (read_key_sequence, keyremap_step):
5513 Change bufsize argument back to int, undoing my 2011-03-30 change.
5514 We prefer signed types, and int is wide enough here.
5515 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5516 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5517 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5518 length, not size_t. Use ptrdiff_t for index, not int.
5519 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5520 possibility of integer overflow.
5521
13464394
PE
5522 Overflow, signedness and related fixes for images.
5523
5524 * dispextern.h (struct it.stack[0].u.image.image_id)
5525 (struct_it.image_id, struct image.id, struct image_cache.size)
5526 (struct image_cache.used, struct image_cache.ref_count):
5527 * gtkutil.c (update_frame_tool_bar):
5528 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5529 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5530 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5531 * nsmenu.m (update_frame_tool_bar):
5532 * xdisp.c (calc_pixel_width_or_height):
5533 * xfns.c (image_cache_refcount):
5534 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5535 on typical 64-bit hosts.
5536
5537 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5538 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5539 Omit unnecessary casts to int.
5540 (parse_image_spec): Check that integers fall into 'int' range
5541 when the callers expect that.
5542 (image_ascent): Redo ascent calculation to avoid int overflow.
5543 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5544 (lookup_image): Remove unnecessary tests.
5545 (xbm_image_p): Locals are now of int, not EMACS_INT,
5546 since parse_image_check makes sure they fit into int.
5547 (png_load, gif_load, svg_load_image):
5548 Prefer int to unsigned where either will do.
5549 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5550 old tiff_error_handler and tiff_warning_handler.
5551 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5552 stack buffer overflows. It uses only the features of vsnprintf
5553 that are common to both POSIX and native Microsoft.
5554 (tiff_error_handler, tiff_warning_handler): Use it.
5555 (tiff_load, gif_load, imagemagick_load_image):
5556 Don't assume :index value fits in 'int'.
5557 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5558 (imagemagick_load_image): Check that crop parameters fit into
5559 the integer types that MagickCropImage accepts. Don't assume
5560 Vimagemagick_render_type has a nonnegative value. Don't assume
5561 size_t fits in 'long'.
5562 (gs_load): Use printmax_t to print the widest integers possible.
5563 Check for integer overflow when computing image height and width.
5564
c11821d4
EZ
55652011-08-26 Eli Zaretskii <eliz@gnu.org>
5566
5567 * xdisp.c (redisplay_window): Don't force window start if point
5568 will be invisible in the resulting window. (Bug#9324)
5569
0c95fcf7
EZ
55702011-08-25 Eli Zaretskii <eliz@gnu.org>
5571
5572 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5573 the display spec is of the form `(space ...)'.
5574 (handle_display_spec): Return the value returned by
5575 handle_single_display_spec, not just 1 or zero.
5576 (handle_single_display_spec): If the display spec is of the form
5577 `(space ...)', and specifies display in the text area, return 2
5578 rather than 1.
fee65a97 5579 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5580 accurately, and prefer exact match for point under bidi.
5581 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5582
5583 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5584 into disp_prop; all users changed.
5585
5586 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5587 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5588 for the text covered by the display property.
5589
e4ed06f1
CY
55902011-08-25 Chong Yidong <cyd@stupidchicken.com>
5591
5592 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5593 Change return value to nil.
5594 (Frecord_buffer): Delete unused function.
5595
f67cdd7f
EZ
55962011-08-24 Eli Zaretskii <eliz@gnu.org>
5597
5980d4c6
EZ
5598 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5599 buffers, return left-to-right.
8610fe8b
EZ
5600 (set_cursor_from_row): Consider candidate row a win if its glyph
5601 represents a newline and point is on that newline. Fixes cursor
5602 positioning on the newline at EOL of R2L text within L2R
5603 paragraph, and vice versa.
5604 (try_cursor_movement): Check continued rows, in addition to
5605 continuation rows. Fixes unwarranted scroll when point enters a
5606 continued line of R2L text within an L2R paragraph, or vice versa.
5607 (cursor_row_p): Consider the case of point being equal to
5608 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5609 from the end of a short line to the beginning of a continued line
5610 of R2L text within L2R paragraph.
5611 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5612 composed characters.
5980d4c6 5613
f67cdd7f
EZ
5614 * bidi.c (bidi_check_type): Use xassert.
5615 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5616 members.
5617
bca633fb
EZ
56182011-08-23 Eli Zaretskii <eliz@gnu.org>
5619
5620 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5621 a character.
5622
4a5885a7
CY
56232011-08-23 Chong Yidong <cyd@stupidchicken.com>
5624
5625 * nsfont.m (ns_otf_to_script): Fix typo.
5626
0902a04e
KH
56272011-08-22 Kenichi Handa <handa@m17n.org>
5628
5629 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5630 extra slot even if the purpose is char-code-property-table.
5631
1a2e6670
EZ
56322011-08-23 Eli Zaretskii <eliz@gnu.org>
5633
8ddde651
EZ
5634 * xdisp.c (redisplay_window): When computing centering_position,
5635 account for the height of the header line. (Bug#8874)
5636
425cc014
EZ
5637 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5638 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5639 candidate is selected by the mouse, and that candidate has a
5640 composed character under the mouse.
5641
1a2e6670
EZ
5642 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5643 coordinates reported by pos-visible-in-window-p for a composed
5644 character in column zero.
5645
8b76d6f8
SM
56462011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5647
5648 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5649
dac347dd
EZ
56502011-08-22 Eli Zaretskii <eliz@gnu.org>
5651
5652 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5653 consider it a hit if to_charpos is anywhere in the range of the
5654 composed buffer positions.
5655
e013fb34
CY
56562011-08-22 Chong Yidong <cyd@stupidchicken.com>
5657
5658 * image.c (gif_load): Don't assume that each subimage has the same
5659 dimensions as the base image. Handle disposal method that is
5660 "undefined" by the gif spec (Bug#9335).
5661
bd1ba3e8
CY
56622011-08-20 Chong Yidong <cyd@stupidchicken.com>
5663
5664 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5665 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5666
54a1215b
EZ
56672011-08-19 Eli Zaretskii <eliz@gnu.org>
5668
823564e5
EZ
5669 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5670 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5671 from an Org mode buffer to a Speedbar frame.
5672
54a1215b
EZ
5673 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5674 a composition, take its buffer position from IT->cmp_it.charpos.
5675 Fixes cursor positioning at the beginning of a line that begins
5676 with a composed character.
5677
9778ebcc
EZ
56782011-08-18 Eli Zaretskii <eliz@gnu.org>
5679
0be6ee06
EZ
5680 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5681 character bidirectional type, use STRONG_L instead. Fixes crashes
5682 in a buffer produced by `describe-categories'.
5683
9778ebcc
EZ
5684 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5685 members before the level stack, so they would be saved and
5686 restored when copying iterator state. Fixes incorrect reordering
5687 around TABs covered by display properties.
5688
156bffbe
AS
56892011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5690
6b02f655 5691 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5692
72ad093b
CY
56932011-08-17 Chong Yidong <cyd@stupidchicken.com>
5694
5695 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5696 (internal_condition_case_2, internal_condition_case_n):
5697 Remove unnecessary aborts (Bug#9081).
72ad093b 5698
35774242
EZ
56992011-08-17 Eli Zaretskii <eliz@gnu.org>
5700
5701 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5702 has no `load' handler, try opening the file locally. (Bug#9311)
5703
db76dd85
KB
57042011-08-16 Ken Brown <kbrown@cornell.edu>
5705
5706 * gmalloc.c: Expand comment.
5707
b215eee5
EZ
57082011-08-16 Eli Zaretskii <eliz@gnu.org>
5709
5710 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5711 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5712
a4579d33
KB
57132011-08-16 Ken Brown <kbrown@cornell.edu>
5714
5715 Fix memory allocation problems in Cygwin build (Bug#9273).
5716
5717 * unexcw.c ( __malloc_initialized): Declare external variable.
5718 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5719
8b76d6f8
SM
5720 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5721 New variables.
a4579d33
KB
5722 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5723 dumped emacs.
5724 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5725 in the static heap.
5726 [CYGWIN] (special_realloc): New function.
5727 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5728 requests to realloc storage in the static heap.
5729
3ebec551
PE
57302011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5731
5732 * bidi.c (bidi_initialize): Remove unused local.
5733
9fd8be00
EZ
57342011-08-15 Eli Zaretskii <eliz@gnu.org>
5735
6b02f655
SM
5736 * bidimirror.h:
5737 * biditype.h: Remove file.
5738 * makefile.w32-in ($(BLD)/bidi.$(O)):
5739 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5740
5741 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5742
5743 * chartab.c: Improve commentary for the uniprop_table API.
5744
32413314
EZ
5745 * bidi.c (bidi_paragraph_init): Support zero value of
5746 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5747 (bidi_initialize): Use uniprop_table instead of including
5748 biditype.h and bidimirror.h.
32413314 5749
9fd8be00
EZ
5750 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5751 coordinates of the iterator when restoring from ppos_it.
5752 (Bug#9296)
5753
5cf2b69b
KH
57542011-08-14 Kenichi Handa <handa@m17n.org>
5755
5756 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5757 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5758
daf17d00
EZ
57592011-08-14 Eli Zaretskii <eliz@gnu.org>
5760
5761 * xdisp.c (move_it_in_display_line_to): Don't invoke
5762 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5763 ppos_it. Fixes vertical cursor motion when line beginning is
5764 covered by an image. (Bug#9296)
5765
08e3161a
JD
57662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5767
5768 * nsterm.h (ns_run_ascript): Declare.
5769 (NSAPP_DATA2_RUNASSCRIPT): Define.
5770
5771 * nsfns.m (as_script, as_result, as_status): New static variables.
5772 (ns_run_ascript): New function.
5e617bc2 5773 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5774 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5775 the event loop. Get status from as_status (Bug#7276).
5776
5777 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5778 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5779 the event loop (Bug#7276).
5780
a3720aa2
AS
57812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5782
5783 * gnutls.c (QCgnutls_bootprop_priority)
5784 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5785 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5786 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5787 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5788 (QCgnutls_bootprop_verify_hostname_error)
5789 (QCgnutls_bootprop_callbacks_verify): Rename from
5790 Qgnutls_bootprop_..., all uses changed.
5791
5792 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5793 uses changed.
5794
0a0d27fb
PE
57952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5796
19d5c50c
PE
5797 * xfaces.c (Qframe_set_background_mode): Now static.
5798 * dispextern.h (Qframe_set_background_mode): Remove decl.
5799
0a0d27fb
PE
5800 * process.c (Fnetwork_interface_info): Declare local only if needed.
5801
377538cb
JD
58022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5803
5804 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5805 (Fnetwork_interface_list): Allocate in increments of bytes instead
5806 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5807 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5808 sockaddr.
5809 (struct ifflag_def): notrailers is smart on OSX.
5810 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5811 Get hardware address with getifaddrs if available.
5812
08fff70c
EZ
58132011-08-12 Eli Zaretskii <eliz@gnu.org>
5814
5815 * xdisp.c (iterate_out_of_display_property): xassert that
5816 IT->position is set to within IT->object's boundaries. Break from
5817 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5818 when IT->position is set up wrongly due to some bug.
5819 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5820 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5821 entry. Force push_it to save on the stack the current
5822 buffer/string position, to be restored by pop_it. Fix flags in
5823 the iterator structure wrt the object coming from a display
5824 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5825 properties. (Bug#9284)
5826
7be1c708 58272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5828
7be1c708
CY
5829 * fontset.c (fontset_get_font_group): Add proper type checks.
5830 (Bug#9172)
aac0c6e3 5831
7be1c708 58322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5833
7be1c708
CY
5834 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5835 and LC_VERSION_MIN_MACOSX.
5836 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5837 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5838
97bb72a6
EZ
58392011-08-08 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5842 no-display-properties-and-no-overlays under bidi display.
5843 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5844 properties and overlays.
97bb72a6 5845
d5617611
CY
58462011-08-08 Chong Yidong <cyd@stupidchicken.com>
5847
37e11a63
CY
5848 * editfns.c (Fset_time_zone_rule): Document relationship with the
5849 setenv function.
5850
d5617611
CY
5851 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5852 the font entity extracted from the cache (Bug#8109).
5853
58872834
CY
58542011-08-07 Chong Yidong <cyd@stupidchicken.com>
5855
5856 * composite.c (autocmp_chars): Don't reset point. That is done by
5857 restore_point_unwind (Bug#5984).
5858
75bfc667
JL
58592011-08-07 Juri Linkov <juri@jurta.org>
5860
5861 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5862 to show the arg `TIME' instead of `TIMEVAL'.
5863
d1410150
EZ
58642011-08-06 Eli Zaretskii <eliz@gnu.org>
5865
5866 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5867 display property strides EOL and includes a newline, as in
5868 longlines-mode. (Bug#9254)
75b771e4
EZ
5869 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5870 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5871
5872 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5873 is non-zero, even if the data buffer is NULL. Fixes a crash in
5874 vertical-motion with longlines-mode. (Bug#9254)
5875
35928349
EZ
58762011-08-05 Eli Zaretskii <eliz@gnu.org>
5877
ec7cc85b
EZ
5878 * bidi.c <bidi_cache_total_alloc>: Now static.
5879 (bidi_initialize): Initialize bidi_cache_total_alloc.
5880
8b76d6f8 5881 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5882 cache. (Bug#9221)
5883
5884 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5885 amount allocated this far in `bidi_cache_total_alloc'.
5886 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5887 non-zero, only free the data buffer without restoring the cache
5888 contents. All callers changed.
5889
5890 * dispextern.h (bidi_unshelve_cache): Update prototype.
5891
5892 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5893 (move_it_in_display_line, move_it_to)
5894 (move_it_vertically_backward, move_it_by_lines): Replace the call
5895 to xfree to an equivalent call to bidi_unshelve_cache.
5896 (move_it_in_display_line_to): Fix logic of returning
412b6358 5897 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5898
e2e2423b
EZ
58992011-08-05 Eli Zaretskii <eliz@gnu.org>
5900
5901 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5902 came from a string character with a `cursor' property. (Bug#9229)
5903
ae9e757a
JD
59042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5905
5906 * Makefile.in (LIB_PTHREAD): New variable.
5907 (LIBES): Add LIB_PTHREAD (Bug#9216).
5908
5909 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5910 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5911
213bd7f2
AS
59122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5913
6b02f655 5914 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5915
99aaf75f
JD
59162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5917
5918 * xterm.c (x_find_topmost_parent): New function.
5919 (x_set_frame_alpha): Find topmost parent window with
5920 x_find_topmost_parent and set the property there also (bug#9181).
5921 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5922
c74e9d86
PE
59232011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 * callproc.c (Fcall_process): Avoid vfork clobbering
5926 the local vars buffer, coding_systems, current_dir.
5927
640c8776
SM
59282011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5929
5930 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5931
f26d0e4c
PE
59322011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5933
8a10d76c
PE
5934 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5935 so that it is not optimized away.
5936
f26d0e4c
PE
5937 * xdisp.c (compute_display_string_pos): Remove unused local.
5938
55439c61
EZ
59392011-08-02 Eli Zaretskii <eliz@gnu.org>
5940
5941 Fix slow cursor motion and scrolling in large buffers with
5942 selective display, like Org Mode buffers. (Bug#9218)
5943
5944 * dispextern.h (struct bidi_it): New member disp_prop_p.
5945
5946 * xdisp.c: Remove one-slot cache of display string positions.
5947 (compute_display_string_pos): Accept an additional argument
5e617bc2 5948 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5949 for a display string or property. If found, set DISP_PROP_P
5950 non-zero.
5951
5952 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5953 DISP_PROP_P, and pass it to compute_display_string_pos.
5954 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5955 non-zero. All callers of bidi_fetch_char changed.
5956
fb33fa43
SM
59572011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5958
5959 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5960
b099e063
DM
59612010-12-03 Don March <don@ohspite.net>
5962
5963 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5964 last character M-[char] is translated to ESC [char] (bug#7541).
5965
5cc7f7af
KH
59662011-08-02 Kenichi Handa <handa@m17n.org>
5967
d0fffa3f 5968 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5969
5970 * chartab.c (uniprop_table): Make it non-static.
5971
525d5e6e
EZ
59722011-08-01 Eli Zaretskii <eliz@gnu.org>
5973
5974 * xdisp.c (forward_to_next_line_start): Accept additional argument
5975 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5976 on the newline.
5977 (reseat_at_next_visible_line_start): Use the bidi iterator state
5978 returned by forward_to_next_line_start to restore the state of
5979 it->bidi_it after backing up to previous newline. (Bug#9212)
5980
31011111
AS
59812011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5982
5983 * regex.c (re_comp): Protoize.
5984 (re_exec): Fix return type.
5985 (regexec): Fix type of `ret'. (Bug#9203)
5986
476371c4
PE
59872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5988
e5d76069
PE
5989 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5990 This is needed if max-image-size is a floating-point number.
5991
9a79b20c
AS
59922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5993
5994 * print.c (print_object): Print empty symbol as ##.
5995
5996 * lread.c (read1): Read ## as empty symbol.
5997
d8c2fa78
AA
59982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5999
6000 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6001 setting frame foreground color (Bug#9175).
6002 (x_set_background_color): Likewise.
6003
ffe57a7a
AA
6004 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6005 contents (Bug#9176).
6006 (EmacsTooltip -init): Remove bezels and add shadows to
6007 tooltip windows.
6008
bf3492a5
AA
6009 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6010 or scroll bar (Bug#8470).
6011
d55e9c53
AA
6012 * nsfont.m (nsfont_open): Remove assignment to voffset and
6013 unnecessary vars hshink, expand, hd, full_height, min_height.
6014 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6015
6016 * nsterm.h (nsfont_info): Remove voffset field.
6017
d8c2fa78 60182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6019
6020 Implement strike-through and overline on NextStep (Bug#8863).
6021
6022 * nsfont.m (nsfont_open): Use underline position provided by font,
6023 instead of hard-coded value of 2.
6024 (nsfont_draw): Call ns_draw_text_decoration instead.
6025
6026 * nsterm.h: Add declaration for ns_draw_text_decoration.
6027
6028 * nsterm.m (ns_draw_text_decoration): New function for drawing
6029 underline, overline, and strike-through.
6030 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6031 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6032 accommodate underlining, etc.
4843aac3 6033
4cc60b9b
EZ
60342011-07-28 Eli Zaretskii <eliz@gnu.org>
6035
bc7ece87
EZ
6036 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6037 default.
4cc60b9b 6038
476371c4
PE
60392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6040
66606eea
PE
6041 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6042 Without this fix, if a signal arrives just after memory fills up,
6043 'malloc' might be invoked reentrantly.
6044
476371c4
PE
6045 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6046 In other words, assume that every image size is allowed, on non-X
6047 hosts. This assumption is probably wrong, but it lets Emacs compile.
6048
f3fcc40d
AS
60492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6050
6051 * regex.c (re_iswctype): Convert return values to boolean.
6052
350c992f
EZ
60532011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6054
6055 * xdisp.c (compute_display_string_pos): Don't use cached display
6056 string position if the buffer had its restriction changed.
6057 (Bug#9184)
6058
5266b4bb
PE
60592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6060
6061 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6062
2573a837 60632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6064
41f55ccd 6065 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6066
39e378da
PE
6067 * bidi.c: Integer size and overflow fixes.
6068 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6069 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6070 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6071 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6072 (bidi_find_other_level_edge):
6073 Use ptrdiff_t instead of EMACS_INT where either will do.
6074 This works better on 32-bit hosts configured --with-wide-int.
6075 (bidi_cache_ensure_space): Check for size-calculation overflow.
6076 Use % rather than repeated addition, for better worst-case speed.
6077 Don't set bidi_cache_size until after xrealloc returns, because it
6078 might not return.
6079 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6080 (bidi_cache_ensure_space): Also check that the bidi cache size
6081 does not exceed that of the largest Lisp string or buffer. See Eli
6082 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6083
5e927815
PE
6084 * alloc.c (__malloc_size_t): Remove.
6085 All uses replaced by size_t. See Andreas Schwab's note
6086 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6087
ca4aa935
PE
6088 * image.c: Improve checking for integer overflow.
6089 (check_image_size): Assume that f is nonnull, since
6090 it is always nonnull in practice. This is one less thing to
6091 worry about when checking for integer overflow later.
6092 (x_check_image_size): New function, which checks for integer
6093 overflow issues inside X.
6094 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6095 This removes the need for a memory_full check.
6096 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6097 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6098 (xbm_read_bitmap_data): Change locals back to 'int', since
6099 their values must fit in 'int'.
6100 (xpm_load_image, png_load, tiff_load):
6101 Invoke x_create_x_image_and_pixmap earlier,
6102 to avoid much needless work if the image is too large.
6103 (tiff_load): Treat overly large images as if
6104 x_create_x_image_and_pixmap failed, not as malloc failures.
6105 (gs_load): Use x_check_image_size.
6106
5f8f9cc2
PE
6107 * gtkutil.c: Omit integer casts.
6108 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6109 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6110
5adf60bc
PE
6111 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6112
c8907a93
PE
6113 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6114 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6115 would wrongly return t on a 64-bit host.
6116
e3c25c68
PE
6117 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6118 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6119 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6120 and therefore cause GCC to emit a bogus diagnostic in some cases.
6121
3f791afe
PE
6122 * image.c: Integer signedness and overflow and related fixes.
6123 This is not an exhaustive set of fixes, but it's time to
6124 record what I've got.
6125 (lookup_pixel_color, check_image_size): Remove redundant decls.
6126 (check_image_size): Don't assume that arbitrary EMACS_INT values
6127 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6128 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6129 (tiff_load, imagemagick_load_image):
6130 Check for overflow in size calculations.
6131 (x_create_x_image_and_pixmap): Remove unnecessary test for
6132 xmalloc returning NULL; that can't happen.
6133 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6134 (xpm_color_bucket): Use better integer hashing function.
6135 (xpm_cache_color): Don't possibly over-allocate memory.
6136 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6137 (gif_memory_source):
6138 Use ptrdiff_t, not int or size_t, to record sizes.
6139 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6140 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6141 either works, as we prefer signed integers.
6142 (tiff_read_from_memory, tiff_write_from_memory):
6143 Return tsize_t, not size_t, since that's what the TIFF API wants.
6144 (tiff_read_from_memory): Don't fail simply because the read would
6145 go past EOF; instead, return a short read.
6146 (tiff_load): Omit no-longer-needed casts.
6147 (Fimagemagick_types): Don't assume size fits into 'int'.
6148
3cc5a532
PE
6149 Improve hashing quality when configured --with-wide-int.
6150 * fns.c (hash_string): New function, taken from sxhash_string.
6151 Do not discard information about ASCII character case; this
6152 discarding is no longer needed.
6153 (sxhash-string): Use it. Change sig to match it. Caller changed.
6154 * lisp.h: Declare it.
6155 * lread.c (hash_string): Remove, since we now use fns.c's version.
6156 The fns.c version returns a wider integer if --with-wide-int is
6157 specified, so this should help the quality of the hashing a bit.
6158
b312a492
PE
6159 * emacs.c: Integer overflow minor fix.
6160 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6161 Define only if GNU_LINUX.
6162 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6163
dfd153ae
PE
6164 * dispnew.c: Integer signedness and overflow fixes.
6165 Remove unnecessary forward decls, that were a maintenance hassle.
6166 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6167 All uses changed.
6168 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6169 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6170 (prepare_desired_row, line_draw_cost):
6171 Use int, not unsigned, where either works.
6172 (save_current_matrix, restore_current_matrix):
6173 Use ptrdiff_t, not size_t, where either works.
6174 (init_display): Check for overflow more accurately, and without
6175 relying on undefined behavior.
6176
a81d11a3
PE
6177 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6178 Remove, replacing with the new symbols in lisp.h. All uses changed.
6179 * fileio.c (make_temp_name):
6180 * filelock.c (lock_file_1, lock_file):
6181 * xdisp.c (message_dolog):
6182 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6183 Use pMd etc. instead.
6184 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6185 replacing the pWIDE etc. symbols removed from editfns.c.
6186
3300e6fd
PE
6187 * keyboard.h (num_input_events): Now uintmax_t.
6188 This is (very slightly) less likely to mess up due to wraparound.
6189 All uses changed.
6190
fd05c7e9
PE
6191 * buffer.c: Integer signedness fixes.
6192 (alloc_buffer_text, enlarge_buffer_text):
6193 Use ptrdiff_t rather than size_t when either will do, as we prefer
6194 signed integers.
6195
903fe15d
PE
6196 * alloc.c: Integer signedness and overflow fixes.
6197 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6198 (__malloc_size_t): Default to size_t, not to int.
6199 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6200 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6201 Prefer ptrdiff_t to size_t when either would do, as we prefer
6202 signed integers.
6203 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6204 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6205 Now const. Initialize with values that are in range even if char
6206 is signed.
6207 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6208 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6209 These functions do the right thing with sizes > 2**32.
6210 (check_depth): Now ptrdiff_t, not int.
6211 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6212 Adjust to new way of storing sizes. Check for size overflow bugs
6213 in rest of code.
6214 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6215 slightly wrong anyway, as it missed one instance of
6216 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6217 (refill_memory_reserve): Omit needless cast to size_t.
6218 (mark_object_loop_halt): Mark as externally visible.
6219
ac82cc6a
PE
6220 * xselect.c: Integer signedness and overflow fixes.
6221 (Fx_register_dnd_atom, x_handle_dnd_message):
6222 Use ptrdiff_t, not size_t, since we prefer signed.
6223 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6224 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6225 x_dnd_atoms_size and x_dnd_atoms_length.
6226
c2d1e36d
PE
6227 * doprnt.c: Prefer signed to unsigned when either works.
6228 * eval.c (verror):
6229 * doprnt.c (doprnt):
6230 * lisp.h (doprnt):
6231 * xdisp.c (vmessage):
6232 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6233 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6234 prefer signed arithmetic to avoid comparison confusion.
6235 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6236 but is a bit tricky.
6237
0e926e56
PE
6238 Assume freestanding C89 headers, string.h, stdlib.h.
6239 * data.c, doprnt.c, floatfns.c, print.c:
6240 Include float.h unconditionally.
6241 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6242 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6243 * regex.c: Likewise for stddef.h, string.h.
6244 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6245 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6246 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6247 (STDC_HEADERS): Remove obsolete defines.
6248 * sysdep.c: Include limits.h unconditionally.
6249
9cfdb3ec
PE
6250 Assume support for memcmp, memcpy, memmove, memset.
6251 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6252 * regex.c (memcmp, memcpy):
6253 Remove; we assume C89 now.
6254
6255 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6256 (__malloc_safe_bcopy): Remove; no longer needed.
6257
cf950e6b 6258 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6259 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6260 well either way, and we prefer signed to unsigned.
6261
dbf38e02
LMI
62622011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6263
6264 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6265 closes the connection while we're reading (bug#9182).
6266
d6f0886c 62672011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6268
d6f0886c
JD
6269 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6270 are specified (Bug#9168).
24e0f6b1 6271
2eb1f9e6
PE
62722011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6273
6274 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6275 Found by GCC static checking and --with-wide-int on a 32-bit host.
6276
22381272 62772011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6278
6279 * xdisp.c (compute_display_string_pos): Fix logic of caching
6280 previous display string position. Initialize cached_prev_pos to
6281 -1. Fixes slow-down at the beginning of a buffer.
6282
f25e39b4
EZ
62832011-07-24 Eli Zaretskii <eliz@gnu.org>
6284
6285 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6286 for attrs[LFACE_FONTSET_INDEX].
6287
04c4b52e
PE
62882011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6289
6290 * xml.c (parse_region): Remove unused local
6291 that was recently introduced.
6292
c1734fbd
EZ
62932011-07-23 Eli Zaretskii <eliz@gnu.org>
6294
be18c5a5
EZ
6295 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6296 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6297
c1734fbd
EZ
6298 * xdisp.c (move_it_in_display_line_to): Record the best matching
6299 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6300 exit if none of the characters scanned was an exact match.
6301 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6302 when exact match is impossible due to invisible text, and the
6303 lines are truncated.
6304
a258d627
JD
63052011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6306
6307 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6308 for OSX >= 10.7.
6309
b6d5a689
EZ
63102011-07-22 Eli Zaretskii <eliz@gnu.org>
6311
0f74f785
EZ
6312 Fix a significant slow-down of cursor motion with C-n, C-p,
6313 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6314 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6315 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6316 (next_element_from_buffer): Call compute_stop_pos_backwards to
6317 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6318 base_level_stop.
6319 (reseat): Don't look for prev_stop, as that could mean a very long
6320 run.
6321 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6322 <cached_disp_overlay_modiff>: Cache for last found display string
6323 position.
551918c1 6324 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6325 about the same buffer in the same area of character positions, and
6326 the buffer wasn't changed since the time the display string
6327 position was cached.
551918c1 6328
b2d0c91a
EZ
63292011-07-22 Eli Zaretskii <eliz@gnu.org>
6330
6331 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6332 is an integer, which is important for empty lines. (Bug#9149)
6333
043604ee
CY
63342011-07-22 Chong Yidong <cyd@stupidchicken.com>
6335
6336 * frame.c (Fmodify_frame_parameters): In tty case, update the
6337 default face if necessary (Bug#4238).
6338
da4adb04
CY
63392011-07-21 Chong Yidong <cyd@stupidchicken.com>
6340
6341 * editfns.c (Fstring_to_char): No need to explain what a character
6342 is in the docstring (Bug#6576).
6343
9abd0532
LMI
63442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6345
6346 * xml.c (parse_region): Make sure we always return a tree.
6347
36881d16
HK
63482011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6349
6350 * xml.c (parse_region): If a document contains only comments,
6351 return that, too.
6352
1e98674d
LMI
63532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6354
6355 * xml.c (make_dom): Return comments, too.
6356
590bd467
PE
63572011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6358
6359 Port to OpenBSD.
6360 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6361 and the surrounding thread.
6362 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6363 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6364 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6365 timer goes off.
6366 * s/openbsd.h (BROKEN_SIGIO): Define.
6367 * unexelf.c (unexec) [__OpenBSD__]:
6368 Don't update the .mdebug section of the Alpha COFF symbol table.
6369
f41628b2
LMI
63702011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6371
6372 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6373 (bug#8460).
6374
b59b67c5
PE
63752011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6376
15e3a074
PE
6377 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6378 This fixes some race conditions on the permissions of any newly
6379 created file.
6380
41bed37d
PE
6381 * alloc.c (valid_pointer_p): Use pipe, not open.
6382 This fixes some permissions issues when debugging.
6383
b59b67c5
PE
6384 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6385 If fchown fails to set both uid and gid, try to set just gid,
6386 as that is sometimes allowed. Adjust the file's mode to eliminate
6387 setuid or setgid bits that are inappropriate if fchown fails.
6388
925a6be7
SM
63892011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6390
6391 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6392 to compare Lisp_Objects.
6393 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6394 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6395 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6396
52968808
AS
63972011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6398
0a6a104b
AS
6399 * lread.c (read_integer): Unread even EOF character.
6400 (read1): Likewise. Properly record start position of symbol.
6401
52968808
AS
6402 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6403 symbol character follows.
6404
9e381cdd
PE
64052011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6406
6407 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6408 This works around a problem with the previous change to Fcopy_file.
6409 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6410 and without this change, GCC might complain about discarding
6411 fchown's return value.
6412
b5641435
JB
64132011-07-16 Juanma Barranquero <lekktu@gmail.com>
6414
6415 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6416
a8031457
PE
64172011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6418
6419 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6420
dd889327
LMI
64212011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6422
750c33f7
LMI
6423 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6424 it's used from the C level.
6425
dd889327
LMI
6426 * process.c: Use the same condition for POLL_FOR_INPUT in both
6427 keyboard.c and process.c (bug#1858).
6428
87e86684
LM
64292011-07-09 Lawrence Mitchell <wence@gmx.li>
6430
6431 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6432 (Fgnutls_boot): Use it.
6433
64348f40
AS
64342011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6435
6436 * doc.c (Fsubstitute_command_keys): Revert last change.
6437
1d698799
LMI
64382011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6439
f863868c
LMI
6440 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6441 quotes the next character, and doesn't affect other longer
6442 sequences (bug#8935).
6443
1d698799
LMI
6444 * lread.c (syms_of_lread): Clarify that is isn't only
6445 `eval-buffer' and `eval-defun' that's affected by
6446 `lexical-binding' (bug#8460).
6447
aa4b6df6
EZ
64482011-07-15 Eli Zaretskii <eliz@gnu.org>
6449
6450 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6451 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6452
5d856da6
PE
64532011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6454
ad6042bb
PE
6455 Fix minor problems found by static checking.
6456 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6457 (elsz): Now a signed constant, not a size_t var. We prefer signed
6458 types to unsigned, to avoid integer comparison confusion. Without
6459 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6460 "cannot optimize loop, the loop counter may overflow", a symptom
6461 of the confusion.
f00bbb22 6462 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6463 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6464
6468f31c
LMI
64652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6466
49080b10
LMI
6467 * search.c (Fre_search_backward): Mention `case-fold-search' in
6468 all the re_search_* functions (bug#8138).
6469
6468f31c
LMI
6470 * keyboard.c (Fopen_dribble_file): Document when the file is
6471 closed (bug#8056).
6472
c965adc5
EZ
64732011-07-14 Eli Zaretskii <eliz@gnu.org>
6474
df9733bf
EZ
6475 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6476 bidi_cache_idx.
6477
0bb23927
EZ
6478 Support bidi reordering of display and overlay strings.
6479 * xdisp.c (compute_display_string_pos)
6480 (compute_display_string_end): Accept additional argument STRING.
6481 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6482 (reseat_to_string): Initialize bidi_it->string.s and
6483 bidi_it->string.schars.
6484 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6485 NULL (avoids a crash in bidi_paragraph_init).
6486 Initialize itb.string.lstring.
0bb23927
EZ
6487 (init_iterator): Call bidi_init_it only of a valid
6488 buffer position was specified. Initialize paragraph_embedding to
6489 L2R.
6490 (reseat_to_string): Initialize the bidi iterator.
6491 (display_string): If we need to ignore text properties of
6492 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6493 original value of -1 will not work with bidi.)
6494 (compute_display_string_pos): First arg is now struct
6495 `text_pos *'; all callers changed. Support display properties on
6496 Lisp strings.
6497 (compute_display_string_end): Support display properties on Lisp
6498 strings.
6499 (init_iterator, reseat_1, reseat_to_string): Initialize the
6500 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6501 when iterating on a string not from display properties).
640c8776
SM
6502 (compute_display_string_pos, compute_display_string_end):
6503 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6504 arrow keys.
6505 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6506 base_level_stop; instead, set base_level_stop to BEGV.
6507 Fixes crashes in vertical-motion.
0bb23927
EZ
6508 (next_element_from_buffer): Improve commentary for when
6509 the iterator is before prev_stop.
6510 (init_iterator): Initialize bidi_p from the default value of
6511 bidi-display-reordering, not from buffer-local value. Use the
6512 buffer-local value only if initializing for buffer iteration.
6513 (handle_invisible_prop): Support invisible properties on strings
6514 that are being bidi-reordered.
6515 (set_iterator_to_next): Support bidi reordering of C strings and
6516 Lisp strings.
6517 (next_element_from_string): Support bidi reordering of Lisp
6518 strings.
6519 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6520 (display_string): Support display of R2L glyph rows.
6521 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6522 (init_iterator): Don't initialize it->bidi_p for strings
6523 here.
6524 (reseat_to_string): Initialize it->bidi_p for strings here.
6525 (next_element_from_string, next_element_from_c_string)
6526 (next_element_from_buffer): Add xassert's for correspondence
6527 between IT's object being iterated and it->bidi_it.string
6528 structure.
6529 (face_before_or_after_it_pos): Support bidi iteration.
6530 (next_element_from_c_string): Handle the case of the first string
6531 character that is not the first one in the visual order.
6532 (get_visually_first_element): New function, refactored from common
6533 parts of next_element_from_buffer, next_element_from_string, and
6534 next_element_from_c_string.
6535 (tool_bar_lines_needed, redisplay_tool_bar)
6536 (display_menu_bar): Force left-to-right direction. Add a FIXME
6537 comment for making that be controlled by a user option.
6538 (push_it, pop_it): Save and restore the state of the
6539 bidi iterator. Save and restore the bidi_p flag.
6540 (pop_it): Iterate out of display property for string iteration as
6541 well.
6542 (iterate_out_of_display_property): Support iteration over strings.
6543 (handle_single_display_spec): Set up it->bidi_it for iteration
6544 over a display string, and call bidi_init_it.
6545 (handle_single_display_spec, next_overlay_string)
6546 (get_overlay_strings_1, push_display_prop): Set up the bidi
6547 iterator for displaying display or overlay strings.
6548 (forward_to_next_line_start): Don't use the shortcut if
6549 bidi-iterating.
6550 (back_to_previous_visible_line_start): If handle_display_prop
6551 pushed the iterator stack, restore the internal state of the bidi
6552 iterator by calling bidi_pop_it same number of times.
6553 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6554 and we are bidi-iterating, don't decrement the iterator position;
6555 instead, set the first_elt flag in the bidi iterator, to produce
6556 the same effect.
6557 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6558 (push_display_prop): xassert that we are iterating a buffer.
6559 (push_it, pop_it): Save and restore paragraph_embedding member.
6560 (handle_single_display_spec, next_overlay_string)
6561 (get_overlay_strings_1, reseat_1, reseat_to_string)
6562 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6563 correctly. Don't assume unibyte strings are not bidi-reordered.
6564 (compute_display_string_pos)
6565 (compute_display_string_end): Fix handling the case of C string.
6566 (push_it, pop_it): Save and restore from_disp_prop_p.
6567 (handle_single_display_spec, push_display_prop): Set the
6568 from_disp_prop_p flag.
6569 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6570 (pop_it): Call iterate_out_of_display_property only if we are
6571 popping after iteration over a string that came from a display
6572 property. Fix a typo in popping stretch info. Add an assertion
6573 for verifying that the iterator position is in sync with the bidi
6574 iterator.
6575 (handle_single_display_spec, get_overlay_strings_1)
6576 (push_display_prop): Fix initialization of paragraph direction for
6577 string when that of the parent object is not yet determined.
6578 (reseat_1): Call bidi_init_it to resync the bidi
6579 iterator with IT's position. (Bug#7616)
6580 (find_row_edges): If ROW->start.pos gives position
6581 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6582 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6583 Reset the from_disp_prop_p flag.
6584 (SAVE_IT, RESTORE_IT): New macros.
6585 (pos_visible_p, face_before_or_after_it_pos)
6586 (back_to_previous_visible_line_start)
6587 (move_it_in_display_line_to, move_it_in_display_line)
6588 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6589 (try_scrolling, redisplay_window, display_line): Use them when
6590 saving a temporary copy of the iterator and restoring it back.
6591 (back_to_previous_visible_line_start, reseat_1)
6592 (init_iterator): Empty the bidi cache "stack".
6593 (move_it_in_display_line_to): If iterator ended up at
6594 EOL, but we never saw any buffer positions smaller than
6595 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6596 motion in bidi-reordered lines.
6597 (move_it_in_display_line_to): Record prev_method and prev_pos
6598 immediately before the call to set_iterator_to_next. Fixes cursor
6599 motion in bidi-reordered lines with stretch glyphs and strings
6600 displayed in margins. (Bug#8133) (Bug#8867)
6601 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6602 TO_CHARPOS.
640c8776
SM
6603 (pos_visible_p): Support positions in bidi-reordered lines.
6604 Save and restore bidi cache.
0bb23927
EZ
6605
6606 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6607 (bidi_paragraph_info): Delete unused struct.
6608 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6609 (bidi_cache_start): New variable.
6610 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6611 to zero.
6612 (bidi_cache_fetch_state, bidi_cache_search)
6613 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6614 (bidi_cache_find, bidi_peek_at_next_level)
6615 (bidi_level_of_next_char, bidi_find_other_level_edge)
6616 (bidi_move_to_visually_next): Compare cache index with
6617 bidi_cache_start rather than with zero.
6618 (bidi_fetch_char): Accept new argument STRING; all callers
6619 changed. Support iteration over a string. Support strings with
6620 display properties. Support unibyte strings. Fix the type of
6621 `len' according to what STRING_CHAR_AND_LENGTH expects.
6622 (bidi_paragraph_init, bidi_resolve_explicit_1)
6623 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6624 (bidi_level_of_next_char, bidi_move_to_visually_next):
6625 Support iteration over a string.
0bb23927
EZ
6626 (bidi_set_sor_type, bidi_resolve_explicit_1)
6627 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6628 can now be zero (for strings); special values 0 and -1 were
6629 changed to -1 and -2, respectively.
6630 (bidi_char_at_pos): New function.
6631 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6632 Call it instead of FETCH_MULTIBYTE_CHAR.
6633 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6634 initialized to valid values.
6635 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6636 values.
6637 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6638 the test for valid cached positions. Fix the logic for looking up
6639 the sentinel state in the cache. GCPRO the Lisp string we are
6640 iterating.
6641 (bidi_push_it, bidi_pop_it): New functions.
6642 (bidi_initialize): Initialize the bidi cache start stack pointer.
6643 (bidi_cache_ensure_space): New function, refactored from part of
6644 bidi_cache_iterator_state. Don't assume the required size is just
6645 one BIDI_CACHE_CHUNK away.
6646 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6647 (bidi_count_bytes, bidi_char_at_pos): New functions.
6648 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6649 always valid if bidi_cache_idx is valid.
6650 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6651 is valid if it's going to be used.
6652 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6653 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6654 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6655 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6656 (bidi_find_other_level_edge, bidi_cache_start_stack):
6657 All variables related to cache indices are now EMACS_INT.
c965adc5 6658
0bb23927
EZ
6659 * dispextern.h (struct bidi_string_data): New structure.
6660 (struct bidi_it): New member `string'. Make flag members be 1-bit
6661 fields, and put them last in the struct.
640c8776
SM
6662 (compute_display_string_pos, compute_display_string_end):
6663 Update prototypes.
0bb23927
EZ
6664 (bidi_push_it, bidi_pop_it): Add prototypes.
6665 (struct iterator_stack_entry): New members bidi_p,
6666 paragraph_embedding, and from_disp_prop_p.
6667 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6668 (bidi_shelve_cache, bidi_unshelve_cache):
6669 Declare prototypes.
0bb23927
EZ
6670
6671 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6672 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6673 and vector-like objects.
6674
6675 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6676 cache around display iteration.
6677
6678 * window.c (Fwindow_end, window_scroll_pixel_based)
6679 (displayed_window_lines, Frecenter): Save and restore the bidi
6680 cache around display iteration.
6681
3bbd2265
LMI
66822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6683
6684 * editfns.c (Fdelete_region): Clarify the use of the named
6685 parameters (bug#6788).
6686
adc47434
MR
66872011-07-14 Martin Rudalics <rudalics@gmx.at>
6688
6689 * indent.c (Fvertical_motion): Set and restore w->pointm when
6690 saving and restoring the window's buffer (Bug#9006).
6691
837c31f8
LMI
66922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6693
6694 * editfns.c (Fstring_to_char): Clarify just what is returned
6695 (bug#6576). Text by Eli Zaretskii.
6696
ac389d0c
JB
66972011-07-13 Juanma Barranquero <lekktu@gmail.com>
6698
6699 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6700
0be0ce47
EZ
67012011-07-13 Eli Zaretskii <eliz@gnu.org>
6702
6703 * buffer.c (mmap_find): Fix a typo.
6704
cd18e7e3
JB
67052011-07-13 Johan Bockgård <bojohan@gnu.org>
6706
6707 Fix execution of x selection hooks.
6708 * xselect.c (Qx_lost_selection_functions)
6709 (Qx_sent_selection_functions): New vars.
6710 (syms_of_xselect): DEFSYM them.
6711 (x_handle_selection_request): Pass Qx_sent_selection_functions
6712 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6713 (x_handle_selection_clear,x_clear_frame_selections):
6714 Pass Qx_lost_selection_functions rather than
6715 Vx_lost_selection_functions to Frun_hook_with_args.
6716
47ea7f44
PE
67172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6718
ac389d0c 6719 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6720 The old code sometimes used this field without initializing it.
6721
47ea7f44
PE
6722 * alloc.c (gc_sweep): Don't read past end of array.
6723 In theory, the old code could also have corrupted Emacs internals,
6724 though it'd be very unlikely.
6725
bc985c87
AS
67262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6727
6728 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6729 argument. (Bug#4026)
bc985c87 6730
0cf34688
LMI
67312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6732
b3dadd76
LMI
6733 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6734 key" (bug#4257).
6735
0cf34688
LMI
6736 * window.c (Fset_window_start): Doc fix (bug#4199).
6737 (Fset_window_hscroll): Ditto.
6738
270768cd
PE
67392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6740
077e3dda 6741 Fix minor new problems caught by GCC 4.6.1.
270768cd 6742 * term.c (init_tty): Remove unused local.
490011a6 6743 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6744 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6745 not used otherwise.
270768cd 6746
b1f58454
CY
67472011-07-12 Chong Yidong <cyd@stupidchicken.com>
6748
6749 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6750
22b9578d
LMI
67512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6752
6e70ab07
LMI
6753 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6754 are the mini-buffer and the echo area (bug#3320).
6755
22b9578d
LMI
6756 * term.c (init_tty): Remove support for supdup, c10 and perq
6757 terminals, which are no longer supported (bug#1482).
6758
8974cc9f
JB
67592011-07-10 Johan Bockgård <bojohan@gnu.org>
6760
6761 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6762
a560d974
JD
67632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6764
6765 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6766 for non-popups (Bug#3642).
6767
1dae0f0a
AS
67682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6769
268c2c36 6770 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6771 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6772 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6773 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6774 * data.c (fmod): Likewise.
6775 * dispnew.c (swap_glyphs_in_rows): Likewise.
6776 * emacs.c (memory_warning_signal): Likewise.
6777 * floatfns.c (float_error): Likewise.
6778 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6779 (otf_open, font_otf_capability, generate_otf_features)
6780 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6781 Likewise.
6782 * image.c (pbm_read_file): Likewise.
6783 * indent.c (string_display_width): Likewise.
6784 * intervals.c (check_for_interval, search_for_interval)
6785 (inc_interval_count, count_intervals, root_interval)
6786 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6787 * lread.c (defalias): Likewise.
268c2c36 6788 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6789 * regex.c (set_image_of_range_1, set_image_of_range)
6790 (regex_grow_registers): Likewise.
6791 * sysdep.c (strerror): Likewise.
6792 * termcap.c (valid_filename_p, tprint, main): Likewise.
6793 * tparam.c (main): Likewise.
6794 * unexhp9k800.c (run_time_remap, save_data_space)
6795 (update_file_ptrs, read_header, write_header, calculate_checksum)
6796 (copy_file, copy_rest, display_header): Likewise.
6797 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6798 Likewise.
6799 * xdisp.c (check_it): Likewise.
6800 * xfaces.c (register_color, unregister_color, unregister_colors):
6801 Likewise.
6802 * xfns.c (print_fontset_result): Likewise.
6803 * xrdb.c (member, fatal, main): Likewise.
6804
99033785
PE
68052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6806
6807 Fix minor problems found by static checking (Bug#9031).
6808 * chartab.c (char_table_set_range, map_sub_char_table):
6809 Remove unused locals.
6810 (uniprop_table): Now static.
6811 * composite.c (_work_char): Remove unused static var.
6812
9cb2ac56
JB
68132011-07-09 Juanma Barranquero <lekktu@gmail.com>
6814
6815 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6816
f25661f0
JD
68172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6818
6819 * gtkutil.c (qttip_cb): Remove code without function.
6820
8278c4fe
EZ
68212011-07-09 Eli Zaretskii <eliz@gnu.org>
6822
6823 * w32.c (pthread_sigmask): New stub.
6824
1692ae2d 68252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6826
8a6ebd58 6827 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6828 sigprocmask is portable only for single-threaded applications, and
6829 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6830 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6831 (LIBES): Use it.
6832 * callproc.c (Fcall_process):
6833 * process.c (create_process):
6834 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6835 Use pthread_sigmask, not sigprocmask.
123403e4 6836
1b854618
JD
68372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6838
6839 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6840 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6841 wrong (Bug#8591).
6842
3fe4b549
JD
68432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6844
0ce7e563
JD
6845 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6846 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6847 (xg_hide_tooltip): Fix comment.
6848
3fe4b549
JD
6849 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6850 in registerServicesMenuSendTypes.
6851 (validRequestorForSendType): Don't check ns_return_types.
6852
6853 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6854 ns_return_type.
6855
5df75e47
JR
68562011-07-08 Jason Rumney <jasonr@gnu.org>
6857
22610910
JR
6858 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6859 SH_SHOW for hidden windows (Bug#5482).
6860
5df75e47
JR
6861 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6862 frame struct members of non-existent frames (Bug#6284).
6863
699c10bd
JD
68642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6865
4393663b
JD
6866 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6867 variable firstTime not needed on OSX >= 10.6.
6868 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6869 >= 10.5. Use setKnobProportion, setDoubleValue.
6870
6871 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6872 (MAC_OS_X_VERSION_10_5): Define if not defined.
6873 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6874 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6875 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6876
6877 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6878 cString and lossyCString on OSX >= 10.4
6879
58179cce 6880 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6881 sizeToFit on OSX >= 10.2.
6882
6883 * nsimage.m (allocInitFromFile): Don't use deprecated method
6884 bestRepresentationForDevice on OSX >= 10.6.
6885
6886 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6887 to avoid warning.
6888
6889 * emacs.c: Declare unexec_init_emacs_zone.
6890
a63e0781
JD
6891 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6892
699c10bd
JD
6893 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6894
6895 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6896 on svcsMenu (Bug#8842).
6897
6898 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6899 ns_return_types.
6900 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6901
6902 * nsterm.m (QUTF8_STRING): Declare.
6903 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6904 (validRequestorForSendType): Return type is (id).
6905 Change indexOfObjectIdenticalTo to indexOfObject.
6906 Check if we have local selection before returning self (Bug#8842).
6907 (writeSelectionToPasteboard): Put local selection into paste board
6908 if we have a local selection (Bug#8842).
6909 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6910
6911 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6912 (ns_get_local_selection): Declare.
6913
54e10184
LMI
69142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6915
9888ff71
LMI
6916 * keymap.c (describe_map_tree): Don't insert a double newline at
6917 the end of the buffer (bug#1169) and return whether we inserted
6918 something.
6919
54e10184
LMI
6920 * callint.c (Fcall_interactively): Change "reading args" to
6921 "providing args" to try to clarify what it does (bug#1010).
6922
15fa4783
KH
69232011-07-07 Kenichi Handa <handa@m17n.org>
6924
6925 * composite.c (composition_compute_stop_pos): Ignore a static
6926 composition starting before CHARPOS (Bug#8915).
6927
6928 * xdisp.c (handle_composition_prop): Likewise.
6929
a8815b00
EZ
69302011-07-07 Eli Zaretskii <eliz@gnu.org>
6931
6932 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6933 (Bug#9015)
6934
ef7b981d 69352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6936
6937 * character.h (unicode_category_t): New enum type.
6938
6939 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6940 (Qchar_code_property_table): New variable.
6941 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6942 (UNIPROP_COMPRESSED_FORM_P): New macros.
6943 (char_table_ascii): Uncompress the compressed values.
6944 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6945 Uncompress the compressed values.
ac389d0c 6946 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6947 (char_table_ref_and_range): Uncompress the compressed values.
6948 (sub_char_table_set): New arg is_uniprop. Callers changed.
6949 Uncompress the compressed values.
6950 (sub_char_table_set_range): Args changed. Callers changed.
6951 (char_table_set_range): Adjuted for the above change.
6952 (map_sub_char_table): Delete args default_val and parent. Add arg
6953 top. Give decoded values to a Lisp function.
640c8776 6954 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6955 values to a Lisp function. Gcpro more variables.
6956 (uniprop_table_uncompress)
6957 (uniprop_decode_value_run_length): New functions.
6958 (uniprop_decoder, uniprop_decoder_count): New variables.
6959 (uniprop_get_decoder, uniprop_encode_value_character)
6960 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6961 New functions.
6962 (uniprop_encoder, uniprop_encoder_count): New variables.
6963 (uniprop_get_encoder, uniprop_table)
6964 (Funicode_property_table_internal, Fget_unicode_property_internal)
6965 (Fput_unicode_property_internal): New functions.
6966 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6967 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6968 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6969 char-code-property-alist.
6970
640c8776 6971 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6972 Vunicode_category_table.
6973
640c8776 6974 * font.c (font_range): Adjust for the change of
c805dec0
KH
6975 Vunicode_category_table.
6976
76b397fb
DN
69772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6978
6979 * m/iris4d.h: Remove file, move contents ...
6980 * s/irix6-5.h: ... here.
6981
22b4128e
PE
69822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6983
6984 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6985 * alloc.c (mark_buffer):
6986 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6987 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6988 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6989 This isn't true in general, and it's particularly not true
6990 if Emacs is configured with --with-wide-int.
6991 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6992 New macros, used in the buffer.c change.
6993
869795d6
JD
69942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6995
6996 * xsettings.c: Use both GConf and GSettings if both are available.
6997 (store_config_changed_event): Add comment.
6998 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6999 (store_tool_bar_style_changed): New functions.
5e617bc2 7000 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7001 (struct xsettings): Move font inside HAVE_XFT.
7002 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7003 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7004 Move inside HAVE_XFT.
640c8776 7005 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7006 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7007 also.
7008 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7009 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7010 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7011 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7012 (parse_settings): Move check for font inside HAVE_XFT.
7013 (read_settings, apply_xft_settings): Add comment.
7014 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7015 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7016 call store_font_name_changed.
7017 (xft_settings_event): Add comment.
7018 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7019 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7020 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7021 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7022 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7023 (xsettings_get_system_font, xsettings_get_system_normal_font):
7024 Add comment.
869795d6 7025
d8ed26bd
PE
70262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7027
7028 Random fixes. E.g., (random) never returned negative values.
7029 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7030 subseconds part to the entropy, as that's a bit more random.
7031 Prefer signed to unsigned, since the signedness doesn't matter and
7032 in general we prefer signed. When given a limit, use a
7033 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7034 latter isn't right if USE_2_TAGS_FOR_INTS.
7035 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7036 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7037
cabf1cac
SM
70382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7039
7040 * textprop.c (text_property_stickiness):
7041 Obey Vtext_property_default_nonsticky.
7042 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7043 * w32fns.c (syms_of_w32fns):
7044 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7045
6e9b2be9
PE
70462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7047
7048 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7049 This is more efficient than Ffile_directory_p and avoids a minor race.
7050
90186c68
LMI
70512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7052
7c301272
LMI
7053 * buffer.c (Foverlay_put): Say what the return value is
7054 (bug#7835).
7055
c4f2d8d4
LMI
7056 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7057 is a directory before asking whether to use the file name
7058 (bug#7564).
ad637907
LMI
7059 (barf_or_query_if_file_exists): Make the "File is a directory"
7060 error be more correct.
c4f2d8d4 7061
90186c68
LMI
7062 * fns.c (Frequire): Remove the mention of the .gz files, since
7063 that's installation-specific, but keep the mention of
7064 `get-load-suffixes'.
7065
da64016e
PE
70662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7067
7068 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7069 Report string overflow if the output is too long.
7070
7d47b580
JB
70712011-07-04 Juanma Barranquero <lekktu@gmail.com>
7072
a555cb87
JB
7073 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7074 (syms_of_gnutls): Remove duplicate DEFSYM for
7075 Qgnutls_bootprop_verify_hostname_error, an error for
7076 Qgnutls_bootprop_verify_error (which is no longer used).
7077
7d47b580
JB
7078 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7079 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7080 Also (re)move comments that are misplaced or no longer relevant.
7081
1e49bfab
LMI
70822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7083
7084 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7085
1485f4c0
CY
70862011-07-03 Chong Yidong <cyd@stupidchicken.com>
7087
7088 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7089 and background color parameters if they have been changed.
7090
a9ab721e
LMI
70912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7092
7093 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7094
cf7cff57
PE
70952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7096
2e13213d
PE
7097 * xsettings.c (SYSTEM_FONT): Define only when used.
7098 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7099
cf7cff57
PE
7100 * keymap.c (access_keymap_1): Now static.
7101
7a8e04f7
CY
71022011-07-02 Chong Yidong <cyd@stupidchicken.com>
7103
7104 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7105 leave any prefix arg for the up event (Bug#1586).
7106
61352f62
LMI
71072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7108
69bb1ef7
LMI
7109 * lread.c (syms_of_lread): Mention single symbols defined by
7110 `defvar' or `defconst' (bug#7154).
7111
61352f62 7112 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7113 (Frequire): Mention get-load-suffixes.
61352f62 7114
28545e04
MR
71152011-07-02 Martin Rudalics <rudalics@gmx.at>
7116
7117 * window.h (window): Remove clone_number slot.
7118 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7119 Remove.
7120 (make_parent_window, make_window, saved_window)
7121 (Fset_window_configuration, save_window_save): Don't deal with
7122 clone numbers.
7123 * buffer.c (Qclone_number): Remove declaration.
7124 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7125
3349e122
SM
71262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7127
7128 Add multiple inheritance to keymaps.
7129 * keymap.c (Fmake_composed_keymap): New function.
7130 (Fset_keymap_parent): Simplify.
7131 (fix_submap_inheritance): Remove.
7132 (access_keymap_1): New function extracted from access_keymap to handle
7133 embedded parents and handle lists of maps.
7134 (access_keymap): Use it.
7135 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7136 (Fcopy_keymap): Handle embedded parents.
7137 (Fcommand_remapping, define_as_prefix): Simplify.
7138 (Fkey_binding): Simplify.
7139 (syms_of_keymap): Move minibuffer-local-completion-map,
7140 minibuffer-local-filename-completion-map,
7141 minibuffer-local-must-match-map, and
7142 minibuffer-local-filename-must-match-map to Elisp.
7143 (syms_of_keymap): Defsubr make-composed-keymap.
7144 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7145 (parse_menu_item): Trivial simplification.
7146
3279eb87
GM
71472011-07-01 Glenn Morris <rgm@gnu.org>
7148
7149 * Makefile.in (SETTINGS_LIBS): Fix typo.
7150
4550efdf
KI
71512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7152
7153 * coding.c (Fencode_coding_string): Record the last coding system
7154 used, as the function doc string says (bug#8738).
7155
0949d2b6
JD
71562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7157
7158 * xsettings.c (store_monospaced_changed): Take new font as arg and
7159 check for change against current_mono_font.
7160 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7161 (emacs_settings_constructor, emacs_settings_get_property)
7162 (emacs_settings_set_property, emacs_settings_class_init)
7163 (emacs_settings_init, gsettings_obj): Remove.
7164 (something_changedCB): New function for HAVE_GSETTINGS.
7165 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7166 with value as argument.
7167 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7168 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7169 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7170 "changed".
7171
7172 * xgselect.c: Add defined (HAVE_GSETTINGS).
7173 (xgselect_initialize): Ditto.
7174
7175 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7176 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7177 xg_select.
7178
bbc6b304
PE
71792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7180
7181 * eval.c (struct backtrace): Simplify and port the data structure.
7182 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7183 signed bit field, as this assumption is not portable and it makes
7184 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7185 "char debug_on_exit : 1" as this is not portable either; instead,
7186 use the portable "unsigned int debug_on_exit : 1". Remove unused
7187 member evalargs. Remove obsolete comments about cc bombing out.
7188
9851bfc5
JD
71892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7190
51bb811f 7191 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7192 Let HAVE_GSETTINGS override HAVE_GCONF.
7193 (store_monospaced_changed): New function.
7194 (EMACS_SETTINGS): A new type derived from GObject to handle
7195 GSettings notifications.
7196 (emacs_settings_constructor, emacs_settings_get_property)
7197 (emacs_settings_set_property, emacs_settings_class_init):
7198 New functions.
7199 (gsettings_client, gsettings_obj): New variables.
7200 (GSETTINGS_SCHEMA): New define.
7201 (something_changedCB): Call store_monospaced_changed.
7202 (init_gsettings): New function.
7203 (xsettings_initialize): Call init_gsettings.
7204 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7205 to NULL.
7206
640c8776 7207 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7208 GCONF_CFLAGS/LIBS.
7209
5386012d
MR
72102011-06-29 Martin Rudalics <rudalics@gmx.at>
7211
7212 * window.c (resize_root_window, grow_mini_window)
7213 (shrink_mini_window): Rename Qresize_root_window to
7214 Qwindow_resize_root_window and Qresize_root_window_vertically to
7215 Qwindow_resize_root_window_vertically.
7216
f13e0b08
PE
72172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7218
7219 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7220
94515237
JB
72212011-06-27 Juanma Barranquero <lekktu@gmail.com>
7222
7223 * makefile.w32-in: Redesign dependencies so they reflect more
7224 clearly which files are directly included by each source file,
7225 and not through other includes.
7226
e43b6e43
MR
72272011-06-27 Martin Rudalics <rudalics@gmx.at>
7228
7229 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7230 (sort_overlays, overlay_strings): When an overlay's clone number
7231 matches the window's clone number process the overlay even if
7232 the overlay's window property doesn't match the current window.
7233
d68443dc
MR
7234 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7235 (Fwindow_hchild): Rename to Fwindow_left_child.
7236 (Fwindow_next): Rename to Fwindow_next_sibling.
7237 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7238 (resize_window_check): Rename to window_resize_check.
7239 (resize_window_apply): Rename to window_resize_apply.
7240 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7241 (Fdelete_other_windows_internal, resize_frame_windows)
7242 (Fsplit_window_internal, Fdelete_window_internal)
7243 (grow_mini_window, shrink_mini_window)
7244 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7245
c7e73be5
JD
72462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7247
7248 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7249 (emacs_fixed_set_min_size): Remove.
7250 (emacs_fixed_new): Take frame as argument.
7251
7252 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7253 (_EmacsFixedPrivate): Remove minwidth/height.
7254 Add struct frame *f.
7255 (emacs_fixed_init): Initialize priv->f.
7256 (get_parent_class, emacs_fixed_set_min_size): Remove.
7257 (emacs_fixed_new): Set priv->f to argument.
7258 (emacs_fixed_get_preferred_width)
7259 (emacs_fixed_get_preferred_height): Use min_width/height from
7260 frames size_hint to set minimum and natural (Bug#8919).
7261 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7262 and use min_width/height from frames size_hint to set
7263 min_width/height (Bug#8919).
7264
7265 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7266 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7267 Fix indentation.
c7e73be5 7268
cf99dcf8
EZ
72692011-06-26 Eli Zaretskii <eliz@gnu.org>
7270
7271 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7272 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7273 called at ZV.
7274
029529ac
CY
72752011-06-26 Chong Yidong <cyd@stupidchicken.com>
7276
7277 * process.c (wait_reading_process_output): Bypass select if
7278 waiting for a cell while ignoring keyboard input, and input is
7279 pending. Suggested by Jan Djärv (Bug#8869).
7280
7a7ef429
PE
72812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7282
7283 Use gnulib's dup2 module instead of rolling our own.
7284 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7285
11fdef7d 72862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7287
7288 * dispnew.c (scrolling_window): Before scrolling, turn off a
7289 mouse-highlight in the window being scrolled.
7290
cd3520a4
JB
72912011-06-24 Juanma Barranquero <lekktu@gmail.com>
7292
7293 Move DEFSYM to lisp.h and use everywhere.
7294
7295 * character.h (DEFSYM): Move declaration...
7296 * lisp.h (DEFSYM): ...here.
7297
7298 * gnutls.c:
7299 * minibuf.c:
7300 * w32menu.c:
7301 * w32proc.c:
7302 * w32select.c: Don't include character.h.
7303
7304 * alloc.c (syms_of_alloc):
7305 * buffer.c (syms_of_buffer):
7306 * bytecode.c (syms_of_bytecode):
7307 * callint.c (syms_of_callint):
7308 * casefiddle.c (syms_of_casefiddle):
7309 * casetab.c (init_casetab_once):
7310 * category.c (init_category_once, syms_of_category):
7311 * ccl.c (syms_of_ccl):
7312 * cmds.c (syms_of_cmds):
7313 * composite.c (syms_of_composite):
7314 * dbusbind.c (syms_of_dbusbind):
7315 * dired.c (syms_of_dired):
7316 * dispnew.c (syms_of_display):
7317 * doc.c (syms_of_doc):
7318 * editfns.c (syms_of_editfns):
7319 * emacs.c (syms_of_emacs):
7320 * eval.c (syms_of_eval):
7321 * fileio.c (syms_of_fileio):
7322 * fns.c (syms_of_fns):
7323 * frame.c (syms_of_frame):
7324 * fringe.c (syms_of_fringe):
7325 * insdel.c (syms_of_insdel):
7326 * keymap.c (syms_of_keymap):
7327 * lread.c (init_obarray, syms_of_lread):
7328 * macros.c (syms_of_macros):
7329 * msdos.c (syms_of_msdos):
7330 * print.c (syms_of_print):
7331 * process.c (syms_of_process):
7332 * search.c (syms_of_search):
7333 * sound.c (syms_of_sound):
7334 * syntax.c (init_syntax_once, syms_of_syntax):
7335 * terminal.c (syms_of_terminal):
7336 * textprop.c (syms_of_textprop):
7337 * undo.c (syms_of_undo):
7338 * w32.c (globals_of_w32):
7339 * window.c (syms_of_window):
7340 * xdisp.c (syms_of_xdisp):
7341 * xfaces.c (syms_of_xfaces):
7342 * xfns.c (syms_of_xfns):
7343 * xmenu.c (syms_of_xmenu):
7344 * xsettings.c (syms_of_xsettings):
7345 * xterm.c (syms_of_xterm): Use DEFSYM.
7346
4228cf16
TZ
73472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7348
cd3520a4 7349 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7350
7fcccf1e
PE
73512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7352
7efb4e0e
PE
7353 Integer and buffer overflow fixes (Bug#8873).
7354
ff5844ad
PE
7355 * print.c (printchar, strout): Check for string overflow.
7356 (PRINTPREPARE, printchar, strout):
7357 Don't set size unless allocation succeeds.
7358
90532f02
PE
7359 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7360 for sizes. Check for string overflow more accurately.
7361 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7362
6d84508d
PE
7363 * macros.c: Integer and buffer overflow fixes.
7364 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7365 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7366 Use ptrdiff_t, not int, for sizes.
7367 Don't increment bufsize until after realloc succeeds.
7368 Check for size-calculation overflow.
7369 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7370
437b2cb4
PE
7371 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7372
8b9ac8b4
PE
7373 * lread.c: Integer overflow fixes.
7374 (read_integer): Radix is now EMACS_INT, not int,
7375 to improve quality of diagnostics for out-of-range radices.
7376 Calculate buffer size correctly for out-of-range radices.
7377 (read1): Check for integer overflow in radices, and in
7378 read-circle numbers.
82cb60d3
PE
7379 (read_escape): Avoid int overflow.
7380 (Fload, openp, read_buffer_size, read1)
7381 (substitute_object_recurse, read_vector, read_list, map_obarray):
7382 Use ptrdiff_t, not int, for sizes.
7383 (read1): Use EMACS_INT, not int, for sizes.
20270765 7384 Check for size overflow.
8b9ac8b4 7385
7fcccf1e
PE
7386 * image.c (cache_image): Check for size arithmetic overflow.
7387
bfbbd7e7
PE
7388 * lread.c: Integer overflow issues.
7389 (saved_doc_string_size, saved_doc_string_length)
7390 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7391 Now ptrdiff_t, not int.
7392 (read1): Don't assume doc string length fits in int. Check for
7393 out-of-range doc string lengths.
7394 (read_list): Don't assume file position fits in int.
39019e54 7395 (read_escape): Check for hex character overflow.
bfbbd7e7 7396
4e323265
LL
73972011-06-22 Leo Liu <sdl.web@gmail.com>
7398
7399 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7400 Move to minibuffer.el.
7401
85fece3e
PE
74022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7403
20b84ce9 7404 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7405 The following patches are for when GLYPH_DEBUG && !XASSERT.
7406 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7407 * dispnew.c (flush_stdout):
7408 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7409 Mark as externally visible.
7410 * dispnew.c (check_window_matrix_pointers): Now static.
7411 * dispnew.c (window_to_frame_vpos):
7412 * xfns.c (unwind_create_frame):
7413 * xterm.c (x_check_font): Remove unused local.
7414 * scroll.c (CHECK_BOUNDS):
7415 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7416 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7417 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7418 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7419 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7420 Now static.
7421 (debug_method_add): Use va_list and vsprintf rather than relying
7422 on undefined behavior with wrong number of arguments.
7423 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7424 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7425 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7426 since we're not interested in debugging glyphs with old libraries.
7427 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7428 GCC 4.6.0's static checking.
7429
0766b489
PE
74302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7431
31fd4b32
PE
7432 Integer overflow and signedness fixes (Bug#8873).
7433 A few related buffer overrun fixes, too.
7434
b79e8648
PE
7435 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7436
0766b489
PE
7437 * dispextern.h (struct face.stipple):
7438 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7439 (x_bitmap_mask, x_allocate_bitmap_record)
7440 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7441 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7442 (x_create_bitmap_from_xpm_data):
7443 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7444 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7445 (.bitmaps_last):
7446 * xfaces.c (load_pixmap):
7447 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7448 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7449 (.bitmaps_last, struct x_output.icon_bitmap):
7450 Use ptrdiff_t, not int, for bitmap indexes.
7451 (x_allocate_bitmap_record): Check for size overflow.
7452 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7453
b081724f
PE
7454 Use ptrdiff_t, not int, for overlay counts.
7455 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7456 * editfns.c (overlays_around, get_pos_property):
7457 * textprop.c (get_char_property_and_overlay):
7458 * xdisp.c (next_overlay_change, note_mouse_highlight):
7459 * xfaces.c (face_at_buffer_position):
21514da7
PE
7460 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7461 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7462 (Fnext_overlay_change, Fprevious_overlay_change)
7463 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7464 Use ptrdiff_t, not int, for sizes.
21514da7 7465 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7466
3de73e5e
PE
7467 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7468
2606c57b
PE
7469 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7470 (x_session_initialize): Do not assume string length fits in int.
7471
aaafe47a
PE
7472 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7473 This is unlikely, but can occur if DPI is outlandish.
7474
2674ddc8 7475 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7476 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7477
28154962
PE
7478 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7479 * xrdb.c (magic_file_p, search_magic_path):
7480 Omit last arg SUFFIX; it was always 0. All callers changed.
7481 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7482
7de51af5
PE
7483 * xfont.c (xfont_match): Avoid need for strlen.
7484
25ed6cc3
PE
7485 * xfns.c: Don't assume strlen fits in int.
7486 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7487
4eab31dd
PE
7488 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7489 not unsigned long, as we prefer signed integers. All callers changed.
7490 Detect integer overflow in repeat count.
7491 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7492 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7493
171e2a58
PE
7494 * termcap.c: Don't assume sizes fit in int and never overflow.
7495 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7496 (gobble_line): Check for size-calculation overflow.
7497
ad39faca 7498 * minibuf.c (Fread_buffer):
6e5bb2dc 7499 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7500 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7501 Don't assume string length fits in int.
7502
52c61c22 7503 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7504 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7505
b5b8c9e5
PE
7506 * font.c: Don't assume string length fits in int.
7507 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7508 Use ptrdiff_t, not int.
ccd6111c
PE
7509 (font_intern_prop): Don't assume string length fits in int.
7510 Don't assume integer property fits in fixnum.
7511 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7512
882f0d81 7513 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7514 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7515 Reformulate so as not to need the command string.
7516 Invoke gzip -cd rather than gunzip, as it's more portable.
7517 (lock_info_type, lock_file_1, lock_file):
7518 Don't assume pid_t and time_t fit in unsigned long.
7519 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7520 (current_lock_owner): Prefer signed type for sizes.
7521 Use memcpy, not strncpy, where memcpy is what is really wanted.
7522 Don't assume (via atoi) that time_t and pid_t fit in int.
7523 Check for time_t and/or pid_t out of range, e.g., via a network share.
7524 Don't alloca where an auto var works fine.
7525
93f4cf88
PE
7526 * fileio.c: Fix some integer overflow issues.
7527 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7528 Don't assume string length fits in int.
7529 (directory_file_name): Don't assume string length fits in long.
7530 (make_temp_name): Don't assume pid fits in int, or that its print
7531 length is less than 20.
7532
f3e92b69
PE
7533 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7534
1bfdaf10
PE
7535 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7536
35016e9a
PE
7537 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7538
3d1e65a1
PE
7539 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7540 We prefer signed integers, even for size calculations.
7541
0b963a93
PE
7542 * emacs.c: Don't assume string length fits in 'int'.
7543 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7544 (main): Don't invoke strlen when not needed.
7545
573f4b54
PE
7546 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7547 (XD_DEBUG_MESSAGE): Don't waste a byte.
7548
989f33ba
PE
7549 * callproc.c (getenv_internal_1, getenv_internal)
7550 (Fgetenv_internal):
965d34eb
PE
7551 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7552
e4d29b33
PE
7553 * lread.c (invalid_syntax): Omit length argument.
7554 All uses changed. This doesn't fix a bug, but it simplifies the
7555 code away from its former Hollerith-constant appearance, and it's
7556 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7557 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7558
eb49b136
PE
7559 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7560 This didn't break anything, but it didn't help either.
7561 It's confusing to put a bogus integer in a place where the actual
7562 value does not matter.
9f62aeb1 7563 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7564 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7565
15375a22
PE
7566 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7567 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7568 implementation.
b61cc01c
PE
7569 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7570 We prefer signed types, and the value cannot exceed the EMACS_INT
7571 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7572 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7573 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7574 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7575
53b2623d
PE
7576 * indent.c (sane_tab_width): New function.
7577 (current_column, scan_for_column, Findent_to, position_indentation)
7578 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7579 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7580
51cab52b 7581 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7582
f2ed8a70
PE
7583 * lisp.h (lint_assume): New macro.
7584 * composite.c (composition_gstring_put_cache):
7585 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7586
abe80cc6
PE
7587 * editfns.c, insdel.c:
7588 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7589
b02c740e
PE
7590 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7591
ebc96716
PE
7592 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7593
b4e50fa0 7594 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7595 Use much-faster test for byte-length change.
311d5d7c 7596 Don't assume string byte-length fits in 'int'.
a4cf38e4 7597 Check that character arg fits in 'int'.
85461888 7598 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7599
c0c1ee9f
PE
7600 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7601
a498d7f4
PE
7602 * fns.c (concat): Catch string overflow earlier.
7603 Do not rely on integer wraparound.
7604
51cab52b
PE
7605 * dispextern.h (struct it.overlay_strings_charpos)
7606 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7607 * xdisp.c (forward_to_next_line_start)
7608 (back_to_previous_visible_line_start)
7609 (reseat_at_next_visible_line_start, next_element_from_buffer):
7610 Don't arbitrarily truncate the value of 'selective' to int.
7611
76031fad
PE
7612 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7613
5eb55db9
PE
7614 * composite.c: Don't truncate sizes to 'int'.
7615 (composition_gstring_p, composition_reseat_it)
7616 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7617 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7618 not EMACS_UINT, for indexes.
5eb55db9 7619
0703a717
PE
7620 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7621
d6202519
PE
7622 * buffer.c: Include <verify.h>.
7623 (struct sortvec.priority, struct sortstr.priority):
8961a454 7624 Now EMACS_INT, not int.
c20998a7 7625 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7626 (struct sortstr.size, record_overlay_string)
7627 (struct sortstrlist.size, struct sortlist.used):
7628 Don't truncate size to int.
7629 (record_overlay_string): Check for size-calculation overflow.
d6202519 7630 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7631
d5a19415
JM
76322011-06-22 Jim Meyering <meyering@redhat.com>
7633
029529ac 7634 Don't leak an XBM-image-sized buffer
d5a19415
JM
7635 * image.c (xbm_load): Free the image buffer after using it.
7636
a9041e6c
PE
76372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7638
7639 Port to Sun C.
7640 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7641 that Sun C diagnosed.
7642 * fns.c (secure_hash): Fix pointer signedness issue.
7643 * intervals.c (static_offset_intervals): New function.
7644 (offset_intervals): Use it.
7645
7f3f739f
LL
76462011-06-21 Leo Liu <sdl.web@gmail.com>
7647
7648 * deps.mk (fns.o):
7649 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7650 sha512.h.
7651
7652 * fns.c (secure_hash): Rename from crypto_hash_function and change
7653 the first arg to accept symbols.
5b66d427 7654 (Fsecure_hash): New primitive.
7f3f739f
LL
7655 (syms_of_fns): New symbols.
7656
76147d94
DD
76572011-06-20 Deniz Dogan <deniz@dogan.se>
7658
7659 * process.c (Fset_process_buffer): Clarify return value in
7660 docstring.
7661
7d7d0045
CY
76622011-06-18 Chong Yidong <cyd@stupidchicken.com>
7663
7664 * dispnew.c (add_window_display_history): Use BVAR.
7665
7666 * xdisp.c (debug_method_add): Use BVAR.
7667 (check_window_end, dump_glyph_matrix, dump_glyph)
7668 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7669
7670 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7671 Likewise.
7672
7673 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7674 check till after the cache is created in init_frame_faces.
7675
ff2bc410
SM
76762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7677
7678 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7679
28177add
PE
76802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7681
dd3482fe
PE
7682 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7683 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7684 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7685
393d71f3 7686 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7687 * fileio.c (Finsert_file_contents):
7688 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7689 Remove the old (too-loose) buffer overflow checks.
7690 They weren't needed, since make_gap checks for buffer overflow.
7691 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7692 The old code merely checked for Emacs fixnum overflow, and relied
7693 on undefined (wraparound) behavior. The new code avoids undefined
7694 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7695
2e6813b0 7696 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7697 Tune. Don't use wider integers than needed. Don't use alloca.
7698 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7699
599a9e4f
PE
7700 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7701
99561444
PE
7702 * insdel.c, lisp.h (buffer_overflow): New function.
7703 (insert_from_buffer_1, replace_range, replace_range_2):
7704 * insdel.c (make_gap_larger):
7705 * editfns.c (Finsert_char):
7706 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7707
28177add
PE
7708 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7709
e69dafad
PE
77102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7711
4baa020d 7712 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7713
b1c46f02
PE
7714 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7715 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7716
e69dafad
PE
7717 * fileio.c: Don't assume EMACS_INT fits in off_t.
7718 (emacs_lseek): New static function.
7719 (Finsert_file_contents, Fwrite_region): Use it.
7720 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7721
566684ea
PE
7722 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7723
e6966cd6
PE
7724 * fns.c: Don't overflow int when computing a list length.
7725 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7726 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7727 truncation on 64-bit hosts. Check for QUIT every
7728 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7729 faster and is responsive enough.
7730 (Flength): Report an error instead of overflowing an integer.
7731 (Fsafe_length): Return a float if the value is not representable
7732 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7733 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7734 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7735
dd0b0efb
PE
7736 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7737 (header_size, word_size): New constants.
7738 (allocate_vectorlike): Don't check size overflow here.
7739 (allocate_vector): Check it here instead, since this is the only
7740 caller of allocate_vectorlike that could cause overflow.
7741 Check that the new vector's length is representable as a fixnum.
7742
86fe5cfe
PE
7743 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7744 The previous code was bogus. For example, next_almost_prime (32)
7745 returned 39, which is undesirable as it is a multiple of 3; and
7746 next_almost_prime (24) returned 25, which is a multiple of 5 so
7747 why was the code bothering to check for multiples of 7?
7748
80e88859
PE
7749 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7750
4a2f0ad6
PE
7751 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7752
f66c7cf8
PE
7753 Variadic C functions now count arguments with ptrdiff_t.
7754 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7755 Back then I didn't know that the Emacs coding style prefers signed int.
7756 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7757 were being counted with int, which may truncate counts on 64-bit
7758 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7759 * lisp.h (struct Lisp_Subr.function.aMANY)
7760 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7761 Arg counts are now ptrdiff_t, not size_t.
7762 All variadic functions and their callers changed accordingly.
7763 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7764 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7765 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7766 * callint.c (Fcall_interactively): Check arg count for overflow,
7767 to avoid potential buffer overrun. Use signed char, not 'int',
7768 for 'varies' array, so that we needn't bother to check its size
7769 calculation for overflow.
7770 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7771 * eval.c (apply_lambda):
7772 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7773 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7774 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7775
a1759b76
PE
7776 * callint.c (Fcall_interactively): Don't use index var as event count.
7777
d96be9fc
PE
7778 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7779 * mem-limits.h (SIZE): Remove; no longer used.
7780
a690a978 7781 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7782
578c21e6
PE
7783 Remove unnecessary casts.
7784 * xterm.c (x_term_init):
7785 * xfns.c (x_set_border_pixel):
7786 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7787 These aren't needed now that we assume ANSI C.
7788
96f53c6c
PE
7789 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7790 It's more likely to cause problems (due to unsigned overflow)
7791 than to cure them.
7792
83c77d31
PE
7793 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7794
ee2079f1
PE
7795 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7796
6da65536
PE
7797 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7798
7147c4a4
PE
7799 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7800
193e32d9
PE
7801 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7802
e5533da6
PE
7803 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7804
9910e595
PE
7805 GLYPH_CODE_FACE returns EMACS_INT, not int.
7806 * dispextern.h (merge_faces):
7807 * xfaces.c (merge_faces):
01103c44
PE
7808 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7809 Don't assume EMACS_INT fits in int.
9910e595 7810
2638320e
PE
7811 * character.h (CHAR_VALID_P): Remove unused parameter.
7812 * fontset.c, lisp.h, xdisp.c: All uses changed.
7813
045eb8d9
PE
7814 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7815
c1f134b5
PE
7816 * fns.c (concat): Minor tuning based on overflow analysis.
7817 This doesn't fix any bugs. Use int to hold character, instead
7818 of constantly refetching from Emacs object. Use XFASTINT, not
7819 XINT, for value known to be a character. Don't bother comparing
7820 a single byte to 0400, as it's always less.
7821
395fcb93 7822 * floatfns.c (Fexpt):
327eeec8
PE
7823 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7824
abbd3d23
PE
7825 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7826 for characters.
7827
684a03ef
PE
7828 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7829
0fed43f3
PE
7830 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7831 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7832 incorrectly succeed when S was a string, because 4294967386 was
7833 truncated before it was used.
7834
8fd02eb7
PE
7835 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7836 Otherwise, an out-of-range integer could cause undefined behavior
7837 on a 64-bit host.
7838
f8c86b69
PE
7839 * composite.c: Use int, not EMACS_INT, for characters.
7840 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7841 EMACS_INT, for values that are known to be in character range.
7842 This doesn't fix any bugs but is the usual style inside Emacs and
7843 may generate better code on 32-bit machines.
7844
34206dd2
PE
7845 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7846 This is for reasons similar to the recent CHAR_STRING fix.
7847 * charset.c (Fencode_char): Check that character arg is actually
7848 a character. Pass an int to ENCODE_CHAR.
7849 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7850 wider than 'int', as a compile-time check to prevent future regressions
7851 in this area.
7852
c5958d4c 7853 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7854
7855 Make sure a 64-bit char is never passed to CHAR_STRING.
7856 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7857 by silently ignoring the top 32 bits, allowing some values
7858 that were far too large to be valid characters.
7859 * character.h: Include <verify.h>.
7860 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7861 arguments are no wider than unsigned, as a compile-time check
7862 to prevent future regressions in this area.
7863 * data.c (Faset):
01103c44 7864 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7865 (Fsubst_char_in_region):
7866 * fns.c (concat):
7867 * xdisp.c (decode_mode_spec_coding):
7868 Adjust to CHAR_STRING's new requirement.
7869 * editfns.c (Finsert_char, Fsubst_char_in_region):
7870 * fns.c (concat): Check that character args are actually
7871 characters. Without this test, these functions did the wrong
7872 thing with wildly out-of-range values on 64-bit hosts.
7873
d37ca623
PE
7874 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7875 These casts should not be needed on 32-bit hosts, either.
7876 * keyboard.c (read_char):
7877 * lread.c (Fload): Remove casts to unsigned.
7878
ea204efb
PE
7879 * lisp.h (UNSIGNED_CMP): New macro.
7880 This fixes comparison bugs on 64-bit hosts.
7881 (ASCII_CHAR_P): Use it.
7882 * casefiddle.c (casify_object):
01103c44 7883 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7884 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7885 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7886 * dispextern.h (FACE_FROM_ID):
7887 * keyboard.c (read_char): Use UNSIGNED_CMP.
7888
41cb286c
PE
7889 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7890 not to EMACS_INT, to avoid GCC warning.
7891
4a1b9832
PE
7892 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7893
55daad71
PE
7894 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7895 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7896 isn't needed on 32-bit machines.
8f95c75c 7897
01103c44
PE
7898 * buffer.c (Fgenerate_new_buffer_name):
7899 Use EMACS_INT for count, not int.
0ceccced 7900 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7901
7902 * data.c (Qcompiled_function): Now static.
7903
c6f072e7
PE
7904 * window.c (window_body_lines): Now static.
7905
20ce5912
PE
7906 * image.c (gif_load): Rename local to avoid shadowing.
7907
9c4c5f81
PE
7908 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7909 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7910 * alloc.c (make_save_value): Integer argument is now of type
7911 ptrdiff_t, not int.
7912 (mark_object): Use ptrdiff_t, not int.
7913 * lisp.h (pD): New macro.
7914 * print.c (print_object): Use it.
7915
c0c5c8ae
PE
7916 * alloc.c: Use EMACS_INT, not int, to count objects.
7917 (total_conses, total_markers, total_symbols, total_vector_size)
7918 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7919 (total_free_floats, total_floats, total_free_intervals)
7920 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7921 Now EMACS_INT, not int. All uses changed.
7922 (Fgarbage_collect): Compute overall total using a double, so that
7923 integer overflow is less likely to be a problem. Check for overflow
7924 when converting back to an integer.
5a25e253
PE
7925 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7926 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7927 These were 'int' variables that could overflow on 64-bit hosts;
7928 they were never used, so remove them instead of repairing them.
211a0b2a 7929 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7930 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7931 Previously, this ceilinged at INT_MAX, but that doesn't work on
7932 64-bit machines.
e46bb31a 7933 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7934
c78baabf 7935 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7936 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7937 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7938 when a (possibly-narrower) signed value would do just as well.
7939 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7940
c9d624c6
PE
7941 * alloc.c: Catch some string size overflows that we were missing.
7942 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7943 for convenience in STRING_BYTES_MAX.
7944 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7945 The definition here is exact; the one in lisp.h was approximate.
7946 (allocate_string_data): Check for string overflow. This catches
7947 some instances we weren't catching before. Also, it catches
7948 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7949 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7950 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7951
c9d624c6
PE
7952 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7953 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7954 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7955
353032ce
PE
7956 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7957
2bccce07
PE
7958 * alloc.c (Fmake_string): Check for out-of-range init.
7959
0ac30604
SM
79602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7961
7962 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7963
c195f2de
JD
79642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7965
7966 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7967 xg_get_default_scrollbar_width.
7968
7969 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7970 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7971 (style_changed_cb): Call update_theme_scrollbar_width and call
7972 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7973 all frames (Bug#8505).
7974 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7975 Call gtk_window_set_resizable if HAVE_GTK3.
7976 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7977 and height if HAVE_GTK3 (Bug#8505).
7978 (scroll_bar_width_for_theme): New variable.
7979 (update_theme_scrollbar_width): New function.
7980 (xg_get_default_scrollbar_width): Move code to
7981 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7982 (xg_initialize): Call update_theme_scrollbar_width.
7983
7984 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7985
7986 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7987
e10ac9f1
MR
79882011-06-12 Martin Rudalics <rudalics@gmx.at>
7989
7990 * frame.c (make_frame): Call other_buffer_safely instead of
7991 other_buffer.
7992
7993 * window.c (temp_output_buffer_show): Call display_buffer with
7994 second argument Vtemp_buffer_show_specifiers and reset latter
7995 immediately after the call.
7996 (Vtemp_buffer_show_specifiers): New variable.
7997 (auto_window_vscroll_p, next_screen_context_lines)
7998 (Vscroll_preserve_screen_position): Remove leading asterisks from
7999 doc-strings.
8000
2d3c217e 80012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8002
7b7f97e8 8003 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8004 * buffer.c (Qclone_number): Remove for now, as it's unused.
8005 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8006 (record_buffer): Remove unused local.
8007 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8008 (set_frame_buffer_list): Remove; unused.
8009 * frame.h (other_visible_frames): Remove decl.
8010 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8011 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8012 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8013 if HAVE_GPM.
8014 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8015 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8016 Define only if HAVE_GPM.
8017 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8018 (update_hints_inhibit): Remove; never set. All uses removed.
8019 * widgetprv.h (emacsFrameClassRec): Remove decl.
8020 * window.c (delete_deletable_window): Now returns void, since it
8021 wasn't returning anything.
8022 (compare_window_configurations): Remove unused locals.
8023 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8024 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8025 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8026 the same widths as pointers. This follows up on the 2011-05-06 patch.
8027 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8028 * xterm.h: Likewise.
8029 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8030
1384b89e
JB
80312011-06-12 Juanma Barranquero <lekktu@gmail.com>
8032
8033 * makefile.w32-in: Update dependencies.
8034 (LISP_H): Add lib/intprops.h.
8035
1100a63c
CY
80362011-06-11 Chong Yidong <cyd@stupidchicken.com>
8037
8038 * image.c (gif_load): Add animation frame delay to the metadata.
8039 (syms_of_image): Use DEFSYM. New symbol `delay'.
8040
6198ccd0
MR
80412011-06-11 Martin Rudalics <rudalics@gmx.at>
8042
8043 * window.c (delete_deletable_window): Re-add.
8044 (Fset_window_configuration): Rewrite to handle dead buffers and
8045 consequently deletable windows.
8046 (window_tree, Fwindow_tree): Remove. Supply functionality in
8047 window.el.
8048 (compare_window_configurations): Simplify code.
8049
b6e3633c
AS
80502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8051
1ab0dee5
AS
8052 * image.c (imagemagick_load_image): Fix type mismatch.
8053 (Fimagemagick_types): Likewise.
8054
b6e3633c
AS
8055 * window.h (replace_buffer_in_windows): Declare.
8056
9397e56f
MR
80572011-06-11 Martin Rudalics <rudalics@gmx.at>
8058
8059 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8060 Qclone_number. Remove external declaration of Qdelete_window.
8061 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8062 code.
640c8776
SM
8063 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8064 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8065 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8066 buffer list implementation.
8067 (other_buffer_safely): New function.
8068 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8069 calls to replace_buffer_in_windows and
8070 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8071 if allowed.
8072 (record_buffer): Inhibit quitting and rewrite using quittable
8073 functions. Run Qbuffer_list_update_hook if allowed.
8074 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8075 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8076 Move switch-to-buffer to window.el.
9397e56f
MR
8077 (bury-buffer): Move to window.el.
8078 (Vbuffer_list_update_hook): New variable.
8079
8080 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8081 section.
8082
8083 * window.h (resize_frame_windows): Move up in code.
8084 (Fwindow_frame): Remove EXFUN.
8085 (replace_buffer_in_all_windows): Remove prototype.
8086 (replace_buffer_in_windows_safely): Add prototype.
8087
8088 * window.c: Declare Qdelete_window static again. Move down
8089 declaration of select_count.
8090 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8091 (Fother_window): Move to window.el.
8092 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8093 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8094 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8095 window.el.
8096 (replace_buffer_in_windows): Implement by calling
8097 Qreplace_buffer_in_windows.
8098 (replace_buffer_in_all_windows): Remove with some functionality
8099 moved into replace_buffer_in_windows_safely.
8100 (replace_buffer_in_windows_safely): New function.
8101 (select_window_norecord, select_frame_norecord): Move in front
8102 of run_window_configuration_change_hook. Remove now obsolete
8103 declarations.
640c8776
SM
8104 (Fset_window_buffer): Rewrite doc-string.
8105 Call Qrecord_window_buffer.
9397e56f
MR
8106 (keys_of_window): Move binding for other-window to window.el.
8107
b50691aa
CY
81082011-06-11 Chong Yidong <cyd@stupidchicken.com>
8109
8110 * dispextern.h (struct image): Replace data member, whose int_val
8111 and ptr_val fields were not used by anything, with a single
8112 lisp_val object.
8113
8114 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8115 (gif_clear_image, gif_load, imagemagick_load_image)
8116 (gs_clear_image, gs_load): Callers changed.
8117
3f754b86
PE
81182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8119
cca69397
PE
8120 * buffer.h: Include <time.h>, for time_t.
8121 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8122
109e28d0
PE
8123 Fix minor problems found by static checking.
8124
60737f02
PE
8125 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8126
4b66faf3
PE
8127 Make identifiers static if they are not used in other modules.
8128 * data.c (Qcompiled_function, Qframe, Qvector):
8129 * image.c (QimageMagick, Qsvg):
8130 * minibuf.c (Qmetadata):
8131 * window.c (resize_window_check, resize_root_window): Now static.
8132 * window.h (resize_window_check, resize_root_window): Remove decls.
8133
109e28d0
PE
8134 * window.c (window_deletion_count, delete_deletable_window):
8135 Remove; unused.
46a4ce9e
PE
8136 (window_body_lines): Now static.
8137 (Fdelete_other_windows_internal): Mark vars as initialized.
8138 Make sure 'resize_failed' is initialized.
8139 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8140 (resize_window_apply): Remove unused local.
8141 * window.h (delete_deletable_window): Remove decl.
8142
109e28d0 8143 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8144 (imagemagick_load_image): Fix pointer signedness problem by changing
8145 last arg from unsigned char * to char *. All uses changed.
8146 Also, fix a local for similar reasons.
8147 Remove unused locals. Remove locals to avoid shadowing.
8148 (fn_rsvg_handle_free): Remove; unused.
8149 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8150 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8151
3f754b86
PE
8152 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8153
2547adb1
CY
81542011-06-10 Chong Yidong <cyd@stupidchicken.com>
8155
8156 * image.c (gif_load): Fix omitted cast error introduced by
8157 2011-06-06 change.
8158
2c8e37d4
MR
81592011-06-10 Martin Rudalics <rudalics@gmx.at>
8160
8161 * window.h (resize_proportionally, orig_total_lines)
8162 (orig_top_line): Remove from window structure.
8163 (set_window_height, set_window_width, change_window_heights)
8164 (Fdelete_window): Remove prototypes.
8165 (resize_frame_windows): Remove duplicate declaration.
8166
440a42e3
EZ
81672011-06-10 Eli Zaretskii <eliz@gnu.org>
8168
8169 * window.h (resize_frame_windows, resize_window_check)
8170 (delete_deletable_window, resize_root_window)
8171 (resize_frame_windows): Declare prototypes.
8172
8173 * window.c (resize_window_apply): Make definition be "static" to
8174 match the prototype.
8175
562dd5e9
MR
81762011-06-10 Martin Rudalics <rudalics@gmx.at>
8177
8178 * window.c: Remove declarations of Qwindow_size_fixed,
8179 window_min_size_1, window_min_size_2, window_min_size,
8180 size_window, window_fixed_size_p, enlarge_window, delete_window.
8181 Remove static from declaration of Qdelete_window, it's
8182 temporarily needed by Fbury_buffer.
8183 (replace_window): Don't assign orig_top_line and
8184 orig_total_lines.
8185 (Fdelete_window, delete_window): Remove. Window deletion is
8186 handled by window.el.
640c8776
SM
8187 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8188 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8189 (Fdelete_other_windows): Remove. Deleting other windows is
8190 handled by window.el.
8191 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8192 handled in window.el.
8193 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8194 Window minimum sizes are handled in window.el.
8195 (shrink_windows, size_window, set_window_height)
8196 (set_window_width, change_window_heights, window_height)
8197 (window_width, CURBEG, CURSIZE, enlarge_window)
8198 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8199 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8200 handled in window.el.
8201 (make_dummy_parent): Rename to make_parent_window and give it a
8202 second argument horflag.
8203 (make_window): Don't set resize_proportionally any more.
8204 (Fsplit_window): Remove. Windows are split in window.el.
8205 (save_restore_action, save_restore_orig_size)
8206 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8207 Resize mini windows in window.el.
8208 (grow_mini_window, shrink_mini_window): Implement by calling
8209 Qresize_root_window_vertically, resize_window_check and
8210 resize_window_apply.
640c8776
SM
8211 (saved_window, Fset_window_configuration, save_window_save):
8212 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8213 resize_proportionally.
8214 (window_min_height, window_min_width): Move to window.el.
8215 (keys_of_window): Move bindings for delete-other-windows,
8216 split-window, delete-window and enlarge-window to window.el.
8217
8218 * buffer.c: Temporarily extern Qdelete_window.
8219 (Fbury_buffer): Temporarily call Qdelete_window instead of
8220 Fdelete_window (Fbury_buffer will move to window.el soon).
8221
8222 * frame.c (set_menu_bar_lines_1): Remove code handling
8223 orig_top_line and orig_total_lines.
8224
8225 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8226 set_window_height but set heights directly.
8227 (change_frame_size_1): Use resize_frame_windows.
8228
8229 * xdisp.c (init_xdisp): Don't use set_window_height but set
8230 heights directly.
8231
640c8776
SM
8232 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8233 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8234 run_window_configuration_change_hook.
8235
8236 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8237 instead of change_window_heights and run
8238 run_window_configuration_change_hook.
8239
1a13852e
MR
82402011-06-09 Martin Rudalics <rudalics@gmx.at>
8241
8242 * window.c (replace_window): Rename second argument REPLACEMENT to
8243 NEW. New third argument SETFLAG. Rewrite.
8244 (delete_window, make_dummy_parent): Call replace_window with
8245 third argument 1.
8246 (window_list_1): Move down in code.
8247 (run_window_configuration_change_hook): Move set_buffer part
8248 before select_frame_norecord part in order to unwind correctly.
8249 Rename count1 to count.
8250 (recombine_windows, delete_deletable_window, resize_root_window)
8251 (Fdelete_other_windows_internal)
8252 (Frun_window_configuration_change_hook, make_parent_window)
8253 (resize_window_check, resize_window_apply, Fresize_window_apply)
8254 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8255 (Fdelete_window_internal, Fresize_mini_window_internal):
8256 New functions.
1a13852e
MR
8257 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8258
f3d1777e
MR
82592011-06-08 Martin Rudalics <rudalics@gmx.at>
8260
496e208e
MR
8261 * window.h (window): Add some new members to window structure -
8262 normal_lines, normal_cols, new_total, new_normal, clone_number,
8263 splits, nest, prev_buffers, next_buffers.
8264 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8265 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8266
f3d1777e
MR
8267 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8268 Remove.
496e208e
MR
8269 (make_dummy_parent): Set new members of windows structure.
8270 (make_window): Move down in code. Handle new members of window
8271 structure.
8272 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8273 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8274 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8275 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8276 (Fset_window_next_buffers, Fset_window_clone_number):
8277 New functions.
496e208e
MR
8278 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8279 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8280 Doc-string fixes.
8281 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8282 Argument WINDOW can be now internal window too.
8283 (Fwindow_use_time): Move up in code.
8284 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8285 Rewrite doc-string.
8286 (Fset_window_configuration, saved_window)
8287 (Fcurrent_window_configuration, save_window_save): Handle new
8288 members of window structure.
b9e809c2
MR
8289 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8290 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8291 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8292 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8293 Qget_mru_window, Qresize_root_window,
8294 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8295 Qauto_buffer_name; staticpro them.
f3d1777e 8296
abde8f8c
MR
82972011-06-07 Martin Rudalics <rudalics@gmx.at>
8298
8299 * window.c (Fwindow_total_size, Fwindow_left_column)
8300 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8301 (Fwindow_list_1): New functions.
8302 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8303 (Fwindow_width, Fscroll_left, Fscroll_right):
8304 Use window_body_cols instead of window_box_text_cols.
8305 (delete_window, Fset_window_configuration):
8306 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8307 (delete_all_subwindows): Take a window as argument and not a
8308 structure. Rewrite.
190b47e6
MR
8309 (window_loop): Remove handling of GET_LRU_WINDOW and
8310 GET_LARGEST_WINDOW.
8311 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8312
8313 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8314 window_box_text_cols. delete_all_subwindows now takes a
8315 Lisp_Object as argument.
abde8f8c 8316
640c8776
SM
8317 * indent.c (compute_motion, Fcompute_motion):
8318 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8319
fa8a67e6
MR
8320 * frame.c (delete_frame): Call delete_all_subwindows with root
8321 window as argument.
8322
a54e3482
DC
83232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8324
8325 * fns.c (Fputhash): Document return value.
8326
60002bf5
CY
83272011-06-06 Chong Yidong <cyd@stupidchicken.com>
8328
8329 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8330
0c671da6 83312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8332
b862a52a 8333 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8334
be44ca6c
PE
8335 Check for overflow when converting integer to cons and back.
8336 * charset.c (Fdefine_charset_internal, Fdecode_char):
8337 Use cons_to_unsigned to catch overflow.
8338 (Fencode_char): Use INTEGER_TO_CONS.
8339 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8340 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8341 * data.c (long_to_cons, cons_to_long): Remove.
8342 (cons_to_unsigned, cons_to_signed): New functions.
8343 These signal an error for invalid or out-of-range values.
8344 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8345 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8346 * font.c (Ffont_variation_glyphs):
8347 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8348 * lisp.h: Include <intprops.h>.
8349 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8350 (cons_to_signed, cons_to_unsigned): New decls.
8351 (long_to_cons, cons_to_long): Remove decls.
8352 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8353 (Fprimitive_undo): Use CONS_TO_INTEGER.
8354 * xfns.c (Fx_window_property): Likewise.
8355 * xselect.c: Include <limits.h>.
8356 (x_own_selection, selection_data_to_lisp_data):
8357 Use INTEGER_TO_CONS.
8358 (x_handle_selection_request, x_handle_selection_clear)
8359 (x_get_foreign_selection, Fx_disown_selection_internal)
8360 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8361 (lisp_data_to_selection_data): Use cons_to_unsigned.
8362 (x_fill_property_data): Use cons_to_signed.
8363 Report values out of range.
8364
d1f3d2af
PE
8365 Check for buffer and string overflow more precisely.
8366 * buffer.h (BUF_BYTES_MAX): New macro.
8367 * lisp.h (STRING_BYTES_MAX): New macro.
8368 * alloc.c (Fmake_string):
8369 * character.c (string_escape_byte8):
8370 * coding.c (coding_alloc_by_realloc):
8371 * doprnt.c (doprnt):
8372 * editfns.c (Fformat):
8373 * eval.c (verror):
8374 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8375 since they may not be the same number.
8376 * editfns.c (Finsert_char):
8377 * fileio.c (Finsert_file_contents):
8378 Likewise for BUF_BYTES_MAX.
8379
dd52fcea
PE
8380 * image.c: Use ptrdiff_t, not int, for sizes.
8381 (slurp_file): Switch from int to ptrdiff_t.
8382 All uses changed.
8383 (slurp_file): Check that file size fits in both size_t (for
8384 malloc) and ptrdiff_t (for sanity and safety).
8385
7f9bbdbb
PE
8386 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8387 if b->modtime has its maximal value.
8388
dfe18f82
PE
8389 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8390
84acfcf0
PE
8391 Don't assume time_t can fit into int.
8392 * buffer.h (struct buffer.modtime): Now time_t, not int.
8393 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8394 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8395
ccd9a01a
PE
8396 Minor fixes for signed vs unsigned integers.
8397 * character.h (MAYBE_UNIFY_CHAR):
8398 * charset.c (maybe_unify_char):
8399 * keyboard.c (read_char, reorder_modifiers):
8400 XINT -> XFASTINT, since the integer must be nonnegative.
8401 * ftfont.c (ftfont_spec_pattern):
8402 * keymap.c (access_keymap, silly_event_symbol_error):
8403 XUINT -> XFASTINT, since the integer must be nonnegative.
8404 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8405 since it makes no difference and we prefer signed.
8406 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8407 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8408 nonnegative.
8409
d6d100dd
SM
84102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8411
8412 * window.h (Fwindow_frame): Declare.
8413
2b6148e4
PE
84142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8415
8416 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8417 (SPARE_MEMORY): Always define.
8418 (LARGE_REQUEST): Remove.
8419 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8420
f230ecc9
MR
84212011-06-06 Martin Rudalics <rudalics@gmx.at>
8422
727e958e
MR
8423 * lisp.h: Move EXFUNS for Fframe_root_window,
8424 Fframe_first_window and Fset_frame_selected_window to window.h.
8425
8426 * window.h: Move EXFUNS for Fframe_root_window,
8427 Fframe_first_window and Fset_frame_selected_window here from
8428 lisp.h.
8429
8430 * frame.c (Fwindow_frame, Fframe_first_window)
8431 (Fframe_root_window, Fframe_selected_window)
8432 (Fset_frame_selected_window): Move to window.c.
8433 (Factive_minibuffer_window): Move to minibuf.c.
8434 (Fother_visible_frames_p): New function.
8435
8436 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8437
f230ecc9
MR
8438 * window.c (decode_window, decode_any_window): Move up in code.
8439 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8440 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8441 (Fwindow_buffer): Move up and rewrite doc-string.
8442 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8443 (Fwindow_prev): New functions.
727e958e
MR
8444 (Fwindow_frame): Move here from frame.c. Accept any window as
8445 argument.
8446 (Fframe_root_window, Fframe_first_window)
8447 (Fframe_selected_window): Move here from frame.c. Accept frame
8448 or arbitrary window as argument. Update doc-strings.
8449 (Fminibuffer_window): Move up in code.
8450 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8451 (Fset_frame_selected_window): Move here from frame.c.
8452 Marginal rewrite.
727e958e
MR
8453 (Fselected_window, select_window, Fselect_window): Move up in
8454 code. Minor doc-string fixes.
f230ecc9 8455
4d09bcf6
PE
84562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8457
8458 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8459 Do not assume that spare memory exists; that assumption is valid
8460 only if SYSTEM_MALLOC.
8461 (LARGE_REQUEST): New macro, so that the issue of large requests
8462 is separated from the issue of spare memory.
8463
810928a2
AS
84642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8465
172418ad
AS
8466 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8467 format. (Bug#8806)
8468
43f862f7
AS
8469 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8470
810928a2
AS
8471 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8472 before statements.
8473
a059fe24
JD
84742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8475
8476 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8477
8478 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8479
8480 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8481 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8482
989bf368
JB
84832011-06-05 Juanma Barranquero <lekktu@gmail.com>
8484
8485 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8486
4b80f674
CY
84872011-06-04 Chong Yidong <cyd@stupidchicken.com>
8488
8489 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8490 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8491 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8492 New error handlers.
4b80f674
CY
8493 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8494 Obey Vx_select_enable_clipboard_manager. Catch errors in
8495 x_clipboard_manager_save (Bug#8779).
8496 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8497 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8498
99a33b77 84992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8500
8501 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8502
99a33b77 85032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8504
8505 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8506 in the current matrix if keep_current_p is non-zero.
8507
8264569d
EZ
85082011-06-04 Eli Zaretskii <eliz@gnu.org>
8509
8510 * bidi.c (bidi_level_of_next_char): Fix last change.
8511
57f97249
EZ
85122011-06-03 Eli Zaretskii <eliz@gnu.org>
8513
fec2107c 8514 Support bidi reordering of text covered by display properties.
57f97249 8515
fec2107c
EZ
8516 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8517 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8518 (bidi_cache_search, bidi_cache_iterator_state)
8519 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8520 (bidi_level_of_next_char, bidi_move_to_visually_next):
8521 Support character positions inside a run of characters covered by a
fec2107c
EZ
8522 display string.
8523 (bidi_paragraph_init, bidi_resolve_explicit_1)
8524 (bidi_level_of_next_char): Call bidi_fetch_char and
8525 bidi_fetch_char_advance instead of FETCH_CHAR and
8526 FETCH_CHAR_ADVANCE.
8527 (bidi_init_it): Initialize new members.
8528 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8529 definitions.
8530 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8531 instead of using explicit *_CHAR codes.
d6d100dd
SM
8532 (bidi_resolve_explicit, bidi_resolve_weak):
8533 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8534 bidirectional text is supported only in multibyte buffers.
8535 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8536 it to initialize the frame_window_p member of struct bidi_it.
8537 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8538 (bidi_resolve_explicit, bidi_resolve_weak)
8539 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8540 bidi_it->nchars is non-positive.
8541 (bidi_level_of_next_char): Don't try to lookup the cache for the
8542 next/previous character if nothing is cached there yet, or if we
8543 were just reseat()'ed to a new position.
c40e2fb2 8544
0e14fe90
EZ
8545 * xdisp.c (set_cursor_from_row): Set start and stop points
8546 according to the row's direction when priming the loop that looks
8547 for the glyph on which to display cursor.
8548 (single_display_spec_intangible_p): Function deleted.
8549 (display_prop_intangible_p): Reimplement to call
8550 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8551 Accept 3 additional arguments needed by handle_display_spec.
8552 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8553 values: lists, `(when COND...)' forms, etc.
8554 (single_display_spec_string_p): Support property values that are
8555 lists with the argument STRING its top-level element.
8556 (display_prop_string_p): Fix the condition for processing a
8557 property that is a list to be consistent with handle_display_spec.
fec2107c 8558 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8559 last portion of handle_display_prop.
8560 (compute_display_string_pos): Accept additional argument
8561 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8562 value of a `display' property is a "replacing spec".
8563 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8564 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8565 the display property, but just return a value indicating whether
8566 the display property will replace the characters it covers.
8567 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8568 frame_window_p members of struct bidi_it.
d6d100dd
SM
8569 (compute_display_string_pos, compute_display_string_end):
8570 New functions.
fec2107c
EZ
8571 (push_it): Accept second argument POSITION, where pop_it should
8572 jump to continue iteration.
8573 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8574
fec2107c
EZ
8575 * keyboard.c (adjust_point_for_property): Adjust the call to
8576 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8577
8578 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8579 (bidi_init_it): Update prototypes.
8580 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8581 (compute_display_string_pos, compute_display_string_end):
8582 Declare prototypes.
fec2107c
EZ
8583 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8584 EMACS_INT.
fc6f18ce 8585
40087514 85862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8587
57f53182
PE
8588 Malloc failure behavior now depends on size of allocation.
8589 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8590 * lisp.h: Change signatures accordingly.
8591 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8592 All callers changed. (Bug#8762)
8593
8594 * gnutls.c: Use Emacs's memory allocators.
8595 Without this change, the gnutls library would invoke malloc etc.
8596 directly, which causes problems on non-SYNC_INPUT hosts, and which
8597 runs afoul of improving memory_full behavior. (Bug#8761)
8598 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8599 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8600 xfree instead of the default malloc, realloc, free.
8601 (Fgnutls_boot): No need to check for memory allocation failure,
8602 since xmalloc does that for us.
8603
ac32cd99 8604 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8605 * category.c (hash_get_category_set):
8606 * ccl.c (ccl_driver):
8607 * charset.c (Fdefine_charset_internal):
8608 * charset.h (struct charset.hash_index):
8609 * composite.c (get_composition_id, gstring_lookup_cache)
8610 (composition_gstring_put_cache):
8611 * composite.h (struct composition.hash_index):
8612 * dispextern.h (struct image.hash):
8613 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8614 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8615 (hashfn_equal, hashfn_user_defined, make_hash_table)
8616 (maybe_resize_hash_table, hash_lookup, hash_put)
8617 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8618 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8619 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8620 * image.c (make_image, search_image_cache, lookup_image)
8621 (xpm_put_color_table_h):
8622 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8623 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8624 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8625 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8626 * alloc.c (allocate_vectorlike):
8627 Check for overflow in vector size calculations.
8628 * ccl.c (ccl_driver):
8629 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8630 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8631 need to be updated by these changes.
40087514
PE
8632 * fns.c (make_hash_table, maybe_resize_hash_table):
8633 Check for integer overflow with large hash tables.
0de4bb68
PE
8634 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8635 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8636 (SXHASH_REDUCE): New macro.
8637 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8638 Use it instead of discarding useful hash info with large hash values.
8639 (sxhash_float): New function.
8640 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8641 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8642 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8643 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8644 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8645 Adjust signatures to match updated version of code.
8646 (consing_since_gc): Now EMACS_INT, since a single hash table can
8647 use more than INT_MAX bytes.
8648
698d32e2
DN
86492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8650
8651 Make it possible to build with GCC-4.6+ -O2 -flto.
8652
8653 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8654
fd6fa53f
SM
86552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8656
8657 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8658 Call minibuffer-inactive-mode.
8659
864db017
JB
86602011-05-31 Juanma Barranquero <lekktu@gmail.com>
8661
8662 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8663 Update dependencies.
8664
2ad0baf4
DN
86652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8666
8667 * data.c (init_data): Remove code for UTS, this system is not
8668 supported anymore.
8669
4fcc2638
DN
86702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8671
8672 Don't force ./temacs to start in terminal mode.
8673
8674 * frame.c (make_initial_frame): Initialize faces in all cases, not
8675 only when CANNOT_DUMP is defined.
8676 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8677
c56e0fd5
DN
86782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8679
8680 * dispnew.c (add_window_display_history): Use const for the string
8681 pointer. Remove declaration, not needed.
8682
333d54da 86832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8684
55d4c1b2 8685 Use 'inline', not 'INLINE'.
333d54da 8686 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8687 * alloc.c, fontset.c (INLINE): Remove.
8688 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8689 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8690 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8691 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8692 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8693
738db178
DN
86942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8695
8696 Make it possible to run ./temacs.
8697
8698 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8699 syms_of_callproc does the same thing. Remove test for
8700 "initialized", do it in the caller.
8701 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8702
620c53a6
SM
87032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8704
8705 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8706 (read_minibuf): Use get_minibuffer.
8707 (syms_of_minibuf): Use DEFSYM.
8708 (Qmetadata): New var.
8709 * data.c (Qbuffer): Don't make it static.
8710 (syms_of_data): Use DEFSYM.
8711
e003a292
PE
87122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8713
8714 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8715 (CCL_CODE_MIN): New macro.
8716
ed008a6d
PE
87172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8718
3687c2ef
PE
8719 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8720
ed008a6d
PE
8721 * eval.c (Qdebug): Now static.
8722 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8723 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8724 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8725
d66c4c7c
CY
87262011-05-29 Chong Yidong <cyd@stupidchicken.com>
8727
8728 * image.c: Various fixes to ImageMagick code comments.
8729 (Fimagemagick_types): Doc fix.
8730
5fbc2025
PE
87312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8732
0196f88a
PE
8733 Minor fixes prompted by GCC 4.6.0 warnings.
8734
8735 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8736
5fbc2025
PE
8737 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8738 (x_clipboard_manager_save_all): Move extern decl to ...
8739 * xterm.h: ... here, so that it can be checked for consistency.
8740
1dd3c2d9
CY
87412011-05-29 Chong Yidong <cyd@stupidchicken.com>
8742
8743 * xselect.c (x_clipboard_manager_save_frame)
8744 (x_clipboard_manager_save_all): New functions.
8745 (Fx_clipboard_manager_save): Lisp function deleted.
8746
8747 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8748 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8749
8750 * xterm.h: Update prototype.
8751
5ba6571d
WX
87522011-05-28 William Xu <william.xwl@gmail.com>
8753
8754 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8755 exiting (Bug#8239).
8756
3eaff834
JM
87572011-05-28 Jim Meyering <meyering@redhat.com>
8758
e1900994 8759 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8760 * fns.c (to_uchar): Define.
8761 (crypto_hash_function): Use it to convert some newly-signed
8762 variables to unsigned, to avoid sign-extension bugs. For example,
8763 without this change, (md5 "truc") would evaluate to
8764 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8765 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8766 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8767
0f6990a7
PE
87682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8769
8770 Integer overflow fixes.
c8a9ca5a 8771
08686060
PE
8772 * dbusbind.c: Serial number integer overflow fixes.
8773 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8774 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8775 to hold a serial number that is too large for a fixnum.
8776 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8777 Check for serial numbers out of range. Decode any serial number
59568bf0 8778 that was so large that it became a float. (Bug#8722)
08686060 8779
2d1fc3c7
PE
8780 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8781 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8782 Use XFASTINT rather than XUINT when numbers are nonnegative.
8783 (xd_append_arg, Fdbus_method_return_internal):
8784 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8785 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8786 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8787 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8788 (Bug#8722)
2d1fc3c7 8789
c8a9ca5a
PE
8790 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8791
519e1d69
PE
8792 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8793
6df6ae42 8794 ccl: Add integer overflow checks.
30569699
PE
8795 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8796 (IN_INT_RANGE): New macros.
8797 (ccl_driver): Use them to check for integer overflow when
8798 decoding a CCL program. Many of the new checks are whether XINT (x)
8799 fits in int; it doesn't always, on 64-bit hosts. The new version
8800 doesn't catch all possible integer overflows, but it's an
847044ea 8801 improvement. (Bug#8719)
30569699 8802
c11285dc
PE
8803 * alloc.c (make_event_array): Use XINT, not XUINT.
8804 There's no need for unsigned here.
8805
fdccd48e
PE
8806 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8807 This follows up to the 2011-05-06 change that substituted uintptr_t
8808 for EMACS_INT. This case wasn't caught back then.
8809
37910ab2
PE
8810 Rework Fformat to avoid integer overflow issues.
8811 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8812 now (part of C89). Include <verify.h>.
8813 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8814 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8815 (Fformat): Avoid the prepass trying to compute sizes; it was only
8816 approximate and thus did not catch overflow reliably. Instead, walk
8817 through the format just once, formatting and computing sizes as we go,
8818 checking for integer overflow at every step, and allocating a larger
8819 buffer as needed. Keep track separately whether the format is
8820 multibyte. Keep only the most-recently calculated precision, rather
8821 than them all. Record whether each argument has been converted to
8822 string. Use EMACS_INT, not int, for byte and char and arg counts.
8823 Support field widths and precisions larger than INT_MAX. Avoid
8824 sprintf's undefined behavior with conversion specifications such as %#d
8825 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8826 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8827 formatting out-of-range floating point numbers with int
9173deec 8828 formats. (Bug#8668)
37910ab2 8829
2e6578fb
PE
8830 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8831
0ae6bdee
PE
8832 * data.c: Avoid integer truncation in expressions involving floats.
8833 * data.c: Include <intprops.h>.
8834 (arith_driver): When there's an integer overflow in an expression
8835 involving floating point, convert the integers to floating point
8836 so that the resulting value does not suffer from catastrophic
8837 integer truncation. For example, on a 64-bit host (* 4
8838 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8839 Do not rely on undefined behavior after integer overflow.
8840
de883a70
PE
8841 merge count_size_as_multibyte, parse_str_to_multibyte
8842 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8843 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8844 Check for integer overflow.
8845 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8846 since it's now a duplicate of the other. This is more of
8847 a character than a buffer op, so better that it's in character.c.
8848 * fns.c, print.c: Adjust to above changes.
8849
2ff916cb
PE
88502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8851
8852 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8853
f1b54466
PE
88542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8855
fb1ac845
PE
8856 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8857 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8858 (x_clipboard_manager_save): Now static.
8859 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8860
f1b54466
PE
8861 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8862 (crypto_hash_function): Now static.
8863 Fix pointer signedness problems. Avoid unnecessary initializations.
8864
a9f737ee
CY
88652011-05-27 Chong Yidong <cyd@stupidchicken.com>
8866
8867 * termhooks.h (Vselection_alist): Make it terminal-local.
8868
8869 * terminal.c (create_terminal): Initialize it.
8870
8871 * xselect.c: Support for clipboard managers.
8872 (Vselection_alist): Move to termhooks.h as terminal-local var.
8873 (LOCAL_SELECTION): New macro.
8874 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8875 (symbol_to_x_atom): Remove gratuitous arg.
8876 (x_handle_selection_request, lisp_data_to_selection_data)
8877 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8878 (x_own_selection, x_get_local_selection, x_convert_selection):
8879 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8880 (some_frame_on_display): Delete unused function.
8881 (Fx_own_selection_internal, Fx_get_selection_internal)
8882 (Fx_disown_selection_internal, Fx_selection_owner_p)
8883 (Fx_selection_exists_p): New optional frame arg.
8884 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8885 (x_handle_selection_clear): Don't treat other terminals with the
8886 same keyboard specially. Use the terminal-local Vselection_alist.
8887 (x_clear_frame_selections): Use Frun_hook_with_args.
8888
8889 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8890
8891 * xterm.h: Add support for those atoms.
8892
e067f0c1
CY
88932011-05-26 Chong Yidong <cyd@stupidchicken.com>
8894
8895 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8896 (converted_selections, conversion_fail_tag): New global variables.
8897 (x_selection_request_lisp_error): Free the above.
8898 (x_get_local_selection): Remove unnecessary code.
8899 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8900 of converted selections stored in converted_selections.
8901 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8902 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8903 (x_convert_selection): New function.
8904 (x_handle_selection_event): Simplify.
8905 (x_get_foreign_selection): Don't ignore incoming requests while
8906 waiting for an answer; this will fail when we implement
8907 SAVE_TARGETS, and seems unnecessary anyway.
8908 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8909 (Vx_sent_selection_functions): Doc fix.
8910
0f4aebc0
LL
89112011-05-26 Leo Liu <sdl.web@gmail.com>
8912
8913 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8914
e61124cd
YM
89152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8916
8917 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8918
8919 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8920 for fringe update if it has periodic bitmap.
ac389d0c 8921 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8922 and fringe_bitmap_periodic_p.
8923
8924 * fringe.c (get_fringe_bitmap_data): New function.
8925 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8926 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8927 row. Mark glyph row for fringe update if periodicity changed.
8928
8929 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8930 for fringe update unless it has periodic bitmap.
8931
f16d9837
KH
89322011-05-25 Kenichi Handa <handa@m17n.org>
8933
8934 * xdisp.c (get_next_display_element): Set correct it->face_id for
8935 a static composition.
8936
e1b90ef6
LL
89372011-05-24 Leo Liu <sdl.web@gmail.com>
8938
8939 * deps.mk (fns.o):
8940 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8941
8942 * fns.c (crypto_hash_function, Fsha1): New function.
8943 (Fmd5): Use crypto_hash_function.
8944 (syms_of_fns): Add Ssha1.
8945
7400048f
PE
89462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8947
8948 * gnutls.c: Remove unused macros.
8949 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8950 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8951 Remove macros that are defined and never used.
8952 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8953
abb71cf4
CY
89542011-05-22 Chong Yidong <cyd@stupidchicken.com>
8955
8956 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8957 (Fx_get_selection_internal): Minor cleanup.
8958 (Fx_own_selection_internal): Rename arguments for consistency with
8959 select.el.
8960
6307db39
PE
89612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8962
8963 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8964
f3d4e0a4
CY
89652011-05-22 Chong Yidong <cyd@stupidchicken.com>
8966
8967 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8968
4d8ade89
YM
89692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8970
8971 * dispnew.c (scrolling_window): Don't exclude the case that the
8972 last enabled row in the desired matrix touches the bottom boundary.
8973
32078c8d
GM
89742011-05-21 Glenn Morris <rgm@gnu.org>
8975
8976 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8977 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8978 and add some more files.
32078c8d 8979
7285dc67
EZ
89802011-05-20 Eli Zaretskii <eliz@gnu.org>
8981
8982 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8983 report_file_error introduced by the change from 2011-05-07.
8984
89d1bd22
PE
89852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8986
8987 * systime.h (Time): Define only if emacs is defined.
8988 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8989 where the include path doesn't have X11/X.h by default. See
8990 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8991
cd394be1 89922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8993
8994 * composite.c (find_automatic_composition): Fix previous change.
8995
b9704ad9
GM
89962011-05-20 Glenn Morris <rgm@gnu.org>
8997
8998 * lisp.mk: New file, split from Makefile.in.
8999 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9000 (shortlisp): Remove.
9001 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9002
4a720484
GM
90032011-05-19 Glenn Morris <rgm@gnu.org>
9004
9005 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9006 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9007 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9008 (lisp): Set the order to that of loadup.el.
9009 (shortlisp): Make it a copy of $lisp.
9010 (SOME_MACHINE_LISP): Remove.
9011 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9012 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9013
a28d4396
KH
90142011-05-18 Kenichi Handa <handa@m17n.org>
9015
9016 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9017 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9018 (find_automatic_composition): Mostly rewrite for efficiency.
9019
a2b1fa8e
JB
90202011-05-18 Juanma Barranquero <lekktu@gmail.com>
9021
9022 * makefile.w32-in: Update dependencies.
9023
8e1f5610
CS
90242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9025
9026 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9027 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9028
7025ee00 90292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9030
cdfa6eab
PE
9031 Fix some integer overflow issues, such as string length overflow.
9032
06d6db33
PE
9033 * insdel.c (count_size_as_multibyte): Check for string overflow.
9034
2b4560a8
PE
9035 * character.c (lisp_string_width): Check for string overflow.
9036 Use EMACS_INT, not int, for string indexes and lengths; in
9037 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9038 the resulting string length overflows an EMACS_INT; instead,
9039 report a string overflow if no precision given. When checking for
9040 precision exhaustion, use a check that cannot possibly have
9041 integer overflow. (Bug#8675)
9042 * character.h (lisp_string_width): Adjust to new signature.
9043
cb93f9be
PE
9044 * alloc.c (string_overflow): New function.
9045 (Fmake_string): Use it. This doesn't change behavior, but saves
9046 a few bytes and will simplify future changes.
9047 * character.c (string_escape_byte8): Likewise.
9048 * lisp.h (string_overflow): New decl.
9049
1a1f3366
PE
9050 Fixups, following up to the user-interface timestamp change.
9051 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9052 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9053 * msdos.c (mouse_get_pos): Likewise.
9054 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9055 * w32gui.h (Time): Define by including "systime.h" rather than by
9056 declaring it ourselves. (Bug#8664)
9057
d4e3e4d3
PE
9058 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9059 * image.c (clear_image_cache): Likewise.
9060
f6a24d19
PE
9061 * term.c (term_mouse_position): Don't assume time_t wraparound.
9062
08dc5ae6
PE
9063 Be more systematic about user-interface timestamps.
9064 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9065 and sometimes 'EMACS_UINT', to represent these timestamps.
9066 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9067 This makes the code easier to follow, and makes it easier to catch
9068 integer overflow bugs such as Bug#8664.
9069 * frame.c (Fmouse_position, Fmouse_pixel_position):
9070 Use Time, not unsigned long, for user-interface timestamps.
9071 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9072 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9073 * keyboard.h (last_event_timestamp): Likewise.
9074 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9075 * menu.h (xmenu_show): Likewise.
9076 * term.c (term_mouse_position): Likewise.
9077 * termhooks.h (struct input_event.timestamp): Likewise.
9078 (struct terminal.mouse_position_hook): Likewise.
9079 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9080 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9081 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9082 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9083 what it was before.
9084 * menu.h, termhooks.h: Include "systime.h", for Time.
9085
8e55734a
PE
9086 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9087 Don't assume that the difference between two unsigned long values
9088 can fit into an integer. At this point, we know button_down_time
9089 <= event->timestamp, so the difference must be nonnegative, so
9090 there's no need to cast the result if double-click-time is
9091 nonnegative, as it should be; check that it's nonnegative, just in
9092 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9093 apart (about 25 days). (Bug#8664)
8e55734a 9094
841f1b75 9095 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9096 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9097
3e26f69c
PE
9098 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9099 that always fit in int. Use a sentinel instead of a counter, to
9100 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9101 * frame.h (struct frame): Use int for menu_bar_items_used
9102 instead of EMACS_INT, since it always fits in int.
3e26f69c 9103
5cc152c0
PE
9104 * menu.c (grow_menu_items): Check for int overflow.
9105
d89eb65e
PE
9106 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9107
5235bd3e
PE
9108 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9109 Before, the code was not consistent. These values cannot exceed
9110 2**31 - 1 so there's no need to make them unsigned.
9111 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9112 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9113 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9114 as modifiers.
9115 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9116
bc827e23
PE
9117 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9118 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9119 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9120 presumably because the widths might not match.
9121
78eb494e
PE
9122 * window.c (size_window): Avoid needless test at loop start.
9123
04f2d78b
CB
91242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9125
9126 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9127
d2fc7e3d 91282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9129
9130 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9131
d2fc7e3d 91322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9133
9134 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9135 `width' to `bar_area_x' and `bar_area_width', respectively.
9136 (x_scroll_run): Take account of fringe background extension.
9137
04f2d78b
CB
9138 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9139 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9140 `bar_area_width', respectively.
9141 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9142 background extension.
9143
79b70037
GM
91442011-05-10 Jim Meyering <meyering@redhat.com>
9145
9146 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9147
2f142cc5
JB
91482011-05-10 Juanma Barranquero <lekktu@gmail.com>
9149
9150 * image.c (Finit_image_library): Return t for built-in image types,
9151 like pbm and xbm. (Bug#8640)
9152
57679c86
AS
91532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9154
9155 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9156
888c9e86
EZ
91572011-05-07 Eli Zaretskii <eliz@gnu.org>
9158
b0512a1d
EZ
9159 * w32console.c (Fset_screen_color): Doc fix.
9160 (Fget_screen_color): New function.
9161 (syms_of_ntterm): Defsubr it.
9162
7285dc67
EZ
9163 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9164 unlink the temporary file if Fcall_process didn't create it in the
9165 first place.
9166 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9167 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9168 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9169 cue to call_process_cleanup not to close that handle.
9170
4d3fcc8e
BK
91712011-05-07 Ben Key <bkey76@gmail.com>
9172
9173 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9174 one of two shell specific rules, either bootstrap-temacs-CMD or
9175 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9176 to the previous implementation of the bootstrap-temacs rule.
9177 The bootstrap-temacs-CMD rule is similar to the previous
9178 implementation of the bootstrap-temacs rule except that it
9179 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9180 variable.
9181
9182 These changes, along with some changes to nt/configure.bat,
9183 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9184 earlier fix to add support for --cflags and --ldflags options
9185 that include quotes so that it works whether make uses cmd or
9186 sh as the shell.
9187
b4289b64
MA
91882011-05-06 Michael Albinus <michael.albinus@gmx.de>
9189
9190 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9191 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9192 is a constant.
9193 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9194 a string. Handle both cases.
9195 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9196 (Fdbus_register_method): Use Qinvalid_function.
9197
af4c0e28
JB
91982011-05-06 Juanma Barranquero <lekktu@gmail.com>
9199
9200 * makefile.w32-in: Update dependencies.
9201 (LISP_H): Add inttypes.h and stdin.h.
9202 (PROCESS_H): Add unistd.h.
9203
c51453d9
EZ
92042011-05-06 Eli Zaretskii <eliz@gnu.org>
9205
9206 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9207 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9208
8ff0ac3c 92092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9210
4c4b566b
PE
9211 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9212
aab2b9b5
PE
9213 * term.c (vfatal): Remove stray call to va_end.
9214 It's not needed and the C Standard doesn't allow it here anyway.
9215
c378da0b
PE
9216 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9217 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9218
288b08c7
PE
9219 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9220 bytes.
9221
e3601888
PE
9222 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9223
db6c0e74
PE
9224 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9225
dd5963ea
PE
9226 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9227
88c9450f
PE
9228 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9229
2f9442b8
PE
9230 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9231
c032b5f8
PE
9232 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9233 * charset.c (Fdefine_charset_internal): Don't initialize
9234 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9235 32-bit int (Bug#8600).
a108c10b
PE
9236
9237 * lread.c (read_integer): Be more consistent with string-to-number.
9238 Use string_to_number to do the actual conversion; this avoids
9239 rounding errors and fixes some other screwups. Without this fix,
9240 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9241 (digit_to_number): Move earlier, for benefit of read_integer.
9242 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9243 not a digit in any supported base. (Bug#8602)
a108c10b 9244
ad5f9eea
PE
9245 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9246
aec1708a
PE
9247 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9248 to match comment at start of function. This also removes a
9249 GCC warning about overflow in a 32+64-bit port.
9250
47be4ab5
PE
9251 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9252
371cac43
PE
9253 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9254 Reported by Stefan Monnier in
9255 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9256 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9257 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9258
d01a7826
PE
9259 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9260 (EMACS_UINTPTR): Likewise, with uintptr_t.
9261
7fd47d5c
PE
9262 * lisp.h: Prefer 64-bit EMACS_INT if available.
9263 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9264 on 32-bit hosts that have 64-bit int, so that they can access
9265 large files.
122b0c86
PE
9266 However, temporarily disable this change unless the temporary
9267 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9268
8727937b
PE
9269 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9270
8ac068ac
PE
9271 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9272 This removes an assumption that EMACS_INT and long are the same
9273 width as pointers. The assumption is true for Emacs porting targets
9274 now, but we want to make other targets possible.
9275 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9276 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9277 In the rest of the code, change types of integers that hold casted
9278 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9279 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9280 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9281 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9282 No need to cast type when ORing.
9283 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9284 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9285 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9286 assume EMACS_INT is the same width as char *.
9287 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9288 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9289 Remove no-longer-needed casts.
9290 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9291 (xg_tool_bar_help_callback, xg_make_tool_item):
9292 Use EMACS_INTPTR to hold an integer
9293 that will be cast to void *; this can avoid a GCC warning
9294 if EMACS_INT is not the same width as void *.
9295 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9296 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9297 (current_message_1, set_message_1):
9298 Use a local to convert to proper width without a cast.
9299 * xmenu.c (dialog_selection_callback): Likewise.
9300
ede49d71
PE
9301 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9302 Also, don't assume VALBITS / RAND_BITS is less than 5,
9303 and don't rely on undefined behavior when shifting a 1 left into
9304 the sign bit.
9305 * lisp.h (get_random): Change signature to match.
9306
2f30ecd0
PE
9307 * lread.c (hash_string): Use size_t, not int, for hash computation.
9308 Normally we prefer signed values; but hashing is special, because
9309 it's better to use unsigned division on hash table sizes so that
9310 the remainder is nonnegative. Also, size_t is the natural width
9311 for hashing into memory. The previous code used 'int', which doesn't
9312 retain enough info to hash well into very large tables.
9313 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9314
2a866e7b
PE
9315 * dbusbind.c: Don't possibly lose pointer info when converting.
9316 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9317 Use XPNTR rather than XHASH, so that the high-order bits of
9318 the pointer aren't lost when converting through void *.
9319
51639eac
PE
9320 * eval.c (Fautoload): Don't double-shift a pointer.
9321
92394119
PE
9322 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9323
dbdb9a7c
JB
93242011-05-06 Juanma Barranquero <lekktu@gmail.com>
9325
9326 * gnutls.c (DEF_GNUTLS_FN):
9327 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9328
db7a0b4f
AS
93292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9330
9331 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9332 marker. (Bug#8610)
9333
cd394be1 93342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9335
9336 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9337 New version that can reserve upto 2GB of heap space.
9338
f7ff1b0f 93392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9340
9341 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9342
639c109b
TZ
93432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9344
9345 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9346 `gnutls_certificate_set_x509_key_file'.
9347
d2127135
JB
93482011-05-05 Juanma Barranquero <lekktu@gmail.com>
9349
9350 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9351 Update dependencies.
9352
e968f4f3
JB
93532011-05-04 Juanma Barranquero <lekktu@gmail.com>
9354
9355 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9356 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9357 Remove unused parameter `fildes'.
9358 * process.c (read_process_output, send_process): Don't pass it.
9359
84d358f0
JB
93602011-05-04 Juanma Barranquero <lekktu@gmail.com>
9361
9362 Fix previous change: the library cache is defined in w32.c.
9363 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9364 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9365
0898ca10
JB
93662011-05-04 Juanma Barranquero <lekktu@gmail.com>
9367
9368 Implement dynamic loading of GnuTLS on Windows.
9369
9370 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9371 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9372 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9373 Declare.
9374
9375 * gnutls.c (Qgnutls_dll): Define.
9376 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9377 (gnutls_*): Declare function pointers.
9378 (init_gnutls_functions): New function to initialize function pointers.
9379 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9380 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9381 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9382 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9383 (emacs_gnutls_write, emacs_gnutls_read)
9384 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9385 (Fgnutls_available_p): New function.
9386 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9387 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9388 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9389
9390 * image.c: Include w32.h.
9391 (Vimage_type_cache): Delete.
9392 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9393 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9394 (w32_delayed_load): Move to w32.c.
9395
9396 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9397
9398 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9399 (w32_delayed_load): Move from image.c. When loading a library, record
9400 its filename in the :loaded-from property of the library id.
9401 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9402 Initialize and staticpro them.
9403 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9404
9405 * process.c: Include lisp.h before w32.h, not after.
9406 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9407 instead of gnutls_record_check_pending.
9408
9409 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9410
ff4de4aa
TZ
94112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9412
9413 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9414 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9415 as passed in.
9416
abe95abb
JD
94172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9418
9419 * xterm.c (x_set_frame_alpha): Do not set property on anything
9420 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9421
e16e55d4
JB
94222011-05-02 Juanma Barranquero <lekktu@gmail.com>
9423
9424 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9425
bafcf6a5
JB
94262011-05-02 Juanma Barranquero <lekktu@gmail.com>
9427
9428 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9429 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9430 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9431 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9432 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9433 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9434 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9435 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9436 (Qgnutls_bootprop_callbacks_verify): Make static.
9437
e7a6747f
AS
94382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9439
19ed11ba
AS
9440 * callproc.c: Indentation fixup.
9441
e7a6747f 9442 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9443 (wait_for_termination, interruptible_wait_for_termination):
9444 Move after wait_for_termination_1.
e7a6747f 9445
1ef14cb4
LMI
94462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9447
9448 * sysdep.c (interruptible_wait_for_termination): New function
9449 which is like wait_for_termination, but allows keyboard
9450 interruptions.
9451
9452 * callproc.c (Fcall_process): Add (:file "file") as an option for
9453 the STDOUT buffer.
9454 (Fcall_process_region): Ditto.
9455
330d880c
EZ
94562011-04-30 Eli Zaretskii <eliz@gnu.org>
9457
8db90b73
EZ
9458 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9459 rather than `XVECTOR (FOO)->size'.
9460
330d880c
EZ
9461 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9462 inttypes.h, as a gnulib replacement is used if it not available in
9463 system headers.
9464
15cbd324
EZ
94652011-04-21 Eli Zaretskii <eliz@gnu.org>
9466
9467 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9468 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9469 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9470
9471 * coding.c (coding_alloc_by_realloc): Error out if destination
9472 will grow beyond MOST_POSITIVE_FIXNUM.
9473 (decode_coding_emacs_mule): Abort if there isn't enough place in
9474 charbuf for the composition carryover bytes. Reserve an extra
9475 space for up to 2 characters produced in a loop.
9476 (decode_coding_iso_2022): Abort if there isn't enough place in
9477 charbuf for the composition carryover bytes.
9478
94792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9480
ae940cca
EZ
9481 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9482 aborting when %lld or %lll format is passed.
9483 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9484 %llo or %llx format is passed. (Bug#8545)
9485
03ab8921
EZ
9486 * window.c (window_scroll_line_based): Use a marker instead of
9487 simple variables to record original value of point. (Bug#7952)
9488
afda1437
EZ
9489 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9490 produced by %s or %c overflows available buffer space. (Bug#8545)
9491
f76dee0c
PE
94922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9493
9494 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9495 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9496
fdc5744d
JB
94972011-04-28 Juanma Barranquero <lekktu@gmail.com>
9498
9499 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9500
638f053a
JB
95012011-04-28 Juanma Barranquero <lekktu@gmail.com>
9502
9503 * keyboard.c (Qdelayed_warnings_hook): Define.
9504 (command_loop_1): Run `delayed-warnings-hook'
9505 if Vdelayed_warnings_list is non-nil.
9506 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9507 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9508
d178f871
EZ
95092011-04-28 Eli Zaretskii <eliz@gnu.org>
9510
9511 * doprnt.c (doprnt): Don't return value smaller than the buffer
9512 size if the message was truncated. (Bug#8545).
9513
b124fd93
JB
95142011-04-28 Juanma Barranquero <lekktu@gmail.com>
9515
9516 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9517 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9518
e810457d
PE
95192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9520
9521 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9522
ea51cceb
JB
95232011-04-27 Juanma Barranquero <lekktu@gmail.com>
9524
9525 * makefile.w32-in: Update dependencies.
9526
94dcfacf
EZ
95272011-04-27 Eli Zaretskii <eliz@gnu.org>
9528
9529 Improve `doprnt' and its usage. (Bug#8545)
9530 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9531 `format_end'. Remove support for %l as a conversion specifier.
9532 Don't use xrealloc. Improve diagnostics when the %l size modifier
9533 is used. Update the commentary.
9534
9535 * eval.c (verror): Simplify calculation of size_t.
9536
9537 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9538 messages.
9539
f61f41d7
PE
95402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9541
9542 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9543 change.
9544
96fb4434
PE
95452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9546
9547 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9548 This makes this file independent of the recent pseudovector change.
9549
671875da 95502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9551
69e9b5a3
PE
9552 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9553
b5f869a7 9554 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9555 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9556 Remove unused local.
c8926152 9557 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9558
841a1577 9559 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9560 GCC 4.6.0 optimizes based on type-based alias analysis.
9561 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9562 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9563 != &v->size, and therefore "v->size = 1; b->size = 2; return
9564 v->size;" must therefore return 1. This assumption is incorrect
9565 for Emacs, since it type-puns struct Lisp_Vector * with many other
9566 types. To fix this problem, this patch adds a new type struct
f904488f 9567 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9568 and pseudovectors, and helps optimizing compilers not get fooled
9569 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9570 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9571 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9572 the size member.
eab3844f
PE
9573 (XSETPVECTYPE): Rewrite in terms of new macro.
9574 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9575 This is a bit clearer, and further avoids the possibility of
9576 undesirable aliasing.
9577 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9578 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9579 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9580 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9581 (ASIZE): Now uses header.size rather than size.
9582 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9583 to avoid the hassle of writing XVECTOR (foo)->header.size.
9584 (struct vectorlike_header): New type.
eab3844f
PE
9585 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9586 object, to help avoid aliasing.
9587 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9588 (SUBRP): Likewise, since Lisp_Subr is a special case.
9589 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9590 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9591 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9592 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9593 changed to be "header.size" and "header.next".
9594 * buffer.h (struct buffer): Likewise.
9595 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9596 * frame.h (struct frame): Likewise.
9597 * process.h (struct Lisp_Process): Likewise.
9598 * termhooks.h (struct terminal): Likewise.
9599 * window.c (struct save_window_data, struct saved_window): Likewise.
9600 * window.h (struct window): Likewise.
9601 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9602 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9603 * buffer.c (init_buffer_once): Likewise.
9604 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9605 special case.
9606 * process.c (Fformat_network_address): Use local var for size,
9607 for brevity.
9608
0df1eac5
PE
9609 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9610
847ab9d1 9611 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9612 * data.c (atof): Remove decl; no longer used or needed.
9613 (digit_to_number): Move to lread.c.
9614 (Fstring_to_number): Use new string_to_number function, to be
9615 consistent with how the Lisp reader treats infinities and NaNs.
9616 Do not assume that floating-point numbers represent EMACS_INT
9617 without losing information; this is not true on most 64-bit hosts.
9618 Avoid double-rounding errors, by insisting on integers when
9619 parsing non-base-10 numbers, as the documentation specifies.
9620 * lisp.h (string_to_number): New decl, replacing ...
9621 (isfloat_string): Remove.
bc0a5c13 9622 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9623 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9624 appears to have been a coding error. Similarly, do not accept
9625 strings like +-1e0 as floating point numbers. Do not report
9626 overflow for integer overflows unless the base is not 10 which
9627 means we have no simple and reliable way to continue.
9628 Break out the floating-point parsing into a new
9629 function string_to_number, so that Fstring_to_number parses
9630 floating point numbers consistently with the Lisp reader.
04f2d78b 9631 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9632 (E_CHAR, EXP_INT): Remove, replacing with ...
9633 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9634 (string_to_number): New function, replacing isfloat_string.
9635 This function checks for valid syntax and produces the resulting
9636 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9637 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9638 so that overflow for non-base-10 numbers is reported only when
9639 there's no portable and simple way to convert to floating point.
452f4150 9640
67769ffc
PE
9641 * textprop.c (set_text_properties_1): Rewrite for clarity,
9642 and to avoid GCC warning about integer overflow.
9643
c20db43f
PE
9644 * intervals.h (struct interval): Use EMACS_INT for members
9645 where EMACS_UINT might cause problems. See
9646 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9647 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9648 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9649 All uses changed.
37aa2f85
PE
9650 (offset_intervals): Tell GCC not to worry about length overflow
9651 when negating a negative length.
c20db43f 9652
2538aa2f
PE
9653 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9654 (overrun_check_free): Likewise.
9655
f2d3008d
PE
9656 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9657 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9658 word size.
9659
ec8df744
PE
9660 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9661 (gnutls_make_error): Rename local to avoid shadowing.
9662 (gnutls_emacs_global_deinit): ifdef out; not used.
9663 (Fgnutls_boot): Use const for pointer to readonly storage.
9664 Comment out unused local. Fix pointer signedness problems.
9665
640ee02d
PE
9666 * lread.c (openp): Don't stuff size_t into an 'int'.
9667 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9668 about possible signed overflow.
9669
6048fb2a
PE
9670 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9671 (GDK_KEY_g): Don't define if already defined.
9672 (xg_prepare_tooltip): Avoid pointer signedness problem.
9673 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9674
fa3c87e1
PE
9675 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9676 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9677
2172544b
PE
9678 * xfns.c (Fx_window_property): Simplify a bit,
9679 to make a bit faster and to avoid GCC 4.6.0 warning.
9680 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9681
9b821a21
PE
9682 * fns.c (internal_equal): Don't assume size_t fits in int.
9683
3c616cfa
PE
9684 * alloc.c (compact_small_strings): Tighten assertion a little.
9685
c2982e87
PE
9686 Replace pEd with more-general pI, and fix some printf arg casts.
9687 * lisp.h (pI): New macro, generalizing old pEd macro to other
9688 conversion specifiers. For example, use "...%"pI"d..." rather
9689 than "...%"pEd"...".
9690 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9691 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9692 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9693 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9694 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9695 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9696 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9697 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9698 64-bit hosts.
9699 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9700 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9701 * print.c (safe_debug_print, print_object): Likewise.
9702 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9703 to int.
6f04d126
PE
9704 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9705 avoiding the 0 flag, which is not portable.
c2982e87
PE
9706 * process.c (Fmake_network_process): Use pI to avoid cast.
9707 * region-cache.c (pp_cache): Likewise.
9708 * xdisp.c (decode_mode_spec): Likewise.
9709 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9710 behavior on 64-bit hosts with printf arg.
6f04d126 9711 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9712 (x_stop_queuing_selection_requests): Likewise.
9713 (x_get_window_property): Don't truncate byte count to an 'int'
9714 when tracing.
0b432f21 9715
5e073ec7
PE
9716 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9717 here, since it parses constructs like leading '-' and spaces,
9718 which are not wanted; and it overflows with large numbers.
9719 Instead, simply match F[0-9]+, which is what is wanted anyway.
9720
36372bf9
PE
9721 * alloc.c: Remove unportable assumptions about struct layout.
9722 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9723 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9724 (allocate_vectorlike, make_pure_vector): Use the new macros,
9725 plus offsetof, to remove unportable assumptions about struct layout.
9726 These assumptions hold on all porting targets that I know of, but
9727 they are not guaranteed, they're easy to remove, and removing them
9728 makes further changes easier.
9729
0b432f21
PE
9730 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9731 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9732 (string_overrun_cookie): Now const. Use initializers that
9733 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9734 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9735 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9736 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9737 multiple of sizeof (EMACS_INT); it need not be, if
9738 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9739 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9740
895009e1
JB
97412011-04-26 Juanma Barranquero <lekktu@gmail.com>
9742
9743 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9744
6a7a1b0b
TZ
97452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9746
9747 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9748 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9749 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9750
841a1577 97512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9752
9753 * lisp.h (Qdebug): List symbol.
895009e1 9754 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9755 * keyboard.c (debug-on-event): New variable.
9756 (handle_user_signal): Break into debugger when debug-on-event
9757 matches the current signal symbol.
9758
f2d3ba6f
DN
97592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9760
9761 * alloc.c (check_sblock, check_string_bytes)
9762 (check_string_free_list): Convert to standard C.
9763
42ce4c63
TZ
97642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9765
9766 * w32.c (emacs_gnutls_push): Fix typo.
9767
825cd63c
EZ
97682011-04-25 Eli Zaretskii <eliz@gnu.org>
9769
fb11d64d
EZ
9770 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9771 "cast to pointer from integer of different size".
9772
825cd63c
EZ
9773 Improve doprnt and its use in verror. (Bug#8545)
9774 * doprnt.c (doprnt): Document the set of format control sequences
9775 supported by the function. Use SAFE_ALLOCA instead of always
9776 using `alloca'.
9777
9778 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9779 is one byte too soon. Don't use xrealloc; instead xfree and
9780 xmalloc anew.
9781
e061a11b
TZ
97822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9783
9784 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9785 callbacks stage.
9786
9787 * gnutls.c: Renamed global_initialized to
9788 gnutls_global_initialized. Added internals for the
9789 :verify-hostname-error, :verify-error, and :verify-flags
9790 parameters of `gnutls-boot' and documented those parameters in the
9791 docstring. Start callback support.
9173deec
JB
9792 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9793 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9794 on error. Return error code.
e061a11b
TZ
9795 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9796 (emacs_gnutls_read): Likewise.
9797 (Fgnutls_boot): Return handshake error code.
9798 (emacs_gnutls_handle_error): New function.
9799 (wsaerror_to_errno): Likewise.
9800
9801 * w32.h (emacs_gnutls_pull): Add prototype.
9802 (emacs_gnutls_push): Likewise.
9803
9804 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9805 (emacs_gnutls_push): Likewise.
9806
98072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9808
9809 * process.c (wait_reading_process_output): Check if GnuTLS
9810 buffered some data internally if no FDs are set for TLS
9811 connections.
9812
9813 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9814 (LIBS): Link to USER_LIBS.
9815 ($(BLD)/gnutls.$(0)): New target.
9816
fa6996bc
EZ
98172011-04-24 Eli Zaretskii <eliz@gnu.org>
9818
eb35682e
EZ
9819 * xdisp.c (handle_single_display_spec): Rename the
9820 display_replaced_before_p argument into display_replaced_p, to
9821 make it consistent with the commentary. Fix typos in the
9822 commentary.
9823
e2ad650c
EZ
9824 * textprop.c (syms_of_textprop): Remove dead code.
9825 (copy_text_properties): Delete obsolete commentary about an
9826 interface that was deleted long ago. Fix typos in the description
9827 of arguments.
9828
1b2de274
EZ
9829 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9830 to changes in oldXMenu/XMenu.h from 2011-04-16.
9831 <menu_help_message, prev_menu_help_message>: Constify.
9832 (IT_menu_make_room): menu->help_text is now `const char **';
9833 adjust.
9834
9835 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9836 to changes in oldXMenu/XMenu.h from 2011-04-16.
9837 (struct XMenu): Declare `help_text' `const char **'.
9838
9839 * xfaces.c <Qunspecified>: Make extern again.
9840
9841 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9842 required by POSIX.
1b2de274 9843
762b15be
EZ
9844 * doc.c (get_doc_string): Improve the format passed to `error'.
9845
9846 * doprnt.c (doprnt): Improve commentary.
9847
9848 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9849
9850 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9851 them with etags.
9852
f1052e5d
EZ
9853 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9854 changes in globals.h immediately force recompilation.
762b15be
EZ
9855 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9856 $(CURDIR)/s/ms-w32.h.
9857 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9858
fa6996bc
EZ
9859 * character.c (Fchar_direction): Function deleted.
9860 (syms_of_character): Don't defsubr it.
9861 <char-direction-table>: Deleted.
9862
e6c3da20
EZ
98632011-04-23 Eli Zaretskii <eliz@gnu.org>
9864
9865 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9866 * doprnt.c: Include limits.h.
9867 (SIZE_MAX): New macro.
04f2d78b
CB
9868 (doprnt): Return a size_t value. 2nd arg is now size_t.
9869 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9870 Improve overflow protection. Support `l' modifier for integer
9871 conversions. Support %l conversion. Don't assume an EMACS_INT
9872 argument for integer conversions and for %c.
9873
9874 * lisp.h (doprnt): Restore prototype.
9875
9876 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9877 $(SRC)/character.h.
9878
9879 * Makefile.in (base_obj): Add back doprnt.o.
9880
9881 * deps.mk (doprnt.o): Add back prerequisites.
9882 (callint.o): Depend on character.h.
9883
9884 * eval.c (internal_lisp_condition_case): Include the handler
9885 representation in the error message.
9886 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9887 when breaking from the loop.
9888
9889 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9890
9891 * callint.c (Fcall_interactively): When displaying error message
9892 about invalid control letter, pass the character's codepoint, not
9893 a pointer to its multibyte form. Improve display of the character
9894 in octal and display also its hex code.
9895
9896 * character.c (char_string): Use %x to display the (unsigned)
9897 codepoint of an invalid character, to avoid displaying a bogus
9898 negative value.
9899
9900 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9901 `error', not SYMBOL_NAME itself.
9902
9903 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9904 character arguments to `error'.
9905
9906 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9907 to `error' in error message about FINAL_CHAR argument. Make sure
9908 FINAL_CHAR is a character, and use %c when it is passed as
9909 argument to `error'.
9910
4ffd0d6b 99112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9912
9913 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9914
9915 * w32.c: Include <time.h>.
9916 (sys_localtime): New function.
9917
4ffd0d6b 99182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9919
9920 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9921
4ffd0d6b 9922 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9923
4ffd0d6b 99242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9925
4ffd0d6b
GM
9926 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9927 zombies (Bug#8467).
aac0c6e3 9928
04c56954
EZ
99292011-04-19 Eli Zaretskii <eliz@gnu.org>
9930
9931 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9932 gl_state.e_property when gl_state.object is Qt.
9933
9934 * insdel.c (make_gap_larger): Remove limitation of buffer size
9935 to <= INT_MAX.
9936
16a43933
CY
99372011-04-18 Chong Yidong <cyd@stupidchicken.com>
9938
9939 * xdisp.c (lookup_glyphless_char_display)
9940 (produce_glyphless_glyph): Handle cons cell entry in
9941 glyphless-char-display.
9942 (Vglyphless_char_display): Document it.
9943
9944 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9945 glyphless-char-display.
9946
4581706e
CY
99472011-04-17 Chong Yidong <cyd@stupidchicken.com>
9948
9949 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9950
9951 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9952
9953 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9954 definition for no-X builds.
9955
4887c6e2 99562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9957
fd35b6f9
PE
9958 Static checks with GCC 4.6.0 and non-default toolkits.
9959
5c1ccb01
PE
9960 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9961
006c5daa
PE
9962 * process.c (keyboard_bit_set): Define only if SIGIO.
9963 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9964 (send_process): Repair possible setjmp clobbering.
9965
efc736d3
PE
9966 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9967
4e2fe2e6
PE
9968 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9969
f97334a2
PE
9970 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9971
4e75f29d
PE
9972 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9973 Define only if needed.
9974
90efadd1
PE
9975 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9976 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9977 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9978
3c647824
PE
9979 * dispextern.h (struct redisplay_interface): Rename param
9980 to avoid shadowing.
e264f262 9981 * termhooks.h (struct terminal): Likewise.
761383f4 9982 * xterm.c (xembed_send_message): Likewise.
3c647824 9983
b58c5c4a
PE
9984 * insdel.c (make_gap_smaller): Define only if
9985 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9986
cad59032
PE
9987 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9988 it.
9989
c339dc2e
PE
9990 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9991 so that we aren't warned about unused symbols.
9992
91a3e27b
PE
9993 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9994
399c71d3 9995 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9996
8ffc96f5
PE
9997 * xfns.c (x_real_positions): Mark locals as initialized.
9998
eef9bc79
PE
9999 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10000
098db9dd
PE
10001 * xterm.c: Fix problems found by static analysis with other toolkits.
10002 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10003 (x_dispatch_event): Declare static if USE_GTK, and
10004 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10005 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10006 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10007 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10008 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10009
eb18f6cc
PE
10010 * xmenu.c (menu_help_callback): Pointer type fixes.
10011 Use const pointers when pointing at readonly data. Avoid pointer
10012 signedness clashes.
10013 (FALSE): Remove unused macro.
10014 (update_frame_menubar): Remove unused decl.
10015
1fe72bf8
PE
10016 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10017
60d9e1db
PE
10018 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10019 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10020 (single_menu_item): Rename local to avoid shadowing.
10021
39261c26
PE
10022 * keyboard.c (make_lispy_event): Remove unused local var.
10023
018c5e19
PE
10024 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10025 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10026
63d2b86e
PE
10027 * bitmaps: Change bitmaps from unsigned char back to the X11
10028 compatible char. Avoid the old compiler warnings about
10029 out-of-range initializers by using, for example, '\xab' rather
10030 than 0xab.
10031
aefd87e1
PE
10032 * xgselect.c (xgselect_initialize): Check vs interface
10033 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10034
bf501fb9
PE
10035 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10036
e9829fdf
PE
10037 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10038 to read-only memory.
10039
1086c095
PE
10040 * fns.c (vector): Remove; this old hack is no longer needed.
10041
2baccd04 10042 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10043 Remove unused var.
dde42981 10044 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10045
72391843 10046 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10047
436c16df 10048 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10049 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10050 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10051
92bb796d 10052 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10053 (x_term_init): Remove local to avoid shadowing.
92bb796d 10054
764430a3 10055 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10056
10057 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10058 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10059
d1dfb56c
EZ
100602011-04-16 Eli Zaretskii <eliz@gnu.org>
10061
c4354cb4
EZ
10062 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10063
d1dfb56c
EZ
10064 Fix regex.c, syntax.c and friends for buffers > 2GB.
10065 * syntax.h (struct gl_state_s): Declare character position members
10066 EMACS_INT.
10067
10068 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10069
04f2d78b
CB
10070 * textprop.c (verify_interval_modification, interval_of):
10071 Declare arguments EMACS_INT.
d1dfb56c
EZ
10072
10073 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10074 EMACS_INT.
10075
10076 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10077
10078 * indent.c (Fvertical_motion): Local variable it_start is now
10079 EMACS_INT.
10080
10081 * regex.c (re_match, re_match_2, re_match_2_internal)
10082 (bcmp_translate, regcomp, regexec, print_double_string)
10083 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10084 (re_compile_pattern, re_exec): Declare arguments and local
10085 variables `size_t' and `ssize_t' and return values `regoff_t', as
10086 appropriate.
10087 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10088 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10089 <compile_stack_type>: `size' and `avail' are now `size_t'.
10090
10091 * regex.h <regoff_t>: Use ssize_t, not int.
10092 (re_search, re_search_2, re_match, re_match_2): Arguments that
10093 specify buffer/string position and length are now ssize_t and
10094 size_t. Return type is regoff_t.
10095
613052cd
BK
100962011-04-16 Ben Key <bkey76@gmail.com>
10097
10098 * nsfont.m: Fixed bugs in ns_get_family and
10099 ns_descriptor_to_entity that were caused by using free to
10100 deallocate memory blocks that were allocated by xmalloc (via
10101 xstrdup). This caused Emacs to crash when compiled with
10102 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10103 --enable-checking=xmallocoverrun). xfree is now used to
10104 deallocate these memory blocks.
10105
4170f62f 101062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10107
71b41406
PE
10108 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10109
9587a89d
PE
10110 emacs_write: Accept and return EMACS_INT for sizes.
10111 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10112 et seq.
10113 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10114 Accept and return EMACS_INT.
10115 (emacs_gnutls_write): Return the number of bytes written on
10116 partial writes.
10117 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10118 (emacs_read, emacs_write): Remove check for negative size, as the
10119 Emacs source code has been audited now.
9587a89d
PE
10120 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10121 (emacs_read, emacs_write): Use it.
273a5f82
PE
10122 * process.c (send_process): Adjust to the new signatures of
10123 emacs_write and emacs_gnutls_write. Do not attempt to store
10124 a byte offset into an 'int'; it might overflow.
9587a89d 10125 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10126
3e047f51
PE
10127 * sound.c: Don't assume sizes fit in 'int'.
10128 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10129 Return EMACS_INT, not int.
3e047f51 10130 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10131 Accept EMACS_INT, not int.
10132 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10133 record read return values.
10134
cc39a9db
BK
101352011-04-15 Ben Key <bkey76@gmail.com>
10136
c9d0ec6d
JB
10137 * keyboard.c (Qundefined): Don't declare static since it is used
10138 in nsfns.m.
10139 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10140 static since they are used in nsfont.m.
cc39a9db 10141
6c60eb9f
SM
101422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10143
10144 * process.c (Qprocessp): Don't declare static.
10145 * lisp.h (Qprocessp): Declare again.
10146
7990b61a
JB
101472011-04-15 Juanma Barranquero <lekktu@gmail.com>
10148
10149 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10150
5d4cb038
PE
101512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10152
8bd7b830 10153 Improve C-level modularity by making more things 'static'.
cd64ea1d 10154
e3b27b31
PE
10155 Don't publish debugger-only interfaces to other modules.
10156 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10157 (verify_bytepos, count_markers): Move decls to the only modules
10158 that need them.
10159 * region-cache.h (pp_cache): Likewise.
10160 * window.h (check_all_windows): Likewise.
10161 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10162
5d4cb038
PE
10163 * sysdep.c (croak): Now static, if
10164 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10165 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10166
10167 * alloc.c (refill_memory_reserve): Now static if
10168 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10169 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10170
e87b6180
PE
10171 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10172 Define only if USE_LUCID.
10173
ac64929e
PE
10174 * xrdb.c (x_customization_string, x_rm_string): Now static.
10175
6f37259d
PE
10176 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10177 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10178
1683e3ab
PE
10179 * xdisp.c (draw_row_with_mouse_face): Now static.
10180 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10181
de9c2632
PE
10182 * window.h (check_all_windows): Mark externally visible.
10183
2b96acb7
PE
10184 * window.c (window_deletion_count): Now static.
10185
10186 * undo.c: Make symbols static if they're not exported.
10187 (last_undo_buffer, last_boundary_position, pending_boundary):
10188 Now static.
10189
50436f33
PE
10190 * textprop.c (interval_insert_behind_hooks): Now static.
10191 (interval_insert_in_front_hooks): Likewise.
10192
64520e5c
PE
10193 * term.c: Make symbols static if they're not exported.
10194 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10195 (max_frame_lines, tty_set_terminal_modes):
10196 (tty_reset_terminal_modes, tty_turn_off_highlight):
10197 (get_tty_terminal): Now static.
10198 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10199 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10200 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10201 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10202 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10203
1fa53021
PE
10204 * sysdep.c: Make symbols static if they're not exported.
10205 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10206 Now static.
10207 (sigprocmask_set, full_mask): Remove; unused.
10208 (wait_debugging): Mark as visible.
10209 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10210 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10211
d4b43b22
PE
10212 * syntax.c (syntax_temp): Define only if !__GNUC__.
10213
b7c513d0
PE
10214 * sound.c (current_sound_device, current_sound): Now static.
10215
989b29ad
PE
10216 * search.c (searchbufs, searchbuf_head): Now static.
10217
13a55a78
PE
10218 * scroll.c (scroll_cost): Remove; unused.
10219 * dispextern.h (scroll_cost): Remove decl.
10220
de68a1fc
PE
10221 * region-cache.h (pp_cache): Mark as externally visible.
10222
40ccffa6
PE
10223 * process.c: Make symbols static if they're not exported.
10224 (process_tick, update_tick, create_process, chan_process):
10225 (Vprocess_alist, proc_buffered_char, datagram_access):
10226 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10227 (deactivate_process): Mark defn as static, as well as decl.
10228 * lisp.h (create_process): Remove decl.
10229 * process.h (chan_process, Vprocess_alist): Remove decls.
10230
ad64fc97
PE
10231 * print.c: Make symbols static if they're not exported.
10232 (print_depth, new_backquote_output, being_printed, print_buffer):
10233 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10234 (print_interval, print_number_index, initial_stderr_stream):
10235 Now static.
10236 * lisp.h (Fprinc): Remove decl.
10237 (debug_output_compilation_hack): Mark as externally visible.
10238
adddb265
PE
10239 * sysdep.c (croak): Move decl from here to syssignal.h.
10240 * syssignal.h (croak): Put it here, so the API can be checked when
10241 'croak' is called from dissociate_if_controlling_tty.
10242
1717ede2
PE
10243 * minibuf.c: Make symbols static if they're not exported.
10244 (minibuf_save_list, choose_minibuf_frame): Now static.
10245 * lisp.h (choose_minibuf_frame): Remove decl.
10246
fa5fb2bc
PE
10247 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10248
1e3890d1
PE
10249 * lread.c: Make symbols static if they're not exported.
10250 (read_objects, initial_obarray, oblookup_last_bucket_number):
10251 Now static.
10252 (make_symbol): Remove; unused.
10253 * lisp.h (initial_obarray, make_symbol): Remove decls.
10254
8a1414fa
PE
10255 * keyboard.c: Make symbols static if they're not exported.
10256 (single_kboard, recent_keys_index, total_keys, recent_keys):
10257 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10258 (this_single_command_key_start, echoing, last_auto_save):
10259 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10260 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10261 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10262 (Vlispy_mouse_stem, double_click_count):
10263 Now static.
10264 (force_auto_save_soon): Define only if SIGDANGER.
10265 (ignore_mouse_drag_p): Now static if
10266 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10267 (print_help): Remove; unused.
10268 (stop_character, last_timer_event): Mark as externally visible.
10269 * keyboard.h (ignore_mouse_drag_p): Declare only if
10270 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10271 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10272 * lisp.h (echoing): Remove decl.
10273 (force_auto_save_soon): Declare only if SIGDANGER.
10274 * xdisp.c (redisplay_window): Simplify code, to make it more
10275 obvious that ignore_mouse_drag_p is not accessed if !defined
10276 USE_GTK && !defined HAVE_NS.
10277
93ea6e8f
PE
10278 * intervals.c: Make symbols static if they're not exported.
10279 (merge_properties_sticky, merge_interval_right, delete_interval):
10280 Now static.
10281 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10282
77382fcc
PE
10283 * insdel.c: Make symbols static if they're not exported.
10284 However, leave prepare_to_modify_buffer alone. It's never
10285 called from outside this function, but that appears to be a bug.
10286 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10287 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10288 (adjust_after_replace_noundo): Remove; unused.
10289 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10290 (signal_before_change): Remove decls.
77382fcc 10291
9306c32e
PE
10292 * indent.c (val_compute_motion, val_vmotion): Now static.
10293
cd44d2eb
PE
10294 * image.c: Make symbols static if they're not exported.
10295 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10296 if USE_GTK.
10297 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10298 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10299
ad9a7a06
PE
10300 * fringe.c (standard_bitmaps): Now static.
10301 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10302
81626931
PE
10303 * frame.c: Make symbols static if they're not exported.
10304 (x_report_frame_params, make_terminal_frame): Now static.
10305 (get_frame_param): Now static, unless HAVE_NS.
10306 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10307 (x_get_resource_string): Remove; not used.
10308 * frame.h (make_terminal_frame, x_report_frame_params):
10309 (x_get_resource_string); Remove decls.
10310 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10311 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10312
239f9db9
PE
10313 * font.c, fontset.c: Make symbols static if they're not exported.
10314 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10315 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10316 * font.c (font_close_object): Now static.
10317 * font.h (font_close_object): Remove.
10318 * fontset.c (FONTSET_OBJLIST): Remove.
10319 (free_realized_fontset) #if-0 the body, which does nothing.
10320 (face_suitable_for_char_p): #if-0, as it's never called.
10321 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10322 * xfaces.c (face_at_string_position):
10323 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10324 since 0 is always ASCII.
10325
dfcf3579
PE
10326 * fns.c (weak_hash_tables): Now static.
10327
5045092b
PE
10328 * fileio.c: Make symbols static if they're not exported.
10329 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10330 (Vwrite_region_annotation_buffers): Now static.
10331
57a96f5c
PE
10332 * eval.c: Make symbols static if they're not exported.
10333 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10334 * lisp.h (backtrace_list): Remove decl.
10335
35f08c38
PE
10336 * emacs.c: Make symbols static if they're not exported.
10337 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10338 (fatal_error_code, fatal_error_signal_hook, standard_args):
10339 Now static.
10340 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10341 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10342 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10343 * lisp.h (fatal_error_signal_hook): Remove decl.
10344 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10345
f44bd759
PE
10346 * editfns.c: Move a (normally-unused) function to its only use.
10347 * editfns.c, lisp.h (get_operating_system_release): Remove.
10348 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10349 worth the hassle of breaking this out.
10350
b532497d
PE
10351 * xterm.c: Make symbols static if they're not exported.
10352 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10353 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10354 (x_destroy_window, x_delete_display):
10355 Now static.
10356 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10357 (x_mouse_leave): Remove; unused.
10358 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10359 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10360 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10361 Remove decls.
10362 (x_mouse_leave): Declare only if WINDOWSNT.
10363 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10364 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10365 USE_X_TOOLKIT.
10366
1675728f
PE
10367 * ftxfont.c: Make symbols static if they're not exported.
10368 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10369 HAVE_FREETYPE.
10370 * font.h (ftxfont_driver): Likewise.
10371
e4cebfca
PE
10372 * xfns.c: Make symbols static if they're not exported.
10373 (x_last_font_name, x_display_info_for_name):
10374 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10375 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10376 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10377 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10378 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10379 (last_show_tip_args): Now static.
10380 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10381 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10382 (x_screen_planes): Remove; unused.
10383 * dispextern.h (x_screen_planes): Remove decl.
10384
5bf46f05
PE
10385 * dispnew.c: Make symbols static if they're not exported.
10386 * dispextern.h (redraw_garbaged_frames, scrolling):
10387 (increment_row_positions): Remove.
10388 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10389 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10390 Now static.
10391 (redraw_garbaged_frames): Remove; unused.
10392
435f4c28
PE
10393 * xfaces.c: Make symbols static if they're not exported.
10394 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10395 Remove decls.
10396 * xterm.h (defined_color): Remove decls.
10397 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10398 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10399 (menu_face_changed_default, defined_color, free_realized_face):
10400 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10401 (ascii_face_of_lisp_face): Remove; unused.
10402
8524aef3
PE
10403 * xdisp.c: Make symbols static if they're not exported.
10404 * dispextern.h (scratch_glyph_row, window_box_edges):
10405 (glyph_to_pixel_coords, set_cursor_from_row):
10406 (get_next_display_element, set_iterator_to_next):
10407 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10408 (show_mouse_face): Remove decls
10409 * frame.h (message_buf_print): Likewise.
10410 * lisp.h (pop_message, set_message, check_point_in_composition):
10411 Likewise.
10412 * xterm.h (set_vertical_scroll_bar): Likewise.
10413 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10414 (message_buf_print, scratch_glyph_row, displayed_buffer):
10415 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10416 (get_next_display_element, show_mouse_face, window_box_edges):
10417 (frame_to_window_pixel_xy, check_point_in_composition):
10418 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10419 (glyph_to_pixel_coords): Remove; unused.
10420
16390cd2
PE
10421 * dired.c (file_name_completion): Now static.
10422
10423 * dbusbind.c (xd_in_read_queued_messages): Now static.
10424
a25f4dfa
PE
10425 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10426 * data.c (circular_list_error): Remove.
10427
14a9c8df
PE
10428 * commands.h (last_point_position, last_point_position_buffer):
10429 (last_point_position_window): Remove decls.
10430 * keyboard.c: Make these variables static.
10431
04f2d78b
CB
10432 * coding.h (coding, code_convert_region, encode_coding_gap):
10433 Remove decls.
74ab6df5
PE
10434 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10435 (iso_code_class, detect_coding, code_convert_region): Now static.
10436 (encode_coding_gap): Remove; unused.
10437
38dfbee1
PE
10438 * chartab.c (chartab_chars, chartab_bits): Now static.
10439
a2cb4e63
PE
10440 * charset.h (charset_iso_8859_1): Remove decl.
10441 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10442 Now static.
10443
127198fd
PE
10444 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10445 * ccl.c (Vccl_program_table): Now static.
10446 (check_ccl_update): Remove; unused.
10447
d85b608f
PE
10448 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10449 * category.h: ... from here.
10450 * category.c (check_category_table, set_category_set): Now static.
10451
31cd66f3
PE
10452 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10453 * lisp.h: Remove these decls.
10454
c358e587
PE
10455 * buffer.c (buffer_count): Remove unused var.
10456
e78aecca
PE
10457 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10458 so that it's not optimized away.
10459 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10460 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10461 exported only to the debugger.
10462
e192d7d3 10463 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10464 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10465
92470028
PE
10466 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10467 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10468 was inaccessible from Lisp.
10469 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10470 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10471
244ed907
PE
10472 alloc.c: Import and export fewer symbols, and remove unused items.
10473 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10474 is defined.
10475 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10476 it's not optimized away by whole-program optimization.
10477 (message_enable_multibyte, free_misc): Remove.
10478 (catchlist, handlerlist, mark_backtrace):
10479 Declare only if BYTE_MARK_STACK.
10480 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10481 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10482 (message_enable_multibyte): Remove decl.
10483 (free_misc, interval_free_list, float_block, float_block_index):
10484 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10485 (cons_free_list, last_marked_index):
10486 Now static.
10487 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10488 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10489 (mark_backtrace): Define only if BYTE_MARK_STACK.
10490 * xdisp.c (message_enable_multibyte): Now static.
10491
61c2b50e 10492 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10493 This makes it easier for human readers (and static analyzers)
10494 to see whether these variables are used from other modules.
10495 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10496 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10497 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10498 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10499 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10500 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10501 * xmenu.c, xselect.c:
10502 Declare Q* vars static if they are not used in other modules.
10503 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10504 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10505 Remove decls of unexported vars.
10506 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10507
95c82688
PE
10508 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10509
16a97296
PE
10510 Make Emacs functions such as Fatom 'static' by default.
10511 This makes it easier for human readers (and static analyzers)
10512 to see whether these functions can be called from other modules.
10513 DEFUN now defines a static function. To make the function external
10514 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10515 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10516 (Finit_image_library):
16a97296
PE
10517 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10518 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10519 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10520 Remove decls, since these functions are now static.
10521 (Funintern, Fget_internal_run_time): New decls, since these functions
10522 were already external.
95c82688 10523
16a97296
PE
10524 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10525 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10526 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10527 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10528 * keyboard.c, keymap.c, lread.c:
10529 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10530 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10531 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10532 Mark functions with DEFUE instead of DEFUN,
10533 if they are used in other modules.
10534 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10535 decls for now-static functions.
10536 * buffer.h (Fdelete_overlay): Remove decl.
10537 * callproc.c (Fgetenv_internal): Mark as internal.
10538 * composite.c (Fremove_list_of_text_properties): Remove decl.
10539 (Fcomposition_get_gstring): New forward static decl.
10540 * composite.h (Fcomposite_get_gstring): Remove decl.
10541 * dired.c (Ffile_attributes): New forward static decl.
10542 * doc.c (Fdocumntation_property): New forward static decl.
10543 * eval.c (Ffetch_bytecode): New forward static decl.
10544 (Funintern): Remove extern decl; now in .h file where it belongs.
10545 * fileio.c (Fmake_symbolic_link): New forward static decl.
10546 * image.c (Finit_image_library): New forward static decl.
10547 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10548 * intervals.h (Fprevious_property_change):
10549 (Fremove_list_of_text_properties): Remove decls.
10550 * keyboard.c (Fthis_command_keys): Remove decl.
10551 (Fcommand_execute): New forward static decl.
10552 * keymap.c (Flookup_key): New forward static decl.
10553 (Fcopy_keymap): Now static.
10554 * keymap.h (Flookup_key): Remove decl.
10555 * process.c (Fget_process): New forward static decl.
10556 (Fprocess_datagram_address): Mark as internal.
10557 * syntax.c (Fsyntax_table_p): New forward static decl.
10558 (skip_chars): Remove duplicate decl.
10559 * textprop.c (Fprevious_property_change): New forward static decl.
10560 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10561 Now internal.
10562 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10563 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10564
785bbd42
PE
10565 * editfns.c (Fformat): Remove unreachable code.
10566
8b913b57
AS
105672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10568
10569 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10570 change. (Bug#8496)
10571
a6744a35
EZ
105722011-04-13 Eli Zaretskii <eliz@gnu.org>
10573
10574 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10575 when at ZV. (Bug#8487)
10576
e7974947
AS
105772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10578
baad03f0
AS
10579 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10580 (Bug#8437)
10581 * keyboard.c (parse_tool_bar_item): Likewise.
10582 * sound.c (sound_cleanup, alsa_close): Likewise.
10583 * termcap.c (tgetent): Likewise.
10584 * xfns.c (x_default_font_parameter): Likewise.
10585 * xsettings.c (read_and_apply_settings): Likewise.
10586
e7974947
AS
10587 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10588 (overrun_check_free): Protoize.
10589
28272684
PE
105902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10591
10592 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10593 since callers should never pass a negative size.
10594 Change the signature to match that of plain 'read' and 'write'; see
10595 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10596 * lisp.h: Update prototypes of emacs_write and emacs_read.
10597
11997c76
EZ
105982011-04-11 Eli Zaretskii <eliz@gnu.org>
10599
10600 * xdisp.c (redisplay_window): Don't try to determine the character
10601 position of the scroll margin if the window start point w->startp
e896f03c 10602 is outside the buffer's accessible region. (Bug#8468)
11997c76 10603
8a2cbd72
EZ
106042011-04-10 Eli Zaretskii <eliz@gnu.org>
10605
10606 Fix write-region and its subroutines for buffers > 2GB.
10607 * fileio.c (a_write, e_write): Modify declaration of arguments and
10608 local variables to support buffers larger than 2GB.
10609 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10610
10611 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10612 argument, local variables, and return value.
10613
10614 * lisp.h: Update prototypes of emacs_write and emacs_read.
10615
10616 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10617
4073e537 106182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10619
1ebfdcb6
PE
10620 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10621
b2ded58d
PE
10622 Fix more problems found by GCC 4.6.0's static checks.
10623
7d66342c
PE
10624 * xdisp.c (vmessage): Use a better test for character truncation.
10625
bbf47d44
PE
10626 * charset.c (load_charset_map): <, not <=, for optimization,
10627 and to avoid potential problems with integer overflow.
9248994d 10628 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10629 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10630 * editfns.c (Fformat): Likewise.
1e69125e 10631 * syntax.c (skip_chars): Likewise.
3befa583 10632
e3019616
PE
10633 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10634 This also lets GCC 4.6.0 generate slightly better loop code.
10635
becfa255
PE
10636 * callint.c (Fcall_interactively): <, not <=, for optimization.
10637 (Fcall_interactively): Count the number of arguments produced,
10638 not the number of arguments given. This is simpler and lets GCC
10639 4.6.0 generate slightly better code.
10640
dae0cd48
PE
10641 * ftfont.c: Distingish more carefully between FcChar8 and char.
10642 The previous code passed unsigned char * to a functions like
10643 strlen and xstrcasecmp that expect char *, which does not
10644 conform to the C standard.
10645 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10646 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10647 char * when the C standard requires it.
10648
76032d70
PE
10649 * keyboard.c (read_char): Remove unused var.
10650
eb3f1cc8
PE
10651 * eval.c: Port to Windows vsnprintf (Bug#8435).
10652 Include <limits.h>.
10653 (SIZE_MAX): Define if the headers do not.
10654 (verror): Do not give up if vsnprintf returns a negative count.
10655 Instead, grow the buffer. This ports to Windows vsnprintf, which
10656 does not conform to C99. Problem reported by Eli Zaretskii.
10657 Also, simplify the allocation scheme, by avoiding the need for
10658 calling realloc, and removing the ALLOCATED variable.
10659
70476b54
PE
10660 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10661
12020a9e
PE
10662 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10663 But keep the doprint source code for now, as we might revamp it
10664 and use it again (Bug#8435).
ea6c7ae6
PE
10665 * lisp.h (doprnt): Remove.
10666 * Makefile.in (base_obj): Remove doprnt.o.
10667 * deps.mk (doprnt.o): Remove.
10668
5fdb398c
PE
10669 error: Print 32- and 64-bit integers portably (Bug#8435).
10670 Without this change, on typical 64-bit hosts error ("...%d...", N)
10671 was used to print both 32- and 64-bit integers N, which relied on
10672 undefined behavior.
61bdb816 10673 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10674 * lisp.h (error, verror): Mark as printf-like functions.
10675 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10676 Report overflow in size calculations when allocating printf buffer.
10677 Do not truncate output string at its first null byte.
10678 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10679 Truncate the output at a character boundary, since vsnprintf does not
10680 do that.
10681 * charset.c (check_iso_charset_parameter): Convert internal
10682 character to string before calling 'error', since %c now has the
10683 printf meaning.
10684 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10685 overflow when computing char to be passed to 'error'. Do not
10686 pass Lisp_Object to 'error'; pass the integer instead.
10687 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10688 formatted with plain %d.
10689
b189fa66
PE
10690 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10691
bff87ef0
PE
10692 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10693
7e2cac20
PE
10694 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10695
ce4d90b5
PE
10696 * xterm.c (x_catch_errors): Remove duplicate declaration.
10697
266c9547
PE
10698 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10699
79c49ad2
PE
10700 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10701
368f4090
JM
107022011-04-10 Jim Meyering <meyering@redhat.com>
10703
10704 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10705 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10706 return ssize_t not "int", and use size_t as the buffer length.
10707 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10708 * gnutls.h: Update declarations.
10709 * process.c (read_process_output): Use ssize_t, to match.
10710 (send_process): Likewise.
10711
a32d4040
CY
107122011-04-09 Chong Yidong <cyd@stupidchicken.com>
10713
10714 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10715
8546720e 107162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10717
04f2d78b
CB
10718 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10719 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10720
8546720e
GM
10721 * xterm.c (handle_one_xevent):
10722 * xmenu.c (create_and_show_popup_menu):
10723 * xselect.c (x_decline_selection_request)
10724 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10725
0a2f5c1a 107262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10727
10728 Fix some uses of `int' instead of EMACS_INT.
10729 * search.c (string_match_1, fast_string_match)
10730 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10731 (scan_buffer, find_next_newline_no_quit)
10732 (find_before_next_newline, search_command, Freplace_match)
10733 (Fmatch_data): Make some `int' variables be EMACS_INT.
10734
10735 * xdisp.c (display_count_lines): 3rd argument and return value now
10736 EMACS_INT. All callers changed.
10737 (pint2hrstr): Last argument is now EMACS_INT.
10738
10739 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10740 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10741 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10742 (decode_coding_utf_16, decode_coding_emacs_mule)
10743 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10744 (decode_coding_ccl, decode_coding_charset)
10745 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10746 (decode_coding_iso_2022, decode_coding_emacs_mule)
10747 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10748 <char_offset, last_offset>: Declare EMACS_INT.
10749 (encode_coding_utf_8, encode_coding_utf_16)
10750 (encode_coding_emacs_mule, encode_invocation_designation)
10751 (encode_designation_at_bol, encode_coding_iso_2022)
10752 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10753 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10754 Declare EMACS_INT.
10755 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10756 (encode_invocation_designation): Last argument P_NCHARS is now
10757 EMACS_INT.
10758 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10759 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10760
10761 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10762 All users changed.
10763
10764 * ccl.c (Fccl_execute_on_string): Declare some variables
10765 EMACS_INT.
10766
8546720e 107672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10768
10769 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10770
4e19a977
CS
107712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10772
10773 * process.c (Fformat_network_address): Doc fix.
10774
87302331
R
107752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10776
ee7683eb 10777 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10778
cbb59342
CY
107792011-04-08 Chong Yidong <cyd@stupidchicken.com>
10780
10781 * keyboard.c (read_char): Call Lisp function help-form-show,
10782 instead of using internal_with_output_to_temp_buffer.
10783 (Qhelp_form_show): New var.
e0d38eeb 10784 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10785
10786 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10787
10788 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10789
e67a13ab
CY
107902011-04-06 Chong Yidong <cyd@stupidchicken.com>
10791
04f2d78b
CB
10792 * process.c (Flist_processes): Remove to Lisp.
10793 (list_processes_1): Delete.
e67a13ab 10794
973f782d
EZ
107952011-04-06 Eli Zaretskii <eliz@gnu.org>
10796
7c106b1e
EZ
10797 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10798
973f782d
EZ
10799 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10800
41cf7d1a 108012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10802
ca23cc88
PE
10803 Fix more problems found by GCC 4.6.0's static checks.
10804
f390e2d5
PE
10805 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10806
42eea0d0
PE
10807 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10808
b69769da 10809 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10810
f9541e84
PE
10811 * xdisp.c (vmessage): Mark as a printf-like function.
10812
13841b55
PE
10813 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10814
c136c10f
PE
10815 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10816
5e2d4a30
PE
10817 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10818 printf-like functions.
10819 (tiff_load): Add casts to remove these marks before passing them
10820 to system-supplied API.
10821
583f48b9
PE
10822 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10823
b25d760e
PE
10824 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10825 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10826 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10827 directly, rather than having caller test rule sign. This avoids
10828 some unnecessary tests.
10829 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10830 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10831 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10832
bc7b6697 10833 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10834 (xfont_open): Avoid unnecessary tests.
bc7b6697 10835
27ccc379
PE
10836 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10837
dcd5c89a
PE
10838 * composite.h, composite.c (composition_gstring_put_cache):
10839 Use EMACS_INT, not int, for length.
10840
b13a45c6
PE
10841 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10842 breaking out part of COMPOSITION_DECODE_RULE.
10843 (COMPOSITION_DECODE_RULE): Use it.
10844 * composite.c (get_composition_id): Remove unused local vars,
10845 by using the new macro.
10846
1e792e4d
PE
10847 * textprop.c (set_text_properties_1): Change while to do-while,
10848 since the condition is always true at first.
10849
dc6c6455 10850 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10851 (interval_deletion_adjustment): Return unsigned value.
10852 All uses changed.
dc6c6455 10853
aba7731a
PE
10854 * process.c (list_processes_1, create_pty, read_process_output):
10855 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10856 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10857 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10858 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10859 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10860
fdfc4bf3
PE
10861 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10862
fca8fe46 10863 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10864 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10865
06a0259a 10866 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10867 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10868 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10869
e7b9e80f
PE
10870 * print.c (print_error_message): Avoid int overflow.
10871
56201685
PE
10872 * font.c (font_list_entities): Redo for clarity,
10873 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10874
78834453 10875 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10876 (font_score): Avoid potential overflow in diff calculation.
78834453 10877
0bc0b309 10878 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10879 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10880
e610eaca
PE
10881 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10882
b895abce
PE
10883 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10884 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10885 can always succeed if overflow has undefined behavior.
10886
1f1d9321 10887 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10888 (wordify): Omit three unnecessary tests.
1f1d9321 10889
c59478bc
PE
10890 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10891 All callers changed. This avoids the need for an unused var.
10892
79b73827
PE
10893 * casefiddle.c (casify_region): Remove var that is set but not used.
10894
a4db5dfe
PE
10895 * dired.c (file_name_completion): Remove var that is set but not used.
10896
43aae36e
PE
10897 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10898
2a47c44d 10899 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10900 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10901
a37c69bf
PE
10902 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10903 Check for integer overflow on size calculations.
10904
328ab8e7
PE
10905 * buffer.c (Fprevious_overlay_change): Remove var that is set
10906 but not used.
10907
e5a2a5cb
PE
10908 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10909 Remove vars that are set but not used.
8d84a6eb 10910 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10911 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10912
a60e5f68
PE
10913 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10914
f661cb61 10915 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10916 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10917
f0397f5a
PE
10918 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10919 that are set but not used.
10920
8664db06 10921 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10922 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10923
6abdaa4a
PE
10924 * xselect.c (x_get_local_selection, x_handle_property_notify):
10925 Remove vars that are set but not used.
10926
0ce7538d 10927 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10928 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10929
9ae848fc
PE
10930 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10931 Remove var that is set but not used.
0b918413
PE
10932 (scroll_bar_windows_size): Now size_t, not int.
10933 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10934 Check for overflow.
9ae848fc 10935
a5a62657
PE
10936 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10937 (map_tty_color) [!defined MSDOS]: Likewise.
10938
5c5cdd39
PE
10939 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10940
66ebf983
PE
10941 * coding.c: Remove vars that are set but not used.
10942 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10943 All callers changed.
10944 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10945 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10946 (decode_coding_charset): Remove vars that are set but not used.
10947
1be4d761
PE
10948 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10949 that is set but not used.
10950
47553fa8
PE
10951 * print.c (print_object): Remove var that is set but not used.
10952
1f7196bf 10953 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10954 The gnulib version avoids calling malloc in the usual case,
10955 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10956 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10957 * filelock.c (current_lock_owner): Likewise.
10958 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10959 * sysdep.c: Include allocator.h, careadlinkat.h.
10960 (emacs_no_realloc_allocator): New static constant.
10961 (emacs_readlink): New function.
fdb61804
PE
10962 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10963 ../lib/careadlinkat.h.
d1fdcab7 10964
f84c17c7
SM
109652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10966
10967 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10968 first non-nil return value).
10969
ef3862ad
JD
109702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10971
10972 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10973 if not defined (Bug#8403).
10974
376a7006
JB
109752011-04-02 Juanma Barranquero <lekktu@gmail.com>
10976
10977 * xdisp.c (display_count_lines): Remove parameter `start',
10978 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10979 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10980 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10981 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10982 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10983 and thereabouts. All callers changed.
10984 (get_per_char_metric): Remove parameter `f', unused since
10985 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10986
6ca3801d
JM
109872011-04-02 Jim Meyering <meyering@redhat.com>
10988
10989 do not dereference NULL upon failed strdup
10990 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10991 (ns_get_family): Likewise.
10992
d8e2b5ba
JB
109932011-04-02 Juanma Barranquero <lekktu@gmail.com>
10994
10995 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10996
8c74fcbd
JD
109972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10998
10999 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11000 later (Bug#8403).
11001
7200d79c
SM
110022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11003
03408648 11004 Add lexical binding.
7200d79c 11005
03408648
SM
11006 * window.c (Ftemp_output_buffer_show): New fun.
11007 (Fsave_window_excursion):
11008 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11009
11010 * lread.c (lisp_file_lexically_bound_p): New function.
11011 (Fload): Bind Qlexical_binding.
11012 (readevalloop): Remove `evalfun' arg.
11013 Bind Qinternal_interpreter_environment.
11014 (Feval_buffer): Bind Qlexical_binding.
11015 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11016 Mark as dynamic.
11017 (syms_of_lread): Declare `lexical-binding'.
11018
11019 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11020
11021 * keyboard.c (eval_dyn): New fun.
11022 (menu_item_eval_property): Use it.
ca105506
SM
11023
11024 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11025
03408648
SM
11026 * fns.c (concat, mapcar1): Accept byte-code-functions.
11027
11028 * eval.c (Fsetq): Handle lexical vars.
11029 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11030 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11031 (FletX, Flet): Obey lexical binding.
11032 (Fcommandp): Handle closures.
11033 (Feval): New `lexical' arg.
11034 (eval_sub): New function extracted from Feval. Use it almost
11035 everywhere where Feval was used. Look up vars in lexical env.
11036 Handle closures.
11037 (Ffunctionp): Move from subr.el.
11038 (Ffuncall): Handle closures.
11039 (apply_lambda): Remove `eval_flags'.
11040 (funcall_lambda): Handle closures and new byte-code-functions.
11041 (Fspecial_variable_p): New function.
11042 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11043 but without exporting it to Lisp.
23aba0ea 11044
23aba0ea 11045 * doc.c (Fdocumentation, store_function_docstring):
03408648 11046 * data.c (Finteractive_form): Handle closures.
23aba0ea 11047
03408648
SM
11048 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11049 interactive spec.
ba83908c 11050
04f2d78b
CB
11051 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11052 New byte-codes.
03408648
SM
11053 (exec_byte_code): New function extracted from Fbyte_code to handle new
11054 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11055
03408648 11056 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11057
03408648 11058 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11059
e2abce01
JB
110602011-03-31 Juanma Barranquero <lekktu@gmail.com>
11061
11062 * xdisp.c (redisplay_internal): Fix prototype.
11063
63696a73 110642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11065
63696a73 11066 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11067 (try_scrolling): Use it when setting scroll_limit.
11068 Limit scrolling to 100 screen lines.
63696a73
EZ
11069 (redisplay_window): Even when falling back on "recentering",
11070 position point in the window according to scroll-conservatively,
11071 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11072
11073 (try_scrolling): When point is above the window, allow searching
11074 as far as scroll_max, or one screenful, to compute vertical
11075 distance from PT to the scroll margin position. This prevents
11076 try_scrolling from unnecessarily failing when
11077 scroll-conservatively is set to a value slightly larger than the
11078 window height. Clean up the case of PT below the margin at bottom
11079 of window: scroll_max can no longer be INT_MAX. When aggressive
11080 scrolling is in use, don't let point enter the opposite scroll
11081 margin as result of the scroll.
11082 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11083 threshold of 100 lines for never-recentering scrolling.
11084
e4cc2dfc
JB
110852011-03-31 Juanma Barranquero <lekktu@gmail.com>
11086
11087 * dispextern.h (move_it_by_lines):
11088 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11089 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11090 (message_log_check_duplicate): Remove parameters `prev_bol' and
11091 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11092 (redisplay_internal): Remove parameter `preserve_echo_area',
11093 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11094
11095 * indent.c (Fvertical_motion):
11096 * window.c (window_scroll_pixel_based, Frecenter):
11097 Don't pass `need_y_p' to `move_it_by_lines'.
11098
1c470562
SM
110992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11100
44f230aa
SM
11101 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11102 steal a few bits to be more compact.
11103 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11104 Remove unneeded casts.
11105
1c470562
SM
11106 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11107
888adce9
ZK
111082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11109
11110 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11111 binding" message (bug#7967).
11112
f838ed7b
PE
111132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11114
77861b95
PE
11115 Fix more problems found by GCC 4.6.0's static checks.
11116
de6dbc14
PE
11117 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11118 Remove unused local var.
11119
f838ed7b
PE
11120 * editfns.c (Fmessage_box): Remove unused local var.
11121
792c7b2b
PE
11122 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11123 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11124 Omit unused local vars.
c499e557 11125 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11126 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11127 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11128 Omit unused local var.
11129
ba0165e1
PE
11130 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11131 Don't assume string length fits in int.
32ad8845 11132 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11133 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11134
3c59b4c9
PE
11135 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11136 instead of alloca (Bug#8344).
11137
a3eed478 11138 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11139 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11140
eb4d412d
PE
11141 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11142
1658b401
PE
11143 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11144 concerns.
11145
11146 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11147
11148 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11149
9a2c6e05
PE
11150 * keyboard.c (syms_of_keyboard): Use the same style as later
11151 in this function when indexing through an array. This also
11152 works around GCC bug 48267.
11153
03d0a109
PE
11154 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11155
44f730c8
PE
11156 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11157
fe75f926
PE
11158 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11159 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11160
ffa8c828
PE
11161 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11162 This avoids undefined behavior on integer overflow, and is a bit
11163 more convenient anyway since it is compared to a size_t variable.
11164
c5101a77
PE
11165 Variadic C functions now count arguments with size_t, not int.
11166 This avoids an unnecessary limitation on 64-bit machines, which
11167 caused (substring ...) to crash on large vectors (Bug#8344).
11168 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11169 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11170 All variadic functions and their callers changed accordingly.
c5101a77
PE
11171 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11172 * data.c (arith_driver, float_arith_driver): Likewise.
11173 * editfns.c (general_insert_function): Likewise.
11174 * eval.c (struct backtrace.nargs, interactive_p)
11175 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11176 (funcall_lambda, mark_backtrace): Likewise.
11177 * fns.c (concat): Likewise.
11178 * frame.c (x_set_frame_parameters): Likewise.
11179 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11180 0 if not found, not -1. All callers changed.
11181
dd3f25f7
PE
11182 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11183 (stack_copy_size): Now size_t, not int.
11184 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11185
461c2ab9
JB
111862011-03-28 Juanma Barranquero <lekktu@gmail.com>
11187
11188 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11189 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11190 All callers changed.
11191
11192 * lisp.h (multibyte_char_to_unibyte):
11193 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11194 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11195 * character.h (CHAR_TO_BYTE8):
11196 * cmds.c (internal_self_insert):
11197 * editfns.c (general_insert_function):
11198 * keymap.c (push_key_description):
11199 * search.c (Freplace_match):
11200 * xdisp.c (message_dolog, set_message_1): All callers changed.
11201
f6d62986
SM
112022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11203
11204 * keyboard.c (safe_run_hook_funcall): New function.
11205 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11206 don't set the hook to nil, but remove the offending function instead.
11207 (Qcommand_hook_internal): Remove, unused.
11208 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11209 Vcommand_hook_internal.
11210
11211 * eval.c (enum run_hooks_condition): Remove.
11212 (funcall_nil, funcall_not): New functions.
11213 (run_hook_with_args): Call each function through a `funcall' argument.
11214 Remove `cond' argument, now redundant.
11215 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11216 (Frun_hook_with_args_until_failure): Adjust accordingly.
11217 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11218
1db5b1ad
JB
112192011-03-28 Juanma Barranquero <lekktu@gmail.com>
11220
11221 * dispextern.h (string_buffer_position): Remove declaration.
11222
11223 * print.c (strout): Remove parameter `multibyte', unused since
11224 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11225
11226 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11227 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11228 All callers changed.
11229
11230 * w32.c (_wsa_errlist): Use braces for struct initializers.
11231
11232 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11233 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11234 All callers changed.
11235 (string_buffer_position): Likewise. Also, make static (it's never
11236 used outside xdisp.c).
11237 (cursor_row_p): Remove parameter `w', unused since
11238 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11239 (decode_mode_spec): Remove parameter `precision', introduced during
11240 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11241 All callers changed.
11242
5ffb62aa
JD
112432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11244
11245 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11246
461c2ab9 112472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11248
11249 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11250 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11251 (ns_update_auto_hide_menu_bar): New functions.
11252 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11253 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11254 ns_constrain_all_frames.
11255 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11256 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11257
5c380ffb
JD
112582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11259
11260 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11261
9af30bdf
GM
112622011-03-27 Glenn Morris <rgm@gnu.org>
11263
11264 * syssignal.h: Replace RETSIGTYPE with void.
11265 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11266 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11267 Replace SIGTYPE with void everywhere.
11268 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11269 * s/template.h (SIGTYPE): Remove commented out definition.
11270
e2abce01
JB
112712011-03-26 Eli Zaretskii <eliz@gnu.org>
11272
11273 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11274 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11275
f868cd8a
JB
112762011-03-26 Juanma Barranquero <lekktu@gmail.com>
11277
59eb0929
JB
11278 * w32.c (read_unc_volume): Use parameter `henum', instead of
11279 global variable `wget_enum_handle'.
11280
11281 * keymap.c (describe_vector): Remove parameters `indices' and
11282 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11283 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11284
f868cd8a
JB
11285 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11286
11287 * keyboard.c (timer_check): Remove parameter `do_it_now',
11288 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11289 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11290 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11291
11292 * keyboard.c (read_char):
11293 * w32menu.c (w32_menu_display_help):
11294 * xmenu.c (show_help_event, menu_help_callback):
11295 Adjust calls to `show_help_echo'.
11296
11297 * gtkutil.c (xg_maybe_add_timer):
11298 * keyboard.c (readable_events):
11299 * process.c (wait_reading_process_output):
11300 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11301
11302 * insdel.c (adjust_markers_gap_motion):
11303 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11304 (gap_left, gap_right): Don't call it.
11305
2ecf6fdb
CY
113062011-03-25 Chong Yidong <cyd@stupidchicken.com>
11307
11308 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11309 incurred during fontification.
11310
6b1f9ba4
JB
113112011-03-25 Juanma Barranquero <lekktu@gmail.com>
11312
11313 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11314 (DEFVAR_PER_BUFFER): Don't pass it.
11315
11316 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11317 (scrolling_window): Don't pass it.
11318
0f4a96b5
JB
113192011-03-25 Juanma Barranquero <lekktu@gmail.com>
11320
11321 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11322
11323 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11324 and `suffix'.
11325 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11326 of variables specific to SELinux and computation of `encoded_absname'.
11327
11328 * image.c (XPutPixel): Remove unused variable `height'.
11329
11330 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11331
11332 * unexw32.c (get_section_info): Remove unused variable `section'.
11333
11334 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11335 (system_process_attributes): Remove unused variable `sess'.
11336 (sys_read): Remove unused variable `err'.
11337
11338 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11339 (w32_wnd_proc): Remove unused variable `isdead'.
11340 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11341 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11342 (x_create_tip_frame): Remove unused variable `tem'.
11343
11344 * w32inevt.c (w32_console_read_socket):
11345 Remove unused variable `no_events'.
11346
11347 * w32term.c (x_draw_composite_glyph_string_foreground):
11348 Remove unused variable `width'.
11349
1149507c
JB
113502011-03-24 Juanma Barranquero <lekktu@gmail.com>
11351
11352 * w32term.c (x_set_glyph_string_clipping):
11353 Don't pass uninitialized region to CombineRgn.
11354
9c88f339
JB
113552011-03-23 Juanma Barranquero <lekktu@gmail.com>
11356
11357 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11358 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11359 (Fx_close_connection): Remove unused variable `i'.
11360
11361 * w32font.c (w32font_draw): Return number of glyphs.
11362 (w32font_open_internal): Remove unused variable `i'.
11363 (w32font_driver): Add missing initializer.
11364
11365 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11366 (fill_in_menu): Remove unused variable `items_added'.
11367
11368 * w32term.c (last_mouse_press_frame): Remove static global variable.
11369 (w32_clip_to_row): Remove unused variable `f'.
11370 (x_delete_terminal): Remove unused variable `i'.
11371
11372 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11373 (NOTHING): Remove unused static global variable.
11374 (uniscribe_check_otf): Remove unused variable `table'.
11375 (uniscribe_font_driver): Add missing initializers.
11376
dee091a3
JD
113772011-03-23 Julien Danjou <julien@danjou.info>
11378
11379 * term.c (Fsuspend_tty, Fresume_tty):
11380 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11381 * window.c (temp_output_buffer_show):
11382 * insdel.c (signal_before_change):
11383 * frame.c (Fhandle_switch_frame):
11384 * fileio.c (Fdo_auto_save):
11385 * emacs.c (Fkill_emacs):
11386 * editfns.c (save_excursion_restore):
11387 * cmds.c (internal_self_insert):
11388 * callint.c (Fcall_interactively):
11389 * buffer.c (Fkill_all_local_variables):
11390 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11391 Use Frun_hooks.
0f4a96b5 11392 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11393 unconditionally since it does the check itself.
dee091a3 11394
2c520ab5 113952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11396
c9c49752
PE
11397 Fix more problems found by GCC 4.5.2's static checks.
11398
8abc3f12
PE
11399 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11400 the first time through the loop, since we know p0 < p1 then.
11401 This also avoids a gcc -Wstrict-overflow warning.
11402
a2d26660
PE
11403 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11404 leading to a memory leak, possible in functions like
11405 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11406 of objects (Bug#8318).
a2d26660 11407
916c72e9
PE
11408 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11409 that could (at least in theory) be that large.
11410
19ab8a18
PE
11411 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11412 This is less likely to overflow, and avoids undefined behavior if
11413 overflow does occur. All callers changed. Use strtoul to scan
11414 for the unsigned long integer.
b7cbbd6f
PE
11415 (pint2hrstr): Simplify and tune code slightly.
11416 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11417
f0641eff
PE
11418 * scroll.c (do_scrolling): Work around GCC bug 48228.
11419 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11420
7f650bb9
PE
11421 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11422 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11423 (validate_x_resource_name): Simplify count usage.
11424 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11425
37dd57d1
PE
11426 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11427 fail (Bug#8306).
81e56e61 11428
699979fc 11429 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11430
401bf9b4
PE
11431 * process.c (Fmake_network_process): Use socklen_t, not int,
11432 where POSIX says socklen_t is required in portable programs.
11433 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11434 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11435 (Fmake_network_process, server_accept_connection):
11436 (wait_reading_process_output, read_process_output):
11437 Likewise.
11438
b93aacde
PE
11439 * process.c: Rename or move locals to avoid shadowing.
11440 (list_processes_1, Fmake_network_process):
11441 (read_process_output_error_handler, exec_sentinel_error_handler):
11442 Rename or move locals.
4dc343ee 11443 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11444 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11445 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11446 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11447 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11448
af8a867c 11449 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11450 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11451 Include tparam.h instead, since it declares them.
af8a867c
PE
11452 * cm.h (PC): Remove extern decl; tparam.h now does this.
11453 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11454 * terminfo.c: Include tparam.h, to check interfaces.
11455 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11456 (tparam): Adjust signature to match interface in tparam.h;
11457 this removes some undefined behavior. Check that outstring and len
11458 are zero, which they always are with Emacs.
11459 * tparam.h (PC, BC, UP): New extern decls.
11460
0248044d 11461 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11462 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11463
8ff096c1 11464 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11465 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11466 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11467 (ftfont_list): Remove unused local.
49eaafba
PE
11468 (get_adstyle_property, ftfont_pattern_entity):
11469 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11470 Rename locals to avoid shadowing.
8ff096c1 11471
e2be39f6
PE
11472 * xfont.c (xfont_list_family): Mark var as initialized.
11473
c9735e30
PE
11474 * xml.c (make_dom): Now static.
11475
8f5201ae
PE
11476 * composite.c (composition_compute_stop_pos): Rename local to
11477 avoid shadowing.
b246f932
PE
11478 (composition_reseat_it): Remove unused locals.
11479 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11480 (composition_update_it): Mark var as initialized.
11b61122
PE
11481 (find_automatic_composition): Mark vars as initialized,
11482 with a FIXME (Bug#8290).
8f5201ae 11483
760fbc2c
PE
11484 character.h: Rename locals to avoid shadowing.
11485 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11486 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11487 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11488 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11489 to avoid shadowing.
11490
ff08eb85
PE
11491 * textprop.c (property_change_between_p): Remove; unused.
11492
fc7bf025
PE
11493 * intervals.c (interval_start_pos): Now static.
11494
235d7abc
PE
11495 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11496
44f230aa
SM
11497 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11498 Rename locals to avoid shadowing.
3e7d6594 11499
50060332
PE
11500 * sound.c (wav_play, au_play, Fplay_sound_internal):
11501 Fix pointer signedness.
d01f234b 11502 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11503 (wav_play): Initialize a variable to 0, to prevent undefined
11504 behavior (Bug#8278).
50060332 11505
c4fc4e30
PE
11506 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11507
918436ed
PE
11508 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11509
c939f91b
PE
11510 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11511 clobbering (Bug#8298).
b9c7f648
PE
11512 * sysdep.c (sys_subshell): Likewise.
11513 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11514
6bd8c144
PE
11515 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11516 This should get cleaned up, so that child_setup has the
11517 same signature on all platforms.
11518
7710357c 11519 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11520 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11521
c59da222
CY
115222011-03-22 Chong Yidong <cyd@stupidchicken.com>
11523
11524 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11525 not to be necessary, and produces flickering.
11526
66b87493
GM
115272011-03-20 Glenn Morris <rgm@gnu.org>
11528
11529 * config.in: Remove file.
11530
45b6f6d5
JB
115312011-03-20 Juanma Barranquero <lekktu@gmail.com>
11532
11533 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11534 are now in src/globals.h.
11535 (syms_of_minibuf): Remove spurious & from previous change.
11536
cd394be1 115372011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11538
11539 * minibuf.c (completing-read-function): New variable.
11540 (completing-read-default): Rename from completing-read.
11541 (completing-read): Call completing-read-function.
11542
b14e3e21
CY
115432011-03-19 Juanma Barranquero <lekktu@gmail.com>
11544
11545 * xfaces.c (Fx_load_color_file):
11546 Read color file from absolute filename (bug#8250).
11547
f2b726e6
JB
115482011-03-19 Juanma Barranquero <lekktu@gmail.com>
11549
11550 * makefile.w32-in: Update dependencies.
11551
09f6ff02
EZ
115522011-03-17 Eli Zaretskii <eliz@gnu.org>
11553
11554 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11555
29a6015a
PE
115562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11557
a3a6c54e
PE
11558 Fix more problems found by GCC 4.5.2's static checks.
11559
b766f867
PE
11560 * process.c (make_serial_process_unwind, send_process_trap):
11561 (sigchld_handler): Now static.
11562
be02381c
PE
11563 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11564 That way, the code declares only the vars that it needs.
11565 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11566 * s/cygwin.h (PTY_ITERATION): Likewise.
11567 * s/darwin.h (PTY_ITERATION): Likewise.
11568 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11569
57048744
PE
11570 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11571 * process.c (allocate_pty): Don't declare stb unless it's needed.
11572
7914961c 11573 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11574 (CONSTANTLIM): Remove; unused.
11575 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11576 Define only if needed.
7914961c 11577
b3967b18
PE
11578 * unexelf.c (unexec): Name an expression,
11579 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11580 Use a different way to cause a compilation error if anyone uses
11581 n rather than nn, a way that does not involve shadowing.
73366a00 11582 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11583
29a6015a
PE
11584 * deps.mk (unexalpha.o): Remove; unused.
11585
43cfc33e 11586 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11587 * unexec.h: New file.
ce701a33
PE
11588 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11589 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11590 Depend on unexec.h.
11591 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11592 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11593 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11594 Change as necessary to match prototype in unexec.h.
ce701a33 11595
01f44d5a
PE
11596 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11597 shadowing.
4f63c6bb 11598 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11599
a6670b0b
PE
11600 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11601 Rename locals to avoid shadowing.
11602
cef2010d 11603 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11604 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11605
d4d7173a
PE
11606 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11607
f08b802a
PE
11608 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11609 warning when compiling print.c.
11610
3ddb0639
PE
11611 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11612 instead of using an uninitialized var.
5ad03b97 11613 (font_sort_entities): Mark var as initialized.
3ddb0639 11614
170a2692
PE
11615 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11616
e663c700
PE
11617 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11618 pointers to constants.
89bc529a 11619 (font_parse_fcname): Remove unused vars.
7b81e2d0 11620 (font_delete_unmatched): Now static.
ea838e10 11621 (font_get_spec): Remove; unused.
13a547c6
PE
11622 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11623 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11624 Rename or move locals to avoid shadowing.
e663c700 11625
2a80c887 11626 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11627 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11628
1384fa33 11629 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11630 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11631
8b2c52e9
PE
11632 * alloc.c (mark_backtrace): Move decl from here ...
11633 * lisp.h: ... to here, so that it can be checked.
11634
475545b5 11635 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11636 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11637 (lisp_indirect_variable): Name an expression,
11638 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11639 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11640
b1349114 11641 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11642 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11643 Use const pointer when appropriate.
b1349114 11644
a2928364
PE
11645 * lisp.h (get_system_name, get_operating_system_release):
11646 Move decls here, to check interfaces.
11647 * process.c (get_operating_system_release): Move decl to lisp.h.
11648 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11649 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11650 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11651 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11652 (Fformat_time_string, Fencode_time, Finsert_char):
11653 (Ftranslate_region_internal, Fformat):
11654 Rename or remove local vars to avoid shadowing.
9710023e 11655 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11656
a415e694
PE
11657 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11658 avoid shadowing.
11659
8ef4622d
PE
11660 * lisp.h (eassert): Check that the argument compiles, even if
11661 ENABLE_CHECKING is not defined.
11662
946f9a5b
PE
11663 * data.c (Findirect_variable): Name an expression, to avoid
11664 gcc -Wbad-function-cast warning.
112396d6 11665 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11666 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11667 (Fmake_variable_buffer_local, Fmake_local_variable):
11668 Mark variables as initialized.
52746918 11669 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11670
e5aab7e7 11671 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11672 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11673 Rename locals to avoid shadowing.
dff45157
PE
11674 (mark_stack): Move local variables into the #ifdef region where
11675 they're used.
7bc26fdb
PE
11676 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11677 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11678 needed otherwise.
11679 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11680 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11681 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11682
e5aab7e7
PE
11683 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11684 avoids undefined behavior in theory.
11685
4da60324
PE
11686 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11687
88043301
PE
11688 Use functions, not macros, for up- and down-casing (Bug#8254).
11689 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11690 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11691 to use the following functions instead of these macros.
11692 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11693 EMACS_INT, since callers assume the returned value fits in int.
11694 (upcase1): Likewise, for UPCASE_TABLE.
11695 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11696 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11697 the race-condition problem in the old DOWNCASE.
88043301 11698
19ed5445
PE
11699 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11700 Rename locals to avoid shadowing.
11701 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11702 (regex_compile, re_search_2, re_match_2_internal):
11703 Remove unused local vars.
952db0d7
PE
11704 (FREE_VAR): Rewrite so as not to use empty "else",
11705 which gcc can warn about.
da053e48 11706 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11707 (RETALLOC_IF): Define only if needed.
11708 (WORDCHAR_P): Likewise. This one is never needed, but is used
11709 only in a comment talking about a compiler bug, so put inside
11710 the #if 0 of that comment.
11711 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11712 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11713 Remove; unused.
19ed5445 11714
1f3561e4 11715 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11716 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11717 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11718
ded6f8f7
PE
11719 * search.c (simple_search): Remove unused var.
11720
dbd37a95
PE
11721 * dired.c (compile_pattern): Move decl from here ...
11722 * lisp.h: ... to here, so that it can be checked.
11723 (struct re_registers): New forward decl.
11724
7e47afad
PE
11725 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11726
85f24f61
PE
11727 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11728 All uses changed.
11729 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11730 Rename locals to avoid shadowing.
5671df8f 11731 (Fvertical_motion): Mark locals as initialized.
85f24f61 11732
181aa2be 11733 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11734 (casify_region): Mark local as initialized.
181aa2be 11735
930d429c
PE
11736 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11737
7082eac6
PE
11738 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11739 New macros, so that the caller can use some names other than
11740 gcpro1, gcpro2, etc.
11741 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11742 of the new macros.
11743 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11744 argument, for consistency with GCPRO2_VAR, etc: it is now the
11745 prefix of the variable, not the variable itself. All uses
11746 changed.
38b2c076
PE
11747 * dired.c (directory_files_internal, file_name_completion):
11748 Rename locals to avoid shadowing.
11749
15206ed9
PE
11750 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11751 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11752 dired.c's scmp function, had undefined behavior.
11753 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11754 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11755 * buffer.h: ... to here, because these macros use current_buffer,
11756 and the new implementation with inline functions needs to have
11757 current_buffer in scope now, rather than later when the macros
11758 are used.
11759 (downcase, upcase1): New static inline functions.
11760 (DOWNCASE, UPCASE1): Reimplement using these functions.
11761 This avoids undefined behavior in expressions like
11762 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11763 from race conditions in accessing the global variables
11764 case_temp1 and case_temp2.
11765 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11766 * lisp.h (case_temp1, case_temp2): Remove their decls.
11767 * character.h (ASCII_CHAR_P): Move from here ...
11768 * lisp.h: ... to here, so that the inline functions mentioned
11769 above can use them.
11770
4a6bea26
PE
11771 * dired.c (directory_files_internal_unwind): Now static.
11772
f14b7e14
PE
11773 * fileio.c (file_name_as_directory, directory_file_name):
11774 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11775 Now static.
2893f146
PE
11776 (file_name_as_directory): Use const pointers when appropriate.
11777 (Fexpand_file_name): Likewise. In particular, newdir might
11778 point at constant storage, so make it a const pointer.
fd4ead52 11779 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11780 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11781 signedness issues.
f839df0c
PE
11782 (Fset_file_times, Finsert_file_contents, auto_save_error):
11783 Rename locals to avoid shadowing.
f14b7e14 11784
5716756e 11785 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11786 (Ftry_completion, Fall_completions): Rename or remove locals
11787 to avoid shadowing.
5716756e 11788
b4c3046a
PE
11789 * marker.c (bytepos_to_charpos): Remove; unused.
11790
b45db522
PE
11791 * lisp.h (verify_bytepos, count_markers): New decls,
11792 so that gcc does not warn that these functions aren't declared.
11793
85876d07
PE
11794 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11795 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11796 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11797 (copy_text): Remove unused local var.
85876d07 11798
03d78a21 11799 * filelock.c (within_one_second): Now static.
b3dd38ab 11800 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11801
5df8f01b
PE
11802 * buffer.c (fix_overlays_before): Mark locals as initialized.
11803 (fix_start_end_in_overlays): Likewise. This function should be
11804 simplified by using pointers-to-pointers, but that's a different
11805 matter.
b1d876f1 11806 (switch_to_buffer_1): Now static.
8f54f30a
PE
11807 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11808 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11809
a70072c9 11810 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11811 Fix pointer signedness issue.
edced198
PE
11812 (sys_subshell): Mark local as volatile if checking for lint,
11813 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11814 (MAXPATHLEN): Define only if needed.
a70072c9 11815
a0977c44
PE
11816 * process.c (serial_open, serial_configure): Move decls from here ...
11817 * systty.h: ... to here, so that they can be checked.
11818
a884fdcc
PE
11819 * fns.c (get_random, seed_random): Move extern decls from here ...
11820 * lisp.h: ... to here, so that they can be checked.
11821
604efe86 11822 * sysdep.c (reset_io): Now static.
b8950c94 11823 (wait_for_termination_signal): Remove; unused.
604efe86 11824
38fc62d9
PE
11825 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11826 (copy_keymap_item, append_key, push_text_char_description):
11827 Now static.
1004a21a 11828 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11829 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11830 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11831 (describe_map_tree):
11832 Rename locals to avoid shadowing.
38fc62d9 11833
2f2650da
PE
11834 * keyboard.c: Declare functions static if they are not used elsewhere.
11835 (echo_char, echo_dash, cmd_error, top_level_2):
11836 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11837 (read_char, kbd_buffer_get_event, make_lispy_position):
11838 (make_lispy_event, make_lispy_movement, apply_modifiers):
11839 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11840 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11841 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11842 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11843 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11844
a053e86c 11845 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11846 (mark_kboards): Move decl here ...
11847 * alloc.c (mark_kboards): ... from here.
a053e86c 11848
4752793e
PE
11849 * lisp.h (force_auto_save_soon): New decl.
11850
74f10ca7 11851 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11852 (DEFINE_DUMMY_FUNCTION): New macro.
11853 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11854 Use it.
c03cd23f
PE
11855 (main): Add casts to avoid warnings
11856 if GCC considers string literals to be constants.
74f10ca7 11857
022e70d4
PE
11858 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11859
59d6fe83
PE
11860 * dbusbind.c: Pointer signedness fixes.
11861 (xd_signature, xd_append_arg, xd_initialize):
11862 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11863 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11864 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11865 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11866
78320123
PE
11867 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11868 if GCC considers string literals to be constants.
49cebcca 11869 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11870
35ac2a97
SM
118712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11872
fb103ca9
SM
11873 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11874 (print_preprocess, print_object): New macro to fix last change.
11875
35ac2a97
SM
11876 * print.c (print_preprocess): Don't forget font objects.
11877
62973b41
JB
118782011-03-16 Juanma Barranquero <lekktu@gmail.com>
11879
11880 * emacs.c (USAGE3): Doc fixes.
11881
0e48bb22
AS
118822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11883
11884 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11885 structure.
11886
7684e57b
JB
118872011-03-14 Juanma Barranquero <lekktu@gmail.com>
11888
11889 * lisp.h (VWindow_system, Qfile_name_history):
11890 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11891 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11892 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11893
11894 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11895 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11896
11897 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11898 * w32console.c (detect_input_pending, read_input_pending)
11899 (encode_terminal_code):
11900 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11901 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11902 (w32_system_caret_y, Qfile_name_history):
11903 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11904 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11905 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11906 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11907 * w32proc.c (Qlocal, report_file_error):
11908 * w32term.c (Vwindow_system, updating_frame):
11909 * w32uniscribe.c (initialized, uniscribe_font_driver):
11910 Remove unneeded extern declarations.
11911
2aa46d6c
CY
119122011-03-14 Chong Yidong <cyd@stupidchicken.com>
11913
c96bbc66 11914 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11915
cffc6f3b
CY
119162011-03-13 Chong Yidong <cyd@stupidchicken.com>
11917
11918 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11919 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11920 These macros can no longer be used for assignment.
11921
44f230aa
SM
11922 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11923 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11924 (record_buffer_markers, fetch_buffer_markers): New functions for
11925 recording and fetching special buffer markers.
11926 (set_buffer_internal_1, set_buffer_temp): Use them.
11927
11928 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11929
11930 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11931
11932 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11933 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11934
11935 * xdisp.c (hscroll_window_tree):
11936 (reconsider_clip_changes): Use PT instead of BUF_PT.
11937
d251f04b
EZ
119382011-03-13 Eli Zaretskii <eliz@gnu.org>
11939
11940 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11941 $(EMACS_ROOT)/lib/intprops.h.
11942
f0c77cd1
PE
119432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11944
3eca4629
PE
11945 Fix more problems found by GCC 4.5.2's static checks.
11946
7c86ee98
PE
11947 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11948 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11949 (xg_free_frame_widgets): Make it clear that a local variable is
11950 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11951 (gdk_window_get_screen): Make it clear that this macro is needed
11952 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11953 (int_gtk_range_get_value): New function, which avoids a diagnostic
11954 from gcc -Wbad-function-cast.
11955 (xg_set_toolkit_scroll_bar_thumb): Use it.
11956 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11957 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11958 (get_utf8_string, xg_get_file_with_chooser):
11959 Rename locals to avoid shadowing.
11960 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11961
41729b81
PE
11962 * xgselect.c (xg_select): Remove unused var.
11963
f0c77cd1
PE
11964 * image.c (four_corners_best): Mark locals as initialized.
11965 (gif_load): Initialize transparent_p to zero (Bug#8238).
11966 Mark another local as initialized.
ec6cf4c6 11967 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11968
ce0ad53d 11969 * image.c (clear_image_cache): Now static.
d5d5a617 11970 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11971 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11972 (x_edge_detection): Remove unnecessary cast that
11973 gcc -Wbad-function-cast diagnoses.
2037898d 11974 (gif_load): Fix pointer signedness.
6ae141d6
PE
11975 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11976 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11977
33383987 119782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11979
d32df629
PE
11980 Improve quality of tests for time stamp overflow.
11981 For example, without this patch (encode-time 0 0 0 1 1
11982 1152921504606846976) returns the obviously-bogus value (-948597
11983 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11984 reports time overflow. See
11985 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11986 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11987 * editfns.c: Include limits.h and intprops.h.
11988 (TIME_T_MIN, TIME_T_MAX): New macros.
11989 (time_overflow): Move earlier, to before first use.
11990 (hi_time, lo_time): New functions, for an accurate test for
11991 out-of-range times.
11992 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11993 (Fget_internal_run_time): Don't assume time_t fits in int.
11994 (make_time): Use list2 instead of Fcons twice.
11995 (Fdecode_time): More accurate test for out-of-range times.
11996 (check_tm_member): New function.
11997 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11998 (lisp_time_argument): Don't rely on undefined left-shift and
11999 right-shift behavior when checking for time stamp overflow.
8be6f318 12000
fe31d94c
PE
12001 * editfns.c (time_overflow): New function, refactoring common code.
12002 (Fformat_time_string, Fdecode_time, Fencode_time):
12003 (Fcurrent_time_string): Use it.
12004
8be6f318
PE
12005 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12006 * dired.c (make_time): Move to ...
12007 * editfns.c (make_time): ... here.
12008 * systime.h: Note the move.
12009
09d9db2c 120102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12011
126bc0dc
YM
12012 * fringe.c (update_window_fringes): Remove unused variables.
12013
c47cbdfd
YM
12014 * unexmacosx.c (copy_data_segment): Also copy __got section.
12015 (Bug#8223)
12016
7ac80be9
EZ
120172011-03-12 Eli Zaretskii <eliz@gnu.org>
12018
c96bbc66 12019 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12020 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12021 Constify `char *' arguments and their references according to
12022 prototypes in tparam.h.
12023
ecb0f94d 12024 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12025
7ac80be9
EZ
12026 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12027 Adapt all references accordingly.
12028
12029 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12030
ef1fd07e
TT
120312011-03-11 Tom Tromey <tromey@redhat.com>
12032
12033 * buffer.c (syms_of_buffer): Remove obsolete comment.
12034
7ef4b50c
EZ
120352011-03-11 Eli Zaretskii <eliz@gnu.org>
12036
12037 * termhooks.h (encode_terminal_code): Declare prototype.
12038
12039 * msdos.c (encode_terminal_code): Don't declare prototype.
12040
12041 * term.c (encode_terminal_code): Now external again, used by
12042 w32console.c and msdos.c.
12043
44f230aa
SM
12044 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12045 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12046
4b1ec863 120472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12048
1714f52b 12049 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12050
4b1ec863
PE
12051 * fringe.c (update_window_fringes): Mark locals as initialized
12052 (Bug#8227).
12053 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12054
524c7aa6
PE
12055 * alloc.c (mark_fringe_data): Move decl from here ...
12056 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12057 to check its interface.
12058 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12059
a5c0af81 12060 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12061 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12062 (fontset_font): Mark local as initialized.
a9a06e0b 12063 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12064
b4716021
PE
12065 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12066
811e9bac 12067 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12068 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12069 (x_own_selection, Fx_disown_selection_internal): Rename locals
12070 to avoid shadowing.
12071 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12072
7e3ab302
PE
12073 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12074 so that the caller can use some name other than gcpro1.
12075 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12076 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12077 (Fx_backspace_delete_keys_p):
12078 Use them to avoid shadowing, and rename vars to avoid shadowing.
12079 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12080 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12081 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12082 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12083 Remove unused locals.
7e3ab302
PE
12084 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12085 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12086 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12087 macros.
f78faa98 12088
e2b13473
PE
12089 * xterm.h (x_mouse_leave): New decl.
12090
77f23912
PE
12091 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12092 Remove unused functions.
cdf4ba58
PE
12093 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12094 (x_calc_absolute_position): Now static.
7411c686 12095 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12096 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12097 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12098 unless they are used.
38d0b34a
PE
12099 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12100 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12101 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12102 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12103 (x_error_catcher, x_connection_closed, x_error_handler):
12104 (x_error_quitter, xembed_send_message, x_iconify_frame):
12105 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12106 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12107 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12108
44f230aa
SM
12109 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12110 Rename or move locals to avoid shadowing.
6b463e58 12111 (tty_defined_color, merge_face_heights): Now static.
5967d051 12112 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12113 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12114 does not deduce is never used uninitialized.
73719eba
PE
12115 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12116 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12117
426994c3 12118 * terminal.c (store_terminal_param): Now static.
5489860b 12119
032f1620 12120 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12121 (set_frame_menubar): Remove unused local.
d4323972 12122 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12123 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12124 since they might point to immutable storage.
281585b0
PE
12125 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12126 since it's unused otherwise.
032f1620 12127
367c19e5 12128 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12129 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12130 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12131 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12132 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12133 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12134 does not deduce are never used uninitialized.
70739cbe 12135
07b48fa9
PE
12136 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12137
8868a238 12138 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12139 * window.c (window_loop, size_window):
12140 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12141
7e5cf297 12142 * window.c (display_buffer): Now static.
d6550a9f
PE
12143 (size_window): Mark variables that gcc -Wuninitialized
12144 does not deduce are never used uninitialized.
a586633d
PE
12145 * window.h (check_all_windows): New decl, to forestall
12146 gcc -Wmissing-prototypes diagnostic.
5b555da1 12147 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12148
f6095868
PE
12149 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12150 shadowing.
12151 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12152 Include <limits.h>.
12153 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12154 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12155 (load_charset_map): Mark variables that gcc -Wuninitialized
12156 does not deduce are never used uninitialized.
53df7c11 12157 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12158
f38b440c
PE
12159 * coding.c (coding_set_source, coding_set_destination):
12160 Use "else { /* comment */ }" rather than "else /* comment */;"
12161 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12162 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12163 a block, when the outer 'i' will do.
12164 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12165 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12166 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12167 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12168 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12169 Rename locals to avoid shadowing.
12170 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12171 * coding.c (emacs_mule_char, encode_invocation_designation):
12172 Now static, since they're not used elsewhere.
413bb2db 12173 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12174 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12175 (decode_coding_emacs_mule): Mark variables that gcc
12176 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12177 (detect_coding_iso_2022): Initialize a local variable that might
12178 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12179 this initialization is needed. (Bug#8211)
5f58e762
PE
12180 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12181 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12182 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12183 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12184 Remove unused macros.
f38b440c 12185
232b38b9 12186 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12187 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12188 * character.c (string_count_byte8): Likewise.
232b38b9 12189
fb90da1b
PE
12190 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12191 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12192
fb93dbc2
PE
12193 * chartab.c (copy_sub_char_table): Now static, since it's not used
12194 elsewhere.
5c156ace
PE
12195 (sub_char_table_ref_and_range, char_table_ref_and_range):
12196 Rename locals to avoid shadowing.
bbcd0949 12197 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12198
7d3b3862 12199 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12200 (BIDI_BOB): Remove unused macro.
7d3b3862 12201
6be7d3da
PE
12202 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12203 deduce are never used uninitialized.
c2ed9c8b 12204 * term.c (encode_terminal_code): Likewise.
6be7d3da 12205
75f8807f 12206 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12207
50938595
PE
12208 * tparam.h: New file.
12209 * term.c, tparam.h: Include it.
12210 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12211 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12212 Move these decls to tparam.h, and make them agree with what
12213 is actually in tparam.c. The previous trick of using incompatible
12214 decls in different modules does not conform to the C standard.
12215 All callers of tparam changed to use tparam's actual API.
12216 * tparam.c (tparam1, tparam, tgoto):
12217 Use const pointers where appropriate.
12218
fbceeba2
PE
12219 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12220 * cm.h (struct cm): Likewise.
12221 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12222 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12223 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12224 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12225 (turn_on_face, init_tty): Likewise.
12226 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12227
7f3f1250
PE
12228 * term.c (term_mouse_position): Rename local to avoid shadowing.
12229
e6ca6543
PE
12230 * alloc.c (mark_ttys): Move decl from here ...
12231 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12232
c40f8d15
AS
122332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12234
12235 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12236
cfe0661d
JB
122372011-03-09 Juanma Barranquero <lekktu@gmail.com>
12238
12239 * search.c (compile_pattern_1): Remove argument regp, unused since
12240 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12241 (compile_pattern): Don't pass it.
12242
0afb4571
J
122432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12244
12245 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12246 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12247 for ! HAVE_GTK3.
12248 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12249
12250 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12251
12252 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12253 gdk_window_get_screen, gdk_window_get_geometry,
12254 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12255 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12256 (xg_get_pixbuf_from_pixmap): New function.
12257 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12258 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12259 Call xg_get_pixbuf_from_pixmap instead of
12260 gdk_pixbuf_get_from_drawable.
12261 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12262 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12263 (xg_check_special_colors): Use GtkStyleContext and its functions
12264 for HAVE_GTK3.
12265 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12266 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12267 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12268 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12269 Call gtk_widget_get_preferred_size.
0afb4571
J
12270 (xg_frame_resized): gdk_window_get_geometry only takes 5
12271 parameters.
44f230aa
SM
12272 (xg_win_to_widget, xg_event_is_for_menubar):
12273 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12274 (xg_set_widget_bg): New function.
12275 (delete_cb): New function.
895009e1 12276 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12277 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12278 (xg_set_background_color): Call xg_set_widget_bg.
12279 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12280 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12281 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12282 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12283 if ! HAVE_GTK3.
12284 (update_frame_tool_bar): Call gtk_widget_hide.
12285 (xg_initialize): Use GDK_KEY_g.
12286
12287 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12288 if ! HAVE_GTK3
12289 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12290
12291 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12292 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12293 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12294
1c2cc4ef
JB
122952011-03-08 Juanma Barranquero <lekktu@gmail.com>
12296
12297 * w32xfns.c (select_palette): Check success of RealizePalette against
12298 GDI_ERROR, not zero.
12299
33383987 12300See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12301
12302;; Local Variables:
12303;; coding: utf-8
aac0c6e3
MR
12304;; End:
12305
2f097256 12306 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12307
12308 This file is part of GNU Emacs.
12309
12310 GNU Emacs is free software: you can redistribute it and/or modify
12311 it under the terms of the GNU General Public License as published by
12312 the Free Software Foundation, either version 3 of the License, or
12313 (at your option) any later version.
12314
12315 GNU Emacs is distributed in the hope that it will be useful,
12316 but WITHOUT ANY WARRANTY; without even the implied warranty of
12317 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12318 GNU General Public License for more details.
12319
12320 You should have received a copy of the GNU General Public License
12321 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.