Improve and document the language-change event on MS-Windows.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0bd8297f
EZ
12012-06-23 Eli Zaretskii <eliz@gnu.org>
2
3 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4 language ID in the event parameters.
5
6 * w32term.c (w32_read_socket): Put the new keyboard codepage into
7 event.code, not the obscure "character set ID".
8
63def6b6
CY
92012-06-23 Chong Yidong <cyd@gnu.org>
10
11 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
12
e8a02204
EZ
132012-06-23 Eli Zaretskii <eliz@gnu.org>
14
388cdec0
EZ
15 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
16 * w32.c (fdutimens): New function.
17
18 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
19
20 * s/ms-w32.h (pselect): Redirect to sys_select.
21
22 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
23
e8a02204
EZ
24 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
25 in the logic of incrementing and decrementing the value of
26 use_relocatable_buffers.
27
d054f3fb
PE
282012-06-23 Paul Eggert <eggert@cs.ucla.edu>
29
30 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
31 Privately reported by Herbert J. Skuhra.
32 [__FreeBSD__]: Remove "*/" typo after "#include".
33 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
34 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
35 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
36 Don't assume EMACS_TIME and struct timeval are the same type.
37
d35af63c
PE
382012-06-22 Paul Eggert <eggert@cs.ucla.edu>
39
40 Support higher-resolution time stamps (Bug#9000).
41 The time stamps are only nanosecond-resolution at the C level,
42 since that's the best that any real-world system supports now.
43 But they are picosecond-resolution at the Lisp level, as that's
44 easy, and leaves room for future OS improvements.
45
46 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
47 (LIBES): Use it.
48
49 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
50 Don't get current time unless it's needed.
51
52 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
53 now provides it if it's absent.
54 (start_atimer): Port to higher-res time stamps.
55 Check for time stamp overflow. Don't get current time more
56 often than is needed.
57
58 * buffer.h (struct buffer): Buffer modtime now has high resolution.
59 Include systime.h, not time.h.
60 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
61
62 * dired.c: Include stat-time.h.
63 (Ffile-attributes): File times now have higher resolution.
64
65 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
66 (struct image): Timestamp now has higher resolution.
67
68 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
69 has at least microseconds now. All uses removed.
70 (update_frame, update_single_window, update_window, update_frame_1)
71 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
72
73 * editfns.c (time_overflow): Now extern.
74 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
75 (float-time, Fformat_time_string, Fcurrent_time_string)
76 (Fcurrent_time_zone): Accept and generate higher-resolution
77 time stamps.
78 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
79 (decode_time_components, lisp_seconds_argument): New functions.
80 (make_time): Now static.
81 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
82 Report an error if the time is invalid, rather than having the caller
83 do that.
84
85 * fileio.c: Include <stat-time.h>
86 (Fcopy_file): Copy higher-resolution time stamps.
87 Prefer to set the time stamp via a file descriptor if that works.
88 (Fset_file_times, Finsert_file_contents, Fwrite_region)
89 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
90 (Fvisited_file_modtime, Fset_visited_file_modtime):
91 Support higher-resolution time stamps.
92
93 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
94
95 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
96
97 * image.c (prepare_image_for_display, clear_image_cache)
98 (lookup_image): Port to higer-resolution time stamps.
99
100 * keyboard.c (start_polling, bind_polling_period):
101 Check for time stamp overflow.
102 (read_char, kbd_buffer_get_event, timer_start_idle)
103 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
104 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
105 Port to higher-resolution time stamps. Do not assume time_t is signed.
106 (decode_timer): New function. Timers are now vectors of length 9,
107 not 8, to accommodate the picosecond component.
108 (timer_check_2): Use it.
109
110 * nsterm.m (select_timeout, timeval_subtract): Remove.
111 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
112 as they're a bit more accurate and handle overflow better.
113 (ns_select): Change prototype to be compatible with pselect.
114 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
115 * nsterm.h (ns_select): Adjust prototype.
116
117 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
118 us-resolution time stamps.
119 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
120
121 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
122
123 * lisp.h (time_overflow): New decl.
124 (wait_reading_process_output): First arg is now intmax_t, not int,
125 to accommodate larger waits.
126
127 * process.h (struct Lisp_Process.read_output_delay):
128 Now counts nanoseconds, not microseconds.
129 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
130 EMACS_HAS_USECS.
131 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
132 (wait_reading_process_output):
133 Port to ns-resolution time stamps.
134 (Faccept_process_output, wait_reading_process_output):
135 Check for time stamp overflow. Do not assume time_t is signed.
136 (select_wrapper): Remove; we now use pselect.
137 (Fprocess_attributes): Now generates ns-resolution time stamps.
138
139 * sysdep.c: Include utimens.h. Don't include utime.h
140 or worry about struct utimbuf; gnulib does that for us now.
141 (gettimeofday): Remove; gnulib provides a substitute.
142 (make_timeval): New function.
143 (set_file_times): Now sets ns-resolution time stamps.
144 New arg FD; all uses changed.
145 (time_from_jiffies, ltime_from_jiffies, get_up_time)
146 (system_process_attributes):
147 Now returns ns-resolution time stamp. All uses changed.
148 Check for time stamp overflow.
149
150 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
151 provides a substitute now.
152
153 * systime.h: Include timespec.h rather than sys/time.h and time.h,
154 since it guarantees struct timespec.
155 (EMACS_TIME): Now struct timespec, so that we can support
156 ns-resolution time stamps.
157 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
158 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
159 (EMACS_USECS): Remove.
160 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
161 so multiply the arg by 1000 before storing it.
162 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
163 New macros.
164 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
165 Port to ns-resolution time stamps.
166 (EMACS_TIME_NEG_P): Remove; replaced by....
167 (EMACS_TIME_SIGN): New macro.
168 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
169 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
170 (set_file_times, make_time, lisp_time_argument): Adjust signature.
171 (make_timeval, make_lisp_time, decode_time_components): New decls.
172 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
173 that it mishandled time_t overflow. You can't compare by subtracting!
174 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
175 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
176
177 * term.c: Include <sys/time.h>.
178 (timeval_to_Time): New function, for proper overflow wraparound.
179 (term_mouse_position, term_mouse_click): Use it.
180
181 * undo.c (record_first_change): Support higher-resolution time stamps
182 in the undo buffer.
183 (Fprimitive_undo): Use them when restoring time stamps.
184
185 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
186 (w32_get_internal_run_time):
187 Port to higher-resolution Emacs time stamps.
188 (ltime): Now accepts single 64-bit integer, as that's more convenient
189 for callers.
190
191 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
192
193 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
194 for compatibility with pselect. Support ns-resolution time stamps.
195
196 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
197
198 * xselect.c (wait_for_property_change, x_get_foreign_selection):
199 Check for time stamp overflow, and support ns-resolution time stamps.
200
201 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
202 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
203 (timeval_subtract): Remove; no longer needed.
204 (XTflash, XTring_bell, x_wait_for_event):
205 Port to ns-resolution time stamps. Don't assume time_t is signed.
206
b6a92dfe
CY
2072012-06-22 Chong Yidong <cyd@gnu.org>
208
209 * xdisp.c (x_consider_frame_title): Revert last change.
210
d251c37c
EZ
2112012-06-22 Eli Zaretskii <eliz@gnu.org>
212
213 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
214 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
215 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
216 staticidx goes up to 1597 out of 1600 = 0x640.)
217
f10deafb
PE
2182012-06-20 Paul Eggert <eggert@cs.ucla.edu>
219
220 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
221 Otherwise, the umask might be mistakenly 0 while handling input signals.
222
ec6de1e2
SM
2232012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
224
225 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
226
28be1ada
DA
2272012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
230 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
231 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
232 access to `contents' member of Lisp_Vector objects with AREF and ASET
233 where appropriate.
234
c6bf3022
CY
2352012-06-19 Chong Yidong <cyd@gnu.org>
236
237 * frame.c (delete_frame): When selecting a frame on a different
238 text terminal, do not alter the terminal's top-frame.
239
240 * xdisp.c (format_mode_line_unwind_data): Record the target
241 frame's selected window and its terminal's top-frame.
242 (unwind_format_mode_line): Restore them.
243 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
244 Callers changed.
245 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
246 since tty frames can be explicitly named.
247 (prepare_menu_bars): Likewise.
248
249 * term.c (Ftty_top_frame): New function.
250
defd4196
PE
2512012-06-18 Paul Eggert <eggert@cs.ucla.edu>
252
253 Port byte-code-meter to modern targets.
254 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
255 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 256 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
257 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
258 (METER_1, METER_2): Simplify.
259
1053a871
SM
2602012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
261
262 * data.c (Fdefalias): Return `symbol' (bug#11686).
263
b7e8d081
MR
2642012-06-18 Martin Rudalics <rudalics@gmx.at>
265
266 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
267 gets killed during executing of this function (Bug#11665).
268 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
269 (Vkill_buffer_query_functions): In doc-string say that functions
270 run by this hook should not change the current buffer.
271
7ea2b339
PE
2722012-06-18 Paul Eggert <eggert@cs.ucla.edu>
273
274 Fix recently-introduced process.c problems found by static checking.
275 * process.c (write_queue_push, write_queue_pop, send_process):
276 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
277 (write_queue_pop): Fix pointer signedness problem.
278 (send_process): Remove unused local.
279
96a313a1
CY
2802012-06-17 Chong Yidong <cyd@gnu.org>
281
282 * xdisp.c (redisplay_internal): No need to redisplay terminal
283 frames that are not on top.
284
20ca2e94
TN
2852012-06-17 Troels Nielsen <bn.troels@gmail.com>
286
287 * process.c (make_process): Initialize write_queue.
288 (write_queue_push, write_queue_pop): New functions.
289 (send_process): Use them to maintain correct ordering of process
290 writes (Bug#10815).
291
9a900ca9
PE
2922012-06-17 Paul Eggert <eggert@cs.ucla.edu>
293
310fbfa8
PE
294 * lisp.h (eassert): Assume C89 or later.
295 This removes the need for CHECK.
296 (CHECK): Remove. Its comments about always evaluating its
297 argument were confusing, as 'eassert' typically does not evaluate
298 its argument.
299
27bb1ca4
PE
300 * coding.c (produce_chars): Use ptrdiff_t, not int.
301
9a900ca9
PE
302 * xterm.c (x_draw_underwave): Check for integer overflow.
303 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
304
41b7f8bc 3052012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
306
307 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
308 referenced (Bug#11583).
309
9b0e3eba
AA
3102012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
311
312 Implement wave-style variant of underlining.
313 * dispextern.h (face_underline_type): New enum.
314 (face): Add field for underline type.
315 * nsterm.m (ns_draw_underwave): New function.
316 (ns_draw_text_decoration): Use it.
317 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
318 New functions.
319 (x_draw_glyph_string): Use them.
320 * xfaces.c (Qline, Qwave): New Lisp objects.
321 (check_lface_attrs, merge_face_ref)
1053a871
SM
322 (Finternal_set_lisp_face_attribute, realize_x_face):
323 Handle wave-style underline face attributes.
9b0e3eba
AA
324 * xterm.c (x_draw_underwave): New function.
325 (x_draw_glyph_string): Use it.
326
0fb52f11
JB
3272012-06-16 Juanma Barranquero <lekktu@gmail.com>
328
329 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
330 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
331 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
332 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
333 ($(BLD)/w32select.$(O)): Update dependencies.
334
e5560ff7
AS
3352012-06-16 Andreas Schwab <schwab@linux-m68k.org>
336
337 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
338 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
339 * character.c (_fetch_multibyte_char_p): Remove.
340 * alloc.c: Include "character.h" before "buffer.h".
341 * bidi.c: Likewise.
342 * buffer.c: Likewise.
343 * bytecode.c: Likewise.
344 * callint.c: Likewise.
345 * callproc.c: Likewise.
346 * casefiddle.c: Likewise.
347 * casetab.c: Likewise.
348 * category.c: Likewise.
349 * cmds.c: Likewise.
350 * coding.c: Likewise.
351 * composite.c: Likewise.
352 * dired.c: Likewise.
353 * dispnew.c: Likewise.
354 * doc.c: Likewise.
355 * dosfns.c: Likewise.
356 * editfns.c: Likewise.
357 * emacs.c: Likewise.
358 * fileio.c: Likewise.
359 * filelock.c: Likewise.
360 * font.c: Likewise.
361 * fontset.c: Likewise.
362 * fringe.c: Likewise.
363 * indent.c: Likewise.
364 * insdel.c: Likewise.
365 * intervals.c: Likewise.
366 * keyboard.c: Likewise.
367 * keymap.c: Likewise.
368 * lread.c: Likewise.
369 * macros.c: Likewise.
370 * marker.c: Likewise.
371 * minibuf.c: Likewise.
372 * nsfns.m: Likewise.
373 * nsmenu.m: Likewise.
374 * print.c: Likewise.
375 * process.c: Likewise.
376 * regex.c: Likewise.
377 * region-cache.c: Likewise.
378 * search.c: Likewise.
379 * syntax.c: Likewise.
380 * term.c: Likewise.
381 * textprop.c: Likewise.
382 * undo.c: Likewise.
383 * unexsol.c: Likewise.
384 * w16select.c: Likewise.
385 * w32fns.c: Likewise.
386 * w32menu.c: Likewise.
387 * window.c: Likewise.
388 * xdisp.c: Likewise.
389 * xfns.c: Likewise.
390 * xmenu.c: Likewise.
391 * xml.c: Likewise.
392 * xselect.c: Likewise.
393
2f07e6af
EZ
3942012-06-16 Eli Zaretskii <eliz@gnu.org>
395
1053a871
SM
396 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
397 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 398 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
399 row.
400 (handle_face_prop): Use chunk-relative overlay string index when
401 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
402 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
403 the rightmost. (Bug#11720)
2f07e6af 404
29b83cec
AS
4052012-06-16 Andreas Schwab <schwab@linux-m68k.org>
406
407 * category.h (CHAR_HAS_CATEGORY): Define as inline.
408 (CATEGORY_MEMBER): Enforce 1/0 value.
409 * category.c (_temp_category_set): Remove.
410
4c5501e9
EZ
4112012-06-16 Eli Zaretskii <eliz@gnu.org>
412
413 * window.c (Fdelete_other_windows_internal)
414 (Fdelete_window_internal): Don't access frame's mouse highlight
415 info of the initial frame. (Bug#11677)
416
2b570124
PE
4172012-06-14 Paul Eggert <eggert@cs.ucla.edu>
418
e93864f9
PE
419 * .gdbinit (xgetint): Fix recently-introduced paren typo.
420 Assume USE_2_TAGS_FOR_INTS.
421 (xreload): Adjust $tagmask width to match recent lisp.h change.
422
2b570124
PE
423 Simplify lisp.h in minor ways that should not affect code.
424 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
425 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
426 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
427 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
428 (INTTYPEBITS): New macro, for clarity.
429 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
430 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
431 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
432 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
433 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
434
81755f69
JB
4352012-06-13 Juanma Barranquero <lekktu@gmail.com>
436
437 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
438
16192a57
GM
4392012-06-13 Glenn Morris <rgm@gnu.org>
440
441 * s/bsd-common.h (BSD4_3):
442 * s/usg5-4-common.h (USG5_4): No longer define; unused.
443
646b5f55
AS
4442012-06-13 Andreas Schwab <schwab@linux-m68k.org>
445
446 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
447 instead of union.
448 (XLI, XIL): Define.
1053a871
SM
449 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
450 Use them.
451 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 452 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 453 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
454 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
455 * frame.c (delete_frame): Remove outdated comment.
456 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
457 USE_LISP_UNION_TYPE.
458 (Fw32_unregister_hot_key): Likewise.
459 (Fw32_toggle_lock_key): Likewise.
460 * w32menu.c (add_menu_item): Likewise.
461 (w32_menu_display_help): Use XIL instead of checking
462 USE_LISP_UNION_TYPE.
463 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
464 (init_heap): Likewise.
465 * w32term.c (w32_read_socket): Update comment.
466
1d3823c9
GM
4672012-06-13 Glenn Morris <rgm@gnu.org>
468
c62ff706
GM
469 * s/usg5-4-common.h, src/s/unixware.h:
470 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
471
1d3823c9
GM
472 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
473
bfe3e0a2
PE
4742012-06-13 Paul Eggert <eggert@cs.ucla.edu>
475
476 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
477 * alloc.c (make_number) [!defined make_number]:
478 Remove, as lisp.h always defines this now.
479 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
480 (roundup_size): Verify that it is a power of 2.
481 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
482 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
483 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
484 -DUSE_LSB_TAG=0, to override the automatically-selected default.
485 USE_LSB_TAG now is always defined to be either 0 or 1.
486 All uses changed.
487 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
488 code works fine either way, and efficiency is not a concern here,
489 as the union type is for debugging, not for production.
490 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
491 Use an inline function on all platforms when using the union type,
492 since this is simpler and 'static inline' can be used portably
493 within Emacs now.
494 (LISP_INITIALLY_ZERO): New macro.
495 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
496 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
497
45fa9c0f
GM
4982012-06-12 Glenn Morris <rgm@gnu.org>
499
b4492cba
GM
500 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
501
502 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 503
45fa9c0f
GM
504 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
505 Move BROKEN_SIGIO to configure.
506
507 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
508 Move NO_TERMIO to configure.
509
0e25d334
CY
5102012-06-12 Chong Yidong <cyd@gnu.org>
511
512 * image.c (imagemagick_load_image): Use MagickFlattenImage if
513 MagickMergeImageLayers is undefined. Use pixel pusher loop if
514 MagickExportImagePixels is undefined.
515
43682bb6
PE
5162012-06-12 Paul Eggert <eggert@cs.ucla.edu>
517
518 * image.c (imagemagick_load_image): Remove unused label.
519
a9be7d2b
GM
5202012-06-11 Glenn Morris <rgm@gnu.org>
521
522 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
523 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
524 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
525 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
526
3017f87f
SM
5272012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
528
529 * alloc.c (make_byte_code): New function.
530 (Fmake_byte_code): Use it. Don't purify here.
531 * lread.c (read1): Use it as well to avoid extra allocation.
532
1b9b4cf4
CY
5332012-06-11 Chong Yidong <cyd@gnu.org>
534
535 * image.c (imagemagick_load_image): Implement transparency.
536
95988fcf
AS
5372012-06-10 Andreas Schwab <schwab@linux-m68k.org>
538
539 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
540 account for preceding backslashes. (Bug#11663)
541
cd4eb164
CY
5422012-06-09 Chong Yidong <cyd@gnu.org>
543
544 * term.c: Support italics in capable terminals (Bug#9652).
545 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
546 (turn_on_face): Output using TS_enter_italic_mode if available.
547 Don't handle unused blinking and alt-charset cases.
548 (turn_off_face): Handle italic case; discard unused tty_blinking_p
549 and tty_alt_charset_p cases.
550 (tty_capable_p, init_tty): Support italics.
551
552 * termchar.h (struct tty_display_info): Add field for italics.
553 Remove unused blink field.
554
555 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
556 Handle slant.
557
558 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
559 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
560 tty_alt_charset_p. Add tty_italic_p.
561
ff88beb8
MA
5622012-06-09 Michael Albinus <michael.albinus@gmx.de>
563
564 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
565 dbus_type_is_basic if available.
566 (xd_extract_signed, xd_extract_unsigned): Rename from
567 extract_signed and extract_unsigned, respectively. Adapt callers.
568
44286096
CY
5692012-06-09 Chong Yidong <cyd@gnu.org>
570
1682701f
CY
571 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
572
44286096
CY
573 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
574 case (Bug#9752).
575
d86feb17
PE
5762012-06-08 Paul Eggert <eggert@cs.ucla.edu>
577
578 * xdisp.c (vmessage): Treat frame message as multibyte.
579 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
580 would generate the diagnostic "Making \302\247 buffer-local while
581 let-bound!".
582
d5c20fe8
EZ
5832012-06-08 Eli Zaretskii <eliz@gnu.org>
584
585 * dispnew.c (showing_window_margins_p): Undo last change, which
586 was done due to an inadvertent commit.
587 (adjust_frame_glyphs_for_frame_redisplay): Do call
588 showing_window_margins_p.
589
513749ee
SM
5902012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
591
592 * eval.c (Fmake_var_non_special): New primitive.
593 (syms_of_eval): Defsubr it.
594 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
595
d4a8f5c1
JB
5962012-06-08 Juanma Barranquero <lekktu@gmail.com>
597
598 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
599 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
600
8bbbc977
EZ
6012012-06-08 Eli Zaretskii <eliz@gnu.org>
602
603 * alloc.c (allocate_vectorlike): Fix last change.
604
f3372c87
DA
6052012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
606
607 Block-based vector allocation of small vectors.
608 * lisp.h (struct vectorlike_header): New field `nbytes',
609 adjust comment accordingly.
610 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
611 to denote vector blocks. Adjust users (live_vector_p,
612 mark_maybe_pointer, valid_lisp_object_p) accordingly.
613 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
614 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
615 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
616 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
617 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
618 (roundup_size): New constant.
619 (struct vector_block): New data type.
620 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 621 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
622 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
623 (sweep_vectors): New functions.
624 (allocate_vectorlike): Return `zero_vector' as the only vector of
625 0 items. Allocate new vector from block if vector size is less than
626 or equal to VBLOCK_BYTES_MAX.
627 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
628 (init_alloc_once): Add call to init_vectors.
629
4f18a4ed
SM
6302012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
631
632 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
633
86f158bc
PE
6342012-06-07 Paul Eggert <eggert@cs.ucla.edu>
635
636 * doprnt.c (doprnt): Truncate multibyte char correctly.
637 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
638 would mishandle a string argument "Xc" if X was a multibyte
639 character of length 2: it would truncate after X's first byte
640 rather than including all of X.
641
c5cfcbe0
CY
6422012-06-06 Chong Yidong <cyd@gnu.org>
643
644 * buffer.c (word_wrap): Doc fix.
645
c05cf390
PE
6462012-06-04 Paul Eggert <eggert@cs.ucla.edu>
647
648 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
649
0c3461de
GM
6502012-06-03 Glenn Morris <rgm@gnu.org>
651
652 * xdisp.c (tool-bar-style): Doc fix.
653
c71232db
UM
6542012-06-03 Ulrich Müller <ulm@gentoo.org>
655
656 * Makefile.in (PAXCTL): Define.
657 (temacs$(EXEEXT)): Disable memory randomization for the temacs
658 binary via PaX flags if the paxctl utility is available.
659 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
660 Restore PaX flags to their default. (Bug#11398)
661
383f7350
CY
6622012-06-03 Chong Yidong <cyd@gnu.org>
663
664 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
665 buffer (Bug#11226).
666
5f2c76c6
CY
6672012-06-03 Chong Yidong <cyd@gnu.org>
668
669 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
670 (note_mode_line_or_margin_highlight): If there is no help echo,
671 use mode-line-default-help-echo. Handle the case where the mouse
672 position is past the end of the mode line string.
673
674 * buffer.c (buffer_local_value_1): New function, split from
675 Fbuffer_local_value; can return Qunbound.
676 (Fbuffer_local_value): Use it.
677 (Vmode_line_format): Docstring tweaks.
678
773d47f6
PE
6792012-06-02 Paul Eggert <eggert@cs.ucla.edu>
680
681 * sysdep.c (system_process_attributes): Improve comment.
682
f2d6a3df
SM
6832012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
684
685 * keyboard.c: Export real-this-command to Elisp.
686 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
687 and DEFVAR it. Update all users.
688
63810350
PE
6892012-06-02 Paul Eggert <eggert@cs.ucla.edu>
690
7bd5c1f4
PE
691 * minibuf.c (Fassoc_string): Remove duplicate declaration.
692
63810350
PE
693 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
694 Convert pctcpu and pctmem to Lisp float properly.
695 Let the compiler fold better, as 100.0/0x8000 is exact.
696
a2821611
AS
6972012-06-02 Andreas Schwab <schwab@linux-m68k.org>
698
699 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
700 cons_block.
701
5fceba1d
PE
7022012-06-01 Paul Eggert <eggert@cs.ucla.edu>
703
704 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
705
c98ff5dd
DA
7062012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
707
708 For a 'struct window', replace some Lisp_Object fields to
709 bitfields where appropriate, remove unused fields.
710 * window.h (struct window): Remove unused 'last_mark_x' and
711 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
712 change it's type from Lisp_Object to bitfield.
713 Change type of 'force_start', 'optional_new_start',
714 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
715 fields from Lisp_Object to bitfield. Adjust users accordingly.
716
ca34e0be
PE
7172012-05-31 Paul Eggert <eggert@cs.ucla.edu>
718
719 Pacify gcc -Wdouble-precision when using Xaw.
720 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
721 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
722 Use 'float' consistently, rather than 'float' in most places
723 and 'double' in a couple of places.
724
efc00ab1 7252012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
726
727 * xdisp.c (handle_stop): Detect whether we have overlay strings
728 loaded by testing it->current.overlay_string_index to be
729 non-negative, instead of checking whether n_overlay_strings is
730 positive. (Bug#11587)
731
efc00ab1 7322012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
733
734 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
735
736 * doc.c (Fsubstitute_command_keys): Doc fix.
737
efc00ab1 7382012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
739
740 * search.c (search_buffer): Remove calls to
741 r_alloc_inhibit_buffer_relocation, as it is now called by
742 maybe_unify_char, which was the cause of relocation of buffer text
743 in bug#11519.
744
efc00ab1 7452012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
746
747 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
748 for the duration of call to load_charset, to avoid problems with
749 callers of maybe_unify_char that access buffer text through C
750 pointers.
751
752 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
753 decrement the inhibition flag, instead of just setting or
754 resetting it.
755
ba93a187
PE
7562012-05-31 Paul Eggert <eggert@cs.ucla.edu>
757
758 Remove obsolete '#define static' cruft.
759 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
760 This #undef was "temporary" in 2000; it is no longer needed
761 now that '#define static' has gone away.
762 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
763 (gray_bitmap_bits): Remove; no longer needed.
764 All uses replaced with definiens.
765 * xterm.c: Include "bitmaps/gray.xbm".
766
9e4bf381
PE
7672012-05-30 Paul Eggert <eggert@cs.ucla.edu>
768
769 Clean up __executable_start, monstartup when --enable-profiling.
770 The following changes affect the code only when profiling.
771 * dispnew.c (__executable_start): Rename from safe_bcopy.
772 Define only on platforms that need it.
773 * emacs.c: Include <sys/gmon.h> when profiling.
774 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
775 (__executable_start): Remove decl, since lisp.h does it now.
776 (safe_bcopy): Remove decl; no longer has that name.
777 (main): Coalesce #if into single bit of code, for simplicity.
778 Cast pointers to uintptr_t, since standard libraries want integers
779 and not pointers.
780 * lisp.h (__executable_start): New decl.
781
32d72c2f
GM
7822012-05-31 Glenn Morris <rgm@gnu.org>
783
784 * image.c (Fimagemagick_types): Doc fix.
785
baac5bc7
JM
7862012-05-30 Jim Meyering <meyering@redhat.com>
787
788 * callproc.c (Fcall_process_region): Include directory component
789 in mkstemp error message (Bug#11586).
790
72cb32cf
PE
7912012-05-30 Paul Eggert <eggert@cs.ucla.edu>
792
793 * alloc.c, lisp.h (make_pure_vector): Now static.
794
61b108cc
SM
7952012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
798 Move to byte-run.el.
799 (Fautoload): Do the hash-doc more carefully.
800 * data.c (Fdefalias): Purify definition, except for keymaps.
801 (Qdefun): Move from eval.c.
802 * lisp.h (Qdefun): Remove.
803 * lread.c (read1): Tiny simplification.
804
471fe23d
TN
8052012-05-29 Troels Nielsen <bn.troels@gmail.com>
806
934f3f58 807 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
808 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
809 Bug#9642, but explicitly check that the buffer the overlay would
810 be moved to is live and rearrange lines to make sure that errors
811 will not put the overlay in an inconsistent state.
812 (Fdelete_overlay): Cosmetics.
813
85d0efd1
EZ
8142012-05-28 Eli Zaretskii <eliz@gnu.org>
815
816 * w32term.c (my_bring_window_to_top): New function.
817 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
818 could be different from the original one.
819 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
820 (Bug#11513)
821
822 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
823 by calling BringWindowToTop.
824
825 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
826 (WM_EMACS_END): Increase by one.
827
da92a98c
PE
8282012-05-28 Paul Eggert <eggert@cs.ucla.edu>
829
830 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
831 This avoids undefined behavior that might cause the eassert
832 to not catch an out-of-range value.
833
74d1f848
JB
8342012-05-28 Juanma Barranquero <lekktu@gmail.com>
835
836 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
837 Update dependencies.
838
9e1a06fc
EZ
8392012-05-27 Eli Zaretskii <eliz@gnu.org>
840
841 * bidi.c (bidi_mirror_char): Fix last change.
842
f3dd7312
AS
8432012-05-27 Andreas Schwab <schwab@linux-m68k.org>
844
845 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
846 when referring to sectname field in printf format.
847
81899c91
PE
8482012-05-27 Paul Eggert <eggert@cs.ucla.edu>
849
57b81a9f
PE
850 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
851 Only r_alloc_inhibit_buffer_relocation needed to be added;
852 the others were already declared.
853
81899c91
PE
854 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
855 before checking whether it's out of range. Put the check inside
856 eassert. See
857 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
858
33017faf 8592012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
860
861 * callproc.c (Fcall_process): Restore a line that was accidentally
862 commented out in the 2011-02-13 change (bug#11547).
863
33017faf 8642012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
865
866 * lisp.h [REL_ALLOC]: Add prototypes for external functions
867 defined on ralloc.c.
868
869 * buffer.c [REL_ALLOC]: Remove prototypes of
870 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
871 they are now on lisp.h.
872
873 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
874
875 * search.c (search_buffer): Use it to inhibit relocation of buffer
876 text while re_search_2 is doing its job, because re_search_2 is
877 passed C pointers to buffer text. (Bug#11519)
878
23415acf
EZ
879 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
880 Update value to 24.
881
44e27368
EZ
882 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
883 state after an additional call to move_it_in_display_line_to, keep
884 the values of it->max_ascent and it->max_descent found for the
885 entire line.
886 (pos_visible_p): Revert the comparison against bottom_y to what it
887 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
888 (Bug#11464)
889
c1892f11
PE
8902012-05-26 Paul Eggert <eggert@cs.ucla.edu>
891
892 Fix coding-related core dumps with gcc -ftrapv.
893 The code was computing A - B, where A and B are pointers, and B is
894 random garbage. This can lead to core dumps on platforms that
895 have special pointer registers, and it also leads to core dumps on
896 x86-64 when compiled with gcc -ftrapv. The fix is to compute
897 A - B only when B is initialized properly.
898 * coding.c (coding_set_source, coding_set_destination): Return void.
899 (coding_change_source, coding_change_destinations): New functions,
900 with the old behaviors of coding_set_source and coding_set_destination.
901 All callers that need an offset changed to use these new functions.
902
eb7afdad
GM
9032012-05-26 Glenn Morris <rgm@gnu.org>
904
905 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
906
f12fdf02
EZ
9072012-05-26 Eli Zaretskii <eliz@gnu.org>
908
53a63be6 909 Extend mouse support on W32 text-mode console.
61b108cc
SM
910 * xdisp.c (draw_row_with_mouse_face):
911 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 912
eb3f6f01 913 * w32console.c: Include window.h.
61b108cc
SM
914 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
915 New functions.
eb3f6f01
EZ
916 (initialize_w32_display): Initialize mouse-highlight data.
917
53a63be6
EZ
918 * w32inevt.c: Include termchar.h and window.h.
919 (do_mouse_event): Support mouse-autoselect-window. When the mouse
920 moves, call note_mouse_highlight. If help_echo changed, call
921 gen_help_event to produce help-echo message in the echo area.
922 Call clear_mouse_face if mouse_face_hidden is set in the mouse
923 highlight info.
924
4cfd81f6
PE
9252012-05-26 Paul Eggert <eggert@cs.ucla.edu>
926
927 * lread.c (read1): Simplify slightly to avoid an overflow warning
928 with GCC 4.7.0 on x86-64.
929
4446092a
EZ
9302012-05-26 Eli Zaretskii <eliz@gnu.org>
931
932 * bidi.c (bidi_mirror_char): Revert last change: an int is
933 definitely wide enough here.
934
42b2a986 9352012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 936
42b2a986 937 Fix integer width and related bugs (Bug#9874).
eb106a49 938 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
939 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
940 (string_bytes, check_sblock, allocate_string_data):
941 (compact_small_strings, Fmake_bool_vector, make_string)
942 (make_unibyte_string, make_multibyte_string)
943 (make_string_from_bytes, make_specified_string)
944 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
945 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
946 (mark_vectorlike):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 (allocate_pseudovector):
949 Use int, not EMACS_INT, where int is wide enough.
950 (inhibit_garbage_collection, Fgarbage_collect):
951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
952 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
953 int might not be wide enough.
954 (bidi_cache_search, bidi_cache_find, bidi_init_it)
955 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
956 (bidi_at_paragraph_end, bidi_find_paragraph_start)
957 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
958 (bidi_level_of_next_char, bidi_move_to_visually_next):
959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
960 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
961 (Fkill_buffer, Fset_buffer_major_mode)
962 (advance_to_char_boundary, Fbuffer_swap_text)
963 (Fset_buffer_multibyte, overlays_at, overlays_in)
964 (overlay_touches_p, struct sortvec, record_overlay_string)
965 (overlay_strings, recenter_overlay_lists)
966 (adjust_overlays_for_insert, adjust_overlays_for_delete)
967 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
968 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
969 (Foverlay_recenter, last_overlay_modification_hooks_used)
970 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
972 (validate_region): Omit unnecessary test for b <= e,
973 since that's guaranteed by the previous test.
d311d28c
PE
974 (adjust_overlays_for_delete): Avoid pos + length overflow.
975 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
976 (report_overlay_modification):
977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
978 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
979 Omit pointer cast, which isn't needed anyway, and doesn't work
980 after the EMACS_INT -> ptrdiff_t change.
02481186 981 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
982 * buffer.h: Adjust decls to match defn changes elsewhere.
983 (struct buffer_text, struct buffer):
984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
985 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
986 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
987 not int, to avoid needless 32-bit limit on 64-bit hosts.
988 (exec_byte_code): Use tighter memory-full test, one that checks
989 for alloca overflow. Don't compute the address of the object just
990 before an array, as that's not portable. Use EMACS_INT, not
991 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
992 * callint.c (Fcall_interactively):
993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
994 * callproc.c (call_process_kill, Fcall_process):
995 Don't assume pid_t fits into an Emacs fixnum.
996 (call_process_cleanup, Fcall_process, child_setup):
997 Don't assume pid_t fits into int.
998 (call_process_cleanup, Fcall_process, delete_temp_file)
999 (Fcall_process_region):
1000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1001 (Fcall_process): Simplify handling of volatile integers.
1002 Use int, not EMACS_INT, where int will do.
1003 * casefiddle.c (casify_object, casify_region, operate_on_word)
1004 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1006 (casify_object): Avoid integer overflow when overallocating buffer.
1007 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1008 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1009 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1010 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1011 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1012 integers are now checked earlier. All uses replaced with XINT.
1013 (ccl_driver):
1014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1015 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1016 (ccl_driver, Fregister_code_conversion_map):
1017 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1018 (resolve_symbol_ccl_program): Check that vector header is in range.
1019 Always copy the vector, so that we can check its contents reliably
1020 now rather than having to recheck each instruction as it's being
1021 executed. Check that vector words fit in 'int'.
1022 (ccl_get_compiled_code, Fregister_ccl_program)
1023 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1024 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1025 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1026 contents are in range.
1027 (Fccl_execute_on_string): Check that status is in range.
1028 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1029 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1030 Accept and return EMACS_INT, not int, because callers can pass values
1031 out of 'int' range.
1032 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1033 (multibyte_chars_in_text, parse_str_as_multibyte)
1034 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1035 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1036 (string_escape_byte8, Fget_byte):
1037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1038 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1039 avoid mishandling large integers.
1040 * character.h: Adjust decls to match defn changes elsewhere.
1041 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1042 (Ffind_charset_region):
1043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1044 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1045 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1046 Don't assume fixnum fits in int.
d311d28c
PE
1047 (load_charset_map_from_vector, Fmap_charset_chars):
1048 Remove now-unnecessary CHECK_NATNUMs.
1049 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1050 Don't rely on undefined behavior with signed left shift overflow.
1051 Don't assume unsigned int fits into fixnum, or that fixnum fits
1052 into unsigned int. Don't require max_code to be a valid fixnum;
1053 that's not true for gb10830 4-byte on a 32-bit host. Allow
1054 invalid_code to be a cons, for the same reason. Require code_offset
1055 to be a character. Avoid int overflow if max_char is close
1056 to INT_MAX.
1057 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1058 this is intended anyway and avoids some undefined behavior.
1059 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1060 INDEX_TO_CODE_POINT, as that's what it expects.
1061 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1062 * charset.h (DECODE_CHAR): Return int, not unsigned;
1063 this is what was intended anyway, and it avoids undefined behavior.
1064 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1065 integer-overflow issues.
1066 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1067 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1068 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1069 * chartab.c (Fmake_char_table, Fset_char_table_range)
1070 (uniprop_get_decoder, uniprop_get_encoder):
1071 Don't assume fixnum fits in int.
1072 * cmds.c (move_point): New function, that does the gist of
1073 Fforward_char and Fbackward_char, but does so while checking
1074 for integer overflow more accurately.
c96e5d6a 1075 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1076 (Fforward_line, Fend_of_line, internal_self_insert)
1077 (internal_self_insert):
1078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1079 Fix a FIXME, by checking for integer overflow when calculating
1080 target_clm and actual_clm.
1081 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1082 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1083 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1084 (coding_alloc_by_making_gap, alloc_destination)
1085 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1086 (encode_coding_utf_16, detect_coding_emacs_mule)
1087 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1088 (detect_coding_iso_2022, decode_coding_iso_2022)
1089 (encode_invocation_designation, encode_designation_at_bol)
1090 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1091 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1092 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1093 (encode_coding_ccl, encode_coding_raw_text)
1094 (detect_coding_charset, decode_coding_charset)
1095 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1096 (produce_composition, produce_charset, produce_annotation)
1097 (decode_coding, handle_composition_annotation)
1098 (handle_charset_annotation, consume_chars, decode_coding_gap)
1099 (decode_coding_object, encode_coding_object, detect_coding_system)
1100 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1101 (code_convert_region, code_convert_string)
8f50130c
PE
1102 (Fdefine_coding_system_internal)
1103 (coding_set_source, coding_set_destination):
d311d28c
PE
1104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1105 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1106 (Fdefine_coding_system_internal):
1107 Don't assume fixnums fit in int.
1108 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1109 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1110 (Funencodable_char_position, Fcheck_coding_systems_region)
1111 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1112 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1113 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1114 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1115 Don't access memory outside of the args array.
d311d28c 1116 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1117 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1118 result of ENCODE_CHAR.
d311d28c
PE
1119 * coding.h: Adjust decls to match defn changes elsewhere.
1120 (struct coding_system):
1121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1122 * composite.c (get_composition_id, find_composition)
1123 (run_composition_function, update_compositions)
1124 (compose_text, composition_gstring_put_cache)
1125 (composition_gstring_p, composition_gstring_width)
1126 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1127 (composition_compute_stop_pos, composition_reseat_it)
1128 (composition_update_it, struct position_record)
1129 (find_automatic_composition, composition_adjust_point)
1130 (Fcomposition_get_gstring, Ffind_composition_internal):
1131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1132 (update_compositions):
1133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1134 * composite.h: Adjust decls to match defn changes elsewhere.
1135 (struct composition):
1136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1137 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1138 Do not attempt to compute the address of the object just before a
1139 buffer; this is not portable.
1140 (Faref, Faset):
1141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1142 (Faset): Use int, not EMACS_INT, where int is wide enough.
1143 (Fstring_to_number): Don't assume fixnums fit in int.
1144 (Frem): Don't assume arg is nonnegative.
1145 * dbusbind.c (xd_append_arg): Check for integers out of range.
1146 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1147 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1148 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1149 (xd_get_connection_references): Return ptrdiff_t, not int.
1150 All uses changed.
1151 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1152 (xd_read_message_1):
1153 Use int, not unsigned, where the dbus API uses int.
1154 (Fdbus_message_internal): Don't overflow mtype.
1155 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1156 * dired.c (directory_files_internal, file_name_completion, scmp)
1157 (file_name_completion_stat):
1158 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1159 (file_name_completion): Don't overflow matchcount.
1160 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1161 * dispextern.h: Adjust decls to match defn changes elsewhere.
1162 (struct text_pos, struct glyph, struct bidi_saved_info)
1163 (struct bidi_string_data, struct bidi_it, struct composition_it)
1164 (struct it):
1165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1166 (struct display_pos, struct composition_it, struct it):
1167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1168 * dispnew.c (increment_matrix_positions)
1169 (increment_row_positions, mode_line_string)
1170 (marginal_area_string):
1171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1172 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1174 (duration_to_sec_usec): New function, to check for overflow better.
1175 (Fsleep_for, sit_for): Use it.
1176 * doc.c (get_doc_string, store_function_docstring):
1177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1178 (get_doc_string, Fsnarf_documentation):
1179 Use int, not EMACS_INT, where int is wide enough.
1180 (get_doc_string):
1181 Use SAFE_ALLOCA, not alloca.
1182 Check for overflow when converting EMACS_INT to off_t.
1183 * doprnt.c (doprnt):
1184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1185 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1186 Don't assume uid_t fits into fixnum.
1187 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1188 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1189 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1190 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1191 (general_insert_function)
1192 (Finsert_char, make_buffer_string, make_buffer_string_both)
1193 (update_buffer_properties, Fbuffer_substring)
1194 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1195 (Fsubst_char_in_region, check_translation)
1196 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1197 (transpose_markers, Ftranspose_regions):
1198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1199 (clip_to_bounds): Move to lisp.h as an inline function).
1200 (Fconstrain_to_field): Don't assume integers are nonnegative.
1201 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1202 (Fsubst_char_in_region, Fsave_restriction):
1203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1204 (Femacs_pid): Don't assume pid_t fits into fixnum.
1205 (lo_time): Use int, not EMACS_INT, when int suffices.
1206 (lisp_time_argument): Check for usec out of range.
1207 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1208 (Fuser_login_name, Fuser_full_name): Signal an error
1209 if a uid argument is out of range, rather than relying on
1210 undefined behavior.
c8d5c857
PE
1211 (Fformat_time_string): Remove now-unnecessary check.
1212 lisp_time_argument checks for out-of-range usec now.
243e0530 1213 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1214 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1215 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1216 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1217 (init_cmdargs, Fdump_emacs):
1218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1219 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1220 the bottom (typically) 32 bits of the fixnum.
1221 * eval.c (specpdl_size, call_debugger):
1222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1223 (when_entered_debugger, Fbacktrace_debug):
1224 Don't assume fixnum can fit in int.
1225 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1226 the object just before a buffer; this is not portable.
1227 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1228 (grow_specpdl, unbind_to):
1229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1230 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1231 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1232 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1233 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1234 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1236 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1237 (a_write, e_write):
1238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1239 (Fcopy_file, non_regular_nbytes, read_non_regular)
1240 (Finsert_file_contents):
1241 Use int, not EMACS_INT, where int is wide enough.
1242 (READ_BUF_SIZE): Verify that it fits in int.
1243 (Finsert_file_contents): Check that counts are in proper range,
1244 rather than assuming fixnums fit into ptrdiff_t etc.
1245 Don't assume fixnums fit into int.
125b3835 1246 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1247 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1248 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1249 (string_char_to_byte, string_byte_to_char)
1250 (string_make_multibyte, string_to_multibyte)
1251 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1252 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1253 (substring_both, Fdelete, internal_equal, Ffillarray)
1254 (Fclear_string, mapcar1)
1255 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1256 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1257 (larger_vector, make_hash_table, maybe_resize_hash_table)
1258 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1259 (Fmaphash, secure_hash):
1260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1261 (concat): Check for string index and length overflow.
1262 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1263 (Frequire):
1264 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1265 (larger_vector): New API (vec, incr_min, size_max) replaces old
1266 one (vec, new_size, init). This catches size overflow.
1267 INIT was removed because it was always Qnil.
1268 All callers changed.
1269 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1270 the upper bound on a hash table index size.
1271 (make_hash_table, maybe_resize_hash_table): Use it.
1272 (secure_hash): Computer start_byte and end_byte only after
1273 they're known to be in ptrdiff_t range.
1274 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1275 (Ffont_get_glyphs, Ffont_at):
1276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1277 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1278 (Flist_fonts, Fopen_font):
1279 Don't assume fixnum can fit in int.
1280 (check_gstring): Don't assume index can fit in int.
1281 (font_match_p): Check that fixnum is a character, not a nonnegative
1282 fixnum, since the later code needs to stuff it into an int.
1283 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1284 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1285 conversion overflow issues.
1286 (Fopen_font): Check for integer out of range.
1287 (Ffont_get_glyphs): Don't assume index can fit in int.
1288 * font.h: Adjust decls to match defn changes elsewhere.
1289 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1290 integer overflow.
1291 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1292 printmax_t, where ptrdiff_t is wide enough.
1293 (Finternal_char_font):
1294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1295 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1296 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1297 (Fset_frame_position, x_set_frame_parameters)
1298 (x_set_line_spacing, x_set_border_width)
1299 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1300 Check that fixnums are in proper range for system types.
1301 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1303 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1304 Use SAFE_ALLOCA_LISP, not alloca.
1305 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1306 intptr_t is wide enough.
1307 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1308 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1309 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1310 Check for fixnum out of range.
1311 * ftfont.c (ftfont_list): Don't assume index fits in int.
1312 Check that fixnums are in proper range for system types.
1313 (ftfont_shape_by_flt):
1314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1315 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1317 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1318 Check that fixnums are in proper range for system types.
1319 * gnutls.h: Adjust decls to match defn changes elsewhere.
1320 * gtkutil.c (xg_dialog_run):
1321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1322 (update_frame_tool_bar):
1323 Check that fixnums are in proper range for system types.
1324 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1325 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1326 * indent.c (last_known_column, last_known_column_point):
1327 (current_column_bol_cache):
1328 (skip_invisible, current_column, check_display_width):
1329 (check_display_width, scan_for_column, current_column_1)
1330 (Findent_to, Fcurrent_indentation, position_indentation)
1331 (indented_beyond_p, Fmove_to_column, compute_motion):
1332 (Fcompute_motion, Fvertical_motion):
1333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1334 (last_known_column_modified): Use EMACS_INT, not int.
1335 (check_display_width):
1336 (Fcompute_motion):
1337 Check that fixnums and floats are in proper range for system types.
1338 (compute_motion): Don't assume index or fixnum fits in int.
1339 (compute_motion, Fcompute_motion):
1340 Use int, not EMACS_INT, when it is wide enough.
1341 (vmotion): Omit local var start_hpos that is always 0; that way
1342 we don't need to worry about overflow in expressions involving it.
1343 * indent.h: Adjust decls to match defn changes elsewhere.
1344 (struct position):
1345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1346 Use int, not EMACS_INT, where int is wide enough.
1347 Remove unused members ovstring_chars_done and tab_offset;
1348 all uses removed.
1349 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1350 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1351 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1352 (make_gap, copy_text, insert, insert_and_inherit)
1353 (insert_before_markers, insert_before_markers_and_inherit)
1354 (insert_1, count_combining_before, count_combining_after)
1355 (insert_1_both, insert_from_string)
1356 (insert_from_string_before_markers, insert_from_string_1)
1357 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1358 (adjust_after_replace, adjust_after_insert, replace_range)
1359 (replace_range_2, del_range, del_range_1, del_range_byte)
1360 (del_range_both, del_range_2, modify_region)
1361 (prepare_to_modify_buffer, signal_before_change)
1362 (signal_after_change, Fcombine_after_change_execute):
1363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1364 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1365 (balance_an_interval, split_interval_right, split_interval_left)
1366 (find_interval, next_interval, update_interval)
1367 (adjust_intervals_for_insertion, delete_node, delete_interval)
1368 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1369 (static_offset_intervals, offset_intervals)
1370 (merge_interval_right, merge_interval_left, make_new_interval)
1371 (graft_intervals_into_buffer, temp_set_point_both)
1372 (temp_set_point, set_point, adjust_for_invis_intang)
1373 (set_point_both, move_if_not_intangible, get_property_and_range)
1374 (get_local_map, copy_intervals, copy_intervals_to_string)
1375 (compare_string_intervals, set_intervals_multibyte_1):
1376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1377 * intervals.h: Adjust decls to match defn changes elsewhere.
1378 (struct interval):
1379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1380 * keyboard.c (this_command_key_count, this_single_command_key_start)
1381 (before_command_key_count, before_command_echo_length, echo_now)
1382 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1383 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1384 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1385 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1387 (last_non_minibuf_size, last_point_position, echo_truncate)
1388 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1389 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1390 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1391 (stuff_buffered_input):
1392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1393 (last_auto_save, command_loop_1, read_char):
1394 Use EMACS_INT, not int, to avoid integer overflow.
1395 (record_char): Avoid overflow in total_keys computation.
1396 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1397 * keyboard.h: Adjust decls to match defn changes elsewhere.
1398 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1399 (Fkey_description, Fdescribe_vector, Flookup_key):
1400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1401 (click_position): New function, to check that positions are in range.
1402 (Fcurrent_active_maps):
1403 (describe_command):
1404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1405 (Faccessible_keymaps, Fkey_description):
1406 (preferred_sequence_p):
1407 Don't assume fixnum can fit into int.
1408 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1409 Check for integer overflow in size calculations.
1410 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1411 avoid mishandling large integers.
1412 * lisp.h: Adjust decls to match defn changes elsewhere.
1413 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1414 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1415 (struct Lisp_Marker):
1416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1417 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1418 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1419 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1420 All callers changed.
1421 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1422 Assume the arg has valid form, since it always does.
1423 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1424 unsigned integer system type.
1425 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1426 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1428 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1429 (duration_to_sec_usec): New decl.
1430 * lread.c (read_from_string_index, read_from_string_index_byte)
1431 (read_from_string_limit, readchar, unreadchar, openp)
1432 (read_internal_start, read1, oblookup):
1433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1434 (Fload, readevalloop, Feval_buffer, Feval_region):
1435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1436 (openp): Check for out-of-range argument to 'access'.
1437 (read1): Use int, not EMACS_INT, where int is wide enough.
1438 Don't assume fixnum fits into int.
6efdadfd 1439 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1440 (read_filtered_event): Use duration_to_sec_usec
1441 to do proper overflow checking on durations.
d311d28c
PE
1442 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1443 in size calculation.
1444 (Fexecute_kbd_macro):
1445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1446 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1447 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1448 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1449 (set_marker_both, set_marker_restricted_both, marker_position)
1450 (marker_byte_position, Fbuffer_has_markers_at):
1451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1452 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1453 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1454 It now merely ensures that the menu is large enough, without
1455 necessarily growing it, as this avoids some integer overflow issues.
1456 All callers changed.
1457 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1459 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1460 Use SAFE_ALLOCA_LISP, not alloca.
1461 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1462 to EMACS_INT. Check that fixnums are in proper range for system types.
1463 * minibuf.c (minibuf_prompt_width, string_to_object)
1464 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1465 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1467 (get_minibuffer, read_minibuf_unwind):
1468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1469 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1470 this simplifies overflow checking. All callers changed.
1471 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1472 (Ftest_completion):
1473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1474 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1475 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1476 Check that fixnums are in proper range for system types.
1477 (Fx_create_frame, Fx_show_tip):
1478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1479 * nsfont.m (ns_findfonts, nsfont_list_family):
1480 Don't assume fixnum fits in long.
1481 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1483 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1484 wide enough.
17fdb222 1485 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1487 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1488 (PRINTDECLARE, PRINTPREPARE):
1489 (strout, print_string):
1490 (print, print_preprocess, print_check_string_charset_prop)
1491 (print_object):
1492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1493 (PRINTDECLARE):
1494 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1496 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1497 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1498 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1499 (print_error_message): Use SAFE_ALLOCA, not alloca.
1500 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1501 (print_depth, new_backquote_output, print_number_index):
1502 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1503 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1504 (Fset_process_window_size, Fformat_network_address)
1505 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1506 (sigchld_handler):
d311d28c 1507 Check that fixnums are in proper range for system types.
d44287d4 1508 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1509 Check for process-ids out of pid_t range rather than relying on
1510 undefined behavior.
e4d81efc 1511 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1512 (Fformat_network_address, read_process_output, send_process)
1513 (Fprocess_send_region, status_notify):
1514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1515 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1516 (wait_reading_process_output, read_process_output, exec_sentinel):
1517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1518 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1519 (Faccept_process_output): Use duration_to_sec_usec to do proper
1520 overflow checking on durations.
dde14581
PE
1521 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1522 Don't assume pid_t fits in int.
02481186
PE
1523 * process.h (struct Lisp_Process): Members tick and update_tick
1524 are now of type EMACS_INT, not int.
b62b53e8
PE
1525 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1526 configured --with-wide-int.
d311d28c
PE
1527 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1528 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1529 * search.c (looking_at_1, string_match_1):
1530 (fast_string_match, fast_c_string_match_ignore_case)
1531 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1532 (scan_newline, find_before_next_newline, search_command)
1533 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1534 (set_search_regs, wordify):
1535 (Freplace_match):
1536 (Fmatch_data):
1537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1538 (string_match_1, search_buffer, set_search_regs):
1539 (Fmatch_data):
1540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1541 (wordify): Check for overflow in size calculation.
1542 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1543 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1544 Check that fixnums are in proper range for system types.
1545 * sound.c (struct sound_device)
1546 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1548 (Fplay_sound_internal):
1549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1550 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1551 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1552 (Fparse_partial_sexp):
1553 Don't assume fixnums can fit in int.
1554 (struct lisp_parse_state, find_start_pos, find_start_value)
1555 (find_start_value_byte, find_start_begv)
1556 (update_syntax_table, char_quoted, dec_bytepos)
1557 (find_defun_start, prev_char_comend_first, back_comment):
1558 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1559 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1561 (Finternal_describe_syntax_value): Check that match_lisp is a
1562 character, not an integer, since the code stuffs it into int.
1563 (scan_words, scan_sexps_forward):
1564 Check that fixnums are in proper range for system types.
1565 (Fforward_word):
1566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1567 (scan_sexps_forward):
1568 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1569 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1570 * syntax.h: Adjust decls to match defn changes elsewhere.
1571 (struct gl_state_s):
1572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1573 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1574 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1575 * sysdep.c (wait_for_termination_1, wait_for_termination)
1576 (interruptible_wait_for_termination, mkdir):
1577 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1578 (emacs_read, emacs_write):
1579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1580 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1581 and double all fit in int.
d311d28c
PE
1582 * term.c (set_tty_color_mode):
1583 Check that fixnums are in proper range for system types.
1584 * termhooks.h (struct input_event):
1585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1586 * textprop.c (validate_interval_range, interval_of)
1587 (Fadd_text_properties, set_text_properties_1)
1588 (Fremove_text_properties, Fremove_list_of_text_properties)
1589 (Ftext_property_any, Ftext_property_not_all)
1590 (copy_text_properties, text_property_list, extend_property_ranges)
1591 (verify_interval_modification):
1592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1593 (Fnext_single_char_property_change)
1594 (Fprevious_single_char_property_change):
1595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1596 (copy_text_properties):
1597 Check for integer overflow in index calculation.
d311d28c
PE
1598 * undo.c (last_boundary_position, record_point, record_insert)
1599 (record_delete, record_marker_adjustment, record_change)
1600 (record_property_change):
1601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1602 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1604 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1605 (Fx_hide_tip, Fx_file_dialog):
1606 * w32menu.c (set_frame_menubar):
1607 Use ptrdiff_t, not int, for consistency with rest of code.
1608 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1609 (select_window, Fdelete_other_windows_internal)
1610 (window_scroll_pixel_based, window_scroll_line_based)
1611 (Frecenter, Fset_window_configuration):
1612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1613 (Fset_window_hscroll, run_window_configuration_change_hook)
1614 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1615 (Fscroll_other_window, Frecenter):
d311d28c
PE
1616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1617 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1618 Don't assume fixnum fits in int.
1619 (Fset_window_scroll_bars):
1620 Check that fixnums are in proper range for system types.
1621 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1622 (string_pos, c_string_pos, number_of_chars, init_iterator)
1623 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1624 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1625 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1626 (face_before_or_after_it_pos, handle_invisible_prop)
1627 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1628 (display_prop_intangible_p, string_buffer_position_lim)
1629 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1630 (get_overlay_strings_1, get_overlay_strings)
1631 (iterate_out_of_display_property, forward_to_next_line_start)
1632 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1633 (get_next_display_element, set_iterator_to_next)
1634 (get_visually_first_element, compute_stop_pos_backwards)
1635 (handle_stop_backwards, next_element_from_buffer)
1636 (move_it_in_display_line_to, move_it_in_display_line)
1637 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1638 (add_to_log, message_dolog, message_log_check_duplicate)
1639 (message2, message2_nolog, message3, message3_nolog
1640 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1641 (current_message_1, truncate_echo_area, truncate_message_1)
1642 (set_message, set_message_1, store_mode_line_noprop)
1643 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1644 (text_outside_line_unchanged_p, check_point_in_composition)
1645 (reconsider_clip_changes)
1646 (redisplay_internal, set_cursor_from_row, try_scrolling)
1647 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1648 (redisplay_window, find_last_unchanged_at_beg_row)
1649 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1650 (trailing_whitespace_p, find_row_edges, display_line)
1651 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1652 (display_mode_element, store_mode_line_string)
1653 (pint2str, pint2hrstr, decode_mode_spec)
1654 (display_count_lines, display_string, draw_glyphs)
1655 (x_produce_glyphs, x_insert_glyphs)
1656 (rows_from_pos_range, mouse_face_from_buffer_pos)
1657 (fast_find_string_pos, mouse_face_from_string_pos)
1658 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1660 (safe_call, init_from_display_pos, handle_fontified_prop)
1661 (handle_single_display_spec, load_overlay_strings)
1662 (with_echo_area_buffer, setup_echo_area_for_printing)
1663 (display_echo_area, echo_area_display)
1664 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1665 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1666 (redisplay_window, dump_glyph_row, display_mode_line)
1667 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1668 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1670 (handle_single_display_spec, build_desired_tool_bar_string)
1671 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1672 (get_specified_cursor_type):
1673 Check that fixnums are in proper range for system types.
1674 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1675 (Flookup_image_map):
1676 Don't assume fixnums fit in int.
1677 (compare_overlay_entries):
1678 Avoid mishandling comparisons due to subtraction overflow.
1679 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1680 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1681 (handle_tool_bar_click):
1682 Use int, not unsigned, since we prefer signed and the signedness
1683 doesn't matter here.
1684 (get_next_display_element, next_element_from_display_vector):
1685 Use int, not EMACS_INT, when int is wide enough.
1686 (start_hourglass): Use duration_to_sec_usec to do proper
1687 overflow checking on durations.
1688 * xfaces.c (Fbitmap_spec_p):
1689 Check that fixnums are in proper range for system types.
1690 (compare_fonts_by_sort_order):
1691 Avoid mishandling comparisons due to subtraction overflow.
1692 (Fx_family_fonts, realize_basic_faces):
1693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1694 (Fx_family_fonts):
1695 Don't assume fixnum fits in int.
1696 Use SAFE_ALLOCA_LISP, not alloca.
1697 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1698 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1699 (face_at_buffer_position, face_for_overlay_string)
1700 (face_at_string_position):
1701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1702 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1703 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1704 (Fx_show_tip):
1705 Check that fixnums are in proper range for system types.
1706 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1707 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1709 (Fx_change_window_property): Don't assume fixnums fit in int.
1710 * xfont.c (xfont_chars_supported):
1711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1712 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1713 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1715 * xml.c (parse_region):
1716 * xrdb.c (magic_file_p):
1717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1718 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1719 (x_get_local_selection, x_reply_selection_request)
1720 (x_handle_selection_request, wait_for_property_change):
1721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1722 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1723 short is wide enough.
1724 (x_send_client_event): Don't assume fixnum fits in int.
1725 * xterm.c (x_x_to_emacs_modifiers):
1726 Don't assume EMACS_INT overflows nicely into int.
1727 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1728 may come from Lisp.
1729 (handle_one_xevent): NATNUMP can eval its arg twice.
1730 (x_connection_closed):
1731 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1732 * xterm.h: Adjust decls to match defn changes elsewhere.
1733 (struct scroll_bar): Use struct vectorlike_header
1734 rather than rolling our own approximation.
1735 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1736
c6574eb5
GM
17372012-05-25 Glenn Morris <rgm@gnu.org>
1738
1739 * lisp.mk (lisp): Update for more files being compiled now.
1740
e8d32c7e
SM
17412012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1742
48def666
SM
1743 * lread.c: Remove `read_pure' which makes no difference.
1744 (read_pure): Remove var.
1745 (unreadpure): Remove function.
1746 (readevalloop): Don't call read_list with -1 flag.
1747 (read1, read_vector): Don't test read_pure any more.
1748 (read_list): Simplify.
1749
e8d32c7e
SM
1750 * fileio.c, character.h: Minor style tweaks.
1751
4b2addb7
DA
17522012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1753
1754 * window.h (clip_changed): Remove useless declaration.
1755
584461b2
JB
17562012-05-22 Juanma Barranquero <lekktu@gmail.com>
1757
1758 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1759 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1760
34374650
PE
17612012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 Remove src/m/*.
1764 This directory predates autoconf and is no longer needed nowadays.
1765 Move its few remaining bits of functionality to where they're needed.
1766 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1767 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1768 * m/template.h: Remove.
1769 * Makefile.in (M_FILE): Remove. All uses removed.
1770 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1771 * lisp.h (USE_LSB_TAG):
1772 * mem-limits.h (EXCEEDS_LISP_PTR):
1773 Use VAL_MAX, not VALBITS, in #if.
1774 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1775 (EMACS_UINT): Define unconditionally now.
1776 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1777 (BITS_PER_EMACS_INT): New constants, replacing
1778 what used to be in config.h, but not useful in #if.
1779 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1780 define them any more.
1781 (VAL_MAX): New macro.
1782 (VALMASK): Use it.
1783 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1784 BITS_PER_EMACS_INT, in #if.
1785 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1786 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1787 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1788 * s/ms-w32.h (DATA_START):
1789 Move here from removed file m/intel386.h.
1790 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1791 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1792
261cb4bb
PE
17932012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1794
1795 Assume C89 or later.
1796 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1797 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1798 (xrealloc):
1799 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1800 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1801 * textprop.c, tparam.c (NULL): Remove.
1802 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1803 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1804 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1805 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1806 * xterm.c (input_signal_count): Assume volatile works.
1807
ff23cd9f
KB
18082012-05-21 Ken Brown <kbrown@cornell.edu>
1809
1810 * xgselect.c (xg_select): Fix first argument in call to 'select'
1811 (bug#11508).
1812
1b170bc6
KB
18132012-05-20 Ken Brown <kbrown@cornell.edu>
1814
1815 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1816 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1817
b2f4d39f
KB
18182012-05-19 Ken Brown <kbrown@cornell.edu>
1819
1820 * xfns.c (x_in_use): Remove `static' qualifier.
1821 * xterm.h (x_in_use): Declare.
1822 * xgselect.c: Include xterm.h.
1823 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1824 and `display_arg' (bug#9754).
1825
003fdae2
PE
18262012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1827
9232a6d9
PE
1828 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1829
003fdae2
PE
1830 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1831 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1832
784b56e2
EZ
18332012-05-18 Eli Zaretskii <eliz@gnu.org>
1834
1835 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1836
1837 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1838 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1839
1840 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1841 reference to image_cache->refcount.
1842 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1843
a0a79cde
JL
18442012-05-17 Juri Linkov <juri@jurta.org>
1845
1846 * search.c (Fword_search_regexp, Fword_search_backward)
1847 (Fword_search_forward, Fword_search_backward_lax)
1848 (Fword_search_forward_lax): Move functions to isearch.el
1849 (bug#10145, bug#11381).
1850
b0572523
PE
18512012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1852
1853 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1854
9660f5fc
SM
18552012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1856
1857 * lread.c (init_obarray): Declare Qt and Qnil as special.
1858
4374de83
GM
18592012-05-14 Glenn Morris <rgm@gnu.org>
1860
1861 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1862 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1863
dc44c39a
PE
18642012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1865
078c97cb
PE
1866 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1867
dc44c39a
PE
1868 * unexaix.c: Port to more-recent AIX compilers.
1869 (report_error, report_error_1, make_hdr, copy_sym)
1870 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1871 Make arguments const char *, not char *, to avoid violations of C
1872 standard and to fix some AIX warnings reported by Gilles Pion.
1873
e18afed7 18742012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1875
1876 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1877 already have overlays loaded.
1878 (handle_single_display_spec): Before returning without displaying
1879 fringe bitmap, synchronize the bidi iterator with the main display
1880 iterator, by calling iterate_out_of_display_property.
1881 (iterate_out_of_display_property): Detect buffer iteration by
1882 testing that it->string is a Lisp string.
1883 (get_next_display_element): When the current object is exhausted,
1884 and there's something on it->stack, call set_iterator_to_next to
1885 proceed with what's on the stack, instead of returning zero.
1886 (set_iterator_to_next): If called at the end of a Lisp string,
1887 proceed to consider_string_end without incrementing string
1888 position. Don't increment display vector index past the end of
1889 the display vector. (Bug#11417)
c8fb9dc6
EZ
1890 (pos_visible_p): Don't report a position visible when move_it_to
1891 stopped at the last line of window, which happens to be scanned
1892 backwards by the bidi iteration. (Bug#11464)
ac268e67 1893
e18afed7 18942012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1895
1896 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1897 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1898 are on a TTY, and thus unable to display on the fringes.
1899 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1900 so we need to signal to the caller that this is a "replacing"
1901 display spec. This fixes display when the spec is invalid or we
1902 are on a TTY.
1903
e18afed7 19042012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1905
1906 * unexaix.c (make_hdr): Fix typo in prototype.
1907 This bug broke the build on AIX. Problem reported by Gilles Pion.
1908
9d0a235a
MA
19092012-05-14 Michael Albinus <michael.albinus@gmx.de>
1910
1911 * keyboard.c (kbd_buffer_get_event): Read special events also in
1912 batch mode. (Bug#11415)
1913
9e6b06ed
GM
19142012-05-12 Glenn Morris <rgm@gnu.org>
1915
1916 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1917
c1a1d7a3
EZ
19182012-05-12 Eli Zaretskii <eliz@gnu.org>
1919
1920 * lisp.mk (lisp): Add newcomment.elc.
1921
3fe7cdc8
GM
19222012-05-12 Glenn Morris <rgm@gnu.org>
1923
1924 * Makefile.in (MKDIR_P): New, set by configure.
1925 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1926
53f7d2c0
PE
19272012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 Remove unused function hourglass_started.
1930 * dispextern.h (hourglass_started):
1931 * w32fns.c (hourglass_started):
1932 * xdisp.c (hourglass_started): Remove.
1933
75aafb17
JB
19342012-05-10 Juanma Barranquero <lekktu@gmail.com>
1935
1936 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1937 Update dependencies.
1938
12959e8e
PE
19392012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1940
97107e2e
PE
1941 * xgselect.c (xg_select): Put maxfds+1 into a var.
1942 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1943
12959e8e
PE
1944 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1945
836d29b3
DA
19462012-05-10 Dave Abrahams <dave@boostpro.com>
1947
1948 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1949 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1950
5cb67954
MA
19512012-05-09 Michael Albinus <michael.albinus@gmx.de>
1952
1953 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1954 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1955 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1956 Initialize xd_registered_buses.
1957
3478ec45
PE
19582012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1959
b263a6b0
PE
1960 Untag more efficiently if USE_LSB_TAG.
1961 This is based on a proposal by YAMAMOTO Mitsuharu in
1962 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1963 For an admittedly artificial (nth 8000 longlist) benchmark on
1964 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1965 Emacs's overall text size by 1%.
1966 * lisp.h (XUNTAG): New macro.
1967 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1968 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1969 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1970 * eval.c (Fautoload):
1971 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1972 * frame.h (XFRAME): Use XUNTAG.
1973
3478ec45
PE
1974 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1975 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1976 Remove unportable assumptions about print widths of types like
1977 dbus_uint32_t.
1978 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1979 intptr_t when converting between pointer and integer, to avoid GCC
1980 warnings about wrong width.
1981
666b903b 19822012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1983
1984 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1985 stack for each reader_thread, instead of defaulting to 8MB
1986 determined by the linker. This avoids failures in creating
1987 subprocesses on Windows 7, see the discussion in this thread:
1988 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1989
b120cc17
JC
19902012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1991
1992 Fix up display of the *Minibuf-0* buffer in the mini window.
1993 * keyboard.c (read_char): Don't clear the echo area if there's no
1994 message to clear.
1995 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1996 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1997
9a4b36f8
MA
19982012-05-07 Michael Albinus <michael.albinus@gmx.de>
1999
2000 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2001 batch mode.
2002
e5f9458f
CY
20032012-05-06 Chong Yidong <cyd@gnu.org>
2004
2005 * lisp.mk (lisp): Update.
2006
eceeb5fc 20072012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2008
2009 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2010
71873e2b
SM
20112012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2012
2013 * data.c (PUT_ERROR): New macro.
2014 (syms_of_data): Use it. Add new error type `user-error'.
2015 * undo.c (user_error): New function.
2016 (Fprimitive_undo): Use it.
2017 * print.c (print_error_message): Adjust print style for `user-error'.
2018 * keyboard.c (user_error): New function.
2019 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2020
ab0fa4e4
PE
20212012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 Do not limit current-time-string to years 1000..9999.
2024 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2025 (Fcurrent_time_string): Support any year that is supported by the
2026 underlying localtime representation. Don't use asctime, as it
2027 has undefined behavior for years outside the range -999..9999.
2028
7ed806a7
PE
20292012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2030
2031 Fix race conditions involving setenv, gmtime, localtime, asctime.
2032 Without this fix, interrupts could mess up code that uses these
2033 nonreentrant functions, since setting TZ invalidates existing
2034 tm_zone or tzname values, and since most of these functions return
2035 pointers to static storage.
2036 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2037 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2038 Grow the critical sections to include not just invoking
2039 localtime/gmtime, but also accessing these functions' results
2040 including their tm_zone values if any, and any related TZ setting.
2041 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2042 so that the struct tm is saved in the critical section.
2043 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2044 motivated by the fact that memory allocation needs to be outside
2045 the critical section.
2046
0c16dfed
DA
20472012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2048
2049 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2050 with RESET_INTERVAL.
2051
2052 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2053 Remove duplicated buffer name initialization.
2054
3f83ace8
JM
20552012-05-02 Jim Meyering <jim@meyering.net>
2056
2057 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2058
c7b8541e
JM
2059 * xfns.c (x_window): Use xstrdup (Bug#11375).
2060
90207a15 20612012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2062
2063 * xdisp.c (pos_visible_p): If already at a newline from the
2064 display string before the 'while' loop, don't walk back the glyphs
2065 from it3.glyph_row. Solves assertion violation when the display
2066 string begins with a newline (egg.el). (Bug#11367)
2067
b593d6a9
AH
20682012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2069
2070 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2071 Move to simple.el.
2072
4737362e
GM
20732012-05-01 Glenn Morris <rgm@gnu.org>
2074
99cf43f9
GM
2075 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2076 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2077 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2078 All were removed before 23.1.
2079
9311dcff
GM
2080 * dispnew.c: Remove HAVE_LIBNCURSES test;
2081 it is always true on relevant platforms.
2082
4d5c6349
GM
2083 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2084 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2085
4737362e
GM
2086 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2087
74dd3a6b
AS
20882012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2089
2090 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2091 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2092 Remove.
2093
13c379ee
PE
20942012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 Do not avoid creating empty evaporating overlays (Bug#9642).
2097 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2098 That is, do not delete an evaporating overlay if it becomes
2099 empty after its bounds are adjusted to fit within its buffer.
2100 This fix caused other problems, and I'm reverting it until we get
2101 to the bottom of them.
2102
a8e7d6d7 21032012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2104
2105 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2106
a8e7d6d7 21072012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2108
2109 * xdisp.c (pos_visible_p): If the window start position is beyond
2110 ZV, start the display from buffer beginning. Prevents assertion
2111 violation in init_iterator when the minibuffer window is scrolled
2112 via the scroll bar.
2113
2114 * window.c (window_scroll_pixel_based): Likewise.
2115
a8e7d6d7 21162012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2117
2118 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2119
a8e7d6d7 21202012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2121
2122 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2123 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2124
a8e7d6d7 21252012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2126
b593d6a9
AH
2127 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2128 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2129
1c6900d9
EZ
21302012-04-26 Eli Zaretskii <eliz@gnu.org>
2131
4c3fa1d9
EZ
2132 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2133 display element, check also the underlying string or buffer
2134 character. (Bug#11341)
2135
1c6900d9
EZ
2136 * w32menu.c: Include w32heap.h.
2137 (add_menu_item): If the call to AppendMenuW (via
2138 unicode_append_menu) fails, disable Unicode menus only if we are
2139 running on Windows 9X/Me.
2140
42bf8205
AS
21412012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2142
2143 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2144 (xgetint): Add missing shift for LSB tags.
2145
b1bac16e
MR
21462012-04-24 Martin Rudalics <rudalics@gmx.at>
2147
2148 * keyboard.c (read_char): Don't wipe echo area for select window
2149 events: These might get delayed via `mouse-autoselect-window'
2150 (Bug#11304).
2151
d69621cc
JB
21522012-04-24 Juanma Barranquero <lekktu@gmail.com>
2153
2154 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2155 manipulation of :loaded-from data.
2156
02fd101b
JB
21572012-04-23 Juanma Barranquero <lekktu@gmail.com>
2158
2159 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2160 now a cons (bug#11311).
2161
888bec30
PE
21622012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2163
89a438bd
PE
2164 Do not create empty overlays with the evaporate property (Bug#9642).
2165 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2166 if it becomes empty after its bounds are adjusted to fit within
2167 its buffer. Without this fix, in a nonempty buffer (let ((o
2168 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2169 yields an empty overlay that has the evaporate property, which is
2170 not supposed to happen.
2171
1068fe4d
PE
2172 Fix minor GTK3 problems found by static checking.
2173 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2174 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2175 (struct _EmacsFixedClass, emacs_fixed_get_type):
2176 Move decls here from emacsgtkfixed.h, since they needn't be public.
2177 (emacs_fixed_get_type): Now static.
2178 (emacs_fixed_class_init): Omit unused local.
2179 (emacs_fixed_child_type): Remove; unused.
2180 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2181 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2182 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2183 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2184 (EMACS_FIXED_GET_CLASS): Remove; unused.
2185 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2186
888bec30
PE
2187 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2188 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2189
de85e130
PE
21902012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2191
d0baac98 2192 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2193 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2194 (__malloc_size_t, __malloc_ptrdiff_t):
2195 Remove. All uses removed, replaced by the definiens if needed,
2196 since we can assume C89 or better now.
2197 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2198 (protect_malloc_state, align, get_contiguous_space)
2199 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2200 (malloc_atfork_handler_child, malloc_enable_thread)
2201 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2202 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2203 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2204 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2205 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2206 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2207 Define using prototypes, not old style.
2208 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2209 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2210 (align): Don't assume that signed integer overflow wraps around.
2211 Omit unused local var.
2212 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2213 (_free_internal_nolock, memalign, mallochook, reallochook):
2214 Omit no-longer-needed casts.
2215 (valloc): Use getpagesize, not __getpagesize.
2216 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2217 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2218
de85e130
PE
2219 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2220
dcbf5805
MA
22212012-04-22 Michael Albinus <michael.albinus@gmx.de>
2222
2223 Move functions from C to Lisp. Make non-blocking method calls
2224 the default. Implement further D-Bus standard interfaces.
2225
2226 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2227 (QCdbus_request_name_allow_replacement)
2228 (QCdbus_request_name_replace_existing)
2229 (QCdbus_request_name_do_not_queue)
2230 (QCdbus_request_name_reply_primary_owner)
2231 (QCdbus_request_name_reply_in_queue)
2232 (QCdbus_request_name_reply_exists)
2233 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2234 (QCdbus_registered_serial, QCdbus_registered_method)
2235 (QCdbus_registered_signal): New Lisp objects.
2236 (XD_DEBUG_MESSAGE): Use sizeof.
2237 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2238 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2239 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2240 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2241 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2242 (xd_signature, xd_append_arg): Allow float for integer types.
2243 (xd_get_connection_references): New function.
b593d6a9
AH
2244 (xd_get_connection_address): Rename from xd_initialize.
2245 Return cached address.
dcbf5805
MA
2246 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2247 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2248 level.
2249 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2250 Return number of refcounts.
dcbf5805
MA
2251 (Fdbus_get_unique_name): Make stronger parameter check.
2252 (Fdbus_message_internal): New defun.
2253 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2254 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2255 (Fdbus_send_signal, Fdbus_register_service)
2256 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2257 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2258 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2259 (Vdbus_compiled_version, Vdbus_runtime_version)
2260 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2261 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2262 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2263 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2264 Adapt docstring.
dcbf5805 2265
52828e02
PE
22662012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2267
da05bc4c
PE
2268 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2269 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2270 Do not assume ptrdiff_t is the same width as 'int'.
2271
52828e02
PE
2272 * alloc.c: Handle unusual debugging option combinations.
2273 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2274 since the two debugging options are incompatible.
2275 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2276 is defined.
2277 (mem_init, mem_insert, mem_insert_fixup):
2278 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2279 (NEED_MEM_INSERT): Remove; no longer needed.
2280
f01769f9
LL
22812012-04-22 Leo Liu <sdl.web@gmail.com>
2282
2283 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2284
5790543d
PE
22852012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 * sysdep.c [__FreeBSD__]: Minor cleanups.
2288 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2289 Use Emacs indenting style more consistently. Avoid some casts.
2290 Use 'double' consistently rather than mixing 'float' and 'double'.
2291
b91b7e4d
EW
22922012-04-21 Eduard Wiebe <usenet@pusto.de>
2293
b593d6a9
AH
2294 * sysdep.c (list_system_processes, system_process_attributes):
2295 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2296
6114eb15
AS
22972012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2298
2299 * lisp.mk (lisp): Update.
2300
2f38dff7
PE
23012012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2304 It is never used otherwise.
2305
4ae29f89
SM
23062012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2307
2308 * print.c (print_preprocess): Only check print_depth if print-circle
2309 is nil.
2310 (print_object): Check for cycles even when print-circle is nil and
2311 print-gensym is t, but only check print_depth if print-circle is nil.
2312
f30d612a
CY
23132012-04-20 Chong Yidong <cyd@gnu.org>
2314
2315 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2316 set the status to "failed" and ensure that sentinel is run.
2317
c07a4c0b 23182012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2319
2320 * process.c (Fset_process_inherit_coding_system_flag)
2321 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2322 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2323
c07a4c0b 23242012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2325
2326 * xdisp.c (string_buffer_position_lim): Limit starting position to
2327 BEGV.
2328 (set_cursor_from_row): If called for a mode-line or header-line
2329 row, return zero immediately.
2330 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2331 farther than the first row after the header line, if any.
2332 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2333 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2334
c07a4c0b 23352012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2336
4ae29f89
SM
2337 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2338 (bug#11238).
ad3a2b41 2339
c07a4c0b 23402012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 23412012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2342
2343 configure: new option --enable-gcc-warnings (Bug#11207)
2344 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2345 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2346 (ALL_CFLAGS): Use new macros rather than old.
2347 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2348 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2349 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2350 -Wunused-result, -Wunused-variable. This should go away once
2351 the Emacs and Gnulib regex code is merged.
2352 (xmalloc, xrealloc): Now static.
2353
aba027e8
PE
23542012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 * dired.c (Fsystem_groups): Remove unused local.
2357
e5a36063
GM
23582012-04-17 Glenn Morris <rgm@gnu.org>
2359
2360 * dired.c (Fsystem_users): Doc fix.
2361
316411f0
DA
23622012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2363
2364 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2365 (syms_of_dired): Add them.
2366
9426aba4
PE
23672012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2368
b62a57be
PE
2369 Fix minor alloc.c problems found by static checking.
2370 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2371 New extern decls, to avoid calling undeclared functions.
2372 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2373 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2374 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2375 (NEED_MEM_INSERT): New macro.
2376 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2377 Remove one incorrect comment and fix another.
b62a57be 2378
3539f31f
PE
2379 Fix minor ralloc.c problems found by static checking.
2380 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2381 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2382 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2383 (r_alloc_sbrk): Now static.
2384
a041960a
PE
2385 Improve ralloc.c interface checking.
2386 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2387 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2388 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2389 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2390 [REL_ALLOC]: ... to here, to check interface.
2391 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2392 Remove decls. This fixes an "It stinks!".
2393
9426aba4
PE
2394 * alloc.c (which_symbols): Fix alignment issue / type clash.
2395
d55c12ed
AS
23962012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2397
2398 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2399 (struct Lisp_Misc_Any): Likewise.
2400 (struct Lisp_Free): Likewise.
2401 * alloc.c (union aligned_Lisp_Symbol): Define.
2402 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2403 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2404 (union aligned_Lisp_Misc): Define.
2405 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2406 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2407 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2408
b948ce8b
PE
24092012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2410
2411 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2412 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2413 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2414 * s/netbsd.h, s/sol2-6.h:
2415 Remove definition of GC_MARK_STACK, since the default now works.
2416 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2417 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2418 no longer the default.
2419 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2420
35dc09a1 24212012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2422
35dc09a1
GM
2423 * lread.c (lisp_file_lexically_bound_p):
2424 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2425
35dc09a1
GM
24262012-04-14 Eli Zaretskii <eliz@gnu.org>
2427
2428 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2429 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2430
24312012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2432
2433 * nsterm.m (constrainFrameRect): Always constrain when there is only
2434 one screen (Bug#10962).
2435
bcd86815
KB
24362012-04-13 Ken Brown <kbrown@cornell.edu>
2437
2438 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2439
c25df26e
RT
24402012-04-13 Reuben Thomas <rrt@sc3d.org>
2441
2442 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2443
0fc59f1e
DC
24442012-04-11 Daniel Colascione <dancol@dancol.org>
2445
2446 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2447 against is gone. It's better to use vfork now so that when Cygwin
2448 gains a new, working vfork, we use it automatically (bug#10398).
2449
de8c03dc
SM
24502012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2451
2452 * window.c (save_window_save): Obey window-point-insertion-type.
2453
2f097256
GM
24542012-04-11 Glenn Morris <rgm@gnu.org>
2455
2456 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2457
453b951e
SM
24582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2459
2460 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2461
75f1671a 24622012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2463
2464 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2465 (force_quit_count): New var.
2466 (handle_interrupt): Use it.
2467
2a8ce227
JB
24682012-04-10 Juanma Barranquero <lekktu@gmail.com>
2469
2470 * w32.c (w32_delayed_load): Record the full path of the library
2471 being loaded (bug#10424).
2472
935396c0
GM
24732012-04-09 Glenn Morris <rgm@gnu.org>
2474
05920a43
GM
2475 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2476 not just in the obarray, before snarfing them. (Bug#11036)
2477
935396c0
GM
2478 * Makefile.in ($(leimdir)/leim-list.el):
2479 Pass EMACS rather than BUILT_EMACS.
2480
a18ecafa
TZ
24812012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2482
2483 * process.c (make_process):
2484 * process.h: Add integer `gnutls_handshakes_tried' member to
2485 process struct.
2486
6bbef4e5
JC
2487 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2488 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2489
2490 * gnutls.c (gnutls_log_function2i): Convenience log function.
2491 (emacs_gnutls_read): Use new log functions,
2492 `gnutls_handshakes_tried' process member, and
2493 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2494 attempts per process (connection).
2495
b4d3bc10
CY
24962012-04-09 Chong Yidong <cyd@gnu.org>
2497
2498 * eval.c (Fuser_variable_p, user_variable_p_eh)
2499 (lisp_indirect_variable): Functions deleted.
2500 (Fdefvar): Caller changed.
2501
2502 * callint.c (Finteractive, Fcall_interactively):
2503 * minibuf.c (Fread_variable): Callers changed.
2504
70f4d973
EZ
25052012-04-09 Eli Zaretskii <eliz@gnu.org>
2506
2507 * xdisp.c (set_cursor_from_row): If the display string appears in
2508 the buffer at position that is closer to point than the position
2509 after the display string, display the cursor on the first glyph of
2510 the display string. Fixes cursor display when a 'display' text
2511 property immediately follows invisible text. (Bug#11094)
2512
cb3c2e3e
PE
25132012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2514
2515 composite.c: use 'double' consistently
2516 * composite.c (get_composition_id): Use 'double' consistently
2517 instead of converting 'float' to 'double' and vice versa; this is
2518 easier to understand and avoids a GCC warning.
2519
fd06db5d
GM
25202012-04-09 Glenn Morris <rgm@gnu.org>
2521
50fe702a
GM
2522 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2523 preparation for dumping it with emacs. (Bug#4789)
2524 (leimdir): New variable.
2525 ($(leimdir)/leim-list.el): New rule.
2526 (emacs$(EXEEXT)): Depend on leim-list.el.
2527
fd06db5d
GM
2528 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2529 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2530 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2531
55c131ee
AS
25322012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2533
2534 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2535 proper alignment.
2536
9209588f
JB
25372012-04-07 Juanma Barranquero <lekktu@gmail.com>
2538
2539 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2540 Remove unused local variable.
2541
e3fb2efb
PE
25422012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2543
2544 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2545 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2546 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2547 objects, as mark_maybe_pointer will catch them otherwise.
2548 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2549 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2550
b5385551
PE
25512012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2552
2553 Fix typo that broke non-Windows builds.
2554 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2555
9078ead6
EZ
25562012-04-07 Eli Zaretskii <eliz@gnu.org>
2557
2558 Support building on MS-Windows with libxml2.
2559
2560 * makefile.w32-in (OBJ2): Add xml.$(O).
2561 (GLOBAL_SOURCES): Add xml.c.
2562 ($(BLD)/xml.$(O)): New dependency list.
2563
2564 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2565 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2566 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2567 [!WINDOWSNT]: New macros.
2568 (init_libxml2_functions, libxml2_loaded_p): New functions.
2569 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2570 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2571 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2572 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2573 linked in).
6bbef4e5
JC
2574 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2575 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2576 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2577
2578 * emacs.c: Don't include libxml/parser.h.
2579 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2580 xmlCleanupParser directly.
2581
2582 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2583
3811fdf3
EZ
25842012-04-07 Eli Zaretskii <eliz@gnu.org>
2585
2586 * indent.c (Fvertical_motion): If there is a display string at
2587 point, use it.vpos to compute how many lines to backtrack after
2588 move_it_to point. (Bug#11133)
2589
2f8e16b2
EZ
25902012-04-06 Eli Zaretskii <eliz@gnu.org>
2591
2592 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2593 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2594 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2595 macros related to unification of CJK characters. For the details,
2596 see the discussion following the message here:
2597 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2598
3d439cd1
CY
25992012-04-04 Chong Yidong <cyd@gnu.org>
2600
2601 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2602
8bc53d00
EZ
26032012-04-01 Eli Zaretskii <eliz@gnu.org>
2604
2605 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2606 instead of alloca. (Bug#11138)
2607
3b0512a3
AS
26082012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2609
2610 * w32menu.c (is_simple_dialog): Properly check lisp types.
2611 (Bug#11141)
2612
8427ddd2
EZ
26132012-03-31 Eli Zaretskii <eliz@gnu.org>
2614
979022ef
EZ
2615 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2616 position we get to after a call to move_it_to fails the
2617 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2618 only if we wind up in a string from display property. (Bug#11063)
2619
a6b1c7cc
EZ
2620 * window.c (Fdelete_other_windows_internal): Invalidate the row
2621 and column information about mouse highlight, so that redisplay
2622 restores it after reallocating the glyph matrices. (Bug#7464)
2623
8427ddd2
EZ
2624 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2625 string comes from a `display' text property, use the buffer
2626 position of that property as if we actually saw that position in
2627 the row's glyphs.
697ba24b
EZ
2628 (move_it_by_lines): Remove the assertion that
2629 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2630 violated when there's a before-string at the beginning of a line.
2631 (Bug#11063)
8427ddd2 2632
65a0a738
EZ
26332012-03-30 Eli Zaretskii <eliz@gnu.org>
2634
2635 * xdisp.c (append_space_for_newline): If the default face was
2636 remapped, use the remapped face for the appended newline.
2637 (extend_face_to_end_of_line): Use the remapped default face for
2638 extending the face to the end of the line.
2639 (display_line): Call extend_face_to_end_of_line when the default
2640 face was remapped. (Bug#11068)
2641
581355cc
EZ
26422012-03-29 Eli Zaretskii <eliz@gnu.org>
2643
2644 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2645
e8fc049f
SM
26462012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2647
2648 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2649
4fb9a543
GM
26502012-03-27 Glenn Morris <rgm@gnu.org>
2651
2652 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2653 Doc fixes.
2654
679910f1
KH
26552012-03-26 Kenichi Handa <handa@m17n.org>
2656
2657 * dispextern.h (struct glyph): Fix previous change. Change the
2658 bit length of glyphless.ch to 25 (Bug#11082).
2659
90d49b7f
CY
26602012-03-26 Chong Yidong <cyd@gnu.org>
2661
2662 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2663 (command_loop_1): Use it; inhibit selection update for
2664 handle-select-window too (Bug#8996).
2665
f514f6f0
FP
26662012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2667
e8fc049f 2668 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2669
bf43fa51
KH
26702012-03-25 Kenichi Handa <handa@m17n.org>
2671
2672 * dispextern.h (struct glyph): Change the bit length of
2673 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2674
8a0c01dd
EZ
26752012-03-24 Eli Zaretskii <eliz@gnu.org>
2676
2677 * s/ms-w32.h (tzname): Include time.h before redirecting to
2678 _tzname. Fixes the MSVC build. (Bug#9960)
2679
7d1c3a76
AS
26802012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2681
8ed79523
AS
2682 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2683 characters.
2684
7d1c3a76
AS
2685 * xterm.c (XTread_socket): Only modify handling_signal if
2686 !SYNC_INPUT. (Bug#11080)
2687
e99a9b8b
EZ
26882012-03-23 Eli Zaretskii <eliz@gnu.org>
2689
2690 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2691 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2692 when fetching a multibyte character consumes more bytes than
2693 CHAR_BYTES returns, due to unification of CJK characters in
2694 string_char. (Bug#11073)
2695
5063c0e1
TN
26962012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2697
2698 * process.c (wait_reading_process_output): Handle pty disconnect
2699 by refraining from sending oneself a SIGCHLD (bug#10933).
2700
9f851fbd
CY
27012012-03-22 Chong Yidong <cyd@gnu.org>
2702
2703 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2704
5063c0e1 2705 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2706 Mark string as coming from a prefix property.
2707 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2708 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2709
fb5b8aca
CY
27102012-03-21 Chong Yidong <cyd@gnu.org>
2711
2712 * xfaces.c (Vface_remapping_alist): Doc fix.
2713
62356a1b
EZ
27142012-03-20 Eli Zaretskii <eliz@gnu.org>
2715
2716 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2717 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2718 Doc fixes.
62356a1b 2719
025de85b
CY
27202012-03-20 Chong Yidong <cyd@gnu.org>
2721
2722 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2723 to reflect default non-nil value of redisplay-dont-pause.
2724
4827f94e
KH
27252012-03-19 Kenichi Handa <handa@m17n.org>
2726
2727 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2728 it fit in a valid range (Bug#11003).
2729
e50a24a2
EZ
27302012-03-18 Eli Zaretskii <eliz@gnu.org>
2731
2732 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2733 that is not from display property, accept the row as a "cursor
2734 row" if one of the string's character has a non-nil `cursor'
2735 property. Fixes cursor positioning when there are newlines in
2736 overlay strings, e.g. in icomplete.el. (Bug#11035)
2737
9af5ed87
PE
27382012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2741
d1f55f16
CY
27422012-03-12 Chong Yidong <cyd@gnu.org>
2743
2744 * eval.c (inhibit_lisp_code): Rename from
2745 inhibit_window_configuration_change_hook; move from window.c.
2746
2747 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2748 * window.c (run_window_configuration_change_hook)
2749 (syms_of_window): Callers changed.
2750
66c5eebd
CY
27512012-03-11 Chong Yidong <cyd@gnu.org>
2752
413df973
CY
2753 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2754
66c5eebd
CY
2755 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2756
1de11f56
CY
27572012-03-10 Chong Yidong <cyd@gnu.org>
2758
2759 * frame.c (other_visible_frames): Don't assume the selected frame
2760 is visible (Bug#10955).
2761
cae07000
SM
27622012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2763
2764 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2765
89c94350
JD
27662012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2767
2768 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2769 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2770 zero (Bug#10954).
2771
999dd333
GM
27722012-03-03 Glenn Morris <rgm@gnu.org>
2773
01a6dcc8 2774 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2775
de0100f2
EZ
27762012-03-02 Eli Zaretskii <eliz@gnu.org>
2777
2778 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2779 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2780 (redisplay_window, next_element_from_string): Fix typos in
2781 comments.
3e441275
EZ
2782 (redisplay_window): Pass to move_it_vertically the margin in
2783 pixels, not in screen lines.
de0100f2 2784
96a72ee9
GM
27852012-03-02 Glenn Morris <rgm@gnu.org>
2786
2787 * buffer.c (buffer-list-update-hook): Doc fix.
2788
312508d7
EZ
27892012-02-29 Eli Zaretskii <eliz@gnu.org>
2790
2791 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2792 push_it before setting up the iterator for the first overlay
2793 string, even if we have an empty string loaded.
2794 (next_overlay_string): If there's an empty string on the iterator
2795 stack, pop the stack. (Bug#10903)
2796
27f3c637
PE
27972012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2798
2799 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2800 Suggested by Stefan Monnier in
2801 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2802 * alloc.c (widen_to_Lisp_Object): New static function.
2803 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2804 and widening them to Lisp_Objects. This would work even if
2805 USE_LSB_TAG is defined and wide integers are used, which might
2806 happen in a future version of Emacs.
2807
3c9dfce6
CY
28082012-02-25 Chong Yidong <cyd@gnu.org>
2809
fa74b241
CY
2810 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2811 Doc fix.
2812
3c9dfce6
CY
2813 * xselect.c (Fx_selection_exists_p): Doc fix.
2814 (x_clipboard_manager_save_all): Print an informative message
2815 before saving to clipboard manager.
2816
9486df08
CY
28172012-02-24 Chong Yidong <cyd@gnu.org>
2818
2819 * keyboard.c (process_special_events): Handle all X selection
2820 requests in kbd_buffer, not just the next one (Bug#8869).
2821
f01d3321
CY
28222012-02-23 Chong Yidong <cyd@gnu.org>
2823
2824 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2825 call when setting menu-bar-lines and tool-bar-lines parameters.
2826 (unwind_create_frame_1): New helper function.
2827
2828 * window.c (inhibit_window_configuration_change_hook): New var.
2829 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2830 (syms_of_window): Initialize it.
f01d3321 2831
86b847b6
CY
28322012-02-22 Chong Yidong <cyd@gnu.org>
2833
2834 * xterm.c (x_draw_image_relief): Add missing type check for
2835 Vtool_bar_button_margin (Bug#10743).
2836
a59225b1
CY
28372012-02-21 Chong Yidong <cyd@gnu.org>
2838
2839 * fileio.c (Vfile_name_handler_alist): Doc fix.
2840
2841 * buffer.c (Fget_file_buffer): Protect against invalid file
2842 handler return value.
2843
310f5bd4
PE
28442012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2845
cb3a28cc
PE
2846 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2847 when computing $valmask.
2848
310f5bd4
PE
2849 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2850 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2851 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2852 It's useless in that case, and it can cause problems on hosts
2853 that allocate halves of EMACS_INT values separately.
2854 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2855 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2856 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2857 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2858 it avoids undefined behavior on hosts where shifting right by more
2859 than the word width has undefined behavior.
2860
2375c96a
CY
28612012-02-19 Chong Yidong <cyd@gnu.org>
2862
2863 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2864 (Funhandled_file_name_directory, Ffile_name_as_directory)
2865 (Fdirectory_file_name, Fexpand_file_name)
2866 (Fsubstitute_in_file_name): Protect against invalid file handler
2867 return values (Bug#10845).
2868
3eb49e71
EZ
28692012-02-18 Eli Zaretskii <eliz@gnu.org>
2870
2871 * .gdbinit (pitx): Fix incorrect references to fields of the
2872 iterator stack.
2873
7b926f3f
CY
28742012-02-17 Chong Yidong <cyd@gnu.org>
2875
2876 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2877
11273115
PE
28782012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2879
2880 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2881 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2882
c3a70e2b
CY
28832012-02-15 Chong Yidong <cyd@gnu.org>
2884
2885 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2886 marked as special. Also, starting docstrings with * is obsolete.
2887
0ca43699
AS
28882012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2889
2890 * gnutls.c (emacs_gnutls_write): Fix last change.
2891
2e8f3c56
LI
28922012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2893
2894 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2895 send_process.
2896
af70074f
SM
28972012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2898
2899 * keymap.c (Fsingle_key_description): Handle char ranges.
2900
95986d52
CY
29012012-02-12 Chong Yidong <cyd@gnu.org>
2902
afd83bd1
CY
2903 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2904 as that creates a dangerous corner case.
2905
95986d52
CY
2906 * window.c (Fdelete_window_internal): Invalidate the mouse
2907 highlight (Bug#9904).
2908
bd7da63e
GM
29092012-02-12 Glenn Morris <rgm@gnu.org>
2910
2911 * xselect.c (Fx_own_selection_internal)
2912 (Fx_get_selection_internal, Fx_disown_selection_internal)
2913 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2914 * nsselect.m (Fx_own_selection_internal)
2915 (Fx_disown_selection_internal, Fx_selection_exists_p)
2916 (Fx_selection_owner_p, Fx_get_selection_internal):
2917 Sync docs and argument specs with the xselect.c versions.
2918
77abcbc2
LI
29192012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2920
2921 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2922
90b671e2
EZ
29232012-02-11 Eli Zaretskii <eliz@gnu.org>
2924
1c0ca0b7
EZ
2925 * w32select.c (Fx_selection_exists_p): Sync doc string and
2926 argument list with xselect.c. (Bug#10783)
2927
2928 * w16select.c (Fx_selection_exists_p): Sync doc string and
2929 argument list with xselect.c. (Bug#10783)
90b671e2 2930
49241268
GM
29312012-02-10 Glenn Morris <rgm@gnu.org>
2932
2933 * fns.c (Fsecure_hash): Doc fix.
2934
f998bbe7 29352012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2936
2937 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2938
0992bd9c
CY
29392012-02-07 Chong Yidong <cyd@gnu.org>
2940
2941 * buffer.c (Fbuffer_local_variables)
2942 (buffer_lisp_local_variables): Handle unbound vars correctly;
2943 don't let Qunbound leak into Lisp.
2944
af008560
GM
29452012-02-07 Glenn Morris <rgm@gnu.org>
2946
dd605cc4
GM
2947 * image.c (Fimagemagick_types): Doc fix.
2948
af008560
GM
2949 * image.c (imagemagick-render-type): Change it from a lisp object
2950 to an integer. Move the doc here from the lisp manual.
2951 Treat all values not equal to 0 the same.
2952
1449fa1d
CY
29532012-02-06 Chong Yidong <cyd@gnu.org>
2954
2955 * doc.c (store_function_docstring): Avoid applying docstring of
2956 alias to base function (Bug#2603).
2957
3723ec07
AS
29582012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2959
2960 * .gdbinit (pp1, pv1): Remove redundant defines.
2961 (pr): Use pp.
2962
79c1cc1e
CY
29632012-02-04 Chong Yidong <cyd@gnu.org>
2964
2965 * nsterm.m: Declare a global (Bug#10694).
2966
d7f29f8e
EZ
29672012-02-04 Eli Zaretskii <eliz@gnu.org>
2968
cae07000
SM
2969 * w32.c (get_emacs_configuration_options):
2970 Include --enable-checking, if specified, in the return value.
d7f29f8e 2971
3b95a6f9
MR
29722012-02-04 Martin Rudalics <rudalics@gmx.at>
2973
2974 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2975 after rounding frame sizes. (Bug#9723)
2976
d6fa96a6
EZ
29772012-02-04 Eli Zaretskii <eliz@gnu.org>
2978
2979 * keyboard.c (adjust_point_for_property): Don't position point
2980 before BEGV. (Bug#10696)
2981
df0b2940
PE
29822012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2983
2984 Handle overflow when computing char display width (Bug#9496).
2985 * character.c (char_width): Return EMACS_INT, not int.
2986 (char_width, c_string_width): Check for overflow when
2987 computing the width; this is possible now that individual
2988 characters can have unbounded width. Problem introduced
2989 by merge from Emacs 23 on 2012-01-19.
2990
6bee44d6
MA
29912012-02-02 Michael Albinus <michael.albinus@gmx.de>
2992
2993 * dbusbind.c (Fdbus_register_method): Mention the return value
2994 :ignore in the docstring.
2995
44f92739
GM
29962012-02-02 Glenn Morris <rgm@gnu.org>
2997
1b9f60cc
GM
2998 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2999
44f92739
GM
3000 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3001 Unconditionally set to t. (Bug#10673)
3002 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3003 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3004 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3005
c5d3843c
KH
30062012-02-02 Kenichi Handa <handa@m17n.org>
3007
3008 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3009 0, do not call append_composite_glyph.
3010
159462d4 30112012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3012
3013 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3014 NULL (Bug#6988).
3015 (x_produce_glyphs): If the component of a composition is a null
3016 string, set it->pixel_width to 1 to avoid zero-width glyph.
3017
78cef877
EZ
30182012-02-01 Eli Zaretskii <eliz@gnu.org>
3019
3020 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3021 first 2 arguments are identical. This makes inserting large
3022 output from a subprocess an order of magnitude faster on
3023 MS-Windows, where all sbrk'ed memory is always contiguous.
3024
97897668
GM
30252012-01-31 Glenn Morris <rgm@gnu.org>
3026
3027 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3028 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3029 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3030
31fd3586
GM
30312012-01-29 Glenn Morris <rgm@gnu.org>
3032
3033 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3034
0e24a8b2
CY
30352012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3036
3037 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3038
cc0adcb0
CY
30392012-01-28 Chong Yidong <cyd@gnu.org>
3040
3041 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3042
acc28cb9
CY
30432012-01-26 Chong Yidong <cyd@gnu.org>
3044
9c69cfb7
CY
3045 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3046
acc28cb9
CY
3047 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3048 repeat counts (Bug#10507).
3049
48da7392
GM
30502012-01-26 Glenn Morris <rgm@gnu.org>
3051
3052 * lread.c (syms_of_lread): Doc fix.
3053
14af5f7f
CY
30542012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3055
3056 * coding.c (encode_designation_at_bol): Change return value to
3057 EMACS_INT.
3058
0b21c100
CY
30592012-01-25 Chong Yidong <cyd@gnu.org>
3060
3061 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3062
3c2907f7
CY
30632012-01-21 Chong Yidong <cyd@gnu.org>
3064
3065 * floatfns.c (Fcopysign): Make the second argument non-optional,
3066 since nil is not allowed anyway.
3067
959ad23f
AS
30682012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3069
3070 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3071 (send_process): Likewise.
3072
34a02f46
MR
30732012-01-19 Martin Rudalics <rudalics@gmx.at>
3074
3075 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3076 (Vwindow_persistent_parameters): Do not use Qstate.
3077 Rewrite doc-strings.
34a02f46 3078
1259009a 30792012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3080
3081 * character.c (char_width): New function.
70d4fdf6
GM
3082 (Fchar_width, c_string_width, lisp_string_width):
3083 Use char_width (Bug#9496).
25ed9e61 3084
6a6ee00d
MR
30852012-01-16 Martin Rudalics <rudalics@gmx.at>
3086
3087 * window.c (Vwindow_persistent_parameters): New variable.
3088 (Fset_window_configuration, save_window_save): Handle persistent
3089 window parameters.
3090
c85efaf7
EZ
30912012-01-14 Eli Zaretskii <eliz@gnu.org>
3092
3093 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3094 thrashing the stack of the thread. (Bug#9087)
3095
5944709e
PE
30962012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3097
3098 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3099
e71f5d99
EZ
31002012-01-11 Eli Zaretskii <eliz@gnu.org>
3101
3102 * xdisp.c (rows_from_pos_range): Handle the case where the
3103 highlight ends on a newline. (Bug#10464)
3104 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3105 he end column for display of highlight that ends on a newline
3106 before a R2L line.
3107
ce316182
GM
31082012-01-11 Glenn Morris <rgm@gnu.org>
3109
3110 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3111 from load-path also when installation-directory is nil. (Bug#10208)
3112
5b43da69
GM
31132012-01-10 Glenn Morris <rgm@gnu.org>
3114
74cc8ff9
GM
3115 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3116
7d8d6e4e
GM
3117 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3118 Update template values to be closer to their typical values these days.
5b43da69 3119
a0db8d43
EZ
31202012-01-09 Eli Zaretskii <eliz@gnu.org>
3121
3122 * xdisp.c (rows_from_pos_range): Accept additional argument
3123 DISP_STRING, and accept any glyph in a row whose object is that
3124 string as eligible for mouse highlight. Fixes mouse highlight of
3125 display strings from overlays. (Bug#10464)
3126
9a0115ab 31272012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3128
b9110d6a 3129 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3130 * fileio.c (auto_saving_dir_umask): New static var.
3131 (Fmake_directory_internal): Use it.
3132 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3133 creating the directory. The old code temporarily assigns
3134 too-generous permissions to the directory.
3135 (do_auto_save_eh): Clear it.
b9110d6a 3136 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3137 that the var is always cleared.
3138
6c1bd3f3
EZ
31392012-01-07 Eli Zaretskii <eliz@gnu.org>
3140
3141 * search.c (scan_buffer): Pass character positions to
3142 know_region_cache, not byte positions. (Bug#6540)
3143
069d2b50
L
31442012-01-07 LynX <_LynX@bk.ru> (tiny change)
3145
3146 * w32.c (sys_rename): Report EXDEV when rename of a directory
3147 fails because the target is on another logical disk. (Bug#10284)
3148
75bf0d33
DB
31492012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3150
3151 * xterm.c (x_embed_request_focus): New function.
3152
3153 * xterm.h: Add prototype.
3154
3155 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3156
1c6e5a32
GM
31572012-01-05 Glenn Morris <rgm@gnu.org>
3158
3159 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3160
651e947e
EZ
31612012-01-01 Eli Zaretskii <eliz@gnu.org>
3162
3163 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3164 Load gnutls_transport_set_lowat only if GnuTLS version is below
3165 2.11.1.
3166 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3167 GnuTLS versions below 2.11.1.
3168
3778cdd8
AL
31692011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3170
3171 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3172 to the doc string advising against its use for altering the way
3173 windows are scrolled.
3174
0e5317f7
KH
31752011-12-28 Kenichi Handa <handa@m17n.org>
3176
3177 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3178 coding-system ASCII compatible only when it does not produce BOM
3179 on encoding (Bug#10383).
3180
93d5ca1f
JD
31812011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3182
3183 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3184 can scroll.
3185 (create_and_show_popup_menu): Always use menu_position_func for
3186 Gtk3 (Bug#10361).
3187
ca22b785
AS
31882011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3189
3190 * callint.c (Fcall_interactively): Don't truncate prompt string.
3191
d048e1e6
EZ
31922011-12-23 Eli Zaretskii <eliz@gnu.org>
3193
3194 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3195 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3196 resumed from there (after widening). (Bug#10360)
d048e1e6 3197
5ccaba1f
JD
31982011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3199
3200 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3201
204ee57f
JD
32022011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3203
b81d40f0
JB
3204 * nsterm.m (x_free_frame_resources):
3205 Release f->output_data.ns->miniimage.
204ee57f
JD
3206 (ns_index_color): Fix indentation. Do not retain
3207 color_table->colors[i].
3208
3209 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3210 before returning.
3211
3212 * nsfns.m (x_set_background_color): Assign return value from
3213 ns_index_color to face-background instead of NSColor*.
3214 (ns_implicitly_set_icon_type): Fix indentation.
3215 Change assignment in for loop to comparison.
3216
3217 * emacs.c (ns_pool): New variable.
3218 (main): Assign ns_pool.
3219 (Fkill_emacs): Call ns_release_autorelease_pool.
3220
3221 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3222 autorelease fdesc, release fdAttrs and tdict.
3223 (ns_get_covering_families): Release charset.
3224 (ns_findfonts): Release NSFontDescriptor created with new.
3225 (ns_uni_to_glyphs): Fix indentation.
3226 (setString): Release attrStr before assigning new value.
3227
c803b2b7
JD
32282011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3229
678f4426
JD
3230 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3231 and NS_IMPL_COCOA.
3232 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3233 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3234
cd394be1 32352011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3236
5fecd5fc
JD
3237 * nsterm.m (ns_term_init): Subscribe for notifications
3238 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3239 to method trackingNotification in EmacsMenu.
3240
3241 * nsmenu.m (trackingMenu): New variable.
3771cb17 3242 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3243 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3244 from Aquamacs (Bug#7030).
678f4426
JD
3245
32462011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3247
c803b2b7
JD
3248 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3249 (symbol_to_nsstring): Fix indentation.
3250 (ns_symbol_to_pb): New function.
cae07000
SM
3251 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3252 (Fns_rotate_cut_buffers_internal): Remove.
3253 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3254 Fns_store_cut_buffer_internal.
3255 (ns_get_foreign_selection, Fx_own_selection_internal)
3256 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3257 (Fns_get_selection_internal, Fns_store_selection_internal):
3258 Use ns_symbol_to_pb and check if return value is nil.
3259 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3260 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3261 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3262 renamed to Sns_store_selection_internal.
3263 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3264 and remove this function.
3265 (ns_handle_selection_clear): Remove, never used.
3266 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3267 here.
3268
e1b01a3a
KB
32692011-12-17 Ken Brown <kbrown@cornell.edu>
3270
3271 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3272 GID is unknown (Bug#10257).
3273
2adb6e85
PE
32742011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3277 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3278 which caused a build failure on GNU/Linux IA-64. This problem was
3279 introduced by my 2011-10-07 patch.
3280
d1d7b339
JL
32812011-12-15 Juri Linkov <juri@jurta.org>
3282
3283 * image.c (imagemagick_error): New function. (Bug#10112)
3284 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3285 Use `imagemagick_error' where ImageMagick functions return
3286 `MagickFalse'.
3287 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3288 proper order.
3289
100d5755
KH
32902011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3291
3292 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3293 fill background (Bug#8992).
3294
454592a6
MR
32952011-12-13 Martin Rudalics <rudalics@gmx.at>
3296
3297 * window.c (Vwindow_combination_resize)
3298 (Vwindow_combination_limit): Use t instead of non-nil in
3299 doc-strings.
61d4b438
MR
3300 (Vrecenter_redisplay): Add first sentence of doc-string on
3301 separate line.
53524d93 3302 (Frecenter): Fix doc-string typo.
454592a6 3303
3633e3aa
KH
33042011-12-11 Kenichi Handa <handa@m17n.org>
3305
3306 * coding.c (Funencodable_char_position): Pay attention to the
3307 buffer text relocation (Bug#9389).
3308
7b9d523a 33092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3310
7b9d523a
JD
3311 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3312 gtk_init (Bug#10100).
3313
b73189c6
EZ
33142011-12-10 Eli Zaretskii <eliz@gnu.org>
3315
3316 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3317 IT->string is nil. (Bug#10263)
3318
f7dfe5d6
JD
33192011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3320
83faebb4
JD
3321 * nsterm.h (x_free_frame_resources): Declare.
3322
f7dfe5d6
JD
3323 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3324 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3325
3326 * nsterm.h (ns_get_defaults_value): Declare.
3327
3328 * nsterm.m (ns_default): Call ns_get_defaults_value.
3329
7cd4e72c
EZ
33302011-12-09 Eli Zaretskii <eliz@gnu.org>
3331
3332 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3333 (Bug#10170)
3334
b34d7317
YM
33352011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3336
3337 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3338 that where the value of an _OBJC_* symbol points to is in the .bss
3339 section (Bug#10240).
3340
76470ad1
KH
33412011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3342
3343 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3344 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3345
745fff94
KH
33462011-12-08 Kenichi Handa <handa@m17n.org>
3347
3348 * ftfont.c (get_adstyle_property): Fix previous change
3349 (Bug#10233).
3350
6e44397c
JB
33512011-12-07 Juanma Barranquero <lekktu@gmail.com>
3352
3353 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3354 dirs from the default value of EMACSLOADPATH (bug#10208).
3355
7efa6272
GM
33562011-12-07 Glenn Morris <rgm@gnu.org>
3357
3358 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3359 installation and source directories as well. (Bug#10208)
3360
f6fc4d87
CY
33612011-12-06 Chong Yidong <cyd@gnu.org>
3362
3363 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3364
2bf26180
GM
33652011-12-06 Glenn Morris <rgm@gnu.org>
3366
3367 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3368 as an error, not just -1. (Bug#10217)
3369
3a6ad4f0
CY
33702011-12-05 Chong Yidong <cyd@gnu.org>
3371
3372 * keyboard.c (process_special_events): New function.
3373 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3374
75a3b399
PE
33752011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * coding.c (encode_designation_at_bol): Don't use uninitialized
3378 local variable (Bug#9318).
3379
c3c9e25e
KH
33802011-12-05 Kenichi Handa <handa@m17n.org>
3381
3382 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3383 return Qnil (Bug#8046, Bug#10193).
3384
5eb05ea3
KH
33852011-12-05 Kenichi Handa <handa@m17n.org>
3386
3387 * coding.c (encode_designation_at_bol): New args charbuf_end and
3388 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3389 (coding_set_source): Return how many bytes coding->source was
3390 relocated.
3391 (coding_set_destination): Return how many bytes
3392 coding->destination was relocated.
3393 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3394 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3395
33962011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3397
3398 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3399 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3400 macro (Bug#9318).
3401
34022011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3403
3404 The following changes are to fix Bug#9318.
3405
a79703f5 3406 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3407 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3408 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3409 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3410
7dbda6df
JB
34112011-12-05 Juanma Barranquero <lekktu@gmail.com>
3412
3413 * lisp.h (process_quit_flag): Fix external declaration.
3414
6d5eb5b0
SM
34152011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3416
3417 Don't macro-inline non-performance-critical code.
3418 * eval.c (process_quit_flag): New function.
3419 * lisp.h (QUIT): Use it.
3420
a0c3fad0
JD
34212011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3422
3423 * nsfns.m (get_geometry_from_preferences): New function.
3424 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3425
6c07aac2
AS
34262011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3427
3428 * emacs.c (Qkill_emacs): Define.
3429 (syms_of_emacs): Initialize it.
3430 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3431 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3432 (quit_throw_to_read_char): Add parameter `from_signal'.
3433 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3434 * lisp.h (QUIT): Call Fkill_emacs if requested.
3435
c052ead4
JD
34362011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3437
3438 * widget.c (update_wm_hints): Return if wmshell is null.
3439 (widget_update_wm_size_hints): New function.
3440
3441 * widget.h (widget_update_wm_size_hints): Declare.
3442
3443 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3444 widget_update_wm_size_hints (Bug#10104).
3445
9e49252b
EZ
34462011-12-03 Eli Zaretskii <eliz@gnu.org>
3447
3448 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3449 before a newline, prepare the bidi iterator for consuming the
3450 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3451 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3452
02b16839
JL
34532011-12-02 Juri Linkov <juri@jurta.org>
3454
3455 * search.c (Fword_search_regexp): New Lisp function created from
3456 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3457 (Fword_search_backward, Fword_search_forward)
3458 (Fword_search_backward_lax, Fword_search_forward_lax):
3459 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3460 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3461
0068070e
SM
34622011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3463
3464 * fileio.c (Finsert_file_contents): Move after-change-function call
3465 to before the "handled:" label, since all "goto handled" appear in
3466 cases where the *-change-functions have already been properly called
3467 (bug#10117).
3468
3360a3fc
AS
34692011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3470
3471 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3472 waiting for input. (Bug#10169)
3473
73d6c093
EZ
34742011-11-30 Eli Zaretskii <eliz@gnu.org>
3475
3476 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3477 verifies glyph row's hash code--we have just reallocated the
3478 glyphs, so their contents can be complete garbage. (Bug#10164)
3479
febe6bea
JB
34802011-11-30 Juanma Barranquero <lekktu@gmail.com>
3481
3482 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3483
801a4313
EZ
34842011-11-30 Eli Zaretskii <eliz@gnu.org>
3485
3486 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3487 attributes are tested _before_ calling verify_row_hash, to protect
3488 against GCC re-ordering of the tests. (Bug#10164)
3489
2b56b87e
JD
34902011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3491
3492 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3493
3494 * xterm.c (handle_one_xevent): Only set async_visible and friends
3495 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3496 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3497 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3498
dbf31225
PE
34992011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3500
3501 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3502 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3503 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3504 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3505 All uses changed to use GCPRO1 etc.
3506 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3507 Revert to old implementation (i.e., before 2011-03-11).
3508
1305621b
YM
35092011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3510
3511 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3512 of scroll runs so as to avoid assigning disabled bogus rows and
3513 unnecessary graphics copy operations.
3514
8c9afb46
EZ
35152011-11-27 Eli Zaretskii <eliz@gnu.org>
3516
3517 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3518 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3519 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3520 (malloc, free, realloc, calloc): Redirect to e_* only when
3521 compiling Emacs.
3522
3523 * lisp.h (GCTYPEBITS): Move before first use.
3524 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3525 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3526 this macro definition.
3527
3528 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3529 _MSC_VER.
3530
54e9e3bf
JD
35312011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3532
6d5eb5b0
SM
3533 * gtkutil.c (xg_create_frame_widgets):
3534 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3535 present with Gtk+ 2.0.
3536
83aca1cb
PE
35372011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 * fileio.c (Finsert_file_contents): Undo previous change; see
3540 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3541
5b76caa4
PE
35422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3543
3544 Rename locals to avoid shadowing.
3545 * fileio.c (Finsert_file_contents):
3546 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3547 * process.c (wait_reading_process_output):
3548 Rename inner 'proc' to 'p' to avoid shadowing.
3549 Indent for consistency with usual Emacs style.
3550
8c535114
EZ
35512011-11-25 Eli Zaretskii <eliz@gnu.org>
3552
3553 * xdisp.c (redisplay_window): If cursor row is not fully visible
3554 after recentering, and scroll-conservatively is set to a large
3555 number, scroll window by a few more lines to make the cursor fully
3556 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3557 (start_display): Don't move to the next line if the display should
3558 start at a newline that is part of a display vector or an overlay
3559 string. (Bug#10119)
8c535114 3560
fa4fdb5c
JL
35612011-11-24 Juri Linkov <juri@jurta.org>
3562
3563 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3564 after the `MagickPingImage' call. (Bug#10112)
3565
90ec88df
CY
35662011-11-23 Chong Yidong <cyd@gnu.org>
3567
3568 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3569
56e2e794
MR
35702011-11-23 Martin Rudalics <rudalics@gmx.at>
3571
3572 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3573 making another buffer current. (Bug#10114)
3574
b6e64c41
GM
35752011-11-23 Glenn Morris <rgm@gnu.org>
3576
3577 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3578
6b21de18
CY
35792011-11-23 Chong Yidong <cyd@gnu.org>
3580
3581 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3582 using it (Bug#5984).
3583
b12cd789
EZ
35842011-11-22 Eli Zaretskii <eliz@gnu.org>
3585
3586 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3587 and header-lines, as they don't have one computed for them.
3588 (Bug#10098)
3589
3590 * .gdbinit (prow): Make displayed values more self-explaining.
3591 Add row's hash code.
3592
261b6fd4
LMI
35932011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3594
3595 * process.c (wait_reading_process_output): Fix asynchrounous
3596 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3597 (wait_reading_process_output): Add comment and URL.
261b6fd4 3598
e7cfd277
JD
35992011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3600
3601 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3602
a9b9b7f5
CY
36032011-11-21 Chong Yidong <cyd@gnu.org>
3604
3605 * window.c (Fnext_window, Fprevious_window): Doc fix.
3606
b0d15b4f
SM
36072011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3608
3609 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3610
fe7a3057
JB
36112011-11-20 Juanma Barranquero <lekktu@gmail.com>
3612
3613 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3614
d2999b1a
MR
36152011-11-20 Martin Rudalics <rudalics@gmx.at>
3616
3617 * window.c (Fset_window_combination_limit): Rename argument
3618 STATUS to LIMIT.
3619 (Vwindow_combination_limit): Remove "status" from doc-string.
3620
d5ff9cd0
AS
36212011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3622
3623 * m/ibms390.h: Remove.
3624 * m/ibms390x.h: Don't include "ibms390.h".
3625
a5bb9bd3
SM
36262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3627
3628 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3629 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3630
cd1181db
JB
36312011-11-20 Juanma Barranquero <lekktu@gmail.com>
3632
3633 * casetab.c (Fset_case_table):
3634 * charset.c (Fcharset_after): Fix typos.
3635
615a3b8d 36362011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3637
17e845af
PE
3638 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3639 Otherwise, valgrind does not work on some platforms.
3640 Problem reported by Andreas Schwab in
6a0bf43d
PE
3641 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3642 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3643 is set, removing the need for VIRT_ADDRESS_VARIES.
3644 (PURE_P): Use a more-efficient implementation that needs just one
3645 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3646 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3647 to 4 (xorl, subq, cmpq, setbe).
3648 * alloc.c (pure): Always extern now, since that's the
3649 VIRT_ADDR_VARIES behavior.
3650 (PURE_POINTER_P): Use a single comparison, not two, for
3651 consistency with the new puresize.h.
3652 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3653 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3654 Remove VIRT_ADDR_VARIES no longer needed.
3655
f8fe6f96
EZ
36562011-11-19 Eli Zaretskii <eliz@gnu.org>
3657
3658 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3659 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3660 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3661 behave as if the cursor position were at the window margin.
3662
3663 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3664 and the cursor position is out of bounds, behave as if the cursor
3665 position were at the window margin. (Bug#10075)
3666
df05a53c
CY
36672011-11-18 Chong Yidong <cyd@gnu.org>
3668
3669 * window.c (Fwindow_combination_limit): Make first argument
3670 non-optional, since it is meaningless for live windows like the
3671 selected window.
61ccba97 3672
2071918e
DA
36732011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3674
3675 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3676
b50a28de
SM
36772011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3678
3679 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3680 (graft_intervals_into_buffer): Simplify.
3681
015137db
EZ
36822011-11-18 Eli Zaretskii <eliz@gnu.org>
3683
3684 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3685 hash values of the two rows.
3686 (copy_row_except_pointers): Preserve the used[] arrays and the
3687 hash values of the two rows. (Bug#10035)
68c95424 3688 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3689
3690 * xdisp.c (row_hash): New function, body extracted from
3691 compute_line_metrics.
3692 (compute_line_metrics): Call row_hash, instead of computing the
3693 hash code inline.
3694
3695 * dispnew.c (verify_row_hash): Call row_hash for computing the
3696 hash code of a row, instead of duplicating code from xdisp.c.
3697
3698 * dispextern.h (row_hash): Add prototype.
3699
a2addb04
TH
37002011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3701
3702 * frame.c (delete_frame): Don't delete the terminal when the last
3703 X frame is closed if emacs is built with GTK toolkit.
3704
df85d315
JB
37052011-11-17 Juanma Barranquero <lekktu@gmail.com>
3706
3707 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3708
a0c2d0ae
MR
37092011-11-17 Martin Rudalics <rudalics@gmx.at>
3710
3711 * window.c (Vwindow_splits): Rename to
3712 Vwindow_combination_resize. Suggested by Juri Linkov.
3713 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3714 of Vwindow_splits.
3715
58179cce
JB
37162011-11-16 Juanma Barranquero <lekktu@gmail.com>
3717
7877f373
JB
3718 * nsfns.m (Fns_font_name):
3719 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3720
b6f67890
MR
37212011-11-16 Martin Rudalics <rudalics@gmx.at>
3722
3723 * window.h (window): Rename slot "nest" to "combination_limit".
3724 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3725 (Fset_window_nest): Rename to Fset_window_combination_limit.
3726 (Vwindow_nest): Rename to Vwindow_combination_limit.
3727 (recombine_windows, make_parent_window, make_window)
3728 (Fsplit_window_internal, saved_window)
3729 (Fset_window_configuration, save_window_save): Rename all
3730 occurrences of window_nest to window_combination_limit.
3731
c7015153
JB
37322011-11-15 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * image.c (imagemagick_load_image): Fix typo.
3735
322ad6ec
EZ
37362011-11-14 Eli Zaretskii <eliz@gnu.org>
3737
3738 * xdisp.c (display_line): Move the call to
3739 highlight_trailing_whitespace before the call to
3740 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3741 faces of all the glyphs to compute ROW's hash value.
3742 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3743
f067b8ec
JB
37442011-11-14 Juanma Barranquero <lekktu@gmail.com>
3745
3746 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3747 just return (bug#10044).
3748
1e5b2111
EZ
37492011-11-12 Eli Zaretskii <eliz@gnu.org>
3750
7ef3cbd5
EZ
3751 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3752 with user-defined heap size. Bump the default size of the temacs
3753 heap to 27MB, to avoid memory warning when running temacs.
3754 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3755
1e5b2111
EZ
3756 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3757 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3758 (verify_row_hash) [XASSERTS]: New function.
3759 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3760 that the hash value of glyph rows is correct.
1e5b2111 3761
89d61221
MR
37622011-11-12 Martin Rudalics <rudalics@gmx.at>
3763
3764 * window.h (window): Remove splits slot.
3765 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3766 (Fdelete_other_windows_internal, make_parent_window)
3767 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3768 (Fset_window_configuration, save_window_save): Don't deal with
3769 split status of windows.
3770 (saved_window): Remove splits slot.
3771 (Vwindow_splits): Rewrite doc-string.
3772
97f18cc8
JD
37732011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3774
3775 * xfns.c (unwind_create_frame):
3776 * nsfns.m (unwind_create_frame):
3777 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3778 Vframe_list (Bug#9999).
3779
22a648b4
DA
37802011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3781
0b381c7e 3782 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3783
659afede
KH
37842011-11-11 Kenichi Handa <handa@m17n.org>
3785
3786 * callproc.c (Fcall_process): Set the member dst_multibyte of
3787 process_coding.
3788
9ac0394b
KH
37892011-11-11 Johan Bockgård <bojohan@gnu.org>
3790
3791 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3792 avoid a crash (bug#9496).
3793
2fbdc249
CY
37942011-11-09 Chong Yidong <cyd@gnu.org>
3795
3796 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3797 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3798
ac6b1f81
PE
37992011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3800
3801 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3802
09db192c
PE
38032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3804
3805 Avoid some portability problems by eschewing 'extern inline' functions.
3806 The trivial performance wins aren't worth the portability hassles; see
3807 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3808 et seq.
3809 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3810 (window_box_width, window_box_left, window_box_left_offset)
3811 (window_box_right, window_box_right_offset): Undo previous change,
3812 by removing the "extern"s.
3813 * intervals.c (adjust_intervals_for_insertion)
3814 (adjust_intervals_for_deletion): Undo previous change,
3815 making these static again.
3816 (offset_intervals, temp_set_point_both, temp_set_point)
3817 (copy_intervals_to_string): No longer inline.
3818 * xdisp.c (window_text_bottom_y, window_box_width)
3819 (window_box_height, window_box_left_offset)
3820 (window_box_right_offset, window_box_left, window_box_right)
3821 (window_box): No longer inline.
3822
105216ed
CY
38232011-11-08 Chong Yidong <cyd@gnu.org>
3824
3825 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3826 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3827 Signal an error if not a live window.
105216ed
CY
3828 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3829 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3830
ae9e237f
JB
38312011-11-07 Juanma Barranquero <lekktu@gmail.com>
3832
3833 * lisp.h (syms_of_abbrev): Remove declaration.
3834 Reported by CHENG Gao <chenggao@royau.me>.
3835
c7aa8333
EZ
38362011-11-07 Eli Zaretskii <eliz@gnu.org>
3837
3838 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3839 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3840 of temacs in GUI mode.
3841
be7f5545
MR
38422011-11-07 Martin Rudalics <rudalics@gmx.at>
3843
3844 * window.h: Declare delete_all_child_windows instead of
3845 delete_all_subwindows.
3846 * window.c (Fwindow_nest, Fset_window_nest)
3847 (Fset_window_new_total, Fset_window_new_normal)
3848 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3849 (delete_all_subwindows): Rename to delete_all_child_windows.
3850 (Fdelete_other_windows_internal, Fset_window_configuration):
3851 Call delete_all_child_windows instead of delete_all_subwindows.
3852 * frame.c (delete_frame): Call delete_all_child_windows instead
3853 of delete_all_subwindows.
3854
ca78dc43
PE
38552011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3856
3857 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3858 This is also needed for porting to any host where GC_MARK_STACK is
3859 not GC_MAKE_GCPROS_NOOPS.
3860 (which_symbols): Use it.
3861
a0241d01
KH
38622011-11-07 Kenichi Handa <handa@m17n.org>
3863
3864 * coding.c (coding_set_destination): Check coding->src_pos only
3865 when coding->src_object is a buffer (bug#9910).
3866
3867 * process.c (send_process): Set the member src_multibyte of coding
3868 to 0 (bug#9911) when sending a unibyte text.
3869
3870 * callproc.c (Fcall_process): Set the member src_multibyte of
3871 process_coding to 0 (bug#9912).
3872
a64bfdfa 38732011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3874
3875 * xmenu.c (cleanup_widget_value_tree): New function.
3876 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3877 calling free_menubar_widget_value_tree directly (Bug#9830).
3878
cb41b32a
PE
38792011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 Fix some portability problems with 'inline'.
3882 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3883 (window_box_width, window_box_left, window_box_left_offset)
3884 (window_box_right, window_box_right_offset): Declare extern.
3885 Otherwise, these inline functions do not conform to C99 and
3886 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3887 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3888 * intervals.c (adjust_intervals_for_insertion)
3889 (adjust_intervals_for_deletion): Now extern, because otherwise the
3890 extern inline functions 'offset_intervals' couldn't refer to it.
3891 (static_offset_intervals): Remove.
3892 (offset_intervals): Rewrite using the old contents of
3893 static_offset_intervals. The old version didn't conform to C99
3894 because an extern inline function contained a reference to an
3895 identifier with static linkage.
3896
b7041366
AS
38972011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3898
3899 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3900 GC.
3901
88a37c4d
EZ
39022011-11-06 Eli Zaretskii <eliz@gnu.org>
3903
3904 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3905 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3906 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3907 return Qleft_to_right.
3908
49745b39
CY
39092011-11-06 Chong Yidong <cyd@gnu.org>
3910
3911 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3912 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3913 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3914 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3915 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3916 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3917 (Fwindow_vscroll): Doc fix.
3918 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3919 argument, since it makes no sense to pass a live window and for
3920 consistency with window-child.
3921
1f05cd82
CS
39222011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3923
3924 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3925 support MSVC.
3926
22610910
JR
39272011-11-05 Jason Rumney <jasonr@gnu.org>
3928
3929 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3930 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3931 fonts (Bug#6029).
3932 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3933 bitwise arithmetic preventing use of unicode-sip and non-truetype
3934 opentype fonts.
3935
a06776b2
EZ
39362011-11-05 Eli Zaretskii <eliz@gnu.org>
3937
3ad924ba
EZ
3938 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3939 "emacs"-only part.
3940
a06776b2
EZ
3941 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3942 initialization code to keep similarity to xfns.c after changes
3943 from 2011-11-05.
3944
c9e7db78
JD
39452011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3946
a97f8f3f
JD
3947 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3948 (unwind_create_frame): New function (Bug#9943).
3949 (Fx_create_frame): Restructure code to be more similar to the one in
3950 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3951 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3952 Move terminal->reference_count++ just before making the frame official
3953 (Bug#9943).
3954
3955 * nsterm.m (x_free_frame_resources): New function.
3956 (x_destroy_window): Move code to x_free_frame_resources.
3957
c9e7db78 3958 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3959 (Fx_create_frame, x_create_tip_frame):
3960 Move terminal->reference_count++ just before making the frame
75f1671a 3961 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3962 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3963
a6fc3b5c
EZ
39642011-11-05 Eli Zaretskii <eliz@gnu.org>
3965
3966 Support MSVC build with newer versions of Visual Studio.
3967 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3968 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3969 nt/gmake.defs.
3970
3971 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3972 which are not supported by MSVC.
3973 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3974 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3975 bitfields.
3976 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3977 types in bitfields.
3978 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3979
3980 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3981
58179cce 39822011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3983
3984 Support MSVC build with newer versions of Visual Studio.
3985 * w32.c: Don't include w32api.h for MSVC.
3986 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3987
3988 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3989 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3990 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3991 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3992 e_* cousins.
3993 (alloca) [_MSC_VER]: Define to _alloca.
3994
3995 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3996
3997 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3998
a58c13ed
EZ
39992011-11-04 Eli Zaretskii <eliz@gnu.org>
4000
4001 * xdisp.c (note_mouse_highlight): If either of
4002 previous/next-single-property-change returns nil, treat that as
4003 the beginning or the end of the buffer. (Bug#9955)
4004
fe0b6370
JD
40052011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4006
a58c13ed 4007 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4008 label is not null (Bug#9951).
4009 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4010 may be NULL.
4011
89bd5ee1
EZ
40122011-11-04 Eli Zaretskii <eliz@gnu.org>
4013
4014 * window.c (Fwindow_body_size): Mention in the doc string that the
4015 return value is in frame's canonical units. (Bug#9949)
4016
84c3edb9
EZ
40172011-11-03 Eli Zaretskii <eliz@gnu.org>
4018
4e2fb5c7
EZ
4019 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4020
84c3edb9 4021 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4022 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4023 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4024
bc17a887
EZ
40252011-11-01 Eli Zaretskii <eliz@gnu.org>
4026
4027 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4028 Don't stop backward scan on the continuation glyph, even though
4029 its CHARPOS is positive.
6d5eb5b0
SM
4030 (mouse_face_from_buffer_pos, note_mouse_highlight):
4031 Rename cover_string to disp_string.
bc17a887 4032
4ee88440
MR
40332011-11-01 Martin Rudalics <rudalics@gmx.at>
4034
4035 * window.c (temp_output_buffer_show): Don't use
4036 Vtemp_buffer_show_specifiers.
4037 (Vtemp_buffer_show_specifiers): Remove unused variable.
4038
c2ff3c02
EZ
40392011-10-30 Eli Zaretskii <eliz@gnu.org>
4040
4041 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4042 past the beginning of the current glyph matrix.
4043
58179cce 40442011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4045
4046 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4047 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4048 HAVE_GTK3 (Bug#9869).
b77a6a7f 4049
3b574623
JD
4050 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4051 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4052
b77a6a7f
JD
4053 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4054
4055 * xterm.c: Declare x_handle_net_wm_state to return int.
4056 (handle_one_xevent): Check if we are iconified but don't have
4057 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4058 (get_current_wm_state): Return non-zero if not hidden,
4059 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4060 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4061 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4062 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4063
196e41e4
PE
40642011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4065
4066 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4067 so that this new function doesn't get optimized away by a
4068 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4069
021f2e1a
AS
40702011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4071
4072 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4073
8b058d44
EZ
40742011-10-29 Eli Zaretskii <eliz@gnu.org>
4075
4076 Fix the `xbytecode' command.
4077 * .gdbinit (xprintbytestr): New command.
b50a28de 4078 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4079 (xbytecode): Print the byte-code string as well.
4080
4452fb80
EZ
40812011-10-29 Kim Storm <storm@cua.dk>
4082
8b058d44
EZ
4083 * alloc.c (which_symbols): New function.
4084
21b72067
AS
40852011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4086
4087 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4088 line. (Bug#9903)
4089
83ed7b5c
GM
40902011-10-29 Glenn Morris <rgm@gnu.org>
4091
4092 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4093 Not clear what it was for, and it causes various bugs. (Bug#9839)
4094
5a7a728b
EZ
40952011-10-28 Eli Zaretskii <eliz@gnu.org>
4096
4097 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4098 possible random value that matches one of those tested as
4099 condition to clear the mouse face.
4100
d3d0842f
CY
41012011-10-28 Chong Yidong <cyd@gnu.org>
4102
4103 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4104
31b39d13
DN
41052011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4106
4107 * window.c (make_window): Initialize phys_cursor_on_p.
4108
9aba6043
SM
41092011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * lisp.h (struct Lisp_Symbol): Update comments.
4112
c20992f4
JB
41132011-10-28 Juanma Barranquero <lekktu@gmail.com>
4114
4115 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4116
db4f02f2
EZ
41172011-10-28 Eli Zaretskii <eliz@gnu.org>
4118
4119 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4120 <oslsachem@gmail.com> for helping to debug this.
4121
4122 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4123 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4124 (g_b_init_get_glyph_outline_w): New static variables.
4125 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4126 (GetGlyphOutlineW_Proc): New typedefs.
4127 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4128 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4129 New functions.
4130 (w32font_open_internal, compute_metrics):
4131 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4132 instead of calling the "wide" APIs directly.
4133
4134 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4135
4136 * w32.h (syms_of_w32font): Add prototype.
4137
87e68db4
JB
41382011-10-27 Juanma Barranquero <lekktu@gmail.com>
4139
4140 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4141 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4142 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4143 (Fmove_to_window_line): Doc fix.
4144
435c1d67
CY
41452011-10-27 Chong Yidong <cyd@gnu.org>
4146
4147 * process.c (make_process): Set gnutls_state to NULL.
4148
4149 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4150 non-NULL, regardless of GNUTLS_INITSTAGE.
4151 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4152 an error. Set process slots as soon as we allocate them.
4153
4154 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4155
9c6c6f49
CY
41562011-10-27 Chong Yidong <cyd@gnu.org>
4157
9aba6043
SM
4158 * gnutls.c (emacs_gnutls_deinit): New function.
4159 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4160 (Fgnutls_deinit, Fgnutls_boot): Use it.
4161
4162 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4163 (deactivate_process): Call emacs_gnutls_deinit.
4164
657d08d3
JB
41652011-10-27 Juanma Barranquero <lekktu@gmail.com>
4166
4167 * image.c (x_create_x_image_and_pixmap):
4168 * w32.c (sys_rename, w32_delayed_load):
4169 * w32font.c (fill_in_logfont):
4170 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4171
5430d399
JB
41722011-10-26 Juanma Barranquero <lekktu@gmail.com>
4173
4174 * w32fns.c (w32_default_color_map): New function,
4175 extracted from Fw32_default_color_map.
a7ef684b 4176 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4177
fe0055fa
PE
41782011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4179
4180 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4181
e6346438
SM
41822011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4183
4184 * keyboard.c (test_undefined): New function (bug#9751).
4185 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4186
e112cc37
ET
41872011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4188
4189 * sysdep.c (init_sys_modes): Fix the check for the controlling
4190 terminal (Bug#6649).
4191
7b5d6677
EZ
41922011-10-20 Eli Zaretskii <eliz@gnu.org>
4193
4194 * dispextern.h (struct bidi_it): New member next_en_type.
4195
4196 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4197 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4198 current character, check also for next_en_type being WEAK_EN.
4199 (bidi_resolve_weak): Don't enter the expensive loop if the current
4200 position is before next_en_pos. Record the bidi type of the first
4201 non-ET, non-BN character we find, in addition to its position.
4202 (bidi_level_of_next_char): Invalidate next_en_type when
4203 next_en_pos is over-stepped.
4204
7da0b018
PE
42052011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4206
4207 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4208 * editfns.c: Rewrite current-time-zone so that it invokes
4209 the equivalent of (format-time-string "%Z") to get the time zone name.
4210 This fixes a bug when the time zone name contains characters that
4211 need converting from the system time locale to Emacs internal format.
4212 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4213 that patch fixed format-time-string to do the conversion, but
4214 I forgot to fix current-time-zone.
4215 (format_time_string): New function, containing most of
4216 what Fformat_time_string used to contain.
4217 (Fformat_time_string): Rewrite in terms of format_time_string.
4218 This doesn't change this function's behavior.
4219 (current-time-zone): Rewrite to use format_time_string.
4220 This fixes the bug reported by Michael Schierl in
4221 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4222 Jason Rumney's 2007-06-07 change worked around this bug, but
4223 didn't fix it.
4224 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4225
8547b010
EZ
42262011-10-19 Eli Zaretskii <eliz@gnu.org>
4227
4228 * xdisp.c (start_display): If the character at POS is displayed
4229 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4230 (try_window_reusing_current_matrix): If a line ends in a display
4231 vector or the next line starts in a display vector, continue
4232 redrawing the window even though the character position of
4233 start_row was reached.
8547b010
EZ
4234 (Bug#9771, part 2)
4235
4e948d15
CY
42362011-10-18 Chong Yidong <cyd@gnu.org>
4237
4238 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4239 with nobreak-char-display too.
4240
4787455f
EZ
42412011-10-18 Eli Zaretskii <eliz@gnu.org>
4242
4243 Fix part 3 of bug#9771.
4244 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4245 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4246 non-neutral characters if the current character is a paragraph
4247 separator (a.k.a. Newline). This avoids running the same
4248 expensive loop twice, once when we consume the preceding newline
4249 and the other time when the line actually needs to be displayed.
4250 Avoid the loop when we see neutrals on the base embedding level
4251 following a character whose directionality is the same as the
4252 paragraph's. This avoids running the expensive loop when a line
4253 ends in a long sequence of neutrals, like control characters.
4254 Add assertion against STRONG_AL type. Slightly rearrange code
4255 that determines the type of a neutral given the first non-neutral
4256 that follows it.
4257 (bidi_level_of_next_char): Set next_en_pos to zero when
4258 invalidating its info.
4259
2c91f553
EZ
42602011-10-17 Eli Zaretskii <eliz@gnu.org>
4261
4262 * xdisp.c (push_display_prop): Determine whether to record string
4263 or buffer position by IT->string, not by IT->method. Allow
4264 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4265 (move_it_vertically_backward): Don't look for character position
4266 immediately after the newline when in a continuation line.
4267 (Bug#9771, part 1)
2c91f553 4268
c7b08b0d
MR
42692011-10-15 Martin Rudalics <rudalics@gmx.at>
4270
4271 * window.c (coordinates_in_window): Rewrite and delabelize
4272 vertical border check. (Bug#5357) (Bug#9618)
4273
6b02f655
SM
42742011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4275
4276 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4277 errors in XSetWindowBorder (bug#9310).
4278
81d40c92
DA
42792011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4280
4281 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4282 avoid crash when xmalloc overrun checking is enabled.
4283
d4172c3b
EZ
42842011-10-13 Eli Zaretskii <eliz@gnu.org>
4285
4286 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4287 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4288 cursor motion with <left> and <right> arrow keys.
4289
4290 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4291 some callers set that themselves.
4292
b00eea75
EZ
42932011-10-12 Eli Zaretskii <eliz@gnu.org>
4294
4295 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4296 display string and the previous row comes from the same string and
4297 is empty. (Bug#9739) (Bug#9738)
4298
8fe012c4
SM
42992011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4300
4301 * doc.c (get_doc_string): Encode file name (bug#9735).
4302
0074aef2
EZ
43032011-10-12 Eli Zaretskii <eliz@gnu.org>
4304
79beb178
EZ
4305 * bidi.c (bidi_level_of_next_char):
4306 * xdisp.c (get_visually_first_element): Remove old incorrect
4307 comments regarding the Unicode Line Separator character.
4308
0074aef2
EZ
4309 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4310
6e4b3fbe
DA
43112011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4312
4313 * alloc.c (Fgc_status): Do not access beyond zombies array
4314 boundary if nzombies > MAX_ZOMBIES.
4315 * alloc.c (dump_zombies): Add missing format specifier.
4316
0324f3af
PE
43172011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4318
b5525cac
PE
4319 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4320 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4321
0324f3af
PE
4322 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4323 Some packages use them to denote characters with modifiers.
4324
e9b5f888
AS
43252011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4326
4327 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4328 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4329 matching a pp-number. Rename parameter var to var1.
4330
127827c0
SM
43312011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4332
4333 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4334
c8fd3bd0
GM
43352011-10-08 Glenn Morris <rgm@gnu.org>
4336
4337 * callint.c (Fcall_interactively): Give a more explicit error for the
4338 'c' case with a non-character input. (Bug#8479)
4339
352ec8ff
EZ
43402011-10-08 Eli Zaretskii <eliz@gnu.org>
4341
03669ccb
EZ
4342 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4343 lines.
7061c986
EZ
4344 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4345 lines that are hscrolled on the left.
03669ccb 4346
352ec8ff
EZ
4347 * dispnew.c (buffer_posn_from_coords): Account for a possible
4348 presence of header-line. (Bug#4426)
4349
a66cfb1c
SM
43502011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4351
6b02f655
SM
4352 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4353 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4354
7c5ee88e
PE
43552011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4356
4357 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4358 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4359 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4360 this makes Emacs dump core during garbage collection on rare
4361 occasions. sizeof is obviously inferior to offsetof here, so
4362 stick with offsetof.
4363 (GC_POINTER_ALIGNMENT): New macro.
4364 (mark_memory): Omit 3rd (offset) arg; caller changed.
4365 Don't assume EMACS_INT alignment is the same as pointer alignment.
4366
df1bbe5b
SM
43672011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4368
4369 * keyboard.c (read_key_sequence_remapped): New var.
4370 (read_key_sequence): Compute remapping in the right buffer.
4371 (command_loop_1): Use read_key_sequence's remapping directly.
4372
51553db6
SM
43732011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4374
32c1fffd
SM
4375 * dired.c (file_name_completion): Don't expand file name.
4376 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4377 before checking file name handler.
4378
51553db6
SM
4379 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4380 they've been requested explicitly (bug#9591).
4381
b6bd1599 43822011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4383
4384 * keymap.c (Fsingle_key_description): Use make_specified_string
4385 instead of build_string to build string from push_key_description.
4386 (Bug#5193)
4387
f701dc2a
PE
43882011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4389
4222c55d
PE
4390 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4391 This fixes a Y2038 bug on 64-bit hosts.
4392 * buffer.c (reset_buffer):
4393 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4394 (Fclear_buffer_auto_save_failure):
4395 Use 0, not -1, to represent an unset failure time, since time_t
4396 might not be signed.
4397
f701dc2a
PE
4398 Remove dependency on glibc malloc internals.
4399 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4400 Move back here from lisp.h, but with their new implementations.
4401 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4402 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4403 * charset.c (charset_table_init): New static var.
4404 (syms_of_charset): Use it instead of xmalloc. This removes a
4405 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4406 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4407 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4408 Move back to alloc.c.
4409 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4410 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4411
9ceebf39
JD
44122011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4413
4414 * nsterm.m (windowDidResize): Call x_set_window_size only when
4415 ns_in_resize is true. Otherwise set pixelwidth/height and
4416 call change_frame_size (Bug#9628).
4417
cb993c58
PE
44182011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4419
3930c88b
PE
4420 Port --enable-checking=all to Fedora 14 x86-64.
4421 * charset.c (syms_of_charset): Also account for glibc malloc's
4422 internal overhead when calculating the initial malloc maximum.
4423
cb993c58
PE
4424 Port --enable-checking=all to Fedora 14 x86.
4425 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4426 Move to lisp.h.
4427 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4428 (overrun_check_realloc, overrun_check_free):
4429 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4430 That way, xmalloc returns a properly-aligned pointer even if
4431 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4432 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4433 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4434 into account when calculating the initial malloc maximum.
4435 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4436 Move here from alloc.c, so that charset.c can use it too.
4437 Properly align; the old code wasn't right for common 32-bit hosts
4438 when configured with --enable-checking=all.
4439 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4440 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4441
31bed486
EZ
44422011-09-29 Eli Zaretskii <eliz@gnu.org>
4443
04c70788 4444 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4445 use EDOM.
4446
fbcaa2f3
EZ
44472011-09-28 Eli Zaretskii <eliz@gnu.org>
4448
4449 * xdisp.c (compute_display_string_end): If there's no display
4450 string at CHARPOS, return -1.
4451
4452 * bidi.c (bidi_fetch_char): When compute_display_string_end
4453 returns a negative value, treat the character as a normal
4454 character not covered by a display string. (Bug#9624)
4455
a239d4e9
JB
44562011-09-28 Juanma Barranquero <lekktu@gmail.com>
4457
4458 * lread.c (Fread_from_string): Fix typo in docstring.
4459
88652fd5
EZ
44602011-09-27 Eli Zaretskii <eliz@gnu.org>
4461
4462 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4463 newline, reseat the iterator instead of bidi-iterating there one
4464 character at a time. (Bug#9610)
32c1fffd
SM
4465 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4466 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4467
ed497dd4
AS
44682011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4469
4470 * lread.c (readevalloop): Use correct code for NBSP.
4471 (read1): Likewise. (Bug#9608)
4472
b2bf61aa
MA
44732011-09-25 Michael Albinus <michael.albinus@gmx.de>
4474
4475 * dbusbind.c (Fdbus_register_signal): When service is not
4476 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4477
32bbb17c
GM
44782011-09-25 Glenn Morris <rgm@gnu.org>
4479
4480 * buffer.c (truncate-lines): Doc fix.
4481
94e0933e
CY
44822011-09-24 Chong Yidong <cyd@stupidchicken.com>
4483
4484 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4485 (Fset_window_next_buffers): Doc fix.
4486
cddde921
GM
44872011-09-24 Glenn Morris <rgm@gnu.org>
4488
4489 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4490
1260aef1
PE
44912011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4492
25b4bfa0
PE
4493 Fix minor problems found by static checking.
4494 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4495 * indent.c (Fvertical_motion): Fix == vs = typo.
4496
e3cbd34b
EZ
44972011-09-24 Eli Zaretskii <eliz@gnu.org>
4498
a66cfb1c
SM
4499 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4500 Default value is now t. Doc fix.
6bf7006f 4501
e3cbd34b 4502 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4503 logic when moving up, not only when moving down. Fix the
e3cbd34b 4504 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4505 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4506
4507 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4508 CHARPOS is covered by a display string which includes newlines.
4509 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4510 is covered by a display string with embedded newlines.
4511
a3de0cbd
MA
45122011-09-24 Michael Albinus <michael.albinus@gmx.de>
4513
4514 * dbusbind.c (Fdbus_register_signal): Add match rule to
4515 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4516 (Fdbus_register_method, Vdbus_registered_objects_table):
4517 Fix docstring.
a3de0cbd 4518
b260039d
JM
45192011-09-24 Jim Meyering <meyering@redhat.com>
4520
32c1fffd 4521 do not ignore write error for any output size
b260039d
JM
4522 The previous change was incomplete.
4523 While it makes emacs --batch detect the vast majority of stdout
4524 write failures, errors were still ignored whenever the output size is
4525 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4526 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4527 && echo FAIL: ignored write error
4528 FAIL: ignored write error
4529 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4530 && echo FAIL: ignored write error
4531 FAIL: ignored write error
4532 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4533
8eca8a7c
AS
45342011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4535
4536 * emacs.c (Fkill_emacs): In noninteractive mode exit
4537 non-successfully if a write error occurred on stdout. (Bug#9574)
4538
3341db62
EZ
45392011-09-21 Eli Zaretskii <eliz@gnu.org>
4540
4541 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4542 the xassert test.
4543
4544 * dispextern.h (struct it): Update the comment documenting what
4545 can it->OBJECT be.
4546
8c203dbf
EZ
45472011-09-20 Eli Zaretskii <eliz@gnu.org>
4548
4549 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4550 a display string, extend search for cursor position to end of row.
4551 (find_row_edges): If the row ends in a newline from a display
4552 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4553 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4554 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4555 non-empty line. Fixes confusing cursor motion with arrow keys at
4556 the beginning of a line that starts with whitespace.
8c203dbf 4557
a4824228
LMI
45582011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4559
4560 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4561 (bug#9493).
4562
33ed493b
CY
45632011-09-18 Chong Yidong <cyd@stupidchicken.com>
4564
4565 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4566 boolean (Bug#9154).
4567
56cd55c8
EZ
45682011-09-18 Eli Zaretskii <eliz@gnu.org>
4569
4570 * xdisp.c (display_line): Record maximum and minimum buffer
4571 positions even if no glyphs were produced (e.g., by a zero-width
4572 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4573 buffer positions that will be removed from the glyph row because
4574 they don't fit.
c02dcedf
EZ
4575 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4576 column is beyond frame width: don't subtract 1 "pixel" when
4577 computing width of the stretch.
3e62b7e0
EZ
4578 (reseat_at_next_visible_line_start): Undo the change made on
4579 2011-09-17 that saved paragraph information and restored it after
4580 the call to `reseat'. (Bug#9545)
56cd55c8 4581
5ed99d36 45822011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4583
4584 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4585 and turn window cursor on if cleared (Bug#9415).
4586
5ed99d36 45872011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4588
4589 * search.c (boyer_moore): Take unibyte characters from pattern
4590 literally. (Bug#9458)
4591
9bade7b2
EZ
45922011-09-18 Eli Zaretskii <eliz@gnu.org>
4593
4594 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4595
e5e9d610
PE
45962011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4597
87e4427a
PE
4598 Fix minor problem found by static checking.
4599 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4600 initialized, to pacify gcc -Wuninitialized.
4601
e5e9d610
PE
4602 * fileio.c: Report proper errno when syscall falls.
4603 (Finsert_file_contents): Save and restore errno,
4604 so that report_file_error outputs the correct diagnostic.
4605 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4606
a1674f0b
EZ
46072011-09-18 Eli Zaretskii <eliz@gnu.org>
4608
4609 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4610
fbfb6dd4
EZ
46112011-09-17 Eli Zaretskii <eliz@gnu.org>
4612
4613 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4614 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4615
bb187662
EZ
46162011-09-17 Eli Zaretskii <eliz@gnu.org>
4617
1137e8b8 4618 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4619 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4620
4621 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4622 (bidi_find_paragraph_start): Search back for paragraph beginning
4623 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4624 (bidi_move_to_visually_next): Only trigger paragraph-related
4625 computations when the last character is a newline or at EOB, not
4626 just any NEUTRAL_B. (Bug#9470)
4627
bb187662
EZ
4628 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4629 truncated lines if point is covered by a display string. (Bug#9524)
4630
2e621251
PE
46312011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4632
4633 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4634 (cons_to_x_long): New function.
4635 (lisp_data_to_selection_data): Use it. Correct the test for
4636 short-versus-long data; it was negated. Break out of vector
4637 loop, for efficiency, when a long datum is discovered.
4638
91a15bc6
SM
46392011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4640
4641 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4642
b41c3a35
EZ
46432011-09-16 Eli Zaretskii <eliz@gnu.org>
4644
4645 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4646 GCC PR/17406) by declaring this function with external scope.
4647
7812ba2d
PE
46482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4649
4650 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4651 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4652
cf7edc2a
AS
46532011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4654
4655 * editfns.c (Fformat): Correctly handle text properties on "%%".
4656
bd01620e
EZ
46572011-09-15 Eli Zaretskii <eliz@gnu.org>
4658
4659 * xterm.c (x_draw_composite_glyph_string_foreground):
4660 * w32term.c (x_draw_composite_glyph_string_foreground):
4661 * term.c (encode_terminal_code):
4662 * composite.c (composition_update_it, get_composition_id):
4663 * xdisp.c (get_next_display_element)
4664 (fill_composite_glyph_string): Add comments about special meaning
4665 of TAB characters in a composition.
4666
a02719a3
PE
46672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4668
4669 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4670 This occurs when processing a multibyte format.
4671 Problem reported by Wolfgang Jenker.
a02719a3 4672
72589a3c
JB
46732011-09-15 Johan Bockgård <bojohan@gnu.org>
4674
4675 * xdisp.c (try_cursor_movement): Only check for exact match if
4676 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4677
1c14176c
PE
46782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4679
4680 Remove unused external symbols.
4681 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4682 * xdisp.c (calc_pixel_width_or_height): Now static.
4683 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4684 * indent.c (check_display_width):
4685 * w32term.c: Fix comment to match code.
4686 * xterm.c, xterm.h (x_catching_errors): Remove.
4687
d2eea5b5
PE
46882011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4689
4690 * xselect.c: Use signed conversions more consistently (Bug#9498).
4691 (selection_data_to_lisp_data): Assume incoming selection data are
4692 signed integers, not unsigned. This is to be consistent with
4693 outgoing selection data, which was modified to use signed integers
4694 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4695 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4696 expects long, not unsigned long.
4697
46888499
EZ
46982011-09-14 Eli Zaretskii <eliz@gnu.org>
4699
4700 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4701 computation of loop end. Reported by Johan Bockgård
4702 <bojohan@gnu.org>.
4703
ef8ef9fb
CY
47042011-09-13 Chong Yidong <cyd@stupidchicken.com>
4705
4706 * frame.c (Fother_visible_frames_p): Function deleted.
4707
fa819fed
EZ
47082011-09-12 Eli Zaretskii <eliz@gnu.org>
4709
4710 * indent.c (compute_motion): Process display vector front to back
4711 rather than the other way around. (Bug#2496)
4712
2ba8e008
SM
47132011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4714
4715 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4716
20f53c69
CY
47172011-09-11 Chong Yidong <cyd@stupidchicken.com>
4718
4719 * minibuf.c (Fread_from_minibuffer): Doc fix.
4720
d562d7a4
EZ
47212011-09-11 Eli Zaretskii <eliz@gnu.org>
4722
4723 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4724 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4725
1c4d7f3d
LMI
47262011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4727
4728 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4729 value for non-existent files.
4730
b885bf36
EZ
47312011-09-11 Eli Zaretskii <eliz@gnu.org>
4732
4733 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4734 set its "size" to -1. This will set the modtime_size field of
4735 the corresponding buffer to -1, which is what
4736 verify-visited-file-modtime expects for files that do not exist.
4737 (Bug#9139)
4738
6612f0bf
PE
47392011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4740
4741 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4742 here ...
4743 * lisp.h: ... from here. push_key_description is no longer
4744 defined in keyboard.c, so its declaration should not be in
4745 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4746 logically belongs with push_key_description.
4747
dfb3f755
PE
47482011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4749
4750 * buffer.h: Include <sys/types.h> instead of <time.h>.
4751 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4752 Problem reported by Herbert J. Skuhra.
4753
3134906c
LMI
47542011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4755
4756 * xml.c (parse_region): Make the parsing work for
4757 non-comment-starting XML files again (bug#9144).
4758
8d903f4e
AS
47592011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4760
4761 * image.c (gif_load): Fix calculation of bottom and right corner.
4762 (Bug#9468)
4763
80ad64f4
EZ
47642011-09-10 Eli Zaretskii <eliz@gnu.org>
4765
4766 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4767 redisplay in small windows.
4768
208a048d
EZ
47692011-09-09 Eli Zaretskii <eliz@gnu.org>
4770
4771 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4772
9b1c252e
MR
47732011-09-08 Martin Rudalics <rudalics@gmx.at>
4774
4775 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4776 Operate on live windows only.
4777
2949f33b
JB
47782011-09-08 Juanma Barranquero <lekktu@gmail.com>
4779
4780 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4781
e08dcafd
EZ
47822011-09-07 Eli Zaretskii <eliz@gnu.org>
4783
4784 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4785 only under bidi iteration.
4786
115b96bd
JD
47872011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4788
4789 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4790
c8199d0f
PE
47912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4794 Without this fix, the command to link temacs failed due to an
4795 undefined symbol __builtin_isnan. This is because
4796 /usr/include/iso/math_c99.h #defines isnan(x) to
4797 __builtin_isnan(x), but the bundled gcc, which identifies itself
4798 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4799 a __builtin_isnan.
4800 * floatfns.c (isnan): #undef, and then #define to a clone of
4801 what's in data.c.
4802 (Fisnan): Always define, since it's always available now.
4803 (syms_of_floatfns): Always define isnan at the Lisp level.
4804
e39b275c 48052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4806
4807 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4808
b2db44d9 48092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4810
f4af5137 4811 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4812 The previous code assumed that file offsets (off_t values) fit in
4813 EMACS_INT variables, which is not true on typical 32-bit hosts.
4814 The code messed up by falsely reporting buffer overflow in cases
4815 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4816 when "big" contains more than 2**29 bytes, even though this
4817 inserts just one byte and does not overflow the buffer.
4818 (Finsert_file_contents): Store file offsets as off_t
4819 values, not as EMACS_INT values. Check for overflow when
4820 converting between EMACS_INT and off_t. When checking for
4821 buffer overflow or for overlap, take the offsets into account.
4822 Don't use EMACS_INT for small values where int suffices.
4823 When checking for overlap, fix a typo: ZV was used where
4824 ZV_BYTE was intended.
4825 (Fwrite_region): Don't assume off_t fits into 'long'.
4826 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4827
ecfc0a49
MA
48282011-09-05 Michael Albinus <michael.albinus@gmx.de>
4829
4830 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4831
6511acf2 48322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4833
0999621a 4834 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4835
4836 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4837 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4838 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4839 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4840 (modify_event_symbol): Do not assume that the length of
4841 name_alist_or_stem is safe to alloca and fits in int.
4842 (Fexecute_extended_command): Likewise for function name and binding.
4843 (Frecursion_depth): Wrap around reliably on integer overflow.
4844 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4845 since some callers pass EMACS_INT values.
4846 (Fsingle_key_description): Don't crash if symbol name contains more
4847 than MAX_ALLOCA bytes.
4848 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4849 (get_minibuffer): Arg is now EMACS_INT, not int.
4850 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4851 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4852 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4853
2be7d702
PE
4854 * dbusbind.c (signature_cat): New function.
4855 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4856 Do not overrun buffer; instead, report string overflow.
4857
9d1df220
PE
4858 * dispnew.c (add_window_display_history): Don't overrun buffer.
4859 Truncate instead; this is OK since it's just a log.
4860
33ef5c64
PE
4861 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4862 even if the time zone offset is outlandishly large.
4863 Don't mishandle offset == INT_MIN.
4864
66c6fdd5
PE
4865 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4866 when creating daemon; the previous buffer-overflow check was incorrect.
4867
d749b01b
PE
4868 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4869 which has the guts of the old verror function.
4870
b5cd1905
PE
4871 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4872 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4873
6e1a67fb
PE
4874 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4875 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4876 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4877 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4878 length of string rather than counting it via multiple sprintfs;
4879 that's simpler and more reliable.
c21721cc
PE
4880 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4881 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4882 sprintf, in case result does not fit in int.
4883
c57b67fc
PE
4884 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4885 (fontset_from_font): Print it.
4886
8a401434
PE
4887 * frame.c (tty_frame_count): Now printmax_t, not int.
4888 (make_terminal_frame, set_term_frame_name): Print it.
4889 (x_report_frame_params): In X, window IDs are unsigned long,
4890 not signed long, so print them as unsigned.
4891 (validate_x_resource_name): Check for implausibly long names,
4892 and don't assume name length fits in 'int'.
4893 (x_get_resource_string): Don't blindly alloca invocation name;
4894 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4895 not fit in int.
4896
6e1a67fb
PE
4897 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4898 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4899 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4900
0df02bf3
PE
4901 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4902 Use esprintf, not sprintf, in case result does not fit in int.
4903
48e30793
PE
4904 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4905 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4906 it as a large positive number.
4907 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4908 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4909
a66ff6d8
PE
4910 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4911 in case result does not fit in int.
4912
aca216ff
PE
4913 * print.c (float_to_string): Detect width overflow more reliably.
4914 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4915 buffer overrun. Don't assume list length fits in 'int'. Treat
4916 print length of 0 as 0, not as infinity; to be consistent with other
4917 uses of print length in this function. Don't overflow print length
4918 index. Don't assume hash table size fits in 'long', or that
4919 vectorlike size fits in 'unsigned long'.
4920
31c286f7
PE
4921 * process.c (make_process): Use printmax_t, not int, to format
4922 process-name gensyms.
4923
55e5faa1
PE
4924 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4925
80f2e268
PE
4926 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4927 to avoid potential buffer overrun.
4928
670741ab
PE
4929 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4930 if X resource line is longer than 512 bytes.
4931
b7163a50
PE
4932 * xfns.c (x_window): Make sprintf buffer a bit bigger
4933 to avoid potential buffer overrun.
4934
ae58ff1f
PE
4935 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4936
c43c8a6a
PE
4937 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4938
3f8236f4
PE
49392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4940
53e9fe90 4941 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4942 Without these, Emacs silently mishandles large integers sometimes.
4943 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4944 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4945
6511acf2
PE
4946 * xdisp.c (try_window_id): Check Emacs fixnum range before
4947 converting to 'int'.
806add1d 4948
6511acf2 4949 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4950 Check that an Emacs fixnum is in range before assigning it to 'int'.
4951 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4952 values converted from Emacs fixnums.
4953 (Frecenter): Don't wrap around a line count if it is out of 'int'
4954 range; instead, treat it as an extreme value.
4955 (Fset_window_configuration, compare_window_configurations):
4956 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4957
6511acf2
PE
4958 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4959 that can exceed INT_MAX. Check that EMACS_INT value is in range
4960 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4961 (match_limit): Don't assume that a fixnum can fit in 'int'.
4962
6511acf2 4963 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4964 exceed INT_MAX.
4965
6511acf2 4966 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4967 (Fvertical_motion): Don't wrap around LINES values that don't fit
4968 in 'int'. Instead, treat them as extreme values. This is good
4969 enough for windows, which can't have more than INT_MAX lines anyway.
4970
fcb901a7
LMI
49712011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4972
0f2f6b6d
LMI
4973 * Require libxml/parser.h to avoid compilation warning.
4974
fcb901a7
LMI
4975 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4976
4977 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4978 since this reportedly can destroy thread storage.
4979
6e20a0d4
CY
49802011-08-30 Chong Yidong <cyd@stupidchicken.com>
4981
4982 * syntax.c (find_defun_start): Update all cache variables if
4983 exiting early (Bug#9401).
4984
148ae00e
EZ
49852011-08-30 Eli Zaretskii <eliz@gnu.org>
4986
f6cfbd8f
EZ
4987 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4988
148ae00e
EZ
4989 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4990 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4991 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4992
4993 * term.c (tty_append_glyph): New function.
4994 (produce_stretch_glyph): Static function and its prototype deleted.
4995
a66cfb1c
SM
4996 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4997 Add prototypes.
148ae00e 4998
c4a07a4c
PE
49992011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5000
5001 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5002 when checking :margin (Bug#9390).
5003 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5004 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5005 so that the name doesn't mislead. All uses changed.
5006
6bc8cd65
JB
50072011-08-28 Johan Bockgård <bojohan@gnu.org>
5008
5009 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5010 set_tty_hooks.
5011
dca4927e
EZ
50122011-08-27 Eli Zaretskii <eliz@gnu.org>
5013
5014 * xdisp.c (move_it_to): Don't bail out early when reaching
5015 position beyond to_charpos, if we are scanning backwards.
5016 (move_it_vertically_backward): When DY == 0, make sure we get to
5017 the first character in the line after the newline.
5018
f2cad773
PE
50192011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5020
5021 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5022 (ccl_driver): Do not generate an out-of-range pointer.
5023 (Fccl_execute_on_string): Remove unnecessary check for
5024 integer overflow, noted by Stefan Monnier in
5025 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5026 Remove a FIXME that didn't need fixing.
5027 Simplify the newly-introduced buffer reallocation code.
5028
0cae2cdb
JB
50292011-08-27 Juanma Barranquero <lekktu@gmail.com>
5030
5031 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5032
5fc295a4 50332011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5034
70c60eb2 5035 Integer and memory overflow issues (Bug#9196).
726e0ab1 5036
d31850da
PE
5037 * doc.c (get_doc_string): Rework so that
5038 get_doc_string_buffer_size is the actual buffer size, rather than
5039 being 1 less than the actual buffer size; this makes xpalloc more
5040 convenient.
5041
a69fbedb
PE
5042 * image.c (x_allocate_bitmap_record, cache_image):
5043 * xselect.c (Fx_register_dnd_atom):
5044 Simplify previous changes by using xpalloc.
5045
fe5c5d37
PE
5046 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5047 since either will do and ptrdiff_t is convenient with xpalloc.
5048
0065d054
PE
5049 * charset.c (charset_table_size)
5050 (struct charset_sort_data.priority): Now ptrdiff_t.
5051 (charset_compare): Don't overflow if priorities differ greatly.
5052 (Fsort_charsets): Don't assume list length fits in int.
5053 Check for size-calculation overflow when allocating sort data.
5054 (syms_of_charset): Allocate an initial charset table that is
5055 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5056
5057 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5058
5059 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5060 The actual value is always <= INT_MAX, and leaving it unsigned made
5061 overflow checking harder.
5062
5063 * dispextern.h (struct glyph_matrix.rows_allocated)
5064 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5065 with xpalloc. The values are still always <= INT_MAX.
5066
5067 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5068
5069 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5070 (SAFE_NALLOCA): New macro.
5071
5072 * region-cache.c (struct boundary.pos, find_cache_boundary)
5073 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5074 (set_cache_region, invalidate_region_cache)
5075 (revalidate_region_cache, know_region_cache, region_cache_forward)
5076 (region_cache_backward, pp_cache):
5077 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5078 so that ptrdiff_t * can be passed to xpalloc.
5079 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5080 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5081 (pp_cache): Don't assume cache_len fits in int.
5082 * region-cache.h: Adjust extern decls to match.
5083
5084 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5085 EMACS_INT, since either will do, for xpalloc.
5086
5087 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5088 (xnmalloc, xnrealloc, xpalloc): New functions.
5089
726e0ab1
PE
5090 * bidi.c (bidi_shelve_header_size): New constant.
5091 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5092 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5093
51f30bc5 5094 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5095 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5096 (overlay_strings):
5097 Don't update size of array until after memory allocation succeeds,
5098 because xmalloc/xrealloc may not return.
0065d054
PE
5099 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5100 now that we have proper integer overflow checking.
5101 (record_overlay_string, overlay_strings): Catch overflows when
5102 calculating size of overlay_str_buf.
726e0ab1 5103
0065d054
PE
5104 * callproc.c (Fcall_process): Check for size overflow when
5105 calculating size of args2.
5106 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5107 Normally we prefer signed values, but sticking with ptrdiff_t would
5108 require adding more-complicated checks.
726e0ab1
PE
5109
5110 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5111 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5112 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5113 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5114
5115 * character.c (Fstring): Check for size-calculation overflow.
5116
5117 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5118 unnecessary integer overflow. Check for size overflow.
5119 (encode_coding_object): Don't update size until xmalloc succeeds.
5120
5121 * composite.c (get_composition_id): Check for overflow in glyph
5122 length calculations.
5123
5124 Integer and memory overflow fixes for display code.
5125 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5126 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5127 (scrolling_window): Check for overflow in size calculations.
5128 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5129 Don't assume glyph table len fits in int.
5130 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5131 (row_table_size): Now ptrdiff_t, not int.
5132 (scrolling_window): Avoid overflow in size calculations.
5133 Don't update size until allocation succeeds.
5134 * fns.c (concat): Check for overflow in size calculations.
5135 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5136 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5137 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5138
5139 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5140 (get_doc_string): Check for size calculation overflow.
5141 Don't update size until allocation succeeds.
5142 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5143 EMACS_INT, where ptrdiff_t will do.
5144 (Fsubstitute_command_keys): Check for string overflow.
5145
5146 * editfns.c (set_time_zone_rule): Don't assume environment length
5147 fits in int.
5148 (message_length): Now ptrdiff_t, not int.
5149 (Fmessage_box): Don't update size until allocation succeeds.
5150 Don't assume message length fits in int.
5151 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5152
0065d054
PE
5153 * emacs.c (main): Do not reallocate argv, since there is a null at
5154 the end that can be overwritten, and this way there's no need to
5155 worry about size-calculation overflow.
5156 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5157
5158 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5159 alloc succeeds.
5160 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5161
5162 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5163 (x_set_scroll_bar_width, x_figure_window_size):
5164 Check for integer overflow.
5165 (x_set_alpha): Do not assume XINT fits in int.
5166
5167 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5168 This is for the members text_lines, text_cols, total_lines, total_cols,
5169 where the system imposes an 'int' limit.
5170
5171 * fringe.c (Fdefine_fringe_bitmap):
5172 Don't update size until alloc works.
5173
5174 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5175 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5176
5177 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5178 Check for size-calculation overflow.
5179 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5180 do, as we prefer signed integers.
5181 (id_to_widget.max_size, id_to_widget.used)
5182 (xg_store_widget_in_map, xg_remove_widget_from_map)
5183 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5184 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5185 Use and return ptrdiff_t, not int.
5186 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5187 * gtkutil.h: Change prototypes to match the above.
5188
5189 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5190 are duplicate now that they've been promoted to lisp.h.
5191 (x_allocate_bitmap_record, x_alloc_image_color)
5192 (make_image_cache, cache_image, xpm_load):
5193 Don't update size until alloc is done.
5194 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5195 (x_detect_edges):
3256efce 5196 Check for size calculation overflow.
726e0ab1
PE
5197 (ct_colors_allocated_max): New constant.
5198 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5199 overflow.
3256efce 5200
726e0ab1
PE
5201 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5202 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5203 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5204 Use ptrdiff_t, not int, to count maps.
5205 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5206 calculations. Don't update size until allocation succeeds.
5207 Redo calculations to avoid overflow.
726e0ab1
PE
5208 * keyboard.h: Change prototypes to match the above.
5209
5210 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5211 to count maps.
5212 (current_minor_maps): Check for size calculation overflow.
5213 * keymap.h: Change prototypes to match the above.
5214
5215 * lread.c (read1, init_obarray): Don't update size until alloc done.
5216
5217 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5218 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5219
726e0ab1
PE
5220 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5221 Now ptrdiff_t, not int.
5222 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5223 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5224
5225 * process.c (Fnetwork_interface_list): Check for overflow
5226 in size calculation.
5227
5228 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5229
5230 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5231 overflow. Don't bother calling xmalloc when xrealloc will do.
5232
5233 * search.c (Freplace_match): Check for size calculation overflow.
5234 (Fset_match_data): Don't assume list lengths fit in 'int'.
5235
5236 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5237 for command line length. Do not attempt to address one before the
5238 beginning of an array, as that's not portable.
5239
5240 * term.c (max_frame_lines): Remove; unused.
5241 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5242 not int.
5243 (encode_terminal_code, calculate_costs): Check for size
5244 calculation overflow.
5245 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5246 table lengths and related sizes. Don't update size until alloc
5247 done. Redo calculations to avoid overflow.
5248 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5249
5250 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5251 subtracting pointers.
5252 (gobble_line): Check for overflow more carefully. Don't update size
5253 until alloc done.
5254
5255 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5256 Don't update size until alloc done.
5257 Redo size calculations to avoid overflow.
5258 Check for size calculation overflow.
0065d054 5259 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5260
5261 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5262 Use ptrdiff_t, not int, for sizes.
5263 (store_mode_line_noprop_char): Don't update size until alloc done.
5264
0065d054
PE
5265 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5266 Use ptrdiff_t, not int, for sizes.
5267 (Finternal_make_lisp_face, cache_face):
5268 Check for size calculation overflow.
5269 (cache_face): Treat size calculation overflows as if they were
5270 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5271
5272 * xfns.c (x_encode_text, x_set_name_internal)
5273 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5274 sizes, since they can exceed INT_MAX in size. Check for size
5275 calculation overflow.
5276
0065d054
PE
5277 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5278 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5279 Don't update size until alloc done.
5280
0065d054 5281 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5282 as sprintf is limited to int lengths.
1d526e2f 5283
252c5ee1
PE
5284 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5285 (X_LONG_MIN): New macros.
864d7ce7
PE
5286 Use them to make the following changes clearer.
5287 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5288 This change doesn't affect the value now, but it may help remind
5289 future maintainers not to raise the value too much later.
5290 (SELECTION_QUANTUM): Remove, replacing with ...
5291 (selection_quantum): ... new function, which avoids overflow.
5292 All uses changed.
5293 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5294 assumption that selection length fits in 'int'.
5295 (x_reply_selection_request, x_handle_selection_request)
5296 (x_get_window_property, receive_incremental_selection)
5297 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5298 (lisp_data_to_selection_data, clean_local_selection_data):
5299 Use ptrdiff_t, not int, to record length of selection.
5300 (x_reply_selection_request, x_get_window_property)
5301 (receive_incremental_selection, x_property_data_to_lisp):
5302 Redo calculations to avoid overflow.
5303 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5304 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5305 something.
5306 (x_get_window_property, receive_incremental_selection)
5307 (lisp_data_to_selection_data, x_property_data_to_lisp):
5308 Check for size-calculation overflow.
5309 (x_get_window_property, receive_incremental_selection)
5310 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5311 Don't store size until memory allocation succeeds.
5312 (x_get_window_property): Plug memory leak on memory exhaustion.
5313 Don't double-block input; malloc is safe here. Don't assume 2**34
5314 - 4 fits in unsigned long. Add an xassert to check
5315 XGetWindowProperty overflow. Be more careful about overflow
5316 calculations, and distinguish size from memory overflow better.
5317 (receive_incremental_selection): When tracing, don't assume
5318 unsigned int is less than INT_MAX.
5319 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5320 harmful) conversions of unsigned short to int.
5321 (lisp_data_to_selection_data): Don't assume that integers
5322 in the range -65535 through -1 fit in an X unsigned short.
5323 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5324 result parameters unless successful. Rely on cons_to_unsigned
5325 to report problems with elements; the old code wasn't right anyway.
5326 (x_check_property_data): Check for int overflow; we cannot use
5327 a wider type due to X limits.
5328 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5329
726e0ab1 5330 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5331
0065d054
PE
5332 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5333 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5334 (x_color_cells): Don't store size until memory allocation succeeds.
5335 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5336 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5337 (x_term_init): Don't assume length fits in int (sprintf is limited
5338 to int size).
bc18e09d 5339
ebfa62c0
PE
5340 Use ptrdiff_t for composition IDs.
5341 * character.c (lisp_string_width):
5342 * composite.c (composition_table_size, n_compositions)
5343 (get_composition_id, composition_gstring_from_id):
5344 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5345 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5346 * window.c (Frecenter):
5347 Use ptrdiff_t, not int, for composition IDs.
5348 * composite.c (get_composition_id): Check for integer overflow.
5349 * composite.h: Adjust prototypes to match the above changes.
5350
d3411f89
PE
5351 Use ptrdiff_t for hash table indexes.
5352 * category.c (hash_get_category_set):
5353 * ccl.c (ccl_driver):
5354 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5355 * coding.c (coding_system_charset_list, detect_coding_system):
5356 * coding.h (struct coding_system.id):
5357 * composite.c (get_composition_id, gstring_lookup_cache):
5358 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5359 * image.c (xpm_get_color_table_h):
5360 * lisp.h (hash_lookup, hash_put):
5361 * minibuf.c (Ftest_completion):
5362 Use ptrdiff_t for hash table indexes, not int (which is too
5363 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5364 32-bit --with-wide-int hosts).
5365
e097a6fa
PE
5366 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5367 Add a FIXME comment about memory leaks.
5368 (syms_of_charset): Don't assume xmalloc returns.
5369
5637687f
PE
5370 Don't assume that stated character widths fit in int.
5371 * character.c (Fchar_width, c_string_width, lisp_string_width):
5372 * character.h (CHAR_WIDTH):
5373 * indent.c (MULTIBYTE_BYTES_WIDTH):
5374 Use sanitize_char_width to avoid undefined and/or bad behavior
5375 with outlandish widths.
a66cfb1c 5376 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5377 now that we have two such functions. All uses changed.
5378 (sanitize_char_width): New inline function.
5379
a2271ba2
PE
5380 Don't assume that tab-width fits in int.
5381 * character.h (sanitize_width): New inline function.
5382 (SANE_TAB_WIDTH): New macro.
5383 (ASCII_CHAR_WIDTH): Use it.
5384 * indent.c (sane_tab_width): Remove. All uses replaced by
5385 SANE_TAB_WIDTH (current_buffer).
5386 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5387
18c52557
PE
5388 * fileio.c: Integer overflow issues with file modes.
5389 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5390
caeeedc1
PE
5391 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5392 Remove unreachable code.
5393 (read_hex, load_charset_map_from_file): Check for integer overflow.
5394
6df6ae42 5395 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5396 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5397 (x_send_scroll_bar_event): Likewise. Check that the size does not
5398 exceed limits imposed by XClientMessageEvent, as well as the usual
5399 ptrdiff_t and size_t limits.
5400
b13995db
PE
5401 * keyboard.c: Overflow, signedness and related fixes.
5402 (make_lispy_movement): Use same integer type in forward decl
5403 that is used in the definition.
5404 (read_key_sequence, keyremap_step):
5405 Change bufsize argument back to int, undoing my 2011-03-30 change.
5406 We prefer signed types, and int is wide enough here.
5407 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5408 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5409 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5410 length, not size_t. Use ptrdiff_t for index, not int.
5411 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5412 possibility of integer overflow.
5413
13464394
PE
5414 Overflow, signedness and related fixes for images.
5415
5416 * dispextern.h (struct it.stack[0].u.image.image_id)
5417 (struct_it.image_id, struct image.id, struct image_cache.size)
5418 (struct image_cache.used, struct image_cache.ref_count):
5419 * gtkutil.c (update_frame_tool_bar):
5420 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5421 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5422 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5423 * nsmenu.m (update_frame_tool_bar):
5424 * xdisp.c (calc_pixel_width_or_height):
5425 * xfns.c (image_cache_refcount):
5426 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5427 on typical 64-bit hosts.
5428
5429 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5430 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5431 Omit unnecessary casts to int.
5432 (parse_image_spec): Check that integers fall into 'int' range
5433 when the callers expect that.
5434 (image_ascent): Redo ascent calculation to avoid int overflow.
5435 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5436 (lookup_image): Remove unnecessary tests.
5437 (xbm_image_p): Locals are now of int, not EMACS_INT,
5438 since parse_image_check makes sure they fit into int.
5439 (png_load, gif_load, svg_load_image):
5440 Prefer int to unsigned where either will do.
5441 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5442 old tiff_error_handler and tiff_warning_handler.
5443 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5444 stack buffer overflows. It uses only the features of vsnprintf
5445 that are common to both POSIX and native Microsoft.
5446 (tiff_error_handler, tiff_warning_handler): Use it.
5447 (tiff_load, gif_load, imagemagick_load_image):
5448 Don't assume :index value fits in 'int'.
5449 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5450 (imagemagick_load_image): Check that crop parameters fit into
5451 the integer types that MagickCropImage accepts. Don't assume
5452 Vimagemagick_render_type has a nonnegative value. Don't assume
5453 size_t fits in 'long'.
5454 (gs_load): Use printmax_t to print the widest integers possible.
5455 Check for integer overflow when computing image height and width.
5456
c11821d4
EZ
54572011-08-26 Eli Zaretskii <eliz@gnu.org>
5458
5459 * xdisp.c (redisplay_window): Don't force window start if point
5460 will be invisible in the resulting window. (Bug#9324)
5461
0c95fcf7
EZ
54622011-08-25 Eli Zaretskii <eliz@gnu.org>
5463
5464 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5465 the display spec is of the form `(space ...)'.
5466 (handle_display_spec): Return the value returned by
5467 handle_single_display_spec, not just 1 or zero.
5468 (handle_single_display_spec): If the display spec is of the form
5469 `(space ...)', and specifies display in the text area, return 2
5470 rather than 1.
fee65a97 5471 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5472 accurately, and prefer exact match for point under bidi.
5473 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5474
5475 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5476 into disp_prop; all users changed.
5477
5478 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5479 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5480 for the text covered by the display property.
5481
e4ed06f1
CY
54822011-08-25 Chong Yidong <cyd@stupidchicken.com>
5483
5484 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5485 Change return value to nil.
5486 (Frecord_buffer): Delete unused function.
5487
f67cdd7f
EZ
54882011-08-24 Eli Zaretskii <eliz@gnu.org>
5489
5980d4c6
EZ
5490 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5491 buffers, return left-to-right.
8610fe8b
EZ
5492 (set_cursor_from_row): Consider candidate row a win if its glyph
5493 represents a newline and point is on that newline. Fixes cursor
5494 positioning on the newline at EOL of R2L text within L2R
5495 paragraph, and vice versa.
5496 (try_cursor_movement): Check continued rows, in addition to
5497 continuation rows. Fixes unwarranted scroll when point enters a
5498 continued line of R2L text within an L2R paragraph, or vice versa.
5499 (cursor_row_p): Consider the case of point being equal to
5500 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5501 from the end of a short line to the beginning of a continued line
5502 of R2L text within L2R paragraph.
5503 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5504 composed characters.
5980d4c6 5505
f67cdd7f
EZ
5506 * bidi.c (bidi_check_type): Use xassert.
5507 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5508 members.
5509
bca633fb
EZ
55102011-08-23 Eli Zaretskii <eliz@gnu.org>
5511
5512 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5513 a character.
5514
4a5885a7
CY
55152011-08-23 Chong Yidong <cyd@stupidchicken.com>
5516
5517 * nsfont.m (ns_otf_to_script): Fix typo.
5518
0902a04e
KH
55192011-08-22 Kenichi Handa <handa@m17n.org>
5520
5521 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5522 extra slot even if the purpose is char-code-property-table.
5523
1a2e6670
EZ
55242011-08-23 Eli Zaretskii <eliz@gnu.org>
5525
8ddde651
EZ
5526 * xdisp.c (redisplay_window): When computing centering_position,
5527 account for the height of the header line. (Bug#8874)
5528
425cc014
EZ
5529 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5530 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5531 candidate is selected by the mouse, and that candidate has a
5532 composed character under the mouse.
5533
1a2e6670
EZ
5534 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5535 coordinates reported by pos-visible-in-window-p for a composed
5536 character in column zero.
5537
8b76d6f8
SM
55382011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5539
5540 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5541
dac347dd
EZ
55422011-08-22 Eli Zaretskii <eliz@gnu.org>
5543
5544 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5545 consider it a hit if to_charpos is anywhere in the range of the
5546 composed buffer positions.
5547
e013fb34
CY
55482011-08-22 Chong Yidong <cyd@stupidchicken.com>
5549
5550 * image.c (gif_load): Don't assume that each subimage has the same
5551 dimensions as the base image. Handle disposal method that is
5552 "undefined" by the gif spec (Bug#9335).
5553
bd1ba3e8
CY
55542011-08-20 Chong Yidong <cyd@stupidchicken.com>
5555
5556 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5557 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5558
54a1215b
EZ
55592011-08-19 Eli Zaretskii <eliz@gnu.org>
5560
823564e5
EZ
5561 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5562 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5563 from an Org mode buffer to a Speedbar frame.
5564
54a1215b
EZ
5565 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5566 a composition, take its buffer position from IT->cmp_it.charpos.
5567 Fixes cursor positioning at the beginning of a line that begins
5568 with a composed character.
5569
9778ebcc
EZ
55702011-08-18 Eli Zaretskii <eliz@gnu.org>
5571
0be6ee06
EZ
5572 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5573 character bidirectional type, use STRONG_L instead. Fixes crashes
5574 in a buffer produced by `describe-categories'.
5575
9778ebcc
EZ
5576 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5577 members before the level stack, so they would be saved and
5578 restored when copying iterator state. Fixes incorrect reordering
5579 around TABs covered by display properties.
5580
156bffbe
AS
55812011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5582
6b02f655 5583 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5584
72ad093b
CY
55852011-08-17 Chong Yidong <cyd@stupidchicken.com>
5586
5587 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5588 (internal_condition_case_2, internal_condition_case_n):
5589 Remove unnecessary aborts (Bug#9081).
72ad093b 5590
35774242
EZ
55912011-08-17 Eli Zaretskii <eliz@gnu.org>
5592
5593 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5594 has no `load' handler, try opening the file locally. (Bug#9311)
5595
db76dd85
KB
55962011-08-16 Ken Brown <kbrown@cornell.edu>
5597
5598 * gmalloc.c: Expand comment.
5599
b215eee5
EZ
56002011-08-16 Eli Zaretskii <eliz@gnu.org>
5601
5602 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5603 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5604
a4579d33
KB
56052011-08-16 Ken Brown <kbrown@cornell.edu>
5606
5607 Fix memory allocation problems in Cygwin build (Bug#9273).
5608
5609 * unexcw.c ( __malloc_initialized): Declare external variable.
5610 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5611
8b76d6f8
SM
5612 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5613 New variables.
a4579d33
KB
5614 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5615 dumped emacs.
5616 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5617 in the static heap.
5618 [CYGWIN] (special_realloc): New function.
5619 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5620 requests to realloc storage in the static heap.
5621
3ebec551
PE
56222011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5623
5624 * bidi.c (bidi_initialize): Remove unused local.
5625
9fd8be00
EZ
56262011-08-15 Eli Zaretskii <eliz@gnu.org>
5627
6b02f655
SM
5628 * bidimirror.h:
5629 * biditype.h: Remove file.
5630 * makefile.w32-in ($(BLD)/bidi.$(O)):
5631 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5632
5633 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5634
5635 * chartab.c: Improve commentary for the uniprop_table API.
5636
32413314
EZ
5637 * bidi.c (bidi_paragraph_init): Support zero value of
5638 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5639 (bidi_initialize): Use uniprop_table instead of including
5640 biditype.h and bidimirror.h.
32413314 5641
9fd8be00
EZ
5642 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5643 coordinates of the iterator when restoring from ppos_it.
5644 (Bug#9296)
5645
5cf2b69b
KH
56462011-08-14 Kenichi Handa <handa@m17n.org>
5647
5648 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5649 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5650
daf17d00
EZ
56512011-08-14 Eli Zaretskii <eliz@gnu.org>
5652
5653 * xdisp.c (move_it_in_display_line_to): Don't invoke
5654 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5655 ppos_it. Fixes vertical cursor motion when line beginning is
5656 covered by an image. (Bug#9296)
5657
08e3161a
JD
56582011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5659
5660 * nsterm.h (ns_run_ascript): Declare.
5661 (NSAPP_DATA2_RUNASSCRIPT): Define.
5662
5663 * nsfns.m (as_script, as_result, as_status): New static variables.
5664 (ns_run_ascript): New function.
5e617bc2 5665 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5666 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5667 the event loop. Get status from as_status (Bug#7276).
5668
5669 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5670 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5671 the event loop (Bug#7276).
5672
a3720aa2
AS
56732011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5674
5675 * gnutls.c (QCgnutls_bootprop_priority)
5676 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5677 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5678 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5679 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5680 (QCgnutls_bootprop_verify_hostname_error)
5681 (QCgnutls_bootprop_callbacks_verify): Rename from
5682 Qgnutls_bootprop_..., all uses changed.
5683
5684 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5685 uses changed.
5686
0a0d27fb
PE
56872011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5688
19d5c50c
PE
5689 * xfaces.c (Qframe_set_background_mode): Now static.
5690 * dispextern.h (Qframe_set_background_mode): Remove decl.
5691
0a0d27fb
PE
5692 * process.c (Fnetwork_interface_info): Declare local only if needed.
5693
377538cb
JD
56942011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5695
5696 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5697 (Fnetwork_interface_list): Allocate in increments of bytes instead
5698 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5699 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5700 sockaddr.
5701 (struct ifflag_def): notrailers is smart on OSX.
5702 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5703 Get hardware address with getifaddrs if available.
5704
08fff70c
EZ
57052011-08-12 Eli Zaretskii <eliz@gnu.org>
5706
5707 * xdisp.c (iterate_out_of_display_property): xassert that
5708 IT->position is set to within IT->object's boundaries. Break from
5709 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5710 when IT->position is set up wrongly due to some bug.
5711 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5712 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5713 entry. Force push_it to save on the stack the current
5714 buffer/string position, to be restored by pop_it. Fix flags in
5715 the iterator structure wrt the object coming from a display
5716 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5717 properties. (Bug#9284)
5718
7be1c708 57192011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5720
7be1c708
CY
5721 * fontset.c (fontset_get_font_group): Add proper type checks.
5722 (Bug#9172)
aac0c6e3 5723
7be1c708 57242011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5725
7be1c708
CY
5726 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5727 and LC_VERSION_MIN_MACOSX.
5728 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5729 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5730
97bb72a6
EZ
57312011-08-08 Eli Zaretskii <eliz@gnu.org>
5732
5733 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5734 no-display-properties-and-no-overlays under bidi display.
5735 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5736 properties and overlays.
97bb72a6 5737
d5617611
CY
57382011-08-08 Chong Yidong <cyd@stupidchicken.com>
5739
37e11a63
CY
5740 * editfns.c (Fset_time_zone_rule): Document relationship with the
5741 setenv function.
5742
d5617611
CY
5743 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5744 the font entity extracted from the cache (Bug#8109).
5745
58872834
CY
57462011-08-07 Chong Yidong <cyd@stupidchicken.com>
5747
5748 * composite.c (autocmp_chars): Don't reset point. That is done by
5749 restore_point_unwind (Bug#5984).
5750
75bfc667
JL
57512011-08-07 Juri Linkov <juri@jurta.org>
5752
5753 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5754 to show the arg `TIME' instead of `TIMEVAL'.
5755
d1410150
EZ
57562011-08-06 Eli Zaretskii <eliz@gnu.org>
5757
5758 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5759 display property strides EOL and includes a newline, as in
5760 longlines-mode. (Bug#9254)
75b771e4
EZ
5761 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5762 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5763
5764 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5765 is non-zero, even if the data buffer is NULL. Fixes a crash in
5766 vertical-motion with longlines-mode. (Bug#9254)
5767
35928349
EZ
57682011-08-05 Eli Zaretskii <eliz@gnu.org>
5769
ec7cc85b
EZ
5770 * bidi.c <bidi_cache_total_alloc>: Now static.
5771 (bidi_initialize): Initialize bidi_cache_total_alloc.
5772
8b76d6f8 5773 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5774 cache. (Bug#9221)
5775
5776 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5777 amount allocated this far in `bidi_cache_total_alloc'.
5778 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5779 non-zero, only free the data buffer without restoring the cache
5780 contents. All callers changed.
5781
5782 * dispextern.h (bidi_unshelve_cache): Update prototype.
5783
5784 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5785 (move_it_in_display_line, move_it_to)
5786 (move_it_vertically_backward, move_it_by_lines): Replace the call
5787 to xfree to an equivalent call to bidi_unshelve_cache.
5788 (move_it_in_display_line_to): Fix logic of returning
412b6358 5789 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5790
e2e2423b
EZ
57912011-08-05 Eli Zaretskii <eliz@gnu.org>
5792
5793 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5794 came from a string character with a `cursor' property. (Bug#9229)
5795
ae9e757a
JD
57962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5797
5798 * Makefile.in (LIB_PTHREAD): New variable.
5799 (LIBES): Add LIB_PTHREAD (Bug#9216).
5800
5801 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5802 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5803
213bd7f2
AS
58042011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5805
6b02f655 5806 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5807
99aaf75f
JD
58082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5809
5810 * xterm.c (x_find_topmost_parent): New function.
5811 (x_set_frame_alpha): Find topmost parent window with
5812 x_find_topmost_parent and set the property there also (bug#9181).
5813 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5814
c74e9d86
PE
58152011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 * callproc.c (Fcall_process): Avoid vfork clobbering
5818 the local vars buffer, coding_systems, current_dir.
5819
640c8776
SM
58202011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5821
5822 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5823
f26d0e4c
PE
58242011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5825
8a10d76c
PE
5826 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5827 so that it is not optimized away.
5828
f26d0e4c
PE
5829 * xdisp.c (compute_display_string_pos): Remove unused local.
5830
55439c61
EZ
58312011-08-02 Eli Zaretskii <eliz@gnu.org>
5832
5833 Fix slow cursor motion and scrolling in large buffers with
5834 selective display, like Org Mode buffers. (Bug#9218)
5835
5836 * dispextern.h (struct bidi_it): New member disp_prop_p.
5837
5838 * xdisp.c: Remove one-slot cache of display string positions.
5839 (compute_display_string_pos): Accept an additional argument
5e617bc2 5840 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5841 for a display string or property. If found, set DISP_PROP_P
5842 non-zero.
5843
5844 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5845 DISP_PROP_P, and pass it to compute_display_string_pos.
5846 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5847 non-zero. All callers of bidi_fetch_char changed.
5848
fb33fa43
SM
58492011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5850
5851 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5852
b099e063
DM
58532010-12-03 Don March <don@ohspite.net>
5854
5855 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5856 last character M-[char] is translated to ESC [char] (bug#7541).
5857
5cc7f7af
KH
58582011-08-02 Kenichi Handa <handa@m17n.org>
5859
d0fffa3f 5860 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5861
5862 * chartab.c (uniprop_table): Make it non-static.
5863
525d5e6e
EZ
58642011-08-01 Eli Zaretskii <eliz@gnu.org>
5865
5866 * xdisp.c (forward_to_next_line_start): Accept additional argument
5867 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5868 on the newline.
5869 (reseat_at_next_visible_line_start): Use the bidi iterator state
5870 returned by forward_to_next_line_start to restore the state of
5871 it->bidi_it after backing up to previous newline. (Bug#9212)
5872
31011111
AS
58732011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5874
5875 * regex.c (re_comp): Protoize.
5876 (re_exec): Fix return type.
5877 (regexec): Fix type of `ret'. (Bug#9203)
5878
476371c4
PE
58792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5880
e5d76069
PE
5881 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5882 This is needed if max-image-size is a floating-point number.
5883
9a79b20c
AS
58842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5885
5886 * print.c (print_object): Print empty symbol as ##.
5887
5888 * lread.c (read1): Read ## as empty symbol.
5889
d8c2fa78
AA
58902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5891
5892 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5893 setting frame foreground color (Bug#9175).
5894 (x_set_background_color): Likewise.
5895
ffe57a7a
AA
5896 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5897 contents (Bug#9176).
5898 (EmacsTooltip -init): Remove bezels and add shadows to
5899 tooltip windows.
5900
bf3492a5
AA
5901 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5902 or scroll bar (Bug#8470).
5903
d55e9c53
AA
5904 * nsfont.m (nsfont_open): Remove assignment to voffset and
5905 unnecessary vars hshink, expand, hd, full_height, min_height.
5906 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5907
5908 * nsterm.h (nsfont_info): Remove voffset field.
5909
d8c2fa78 59102011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5911
5912 Implement strike-through and overline on NextStep (Bug#8863).
5913
5914 * nsfont.m (nsfont_open): Use underline position provided by font,
5915 instead of hard-coded value of 2.
5916 (nsfont_draw): Call ns_draw_text_decoration instead.
5917
5918 * nsterm.h: Add declaration for ns_draw_text_decoration.
5919
5920 * nsterm.m (ns_draw_text_decoration): New function for drawing
5921 underline, overline, and strike-through.
5922 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5923 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5924 accommodate underlining, etc.
4843aac3 5925
4cc60b9b
EZ
59262011-07-28 Eli Zaretskii <eliz@gnu.org>
5927
bc7ece87
EZ
5928 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5929 default.
4cc60b9b 5930
476371c4
PE
59312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5932
66606eea
PE
5933 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5934 Without this fix, if a signal arrives just after memory fills up,
5935 'malloc' might be invoked reentrantly.
5936
476371c4
PE
5937 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5938 In other words, assume that every image size is allowed, on non-X
5939 hosts. This assumption is probably wrong, but it lets Emacs compile.
5940
f3fcc40d
AS
59412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5942
5943 * regex.c (re_iswctype): Convert return values to boolean.
5944
350c992f
EZ
59452011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5946
5947 * xdisp.c (compute_display_string_pos): Don't use cached display
5948 string position if the buffer had its restriction changed.
5949 (Bug#9184)
5950
5266b4bb
PE
59512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5952
5953 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5954
2573a837 59552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5956
41f55ccd 5957 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5958
39e378da
PE
5959 * bidi.c: Integer size and overflow fixes.
5960 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5961 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5962 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5963 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5964 (bidi_find_other_level_edge):
5965 Use ptrdiff_t instead of EMACS_INT where either will do.
5966 This works better on 32-bit hosts configured --with-wide-int.
5967 (bidi_cache_ensure_space): Check for size-calculation overflow.
5968 Use % rather than repeated addition, for better worst-case speed.
5969 Don't set bidi_cache_size until after xrealloc returns, because it
5970 might not return.
5971 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5972 (bidi_cache_ensure_space): Also check that the bidi cache size
5973 does not exceed that of the largest Lisp string or buffer. See Eli
5974 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5975
5e927815
PE
5976 * alloc.c (__malloc_size_t): Remove.
5977 All uses replaced by size_t. See Andreas Schwab's note
5978 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5979
ca4aa935
PE
5980 * image.c: Improve checking for integer overflow.
5981 (check_image_size): Assume that f is nonnull, since
5982 it is always nonnull in practice. This is one less thing to
5983 worry about when checking for integer overflow later.
5984 (x_check_image_size): New function, which checks for integer
5985 overflow issues inside X.
5986 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5987 This removes the need for a memory_full check.
5988 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5989 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5990 (xbm_read_bitmap_data): Change locals back to 'int', since
5991 their values must fit in 'int'.
5992 (xpm_load_image, png_load, tiff_load):
5993 Invoke x_create_x_image_and_pixmap earlier,
5994 to avoid much needless work if the image is too large.
5995 (tiff_load): Treat overly large images as if
5996 x_create_x_image_and_pixmap failed, not as malloc failures.
5997 (gs_load): Use x_check_image_size.
5998
5f8f9cc2
PE
5999 * gtkutil.c: Omit integer casts.
6000 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6001 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6002
5adf60bc
PE
6003 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6004
c8907a93
PE
6005 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6006 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6007 would wrongly return t on a 64-bit host.
6008
e3c25c68
PE
6009 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6010 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6011 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6012 and therefore cause GCC to emit a bogus diagnostic in some cases.
6013
3f791afe
PE
6014 * image.c: Integer signedness and overflow and related fixes.
6015 This is not an exhaustive set of fixes, but it's time to
6016 record what I've got.
6017 (lookup_pixel_color, check_image_size): Remove redundant decls.
6018 (check_image_size): Don't assume that arbitrary EMACS_INT values
6019 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6020 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6021 (tiff_load, imagemagick_load_image):
6022 Check for overflow in size calculations.
6023 (x_create_x_image_and_pixmap): Remove unnecessary test for
6024 xmalloc returning NULL; that can't happen.
6025 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6026 (xpm_color_bucket): Use better integer hashing function.
6027 (xpm_cache_color): Don't possibly over-allocate memory.
6028 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6029 (gif_memory_source):
6030 Use ptrdiff_t, not int or size_t, to record sizes.
6031 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6032 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6033 either works, as we prefer signed integers.
6034 (tiff_read_from_memory, tiff_write_from_memory):
6035 Return tsize_t, not size_t, since that's what the TIFF API wants.
6036 (tiff_read_from_memory): Don't fail simply because the read would
6037 go past EOF; instead, return a short read.
6038 (tiff_load): Omit no-longer-needed casts.
6039 (Fimagemagick_types): Don't assume size fits into 'int'.
6040
3cc5a532
PE
6041 Improve hashing quality when configured --with-wide-int.
6042 * fns.c (hash_string): New function, taken from sxhash_string.
6043 Do not discard information about ASCII character case; this
6044 discarding is no longer needed.
6045 (sxhash-string): Use it. Change sig to match it. Caller changed.
6046 * lisp.h: Declare it.
6047 * lread.c (hash_string): Remove, since we now use fns.c's version.
6048 The fns.c version returns a wider integer if --with-wide-int is
6049 specified, so this should help the quality of the hashing a bit.
6050
b312a492
PE
6051 * emacs.c: Integer overflow minor fix.
6052 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6053 Define only if GNU_LINUX.
6054 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6055
dfd153ae
PE
6056 * dispnew.c: Integer signedness and overflow fixes.
6057 Remove unnecessary forward decls, that were a maintenance hassle.
6058 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6059 All uses changed.
6060 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6061 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6062 (prepare_desired_row, line_draw_cost):
6063 Use int, not unsigned, where either works.
6064 (save_current_matrix, restore_current_matrix):
6065 Use ptrdiff_t, not size_t, where either works.
6066 (init_display): Check for overflow more accurately, and without
6067 relying on undefined behavior.
6068
a81d11a3
PE
6069 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6070 Remove, replacing with the new symbols in lisp.h. All uses changed.
6071 * fileio.c (make_temp_name):
6072 * filelock.c (lock_file_1, lock_file):
6073 * xdisp.c (message_dolog):
6074 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6075 Use pMd etc. instead.
6076 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6077 replacing the pWIDE etc. symbols removed from editfns.c.
6078
3300e6fd
PE
6079 * keyboard.h (num_input_events): Now uintmax_t.
6080 This is (very slightly) less likely to mess up due to wraparound.
6081 All uses changed.
6082
fd05c7e9
PE
6083 * buffer.c: Integer signedness fixes.
6084 (alloc_buffer_text, enlarge_buffer_text):
6085 Use ptrdiff_t rather than size_t when either will do, as we prefer
6086 signed integers.
6087
903fe15d
PE
6088 * alloc.c: Integer signedness and overflow fixes.
6089 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6090 (__malloc_size_t): Default to size_t, not to int.
6091 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6092 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6093 Prefer ptrdiff_t to size_t when either would do, as we prefer
6094 signed integers.
6095 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6096 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6097 Now const. Initialize with values that are in range even if char
6098 is signed.
6099 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6100 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6101 These functions do the right thing with sizes > 2**32.
6102 (check_depth): Now ptrdiff_t, not int.
6103 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6104 Adjust to new way of storing sizes. Check for size overflow bugs
6105 in rest of code.
6106 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6107 slightly wrong anyway, as it missed one instance of
6108 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6109 (refill_memory_reserve): Omit needless cast to size_t.
6110 (mark_object_loop_halt): Mark as externally visible.
6111
ac82cc6a
PE
6112 * xselect.c: Integer signedness and overflow fixes.
6113 (Fx_register_dnd_atom, x_handle_dnd_message):
6114 Use ptrdiff_t, not size_t, since we prefer signed.
6115 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6116 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6117 x_dnd_atoms_size and x_dnd_atoms_length.
6118
c2d1e36d
PE
6119 * doprnt.c: Prefer signed to unsigned when either works.
6120 * eval.c (verror):
6121 * doprnt.c (doprnt):
6122 * lisp.h (doprnt):
6123 * xdisp.c (vmessage):
6124 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6125 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6126 prefer signed arithmetic to avoid comparison confusion.
6127 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6128 but is a bit tricky.
6129
0e926e56
PE
6130 Assume freestanding C89 headers, string.h, stdlib.h.
6131 * data.c, doprnt.c, floatfns.c, print.c:
6132 Include float.h unconditionally.
6133 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6134 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6135 * regex.c: Likewise for stddef.h, string.h.
6136 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6137 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6138 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6139 (STDC_HEADERS): Remove obsolete defines.
6140 * sysdep.c: Include limits.h unconditionally.
6141
9cfdb3ec
PE
6142 Assume support for memcmp, memcpy, memmove, memset.
6143 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6144 * regex.c (memcmp, memcpy):
6145 Remove; we assume C89 now.
6146
6147 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6148 (__malloc_safe_bcopy): Remove; no longer needed.
6149
cf950e6b 6150 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6151 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6152 well either way, and we prefer signed to unsigned.
6153
dbf38e02
LMI
61542011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6155
6156 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6157 closes the connection while we're reading (bug#9182).
6158
d6f0886c 61592011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6160
d6f0886c
JD
6161 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6162 are specified (Bug#9168).
24e0f6b1 6163
2eb1f9e6
PE
61642011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6165
6166 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6167 Found by GCC static checking and --with-wide-int on a 32-bit host.
6168
22381272 61692011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6170
6171 * xdisp.c (compute_display_string_pos): Fix logic of caching
6172 previous display string position. Initialize cached_prev_pos to
6173 -1. Fixes slow-down at the beginning of a buffer.
6174
f25e39b4
EZ
61752011-07-24 Eli Zaretskii <eliz@gnu.org>
6176
6177 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6178 for attrs[LFACE_FONTSET_INDEX].
6179
04c4b52e
PE
61802011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6181
6182 * xml.c (parse_region): Remove unused local
6183 that was recently introduced.
6184
c1734fbd
EZ
61852011-07-23 Eli Zaretskii <eliz@gnu.org>
6186
be18c5a5
EZ
6187 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6188 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6189
c1734fbd
EZ
6190 * xdisp.c (move_it_in_display_line_to): Record the best matching
6191 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6192 exit if none of the characters scanned was an exact match.
6193 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6194 when exact match is impossible due to invisible text, and the
6195 lines are truncated.
6196
a258d627
JD
61972011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6198
6199 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6200 for OSX >= 10.7.
6201
b6d5a689
EZ
62022011-07-22 Eli Zaretskii <eliz@gnu.org>
6203
0f74f785
EZ
6204 Fix a significant slow-down of cursor motion with C-n, C-p,
6205 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6206 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6207 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6208 (next_element_from_buffer): Call compute_stop_pos_backwards to
6209 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6210 base_level_stop.
6211 (reseat): Don't look for prev_stop, as that could mean a very long
6212 run.
6213 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6214 <cached_disp_overlay_modiff>: Cache for last found display string
6215 position.
551918c1 6216 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6217 about the same buffer in the same area of character positions, and
6218 the buffer wasn't changed since the time the display string
6219 position was cached.
551918c1 6220
b2d0c91a
EZ
62212011-07-22 Eli Zaretskii <eliz@gnu.org>
6222
6223 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6224 is an integer, which is important for empty lines. (Bug#9149)
6225
043604ee
CY
62262011-07-22 Chong Yidong <cyd@stupidchicken.com>
6227
6228 * frame.c (Fmodify_frame_parameters): In tty case, update the
6229 default face if necessary (Bug#4238).
6230
da4adb04
CY
62312011-07-21 Chong Yidong <cyd@stupidchicken.com>
6232
6233 * editfns.c (Fstring_to_char): No need to explain what a character
6234 is in the docstring (Bug#6576).
6235
9abd0532
LMI
62362011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6237
6238 * xml.c (parse_region): Make sure we always return a tree.
6239
36881d16
HK
62402011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6241
6242 * xml.c (parse_region): If a document contains only comments,
6243 return that, too.
6244
1e98674d
LMI
62452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6246
6247 * xml.c (make_dom): Return comments, too.
6248
590bd467
PE
62492011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6250
6251 Port to OpenBSD.
6252 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6253 and the surrounding thread.
6254 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6255 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6256 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6257 timer goes off.
6258 * s/openbsd.h (BROKEN_SIGIO): Define.
6259 * unexelf.c (unexec) [__OpenBSD__]:
6260 Don't update the .mdebug section of the Alpha COFF symbol table.
6261
f41628b2
LMI
62622011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6263
6264 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6265 (bug#8460).
6266
b59b67c5
PE
62672011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6268
15e3a074
PE
6269 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6270 This fixes some race conditions on the permissions of any newly
6271 created file.
6272
41bed37d
PE
6273 * alloc.c (valid_pointer_p): Use pipe, not open.
6274 This fixes some permissions issues when debugging.
6275
b59b67c5
PE
6276 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6277 If fchown fails to set both uid and gid, try to set just gid,
6278 as that is sometimes allowed. Adjust the file's mode to eliminate
6279 setuid or setgid bits that are inappropriate if fchown fails.
6280
925a6be7
SM
62812011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6282
6283 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6284 to compare Lisp_Objects.
6285 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6286 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6287 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6288
52968808
AS
62892011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6290
0a6a104b
AS
6291 * lread.c (read_integer): Unread even EOF character.
6292 (read1): Likewise. Properly record start position of symbol.
6293
52968808
AS
6294 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6295 symbol character follows.
6296
9e381cdd
PE
62972011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6298
6299 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6300 This works around a problem with the previous change to Fcopy_file.
6301 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6302 and without this change, GCC might complain about discarding
6303 fchown's return value.
6304
b5641435
JB
63052011-07-16 Juanma Barranquero <lekktu@gmail.com>
6306
6307 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6308
a8031457
PE
63092011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6310
6311 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6312
dd889327
LMI
63132011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6314
750c33f7
LMI
6315 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6316 it's used from the C level.
6317
dd889327
LMI
6318 * process.c: Use the same condition for POLL_FOR_INPUT in both
6319 keyboard.c and process.c (bug#1858).
6320
87e86684
LM
63212011-07-09 Lawrence Mitchell <wence@gmx.li>
6322
6323 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6324 (Fgnutls_boot): Use it.
6325
64348f40
AS
63262011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6327
6328 * doc.c (Fsubstitute_command_keys): Revert last change.
6329
1d698799
LMI
63302011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6331
f863868c
LMI
6332 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6333 quotes the next character, and doesn't affect other longer
6334 sequences (bug#8935).
6335
1d698799
LMI
6336 * lread.c (syms_of_lread): Clarify that is isn't only
6337 `eval-buffer' and `eval-defun' that's affected by
6338 `lexical-binding' (bug#8460).
6339
aa4b6df6
EZ
63402011-07-15 Eli Zaretskii <eliz@gnu.org>
6341
6342 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6343 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6344
5d856da6
PE
63452011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6346
ad6042bb
PE
6347 Fix minor problems found by static checking.
6348 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6349 (elsz): Now a signed constant, not a size_t var. We prefer signed
6350 types to unsigned, to avoid integer comparison confusion. Without
6351 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6352 "cannot optimize loop, the loop counter may overflow", a symptom
6353 of the confusion.
f00bbb22 6354 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6355 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6356
6468f31c
LMI
63572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6358
49080b10
LMI
6359 * search.c (Fre_search_backward): Mention `case-fold-search' in
6360 all the re_search_* functions (bug#8138).
6361
6468f31c
LMI
6362 * keyboard.c (Fopen_dribble_file): Document when the file is
6363 closed (bug#8056).
6364
c965adc5
EZ
63652011-07-14 Eli Zaretskii <eliz@gnu.org>
6366
df9733bf
EZ
6367 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6368 bidi_cache_idx.
6369
0bb23927
EZ
6370 Support bidi reordering of display and overlay strings.
6371 * xdisp.c (compute_display_string_pos)
6372 (compute_display_string_end): Accept additional argument STRING.
6373 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6374 (reseat_to_string): Initialize bidi_it->string.s and
6375 bidi_it->string.schars.
6376 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6377 NULL (avoids a crash in bidi_paragraph_init).
6378 Initialize itb.string.lstring.
0bb23927
EZ
6379 (init_iterator): Call bidi_init_it only of a valid
6380 buffer position was specified. Initialize paragraph_embedding to
6381 L2R.
6382 (reseat_to_string): Initialize the bidi iterator.
6383 (display_string): If we need to ignore text properties of
6384 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6385 original value of -1 will not work with bidi.)
6386 (compute_display_string_pos): First arg is now struct
6387 `text_pos *'; all callers changed. Support display properties on
6388 Lisp strings.
6389 (compute_display_string_end): Support display properties on Lisp
6390 strings.
6391 (init_iterator, reseat_1, reseat_to_string): Initialize the
6392 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6393 when iterating on a string not from display properties).
640c8776
SM
6394 (compute_display_string_pos, compute_display_string_end):
6395 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6396 arrow keys.
6397 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6398 base_level_stop; instead, set base_level_stop to BEGV.
6399 Fixes crashes in vertical-motion.
0bb23927
EZ
6400 (next_element_from_buffer): Improve commentary for when
6401 the iterator is before prev_stop.
6402 (init_iterator): Initialize bidi_p from the default value of
6403 bidi-display-reordering, not from buffer-local value. Use the
6404 buffer-local value only if initializing for buffer iteration.
6405 (handle_invisible_prop): Support invisible properties on strings
6406 that are being bidi-reordered.
6407 (set_iterator_to_next): Support bidi reordering of C strings and
6408 Lisp strings.
6409 (next_element_from_string): Support bidi reordering of Lisp
6410 strings.
6411 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6412 (display_string): Support display of R2L glyph rows.
6413 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6414 (init_iterator): Don't initialize it->bidi_p for strings
6415 here.
6416 (reseat_to_string): Initialize it->bidi_p for strings here.
6417 (next_element_from_string, next_element_from_c_string)
6418 (next_element_from_buffer): Add xassert's for correspondence
6419 between IT's object being iterated and it->bidi_it.string
6420 structure.
6421 (face_before_or_after_it_pos): Support bidi iteration.
6422 (next_element_from_c_string): Handle the case of the first string
6423 character that is not the first one in the visual order.
6424 (get_visually_first_element): New function, refactored from common
6425 parts of next_element_from_buffer, next_element_from_string, and
6426 next_element_from_c_string.
6427 (tool_bar_lines_needed, redisplay_tool_bar)
6428 (display_menu_bar): Force left-to-right direction. Add a FIXME
6429 comment for making that be controlled by a user option.
6430 (push_it, pop_it): Save and restore the state of the
6431 bidi iterator. Save and restore the bidi_p flag.
6432 (pop_it): Iterate out of display property for string iteration as
6433 well.
6434 (iterate_out_of_display_property): Support iteration over strings.
6435 (handle_single_display_spec): Set up it->bidi_it for iteration
6436 over a display string, and call bidi_init_it.
6437 (handle_single_display_spec, next_overlay_string)
6438 (get_overlay_strings_1, push_display_prop): Set up the bidi
6439 iterator for displaying display or overlay strings.
6440 (forward_to_next_line_start): Don't use the shortcut if
6441 bidi-iterating.
6442 (back_to_previous_visible_line_start): If handle_display_prop
6443 pushed the iterator stack, restore the internal state of the bidi
6444 iterator by calling bidi_pop_it same number of times.
6445 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6446 and we are bidi-iterating, don't decrement the iterator position;
6447 instead, set the first_elt flag in the bidi iterator, to produce
6448 the same effect.
6449 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6450 (push_display_prop): xassert that we are iterating a buffer.
6451 (push_it, pop_it): Save and restore paragraph_embedding member.
6452 (handle_single_display_spec, next_overlay_string)
6453 (get_overlay_strings_1, reseat_1, reseat_to_string)
6454 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6455 correctly. Don't assume unibyte strings are not bidi-reordered.
6456 (compute_display_string_pos)
6457 (compute_display_string_end): Fix handling the case of C string.
6458 (push_it, pop_it): Save and restore from_disp_prop_p.
6459 (handle_single_display_spec, push_display_prop): Set the
6460 from_disp_prop_p flag.
6461 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6462 (pop_it): Call iterate_out_of_display_property only if we are
6463 popping after iteration over a string that came from a display
6464 property. Fix a typo in popping stretch info. Add an assertion
6465 for verifying that the iterator position is in sync with the bidi
6466 iterator.
6467 (handle_single_display_spec, get_overlay_strings_1)
6468 (push_display_prop): Fix initialization of paragraph direction for
6469 string when that of the parent object is not yet determined.
6470 (reseat_1): Call bidi_init_it to resync the bidi
6471 iterator with IT's position. (Bug#7616)
6472 (find_row_edges): If ROW->start.pos gives position
6473 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6474 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6475 Reset the from_disp_prop_p flag.
6476 (SAVE_IT, RESTORE_IT): New macros.
6477 (pos_visible_p, face_before_or_after_it_pos)
6478 (back_to_previous_visible_line_start)
6479 (move_it_in_display_line_to, move_it_in_display_line)
6480 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6481 (try_scrolling, redisplay_window, display_line): Use them when
6482 saving a temporary copy of the iterator and restoring it back.
6483 (back_to_previous_visible_line_start, reseat_1)
6484 (init_iterator): Empty the bidi cache "stack".
6485 (move_it_in_display_line_to): If iterator ended up at
6486 EOL, but we never saw any buffer positions smaller than
6487 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6488 motion in bidi-reordered lines.
6489 (move_it_in_display_line_to): Record prev_method and prev_pos
6490 immediately before the call to set_iterator_to_next. Fixes cursor
6491 motion in bidi-reordered lines with stretch glyphs and strings
6492 displayed in margins. (Bug#8133) (Bug#8867)
6493 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6494 TO_CHARPOS.
640c8776
SM
6495 (pos_visible_p): Support positions in bidi-reordered lines.
6496 Save and restore bidi cache.
0bb23927
EZ
6497
6498 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6499 (bidi_paragraph_info): Delete unused struct.
6500 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6501 (bidi_cache_start): New variable.
6502 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6503 to zero.
6504 (bidi_cache_fetch_state, bidi_cache_search)
6505 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6506 (bidi_cache_find, bidi_peek_at_next_level)
6507 (bidi_level_of_next_char, bidi_find_other_level_edge)
6508 (bidi_move_to_visually_next): Compare cache index with
6509 bidi_cache_start rather than with zero.
6510 (bidi_fetch_char): Accept new argument STRING; all callers
6511 changed. Support iteration over a string. Support strings with
6512 display properties. Support unibyte strings. Fix the type of
6513 `len' according to what STRING_CHAR_AND_LENGTH expects.
6514 (bidi_paragraph_init, bidi_resolve_explicit_1)
6515 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6516 (bidi_level_of_next_char, bidi_move_to_visually_next):
6517 Support iteration over a string.
0bb23927
EZ
6518 (bidi_set_sor_type, bidi_resolve_explicit_1)
6519 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6520 can now be zero (for strings); special values 0 and -1 were
6521 changed to -1 and -2, respectively.
6522 (bidi_char_at_pos): New function.
6523 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6524 Call it instead of FETCH_MULTIBYTE_CHAR.
6525 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6526 initialized to valid values.
6527 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6528 values.
6529 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6530 the test for valid cached positions. Fix the logic for looking up
6531 the sentinel state in the cache. GCPRO the Lisp string we are
6532 iterating.
6533 (bidi_push_it, bidi_pop_it): New functions.
6534 (bidi_initialize): Initialize the bidi cache start stack pointer.
6535 (bidi_cache_ensure_space): New function, refactored from part of
6536 bidi_cache_iterator_state. Don't assume the required size is just
6537 one BIDI_CACHE_CHUNK away.
6538 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6539 (bidi_count_bytes, bidi_char_at_pos): New functions.
6540 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6541 always valid if bidi_cache_idx is valid.
6542 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6543 is valid if it's going to be used.
6544 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6545 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6546 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6547 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6548 (bidi_find_other_level_edge, bidi_cache_start_stack):
6549 All variables related to cache indices are now EMACS_INT.
c965adc5 6550
0bb23927
EZ
6551 * dispextern.h (struct bidi_string_data): New structure.
6552 (struct bidi_it): New member `string'. Make flag members be 1-bit
6553 fields, and put them last in the struct.
640c8776
SM
6554 (compute_display_string_pos, compute_display_string_end):
6555 Update prototypes.
0bb23927
EZ
6556 (bidi_push_it, bidi_pop_it): Add prototypes.
6557 (struct iterator_stack_entry): New members bidi_p,
6558 paragraph_embedding, and from_disp_prop_p.
6559 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6560 (bidi_shelve_cache, bidi_unshelve_cache):
6561 Declare prototypes.
0bb23927
EZ
6562
6563 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6564 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6565 and vector-like objects.
6566
6567 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6568 cache around display iteration.
6569
6570 * window.c (Fwindow_end, window_scroll_pixel_based)
6571 (displayed_window_lines, Frecenter): Save and restore the bidi
6572 cache around display iteration.
6573
3bbd2265
LMI
65742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6575
6576 * editfns.c (Fdelete_region): Clarify the use of the named
6577 parameters (bug#6788).
6578
adc47434
MR
65792011-07-14 Martin Rudalics <rudalics@gmx.at>
6580
6581 * indent.c (Fvertical_motion): Set and restore w->pointm when
6582 saving and restoring the window's buffer (Bug#9006).
6583
837c31f8
LMI
65842011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6585
6586 * editfns.c (Fstring_to_char): Clarify just what is returned
6587 (bug#6576). Text by Eli Zaretskii.
6588
ac389d0c
JB
65892011-07-13 Juanma Barranquero <lekktu@gmail.com>
6590
6591 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6592
0be0ce47
EZ
65932011-07-13 Eli Zaretskii <eliz@gnu.org>
6594
6595 * buffer.c (mmap_find): Fix a typo.
6596
cd18e7e3
JB
65972011-07-13 Johan Bockgård <bojohan@gnu.org>
6598
6599 Fix execution of x selection hooks.
6600 * xselect.c (Qx_lost_selection_functions)
6601 (Qx_sent_selection_functions): New vars.
6602 (syms_of_xselect): DEFSYM them.
6603 (x_handle_selection_request): Pass Qx_sent_selection_functions
6604 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6605 (x_handle_selection_clear,x_clear_frame_selections):
6606 Pass Qx_lost_selection_functions rather than
6607 Vx_lost_selection_functions to Frun_hook_with_args.
6608
47ea7f44
PE
66092011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6610
ac389d0c 6611 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6612 The old code sometimes used this field without initializing it.
6613
47ea7f44
PE
6614 * alloc.c (gc_sweep): Don't read past end of array.
6615 In theory, the old code could also have corrupted Emacs internals,
6616 though it'd be very unlikely.
6617
bc985c87
AS
66182011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6619
6620 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6621 argument. (Bug#4026)
bc985c87 6622
0cf34688
LMI
66232011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6624
b3dadd76
LMI
6625 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6626 key" (bug#4257).
6627
0cf34688
LMI
6628 * window.c (Fset_window_start): Doc fix (bug#4199).
6629 (Fset_window_hscroll): Ditto.
6630
270768cd
PE
66312011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6632
077e3dda 6633 Fix minor new problems caught by GCC 4.6.1.
270768cd 6634 * term.c (init_tty): Remove unused local.
490011a6 6635 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6636 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6637 not used otherwise.
270768cd 6638
b1f58454
CY
66392011-07-12 Chong Yidong <cyd@stupidchicken.com>
6640
6641 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6642
22b9578d
LMI
66432011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6644
6e70ab07
LMI
6645 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6646 are the mini-buffer and the echo area (bug#3320).
6647
22b9578d
LMI
6648 * term.c (init_tty): Remove support for supdup, c10 and perq
6649 terminals, which are no longer supported (bug#1482).
6650
8974cc9f
JB
66512011-07-10 Johan Bockgård <bojohan@gnu.org>
6652
6653 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6654
a560d974
JD
66552011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6656
6657 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6658 for non-popups (Bug#3642).
6659
1dae0f0a
AS
66602011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6661
268c2c36 6662 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6663 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6664 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6665 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6666 * data.c (fmod): Likewise.
6667 * dispnew.c (swap_glyphs_in_rows): Likewise.
6668 * emacs.c (memory_warning_signal): Likewise.
6669 * floatfns.c (float_error): Likewise.
6670 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6671 (otf_open, font_otf_capability, generate_otf_features)
6672 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6673 Likewise.
6674 * image.c (pbm_read_file): Likewise.
6675 * indent.c (string_display_width): Likewise.
6676 * intervals.c (check_for_interval, search_for_interval)
6677 (inc_interval_count, count_intervals, root_interval)
6678 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6679 * lread.c (defalias): Likewise.
268c2c36 6680 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6681 * regex.c (set_image_of_range_1, set_image_of_range)
6682 (regex_grow_registers): Likewise.
6683 * sysdep.c (strerror): Likewise.
6684 * termcap.c (valid_filename_p, tprint, main): Likewise.
6685 * tparam.c (main): Likewise.
6686 * unexhp9k800.c (run_time_remap, save_data_space)
6687 (update_file_ptrs, read_header, write_header, calculate_checksum)
6688 (copy_file, copy_rest, display_header): Likewise.
6689 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6690 Likewise.
6691 * xdisp.c (check_it): Likewise.
6692 * xfaces.c (register_color, unregister_color, unregister_colors):
6693 Likewise.
6694 * xfns.c (print_fontset_result): Likewise.
6695 * xrdb.c (member, fatal, main): Likewise.
6696
99033785
PE
66972011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6698
6699 Fix minor problems found by static checking (Bug#9031).
6700 * chartab.c (char_table_set_range, map_sub_char_table):
6701 Remove unused locals.
6702 (uniprop_table): Now static.
6703 * composite.c (_work_char): Remove unused static var.
6704
9cb2ac56
JB
67052011-07-09 Juanma Barranquero <lekktu@gmail.com>
6706
6707 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6708
f25661f0
JD
67092011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6710
6711 * gtkutil.c (qttip_cb): Remove code without function.
6712
8278c4fe
EZ
67132011-07-09 Eli Zaretskii <eliz@gnu.org>
6714
6715 * w32.c (pthread_sigmask): New stub.
6716
1692ae2d 67172011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6718
8a6ebd58 6719 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6720 sigprocmask is portable only for single-threaded applications, and
6721 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6722 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6723 (LIBES): Use it.
6724 * callproc.c (Fcall_process):
6725 * process.c (create_process):
6726 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6727 Use pthread_sigmask, not sigprocmask.
123403e4 6728
1b854618
JD
67292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6730
6731 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6732 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6733 wrong (Bug#8591).
6734
3fe4b549
JD
67352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6736
0ce7e563
JD
6737 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6738 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6739 (xg_hide_tooltip): Fix comment.
6740
3fe4b549
JD
6741 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6742 in registerServicesMenuSendTypes.
6743 (validRequestorForSendType): Don't check ns_return_types.
6744
6745 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6746 ns_return_type.
6747
5df75e47
JR
67482011-07-08 Jason Rumney <jasonr@gnu.org>
6749
22610910
JR
6750 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6751 SH_SHOW for hidden windows (Bug#5482).
6752
5df75e47
JR
6753 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6754 frame struct members of non-existent frames (Bug#6284).
6755
699c10bd
JD
67562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6757
4393663b
JD
6758 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6759 variable firstTime not needed on OSX >= 10.6.
6760 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6761 >= 10.5. Use setKnobProportion, setDoubleValue.
6762
6763 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6764 (MAC_OS_X_VERSION_10_5): Define if not defined.
6765 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6766 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6767 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6768
6769 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6770 cString and lossyCString on OSX >= 10.4
6771
58179cce 6772 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6773 sizeToFit on OSX >= 10.2.
6774
6775 * nsimage.m (allocInitFromFile): Don't use deprecated method
6776 bestRepresentationForDevice on OSX >= 10.6.
6777
6778 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6779 to avoid warning.
6780
6781 * emacs.c: Declare unexec_init_emacs_zone.
6782
a63e0781
JD
6783 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6784
699c10bd
JD
6785 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6786
6787 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6788 on svcsMenu (Bug#8842).
6789
6790 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6791 ns_return_types.
6792 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6793
6794 * nsterm.m (QUTF8_STRING): Declare.
6795 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6796 (validRequestorForSendType): Return type is (id).
6797 Change indexOfObjectIdenticalTo to indexOfObject.
6798 Check if we have local selection before returning self (Bug#8842).
6799 (writeSelectionToPasteboard): Put local selection into paste board
6800 if we have a local selection (Bug#8842).
6801 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6802
6803 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6804 (ns_get_local_selection): Declare.
6805
54e10184
LMI
68062011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6807
9888ff71
LMI
6808 * keymap.c (describe_map_tree): Don't insert a double newline at
6809 the end of the buffer (bug#1169) and return whether we inserted
6810 something.
6811
54e10184
LMI
6812 * callint.c (Fcall_interactively): Change "reading args" to
6813 "providing args" to try to clarify what it does (bug#1010).
6814
15fa4783
KH
68152011-07-07 Kenichi Handa <handa@m17n.org>
6816
6817 * composite.c (composition_compute_stop_pos): Ignore a static
6818 composition starting before CHARPOS (Bug#8915).
6819
6820 * xdisp.c (handle_composition_prop): Likewise.
6821
a8815b00
EZ
68222011-07-07 Eli Zaretskii <eliz@gnu.org>
6823
6824 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6825 (Bug#9015)
6826
ef7b981d 68272011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6828
6829 * character.h (unicode_category_t): New enum type.
6830
6831 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6832 (Qchar_code_property_table): New variable.
6833 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6834 (UNIPROP_COMPRESSED_FORM_P): New macros.
6835 (char_table_ascii): Uncompress the compressed values.
6836 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6837 Uncompress the compressed values.
ac389d0c 6838 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6839 (char_table_ref_and_range): Uncompress the compressed values.
6840 (sub_char_table_set): New arg is_uniprop. Callers changed.
6841 Uncompress the compressed values.
6842 (sub_char_table_set_range): Args changed. Callers changed.
6843 (char_table_set_range): Adjuted for the above change.
6844 (map_sub_char_table): Delete args default_val and parent. Add arg
6845 top. Give decoded values to a Lisp function.
640c8776 6846 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6847 values to a Lisp function. Gcpro more variables.
6848 (uniprop_table_uncompress)
6849 (uniprop_decode_value_run_length): New functions.
6850 (uniprop_decoder, uniprop_decoder_count): New variables.
6851 (uniprop_get_decoder, uniprop_encode_value_character)
6852 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6853 New functions.
6854 (uniprop_encoder, uniprop_encoder_count): New variables.
6855 (uniprop_get_encoder, uniprop_table)
6856 (Funicode_property_table_internal, Fget_unicode_property_internal)
6857 (Fput_unicode_property_internal): New functions.
6858 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6859 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6860 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6861 char-code-property-alist.
6862
640c8776 6863 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6864 Vunicode_category_table.
6865
640c8776 6866 * font.c (font_range): Adjust for the change of
c805dec0
KH
6867 Vunicode_category_table.
6868
76b397fb
DN
68692011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6870
6871 * m/iris4d.h: Remove file, move contents ...
6872 * s/irix6-5.h: ... here.
6873
22b4128e
PE
68742011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6875
6876 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6877 * alloc.c (mark_buffer):
6878 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6879 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6880 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6881 This isn't true in general, and it's particularly not true
6882 if Emacs is configured with --with-wide-int.
6883 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6884 New macros, used in the buffer.c change.
6885
869795d6
JD
68862011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6887
6888 * xsettings.c: Use both GConf and GSettings if both are available.
6889 (store_config_changed_event): Add comment.
6890 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6891 (store_tool_bar_style_changed): New functions.
5e617bc2 6892 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6893 (struct xsettings): Move font inside HAVE_XFT.
6894 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6895 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6896 Move inside HAVE_XFT.
640c8776 6897 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6898 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6899 also.
6900 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6901 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6902 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6903 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6904 (parse_settings): Move check for font inside HAVE_XFT.
6905 (read_settings, apply_xft_settings): Add comment.
6906 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6907 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6908 call store_font_name_changed.
6909 (xft_settings_event): Add comment.
6910 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6911 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6912 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6913 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6914 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6915 (xsettings_get_system_font, xsettings_get_system_normal_font):
6916 Add comment.
869795d6 6917
d8ed26bd
PE
69182011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6919
6920 Random fixes. E.g., (random) never returned negative values.
6921 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6922 subseconds part to the entropy, as that's a bit more random.
6923 Prefer signed to unsigned, since the signedness doesn't matter and
6924 in general we prefer signed. When given a limit, use a
6925 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6926 latter isn't right if USE_2_TAGS_FOR_INTS.
6927 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6928 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6929
cabf1cac
SM
69302011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6931
6932 * textprop.c (text_property_stickiness):
6933 Obey Vtext_property_default_nonsticky.
6934 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6935 * w32fns.c (syms_of_w32fns):
6936 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6937
6e9b2be9
PE
69382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6939
6940 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6941 This is more efficient than Ffile_directory_p and avoids a minor race.
6942
90186c68
LMI
69432011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6944
7c301272
LMI
6945 * buffer.c (Foverlay_put): Say what the return value is
6946 (bug#7835).
6947
c4f2d8d4
LMI
6948 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6949 is a directory before asking whether to use the file name
6950 (bug#7564).
ad637907
LMI
6951 (barf_or_query_if_file_exists): Make the "File is a directory"
6952 error be more correct.
c4f2d8d4 6953
90186c68
LMI
6954 * fns.c (Frequire): Remove the mention of the .gz files, since
6955 that's installation-specific, but keep the mention of
6956 `get-load-suffixes'.
6957
da64016e
PE
69582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6959
6960 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6961 Report string overflow if the output is too long.
6962
7d47b580
JB
69632011-07-04 Juanma Barranquero <lekktu@gmail.com>
6964
a555cb87
JB
6965 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6966 (syms_of_gnutls): Remove duplicate DEFSYM for
6967 Qgnutls_bootprop_verify_hostname_error, an error for
6968 Qgnutls_bootprop_verify_error (which is no longer used).
6969
7d47b580
JB
6970 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6971 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6972 Also (re)move comments that are misplaced or no longer relevant.
6973
1e49bfab
LMI
69742011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6975
6976 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6977
1485f4c0
CY
69782011-07-03 Chong Yidong <cyd@stupidchicken.com>
6979
6980 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6981 and background color parameters if they have been changed.
6982
a9ab721e
LMI
69832011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6984
6985 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6986
cf7cff57
PE
69872011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6988
2e13213d
PE
6989 * xsettings.c (SYSTEM_FONT): Define only when used.
6990 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6991
cf7cff57
PE
6992 * keymap.c (access_keymap_1): Now static.
6993
7a8e04f7
CY
69942011-07-02 Chong Yidong <cyd@stupidchicken.com>
6995
6996 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6997 leave any prefix arg for the up event (Bug#1586).
6998
61352f62
LMI
69992011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7000
69bb1ef7
LMI
7001 * lread.c (syms_of_lread): Mention single symbols defined by
7002 `defvar' or `defconst' (bug#7154).
7003
61352f62 7004 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7005 (Frequire): Mention get-load-suffixes.
61352f62 7006
28545e04
MR
70072011-07-02 Martin Rudalics <rudalics@gmx.at>
7008
7009 * window.h (window): Remove clone_number slot.
7010 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7011 Remove.
7012 (make_parent_window, make_window, saved_window)
7013 (Fset_window_configuration, save_window_save): Don't deal with
7014 clone numbers.
7015 * buffer.c (Qclone_number): Remove declaration.
7016 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7017
3349e122
SM
70182011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7019
7020 Add multiple inheritance to keymaps.
7021 * keymap.c (Fmake_composed_keymap): New function.
7022 (Fset_keymap_parent): Simplify.
7023 (fix_submap_inheritance): Remove.
7024 (access_keymap_1): New function extracted from access_keymap to handle
7025 embedded parents and handle lists of maps.
7026 (access_keymap): Use it.
7027 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7028 (Fcopy_keymap): Handle embedded parents.
7029 (Fcommand_remapping, define_as_prefix): Simplify.
7030 (Fkey_binding): Simplify.
7031 (syms_of_keymap): Move minibuffer-local-completion-map,
7032 minibuffer-local-filename-completion-map,
7033 minibuffer-local-must-match-map, and
7034 minibuffer-local-filename-must-match-map to Elisp.
7035 (syms_of_keymap): Defsubr make-composed-keymap.
7036 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7037 (parse_menu_item): Trivial simplification.
7038
3279eb87
GM
70392011-07-01 Glenn Morris <rgm@gnu.org>
7040
7041 * Makefile.in (SETTINGS_LIBS): Fix typo.
7042
4550efdf
KI
70432011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7044
7045 * coding.c (Fencode_coding_string): Record the last coding system
7046 used, as the function doc string says (bug#8738).
7047
0949d2b6
JD
70482011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7049
7050 * xsettings.c (store_monospaced_changed): Take new font as arg and
7051 check for change against current_mono_font.
7052 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7053 (emacs_settings_constructor, emacs_settings_get_property)
7054 (emacs_settings_set_property, emacs_settings_class_init)
7055 (emacs_settings_init, gsettings_obj): Remove.
7056 (something_changedCB): New function for HAVE_GSETTINGS.
7057 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7058 with value as argument.
7059 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7060 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7061 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7062 "changed".
7063
7064 * xgselect.c: Add defined (HAVE_GSETTINGS).
7065 (xgselect_initialize): Ditto.
7066
7067 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7068 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7069 xg_select.
7070
bbc6b304
PE
70712011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7072
7073 * eval.c (struct backtrace): Simplify and port the data structure.
7074 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7075 signed bit field, as this assumption is not portable and it makes
7076 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7077 "char debug_on_exit : 1" as this is not portable either; instead,
7078 use the portable "unsigned int debug_on_exit : 1". Remove unused
7079 member evalargs. Remove obsolete comments about cc bombing out.
7080
9851bfc5
JD
70812011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7082
51bb811f 7083 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7084 Let HAVE_GSETTINGS override HAVE_GCONF.
7085 (store_monospaced_changed): New function.
7086 (EMACS_SETTINGS): A new type derived from GObject to handle
7087 GSettings notifications.
7088 (emacs_settings_constructor, emacs_settings_get_property)
7089 (emacs_settings_set_property, emacs_settings_class_init):
7090 New functions.
7091 (gsettings_client, gsettings_obj): New variables.
7092 (GSETTINGS_SCHEMA): New define.
7093 (something_changedCB): Call store_monospaced_changed.
7094 (init_gsettings): New function.
7095 (xsettings_initialize): Call init_gsettings.
7096 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7097 to NULL.
7098
640c8776 7099 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7100 GCONF_CFLAGS/LIBS.
7101
5386012d
MR
71022011-06-29 Martin Rudalics <rudalics@gmx.at>
7103
7104 * window.c (resize_root_window, grow_mini_window)
7105 (shrink_mini_window): Rename Qresize_root_window to
7106 Qwindow_resize_root_window and Qresize_root_window_vertically to
7107 Qwindow_resize_root_window_vertically.
7108
f13e0b08
PE
71092011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7110
7111 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7112
94515237
JB
71132011-06-27 Juanma Barranquero <lekktu@gmail.com>
7114
7115 * makefile.w32-in: Redesign dependencies so they reflect more
7116 clearly which files are directly included by each source file,
7117 and not through other includes.
7118
e43b6e43
MR
71192011-06-27 Martin Rudalics <rudalics@gmx.at>
7120
7121 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7122 (sort_overlays, overlay_strings): When an overlay's clone number
7123 matches the window's clone number process the overlay even if
7124 the overlay's window property doesn't match the current window.
7125
d68443dc
MR
7126 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7127 (Fwindow_hchild): Rename to Fwindow_left_child.
7128 (Fwindow_next): Rename to Fwindow_next_sibling.
7129 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7130 (resize_window_check): Rename to window_resize_check.
7131 (resize_window_apply): Rename to window_resize_apply.
7132 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7133 (Fdelete_other_windows_internal, resize_frame_windows)
7134 (Fsplit_window_internal, Fdelete_window_internal)
7135 (grow_mini_window, shrink_mini_window)
7136 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7137
c7e73be5
JD
71382011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7139
7140 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7141 (emacs_fixed_set_min_size): Remove.
7142 (emacs_fixed_new): Take frame as argument.
7143
7144 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7145 (_EmacsFixedPrivate): Remove minwidth/height.
7146 Add struct frame *f.
7147 (emacs_fixed_init): Initialize priv->f.
7148 (get_parent_class, emacs_fixed_set_min_size): Remove.
7149 (emacs_fixed_new): Set priv->f to argument.
7150 (emacs_fixed_get_preferred_width)
7151 (emacs_fixed_get_preferred_height): Use min_width/height from
7152 frames size_hint to set minimum and natural (Bug#8919).
7153 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7154 and use min_width/height from frames size_hint to set
7155 min_width/height (Bug#8919).
7156
7157 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7158 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7159 Fix indentation.
c7e73be5 7160
cf99dcf8
EZ
71612011-06-26 Eli Zaretskii <eliz@gnu.org>
7162
7163 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7164 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7165 called at ZV.
7166
029529ac
CY
71672011-06-26 Chong Yidong <cyd@stupidchicken.com>
7168
7169 * process.c (wait_reading_process_output): Bypass select if
7170 waiting for a cell while ignoring keyboard input, and input is
7171 pending. Suggested by Jan Djärv (Bug#8869).
7172
7a7ef429
PE
71732011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7174
7175 Use gnulib's dup2 module instead of rolling our own.
7176 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7177
11fdef7d 71782011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7179
7180 * dispnew.c (scrolling_window): Before scrolling, turn off a
7181 mouse-highlight in the window being scrolled.
7182
cd3520a4
JB
71832011-06-24 Juanma Barranquero <lekktu@gmail.com>
7184
7185 Move DEFSYM to lisp.h and use everywhere.
7186
7187 * character.h (DEFSYM): Move declaration...
7188 * lisp.h (DEFSYM): ...here.
7189
7190 * gnutls.c:
7191 * minibuf.c:
7192 * w32menu.c:
7193 * w32proc.c:
7194 * w32select.c: Don't include character.h.
7195
7196 * alloc.c (syms_of_alloc):
7197 * buffer.c (syms_of_buffer):
7198 * bytecode.c (syms_of_bytecode):
7199 * callint.c (syms_of_callint):
7200 * casefiddle.c (syms_of_casefiddle):
7201 * casetab.c (init_casetab_once):
7202 * category.c (init_category_once, syms_of_category):
7203 * ccl.c (syms_of_ccl):
7204 * cmds.c (syms_of_cmds):
7205 * composite.c (syms_of_composite):
7206 * dbusbind.c (syms_of_dbusbind):
7207 * dired.c (syms_of_dired):
7208 * dispnew.c (syms_of_display):
7209 * doc.c (syms_of_doc):
7210 * editfns.c (syms_of_editfns):
7211 * emacs.c (syms_of_emacs):
7212 * eval.c (syms_of_eval):
7213 * fileio.c (syms_of_fileio):
7214 * fns.c (syms_of_fns):
7215 * frame.c (syms_of_frame):
7216 * fringe.c (syms_of_fringe):
7217 * insdel.c (syms_of_insdel):
7218 * keymap.c (syms_of_keymap):
7219 * lread.c (init_obarray, syms_of_lread):
7220 * macros.c (syms_of_macros):
7221 * msdos.c (syms_of_msdos):
7222 * print.c (syms_of_print):
7223 * process.c (syms_of_process):
7224 * search.c (syms_of_search):
7225 * sound.c (syms_of_sound):
7226 * syntax.c (init_syntax_once, syms_of_syntax):
7227 * terminal.c (syms_of_terminal):
7228 * textprop.c (syms_of_textprop):
7229 * undo.c (syms_of_undo):
7230 * w32.c (globals_of_w32):
7231 * window.c (syms_of_window):
7232 * xdisp.c (syms_of_xdisp):
7233 * xfaces.c (syms_of_xfaces):
7234 * xfns.c (syms_of_xfns):
7235 * xmenu.c (syms_of_xmenu):
7236 * xsettings.c (syms_of_xsettings):
7237 * xterm.c (syms_of_xterm): Use DEFSYM.
7238
4228cf16
TZ
72392011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7240
cd3520a4 7241 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7242
7fcccf1e
PE
72432011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7244
7efb4e0e
PE
7245 Integer and buffer overflow fixes (Bug#8873).
7246
ff5844ad
PE
7247 * print.c (printchar, strout): Check for string overflow.
7248 (PRINTPREPARE, printchar, strout):
7249 Don't set size unless allocation succeeds.
7250
90532f02
PE
7251 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7252 for sizes. Check for string overflow more accurately.
7253 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7254
6d84508d
PE
7255 * macros.c: Integer and buffer overflow fixes.
7256 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7257 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7258 Use ptrdiff_t, not int, for sizes.
7259 Don't increment bufsize until after realloc succeeds.
7260 Check for size-calculation overflow.
7261 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7262
437b2cb4
PE
7263 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7264
8b9ac8b4
PE
7265 * lread.c: Integer overflow fixes.
7266 (read_integer): Radix is now EMACS_INT, not int,
7267 to improve quality of diagnostics for out-of-range radices.
7268 Calculate buffer size correctly for out-of-range radices.
7269 (read1): Check for integer overflow in radices, and in
7270 read-circle numbers.
82cb60d3
PE
7271 (read_escape): Avoid int overflow.
7272 (Fload, openp, read_buffer_size, read1)
7273 (substitute_object_recurse, read_vector, read_list, map_obarray):
7274 Use ptrdiff_t, not int, for sizes.
7275 (read1): Use EMACS_INT, not int, for sizes.
20270765 7276 Check for size overflow.
8b9ac8b4 7277
7fcccf1e
PE
7278 * image.c (cache_image): Check for size arithmetic overflow.
7279
bfbbd7e7
PE
7280 * lread.c: Integer overflow issues.
7281 (saved_doc_string_size, saved_doc_string_length)
7282 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7283 Now ptrdiff_t, not int.
7284 (read1): Don't assume doc string length fits in int. Check for
7285 out-of-range doc string lengths.
7286 (read_list): Don't assume file position fits in int.
39019e54 7287 (read_escape): Check for hex character overflow.
bfbbd7e7 7288
4e323265
LL
72892011-06-22 Leo Liu <sdl.web@gmail.com>
7290
7291 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7292 Move to minibuffer.el.
7293
85fece3e
PE
72942011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7295
20b84ce9 7296 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7297 The following patches are for when GLYPH_DEBUG && !XASSERT.
7298 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7299 * dispnew.c (flush_stdout):
7300 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7301 Mark as externally visible.
7302 * dispnew.c (check_window_matrix_pointers): Now static.
7303 * dispnew.c (window_to_frame_vpos):
7304 * xfns.c (unwind_create_frame):
7305 * xterm.c (x_check_font): Remove unused local.
7306 * scroll.c (CHECK_BOUNDS):
7307 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7308 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7309 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7310 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7311 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7312 Now static.
7313 (debug_method_add): Use va_list and vsprintf rather than relying
7314 on undefined behavior with wrong number of arguments.
7315 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7316 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7317 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7318 since we're not interested in debugging glyphs with old libraries.
7319 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7320 GCC 4.6.0's static checking.
7321
0766b489
PE
73222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7323
31fd4b32
PE
7324 Integer overflow and signedness fixes (Bug#8873).
7325 A few related buffer overrun fixes, too.
7326
b79e8648
PE
7327 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7328
0766b489
PE
7329 * dispextern.h (struct face.stipple):
7330 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7331 (x_bitmap_mask, x_allocate_bitmap_record)
7332 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7333 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7334 (x_create_bitmap_from_xpm_data):
7335 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7336 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7337 (.bitmaps_last):
7338 * xfaces.c (load_pixmap):
7339 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7340 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7341 (.bitmaps_last, struct x_output.icon_bitmap):
7342 Use ptrdiff_t, not int, for bitmap indexes.
7343 (x_allocate_bitmap_record): Check for size overflow.
7344 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7345
b081724f
PE
7346 Use ptrdiff_t, not int, for overlay counts.
7347 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7348 * editfns.c (overlays_around, get_pos_property):
7349 * textprop.c (get_char_property_and_overlay):
7350 * xdisp.c (next_overlay_change, note_mouse_highlight):
7351 * xfaces.c (face_at_buffer_position):
21514da7
PE
7352 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7353 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7354 (Fnext_overlay_change, Fprevious_overlay_change)
7355 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7356 Use ptrdiff_t, not int, for sizes.
21514da7 7357 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7358
3de73e5e
PE
7359 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7360
2606c57b
PE
7361 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7362 (x_session_initialize): Do not assume string length fits in int.
7363
aaafe47a
PE
7364 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7365 This is unlikely, but can occur if DPI is outlandish.
7366
2674ddc8 7367 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7368 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7369
28154962
PE
7370 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7371 * xrdb.c (magic_file_p, search_magic_path):
7372 Omit last arg SUFFIX; it was always 0. All callers changed.
7373 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7374
7de51af5
PE
7375 * xfont.c (xfont_match): Avoid need for strlen.
7376
25ed6cc3
PE
7377 * xfns.c: Don't assume strlen fits in int.
7378 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7379
4eab31dd
PE
7380 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7381 not unsigned long, as we prefer signed integers. All callers changed.
7382 Detect integer overflow in repeat count.
7383 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7384 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7385
171e2a58
PE
7386 * termcap.c: Don't assume sizes fit in int and never overflow.
7387 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7388 (gobble_line): Check for size-calculation overflow.
7389
ad39faca 7390 * minibuf.c (Fread_buffer):
6e5bb2dc 7391 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7392 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7393 Don't assume string length fits in int.
7394
52c61c22 7395 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7396 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7397
b5b8c9e5
PE
7398 * font.c: Don't assume string length fits in int.
7399 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7400 Use ptrdiff_t, not int.
ccd6111c
PE
7401 (font_intern_prop): Don't assume string length fits in int.
7402 Don't assume integer property fits in fixnum.
7403 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7404
882f0d81 7405 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7406 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7407 Reformulate so as not to need the command string.
7408 Invoke gzip -cd rather than gunzip, as it's more portable.
7409 (lock_info_type, lock_file_1, lock_file):
7410 Don't assume pid_t and time_t fit in unsigned long.
7411 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7412 (current_lock_owner): Prefer signed type for sizes.
7413 Use memcpy, not strncpy, where memcpy is what is really wanted.
7414 Don't assume (via atoi) that time_t and pid_t fit in int.
7415 Check for time_t and/or pid_t out of range, e.g., via a network share.
7416 Don't alloca where an auto var works fine.
7417
93f4cf88
PE
7418 * fileio.c: Fix some integer overflow issues.
7419 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7420 Don't assume string length fits in int.
7421 (directory_file_name): Don't assume string length fits in long.
7422 (make_temp_name): Don't assume pid fits in int, or that its print
7423 length is less than 20.
7424
f3e92b69
PE
7425 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7426
1bfdaf10
PE
7427 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7428
35016e9a
PE
7429 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7430
3d1e65a1
PE
7431 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7432 We prefer signed integers, even for size calculations.
7433
0b963a93
PE
7434 * emacs.c: Don't assume string length fits in 'int'.
7435 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7436 (main): Don't invoke strlen when not needed.
7437
573f4b54
PE
7438 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7439 (XD_DEBUG_MESSAGE): Don't waste a byte.
7440
989f33ba
PE
7441 * callproc.c (getenv_internal_1, getenv_internal)
7442 (Fgetenv_internal):
965d34eb
PE
7443 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7444
e4d29b33
PE
7445 * lread.c (invalid_syntax): Omit length argument.
7446 All uses changed. This doesn't fix a bug, but it simplifies the
7447 code away from its former Hollerith-constant appearance, and it's
7448 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7449 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7450
eb49b136
PE
7451 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7452 This didn't break anything, but it didn't help either.
7453 It's confusing to put a bogus integer in a place where the actual
7454 value does not matter.
9f62aeb1 7455 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7456 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7457
15375a22
PE
7458 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7459 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7460 implementation.
b61cc01c
PE
7461 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7462 We prefer signed types, and the value cannot exceed the EMACS_INT
7463 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7464 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7465 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7466 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7467
53b2623d
PE
7468 * indent.c (sane_tab_width): New function.
7469 (current_column, scan_for_column, Findent_to, position_indentation)
7470 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7471 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7472
51cab52b 7473 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7474
f2ed8a70
PE
7475 * lisp.h (lint_assume): New macro.
7476 * composite.c (composition_gstring_put_cache):
7477 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7478
abe80cc6
PE
7479 * editfns.c, insdel.c:
7480 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7481
b02c740e
PE
7482 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7483
ebc96716
PE
7484 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7485
b4e50fa0 7486 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7487 Use much-faster test for byte-length change.
311d5d7c 7488 Don't assume string byte-length fits in 'int'.
a4cf38e4 7489 Check that character arg fits in 'int'.
85461888 7490 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7491
c0c1ee9f
PE
7492 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7493
a498d7f4
PE
7494 * fns.c (concat): Catch string overflow earlier.
7495 Do not rely on integer wraparound.
7496
51cab52b
PE
7497 * dispextern.h (struct it.overlay_strings_charpos)
7498 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7499 * xdisp.c (forward_to_next_line_start)
7500 (back_to_previous_visible_line_start)
7501 (reseat_at_next_visible_line_start, next_element_from_buffer):
7502 Don't arbitrarily truncate the value of 'selective' to int.
7503
76031fad
PE
7504 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7505
5eb55db9
PE
7506 * composite.c: Don't truncate sizes to 'int'.
7507 (composition_gstring_p, composition_reseat_it)
7508 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7509 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7510 not EMACS_UINT, for indexes.
5eb55db9 7511
0703a717
PE
7512 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7513
d6202519
PE
7514 * buffer.c: Include <verify.h>.
7515 (struct sortvec.priority, struct sortstr.priority):
8961a454 7516 Now EMACS_INT, not int.
c20998a7 7517 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7518 (struct sortstr.size, record_overlay_string)
7519 (struct sortstrlist.size, struct sortlist.used):
7520 Don't truncate size to int.
7521 (record_overlay_string): Check for size-calculation overflow.
d6202519 7522 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7523
d5a19415
JM
75242011-06-22 Jim Meyering <meyering@redhat.com>
7525
029529ac 7526 Don't leak an XBM-image-sized buffer
d5a19415
JM
7527 * image.c (xbm_load): Free the image buffer after using it.
7528
a9041e6c
PE
75292011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7530
7531 Port to Sun C.
7532 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7533 that Sun C diagnosed.
7534 * fns.c (secure_hash): Fix pointer signedness issue.
7535 * intervals.c (static_offset_intervals): New function.
7536 (offset_intervals): Use it.
7537
7f3f739f
LL
75382011-06-21 Leo Liu <sdl.web@gmail.com>
7539
7540 * deps.mk (fns.o):
7541 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7542 sha512.h.
7543
7544 * fns.c (secure_hash): Rename from crypto_hash_function and change
7545 the first arg to accept symbols.
5b66d427 7546 (Fsecure_hash): New primitive.
7f3f739f
LL
7547 (syms_of_fns): New symbols.
7548
76147d94
DD
75492011-06-20 Deniz Dogan <deniz@dogan.se>
7550
7551 * process.c (Fset_process_buffer): Clarify return value in
7552 docstring.
7553
7d7d0045
CY
75542011-06-18 Chong Yidong <cyd@stupidchicken.com>
7555
7556 * dispnew.c (add_window_display_history): Use BVAR.
7557
7558 * xdisp.c (debug_method_add): Use BVAR.
7559 (check_window_end, dump_glyph_matrix, dump_glyph)
7560 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7561
7562 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7563 Likewise.
7564
7565 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7566 check till after the cache is created in init_frame_faces.
7567
ff2bc410
SM
75682011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7569
7570 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7571
28177add
PE
75722011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7573
dd3482fe
PE
7574 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7575 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7576 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7577
393d71f3 7578 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7579 * fileio.c (Finsert_file_contents):
7580 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7581 Remove the old (too-loose) buffer overflow checks.
7582 They weren't needed, since make_gap checks for buffer overflow.
7583 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7584 The old code merely checked for Emacs fixnum overflow, and relied
7585 on undefined (wraparound) behavior. The new code avoids undefined
7586 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7587
2e6813b0 7588 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7589 Tune. Don't use wider integers than needed. Don't use alloca.
7590 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7591
599a9e4f
PE
7592 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7593
99561444
PE
7594 * insdel.c, lisp.h (buffer_overflow): New function.
7595 (insert_from_buffer_1, replace_range, replace_range_2):
7596 * insdel.c (make_gap_larger):
7597 * editfns.c (Finsert_char):
7598 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7599
28177add
PE
7600 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7601
e69dafad
PE
76022011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7603
4baa020d 7604 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7605
b1c46f02
PE
7606 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7607 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7608
e69dafad
PE
7609 * fileio.c: Don't assume EMACS_INT fits in off_t.
7610 (emacs_lseek): New static function.
7611 (Finsert_file_contents, Fwrite_region): Use it.
7612 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7613
566684ea
PE
7614 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7615
e6966cd6
PE
7616 * fns.c: Don't overflow int when computing a list length.
7617 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7618 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7619 truncation on 64-bit hosts. Check for QUIT every
7620 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7621 faster and is responsive enough.
7622 (Flength): Report an error instead of overflowing an integer.
7623 (Fsafe_length): Return a float if the value is not representable
7624 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7625 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7626 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7627
dd0b0efb
PE
7628 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7629 (header_size, word_size): New constants.
7630 (allocate_vectorlike): Don't check size overflow here.
7631 (allocate_vector): Check it here instead, since this is the only
7632 caller of allocate_vectorlike that could cause overflow.
7633 Check that the new vector's length is representable as a fixnum.
7634
86fe5cfe
PE
7635 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7636 The previous code was bogus. For example, next_almost_prime (32)
7637 returned 39, which is undesirable as it is a multiple of 3; and
7638 next_almost_prime (24) returned 25, which is a multiple of 5 so
7639 why was the code bothering to check for multiples of 7?
7640
80e88859
PE
7641 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7642
4a2f0ad6
PE
7643 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7644
f66c7cf8
PE
7645 Variadic C functions now count arguments with ptrdiff_t.
7646 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7647 Back then I didn't know that the Emacs coding style prefers signed int.
7648 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7649 were being counted with int, which may truncate counts on 64-bit
7650 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7651 * lisp.h (struct Lisp_Subr.function.aMANY)
7652 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7653 Arg counts are now ptrdiff_t, not size_t.
7654 All variadic functions and their callers changed accordingly.
7655 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7656 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7657 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7658 * callint.c (Fcall_interactively): Check arg count for overflow,
7659 to avoid potential buffer overrun. Use signed char, not 'int',
7660 for 'varies' array, so that we needn't bother to check its size
7661 calculation for overflow.
7662 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7663 * eval.c (apply_lambda):
7664 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7665 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7666 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7667
a1759b76
PE
7668 * callint.c (Fcall_interactively): Don't use index var as event count.
7669
d96be9fc
PE
7670 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7671 * mem-limits.h (SIZE): Remove; no longer used.
7672
a690a978 7673 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7674
578c21e6
PE
7675 Remove unnecessary casts.
7676 * xterm.c (x_term_init):
7677 * xfns.c (x_set_border_pixel):
7678 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7679 These aren't needed now that we assume ANSI C.
7680
96f53c6c
PE
7681 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7682 It's more likely to cause problems (due to unsigned overflow)
7683 than to cure them.
7684
83c77d31
PE
7685 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7686
ee2079f1
PE
7687 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7688
6da65536
PE
7689 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7690
7147c4a4
PE
7691 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7692
193e32d9
PE
7693 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7694
e5533da6
PE
7695 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7696
9910e595
PE
7697 GLYPH_CODE_FACE returns EMACS_INT, not int.
7698 * dispextern.h (merge_faces):
7699 * xfaces.c (merge_faces):
01103c44
PE
7700 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7701 Don't assume EMACS_INT fits in int.
9910e595 7702
2638320e
PE
7703 * character.h (CHAR_VALID_P): Remove unused parameter.
7704 * fontset.c, lisp.h, xdisp.c: All uses changed.
7705
045eb8d9
PE
7706 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7707
c1f134b5
PE
7708 * fns.c (concat): Minor tuning based on overflow analysis.
7709 This doesn't fix any bugs. Use int to hold character, instead
7710 of constantly refetching from Emacs object. Use XFASTINT, not
7711 XINT, for value known to be a character. Don't bother comparing
7712 a single byte to 0400, as it's always less.
7713
395fcb93 7714 * floatfns.c (Fexpt):
327eeec8
PE
7715 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7716
abbd3d23
PE
7717 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7718 for characters.
7719
684a03ef
PE
7720 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7721
0fed43f3
PE
7722 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7723 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7724 incorrectly succeed when S was a string, because 4294967386 was
7725 truncated before it was used.
7726
8fd02eb7
PE
7727 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7728 Otherwise, an out-of-range integer could cause undefined behavior
7729 on a 64-bit host.
7730
f8c86b69
PE
7731 * composite.c: Use int, not EMACS_INT, for characters.
7732 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7733 EMACS_INT, for values that are known to be in character range.
7734 This doesn't fix any bugs but is the usual style inside Emacs and
7735 may generate better code on 32-bit machines.
7736
34206dd2
PE
7737 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7738 This is for reasons similar to the recent CHAR_STRING fix.
7739 * charset.c (Fencode_char): Check that character arg is actually
7740 a character. Pass an int to ENCODE_CHAR.
7741 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7742 wider than 'int', as a compile-time check to prevent future regressions
7743 in this area.
7744
c5958d4c 7745 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7746
7747 Make sure a 64-bit char is never passed to CHAR_STRING.
7748 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7749 by silently ignoring the top 32 bits, allowing some values
7750 that were far too large to be valid characters.
7751 * character.h: Include <verify.h>.
7752 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7753 arguments are no wider than unsigned, as a compile-time check
7754 to prevent future regressions in this area.
7755 * data.c (Faset):
01103c44 7756 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7757 (Fsubst_char_in_region):
7758 * fns.c (concat):
7759 * xdisp.c (decode_mode_spec_coding):
7760 Adjust to CHAR_STRING's new requirement.
7761 * editfns.c (Finsert_char, Fsubst_char_in_region):
7762 * fns.c (concat): Check that character args are actually
7763 characters. Without this test, these functions did the wrong
7764 thing with wildly out-of-range values on 64-bit hosts.
7765
d37ca623
PE
7766 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7767 These casts should not be needed on 32-bit hosts, either.
7768 * keyboard.c (read_char):
7769 * lread.c (Fload): Remove casts to unsigned.
7770
ea204efb
PE
7771 * lisp.h (UNSIGNED_CMP): New macro.
7772 This fixes comparison bugs on 64-bit hosts.
7773 (ASCII_CHAR_P): Use it.
7774 * casefiddle.c (casify_object):
01103c44 7775 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7776 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7777 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7778 * dispextern.h (FACE_FROM_ID):
7779 * keyboard.c (read_char): Use UNSIGNED_CMP.
7780
41cb286c
PE
7781 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7782 not to EMACS_INT, to avoid GCC warning.
7783
4a1b9832
PE
7784 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7785
55daad71
PE
7786 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7787 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7788 isn't needed on 32-bit machines.
8f95c75c 7789
01103c44
PE
7790 * buffer.c (Fgenerate_new_buffer_name):
7791 Use EMACS_INT for count, not int.
0ceccced 7792 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7793
7794 * data.c (Qcompiled_function): Now static.
7795
c6f072e7
PE
7796 * window.c (window_body_lines): Now static.
7797
20ce5912
PE
7798 * image.c (gif_load): Rename local to avoid shadowing.
7799
9c4c5f81
PE
7800 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7801 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7802 * alloc.c (make_save_value): Integer argument is now of type
7803 ptrdiff_t, not int.
7804 (mark_object): Use ptrdiff_t, not int.
7805 * lisp.h (pD): New macro.
7806 * print.c (print_object): Use it.
7807
c0c5c8ae
PE
7808 * alloc.c: Use EMACS_INT, not int, to count objects.
7809 (total_conses, total_markers, total_symbols, total_vector_size)
7810 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7811 (total_free_floats, total_floats, total_free_intervals)
7812 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7813 Now EMACS_INT, not int. All uses changed.
7814 (Fgarbage_collect): Compute overall total using a double, so that
7815 integer overflow is less likely to be a problem. Check for overflow
7816 when converting back to an integer.
5a25e253
PE
7817 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7818 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7819 These were 'int' variables that could overflow on 64-bit hosts;
7820 they were never used, so remove them instead of repairing them.
211a0b2a 7821 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7822 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7823 Previously, this ceilinged at INT_MAX, but that doesn't work on
7824 64-bit machines.
e46bb31a 7825 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7826
c78baabf 7827 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7828 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7829 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7830 when a (possibly-narrower) signed value would do just as well.
7831 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7832
c9d624c6
PE
7833 * alloc.c: Catch some string size overflows that we were missing.
7834 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7835 for convenience in STRING_BYTES_MAX.
7836 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7837 The definition here is exact; the one in lisp.h was approximate.
7838 (allocate_string_data): Check for string overflow. This catches
7839 some instances we weren't catching before. Also, it catches
7840 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7841 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7842 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7843
c9d624c6
PE
7844 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7845 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7846 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7847
353032ce
PE
7848 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7849
2bccce07
PE
7850 * alloc.c (Fmake_string): Check for out-of-range init.
7851
0ac30604
SM
78522011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7853
7854 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7855
c195f2de
JD
78562011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7857
7858 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7859 xg_get_default_scrollbar_width.
7860
7861 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7862 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7863 (style_changed_cb): Call update_theme_scrollbar_width and call
7864 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7865 all frames (Bug#8505).
7866 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7867 Call gtk_window_set_resizable if HAVE_GTK3.
7868 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7869 and height if HAVE_GTK3 (Bug#8505).
7870 (scroll_bar_width_for_theme): New variable.
7871 (update_theme_scrollbar_width): New function.
7872 (xg_get_default_scrollbar_width): Move code to
7873 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7874 (xg_initialize): Call update_theme_scrollbar_width.
7875
7876 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7877
7878 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7879
e10ac9f1
MR
78802011-06-12 Martin Rudalics <rudalics@gmx.at>
7881
7882 * frame.c (make_frame): Call other_buffer_safely instead of
7883 other_buffer.
7884
7885 * window.c (temp_output_buffer_show): Call display_buffer with
7886 second argument Vtemp_buffer_show_specifiers and reset latter
7887 immediately after the call.
7888 (Vtemp_buffer_show_specifiers): New variable.
7889 (auto_window_vscroll_p, next_screen_context_lines)
7890 (Vscroll_preserve_screen_position): Remove leading asterisks from
7891 doc-strings.
7892
2d3c217e 78932011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7894
7b7f97e8 7895 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7896 * buffer.c (Qclone_number): Remove for now, as it's unused.
7897 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7898 (record_buffer): Remove unused local.
7899 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7900 (set_frame_buffer_list): Remove; unused.
7901 * frame.h (other_visible_frames): Remove decl.
7902 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7903 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7904 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7905 if HAVE_GPM.
7906 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7907 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7908 Define only if HAVE_GPM.
7909 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7910 (update_hints_inhibit): Remove; never set. All uses removed.
7911 * widgetprv.h (emacsFrameClassRec): Remove decl.
7912 * window.c (delete_deletable_window): Now returns void, since it
7913 wasn't returning anything.
7914 (compare_window_configurations): Remove unused locals.
7915 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7916 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7917 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7918 the same widths as pointers. This follows up on the 2011-05-06 patch.
7919 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7920 * xterm.h: Likewise.
7921 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7922
1384b89e
JB
79232011-06-12 Juanma Barranquero <lekktu@gmail.com>
7924
7925 * makefile.w32-in: Update dependencies.
7926 (LISP_H): Add lib/intprops.h.
7927
1100a63c
CY
79282011-06-11 Chong Yidong <cyd@stupidchicken.com>
7929
7930 * image.c (gif_load): Add animation frame delay to the metadata.
7931 (syms_of_image): Use DEFSYM. New symbol `delay'.
7932
6198ccd0
MR
79332011-06-11 Martin Rudalics <rudalics@gmx.at>
7934
7935 * window.c (delete_deletable_window): Re-add.
7936 (Fset_window_configuration): Rewrite to handle dead buffers and
7937 consequently deletable windows.
7938 (window_tree, Fwindow_tree): Remove. Supply functionality in
7939 window.el.
7940 (compare_window_configurations): Simplify code.
7941
b6e3633c
AS
79422011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7943
1ab0dee5
AS
7944 * image.c (imagemagick_load_image): Fix type mismatch.
7945 (Fimagemagick_types): Likewise.
7946
b6e3633c
AS
7947 * window.h (replace_buffer_in_windows): Declare.
7948
9397e56f
MR
79492011-06-11 Martin Rudalics <rudalics@gmx.at>
7950
7951 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7952 Qclone_number. Remove external declaration of Qdelete_window.
7953 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7954 code.
640c8776
SM
7955 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7956 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7957 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7958 buffer list implementation.
7959 (other_buffer_safely): New function.
7960 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7961 calls to replace_buffer_in_windows and
7962 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7963 if allowed.
7964 (record_buffer): Inhibit quitting and rewrite using quittable
7965 functions. Run Qbuffer_list_update_hook if allowed.
7966 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7967 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7968 Move switch-to-buffer to window.el.
9397e56f
MR
7969 (bury-buffer): Move to window.el.
7970 (Vbuffer_list_update_hook): New variable.
7971
7972 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7973 section.
7974
7975 * window.h (resize_frame_windows): Move up in code.
7976 (Fwindow_frame): Remove EXFUN.
7977 (replace_buffer_in_all_windows): Remove prototype.
7978 (replace_buffer_in_windows_safely): Add prototype.
7979
7980 * window.c: Declare Qdelete_window static again. Move down
7981 declaration of select_count.
7982 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7983 (Fother_window): Move to window.el.
7984 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7985 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7986 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7987 window.el.
7988 (replace_buffer_in_windows): Implement by calling
7989 Qreplace_buffer_in_windows.
7990 (replace_buffer_in_all_windows): Remove with some functionality
7991 moved into replace_buffer_in_windows_safely.
7992 (replace_buffer_in_windows_safely): New function.
7993 (select_window_norecord, select_frame_norecord): Move in front
7994 of run_window_configuration_change_hook. Remove now obsolete
7995 declarations.
640c8776
SM
7996 (Fset_window_buffer): Rewrite doc-string.
7997 Call Qrecord_window_buffer.
9397e56f
MR
7998 (keys_of_window): Move binding for other-window to window.el.
7999
b50691aa
CY
80002011-06-11 Chong Yidong <cyd@stupidchicken.com>
8001
8002 * dispextern.h (struct image): Replace data member, whose int_val
8003 and ptr_val fields were not used by anything, with a single
8004 lisp_val object.
8005
8006 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8007 (gif_clear_image, gif_load, imagemagick_load_image)
8008 (gs_clear_image, gs_load): Callers changed.
8009
3f754b86
PE
80102011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8011
cca69397
PE
8012 * buffer.h: Include <time.h>, for time_t.
8013 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8014
109e28d0
PE
8015 Fix minor problems found by static checking.
8016
60737f02
PE
8017 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8018
4b66faf3
PE
8019 Make identifiers static if they are not used in other modules.
8020 * data.c (Qcompiled_function, Qframe, Qvector):
8021 * image.c (QimageMagick, Qsvg):
8022 * minibuf.c (Qmetadata):
8023 * window.c (resize_window_check, resize_root_window): Now static.
8024 * window.h (resize_window_check, resize_root_window): Remove decls.
8025
109e28d0
PE
8026 * window.c (window_deletion_count, delete_deletable_window):
8027 Remove; unused.
46a4ce9e
PE
8028 (window_body_lines): Now static.
8029 (Fdelete_other_windows_internal): Mark vars as initialized.
8030 Make sure 'resize_failed' is initialized.
8031 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8032 (resize_window_apply): Remove unused local.
8033 * window.h (delete_deletable_window): Remove decl.
8034
109e28d0 8035 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8036 (imagemagick_load_image): Fix pointer signedness problem by changing
8037 last arg from unsigned char * to char *. All uses changed.
8038 Also, fix a local for similar reasons.
8039 Remove unused locals. Remove locals to avoid shadowing.
8040 (fn_rsvg_handle_free): Remove; unused.
8041 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8042 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8043
3f754b86
PE
8044 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8045
2547adb1
CY
80462011-06-10 Chong Yidong <cyd@stupidchicken.com>
8047
8048 * image.c (gif_load): Fix omitted cast error introduced by
8049 2011-06-06 change.
8050
2c8e37d4
MR
80512011-06-10 Martin Rudalics <rudalics@gmx.at>
8052
8053 * window.h (resize_proportionally, orig_total_lines)
8054 (orig_top_line): Remove from window structure.
8055 (set_window_height, set_window_width, change_window_heights)
8056 (Fdelete_window): Remove prototypes.
8057 (resize_frame_windows): Remove duplicate declaration.
8058
440a42e3
EZ
80592011-06-10 Eli Zaretskii <eliz@gnu.org>
8060
8061 * window.h (resize_frame_windows, resize_window_check)
8062 (delete_deletable_window, resize_root_window)
8063 (resize_frame_windows): Declare prototypes.
8064
8065 * window.c (resize_window_apply): Make definition be "static" to
8066 match the prototype.
8067
562dd5e9
MR
80682011-06-10 Martin Rudalics <rudalics@gmx.at>
8069
8070 * window.c: Remove declarations of Qwindow_size_fixed,
8071 window_min_size_1, window_min_size_2, window_min_size,
8072 size_window, window_fixed_size_p, enlarge_window, delete_window.
8073 Remove static from declaration of Qdelete_window, it's
8074 temporarily needed by Fbury_buffer.
8075 (replace_window): Don't assign orig_top_line and
8076 orig_total_lines.
8077 (Fdelete_window, delete_window): Remove. Window deletion is
8078 handled by window.el.
640c8776
SM
8079 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8080 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8081 (Fdelete_other_windows): Remove. Deleting other windows is
8082 handled by window.el.
8083 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8084 handled in window.el.
8085 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8086 Window minimum sizes are handled in window.el.
8087 (shrink_windows, size_window, set_window_height)
8088 (set_window_width, change_window_heights, window_height)
8089 (window_width, CURBEG, CURSIZE, enlarge_window)
8090 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8091 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8092 handled in window.el.
8093 (make_dummy_parent): Rename to make_parent_window and give it a
8094 second argument horflag.
8095 (make_window): Don't set resize_proportionally any more.
8096 (Fsplit_window): Remove. Windows are split in window.el.
8097 (save_restore_action, save_restore_orig_size)
8098 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8099 Resize mini windows in window.el.
8100 (grow_mini_window, shrink_mini_window): Implement by calling
8101 Qresize_root_window_vertically, resize_window_check and
8102 resize_window_apply.
640c8776
SM
8103 (saved_window, Fset_window_configuration, save_window_save):
8104 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8105 resize_proportionally.
8106 (window_min_height, window_min_width): Move to window.el.
8107 (keys_of_window): Move bindings for delete-other-windows,
8108 split-window, delete-window and enlarge-window to window.el.
8109
8110 * buffer.c: Temporarily extern Qdelete_window.
8111 (Fbury_buffer): Temporarily call Qdelete_window instead of
8112 Fdelete_window (Fbury_buffer will move to window.el soon).
8113
8114 * frame.c (set_menu_bar_lines_1): Remove code handling
8115 orig_top_line and orig_total_lines.
8116
8117 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8118 set_window_height but set heights directly.
8119 (change_frame_size_1): Use resize_frame_windows.
8120
8121 * xdisp.c (init_xdisp): Don't use set_window_height but set
8122 heights directly.
8123
640c8776
SM
8124 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8125 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8126 run_window_configuration_change_hook.
8127
8128 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8129 instead of change_window_heights and run
8130 run_window_configuration_change_hook.
8131
1a13852e
MR
81322011-06-09 Martin Rudalics <rudalics@gmx.at>
8133
8134 * window.c (replace_window): Rename second argument REPLACEMENT to
8135 NEW. New third argument SETFLAG. Rewrite.
8136 (delete_window, make_dummy_parent): Call replace_window with
8137 third argument 1.
8138 (window_list_1): Move down in code.
8139 (run_window_configuration_change_hook): Move set_buffer part
8140 before select_frame_norecord part in order to unwind correctly.
8141 Rename count1 to count.
8142 (recombine_windows, delete_deletable_window, resize_root_window)
8143 (Fdelete_other_windows_internal)
8144 (Frun_window_configuration_change_hook, make_parent_window)
8145 (resize_window_check, resize_window_apply, Fresize_window_apply)
8146 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8147 (Fdelete_window_internal, Fresize_mini_window_internal):
8148 New functions.
1a13852e
MR
8149 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8150
f3d1777e
MR
81512011-06-08 Martin Rudalics <rudalics@gmx.at>
8152
496e208e
MR
8153 * window.h (window): Add some new members to window structure -
8154 normal_lines, normal_cols, new_total, new_normal, clone_number,
8155 splits, nest, prev_buffers, next_buffers.
8156 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8157 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8158
f3d1777e
MR
8159 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8160 Remove.
496e208e
MR
8161 (make_dummy_parent): Set new members of windows structure.
8162 (make_window): Move down in code. Handle new members of window
8163 structure.
8164 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8165 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8166 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8167 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8168 (Fset_window_next_buffers, Fset_window_clone_number):
8169 New functions.
496e208e
MR
8170 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8171 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8172 Doc-string fixes.
8173 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8174 Argument WINDOW can be now internal window too.
8175 (Fwindow_use_time): Move up in code.
8176 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8177 Rewrite doc-string.
8178 (Fset_window_configuration, saved_window)
8179 (Fcurrent_window_configuration, save_window_save): Handle new
8180 members of window structure.
b9e809c2
MR
8181 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8182 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8183 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8184 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8185 Qget_mru_window, Qresize_root_window,
8186 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8187 Qauto_buffer_name; staticpro them.
f3d1777e 8188
abde8f8c
MR
81892011-06-07 Martin Rudalics <rudalics@gmx.at>
8190
8191 * window.c (Fwindow_total_size, Fwindow_left_column)
8192 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8193 (Fwindow_list_1): New functions.
8194 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8195 (Fwindow_width, Fscroll_left, Fscroll_right):
8196 Use window_body_cols instead of window_box_text_cols.
8197 (delete_window, Fset_window_configuration):
8198 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8199 (delete_all_subwindows): Take a window as argument and not a
8200 structure. Rewrite.
190b47e6
MR
8201 (window_loop): Remove handling of GET_LRU_WINDOW and
8202 GET_LARGEST_WINDOW.
8203 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8204
8205 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8206 window_box_text_cols. delete_all_subwindows now takes a
8207 Lisp_Object as argument.
abde8f8c 8208
640c8776
SM
8209 * indent.c (compute_motion, Fcompute_motion):
8210 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8211
fa8a67e6
MR
8212 * frame.c (delete_frame): Call delete_all_subwindows with root
8213 window as argument.
8214
a54e3482
DC
82152011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8216
8217 * fns.c (Fputhash): Document return value.
8218
60002bf5
CY
82192011-06-06 Chong Yidong <cyd@stupidchicken.com>
8220
8221 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8222
0c671da6 82232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8224
b862a52a 8225 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8226
be44ca6c
PE
8227 Check for overflow when converting integer to cons and back.
8228 * charset.c (Fdefine_charset_internal, Fdecode_char):
8229 Use cons_to_unsigned to catch overflow.
8230 (Fencode_char): Use INTEGER_TO_CONS.
8231 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8232 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8233 * data.c (long_to_cons, cons_to_long): Remove.
8234 (cons_to_unsigned, cons_to_signed): New functions.
8235 These signal an error for invalid or out-of-range values.
8236 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8237 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8238 * font.c (Ffont_variation_glyphs):
8239 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8240 * lisp.h: Include <intprops.h>.
8241 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8242 (cons_to_signed, cons_to_unsigned): New decls.
8243 (long_to_cons, cons_to_long): Remove decls.
8244 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8245 (Fprimitive_undo): Use CONS_TO_INTEGER.
8246 * xfns.c (Fx_window_property): Likewise.
8247 * xselect.c: Include <limits.h>.
8248 (x_own_selection, selection_data_to_lisp_data):
8249 Use INTEGER_TO_CONS.
8250 (x_handle_selection_request, x_handle_selection_clear)
8251 (x_get_foreign_selection, Fx_disown_selection_internal)
8252 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8253 (lisp_data_to_selection_data): Use cons_to_unsigned.
8254 (x_fill_property_data): Use cons_to_signed.
8255 Report values out of range.
8256
d1f3d2af
PE
8257 Check for buffer and string overflow more precisely.
8258 * buffer.h (BUF_BYTES_MAX): New macro.
8259 * lisp.h (STRING_BYTES_MAX): New macro.
8260 * alloc.c (Fmake_string):
8261 * character.c (string_escape_byte8):
8262 * coding.c (coding_alloc_by_realloc):
8263 * doprnt.c (doprnt):
8264 * editfns.c (Fformat):
8265 * eval.c (verror):
8266 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8267 since they may not be the same number.
8268 * editfns.c (Finsert_char):
8269 * fileio.c (Finsert_file_contents):
8270 Likewise for BUF_BYTES_MAX.
8271
dd52fcea
PE
8272 * image.c: Use ptrdiff_t, not int, for sizes.
8273 (slurp_file): Switch from int to ptrdiff_t.
8274 All uses changed.
8275 (slurp_file): Check that file size fits in both size_t (for
8276 malloc) and ptrdiff_t (for sanity and safety).
8277
7f9bbdbb
PE
8278 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8279 if b->modtime has its maximal value.
8280
dfe18f82
PE
8281 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8282
84acfcf0
PE
8283 Don't assume time_t can fit into int.
8284 * buffer.h (struct buffer.modtime): Now time_t, not int.
8285 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8286 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8287
ccd9a01a
PE
8288 Minor fixes for signed vs unsigned integers.
8289 * character.h (MAYBE_UNIFY_CHAR):
8290 * charset.c (maybe_unify_char):
8291 * keyboard.c (read_char, reorder_modifiers):
8292 XINT -> XFASTINT, since the integer must be nonnegative.
8293 * ftfont.c (ftfont_spec_pattern):
8294 * keymap.c (access_keymap, silly_event_symbol_error):
8295 XUINT -> XFASTINT, since the integer must be nonnegative.
8296 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8297 since it makes no difference and we prefer signed.
8298 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8299 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8300 nonnegative.
8301
d6d100dd
SM
83022011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8303
8304 * window.h (Fwindow_frame): Declare.
8305
2b6148e4
PE
83062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8307
8308 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8309 (SPARE_MEMORY): Always define.
8310 (LARGE_REQUEST): Remove.
8311 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8312
f230ecc9
MR
83132011-06-06 Martin Rudalics <rudalics@gmx.at>
8314
727e958e
MR
8315 * lisp.h: Move EXFUNS for Fframe_root_window,
8316 Fframe_first_window and Fset_frame_selected_window to window.h.
8317
8318 * window.h: Move EXFUNS for Fframe_root_window,
8319 Fframe_first_window and Fset_frame_selected_window here from
8320 lisp.h.
8321
8322 * frame.c (Fwindow_frame, Fframe_first_window)
8323 (Fframe_root_window, Fframe_selected_window)
8324 (Fset_frame_selected_window): Move to window.c.
8325 (Factive_minibuffer_window): Move to minibuf.c.
8326 (Fother_visible_frames_p): New function.
8327
8328 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8329
f230ecc9
MR
8330 * window.c (decode_window, decode_any_window): Move up in code.
8331 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8332 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8333 (Fwindow_buffer): Move up and rewrite doc-string.
8334 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8335 (Fwindow_prev): New functions.
727e958e
MR
8336 (Fwindow_frame): Move here from frame.c. Accept any window as
8337 argument.
8338 (Fframe_root_window, Fframe_first_window)
8339 (Fframe_selected_window): Move here from frame.c. Accept frame
8340 or arbitrary window as argument. Update doc-strings.
8341 (Fminibuffer_window): Move up in code.
8342 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8343 (Fset_frame_selected_window): Move here from frame.c.
8344 Marginal rewrite.
727e958e
MR
8345 (Fselected_window, select_window, Fselect_window): Move up in
8346 code. Minor doc-string fixes.
f230ecc9 8347
4d09bcf6
PE
83482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8349
8350 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8351 Do not assume that spare memory exists; that assumption is valid
8352 only if SYSTEM_MALLOC.
8353 (LARGE_REQUEST): New macro, so that the issue of large requests
8354 is separated from the issue of spare memory.
8355
810928a2
AS
83562011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8357
172418ad
AS
8358 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8359 format. (Bug#8806)
8360
43f862f7
AS
8361 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8362
810928a2
AS
8363 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8364 before statements.
8365
a059fe24
JD
83662011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8367
8368 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8369
8370 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8371
8372 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8373 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8374
989bf368
JB
83752011-06-05 Juanma Barranquero <lekktu@gmail.com>
8376
8377 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8378
4b80f674
CY
83792011-06-04 Chong Yidong <cyd@stupidchicken.com>
8380
8381 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8382 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8383 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8384 New error handlers.
4b80f674
CY
8385 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8386 Obey Vx_select_enable_clipboard_manager. Catch errors in
8387 x_clipboard_manager_save (Bug#8779).
8388 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8389 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8390
99a33b77 83912011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8392
8393 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8394
99a33b77 83952011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8396
8397 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8398 in the current matrix if keep_current_p is non-zero.
8399
8264569d
EZ
84002011-06-04 Eli Zaretskii <eliz@gnu.org>
8401
8402 * bidi.c (bidi_level_of_next_char): Fix last change.
8403
57f97249
EZ
84042011-06-03 Eli Zaretskii <eliz@gnu.org>
8405
fec2107c 8406 Support bidi reordering of text covered by display properties.
57f97249 8407
fec2107c
EZ
8408 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8409 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8410 (bidi_cache_search, bidi_cache_iterator_state)
8411 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8412 (bidi_level_of_next_char, bidi_move_to_visually_next):
8413 Support character positions inside a run of characters covered by a
fec2107c
EZ
8414 display string.
8415 (bidi_paragraph_init, bidi_resolve_explicit_1)
8416 (bidi_level_of_next_char): Call bidi_fetch_char and
8417 bidi_fetch_char_advance instead of FETCH_CHAR and
8418 FETCH_CHAR_ADVANCE.
8419 (bidi_init_it): Initialize new members.
8420 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8421 definitions.
8422 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8423 instead of using explicit *_CHAR codes.
d6d100dd
SM
8424 (bidi_resolve_explicit, bidi_resolve_weak):
8425 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8426 bidirectional text is supported only in multibyte buffers.
8427 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8428 it to initialize the frame_window_p member of struct bidi_it.
8429 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8430 (bidi_resolve_explicit, bidi_resolve_weak)
8431 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8432 bidi_it->nchars is non-positive.
8433 (bidi_level_of_next_char): Don't try to lookup the cache for the
8434 next/previous character if nothing is cached there yet, or if we
8435 were just reseat()'ed to a new position.
c40e2fb2 8436
0e14fe90
EZ
8437 * xdisp.c (set_cursor_from_row): Set start and stop points
8438 according to the row's direction when priming the loop that looks
8439 for the glyph on which to display cursor.
8440 (single_display_spec_intangible_p): Function deleted.
8441 (display_prop_intangible_p): Reimplement to call
8442 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8443 Accept 3 additional arguments needed by handle_display_spec.
8444 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8445 values: lists, `(when COND...)' forms, etc.
8446 (single_display_spec_string_p): Support property values that are
8447 lists with the argument STRING its top-level element.
8448 (display_prop_string_p): Fix the condition for processing a
8449 property that is a list to be consistent with handle_display_spec.
fec2107c 8450 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8451 last portion of handle_display_prop.
8452 (compute_display_string_pos): Accept additional argument
8453 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8454 value of a `display' property is a "replacing spec".
8455 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8456 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8457 the display property, but just return a value indicating whether
8458 the display property will replace the characters it covers.
8459 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8460 frame_window_p members of struct bidi_it.
d6d100dd
SM
8461 (compute_display_string_pos, compute_display_string_end):
8462 New functions.
fec2107c
EZ
8463 (push_it): Accept second argument POSITION, where pop_it should
8464 jump to continue iteration.
8465 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8466
fec2107c
EZ
8467 * keyboard.c (adjust_point_for_property): Adjust the call to
8468 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8469
8470 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8471 (bidi_init_it): Update prototypes.
8472 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8473 (compute_display_string_pos, compute_display_string_end):
8474 Declare prototypes.
fec2107c
EZ
8475 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8476 EMACS_INT.
fc6f18ce 8477
40087514 84782011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8479
57f53182
PE
8480 Malloc failure behavior now depends on size of allocation.
8481 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8482 * lisp.h: Change signatures accordingly.
8483 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8484 All callers changed. (Bug#8762)
8485
8486 * gnutls.c: Use Emacs's memory allocators.
8487 Without this change, the gnutls library would invoke malloc etc.
8488 directly, which causes problems on non-SYNC_INPUT hosts, and which
8489 runs afoul of improving memory_full behavior. (Bug#8761)
8490 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8491 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8492 xfree instead of the default malloc, realloc, free.
8493 (Fgnutls_boot): No need to check for memory allocation failure,
8494 since xmalloc does that for us.
8495
ac32cd99 8496 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8497 * category.c (hash_get_category_set):
8498 * ccl.c (ccl_driver):
8499 * charset.c (Fdefine_charset_internal):
8500 * charset.h (struct charset.hash_index):
8501 * composite.c (get_composition_id, gstring_lookup_cache)
8502 (composition_gstring_put_cache):
8503 * composite.h (struct composition.hash_index):
8504 * dispextern.h (struct image.hash):
8505 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8506 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8507 (hashfn_equal, hashfn_user_defined, make_hash_table)
8508 (maybe_resize_hash_table, hash_lookup, hash_put)
8509 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8510 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8511 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8512 * image.c (make_image, search_image_cache, lookup_image)
8513 (xpm_put_color_table_h):
8514 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8515 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8516 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8517 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8518 * alloc.c (allocate_vectorlike):
8519 Check for overflow in vector size calculations.
8520 * ccl.c (ccl_driver):
8521 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8522 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8523 need to be updated by these changes.
40087514
PE
8524 * fns.c (make_hash_table, maybe_resize_hash_table):
8525 Check for integer overflow with large hash tables.
0de4bb68
PE
8526 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8527 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8528 (SXHASH_REDUCE): New macro.
8529 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8530 Use it instead of discarding useful hash info with large hash values.
8531 (sxhash_float): New function.
8532 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8533 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8534 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8535 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8536 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8537 Adjust signatures to match updated version of code.
8538 (consing_since_gc): Now EMACS_INT, since a single hash table can
8539 use more than INT_MAX bytes.
8540
698d32e2
DN
85412011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8542
8543 Make it possible to build with GCC-4.6+ -O2 -flto.
8544
8545 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8546
fd6fa53f
SM
85472011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8548
8549 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8550 Call minibuffer-inactive-mode.
8551
864db017
JB
85522011-05-31 Juanma Barranquero <lekktu@gmail.com>
8553
8554 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8555 Update dependencies.
8556
2ad0baf4
DN
85572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8558
8559 * data.c (init_data): Remove code for UTS, this system is not
8560 supported anymore.
8561
4fcc2638
DN
85622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8563
8564 Don't force ./temacs to start in terminal mode.
8565
8566 * frame.c (make_initial_frame): Initialize faces in all cases, not
8567 only when CANNOT_DUMP is defined.
8568 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8569
c56e0fd5
DN
85702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8571
8572 * dispnew.c (add_window_display_history): Use const for the string
8573 pointer. Remove declaration, not needed.
8574
333d54da 85752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8576
55d4c1b2 8577 Use 'inline', not 'INLINE'.
333d54da 8578 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8579 * alloc.c, fontset.c (INLINE): Remove.
8580 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8581 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8582 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8583 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8584 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8585
738db178
DN
85862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8587
8588 Make it possible to run ./temacs.
8589
8590 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8591 syms_of_callproc does the same thing. Remove test for
8592 "initialized", do it in the caller.
8593 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8594
620c53a6
SM
85952011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8596
8597 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8598 (read_minibuf): Use get_minibuffer.
8599 (syms_of_minibuf): Use DEFSYM.
8600 (Qmetadata): New var.
8601 * data.c (Qbuffer): Don't make it static.
8602 (syms_of_data): Use DEFSYM.
8603
e003a292
PE
86042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8605
8606 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8607 (CCL_CODE_MIN): New macro.
8608
ed008a6d
PE
86092011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8610
3687c2ef
PE
8611 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8612
ed008a6d
PE
8613 * eval.c (Qdebug): Now static.
8614 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8615 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8616 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8617
d66c4c7c
CY
86182011-05-29 Chong Yidong <cyd@stupidchicken.com>
8619
8620 * image.c: Various fixes to ImageMagick code comments.
8621 (Fimagemagick_types): Doc fix.
8622
5fbc2025
PE
86232011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8624
0196f88a
PE
8625 Minor fixes prompted by GCC 4.6.0 warnings.
8626
8627 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8628
5fbc2025
PE
8629 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8630 (x_clipboard_manager_save_all): Move extern decl to ...
8631 * xterm.h: ... here, so that it can be checked for consistency.
8632
1dd3c2d9
CY
86332011-05-29 Chong Yidong <cyd@stupidchicken.com>
8634
8635 * xselect.c (x_clipboard_manager_save_frame)
8636 (x_clipboard_manager_save_all): New functions.
8637 (Fx_clipboard_manager_save): Lisp function deleted.
8638
8639 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8640 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8641
8642 * xterm.h: Update prototype.
8643
5ba6571d
WX
86442011-05-28 William Xu <william.xwl@gmail.com>
8645
8646 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8647 exiting (Bug#8239).
8648
3eaff834
JM
86492011-05-28 Jim Meyering <meyering@redhat.com>
8650
e1900994 8651 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8652 * fns.c (to_uchar): Define.
8653 (crypto_hash_function): Use it to convert some newly-signed
8654 variables to unsigned, to avoid sign-extension bugs. For example,
8655 without this change, (md5 "truc") would evaluate to
8656 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8657 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8658 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8659
0f6990a7
PE
86602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8661
8662 Integer overflow fixes.
c8a9ca5a 8663
08686060
PE
8664 * dbusbind.c: Serial number integer overflow fixes.
8665 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8666 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8667 to hold a serial number that is too large for a fixnum.
8668 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8669 Check for serial numbers out of range. Decode any serial number
59568bf0 8670 that was so large that it became a float. (Bug#8722)
08686060 8671
2d1fc3c7
PE
8672 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8673 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8674 Use XFASTINT rather than XUINT when numbers are nonnegative.
8675 (xd_append_arg, Fdbus_method_return_internal):
8676 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8677 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8678 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8679 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8680 (Bug#8722)
2d1fc3c7 8681
c8a9ca5a
PE
8682 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8683
519e1d69
PE
8684 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8685
6df6ae42 8686 ccl: Add integer overflow checks.
30569699
PE
8687 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8688 (IN_INT_RANGE): New macros.
8689 (ccl_driver): Use them to check for integer overflow when
8690 decoding a CCL program. Many of the new checks are whether XINT (x)
8691 fits in int; it doesn't always, on 64-bit hosts. The new version
8692 doesn't catch all possible integer overflows, but it's an
847044ea 8693 improvement. (Bug#8719)
30569699 8694
c11285dc
PE
8695 * alloc.c (make_event_array): Use XINT, not XUINT.
8696 There's no need for unsigned here.
8697
fdccd48e
PE
8698 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8699 This follows up to the 2011-05-06 change that substituted uintptr_t
8700 for EMACS_INT. This case wasn't caught back then.
8701
37910ab2
PE
8702 Rework Fformat to avoid integer overflow issues.
8703 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8704 now (part of C89). Include <verify.h>.
8705 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8706 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8707 (Fformat): Avoid the prepass trying to compute sizes; it was only
8708 approximate and thus did not catch overflow reliably. Instead, walk
8709 through the format just once, formatting and computing sizes as we go,
8710 checking for integer overflow at every step, and allocating a larger
8711 buffer as needed. Keep track separately whether the format is
8712 multibyte. Keep only the most-recently calculated precision, rather
8713 than them all. Record whether each argument has been converted to
8714 string. Use EMACS_INT, not int, for byte and char and arg counts.
8715 Support field widths and precisions larger than INT_MAX. Avoid
8716 sprintf's undefined behavior with conversion specifications such as %#d
8717 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8718 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8719 formatting out-of-range floating point numbers with int
9173deec 8720 formats. (Bug#8668)
37910ab2 8721
2e6578fb
PE
8722 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8723
0ae6bdee
PE
8724 * data.c: Avoid integer truncation in expressions involving floats.
8725 * data.c: Include <intprops.h>.
8726 (arith_driver): When there's an integer overflow in an expression
8727 involving floating point, convert the integers to floating point
8728 so that the resulting value does not suffer from catastrophic
8729 integer truncation. For example, on a 64-bit host (* 4
8730 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8731 Do not rely on undefined behavior after integer overflow.
8732
de883a70
PE
8733 merge count_size_as_multibyte, parse_str_to_multibyte
8734 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8735 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8736 Check for integer overflow.
8737 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8738 since it's now a duplicate of the other. This is more of
8739 a character than a buffer op, so better that it's in character.c.
8740 * fns.c, print.c: Adjust to above changes.
8741
2ff916cb
PE
87422011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8743
8744 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8745
f1b54466
PE
87462011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8747
fb1ac845
PE
8748 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8749 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8750 (x_clipboard_manager_save): Now static.
8751 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8752
f1b54466
PE
8753 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8754 (crypto_hash_function): Now static.
8755 Fix pointer signedness problems. Avoid unnecessary initializations.
8756
a9f737ee
CY
87572011-05-27 Chong Yidong <cyd@stupidchicken.com>
8758
8759 * termhooks.h (Vselection_alist): Make it terminal-local.
8760
8761 * terminal.c (create_terminal): Initialize it.
8762
8763 * xselect.c: Support for clipboard managers.
8764 (Vselection_alist): Move to termhooks.h as terminal-local var.
8765 (LOCAL_SELECTION): New macro.
8766 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8767 (symbol_to_x_atom): Remove gratuitous arg.
8768 (x_handle_selection_request, lisp_data_to_selection_data)
8769 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8770 (x_own_selection, x_get_local_selection, x_convert_selection):
8771 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8772 (some_frame_on_display): Delete unused function.
8773 (Fx_own_selection_internal, Fx_get_selection_internal)
8774 (Fx_disown_selection_internal, Fx_selection_owner_p)
8775 (Fx_selection_exists_p): New optional frame arg.
8776 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8777 (x_handle_selection_clear): Don't treat other terminals with the
8778 same keyboard specially. Use the terminal-local Vselection_alist.
8779 (x_clear_frame_selections): Use Frun_hook_with_args.
8780
8781 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8782
8783 * xterm.h: Add support for those atoms.
8784
e067f0c1
CY
87852011-05-26 Chong Yidong <cyd@stupidchicken.com>
8786
8787 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8788 (converted_selections, conversion_fail_tag): New global variables.
8789 (x_selection_request_lisp_error): Free the above.
8790 (x_get_local_selection): Remove unnecessary code.
8791 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8792 of converted selections stored in converted_selections.
8793 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8794 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8795 (x_convert_selection): New function.
8796 (x_handle_selection_event): Simplify.
8797 (x_get_foreign_selection): Don't ignore incoming requests while
8798 waiting for an answer; this will fail when we implement
8799 SAVE_TARGETS, and seems unnecessary anyway.
8800 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8801 (Vx_sent_selection_functions): Doc fix.
8802
0f4aebc0
LL
88032011-05-26 Leo Liu <sdl.web@gmail.com>
8804
8805 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8806
e61124cd
YM
88072011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8808
8809 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8810
8811 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8812 for fringe update if it has periodic bitmap.
ac389d0c 8813 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8814 and fringe_bitmap_periodic_p.
8815
8816 * fringe.c (get_fringe_bitmap_data): New function.
8817 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8818 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8819 row. Mark glyph row for fringe update if periodicity changed.
8820
8821 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8822 for fringe update unless it has periodic bitmap.
8823
f16d9837
KH
88242011-05-25 Kenichi Handa <handa@m17n.org>
8825
8826 * xdisp.c (get_next_display_element): Set correct it->face_id for
8827 a static composition.
8828
e1b90ef6
LL
88292011-05-24 Leo Liu <sdl.web@gmail.com>
8830
8831 * deps.mk (fns.o):
8832 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8833
8834 * fns.c (crypto_hash_function, Fsha1): New function.
8835 (Fmd5): Use crypto_hash_function.
8836 (syms_of_fns): Add Ssha1.
8837
7400048f
PE
88382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8839
8840 * gnutls.c: Remove unused macros.
8841 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8842 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8843 Remove macros that are defined and never used.
8844 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8845
abb71cf4
CY
88462011-05-22 Chong Yidong <cyd@stupidchicken.com>
8847
8848 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8849 (Fx_get_selection_internal): Minor cleanup.
8850 (Fx_own_selection_internal): Rename arguments for consistency with
8851 select.el.
8852
6307db39
PE
88532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8854
8855 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8856
f3d4e0a4
CY
88572011-05-22 Chong Yidong <cyd@stupidchicken.com>
8858
8859 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8860
4d8ade89
YM
88612011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8862
8863 * dispnew.c (scrolling_window): Don't exclude the case that the
8864 last enabled row in the desired matrix touches the bottom boundary.
8865
32078c8d
GM
88662011-05-21 Glenn Morris <rgm@gnu.org>
8867
8868 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8869 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8870 and add some more files.
32078c8d 8871
7285dc67
EZ
88722011-05-20 Eli Zaretskii <eliz@gnu.org>
8873
8874 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8875 report_file_error introduced by the change from 2011-05-07.
8876
89d1bd22
PE
88772011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8878
8879 * systime.h (Time): Define only if emacs is defined.
8880 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8881 where the include path doesn't have X11/X.h by default. See
8882 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8883
cd394be1 88842011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8885
8886 * composite.c (find_automatic_composition): Fix previous change.
8887
b9704ad9
GM
88882011-05-20 Glenn Morris <rgm@gnu.org>
8889
8890 * lisp.mk: New file, split from Makefile.in.
8891 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8892 (shortlisp): Remove.
8893 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8894
4a720484
GM
88952011-05-19 Glenn Morris <rgm@gnu.org>
8896
8897 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8898 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8899 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8900 (lisp): Set the order to that of loadup.el.
8901 (shortlisp): Make it a copy of $lisp.
8902 (SOME_MACHINE_LISP): Remove.
8903 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8904 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8905
a28d4396
KH
89062011-05-18 Kenichi Handa <handa@m17n.org>
8907
8908 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8909 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8910 (find_automatic_composition): Mostly rewrite for efficiency.
8911
a2b1fa8e
JB
89122011-05-18 Juanma Barranquero <lekktu@gmail.com>
8913
8914 * makefile.w32-in: Update dependencies.
8915
8e1f5610
CS
89162011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8917
8918 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8919 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8920
7025ee00 89212011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8922
cdfa6eab
PE
8923 Fix some integer overflow issues, such as string length overflow.
8924
06d6db33
PE
8925 * insdel.c (count_size_as_multibyte): Check for string overflow.
8926
2b4560a8
PE
8927 * character.c (lisp_string_width): Check for string overflow.
8928 Use EMACS_INT, not int, for string indexes and lengths; in
8929 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8930 the resulting string length overflows an EMACS_INT; instead,
8931 report a string overflow if no precision given. When checking for
8932 precision exhaustion, use a check that cannot possibly have
8933 integer overflow. (Bug#8675)
8934 * character.h (lisp_string_width): Adjust to new signature.
8935
cb93f9be
PE
8936 * alloc.c (string_overflow): New function.
8937 (Fmake_string): Use it. This doesn't change behavior, but saves
8938 a few bytes and will simplify future changes.
8939 * character.c (string_escape_byte8): Likewise.
8940 * lisp.h (string_overflow): New decl.
8941
1a1f3366
PE
8942 Fixups, following up to the user-interface timestamp change.
8943 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8944 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8945 * msdos.c (mouse_get_pos): Likewise.
8946 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8947 * w32gui.h (Time): Define by including "systime.h" rather than by
8948 declaring it ourselves. (Bug#8664)
8949
d4e3e4d3
PE
8950 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8951 * image.c (clear_image_cache): Likewise.
8952
f6a24d19
PE
8953 * term.c (term_mouse_position): Don't assume time_t wraparound.
8954
08dc5ae6
PE
8955 Be more systematic about user-interface timestamps.
8956 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8957 and sometimes 'EMACS_UINT', to represent these timestamps.
8958 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8959 This makes the code easier to follow, and makes it easier to catch
8960 integer overflow bugs such as Bug#8664.
8961 * frame.c (Fmouse_position, Fmouse_pixel_position):
8962 Use Time, not unsigned long, for user-interface timestamps.
8963 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8964 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8965 * keyboard.h (last_event_timestamp): Likewise.
8966 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8967 * menu.h (xmenu_show): Likewise.
8968 * term.c (term_mouse_position): Likewise.
8969 * termhooks.h (struct input_event.timestamp): Likewise.
8970 (struct terminal.mouse_position_hook): Likewise.
8971 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8972 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8973 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8974 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8975 what it was before.
8976 * menu.h, termhooks.h: Include "systime.h", for Time.
8977
8e55734a
PE
8978 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8979 Don't assume that the difference between two unsigned long values
8980 can fit into an integer. At this point, we know button_down_time
8981 <= event->timestamp, so the difference must be nonnegative, so
8982 there's no need to cast the result if double-click-time is
8983 nonnegative, as it should be; check that it's nonnegative, just in
8984 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8985 apart (about 25 days). (Bug#8664)
8e55734a 8986
841f1b75 8987 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8988 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8989
3e26f69c
PE
8990 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8991 that always fit in int. Use a sentinel instead of a counter, to
8992 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8993 * frame.h (struct frame): Use int for menu_bar_items_used
8994 instead of EMACS_INT, since it always fits in int.
3e26f69c 8995
5cc152c0
PE
8996 * menu.c (grow_menu_items): Check for int overflow.
8997
d89eb65e
PE
8998 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8999
5235bd3e
PE
9000 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9001 Before, the code was not consistent. These values cannot exceed
9002 2**31 - 1 so there's no need to make them unsigned.
9003 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9004 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9005 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9006 as modifiers.
9007 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9008
bc827e23
PE
9009 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9010 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9011 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9012 presumably because the widths might not match.
9013
78eb494e
PE
9014 * window.c (size_window): Avoid needless test at loop start.
9015
04f2d78b
CB
90162011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9017
9018 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9019
d2fc7e3d 90202011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9021
9022 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9023
d2fc7e3d 90242011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9025
9026 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9027 `width' to `bar_area_x' and `bar_area_width', respectively.
9028 (x_scroll_run): Take account of fringe background extension.
9029
04f2d78b
CB
9030 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9031 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9032 `bar_area_width', respectively.
9033 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9034 background extension.
9035
79b70037
GM
90362011-05-10 Jim Meyering <meyering@redhat.com>
9037
9038 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9039
2f142cc5
JB
90402011-05-10 Juanma Barranquero <lekktu@gmail.com>
9041
9042 * image.c (Finit_image_library): Return t for built-in image types,
9043 like pbm and xbm. (Bug#8640)
9044
57679c86
AS
90452011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9046
9047 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9048
888c9e86
EZ
90492011-05-07 Eli Zaretskii <eliz@gnu.org>
9050
b0512a1d
EZ
9051 * w32console.c (Fset_screen_color): Doc fix.
9052 (Fget_screen_color): New function.
9053 (syms_of_ntterm): Defsubr it.
9054
7285dc67
EZ
9055 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9056 unlink the temporary file if Fcall_process didn't create it in the
9057 first place.
9058 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9059 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9060 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9061 cue to call_process_cleanup not to close that handle.
9062
4d3fcc8e
BK
90632011-05-07 Ben Key <bkey76@gmail.com>
9064
9065 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9066 one of two shell specific rules, either bootstrap-temacs-CMD or
9067 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9068 to the previous implementation of the bootstrap-temacs rule.
9069 The bootstrap-temacs-CMD rule is similar to the previous
9070 implementation of the bootstrap-temacs rule except that it
9071 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9072 variable.
9073
9074 These changes, along with some changes to nt/configure.bat,
9075 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9076 earlier fix to add support for --cflags and --ldflags options
9077 that include quotes so that it works whether make uses cmd or
9078 sh as the shell.
9079
b4289b64
MA
90802011-05-06 Michael Albinus <michael.albinus@gmx.de>
9081
9082 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9083 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9084 is a constant.
9085 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9086 a string. Handle both cases.
9087 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9088 (Fdbus_register_method): Use Qinvalid_function.
9089
af4c0e28
JB
90902011-05-06 Juanma Barranquero <lekktu@gmail.com>
9091
9092 * makefile.w32-in: Update dependencies.
9093 (LISP_H): Add inttypes.h and stdin.h.
9094 (PROCESS_H): Add unistd.h.
9095
c51453d9
EZ
90962011-05-06 Eli Zaretskii <eliz@gnu.org>
9097
9098 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9099 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9100
8ff0ac3c 91012011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9102
4c4b566b
PE
9103 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9104
aab2b9b5
PE
9105 * term.c (vfatal): Remove stray call to va_end.
9106 It's not needed and the C Standard doesn't allow it here anyway.
9107
c378da0b
PE
9108 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9109 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9110
288b08c7
PE
9111 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9112 bytes.
9113
e3601888
PE
9114 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9115
db6c0e74
PE
9116 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9117
dd5963ea
PE
9118 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9119
88c9450f
PE
9120 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9121
2f9442b8
PE
9122 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9123
c032b5f8
PE
9124 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9125 * charset.c (Fdefine_charset_internal): Don't initialize
9126 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9127 32-bit int (Bug#8600).
a108c10b
PE
9128
9129 * lread.c (read_integer): Be more consistent with string-to-number.
9130 Use string_to_number to do the actual conversion; this avoids
9131 rounding errors and fixes some other screwups. Without this fix,
9132 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9133 (digit_to_number): Move earlier, for benefit of read_integer.
9134 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9135 not a digit in any supported base. (Bug#8602)
a108c10b 9136
ad5f9eea
PE
9137 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9138
aec1708a
PE
9139 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9140 to match comment at start of function. This also removes a
9141 GCC warning about overflow in a 32+64-bit port.
9142
47be4ab5
PE
9143 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9144
371cac43
PE
9145 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9146 Reported by Stefan Monnier in
9147 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9148 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9149 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9150
d01a7826
PE
9151 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9152 (EMACS_UINTPTR): Likewise, with uintptr_t.
9153
7fd47d5c
PE
9154 * lisp.h: Prefer 64-bit EMACS_INT if available.
9155 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9156 on 32-bit hosts that have 64-bit int, so that they can access
9157 large files.
122b0c86
PE
9158 However, temporarily disable this change unless the temporary
9159 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9160
8727937b
PE
9161 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9162
8ac068ac
PE
9163 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9164 This removes an assumption that EMACS_INT and long are the same
9165 width as pointers. The assumption is true for Emacs porting targets
9166 now, but we want to make other targets possible.
9167 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9168 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9169 In the rest of the code, change types of integers that hold casted
9170 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9171 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9172 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9173 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9174 No need to cast type when ORing.
9175 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9176 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9177 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9178 assume EMACS_INT is the same width as char *.
9179 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9180 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9181 Remove no-longer-needed casts.
9182 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9183 (xg_tool_bar_help_callback, xg_make_tool_item):
9184 Use EMACS_INTPTR to hold an integer
9185 that will be cast to void *; this can avoid a GCC warning
9186 if EMACS_INT is not the same width as void *.
9187 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9188 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9189 (current_message_1, set_message_1):
9190 Use a local to convert to proper width without a cast.
9191 * xmenu.c (dialog_selection_callback): Likewise.
9192
ede49d71
PE
9193 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9194 Also, don't assume VALBITS / RAND_BITS is less than 5,
9195 and don't rely on undefined behavior when shifting a 1 left into
9196 the sign bit.
9197 * lisp.h (get_random): Change signature to match.
9198
2f30ecd0
PE
9199 * lread.c (hash_string): Use size_t, not int, for hash computation.
9200 Normally we prefer signed values; but hashing is special, because
9201 it's better to use unsigned division on hash table sizes so that
9202 the remainder is nonnegative. Also, size_t is the natural width
9203 for hashing into memory. The previous code used 'int', which doesn't
9204 retain enough info to hash well into very large tables.
9205 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9206
2a866e7b
PE
9207 * dbusbind.c: Don't possibly lose pointer info when converting.
9208 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9209 Use XPNTR rather than XHASH, so that the high-order bits of
9210 the pointer aren't lost when converting through void *.
9211
51639eac
PE
9212 * eval.c (Fautoload): Don't double-shift a pointer.
9213
92394119
PE
9214 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9215
dbdb9a7c
JB
92162011-05-06 Juanma Barranquero <lekktu@gmail.com>
9217
9218 * gnutls.c (DEF_GNUTLS_FN):
9219 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9220
db7a0b4f
AS
92212011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9222
9223 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9224 marker. (Bug#8610)
9225
cd394be1 92262011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9227
9228 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9229 New version that can reserve upto 2GB of heap space.
9230
f7ff1b0f 92312011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9232
9233 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9234
639c109b
TZ
92352011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9236
9237 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9238 `gnutls_certificate_set_x509_key_file'.
9239
d2127135
JB
92402011-05-05 Juanma Barranquero <lekktu@gmail.com>
9241
9242 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9243 Update dependencies.
9244
e968f4f3
JB
92452011-05-04 Juanma Barranquero <lekktu@gmail.com>
9246
9247 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9248 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9249 Remove unused parameter `fildes'.
9250 * process.c (read_process_output, send_process): Don't pass it.
9251
84d358f0
JB
92522011-05-04 Juanma Barranquero <lekktu@gmail.com>
9253
9254 Fix previous change: the library cache is defined in w32.c.
9255 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9256 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9257
0898ca10
JB
92582011-05-04 Juanma Barranquero <lekktu@gmail.com>
9259
9260 Implement dynamic loading of GnuTLS on Windows.
9261
9262 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9263 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9264 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9265 Declare.
9266
9267 * gnutls.c (Qgnutls_dll): Define.
9268 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9269 (gnutls_*): Declare function pointers.
9270 (init_gnutls_functions): New function to initialize function pointers.
9271 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9272 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9273 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9274 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9275 (emacs_gnutls_write, emacs_gnutls_read)
9276 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9277 (Fgnutls_available_p): New function.
9278 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9279 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9280 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9281
9282 * image.c: Include w32.h.
9283 (Vimage_type_cache): Delete.
9284 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9285 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9286 (w32_delayed_load): Move to w32.c.
9287
9288 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9289
9290 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9291 (w32_delayed_load): Move from image.c. When loading a library, record
9292 its filename in the :loaded-from property of the library id.
9293 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9294 Initialize and staticpro them.
9295 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9296
9297 * process.c: Include lisp.h before w32.h, not after.
9298 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9299 instead of gnutls_record_check_pending.
9300
9301 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9302
ff4de4aa
TZ
93032011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9304
9305 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9306 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9307 as passed in.
9308
abe95abb
JD
93092011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9310
9311 * xterm.c (x_set_frame_alpha): Do not set property on anything
9312 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9313
e16e55d4
JB
93142011-05-02 Juanma Barranquero <lekktu@gmail.com>
9315
9316 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9317
bafcf6a5
JB
93182011-05-02 Juanma Barranquero <lekktu@gmail.com>
9319
9320 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9321 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9322 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9323 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9324 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9325 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9326 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9327 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9328 (Qgnutls_bootprop_callbacks_verify): Make static.
9329
e7a6747f
AS
93302011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9331
19ed11ba
AS
9332 * callproc.c: Indentation fixup.
9333
e7a6747f 9334 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9335 (wait_for_termination, interruptible_wait_for_termination):
9336 Move after wait_for_termination_1.
e7a6747f 9337
1ef14cb4
LMI
93382011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9339
9340 * sysdep.c (interruptible_wait_for_termination): New function
9341 which is like wait_for_termination, but allows keyboard
9342 interruptions.
9343
9344 * callproc.c (Fcall_process): Add (:file "file") as an option for
9345 the STDOUT buffer.
9346 (Fcall_process_region): Ditto.
9347
330d880c
EZ
93482011-04-30 Eli Zaretskii <eliz@gnu.org>
9349
8db90b73
EZ
9350 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9351 rather than `XVECTOR (FOO)->size'.
9352
330d880c
EZ
9353 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9354 inttypes.h, as a gnulib replacement is used if it not available in
9355 system headers.
9356
15cbd324
EZ
93572011-04-21 Eli Zaretskii <eliz@gnu.org>
9358
9359 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9360 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9361 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9362
9363 * coding.c (coding_alloc_by_realloc): Error out if destination
9364 will grow beyond MOST_POSITIVE_FIXNUM.
9365 (decode_coding_emacs_mule): Abort if there isn't enough place in
9366 charbuf for the composition carryover bytes. Reserve an extra
9367 space for up to 2 characters produced in a loop.
9368 (decode_coding_iso_2022): Abort if there isn't enough place in
9369 charbuf for the composition carryover bytes.
9370
93712011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9372
ae940cca
EZ
9373 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9374 aborting when %lld or %lll format is passed.
9375 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9376 %llo or %llx format is passed. (Bug#8545)
9377
03ab8921
EZ
9378 * window.c (window_scroll_line_based): Use a marker instead of
9379 simple variables to record original value of point. (Bug#7952)
9380
afda1437
EZ
9381 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9382 produced by %s or %c overflows available buffer space. (Bug#8545)
9383
f76dee0c
PE
93842011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9385
9386 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9387 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9388
fdc5744d
JB
93892011-04-28 Juanma Barranquero <lekktu@gmail.com>
9390
9391 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9392
638f053a
JB
93932011-04-28 Juanma Barranquero <lekktu@gmail.com>
9394
9395 * keyboard.c (Qdelayed_warnings_hook): Define.
9396 (command_loop_1): Run `delayed-warnings-hook'
9397 if Vdelayed_warnings_list is non-nil.
9398 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9399 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9400
d178f871
EZ
94012011-04-28 Eli Zaretskii <eliz@gnu.org>
9402
9403 * doprnt.c (doprnt): Don't return value smaller than the buffer
9404 size if the message was truncated. (Bug#8545).
9405
b124fd93
JB
94062011-04-28 Juanma Barranquero <lekktu@gmail.com>
9407
9408 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9409 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9410
e810457d
PE
94112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9412
9413 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9414
ea51cceb
JB
94152011-04-27 Juanma Barranquero <lekktu@gmail.com>
9416
9417 * makefile.w32-in: Update dependencies.
9418
94dcfacf
EZ
94192011-04-27 Eli Zaretskii <eliz@gnu.org>
9420
9421 Improve `doprnt' and its usage. (Bug#8545)
9422 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9423 `format_end'. Remove support for %l as a conversion specifier.
9424 Don't use xrealloc. Improve diagnostics when the %l size modifier
9425 is used. Update the commentary.
9426
9427 * eval.c (verror): Simplify calculation of size_t.
9428
9429 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9430 messages.
9431
f61f41d7
PE
94322011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9433
9434 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9435 change.
9436
96fb4434
PE
94372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9438
9439 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9440 This makes this file independent of the recent pseudovector change.
9441
671875da 94422011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9443
69e9b5a3
PE
9444 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9445
b5f869a7 9446 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9447 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9448 Remove unused local.
c8926152 9449 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9450
841a1577 9451 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9452 GCC 4.6.0 optimizes based on type-based alias analysis.
9453 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9454 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9455 != &v->size, and therefore "v->size = 1; b->size = 2; return
9456 v->size;" must therefore return 1. This assumption is incorrect
9457 for Emacs, since it type-puns struct Lisp_Vector * with many other
9458 types. To fix this problem, this patch adds a new type struct
f904488f 9459 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9460 and pseudovectors, and helps optimizing compilers not get fooled
9461 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9462 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9463 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9464 the size member.
eab3844f
PE
9465 (XSETPVECTYPE): Rewrite in terms of new macro.
9466 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9467 This is a bit clearer, and further avoids the possibility of
9468 undesirable aliasing.
9469 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9470 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9471 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9472 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9473 (ASIZE): Now uses header.size rather than size.
9474 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9475 to avoid the hassle of writing XVECTOR (foo)->header.size.
9476 (struct vectorlike_header): New type.
eab3844f
PE
9477 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9478 object, to help avoid aliasing.
9479 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9480 (SUBRP): Likewise, since Lisp_Subr is a special case.
9481 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9482 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9483 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9484 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9485 changed to be "header.size" and "header.next".
9486 * buffer.h (struct buffer): Likewise.
9487 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9488 * frame.h (struct frame): Likewise.
9489 * process.h (struct Lisp_Process): Likewise.
9490 * termhooks.h (struct terminal): Likewise.
9491 * window.c (struct save_window_data, struct saved_window): Likewise.
9492 * window.h (struct window): Likewise.
9493 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9494 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9495 * buffer.c (init_buffer_once): Likewise.
9496 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9497 special case.
9498 * process.c (Fformat_network_address): Use local var for size,
9499 for brevity.
9500
0df1eac5
PE
9501 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9502
847ab9d1 9503 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9504 * data.c (atof): Remove decl; no longer used or needed.
9505 (digit_to_number): Move to lread.c.
9506 (Fstring_to_number): Use new string_to_number function, to be
9507 consistent with how the Lisp reader treats infinities and NaNs.
9508 Do not assume that floating-point numbers represent EMACS_INT
9509 without losing information; this is not true on most 64-bit hosts.
9510 Avoid double-rounding errors, by insisting on integers when
9511 parsing non-base-10 numbers, as the documentation specifies.
9512 * lisp.h (string_to_number): New decl, replacing ...
9513 (isfloat_string): Remove.
bc0a5c13 9514 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9515 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9516 appears to have been a coding error. Similarly, do not accept
9517 strings like +-1e0 as floating point numbers. Do not report
9518 overflow for integer overflows unless the base is not 10 which
9519 means we have no simple and reliable way to continue.
9520 Break out the floating-point parsing into a new
9521 function string_to_number, so that Fstring_to_number parses
9522 floating point numbers consistently with the Lisp reader.
04f2d78b 9523 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9524 (E_CHAR, EXP_INT): Remove, replacing with ...
9525 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9526 (string_to_number): New function, replacing isfloat_string.
9527 This function checks for valid syntax and produces the resulting
9528 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9529 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9530 so that overflow for non-base-10 numbers is reported only when
9531 there's no portable and simple way to convert to floating point.
452f4150 9532
67769ffc
PE
9533 * textprop.c (set_text_properties_1): Rewrite for clarity,
9534 and to avoid GCC warning about integer overflow.
9535
c20db43f
PE
9536 * intervals.h (struct interval): Use EMACS_INT for members
9537 where EMACS_UINT might cause problems. See
9538 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9539 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9540 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9541 All uses changed.
37aa2f85
PE
9542 (offset_intervals): Tell GCC not to worry about length overflow
9543 when negating a negative length.
c20db43f 9544
2538aa2f
PE
9545 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9546 (overrun_check_free): Likewise.
9547
f2d3008d
PE
9548 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9549 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9550 word size.
9551
ec8df744
PE
9552 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9553 (gnutls_make_error): Rename local to avoid shadowing.
9554 (gnutls_emacs_global_deinit): ifdef out; not used.
9555 (Fgnutls_boot): Use const for pointer to readonly storage.
9556 Comment out unused local. Fix pointer signedness problems.
9557
640ee02d
PE
9558 * lread.c (openp): Don't stuff size_t into an 'int'.
9559 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9560 about possible signed overflow.
9561
6048fb2a
PE
9562 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9563 (GDK_KEY_g): Don't define if already defined.
9564 (xg_prepare_tooltip): Avoid pointer signedness problem.
9565 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9566
fa3c87e1
PE
9567 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9568 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9569
2172544b
PE
9570 * xfns.c (Fx_window_property): Simplify a bit,
9571 to make a bit faster and to avoid GCC 4.6.0 warning.
9572 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9573
9b821a21
PE
9574 * fns.c (internal_equal): Don't assume size_t fits in int.
9575
3c616cfa
PE
9576 * alloc.c (compact_small_strings): Tighten assertion a little.
9577
c2982e87
PE
9578 Replace pEd with more-general pI, and fix some printf arg casts.
9579 * lisp.h (pI): New macro, generalizing old pEd macro to other
9580 conversion specifiers. For example, use "...%"pI"d..." rather
9581 than "...%"pEd"...".
9582 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9583 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9584 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9585 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9586 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9587 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9588 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9589 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9590 64-bit hosts.
9591 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9592 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9593 * print.c (safe_debug_print, print_object): Likewise.
9594 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9595 to int.
6f04d126
PE
9596 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9597 avoiding the 0 flag, which is not portable.
c2982e87
PE
9598 * process.c (Fmake_network_process): Use pI to avoid cast.
9599 * region-cache.c (pp_cache): Likewise.
9600 * xdisp.c (decode_mode_spec): Likewise.
9601 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9602 behavior on 64-bit hosts with printf arg.
6f04d126 9603 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9604 (x_stop_queuing_selection_requests): Likewise.
9605 (x_get_window_property): Don't truncate byte count to an 'int'
9606 when tracing.
0b432f21 9607
5e073ec7
PE
9608 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9609 here, since it parses constructs like leading '-' and spaces,
9610 which are not wanted; and it overflows with large numbers.
9611 Instead, simply match F[0-9]+, which is what is wanted anyway.
9612
36372bf9
PE
9613 * alloc.c: Remove unportable assumptions about struct layout.
9614 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9615 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9616 (allocate_vectorlike, make_pure_vector): Use the new macros,
9617 plus offsetof, to remove unportable assumptions about struct layout.
9618 These assumptions hold on all porting targets that I know of, but
9619 they are not guaranteed, they're easy to remove, and removing them
9620 makes further changes easier.
9621
0b432f21
PE
9622 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9623 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9624 (string_overrun_cookie): Now const. Use initializers that
9625 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9626 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9627 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9628 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9629 multiple of sizeof (EMACS_INT); it need not be, if
9630 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9631 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9632
895009e1
JB
96332011-04-26 Juanma Barranquero <lekktu@gmail.com>
9634
9635 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9636
6a7a1b0b
TZ
96372011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9638
9639 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9640 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9641 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9642
841a1577 96432011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9644
9645 * lisp.h (Qdebug): List symbol.
895009e1 9646 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9647 * keyboard.c (debug-on-event): New variable.
9648 (handle_user_signal): Break into debugger when debug-on-event
9649 matches the current signal symbol.
9650
f2d3ba6f
DN
96512011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9652
9653 * alloc.c (check_sblock, check_string_bytes)
9654 (check_string_free_list): Convert to standard C.
9655
42ce4c63
TZ
96562011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9657
9658 * w32.c (emacs_gnutls_push): Fix typo.
9659
825cd63c
EZ
96602011-04-25 Eli Zaretskii <eliz@gnu.org>
9661
fb11d64d
EZ
9662 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9663 "cast to pointer from integer of different size".
9664
825cd63c
EZ
9665 Improve doprnt and its use in verror. (Bug#8545)
9666 * doprnt.c (doprnt): Document the set of format control sequences
9667 supported by the function. Use SAFE_ALLOCA instead of always
9668 using `alloca'.
9669
9670 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9671 is one byte too soon. Don't use xrealloc; instead xfree and
9672 xmalloc anew.
9673
e061a11b
TZ
96742011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9675
9676 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9677 callbacks stage.
9678
9679 * gnutls.c: Renamed global_initialized to
9680 gnutls_global_initialized. Added internals for the
9681 :verify-hostname-error, :verify-error, and :verify-flags
9682 parameters of `gnutls-boot' and documented those parameters in the
9683 docstring. Start callback support.
9173deec
JB
9684 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9685 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9686 on error. Return error code.
e061a11b
TZ
9687 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9688 (emacs_gnutls_read): Likewise.
9689 (Fgnutls_boot): Return handshake error code.
9690 (emacs_gnutls_handle_error): New function.
9691 (wsaerror_to_errno): Likewise.
9692
9693 * w32.h (emacs_gnutls_pull): Add prototype.
9694 (emacs_gnutls_push): Likewise.
9695
9696 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9697 (emacs_gnutls_push): Likewise.
9698
96992011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9700
9701 * process.c (wait_reading_process_output): Check if GnuTLS
9702 buffered some data internally if no FDs are set for TLS
9703 connections.
9704
9705 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9706 (LIBS): Link to USER_LIBS.
9707 ($(BLD)/gnutls.$(0)): New target.
9708
fa6996bc
EZ
97092011-04-24 Eli Zaretskii <eliz@gnu.org>
9710
eb35682e
EZ
9711 * xdisp.c (handle_single_display_spec): Rename the
9712 display_replaced_before_p argument into display_replaced_p, to
9713 make it consistent with the commentary. Fix typos in the
9714 commentary.
9715
e2ad650c
EZ
9716 * textprop.c (syms_of_textprop): Remove dead code.
9717 (copy_text_properties): Delete obsolete commentary about an
9718 interface that was deleted long ago. Fix typos in the description
9719 of arguments.
9720
1b2de274
EZ
9721 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9722 to changes in oldXMenu/XMenu.h from 2011-04-16.
9723 <menu_help_message, prev_menu_help_message>: Constify.
9724 (IT_menu_make_room): menu->help_text is now `const char **';
9725 adjust.
9726
9727 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9728 to changes in oldXMenu/XMenu.h from 2011-04-16.
9729 (struct XMenu): Declare `help_text' `const char **'.
9730
9731 * xfaces.c <Qunspecified>: Make extern again.
9732
9733 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9734 required by POSIX.
1b2de274 9735
762b15be
EZ
9736 * doc.c (get_doc_string): Improve the format passed to `error'.
9737
9738 * doprnt.c (doprnt): Improve commentary.
9739
9740 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9741
9742 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9743 them with etags.
9744
f1052e5d
EZ
9745 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9746 changes in globals.h immediately force recompilation.
762b15be
EZ
9747 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9748 $(CURDIR)/s/ms-w32.h.
9749 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9750
fa6996bc
EZ
9751 * character.c (Fchar_direction): Function deleted.
9752 (syms_of_character): Don't defsubr it.
9753 <char-direction-table>: Deleted.
9754
e6c3da20
EZ
97552011-04-23 Eli Zaretskii <eliz@gnu.org>
9756
9757 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9758 * doprnt.c: Include limits.h.
9759 (SIZE_MAX): New macro.
04f2d78b
CB
9760 (doprnt): Return a size_t value. 2nd arg is now size_t.
9761 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9762 Improve overflow protection. Support `l' modifier for integer
9763 conversions. Support %l conversion. Don't assume an EMACS_INT
9764 argument for integer conversions and for %c.
9765
9766 * lisp.h (doprnt): Restore prototype.
9767
9768 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9769 $(SRC)/character.h.
9770
9771 * Makefile.in (base_obj): Add back doprnt.o.
9772
9773 * deps.mk (doprnt.o): Add back prerequisites.
9774 (callint.o): Depend on character.h.
9775
9776 * eval.c (internal_lisp_condition_case): Include the handler
9777 representation in the error message.
9778 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9779 when breaking from the loop.
9780
9781 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9782
9783 * callint.c (Fcall_interactively): When displaying error message
9784 about invalid control letter, pass the character's codepoint, not
9785 a pointer to its multibyte form. Improve display of the character
9786 in octal and display also its hex code.
9787
9788 * character.c (char_string): Use %x to display the (unsigned)
9789 codepoint of an invalid character, to avoid displaying a bogus
9790 negative value.
9791
9792 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9793 `error', not SYMBOL_NAME itself.
9794
9795 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9796 character arguments to `error'.
9797
9798 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9799 to `error' in error message about FINAL_CHAR argument. Make sure
9800 FINAL_CHAR is a character, and use %c when it is passed as
9801 argument to `error'.
9802
4ffd0d6b 98032011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9804
9805 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9806
9807 * w32.c: Include <time.h>.
9808 (sys_localtime): New function.
9809
4ffd0d6b 98102011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9811
9812 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9813
4ffd0d6b 9814 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9815
4ffd0d6b 98162011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9817
4ffd0d6b
GM
9818 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9819 zombies (Bug#8467).
aac0c6e3 9820
04c56954
EZ
98212011-04-19 Eli Zaretskii <eliz@gnu.org>
9822
9823 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9824 gl_state.e_property when gl_state.object is Qt.
9825
9826 * insdel.c (make_gap_larger): Remove limitation of buffer size
9827 to <= INT_MAX.
9828
16a43933
CY
98292011-04-18 Chong Yidong <cyd@stupidchicken.com>
9830
9831 * xdisp.c (lookup_glyphless_char_display)
9832 (produce_glyphless_glyph): Handle cons cell entry in
9833 glyphless-char-display.
9834 (Vglyphless_char_display): Document it.
9835
9836 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9837 glyphless-char-display.
9838
4581706e
CY
98392011-04-17 Chong Yidong <cyd@stupidchicken.com>
9840
9841 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9842
9843 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9844
9845 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9846 definition for no-X builds.
9847
4887c6e2 98482011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9849
fd35b6f9
PE
9850 Static checks with GCC 4.6.0 and non-default toolkits.
9851
5c1ccb01
PE
9852 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9853
006c5daa
PE
9854 * process.c (keyboard_bit_set): Define only if SIGIO.
9855 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9856 (send_process): Repair possible setjmp clobbering.
9857
efc736d3
PE
9858 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9859
4e2fe2e6
PE
9860 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9861
f97334a2
PE
9862 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9863
4e75f29d
PE
9864 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9865 Define only if needed.
9866
90efadd1
PE
9867 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9868 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9869 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9870
3c647824
PE
9871 * dispextern.h (struct redisplay_interface): Rename param
9872 to avoid shadowing.
e264f262 9873 * termhooks.h (struct terminal): Likewise.
761383f4 9874 * xterm.c (xembed_send_message): Likewise.
3c647824 9875
b58c5c4a
PE
9876 * insdel.c (make_gap_smaller): Define only if
9877 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9878
cad59032
PE
9879 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9880 it.
9881
c339dc2e
PE
9882 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9883 so that we aren't warned about unused symbols.
9884
91a3e27b
PE
9885 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9886
399c71d3 9887 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9888
8ffc96f5
PE
9889 * xfns.c (x_real_positions): Mark locals as initialized.
9890
eef9bc79
PE
9891 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9892
098db9dd
PE
9893 * xterm.c: Fix problems found by static analysis with other toolkits.
9894 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9895 (x_dispatch_event): Declare static if USE_GTK, and
9896 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9897 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9898 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9899 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9900 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9901
eb18f6cc
PE
9902 * xmenu.c (menu_help_callback): Pointer type fixes.
9903 Use const pointers when pointing at readonly data. Avoid pointer
9904 signedness clashes.
9905 (FALSE): Remove unused macro.
9906 (update_frame_menubar): Remove unused decl.
9907
1fe72bf8
PE
9908 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9909
60d9e1db
PE
9910 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9911 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9912 (single_menu_item): Rename local to avoid shadowing.
9913
39261c26
PE
9914 * keyboard.c (make_lispy_event): Remove unused local var.
9915
018c5e19
PE
9916 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9917 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9918
63d2b86e
PE
9919 * bitmaps: Change bitmaps from unsigned char back to the X11
9920 compatible char. Avoid the old compiler warnings about
9921 out-of-range initializers by using, for example, '\xab' rather
9922 than 0xab.
9923
aefd87e1
PE
9924 * xgselect.c (xgselect_initialize): Check vs interface
9925 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9926
bf501fb9
PE
9927 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9928
e9829fdf
PE
9929 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9930 to read-only memory.
9931
1086c095
PE
9932 * fns.c (vector): Remove; this old hack is no longer needed.
9933
2baccd04 9934 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9935 Remove unused var.
dde42981 9936 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9937
72391843 9938 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9939
436c16df 9940 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9941 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9942 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9943
92bb796d 9944 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9945 (x_term_init): Remove local to avoid shadowing.
92bb796d 9946
764430a3 9947 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9948
9949 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9950 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9951
d1dfb56c
EZ
99522011-04-16 Eli Zaretskii <eliz@gnu.org>
9953
c4354cb4
EZ
9954 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9955
d1dfb56c
EZ
9956 Fix regex.c, syntax.c and friends for buffers > 2GB.
9957 * syntax.h (struct gl_state_s): Declare character position members
9958 EMACS_INT.
9959
9960 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9961
04f2d78b
CB
9962 * textprop.c (verify_interval_modification, interval_of):
9963 Declare arguments EMACS_INT.
d1dfb56c
EZ
9964
9965 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9966 EMACS_INT.
9967
9968 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9969
9970 * indent.c (Fvertical_motion): Local variable it_start is now
9971 EMACS_INT.
9972
9973 * regex.c (re_match, re_match_2, re_match_2_internal)
9974 (bcmp_translate, regcomp, regexec, print_double_string)
9975 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9976 (re_compile_pattern, re_exec): Declare arguments and local
9977 variables `size_t' and `ssize_t' and return values `regoff_t', as
9978 appropriate.
9979 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9980 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9981 <compile_stack_type>: `size' and `avail' are now `size_t'.
9982
9983 * regex.h <regoff_t>: Use ssize_t, not int.
9984 (re_search, re_search_2, re_match, re_match_2): Arguments that
9985 specify buffer/string position and length are now ssize_t and
9986 size_t. Return type is regoff_t.
9987
613052cd
BK
99882011-04-16 Ben Key <bkey76@gmail.com>
9989
9990 * nsfont.m: Fixed bugs in ns_get_family and
9991 ns_descriptor_to_entity that were caused by using free to
9992 deallocate memory blocks that were allocated by xmalloc (via
9993 xstrdup). This caused Emacs to crash when compiled with
9994 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9995 --enable-checking=xmallocoverrun). xfree is now used to
9996 deallocate these memory blocks.
9997
4170f62f 99982011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9999
71b41406
PE
10000 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10001
9587a89d
PE
10002 emacs_write: Accept and return EMACS_INT for sizes.
10003 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10004 et seq.
10005 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10006 Accept and return EMACS_INT.
10007 (emacs_gnutls_write): Return the number of bytes written on
10008 partial writes.
10009 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10010 (emacs_read, emacs_write): Remove check for negative size, as the
10011 Emacs source code has been audited now.
9587a89d
PE
10012 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10013 (emacs_read, emacs_write): Use it.
273a5f82
PE
10014 * process.c (send_process): Adjust to the new signatures of
10015 emacs_write and emacs_gnutls_write. Do not attempt to store
10016 a byte offset into an 'int'; it might overflow.
9587a89d 10017 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10018
3e047f51
PE
10019 * sound.c: Don't assume sizes fit in 'int'.
10020 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10021 Return EMACS_INT, not int.
3e047f51 10022 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10023 Accept EMACS_INT, not int.
10024 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10025 record read return values.
10026
cc39a9db
BK
100272011-04-15 Ben Key <bkey76@gmail.com>
10028
c9d0ec6d
JB
10029 * keyboard.c (Qundefined): Don't declare static since it is used
10030 in nsfns.m.
10031 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10032 static since they are used in nsfont.m.
cc39a9db 10033
6c60eb9f
SM
100342011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10035
10036 * process.c (Qprocessp): Don't declare static.
10037 * lisp.h (Qprocessp): Declare again.
10038
7990b61a
JB
100392011-04-15 Juanma Barranquero <lekktu@gmail.com>
10040
10041 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10042
5d4cb038
PE
100432011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10044
8bd7b830 10045 Improve C-level modularity by making more things 'static'.
cd64ea1d 10046
e3b27b31
PE
10047 Don't publish debugger-only interfaces to other modules.
10048 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10049 (verify_bytepos, count_markers): Move decls to the only modules
10050 that need them.
10051 * region-cache.h (pp_cache): Likewise.
10052 * window.h (check_all_windows): Likewise.
10053 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10054
5d4cb038
PE
10055 * sysdep.c (croak): Now static, if
10056 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10057 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10058
10059 * alloc.c (refill_memory_reserve): Now static if
10060 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10061 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10062
e87b6180
PE
10063 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10064 Define only if USE_LUCID.
10065
ac64929e
PE
10066 * xrdb.c (x_customization_string, x_rm_string): Now static.
10067
6f37259d
PE
10068 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10069 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10070
1683e3ab
PE
10071 * xdisp.c (draw_row_with_mouse_face): Now static.
10072 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10073
de9c2632
PE
10074 * window.h (check_all_windows): Mark externally visible.
10075
2b96acb7
PE
10076 * window.c (window_deletion_count): Now static.
10077
10078 * undo.c: Make symbols static if they're not exported.
10079 (last_undo_buffer, last_boundary_position, pending_boundary):
10080 Now static.
10081
50436f33
PE
10082 * textprop.c (interval_insert_behind_hooks): Now static.
10083 (interval_insert_in_front_hooks): Likewise.
10084
64520e5c
PE
10085 * term.c: Make symbols static if they're not exported.
10086 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10087 (max_frame_lines, tty_set_terminal_modes):
10088 (tty_reset_terminal_modes, tty_turn_off_highlight):
10089 (get_tty_terminal): Now static.
10090 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10091 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10092 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10093 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10094 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10095
1fa53021
PE
10096 * sysdep.c: Make symbols static if they're not exported.
10097 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10098 Now static.
10099 (sigprocmask_set, full_mask): Remove; unused.
10100 (wait_debugging): Mark as visible.
10101 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10102 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10103
d4b43b22
PE
10104 * syntax.c (syntax_temp): Define only if !__GNUC__.
10105
b7c513d0
PE
10106 * sound.c (current_sound_device, current_sound): Now static.
10107
989b29ad
PE
10108 * search.c (searchbufs, searchbuf_head): Now static.
10109
13a55a78
PE
10110 * scroll.c (scroll_cost): Remove; unused.
10111 * dispextern.h (scroll_cost): Remove decl.
10112
de68a1fc
PE
10113 * region-cache.h (pp_cache): Mark as externally visible.
10114
40ccffa6
PE
10115 * process.c: Make symbols static if they're not exported.
10116 (process_tick, update_tick, create_process, chan_process):
10117 (Vprocess_alist, proc_buffered_char, datagram_access):
10118 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10119 (deactivate_process): Mark defn as static, as well as decl.
10120 * lisp.h (create_process): Remove decl.
10121 * process.h (chan_process, Vprocess_alist): Remove decls.
10122
ad64fc97
PE
10123 * print.c: Make symbols static if they're not exported.
10124 (print_depth, new_backquote_output, being_printed, print_buffer):
10125 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10126 (print_interval, print_number_index, initial_stderr_stream):
10127 Now static.
10128 * lisp.h (Fprinc): Remove decl.
10129 (debug_output_compilation_hack): Mark as externally visible.
10130
adddb265
PE
10131 * sysdep.c (croak): Move decl from here to syssignal.h.
10132 * syssignal.h (croak): Put it here, so the API can be checked when
10133 'croak' is called from dissociate_if_controlling_tty.
10134
1717ede2
PE
10135 * minibuf.c: Make symbols static if they're not exported.
10136 (minibuf_save_list, choose_minibuf_frame): Now static.
10137 * lisp.h (choose_minibuf_frame): Remove decl.
10138
fa5fb2bc
PE
10139 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10140
1e3890d1
PE
10141 * lread.c: Make symbols static if they're not exported.
10142 (read_objects, initial_obarray, oblookup_last_bucket_number):
10143 Now static.
10144 (make_symbol): Remove; unused.
10145 * lisp.h (initial_obarray, make_symbol): Remove decls.
10146
8a1414fa
PE
10147 * keyboard.c: Make symbols static if they're not exported.
10148 (single_kboard, recent_keys_index, total_keys, recent_keys):
10149 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10150 (this_single_command_key_start, echoing, last_auto_save):
10151 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10152 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10153 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10154 (Vlispy_mouse_stem, double_click_count):
10155 Now static.
10156 (force_auto_save_soon): Define only if SIGDANGER.
10157 (ignore_mouse_drag_p): Now static if
10158 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10159 (print_help): Remove; unused.
10160 (stop_character, last_timer_event): Mark as externally visible.
10161 * keyboard.h (ignore_mouse_drag_p): Declare only if
10162 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10163 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10164 * lisp.h (echoing): Remove decl.
10165 (force_auto_save_soon): Declare only if SIGDANGER.
10166 * xdisp.c (redisplay_window): Simplify code, to make it more
10167 obvious that ignore_mouse_drag_p is not accessed if !defined
10168 USE_GTK && !defined HAVE_NS.
10169
93ea6e8f
PE
10170 * intervals.c: Make symbols static if they're not exported.
10171 (merge_properties_sticky, merge_interval_right, delete_interval):
10172 Now static.
10173 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10174
77382fcc
PE
10175 * insdel.c: Make symbols static if they're not exported.
10176 However, leave prepare_to_modify_buffer alone. It's never
10177 called from outside this function, but that appears to be a bug.
10178 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10179 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10180 (adjust_after_replace_noundo): Remove; unused.
10181 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10182 (signal_before_change): Remove decls.
77382fcc 10183
9306c32e
PE
10184 * indent.c (val_compute_motion, val_vmotion): Now static.
10185
cd44d2eb
PE
10186 * image.c: Make symbols static if they're not exported.
10187 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10188 if USE_GTK.
10189 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10190 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10191
ad9a7a06
PE
10192 * fringe.c (standard_bitmaps): Now static.
10193 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10194
81626931
PE
10195 * frame.c: Make symbols static if they're not exported.
10196 (x_report_frame_params, make_terminal_frame): Now static.
10197 (get_frame_param): Now static, unless HAVE_NS.
10198 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10199 (x_get_resource_string): Remove; not used.
10200 * frame.h (make_terminal_frame, x_report_frame_params):
10201 (x_get_resource_string); Remove decls.
10202 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10203 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10204
239f9db9
PE
10205 * font.c, fontset.c: Make symbols static if they're not exported.
10206 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10207 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10208 * font.c (font_close_object): Now static.
10209 * font.h (font_close_object): Remove.
10210 * fontset.c (FONTSET_OBJLIST): Remove.
10211 (free_realized_fontset) #if-0 the body, which does nothing.
10212 (face_suitable_for_char_p): #if-0, as it's never called.
10213 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10214 * xfaces.c (face_at_string_position):
10215 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10216 since 0 is always ASCII.
10217
dfcf3579
PE
10218 * fns.c (weak_hash_tables): Now static.
10219
5045092b
PE
10220 * fileio.c: Make symbols static if they're not exported.
10221 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10222 (Vwrite_region_annotation_buffers): Now static.
10223
57a96f5c
PE
10224 * eval.c: Make symbols static if they're not exported.
10225 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10226 * lisp.h (backtrace_list): Remove decl.
10227
35f08c38
PE
10228 * emacs.c: Make symbols static if they're not exported.
10229 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10230 (fatal_error_code, fatal_error_signal_hook, standard_args):
10231 Now static.
10232 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10233 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10234 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10235 * lisp.h (fatal_error_signal_hook): Remove decl.
10236 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10237
f44bd759
PE
10238 * editfns.c: Move a (normally-unused) function to its only use.
10239 * editfns.c, lisp.h (get_operating_system_release): Remove.
10240 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10241 worth the hassle of breaking this out.
10242
b532497d
PE
10243 * xterm.c: Make symbols static if they're not exported.
10244 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10245 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10246 (x_destroy_window, x_delete_display):
10247 Now static.
10248 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10249 (x_mouse_leave): Remove; unused.
10250 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10251 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10252 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10253 Remove decls.
10254 (x_mouse_leave): Declare only if WINDOWSNT.
10255 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10256 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10257 USE_X_TOOLKIT.
10258
1675728f
PE
10259 * ftxfont.c: Make symbols static if they're not exported.
10260 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10261 HAVE_FREETYPE.
10262 * font.h (ftxfont_driver): Likewise.
10263
e4cebfca
PE
10264 * xfns.c: Make symbols static if they're not exported.
10265 (x_last_font_name, x_display_info_for_name):
10266 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10267 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10268 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10269 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10270 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10271 (last_show_tip_args): Now static.
10272 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10273 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10274 (x_screen_planes): Remove; unused.
10275 * dispextern.h (x_screen_planes): Remove decl.
10276
5bf46f05
PE
10277 * dispnew.c: Make symbols static if they're not exported.
10278 * dispextern.h (redraw_garbaged_frames, scrolling):
10279 (increment_row_positions): Remove.
10280 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10281 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10282 Now static.
10283 (redraw_garbaged_frames): Remove; unused.
10284
435f4c28
PE
10285 * xfaces.c: Make symbols static if they're not exported.
10286 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10287 Remove decls.
10288 * xterm.h (defined_color): Remove decls.
10289 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10290 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10291 (menu_face_changed_default, defined_color, free_realized_face):
10292 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10293 (ascii_face_of_lisp_face): Remove; unused.
10294
8524aef3
PE
10295 * xdisp.c: Make symbols static if they're not exported.
10296 * dispextern.h (scratch_glyph_row, window_box_edges):
10297 (glyph_to_pixel_coords, set_cursor_from_row):
10298 (get_next_display_element, set_iterator_to_next):
10299 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10300 (show_mouse_face): Remove decls
10301 * frame.h (message_buf_print): Likewise.
10302 * lisp.h (pop_message, set_message, check_point_in_composition):
10303 Likewise.
10304 * xterm.h (set_vertical_scroll_bar): Likewise.
10305 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10306 (message_buf_print, scratch_glyph_row, displayed_buffer):
10307 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10308 (get_next_display_element, show_mouse_face, window_box_edges):
10309 (frame_to_window_pixel_xy, check_point_in_composition):
10310 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10311 (glyph_to_pixel_coords): Remove; unused.
10312
16390cd2
PE
10313 * dired.c (file_name_completion): Now static.
10314
10315 * dbusbind.c (xd_in_read_queued_messages): Now static.
10316
a25f4dfa
PE
10317 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10318 * data.c (circular_list_error): Remove.
10319
14a9c8df
PE
10320 * commands.h (last_point_position, last_point_position_buffer):
10321 (last_point_position_window): Remove decls.
10322 * keyboard.c: Make these variables static.
10323
04f2d78b
CB
10324 * coding.h (coding, code_convert_region, encode_coding_gap):
10325 Remove decls.
74ab6df5
PE
10326 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10327 (iso_code_class, detect_coding, code_convert_region): Now static.
10328 (encode_coding_gap): Remove; unused.
10329
38dfbee1
PE
10330 * chartab.c (chartab_chars, chartab_bits): Now static.
10331
a2cb4e63
PE
10332 * charset.h (charset_iso_8859_1): Remove decl.
10333 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10334 Now static.
10335
127198fd
PE
10336 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10337 * ccl.c (Vccl_program_table): Now static.
10338 (check_ccl_update): Remove; unused.
10339
d85b608f
PE
10340 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10341 * category.h: ... from here.
10342 * category.c (check_category_table, set_category_set): Now static.
10343
31cd66f3
PE
10344 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10345 * lisp.h: Remove these decls.
10346
c358e587
PE
10347 * buffer.c (buffer_count): Remove unused var.
10348
e78aecca
PE
10349 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10350 so that it's not optimized away.
10351 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10352 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10353 exported only to the debugger.
10354
e192d7d3 10355 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10356 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10357
92470028
PE
10358 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10359 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10360 was inaccessible from Lisp.
10361 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10362 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10363
244ed907
PE
10364 alloc.c: Import and export fewer symbols, and remove unused items.
10365 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10366 is defined.
10367 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10368 it's not optimized away by whole-program optimization.
10369 (message_enable_multibyte, free_misc): Remove.
10370 (catchlist, handlerlist, mark_backtrace):
10371 Declare only if BYTE_MARK_STACK.
10372 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10373 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10374 (message_enable_multibyte): Remove decl.
10375 (free_misc, interval_free_list, float_block, float_block_index):
10376 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10377 (cons_free_list, last_marked_index):
10378 Now static.
10379 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10380 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10381 (mark_backtrace): Define only if BYTE_MARK_STACK.
10382 * xdisp.c (message_enable_multibyte): Now static.
10383
61c2b50e 10384 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10385 This makes it easier for human readers (and static analyzers)
10386 to see whether these variables are used from other modules.
10387 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10388 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10389 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10390 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10391 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10392 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10393 * xmenu.c, xselect.c:
10394 Declare Q* vars static if they are not used in other modules.
10395 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10396 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10397 Remove decls of unexported vars.
10398 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10399
95c82688
PE
10400 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10401
16a97296
PE
10402 Make Emacs functions such as Fatom 'static' by default.
10403 This makes it easier for human readers (and static analyzers)
10404 to see whether these functions can be called from other modules.
10405 DEFUN now defines a static function. To make the function external
10406 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10407 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10408 (Finit_image_library):
16a97296
PE
10409 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10410 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10411 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10412 Remove decls, since these functions are now static.
10413 (Funintern, Fget_internal_run_time): New decls, since these functions
10414 were already external.
95c82688 10415
16a97296
PE
10416 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10417 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10418 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10419 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10420 * keyboard.c, keymap.c, lread.c:
10421 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10422 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10423 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10424 Mark functions with DEFUE instead of DEFUN,
10425 if they are used in other modules.
10426 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10427 decls for now-static functions.
10428 * buffer.h (Fdelete_overlay): Remove decl.
10429 * callproc.c (Fgetenv_internal): Mark as internal.
10430 * composite.c (Fremove_list_of_text_properties): Remove decl.
10431 (Fcomposition_get_gstring): New forward static decl.
10432 * composite.h (Fcomposite_get_gstring): Remove decl.
10433 * dired.c (Ffile_attributes): New forward static decl.
10434 * doc.c (Fdocumntation_property): New forward static decl.
10435 * eval.c (Ffetch_bytecode): New forward static decl.
10436 (Funintern): Remove extern decl; now in .h file where it belongs.
10437 * fileio.c (Fmake_symbolic_link): New forward static decl.
10438 * image.c (Finit_image_library): New forward static decl.
10439 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10440 * intervals.h (Fprevious_property_change):
10441 (Fremove_list_of_text_properties): Remove decls.
10442 * keyboard.c (Fthis_command_keys): Remove decl.
10443 (Fcommand_execute): New forward static decl.
10444 * keymap.c (Flookup_key): New forward static decl.
10445 (Fcopy_keymap): Now static.
10446 * keymap.h (Flookup_key): Remove decl.
10447 * process.c (Fget_process): New forward static decl.
10448 (Fprocess_datagram_address): Mark as internal.
10449 * syntax.c (Fsyntax_table_p): New forward static decl.
10450 (skip_chars): Remove duplicate decl.
10451 * textprop.c (Fprevious_property_change): New forward static decl.
10452 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10453 Now internal.
10454 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10455 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10456
785bbd42
PE
10457 * editfns.c (Fformat): Remove unreachable code.
10458
8b913b57
AS
104592011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10460
10461 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10462 change. (Bug#8496)
10463
a6744a35
EZ
104642011-04-13 Eli Zaretskii <eliz@gnu.org>
10465
10466 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10467 when at ZV. (Bug#8487)
10468
e7974947
AS
104692011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10470
baad03f0
AS
10471 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10472 (Bug#8437)
10473 * keyboard.c (parse_tool_bar_item): Likewise.
10474 * sound.c (sound_cleanup, alsa_close): Likewise.
10475 * termcap.c (tgetent): Likewise.
10476 * xfns.c (x_default_font_parameter): Likewise.
10477 * xsettings.c (read_and_apply_settings): Likewise.
10478
e7974947
AS
10479 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10480 (overrun_check_free): Protoize.
10481
28272684
PE
104822011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10483
10484 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10485 since callers should never pass a negative size.
10486 Change the signature to match that of plain 'read' and 'write'; see
10487 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10488 * lisp.h: Update prototypes of emacs_write and emacs_read.
10489
11997c76
EZ
104902011-04-11 Eli Zaretskii <eliz@gnu.org>
10491
10492 * xdisp.c (redisplay_window): Don't try to determine the character
10493 position of the scroll margin if the window start point w->startp
e896f03c 10494 is outside the buffer's accessible region. (Bug#8468)
11997c76 10495
8a2cbd72
EZ
104962011-04-10 Eli Zaretskii <eliz@gnu.org>
10497
10498 Fix write-region and its subroutines for buffers > 2GB.
10499 * fileio.c (a_write, e_write): Modify declaration of arguments and
10500 local variables to support buffers larger than 2GB.
10501 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10502
10503 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10504 argument, local variables, and return value.
10505
10506 * lisp.h: Update prototypes of emacs_write and emacs_read.
10507
10508 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10509
4073e537 105102011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10511
1ebfdcb6
PE
10512 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10513
b2ded58d
PE
10514 Fix more problems found by GCC 4.6.0's static checks.
10515
7d66342c
PE
10516 * xdisp.c (vmessage): Use a better test for character truncation.
10517
bbf47d44
PE
10518 * charset.c (load_charset_map): <, not <=, for optimization,
10519 and to avoid potential problems with integer overflow.
9248994d 10520 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10521 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10522 * editfns.c (Fformat): Likewise.
1e69125e 10523 * syntax.c (skip_chars): Likewise.
3befa583 10524
e3019616
PE
10525 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10526 This also lets GCC 4.6.0 generate slightly better loop code.
10527
becfa255
PE
10528 * callint.c (Fcall_interactively): <, not <=, for optimization.
10529 (Fcall_interactively): Count the number of arguments produced,
10530 not the number of arguments given. This is simpler and lets GCC
10531 4.6.0 generate slightly better code.
10532
dae0cd48
PE
10533 * ftfont.c: Distingish more carefully between FcChar8 and char.
10534 The previous code passed unsigned char * to a functions like
10535 strlen and xstrcasecmp that expect char *, which does not
10536 conform to the C standard.
10537 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10538 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10539 char * when the C standard requires it.
10540
76032d70
PE
10541 * keyboard.c (read_char): Remove unused var.
10542
eb3f1cc8
PE
10543 * eval.c: Port to Windows vsnprintf (Bug#8435).
10544 Include <limits.h>.
10545 (SIZE_MAX): Define if the headers do not.
10546 (verror): Do not give up if vsnprintf returns a negative count.
10547 Instead, grow the buffer. This ports to Windows vsnprintf, which
10548 does not conform to C99. Problem reported by Eli Zaretskii.
10549 Also, simplify the allocation scheme, by avoiding the need for
10550 calling realloc, and removing the ALLOCATED variable.
10551
70476b54
PE
10552 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10553
12020a9e
PE
10554 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10555 But keep the doprint source code for now, as we might revamp it
10556 and use it again (Bug#8435).
ea6c7ae6
PE
10557 * lisp.h (doprnt): Remove.
10558 * Makefile.in (base_obj): Remove doprnt.o.
10559 * deps.mk (doprnt.o): Remove.
10560
5fdb398c
PE
10561 error: Print 32- and 64-bit integers portably (Bug#8435).
10562 Without this change, on typical 64-bit hosts error ("...%d...", N)
10563 was used to print both 32- and 64-bit integers N, which relied on
10564 undefined behavior.
61bdb816 10565 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10566 * lisp.h (error, verror): Mark as printf-like functions.
10567 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10568 Report overflow in size calculations when allocating printf buffer.
10569 Do not truncate output string at its first null byte.
10570 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10571 Truncate the output at a character boundary, since vsnprintf does not
10572 do that.
10573 * charset.c (check_iso_charset_parameter): Convert internal
10574 character to string before calling 'error', since %c now has the
10575 printf meaning.
10576 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10577 overflow when computing char to be passed to 'error'. Do not
10578 pass Lisp_Object to 'error'; pass the integer instead.
10579 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10580 formatted with plain %d.
10581
b189fa66
PE
10582 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10583
bff87ef0
PE
10584 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10585
7e2cac20
PE
10586 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10587
ce4d90b5
PE
10588 * xterm.c (x_catch_errors): Remove duplicate declaration.
10589
266c9547
PE
10590 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10591
79c49ad2
PE
10592 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10593
368f4090
JM
105942011-04-10 Jim Meyering <meyering@redhat.com>
10595
10596 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10597 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10598 return ssize_t not "int", and use size_t as the buffer length.
10599 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10600 * gnutls.h: Update declarations.
10601 * process.c (read_process_output): Use ssize_t, to match.
10602 (send_process): Likewise.
10603
a32d4040
CY
106042011-04-09 Chong Yidong <cyd@stupidchicken.com>
10605
10606 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10607
8546720e 106082011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10609
04f2d78b
CB
10610 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10611 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10612
8546720e
GM
10613 * xterm.c (handle_one_xevent):
10614 * xmenu.c (create_and_show_popup_menu):
10615 * xselect.c (x_decline_selection_request)
10616 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10617
0a2f5c1a 106182011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10619
10620 Fix some uses of `int' instead of EMACS_INT.
10621 * search.c (string_match_1, fast_string_match)
10622 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10623 (scan_buffer, find_next_newline_no_quit)
10624 (find_before_next_newline, search_command, Freplace_match)
10625 (Fmatch_data): Make some `int' variables be EMACS_INT.
10626
10627 * xdisp.c (display_count_lines): 3rd argument and return value now
10628 EMACS_INT. All callers changed.
10629 (pint2hrstr): Last argument is now EMACS_INT.
10630
10631 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10632 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10633 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10634 (decode_coding_utf_16, decode_coding_emacs_mule)
10635 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10636 (decode_coding_ccl, decode_coding_charset)
10637 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10638 (decode_coding_iso_2022, decode_coding_emacs_mule)
10639 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10640 <char_offset, last_offset>: Declare EMACS_INT.
10641 (encode_coding_utf_8, encode_coding_utf_16)
10642 (encode_coding_emacs_mule, encode_invocation_designation)
10643 (encode_designation_at_bol, encode_coding_iso_2022)
10644 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10645 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10646 Declare EMACS_INT.
10647 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10648 (encode_invocation_designation): Last argument P_NCHARS is now
10649 EMACS_INT.
10650 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10651 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10652
10653 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10654 All users changed.
10655
10656 * ccl.c (Fccl_execute_on_string): Declare some variables
10657 EMACS_INT.
10658
8546720e 106592011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10660
10661 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10662
4e19a977
CS
106632011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10664
10665 * process.c (Fformat_network_address): Doc fix.
10666
87302331
R
106672011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10668
ee7683eb 10669 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10670
cbb59342
CY
106712011-04-08 Chong Yidong <cyd@stupidchicken.com>
10672
10673 * keyboard.c (read_char): Call Lisp function help-form-show,
10674 instead of using internal_with_output_to_temp_buffer.
10675 (Qhelp_form_show): New var.
e0d38eeb 10676 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10677
10678 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10679
10680 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10681
e67a13ab
CY
106822011-04-06 Chong Yidong <cyd@stupidchicken.com>
10683
04f2d78b
CB
10684 * process.c (Flist_processes): Remove to Lisp.
10685 (list_processes_1): Delete.
e67a13ab 10686
973f782d
EZ
106872011-04-06 Eli Zaretskii <eliz@gnu.org>
10688
7c106b1e
EZ
10689 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10690
973f782d
EZ
10691 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10692
41cf7d1a 106932011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10694
ca23cc88
PE
10695 Fix more problems found by GCC 4.6.0's static checks.
10696
f390e2d5
PE
10697 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10698
42eea0d0
PE
10699 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10700
b69769da 10701 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10702
f9541e84
PE
10703 * xdisp.c (vmessage): Mark as a printf-like function.
10704
13841b55
PE
10705 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10706
c136c10f
PE
10707 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10708
5e2d4a30
PE
10709 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10710 printf-like functions.
10711 (tiff_load): Add casts to remove these marks before passing them
10712 to system-supplied API.
10713
583f48b9
PE
10714 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10715
b25d760e
PE
10716 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10717 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10718 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10719 directly, rather than having caller test rule sign. This avoids
10720 some unnecessary tests.
10721 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10722 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10723 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10724
bc7b6697 10725 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10726 (xfont_open): Avoid unnecessary tests.
bc7b6697 10727
27ccc379
PE
10728 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10729
dcd5c89a
PE
10730 * composite.h, composite.c (composition_gstring_put_cache):
10731 Use EMACS_INT, not int, for length.
10732
b13a45c6
PE
10733 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10734 breaking out part of COMPOSITION_DECODE_RULE.
10735 (COMPOSITION_DECODE_RULE): Use it.
10736 * composite.c (get_composition_id): Remove unused local vars,
10737 by using the new macro.
10738
1e792e4d
PE
10739 * textprop.c (set_text_properties_1): Change while to do-while,
10740 since the condition is always true at first.
10741
dc6c6455 10742 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10743 (interval_deletion_adjustment): Return unsigned value.
10744 All uses changed.
dc6c6455 10745
aba7731a
PE
10746 * process.c (list_processes_1, create_pty, read_process_output):
10747 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10748 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10749 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10750 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10751 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10752
fdfc4bf3
PE
10753 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10754
fca8fe46 10755 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10756 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10757
06a0259a 10758 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10759 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10760 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10761
e7b9e80f
PE
10762 * print.c (print_error_message): Avoid int overflow.
10763
56201685
PE
10764 * font.c (font_list_entities): Redo for clarity,
10765 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10766
78834453 10767 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10768 (font_score): Avoid potential overflow in diff calculation.
78834453 10769
0bc0b309 10770 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10771 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10772
e610eaca
PE
10773 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10774
b895abce
PE
10775 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10776 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10777 can always succeed if overflow has undefined behavior.
10778
1f1d9321 10779 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10780 (wordify): Omit three unnecessary tests.
1f1d9321 10781
c59478bc
PE
10782 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10783 All callers changed. This avoids the need for an unused var.
10784
79b73827
PE
10785 * casefiddle.c (casify_region): Remove var that is set but not used.
10786
a4db5dfe
PE
10787 * dired.c (file_name_completion): Remove var that is set but not used.
10788
43aae36e
PE
10789 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10790
2a47c44d 10791 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10792 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10793
a37c69bf
PE
10794 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10795 Check for integer overflow on size calculations.
10796
328ab8e7
PE
10797 * buffer.c (Fprevious_overlay_change): Remove var that is set
10798 but not used.
10799
e5a2a5cb
PE
10800 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10801 Remove vars that are set but not used.
8d84a6eb 10802 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10803 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10804
a60e5f68
PE
10805 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10806
f661cb61 10807 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10808 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10809
f0397f5a
PE
10810 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10811 that are set but not used.
10812
8664db06 10813 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10814 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10815
6abdaa4a
PE
10816 * xselect.c (x_get_local_selection, x_handle_property_notify):
10817 Remove vars that are set but not used.
10818
0ce7538d 10819 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10820 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10821
9ae848fc
PE
10822 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10823 Remove var that is set but not used.
0b918413
PE
10824 (scroll_bar_windows_size): Now size_t, not int.
10825 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10826 Check for overflow.
9ae848fc 10827
a5a62657
PE
10828 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10829 (map_tty_color) [!defined MSDOS]: Likewise.
10830
5c5cdd39
PE
10831 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10832
66ebf983
PE
10833 * coding.c: Remove vars that are set but not used.
10834 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10835 All callers changed.
10836 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10837 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10838 (decode_coding_charset): Remove vars that are set but not used.
10839
1be4d761
PE
10840 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10841 that is set but not used.
10842
47553fa8
PE
10843 * print.c (print_object): Remove var that is set but not used.
10844
1f7196bf 10845 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10846 The gnulib version avoids calling malloc in the usual case,
10847 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10848 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10849 * filelock.c (current_lock_owner): Likewise.
10850 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10851 * sysdep.c: Include allocator.h, careadlinkat.h.
10852 (emacs_no_realloc_allocator): New static constant.
10853 (emacs_readlink): New function.
fdb61804
PE
10854 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10855 ../lib/careadlinkat.h.
d1fdcab7 10856
f84c17c7
SM
108572011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10858
10859 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10860 first non-nil return value).
10861
ef3862ad
JD
108622011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10863
10864 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10865 if not defined (Bug#8403).
10866
376a7006
JB
108672011-04-02 Juanma Barranquero <lekktu@gmail.com>
10868
10869 * xdisp.c (display_count_lines): Remove parameter `start',
10870 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10871 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10872 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10873 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10874 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10875 and thereabouts. All callers changed.
10876 (get_per_char_metric): Remove parameter `f', unused since
10877 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10878
6ca3801d
JM
108792011-04-02 Jim Meyering <meyering@redhat.com>
10880
10881 do not dereference NULL upon failed strdup
10882 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10883 (ns_get_family): Likewise.
10884
d8e2b5ba
JB
108852011-04-02 Juanma Barranquero <lekktu@gmail.com>
10886
10887 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10888
8c74fcbd
JD
108892011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10890
10891 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10892 later (Bug#8403).
10893
7200d79c
SM
108942011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10895
03408648 10896 Add lexical binding.
7200d79c 10897
03408648
SM
10898 * window.c (Ftemp_output_buffer_show): New fun.
10899 (Fsave_window_excursion):
10900 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10901
10902 * lread.c (lisp_file_lexically_bound_p): New function.
10903 (Fload): Bind Qlexical_binding.
10904 (readevalloop): Remove `evalfun' arg.
10905 Bind Qinternal_interpreter_environment.
10906 (Feval_buffer): Bind Qlexical_binding.
10907 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10908 Mark as dynamic.
10909 (syms_of_lread): Declare `lexical-binding'.
10910
10911 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10912
10913 * keyboard.c (eval_dyn): New fun.
10914 (menu_item_eval_property): Use it.
ca105506
SM
10915
10916 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10917
03408648
SM
10918 * fns.c (concat, mapcar1): Accept byte-code-functions.
10919
10920 * eval.c (Fsetq): Handle lexical vars.
10921 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10922 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10923 (FletX, Flet): Obey lexical binding.
10924 (Fcommandp): Handle closures.
10925 (Feval): New `lexical' arg.
10926 (eval_sub): New function extracted from Feval. Use it almost
10927 everywhere where Feval was used. Look up vars in lexical env.
10928 Handle closures.
10929 (Ffunctionp): Move from subr.el.
10930 (Ffuncall): Handle closures.
10931 (apply_lambda): Remove `eval_flags'.
10932 (funcall_lambda): Handle closures and new byte-code-functions.
10933 (Fspecial_variable_p): New function.
10934 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10935 but without exporting it to Lisp.
23aba0ea 10936
23aba0ea 10937 * doc.c (Fdocumentation, store_function_docstring):
03408648 10938 * data.c (Finteractive_form): Handle closures.
23aba0ea 10939
03408648
SM
10940 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10941 interactive spec.
ba83908c 10942
04f2d78b
CB
10943 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10944 New byte-codes.
03408648
SM
10945 (exec_byte_code): New function extracted from Fbyte_code to handle new
10946 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10947
03408648 10948 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10949
03408648 10950 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10951
e2abce01
JB
109522011-03-31 Juanma Barranquero <lekktu@gmail.com>
10953
10954 * xdisp.c (redisplay_internal): Fix prototype.
10955
63696a73 109562011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10957
63696a73 10958 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10959 (try_scrolling): Use it when setting scroll_limit.
10960 Limit scrolling to 100 screen lines.
63696a73
EZ
10961 (redisplay_window): Even when falling back on "recentering",
10962 position point in the window according to scroll-conservatively,
10963 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10964
10965 (try_scrolling): When point is above the window, allow searching
10966 as far as scroll_max, or one screenful, to compute vertical
10967 distance from PT to the scroll margin position. This prevents
10968 try_scrolling from unnecessarily failing when
10969 scroll-conservatively is set to a value slightly larger than the
10970 window height. Clean up the case of PT below the margin at bottom
10971 of window: scroll_max can no longer be INT_MAX. When aggressive
10972 scrolling is in use, don't let point enter the opposite scroll
10973 margin as result of the scroll.
10974 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10975 threshold of 100 lines for never-recentering scrolling.
10976
e4cc2dfc
JB
109772011-03-31 Juanma Barranquero <lekktu@gmail.com>
10978
10979 * dispextern.h (move_it_by_lines):
10980 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10981 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10982 (message_log_check_duplicate): Remove parameters `prev_bol' and
10983 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10984 (redisplay_internal): Remove parameter `preserve_echo_area',
10985 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10986
10987 * indent.c (Fvertical_motion):
10988 * window.c (window_scroll_pixel_based, Frecenter):
10989 Don't pass `need_y_p' to `move_it_by_lines'.
10990
1c470562
SM
109912011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10992
44f230aa
SM
10993 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10994 steal a few bits to be more compact.
10995 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10996 Remove unneeded casts.
10997
1c470562
SM
10998 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10999
888adce9
ZK
110002011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11001
11002 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11003 binding" message (bug#7967).
11004
f838ed7b
PE
110052011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11006
77861b95
PE
11007 Fix more problems found by GCC 4.6.0's static checks.
11008
de6dbc14
PE
11009 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11010 Remove unused local var.
11011
f838ed7b
PE
11012 * editfns.c (Fmessage_box): Remove unused local var.
11013
792c7b2b
PE
11014 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11015 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11016 Omit unused local vars.
c499e557 11017 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11018 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11019 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11020 Omit unused local var.
11021
ba0165e1
PE
11022 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11023 Don't assume string length fits in int.
32ad8845 11024 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11025 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11026
3c59b4c9
PE
11027 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11028 instead of alloca (Bug#8344).
11029
a3eed478 11030 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11031 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11032
eb4d412d
PE
11033 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11034
1658b401
PE
11035 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11036 concerns.
11037
11038 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11039
11040 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11041
9a2c6e05
PE
11042 * keyboard.c (syms_of_keyboard): Use the same style as later
11043 in this function when indexing through an array. This also
11044 works around GCC bug 48267.
11045
03d0a109
PE
11046 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11047
44f730c8
PE
11048 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11049
fe75f926
PE
11050 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11051 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11052
ffa8c828
PE
11053 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11054 This avoids undefined behavior on integer overflow, and is a bit
11055 more convenient anyway since it is compared to a size_t variable.
11056
c5101a77
PE
11057 Variadic C functions now count arguments with size_t, not int.
11058 This avoids an unnecessary limitation on 64-bit machines, which
11059 caused (substring ...) to crash on large vectors (Bug#8344).
11060 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11061 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11062 All variadic functions and their callers changed accordingly.
c5101a77
PE
11063 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11064 * data.c (arith_driver, float_arith_driver): Likewise.
11065 * editfns.c (general_insert_function): Likewise.
11066 * eval.c (struct backtrace.nargs, interactive_p)
11067 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11068 (funcall_lambda, mark_backtrace): Likewise.
11069 * fns.c (concat): Likewise.
11070 * frame.c (x_set_frame_parameters): Likewise.
11071 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11072 0 if not found, not -1. All callers changed.
11073
dd3f25f7
PE
11074 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11075 (stack_copy_size): Now size_t, not int.
11076 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11077
461c2ab9
JB
110782011-03-28 Juanma Barranquero <lekktu@gmail.com>
11079
11080 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11081 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11082 All callers changed.
11083
11084 * lisp.h (multibyte_char_to_unibyte):
11085 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11086 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11087 * character.h (CHAR_TO_BYTE8):
11088 * cmds.c (internal_self_insert):
11089 * editfns.c (general_insert_function):
11090 * keymap.c (push_key_description):
11091 * search.c (Freplace_match):
11092 * xdisp.c (message_dolog, set_message_1): All callers changed.
11093
f6d62986
SM
110942011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11095
11096 * keyboard.c (safe_run_hook_funcall): New function.
11097 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11098 don't set the hook to nil, but remove the offending function instead.
11099 (Qcommand_hook_internal): Remove, unused.
11100 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11101 Vcommand_hook_internal.
11102
11103 * eval.c (enum run_hooks_condition): Remove.
11104 (funcall_nil, funcall_not): New functions.
11105 (run_hook_with_args): Call each function through a `funcall' argument.
11106 Remove `cond' argument, now redundant.
11107 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11108 (Frun_hook_with_args_until_failure): Adjust accordingly.
11109 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11110
1db5b1ad
JB
111112011-03-28 Juanma Barranquero <lekktu@gmail.com>
11112
11113 * dispextern.h (string_buffer_position): Remove declaration.
11114
11115 * print.c (strout): Remove parameter `multibyte', unused since
11116 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11117
11118 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11119 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11120 All callers changed.
11121
11122 * w32.c (_wsa_errlist): Use braces for struct initializers.
11123
11124 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11125 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11126 All callers changed.
11127 (string_buffer_position): Likewise. Also, make static (it's never
11128 used outside xdisp.c).
11129 (cursor_row_p): Remove parameter `w', unused since
11130 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11131 (decode_mode_spec): Remove parameter `precision', introduced during
11132 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11133 All callers changed.
11134
5ffb62aa
JD
111352011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11136
11137 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11138
461c2ab9 111392011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11140
11141 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11142 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11143 (ns_update_auto_hide_menu_bar): New functions.
11144 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11145 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11146 ns_constrain_all_frames.
11147 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11148 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11149
5c380ffb
JD
111502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11151
11152 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11153
9af30bdf
GM
111542011-03-27 Glenn Morris <rgm@gnu.org>
11155
11156 * syssignal.h: Replace RETSIGTYPE with void.
11157 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11158 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11159 Replace SIGTYPE with void everywhere.
11160 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11161 * s/template.h (SIGTYPE): Remove commented out definition.
11162
e2abce01
JB
111632011-03-26 Eli Zaretskii <eliz@gnu.org>
11164
11165 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11166 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11167
f868cd8a
JB
111682011-03-26 Juanma Barranquero <lekktu@gmail.com>
11169
59eb0929
JB
11170 * w32.c (read_unc_volume): Use parameter `henum', instead of
11171 global variable `wget_enum_handle'.
11172
11173 * keymap.c (describe_vector): Remove parameters `indices' and
11174 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11175 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11176
f868cd8a
JB
11177 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11178
11179 * keyboard.c (timer_check): Remove parameter `do_it_now',
11180 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11181 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11182 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11183
11184 * keyboard.c (read_char):
11185 * w32menu.c (w32_menu_display_help):
11186 * xmenu.c (show_help_event, menu_help_callback):
11187 Adjust calls to `show_help_echo'.
11188
11189 * gtkutil.c (xg_maybe_add_timer):
11190 * keyboard.c (readable_events):
11191 * process.c (wait_reading_process_output):
11192 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11193
11194 * insdel.c (adjust_markers_gap_motion):
11195 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11196 (gap_left, gap_right): Don't call it.
11197
2ecf6fdb
CY
111982011-03-25 Chong Yidong <cyd@stupidchicken.com>
11199
11200 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11201 incurred during fontification.
11202
6b1f9ba4
JB
112032011-03-25 Juanma Barranquero <lekktu@gmail.com>
11204
11205 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11206 (DEFVAR_PER_BUFFER): Don't pass it.
11207
11208 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11209 (scrolling_window): Don't pass it.
11210
0f4a96b5
JB
112112011-03-25 Juanma Barranquero <lekktu@gmail.com>
11212
11213 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11214
11215 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11216 and `suffix'.
11217 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11218 of variables specific to SELinux and computation of `encoded_absname'.
11219
11220 * image.c (XPutPixel): Remove unused variable `height'.
11221
11222 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11223
11224 * unexw32.c (get_section_info): Remove unused variable `section'.
11225
11226 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11227 (system_process_attributes): Remove unused variable `sess'.
11228 (sys_read): Remove unused variable `err'.
11229
11230 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11231 (w32_wnd_proc): Remove unused variable `isdead'.
11232 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11233 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11234 (x_create_tip_frame): Remove unused variable `tem'.
11235
11236 * w32inevt.c (w32_console_read_socket):
11237 Remove unused variable `no_events'.
11238
11239 * w32term.c (x_draw_composite_glyph_string_foreground):
11240 Remove unused variable `width'.
11241
1149507c
JB
112422011-03-24 Juanma Barranquero <lekktu@gmail.com>
11243
11244 * w32term.c (x_set_glyph_string_clipping):
11245 Don't pass uninitialized region to CombineRgn.
11246
9c88f339
JB
112472011-03-23 Juanma Barranquero <lekktu@gmail.com>
11248
11249 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11250 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11251 (Fx_close_connection): Remove unused variable `i'.
11252
11253 * w32font.c (w32font_draw): Return number of glyphs.
11254 (w32font_open_internal): Remove unused variable `i'.
11255 (w32font_driver): Add missing initializer.
11256
11257 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11258 (fill_in_menu): Remove unused variable `items_added'.
11259
11260 * w32term.c (last_mouse_press_frame): Remove static global variable.
11261 (w32_clip_to_row): Remove unused variable `f'.
11262 (x_delete_terminal): Remove unused variable `i'.
11263
11264 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11265 (NOTHING): Remove unused static global variable.
11266 (uniscribe_check_otf): Remove unused variable `table'.
11267 (uniscribe_font_driver): Add missing initializers.
11268
dee091a3
JD
112692011-03-23 Julien Danjou <julien@danjou.info>
11270
11271 * term.c (Fsuspend_tty, Fresume_tty):
11272 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11273 * window.c (temp_output_buffer_show):
11274 * insdel.c (signal_before_change):
11275 * frame.c (Fhandle_switch_frame):
11276 * fileio.c (Fdo_auto_save):
11277 * emacs.c (Fkill_emacs):
11278 * editfns.c (save_excursion_restore):
11279 * cmds.c (internal_self_insert):
11280 * callint.c (Fcall_interactively):
11281 * buffer.c (Fkill_all_local_variables):
11282 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11283 Use Frun_hooks.
0f4a96b5 11284 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11285 unconditionally since it does the check itself.
dee091a3 11286
2c520ab5 112872011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11288
c9c49752
PE
11289 Fix more problems found by GCC 4.5.2's static checks.
11290
8abc3f12
PE
11291 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11292 the first time through the loop, since we know p0 < p1 then.
11293 This also avoids a gcc -Wstrict-overflow warning.
11294
a2d26660
PE
11295 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11296 leading to a memory leak, possible in functions like
11297 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11298 of objects (Bug#8318).
a2d26660 11299
916c72e9
PE
11300 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11301 that could (at least in theory) be that large.
11302
19ab8a18
PE
11303 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11304 This is less likely to overflow, and avoids undefined behavior if
11305 overflow does occur. All callers changed. Use strtoul to scan
11306 for the unsigned long integer.
b7cbbd6f
PE
11307 (pint2hrstr): Simplify and tune code slightly.
11308 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11309
f0641eff
PE
11310 * scroll.c (do_scrolling): Work around GCC bug 48228.
11311 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11312
7f650bb9
PE
11313 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11314 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11315 (validate_x_resource_name): Simplify count usage.
11316 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11317
37dd57d1
PE
11318 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11319 fail (Bug#8306).
81e56e61 11320
699979fc 11321 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11322
401bf9b4
PE
11323 * process.c (Fmake_network_process): Use socklen_t, not int,
11324 where POSIX says socklen_t is required in portable programs.
11325 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11326 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11327 (Fmake_network_process, server_accept_connection):
11328 (wait_reading_process_output, read_process_output):
11329 Likewise.
11330
b93aacde
PE
11331 * process.c: Rename or move locals to avoid shadowing.
11332 (list_processes_1, Fmake_network_process):
11333 (read_process_output_error_handler, exec_sentinel_error_handler):
11334 Rename or move locals.
4dc343ee 11335 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11336 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11337 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11338 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11339 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11340
af8a867c 11341 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11342 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11343 Include tparam.h instead, since it declares them.
af8a867c
PE
11344 * cm.h (PC): Remove extern decl; tparam.h now does this.
11345 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11346 * terminfo.c: Include tparam.h, to check interfaces.
11347 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11348 (tparam): Adjust signature to match interface in tparam.h;
11349 this removes some undefined behavior. Check that outstring and len
11350 are zero, which they always are with Emacs.
11351 * tparam.h (PC, BC, UP): New extern decls.
11352
0248044d 11353 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11354 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11355
8ff096c1 11356 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11357 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11358 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11359 (ftfont_list): Remove unused local.
49eaafba
PE
11360 (get_adstyle_property, ftfont_pattern_entity):
11361 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11362 Rename locals to avoid shadowing.
8ff096c1 11363
e2be39f6
PE
11364 * xfont.c (xfont_list_family): Mark var as initialized.
11365
c9735e30
PE
11366 * xml.c (make_dom): Now static.
11367
8f5201ae
PE
11368 * composite.c (composition_compute_stop_pos): Rename local to
11369 avoid shadowing.
b246f932
PE
11370 (composition_reseat_it): Remove unused locals.
11371 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11372 (composition_update_it): Mark var as initialized.
11b61122
PE
11373 (find_automatic_composition): Mark vars as initialized,
11374 with a FIXME (Bug#8290).
8f5201ae 11375
760fbc2c
PE
11376 character.h: Rename locals to avoid shadowing.
11377 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11378 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11379 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11380 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11381 to avoid shadowing.
11382
ff08eb85
PE
11383 * textprop.c (property_change_between_p): Remove; unused.
11384
fc7bf025
PE
11385 * intervals.c (interval_start_pos): Now static.
11386
235d7abc
PE
11387 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11388
44f230aa
SM
11389 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11390 Rename locals to avoid shadowing.
3e7d6594 11391
50060332
PE
11392 * sound.c (wav_play, au_play, Fplay_sound_internal):
11393 Fix pointer signedness.
d01f234b 11394 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11395 (wav_play): Initialize a variable to 0, to prevent undefined
11396 behavior (Bug#8278).
50060332 11397
c4fc4e30
PE
11398 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11399
918436ed
PE
11400 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11401
c939f91b
PE
11402 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11403 clobbering (Bug#8298).
b9c7f648
PE
11404 * sysdep.c (sys_subshell): Likewise.
11405 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11406
6bd8c144
PE
11407 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11408 This should get cleaned up, so that child_setup has the
11409 same signature on all platforms.
11410
7710357c 11411 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11412 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11413
c59da222
CY
114142011-03-22 Chong Yidong <cyd@stupidchicken.com>
11415
11416 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11417 not to be necessary, and produces flickering.
11418
66b87493
GM
114192011-03-20 Glenn Morris <rgm@gnu.org>
11420
11421 * config.in: Remove file.
11422
45b6f6d5
JB
114232011-03-20 Juanma Barranquero <lekktu@gmail.com>
11424
11425 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11426 are now in src/globals.h.
11427 (syms_of_minibuf): Remove spurious & from previous change.
11428
cd394be1 114292011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11430
11431 * minibuf.c (completing-read-function): New variable.
11432 (completing-read-default): Rename from completing-read.
11433 (completing-read): Call completing-read-function.
11434
b14e3e21
CY
114352011-03-19 Juanma Barranquero <lekktu@gmail.com>
11436
11437 * xfaces.c (Fx_load_color_file):
11438 Read color file from absolute filename (bug#8250).
11439
f2b726e6
JB
114402011-03-19 Juanma Barranquero <lekktu@gmail.com>
11441
11442 * makefile.w32-in: Update dependencies.
11443
09f6ff02
EZ
114442011-03-17 Eli Zaretskii <eliz@gnu.org>
11445
11446 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11447
29a6015a
PE
114482011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11449
a3a6c54e
PE
11450 Fix more problems found by GCC 4.5.2's static checks.
11451
b766f867
PE
11452 * process.c (make_serial_process_unwind, send_process_trap):
11453 (sigchld_handler): Now static.
11454
be02381c
PE
11455 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11456 That way, the code declares only the vars that it needs.
11457 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11458 * s/cygwin.h (PTY_ITERATION): Likewise.
11459 * s/darwin.h (PTY_ITERATION): Likewise.
11460 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11461
57048744
PE
11462 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11463 * process.c (allocate_pty): Don't declare stb unless it's needed.
11464
7914961c 11465 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11466 (CONSTANTLIM): Remove; unused.
11467 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11468 Define only if needed.
7914961c 11469
b3967b18
PE
11470 * unexelf.c (unexec): Name an expression,
11471 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11472 Use a different way to cause a compilation error if anyone uses
11473 n rather than nn, a way that does not involve shadowing.
73366a00 11474 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11475
29a6015a
PE
11476 * deps.mk (unexalpha.o): Remove; unused.
11477
43cfc33e 11478 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11479 * unexec.h: New file.
ce701a33
PE
11480 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11481 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11482 Depend on unexec.h.
11483 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11484 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11485 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11486 Change as necessary to match prototype in unexec.h.
ce701a33 11487
01f44d5a
PE
11488 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11489 shadowing.
4f63c6bb 11490 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11491
a6670b0b
PE
11492 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11493 Rename locals to avoid shadowing.
11494
cef2010d 11495 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11496 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11497
d4d7173a
PE
11498 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11499
f08b802a
PE
11500 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11501 warning when compiling print.c.
11502
3ddb0639
PE
11503 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11504 instead of using an uninitialized var.
5ad03b97 11505 (font_sort_entities): Mark var as initialized.
3ddb0639 11506
170a2692
PE
11507 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11508
e663c700
PE
11509 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11510 pointers to constants.
89bc529a 11511 (font_parse_fcname): Remove unused vars.
7b81e2d0 11512 (font_delete_unmatched): Now static.
ea838e10 11513 (font_get_spec): Remove; unused.
13a547c6
PE
11514 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11515 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11516 Rename or move locals to avoid shadowing.
e663c700 11517
2a80c887 11518 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11519 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11520
1384fa33 11521 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11522 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11523
8b2c52e9
PE
11524 * alloc.c (mark_backtrace): Move decl from here ...
11525 * lisp.h: ... to here, so that it can be checked.
11526
475545b5 11527 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11528 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11529 (lisp_indirect_variable): Name an expression,
11530 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11531 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11532
b1349114 11533 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11534 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11535 Use const pointer when appropriate.
b1349114 11536
a2928364
PE
11537 * lisp.h (get_system_name, get_operating_system_release):
11538 Move decls here, to check interfaces.
11539 * process.c (get_operating_system_release): Move decl to lisp.h.
11540 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11541 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11542 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11543 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11544 (Fformat_time_string, Fencode_time, Finsert_char):
11545 (Ftranslate_region_internal, Fformat):
11546 Rename or remove local vars to avoid shadowing.
9710023e 11547 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11548
a415e694
PE
11549 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11550 avoid shadowing.
11551
8ef4622d
PE
11552 * lisp.h (eassert): Check that the argument compiles, even if
11553 ENABLE_CHECKING is not defined.
11554
946f9a5b
PE
11555 * data.c (Findirect_variable): Name an expression, to avoid
11556 gcc -Wbad-function-cast warning.
112396d6 11557 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11558 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11559 (Fmake_variable_buffer_local, Fmake_local_variable):
11560 Mark variables as initialized.
52746918 11561 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11562
e5aab7e7 11563 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11564 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11565 Rename locals to avoid shadowing.
dff45157
PE
11566 (mark_stack): Move local variables into the #ifdef region where
11567 they're used.
7bc26fdb
PE
11568 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11569 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11570 needed otherwise.
11571 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11572 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11573 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11574
e5aab7e7
PE
11575 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11576 avoids undefined behavior in theory.
11577
4da60324
PE
11578 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11579
88043301
PE
11580 Use functions, not macros, for up- and down-casing (Bug#8254).
11581 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11582 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11583 to use the following functions instead of these macros.
11584 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11585 EMACS_INT, since callers assume the returned value fits in int.
11586 (upcase1): Likewise, for UPCASE_TABLE.
11587 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11588 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11589 the race-condition problem in the old DOWNCASE.
88043301 11590
19ed5445
PE
11591 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11592 Rename locals to avoid shadowing.
11593 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11594 (regex_compile, re_search_2, re_match_2_internal):
11595 Remove unused local vars.
952db0d7
PE
11596 (FREE_VAR): Rewrite so as not to use empty "else",
11597 which gcc can warn about.
da053e48 11598 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11599 (RETALLOC_IF): Define only if needed.
11600 (WORDCHAR_P): Likewise. This one is never needed, but is used
11601 only in a comment talking about a compiler bug, so put inside
11602 the #if 0 of that comment.
11603 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11604 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11605 Remove; unused.
19ed5445 11606
1f3561e4 11607 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11608 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11609 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11610
ded6f8f7
PE
11611 * search.c (simple_search): Remove unused var.
11612
dbd37a95
PE
11613 * dired.c (compile_pattern): Move decl from here ...
11614 * lisp.h: ... to here, so that it can be checked.
11615 (struct re_registers): New forward decl.
11616
7e47afad
PE
11617 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11618
85f24f61
PE
11619 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11620 All uses changed.
11621 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11622 Rename locals to avoid shadowing.
5671df8f 11623 (Fvertical_motion): Mark locals as initialized.
85f24f61 11624
181aa2be 11625 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11626 (casify_region): Mark local as initialized.
181aa2be 11627
930d429c
PE
11628 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11629
7082eac6
PE
11630 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11631 New macros, so that the caller can use some names other than
11632 gcpro1, gcpro2, etc.
11633 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11634 of the new macros.
11635 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11636 argument, for consistency with GCPRO2_VAR, etc: it is now the
11637 prefix of the variable, not the variable itself. All uses
11638 changed.
38b2c076
PE
11639 * dired.c (directory_files_internal, file_name_completion):
11640 Rename locals to avoid shadowing.
11641
15206ed9
PE
11642 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11643 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11644 dired.c's scmp function, had undefined behavior.
11645 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11646 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11647 * buffer.h: ... to here, because these macros use current_buffer,
11648 and the new implementation with inline functions needs to have
11649 current_buffer in scope now, rather than later when the macros
11650 are used.
11651 (downcase, upcase1): New static inline functions.
11652 (DOWNCASE, UPCASE1): Reimplement using these functions.
11653 This avoids undefined behavior in expressions like
11654 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11655 from race conditions in accessing the global variables
11656 case_temp1 and case_temp2.
11657 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11658 * lisp.h (case_temp1, case_temp2): Remove their decls.
11659 * character.h (ASCII_CHAR_P): Move from here ...
11660 * lisp.h: ... to here, so that the inline functions mentioned
11661 above can use them.
11662
4a6bea26
PE
11663 * dired.c (directory_files_internal_unwind): Now static.
11664
f14b7e14
PE
11665 * fileio.c (file_name_as_directory, directory_file_name):
11666 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11667 Now static.
2893f146
PE
11668 (file_name_as_directory): Use const pointers when appropriate.
11669 (Fexpand_file_name): Likewise. In particular, newdir might
11670 point at constant storage, so make it a const pointer.
fd4ead52 11671 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11672 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11673 signedness issues.
f839df0c
PE
11674 (Fset_file_times, Finsert_file_contents, auto_save_error):
11675 Rename locals to avoid shadowing.
f14b7e14 11676
5716756e 11677 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11678 (Ftry_completion, Fall_completions): Rename or remove locals
11679 to avoid shadowing.
5716756e 11680
b4c3046a
PE
11681 * marker.c (bytepos_to_charpos): Remove; unused.
11682
b45db522
PE
11683 * lisp.h (verify_bytepos, count_markers): New decls,
11684 so that gcc does not warn that these functions aren't declared.
11685
85876d07
PE
11686 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11687 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11688 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11689 (copy_text): Remove unused local var.
85876d07 11690
03d78a21 11691 * filelock.c (within_one_second): Now static.
b3dd38ab 11692 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11693
5df8f01b
PE
11694 * buffer.c (fix_overlays_before): Mark locals as initialized.
11695 (fix_start_end_in_overlays): Likewise. This function should be
11696 simplified by using pointers-to-pointers, but that's a different
11697 matter.
b1d876f1 11698 (switch_to_buffer_1): Now static.
8f54f30a
PE
11699 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11700 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11701
a70072c9 11702 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11703 Fix pointer signedness issue.
edced198
PE
11704 (sys_subshell): Mark local as volatile if checking for lint,
11705 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11706 (MAXPATHLEN): Define only if needed.
a70072c9 11707
a0977c44
PE
11708 * process.c (serial_open, serial_configure): Move decls from here ...
11709 * systty.h: ... to here, so that they can be checked.
11710
a884fdcc
PE
11711 * fns.c (get_random, seed_random): Move extern decls from here ...
11712 * lisp.h: ... to here, so that they can be checked.
11713
604efe86 11714 * sysdep.c (reset_io): Now static.
b8950c94 11715 (wait_for_termination_signal): Remove; unused.
604efe86 11716
38fc62d9
PE
11717 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11718 (copy_keymap_item, append_key, push_text_char_description):
11719 Now static.
1004a21a 11720 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11721 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11722 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11723 (describe_map_tree):
11724 Rename locals to avoid shadowing.
38fc62d9 11725
2f2650da
PE
11726 * keyboard.c: Declare functions static if they are not used elsewhere.
11727 (echo_char, echo_dash, cmd_error, top_level_2):
11728 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11729 (read_char, kbd_buffer_get_event, make_lispy_position):
11730 (make_lispy_event, make_lispy_movement, apply_modifiers):
11731 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11732 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11733 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11734 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11735 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11736
a053e86c 11737 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11738 (mark_kboards): Move decl here ...
11739 * alloc.c (mark_kboards): ... from here.
a053e86c 11740
4752793e
PE
11741 * lisp.h (force_auto_save_soon): New decl.
11742
74f10ca7 11743 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11744 (DEFINE_DUMMY_FUNCTION): New macro.
11745 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11746 Use it.
c03cd23f
PE
11747 (main): Add casts to avoid warnings
11748 if GCC considers string literals to be constants.
74f10ca7 11749
022e70d4
PE
11750 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11751
59d6fe83
PE
11752 * dbusbind.c: Pointer signedness fixes.
11753 (xd_signature, xd_append_arg, xd_initialize):
11754 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11755 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11756 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11757 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11758
78320123
PE
11759 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11760 if GCC considers string literals to be constants.
49cebcca 11761 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11762
35ac2a97
SM
117632011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11764
fb103ca9
SM
11765 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11766 (print_preprocess, print_object): New macro to fix last change.
11767
35ac2a97
SM
11768 * print.c (print_preprocess): Don't forget font objects.
11769
62973b41
JB
117702011-03-16 Juanma Barranquero <lekktu@gmail.com>
11771
11772 * emacs.c (USAGE3): Doc fixes.
11773
0e48bb22
AS
117742011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11775
11776 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11777 structure.
11778
7684e57b
JB
117792011-03-14 Juanma Barranquero <lekktu@gmail.com>
11780
11781 * lisp.h (VWindow_system, Qfile_name_history):
11782 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11783 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11784 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11785
11786 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11787 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11788
11789 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11790 * w32console.c (detect_input_pending, read_input_pending)
11791 (encode_terminal_code):
11792 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11793 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11794 (w32_system_caret_y, Qfile_name_history):
11795 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11796 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11797 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11798 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11799 * w32proc.c (Qlocal, report_file_error):
11800 * w32term.c (Vwindow_system, updating_frame):
11801 * w32uniscribe.c (initialized, uniscribe_font_driver):
11802 Remove unneeded extern declarations.
11803
2aa46d6c
CY
118042011-03-14 Chong Yidong <cyd@stupidchicken.com>
11805
c96bbc66 11806 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11807
cffc6f3b
CY
118082011-03-13 Chong Yidong <cyd@stupidchicken.com>
11809
11810 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11811 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11812 These macros can no longer be used for assignment.
11813
44f230aa
SM
11814 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11815 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11816 (record_buffer_markers, fetch_buffer_markers): New functions for
11817 recording and fetching special buffer markers.
11818 (set_buffer_internal_1, set_buffer_temp): Use them.
11819
11820 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11821
11822 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11823
11824 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11825 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11826
11827 * xdisp.c (hscroll_window_tree):
11828 (reconsider_clip_changes): Use PT instead of BUF_PT.
11829
d251f04b
EZ
118302011-03-13 Eli Zaretskii <eliz@gnu.org>
11831
11832 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11833 $(EMACS_ROOT)/lib/intprops.h.
11834
f0c77cd1
PE
118352011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11836
3eca4629
PE
11837 Fix more problems found by GCC 4.5.2's static checks.
11838
7c86ee98
PE
11839 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11840 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11841 (xg_free_frame_widgets): Make it clear that a local variable is
11842 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11843 (gdk_window_get_screen): Make it clear that this macro is needed
11844 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11845 (int_gtk_range_get_value): New function, which avoids a diagnostic
11846 from gcc -Wbad-function-cast.
11847 (xg_set_toolkit_scroll_bar_thumb): Use it.
11848 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11849 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11850 (get_utf8_string, xg_get_file_with_chooser):
11851 Rename locals to avoid shadowing.
11852 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11853
41729b81
PE
11854 * xgselect.c (xg_select): Remove unused var.
11855
f0c77cd1
PE
11856 * image.c (four_corners_best): Mark locals as initialized.
11857 (gif_load): Initialize transparent_p to zero (Bug#8238).
11858 Mark another local as initialized.
ec6cf4c6 11859 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11860
ce0ad53d 11861 * image.c (clear_image_cache): Now static.
d5d5a617 11862 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11863 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11864 (x_edge_detection): Remove unnecessary cast that
11865 gcc -Wbad-function-cast diagnoses.
2037898d 11866 (gif_load): Fix pointer signedness.
6ae141d6
PE
11867 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11868 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11869
33383987 118702011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11871
d32df629
PE
11872 Improve quality of tests for time stamp overflow.
11873 For example, without this patch (encode-time 0 0 0 1 1
11874 1152921504606846976) returns the obviously-bogus value (-948597
11875 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11876 reports time overflow. See
11877 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11878 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11879 * editfns.c: Include limits.h and intprops.h.
11880 (TIME_T_MIN, TIME_T_MAX): New macros.
11881 (time_overflow): Move earlier, to before first use.
11882 (hi_time, lo_time): New functions, for an accurate test for
11883 out-of-range times.
11884 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11885 (Fget_internal_run_time): Don't assume time_t fits in int.
11886 (make_time): Use list2 instead of Fcons twice.
11887 (Fdecode_time): More accurate test for out-of-range times.
11888 (check_tm_member): New function.
11889 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11890 (lisp_time_argument): Don't rely on undefined left-shift and
11891 right-shift behavior when checking for time stamp overflow.
8be6f318 11892
fe31d94c
PE
11893 * editfns.c (time_overflow): New function, refactoring common code.
11894 (Fformat_time_string, Fdecode_time, Fencode_time):
11895 (Fcurrent_time_string): Use it.
11896
8be6f318
PE
11897 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11898 * dired.c (make_time): Move to ...
11899 * editfns.c (make_time): ... here.
11900 * systime.h: Note the move.
11901
09d9db2c 119022011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11903
126bc0dc
YM
11904 * fringe.c (update_window_fringes): Remove unused variables.
11905
c47cbdfd
YM
11906 * unexmacosx.c (copy_data_segment): Also copy __got section.
11907 (Bug#8223)
11908
7ac80be9
EZ
119092011-03-12 Eli Zaretskii <eliz@gnu.org>
11910
c96bbc66 11911 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11912 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11913 Constify `char *' arguments and their references according to
11914 prototypes in tparam.h.
11915
ecb0f94d 11916 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11917
7ac80be9
EZ
11918 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11919 Adapt all references accordingly.
11920
11921 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11922
ef1fd07e
TT
119232011-03-11 Tom Tromey <tromey@redhat.com>
11924
11925 * buffer.c (syms_of_buffer): Remove obsolete comment.
11926
7ef4b50c
EZ
119272011-03-11 Eli Zaretskii <eliz@gnu.org>
11928
11929 * termhooks.h (encode_terminal_code): Declare prototype.
11930
11931 * msdos.c (encode_terminal_code): Don't declare prototype.
11932
11933 * term.c (encode_terminal_code): Now external again, used by
11934 w32console.c and msdos.c.
11935
44f230aa
SM
11936 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11937 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11938
4b1ec863 119392011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11940
1714f52b 11941 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11942
4b1ec863
PE
11943 * fringe.c (update_window_fringes): Mark locals as initialized
11944 (Bug#8227).
11945 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11946
524c7aa6
PE
11947 * alloc.c (mark_fringe_data): Move decl from here ...
11948 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11949 to check its interface.
11950 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11951
a5c0af81 11952 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11953 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11954 (fontset_font): Mark local as initialized.
a9a06e0b 11955 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11956
b4716021
PE
11957 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11958
811e9bac 11959 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11960 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11961 (x_own_selection, Fx_disown_selection_internal): Rename locals
11962 to avoid shadowing.
11963 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11964
7e3ab302
PE
11965 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11966 so that the caller can use some name other than gcpro1.
11967 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11968 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11969 (Fx_backspace_delete_keys_p):
11970 Use them to avoid shadowing, and rename vars to avoid shadowing.
11971 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11972 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11973 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11974 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11975 Remove unused locals.
7e3ab302
PE
11976 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11977 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11978 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11979 macros.
f78faa98 11980
e2b13473
PE
11981 * xterm.h (x_mouse_leave): New decl.
11982
77f23912
PE
11983 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11984 Remove unused functions.
cdf4ba58
PE
11985 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11986 (x_calc_absolute_position): Now static.
7411c686 11987 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11988 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11989 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11990 unless they are used.
38d0b34a
PE
11991 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11992 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11993 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11994 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11995 (x_error_catcher, x_connection_closed, x_error_handler):
11996 (x_error_quitter, xembed_send_message, x_iconify_frame):
11997 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11998 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11999 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12000
44f230aa
SM
12001 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12002 Rename or move locals to avoid shadowing.
6b463e58 12003 (tty_defined_color, merge_face_heights): Now static.
5967d051 12004 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12005 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12006 does not deduce is never used uninitialized.
73719eba
PE
12007 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12008 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12009
426994c3 12010 * terminal.c (store_terminal_param): Now static.
5489860b 12011
032f1620 12012 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12013 (set_frame_menubar): Remove unused local.
d4323972 12014 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12015 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12016 since they might point to immutable storage.
281585b0
PE
12017 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12018 since it's unused otherwise.
032f1620 12019
367c19e5 12020 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12021 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12022 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12023 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12024 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12025 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12026 does not deduce are never used uninitialized.
70739cbe 12027
07b48fa9
PE
12028 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12029
8868a238 12030 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12031 * window.c (window_loop, size_window):
12032 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12033
7e5cf297 12034 * window.c (display_buffer): Now static.
d6550a9f
PE
12035 (size_window): Mark variables that gcc -Wuninitialized
12036 does not deduce are never used uninitialized.
a586633d
PE
12037 * window.h (check_all_windows): New decl, to forestall
12038 gcc -Wmissing-prototypes diagnostic.
5b555da1 12039 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12040
f6095868
PE
12041 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12042 shadowing.
12043 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12044 Include <limits.h>.
12045 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12046 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12047 (load_charset_map): Mark variables that gcc -Wuninitialized
12048 does not deduce are never used uninitialized.
53df7c11 12049 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12050
f38b440c
PE
12051 * coding.c (coding_set_source, coding_set_destination):
12052 Use "else { /* comment */ }" rather than "else /* comment */;"
12053 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12054 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12055 a block, when the outer 'i' will do.
12056 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12057 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12058 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12059 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12060 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12061 Rename locals to avoid shadowing.
12062 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12063 * coding.c (emacs_mule_char, encode_invocation_designation):
12064 Now static, since they're not used elsewhere.
413bb2db 12065 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12066 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12067 (decode_coding_emacs_mule): Mark variables that gcc
12068 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12069 (detect_coding_iso_2022): Initialize a local variable that might
12070 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12071 this initialization is needed. (Bug#8211)
5f58e762
PE
12072 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12073 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12074 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12075 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12076 Remove unused macros.
f38b440c 12077
232b38b9 12078 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12079 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12080 * character.c (string_count_byte8): Likewise.
232b38b9 12081
fb90da1b
PE
12082 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12083 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12084
fb93dbc2
PE
12085 * chartab.c (copy_sub_char_table): Now static, since it's not used
12086 elsewhere.
5c156ace
PE
12087 (sub_char_table_ref_and_range, char_table_ref_and_range):
12088 Rename locals to avoid shadowing.
bbcd0949 12089 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12090
7d3b3862 12091 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12092 (BIDI_BOB): Remove unused macro.
7d3b3862 12093
6be7d3da
PE
12094 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12095 deduce are never used uninitialized.
c2ed9c8b 12096 * term.c (encode_terminal_code): Likewise.
6be7d3da 12097
75f8807f 12098 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12099
50938595
PE
12100 * tparam.h: New file.
12101 * term.c, tparam.h: Include it.
12102 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12103 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12104 Move these decls to tparam.h, and make them agree with what
12105 is actually in tparam.c. The previous trick of using incompatible
12106 decls in different modules does not conform to the C standard.
12107 All callers of tparam changed to use tparam's actual API.
12108 * tparam.c (tparam1, tparam, tgoto):
12109 Use const pointers where appropriate.
12110
fbceeba2
PE
12111 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12112 * cm.h (struct cm): Likewise.
12113 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12114 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12115 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12116 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12117 (turn_on_face, init_tty): Likewise.
12118 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12119
7f3f1250
PE
12120 * term.c (term_mouse_position): Rename local to avoid shadowing.
12121
e6ca6543
PE
12122 * alloc.c (mark_ttys): Move decl from here ...
12123 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12124
c40f8d15
AS
121252011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12126
12127 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12128
cfe0661d
JB
121292011-03-09 Juanma Barranquero <lekktu@gmail.com>
12130
12131 * search.c (compile_pattern_1): Remove argument regp, unused since
12132 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12133 (compile_pattern): Don't pass it.
12134
0afb4571
J
121352011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12136
12137 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12138 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12139 for ! HAVE_GTK3.
12140 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12141
12142 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12143
12144 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12145 gdk_window_get_screen, gdk_window_get_geometry,
12146 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12147 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12148 (xg_get_pixbuf_from_pixmap): New function.
12149 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12150 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12151 Call xg_get_pixbuf_from_pixmap instead of
12152 gdk_pixbuf_get_from_drawable.
12153 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12154 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12155 (xg_check_special_colors): Use GtkStyleContext and its functions
12156 for HAVE_GTK3.
12157 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12158 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12159 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12160 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12161 Call gtk_widget_get_preferred_size.
0afb4571
J
12162 (xg_frame_resized): gdk_window_get_geometry only takes 5
12163 parameters.
44f230aa
SM
12164 (xg_win_to_widget, xg_event_is_for_menubar):
12165 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12166 (xg_set_widget_bg): New function.
12167 (delete_cb): New function.
895009e1 12168 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12169 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12170 (xg_set_background_color): Call xg_set_widget_bg.
12171 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12172 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12173 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12174 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12175 if ! HAVE_GTK3.
12176 (update_frame_tool_bar): Call gtk_widget_hide.
12177 (xg_initialize): Use GDK_KEY_g.
12178
12179 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12180 if ! HAVE_GTK3
12181 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12182
12183 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12184 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12185 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12186
1c2cc4ef
JB
121872011-03-08 Juanma Barranquero <lekktu@gmail.com>
12188
12189 * w32xfns.c (select_palette): Check success of RealizePalette against
12190 GDI_ERROR, not zero.
12191
33383987 12192See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12193
12194;; Local Variables:
12195;; coding: utf-8
aac0c6e3
MR
12196;; End:
12197
2f097256 12198 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12199
12200 This file is part of GNU Emacs.
12201
12202 GNU Emacs is free software: you can redistribute it and/or modify
12203 it under the terms of the GNU General Public License as published by
12204 the Free Software Foundation, either version 3 of the License, or
12205 (at your option) any later version.
12206
12207 GNU Emacs is distributed in the hope that it will be useful,
12208 but WITHOUT ANY WARRANTY; without even the implied warranty of
12209 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12210 GNU General Public License for more details.
12211
12212 You should have received a copy of the GNU General Public License
12213 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.