Fix bug #9943 with abort at shutdown.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
84c3edb9
EZ
12011-11-03 Eli Zaretskii <eliz@gnu.org>
2
3 * w32fns.c (unwind_create_frame): If needed, free the glyph
4 matrices of the partially constructed frame.
5
bc17a887
EZ
62011-11-01 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9 Don't stop backward scan on the continuation glyph, even though
10 its CHARPOS is positive.
26b46e51
EZ
11 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
12 cover_string to disp_string.
bc17a887 13
4ee88440
MR
142011-11-01 Martin Rudalics <rudalics@gmx.at>
15
16 * window.c (temp_output_buffer_show): Don't use
17 Vtemp_buffer_show_specifiers.
18 (Vtemp_buffer_show_specifiers): Remove unused variable.
19
c2ff3c02
EZ
202011-10-30 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
23 past the beginning of the current glyph matrix.
24
6e56383b
JD
252011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
26
27 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
28 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
29 HAVE_GTK3 (Bug#9869).
b77a6a7f 30
3b574623
JD
31 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
32 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
33
b77a6a7f
JD
34 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
35
36 * xterm.c: Declare x_handle_net_wm_state to return int.
37 (handle_one_xevent): Check if we are iconified but don't have
38 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
39 (get_current_wm_state): Return non-zero if not hidden,
40 check for _NET_WM_STATE_HIDDEN (Bug#9893).
41 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
42 (x_handle_net_wm_state): Return what get_current_wm_state returns.
43 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
44
196e41e4
PE
452011-10-29 Paul Eggert <eggert@cs.ucla.edu>
46
47 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
48 so that this new function doesn't get optimized away by a
49 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
50
021f2e1a
AS
512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
52
53 * frame.h (MOUSE_HL_INFO): Remove excess parens.
54
8b058d44
EZ
552011-10-29 Eli Zaretskii <eliz@gnu.org>
56
57 Fix the `xbytecode' command.
58 * .gdbinit (xprintbytestr): New command.
59 (xwhichsymbols): Renamed from `which'; all callers changed.
60 (xbytecode): Print the byte-code string as well.
61
4452fb80
EZ
622011-10-29 Kim Storm <storm@cua.dk>
63
8b058d44
EZ
64 * alloc.c (which_symbols): New function.
65
21b72067
AS
662011-10-29 Andreas Schwab <schwab@linux-m68k.org>
67
68 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
69 line. (Bug#9903)
70
83ed7b5c
GM
712011-10-29 Glenn Morris <rgm@gnu.org>
72
73 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
74 Not clear what it was for, and it causes various bugs. (Bug#9839)
75
5a7a728b
EZ
762011-10-28 Eli Zaretskii <eliz@gnu.org>
77
78 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
79 possible random value that matches one of those tested as
80 condition to clear the mouse face.
81
d3d0842f
CY
822011-10-28 Chong Yidong <cyd@gnu.org>
83
84 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
85
31b39d13
DN
862011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
87
88 * window.c (make_window): Initialize phys_cursor_on_p.
89
9aba6043
SM
902011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
91
92 * lisp.h (struct Lisp_Symbol): Update comments.
93
c20992f4
JB
942011-10-28 Juanma Barranquero <lekktu@gmail.com>
95
96 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
97
db4f02f2
EZ
982011-10-28 Eli Zaretskii <eliz@gnu.org>
99
100 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
101 <oslsachem@gmail.com> for helping to debug this.
102
103 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
104 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
105 (g_b_init_get_glyph_outline_w): New static variables.
106 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
107 (GetGlyphOutlineW_Proc): New typedefs.
108 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
109 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
110 New functions.
111 (w32font_open_internal, compute_metrics):
112 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
113 instead of calling the "wide" APIs directly.
114
115 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
116
117 * w32.h (syms_of_w32font): Add prototype.
118
87e68db4
JB
1192011-10-27 Juanma Barranquero <lekktu@gmail.com>
120
121 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
122 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
123 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
124 (Fmove_to_window_line): Doc fix.
125
435c1d67
CY
1262011-10-27 Chong Yidong <cyd@gnu.org>
127
128 * process.c (make_process): Set gnutls_state to NULL.
129
130 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
131 non-NULL, regardless of GNUTLS_INITSTAGE.
132 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
133 an error. Set process slots as soon as we allocate them.
134
135 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
136
9c6c6f49
CY
1372011-10-27 Chong Yidong <cyd@gnu.org>
138
9aba6043
SM
139 * gnutls.c (emacs_gnutls_deinit): New function.
140 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
141 (Fgnutls_deinit, Fgnutls_boot): Use it.
142
143 * process.c (make_process): Initialize GnuTLS credentials to NULL.
144 (deactivate_process): Call emacs_gnutls_deinit.
145
657d08d3
JB
1462011-10-27 Juanma Barranquero <lekktu@gmail.com>
147
148 * image.c (x_create_x_image_and_pixmap):
149 * w32.c (sys_rename, w32_delayed_load):
150 * w32font.c (fill_in_logfont):
151 * w32reg.c (x_get_string_resource): Silence compiler warnings.
152
5430d399
JB
1532011-10-26 Juanma Barranquero <lekktu@gmail.com>
154
155 * w32fns.c (w32_default_color_map): New function,
156 extracted from Fw32_default_color_map.
a7ef684b 157 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 158
fe0055fa
PE
1592011-10-25 Paul Eggert <eggert@cs.ucla.edu>
160
161 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
162
e6346438
SM
1632011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
164
165 * keyboard.c (test_undefined): New function (bug#9751).
166 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
167
e112cc37
ET
1682011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
169
170 * sysdep.c (init_sys_modes): Fix the check for the controlling
171 terminal (Bug#6649).
172
7b5d6677
EZ
1732011-10-20 Eli Zaretskii <eliz@gnu.org>
174
175 * dispextern.h (struct bidi_it): New member next_en_type.
176
177 * bidi.c (bidi_line_init): Initialize the next_en_type member.
178 (bidi_resolve_explicit_1): When next_en_pos is valid for the
179 current character, check also for next_en_type being WEAK_EN.
180 (bidi_resolve_weak): Don't enter the expensive loop if the current
181 position is before next_en_pos. Record the bidi type of the first
182 non-ET, non-BN character we find, in addition to its position.
183 (bidi_level_of_next_char): Invalidate next_en_type when
184 next_en_pos is over-stepped.
185
7da0b018
PE
1862011-10-20 Paul Eggert <eggert@cs.ucla.edu>
187
188 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
189 * editfns.c: Rewrite current-time-zone so that it invokes
190 the equivalent of (format-time-string "%Z") to get the time zone name.
191 This fixes a bug when the time zone name contains characters that
192 need converting from the system time locale to Emacs internal format.
193 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
194 that patch fixed format-time-string to do the conversion, but
195 I forgot to fix current-time-zone.
196 (format_time_string): New function, containing most of
197 what Fformat_time_string used to contain.
198 (Fformat_time_string): Rewrite in terms of format_time_string.
199 This doesn't change this function's behavior.
200 (current-time-zone): Rewrite to use format_time_string.
201 This fixes the bug reported by Michael Schierl in
202 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
203 Jason Rumney's 2007-06-07 change worked around this bug, but
204 didn't fix it.
205 * systime.h (tzname, timezone): Remove no-longer-used declarations.
206
8547b010
EZ
2072011-10-19 Eli Zaretskii <eliz@gnu.org>
208
209 * xdisp.c (start_display): If the character at POS is displayed
210 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
211 (try_window_reusing_current_matrix): If a line ends in a display
212 vector or the next line starts in a display vector, continue
213 redrawing the window even though the character position of
214 start_row was reached.
8547b010
EZ
215 (Bug#9771, part 2)
216
4e948d15
CY
2172011-10-18 Chong Yidong <cyd@gnu.org>
218
219 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
220 with nobreak-char-display too.
221
4787455f
EZ
2222011-10-18 Eli Zaretskii <eliz@gnu.org>
223
224 Fix part 3 of bug#9771.
225 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
226 (bidi_resolve_neutral): Don't enter the expensive loop looking for
227 non-neutral characters if the current character is a paragraph
228 separator (a.k.a. Newline). This avoids running the same
229 expensive loop twice, once when we consume the preceding newline
230 and the other time when the line actually needs to be displayed.
231 Avoid the loop when we see neutrals on the base embedding level
232 following a character whose directionality is the same as the
233 paragraph's. This avoids running the expensive loop when a line
234 ends in a long sequence of neutrals, like control characters.
235 Add assertion against STRONG_AL type. Slightly rearrange code
236 that determines the type of a neutral given the first non-neutral
237 that follows it.
238 (bidi_level_of_next_char): Set next_en_pos to zero when
239 invalidating its info.
240
2c91f553
EZ
2412011-10-17 Eli Zaretskii <eliz@gnu.org>
242
243 * xdisp.c (push_display_prop): Determine whether to record string
244 or buffer position by IT->string, not by IT->method. Allow
245 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
246 (move_it_vertically_backward): Don't look for character position
247 immediately after the newline when in a continuation line.
248 (Bug#9771, part 1)
2c91f553 249
c7b08b0d
MR
2502011-10-15 Martin Rudalics <rudalics@gmx.at>
251
252 * window.c (coordinates_in_window): Rewrite and delabelize
253 vertical border check. (Bug#5357) (Bug#9618)
254
6b02f655
SM
2552011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
256
257 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
258 errors in XSetWindowBorder (bug#9310).
259
81d40c92
DA
2602011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
261
262 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
263 avoid crash when xmalloc overrun checking is enabled.
264
d4172c3b
EZ
2652011-10-13 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
268 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
269 cursor motion with <left> and <right> arrow keys.
270
271 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
272 some callers set that themselves.
273
b00eea75
EZ
2742011-10-12 Eli Zaretskii <eliz@gnu.org>
275
276 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
277 display string and the previous row comes from the same string and
278 is empty. (Bug#9739) (Bug#9738)
279
8fe012c4
SM
2802011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
281
282 * doc.c (get_doc_string): Encode file name (bug#9735).
283
0074aef2
EZ
2842011-10-12 Eli Zaretskii <eliz@gnu.org>
285
79beb178
EZ
286 * bidi.c (bidi_level_of_next_char):
287 * xdisp.c (get_visually_first_element): Remove old incorrect
288 comments regarding the Unicode Line Separator character.
289
0074aef2
EZ
290 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
291
6e4b3fbe
DA
2922011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
293
294 * alloc.c (Fgc_status): Do not access beyond zombies array
295 boundary if nzombies > MAX_ZOMBIES.
296 * alloc.c (dump_zombies): Add missing format specifier.
297
0324f3af
PE
2982011-10-12 Paul Eggert <eggert@cs.ucla.edu>
299
b5525cac
PE
300 * xdisp.c (set_cursor_from_row): Simplify conditionals,
301 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
302
0324f3af
PE
303 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
304 Some packages use them to denote characters with modifiers.
305
e9b5f888
AS
3062011-10-11 Andreas Schwab <schwab@linux-m68k.org>
307
308 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
309 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
310 matching a pp-number. Rename parameter var to var1.
311
127827c0
SM
3122011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
313
314 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
315
c8fd3bd0
GM
3162011-10-08 Glenn Morris <rgm@gnu.org>
317
318 * callint.c (Fcall_interactively): Give a more explicit error for the
319 'c' case with a non-character input. (Bug#8479)
320
352ec8ff
EZ
3212011-10-08 Eli Zaretskii <eliz@gnu.org>
322
03669ccb
EZ
323 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
324 lines.
7061c986
EZ
325 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
326 lines that are hscrolled on the left.
03669ccb 327
352ec8ff
EZ
328 * dispnew.c (buffer_posn_from_coords): Account for a possible
329 presence of header-line. (Bug#4426)
330
a66cfb1c
SM
3312011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
332
6b02f655
SM
333 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
334 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 335
7c5ee88e
PE
3362011-10-07 Paul Eggert <eggert@cs.ucla.edu>
337
338 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
339 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
340 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
341 this makes Emacs dump core during garbage collection on rare
342 occasions. sizeof is obviously inferior to offsetof here, so
343 stick with offsetof.
344 (GC_POINTER_ALIGNMENT): New macro.
345 (mark_memory): Omit 3rd (offset) arg; caller changed.
346 Don't assume EMACS_INT alignment is the same as pointer alignment.
347
df1bbe5b
SM
3482011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * keyboard.c (read_key_sequence_remapped): New var.
351 (read_key_sequence): Compute remapping in the right buffer.
352 (command_loop_1): Use read_key_sequence's remapping directly.
353
51553db6
SM
3542011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
355
32c1fffd
SM
356 * dired.c (file_name_completion): Don't expand file name.
357 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
358 before checking file name handler.
359
51553db6
SM
360 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
361 they've been requested explicitly (bug#9591).
362
b6bd1599 3632011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
364
365 * keymap.c (Fsingle_key_description): Use make_specified_string
366 instead of build_string to build string from push_key_description.
367 (Bug#5193)
368
f701dc2a
PE
3692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
370
4222c55d
PE
371 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
372 This fixes a Y2038 bug on 64-bit hosts.
373 * buffer.c (reset_buffer):
374 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
375 (Fclear_buffer_auto_save_failure):
376 Use 0, not -1, to represent an unset failure time, since time_t
377 might not be signed.
378
f701dc2a
PE
379 Remove dependency on glibc malloc internals.
380 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
381 Move back here from lisp.h, but with their new implementations.
382 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
383 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
384 * charset.c (charset_table_init): New static var.
385 (syms_of_charset): Use it instead of xmalloc. This removes a
386 dependency on glibc malloc internals. See Eli Zaretskii's comment in
387 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
388 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
389 Move back to alloc.c.
390 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
391 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
392
9ceebf39
JD
3932011-09-30 Jan Djärv <jan.h.d@swipnet.se>
394
395 * nsterm.m (windowDidResize): Call x_set_window_size only when
396 ns_in_resize is true. Otherwise set pixelwidth/height and
397 call change_frame_size (Bug#9628).
398
cb993c58
PE
3992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
400
3930c88b
PE
401 Port --enable-checking=all to Fedora 14 x86-64.
402 * charset.c (syms_of_charset): Also account for glibc malloc's
403 internal overhead when calculating the initial malloc maximum.
404
cb993c58
PE
405 Port --enable-checking=all to Fedora 14 x86.
406 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
407 Move to lisp.h.
408 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
409 (overrun_check_realloc, overrun_check_free):
410 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
411 That way, xmalloc returns a properly-aligned pointer even if
412 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
413 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
414 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
415 into account when calculating the initial malloc maximum.
416 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
417 Move here from alloc.c, so that charset.c can use it too.
418 Properly align; the old code wasn't right for common 32-bit hosts
419 when configured with --enable-checking=all.
420 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
421 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
422
31bed486
EZ
4232011-09-29 Eli Zaretskii <eliz@gnu.org>
424
04c70788 425 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
426 use EDOM.
427
fbcaa2f3
EZ
4282011-09-28 Eli Zaretskii <eliz@gnu.org>
429
430 * xdisp.c (compute_display_string_end): If there's no display
431 string at CHARPOS, return -1.
432
433 * bidi.c (bidi_fetch_char): When compute_display_string_end
434 returns a negative value, treat the character as a normal
435 character not covered by a display string. (Bug#9624)
436
a239d4e9
JB
4372011-09-28 Juanma Barranquero <lekktu@gmail.com>
438
439 * lread.c (Fread_from_string): Fix typo in docstring.
440
88652fd5
EZ
4412011-09-27 Eli Zaretskii <eliz@gnu.org>
442
443 * xdisp.c (handle_invisible_prop): If invisible text ends on a
444 newline, reseat the iterator instead of bidi-iterating there one
445 character at a time. (Bug#9610)
32c1fffd
SM
446 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
447 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 448
ed497dd4
AS
4492011-09-27 Andreas Schwab <schwab@linux-m68k.org>
450
451 * lread.c (readevalloop): Use correct code for NBSP.
452 (read1): Likewise. (Bug#9608)
453
b2bf61aa
MA
4542011-09-25 Michael Albinus <michael.albinus@gmx.de>
455
456 * dbusbind.c (Fdbus_register_signal): When service is not
457 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
458
32bbb17c
GM
4592011-09-25 Glenn Morris <rgm@gnu.org>
460
461 * buffer.c (truncate-lines): Doc fix.
462
94e0933e
CY
4632011-09-24 Chong Yidong <cyd@stupidchicken.com>
464
465 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
466 (Fset_window_next_buffers): Doc fix.
467
cddde921
GM
4682011-09-24 Glenn Morris <rgm@gnu.org>
469
470 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
471
1260aef1
PE
4722011-09-24 Paul Eggert <eggert@cs.ucla.edu>
473
25b4bfa0
PE
474 Fix minor problems found by static checking.
475 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
476 * indent.c (Fvertical_motion): Fix == vs = typo.
477
e3cbd34b
EZ
4782011-09-24 Eli Zaretskii <eliz@gnu.org>
479
a66cfb1c
SM
480 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
481 Default value is now t. Doc fix.
6bf7006f 482
e3cbd34b 483 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 484 logic when moving up, not only when moving down. Fix the
e3cbd34b 485 confusing name and values of the it_overshoot_expected variable;
32c1fffd 486 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
487
488 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
489 CHARPOS is covered by a display string which includes newlines.
490 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
491 is covered by a display string with embedded newlines.
492
a3de0cbd
MA
4932011-09-24 Michael Albinus <michael.albinus@gmx.de>
494
495 * dbusbind.c (Fdbus_register_signal): Add match rule to
496 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
497 (Fdbus_register_method, Vdbus_registered_objects_table):
498 Fix docstring.
a3de0cbd 499
b260039d
JM
5002011-09-24 Jim Meyering <meyering@redhat.com>
501
32c1fffd 502 do not ignore write error for any output size
b260039d
JM
503 The previous change was incomplete.
504 While it makes emacs --batch detect the vast majority of stdout
505 write failures, errors were still ignored whenever the output size is
506 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
507 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
508 && echo FAIL: ignored write error
509 FAIL: ignored write error
510 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
511 && echo FAIL: ignored write error
512 FAIL: ignored write error
513 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
514
8eca8a7c
AS
5152011-09-23 Andreas Schwab <schwab@linux-m68k.org>
516
517 * emacs.c (Fkill_emacs): In noninteractive mode exit
518 non-successfully if a write error occurred on stdout. (Bug#9574)
519
3341db62
EZ
5202011-09-21 Eli Zaretskii <eliz@gnu.org>
521
522 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
523 the xassert test.
524
525 * dispextern.h (struct it): Update the comment documenting what
526 can it->OBJECT be.
527
8c203dbf
EZ
5282011-09-20 Eli Zaretskii <eliz@gnu.org>
529
530 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
531 a display string, extend search for cursor position to end of row.
532 (find_row_edges): If the row ends in a newline from a display
533 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
534 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
535 (Fcurrent_bidi_paragraph_direction): Fix search for previous
536 non-empty line. Fixes confusing cursor motion with arrow keys at
537 the beginning of a line that starts with whitespace.
8c203dbf 538
a4824228
LMI
5392011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
540
541 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
542 (bug#9493).
543
33ed493b
CY
5442011-09-18 Chong Yidong <cyd@stupidchicken.com>
545
546 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
547 boolean (Bug#9154).
548
56cd55c8
EZ
5492011-09-18 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (display_line): Record maximum and minimum buffer
552 positions even if no glyphs were produced (e.g., by a zero-width
553 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
554 buffer positions that will be removed from the glyph row because
555 they don't fit.
c02dcedf
EZ
556 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
557 column is beyond frame width: don't subtract 1 "pixel" when
558 computing width of the stretch.
3e62b7e0
EZ
559 (reseat_at_next_visible_line_start): Undo the change made on
560 2011-09-17 that saved paragraph information and restored it after
561 the call to `reseat'. (Bug#9545)
56cd55c8 562
5ed99d36 5632011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
564
565 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
566 and turn window cursor on if cleared (Bug#9415).
567
5ed99d36 5682011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
569
570 * search.c (boyer_moore): Take unibyte characters from pattern
571 literally. (Bug#9458)
572
9bade7b2
EZ
5732011-09-18 Eli Zaretskii <eliz@gnu.org>
574
575 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
576
e5e9d610
PE
5772011-09-18 Paul Eggert <eggert@cs.ucla.edu>
578
87e4427a
PE
579 Fix minor problem found by static checking.
580 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
581 initialized, to pacify gcc -Wuninitialized.
582
e5e9d610
PE
583 * fileio.c: Report proper errno when syscall falls.
584 (Finsert_file_contents): Save and restore errno,
585 so that report_file_error outputs the correct diagnostic.
586 (Fwrite_region) [CLASH_DETECTION]: Likewise.
587
a1674f0b
EZ
5882011-09-18 Eli Zaretskii <eliz@gnu.org>
589
590 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
591
fbfb6dd4
EZ
5922011-09-17 Eli Zaretskii <eliz@gnu.org>
593
594 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
595 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
596
bb187662
EZ
5972011-09-17 Eli Zaretskii <eliz@gnu.org>
598
1137e8b8 599 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 600 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
601
602 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
603 (bidi_find_paragraph_start): Search back for paragraph beginning
604 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
605 (bidi_move_to_visually_next): Only trigger paragraph-related
606 computations when the last character is a newline or at EOB, not
607 just any NEUTRAL_B. (Bug#9470)
608
bb187662
EZ
609 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
610 truncated lines if point is covered by a display string. (Bug#9524)
611
2e621251
PE
6122011-09-16 Paul Eggert <eggert@cs.ucla.edu>
613
614 * xselect.c: Relax test for outgoing X longs (Bug#9498).
615 (cons_to_x_long): New function.
616 (lisp_data_to_selection_data): Use it. Correct the test for
617 short-versus-long data; it was negated. Break out of vector
618 loop, for efficiency, when a long datum is discovered.
619
91a15bc6
SM
6202011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
621
622 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
623
b41c3a35
EZ
6242011-09-16 Eli Zaretskii <eliz@gnu.org>
625
626 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
627 GCC PR/17406) by declaring this function with external scope.
628
7812ba2d
PE
6292011-09-15 Paul Eggert <eggert@cs.ucla.edu>
630
631 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
632 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
633
cf7edc2a
AS
6342011-09-15 Andreas Schwab <schwab@linux-m68k.org>
635
636 * editfns.c (Fformat): Correctly handle text properties on "%%".
637
bd01620e
EZ
6382011-09-15 Eli Zaretskii <eliz@gnu.org>
639
640 * xterm.c (x_draw_composite_glyph_string_foreground):
641 * w32term.c (x_draw_composite_glyph_string_foreground):
642 * term.c (encode_terminal_code):
643 * composite.c (composition_update_it, get_composition_id):
644 * xdisp.c (get_next_display_element)
645 (fill_composite_glyph_string): Add comments about special meaning
646 of TAB characters in a composition.
647
a02719a3
PE
6482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
649
650 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
651 This occurs when processing a multibyte format.
652 Problem reported by Wolfgang Jenker.
a02719a3 653
72589a3c
JB
6542011-09-15 Johan Bockgård <bojohan@gnu.org>
655
656 * xdisp.c (try_cursor_movement): Only check for exact match if
657 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
658
1c14176c
PE
6592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
660
661 Remove unused external symbols.
662 * dispextern.h (calc_pixel_width_or_height): Remove decl.
663 * xdisp.c (calc_pixel_width_or_height): Now static.
664 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
665 * indent.c (check_display_width):
666 * w32term.c: Fix comment to match code.
667 * xterm.c, xterm.h (x_catching_errors): Remove.
668
d2eea5b5
PE
6692011-09-14 Paul Eggert <eggert@cs.ucla.edu>
670
671 * xselect.c: Use signed conversions more consistently (Bug#9498).
672 (selection_data_to_lisp_data): Assume incoming selection data are
673 signed integers, not unsigned. This is to be consistent with
674 outgoing selection data, which was modified to use signed integers
675 in as part of the fix to Bug#9196 in response to Jan D.'s comment
676 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
677 expects long, not unsigned long.
678
46888499
EZ
6792011-09-14 Eli Zaretskii <eliz@gnu.org>
680
681 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
682 computation of loop end. Reported by Johan Bockgård
683 <bojohan@gnu.org>.
684
ef8ef9fb
CY
6852011-09-13 Chong Yidong <cyd@stupidchicken.com>
686
687 * frame.c (Fother_visible_frames_p): Function deleted.
688
fa819fed
EZ
6892011-09-12 Eli Zaretskii <eliz@gnu.org>
690
691 * indent.c (compute_motion): Process display vector front to back
692 rather than the other way around. (Bug#2496)
693
2ba8e008
SM
6942011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
695
696 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
697
20f53c69
CY
6982011-09-11 Chong Yidong <cyd@stupidchicken.com>
699
700 * minibuf.c (Fread_from_minibuffer): Doc fix.
701
d562d7a4
EZ
7022011-09-11 Eli Zaretskii <eliz@gnu.org>
703
704 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
705 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
706
1c4d7f3d
LMI
7072011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
708
709 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
710 value for non-existent files.
711
b885bf36
EZ
7122011-09-11 Eli Zaretskii <eliz@gnu.org>
713
714 * fileio.c (Finsert_file_contents): If the file cannot be opened,
715 set its "size" to -1. This will set the modtime_size field of
716 the corresponding buffer to -1, which is what
717 verify-visited-file-modtime expects for files that do not exist.
718 (Bug#9139)
719
6612f0bf
PE
7202011-09-11 Paul Eggert <eggert@cs.ucla.edu>
721
722 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
723 here ...
724 * lisp.h: ... from here. push_key_description is no longer
725 defined in keyboard.c, so its declaration should not be in
726 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
727 logically belongs with push_key_description.
728
dfb3f755
PE
7292011-09-10 Paul Eggert <eggert@cs.ucla.edu>
730
731 * buffer.h: Include <sys/types.h> instead of <time.h>.
732 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
733 Problem reported by Herbert J. Skuhra.
734
3134906c
LMI
7352011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
736
737 * xml.c (parse_region): Make the parsing work for
738 non-comment-starting XML files again (bug#9144).
739
8d903f4e
AS
7402011-09-10 Andreas Schwab <schwab@linux-m68k.org>
741
742 * image.c (gif_load): Fix calculation of bottom and right corner.
743 (Bug#9468)
744
80ad64f4
EZ
7452011-09-10 Eli Zaretskii <eliz@gnu.org>
746
747 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
748 redisplay in small windows.
749
208a048d
EZ
7502011-09-09 Eli Zaretskii <eliz@gnu.org>
751
752 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
753
9b1c252e
MR
7542011-09-08 Martin Rudalics <rudalics@gmx.at>
755
756 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
757 Operate on live windows only.
758
2949f33b
JB
7592011-09-08 Juanma Barranquero <lekktu@gmail.com>
760
761 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
762
e08dcafd
EZ
7632011-09-07 Eli Zaretskii <eliz@gnu.org>
764
765 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
766 only under bidi iteration.
767
115b96bd
JD
7682011-09-07 Jan Djärv <jan.h.d@swipnet.se>
769
770 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
771
c8199d0f
PE
7722011-09-06 Paul Eggert <eggert@cs.ucla.edu>
773
774 isnan: Fix porting problem to Solaris 10 with bundled gcc.
775 Without this fix, the command to link temacs failed due to an
776 undefined symbol __builtin_isnan. This is because
777 /usr/include/iso/math_c99.h #defines isnan(x) to
778 __builtin_isnan(x), but the bundled gcc, which identifies itself
779 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
780 a __builtin_isnan.
781 * floatfns.c (isnan): #undef, and then #define to a clone of
782 what's in data.c.
783 (Fisnan): Always define, since it's always available now.
784 (syms_of_floatfns): Always define isnan at the Lisp level.
785
e39b275c 7862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
787
788 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
789
b2db44d9 7902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 791
f4af5137 792 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
793 The previous code assumed that file offsets (off_t values) fit in
794 EMACS_INT variables, which is not true on typical 32-bit hosts.
795 The code messed up by falsely reporting buffer overflow in cases
796 such as (insert-file-contents "big" nil 1 2) into an empty buffer
797 when "big" contains more than 2**29 bytes, even though this
798 inserts just one byte and does not overflow the buffer.
799 (Finsert_file_contents): Store file offsets as off_t
800 values, not as EMACS_INT values. Check for overflow when
801 converting between EMACS_INT and off_t. When checking for
802 buffer overflow or for overlap, take the offsets into account.
803 Don't use EMACS_INT for small values where int suffices.
804 When checking for overlap, fix a typo: ZV was used where
805 ZV_BYTE was intended.
806 (Fwrite_region): Don't assume off_t fits into 'long'.
807 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
808
ecfc0a49
MA
8092011-09-05 Michael Albinus <michael.albinus@gmx.de>
810
811 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
812
6511acf2 8132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 814
0999621a 815 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
816
817 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 818 (esprintf, exprintf, evxprintf): New functions.
62f19c19 819 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 820 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
821 (modify_event_symbol): Do not assume that the length of
822 name_alist_or_stem is safe to alloca and fits in int.
823 (Fexecute_extended_command): Likewise for function name and binding.
824 (Frecursion_depth): Wrap around reliably on integer overflow.
825 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
826 since some callers pass EMACS_INT values.
827 (Fsingle_key_description): Don't crash if symbol name contains more
828 than MAX_ALLOCA bytes.
829 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
830 (get_minibuffer): Arg is now EMACS_INT, not int.
831 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 832 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
833 * window.h (command_loop_level, minibuf_level): Reflect API changes.
834
2be7d702
PE
835 * dbusbind.c (signature_cat): New function.
836 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
837 Do not overrun buffer; instead, report string overflow.
838
9d1df220
PE
839 * dispnew.c (add_window_display_history): Don't overrun buffer.
840 Truncate instead; this is OK since it's just a log.
841
33ef5c64
PE
842 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
843 even if the time zone offset is outlandishly large.
844 Don't mishandle offset == INT_MIN.
845
66c6fdd5
PE
846 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
847 when creating daemon; the previous buffer-overflow check was incorrect.
848
d749b01b
PE
849 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
850 which has the guts of the old verror function.
851
b5cd1905
PE
852 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
853 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
854
6e1a67fb
PE
855 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
856 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 857 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 858 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
859 length of string rather than counting it via multiple sprintfs;
860 that's simpler and more reliable.
c21721cc
PE
861 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
862 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
863 sprintf, in case result does not fit in int.
864
c57b67fc
PE
865 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
866 (fontset_from_font): Print it.
867
8a401434
PE
868 * frame.c (tty_frame_count): Now printmax_t, not int.
869 (make_terminal_frame, set_term_frame_name): Print it.
870 (x_report_frame_params): In X, window IDs are unsigned long,
871 not signed long, so print them as unsigned.
872 (validate_x_resource_name): Check for implausibly long names,
873 and don't assume name length fits in 'int'.
874 (x_get_resource_string): Don't blindly alloca invocation name;
875 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
876 not fit in int.
877
6e1a67fb
PE
878 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
879 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
880 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
881
0df02bf3
PE
882 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
883 Use esprintf, not sprintf, in case result does not fit in int.
884
48e30793
PE
885 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
886 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
887 it as a large positive number.
888 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
889 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
890
a66ff6d8
PE
891 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
892 in case result does not fit in int.
893
aca216ff
PE
894 * print.c (float_to_string): Detect width overflow more reliably.
895 (print_object): Make sprintf buffer a bit bigger, to avoid potential
896 buffer overrun. Don't assume list length fits in 'int'. Treat
897 print length of 0 as 0, not as infinity; to be consistent with other
898 uses of print length in this function. Don't overflow print length
899 index. Don't assume hash table size fits in 'long', or that
900 vectorlike size fits in 'unsigned long'.
901
31c286f7
PE
902 * process.c (make_process): Use printmax_t, not int, to format
903 process-name gensyms.
904
55e5faa1
PE
905 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
906
80f2e268
PE
907 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
908 to avoid potential buffer overrun.
909
670741ab
PE
910 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
911 if X resource line is longer than 512 bytes.
912
b7163a50
PE
913 * xfns.c (x_window): Make sprintf buffer a bit bigger
914 to avoid potential buffer overrun.
915
ae58ff1f
PE
916 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
917
c43c8a6a
PE
918 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
919
3f8236f4
PE
9202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
921
53e9fe90 922 Integer overflow fixes for scrolling, etc.
6511acf2
PE
923 Without these, Emacs silently mishandles large integers sometimes.
924 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
925 it were "C-u 1 M-x recenter" on a typical 64-bit host.
926
6511acf2
PE
927 * xdisp.c (try_window_id): Check Emacs fixnum range before
928 converting to 'int'.
806add1d 929
6511acf2 930 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
931 Check that an Emacs fixnum is in range before assigning it to 'int'.
932 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
933 values converted from Emacs fixnums.
934 (Frecenter): Don't wrap around a line count if it is out of 'int'
935 range; instead, treat it as an extreme value.
936 (Fset_window_configuration, compare_window_configurations):
937 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
938
6511acf2
PE
939 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
940 that can exceed INT_MAX. Check that EMACS_INT value is in range
941 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
942 (match_limit): Don't assume that a fixnum can fit in 'int'.
943
6511acf2 944 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
945 exceed INT_MAX.
946
6511acf2 947 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
948 (Fvertical_motion): Don't wrap around LINES values that don't fit
949 in 'int'. Instead, treat them as extreme values. This is good
950 enough for windows, which can't have more than INT_MAX lines anyway.
951
fcb901a7
LMI
9522011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
953
0f2f6b6d
LMI
954 * Require libxml/parser.h to avoid compilation warning.
955
fcb901a7
LMI
956 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
957
958 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
959 since this reportedly can destroy thread storage.
960
6e20a0d4
CY
9612011-08-30 Chong Yidong <cyd@stupidchicken.com>
962
963 * syntax.c (find_defun_start): Update all cache variables if
964 exiting early (Bug#9401).
965
148ae00e
EZ
9662011-08-30 Eli Zaretskii <eliz@gnu.org>
967
f6cfbd8f
EZ
968 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
969
148ae00e
EZ
970 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
971 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
972 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
973
974 * term.c (tty_append_glyph): New function.
975 (produce_stretch_glyph): Static function and its prototype deleted.
976
a66cfb1c
SM
977 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
978 Add prototypes.
148ae00e 979
c4a07a4c
PE
9802011-08-29 Paul Eggert <eggert@cs.ucla.edu>
981
982 * image.c (parse_image_spec): Check for nonnegative, not for positive,
983 when checking :margin (Bug#9390).
984 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 985 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
986 so that the name doesn't mislead. All uses changed.
987
6bc8cd65
JB
9882011-08-28 Johan Bockgård <bojohan@gnu.org>
989
990 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
991 set_tty_hooks.
992
dca4927e
EZ
9932011-08-27 Eli Zaretskii <eliz@gnu.org>
994
995 * xdisp.c (move_it_to): Don't bail out early when reaching
996 position beyond to_charpos, if we are scanning backwards.
997 (move_it_vertically_backward): When DY == 0, make sure we get to
998 the first character in the line after the newline.
999
f2cad773
PE
10002011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1001
1002 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1003 (ccl_driver): Do not generate an out-of-range pointer.
1004 (Fccl_execute_on_string): Remove unnecessary check for
1005 integer overflow, noted by Stefan Monnier in
1006 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1007 Remove a FIXME that didn't need fixing.
1008 Simplify the newly-introduced buffer reallocation code.
1009
0cae2cdb
JB
10102011-08-27 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1013
5fc295a4 10142011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1015
70c60eb2 1016 Integer and memory overflow issues (Bug#9196).
726e0ab1 1017
d31850da
PE
1018 * doc.c (get_doc_string): Rework so that
1019 get_doc_string_buffer_size is the actual buffer size, rather than
1020 being 1 less than the actual buffer size; this makes xpalloc more
1021 convenient.
1022
a69fbedb
PE
1023 * image.c (x_allocate_bitmap_record, cache_image):
1024 * xselect.c (Fx_register_dnd_atom):
1025 Simplify previous changes by using xpalloc.
1026
fe5c5d37
PE
1027 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1028 since either will do and ptrdiff_t is convenient with xpalloc.
1029
0065d054
PE
1030 * charset.c (charset_table_size)
1031 (struct charset_sort_data.priority): Now ptrdiff_t.
1032 (charset_compare): Don't overflow if priorities differ greatly.
1033 (Fsort_charsets): Don't assume list length fits in int.
1034 Check for size-calculation overflow when allocating sort data.
1035 (syms_of_charset): Allocate an initial charset table that is
1036 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1037
1038 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1039
1040 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1041 The actual value is always <= INT_MAX, and leaving it unsigned made
1042 overflow checking harder.
1043
1044 * dispextern.h (struct glyph_matrix.rows_allocated)
1045 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1046 with xpalloc. The values are still always <= INT_MAX.
1047
1048 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1049
1050 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1051 (SAFE_NALLOCA): New macro.
1052
1053 * region-cache.c (struct boundary.pos, find_cache_boundary)
1054 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1055 (set_cache_region, invalidate_region_cache)
1056 (revalidate_region_cache, know_region_cache, region_cache_forward)
1057 (region_cache_backward, pp_cache):
1058 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1059 so that ptrdiff_t * can be passed to xpalloc.
1060 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1061 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1062 (pp_cache): Don't assume cache_len fits in int.
1063 * region-cache.h: Adjust extern decls to match.
1064
1065 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1066 EMACS_INT, since either will do, for xpalloc.
1067
1068 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1069 (xnmalloc, xnrealloc, xpalloc): New functions.
1070
726e0ab1
PE
1071 * bidi.c (bidi_shelve_header_size): New constant.
1072 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1073 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1074
51f30bc5 1075 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1076 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1077 (overlay_strings):
1078 Don't update size of array until after memory allocation succeeds,
1079 because xmalloc/xrealloc may not return.
0065d054
PE
1080 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1081 now that we have proper integer overflow checking.
1082 (record_overlay_string, overlay_strings): Catch overflows when
1083 calculating size of overlay_str_buf.
726e0ab1 1084
0065d054
PE
1085 * callproc.c (Fcall_process): Check for size overflow when
1086 calculating size of args2.
1087 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1088 Normally we prefer signed values, but sticking with ptrdiff_t would
1089 require adding more-complicated checks.
726e0ab1
PE
1090
1091 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1092 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1093 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1094 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1095
1096 * character.c (Fstring): Check for size-calculation overflow.
1097
1098 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1099 unnecessary integer overflow. Check for size overflow.
1100 (encode_coding_object): Don't update size until xmalloc succeeds.
1101
1102 * composite.c (get_composition_id): Check for overflow in glyph
1103 length calculations.
1104
1105 Integer and memory overflow fixes for display code.
1106 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1107 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1108 (scrolling_window): Check for overflow in size calculations.
1109 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1110 Don't assume glyph table len fits in int.
1111 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1112 (row_table_size): Now ptrdiff_t, not int.
1113 (scrolling_window): Avoid overflow in size calculations.
1114 Don't update size until allocation succeeds.
1115 * fns.c (concat): Check for overflow in size calculations.
1116 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1117 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1118 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1119
1120 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1121 (get_doc_string): Check for size calculation overflow.
1122 Don't update size until allocation succeeds.
1123 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1124 EMACS_INT, where ptrdiff_t will do.
1125 (Fsubstitute_command_keys): Check for string overflow.
1126
1127 * editfns.c (set_time_zone_rule): Don't assume environment length
1128 fits in int.
1129 (message_length): Now ptrdiff_t, not int.
1130 (Fmessage_box): Don't update size until allocation succeeds.
1131 Don't assume message length fits in int.
1132 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1133
0065d054
PE
1134 * emacs.c (main): Do not reallocate argv, since there is a null at
1135 the end that can be overwritten, and this way there's no need to
1136 worry about size-calculation overflow.
1137 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1138
1139 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1140 alloc succeeds.
1141 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1142
1143 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1144 (x_set_scroll_bar_width, x_figure_window_size):
1145 Check for integer overflow.
1146 (x_set_alpha): Do not assume XINT fits in int.
1147
1148 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1149 This is for the members text_lines, text_cols, total_lines, total_cols,
1150 where the system imposes an 'int' limit.
1151
1152 * fringe.c (Fdefine_fringe_bitmap):
1153 Don't update size until alloc works.
1154
1155 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1156 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1157
1158 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1159 Check for size-calculation overflow.
1160 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1161 do, as we prefer signed integers.
1162 (id_to_widget.max_size, id_to_widget.used)
1163 (xg_store_widget_in_map, xg_remove_widget_from_map)
1164 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1165 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1166 Use and return ptrdiff_t, not int.
1167 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1168 * gtkutil.h: Change prototypes to match the above.
1169
1170 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1171 are duplicate now that they've been promoted to lisp.h.
1172 (x_allocate_bitmap_record, x_alloc_image_color)
1173 (make_image_cache, cache_image, xpm_load):
1174 Don't update size until alloc is done.
1175 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1176 (x_detect_edges):
3256efce 1177 Check for size calculation overflow.
726e0ab1
PE
1178 (ct_colors_allocated_max): New constant.
1179 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1180 overflow.
3256efce 1181
726e0ab1
PE
1182 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1183 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1184 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1185 Use ptrdiff_t, not int, to count maps.
1186 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1187 calculations. Don't update size until allocation succeeds.
1188 Redo calculations to avoid overflow.
726e0ab1
PE
1189 * keyboard.h: Change prototypes to match the above.
1190
1191 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1192 to count maps.
1193 (current_minor_maps): Check for size calculation overflow.
1194 * keymap.h: Change prototypes to match the above.
1195
1196 * lread.c (read1, init_obarray): Don't update size until alloc done.
1197
1198 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1199 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1200
726e0ab1
PE
1201 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1202 Now ptrdiff_t, not int.
1203 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1204 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1205
1206 * process.c (Fnetwork_interface_list): Check for overflow
1207 in size calculation.
1208
1209 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1210
1211 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1212 overflow. Don't bother calling xmalloc when xrealloc will do.
1213
1214 * search.c (Freplace_match): Check for size calculation overflow.
1215 (Fset_match_data): Don't assume list lengths fit in 'int'.
1216
1217 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1218 for command line length. Do not attempt to address one before the
1219 beginning of an array, as that's not portable.
1220
1221 * term.c (max_frame_lines): Remove; unused.
1222 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1223 not int.
1224 (encode_terminal_code, calculate_costs): Check for size
1225 calculation overflow.
1226 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1227 table lengths and related sizes. Don't update size until alloc
1228 done. Redo calculations to avoid overflow.
1229 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1230
1231 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1232 subtracting pointers.
1233 (gobble_line): Check for overflow more carefully. Don't update size
1234 until alloc done.
1235
1236 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1237 Don't update size until alloc done.
1238 Redo size calculations to avoid overflow.
1239 Check for size calculation overflow.
0065d054 1240 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1241
1242 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1243 Use ptrdiff_t, not int, for sizes.
1244 (store_mode_line_noprop_char): Don't update size until alloc done.
1245
0065d054
PE
1246 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1247 Use ptrdiff_t, not int, for sizes.
1248 (Finternal_make_lisp_face, cache_face):
1249 Check for size calculation overflow.
1250 (cache_face): Treat size calculation overflows as if they were
1251 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1252
1253 * xfns.c (x_encode_text, x_set_name_internal)
1254 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1255 sizes, since they can exceed INT_MAX in size. Check for size
1256 calculation overflow.
1257
0065d054
PE
1258 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1259 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1260 Don't update size until alloc done.
1261
0065d054 1262 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1263 as sprintf is limited to int lengths.
1d526e2f 1264
252c5ee1
PE
1265 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1266 (X_LONG_MIN): New macros.
864d7ce7
PE
1267 Use them to make the following changes clearer.
1268 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1269 This change doesn't affect the value now, but it may help remind
1270 future maintainers not to raise the value too much later.
1271 (SELECTION_QUANTUM): Remove, replacing with ...
1272 (selection_quantum): ... new function, which avoids overflow.
1273 All uses changed.
1274 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1275 assumption that selection length fits in 'int'.
1276 (x_reply_selection_request, x_handle_selection_request)
1277 (x_get_window_property, receive_incremental_selection)
1278 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1279 (lisp_data_to_selection_data, clean_local_selection_data):
1280 Use ptrdiff_t, not int, to record length of selection.
1281 (x_reply_selection_request, x_get_window_property)
1282 (receive_incremental_selection, x_property_data_to_lisp):
1283 Redo calculations to avoid overflow.
1284 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1285 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1286 something.
1287 (x_get_window_property, receive_incremental_selection)
1288 (lisp_data_to_selection_data, x_property_data_to_lisp):
1289 Check for size-calculation overflow.
1290 (x_get_window_property, receive_incremental_selection)
1291 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1292 Don't store size until memory allocation succeeds.
1293 (x_get_window_property): Plug memory leak on memory exhaustion.
1294 Don't double-block input; malloc is safe here. Don't assume 2**34
1295 - 4 fits in unsigned long. Add an xassert to check
1296 XGetWindowProperty overflow. Be more careful about overflow
1297 calculations, and distinguish size from memory overflow better.
1298 (receive_incremental_selection): When tracing, don't assume
1299 unsigned int is less than INT_MAX.
1300 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1301 harmful) conversions of unsigned short to int.
1302 (lisp_data_to_selection_data): Don't assume that integers
1303 in the range -65535 through -1 fit in an X unsigned short.
1304 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1305 result parameters unless successful. Rely on cons_to_unsigned
1306 to report problems with elements; the old code wasn't right anyway.
1307 (x_check_property_data): Check for int overflow; we cannot use
1308 a wider type due to X limits.
1309 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1310
726e0ab1 1311 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1312
0065d054
PE
1313 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1314 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1315 (x_color_cells): Don't store size until memory allocation succeeds.
1316 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1317 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1318 (x_term_init): Don't assume length fits in int (sprintf is limited
1319 to int size).
bc18e09d 1320
ebfa62c0
PE
1321 Use ptrdiff_t for composition IDs.
1322 * character.c (lisp_string_width):
1323 * composite.c (composition_table_size, n_compositions)
1324 (get_composition_id, composition_gstring_from_id):
1325 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1326 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1327 * window.c (Frecenter):
1328 Use ptrdiff_t, not int, for composition IDs.
1329 * composite.c (get_composition_id): Check for integer overflow.
1330 * composite.h: Adjust prototypes to match the above changes.
1331
d3411f89
PE
1332 Use ptrdiff_t for hash table indexes.
1333 * category.c (hash_get_category_set):
1334 * ccl.c (ccl_driver):
1335 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1336 * coding.c (coding_system_charset_list, detect_coding_system):
1337 * coding.h (struct coding_system.id):
1338 * composite.c (get_composition_id, gstring_lookup_cache):
1339 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1340 * image.c (xpm_get_color_table_h):
1341 * lisp.h (hash_lookup, hash_put):
1342 * minibuf.c (Ftest_completion):
1343 Use ptrdiff_t for hash table indexes, not int (which is too
1344 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1345 32-bit --with-wide-int hosts).
1346
e097a6fa
PE
1347 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1348 Add a FIXME comment about memory leaks.
1349 (syms_of_charset): Don't assume xmalloc returns.
1350
5637687f
PE
1351 Don't assume that stated character widths fit in int.
1352 * character.c (Fchar_width, c_string_width, lisp_string_width):
1353 * character.h (CHAR_WIDTH):
1354 * indent.c (MULTIBYTE_BYTES_WIDTH):
1355 Use sanitize_char_width to avoid undefined and/or bad behavior
1356 with outlandish widths.
a66cfb1c 1357 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1358 now that we have two such functions. All uses changed.
1359 (sanitize_char_width): New inline function.
1360
a2271ba2
PE
1361 Don't assume that tab-width fits in int.
1362 * character.h (sanitize_width): New inline function.
1363 (SANE_TAB_WIDTH): New macro.
1364 (ASCII_CHAR_WIDTH): Use it.
1365 * indent.c (sane_tab_width): Remove. All uses replaced by
1366 SANE_TAB_WIDTH (current_buffer).
1367 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1368
18c52557
PE
1369 * fileio.c: Integer overflow issues with file modes.
1370 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1371
caeeedc1
PE
1372 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1373 Remove unreachable code.
1374 (read_hex, load_charset_map_from_file): Check for integer overflow.
1375
50849c52
PE
1376 * xterm.c: don't go over XClientMessageEvent limit
1377 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1378 (x_send_scroll_bar_event): Likewise. Check that the size does not
1379 exceed limits imposed by XClientMessageEvent, as well as the usual
1380 ptrdiff_t and size_t limits.
1381
b13995db
PE
1382 * keyboard.c: Overflow, signedness and related fixes.
1383 (make_lispy_movement): Use same integer type in forward decl
1384 that is used in the definition.
1385 (read_key_sequence, keyremap_step):
1386 Change bufsize argument back to int, undoing my 2011-03-30 change.
1387 We prefer signed types, and int is wide enough here.
1388 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1389 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1390 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1391 length, not size_t. Use ptrdiff_t for index, not int.
1392 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1393 possibility of integer overflow.
1394
13464394
PE
1395 Overflow, signedness and related fixes for images.
1396
1397 * dispextern.h (struct it.stack[0].u.image.image_id)
1398 (struct_it.image_id, struct image.id, struct image_cache.size)
1399 (struct image_cache.used, struct image_cache.ref_count):
1400 * gtkutil.c (update_frame_tool_bar):
1401 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1402 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1403 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1404 * nsmenu.m (update_frame_tool_bar):
1405 * xdisp.c (calc_pixel_width_or_height):
1406 * xfns.c (image_cache_refcount):
1407 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1408 on typical 64-bit hosts.
1409
1410 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1411 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1412 Omit unnecessary casts to int.
1413 (parse_image_spec): Check that integers fall into 'int' range
1414 when the callers expect that.
1415 (image_ascent): Redo ascent calculation to avoid int overflow.
1416 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1417 (lookup_image): Remove unnecessary tests.
1418 (xbm_image_p): Locals are now of int, not EMACS_INT,
1419 since parse_image_check makes sure they fit into int.
1420 (png_load, gif_load, svg_load_image):
1421 Prefer int to unsigned where either will do.
1422 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1423 old tiff_error_handler and tiff_warning_handler.
1424 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1425 stack buffer overflows. It uses only the features of vsnprintf
1426 that are common to both POSIX and native Microsoft.
1427 (tiff_error_handler, tiff_warning_handler): Use it.
1428 (tiff_load, gif_load, imagemagick_load_image):
1429 Don't assume :index value fits in 'int'.
1430 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1431 (imagemagick_load_image): Check that crop parameters fit into
1432 the integer types that MagickCropImage accepts. Don't assume
1433 Vimagemagick_render_type has a nonnegative value. Don't assume
1434 size_t fits in 'long'.
1435 (gs_load): Use printmax_t to print the widest integers possible.
1436 Check for integer overflow when computing image height and width.
1437
c11821d4
EZ
14382011-08-26 Eli Zaretskii <eliz@gnu.org>
1439
1440 * xdisp.c (redisplay_window): Don't force window start if point
1441 will be invisible in the resulting window. (Bug#9324)
1442
0c95fcf7
EZ
14432011-08-25 Eli Zaretskii <eliz@gnu.org>
1444
1445 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1446 the display spec is of the form `(space ...)'.
1447 (handle_display_spec): Return the value returned by
1448 handle_single_display_spec, not just 1 or zero.
1449 (handle_single_display_spec): If the display spec is of the form
1450 `(space ...)', and specifies display in the text area, return 2
1451 rather than 1.
fee65a97 1452 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1453 accurately, and prefer exact match for point under bidi.
1454 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1455
1456 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1457 into disp_prop; all users changed.
1458
1459 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1460 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1461 for the text covered by the display property.
1462
e4ed06f1
CY
14632011-08-25 Chong Yidong <cyd@stupidchicken.com>
1464
1465 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1466 Change return value to nil.
1467 (Frecord_buffer): Delete unused function.
1468
f67cdd7f
EZ
14692011-08-24 Eli Zaretskii <eliz@gnu.org>
1470
5980d4c6
EZ
1471 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1472 buffers, return left-to-right.
8610fe8b
EZ
1473 (set_cursor_from_row): Consider candidate row a win if its glyph
1474 represents a newline and point is on that newline. Fixes cursor
1475 positioning on the newline at EOL of R2L text within L2R
1476 paragraph, and vice versa.
1477 (try_cursor_movement): Check continued rows, in addition to
1478 continuation rows. Fixes unwarranted scroll when point enters a
1479 continued line of R2L text within an L2R paragraph, or vice versa.
1480 (cursor_row_p): Consider the case of point being equal to
1481 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1482 from the end of a short line to the beginning of a continued line
1483 of R2L text within L2R paragraph.
1484 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1485 composed characters.
5980d4c6 1486
f67cdd7f
EZ
1487 * bidi.c (bidi_check_type): Use xassert.
1488 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1489 members.
1490
bca633fb
EZ
14912011-08-23 Eli Zaretskii <eliz@gnu.org>
1492
1493 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1494 a character.
1495
4a5885a7
CY
14962011-08-23 Chong Yidong <cyd@stupidchicken.com>
1497
1498 * nsfont.m (ns_otf_to_script): Fix typo.
1499
0902a04e
KH
15002011-08-22 Kenichi Handa <handa@m17n.org>
1501
1502 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1503 extra slot even if the purpose is char-code-property-table.
1504
1a2e6670
EZ
15052011-08-23 Eli Zaretskii <eliz@gnu.org>
1506
8ddde651
EZ
1507 * xdisp.c (redisplay_window): When computing centering_position,
1508 account for the height of the header line. (Bug#8874)
1509
425cc014
EZ
1510 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1511 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1512 candidate is selected by the mouse, and that candidate has a
1513 composed character under the mouse.
1514
1a2e6670
EZ
1515 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1516 coordinates reported by pos-visible-in-window-p for a composed
1517 character in column zero.
1518
8b76d6f8
SM
15192011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1520
1521 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1522
dac347dd
EZ
15232011-08-22 Eli Zaretskii <eliz@gnu.org>
1524
1525 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1526 consider it a hit if to_charpos is anywhere in the range of the
1527 composed buffer positions.
1528
e013fb34
CY
15292011-08-22 Chong Yidong <cyd@stupidchicken.com>
1530
1531 * image.c (gif_load): Don't assume that each subimage has the same
1532 dimensions as the base image. Handle disposal method that is
1533 "undefined" by the gif spec (Bug#9335).
1534
bd1ba3e8
CY
15352011-08-20 Chong Yidong <cyd@stupidchicken.com>
1536
1537 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1538 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1539
54a1215b
EZ
15402011-08-19 Eli Zaretskii <eliz@gnu.org>
1541
823564e5
EZ
1542 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1543 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1544 from an Org mode buffer to a Speedbar frame.
1545
54a1215b
EZ
1546 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1547 a composition, take its buffer position from IT->cmp_it.charpos.
1548 Fixes cursor positioning at the beginning of a line that begins
1549 with a composed character.
1550
9778ebcc
EZ
15512011-08-18 Eli Zaretskii <eliz@gnu.org>
1552
0be6ee06
EZ
1553 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1554 character bidirectional type, use STRONG_L instead. Fixes crashes
1555 in a buffer produced by `describe-categories'.
1556
9778ebcc
EZ
1557 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1558 members before the level stack, so they would be saved and
1559 restored when copying iterator state. Fixes incorrect reordering
1560 around TABs covered by display properties.
1561
156bffbe
AS
15622011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1563
6b02f655 1564 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1565
72ad093b
CY
15662011-08-17 Chong Yidong <cyd@stupidchicken.com>
1567
1568 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1569 (internal_condition_case_2, internal_condition_case_n):
1570 Remove unnecessary aborts (Bug#9081).
72ad093b 1571
35774242
EZ
15722011-08-17 Eli Zaretskii <eliz@gnu.org>
1573
1574 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1575 has no `load' handler, try opening the file locally. (Bug#9311)
1576
db76dd85
KB
15772011-08-16 Ken Brown <kbrown@cornell.edu>
1578
1579 * gmalloc.c: Expand comment.
1580
b215eee5
EZ
15812011-08-16 Eli Zaretskii <eliz@gnu.org>
1582
1583 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1584 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1585
a4579d33
KB
15862011-08-16 Ken Brown <kbrown@cornell.edu>
1587
1588 Fix memory allocation problems in Cygwin build (Bug#9273).
1589
1590 * unexcw.c ( __malloc_initialized): Declare external variable.
1591 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1592
8b76d6f8
SM
1593 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1594 New variables.
a4579d33
KB
1595 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1596 dumped emacs.
1597 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1598 in the static heap.
1599 [CYGWIN] (special_realloc): New function.
1600 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1601 requests to realloc storage in the static heap.
1602
3ebec551
PE
16032011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1604
1605 * bidi.c (bidi_initialize): Remove unused local.
1606
9fd8be00
EZ
16072011-08-15 Eli Zaretskii <eliz@gnu.org>
1608
6b02f655
SM
1609 * bidimirror.h:
1610 * biditype.h: Remove file.
1611 * makefile.w32-in ($(BLD)/bidi.$(O)):
1612 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1613
1614 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1615
1616 * chartab.c: Improve commentary for the uniprop_table API.
1617
32413314
EZ
1618 * bidi.c (bidi_paragraph_init): Support zero value of
1619 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1620 (bidi_initialize): Use uniprop_table instead of including
1621 biditype.h and bidimirror.h.
32413314 1622
9fd8be00
EZ
1623 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1624 coordinates of the iterator when restoring from ppos_it.
1625 (Bug#9296)
1626
5cf2b69b
KH
16272011-08-14 Kenichi Handa <handa@m17n.org>
1628
1629 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1630 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1631
daf17d00
EZ
16322011-08-14 Eli Zaretskii <eliz@gnu.org>
1633
1634 * xdisp.c (move_it_in_display_line_to): Don't invoke
1635 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1636 ppos_it. Fixes vertical cursor motion when line beginning is
1637 covered by an image. (Bug#9296)
1638
08e3161a
JD
16392011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1640
1641 * nsterm.h (ns_run_ascript): Declare.
1642 (NSAPP_DATA2_RUNASSCRIPT): Define.
1643
1644 * nsfns.m (as_script, as_result, as_status): New static variables.
1645 (ns_run_ascript): New function.
5e617bc2 1646 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1647 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1648 the event loop. Get status from as_status (Bug#7276).
1649
1650 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1651 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1652 the event loop (Bug#7276).
1653
a3720aa2
AS
16542011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1655
1656 * gnutls.c (QCgnutls_bootprop_priority)
1657 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1658 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1659 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1660 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1661 (QCgnutls_bootprop_verify_hostname_error)
1662 (QCgnutls_bootprop_callbacks_verify): Rename from
1663 Qgnutls_bootprop_..., all uses changed.
1664
1665 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1666 uses changed.
1667
0a0d27fb
PE
16682011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1669
19d5c50c
PE
1670 * xfaces.c (Qframe_set_background_mode): Now static.
1671 * dispextern.h (Qframe_set_background_mode): Remove decl.
1672
0a0d27fb
PE
1673 * process.c (Fnetwork_interface_info): Declare local only if needed.
1674
377538cb
JD
16752011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1676
1677 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1678 (Fnetwork_interface_list): Allocate in increments of bytes instead
1679 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1680 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1681 sockaddr.
1682 (struct ifflag_def): notrailers is smart on OSX.
1683 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1684 Get hardware address with getifaddrs if available.
1685
08fff70c
EZ
16862011-08-12 Eli Zaretskii <eliz@gnu.org>
1687
1688 * xdisp.c (iterate_out_of_display_property): xassert that
1689 IT->position is set to within IT->object's boundaries. Break from
1690 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1691 when IT->position is set up wrongly due to some bug.
1692 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1693 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1694 entry. Force push_it to save on the stack the current
1695 buffer/string position, to be restored by pop_it. Fix flags in
1696 the iterator structure wrt the object coming from a display
1697 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1698 properties. (Bug#9284)
1699
7be1c708 17002011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1701
7be1c708
CY
1702 * fontset.c (fontset_get_font_group): Add proper type checks.
1703 (Bug#9172)
aac0c6e3 1704
7be1c708 17052011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1706
7be1c708
CY
1707 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1708 and LC_VERSION_MIN_MACOSX.
1709 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1710 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1711
97bb72a6
EZ
17122011-08-08 Eli Zaretskii <eliz@gnu.org>
1713
1714 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1715 no-display-properties-and-no-overlays under bidi display.
1716 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1717 properties and overlays.
97bb72a6 1718
d5617611
CY
17192011-08-08 Chong Yidong <cyd@stupidchicken.com>
1720
37e11a63
CY
1721 * editfns.c (Fset_time_zone_rule): Document relationship with the
1722 setenv function.
1723
d5617611
CY
1724 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1725 the font entity extracted from the cache (Bug#8109).
1726
58872834
CY
17272011-08-07 Chong Yidong <cyd@stupidchicken.com>
1728
1729 * composite.c (autocmp_chars): Don't reset point. That is done by
1730 restore_point_unwind (Bug#5984).
1731
75bfc667
JL
17322011-08-07 Juri Linkov <juri@jurta.org>
1733
1734 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1735 to show the arg `TIME' instead of `TIMEVAL'.
1736
d1410150
EZ
17372011-08-06 Eli Zaretskii <eliz@gnu.org>
1738
1739 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1740 display property strides EOL and includes a newline, as in
1741 longlines-mode. (Bug#9254)
75b771e4
EZ
1742 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1743 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1744
1745 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1746 is non-zero, even if the data buffer is NULL. Fixes a crash in
1747 vertical-motion with longlines-mode. (Bug#9254)
1748
35928349
EZ
17492011-08-05 Eli Zaretskii <eliz@gnu.org>
1750
ec7cc85b
EZ
1751 * bidi.c <bidi_cache_total_alloc>: Now static.
1752 (bidi_initialize): Initialize bidi_cache_total_alloc.
1753
8b76d6f8 1754 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1755 cache. (Bug#9221)
1756
1757 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1758 amount allocated this far in `bidi_cache_total_alloc'.
1759 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1760 non-zero, only free the data buffer without restoring the cache
1761 contents. All callers changed.
1762
1763 * dispextern.h (bidi_unshelve_cache): Update prototype.
1764
1765 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1766 (move_it_in_display_line, move_it_to)
1767 (move_it_vertically_backward, move_it_by_lines): Replace the call
1768 to xfree to an equivalent call to bidi_unshelve_cache.
1769 (move_it_in_display_line_to): Fix logic of returning
412b6358 1770 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1771
e2e2423b
EZ
17722011-08-05 Eli Zaretskii <eliz@gnu.org>
1773
1774 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1775 came from a string character with a `cursor' property. (Bug#9229)
1776
ae9e757a
JD
17772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1778
1779 * Makefile.in (LIB_PTHREAD): New variable.
1780 (LIBES): Add LIB_PTHREAD (Bug#9216).
1781
1782 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1783 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1784
213bd7f2
AS
17852011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1786
6b02f655 1787 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1788
99aaf75f
JD
17892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1790
1791 * xterm.c (x_find_topmost_parent): New function.
1792 (x_set_frame_alpha): Find topmost parent window with
1793 x_find_topmost_parent and set the property there also (bug#9181).
1794 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1795
c74e9d86
PE
17962011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 * callproc.c (Fcall_process): Avoid vfork clobbering
1799 the local vars buffer, coding_systems, current_dir.
1800
640c8776
SM
18012011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1802
1803 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1804
f26d0e4c
PE
18052011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1806
8a10d76c
PE
1807 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1808 so that it is not optimized away.
1809
f26d0e4c
PE
1810 * xdisp.c (compute_display_string_pos): Remove unused local.
1811
55439c61
EZ
18122011-08-02 Eli Zaretskii <eliz@gnu.org>
1813
1814 Fix slow cursor motion and scrolling in large buffers with
1815 selective display, like Org Mode buffers. (Bug#9218)
1816
1817 * dispextern.h (struct bidi_it): New member disp_prop_p.
1818
1819 * xdisp.c: Remove one-slot cache of display string positions.
1820 (compute_display_string_pos): Accept an additional argument
5e617bc2 1821 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1822 for a display string or property. If found, set DISP_PROP_P
1823 non-zero.
1824
1825 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1826 DISP_PROP_P, and pass it to compute_display_string_pos.
1827 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1828 non-zero. All callers of bidi_fetch_char changed.
1829
fb33fa43
SM
18302011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1831
1832 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1833
b099e063
DM
18342010-12-03 Don March <don@ohspite.net>
1835
1836 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1837 last character M-[char] is translated to ESC [char] (bug#7541).
1838
5cc7f7af
KH
18392011-08-02 Kenichi Handa <handa@m17n.org>
1840
d0fffa3f 1841 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1842
1843 * chartab.c (uniprop_table): Make it non-static.
1844
525d5e6e
EZ
18452011-08-01 Eli Zaretskii <eliz@gnu.org>
1846
1847 * xdisp.c (forward_to_next_line_start): Accept additional argument
1848 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1849 on the newline.
1850 (reseat_at_next_visible_line_start): Use the bidi iterator state
1851 returned by forward_to_next_line_start to restore the state of
1852 it->bidi_it after backing up to previous newline. (Bug#9212)
1853
31011111
AS
18542011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1855
1856 * regex.c (re_comp): Protoize.
1857 (re_exec): Fix return type.
1858 (regexec): Fix type of `ret'. (Bug#9203)
1859
476371c4
PE
18602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1861
e5d76069
PE
1862 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1863 This is needed if max-image-size is a floating-point number.
1864
9a79b20c
AS
18652011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1866
1867 * print.c (print_object): Print empty symbol as ##.
1868
1869 * lread.c (read1): Read ## as empty symbol.
1870
d8c2fa78
AA
18712011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1872
1873 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1874 setting frame foreground color (Bug#9175).
1875 (x_set_background_color): Likewise.
1876
ffe57a7a
AA
1877 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1878 contents (Bug#9176).
1879 (EmacsTooltip -init): Remove bezels and add shadows to
1880 tooltip windows.
1881
bf3492a5
AA
1882 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1883 or scroll bar (Bug#8470).
1884
d55e9c53
AA
1885 * nsfont.m (nsfont_open): Remove assignment to voffset and
1886 unnecessary vars hshink, expand, hd, full_height, min_height.
1887 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1888
1889 * nsterm.h (nsfont_info): Remove voffset field.
1890
d8c2fa78 18912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1892
1893 Implement strike-through and overline on NextStep (Bug#8863).
1894
1895 * nsfont.m (nsfont_open): Use underline position provided by font,
1896 instead of hard-coded value of 2.
1897 (nsfont_draw): Call ns_draw_text_decoration instead.
1898
1899 * nsterm.h: Add declaration for ns_draw_text_decoration.
1900
1901 * nsterm.m (ns_draw_text_decoration): New function for drawing
1902 underline, overline, and strike-through.
1903 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1904 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1905 accommodate underlining, etc.
4843aac3 1906
4cc60b9b
EZ
19072011-07-28 Eli Zaretskii <eliz@gnu.org>
1908
bc7ece87
EZ
1909 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1910 default.
4cc60b9b 1911
476371c4
PE
19122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1913
66606eea
PE
1914 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1915 Without this fix, if a signal arrives just after memory fills up,
1916 'malloc' might be invoked reentrantly.
1917
476371c4
PE
1918 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1919 In other words, assume that every image size is allowed, on non-X
1920 hosts. This assumption is probably wrong, but it lets Emacs compile.
1921
f3fcc40d
AS
19222011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1923
1924 * regex.c (re_iswctype): Convert return values to boolean.
1925
350c992f
EZ
19262011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1927
1928 * xdisp.c (compute_display_string_pos): Don't use cached display
1929 string position if the buffer had its restriction changed.
1930 (Bug#9184)
1931
5266b4bb
PE
19322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1935
2573a837 19362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1937
41f55ccd 1938 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1939
39e378da
PE
1940 * bidi.c: Integer size and overflow fixes.
1941 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1942 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1943 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1944 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1945 (bidi_find_other_level_edge):
1946 Use ptrdiff_t instead of EMACS_INT where either will do.
1947 This works better on 32-bit hosts configured --with-wide-int.
1948 (bidi_cache_ensure_space): Check for size-calculation overflow.
1949 Use % rather than repeated addition, for better worst-case speed.
1950 Don't set bidi_cache_size until after xrealloc returns, because it
1951 might not return.
1952 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1953 (bidi_cache_ensure_space): Also check that the bidi cache size
1954 does not exceed that of the largest Lisp string or buffer. See Eli
1955 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1956
5e927815
PE
1957 * alloc.c (__malloc_size_t): Remove.
1958 All uses replaced by size_t. See Andreas Schwab's note
1959 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1960
ca4aa935
PE
1961 * image.c: Improve checking for integer overflow.
1962 (check_image_size): Assume that f is nonnull, since
1963 it is always nonnull in practice. This is one less thing to
1964 worry about when checking for integer overflow later.
1965 (x_check_image_size): New function, which checks for integer
1966 overflow issues inside X.
1967 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1968 This removes the need for a memory_full check.
1969 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1970 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1971 (xbm_read_bitmap_data): Change locals back to 'int', since
1972 their values must fit in 'int'.
1973 (xpm_load_image, png_load, tiff_load):
1974 Invoke x_create_x_image_and_pixmap earlier,
1975 to avoid much needless work if the image is too large.
1976 (tiff_load): Treat overly large images as if
1977 x_create_x_image_and_pixmap failed, not as malloc failures.
1978 (gs_load): Use x_check_image_size.
1979
5f8f9cc2
PE
1980 * gtkutil.c: Omit integer casts.
1981 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1982 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1983
5adf60bc
PE
1984 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1985
c8907a93
PE
1986 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1987 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1988 would wrongly return t on a 64-bit host.
1989
e3c25c68
PE
1990 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1991 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1992 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1993 and therefore cause GCC to emit a bogus diagnostic in some cases.
1994
3f791afe
PE
1995 * image.c: Integer signedness and overflow and related fixes.
1996 This is not an exhaustive set of fixes, but it's time to
1997 record what I've got.
1998 (lookup_pixel_color, check_image_size): Remove redundant decls.
1999 (check_image_size): Don't assume that arbitrary EMACS_INT values
2000 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2001 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2002 (tiff_load, imagemagick_load_image):
2003 Check for overflow in size calculations.
2004 (x_create_x_image_and_pixmap): Remove unnecessary test for
2005 xmalloc returning NULL; that can't happen.
2006 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2007 (xpm_color_bucket): Use better integer hashing function.
2008 (xpm_cache_color): Don't possibly over-allocate memory.
2009 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2010 (gif_memory_source):
2011 Use ptrdiff_t, not int or size_t, to record sizes.
2012 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2013 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2014 either works, as we prefer signed integers.
2015 (tiff_read_from_memory, tiff_write_from_memory):
2016 Return tsize_t, not size_t, since that's what the TIFF API wants.
2017 (tiff_read_from_memory): Don't fail simply because the read would
2018 go past EOF; instead, return a short read.
2019 (tiff_load): Omit no-longer-needed casts.
2020 (Fimagemagick_types): Don't assume size fits into 'int'.
2021
3cc5a532
PE
2022 Improve hashing quality when configured --with-wide-int.
2023 * fns.c (hash_string): New function, taken from sxhash_string.
2024 Do not discard information about ASCII character case; this
2025 discarding is no longer needed.
2026 (sxhash-string): Use it. Change sig to match it. Caller changed.
2027 * lisp.h: Declare it.
2028 * lread.c (hash_string): Remove, since we now use fns.c's version.
2029 The fns.c version returns a wider integer if --with-wide-int is
2030 specified, so this should help the quality of the hashing a bit.
2031
b312a492
PE
2032 * emacs.c: Integer overflow minor fix.
2033 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2034 Define only if GNU_LINUX.
2035 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2036
dfd153ae
PE
2037 * dispnew.c: Integer signedness and overflow fixes.
2038 Remove unnecessary forward decls, that were a maintenance hassle.
2039 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2040 All uses changed.
2041 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2042 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2043 (prepare_desired_row, line_draw_cost):
2044 Use int, not unsigned, where either works.
2045 (save_current_matrix, restore_current_matrix):
2046 Use ptrdiff_t, not size_t, where either works.
2047 (init_display): Check for overflow more accurately, and without
2048 relying on undefined behavior.
2049
a81d11a3
PE
2050 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2051 Remove, replacing with the new symbols in lisp.h. All uses changed.
2052 * fileio.c (make_temp_name):
2053 * filelock.c (lock_file_1, lock_file):
2054 * xdisp.c (message_dolog):
2055 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2056 Use pMd etc. instead.
2057 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2058 replacing the pWIDE etc. symbols removed from editfns.c.
2059
3300e6fd
PE
2060 * keyboard.h (num_input_events): Now uintmax_t.
2061 This is (very slightly) less likely to mess up due to wraparound.
2062 All uses changed.
2063
fd05c7e9
PE
2064 * buffer.c: Integer signedness fixes.
2065 (alloc_buffer_text, enlarge_buffer_text):
2066 Use ptrdiff_t rather than size_t when either will do, as we prefer
2067 signed integers.
2068
903fe15d
PE
2069 * alloc.c: Integer signedness and overflow fixes.
2070 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2071 (__malloc_size_t): Default to size_t, not to int.
2072 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2073 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2074 Prefer ptrdiff_t to size_t when either would do, as we prefer
2075 signed integers.
2076 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2077 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2078 Now const. Initialize with values that are in range even if char
2079 is signed.
2080 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2081 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2082 These functions do the right thing with sizes > 2**32.
2083 (check_depth): Now ptrdiff_t, not int.
2084 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2085 Adjust to new way of storing sizes. Check for size overflow bugs
2086 in rest of code.
2087 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2088 slightly wrong anyway, as it missed one instance of
2089 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2090 (refill_memory_reserve): Omit needless cast to size_t.
2091 (mark_object_loop_halt): Mark as externally visible.
2092
ac82cc6a
PE
2093 * xselect.c: Integer signedness and overflow fixes.
2094 (Fx_register_dnd_atom, x_handle_dnd_message):
2095 Use ptrdiff_t, not size_t, since we prefer signed.
2096 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2097 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2098 x_dnd_atoms_size and x_dnd_atoms_length.
2099
c2d1e36d
PE
2100 * doprnt.c: Prefer signed to unsigned when either works.
2101 * eval.c (verror):
2102 * doprnt.c (doprnt):
2103 * lisp.h (doprnt):
2104 * xdisp.c (vmessage):
2105 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2106 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2107 prefer signed arithmetic to avoid comparison confusion.
2108 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2109 but is a bit tricky.
2110
0e926e56
PE
2111 Assume freestanding C89 headers, string.h, stdlib.h.
2112 * data.c, doprnt.c, floatfns.c, print.c:
2113 Include float.h unconditionally.
2114 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2115 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2116 * regex.c: Likewise for stddef.h, string.h.
2117 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2118 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2119 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2120 (STDC_HEADERS): Remove obsolete defines.
2121 * sysdep.c: Include limits.h unconditionally.
2122
9cfdb3ec
PE
2123 Assume support for memcmp, memcpy, memmove, memset.
2124 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2125 * regex.c (memcmp, memcpy):
2126 Remove; we assume C89 now.
2127
2128 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2129 (__malloc_safe_bcopy): Remove; no longer needed.
2130
cf950e6b 2131 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2132 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2133 well either way, and we prefer signed to unsigned.
2134
dbf38e02
LMI
21352011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2136
2137 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2138 closes the connection while we're reading (bug#9182).
2139
d6f0886c 21402011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2141
d6f0886c
JD
2142 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2143 are specified (Bug#9168).
24e0f6b1 2144
2eb1f9e6
PE
21452011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2146
2147 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2148 Found by GCC static checking and --with-wide-int on a 32-bit host.
2149
22381272 21502011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2151
2152 * xdisp.c (compute_display_string_pos): Fix logic of caching
2153 previous display string position. Initialize cached_prev_pos to
2154 -1. Fixes slow-down at the beginning of a buffer.
2155
f25e39b4
EZ
21562011-07-24 Eli Zaretskii <eliz@gnu.org>
2157
2158 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2159 for attrs[LFACE_FONTSET_INDEX].
2160
04c4b52e
PE
21612011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * xml.c (parse_region): Remove unused local
2164 that was recently introduced.
2165
c1734fbd
EZ
21662011-07-23 Eli Zaretskii <eliz@gnu.org>
2167
be18c5a5
EZ
2168 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2169 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2170
c1734fbd
EZ
2171 * xdisp.c (move_it_in_display_line_to): Record the best matching
2172 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2173 exit if none of the characters scanned was an exact match.
2174 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2175 when exact match is impossible due to invisible text, and the
2176 lines are truncated.
2177
a258d627
JD
21782011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2179
2180 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2181 for OSX >= 10.7.
2182
b6d5a689
EZ
21832011-07-22 Eli Zaretskii <eliz@gnu.org>
2184
0f74f785
EZ
2185 Fix a significant slow-down of cursor motion with C-n, C-p,
2186 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2187 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2188 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2189 (next_element_from_buffer): Call compute_stop_pos_backwards to
2190 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2191 base_level_stop.
2192 (reseat): Don't look for prev_stop, as that could mean a very long
2193 run.
2194 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2195 <cached_disp_overlay_modiff>: Cache for last found display string
2196 position.
551918c1 2197 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2198 about the same buffer in the same area of character positions, and
2199 the buffer wasn't changed since the time the display string
2200 position was cached.
551918c1 2201
b2d0c91a
EZ
22022011-07-22 Eli Zaretskii <eliz@gnu.org>
2203
2204 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2205 is an integer, which is important for empty lines. (Bug#9149)
2206
043604ee
CY
22072011-07-22 Chong Yidong <cyd@stupidchicken.com>
2208
2209 * frame.c (Fmodify_frame_parameters): In tty case, update the
2210 default face if necessary (Bug#4238).
2211
da4adb04
CY
22122011-07-21 Chong Yidong <cyd@stupidchicken.com>
2213
2214 * editfns.c (Fstring_to_char): No need to explain what a character
2215 is in the docstring (Bug#6576).
2216
9abd0532
LMI
22172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2218
2219 * xml.c (parse_region): Make sure we always return a tree.
2220
36881d16
HK
22212011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2222
2223 * xml.c (parse_region): If a document contains only comments,
2224 return that, too.
2225
1e98674d
LMI
22262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2227
2228 * xml.c (make_dom): Return comments, too.
2229
590bd467
PE
22302011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2231
2232 Port to OpenBSD.
2233 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2234 and the surrounding thread.
2235 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2236 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2237 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2238 timer goes off.
2239 * s/openbsd.h (BROKEN_SIGIO): Define.
2240 * unexelf.c (unexec) [__OpenBSD__]:
2241 Don't update the .mdebug section of the Alpha COFF symbol table.
2242
f41628b2
LMI
22432011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2244
2245 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2246 (bug#8460).
2247
b59b67c5
PE
22482011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2249
15e3a074
PE
2250 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2251 This fixes some race conditions on the permissions of any newly
2252 created file.
2253
41bed37d
PE
2254 * alloc.c (valid_pointer_p): Use pipe, not open.
2255 This fixes some permissions issues when debugging.
2256
b59b67c5
PE
2257 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2258 If fchown fails to set both uid and gid, try to set just gid,
2259 as that is sometimes allowed. Adjust the file's mode to eliminate
2260 setuid or setgid bits that are inappropriate if fchown fails.
2261
925a6be7
SM
22622011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2263
2264 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2265 to compare Lisp_Objects.
2266 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2267 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2268 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2269
52968808
AS
22702011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2271
0a6a104b
AS
2272 * lread.c (read_integer): Unread even EOF character.
2273 (read1): Likewise. Properly record start position of symbol.
2274
52968808
AS
2275 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2276 symbol character follows.
2277
9e381cdd
PE
22782011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2281 This works around a problem with the previous change to Fcopy_file.
2282 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2283 and without this change, GCC might complain about discarding
2284 fchown's return value.
2285
b5641435
JB
22862011-07-16 Juanma Barranquero <lekktu@gmail.com>
2287
2288 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2289
a8031457
PE
22902011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2291
2292 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2293
dd889327
LMI
22942011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2295
750c33f7
LMI
2296 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2297 it's used from the C level.
2298
dd889327
LMI
2299 * process.c: Use the same condition for POLL_FOR_INPUT in both
2300 keyboard.c and process.c (bug#1858).
2301
87e86684
LM
23022011-07-09 Lawrence Mitchell <wence@gmx.li>
2303
2304 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2305 (Fgnutls_boot): Use it.
2306
64348f40
AS
23072011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2308
2309 * doc.c (Fsubstitute_command_keys): Revert last change.
2310
1d698799
LMI
23112011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2312
f863868c
LMI
2313 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2314 quotes the next character, and doesn't affect other longer
2315 sequences (bug#8935).
2316
1d698799
LMI
2317 * lread.c (syms_of_lread): Clarify that is isn't only
2318 `eval-buffer' and `eval-defun' that's affected by
2319 `lexical-binding' (bug#8460).
2320
aa4b6df6
EZ
23212011-07-15 Eli Zaretskii <eliz@gnu.org>
2322
2323 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2324 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2325
5d856da6
PE
23262011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2327
ad6042bb
PE
2328 Fix minor problems found by static checking.
2329 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2330 (elsz): Now a signed constant, not a size_t var. We prefer signed
2331 types to unsigned, to avoid integer comparison confusion. Without
2332 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2333 "cannot optimize loop, the loop counter may overflow", a symptom
2334 of the confusion.
f00bbb22 2335 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2336 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2337
6468f31c
LMI
23382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2339
49080b10
LMI
2340 * search.c (Fre_search_backward): Mention `case-fold-search' in
2341 all the re_search_* functions (bug#8138).
2342
6468f31c
LMI
2343 * keyboard.c (Fopen_dribble_file): Document when the file is
2344 closed (bug#8056).
2345
c965adc5
EZ
23462011-07-14 Eli Zaretskii <eliz@gnu.org>
2347
df9733bf
EZ
2348 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2349 bidi_cache_idx.
2350
0bb23927
EZ
2351 Support bidi reordering of display and overlay strings.
2352 * xdisp.c (compute_display_string_pos)
2353 (compute_display_string_end): Accept additional argument STRING.
2354 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2355 (reseat_to_string): Initialize bidi_it->string.s and
2356 bidi_it->string.schars.
2357 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2358 NULL (avoids a crash in bidi_paragraph_init).
2359 Initialize itb.string.lstring.
0bb23927
EZ
2360 (init_iterator): Call bidi_init_it only of a valid
2361 buffer position was specified. Initialize paragraph_embedding to
2362 L2R.
2363 (reseat_to_string): Initialize the bidi iterator.
2364 (display_string): If we need to ignore text properties of
2365 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2366 original value of -1 will not work with bidi.)
2367 (compute_display_string_pos): First arg is now struct
2368 `text_pos *'; all callers changed. Support display properties on
2369 Lisp strings.
2370 (compute_display_string_end): Support display properties on Lisp
2371 strings.
2372 (init_iterator, reseat_1, reseat_to_string): Initialize the
2373 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2374 when iterating on a string not from display properties).
640c8776
SM
2375 (compute_display_string_pos, compute_display_string_end):
2376 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2377 arrow keys.
2378 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2379 base_level_stop; instead, set base_level_stop to BEGV.
2380 Fixes crashes in vertical-motion.
0bb23927
EZ
2381 (next_element_from_buffer): Improve commentary for when
2382 the iterator is before prev_stop.
2383 (init_iterator): Initialize bidi_p from the default value of
2384 bidi-display-reordering, not from buffer-local value. Use the
2385 buffer-local value only if initializing for buffer iteration.
2386 (handle_invisible_prop): Support invisible properties on strings
2387 that are being bidi-reordered.
2388 (set_iterator_to_next): Support bidi reordering of C strings and
2389 Lisp strings.
2390 (next_element_from_string): Support bidi reordering of Lisp
2391 strings.
2392 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2393 (display_string): Support display of R2L glyph rows.
2394 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2395 (init_iterator): Don't initialize it->bidi_p for strings
2396 here.
2397 (reseat_to_string): Initialize it->bidi_p for strings here.
2398 (next_element_from_string, next_element_from_c_string)
2399 (next_element_from_buffer): Add xassert's for correspondence
2400 between IT's object being iterated and it->bidi_it.string
2401 structure.
2402 (face_before_or_after_it_pos): Support bidi iteration.
2403 (next_element_from_c_string): Handle the case of the first string
2404 character that is not the first one in the visual order.
2405 (get_visually_first_element): New function, refactored from common
2406 parts of next_element_from_buffer, next_element_from_string, and
2407 next_element_from_c_string.
2408 (tool_bar_lines_needed, redisplay_tool_bar)
2409 (display_menu_bar): Force left-to-right direction. Add a FIXME
2410 comment for making that be controlled by a user option.
2411 (push_it, pop_it): Save and restore the state of the
2412 bidi iterator. Save and restore the bidi_p flag.
2413 (pop_it): Iterate out of display property for string iteration as
2414 well.
2415 (iterate_out_of_display_property): Support iteration over strings.
2416 (handle_single_display_spec): Set up it->bidi_it for iteration
2417 over a display string, and call bidi_init_it.
2418 (handle_single_display_spec, next_overlay_string)
2419 (get_overlay_strings_1, push_display_prop): Set up the bidi
2420 iterator for displaying display or overlay strings.
2421 (forward_to_next_line_start): Don't use the shortcut if
2422 bidi-iterating.
2423 (back_to_previous_visible_line_start): If handle_display_prop
2424 pushed the iterator stack, restore the internal state of the bidi
2425 iterator by calling bidi_pop_it same number of times.
2426 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2427 and we are bidi-iterating, don't decrement the iterator position;
2428 instead, set the first_elt flag in the bidi iterator, to produce
2429 the same effect.
2430 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2431 (push_display_prop): xassert that we are iterating a buffer.
2432 (push_it, pop_it): Save and restore paragraph_embedding member.
2433 (handle_single_display_spec, next_overlay_string)
2434 (get_overlay_strings_1, reseat_1, reseat_to_string)
2435 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2436 correctly. Don't assume unibyte strings are not bidi-reordered.
2437 (compute_display_string_pos)
2438 (compute_display_string_end): Fix handling the case of C string.
2439 (push_it, pop_it): Save and restore from_disp_prop_p.
2440 (handle_single_display_spec, push_display_prop): Set the
2441 from_disp_prop_p flag.
2442 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2443 (pop_it): Call iterate_out_of_display_property only if we are
2444 popping after iteration over a string that came from a display
2445 property. Fix a typo in popping stretch info. Add an assertion
2446 for verifying that the iterator position is in sync with the bidi
2447 iterator.
2448 (handle_single_display_spec, get_overlay_strings_1)
2449 (push_display_prop): Fix initialization of paragraph direction for
2450 string when that of the parent object is not yet determined.
2451 (reseat_1): Call bidi_init_it to resync the bidi
2452 iterator with IT's position. (Bug#7616)
2453 (find_row_edges): If ROW->start.pos gives position
2454 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2455 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2456 Reset the from_disp_prop_p flag.
2457 (SAVE_IT, RESTORE_IT): New macros.
2458 (pos_visible_p, face_before_or_after_it_pos)
2459 (back_to_previous_visible_line_start)
2460 (move_it_in_display_line_to, move_it_in_display_line)
2461 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2462 (try_scrolling, redisplay_window, display_line): Use them when
2463 saving a temporary copy of the iterator and restoring it back.
2464 (back_to_previous_visible_line_start, reseat_1)
2465 (init_iterator): Empty the bidi cache "stack".
2466 (move_it_in_display_line_to): If iterator ended up at
2467 EOL, but we never saw any buffer positions smaller than
2468 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2469 motion in bidi-reordered lines.
2470 (move_it_in_display_line_to): Record prev_method and prev_pos
2471 immediately before the call to set_iterator_to_next. Fixes cursor
2472 motion in bidi-reordered lines with stretch glyphs and strings
2473 displayed in margins. (Bug#8133) (Bug#8867)
2474 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2475 TO_CHARPOS.
640c8776
SM
2476 (pos_visible_p): Support positions in bidi-reordered lines.
2477 Save and restore bidi cache.
0bb23927
EZ
2478
2479 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2480 (bidi_paragraph_info): Delete unused struct.
2481 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2482 (bidi_cache_start): New variable.
2483 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2484 to zero.
2485 (bidi_cache_fetch_state, bidi_cache_search)
2486 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2487 (bidi_cache_find, bidi_peek_at_next_level)
2488 (bidi_level_of_next_char, bidi_find_other_level_edge)
2489 (bidi_move_to_visually_next): Compare cache index with
2490 bidi_cache_start rather than with zero.
2491 (bidi_fetch_char): Accept new argument STRING; all callers
2492 changed. Support iteration over a string. Support strings with
2493 display properties. Support unibyte strings. Fix the type of
2494 `len' according to what STRING_CHAR_AND_LENGTH expects.
2495 (bidi_paragraph_init, bidi_resolve_explicit_1)
2496 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2497 (bidi_level_of_next_char, bidi_move_to_visually_next):
2498 Support iteration over a string.
0bb23927
EZ
2499 (bidi_set_sor_type, bidi_resolve_explicit_1)
2500 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2501 can now be zero (for strings); special values 0 and -1 were
2502 changed to -1 and -2, respectively.
2503 (bidi_char_at_pos): New function.
2504 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2505 Call it instead of FETCH_MULTIBYTE_CHAR.
2506 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2507 initialized to valid values.
2508 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2509 values.
2510 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2511 the test for valid cached positions. Fix the logic for looking up
2512 the sentinel state in the cache. GCPRO the Lisp string we are
2513 iterating.
2514 (bidi_push_it, bidi_pop_it): New functions.
2515 (bidi_initialize): Initialize the bidi cache start stack pointer.
2516 (bidi_cache_ensure_space): New function, refactored from part of
2517 bidi_cache_iterator_state. Don't assume the required size is just
2518 one BIDI_CACHE_CHUNK away.
2519 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2520 (bidi_count_bytes, bidi_char_at_pos): New functions.
2521 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2522 always valid if bidi_cache_idx is valid.
2523 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2524 is valid if it's going to be used.
2525 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2526 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2527 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2528 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2529 (bidi_find_other_level_edge, bidi_cache_start_stack):
2530 All variables related to cache indices are now EMACS_INT.
c965adc5 2531
0bb23927
EZ
2532 * dispextern.h (struct bidi_string_data): New structure.
2533 (struct bidi_it): New member `string'. Make flag members be 1-bit
2534 fields, and put them last in the struct.
640c8776
SM
2535 (compute_display_string_pos, compute_display_string_end):
2536 Update prototypes.
0bb23927
EZ
2537 (bidi_push_it, bidi_pop_it): Add prototypes.
2538 (struct iterator_stack_entry): New members bidi_p,
2539 paragraph_embedding, and from_disp_prop_p.
2540 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2541 (bidi_shelve_cache, bidi_unshelve_cache):
2542 Declare prototypes.
0bb23927
EZ
2543
2544 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2545 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2546 and vector-like objects.
2547
2548 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2549 cache around display iteration.
2550
2551 * window.c (Fwindow_end, window_scroll_pixel_based)
2552 (displayed_window_lines, Frecenter): Save and restore the bidi
2553 cache around display iteration.
2554
3bbd2265
LMI
25552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2556
2557 * editfns.c (Fdelete_region): Clarify the use of the named
2558 parameters (bug#6788).
2559
adc47434
MR
25602011-07-14 Martin Rudalics <rudalics@gmx.at>
2561
2562 * indent.c (Fvertical_motion): Set and restore w->pointm when
2563 saving and restoring the window's buffer (Bug#9006).
2564
837c31f8
LMI
25652011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2566
2567 * editfns.c (Fstring_to_char): Clarify just what is returned
2568 (bug#6576). Text by Eli Zaretskii.
2569
ac389d0c
JB
25702011-07-13 Juanma Barranquero <lekktu@gmail.com>
2571
2572 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2573
0be0ce47
EZ
25742011-07-13 Eli Zaretskii <eliz@gnu.org>
2575
2576 * buffer.c (mmap_find): Fix a typo.
2577
cd18e7e3
JB
25782011-07-13 Johan Bockgård <bojohan@gnu.org>
2579
2580 Fix execution of x selection hooks.
2581 * xselect.c (Qx_lost_selection_functions)
2582 (Qx_sent_selection_functions): New vars.
2583 (syms_of_xselect): DEFSYM them.
2584 (x_handle_selection_request): Pass Qx_sent_selection_functions
2585 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2586 (x_handle_selection_clear,x_clear_frame_selections):
2587 Pass Qx_lost_selection_functions rather than
2588 Vx_lost_selection_functions to Frun_hook_with_args.
2589
47ea7f44
PE
25902011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2591
ac389d0c 2592 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2593 The old code sometimes used this field without initializing it.
2594
47ea7f44
PE
2595 * alloc.c (gc_sweep): Don't read past end of array.
2596 In theory, the old code could also have corrupted Emacs internals,
2597 though it'd be very unlikely.
2598
bc985c87
AS
25992011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2600
2601 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2602 argument. (Bug#4026)
bc985c87 2603
0cf34688
LMI
26042011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2605
b3dadd76
LMI
2606 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2607 key" (bug#4257).
2608
0cf34688
LMI
2609 * window.c (Fset_window_start): Doc fix (bug#4199).
2610 (Fset_window_hscroll): Ditto.
2611
270768cd
PE
26122011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2613
077e3dda 2614 Fix minor new problems caught by GCC 4.6.1.
270768cd 2615 * term.c (init_tty): Remove unused local.
490011a6 2616 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2617 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2618 not used otherwise.
270768cd 2619
b1f58454
CY
26202011-07-12 Chong Yidong <cyd@stupidchicken.com>
2621
2622 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2623
22b9578d
LMI
26242011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2625
6e70ab07
LMI
2626 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2627 are the mini-buffer and the echo area (bug#3320).
2628
22b9578d
LMI
2629 * term.c (init_tty): Remove support for supdup, c10 and perq
2630 terminals, which are no longer supported (bug#1482).
2631
8974cc9f
JB
26322011-07-10 Johan Bockgård <bojohan@gnu.org>
2633
2634 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2635
a560d974
JD
26362011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2637
2638 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2639 for non-popups (Bug#3642).
2640
1dae0f0a
AS
26412011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2642
268c2c36 2643 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2644 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2645 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2646 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2647 * data.c (fmod): Likewise.
2648 * dispnew.c (swap_glyphs_in_rows): Likewise.
2649 * emacs.c (memory_warning_signal): Likewise.
2650 * floatfns.c (float_error): Likewise.
2651 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2652 (otf_open, font_otf_capability, generate_otf_features)
2653 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2654 Likewise.
2655 * image.c (pbm_read_file): Likewise.
2656 * indent.c (string_display_width): Likewise.
2657 * intervals.c (check_for_interval, search_for_interval)
2658 (inc_interval_count, count_intervals, root_interval)
2659 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2660 * lread.c (defalias): Likewise.
268c2c36 2661 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2662 * regex.c (set_image_of_range_1, set_image_of_range)
2663 (regex_grow_registers): Likewise.
2664 * sysdep.c (strerror): Likewise.
2665 * termcap.c (valid_filename_p, tprint, main): Likewise.
2666 * tparam.c (main): Likewise.
2667 * unexhp9k800.c (run_time_remap, save_data_space)
2668 (update_file_ptrs, read_header, write_header, calculate_checksum)
2669 (copy_file, copy_rest, display_header): Likewise.
2670 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2671 Likewise.
2672 * xdisp.c (check_it): Likewise.
2673 * xfaces.c (register_color, unregister_color, unregister_colors):
2674 Likewise.
2675 * xfns.c (print_fontset_result): Likewise.
2676 * xrdb.c (member, fatal, main): Likewise.
2677
99033785
PE
26782011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 Fix minor problems found by static checking (Bug#9031).
2681 * chartab.c (char_table_set_range, map_sub_char_table):
2682 Remove unused locals.
2683 (uniprop_table): Now static.
2684 * composite.c (_work_char): Remove unused static var.
2685
9cb2ac56
JB
26862011-07-09 Juanma Barranquero <lekktu@gmail.com>
2687
2688 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2689
f25661f0
JD
26902011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2691
2692 * gtkutil.c (qttip_cb): Remove code without function.
2693
8278c4fe
EZ
26942011-07-09 Eli Zaretskii <eliz@gnu.org>
2695
2696 * w32.c (pthread_sigmask): New stub.
2697
1692ae2d 26982011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2699
8a6ebd58 2700 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2701 sigprocmask is portable only for single-threaded applications, and
2702 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2703 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2704 (LIBES): Use it.
2705 * callproc.c (Fcall_process):
2706 * process.c (create_process):
2707 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2708 Use pthread_sigmask, not sigprocmask.
123403e4 2709
1b854618
JD
27102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2711
2712 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2713 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2714 wrong (Bug#8591).
2715
3fe4b549
JD
27162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2717
0ce7e563
JD
2718 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2719 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2720 (xg_hide_tooltip): Fix comment.
2721
3fe4b549
JD
2722 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2723 in registerServicesMenuSendTypes.
2724 (validRequestorForSendType): Don't check ns_return_types.
2725
2726 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2727 ns_return_type.
2728
5df75e47
JR
27292011-07-08 Jason Rumney <jasonr@gnu.org>
2730
2731 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2732 frame struct members of non-existent frames (Bug#6284).
2733
699c10bd
JD
27342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2735
4393663b
JD
2736 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2737 variable firstTime not needed on OSX >= 10.6.
2738 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2739 >= 10.5. Use setKnobProportion, setDoubleValue.
2740
2741 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2742 (MAC_OS_X_VERSION_10_5): Define if not defined.
2743 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2744 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2745 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2746
2747 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2748 cString and lossyCString on OSX >= 10.4
2749
2750 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2751 sizeToFit on OSX >= 10.2.
2752
2753 * nsimage.m (allocInitFromFile): Don't use deprecated method
2754 bestRepresentationForDevice on OSX >= 10.6.
2755
2756 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2757 to avoid warning.
2758
2759 * emacs.c: Declare unexec_init_emacs_zone.
2760
a63e0781
JD
2761 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2762
699c10bd
JD
2763 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2764
2765 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2766 on svcsMenu (Bug#8842).
2767
2768 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2769 ns_return_types.
2770 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2771
2772 * nsterm.m (QUTF8_STRING): Declare.
2773 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2774 (validRequestorForSendType): Return type is (id).
2775 Change indexOfObjectIdenticalTo to indexOfObject.
2776 Check if we have local selection before returning self (Bug#8842).
2777 (writeSelectionToPasteboard): Put local selection into paste board
2778 if we have a local selection (Bug#8842).
2779 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2780
2781 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2782 (ns_get_local_selection): Declare.
2783
54e10184
LMI
27842011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2785
9888ff71
LMI
2786 * keymap.c (describe_map_tree): Don't insert a double newline at
2787 the end of the buffer (bug#1169) and return whether we inserted
2788 something.
2789
54e10184
LMI
2790 * callint.c (Fcall_interactively): Change "reading args" to
2791 "providing args" to try to clarify what it does (bug#1010).
2792
15fa4783
KH
27932011-07-07 Kenichi Handa <handa@m17n.org>
2794
2795 * composite.c (composition_compute_stop_pos): Ignore a static
2796 composition starting before CHARPOS (Bug#8915).
2797
2798 * xdisp.c (handle_composition_prop): Likewise.
2799
a8815b00
EZ
28002011-07-07 Eli Zaretskii <eliz@gnu.org>
2801
2802 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2803 (Bug#9015)
2804
ef7b981d 28052011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2806
2807 * character.h (unicode_category_t): New enum type.
2808
2809 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2810 (Qchar_code_property_table): New variable.
2811 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2812 (UNIPROP_COMPRESSED_FORM_P): New macros.
2813 (char_table_ascii): Uncompress the compressed values.
2814 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2815 Uncompress the compressed values.
ac389d0c 2816 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2817 (char_table_ref_and_range): Uncompress the compressed values.
2818 (sub_char_table_set): New arg is_uniprop. Callers changed.
2819 Uncompress the compressed values.
2820 (sub_char_table_set_range): Args changed. Callers changed.
2821 (char_table_set_range): Adjuted for the above change.
2822 (map_sub_char_table): Delete args default_val and parent. Add arg
2823 top. Give decoded values to a Lisp function.
640c8776 2824 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2825 values to a Lisp function. Gcpro more variables.
2826 (uniprop_table_uncompress)
2827 (uniprop_decode_value_run_length): New functions.
2828 (uniprop_decoder, uniprop_decoder_count): New variables.
2829 (uniprop_get_decoder, uniprop_encode_value_character)
2830 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2831 New functions.
2832 (uniprop_encoder, uniprop_encoder_count): New variables.
2833 (uniprop_get_encoder, uniprop_table)
2834 (Funicode_property_table_internal, Fget_unicode_property_internal)
2835 (Fput_unicode_property_internal): New functions.
2836 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2837 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2838 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2839 char-code-property-alist.
2840
640c8776 2841 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2842 Vunicode_category_table.
2843
640c8776 2844 * font.c (font_range): Adjust for the change of
c805dec0
KH
2845 Vunicode_category_table.
2846
76b397fb
DN
28472011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2848
2849 * m/iris4d.h: Remove file, move contents ...
2850 * s/irix6-5.h: ... here.
2851
22b4128e
PE
28522011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2853
2854 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2855 * alloc.c (mark_buffer):
2856 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2857 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2858 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2859 This isn't true in general, and it's particularly not true
2860 if Emacs is configured with --with-wide-int.
2861 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2862 New macros, used in the buffer.c change.
2863
869795d6
JD
28642011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2865
2866 * xsettings.c: Use both GConf and GSettings if both are available.
2867 (store_config_changed_event): Add comment.
2868 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2869 (store_tool_bar_style_changed): New functions.
5e617bc2 2870 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2871 (struct xsettings): Move font inside HAVE_XFT.
2872 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2873 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2874 Move inside HAVE_XFT.
640c8776 2875 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2876 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2877 also.
2878 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2879 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2880 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2881 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2882 (parse_settings): Move check for font inside HAVE_XFT.
2883 (read_settings, apply_xft_settings): Add comment.
2884 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2885 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2886 call store_font_name_changed.
2887 (xft_settings_event): Add comment.
2888 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2889 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2890 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2891 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2892 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2893 (xsettings_get_system_font, xsettings_get_system_normal_font):
2894 Add comment.
869795d6 2895
d8ed26bd
PE
28962011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2897
2898 Random fixes. E.g., (random) never returned negative values.
2899 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2900 subseconds part to the entropy, as that's a bit more random.
2901 Prefer signed to unsigned, since the signedness doesn't matter and
2902 in general we prefer signed. When given a limit, use a
2903 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2904 latter isn't right if USE_2_TAGS_FOR_INTS.
2905 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2906 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2907
cabf1cac
SM
29082011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2909
2910 * textprop.c (text_property_stickiness):
2911 Obey Vtext_property_default_nonsticky.
2912 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2913 * w32fns.c (syms_of_w32fns):
2914 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2915
6e9b2be9
PE
29162011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2919 This is more efficient than Ffile_directory_p and avoids a minor race.
2920
90186c68
LMI
29212011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2922
7c301272
LMI
2923 * buffer.c (Foverlay_put): Say what the return value is
2924 (bug#7835).
2925
c4f2d8d4
LMI
2926 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2927 is a directory before asking whether to use the file name
2928 (bug#7564).
ad637907
LMI
2929 (barf_or_query_if_file_exists): Make the "File is a directory"
2930 error be more correct.
c4f2d8d4 2931
90186c68
LMI
2932 * fns.c (Frequire): Remove the mention of the .gz files, since
2933 that's installation-specific, but keep the mention of
2934 `get-load-suffixes'.
2935
da64016e
PE
29362011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2939 Report string overflow if the output is too long.
2940
7d47b580
JB
29412011-07-04 Juanma Barranquero <lekktu@gmail.com>
2942
a555cb87
JB
2943 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2944 (syms_of_gnutls): Remove duplicate DEFSYM for
2945 Qgnutls_bootprop_verify_hostname_error, an error for
2946 Qgnutls_bootprop_verify_error (which is no longer used).
2947
7d47b580
JB
2948 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2949 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2950 Also (re)move comments that are misplaced or no longer relevant.
2951
1e49bfab
LMI
29522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2953
2954 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2955
1485f4c0
CY
29562011-07-03 Chong Yidong <cyd@stupidchicken.com>
2957
2958 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2959 and background color parameters if they have been changed.
2960
a9ab721e
LMI
29612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2962
2963 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2964
cf7cff57
PE
29652011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2966
2e13213d
PE
2967 * xsettings.c (SYSTEM_FONT): Define only when used.
2968 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2969
cf7cff57
PE
2970 * keymap.c (access_keymap_1): Now static.
2971
7a8e04f7
CY
29722011-07-02 Chong Yidong <cyd@stupidchicken.com>
2973
2974 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2975 leave any prefix arg for the up event (Bug#1586).
2976
61352f62
LMI
29772011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2978
69bb1ef7
LMI
2979 * lread.c (syms_of_lread): Mention single symbols defined by
2980 `defvar' or `defconst' (bug#7154).
2981
61352f62 2982 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2983 (Frequire): Mention get-load-suffixes.
61352f62 2984
28545e04
MR
29852011-07-02 Martin Rudalics <rudalics@gmx.at>
2986
2987 * window.h (window): Remove clone_number slot.
2988 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2989 Remove.
2990 (make_parent_window, make_window, saved_window)
2991 (Fset_window_configuration, save_window_save): Don't deal with
2992 clone numbers.
2993 * buffer.c (Qclone_number): Remove declaration.
2994 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2995
3349e122
SM
29962011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2997
2998 Add multiple inheritance to keymaps.
2999 * keymap.c (Fmake_composed_keymap): New function.
3000 (Fset_keymap_parent): Simplify.
3001 (fix_submap_inheritance): Remove.
3002 (access_keymap_1): New function extracted from access_keymap to handle
3003 embedded parents and handle lists of maps.
3004 (access_keymap): Use it.
3005 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3006 (Fcopy_keymap): Handle embedded parents.
3007 (Fcommand_remapping, define_as_prefix): Simplify.
3008 (Fkey_binding): Simplify.
3009 (syms_of_keymap): Move minibuffer-local-completion-map,
3010 minibuffer-local-filename-completion-map,
3011 minibuffer-local-must-match-map, and
3012 minibuffer-local-filename-must-match-map to Elisp.
3013 (syms_of_keymap): Defsubr make-composed-keymap.
3014 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3015 (parse_menu_item): Trivial simplification.
3016
3279eb87
GM
30172011-07-01 Glenn Morris <rgm@gnu.org>
3018
3019 * Makefile.in (SETTINGS_LIBS): Fix typo.
3020
4550efdf
KI
30212011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3022
3023 * coding.c (Fencode_coding_string): Record the last coding system
3024 used, as the function doc string says (bug#8738).
3025
0949d2b6
JD
30262011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3027
3028 * xsettings.c (store_monospaced_changed): Take new font as arg and
3029 check for change against current_mono_font.
3030 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3031 (emacs_settings_constructor, emacs_settings_get_property)
3032 (emacs_settings_set_property, emacs_settings_class_init)
3033 (emacs_settings_init, gsettings_obj): Remove.
3034 (something_changedCB): New function for HAVE_GSETTINGS.
3035 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3036 with value as argument.
3037 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3038 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3039 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3040 "changed".
3041
3042 * xgselect.c: Add defined (HAVE_GSETTINGS).
3043 (xgselect_initialize): Ditto.
3044
3045 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3046 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3047 xg_select.
3048
bbc6b304
PE
30492011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 * eval.c (struct backtrace): Simplify and port the data structure.
3052 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3053 signed bit field, as this assumption is not portable and it makes
3054 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3055 "char debug_on_exit : 1" as this is not portable either; instead,
3056 use the portable "unsigned int debug_on_exit : 1". Remove unused
3057 member evalargs. Remove obsolete comments about cc bombing out.
3058
9851bfc5
JD
30592011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3060
51bb811f 3061 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3062 Let HAVE_GSETTINGS override HAVE_GCONF.
3063 (store_monospaced_changed): New function.
3064 (EMACS_SETTINGS): A new type derived from GObject to handle
3065 GSettings notifications.
3066 (emacs_settings_constructor, emacs_settings_get_property)
3067 (emacs_settings_set_property, emacs_settings_class_init):
3068 New functions.
3069 (gsettings_client, gsettings_obj): New variables.
3070 (GSETTINGS_SCHEMA): New define.
3071 (something_changedCB): Call store_monospaced_changed.
3072 (init_gsettings): New function.
3073 (xsettings_initialize): Call init_gsettings.
3074 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3075 to NULL.
3076
640c8776 3077 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3078 GCONF_CFLAGS/LIBS.
3079
5386012d
MR
30802011-06-29 Martin Rudalics <rudalics@gmx.at>
3081
3082 * window.c (resize_root_window, grow_mini_window)
3083 (shrink_mini_window): Rename Qresize_root_window to
3084 Qwindow_resize_root_window and Qresize_root_window_vertically to
3085 Qwindow_resize_root_window_vertically.
3086
f13e0b08
PE
30872011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3088
3089 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3090
94515237
JB
30912011-06-27 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * makefile.w32-in: Redesign dependencies so they reflect more
3094 clearly which files are directly included by each source file,
3095 and not through other includes.
3096
e43b6e43
MR
30972011-06-27 Martin Rudalics <rudalics@gmx.at>
3098
3099 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3100 (sort_overlays, overlay_strings): When an overlay's clone number
3101 matches the window's clone number process the overlay even if
3102 the overlay's window property doesn't match the current window.
3103
d68443dc
MR
3104 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3105 (Fwindow_hchild): Rename to Fwindow_left_child.
3106 (Fwindow_next): Rename to Fwindow_next_sibling.
3107 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3108 (resize_window_check): Rename to window_resize_check.
3109 (resize_window_apply): Rename to window_resize_apply.
3110 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3111 (Fdelete_other_windows_internal, resize_frame_windows)
3112 (Fsplit_window_internal, Fdelete_window_internal)
3113 (grow_mini_window, shrink_mini_window)
3114 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3115
c7e73be5
JD
31162011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3117
3118 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3119 (emacs_fixed_set_min_size): Remove.
3120 (emacs_fixed_new): Take frame as argument.
3121
3122 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3123 (_EmacsFixedPrivate): Remove minwidth/height.
3124 Add struct frame *f.
3125 (emacs_fixed_init): Initialize priv->f.
3126 (get_parent_class, emacs_fixed_set_min_size): Remove.
3127 (emacs_fixed_new): Set priv->f to argument.
3128 (emacs_fixed_get_preferred_width)
3129 (emacs_fixed_get_preferred_height): Use min_width/height from
3130 frames size_hint to set minimum and natural (Bug#8919).
3131 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3132 and use min_width/height from frames size_hint to set
3133 min_width/height (Bug#8919).
3134
3135 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3136 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3137 Fix indentation.
c7e73be5 3138
cf99dcf8
EZ
31392011-06-26 Eli Zaretskii <eliz@gnu.org>
3140
3141 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3142 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3143 called at ZV.
3144
029529ac
CY
31452011-06-26 Chong Yidong <cyd@stupidchicken.com>
3146
3147 * process.c (wait_reading_process_output): Bypass select if
3148 waiting for a cell while ignoring keyboard input, and input is
3149 pending. Suggested by Jan Djärv (Bug#8869).
3150
7a7ef429
PE
31512011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 Use gnulib's dup2 module instead of rolling our own.
3154 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3155
11fdef7d 31562011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3157
3158 * dispnew.c (scrolling_window): Before scrolling, turn off a
3159 mouse-highlight in the window being scrolled.
3160
cd3520a4
JB
31612011-06-24 Juanma Barranquero <lekktu@gmail.com>
3162
3163 Move DEFSYM to lisp.h and use everywhere.
3164
3165 * character.h (DEFSYM): Move declaration...
3166 * lisp.h (DEFSYM): ...here.
3167
3168 * gnutls.c:
3169 * minibuf.c:
3170 * w32menu.c:
3171 * w32proc.c:
3172 * w32select.c: Don't include character.h.
3173
3174 * alloc.c (syms_of_alloc):
3175 * buffer.c (syms_of_buffer):
3176 * bytecode.c (syms_of_bytecode):
3177 * callint.c (syms_of_callint):
3178 * casefiddle.c (syms_of_casefiddle):
3179 * casetab.c (init_casetab_once):
3180 * category.c (init_category_once, syms_of_category):
3181 * ccl.c (syms_of_ccl):
3182 * cmds.c (syms_of_cmds):
3183 * composite.c (syms_of_composite):
3184 * dbusbind.c (syms_of_dbusbind):
3185 * dired.c (syms_of_dired):
3186 * dispnew.c (syms_of_display):
3187 * doc.c (syms_of_doc):
3188 * editfns.c (syms_of_editfns):
3189 * emacs.c (syms_of_emacs):
3190 * eval.c (syms_of_eval):
3191 * fileio.c (syms_of_fileio):
3192 * fns.c (syms_of_fns):
3193 * frame.c (syms_of_frame):
3194 * fringe.c (syms_of_fringe):
3195 * insdel.c (syms_of_insdel):
3196 * keymap.c (syms_of_keymap):
3197 * lread.c (init_obarray, syms_of_lread):
3198 * macros.c (syms_of_macros):
3199 * msdos.c (syms_of_msdos):
3200 * print.c (syms_of_print):
3201 * process.c (syms_of_process):
3202 * search.c (syms_of_search):
3203 * sound.c (syms_of_sound):
3204 * syntax.c (init_syntax_once, syms_of_syntax):
3205 * terminal.c (syms_of_terminal):
3206 * textprop.c (syms_of_textprop):
3207 * undo.c (syms_of_undo):
3208 * w32.c (globals_of_w32):
3209 * window.c (syms_of_window):
3210 * xdisp.c (syms_of_xdisp):
3211 * xfaces.c (syms_of_xfaces):
3212 * xfns.c (syms_of_xfns):
3213 * xmenu.c (syms_of_xmenu):
3214 * xsettings.c (syms_of_xsettings):
3215 * xterm.c (syms_of_xterm): Use DEFSYM.
3216
4228cf16
TZ
32172011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3218
cd3520a4 3219 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3220
7fcccf1e
PE
32212011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3222
7efb4e0e
PE
3223 Integer and buffer overflow fixes (Bug#8873).
3224
ff5844ad
PE
3225 * print.c (printchar, strout): Check for string overflow.
3226 (PRINTPREPARE, printchar, strout):
3227 Don't set size unless allocation succeeds.
3228
90532f02
PE
3229 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3230 for sizes. Check for string overflow more accurately.
3231 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3232
6d84508d
PE
3233 * macros.c: Integer and buffer overflow fixes.
3234 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3235 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3236 Use ptrdiff_t, not int, for sizes.
3237 Don't increment bufsize until after realloc succeeds.
3238 Check for size-calculation overflow.
3239 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3240
437b2cb4
PE
3241 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3242
8b9ac8b4
PE
3243 * lread.c: Integer overflow fixes.
3244 (read_integer): Radix is now EMACS_INT, not int,
3245 to improve quality of diagnostics for out-of-range radices.
3246 Calculate buffer size correctly for out-of-range radices.
3247 (read1): Check for integer overflow in radices, and in
3248 read-circle numbers.
82cb60d3
PE
3249 (read_escape): Avoid int overflow.
3250 (Fload, openp, read_buffer_size, read1)
3251 (substitute_object_recurse, read_vector, read_list, map_obarray):
3252 Use ptrdiff_t, not int, for sizes.
3253 (read1): Use EMACS_INT, not int, for sizes.
20270765 3254 Check for size overflow.
8b9ac8b4 3255
7fcccf1e
PE
3256 * image.c (cache_image): Check for size arithmetic overflow.
3257
bfbbd7e7
PE
3258 * lread.c: Integer overflow issues.
3259 (saved_doc_string_size, saved_doc_string_length)
3260 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3261 Now ptrdiff_t, not int.
3262 (read1): Don't assume doc string length fits in int. Check for
3263 out-of-range doc string lengths.
3264 (read_list): Don't assume file position fits in int.
39019e54 3265 (read_escape): Check for hex character overflow.
bfbbd7e7 3266
4e323265
LL
32672011-06-22 Leo Liu <sdl.web@gmail.com>
3268
3269 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3270 Move to minibuffer.el.
3271
85fece3e
PE
32722011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3273
20b84ce9 3274 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3275 The following patches are for when GLYPH_DEBUG && !XASSERT.
3276 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3277 * dispnew.c (flush_stdout):
3278 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3279 Mark as externally visible.
3280 * dispnew.c (check_window_matrix_pointers): Now static.
3281 * dispnew.c (window_to_frame_vpos):
3282 * xfns.c (unwind_create_frame):
3283 * xterm.c (x_check_font): Remove unused local.
3284 * scroll.c (CHECK_BOUNDS):
3285 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3286 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3287 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3288 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3289 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3290 Now static.
3291 (debug_method_add): Use va_list and vsprintf rather than relying
3292 on undefined behavior with wrong number of arguments.
3293 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3294 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3295 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3296 since we're not interested in debugging glyphs with old libraries.
3297 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3298 GCC 4.6.0's static checking.
3299
0766b489
PE
33002011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3301
31fd4b32
PE
3302 Integer overflow and signedness fixes (Bug#8873).
3303 A few related buffer overrun fixes, too.
3304
b79e8648
PE
3305 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3306
0766b489
PE
3307 * dispextern.h (struct face.stipple):
3308 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3309 (x_bitmap_mask, x_allocate_bitmap_record)
3310 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3311 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3312 (x_create_bitmap_from_xpm_data):
3313 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3314 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3315 (.bitmaps_last):
3316 * xfaces.c (load_pixmap):
3317 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3318 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3319 (.bitmaps_last, struct x_output.icon_bitmap):
3320 Use ptrdiff_t, not int, for bitmap indexes.
3321 (x_allocate_bitmap_record): Check for size overflow.
3322 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3323
b081724f
PE
3324 Use ptrdiff_t, not int, for overlay counts.
3325 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3326 * editfns.c (overlays_around, get_pos_property):
3327 * textprop.c (get_char_property_and_overlay):
3328 * xdisp.c (next_overlay_change, note_mouse_highlight):
3329 * xfaces.c (face_at_buffer_position):
21514da7
PE
3330 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3331 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3332 (Fnext_overlay_change, Fprevious_overlay_change)
3333 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3334 Use ptrdiff_t, not int, for sizes.
21514da7 3335 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3336
3de73e5e
PE
3337 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3338
2606c57b
PE
3339 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3340 (x_session_initialize): Do not assume string length fits in int.
3341
aaafe47a
PE
3342 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3343 This is unlikely, but can occur if DPI is outlandish.
3344
2674ddc8 3345 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3346 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3347
28154962
PE
3348 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3349 * xrdb.c (magic_file_p, search_magic_path):
3350 Omit last arg SUFFIX; it was always 0. All callers changed.
3351 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3352
7de51af5
PE
3353 * xfont.c (xfont_match): Avoid need for strlen.
3354
25ed6cc3
PE
3355 * xfns.c: Don't assume strlen fits in int.
3356 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3357
4eab31dd
PE
3358 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3359 not unsigned long, as we prefer signed integers. All callers changed.
3360 Detect integer overflow in repeat count.
3361 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3362 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3363
171e2a58
PE
3364 * termcap.c: Don't assume sizes fit in int and never overflow.
3365 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3366 (gobble_line): Check for size-calculation overflow.
3367
ad39faca 3368 * minibuf.c (Fread_buffer):
6e5bb2dc 3369 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3370 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3371 Don't assume string length fits in int.
3372
52c61c22 3373 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3374 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3375
b5b8c9e5
PE
3376 * font.c: Don't assume string length fits in int.
3377 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3378 Use ptrdiff_t, not int.
ccd6111c
PE
3379 (font_intern_prop): Don't assume string length fits in int.
3380 Don't assume integer property fits in fixnum.
3381 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3382
882f0d81 3383 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3384 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3385 Reformulate so as not to need the command string.
3386 Invoke gzip -cd rather than gunzip, as it's more portable.
3387 (lock_info_type, lock_file_1, lock_file):
3388 Don't assume pid_t and time_t fit in unsigned long.
3389 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3390 (current_lock_owner): Prefer signed type for sizes.
3391 Use memcpy, not strncpy, where memcpy is what is really wanted.
3392 Don't assume (via atoi) that time_t and pid_t fit in int.
3393 Check for time_t and/or pid_t out of range, e.g., via a network share.
3394 Don't alloca where an auto var works fine.
3395
93f4cf88
PE
3396 * fileio.c: Fix some integer overflow issues.
3397 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3398 Don't assume string length fits in int.
3399 (directory_file_name): Don't assume string length fits in long.
3400 (make_temp_name): Don't assume pid fits in int, or that its print
3401 length is less than 20.
3402
f3e92b69
PE
3403 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3404
1bfdaf10
PE
3405 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3406
35016e9a
PE
3407 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3408
3d1e65a1
PE
3409 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3410 We prefer signed integers, even for size calculations.
3411
0b963a93
PE
3412 * emacs.c: Don't assume string length fits in 'int'.
3413 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3414 (main): Don't invoke strlen when not needed.
3415
573f4b54
PE
3416 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3417 (XD_DEBUG_MESSAGE): Don't waste a byte.
3418
989f33ba
PE
3419 * callproc.c (getenv_internal_1, getenv_internal)
3420 (Fgetenv_internal):
965d34eb
PE
3421 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3422
e4d29b33
PE
3423 * lread.c (invalid_syntax): Omit length argument.
3424 All uses changed. This doesn't fix a bug, but it simplifies the
3425 code away from its former Hollerith-constant appearance, and it's
3426 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3427 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3428
eb49b136
PE
3429 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3430 This didn't break anything, but it didn't help either.
3431 It's confusing to put a bogus integer in a place where the actual
3432 value does not matter.
9f62aeb1 3433 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3434 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3435
15375a22
PE
3436 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3437 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3438 implementation.
b61cc01c
PE
3439 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3440 We prefer signed types, and the value cannot exceed the EMACS_INT
3441 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3442 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3443 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3444 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3445
53b2623d
PE
3446 * indent.c (sane_tab_width): New function.
3447 (current_column, scan_for_column, Findent_to, position_indentation)
3448 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3449 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3450
51cab52b 3451 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3452
f2ed8a70
PE
3453 * lisp.h (lint_assume): New macro.
3454 * composite.c (composition_gstring_put_cache):
3455 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3456
abe80cc6
PE
3457 * editfns.c, insdel.c:
3458 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3459
b02c740e
PE
3460 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3461
ebc96716
PE
3462 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3463
b4e50fa0 3464 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3465 Use much-faster test for byte-length change.
311d5d7c 3466 Don't assume string byte-length fits in 'int'.
a4cf38e4 3467 Check that character arg fits in 'int'.
85461888 3468 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3469
c0c1ee9f
PE
3470 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3471
a498d7f4
PE
3472 * fns.c (concat): Catch string overflow earlier.
3473 Do not rely on integer wraparound.
3474
51cab52b
PE
3475 * dispextern.h (struct it.overlay_strings_charpos)
3476 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3477 * xdisp.c (forward_to_next_line_start)
3478 (back_to_previous_visible_line_start)
3479 (reseat_at_next_visible_line_start, next_element_from_buffer):
3480 Don't arbitrarily truncate the value of 'selective' to int.
3481
76031fad
PE
3482 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3483
5eb55db9
PE
3484 * composite.c: Don't truncate sizes to 'int'.
3485 (composition_gstring_p, composition_reseat_it)
3486 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3487 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3488 not EMACS_UINT, for indexes.
5eb55db9 3489
0703a717
PE
3490 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3491
d6202519
PE
3492 * buffer.c: Include <verify.h>.
3493 (struct sortvec.priority, struct sortstr.priority):
8961a454 3494 Now EMACS_INT, not int.
c20998a7 3495 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3496 (struct sortstr.size, record_overlay_string)
3497 (struct sortstrlist.size, struct sortlist.used):
3498 Don't truncate size to int.
3499 (record_overlay_string): Check for size-calculation overflow.
d6202519 3500 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3501
d5a19415
JM
35022011-06-22 Jim Meyering <meyering@redhat.com>
3503
029529ac 3504 Don't leak an XBM-image-sized buffer
d5a19415
JM
3505 * image.c (xbm_load): Free the image buffer after using it.
3506
a9041e6c
PE
35072011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3508
3509 Port to Sun C.
3510 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3511 that Sun C diagnosed.
3512 * fns.c (secure_hash): Fix pointer signedness issue.
3513 * intervals.c (static_offset_intervals): New function.
3514 (offset_intervals): Use it.
3515
7f3f739f
LL
35162011-06-21 Leo Liu <sdl.web@gmail.com>
3517
3518 * deps.mk (fns.o):
3519 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3520 sha512.h.
3521
3522 * fns.c (secure_hash): Rename from crypto_hash_function and change
3523 the first arg to accept symbols.
5b66d427 3524 (Fsecure_hash): New primitive.
7f3f739f
LL
3525 (syms_of_fns): New symbols.
3526
76147d94
DD
35272011-06-20 Deniz Dogan <deniz@dogan.se>
3528
3529 * process.c (Fset_process_buffer): Clarify return value in
3530 docstring.
3531
7d7d0045
CY
35322011-06-18 Chong Yidong <cyd@stupidchicken.com>
3533
3534 * dispnew.c (add_window_display_history): Use BVAR.
3535
3536 * xdisp.c (debug_method_add): Use BVAR.
3537 (check_window_end, dump_glyph_matrix, dump_glyph)
3538 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3539
3540 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3541 Likewise.
3542
3543 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3544 check till after the cache is created in init_frame_faces.
3545
ff2bc410
SM
35462011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3547
3548 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3549
28177add
PE
35502011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3551
dd3482fe
PE
3552 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3553 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3554 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3555
393d71f3 3556 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3557 * fileio.c (Finsert_file_contents):
3558 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3559 Remove the old (too-loose) buffer overflow checks.
3560 They weren't needed, since make_gap checks for buffer overflow.
3561 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3562 The old code merely checked for Emacs fixnum overflow, and relied
3563 on undefined (wraparound) behavior. The new code avoids undefined
3564 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3565
2e6813b0 3566 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3567 Tune. Don't use wider integers than needed. Don't use alloca.
3568 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3569
599a9e4f
PE
3570 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3571
99561444
PE
3572 * insdel.c, lisp.h (buffer_overflow): New function.
3573 (insert_from_buffer_1, replace_range, replace_range_2):
3574 * insdel.c (make_gap_larger):
3575 * editfns.c (Finsert_char):
3576 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3577
28177add
PE
3578 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3579
e69dafad
PE
35802011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3581
a7af7fde 3582 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3583
b1c46f02
PE
3584 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3585 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3586
e69dafad
PE
3587 * fileio.c: Don't assume EMACS_INT fits in off_t.
3588 (emacs_lseek): New static function.
3589 (Finsert_file_contents, Fwrite_region): Use it.
3590 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3591
566684ea
PE
3592 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3593
e6966cd6
PE
3594 * fns.c: Don't overflow int when computing a list length.
3595 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3596 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3597 truncation on 64-bit hosts. Check for QUIT every
3598 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3599 faster and is responsive enough.
3600 (Flength): Report an error instead of overflowing an integer.
3601 (Fsafe_length): Return a float if the value is not representable
3602 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3603 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3604 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3605
dd0b0efb
PE
3606 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3607 (header_size, word_size): New constants.
3608 (allocate_vectorlike): Don't check size overflow here.
3609 (allocate_vector): Check it here instead, since this is the only
3610 caller of allocate_vectorlike that could cause overflow.
3611 Check that the new vector's length is representable as a fixnum.
3612
86fe5cfe
PE
3613 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3614 The previous code was bogus. For example, next_almost_prime (32)
3615 returned 39, which is undesirable as it is a multiple of 3; and
3616 next_almost_prime (24) returned 25, which is a multiple of 5 so
3617 why was the code bothering to check for multiples of 7?
3618
80e88859
PE
3619 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3620
4a2f0ad6
PE
3621 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3622
f66c7cf8
PE
3623 Variadic C functions now count arguments with ptrdiff_t.
3624 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3625 Back then I didn't know that the Emacs coding style prefers signed int.
3626 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3627 were being counted with int, which may truncate counts on 64-bit
3628 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3629 * lisp.h (struct Lisp_Subr.function.aMANY)
3630 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3631 Arg counts are now ptrdiff_t, not size_t.
3632 All variadic functions and their callers changed accordingly.
3633 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3634 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3635 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3636 * callint.c (Fcall_interactively): Check arg count for overflow,
3637 to avoid potential buffer overrun. Use signed char, not 'int',
3638 for 'varies' array, so that we needn't bother to check its size
3639 calculation for overflow.
3640 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3641 * eval.c (apply_lambda):
3642 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3643 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3644 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3645
a1759b76
PE
3646 * callint.c (Fcall_interactively): Don't use index var as event count.
3647
d96be9fc
PE
3648 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3649 * mem-limits.h (SIZE): Remove; no longer used.
3650
a690a978 3651 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3652
578c21e6
PE
3653 Remove unnecessary casts.
3654 * xterm.c (x_term_init):
3655 * xfns.c (x_set_border_pixel):
3656 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3657 These aren't needed now that we assume ANSI C.
3658
96f53c6c
PE
3659 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3660 It's more likely to cause problems (due to unsigned overflow)
3661 than to cure them.
3662
83c77d31
PE
3663 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3664
ee2079f1
PE
3665 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3666
6da65536
PE
3667 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3668
7147c4a4
PE
3669 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3670
193e32d9
PE
3671 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3672
e5533da6
PE
3673 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3674
9910e595
PE
3675 GLYPH_CODE_FACE returns EMACS_INT, not int.
3676 * dispextern.h (merge_faces):
3677 * xfaces.c (merge_faces):
01103c44
PE
3678 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3679 Don't assume EMACS_INT fits in int.
9910e595 3680
2638320e
PE
3681 * character.h (CHAR_VALID_P): Remove unused parameter.
3682 * fontset.c, lisp.h, xdisp.c: All uses changed.
3683
045eb8d9
PE
3684 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3685
c1f134b5
PE
3686 * fns.c (concat): Minor tuning based on overflow analysis.
3687 This doesn't fix any bugs. Use int to hold character, instead
3688 of constantly refetching from Emacs object. Use XFASTINT, not
3689 XINT, for value known to be a character. Don't bother comparing
3690 a single byte to 0400, as it's always less.
3691
395fcb93 3692 * floatfns.c (Fexpt):
327eeec8
PE
3693 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3694
abbd3d23
PE
3695 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3696 for characters.
3697
684a03ef
PE
3698 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3699
0fed43f3
PE
3700 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3701 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3702 incorrectly succeed when S was a string, because 4294967386 was
3703 truncated before it was used.
3704
8fd02eb7
PE
3705 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3706 Otherwise, an out-of-range integer could cause undefined behavior
3707 on a 64-bit host.
3708
f8c86b69
PE
3709 * composite.c: Use int, not EMACS_INT, for characters.
3710 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3711 EMACS_INT, for values that are known to be in character range.
3712 This doesn't fix any bugs but is the usual style inside Emacs and
3713 may generate better code on 32-bit machines.
3714
34206dd2
PE
3715 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3716 This is for reasons similar to the recent CHAR_STRING fix.
3717 * charset.c (Fencode_char): Check that character arg is actually
3718 a character. Pass an int to ENCODE_CHAR.
3719 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3720 wider than 'int', as a compile-time check to prevent future regressions
3721 in this area.
3722
c5958d4c 3723 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3724
3725 Make sure a 64-bit char is never passed to CHAR_STRING.
3726 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3727 by silently ignoring the top 32 bits, allowing some values
3728 that were far too large to be valid characters.
3729 * character.h: Include <verify.h>.
3730 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3731 arguments are no wider than unsigned, as a compile-time check
3732 to prevent future regressions in this area.
3733 * data.c (Faset):
01103c44 3734 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3735 (Fsubst_char_in_region):
3736 * fns.c (concat):
3737 * xdisp.c (decode_mode_spec_coding):
3738 Adjust to CHAR_STRING's new requirement.
3739 * editfns.c (Finsert_char, Fsubst_char_in_region):
3740 * fns.c (concat): Check that character args are actually
3741 characters. Without this test, these functions did the wrong
3742 thing with wildly out-of-range values on 64-bit hosts.
3743
d37ca623
PE
3744 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3745 These casts should not be needed on 32-bit hosts, either.
3746 * keyboard.c (read_char):
3747 * lread.c (Fload): Remove casts to unsigned.
3748
ea204efb
PE
3749 * lisp.h (UNSIGNED_CMP): New macro.
3750 This fixes comparison bugs on 64-bit hosts.
3751 (ASCII_CHAR_P): Use it.
3752 * casefiddle.c (casify_object):
01103c44 3753 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3754 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3755 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3756 * dispextern.h (FACE_FROM_ID):
3757 * keyboard.c (read_char): Use UNSIGNED_CMP.
3758
41cb286c
PE
3759 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3760 not to EMACS_INT, to avoid GCC warning.
3761
4a1b9832
PE
3762 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3763
55daad71
PE
3764 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3765 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3766 isn't needed on 32-bit machines.
8f95c75c 3767
01103c44
PE
3768 * buffer.c (Fgenerate_new_buffer_name):
3769 Use EMACS_INT for count, not int.
0ceccced 3770 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3771
3772 * data.c (Qcompiled_function): Now static.
3773
c6f072e7
PE
3774 * window.c (window_body_lines): Now static.
3775
20ce5912
PE
3776 * image.c (gif_load): Rename local to avoid shadowing.
3777
9c4c5f81
PE
3778 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3779 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3780 * alloc.c (make_save_value): Integer argument is now of type
3781 ptrdiff_t, not int.
3782 (mark_object): Use ptrdiff_t, not int.
3783 * lisp.h (pD): New macro.
3784 * print.c (print_object): Use it.
3785
c0c5c8ae
PE
3786 * alloc.c: Use EMACS_INT, not int, to count objects.
3787 (total_conses, total_markers, total_symbols, total_vector_size)
3788 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3789 (total_free_floats, total_floats, total_free_intervals)
3790 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3791 Now EMACS_INT, not int. All uses changed.
3792 (Fgarbage_collect): Compute overall total using a double, so that
3793 integer overflow is less likely to be a problem. Check for overflow
3794 when converting back to an integer.
5a25e253
PE
3795 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3796 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3797 These were 'int' variables that could overflow on 64-bit hosts;
3798 they were never used, so remove them instead of repairing them.
211a0b2a 3799 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3800 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3801 Previously, this ceilinged at INT_MAX, but that doesn't work on
3802 64-bit machines.
e46bb31a 3803 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3804
c78baabf 3805 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3806 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3807 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3808 when a (possibly-narrower) signed value would do just as well.
3809 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3810
c9d624c6
PE
3811 * alloc.c: Catch some string size overflows that we were missing.
3812 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3813 for convenience in STRING_BYTES_MAX.
3814 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3815 The definition here is exact; the one in lisp.h was approximate.
3816 (allocate_string_data): Check for string overflow. This catches
3817 some instances we weren't catching before. Also, it catches
3818 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3819 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3820 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3821
c9d624c6
PE
3822 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3823 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3824 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3825
353032ce
PE
3826 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3827
2bccce07
PE
3828 * alloc.c (Fmake_string): Check for out-of-range init.
3829
0ac30604
SM
38302011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3831
3832 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3833
c195f2de
JD
38342011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3835
3836 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3837 xg_get_default_scrollbar_width.
3838
3839 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3840 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3841 (style_changed_cb): Call update_theme_scrollbar_width and call
3842 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3843 all frames (Bug#8505).
3844 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3845 Call gtk_window_set_resizable if HAVE_GTK3.
3846 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3847 and height if HAVE_GTK3 (Bug#8505).
3848 (scroll_bar_width_for_theme): New variable.
3849 (update_theme_scrollbar_width): New function.
3850 (xg_get_default_scrollbar_width): Move code to
3851 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3852 (xg_initialize): Call update_theme_scrollbar_width.
3853
3854 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3855
3856 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3857
e10ac9f1
MR
38582011-06-12 Martin Rudalics <rudalics@gmx.at>
3859
3860 * frame.c (make_frame): Call other_buffer_safely instead of
3861 other_buffer.
3862
3863 * window.c (temp_output_buffer_show): Call display_buffer with
3864 second argument Vtemp_buffer_show_specifiers and reset latter
3865 immediately after the call.
3866 (Vtemp_buffer_show_specifiers): New variable.
3867 (auto_window_vscroll_p, next_screen_context_lines)
3868 (Vscroll_preserve_screen_position): Remove leading asterisks from
3869 doc-strings.
3870
2d3c217e 38712011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3872
7b7f97e8 3873 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3874 * buffer.c (Qclone_number): Remove for now, as it's unused.
3875 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3876 (record_buffer): Remove unused local.
3877 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3878 (set_frame_buffer_list): Remove; unused.
3879 * frame.h (other_visible_frames): Remove decl.
3880 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3881 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3882 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3883 if HAVE_GPM.
3884 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3885 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3886 Define only if HAVE_GPM.
3887 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3888 (update_hints_inhibit): Remove; never set. All uses removed.
3889 * widgetprv.h (emacsFrameClassRec): Remove decl.
3890 * window.c (delete_deletable_window): Now returns void, since it
3891 wasn't returning anything.
3892 (compare_window_configurations): Remove unused locals.
3893 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3894 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3895 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3896 the same widths as pointers. This follows up on the 2011-05-06 patch.
3897 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3898 * xterm.h: Likewise.
3899 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3900
1384b89e
JB
39012011-06-12 Juanma Barranquero <lekktu@gmail.com>
3902
3903 * makefile.w32-in: Update dependencies.
3904 (LISP_H): Add lib/intprops.h.
3905
1100a63c
CY
39062011-06-11 Chong Yidong <cyd@stupidchicken.com>
3907
3908 * image.c (gif_load): Add animation frame delay to the metadata.
3909 (syms_of_image): Use DEFSYM. New symbol `delay'.
3910
6198ccd0
MR
39112011-06-11 Martin Rudalics <rudalics@gmx.at>
3912
3913 * window.c (delete_deletable_window): Re-add.
3914 (Fset_window_configuration): Rewrite to handle dead buffers and
3915 consequently deletable windows.
3916 (window_tree, Fwindow_tree): Remove. Supply functionality in
3917 window.el.
3918 (compare_window_configurations): Simplify code.
3919
b6e3633c
AS
39202011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3921
1ab0dee5
AS
3922 * image.c (imagemagick_load_image): Fix type mismatch.
3923 (Fimagemagick_types): Likewise.
3924
b6e3633c
AS
3925 * window.h (replace_buffer_in_windows): Declare.
3926
9397e56f
MR
39272011-06-11 Martin Rudalics <rudalics@gmx.at>
3928
3929 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3930 Qclone_number. Remove external declaration of Qdelete_window.
3931 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3932 code.
640c8776
SM
3933 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3934 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3935 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3936 buffer list implementation.
3937 (other_buffer_safely): New function.
3938 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3939 calls to replace_buffer_in_windows and
3940 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3941 if allowed.
3942 (record_buffer): Inhibit quitting and rewrite using quittable
3943 functions. Run Qbuffer_list_update_hook if allowed.
3944 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3945 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3946 Move switch-to-buffer to window.el.
9397e56f
MR
3947 (bury-buffer): Move to window.el.
3948 (Vbuffer_list_update_hook): New variable.
3949
3950 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3951 section.
3952
3953 * window.h (resize_frame_windows): Move up in code.
3954 (Fwindow_frame): Remove EXFUN.
3955 (replace_buffer_in_all_windows): Remove prototype.
3956 (replace_buffer_in_windows_safely): Add prototype.
3957
3958 * window.c: Declare Qdelete_window static again. Move down
3959 declaration of select_count.
3960 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3961 (Fother_window): Move to window.el.
3962 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3963 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3964 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3965 window.el.
3966 (replace_buffer_in_windows): Implement by calling
3967 Qreplace_buffer_in_windows.
3968 (replace_buffer_in_all_windows): Remove with some functionality
3969 moved into replace_buffer_in_windows_safely.
3970 (replace_buffer_in_windows_safely): New function.
3971 (select_window_norecord, select_frame_norecord): Move in front
3972 of run_window_configuration_change_hook. Remove now obsolete
3973 declarations.
640c8776
SM
3974 (Fset_window_buffer): Rewrite doc-string.
3975 Call Qrecord_window_buffer.
9397e56f
MR
3976 (keys_of_window): Move binding for other-window to window.el.
3977
b50691aa
CY
39782011-06-11 Chong Yidong <cyd@stupidchicken.com>
3979
3980 * dispextern.h (struct image): Replace data member, whose int_val
3981 and ptr_val fields were not used by anything, with a single
3982 lisp_val object.
3983
3984 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3985 (gif_clear_image, gif_load, imagemagick_load_image)
3986 (gs_clear_image, gs_load): Callers changed.
3987
3f754b86
PE
39882011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3989
cca69397
PE
3990 * buffer.h: Include <time.h>, for time_t.
3991 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3992
109e28d0
PE
3993 Fix minor problems found by static checking.
3994
60737f02
PE
3995 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3996
4b66faf3
PE
3997 Make identifiers static if they are not used in other modules.
3998 * data.c (Qcompiled_function, Qframe, Qvector):
3999 * image.c (QimageMagick, Qsvg):
4000 * minibuf.c (Qmetadata):
4001 * window.c (resize_window_check, resize_root_window): Now static.
4002 * window.h (resize_window_check, resize_root_window): Remove decls.
4003
109e28d0
PE
4004 * window.c (window_deletion_count, delete_deletable_window):
4005 Remove; unused.
46a4ce9e
PE
4006 (window_body_lines): Now static.
4007 (Fdelete_other_windows_internal): Mark vars as initialized.
4008 Make sure 'resize_failed' is initialized.
4009 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4010 (resize_window_apply): Remove unused local.
4011 * window.h (delete_deletable_window): Remove decl.
4012
109e28d0 4013 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4014 (imagemagick_load_image): Fix pointer signedness problem by changing
4015 last arg from unsigned char * to char *. All uses changed.
4016 Also, fix a local for similar reasons.
4017 Remove unused locals. Remove locals to avoid shadowing.
4018 (fn_rsvg_handle_free): Remove; unused.
4019 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4020 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4021
3f754b86
PE
4022 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4023
2547adb1
CY
40242011-06-10 Chong Yidong <cyd@stupidchicken.com>
4025
4026 * image.c (gif_load): Fix omitted cast error introduced by
4027 2011-06-06 change.
4028
2c8e37d4
MR
40292011-06-10 Martin Rudalics <rudalics@gmx.at>
4030
4031 * window.h (resize_proportionally, orig_total_lines)
4032 (orig_top_line): Remove from window structure.
4033 (set_window_height, set_window_width, change_window_heights)
4034 (Fdelete_window): Remove prototypes.
4035 (resize_frame_windows): Remove duplicate declaration.
4036
440a42e3
EZ
40372011-06-10 Eli Zaretskii <eliz@gnu.org>
4038
4039 * window.h (resize_frame_windows, resize_window_check)
4040 (delete_deletable_window, resize_root_window)
4041 (resize_frame_windows): Declare prototypes.
4042
4043 * window.c (resize_window_apply): Make definition be "static" to
4044 match the prototype.
4045
562dd5e9
MR
40462011-06-10 Martin Rudalics <rudalics@gmx.at>
4047
4048 * window.c: Remove declarations of Qwindow_size_fixed,
4049 window_min_size_1, window_min_size_2, window_min_size,
4050 size_window, window_fixed_size_p, enlarge_window, delete_window.
4051 Remove static from declaration of Qdelete_window, it's
4052 temporarily needed by Fbury_buffer.
4053 (replace_window): Don't assign orig_top_line and
4054 orig_total_lines.
4055 (Fdelete_window, delete_window): Remove. Window deletion is
4056 handled by window.el.
640c8776
SM
4057 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4058 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4059 (Fdelete_other_windows): Remove. Deleting other windows is
4060 handled by window.el.
4061 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4062 handled in window.el.
4063 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4064 Window minimum sizes are handled in window.el.
4065 (shrink_windows, size_window, set_window_height)
4066 (set_window_width, change_window_heights, window_height)
4067 (window_width, CURBEG, CURSIZE, enlarge_window)
4068 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4069 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4070 handled in window.el.
4071 (make_dummy_parent): Rename to make_parent_window and give it a
4072 second argument horflag.
4073 (make_window): Don't set resize_proportionally any more.
4074 (Fsplit_window): Remove. Windows are split in window.el.
4075 (save_restore_action, save_restore_orig_size)
4076 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4077 Resize mini windows in window.el.
4078 (grow_mini_window, shrink_mini_window): Implement by calling
4079 Qresize_root_window_vertically, resize_window_check and
4080 resize_window_apply.
640c8776
SM
4081 (saved_window, Fset_window_configuration, save_window_save):
4082 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4083 resize_proportionally.
4084 (window_min_height, window_min_width): Move to window.el.
4085 (keys_of_window): Move bindings for delete-other-windows,
4086 split-window, delete-window and enlarge-window to window.el.
4087
4088 * buffer.c: Temporarily extern Qdelete_window.
4089 (Fbury_buffer): Temporarily call Qdelete_window instead of
4090 Fdelete_window (Fbury_buffer will move to window.el soon).
4091
4092 * frame.c (set_menu_bar_lines_1): Remove code handling
4093 orig_top_line and orig_total_lines.
4094
4095 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4096 set_window_height but set heights directly.
4097 (change_frame_size_1): Use resize_frame_windows.
4098
4099 * xdisp.c (init_xdisp): Don't use set_window_height but set
4100 heights directly.
4101
640c8776
SM
4102 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4103 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4104 run_window_configuration_change_hook.
4105
4106 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4107 instead of change_window_heights and run
4108 run_window_configuration_change_hook.
4109
1a13852e
MR
41102011-06-09 Martin Rudalics <rudalics@gmx.at>
4111
4112 * window.c (replace_window): Rename second argument REPLACEMENT to
4113 NEW. New third argument SETFLAG. Rewrite.
4114 (delete_window, make_dummy_parent): Call replace_window with
4115 third argument 1.
4116 (window_list_1): Move down in code.
4117 (run_window_configuration_change_hook): Move set_buffer part
4118 before select_frame_norecord part in order to unwind correctly.
4119 Rename count1 to count.
4120 (recombine_windows, delete_deletable_window, resize_root_window)
4121 (Fdelete_other_windows_internal)
4122 (Frun_window_configuration_change_hook, make_parent_window)
4123 (resize_window_check, resize_window_apply, Fresize_window_apply)
4124 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4125 (Fdelete_window_internal, Fresize_mini_window_internal):
4126 New functions.
1a13852e
MR
4127 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4128
f3d1777e
MR
41292011-06-08 Martin Rudalics <rudalics@gmx.at>
4130
496e208e
MR
4131 * window.h (window): Add some new members to window structure -
4132 normal_lines, normal_cols, new_total, new_normal, clone_number,
4133 splits, nest, prev_buffers, next_buffers.
4134 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4135 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4136
f3d1777e
MR
4137 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4138 Remove.
496e208e
MR
4139 (make_dummy_parent): Set new members of windows structure.
4140 (make_window): Move down in code. Handle new members of window
4141 structure.
4142 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4143 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4144 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4145 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4146 (Fset_window_next_buffers, Fset_window_clone_number):
4147 New functions.
496e208e
MR
4148 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4149 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4150 Doc-string fixes.
4151 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4152 Argument WINDOW can be now internal window too.
4153 (Fwindow_use_time): Move up in code.
4154 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4155 Rewrite doc-string.
4156 (Fset_window_configuration, saved_window)
4157 (Fcurrent_window_configuration, save_window_save): Handle new
4158 members of window structure.
b9e809c2
MR
4159 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4160 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4161 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4162 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4163 Qget_mru_window, Qresize_root_window,
4164 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4165 Qauto_buffer_name; staticpro them.
f3d1777e 4166
abde8f8c
MR
41672011-06-07 Martin Rudalics <rudalics@gmx.at>
4168
4169 * window.c (Fwindow_total_size, Fwindow_left_column)
4170 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4171 (Fwindow_list_1): New functions.
4172 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4173 (Fwindow_width, Fscroll_left, Fscroll_right):
4174 Use window_body_cols instead of window_box_text_cols.
4175 (delete_window, Fset_window_configuration):
4176 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4177 (delete_all_subwindows): Take a window as argument and not a
4178 structure. Rewrite.
190b47e6
MR
4179 (window_loop): Remove handling of GET_LRU_WINDOW and
4180 GET_LARGEST_WINDOW.
4181 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4182
4183 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4184 window_box_text_cols. delete_all_subwindows now takes a
4185 Lisp_Object as argument.
abde8f8c 4186
640c8776
SM
4187 * indent.c (compute_motion, Fcompute_motion):
4188 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4189
fa8a67e6
MR
4190 * frame.c (delete_frame): Call delete_all_subwindows with root
4191 window as argument.
4192
a54e3482
DC
41932011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4194
4195 * fns.c (Fputhash): Document return value.
4196
60002bf5
CY
41972011-06-06 Chong Yidong <cyd@stupidchicken.com>
4198
4199 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4200
0c671da6 42012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4202
b862a52a 4203 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4204
be44ca6c
PE
4205 Check for overflow when converting integer to cons and back.
4206 * charset.c (Fdefine_charset_internal, Fdecode_char):
4207 Use cons_to_unsigned to catch overflow.
4208 (Fencode_char): Use INTEGER_TO_CONS.
4209 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4210 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4211 * data.c (long_to_cons, cons_to_long): Remove.
4212 (cons_to_unsigned, cons_to_signed): New functions.
4213 These signal an error for invalid or out-of-range values.
4214 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4215 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4216 * font.c (Ffont_variation_glyphs):
4217 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4218 * lisp.h: Include <intprops.h>.
4219 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4220 (cons_to_signed, cons_to_unsigned): New decls.
4221 (long_to_cons, cons_to_long): Remove decls.
4222 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4223 (Fprimitive_undo): Use CONS_TO_INTEGER.
4224 * xfns.c (Fx_window_property): Likewise.
4225 * xselect.c: Include <limits.h>.
4226 (x_own_selection, selection_data_to_lisp_data):
4227 Use INTEGER_TO_CONS.
4228 (x_handle_selection_request, x_handle_selection_clear)
4229 (x_get_foreign_selection, Fx_disown_selection_internal)
4230 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4231 (lisp_data_to_selection_data): Use cons_to_unsigned.
4232 (x_fill_property_data): Use cons_to_signed.
4233 Report values out of range.
4234
d1f3d2af
PE
4235 Check for buffer and string overflow more precisely.
4236 * buffer.h (BUF_BYTES_MAX): New macro.
4237 * lisp.h (STRING_BYTES_MAX): New macro.
4238 * alloc.c (Fmake_string):
4239 * character.c (string_escape_byte8):
4240 * coding.c (coding_alloc_by_realloc):
4241 * doprnt.c (doprnt):
4242 * editfns.c (Fformat):
4243 * eval.c (verror):
4244 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4245 since they may not be the same number.
4246 * editfns.c (Finsert_char):
4247 * fileio.c (Finsert_file_contents):
4248 Likewise for BUF_BYTES_MAX.
4249
dd52fcea
PE
4250 * image.c: Use ptrdiff_t, not int, for sizes.
4251 (slurp_file): Switch from int to ptrdiff_t.
4252 All uses changed.
4253 (slurp_file): Check that file size fits in both size_t (for
4254 malloc) and ptrdiff_t (for sanity and safety).
4255
7f9bbdbb
PE
4256 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4257 if b->modtime has its maximal value.
4258
dfe18f82
PE
4259 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4260
84acfcf0
PE
4261 Don't assume time_t can fit into int.
4262 * buffer.h (struct buffer.modtime): Now time_t, not int.
4263 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4264 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4265
ccd9a01a
PE
4266 Minor fixes for signed vs unsigned integers.
4267 * character.h (MAYBE_UNIFY_CHAR):
4268 * charset.c (maybe_unify_char):
4269 * keyboard.c (read_char, reorder_modifiers):
4270 XINT -> XFASTINT, since the integer must be nonnegative.
4271 * ftfont.c (ftfont_spec_pattern):
4272 * keymap.c (access_keymap, silly_event_symbol_error):
4273 XUINT -> XFASTINT, since the integer must be nonnegative.
4274 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4275 since it makes no difference and we prefer signed.
4276 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4277 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4278 nonnegative.
4279
d6d100dd
SM
42802011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4281
4282 * window.h (Fwindow_frame): Declare.
4283
2b6148e4
PE
42842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4287 (SPARE_MEMORY): Always define.
4288 (LARGE_REQUEST): Remove.
4289 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4290
f230ecc9
MR
42912011-06-06 Martin Rudalics <rudalics@gmx.at>
4292
727e958e
MR
4293 * lisp.h: Move EXFUNS for Fframe_root_window,
4294 Fframe_first_window and Fset_frame_selected_window to window.h.
4295
4296 * window.h: Move EXFUNS for Fframe_root_window,
4297 Fframe_first_window and Fset_frame_selected_window here from
4298 lisp.h.
4299
4300 * frame.c (Fwindow_frame, Fframe_first_window)
4301 (Fframe_root_window, Fframe_selected_window)
4302 (Fset_frame_selected_window): Move to window.c.
4303 (Factive_minibuffer_window): Move to minibuf.c.
4304 (Fother_visible_frames_p): New function.
4305
4306 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4307
f230ecc9
MR
4308 * window.c (decode_window, decode_any_window): Move up in code.
4309 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4310 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4311 (Fwindow_buffer): Move up and rewrite doc-string.
4312 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4313 (Fwindow_prev): New functions.
727e958e
MR
4314 (Fwindow_frame): Move here from frame.c. Accept any window as
4315 argument.
4316 (Fframe_root_window, Fframe_first_window)
4317 (Fframe_selected_window): Move here from frame.c. Accept frame
4318 or arbitrary window as argument. Update doc-strings.
4319 (Fminibuffer_window): Move up in code.
4320 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4321 (Fset_frame_selected_window): Move here from frame.c.
4322 Marginal rewrite.
727e958e
MR
4323 (Fselected_window, select_window, Fselect_window): Move up in
4324 code. Minor doc-string fixes.
f230ecc9 4325
4d09bcf6
PE
43262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4329 Do not assume that spare memory exists; that assumption is valid
4330 only if SYSTEM_MALLOC.
4331 (LARGE_REQUEST): New macro, so that the issue of large requests
4332 is separated from the issue of spare memory.
4333
810928a2
AS
43342011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4335
172418ad
AS
4336 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4337 format. (Bug#8806)
4338
43f862f7
AS
4339 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4340
810928a2
AS
4341 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4342 before statements.
4343
a059fe24
JD
43442011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4345
4346 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4347
4348 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4349
4350 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4351 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4352
989bf368
JB
43532011-06-05 Juanma Barranquero <lekktu@gmail.com>
4354
4355 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4356
4b80f674
CY
43572011-06-04 Chong Yidong <cyd@stupidchicken.com>
4358
4359 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4360 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4361 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4362 New error handlers.
4b80f674
CY
4363 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4364 Obey Vx_select_enable_clipboard_manager. Catch errors in
4365 x_clipboard_manager_save (Bug#8779).
4366 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4367 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4368
99a33b77 43692011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4370
4371 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4372
99a33b77 43732011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4374
4375 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4376 in the current matrix if keep_current_p is non-zero.
4377
8264569d
EZ
43782011-06-04 Eli Zaretskii <eliz@gnu.org>
4379
4380 * bidi.c (bidi_level_of_next_char): Fix last change.
4381
57f97249
EZ
43822011-06-03 Eli Zaretskii <eliz@gnu.org>
4383
fec2107c 4384 Support bidi reordering of text covered by display properties.
57f97249 4385
fec2107c
EZ
4386 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4387 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4388 (bidi_cache_search, bidi_cache_iterator_state)
4389 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4390 (bidi_level_of_next_char, bidi_move_to_visually_next):
4391 Support character positions inside a run of characters covered by a
fec2107c
EZ
4392 display string.
4393 (bidi_paragraph_init, bidi_resolve_explicit_1)
4394 (bidi_level_of_next_char): Call bidi_fetch_char and
4395 bidi_fetch_char_advance instead of FETCH_CHAR and
4396 FETCH_CHAR_ADVANCE.
4397 (bidi_init_it): Initialize new members.
4398 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4399 definitions.
4400 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4401 instead of using explicit *_CHAR codes.
d6d100dd
SM
4402 (bidi_resolve_explicit, bidi_resolve_weak):
4403 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4404 bidirectional text is supported only in multibyte buffers.
4405 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4406 it to initialize the frame_window_p member of struct bidi_it.
4407 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4408 (bidi_resolve_explicit, bidi_resolve_weak)
4409 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4410 bidi_it->nchars is non-positive.
4411 (bidi_level_of_next_char): Don't try to lookup the cache for the
4412 next/previous character if nothing is cached there yet, or if we
4413 were just reseat()'ed to a new position.
c40e2fb2 4414
0e14fe90
EZ
4415 * xdisp.c (set_cursor_from_row): Set start and stop points
4416 according to the row's direction when priming the loop that looks
4417 for the glyph on which to display cursor.
4418 (single_display_spec_intangible_p): Function deleted.
4419 (display_prop_intangible_p): Reimplement to call
4420 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4421 Accept 3 additional arguments needed by handle_display_spec.
4422 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4423 values: lists, `(when COND...)' forms, etc.
4424 (single_display_spec_string_p): Support property values that are
4425 lists with the argument STRING its top-level element.
4426 (display_prop_string_p): Fix the condition for processing a
4427 property that is a list to be consistent with handle_display_spec.
fec2107c 4428 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4429 last portion of handle_display_prop.
4430 (compute_display_string_pos): Accept additional argument
4431 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4432 value of a `display' property is a "replacing spec".
4433 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4434 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4435 the display property, but just return a value indicating whether
4436 the display property will replace the characters it covers.
4437 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4438 frame_window_p members of struct bidi_it.
d6d100dd
SM
4439 (compute_display_string_pos, compute_display_string_end):
4440 New functions.
fec2107c
EZ
4441 (push_it): Accept second argument POSITION, where pop_it should
4442 jump to continue iteration.
4443 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4444
fec2107c
EZ
4445 * keyboard.c (adjust_point_for_property): Adjust the call to
4446 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4447
4448 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4449 (bidi_init_it): Update prototypes.
4450 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4451 (compute_display_string_pos, compute_display_string_end):
4452 Declare prototypes.
fec2107c
EZ
4453 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4454 EMACS_INT.
fc6f18ce 4455
40087514 44562011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4457
57f53182
PE
4458 Malloc failure behavior now depends on size of allocation.
4459 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4460 * lisp.h: Change signatures accordingly.
4461 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4462 All callers changed. (Bug#8762)
4463
4464 * gnutls.c: Use Emacs's memory allocators.
4465 Without this change, the gnutls library would invoke malloc etc.
4466 directly, which causes problems on non-SYNC_INPUT hosts, and which
4467 runs afoul of improving memory_full behavior. (Bug#8761)
4468 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4469 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4470 xfree instead of the default malloc, realloc, free.
4471 (Fgnutls_boot): No need to check for memory allocation failure,
4472 since xmalloc does that for us.
4473
ac32cd99 4474 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4475 * category.c (hash_get_category_set):
4476 * ccl.c (ccl_driver):
4477 * charset.c (Fdefine_charset_internal):
4478 * charset.h (struct charset.hash_index):
4479 * composite.c (get_composition_id, gstring_lookup_cache)
4480 (composition_gstring_put_cache):
4481 * composite.h (struct composition.hash_index):
4482 * dispextern.h (struct image.hash):
4483 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4484 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4485 (hashfn_equal, hashfn_user_defined, make_hash_table)
4486 (maybe_resize_hash_table, hash_lookup, hash_put)
4487 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4488 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4489 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4490 * image.c (make_image, search_image_cache, lookup_image)
4491 (xpm_put_color_table_h):
4492 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4493 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4494 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4495 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4496 * alloc.c (allocate_vectorlike):
4497 Check for overflow in vector size calculations.
4498 * ccl.c (ccl_driver):
4499 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4500 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4501 need to be updated by these changes.
40087514
PE
4502 * fns.c (make_hash_table, maybe_resize_hash_table):
4503 Check for integer overflow with large hash tables.
0de4bb68
PE
4504 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4505 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4506 (SXHASH_REDUCE): New macro.
4507 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4508 Use it instead of discarding useful hash info with large hash values.
4509 (sxhash_float): New function.
4510 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4511 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4512 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4513 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4514 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4515 Adjust signatures to match updated version of code.
4516 (consing_since_gc): Now EMACS_INT, since a single hash table can
4517 use more than INT_MAX bytes.
4518
698d32e2
DN
45192011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4520
4521 Make it possible to build with GCC-4.6+ -O2 -flto.
4522
4523 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4524
fd6fa53f
SM
45252011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4526
4527 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4528 Call minibuffer-inactive-mode.
4529
864db017
JB
45302011-05-31 Juanma Barranquero <lekktu@gmail.com>
4531
4532 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4533 Update dependencies.
4534
2ad0baf4
DN
45352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4536
4537 * data.c (init_data): Remove code for UTS, this system is not
4538 supported anymore.
4539
4fcc2638
DN
45402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4541
4542 Don't force ./temacs to start in terminal mode.
4543
4544 * frame.c (make_initial_frame): Initialize faces in all cases, not
4545 only when CANNOT_DUMP is defined.
4546 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4547
c56e0fd5
DN
45482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4549
4550 * dispnew.c (add_window_display_history): Use const for the string
4551 pointer. Remove declaration, not needed.
4552
333d54da 45532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4554
55d4c1b2 4555 Use 'inline', not 'INLINE'.
333d54da 4556 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4557 * alloc.c, fontset.c (INLINE): Remove.
4558 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4559 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4560 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4561 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4562 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4563
738db178
DN
45642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4565
4566 Make it possible to run ./temacs.
4567
4568 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4569 syms_of_callproc does the same thing. Remove test for
4570 "initialized", do it in the caller.
4571 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4572
620c53a6
SM
45732011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4574
4575 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4576 (read_minibuf): Use get_minibuffer.
4577 (syms_of_minibuf): Use DEFSYM.
4578 (Qmetadata): New var.
4579 * data.c (Qbuffer): Don't make it static.
4580 (syms_of_data): Use DEFSYM.
4581
e003a292
PE
45822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4583
4584 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4585 (CCL_CODE_MIN): New macro.
4586
ed008a6d
PE
45872011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4588
3687c2ef
PE
4589 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4590
ed008a6d
PE
4591 * eval.c (Qdebug): Now static.
4592 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4593 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4594 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4595
d66c4c7c
CY
45962011-05-29 Chong Yidong <cyd@stupidchicken.com>
4597
4598 * image.c: Various fixes to ImageMagick code comments.
4599 (Fimagemagick_types): Doc fix.
4600
5fbc2025
PE
46012011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4602
0196f88a
PE
4603 Minor fixes prompted by GCC 4.6.0 warnings.
4604
4605 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4606
5fbc2025
PE
4607 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4608 (x_clipboard_manager_save_all): Move extern decl to ...
4609 * xterm.h: ... here, so that it can be checked for consistency.
4610
1dd3c2d9
CY
46112011-05-29 Chong Yidong <cyd@stupidchicken.com>
4612
4613 * xselect.c (x_clipboard_manager_save_frame)
4614 (x_clipboard_manager_save_all): New functions.
4615 (Fx_clipboard_manager_save): Lisp function deleted.
4616
4617 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4618 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4619
4620 * xterm.h: Update prototype.
4621
5ba6571d
WX
46222011-05-28 William Xu <william.xwl@gmail.com>
4623
4624 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4625 exiting (Bug#8239).
4626
3eaff834
JM
46272011-05-28 Jim Meyering <meyering@redhat.com>
4628
e1900994 4629 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4630 * fns.c (to_uchar): Define.
4631 (crypto_hash_function): Use it to convert some newly-signed
4632 variables to unsigned, to avoid sign-extension bugs. For example,
4633 without this change, (md5 "truc") would evaluate to
4634 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4635 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4636 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4637
0f6990a7
PE
46382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4639
4640 Integer overflow fixes.
c8a9ca5a 4641
08686060
PE
4642 * dbusbind.c: Serial number integer overflow fixes.
4643 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4644 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4645 to hold a serial number that is too large for a fixnum.
4646 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4647 Check for serial numbers out of range. Decode any serial number
59568bf0 4648 that was so large that it became a float. (Bug#8722)
08686060 4649
2d1fc3c7
PE
4650 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4651 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4652 Use XFASTINT rather than XUINT when numbers are nonnegative.
4653 (xd_append_arg, Fdbus_method_return_internal):
4654 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4655 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4656 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4657 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4658 (Bug#8722)
2d1fc3c7 4659
c8a9ca5a
PE
4660 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4661
519e1d69
PE
4662 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4663
30569699
PE
4664 ccl: add integer overflow checks
4665 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4666 (IN_INT_RANGE): New macros.
4667 (ccl_driver): Use them to check for integer overflow when
4668 decoding a CCL program. Many of the new checks are whether XINT (x)
4669 fits in int; it doesn't always, on 64-bit hosts. The new version
4670 doesn't catch all possible integer overflows, but it's an
847044ea 4671 improvement. (Bug#8719)
30569699 4672
c11285dc
PE
4673 * alloc.c (make_event_array): Use XINT, not XUINT.
4674 There's no need for unsigned here.
4675
fdccd48e
PE
4676 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4677 This follows up to the 2011-05-06 change that substituted uintptr_t
4678 for EMACS_INT. This case wasn't caught back then.
4679
37910ab2
PE
4680 Rework Fformat to avoid integer overflow issues.
4681 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4682 now (part of C89). Include <verify.h>.
4683 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4684 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4685 (Fformat): Avoid the prepass trying to compute sizes; it was only
4686 approximate and thus did not catch overflow reliably. Instead, walk
4687 through the format just once, formatting and computing sizes as we go,
4688 checking for integer overflow at every step, and allocating a larger
4689 buffer as needed. Keep track separately whether the format is
4690 multibyte. Keep only the most-recently calculated precision, rather
4691 than them all. Record whether each argument has been converted to
4692 string. Use EMACS_INT, not int, for byte and char and arg counts.
4693 Support field widths and precisions larger than INT_MAX. Avoid
4694 sprintf's undefined behavior with conversion specifications such as %#d
4695 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4696 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4697 formatting out-of-range floating point numbers with int
9173deec 4698 formats. (Bug#8668)
37910ab2 4699
2e6578fb
PE
4700 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4701
0ae6bdee
PE
4702 * data.c: Avoid integer truncation in expressions involving floats.
4703 * data.c: Include <intprops.h>.
4704 (arith_driver): When there's an integer overflow in an expression
4705 involving floating point, convert the integers to floating point
4706 so that the resulting value does not suffer from catastrophic
4707 integer truncation. For example, on a 64-bit host (* 4
4708 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4709 Do not rely on undefined behavior after integer overflow.
4710
de883a70
PE
4711 merge count_size_as_multibyte, parse_str_to_multibyte
4712 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4713 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4714 Check for integer overflow.
4715 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4716 since it's now a duplicate of the other. This is more of
4717 a character than a buffer op, so better that it's in character.c.
4718 * fns.c, print.c: Adjust to above changes.
4719
2ff916cb
PE
47202011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4721
4722 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4723
f1b54466
PE
47242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4725
fb1ac845
PE
4726 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4727 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4728 (x_clipboard_manager_save): Now static.
4729 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4730
f1b54466
PE
4731 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4732 (crypto_hash_function): Now static.
4733 Fix pointer signedness problems. Avoid unnecessary initializations.
4734
a9f737ee
CY
47352011-05-27 Chong Yidong <cyd@stupidchicken.com>
4736
4737 * termhooks.h (Vselection_alist): Make it terminal-local.
4738
4739 * terminal.c (create_terminal): Initialize it.
4740
4741 * xselect.c: Support for clipboard managers.
4742 (Vselection_alist): Move to termhooks.h as terminal-local var.
4743 (LOCAL_SELECTION): New macro.
4744 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4745 (symbol_to_x_atom): Remove gratuitous arg.
4746 (x_handle_selection_request, lisp_data_to_selection_data)
4747 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4748 (x_own_selection, x_get_local_selection, x_convert_selection):
4749 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4750 (some_frame_on_display): Delete unused function.
4751 (Fx_own_selection_internal, Fx_get_selection_internal)
4752 (Fx_disown_selection_internal, Fx_selection_owner_p)
4753 (Fx_selection_exists_p): New optional frame arg.
4754 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4755 (x_handle_selection_clear): Don't treat other terminals with the
4756 same keyboard specially. Use the terminal-local Vselection_alist.
4757 (x_clear_frame_selections): Use Frun_hook_with_args.
4758
4759 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4760
4761 * xterm.h: Add support for those atoms.
4762
e067f0c1
CY
47632011-05-26 Chong Yidong <cyd@stupidchicken.com>
4764
4765 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4766 (converted_selections, conversion_fail_tag): New global variables.
4767 (x_selection_request_lisp_error): Free the above.
4768 (x_get_local_selection): Remove unnecessary code.
4769 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4770 of converted selections stored in converted_selections.
4771 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4772 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4773 (x_convert_selection): New function.
4774 (x_handle_selection_event): Simplify.
4775 (x_get_foreign_selection): Don't ignore incoming requests while
4776 waiting for an answer; this will fail when we implement
4777 SAVE_TARGETS, and seems unnecessary anyway.
4778 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4779 (Vx_sent_selection_functions): Doc fix.
4780
0f4aebc0
LL
47812011-05-26 Leo Liu <sdl.web@gmail.com>
4782
4783 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4784
e61124cd
YM
47852011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4786
4787 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4788
4789 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4790 for fringe update if it has periodic bitmap.
ac389d0c 4791 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4792 and fringe_bitmap_periodic_p.
4793
4794 * fringe.c (get_fringe_bitmap_data): New function.
4795 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4796 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4797 row. Mark glyph row for fringe update if periodicity changed.
4798
4799 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4800 for fringe update unless it has periodic bitmap.
4801
f16d9837
KH
48022011-05-25 Kenichi Handa <handa@m17n.org>
4803
4804 * xdisp.c (get_next_display_element): Set correct it->face_id for
4805 a static composition.
4806
e1b90ef6
LL
48072011-05-24 Leo Liu <sdl.web@gmail.com>
4808
4809 * deps.mk (fns.o):
4810 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4811
4812 * fns.c (crypto_hash_function, Fsha1): New function.
4813 (Fmd5): Use crypto_hash_function.
4814 (syms_of_fns): Add Ssha1.
4815
7400048f
PE
48162011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4817
4818 * gnutls.c: Remove unused macros.
4819 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4820 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4821 Remove macros that are defined and never used.
4822 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4823
abb71cf4
CY
48242011-05-22 Chong Yidong <cyd@stupidchicken.com>
4825
4826 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4827 (Fx_get_selection_internal): Minor cleanup.
4828 (Fx_own_selection_internal): Rename arguments for consistency with
4829 select.el.
4830
6307db39
PE
48312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4832
4833 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4834
f3d4e0a4
CY
48352011-05-22 Chong Yidong <cyd@stupidchicken.com>
4836
4837 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4838
4d8ade89
YM
48392011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4840
4841 * dispnew.c (scrolling_window): Don't exclude the case that the
4842 last enabled row in the desired matrix touches the bottom boundary.
4843
32078c8d
GM
48442011-05-21 Glenn Morris <rgm@gnu.org>
4845
4846 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4847 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4848 and add some more files.
32078c8d 4849
7285dc67
EZ
48502011-05-20 Eli Zaretskii <eliz@gnu.org>
4851
4852 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4853 report_file_error introduced by the change from 2011-05-07.
4854
89d1bd22
PE
48552011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4856
4857 * systime.h (Time): Define only if emacs is defined.
4858 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4859 where the include path doesn't have X11/X.h by default. See
4860 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4861
e23640bb 48622011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4863
4864 * composite.c (find_automatic_composition): Fix previous change.
4865
b9704ad9
GM
48662011-05-20 Glenn Morris <rgm@gnu.org>
4867
4868 * lisp.mk: New file, split from Makefile.in.
4869 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4870 (shortlisp): Remove.
4871 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4872
4a720484
GM
48732011-05-19 Glenn Morris <rgm@gnu.org>
4874
4875 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4876 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4877 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4878 (lisp): Set the order to that of loadup.el.
4879 (shortlisp): Make it a copy of $lisp.
4880 (SOME_MACHINE_LISP): Remove.
4881 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4882 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4883
a28d4396
KH
48842011-05-18 Kenichi Handa <handa@m17n.org>
4885
4886 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4887 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4888 (find_automatic_composition): Mostly rewrite for efficiency.
4889
a2b1fa8e
JB
48902011-05-18 Juanma Barranquero <lekktu@gmail.com>
4891
4892 * makefile.w32-in: Update dependencies.
4893
8e1f5610
CS
48942011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4895
4896 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4897 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4898
7025ee00 48992011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4900
cdfa6eab
PE
4901 Fix some integer overflow issues, such as string length overflow.
4902
06d6db33
PE
4903 * insdel.c (count_size_as_multibyte): Check for string overflow.
4904
2b4560a8
PE
4905 * character.c (lisp_string_width): Check for string overflow.
4906 Use EMACS_INT, not int, for string indexes and lengths; in
4907 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4908 the resulting string length overflows an EMACS_INT; instead,
4909 report a string overflow if no precision given. When checking for
4910 precision exhaustion, use a check that cannot possibly have
4911 integer overflow. (Bug#8675)
4912 * character.h (lisp_string_width): Adjust to new signature.
4913
cb93f9be
PE
4914 * alloc.c (string_overflow): New function.
4915 (Fmake_string): Use it. This doesn't change behavior, but saves
4916 a few bytes and will simplify future changes.
4917 * character.c (string_escape_byte8): Likewise.
4918 * lisp.h (string_overflow): New decl.
4919
1a1f3366
PE
4920 Fixups, following up to the user-interface timestamp change.
4921 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4922 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4923 * msdos.c (mouse_get_pos): Likewise.
4924 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4925 * w32gui.h (Time): Define by including "systime.h" rather than by
4926 declaring it ourselves. (Bug#8664)
4927
d4e3e4d3
PE
4928 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4929 * image.c (clear_image_cache): Likewise.
4930
f6a24d19
PE
4931 * term.c (term_mouse_position): Don't assume time_t wraparound.
4932
08dc5ae6
PE
4933 Be more systematic about user-interface timestamps.
4934 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4935 and sometimes 'EMACS_UINT', to represent these timestamps.
4936 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4937 This makes the code easier to follow, and makes it easier to catch
4938 integer overflow bugs such as Bug#8664.
4939 * frame.c (Fmouse_position, Fmouse_pixel_position):
4940 Use Time, not unsigned long, for user-interface timestamps.
4941 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4942 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4943 * keyboard.h (last_event_timestamp): Likewise.
4944 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4945 * menu.h (xmenu_show): Likewise.
4946 * term.c (term_mouse_position): Likewise.
4947 * termhooks.h (struct input_event.timestamp): Likewise.
4948 (struct terminal.mouse_position_hook): Likewise.
4949 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4950 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4951 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4952 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4953 what it was before.
4954 * menu.h, termhooks.h: Include "systime.h", for Time.
4955
8e55734a
PE
4956 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4957 Don't assume that the difference between two unsigned long values
4958 can fit into an integer. At this point, we know button_down_time
4959 <= event->timestamp, so the difference must be nonnegative, so
4960 there's no need to cast the result if double-click-time is
4961 nonnegative, as it should be; check that it's nonnegative, just in
4962 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4963 apart (about 25 days). (Bug#8664)
8e55734a 4964
841f1b75 4965 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4966 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4967
3e26f69c
PE
4968 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4969 that always fit in int. Use a sentinel instead of a counter, to
4970 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4971 * frame.h (struct frame): Use int for menu_bar_items_used
4972 instead of EMACS_INT, since it always fits in int.
3e26f69c 4973
5cc152c0
PE
4974 * menu.c (grow_menu_items): Check for int overflow.
4975
d89eb65e
PE
4976 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4977
5235bd3e
PE
4978 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4979 Before, the code was not consistent. These values cannot exceed
4980 2**31 - 1 so there's no need to make them unsigned.
4981 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4982 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4983 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4984 as modifiers.
4985 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4986
bc827e23
PE
4987 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4988 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4989 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4990 presumably because the widths might not match.
4991
78eb494e
PE
4992 * window.c (size_window): Avoid needless test at loop start.
4993
04f2d78b
CB
49942011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4995
4996 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4997
d2fc7e3d 49982011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4999
5000 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5001
d2fc7e3d 50022011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5003
5004 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5005 `width' to `bar_area_x' and `bar_area_width', respectively.
5006 (x_scroll_run): Take account of fringe background extension.
5007
04f2d78b
CB
5008 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5009 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5010 `bar_area_width', respectively.
5011 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5012 background extension.
5013
79b70037
GM
50142011-05-10 Jim Meyering <meyering@redhat.com>
5015
5016 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5017
2f142cc5
JB
50182011-05-10 Juanma Barranquero <lekktu@gmail.com>
5019
5020 * image.c (Finit_image_library): Return t for built-in image types,
5021 like pbm and xbm. (Bug#8640)
5022
57679c86
AS
50232011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5024
5025 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5026
888c9e86
EZ
50272011-05-07 Eli Zaretskii <eliz@gnu.org>
5028
b0512a1d
EZ
5029 * w32console.c (Fset_screen_color): Doc fix.
5030 (Fget_screen_color): New function.
5031 (syms_of_ntterm): Defsubr it.
5032
7285dc67
EZ
5033 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5034 unlink the temporary file if Fcall_process didn't create it in the
5035 first place.
5036 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5037 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5038 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5039 cue to call_process_cleanup not to close that handle.
5040
4d3fcc8e
BK
50412011-05-07 Ben Key <bkey76@gmail.com>
5042
5043 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5044 one of two shell specific rules, either bootstrap-temacs-CMD or
5045 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5046 to the previous implementation of the bootstrap-temacs rule.
5047 The bootstrap-temacs-CMD rule is similar to the previous
5048 implementation of the bootstrap-temacs rule except that it
5049 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5050 variable.
5051
5052 These changes, along with some changes to nt/configure.bat,
5053 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5054 earlier fix to add support for --cflags and --ldflags options
5055 that include quotes so that it works whether make uses cmd or
5056 sh as the shell.
5057
b4289b64
MA
50582011-05-06 Michael Albinus <michael.albinus@gmx.de>
5059
5060 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5061 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5062 is a constant.
5063 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5064 a string. Handle both cases.
5065 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5066 (Fdbus_register_method): Use Qinvalid_function.
5067
af4c0e28
JB
50682011-05-06 Juanma Barranquero <lekktu@gmail.com>
5069
5070 * makefile.w32-in: Update dependencies.
5071 (LISP_H): Add inttypes.h and stdin.h.
5072 (PROCESS_H): Add unistd.h.
5073
c51453d9
EZ
50742011-05-06 Eli Zaretskii <eliz@gnu.org>
5075
5076 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5077 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5078
8ff0ac3c 50792011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5080
4c4b566b
PE
5081 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5082
aab2b9b5
PE
5083 * term.c (vfatal): Remove stray call to va_end.
5084 It's not needed and the C Standard doesn't allow it here anyway.
5085
c378da0b
PE
5086 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5087 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5088
288b08c7
PE
5089 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5090 bytes.
5091
e3601888
PE
5092 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5093
db6c0e74
PE
5094 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5095
dd5963ea
PE
5096 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5097
88c9450f
PE
5098 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5099
2f9442b8
PE
5100 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5101
c032b5f8
PE
5102 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5103 * charset.c (Fdefine_charset_internal): Don't initialize
5104 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5105 32-bit int (Bug#8600).
a108c10b
PE
5106
5107 * lread.c (read_integer): Be more consistent with string-to-number.
5108 Use string_to_number to do the actual conversion; this avoids
5109 rounding errors and fixes some other screwups. Without this fix,
5110 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5111 (digit_to_number): Move earlier, for benefit of read_integer.
5112 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5113 not a digit in any supported base. (Bug#8602)
a108c10b 5114
ad5f9eea
PE
5115 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5116
aec1708a
PE
5117 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5118 to match comment at start of function. This also removes a
5119 GCC warning about overflow in a 32+64-bit port.
5120
47be4ab5
PE
5121 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5122
371cac43
PE
5123 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5124 Reported by Stefan Monnier in
5125 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5126 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5127 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5128
d01a7826
PE
5129 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5130 (EMACS_UINTPTR): Likewise, with uintptr_t.
5131
7fd47d5c
PE
5132 * lisp.h: Prefer 64-bit EMACS_INT if available.
5133 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5134 on 32-bit hosts that have 64-bit int, so that they can access
5135 large files.
122b0c86
PE
5136 However, temporarily disable this change unless the temporary
5137 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5138
8727937b
PE
5139 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5140
8ac068ac
PE
5141 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5142 This removes an assumption that EMACS_INT and long are the same
5143 width as pointers. The assumption is true for Emacs porting targets
5144 now, but we want to make other targets possible.
5145 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5146 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5147 In the rest of the code, change types of integers that hold casted
5148 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5149 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5150 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5151 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5152 No need to cast type when ORing.
5153 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5154 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5155 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5156 assume EMACS_INT is the same width as char *.
5157 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5158 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5159 Remove no-longer-needed casts.
5160 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5161 (xg_tool_bar_help_callback, xg_make_tool_item):
5162 Use EMACS_INTPTR to hold an integer
5163 that will be cast to void *; this can avoid a GCC warning
5164 if EMACS_INT is not the same width as void *.
5165 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5166 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5167 (current_message_1, set_message_1):
5168 Use a local to convert to proper width without a cast.
5169 * xmenu.c (dialog_selection_callback): Likewise.
5170
ede49d71
PE
5171 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5172 Also, don't assume VALBITS / RAND_BITS is less than 5,
5173 and don't rely on undefined behavior when shifting a 1 left into
5174 the sign bit.
5175 * lisp.h (get_random): Change signature to match.
5176
2f30ecd0
PE
5177 * lread.c (hash_string): Use size_t, not int, for hash computation.
5178 Normally we prefer signed values; but hashing is special, because
5179 it's better to use unsigned division on hash table sizes so that
5180 the remainder is nonnegative. Also, size_t is the natural width
5181 for hashing into memory. The previous code used 'int', which doesn't
5182 retain enough info to hash well into very large tables.
5183 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5184
2a866e7b
PE
5185 * dbusbind.c: Don't possibly lose pointer info when converting.
5186 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5187 Use XPNTR rather than XHASH, so that the high-order bits of
5188 the pointer aren't lost when converting through void *.
5189
51639eac
PE
5190 * eval.c (Fautoload): Don't double-shift a pointer.
5191
92394119
PE
5192 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5193
dbdb9a7c
JB
51942011-05-06 Juanma Barranquero <lekktu@gmail.com>
5195
5196 * gnutls.c (DEF_GNUTLS_FN):
5197 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5198
db7a0b4f
AS
51992011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5200
5201 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5202 marker. (Bug#8610)
5203
f7ff1b0f 52042011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5205
5206 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5207 New version that can reserve upto 2GB of heap space.
5208
f7ff1b0f 52092011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5210
5211 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5212
639c109b
TZ
52132011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5214
5215 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5216 `gnutls_certificate_set_x509_key_file'.
5217
d2127135
JB
52182011-05-05 Juanma Barranquero <lekktu@gmail.com>
5219
5220 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5221 Update dependencies.
5222
e968f4f3
JB
52232011-05-04 Juanma Barranquero <lekktu@gmail.com>
5224
5225 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5226 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5227 Remove unused parameter `fildes'.
5228 * process.c (read_process_output, send_process): Don't pass it.
5229
84d358f0
JB
52302011-05-04 Juanma Barranquero <lekktu@gmail.com>
5231
5232 Fix previous change: the library cache is defined in w32.c.
5233 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5234 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5235
0898ca10
JB
52362011-05-04 Juanma Barranquero <lekktu@gmail.com>
5237
5238 Implement dynamic loading of GnuTLS on Windows.
5239
5240 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5241 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5242 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5243 Declare.
5244
5245 * gnutls.c (Qgnutls_dll): Define.
5246 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5247 (gnutls_*): Declare function pointers.
5248 (init_gnutls_functions): New function to initialize function pointers.
5249 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5250 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5251 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5252 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5253 (emacs_gnutls_write, emacs_gnutls_read)
5254 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5255 (Fgnutls_available_p): New function.
5256 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5257 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5258 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5259
5260 * image.c: Include w32.h.
5261 (Vimage_type_cache): Delete.
5262 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5263 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5264 (w32_delayed_load): Move to w32.c.
5265
5266 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5267
5268 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5269 (w32_delayed_load): Move from image.c. When loading a library, record
5270 its filename in the :loaded-from property of the library id.
5271 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5272 Initialize and staticpro them.
5273 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5274
5275 * process.c: Include lisp.h before w32.h, not after.
5276 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5277 instead of gnutls_record_check_pending.
5278
5279 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5280
ff4de4aa
TZ
52812011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5282
5283 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5284 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5285 as passed in.
5286
abe95abb
JD
52872011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5288
5289 * xterm.c (x_set_frame_alpha): Do not set property on anything
5290 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5291
e16e55d4
JB
52922011-05-02 Juanma Barranquero <lekktu@gmail.com>
5293
5294 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5295
bafcf6a5
JB
52962011-05-02 Juanma Barranquero <lekktu@gmail.com>
5297
5298 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5299 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5300 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5301 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5302 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5303 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5304 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5305 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5306 (Qgnutls_bootprop_callbacks_verify): Make static.
5307
e7a6747f
AS
53082011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5309
19ed11ba
AS
5310 * callproc.c: Indentation fixup.
5311
e7a6747f 5312 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5313 (wait_for_termination, interruptible_wait_for_termination):
5314 Move after wait_for_termination_1.
e7a6747f 5315
1ef14cb4
LMI
53162011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5317
5318 * sysdep.c (interruptible_wait_for_termination): New function
5319 which is like wait_for_termination, but allows keyboard
5320 interruptions.
5321
5322 * callproc.c (Fcall_process): Add (:file "file") as an option for
5323 the STDOUT buffer.
5324 (Fcall_process_region): Ditto.
5325
330d880c
EZ
53262011-04-30 Eli Zaretskii <eliz@gnu.org>
5327
8db90b73
EZ
5328 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5329 rather than `XVECTOR (FOO)->size'.
5330
330d880c
EZ
5331 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5332 inttypes.h, as a gnulib replacement is used if it not available in
5333 system headers.
5334
15cbd324
EZ
53352011-04-21 Eli Zaretskii <eliz@gnu.org>
5336
5337 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5338 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5339 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5340
5341 * coding.c (coding_alloc_by_realloc): Error out if destination
5342 will grow beyond MOST_POSITIVE_FIXNUM.
5343 (decode_coding_emacs_mule): Abort if there isn't enough place in
5344 charbuf for the composition carryover bytes. Reserve an extra
5345 space for up to 2 characters produced in a loop.
5346 (decode_coding_iso_2022): Abort if there isn't enough place in
5347 charbuf for the composition carryover bytes.
5348
53492011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5350
ae940cca
EZ
5351 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5352 aborting when %lld or %lll format is passed.
5353 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5354 %llo or %llx format is passed. (Bug#8545)
5355
03ab8921
EZ
5356 * window.c (window_scroll_line_based): Use a marker instead of
5357 simple variables to record original value of point. (Bug#7952)
5358
afda1437
EZ
5359 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5360 produced by %s or %c overflows available buffer space. (Bug#8545)
5361
f76dee0c
PE
53622011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5363
5364 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5365 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5366
fdc5744d
JB
53672011-04-28 Juanma Barranquero <lekktu@gmail.com>
5368
5369 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5370
638f053a
JB
53712011-04-28 Juanma Barranquero <lekktu@gmail.com>
5372
5373 * keyboard.c (Qdelayed_warnings_hook): Define.
5374 (command_loop_1): Run `delayed-warnings-hook'
5375 if Vdelayed_warnings_list is non-nil.
5376 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5377 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5378
d178f871
EZ
53792011-04-28 Eli Zaretskii <eliz@gnu.org>
5380
5381 * doprnt.c (doprnt): Don't return value smaller than the buffer
5382 size if the message was truncated. (Bug#8545).
5383
b124fd93
JB
53842011-04-28 Juanma Barranquero <lekktu@gmail.com>
5385
5386 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5387 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5388
e810457d
PE
53892011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5390
5391 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5392
ea51cceb
JB
53932011-04-27 Juanma Barranquero <lekktu@gmail.com>
5394
5395 * makefile.w32-in: Update dependencies.
5396
94dcfacf
EZ
53972011-04-27 Eli Zaretskii <eliz@gnu.org>
5398
5399 Improve `doprnt' and its usage. (Bug#8545)
5400 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5401 `format_end'. Remove support for %l as a conversion specifier.
5402 Don't use xrealloc. Improve diagnostics when the %l size modifier
5403 is used. Update the commentary.
5404
5405 * eval.c (verror): Simplify calculation of size_t.
5406
5407 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5408 messages.
5409
f61f41d7
PE
54102011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5411
5412 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5413 change.
5414
96fb4434
PE
54152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5416
5417 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5418 This makes this file independent of the recent pseudovector change.
5419
671875da 54202011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5421
69e9b5a3
PE
5422 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5423
b5f869a7 5424 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5425 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5426 Remove unused local.
c8926152 5427 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5428
841a1577 5429 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5430 GCC 4.6.0 optimizes based on type-based alias analysis.
5431 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5432 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5433 != &v->size, and therefore "v->size = 1; b->size = 2; return
5434 v->size;" must therefore return 1. This assumption is incorrect
5435 for Emacs, since it type-puns struct Lisp_Vector * with many other
5436 types. To fix this problem, this patch adds a new type struct
f904488f 5437 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5438 and pseudovectors, and helps optimizing compilers not get fooled
5439 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5440 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5441 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5442 the size member.
eab3844f
PE
5443 (XSETPVECTYPE): Rewrite in terms of new macro.
5444 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5445 This is a bit clearer, and further avoids the possibility of
5446 undesirable aliasing.
5447 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5448 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5449 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5450 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5451 (ASIZE): Now uses header.size rather than size.
5452 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5453 to avoid the hassle of writing XVECTOR (foo)->header.size.
5454 (struct vectorlike_header): New type.
eab3844f
PE
5455 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5456 object, to help avoid aliasing.
5457 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5458 (SUBRP): Likewise, since Lisp_Subr is a special case.
5459 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5460 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5461 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5462 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5463 changed to be "header.size" and "header.next".
5464 * buffer.h (struct buffer): Likewise.
5465 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5466 * frame.h (struct frame): Likewise.
5467 * process.h (struct Lisp_Process): Likewise.
5468 * termhooks.h (struct terminal): Likewise.
5469 * window.c (struct save_window_data, struct saved_window): Likewise.
5470 * window.h (struct window): Likewise.
5471 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5472 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5473 * buffer.c (init_buffer_once): Likewise.
5474 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5475 special case.
5476 * process.c (Fformat_network_address): Use local var for size,
5477 for brevity.
5478
0df1eac5
PE
5479 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5480
847ab9d1 5481 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5482 * data.c (atof): Remove decl; no longer used or needed.
5483 (digit_to_number): Move to lread.c.
5484 (Fstring_to_number): Use new string_to_number function, to be
5485 consistent with how the Lisp reader treats infinities and NaNs.
5486 Do not assume that floating-point numbers represent EMACS_INT
5487 without losing information; this is not true on most 64-bit hosts.
5488 Avoid double-rounding errors, by insisting on integers when
5489 parsing non-base-10 numbers, as the documentation specifies.
5490 * lisp.h (string_to_number): New decl, replacing ...
5491 (isfloat_string): Remove.
bc0a5c13 5492 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5493 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5494 appears to have been a coding error. Similarly, do not accept
5495 strings like +-1e0 as floating point numbers. Do not report
5496 overflow for integer overflows unless the base is not 10 which
5497 means we have no simple and reliable way to continue.
5498 Break out the floating-point parsing into a new
5499 function string_to_number, so that Fstring_to_number parses
5500 floating point numbers consistently with the Lisp reader.
04f2d78b 5501 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5502 (E_CHAR, EXP_INT): Remove, replacing with ...
5503 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5504 (string_to_number): New function, replacing isfloat_string.
5505 This function checks for valid syntax and produces the resulting
5506 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5507 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5508 so that overflow for non-base-10 numbers is reported only when
5509 there's no portable and simple way to convert to floating point.
452f4150 5510
67769ffc
PE
5511 * textprop.c (set_text_properties_1): Rewrite for clarity,
5512 and to avoid GCC warning about integer overflow.
5513
c20db43f
PE
5514 * intervals.h (struct interval): Use EMACS_INT for members
5515 where EMACS_UINT might cause problems. See
5516 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5517 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5518 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5519 All uses changed.
37aa2f85
PE
5520 (offset_intervals): Tell GCC not to worry about length overflow
5521 when negating a negative length.
c20db43f 5522
2538aa2f
PE
5523 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5524 (overrun_check_free): Likewise.
5525
f2d3008d
PE
5526 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5527 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5528 word size.
5529
ec8df744
PE
5530 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5531 (gnutls_make_error): Rename local to avoid shadowing.
5532 (gnutls_emacs_global_deinit): ifdef out; not used.
5533 (Fgnutls_boot): Use const for pointer to readonly storage.
5534 Comment out unused local. Fix pointer signedness problems.
5535
640ee02d
PE
5536 * lread.c (openp): Don't stuff size_t into an 'int'.
5537 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5538 about possible signed overflow.
5539
6048fb2a
PE
5540 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5541 (GDK_KEY_g): Don't define if already defined.
5542 (xg_prepare_tooltip): Avoid pointer signedness problem.
5543 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5544
fa3c87e1
PE
5545 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5546 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5547
2172544b
PE
5548 * xfns.c (Fx_window_property): Simplify a bit,
5549 to make a bit faster and to avoid GCC 4.6.0 warning.
5550 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5551
9b821a21
PE
5552 * fns.c (internal_equal): Don't assume size_t fits in int.
5553
3c616cfa
PE
5554 * alloc.c (compact_small_strings): Tighten assertion a little.
5555
c2982e87
PE
5556 Replace pEd with more-general pI, and fix some printf arg casts.
5557 * lisp.h (pI): New macro, generalizing old pEd macro to other
5558 conversion specifiers. For example, use "...%"pI"d..." rather
5559 than "...%"pEd"...".
5560 (pEd): Remove. All uses replaced with similar uses of pI.
5561 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5562 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5563 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5564 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5565 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5566 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5567 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5568 64-bit hosts.
5569 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5570 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5571 * print.c (safe_debug_print, print_object): Likewise.
5572 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5573 to int.
6f04d126
PE
5574 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5575 avoiding the 0 flag, which is not portable.
c2982e87
PE
5576 * process.c (Fmake_network_process): Use pI to avoid cast.
5577 * region-cache.c (pp_cache): Likewise.
5578 * xdisp.c (decode_mode_spec): Likewise.
5579 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5580 behavior on 64-bit hosts with printf arg.
6f04d126 5581 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5582 (x_stop_queuing_selection_requests): Likewise.
5583 (x_get_window_property): Don't truncate byte count to an 'int'
5584 when tracing.
0b432f21 5585
5e073ec7
PE
5586 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5587 here, since it parses constructs like leading '-' and spaces,
5588 which are not wanted; and it overflows with large numbers.
5589 Instead, simply match F[0-9]+, which is what is wanted anyway.
5590
36372bf9
PE
5591 * alloc.c: Remove unportable assumptions about struct layout.
5592 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5593 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5594 (allocate_vectorlike, make_pure_vector): Use the new macros,
5595 plus offsetof, to remove unportable assumptions about struct layout.
5596 These assumptions hold on all porting targets that I know of, but
5597 they are not guaranteed, they're easy to remove, and removing them
5598 makes further changes easier.
5599
0b432f21
PE
5600 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5601 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5602 (string_overrun_cookie): Now const. Use initializers that
5603 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5604 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5605 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5606 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5607 multiple of sizeof (EMACS_INT); it need not be, if
5608 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5609 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5610
895009e1
JB
56112011-04-26 Juanma Barranquero <lekktu@gmail.com>
5612
5613 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5614
6a7a1b0b
TZ
56152011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5616
5617 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5618 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5619 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5620
841a1577 56212011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5622
5623 * lisp.h (Qdebug): List symbol.
895009e1 5624 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5625 * keyboard.c (debug-on-event): New variable.
5626 (handle_user_signal): Break into debugger when debug-on-event
5627 matches the current signal symbol.
5628
f2d3ba6f
DN
56292011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5630
5631 * alloc.c (check_sblock, check_string_bytes)
5632 (check_string_free_list): Convert to standard C.
5633
42ce4c63
TZ
56342011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5635
5636 * w32.c (emacs_gnutls_push): Fix typo.
5637
825cd63c
EZ
56382011-04-25 Eli Zaretskii <eliz@gnu.org>
5639
fb11d64d
EZ
5640 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5641 "cast to pointer from integer of different size".
5642
825cd63c
EZ
5643 Improve doprnt and its use in verror. (Bug#8545)
5644 * doprnt.c (doprnt): Document the set of format control sequences
5645 supported by the function. Use SAFE_ALLOCA instead of always
5646 using `alloca'.
5647
5648 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5649 is one byte too soon. Don't use xrealloc; instead xfree and
5650 xmalloc anew.
5651
e061a11b
TZ
56522011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5653
5654 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5655 callbacks stage.
5656
5657 * gnutls.c: Renamed global_initialized to
5658 gnutls_global_initialized. Added internals for the
5659 :verify-hostname-error, :verify-error, and :verify-flags
5660 parameters of `gnutls-boot' and documented those parameters in the
5661 docstring. Start callback support.
9173deec
JB
5662 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5663 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5664 on error. Return error code.
e061a11b
TZ
5665 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5666 (emacs_gnutls_read): Likewise.
5667 (Fgnutls_boot): Return handshake error code.
5668 (emacs_gnutls_handle_error): New function.
5669 (wsaerror_to_errno): Likewise.
5670
5671 * w32.h (emacs_gnutls_pull): Add prototype.
5672 (emacs_gnutls_push): Likewise.
5673
5674 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5675 (emacs_gnutls_push): Likewise.
5676
56772011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5678
5679 * process.c (wait_reading_process_output): Check if GnuTLS
5680 buffered some data internally if no FDs are set for TLS
5681 connections.
5682
5683 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5684 (LIBS): Link to USER_LIBS.
5685 ($(BLD)/gnutls.$(0)): New target.
5686
fa6996bc
EZ
56872011-04-24 Eli Zaretskii <eliz@gnu.org>
5688
eb35682e
EZ
5689 * xdisp.c (handle_single_display_spec): Rename the
5690 display_replaced_before_p argument into display_replaced_p, to
5691 make it consistent with the commentary. Fix typos in the
5692 commentary.
5693
e2ad650c
EZ
5694 * textprop.c (syms_of_textprop): Remove dead code.
5695 (copy_text_properties): Delete obsolete commentary about an
5696 interface that was deleted long ago. Fix typos in the description
5697 of arguments.
5698
1b2de274
EZ
5699 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5700 to changes in oldXMenu/XMenu.h from 2011-04-16.
5701 <menu_help_message, prev_menu_help_message>: Constify.
5702 (IT_menu_make_room): menu->help_text is now `const char **';
5703 adjust.
5704
5705 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5706 to changes in oldXMenu/XMenu.h from 2011-04-16.
5707 (struct XMenu): Declare `help_text' `const char **'.
5708
5709 * xfaces.c <Qunspecified>: Make extern again.
5710
5711 * syntax.c: Include sys/types.h before including regex.h, as
5712 required by Posix.
5713
762b15be
EZ
5714 * doc.c (get_doc_string): Improve the format passed to `error'.
5715
5716 * doprnt.c (doprnt): Improve commentary.
5717
5718 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5719
5720 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5721 them with etags.
5722
f1052e5d
EZ
5723 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5724 changes in globals.h immediately force recompilation.
762b15be
EZ
5725 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5726 $(CURDIR)/s/ms-w32.h.
5727 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5728
fa6996bc
EZ
5729 * character.c (Fchar_direction): Function deleted.
5730 (syms_of_character): Don't defsubr it.
5731 <char-direction-table>: Deleted.
5732
e6c3da20
EZ
57332011-04-23 Eli Zaretskii <eliz@gnu.org>
5734
5735 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5736 * doprnt.c: Include limits.h.
5737 (SIZE_MAX): New macro.
04f2d78b
CB
5738 (doprnt): Return a size_t value. 2nd arg is now size_t.
5739 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5740 Improve overflow protection. Support `l' modifier for integer
5741 conversions. Support %l conversion. Don't assume an EMACS_INT
5742 argument for integer conversions and for %c.
5743
5744 * lisp.h (doprnt): Restore prototype.
5745
5746 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5747 $(SRC)/character.h.
5748
5749 * Makefile.in (base_obj): Add back doprnt.o.
5750
5751 * deps.mk (doprnt.o): Add back prerequisites.
5752 (callint.o): Depend on character.h.
5753
5754 * eval.c (internal_lisp_condition_case): Include the handler
5755 representation in the error message.
5756 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5757 when breaking from the loop.
5758
5759 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5760
5761 * callint.c (Fcall_interactively): When displaying error message
5762 about invalid control letter, pass the character's codepoint, not
5763 a pointer to its multibyte form. Improve display of the character
5764 in octal and display also its hex code.
5765
5766 * character.c (char_string): Use %x to display the (unsigned)
5767 codepoint of an invalid character, to avoid displaying a bogus
5768 negative value.
5769
5770 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5771 `error', not SYMBOL_NAME itself.
5772
5773 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5774 character arguments to `error'.
5775
5776 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5777 to `error' in error message about FINAL_CHAR argument. Make sure
5778 FINAL_CHAR is a character, and use %c when it is passed as
5779 argument to `error'.
5780
4ffd0d6b 57812011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5782
5783 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5784
5785 * w32.c: Include <time.h>.
5786 (sys_localtime): New function.
5787
4ffd0d6b 57882011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5789
5790 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5791
4ffd0d6b 5792 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5793
4ffd0d6b 57942011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5795
4ffd0d6b
GM
5796 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5797 zombies (Bug#8467).
aac0c6e3 5798
04c56954
EZ
57992011-04-19 Eli Zaretskii <eliz@gnu.org>
5800
5801 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5802 gl_state.e_property when gl_state.object is Qt.
5803
5804 * insdel.c (make_gap_larger): Remove limitation of buffer size
5805 to <= INT_MAX.
5806
16a43933
CY
58072011-04-18 Chong Yidong <cyd@stupidchicken.com>
5808
5809 * xdisp.c (lookup_glyphless_char_display)
5810 (produce_glyphless_glyph): Handle cons cell entry in
5811 glyphless-char-display.
5812 (Vglyphless_char_display): Document it.
5813
5814 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5815 glyphless-char-display.
5816
4581706e
CY
58172011-04-17 Chong Yidong <cyd@stupidchicken.com>
5818
5819 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5820
5821 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5822
5823 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5824 definition for no-X builds.
5825
4887c6e2 58262011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5827
fd35b6f9
PE
5828 Static checks with GCC 4.6.0 and non-default toolkits.
5829
5c1ccb01
PE
5830 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5831
006c5daa
PE
5832 * process.c (keyboard_bit_set): Define only if SIGIO.
5833 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5834 (send_process): Repair possible setjmp clobbering.
5835
efc736d3
PE
5836 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5837
4e2fe2e6
PE
5838 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5839
f97334a2
PE
5840 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5841
4e75f29d
PE
5842 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5843 Define only if needed.
5844
90efadd1
PE
5845 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5846 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5847 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5848
3c647824
PE
5849 * dispextern.h (struct redisplay_interface): Rename param
5850 to avoid shadowing.
e264f262 5851 * termhooks.h (struct terminal): Likewise.
761383f4 5852 * xterm.c (xembed_send_message): Likewise.
3c647824 5853
b58c5c4a
PE
5854 * insdel.c (make_gap_smaller): Define only if
5855 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5856
cad59032
PE
5857 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5858 it.
5859
c339dc2e
PE
5860 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5861 so that we aren't warned about unused symbols.
5862
91a3e27b
PE
5863 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5864
399c71d3 5865 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5866
8ffc96f5
PE
5867 * xfns.c (x_real_positions): Mark locals as initialized.
5868
eef9bc79
PE
5869 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5870
098db9dd
PE
5871 * xterm.c: Fix problems found by static analysis with other toolkits.
5872 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5873 (x_dispatch_event): Declare static if USE_GTK, and
5874 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5875 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5876 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5877 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5878 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5879
eb18f6cc
PE
5880 * xmenu.c (menu_help_callback): Pointer type fixes.
5881 Use const pointers when pointing at readonly data. Avoid pointer
5882 signedness clashes.
5883 (FALSE): Remove unused macro.
5884 (update_frame_menubar): Remove unused decl.
5885
1fe72bf8
PE
5886 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5887
60d9e1db
PE
5888 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5889 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5890 (single_menu_item): Rename local to avoid shadowing.
5891
39261c26
PE
5892 * keyboard.c (make_lispy_event): Remove unused local var.
5893
018c5e19
PE
5894 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5895 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5896
63d2b86e
PE
5897 * bitmaps: Change bitmaps from unsigned char back to the X11
5898 compatible char. Avoid the old compiler warnings about
5899 out-of-range initializers by using, for example, '\xab' rather
5900 than 0xab.
5901
aefd87e1
PE
5902 * xgselect.c (xgselect_initialize): Check vs interface
5903 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5904
bf501fb9
PE
5905 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5906
e9829fdf
PE
5907 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5908 to read-only memory.
5909
1086c095
PE
5910 * fns.c (vector): Remove; this old hack is no longer needed.
5911
2baccd04 5912 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5913 Remove unused var.
dde42981 5914 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5915
72391843 5916 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5917
436c16df 5918 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5919 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5920 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5921
92bb796d 5922 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5923 (x_term_init): Remove local to avoid shadowing.
92bb796d 5924
764430a3 5925 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5926
5927 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5928 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5929
d1dfb56c
EZ
59302011-04-16 Eli Zaretskii <eliz@gnu.org>
5931
c4354cb4
EZ
5932 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5933
d1dfb56c
EZ
5934 Fix regex.c, syntax.c and friends for buffers > 2GB.
5935 * syntax.h (struct gl_state_s): Declare character position members
5936 EMACS_INT.
5937
5938 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5939
04f2d78b
CB
5940 * textprop.c (verify_interval_modification, interval_of):
5941 Declare arguments EMACS_INT.
d1dfb56c
EZ
5942
5943 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5944 EMACS_INT.
5945
5946 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5947
5948 * indent.c (Fvertical_motion): Local variable it_start is now
5949 EMACS_INT.
5950
5951 * regex.c (re_match, re_match_2, re_match_2_internal)
5952 (bcmp_translate, regcomp, regexec, print_double_string)
5953 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5954 (re_compile_pattern, re_exec): Declare arguments and local
5955 variables `size_t' and `ssize_t' and return values `regoff_t', as
5956 appropriate.
5957 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5958 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5959 <compile_stack_type>: `size' and `avail' are now `size_t'.
5960
5961 * regex.h <regoff_t>: Use ssize_t, not int.
5962 (re_search, re_search_2, re_match, re_match_2): Arguments that
5963 specify buffer/string position and length are now ssize_t and
5964 size_t. Return type is regoff_t.
5965
613052cd
BK
59662011-04-16 Ben Key <bkey76@gmail.com>
5967
5968 * nsfont.m: Fixed bugs in ns_get_family and
5969 ns_descriptor_to_entity that were caused by using free to
5970 deallocate memory blocks that were allocated by xmalloc (via
5971 xstrdup). This caused Emacs to crash when compiled with
5972 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5973 --enable-checking=xmallocoverrun). xfree is now used to
5974 deallocate these memory blocks.
5975
4170f62f 59762011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5977
71b41406
PE
5978 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5979
9587a89d
PE
5980 emacs_write: Accept and return EMACS_INT for sizes.
5981 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5982 et seq.
5983 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5984 Accept and return EMACS_INT.
5985 (emacs_gnutls_write): Return the number of bytes written on
5986 partial writes.
5987 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5988 (emacs_read, emacs_write): Remove check for negative size, as the
5989 Emacs source code has been audited now.
9587a89d
PE
5990 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5991 (emacs_read, emacs_write): Use it.
273a5f82
PE
5992 * process.c (send_process): Adjust to the new signatures of
5993 emacs_write and emacs_gnutls_write. Do not attempt to store
5994 a byte offset into an 'int'; it might overflow.
9587a89d 5995 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5996
3e047f51
PE
5997 * sound.c: Don't assume sizes fit in 'int'.
5998 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5999 Return EMACS_INT, not int.
3e047f51 6000 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6001 Accept EMACS_INT, not int.
6002 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6003 record read return values.
6004
cc39a9db
BK
60052011-04-15 Ben Key <bkey76@gmail.com>
6006
c9d0ec6d
JB
6007 * keyboard.c (Qundefined): Don't declare static since it is used
6008 in nsfns.m.
6009 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6010 static since they are used in nsfont.m.
cc39a9db 6011
6c60eb9f
SM
60122011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6013
6014 * process.c (Qprocessp): Don't declare static.
6015 * lisp.h (Qprocessp): Declare again.
6016
7990b61a
JB
60172011-04-15 Juanma Barranquero <lekktu@gmail.com>
6018
6019 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6020
5d4cb038
PE
60212011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6022
8bd7b830 6023 Improve C-level modularity by making more things 'static'.
cd64ea1d 6024
e3b27b31
PE
6025 Don't publish debugger-only interfaces to other modules.
6026 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6027 (verify_bytepos, count_markers): Move decls to the only modules
6028 that need them.
6029 * region-cache.h (pp_cache): Likewise.
6030 * window.h (check_all_windows): Likewise.
6031 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6032
5d4cb038
PE
6033 * sysdep.c (croak): Now static, if
6034 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6035 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6036
6037 * alloc.c (refill_memory_reserve): Now static if
6038 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6039 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6040
e87b6180
PE
6041 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6042 Define only if USE_LUCID.
6043
ac64929e
PE
6044 * xrdb.c (x_customization_string, x_rm_string): Now static.
6045
6f37259d
PE
6046 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6047 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6048
1683e3ab
PE
6049 * xdisp.c (draw_row_with_mouse_face): Now static.
6050 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6051
de9c2632
PE
6052 * window.h (check_all_windows): Mark externally visible.
6053
2b96acb7
PE
6054 * window.c (window_deletion_count): Now static.
6055
6056 * undo.c: Make symbols static if they're not exported.
6057 (last_undo_buffer, last_boundary_position, pending_boundary):
6058 Now static.
6059
50436f33
PE
6060 * textprop.c (interval_insert_behind_hooks): Now static.
6061 (interval_insert_in_front_hooks): Likewise.
6062
64520e5c
PE
6063 * term.c: Make symbols static if they're not exported.
6064 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6065 (max_frame_lines, tty_set_terminal_modes):
6066 (tty_reset_terminal_modes, tty_turn_off_highlight):
6067 (get_tty_terminal): Now static.
6068 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6069 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6070 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6071 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6072 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6073
1fa53021
PE
6074 * sysdep.c: Make symbols static if they're not exported.
6075 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6076 Now static.
6077 (sigprocmask_set, full_mask): Remove; unused.
6078 (wait_debugging): Mark as visible.
6079 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6080 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6081
d4b43b22
PE
6082 * syntax.c (syntax_temp): Define only if !__GNUC__.
6083
b7c513d0
PE
6084 * sound.c (current_sound_device, current_sound): Now static.
6085
989b29ad
PE
6086 * search.c (searchbufs, searchbuf_head): Now static.
6087
13a55a78
PE
6088 * scroll.c (scroll_cost): Remove; unused.
6089 * dispextern.h (scroll_cost): Remove decl.
6090
de68a1fc
PE
6091 * region-cache.h (pp_cache): Mark as externally visible.
6092
40ccffa6
PE
6093 * process.c: Make symbols static if they're not exported.
6094 (process_tick, update_tick, create_process, chan_process):
6095 (Vprocess_alist, proc_buffered_char, datagram_access):
6096 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6097 (deactivate_process): Mark defn as static, as well as decl.
6098 * lisp.h (create_process): Remove decl.
6099 * process.h (chan_process, Vprocess_alist): Remove decls.
6100
ad64fc97
PE
6101 * print.c: Make symbols static if they're not exported.
6102 (print_depth, new_backquote_output, being_printed, print_buffer):
6103 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6104 (print_interval, print_number_index, initial_stderr_stream):
6105 Now static.
6106 * lisp.h (Fprinc): Remove decl.
6107 (debug_output_compilation_hack): Mark as externally visible.
6108
adddb265
PE
6109 * sysdep.c (croak): Move decl from here to syssignal.h.
6110 * syssignal.h (croak): Put it here, so the API can be checked when
6111 'croak' is called from dissociate_if_controlling_tty.
6112
1717ede2
PE
6113 * minibuf.c: Make symbols static if they're not exported.
6114 (minibuf_save_list, choose_minibuf_frame): Now static.
6115 * lisp.h (choose_minibuf_frame): Remove decl.
6116
fa5fb2bc
PE
6117 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6118
1e3890d1
PE
6119 * lread.c: Make symbols static if they're not exported.
6120 (read_objects, initial_obarray, oblookup_last_bucket_number):
6121 Now static.
6122 (make_symbol): Remove; unused.
6123 * lisp.h (initial_obarray, make_symbol): Remove decls.
6124
8a1414fa
PE
6125 * keyboard.c: Make symbols static if they're not exported.
6126 (single_kboard, recent_keys_index, total_keys, recent_keys):
6127 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6128 (this_single_command_key_start, echoing, last_auto_save):
6129 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6130 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6131 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6132 (Vlispy_mouse_stem, double_click_count):
6133 Now static.
6134 (force_auto_save_soon): Define only if SIGDANGER.
6135 (ignore_mouse_drag_p): Now static if
6136 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6137 (print_help): Remove; unused.
6138 (stop_character, last_timer_event): Mark as externally visible.
6139 * keyboard.h (ignore_mouse_drag_p): Declare only if
6140 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6141 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6142 * lisp.h (echoing): Remove decl.
6143 (force_auto_save_soon): Declare only if SIGDANGER.
6144 * xdisp.c (redisplay_window): Simplify code, to make it more
6145 obvious that ignore_mouse_drag_p is not accessed if !defined
6146 USE_GTK && !defined HAVE_NS.
6147
93ea6e8f
PE
6148 * intervals.c: Make symbols static if they're not exported.
6149 (merge_properties_sticky, merge_interval_right, delete_interval):
6150 Now static.
6151 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6152
77382fcc
PE
6153 * insdel.c: Make symbols static if they're not exported.
6154 However, leave prepare_to_modify_buffer alone. It's never
6155 called from outside this function, but that appears to be a bug.
6156 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6157 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6158 (adjust_after_replace_noundo): Remove; unused.
6159 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6160 (signal_before_change): Remove decls.
77382fcc 6161
9306c32e
PE
6162 * indent.c (val_compute_motion, val_vmotion): Now static.
6163
cd44d2eb
PE
6164 * image.c: Make symbols static if they're not exported.
6165 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6166 if USE_GTK.
6167 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6168 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6169
ad9a7a06
PE
6170 * fringe.c (standard_bitmaps): Now static.
6171 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6172
81626931
PE
6173 * frame.c: Make symbols static if they're not exported.
6174 (x_report_frame_params, make_terminal_frame): Now static.
6175 (get_frame_param): Now static, unless HAVE_NS.
6176 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6177 (x_get_resource_string): Remove; not used.
6178 * frame.h (make_terminal_frame, x_report_frame_params):
6179 (x_get_resource_string); Remove decls.
6180 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6181 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6182
239f9db9
PE
6183 * font.c, fontset.c: Make symbols static if they're not exported.
6184 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6185 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6186 * font.c (font_close_object): Now static.
6187 * font.h (font_close_object): Remove.
6188 * fontset.c (FONTSET_OBJLIST): Remove.
6189 (free_realized_fontset) #if-0 the body, which does nothing.
6190 (face_suitable_for_char_p): #if-0, as it's never called.
6191 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6192 * xfaces.c (face_at_string_position):
6193 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6194 since 0 is always ASCII.
6195
dfcf3579
PE
6196 * fns.c (weak_hash_tables): Now static.
6197
5045092b
PE
6198 * fileio.c: Make symbols static if they're not exported.
6199 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6200 (Vwrite_region_annotation_buffers): Now static.
6201
57a96f5c
PE
6202 * eval.c: Make symbols static if they're not exported.
6203 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6204 * lisp.h (backtrace_list): Remove decl.
6205
35f08c38
PE
6206 * emacs.c: Make symbols static if they're not exported.
6207 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6208 (fatal_error_code, fatal_error_signal_hook, standard_args):
6209 Now static.
6210 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6211 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6212 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6213 * lisp.h (fatal_error_signal_hook): Remove decl.
6214 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6215
f44bd759
PE
6216 * editfns.c: Move a (normally-unused) function to its only use.
6217 * editfns.c, lisp.h (get_operating_system_release): Remove.
6218 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6219 worth the hassle of breaking this out.
6220
b532497d
PE
6221 * xterm.c: Make symbols static if they're not exported.
6222 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6223 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6224 (x_destroy_window, x_delete_display):
6225 Now static.
6226 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6227 (x_mouse_leave): Remove; unused.
6228 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6229 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6230 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6231 Remove decls.
6232 (x_mouse_leave): Declare only if WINDOWSNT.
6233 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6234 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6235 USE_X_TOOLKIT.
6236
1675728f
PE
6237 * ftxfont.c: Make symbols static if they're not exported.
6238 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6239 HAVE_FREETYPE.
6240 * font.h (ftxfont_driver): Likewise.
6241
e4cebfca
PE
6242 * xfns.c: Make symbols static if they're not exported.
6243 (x_last_font_name, x_display_info_for_name):
6244 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6245 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6246 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6247 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6248 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6249 (last_show_tip_args): Now static.
6250 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6251 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6252 (x_screen_planes): Remove; unused.
6253 * dispextern.h (x_screen_planes): Remove decl.
6254
5bf46f05
PE
6255 * dispnew.c: Make symbols static if they're not exported.
6256 * dispextern.h (redraw_garbaged_frames, scrolling):
6257 (increment_row_positions): Remove.
6258 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6259 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6260 Now static.
6261 (redraw_garbaged_frames): Remove; unused.
6262
435f4c28
PE
6263 * xfaces.c: Make symbols static if they're not exported.
6264 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6265 Remove decls.
6266 * xterm.h (defined_color): Remove decls.
6267 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6268 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6269 (menu_face_changed_default, defined_color, free_realized_face):
6270 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6271 (ascii_face_of_lisp_face): Remove; unused.
6272
8524aef3
PE
6273 * xdisp.c: Make symbols static if they're not exported.
6274 * dispextern.h (scratch_glyph_row, window_box_edges):
6275 (glyph_to_pixel_coords, set_cursor_from_row):
6276 (get_next_display_element, set_iterator_to_next):
6277 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6278 (show_mouse_face): Remove decls
6279 * frame.h (message_buf_print): Likewise.
6280 * lisp.h (pop_message, set_message, check_point_in_composition):
6281 Likewise.
6282 * xterm.h (set_vertical_scroll_bar): Likewise.
6283 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6284 (message_buf_print, scratch_glyph_row, displayed_buffer):
6285 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6286 (get_next_display_element, show_mouse_face, window_box_edges):
6287 (frame_to_window_pixel_xy, check_point_in_composition):
6288 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6289 (glyph_to_pixel_coords): Remove; unused.
6290
16390cd2
PE
6291 * dired.c (file_name_completion): Now static.
6292
6293 * dbusbind.c (xd_in_read_queued_messages): Now static.
6294
a25f4dfa
PE
6295 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6296 * data.c (circular_list_error): Remove.
6297
14a9c8df
PE
6298 * commands.h (last_point_position, last_point_position_buffer):
6299 (last_point_position_window): Remove decls.
6300 * keyboard.c: Make these variables static.
6301
04f2d78b
CB
6302 * coding.h (coding, code_convert_region, encode_coding_gap):
6303 Remove decls.
74ab6df5
PE
6304 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6305 (iso_code_class, detect_coding, code_convert_region): Now static.
6306 (encode_coding_gap): Remove; unused.
6307
38dfbee1
PE
6308 * chartab.c (chartab_chars, chartab_bits): Now static.
6309
a2cb4e63
PE
6310 * charset.h (charset_iso_8859_1): Remove decl.
6311 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6312 Now static.
6313
127198fd
PE
6314 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6315 * ccl.c (Vccl_program_table): Now static.
6316 (check_ccl_update): Remove; unused.
6317
d85b608f
PE
6318 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6319 * category.h: ... from here.
6320 * category.c (check_category_table, set_category_set): Now static.
6321
31cd66f3
PE
6322 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6323 * lisp.h: Remove these decls.
6324
c358e587
PE
6325 * buffer.c (buffer_count): Remove unused var.
6326
e78aecca
PE
6327 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6328 so that it's not optimized away.
6329 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6330 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6331 exported only to the debugger.
6332
e192d7d3 6333 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6334 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6335
92470028
PE
6336 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6337 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6338 was inaccessible from Lisp.
6339 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6340 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6341
244ed907
PE
6342 alloc.c: Import and export fewer symbols, and remove unused items.
6343 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6344 is defined.
6345 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6346 it's not optimized away by whole-program optimization.
6347 (message_enable_multibyte, free_misc): Remove.
6348 (catchlist, handlerlist, mark_backtrace):
6349 Declare only if BYTE_MARK_STACK.
6350 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6351 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6352 (message_enable_multibyte): Remove decl.
6353 (free_misc, interval_free_list, float_block, float_block_index):
6354 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6355 (cons_free_list, last_marked_index):
6356 Now static.
6357 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6358 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6359 (mark_backtrace): Define only if BYTE_MARK_STACK.
6360 * xdisp.c (message_enable_multibyte): Now static.
6361
61c2b50e 6362 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6363 This makes it easier for human readers (and static analyzers)
6364 to see whether these variables are used from other modules.
6365 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6366 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6367 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6368 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6369 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6370 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6371 * xmenu.c, xselect.c:
6372 Declare Q* vars static if they are not used in other modules.
6373 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6374 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6375 Remove decls of unexported vars.
6376 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6377
95c82688
PE
6378 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6379
16a97296
PE
6380 Make Emacs functions such as Fatom 'static' by default.
6381 This makes it easier for human readers (and static analyzers)
6382 to see whether these functions can be called from other modules.
6383 DEFUN now defines a static function. To make the function external
6384 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6385 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6386 (Finit_image_library):
16a97296
PE
6387 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6388 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6389 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6390 Remove decls, since these functions are now static.
6391 (Funintern, Fget_internal_run_time): New decls, since these functions
6392 were already external.
95c82688 6393
16a97296
PE
6394 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6395 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6396 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6397 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6398 * keyboard.c, keymap.c, lread.c:
6399 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6400 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6401 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6402 Mark functions with DEFUE instead of DEFUN,
6403 if they are used in other modules.
6404 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6405 decls for now-static functions.
6406 * buffer.h (Fdelete_overlay): Remove decl.
6407 * callproc.c (Fgetenv_internal): Mark as internal.
6408 * composite.c (Fremove_list_of_text_properties): Remove decl.
6409 (Fcomposition_get_gstring): New forward static decl.
6410 * composite.h (Fcomposite_get_gstring): Remove decl.
6411 * dired.c (Ffile_attributes): New forward static decl.
6412 * doc.c (Fdocumntation_property): New forward static decl.
6413 * eval.c (Ffetch_bytecode): New forward static decl.
6414 (Funintern): Remove extern decl; now in .h file where it belongs.
6415 * fileio.c (Fmake_symbolic_link): New forward static decl.
6416 * image.c (Finit_image_library): New forward static decl.
6417 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6418 * intervals.h (Fprevious_property_change):
6419 (Fremove_list_of_text_properties): Remove decls.
6420 * keyboard.c (Fthis_command_keys): Remove decl.
6421 (Fcommand_execute): New forward static decl.
6422 * keymap.c (Flookup_key): New forward static decl.
6423 (Fcopy_keymap): Now static.
6424 * keymap.h (Flookup_key): Remove decl.
6425 * process.c (Fget_process): New forward static decl.
6426 (Fprocess_datagram_address): Mark as internal.
6427 * syntax.c (Fsyntax_table_p): New forward static decl.
6428 (skip_chars): Remove duplicate decl.
6429 * textprop.c (Fprevious_property_change): New forward static decl.
6430 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6431 Now internal.
6432 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6433 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6434
785bbd42
PE
6435 * editfns.c (Fformat): Remove unreachable code.
6436
8b913b57
AS
64372011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6438
6439 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6440 change. (Bug#8496)
6441
a6744a35
EZ
64422011-04-13 Eli Zaretskii <eliz@gnu.org>
6443
6444 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6445 when at ZV. (Bug#8487)
6446
e7974947
AS
64472011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6448
baad03f0
AS
6449 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6450 (Bug#8437)
6451 * keyboard.c (parse_tool_bar_item): Likewise.
6452 * sound.c (sound_cleanup, alsa_close): Likewise.
6453 * termcap.c (tgetent): Likewise.
6454 * xfns.c (x_default_font_parameter): Likewise.
6455 * xsettings.c (read_and_apply_settings): Likewise.
6456
e7974947
AS
6457 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6458 (overrun_check_free): Protoize.
6459
28272684
PE
64602011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6461
6462 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6463 since callers should never pass a negative size.
6464 Change the signature to match that of plain 'read' and 'write'; see
6465 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6466 * lisp.h: Update prototypes of emacs_write and emacs_read.
6467
11997c76
EZ
64682011-04-11 Eli Zaretskii <eliz@gnu.org>
6469
6470 * xdisp.c (redisplay_window): Don't try to determine the character
6471 position of the scroll margin if the window start point w->startp
e896f03c 6472 is outside the buffer's accessible region. (Bug#8468)
11997c76 6473
8a2cbd72
EZ
64742011-04-10 Eli Zaretskii <eliz@gnu.org>
6475
6476 Fix write-region and its subroutines for buffers > 2GB.
6477 * fileio.c (a_write, e_write): Modify declaration of arguments and
6478 local variables to support buffers larger than 2GB.
6479 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6480
6481 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6482 argument, local variables, and return value.
6483
6484 * lisp.h: Update prototypes of emacs_write and emacs_read.
6485
6486 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6487
4073e537 64882011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6489
1ebfdcb6
PE
6490 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6491
b2ded58d
PE
6492 Fix more problems found by GCC 4.6.0's static checks.
6493
7d66342c
PE
6494 * xdisp.c (vmessage): Use a better test for character truncation.
6495
bbf47d44
PE
6496 * charset.c (load_charset_map): <, not <=, for optimization,
6497 and to avoid potential problems with integer overflow.
9248994d 6498 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6499 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6500 * editfns.c (Fformat): Likewise.
1e69125e 6501 * syntax.c (skip_chars): Likewise.
3befa583 6502
e3019616
PE
6503 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6504 This also lets GCC 4.6.0 generate slightly better loop code.
6505
becfa255
PE
6506 * callint.c (Fcall_interactively): <, not <=, for optimization.
6507 (Fcall_interactively): Count the number of arguments produced,
6508 not the number of arguments given. This is simpler and lets GCC
6509 4.6.0 generate slightly better code.
6510
dae0cd48
PE
6511 * ftfont.c: Distingish more carefully between FcChar8 and char.
6512 The previous code passed unsigned char * to a functions like
6513 strlen and xstrcasecmp that expect char *, which does not
6514 conform to the C standard.
6515 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6516 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6517 char * when the C standard requires it.
6518
76032d70
PE
6519 * keyboard.c (read_char): Remove unused var.
6520
eb3f1cc8
PE
6521 * eval.c: Port to Windows vsnprintf (Bug#8435).
6522 Include <limits.h>.
6523 (SIZE_MAX): Define if the headers do not.
6524 (verror): Do not give up if vsnprintf returns a negative count.
6525 Instead, grow the buffer. This ports to Windows vsnprintf, which
6526 does not conform to C99. Problem reported by Eli Zaretskii.
6527 Also, simplify the allocation scheme, by avoiding the need for
6528 calling realloc, and removing the ALLOCATED variable.
6529
70476b54
PE
6530 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6531
12020a9e
PE
6532 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6533 But keep the doprint source code for now, as we might revamp it
6534 and use it again (Bug#8435).
ea6c7ae6
PE
6535 * lisp.h (doprnt): Remove.
6536 * Makefile.in (base_obj): Remove doprnt.o.
6537 * deps.mk (doprnt.o): Remove.
6538
5fdb398c
PE
6539 error: Print 32- and 64-bit integers portably (Bug#8435).
6540 Without this change, on typical 64-bit hosts error ("...%d...", N)
6541 was used to print both 32- and 64-bit integers N, which relied on
6542 undefined behavior.
6543 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6544 New macro.
6545 * lisp.h (error, verror): Mark as printf-like functions.
6546 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6547 Report overflow in size calculations when allocating printf buffer.
6548 Do not truncate output string at its first null byte.
6549 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6550 Truncate the output at a character boundary, since vsnprintf does not
6551 do that.
6552 * charset.c (check_iso_charset_parameter): Convert internal
6553 character to string before calling 'error', since %c now has the
6554 printf meaning.
6555 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6556 overflow when computing char to be passed to 'error'. Do not
6557 pass Lisp_Object to 'error'; pass the integer instead.
6558 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6559 formatted with plain %d.
6560
b189fa66
PE
6561 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6562
bff87ef0
PE
6563 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6564
7e2cac20
PE
6565 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6566
ce4d90b5
PE
6567 * xterm.c (x_catch_errors): Remove duplicate declaration.
6568
266c9547
PE
6569 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6570
79c49ad2
PE
6571 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6572
368f4090
JM
65732011-04-10 Jim Meyering <meyering@redhat.com>
6574
6575 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6576 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6577 return ssize_t not "int", and use size_t as the buffer length.
6578 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6579 * gnutls.h: Update declarations.
6580 * process.c (read_process_output): Use ssize_t, to match.
6581 (send_process): Likewise.
6582
a32d4040
CY
65832011-04-09 Chong Yidong <cyd@stupidchicken.com>
6584
6585 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6586
8546720e 65872011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6588
04f2d78b
CB
6589 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6590 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6591
8546720e
GM
6592 * xterm.c (handle_one_xevent):
6593 * xmenu.c (create_and_show_popup_menu):
6594 * xselect.c (x_decline_selection_request)
6595 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6596
0a2f5c1a 65972011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6598
6599 Fix some uses of `int' instead of EMACS_INT.
6600 * search.c (string_match_1, fast_string_match)
6601 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6602 (scan_buffer, find_next_newline_no_quit)
6603 (find_before_next_newline, search_command, Freplace_match)
6604 (Fmatch_data): Make some `int' variables be EMACS_INT.
6605
6606 * xdisp.c (display_count_lines): 3rd argument and return value now
6607 EMACS_INT. All callers changed.
6608 (pint2hrstr): Last argument is now EMACS_INT.
6609
6610 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6611 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6612 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6613 (decode_coding_utf_16, decode_coding_emacs_mule)
6614 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6615 (decode_coding_ccl, decode_coding_charset)
6616 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6617 (decode_coding_iso_2022, decode_coding_emacs_mule)
6618 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6619 <char_offset, last_offset>: Declare EMACS_INT.
6620 (encode_coding_utf_8, encode_coding_utf_16)
6621 (encode_coding_emacs_mule, encode_invocation_designation)
6622 (encode_designation_at_bol, encode_coding_iso_2022)
6623 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6624 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6625 Declare EMACS_INT.
6626 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6627 (encode_invocation_designation): Last argument P_NCHARS is now
6628 EMACS_INT.
6629 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6630 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6631
6632 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6633 All users changed.
6634
6635 * ccl.c (Fccl_execute_on_string): Declare some variables
6636 EMACS_INT.
6637
8546720e 66382011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6639
6640 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6641
4e19a977
CS
66422011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6643
6644 * process.c (Fformat_network_address): Doc fix.
6645
87302331
R
66462011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6647
6648 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6649
cbb59342
CY
66502011-04-08 Chong Yidong <cyd@stupidchicken.com>
6651
6652 * keyboard.c (read_char): Call Lisp function help-form-show,
6653 instead of using internal_with_output_to_temp_buffer.
6654 (Qhelp_form_show): New var.
e0d38eeb 6655 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6656
6657 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6658
6659 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6660
e67a13ab
CY
66612011-04-06 Chong Yidong <cyd@stupidchicken.com>
6662
04f2d78b
CB
6663 * process.c (Flist_processes): Remove to Lisp.
6664 (list_processes_1): Delete.
e67a13ab 6665
973f782d
EZ
66662011-04-06 Eli Zaretskii <eliz@gnu.org>
6667
7c106b1e
EZ
6668 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6669
973f782d
EZ
6670 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6671
41cf7d1a 66722011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6673
ca23cc88
PE
6674 Fix more problems found by GCC 4.6.0's static checks.
6675
f390e2d5
PE
6676 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6677
42eea0d0
PE
6678 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6679
b69769da 6680 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6681
f9541e84
PE
6682 * xdisp.c (vmessage): Mark as a printf-like function.
6683
13841b55
PE
6684 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6685
c136c10f
PE
6686 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6687
5e2d4a30
PE
6688 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6689 printf-like functions.
6690 (tiff_load): Add casts to remove these marks before passing them
6691 to system-supplied API.
6692
583f48b9
PE
6693 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6694
b25d760e
PE
6695 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6696 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6697 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6698 directly, rather than having caller test rule sign. This avoids
6699 some unnecessary tests.
6700 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6701 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6702 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6703
bc7b6697 6704 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6705 (xfont_open): Avoid unnecessary tests.
bc7b6697 6706
27ccc379
PE
6707 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6708
dcd5c89a
PE
6709 * composite.h, composite.c (composition_gstring_put_cache):
6710 Use EMACS_INT, not int, for length.
6711
b13a45c6
PE
6712 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6713 breaking out part of COMPOSITION_DECODE_RULE.
6714 (COMPOSITION_DECODE_RULE): Use it.
6715 * composite.c (get_composition_id): Remove unused local vars,
6716 by using the new macro.
6717
1e792e4d
PE
6718 * textprop.c (set_text_properties_1): Change while to do-while,
6719 since the condition is always true at first.
6720
dc6c6455 6721 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6722 (interval_deletion_adjustment): Return unsigned value.
6723 All uses changed.
dc6c6455 6724
aba7731a
PE
6725 * process.c (list_processes_1, create_pty, read_process_output):
6726 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6727 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6728 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6729 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6730 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6731
fdfc4bf3
PE
6732 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6733
fca8fe46 6734 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6735 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6736
06a0259a 6737 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6738 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6739 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6740
e7b9e80f
PE
6741 * print.c (print_error_message): Avoid int overflow.
6742
56201685
PE
6743 * font.c (font_list_entities): Redo for clarity,
6744 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6745
78834453 6746 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6747 (font_score): Avoid potential overflow in diff calculation.
78834453 6748
0bc0b309 6749 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6750 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6751
e610eaca
PE
6752 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6753
b895abce
PE
6754 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6755 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6756 can always succeed if overflow has undefined behavior.
6757
1f1d9321 6758 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6759 (wordify): Omit three unnecessary tests.
1f1d9321 6760
c59478bc
PE
6761 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6762 All callers changed. This avoids the need for an unused var.
6763
79b73827
PE
6764 * casefiddle.c (casify_region): Remove var that is set but not used.
6765
a4db5dfe
PE
6766 * dired.c (file_name_completion): Remove var that is set but not used.
6767
43aae36e
PE
6768 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6769
2a47c44d 6770 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6771 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6772
a37c69bf
PE
6773 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6774 Check for integer overflow on size calculations.
6775
328ab8e7
PE
6776 * buffer.c (Fprevious_overlay_change): Remove var that is set
6777 but not used.
6778
e5a2a5cb
PE
6779 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6780 Remove vars that are set but not used.
8d84a6eb 6781 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6782 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6783
a60e5f68
PE
6784 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6785
f661cb61 6786 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6787 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6788
f0397f5a
PE
6789 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6790 that are set but not used.
6791
8664db06 6792 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6793 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6794
6abdaa4a
PE
6795 * xselect.c (x_get_local_selection, x_handle_property_notify):
6796 Remove vars that are set but not used.
6797
0ce7538d 6798 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6799 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6800
9ae848fc
PE
6801 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6802 Remove var that is set but not used.
0b918413
PE
6803 (scroll_bar_windows_size): Now size_t, not int.
6804 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6805 Check for overflow.
9ae848fc 6806
a5a62657
PE
6807 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6808 (map_tty_color) [!defined MSDOS]: Likewise.
6809
5c5cdd39
PE
6810 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6811
66ebf983
PE
6812 * coding.c: Remove vars that are set but not used.
6813 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6814 All callers changed.
6815 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6816 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6817 (decode_coding_charset): Remove vars that are set but not used.
6818
1be4d761
PE
6819 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6820 that is set but not used.
6821
47553fa8
PE
6822 * print.c (print_object): Remove var that is set but not used.
6823
1f7196bf 6824 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6825 The gnulib version avoids calling malloc in the usual case,
6826 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6827 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6828 * filelock.c (current_lock_owner): Likewise.
6829 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6830 * sysdep.c: Include allocator.h, careadlinkat.h.
6831 (emacs_no_realloc_allocator): New static constant.
6832 (emacs_readlink): New function.
fdb61804
PE
6833 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6834 ../lib/careadlinkat.h.
d1fdcab7 6835
f84c17c7
SM
68362011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6837
6838 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6839 first non-nil return value).
6840
ef3862ad
JD
68412011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6842
6843 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6844 if not defined (Bug#8403).
6845
376a7006
JB
68462011-04-02 Juanma Barranquero <lekktu@gmail.com>
6847
6848 * xdisp.c (display_count_lines): Remove parameter `start',
6849 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6850 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6851 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6852 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6853 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6854 and thereabouts. All callers changed.
6855 (get_per_char_metric): Remove parameter `f', unused since
6856 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6857
6ca3801d
JM
68582011-04-02 Jim Meyering <meyering@redhat.com>
6859
6860 do not dereference NULL upon failed strdup
6861 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6862 (ns_get_family): Likewise.
6863
d8e2b5ba
JB
68642011-04-02 Juanma Barranquero <lekktu@gmail.com>
6865
6866 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6867
8c74fcbd
JD
68682011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6869
6870 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6871 later (Bug#8403).
6872
7200d79c
SM
68732011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6874
03408648 6875 Add lexical binding.
7200d79c 6876
03408648
SM
6877 * window.c (Ftemp_output_buffer_show): New fun.
6878 (Fsave_window_excursion):
6879 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6880
6881 * lread.c (lisp_file_lexically_bound_p): New function.
6882 (Fload): Bind Qlexical_binding.
6883 (readevalloop): Remove `evalfun' arg.
6884 Bind Qinternal_interpreter_environment.
6885 (Feval_buffer): Bind Qlexical_binding.
6886 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6887 Mark as dynamic.
6888 (syms_of_lread): Declare `lexical-binding'.
6889
6890 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6891
6892 * keyboard.c (eval_dyn): New fun.
6893 (menu_item_eval_property): Use it.
ca105506
SM
6894
6895 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6896
03408648
SM
6897 * fns.c (concat, mapcar1): Accept byte-code-functions.
6898
6899 * eval.c (Fsetq): Handle lexical vars.
6900 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6901 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6902 (FletX, Flet): Obey lexical binding.
6903 (Fcommandp): Handle closures.
6904 (Feval): New `lexical' arg.
6905 (eval_sub): New function extracted from Feval. Use it almost
6906 everywhere where Feval was used. Look up vars in lexical env.
6907 Handle closures.
6908 (Ffunctionp): Move from subr.el.
6909 (Ffuncall): Handle closures.
6910 (apply_lambda): Remove `eval_flags'.
6911 (funcall_lambda): Handle closures and new byte-code-functions.
6912 (Fspecial_variable_p): New function.
6913 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6914 but without exporting it to Lisp.
23aba0ea 6915
23aba0ea 6916 * doc.c (Fdocumentation, store_function_docstring):
03408648 6917 * data.c (Finteractive_form): Handle closures.
23aba0ea 6918
03408648
SM
6919 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6920 interactive spec.
ba83908c 6921
04f2d78b
CB
6922 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6923 New byte-codes.
03408648
SM
6924 (exec_byte_code): New function extracted from Fbyte_code to handle new
6925 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6926
03408648 6927 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6928
03408648 6929 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6930
e2abce01
JB
69312011-03-31 Juanma Barranquero <lekktu@gmail.com>
6932
6933 * xdisp.c (redisplay_internal): Fix prototype.
6934
63696a73 69352011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6936
63696a73 6937 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6938 (try_scrolling): Use it when setting scroll_limit.
6939 Limit scrolling to 100 screen lines.
63696a73
EZ
6940 (redisplay_window): Even when falling back on "recentering",
6941 position point in the window according to scroll-conservatively,
6942 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6943
6944 (try_scrolling): When point is above the window, allow searching
6945 as far as scroll_max, or one screenful, to compute vertical
6946 distance from PT to the scroll margin position. This prevents
6947 try_scrolling from unnecessarily failing when
6948 scroll-conservatively is set to a value slightly larger than the
6949 window height. Clean up the case of PT below the margin at bottom
6950 of window: scroll_max can no longer be INT_MAX. When aggressive
6951 scrolling is in use, don't let point enter the opposite scroll
6952 margin as result of the scroll.
6953 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6954 threshold of 100 lines for never-recentering scrolling.
6955
e4cc2dfc
JB
69562011-03-31 Juanma Barranquero <lekktu@gmail.com>
6957
6958 * dispextern.h (move_it_by_lines):
6959 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6960 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6961 (message_log_check_duplicate): Remove parameters `prev_bol' and
6962 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6963 (redisplay_internal): Remove parameter `preserve_echo_area',
6964 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6965
6966 * indent.c (Fvertical_motion):
6967 * window.c (window_scroll_pixel_based, Frecenter):
6968 Don't pass `need_y_p' to `move_it_by_lines'.
6969
1c470562
SM
69702011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6971
44f230aa
SM
6972 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6973 steal a few bits to be more compact.
6974 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6975 Remove unneeded casts.
6976
1c470562
SM
6977 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6978
888adce9
ZK
69792011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6980
6981 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6982 binding" message (bug#7967).
6983
f838ed7b
PE
69842011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6985
77861b95
PE
6986 Fix more problems found by GCC 4.6.0's static checks.
6987
de6dbc14
PE
6988 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6989 Remove unused local var.
6990
f838ed7b
PE
6991 * editfns.c (Fmessage_box): Remove unused local var.
6992
792c7b2b
PE
6993 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6994 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6995 Omit unused local vars.
c499e557 6996 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6997 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6998 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6999 Omit unused local var.
7000
ba0165e1
PE
7001 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7002 Don't assume string length fits in int.
32ad8845 7003 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7004 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7005
3c59b4c9
PE
7006 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7007 instead of alloca (Bug#8344).
7008
a3eed478 7009 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7010 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7011
eb4d412d
PE
7012 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7013
1658b401
PE
7014 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7015 concerns.
7016
7017 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7018
7019 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7020
9a2c6e05
PE
7021 * keyboard.c (syms_of_keyboard): Use the same style as later
7022 in this function when indexing through an array. This also
7023 works around GCC bug 48267.
7024
03d0a109
PE
7025 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7026
44f730c8
PE
7027 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7028
fe75f926
PE
7029 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7030 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7031
ffa8c828
PE
7032 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7033 This avoids undefined behavior on integer overflow, and is a bit
7034 more convenient anyway since it is compared to a size_t variable.
7035
c5101a77
PE
7036 Variadic C functions now count arguments with size_t, not int.
7037 This avoids an unnecessary limitation on 64-bit machines, which
7038 caused (substring ...) to crash on large vectors (Bug#8344).
7039 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7040 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7041 All variadic functions and their callers changed accordingly.
c5101a77
PE
7042 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7043 * data.c (arith_driver, float_arith_driver): Likewise.
7044 * editfns.c (general_insert_function): Likewise.
7045 * eval.c (struct backtrace.nargs, interactive_p)
7046 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7047 (funcall_lambda, mark_backtrace): Likewise.
7048 * fns.c (concat): Likewise.
7049 * frame.c (x_set_frame_parameters): Likewise.
7050 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7051 0 if not found, not -1. All callers changed.
7052
dd3f25f7
PE
7053 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7054 (stack_copy_size): Now size_t, not int.
7055 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7056
461c2ab9
JB
70572011-03-28 Juanma Barranquero <lekktu@gmail.com>
7058
7059 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7060 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7061 All callers changed.
7062
7063 * lisp.h (multibyte_char_to_unibyte):
7064 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7065 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7066 * character.h (CHAR_TO_BYTE8):
7067 * cmds.c (internal_self_insert):
7068 * editfns.c (general_insert_function):
7069 * keymap.c (push_key_description):
7070 * search.c (Freplace_match):
7071 * xdisp.c (message_dolog, set_message_1): All callers changed.
7072
f6d62986
SM
70732011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7074
7075 * keyboard.c (safe_run_hook_funcall): New function.
7076 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7077 don't set the hook to nil, but remove the offending function instead.
7078 (Qcommand_hook_internal): Remove, unused.
7079 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7080 Vcommand_hook_internal.
7081
7082 * eval.c (enum run_hooks_condition): Remove.
7083 (funcall_nil, funcall_not): New functions.
7084 (run_hook_with_args): Call each function through a `funcall' argument.
7085 Remove `cond' argument, now redundant.
7086 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7087 (Frun_hook_with_args_until_failure): Adjust accordingly.
7088 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7089
1db5b1ad
JB
70902011-03-28 Juanma Barranquero <lekktu@gmail.com>
7091
7092 * dispextern.h (string_buffer_position): Remove declaration.
7093
7094 * print.c (strout): Remove parameter `multibyte', unused since
7095 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7096
7097 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7098 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7099 All callers changed.
7100
7101 * w32.c (_wsa_errlist): Use braces for struct initializers.
7102
7103 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7104 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7105 All callers changed.
7106 (string_buffer_position): Likewise. Also, make static (it's never
7107 used outside xdisp.c).
7108 (cursor_row_p): Remove parameter `w', unused since
7109 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7110 (decode_mode_spec): Remove parameter `precision', introduced during
7111 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7112 All callers changed.
7113
5ffb62aa
JD
71142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7115
7116 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7117
461c2ab9 71182011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7119
7120 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7121 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7122 (ns_update_auto_hide_menu_bar): New functions.
7123 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7124 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7125 ns_constrain_all_frames.
7126 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7127 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7128
5c380ffb
JD
71292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7130
7131 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7132
9af30bdf
GM
71332011-03-27 Glenn Morris <rgm@gnu.org>
7134
7135 * syssignal.h: Replace RETSIGTYPE with void.
7136 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7137 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7138 Replace SIGTYPE with void everywhere.
7139 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7140 * s/template.h (SIGTYPE): Remove commented out definition.
7141
e2abce01
JB
71422011-03-26 Eli Zaretskii <eliz@gnu.org>
7143
7144 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7145 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7146
f868cd8a
JB
71472011-03-26 Juanma Barranquero <lekktu@gmail.com>
7148
59eb0929
JB
7149 * w32.c (read_unc_volume): Use parameter `henum', instead of
7150 global variable `wget_enum_handle'.
7151
7152 * keymap.c (describe_vector): Remove parameters `indices' and
7153 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7154 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7155
f868cd8a
JB
7156 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7157
7158 * keyboard.c (timer_check): Remove parameter `do_it_now',
7159 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7160 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7161 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7162
7163 * keyboard.c (read_char):
7164 * w32menu.c (w32_menu_display_help):
7165 * xmenu.c (show_help_event, menu_help_callback):
7166 Adjust calls to `show_help_echo'.
7167
7168 * gtkutil.c (xg_maybe_add_timer):
7169 * keyboard.c (readable_events):
7170 * process.c (wait_reading_process_output):
7171 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7172
7173 * insdel.c (adjust_markers_gap_motion):
7174 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7175 (gap_left, gap_right): Don't call it.
7176
2ecf6fdb
CY
71772011-03-25 Chong Yidong <cyd@stupidchicken.com>
7178
7179 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7180 incurred during fontification.
7181
6b1f9ba4
JB
71822011-03-25 Juanma Barranquero <lekktu@gmail.com>
7183
7184 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7185 (DEFVAR_PER_BUFFER): Don't pass it.
7186
7187 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7188 (scrolling_window): Don't pass it.
7189
0f4a96b5
JB
71902011-03-25 Juanma Barranquero <lekktu@gmail.com>
7191
7192 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7193
7194 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7195 and `suffix'.
7196 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7197 of variables specific to SELinux and computation of `encoded_absname'.
7198
7199 * image.c (XPutPixel): Remove unused variable `height'.
7200
7201 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7202
7203 * unexw32.c (get_section_info): Remove unused variable `section'.
7204
7205 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7206 (system_process_attributes): Remove unused variable `sess'.
7207 (sys_read): Remove unused variable `err'.
7208
7209 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7210 (w32_wnd_proc): Remove unused variable `isdead'.
7211 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7212 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7213 (x_create_tip_frame): Remove unused variable `tem'.
7214
7215 * w32inevt.c (w32_console_read_socket):
7216 Remove unused variable `no_events'.
7217
7218 * w32term.c (x_draw_composite_glyph_string_foreground):
7219 Remove unused variable `width'.
7220
1149507c
JB
72212011-03-24 Juanma Barranquero <lekktu@gmail.com>
7222
7223 * w32term.c (x_set_glyph_string_clipping):
7224 Don't pass uninitialized region to CombineRgn.
7225
9c88f339
JB
72262011-03-23 Juanma Barranquero <lekktu@gmail.com>
7227
7228 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7229 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7230 (Fx_close_connection): Remove unused variable `i'.
7231
7232 * w32font.c (w32font_draw): Return number of glyphs.
7233 (w32font_open_internal): Remove unused variable `i'.
7234 (w32font_driver): Add missing initializer.
7235
7236 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7237 (fill_in_menu): Remove unused variable `items_added'.
7238
7239 * w32term.c (last_mouse_press_frame): Remove static global variable.
7240 (w32_clip_to_row): Remove unused variable `f'.
7241 (x_delete_terminal): Remove unused variable `i'.
7242
7243 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7244 (NOTHING): Remove unused static global variable.
7245 (uniscribe_check_otf): Remove unused variable `table'.
7246 (uniscribe_font_driver): Add missing initializers.
7247
dee091a3
JD
72482011-03-23 Julien Danjou <julien@danjou.info>
7249
7250 * term.c (Fsuspend_tty, Fresume_tty):
7251 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7252 * window.c (temp_output_buffer_show):
7253 * insdel.c (signal_before_change):
7254 * frame.c (Fhandle_switch_frame):
7255 * fileio.c (Fdo_auto_save):
7256 * emacs.c (Fkill_emacs):
7257 * editfns.c (save_excursion_restore):
7258 * cmds.c (internal_self_insert):
7259 * callint.c (Fcall_interactively):
7260 * buffer.c (Fkill_all_local_variables):
7261 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7262 Use Frun_hooks.
0f4a96b5 7263 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7264 unconditionnaly since it does the check itself.
7265
2c520ab5 72662011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7267
c9c49752
PE
7268 Fix more problems found by GCC 4.5.2's static checks.
7269
8abc3f12
PE
7270 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7271 the first time through the loop, since we know p0 < p1 then.
7272 This also avoids a gcc -Wstrict-overflow warning.
7273
a2d26660
PE
7274 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7275 leading to a memory leak, possible in functions like
7276 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7277 of objects (Bug#8318).
a2d26660 7278
916c72e9
PE
7279 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7280 that could (at least in theory) be that large.
7281
19ab8a18
PE
7282 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7283 This is less likely to overflow, and avoids undefined behavior if
7284 overflow does occur. All callers changed. Use strtoul to scan
7285 for the unsigned long integer.
b7cbbd6f
PE
7286 (pint2hrstr): Simplify and tune code slightly.
7287 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7288
f0641eff
PE
7289 * scroll.c (do_scrolling): Work around GCC bug 48228.
7290 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7291
7f650bb9
PE
7292 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7293 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7294 (validate_x_resource_name): Simplify count usage.
7295 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7296
37dd57d1
PE
7297 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7298 fail (Bug#8306).
81e56e61 7299
699979fc 7300 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7301
401bf9b4
PE
7302 * process.c (Fmake_network_process): Use socklen_t, not int,
7303 where POSIX says socklen_t is required in portable programs.
7304 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7305 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7306 (Fmake_network_process, server_accept_connection):
7307 (wait_reading_process_output, read_process_output):
7308 Likewise.
7309
b93aacde
PE
7310 * process.c: Rename or move locals to avoid shadowing.
7311 (list_processes_1, Fmake_network_process):
7312 (read_process_output_error_handler, exec_sentinel_error_handler):
7313 Rename or move locals.
4dc343ee 7314 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7315 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7316 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7317 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7318 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7319
af8a867c 7320 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7321 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7322 Include tparam.h instead, since it declares them.
af8a867c
PE
7323 * cm.h (PC): Remove extern decl; tparam.h now does this.
7324 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7325 * terminfo.c: Include tparam.h, to check interfaces.
7326 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7327 (tparam): Adjust signature to match interface in tparam.h;
7328 this removes some undefined behavior. Check that outstring and len
7329 are zero, which they always are with Emacs.
7330 * tparam.h (PC, BC, UP): New extern decls.
7331
0248044d 7332 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7333 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7334
8ff096c1 7335 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7336 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7337 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7338 (ftfont_list): Remove unused local.
49eaafba
PE
7339 (get_adstyle_property, ftfont_pattern_entity):
7340 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7341 Rename locals to avoid shadowing.
8ff096c1 7342
e2be39f6
PE
7343 * xfont.c (xfont_list_family): Mark var as initialized.
7344
c9735e30
PE
7345 * xml.c (make_dom): Now static.
7346
8f5201ae
PE
7347 * composite.c (composition_compute_stop_pos): Rename local to
7348 avoid shadowing.
b246f932
PE
7349 (composition_reseat_it): Remove unused locals.
7350 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7351 (composition_update_it): Mark var as initialized.
11b61122
PE
7352 (find_automatic_composition): Mark vars as initialized,
7353 with a FIXME (Bug#8290).
8f5201ae 7354
760fbc2c
PE
7355 character.h: Rename locals to avoid shadowing.
7356 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7357 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7358 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7359 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7360 to avoid shadowing.
7361
ff08eb85
PE
7362 * textprop.c (property_change_between_p): Remove; unused.
7363
fc7bf025
PE
7364 * intervals.c (interval_start_pos): Now static.
7365
235d7abc
PE
7366 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7367
44f230aa
SM
7368 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7369 Rename locals to avoid shadowing.
3e7d6594 7370
50060332
PE
7371 * sound.c (wav_play, au_play, Fplay_sound_internal):
7372 Fix pointer signedness.
d01f234b 7373 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7374 (wav_play): Initialize a variable to 0, to prevent undefined
7375 behavior (Bug#8278).
50060332 7376
c4fc4e30
PE
7377 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7378
918436ed
PE
7379 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7380
c939f91b
PE
7381 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7382 clobbering (Bug#8298).
b9c7f648
PE
7383 * sysdep.c (sys_subshell): Likewise.
7384 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7385
6bd8c144
PE
7386 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7387 This should get cleaned up, so that child_setup has the
7388 same signature on all platforms.
7389
7710357c 7390 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7391 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7392
c59da222
CY
73932011-03-22 Chong Yidong <cyd@stupidchicken.com>
7394
7395 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7396 not to be necessary, and produces flickering.
7397
66b87493
GM
73982011-03-20 Glenn Morris <rgm@gnu.org>
7399
7400 * config.in: Remove file.
7401
45b6f6d5
JB
74022011-03-20 Juanma Barranquero <lekktu@gmail.com>
7403
7404 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7405 are now in src/globals.h.
7406 (syms_of_minibuf): Remove spurious & from previous change.
7407
3ec03f7e
LL
74082011-03-20 Leo <sdl.web@gmail.com>
7409
7410 * minibuf.c (completing-read-function): New variable.
7411 (completing-read-default): Rename from completing-read.
7412 (completing-read): Call completing-read-function.
7413
b14e3e21
CY
74142011-03-19 Juanma Barranquero <lekktu@gmail.com>
7415
7416 * xfaces.c (Fx_load_color_file):
7417 Read color file from absolute filename (bug#8250).
7418
f2b726e6
JB
74192011-03-19 Juanma Barranquero <lekktu@gmail.com>
7420
7421 * makefile.w32-in: Update dependencies.
7422
09f6ff02
EZ
74232011-03-17 Eli Zaretskii <eliz@gnu.org>
7424
7425 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7426
29a6015a
PE
74272011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7428
a3a6c54e
PE
7429 Fix more problems found by GCC 4.5.2's static checks.
7430
b766f867
PE
7431 * process.c (make_serial_process_unwind, send_process_trap):
7432 (sigchld_handler): Now static.
7433
be02381c
PE
7434 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7435 That way, the code declares only the vars that it needs.
7436 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7437 * s/cygwin.h (PTY_ITERATION): Likewise.
7438 * s/darwin.h (PTY_ITERATION): Likewise.
7439 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7440
57048744
PE
7441 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7442 * process.c (allocate_pty): Don't declare stb unless it's needed.
7443
7914961c 7444 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7445 (CONSTANTLIM): Remove; unused.
7446 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7447 Define only if needed.
7914961c 7448
b3967b18
PE
7449 * unexelf.c (unexec): Name an expression,
7450 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7451 Use a different way to cause a compilation error if anyone uses
7452 n rather than nn, a way that does not involve shadowing.
73366a00 7453 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7454
29a6015a
PE
7455 * deps.mk (unexalpha.o): Remove; unused.
7456
43cfc33e 7457 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7458 * unexec.h: New file.
ce701a33
PE
7459 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7460 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7461 Depend on unexec.h.
7462 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7463 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7464 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7465 Change as necessary to match prototype in unexec.h.
ce701a33 7466
01f44d5a
PE
7467 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7468 shadowing.
4f63c6bb 7469 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7470
a6670b0b
PE
7471 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7472 Rename locals to avoid shadowing.
7473
cef2010d 7474 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7475 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7476
d4d7173a
PE
7477 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7478
f08b802a
PE
7479 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7480 warning when compiling print.c.
7481
3ddb0639
PE
7482 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7483 instead of using an uninitialized var.
5ad03b97 7484 (font_sort_entities): Mark var as initialized.
3ddb0639 7485
170a2692
PE
7486 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7487
e663c700
PE
7488 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7489 pointers to constants.
89bc529a 7490 (font_parse_fcname): Remove unused vars.
7b81e2d0 7491 (font_delete_unmatched): Now static.
ea838e10 7492 (font_get_spec): Remove; unused.
13a547c6
PE
7493 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7494 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7495 Rename or move locals to avoid shadowing.
e663c700 7496
2a80c887 7497 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7498 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7499
1384fa33 7500 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7501 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7502
8b2c52e9
PE
7503 * alloc.c (mark_backtrace): Move decl from here ...
7504 * lisp.h: ... to here, so that it can be checked.
7505
475545b5 7506 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7507 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7508 (lisp_indirect_variable): Name an expression,
7509 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7510 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7511
b1349114 7512 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7513 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7514 Use const pointer when appropriate.
b1349114 7515
a2928364
PE
7516 * lisp.h (get_system_name, get_operating_system_release):
7517 Move decls here, to check interfaces.
7518 * process.c (get_operating_system_release): Move decl to lisp.h.
7519 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7520 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7521 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7522 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7523 (Fformat_time_string, Fencode_time, Finsert_char):
7524 (Ftranslate_region_internal, Fformat):
7525 Rename or remove local vars to avoid shadowing.
9710023e 7526 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7527
a415e694
PE
7528 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7529 avoid shadowing.
7530
8ef4622d
PE
7531 * lisp.h (eassert): Check that the argument compiles, even if
7532 ENABLE_CHECKING is not defined.
7533
946f9a5b
PE
7534 * data.c (Findirect_variable): Name an expression, to avoid
7535 gcc -Wbad-function-cast warning.
112396d6 7536 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7537 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7538 (Fmake_variable_buffer_local, Fmake_local_variable):
7539 Mark variables as initialized.
52746918 7540 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7541
e5aab7e7 7542 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7543 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7544 Rename locals to avoid shadowing.
dff45157
PE
7545 (mark_stack): Move local variables into the #ifdef region where
7546 they're used.
7bc26fdb
PE
7547 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7548 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7549 needed otherwise.
7550 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7551 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7552 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7553
e5aab7e7
PE
7554 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7555 avoids undefined behavior in theory.
7556
4da60324
PE
7557 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7558
88043301
PE
7559 Use functions, not macros, for up- and down-casing (Bug#8254).
7560 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7561 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7562 to use the following functions instead of these macros.
7563 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7564 EMACS_INT, since callers assume the returned value fits in int.
7565 (upcase1): Likewise, for UPCASE_TABLE.
7566 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7567 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7568 the race-condition problem in the old DOWNCASE.
88043301 7569
19ed5445
PE
7570 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7571 Rename locals to avoid shadowing.
7572 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7573 (regex_compile, re_search_2, re_match_2_internal):
7574 Remove unused local vars.
952db0d7
PE
7575 (FREE_VAR): Rewrite so as not to use empty "else",
7576 which gcc can warn about.
da053e48 7577 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7578 (RETALLOC_IF): Define only if needed.
7579 (WORDCHAR_P): Likewise. This one is never needed, but is used
7580 only in a comment talking about a compiler bug, so put inside
7581 the #if 0 of that comment.
7582 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7583 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7584 Remove; unused.
19ed5445 7585
1f3561e4 7586 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7587 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7588 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7589
ded6f8f7
PE
7590 * search.c (simple_search): Remove unused var.
7591
dbd37a95
PE
7592 * dired.c (compile_pattern): Move decl from here ...
7593 * lisp.h: ... to here, so that it can be checked.
7594 (struct re_registers): New forward decl.
7595
7e47afad
PE
7596 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7597
85f24f61
PE
7598 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7599 All uses changed.
7600 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7601 Rename locals to avoid shadowing.
5671df8f 7602 (Fvertical_motion): Mark locals as initialized.
85f24f61 7603
181aa2be 7604 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7605 (casify_region): Mark local as initialized.
181aa2be 7606
930d429c
PE
7607 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7608
7082eac6
PE
7609 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7610 New macros, so that the caller can use some names other than
7611 gcpro1, gcpro2, etc.
7612 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7613 of the new macros.
7614 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7615 argument, for consistency with GCPRO2_VAR, etc: it is now the
7616 prefix of the variable, not the variable itself. All uses
7617 changed.
38b2c076
PE
7618 * dired.c (directory_files_internal, file_name_completion):
7619 Rename locals to avoid shadowing.
7620
15206ed9
PE
7621 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7622 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7623 dired.c's scmp function, had undefined behavior.
7624 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7625 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7626 * buffer.h: ... to here, because these macros use current_buffer,
7627 and the new implementation with inline functions needs to have
7628 current_buffer in scope now, rather than later when the macros
7629 are used.
7630 (downcase, upcase1): New static inline functions.
7631 (DOWNCASE, UPCASE1): Reimplement using these functions.
7632 This avoids undefined behavior in expressions like
7633 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7634 from race conditions in accessing the global variables
7635 case_temp1 and case_temp2.
7636 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7637 * lisp.h (case_temp1, case_temp2): Remove their decls.
7638 * character.h (ASCII_CHAR_P): Move from here ...
7639 * lisp.h: ... to here, so that the inline functions mentioned
7640 above can use them.
7641
4a6bea26
PE
7642 * dired.c (directory_files_internal_unwind): Now static.
7643
f14b7e14
PE
7644 * fileio.c (file_name_as_directory, directory_file_name):
7645 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7646 Now static.
2893f146
PE
7647 (file_name_as_directory): Use const pointers when appropriate.
7648 (Fexpand_file_name): Likewise. In particular, newdir might
7649 point at constant storage, so make it a const pointer.
fd4ead52 7650 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7651 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7652 signedness issues.
f839df0c
PE
7653 (Fset_file_times, Finsert_file_contents, auto_save_error):
7654 Rename locals to avoid shadowing.
f14b7e14 7655
5716756e 7656 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7657 (Ftry_completion, Fall_completions): Rename or remove locals
7658 to avoid shadowing.
5716756e 7659
b4c3046a
PE
7660 * marker.c (bytepos_to_charpos): Remove; unused.
7661
b45db522
PE
7662 * lisp.h (verify_bytepos, count_markers): New decls,
7663 so that gcc does not warn that these functions aren't declared.
7664
85876d07
PE
7665 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7666 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7667 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7668 (copy_text): Remove unused local var.
85876d07 7669
03d78a21 7670 * filelock.c (within_one_second): Now static.
b3dd38ab 7671 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7672
5df8f01b
PE
7673 * buffer.c (fix_overlays_before): Mark locals as initialized.
7674 (fix_start_end_in_overlays): Likewise. This function should be
7675 simplified by using pointers-to-pointers, but that's a different
7676 matter.
b1d876f1 7677 (switch_to_buffer_1): Now static.
8f54f30a
PE
7678 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7679 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7680
a70072c9 7681 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7682 Fix pointer signedness issue.
edced198
PE
7683 (sys_subshell): Mark local as volatile if checking for lint,
7684 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7685 (MAXPATHLEN): Define only if needed.
a70072c9 7686
a0977c44
PE
7687 * process.c (serial_open, serial_configure): Move decls from here ...
7688 * systty.h: ... to here, so that they can be checked.
7689
a884fdcc
PE
7690 * fns.c (get_random, seed_random): Move extern decls from here ...
7691 * lisp.h: ... to here, so that they can be checked.
7692
604efe86 7693 * sysdep.c (reset_io): Now static.
b8950c94 7694 (wait_for_termination_signal): Remove; unused.
604efe86 7695
38fc62d9
PE
7696 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7697 (copy_keymap_item, append_key, push_text_char_description):
7698 Now static.
1004a21a 7699 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7700 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7701 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7702 (describe_map_tree):
7703 Rename locals to avoid shadowing.
38fc62d9 7704
2f2650da
PE
7705 * keyboard.c: Declare functions static if they are not used elsewhere.
7706 (echo_char, echo_dash, cmd_error, top_level_2):
7707 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7708 (read_char, kbd_buffer_get_event, make_lispy_position):
7709 (make_lispy_event, make_lispy_movement, apply_modifiers):
7710 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7711 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7712 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7713 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7714 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7715
a053e86c 7716 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7717 (mark_kboards): Move decl here ...
7718 * alloc.c (mark_kboards): ... from here.
a053e86c 7719
4752793e
PE
7720 * lisp.h (force_auto_save_soon): New decl.
7721
74f10ca7 7722 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7723 (DEFINE_DUMMY_FUNCTION): New macro.
7724 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7725 Use it.
c03cd23f
PE
7726 (main): Add casts to avoid warnings
7727 if GCC considers string literals to be constants.
74f10ca7 7728
022e70d4
PE
7729 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7730
59d6fe83
PE
7731 * dbusbind.c: Pointer signedness fixes.
7732 (xd_signature, xd_append_arg, xd_initialize):
7733 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7734 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7735 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7736 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7737
78320123
PE
7738 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7739 if GCC considers string literals to be constants.
49cebcca 7740 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7741
35ac2a97
SM
77422011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7743
fb103ca9
SM
7744 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7745 (print_preprocess, print_object): New macro to fix last change.
7746
35ac2a97
SM
7747 * print.c (print_preprocess): Don't forget font objects.
7748
62973b41
JB
77492011-03-16 Juanma Barranquero <lekktu@gmail.com>
7750
7751 * emacs.c (USAGE3): Doc fixes.
7752
0e48bb22
AS
77532011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7754
7755 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7756 structure.
7757
7684e57b
JB
77582011-03-14 Juanma Barranquero <lekktu@gmail.com>
7759
7760 * lisp.h (VWindow_system, Qfile_name_history):
7761 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7762 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7763 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7764
7765 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7766 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7767
7768 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7769 * w32console.c (detect_input_pending, read_input_pending)
7770 (encode_terminal_code):
7771 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7772 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7773 (w32_system_caret_y, Qfile_name_history):
7774 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7775 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7776 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7777 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7778 * w32proc.c (Qlocal, report_file_error):
7779 * w32term.c (Vwindow_system, updating_frame):
7780 * w32uniscribe.c (initialized, uniscribe_font_driver):
7781 Remove unneeded extern declarations.
7782
2aa46d6c
CY
77832011-03-14 Chong Yidong <cyd@stupidchicken.com>
7784
c96bbc66 7785 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7786
cffc6f3b
CY
77872011-03-13 Chong Yidong <cyd@stupidchicken.com>
7788
7789 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7790 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7791 These macros can no longer be used for assignment.
7792
44f230aa
SM
7793 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7794 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7795 (record_buffer_markers, fetch_buffer_markers): New functions for
7796 recording and fetching special buffer markers.
7797 (set_buffer_internal_1, set_buffer_temp): Use them.
7798
7799 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7800
7801 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7802
7803 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7804 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7805
7806 * xdisp.c (hscroll_window_tree):
7807 (reconsider_clip_changes): Use PT instead of BUF_PT.
7808
d251f04b
EZ
78092011-03-13 Eli Zaretskii <eliz@gnu.org>
7810
7811 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7812 $(EMACS_ROOT)/lib/intprops.h.
7813
f0c77cd1
PE
78142011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7815
3eca4629
PE
7816 Fix more problems found by GCC 4.5.2's static checks.
7817
7c86ee98
PE
7818 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7819 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7820 (xg_free_frame_widgets): Make it clear that a local variable is
7821 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7822 (gdk_window_get_screen): Make it clear that this macro is needed
7823 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7824 (int_gtk_range_get_value): New function, which avoids a diagnostic
7825 from gcc -Wbad-function-cast.
7826 (xg_set_toolkit_scroll_bar_thumb): Use it.
7827 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7828 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7829 (get_utf8_string, xg_get_file_with_chooser):
7830 Rename locals to avoid shadowing.
7831 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7832
41729b81
PE
7833 * xgselect.c (xg_select): Remove unused var.
7834
f0c77cd1
PE
7835 * image.c (four_corners_best): Mark locals as initialized.
7836 (gif_load): Initialize transparent_p to zero (Bug#8238).
7837 Mark another local as initialized.
ec6cf4c6 7838 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7839
ce0ad53d 7840 * image.c (clear_image_cache): Now static.
d5d5a617 7841 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7842 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7843 (x_edge_detection): Remove unnecessary cast that
7844 gcc -Wbad-function-cast diagnoses.
2037898d 7845 (gif_load): Fix pointer signedness.
6ae141d6
PE
7846 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7847 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7848
33383987 78492011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7850
d32df629
PE
7851 Improve quality of tests for time stamp overflow.
7852 For example, without this patch (encode-time 0 0 0 1 1
7853 1152921504606846976) returns the obviously-bogus value (-948597
7854 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7855 reports time overflow. See
7856 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7857 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7858 * editfns.c: Include limits.h and intprops.h.
7859 (TIME_T_MIN, TIME_T_MAX): New macros.
7860 (time_overflow): Move earlier, to before first use.
7861 (hi_time, lo_time): New functions, for an accurate test for
7862 out-of-range times.
7863 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7864 (Fget_internal_run_time): Don't assume time_t fits in int.
7865 (make_time): Use list2 instead of Fcons twice.
7866 (Fdecode_time): More accurate test for out-of-range times.
7867 (check_tm_member): New function.
7868 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7869 (lisp_time_argument): Don't rely on undefined left-shift and
7870 right-shift behavior when checking for time stamp overflow.
8be6f318 7871
fe31d94c
PE
7872 * editfns.c (time_overflow): New function, refactoring common code.
7873 (Fformat_time_string, Fdecode_time, Fencode_time):
7874 (Fcurrent_time_string): Use it.
7875
8be6f318
PE
7876 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7877 * dired.c (make_time): Move to ...
7878 * editfns.c (make_time): ... here.
7879 * systime.h: Note the move.
7880
09d9db2c 78812011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7882
126bc0dc
YM
7883 * fringe.c (update_window_fringes): Remove unused variables.
7884
c47cbdfd
YM
7885 * unexmacosx.c (copy_data_segment): Also copy __got section.
7886 (Bug#8223)
7887
7ac80be9
EZ
78882011-03-12 Eli Zaretskii <eliz@gnu.org>
7889
c96bbc66 7890 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7891 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7892 Constify `char *' arguments and their references according to
7893 prototypes in tparam.h.
7894
ecb0f94d 7895 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7896
7ac80be9
EZ
7897 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7898 Adapt all references accordingly.
7899
7900 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7901
ef1fd07e
TT
79022011-03-11 Tom Tromey <tromey@redhat.com>
7903
7904 * buffer.c (syms_of_buffer): Remove obsolete comment.
7905
7ef4b50c
EZ
79062011-03-11 Eli Zaretskii <eliz@gnu.org>
7907
7908 * termhooks.h (encode_terminal_code): Declare prototype.
7909
7910 * msdos.c (encode_terminal_code): Don't declare prototype.
7911
7912 * term.c (encode_terminal_code): Now external again, used by
7913 w32console.c and msdos.c.
7914
44f230aa
SM
7915 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7916 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7917
4b1ec863 79182011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7919
1714f52b 7920 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7921
4b1ec863
PE
7922 * fringe.c (update_window_fringes): Mark locals as initialized
7923 (Bug#8227).
7924 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7925
524c7aa6
PE
7926 * alloc.c (mark_fringe_data): Move decl from here ...
7927 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7928 to check its interface.
7929 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7930
a5c0af81 7931 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7932 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7933 (fontset_font): Mark local as initialized.
a9a06e0b 7934 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7935
b4716021
PE
7936 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7937
811e9bac 7938 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7939 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7940 (x_own_selection, Fx_disown_selection_internal): Rename locals
7941 to avoid shadowing.
7942 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7943
7e3ab302
PE
7944 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7945 so that the caller can use some name other than gcpro1.
7946 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7947 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7948 (Fx_backspace_delete_keys_p):
7949 Use them to avoid shadowing, and rename vars to avoid shadowing.
7950 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7951 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7952 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7953 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7954 Remove unused locals.
7e3ab302
PE
7955 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7956 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7957 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7958 macros.
f78faa98 7959
e2b13473
PE
7960 * xterm.h (x_mouse_leave): New decl.
7961
77f23912
PE
7962 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7963 Remove unused functions.
cdf4ba58
PE
7964 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7965 (x_calc_absolute_position): Now static.
7411c686 7966 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7967 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7968 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7969 unless they are used.
38d0b34a
PE
7970 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7971 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7972 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7973 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7974 (x_error_catcher, x_connection_closed, x_error_handler):
7975 (x_error_quitter, xembed_send_message, x_iconify_frame):
7976 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7977 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7978 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7979
44f230aa
SM
7980 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7981 Rename or move locals to avoid shadowing.
6b463e58 7982 (tty_defined_color, merge_face_heights): Now static.
5967d051 7983 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7984 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7985 does not deduce is never used uninitialized.
73719eba
PE
7986 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7987 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7988
426994c3 7989 * terminal.c (store_terminal_param): Now static.
5489860b 7990
032f1620 7991 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7992 (set_frame_menubar): Remove unused local.
d4323972 7993 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7994 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7995 since they might point to immutable storage.
281585b0
PE
7996 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7997 since it's unused otherwise.
032f1620 7998
367c19e5 7999 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8000 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8001 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8002 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8003 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8004 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8005 does not deduce are never used uninitialized.
70739cbe 8006
07b48fa9
PE
8007 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8008
8868a238 8009 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8010 * window.c (window_loop, size_window):
8011 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8012
7e5cf297 8013 * window.c (display_buffer): Now static.
d6550a9f
PE
8014 (size_window): Mark variables that gcc -Wuninitialized
8015 does not deduce are never used uninitialized.
a586633d
PE
8016 * window.h (check_all_windows): New decl, to forestall
8017 gcc -Wmissing-prototypes diagnostic.
5b555da1 8018 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8019
f6095868
PE
8020 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8021 shadowing.
8022 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8023 Include <limits.h>.
8024 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8025 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8026 (load_charset_map): Mark variables that gcc -Wuninitialized
8027 does not deduce are never used uninitialized.
53df7c11 8028 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8029
f38b440c
PE
8030 * coding.c (coding_set_source, coding_set_destination):
8031 Use "else { /* comment */ }" rather than "else /* comment */;"
8032 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8033 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8034 a block, when the outer 'i' will do.
8035 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8036 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8037 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8038 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8039 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8040 Rename locals to avoid shadowing.
8041 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8042 * coding.c (emacs_mule_char, encode_invocation_designation):
8043 Now static, since they're not used elsewhere.
413bb2db 8044 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8045 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8046 (decode_coding_emacs_mule): Mark variables that gcc
8047 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8048 (detect_coding_iso_2022): Initialize a local variable that might
8049 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8050 this initialization is needed. (Bug#8211)
5f58e762
PE
8051 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8052 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8053 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8054 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8055 Remove unused macros.
f38b440c 8056
232b38b9 8057 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8058 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8059 * character.c (string_count_byte8): Likewise.
232b38b9 8060
fb90da1b
PE
8061 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8062 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8063
fb93dbc2
PE
8064 * chartab.c (copy_sub_char_table): Now static, since it's not used
8065 elsewhere.
5c156ace
PE
8066 (sub_char_table_ref_and_range, char_table_ref_and_range):
8067 Rename locals to avoid shadowing.
bbcd0949 8068 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8069
7d3b3862 8070 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8071 (BIDI_BOB): Remove unused macro.
7d3b3862 8072
6be7d3da
PE
8073 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8074 deduce are never used uninitialized.
c2ed9c8b 8075 * term.c (encode_terminal_code): Likewise.
6be7d3da 8076
75f8807f 8077 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8078
50938595
PE
8079 * tparam.h: New file.
8080 * term.c, tparam.h: Include it.
8081 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8082 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8083 Move these decls to tparam.h, and make them agree with what
8084 is actually in tparam.c. The previous trick of using incompatible
8085 decls in different modules does not conform to the C standard.
8086 All callers of tparam changed to use tparam's actual API.
8087 * tparam.c (tparam1, tparam, tgoto):
8088 Use const pointers where appropriate.
8089
fbceeba2
PE
8090 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8091 * cm.h (struct cm): Likewise.
8092 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8093 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8094 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8095 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8096 (turn_on_face, init_tty): Likewise.
8097 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8098
7f3f1250
PE
8099 * term.c (term_mouse_position): Rename local to avoid shadowing.
8100
e6ca6543
PE
8101 * alloc.c (mark_ttys): Move decl from here ...
8102 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8103
c40f8d15
AS
81042011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8105
8106 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8107
cfe0661d
JB
81082011-03-09 Juanma Barranquero <lekktu@gmail.com>
8109
8110 * search.c (compile_pattern_1): Remove argument regp, unused since
8111 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8112 (compile_pattern): Don't pass it.
8113
0afb4571
J
81142011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8115
8116 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8117 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8118 for ! HAVE_GTK3.
8119 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8120
8121 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8122
8123 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8124 gdk_window_get_screen, gdk_window_get_geometry,
8125 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8126 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8127 (xg_get_pixbuf_from_pixmap): New function.
8128 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8129 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8130 Call xg_get_pixbuf_from_pixmap instead of
8131 gdk_pixbuf_get_from_drawable.
8132 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8133 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8134 (xg_check_special_colors): Use GtkStyleContext and its functions
8135 for HAVE_GTK3.
8136 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8137 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8138 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8139 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8140 Call gtk_widget_get_preferred_size.
0afb4571
J
8141 (xg_frame_resized): gdk_window_get_geometry only takes 5
8142 parameters.
44f230aa
SM
8143 (xg_win_to_widget, xg_event_is_for_menubar):
8144 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8145 (xg_set_widget_bg): New function.
8146 (delete_cb): New function.
895009e1 8147 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8148 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8149 (xg_set_background_color): Call xg_set_widget_bg.
8150 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8151 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8152 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8153 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8154 if ! HAVE_GTK3.
8155 (update_frame_tool_bar): Call gtk_widget_hide.
8156 (xg_initialize): Use GDK_KEY_g.
8157
8158 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8159 if ! HAVE_GTK3
8160 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8161
8162 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8163 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8164 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8165
1c2cc4ef
JB
81662011-03-08 Juanma Barranquero <lekktu@gmail.com>
8167
8168 * w32xfns.c (select_palette): Check success of RealizePalette against
8169 GDI_ERROR, not zero.
8170
33383987 8171See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8172
8173;; Local Variables:
8174;; coding: utf-8
aac0c6e3
MR
8175;; End:
8176
33383987 8177 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8178
8179 This file is part of GNU Emacs.
8180
8181 GNU Emacs is free software: you can redistribute it and/or modify
8182 it under the terms of the GNU General Public License as published by
8183 the Free Software Foundation, either version 3 of the License, or
8184 (at your option) any later version.
8185
8186 GNU Emacs is distributed in the hope that it will be useful,
8187 but WITHOUT ANY WARRANTY; without even the implied warranty of
8188 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8189 GNU General Public License for more details.
8190
8191 You should have received a copy of the GNU General Public License
8192 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.