Spelling fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
35dc09a1 12012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2
35dc09a1
GM
3 * lread.c (lisp_file_lexically_bound_p):
4 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5
35dc09a1
GM
62012-04-14 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
9 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
10
112012-04-14 Jan Djärv <jan.h.d@swipnet.se>
12
13 * nsterm.m (constrainFrameRect): Always constrain when there is only
14 one screen (Bug#10962).
15
bcd86815
KB
162012-04-13 Ken Brown <kbrown@cornell.edu>
17
18 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
19
c25df26e
RT
202012-04-13 Reuben Thomas <rrt@sc3d.org>
21
22 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
23
0fc59f1e
DC
242012-04-11 Daniel Colascione <dancol@dancol.org>
25
26 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
27 against is gone. It's better to use vfork now so that when Cygwin
28 gains a new, working vfork, we use it automatically (bug#10398).
29
de8c03dc
SM
302012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
31
32 * window.c (save_window_save): Obey window-point-insertion-type.
33
2f097256
GM
342012-04-11 Glenn Morris <rgm@gnu.org>
35
36 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
37
453b951e
SM
382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
41
6bbef4e5
JC
422012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
43
44 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
45 (force_quit_count): New var.
46 (handle_interrupt): Use it.
47
2a8ce227
JB
482012-04-10 Juanma Barranquero <lekktu@gmail.com>
49
50 * w32.c (w32_delayed_load): Record the full path of the library
51 being loaded (bug#10424).
52
935396c0
GM
532012-04-09 Glenn Morris <rgm@gnu.org>
54
05920a43
GM
55 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
56 not just in the obarray, before snarfing them. (Bug#11036)
57
935396c0
GM
58 * Makefile.in ($(leimdir)/leim-list.el):
59 Pass EMACS rather than BUILT_EMACS.
60
a18ecafa
TZ
612012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
62
63 * process.c (make_process):
64 * process.h: Add integer `gnutls_handshakes_tried' member to
65 process struct.
66
6bbef4e5
JC
67 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
68 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
69
70 * gnutls.c (gnutls_log_function2i): Convenience log function.
71 (emacs_gnutls_read): Use new log functions,
72 `gnutls_handshakes_tried' process member, and
73 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
74 attempts per process (connection).
75
b4d3bc10
CY
762012-04-09 Chong Yidong <cyd@gnu.org>
77
78 * eval.c (Fuser_variable_p, user_variable_p_eh)
79 (lisp_indirect_variable): Functions deleted.
80 (Fdefvar): Caller changed.
81
82 * callint.c (Finteractive, Fcall_interactively):
83 * minibuf.c (Fread_variable): Callers changed.
84
70f4d973
EZ
852012-04-09 Eli Zaretskii <eliz@gnu.org>
86
87 * xdisp.c (set_cursor_from_row): If the display string appears in
88 the buffer at position that is closer to point than the position
89 after the display string, display the cursor on the first glyph of
90 the display string. Fixes cursor display when a 'display' text
91 property immediately follows invisible text. (Bug#11094)
92
cb3c2e3e
PE
932012-04-09 Paul Eggert <eggert@cs.ucla.edu>
94
95 composite.c: use 'double' consistently
96 * composite.c (get_composition_id): Use 'double' consistently
97 instead of converting 'float' to 'double' and vice versa; this is
98 easier to understand and avoids a GCC warning.
99
fd06db5d
GM
1002012-04-09 Glenn Morris <rgm@gnu.org>
101
50fe702a
GM
102 * Makefile.in: Generate leim-list with bootstrap-emacs, in
103 preparation for dumping it with emacs. (Bug#4789)
104 (leimdir): New variable.
105 ($(leimdir)/leim-list.el): New rule.
106 (emacs$(EXEEXT)): Depend on leim-list.el.
107
fd06db5d
GM
108 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
109 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
110 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
111
55c131ee
AS
1122012-04-08 Andreas Schwab <schwab@linux-m68k.org>
113
114 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
115 proper alignment.
116
9209588f
JB
1172012-04-07 Juanma Barranquero <lekktu@gmail.com>
118
119 * xml.c (init_libxml2_functions) [WINDOWSNT]:
120 Remove unused local variable.
121
e3fb2efb
PE
1222012-04-07 Paul Eggert <eggert@cs.ucla.edu>
123
124 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
125 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
126 (mark_memory): Mark Lisp_Objects only if pointers might hide in
127 objects, as mark_maybe_pointer will catch them otherwise.
128 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
129 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
130
b5385551
PE
1312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
132
133 Fix typo that broke non-Windows builds.
134 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
135
9078ead6
EZ
1362012-04-07 Eli Zaretskii <eliz@gnu.org>
137
138 Support building on MS-Windows with libxml2.
139
140 * makefile.w32-in (OBJ2): Add xml.$(O).
141 (GLOBAL_SOURCES): Add xml.c.
142 ($(BLD)/xml.$(O)): New dependency list.
143
144 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
145 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
146 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
147 [!WINDOWSNT]: New macros.
148 (init_libxml2_functions, libxml2_loaded_p): New functions.
149 (parse_region): Call fn_xmlCheckVersion instead of using the macro
150 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
151 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
152 Calls xmlCleanupParser only if libxml2 was loaded (or statically
153 linked in).
6bbef4e5
JC
154 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
155 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
156 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
157
158 * emacs.c: Don't include libxml/parser.h.
159 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
160 xmlCleanupParser directly.
161
162 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
163
3811fdf3
EZ
1642012-04-07 Eli Zaretskii <eliz@gnu.org>
165
166 * indent.c (Fvertical_motion): If there is a display string at
167 point, use it.vpos to compute how many lines to backtrack after
168 move_it_to point. (Bug#11133)
169
2f8e16b2
EZ
1702012-04-06 Eli Zaretskii <eliz@gnu.org>
171
172 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
173 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
174 about subtle differences between FETCH_CHAR* and STRING_CHAR*
175 macros related to unification of CJK characters. For the details,
176 see the discussion following the message here:
177 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
178
3d439cd1
CY
1792012-04-04 Chong Yidong <cyd@gnu.org>
180
181 * keyboard.c (Vdelayed_warnings_list): Doc fix.
182
8bc53d00
EZ
1832012-04-01 Eli Zaretskii <eliz@gnu.org>
184
185 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
186 instead of alloca. (Bug#11138)
187
3b0512a3
AS
1882012-04-01 Andreas Schwab <schwab@linux-m68k.org>
189
190 * w32menu.c (is_simple_dialog): Properly check lisp types.
191 (Bug#11141)
192
8427ddd2
EZ
1932012-03-31 Eli Zaretskii <eliz@gnu.org>
194
979022ef
EZ
195 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
196 position we get to after a call to move_it_to fails the
197 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
198 only if we wind up in a string from display property. (Bug#11063)
199
a6b1c7cc
EZ
200 * window.c (Fdelete_other_windows_internal): Invalidate the row
201 and column information about mouse highlight, so that redisplay
202 restores it after reallocating the glyph matrices. (Bug#7464)
203
8427ddd2
EZ
204 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
205 string comes from a `display' text property, use the buffer
206 position of that property as if we actually saw that position in
207 the row's glyphs.
697ba24b
EZ
208 (move_it_by_lines): Remove the assertion that
209 "it->current_x == 0 && it->hpos == 0" which can be legitimately
210 violated when there's a before-string at the beginning of a line.
211 (Bug#11063)
8427ddd2 212
65a0a738
EZ
2132012-03-30 Eli Zaretskii <eliz@gnu.org>
214
215 * xdisp.c (append_space_for_newline): If the default face was
216 remapped, use the remapped face for the appended newline.
217 (extend_face_to_end_of_line): Use the remapped default face for
218 extending the face to the end of the line.
219 (display_line): Call extend_face_to_end_of_line when the default
220 face was remapped. (Bug#11068)
221
581355cc
EZ
2222012-03-29 Eli Zaretskii <eliz@gnu.org>
223
224 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
225
e8fc049f
SM
2262012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
227
228 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
229
4fb9a543
GM
2302012-03-27 Glenn Morris <rgm@gnu.org>
231
232 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
233 Doc fixes.
234
679910f1
KH
2352012-03-26 Kenichi Handa <handa@m17n.org>
236
237 * dispextern.h (struct glyph): Fix previous change. Change the
238 bit length of glyphless.ch to 25 (Bug#11082).
239
90d49b7f
CY
2402012-03-26 Chong Yidong <cyd@gnu.org>
241
242 * keyboard.c (Vselection_inhibit_update_commands): New variable.
243 (command_loop_1): Use it; inhibit selection update for
244 handle-select-window too (Bug#8996).
245
f514f6f0
FP
2462012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
247
e8fc049f 248 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 249
bf43fa51
KH
2502012-03-25 Kenichi Handa <handa@m17n.org>
251
252 * dispextern.h (struct glyph): Change the bit length of
253 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
254
8a0c01dd
EZ
2552012-03-24 Eli Zaretskii <eliz@gnu.org>
256
257 * s/ms-w32.h (tzname): Include time.h before redirecting to
258 _tzname. Fixes the MSVC build. (Bug#9960)
259
7d1c3a76
AS
2602012-03-24 Andreas Schwab <schwab@linux-m68k.org>
261
8ed79523
AS
262 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
263 characters.
264
7d1c3a76
AS
265 * xterm.c (XTread_socket): Only modify handling_signal if
266 !SYNC_INPUT. (Bug#11080)
267
e99a9b8b
EZ
2682012-03-23 Eli Zaretskii <eliz@gnu.org>
269
270 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
271 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
272 when fetching a multibyte character consumes more bytes than
273 CHAR_BYTES returns, due to unification of CJK characters in
274 string_char. (Bug#11073)
275
5063c0e1
TN
2762012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
277
278 * process.c (wait_reading_process_output): Handle pty disconnect
279 by refraining from sending oneself a SIGCHLD (bug#10933).
280
9f851fbd
CY
2812012-03-22 Chong Yidong <cyd@gnu.org>
282
283 * dispextern.h (struct it): New member string_from_prefix_prop_p.
284
5063c0e1 285 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
286 Mark string as coming from a prefix property.
287 (handle_face_prop): Use default face for prefix strings (Bug#4281).
288 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
289
fb5b8aca
CY
2902012-03-21 Chong Yidong <cyd@gnu.org>
291
292 * xfaces.c (Vface_remapping_alist): Doc fix.
293
62356a1b
EZ
2942012-03-20 Eli Zaretskii <eliz@gnu.org>
295
296 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
297 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
298 Doc fixes.
62356a1b 299
025de85b
CY
3002012-03-20 Chong Yidong <cyd@gnu.org>
301
302 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
303 to reflect default non-nil value of redisplay-dont-pause.
304
4827f94e
KH
3052012-03-19 Kenichi Handa <handa@m17n.org>
306
307 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
308 it fit in a valid range (Bug#11003).
309
e50a24a2
EZ
3102012-03-18 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
313 that is not from display property, accept the row as a "cursor
314 row" if one of the string's character has a non-nil `cursor'
315 property. Fixes cursor positioning when there are newlines in
316 overlay strings, e.g. in icomplete.el. (Bug#11035)
317
9af5ed87
PE
3182012-03-12 Paul Eggert <eggert@cs.ucla.edu>
319
320 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
321
d1f55f16
CY
3222012-03-12 Chong Yidong <cyd@gnu.org>
323
324 * eval.c (inhibit_lisp_code): Rename from
325 inhibit_window_configuration_change_hook; move from window.c.
326
327 * xfns.c (unwind_create_frame_1, Fx_create_frame):
328 * window.c (run_window_configuration_change_hook)
329 (syms_of_window): Callers changed.
330
66c5eebd
CY
3312012-03-11 Chong Yidong <cyd@gnu.org>
332
413df973
CY
333 * keymap.c (Fkey_description): Doc fix (Bug#9700).
334
66c5eebd
CY
335 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
336
1de11f56
CY
3372012-03-10 Chong Yidong <cyd@gnu.org>
338
339 * frame.c (other_visible_frames): Don't assume the selected frame
340 is visible (Bug#10955).
341
cae07000
SM
3422012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
343
344 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
345
89c94350
JD
3462012-03-08 Jan Djärv <jan.h.d@swipnet.se>
347
348 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
349 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
350 zero (Bug#10954).
351
999dd333
GM
3522012-03-03 Glenn Morris <rgm@gnu.org>
353
01a6dcc8 354 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 355
de0100f2
EZ
3562012-03-02 Eli Zaretskii <eliz@gnu.org>
357
358 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
359 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
360 (redisplay_window, next_element_from_string): Fix typos in
361 comments.
3e441275
EZ
362 (redisplay_window): Pass to move_it_vertically the margin in
363 pixels, not in screen lines.
de0100f2 364
96a72ee9
GM
3652012-03-02 Glenn Morris <rgm@gnu.org>
366
367 * buffer.c (buffer-list-update-hook): Doc fix.
368
312508d7
EZ
3692012-02-29 Eli Zaretskii <eliz@gnu.org>
370
371 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
372 push_it before setting up the iterator for the first overlay
373 string, even if we have an empty string loaded.
374 (next_overlay_string): If there's an empty string on the iterator
375 stack, pop the stack. (Bug#10903)
376
27f3c637
PE
3772012-02-25 Paul Eggert <eggert@cs.ucla.edu>
378
379 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
380 Suggested by Stefan Monnier in
381 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
382 * alloc.c (widen_to_Lisp_Object): New static function.
383 (mark_memory): Also mark Lisp_Objects by fetching pointer words
384 and widening them to Lisp_Objects. This would work even if
385 USE_LSB_TAG is defined and wide integers are used, which might
386 happen in a future version of Emacs.
387
3c9dfce6
CY
3882012-02-25 Chong Yidong <cyd@gnu.org>
389
fa74b241
CY
390 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
391 Doc fix.
392
3c9dfce6
CY
393 * xselect.c (Fx_selection_exists_p): Doc fix.
394 (x_clipboard_manager_save_all): Print an informative message
395 before saving to clipboard manager.
396
9486df08
CY
3972012-02-24 Chong Yidong <cyd@gnu.org>
398
399 * keyboard.c (process_special_events): Handle all X selection
400 requests in kbd_buffer, not just the next one (Bug#8869).
401
f01d3321
CY
4022012-02-23 Chong Yidong <cyd@gnu.org>
403
404 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
405 call when setting menu-bar-lines and tool-bar-lines parameters.
406 (unwind_create_frame_1): New helper function.
407
408 * window.c (inhibit_window_configuration_change_hook): New var.
409 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 410 (syms_of_window): Initialize it.
f01d3321 411
86b847b6
CY
4122012-02-22 Chong Yidong <cyd@gnu.org>
413
414 * xterm.c (x_draw_image_relief): Add missing type check for
415 Vtool_bar_button_margin (Bug#10743).
416
a59225b1
CY
4172012-02-21 Chong Yidong <cyd@gnu.org>
418
419 * fileio.c (Vfile_name_handler_alist): Doc fix.
420
421 * buffer.c (Fget_file_buffer): Protect against invalid file
422 handler return value.
423
310f5bd4
PE
4242012-02-20 Paul Eggert <eggert@cs.ucla.edu>
425
cb3a28cc
PE
426 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
427 when computing $valmask.
428
310f5bd4
PE
429 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
430 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
431 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
432 It's useless in that case, and it can cause problems on hosts
433 that allocate halves of EMACS_INT values separately.
434 Reported by Dan Horák. Diagnosed by Andreas Schwab in
435 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
436 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
437 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
438 it avoids undefined behavior on hosts where shifting right by more
439 than the word width has undefined behavior.
440
2375c96a
CY
4412012-02-19 Chong Yidong <cyd@gnu.org>
442
443 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
444 (Funhandled_file_name_directory, Ffile_name_as_directory)
445 (Fdirectory_file_name, Fexpand_file_name)
446 (Fsubstitute_in_file_name): Protect against invalid file handler
447 return values (Bug#10845).
448
3eb49e71
EZ
4492012-02-18 Eli Zaretskii <eliz@gnu.org>
450
451 * .gdbinit (pitx): Fix incorrect references to fields of the
452 iterator stack.
453
7b926f3f
CY
4542012-02-17 Chong Yidong <cyd@gnu.org>
455
456 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
457
11273115
PE
4582012-02-15 Paul Eggert <eggert@cs.ucla.edu>
459
460 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
461 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
462
c3a70e2b
CY
4632012-02-15 Chong Yidong <cyd@gnu.org>
464
465 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
466 marked as special. Also, starting docstrings with * is obsolete.
467
0ca43699
AS
4682012-02-13 Andreas Schwab <schwab@linux-m68k.org>
469
470 * gnutls.c (emacs_gnutls_write): Fix last change.
471
2e8f3c56
LI
4722012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
473
474 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
475 send_process.
476
af70074f
SM
4772012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
478
479 * keymap.c (Fsingle_key_description): Handle char ranges.
480
95986d52
CY
4812012-02-12 Chong Yidong <cyd@gnu.org>
482
afd83bd1
CY
483 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
484 as that creates a dangerous corner case.
485
95986d52
CY
486 * window.c (Fdelete_window_internal): Invalidate the mouse
487 highlight (Bug#9904).
488
bd7da63e
GM
4892012-02-12 Glenn Morris <rgm@gnu.org>
490
491 * xselect.c (Fx_own_selection_internal)
492 (Fx_get_selection_internal, Fx_disown_selection_internal)
493 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
494 * nsselect.m (Fx_own_selection_internal)
495 (Fx_disown_selection_internal, Fx_selection_exists_p)
496 (Fx_selection_owner_p, Fx_get_selection_internal):
497 Sync docs and argument specs with the xselect.c versions.
498
77abcbc2
LI
4992012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
500
501 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
502
90b671e2
EZ
5032012-02-11 Eli Zaretskii <eliz@gnu.org>
504
1c0ca0b7
EZ
505 * w32select.c (Fx_selection_exists_p): Sync doc string and
506 argument list with xselect.c. (Bug#10783)
507
508 * w16select.c (Fx_selection_exists_p): Sync doc string and
509 argument list with xselect.c. (Bug#10783)
90b671e2 510
49241268
GM
5112012-02-10 Glenn Morris <rgm@gnu.org>
512
513 * fns.c (Fsecure_hash): Doc fix.
514
f998bbe7 5152012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
516
517 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
518
0992bd9c
CY
5192012-02-07 Chong Yidong <cyd@gnu.org>
520
521 * buffer.c (Fbuffer_local_variables)
522 (buffer_lisp_local_variables): Handle unbound vars correctly;
523 don't let Qunbound leak into Lisp.
524
af008560
GM
5252012-02-07 Glenn Morris <rgm@gnu.org>
526
dd605cc4
GM
527 * image.c (Fimagemagick_types): Doc fix.
528
af008560
GM
529 * image.c (imagemagick-render-type): Change it from a lisp object
530 to an integer. Move the doc here from the lisp manual.
531 Treat all values not equal to 0 the same.
532
1449fa1d
CY
5332012-02-06 Chong Yidong <cyd@gnu.org>
534
535 * doc.c (store_function_docstring): Avoid applying docstring of
536 alias to base function (Bug#2603).
537
3723ec07
AS
5382012-02-04 Andreas Schwab <schwab@linux-m68k.org>
539
540 * .gdbinit (pp1, pv1): Remove redundant defines.
541 (pr): Use pp.
542
79c1cc1e
CY
5432012-02-04 Chong Yidong <cyd@gnu.org>
544
545 * nsterm.m: Declare a global (Bug#10694).
546
d7f29f8e
EZ
5472012-02-04 Eli Zaretskii <eliz@gnu.org>
548
cae07000
SM
549 * w32.c (get_emacs_configuration_options):
550 Include --enable-checking, if specified, in the return value.
d7f29f8e 551
3b95a6f9
MR
5522012-02-04 Martin Rudalics <rudalics@gmx.at>
553
554 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
555 after rounding frame sizes. (Bug#9723)
556
d6fa96a6
EZ
5572012-02-04 Eli Zaretskii <eliz@gnu.org>
558
559 * keyboard.c (adjust_point_for_property): Don't position point
560 before BEGV. (Bug#10696)
561
df0b2940
PE
5622012-02-03 Paul Eggert <eggert@cs.ucla.edu>
563
564 Handle overflow when computing char display width (Bug#9496).
565 * character.c (char_width): Return EMACS_INT, not int.
566 (char_width, c_string_width): Check for overflow when
567 computing the width; this is possible now that individual
568 characters can have unbounded width. Problem introduced
569 by merge from Emacs 23 on 2012-01-19.
570
6bee44d6
MA
5712012-02-02 Michael Albinus <michael.albinus@gmx.de>
572
573 * dbusbind.c (Fdbus_register_method): Mention the return value
574 :ignore in the docstring.
575
44f92739
GM
5762012-02-02 Glenn Morris <rgm@gnu.org>
577
1b9f60cc
GM
578 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
579
44f92739
GM
580 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
581 Unconditionally set to t. (Bug#10673)
582 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
583 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
584 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
585
c5d3843c
KH
5862012-02-02 Kenichi Handa <handa@m17n.org>
587
588 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
589 0, do not call append_composite_glyph.
590
159462d4 5912012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
592
593 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
594 NULL (Bug#6988).
595 (x_produce_glyphs): If the component of a composition is a null
596 string, set it->pixel_width to 1 to avoid zero-width glyph.
597
78cef877
EZ
5982012-02-01 Eli Zaretskii <eliz@gnu.org>
599
600 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
601 first 2 arguments are identical. This makes inserting large
602 output from a subprocess an order of magnitude faster on
603 MS-Windows, where all sbrk'ed memory is always contiguous.
604
97897668
GM
6052012-01-31 Glenn Morris <rgm@gnu.org>
606
607 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 608 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
609 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
610
31fd3586
GM
6112012-01-29 Glenn Morris <rgm@gnu.org>
612
613 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
614
0e24a8b2
CY
6152012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
616
617 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
618
cc0adcb0
CY
6192012-01-28 Chong Yidong <cyd@gnu.org>
620
621 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
622
acc28cb9
CY
6232012-01-26 Chong Yidong <cyd@gnu.org>
624
9c69cfb7
CY
625 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
626
acc28cb9
CY
627 * search.c (Fsearch_forward, Fsearch_backward): Document negative
628 repeat counts (Bug#10507).
629
48da7392
GM
6302012-01-26 Glenn Morris <rgm@gnu.org>
631
632 * lread.c (syms_of_lread): Doc fix.
633
14af5f7f
CY
6342012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
635
636 * coding.c (encode_designation_at_bol): Change return value to
637 EMACS_INT.
638
0b21c100
CY
6392012-01-25 Chong Yidong <cyd@gnu.org>
640
641 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
642
3c2907f7
CY
6432012-01-21 Chong Yidong <cyd@gnu.org>
644
645 * floatfns.c (Fcopysign): Make the second argument non-optional,
646 since nil is not allowed anyway.
647
959ad23f
AS
6482012-01-21 Andreas Schwab <schwab@linux-m68k.org>
649
650 * process.c (read_process_output): Use p instead of XPROCESS (proc).
651 (send_process): Likewise.
652
34a02f46
MR
6532012-01-19 Martin Rudalics <rudalics@gmx.at>
654
655 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
656 (Vwindow_persistent_parameters): Do not use Qstate.
657 Rewrite doc-strings.
34a02f46 658
1259009a 6592012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
660
661 * character.c (char_width): New function.
70d4fdf6
GM
662 (Fchar_width, c_string_width, lisp_string_width):
663 Use char_width (Bug#9496).
25ed9e61 664
6a6ee00d
MR
6652012-01-16 Martin Rudalics <rudalics@gmx.at>
666
667 * window.c (Vwindow_persistent_parameters): New variable.
668 (Fset_window_configuration, save_window_save): Handle persistent
669 window parameters.
670
c85efaf7
EZ
6712012-01-14 Eli Zaretskii <eliz@gnu.org>
672
673 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
674 thrashing the stack of the thread. (Bug#9087)
675
5944709e
PE
6762012-01-12 Paul Eggert <eggert@cs.ucla.edu>
677
678 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
679
e71f5d99
EZ
6802012-01-11 Eli Zaretskii <eliz@gnu.org>
681
682 * xdisp.c (rows_from_pos_range): Handle the case where the
683 highlight ends on a newline. (Bug#10464)
684 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
685 he end column for display of highlight that ends on a newline
686 before a R2L line.
687
ce316182
GM
6882012-01-11 Glenn Morris <rgm@gnu.org>
689
690 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
691 from load-path also when installation-directory is nil. (Bug#10208)
692
5b43da69
GM
6932012-01-10 Glenn Morris <rgm@gnu.org>
694
74cc8ff9
GM
695 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
696
7d8d6e4e
GM
697 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
698 Update template values to be closer to their typical values these days.
5b43da69 699
a0db8d43
EZ
7002012-01-09 Eli Zaretskii <eliz@gnu.org>
701
702 * xdisp.c (rows_from_pos_range): Accept additional argument
703 DISP_STRING, and accept any glyph in a row whose object is that
704 string as eligible for mouse highlight. Fixes mouse highlight of
705 display strings from overlays. (Bug#10464)
706
9a0115ab 7072012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 708
b9110d6a 709 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
710 * fileio.c (auto_saving_dir_umask): New static var.
711 (Fmake_directory_internal): Use it.
712 (do_auto_save_make_dir): Set it, instead of invoking chmod after
713 creating the directory. The old code temporarily assigns
714 too-generous permissions to the directory.
715 (do_auto_save_eh): Clear it.
b9110d6a 716 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
717 that the var is always cleared.
718
6c1bd3f3
EZ
7192012-01-07 Eli Zaretskii <eliz@gnu.org>
720
721 * search.c (scan_buffer): Pass character positions to
722 know_region_cache, not byte positions. (Bug#6540)
723
069d2b50
L
7242012-01-07 LynX <_LynX@bk.ru> (tiny change)
725
726 * w32.c (sys_rename): Report EXDEV when rename of a directory
727 fails because the target is on another logical disk. (Bug#10284)
728
75bf0d33
DB
7292012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
730
731 * xterm.c (x_embed_request_focus): New function.
732
733 * xterm.h: Add prototype.
734
735 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
736
1c6e5a32
GM
7372012-01-05 Glenn Morris <rgm@gnu.org>
738
739 * emacs.c (emacs_copyright): Update short copyright year to 2012.
740
651e947e
EZ
7412012-01-01 Eli Zaretskii <eliz@gnu.org>
742
743 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
744 Load gnutls_transport_set_lowat only if GnuTLS version is below
745 2.11.1.
746 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
747 GnuTLS versions below 2.11.1.
748
3778cdd8
AL
7492011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
750
751 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
752 to the doc string advising against its use for altering the way
753 windows are scrolled.
754
0e5317f7
KH
7552011-12-28 Kenichi Handa <handa@m17n.org>
756
757 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
758 coding-system ASCII compatible only when it does not produce BOM
759 on encoding (Bug#10383).
760
93d5ca1f
JD
7612011-12-26 Jan Djärv <jan.h.d@swipnet.se>
762
763 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
764 can scroll.
765 (create_and_show_popup_menu): Always use menu_position_func for
766 Gtk3 (Bug#10361).
767
ca22b785
AS
7682011-12-24 Andreas Schwab <schwab@linux-m68k.org>
769
770 * callint.c (Fcall_interactively): Don't truncate prompt string.
771
d048e1e6
EZ
7722011-12-23 Eli Zaretskii <eliz@gnu.org>
773
774 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
775 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 776 resumed from there (after widening). (Bug#10360)
d048e1e6 777
5ccaba1f
JD
7782011-12-22 Jan Djärv <jan.h.d@swipnet.se>
779
780 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
781
204ee57f
JD
7822011-12-21 Jan Djärv <jan.h.d@swipnet.se>
783
b81d40f0
JB
784 * nsterm.m (x_free_frame_resources):
785 Release f->output_data.ns->miniimage.
204ee57f
JD
786 (ns_index_color): Fix indentation. Do not retain
787 color_table->colors[i].
788
789 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
790 before returning.
791
792 * nsfns.m (x_set_background_color): Assign return value from
793 ns_index_color to face-background instead of NSColor*.
794 (ns_implicitly_set_icon_type): Fix indentation.
795 Change assignment in for loop to comparison.
796
797 * emacs.c (ns_pool): New variable.
798 (main): Assign ns_pool.
799 (Fkill_emacs): Call ns_release_autorelease_pool.
800
801 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
802 autorelease fdesc, release fdAttrs and tdict.
803 (ns_get_covering_families): Release charset.
804 (ns_findfonts): Release NSFontDescriptor created with new.
805 (ns_uni_to_glyphs): Fix indentation.
806 (setString): Release attrStr before assigning new value.
807
c803b2b7
JD
8082011-12-18 Jan Djärv <jan.h.d@swipnet.se>
809
678f4426
JD
810 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
811 and NS_IMPL_COCOA.
812 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
813 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
814
cd394be1 8152011-12-18 David Reitter <reitter@cmu.edu>
678f4426 816
5fecd5fc
JD
817 * nsterm.m (ns_term_init): Subscribe for notifications
818 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
819 to method trackingNotification in EmacsMenu.
820
821 * nsmenu.m (trackingMenu): New variable.
3771cb17 822 (trackingNotification): New method (from Aquamacs).
5fecd5fc 823 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 824 from Aquamacs (Bug#7030).
678f4426
JD
825
8262011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 827
c803b2b7
JD
828 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
829 (symbol_to_nsstring): Fix indentation.
830 (ns_symbol_to_pb): New function.
cae07000
SM
831 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
832 (Fns_rotate_cut_buffers_internal): Remove.
833 (Fns_store_selection_internal): Rename from
c803b2b7
JD
834 Fns_store_cut_buffer_internal.
835 (ns_get_foreign_selection, Fx_own_selection_internal)
836 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
837 (Fns_get_selection_internal, Fns_store_selection_internal):
838 Use ns_symbol_to_pb and check if return value is nil.
839 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
840 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
841 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
842 renamed to Sns_store_selection_internal.
843 (ns_handle_selection_request): Move code to Fx_own_selection_internal
844 and remove this function.
845 (ns_handle_selection_clear): Remove, never used.
846 (Fx_own_selection_internal): Move code from ns_handle_selection_request
847 here.
848
e1b01a3a
KB
8492011-12-17 Ken Brown <kbrown@cornell.edu>
850
851 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
852 GID is unknown (Bug#10257).
853
2adb6e85
PE
8542011-12-17 Paul Eggert <eggert@cs.ucla.edu>
855
856 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
857 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
858 which caused a build failure on GNU/Linux IA-64. This problem was
859 introduced by my 2011-10-07 patch.
860
d1d7b339
JL
8612011-12-15 Juri Linkov <juri@jurta.org>
862
863 * image.c (imagemagick_error): New function. (Bug#10112)
864 (imagemagick_load_image): Comment out `MagickSetResolution' call.
865 Use `imagemagick_error' where ImageMagick functions return
866 `MagickFalse'.
867 (Fimagemagick_types): Add `Fnreverse' to return the list in the
868 proper order.
869
100d5755
KH
8702011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
871
872 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
873 fill background (Bug#8992).
874
454592a6
MR
8752011-12-13 Martin Rudalics <rudalics@gmx.at>
876
877 * window.c (Vwindow_combination_resize)
878 (Vwindow_combination_limit): Use t instead of non-nil in
879 doc-strings.
61d4b438
MR
880 (Vrecenter_redisplay): Add first sentence of doc-string on
881 separate line.
53524d93 882 (Frecenter): Fix doc-string typo.
454592a6 883
3633e3aa
KH
8842011-12-11 Kenichi Handa <handa@m17n.org>
885
886 * coding.c (Funencodable_char_position): Pay attention to the
887 buffer text relocation (Bug#9389).
888
7b9d523a
JD
8892011-12-10 Jan Djärv <jan.h.d@swipnet.se>
890
891 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
892 gtk_init (Bug#10100).
893
b73189c6
EZ
8942011-12-10 Eli Zaretskii <eliz@gnu.org>
895
896 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
897 IT->string is nil. (Bug#10263)
898
f7dfe5d6
JD
8992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
900
83faebb4
JD
901 * nsterm.h (x_free_frame_resources): Declare.
902
f7dfe5d6
JD
903 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
904 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
905
906 * nsterm.h (ns_get_defaults_value): Declare.
907
908 * nsterm.m (ns_default): Call ns_get_defaults_value.
909
7cd4e72c
EZ
9102011-12-09 Eli Zaretskii <eliz@gnu.org>
911
912 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
913 (Bug#10170)
914
b34d7317
YM
9152011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
916
917 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
918 that where the value of an _OBJC_* symbol points to is in the .bss
919 section (Bug#10240).
920
76470ad1
KH
9212011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
922
923 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 924 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 925
745fff94
KH
9262011-12-08 Kenichi Handa <handa@m17n.org>
927
928 * ftfont.c (get_adstyle_property): Fix previous change
929 (Bug#10233).
930
6e44397c
JB
9312011-12-07 Juanma Barranquero <lekktu@gmail.com>
932
933 * w32.c (init_environment): If no_site_lisp, remove site-lisp
934 dirs from the default value of EMACSLOADPATH (bug#10208).
935
7efa6272
GM
9362011-12-07 Glenn Morris <rgm@gnu.org>
937
938 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
939 installation and source directories as well. (Bug#10208)
940
f6fc4d87
CY
9412011-12-06 Chong Yidong <cyd@gnu.org>
942
943 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
944
2bf26180
GM
9452011-12-06 Glenn Morris <rgm@gnu.org>
946
947 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
948 as an error, not just -1. (Bug#10217)
949
3a6ad4f0
CY
9502011-12-05 Chong Yidong <cyd@gnu.org>
951
952 * keyboard.c (process_special_events): New function.
953 (swallow_events, Finput_pending_p): Use it (Bug#10195).
954
75a3b399
PE
9552011-12-05 Paul Eggert <eggert@cs.ucla.edu>
956
957 * coding.c (encode_designation_at_bol): Don't use uninitialized
958 local variable (Bug#9318).
959
c3c9e25e
KH
9602011-12-05 Kenichi Handa <handa@m17n.org>
961
962 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
963 return Qnil (Bug#8046, Bug#10193).
964
5eb05ea3
KH
9652011-12-05 Kenichi Handa <handa@m17n.org>
966
967 * coding.c (encode_designation_at_bol): New args charbuf_end and
968 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
969 (coding_set_source): Return how many bytes coding->source was
970 relocated.
971 (coding_set_destination): Return how many bytes
972 coding->destination was relocated.
973 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 974 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
975
9762011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
977
978 * coding.c (CODING_CHAR_CHARSET_P): New macro.
979 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
980 macro (Bug#9318).
981
9822011-12-05 Andreas Schwab <schwab@linux-m68k.org>
983
984 The following changes are to fix Bug#9318.
985
a79703f5 986 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
987 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
988 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 989 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 990
7dbda6df
JB
9912011-12-05 Juanma Barranquero <lekktu@gmail.com>
992
993 * lisp.h (process_quit_flag): Fix external declaration.
994
6d5eb5b0
SM
9952011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
996
997 Don't macro-inline non-performance-critical code.
998 * eval.c (process_quit_flag): New function.
999 * lisp.h (QUIT): Use it.
1000
a0c3fad0
JD
10012011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1002
1003 * nsfns.m (get_geometry_from_preferences): New function.
1004 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1005
6c07aac2
AS
10062011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1007
1008 * emacs.c (Qkill_emacs): Define.
1009 (syms_of_emacs): Initialize it.
1010 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1011 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1012 (quit_throw_to_read_char): Add parameter `from_signal'.
1013 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1014 * lisp.h (QUIT): Call Fkill_emacs if requested.
1015
c052ead4
JD
10162011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1017
1018 * widget.c (update_wm_hints): Return if wmshell is null.
1019 (widget_update_wm_size_hints): New function.
1020
1021 * widget.h (widget_update_wm_size_hints): Declare.
1022
1023 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1024 widget_update_wm_size_hints (Bug#10104).
1025
9e49252b
EZ
10262011-12-03 Eli Zaretskii <eliz@gnu.org>
1027
1028 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1029 before a newline, prepare the bidi iterator for consuming the
1030 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1031 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1032
02b16839
JL
10332011-12-02 Juri Linkov <juri@jurta.org>
1034
1035 * search.c (Fword_search_regexp): New Lisp function created from
1036 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1037 (Fword_search_backward, Fword_search_forward)
1038 (Fword_search_backward_lax, Fword_search_forward_lax):
1039 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1040 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1041
0068070e
SM
10422011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1043
1044 * fileio.c (Finsert_file_contents): Move after-change-function call
1045 to before the "handled:" label, since all "goto handled" appear in
1046 cases where the *-change-functions have already been properly called
1047 (bug#10117).
1048
3360a3fc
AS
10492011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1050
1051 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1052 waiting for input. (Bug#10169)
1053
73d6c093
EZ
10542011-11-30 Eli Zaretskii <eliz@gnu.org>
1055
1056 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1057 verifies glyph row's hash code--we have just reallocated the
1058 glyphs, so their contents can be complete garbage. (Bug#10164)
1059
febe6bea
JB
10602011-11-30 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1063
801a4313
EZ
10642011-11-30 Eli Zaretskii <eliz@gnu.org>
1065
1066 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1067 attributes are tested _before_ calling verify_row_hash, to protect
1068 against GCC re-ordering of the tests. (Bug#10164)
1069
2b56b87e
JD
10702011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1071
1072 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1073
1074 * xterm.c (handle_one_xevent): Only set async_visible and friends
1075 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1076 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1077 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1078
dbf31225
PE
10792011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1082 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1083 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1084 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1085 All uses changed to use GCPRO1 etc.
1086 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1087 Revert to old implementation (i.e., before 2011-03-11).
1088
1305621b
YM
10892011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1090
1091 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1092 of scroll runs so as to avoid assigning disabled bogus rows and
1093 unnecessary graphics copy operations.
1094
8c9afb46
EZ
10952011-11-27 Eli Zaretskii <eliz@gnu.org>
1096
1097 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1098 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1099 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1100 (malloc, free, realloc, calloc): Redirect to e_* only when
1101 compiling Emacs.
1102
1103 * lisp.h (GCTYPEBITS): Move before first use.
1104 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1105 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1106 this macro definition.
1107
1108 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1109 _MSC_VER.
1110
54e9e3bf
JD
11112011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1112
6d5eb5b0
SM
1113 * gtkutil.c (xg_create_frame_widgets):
1114 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1115 present with Gtk+ 2.0.
1116
83aca1cb
PE
11172011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1118
1119 * fileio.c (Finsert_file_contents): Undo previous change; see
1120 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1121
5b76caa4
PE
11222011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 Rename locals to avoid shadowing.
1125 * fileio.c (Finsert_file_contents):
1126 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1127 * process.c (wait_reading_process_output):
1128 Rename inner 'proc' to 'p' to avoid shadowing.
1129 Indent for consistency with usual Emacs style.
1130
8c535114
EZ
11312011-11-25 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (redisplay_window): If cursor row is not fully visible
1134 after recentering, and scroll-conservatively is set to a large
1135 number, scroll window by a few more lines to make the cursor fully
1136 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1137 (start_display): Don't move to the next line if the display should
1138 start at a newline that is part of a display vector or an overlay
1139 string. (Bug#10119)
8c535114 1140
fa4fdb5c
JL
11412011-11-24 Juri Linkov <juri@jurta.org>
1142
1143 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1144 after the `MagickPingImage' call. (Bug#10112)
1145
90ec88df
CY
11462011-11-23 Chong Yidong <cyd@gnu.org>
1147
1148 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1149
56e2e794
MR
11502011-11-23 Martin Rudalics <rudalics@gmx.at>
1151
1152 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1153 making another buffer current. (Bug#10114)
1154
b6e64c41
GM
11552011-11-23 Glenn Morris <rgm@gnu.org>
1156
1157 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1158
6b21de18
CY
11592011-11-23 Chong Yidong <cyd@gnu.org>
1160
1161 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1162 using it (Bug#5984).
1163
b12cd789
EZ
11642011-11-22 Eli Zaretskii <eliz@gnu.org>
1165
1166 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1167 and header-lines, as they don't have one computed for them.
1168 (Bug#10098)
1169
1170 * .gdbinit (prow): Make displayed values more self-explaining.
1171 Add row's hash code.
1172
261b6fd4
LMI
11732011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1174
1175 * process.c (wait_reading_process_output): Fix asynchrounous
1176 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1177 (wait_reading_process_output): Add comment and URL.
261b6fd4 1178
e7cfd277
JD
11792011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1182
a9b9b7f5
CY
11832011-11-21 Chong Yidong <cyd@gnu.org>
1184
1185 * window.c (Fnext_window, Fprevious_window): Doc fix.
1186
b0d15b4f
SM
11872011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1188
1189 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1190
fe7a3057
JB
11912011-11-20 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1194
d2999b1a
MR
11952011-11-20 Martin Rudalics <rudalics@gmx.at>
1196
1197 * window.c (Fset_window_combination_limit): Rename argument
1198 STATUS to LIMIT.
1199 (Vwindow_combination_limit): Remove "status" from doc-string.
1200
d5ff9cd0
AS
12012011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1202
1203 * m/ibms390.h: Remove.
1204 * m/ibms390x.h: Don't include "ibms390.h".
1205
a5bb9bd3
SM
12062011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1207
1208 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1209 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1210
cd1181db
JB
12112011-11-20 Juanma Barranquero <lekktu@gmail.com>
1212
1213 * casetab.c (Fset_case_table):
1214 * charset.c (Fcharset_after): Fix typos.
1215
615a3b8d 12162011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1217
17e845af
PE
1218 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1219 Otherwise, valgrind does not work on some platforms.
1220 Problem reported by Andreas Schwab in
6a0bf43d
PE
1221 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1222 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1223 is set, removing the need for VIRT_ADDRESS_VARIES.
1224 (PURE_P): Use a more-efficient implementation that needs just one
1225 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1226 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1227 to 4 (xorl, subq, cmpq, setbe).
1228 * alloc.c (pure): Always extern now, since that's the
1229 VIRT_ADDR_VARIES behavior.
1230 (PURE_POINTER_P): Use a single comparison, not two, for
1231 consistency with the new puresize.h.
1232 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1233 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1234 Remove VIRT_ADDR_VARIES no longer needed.
1235
f8fe6f96
EZ
12362011-11-19 Eli Zaretskii <eliz@gnu.org>
1237
1238 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1239 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1240 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1241 behave as if the cursor position were at the window margin.
1242
1243 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1244 and the cursor position is out of bounds, behave as if the cursor
1245 position were at the window margin. (Bug#10075)
1246
df05a53c
CY
12472011-11-18 Chong Yidong <cyd@gnu.org>
1248
1249 * window.c (Fwindow_combination_limit): Make first argument
1250 non-optional, since it is meaningless for live windows like the
1251 selected window.
1252
2071918e
DA
12532011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1254
1255 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1256
b50a28de
SM
12572011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1258
1259 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1260 (graft_intervals_into_buffer): Simplify.
1261
015137db
EZ
12622011-11-18 Eli Zaretskii <eliz@gnu.org>
1263
1264 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1265 hash values of the two rows.
1266 (copy_row_except_pointers): Preserve the used[] arrays and the
1267 hash values of the two rows. (Bug#10035)
68c95424 1268 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1269
1270 * xdisp.c (row_hash): New function, body extracted from
1271 compute_line_metrics.
1272 (compute_line_metrics): Call row_hash, instead of computing the
1273 hash code inline.
1274
1275 * dispnew.c (verify_row_hash): Call row_hash for computing the
1276 hash code of a row, instead of duplicating code from xdisp.c.
1277
1278 * dispextern.h (row_hash): Add prototype.
1279
a2addb04
TH
12802011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1281
1282 * frame.c (delete_frame): Don't delete the terminal when the last
1283 X frame is closed if emacs is built with GTK toolkit.
1284
df85d315
JB
12852011-11-17 Juanma Barranquero <lekktu@gmail.com>
1286
1287 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1288
a0c2d0ae
MR
12892011-11-17 Martin Rudalics <rudalics@gmx.at>
1290
1291 * window.c (Vwindow_splits): Rename to
1292 Vwindow_combination_resize. Suggested by Juri Linkov.
1293 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1294 of Vwindow_splits.
1295
58179cce
JB
12962011-11-16 Juanma Barranquero <lekktu@gmail.com>
1297
7877f373
JB
1298 * nsfns.m (Fns_font_name):
1299 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1300
b6f67890
MR
13012011-11-16 Martin Rudalics <rudalics@gmx.at>
1302
1303 * window.h (window): Rename slot "nest" to "combination_limit".
1304 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1305 (Fset_window_nest): Rename to Fset_window_combination_limit.
1306 (Vwindow_nest): Rename to Vwindow_combination_limit.
1307 (recombine_windows, make_parent_window, make_window)
1308 (Fsplit_window_internal, saved_window)
1309 (Fset_window_configuration, save_window_save): Rename all
1310 occurrences of window_nest to window_combination_limit.
1311
c7015153
JB
13122011-11-15 Juanma Barranquero <lekktu@gmail.com>
1313
1314 * image.c (imagemagick_load_image): Fix typo.
1315
322ad6ec
EZ
13162011-11-14 Eli Zaretskii <eliz@gnu.org>
1317
1318 * xdisp.c (display_line): Move the call to
1319 highlight_trailing_whitespace before the call to
1320 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1321 faces of all the glyphs to compute ROW's hash value.
1322 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1323
f067b8ec
JB
13242011-11-14 Juanma Barranquero <lekktu@gmail.com>
1325
1326 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1327 just return (bug#10044).
1328
1e5b2111
EZ
13292011-11-12 Eli Zaretskii <eliz@gnu.org>
1330
7ef3cbd5
EZ
1331 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1332 with user-defined heap size. Bump the default size of the temacs
1333 heap to 27MB, to avoid memory warning when running temacs.
1334 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1335
1e5b2111
EZ
1336 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1337 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1338 (verify_row_hash) [XASSERTS]: New function.
1339 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1340 that the hash value of glyph rows is correct.
1e5b2111 1341
89d61221
MR
13422011-11-12 Martin Rudalics <rudalics@gmx.at>
1343
1344 * window.h (window): Remove splits slot.
1345 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1346 (Fdelete_other_windows_internal, make_parent_window)
1347 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1348 (Fset_window_configuration, save_window_save): Don't deal with
1349 split status of windows.
1350 (saved_window): Remove splits slot.
1351 (Vwindow_splits): Rewrite doc-string.
1352
97f18cc8
JD
13532011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1354
1355 * xfns.c (unwind_create_frame):
1356 * nsfns.m (unwind_create_frame):
1357 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1358 Vframe_list (Bug#9999).
1359
22a648b4
DA
13602011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1361
0b381c7e 1362 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1363
659afede
KH
13642011-11-11 Kenichi Handa <handa@m17n.org>
1365
1366 * callproc.c (Fcall_process): Set the member dst_multibyte of
1367 process_coding.
1368
9ac0394b
KH
13692011-11-11 Johan Bockgård <bojohan@gnu.org>
1370
1371 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1372 avoid a crash (bug#9496).
1373
2fbdc249
CY
13742011-11-09 Chong Yidong <cyd@gnu.org>
1375
1376 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1377 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1378
ac6b1f81
PE
13792011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1382
09db192c
PE
13832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 Avoid some portability problems by eschewing 'extern inline' functions.
1386 The trivial performance wins aren't worth the portability hassles; see
1387 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1388 et seq.
1389 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1390 (window_box_width, window_box_left, window_box_left_offset)
1391 (window_box_right, window_box_right_offset): Undo previous change,
1392 by removing the "extern"s.
1393 * intervals.c (adjust_intervals_for_insertion)
1394 (adjust_intervals_for_deletion): Undo previous change,
1395 making these static again.
1396 (offset_intervals, temp_set_point_both, temp_set_point)
1397 (copy_intervals_to_string): No longer inline.
1398 * xdisp.c (window_text_bottom_y, window_box_width)
1399 (window_box_height, window_box_left_offset)
1400 (window_box_right_offset, window_box_left, window_box_right)
1401 (window_box): No longer inline.
1402
105216ed
CY
14032011-11-08 Chong Yidong <cyd@gnu.org>
1404
1405 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1406 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1407 Signal an error if not a live window.
105216ed
CY
1408 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1409 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1410
ae9e237f
JB
14112011-11-07 Juanma Barranquero <lekktu@gmail.com>
1412
1413 * lisp.h (syms_of_abbrev): Remove declaration.
1414 Reported by CHENG Gao <chenggao@royau.me>.
1415
c7aa8333
EZ
14162011-11-07 Eli Zaretskii <eliz@gnu.org>
1417
1418 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1419 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1420 of temacs in GUI mode.
1421
be7f5545
MR
14222011-11-07 Martin Rudalics <rudalics@gmx.at>
1423
1424 * window.h: Declare delete_all_child_windows instead of
1425 delete_all_subwindows.
1426 * window.c (Fwindow_nest, Fset_window_nest)
1427 (Fset_window_new_total, Fset_window_new_normal)
1428 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1429 (delete_all_subwindows): Rename to delete_all_child_windows.
1430 (Fdelete_other_windows_internal, Fset_window_configuration):
1431 Call delete_all_child_windows instead of delete_all_subwindows.
1432 * frame.c (delete_frame): Call delete_all_child_windows instead
1433 of delete_all_subwindows.
1434
ca78dc43
PE
14352011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1438 This is also needed for porting to any host where GC_MARK_STACK is
1439 not GC_MAKE_GCPROS_NOOPS.
1440 (which_symbols): Use it.
1441
a0241d01
KH
14422011-11-07 Kenichi Handa <handa@m17n.org>
1443
1444 * coding.c (coding_set_destination): Check coding->src_pos only
1445 when coding->src_object is a buffer (bug#9910).
1446
1447 * process.c (send_process): Set the member src_multibyte of coding
1448 to 0 (bug#9911) when sending a unibyte text.
1449
1450 * callproc.c (Fcall_process): Set the member src_multibyte of
1451 process_coding to 0 (bug#9912).
1452
a64bfdfa 14532011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1454
1455 * xmenu.c (cleanup_widget_value_tree): New function.
1456 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1457 calling free_menubar_widget_value_tree directly (Bug#9830).
1458
cb41b32a
PE
14592011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 Fix some portability problems with 'inline'.
1462 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1463 (window_box_width, window_box_left, window_box_left_offset)
1464 (window_box_right, window_box_right_offset): Declare extern.
1465 Otherwise, these inline functions do not conform to C99 and
1466 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1467 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1468 * intervals.c (adjust_intervals_for_insertion)
1469 (adjust_intervals_for_deletion): Now extern, because otherwise the
1470 extern inline functions 'offset_intervals' couldn't refer to it.
1471 (static_offset_intervals): Remove.
1472 (offset_intervals): Rewrite using the old contents of
1473 static_offset_intervals. The old version didn't conform to C99
1474 because an extern inline function contained a reference to an
1475 identifier with static linkage.
1476
b7041366
AS
14772011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1478
1479 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1480 GC.
1481
88a37c4d
EZ
14822011-11-06 Eli Zaretskii <eliz@gnu.org>
1483
1484 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1485 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1486 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1487 return Qleft_to_right.
1488
49745b39
CY
14892011-11-06 Chong Yidong <cyd@gnu.org>
1490
1491 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1492 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1493 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1494 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1495 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1496 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1497 (Fwindow_vscroll): Doc fix.
1498 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1499 argument, since it makes no sense to pass a live window and for
1500 consistency with window-child.
1501
1f05cd82
CS
15022011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1503
1504 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1505 support MSVC.
1506
22610910
JR
15072011-11-05 Jason Rumney <jasonr@gnu.org>
1508
1509 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1510 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1511 fonts (Bug#6029).
1512 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1513 bitwise arithmetic preventing use of unicode-sip and non-truetype
1514 opentype fonts.
1515
a06776b2
EZ
15162011-11-05 Eli Zaretskii <eliz@gnu.org>
1517
3ad924ba
EZ
1518 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1519 "emacs"-only part.
1520
a06776b2
EZ
1521 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1522 initialization code to keep similarity to xfns.c after changes
1523 from 2011-11-05.
1524
c9e7db78
JD
15252011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1526
a97f8f3f
JD
1527 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1528 (unwind_create_frame): New function (Bug#9943).
1529 (Fx_create_frame): Restructure code to be more similar to the one in
1530 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1531 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1532 Move terminal->reference_count++ just before making the frame official
1533 (Bug#9943).
1534
1535 * nsterm.m (x_free_frame_resources): New function.
1536 (x_destroy_window): Move code to x_free_frame_resources.
1537
c9e7db78 1538 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1539 (Fx_create_frame, x_create_tip_frame):
1540 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1541 official. Move initialization of image_cache_refcount and
1542 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1543
a6fc3b5c
EZ
15442011-11-05 Eli Zaretskii <eliz@gnu.org>
1545
1546 Support MSVC build with newer versions of Visual Studio.
1547 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1548 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1549 nt/gmake.defs.
1550
1551 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1552 which are not supported by MSVC.
1553 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1554 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1555 bitfields.
1556 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1557 types in bitfields.
1558 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1559
1560 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1561
58179cce 15622011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1563
1564 Support MSVC build with newer versions of Visual Studio.
1565 * w32.c: Don't include w32api.h for MSVC.
1566 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1567
1568 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1569 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1570 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1571 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1572 e_* cousins.
1573 (alloca) [_MSC_VER]: Define to _alloca.
1574
1575 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1576
1577 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1578
a58c13ed
EZ
15792011-11-04 Eli Zaretskii <eliz@gnu.org>
1580
1581 * xdisp.c (note_mouse_highlight): If either of
1582 previous/next-single-property-change returns nil, treat that as
1583 the beginning or the end of the buffer. (Bug#9955)
1584
fe0b6370
JD
15852011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1586
a58c13ed 1587 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1588 label is not null (Bug#9951).
1589 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1590 may be NULL.
1591
89bd5ee1
EZ
15922011-11-04 Eli Zaretskii <eliz@gnu.org>
1593
1594 * window.c (Fwindow_body_size): Mention in the doc string that the
1595 return value is in frame's canonical units. (Bug#9949)
1596
84c3edb9
EZ
15972011-11-03 Eli Zaretskii <eliz@gnu.org>
1598
4e2fb5c7
EZ
1599 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1600
84c3edb9 1601 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1602 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1603 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1604
bc17a887
EZ
16052011-11-01 Eli Zaretskii <eliz@gnu.org>
1606
1607 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1608 Don't stop backward scan on the continuation glyph, even though
1609 its CHARPOS is positive.
6d5eb5b0
SM
1610 (mouse_face_from_buffer_pos, note_mouse_highlight):
1611 Rename cover_string to disp_string.
bc17a887 1612
4ee88440
MR
16132011-11-01 Martin Rudalics <rudalics@gmx.at>
1614
1615 * window.c (temp_output_buffer_show): Don't use
1616 Vtemp_buffer_show_specifiers.
1617 (Vtemp_buffer_show_specifiers): Remove unused variable.
1618
c2ff3c02
EZ
16192011-10-30 Eli Zaretskii <eliz@gnu.org>
1620
1621 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1622 past the beginning of the current glyph matrix.
1623
58179cce 16242011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1625
1626 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1627 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1628 HAVE_GTK3 (Bug#9869).
b77a6a7f 1629
3b574623
JD
1630 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1631 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1632
b77a6a7f
JD
1633 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1634
1635 * xterm.c: Declare x_handle_net_wm_state to return int.
1636 (handle_one_xevent): Check if we are iconified but don't have
1637 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1638 (get_current_wm_state): Return non-zero if not hidden,
1639 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1640 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1641 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1642 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1643
196e41e4
PE
16442011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1647 so that this new function doesn't get optimized away by a
1648 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1649
021f2e1a
AS
16502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1651
1652 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1653
8b058d44
EZ
16542011-10-29 Eli Zaretskii <eliz@gnu.org>
1655
1656 Fix the `xbytecode' command.
1657 * .gdbinit (xprintbytestr): New command.
b50a28de 1658 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1659 (xbytecode): Print the byte-code string as well.
1660
4452fb80
EZ
16612011-10-29 Kim Storm <storm@cua.dk>
1662
8b058d44
EZ
1663 * alloc.c (which_symbols): New function.
1664
21b72067
AS
16652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1666
1667 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1668 line. (Bug#9903)
1669
83ed7b5c
GM
16702011-10-29 Glenn Morris <rgm@gnu.org>
1671
1672 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1673 Not clear what it was for, and it causes various bugs. (Bug#9839)
1674
5a7a728b
EZ
16752011-10-28 Eli Zaretskii <eliz@gnu.org>
1676
1677 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1678 possible random value that matches one of those tested as
1679 condition to clear the mouse face.
1680
d3d0842f
CY
16812011-10-28 Chong Yidong <cyd@gnu.org>
1682
1683 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1684
31b39d13
DN
16852011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1686
1687 * window.c (make_window): Initialize phys_cursor_on_p.
1688
9aba6043
SM
16892011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1690
1691 * lisp.h (struct Lisp_Symbol): Update comments.
1692
c20992f4
JB
16932011-10-28 Juanma Barranquero <lekktu@gmail.com>
1694
1695 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1696
db4f02f2
EZ
16972011-10-28 Eli Zaretskii <eliz@gnu.org>
1698
1699 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1700 <oslsachem@gmail.com> for helping to debug this.
1701
1702 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1703 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1704 (g_b_init_get_glyph_outline_w): New static variables.
1705 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1706 (GetGlyphOutlineW_Proc): New typedefs.
1707 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1708 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1709 New functions.
1710 (w32font_open_internal, compute_metrics):
1711 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1712 instead of calling the "wide" APIs directly.
1713
1714 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1715
1716 * w32.h (syms_of_w32font): Add prototype.
1717
87e68db4
JB
17182011-10-27 Juanma Barranquero <lekktu@gmail.com>
1719
1720 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1721 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1722 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1723 (Fmove_to_window_line): Doc fix.
1724
435c1d67
CY
17252011-10-27 Chong Yidong <cyd@gnu.org>
1726
1727 * process.c (make_process): Set gnutls_state to NULL.
1728
1729 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1730 non-NULL, regardless of GNUTLS_INITSTAGE.
1731 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1732 an error. Set process slots as soon as we allocate them.
1733
1734 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1735
9c6c6f49
CY
17362011-10-27 Chong Yidong <cyd@gnu.org>
1737
9aba6043
SM
1738 * gnutls.c (emacs_gnutls_deinit): New function.
1739 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1740 (Fgnutls_deinit, Fgnutls_boot): Use it.
1741
1742 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1743 (deactivate_process): Call emacs_gnutls_deinit.
1744
657d08d3
JB
17452011-10-27 Juanma Barranquero <lekktu@gmail.com>
1746
1747 * image.c (x_create_x_image_and_pixmap):
1748 * w32.c (sys_rename, w32_delayed_load):
1749 * w32font.c (fill_in_logfont):
1750 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1751
5430d399
JB
17522011-10-26 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * w32fns.c (w32_default_color_map): New function,
1755 extracted from Fw32_default_color_map.
a7ef684b 1756 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1757
fe0055fa
PE
17582011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1761
e6346438
SM
17622011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1763
1764 * keyboard.c (test_undefined): New function (bug#9751).
1765 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1766
e112cc37
ET
17672011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1768
1769 * sysdep.c (init_sys_modes): Fix the check for the controlling
1770 terminal (Bug#6649).
1771
7b5d6677
EZ
17722011-10-20 Eli Zaretskii <eliz@gnu.org>
1773
1774 * dispextern.h (struct bidi_it): New member next_en_type.
1775
1776 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1777 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1778 current character, check also for next_en_type being WEAK_EN.
1779 (bidi_resolve_weak): Don't enter the expensive loop if the current
1780 position is before next_en_pos. Record the bidi type of the first
1781 non-ET, non-BN character we find, in addition to its position.
1782 (bidi_level_of_next_char): Invalidate next_en_type when
1783 next_en_pos is over-stepped.
1784
7da0b018
PE
17852011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1788 * editfns.c: Rewrite current-time-zone so that it invokes
1789 the equivalent of (format-time-string "%Z") to get the time zone name.
1790 This fixes a bug when the time zone name contains characters that
1791 need converting from the system time locale to Emacs internal format.
1792 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1793 that patch fixed format-time-string to do the conversion, but
1794 I forgot to fix current-time-zone.
1795 (format_time_string): New function, containing most of
1796 what Fformat_time_string used to contain.
1797 (Fformat_time_string): Rewrite in terms of format_time_string.
1798 This doesn't change this function's behavior.
1799 (current-time-zone): Rewrite to use format_time_string.
1800 This fixes the bug reported by Michael Schierl in
1801 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1802 Jason Rumney's 2007-06-07 change worked around this bug, but
1803 didn't fix it.
1804 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1805
8547b010
EZ
18062011-10-19 Eli Zaretskii <eliz@gnu.org>
1807
1808 * xdisp.c (start_display): If the character at POS is displayed
1809 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1810 (try_window_reusing_current_matrix): If a line ends in a display
1811 vector or the next line starts in a display vector, continue
1812 redrawing the window even though the character position of
1813 start_row was reached.
8547b010
EZ
1814 (Bug#9771, part 2)
1815
4e948d15
CY
18162011-10-18 Chong Yidong <cyd@gnu.org>
1817
1818 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1819 with nobreak-char-display too.
1820
4787455f
EZ
18212011-10-18 Eli Zaretskii <eliz@gnu.org>
1822
1823 Fix part 3 of bug#9771.
1824 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1825 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1826 non-neutral characters if the current character is a paragraph
1827 separator (a.k.a. Newline). This avoids running the same
1828 expensive loop twice, once when we consume the preceding newline
1829 and the other time when the line actually needs to be displayed.
1830 Avoid the loop when we see neutrals on the base embedding level
1831 following a character whose directionality is the same as the
1832 paragraph's. This avoids running the expensive loop when a line
1833 ends in a long sequence of neutrals, like control characters.
1834 Add assertion against STRONG_AL type. Slightly rearrange code
1835 that determines the type of a neutral given the first non-neutral
1836 that follows it.
1837 (bidi_level_of_next_char): Set next_en_pos to zero when
1838 invalidating its info.
1839
2c91f553
EZ
18402011-10-17 Eli Zaretskii <eliz@gnu.org>
1841
1842 * xdisp.c (push_display_prop): Determine whether to record string
1843 or buffer position by IT->string, not by IT->method. Allow
1844 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1845 (move_it_vertically_backward): Don't look for character position
1846 immediately after the newline when in a continuation line.
1847 (Bug#9771, part 1)
2c91f553 1848
c7b08b0d
MR
18492011-10-15 Martin Rudalics <rudalics@gmx.at>
1850
1851 * window.c (coordinates_in_window): Rewrite and delabelize
1852 vertical border check. (Bug#5357) (Bug#9618)
1853
6b02f655
SM
18542011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1855
1856 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1857 errors in XSetWindowBorder (bug#9310).
1858
81d40c92
DA
18592011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1860
1861 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1862 avoid crash when xmalloc overrun checking is enabled.
1863
d4172c3b
EZ
18642011-10-13 Eli Zaretskii <eliz@gnu.org>
1865
1866 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1867 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1868 cursor motion with <left> and <right> arrow keys.
1869
1870 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1871 some callers set that themselves.
1872
b00eea75
EZ
18732011-10-12 Eli Zaretskii <eliz@gnu.org>
1874
1875 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1876 display string and the previous row comes from the same string and
1877 is empty. (Bug#9739) (Bug#9738)
1878
8fe012c4
SM
18792011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1880
1881 * doc.c (get_doc_string): Encode file name (bug#9735).
1882
0074aef2
EZ
18832011-10-12 Eli Zaretskii <eliz@gnu.org>
1884
79beb178
EZ
1885 * bidi.c (bidi_level_of_next_char):
1886 * xdisp.c (get_visually_first_element): Remove old incorrect
1887 comments regarding the Unicode Line Separator character.
1888
0074aef2
EZ
1889 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1890
6e4b3fbe
DA
18912011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1892
1893 * alloc.c (Fgc_status): Do not access beyond zombies array
1894 boundary if nzombies > MAX_ZOMBIES.
1895 * alloc.c (dump_zombies): Add missing format specifier.
1896
0324f3af
PE
18972011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1898
b5525cac
PE
1899 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1900 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1901
0324f3af
PE
1902 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1903 Some packages use them to denote characters with modifiers.
1904
e9b5f888
AS
19052011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1906
1907 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1908 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1909 matching a pp-number. Rename parameter var to var1.
1910
127827c0
SM
19112011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1912
1913 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1914
c8fd3bd0
GM
19152011-10-08 Glenn Morris <rgm@gnu.org>
1916
1917 * callint.c (Fcall_interactively): Give a more explicit error for the
1918 'c' case with a non-character input. (Bug#8479)
1919
352ec8ff
EZ
19202011-10-08 Eli Zaretskii <eliz@gnu.org>
1921
03669ccb
EZ
1922 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1923 lines.
7061c986
EZ
1924 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1925 lines that are hscrolled on the left.
03669ccb 1926
352ec8ff
EZ
1927 * dispnew.c (buffer_posn_from_coords): Account for a possible
1928 presence of header-line. (Bug#4426)
1929
a66cfb1c
SM
19302011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1931
6b02f655
SM
1932 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1933 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1934
7c5ee88e
PE
19352011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1938 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1939 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1940 this makes Emacs dump core during garbage collection on rare
1941 occasions. sizeof is obviously inferior to offsetof here, so
1942 stick with offsetof.
1943 (GC_POINTER_ALIGNMENT): New macro.
1944 (mark_memory): Omit 3rd (offset) arg; caller changed.
1945 Don't assume EMACS_INT alignment is the same as pointer alignment.
1946
df1bbe5b
SM
19472011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1948
1949 * keyboard.c (read_key_sequence_remapped): New var.
1950 (read_key_sequence): Compute remapping in the right buffer.
1951 (command_loop_1): Use read_key_sequence's remapping directly.
1952
51553db6
SM
19532011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1954
32c1fffd
SM
1955 * dired.c (file_name_completion): Don't expand file name.
1956 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1957 before checking file name handler.
1958
51553db6
SM
1959 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1960 they've been requested explicitly (bug#9591).
1961
b6bd1599 19622011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1963
1964 * keymap.c (Fsingle_key_description): Use make_specified_string
1965 instead of build_string to build string from push_key_description.
1966 (Bug#5193)
1967
f701dc2a
PE
19682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1969
4222c55d
PE
1970 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1971 This fixes a Y2038 bug on 64-bit hosts.
1972 * buffer.c (reset_buffer):
1973 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1974 (Fclear_buffer_auto_save_failure):
1975 Use 0, not -1, to represent an unset failure time, since time_t
1976 might not be signed.
1977
f701dc2a
PE
1978 Remove dependency on glibc malloc internals.
1979 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1980 Move back here from lisp.h, but with their new implementations.
1981 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1982 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1983 * charset.c (charset_table_init): New static var.
1984 (syms_of_charset): Use it instead of xmalloc. This removes a
1985 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1986 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1987 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1988 Move back to alloc.c.
1989 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1990 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1991
9ceebf39
JD
19922011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1993
1994 * nsterm.m (windowDidResize): Call x_set_window_size only when
1995 ns_in_resize is true. Otherwise set pixelwidth/height and
1996 call change_frame_size (Bug#9628).
1997
cb993c58
PE
19982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1999
3930c88b
PE
2000 Port --enable-checking=all to Fedora 14 x86-64.
2001 * charset.c (syms_of_charset): Also account for glibc malloc's
2002 internal overhead when calculating the initial malloc maximum.
2003
cb993c58
PE
2004 Port --enable-checking=all to Fedora 14 x86.
2005 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2006 Move to lisp.h.
2007 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2008 (overrun_check_realloc, overrun_check_free):
2009 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2010 That way, xmalloc returns a properly-aligned pointer even if
2011 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2012 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2013 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2014 into account when calculating the initial malloc maximum.
2015 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2016 Move here from alloc.c, so that charset.c can use it too.
2017 Properly align; the old code wasn't right for common 32-bit hosts
2018 when configured with --enable-checking=all.
2019 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2020 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2021
31bed486
EZ
20222011-09-29 Eli Zaretskii <eliz@gnu.org>
2023
04c70788 2024 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2025 use EDOM.
2026
fbcaa2f3
EZ
20272011-09-28 Eli Zaretskii <eliz@gnu.org>
2028
2029 * xdisp.c (compute_display_string_end): If there's no display
2030 string at CHARPOS, return -1.
2031
2032 * bidi.c (bidi_fetch_char): When compute_display_string_end
2033 returns a negative value, treat the character as a normal
2034 character not covered by a display string. (Bug#9624)
2035
a239d4e9
JB
20362011-09-28 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * lread.c (Fread_from_string): Fix typo in docstring.
2039
88652fd5
EZ
20402011-09-27 Eli Zaretskii <eliz@gnu.org>
2041
2042 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2043 newline, reseat the iterator instead of bidi-iterating there one
2044 character at a time. (Bug#9610)
32c1fffd
SM
2045 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2046 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2047
ed497dd4
AS
20482011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2049
2050 * lread.c (readevalloop): Use correct code for NBSP.
2051 (read1): Likewise. (Bug#9608)
2052
b2bf61aa
MA
20532011-09-25 Michael Albinus <michael.albinus@gmx.de>
2054
2055 * dbusbind.c (Fdbus_register_signal): When service is not
2056 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2057
32bbb17c
GM
20582011-09-25 Glenn Morris <rgm@gnu.org>
2059
2060 * buffer.c (truncate-lines): Doc fix.
2061
94e0933e
CY
20622011-09-24 Chong Yidong <cyd@stupidchicken.com>
2063
2064 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2065 (Fset_window_next_buffers): Doc fix.
2066
cddde921
GM
20672011-09-24 Glenn Morris <rgm@gnu.org>
2068
2069 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2070
1260aef1
PE
20712011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2072
25b4bfa0
PE
2073 Fix minor problems found by static checking.
2074 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2075 * indent.c (Fvertical_motion): Fix == vs = typo.
2076
e3cbd34b
EZ
20772011-09-24 Eli Zaretskii <eliz@gnu.org>
2078
a66cfb1c
SM
2079 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2080 Default value is now t. Doc fix.
6bf7006f 2081
e3cbd34b 2082 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2083 logic when moving up, not only when moving down. Fix the
e3cbd34b 2084 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2085 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2086
2087 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2088 CHARPOS is covered by a display string which includes newlines.
2089 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2090 is covered by a display string with embedded newlines.
2091
a3de0cbd
MA
20922011-09-24 Michael Albinus <michael.albinus@gmx.de>
2093
2094 * dbusbind.c (Fdbus_register_signal): Add match rule to
2095 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2096 (Fdbus_register_method, Vdbus_registered_objects_table):
2097 Fix docstring.
a3de0cbd 2098
b260039d
JM
20992011-09-24 Jim Meyering <meyering@redhat.com>
2100
32c1fffd 2101 do not ignore write error for any output size
b260039d
JM
2102 The previous change was incomplete.
2103 While it makes emacs --batch detect the vast majority of stdout
2104 write failures, errors were still ignored whenever the output size is
2105 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2106 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2107 && echo FAIL: ignored write error
2108 FAIL: ignored write error
2109 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2110 && echo FAIL: ignored write error
2111 FAIL: ignored write error
2112 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2113
8eca8a7c
AS
21142011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2115
2116 * emacs.c (Fkill_emacs): In noninteractive mode exit
2117 non-successfully if a write error occurred on stdout. (Bug#9574)
2118
3341db62
EZ
21192011-09-21 Eli Zaretskii <eliz@gnu.org>
2120
2121 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2122 the xassert test.
2123
2124 * dispextern.h (struct it): Update the comment documenting what
2125 can it->OBJECT be.
2126
8c203dbf
EZ
21272011-09-20 Eli Zaretskii <eliz@gnu.org>
2128
2129 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2130 a display string, extend search for cursor position to end of row.
2131 (find_row_edges): If the row ends in a newline from a display
2132 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2133 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2134 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2135 non-empty line. Fixes confusing cursor motion with arrow keys at
2136 the beginning of a line that starts with whitespace.
8c203dbf 2137
a4824228
LMI
21382011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2139
2140 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2141 (bug#9493).
2142
33ed493b
CY
21432011-09-18 Chong Yidong <cyd@stupidchicken.com>
2144
2145 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2146 boolean (Bug#9154).
2147
56cd55c8
EZ
21482011-09-18 Eli Zaretskii <eliz@gnu.org>
2149
2150 * xdisp.c (display_line): Record maximum and minimum buffer
2151 positions even if no glyphs were produced (e.g., by a zero-width
2152 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2153 buffer positions that will be removed from the glyph row because
2154 they don't fit.
c02dcedf
EZ
2155 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2156 column is beyond frame width: don't subtract 1 "pixel" when
2157 computing width of the stretch.
3e62b7e0
EZ
2158 (reseat_at_next_visible_line_start): Undo the change made on
2159 2011-09-17 that saved paragraph information and restored it after
2160 the call to `reseat'. (Bug#9545)
56cd55c8 2161
5ed99d36 21622011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2163
2164 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2165 and turn window cursor on if cleared (Bug#9415).
2166
5ed99d36 21672011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2168
2169 * search.c (boyer_moore): Take unibyte characters from pattern
2170 literally. (Bug#9458)
2171
9bade7b2
EZ
21722011-09-18 Eli Zaretskii <eliz@gnu.org>
2173
2174 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2175
e5e9d610
PE
21762011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2177
87e4427a
PE
2178 Fix minor problem found by static checking.
2179 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2180 initialized, to pacify gcc -Wuninitialized.
2181
e5e9d610
PE
2182 * fileio.c: Report proper errno when syscall falls.
2183 (Finsert_file_contents): Save and restore errno,
2184 so that report_file_error outputs the correct diagnostic.
2185 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2186
a1674f0b
EZ
21872011-09-18 Eli Zaretskii <eliz@gnu.org>
2188
2189 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2190
fbfb6dd4
EZ
21912011-09-17 Eli Zaretskii <eliz@gnu.org>
2192
2193 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2194 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2195
bb187662
EZ
21962011-09-17 Eli Zaretskii <eliz@gnu.org>
2197
1137e8b8 2198 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2199 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2200
2201 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2202 (bidi_find_paragraph_start): Search back for paragraph beginning
2203 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2204 (bidi_move_to_visually_next): Only trigger paragraph-related
2205 computations when the last character is a newline or at EOB, not
2206 just any NEUTRAL_B. (Bug#9470)
2207
bb187662
EZ
2208 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2209 truncated lines if point is covered by a display string. (Bug#9524)
2210
2e621251
PE
22112011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2214 (cons_to_x_long): New function.
2215 (lisp_data_to_selection_data): Use it. Correct the test for
2216 short-versus-long data; it was negated. Break out of vector
2217 loop, for efficiency, when a long datum is discovered.
2218
91a15bc6
SM
22192011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2220
2221 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2222
b41c3a35
EZ
22232011-09-16 Eli Zaretskii <eliz@gnu.org>
2224
2225 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2226 GCC PR/17406) by declaring this function with external scope.
2227
7812ba2d
PE
22282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2231 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2232
cf7edc2a
AS
22332011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2234
2235 * editfns.c (Fformat): Correctly handle text properties on "%%".
2236
bd01620e
EZ
22372011-09-15 Eli Zaretskii <eliz@gnu.org>
2238
2239 * xterm.c (x_draw_composite_glyph_string_foreground):
2240 * w32term.c (x_draw_composite_glyph_string_foreground):
2241 * term.c (encode_terminal_code):
2242 * composite.c (composition_update_it, get_composition_id):
2243 * xdisp.c (get_next_display_element)
2244 (fill_composite_glyph_string): Add comments about special meaning
2245 of TAB characters in a composition.
2246
a02719a3
PE
22472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2250 This occurs when processing a multibyte format.
2251 Problem reported by Wolfgang Jenker.
a02719a3 2252
72589a3c
JB
22532011-09-15 Johan Bockgård <bojohan@gnu.org>
2254
2255 * xdisp.c (try_cursor_movement): Only check for exact match if
2256 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2257
1c14176c
PE
22582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 Remove unused external symbols.
2261 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2262 * xdisp.c (calc_pixel_width_or_height): Now static.
2263 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2264 * indent.c (check_display_width):
2265 * w32term.c: Fix comment to match code.
2266 * xterm.c, xterm.h (x_catching_errors): Remove.
2267
d2eea5b5
PE
22682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2269
2270 * xselect.c: Use signed conversions more consistently (Bug#9498).
2271 (selection_data_to_lisp_data): Assume incoming selection data are
2272 signed integers, not unsigned. This is to be consistent with
2273 outgoing selection data, which was modified to use signed integers
2274 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2275 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2276 expects long, not unsigned long.
2277
46888499
EZ
22782011-09-14 Eli Zaretskii <eliz@gnu.org>
2279
2280 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2281 computation of loop end. Reported by Johan Bockgård
2282 <bojohan@gnu.org>.
2283
ef8ef9fb
CY
22842011-09-13 Chong Yidong <cyd@stupidchicken.com>
2285
2286 * frame.c (Fother_visible_frames_p): Function deleted.
2287
fa819fed
EZ
22882011-09-12 Eli Zaretskii <eliz@gnu.org>
2289
2290 * indent.c (compute_motion): Process display vector front to back
2291 rather than the other way around. (Bug#2496)
2292
2ba8e008
SM
22932011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2294
2295 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2296
20f53c69
CY
22972011-09-11 Chong Yidong <cyd@stupidchicken.com>
2298
2299 * minibuf.c (Fread_from_minibuffer): Doc fix.
2300
d562d7a4
EZ
23012011-09-11 Eli Zaretskii <eliz@gnu.org>
2302
2303 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2304 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2305
1c4d7f3d
LMI
23062011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2307
2308 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2309 value for non-existent files.
2310
b885bf36
EZ
23112011-09-11 Eli Zaretskii <eliz@gnu.org>
2312
2313 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2314 set its "size" to -1. This will set the modtime_size field of
2315 the corresponding buffer to -1, which is what
2316 verify-visited-file-modtime expects for files that do not exist.
2317 (Bug#9139)
2318
6612f0bf
PE
23192011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2322 here ...
2323 * lisp.h: ... from here. push_key_description is no longer
2324 defined in keyboard.c, so its declaration should not be in
2325 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2326 logically belongs with push_key_description.
2327
dfb3f755
PE
23282011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2329
2330 * buffer.h: Include <sys/types.h> instead of <time.h>.
2331 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2332 Problem reported by Herbert J. Skuhra.
2333
3134906c
LMI
23342011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2335
2336 * xml.c (parse_region): Make the parsing work for
2337 non-comment-starting XML files again (bug#9144).
2338
8d903f4e
AS
23392011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2340
2341 * image.c (gif_load): Fix calculation of bottom and right corner.
2342 (Bug#9468)
2343
80ad64f4
EZ
23442011-09-10 Eli Zaretskii <eliz@gnu.org>
2345
2346 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2347 redisplay in small windows.
2348
208a048d
EZ
23492011-09-09 Eli Zaretskii <eliz@gnu.org>
2350
2351 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2352
9b1c252e
MR
23532011-09-08 Martin Rudalics <rudalics@gmx.at>
2354
2355 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2356 Operate on live windows only.
2357
2949f33b
JB
23582011-09-08 Juanma Barranquero <lekktu@gmail.com>
2359
2360 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2361
e08dcafd
EZ
23622011-09-07 Eli Zaretskii <eliz@gnu.org>
2363
2364 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2365 only under bidi iteration.
2366
115b96bd
JD
23672011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2368
2369 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2370
c8199d0f
PE
23712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2374 Without this fix, the command to link temacs failed due to an
2375 undefined symbol __builtin_isnan. This is because
2376 /usr/include/iso/math_c99.h #defines isnan(x) to
2377 __builtin_isnan(x), but the bundled gcc, which identifies itself
2378 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2379 a __builtin_isnan.
2380 * floatfns.c (isnan): #undef, and then #define to a clone of
2381 what's in data.c.
2382 (Fisnan): Always define, since it's always available now.
2383 (syms_of_floatfns): Always define isnan at the Lisp level.
2384
e39b275c 23852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2386
2387 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2388
b2db44d9 23892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2390
f4af5137 2391 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2392 The previous code assumed that file offsets (off_t values) fit in
2393 EMACS_INT variables, which is not true on typical 32-bit hosts.
2394 The code messed up by falsely reporting buffer overflow in cases
2395 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2396 when "big" contains more than 2**29 bytes, even though this
2397 inserts just one byte and does not overflow the buffer.
2398 (Finsert_file_contents): Store file offsets as off_t
2399 values, not as EMACS_INT values. Check for overflow when
2400 converting between EMACS_INT and off_t. When checking for
2401 buffer overflow or for overlap, take the offsets into account.
2402 Don't use EMACS_INT for small values where int suffices.
2403 When checking for overlap, fix a typo: ZV was used where
2404 ZV_BYTE was intended.
2405 (Fwrite_region): Don't assume off_t fits into 'long'.
2406 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2407
ecfc0a49
MA
24082011-09-05 Michael Albinus <michael.albinus@gmx.de>
2409
2410 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2411
6511acf2 24122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2413
0999621a 2414 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2415
2416 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2417 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2418 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2419 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2420 (modify_event_symbol): Do not assume that the length of
2421 name_alist_or_stem is safe to alloca and fits in int.
2422 (Fexecute_extended_command): Likewise for function name and binding.
2423 (Frecursion_depth): Wrap around reliably on integer overflow.
2424 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2425 since some callers pass EMACS_INT values.
2426 (Fsingle_key_description): Don't crash if symbol name contains more
2427 than MAX_ALLOCA bytes.
2428 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2429 (get_minibuffer): Arg is now EMACS_INT, not int.
2430 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2431 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2432 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2433
2be7d702
PE
2434 * dbusbind.c (signature_cat): New function.
2435 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2436 Do not overrun buffer; instead, report string overflow.
2437
9d1df220
PE
2438 * dispnew.c (add_window_display_history): Don't overrun buffer.
2439 Truncate instead; this is OK since it's just a log.
2440
33ef5c64
PE
2441 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2442 even if the time zone offset is outlandishly large.
2443 Don't mishandle offset == INT_MIN.
2444
66c6fdd5
PE
2445 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2446 when creating daemon; the previous buffer-overflow check was incorrect.
2447
d749b01b
PE
2448 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2449 which has the guts of the old verror function.
2450
b5cd1905
PE
2451 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2452 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2453
6e1a67fb
PE
2454 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2455 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2456 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2457 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2458 length of string rather than counting it via multiple sprintfs;
2459 that's simpler and more reliable.
c21721cc
PE
2460 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2461 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2462 sprintf, in case result does not fit in int.
2463
c57b67fc
PE
2464 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2465 (fontset_from_font): Print it.
2466
8a401434
PE
2467 * frame.c (tty_frame_count): Now printmax_t, not int.
2468 (make_terminal_frame, set_term_frame_name): Print it.
2469 (x_report_frame_params): In X, window IDs are unsigned long,
2470 not signed long, so print them as unsigned.
2471 (validate_x_resource_name): Check for implausibly long names,
2472 and don't assume name length fits in 'int'.
2473 (x_get_resource_string): Don't blindly alloca invocation name;
2474 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2475 not fit in int.
2476
6e1a67fb
PE
2477 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2478 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2479 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2480
0df02bf3
PE
2481 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2482 Use esprintf, not sprintf, in case result does not fit in int.
2483
48e30793
PE
2484 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2485 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2486 it as a large positive number.
2487 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2488 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2489
a66ff6d8
PE
2490 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2491 in case result does not fit in int.
2492
aca216ff
PE
2493 * print.c (float_to_string): Detect width overflow more reliably.
2494 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2495 buffer overrun. Don't assume list length fits in 'int'. Treat
2496 print length of 0 as 0, not as infinity; to be consistent with other
2497 uses of print length in this function. Don't overflow print length
2498 index. Don't assume hash table size fits in 'long', or that
2499 vectorlike size fits in 'unsigned long'.
2500
31c286f7
PE
2501 * process.c (make_process): Use printmax_t, not int, to format
2502 process-name gensyms.
2503
55e5faa1
PE
2504 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2505
80f2e268
PE
2506 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2507 to avoid potential buffer overrun.
2508
670741ab
PE
2509 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2510 if X resource line is longer than 512 bytes.
2511
b7163a50
PE
2512 * xfns.c (x_window): Make sprintf buffer a bit bigger
2513 to avoid potential buffer overrun.
2514
ae58ff1f
PE
2515 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2516
c43c8a6a
PE
2517 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2518
3f8236f4
PE
25192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2520
53e9fe90 2521 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2522 Without these, Emacs silently mishandles large integers sometimes.
2523 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2524 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2525
6511acf2
PE
2526 * xdisp.c (try_window_id): Check Emacs fixnum range before
2527 converting to 'int'.
806add1d 2528
6511acf2 2529 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2530 Check that an Emacs fixnum is in range before assigning it to 'int'.
2531 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2532 values converted from Emacs fixnums.
2533 (Frecenter): Don't wrap around a line count if it is out of 'int'
2534 range; instead, treat it as an extreme value.
2535 (Fset_window_configuration, compare_window_configurations):
2536 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2537
6511acf2
PE
2538 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2539 that can exceed INT_MAX. Check that EMACS_INT value is in range
2540 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2541 (match_limit): Don't assume that a fixnum can fit in 'int'.
2542
6511acf2 2543 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2544 exceed INT_MAX.
2545
6511acf2 2546 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2547 (Fvertical_motion): Don't wrap around LINES values that don't fit
2548 in 'int'. Instead, treat them as extreme values. This is good
2549 enough for windows, which can't have more than INT_MAX lines anyway.
2550
fcb901a7
LMI
25512011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2552
0f2f6b6d
LMI
2553 * Require libxml/parser.h to avoid compilation warning.
2554
fcb901a7
LMI
2555 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2556
2557 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2558 since this reportedly can destroy thread storage.
2559
6e20a0d4
CY
25602011-08-30 Chong Yidong <cyd@stupidchicken.com>
2561
2562 * syntax.c (find_defun_start): Update all cache variables if
2563 exiting early (Bug#9401).
2564
148ae00e
EZ
25652011-08-30 Eli Zaretskii <eliz@gnu.org>
2566
f6cfbd8f
EZ
2567 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2568
148ae00e
EZ
2569 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2570 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2571 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2572
2573 * term.c (tty_append_glyph): New function.
2574 (produce_stretch_glyph): Static function and its prototype deleted.
2575
a66cfb1c
SM
2576 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2577 Add prototypes.
148ae00e 2578
c4a07a4c
PE
25792011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2580
2581 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2582 when checking :margin (Bug#9390).
2583 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2584 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2585 so that the name doesn't mislead. All uses changed.
2586
6bc8cd65
JB
25872011-08-28 Johan Bockgård <bojohan@gnu.org>
2588
2589 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2590 set_tty_hooks.
2591
dca4927e
EZ
25922011-08-27 Eli Zaretskii <eliz@gnu.org>
2593
2594 * xdisp.c (move_it_to): Don't bail out early when reaching
2595 position beyond to_charpos, if we are scanning backwards.
2596 (move_it_vertically_backward): When DY == 0, make sure we get to
2597 the first character in the line after the newline.
2598
f2cad773
PE
25992011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2602 (ccl_driver): Do not generate an out-of-range pointer.
2603 (Fccl_execute_on_string): Remove unnecessary check for
2604 integer overflow, noted by Stefan Monnier in
2605 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2606 Remove a FIXME that didn't need fixing.
2607 Simplify the newly-introduced buffer reallocation code.
2608
0cae2cdb
JB
26092011-08-27 Juanma Barranquero <lekktu@gmail.com>
2610
2611 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2612
5fc295a4 26132011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2614
70c60eb2 2615 Integer and memory overflow issues (Bug#9196).
726e0ab1 2616
d31850da
PE
2617 * doc.c (get_doc_string): Rework so that
2618 get_doc_string_buffer_size is the actual buffer size, rather than
2619 being 1 less than the actual buffer size; this makes xpalloc more
2620 convenient.
2621
a69fbedb
PE
2622 * image.c (x_allocate_bitmap_record, cache_image):
2623 * xselect.c (Fx_register_dnd_atom):
2624 Simplify previous changes by using xpalloc.
2625
fe5c5d37
PE
2626 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2627 since either will do and ptrdiff_t is convenient with xpalloc.
2628
0065d054
PE
2629 * charset.c (charset_table_size)
2630 (struct charset_sort_data.priority): Now ptrdiff_t.
2631 (charset_compare): Don't overflow if priorities differ greatly.
2632 (Fsort_charsets): Don't assume list length fits in int.
2633 Check for size-calculation overflow when allocating sort data.
2634 (syms_of_charset): Allocate an initial charset table that is
2635 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2636
2637 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2638
2639 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2640 The actual value is always <= INT_MAX, and leaving it unsigned made
2641 overflow checking harder.
2642
2643 * dispextern.h (struct glyph_matrix.rows_allocated)
2644 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2645 with xpalloc. The values are still always <= INT_MAX.
2646
2647 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2648
2649 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2650 (SAFE_NALLOCA): New macro.
2651
2652 * region-cache.c (struct boundary.pos, find_cache_boundary)
2653 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2654 (set_cache_region, invalidate_region_cache)
2655 (revalidate_region_cache, know_region_cache, region_cache_forward)
2656 (region_cache_backward, pp_cache):
2657 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2658 so that ptrdiff_t * can be passed to xpalloc.
2659 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2660 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2661 (pp_cache): Don't assume cache_len fits in int.
2662 * region-cache.h: Adjust extern decls to match.
2663
2664 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2665 EMACS_INT, since either will do, for xpalloc.
2666
2667 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2668 (xnmalloc, xnrealloc, xpalloc): New functions.
2669
726e0ab1
PE
2670 * bidi.c (bidi_shelve_header_size): New constant.
2671 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2672 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2673
51f30bc5 2674 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2675 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2676 (overlay_strings):
2677 Don't update size of array until after memory allocation succeeds,
2678 because xmalloc/xrealloc may not return.
0065d054
PE
2679 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2680 now that we have proper integer overflow checking.
2681 (record_overlay_string, overlay_strings): Catch overflows when
2682 calculating size of overlay_str_buf.
726e0ab1 2683
0065d054
PE
2684 * callproc.c (Fcall_process): Check for size overflow when
2685 calculating size of args2.
2686 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2687 Normally we prefer signed values, but sticking with ptrdiff_t would
2688 require adding more-complicated checks.
726e0ab1
PE
2689
2690 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2691 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2692 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2693 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2694
2695 * character.c (Fstring): Check for size-calculation overflow.
2696
2697 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2698 unnecessary integer overflow. Check for size overflow.
2699 (encode_coding_object): Don't update size until xmalloc succeeds.
2700
2701 * composite.c (get_composition_id): Check for overflow in glyph
2702 length calculations.
2703
2704 Integer and memory overflow fixes for display code.
2705 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2706 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2707 (scrolling_window): Check for overflow in size calculations.
2708 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2709 Don't assume glyph table len fits in int.
2710 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2711 (row_table_size): Now ptrdiff_t, not int.
2712 (scrolling_window): Avoid overflow in size calculations.
2713 Don't update size until allocation succeeds.
2714 * fns.c (concat): Check for overflow in size calculations.
2715 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2716 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2717 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2718
2719 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2720 (get_doc_string): Check for size calculation overflow.
2721 Don't update size until allocation succeeds.
2722 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2723 EMACS_INT, where ptrdiff_t will do.
2724 (Fsubstitute_command_keys): Check for string overflow.
2725
2726 * editfns.c (set_time_zone_rule): Don't assume environment length
2727 fits in int.
2728 (message_length): Now ptrdiff_t, not int.
2729 (Fmessage_box): Don't update size until allocation succeeds.
2730 Don't assume message length fits in int.
2731 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2732
0065d054
PE
2733 * emacs.c (main): Do not reallocate argv, since there is a null at
2734 the end that can be overwritten, and this way there's no need to
2735 worry about size-calculation overflow.
2736 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2737
2738 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2739 alloc succeeds.
2740 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2741
2742 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2743 (x_set_scroll_bar_width, x_figure_window_size):
2744 Check for integer overflow.
2745 (x_set_alpha): Do not assume XINT fits in int.
2746
2747 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2748 This is for the members text_lines, text_cols, total_lines, total_cols,
2749 where the system imposes an 'int' limit.
2750
2751 * fringe.c (Fdefine_fringe_bitmap):
2752 Don't update size until alloc works.
2753
2754 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2755 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2756
2757 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2758 Check for size-calculation overflow.
2759 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2760 do, as we prefer signed integers.
2761 (id_to_widget.max_size, id_to_widget.used)
2762 (xg_store_widget_in_map, xg_remove_widget_from_map)
2763 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2764 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2765 Use and return ptrdiff_t, not int.
2766 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2767 * gtkutil.h: Change prototypes to match the above.
2768
2769 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2770 are duplicate now that they've been promoted to lisp.h.
2771 (x_allocate_bitmap_record, x_alloc_image_color)
2772 (make_image_cache, cache_image, xpm_load):
2773 Don't update size until alloc is done.
2774 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2775 (x_detect_edges):
3256efce 2776 Check for size calculation overflow.
726e0ab1
PE
2777 (ct_colors_allocated_max): New constant.
2778 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2779 overflow.
3256efce 2780
726e0ab1
PE
2781 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2782 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2783 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2784 Use ptrdiff_t, not int, to count maps.
2785 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2786 calculations. Don't update size until allocation succeeds.
2787 Redo calculations to avoid overflow.
726e0ab1
PE
2788 * keyboard.h: Change prototypes to match the above.
2789
2790 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2791 to count maps.
2792 (current_minor_maps): Check for size calculation overflow.
2793 * keymap.h: Change prototypes to match the above.
2794
2795 * lread.c (read1, init_obarray): Don't update size until alloc done.
2796
2797 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2798 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2799
726e0ab1
PE
2800 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2801 Now ptrdiff_t, not int.
2802 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2803 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2804
2805 * process.c (Fnetwork_interface_list): Check for overflow
2806 in size calculation.
2807
2808 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2809
2810 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2811 overflow. Don't bother calling xmalloc when xrealloc will do.
2812
2813 * search.c (Freplace_match): Check for size calculation overflow.
2814 (Fset_match_data): Don't assume list lengths fit in 'int'.
2815
2816 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2817 for command line length. Do not attempt to address one before the
2818 beginning of an array, as that's not portable.
2819
2820 * term.c (max_frame_lines): Remove; unused.
2821 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2822 not int.
2823 (encode_terminal_code, calculate_costs): Check for size
2824 calculation overflow.
2825 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2826 table lengths and related sizes. Don't update size until alloc
2827 done. Redo calculations to avoid overflow.
2828 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2829
2830 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2831 subtracting pointers.
2832 (gobble_line): Check for overflow more carefully. Don't update size
2833 until alloc done.
2834
2835 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2836 Don't update size until alloc done.
2837 Redo size calculations to avoid overflow.
2838 Check for size calculation overflow.
0065d054 2839 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2840
2841 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2842 Use ptrdiff_t, not int, for sizes.
2843 (store_mode_line_noprop_char): Don't update size until alloc done.
2844
0065d054
PE
2845 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2846 Use ptrdiff_t, not int, for sizes.
2847 (Finternal_make_lisp_face, cache_face):
2848 Check for size calculation overflow.
2849 (cache_face): Treat size calculation overflows as if they were
2850 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2851
2852 * xfns.c (x_encode_text, x_set_name_internal)
2853 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2854 sizes, since they can exceed INT_MAX in size. Check for size
2855 calculation overflow.
2856
0065d054
PE
2857 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2858 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2859 Don't update size until alloc done.
2860
0065d054 2861 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2862 as sprintf is limited to int lengths.
1d526e2f 2863
252c5ee1
PE
2864 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2865 (X_LONG_MIN): New macros.
864d7ce7
PE
2866 Use them to make the following changes clearer.
2867 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2868 This change doesn't affect the value now, but it may help remind
2869 future maintainers not to raise the value too much later.
2870 (SELECTION_QUANTUM): Remove, replacing with ...
2871 (selection_quantum): ... new function, which avoids overflow.
2872 All uses changed.
2873 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2874 assumption that selection length fits in 'int'.
2875 (x_reply_selection_request, x_handle_selection_request)
2876 (x_get_window_property, receive_incremental_selection)
2877 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2878 (lisp_data_to_selection_data, clean_local_selection_data):
2879 Use ptrdiff_t, not int, to record length of selection.
2880 (x_reply_selection_request, x_get_window_property)
2881 (receive_incremental_selection, x_property_data_to_lisp):
2882 Redo calculations to avoid overflow.
2883 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2884 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2885 something.
2886 (x_get_window_property, receive_incremental_selection)
2887 (lisp_data_to_selection_data, x_property_data_to_lisp):
2888 Check for size-calculation overflow.
2889 (x_get_window_property, receive_incremental_selection)
2890 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2891 Don't store size until memory allocation succeeds.
2892 (x_get_window_property): Plug memory leak on memory exhaustion.
2893 Don't double-block input; malloc is safe here. Don't assume 2**34
2894 - 4 fits in unsigned long. Add an xassert to check
2895 XGetWindowProperty overflow. Be more careful about overflow
2896 calculations, and distinguish size from memory overflow better.
2897 (receive_incremental_selection): When tracing, don't assume
2898 unsigned int is less than INT_MAX.
2899 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2900 harmful) conversions of unsigned short to int.
2901 (lisp_data_to_selection_data): Don't assume that integers
2902 in the range -65535 through -1 fit in an X unsigned short.
2903 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2904 result parameters unless successful. Rely on cons_to_unsigned
2905 to report problems with elements; the old code wasn't right anyway.
2906 (x_check_property_data): Check for int overflow; we cannot use
2907 a wider type due to X limits.
2908 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2909
726e0ab1 2910 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2911
0065d054
PE
2912 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2913 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2914 (x_color_cells): Don't store size until memory allocation succeeds.
2915 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2916 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2917 (x_term_init): Don't assume length fits in int (sprintf is limited
2918 to int size).
bc18e09d 2919
ebfa62c0
PE
2920 Use ptrdiff_t for composition IDs.
2921 * character.c (lisp_string_width):
2922 * composite.c (composition_table_size, n_compositions)
2923 (get_composition_id, composition_gstring_from_id):
2924 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2925 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2926 * window.c (Frecenter):
2927 Use ptrdiff_t, not int, for composition IDs.
2928 * composite.c (get_composition_id): Check for integer overflow.
2929 * composite.h: Adjust prototypes to match the above changes.
2930
d3411f89
PE
2931 Use ptrdiff_t for hash table indexes.
2932 * category.c (hash_get_category_set):
2933 * ccl.c (ccl_driver):
2934 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2935 * coding.c (coding_system_charset_list, detect_coding_system):
2936 * coding.h (struct coding_system.id):
2937 * composite.c (get_composition_id, gstring_lookup_cache):
2938 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2939 * image.c (xpm_get_color_table_h):
2940 * lisp.h (hash_lookup, hash_put):
2941 * minibuf.c (Ftest_completion):
2942 Use ptrdiff_t for hash table indexes, not int (which is too
2943 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2944 32-bit --with-wide-int hosts).
2945
e097a6fa
PE
2946 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2947 Add a FIXME comment about memory leaks.
2948 (syms_of_charset): Don't assume xmalloc returns.
2949
5637687f
PE
2950 Don't assume that stated character widths fit in int.
2951 * character.c (Fchar_width, c_string_width, lisp_string_width):
2952 * character.h (CHAR_WIDTH):
2953 * indent.c (MULTIBYTE_BYTES_WIDTH):
2954 Use sanitize_char_width to avoid undefined and/or bad behavior
2955 with outlandish widths.
a66cfb1c 2956 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2957 now that we have two such functions. All uses changed.
2958 (sanitize_char_width): New inline function.
2959
a2271ba2
PE
2960 Don't assume that tab-width fits in int.
2961 * character.h (sanitize_width): New inline function.
2962 (SANE_TAB_WIDTH): New macro.
2963 (ASCII_CHAR_WIDTH): Use it.
2964 * indent.c (sane_tab_width): Remove. All uses replaced by
2965 SANE_TAB_WIDTH (current_buffer).
2966 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2967
18c52557
PE
2968 * fileio.c: Integer overflow issues with file modes.
2969 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2970
caeeedc1
PE
2971 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2972 Remove unreachable code.
2973 (read_hex, load_charset_map_from_file): Check for integer overflow.
2974
6df6ae42 2975 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2976 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2977 (x_send_scroll_bar_event): Likewise. Check that the size does not
2978 exceed limits imposed by XClientMessageEvent, as well as the usual
2979 ptrdiff_t and size_t limits.
2980
b13995db
PE
2981 * keyboard.c: Overflow, signedness and related fixes.
2982 (make_lispy_movement): Use same integer type in forward decl
2983 that is used in the definition.
2984 (read_key_sequence, keyremap_step):
2985 Change bufsize argument back to int, undoing my 2011-03-30 change.
2986 We prefer signed types, and int is wide enough here.
2987 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2988 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2989 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2990 length, not size_t. Use ptrdiff_t for index, not int.
2991 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2992 possibility of integer overflow.
2993
13464394
PE
2994 Overflow, signedness and related fixes for images.
2995
2996 * dispextern.h (struct it.stack[0].u.image.image_id)
2997 (struct_it.image_id, struct image.id, struct image_cache.size)
2998 (struct image_cache.used, struct image_cache.ref_count):
2999 * gtkutil.c (update_frame_tool_bar):
3000 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3001 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3002 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3003 * nsmenu.m (update_frame_tool_bar):
3004 * xdisp.c (calc_pixel_width_or_height):
3005 * xfns.c (image_cache_refcount):
3006 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3007 on typical 64-bit hosts.
3008
3009 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3010 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3011 Omit unnecessary casts to int.
3012 (parse_image_spec): Check that integers fall into 'int' range
3013 when the callers expect that.
3014 (image_ascent): Redo ascent calculation to avoid int overflow.
3015 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3016 (lookup_image): Remove unnecessary tests.
3017 (xbm_image_p): Locals are now of int, not EMACS_INT,
3018 since parse_image_check makes sure they fit into int.
3019 (png_load, gif_load, svg_load_image):
3020 Prefer int to unsigned where either will do.
3021 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3022 old tiff_error_handler and tiff_warning_handler.
3023 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3024 stack buffer overflows. It uses only the features of vsnprintf
3025 that are common to both POSIX and native Microsoft.
3026 (tiff_error_handler, tiff_warning_handler): Use it.
3027 (tiff_load, gif_load, imagemagick_load_image):
3028 Don't assume :index value fits in 'int'.
3029 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3030 (imagemagick_load_image): Check that crop parameters fit into
3031 the integer types that MagickCropImage accepts. Don't assume
3032 Vimagemagick_render_type has a nonnegative value. Don't assume
3033 size_t fits in 'long'.
3034 (gs_load): Use printmax_t to print the widest integers possible.
3035 Check for integer overflow when computing image height and width.
3036
c11821d4
EZ
30372011-08-26 Eli Zaretskii <eliz@gnu.org>
3038
3039 * xdisp.c (redisplay_window): Don't force window start if point
3040 will be invisible in the resulting window. (Bug#9324)
3041
0c95fcf7
EZ
30422011-08-25 Eli Zaretskii <eliz@gnu.org>
3043
3044 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3045 the display spec is of the form `(space ...)'.
3046 (handle_display_spec): Return the value returned by
3047 handle_single_display_spec, not just 1 or zero.
3048 (handle_single_display_spec): If the display spec is of the form
3049 `(space ...)', and specifies display in the text area, return 2
3050 rather than 1.
fee65a97 3051 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3052 accurately, and prefer exact match for point under bidi.
3053 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3054
3055 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3056 into disp_prop; all users changed.
3057
3058 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3059 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3060 for the text covered by the display property.
3061
e4ed06f1
CY
30622011-08-25 Chong Yidong <cyd@stupidchicken.com>
3063
3064 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3065 Change return value to nil.
3066 (Frecord_buffer): Delete unused function.
3067
f67cdd7f
EZ
30682011-08-24 Eli Zaretskii <eliz@gnu.org>
3069
5980d4c6
EZ
3070 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3071 buffers, return left-to-right.
8610fe8b
EZ
3072 (set_cursor_from_row): Consider candidate row a win if its glyph
3073 represents a newline and point is on that newline. Fixes cursor
3074 positioning on the newline at EOL of R2L text within L2R
3075 paragraph, and vice versa.
3076 (try_cursor_movement): Check continued rows, in addition to
3077 continuation rows. Fixes unwarranted scroll when point enters a
3078 continued line of R2L text within an L2R paragraph, or vice versa.
3079 (cursor_row_p): Consider the case of point being equal to
3080 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3081 from the end of a short line to the beginning of a continued line
3082 of R2L text within L2R paragraph.
3083 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3084 composed characters.
5980d4c6 3085
f67cdd7f
EZ
3086 * bidi.c (bidi_check_type): Use xassert.
3087 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3088 members.
3089
bca633fb
EZ
30902011-08-23 Eli Zaretskii <eliz@gnu.org>
3091
3092 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3093 a character.
3094
4a5885a7
CY
30952011-08-23 Chong Yidong <cyd@stupidchicken.com>
3096
3097 * nsfont.m (ns_otf_to_script): Fix typo.
3098
0902a04e
KH
30992011-08-22 Kenichi Handa <handa@m17n.org>
3100
3101 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3102 extra slot even if the purpose is char-code-property-table.
3103
1a2e6670
EZ
31042011-08-23 Eli Zaretskii <eliz@gnu.org>
3105
8ddde651
EZ
3106 * xdisp.c (redisplay_window): When computing centering_position,
3107 account for the height of the header line. (Bug#8874)
3108
425cc014
EZ
3109 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3110 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3111 candidate is selected by the mouse, and that candidate has a
3112 composed character under the mouse.
3113
1a2e6670
EZ
3114 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3115 coordinates reported by pos-visible-in-window-p for a composed
3116 character in column zero.
3117
8b76d6f8
SM
31182011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3119
3120 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3121
dac347dd
EZ
31222011-08-22 Eli Zaretskii <eliz@gnu.org>
3123
3124 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3125 consider it a hit if to_charpos is anywhere in the range of the
3126 composed buffer positions.
3127
e013fb34
CY
31282011-08-22 Chong Yidong <cyd@stupidchicken.com>
3129
3130 * image.c (gif_load): Don't assume that each subimage has the same
3131 dimensions as the base image. Handle disposal method that is
3132 "undefined" by the gif spec (Bug#9335).
3133
bd1ba3e8
CY
31342011-08-20 Chong Yidong <cyd@stupidchicken.com>
3135
3136 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3137 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3138
54a1215b
EZ
31392011-08-19 Eli Zaretskii <eliz@gnu.org>
3140
823564e5
EZ
3141 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3142 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3143 from an Org mode buffer to a Speedbar frame.
3144
54a1215b
EZ
3145 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3146 a composition, take its buffer position from IT->cmp_it.charpos.
3147 Fixes cursor positioning at the beginning of a line that begins
3148 with a composed character.
3149
9778ebcc
EZ
31502011-08-18 Eli Zaretskii <eliz@gnu.org>
3151
0be6ee06
EZ
3152 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3153 character bidirectional type, use STRONG_L instead. Fixes crashes
3154 in a buffer produced by `describe-categories'.
3155
9778ebcc
EZ
3156 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3157 members before the level stack, so they would be saved and
3158 restored when copying iterator state. Fixes incorrect reordering
3159 around TABs covered by display properties.
3160
156bffbe
AS
31612011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3162
6b02f655 3163 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3164
72ad093b
CY
31652011-08-17 Chong Yidong <cyd@stupidchicken.com>
3166
3167 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3168 (internal_condition_case_2, internal_condition_case_n):
3169 Remove unnecessary aborts (Bug#9081).
72ad093b 3170
35774242
EZ
31712011-08-17 Eli Zaretskii <eliz@gnu.org>
3172
3173 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3174 has no `load' handler, try opening the file locally. (Bug#9311)
3175
db76dd85
KB
31762011-08-16 Ken Brown <kbrown@cornell.edu>
3177
3178 * gmalloc.c: Expand comment.
3179
b215eee5
EZ
31802011-08-16 Eli Zaretskii <eliz@gnu.org>
3181
3182 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3183 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3184
a4579d33
KB
31852011-08-16 Ken Brown <kbrown@cornell.edu>
3186
3187 Fix memory allocation problems in Cygwin build (Bug#9273).
3188
3189 * unexcw.c ( __malloc_initialized): Declare external variable.
3190 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3191
8b76d6f8
SM
3192 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3193 New variables.
a4579d33
KB
3194 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3195 dumped emacs.
3196 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3197 in the static heap.
3198 [CYGWIN] (special_realloc): New function.
3199 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3200 requests to realloc storage in the static heap.
3201
3ebec551
PE
32022011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3203
3204 * bidi.c (bidi_initialize): Remove unused local.
3205
9fd8be00
EZ
32062011-08-15 Eli Zaretskii <eliz@gnu.org>
3207
6b02f655
SM
3208 * bidimirror.h:
3209 * biditype.h: Remove file.
3210 * makefile.w32-in ($(BLD)/bidi.$(O)):
3211 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3212
3213 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3214
3215 * chartab.c: Improve commentary for the uniprop_table API.
3216
32413314
EZ
3217 * bidi.c (bidi_paragraph_init): Support zero value of
3218 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3219 (bidi_initialize): Use uniprop_table instead of including
3220 biditype.h and bidimirror.h.
32413314 3221
9fd8be00
EZ
3222 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3223 coordinates of the iterator when restoring from ppos_it.
3224 (Bug#9296)
3225
5cf2b69b
KH
32262011-08-14 Kenichi Handa <handa@m17n.org>
3227
3228 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3229 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3230
daf17d00
EZ
32312011-08-14 Eli Zaretskii <eliz@gnu.org>
3232
3233 * xdisp.c (move_it_in_display_line_to): Don't invoke
3234 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3235 ppos_it. Fixes vertical cursor motion when line beginning is
3236 covered by an image. (Bug#9296)
3237
08e3161a
JD
32382011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3239
3240 * nsterm.h (ns_run_ascript): Declare.
3241 (NSAPP_DATA2_RUNASSCRIPT): Define.
3242
3243 * nsfns.m (as_script, as_result, as_status): New static variables.
3244 (ns_run_ascript): New function.
5e617bc2 3245 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3246 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3247 the event loop. Get status from as_status (Bug#7276).
3248
3249 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3250 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3251 the event loop (Bug#7276).
3252
a3720aa2
AS
32532011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3254
3255 * gnutls.c (QCgnutls_bootprop_priority)
3256 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3257 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3258 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3259 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3260 (QCgnutls_bootprop_verify_hostname_error)
3261 (QCgnutls_bootprop_callbacks_verify): Rename from
3262 Qgnutls_bootprop_..., all uses changed.
3263
3264 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3265 uses changed.
3266
0a0d27fb
PE
32672011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3268
19d5c50c
PE
3269 * xfaces.c (Qframe_set_background_mode): Now static.
3270 * dispextern.h (Qframe_set_background_mode): Remove decl.
3271
0a0d27fb
PE
3272 * process.c (Fnetwork_interface_info): Declare local only if needed.
3273
377538cb
JD
32742011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3275
3276 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3277 (Fnetwork_interface_list): Allocate in increments of bytes instead
3278 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3279 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3280 sockaddr.
3281 (struct ifflag_def): notrailers is smart on OSX.
3282 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3283 Get hardware address with getifaddrs if available.
3284
08fff70c
EZ
32852011-08-12 Eli Zaretskii <eliz@gnu.org>
3286
3287 * xdisp.c (iterate_out_of_display_property): xassert that
3288 IT->position is set to within IT->object's boundaries. Break from
3289 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3290 when IT->position is set up wrongly due to some bug.
3291 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3292 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3293 entry. Force push_it to save on the stack the current
3294 buffer/string position, to be restored by pop_it. Fix flags in
3295 the iterator structure wrt the object coming from a display
3296 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3297 properties. (Bug#9284)
3298
7be1c708 32992011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3300
7be1c708
CY
3301 * fontset.c (fontset_get_font_group): Add proper type checks.
3302 (Bug#9172)
aac0c6e3 3303
7be1c708 33042011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3305
7be1c708
CY
3306 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3307 and LC_VERSION_MIN_MACOSX.
3308 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3309 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3310
97bb72a6
EZ
33112011-08-08 Eli Zaretskii <eliz@gnu.org>
3312
3313 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3314 no-display-properties-and-no-overlays under bidi display.
3315 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3316 properties and overlays.
97bb72a6 3317
d5617611
CY
33182011-08-08 Chong Yidong <cyd@stupidchicken.com>
3319
37e11a63
CY
3320 * editfns.c (Fset_time_zone_rule): Document relationship with the
3321 setenv function.
3322
d5617611
CY
3323 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3324 the font entity extracted from the cache (Bug#8109).
3325
58872834
CY
33262011-08-07 Chong Yidong <cyd@stupidchicken.com>
3327
3328 * composite.c (autocmp_chars): Don't reset point. That is done by
3329 restore_point_unwind (Bug#5984).
3330
75bfc667
JL
33312011-08-07 Juri Linkov <juri@jurta.org>
3332
3333 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3334 to show the arg `TIME' instead of `TIMEVAL'.
3335
d1410150
EZ
33362011-08-06 Eli Zaretskii <eliz@gnu.org>
3337
3338 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3339 display property strides EOL and includes a newline, as in
3340 longlines-mode. (Bug#9254)
75b771e4
EZ
3341 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3342 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3343
3344 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3345 is non-zero, even if the data buffer is NULL. Fixes a crash in
3346 vertical-motion with longlines-mode. (Bug#9254)
3347
35928349
EZ
33482011-08-05 Eli Zaretskii <eliz@gnu.org>
3349
ec7cc85b
EZ
3350 * bidi.c <bidi_cache_total_alloc>: Now static.
3351 (bidi_initialize): Initialize bidi_cache_total_alloc.
3352
8b76d6f8 3353 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3354 cache. (Bug#9221)
3355
3356 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3357 amount allocated this far in `bidi_cache_total_alloc'.
3358 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3359 non-zero, only free the data buffer without restoring the cache
3360 contents. All callers changed.
3361
3362 * dispextern.h (bidi_unshelve_cache): Update prototype.
3363
3364 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3365 (move_it_in_display_line, move_it_to)
3366 (move_it_vertically_backward, move_it_by_lines): Replace the call
3367 to xfree to an equivalent call to bidi_unshelve_cache.
3368 (move_it_in_display_line_to): Fix logic of returning
412b6358 3369 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3370
e2e2423b
EZ
33712011-08-05 Eli Zaretskii <eliz@gnu.org>
3372
3373 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3374 came from a string character with a `cursor' property. (Bug#9229)
3375
ae9e757a
JD
33762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3377
3378 * Makefile.in (LIB_PTHREAD): New variable.
3379 (LIBES): Add LIB_PTHREAD (Bug#9216).
3380
3381 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3382 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3383
213bd7f2
AS
33842011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3385
6b02f655 3386 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3387
99aaf75f
JD
33882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3389
3390 * xterm.c (x_find_topmost_parent): New function.
3391 (x_set_frame_alpha): Find topmost parent window with
3392 x_find_topmost_parent and set the property there also (bug#9181).
3393 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3394
c74e9d86
PE
33952011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 * callproc.c (Fcall_process): Avoid vfork clobbering
3398 the local vars buffer, coding_systems, current_dir.
3399
640c8776
SM
34002011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3401
3402 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3403
f26d0e4c
PE
34042011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3405
8a10d76c
PE
3406 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3407 so that it is not optimized away.
3408
f26d0e4c
PE
3409 * xdisp.c (compute_display_string_pos): Remove unused local.
3410
55439c61
EZ
34112011-08-02 Eli Zaretskii <eliz@gnu.org>
3412
3413 Fix slow cursor motion and scrolling in large buffers with
3414 selective display, like Org Mode buffers. (Bug#9218)
3415
3416 * dispextern.h (struct bidi_it): New member disp_prop_p.
3417
3418 * xdisp.c: Remove one-slot cache of display string positions.
3419 (compute_display_string_pos): Accept an additional argument
5e617bc2 3420 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3421 for a display string or property. If found, set DISP_PROP_P
3422 non-zero.
3423
3424 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3425 DISP_PROP_P, and pass it to compute_display_string_pos.
3426 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3427 non-zero. All callers of bidi_fetch_char changed.
3428
fb33fa43
SM
34292011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3430
3431 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3432
b099e063
DM
34332010-12-03 Don March <don@ohspite.net>
3434
3435 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3436 last character M-[char] is translated to ESC [char] (bug#7541).
3437
5cc7f7af
KH
34382011-08-02 Kenichi Handa <handa@m17n.org>
3439
d0fffa3f 3440 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3441
3442 * chartab.c (uniprop_table): Make it non-static.
3443
525d5e6e
EZ
34442011-08-01 Eli Zaretskii <eliz@gnu.org>
3445
3446 * xdisp.c (forward_to_next_line_start): Accept additional argument
3447 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3448 on the newline.
3449 (reseat_at_next_visible_line_start): Use the bidi iterator state
3450 returned by forward_to_next_line_start to restore the state of
3451 it->bidi_it after backing up to previous newline. (Bug#9212)
3452
31011111
AS
34532011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3454
3455 * regex.c (re_comp): Protoize.
3456 (re_exec): Fix return type.
3457 (regexec): Fix type of `ret'. (Bug#9203)
3458
476371c4
PE
34592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3460
e5d76069
PE
3461 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3462 This is needed if max-image-size is a floating-point number.
3463
9a79b20c
AS
34642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3465
3466 * print.c (print_object): Print empty symbol as ##.
3467
3468 * lread.c (read1): Read ## as empty symbol.
3469
d8c2fa78
AA
34702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3471
3472 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3473 setting frame foreground color (Bug#9175).
3474 (x_set_background_color): Likewise.
3475
ffe57a7a
AA
3476 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3477 contents (Bug#9176).
3478 (EmacsTooltip -init): Remove bezels and add shadows to
3479 tooltip windows.
3480
bf3492a5
AA
3481 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3482 or scroll bar (Bug#8470).
3483
d55e9c53
AA
3484 * nsfont.m (nsfont_open): Remove assignment to voffset and
3485 unnecessary vars hshink, expand, hd, full_height, min_height.
3486 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3487
3488 * nsterm.h (nsfont_info): Remove voffset field.
3489
d8c2fa78 34902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3491
3492 Implement strike-through and overline on NextStep (Bug#8863).
3493
3494 * nsfont.m (nsfont_open): Use underline position provided by font,
3495 instead of hard-coded value of 2.
3496 (nsfont_draw): Call ns_draw_text_decoration instead.
3497
3498 * nsterm.h: Add declaration for ns_draw_text_decoration.
3499
3500 * nsterm.m (ns_draw_text_decoration): New function for drawing
3501 underline, overline, and strike-through.
3502 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3503 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3504 accommodate underlining, etc.
4843aac3 3505
4cc60b9b
EZ
35062011-07-28 Eli Zaretskii <eliz@gnu.org>
3507
bc7ece87
EZ
3508 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3509 default.
4cc60b9b 3510
476371c4
PE
35112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3512
66606eea
PE
3513 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3514 Without this fix, if a signal arrives just after memory fills up,
3515 'malloc' might be invoked reentrantly.
3516
476371c4
PE
3517 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3518 In other words, assume that every image size is allowed, on non-X
3519 hosts. This assumption is probably wrong, but it lets Emacs compile.
3520
f3fcc40d
AS
35212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3522
3523 * regex.c (re_iswctype): Convert return values to boolean.
3524
350c992f
EZ
35252011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3526
3527 * xdisp.c (compute_display_string_pos): Don't use cached display
3528 string position if the buffer had its restriction changed.
3529 (Bug#9184)
3530
5266b4bb
PE
35312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3534
2573a837 35352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3536
41f55ccd 3537 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3538
39e378da
PE
3539 * bidi.c: Integer size and overflow fixes.
3540 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3541 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3542 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3543 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3544 (bidi_find_other_level_edge):
3545 Use ptrdiff_t instead of EMACS_INT where either will do.
3546 This works better on 32-bit hosts configured --with-wide-int.
3547 (bidi_cache_ensure_space): Check for size-calculation overflow.
3548 Use % rather than repeated addition, for better worst-case speed.
3549 Don't set bidi_cache_size until after xrealloc returns, because it
3550 might not return.
3551 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3552 (bidi_cache_ensure_space): Also check that the bidi cache size
3553 does not exceed that of the largest Lisp string or buffer. See Eli
3554 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3555
5e927815
PE
3556 * alloc.c (__malloc_size_t): Remove.
3557 All uses replaced by size_t. See Andreas Schwab's note
3558 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3559
ca4aa935
PE
3560 * image.c: Improve checking for integer overflow.
3561 (check_image_size): Assume that f is nonnull, since
3562 it is always nonnull in practice. This is one less thing to
3563 worry about when checking for integer overflow later.
3564 (x_check_image_size): New function, which checks for integer
3565 overflow issues inside X.
3566 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3567 This removes the need for a memory_full check.
3568 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3569 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3570 (xbm_read_bitmap_data): Change locals back to 'int', since
3571 their values must fit in 'int'.
3572 (xpm_load_image, png_load, tiff_load):
3573 Invoke x_create_x_image_and_pixmap earlier,
3574 to avoid much needless work if the image is too large.
3575 (tiff_load): Treat overly large images as if
3576 x_create_x_image_and_pixmap failed, not as malloc failures.
3577 (gs_load): Use x_check_image_size.
3578
5f8f9cc2
PE
3579 * gtkutil.c: Omit integer casts.
3580 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3581 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3582
5adf60bc
PE
3583 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3584
c8907a93
PE
3585 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3586 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3587 would wrongly return t on a 64-bit host.
3588
e3c25c68
PE
3589 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3590 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3591 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3592 and therefore cause GCC to emit a bogus diagnostic in some cases.
3593
3f791afe
PE
3594 * image.c: Integer signedness and overflow and related fixes.
3595 This is not an exhaustive set of fixes, but it's time to
3596 record what I've got.
3597 (lookup_pixel_color, check_image_size): Remove redundant decls.
3598 (check_image_size): Don't assume that arbitrary EMACS_INT values
3599 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3600 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3601 (tiff_load, imagemagick_load_image):
3602 Check for overflow in size calculations.
3603 (x_create_x_image_and_pixmap): Remove unnecessary test for
3604 xmalloc returning NULL; that can't happen.
3605 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3606 (xpm_color_bucket): Use better integer hashing function.
3607 (xpm_cache_color): Don't possibly over-allocate memory.
3608 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3609 (gif_memory_source):
3610 Use ptrdiff_t, not int or size_t, to record sizes.
3611 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3612 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3613 either works, as we prefer signed integers.
3614 (tiff_read_from_memory, tiff_write_from_memory):
3615 Return tsize_t, not size_t, since that's what the TIFF API wants.
3616 (tiff_read_from_memory): Don't fail simply because the read would
3617 go past EOF; instead, return a short read.
3618 (tiff_load): Omit no-longer-needed casts.
3619 (Fimagemagick_types): Don't assume size fits into 'int'.
3620
3cc5a532
PE
3621 Improve hashing quality when configured --with-wide-int.
3622 * fns.c (hash_string): New function, taken from sxhash_string.
3623 Do not discard information about ASCII character case; this
3624 discarding is no longer needed.
3625 (sxhash-string): Use it. Change sig to match it. Caller changed.
3626 * lisp.h: Declare it.
3627 * lread.c (hash_string): Remove, since we now use fns.c's version.
3628 The fns.c version returns a wider integer if --with-wide-int is
3629 specified, so this should help the quality of the hashing a bit.
3630
b312a492
PE
3631 * emacs.c: Integer overflow minor fix.
3632 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3633 Define only if GNU_LINUX.
3634 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3635
dfd153ae
PE
3636 * dispnew.c: Integer signedness and overflow fixes.
3637 Remove unnecessary forward decls, that were a maintenance hassle.
3638 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3639 All uses changed.
3640 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3641 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3642 (prepare_desired_row, line_draw_cost):
3643 Use int, not unsigned, where either works.
3644 (save_current_matrix, restore_current_matrix):
3645 Use ptrdiff_t, not size_t, where either works.
3646 (init_display): Check for overflow more accurately, and without
3647 relying on undefined behavior.
3648
a81d11a3
PE
3649 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3650 Remove, replacing with the new symbols in lisp.h. All uses changed.
3651 * fileio.c (make_temp_name):
3652 * filelock.c (lock_file_1, lock_file):
3653 * xdisp.c (message_dolog):
3654 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3655 Use pMd etc. instead.
3656 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3657 replacing the pWIDE etc. symbols removed from editfns.c.
3658
3300e6fd
PE
3659 * keyboard.h (num_input_events): Now uintmax_t.
3660 This is (very slightly) less likely to mess up due to wraparound.
3661 All uses changed.
3662
fd05c7e9
PE
3663 * buffer.c: Integer signedness fixes.
3664 (alloc_buffer_text, enlarge_buffer_text):
3665 Use ptrdiff_t rather than size_t when either will do, as we prefer
3666 signed integers.
3667
903fe15d
PE
3668 * alloc.c: Integer signedness and overflow fixes.
3669 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3670 (__malloc_size_t): Default to size_t, not to int.
3671 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3672 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3673 Prefer ptrdiff_t to size_t when either would do, as we prefer
3674 signed integers.
3675 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3676 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3677 Now const. Initialize with values that are in range even if char
3678 is signed.
3679 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3680 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3681 These functions do the right thing with sizes > 2**32.
3682 (check_depth): Now ptrdiff_t, not int.
3683 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3684 Adjust to new way of storing sizes. Check for size overflow bugs
3685 in rest of code.
3686 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3687 slightly wrong anyway, as it missed one instance of
3688 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3689 (refill_memory_reserve): Omit needless cast to size_t.
3690 (mark_object_loop_halt): Mark as externally visible.
3691
ac82cc6a
PE
3692 * xselect.c: Integer signedness and overflow fixes.
3693 (Fx_register_dnd_atom, x_handle_dnd_message):
3694 Use ptrdiff_t, not size_t, since we prefer signed.
3695 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3696 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3697 x_dnd_atoms_size and x_dnd_atoms_length.
3698
c2d1e36d
PE
3699 * doprnt.c: Prefer signed to unsigned when either works.
3700 * eval.c (verror):
3701 * doprnt.c (doprnt):
3702 * lisp.h (doprnt):
3703 * xdisp.c (vmessage):
3704 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3705 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3706 prefer signed arithmetic to avoid comparison confusion.
3707 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3708 but is a bit tricky.
3709
0e926e56
PE
3710 Assume freestanding C89 headers, string.h, stdlib.h.
3711 * data.c, doprnt.c, floatfns.c, print.c:
3712 Include float.h unconditionally.
3713 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3714 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3715 * regex.c: Likewise for stddef.h, string.h.
3716 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3717 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3718 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3719 (STDC_HEADERS): Remove obsolete defines.
3720 * sysdep.c: Include limits.h unconditionally.
3721
9cfdb3ec
PE
3722 Assume support for memcmp, memcpy, memmove, memset.
3723 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3724 * regex.c (memcmp, memcpy):
3725 Remove; we assume C89 now.
3726
3727 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3728 (__malloc_safe_bcopy): Remove; no longer needed.
3729
cf950e6b 3730 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3731 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3732 well either way, and we prefer signed to unsigned.
3733
dbf38e02
LMI
37342011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3735
3736 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3737 closes the connection while we're reading (bug#9182).
3738
d6f0886c 37392011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3740
d6f0886c
JD
3741 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3742 are specified (Bug#9168).
24e0f6b1 3743
2eb1f9e6
PE
37442011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3745
3746 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3747 Found by GCC static checking and --with-wide-int on a 32-bit host.
3748
22381272 37492011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3750
3751 * xdisp.c (compute_display_string_pos): Fix logic of caching
3752 previous display string position. Initialize cached_prev_pos to
3753 -1. Fixes slow-down at the beginning of a buffer.
3754
f25e39b4
EZ
37552011-07-24 Eli Zaretskii <eliz@gnu.org>
3756
3757 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3758 for attrs[LFACE_FONTSET_INDEX].
3759
04c4b52e
PE
37602011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 * xml.c (parse_region): Remove unused local
3763 that was recently introduced.
3764
c1734fbd
EZ
37652011-07-23 Eli Zaretskii <eliz@gnu.org>
3766
be18c5a5
EZ
3767 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3768 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3769
c1734fbd
EZ
3770 * xdisp.c (move_it_in_display_line_to): Record the best matching
3771 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3772 exit if none of the characters scanned was an exact match.
3773 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3774 when exact match is impossible due to invisible text, and the
3775 lines are truncated.
3776
a258d627
JD
37772011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3778
3779 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3780 for OSX >= 10.7.
3781
b6d5a689
EZ
37822011-07-22 Eli Zaretskii <eliz@gnu.org>
3783
0f74f785
EZ
3784 Fix a significant slow-down of cursor motion with C-n, C-p,
3785 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3786 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3787 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3788 (next_element_from_buffer): Call compute_stop_pos_backwards to
3789 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3790 base_level_stop.
3791 (reseat): Don't look for prev_stop, as that could mean a very long
3792 run.
3793 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3794 <cached_disp_overlay_modiff>: Cache for last found display string
3795 position.
551918c1 3796 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3797 about the same buffer in the same area of character positions, and
3798 the buffer wasn't changed since the time the display string
3799 position was cached.
551918c1 3800
b2d0c91a
EZ
38012011-07-22 Eli Zaretskii <eliz@gnu.org>
3802
3803 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3804 is an integer, which is important for empty lines. (Bug#9149)
3805
043604ee
CY
38062011-07-22 Chong Yidong <cyd@stupidchicken.com>
3807
3808 * frame.c (Fmodify_frame_parameters): In tty case, update the
3809 default face if necessary (Bug#4238).
3810
da4adb04
CY
38112011-07-21 Chong Yidong <cyd@stupidchicken.com>
3812
3813 * editfns.c (Fstring_to_char): No need to explain what a character
3814 is in the docstring (Bug#6576).
3815
9abd0532
LMI
38162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3817
3818 * xml.c (parse_region): Make sure we always return a tree.
3819
36881d16
HK
38202011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3821
3822 * xml.c (parse_region): If a document contains only comments,
3823 return that, too.
3824
1e98674d
LMI
38252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3826
3827 * xml.c (make_dom): Return comments, too.
3828
590bd467
PE
38292011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3830
3831 Port to OpenBSD.
3832 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3833 and the surrounding thread.
3834 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3835 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3836 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3837 timer goes off.
3838 * s/openbsd.h (BROKEN_SIGIO): Define.
3839 * unexelf.c (unexec) [__OpenBSD__]:
3840 Don't update the .mdebug section of the Alpha COFF symbol table.
3841
f41628b2
LMI
38422011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3843
3844 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3845 (bug#8460).
3846
b59b67c5
PE
38472011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3848
15e3a074
PE
3849 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3850 This fixes some race conditions on the permissions of any newly
3851 created file.
3852
41bed37d
PE
3853 * alloc.c (valid_pointer_p): Use pipe, not open.
3854 This fixes some permissions issues when debugging.
3855
b59b67c5
PE
3856 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3857 If fchown fails to set both uid and gid, try to set just gid,
3858 as that is sometimes allowed. Adjust the file's mode to eliminate
3859 setuid or setgid bits that are inappropriate if fchown fails.
3860
925a6be7
SM
38612011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3862
3863 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3864 to compare Lisp_Objects.
3865 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3866 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3867 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3868
52968808
AS
38692011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3870
0a6a104b
AS
3871 * lread.c (read_integer): Unread even EOF character.
3872 (read1): Likewise. Properly record start position of symbol.
3873
52968808
AS
3874 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3875 symbol character follows.
3876
9e381cdd
PE
38772011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3880 This works around a problem with the previous change to Fcopy_file.
3881 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3882 and without this change, GCC might complain about discarding
3883 fchown's return value.
3884
b5641435
JB
38852011-07-16 Juanma Barranquero <lekktu@gmail.com>
3886
3887 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3888
a8031457
PE
38892011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3892
dd889327
LMI
38932011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3894
750c33f7
LMI
3895 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3896 it's used from the C level.
3897
dd889327
LMI
3898 * process.c: Use the same condition for POLL_FOR_INPUT in both
3899 keyboard.c and process.c (bug#1858).
3900
87e86684
LM
39012011-07-09 Lawrence Mitchell <wence@gmx.li>
3902
3903 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3904 (Fgnutls_boot): Use it.
3905
64348f40
AS
39062011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3907
3908 * doc.c (Fsubstitute_command_keys): Revert last change.
3909
1d698799
LMI
39102011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3911
f863868c
LMI
3912 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3913 quotes the next character, and doesn't affect other longer
3914 sequences (bug#8935).
3915
1d698799
LMI
3916 * lread.c (syms_of_lread): Clarify that is isn't only
3917 `eval-buffer' and `eval-defun' that's affected by
3918 `lexical-binding' (bug#8460).
3919
aa4b6df6
EZ
39202011-07-15 Eli Zaretskii <eliz@gnu.org>
3921
3922 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3923 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3924
5d856da6
PE
39252011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3926
ad6042bb
PE
3927 Fix minor problems found by static checking.
3928 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3929 (elsz): Now a signed constant, not a size_t var. We prefer signed
3930 types to unsigned, to avoid integer comparison confusion. Without
3931 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3932 "cannot optimize loop, the loop counter may overflow", a symptom
3933 of the confusion.
f00bbb22 3934 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3935 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3936
6468f31c
LMI
39372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3938
49080b10
LMI
3939 * search.c (Fre_search_backward): Mention `case-fold-search' in
3940 all the re_search_* functions (bug#8138).
3941
6468f31c
LMI
3942 * keyboard.c (Fopen_dribble_file): Document when the file is
3943 closed (bug#8056).
3944
c965adc5
EZ
39452011-07-14 Eli Zaretskii <eliz@gnu.org>
3946
df9733bf
EZ
3947 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3948 bidi_cache_idx.
3949
0bb23927
EZ
3950 Support bidi reordering of display and overlay strings.
3951 * xdisp.c (compute_display_string_pos)
3952 (compute_display_string_end): Accept additional argument STRING.
3953 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3954 (reseat_to_string): Initialize bidi_it->string.s and
3955 bidi_it->string.schars.
3956 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3957 NULL (avoids a crash in bidi_paragraph_init).
3958 Initialize itb.string.lstring.
0bb23927
EZ
3959 (init_iterator): Call bidi_init_it only of a valid
3960 buffer position was specified. Initialize paragraph_embedding to
3961 L2R.
3962 (reseat_to_string): Initialize the bidi iterator.
3963 (display_string): If we need to ignore text properties of
3964 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3965 original value of -1 will not work with bidi.)
3966 (compute_display_string_pos): First arg is now struct
3967 `text_pos *'; all callers changed. Support display properties on
3968 Lisp strings.
3969 (compute_display_string_end): Support display properties on Lisp
3970 strings.
3971 (init_iterator, reseat_1, reseat_to_string): Initialize the
3972 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3973 when iterating on a string not from display properties).
640c8776
SM
3974 (compute_display_string_pos, compute_display_string_end):
3975 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3976 arrow keys.
3977 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3978 base_level_stop; instead, set base_level_stop to BEGV.
3979 Fixes crashes in vertical-motion.
0bb23927
EZ
3980 (next_element_from_buffer): Improve commentary for when
3981 the iterator is before prev_stop.
3982 (init_iterator): Initialize bidi_p from the default value of
3983 bidi-display-reordering, not from buffer-local value. Use the
3984 buffer-local value only if initializing for buffer iteration.
3985 (handle_invisible_prop): Support invisible properties on strings
3986 that are being bidi-reordered.
3987 (set_iterator_to_next): Support bidi reordering of C strings and
3988 Lisp strings.
3989 (next_element_from_string): Support bidi reordering of Lisp
3990 strings.
3991 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3992 (display_string): Support display of R2L glyph rows.
3993 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3994 (init_iterator): Don't initialize it->bidi_p for strings
3995 here.
3996 (reseat_to_string): Initialize it->bidi_p for strings here.
3997 (next_element_from_string, next_element_from_c_string)
3998 (next_element_from_buffer): Add xassert's for correspondence
3999 between IT's object being iterated and it->bidi_it.string
4000 structure.
4001 (face_before_or_after_it_pos): Support bidi iteration.
4002 (next_element_from_c_string): Handle the case of the first string
4003 character that is not the first one in the visual order.
4004 (get_visually_first_element): New function, refactored from common
4005 parts of next_element_from_buffer, next_element_from_string, and
4006 next_element_from_c_string.
4007 (tool_bar_lines_needed, redisplay_tool_bar)
4008 (display_menu_bar): Force left-to-right direction. Add a FIXME
4009 comment for making that be controlled by a user option.
4010 (push_it, pop_it): Save and restore the state of the
4011 bidi iterator. Save and restore the bidi_p flag.
4012 (pop_it): Iterate out of display property for string iteration as
4013 well.
4014 (iterate_out_of_display_property): Support iteration over strings.
4015 (handle_single_display_spec): Set up it->bidi_it for iteration
4016 over a display string, and call bidi_init_it.
4017 (handle_single_display_spec, next_overlay_string)
4018 (get_overlay_strings_1, push_display_prop): Set up the bidi
4019 iterator for displaying display or overlay strings.
4020 (forward_to_next_line_start): Don't use the shortcut if
4021 bidi-iterating.
4022 (back_to_previous_visible_line_start): If handle_display_prop
4023 pushed the iterator stack, restore the internal state of the bidi
4024 iterator by calling bidi_pop_it same number of times.
4025 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4026 and we are bidi-iterating, don't decrement the iterator position;
4027 instead, set the first_elt flag in the bidi iterator, to produce
4028 the same effect.
4029 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4030 (push_display_prop): xassert that we are iterating a buffer.
4031 (push_it, pop_it): Save and restore paragraph_embedding member.
4032 (handle_single_display_spec, next_overlay_string)
4033 (get_overlay_strings_1, reseat_1, reseat_to_string)
4034 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4035 correctly. Don't assume unibyte strings are not bidi-reordered.
4036 (compute_display_string_pos)
4037 (compute_display_string_end): Fix handling the case of C string.
4038 (push_it, pop_it): Save and restore from_disp_prop_p.
4039 (handle_single_display_spec, push_display_prop): Set the
4040 from_disp_prop_p flag.
4041 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4042 (pop_it): Call iterate_out_of_display_property only if we are
4043 popping after iteration over a string that came from a display
4044 property. Fix a typo in popping stretch info. Add an assertion
4045 for verifying that the iterator position is in sync with the bidi
4046 iterator.
4047 (handle_single_display_spec, get_overlay_strings_1)
4048 (push_display_prop): Fix initialization of paragraph direction for
4049 string when that of the parent object is not yet determined.
4050 (reseat_1): Call bidi_init_it to resync the bidi
4051 iterator with IT's position. (Bug#7616)
4052 (find_row_edges): If ROW->start.pos gives position
4053 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4054 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4055 Reset the from_disp_prop_p flag.
4056 (SAVE_IT, RESTORE_IT): New macros.
4057 (pos_visible_p, face_before_or_after_it_pos)
4058 (back_to_previous_visible_line_start)
4059 (move_it_in_display_line_to, move_it_in_display_line)
4060 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4061 (try_scrolling, redisplay_window, display_line): Use them when
4062 saving a temporary copy of the iterator and restoring it back.
4063 (back_to_previous_visible_line_start, reseat_1)
4064 (init_iterator): Empty the bidi cache "stack".
4065 (move_it_in_display_line_to): If iterator ended up at
4066 EOL, but we never saw any buffer positions smaller than
4067 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4068 motion in bidi-reordered lines.
4069 (move_it_in_display_line_to): Record prev_method and prev_pos
4070 immediately before the call to set_iterator_to_next. Fixes cursor
4071 motion in bidi-reordered lines with stretch glyphs and strings
4072 displayed in margins. (Bug#8133) (Bug#8867)
4073 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4074 TO_CHARPOS.
640c8776
SM
4075 (pos_visible_p): Support positions in bidi-reordered lines.
4076 Save and restore bidi cache.
0bb23927
EZ
4077
4078 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4079 (bidi_paragraph_info): Delete unused struct.
4080 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4081 (bidi_cache_start): New variable.
4082 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4083 to zero.
4084 (bidi_cache_fetch_state, bidi_cache_search)
4085 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4086 (bidi_cache_find, bidi_peek_at_next_level)
4087 (bidi_level_of_next_char, bidi_find_other_level_edge)
4088 (bidi_move_to_visually_next): Compare cache index with
4089 bidi_cache_start rather than with zero.
4090 (bidi_fetch_char): Accept new argument STRING; all callers
4091 changed. Support iteration over a string. Support strings with
4092 display properties. Support unibyte strings. Fix the type of
4093 `len' according to what STRING_CHAR_AND_LENGTH expects.
4094 (bidi_paragraph_init, bidi_resolve_explicit_1)
4095 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4096 (bidi_level_of_next_char, bidi_move_to_visually_next):
4097 Support iteration over a string.
0bb23927
EZ
4098 (bidi_set_sor_type, bidi_resolve_explicit_1)
4099 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4100 can now be zero (for strings); special values 0 and -1 were
4101 changed to -1 and -2, respectively.
4102 (bidi_char_at_pos): New function.
4103 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4104 Call it instead of FETCH_MULTIBYTE_CHAR.
4105 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4106 initialized to valid values.
4107 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4108 values.
4109 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4110 the test for valid cached positions. Fix the logic for looking up
4111 the sentinel state in the cache. GCPRO the Lisp string we are
4112 iterating.
4113 (bidi_push_it, bidi_pop_it): New functions.
4114 (bidi_initialize): Initialize the bidi cache start stack pointer.
4115 (bidi_cache_ensure_space): New function, refactored from part of
4116 bidi_cache_iterator_state. Don't assume the required size is just
4117 one BIDI_CACHE_CHUNK away.
4118 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4119 (bidi_count_bytes, bidi_char_at_pos): New functions.
4120 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4121 always valid if bidi_cache_idx is valid.
4122 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4123 is valid if it's going to be used.
4124 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4125 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4126 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4127 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4128 (bidi_find_other_level_edge, bidi_cache_start_stack):
4129 All variables related to cache indices are now EMACS_INT.
c965adc5 4130
0bb23927
EZ
4131 * dispextern.h (struct bidi_string_data): New structure.
4132 (struct bidi_it): New member `string'. Make flag members be 1-bit
4133 fields, and put them last in the struct.
640c8776
SM
4134 (compute_display_string_pos, compute_display_string_end):
4135 Update prototypes.
0bb23927
EZ
4136 (bidi_push_it, bidi_pop_it): Add prototypes.
4137 (struct iterator_stack_entry): New members bidi_p,
4138 paragraph_embedding, and from_disp_prop_p.
4139 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4140 (bidi_shelve_cache, bidi_unshelve_cache):
4141 Declare prototypes.
0bb23927
EZ
4142
4143 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4144 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4145 and vector-like objects.
4146
4147 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4148 cache around display iteration.
4149
4150 * window.c (Fwindow_end, window_scroll_pixel_based)
4151 (displayed_window_lines, Frecenter): Save and restore the bidi
4152 cache around display iteration.
4153
3bbd2265
LMI
41542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4155
4156 * editfns.c (Fdelete_region): Clarify the use of the named
4157 parameters (bug#6788).
4158
adc47434
MR
41592011-07-14 Martin Rudalics <rudalics@gmx.at>
4160
4161 * indent.c (Fvertical_motion): Set and restore w->pointm when
4162 saving and restoring the window's buffer (Bug#9006).
4163
837c31f8
LMI
41642011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4165
4166 * editfns.c (Fstring_to_char): Clarify just what is returned
4167 (bug#6576). Text by Eli Zaretskii.
4168
ac389d0c
JB
41692011-07-13 Juanma Barranquero <lekktu@gmail.com>
4170
4171 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4172
0be0ce47
EZ
41732011-07-13 Eli Zaretskii <eliz@gnu.org>
4174
4175 * buffer.c (mmap_find): Fix a typo.
4176
cd18e7e3
JB
41772011-07-13 Johan Bockgård <bojohan@gnu.org>
4178
4179 Fix execution of x selection hooks.
4180 * xselect.c (Qx_lost_selection_functions)
4181 (Qx_sent_selection_functions): New vars.
4182 (syms_of_xselect): DEFSYM them.
4183 (x_handle_selection_request): Pass Qx_sent_selection_functions
4184 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4185 (x_handle_selection_clear,x_clear_frame_selections):
4186 Pass Qx_lost_selection_functions rather than
4187 Vx_lost_selection_functions to Frun_hook_with_args.
4188
47ea7f44
PE
41892011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4190
ac389d0c 4191 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4192 The old code sometimes used this field without initializing it.
4193
47ea7f44
PE
4194 * alloc.c (gc_sweep): Don't read past end of array.
4195 In theory, the old code could also have corrupted Emacs internals,
4196 though it'd be very unlikely.
4197
bc985c87
AS
41982011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4199
4200 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4201 argument. (Bug#4026)
bc985c87 4202
0cf34688
LMI
42032011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4204
b3dadd76
LMI
4205 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4206 key" (bug#4257).
4207
0cf34688
LMI
4208 * window.c (Fset_window_start): Doc fix (bug#4199).
4209 (Fset_window_hscroll): Ditto.
4210
270768cd
PE
42112011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4212
077e3dda 4213 Fix minor new problems caught by GCC 4.6.1.
270768cd 4214 * term.c (init_tty): Remove unused local.
490011a6 4215 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4216 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4217 not used otherwise.
270768cd 4218
b1f58454
CY
42192011-07-12 Chong Yidong <cyd@stupidchicken.com>
4220
4221 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4222
22b9578d
LMI
42232011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4224
6e70ab07
LMI
4225 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4226 are the mini-buffer and the echo area (bug#3320).
4227
22b9578d
LMI
4228 * term.c (init_tty): Remove support for supdup, c10 and perq
4229 terminals, which are no longer supported (bug#1482).
4230
8974cc9f
JB
42312011-07-10 Johan Bockgård <bojohan@gnu.org>
4232
4233 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4234
a560d974
JD
42352011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4236
4237 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4238 for non-popups (Bug#3642).
4239
1dae0f0a
AS
42402011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4241
268c2c36 4242 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4243 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4244 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4245 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4246 * data.c (fmod): Likewise.
4247 * dispnew.c (swap_glyphs_in_rows): Likewise.
4248 * emacs.c (memory_warning_signal): Likewise.
4249 * floatfns.c (float_error): Likewise.
4250 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4251 (otf_open, font_otf_capability, generate_otf_features)
4252 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4253 Likewise.
4254 * image.c (pbm_read_file): Likewise.
4255 * indent.c (string_display_width): Likewise.
4256 * intervals.c (check_for_interval, search_for_interval)
4257 (inc_interval_count, count_intervals, root_interval)
4258 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4259 * lread.c (defalias): Likewise.
268c2c36 4260 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4261 * regex.c (set_image_of_range_1, set_image_of_range)
4262 (regex_grow_registers): Likewise.
4263 * sysdep.c (strerror): Likewise.
4264 * termcap.c (valid_filename_p, tprint, main): Likewise.
4265 * tparam.c (main): Likewise.
4266 * unexhp9k800.c (run_time_remap, save_data_space)
4267 (update_file_ptrs, read_header, write_header, calculate_checksum)
4268 (copy_file, copy_rest, display_header): Likewise.
4269 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4270 Likewise.
4271 * xdisp.c (check_it): Likewise.
4272 * xfaces.c (register_color, unregister_color, unregister_colors):
4273 Likewise.
4274 * xfns.c (print_fontset_result): Likewise.
4275 * xrdb.c (member, fatal, main): Likewise.
4276
99033785
PE
42772011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4278
4279 Fix minor problems found by static checking (Bug#9031).
4280 * chartab.c (char_table_set_range, map_sub_char_table):
4281 Remove unused locals.
4282 (uniprop_table): Now static.
4283 * composite.c (_work_char): Remove unused static var.
4284
9cb2ac56
JB
42852011-07-09 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4288
f25661f0
JD
42892011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4290
4291 * gtkutil.c (qttip_cb): Remove code without function.
4292
8278c4fe
EZ
42932011-07-09 Eli Zaretskii <eliz@gnu.org>
4294
4295 * w32.c (pthread_sigmask): New stub.
4296
1692ae2d 42972011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4298
8a6ebd58 4299 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4300 sigprocmask is portable only for single-threaded applications, and
4301 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4302 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4303 (LIBES): Use it.
4304 * callproc.c (Fcall_process):
4305 * process.c (create_process):
4306 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4307 Use pthread_sigmask, not sigprocmask.
123403e4 4308
1b854618
JD
43092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4310
4311 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4312 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4313 wrong (Bug#8591).
4314
3fe4b549
JD
43152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4316
0ce7e563
JD
4317 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4318 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4319 (xg_hide_tooltip): Fix comment.
4320
3fe4b549
JD
4321 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4322 in registerServicesMenuSendTypes.
4323 (validRequestorForSendType): Don't check ns_return_types.
4324
4325 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4326 ns_return_type.
4327
5df75e47
JR
43282011-07-08 Jason Rumney <jasonr@gnu.org>
4329
22610910
JR
4330 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4331 SH_SHOW for hidden windows (Bug#5482).
4332
5df75e47
JR
4333 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4334 frame struct members of non-existent frames (Bug#6284).
4335
699c10bd
JD
43362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4337
4393663b
JD
4338 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4339 variable firstTime not needed on OSX >= 10.6.
4340 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4341 >= 10.5. Use setKnobProportion, setDoubleValue.
4342
4343 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4344 (MAC_OS_X_VERSION_10_5): Define if not defined.
4345 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4346 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4347 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4348
4349 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4350 cString and lossyCString on OSX >= 10.4
4351
58179cce 4352 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4353 sizeToFit on OSX >= 10.2.
4354
4355 * nsimage.m (allocInitFromFile): Don't use deprecated method
4356 bestRepresentationForDevice on OSX >= 10.6.
4357
4358 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4359 to avoid warning.
4360
4361 * emacs.c: Declare unexec_init_emacs_zone.
4362
a63e0781
JD
4363 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4364
699c10bd
JD
4365 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4366
4367 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4368 on svcsMenu (Bug#8842).
4369
4370 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4371 ns_return_types.
4372 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4373
4374 * nsterm.m (QUTF8_STRING): Declare.
4375 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4376 (validRequestorForSendType): Return type is (id).
4377 Change indexOfObjectIdenticalTo to indexOfObject.
4378 Check if we have local selection before returning self (Bug#8842).
4379 (writeSelectionToPasteboard): Put local selection into paste board
4380 if we have a local selection (Bug#8842).
4381 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4382
4383 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4384 (ns_get_local_selection): Declare.
4385
54e10184
LMI
43862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4387
9888ff71
LMI
4388 * keymap.c (describe_map_tree): Don't insert a double newline at
4389 the end of the buffer (bug#1169) and return whether we inserted
4390 something.
4391
54e10184
LMI
4392 * callint.c (Fcall_interactively): Change "reading args" to
4393 "providing args" to try to clarify what it does (bug#1010).
4394
15fa4783
KH
43952011-07-07 Kenichi Handa <handa@m17n.org>
4396
4397 * composite.c (composition_compute_stop_pos): Ignore a static
4398 composition starting before CHARPOS (Bug#8915).
4399
4400 * xdisp.c (handle_composition_prop): Likewise.
4401
a8815b00
EZ
44022011-07-07 Eli Zaretskii <eliz@gnu.org>
4403
4404 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4405 (Bug#9015)
4406
ef7b981d 44072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4408
4409 * character.h (unicode_category_t): New enum type.
4410
4411 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4412 (Qchar_code_property_table): New variable.
4413 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4414 (UNIPROP_COMPRESSED_FORM_P): New macros.
4415 (char_table_ascii): Uncompress the compressed values.
4416 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4417 Uncompress the compressed values.
ac389d0c 4418 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4419 (char_table_ref_and_range): Uncompress the compressed values.
4420 (sub_char_table_set): New arg is_uniprop. Callers changed.
4421 Uncompress the compressed values.
4422 (sub_char_table_set_range): Args changed. Callers changed.
4423 (char_table_set_range): Adjuted for the above change.
4424 (map_sub_char_table): Delete args default_val and parent. Add arg
4425 top. Give decoded values to a Lisp function.
640c8776 4426 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4427 values to a Lisp function. Gcpro more variables.
4428 (uniprop_table_uncompress)
4429 (uniprop_decode_value_run_length): New functions.
4430 (uniprop_decoder, uniprop_decoder_count): New variables.
4431 (uniprop_get_decoder, uniprop_encode_value_character)
4432 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4433 New functions.
4434 (uniprop_encoder, uniprop_encoder_count): New variables.
4435 (uniprop_get_encoder, uniprop_table)
4436 (Funicode_property_table_internal, Fget_unicode_property_internal)
4437 (Fput_unicode_property_internal): New functions.
4438 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4439 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4440 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4441 char-code-property-alist.
4442
640c8776 4443 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4444 Vunicode_category_table.
4445
640c8776 4446 * font.c (font_range): Adjust for the change of
c805dec0
KH
4447 Vunicode_category_table.
4448
76b397fb
DN
44492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4450
4451 * m/iris4d.h: Remove file, move contents ...
4452 * s/irix6-5.h: ... here.
4453
22b4128e
PE
44542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4455
4456 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4457 * alloc.c (mark_buffer):
4458 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4459 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4460 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4461 This isn't true in general, and it's particularly not true
4462 if Emacs is configured with --with-wide-int.
4463 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4464 New macros, used in the buffer.c change.
4465
869795d6
JD
44662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4467
4468 * xsettings.c: Use both GConf and GSettings if both are available.
4469 (store_config_changed_event): Add comment.
4470 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4471 (store_tool_bar_style_changed): New functions.
5e617bc2 4472 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4473 (struct xsettings): Move font inside HAVE_XFT.
4474 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4475 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4476 Move inside HAVE_XFT.
640c8776 4477 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4478 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4479 also.
4480 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4481 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4482 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4483 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4484 (parse_settings): Move check for font inside HAVE_XFT.
4485 (read_settings, apply_xft_settings): Add comment.
4486 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4487 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4488 call store_font_name_changed.
4489 (xft_settings_event): Add comment.
4490 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4491 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4492 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4493 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4494 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4495 (xsettings_get_system_font, xsettings_get_system_normal_font):
4496 Add comment.
869795d6 4497
d8ed26bd
PE
44982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4499
4500 Random fixes. E.g., (random) never returned negative values.
4501 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4502 subseconds part to the entropy, as that's a bit more random.
4503 Prefer signed to unsigned, since the signedness doesn't matter and
4504 in general we prefer signed. When given a limit, use a
4505 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4506 latter isn't right if USE_2_TAGS_FOR_INTS.
4507 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4508 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4509
cabf1cac
SM
45102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4511
4512 * textprop.c (text_property_stickiness):
4513 Obey Vtext_property_default_nonsticky.
4514 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4515 * w32fns.c (syms_of_w32fns):
4516 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4517
6e9b2be9
PE
45182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4519
4520 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4521 This is more efficient than Ffile_directory_p and avoids a minor race.
4522
90186c68
LMI
45232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4524
7c301272
LMI
4525 * buffer.c (Foverlay_put): Say what the return value is
4526 (bug#7835).
4527
c4f2d8d4
LMI
4528 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4529 is a directory before asking whether to use the file name
4530 (bug#7564).
ad637907
LMI
4531 (barf_or_query_if_file_exists): Make the "File is a directory"
4532 error be more correct.
c4f2d8d4 4533
90186c68
LMI
4534 * fns.c (Frequire): Remove the mention of the .gz files, since
4535 that's installation-specific, but keep the mention of
4536 `get-load-suffixes'.
4537
da64016e
PE
45382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4541 Report string overflow if the output is too long.
4542
7d47b580
JB
45432011-07-04 Juanma Barranquero <lekktu@gmail.com>
4544
a555cb87
JB
4545 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4546 (syms_of_gnutls): Remove duplicate DEFSYM for
4547 Qgnutls_bootprop_verify_hostname_error, an error for
4548 Qgnutls_bootprop_verify_error (which is no longer used).
4549
7d47b580
JB
4550 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4551 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4552 Also (re)move comments that are misplaced or no longer relevant.
4553
1e49bfab
LMI
45542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4555
4556 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4557
1485f4c0
CY
45582011-07-03 Chong Yidong <cyd@stupidchicken.com>
4559
4560 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4561 and background color parameters if they have been changed.
4562
a9ab721e
LMI
45632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4564
4565 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4566
cf7cff57
PE
45672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4568
2e13213d
PE
4569 * xsettings.c (SYSTEM_FONT): Define only when used.
4570 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4571
cf7cff57
PE
4572 * keymap.c (access_keymap_1): Now static.
4573
7a8e04f7
CY
45742011-07-02 Chong Yidong <cyd@stupidchicken.com>
4575
4576 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4577 leave any prefix arg for the up event (Bug#1586).
4578
61352f62
LMI
45792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4580
69bb1ef7
LMI
4581 * lread.c (syms_of_lread): Mention single symbols defined by
4582 `defvar' or `defconst' (bug#7154).
4583
61352f62 4584 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4585 (Frequire): Mention get-load-suffixes.
61352f62 4586
28545e04
MR
45872011-07-02 Martin Rudalics <rudalics@gmx.at>
4588
4589 * window.h (window): Remove clone_number slot.
4590 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4591 Remove.
4592 (make_parent_window, make_window, saved_window)
4593 (Fset_window_configuration, save_window_save): Don't deal with
4594 clone numbers.
4595 * buffer.c (Qclone_number): Remove declaration.
4596 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4597
3349e122
SM
45982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4599
4600 Add multiple inheritance to keymaps.
4601 * keymap.c (Fmake_composed_keymap): New function.
4602 (Fset_keymap_parent): Simplify.
4603 (fix_submap_inheritance): Remove.
4604 (access_keymap_1): New function extracted from access_keymap to handle
4605 embedded parents and handle lists of maps.
4606 (access_keymap): Use it.
4607 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4608 (Fcopy_keymap): Handle embedded parents.
4609 (Fcommand_remapping, define_as_prefix): Simplify.
4610 (Fkey_binding): Simplify.
4611 (syms_of_keymap): Move minibuffer-local-completion-map,
4612 minibuffer-local-filename-completion-map,
4613 minibuffer-local-must-match-map, and
4614 minibuffer-local-filename-must-match-map to Elisp.
4615 (syms_of_keymap): Defsubr make-composed-keymap.
4616 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4617 (parse_menu_item): Trivial simplification.
4618
3279eb87
GM
46192011-07-01 Glenn Morris <rgm@gnu.org>
4620
4621 * Makefile.in (SETTINGS_LIBS): Fix typo.
4622
4550efdf
KI
46232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4624
4625 * coding.c (Fencode_coding_string): Record the last coding system
4626 used, as the function doc string says (bug#8738).
4627
0949d2b6
JD
46282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4629
4630 * xsettings.c (store_monospaced_changed): Take new font as arg and
4631 check for change against current_mono_font.
4632 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4633 (emacs_settings_constructor, emacs_settings_get_property)
4634 (emacs_settings_set_property, emacs_settings_class_init)
4635 (emacs_settings_init, gsettings_obj): Remove.
4636 (something_changedCB): New function for HAVE_GSETTINGS.
4637 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4638 with value as argument.
4639 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4640 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4641 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4642 "changed".
4643
4644 * xgselect.c: Add defined (HAVE_GSETTINGS).
4645 (xgselect_initialize): Ditto.
4646
4647 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4648 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4649 xg_select.
4650
bbc6b304
PE
46512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4652
4653 * eval.c (struct backtrace): Simplify and port the data structure.
4654 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4655 signed bit field, as this assumption is not portable and it makes
4656 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4657 "char debug_on_exit : 1" as this is not portable either; instead,
4658 use the portable "unsigned int debug_on_exit : 1". Remove unused
4659 member evalargs. Remove obsolete comments about cc bombing out.
4660
9851bfc5
JD
46612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4662
51bb811f 4663 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4664 Let HAVE_GSETTINGS override HAVE_GCONF.
4665 (store_monospaced_changed): New function.
4666 (EMACS_SETTINGS): A new type derived from GObject to handle
4667 GSettings notifications.
4668 (emacs_settings_constructor, emacs_settings_get_property)
4669 (emacs_settings_set_property, emacs_settings_class_init):
4670 New functions.
4671 (gsettings_client, gsettings_obj): New variables.
4672 (GSETTINGS_SCHEMA): New define.
4673 (something_changedCB): Call store_monospaced_changed.
4674 (init_gsettings): New function.
4675 (xsettings_initialize): Call init_gsettings.
4676 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4677 to NULL.
4678
640c8776 4679 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4680 GCONF_CFLAGS/LIBS.
4681
5386012d
MR
46822011-06-29 Martin Rudalics <rudalics@gmx.at>
4683
4684 * window.c (resize_root_window, grow_mini_window)
4685 (shrink_mini_window): Rename Qresize_root_window to
4686 Qwindow_resize_root_window and Qresize_root_window_vertically to
4687 Qwindow_resize_root_window_vertically.
4688
f13e0b08
PE
46892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4690
4691 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4692
94515237
JB
46932011-06-27 Juanma Barranquero <lekktu@gmail.com>
4694
4695 * makefile.w32-in: Redesign dependencies so they reflect more
4696 clearly which files are directly included by each source file,
4697 and not through other includes.
4698
e43b6e43
MR
46992011-06-27 Martin Rudalics <rudalics@gmx.at>
4700
4701 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4702 (sort_overlays, overlay_strings): When an overlay's clone number
4703 matches the window's clone number process the overlay even if
4704 the overlay's window property doesn't match the current window.
4705
d68443dc
MR
4706 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4707 (Fwindow_hchild): Rename to Fwindow_left_child.
4708 (Fwindow_next): Rename to Fwindow_next_sibling.
4709 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4710 (resize_window_check): Rename to window_resize_check.
4711 (resize_window_apply): Rename to window_resize_apply.
4712 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4713 (Fdelete_other_windows_internal, resize_frame_windows)
4714 (Fsplit_window_internal, Fdelete_window_internal)
4715 (grow_mini_window, shrink_mini_window)
4716 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4717
c7e73be5
JD
47182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4719
4720 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4721 (emacs_fixed_set_min_size): Remove.
4722 (emacs_fixed_new): Take frame as argument.
4723
4724 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4725 (_EmacsFixedPrivate): Remove minwidth/height.
4726 Add struct frame *f.
4727 (emacs_fixed_init): Initialize priv->f.
4728 (get_parent_class, emacs_fixed_set_min_size): Remove.
4729 (emacs_fixed_new): Set priv->f to argument.
4730 (emacs_fixed_get_preferred_width)
4731 (emacs_fixed_get_preferred_height): Use min_width/height from
4732 frames size_hint to set minimum and natural (Bug#8919).
4733 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4734 and use min_width/height from frames size_hint to set
4735 min_width/height (Bug#8919).
4736
4737 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4738 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4739 Fix indentation.
c7e73be5 4740
cf99dcf8
EZ
47412011-06-26 Eli Zaretskii <eliz@gnu.org>
4742
4743 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4744 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4745 called at ZV.
4746
029529ac
CY
47472011-06-26 Chong Yidong <cyd@stupidchicken.com>
4748
4749 * process.c (wait_reading_process_output): Bypass select if
4750 waiting for a cell while ignoring keyboard input, and input is
4751 pending. Suggested by Jan Djärv (Bug#8869).
4752
7a7ef429
PE
47532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4754
4755 Use gnulib's dup2 module instead of rolling our own.
4756 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4757
11fdef7d 47582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4759
4760 * dispnew.c (scrolling_window): Before scrolling, turn off a
4761 mouse-highlight in the window being scrolled.
4762
cd3520a4
JB
47632011-06-24 Juanma Barranquero <lekktu@gmail.com>
4764
4765 Move DEFSYM to lisp.h and use everywhere.
4766
4767 * character.h (DEFSYM): Move declaration...
4768 * lisp.h (DEFSYM): ...here.
4769
4770 * gnutls.c:
4771 * minibuf.c:
4772 * w32menu.c:
4773 * w32proc.c:
4774 * w32select.c: Don't include character.h.
4775
4776 * alloc.c (syms_of_alloc):
4777 * buffer.c (syms_of_buffer):
4778 * bytecode.c (syms_of_bytecode):
4779 * callint.c (syms_of_callint):
4780 * casefiddle.c (syms_of_casefiddle):
4781 * casetab.c (init_casetab_once):
4782 * category.c (init_category_once, syms_of_category):
4783 * ccl.c (syms_of_ccl):
4784 * cmds.c (syms_of_cmds):
4785 * composite.c (syms_of_composite):
4786 * dbusbind.c (syms_of_dbusbind):
4787 * dired.c (syms_of_dired):
4788 * dispnew.c (syms_of_display):
4789 * doc.c (syms_of_doc):
4790 * editfns.c (syms_of_editfns):
4791 * emacs.c (syms_of_emacs):
4792 * eval.c (syms_of_eval):
4793 * fileio.c (syms_of_fileio):
4794 * fns.c (syms_of_fns):
4795 * frame.c (syms_of_frame):
4796 * fringe.c (syms_of_fringe):
4797 * insdel.c (syms_of_insdel):
4798 * keymap.c (syms_of_keymap):
4799 * lread.c (init_obarray, syms_of_lread):
4800 * macros.c (syms_of_macros):
4801 * msdos.c (syms_of_msdos):
4802 * print.c (syms_of_print):
4803 * process.c (syms_of_process):
4804 * search.c (syms_of_search):
4805 * sound.c (syms_of_sound):
4806 * syntax.c (init_syntax_once, syms_of_syntax):
4807 * terminal.c (syms_of_terminal):
4808 * textprop.c (syms_of_textprop):
4809 * undo.c (syms_of_undo):
4810 * w32.c (globals_of_w32):
4811 * window.c (syms_of_window):
4812 * xdisp.c (syms_of_xdisp):
4813 * xfaces.c (syms_of_xfaces):
4814 * xfns.c (syms_of_xfns):
4815 * xmenu.c (syms_of_xmenu):
4816 * xsettings.c (syms_of_xsettings):
4817 * xterm.c (syms_of_xterm): Use DEFSYM.
4818
4228cf16
TZ
48192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4820
cd3520a4 4821 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4822
7fcccf1e
PE
48232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4824
7efb4e0e
PE
4825 Integer and buffer overflow fixes (Bug#8873).
4826
ff5844ad
PE
4827 * print.c (printchar, strout): Check for string overflow.
4828 (PRINTPREPARE, printchar, strout):
4829 Don't set size unless allocation succeeds.
4830
90532f02
PE
4831 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4832 for sizes. Check for string overflow more accurately.
4833 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4834
6d84508d
PE
4835 * macros.c: Integer and buffer overflow fixes.
4836 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4837 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4838 Use ptrdiff_t, not int, for sizes.
4839 Don't increment bufsize until after realloc succeeds.
4840 Check for size-calculation overflow.
4841 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4842
437b2cb4
PE
4843 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4844
8b9ac8b4
PE
4845 * lread.c: Integer overflow fixes.
4846 (read_integer): Radix is now EMACS_INT, not int,
4847 to improve quality of diagnostics for out-of-range radices.
4848 Calculate buffer size correctly for out-of-range radices.
4849 (read1): Check for integer overflow in radices, and in
4850 read-circle numbers.
82cb60d3
PE
4851 (read_escape): Avoid int overflow.
4852 (Fload, openp, read_buffer_size, read1)
4853 (substitute_object_recurse, read_vector, read_list, map_obarray):
4854 Use ptrdiff_t, not int, for sizes.
4855 (read1): Use EMACS_INT, not int, for sizes.
20270765 4856 Check for size overflow.
8b9ac8b4 4857
7fcccf1e
PE
4858 * image.c (cache_image): Check for size arithmetic overflow.
4859
bfbbd7e7
PE
4860 * lread.c: Integer overflow issues.
4861 (saved_doc_string_size, saved_doc_string_length)
4862 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4863 Now ptrdiff_t, not int.
4864 (read1): Don't assume doc string length fits in int. Check for
4865 out-of-range doc string lengths.
4866 (read_list): Don't assume file position fits in int.
39019e54 4867 (read_escape): Check for hex character overflow.
bfbbd7e7 4868
4e323265
LL
48692011-06-22 Leo Liu <sdl.web@gmail.com>
4870
4871 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4872 Move to minibuffer.el.
4873
85fece3e
PE
48742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4875
20b84ce9 4876 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4877 The following patches are for when GLYPH_DEBUG && !XASSERT.
4878 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4879 * dispnew.c (flush_stdout):
4880 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4881 Mark as externally visible.
4882 * dispnew.c (check_window_matrix_pointers): Now static.
4883 * dispnew.c (window_to_frame_vpos):
4884 * xfns.c (unwind_create_frame):
4885 * xterm.c (x_check_font): Remove unused local.
4886 * scroll.c (CHECK_BOUNDS):
4887 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4888 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4889 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4890 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4891 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4892 Now static.
4893 (debug_method_add): Use va_list and vsprintf rather than relying
4894 on undefined behavior with wrong number of arguments.
4895 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4896 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4897 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4898 since we're not interested in debugging glyphs with old libraries.
4899 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4900 GCC 4.6.0's static checking.
4901
0766b489
PE
49022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4903
31fd4b32
PE
4904 Integer overflow and signedness fixes (Bug#8873).
4905 A few related buffer overrun fixes, too.
4906
b79e8648
PE
4907 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4908
0766b489
PE
4909 * dispextern.h (struct face.stipple):
4910 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4911 (x_bitmap_mask, x_allocate_bitmap_record)
4912 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4913 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4914 (x_create_bitmap_from_xpm_data):
4915 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4916 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4917 (.bitmaps_last):
4918 * xfaces.c (load_pixmap):
4919 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4920 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4921 (.bitmaps_last, struct x_output.icon_bitmap):
4922 Use ptrdiff_t, not int, for bitmap indexes.
4923 (x_allocate_bitmap_record): Check for size overflow.
4924 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4925
b081724f
PE
4926 Use ptrdiff_t, not int, for overlay counts.
4927 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4928 * editfns.c (overlays_around, get_pos_property):
4929 * textprop.c (get_char_property_and_overlay):
4930 * xdisp.c (next_overlay_change, note_mouse_highlight):
4931 * xfaces.c (face_at_buffer_position):
21514da7
PE
4932 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4933 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4934 (Fnext_overlay_change, Fprevious_overlay_change)
4935 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4936 Use ptrdiff_t, not int, for sizes.
21514da7 4937 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4938
3de73e5e
PE
4939 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4940
2606c57b
PE
4941 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4942 (x_session_initialize): Do not assume string length fits in int.
4943
aaafe47a
PE
4944 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4945 This is unlikely, but can occur if DPI is outlandish.
4946
2674ddc8 4947 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4948 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4949
28154962
PE
4950 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4951 * xrdb.c (magic_file_p, search_magic_path):
4952 Omit last arg SUFFIX; it was always 0. All callers changed.
4953 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4954
7de51af5
PE
4955 * xfont.c (xfont_match): Avoid need for strlen.
4956
25ed6cc3
PE
4957 * xfns.c: Don't assume strlen fits in int.
4958 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4959
4eab31dd
PE
4960 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4961 not unsigned long, as we prefer signed integers. All callers changed.
4962 Detect integer overflow in repeat count.
4963 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4964 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4965
171e2a58
PE
4966 * termcap.c: Don't assume sizes fit in int and never overflow.
4967 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4968 (gobble_line): Check for size-calculation overflow.
4969
ad39faca 4970 * minibuf.c (Fread_buffer):
6e5bb2dc 4971 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4972 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4973 Don't assume string length fits in int.
4974
52c61c22 4975 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4976 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4977
b5b8c9e5
PE
4978 * font.c: Don't assume string length fits in int.
4979 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4980 Use ptrdiff_t, not int.
ccd6111c
PE
4981 (font_intern_prop): Don't assume string length fits in int.
4982 Don't assume integer property fits in fixnum.
4983 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4984
882f0d81 4985 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4986 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4987 Reformulate so as not to need the command string.
4988 Invoke gzip -cd rather than gunzip, as it's more portable.
4989 (lock_info_type, lock_file_1, lock_file):
4990 Don't assume pid_t and time_t fit in unsigned long.
4991 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4992 (current_lock_owner): Prefer signed type for sizes.
4993 Use memcpy, not strncpy, where memcpy is what is really wanted.
4994 Don't assume (via atoi) that time_t and pid_t fit in int.
4995 Check for time_t and/or pid_t out of range, e.g., via a network share.
4996 Don't alloca where an auto var works fine.
4997
93f4cf88
PE
4998 * fileio.c: Fix some integer overflow issues.
4999 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5000 Don't assume string length fits in int.
5001 (directory_file_name): Don't assume string length fits in long.
5002 (make_temp_name): Don't assume pid fits in int, or that its print
5003 length is less than 20.
5004
f3e92b69
PE
5005 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5006
1bfdaf10
PE
5007 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5008
35016e9a
PE
5009 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5010
3d1e65a1
PE
5011 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5012 We prefer signed integers, even for size calculations.
5013
0b963a93
PE
5014 * emacs.c: Don't assume string length fits in 'int'.
5015 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5016 (main): Don't invoke strlen when not needed.
5017
573f4b54
PE
5018 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5019 (XD_DEBUG_MESSAGE): Don't waste a byte.
5020
989f33ba
PE
5021 * callproc.c (getenv_internal_1, getenv_internal)
5022 (Fgetenv_internal):
965d34eb
PE
5023 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5024
e4d29b33
PE
5025 * lread.c (invalid_syntax): Omit length argument.
5026 All uses changed. This doesn't fix a bug, but it simplifies the
5027 code away from its former Hollerith-constant appearance, and it's
5028 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5029 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5030
eb49b136
PE
5031 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5032 This didn't break anything, but it didn't help either.
5033 It's confusing to put a bogus integer in a place where the actual
5034 value does not matter.
9f62aeb1 5035 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5036 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5037
15375a22
PE
5038 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5039 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5040 implementation.
b61cc01c
PE
5041 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5042 We prefer signed types, and the value cannot exceed the EMACS_INT
5043 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5044 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5045 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5046 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5047
53b2623d
PE
5048 * indent.c (sane_tab_width): New function.
5049 (current_column, scan_for_column, Findent_to, position_indentation)
5050 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5051 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5052
51cab52b 5053 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5054
f2ed8a70
PE
5055 * lisp.h (lint_assume): New macro.
5056 * composite.c (composition_gstring_put_cache):
5057 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5058
abe80cc6
PE
5059 * editfns.c, insdel.c:
5060 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5061
b02c740e
PE
5062 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5063
ebc96716
PE
5064 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5065
b4e50fa0 5066 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5067 Use much-faster test for byte-length change.
311d5d7c 5068 Don't assume string byte-length fits in 'int'.
a4cf38e4 5069 Check that character arg fits in 'int'.
85461888 5070 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5071
c0c1ee9f
PE
5072 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5073
a498d7f4
PE
5074 * fns.c (concat): Catch string overflow earlier.
5075 Do not rely on integer wraparound.
5076
51cab52b
PE
5077 * dispextern.h (struct it.overlay_strings_charpos)
5078 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5079 * xdisp.c (forward_to_next_line_start)
5080 (back_to_previous_visible_line_start)
5081 (reseat_at_next_visible_line_start, next_element_from_buffer):
5082 Don't arbitrarily truncate the value of 'selective' to int.
5083
76031fad
PE
5084 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5085
5eb55db9
PE
5086 * composite.c: Don't truncate sizes to 'int'.
5087 (composition_gstring_p, composition_reseat_it)
5088 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5089 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5090 not EMACS_UINT, for indexes.
5eb55db9 5091
0703a717
PE
5092 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5093
d6202519
PE
5094 * buffer.c: Include <verify.h>.
5095 (struct sortvec.priority, struct sortstr.priority):
8961a454 5096 Now EMACS_INT, not int.
c20998a7 5097 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5098 (struct sortstr.size, record_overlay_string)
5099 (struct sortstrlist.size, struct sortlist.used):
5100 Don't truncate size to int.
5101 (record_overlay_string): Check for size-calculation overflow.
d6202519 5102 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5103
d5a19415
JM
51042011-06-22 Jim Meyering <meyering@redhat.com>
5105
029529ac 5106 Don't leak an XBM-image-sized buffer
d5a19415
JM
5107 * image.c (xbm_load): Free the image buffer after using it.
5108
a9041e6c
PE
51092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5110
5111 Port to Sun C.
5112 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5113 that Sun C diagnosed.
5114 * fns.c (secure_hash): Fix pointer signedness issue.
5115 * intervals.c (static_offset_intervals): New function.
5116 (offset_intervals): Use it.
5117
7f3f739f
LL
51182011-06-21 Leo Liu <sdl.web@gmail.com>
5119
5120 * deps.mk (fns.o):
5121 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5122 sha512.h.
5123
5124 * fns.c (secure_hash): Rename from crypto_hash_function and change
5125 the first arg to accept symbols.
5b66d427 5126 (Fsecure_hash): New primitive.
7f3f739f
LL
5127 (syms_of_fns): New symbols.
5128
76147d94
DD
51292011-06-20 Deniz Dogan <deniz@dogan.se>
5130
5131 * process.c (Fset_process_buffer): Clarify return value in
5132 docstring.
5133
7d7d0045
CY
51342011-06-18 Chong Yidong <cyd@stupidchicken.com>
5135
5136 * dispnew.c (add_window_display_history): Use BVAR.
5137
5138 * xdisp.c (debug_method_add): Use BVAR.
5139 (check_window_end, dump_glyph_matrix, dump_glyph)
5140 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5141
5142 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5143 Likewise.
5144
5145 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5146 check till after the cache is created in init_frame_faces.
5147
ff2bc410
SM
51482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5149
5150 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5151
28177add
PE
51522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5153
dd3482fe
PE
5154 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5155 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5156 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5157
393d71f3 5158 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5159 * fileio.c (Finsert_file_contents):
5160 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5161 Remove the old (too-loose) buffer overflow checks.
5162 They weren't needed, since make_gap checks for buffer overflow.
5163 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5164 The old code merely checked for Emacs fixnum overflow, and relied
5165 on undefined (wraparound) behavior. The new code avoids undefined
5166 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5167
2e6813b0 5168 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5169 Tune. Don't use wider integers than needed. Don't use alloca.
5170 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5171
599a9e4f
PE
5172 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5173
99561444
PE
5174 * insdel.c, lisp.h (buffer_overflow): New function.
5175 (insert_from_buffer_1, replace_range, replace_range_2):
5176 * insdel.c (make_gap_larger):
5177 * editfns.c (Finsert_char):
5178 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5179
28177add
PE
5180 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5181
e69dafad
PE
51822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5183
4baa020d 5184 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5185
b1c46f02
PE
5186 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5187 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5188
e69dafad
PE
5189 * fileio.c: Don't assume EMACS_INT fits in off_t.
5190 (emacs_lseek): New static function.
5191 (Finsert_file_contents, Fwrite_region): Use it.
5192 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5193
566684ea
PE
5194 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5195
e6966cd6
PE
5196 * fns.c: Don't overflow int when computing a list length.
5197 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5198 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5199 truncation on 64-bit hosts. Check for QUIT every
5200 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5201 faster and is responsive enough.
5202 (Flength): Report an error instead of overflowing an integer.
5203 (Fsafe_length): Return a float if the value is not representable
5204 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5205 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5206 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5207
dd0b0efb
PE
5208 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5209 (header_size, word_size): New constants.
5210 (allocate_vectorlike): Don't check size overflow here.
5211 (allocate_vector): Check it here instead, since this is the only
5212 caller of allocate_vectorlike that could cause overflow.
5213 Check that the new vector's length is representable as a fixnum.
5214
86fe5cfe
PE
5215 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5216 The previous code was bogus. For example, next_almost_prime (32)
5217 returned 39, which is undesirable as it is a multiple of 3; and
5218 next_almost_prime (24) returned 25, which is a multiple of 5 so
5219 why was the code bothering to check for multiples of 7?
5220
80e88859
PE
5221 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5222
4a2f0ad6
PE
5223 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5224
f66c7cf8
PE
5225 Variadic C functions now count arguments with ptrdiff_t.
5226 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5227 Back then I didn't know that the Emacs coding style prefers signed int.
5228 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5229 were being counted with int, which may truncate counts on 64-bit
5230 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5231 * lisp.h (struct Lisp_Subr.function.aMANY)
5232 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5233 Arg counts are now ptrdiff_t, not size_t.
5234 All variadic functions and their callers changed accordingly.
5235 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5236 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5237 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5238 * callint.c (Fcall_interactively): Check arg count for overflow,
5239 to avoid potential buffer overrun. Use signed char, not 'int',
5240 for 'varies' array, so that we needn't bother to check its size
5241 calculation for overflow.
5242 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5243 * eval.c (apply_lambda):
5244 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5245 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5246 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5247
a1759b76
PE
5248 * callint.c (Fcall_interactively): Don't use index var as event count.
5249
d96be9fc
PE
5250 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5251 * mem-limits.h (SIZE): Remove; no longer used.
5252
a690a978 5253 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5254
578c21e6
PE
5255 Remove unnecessary casts.
5256 * xterm.c (x_term_init):
5257 * xfns.c (x_set_border_pixel):
5258 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5259 These aren't needed now that we assume ANSI C.
5260
96f53c6c
PE
5261 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5262 It's more likely to cause problems (due to unsigned overflow)
5263 than to cure them.
5264
83c77d31
PE
5265 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5266
ee2079f1
PE
5267 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5268
6da65536
PE
5269 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5270
7147c4a4
PE
5271 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5272
193e32d9
PE
5273 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5274
e5533da6
PE
5275 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5276
9910e595
PE
5277 GLYPH_CODE_FACE returns EMACS_INT, not int.
5278 * dispextern.h (merge_faces):
5279 * xfaces.c (merge_faces):
01103c44
PE
5280 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5281 Don't assume EMACS_INT fits in int.
9910e595 5282
2638320e
PE
5283 * character.h (CHAR_VALID_P): Remove unused parameter.
5284 * fontset.c, lisp.h, xdisp.c: All uses changed.
5285
045eb8d9
PE
5286 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5287
c1f134b5
PE
5288 * fns.c (concat): Minor tuning based on overflow analysis.
5289 This doesn't fix any bugs. Use int to hold character, instead
5290 of constantly refetching from Emacs object. Use XFASTINT, not
5291 XINT, for value known to be a character. Don't bother comparing
5292 a single byte to 0400, as it's always less.
5293
395fcb93 5294 * floatfns.c (Fexpt):
327eeec8
PE
5295 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5296
abbd3d23
PE
5297 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5298 for characters.
5299
684a03ef
PE
5300 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5301
0fed43f3
PE
5302 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5303 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5304 incorrectly succeed when S was a string, because 4294967386 was
5305 truncated before it was used.
5306
8fd02eb7
PE
5307 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5308 Otherwise, an out-of-range integer could cause undefined behavior
5309 on a 64-bit host.
5310
f8c86b69
PE
5311 * composite.c: Use int, not EMACS_INT, for characters.
5312 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5313 EMACS_INT, for values that are known to be in character range.
5314 This doesn't fix any bugs but is the usual style inside Emacs and
5315 may generate better code on 32-bit machines.
5316
34206dd2
PE
5317 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5318 This is for reasons similar to the recent CHAR_STRING fix.
5319 * charset.c (Fencode_char): Check that character arg is actually
5320 a character. Pass an int to ENCODE_CHAR.
5321 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5322 wider than 'int', as a compile-time check to prevent future regressions
5323 in this area.
5324
c5958d4c 5325 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5326
5327 Make sure a 64-bit char is never passed to CHAR_STRING.
5328 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5329 by silently ignoring the top 32 bits, allowing some values
5330 that were far too large to be valid characters.
5331 * character.h: Include <verify.h>.
5332 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5333 arguments are no wider than unsigned, as a compile-time check
5334 to prevent future regressions in this area.
5335 * data.c (Faset):
01103c44 5336 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5337 (Fsubst_char_in_region):
5338 * fns.c (concat):
5339 * xdisp.c (decode_mode_spec_coding):
5340 Adjust to CHAR_STRING's new requirement.
5341 * editfns.c (Finsert_char, Fsubst_char_in_region):
5342 * fns.c (concat): Check that character args are actually
5343 characters. Without this test, these functions did the wrong
5344 thing with wildly out-of-range values on 64-bit hosts.
5345
d37ca623
PE
5346 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5347 These casts should not be needed on 32-bit hosts, either.
5348 * keyboard.c (read_char):
5349 * lread.c (Fload): Remove casts to unsigned.
5350
ea204efb
PE
5351 * lisp.h (UNSIGNED_CMP): New macro.
5352 This fixes comparison bugs on 64-bit hosts.
5353 (ASCII_CHAR_P): Use it.
5354 * casefiddle.c (casify_object):
01103c44 5355 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5356 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5357 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5358 * dispextern.h (FACE_FROM_ID):
5359 * keyboard.c (read_char): Use UNSIGNED_CMP.
5360
41cb286c
PE
5361 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5362 not to EMACS_INT, to avoid GCC warning.
5363
4a1b9832
PE
5364 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5365
55daad71
PE
5366 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5367 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5368 isn't needed on 32-bit machines.
8f95c75c 5369
01103c44
PE
5370 * buffer.c (Fgenerate_new_buffer_name):
5371 Use EMACS_INT for count, not int.
0ceccced 5372 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5373
5374 * data.c (Qcompiled_function): Now static.
5375
c6f072e7
PE
5376 * window.c (window_body_lines): Now static.
5377
20ce5912
PE
5378 * image.c (gif_load): Rename local to avoid shadowing.
5379
9c4c5f81
PE
5380 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5381 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5382 * alloc.c (make_save_value): Integer argument is now of type
5383 ptrdiff_t, not int.
5384 (mark_object): Use ptrdiff_t, not int.
5385 * lisp.h (pD): New macro.
5386 * print.c (print_object): Use it.
5387
c0c5c8ae
PE
5388 * alloc.c: Use EMACS_INT, not int, to count objects.
5389 (total_conses, total_markers, total_symbols, total_vector_size)
5390 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5391 (total_free_floats, total_floats, total_free_intervals)
5392 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5393 Now EMACS_INT, not int. All uses changed.
5394 (Fgarbage_collect): Compute overall total using a double, so that
5395 integer overflow is less likely to be a problem. Check for overflow
5396 when converting back to an integer.
5a25e253
PE
5397 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5398 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5399 These were 'int' variables that could overflow on 64-bit hosts;
5400 they were never used, so remove them instead of repairing them.
211a0b2a 5401 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5402 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5403 Previously, this ceilinged at INT_MAX, but that doesn't work on
5404 64-bit machines.
e46bb31a 5405 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5406
c78baabf 5407 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5408 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5409 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5410 when a (possibly-narrower) signed value would do just as well.
5411 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5412
c9d624c6
PE
5413 * alloc.c: Catch some string size overflows that we were missing.
5414 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5415 for convenience in STRING_BYTES_MAX.
5416 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5417 The definition here is exact; the one in lisp.h was approximate.
5418 (allocate_string_data): Check for string overflow. This catches
5419 some instances we weren't catching before. Also, it catches
5420 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5421 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5422 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5423
c9d624c6
PE
5424 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5425 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5426 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5427
353032ce
PE
5428 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5429
2bccce07
PE
5430 * alloc.c (Fmake_string): Check for out-of-range init.
5431
0ac30604
SM
54322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5433
5434 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5435
c195f2de
JD
54362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5437
5438 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5439 xg_get_default_scrollbar_width.
5440
5441 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5442 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5443 (style_changed_cb): Call update_theme_scrollbar_width and call
5444 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5445 all frames (Bug#8505).
5446 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5447 Call gtk_window_set_resizable if HAVE_GTK3.
5448 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5449 and height if HAVE_GTK3 (Bug#8505).
5450 (scroll_bar_width_for_theme): New variable.
5451 (update_theme_scrollbar_width): New function.
5452 (xg_get_default_scrollbar_width): Move code to
5453 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5454 (xg_initialize): Call update_theme_scrollbar_width.
5455
5456 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5457
5458 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5459
e10ac9f1
MR
54602011-06-12 Martin Rudalics <rudalics@gmx.at>
5461
5462 * frame.c (make_frame): Call other_buffer_safely instead of
5463 other_buffer.
5464
5465 * window.c (temp_output_buffer_show): Call display_buffer with
5466 second argument Vtemp_buffer_show_specifiers and reset latter
5467 immediately after the call.
5468 (Vtemp_buffer_show_specifiers): New variable.
5469 (auto_window_vscroll_p, next_screen_context_lines)
5470 (Vscroll_preserve_screen_position): Remove leading asterisks from
5471 doc-strings.
5472
2d3c217e 54732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5474
7b7f97e8 5475 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5476 * buffer.c (Qclone_number): Remove for now, as it's unused.
5477 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5478 (record_buffer): Remove unused local.
5479 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5480 (set_frame_buffer_list): Remove; unused.
5481 * frame.h (other_visible_frames): Remove decl.
5482 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5483 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5484 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5485 if HAVE_GPM.
5486 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5487 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5488 Define only if HAVE_GPM.
5489 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5490 (update_hints_inhibit): Remove; never set. All uses removed.
5491 * widgetprv.h (emacsFrameClassRec): Remove decl.
5492 * window.c (delete_deletable_window): Now returns void, since it
5493 wasn't returning anything.
5494 (compare_window_configurations): Remove unused locals.
5495 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5496 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5497 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5498 the same widths as pointers. This follows up on the 2011-05-06 patch.
5499 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5500 * xterm.h: Likewise.
5501 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5502
1384b89e
JB
55032011-06-12 Juanma Barranquero <lekktu@gmail.com>
5504
5505 * makefile.w32-in: Update dependencies.
5506 (LISP_H): Add lib/intprops.h.
5507
1100a63c
CY
55082011-06-11 Chong Yidong <cyd@stupidchicken.com>
5509
5510 * image.c (gif_load): Add animation frame delay to the metadata.
5511 (syms_of_image): Use DEFSYM. New symbol `delay'.
5512
6198ccd0
MR
55132011-06-11 Martin Rudalics <rudalics@gmx.at>
5514
5515 * window.c (delete_deletable_window): Re-add.
5516 (Fset_window_configuration): Rewrite to handle dead buffers and
5517 consequently deletable windows.
5518 (window_tree, Fwindow_tree): Remove. Supply functionality in
5519 window.el.
5520 (compare_window_configurations): Simplify code.
5521
b6e3633c
AS
55222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5523
1ab0dee5
AS
5524 * image.c (imagemagick_load_image): Fix type mismatch.
5525 (Fimagemagick_types): Likewise.
5526
b6e3633c
AS
5527 * window.h (replace_buffer_in_windows): Declare.
5528
9397e56f
MR
55292011-06-11 Martin Rudalics <rudalics@gmx.at>
5530
5531 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5532 Qclone_number. Remove external declaration of Qdelete_window.
5533 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5534 code.
640c8776
SM
5535 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5536 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5537 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5538 buffer list implementation.
5539 (other_buffer_safely): New function.
5540 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5541 calls to replace_buffer_in_windows and
5542 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5543 if allowed.
5544 (record_buffer): Inhibit quitting and rewrite using quittable
5545 functions. Run Qbuffer_list_update_hook if allowed.
5546 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5547 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5548 Move switch-to-buffer to window.el.
9397e56f
MR
5549 (bury-buffer): Move to window.el.
5550 (Vbuffer_list_update_hook): New variable.
5551
5552 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5553 section.
5554
5555 * window.h (resize_frame_windows): Move up in code.
5556 (Fwindow_frame): Remove EXFUN.
5557 (replace_buffer_in_all_windows): Remove prototype.
5558 (replace_buffer_in_windows_safely): Add prototype.
5559
5560 * window.c: Declare Qdelete_window static again. Move down
5561 declaration of select_count.
5562 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5563 (Fother_window): Move to window.el.
5564 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5565 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5566 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5567 window.el.
5568 (replace_buffer_in_windows): Implement by calling
5569 Qreplace_buffer_in_windows.
5570 (replace_buffer_in_all_windows): Remove with some functionality
5571 moved into replace_buffer_in_windows_safely.
5572 (replace_buffer_in_windows_safely): New function.
5573 (select_window_norecord, select_frame_norecord): Move in front
5574 of run_window_configuration_change_hook. Remove now obsolete
5575 declarations.
640c8776
SM
5576 (Fset_window_buffer): Rewrite doc-string.
5577 Call Qrecord_window_buffer.
9397e56f
MR
5578 (keys_of_window): Move binding for other-window to window.el.
5579
b50691aa
CY
55802011-06-11 Chong Yidong <cyd@stupidchicken.com>
5581
5582 * dispextern.h (struct image): Replace data member, whose int_val
5583 and ptr_val fields were not used by anything, with a single
5584 lisp_val object.
5585
5586 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5587 (gif_clear_image, gif_load, imagemagick_load_image)
5588 (gs_clear_image, gs_load): Callers changed.
5589
3f754b86
PE
55902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5591
cca69397
PE
5592 * buffer.h: Include <time.h>, for time_t.
5593 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5594
109e28d0
PE
5595 Fix minor problems found by static checking.
5596
60737f02
PE
5597 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5598
4b66faf3
PE
5599 Make identifiers static if they are not used in other modules.
5600 * data.c (Qcompiled_function, Qframe, Qvector):
5601 * image.c (QimageMagick, Qsvg):
5602 * minibuf.c (Qmetadata):
5603 * window.c (resize_window_check, resize_root_window): Now static.
5604 * window.h (resize_window_check, resize_root_window): Remove decls.
5605
109e28d0
PE
5606 * window.c (window_deletion_count, delete_deletable_window):
5607 Remove; unused.
46a4ce9e
PE
5608 (window_body_lines): Now static.
5609 (Fdelete_other_windows_internal): Mark vars as initialized.
5610 Make sure 'resize_failed' is initialized.
5611 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5612 (resize_window_apply): Remove unused local.
5613 * window.h (delete_deletable_window): Remove decl.
5614
109e28d0 5615 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5616 (imagemagick_load_image): Fix pointer signedness problem by changing
5617 last arg from unsigned char * to char *. All uses changed.
5618 Also, fix a local for similar reasons.
5619 Remove unused locals. Remove locals to avoid shadowing.
5620 (fn_rsvg_handle_free): Remove; unused.
5621 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5622 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5623
3f754b86
PE
5624 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5625
2547adb1
CY
56262011-06-10 Chong Yidong <cyd@stupidchicken.com>
5627
5628 * image.c (gif_load): Fix omitted cast error introduced by
5629 2011-06-06 change.
5630
2c8e37d4
MR
56312011-06-10 Martin Rudalics <rudalics@gmx.at>
5632
5633 * window.h (resize_proportionally, orig_total_lines)
5634 (orig_top_line): Remove from window structure.
5635 (set_window_height, set_window_width, change_window_heights)
5636 (Fdelete_window): Remove prototypes.
5637 (resize_frame_windows): Remove duplicate declaration.
5638
440a42e3
EZ
56392011-06-10 Eli Zaretskii <eliz@gnu.org>
5640
5641 * window.h (resize_frame_windows, resize_window_check)
5642 (delete_deletable_window, resize_root_window)
5643 (resize_frame_windows): Declare prototypes.
5644
5645 * window.c (resize_window_apply): Make definition be "static" to
5646 match the prototype.
5647
562dd5e9
MR
56482011-06-10 Martin Rudalics <rudalics@gmx.at>
5649
5650 * window.c: Remove declarations of Qwindow_size_fixed,
5651 window_min_size_1, window_min_size_2, window_min_size,
5652 size_window, window_fixed_size_p, enlarge_window, delete_window.
5653 Remove static from declaration of Qdelete_window, it's
5654 temporarily needed by Fbury_buffer.
5655 (replace_window): Don't assign orig_top_line and
5656 orig_total_lines.
5657 (Fdelete_window, delete_window): Remove. Window deletion is
5658 handled by window.el.
640c8776
SM
5659 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5660 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5661 (Fdelete_other_windows): Remove. Deleting other windows is
5662 handled by window.el.
5663 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5664 handled in window.el.
5665 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5666 Window minimum sizes are handled in window.el.
5667 (shrink_windows, size_window, set_window_height)
5668 (set_window_width, change_window_heights, window_height)
5669 (window_width, CURBEG, CURSIZE, enlarge_window)
5670 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5671 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5672 handled in window.el.
5673 (make_dummy_parent): Rename to make_parent_window and give it a
5674 second argument horflag.
5675 (make_window): Don't set resize_proportionally any more.
5676 (Fsplit_window): Remove. Windows are split in window.el.
5677 (save_restore_action, save_restore_orig_size)
5678 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5679 Resize mini windows in window.el.
5680 (grow_mini_window, shrink_mini_window): Implement by calling
5681 Qresize_root_window_vertically, resize_window_check and
5682 resize_window_apply.
640c8776
SM
5683 (saved_window, Fset_window_configuration, save_window_save):
5684 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5685 resize_proportionally.
5686 (window_min_height, window_min_width): Move to window.el.
5687 (keys_of_window): Move bindings for delete-other-windows,
5688 split-window, delete-window and enlarge-window to window.el.
5689
5690 * buffer.c: Temporarily extern Qdelete_window.
5691 (Fbury_buffer): Temporarily call Qdelete_window instead of
5692 Fdelete_window (Fbury_buffer will move to window.el soon).
5693
5694 * frame.c (set_menu_bar_lines_1): Remove code handling
5695 orig_top_line and orig_total_lines.
5696
5697 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5698 set_window_height but set heights directly.
5699 (change_frame_size_1): Use resize_frame_windows.
5700
5701 * xdisp.c (init_xdisp): Don't use set_window_height but set
5702 heights directly.
5703
640c8776
SM
5704 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5705 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5706 run_window_configuration_change_hook.
5707
5708 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5709 instead of change_window_heights and run
5710 run_window_configuration_change_hook.
5711
1a13852e
MR
57122011-06-09 Martin Rudalics <rudalics@gmx.at>
5713
5714 * window.c (replace_window): Rename second argument REPLACEMENT to
5715 NEW. New third argument SETFLAG. Rewrite.
5716 (delete_window, make_dummy_parent): Call replace_window with
5717 third argument 1.
5718 (window_list_1): Move down in code.
5719 (run_window_configuration_change_hook): Move set_buffer part
5720 before select_frame_norecord part in order to unwind correctly.
5721 Rename count1 to count.
5722 (recombine_windows, delete_deletable_window, resize_root_window)
5723 (Fdelete_other_windows_internal)
5724 (Frun_window_configuration_change_hook, make_parent_window)
5725 (resize_window_check, resize_window_apply, Fresize_window_apply)
5726 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5727 (Fdelete_window_internal, Fresize_mini_window_internal):
5728 New functions.
1a13852e
MR
5729 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5730
f3d1777e
MR
57312011-06-08 Martin Rudalics <rudalics@gmx.at>
5732
496e208e
MR
5733 * window.h (window): Add some new members to window structure -
5734 normal_lines, normal_cols, new_total, new_normal, clone_number,
5735 splits, nest, prev_buffers, next_buffers.
5736 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5737 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5738
f3d1777e
MR
5739 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5740 Remove.
496e208e
MR
5741 (make_dummy_parent): Set new members of windows structure.
5742 (make_window): Move down in code. Handle new members of window
5743 structure.
5744 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5745 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5746 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5747 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5748 (Fset_window_next_buffers, Fset_window_clone_number):
5749 New functions.
496e208e
MR
5750 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5751 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5752 Doc-string fixes.
5753 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5754 Argument WINDOW can be now internal window too.
5755 (Fwindow_use_time): Move up in code.
5756 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5757 Rewrite doc-string.
5758 (Fset_window_configuration, saved_window)
5759 (Fcurrent_window_configuration, save_window_save): Handle new
5760 members of window structure.
b9e809c2
MR
5761 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5762 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5763 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5764 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5765 Qget_mru_window, Qresize_root_window,
5766 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5767 Qauto_buffer_name; staticpro them.
f3d1777e 5768
abde8f8c
MR
57692011-06-07 Martin Rudalics <rudalics@gmx.at>
5770
5771 * window.c (Fwindow_total_size, Fwindow_left_column)
5772 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5773 (Fwindow_list_1): New functions.
5774 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5775 (Fwindow_width, Fscroll_left, Fscroll_right):
5776 Use window_body_cols instead of window_box_text_cols.
5777 (delete_window, Fset_window_configuration):
5778 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5779 (delete_all_subwindows): Take a window as argument and not a
5780 structure. Rewrite.
190b47e6
MR
5781 (window_loop): Remove handling of GET_LRU_WINDOW and
5782 GET_LARGEST_WINDOW.
5783 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5784
5785 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5786 window_box_text_cols. delete_all_subwindows now takes a
5787 Lisp_Object as argument.
abde8f8c 5788
640c8776
SM
5789 * indent.c (compute_motion, Fcompute_motion):
5790 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5791
fa8a67e6
MR
5792 * frame.c (delete_frame): Call delete_all_subwindows with root
5793 window as argument.
5794
a54e3482
DC
57952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5796
5797 * fns.c (Fputhash): Document return value.
5798
60002bf5
CY
57992011-06-06 Chong Yidong <cyd@stupidchicken.com>
5800
5801 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5802
0c671da6 58032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5804
b862a52a 5805 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5806
be44ca6c
PE
5807 Check for overflow when converting integer to cons and back.
5808 * charset.c (Fdefine_charset_internal, Fdecode_char):
5809 Use cons_to_unsigned to catch overflow.
5810 (Fencode_char): Use INTEGER_TO_CONS.
5811 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5812 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5813 * data.c (long_to_cons, cons_to_long): Remove.
5814 (cons_to_unsigned, cons_to_signed): New functions.
5815 These signal an error for invalid or out-of-range values.
5816 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5817 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5818 * font.c (Ffont_variation_glyphs):
5819 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5820 * lisp.h: Include <intprops.h>.
5821 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5822 (cons_to_signed, cons_to_unsigned): New decls.
5823 (long_to_cons, cons_to_long): Remove decls.
5824 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5825 (Fprimitive_undo): Use CONS_TO_INTEGER.
5826 * xfns.c (Fx_window_property): Likewise.
5827 * xselect.c: Include <limits.h>.
5828 (x_own_selection, selection_data_to_lisp_data):
5829 Use INTEGER_TO_CONS.
5830 (x_handle_selection_request, x_handle_selection_clear)
5831 (x_get_foreign_selection, Fx_disown_selection_internal)
5832 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5833 (lisp_data_to_selection_data): Use cons_to_unsigned.
5834 (x_fill_property_data): Use cons_to_signed.
5835 Report values out of range.
5836
d1f3d2af
PE
5837 Check for buffer and string overflow more precisely.
5838 * buffer.h (BUF_BYTES_MAX): New macro.
5839 * lisp.h (STRING_BYTES_MAX): New macro.
5840 * alloc.c (Fmake_string):
5841 * character.c (string_escape_byte8):
5842 * coding.c (coding_alloc_by_realloc):
5843 * doprnt.c (doprnt):
5844 * editfns.c (Fformat):
5845 * eval.c (verror):
5846 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5847 since they may not be the same number.
5848 * editfns.c (Finsert_char):
5849 * fileio.c (Finsert_file_contents):
5850 Likewise for BUF_BYTES_MAX.
5851
dd52fcea
PE
5852 * image.c: Use ptrdiff_t, not int, for sizes.
5853 (slurp_file): Switch from int to ptrdiff_t.
5854 All uses changed.
5855 (slurp_file): Check that file size fits in both size_t (for
5856 malloc) and ptrdiff_t (for sanity and safety).
5857
7f9bbdbb
PE
5858 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5859 if b->modtime has its maximal value.
5860
dfe18f82
PE
5861 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5862
84acfcf0
PE
5863 Don't assume time_t can fit into int.
5864 * buffer.h (struct buffer.modtime): Now time_t, not int.
5865 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5866 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5867
ccd9a01a
PE
5868 Minor fixes for signed vs unsigned integers.
5869 * character.h (MAYBE_UNIFY_CHAR):
5870 * charset.c (maybe_unify_char):
5871 * keyboard.c (read_char, reorder_modifiers):
5872 XINT -> XFASTINT, since the integer must be nonnegative.
5873 * ftfont.c (ftfont_spec_pattern):
5874 * keymap.c (access_keymap, silly_event_symbol_error):
5875 XUINT -> XFASTINT, since the integer must be nonnegative.
5876 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5877 since it makes no difference and we prefer signed.
5878 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5879 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5880 nonnegative.
5881
d6d100dd
SM
58822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5883
5884 * window.h (Fwindow_frame): Declare.
5885
2b6148e4
PE
58862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5887
5888 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5889 (SPARE_MEMORY): Always define.
5890 (LARGE_REQUEST): Remove.
5891 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5892
f230ecc9
MR
58932011-06-06 Martin Rudalics <rudalics@gmx.at>
5894
727e958e
MR
5895 * lisp.h: Move EXFUNS for Fframe_root_window,
5896 Fframe_first_window and Fset_frame_selected_window to window.h.
5897
5898 * window.h: Move EXFUNS for Fframe_root_window,
5899 Fframe_first_window and Fset_frame_selected_window here from
5900 lisp.h.
5901
5902 * frame.c (Fwindow_frame, Fframe_first_window)
5903 (Fframe_root_window, Fframe_selected_window)
5904 (Fset_frame_selected_window): Move to window.c.
5905 (Factive_minibuffer_window): Move to minibuf.c.
5906 (Fother_visible_frames_p): New function.
5907
5908 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5909
f230ecc9
MR
5910 * window.c (decode_window, decode_any_window): Move up in code.
5911 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5912 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5913 (Fwindow_buffer): Move up and rewrite doc-string.
5914 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5915 (Fwindow_prev): New functions.
727e958e
MR
5916 (Fwindow_frame): Move here from frame.c. Accept any window as
5917 argument.
5918 (Fframe_root_window, Fframe_first_window)
5919 (Fframe_selected_window): Move here from frame.c. Accept frame
5920 or arbitrary window as argument. Update doc-strings.
5921 (Fminibuffer_window): Move up in code.
5922 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5923 (Fset_frame_selected_window): Move here from frame.c.
5924 Marginal rewrite.
727e958e
MR
5925 (Fselected_window, select_window, Fselect_window): Move up in
5926 code. Minor doc-string fixes.
f230ecc9 5927
4d09bcf6
PE
59282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5929
5930 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5931 Do not assume that spare memory exists; that assumption is valid
5932 only if SYSTEM_MALLOC.
5933 (LARGE_REQUEST): New macro, so that the issue of large requests
5934 is separated from the issue of spare memory.
5935
810928a2
AS
59362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5937
172418ad
AS
5938 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5939 format. (Bug#8806)
5940
43f862f7
AS
5941 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5942
810928a2
AS
5943 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5944 before statements.
5945
a059fe24
JD
59462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5947
5948 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5949
5950 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5951
5952 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5953 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5954
989bf368
JB
59552011-06-05 Juanma Barranquero <lekktu@gmail.com>
5956
5957 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5958
4b80f674
CY
59592011-06-04 Chong Yidong <cyd@stupidchicken.com>
5960
5961 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5962 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5963 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5964 New error handlers.
4b80f674
CY
5965 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5966 Obey Vx_select_enable_clipboard_manager. Catch errors in
5967 x_clipboard_manager_save (Bug#8779).
5968 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5969 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5970
99a33b77 59712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5972
5973 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5974
99a33b77 59752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5976
5977 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5978 in the current matrix if keep_current_p is non-zero.
5979
8264569d
EZ
59802011-06-04 Eli Zaretskii <eliz@gnu.org>
5981
5982 * bidi.c (bidi_level_of_next_char): Fix last change.
5983
57f97249
EZ
59842011-06-03 Eli Zaretskii <eliz@gnu.org>
5985
fec2107c 5986 Support bidi reordering of text covered by display properties.
57f97249 5987
fec2107c
EZ
5988 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5989 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5990 (bidi_cache_search, bidi_cache_iterator_state)
5991 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5992 (bidi_level_of_next_char, bidi_move_to_visually_next):
5993 Support character positions inside a run of characters covered by a
fec2107c
EZ
5994 display string.
5995 (bidi_paragraph_init, bidi_resolve_explicit_1)
5996 (bidi_level_of_next_char): Call bidi_fetch_char and
5997 bidi_fetch_char_advance instead of FETCH_CHAR and
5998 FETCH_CHAR_ADVANCE.
5999 (bidi_init_it): Initialize new members.
6000 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6001 definitions.
6002 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6003 instead of using explicit *_CHAR codes.
d6d100dd
SM
6004 (bidi_resolve_explicit, bidi_resolve_weak):
6005 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6006 bidirectional text is supported only in multibyte buffers.
6007 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6008 it to initialize the frame_window_p member of struct bidi_it.
6009 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6010 (bidi_resolve_explicit, bidi_resolve_weak)
6011 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6012 bidi_it->nchars is non-positive.
6013 (bidi_level_of_next_char): Don't try to lookup the cache for the
6014 next/previous character if nothing is cached there yet, or if we
6015 were just reseat()'ed to a new position.
c40e2fb2 6016
0e14fe90
EZ
6017 * xdisp.c (set_cursor_from_row): Set start and stop points
6018 according to the row's direction when priming the loop that looks
6019 for the glyph on which to display cursor.
6020 (single_display_spec_intangible_p): Function deleted.
6021 (display_prop_intangible_p): Reimplement to call
6022 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6023 Accept 3 additional arguments needed by handle_display_spec.
6024 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6025 values: lists, `(when COND...)' forms, etc.
6026 (single_display_spec_string_p): Support property values that are
6027 lists with the argument STRING its top-level element.
6028 (display_prop_string_p): Fix the condition for processing a
6029 property that is a list to be consistent with handle_display_spec.
fec2107c 6030 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6031 last portion of handle_display_prop.
6032 (compute_display_string_pos): Accept additional argument
6033 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6034 value of a `display' property is a "replacing spec".
6035 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6036 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6037 the display property, but just return a value indicating whether
6038 the display property will replace the characters it covers.
6039 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6040 frame_window_p members of struct bidi_it.
d6d100dd
SM
6041 (compute_display_string_pos, compute_display_string_end):
6042 New functions.
fec2107c
EZ
6043 (push_it): Accept second argument POSITION, where pop_it should
6044 jump to continue iteration.
6045 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6046
fec2107c
EZ
6047 * keyboard.c (adjust_point_for_property): Adjust the call to
6048 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6049
6050 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6051 (bidi_init_it): Update prototypes.
6052 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6053 (compute_display_string_pos, compute_display_string_end):
6054 Declare prototypes.
fec2107c
EZ
6055 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6056 EMACS_INT.
fc6f18ce 6057
40087514 60582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6059
57f53182
PE
6060 Malloc failure behavior now depends on size of allocation.
6061 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6062 * lisp.h: Change signatures accordingly.
6063 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6064 All callers changed. (Bug#8762)
6065
6066 * gnutls.c: Use Emacs's memory allocators.
6067 Without this change, the gnutls library would invoke malloc etc.
6068 directly, which causes problems on non-SYNC_INPUT hosts, and which
6069 runs afoul of improving memory_full behavior. (Bug#8761)
6070 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6071 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6072 xfree instead of the default malloc, realloc, free.
6073 (Fgnutls_boot): No need to check for memory allocation failure,
6074 since xmalloc does that for us.
6075
ac32cd99 6076 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6077 * category.c (hash_get_category_set):
6078 * ccl.c (ccl_driver):
6079 * charset.c (Fdefine_charset_internal):
6080 * charset.h (struct charset.hash_index):
6081 * composite.c (get_composition_id, gstring_lookup_cache)
6082 (composition_gstring_put_cache):
6083 * composite.h (struct composition.hash_index):
6084 * dispextern.h (struct image.hash):
6085 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6086 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6087 (hashfn_equal, hashfn_user_defined, make_hash_table)
6088 (maybe_resize_hash_table, hash_lookup, hash_put)
6089 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6090 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6091 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6092 * image.c (make_image, search_image_cache, lookup_image)
6093 (xpm_put_color_table_h):
6094 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6095 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6096 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6097 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6098 * alloc.c (allocate_vectorlike):
6099 Check for overflow in vector size calculations.
6100 * ccl.c (ccl_driver):
6101 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6102 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6103 need to be updated by these changes.
40087514
PE
6104 * fns.c (make_hash_table, maybe_resize_hash_table):
6105 Check for integer overflow with large hash tables.
0de4bb68
PE
6106 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6107 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6108 (SXHASH_REDUCE): New macro.
6109 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6110 Use it instead of discarding useful hash info with large hash values.
6111 (sxhash_float): New function.
6112 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6113 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6114 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6115 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6116 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6117 Adjust signatures to match updated version of code.
6118 (consing_since_gc): Now EMACS_INT, since a single hash table can
6119 use more than INT_MAX bytes.
6120
698d32e2
DN
61212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6122
6123 Make it possible to build with GCC-4.6+ -O2 -flto.
6124
6125 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6126
fd6fa53f
SM
61272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6128
6129 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6130 Call minibuffer-inactive-mode.
6131
864db017
JB
61322011-05-31 Juanma Barranquero <lekktu@gmail.com>
6133
6134 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6135 Update dependencies.
6136
2ad0baf4
DN
61372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6138
6139 * data.c (init_data): Remove code for UTS, this system is not
6140 supported anymore.
6141
4fcc2638
DN
61422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6143
6144 Don't force ./temacs to start in terminal mode.
6145
6146 * frame.c (make_initial_frame): Initialize faces in all cases, not
6147 only when CANNOT_DUMP is defined.
6148 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6149
c56e0fd5
DN
61502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6151
6152 * dispnew.c (add_window_display_history): Use const for the string
6153 pointer. Remove declaration, not needed.
6154
333d54da 61552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6156
55d4c1b2 6157 Use 'inline', not 'INLINE'.
333d54da 6158 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6159 * alloc.c, fontset.c (INLINE): Remove.
6160 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6161 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6162 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6163 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6164 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6165
738db178
DN
61662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6167
6168 Make it possible to run ./temacs.
6169
6170 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6171 syms_of_callproc does the same thing. Remove test for
6172 "initialized", do it in the caller.
6173 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6174
620c53a6
SM
61752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6176
6177 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6178 (read_minibuf): Use get_minibuffer.
6179 (syms_of_minibuf): Use DEFSYM.
6180 (Qmetadata): New var.
6181 * data.c (Qbuffer): Don't make it static.
6182 (syms_of_data): Use DEFSYM.
6183
e003a292
PE
61842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6185
6186 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6187 (CCL_CODE_MIN): New macro.
6188
ed008a6d
PE
61892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6190
3687c2ef
PE
6191 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6192
ed008a6d
PE
6193 * eval.c (Qdebug): Now static.
6194 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6195 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6196 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6197
d66c4c7c
CY
61982011-05-29 Chong Yidong <cyd@stupidchicken.com>
6199
6200 * image.c: Various fixes to ImageMagick code comments.
6201 (Fimagemagick_types): Doc fix.
6202
5fbc2025
PE
62032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6204
0196f88a
PE
6205 Minor fixes prompted by GCC 4.6.0 warnings.
6206
6207 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6208
5fbc2025
PE
6209 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6210 (x_clipboard_manager_save_all): Move extern decl to ...
6211 * xterm.h: ... here, so that it can be checked for consistency.
6212
1dd3c2d9
CY
62132011-05-29 Chong Yidong <cyd@stupidchicken.com>
6214
6215 * xselect.c (x_clipboard_manager_save_frame)
6216 (x_clipboard_manager_save_all): New functions.
6217 (Fx_clipboard_manager_save): Lisp function deleted.
6218
6219 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6220 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6221
6222 * xterm.h: Update prototype.
6223
5ba6571d
WX
62242011-05-28 William Xu <william.xwl@gmail.com>
6225
6226 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6227 exiting (Bug#8239).
6228
3eaff834
JM
62292011-05-28 Jim Meyering <meyering@redhat.com>
6230
e1900994 6231 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6232 * fns.c (to_uchar): Define.
6233 (crypto_hash_function): Use it to convert some newly-signed
6234 variables to unsigned, to avoid sign-extension bugs. For example,
6235 without this change, (md5 "truc") would evaluate to
6236 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6237 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6238 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6239
0f6990a7
PE
62402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6241
6242 Integer overflow fixes.
c8a9ca5a 6243
08686060
PE
6244 * dbusbind.c: Serial number integer overflow fixes.
6245 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6246 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6247 to hold a serial number that is too large for a fixnum.
6248 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6249 Check for serial numbers out of range. Decode any serial number
59568bf0 6250 that was so large that it became a float. (Bug#8722)
08686060 6251
2d1fc3c7
PE
6252 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6253 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6254 Use XFASTINT rather than XUINT when numbers are nonnegative.
6255 (xd_append_arg, Fdbus_method_return_internal):
6256 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6257 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6258 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6259 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6260 (Bug#8722)
2d1fc3c7 6261
c8a9ca5a
PE
6262 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6263
519e1d69
PE
6264 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6265
6df6ae42 6266 ccl: Add integer overflow checks.
30569699
PE
6267 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6268 (IN_INT_RANGE): New macros.
6269 (ccl_driver): Use them to check for integer overflow when
6270 decoding a CCL program. Many of the new checks are whether XINT (x)
6271 fits in int; it doesn't always, on 64-bit hosts. The new version
6272 doesn't catch all possible integer overflows, but it's an
847044ea 6273 improvement. (Bug#8719)
30569699 6274
c11285dc
PE
6275 * alloc.c (make_event_array): Use XINT, not XUINT.
6276 There's no need for unsigned here.
6277
fdccd48e
PE
6278 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6279 This follows up to the 2011-05-06 change that substituted uintptr_t
6280 for EMACS_INT. This case wasn't caught back then.
6281
37910ab2
PE
6282 Rework Fformat to avoid integer overflow issues.
6283 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6284 now (part of C89). Include <verify.h>.
6285 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6286 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6287 (Fformat): Avoid the prepass trying to compute sizes; it was only
6288 approximate and thus did not catch overflow reliably. Instead, walk
6289 through the format just once, formatting and computing sizes as we go,
6290 checking for integer overflow at every step, and allocating a larger
6291 buffer as needed. Keep track separately whether the format is
6292 multibyte. Keep only the most-recently calculated precision, rather
6293 than them all. Record whether each argument has been converted to
6294 string. Use EMACS_INT, not int, for byte and char and arg counts.
6295 Support field widths and precisions larger than INT_MAX. Avoid
6296 sprintf's undefined behavior with conversion specifications such as %#d
6297 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6298 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6299 formatting out-of-range floating point numbers with int
9173deec 6300 formats. (Bug#8668)
37910ab2 6301
2e6578fb
PE
6302 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6303
0ae6bdee
PE
6304 * data.c: Avoid integer truncation in expressions involving floats.
6305 * data.c: Include <intprops.h>.
6306 (arith_driver): When there's an integer overflow in an expression
6307 involving floating point, convert the integers to floating point
6308 so that the resulting value does not suffer from catastrophic
6309 integer truncation. For example, on a 64-bit host (* 4
6310 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6311 Do not rely on undefined behavior after integer overflow.
6312
de883a70
PE
6313 merge count_size_as_multibyte, parse_str_to_multibyte
6314 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6315 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6316 Check for integer overflow.
6317 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6318 since it's now a duplicate of the other. This is more of
6319 a character than a buffer op, so better that it's in character.c.
6320 * fns.c, print.c: Adjust to above changes.
6321
2ff916cb
PE
63222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6323
6324 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6325
f1b54466
PE
63262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6327
fb1ac845
PE
6328 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6329 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6330 (x_clipboard_manager_save): Now static.
6331 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6332
f1b54466
PE
6333 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6334 (crypto_hash_function): Now static.
6335 Fix pointer signedness problems. Avoid unnecessary initializations.
6336
a9f737ee
CY
63372011-05-27 Chong Yidong <cyd@stupidchicken.com>
6338
6339 * termhooks.h (Vselection_alist): Make it terminal-local.
6340
6341 * terminal.c (create_terminal): Initialize it.
6342
6343 * xselect.c: Support for clipboard managers.
6344 (Vselection_alist): Move to termhooks.h as terminal-local var.
6345 (LOCAL_SELECTION): New macro.
6346 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6347 (symbol_to_x_atom): Remove gratuitous arg.
6348 (x_handle_selection_request, lisp_data_to_selection_data)
6349 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6350 (x_own_selection, x_get_local_selection, x_convert_selection):
6351 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6352 (some_frame_on_display): Delete unused function.
6353 (Fx_own_selection_internal, Fx_get_selection_internal)
6354 (Fx_disown_selection_internal, Fx_selection_owner_p)
6355 (Fx_selection_exists_p): New optional frame arg.
6356 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6357 (x_handle_selection_clear): Don't treat other terminals with the
6358 same keyboard specially. Use the terminal-local Vselection_alist.
6359 (x_clear_frame_selections): Use Frun_hook_with_args.
6360
6361 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6362
6363 * xterm.h: Add support for those atoms.
6364
e067f0c1
CY
63652011-05-26 Chong Yidong <cyd@stupidchicken.com>
6366
6367 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6368 (converted_selections, conversion_fail_tag): New global variables.
6369 (x_selection_request_lisp_error): Free the above.
6370 (x_get_local_selection): Remove unnecessary code.
6371 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6372 of converted selections stored in converted_selections.
6373 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6374 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6375 (x_convert_selection): New function.
6376 (x_handle_selection_event): Simplify.
6377 (x_get_foreign_selection): Don't ignore incoming requests while
6378 waiting for an answer; this will fail when we implement
6379 SAVE_TARGETS, and seems unnecessary anyway.
6380 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6381 (Vx_sent_selection_functions): Doc fix.
6382
0f4aebc0
LL
63832011-05-26 Leo Liu <sdl.web@gmail.com>
6384
6385 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6386
e61124cd
YM
63872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6388
6389 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6390
6391 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6392 for fringe update if it has periodic bitmap.
ac389d0c 6393 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6394 and fringe_bitmap_periodic_p.
6395
6396 * fringe.c (get_fringe_bitmap_data): New function.
6397 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6398 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6399 row. Mark glyph row for fringe update if periodicity changed.
6400
6401 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6402 for fringe update unless it has periodic bitmap.
6403
f16d9837
KH
64042011-05-25 Kenichi Handa <handa@m17n.org>
6405
6406 * xdisp.c (get_next_display_element): Set correct it->face_id for
6407 a static composition.
6408
e1b90ef6
LL
64092011-05-24 Leo Liu <sdl.web@gmail.com>
6410
6411 * deps.mk (fns.o):
6412 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6413
6414 * fns.c (crypto_hash_function, Fsha1): New function.
6415 (Fmd5): Use crypto_hash_function.
6416 (syms_of_fns): Add Ssha1.
6417
7400048f
PE
64182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6419
6420 * gnutls.c: Remove unused macros.
6421 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6422 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6423 Remove macros that are defined and never used.
6424 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6425
abb71cf4
CY
64262011-05-22 Chong Yidong <cyd@stupidchicken.com>
6427
6428 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6429 (Fx_get_selection_internal): Minor cleanup.
6430 (Fx_own_selection_internal): Rename arguments for consistency with
6431 select.el.
6432
6307db39
PE
64332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6434
6435 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6436
f3d4e0a4
CY
64372011-05-22 Chong Yidong <cyd@stupidchicken.com>
6438
6439 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6440
4d8ade89
YM
64412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6442
6443 * dispnew.c (scrolling_window): Don't exclude the case that the
6444 last enabled row in the desired matrix touches the bottom boundary.
6445
32078c8d
GM
64462011-05-21 Glenn Morris <rgm@gnu.org>
6447
6448 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6449 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6450 and add some more files.
32078c8d 6451
7285dc67
EZ
64522011-05-20 Eli Zaretskii <eliz@gnu.org>
6453
6454 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6455 report_file_error introduced by the change from 2011-05-07.
6456
89d1bd22
PE
64572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6458
6459 * systime.h (Time): Define only if emacs is defined.
6460 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6461 where the include path doesn't have X11/X.h by default. See
6462 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6463
cd394be1 64642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6465
6466 * composite.c (find_automatic_composition): Fix previous change.
6467
b9704ad9
GM
64682011-05-20 Glenn Morris <rgm@gnu.org>
6469
6470 * lisp.mk: New file, split from Makefile.in.
6471 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6472 (shortlisp): Remove.
6473 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6474
4a720484
GM
64752011-05-19 Glenn Morris <rgm@gnu.org>
6476
6477 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6478 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6479 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6480 (lisp): Set the order to that of loadup.el.
6481 (shortlisp): Make it a copy of $lisp.
6482 (SOME_MACHINE_LISP): Remove.
6483 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6484 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6485
a28d4396
KH
64862011-05-18 Kenichi Handa <handa@m17n.org>
6487
6488 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6489 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6490 (find_automatic_composition): Mostly rewrite for efficiency.
6491
a2b1fa8e
JB
64922011-05-18 Juanma Barranquero <lekktu@gmail.com>
6493
6494 * makefile.w32-in: Update dependencies.
6495
8e1f5610
CS
64962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6497
6498 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6499 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6500
7025ee00 65012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6502
cdfa6eab
PE
6503 Fix some integer overflow issues, such as string length overflow.
6504
06d6db33
PE
6505 * insdel.c (count_size_as_multibyte): Check for string overflow.
6506
2b4560a8
PE
6507 * character.c (lisp_string_width): Check for string overflow.
6508 Use EMACS_INT, not int, for string indexes and lengths; in
6509 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6510 the resulting string length overflows an EMACS_INT; instead,
6511 report a string overflow if no precision given. When checking for
6512 precision exhaustion, use a check that cannot possibly have
6513 integer overflow. (Bug#8675)
6514 * character.h (lisp_string_width): Adjust to new signature.
6515
cb93f9be
PE
6516 * alloc.c (string_overflow): New function.
6517 (Fmake_string): Use it. This doesn't change behavior, but saves
6518 a few bytes and will simplify future changes.
6519 * character.c (string_escape_byte8): Likewise.
6520 * lisp.h (string_overflow): New decl.
6521
1a1f3366
PE
6522 Fixups, following up to the user-interface timestamp change.
6523 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6524 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6525 * msdos.c (mouse_get_pos): Likewise.
6526 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6527 * w32gui.h (Time): Define by including "systime.h" rather than by
6528 declaring it ourselves. (Bug#8664)
6529
d4e3e4d3
PE
6530 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6531 * image.c (clear_image_cache): Likewise.
6532
f6a24d19
PE
6533 * term.c (term_mouse_position): Don't assume time_t wraparound.
6534
08dc5ae6
PE
6535 Be more systematic about user-interface timestamps.
6536 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6537 and sometimes 'EMACS_UINT', to represent these timestamps.
6538 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6539 This makes the code easier to follow, and makes it easier to catch
6540 integer overflow bugs such as Bug#8664.
6541 * frame.c (Fmouse_position, Fmouse_pixel_position):
6542 Use Time, not unsigned long, for user-interface timestamps.
6543 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6544 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6545 * keyboard.h (last_event_timestamp): Likewise.
6546 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6547 * menu.h (xmenu_show): Likewise.
6548 * term.c (term_mouse_position): Likewise.
6549 * termhooks.h (struct input_event.timestamp): Likewise.
6550 (struct terminal.mouse_position_hook): Likewise.
6551 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6552 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6553 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6554 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6555 what it was before.
6556 * menu.h, termhooks.h: Include "systime.h", for Time.
6557
8e55734a
PE
6558 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6559 Don't assume that the difference between two unsigned long values
6560 can fit into an integer. At this point, we know button_down_time
6561 <= event->timestamp, so the difference must be nonnegative, so
6562 there's no need to cast the result if double-click-time is
6563 nonnegative, as it should be; check that it's nonnegative, just in
6564 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6565 apart (about 25 days). (Bug#8664)
8e55734a 6566
841f1b75 6567 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6568 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6569
3e26f69c
PE
6570 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6571 that always fit in int. Use a sentinel instead of a counter, to
6572 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6573 * frame.h (struct frame): Use int for menu_bar_items_used
6574 instead of EMACS_INT, since it always fits in int.
3e26f69c 6575
5cc152c0
PE
6576 * menu.c (grow_menu_items): Check for int overflow.
6577
d89eb65e
PE
6578 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6579
5235bd3e
PE
6580 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6581 Before, the code was not consistent. These values cannot exceed
6582 2**31 - 1 so there's no need to make them unsigned.
6583 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6584 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6585 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6586 as modifiers.
6587 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6588
bc827e23
PE
6589 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6590 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6591 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6592 presumably because the widths might not match.
6593
78eb494e
PE
6594 * window.c (size_window): Avoid needless test at loop start.
6595
04f2d78b
CB
65962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6597
6598 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6599
d2fc7e3d 66002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6601
6602 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6603
d2fc7e3d 66042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6605
6606 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6607 `width' to `bar_area_x' and `bar_area_width', respectively.
6608 (x_scroll_run): Take account of fringe background extension.
6609
04f2d78b
CB
6610 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6611 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6612 `bar_area_width', respectively.
6613 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6614 background extension.
6615
79b70037
GM
66162011-05-10 Jim Meyering <meyering@redhat.com>
6617
6618 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6619
2f142cc5
JB
66202011-05-10 Juanma Barranquero <lekktu@gmail.com>
6621
6622 * image.c (Finit_image_library): Return t for built-in image types,
6623 like pbm and xbm. (Bug#8640)
6624
57679c86
AS
66252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6626
6627 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6628
888c9e86
EZ
66292011-05-07 Eli Zaretskii <eliz@gnu.org>
6630
b0512a1d
EZ
6631 * w32console.c (Fset_screen_color): Doc fix.
6632 (Fget_screen_color): New function.
6633 (syms_of_ntterm): Defsubr it.
6634
7285dc67
EZ
6635 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6636 unlink the temporary file if Fcall_process didn't create it in the
6637 first place.
6638 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6639 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6640 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6641 cue to call_process_cleanup not to close that handle.
6642
4d3fcc8e
BK
66432011-05-07 Ben Key <bkey76@gmail.com>
6644
6645 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6646 one of two shell specific rules, either bootstrap-temacs-CMD or
6647 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6648 to the previous implementation of the bootstrap-temacs rule.
6649 The bootstrap-temacs-CMD rule is similar to the previous
6650 implementation of the bootstrap-temacs rule except that it
6651 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6652 variable.
6653
6654 These changes, along with some changes to nt/configure.bat,
6655 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6656 earlier fix to add support for --cflags and --ldflags options
6657 that include quotes so that it works whether make uses cmd or
6658 sh as the shell.
6659
b4289b64
MA
66602011-05-06 Michael Albinus <michael.albinus@gmx.de>
6661
6662 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6663 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6664 is a constant.
6665 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6666 a string. Handle both cases.
6667 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6668 (Fdbus_register_method): Use Qinvalid_function.
6669
af4c0e28
JB
66702011-05-06 Juanma Barranquero <lekktu@gmail.com>
6671
6672 * makefile.w32-in: Update dependencies.
6673 (LISP_H): Add inttypes.h and stdin.h.
6674 (PROCESS_H): Add unistd.h.
6675
c51453d9
EZ
66762011-05-06 Eli Zaretskii <eliz@gnu.org>
6677
6678 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6679 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6680
8ff0ac3c 66812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6682
4c4b566b
PE
6683 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6684
aab2b9b5
PE
6685 * term.c (vfatal): Remove stray call to va_end.
6686 It's not needed and the C Standard doesn't allow it here anyway.
6687
c378da0b
PE
6688 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6689 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6690
288b08c7
PE
6691 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6692 bytes.
6693
e3601888
PE
6694 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6695
db6c0e74
PE
6696 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6697
dd5963ea
PE
6698 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6699
88c9450f
PE
6700 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6701
2f9442b8
PE
6702 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6703
c032b5f8
PE
6704 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6705 * charset.c (Fdefine_charset_internal): Don't initialize
6706 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6707 32-bit int (Bug#8600).
a108c10b
PE
6708
6709 * lread.c (read_integer): Be more consistent with string-to-number.
6710 Use string_to_number to do the actual conversion; this avoids
6711 rounding errors and fixes some other screwups. Without this fix,
6712 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6713 (digit_to_number): Move earlier, for benefit of read_integer.
6714 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6715 not a digit in any supported base. (Bug#8602)
a108c10b 6716
ad5f9eea
PE
6717 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6718
aec1708a
PE
6719 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6720 to match comment at start of function. This also removes a
6721 GCC warning about overflow in a 32+64-bit port.
6722
47be4ab5
PE
6723 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6724
371cac43
PE
6725 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6726 Reported by Stefan Monnier in
6727 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6728 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6729 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6730
d01a7826
PE
6731 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6732 (EMACS_UINTPTR): Likewise, with uintptr_t.
6733
7fd47d5c
PE
6734 * lisp.h: Prefer 64-bit EMACS_INT if available.
6735 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6736 on 32-bit hosts that have 64-bit int, so that they can access
6737 large files.
122b0c86
PE
6738 However, temporarily disable this change unless the temporary
6739 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6740
8727937b
PE
6741 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6742
8ac068ac
PE
6743 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6744 This removes an assumption that EMACS_INT and long are the same
6745 width as pointers. The assumption is true for Emacs porting targets
6746 now, but we want to make other targets possible.
6747 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6748 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6749 In the rest of the code, change types of integers that hold casted
6750 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6751 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6752 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6753 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6754 No need to cast type when ORing.
6755 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6756 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6757 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6758 assume EMACS_INT is the same width as char *.
6759 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6760 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6761 Remove no-longer-needed casts.
6762 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6763 (xg_tool_bar_help_callback, xg_make_tool_item):
6764 Use EMACS_INTPTR to hold an integer
6765 that will be cast to void *; this can avoid a GCC warning
6766 if EMACS_INT is not the same width as void *.
6767 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6768 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6769 (current_message_1, set_message_1):
6770 Use a local to convert to proper width without a cast.
6771 * xmenu.c (dialog_selection_callback): Likewise.
6772
ede49d71
PE
6773 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6774 Also, don't assume VALBITS / RAND_BITS is less than 5,
6775 and don't rely on undefined behavior when shifting a 1 left into
6776 the sign bit.
6777 * lisp.h (get_random): Change signature to match.
6778
2f30ecd0
PE
6779 * lread.c (hash_string): Use size_t, not int, for hash computation.
6780 Normally we prefer signed values; but hashing is special, because
6781 it's better to use unsigned division on hash table sizes so that
6782 the remainder is nonnegative. Also, size_t is the natural width
6783 for hashing into memory. The previous code used 'int', which doesn't
6784 retain enough info to hash well into very large tables.
6785 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6786
2a866e7b
PE
6787 * dbusbind.c: Don't possibly lose pointer info when converting.
6788 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6789 Use XPNTR rather than XHASH, so that the high-order bits of
6790 the pointer aren't lost when converting through void *.
6791
51639eac
PE
6792 * eval.c (Fautoload): Don't double-shift a pointer.
6793
92394119
PE
6794 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6795
dbdb9a7c
JB
67962011-05-06 Juanma Barranquero <lekktu@gmail.com>
6797
6798 * gnutls.c (DEF_GNUTLS_FN):
6799 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6800
db7a0b4f
AS
68012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6802
6803 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6804 marker. (Bug#8610)
6805
cd394be1 68062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6807
6808 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6809 New version that can reserve upto 2GB of heap space.
6810
f7ff1b0f 68112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6812
6813 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6814
639c109b
TZ
68152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6816
6817 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6818 `gnutls_certificate_set_x509_key_file'.
6819
d2127135
JB
68202011-05-05 Juanma Barranquero <lekktu@gmail.com>
6821
6822 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6823 Update dependencies.
6824
e968f4f3
JB
68252011-05-04 Juanma Barranquero <lekktu@gmail.com>
6826
6827 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6828 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6829 Remove unused parameter `fildes'.
6830 * process.c (read_process_output, send_process): Don't pass it.
6831
84d358f0
JB
68322011-05-04 Juanma Barranquero <lekktu@gmail.com>
6833
6834 Fix previous change: the library cache is defined in w32.c.
6835 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6836 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6837
0898ca10
JB
68382011-05-04 Juanma Barranquero <lekktu@gmail.com>
6839
6840 Implement dynamic loading of GnuTLS on Windows.
6841
6842 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6843 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6844 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6845 Declare.
6846
6847 * gnutls.c (Qgnutls_dll): Define.
6848 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6849 (gnutls_*): Declare function pointers.
6850 (init_gnutls_functions): New function to initialize function pointers.
6851 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6852 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6853 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6854 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6855 (emacs_gnutls_write, emacs_gnutls_read)
6856 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6857 (Fgnutls_available_p): New function.
6858 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6859 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6860 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6861
6862 * image.c: Include w32.h.
6863 (Vimage_type_cache): Delete.
6864 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6865 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6866 (w32_delayed_load): Move to w32.c.
6867
6868 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6869
6870 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6871 (w32_delayed_load): Move from image.c. When loading a library, record
6872 its filename in the :loaded-from property of the library id.
6873 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6874 Initialize and staticpro them.
6875 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6876
6877 * process.c: Include lisp.h before w32.h, not after.
6878 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6879 instead of gnutls_record_check_pending.
6880
6881 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6882
ff4de4aa
TZ
68832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6884
6885 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6886 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6887 as passed in.
6888
abe95abb
JD
68892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6890
6891 * xterm.c (x_set_frame_alpha): Do not set property on anything
6892 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6893
e16e55d4
JB
68942011-05-02 Juanma Barranquero <lekktu@gmail.com>
6895
6896 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6897
bafcf6a5
JB
68982011-05-02 Juanma Barranquero <lekktu@gmail.com>
6899
6900 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6901 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6902 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6903 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6904 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6905 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6906 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6907 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6908 (Qgnutls_bootprop_callbacks_verify): Make static.
6909
e7a6747f
AS
69102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6911
19ed11ba
AS
6912 * callproc.c: Indentation fixup.
6913
e7a6747f 6914 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6915 (wait_for_termination, interruptible_wait_for_termination):
6916 Move after wait_for_termination_1.
e7a6747f 6917
1ef14cb4
LMI
69182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6919
6920 * sysdep.c (interruptible_wait_for_termination): New function
6921 which is like wait_for_termination, but allows keyboard
6922 interruptions.
6923
6924 * callproc.c (Fcall_process): Add (:file "file") as an option for
6925 the STDOUT buffer.
6926 (Fcall_process_region): Ditto.
6927
330d880c
EZ
69282011-04-30 Eli Zaretskii <eliz@gnu.org>
6929
8db90b73
EZ
6930 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6931 rather than `XVECTOR (FOO)->size'.
6932
330d880c
EZ
6933 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6934 inttypes.h, as a gnulib replacement is used if it not available in
6935 system headers.
6936
15cbd324
EZ
69372011-04-21 Eli Zaretskii <eliz@gnu.org>
6938
6939 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6940 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6941 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6942
6943 * coding.c (coding_alloc_by_realloc): Error out if destination
6944 will grow beyond MOST_POSITIVE_FIXNUM.
6945 (decode_coding_emacs_mule): Abort if there isn't enough place in
6946 charbuf for the composition carryover bytes. Reserve an extra
6947 space for up to 2 characters produced in a loop.
6948 (decode_coding_iso_2022): Abort if there isn't enough place in
6949 charbuf for the composition carryover bytes.
6950
69512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6952
ae940cca
EZ
6953 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6954 aborting when %lld or %lll format is passed.
6955 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6956 %llo or %llx format is passed. (Bug#8545)
6957
03ab8921
EZ
6958 * window.c (window_scroll_line_based): Use a marker instead of
6959 simple variables to record original value of point. (Bug#7952)
6960
afda1437
EZ
6961 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6962 produced by %s or %c overflows available buffer space. (Bug#8545)
6963
f76dee0c
PE
69642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6965
6966 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6967 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6968
fdc5744d
JB
69692011-04-28 Juanma Barranquero <lekktu@gmail.com>
6970
6971 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6972
638f053a
JB
69732011-04-28 Juanma Barranquero <lekktu@gmail.com>
6974
6975 * keyboard.c (Qdelayed_warnings_hook): Define.
6976 (command_loop_1): Run `delayed-warnings-hook'
6977 if Vdelayed_warnings_list is non-nil.
6978 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6979 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6980
d178f871
EZ
69812011-04-28 Eli Zaretskii <eliz@gnu.org>
6982
6983 * doprnt.c (doprnt): Don't return value smaller than the buffer
6984 size if the message was truncated. (Bug#8545).
6985
b124fd93
JB
69862011-04-28 Juanma Barranquero <lekktu@gmail.com>
6987
6988 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6989 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6990
e810457d
PE
69912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6992
6993 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6994
ea51cceb
JB
69952011-04-27 Juanma Barranquero <lekktu@gmail.com>
6996
6997 * makefile.w32-in: Update dependencies.
6998
94dcfacf
EZ
69992011-04-27 Eli Zaretskii <eliz@gnu.org>
7000
7001 Improve `doprnt' and its usage. (Bug#8545)
7002 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7003 `format_end'. Remove support for %l as a conversion specifier.
7004 Don't use xrealloc. Improve diagnostics when the %l size modifier
7005 is used. Update the commentary.
7006
7007 * eval.c (verror): Simplify calculation of size_t.
7008
7009 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7010 messages.
7011
f61f41d7
PE
70122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7013
7014 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7015 change.
7016
96fb4434
PE
70172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7018
7019 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7020 This makes this file independent of the recent pseudovector change.
7021
671875da 70222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7023
69e9b5a3
PE
7024 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7025
b5f869a7 7026 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7027 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7028 Remove unused local.
c8926152 7029 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7030
841a1577 7031 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7032 GCC 4.6.0 optimizes based on type-based alias analysis.
7033 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7034 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7035 != &v->size, and therefore "v->size = 1; b->size = 2; return
7036 v->size;" must therefore return 1. This assumption is incorrect
7037 for Emacs, since it type-puns struct Lisp_Vector * with many other
7038 types. To fix this problem, this patch adds a new type struct
f904488f 7039 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7040 and pseudovectors, and helps optimizing compilers not get fooled
7041 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7042 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7043 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7044 the size member.
eab3844f
PE
7045 (XSETPVECTYPE): Rewrite in terms of new macro.
7046 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7047 This is a bit clearer, and further avoids the possibility of
7048 undesirable aliasing.
7049 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7050 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7051 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7052 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7053 (ASIZE): Now uses header.size rather than size.
7054 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7055 to avoid the hassle of writing XVECTOR (foo)->header.size.
7056 (struct vectorlike_header): New type.
eab3844f
PE
7057 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7058 object, to help avoid aliasing.
7059 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7060 (SUBRP): Likewise, since Lisp_Subr is a special case.
7061 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7062 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7063 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7064 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7065 changed to be "header.size" and "header.next".
7066 * buffer.h (struct buffer): Likewise.
7067 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7068 * frame.h (struct frame): Likewise.
7069 * process.h (struct Lisp_Process): Likewise.
7070 * termhooks.h (struct terminal): Likewise.
7071 * window.c (struct save_window_data, struct saved_window): Likewise.
7072 * window.h (struct window): Likewise.
7073 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7074 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7075 * buffer.c (init_buffer_once): Likewise.
7076 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7077 special case.
7078 * process.c (Fformat_network_address): Use local var for size,
7079 for brevity.
7080
0df1eac5
PE
7081 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7082
847ab9d1 7083 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7084 * data.c (atof): Remove decl; no longer used or needed.
7085 (digit_to_number): Move to lread.c.
7086 (Fstring_to_number): Use new string_to_number function, to be
7087 consistent with how the Lisp reader treats infinities and NaNs.
7088 Do not assume that floating-point numbers represent EMACS_INT
7089 without losing information; this is not true on most 64-bit hosts.
7090 Avoid double-rounding errors, by insisting on integers when
7091 parsing non-base-10 numbers, as the documentation specifies.
7092 * lisp.h (string_to_number): New decl, replacing ...
7093 (isfloat_string): Remove.
bc0a5c13 7094 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7095 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7096 appears to have been a coding error. Similarly, do not accept
7097 strings like +-1e0 as floating point numbers. Do not report
7098 overflow for integer overflows unless the base is not 10 which
7099 means we have no simple and reliable way to continue.
7100 Break out the floating-point parsing into a new
7101 function string_to_number, so that Fstring_to_number parses
7102 floating point numbers consistently with the Lisp reader.
04f2d78b 7103 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7104 (E_CHAR, EXP_INT): Remove, replacing with ...
7105 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7106 (string_to_number): New function, replacing isfloat_string.
7107 This function checks for valid syntax and produces the resulting
7108 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7109 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7110 so that overflow for non-base-10 numbers is reported only when
7111 there's no portable and simple way to convert to floating point.
452f4150 7112
67769ffc
PE
7113 * textprop.c (set_text_properties_1): Rewrite for clarity,
7114 and to avoid GCC warning about integer overflow.
7115
c20db43f
PE
7116 * intervals.h (struct interval): Use EMACS_INT for members
7117 where EMACS_UINT might cause problems. See
7118 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7119 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7120 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7121 All uses changed.
37aa2f85
PE
7122 (offset_intervals): Tell GCC not to worry about length overflow
7123 when negating a negative length.
c20db43f 7124
2538aa2f
PE
7125 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7126 (overrun_check_free): Likewise.
7127
f2d3008d
PE
7128 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7129 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7130 word size.
7131
ec8df744
PE
7132 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7133 (gnutls_make_error): Rename local to avoid shadowing.
7134 (gnutls_emacs_global_deinit): ifdef out; not used.
7135 (Fgnutls_boot): Use const for pointer to readonly storage.
7136 Comment out unused local. Fix pointer signedness problems.
7137
640ee02d
PE
7138 * lread.c (openp): Don't stuff size_t into an 'int'.
7139 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7140 about possible signed overflow.
7141
6048fb2a
PE
7142 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7143 (GDK_KEY_g): Don't define if already defined.
7144 (xg_prepare_tooltip): Avoid pointer signedness problem.
7145 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7146
fa3c87e1
PE
7147 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7148 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7149
2172544b
PE
7150 * xfns.c (Fx_window_property): Simplify a bit,
7151 to make a bit faster and to avoid GCC 4.6.0 warning.
7152 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7153
9b821a21
PE
7154 * fns.c (internal_equal): Don't assume size_t fits in int.
7155
3c616cfa
PE
7156 * alloc.c (compact_small_strings): Tighten assertion a little.
7157
c2982e87
PE
7158 Replace pEd with more-general pI, and fix some printf arg casts.
7159 * lisp.h (pI): New macro, generalizing old pEd macro to other
7160 conversion specifiers. For example, use "...%"pI"d..." rather
7161 than "...%"pEd"...".
7162 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7163 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7164 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7165 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7166 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7167 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7168 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7169 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7170 64-bit hosts.
7171 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7172 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7173 * print.c (safe_debug_print, print_object): Likewise.
7174 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7175 to int.
6f04d126
PE
7176 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7177 avoiding the 0 flag, which is not portable.
c2982e87
PE
7178 * process.c (Fmake_network_process): Use pI to avoid cast.
7179 * region-cache.c (pp_cache): Likewise.
7180 * xdisp.c (decode_mode_spec): Likewise.
7181 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7182 behavior on 64-bit hosts with printf arg.
6f04d126 7183 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7184 (x_stop_queuing_selection_requests): Likewise.
7185 (x_get_window_property): Don't truncate byte count to an 'int'
7186 when tracing.
0b432f21 7187
5e073ec7
PE
7188 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7189 here, since it parses constructs like leading '-' and spaces,
7190 which are not wanted; and it overflows with large numbers.
7191 Instead, simply match F[0-9]+, which is what is wanted anyway.
7192
36372bf9
PE
7193 * alloc.c: Remove unportable assumptions about struct layout.
7194 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7195 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7196 (allocate_vectorlike, make_pure_vector): Use the new macros,
7197 plus offsetof, to remove unportable assumptions about struct layout.
7198 These assumptions hold on all porting targets that I know of, but
7199 they are not guaranteed, they're easy to remove, and removing them
7200 makes further changes easier.
7201
0b432f21
PE
7202 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7203 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7204 (string_overrun_cookie): Now const. Use initializers that
7205 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7206 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7207 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7208 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7209 multiple of sizeof (EMACS_INT); it need not be, if
7210 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7211 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7212
895009e1
JB
72132011-04-26 Juanma Barranquero <lekktu@gmail.com>
7214
7215 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7216
6a7a1b0b
TZ
72172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7218
7219 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7220 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7221 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7222
841a1577 72232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7224
7225 * lisp.h (Qdebug): List symbol.
895009e1 7226 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7227 * keyboard.c (debug-on-event): New variable.
7228 (handle_user_signal): Break into debugger when debug-on-event
7229 matches the current signal symbol.
7230
f2d3ba6f
DN
72312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7232
7233 * alloc.c (check_sblock, check_string_bytes)
7234 (check_string_free_list): Convert to standard C.
7235
42ce4c63
TZ
72362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7237
7238 * w32.c (emacs_gnutls_push): Fix typo.
7239
825cd63c
EZ
72402011-04-25 Eli Zaretskii <eliz@gnu.org>
7241
fb11d64d
EZ
7242 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7243 "cast to pointer from integer of different size".
7244
825cd63c
EZ
7245 Improve doprnt and its use in verror. (Bug#8545)
7246 * doprnt.c (doprnt): Document the set of format control sequences
7247 supported by the function. Use SAFE_ALLOCA instead of always
7248 using `alloca'.
7249
7250 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7251 is one byte too soon. Don't use xrealloc; instead xfree and
7252 xmalloc anew.
7253
e061a11b
TZ
72542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7255
7256 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7257 callbacks stage.
7258
7259 * gnutls.c: Renamed global_initialized to
7260 gnutls_global_initialized. Added internals for the
7261 :verify-hostname-error, :verify-error, and :verify-flags
7262 parameters of `gnutls-boot' and documented those parameters in the
7263 docstring. Start callback support.
9173deec
JB
7264 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7265 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7266 on error. Return error code.
e061a11b
TZ
7267 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7268 (emacs_gnutls_read): Likewise.
7269 (Fgnutls_boot): Return handshake error code.
7270 (emacs_gnutls_handle_error): New function.
7271 (wsaerror_to_errno): Likewise.
7272
7273 * w32.h (emacs_gnutls_pull): Add prototype.
7274 (emacs_gnutls_push): Likewise.
7275
7276 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7277 (emacs_gnutls_push): Likewise.
7278
72792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7280
7281 * process.c (wait_reading_process_output): Check if GnuTLS
7282 buffered some data internally if no FDs are set for TLS
7283 connections.
7284
7285 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7286 (LIBS): Link to USER_LIBS.
7287 ($(BLD)/gnutls.$(0)): New target.
7288
fa6996bc
EZ
72892011-04-24 Eli Zaretskii <eliz@gnu.org>
7290
eb35682e
EZ
7291 * xdisp.c (handle_single_display_spec): Rename the
7292 display_replaced_before_p argument into display_replaced_p, to
7293 make it consistent with the commentary. Fix typos in the
7294 commentary.
7295
e2ad650c
EZ
7296 * textprop.c (syms_of_textprop): Remove dead code.
7297 (copy_text_properties): Delete obsolete commentary about an
7298 interface that was deleted long ago. Fix typos in the description
7299 of arguments.
7300
1b2de274
EZ
7301 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7302 to changes in oldXMenu/XMenu.h from 2011-04-16.
7303 <menu_help_message, prev_menu_help_message>: Constify.
7304 (IT_menu_make_room): menu->help_text is now `const char **';
7305 adjust.
7306
7307 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7308 to changes in oldXMenu/XMenu.h from 2011-04-16.
7309 (struct XMenu): Declare `help_text' `const char **'.
7310
7311 * xfaces.c <Qunspecified>: Make extern again.
7312
7313 * syntax.c: Include sys/types.h before including regex.h, as
7314 required by Posix.
7315
762b15be
EZ
7316 * doc.c (get_doc_string): Improve the format passed to `error'.
7317
7318 * doprnt.c (doprnt): Improve commentary.
7319
7320 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7321
7322 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7323 them with etags.
7324
f1052e5d
EZ
7325 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7326 changes in globals.h immediately force recompilation.
762b15be
EZ
7327 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7328 $(CURDIR)/s/ms-w32.h.
7329 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7330
fa6996bc
EZ
7331 * character.c (Fchar_direction): Function deleted.
7332 (syms_of_character): Don't defsubr it.
7333 <char-direction-table>: Deleted.
7334
e6c3da20
EZ
73352011-04-23 Eli Zaretskii <eliz@gnu.org>
7336
7337 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7338 * doprnt.c: Include limits.h.
7339 (SIZE_MAX): New macro.
04f2d78b
CB
7340 (doprnt): Return a size_t value. 2nd arg is now size_t.
7341 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7342 Improve overflow protection. Support `l' modifier for integer
7343 conversions. Support %l conversion. Don't assume an EMACS_INT
7344 argument for integer conversions and for %c.
7345
7346 * lisp.h (doprnt): Restore prototype.
7347
7348 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7349 $(SRC)/character.h.
7350
7351 * Makefile.in (base_obj): Add back doprnt.o.
7352
7353 * deps.mk (doprnt.o): Add back prerequisites.
7354 (callint.o): Depend on character.h.
7355
7356 * eval.c (internal_lisp_condition_case): Include the handler
7357 representation in the error message.
7358 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7359 when breaking from the loop.
7360
7361 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7362
7363 * callint.c (Fcall_interactively): When displaying error message
7364 about invalid control letter, pass the character's codepoint, not
7365 a pointer to its multibyte form. Improve display of the character
7366 in octal and display also its hex code.
7367
7368 * character.c (char_string): Use %x to display the (unsigned)
7369 codepoint of an invalid character, to avoid displaying a bogus
7370 negative value.
7371
7372 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7373 `error', not SYMBOL_NAME itself.
7374
7375 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7376 character arguments to `error'.
7377
7378 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7379 to `error' in error message about FINAL_CHAR argument. Make sure
7380 FINAL_CHAR is a character, and use %c when it is passed as
7381 argument to `error'.
7382
4ffd0d6b 73832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7384
7385 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7386
7387 * w32.c: Include <time.h>.
7388 (sys_localtime): New function.
7389
4ffd0d6b 73902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7391
7392 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7393
4ffd0d6b 7394 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7395
4ffd0d6b 73962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7397
4ffd0d6b
GM
7398 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7399 zombies (Bug#8467).
aac0c6e3 7400
04c56954
EZ
74012011-04-19 Eli Zaretskii <eliz@gnu.org>
7402
7403 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7404 gl_state.e_property when gl_state.object is Qt.
7405
7406 * insdel.c (make_gap_larger): Remove limitation of buffer size
7407 to <= INT_MAX.
7408
16a43933
CY
74092011-04-18 Chong Yidong <cyd@stupidchicken.com>
7410
7411 * xdisp.c (lookup_glyphless_char_display)
7412 (produce_glyphless_glyph): Handle cons cell entry in
7413 glyphless-char-display.
7414 (Vglyphless_char_display): Document it.
7415
7416 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7417 glyphless-char-display.
7418
4581706e
CY
74192011-04-17 Chong Yidong <cyd@stupidchicken.com>
7420
7421 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7422
7423 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7424
7425 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7426 definition for no-X builds.
7427
4887c6e2 74282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7429
fd35b6f9
PE
7430 Static checks with GCC 4.6.0 and non-default toolkits.
7431
5c1ccb01
PE
7432 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7433
006c5daa
PE
7434 * process.c (keyboard_bit_set): Define only if SIGIO.
7435 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7436 (send_process): Repair possible setjmp clobbering.
7437
efc736d3
PE
7438 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7439
4e2fe2e6
PE
7440 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7441
f97334a2
PE
7442 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7443
4e75f29d
PE
7444 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7445 Define only if needed.
7446
90efadd1
PE
7447 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7448 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7449 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7450
3c647824
PE
7451 * dispextern.h (struct redisplay_interface): Rename param
7452 to avoid shadowing.
e264f262 7453 * termhooks.h (struct terminal): Likewise.
761383f4 7454 * xterm.c (xembed_send_message): Likewise.
3c647824 7455
b58c5c4a
PE
7456 * insdel.c (make_gap_smaller): Define only if
7457 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7458
cad59032
PE
7459 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7460 it.
7461
c339dc2e
PE
7462 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7463 so that we aren't warned about unused symbols.
7464
91a3e27b
PE
7465 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7466
399c71d3 7467 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7468
8ffc96f5
PE
7469 * xfns.c (x_real_positions): Mark locals as initialized.
7470
eef9bc79
PE
7471 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7472
098db9dd
PE
7473 * xterm.c: Fix problems found by static analysis with other toolkits.
7474 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7475 (x_dispatch_event): Declare static if USE_GTK, and
7476 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7477 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7478 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7479 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7480 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7481
eb18f6cc
PE
7482 * xmenu.c (menu_help_callback): Pointer type fixes.
7483 Use const pointers when pointing at readonly data. Avoid pointer
7484 signedness clashes.
7485 (FALSE): Remove unused macro.
7486 (update_frame_menubar): Remove unused decl.
7487
1fe72bf8
PE
7488 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7489
60d9e1db
PE
7490 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7491 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7492 (single_menu_item): Rename local to avoid shadowing.
7493
39261c26
PE
7494 * keyboard.c (make_lispy_event): Remove unused local var.
7495
018c5e19
PE
7496 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7497 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7498
63d2b86e
PE
7499 * bitmaps: Change bitmaps from unsigned char back to the X11
7500 compatible char. Avoid the old compiler warnings about
7501 out-of-range initializers by using, for example, '\xab' rather
7502 than 0xab.
7503
aefd87e1
PE
7504 * xgselect.c (xgselect_initialize): Check vs interface
7505 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7506
bf501fb9
PE
7507 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7508
e9829fdf
PE
7509 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7510 to read-only memory.
7511
1086c095
PE
7512 * fns.c (vector): Remove; this old hack is no longer needed.
7513
2baccd04 7514 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7515 Remove unused var.
dde42981 7516 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7517
72391843 7518 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7519
436c16df 7520 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7521 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7522 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7523
92bb796d 7524 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7525 (x_term_init): Remove local to avoid shadowing.
92bb796d 7526
764430a3 7527 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7528
7529 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7530 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7531
d1dfb56c
EZ
75322011-04-16 Eli Zaretskii <eliz@gnu.org>
7533
c4354cb4
EZ
7534 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7535
d1dfb56c
EZ
7536 Fix regex.c, syntax.c and friends for buffers > 2GB.
7537 * syntax.h (struct gl_state_s): Declare character position members
7538 EMACS_INT.
7539
7540 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7541
04f2d78b
CB
7542 * textprop.c (verify_interval_modification, interval_of):
7543 Declare arguments EMACS_INT.
d1dfb56c
EZ
7544
7545 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7546 EMACS_INT.
7547
7548 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7549
7550 * indent.c (Fvertical_motion): Local variable it_start is now
7551 EMACS_INT.
7552
7553 * regex.c (re_match, re_match_2, re_match_2_internal)
7554 (bcmp_translate, regcomp, regexec, print_double_string)
7555 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7556 (re_compile_pattern, re_exec): Declare arguments and local
7557 variables `size_t' and `ssize_t' and return values `regoff_t', as
7558 appropriate.
7559 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7560 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7561 <compile_stack_type>: `size' and `avail' are now `size_t'.
7562
7563 * regex.h <regoff_t>: Use ssize_t, not int.
7564 (re_search, re_search_2, re_match, re_match_2): Arguments that
7565 specify buffer/string position and length are now ssize_t and
7566 size_t. Return type is regoff_t.
7567
613052cd
BK
75682011-04-16 Ben Key <bkey76@gmail.com>
7569
7570 * nsfont.m: Fixed bugs in ns_get_family and
7571 ns_descriptor_to_entity that were caused by using free to
7572 deallocate memory blocks that were allocated by xmalloc (via
7573 xstrdup). This caused Emacs to crash when compiled with
7574 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7575 --enable-checking=xmallocoverrun). xfree is now used to
7576 deallocate these memory blocks.
7577
4170f62f 75782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7579
71b41406
PE
7580 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7581
9587a89d
PE
7582 emacs_write: Accept and return EMACS_INT for sizes.
7583 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7584 et seq.
7585 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7586 Accept and return EMACS_INT.
7587 (emacs_gnutls_write): Return the number of bytes written on
7588 partial writes.
7589 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7590 (emacs_read, emacs_write): Remove check for negative size, as the
7591 Emacs source code has been audited now.
9587a89d
PE
7592 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7593 (emacs_read, emacs_write): Use it.
273a5f82
PE
7594 * process.c (send_process): Adjust to the new signatures of
7595 emacs_write and emacs_gnutls_write. Do not attempt to store
7596 a byte offset into an 'int'; it might overflow.
9587a89d 7597 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7598
3e047f51
PE
7599 * sound.c: Don't assume sizes fit in 'int'.
7600 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7601 Return EMACS_INT, not int.
3e047f51 7602 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7603 Accept EMACS_INT, not int.
7604 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7605 record read return values.
7606
cc39a9db
BK
76072011-04-15 Ben Key <bkey76@gmail.com>
7608
c9d0ec6d
JB
7609 * keyboard.c (Qundefined): Don't declare static since it is used
7610 in nsfns.m.
7611 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7612 static since they are used in nsfont.m.
cc39a9db 7613
6c60eb9f
SM
76142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7615
7616 * process.c (Qprocessp): Don't declare static.
7617 * lisp.h (Qprocessp): Declare again.
7618
7990b61a
JB
76192011-04-15 Juanma Barranquero <lekktu@gmail.com>
7620
7621 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7622
5d4cb038
PE
76232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7624
8bd7b830 7625 Improve C-level modularity by making more things 'static'.
cd64ea1d 7626
e3b27b31
PE
7627 Don't publish debugger-only interfaces to other modules.
7628 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7629 (verify_bytepos, count_markers): Move decls to the only modules
7630 that need them.
7631 * region-cache.h (pp_cache): Likewise.
7632 * window.h (check_all_windows): Likewise.
7633 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7634
5d4cb038
PE
7635 * sysdep.c (croak): Now static, if
7636 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7637 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7638
7639 * alloc.c (refill_memory_reserve): Now static if
7640 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7641 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7642
e87b6180
PE
7643 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7644 Define only if USE_LUCID.
7645
ac64929e
PE
7646 * xrdb.c (x_customization_string, x_rm_string): Now static.
7647
6f37259d
PE
7648 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7649 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7650
1683e3ab
PE
7651 * xdisp.c (draw_row_with_mouse_face): Now static.
7652 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7653
de9c2632
PE
7654 * window.h (check_all_windows): Mark externally visible.
7655
2b96acb7
PE
7656 * window.c (window_deletion_count): Now static.
7657
7658 * undo.c: Make symbols static if they're not exported.
7659 (last_undo_buffer, last_boundary_position, pending_boundary):
7660 Now static.
7661
50436f33
PE
7662 * textprop.c (interval_insert_behind_hooks): Now static.
7663 (interval_insert_in_front_hooks): Likewise.
7664
64520e5c
PE
7665 * term.c: Make symbols static if they're not exported.
7666 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7667 (max_frame_lines, tty_set_terminal_modes):
7668 (tty_reset_terminal_modes, tty_turn_off_highlight):
7669 (get_tty_terminal): Now static.
7670 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7671 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7672 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7673 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7674 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7675
1fa53021
PE
7676 * sysdep.c: Make symbols static if they're not exported.
7677 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7678 Now static.
7679 (sigprocmask_set, full_mask): Remove; unused.
7680 (wait_debugging): Mark as visible.
7681 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7682 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7683
d4b43b22
PE
7684 * syntax.c (syntax_temp): Define only if !__GNUC__.
7685
b7c513d0
PE
7686 * sound.c (current_sound_device, current_sound): Now static.
7687
989b29ad
PE
7688 * search.c (searchbufs, searchbuf_head): Now static.
7689
13a55a78
PE
7690 * scroll.c (scroll_cost): Remove; unused.
7691 * dispextern.h (scroll_cost): Remove decl.
7692
de68a1fc
PE
7693 * region-cache.h (pp_cache): Mark as externally visible.
7694
40ccffa6
PE
7695 * process.c: Make symbols static if they're not exported.
7696 (process_tick, update_tick, create_process, chan_process):
7697 (Vprocess_alist, proc_buffered_char, datagram_access):
7698 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7699 (deactivate_process): Mark defn as static, as well as decl.
7700 * lisp.h (create_process): Remove decl.
7701 * process.h (chan_process, Vprocess_alist): Remove decls.
7702
ad64fc97
PE
7703 * print.c: Make symbols static if they're not exported.
7704 (print_depth, new_backquote_output, being_printed, print_buffer):
7705 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7706 (print_interval, print_number_index, initial_stderr_stream):
7707 Now static.
7708 * lisp.h (Fprinc): Remove decl.
7709 (debug_output_compilation_hack): Mark as externally visible.
7710
adddb265
PE
7711 * sysdep.c (croak): Move decl from here to syssignal.h.
7712 * syssignal.h (croak): Put it here, so the API can be checked when
7713 'croak' is called from dissociate_if_controlling_tty.
7714
1717ede2
PE
7715 * minibuf.c: Make symbols static if they're not exported.
7716 (minibuf_save_list, choose_minibuf_frame): Now static.
7717 * lisp.h (choose_minibuf_frame): Remove decl.
7718
fa5fb2bc
PE
7719 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7720
1e3890d1
PE
7721 * lread.c: Make symbols static if they're not exported.
7722 (read_objects, initial_obarray, oblookup_last_bucket_number):
7723 Now static.
7724 (make_symbol): Remove; unused.
7725 * lisp.h (initial_obarray, make_symbol): Remove decls.
7726
8a1414fa
PE
7727 * keyboard.c: Make symbols static if they're not exported.
7728 (single_kboard, recent_keys_index, total_keys, recent_keys):
7729 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7730 (this_single_command_key_start, echoing, last_auto_save):
7731 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7732 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7733 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7734 (Vlispy_mouse_stem, double_click_count):
7735 Now static.
7736 (force_auto_save_soon): Define only if SIGDANGER.
7737 (ignore_mouse_drag_p): Now static if
7738 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7739 (print_help): Remove; unused.
7740 (stop_character, last_timer_event): Mark as externally visible.
7741 * keyboard.h (ignore_mouse_drag_p): Declare only if
7742 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7743 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7744 * lisp.h (echoing): Remove decl.
7745 (force_auto_save_soon): Declare only if SIGDANGER.
7746 * xdisp.c (redisplay_window): Simplify code, to make it more
7747 obvious that ignore_mouse_drag_p is not accessed if !defined
7748 USE_GTK && !defined HAVE_NS.
7749
93ea6e8f
PE
7750 * intervals.c: Make symbols static if they're not exported.
7751 (merge_properties_sticky, merge_interval_right, delete_interval):
7752 Now static.
7753 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7754
77382fcc
PE
7755 * insdel.c: Make symbols static if they're not exported.
7756 However, leave prepare_to_modify_buffer alone. It's never
7757 called from outside this function, but that appears to be a bug.
7758 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7759 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7760 (adjust_after_replace_noundo): Remove; unused.
7761 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7762 (signal_before_change): Remove decls.
77382fcc 7763
9306c32e
PE
7764 * indent.c (val_compute_motion, val_vmotion): Now static.
7765
cd44d2eb
PE
7766 * image.c: Make symbols static if they're not exported.
7767 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7768 if USE_GTK.
7769 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7770 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7771
ad9a7a06
PE
7772 * fringe.c (standard_bitmaps): Now static.
7773 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7774
81626931
PE
7775 * frame.c: Make symbols static if they're not exported.
7776 (x_report_frame_params, make_terminal_frame): Now static.
7777 (get_frame_param): Now static, unless HAVE_NS.
7778 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7779 (x_get_resource_string): Remove; not used.
7780 * frame.h (make_terminal_frame, x_report_frame_params):
7781 (x_get_resource_string); Remove decls.
7782 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7783 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7784
239f9db9
PE
7785 * font.c, fontset.c: Make symbols static if they're not exported.
7786 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7787 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7788 * font.c (font_close_object): Now static.
7789 * font.h (font_close_object): Remove.
7790 * fontset.c (FONTSET_OBJLIST): Remove.
7791 (free_realized_fontset) #if-0 the body, which does nothing.
7792 (face_suitable_for_char_p): #if-0, as it's never called.
7793 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7794 * xfaces.c (face_at_string_position):
7795 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7796 since 0 is always ASCII.
7797
dfcf3579
PE
7798 * fns.c (weak_hash_tables): Now static.
7799
5045092b
PE
7800 * fileio.c: Make symbols static if they're not exported.
7801 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7802 (Vwrite_region_annotation_buffers): Now static.
7803
57a96f5c
PE
7804 * eval.c: Make symbols static if they're not exported.
7805 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7806 * lisp.h (backtrace_list): Remove decl.
7807
35f08c38
PE
7808 * emacs.c: Make symbols static if they're not exported.
7809 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7810 (fatal_error_code, fatal_error_signal_hook, standard_args):
7811 Now static.
7812 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7813 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7814 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7815 * lisp.h (fatal_error_signal_hook): Remove decl.
7816 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7817
f44bd759
PE
7818 * editfns.c: Move a (normally-unused) function to its only use.
7819 * editfns.c, lisp.h (get_operating_system_release): Remove.
7820 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7821 worth the hassle of breaking this out.
7822
b532497d
PE
7823 * xterm.c: Make symbols static if they're not exported.
7824 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7825 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7826 (x_destroy_window, x_delete_display):
7827 Now static.
7828 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7829 (x_mouse_leave): Remove; unused.
7830 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7831 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7832 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7833 Remove decls.
7834 (x_mouse_leave): Declare only if WINDOWSNT.
7835 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7836 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7837 USE_X_TOOLKIT.
7838
1675728f
PE
7839 * ftxfont.c: Make symbols static if they're not exported.
7840 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7841 HAVE_FREETYPE.
7842 * font.h (ftxfont_driver): Likewise.
7843
e4cebfca
PE
7844 * xfns.c: Make symbols static if they're not exported.
7845 (x_last_font_name, x_display_info_for_name):
7846 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7847 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7848 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7849 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7850 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7851 (last_show_tip_args): Now static.
7852 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7853 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7854 (x_screen_planes): Remove; unused.
7855 * dispextern.h (x_screen_planes): Remove decl.
7856
5bf46f05
PE
7857 * dispnew.c: Make symbols static if they're not exported.
7858 * dispextern.h (redraw_garbaged_frames, scrolling):
7859 (increment_row_positions): Remove.
7860 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7861 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7862 Now static.
7863 (redraw_garbaged_frames): Remove; unused.
7864
435f4c28
PE
7865 * xfaces.c: Make symbols static if they're not exported.
7866 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7867 Remove decls.
7868 * xterm.h (defined_color): Remove decls.
7869 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7870 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7871 (menu_face_changed_default, defined_color, free_realized_face):
7872 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7873 (ascii_face_of_lisp_face): Remove; unused.
7874
8524aef3
PE
7875 * xdisp.c: Make symbols static if they're not exported.
7876 * dispextern.h (scratch_glyph_row, window_box_edges):
7877 (glyph_to_pixel_coords, set_cursor_from_row):
7878 (get_next_display_element, set_iterator_to_next):
7879 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7880 (show_mouse_face): Remove decls
7881 * frame.h (message_buf_print): Likewise.
7882 * lisp.h (pop_message, set_message, check_point_in_composition):
7883 Likewise.
7884 * xterm.h (set_vertical_scroll_bar): Likewise.
7885 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7886 (message_buf_print, scratch_glyph_row, displayed_buffer):
7887 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7888 (get_next_display_element, show_mouse_face, window_box_edges):
7889 (frame_to_window_pixel_xy, check_point_in_composition):
7890 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7891 (glyph_to_pixel_coords): Remove; unused.
7892
16390cd2
PE
7893 * dired.c (file_name_completion): Now static.
7894
7895 * dbusbind.c (xd_in_read_queued_messages): Now static.
7896
a25f4dfa
PE
7897 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7898 * data.c (circular_list_error): Remove.
7899
14a9c8df
PE
7900 * commands.h (last_point_position, last_point_position_buffer):
7901 (last_point_position_window): Remove decls.
7902 * keyboard.c: Make these variables static.
7903
04f2d78b
CB
7904 * coding.h (coding, code_convert_region, encode_coding_gap):
7905 Remove decls.
74ab6df5
PE
7906 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7907 (iso_code_class, detect_coding, code_convert_region): Now static.
7908 (encode_coding_gap): Remove; unused.
7909
38dfbee1
PE
7910 * chartab.c (chartab_chars, chartab_bits): Now static.
7911
a2cb4e63
PE
7912 * charset.h (charset_iso_8859_1): Remove decl.
7913 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7914 Now static.
7915
127198fd
PE
7916 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7917 * ccl.c (Vccl_program_table): Now static.
7918 (check_ccl_update): Remove; unused.
7919
d85b608f
PE
7920 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7921 * category.h: ... from here.
7922 * category.c (check_category_table, set_category_set): Now static.
7923
31cd66f3
PE
7924 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7925 * lisp.h: Remove these decls.
7926
c358e587
PE
7927 * buffer.c (buffer_count): Remove unused var.
7928
e78aecca
PE
7929 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7930 so that it's not optimized away.
7931 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7932 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7933 exported only to the debugger.
7934
e192d7d3 7935 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7936 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7937
92470028
PE
7938 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7939 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7940 was inaccessible from Lisp.
7941 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7942 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7943
244ed907
PE
7944 alloc.c: Import and export fewer symbols, and remove unused items.
7945 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7946 is defined.
7947 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7948 it's not optimized away by whole-program optimization.
7949 (message_enable_multibyte, free_misc): Remove.
7950 (catchlist, handlerlist, mark_backtrace):
7951 Declare only if BYTE_MARK_STACK.
7952 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7953 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7954 (message_enable_multibyte): Remove decl.
7955 (free_misc, interval_free_list, float_block, float_block_index):
7956 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7957 (cons_free_list, last_marked_index):
7958 Now static.
7959 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7960 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7961 (mark_backtrace): Define only if BYTE_MARK_STACK.
7962 * xdisp.c (message_enable_multibyte): Now static.
7963
61c2b50e 7964 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7965 This makes it easier for human readers (and static analyzers)
7966 to see whether these variables are used from other modules.
7967 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7968 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7969 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7970 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7971 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7972 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7973 * xmenu.c, xselect.c:
7974 Declare Q* vars static if they are not used in other modules.
7975 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7976 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7977 Remove decls of unexported vars.
7978 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7979
95c82688
PE
7980 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7981
16a97296
PE
7982 Make Emacs functions such as Fatom 'static' by default.
7983 This makes it easier for human readers (and static analyzers)
7984 to see whether these functions can be called from other modules.
7985 DEFUN now defines a static function. To make the function external
7986 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7987 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7988 (Finit_image_library):
16a97296
PE
7989 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7990 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7991 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7992 Remove decls, since these functions are now static.
7993 (Funintern, Fget_internal_run_time): New decls, since these functions
7994 were already external.
95c82688 7995
16a97296
PE
7996 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7997 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7998 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7999 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8000 * keyboard.c, keymap.c, lread.c:
8001 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8002 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8003 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8004 Mark functions with DEFUE instead of DEFUN,
8005 if they are used in other modules.
8006 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8007 decls for now-static functions.
8008 * buffer.h (Fdelete_overlay): Remove decl.
8009 * callproc.c (Fgetenv_internal): Mark as internal.
8010 * composite.c (Fremove_list_of_text_properties): Remove decl.
8011 (Fcomposition_get_gstring): New forward static decl.
8012 * composite.h (Fcomposite_get_gstring): Remove decl.
8013 * dired.c (Ffile_attributes): New forward static decl.
8014 * doc.c (Fdocumntation_property): New forward static decl.
8015 * eval.c (Ffetch_bytecode): New forward static decl.
8016 (Funintern): Remove extern decl; now in .h file where it belongs.
8017 * fileio.c (Fmake_symbolic_link): New forward static decl.
8018 * image.c (Finit_image_library): New forward static decl.
8019 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8020 * intervals.h (Fprevious_property_change):
8021 (Fremove_list_of_text_properties): Remove decls.
8022 * keyboard.c (Fthis_command_keys): Remove decl.
8023 (Fcommand_execute): New forward static decl.
8024 * keymap.c (Flookup_key): New forward static decl.
8025 (Fcopy_keymap): Now static.
8026 * keymap.h (Flookup_key): Remove decl.
8027 * process.c (Fget_process): New forward static decl.
8028 (Fprocess_datagram_address): Mark as internal.
8029 * syntax.c (Fsyntax_table_p): New forward static decl.
8030 (skip_chars): Remove duplicate decl.
8031 * textprop.c (Fprevious_property_change): New forward static decl.
8032 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8033 Now internal.
8034 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8035 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8036
785bbd42
PE
8037 * editfns.c (Fformat): Remove unreachable code.
8038
8b913b57
AS
80392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8040
8041 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8042 change. (Bug#8496)
8043
a6744a35
EZ
80442011-04-13 Eli Zaretskii <eliz@gnu.org>
8045
8046 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8047 when at ZV. (Bug#8487)
8048
e7974947
AS
80492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8050
baad03f0
AS
8051 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8052 (Bug#8437)
8053 * keyboard.c (parse_tool_bar_item): Likewise.
8054 * sound.c (sound_cleanup, alsa_close): Likewise.
8055 * termcap.c (tgetent): Likewise.
8056 * xfns.c (x_default_font_parameter): Likewise.
8057 * xsettings.c (read_and_apply_settings): Likewise.
8058
e7974947
AS
8059 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8060 (overrun_check_free): Protoize.
8061
28272684
PE
80622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8063
8064 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8065 since callers should never pass a negative size.
8066 Change the signature to match that of plain 'read' and 'write'; see
8067 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8068 * lisp.h: Update prototypes of emacs_write and emacs_read.
8069
11997c76
EZ
80702011-04-11 Eli Zaretskii <eliz@gnu.org>
8071
8072 * xdisp.c (redisplay_window): Don't try to determine the character
8073 position of the scroll margin if the window start point w->startp
e896f03c 8074 is outside the buffer's accessible region. (Bug#8468)
11997c76 8075
8a2cbd72
EZ
80762011-04-10 Eli Zaretskii <eliz@gnu.org>
8077
8078 Fix write-region and its subroutines for buffers > 2GB.
8079 * fileio.c (a_write, e_write): Modify declaration of arguments and
8080 local variables to support buffers larger than 2GB.
8081 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8082
8083 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8084 argument, local variables, and return value.
8085
8086 * lisp.h: Update prototypes of emacs_write and emacs_read.
8087
8088 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8089
4073e537 80902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8091
1ebfdcb6
PE
8092 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8093
b2ded58d
PE
8094 Fix more problems found by GCC 4.6.0's static checks.
8095
7d66342c
PE
8096 * xdisp.c (vmessage): Use a better test for character truncation.
8097
bbf47d44
PE
8098 * charset.c (load_charset_map): <, not <=, for optimization,
8099 and to avoid potential problems with integer overflow.
9248994d 8100 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8101 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8102 * editfns.c (Fformat): Likewise.
1e69125e 8103 * syntax.c (skip_chars): Likewise.
3befa583 8104
e3019616
PE
8105 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8106 This also lets GCC 4.6.0 generate slightly better loop code.
8107
becfa255
PE
8108 * callint.c (Fcall_interactively): <, not <=, for optimization.
8109 (Fcall_interactively): Count the number of arguments produced,
8110 not the number of arguments given. This is simpler and lets GCC
8111 4.6.0 generate slightly better code.
8112
dae0cd48
PE
8113 * ftfont.c: Distingish more carefully between FcChar8 and char.
8114 The previous code passed unsigned char * to a functions like
8115 strlen and xstrcasecmp that expect char *, which does not
8116 conform to the C standard.
8117 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8118 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8119 char * when the C standard requires it.
8120
76032d70
PE
8121 * keyboard.c (read_char): Remove unused var.
8122
eb3f1cc8
PE
8123 * eval.c: Port to Windows vsnprintf (Bug#8435).
8124 Include <limits.h>.
8125 (SIZE_MAX): Define if the headers do not.
8126 (verror): Do not give up if vsnprintf returns a negative count.
8127 Instead, grow the buffer. This ports to Windows vsnprintf, which
8128 does not conform to C99. Problem reported by Eli Zaretskii.
8129 Also, simplify the allocation scheme, by avoiding the need for
8130 calling realloc, and removing the ALLOCATED variable.
8131
70476b54
PE
8132 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8133
12020a9e
PE
8134 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8135 But keep the doprint source code for now, as we might revamp it
8136 and use it again (Bug#8435).
ea6c7ae6
PE
8137 * lisp.h (doprnt): Remove.
8138 * Makefile.in (base_obj): Remove doprnt.o.
8139 * deps.mk (doprnt.o): Remove.
8140
5fdb398c
PE
8141 error: Print 32- and 64-bit integers portably (Bug#8435).
8142 Without this change, on typical 64-bit hosts error ("...%d...", N)
8143 was used to print both 32- and 64-bit integers N, which relied on
8144 undefined behavior.
61bdb816 8145 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8146 * lisp.h (error, verror): Mark as printf-like functions.
8147 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8148 Report overflow in size calculations when allocating printf buffer.
8149 Do not truncate output string at its first null byte.
8150 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8151 Truncate the output at a character boundary, since vsnprintf does not
8152 do that.
8153 * charset.c (check_iso_charset_parameter): Convert internal
8154 character to string before calling 'error', since %c now has the
8155 printf meaning.
8156 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8157 overflow when computing char to be passed to 'error'. Do not
8158 pass Lisp_Object to 'error'; pass the integer instead.
8159 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8160 formatted with plain %d.
8161
b189fa66
PE
8162 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8163
bff87ef0
PE
8164 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8165
7e2cac20
PE
8166 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8167
ce4d90b5
PE
8168 * xterm.c (x_catch_errors): Remove duplicate declaration.
8169
266c9547
PE
8170 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8171
79c49ad2
PE
8172 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8173
368f4090
JM
81742011-04-10 Jim Meyering <meyering@redhat.com>
8175
8176 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8177 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8178 return ssize_t not "int", and use size_t as the buffer length.
8179 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8180 * gnutls.h: Update declarations.
8181 * process.c (read_process_output): Use ssize_t, to match.
8182 (send_process): Likewise.
8183
a32d4040
CY
81842011-04-09 Chong Yidong <cyd@stupidchicken.com>
8185
8186 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8187
8546720e 81882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8189
04f2d78b
CB
8190 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8191 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8192
8546720e
GM
8193 * xterm.c (handle_one_xevent):
8194 * xmenu.c (create_and_show_popup_menu):
8195 * xselect.c (x_decline_selection_request)
8196 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8197
0a2f5c1a 81982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8199
8200 Fix some uses of `int' instead of EMACS_INT.
8201 * search.c (string_match_1, fast_string_match)
8202 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8203 (scan_buffer, find_next_newline_no_quit)
8204 (find_before_next_newline, search_command, Freplace_match)
8205 (Fmatch_data): Make some `int' variables be EMACS_INT.
8206
8207 * xdisp.c (display_count_lines): 3rd argument and return value now
8208 EMACS_INT. All callers changed.
8209 (pint2hrstr): Last argument is now EMACS_INT.
8210
8211 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8212 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8213 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8214 (decode_coding_utf_16, decode_coding_emacs_mule)
8215 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8216 (decode_coding_ccl, decode_coding_charset)
8217 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8218 (decode_coding_iso_2022, decode_coding_emacs_mule)
8219 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8220 <char_offset, last_offset>: Declare EMACS_INT.
8221 (encode_coding_utf_8, encode_coding_utf_16)
8222 (encode_coding_emacs_mule, encode_invocation_designation)
8223 (encode_designation_at_bol, encode_coding_iso_2022)
8224 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8225 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8226 Declare EMACS_INT.
8227 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8228 (encode_invocation_designation): Last argument P_NCHARS is now
8229 EMACS_INT.
8230 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8231 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8232
8233 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8234 All users changed.
8235
8236 * ccl.c (Fccl_execute_on_string): Declare some variables
8237 EMACS_INT.
8238
8546720e 82392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8240
8241 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8242
4e19a977
CS
82432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8244
8245 * process.c (Fformat_network_address): Doc fix.
8246
87302331
R
82472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8248
ee7683eb 8249 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8250
cbb59342
CY
82512011-04-08 Chong Yidong <cyd@stupidchicken.com>
8252
8253 * keyboard.c (read_char): Call Lisp function help-form-show,
8254 instead of using internal_with_output_to_temp_buffer.
8255 (Qhelp_form_show): New var.
e0d38eeb 8256 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8257
8258 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8259
8260 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8261
e67a13ab
CY
82622011-04-06 Chong Yidong <cyd@stupidchicken.com>
8263
04f2d78b
CB
8264 * process.c (Flist_processes): Remove to Lisp.
8265 (list_processes_1): Delete.
e67a13ab 8266
973f782d
EZ
82672011-04-06 Eli Zaretskii <eliz@gnu.org>
8268
7c106b1e
EZ
8269 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8270
973f782d
EZ
8271 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8272
41cf7d1a 82732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8274
ca23cc88
PE
8275 Fix more problems found by GCC 4.6.0's static checks.
8276
f390e2d5
PE
8277 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8278
42eea0d0
PE
8279 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8280
b69769da 8281 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8282
f9541e84
PE
8283 * xdisp.c (vmessage): Mark as a printf-like function.
8284
13841b55
PE
8285 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8286
c136c10f
PE
8287 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8288
5e2d4a30
PE
8289 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8290 printf-like functions.
8291 (tiff_load): Add casts to remove these marks before passing them
8292 to system-supplied API.
8293
583f48b9
PE
8294 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8295
b25d760e
PE
8296 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8297 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8298 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8299 directly, rather than having caller test rule sign. This avoids
8300 some unnecessary tests.
8301 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8302 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8303 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8304
bc7b6697 8305 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8306 (xfont_open): Avoid unnecessary tests.
bc7b6697 8307
27ccc379
PE
8308 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8309
dcd5c89a
PE
8310 * composite.h, composite.c (composition_gstring_put_cache):
8311 Use EMACS_INT, not int, for length.
8312
b13a45c6
PE
8313 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8314 breaking out part of COMPOSITION_DECODE_RULE.
8315 (COMPOSITION_DECODE_RULE): Use it.
8316 * composite.c (get_composition_id): Remove unused local vars,
8317 by using the new macro.
8318
1e792e4d
PE
8319 * textprop.c (set_text_properties_1): Change while to do-while,
8320 since the condition is always true at first.
8321
dc6c6455 8322 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8323 (interval_deletion_adjustment): Return unsigned value.
8324 All uses changed.
dc6c6455 8325
aba7731a
PE
8326 * process.c (list_processes_1, create_pty, read_process_output):
8327 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8328 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8329 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8330 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8331 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8332
fdfc4bf3
PE
8333 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8334
fca8fe46 8335 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8336 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8337
06a0259a 8338 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8339 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8340 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8341
e7b9e80f
PE
8342 * print.c (print_error_message): Avoid int overflow.
8343
56201685
PE
8344 * font.c (font_list_entities): Redo for clarity,
8345 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8346
78834453 8347 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8348 (font_score): Avoid potential overflow in diff calculation.
78834453 8349
0bc0b309 8350 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8351 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8352
e610eaca
PE
8353 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8354
b895abce
PE
8355 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8356 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8357 can always succeed if overflow has undefined behavior.
8358
1f1d9321 8359 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8360 (wordify): Omit three unnecessary tests.
1f1d9321 8361
c59478bc
PE
8362 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8363 All callers changed. This avoids the need for an unused var.
8364
79b73827
PE
8365 * casefiddle.c (casify_region): Remove var that is set but not used.
8366
a4db5dfe
PE
8367 * dired.c (file_name_completion): Remove var that is set but not used.
8368
43aae36e
PE
8369 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8370
2a47c44d 8371 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8372 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8373
a37c69bf
PE
8374 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8375 Check for integer overflow on size calculations.
8376
328ab8e7
PE
8377 * buffer.c (Fprevious_overlay_change): Remove var that is set
8378 but not used.
8379
e5a2a5cb
PE
8380 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8381 Remove vars that are set but not used.
8d84a6eb 8382 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8383 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8384
a60e5f68
PE
8385 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8386
f661cb61 8387 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8388 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8389
f0397f5a
PE
8390 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8391 that are set but not used.
8392
8664db06 8393 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8394 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8395
6abdaa4a
PE
8396 * xselect.c (x_get_local_selection, x_handle_property_notify):
8397 Remove vars that are set but not used.
8398
0ce7538d 8399 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8400 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8401
9ae848fc
PE
8402 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8403 Remove var that is set but not used.
0b918413
PE
8404 (scroll_bar_windows_size): Now size_t, not int.
8405 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8406 Check for overflow.
9ae848fc 8407
a5a62657
PE
8408 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8409 (map_tty_color) [!defined MSDOS]: Likewise.
8410
5c5cdd39
PE
8411 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8412
66ebf983
PE
8413 * coding.c: Remove vars that are set but not used.
8414 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8415 All callers changed.
8416 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8417 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8418 (decode_coding_charset): Remove vars that are set but not used.
8419
1be4d761
PE
8420 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8421 that is set but not used.
8422
47553fa8
PE
8423 * print.c (print_object): Remove var that is set but not used.
8424
1f7196bf 8425 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8426 The gnulib version avoids calling malloc in the usual case,
8427 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8428 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8429 * filelock.c (current_lock_owner): Likewise.
8430 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8431 * sysdep.c: Include allocator.h, careadlinkat.h.
8432 (emacs_no_realloc_allocator): New static constant.
8433 (emacs_readlink): New function.
fdb61804
PE
8434 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8435 ../lib/careadlinkat.h.
d1fdcab7 8436
f84c17c7
SM
84372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8438
8439 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8440 first non-nil return value).
8441
ef3862ad
JD
84422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8443
8444 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8445 if not defined (Bug#8403).
8446
376a7006
JB
84472011-04-02 Juanma Barranquero <lekktu@gmail.com>
8448
8449 * xdisp.c (display_count_lines): Remove parameter `start',
8450 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8451 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8452 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8453 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8454 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8455 and thereabouts. All callers changed.
8456 (get_per_char_metric): Remove parameter `f', unused since
8457 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8458
6ca3801d
JM
84592011-04-02 Jim Meyering <meyering@redhat.com>
8460
8461 do not dereference NULL upon failed strdup
8462 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8463 (ns_get_family): Likewise.
8464
d8e2b5ba
JB
84652011-04-02 Juanma Barranquero <lekktu@gmail.com>
8466
8467 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8468
8c74fcbd
JD
84692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8470
8471 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8472 later (Bug#8403).
8473
7200d79c
SM
84742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8475
03408648 8476 Add lexical binding.
7200d79c 8477
03408648
SM
8478 * window.c (Ftemp_output_buffer_show): New fun.
8479 (Fsave_window_excursion):
8480 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8481
8482 * lread.c (lisp_file_lexically_bound_p): New function.
8483 (Fload): Bind Qlexical_binding.
8484 (readevalloop): Remove `evalfun' arg.
8485 Bind Qinternal_interpreter_environment.
8486 (Feval_buffer): Bind Qlexical_binding.
8487 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8488 Mark as dynamic.
8489 (syms_of_lread): Declare `lexical-binding'.
8490
8491 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8492
8493 * keyboard.c (eval_dyn): New fun.
8494 (menu_item_eval_property): Use it.
ca105506
SM
8495
8496 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8497
03408648
SM
8498 * fns.c (concat, mapcar1): Accept byte-code-functions.
8499
8500 * eval.c (Fsetq): Handle lexical vars.
8501 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8502 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8503 (FletX, Flet): Obey lexical binding.
8504 (Fcommandp): Handle closures.
8505 (Feval): New `lexical' arg.
8506 (eval_sub): New function extracted from Feval. Use it almost
8507 everywhere where Feval was used. Look up vars in lexical env.
8508 Handle closures.
8509 (Ffunctionp): Move from subr.el.
8510 (Ffuncall): Handle closures.
8511 (apply_lambda): Remove `eval_flags'.
8512 (funcall_lambda): Handle closures and new byte-code-functions.
8513 (Fspecial_variable_p): New function.
8514 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8515 but without exporting it to Lisp.
23aba0ea 8516
23aba0ea 8517 * doc.c (Fdocumentation, store_function_docstring):
03408648 8518 * data.c (Finteractive_form): Handle closures.
23aba0ea 8519
03408648
SM
8520 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8521 interactive spec.
ba83908c 8522
04f2d78b
CB
8523 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8524 New byte-codes.
03408648
SM
8525 (exec_byte_code): New function extracted from Fbyte_code to handle new
8526 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8527
03408648 8528 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8529
03408648 8530 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8531
e2abce01
JB
85322011-03-31 Juanma Barranquero <lekktu@gmail.com>
8533
8534 * xdisp.c (redisplay_internal): Fix prototype.
8535
63696a73 85362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8537
63696a73 8538 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8539 (try_scrolling): Use it when setting scroll_limit.
8540 Limit scrolling to 100 screen lines.
63696a73
EZ
8541 (redisplay_window): Even when falling back on "recentering",
8542 position point in the window according to scroll-conservatively,
8543 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8544
8545 (try_scrolling): When point is above the window, allow searching
8546 as far as scroll_max, or one screenful, to compute vertical
8547 distance from PT to the scroll margin position. This prevents
8548 try_scrolling from unnecessarily failing when
8549 scroll-conservatively is set to a value slightly larger than the
8550 window height. Clean up the case of PT below the margin at bottom
8551 of window: scroll_max can no longer be INT_MAX. When aggressive
8552 scrolling is in use, don't let point enter the opposite scroll
8553 margin as result of the scroll.
8554 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8555 threshold of 100 lines for never-recentering scrolling.
8556
e4cc2dfc
JB
85572011-03-31 Juanma Barranquero <lekktu@gmail.com>
8558
8559 * dispextern.h (move_it_by_lines):
8560 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8561 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8562 (message_log_check_duplicate): Remove parameters `prev_bol' and
8563 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8564 (redisplay_internal): Remove parameter `preserve_echo_area',
8565 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8566
8567 * indent.c (Fvertical_motion):
8568 * window.c (window_scroll_pixel_based, Frecenter):
8569 Don't pass `need_y_p' to `move_it_by_lines'.
8570
1c470562
SM
85712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8572
44f230aa
SM
8573 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8574 steal a few bits to be more compact.
8575 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8576 Remove unneeded casts.
8577
1c470562
SM
8578 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8579
888adce9
ZK
85802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8581
8582 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8583 binding" message (bug#7967).
8584
f838ed7b
PE
85852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8586
77861b95
PE
8587 Fix more problems found by GCC 4.6.0's static checks.
8588
de6dbc14
PE
8589 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8590 Remove unused local var.
8591
f838ed7b
PE
8592 * editfns.c (Fmessage_box): Remove unused local var.
8593
792c7b2b
PE
8594 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8595 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8596 Omit unused local vars.
c499e557 8597 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8598 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8599 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8600 Omit unused local var.
8601
ba0165e1
PE
8602 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8603 Don't assume string length fits in int.
32ad8845 8604 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8605 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8606
3c59b4c9
PE
8607 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8608 instead of alloca (Bug#8344).
8609
a3eed478 8610 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8611 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8612
eb4d412d
PE
8613 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8614
1658b401
PE
8615 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8616 concerns.
8617
8618 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8619
8620 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8621
9a2c6e05
PE
8622 * keyboard.c (syms_of_keyboard): Use the same style as later
8623 in this function when indexing through an array. This also
8624 works around GCC bug 48267.
8625
03d0a109
PE
8626 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8627
44f730c8
PE
8628 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8629
fe75f926
PE
8630 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8631 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8632
ffa8c828
PE
8633 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8634 This avoids undefined behavior on integer overflow, and is a bit
8635 more convenient anyway since it is compared to a size_t variable.
8636
c5101a77
PE
8637 Variadic C functions now count arguments with size_t, not int.
8638 This avoids an unnecessary limitation on 64-bit machines, which
8639 caused (substring ...) to crash on large vectors (Bug#8344).
8640 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8641 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8642 All variadic functions and their callers changed accordingly.
c5101a77
PE
8643 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8644 * data.c (arith_driver, float_arith_driver): Likewise.
8645 * editfns.c (general_insert_function): Likewise.
8646 * eval.c (struct backtrace.nargs, interactive_p)
8647 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8648 (funcall_lambda, mark_backtrace): Likewise.
8649 * fns.c (concat): Likewise.
8650 * frame.c (x_set_frame_parameters): Likewise.
8651 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8652 0 if not found, not -1. All callers changed.
8653
dd3f25f7
PE
8654 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8655 (stack_copy_size): Now size_t, not int.
8656 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8657
461c2ab9
JB
86582011-03-28 Juanma Barranquero <lekktu@gmail.com>
8659
8660 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8661 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8662 All callers changed.
8663
8664 * lisp.h (multibyte_char_to_unibyte):
8665 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8666 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8667 * character.h (CHAR_TO_BYTE8):
8668 * cmds.c (internal_self_insert):
8669 * editfns.c (general_insert_function):
8670 * keymap.c (push_key_description):
8671 * search.c (Freplace_match):
8672 * xdisp.c (message_dolog, set_message_1): All callers changed.
8673
f6d62986
SM
86742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8675
8676 * keyboard.c (safe_run_hook_funcall): New function.
8677 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8678 don't set the hook to nil, but remove the offending function instead.
8679 (Qcommand_hook_internal): Remove, unused.
8680 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8681 Vcommand_hook_internal.
8682
8683 * eval.c (enum run_hooks_condition): Remove.
8684 (funcall_nil, funcall_not): New functions.
8685 (run_hook_with_args): Call each function through a `funcall' argument.
8686 Remove `cond' argument, now redundant.
8687 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8688 (Frun_hook_with_args_until_failure): Adjust accordingly.
8689 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8690
1db5b1ad
JB
86912011-03-28 Juanma Barranquero <lekktu@gmail.com>
8692
8693 * dispextern.h (string_buffer_position): Remove declaration.
8694
8695 * print.c (strout): Remove parameter `multibyte', unused since
8696 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8697
8698 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8699 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8700 All callers changed.
8701
8702 * w32.c (_wsa_errlist): Use braces for struct initializers.
8703
8704 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8705 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8706 All callers changed.
8707 (string_buffer_position): Likewise. Also, make static (it's never
8708 used outside xdisp.c).
8709 (cursor_row_p): Remove parameter `w', unused since
8710 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8711 (decode_mode_spec): Remove parameter `precision', introduced during
8712 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8713 All callers changed.
8714
5ffb62aa
JD
87152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8716
8717 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8718
461c2ab9 87192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8720
8721 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8722 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8723 (ns_update_auto_hide_menu_bar): New functions.
8724 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8725 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8726 ns_constrain_all_frames.
8727 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8728 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8729
5c380ffb
JD
87302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8731
8732 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8733
9af30bdf
GM
87342011-03-27 Glenn Morris <rgm@gnu.org>
8735
8736 * syssignal.h: Replace RETSIGTYPE with void.
8737 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8738 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8739 Replace SIGTYPE with void everywhere.
8740 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8741 * s/template.h (SIGTYPE): Remove commented out definition.
8742
e2abce01
JB
87432011-03-26 Eli Zaretskii <eliz@gnu.org>
8744
8745 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8746 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8747
f868cd8a
JB
87482011-03-26 Juanma Barranquero <lekktu@gmail.com>
8749
59eb0929
JB
8750 * w32.c (read_unc_volume): Use parameter `henum', instead of
8751 global variable `wget_enum_handle'.
8752
8753 * keymap.c (describe_vector): Remove parameters `indices' and
8754 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8755 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8756
f868cd8a
JB
8757 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8758
8759 * keyboard.c (timer_check): Remove parameter `do_it_now',
8760 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8761 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8762 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8763
8764 * keyboard.c (read_char):
8765 * w32menu.c (w32_menu_display_help):
8766 * xmenu.c (show_help_event, menu_help_callback):
8767 Adjust calls to `show_help_echo'.
8768
8769 * gtkutil.c (xg_maybe_add_timer):
8770 * keyboard.c (readable_events):
8771 * process.c (wait_reading_process_output):
8772 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8773
8774 * insdel.c (adjust_markers_gap_motion):
8775 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8776 (gap_left, gap_right): Don't call it.
8777
2ecf6fdb
CY
87782011-03-25 Chong Yidong <cyd@stupidchicken.com>
8779
8780 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8781 incurred during fontification.
8782
6b1f9ba4
JB
87832011-03-25 Juanma Barranquero <lekktu@gmail.com>
8784
8785 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8786 (DEFVAR_PER_BUFFER): Don't pass it.
8787
8788 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8789 (scrolling_window): Don't pass it.
8790
0f4a96b5
JB
87912011-03-25 Juanma Barranquero <lekktu@gmail.com>
8792
8793 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8794
8795 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8796 and `suffix'.
8797 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8798 of variables specific to SELinux and computation of `encoded_absname'.
8799
8800 * image.c (XPutPixel): Remove unused variable `height'.
8801
8802 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8803
8804 * unexw32.c (get_section_info): Remove unused variable `section'.
8805
8806 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8807 (system_process_attributes): Remove unused variable `sess'.
8808 (sys_read): Remove unused variable `err'.
8809
8810 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8811 (w32_wnd_proc): Remove unused variable `isdead'.
8812 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8813 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8814 (x_create_tip_frame): Remove unused variable `tem'.
8815
8816 * w32inevt.c (w32_console_read_socket):
8817 Remove unused variable `no_events'.
8818
8819 * w32term.c (x_draw_composite_glyph_string_foreground):
8820 Remove unused variable `width'.
8821
1149507c
JB
88222011-03-24 Juanma Barranquero <lekktu@gmail.com>
8823
8824 * w32term.c (x_set_glyph_string_clipping):
8825 Don't pass uninitialized region to CombineRgn.
8826
9c88f339
JB
88272011-03-23 Juanma Barranquero <lekktu@gmail.com>
8828
8829 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8830 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8831 (Fx_close_connection): Remove unused variable `i'.
8832
8833 * w32font.c (w32font_draw): Return number of glyphs.
8834 (w32font_open_internal): Remove unused variable `i'.
8835 (w32font_driver): Add missing initializer.
8836
8837 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8838 (fill_in_menu): Remove unused variable `items_added'.
8839
8840 * w32term.c (last_mouse_press_frame): Remove static global variable.
8841 (w32_clip_to_row): Remove unused variable `f'.
8842 (x_delete_terminal): Remove unused variable `i'.
8843
8844 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8845 (NOTHING): Remove unused static global variable.
8846 (uniscribe_check_otf): Remove unused variable `table'.
8847 (uniscribe_font_driver): Add missing initializers.
8848
dee091a3
JD
88492011-03-23 Julien Danjou <julien@danjou.info>
8850
8851 * term.c (Fsuspend_tty, Fresume_tty):
8852 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8853 * window.c (temp_output_buffer_show):
8854 * insdel.c (signal_before_change):
8855 * frame.c (Fhandle_switch_frame):
8856 * fileio.c (Fdo_auto_save):
8857 * emacs.c (Fkill_emacs):
8858 * editfns.c (save_excursion_restore):
8859 * cmds.c (internal_self_insert):
8860 * callint.c (Fcall_interactively):
8861 * buffer.c (Fkill_all_local_variables):
8862 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8863 Use Frun_hooks.
0f4a96b5 8864 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8865 unconditionally since it does the check itself.
dee091a3 8866
2c520ab5 88672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8868
c9c49752
PE
8869 Fix more problems found by GCC 4.5.2's static checks.
8870
8abc3f12
PE
8871 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8872 the first time through the loop, since we know p0 < p1 then.
8873 This also avoids a gcc -Wstrict-overflow warning.
8874
a2d26660
PE
8875 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8876 leading to a memory leak, possible in functions like
8877 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8878 of objects (Bug#8318).
a2d26660 8879
916c72e9
PE
8880 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8881 that could (at least in theory) be that large.
8882
19ab8a18
PE
8883 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8884 This is less likely to overflow, and avoids undefined behavior if
8885 overflow does occur. All callers changed. Use strtoul to scan
8886 for the unsigned long integer.
b7cbbd6f
PE
8887 (pint2hrstr): Simplify and tune code slightly.
8888 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8889
f0641eff
PE
8890 * scroll.c (do_scrolling): Work around GCC bug 48228.
8891 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8892
7f650bb9
PE
8893 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8894 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8895 (validate_x_resource_name): Simplify count usage.
8896 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8897
37dd57d1
PE
8898 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8899 fail (Bug#8306).
81e56e61 8900
699979fc 8901 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8902
401bf9b4
PE
8903 * process.c (Fmake_network_process): Use socklen_t, not int,
8904 where POSIX says socklen_t is required in portable programs.
8905 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8906 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8907 (Fmake_network_process, server_accept_connection):
8908 (wait_reading_process_output, read_process_output):
8909 Likewise.
8910
b93aacde
PE
8911 * process.c: Rename or move locals to avoid shadowing.
8912 (list_processes_1, Fmake_network_process):
8913 (read_process_output_error_handler, exec_sentinel_error_handler):
8914 Rename or move locals.
4dc343ee 8915 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8916 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8917 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8918 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8919 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8920
af8a867c 8921 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8922 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8923 Include tparam.h instead, since it declares them.
af8a867c
PE
8924 * cm.h (PC): Remove extern decl; tparam.h now does this.
8925 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8926 * terminfo.c: Include tparam.h, to check interfaces.
8927 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8928 (tparam): Adjust signature to match interface in tparam.h;
8929 this removes some undefined behavior. Check that outstring and len
8930 are zero, which they always are with Emacs.
8931 * tparam.h (PC, BC, UP): New extern decls.
8932
0248044d 8933 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8934 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8935
8ff096c1 8936 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8937 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8938 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8939 (ftfont_list): Remove unused local.
49eaafba
PE
8940 (get_adstyle_property, ftfont_pattern_entity):
8941 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8942 Rename locals to avoid shadowing.
8ff096c1 8943
e2be39f6
PE
8944 * xfont.c (xfont_list_family): Mark var as initialized.
8945
c9735e30
PE
8946 * xml.c (make_dom): Now static.
8947
8f5201ae
PE
8948 * composite.c (composition_compute_stop_pos): Rename local to
8949 avoid shadowing.
b246f932
PE
8950 (composition_reseat_it): Remove unused locals.
8951 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8952 (composition_update_it): Mark var as initialized.
11b61122
PE
8953 (find_automatic_composition): Mark vars as initialized,
8954 with a FIXME (Bug#8290).
8f5201ae 8955
760fbc2c
PE
8956 character.h: Rename locals to avoid shadowing.
8957 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8958 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8959 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8960 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8961 to avoid shadowing.
8962
ff08eb85
PE
8963 * textprop.c (property_change_between_p): Remove; unused.
8964
fc7bf025
PE
8965 * intervals.c (interval_start_pos): Now static.
8966
235d7abc
PE
8967 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8968
44f230aa
SM
8969 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8970 Rename locals to avoid shadowing.
3e7d6594 8971
50060332
PE
8972 * sound.c (wav_play, au_play, Fplay_sound_internal):
8973 Fix pointer signedness.
d01f234b 8974 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8975 (wav_play): Initialize a variable to 0, to prevent undefined
8976 behavior (Bug#8278).
50060332 8977
c4fc4e30
PE
8978 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8979
918436ed
PE
8980 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8981
c939f91b
PE
8982 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8983 clobbering (Bug#8298).
b9c7f648
PE
8984 * sysdep.c (sys_subshell): Likewise.
8985 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8986
6bd8c144
PE
8987 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8988 This should get cleaned up, so that child_setup has the
8989 same signature on all platforms.
8990
7710357c 8991 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8992 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8993
c59da222
CY
89942011-03-22 Chong Yidong <cyd@stupidchicken.com>
8995
8996 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8997 not to be necessary, and produces flickering.
8998
66b87493
GM
89992011-03-20 Glenn Morris <rgm@gnu.org>
9000
9001 * config.in: Remove file.
9002
45b6f6d5
JB
90032011-03-20 Juanma Barranquero <lekktu@gmail.com>
9004
9005 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9006 are now in src/globals.h.
9007 (syms_of_minibuf): Remove spurious & from previous change.
9008
cd394be1 90092011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9010
9011 * minibuf.c (completing-read-function): New variable.
9012 (completing-read-default): Rename from completing-read.
9013 (completing-read): Call completing-read-function.
9014
b14e3e21
CY
90152011-03-19 Juanma Barranquero <lekktu@gmail.com>
9016
9017 * xfaces.c (Fx_load_color_file):
9018 Read color file from absolute filename (bug#8250).
9019
f2b726e6
JB
90202011-03-19 Juanma Barranquero <lekktu@gmail.com>
9021
9022 * makefile.w32-in: Update dependencies.
9023
09f6ff02
EZ
90242011-03-17 Eli Zaretskii <eliz@gnu.org>
9025
9026 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9027
29a6015a
PE
90282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9029
a3a6c54e
PE
9030 Fix more problems found by GCC 4.5.2's static checks.
9031
b766f867
PE
9032 * process.c (make_serial_process_unwind, send_process_trap):
9033 (sigchld_handler): Now static.
9034
be02381c
PE
9035 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9036 That way, the code declares only the vars that it needs.
9037 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9038 * s/cygwin.h (PTY_ITERATION): Likewise.
9039 * s/darwin.h (PTY_ITERATION): Likewise.
9040 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9041
57048744
PE
9042 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9043 * process.c (allocate_pty): Don't declare stb unless it's needed.
9044
7914961c 9045 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9046 (CONSTANTLIM): Remove; unused.
9047 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9048 Define only if needed.
7914961c 9049
b3967b18
PE
9050 * unexelf.c (unexec): Name an expression,
9051 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9052 Use a different way to cause a compilation error if anyone uses
9053 n rather than nn, a way that does not involve shadowing.
73366a00 9054 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9055
29a6015a
PE
9056 * deps.mk (unexalpha.o): Remove; unused.
9057
43cfc33e 9058 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9059 * unexec.h: New file.
ce701a33
PE
9060 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9061 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9062 Depend on unexec.h.
9063 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9064 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9065 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9066 Change as necessary to match prototype in unexec.h.
ce701a33 9067
01f44d5a
PE
9068 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9069 shadowing.
4f63c6bb 9070 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9071
a6670b0b
PE
9072 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9073 Rename locals to avoid shadowing.
9074
cef2010d 9075 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9076 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9077
d4d7173a
PE
9078 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9079
f08b802a
PE
9080 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9081 warning when compiling print.c.
9082
3ddb0639
PE
9083 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9084 instead of using an uninitialized var.
5ad03b97 9085 (font_sort_entities): Mark var as initialized.
3ddb0639 9086
170a2692
PE
9087 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9088
e663c700
PE
9089 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9090 pointers to constants.
89bc529a 9091 (font_parse_fcname): Remove unused vars.
7b81e2d0 9092 (font_delete_unmatched): Now static.
ea838e10 9093 (font_get_spec): Remove; unused.
13a547c6
PE
9094 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9095 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9096 Rename or move locals to avoid shadowing.
e663c700 9097
2a80c887 9098 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9099 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9100
1384fa33 9101 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9102 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9103
8b2c52e9
PE
9104 * alloc.c (mark_backtrace): Move decl from here ...
9105 * lisp.h: ... to here, so that it can be checked.
9106
475545b5 9107 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9108 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9109 (lisp_indirect_variable): Name an expression,
9110 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9111 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9112
b1349114 9113 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9114 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9115 Use const pointer when appropriate.
b1349114 9116
a2928364
PE
9117 * lisp.h (get_system_name, get_operating_system_release):
9118 Move decls here, to check interfaces.
9119 * process.c (get_operating_system_release): Move decl to lisp.h.
9120 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9121 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9122 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9123 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9124 (Fformat_time_string, Fencode_time, Finsert_char):
9125 (Ftranslate_region_internal, Fformat):
9126 Rename or remove local vars to avoid shadowing.
9710023e 9127 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9128
a415e694
PE
9129 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9130 avoid shadowing.
9131
8ef4622d
PE
9132 * lisp.h (eassert): Check that the argument compiles, even if
9133 ENABLE_CHECKING is not defined.
9134
946f9a5b
PE
9135 * data.c (Findirect_variable): Name an expression, to avoid
9136 gcc -Wbad-function-cast warning.
112396d6 9137 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9138 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9139 (Fmake_variable_buffer_local, Fmake_local_variable):
9140 Mark variables as initialized.
52746918 9141 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9142
e5aab7e7 9143 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9144 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9145 Rename locals to avoid shadowing.
dff45157
PE
9146 (mark_stack): Move local variables into the #ifdef region where
9147 they're used.
7bc26fdb
PE
9148 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9149 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9150 needed otherwise.
9151 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9152 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9153 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9154
e5aab7e7
PE
9155 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9156 avoids undefined behavior in theory.
9157
4da60324
PE
9158 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9159
88043301
PE
9160 Use functions, not macros, for up- and down-casing (Bug#8254).
9161 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9162 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9163 to use the following functions instead of these macros.
9164 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9165 EMACS_INT, since callers assume the returned value fits in int.
9166 (upcase1): Likewise, for UPCASE_TABLE.
9167 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9168 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9169 the race-condition problem in the old DOWNCASE.
88043301 9170
19ed5445
PE
9171 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9172 Rename locals to avoid shadowing.
9173 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9174 (regex_compile, re_search_2, re_match_2_internal):
9175 Remove unused local vars.
952db0d7
PE
9176 (FREE_VAR): Rewrite so as not to use empty "else",
9177 which gcc can warn about.
da053e48 9178 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9179 (RETALLOC_IF): Define only if needed.
9180 (WORDCHAR_P): Likewise. This one is never needed, but is used
9181 only in a comment talking about a compiler bug, so put inside
9182 the #if 0 of that comment.
9183 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9184 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9185 Remove; unused.
19ed5445 9186
1f3561e4 9187 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9188 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9189 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9190
ded6f8f7
PE
9191 * search.c (simple_search): Remove unused var.
9192
dbd37a95
PE
9193 * dired.c (compile_pattern): Move decl from here ...
9194 * lisp.h: ... to here, so that it can be checked.
9195 (struct re_registers): New forward decl.
9196
7e47afad
PE
9197 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9198
85f24f61
PE
9199 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9200 All uses changed.
9201 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9202 Rename locals to avoid shadowing.
5671df8f 9203 (Fvertical_motion): Mark locals as initialized.
85f24f61 9204
181aa2be 9205 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9206 (casify_region): Mark local as initialized.
181aa2be 9207
930d429c
PE
9208 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9209
7082eac6
PE
9210 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9211 New macros, so that the caller can use some names other than
9212 gcpro1, gcpro2, etc.
9213 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9214 of the new macros.
9215 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9216 argument, for consistency with GCPRO2_VAR, etc: it is now the
9217 prefix of the variable, not the variable itself. All uses
9218 changed.
38b2c076
PE
9219 * dired.c (directory_files_internal, file_name_completion):
9220 Rename locals to avoid shadowing.
9221
15206ed9
PE
9222 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9223 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9224 dired.c's scmp function, had undefined behavior.
9225 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9226 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9227 * buffer.h: ... to here, because these macros use current_buffer,
9228 and the new implementation with inline functions needs to have
9229 current_buffer in scope now, rather than later when the macros
9230 are used.
9231 (downcase, upcase1): New static inline functions.
9232 (DOWNCASE, UPCASE1): Reimplement using these functions.
9233 This avoids undefined behavior in expressions like
9234 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9235 from race conditions in accessing the global variables
9236 case_temp1 and case_temp2.
9237 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9238 * lisp.h (case_temp1, case_temp2): Remove their decls.
9239 * character.h (ASCII_CHAR_P): Move from here ...
9240 * lisp.h: ... to here, so that the inline functions mentioned
9241 above can use them.
9242
4a6bea26
PE
9243 * dired.c (directory_files_internal_unwind): Now static.
9244
f14b7e14
PE
9245 * fileio.c (file_name_as_directory, directory_file_name):
9246 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9247 Now static.
2893f146
PE
9248 (file_name_as_directory): Use const pointers when appropriate.
9249 (Fexpand_file_name): Likewise. In particular, newdir might
9250 point at constant storage, so make it a const pointer.
fd4ead52 9251 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9252 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9253 signedness issues.
f839df0c
PE
9254 (Fset_file_times, Finsert_file_contents, auto_save_error):
9255 Rename locals to avoid shadowing.
f14b7e14 9256
5716756e 9257 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9258 (Ftry_completion, Fall_completions): Rename or remove locals
9259 to avoid shadowing.
5716756e 9260
b4c3046a
PE
9261 * marker.c (bytepos_to_charpos): Remove; unused.
9262
b45db522
PE
9263 * lisp.h (verify_bytepos, count_markers): New decls,
9264 so that gcc does not warn that these functions aren't declared.
9265
85876d07
PE
9266 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9267 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9268 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9269 (copy_text): Remove unused local var.
85876d07 9270
03d78a21 9271 * filelock.c (within_one_second): Now static.
b3dd38ab 9272 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9273
5df8f01b
PE
9274 * buffer.c (fix_overlays_before): Mark locals as initialized.
9275 (fix_start_end_in_overlays): Likewise. This function should be
9276 simplified by using pointers-to-pointers, but that's a different
9277 matter.
b1d876f1 9278 (switch_to_buffer_1): Now static.
8f54f30a
PE
9279 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9280 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9281
a70072c9 9282 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9283 Fix pointer signedness issue.
edced198
PE
9284 (sys_subshell): Mark local as volatile if checking for lint,
9285 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9286 (MAXPATHLEN): Define only if needed.
a70072c9 9287
a0977c44
PE
9288 * process.c (serial_open, serial_configure): Move decls from here ...
9289 * systty.h: ... to here, so that they can be checked.
9290
a884fdcc
PE
9291 * fns.c (get_random, seed_random): Move extern decls from here ...
9292 * lisp.h: ... to here, so that they can be checked.
9293
604efe86 9294 * sysdep.c (reset_io): Now static.
b8950c94 9295 (wait_for_termination_signal): Remove; unused.
604efe86 9296
38fc62d9
PE
9297 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9298 (copy_keymap_item, append_key, push_text_char_description):
9299 Now static.
1004a21a 9300 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9301 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9302 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9303 (describe_map_tree):
9304 Rename locals to avoid shadowing.
38fc62d9 9305
2f2650da
PE
9306 * keyboard.c: Declare functions static if they are not used elsewhere.
9307 (echo_char, echo_dash, cmd_error, top_level_2):
9308 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9309 (read_char, kbd_buffer_get_event, make_lispy_position):
9310 (make_lispy_event, make_lispy_movement, apply_modifiers):
9311 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9312 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9313 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9314 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9315 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9316
a053e86c 9317 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9318 (mark_kboards): Move decl here ...
9319 * alloc.c (mark_kboards): ... from here.
a053e86c 9320
4752793e
PE
9321 * lisp.h (force_auto_save_soon): New decl.
9322
74f10ca7 9323 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9324 (DEFINE_DUMMY_FUNCTION): New macro.
9325 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9326 Use it.
c03cd23f
PE
9327 (main): Add casts to avoid warnings
9328 if GCC considers string literals to be constants.
74f10ca7 9329
022e70d4
PE
9330 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9331
59d6fe83
PE
9332 * dbusbind.c: Pointer signedness fixes.
9333 (xd_signature, xd_append_arg, xd_initialize):
9334 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9335 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9336 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9337 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9338
78320123
PE
9339 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9340 if GCC considers string literals to be constants.
49cebcca 9341 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9342
35ac2a97
SM
93432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9344
fb103ca9
SM
9345 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9346 (print_preprocess, print_object): New macro to fix last change.
9347
35ac2a97
SM
9348 * print.c (print_preprocess): Don't forget font objects.
9349
62973b41
JB
93502011-03-16 Juanma Barranquero <lekktu@gmail.com>
9351
9352 * emacs.c (USAGE3): Doc fixes.
9353
0e48bb22
AS
93542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9355
9356 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9357 structure.
9358
7684e57b
JB
93592011-03-14 Juanma Barranquero <lekktu@gmail.com>
9360
9361 * lisp.h (VWindow_system, Qfile_name_history):
9362 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9363 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9364 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9365
9366 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9367 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9368
9369 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9370 * w32console.c (detect_input_pending, read_input_pending)
9371 (encode_terminal_code):
9372 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9373 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9374 (w32_system_caret_y, Qfile_name_history):
9375 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9376 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9377 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9378 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9379 * w32proc.c (Qlocal, report_file_error):
9380 * w32term.c (Vwindow_system, updating_frame):
9381 * w32uniscribe.c (initialized, uniscribe_font_driver):
9382 Remove unneeded extern declarations.
9383
2aa46d6c
CY
93842011-03-14 Chong Yidong <cyd@stupidchicken.com>
9385
c96bbc66 9386 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9387
cffc6f3b
CY
93882011-03-13 Chong Yidong <cyd@stupidchicken.com>
9389
9390 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9391 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9392 These macros can no longer be used for assignment.
9393
44f230aa
SM
9394 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9395 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9396 (record_buffer_markers, fetch_buffer_markers): New functions for
9397 recording and fetching special buffer markers.
9398 (set_buffer_internal_1, set_buffer_temp): Use them.
9399
9400 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9401
9402 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9403
9404 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9405 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9406
9407 * xdisp.c (hscroll_window_tree):
9408 (reconsider_clip_changes): Use PT instead of BUF_PT.
9409
d251f04b
EZ
94102011-03-13 Eli Zaretskii <eliz@gnu.org>
9411
9412 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9413 $(EMACS_ROOT)/lib/intprops.h.
9414
f0c77cd1
PE
94152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9416
3eca4629
PE
9417 Fix more problems found by GCC 4.5.2's static checks.
9418
7c86ee98
PE
9419 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9420 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9421 (xg_free_frame_widgets): Make it clear that a local variable is
9422 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9423 (gdk_window_get_screen): Make it clear that this macro is needed
9424 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9425 (int_gtk_range_get_value): New function, which avoids a diagnostic
9426 from gcc -Wbad-function-cast.
9427 (xg_set_toolkit_scroll_bar_thumb): Use it.
9428 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9429 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9430 (get_utf8_string, xg_get_file_with_chooser):
9431 Rename locals to avoid shadowing.
9432 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9433
41729b81
PE
9434 * xgselect.c (xg_select): Remove unused var.
9435
f0c77cd1
PE
9436 * image.c (four_corners_best): Mark locals as initialized.
9437 (gif_load): Initialize transparent_p to zero (Bug#8238).
9438 Mark another local as initialized.
ec6cf4c6 9439 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9440
ce0ad53d 9441 * image.c (clear_image_cache): Now static.
d5d5a617 9442 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9443 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9444 (x_edge_detection): Remove unnecessary cast that
9445 gcc -Wbad-function-cast diagnoses.
2037898d 9446 (gif_load): Fix pointer signedness.
6ae141d6
PE
9447 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9448 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9449
33383987 94502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9451
d32df629
PE
9452 Improve quality of tests for time stamp overflow.
9453 For example, without this patch (encode-time 0 0 0 1 1
9454 1152921504606846976) returns the obviously-bogus value (-948597
9455 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9456 reports time overflow. See
9457 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9458 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9459 * editfns.c: Include limits.h and intprops.h.
9460 (TIME_T_MIN, TIME_T_MAX): New macros.
9461 (time_overflow): Move earlier, to before first use.
9462 (hi_time, lo_time): New functions, for an accurate test for
9463 out-of-range times.
9464 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9465 (Fget_internal_run_time): Don't assume time_t fits in int.
9466 (make_time): Use list2 instead of Fcons twice.
9467 (Fdecode_time): More accurate test for out-of-range times.
9468 (check_tm_member): New function.
9469 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9470 (lisp_time_argument): Don't rely on undefined left-shift and
9471 right-shift behavior when checking for time stamp overflow.
8be6f318 9472
fe31d94c
PE
9473 * editfns.c (time_overflow): New function, refactoring common code.
9474 (Fformat_time_string, Fdecode_time, Fencode_time):
9475 (Fcurrent_time_string): Use it.
9476
8be6f318
PE
9477 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9478 * dired.c (make_time): Move to ...
9479 * editfns.c (make_time): ... here.
9480 * systime.h: Note the move.
9481
09d9db2c 94822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9483
126bc0dc
YM
9484 * fringe.c (update_window_fringes): Remove unused variables.
9485
c47cbdfd
YM
9486 * unexmacosx.c (copy_data_segment): Also copy __got section.
9487 (Bug#8223)
9488
7ac80be9
EZ
94892011-03-12 Eli Zaretskii <eliz@gnu.org>
9490
c96bbc66 9491 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9492 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9493 Constify `char *' arguments and their references according to
9494 prototypes in tparam.h.
9495
ecb0f94d 9496 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9497
7ac80be9
EZ
9498 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9499 Adapt all references accordingly.
9500
9501 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9502
ef1fd07e
TT
95032011-03-11 Tom Tromey <tromey@redhat.com>
9504
9505 * buffer.c (syms_of_buffer): Remove obsolete comment.
9506
7ef4b50c
EZ
95072011-03-11 Eli Zaretskii <eliz@gnu.org>
9508
9509 * termhooks.h (encode_terminal_code): Declare prototype.
9510
9511 * msdos.c (encode_terminal_code): Don't declare prototype.
9512
9513 * term.c (encode_terminal_code): Now external again, used by
9514 w32console.c and msdos.c.
9515
44f230aa
SM
9516 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9517 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9518
4b1ec863 95192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9520
1714f52b 9521 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9522
4b1ec863
PE
9523 * fringe.c (update_window_fringes): Mark locals as initialized
9524 (Bug#8227).
9525 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9526
524c7aa6
PE
9527 * alloc.c (mark_fringe_data): Move decl from here ...
9528 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9529 to check its interface.
9530 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9531
a5c0af81 9532 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9533 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9534 (fontset_font): Mark local as initialized.
a9a06e0b 9535 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9536
b4716021
PE
9537 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9538
811e9bac 9539 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9540 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9541 (x_own_selection, Fx_disown_selection_internal): Rename locals
9542 to avoid shadowing.
9543 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9544
7e3ab302
PE
9545 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9546 so that the caller can use some name other than gcpro1.
9547 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9548 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9549 (Fx_backspace_delete_keys_p):
9550 Use them to avoid shadowing, and rename vars to avoid shadowing.
9551 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9552 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9553 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9554 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9555 Remove unused locals.
7e3ab302
PE
9556 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9557 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9558 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9559 macros.
f78faa98 9560
e2b13473
PE
9561 * xterm.h (x_mouse_leave): New decl.
9562
77f23912
PE
9563 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9564 Remove unused functions.
cdf4ba58
PE
9565 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9566 (x_calc_absolute_position): Now static.
7411c686 9567 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9568 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9569 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9570 unless they are used.
38d0b34a
PE
9571 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9572 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9573 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9574 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9575 (x_error_catcher, x_connection_closed, x_error_handler):
9576 (x_error_quitter, xembed_send_message, x_iconify_frame):
9577 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9578 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9579 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9580
44f230aa
SM
9581 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9582 Rename or move locals to avoid shadowing.
6b463e58 9583 (tty_defined_color, merge_face_heights): Now static.
5967d051 9584 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9585 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9586 does not deduce is never used uninitialized.
73719eba
PE
9587 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9588 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9589
426994c3 9590 * terminal.c (store_terminal_param): Now static.
5489860b 9591
032f1620 9592 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9593 (set_frame_menubar): Remove unused local.
d4323972 9594 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9595 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9596 since they might point to immutable storage.
281585b0
PE
9597 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9598 since it's unused otherwise.
032f1620 9599
367c19e5 9600 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9601 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9602 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9603 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9604 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9605 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9606 does not deduce are never used uninitialized.
70739cbe 9607
07b48fa9
PE
9608 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9609
8868a238 9610 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9611 * window.c (window_loop, size_window):
9612 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9613
7e5cf297 9614 * window.c (display_buffer): Now static.
d6550a9f
PE
9615 (size_window): Mark variables that gcc -Wuninitialized
9616 does not deduce are never used uninitialized.
a586633d
PE
9617 * window.h (check_all_windows): New decl, to forestall
9618 gcc -Wmissing-prototypes diagnostic.
5b555da1 9619 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9620
f6095868
PE
9621 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9622 shadowing.
9623 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9624 Include <limits.h>.
9625 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9626 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9627 (load_charset_map): Mark variables that gcc -Wuninitialized
9628 does not deduce are never used uninitialized.
53df7c11 9629 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9630
f38b440c
PE
9631 * coding.c (coding_set_source, coding_set_destination):
9632 Use "else { /* comment */ }" rather than "else /* comment */;"
9633 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9634 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9635 a block, when the outer 'i' will do.
9636 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9637 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9638 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9639 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9640 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9641 Rename locals to avoid shadowing.
9642 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9643 * coding.c (emacs_mule_char, encode_invocation_designation):
9644 Now static, since they're not used elsewhere.
413bb2db 9645 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9646 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9647 (decode_coding_emacs_mule): Mark variables that gcc
9648 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9649 (detect_coding_iso_2022): Initialize a local variable that might
9650 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9651 this initialization is needed. (Bug#8211)
5f58e762
PE
9652 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9653 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9654 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9655 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9656 Remove unused macros.
f38b440c 9657
232b38b9 9658 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9659 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9660 * character.c (string_count_byte8): Likewise.
232b38b9 9661
fb90da1b
PE
9662 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9663 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9664
fb93dbc2
PE
9665 * chartab.c (copy_sub_char_table): Now static, since it's not used
9666 elsewhere.
5c156ace
PE
9667 (sub_char_table_ref_and_range, char_table_ref_and_range):
9668 Rename locals to avoid shadowing.
bbcd0949 9669 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9670
7d3b3862 9671 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9672 (BIDI_BOB): Remove unused macro.
7d3b3862 9673
6be7d3da
PE
9674 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9675 deduce are never used uninitialized.
c2ed9c8b 9676 * term.c (encode_terminal_code): Likewise.
6be7d3da 9677
75f8807f 9678 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9679
50938595
PE
9680 * tparam.h: New file.
9681 * term.c, tparam.h: Include it.
9682 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9683 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9684 Move these decls to tparam.h, and make them agree with what
9685 is actually in tparam.c. The previous trick of using incompatible
9686 decls in different modules does not conform to the C standard.
9687 All callers of tparam changed to use tparam's actual API.
9688 * tparam.c (tparam1, tparam, tgoto):
9689 Use const pointers where appropriate.
9690
fbceeba2
PE
9691 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9692 * cm.h (struct cm): Likewise.
9693 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9694 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9695 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9696 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9697 (turn_on_face, init_tty): Likewise.
9698 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9699
7f3f1250
PE
9700 * term.c (term_mouse_position): Rename local to avoid shadowing.
9701
e6ca6543
PE
9702 * alloc.c (mark_ttys): Move decl from here ...
9703 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9704
c40f8d15
AS
97052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9706
9707 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9708
cfe0661d
JB
97092011-03-09 Juanma Barranquero <lekktu@gmail.com>
9710
9711 * search.c (compile_pattern_1): Remove argument regp, unused since
9712 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9713 (compile_pattern): Don't pass it.
9714
0afb4571
J
97152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9716
9717 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9718 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9719 for ! HAVE_GTK3.
9720 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9721
9722 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9723
9724 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9725 gdk_window_get_screen, gdk_window_get_geometry,
9726 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9727 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9728 (xg_get_pixbuf_from_pixmap): New function.
9729 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9730 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9731 Call xg_get_pixbuf_from_pixmap instead of
9732 gdk_pixbuf_get_from_drawable.
9733 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9734 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9735 (xg_check_special_colors): Use GtkStyleContext and its functions
9736 for HAVE_GTK3.
9737 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9738 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9739 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9740 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9741 Call gtk_widget_get_preferred_size.
0afb4571
J
9742 (xg_frame_resized): gdk_window_get_geometry only takes 5
9743 parameters.
44f230aa
SM
9744 (xg_win_to_widget, xg_event_is_for_menubar):
9745 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9746 (xg_set_widget_bg): New function.
9747 (delete_cb): New function.
895009e1 9748 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9749 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9750 (xg_set_background_color): Call xg_set_widget_bg.
9751 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9752 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9753 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9754 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9755 if ! HAVE_GTK3.
9756 (update_frame_tool_bar): Call gtk_widget_hide.
9757 (xg_initialize): Use GDK_KEY_g.
9758
9759 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9760 if ! HAVE_GTK3
9761 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9762
9763 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9764 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9765 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9766
1c2cc4ef
JB
97672011-03-08 Juanma Barranquero <lekktu@gmail.com>
9768
9769 * w32xfns.c (select_palette): Check success of RealizePalette against
9770 GDI_ERROR, not zero.
9771
33383987 9772See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9773
9774;; Local Variables:
9775;; coding: utf-8
aac0c6e3
MR
9776;; End:
9777
2f097256 9778 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9779
9780 This file is part of GNU Emacs.
9781
9782 GNU Emacs is free software: you can redistribute it and/or modify
9783 it under the terms of the GNU General Public License as published by
9784 the Free Software Foundation, either version 3 of the License, or
9785 (at your option) any later version.
9786
9787 GNU Emacs is distributed in the hope that it will be useful,
9788 but WITHOUT ANY WARRANTY; without even the implied warranty of
9789 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9790 GNU General Public License for more details.
9791
9792 You should have received a copy of the GNU General Public License
9793 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.