Fix typo in previous
[bpt/emacs.git] / src / ChangeLog
CommitLineData
26bccfae
PE
12012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2
5994c183
PE
3 Add GCC-style 'const' attribute to functions that can use it.
4 * character.h (char_resolve_modifier_mask):
5 * keyboard.h (make_ctrl_char):
6 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
7 (init_character_once, next_almost_prime, init_fns, init_image)
8 (flush_pending_output, init_sound):
9 * mem-limits.h (start_of_data):
10 * menu.h (finish_menu_items):
11 Add ATTRIBUTE_CONST.
12 * emacs.c (DEFINE_DUMMY_FUNCTION):
13 Declare the dummy function with ATTRIBUTE_CONST.
14 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
15 Add decls with ATTRIBUTE_CONST.
16
26bccfae
PE
17 Minor improvements to make_formatted_string.
18 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
19 where int is good enough, as vsprintf returns an int.
20 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
21
a8290ec3
DA
222012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
23
24 Use make_formatted_string to avoid double length calculation.
25 * lisp.h (make_formatted_string): New prototype.
26 * alloc.c (make_formatted_string): New function.
27 * buffer.c (Fgenerate_new_buffer_name): Use it.
28 * dbus.c (syms_of_dbusbind): Likewise.
29 * editfns.c (Fcurrent_time_zone): Likewise.
30 * filelock.c (get_boot_time): Likewise.
31 * frame.c (make_terminal_frame, set_term_frame_name)
32 (x_report_frame_params): Likewise.
33 * image.c (gs_load): Likewise.
34 * minibuf.c (get_minibuffer): Likewise.
35 * msdos.c (dos_set_window_size): Likewise.
36 * process.c (make_process): Likewise.
37 * xdisp.c (ensure_echo_area_buffers): Likewise.
38 * xsettings.c (apply_xft_settings): Likewise.
39
d01ba2f1
GM
402012-07-09 Glenn Morris <rgm@gnu.org>
41
42 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
43 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
44 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
45 * nsterm.h (ns_etc_directory): Add it.
46 * callproc.c [HAVE_NS]: Include nsterm.h.
47 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
48
f1f924b6
DA
492012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
50
51 Move marker debugging code under MARKER_DEBUG.
52 * marker.c (MARKER_DEBUG): Move marker debugging code under
53 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
54 for bootstrap with --enable-checking (~3x slowdown reported
55 by Juanma Barranquero <lekktu@gmail.com>).
56 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
57
ab531b66
PE
582012-07-08 Paul Eggert <eggert@cs.ucla.edu>
59
60 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
61 See <http://bugs.gnu.org/11825#29>.
62
c4b3bc8a
EZ
632012-07-08 Eli Zaretskii <eliz@gnu.org>
64
65 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
66 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
67 (display_line): Add commentary about displaying truncation glyphs
68 on GUI frames.
69 (produce_special_glyphs): Move here from term.c.
70
71 * term.c (produce_special_glyphs): Move to xdisp.c.
72
73 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
74 section.
c4b3bc8a 75
b676b881
AS
762012-07-07 Andreas Schwab <schwab@linux-m68k.org>
77
f17c5273
AS
78 * xdisp.c (display_line): Avoid warning about implicit declaration
79 of FRAME_FONT.
80
298819b9
AS
81 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
82
b676b881
AS
83 * lisp.h: Remove empty conditional.
84
6045c4fd
PE
852012-07-07 Paul Eggert <eggert@cs.ucla.edu>
86
b3350bf9
PE
87 * lread.c (load_path_check): Now static.
88
6045c4fd
PE
89 Fix some minor --with-ns problems found by static checking.
90 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
91 (x_set_font) [!HAVE_X_WINDOWS]:
92 * image.c (xpm_load_image) [HAVE_NS]:
93 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
94 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
95 Remove unused local.
96 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
97 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
98 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
99 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
100 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
101 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
102 Fix pointer signedness problem.
103 * xfaces.c (FRAME_X_FONT_TABLE):
104 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
105
929e7845
GM
1062012-07-07 Glenn Morris <rgm@gnu.org>
107
108 * lread.c (load_path_check): New function, split from init_lread.
109 (init_lread): Reorganize. Motivation:
110 If EMACSLOADPATH is set, check/warn about that rather than the
111 defaults, which we are not going to use. Hence we can remove
112 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
113 Don't warn if site-lisp directories are missing.
114 If not installed, start from a blank load-path, since
115 PATH_LOADSEARCH refers to the eventual installation directories.
116
58dd0aa4
EZ
1172012-07-07 Eli Zaretskii <eliz@gnu.org>
118
119 Support truncation and continuation glyphs on GUI frames, when
120 fringes are disabled. (Bug#11832)
121 * xdisp.c (init_iterator): Get dimensions of truncation and
122 continuation glyphs even if on GUI frames. Adjust
123 it->last_visible_x on GUI frames when the left or right fringes,
124 or both, are absent.
125 (start_display, move_it_in_display_line_to): Handle the case of a
126 GUI frame without a fringe to display continuation or truncation
127 glyphs.
128 (insert_left_trunc_glyphs): Support GUI frames: make sure
129 truncation glyphs overwrite enough glyphs from the current line to
130 have sufficient space in pixels.
131 (display_line): Support truncation and continuation glyphs on GUI
132 frames. If some spare pixels are left on the line after inserting
133 the truncation glyphs, fill that space with a stretch glyph of a
134 suitably computed width.
135
136 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
137 produce_glyphs, to support GUI sessions.
138
31571fd7
PE
1392012-07-07 Paul Eggert <eggert@cs.ucla.edu>
140
5a16b9bc
PE
141 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
142
f3047c75
PE
143 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
144
31571fd7
PE
145 Do not require float-time's arg to fit in time_t (Bug#11825).
146 This works better on hosts where time_t is unsigned, and where
147 float-time is applied to the (negative) difference between two times.
148 * editfns.c (decode_time_components): Last arg is now double *,
149 not int *, and means to store all the result as a double, without
150 worrying about whether the seconds part fits in time_t.
151 All callers changed.
152 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
153 All callers changed.
154 (Ffloat_time): Do not fail merely because the specified time falls
155 outside of time_t range.
156
4516fbef
GM
1572012-07-07 Glenn Morris <rgm@gnu.org>
158
159 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
160 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
161 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
162
07adc2c6
JB
1632012-07-07 Juanma Barranquero <lekktu@gmail.com>
164
165 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
166 Update dependencies.
167
168 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
169
fd573f31
PE
1702012-07-06 Paul Eggert <eggert@cs.ucla.edu>
171
fee5959d
PE
172 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
173 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
174 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
175 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
176 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
177 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
178
fd573f31
PE
179 * xfont.c (compare_font_names): Redo to omit the need for casts.
180
ddadbc0e
AS
1812012-07-06 Andreas Schwab <schwab@linux-m68k.org>
182
fca8d6b6
AS
183 * xfns.c (Fx_change_window_property): Doc fix.
184 * w32fns.c (Fx_change_window_property): Doc fix.
185
ddadbc0e
AS
186 * w32fns.c (Fx_window_property): Accept the same arguments as the
187 X Windows version. Doc fix.
188 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
189
f247498e
JB
1902012-07-06 Juanma Barranquero <lekktu@gmail.com>
191 Eli Zaretskii <eliz@gnu.org>
192
193 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
194 Windows-specific code from nt/config.nt moved here.
195 Obsolete settings removed.
196
216ee680
PE
1972012-07-06 Paul Eggert <eggert@cs.ucla.edu>
198
199 * process.c: Avoid unnecessary calls to gettime.
200 (wait_reading_process_output): Don't get the time of day
201 when gobbling data immediately and not waiting, as there's no need
202 for it in that case. This removes a FIXME.
203
bdd091e4
JD
2042012-07-06 Jan Djärv <jan.h.d@swipnet.se>
205
206 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
207 is defined (Bug#11768).
208
9d44f8ce
DA
2092012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
210
211 Fix marker debugging code.
212 * marker.c (byte_char_debug_check): Do not perform the check
213 if buffer is not multibyte.
090bd7cb
JB
214 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
215 Call byte_char_debug_check with correct arguments.
9d44f8ce 216
90fc4786
DA
2172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
218
219 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
220 * marker.c (byte_char_debug_check, count_markers):
221 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
222 (byte_debug_flag): Remove.
223 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
224 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
225
7b7ae965
DA
2262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
227
4e57b342
DA
228 Avoid code repetition in marker-related functions.
229 * marker.c (attach_marker): New function.
230 (Fset_marker, set_marker_restricted, set_marker_both)
231 (set_marker_restricted_both): Use it.
232 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
233 Consistently rename charno to charpos.
234 (marker_position): Add eassert.
235 (marker_byte_position): Convert to eassert.
236
2372012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
238
239 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 240 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 241 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 242
657924ff
DA
2432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
244
245 Introduce fast path for the widely used marker operation.
246 * alloc.c (build_marker): New function.
247 * lisp.h (build_marker): New prototype.
248 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
249 * composite.c (autocmp_chars): Likewise.
250 * editfns.c (buildmark): Remove.
251 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
252 (save_restriction_save): Use build_marker.
253 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
254 * window.c (save_window_save): Likewise.
255
041a49a6
DA
2562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
257
258 Do not use Fdelete_overlay in delete_all_overlays
259 to avoid redundant calls to unchain_overlay.
260 * buffer.c (drop_overlay): New function.
261 (delete_all_overlays, Fdelete_overlay): Use it.
262 * minibuf.c (get_minibuffer): Fix comment.
263
7dca65a4
PE
2642012-07-06 Paul Eggert <eggert@cs.ucla.edu>
265
266 Port to OpenBSD 5.1 amd64.
267 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
268 This is needed for OpenBSD, and should be harmless on all BSD systems.
269 Also, include <sys/sysctl.h>, as it should be available on all
270 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
271 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
272 use p_pid member, not kp_proc.pid.
273
8eb876e2
GM
2742012-07-06 Glenn Morris <rgm@gnu.org>
275
276 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
277
38182d90
PE
2782012-07-05 Paul Eggert <eggert@cs.ucla.edu>
279
280 More xmalloc and related cleanup.
281 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
282 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
283 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
284 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
285 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
286 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
287 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
288 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
289 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
290 * xterm.c:
291 Omit needless casts involving void * pointers and allocation.
292 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
293 as the former is more robust if P's type is changed.
294 Prefer xzalloc to xmalloc + memset 0.
295 Simplify malloc-or-realloc to realloc.
296 Don't worry about xmalloc returning a null pointer.
297 Prefer xstrdup to xmalloc + strcpy.
298 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
299 growing it.
300 * keyboard.c (apply_modifiers_uncached): Prefer local array to
301 alloca of a constant.
302
6dd5a677
EZ
3032012-07-05 Eli Zaretskii <eliz@gnu.org>
304
305 * xdisp.c (display_line): Fix horizontal pixel coordinates when
306 hscroll is larger than the line width. Fixes long and futile
307 looping inside extend_face_to_end_of_line (on a TTY) producing
308 glyphs that are not needed and thrown away.
309
6b312f0f
DA
3102012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
311
312 * marker.c (set_marker_restricted_both): Simplify by using
313 clip_to_bounds.
314
f520ef9b
PE
3152012-07-05 Paul Eggert <eggert@cs.ucla.edu>
316
317 * editfns.c (region_limit): Simplify by using clip_to_bounds.
318
383b7c95
JD
3192012-07-05 Jan Djärv <jan.h.d@swipnet.se>
320
321 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
322 not defined (Bug#11768).
323 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
324 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
325 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
326 followed by gtk_box_set_homogeneous (Bug#11768).
327 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
328 (update_theme_scrollbar_width, xg_create_scroll_bar):
329 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
330 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
331 (is_box_type): New function (Bug#11768).
332 (xg_tool_item_stale_p): Call is_box_type.
5293d758 333 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
334 with default display (Bug#11768).
335
d6e7bf45
EZ
3362012-07-05 Eli Zaretskii <eliz@gnu.org>
337
338 * xdisp.c (window_hscroll_limited): New function.
339 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
340 coordinates when window's hscroll is set to insanely large
341 values. (Bug#11857)
342
431391ec
JB
3432012-07-05 Juanma Barranquero <lekktu@gmail.com>
344
345 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
346 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
347
23f86fce
DA
3482012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
349
350 Cleanup xmalloc.
351 * lisp.h (xzalloc): New prototype. Omit needless casts.
352 * alloc.c (xzalloc): New function. Omit needless casts.
353 * charset.c: Omit needless casts. Convert all calls to
354 xmalloc with following memset to xzalloc.
355 * dispnew.c: Likewise.
356 * fringe.c: Likewise.
357 * image.c: Likewise.
358 * sound.c: Likewise.
359 * term.c: Likewise.
360 * w32fns.c: Likewise.
361 * w32font.c: Likewise.
362 * w32term.c: Likewise.
363 * xfaces.c: Likewise.
364 * xfns.c: Likewise.
365 * xterm.c: Likewise.
366 * atimer.c: Omit needless casts.
367 * buffer.c: Likewise.
368 * callproc.c: Likewise.
369 * ccl.c: Likewise.
370 * coding.c: Likewise.
371 * composite.c: Likewise.
372 * doc.c: Likewise.
373 * doprnt.c: Likewise.
374 * editfns.c: Likewise.
375 * emacs.c: Likewise.
376 * eval.c: Likewise.
377 * filelock.c: Likewise.
378 * fns.c: Likewise.
379 * gtkutil.c: Likewise.
380 * keyboard.c: Likewise.
381 * lisp.h: Likewise.
382 * lread.c: Likewise.
383 * minibuf.c: Likewise.
384 * msdos.c: Likewise.
385 * print.c: Likewise.
386 * process.c: Likewise.
387 * region-cache.c: Likewise.
388 * search.c: Likewise.
389 * sysdep.c: Likewise.
390 * termcap.c: Likewise.
391 * terminal.c: Likewise.
392 * tparam.c: Likewise.
393 * w16select.c: Likewise.
394 * w32.c: Likewise.
395 * w32reg.c: Likewise.
396 * w32select.c: Likewise.
397 * w32uniscribe.c: Likewise.
398 * widget.c: Likewise.
399 * xdisp.c: Likewise.
400 * xmenu.c: Likewise.
401 * xrdb.c: Likewise.
402 * xselect.c: Likewise.
403
0497dc44
PE
4042012-07-05 Paul Eggert <eggert@cs.ucla.edu>
405
406 * fileio.c (time_error_value): Check the right error number.
407 Problem reported by Troels Nielsen in
408 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
409
356e7178
PE
4102012-07-04 Paul Eggert <eggert@cs.ucla.edu>
411
4e71fd89
PE
412 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
413 This should be fixed in a better way; see Eli Zaretskii in
414 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
415 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
416
f0941253
PE
417 * fileio.c (time_error_value): Rename from special_mtime.
418 The old name's problems were noted by Eli Zaretskii in
419 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
420
065c9eb4
PE
421 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
422 This variable's comment says Emacs needs at least one GDB-visible
423 symbol of type enum pvec_type, to work around GDB problems.
424 The symbol's value doesn't matter.
425
356e7178
PE
426 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
427 that causes compilation to fail on pre-C99 compilers.
428
95f61aa2
JB
4292012-07-04 Juanma Barranquero <lekktu@gmail.com>
430
431 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
432 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
433
3884d954
DA
4342012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
435
d209e2fb 436 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
437 headers for buffer_defaults and buffer_local_symbols.
438 Reported by Juanma Barranquero <lekktu@gmail.com>.
439
ee28be33
SM
4402012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
441
442 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
443 * lisp.h (enum pvec_type): Use fewer bits.
444 (PSEUDOVECTOR_SIZE_BITS): New constant.
445 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
446 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
447 change in pvec_type.
448 (PSEUDOVECTOR_TYPEP): New macro.
449 (TYPED_PSEUDOVECTORP): Use it.
450 * fns.c (internal_equal): Adapt code to extract pvectype.
451 * emacs.c (gdb_pvec_type): Update type.
452 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
453 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
454 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
455 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
456 (sweep_vectors): Use it. Use local var `total_bytes' instead of
457 abusing vector->header.next.nbytes.
458 (live_vector_p): Use PVEC_TYPE.
459 (mark_object): Adapt code to extract pvectype. Use switch.
460
c7f2cd7f
PE
4612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
462
463 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
464 Tighten new eassert a bit.
465
8ce70ed2
DA
4662012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
467
468 Fix compilation with --enable-gcc-warnings and -O1
469 optimization level.
470 * doprnt.c (doprnt): Change type of tem to int, initialize
471 to avoid compiler warning. Add eassert.
472 * search.c (simple_search): Initialize match_byte to avoid
473 compiler warning. Add eassert.
474
dea7f1e5
PE
4752012-07-04 Paul Eggert <eggert@cs.ucla.edu>
476
24a212eb
PE
477 Avoid weird behavior with large horizontal scrolls.
478 Without this change, for example, large hscroll values would
479 mess up Emacs's display on Fedora 15 x86, presumably due to
480 overflows in int calculations in the display code.
481 Also, if buffers had long lines, Emacs would freeze.
482 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
483 (set_window_hscroll): New function, containing the old guts of
484 Fset_window_hscroll. Return the clipped value.
485 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
486 This avoids the need to check against PTRDIFF_MAX.
487
dea7f1e5
PE
488 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
489
76046526
DA
4902012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
491
492 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
493
39adff0d
PE
4942012-07-04 Paul Eggert <eggert@cs.ucla.edu>
495
63807d47
PE
496 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
497 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
498 since GCC 4.4.6 issues a bogus warning for them.
499
39adff0d
PE
500 Fix bugs in file timestamp newness comparisons.
501 * fileio.c (Ffile_newer_than_file_p):
502 * lread.c (Fload): Use full timestamp resolution of files,
503 not just the 1-second resolution, so that files that are only
504 slightly newer still count as newer.
505 * fileio.c (Ffile_newer_than_file_p): Don't assume file
506 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
507
dbeed9a6
PE
5082012-07-03 Paul Eggert <eggert@cs.ucla.edu>
509
510 * fileio.c: Improve handling of file time marker. (Bug#11852)
511 (special_mtime): New function.
512 (Finsert_file_contents, Fverify_visited_file_modtime):
513 Use it to set special mtime values consistently.
514
636334d6
AS
5152012-07-03 Andreas Schwab <schwab@linux-m68k.org>
516
517 * fileio.c (Finsert_file_contents): Properly handle st_mtime
518 marker for non-existing file. (Bug#11852)
519
e2017fe2
GM
5202012-07-03 Glenn Morris <rgm@gnu.org>
521
522 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
523 and did not make it into globals.h).
524
404dbd37
TT
5252012-07-03 Tom Tromey <tromey@redhat.com>
526
527 * window.c (Fset_window_margins, Fset_window_fringes)
528 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
529 * textprop.c (Fprevious_property_change): No longer static.
530 * syntax.c (Fsyntax_table_p): No longer static.
531 * process.c (Fget_process, Fprocess_datagram_address): No longer
532 static.
533 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
534 * keyboard.c (Fcommand_execute): No longer static.
535 Remove EXFUN.
536 * insdel.c (Fcombine_after_change_execute): No longer static.
537 * image.c (Finit_image_library): No longer static.
538 * fileio.c (Fmake_symbolic_link): No longer static.
539 * eval.c (Ffetch_bytecode): No longer static.
540 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
541 * doc.c (Fdocumentation_property, Fsnarf_documentation):
542 No longer static.
404dbd37
TT
543 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
544 static.
545 * dired.c (Ffile_attributes): No longer static.
546 * composite.c (Fcomposition_get_gstring): No longer static.
547 * callproc.c (Fgetenv_internal): No longer static.
548
549 * ccl.h: Remove EXFUNs.
550 * buffer.h: Remove EXFUNs.
551 * dispextern.h: Remove EXFUNs.
552 * intervals.h: Remove EXFUNs.
553 * fontset.h: Remove EXFUN.
554 * font.h: Remove EXFUNs.
555 * dosfns.c (system_process_attributes): Remove EXFUN.
556 * keymap.h: Remove EXFUNs.
557 * lisp.h: Remove EXFUNs.
558 * w32term.h: Remove EXFUNs.
559 * window.h: Remove EXFUNs.
560 * xsettings.h: Remove EXFUN.
561 * xterm.h: Remove EXFUN.
562
8e4fd1e1
GM
5632012-07-03 Glenn Morris <rgm@gnu.org>
564
565 * lisp.h (Frandom): Make it visible to C.
566 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
567 buffer for invisible buffers. (Bug#1229)
568
ca95b3eb
DA
5692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
570
571 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
572 values which aren't power of 2.
573 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
574 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
575 accordingly.
576
7555c33f
SM
5772012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
578
579 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
580
581 * alloc.c (mark_object): Revert part of last patch to use `switch'.
582
d12e8f5a
DA
5832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
584
585 * alloc.c (allocate_vector_block): Remove redundant
586 calls to mallopt if DOUG_LEA_MALLOC is defined.
587 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
588 avoid calls to mallopt if zero_vector is returned.
589
296094c3
DA
5902012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
591
592 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
593 is enabled, avoid dereferencing NULL current_sblock if
594 running undumped.
595
36429c89
DA
5962012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
597
598 Cleanup basic buffer management.
599 * buffer.h (struct buffer): Change layout to use generic vector
600 marking code. Fix some comments. Change type of 'clip_changed'
601 to bitfield. Remove unused #ifndef old.
602 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
603 (GET_OVERLAYS_AT): Fix indentation.
604 (for_each_per_buffer_object_at): New macro.
605 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
606 (Fbuffer_local_variables): Use it.
607 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
608 * alloc.c (allocate_buffer): Adjust to match new layout of
609 struct buffer. Fix comment.
610 (mark_overlay): New function.
611 (mark_buffer): Use it. Use mark_vectorlike to mark normal
612 Lisp area of struct buffer.
613 (mark_object): Use it. Adjust marking of misc objects
614 and related comments.
615
3b3e4cac
PE
6162012-07-02 Paul Eggert <eggert@cs.ucla.edu>
617
618 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
619 wrapper that is not needed because the wrapped code is a no-op (zero
620 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
621 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
622
cf5c0175
DA
6232012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
624
625 * alloc.c (mark_buffer): Simplify. Remove prototype.
626 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 627 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
628 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
629 redundant calls to mark_vectorlike for bool vectors.
630
ca26824c
GM
6312012-06-30 Glenn Morris <rgm@gnu.org>
632
2e4c5312
GM
633 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
634
ca26824c
GM
635 * epaths.in (PATH_SITELOADSEARCH): New.
636 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
637 This is rather than relying on --enable-locallisppath elements
638 having "site-lisp" in their names. (Bug#10208#25, 11658)
639
0d23c240
EZ
6402012-06-30 Eli Zaretskii <eliz@gnu.org>
641
c9240d7a
EZ
642 * w32proc.c (sys_select): Accept and ignore one more argument.
643
644 * w32.c (emacs_gnutls_pull): Call select with one more argument.
645
0d23c240 646 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 647 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
648
649 * sysdep.c: Don't include dos.h and dosfns.h.
650
651 * process.c (sys_select):
652 * msdos.c (sys_select): Accept one more argument and ignore it.
653
654 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
655 adapt data types and code to that.
656
657 * dosfns.c:
658 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
659 which clashes with the gnulib function of the same name.
660
af5a5a98
AS
6612012-06-30 Andreas Schwab <schwab@linux-m68k.org>
662
c5e4379c
AS
663 * font.c (font_style_to_value, font_style_symbolic)
664 (font_prop_validate_style): Add type checks for values in
665 font_style_table.
666
af5a5a98
AS
667 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
668 argument.
669 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
670 uses.
671
8d38f461
EZ
6722012-06-29 Eli Zaretskii <eliz@gnu.org>
673
2e5a6631
EZ
674 * xdisp.c (try_window_id): Undo last change.
675
8d38f461
EZ
676 * w32.c (getwd): Adjust commentary about startup_dir.
677 (init_environment): Always call sys_access, even in non-MSVC
678 builds. Don't chdir to the directory of the Emacs executable.
679 This undoes code from 1997 which was justified by the need to
680 "avoid conflicts when removing and renaming directories". But its
681 downside was that every relative file name was being interpreted
682 relative to the directory of the Emacs executable, which can never
683 be TRT. In particular, it broke sys_access when called with
684 relative file names.
685 (sys_access): Map GetLastError to errno.
686
2af3565e
DA
6872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
688
689 * window.h (struct window): Change type of 'fringes_outside_margins'
690 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 691 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
692 Adjust comment.
693 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
694 to ptrdiff_t.
695
c8d3a25c 6962012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 697
c8d3a25c
GM
698 * gnutls.c (emacs_gnutls_handshake):
699 Add QUIT to make the loop interruptible.
57570cd3 700
c8d3a25c 7012012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 702
c8d3a25c
GM
703 * charset.c (init_charset): Make lack of etc/charsets fatal.
704
3e984ee8
DA
7052012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
706
707 * editfns.c (region_limit): Fix type mismatch.
708
ef884f23
DA
7092012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
710
711 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
712 undefined. Convert from xassert to eassert.
713 * nsmenu.m: Convert from xassert to eassert.
714 * nsterm.m: Likewise.
715
7d7e0027
SM
7162012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
717
718 * editfns.c (region_limit): Clip to narrowing (bug#11770).
719
aa754e6a
PE
7202012-06-28 Paul Eggert <eggert@cs.ucla.edu>
721
722 Avoid integer overflow on scroll-left and scroll-right.
723 * window.c (HSCROLL_MAX): New macro.
724 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
725 overflow when requested scroll falls outside ptrdiff_t range.
726
80b00b08
DA
7272012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
728
729 * window.h (struct window): Change type of 'hscroll',
730 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
731 'last_modified' and 'last_overlay_modified' to EMACS_INT.
732 Adjust users accordingly.
733 * xdisp.c (try_cursor_movement): Replace type check with eassert.
734 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
735 from EMACS_INT to ptrdiff_t.
736 (make_window): Omit redundant initialization.
737
62b2bcf6
JB
7382012-06-28 Juanma Barranquero <lekktu@gmail.com>
739
740 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
741
45942c7d
DA
7422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
743
744 * window.h (struct window): Change type of 'use_time' and
745 'sequence_number' from Lisp_Object to int.
746 * frame.c (make_frame): Adjust users accordingly.
747 * print.c (print_object): Likewise.
748 * window.c (select_window, Fwindow_use_time, make_parent_window)
749 (make_window): Likewise.
750
e509cfa6
DA
7512012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
752
753 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
754 enabled with --enable-checking=[all,glyphs] configure option.
755 Fix GLYPH_DEBUG usage assuming that it may be undefined,
756 adjust comments accordingly.
757 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
758 undefined, adjust comments accordingly.
759 * image.c: Likewise.
760 * scroll.c: Likewise.
761 * w32fns.c: Likewise.
762 * w32term.c: Likewise.
763 * xdisp.c: Likewise.
764 * xfaces.c: Likewise.
765 * xfns.c: Likewise.
766 * xterm.c: Likewise.
767
a54e2c05
DA
7682012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
769
770 Generalize run-time debugging checks.
771 * dispextern.h (XASSERTS): Remove.
772 * fontset.c (xassert): Remove.
773 Convert from xassert to eassert.
774 * alloc.c: Convert from xassert to eassert.
775 * bidi.c: Likewise.
776 * dispnew.c: Likewise.
777 * fns.c: Likewise.
778 * fringe.c: Likewise.
779 * ftfont.c: Likewise.
780 * gtkutil.c: Likewise.
781 * image.c: Likewise.
782 * keyboard.c: Likewise.
783 * menu.c: Likewise.
784 * process.c: Likewise.
785 * scroll.c: Likewise.
786 * sound.c: Likewise.
787 * term.c: Likewise.
788 * w32console.c: Likewise.
789 * w32fns.c: Likewise.
790 * w32term.c: Likewise.
791 * window.c: Likewise.
792 * xdisp.c: Likewise.
793 * xfaces.c: Likewise.
794 * xfns.c: Likewise.
795 * xselect.c: Likewise.
796 * xterm.c: Likewise.
797
1ec4b7b2
SM
7982012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
799
800 * fns.c (maybe_resize_hash_table): Output message when growing the
801 purify-hashtable.
802
2014308a
DA
8032012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
804
805 * alloc.c (allocate_string_data): Remove dead code.
806 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
807 avoid GCC warning about unused macro.
808
246155eb
DA
8092012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
810
811 * alloc.c (allocate_string): Omit intervals initialization.
812 * alloc.c (make_uninit_multibyte_string): Initialize intervals
813 as in make_pure_string and make_pure_c_string.
814
43184b7b
DA
8152012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
816
d209e2fb 817 * alloc.c (allocate_string): Fix last change.
43184b7b 818
3fe6dd74
DA
8192012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
820
d209e2fb 821 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
822 to memset, add explicit initialization where appropriate.
823
1ba6038a
GM
8242012-06-27 Glenn Morris <rgm@gnu.org>
825
826 * lisp.mk (lisp): Remove paths.elc.
827
c89926a5
CY
8282012-06-27 Chong Yidong <cyd@gnu.org>
829
830 * doc.c (Fsubstitute_command_keys): Fix punctuation.
831
ed6b3510
JW
8322012-06-26 John Wiegley <johnw@newartisans.com>
833
1ec4b7b2 834 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
835 on Mac OS X Lion: __mod_init_func and __mod_term_func.
836
ed6b3510
JW
837 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
838 when building with Clang.
839
8edd4a2b
SM
8402012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
841
842 * eval.c (Fapply): Allow calling it with a single argument.
843
f6f62d1b
EZ
8442012-06-26 Eli Zaretskii <eliz@gnu.org>
845
846 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
847 _stricmp and _strnicmp.
848 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
849
62efea5e
DA
8502012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
851
852 * alloc.c (allocate_window): Zero out non-Lisp part of newly
853 allocated window.
854 (allocate_process): Likewise for new process.
8edd4a2b 855 (allocate_terminal): Change to use offsetof.
62efea5e
DA
856 (allocate_frame): Likewise.
857 * frame.c (make_frame): Omit redundant initialization.
858 * window.c (make_parent_window): Use memset.
859 (make_window): Omit redundant initialization.
860 * process.c (make_process): Omit redundant initialization.
861 * terminal.c (create_terminal): Likewise.
862
42997f4d
DA
8632012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
864
865 * term.c (delete_tty): Remove redundant call to memset.
866
1130ecfc
DA
8672012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
868
869 * alloc.c: Remove build_string.
870 * lisp.h: Define build_string as static inline. This provides
871 a better opportunity to optimize away calls to strlen when the
872 function is called with compile-time constant argument.
873 * image.c (imagemagick_error): Convert to build_string.
874 * w32proc.c (sys_spawnve): Likewise.
875 * xterm.c (x_term_init): Likewise.
876
cf38a720
PE
8772012-06-26 Paul Eggert <eggert@cs.ucla.edu>
878
99027bdd
PE
879 Use sprintf return value instead of invoking strlen on result.
880 In the old days this wasn't portable, since some sprintf
881 implementations returned char *. But they died out years ago and
882 Emacs already assumes sprintf returns int.
883 Similarly for float_to_string.
884 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
885 * ccl.c (ccl_driver):
886 * character.c (string_escape_byte8):
887 * data.c (Fnumber_to_string):
888 * doprnt.c (doprnt):
889 * print.c (print_object):
890 * xdisp.c (message_dolog):
891 * xfns.c (syms_of_xfns):
892 Use sprintf or float_to_string result to avoid need to call strlen.
893 * data.c (Fnumber_to_string):
894 Use make_unibyte_string, since the string must be ASCII.
895 * lisp.h, print.c (float_to_string): Now returns int length.
896 * term.c (produce_glyphless_glyph):
897 Use sprintf result rather than recomputing it.
898
cf38a720
PE
899 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
900 * Makefile.in (ALL_CFLAGS):
901 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
902 * gmalloc.c, regex.c: Include <config.h> unconditionally.
903
3511c784
DA
9042012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
905
0a08eb21 906 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
907 strcasecmp if available.
908 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
909
fb7da12e
AS
9102012-06-25 Andreas Schwab <schwab@linux-m68k.org>
911
912 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
913 Avoid comma operator.
914 * menu.c (push_submenu_start, push_submenu_end)
915 (push_left_right_boundary, push_menu_pane): Likewise.
916 * msdos.c (dos_rawgetc): Likewise.
917
afa2ffd8
DA
9182012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
919
920 * xfns.c (xic_create_fontsetname): Remove redundant calls
921 to memset.
922
b3b4476b
PE
9232012-06-25 Paul Eggert <eggert@cs.ucla.edu>
924
4495ff38
PE
925 * gtkutil.c (get_utf8_string): Remove redundant assignment.
926 sprintf already null-terminates its output.
927
b3b4476b
PE
928 * xfns.c (x_window): Remove redundant cast.
929
b00876c9
DA
9302012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
931
932 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
933 `const char *' to `char *' to avoid compiler warning.
934
d188e26b
PE
9352012-06-24 Paul Eggert <eggert@cs.ucla.edu>
936
885d1d74
PE
937 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
938 instead of truncating it to 63 (admittedly a generous limit).
939
d188e26b
PE
940 * process.c: Fix spelling and caps in comments.
941
e2f560b1
DN
9422012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
943
e86db54b 944 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
945 * sysdep.c (setpgrp): Remove definition, not used in this file.
946
7583a3a1
JB
9472012-06-24 Juanma Barranquero <lekktu@gmail.com>
948
949 * makefile.w32-in: Update dependencies.
950
696056c2
EZ
9512012-06-24 Eli Zaretskii <eliz@gnu.org>
952
953 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
954 (SYSTIME_H): Add nt/inc/sys/time.h.
955
956 * systime.h [WINDOWSNT]: Include sys/time.h.
957
958 * s/ms-w32.h (struct timespec): Definition moved from
959 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
960
845ca893
PE
9612012-06-24 Paul Eggert <eggert@cs.ucla.edu>
962
963 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
964 * buffer.h (buffer_slot_type_mismatch):
965 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
966 * eval.c (unwind_to_catch):
967 * image.c (my_png_error, my_error_exit):
968 * keyboard.c (quit_throw_to_read_char, user_error)
969 (Fexit_recursive_edit, Fabort_recursive_edit):
970 * lisp.h (die, args_out_of_range, args_out_of_range_3)
971 (wrong_type_argument, buffer_overflow, __executable_start)
972 (memory_full, buffer_memory_full, string_overflow, Fthrow)
973 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
974 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
975 (fatal):
976 (child_setup) [!DOS_NT]:
977 * lread.c (end_of_file_error, invalid_syntax):
978 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
979 * puresize.h (pure_write_error):
980 * search.c (matcher_overflow):
981 * sound.c (sound_perror, alsa_sound_perror):
982 * sysdep.c, syssignal.h (croak):
983 * term.c (maybe_fatal, vfatal):
984 * textprop.c (text_read_only):
985 * undo.c (user_error):
986 * unexmacosx.c (unexec_error):
987 * xterm.c (x_ins_del_lines, x_delete_glyphs):
988 Use _Noreturn rather than NO_RETURN.
989 No need for separate decl merely because of _Noreturn.
990 * sound.c (sound_warning, parse_sound):
991 Remove unnecessary forward decls.
992
f1dd8073
PE
9932012-06-24 Paul Eggert <eggert@cs.ucla.edu>
994
995 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
996 * lisp.h (WAIT_READING_MAX): New macro.
997 * dispnew.c (Fsleep_for, sit_for):
998 * keyboard.c (kbd_buffer_get_event):
999 * process.c (Faccept_process_output):
1000 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1001 This improves on the previous patch, which introduced a bug
1002 when time_t is unsigned and as wide as intmax_t.
1003 See <http://bugs.gnu.org/9000#51>.
1004
b82c1755
EZ
10052012-06-23 Eli Zaretskii <eliz@gnu.org>
1006
1007 * dispnew.c (sit_for, Fsleep_for):
1008 * keyboard.c (kbd_buffer_get_event):
1009 * process.c (Faccept_process_output): Avoid compiler warnings when
1010 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1011
ca300656
JB
10122012-06-23 Juanma Barranquero <lekktu@gmail.com>
1013
049ec95b
JB
1014 * makefile.w32-in: Update dependencies.
1015
ca300656
JB
1016 * w32.c (ltime): Add return type and declare static.
1017 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1018
db7b8d06
PE
10192012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1022 Privately reported by Herbert J. Skuhra.
1023 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1024 All uses changed.
1025 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1026 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1027
0bd8297f
EZ
10282012-06-23 Eli Zaretskii <eliz@gnu.org>
1029
96512555
EZ
1030 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1031 last argument of make_unibyte_string.
1032
0bd8297f
EZ
1033 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1034 language ID in the event parameters.
1035
1036 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1037 event.code, not the obscure "character set ID".
1038
63def6b6
CY
10392012-06-23 Chong Yidong <cyd@gnu.org>
1040
1041 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1042
e8a02204
EZ
10432012-06-23 Eli Zaretskii <eliz@gnu.org>
1044
388cdec0
EZ
1045 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1046 * w32.c (fdutimens): New function.
1047
1048 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1049
1050 * s/ms-w32.h (pselect): Redirect to sys_select.
1051
1052 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1053
e8a02204
EZ
1054 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1055 in the logic of incrementing and decrementing the value of
1056 use_relocatable_buffers.
1057
d054f3fb
PE
10582012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1059
1060 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1061 Privately reported by Herbert J. Skuhra.
1062 [__FreeBSD__]: Remove "*/" typo after "#include".
1063 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1064 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1065 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1066 Don't assume EMACS_TIME and struct timeval are the same type.
1067
d35af63c
PE
10682012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 Support higher-resolution time stamps (Bug#9000).
1071 The time stamps are only nanosecond-resolution at the C level,
1072 since that's the best that any real-world system supports now.
1073 But they are picosecond-resolution at the Lisp level, as that's
1074 easy, and leaves room for future OS improvements.
1075
1076 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1077 (LIBES): Use it.
1078
1079 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1080 Don't get current time unless it's needed.
1081
1082 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1083 now provides it if it's absent.
1084 (start_atimer): Port to higher-res time stamps.
1085 Check for time stamp overflow. Don't get current time more
1086 often than is needed.
1087
1088 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1089 Include systime.h, not time.h.
1090 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1091
1092 * dired.c: Include stat-time.h.
1093 (Ffile-attributes): File times now have higher resolution.
1094
1095 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1096 (struct image): Timestamp now has higher resolution.
1097
1098 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1099 has at least microseconds now. All uses removed.
1100 (update_frame, update_single_window, update_window, update_frame_1)
1101 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1102
1103 * editfns.c (time_overflow): Now extern.
1104 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1105 (float-time, Fformat_time_string, Fcurrent_time_string)
1106 (Fcurrent_time_zone): Accept and generate higher-resolution
1107 time stamps.
1108 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1109 (decode_time_components, lisp_seconds_argument): New functions.
1110 (make_time): Now static.
1111 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1112 Report an error if the time is invalid, rather than having the caller
1113 do that.
1114
1115 * fileio.c: Include <stat-time.h>
1116 (Fcopy_file): Copy higher-resolution time stamps.
1117 Prefer to set the time stamp via a file descriptor if that works.
1118 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1119 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1120 (Fvisited_file_modtime, Fset_visited_file_modtime):
1121 Support higher-resolution time stamps.
1122
1123 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1124
1125 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1126
1127 * image.c (prepare_image_for_display, clear_image_cache)
1128 (lookup_image): Port to higer-resolution time stamps.
1129
1130 * keyboard.c (start_polling, bind_polling_period):
1131 Check for time stamp overflow.
1132 (read_char, kbd_buffer_get_event, timer_start_idle)
1133 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1134 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1135 Port to higher-resolution time stamps. Do not assume time_t is signed.
1136 (decode_timer): New function. Timers are now vectors of length 9,
1137 not 8, to accommodate the picosecond component.
1138 (timer_check_2): Use it.
1139
1140 * nsterm.m (select_timeout, timeval_subtract): Remove.
1141 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1142 as they're a bit more accurate and handle overflow better.
1143 (ns_select): Change prototype to be compatible with pselect.
1144 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1145 * nsterm.h (ns_select): Adjust prototype.
1146
1147 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1148 us-resolution time stamps.
1149 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1150
1151 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1152
1153 * lisp.h (time_overflow): New decl.
1154 (wait_reading_process_output): First arg is now intmax_t, not int,
1155 to accommodate larger waits.
1156
1157 * process.h (struct Lisp_Process.read_output_delay):
1158 Now counts nanoseconds, not microseconds.
1159 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1160 EMACS_HAS_USECS.
1161 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1162 (wait_reading_process_output):
1163 Port to ns-resolution time stamps.
1164 (Faccept_process_output, wait_reading_process_output):
1165 Check for time stamp overflow. Do not assume time_t is signed.
1166 (select_wrapper): Remove; we now use pselect.
1167 (Fprocess_attributes): Now generates ns-resolution time stamps.
1168
1169 * sysdep.c: Include utimens.h. Don't include utime.h
1170 or worry about struct utimbuf; gnulib does that for us now.
1171 (gettimeofday): Remove; gnulib provides a substitute.
1172 (make_timeval): New function.
1173 (set_file_times): Now sets ns-resolution time stamps.
1174 New arg FD; all uses changed.
1175 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1176 (system_process_attributes):
1177 Now returns ns-resolution time stamp. All uses changed.
1178 Check for time stamp overflow.
1179
1180 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1181 provides a substitute now.
1182
1183 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1184 since it guarantees struct timespec.
1185 (EMACS_TIME): Now struct timespec, so that we can support
1186 ns-resolution time stamps.
1187 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1188 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1189 (EMACS_USECS): Remove.
1190 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1191 so multiply the arg by 1000 before storing it.
1192 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1193 New macros.
1194 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1195 Port to ns-resolution time stamps.
1196 (EMACS_TIME_NEG_P): Remove; replaced by....
1197 (EMACS_TIME_SIGN): New macro.
1198 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1199 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1200 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1201 (make_timeval, make_lisp_time, decode_time_components): New decls.
1202 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1203 that it mishandled time_t overflow. You can't compare by subtracting!
1204 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1205 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1206
1207 * term.c: Include <sys/time.h>.
1208 (timeval_to_Time): New function, for proper overflow wraparound.
1209 (term_mouse_position, term_mouse_click): Use it.
1210
1211 * undo.c (record_first_change): Support higher-resolution time stamps
1212 in the undo buffer.
1213 (Fprimitive_undo): Use them when restoring time stamps.
1214
1215 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1216 (w32_get_internal_run_time):
1217 Port to higher-resolution Emacs time stamps.
1218 (ltime): Now accepts single 64-bit integer, as that's more convenient
1219 for callers.
1220
1221 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1222
1223 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1224 for compatibility with pselect. Support ns-resolution time stamps.
1225
1226 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1227
1228 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1229 Check for time stamp overflow, and support ns-resolution time stamps.
1230
1231 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1232 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1233 (timeval_subtract): Remove; no longer needed.
1234 (XTflash, XTring_bell, x_wait_for_event):
1235 Port to ns-resolution time stamps. Don't assume time_t is signed.
1236
b6a92dfe
CY
12372012-06-22 Chong Yidong <cyd@gnu.org>
1238
1239 * xdisp.c (x_consider_frame_title): Revert last change.
1240
d251c37c
EZ
12412012-06-22 Eli Zaretskii <eliz@gnu.org>
1242
1243 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1244 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1245 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1246 staticidx goes up to 1597 out of 1600 = 0x640.)
1247
f10deafb
PE
12482012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1251 Otherwise, the umask might be mistakenly 0 while handling input signals.
1252
ec6de1e2
SM
12532012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1254
1255 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1256
28be1ada
DA
12572012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1258
1259 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1260 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1261 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1262 access to `contents' member of Lisp_Vector objects with AREF and ASET
1263 where appropriate.
1264
c6bf3022
CY
12652012-06-19 Chong Yidong <cyd@gnu.org>
1266
1267 * frame.c (delete_frame): When selecting a frame on a different
1268 text terminal, do not alter the terminal's top-frame.
1269
1270 * xdisp.c (format_mode_line_unwind_data): Record the target
1271 frame's selected window and its terminal's top-frame.
1272 (unwind_format_mode_line): Restore them.
1273 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1274 Callers changed.
1275 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1276 since tty frames can be explicitly named.
1277 (prepare_menu_bars): Likewise.
1278
1279 * term.c (Ftty_top_frame): New function.
1280
defd4196
PE
12812012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 Port byte-code-meter to modern targets.
1284 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1285 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1286 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1287 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1288 (METER_1, METER_2): Simplify.
1289
1053a871
SM
12902012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1291
1292 * data.c (Fdefalias): Return `symbol' (bug#11686).
1293
b7e8d081
MR
12942012-06-18 Martin Rudalics <rudalics@gmx.at>
1295
1296 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1297 gets killed during executing of this function (Bug#11665).
1298 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1299 (Vkill_buffer_query_functions): In doc-string say that functions
1300 run by this hook should not change the current buffer.
1301
7ea2b339
PE
13022012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 Fix recently-introduced process.c problems found by static checking.
1305 * process.c (write_queue_push, write_queue_pop, send_process):
1306 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1307 (write_queue_pop): Fix pointer signedness problem.
1308 (send_process): Remove unused local.
1309
96a313a1
CY
13102012-06-17 Chong Yidong <cyd@gnu.org>
1311
1312 * xdisp.c (redisplay_internal): No need to redisplay terminal
1313 frames that are not on top.
1314
20ca2e94
TN
13152012-06-17 Troels Nielsen <bn.troels@gmail.com>
1316
1317 * process.c (make_process): Initialize write_queue.
1318 (write_queue_push, write_queue_pop): New functions.
1319 (send_process): Use them to maintain correct ordering of process
1320 writes (Bug#10815).
1321
9a900ca9
PE
13222012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1323
310fbfa8
PE
1324 * lisp.h (eassert): Assume C89 or later.
1325 This removes the need for CHECK.
1326 (CHECK): Remove. Its comments about always evaluating its
1327 argument were confusing, as 'eassert' typically does not evaluate
1328 its argument.
1329
27bb1ca4
PE
1330 * coding.c (produce_chars): Use ptrdiff_t, not int.
1331
9a900ca9
PE
1332 * xterm.c (x_draw_underwave): Check for integer overflow.
1333 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1334
41b7f8bc 13352012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1336
1337 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1338 referenced (Bug#11583).
1339
9b0e3eba
AA
13402012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1341
1342 Implement wave-style variant of underlining.
1343 * dispextern.h (face_underline_type): New enum.
1344 (face): Add field for underline type.
1345 * nsterm.m (ns_draw_underwave): New function.
1346 (ns_draw_text_decoration): Use it.
1347 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1348 New functions.
1349 (x_draw_glyph_string): Use them.
1350 * xfaces.c (Qline, Qwave): New Lisp objects.
1351 (check_lface_attrs, merge_face_ref)
1053a871
SM
1352 (Finternal_set_lisp_face_attribute, realize_x_face):
1353 Handle wave-style underline face attributes.
9b0e3eba
AA
1354 * xterm.c (x_draw_underwave): New function.
1355 (x_draw_glyph_string): Use it.
1356
0fb52f11
JB
13572012-06-16 Juanma Barranquero <lekktu@gmail.com>
1358
1359 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1360 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1361 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1362 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1363 ($(BLD)/w32select.$(O)): Update dependencies.
1364
e5560ff7
AS
13652012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1366
1367 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1368 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1369 * character.c (_fetch_multibyte_char_p): Remove.
1370 * alloc.c: Include "character.h" before "buffer.h".
1371 * bidi.c: Likewise.
1372 * buffer.c: Likewise.
1373 * bytecode.c: Likewise.
1374 * callint.c: Likewise.
1375 * callproc.c: Likewise.
1376 * casefiddle.c: Likewise.
1377 * casetab.c: Likewise.
1378 * category.c: Likewise.
1379 * cmds.c: Likewise.
1380 * coding.c: Likewise.
1381 * composite.c: Likewise.
1382 * dired.c: Likewise.
1383 * dispnew.c: Likewise.
1384 * doc.c: Likewise.
1385 * dosfns.c: Likewise.
1386 * editfns.c: Likewise.
1387 * emacs.c: Likewise.
1388 * fileio.c: Likewise.
1389 * filelock.c: Likewise.
1390 * font.c: Likewise.
1391 * fontset.c: Likewise.
1392 * fringe.c: Likewise.
1393 * indent.c: Likewise.
1394 * insdel.c: Likewise.
1395 * intervals.c: Likewise.
1396 * keyboard.c: Likewise.
1397 * keymap.c: Likewise.
1398 * lread.c: Likewise.
1399 * macros.c: Likewise.
1400 * marker.c: Likewise.
1401 * minibuf.c: Likewise.
1402 * nsfns.m: Likewise.
1403 * nsmenu.m: Likewise.
1404 * print.c: Likewise.
1405 * process.c: Likewise.
1406 * regex.c: Likewise.
1407 * region-cache.c: Likewise.
1408 * search.c: Likewise.
1409 * syntax.c: Likewise.
1410 * term.c: Likewise.
1411 * textprop.c: Likewise.
1412 * undo.c: Likewise.
1413 * unexsol.c: Likewise.
1414 * w16select.c: Likewise.
1415 * w32fns.c: Likewise.
1416 * w32menu.c: Likewise.
1417 * window.c: Likewise.
1418 * xdisp.c: Likewise.
1419 * xfns.c: Likewise.
1420 * xmenu.c: Likewise.
1421 * xml.c: Likewise.
1422 * xselect.c: Likewise.
1423
2f07e6af
EZ
14242012-06-16 Eli Zaretskii <eliz@gnu.org>
1425
1053a871
SM
1426 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1427 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1428 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1429 row.
1430 (handle_face_prop): Use chunk-relative overlay string index when
1431 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1432 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1433 the rightmost. (Bug#11720)
2f07e6af 1434
29b83cec
AS
14352012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1436
1437 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1438 (CATEGORY_MEMBER): Enforce 1/0 value.
1439 * category.c (_temp_category_set): Remove.
1440
4c5501e9
EZ
14412012-06-16 Eli Zaretskii <eliz@gnu.org>
1442
1443 * window.c (Fdelete_other_windows_internal)
1444 (Fdelete_window_internal): Don't access frame's mouse highlight
1445 info of the initial frame. (Bug#11677)
1446
2b570124
PE
14472012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1448
e93864f9
PE
1449 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1450 Assume USE_2_TAGS_FOR_INTS.
1451 (xreload): Adjust $tagmask width to match recent lisp.h change.
1452
2b570124
PE
1453 Simplify lisp.h in minor ways that should not affect code.
1454 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1455 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1456 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1457 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1458 (INTTYPEBITS): New macro, for clarity.
1459 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1460 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1461 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1462 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1463 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1464
81755f69
JB
14652012-06-13 Juanma Barranquero <lekktu@gmail.com>
1466
1467 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1468
16192a57
GM
14692012-06-13 Glenn Morris <rgm@gnu.org>
1470
1471 * s/bsd-common.h (BSD4_3):
1472 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1473
646b5f55
AS
14742012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1475
1476 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1477 instead of union.
1478 (XLI, XIL): Define.
1053a871
SM
1479 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1480 Use them.
1481 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1482 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1483 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1484 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1485 * frame.c (delete_frame): Remove outdated comment.
1486 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1487 USE_LISP_UNION_TYPE.
1488 (Fw32_unregister_hot_key): Likewise.
1489 (Fw32_toggle_lock_key): Likewise.
1490 * w32menu.c (add_menu_item): Likewise.
1491 (w32_menu_display_help): Use XIL instead of checking
1492 USE_LISP_UNION_TYPE.
1493 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1494 (init_heap): Likewise.
1495 * w32term.c (w32_read_socket): Update comment.
1496
1d3823c9
GM
14972012-06-13 Glenn Morris <rgm@gnu.org>
1498
c62ff706
GM
1499 * s/usg5-4-common.h, src/s/unixware.h:
1500 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1501
1d3823c9
GM
1502 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1503
bfe3e0a2
PE
15042012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1507 * alloc.c (make_number) [!defined make_number]:
1508 Remove, as lisp.h always defines this now.
1509 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1510 (roundup_size): Verify that it is a power of 2.
1511 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1512 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1513 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1514 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1515 USE_LSB_TAG now is always defined to be either 0 or 1.
1516 All uses changed.
1517 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1518 code works fine either way, and efficiency is not a concern here,
1519 as the union type is for debugging, not for production.
1520 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1521 Use an inline function on all platforms when using the union type,
1522 since this is simpler and 'static inline' can be used portably
1523 within Emacs now.
1524 (LISP_INITIALLY_ZERO): New macro.
1525 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1526 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1527
45fa9c0f
GM
15282012-06-12 Glenn Morris <rgm@gnu.org>
1529
b4492cba
GM
1530 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1531
1532 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1533
45fa9c0f
GM
1534 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1535 Move BROKEN_SIGIO to configure.
1536
1537 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1538 Move NO_TERMIO to configure.
1539
0e25d334
CY
15402012-06-12 Chong Yidong <cyd@gnu.org>
1541
1542 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1543 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1544 MagickExportImagePixels is undefined.
1545
43682bb6
PE
15462012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 * image.c (imagemagick_load_image): Remove unused label.
1549
a9be7d2b
GM
15502012-06-11 Glenn Morris <rgm@gnu.org>
1551
1552 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1553 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1554 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1555 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1556
3017f87f
SM
15572012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1558
1559 * alloc.c (make_byte_code): New function.
1560 (Fmake_byte_code): Use it. Don't purify here.
1561 * lread.c (read1): Use it as well to avoid extra allocation.
1562
1b9b4cf4
CY
15632012-06-11 Chong Yidong <cyd@gnu.org>
1564
1565 * image.c (imagemagick_load_image): Implement transparency.
1566
95988fcf
AS
15672012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1568
1569 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1570 account for preceding backslashes. (Bug#11663)
1571
cd4eb164
CY
15722012-06-09 Chong Yidong <cyd@gnu.org>
1573
1574 * term.c: Support italics in capable terminals (Bug#9652).
1575 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1576 (turn_on_face): Output using TS_enter_italic_mode if available.
1577 Don't handle unused blinking and alt-charset cases.
1578 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1579 and tty_alt_charset_p cases.
1580 (tty_capable_p, init_tty): Support italics.
1581
1582 * termchar.h (struct tty_display_info): Add field for italics.
1583 Remove unused blink field.
1584
1585 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1586 Handle slant.
1587
1588 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1589 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1590 tty_alt_charset_p. Add tty_italic_p.
1591
ff88beb8
MA
15922012-06-09 Michael Albinus <michael.albinus@gmx.de>
1593
1594 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1595 dbus_type_is_basic if available.
1596 (xd_extract_signed, xd_extract_unsigned): Rename from
1597 extract_signed and extract_unsigned, respectively. Adapt callers.
1598
44286096
CY
15992012-06-09 Chong Yidong <cyd@gnu.org>
1600
1682701f
CY
1601 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1602
44286096
CY
1603 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1604 case (Bug#9752).
1605
d86feb17
PE
16062012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 * xdisp.c (vmessage): Treat frame message as multibyte.
1609 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1610 would generate the diagnostic "Making \302\247 buffer-local while
1611 let-bound!".
1612
d5c20fe8
EZ
16132012-06-08 Eli Zaretskii <eliz@gnu.org>
1614
1615 * dispnew.c (showing_window_margins_p): Undo last change, which
1616 was done due to an inadvertent commit.
1617 (adjust_frame_glyphs_for_frame_redisplay): Do call
1618 showing_window_margins_p.
1619
513749ee
SM
16202012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1621
1622 * eval.c (Fmake_var_non_special): New primitive.
1623 (syms_of_eval): Defsubr it.
1624 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1625
d4a8f5c1
JB
16262012-06-08 Juanma Barranquero <lekktu@gmail.com>
1627
1628 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1629 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1630
8bbbc977
EZ
16312012-06-08 Eli Zaretskii <eliz@gnu.org>
1632
1633 * alloc.c (allocate_vectorlike): Fix last change.
1634
f3372c87
DA
16352012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1636
1637 Block-based vector allocation of small vectors.
1638 * lisp.h (struct vectorlike_header): New field `nbytes',
1639 adjust comment accordingly.
1640 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1641 to denote vector blocks. Adjust users (live_vector_p,
1642 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1643 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1644 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1645 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1646 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1647 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1648 (roundup_size): New constant.
1649 (struct vector_block): New data type.
1650 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1651 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1652 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1653 (sweep_vectors): New functions.
1654 (allocate_vectorlike): Return `zero_vector' as the only vector of
1655 0 items. Allocate new vector from block if vector size is less than
1656 or equal to VBLOCK_BYTES_MAX.
1657 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1658 (init_alloc_once): Add call to init_vectors.
1659
4f18a4ed
SM
16602012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1661
1662 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1663
86f158bc
PE
16642012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 * doprnt.c (doprnt): Truncate multibyte char correctly.
1667 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1668 would mishandle a string argument "Xc" if X was a multibyte
1669 character of length 2: it would truncate after X's first byte
1670 rather than including all of X.
1671
c5cfcbe0
CY
16722012-06-06 Chong Yidong <cyd@gnu.org>
1673
1674 * buffer.c (word_wrap): Doc fix.
1675
c05cf390
PE
16762012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1679
0c3461de
GM
16802012-06-03 Glenn Morris <rgm@gnu.org>
1681
1682 * xdisp.c (tool-bar-style): Doc fix.
1683
c71232db
UM
16842012-06-03 Ulrich Müller <ulm@gentoo.org>
1685
1686 * Makefile.in (PAXCTL): Define.
1687 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1688 binary via PaX flags if the paxctl utility is available.
1689 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1690 Restore PaX flags to their default. (Bug#11398)
1691
383f7350
CY
16922012-06-03 Chong Yidong <cyd@gnu.org>
1693
1694 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1695 buffer (Bug#11226).
1696
5f2c76c6
CY
16972012-06-03 Chong Yidong <cyd@gnu.org>
1698
1699 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1700 (note_mode_line_or_margin_highlight): If there is no help echo,
1701 use mode-line-default-help-echo. Handle the case where the mouse
1702 position is past the end of the mode line string.
1703
1704 * buffer.c (buffer_local_value_1): New function, split from
1705 Fbuffer_local_value; can return Qunbound.
1706 (Fbuffer_local_value): Use it.
1707 (Vmode_line_format): Docstring tweaks.
1708
773d47f6
PE
17092012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 * sysdep.c (system_process_attributes): Improve comment.
1712
f2d6a3df
SM
17132012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1714
1715 * keyboard.c: Export real-this-command to Elisp.
1716 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1717 and DEFVAR it. Update all users.
1718
63810350
PE
17192012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1720
7bd5c1f4
PE
1721 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1722
63810350
PE
1723 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1724 Convert pctcpu and pctmem to Lisp float properly.
1725 Let the compiler fold better, as 100.0/0x8000 is exact.
1726
a2821611
AS
17272012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1728
1729 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1730 cons_block.
1731
5fceba1d
PE
17322012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1733
1734 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1735
c98ff5dd
DA
17362012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1737
1738 For a 'struct window', replace some Lisp_Object fields to
1739 bitfields where appropriate, remove unused fields.
1740 * window.h (struct window): Remove unused 'last_mark_x' and
1741 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1742 change it's type from Lisp_Object to bitfield.
1743 Change type of 'force_start', 'optional_new_start',
1744 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1745 fields from Lisp_Object to bitfield. Adjust users accordingly.
1746
ca34e0be
PE
17472012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 Pacify gcc -Wdouble-precision when using Xaw.
1750 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1751 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1752 Use 'float' consistently, rather than 'float' in most places
1753 and 'double' in a couple of places.
1754
efc00ab1 17552012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1756
1757 * xdisp.c (handle_stop): Detect whether we have overlay strings
1758 loaded by testing it->current.overlay_string_index to be
1759 non-negative, instead of checking whether n_overlay_strings is
1760 positive. (Bug#11587)
1761
efc00ab1 17622012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1763
1764 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1765
1766 * doc.c (Fsubstitute_command_keys): Doc fix.
1767
efc00ab1 17682012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1769
1770 * search.c (search_buffer): Remove calls to
1771 r_alloc_inhibit_buffer_relocation, as it is now called by
1772 maybe_unify_char, which was the cause of relocation of buffer text
1773 in bug#11519.
1774
efc00ab1 17752012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1776
1777 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1778 for the duration of call to load_charset, to avoid problems with
1779 callers of maybe_unify_char that access buffer text through C
1780 pointers.
1781
1782 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1783 decrement the inhibition flag, instead of just setting or
1784 resetting it.
1785
ba93a187
PE
17862012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 Remove obsolete '#define static' cruft.
1789 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1790 This #undef was "temporary" in 2000; it is no longer needed
1791 now that '#define static' has gone away.
1792 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1793 (gray_bitmap_bits): Remove; no longer needed.
1794 All uses replaced with definiens.
1795 * xterm.c: Include "bitmaps/gray.xbm".
1796
9e4bf381
PE
17972012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 Clean up __executable_start, monstartup when --enable-profiling.
1800 The following changes affect the code only when profiling.
1801 * dispnew.c (__executable_start): Rename from safe_bcopy.
1802 Define only on platforms that need it.
1803 * emacs.c: Include <sys/gmon.h> when profiling.
1804 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1805 (__executable_start): Remove decl, since lisp.h does it now.
1806 (safe_bcopy): Remove decl; no longer has that name.
1807 (main): Coalesce #if into single bit of code, for simplicity.
1808 Cast pointers to uintptr_t, since standard libraries want integers
1809 and not pointers.
1810 * lisp.h (__executable_start): New decl.
1811
32d72c2f
GM
18122012-05-31 Glenn Morris <rgm@gnu.org>
1813
1814 * image.c (Fimagemagick_types): Doc fix.
1815
baac5bc7
JM
18162012-05-30 Jim Meyering <meyering@redhat.com>
1817
1818 * callproc.c (Fcall_process_region): Include directory component
1819 in mkstemp error message (Bug#11586).
1820
72cb32cf
PE
18212012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * alloc.c, lisp.h (make_pure_vector): Now static.
1824
61b108cc
SM
18252012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1826
1827 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1828 Move to byte-run.el.
1829 (Fautoload): Do the hash-doc more carefully.
1830 * data.c (Fdefalias): Purify definition, except for keymaps.
1831 (Qdefun): Move from eval.c.
1832 * lisp.h (Qdefun): Remove.
1833 * lread.c (read1): Tiny simplification.
1834
471fe23d
TN
18352012-05-29 Troels Nielsen <bn.troels@gmail.com>
1836
934f3f58 1837 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1838 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1839 Bug#9642, but explicitly check that the buffer the overlay would
1840 be moved to is live and rearrange lines to make sure that errors
1841 will not put the overlay in an inconsistent state.
1842 (Fdelete_overlay): Cosmetics.
1843
85d0efd1
EZ
18442012-05-28 Eli Zaretskii <eliz@gnu.org>
1845
1846 * w32term.c (my_bring_window_to_top): New function.
1847 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1848 could be different from the original one.
1849 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1850 (Bug#11513)
1851
1852 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1853 by calling BringWindowToTop.
1854
1855 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1856 (WM_EMACS_END): Increase by one.
1857
da92a98c
PE
18582012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1861 This avoids undefined behavior that might cause the eassert
1862 to not catch an out-of-range value.
1863
74d1f848
JB
18642012-05-28 Juanma Barranquero <lekktu@gmail.com>
1865
1866 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1867 Update dependencies.
1868
9e1a06fc
EZ
18692012-05-27 Eli Zaretskii <eliz@gnu.org>
1870
1871 * bidi.c (bidi_mirror_char): Fix last change.
1872
f3dd7312
AS
18732012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1874
1875 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1876 when referring to sectname field in printf format.
1877
81899c91
PE
18782012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1879
57b81a9f
PE
1880 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1881 Only r_alloc_inhibit_buffer_relocation needed to be added;
1882 the others were already declared.
1883
81899c91
PE
1884 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1885 before checking whether it's out of range. Put the check inside
1886 eassert. See
1887 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1888
33017faf 18892012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1890
1891 * callproc.c (Fcall_process): Restore a line that was accidentally
1892 commented out in the 2011-02-13 change (bug#11547).
1893
33017faf 18942012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1895
1896 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1897 defined on ralloc.c.
1898
1899 * buffer.c [REL_ALLOC]: Remove prototypes of
1900 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1901 they are now on lisp.h.
1902
1903 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1904
1905 * search.c (search_buffer): Use it to inhibit relocation of buffer
1906 text while re_search_2 is doing its job, because re_search_2 is
1907 passed C pointers to buffer text. (Bug#11519)
1908
23415acf
EZ
1909 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1910 Update value to 24.
1911
44e27368
EZ
1912 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1913 state after an additional call to move_it_in_display_line_to, keep
1914 the values of it->max_ascent and it->max_descent found for the
1915 entire line.
1916 (pos_visible_p): Revert the comparison against bottom_y to what it
1917 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1918 (Bug#11464)
1919
c1892f11
PE
19202012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 Fix coding-related core dumps with gcc -ftrapv.
1923 The code was computing A - B, where A and B are pointers, and B is
1924 random garbage. This can lead to core dumps on platforms that
1925 have special pointer registers, and it also leads to core dumps on
1926 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1927 A - B only when B is initialized properly.
1928 * coding.c (coding_set_source, coding_set_destination): Return void.
1929 (coding_change_source, coding_change_destinations): New functions,
1930 with the old behaviors of coding_set_source and coding_set_destination.
1931 All callers that need an offset changed to use these new functions.
1932
eb7afdad
GM
19332012-05-26 Glenn Morris <rgm@gnu.org>
1934
1935 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1936
f12fdf02
EZ
19372012-05-26 Eli Zaretskii <eliz@gnu.org>
1938
53a63be6 1939 Extend mouse support on W32 text-mode console.
61b108cc
SM
1940 * xdisp.c (draw_row_with_mouse_face):
1941 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1942
eb3f6f01 1943 * w32console.c: Include window.h.
61b108cc
SM
1944 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1945 New functions.
eb3f6f01
EZ
1946 (initialize_w32_display): Initialize mouse-highlight data.
1947
53a63be6
EZ
1948 * w32inevt.c: Include termchar.h and window.h.
1949 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1950 moves, call note_mouse_highlight. If help_echo changed, call
1951 gen_help_event to produce help-echo message in the echo area.
1952 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1953 highlight info.
1954
4cfd81f6
PE
19552012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 * lread.c (read1): Simplify slightly to avoid an overflow warning
1958 with GCC 4.7.0 on x86-64.
1959
4446092a
EZ
19602012-05-26 Eli Zaretskii <eliz@gnu.org>
1961
1962 * bidi.c (bidi_mirror_char): Revert last change: an int is
1963 definitely wide enough here.
1964
42b2a986 19652012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1966
42b2a986 1967 Fix integer width and related bugs (Bug#9874).
eb106a49 1968 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1969 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1970 (string_bytes, check_sblock, allocate_string_data):
1971 (compact_small_strings, Fmake_bool_vector, make_string)
1972 (make_unibyte_string, make_multibyte_string)
1973 (make_string_from_bytes, make_specified_string)
1974 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1975 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1976 (mark_vectorlike):
1977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1978 (allocate_pseudovector):
1979 Use int, not EMACS_INT, where int is wide enough.
1980 (inhibit_garbage_collection, Fgarbage_collect):
1981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1982 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1983 int might not be wide enough.
1984 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1985 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1986 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1987 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1988 (bidi_level_of_next_char, bidi_move_to_visually_next):
1989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1990 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1991 (Fkill_buffer, Fset_buffer_major_mode)
1992 (advance_to_char_boundary, Fbuffer_swap_text)
1993 (Fset_buffer_multibyte, overlays_at, overlays_in)
1994 (overlay_touches_p, struct sortvec, record_overlay_string)
1995 (overlay_strings, recenter_overlay_lists)
1996 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1997 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1998 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1999 (Foverlay_recenter, last_overlay_modification_hooks_used)
2000 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2002 (validate_region): Omit unnecessary test for b <= e,
2003 since that's guaranteed by the previous test.
d311d28c
PE
2004 (adjust_overlays_for_delete): Avoid pos + length overflow.
2005 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2006 (report_overlay_modification):
2007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2008 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2009 Omit pointer cast, which isn't needed anyway, and doesn't work
2010 after the EMACS_INT -> ptrdiff_t change.
02481186 2011 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2012 * buffer.h: Adjust decls to match defn changes elsewhere.
2013 (struct buffer_text, struct buffer):
2014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2015 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2016 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2017 not int, to avoid needless 32-bit limit on 64-bit hosts.
2018 (exec_byte_code): Use tighter memory-full test, one that checks
2019 for alloca overflow. Don't compute the address of the object just
2020 before an array, as that's not portable. Use EMACS_INT, not
2021 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2022 * callint.c (Fcall_interactively):
2023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2024 * callproc.c (call_process_kill, Fcall_process):
2025 Don't assume pid_t fits into an Emacs fixnum.
2026 (call_process_cleanup, Fcall_process, child_setup):
2027 Don't assume pid_t fits into int.
2028 (call_process_cleanup, Fcall_process, delete_temp_file)
2029 (Fcall_process_region):
2030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2031 (Fcall_process): Simplify handling of volatile integers.
2032 Use int, not EMACS_INT, where int will do.
2033 * casefiddle.c (casify_object, casify_region, operate_on_word)
2034 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2036 (casify_object): Avoid integer overflow when overallocating buffer.
2037 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2038 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2039 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2040 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2041 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2042 integers are now checked earlier. All uses replaced with XINT.
2043 (ccl_driver):
2044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2045 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2046 (ccl_driver, Fregister_code_conversion_map):
2047 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2048 (resolve_symbol_ccl_program): Check that vector header is in range.
2049 Always copy the vector, so that we can check its contents reliably
2050 now rather than having to recheck each instruction as it's being
2051 executed. Check that vector words fit in 'int'.
2052 (ccl_get_compiled_code, Fregister_ccl_program)
2053 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2054 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2055 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2056 contents are in range.
2057 (Fccl_execute_on_string): Check that status is in range.
2058 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2059 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2060 Accept and return EMACS_INT, not int, because callers can pass values
2061 out of 'int' range.
2062 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2063 (multibyte_chars_in_text, parse_str_as_multibyte)
2064 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2065 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2066 (string_escape_byte8, Fget_byte):
2067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2068 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2069 avoid mishandling large integers.
2070 * character.h: Adjust decls to match defn changes elsewhere.
2071 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2072 (Ffind_charset_region):
2073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2074 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2075 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2076 Don't assume fixnum fits in int.
d311d28c
PE
2077 (load_charset_map_from_vector, Fmap_charset_chars):
2078 Remove now-unnecessary CHECK_NATNUMs.
2079 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2080 Don't rely on undefined behavior with signed left shift overflow.
2081 Don't assume unsigned int fits into fixnum, or that fixnum fits
2082 into unsigned int. Don't require max_code to be a valid fixnum;
2083 that's not true for gb10830 4-byte on a 32-bit host. Allow
2084 invalid_code to be a cons, for the same reason. Require code_offset
2085 to be a character. Avoid int overflow if max_char is close
2086 to INT_MAX.
2087 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2088 this is intended anyway and avoids some undefined behavior.
2089 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2090 INDEX_TO_CODE_POINT, as that's what it expects.
2091 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2092 * charset.h (DECODE_CHAR): Return int, not unsigned;
2093 this is what was intended anyway, and it avoids undefined behavior.
2094 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2095 integer-overflow issues.
2096 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2097 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2098 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2099 * chartab.c (Fmake_char_table, Fset_char_table_range)
2100 (uniprop_get_decoder, uniprop_get_encoder):
2101 Don't assume fixnum fits in int.
2102 * cmds.c (move_point): New function, that does the gist of
2103 Fforward_char and Fbackward_char, but does so while checking
2104 for integer overflow more accurately.
c96e5d6a 2105 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2106 (Fforward_line, Fend_of_line, internal_self_insert)
2107 (internal_self_insert):
2108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2109 Fix a FIXME, by checking for integer overflow when calculating
2110 target_clm and actual_clm.
2111 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2112 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2113 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2114 (coding_alloc_by_making_gap, alloc_destination)
2115 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2116 (encode_coding_utf_16, detect_coding_emacs_mule)
2117 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2118 (detect_coding_iso_2022, decode_coding_iso_2022)
2119 (encode_invocation_designation, encode_designation_at_bol)
2120 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2121 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2122 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2123 (encode_coding_ccl, encode_coding_raw_text)
2124 (detect_coding_charset, decode_coding_charset)
2125 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2126 (produce_composition, produce_charset, produce_annotation)
2127 (decode_coding, handle_composition_annotation)
2128 (handle_charset_annotation, consume_chars, decode_coding_gap)
2129 (decode_coding_object, encode_coding_object, detect_coding_system)
2130 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2131 (code_convert_region, code_convert_string)
8f50130c
PE
2132 (Fdefine_coding_system_internal)
2133 (coding_set_source, coding_set_destination):
d311d28c
PE
2134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2135 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2136 (Fdefine_coding_system_internal):
2137 Don't assume fixnums fit in int.
2138 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2139 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2140 (Funencodable_char_position, Fcheck_coding_systems_region)
2141 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2143 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2144 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2145 Don't access memory outside of the args array.
d311d28c 2146 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2147 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2148 result of ENCODE_CHAR.
d311d28c
PE
2149 * coding.h: Adjust decls to match defn changes elsewhere.
2150 (struct coding_system):
2151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2152 * composite.c (get_composition_id, find_composition)
2153 (run_composition_function, update_compositions)
2154 (compose_text, composition_gstring_put_cache)
2155 (composition_gstring_p, composition_gstring_width)
2156 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2157 (composition_compute_stop_pos, composition_reseat_it)
2158 (composition_update_it, struct position_record)
2159 (find_automatic_composition, composition_adjust_point)
2160 (Fcomposition_get_gstring, Ffind_composition_internal):
2161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2162 (update_compositions):
2163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2164 * composite.h: Adjust decls to match defn changes elsewhere.
2165 (struct composition):
2166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2167 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2168 Do not attempt to compute the address of the object just before a
2169 buffer; this is not portable.
2170 (Faref, Faset):
2171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2172 (Faset): Use int, not EMACS_INT, where int is wide enough.
2173 (Fstring_to_number): Don't assume fixnums fit in int.
2174 (Frem): Don't assume arg is nonnegative.
2175 * dbusbind.c (xd_append_arg): Check for integers out of range.
2176 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2177 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2178 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2179 (xd_get_connection_references): Return ptrdiff_t, not int.
2180 All uses changed.
2181 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2182 (xd_read_message_1):
2183 Use int, not unsigned, where the dbus API uses int.
2184 (Fdbus_message_internal): Don't overflow mtype.
2185 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2186 * dired.c (directory_files_internal, file_name_completion, scmp)
2187 (file_name_completion_stat):
2188 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2189 (file_name_completion): Don't overflow matchcount.
2190 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2191 * dispextern.h: Adjust decls to match defn changes elsewhere.
2192 (struct text_pos, struct glyph, struct bidi_saved_info)
2193 (struct bidi_string_data, struct bidi_it, struct composition_it)
2194 (struct it):
2195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2196 (struct display_pos, struct composition_it, struct it):
2197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2198 * dispnew.c (increment_matrix_positions)
2199 (increment_row_positions, mode_line_string)
2200 (marginal_area_string):
2201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2202 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2204 (duration_to_sec_usec): New function, to check for overflow better.
2205 (Fsleep_for, sit_for): Use it.
2206 * doc.c (get_doc_string, store_function_docstring):
2207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2208 (get_doc_string, Fsnarf_documentation):
2209 Use int, not EMACS_INT, where int is wide enough.
2210 (get_doc_string):
2211 Use SAFE_ALLOCA, not alloca.
2212 Check for overflow when converting EMACS_INT to off_t.
2213 * doprnt.c (doprnt):
2214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2215 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2216 Don't assume uid_t fits into fixnum.
2217 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2218 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2219 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2220 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2221 (general_insert_function)
2222 (Finsert_char, make_buffer_string, make_buffer_string_both)
2223 (update_buffer_properties, Fbuffer_substring)
2224 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2225 (Fsubst_char_in_region, check_translation)
2226 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2227 (transpose_markers, Ftranspose_regions):
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 (clip_to_bounds): Move to lisp.h as an inline function).
2230 (Fconstrain_to_field): Don't assume integers are nonnegative.
2231 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2232 (Fsubst_char_in_region, Fsave_restriction):
2233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2234 (Femacs_pid): Don't assume pid_t fits into fixnum.
2235 (lo_time): Use int, not EMACS_INT, when int suffices.
2236 (lisp_time_argument): Check for usec out of range.
2237 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2238 (Fuser_login_name, Fuser_full_name): Signal an error
2239 if a uid argument is out of range, rather than relying on
2240 undefined behavior.
c8d5c857
PE
2241 (Fformat_time_string): Remove now-unnecessary check.
2242 lisp_time_argument checks for out-of-range usec now.
243e0530 2243 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2244 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2245 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2246 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2247 (init_cmdargs, Fdump_emacs):
2248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2249 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2250 the bottom (typically) 32 bits of the fixnum.
2251 * eval.c (specpdl_size, call_debugger):
2252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2253 (when_entered_debugger, Fbacktrace_debug):
2254 Don't assume fixnum can fit in int.
2255 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2256 the object just before a buffer; this is not portable.
2257 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2258 (grow_specpdl, unbind_to):
2259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2260 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2261 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2262 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2263 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2264 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2266 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2267 (a_write, e_write):
2268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2269 (Fcopy_file, non_regular_nbytes, read_non_regular)
2270 (Finsert_file_contents):
2271 Use int, not EMACS_INT, where int is wide enough.
2272 (READ_BUF_SIZE): Verify that it fits in int.
2273 (Finsert_file_contents): Check that counts are in proper range,
2274 rather than assuming fixnums fit into ptrdiff_t etc.
2275 Don't assume fixnums fit into int.
125b3835 2276 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2277 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2278 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2279 (string_char_to_byte, string_byte_to_char)
2280 (string_make_multibyte, string_to_multibyte)
2281 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2282 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2283 (substring_both, Fdelete, internal_equal, Ffillarray)
2284 (Fclear_string, mapcar1)
2285 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2286 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2287 (larger_vector, make_hash_table, maybe_resize_hash_table)
2288 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2289 (Fmaphash, secure_hash):
2290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2291 (concat): Check for string index and length overflow.
2292 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2293 (Frequire):
2294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2295 (larger_vector): New API (vec, incr_min, size_max) replaces old
2296 one (vec, new_size, init). This catches size overflow.
2297 INIT was removed because it was always Qnil.
2298 All callers changed.
2299 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2300 the upper bound on a hash table index size.
2301 (make_hash_table, maybe_resize_hash_table): Use it.
2302 (secure_hash): Computer start_byte and end_byte only after
2303 they're known to be in ptrdiff_t range.
2304 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2305 (Ffont_get_glyphs, Ffont_at):
2306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2307 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2308 (Flist_fonts, Fopen_font):
2309 Don't assume fixnum can fit in int.
2310 (check_gstring): Don't assume index can fit in int.
2311 (font_match_p): Check that fixnum is a character, not a nonnegative
2312 fixnum, since the later code needs to stuff it into an int.
2313 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2314 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2315 conversion overflow issues.
2316 (Fopen_font): Check for integer out of range.
2317 (Ffont_get_glyphs): Don't assume index can fit in int.
2318 * font.h: Adjust decls to match defn changes elsewhere.
2319 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2320 integer overflow.
2321 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2322 printmax_t, where ptrdiff_t is wide enough.
2323 (Finternal_char_font):
2324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2325 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2326 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2327 (Fset_frame_position, x_set_frame_parameters)
2328 (x_set_line_spacing, x_set_border_width)
2329 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2330 Check that fixnums are in proper range for system types.
2331 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2333 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2334 Use SAFE_ALLOCA_LISP, not alloca.
2335 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2336 intptr_t is wide enough.
2337 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2338 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2339 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2340 Check for fixnum out of range.
2341 * ftfont.c (ftfont_list): Don't assume index fits in int.
2342 Check that fixnums are in proper range for system types.
2343 (ftfont_shape_by_flt):
2344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2345 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2347 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2348 Check that fixnums are in proper range for system types.
2349 * gnutls.h: Adjust decls to match defn changes elsewhere.
2350 * gtkutil.c (xg_dialog_run):
2351 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2352 (update_frame_tool_bar):
2353 Check that fixnums are in proper range for system types.
2354 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2355 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2356 * indent.c (last_known_column, last_known_column_point):
2357 (current_column_bol_cache):
2358 (skip_invisible, current_column, check_display_width):
2359 (check_display_width, scan_for_column, current_column_1)
2360 (Findent_to, Fcurrent_indentation, position_indentation)
2361 (indented_beyond_p, Fmove_to_column, compute_motion):
2362 (Fcompute_motion, Fvertical_motion):
2363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2364 (last_known_column_modified): Use EMACS_INT, not int.
2365 (check_display_width):
2366 (Fcompute_motion):
2367 Check that fixnums and floats are in proper range for system types.
2368 (compute_motion): Don't assume index or fixnum fits in int.
2369 (compute_motion, Fcompute_motion):
2370 Use int, not EMACS_INT, when it is wide enough.
2371 (vmotion): Omit local var start_hpos that is always 0; that way
2372 we don't need to worry about overflow in expressions involving it.
2373 * indent.h: Adjust decls to match defn changes elsewhere.
2374 (struct position):
2375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2376 Use int, not EMACS_INT, where int is wide enough.
2377 Remove unused members ovstring_chars_done and tab_offset;
2378 all uses removed.
2379 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2380 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2381 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2382 (make_gap, copy_text, insert, insert_and_inherit)
2383 (insert_before_markers, insert_before_markers_and_inherit)
2384 (insert_1, count_combining_before, count_combining_after)
2385 (insert_1_both, insert_from_string)
2386 (insert_from_string_before_markers, insert_from_string_1)
2387 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2388 (adjust_after_replace, adjust_after_insert, replace_range)
2389 (replace_range_2, del_range, del_range_1, del_range_byte)
2390 (del_range_both, del_range_2, modify_region)
2391 (prepare_to_modify_buffer, signal_before_change)
2392 (signal_after_change, Fcombine_after_change_execute):
2393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2394 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2395 (balance_an_interval, split_interval_right, split_interval_left)
2396 (find_interval, next_interval, update_interval)
2397 (adjust_intervals_for_insertion, delete_node, delete_interval)
2398 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2399 (static_offset_intervals, offset_intervals)
2400 (merge_interval_right, merge_interval_left, make_new_interval)
2401 (graft_intervals_into_buffer, temp_set_point_both)
2402 (temp_set_point, set_point, adjust_for_invis_intang)
2403 (set_point_both, move_if_not_intangible, get_property_and_range)
2404 (get_local_map, copy_intervals, copy_intervals_to_string)
2405 (compare_string_intervals, set_intervals_multibyte_1):
2406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2407 * intervals.h: Adjust decls to match defn changes elsewhere.
2408 (struct interval):
2409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2410 * keyboard.c (this_command_key_count, this_single_command_key_start)
2411 (before_command_key_count, before_command_echo_length, echo_now)
2412 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2413 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2414 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2415 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2417 (last_non_minibuf_size, last_point_position, echo_truncate)
2418 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2419 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2420 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2421 (stuff_buffered_input):
2422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2423 (last_auto_save, command_loop_1, read_char):
2424 Use EMACS_INT, not int, to avoid integer overflow.
2425 (record_char): Avoid overflow in total_keys computation.
2426 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2427 * keyboard.h: Adjust decls to match defn changes elsewhere.
2428 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2429 (Fkey_description, Fdescribe_vector, Flookup_key):
2430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2431 (click_position): New function, to check that positions are in range.
2432 (Fcurrent_active_maps):
2433 (describe_command):
2434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2435 (Faccessible_keymaps, Fkey_description):
2436 (preferred_sequence_p):
2437 Don't assume fixnum can fit into int.
2438 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2439 Check for integer overflow in size calculations.
2440 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2441 avoid mishandling large integers.
2442 * lisp.h: Adjust decls to match defn changes elsewhere.
2443 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2444 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2445 (struct Lisp_Marker):
2446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2447 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2448 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2449 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2450 All callers changed.
2451 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2452 Assume the arg has valid form, since it always does.
2453 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2454 unsigned integer system type.
2455 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2456 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2458 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2459 (duration_to_sec_usec): New decl.
2460 * lread.c (read_from_string_index, read_from_string_index_byte)
2461 (read_from_string_limit, readchar, unreadchar, openp)
2462 (read_internal_start, read1, oblookup):
2463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2464 (Fload, readevalloop, Feval_buffer, Feval_region):
2465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2466 (openp): Check for out-of-range argument to 'access'.
2467 (read1): Use int, not EMACS_INT, where int is wide enough.
2468 Don't assume fixnum fits into int.
6efdadfd 2469 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2470 (read_filtered_event): Use duration_to_sec_usec
2471 to do proper overflow checking on durations.
d311d28c
PE
2472 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2473 in size calculation.
2474 (Fexecute_kbd_macro):
2475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2476 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2477 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2478 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2479 (set_marker_both, set_marker_restricted_both, marker_position)
2480 (marker_byte_position, Fbuffer_has_markers_at):
2481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2482 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2483 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2484 It now merely ensures that the menu is large enough, without
2485 necessarily growing it, as this avoids some integer overflow issues.
2486 All callers changed.
2487 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2489 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2490 Use SAFE_ALLOCA_LISP, not alloca.
2491 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2492 to EMACS_INT. Check that fixnums are in proper range for system types.
2493 * minibuf.c (minibuf_prompt_width, string_to_object)
2494 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2495 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2497 (get_minibuffer, read_minibuf_unwind):
2498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2499 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2500 this simplifies overflow checking. All callers changed.
2501 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2502 (Ftest_completion):
2503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2504 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2505 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2506 Check that fixnums are in proper range for system types.
2507 (Fx_create_frame, Fx_show_tip):
2508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2509 * nsfont.m (ns_findfonts, nsfont_list_family):
2510 Don't assume fixnum fits in long.
2511 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2513 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2514 wide enough.
17fdb222 2515 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2517 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2518 (PRINTDECLARE, PRINTPREPARE):
2519 (strout, print_string):
2520 (print, print_preprocess, print_check_string_charset_prop)
2521 (print_object):
2522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2523 (PRINTDECLARE):
2524 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2526 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2527 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2528 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2529 (print_error_message): Use SAFE_ALLOCA, not alloca.
2530 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2531 (print_depth, new_backquote_output, print_number_index):
2532 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2533 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2534 (Fset_process_window_size, Fformat_network_address)
2535 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2536 (sigchld_handler):
d311d28c 2537 Check that fixnums are in proper range for system types.
d44287d4 2538 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2539 Check for process-ids out of pid_t range rather than relying on
2540 undefined behavior.
e4d81efc 2541 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2542 (Fformat_network_address, read_process_output, send_process)
2543 (Fprocess_send_region, status_notify):
2544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2545 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2546 (wait_reading_process_output, read_process_output, exec_sentinel):
2547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2548 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2549 (Faccept_process_output): Use duration_to_sec_usec to do proper
2550 overflow checking on durations.
dde14581
PE
2551 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2552 Don't assume pid_t fits in int.
02481186
PE
2553 * process.h (struct Lisp_Process): Members tick and update_tick
2554 are now of type EMACS_INT, not int.
b62b53e8
PE
2555 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2556 configured --with-wide-int.
d311d28c
PE
2557 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2558 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2559 * search.c (looking_at_1, string_match_1):
2560 (fast_string_match, fast_c_string_match_ignore_case)
2561 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2562 (scan_newline, find_before_next_newline, search_command)
2563 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2564 (set_search_regs, wordify):
2565 (Freplace_match):
2566 (Fmatch_data):
2567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2568 (string_match_1, search_buffer, set_search_regs):
2569 (Fmatch_data):
2570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2571 (wordify): Check for overflow in size calculation.
2572 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2573 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2574 Check that fixnums are in proper range for system types.
2575 * sound.c (struct sound_device)
2576 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2578 (Fplay_sound_internal):
2579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2580 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2581 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2582 (Fparse_partial_sexp):
2583 Don't assume fixnums can fit in int.
2584 (struct lisp_parse_state, find_start_pos, find_start_value)
2585 (find_start_value_byte, find_start_begv)
2586 (update_syntax_table, char_quoted, dec_bytepos)
2587 (find_defun_start, prev_char_comend_first, back_comment):
2588 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2589 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2591 (Finternal_describe_syntax_value): Check that match_lisp is a
2592 character, not an integer, since the code stuffs it into int.
2593 (scan_words, scan_sexps_forward):
2594 Check that fixnums are in proper range for system types.
2595 (Fforward_word):
2596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2597 (scan_sexps_forward):
2598 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2599 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2600 * syntax.h: Adjust decls to match defn changes elsewhere.
2601 (struct gl_state_s):
2602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2603 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2604 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2605 * sysdep.c (wait_for_termination_1, wait_for_termination)
2606 (interruptible_wait_for_termination, mkdir):
2607 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2608 (emacs_read, emacs_write):
2609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2610 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2611 and double all fit in int.
d311d28c
PE
2612 * term.c (set_tty_color_mode):
2613 Check that fixnums are in proper range for system types.
2614 * termhooks.h (struct input_event):
2615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2616 * textprop.c (validate_interval_range, interval_of)
2617 (Fadd_text_properties, set_text_properties_1)
2618 (Fremove_text_properties, Fremove_list_of_text_properties)
2619 (Ftext_property_any, Ftext_property_not_all)
2620 (copy_text_properties, text_property_list, extend_property_ranges)
2621 (verify_interval_modification):
2622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2623 (Fnext_single_char_property_change)
2624 (Fprevious_single_char_property_change):
2625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2626 (copy_text_properties):
2627 Check for integer overflow in index calculation.
d311d28c
PE
2628 * undo.c (last_boundary_position, record_point, record_insert)
2629 (record_delete, record_marker_adjustment, record_change)
2630 (record_property_change):
2631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2632 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2634 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2635 (Fx_hide_tip, Fx_file_dialog):
2636 * w32menu.c (set_frame_menubar):
2637 Use ptrdiff_t, not int, for consistency with rest of code.
2638 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2639 (select_window, Fdelete_other_windows_internal)
2640 (window_scroll_pixel_based, window_scroll_line_based)
2641 (Frecenter, Fset_window_configuration):
2642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2643 (Fset_window_hscroll, run_window_configuration_change_hook)
2644 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2645 (Fscroll_other_window, Frecenter):
d311d28c
PE
2646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2647 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2648 Don't assume fixnum fits in int.
2649 (Fset_window_scroll_bars):
2650 Check that fixnums are in proper range for system types.
2651 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2652 (string_pos, c_string_pos, number_of_chars, init_iterator)
2653 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2654 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2655 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2656 (face_before_or_after_it_pos, handle_invisible_prop)
2657 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2658 (display_prop_intangible_p, string_buffer_position_lim)
2659 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2660 (get_overlay_strings_1, get_overlay_strings)
2661 (iterate_out_of_display_property, forward_to_next_line_start)
2662 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2663 (get_next_display_element, set_iterator_to_next)
2664 (get_visually_first_element, compute_stop_pos_backwards)
2665 (handle_stop_backwards, next_element_from_buffer)
2666 (move_it_in_display_line_to, move_it_in_display_line)
2667 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2668 (add_to_log, message_dolog, message_log_check_duplicate)
2669 (message2, message2_nolog, message3, message3_nolog
2670 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2671 (current_message_1, truncate_echo_area, truncate_message_1)
2672 (set_message, set_message_1, store_mode_line_noprop)
2673 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2674 (text_outside_line_unchanged_p, check_point_in_composition)
2675 (reconsider_clip_changes)
2676 (redisplay_internal, set_cursor_from_row, try_scrolling)
2677 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2678 (redisplay_window, find_last_unchanged_at_beg_row)
2679 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2680 (trailing_whitespace_p, find_row_edges, display_line)
2681 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2682 (display_mode_element, store_mode_line_string)
2683 (pint2str, pint2hrstr, decode_mode_spec)
2684 (display_count_lines, display_string, draw_glyphs)
2685 (x_produce_glyphs, x_insert_glyphs)
2686 (rows_from_pos_range, mouse_face_from_buffer_pos)
2687 (fast_find_string_pos, mouse_face_from_string_pos)
2688 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2690 (safe_call, init_from_display_pos, handle_fontified_prop)
2691 (handle_single_display_spec, load_overlay_strings)
2692 (with_echo_area_buffer, setup_echo_area_for_printing)
2693 (display_echo_area, echo_area_display)
2694 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2695 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2696 (redisplay_window, dump_glyph_row, display_mode_line)
2697 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2698 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2700 (handle_single_display_spec, build_desired_tool_bar_string)
2701 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2702 (get_specified_cursor_type):
2703 Check that fixnums are in proper range for system types.
2704 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2705 (Flookup_image_map):
2706 Don't assume fixnums fit in int.
2707 (compare_overlay_entries):
2708 Avoid mishandling comparisons due to subtraction overflow.
2709 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2710 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2711 (handle_tool_bar_click):
2712 Use int, not unsigned, since we prefer signed and the signedness
2713 doesn't matter here.
2714 (get_next_display_element, next_element_from_display_vector):
2715 Use int, not EMACS_INT, when int is wide enough.
2716 (start_hourglass): Use duration_to_sec_usec to do proper
2717 overflow checking on durations.
2718 * xfaces.c (Fbitmap_spec_p):
2719 Check that fixnums are in proper range for system types.
2720 (compare_fonts_by_sort_order):
2721 Avoid mishandling comparisons due to subtraction overflow.
2722 (Fx_family_fonts, realize_basic_faces):
2723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2724 (Fx_family_fonts):
2725 Don't assume fixnum fits in int.
2726 Use SAFE_ALLOCA_LISP, not alloca.
2727 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2728 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2729 (face_at_buffer_position, face_for_overlay_string)
2730 (face_at_string_position):
2731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2732 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2733 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2734 (Fx_show_tip):
2735 Check that fixnums are in proper range for system types.
2736 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2737 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2739 (Fx_change_window_property): Don't assume fixnums fit in int.
2740 * xfont.c (xfont_chars_supported):
2741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2742 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2743 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2745 * xml.c (parse_region):
2746 * xrdb.c (magic_file_p):
2747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2748 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2749 (x_get_local_selection, x_reply_selection_request)
2750 (x_handle_selection_request, wait_for_property_change):
2751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2752 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2753 short is wide enough.
2754 (x_send_client_event): Don't assume fixnum fits in int.
2755 * xterm.c (x_x_to_emacs_modifiers):
2756 Don't assume EMACS_INT overflows nicely into int.
2757 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2758 may come from Lisp.
2759 (handle_one_xevent): NATNUMP can eval its arg twice.
2760 (x_connection_closed):
2761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2762 * xterm.h: Adjust decls to match defn changes elsewhere.
2763 (struct scroll_bar): Use struct vectorlike_header
2764 rather than rolling our own approximation.
2765 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2766
c6574eb5
GM
27672012-05-25 Glenn Morris <rgm@gnu.org>
2768
2769 * lisp.mk (lisp): Update for more files being compiled now.
2770
e8d32c7e
SM
27712012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2772
48def666
SM
2773 * lread.c: Remove `read_pure' which makes no difference.
2774 (read_pure): Remove var.
2775 (unreadpure): Remove function.
2776 (readevalloop): Don't call read_list with -1 flag.
2777 (read1, read_vector): Don't test read_pure any more.
2778 (read_list): Simplify.
2779
e8d32c7e
SM
2780 * fileio.c, character.h: Minor style tweaks.
2781
4b2addb7
DA
27822012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2783
2784 * window.h (clip_changed): Remove useless declaration.
2785
584461b2
JB
27862012-05-22 Juanma Barranquero <lekktu@gmail.com>
2787
2788 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2789 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2790
34374650
PE
27912012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 Remove src/m/*.
2794 This directory predates autoconf and is no longer needed nowadays.
2795 Move its few remaining bits of functionality to where they're needed.
2796 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2797 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2798 * m/template.h: Remove.
2799 * Makefile.in (M_FILE): Remove. All uses removed.
2800 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2801 * lisp.h (USE_LSB_TAG):
2802 * mem-limits.h (EXCEEDS_LISP_PTR):
2803 Use VAL_MAX, not VALBITS, in #if.
2804 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2805 (EMACS_UINT): Define unconditionally now.
2806 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2807 (BITS_PER_EMACS_INT): New constants, replacing
2808 what used to be in config.h, but not useful in #if.
2809 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2810 define them any more.
2811 (VAL_MAX): New macro.
2812 (VALMASK): Use it.
2813 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2814 BITS_PER_EMACS_INT, in #if.
2815 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2816 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2817 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2818 * s/ms-w32.h (DATA_START):
2819 Move here from removed file m/intel386.h.
2820 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2821 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2822
261cb4bb
PE
28232012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2824
2825 Assume C89 or later.
2826 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2827 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2828 (xrealloc):
2829 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2830 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2831 * textprop.c, tparam.c (NULL): Remove.
2832 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2833 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2834 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2835 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2836 * xterm.c (input_signal_count): Assume volatile works.
2837
ff23cd9f
KB
28382012-05-21 Ken Brown <kbrown@cornell.edu>
2839
2840 * xgselect.c (xg_select): Fix first argument in call to 'select'
2841 (bug#11508).
2842
1b170bc6
KB
28432012-05-20 Ken Brown <kbrown@cornell.edu>
2844
2845 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2846 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2847
b2f4d39f
KB
28482012-05-19 Ken Brown <kbrown@cornell.edu>
2849
2850 * xfns.c (x_in_use): Remove `static' qualifier.
2851 * xterm.h (x_in_use): Declare.
2852 * xgselect.c: Include xterm.h.
2853 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2854 and `display_arg' (bug#9754).
2855
003fdae2
PE
28562012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2857
9232a6d9
PE
2858 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2859
003fdae2
PE
2860 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2861 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2862
784b56e2
EZ
28632012-05-18 Eli Zaretskii <eliz@gnu.org>
2864
2865 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2866
2867 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 2868 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
2869
2870 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2871 reference to image_cache->refcount.
2872 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2873
a0a79cde
JL
28742012-05-17 Juri Linkov <juri@jurta.org>
2875
2876 * search.c (Fword_search_regexp, Fword_search_backward)
2877 (Fword_search_forward, Fword_search_backward_lax)
2878 (Fword_search_forward_lax): Move functions to isearch.el
2879 (bug#10145, bug#11381).
2880
b0572523
PE
28812012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2884
9660f5fc
SM
28852012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2886
2887 * lread.c (init_obarray): Declare Qt and Qnil as special.
2888
4374de83
GM
28892012-05-14 Glenn Morris <rgm@gnu.org>
2890
2891 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2892 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2893
dc44c39a
PE
28942012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2895
078c97cb
PE
2896 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2897
dc44c39a
PE
2898 * unexaix.c: Port to more-recent AIX compilers.
2899 (report_error, report_error_1, make_hdr, copy_sym)
2900 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2901 Make arguments const char *, not char *, to avoid violations of C
2902 standard and to fix some AIX warnings reported by Gilles Pion.
2903
e18afed7 29042012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2905
2906 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2907 already have overlays loaded.
2908 (handle_single_display_spec): Before returning without displaying
2909 fringe bitmap, synchronize the bidi iterator with the main display
2910 iterator, by calling iterate_out_of_display_property.
2911 (iterate_out_of_display_property): Detect buffer iteration by
2912 testing that it->string is a Lisp string.
2913 (get_next_display_element): When the current object is exhausted,
2914 and there's something on it->stack, call set_iterator_to_next to
2915 proceed with what's on the stack, instead of returning zero.
2916 (set_iterator_to_next): If called at the end of a Lisp string,
2917 proceed to consider_string_end without incrementing string
2918 position. Don't increment display vector index past the end of
2919 the display vector. (Bug#11417)
c8fb9dc6
EZ
2920 (pos_visible_p): Don't report a position visible when move_it_to
2921 stopped at the last line of window, which happens to be scanned
2922 backwards by the bidi iteration. (Bug#11464)
ac268e67 2923
e18afed7 29242012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2925
2926 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2927 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2928 are on a TTY, and thus unable to display on the fringes.
2929 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2930 so we need to signal to the caller that this is a "replacing"
2931 display spec. This fixes display when the spec is invalid or we
2932 are on a TTY.
2933
e18afed7 29342012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2935
2936 * unexaix.c (make_hdr): Fix typo in prototype.
2937 This bug broke the build on AIX. Problem reported by Gilles Pion.
2938
9d0a235a
MA
29392012-05-14 Michael Albinus <michael.albinus@gmx.de>
2940
2941 * keyboard.c (kbd_buffer_get_event): Read special events also in
2942 batch mode. (Bug#11415)
2943
9e6b06ed
GM
29442012-05-12 Glenn Morris <rgm@gnu.org>
2945
2946 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2947
c1a1d7a3
EZ
29482012-05-12 Eli Zaretskii <eliz@gnu.org>
2949
2950 * lisp.mk (lisp): Add newcomment.elc.
2951
3fe7cdc8
GM
29522012-05-12 Glenn Morris <rgm@gnu.org>
2953
2954 * Makefile.in (MKDIR_P): New, set by configure.
2955 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2956
53f7d2c0
PE
29572012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2958
2959 Remove unused function hourglass_started.
2960 * dispextern.h (hourglass_started):
2961 * w32fns.c (hourglass_started):
2962 * xdisp.c (hourglass_started): Remove.
2963
75aafb17
JB
29642012-05-10 Juanma Barranquero <lekktu@gmail.com>
2965
2966 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2967 Update dependencies.
2968
12959e8e
PE
29692012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2970
97107e2e
PE
2971 * xgselect.c (xg_select): Put maxfds+1 into a var.
2972 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2973
12959e8e
PE
2974 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2975
836d29b3
DA
29762012-05-10 Dave Abrahams <dave@boostpro.com>
2977
2978 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2979 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2980
5cb67954
MA
29812012-05-09 Michael Albinus <michael.albinus@gmx.de>
2982
2983 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2984 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2985 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2986 Initialize xd_registered_buses.
2987
3478ec45
PE
29882012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2989
b263a6b0
PE
2990 Untag more efficiently if USE_LSB_TAG.
2991 This is based on a proposal by YAMAMOTO Mitsuharu in
2992 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2993 For an admittedly artificial (nth 8000 longlist) benchmark on
2994 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2995 Emacs's overall text size by 1%.
2996 * lisp.h (XUNTAG): New macro.
2997 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2998 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2999 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3000 * eval.c (Fautoload):
3001 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3002 * frame.h (XFRAME): Use XUNTAG.
3003
3478ec45
PE
3004 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3005 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3006 Remove unportable assumptions about print widths of types like
3007 dbus_uint32_t.
3008 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3009 intptr_t when converting between pointer and integer, to avoid GCC
3010 warnings about wrong width.
3011
666b903b 30122012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3013
3014 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3015 stack for each reader_thread, instead of defaulting to 8MB
3016 determined by the linker. This avoids failures in creating
3017 subprocesses on Windows 7, see the discussion in this thread:
3018 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3019
b120cc17
JC
30202012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3021
3022 Fix up display of the *Minibuf-0* buffer in the mini window.
3023 * keyboard.c (read_char): Don't clear the echo area if there's no
3024 message to clear.
3025 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3026 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3027
9a4b36f8
MA
30282012-05-07 Michael Albinus <michael.albinus@gmx.de>
3029
3030 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3031 batch mode.
3032
e5f9458f
CY
30332012-05-06 Chong Yidong <cyd@gnu.org>
3034
3035 * lisp.mk (lisp): Update.
3036
eceeb5fc 30372012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3038
3039 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3040
71873e2b
SM
30412012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3042
3043 * data.c (PUT_ERROR): New macro.
3044 (syms_of_data): Use it. Add new error type `user-error'.
3045 * undo.c (user_error): New function.
3046 (Fprimitive_undo): Use it.
3047 * print.c (print_error_message): Adjust print style for `user-error'.
3048 * keyboard.c (user_error): New function.
3049 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3050
ab0fa4e4
PE
30512012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3052
3053 Do not limit current-time-string to years 1000..9999.
3054 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3055 (Fcurrent_time_string): Support any year that is supported by the
3056 underlying localtime representation. Don't use asctime, as it
3057 has undefined behavior for years outside the range -999..9999.
3058
7ed806a7
PE
30592012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3060
3061 Fix race conditions involving setenv, gmtime, localtime, asctime.
3062 Without this fix, interrupts could mess up code that uses these
3063 nonreentrant functions, since setting TZ invalidates existing
3064 tm_zone or tzname values, and since most of these functions return
3065 pointers to static storage.
3066 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3067 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3068 Grow the critical sections to include not just invoking
3069 localtime/gmtime, but also accessing these functions' results
3070 including their tm_zone values if any, and any related TZ setting.
3071 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3072 so that the struct tm is saved in the critical section.
3073 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3074 motivated by the fact that memory allocation needs to be outside
3075 the critical section.
3076
0c16dfed
DA
30772012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3078
3079 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3080 with RESET_INTERVAL.
3081
3082 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3083 Remove duplicated buffer name initialization.
3084
3f83ace8
JM
30852012-05-02 Jim Meyering <jim@meyering.net>
3086
3087 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3088
c7b8541e
JM
3089 * xfns.c (x_window): Use xstrdup (Bug#11375).
3090
90207a15 30912012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3092
3093 * xdisp.c (pos_visible_p): If already at a newline from the
3094 display string before the 'while' loop, don't walk back the glyphs
3095 from it3.glyph_row. Solves assertion violation when the display
3096 string begins with a newline (egg.el). (Bug#11367)
3097
b593d6a9
AH
30982012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3099
3100 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3101 Move to simple.el.
3102
4737362e
GM
31032012-05-01 Glenn Morris <rgm@gnu.org>
3104
99cf43f9
GM
3105 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3106 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3107 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3108 All were removed before 23.1.
3109
9311dcff
GM
3110 * dispnew.c: Remove HAVE_LIBNCURSES test;
3111 it is always true on relevant platforms.
3112
4d5c6349
GM
3113 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3114 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3115
4737362e
GM
3116 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3117
74dd3a6b
AS
31182012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3119
3120 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3121 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3122 Remove.
3123
13c379ee
PE
31242012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3125
3126 Do not avoid creating empty evaporating overlays (Bug#9642).
3127 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3128 That is, do not delete an evaporating overlay if it becomes
3129 empty after its bounds are adjusted to fit within its buffer.
3130 This fix caused other problems, and I'm reverting it until we get
3131 to the bottom of them.
3132
a8e7d6d7 31332012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3134
3135 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3136
a8e7d6d7 31372012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3138
3139 * xdisp.c (pos_visible_p): If the window start position is beyond
3140 ZV, start the display from buffer beginning. Prevents assertion
3141 violation in init_iterator when the minibuffer window is scrolled
3142 via the scroll bar.
3143
3144 * window.c (window_scroll_pixel_based): Likewise.
3145
a8e7d6d7 31462012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3147
3148 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3149
a8e7d6d7 31502012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3151
3152 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3153 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3154
a8e7d6d7 31552012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3156
b593d6a9
AH
3157 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3158 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3159
1c6900d9
EZ
31602012-04-26 Eli Zaretskii <eliz@gnu.org>
3161
4c3fa1d9
EZ
3162 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3163 display element, check also the underlying string or buffer
3164 character. (Bug#11341)
3165
1c6900d9
EZ
3166 * w32menu.c: Include w32heap.h.
3167 (add_menu_item): If the call to AppendMenuW (via
3168 unicode_append_menu) fails, disable Unicode menus only if we are
3169 running on Windows 9X/Me.
3170
42bf8205
AS
31712012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3172
3173 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3174 (xgetint): Add missing shift for LSB tags.
3175
b1bac16e
MR
31762012-04-24 Martin Rudalics <rudalics@gmx.at>
3177
3178 * keyboard.c (read_char): Don't wipe echo area for select window
3179 events: These might get delayed via `mouse-autoselect-window'
3180 (Bug#11304).
3181
d69621cc
JB
31822012-04-24 Juanma Barranquero <lekktu@gmail.com>
3183
3184 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3185 manipulation of :loaded-from data.
3186
02fd101b
JB
31872012-04-23 Juanma Barranquero <lekktu@gmail.com>
3188
3189 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3190 now a cons (bug#11311).
3191
888bec30
PE
31922012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3193
89a438bd
PE
3194 Do not create empty overlays with the evaporate property (Bug#9642).
3195 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3196 if it becomes empty after its bounds are adjusted to fit within
3197 its buffer. Without this fix, in a nonempty buffer (let ((o
3198 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3199 yields an empty overlay that has the evaporate property, which is
3200 not supposed to happen.
3201
1068fe4d
PE
3202 Fix minor GTK3 problems found by static checking.
3203 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3204 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3205 (struct _EmacsFixedClass, emacs_fixed_get_type):
3206 Move decls here from emacsgtkfixed.h, since they needn't be public.
3207 (emacs_fixed_get_type): Now static.
3208 (emacs_fixed_class_init): Omit unused local.
3209 (emacs_fixed_child_type): Remove; unused.
3210 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3211 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3212 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3213 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3214 (EMACS_FIXED_GET_CLASS): Remove; unused.
3215 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3216
888bec30
PE
3217 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3218 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3219
de85e130
PE
32202012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3221
d0baac98 3222 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3223 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3224 (__malloc_size_t, __malloc_ptrdiff_t):
3225 Remove. All uses removed, replaced by the definiens if needed,
3226 since we can assume C89 or better now.
3227 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3228 (protect_malloc_state, align, get_contiguous_space)
3229 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3230 (malloc_atfork_handler_child, malloc_enable_thread)
3231 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3232 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3233 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3234 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3235 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3236 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3237 Define using prototypes, not old style.
3238 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3239 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3240 (align): Don't assume that signed integer overflow wraps around.
3241 Omit unused local var.
3242 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3243 (_free_internal_nolock, memalign, mallochook, reallochook):
3244 Omit no-longer-needed casts.
3245 (valloc): Use getpagesize, not __getpagesize.
3246 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3247 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3248
de85e130
PE
3249 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3250
dcbf5805
MA
32512012-04-22 Michael Albinus <michael.albinus@gmx.de>
3252
3253 Move functions from C to Lisp. Make non-blocking method calls
3254 the default. Implement further D-Bus standard interfaces.
3255
3256 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3257 (QCdbus_request_name_allow_replacement)
3258 (QCdbus_request_name_replace_existing)
3259 (QCdbus_request_name_do_not_queue)
3260 (QCdbus_request_name_reply_primary_owner)
3261 (QCdbus_request_name_reply_in_queue)
3262 (QCdbus_request_name_reply_exists)
3263 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3264 (QCdbus_registered_serial, QCdbus_registered_method)
3265 (QCdbus_registered_signal): New Lisp objects.
3266 (XD_DEBUG_MESSAGE): Use sizeof.
3267 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3268 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3269 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3270 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3271 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3272 (xd_signature, xd_append_arg): Allow float for integer types.
3273 (xd_get_connection_references): New function.
b593d6a9
AH
3274 (xd_get_connection_address): Rename from xd_initialize.
3275 Return cached address.
dcbf5805
MA
3276 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3277 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3278 level.
3279 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3280 Return number of refcounts.
dcbf5805
MA
3281 (Fdbus_get_unique_name): Make stronger parameter check.
3282 (Fdbus_message_internal): New defun.
3283 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3284 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3285 (Fdbus_send_signal, Fdbus_register_service)
3286 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3287 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3288 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3289 (Vdbus_compiled_version, Vdbus_runtime_version)
3290 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3291 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3292 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3293 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3294 Adapt docstring.
dcbf5805 3295
52828e02
PE
32962012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3297
da05bc4c
PE
3298 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3299 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3300 Do not assume ptrdiff_t is the same width as 'int'.
3301
52828e02
PE
3302 * alloc.c: Handle unusual debugging option combinations.
3303 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3304 since the two debugging options are incompatible.
3305 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3306 is defined.
3307 (mem_init, mem_insert, mem_insert_fixup):
3308 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3309 (NEED_MEM_INSERT): Remove; no longer needed.
3310
f01769f9
LL
33112012-04-22 Leo Liu <sdl.web@gmail.com>
3312
3313 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3314
5790543d
PE
33152012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3316
3317 * sysdep.c [__FreeBSD__]: Minor cleanups.
3318 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3319 Use Emacs indenting style more consistently. Avoid some casts.
3320 Use 'double' consistently rather than mixing 'float' and 'double'.
3321
b91b7e4d
EW
33222012-04-21 Eduard Wiebe <usenet@pusto.de>
3323
b593d6a9
AH
3324 * sysdep.c (list_system_processes, system_process_attributes):
3325 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3326
6114eb15
AS
33272012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3328
3329 * lisp.mk (lisp): Update.
3330
2f38dff7
PE
33312012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3332
3333 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3334 It is never used otherwise.
3335
4ae29f89
SM
33362012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3337
3338 * print.c (print_preprocess): Only check print_depth if print-circle
3339 is nil.
3340 (print_object): Check for cycles even when print-circle is nil and
3341 print-gensym is t, but only check print_depth if print-circle is nil.
3342
f30d612a
CY
33432012-04-20 Chong Yidong <cyd@gnu.org>
3344
3345 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3346 set the status to "failed" and ensure that sentinel is run.
3347
c07a4c0b 33482012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3349
3350 * process.c (Fset_process_inherit_coding_system_flag)
3351 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3352 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3353
c07a4c0b 33542012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3355
3356 * xdisp.c (string_buffer_position_lim): Limit starting position to
3357 BEGV.
3358 (set_cursor_from_row): If called for a mode-line or header-line
3359 row, return zero immediately.
3360 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3361 farther than the first row after the header line, if any.
3362 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3363 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3364
c07a4c0b 33652012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3366
4ae29f89
SM
3367 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3368 (bug#11238).
ad3a2b41 3369
c07a4c0b 33702012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 33712012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3372
3373 configure: new option --enable-gcc-warnings (Bug#11207)
3374 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3375 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3376 (ALL_CFLAGS): Use new macros rather than old.
3377 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3378 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3379 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3380 -Wunused-result, -Wunused-variable. This should go away once
3381 the Emacs and Gnulib regex code is merged.
3382 (xmalloc, xrealloc): Now static.
3383
aba027e8
PE
33842012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3385
3386 * dired.c (Fsystem_groups): Remove unused local.
3387
e5a36063
GM
33882012-04-17 Glenn Morris <rgm@gnu.org>
3389
3390 * dired.c (Fsystem_users): Doc fix.
3391
316411f0
DA
33922012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3393
3394 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3395 (syms_of_dired): Add them.
3396
9426aba4
PE
33972012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3398
b62a57be
PE
3399 Fix minor alloc.c problems found by static checking.
3400 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3401 New extern decls, to avoid calling undeclared functions.
3402 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3403 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3404 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3405 (NEED_MEM_INSERT): New macro.
3406 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3407 Remove one incorrect comment and fix another.
b62a57be 3408
3539f31f
PE
3409 Fix minor ralloc.c problems found by static checking.
3410 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3411 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3412 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3413 (r_alloc_sbrk): Now static.
3414
a041960a
PE
3415 Improve ralloc.c interface checking.
3416 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3417 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3418 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3419 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3420 [REL_ALLOC]: ... to here, to check interface.
3421 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3422 Remove decls. This fixes an "It stinks!".
3423
9426aba4
PE
3424 * alloc.c (which_symbols): Fix alignment issue / type clash.
3425
d55c12ed
AS
34262012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3427
3428 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3429 (struct Lisp_Misc_Any): Likewise.
3430 (struct Lisp_Free): Likewise.
3431 * alloc.c (union aligned_Lisp_Symbol): Define.
3432 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3433 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3434 (union aligned_Lisp_Misc): Define.
3435 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3436 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3437 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3438
b948ce8b
PE
34392012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3442 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3443 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3444 * s/netbsd.h, s/sol2-6.h:
3445 Remove definition of GC_MARK_STACK, since the default now works.
3446 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3447 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3448 no longer the default.
3449 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3450
35dc09a1 34512012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3452
35dc09a1
GM
3453 * lread.c (lisp_file_lexically_bound_p):
3454 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3455
35dc09a1
GM
34562012-04-14 Eli Zaretskii <eliz@gnu.org>
3457
3458 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3459 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3460
34612012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3462
3463 * nsterm.m (constrainFrameRect): Always constrain when there is only
3464 one screen (Bug#10962).
3465
bcd86815
KB
34662012-04-13 Ken Brown <kbrown@cornell.edu>
3467
3468 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3469
c25df26e
RT
34702012-04-13 Reuben Thomas <rrt@sc3d.org>
3471
3472 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3473
0fc59f1e
DC
34742012-04-11 Daniel Colascione <dancol@dancol.org>
3475
3476 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3477 against is gone. It's better to use vfork now so that when Cygwin
3478 gains a new, working vfork, we use it automatically (bug#10398).
3479
de8c03dc
SM
34802012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3481
3482 * window.c (save_window_save): Obey window-point-insertion-type.
3483
2f097256
GM
34842012-04-11 Glenn Morris <rgm@gnu.org>
3485
3486 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3487
453b951e
SM
34882012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3489
3490 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3491
75f1671a 34922012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3493
3494 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3495 (force_quit_count): New var.
3496 (handle_interrupt): Use it.
3497
2a8ce227
JB
34982012-04-10 Juanma Barranquero <lekktu@gmail.com>
3499
3500 * w32.c (w32_delayed_load): Record the full path of the library
3501 being loaded (bug#10424).
3502
935396c0
GM
35032012-04-09 Glenn Morris <rgm@gnu.org>
3504
05920a43
GM
3505 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3506 not just in the obarray, before snarfing them. (Bug#11036)
3507
935396c0
GM
3508 * Makefile.in ($(leimdir)/leim-list.el):
3509 Pass EMACS rather than BUILT_EMACS.
3510
a18ecafa
TZ
35112012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3512
3513 * process.c (make_process):
3514 * process.h: Add integer `gnutls_handshakes_tried' member to
3515 process struct.
3516
6bbef4e5
JC
3517 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3518 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3519
3520 * gnutls.c (gnutls_log_function2i): Convenience log function.
3521 (emacs_gnutls_read): Use new log functions,
3522 `gnutls_handshakes_tried' process member, and
3523 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3524 attempts per process (connection).
3525
b4d3bc10
CY
35262012-04-09 Chong Yidong <cyd@gnu.org>
3527
3528 * eval.c (Fuser_variable_p, user_variable_p_eh)
3529 (lisp_indirect_variable): Functions deleted.
3530 (Fdefvar): Caller changed.
3531
3532 * callint.c (Finteractive, Fcall_interactively):
3533 * minibuf.c (Fread_variable): Callers changed.
3534
70f4d973
EZ
35352012-04-09 Eli Zaretskii <eliz@gnu.org>
3536
3537 * xdisp.c (set_cursor_from_row): If the display string appears in
3538 the buffer at position that is closer to point than the position
3539 after the display string, display the cursor on the first glyph of
3540 the display string. Fixes cursor display when a 'display' text
3541 property immediately follows invisible text. (Bug#11094)
3542
cb3c2e3e
PE
35432012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 composite.c: use 'double' consistently
3546 * composite.c (get_composition_id): Use 'double' consistently
3547 instead of converting 'float' to 'double' and vice versa; this is
3548 easier to understand and avoids a GCC warning.
3549
fd06db5d
GM
35502012-04-09 Glenn Morris <rgm@gnu.org>
3551
50fe702a
GM
3552 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3553 preparation for dumping it with emacs. (Bug#4789)
3554 (leimdir): New variable.
3555 ($(leimdir)/leim-list.el): New rule.
3556 (emacs$(EXEEXT)): Depend on leim-list.el.
3557
fd06db5d
GM
3558 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3559 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3560 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3561
55c131ee
AS
35622012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3563
3564 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3565 proper alignment.
3566
9209588f
JB
35672012-04-07 Juanma Barranquero <lekktu@gmail.com>
3568
3569 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3570 Remove unused local variable.
3571
e3fb2efb
PE
35722012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3573
3574 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3575 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3576 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3577 objects, as mark_maybe_pointer will catch them otherwise.
3578 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3579 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3580
b5385551
PE
35812012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3582
3583 Fix typo that broke non-Windows builds.
3584 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3585
9078ead6
EZ
35862012-04-07 Eli Zaretskii <eliz@gnu.org>
3587
3588 Support building on MS-Windows with libxml2.
3589
3590 * makefile.w32-in (OBJ2): Add xml.$(O).
3591 (GLOBAL_SOURCES): Add xml.c.
3592 ($(BLD)/xml.$(O)): New dependency list.
3593
3594 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3595 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3596 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3597 [!WINDOWSNT]: New macros.
3598 (init_libxml2_functions, libxml2_loaded_p): New functions.
3599 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3600 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3601 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3602 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3603 linked in).
6bbef4e5
JC
3604 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3605 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3606 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3607
3608 * emacs.c: Don't include libxml/parser.h.
3609 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3610 xmlCleanupParser directly.
3611
3612 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3613
3811fdf3
EZ
36142012-04-07 Eli Zaretskii <eliz@gnu.org>
3615
3616 * indent.c (Fvertical_motion): If there is a display string at
3617 point, use it.vpos to compute how many lines to backtrack after
3618 move_it_to point. (Bug#11133)
3619
2f8e16b2
EZ
36202012-04-06 Eli Zaretskii <eliz@gnu.org>
3621
3622 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3623 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3624 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3625 macros related to unification of CJK characters. For the details,
3626 see the discussion following the message here:
3627 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3628
3d439cd1
CY
36292012-04-04 Chong Yidong <cyd@gnu.org>
3630
3631 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3632
8bc53d00
EZ
36332012-04-01 Eli Zaretskii <eliz@gnu.org>
3634
3635 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3636 instead of alloca. (Bug#11138)
3637
3b0512a3
AS
36382012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * w32menu.c (is_simple_dialog): Properly check lisp types.
3641 (Bug#11141)
3642
8427ddd2
EZ
36432012-03-31 Eli Zaretskii <eliz@gnu.org>
3644
979022ef
EZ
3645 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3646 position we get to after a call to move_it_to fails the
3647 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3648 only if we wind up in a string from display property. (Bug#11063)
3649
a6b1c7cc
EZ
3650 * window.c (Fdelete_other_windows_internal): Invalidate the row
3651 and column information about mouse highlight, so that redisplay
3652 restores it after reallocating the glyph matrices. (Bug#7464)
3653
8427ddd2
EZ
3654 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3655 string comes from a `display' text property, use the buffer
3656 position of that property as if we actually saw that position in
3657 the row's glyphs.
697ba24b
EZ
3658 (move_it_by_lines): Remove the assertion that
3659 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3660 violated when there's a before-string at the beginning of a line.
3661 (Bug#11063)
8427ddd2 3662
65a0a738
EZ
36632012-03-30 Eli Zaretskii <eliz@gnu.org>
3664
3665 * xdisp.c (append_space_for_newline): If the default face was
3666 remapped, use the remapped face for the appended newline.
3667 (extend_face_to_end_of_line): Use the remapped default face for
3668 extending the face to the end of the line.
3669 (display_line): Call extend_face_to_end_of_line when the default
3670 face was remapped. (Bug#11068)
3671
581355cc
EZ
36722012-03-29 Eli Zaretskii <eliz@gnu.org>
3673
3674 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3675
e8fc049f
SM
36762012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3677
3678 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3679
4fb9a543
GM
36802012-03-27 Glenn Morris <rgm@gnu.org>
3681
3682 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3683 Doc fixes.
3684
679910f1
KH
36852012-03-26 Kenichi Handa <handa@m17n.org>
3686
3687 * dispextern.h (struct glyph): Fix previous change. Change the
3688 bit length of glyphless.ch to 25 (Bug#11082).
3689
90d49b7f
CY
36902012-03-26 Chong Yidong <cyd@gnu.org>
3691
3692 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3693 (command_loop_1): Use it; inhibit selection update for
3694 handle-select-window too (Bug#8996).
3695
f514f6f0
FP
36962012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3697
e8fc049f 3698 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3699
bf43fa51
KH
37002012-03-25 Kenichi Handa <handa@m17n.org>
3701
3702 * dispextern.h (struct glyph): Change the bit length of
3703 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3704
8a0c01dd
EZ
37052012-03-24 Eli Zaretskii <eliz@gnu.org>
3706
3707 * s/ms-w32.h (tzname): Include time.h before redirecting to
3708 _tzname. Fixes the MSVC build. (Bug#9960)
3709
7d1c3a76
AS
37102012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3711
8ed79523
AS
3712 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3713 characters.
3714
7d1c3a76
AS
3715 * xterm.c (XTread_socket): Only modify handling_signal if
3716 !SYNC_INPUT. (Bug#11080)
3717
e99a9b8b
EZ
37182012-03-23 Eli Zaretskii <eliz@gnu.org>
3719
3720 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3721 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3722 when fetching a multibyte character consumes more bytes than
3723 CHAR_BYTES returns, due to unification of CJK characters in
3724 string_char. (Bug#11073)
3725
5063c0e1
TN
37262012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3727
3728 * process.c (wait_reading_process_output): Handle pty disconnect
3729 by refraining from sending oneself a SIGCHLD (bug#10933).
3730
9f851fbd
CY
37312012-03-22 Chong Yidong <cyd@gnu.org>
3732
3733 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3734
5063c0e1 3735 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3736 Mark string as coming from a prefix property.
3737 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3738 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3739
fb5b8aca
CY
37402012-03-21 Chong Yidong <cyd@gnu.org>
3741
3742 * xfaces.c (Vface_remapping_alist): Doc fix.
3743
62356a1b
EZ
37442012-03-20 Eli Zaretskii <eliz@gnu.org>
3745
3746 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3747 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3748 Doc fixes.
62356a1b 3749
025de85b
CY
37502012-03-20 Chong Yidong <cyd@gnu.org>
3751
3752 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3753 to reflect default non-nil value of redisplay-dont-pause.
3754
4827f94e
KH
37552012-03-19 Kenichi Handa <handa@m17n.org>
3756
3757 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3758 it fit in a valid range (Bug#11003).
3759
e50a24a2
EZ
37602012-03-18 Eli Zaretskii <eliz@gnu.org>
3761
3762 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3763 that is not from display property, accept the row as a "cursor
3764 row" if one of the string's character has a non-nil `cursor'
3765 property. Fixes cursor positioning when there are newlines in
3766 overlay strings, e.g. in icomplete.el. (Bug#11035)
3767
9af5ed87
PE
37682012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3771
d1f55f16
CY
37722012-03-12 Chong Yidong <cyd@gnu.org>
3773
3774 * eval.c (inhibit_lisp_code): Rename from
3775 inhibit_window_configuration_change_hook; move from window.c.
3776
3777 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3778 * window.c (run_window_configuration_change_hook)
3779 (syms_of_window): Callers changed.
3780
66c5eebd
CY
37812012-03-11 Chong Yidong <cyd@gnu.org>
3782
413df973
CY
3783 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3784
66c5eebd
CY
3785 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3786
1de11f56
CY
37872012-03-10 Chong Yidong <cyd@gnu.org>
3788
3789 * frame.c (other_visible_frames): Don't assume the selected frame
3790 is visible (Bug#10955).
3791
cae07000
SM
37922012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3793
3794 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3795
89c94350
JD
37962012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3797
3798 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3799 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3800 zero (Bug#10954).
3801
999dd333
GM
38022012-03-03 Glenn Morris <rgm@gnu.org>
3803
01a6dcc8 3804 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3805
de0100f2
EZ
38062012-03-02 Eli Zaretskii <eliz@gnu.org>
3807
3808 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3809 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3810 (redisplay_window, next_element_from_string): Fix typos in
3811 comments.
3e441275
EZ
3812 (redisplay_window): Pass to move_it_vertically the margin in
3813 pixels, not in screen lines.
de0100f2 3814
96a72ee9
GM
38152012-03-02 Glenn Morris <rgm@gnu.org>
3816
3817 * buffer.c (buffer-list-update-hook): Doc fix.
3818
312508d7
EZ
38192012-02-29 Eli Zaretskii <eliz@gnu.org>
3820
3821 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3822 push_it before setting up the iterator for the first overlay
3823 string, even if we have an empty string loaded.
3824 (next_overlay_string): If there's an empty string on the iterator
3825 stack, pop the stack. (Bug#10903)
3826
27f3c637
PE
38272012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3828
3829 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3830 Suggested by Stefan Monnier in
3831 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3832 * alloc.c (widen_to_Lisp_Object): New static function.
3833 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3834 and widening them to Lisp_Objects. This would work even if
3835 USE_LSB_TAG is defined and wide integers are used, which might
3836 happen in a future version of Emacs.
3837
3c9dfce6
CY
38382012-02-25 Chong Yidong <cyd@gnu.org>
3839
fa74b241
CY
3840 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3841 Doc fix.
3842
3c9dfce6
CY
3843 * xselect.c (Fx_selection_exists_p): Doc fix.
3844 (x_clipboard_manager_save_all): Print an informative message
3845 before saving to clipboard manager.
3846
9486df08
CY
38472012-02-24 Chong Yidong <cyd@gnu.org>
3848
3849 * keyboard.c (process_special_events): Handle all X selection
3850 requests in kbd_buffer, not just the next one (Bug#8869).
3851
f01d3321
CY
38522012-02-23 Chong Yidong <cyd@gnu.org>
3853
3854 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3855 call when setting menu-bar-lines and tool-bar-lines parameters.
3856 (unwind_create_frame_1): New helper function.
3857
3858 * window.c (inhibit_window_configuration_change_hook): New var.
3859 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3860 (syms_of_window): Initialize it.
f01d3321 3861
86b847b6
CY
38622012-02-22 Chong Yidong <cyd@gnu.org>
3863
3864 * xterm.c (x_draw_image_relief): Add missing type check for
3865 Vtool_bar_button_margin (Bug#10743).
3866
a59225b1
CY
38672012-02-21 Chong Yidong <cyd@gnu.org>
3868
3869 * fileio.c (Vfile_name_handler_alist): Doc fix.
3870
3871 * buffer.c (Fget_file_buffer): Protect against invalid file
3872 handler return value.
3873
310f5bd4
PE
38742012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3875
cb3a28cc
PE
3876 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3877 when computing $valmask.
3878
310f5bd4
PE
3879 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3880 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3881 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3882 It's useless in that case, and it can cause problems on hosts
3883 that allocate halves of EMACS_INT values separately.
3884 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3885 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3886 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3887 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3888 it avoids undefined behavior on hosts where shifting right by more
3889 than the word width has undefined behavior.
3890
2375c96a
CY
38912012-02-19 Chong Yidong <cyd@gnu.org>
3892
3893 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3894 (Funhandled_file_name_directory, Ffile_name_as_directory)
3895 (Fdirectory_file_name, Fexpand_file_name)
3896 (Fsubstitute_in_file_name): Protect against invalid file handler
3897 return values (Bug#10845).
3898
3eb49e71
EZ
38992012-02-18 Eli Zaretskii <eliz@gnu.org>
3900
3901 * .gdbinit (pitx): Fix incorrect references to fields of the
3902 iterator stack.
3903
7b926f3f
CY
39042012-02-17 Chong Yidong <cyd@gnu.org>
3905
3906 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3907
11273115
PE
39082012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3909
3910 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3911 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3912
c3a70e2b
CY
39132012-02-15 Chong Yidong <cyd@gnu.org>
3914
3915 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3916 marked as special. Also, starting docstrings with * is obsolete.
3917
0ca43699
AS
39182012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3919
3920 * gnutls.c (emacs_gnutls_write): Fix last change.
3921
2e8f3c56
LI
39222012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3923
3924 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3925 send_process.
3926
af70074f
SM
39272012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3928
3929 * keymap.c (Fsingle_key_description): Handle char ranges.
3930
95986d52
CY
39312012-02-12 Chong Yidong <cyd@gnu.org>
3932
afd83bd1
CY
3933 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3934 as that creates a dangerous corner case.
3935
95986d52
CY
3936 * window.c (Fdelete_window_internal): Invalidate the mouse
3937 highlight (Bug#9904).
3938
bd7da63e
GM
39392012-02-12 Glenn Morris <rgm@gnu.org>
3940
3941 * xselect.c (Fx_own_selection_internal)
3942 (Fx_get_selection_internal, Fx_disown_selection_internal)
3943 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3944 * nsselect.m (Fx_own_selection_internal)
3945 (Fx_disown_selection_internal, Fx_selection_exists_p)
3946 (Fx_selection_owner_p, Fx_get_selection_internal):
3947 Sync docs and argument specs with the xselect.c versions.
3948
77abcbc2
LI
39492012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3950
3951 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3952
90b671e2
EZ
39532012-02-11 Eli Zaretskii <eliz@gnu.org>
3954
1c0ca0b7
EZ
3955 * w32select.c (Fx_selection_exists_p): Sync doc string and
3956 argument list with xselect.c. (Bug#10783)
3957
3958 * w16select.c (Fx_selection_exists_p): Sync doc string and
3959 argument list with xselect.c. (Bug#10783)
90b671e2 3960
49241268
GM
39612012-02-10 Glenn Morris <rgm@gnu.org>
3962
3963 * fns.c (Fsecure_hash): Doc fix.
3964
f998bbe7 39652012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3966
3967 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3968
0992bd9c
CY
39692012-02-07 Chong Yidong <cyd@gnu.org>
3970
3971 * buffer.c (Fbuffer_local_variables)
3972 (buffer_lisp_local_variables): Handle unbound vars correctly;
3973 don't let Qunbound leak into Lisp.
3974
af008560
GM
39752012-02-07 Glenn Morris <rgm@gnu.org>
3976
dd605cc4
GM
3977 * image.c (Fimagemagick_types): Doc fix.
3978
af008560
GM
3979 * image.c (imagemagick-render-type): Change it from a lisp object
3980 to an integer. Move the doc here from the lisp manual.
3981 Treat all values not equal to 0 the same.
3982
1449fa1d
CY
39832012-02-06 Chong Yidong <cyd@gnu.org>
3984
3985 * doc.c (store_function_docstring): Avoid applying docstring of
3986 alias to base function (Bug#2603).
3987
3723ec07
AS
39882012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3989
3990 * .gdbinit (pp1, pv1): Remove redundant defines.
3991 (pr): Use pp.
3992
79c1cc1e
CY
39932012-02-04 Chong Yidong <cyd@gnu.org>
3994
3995 * nsterm.m: Declare a global (Bug#10694).
3996
d7f29f8e
EZ
39972012-02-04 Eli Zaretskii <eliz@gnu.org>
3998
cae07000
SM
3999 * w32.c (get_emacs_configuration_options):
4000 Include --enable-checking, if specified, in the return value.
d7f29f8e 4001
3b95a6f9
MR
40022012-02-04 Martin Rudalics <rudalics@gmx.at>
4003
4004 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4005 after rounding frame sizes. (Bug#9723)
4006
d6fa96a6
EZ
40072012-02-04 Eli Zaretskii <eliz@gnu.org>
4008
4009 * keyboard.c (adjust_point_for_property): Don't position point
4010 before BEGV. (Bug#10696)
4011
df0b2940
PE
40122012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4013
4014 Handle overflow when computing char display width (Bug#9496).
4015 * character.c (char_width): Return EMACS_INT, not int.
4016 (char_width, c_string_width): Check for overflow when
4017 computing the width; this is possible now that individual
4018 characters can have unbounded width. Problem introduced
4019 by merge from Emacs 23 on 2012-01-19.
4020
6bee44d6
MA
40212012-02-02 Michael Albinus <michael.albinus@gmx.de>
4022
4023 * dbusbind.c (Fdbus_register_method): Mention the return value
4024 :ignore in the docstring.
4025
44f92739
GM
40262012-02-02 Glenn Morris <rgm@gnu.org>
4027
1b9f60cc
GM
4028 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4029
44f92739
GM
4030 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4031 Unconditionally set to t. (Bug#10673)
4032 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4033 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4034 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4035
c5d3843c
KH
40362012-02-02 Kenichi Handa <handa@m17n.org>
4037
4038 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4039 0, do not call append_composite_glyph.
4040
159462d4 40412012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4042
4043 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4044 NULL (Bug#6988).
4045 (x_produce_glyphs): If the component of a composition is a null
4046 string, set it->pixel_width to 1 to avoid zero-width glyph.
4047
78cef877
EZ
40482012-02-01 Eli Zaretskii <eliz@gnu.org>
4049
4050 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4051 first 2 arguments are identical. This makes inserting large
4052 output from a subprocess an order of magnitude faster on
4053 MS-Windows, where all sbrk'ed memory is always contiguous.
4054
97897668
GM
40552012-01-31 Glenn Morris <rgm@gnu.org>
4056
4057 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4058 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4059 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4060
31fd3586
GM
40612012-01-29 Glenn Morris <rgm@gnu.org>
4062
4063 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4064
0e24a8b2
CY
40652012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4066
4067 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4068
cc0adcb0
CY
40692012-01-28 Chong Yidong <cyd@gnu.org>
4070
4071 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4072
acc28cb9
CY
40732012-01-26 Chong Yidong <cyd@gnu.org>
4074
9c69cfb7
CY
4075 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4076
acc28cb9
CY
4077 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4078 repeat counts (Bug#10507).
4079
48da7392
GM
40802012-01-26 Glenn Morris <rgm@gnu.org>
4081
4082 * lread.c (syms_of_lread): Doc fix.
4083
14af5f7f
CY
40842012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4085
4086 * coding.c (encode_designation_at_bol): Change return value to
4087 EMACS_INT.
4088
0b21c100
CY
40892012-01-25 Chong Yidong <cyd@gnu.org>
4090
4091 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4092
3c2907f7
CY
40932012-01-21 Chong Yidong <cyd@gnu.org>
4094
4095 * floatfns.c (Fcopysign): Make the second argument non-optional,
4096 since nil is not allowed anyway.
4097
959ad23f
AS
40982012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4099
4100 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4101 (send_process): Likewise.
4102
34a02f46
MR
41032012-01-19 Martin Rudalics <rudalics@gmx.at>
4104
4105 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4106 (Vwindow_persistent_parameters): Do not use Qstate.
4107 Rewrite doc-strings.
34a02f46 4108
1259009a 41092012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4110
4111 * character.c (char_width): New function.
70d4fdf6
GM
4112 (Fchar_width, c_string_width, lisp_string_width):
4113 Use char_width (Bug#9496).
25ed9e61 4114
6a6ee00d
MR
41152012-01-16 Martin Rudalics <rudalics@gmx.at>
4116
4117 * window.c (Vwindow_persistent_parameters): New variable.
4118 (Fset_window_configuration, save_window_save): Handle persistent
4119 window parameters.
4120
c85efaf7
EZ
41212012-01-14 Eli Zaretskii <eliz@gnu.org>
4122
4123 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4124 thrashing the stack of the thread. (Bug#9087)
4125
5944709e
PE
41262012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4127
4128 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4129
e71f5d99
EZ
41302012-01-11 Eli Zaretskii <eliz@gnu.org>
4131
4132 * xdisp.c (rows_from_pos_range): Handle the case where the
4133 highlight ends on a newline. (Bug#10464)
4134 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4135 he end column for display of highlight that ends on a newline
4136 before a R2L line.
4137
ce316182
GM
41382012-01-11 Glenn Morris <rgm@gnu.org>
4139
4140 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4141 from load-path also when installation-directory is nil. (Bug#10208)
4142
5b43da69
GM
41432012-01-10 Glenn Morris <rgm@gnu.org>
4144
74cc8ff9
GM
4145 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4146
7d8d6e4e
GM
4147 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4148 Update template values to be closer to their typical values these days.
5b43da69 4149
a0db8d43
EZ
41502012-01-09 Eli Zaretskii <eliz@gnu.org>
4151
4152 * xdisp.c (rows_from_pos_range): Accept additional argument
4153 DISP_STRING, and accept any glyph in a row whose object is that
4154 string as eligible for mouse highlight. Fixes mouse highlight of
4155 display strings from overlays. (Bug#10464)
4156
9a0115ab 41572012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4158
b9110d6a 4159 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4160 * fileio.c (auto_saving_dir_umask): New static var.
4161 (Fmake_directory_internal): Use it.
4162 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4163 creating the directory. The old code temporarily assigns
4164 too-generous permissions to the directory.
4165 (do_auto_save_eh): Clear it.
b9110d6a 4166 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4167 that the var is always cleared.
4168
6c1bd3f3
EZ
41692012-01-07 Eli Zaretskii <eliz@gnu.org>
4170
4171 * search.c (scan_buffer): Pass character positions to
4172 know_region_cache, not byte positions. (Bug#6540)
4173
069d2b50
L
41742012-01-07 LynX <_LynX@bk.ru> (tiny change)
4175
4176 * w32.c (sys_rename): Report EXDEV when rename of a directory
4177 fails because the target is on another logical disk. (Bug#10284)
4178
75bf0d33
DB
41792012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4180
4181 * xterm.c (x_embed_request_focus): New function.
4182
4183 * xterm.h: Add prototype.
4184
4185 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4186
1c6e5a32
GM
41872012-01-05 Glenn Morris <rgm@gnu.org>
4188
4189 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4190
651e947e
EZ
41912012-01-01 Eli Zaretskii <eliz@gnu.org>
4192
4193 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4194 Load gnutls_transport_set_lowat only if GnuTLS version is below
4195 2.11.1.
4196 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4197 GnuTLS versions below 2.11.1.
4198
3778cdd8
AL
41992011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4200
4201 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4202 to the doc string advising against its use for altering the way
4203 windows are scrolled.
4204
0e5317f7
KH
42052011-12-28 Kenichi Handa <handa@m17n.org>
4206
4207 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4208 coding-system ASCII compatible only when it does not produce BOM
4209 on encoding (Bug#10383).
4210
93d5ca1f
JD
42112011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4212
4213 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4214 can scroll.
4215 (create_and_show_popup_menu): Always use menu_position_func for
4216 Gtk3 (Bug#10361).
4217
ca22b785
AS
42182011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4219
4220 * callint.c (Fcall_interactively): Don't truncate prompt string.
4221
d048e1e6
EZ
42222011-12-23 Eli Zaretskii <eliz@gnu.org>
4223
4224 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4225 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4226 resumed from there (after widening). (Bug#10360)
d048e1e6 4227
5ccaba1f
JD
42282011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4229
4230 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4231
204ee57f
JD
42322011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4233
b81d40f0
JB
4234 * nsterm.m (x_free_frame_resources):
4235 Release f->output_data.ns->miniimage.
204ee57f
JD
4236 (ns_index_color): Fix indentation. Do not retain
4237 color_table->colors[i].
4238
4239 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4240 before returning.
4241
4242 * nsfns.m (x_set_background_color): Assign return value from
4243 ns_index_color to face-background instead of NSColor*.
4244 (ns_implicitly_set_icon_type): Fix indentation.
4245 Change assignment in for loop to comparison.
4246
4247 * emacs.c (ns_pool): New variable.
4248 (main): Assign ns_pool.
4249 (Fkill_emacs): Call ns_release_autorelease_pool.
4250
4251 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4252 autorelease fdesc, release fdAttrs and tdict.
4253 (ns_get_covering_families): Release charset.
4254 (ns_findfonts): Release NSFontDescriptor created with new.
4255 (ns_uni_to_glyphs): Fix indentation.
4256 (setString): Release attrStr before assigning new value.
4257
c803b2b7
JD
42582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4259
678f4426
JD
4260 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4261 and NS_IMPL_COCOA.
4262 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4263 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4264
cd394be1 42652011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4266
5fecd5fc
JD
4267 * nsterm.m (ns_term_init): Subscribe for notifications
4268 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4269 to method trackingNotification in EmacsMenu.
4270
4271 * nsmenu.m (trackingMenu): New variable.
3771cb17 4272 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4273 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4274 from Aquamacs (Bug#7030).
678f4426
JD
4275
42762011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4277
c803b2b7
JD
4278 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4279 (symbol_to_nsstring): Fix indentation.
4280 (ns_symbol_to_pb): New function.
cae07000
SM
4281 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4282 (Fns_rotate_cut_buffers_internal): Remove.
4283 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4284 Fns_store_cut_buffer_internal.
4285 (ns_get_foreign_selection, Fx_own_selection_internal)
4286 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4287 (Fns_get_selection_internal, Fns_store_selection_internal):
4288 Use ns_symbol_to_pb and check if return value is nil.
4289 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4290 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4291 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4292 renamed to Sns_store_selection_internal.
4293 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4294 and remove this function.
4295 (ns_handle_selection_clear): Remove, never used.
4296 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4297 here.
4298
e1b01a3a
KB
42992011-12-17 Ken Brown <kbrown@cornell.edu>
4300
4301 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4302 GID is unknown (Bug#10257).
4303
2adb6e85
PE
43042011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4305
4306 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4307 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4308 which caused a build failure on GNU/Linux IA-64. This problem was
4309 introduced by my 2011-10-07 patch.
4310
d1d7b339
JL
43112011-12-15 Juri Linkov <juri@jurta.org>
4312
4313 * image.c (imagemagick_error): New function. (Bug#10112)
4314 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4315 Use `imagemagick_error' where ImageMagick functions return
4316 `MagickFalse'.
4317 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4318 proper order.
4319
100d5755
KH
43202011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4321
4322 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4323 fill background (Bug#8992).
4324
454592a6
MR
43252011-12-13 Martin Rudalics <rudalics@gmx.at>
4326
4327 * window.c (Vwindow_combination_resize)
4328 (Vwindow_combination_limit): Use t instead of non-nil in
4329 doc-strings.
61d4b438
MR
4330 (Vrecenter_redisplay): Add first sentence of doc-string on
4331 separate line.
53524d93 4332 (Frecenter): Fix doc-string typo.
454592a6 4333
3633e3aa
KH
43342011-12-11 Kenichi Handa <handa@m17n.org>
4335
4336 * coding.c (Funencodable_char_position): Pay attention to the
4337 buffer text relocation (Bug#9389).
4338
7b9d523a 43392011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4340
7b9d523a
JD
4341 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4342 gtk_init (Bug#10100).
4343
b73189c6
EZ
43442011-12-10 Eli Zaretskii <eliz@gnu.org>
4345
4346 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4347 IT->string is nil. (Bug#10263)
4348
f7dfe5d6
JD
43492011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4350
83faebb4
JD
4351 * nsterm.h (x_free_frame_resources): Declare.
4352
f7dfe5d6
JD
4353 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4354 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4355
4356 * nsterm.h (ns_get_defaults_value): Declare.
4357
4358 * nsterm.m (ns_default): Call ns_get_defaults_value.
4359
7cd4e72c
EZ
43602011-12-09 Eli Zaretskii <eliz@gnu.org>
4361
4362 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4363 (Bug#10170)
4364
b34d7317
YM
43652011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4366
4367 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4368 that where the value of an _OBJC_* symbol points to is in the .bss
4369 section (Bug#10240).
4370
76470ad1
KH
43712011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4372
4373 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4374 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4375
745fff94
KH
43762011-12-08 Kenichi Handa <handa@m17n.org>
4377
4378 * ftfont.c (get_adstyle_property): Fix previous change
4379 (Bug#10233).
4380
6e44397c
JB
43812011-12-07 Juanma Barranquero <lekktu@gmail.com>
4382
4383 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4384 dirs from the default value of EMACSLOADPATH (bug#10208).
4385
7efa6272
GM
43862011-12-07 Glenn Morris <rgm@gnu.org>
4387
4388 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4389 installation and source directories as well. (Bug#10208)
4390
f6fc4d87
CY
43912011-12-06 Chong Yidong <cyd@gnu.org>
4392
4393 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4394
2bf26180
GM
43952011-12-06 Glenn Morris <rgm@gnu.org>
4396
4397 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4398 as an error, not just -1. (Bug#10217)
4399
3a6ad4f0
CY
44002011-12-05 Chong Yidong <cyd@gnu.org>
4401
4402 * keyboard.c (process_special_events): New function.
4403 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4404
75a3b399
PE
44052011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4406
4407 * coding.c (encode_designation_at_bol): Don't use uninitialized
4408 local variable (Bug#9318).
4409
c3c9e25e
KH
44102011-12-05 Kenichi Handa <handa@m17n.org>
4411
4412 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4413 return Qnil (Bug#8046, Bug#10193).
4414
5eb05ea3
KH
44152011-12-05 Kenichi Handa <handa@m17n.org>
4416
4417 * coding.c (encode_designation_at_bol): New args charbuf_end and
4418 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4419 (coding_set_source): Return how many bytes coding->source was
4420 relocated.
4421 (coding_set_destination): Return how many bytes
4422 coding->destination was relocated.
4423 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4424 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4425
44262011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4427
4428 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4429 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4430 macro (Bug#9318).
4431
44322011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4433
4434 The following changes are to fix Bug#9318.
4435
a79703f5 4436 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4437 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4438 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4439 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4440
7dbda6df
JB
44412011-12-05 Juanma Barranquero <lekktu@gmail.com>
4442
4443 * lisp.h (process_quit_flag): Fix external declaration.
4444
6d5eb5b0
SM
44452011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4446
4447 Don't macro-inline non-performance-critical code.
4448 * eval.c (process_quit_flag): New function.
4449 * lisp.h (QUIT): Use it.
4450
a0c3fad0
JD
44512011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4452
4453 * nsfns.m (get_geometry_from_preferences): New function.
4454 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4455
6c07aac2
AS
44562011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4457
4458 * emacs.c (Qkill_emacs): Define.
4459 (syms_of_emacs): Initialize it.
4460 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4461 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4462 (quit_throw_to_read_char): Add parameter `from_signal'.
4463 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4464 * lisp.h (QUIT): Call Fkill_emacs if requested.
4465
c052ead4
JD
44662011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4467
4468 * widget.c (update_wm_hints): Return if wmshell is null.
4469 (widget_update_wm_size_hints): New function.
4470
4471 * widget.h (widget_update_wm_size_hints): Declare.
4472
4473 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4474 widget_update_wm_size_hints (Bug#10104).
4475
9e49252b
EZ
44762011-12-03 Eli Zaretskii <eliz@gnu.org>
4477
4478 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4479 before a newline, prepare the bidi iterator for consuming the
4480 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4481 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4482
02b16839
JL
44832011-12-02 Juri Linkov <juri@jurta.org>
4484
4485 * search.c (Fword_search_regexp): New Lisp function created from
4486 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4487 (Fword_search_backward, Fword_search_forward)
4488 (Fword_search_backward_lax, Fword_search_forward_lax):
4489 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4490 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4491
0068070e
SM
44922011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4493
4494 * fileio.c (Finsert_file_contents): Move after-change-function call
4495 to before the "handled:" label, since all "goto handled" appear in
4496 cases where the *-change-functions have already been properly called
4497 (bug#10117).
4498
3360a3fc
AS
44992011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4500
4501 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4502 waiting for input. (Bug#10169)
4503
73d6c093
EZ
45042011-11-30 Eli Zaretskii <eliz@gnu.org>
4505
4506 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4507 verifies glyph row's hash code--we have just reallocated the
4508 glyphs, so their contents can be complete garbage. (Bug#10164)
4509
febe6bea
JB
45102011-11-30 Juanma Barranquero <lekktu@gmail.com>
4511
4512 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4513
801a4313
EZ
45142011-11-30 Eli Zaretskii <eliz@gnu.org>
4515
4516 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4517 attributes are tested _before_ calling verify_row_hash, to protect
4518 against GCC re-ordering of the tests. (Bug#10164)
4519
2b56b87e
JD
45202011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4521
4522 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4523
4524 * xterm.c (handle_one_xevent): Only set async_visible and friends
4525 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4526 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4527 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4528
dbf31225
PE
45292011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4530
4531 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4532 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4533 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4534 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4535 All uses changed to use GCPRO1 etc.
4536 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4537 Revert to old implementation (i.e., before 2011-03-11).
4538
1305621b
YM
45392011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4540
4541 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4542 of scroll runs so as to avoid assigning disabled bogus rows and
4543 unnecessary graphics copy operations.
4544
8c9afb46
EZ
45452011-11-27 Eli Zaretskii <eliz@gnu.org>
4546
4547 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4548 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4549 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4550 (malloc, free, realloc, calloc): Redirect to e_* only when
4551 compiling Emacs.
4552
4553 * lisp.h (GCTYPEBITS): Move before first use.
4554 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4555 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4556 this macro definition.
4557
4558 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4559 _MSC_VER.
4560
54e9e3bf
JD
45612011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4562
6d5eb5b0
SM
4563 * gtkutil.c (xg_create_frame_widgets):
4564 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4565 present with Gtk+ 2.0.
4566
83aca1cb
PE
45672011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * fileio.c (Finsert_file_contents): Undo previous change; see
4570 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4571
5b76caa4
PE
45722011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4573
4574 Rename locals to avoid shadowing.
4575 * fileio.c (Finsert_file_contents):
4576 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4577 * process.c (wait_reading_process_output):
4578 Rename inner 'proc' to 'p' to avoid shadowing.
4579 Indent for consistency with usual Emacs style.
4580
8c535114
EZ
45812011-11-25 Eli Zaretskii <eliz@gnu.org>
4582
4583 * xdisp.c (redisplay_window): If cursor row is not fully visible
4584 after recentering, and scroll-conservatively is set to a large
4585 number, scroll window by a few more lines to make the cursor fully
4586 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4587 (start_display): Don't move to the next line if the display should
4588 start at a newline that is part of a display vector or an overlay
4589 string. (Bug#10119)
8c535114 4590
fa4fdb5c
JL
45912011-11-24 Juri Linkov <juri@jurta.org>
4592
4593 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4594 after the `MagickPingImage' call. (Bug#10112)
4595
90ec88df
CY
45962011-11-23 Chong Yidong <cyd@gnu.org>
4597
4598 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4599
56e2e794
MR
46002011-11-23 Martin Rudalics <rudalics@gmx.at>
4601
4602 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4603 making another buffer current. (Bug#10114)
4604
b6e64c41
GM
46052011-11-23 Glenn Morris <rgm@gnu.org>
4606
4607 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4608
6b21de18
CY
46092011-11-23 Chong Yidong <cyd@gnu.org>
4610
4611 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4612 using it (Bug#5984).
4613
b12cd789
EZ
46142011-11-22 Eli Zaretskii <eliz@gnu.org>
4615
4616 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4617 and header-lines, as they don't have one computed for them.
4618 (Bug#10098)
4619
4620 * .gdbinit (prow): Make displayed values more self-explaining.
4621 Add row's hash code.
4622
261b6fd4
LMI
46232011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4624
4625 * process.c (wait_reading_process_output): Fix asynchrounous
4626 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4627 (wait_reading_process_output): Add comment and URL.
261b6fd4 4628
e7cfd277
JD
46292011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4630
4631 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4632
a9b9b7f5
CY
46332011-11-21 Chong Yidong <cyd@gnu.org>
4634
4635 * window.c (Fnext_window, Fprevious_window): Doc fix.
4636
b0d15b4f
SM
46372011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4638
4639 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4640
fe7a3057
JB
46412011-11-20 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4644
d2999b1a
MR
46452011-11-20 Martin Rudalics <rudalics@gmx.at>
4646
4647 * window.c (Fset_window_combination_limit): Rename argument
4648 STATUS to LIMIT.
4649 (Vwindow_combination_limit): Remove "status" from doc-string.
4650
d5ff9cd0
AS
46512011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4652
4653 * m/ibms390.h: Remove.
4654 * m/ibms390x.h: Don't include "ibms390.h".
4655
a5bb9bd3
SM
46562011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4657
4658 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4659 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4660
cd1181db
JB
46612011-11-20 Juanma Barranquero <lekktu@gmail.com>
4662
4663 * casetab.c (Fset_case_table):
4664 * charset.c (Fcharset_after): Fix typos.
4665
615a3b8d 46662011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4667
17e845af
PE
4668 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4669 Otherwise, valgrind does not work on some platforms.
4670 Problem reported by Andreas Schwab in
6a0bf43d
PE
4671 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4672 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4673 is set, removing the need for VIRT_ADDRESS_VARIES.
4674 (PURE_P): Use a more-efficient implementation that needs just one
4675 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4676 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4677 to 4 (xorl, subq, cmpq, setbe).
4678 * alloc.c (pure): Always extern now, since that's the
4679 VIRT_ADDR_VARIES behavior.
4680 (PURE_POINTER_P): Use a single comparison, not two, for
4681 consistency with the new puresize.h.
4682 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4683 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4684 Remove VIRT_ADDR_VARIES no longer needed.
4685
f8fe6f96
EZ
46862011-11-19 Eli Zaretskii <eliz@gnu.org>
4687
4688 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4689 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4690 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4691 behave as if the cursor position were at the window margin.
4692
4693 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4694 and the cursor position is out of bounds, behave as if the cursor
4695 position were at the window margin. (Bug#10075)
4696
df05a53c
CY
46972011-11-18 Chong Yidong <cyd@gnu.org>
4698
4699 * window.c (Fwindow_combination_limit): Make first argument
4700 non-optional, since it is meaningless for live windows like the
4701 selected window.
61ccba97 4702
2071918e
DA
47032011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4704
4705 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4706
b50a28de
SM
47072011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4708
4709 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4710 (graft_intervals_into_buffer): Simplify.
4711
015137db
EZ
47122011-11-18 Eli Zaretskii <eliz@gnu.org>
4713
4714 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4715 hash values of the two rows.
4716 (copy_row_except_pointers): Preserve the used[] arrays and the
4717 hash values of the two rows. (Bug#10035)
68c95424 4718 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4719
4720 * xdisp.c (row_hash): New function, body extracted from
4721 compute_line_metrics.
4722 (compute_line_metrics): Call row_hash, instead of computing the
4723 hash code inline.
4724
4725 * dispnew.c (verify_row_hash): Call row_hash for computing the
4726 hash code of a row, instead of duplicating code from xdisp.c.
4727
4728 * dispextern.h (row_hash): Add prototype.
4729
a2addb04
TH
47302011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4731
4732 * frame.c (delete_frame): Don't delete the terminal when the last
4733 X frame is closed if emacs is built with GTK toolkit.
4734
df85d315
JB
47352011-11-17 Juanma Barranquero <lekktu@gmail.com>
4736
4737 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4738
a0c2d0ae
MR
47392011-11-17 Martin Rudalics <rudalics@gmx.at>
4740
4741 * window.c (Vwindow_splits): Rename to
4742 Vwindow_combination_resize. Suggested by Juri Linkov.
4743 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4744 of Vwindow_splits.
4745
58179cce
JB
47462011-11-16 Juanma Barranquero <lekktu@gmail.com>
4747
7877f373
JB
4748 * nsfns.m (Fns_font_name):
4749 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4750
b6f67890
MR
47512011-11-16 Martin Rudalics <rudalics@gmx.at>
4752
4753 * window.h (window): Rename slot "nest" to "combination_limit".
4754 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4755 (Fset_window_nest): Rename to Fset_window_combination_limit.
4756 (Vwindow_nest): Rename to Vwindow_combination_limit.
4757 (recombine_windows, make_parent_window, make_window)
4758 (Fsplit_window_internal, saved_window)
4759 (Fset_window_configuration, save_window_save): Rename all
4760 occurrences of window_nest to window_combination_limit.
4761
c7015153
JB
47622011-11-15 Juanma Barranquero <lekktu@gmail.com>
4763
4764 * image.c (imagemagick_load_image): Fix typo.
4765
322ad6ec
EZ
47662011-11-14 Eli Zaretskii <eliz@gnu.org>
4767
4768 * xdisp.c (display_line): Move the call to
4769 highlight_trailing_whitespace before the call to
4770 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4771 faces of all the glyphs to compute ROW's hash value.
4772 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4773
f067b8ec
JB
47742011-11-14 Juanma Barranquero <lekktu@gmail.com>
4775
4776 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4777 just return (bug#10044).
4778
1e5b2111
EZ
47792011-11-12 Eli Zaretskii <eliz@gnu.org>
4780
7ef3cbd5
EZ
4781 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4782 with user-defined heap size. Bump the default size of the temacs
4783 heap to 27MB, to avoid memory warning when running temacs.
4784 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4785
1e5b2111
EZ
4786 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4787 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4788 (verify_row_hash) [XASSERTS]: New function.
4789 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4790 that the hash value of glyph rows is correct.
1e5b2111 4791
89d61221
MR
47922011-11-12 Martin Rudalics <rudalics@gmx.at>
4793
4794 * window.h (window): Remove splits slot.
4795 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4796 (Fdelete_other_windows_internal, make_parent_window)
4797 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4798 (Fset_window_configuration, save_window_save): Don't deal with
4799 split status of windows.
4800 (saved_window): Remove splits slot.
4801 (Vwindow_splits): Rewrite doc-string.
4802
97f18cc8
JD
48032011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4804
4805 * xfns.c (unwind_create_frame):
4806 * nsfns.m (unwind_create_frame):
4807 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4808 Vframe_list (Bug#9999).
4809
22a648b4
DA
48102011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4811
0b381c7e 4812 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4813
659afede
KH
48142011-11-11 Kenichi Handa <handa@m17n.org>
4815
4816 * callproc.c (Fcall_process): Set the member dst_multibyte of
4817 process_coding.
4818
9ac0394b
KH
48192011-11-11 Johan Bockgård <bojohan@gnu.org>
4820
4821 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4822 avoid a crash (bug#9496).
4823
2fbdc249
CY
48242011-11-09 Chong Yidong <cyd@gnu.org>
4825
4826 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4827 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4828
ac6b1f81
PE
48292011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4830
4831 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4832
09db192c
PE
48332011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4834
4835 Avoid some portability problems by eschewing 'extern inline' functions.
4836 The trivial performance wins aren't worth the portability hassles; see
4837 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4838 et seq.
4839 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4840 (window_box_width, window_box_left, window_box_left_offset)
4841 (window_box_right, window_box_right_offset): Undo previous change,
4842 by removing the "extern"s.
4843 * intervals.c (adjust_intervals_for_insertion)
4844 (adjust_intervals_for_deletion): Undo previous change,
4845 making these static again.
4846 (offset_intervals, temp_set_point_both, temp_set_point)
4847 (copy_intervals_to_string): No longer inline.
4848 * xdisp.c (window_text_bottom_y, window_box_width)
4849 (window_box_height, window_box_left_offset)
4850 (window_box_right_offset, window_box_left, window_box_right)
4851 (window_box): No longer inline.
4852
105216ed
CY
48532011-11-08 Chong Yidong <cyd@gnu.org>
4854
4855 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4856 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4857 Signal an error if not a live window.
105216ed
CY
4858 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4859 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4860
ae9e237f
JB
48612011-11-07 Juanma Barranquero <lekktu@gmail.com>
4862
4863 * lisp.h (syms_of_abbrev): Remove declaration.
4864 Reported by CHENG Gao <chenggao@royau.me>.
4865
c7aa8333
EZ
48662011-11-07 Eli Zaretskii <eliz@gnu.org>
4867
4868 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4869 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4870 of temacs in GUI mode.
4871
be7f5545
MR
48722011-11-07 Martin Rudalics <rudalics@gmx.at>
4873
4874 * window.h: Declare delete_all_child_windows instead of
4875 delete_all_subwindows.
4876 * window.c (Fwindow_nest, Fset_window_nest)
4877 (Fset_window_new_total, Fset_window_new_normal)
4878 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4879 (delete_all_subwindows): Rename to delete_all_child_windows.
4880 (Fdelete_other_windows_internal, Fset_window_configuration):
4881 Call delete_all_child_windows instead of delete_all_subwindows.
4882 * frame.c (delete_frame): Call delete_all_child_windows instead
4883 of delete_all_subwindows.
4884
ca78dc43
PE
48852011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4886
4887 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4888 This is also needed for porting to any host where GC_MARK_STACK is
4889 not GC_MAKE_GCPROS_NOOPS.
4890 (which_symbols): Use it.
4891
a0241d01
KH
48922011-11-07 Kenichi Handa <handa@m17n.org>
4893
4894 * coding.c (coding_set_destination): Check coding->src_pos only
4895 when coding->src_object is a buffer (bug#9910).
4896
4897 * process.c (send_process): Set the member src_multibyte of coding
4898 to 0 (bug#9911) when sending a unibyte text.
4899
4900 * callproc.c (Fcall_process): Set the member src_multibyte of
4901 process_coding to 0 (bug#9912).
4902
a64bfdfa 49032011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4904
4905 * xmenu.c (cleanup_widget_value_tree): New function.
4906 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4907 calling free_menubar_widget_value_tree directly (Bug#9830).
4908
cb41b32a
PE
49092011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4910
4911 Fix some portability problems with 'inline'.
4912 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4913 (window_box_width, window_box_left, window_box_left_offset)
4914 (window_box_right, window_box_right_offset): Declare extern.
4915 Otherwise, these inline functions do not conform to C99 and
4916 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4917 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4918 * intervals.c (adjust_intervals_for_insertion)
4919 (adjust_intervals_for_deletion): Now extern, because otherwise the
4920 extern inline functions 'offset_intervals' couldn't refer to it.
4921 (static_offset_intervals): Remove.
4922 (offset_intervals): Rewrite using the old contents of
4923 static_offset_intervals. The old version didn't conform to C99
4924 because an extern inline function contained a reference to an
4925 identifier with static linkage.
4926
b7041366
AS
49272011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4928
4929 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4930 GC.
4931
88a37c4d
EZ
49322011-11-06 Eli Zaretskii <eliz@gnu.org>
4933
4934 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4935 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4936 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4937 return Qleft_to_right.
4938
49745b39
CY
49392011-11-06 Chong Yidong <cyd@gnu.org>
4940
4941 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4942 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4943 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4944 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4945 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4946 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4947 (Fwindow_vscroll): Doc fix.
4948 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4949 argument, since it makes no sense to pass a live window and for
4950 consistency with window-child.
4951
1f05cd82
CS
49522011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4953
4954 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4955 support MSVC.
4956
22610910
JR
49572011-11-05 Jason Rumney <jasonr@gnu.org>
4958
4959 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4960 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4961 fonts (Bug#6029).
4962 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4963 bitwise arithmetic preventing use of unicode-sip and non-truetype
4964 opentype fonts.
4965
a06776b2
EZ
49662011-11-05 Eli Zaretskii <eliz@gnu.org>
4967
3ad924ba
EZ
4968 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4969 "emacs"-only part.
4970
a06776b2
EZ
4971 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4972 initialization code to keep similarity to xfns.c after changes
4973 from 2011-11-05.
4974
c9e7db78
JD
49752011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4976
a97f8f3f
JD
4977 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4978 (unwind_create_frame): New function (Bug#9943).
4979 (Fx_create_frame): Restructure code to be more similar to the one in
4980 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4981 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4982 Move terminal->reference_count++ just before making the frame official
4983 (Bug#9943).
4984
4985 * nsterm.m (x_free_frame_resources): New function.
4986 (x_destroy_window): Move code to x_free_frame_resources.
4987
c9e7db78 4988 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4989 (Fx_create_frame, x_create_tip_frame):
4990 Move terminal->reference_count++ just before making the frame
75f1671a 4991 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4992 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4993
a6fc3b5c
EZ
49942011-11-05 Eli Zaretskii <eliz@gnu.org>
4995
4996 Support MSVC build with newer versions of Visual Studio.
4997 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4998 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4999 nt/gmake.defs.
5000
5001 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5002 which are not supported by MSVC.
5003 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5004 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5005 bitfields.
5006 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5007 types in bitfields.
5008 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5009
5010 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5011
58179cce 50122011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5013
5014 Support MSVC build with newer versions of Visual Studio.
5015 * w32.c: Don't include w32api.h for MSVC.
5016 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5017
5018 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5019 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5020 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5021 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5022 e_* cousins.
5023 (alloca) [_MSC_VER]: Define to _alloca.
5024
5025 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5026
5027 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5028
a58c13ed
EZ
50292011-11-04 Eli Zaretskii <eliz@gnu.org>
5030
5031 * xdisp.c (note_mouse_highlight): If either of
5032 previous/next-single-property-change returns nil, treat that as
5033 the beginning or the end of the buffer. (Bug#9955)
5034
fe0b6370
JD
50352011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5036
a58c13ed 5037 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5038 label is not null (Bug#9951).
5039 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5040 may be NULL.
5041
89bd5ee1
EZ
50422011-11-04 Eli Zaretskii <eliz@gnu.org>
5043
5044 * window.c (Fwindow_body_size): Mention in the doc string that the
5045 return value is in frame's canonical units. (Bug#9949)
5046
84c3edb9
EZ
50472011-11-03 Eli Zaretskii <eliz@gnu.org>
5048
4e2fb5c7
EZ
5049 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5050
84c3edb9 5051 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5052 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5053 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5054
bc17a887
EZ
50552011-11-01 Eli Zaretskii <eliz@gnu.org>
5056
5057 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5058 Don't stop backward scan on the continuation glyph, even though
5059 its CHARPOS is positive.
6d5eb5b0
SM
5060 (mouse_face_from_buffer_pos, note_mouse_highlight):
5061 Rename cover_string to disp_string.
bc17a887 5062
4ee88440
MR
50632011-11-01 Martin Rudalics <rudalics@gmx.at>
5064
5065 * window.c (temp_output_buffer_show): Don't use
5066 Vtemp_buffer_show_specifiers.
5067 (Vtemp_buffer_show_specifiers): Remove unused variable.
5068
c2ff3c02
EZ
50692011-10-30 Eli Zaretskii <eliz@gnu.org>
5070
5071 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5072 past the beginning of the current glyph matrix.
5073
58179cce 50742011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5075
5076 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5077 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5078 HAVE_GTK3 (Bug#9869).
b77a6a7f 5079
3b574623
JD
5080 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5081 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5082
b77a6a7f
JD
5083 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5084
5085 * xterm.c: Declare x_handle_net_wm_state to return int.
5086 (handle_one_xevent): Check if we are iconified but don't have
5087 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5088 (get_current_wm_state): Return non-zero if not hidden,
5089 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5090 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5091 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5092 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5093
196e41e4
PE
50942011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5095
5096 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5097 so that this new function doesn't get optimized away by a
5098 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5099
021f2e1a
AS
51002011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5101
5102 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5103
8b058d44
EZ
51042011-10-29 Eli Zaretskii <eliz@gnu.org>
5105
5106 Fix the `xbytecode' command.
5107 * .gdbinit (xprintbytestr): New command.
b50a28de 5108 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5109 (xbytecode): Print the byte-code string as well.
5110
4452fb80
EZ
51112011-10-29 Kim Storm <storm@cua.dk>
5112
8b058d44
EZ
5113 * alloc.c (which_symbols): New function.
5114
21b72067
AS
51152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5116
5117 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5118 line. (Bug#9903)
5119
83ed7b5c
GM
51202011-10-29 Glenn Morris <rgm@gnu.org>
5121
5122 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5123 Not clear what it was for, and it causes various bugs. (Bug#9839)
5124
5a7a728b
EZ
51252011-10-28 Eli Zaretskii <eliz@gnu.org>
5126
5127 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5128 possible random value that matches one of those tested as
5129 condition to clear the mouse face.
5130
d3d0842f
CY
51312011-10-28 Chong Yidong <cyd@gnu.org>
5132
5133 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5134
31b39d13
DN
51352011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5136
5137 * window.c (make_window): Initialize phys_cursor_on_p.
5138
9aba6043
SM
51392011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5140
5141 * lisp.h (struct Lisp_Symbol): Update comments.
5142
c20992f4
JB
51432011-10-28 Juanma Barranquero <lekktu@gmail.com>
5144
5145 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5146
db4f02f2
EZ
51472011-10-28 Eli Zaretskii <eliz@gnu.org>
5148
5149 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5150 <oslsachem@gmail.com> for helping to debug this.
5151
5152 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5153 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5154 (g_b_init_get_glyph_outline_w): New static variables.
5155 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5156 (GetGlyphOutlineW_Proc): New typedefs.
5157 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5158 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5159 New functions.
5160 (w32font_open_internal, compute_metrics):
5161 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5162 instead of calling the "wide" APIs directly.
5163
5164 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5165
5166 * w32.h (syms_of_w32font): Add prototype.
5167
87e68db4
JB
51682011-10-27 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5171 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5172 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5173 (Fmove_to_window_line): Doc fix.
5174
435c1d67
CY
51752011-10-27 Chong Yidong <cyd@gnu.org>
5176
5177 * process.c (make_process): Set gnutls_state to NULL.
5178
5179 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5180 non-NULL, regardless of GNUTLS_INITSTAGE.
5181 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5182 an error. Set process slots as soon as we allocate them.
5183
5184 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5185
9c6c6f49
CY
51862011-10-27 Chong Yidong <cyd@gnu.org>
5187
9aba6043
SM
5188 * gnutls.c (emacs_gnutls_deinit): New function.
5189 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5190 (Fgnutls_deinit, Fgnutls_boot): Use it.
5191
5192 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5193 (deactivate_process): Call emacs_gnutls_deinit.
5194
657d08d3
JB
51952011-10-27 Juanma Barranquero <lekktu@gmail.com>
5196
5197 * image.c (x_create_x_image_and_pixmap):
5198 * w32.c (sys_rename, w32_delayed_load):
5199 * w32font.c (fill_in_logfont):
5200 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5201
5430d399
JB
52022011-10-26 Juanma Barranquero <lekktu@gmail.com>
5203
5204 * w32fns.c (w32_default_color_map): New function,
5205 extracted from Fw32_default_color_map.
a7ef684b 5206 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5207
fe0055fa
PE
52082011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5209
5210 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5211
e6346438
SM
52122011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5213
5214 * keyboard.c (test_undefined): New function (bug#9751).
5215 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5216
e112cc37
ET
52172011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5218
5219 * sysdep.c (init_sys_modes): Fix the check for the controlling
5220 terminal (Bug#6649).
5221
7b5d6677
EZ
52222011-10-20 Eli Zaretskii <eliz@gnu.org>
5223
5224 * dispextern.h (struct bidi_it): New member next_en_type.
5225
5226 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5227 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5228 current character, check also for next_en_type being WEAK_EN.
5229 (bidi_resolve_weak): Don't enter the expensive loop if the current
5230 position is before next_en_pos. Record the bidi type of the first
5231 non-ET, non-BN character we find, in addition to its position.
5232 (bidi_level_of_next_char): Invalidate next_en_type when
5233 next_en_pos is over-stepped.
5234
7da0b018
PE
52352011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5236
5237 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5238 * editfns.c: Rewrite current-time-zone so that it invokes
5239 the equivalent of (format-time-string "%Z") to get the time zone name.
5240 This fixes a bug when the time zone name contains characters that
5241 need converting from the system time locale to Emacs internal format.
5242 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5243 that patch fixed format-time-string to do the conversion, but
5244 I forgot to fix current-time-zone.
5245 (format_time_string): New function, containing most of
5246 what Fformat_time_string used to contain.
5247 (Fformat_time_string): Rewrite in terms of format_time_string.
5248 This doesn't change this function's behavior.
5249 (current-time-zone): Rewrite to use format_time_string.
5250 This fixes the bug reported by Michael Schierl in
5251 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5252 Jason Rumney's 2007-06-07 change worked around this bug, but
5253 didn't fix it.
5254 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5255
8547b010
EZ
52562011-10-19 Eli Zaretskii <eliz@gnu.org>
5257
5258 * xdisp.c (start_display): If the character at POS is displayed
5259 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5260 (try_window_reusing_current_matrix): If a line ends in a display
5261 vector or the next line starts in a display vector, continue
5262 redrawing the window even though the character position of
5263 start_row was reached.
8547b010
EZ
5264 (Bug#9771, part 2)
5265
4e948d15
CY
52662011-10-18 Chong Yidong <cyd@gnu.org>
5267
5268 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5269 with nobreak-char-display too.
5270
4787455f
EZ
52712011-10-18 Eli Zaretskii <eliz@gnu.org>
5272
5273 Fix part 3 of bug#9771.
5274 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5275 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5276 non-neutral characters if the current character is a paragraph
5277 separator (a.k.a. Newline). This avoids running the same
5278 expensive loop twice, once when we consume the preceding newline
5279 and the other time when the line actually needs to be displayed.
5280 Avoid the loop when we see neutrals on the base embedding level
5281 following a character whose directionality is the same as the
5282 paragraph's. This avoids running the expensive loop when a line
5283 ends in a long sequence of neutrals, like control characters.
5284 Add assertion against STRONG_AL type. Slightly rearrange code
5285 that determines the type of a neutral given the first non-neutral
5286 that follows it.
5287 (bidi_level_of_next_char): Set next_en_pos to zero when
5288 invalidating its info.
5289
2c91f553
EZ
52902011-10-17 Eli Zaretskii <eliz@gnu.org>
5291
5292 * xdisp.c (push_display_prop): Determine whether to record string
5293 or buffer position by IT->string, not by IT->method. Allow
5294 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5295 (move_it_vertically_backward): Don't look for character position
5296 immediately after the newline when in a continuation line.
5297 (Bug#9771, part 1)
2c91f553 5298
c7b08b0d
MR
52992011-10-15 Martin Rudalics <rudalics@gmx.at>
5300
5301 * window.c (coordinates_in_window): Rewrite and delabelize
5302 vertical border check. (Bug#5357) (Bug#9618)
5303
6b02f655
SM
53042011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5305
5306 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5307 errors in XSetWindowBorder (bug#9310).
5308
81d40c92
DA
53092011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5310
5311 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5312 avoid crash when xmalloc overrun checking is enabled.
5313
d4172c3b
EZ
53142011-10-13 Eli Zaretskii <eliz@gnu.org>
5315
5316 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5317 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5318 cursor motion with <left> and <right> arrow keys.
5319
5320 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5321 some callers set that themselves.
5322
b00eea75
EZ
53232011-10-12 Eli Zaretskii <eliz@gnu.org>
5324
5325 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5326 display string and the previous row comes from the same string and
5327 is empty. (Bug#9739) (Bug#9738)
5328
8fe012c4
SM
53292011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5330
5331 * doc.c (get_doc_string): Encode file name (bug#9735).
5332
0074aef2
EZ
53332011-10-12 Eli Zaretskii <eliz@gnu.org>
5334
79beb178
EZ
5335 * bidi.c (bidi_level_of_next_char):
5336 * xdisp.c (get_visually_first_element): Remove old incorrect
5337 comments regarding the Unicode Line Separator character.
5338
0074aef2
EZ
5339 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5340
6e4b3fbe
DA
53412011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5342
5343 * alloc.c (Fgc_status): Do not access beyond zombies array
5344 boundary if nzombies > MAX_ZOMBIES.
5345 * alloc.c (dump_zombies): Add missing format specifier.
5346
0324f3af
PE
53472011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5348
b5525cac
PE
5349 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5350 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5351
0324f3af
PE
5352 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5353 Some packages use them to denote characters with modifiers.
5354
e9b5f888
AS
53552011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5356
5357 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5358 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5359 matching a pp-number. Rename parameter var to var1.
5360
127827c0
SM
53612011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5362
5363 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5364
c8fd3bd0
GM
53652011-10-08 Glenn Morris <rgm@gnu.org>
5366
5367 * callint.c (Fcall_interactively): Give a more explicit error for the
5368 'c' case with a non-character input. (Bug#8479)
5369
352ec8ff
EZ
53702011-10-08 Eli Zaretskii <eliz@gnu.org>
5371
03669ccb
EZ
5372 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5373 lines.
7061c986
EZ
5374 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5375 lines that are hscrolled on the left.
03669ccb 5376
352ec8ff
EZ
5377 * dispnew.c (buffer_posn_from_coords): Account for a possible
5378 presence of header-line. (Bug#4426)
5379
a66cfb1c
SM
53802011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5381
6b02f655
SM
5382 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5383 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5384
7c5ee88e
PE
53852011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5386
5387 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5388 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5389 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5390 this makes Emacs dump core during garbage collection on rare
5391 occasions. sizeof is obviously inferior to offsetof here, so
5392 stick with offsetof.
5393 (GC_POINTER_ALIGNMENT): New macro.
5394 (mark_memory): Omit 3rd (offset) arg; caller changed.
5395 Don't assume EMACS_INT alignment is the same as pointer alignment.
5396
df1bbe5b
SM
53972011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5398
5399 * keyboard.c (read_key_sequence_remapped): New var.
5400 (read_key_sequence): Compute remapping in the right buffer.
5401 (command_loop_1): Use read_key_sequence's remapping directly.
5402
51553db6
SM
54032011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5404
32c1fffd
SM
5405 * dired.c (file_name_completion): Don't expand file name.
5406 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5407 before checking file name handler.
5408
51553db6
SM
5409 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5410 they've been requested explicitly (bug#9591).
5411
b6bd1599 54122011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5413
5414 * keymap.c (Fsingle_key_description): Use make_specified_string
5415 instead of build_string to build string from push_key_description.
5416 (Bug#5193)
5417
f701dc2a
PE
54182011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5419
4222c55d
PE
5420 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5421 This fixes a Y2038 bug on 64-bit hosts.
5422 * buffer.c (reset_buffer):
5423 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5424 (Fclear_buffer_auto_save_failure):
5425 Use 0, not -1, to represent an unset failure time, since time_t
5426 might not be signed.
5427
f701dc2a
PE
5428 Remove dependency on glibc malloc internals.
5429 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5430 Move back here from lisp.h, but with their new implementations.
5431 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5432 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5433 * charset.c (charset_table_init): New static var.
5434 (syms_of_charset): Use it instead of xmalloc. This removes a
5435 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5436 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5437 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5438 Move back to alloc.c.
5439 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5440 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5441
9ceebf39
JD
54422011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5443
5444 * nsterm.m (windowDidResize): Call x_set_window_size only when
5445 ns_in_resize is true. Otherwise set pixelwidth/height and
5446 call change_frame_size (Bug#9628).
5447
cb993c58
PE
54482011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5449
3930c88b
PE
5450 Port --enable-checking=all to Fedora 14 x86-64.
5451 * charset.c (syms_of_charset): Also account for glibc malloc's
5452 internal overhead when calculating the initial malloc maximum.
5453
cb993c58
PE
5454 Port --enable-checking=all to Fedora 14 x86.
5455 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5456 Move to lisp.h.
5457 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5458 (overrun_check_realloc, overrun_check_free):
5459 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5460 That way, xmalloc returns a properly-aligned pointer even if
5461 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5462 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5463 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5464 into account when calculating the initial malloc maximum.
5465 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5466 Move here from alloc.c, so that charset.c can use it too.
5467 Properly align; the old code wasn't right for common 32-bit hosts
5468 when configured with --enable-checking=all.
5469 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5470 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5471
31bed486
EZ
54722011-09-29 Eli Zaretskii <eliz@gnu.org>
5473
04c70788 5474 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5475 use EDOM.
5476
fbcaa2f3
EZ
54772011-09-28 Eli Zaretskii <eliz@gnu.org>
5478
5479 * xdisp.c (compute_display_string_end): If there's no display
5480 string at CHARPOS, return -1.
5481
5482 * bidi.c (bidi_fetch_char): When compute_display_string_end
5483 returns a negative value, treat the character as a normal
5484 character not covered by a display string. (Bug#9624)
5485
a239d4e9
JB
54862011-09-28 Juanma Barranquero <lekktu@gmail.com>
5487
5488 * lread.c (Fread_from_string): Fix typo in docstring.
5489
88652fd5
EZ
54902011-09-27 Eli Zaretskii <eliz@gnu.org>
5491
5492 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5493 newline, reseat the iterator instead of bidi-iterating there one
5494 character at a time. (Bug#9610)
32c1fffd
SM
5495 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5496 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5497
ed497dd4
AS
54982011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5499
5500 * lread.c (readevalloop): Use correct code for NBSP.
5501 (read1): Likewise. (Bug#9608)
5502
b2bf61aa
MA
55032011-09-25 Michael Albinus <michael.albinus@gmx.de>
5504
5505 * dbusbind.c (Fdbus_register_signal): When service is not
5506 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5507
32bbb17c
GM
55082011-09-25 Glenn Morris <rgm@gnu.org>
5509
5510 * buffer.c (truncate-lines): Doc fix.
5511
94e0933e
CY
55122011-09-24 Chong Yidong <cyd@stupidchicken.com>
5513
5514 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5515 (Fset_window_next_buffers): Doc fix.
5516
cddde921
GM
55172011-09-24 Glenn Morris <rgm@gnu.org>
5518
5519 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5520
1260aef1
PE
55212011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5522
25b4bfa0
PE
5523 Fix minor problems found by static checking.
5524 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5525 * indent.c (Fvertical_motion): Fix == vs = typo.
5526
e3cbd34b
EZ
55272011-09-24 Eli Zaretskii <eliz@gnu.org>
5528
a66cfb1c
SM
5529 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5530 Default value is now t. Doc fix.
6bf7006f 5531
e3cbd34b 5532 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5533 logic when moving up, not only when moving down. Fix the
e3cbd34b 5534 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5535 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5536
5537 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5538 CHARPOS is covered by a display string which includes newlines.
5539 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5540 is covered by a display string with embedded newlines.
5541
a3de0cbd
MA
55422011-09-24 Michael Albinus <michael.albinus@gmx.de>
5543
5544 * dbusbind.c (Fdbus_register_signal): Add match rule to
5545 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5546 (Fdbus_register_method, Vdbus_registered_objects_table):
5547 Fix docstring.
a3de0cbd 5548
b260039d
JM
55492011-09-24 Jim Meyering <meyering@redhat.com>
5550
32c1fffd 5551 do not ignore write error for any output size
b260039d
JM
5552 The previous change was incomplete.
5553 While it makes emacs --batch detect the vast majority of stdout
5554 write failures, errors were still ignored whenever the output size is
5555 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5556 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5557 && echo FAIL: ignored write error
5558 FAIL: ignored write error
5559 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5560 && echo FAIL: ignored write error
5561 FAIL: ignored write error
5562 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5563
8eca8a7c
AS
55642011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5565
5566 * emacs.c (Fkill_emacs): In noninteractive mode exit
5567 non-successfully if a write error occurred on stdout. (Bug#9574)
5568
3341db62
EZ
55692011-09-21 Eli Zaretskii <eliz@gnu.org>
5570
5571 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5572 the xassert test.
5573
5574 * dispextern.h (struct it): Update the comment documenting what
5575 can it->OBJECT be.
5576
8c203dbf
EZ
55772011-09-20 Eli Zaretskii <eliz@gnu.org>
5578
5579 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5580 a display string, extend search for cursor position to end of row.
5581 (find_row_edges): If the row ends in a newline from a display
5582 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5583 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5584 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5585 non-empty line. Fixes confusing cursor motion with arrow keys at
5586 the beginning of a line that starts with whitespace.
8c203dbf 5587
a4824228
LMI
55882011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5589
5590 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5591 (bug#9493).
5592
33ed493b
CY
55932011-09-18 Chong Yidong <cyd@stupidchicken.com>
5594
5595 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5596 boolean (Bug#9154).
5597
56cd55c8
EZ
55982011-09-18 Eli Zaretskii <eliz@gnu.org>
5599
5600 * xdisp.c (display_line): Record maximum and minimum buffer
5601 positions even if no glyphs were produced (e.g., by a zero-width
5602 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5603 buffer positions that will be removed from the glyph row because
5604 they don't fit.
c02dcedf
EZ
5605 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5606 column is beyond frame width: don't subtract 1 "pixel" when
5607 computing width of the stretch.
3e62b7e0
EZ
5608 (reseat_at_next_visible_line_start): Undo the change made on
5609 2011-09-17 that saved paragraph information and restored it after
5610 the call to `reseat'. (Bug#9545)
56cd55c8 5611
5ed99d36 56122011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5613
5614 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5615 and turn window cursor on if cleared (Bug#9415).
5616
5ed99d36 56172011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5618
5619 * search.c (boyer_moore): Take unibyte characters from pattern
5620 literally. (Bug#9458)
5621
9bade7b2
EZ
56222011-09-18 Eli Zaretskii <eliz@gnu.org>
5623
5624 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5625
e5e9d610
PE
56262011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5627
87e4427a
PE
5628 Fix minor problem found by static checking.
5629 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5630 initialized, to pacify gcc -Wuninitialized.
5631
e5e9d610
PE
5632 * fileio.c: Report proper errno when syscall falls.
5633 (Finsert_file_contents): Save and restore errno,
5634 so that report_file_error outputs the correct diagnostic.
5635 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5636
a1674f0b
EZ
56372011-09-18 Eli Zaretskii <eliz@gnu.org>
5638
5639 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5640
fbfb6dd4
EZ
56412011-09-17 Eli Zaretskii <eliz@gnu.org>
5642
5643 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5644 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5645
bb187662
EZ
56462011-09-17 Eli Zaretskii <eliz@gnu.org>
5647
1137e8b8 5648 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5649 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5650
5651 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5652 (bidi_find_paragraph_start): Search back for paragraph beginning
5653 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5654 (bidi_move_to_visually_next): Only trigger paragraph-related
5655 computations when the last character is a newline or at EOB, not
5656 just any NEUTRAL_B. (Bug#9470)
5657
bb187662
EZ
5658 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5659 truncated lines if point is covered by a display string. (Bug#9524)
5660
2e621251
PE
56612011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5662
5663 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5664 (cons_to_x_long): New function.
5665 (lisp_data_to_selection_data): Use it. Correct the test for
5666 short-versus-long data; it was negated. Break out of vector
5667 loop, for efficiency, when a long datum is discovered.
5668
91a15bc6
SM
56692011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5670
5671 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5672
b41c3a35
EZ
56732011-09-16 Eli Zaretskii <eliz@gnu.org>
5674
5675 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5676 GCC PR/17406) by declaring this function with external scope.
5677
7812ba2d
PE
56782011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5679
5680 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5681 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5682
cf7edc2a
AS
56832011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5684
5685 * editfns.c (Fformat): Correctly handle text properties on "%%".
5686
bd01620e
EZ
56872011-09-15 Eli Zaretskii <eliz@gnu.org>
5688
5689 * xterm.c (x_draw_composite_glyph_string_foreground):
5690 * w32term.c (x_draw_composite_glyph_string_foreground):
5691 * term.c (encode_terminal_code):
5692 * composite.c (composition_update_it, get_composition_id):
5693 * xdisp.c (get_next_display_element)
5694 (fill_composite_glyph_string): Add comments about special meaning
5695 of TAB characters in a composition.
5696
a02719a3
PE
56972011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5698
5699 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5700 This occurs when processing a multibyte format.
5701 Problem reported by Wolfgang Jenker.
a02719a3 5702
72589a3c
JB
57032011-09-15 Johan Bockgård <bojohan@gnu.org>
5704
5705 * xdisp.c (try_cursor_movement): Only check for exact match if
5706 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5707
1c14176c
PE
57082011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5709
5710 Remove unused external symbols.
5711 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5712 * xdisp.c (calc_pixel_width_or_height): Now static.
5713 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5714 * indent.c (check_display_width):
5715 * w32term.c: Fix comment to match code.
5716 * xterm.c, xterm.h (x_catching_errors): Remove.
5717
d2eea5b5
PE
57182011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5719
5720 * xselect.c: Use signed conversions more consistently (Bug#9498).
5721 (selection_data_to_lisp_data): Assume incoming selection data are
5722 signed integers, not unsigned. This is to be consistent with
5723 outgoing selection data, which was modified to use signed integers
5724 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5725 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5726 expects long, not unsigned long.
5727
46888499
EZ
57282011-09-14 Eli Zaretskii <eliz@gnu.org>
5729
5730 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5731 computation of loop end. Reported by Johan Bockgård
5732 <bojohan@gnu.org>.
5733
ef8ef9fb
CY
57342011-09-13 Chong Yidong <cyd@stupidchicken.com>
5735
5736 * frame.c (Fother_visible_frames_p): Function deleted.
5737
fa819fed
EZ
57382011-09-12 Eli Zaretskii <eliz@gnu.org>
5739
5740 * indent.c (compute_motion): Process display vector front to back
5741 rather than the other way around. (Bug#2496)
5742
2ba8e008
SM
57432011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5744
5745 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5746
20f53c69
CY
57472011-09-11 Chong Yidong <cyd@stupidchicken.com>
5748
5749 * minibuf.c (Fread_from_minibuffer): Doc fix.
5750
d562d7a4
EZ
57512011-09-11 Eli Zaretskii <eliz@gnu.org>
5752
5753 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5754 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5755
1c4d7f3d
LMI
57562011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5757
5758 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5759 value for non-existent files.
5760
b885bf36
EZ
57612011-09-11 Eli Zaretskii <eliz@gnu.org>
5762
5763 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5764 set its "size" to -1. This will set the modtime_size field of
5765 the corresponding buffer to -1, which is what
5766 verify-visited-file-modtime expects for files that do not exist.
5767 (Bug#9139)
5768
6612f0bf
PE
57692011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5770
5771 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5772 here ...
5773 * lisp.h: ... from here. push_key_description is no longer
5774 defined in keyboard.c, so its declaration should not be in
5775 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5776 logically belongs with push_key_description.
5777
dfb3f755
PE
57782011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5779
5780 * buffer.h: Include <sys/types.h> instead of <time.h>.
5781 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5782 Problem reported by Herbert J. Skuhra.
5783
3134906c
LMI
57842011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5785
5786 * xml.c (parse_region): Make the parsing work for
5787 non-comment-starting XML files again (bug#9144).
5788
8d903f4e
AS
57892011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5790
5791 * image.c (gif_load): Fix calculation of bottom and right corner.
5792 (Bug#9468)
5793
80ad64f4
EZ
57942011-09-10 Eli Zaretskii <eliz@gnu.org>
5795
5796 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5797 redisplay in small windows.
5798
208a048d
EZ
57992011-09-09 Eli Zaretskii <eliz@gnu.org>
5800
5801 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5802
9b1c252e
MR
58032011-09-08 Martin Rudalics <rudalics@gmx.at>
5804
5805 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5806 Operate on live windows only.
5807
2949f33b
JB
58082011-09-08 Juanma Barranquero <lekktu@gmail.com>
5809
5810 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5811
e08dcafd
EZ
58122011-09-07 Eli Zaretskii <eliz@gnu.org>
5813
5814 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5815 only under bidi iteration.
5816
115b96bd
JD
58172011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5818
5819 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5820
c8199d0f
PE
58212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5822
5823 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5824 Without this fix, the command to link temacs failed due to an
5825 undefined symbol __builtin_isnan. This is because
5826 /usr/include/iso/math_c99.h #defines isnan(x) to
5827 __builtin_isnan(x), but the bundled gcc, which identifies itself
5828 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5829 a __builtin_isnan.
5830 * floatfns.c (isnan): #undef, and then #define to a clone of
5831 what's in data.c.
5832 (Fisnan): Always define, since it's always available now.
5833 (syms_of_floatfns): Always define isnan at the Lisp level.
5834
e39b275c 58352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5836
5837 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5838
b2db44d9 58392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5840
f4af5137 5841 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5842 The previous code assumed that file offsets (off_t values) fit in
5843 EMACS_INT variables, which is not true on typical 32-bit hosts.
5844 The code messed up by falsely reporting buffer overflow in cases
5845 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5846 when "big" contains more than 2**29 bytes, even though this
5847 inserts just one byte and does not overflow the buffer.
5848 (Finsert_file_contents): Store file offsets as off_t
5849 values, not as EMACS_INT values. Check for overflow when
5850 converting between EMACS_INT and off_t. When checking for
5851 buffer overflow or for overlap, take the offsets into account.
5852 Don't use EMACS_INT for small values where int suffices.
5853 When checking for overlap, fix a typo: ZV was used where
5854 ZV_BYTE was intended.
5855 (Fwrite_region): Don't assume off_t fits into 'long'.
5856 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5857
ecfc0a49
MA
58582011-09-05 Michael Albinus <michael.albinus@gmx.de>
5859
5860 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5861
6511acf2 58622011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5863
0999621a 5864 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5865
5866 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5867 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5868 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5869 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5870 (modify_event_symbol): Do not assume that the length of
5871 name_alist_or_stem is safe to alloca and fits in int.
5872 (Fexecute_extended_command): Likewise for function name and binding.
5873 (Frecursion_depth): Wrap around reliably on integer overflow.
5874 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5875 since some callers pass EMACS_INT values.
5876 (Fsingle_key_description): Don't crash if symbol name contains more
5877 than MAX_ALLOCA bytes.
5878 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5879 (get_minibuffer): Arg is now EMACS_INT, not int.
5880 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5881 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5882 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5883
2be7d702
PE
5884 * dbusbind.c (signature_cat): New function.
5885 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5886 Do not overrun buffer; instead, report string overflow.
5887
9d1df220
PE
5888 * dispnew.c (add_window_display_history): Don't overrun buffer.
5889 Truncate instead; this is OK since it's just a log.
5890
33ef5c64
PE
5891 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5892 even if the time zone offset is outlandishly large.
5893 Don't mishandle offset == INT_MIN.
5894
66c6fdd5
PE
5895 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5896 when creating daemon; the previous buffer-overflow check was incorrect.
5897
d749b01b
PE
5898 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5899 which has the guts of the old verror function.
5900
b5cd1905
PE
5901 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5902 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5903
6e1a67fb
PE
5904 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5905 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5906 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5907 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5908 length of string rather than counting it via multiple sprintfs;
5909 that's simpler and more reliable.
c21721cc
PE
5910 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5911 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5912 sprintf, in case result does not fit in int.
5913
c57b67fc
PE
5914 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5915 (fontset_from_font): Print it.
5916
8a401434
PE
5917 * frame.c (tty_frame_count): Now printmax_t, not int.
5918 (make_terminal_frame, set_term_frame_name): Print it.
5919 (x_report_frame_params): In X, window IDs are unsigned long,
5920 not signed long, so print them as unsigned.
5921 (validate_x_resource_name): Check for implausibly long names,
5922 and don't assume name length fits in 'int'.
5923 (x_get_resource_string): Don't blindly alloca invocation name;
5924 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5925 not fit in int.
5926
6e1a67fb
PE
5927 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5928 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5929 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5930
0df02bf3
PE
5931 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5932 Use esprintf, not sprintf, in case result does not fit in int.
5933
48e30793
PE
5934 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5935 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5936 it as a large positive number.
5937 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5938 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5939
a66ff6d8
PE
5940 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5941 in case result does not fit in int.
5942
aca216ff
PE
5943 * print.c (float_to_string): Detect width overflow more reliably.
5944 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5945 buffer overrun. Don't assume list length fits in 'int'. Treat
5946 print length of 0 as 0, not as infinity; to be consistent with other
5947 uses of print length in this function. Don't overflow print length
5948 index. Don't assume hash table size fits in 'long', or that
5949 vectorlike size fits in 'unsigned long'.
5950
31c286f7
PE
5951 * process.c (make_process): Use printmax_t, not int, to format
5952 process-name gensyms.
5953
55e5faa1
PE
5954 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5955
80f2e268
PE
5956 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5957 to avoid potential buffer overrun.
5958
670741ab
PE
5959 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5960 if X resource line is longer than 512 bytes.
5961
b7163a50
PE
5962 * xfns.c (x_window): Make sprintf buffer a bit bigger
5963 to avoid potential buffer overrun.
5964
ae58ff1f
PE
5965 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5966
c43c8a6a
PE
5967 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5968
3f8236f4
PE
59692011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5970
53e9fe90 5971 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5972 Without these, Emacs silently mishandles large integers sometimes.
5973 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5974 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5975
6511acf2
PE
5976 * xdisp.c (try_window_id): Check Emacs fixnum range before
5977 converting to 'int'.
806add1d 5978
6511acf2 5979 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5980 Check that an Emacs fixnum is in range before assigning it to 'int'.
5981 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5982 values converted from Emacs fixnums.
5983 (Frecenter): Don't wrap around a line count if it is out of 'int'
5984 range; instead, treat it as an extreme value.
5985 (Fset_window_configuration, compare_window_configurations):
5986 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5987
6511acf2
PE
5988 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5989 that can exceed INT_MAX. Check that EMACS_INT value is in range
5990 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5991 (match_limit): Don't assume that a fixnum can fit in 'int'.
5992
6511acf2 5993 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5994 exceed INT_MAX.
5995
6511acf2 5996 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5997 (Fvertical_motion): Don't wrap around LINES values that don't fit
5998 in 'int'. Instead, treat them as extreme values. This is good
5999 enough for windows, which can't have more than INT_MAX lines anyway.
6000
fcb901a7
LMI
60012011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6002
0f2f6b6d
LMI
6003 * Require libxml/parser.h to avoid compilation warning.
6004
fcb901a7
LMI
6005 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6006
6007 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6008 since this reportedly can destroy thread storage.
6009
6e20a0d4
CY
60102011-08-30 Chong Yidong <cyd@stupidchicken.com>
6011
6012 * syntax.c (find_defun_start): Update all cache variables if
6013 exiting early (Bug#9401).
6014
148ae00e
EZ
60152011-08-30 Eli Zaretskii <eliz@gnu.org>
6016
f6cfbd8f
EZ
6017 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6018
148ae00e
EZ
6019 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6020 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6021 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6022
6023 * term.c (tty_append_glyph): New function.
6024 (produce_stretch_glyph): Static function and its prototype deleted.
6025
a66cfb1c
SM
6026 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6027 Add prototypes.
148ae00e 6028
c4a07a4c
PE
60292011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6030
6031 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6032 when checking :margin (Bug#9390).
6033 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6034 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6035 so that the name doesn't mislead. All uses changed.
6036
6bc8cd65
JB
60372011-08-28 Johan Bockgård <bojohan@gnu.org>
6038
6039 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6040 set_tty_hooks.
6041
dca4927e
EZ
60422011-08-27 Eli Zaretskii <eliz@gnu.org>
6043
6044 * xdisp.c (move_it_to): Don't bail out early when reaching
6045 position beyond to_charpos, if we are scanning backwards.
6046 (move_it_vertically_backward): When DY == 0, make sure we get to
6047 the first character in the line after the newline.
6048
f2cad773
PE
60492011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6052 (ccl_driver): Do not generate an out-of-range pointer.
6053 (Fccl_execute_on_string): Remove unnecessary check for
6054 integer overflow, noted by Stefan Monnier in
6055 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6056 Remove a FIXME that didn't need fixing.
6057 Simplify the newly-introduced buffer reallocation code.
6058
0cae2cdb
JB
60592011-08-27 Juanma Barranquero <lekktu@gmail.com>
6060
6061 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6062
5fc295a4 60632011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6064
70c60eb2 6065 Integer and memory overflow issues (Bug#9196).
726e0ab1 6066
d31850da
PE
6067 * doc.c (get_doc_string): Rework so that
6068 get_doc_string_buffer_size is the actual buffer size, rather than
6069 being 1 less than the actual buffer size; this makes xpalloc more
6070 convenient.
6071
a69fbedb
PE
6072 * image.c (x_allocate_bitmap_record, cache_image):
6073 * xselect.c (Fx_register_dnd_atom):
6074 Simplify previous changes by using xpalloc.
6075
fe5c5d37
PE
6076 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6077 since either will do and ptrdiff_t is convenient with xpalloc.
6078
0065d054
PE
6079 * charset.c (charset_table_size)
6080 (struct charset_sort_data.priority): Now ptrdiff_t.
6081 (charset_compare): Don't overflow if priorities differ greatly.
6082 (Fsort_charsets): Don't assume list length fits in int.
6083 Check for size-calculation overflow when allocating sort data.
6084 (syms_of_charset): Allocate an initial charset table that is
6085 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6086
6087 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6088
6089 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6090 The actual value is always <= INT_MAX, and leaving it unsigned made
6091 overflow checking harder.
6092
6093 * dispextern.h (struct glyph_matrix.rows_allocated)
6094 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6095 with xpalloc. The values are still always <= INT_MAX.
6096
6097 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6098
6099 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6100 (SAFE_NALLOCA): New macro.
6101
6102 * region-cache.c (struct boundary.pos, find_cache_boundary)
6103 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6104 (set_cache_region, invalidate_region_cache)
6105 (revalidate_region_cache, know_region_cache, region_cache_forward)
6106 (region_cache_backward, pp_cache):
6107 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6108 so that ptrdiff_t * can be passed to xpalloc.
6109 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6110 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6111 (pp_cache): Don't assume cache_len fits in int.
6112 * region-cache.h: Adjust extern decls to match.
6113
6114 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6115 EMACS_INT, since either will do, for xpalloc.
6116
6117 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6118 (xnmalloc, xnrealloc, xpalloc): New functions.
6119
726e0ab1
PE
6120 * bidi.c (bidi_shelve_header_size): New constant.
6121 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6122 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6123
51f30bc5 6124 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6125 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6126 (overlay_strings):
6127 Don't update size of array until after memory allocation succeeds,
6128 because xmalloc/xrealloc may not return.
0065d054
PE
6129 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6130 now that we have proper integer overflow checking.
6131 (record_overlay_string, overlay_strings): Catch overflows when
6132 calculating size of overlay_str_buf.
726e0ab1 6133
0065d054
PE
6134 * callproc.c (Fcall_process): Check for size overflow when
6135 calculating size of args2.
6136 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6137 Normally we prefer signed values, but sticking with ptrdiff_t would
6138 require adding more-complicated checks.
726e0ab1
PE
6139
6140 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6141 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6142 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6143 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6144
6145 * character.c (Fstring): Check for size-calculation overflow.
6146
6147 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6148 unnecessary integer overflow. Check for size overflow.
6149 (encode_coding_object): Don't update size until xmalloc succeeds.
6150
6151 * composite.c (get_composition_id): Check for overflow in glyph
6152 length calculations.
6153
6154 Integer and memory overflow fixes for display code.
6155 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6156 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6157 (scrolling_window): Check for overflow in size calculations.
6158 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6159 Don't assume glyph table len fits in int.
6160 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6161 (row_table_size): Now ptrdiff_t, not int.
6162 (scrolling_window): Avoid overflow in size calculations.
6163 Don't update size until allocation succeeds.
6164 * fns.c (concat): Check for overflow in size calculations.
6165 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6166 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6167 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6168
6169 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6170 (get_doc_string): Check for size calculation overflow.
6171 Don't update size until allocation succeeds.
6172 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6173 EMACS_INT, where ptrdiff_t will do.
6174 (Fsubstitute_command_keys): Check for string overflow.
6175
6176 * editfns.c (set_time_zone_rule): Don't assume environment length
6177 fits in int.
6178 (message_length): Now ptrdiff_t, not int.
6179 (Fmessage_box): Don't update size until allocation succeeds.
6180 Don't assume message length fits in int.
6181 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6182
0065d054
PE
6183 * emacs.c (main): Do not reallocate argv, since there is a null at
6184 the end that can be overwritten, and this way there's no need to
6185 worry about size-calculation overflow.
6186 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6187
6188 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6189 alloc succeeds.
6190 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6191
6192 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6193 (x_set_scroll_bar_width, x_figure_window_size):
6194 Check for integer overflow.
6195 (x_set_alpha): Do not assume XINT fits in int.
6196
6197 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6198 This is for the members text_lines, text_cols, total_lines, total_cols,
6199 where the system imposes an 'int' limit.
6200
6201 * fringe.c (Fdefine_fringe_bitmap):
6202 Don't update size until alloc works.
6203
6204 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6205 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6206
6207 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6208 Check for size-calculation overflow.
6209 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6210 do, as we prefer signed integers.
6211 (id_to_widget.max_size, id_to_widget.used)
6212 (xg_store_widget_in_map, xg_remove_widget_from_map)
6213 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6214 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6215 Use and return ptrdiff_t, not int.
6216 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6217 * gtkutil.h: Change prototypes to match the above.
6218
6219 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6220 are duplicate now that they've been promoted to lisp.h.
6221 (x_allocate_bitmap_record, x_alloc_image_color)
6222 (make_image_cache, cache_image, xpm_load):
6223 Don't update size until alloc is done.
6224 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6225 (x_detect_edges):
3256efce 6226 Check for size calculation overflow.
726e0ab1
PE
6227 (ct_colors_allocated_max): New constant.
6228 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6229 overflow.
3256efce 6230
726e0ab1
PE
6231 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6232 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6233 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6234 Use ptrdiff_t, not int, to count maps.
6235 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6236 calculations. Don't update size until allocation succeeds.
6237 Redo calculations to avoid overflow.
726e0ab1
PE
6238 * keyboard.h: Change prototypes to match the above.
6239
6240 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6241 to count maps.
6242 (current_minor_maps): Check for size calculation overflow.
6243 * keymap.h: Change prototypes to match the above.
6244
6245 * lread.c (read1, init_obarray): Don't update size until alloc done.
6246
6247 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6248 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6249
726e0ab1
PE
6250 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6251 Now ptrdiff_t, not int.
6252 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6253 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6254
6255 * process.c (Fnetwork_interface_list): Check for overflow
6256 in size calculation.
6257
6258 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6259
6260 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6261 overflow. Don't bother calling xmalloc when xrealloc will do.
6262
6263 * search.c (Freplace_match): Check for size calculation overflow.
6264 (Fset_match_data): Don't assume list lengths fit in 'int'.
6265
6266 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6267 for command line length. Do not attempt to address one before the
6268 beginning of an array, as that's not portable.
6269
6270 * term.c (max_frame_lines): Remove; unused.
6271 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6272 not int.
6273 (encode_terminal_code, calculate_costs): Check for size
6274 calculation overflow.
6275 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6276 table lengths and related sizes. Don't update size until alloc
6277 done. Redo calculations to avoid overflow.
6278 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6279
6280 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6281 subtracting pointers.
6282 (gobble_line): Check for overflow more carefully. Don't update size
6283 until alloc done.
6284
6285 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6286 Don't update size until alloc done.
6287 Redo size calculations to avoid overflow.
6288 Check for size calculation overflow.
0065d054 6289 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6290
6291 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6292 Use ptrdiff_t, not int, for sizes.
6293 (store_mode_line_noprop_char): Don't update size until alloc done.
6294
0065d054
PE
6295 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6296 Use ptrdiff_t, not int, for sizes.
6297 (Finternal_make_lisp_face, cache_face):
6298 Check for size calculation overflow.
6299 (cache_face): Treat size calculation overflows as if they were
6300 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6301
6302 * xfns.c (x_encode_text, x_set_name_internal)
6303 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6304 sizes, since they can exceed INT_MAX in size. Check for size
6305 calculation overflow.
6306
0065d054
PE
6307 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6308 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6309 Don't update size until alloc done.
6310
0065d054 6311 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6312 as sprintf is limited to int lengths.
1d526e2f 6313
252c5ee1
PE
6314 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6315 (X_LONG_MIN): New macros.
864d7ce7
PE
6316 Use them to make the following changes clearer.
6317 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6318 This change doesn't affect the value now, but it may help remind
6319 future maintainers not to raise the value too much later.
6320 (SELECTION_QUANTUM): Remove, replacing with ...
6321 (selection_quantum): ... new function, which avoids overflow.
6322 All uses changed.
6323 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6324 assumption that selection length fits in 'int'.
6325 (x_reply_selection_request, x_handle_selection_request)
6326 (x_get_window_property, receive_incremental_selection)
6327 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6328 (lisp_data_to_selection_data, clean_local_selection_data):
6329 Use ptrdiff_t, not int, to record length of selection.
6330 (x_reply_selection_request, x_get_window_property)
6331 (receive_incremental_selection, x_property_data_to_lisp):
6332 Redo calculations to avoid overflow.
6333 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6334 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6335 something.
6336 (x_get_window_property, receive_incremental_selection)
6337 (lisp_data_to_selection_data, x_property_data_to_lisp):
6338 Check for size-calculation overflow.
6339 (x_get_window_property, receive_incremental_selection)
6340 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6341 Don't store size until memory allocation succeeds.
6342 (x_get_window_property): Plug memory leak on memory exhaustion.
6343 Don't double-block input; malloc is safe here. Don't assume 2**34
6344 - 4 fits in unsigned long. Add an xassert to check
6345 XGetWindowProperty overflow. Be more careful about overflow
6346 calculations, and distinguish size from memory overflow better.
6347 (receive_incremental_selection): When tracing, don't assume
6348 unsigned int is less than INT_MAX.
6349 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6350 harmful) conversions of unsigned short to int.
6351 (lisp_data_to_selection_data): Don't assume that integers
6352 in the range -65535 through -1 fit in an X unsigned short.
6353 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6354 result parameters unless successful. Rely on cons_to_unsigned
6355 to report problems with elements; the old code wasn't right anyway.
6356 (x_check_property_data): Check for int overflow; we cannot use
6357 a wider type due to X limits.
6358 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6359
726e0ab1 6360 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6361
0065d054
PE
6362 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6363 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6364 (x_color_cells): Don't store size until memory allocation succeeds.
6365 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6366 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6367 (x_term_init): Don't assume length fits in int (sprintf is limited
6368 to int size).
bc18e09d 6369
ebfa62c0
PE
6370 Use ptrdiff_t for composition IDs.
6371 * character.c (lisp_string_width):
6372 * composite.c (composition_table_size, n_compositions)
6373 (get_composition_id, composition_gstring_from_id):
6374 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6375 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6376 * window.c (Frecenter):
6377 Use ptrdiff_t, not int, for composition IDs.
6378 * composite.c (get_composition_id): Check for integer overflow.
6379 * composite.h: Adjust prototypes to match the above changes.
6380
d3411f89
PE
6381 Use ptrdiff_t for hash table indexes.
6382 * category.c (hash_get_category_set):
6383 * ccl.c (ccl_driver):
6384 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6385 * coding.c (coding_system_charset_list, detect_coding_system):
6386 * coding.h (struct coding_system.id):
6387 * composite.c (get_composition_id, gstring_lookup_cache):
6388 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6389 * image.c (xpm_get_color_table_h):
6390 * lisp.h (hash_lookup, hash_put):
6391 * minibuf.c (Ftest_completion):
6392 Use ptrdiff_t for hash table indexes, not int (which is too
6393 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6394 32-bit --with-wide-int hosts).
6395
e097a6fa
PE
6396 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6397 Add a FIXME comment about memory leaks.
6398 (syms_of_charset): Don't assume xmalloc returns.
6399
5637687f
PE
6400 Don't assume that stated character widths fit in int.
6401 * character.c (Fchar_width, c_string_width, lisp_string_width):
6402 * character.h (CHAR_WIDTH):
6403 * indent.c (MULTIBYTE_BYTES_WIDTH):
6404 Use sanitize_char_width to avoid undefined and/or bad behavior
6405 with outlandish widths.
a66cfb1c 6406 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6407 now that we have two such functions. All uses changed.
6408 (sanitize_char_width): New inline function.
6409
a2271ba2
PE
6410 Don't assume that tab-width fits in int.
6411 * character.h (sanitize_width): New inline function.
6412 (SANE_TAB_WIDTH): New macro.
6413 (ASCII_CHAR_WIDTH): Use it.
6414 * indent.c (sane_tab_width): Remove. All uses replaced by
6415 SANE_TAB_WIDTH (current_buffer).
6416 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6417
18c52557
PE
6418 * fileio.c: Integer overflow issues with file modes.
6419 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6420
caeeedc1
PE
6421 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6422 Remove unreachable code.
6423 (read_hex, load_charset_map_from_file): Check for integer overflow.
6424
6df6ae42 6425 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6426 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6427 (x_send_scroll_bar_event): Likewise. Check that the size does not
6428 exceed limits imposed by XClientMessageEvent, as well as the usual
6429 ptrdiff_t and size_t limits.
6430
b13995db
PE
6431 * keyboard.c: Overflow, signedness and related fixes.
6432 (make_lispy_movement): Use same integer type in forward decl
6433 that is used in the definition.
6434 (read_key_sequence, keyremap_step):
6435 Change bufsize argument back to int, undoing my 2011-03-30 change.
6436 We prefer signed types, and int is wide enough here.
6437 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6438 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6439 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6440 length, not size_t. Use ptrdiff_t for index, not int.
6441 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6442 possibility of integer overflow.
6443
13464394
PE
6444 Overflow, signedness and related fixes for images.
6445
6446 * dispextern.h (struct it.stack[0].u.image.image_id)
6447 (struct_it.image_id, struct image.id, struct image_cache.size)
6448 (struct image_cache.used, struct image_cache.ref_count):
6449 * gtkutil.c (update_frame_tool_bar):
6450 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6451 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6452 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6453 * nsmenu.m (update_frame_tool_bar):
6454 * xdisp.c (calc_pixel_width_or_height):
6455 * xfns.c (image_cache_refcount):
6456 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6457 on typical 64-bit hosts.
6458
6459 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6460 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6461 Omit unnecessary casts to int.
6462 (parse_image_spec): Check that integers fall into 'int' range
6463 when the callers expect that.
6464 (image_ascent): Redo ascent calculation to avoid int overflow.
6465 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6466 (lookup_image): Remove unnecessary tests.
6467 (xbm_image_p): Locals are now of int, not EMACS_INT,
6468 since parse_image_check makes sure they fit into int.
6469 (png_load, gif_load, svg_load_image):
6470 Prefer int to unsigned where either will do.
6471 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6472 old tiff_error_handler and tiff_warning_handler.
6473 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6474 stack buffer overflows. It uses only the features of vsnprintf
6475 that are common to both POSIX and native Microsoft.
6476 (tiff_error_handler, tiff_warning_handler): Use it.
6477 (tiff_load, gif_load, imagemagick_load_image):
6478 Don't assume :index value fits in 'int'.
6479 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6480 (imagemagick_load_image): Check that crop parameters fit into
6481 the integer types that MagickCropImage accepts. Don't assume
6482 Vimagemagick_render_type has a nonnegative value. Don't assume
6483 size_t fits in 'long'.
6484 (gs_load): Use printmax_t to print the widest integers possible.
6485 Check for integer overflow when computing image height and width.
6486
c11821d4
EZ
64872011-08-26 Eli Zaretskii <eliz@gnu.org>
6488
6489 * xdisp.c (redisplay_window): Don't force window start if point
6490 will be invisible in the resulting window. (Bug#9324)
6491
0c95fcf7
EZ
64922011-08-25 Eli Zaretskii <eliz@gnu.org>
6493
6494 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6495 the display spec is of the form `(space ...)'.
6496 (handle_display_spec): Return the value returned by
6497 handle_single_display_spec, not just 1 or zero.
6498 (handle_single_display_spec): If the display spec is of the form
6499 `(space ...)', and specifies display in the text area, return 2
6500 rather than 1.
fee65a97 6501 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6502 accurately, and prefer exact match for point under bidi.
6503 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6504
6505 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6506 into disp_prop; all users changed.
6507
6508 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6509 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6510 for the text covered by the display property.
6511
e4ed06f1
CY
65122011-08-25 Chong Yidong <cyd@stupidchicken.com>
6513
6514 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6515 Change return value to nil.
6516 (Frecord_buffer): Delete unused function.
6517
f67cdd7f
EZ
65182011-08-24 Eli Zaretskii <eliz@gnu.org>
6519
5980d4c6
EZ
6520 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6521 buffers, return left-to-right.
8610fe8b
EZ
6522 (set_cursor_from_row): Consider candidate row a win if its glyph
6523 represents a newline and point is on that newline. Fixes cursor
6524 positioning on the newline at EOL of R2L text within L2R
6525 paragraph, and vice versa.
6526 (try_cursor_movement): Check continued rows, in addition to
6527 continuation rows. Fixes unwarranted scroll when point enters a
6528 continued line of R2L text within an L2R paragraph, or vice versa.
6529 (cursor_row_p): Consider the case of point being equal to
6530 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6531 from the end of a short line to the beginning of a continued line
6532 of R2L text within L2R paragraph.
6533 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6534 composed characters.
5980d4c6 6535
f67cdd7f
EZ
6536 * bidi.c (bidi_check_type): Use xassert.
6537 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6538 members.
6539
bca633fb
EZ
65402011-08-23 Eli Zaretskii <eliz@gnu.org>
6541
6542 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6543 a character.
6544
4a5885a7
CY
65452011-08-23 Chong Yidong <cyd@stupidchicken.com>
6546
6547 * nsfont.m (ns_otf_to_script): Fix typo.
6548
0902a04e
KH
65492011-08-22 Kenichi Handa <handa@m17n.org>
6550
6551 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6552 extra slot even if the purpose is char-code-property-table.
6553
1a2e6670
EZ
65542011-08-23 Eli Zaretskii <eliz@gnu.org>
6555
8ddde651
EZ
6556 * xdisp.c (redisplay_window): When computing centering_position,
6557 account for the height of the header line. (Bug#8874)
6558
425cc014
EZ
6559 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6560 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6561 candidate is selected by the mouse, and that candidate has a
6562 composed character under the mouse.
6563
1a2e6670
EZ
6564 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6565 coordinates reported by pos-visible-in-window-p for a composed
6566 character in column zero.
6567
8b76d6f8
SM
65682011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6569
6570 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6571
dac347dd
EZ
65722011-08-22 Eli Zaretskii <eliz@gnu.org>
6573
6574 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6575 consider it a hit if to_charpos is anywhere in the range of the
6576 composed buffer positions.
6577
e013fb34
CY
65782011-08-22 Chong Yidong <cyd@stupidchicken.com>
6579
6580 * image.c (gif_load): Don't assume that each subimage has the same
6581 dimensions as the base image. Handle disposal method that is
6582 "undefined" by the gif spec (Bug#9335).
6583
bd1ba3e8
CY
65842011-08-20 Chong Yidong <cyd@stupidchicken.com>
6585
6586 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6587 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6588
54a1215b
EZ
65892011-08-19 Eli Zaretskii <eliz@gnu.org>
6590
823564e5
EZ
6591 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6592 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6593 from an Org mode buffer to a Speedbar frame.
6594
54a1215b
EZ
6595 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6596 a composition, take its buffer position from IT->cmp_it.charpos.
6597 Fixes cursor positioning at the beginning of a line that begins
6598 with a composed character.
6599
9778ebcc
EZ
66002011-08-18 Eli Zaretskii <eliz@gnu.org>
6601
0be6ee06
EZ
6602 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6603 character bidirectional type, use STRONG_L instead. Fixes crashes
6604 in a buffer produced by `describe-categories'.
6605
9778ebcc
EZ
6606 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6607 members before the level stack, so they would be saved and
6608 restored when copying iterator state. Fixes incorrect reordering
6609 around TABs covered by display properties.
6610
156bffbe
AS
66112011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6612
6b02f655 6613 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6614
72ad093b
CY
66152011-08-17 Chong Yidong <cyd@stupidchicken.com>
6616
6617 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6618 (internal_condition_case_2, internal_condition_case_n):
6619 Remove unnecessary aborts (Bug#9081).
72ad093b 6620
35774242
EZ
66212011-08-17 Eli Zaretskii <eliz@gnu.org>
6622
6623 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6624 has no `load' handler, try opening the file locally. (Bug#9311)
6625
db76dd85
KB
66262011-08-16 Ken Brown <kbrown@cornell.edu>
6627
6628 * gmalloc.c: Expand comment.
6629
b215eee5
EZ
66302011-08-16 Eli Zaretskii <eliz@gnu.org>
6631
6632 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6633 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6634
a4579d33
KB
66352011-08-16 Ken Brown <kbrown@cornell.edu>
6636
6637 Fix memory allocation problems in Cygwin build (Bug#9273).
6638
6639 * unexcw.c ( __malloc_initialized): Declare external variable.
6640 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6641
8b76d6f8
SM
6642 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6643 New variables.
a4579d33
KB
6644 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6645 dumped emacs.
6646 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6647 in the static heap.
6648 [CYGWIN] (special_realloc): New function.
6649 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6650 requests to realloc storage in the static heap.
6651
3ebec551
PE
66522011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6653
6654 * bidi.c (bidi_initialize): Remove unused local.
6655
9fd8be00
EZ
66562011-08-15 Eli Zaretskii <eliz@gnu.org>
6657
6b02f655
SM
6658 * bidimirror.h:
6659 * biditype.h: Remove file.
6660 * makefile.w32-in ($(BLD)/bidi.$(O)):
6661 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6662
6663 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6664
6665 * chartab.c: Improve commentary for the uniprop_table API.
6666
32413314
EZ
6667 * bidi.c (bidi_paragraph_init): Support zero value of
6668 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6669 (bidi_initialize): Use uniprop_table instead of including
6670 biditype.h and bidimirror.h.
32413314 6671
9fd8be00
EZ
6672 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6673 coordinates of the iterator when restoring from ppos_it.
6674 (Bug#9296)
6675
5cf2b69b
KH
66762011-08-14 Kenichi Handa <handa@m17n.org>
6677
6678 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6679 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6680
daf17d00
EZ
66812011-08-14 Eli Zaretskii <eliz@gnu.org>
6682
6683 * xdisp.c (move_it_in_display_line_to): Don't invoke
6684 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6685 ppos_it. Fixes vertical cursor motion when line beginning is
6686 covered by an image. (Bug#9296)
6687
08e3161a
JD
66882011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6689
6690 * nsterm.h (ns_run_ascript): Declare.
6691 (NSAPP_DATA2_RUNASSCRIPT): Define.
6692
6693 * nsfns.m (as_script, as_result, as_status): New static variables.
6694 (ns_run_ascript): New function.
5e617bc2 6695 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6696 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6697 the event loop. Get status from as_status (Bug#7276).
6698
6699 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6700 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6701 the event loop (Bug#7276).
6702
a3720aa2
AS
67032011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6704
6705 * gnutls.c (QCgnutls_bootprop_priority)
6706 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6707 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6708 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6709 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6710 (QCgnutls_bootprop_verify_hostname_error)
6711 (QCgnutls_bootprop_callbacks_verify): Rename from
6712 Qgnutls_bootprop_..., all uses changed.
6713
6714 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6715 uses changed.
6716
0a0d27fb
PE
67172011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6718
19d5c50c
PE
6719 * xfaces.c (Qframe_set_background_mode): Now static.
6720 * dispextern.h (Qframe_set_background_mode): Remove decl.
6721
0a0d27fb
PE
6722 * process.c (Fnetwork_interface_info): Declare local only if needed.
6723
377538cb
JD
67242011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6725
6726 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6727 (Fnetwork_interface_list): Allocate in increments of bytes instead
6728 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6729 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6730 sockaddr.
6731 (struct ifflag_def): notrailers is smart on OSX.
6732 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6733 Get hardware address with getifaddrs if available.
6734
08fff70c
EZ
67352011-08-12 Eli Zaretskii <eliz@gnu.org>
6736
6737 * xdisp.c (iterate_out_of_display_property): xassert that
6738 IT->position is set to within IT->object's boundaries. Break from
6739 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6740 when IT->position is set up wrongly due to some bug.
6741 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6742 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6743 entry. Force push_it to save on the stack the current
6744 buffer/string position, to be restored by pop_it. Fix flags in
6745 the iterator structure wrt the object coming from a display
6746 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6747 properties. (Bug#9284)
6748
7be1c708 67492011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6750
7be1c708
CY
6751 * fontset.c (fontset_get_font_group): Add proper type checks.
6752 (Bug#9172)
aac0c6e3 6753
7be1c708 67542011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6755
7be1c708
CY
6756 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6757 and LC_VERSION_MIN_MACOSX.
6758 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6759 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6760
97bb72a6
EZ
67612011-08-08 Eli Zaretskii <eliz@gnu.org>
6762
6763 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6764 no-display-properties-and-no-overlays under bidi display.
6765 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6766 properties and overlays.
97bb72a6 6767
d5617611
CY
67682011-08-08 Chong Yidong <cyd@stupidchicken.com>
6769
37e11a63
CY
6770 * editfns.c (Fset_time_zone_rule): Document relationship with the
6771 setenv function.
6772
d5617611
CY
6773 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6774 the font entity extracted from the cache (Bug#8109).
6775
58872834
CY
67762011-08-07 Chong Yidong <cyd@stupidchicken.com>
6777
6778 * composite.c (autocmp_chars): Don't reset point. That is done by
6779 restore_point_unwind (Bug#5984).
6780
75bfc667
JL
67812011-08-07 Juri Linkov <juri@jurta.org>
6782
6783 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6784 to show the arg `TIME' instead of `TIMEVAL'.
6785
d1410150
EZ
67862011-08-06 Eli Zaretskii <eliz@gnu.org>
6787
6788 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6789 display property strides EOL and includes a newline, as in
6790 longlines-mode. (Bug#9254)
75b771e4
EZ
6791 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6792 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6793
6794 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6795 is non-zero, even if the data buffer is NULL. Fixes a crash in
6796 vertical-motion with longlines-mode. (Bug#9254)
6797
35928349
EZ
67982011-08-05 Eli Zaretskii <eliz@gnu.org>
6799
ec7cc85b
EZ
6800 * bidi.c <bidi_cache_total_alloc>: Now static.
6801 (bidi_initialize): Initialize bidi_cache_total_alloc.
6802
8b76d6f8 6803 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6804 cache. (Bug#9221)
6805
6806 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6807 amount allocated this far in `bidi_cache_total_alloc'.
6808 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6809 non-zero, only free the data buffer without restoring the cache
6810 contents. All callers changed.
6811
6812 * dispextern.h (bidi_unshelve_cache): Update prototype.
6813
6814 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6815 (move_it_in_display_line, move_it_to)
6816 (move_it_vertically_backward, move_it_by_lines): Replace the call
6817 to xfree to an equivalent call to bidi_unshelve_cache.
6818 (move_it_in_display_line_to): Fix logic of returning
412b6358 6819 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6820
e2e2423b
EZ
68212011-08-05 Eli Zaretskii <eliz@gnu.org>
6822
6823 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6824 came from a string character with a `cursor' property. (Bug#9229)
6825
ae9e757a
JD
68262011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6827
6828 * Makefile.in (LIB_PTHREAD): New variable.
6829 (LIBES): Add LIB_PTHREAD (Bug#9216).
6830
6831 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6832 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6833
213bd7f2
AS
68342011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6835
6b02f655 6836 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6837
99aaf75f
JD
68382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6839
6840 * xterm.c (x_find_topmost_parent): New function.
6841 (x_set_frame_alpha): Find topmost parent window with
6842 x_find_topmost_parent and set the property there also (bug#9181).
6843 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6844
c74e9d86
PE
68452011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6846
6847 * callproc.c (Fcall_process): Avoid vfork clobbering
6848 the local vars buffer, coding_systems, current_dir.
6849
640c8776
SM
68502011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6851
6852 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6853
f26d0e4c
PE
68542011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6855
8a10d76c
PE
6856 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6857 so that it is not optimized away.
6858
f26d0e4c
PE
6859 * xdisp.c (compute_display_string_pos): Remove unused local.
6860
55439c61
EZ
68612011-08-02 Eli Zaretskii <eliz@gnu.org>
6862
6863 Fix slow cursor motion and scrolling in large buffers with
6864 selective display, like Org Mode buffers. (Bug#9218)
6865
6866 * dispextern.h (struct bidi_it): New member disp_prop_p.
6867
6868 * xdisp.c: Remove one-slot cache of display string positions.
6869 (compute_display_string_pos): Accept an additional argument
5e617bc2 6870 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6871 for a display string or property. If found, set DISP_PROP_P
6872 non-zero.
6873
6874 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6875 DISP_PROP_P, and pass it to compute_display_string_pos.
6876 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6877 non-zero. All callers of bidi_fetch_char changed.
6878
fb33fa43
SM
68792011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6880
6881 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6882
b099e063
DM
68832010-12-03 Don March <don@ohspite.net>
6884
6885 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6886 last character M-[char] is translated to ESC [char] (bug#7541).
6887
5cc7f7af
KH
68882011-08-02 Kenichi Handa <handa@m17n.org>
6889
d0fffa3f 6890 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6891
6892 * chartab.c (uniprop_table): Make it non-static.
6893
525d5e6e
EZ
68942011-08-01 Eli Zaretskii <eliz@gnu.org>
6895
6896 * xdisp.c (forward_to_next_line_start): Accept additional argument
6897 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6898 on the newline.
6899 (reseat_at_next_visible_line_start): Use the bidi iterator state
6900 returned by forward_to_next_line_start to restore the state of
6901 it->bidi_it after backing up to previous newline. (Bug#9212)
6902
31011111
AS
69032011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6904
6905 * regex.c (re_comp): Protoize.
6906 (re_exec): Fix return type.
6907 (regexec): Fix type of `ret'. (Bug#9203)
6908
476371c4
PE
69092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6910
e5d76069
PE
6911 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6912 This is needed if max-image-size is a floating-point number.
6913
9a79b20c
AS
69142011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6915
6916 * print.c (print_object): Print empty symbol as ##.
6917
6918 * lread.c (read1): Read ## as empty symbol.
6919
d8c2fa78
AA
69202011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6921
6922 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6923 setting frame foreground color (Bug#9175).
6924 (x_set_background_color): Likewise.
6925
ffe57a7a
AA
6926 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6927 contents (Bug#9176).
6928 (EmacsTooltip -init): Remove bezels and add shadows to
6929 tooltip windows.
6930
bf3492a5
AA
6931 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6932 or scroll bar (Bug#8470).
6933
d55e9c53
AA
6934 * nsfont.m (nsfont_open): Remove assignment to voffset and
6935 unnecessary vars hshink, expand, hd, full_height, min_height.
6936 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6937
6938 * nsterm.h (nsfont_info): Remove voffset field.
6939
d8c2fa78 69402011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6941
6942 Implement strike-through and overline on NextStep (Bug#8863).
6943
6944 * nsfont.m (nsfont_open): Use underline position provided by font,
6945 instead of hard-coded value of 2.
6946 (nsfont_draw): Call ns_draw_text_decoration instead.
6947
6948 * nsterm.h: Add declaration for ns_draw_text_decoration.
6949
6950 * nsterm.m (ns_draw_text_decoration): New function for drawing
6951 underline, overline, and strike-through.
6952 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6953 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6954 accommodate underlining, etc.
4843aac3 6955
4cc60b9b
EZ
69562011-07-28 Eli Zaretskii <eliz@gnu.org>
6957
bc7ece87
EZ
6958 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6959 default.
4cc60b9b 6960
476371c4
PE
69612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6962
66606eea
PE
6963 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6964 Without this fix, if a signal arrives just after memory fills up,
6965 'malloc' might be invoked reentrantly.
6966
476371c4
PE
6967 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6968 In other words, assume that every image size is allowed, on non-X
6969 hosts. This assumption is probably wrong, but it lets Emacs compile.
6970
f3fcc40d
AS
69712011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6972
6973 * regex.c (re_iswctype): Convert return values to boolean.
6974
350c992f
EZ
69752011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6976
6977 * xdisp.c (compute_display_string_pos): Don't use cached display
6978 string position if the buffer had its restriction changed.
6979 (Bug#9184)
6980
5266b4bb
PE
69812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6982
6983 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6984
2573a837 69852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6986
41f55ccd 6987 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6988
39e378da
PE
6989 * bidi.c: Integer size and overflow fixes.
6990 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6991 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6992 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6993 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6994 (bidi_find_other_level_edge):
6995 Use ptrdiff_t instead of EMACS_INT where either will do.
6996 This works better on 32-bit hosts configured --with-wide-int.
6997 (bidi_cache_ensure_space): Check for size-calculation overflow.
6998 Use % rather than repeated addition, for better worst-case speed.
6999 Don't set bidi_cache_size until after xrealloc returns, because it
7000 might not return.
7001 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7002 (bidi_cache_ensure_space): Also check that the bidi cache size
7003 does not exceed that of the largest Lisp string or buffer. See Eli
7004 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7005
5e927815
PE
7006 * alloc.c (__malloc_size_t): Remove.
7007 All uses replaced by size_t. See Andreas Schwab's note
7008 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7009
ca4aa935
PE
7010 * image.c: Improve checking for integer overflow.
7011 (check_image_size): Assume that f is nonnull, since
7012 it is always nonnull in practice. This is one less thing to
7013 worry about when checking for integer overflow later.
7014 (x_check_image_size): New function, which checks for integer
7015 overflow issues inside X.
7016 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7017 This removes the need for a memory_full check.
7018 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7019 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7020 (xbm_read_bitmap_data): Change locals back to 'int', since
7021 their values must fit in 'int'.
7022 (xpm_load_image, png_load, tiff_load):
7023 Invoke x_create_x_image_and_pixmap earlier,
7024 to avoid much needless work if the image is too large.
7025 (tiff_load): Treat overly large images as if
7026 x_create_x_image_and_pixmap failed, not as malloc failures.
7027 (gs_load): Use x_check_image_size.
7028
5f8f9cc2
PE
7029 * gtkutil.c: Omit integer casts.
7030 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7031 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7032
5adf60bc
PE
7033 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7034
c8907a93
PE
7035 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7036 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7037 would wrongly return t on a 64-bit host.
7038
e3c25c68
PE
7039 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7040 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7041 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7042 and therefore cause GCC to emit a bogus diagnostic in some cases.
7043
3f791afe
PE
7044 * image.c: Integer signedness and overflow and related fixes.
7045 This is not an exhaustive set of fixes, but it's time to
7046 record what I've got.
7047 (lookup_pixel_color, check_image_size): Remove redundant decls.
7048 (check_image_size): Don't assume that arbitrary EMACS_INT values
7049 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7050 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7051 (tiff_load, imagemagick_load_image):
7052 Check for overflow in size calculations.
7053 (x_create_x_image_and_pixmap): Remove unnecessary test for
7054 xmalloc returning NULL; that can't happen.
7055 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7056 (xpm_color_bucket): Use better integer hashing function.
7057 (xpm_cache_color): Don't possibly over-allocate memory.
7058 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7059 (gif_memory_source):
7060 Use ptrdiff_t, not int or size_t, to record sizes.
7061 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7062 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7063 either works, as we prefer signed integers.
7064 (tiff_read_from_memory, tiff_write_from_memory):
7065 Return tsize_t, not size_t, since that's what the TIFF API wants.
7066 (tiff_read_from_memory): Don't fail simply because the read would
7067 go past EOF; instead, return a short read.
7068 (tiff_load): Omit no-longer-needed casts.
7069 (Fimagemagick_types): Don't assume size fits into 'int'.
7070
3cc5a532
PE
7071 Improve hashing quality when configured --with-wide-int.
7072 * fns.c (hash_string): New function, taken from sxhash_string.
7073 Do not discard information about ASCII character case; this
7074 discarding is no longer needed.
7075 (sxhash-string): Use it. Change sig to match it. Caller changed.
7076 * lisp.h: Declare it.
7077 * lread.c (hash_string): Remove, since we now use fns.c's version.
7078 The fns.c version returns a wider integer if --with-wide-int is
7079 specified, so this should help the quality of the hashing a bit.
7080
b312a492
PE
7081 * emacs.c: Integer overflow minor fix.
7082 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7083 Define only if GNU_LINUX.
7084 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7085
dfd153ae
PE
7086 * dispnew.c: Integer signedness and overflow fixes.
7087 Remove unnecessary forward decls, that were a maintenance hassle.
7088 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7089 All uses changed.
7090 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7091 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7092 (prepare_desired_row, line_draw_cost):
7093 Use int, not unsigned, where either works.
7094 (save_current_matrix, restore_current_matrix):
7095 Use ptrdiff_t, not size_t, where either works.
7096 (init_display): Check for overflow more accurately, and without
7097 relying on undefined behavior.
7098
a81d11a3
PE
7099 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7100 Remove, replacing with the new symbols in lisp.h. All uses changed.
7101 * fileio.c (make_temp_name):
7102 * filelock.c (lock_file_1, lock_file):
7103 * xdisp.c (message_dolog):
7104 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7105 Use pMd etc. instead.
7106 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7107 replacing the pWIDE etc. symbols removed from editfns.c.
7108
3300e6fd
PE
7109 * keyboard.h (num_input_events): Now uintmax_t.
7110 This is (very slightly) less likely to mess up due to wraparound.
7111 All uses changed.
7112
fd05c7e9
PE
7113 * buffer.c: Integer signedness fixes.
7114 (alloc_buffer_text, enlarge_buffer_text):
7115 Use ptrdiff_t rather than size_t when either will do, as we prefer
7116 signed integers.
7117
903fe15d
PE
7118 * alloc.c: Integer signedness and overflow fixes.
7119 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7120 (__malloc_size_t): Default to size_t, not to int.
7121 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7122 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7123 Prefer ptrdiff_t to size_t when either would do, as we prefer
7124 signed integers.
7125 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7126 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7127 Now const. Initialize with values that are in range even if char
7128 is signed.
7129 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7130 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7131 These functions do the right thing with sizes > 2**32.
7132 (check_depth): Now ptrdiff_t, not int.
7133 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7134 Adjust to new way of storing sizes. Check for size overflow bugs
7135 in rest of code.
7136 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7137 slightly wrong anyway, as it missed one instance of
7138 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7139 (refill_memory_reserve): Omit needless cast to size_t.
7140 (mark_object_loop_halt): Mark as externally visible.
7141
ac82cc6a
PE
7142 * xselect.c: Integer signedness and overflow fixes.
7143 (Fx_register_dnd_atom, x_handle_dnd_message):
7144 Use ptrdiff_t, not size_t, since we prefer signed.
7145 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7146 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7147 x_dnd_atoms_size and x_dnd_atoms_length.
7148
c2d1e36d
PE
7149 * doprnt.c: Prefer signed to unsigned when either works.
7150 * eval.c (verror):
7151 * doprnt.c (doprnt):
7152 * lisp.h (doprnt):
7153 * xdisp.c (vmessage):
7154 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7155 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7156 prefer signed arithmetic to avoid comparison confusion.
7157 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7158 but is a bit tricky.
7159
0e926e56
PE
7160 Assume freestanding C89 headers, string.h, stdlib.h.
7161 * data.c, doprnt.c, floatfns.c, print.c:
7162 Include float.h unconditionally.
7163 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7164 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7165 * regex.c: Likewise for stddef.h, string.h.
7166 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7167 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7168 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7169 (STDC_HEADERS): Remove obsolete defines.
7170 * sysdep.c: Include limits.h unconditionally.
7171
9cfdb3ec
PE
7172 Assume support for memcmp, memcpy, memmove, memset.
7173 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7174 * regex.c (memcmp, memcpy):
7175 Remove; we assume C89 now.
7176
7177 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7178 (__malloc_safe_bcopy): Remove; no longer needed.
7179
cf950e6b 7180 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7181 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7182 well either way, and we prefer signed to unsigned.
7183
dbf38e02
LMI
71842011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7185
7186 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7187 closes the connection while we're reading (bug#9182).
7188
d6f0886c 71892011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7190
d6f0886c
JD
7191 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7192 are specified (Bug#9168).
24e0f6b1 7193
2eb1f9e6
PE
71942011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7195
7196 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7197 Found by GCC static checking and --with-wide-int on a 32-bit host.
7198
22381272 71992011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7200
7201 * xdisp.c (compute_display_string_pos): Fix logic of caching
7202 previous display string position. Initialize cached_prev_pos to
7203 -1. Fixes slow-down at the beginning of a buffer.
7204
f25e39b4
EZ
72052011-07-24 Eli Zaretskii <eliz@gnu.org>
7206
7207 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7208 for attrs[LFACE_FONTSET_INDEX].
7209
04c4b52e
PE
72102011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7211
7212 * xml.c (parse_region): Remove unused local
7213 that was recently introduced.
7214
c1734fbd
EZ
72152011-07-23 Eli Zaretskii <eliz@gnu.org>
7216
be18c5a5
EZ
7217 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7218 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7219
c1734fbd
EZ
7220 * xdisp.c (move_it_in_display_line_to): Record the best matching
7221 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7222 exit if none of the characters scanned was an exact match.
7223 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7224 when exact match is impossible due to invisible text, and the
7225 lines are truncated.
7226
a258d627
JD
72272011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7228
7229 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7230 for OSX >= 10.7.
7231
b6d5a689
EZ
72322011-07-22 Eli Zaretskii <eliz@gnu.org>
7233
0f74f785
EZ
7234 Fix a significant slow-down of cursor motion with C-n, C-p,
7235 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7236 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7237 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7238 (next_element_from_buffer): Call compute_stop_pos_backwards to
7239 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7240 base_level_stop.
7241 (reseat): Don't look for prev_stop, as that could mean a very long
7242 run.
7243 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7244 <cached_disp_overlay_modiff>: Cache for last found display string
7245 position.
551918c1 7246 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7247 about the same buffer in the same area of character positions, and
7248 the buffer wasn't changed since the time the display string
7249 position was cached.
551918c1 7250
b2d0c91a
EZ
72512011-07-22 Eli Zaretskii <eliz@gnu.org>
7252
7253 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7254 is an integer, which is important for empty lines. (Bug#9149)
7255
043604ee
CY
72562011-07-22 Chong Yidong <cyd@stupidchicken.com>
7257
7258 * frame.c (Fmodify_frame_parameters): In tty case, update the
7259 default face if necessary (Bug#4238).
7260
da4adb04
CY
72612011-07-21 Chong Yidong <cyd@stupidchicken.com>
7262
7263 * editfns.c (Fstring_to_char): No need to explain what a character
7264 is in the docstring (Bug#6576).
7265
9abd0532
LMI
72662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7267
7268 * xml.c (parse_region): Make sure we always return a tree.
7269
36881d16
HK
72702011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7271
7272 * xml.c (parse_region): If a document contains only comments,
7273 return that, too.
7274
1e98674d
LMI
72752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7276
7277 * xml.c (make_dom): Return comments, too.
7278
590bd467
PE
72792011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7280
7281 Port to OpenBSD.
7282 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7283 and the surrounding thread.
7284 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7285 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7286 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7287 timer goes off.
7288 * s/openbsd.h (BROKEN_SIGIO): Define.
7289 * unexelf.c (unexec) [__OpenBSD__]:
7290 Don't update the .mdebug section of the Alpha COFF symbol table.
7291
f41628b2
LMI
72922011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7293
7294 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7295 (bug#8460).
7296
b59b67c5
PE
72972011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7298
15e3a074
PE
7299 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7300 This fixes some race conditions on the permissions of any newly
7301 created file.
7302
41bed37d
PE
7303 * alloc.c (valid_pointer_p): Use pipe, not open.
7304 This fixes some permissions issues when debugging.
7305
b59b67c5
PE
7306 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7307 If fchown fails to set both uid and gid, try to set just gid,
7308 as that is sometimes allowed. Adjust the file's mode to eliminate
7309 setuid or setgid bits that are inappropriate if fchown fails.
7310
925a6be7
SM
73112011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7312
7313 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7314 to compare Lisp_Objects.
7315 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7316 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7317 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7318
52968808
AS
73192011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7320
0a6a104b
AS
7321 * lread.c (read_integer): Unread even EOF character.
7322 (read1): Likewise. Properly record start position of symbol.
7323
52968808
AS
7324 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7325 symbol character follows.
7326
9e381cdd
PE
73272011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7328
7329 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7330 This works around a problem with the previous change to Fcopy_file.
7331 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7332 and without this change, GCC might complain about discarding
7333 fchown's return value.
7334
b5641435
JB
73352011-07-16 Juanma Barranquero <lekktu@gmail.com>
7336
7337 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7338
a8031457
PE
73392011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7340
7341 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7342
dd889327
LMI
73432011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7344
750c33f7
LMI
7345 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7346 it's used from the C level.
7347
dd889327
LMI
7348 * process.c: Use the same condition for POLL_FOR_INPUT in both
7349 keyboard.c and process.c (bug#1858).
7350
87e86684
LM
73512011-07-09 Lawrence Mitchell <wence@gmx.li>
7352
7353 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7354 (Fgnutls_boot): Use it.
7355
64348f40
AS
73562011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7357
7358 * doc.c (Fsubstitute_command_keys): Revert last change.
7359
1d698799
LMI
73602011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7361
f863868c
LMI
7362 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7363 quotes the next character, and doesn't affect other longer
7364 sequences (bug#8935).
7365
1d698799
LMI
7366 * lread.c (syms_of_lread): Clarify that is isn't only
7367 `eval-buffer' and `eval-defun' that's affected by
7368 `lexical-binding' (bug#8460).
7369
aa4b6df6
EZ
73702011-07-15 Eli Zaretskii <eliz@gnu.org>
7371
7372 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7373 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7374
5d856da6
PE
73752011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7376
ad6042bb
PE
7377 Fix minor problems found by static checking.
7378 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7379 (elsz): Now a signed constant, not a size_t var. We prefer signed
7380 types to unsigned, to avoid integer comparison confusion. Without
7381 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7382 "cannot optimize loop, the loop counter may overflow", a symptom
7383 of the confusion.
f00bbb22 7384 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7385 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7386
6468f31c
LMI
73872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7388
49080b10
LMI
7389 * search.c (Fre_search_backward): Mention `case-fold-search' in
7390 all the re_search_* functions (bug#8138).
7391
6468f31c
LMI
7392 * keyboard.c (Fopen_dribble_file): Document when the file is
7393 closed (bug#8056).
7394
c965adc5
EZ
73952011-07-14 Eli Zaretskii <eliz@gnu.org>
7396
df9733bf
EZ
7397 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7398 bidi_cache_idx.
7399
0bb23927
EZ
7400 Support bidi reordering of display and overlay strings.
7401 * xdisp.c (compute_display_string_pos)
7402 (compute_display_string_end): Accept additional argument STRING.
7403 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7404 (reseat_to_string): Initialize bidi_it->string.s and
7405 bidi_it->string.schars.
7406 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7407 NULL (avoids a crash in bidi_paragraph_init).
7408 Initialize itb.string.lstring.
0bb23927
EZ
7409 (init_iterator): Call bidi_init_it only of a valid
7410 buffer position was specified. Initialize paragraph_embedding to
7411 L2R.
7412 (reseat_to_string): Initialize the bidi iterator.
7413 (display_string): If we need to ignore text properties of
7414 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7415 original value of -1 will not work with bidi.)
7416 (compute_display_string_pos): First arg is now struct
7417 `text_pos *'; all callers changed. Support display properties on
7418 Lisp strings.
7419 (compute_display_string_end): Support display properties on Lisp
7420 strings.
7421 (init_iterator, reseat_1, reseat_to_string): Initialize the
7422 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7423 when iterating on a string not from display properties).
640c8776
SM
7424 (compute_display_string_pos, compute_display_string_end):
7425 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7426 arrow keys.
7427 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7428 base_level_stop; instead, set base_level_stop to BEGV.
7429 Fixes crashes in vertical-motion.
0bb23927
EZ
7430 (next_element_from_buffer): Improve commentary for when
7431 the iterator is before prev_stop.
7432 (init_iterator): Initialize bidi_p from the default value of
7433 bidi-display-reordering, not from buffer-local value. Use the
7434 buffer-local value only if initializing for buffer iteration.
7435 (handle_invisible_prop): Support invisible properties on strings
7436 that are being bidi-reordered.
7437 (set_iterator_to_next): Support bidi reordering of C strings and
7438 Lisp strings.
7439 (next_element_from_string): Support bidi reordering of Lisp
7440 strings.
7441 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7442 (display_string): Support display of R2L glyph rows.
7443 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7444 (init_iterator): Don't initialize it->bidi_p for strings
7445 here.
7446 (reseat_to_string): Initialize it->bidi_p for strings here.
7447 (next_element_from_string, next_element_from_c_string)
7448 (next_element_from_buffer): Add xassert's for correspondence
7449 between IT's object being iterated and it->bidi_it.string
7450 structure.
7451 (face_before_or_after_it_pos): Support bidi iteration.
7452 (next_element_from_c_string): Handle the case of the first string
7453 character that is not the first one in the visual order.
7454 (get_visually_first_element): New function, refactored from common
7455 parts of next_element_from_buffer, next_element_from_string, and
7456 next_element_from_c_string.
7457 (tool_bar_lines_needed, redisplay_tool_bar)
7458 (display_menu_bar): Force left-to-right direction. Add a FIXME
7459 comment for making that be controlled by a user option.
7460 (push_it, pop_it): Save and restore the state of the
7461 bidi iterator. Save and restore the bidi_p flag.
7462 (pop_it): Iterate out of display property for string iteration as
7463 well.
7464 (iterate_out_of_display_property): Support iteration over strings.
7465 (handle_single_display_spec): Set up it->bidi_it for iteration
7466 over a display string, and call bidi_init_it.
7467 (handle_single_display_spec, next_overlay_string)
7468 (get_overlay_strings_1, push_display_prop): Set up the bidi
7469 iterator for displaying display or overlay strings.
7470 (forward_to_next_line_start): Don't use the shortcut if
7471 bidi-iterating.
7472 (back_to_previous_visible_line_start): If handle_display_prop
7473 pushed the iterator stack, restore the internal state of the bidi
7474 iterator by calling bidi_pop_it same number of times.
7475 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7476 and we are bidi-iterating, don't decrement the iterator position;
7477 instead, set the first_elt flag in the bidi iterator, to produce
7478 the same effect.
7479 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7480 (push_display_prop): xassert that we are iterating a buffer.
7481 (push_it, pop_it): Save and restore paragraph_embedding member.
7482 (handle_single_display_spec, next_overlay_string)
7483 (get_overlay_strings_1, reseat_1, reseat_to_string)
7484 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7485 correctly. Don't assume unibyte strings are not bidi-reordered.
7486 (compute_display_string_pos)
7487 (compute_display_string_end): Fix handling the case of C string.
7488 (push_it, pop_it): Save and restore from_disp_prop_p.
7489 (handle_single_display_spec, push_display_prop): Set the
7490 from_disp_prop_p flag.
7491 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7492 (pop_it): Call iterate_out_of_display_property only if we are
7493 popping after iteration over a string that came from a display
7494 property. Fix a typo in popping stretch info. Add an assertion
7495 for verifying that the iterator position is in sync with the bidi
7496 iterator.
7497 (handle_single_display_spec, get_overlay_strings_1)
7498 (push_display_prop): Fix initialization of paragraph direction for
7499 string when that of the parent object is not yet determined.
7500 (reseat_1): Call bidi_init_it to resync the bidi
7501 iterator with IT's position. (Bug#7616)
7502 (find_row_edges): If ROW->start.pos gives position
7503 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7504 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7505 Reset the from_disp_prop_p flag.
7506 (SAVE_IT, RESTORE_IT): New macros.
7507 (pos_visible_p, face_before_or_after_it_pos)
7508 (back_to_previous_visible_line_start)
7509 (move_it_in_display_line_to, move_it_in_display_line)
7510 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7511 (try_scrolling, redisplay_window, display_line): Use them when
7512 saving a temporary copy of the iterator and restoring it back.
7513 (back_to_previous_visible_line_start, reseat_1)
7514 (init_iterator): Empty the bidi cache "stack".
7515 (move_it_in_display_line_to): If iterator ended up at
7516 EOL, but we never saw any buffer positions smaller than
7517 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7518 motion in bidi-reordered lines.
7519 (move_it_in_display_line_to): Record prev_method and prev_pos
7520 immediately before the call to set_iterator_to_next. Fixes cursor
7521 motion in bidi-reordered lines with stretch glyphs and strings
7522 displayed in margins. (Bug#8133) (Bug#8867)
7523 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7524 TO_CHARPOS.
640c8776
SM
7525 (pos_visible_p): Support positions in bidi-reordered lines.
7526 Save and restore bidi cache.
0bb23927
EZ
7527
7528 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7529 (bidi_paragraph_info): Delete unused struct.
7530 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7531 (bidi_cache_start): New variable.
7532 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7533 to zero.
7534 (bidi_cache_fetch_state, bidi_cache_search)
7535 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7536 (bidi_cache_find, bidi_peek_at_next_level)
7537 (bidi_level_of_next_char, bidi_find_other_level_edge)
7538 (bidi_move_to_visually_next): Compare cache index with
7539 bidi_cache_start rather than with zero.
7540 (bidi_fetch_char): Accept new argument STRING; all callers
7541 changed. Support iteration over a string. Support strings with
7542 display properties. Support unibyte strings. Fix the type of
7543 `len' according to what STRING_CHAR_AND_LENGTH expects.
7544 (bidi_paragraph_init, bidi_resolve_explicit_1)
7545 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7546 (bidi_level_of_next_char, bidi_move_to_visually_next):
7547 Support iteration over a string.
0bb23927
EZ
7548 (bidi_set_sor_type, bidi_resolve_explicit_1)
7549 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7550 can now be zero (for strings); special values 0 and -1 were
7551 changed to -1 and -2, respectively.
7552 (bidi_char_at_pos): New function.
7553 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7554 Call it instead of FETCH_MULTIBYTE_CHAR.
7555 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7556 initialized to valid values.
7557 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7558 values.
7559 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7560 the test for valid cached positions. Fix the logic for looking up
7561 the sentinel state in the cache. GCPRO the Lisp string we are
7562 iterating.
7563 (bidi_push_it, bidi_pop_it): New functions.
7564 (bidi_initialize): Initialize the bidi cache start stack pointer.
7565 (bidi_cache_ensure_space): New function, refactored from part of
7566 bidi_cache_iterator_state. Don't assume the required size is just
7567 one BIDI_CACHE_CHUNK away.
7568 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7569 (bidi_count_bytes, bidi_char_at_pos): New functions.
7570 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7571 always valid if bidi_cache_idx is valid.
7572 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7573 is valid if it's going to be used.
7574 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7575 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7576 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7577 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7578 (bidi_find_other_level_edge, bidi_cache_start_stack):
7579 All variables related to cache indices are now EMACS_INT.
c965adc5 7580
0bb23927
EZ
7581 * dispextern.h (struct bidi_string_data): New structure.
7582 (struct bidi_it): New member `string'. Make flag members be 1-bit
7583 fields, and put them last in the struct.
640c8776
SM
7584 (compute_display_string_pos, compute_display_string_end):
7585 Update prototypes.
0bb23927
EZ
7586 (bidi_push_it, bidi_pop_it): Add prototypes.
7587 (struct iterator_stack_entry): New members bidi_p,
7588 paragraph_embedding, and from_disp_prop_p.
7589 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7590 (bidi_shelve_cache, bidi_unshelve_cache):
7591 Declare prototypes.
0bb23927
EZ
7592
7593 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7594 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7595 and vector-like objects.
7596
7597 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7598 cache around display iteration.
7599
7600 * window.c (Fwindow_end, window_scroll_pixel_based)
7601 (displayed_window_lines, Frecenter): Save and restore the bidi
7602 cache around display iteration.
7603
3bbd2265
LMI
76042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7605
7606 * editfns.c (Fdelete_region): Clarify the use of the named
7607 parameters (bug#6788).
7608
adc47434
MR
76092011-07-14 Martin Rudalics <rudalics@gmx.at>
7610
7611 * indent.c (Fvertical_motion): Set and restore w->pointm when
7612 saving and restoring the window's buffer (Bug#9006).
7613
837c31f8
LMI
76142011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7615
7616 * editfns.c (Fstring_to_char): Clarify just what is returned
7617 (bug#6576). Text by Eli Zaretskii.
7618
ac389d0c
JB
76192011-07-13 Juanma Barranquero <lekktu@gmail.com>
7620
7621 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7622
0be0ce47
EZ
76232011-07-13 Eli Zaretskii <eliz@gnu.org>
7624
7625 * buffer.c (mmap_find): Fix a typo.
7626
cd18e7e3
JB
76272011-07-13 Johan Bockgård <bojohan@gnu.org>
7628
7629 Fix execution of x selection hooks.
7630 * xselect.c (Qx_lost_selection_functions)
7631 (Qx_sent_selection_functions): New vars.
7632 (syms_of_xselect): DEFSYM them.
7633 (x_handle_selection_request): Pass Qx_sent_selection_functions
7634 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7635 (x_handle_selection_clear,x_clear_frame_selections):
7636 Pass Qx_lost_selection_functions rather than
7637 Vx_lost_selection_functions to Frun_hook_with_args.
7638
47ea7f44
PE
76392011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7640
ac389d0c 7641 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7642 The old code sometimes used this field without initializing it.
7643
47ea7f44
PE
7644 * alloc.c (gc_sweep): Don't read past end of array.
7645 In theory, the old code could also have corrupted Emacs internals,
7646 though it'd be very unlikely.
7647
bc985c87
AS
76482011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7649
7650 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7651 argument. (Bug#4026)
bc985c87 7652
0cf34688
LMI
76532011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7654
b3dadd76
LMI
7655 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7656 key" (bug#4257).
7657
0cf34688
LMI
7658 * window.c (Fset_window_start): Doc fix (bug#4199).
7659 (Fset_window_hscroll): Ditto.
7660
270768cd
PE
76612011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7662
077e3dda 7663 Fix minor new problems caught by GCC 4.6.1.
270768cd 7664 * term.c (init_tty): Remove unused local.
490011a6 7665 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7666 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7667 not used otherwise.
270768cd 7668
b1f58454
CY
76692011-07-12 Chong Yidong <cyd@stupidchicken.com>
7670
7671 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7672
22b9578d
LMI
76732011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7674
6e70ab07
LMI
7675 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7676 are the mini-buffer and the echo area (bug#3320).
7677
22b9578d
LMI
7678 * term.c (init_tty): Remove support for supdup, c10 and perq
7679 terminals, which are no longer supported (bug#1482).
7680
8974cc9f
JB
76812011-07-10 Johan Bockgård <bojohan@gnu.org>
7682
7683 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7684
a560d974
JD
76852011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7686
7687 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7688 for non-popups (Bug#3642).
7689
1dae0f0a
AS
76902011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7691
268c2c36 7692 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7693 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7694 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7695 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7696 * data.c (fmod): Likewise.
7697 * dispnew.c (swap_glyphs_in_rows): Likewise.
7698 * emacs.c (memory_warning_signal): Likewise.
7699 * floatfns.c (float_error): Likewise.
7700 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7701 (otf_open, font_otf_capability, generate_otf_features)
7702 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7703 Likewise.
7704 * image.c (pbm_read_file): Likewise.
7705 * indent.c (string_display_width): Likewise.
7706 * intervals.c (check_for_interval, search_for_interval)
7707 (inc_interval_count, count_intervals, root_interval)
7708 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7709 * lread.c (defalias): Likewise.
268c2c36 7710 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7711 * regex.c (set_image_of_range_1, set_image_of_range)
7712 (regex_grow_registers): Likewise.
7713 * sysdep.c (strerror): Likewise.
7714 * termcap.c (valid_filename_p, tprint, main): Likewise.
7715 * tparam.c (main): Likewise.
7716 * unexhp9k800.c (run_time_remap, save_data_space)
7717 (update_file_ptrs, read_header, write_header, calculate_checksum)
7718 (copy_file, copy_rest, display_header): Likewise.
7719 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7720 Likewise.
7721 * xdisp.c (check_it): Likewise.
7722 * xfaces.c (register_color, unregister_color, unregister_colors):
7723 Likewise.
7724 * xfns.c (print_fontset_result): Likewise.
7725 * xrdb.c (member, fatal, main): Likewise.
7726
99033785
PE
77272011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7728
7729 Fix minor problems found by static checking (Bug#9031).
7730 * chartab.c (char_table_set_range, map_sub_char_table):
7731 Remove unused locals.
7732 (uniprop_table): Now static.
7733 * composite.c (_work_char): Remove unused static var.
7734
9cb2ac56
JB
77352011-07-09 Juanma Barranquero <lekktu@gmail.com>
7736
7737 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7738
f25661f0
JD
77392011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7740
7741 * gtkutil.c (qttip_cb): Remove code without function.
7742
8278c4fe
EZ
77432011-07-09 Eli Zaretskii <eliz@gnu.org>
7744
7745 * w32.c (pthread_sigmask): New stub.
7746
1692ae2d 77472011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7748
8a6ebd58 7749 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7750 sigprocmask is portable only for single-threaded applications, and
7751 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7752 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7753 (LIBES): Use it.
7754 * callproc.c (Fcall_process):
7755 * process.c (create_process):
7756 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7757 Use pthread_sigmask, not sigprocmask.
123403e4 7758
1b854618
JD
77592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7760
7761 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7762 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7763 wrong (Bug#8591).
7764
3fe4b549
JD
77652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7766
0ce7e563
JD
7767 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7768 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7769 (xg_hide_tooltip): Fix comment.
7770
3fe4b549
JD
7771 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7772 in registerServicesMenuSendTypes.
7773 (validRequestorForSendType): Don't check ns_return_types.
7774
7775 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7776 ns_return_type.
7777
5df75e47
JR
77782011-07-08 Jason Rumney <jasonr@gnu.org>
7779
22610910
JR
7780 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7781 SH_SHOW for hidden windows (Bug#5482).
7782
5df75e47
JR
7783 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7784 frame struct members of non-existent frames (Bug#6284).
7785
699c10bd
JD
77862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7787
4393663b
JD
7788 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7789 variable firstTime not needed on OSX >= 10.6.
7790 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7791 >= 10.5. Use setKnobProportion, setDoubleValue.
7792
7793 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7794 (MAC_OS_X_VERSION_10_5): Define if not defined.
7795 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7796 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7797 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7798
7799 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7800 cString and lossyCString on OSX >= 10.4.
4393663b 7801
58179cce 7802 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7803 sizeToFit on OSX >= 10.2.
7804
7805 * nsimage.m (allocInitFromFile): Don't use deprecated method
7806 bestRepresentationForDevice on OSX >= 10.6.
7807
7808 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7809 to avoid warning.
7810
7811 * emacs.c: Declare unexec_init_emacs_zone.
7812
a63e0781
JD
7813 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7814
699c10bd
JD
7815 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7816
7817 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7818 on svcsMenu (Bug#8842).
7819
7820 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7821 ns_return_types.
7822 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7823
7824 * nsterm.m (QUTF8_STRING): Declare.
7825 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7826 (validRequestorForSendType): Return type is (id).
7827 Change indexOfObjectIdenticalTo to indexOfObject.
7828 Check if we have local selection before returning self (Bug#8842).
7829 (writeSelectionToPasteboard): Put local selection into paste board
7830 if we have a local selection (Bug#8842).
7831 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7832
7833 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7834 (ns_get_local_selection): Declare.
7835
54e10184
LMI
78362011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7837
9888ff71
LMI
7838 * keymap.c (describe_map_tree): Don't insert a double newline at
7839 the end of the buffer (bug#1169) and return whether we inserted
7840 something.
7841
54e10184
LMI
7842 * callint.c (Fcall_interactively): Change "reading args" to
7843 "providing args" to try to clarify what it does (bug#1010).
7844
15fa4783
KH
78452011-07-07 Kenichi Handa <handa@m17n.org>
7846
7847 * composite.c (composition_compute_stop_pos): Ignore a static
7848 composition starting before CHARPOS (Bug#8915).
7849
7850 * xdisp.c (handle_composition_prop): Likewise.
7851
a8815b00
EZ
78522011-07-07 Eli Zaretskii <eliz@gnu.org>
7853
7854 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7855 (Bug#9015)
7856
ef7b981d 78572011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7858
7859 * character.h (unicode_category_t): New enum type.
7860
7861 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7862 (Qchar_code_property_table): New variable.
7863 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7864 (UNIPROP_COMPRESSED_FORM_P): New macros.
7865 (char_table_ascii): Uncompress the compressed values.
7866 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7867 Uncompress the compressed values.
ac389d0c 7868 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7869 (char_table_ref_and_range): Uncompress the compressed values.
7870 (sub_char_table_set): New arg is_uniprop. Callers changed.
7871 Uncompress the compressed values.
7872 (sub_char_table_set_range): Args changed. Callers changed.
7873 (char_table_set_range): Adjuted for the above change.
7874 (map_sub_char_table): Delete args default_val and parent. Add arg
7875 top. Give decoded values to a Lisp function.
640c8776 7876 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7877 values to a Lisp function. Gcpro more variables.
7878 (uniprop_table_uncompress)
7879 (uniprop_decode_value_run_length): New functions.
7880 (uniprop_decoder, uniprop_decoder_count): New variables.
7881 (uniprop_get_decoder, uniprop_encode_value_character)
7882 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7883 New functions.
7884 (uniprop_encoder, uniprop_encoder_count): New variables.
7885 (uniprop_get_encoder, uniprop_table)
7886 (Funicode_property_table_internal, Fget_unicode_property_internal)
7887 (Fput_unicode_property_internal): New functions.
7888 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7889 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7890 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7891 char-code-property-alist.
7892
640c8776 7893 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7894 Vunicode_category_table.
7895
640c8776 7896 * font.c (font_range): Adjust for the change of
c805dec0
KH
7897 Vunicode_category_table.
7898
76b397fb
DN
78992011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7900
7901 * m/iris4d.h: Remove file, move contents ...
7902 * s/irix6-5.h: ... here.
7903
22b4128e
PE
79042011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7905
7906 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7907 * alloc.c (mark_buffer):
7908 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7909 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7910 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7911 This isn't true in general, and it's particularly not true
7912 if Emacs is configured with --with-wide-int.
7913 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7914 New macros, used in the buffer.c change.
7915
869795d6
JD
79162011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7917
7918 * xsettings.c: Use both GConf and GSettings if both are available.
7919 (store_config_changed_event): Add comment.
7920 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7921 (store_tool_bar_style_changed): New functions.
5e617bc2 7922 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7923 (struct xsettings): Move font inside HAVE_XFT.
7924 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7925 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7926 Move inside HAVE_XFT.
640c8776 7927 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7928 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7929 also.
7930 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7931 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7932 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7933 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7934 (parse_settings): Move check for font inside HAVE_XFT.
7935 (read_settings, apply_xft_settings): Add comment.
7936 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7937 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7938 call store_font_name_changed.
7939 (xft_settings_event): Add comment.
7940 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7941 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7942 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7943 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7944 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7945 (xsettings_get_system_font, xsettings_get_system_normal_font):
7946 Add comment.
869795d6 7947
d8ed26bd
PE
79482011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7949
7950 Random fixes. E.g., (random) never returned negative values.
7951 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7952 subseconds part to the entropy, as that's a bit more random.
7953 Prefer signed to unsigned, since the signedness doesn't matter and
7954 in general we prefer signed. When given a limit, use a
7955 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7956 latter isn't right if USE_2_TAGS_FOR_INTS.
7957 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7958 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7959
cabf1cac
SM
79602011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7961
7962 * textprop.c (text_property_stickiness):
7963 Obey Vtext_property_default_nonsticky.
7964 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7965 * w32fns.c (syms_of_w32fns):
7966 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7967
6e9b2be9
PE
79682011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7969
7970 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7971 This is more efficient than Ffile_directory_p and avoids a minor race.
7972
90186c68
LMI
79732011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7974
7c301272
LMI
7975 * buffer.c (Foverlay_put): Say what the return value is
7976 (bug#7835).
7977
c4f2d8d4
LMI
7978 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7979 is a directory before asking whether to use the file name
7980 (bug#7564).
ad637907
LMI
7981 (barf_or_query_if_file_exists): Make the "File is a directory"
7982 error be more correct.
c4f2d8d4 7983
90186c68
LMI
7984 * fns.c (Frequire): Remove the mention of the .gz files, since
7985 that's installation-specific, but keep the mention of
7986 `get-load-suffixes'.
7987
da64016e
PE
79882011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7989
7990 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7991 Report string overflow if the output is too long.
7992
7d47b580
JB
79932011-07-04 Juanma Barranquero <lekktu@gmail.com>
7994
a555cb87
JB
7995 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7996 (syms_of_gnutls): Remove duplicate DEFSYM for
7997 Qgnutls_bootprop_verify_hostname_error, an error for
7998 Qgnutls_bootprop_verify_error (which is no longer used).
7999
7d47b580
JB
8000 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8001 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8002 Also (re)move comments that are misplaced or no longer relevant.
8003
1e49bfab
LMI
80042011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8005
8006 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8007
1485f4c0
CY
80082011-07-03 Chong Yidong <cyd@stupidchicken.com>
8009
8010 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8011 and background color parameters if they have been changed.
8012
a9ab721e
LMI
80132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8014
8015 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8016
cf7cff57
PE
80172011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8018
2e13213d
PE
8019 * xsettings.c (SYSTEM_FONT): Define only when used.
8020 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8021
cf7cff57
PE
8022 * keymap.c (access_keymap_1): Now static.
8023
7a8e04f7
CY
80242011-07-02 Chong Yidong <cyd@stupidchicken.com>
8025
8026 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8027 leave any prefix arg for the up event (Bug#1586).
8028
61352f62
LMI
80292011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8030
69bb1ef7
LMI
8031 * lread.c (syms_of_lread): Mention single symbols defined by
8032 `defvar' or `defconst' (bug#7154).
8033
61352f62 8034 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8035 (Frequire): Mention get-load-suffixes.
61352f62 8036
28545e04
MR
80372011-07-02 Martin Rudalics <rudalics@gmx.at>
8038
8039 * window.h (window): Remove clone_number slot.
8040 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8041 Remove.
8042 (make_parent_window, make_window, saved_window)
8043 (Fset_window_configuration, save_window_save): Don't deal with
8044 clone numbers.
8045 * buffer.c (Qclone_number): Remove declaration.
8046 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8047
3349e122
SM
80482011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8049
8050 Add multiple inheritance to keymaps.
8051 * keymap.c (Fmake_composed_keymap): New function.
8052 (Fset_keymap_parent): Simplify.
8053 (fix_submap_inheritance): Remove.
8054 (access_keymap_1): New function extracted from access_keymap to handle
8055 embedded parents and handle lists of maps.
8056 (access_keymap): Use it.
8057 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8058 (Fcopy_keymap): Handle embedded parents.
8059 (Fcommand_remapping, define_as_prefix): Simplify.
8060 (Fkey_binding): Simplify.
8061 (syms_of_keymap): Move minibuffer-local-completion-map,
8062 minibuffer-local-filename-completion-map,
8063 minibuffer-local-must-match-map, and
8064 minibuffer-local-filename-must-match-map to Elisp.
8065 (syms_of_keymap): Defsubr make-composed-keymap.
8066 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8067 (parse_menu_item): Trivial simplification.
8068
3279eb87
GM
80692011-07-01 Glenn Morris <rgm@gnu.org>
8070
8071 * Makefile.in (SETTINGS_LIBS): Fix typo.
8072
4550efdf
KI
80732011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8074
8075 * coding.c (Fencode_coding_string): Record the last coding system
8076 used, as the function doc string says (bug#8738).
8077
0949d2b6
JD
80782011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8079
8080 * xsettings.c (store_monospaced_changed): Take new font as arg and
8081 check for change against current_mono_font.
8082 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8083 (emacs_settings_constructor, emacs_settings_get_property)
8084 (emacs_settings_set_property, emacs_settings_class_init)
8085 (emacs_settings_init, gsettings_obj): Remove.
8086 (something_changedCB): New function for HAVE_GSETTINGS.
8087 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8088 with value as argument.
8089 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8090 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8091 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8092 "changed".
8093
8094 * xgselect.c: Add defined (HAVE_GSETTINGS).
8095 (xgselect_initialize): Ditto.
8096
8097 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8098 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8099 xg_select.
8100
bbc6b304
PE
81012011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8102
8103 * eval.c (struct backtrace): Simplify and port the data structure.
8104 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8105 signed bit field, as this assumption is not portable and it makes
8106 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8107 "char debug_on_exit : 1" as this is not portable either; instead,
8108 use the portable "unsigned int debug_on_exit : 1". Remove unused
8109 member evalargs. Remove obsolete comments about cc bombing out.
8110
9851bfc5
JD
81112011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8112
51bb811f 8113 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8114 Let HAVE_GSETTINGS override HAVE_GCONF.
8115 (store_monospaced_changed): New function.
8116 (EMACS_SETTINGS): A new type derived from GObject to handle
8117 GSettings notifications.
8118 (emacs_settings_constructor, emacs_settings_get_property)
8119 (emacs_settings_set_property, emacs_settings_class_init):
8120 New functions.
8121 (gsettings_client, gsettings_obj): New variables.
8122 (GSETTINGS_SCHEMA): New define.
8123 (something_changedCB): Call store_monospaced_changed.
8124 (init_gsettings): New function.
8125 (xsettings_initialize): Call init_gsettings.
8126 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8127 to NULL.
8128
640c8776 8129 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8130 GCONF_CFLAGS/LIBS.
8131
5386012d
MR
81322011-06-29 Martin Rudalics <rudalics@gmx.at>
8133
8134 * window.c (resize_root_window, grow_mini_window)
8135 (shrink_mini_window): Rename Qresize_root_window to
8136 Qwindow_resize_root_window and Qresize_root_window_vertically to
8137 Qwindow_resize_root_window_vertically.
8138
f13e0b08
PE
81392011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8140
8141 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8142
94515237
JB
81432011-06-27 Juanma Barranquero <lekktu@gmail.com>
8144
8145 * makefile.w32-in: Redesign dependencies so they reflect more
8146 clearly which files are directly included by each source file,
8147 and not through other includes.
8148
e43b6e43
MR
81492011-06-27 Martin Rudalics <rudalics@gmx.at>
8150
8151 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8152 (sort_overlays, overlay_strings): When an overlay's clone number
8153 matches the window's clone number process the overlay even if
8154 the overlay's window property doesn't match the current window.
8155
d68443dc
MR
8156 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8157 (Fwindow_hchild): Rename to Fwindow_left_child.
8158 (Fwindow_next): Rename to Fwindow_next_sibling.
8159 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8160 (resize_window_check): Rename to window_resize_check.
8161 (resize_window_apply): Rename to window_resize_apply.
8162 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8163 (Fdelete_other_windows_internal, resize_frame_windows)
8164 (Fsplit_window_internal, Fdelete_window_internal)
8165 (grow_mini_window, shrink_mini_window)
8166 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8167
c7e73be5
JD
81682011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8169
8170 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8171 (emacs_fixed_set_min_size): Remove.
8172 (emacs_fixed_new): Take frame as argument.
8173
8174 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8175 (_EmacsFixedPrivate): Remove minwidth/height.
8176 Add struct frame *f.
8177 (emacs_fixed_init): Initialize priv->f.
8178 (get_parent_class, emacs_fixed_set_min_size): Remove.
8179 (emacs_fixed_new): Set priv->f to argument.
8180 (emacs_fixed_get_preferred_width)
8181 (emacs_fixed_get_preferred_height): Use min_width/height from
8182 frames size_hint to set minimum and natural (Bug#8919).
8183 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8184 and use min_width/height from frames size_hint to set
8185 min_width/height (Bug#8919).
8186
8187 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8188 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8189 Fix indentation.
c7e73be5 8190
cf99dcf8
EZ
81912011-06-26 Eli Zaretskii <eliz@gnu.org>
8192
8193 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8194 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8195 called at ZV.
8196
029529ac
CY
81972011-06-26 Chong Yidong <cyd@stupidchicken.com>
8198
8199 * process.c (wait_reading_process_output): Bypass select if
8200 waiting for a cell while ignoring keyboard input, and input is
8201 pending. Suggested by Jan Djärv (Bug#8869).
8202
7a7ef429
PE
82032011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8204
8205 Use gnulib's dup2 module instead of rolling our own.
8206 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8207
11fdef7d 82082011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8209
8210 * dispnew.c (scrolling_window): Before scrolling, turn off a
8211 mouse-highlight in the window being scrolled.
8212
cd3520a4
JB
82132011-06-24 Juanma Barranquero <lekktu@gmail.com>
8214
8215 Move DEFSYM to lisp.h and use everywhere.
8216
8217 * character.h (DEFSYM): Move declaration...
8218 * lisp.h (DEFSYM): ...here.
8219
8220 * gnutls.c:
8221 * minibuf.c:
8222 * w32menu.c:
8223 * w32proc.c:
8224 * w32select.c: Don't include character.h.
8225
8226 * alloc.c (syms_of_alloc):
8227 * buffer.c (syms_of_buffer):
8228 * bytecode.c (syms_of_bytecode):
8229 * callint.c (syms_of_callint):
8230 * casefiddle.c (syms_of_casefiddle):
8231 * casetab.c (init_casetab_once):
8232 * category.c (init_category_once, syms_of_category):
8233 * ccl.c (syms_of_ccl):
8234 * cmds.c (syms_of_cmds):
8235 * composite.c (syms_of_composite):
8236 * dbusbind.c (syms_of_dbusbind):
8237 * dired.c (syms_of_dired):
8238 * dispnew.c (syms_of_display):
8239 * doc.c (syms_of_doc):
8240 * editfns.c (syms_of_editfns):
8241 * emacs.c (syms_of_emacs):
8242 * eval.c (syms_of_eval):
8243 * fileio.c (syms_of_fileio):
8244 * fns.c (syms_of_fns):
8245 * frame.c (syms_of_frame):
8246 * fringe.c (syms_of_fringe):
8247 * insdel.c (syms_of_insdel):
8248 * keymap.c (syms_of_keymap):
8249 * lread.c (init_obarray, syms_of_lread):
8250 * macros.c (syms_of_macros):
8251 * msdos.c (syms_of_msdos):
8252 * print.c (syms_of_print):
8253 * process.c (syms_of_process):
8254 * search.c (syms_of_search):
8255 * sound.c (syms_of_sound):
8256 * syntax.c (init_syntax_once, syms_of_syntax):
8257 * terminal.c (syms_of_terminal):
8258 * textprop.c (syms_of_textprop):
8259 * undo.c (syms_of_undo):
8260 * w32.c (globals_of_w32):
8261 * window.c (syms_of_window):
8262 * xdisp.c (syms_of_xdisp):
8263 * xfaces.c (syms_of_xfaces):
8264 * xfns.c (syms_of_xfns):
8265 * xmenu.c (syms_of_xmenu):
8266 * xsettings.c (syms_of_xsettings):
8267 * xterm.c (syms_of_xterm): Use DEFSYM.
8268
4228cf16
TZ
82692011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8270
cd3520a4 8271 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8272
7fcccf1e
PE
82732011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8274
7efb4e0e
PE
8275 Integer and buffer overflow fixes (Bug#8873).
8276
ff5844ad
PE
8277 * print.c (printchar, strout): Check for string overflow.
8278 (PRINTPREPARE, printchar, strout):
8279 Don't set size unless allocation succeeds.
8280
90532f02
PE
8281 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8282 for sizes. Check for string overflow more accurately.
8283 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8284
6d84508d
PE
8285 * macros.c: Integer and buffer overflow fixes.
8286 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8287 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8288 Use ptrdiff_t, not int, for sizes.
8289 Don't increment bufsize until after realloc succeeds.
8290 Check for size-calculation overflow.
8291 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8292
437b2cb4
PE
8293 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8294
8b9ac8b4
PE
8295 * lread.c: Integer overflow fixes.
8296 (read_integer): Radix is now EMACS_INT, not int,
8297 to improve quality of diagnostics for out-of-range radices.
8298 Calculate buffer size correctly for out-of-range radices.
8299 (read1): Check for integer overflow in radices, and in
8300 read-circle numbers.
82cb60d3
PE
8301 (read_escape): Avoid int overflow.
8302 (Fload, openp, read_buffer_size, read1)
8303 (substitute_object_recurse, read_vector, read_list, map_obarray):
8304 Use ptrdiff_t, not int, for sizes.
8305 (read1): Use EMACS_INT, not int, for sizes.
20270765 8306 Check for size overflow.
8b9ac8b4 8307
7fcccf1e
PE
8308 * image.c (cache_image): Check for size arithmetic overflow.
8309
bfbbd7e7
PE
8310 * lread.c: Integer overflow issues.
8311 (saved_doc_string_size, saved_doc_string_length)
8312 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8313 Now ptrdiff_t, not int.
8314 (read1): Don't assume doc string length fits in int. Check for
8315 out-of-range doc string lengths.
8316 (read_list): Don't assume file position fits in int.
39019e54 8317 (read_escape): Check for hex character overflow.
bfbbd7e7 8318
4e323265
LL
83192011-06-22 Leo Liu <sdl.web@gmail.com>
8320
8321 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8322 Move to minibuffer.el.
8323
85fece3e
PE
83242011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8325
20b84ce9 8326 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8327 The following patches are for when GLYPH_DEBUG && !XASSERT.
8328 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8329 * dispnew.c (flush_stdout):
8330 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8331 Mark as externally visible.
8332 * dispnew.c (check_window_matrix_pointers): Now static.
8333 * dispnew.c (window_to_frame_vpos):
8334 * xfns.c (unwind_create_frame):
8335 * xterm.c (x_check_font): Remove unused local.
8336 * scroll.c (CHECK_BOUNDS):
8337 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8338 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8339 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8340 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8341 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8342 Now static.
8343 (debug_method_add): Use va_list and vsprintf rather than relying
8344 on undefined behavior with wrong number of arguments.
8345 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8346 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8347 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8348 since we're not interested in debugging glyphs with old libraries.
8349 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8350 GCC 4.6.0's static checking.
8351
0766b489
PE
83522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8353
31fd4b32
PE
8354 Integer overflow and signedness fixes (Bug#8873).
8355 A few related buffer overrun fixes, too.
8356
b79e8648
PE
8357 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8358
0766b489
PE
8359 * dispextern.h (struct face.stipple):
8360 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8361 (x_bitmap_mask, x_allocate_bitmap_record)
8362 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8363 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8364 (x_create_bitmap_from_xpm_data):
8365 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8366 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8367 (.bitmaps_last):
8368 * xfaces.c (load_pixmap):
8369 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8370 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8371 (.bitmaps_last, struct x_output.icon_bitmap):
8372 Use ptrdiff_t, not int, for bitmap indexes.
8373 (x_allocate_bitmap_record): Check for size overflow.
8374 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8375
b081724f
PE
8376 Use ptrdiff_t, not int, for overlay counts.
8377 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8378 * editfns.c (overlays_around, get_pos_property):
8379 * textprop.c (get_char_property_and_overlay):
8380 * xdisp.c (next_overlay_change, note_mouse_highlight):
8381 * xfaces.c (face_at_buffer_position):
21514da7
PE
8382 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8383 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8384 (Fnext_overlay_change, Fprevious_overlay_change)
8385 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8386 Use ptrdiff_t, not int, for sizes.
21514da7 8387 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8388
3de73e5e
PE
8389 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8390
2606c57b
PE
8391 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8392 (x_session_initialize): Do not assume string length fits in int.
8393
aaafe47a
PE
8394 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8395 This is unlikely, but can occur if DPI is outlandish.
8396
2674ddc8 8397 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8398 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8399
28154962
PE
8400 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8401 * xrdb.c (magic_file_p, search_magic_path):
8402 Omit last arg SUFFIX; it was always 0. All callers changed.
8403 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8404
7de51af5
PE
8405 * xfont.c (xfont_match): Avoid need for strlen.
8406
25ed6cc3
PE
8407 * xfns.c: Don't assume strlen fits in int.
8408 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8409
4eab31dd
PE
8410 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8411 not unsigned long, as we prefer signed integers. All callers changed.
8412 Detect integer overflow in repeat count.
8413 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8414 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8415
171e2a58
PE
8416 * termcap.c: Don't assume sizes fit in int and never overflow.
8417 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8418 (gobble_line): Check for size-calculation overflow.
8419
ad39faca 8420 * minibuf.c (Fread_buffer):
6e5bb2dc 8421 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8422 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8423 Don't assume string length fits in int.
8424
52c61c22 8425 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8426 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8427
b5b8c9e5
PE
8428 * font.c: Don't assume string length fits in int.
8429 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8430 Use ptrdiff_t, not int.
ccd6111c
PE
8431 (font_intern_prop): Don't assume string length fits in int.
8432 Don't assume integer property fits in fixnum.
8433 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8434
882f0d81 8435 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8436 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8437 Reformulate so as not to need the command string.
8438 Invoke gzip -cd rather than gunzip, as it's more portable.
8439 (lock_info_type, lock_file_1, lock_file):
8440 Don't assume pid_t and time_t fit in unsigned long.
8441 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8442 (current_lock_owner): Prefer signed type for sizes.
8443 Use memcpy, not strncpy, where memcpy is what is really wanted.
8444 Don't assume (via atoi) that time_t and pid_t fit in int.
8445 Check for time_t and/or pid_t out of range, e.g., via a network share.
8446 Don't alloca where an auto var works fine.
8447
93f4cf88
PE
8448 * fileio.c: Fix some integer overflow issues.
8449 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8450 Don't assume string length fits in int.
8451 (directory_file_name): Don't assume string length fits in long.
8452 (make_temp_name): Don't assume pid fits in int, or that its print
8453 length is less than 20.
8454
f3e92b69
PE
8455 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8456
1bfdaf10
PE
8457 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8458
35016e9a
PE
8459 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8460
3d1e65a1
PE
8461 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8462 We prefer signed integers, even for size calculations.
8463
0b963a93
PE
8464 * emacs.c: Don't assume string length fits in 'int'.
8465 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8466 (main): Don't invoke strlen when not needed.
8467
573f4b54
PE
8468 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8469 (XD_DEBUG_MESSAGE): Don't waste a byte.
8470
989f33ba
PE
8471 * callproc.c (getenv_internal_1, getenv_internal)
8472 (Fgetenv_internal):
965d34eb
PE
8473 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8474
e4d29b33
PE
8475 * lread.c (invalid_syntax): Omit length argument.
8476 All uses changed. This doesn't fix a bug, but it simplifies the
8477 code away from its former Hollerith-constant appearance, and it's
8478 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8479 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8480
eb49b136
PE
8481 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8482 This didn't break anything, but it didn't help either.
8483 It's confusing to put a bogus integer in a place where the actual
8484 value does not matter.
9f62aeb1 8485 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8486 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8487
15375a22
PE
8488 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8489 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8490 implementation.
b61cc01c
PE
8491 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8492 We prefer signed types, and the value cannot exceed the EMACS_INT
8493 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8494 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8495 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8496 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8497
53b2623d
PE
8498 * indent.c (sane_tab_width): New function.
8499 (current_column, scan_for_column, Findent_to, position_indentation)
8500 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8501 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8502
51cab52b 8503 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8504
f2ed8a70
PE
8505 * lisp.h (lint_assume): New macro.
8506 * composite.c (composition_gstring_put_cache):
8507 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8508
abe80cc6
PE
8509 * editfns.c, insdel.c:
8510 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8511
b02c740e
PE
8512 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8513
ebc96716
PE
8514 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8515
b4e50fa0 8516 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8517 Use much-faster test for byte-length change.
311d5d7c 8518 Don't assume string byte-length fits in 'int'.
a4cf38e4 8519 Check that character arg fits in 'int'.
85461888 8520 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8521
c0c1ee9f
PE
8522 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8523
a498d7f4
PE
8524 * fns.c (concat): Catch string overflow earlier.
8525 Do not rely on integer wraparound.
8526
51cab52b
PE
8527 * dispextern.h (struct it.overlay_strings_charpos)
8528 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8529 * xdisp.c (forward_to_next_line_start)
8530 (back_to_previous_visible_line_start)
8531 (reseat_at_next_visible_line_start, next_element_from_buffer):
8532 Don't arbitrarily truncate the value of 'selective' to int.
8533
76031fad
PE
8534 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8535
5eb55db9
PE
8536 * composite.c: Don't truncate sizes to 'int'.
8537 (composition_gstring_p, composition_reseat_it)
8538 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8539 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8540 not EMACS_UINT, for indexes.
5eb55db9 8541
0703a717
PE
8542 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8543
d6202519
PE
8544 * buffer.c: Include <verify.h>.
8545 (struct sortvec.priority, struct sortstr.priority):
8961a454 8546 Now EMACS_INT, not int.
c20998a7 8547 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8548 (struct sortstr.size, record_overlay_string)
8549 (struct sortstrlist.size, struct sortlist.used):
8550 Don't truncate size to int.
8551 (record_overlay_string): Check for size-calculation overflow.
d6202519 8552 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8553
d5a19415
JM
85542011-06-22 Jim Meyering <meyering@redhat.com>
8555
029529ac 8556 Don't leak an XBM-image-sized buffer
d5a19415
JM
8557 * image.c (xbm_load): Free the image buffer after using it.
8558
a9041e6c
PE
85592011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8560
8561 Port to Sun C.
8562 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8563 that Sun C diagnosed.
8564 * fns.c (secure_hash): Fix pointer signedness issue.
8565 * intervals.c (static_offset_intervals): New function.
8566 (offset_intervals): Use it.
8567
7f3f739f
LL
85682011-06-21 Leo Liu <sdl.web@gmail.com>
8569
8570 * deps.mk (fns.o):
8571 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8572 sha512.h.
8573
8574 * fns.c (secure_hash): Rename from crypto_hash_function and change
8575 the first arg to accept symbols.
5b66d427 8576 (Fsecure_hash): New primitive.
7f3f739f
LL
8577 (syms_of_fns): New symbols.
8578
76147d94
DD
85792011-06-20 Deniz Dogan <deniz@dogan.se>
8580
8581 * process.c (Fset_process_buffer): Clarify return value in
8582 docstring.
8583
7d7d0045
CY
85842011-06-18 Chong Yidong <cyd@stupidchicken.com>
8585
8586 * dispnew.c (add_window_display_history): Use BVAR.
8587
8588 * xdisp.c (debug_method_add): Use BVAR.
8589 (check_window_end, dump_glyph_matrix, dump_glyph)
8590 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8591
8592 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8593 Likewise.
8594
8595 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8596 check till after the cache is created in init_frame_faces.
8597
ff2bc410
SM
85982011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8599
8600 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8601
28177add
PE
86022011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8603
dd3482fe
PE
8604 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8605 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8606 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8607
393d71f3 8608 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8609 * fileio.c (Finsert_file_contents):
8610 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8611 Remove the old (too-loose) buffer overflow checks.
8612 They weren't needed, since make_gap checks for buffer overflow.
8613 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8614 The old code merely checked for Emacs fixnum overflow, and relied
8615 on undefined (wraparound) behavior. The new code avoids undefined
8616 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8617
2e6813b0 8618 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8619 Tune. Don't use wider integers than needed. Don't use alloca.
8620 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8621
599a9e4f
PE
8622 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8623
99561444
PE
8624 * insdel.c, lisp.h (buffer_overflow): New function.
8625 (insert_from_buffer_1, replace_range, replace_range_2):
8626 * insdel.c (make_gap_larger):
8627 * editfns.c (Finsert_char):
8628 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8629
28177add
PE
8630 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8631
e69dafad
PE
86322011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8633
4baa020d 8634 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8635
b1c46f02
PE
8636 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8637 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8638
e69dafad
PE
8639 * fileio.c: Don't assume EMACS_INT fits in off_t.
8640 (emacs_lseek): New static function.
8641 (Finsert_file_contents, Fwrite_region): Use it.
8642 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8643
566684ea
PE
8644 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8645
e6966cd6
PE
8646 * fns.c: Don't overflow int when computing a list length.
8647 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8648 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8649 truncation on 64-bit hosts. Check for QUIT every
8650 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8651 faster and is responsive enough.
8652 (Flength): Report an error instead of overflowing an integer.
8653 (Fsafe_length): Return a float if the value is not representable
8654 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8655 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8656 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8657
dd0b0efb
PE
8658 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8659 (header_size, word_size): New constants.
8660 (allocate_vectorlike): Don't check size overflow here.
8661 (allocate_vector): Check it here instead, since this is the only
8662 caller of allocate_vectorlike that could cause overflow.
8663 Check that the new vector's length is representable as a fixnum.
8664
86fe5cfe
PE
8665 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8666 The previous code was bogus. For example, next_almost_prime (32)
8667 returned 39, which is undesirable as it is a multiple of 3; and
8668 next_almost_prime (24) returned 25, which is a multiple of 5 so
8669 why was the code bothering to check for multiples of 7?
8670
80e88859
PE
8671 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8672
4a2f0ad6
PE
8673 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8674
f66c7cf8
PE
8675 Variadic C functions now count arguments with ptrdiff_t.
8676 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8677 Back then I didn't know that the Emacs coding style prefers signed int.
8678 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8679 were being counted with int, which may truncate counts on 64-bit
8680 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8681 * lisp.h (struct Lisp_Subr.function.aMANY)
8682 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8683 Arg counts are now ptrdiff_t, not size_t.
8684 All variadic functions and their callers changed accordingly.
8685 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8686 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8687 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8688 * callint.c (Fcall_interactively): Check arg count for overflow,
8689 to avoid potential buffer overrun. Use signed char, not 'int',
8690 for 'varies' array, so that we needn't bother to check its size
8691 calculation for overflow.
8692 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8693 * eval.c (apply_lambda):
8694 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8695 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8696 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8697
a1759b76
PE
8698 * callint.c (Fcall_interactively): Don't use index var as event count.
8699
d96be9fc
PE
8700 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8701 * mem-limits.h (SIZE): Remove; no longer used.
8702
a690a978 8703 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8704
578c21e6
PE
8705 Remove unnecessary casts.
8706 * xterm.c (x_term_init):
8707 * xfns.c (x_set_border_pixel):
8708 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8709 These aren't needed now that we assume ANSI C.
8710
96f53c6c
PE
8711 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8712 It's more likely to cause problems (due to unsigned overflow)
8713 than to cure them.
8714
83c77d31
PE
8715 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8716
ee2079f1
PE
8717 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8718
6da65536
PE
8719 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8720
7147c4a4
PE
8721 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8722
193e32d9
PE
8723 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8724
e5533da6
PE
8725 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8726
9910e595
PE
8727 GLYPH_CODE_FACE returns EMACS_INT, not int.
8728 * dispextern.h (merge_faces):
8729 * xfaces.c (merge_faces):
01103c44
PE
8730 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8731 Don't assume EMACS_INT fits in int.
9910e595 8732
2638320e
PE
8733 * character.h (CHAR_VALID_P): Remove unused parameter.
8734 * fontset.c, lisp.h, xdisp.c: All uses changed.
8735
045eb8d9
PE
8736 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8737
c1f134b5
PE
8738 * fns.c (concat): Minor tuning based on overflow analysis.
8739 This doesn't fix any bugs. Use int to hold character, instead
8740 of constantly refetching from Emacs object. Use XFASTINT, not
8741 XINT, for value known to be a character. Don't bother comparing
8742 a single byte to 0400, as it's always less.
8743
395fcb93 8744 * floatfns.c (Fexpt):
327eeec8
PE
8745 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8746
abbd3d23
PE
8747 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8748 for characters.
8749
684a03ef
PE
8750 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8751
0fed43f3
PE
8752 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8753 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8754 incorrectly succeed when S was a string, because 4294967386 was
8755 truncated before it was used.
8756
8fd02eb7
PE
8757 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8758 Otherwise, an out-of-range integer could cause undefined behavior
8759 on a 64-bit host.
8760
f8c86b69
PE
8761 * composite.c: Use int, not EMACS_INT, for characters.
8762 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8763 EMACS_INT, for values that are known to be in character range.
8764 This doesn't fix any bugs but is the usual style inside Emacs and
8765 may generate better code on 32-bit machines.
8766
34206dd2
PE
8767 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8768 This is for reasons similar to the recent CHAR_STRING fix.
8769 * charset.c (Fencode_char): Check that character arg is actually
8770 a character. Pass an int to ENCODE_CHAR.
8771 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8772 wider than 'int', as a compile-time check to prevent future regressions
8773 in this area.
8774
c5958d4c 8775 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8776
8777 Make sure a 64-bit char is never passed to CHAR_STRING.
8778 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8779 by silently ignoring the top 32 bits, allowing some values
8780 that were far too large to be valid characters.
8781 * character.h: Include <verify.h>.
8782 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8783 arguments are no wider than unsigned, as a compile-time check
8784 to prevent future regressions in this area.
8785 * data.c (Faset):
01103c44 8786 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8787 (Fsubst_char_in_region):
8788 * fns.c (concat):
8789 * xdisp.c (decode_mode_spec_coding):
8790 Adjust to CHAR_STRING's new requirement.
8791 * editfns.c (Finsert_char, Fsubst_char_in_region):
8792 * fns.c (concat): Check that character args are actually
8793 characters. Without this test, these functions did the wrong
8794 thing with wildly out-of-range values on 64-bit hosts.
8795
d37ca623
PE
8796 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8797 These casts should not be needed on 32-bit hosts, either.
8798 * keyboard.c (read_char):
8799 * lread.c (Fload): Remove casts to unsigned.
8800
ea204efb
PE
8801 * lisp.h (UNSIGNED_CMP): New macro.
8802 This fixes comparison bugs on 64-bit hosts.
8803 (ASCII_CHAR_P): Use it.
8804 * casefiddle.c (casify_object):
01103c44 8805 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8806 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8807 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8808 * dispextern.h (FACE_FROM_ID):
8809 * keyboard.c (read_char): Use UNSIGNED_CMP.
8810
41cb286c
PE
8811 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8812 not to EMACS_INT, to avoid GCC warning.
8813
4a1b9832
PE
8814 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8815
55daad71
PE
8816 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8817 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8818 isn't needed on 32-bit machines.
8f95c75c 8819
01103c44
PE
8820 * buffer.c (Fgenerate_new_buffer_name):
8821 Use EMACS_INT for count, not int.
0ceccced 8822 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8823
8824 * data.c (Qcompiled_function): Now static.
8825
c6f072e7
PE
8826 * window.c (window_body_lines): Now static.
8827
20ce5912
PE
8828 * image.c (gif_load): Rename local to avoid shadowing.
8829
9c4c5f81
PE
8830 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8831 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8832 * alloc.c (make_save_value): Integer argument is now of type
8833 ptrdiff_t, not int.
8834 (mark_object): Use ptrdiff_t, not int.
8835 * lisp.h (pD): New macro.
8836 * print.c (print_object): Use it.
8837
c0c5c8ae
PE
8838 * alloc.c: Use EMACS_INT, not int, to count objects.
8839 (total_conses, total_markers, total_symbols, total_vector_size)
8840 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8841 (total_free_floats, total_floats, total_free_intervals)
8842 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8843 Now EMACS_INT, not int. All uses changed.
8844 (Fgarbage_collect): Compute overall total using a double, so that
8845 integer overflow is less likely to be a problem. Check for overflow
8846 when converting back to an integer.
5a25e253
PE
8847 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8848 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8849 These were 'int' variables that could overflow on 64-bit hosts;
8850 they were never used, so remove them instead of repairing them.
211a0b2a 8851 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8852 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8853 Previously, this ceilinged at INT_MAX, but that doesn't work on
8854 64-bit machines.
e46bb31a 8855 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8856
c78baabf 8857 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8858 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8859 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8860 when a (possibly-narrower) signed value would do just as well.
8861 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8862
c9d624c6
PE
8863 * alloc.c: Catch some string size overflows that we were missing.
8864 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8865 for convenience in STRING_BYTES_MAX.
8866 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8867 The definition here is exact; the one in lisp.h was approximate.
8868 (allocate_string_data): Check for string overflow. This catches
8869 some instances we weren't catching before. Also, it catches
8870 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8871 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8872 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8873
c9d624c6
PE
8874 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8875 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8876 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8877
353032ce
PE
8878 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8879
2bccce07
PE
8880 * alloc.c (Fmake_string): Check for out-of-range init.
8881
0ac30604
SM
88822011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8883
8884 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8885
c195f2de
JD
88862011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8887
8888 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8889 xg_get_default_scrollbar_width.
8890
8891 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8892 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8893 (style_changed_cb): Call update_theme_scrollbar_width and call
8894 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8895 all frames (Bug#8505).
8896 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8897 Call gtk_window_set_resizable if HAVE_GTK3.
8898 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8899 and height if HAVE_GTK3 (Bug#8505).
8900 (scroll_bar_width_for_theme): New variable.
8901 (update_theme_scrollbar_width): New function.
8902 (xg_get_default_scrollbar_width): Move code to
8903 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8904 (xg_initialize): Call update_theme_scrollbar_width.
8905
8906 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8907
8908 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8909
e10ac9f1
MR
89102011-06-12 Martin Rudalics <rudalics@gmx.at>
8911
8912 * frame.c (make_frame): Call other_buffer_safely instead of
8913 other_buffer.
8914
8915 * window.c (temp_output_buffer_show): Call display_buffer with
8916 second argument Vtemp_buffer_show_specifiers and reset latter
8917 immediately after the call.
8918 (Vtemp_buffer_show_specifiers): New variable.
8919 (auto_window_vscroll_p, next_screen_context_lines)
8920 (Vscroll_preserve_screen_position): Remove leading asterisks from
8921 doc-strings.
8922
2d3c217e 89232011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8924
7b7f97e8 8925 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8926 * buffer.c (Qclone_number): Remove for now, as it's unused.
8927 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8928 (record_buffer): Remove unused local.
8929 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8930 (set_frame_buffer_list): Remove; unused.
8931 * frame.h (other_visible_frames): Remove decl.
8932 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8933 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8934 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8935 if HAVE_GPM.
8936 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8937 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8938 Define only if HAVE_GPM.
8939 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8940 (update_hints_inhibit): Remove; never set. All uses removed.
8941 * widgetprv.h (emacsFrameClassRec): Remove decl.
8942 * window.c (delete_deletable_window): Now returns void, since it
8943 wasn't returning anything.
8944 (compare_window_configurations): Remove unused locals.
8945 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8946 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8947 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8948 the same widths as pointers. This follows up on the 2011-05-06 patch.
8949 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8950 * xterm.h: Likewise.
8951 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8952
1384b89e
JB
89532011-06-12 Juanma Barranquero <lekktu@gmail.com>
8954
8955 * makefile.w32-in: Update dependencies.
8956 (LISP_H): Add lib/intprops.h.
8957
1100a63c
CY
89582011-06-11 Chong Yidong <cyd@stupidchicken.com>
8959
8960 * image.c (gif_load): Add animation frame delay to the metadata.
8961 (syms_of_image): Use DEFSYM. New symbol `delay'.
8962
6198ccd0
MR
89632011-06-11 Martin Rudalics <rudalics@gmx.at>
8964
8965 * window.c (delete_deletable_window): Re-add.
8966 (Fset_window_configuration): Rewrite to handle dead buffers and
8967 consequently deletable windows.
8968 (window_tree, Fwindow_tree): Remove. Supply functionality in
8969 window.el.
8970 (compare_window_configurations): Simplify code.
8971
b6e3633c
AS
89722011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8973
1ab0dee5
AS
8974 * image.c (imagemagick_load_image): Fix type mismatch.
8975 (Fimagemagick_types): Likewise.
8976
b6e3633c
AS
8977 * window.h (replace_buffer_in_windows): Declare.
8978
9397e56f
MR
89792011-06-11 Martin Rudalics <rudalics@gmx.at>
8980
8981 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8982 Qclone_number. Remove external declaration of Qdelete_window.
8983 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8984 code.
640c8776
SM
8985 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8986 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8987 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8988 buffer list implementation.
8989 (other_buffer_safely): New function.
8990 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8991 calls to replace_buffer_in_windows and
8992 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8993 if allowed.
8994 (record_buffer): Inhibit quitting and rewrite using quittable
8995 functions. Run Qbuffer_list_update_hook if allowed.
8996 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8997 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8998 Move switch-to-buffer to window.el.
9397e56f
MR
8999 (bury-buffer): Move to window.el.
9000 (Vbuffer_list_update_hook): New variable.
9001
9002 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9003 section.
9004
9005 * window.h (resize_frame_windows): Move up in code.
9006 (Fwindow_frame): Remove EXFUN.
9007 (replace_buffer_in_all_windows): Remove prototype.
9008 (replace_buffer_in_windows_safely): Add prototype.
9009
9010 * window.c: Declare Qdelete_window static again. Move down
9011 declaration of select_count.
9012 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9013 (Fother_window): Move to window.el.
9014 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9015 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9016 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9017 window.el.
9018 (replace_buffer_in_windows): Implement by calling
9019 Qreplace_buffer_in_windows.
9020 (replace_buffer_in_all_windows): Remove with some functionality
9021 moved into replace_buffer_in_windows_safely.
9022 (replace_buffer_in_windows_safely): New function.
9023 (select_window_norecord, select_frame_norecord): Move in front
9024 of run_window_configuration_change_hook. Remove now obsolete
9025 declarations.
640c8776
SM
9026 (Fset_window_buffer): Rewrite doc-string.
9027 Call Qrecord_window_buffer.
9397e56f
MR
9028 (keys_of_window): Move binding for other-window to window.el.
9029
b50691aa
CY
90302011-06-11 Chong Yidong <cyd@stupidchicken.com>
9031
9032 * dispextern.h (struct image): Replace data member, whose int_val
9033 and ptr_val fields were not used by anything, with a single
9034 lisp_val object.
9035
9036 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9037 (gif_clear_image, gif_load, imagemagick_load_image)
9038 (gs_clear_image, gs_load): Callers changed.
9039
3f754b86
PE
90402011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9041
cca69397
PE
9042 * buffer.h: Include <time.h>, for time_t.
9043 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9044
109e28d0
PE
9045 Fix minor problems found by static checking.
9046
60737f02
PE
9047 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9048
4b66faf3
PE
9049 Make identifiers static if they are not used in other modules.
9050 * data.c (Qcompiled_function, Qframe, Qvector):
9051 * image.c (QimageMagick, Qsvg):
9052 * minibuf.c (Qmetadata):
9053 * window.c (resize_window_check, resize_root_window): Now static.
9054 * window.h (resize_window_check, resize_root_window): Remove decls.
9055
109e28d0
PE
9056 * window.c (window_deletion_count, delete_deletable_window):
9057 Remove; unused.
46a4ce9e
PE
9058 (window_body_lines): Now static.
9059 (Fdelete_other_windows_internal): Mark vars as initialized.
9060 Make sure 'resize_failed' is initialized.
9061 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9062 (resize_window_apply): Remove unused local.
9063 * window.h (delete_deletable_window): Remove decl.
9064
109e28d0 9065 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9066 (imagemagick_load_image): Fix pointer signedness problem by changing
9067 last arg from unsigned char * to char *. All uses changed.
9068 Also, fix a local for similar reasons.
9069 Remove unused locals. Remove locals to avoid shadowing.
9070 (fn_rsvg_handle_free): Remove; unused.
9071 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9072 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9073
3f754b86
PE
9074 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9075
2547adb1
CY
90762011-06-10 Chong Yidong <cyd@stupidchicken.com>
9077
9078 * image.c (gif_load): Fix omitted cast error introduced by
9079 2011-06-06 change.
9080
2c8e37d4
MR
90812011-06-10 Martin Rudalics <rudalics@gmx.at>
9082
9083 * window.h (resize_proportionally, orig_total_lines)
9084 (orig_top_line): Remove from window structure.
9085 (set_window_height, set_window_width, change_window_heights)
9086 (Fdelete_window): Remove prototypes.
9087 (resize_frame_windows): Remove duplicate declaration.
9088
440a42e3
EZ
90892011-06-10 Eli Zaretskii <eliz@gnu.org>
9090
9091 * window.h (resize_frame_windows, resize_window_check)
9092 (delete_deletable_window, resize_root_window)
9093 (resize_frame_windows): Declare prototypes.
9094
9095 * window.c (resize_window_apply): Make definition be "static" to
9096 match the prototype.
9097
562dd5e9
MR
90982011-06-10 Martin Rudalics <rudalics@gmx.at>
9099
9100 * window.c: Remove declarations of Qwindow_size_fixed,
9101 window_min_size_1, window_min_size_2, window_min_size,
9102 size_window, window_fixed_size_p, enlarge_window, delete_window.
9103 Remove static from declaration of Qdelete_window, it's
9104 temporarily needed by Fbury_buffer.
9105 (replace_window): Don't assign orig_top_line and
9106 orig_total_lines.
9107 (Fdelete_window, delete_window): Remove. Window deletion is
9108 handled by window.el.
640c8776
SM
9109 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9110 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9111 (Fdelete_other_windows): Remove. Deleting other windows is
9112 handled by window.el.
9113 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9114 handled in window.el.
9115 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9116 Window minimum sizes are handled in window.el.
9117 (shrink_windows, size_window, set_window_height)
9118 (set_window_width, change_window_heights, window_height)
9119 (window_width, CURBEG, CURSIZE, enlarge_window)
9120 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9121 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9122 handled in window.el.
9123 (make_dummy_parent): Rename to make_parent_window and give it a
9124 second argument horflag.
9125 (make_window): Don't set resize_proportionally any more.
9126 (Fsplit_window): Remove. Windows are split in window.el.
9127 (save_restore_action, save_restore_orig_size)
9128 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9129 Resize mini windows in window.el.
9130 (grow_mini_window, shrink_mini_window): Implement by calling
9131 Qresize_root_window_vertically, resize_window_check and
9132 resize_window_apply.
640c8776
SM
9133 (saved_window, Fset_window_configuration, save_window_save):
9134 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9135 resize_proportionally.
9136 (window_min_height, window_min_width): Move to window.el.
9137 (keys_of_window): Move bindings for delete-other-windows,
9138 split-window, delete-window and enlarge-window to window.el.
9139
9140 * buffer.c: Temporarily extern Qdelete_window.
9141 (Fbury_buffer): Temporarily call Qdelete_window instead of
9142 Fdelete_window (Fbury_buffer will move to window.el soon).
9143
9144 * frame.c (set_menu_bar_lines_1): Remove code handling
9145 orig_top_line and orig_total_lines.
9146
9147 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9148 set_window_height but set heights directly.
9149 (change_frame_size_1): Use resize_frame_windows.
9150
9151 * xdisp.c (init_xdisp): Don't use set_window_height but set
9152 heights directly.
9153
640c8776
SM
9154 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9155 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9156 run_window_configuration_change_hook.
9157
9158 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9159 instead of change_window_heights and run
9160 run_window_configuration_change_hook.
9161
1a13852e
MR
91622011-06-09 Martin Rudalics <rudalics@gmx.at>
9163
9164 * window.c (replace_window): Rename second argument REPLACEMENT to
9165 NEW. New third argument SETFLAG. Rewrite.
9166 (delete_window, make_dummy_parent): Call replace_window with
9167 third argument 1.
9168 (window_list_1): Move down in code.
9169 (run_window_configuration_change_hook): Move set_buffer part
9170 before select_frame_norecord part in order to unwind correctly.
9171 Rename count1 to count.
9172 (recombine_windows, delete_deletable_window, resize_root_window)
9173 (Fdelete_other_windows_internal)
9174 (Frun_window_configuration_change_hook, make_parent_window)
9175 (resize_window_check, resize_window_apply, Fresize_window_apply)
9176 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9177 (Fdelete_window_internal, Fresize_mini_window_internal):
9178 New functions.
1a13852e
MR
9179 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9180
f3d1777e
MR
91812011-06-08 Martin Rudalics <rudalics@gmx.at>
9182
496e208e
MR
9183 * window.h (window): Add some new members to window structure -
9184 normal_lines, normal_cols, new_total, new_normal, clone_number,
9185 splits, nest, prev_buffers, next_buffers.
9186 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9187 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9188
f3d1777e
MR
9189 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9190 Remove.
496e208e
MR
9191 (make_dummy_parent): Set new members of windows structure.
9192 (make_window): Move down in code. Handle new members of window
9193 structure.
9194 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9195 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9196 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9197 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9198 (Fset_window_next_buffers, Fset_window_clone_number):
9199 New functions.
496e208e
MR
9200 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9201 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9202 Doc-string fixes.
9203 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9204 Argument WINDOW can be now internal window too.
9205 (Fwindow_use_time): Move up in code.
9206 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9207 Rewrite doc-string.
9208 (Fset_window_configuration, saved_window)
9209 (Fcurrent_window_configuration, save_window_save): Handle new
9210 members of window structure.
b9e809c2
MR
9211 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9212 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9213 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9214 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9215 Qget_mru_window, Qresize_root_window,
9216 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9217 Qauto_buffer_name; staticpro them.
f3d1777e 9218
abde8f8c
MR
92192011-06-07 Martin Rudalics <rudalics@gmx.at>
9220
9221 * window.c (Fwindow_total_size, Fwindow_left_column)
9222 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9223 (Fwindow_list_1): New functions.
9224 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9225 (Fwindow_width, Fscroll_left, Fscroll_right):
9226 Use window_body_cols instead of window_box_text_cols.
9227 (delete_window, Fset_window_configuration):
9228 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9229 (delete_all_subwindows): Take a window as argument and not a
9230 structure. Rewrite.
190b47e6
MR
9231 (window_loop): Remove handling of GET_LRU_WINDOW and
9232 GET_LARGEST_WINDOW.
9233 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9234
9235 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9236 window_box_text_cols. delete_all_subwindows now takes a
9237 Lisp_Object as argument.
abde8f8c 9238
640c8776
SM
9239 * indent.c (compute_motion, Fcompute_motion):
9240 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9241
fa8a67e6
MR
9242 * frame.c (delete_frame): Call delete_all_subwindows with root
9243 window as argument.
9244
a54e3482
DC
92452011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9246
9247 * fns.c (Fputhash): Document return value.
9248
60002bf5
CY
92492011-06-06 Chong Yidong <cyd@stupidchicken.com>
9250
9251 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9252
0c671da6 92532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9254
b862a52a 9255 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9256
be44ca6c
PE
9257 Check for overflow when converting integer to cons and back.
9258 * charset.c (Fdefine_charset_internal, Fdecode_char):
9259 Use cons_to_unsigned to catch overflow.
9260 (Fencode_char): Use INTEGER_TO_CONS.
9261 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9262 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9263 * data.c (long_to_cons, cons_to_long): Remove.
9264 (cons_to_unsigned, cons_to_signed): New functions.
9265 These signal an error for invalid or out-of-range values.
9266 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9267 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9268 * font.c (Ffont_variation_glyphs):
9269 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9270 * lisp.h: Include <intprops.h>.
9271 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9272 (cons_to_signed, cons_to_unsigned): New decls.
9273 (long_to_cons, cons_to_long): Remove decls.
9274 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9275 (Fprimitive_undo): Use CONS_TO_INTEGER.
9276 * xfns.c (Fx_window_property): Likewise.
9277 * xselect.c: Include <limits.h>.
9278 (x_own_selection, selection_data_to_lisp_data):
9279 Use INTEGER_TO_CONS.
9280 (x_handle_selection_request, x_handle_selection_clear)
9281 (x_get_foreign_selection, Fx_disown_selection_internal)
9282 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9283 (lisp_data_to_selection_data): Use cons_to_unsigned.
9284 (x_fill_property_data): Use cons_to_signed.
9285 Report values out of range.
9286
d1f3d2af
PE
9287 Check for buffer and string overflow more precisely.
9288 * buffer.h (BUF_BYTES_MAX): New macro.
9289 * lisp.h (STRING_BYTES_MAX): New macro.
9290 * alloc.c (Fmake_string):
9291 * character.c (string_escape_byte8):
9292 * coding.c (coding_alloc_by_realloc):
9293 * doprnt.c (doprnt):
9294 * editfns.c (Fformat):
9295 * eval.c (verror):
9296 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9297 since they may not be the same number.
9298 * editfns.c (Finsert_char):
9299 * fileio.c (Finsert_file_contents):
9300 Likewise for BUF_BYTES_MAX.
9301
dd52fcea
PE
9302 * image.c: Use ptrdiff_t, not int, for sizes.
9303 (slurp_file): Switch from int to ptrdiff_t.
9304 All uses changed.
9305 (slurp_file): Check that file size fits in both size_t (for
9306 malloc) and ptrdiff_t (for sanity and safety).
9307
7f9bbdbb
PE
9308 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9309 if b->modtime has its maximal value.
9310
dfe18f82
PE
9311 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9312
84acfcf0
PE
9313 Don't assume time_t can fit into int.
9314 * buffer.h (struct buffer.modtime): Now time_t, not int.
9315 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9316 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9317
ccd9a01a
PE
9318 Minor fixes for signed vs unsigned integers.
9319 * character.h (MAYBE_UNIFY_CHAR):
9320 * charset.c (maybe_unify_char):
9321 * keyboard.c (read_char, reorder_modifiers):
9322 XINT -> XFASTINT, since the integer must be nonnegative.
9323 * ftfont.c (ftfont_spec_pattern):
9324 * keymap.c (access_keymap, silly_event_symbol_error):
9325 XUINT -> XFASTINT, since the integer must be nonnegative.
9326 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9327 since it makes no difference and we prefer signed.
9328 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9329 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9330 nonnegative.
9331
d6d100dd
SM
93322011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9333
9334 * window.h (Fwindow_frame): Declare.
9335
2b6148e4
PE
93362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9337
9338 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9339 (SPARE_MEMORY): Always define.
9340 (LARGE_REQUEST): Remove.
9341 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9342
f230ecc9
MR
93432011-06-06 Martin Rudalics <rudalics@gmx.at>
9344
727e958e
MR
9345 * lisp.h: Move EXFUNS for Fframe_root_window,
9346 Fframe_first_window and Fset_frame_selected_window to window.h.
9347
9348 * window.h: Move EXFUNS for Fframe_root_window,
9349 Fframe_first_window and Fset_frame_selected_window here from
9350 lisp.h.
9351
9352 * frame.c (Fwindow_frame, Fframe_first_window)
9353 (Fframe_root_window, Fframe_selected_window)
9354 (Fset_frame_selected_window): Move to window.c.
9355 (Factive_minibuffer_window): Move to minibuf.c.
9356 (Fother_visible_frames_p): New function.
9357
9358 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9359
f230ecc9
MR
9360 * window.c (decode_window, decode_any_window): Move up in code.
9361 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9362 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9363 (Fwindow_buffer): Move up and rewrite doc-string.
9364 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9365 (Fwindow_prev): New functions.
727e958e
MR
9366 (Fwindow_frame): Move here from frame.c. Accept any window as
9367 argument.
9368 (Fframe_root_window, Fframe_first_window)
9369 (Fframe_selected_window): Move here from frame.c. Accept frame
9370 or arbitrary window as argument. Update doc-strings.
9371 (Fminibuffer_window): Move up in code.
9372 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9373 (Fset_frame_selected_window): Move here from frame.c.
9374 Marginal rewrite.
727e958e
MR
9375 (Fselected_window, select_window, Fselect_window): Move up in
9376 code. Minor doc-string fixes.
f230ecc9 9377
4d09bcf6
PE
93782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9379
9380 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9381 Do not assume that spare memory exists; that assumption is valid
9382 only if SYSTEM_MALLOC.
9383 (LARGE_REQUEST): New macro, so that the issue of large requests
9384 is separated from the issue of spare memory.
9385
810928a2
AS
93862011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9387
172418ad
AS
9388 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9389 format. (Bug#8806)
9390
43f862f7
AS
9391 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9392
810928a2
AS
9393 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9394 before statements.
9395
a059fe24
JD
93962011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9397
9398 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9399
9400 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9401
9402 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9403 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9404
989bf368
JB
94052011-06-05 Juanma Barranquero <lekktu@gmail.com>
9406
9407 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9408
4b80f674
CY
94092011-06-04 Chong Yidong <cyd@stupidchicken.com>
9410
9411 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9412 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9413 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9414 New error handlers.
4b80f674
CY
9415 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9416 Obey Vx_select_enable_clipboard_manager. Catch errors in
9417 x_clipboard_manager_save (Bug#8779).
9418 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9419 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9420
99a33b77 94212011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9422
9423 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9424
99a33b77 94252011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9426
9427 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9428 in the current matrix if keep_current_p is non-zero.
9429
8264569d
EZ
94302011-06-04 Eli Zaretskii <eliz@gnu.org>
9431
9432 * bidi.c (bidi_level_of_next_char): Fix last change.
9433
57f97249
EZ
94342011-06-03 Eli Zaretskii <eliz@gnu.org>
9435
fec2107c 9436 Support bidi reordering of text covered by display properties.
57f97249 9437
fec2107c
EZ
9438 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9439 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9440 (bidi_cache_search, bidi_cache_iterator_state)
9441 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9442 (bidi_level_of_next_char, bidi_move_to_visually_next):
9443 Support character positions inside a run of characters covered by a
fec2107c
EZ
9444 display string.
9445 (bidi_paragraph_init, bidi_resolve_explicit_1)
9446 (bidi_level_of_next_char): Call bidi_fetch_char and
9447 bidi_fetch_char_advance instead of FETCH_CHAR and
9448 FETCH_CHAR_ADVANCE.
9449 (bidi_init_it): Initialize new members.
9450 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9451 definitions.
9452 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9453 instead of using explicit *_CHAR codes.
d6d100dd
SM
9454 (bidi_resolve_explicit, bidi_resolve_weak):
9455 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9456 bidirectional text is supported only in multibyte buffers.
9457 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9458 it to initialize the frame_window_p member of struct bidi_it.
9459 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9460 (bidi_resolve_explicit, bidi_resolve_weak)
9461 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9462 bidi_it->nchars is non-positive.
9463 (bidi_level_of_next_char): Don't try to lookup the cache for the
9464 next/previous character if nothing is cached there yet, or if we
9465 were just reseat()'ed to a new position.
c40e2fb2 9466
0e14fe90
EZ
9467 * xdisp.c (set_cursor_from_row): Set start and stop points
9468 according to the row's direction when priming the loop that looks
9469 for the glyph on which to display cursor.
9470 (single_display_spec_intangible_p): Function deleted.
9471 (display_prop_intangible_p): Reimplement to call
9472 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9473 Accept 3 additional arguments needed by handle_display_spec.
9474 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9475 values: lists, `(when COND...)' forms, etc.
9476 (single_display_spec_string_p): Support property values that are
9477 lists with the argument STRING its top-level element.
9478 (display_prop_string_p): Fix the condition for processing a
9479 property that is a list to be consistent with handle_display_spec.
fec2107c 9480 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9481 last portion of handle_display_prop.
9482 (compute_display_string_pos): Accept additional argument
9483 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9484 value of a `display' property is a "replacing spec".
9485 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9486 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9487 the display property, but just return a value indicating whether
9488 the display property will replace the characters it covers.
9489 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9490 frame_window_p members of struct bidi_it.
d6d100dd
SM
9491 (compute_display_string_pos, compute_display_string_end):
9492 New functions.
fec2107c
EZ
9493 (push_it): Accept second argument POSITION, where pop_it should
9494 jump to continue iteration.
9495 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9496
fec2107c
EZ
9497 * keyboard.c (adjust_point_for_property): Adjust the call to
9498 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9499
9500 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9501 (bidi_init_it): Update prototypes.
9502 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9503 (compute_display_string_pos, compute_display_string_end):
9504 Declare prototypes.
fec2107c
EZ
9505 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9506 EMACS_INT.
fc6f18ce 9507
40087514 95082011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9509
57f53182
PE
9510 Malloc failure behavior now depends on size of allocation.
9511 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9512 * lisp.h: Change signatures accordingly.
9513 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9514 All callers changed. (Bug#8762)
9515
9516 * gnutls.c: Use Emacs's memory allocators.
9517 Without this change, the gnutls library would invoke malloc etc.
9518 directly, which causes problems on non-SYNC_INPUT hosts, and which
9519 runs afoul of improving memory_full behavior. (Bug#8761)
9520 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9521 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9522 xfree instead of the default malloc, realloc, free.
9523 (Fgnutls_boot): No need to check for memory allocation failure,
9524 since xmalloc does that for us.
9525
ac32cd99 9526 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9527 * category.c (hash_get_category_set):
9528 * ccl.c (ccl_driver):
9529 * charset.c (Fdefine_charset_internal):
9530 * charset.h (struct charset.hash_index):
9531 * composite.c (get_composition_id, gstring_lookup_cache)
9532 (composition_gstring_put_cache):
9533 * composite.h (struct composition.hash_index):
9534 * dispextern.h (struct image.hash):
9535 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9536 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9537 (hashfn_equal, hashfn_user_defined, make_hash_table)
9538 (maybe_resize_hash_table, hash_lookup, hash_put)
9539 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9540 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9541 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9542 * image.c (make_image, search_image_cache, lookup_image)
9543 (xpm_put_color_table_h):
9544 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9545 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9546 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9547 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9548 * alloc.c (allocate_vectorlike):
9549 Check for overflow in vector size calculations.
9550 * ccl.c (ccl_driver):
9551 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9552 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9553 need to be updated by these changes.
40087514
PE
9554 * fns.c (make_hash_table, maybe_resize_hash_table):
9555 Check for integer overflow with large hash tables.
0de4bb68
PE
9556 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9557 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9558 (SXHASH_REDUCE): New macro.
9559 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9560 Use it instead of discarding useful hash info with large hash values.
9561 (sxhash_float): New function.
9562 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9563 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9564 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9565 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9566 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9567 Adjust signatures to match updated version of code.
9568 (consing_since_gc): Now EMACS_INT, since a single hash table can
9569 use more than INT_MAX bytes.
9570
698d32e2
DN
95712011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9572
9573 Make it possible to build with GCC-4.6+ -O2 -flto.
9574
9575 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9576
fd6fa53f
SM
95772011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9578
9579 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9580 Call minibuffer-inactive-mode.
9581
864db017
JB
95822011-05-31 Juanma Barranquero <lekktu@gmail.com>
9583
9584 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9585 Update dependencies.
9586
2ad0baf4
DN
95872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9588
9589 * data.c (init_data): Remove code for UTS, this system is not
9590 supported anymore.
9591
4fcc2638
DN
95922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9593
9594 Don't force ./temacs to start in terminal mode.
9595
9596 * frame.c (make_initial_frame): Initialize faces in all cases, not
9597 only when CANNOT_DUMP is defined.
9598 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9599
c56e0fd5
DN
96002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9601
9602 * dispnew.c (add_window_display_history): Use const for the string
9603 pointer. Remove declaration, not needed.
9604
333d54da 96052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9606
55d4c1b2 9607 Use 'inline', not 'INLINE'.
333d54da 9608 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9609 * alloc.c, fontset.c (INLINE): Remove.
9610 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9611 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9612 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9613 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9614 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9615
738db178
DN
96162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9617
9618 Make it possible to run ./temacs.
9619
9620 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9621 syms_of_callproc does the same thing. Remove test for
9622 "initialized", do it in the caller.
9623 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9624
620c53a6
SM
96252011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9626
9627 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9628 (read_minibuf): Use get_minibuffer.
9629 (syms_of_minibuf): Use DEFSYM.
9630 (Qmetadata): New var.
9631 * data.c (Qbuffer): Don't make it static.
9632 (syms_of_data): Use DEFSYM.
9633
e003a292
PE
96342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9635
9636 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9637 (CCL_CODE_MIN): New macro.
9638
ed008a6d
PE
96392011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9640
3687c2ef
PE
9641 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9642
ed008a6d
PE
9643 * eval.c (Qdebug): Now static.
9644 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9645 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9646 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9647
d66c4c7c
CY
96482011-05-29 Chong Yidong <cyd@stupidchicken.com>
9649
9650 * image.c: Various fixes to ImageMagick code comments.
9651 (Fimagemagick_types): Doc fix.
9652
5fbc2025
PE
96532011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9654
0196f88a
PE
9655 Minor fixes prompted by GCC 4.6.0 warnings.
9656
9657 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9658
5fbc2025
PE
9659 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9660 (x_clipboard_manager_save_all): Move extern decl to ...
9661 * xterm.h: ... here, so that it can be checked for consistency.
9662
1dd3c2d9
CY
96632011-05-29 Chong Yidong <cyd@stupidchicken.com>
9664
9665 * xselect.c (x_clipboard_manager_save_frame)
9666 (x_clipboard_manager_save_all): New functions.
9667 (Fx_clipboard_manager_save): Lisp function deleted.
9668
9669 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9670 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9671
9672 * xterm.h: Update prototype.
9673
5ba6571d
WX
96742011-05-28 William Xu <william.xwl@gmail.com>
9675
9676 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9677 exiting (Bug#8239).
9678
3eaff834
JM
96792011-05-28 Jim Meyering <meyering@redhat.com>
9680
e1900994 9681 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9682 * fns.c (to_uchar): Define.
9683 (crypto_hash_function): Use it to convert some newly-signed
9684 variables to unsigned, to avoid sign-extension bugs. For example,
9685 without this change, (md5 "truc") would evaluate to
9686 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9687 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9688 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9689
0f6990a7
PE
96902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9691
9692 Integer overflow fixes.
c8a9ca5a 9693
08686060
PE
9694 * dbusbind.c: Serial number integer overflow fixes.
9695 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9696 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9697 to hold a serial number that is too large for a fixnum.
9698 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9699 Check for serial numbers out of range. Decode any serial number
59568bf0 9700 that was so large that it became a float. (Bug#8722)
08686060 9701
2d1fc3c7
PE
9702 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9703 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9704 Use XFASTINT rather than XUINT when numbers are nonnegative.
9705 (xd_append_arg, Fdbus_method_return_internal):
9706 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9707 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9708 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9709 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9710 (Bug#8722)
2d1fc3c7 9711
c8a9ca5a
PE
9712 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9713
519e1d69
PE
9714 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9715
6df6ae42 9716 ccl: Add integer overflow checks.
30569699
PE
9717 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9718 (IN_INT_RANGE): New macros.
9719 (ccl_driver): Use them to check for integer overflow when
9720 decoding a CCL program. Many of the new checks are whether XINT (x)
9721 fits in int; it doesn't always, on 64-bit hosts. The new version
9722 doesn't catch all possible integer overflows, but it's an
847044ea 9723 improvement. (Bug#8719)
30569699 9724
c11285dc
PE
9725 * alloc.c (make_event_array): Use XINT, not XUINT.
9726 There's no need for unsigned here.
9727
fdccd48e
PE
9728 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9729 This follows up to the 2011-05-06 change that substituted uintptr_t
9730 for EMACS_INT. This case wasn't caught back then.
9731
37910ab2
PE
9732 Rework Fformat to avoid integer overflow issues.
9733 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9734 now (part of C89). Include <verify.h>.
9735 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9736 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9737 (Fformat): Avoid the prepass trying to compute sizes; it was only
9738 approximate and thus did not catch overflow reliably. Instead, walk
9739 through the format just once, formatting and computing sizes as we go,
9740 checking for integer overflow at every step, and allocating a larger
9741 buffer as needed. Keep track separately whether the format is
9742 multibyte. Keep only the most-recently calculated precision, rather
9743 than them all. Record whether each argument has been converted to
9744 string. Use EMACS_INT, not int, for byte and char and arg counts.
9745 Support field widths and precisions larger than INT_MAX. Avoid
9746 sprintf's undefined behavior with conversion specifications such as %#d
9747 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9748 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9749 formatting out-of-range floating point numbers with int
9173deec 9750 formats. (Bug#8668)
37910ab2 9751
2e6578fb
PE
9752 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9753
0ae6bdee
PE
9754 * data.c: Avoid integer truncation in expressions involving floats.
9755 * data.c: Include <intprops.h>.
9756 (arith_driver): When there's an integer overflow in an expression
9757 involving floating point, convert the integers to floating point
9758 so that the resulting value does not suffer from catastrophic
9759 integer truncation. For example, on a 64-bit host (* 4
9760 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9761 Do not rely on undefined behavior after integer overflow.
9762
de883a70
PE
9763 merge count_size_as_multibyte, parse_str_to_multibyte
9764 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9765 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9766 Check for integer overflow.
9767 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9768 since it's now a duplicate of the other. This is more of
9769 a character than a buffer op, so better that it's in character.c.
9770 * fns.c, print.c: Adjust to above changes.
9771
2ff916cb
PE
97722011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9773
9774 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9775
f1b54466
PE
97762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9777
fb1ac845
PE
9778 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9779 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9780 (x_clipboard_manager_save): Now static.
9781 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9782
f1b54466
PE
9783 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9784 (crypto_hash_function): Now static.
9785 Fix pointer signedness problems. Avoid unnecessary initializations.
9786
a9f737ee
CY
97872011-05-27 Chong Yidong <cyd@stupidchicken.com>
9788
9789 * termhooks.h (Vselection_alist): Make it terminal-local.
9790
9791 * terminal.c (create_terminal): Initialize it.
9792
9793 * xselect.c: Support for clipboard managers.
9794 (Vselection_alist): Move to termhooks.h as terminal-local var.
9795 (LOCAL_SELECTION): New macro.
9796 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9797 (symbol_to_x_atom): Remove gratuitous arg.
9798 (x_handle_selection_request, lisp_data_to_selection_data)
9799 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9800 (x_own_selection, x_get_local_selection, x_convert_selection):
9801 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9802 (some_frame_on_display): Delete unused function.
9803 (Fx_own_selection_internal, Fx_get_selection_internal)
9804 (Fx_disown_selection_internal, Fx_selection_owner_p)
9805 (Fx_selection_exists_p): New optional frame arg.
9806 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9807 (x_handle_selection_clear): Don't treat other terminals with the
9808 same keyboard specially. Use the terminal-local Vselection_alist.
9809 (x_clear_frame_selections): Use Frun_hook_with_args.
9810
9811 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9812
9813 * xterm.h: Add support for those atoms.
9814
e067f0c1
CY
98152011-05-26 Chong Yidong <cyd@stupidchicken.com>
9816
9817 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9818 (converted_selections, conversion_fail_tag): New global variables.
9819 (x_selection_request_lisp_error): Free the above.
9820 (x_get_local_selection): Remove unnecessary code.
9821 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9822 of converted selections stored in converted_selections.
9823 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9824 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9825 (x_convert_selection): New function.
9826 (x_handle_selection_event): Simplify.
9827 (x_get_foreign_selection): Don't ignore incoming requests while
9828 waiting for an answer; this will fail when we implement
9829 SAVE_TARGETS, and seems unnecessary anyway.
9830 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9831 (Vx_sent_selection_functions): Doc fix.
9832
0f4aebc0
LL
98332011-05-26 Leo Liu <sdl.web@gmail.com>
9834
9835 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9836
e61124cd
YM
98372011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9838
9839 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9840
9841 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9842 for fringe update if it has periodic bitmap.
ac389d0c 9843 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9844 and fringe_bitmap_periodic_p.
9845
9846 * fringe.c (get_fringe_bitmap_data): New function.
9847 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9848 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9849 row. Mark glyph row for fringe update if periodicity changed.
9850
9851 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9852 for fringe update unless it has periodic bitmap.
9853
f16d9837
KH
98542011-05-25 Kenichi Handa <handa@m17n.org>
9855
9856 * xdisp.c (get_next_display_element): Set correct it->face_id for
9857 a static composition.
9858
e1b90ef6
LL
98592011-05-24 Leo Liu <sdl.web@gmail.com>
9860
9861 * deps.mk (fns.o):
9862 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9863
9864 * fns.c (crypto_hash_function, Fsha1): New function.
9865 (Fmd5): Use crypto_hash_function.
9866 (syms_of_fns): Add Ssha1.
9867
7400048f
PE
98682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9869
9870 * gnutls.c: Remove unused macros.
9871 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9872 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9873 Remove macros that are defined and never used.
9874 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9875
abb71cf4
CY
98762011-05-22 Chong Yidong <cyd@stupidchicken.com>
9877
9878 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9879 (Fx_get_selection_internal): Minor cleanup.
9880 (Fx_own_selection_internal): Rename arguments for consistency with
9881 select.el.
9882
6307db39
PE
98832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9884
9885 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9886
f3d4e0a4
CY
98872011-05-22 Chong Yidong <cyd@stupidchicken.com>
9888
9889 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9890
4d8ade89
YM
98912011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9892
9893 * dispnew.c (scrolling_window): Don't exclude the case that the
9894 last enabled row in the desired matrix touches the bottom boundary.
9895
32078c8d
GM
98962011-05-21 Glenn Morris <rgm@gnu.org>
9897
9898 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9899 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9900 and add some more files.
32078c8d 9901
7285dc67
EZ
99022011-05-20 Eli Zaretskii <eliz@gnu.org>
9903
9904 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9905 report_file_error introduced by the change from 2011-05-07.
9906
89d1bd22
PE
99072011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9908
9909 * systime.h (Time): Define only if emacs is defined.
9910 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9911 where the include path doesn't have X11/X.h by default. See
9912 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9913
cd394be1 99142011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9915
9916 * composite.c (find_automatic_composition): Fix previous change.
9917
b9704ad9
GM
99182011-05-20 Glenn Morris <rgm@gnu.org>
9919
9920 * lisp.mk: New file, split from Makefile.in.
9921 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9922 (shortlisp): Remove.
9923 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9924
4a720484
GM
99252011-05-19 Glenn Morris <rgm@gnu.org>
9926
9927 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9928 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9929 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9930 (lisp): Set the order to that of loadup.el.
9931 (shortlisp): Make it a copy of $lisp.
9932 (SOME_MACHINE_LISP): Remove.
9933 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9934 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9935
a28d4396
KH
99362011-05-18 Kenichi Handa <handa@m17n.org>
9937
9938 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9939 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9940 (find_automatic_composition): Mostly rewrite for efficiency.
9941
a2b1fa8e
JB
99422011-05-18 Juanma Barranquero <lekktu@gmail.com>
9943
9944 * makefile.w32-in: Update dependencies.
9945
8e1f5610
CS
99462011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9947
9948 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9949 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9950
7025ee00 99512011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9952
cdfa6eab
PE
9953 Fix some integer overflow issues, such as string length overflow.
9954
06d6db33
PE
9955 * insdel.c (count_size_as_multibyte): Check for string overflow.
9956
2b4560a8
PE
9957 * character.c (lisp_string_width): Check for string overflow.
9958 Use EMACS_INT, not int, for string indexes and lengths; in
9959 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9960 the resulting string length overflows an EMACS_INT; instead,
9961 report a string overflow if no precision given. When checking for
9962 precision exhaustion, use a check that cannot possibly have
9963 integer overflow. (Bug#8675)
9964 * character.h (lisp_string_width): Adjust to new signature.
9965
cb93f9be
PE
9966 * alloc.c (string_overflow): New function.
9967 (Fmake_string): Use it. This doesn't change behavior, but saves
9968 a few bytes and will simplify future changes.
9969 * character.c (string_escape_byte8): Likewise.
9970 * lisp.h (string_overflow): New decl.
9971
1a1f3366
PE
9972 Fixups, following up to the user-interface timestamp change.
9973 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9974 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9975 * msdos.c (mouse_get_pos): Likewise.
9976 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9977 * w32gui.h (Time): Define by including "systime.h" rather than by
9978 declaring it ourselves. (Bug#8664)
9979
d4e3e4d3
PE
9980 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9981 * image.c (clear_image_cache): Likewise.
9982
f6a24d19
PE
9983 * term.c (term_mouse_position): Don't assume time_t wraparound.
9984
08dc5ae6
PE
9985 Be more systematic about user-interface timestamps.
9986 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9987 and sometimes 'EMACS_UINT', to represent these timestamps.
9988 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9989 This makes the code easier to follow, and makes it easier to catch
9990 integer overflow bugs such as Bug#8664.
9991 * frame.c (Fmouse_position, Fmouse_pixel_position):
9992 Use Time, not unsigned long, for user-interface timestamps.
9993 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9994 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9995 * keyboard.h (last_event_timestamp): Likewise.
9996 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9997 * menu.h (xmenu_show): Likewise.
9998 * term.c (term_mouse_position): Likewise.
9999 * termhooks.h (struct input_event.timestamp): Likewise.
10000 (struct terminal.mouse_position_hook): Likewise.
10001 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10002 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10003 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10004 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10005 what it was before.
10006 * menu.h, termhooks.h: Include "systime.h", for Time.
10007
8e55734a
PE
10008 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10009 Don't assume that the difference between two unsigned long values
10010 can fit into an integer. At this point, we know button_down_time
10011 <= event->timestamp, so the difference must be nonnegative, so
10012 there's no need to cast the result if double-click-time is
10013 nonnegative, as it should be; check that it's nonnegative, just in
10014 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10015 apart (about 25 days). (Bug#8664)
8e55734a 10016
841f1b75 10017 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10018 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10019
3e26f69c
PE
10020 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10021 that always fit in int. Use a sentinel instead of a counter, to
10022 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10023 * frame.h (struct frame): Use int for menu_bar_items_used
10024 instead of EMACS_INT, since it always fits in int.
3e26f69c 10025
5cc152c0
PE
10026 * menu.c (grow_menu_items): Check for int overflow.
10027
d89eb65e
PE
10028 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10029
5235bd3e
PE
10030 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10031 Before, the code was not consistent. These values cannot exceed
10032 2**31 - 1 so there's no need to make them unsigned.
10033 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10034 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10035 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10036 as modifiers.
10037 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10038
bc827e23
PE
10039 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10040 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10041 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10042 presumably because the widths might not match.
10043
78eb494e
PE
10044 * window.c (size_window): Avoid needless test at loop start.
10045
04f2d78b
CB
100462011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10047
10048 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10049
d2fc7e3d 100502011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10051
10052 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10053
d2fc7e3d 100542011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10055
10056 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10057 `width' to `bar_area_x' and `bar_area_width', respectively.
10058 (x_scroll_run): Take account of fringe background extension.
10059
04f2d78b
CB
10060 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10061 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10062 `bar_area_width', respectively.
10063 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10064 background extension.
10065
79b70037
GM
100662011-05-10 Jim Meyering <meyering@redhat.com>
10067
10068 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10069
2f142cc5
JB
100702011-05-10 Juanma Barranquero <lekktu@gmail.com>
10071
10072 * image.c (Finit_image_library): Return t for built-in image types,
10073 like pbm and xbm. (Bug#8640)
10074
57679c86
AS
100752011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10076
10077 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10078
888c9e86
EZ
100792011-05-07 Eli Zaretskii <eliz@gnu.org>
10080
b0512a1d
EZ
10081 * w32console.c (Fset_screen_color): Doc fix.
10082 (Fget_screen_color): New function.
10083 (syms_of_ntterm): Defsubr it.
10084
7285dc67
EZ
10085 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10086 unlink the temporary file if Fcall_process didn't create it in the
10087 first place.
10088 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10089 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10090 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10091 cue to call_process_cleanup not to close that handle.
10092
4d3fcc8e
BK
100932011-05-07 Ben Key <bkey76@gmail.com>
10094
10095 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10096 one of two shell specific rules, either bootstrap-temacs-CMD or
10097 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10098 to the previous implementation of the bootstrap-temacs rule.
10099 The bootstrap-temacs-CMD rule is similar to the previous
10100 implementation of the bootstrap-temacs rule except that it
10101 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10102 variable.
10103
10104 These changes, along with some changes to nt/configure.bat,
10105 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10106 earlier fix to add support for --cflags and --ldflags options
10107 that include quotes so that it works whether make uses cmd or
10108 sh as the shell.
10109
b4289b64
MA
101102011-05-06 Michael Albinus <michael.albinus@gmx.de>
10111
10112 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10113 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10114 is a constant.
10115 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10116 a string. Handle both cases.
10117 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10118 (Fdbus_register_method): Use Qinvalid_function.
10119
af4c0e28
JB
101202011-05-06 Juanma Barranquero <lekktu@gmail.com>
10121
10122 * makefile.w32-in: Update dependencies.
10123 (LISP_H): Add inttypes.h and stdin.h.
10124 (PROCESS_H): Add unistd.h.
10125
c51453d9
EZ
101262011-05-06 Eli Zaretskii <eliz@gnu.org>
10127
10128 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10129 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10130
8ff0ac3c 101312011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10132
4c4b566b
PE
10133 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10134
aab2b9b5
PE
10135 * term.c (vfatal): Remove stray call to va_end.
10136 It's not needed and the C Standard doesn't allow it here anyway.
10137
c378da0b
PE
10138 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10139 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10140
288b08c7
PE
10141 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10142 bytes.
10143
e3601888
PE
10144 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10145
db6c0e74
PE
10146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10147
dd5963ea
PE
10148 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10149
88c9450f
PE
10150 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10151
2f9442b8
PE
10152 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10153
c032b5f8
PE
10154 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10155 * charset.c (Fdefine_charset_internal): Don't initialize
10156 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10157 32-bit int (Bug#8600).
a108c10b
PE
10158
10159 * lread.c (read_integer): Be more consistent with string-to-number.
10160 Use string_to_number to do the actual conversion; this avoids
10161 rounding errors and fixes some other screwups. Without this fix,
10162 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10163 (digit_to_number): Move earlier, for benefit of read_integer.
10164 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10165 not a digit in any supported base. (Bug#8602)
a108c10b 10166
ad5f9eea
PE
10167 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10168
aec1708a
PE
10169 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10170 to match comment at start of function. This also removes a
10171 GCC warning about overflow in a 32+64-bit port.
10172
47be4ab5
PE
10173 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10174
371cac43
PE
10175 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10176 Reported by Stefan Monnier in
10177 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10178 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10179 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10180
d01a7826
PE
10181 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10182 (EMACS_UINTPTR): Likewise, with uintptr_t.
10183
7fd47d5c
PE
10184 * lisp.h: Prefer 64-bit EMACS_INT if available.
10185 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10186 on 32-bit hosts that have 64-bit int, so that they can access
10187 large files.
122b0c86
PE
10188 However, temporarily disable this change unless the temporary
10189 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10190
8727937b
PE
10191 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10192
8ac068ac
PE
10193 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10194 This removes an assumption that EMACS_INT and long are the same
10195 width as pointers. The assumption is true for Emacs porting targets
10196 now, but we want to make other targets possible.
10197 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10198 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10199 In the rest of the code, change types of integers that hold casted
10200 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10201 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10202 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10203 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10204 No need to cast type when ORing.
10205 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10206 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10207 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10208 assume EMACS_INT is the same width as char *.
10209 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10210 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10211 Remove no-longer-needed casts.
10212 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10213 (xg_tool_bar_help_callback, xg_make_tool_item):
10214 Use EMACS_INTPTR to hold an integer
10215 that will be cast to void *; this can avoid a GCC warning
10216 if EMACS_INT is not the same width as void *.
10217 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10218 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10219 (current_message_1, set_message_1):
10220 Use a local to convert to proper width without a cast.
10221 * xmenu.c (dialog_selection_callback): Likewise.
10222
ede49d71
PE
10223 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10224 Also, don't assume VALBITS / RAND_BITS is less than 5,
10225 and don't rely on undefined behavior when shifting a 1 left into
10226 the sign bit.
10227 * lisp.h (get_random): Change signature to match.
10228
2f30ecd0
PE
10229 * lread.c (hash_string): Use size_t, not int, for hash computation.
10230 Normally we prefer signed values; but hashing is special, because
10231 it's better to use unsigned division on hash table sizes so that
10232 the remainder is nonnegative. Also, size_t is the natural width
10233 for hashing into memory. The previous code used 'int', which doesn't
10234 retain enough info to hash well into very large tables.
10235 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10236
2a866e7b
PE
10237 * dbusbind.c: Don't possibly lose pointer info when converting.
10238 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10239 Use XPNTR rather than XHASH, so that the high-order bits of
10240 the pointer aren't lost when converting through void *.
10241
51639eac
PE
10242 * eval.c (Fautoload): Don't double-shift a pointer.
10243
92394119
PE
10244 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10245
dbdb9a7c
JB
102462011-05-06 Juanma Barranquero <lekktu@gmail.com>
10247
10248 * gnutls.c (DEF_GNUTLS_FN):
10249 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10250
db7a0b4f
AS
102512011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10252
10253 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10254 marker. (Bug#8610)
10255
cd394be1 102562011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10257
10258 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10259 New version that can reserve upto 2GB of heap space.
10260
f7ff1b0f 102612011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10262
10263 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10264
639c109b
TZ
102652011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10266
10267 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10268 `gnutls_certificate_set_x509_key_file'.
10269
d2127135
JB
102702011-05-05 Juanma Barranquero <lekktu@gmail.com>
10271
10272 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10273 Update dependencies.
10274
e968f4f3
JB
102752011-05-04 Juanma Barranquero <lekktu@gmail.com>
10276
10277 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10278 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10279 Remove unused parameter `fildes'.
10280 * process.c (read_process_output, send_process): Don't pass it.
10281
84d358f0
JB
102822011-05-04 Juanma Barranquero <lekktu@gmail.com>
10283
10284 Fix previous change: the library cache is defined in w32.c.
10285 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10286 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10287
0898ca10
JB
102882011-05-04 Juanma Barranquero <lekktu@gmail.com>
10289
10290 Implement dynamic loading of GnuTLS on Windows.
10291
10292 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10293 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10294 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10295 Declare.
10296
10297 * gnutls.c (Qgnutls_dll): Define.
10298 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10299 (gnutls_*): Declare function pointers.
10300 (init_gnutls_functions): New function to initialize function pointers.
10301 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10302 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10303 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10304 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10305 (emacs_gnutls_write, emacs_gnutls_read)
10306 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10307 (Fgnutls_available_p): New function.
10308 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10309 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10310 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10311
10312 * image.c: Include w32.h.
10313 (Vimage_type_cache): Delete.
10314 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10315 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10316 (w32_delayed_load): Move to w32.c.
10317
10318 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10319
10320 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10321 (w32_delayed_load): Move from image.c. When loading a library, record
10322 its filename in the :loaded-from property of the library id.
10323 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10324 Initialize and staticpro them.
10325 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10326
10327 * process.c: Include lisp.h before w32.h, not after.
10328 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10329 instead of gnutls_record_check_pending.
10330
10331 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10332
ff4de4aa
TZ
103332011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10334
10335 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10336 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10337 as passed in.
10338
abe95abb
JD
103392011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10340
10341 * xterm.c (x_set_frame_alpha): Do not set property on anything
10342 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10343
e16e55d4
JB
103442011-05-02 Juanma Barranquero <lekktu@gmail.com>
10345
10346 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10347
bafcf6a5
JB
103482011-05-02 Juanma Barranquero <lekktu@gmail.com>
10349
10350 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10351 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10352 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10353 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10354 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10355 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10356 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10357 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10358 (Qgnutls_bootprop_callbacks_verify): Make static.
10359
e7a6747f
AS
103602011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10361
19ed11ba
AS
10362 * callproc.c: Indentation fixup.
10363
e7a6747f 10364 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10365 (wait_for_termination, interruptible_wait_for_termination):
10366 Move after wait_for_termination_1.
e7a6747f 10367
1ef14cb4
LMI
103682011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10369
10370 * sysdep.c (interruptible_wait_for_termination): New function
10371 which is like wait_for_termination, but allows keyboard
10372 interruptions.
10373
10374 * callproc.c (Fcall_process): Add (:file "file") as an option for
10375 the STDOUT buffer.
10376 (Fcall_process_region): Ditto.
10377
330d880c
EZ
103782011-04-30 Eli Zaretskii <eliz@gnu.org>
10379
8db90b73
EZ
10380 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10381 rather than `XVECTOR (FOO)->size'.
10382
330d880c
EZ
10383 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10384 inttypes.h, as a gnulib replacement is used if it not available in
10385 system headers.
10386
15cbd324
EZ
103872011-04-21 Eli Zaretskii <eliz@gnu.org>
10388
10389 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10390 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10391 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10392
10393 * coding.c (coding_alloc_by_realloc): Error out if destination
10394 will grow beyond MOST_POSITIVE_FIXNUM.
10395 (decode_coding_emacs_mule): Abort if there isn't enough place in
10396 charbuf for the composition carryover bytes. Reserve an extra
10397 space for up to 2 characters produced in a loop.
10398 (decode_coding_iso_2022): Abort if there isn't enough place in
10399 charbuf for the composition carryover bytes.
10400
104012011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10402
ae940cca
EZ
10403 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10404 aborting when %lld or %lll format is passed.
10405 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10406 %llo or %llx format is passed. (Bug#8545)
10407
03ab8921
EZ
10408 * window.c (window_scroll_line_based): Use a marker instead of
10409 simple variables to record original value of point. (Bug#7952)
10410
afda1437
EZ
10411 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10412 produced by %s or %c overflows available buffer space. (Bug#8545)
10413
f76dee0c
PE
104142011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10415
10416 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10417 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10418
fdc5744d
JB
104192011-04-28 Juanma Barranquero <lekktu@gmail.com>
10420
10421 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10422
638f053a
JB
104232011-04-28 Juanma Barranquero <lekktu@gmail.com>
10424
10425 * keyboard.c (Qdelayed_warnings_hook): Define.
10426 (command_loop_1): Run `delayed-warnings-hook'
10427 if Vdelayed_warnings_list is non-nil.
10428 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10429 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10430
d178f871
EZ
104312011-04-28 Eli Zaretskii <eliz@gnu.org>
10432
10433 * doprnt.c (doprnt): Don't return value smaller than the buffer
10434 size if the message was truncated. (Bug#8545).
10435
b124fd93
JB
104362011-04-28 Juanma Barranquero <lekktu@gmail.com>
10437
10438 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10439 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10440
e810457d
PE
104412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10442
10443 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10444
ea51cceb
JB
104452011-04-27 Juanma Barranquero <lekktu@gmail.com>
10446
10447 * makefile.w32-in: Update dependencies.
10448
94dcfacf
EZ
104492011-04-27 Eli Zaretskii <eliz@gnu.org>
10450
10451 Improve `doprnt' and its usage. (Bug#8545)
10452 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10453 `format_end'. Remove support for %l as a conversion specifier.
10454 Don't use xrealloc. Improve diagnostics when the %l size modifier
10455 is used. Update the commentary.
10456
10457 * eval.c (verror): Simplify calculation of size_t.
10458
10459 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10460 messages.
10461
f61f41d7
PE
104622011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10463
10464 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10465 change.
10466
96fb4434
PE
104672011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10468
10469 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10470 This makes this file independent of the recent pseudovector change.
10471
671875da 104722011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10473
69e9b5a3
PE
10474 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10475
b5f869a7 10476 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10477 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10478 Remove unused local.
c8926152 10479 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10480
841a1577 10481 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10482 GCC 4.6.0 optimizes based on type-based alias analysis.
10483 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10484 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10485 != &v->size, and therefore "v->size = 1; b->size = 2; return
10486 v->size;" must therefore return 1. This assumption is incorrect
10487 for Emacs, since it type-puns struct Lisp_Vector * with many other
10488 types. To fix this problem, this patch adds a new type struct
f904488f 10489 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10490 and pseudovectors, and helps optimizing compilers not get fooled
10491 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10492 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10493 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10494 the size member.
eab3844f
PE
10495 (XSETPVECTYPE): Rewrite in terms of new macro.
10496 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10497 This is a bit clearer, and further avoids the possibility of
10498 undesirable aliasing.
10499 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10500 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10501 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10502 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10503 (ASIZE): Now uses header.size rather than size.
10504 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10505 to avoid the hassle of writing XVECTOR (foo)->header.size.
10506 (struct vectorlike_header): New type.
eab3844f
PE
10507 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10508 object, to help avoid aliasing.
10509 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10510 (SUBRP): Likewise, since Lisp_Subr is a special case.
10511 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10512 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10513 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10514 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10515 changed to be "header.size" and "header.next".
10516 * buffer.h (struct buffer): Likewise.
10517 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10518 * frame.h (struct frame): Likewise.
10519 * process.h (struct Lisp_Process): Likewise.
10520 * termhooks.h (struct terminal): Likewise.
10521 * window.c (struct save_window_data, struct saved_window): Likewise.
10522 * window.h (struct window): Likewise.
10523 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10524 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10525 * buffer.c (init_buffer_once): Likewise.
10526 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10527 special case.
10528 * process.c (Fformat_network_address): Use local var for size,
10529 for brevity.
10530
0df1eac5
PE
10531 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10532
847ab9d1 10533 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10534 * data.c (atof): Remove decl; no longer used or needed.
10535 (digit_to_number): Move to lread.c.
10536 (Fstring_to_number): Use new string_to_number function, to be
10537 consistent with how the Lisp reader treats infinities and NaNs.
10538 Do not assume that floating-point numbers represent EMACS_INT
10539 without losing information; this is not true on most 64-bit hosts.
10540 Avoid double-rounding errors, by insisting on integers when
10541 parsing non-base-10 numbers, as the documentation specifies.
10542 * lisp.h (string_to_number): New decl, replacing ...
10543 (isfloat_string): Remove.
bc0a5c13 10544 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10545 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10546 appears to have been a coding error. Similarly, do not accept
10547 strings like +-1e0 as floating point numbers. Do not report
10548 overflow for integer overflows unless the base is not 10 which
10549 means we have no simple and reliable way to continue.
10550 Break out the floating-point parsing into a new
10551 function string_to_number, so that Fstring_to_number parses
10552 floating point numbers consistently with the Lisp reader.
04f2d78b 10553 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10554 (E_CHAR, EXP_INT): Remove, replacing with ...
10555 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10556 (string_to_number): New function, replacing isfloat_string.
10557 This function checks for valid syntax and produces the resulting
10558 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10559 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10560 so that overflow for non-base-10 numbers is reported only when
10561 there's no portable and simple way to convert to floating point.
452f4150 10562
67769ffc
PE
10563 * textprop.c (set_text_properties_1): Rewrite for clarity,
10564 and to avoid GCC warning about integer overflow.
10565
c20db43f
PE
10566 * intervals.h (struct interval): Use EMACS_INT for members
10567 where EMACS_UINT might cause problems. See
10568 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10569 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10570 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10571 All uses changed.
37aa2f85
PE
10572 (offset_intervals): Tell GCC not to worry about length overflow
10573 when negating a negative length.
c20db43f 10574
2538aa2f
PE
10575 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10576 (overrun_check_free): Likewise.
10577
f2d3008d
PE
10578 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10579 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10580 word size.
10581
ec8df744
PE
10582 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10583 (gnutls_make_error): Rename local to avoid shadowing.
10584 (gnutls_emacs_global_deinit): ifdef out; not used.
10585 (Fgnutls_boot): Use const for pointer to readonly storage.
10586 Comment out unused local. Fix pointer signedness problems.
10587
640ee02d
PE
10588 * lread.c (openp): Don't stuff size_t into an 'int'.
10589 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10590 about possible signed overflow.
10591
6048fb2a
PE
10592 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10593 (GDK_KEY_g): Don't define if already defined.
10594 (xg_prepare_tooltip): Avoid pointer signedness problem.
10595 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10596
fa3c87e1
PE
10597 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10598 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10599
2172544b
PE
10600 * xfns.c (Fx_window_property): Simplify a bit,
10601 to make a bit faster and to avoid GCC 4.6.0 warning.
10602 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10603
9b821a21
PE
10604 * fns.c (internal_equal): Don't assume size_t fits in int.
10605
3c616cfa
PE
10606 * alloc.c (compact_small_strings): Tighten assertion a little.
10607
c2982e87
PE
10608 Replace pEd with more-general pI, and fix some printf arg casts.
10609 * lisp.h (pI): New macro, generalizing old pEd macro to other
10610 conversion specifiers. For example, use "...%"pI"d..." rather
10611 than "...%"pEd"...".
10612 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10613 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10614 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10615 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10616 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10617 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10618 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10619 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10620 64-bit hosts.
10621 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10622 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10623 * print.c (safe_debug_print, print_object): Likewise.
10624 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10625 to int.
6f04d126
PE
10626 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10627 avoiding the 0 flag, which is not portable.
c2982e87
PE
10628 * process.c (Fmake_network_process): Use pI to avoid cast.
10629 * region-cache.c (pp_cache): Likewise.
10630 * xdisp.c (decode_mode_spec): Likewise.
10631 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10632 behavior on 64-bit hosts with printf arg.
6f04d126 10633 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10634 (x_stop_queuing_selection_requests): Likewise.
10635 (x_get_window_property): Don't truncate byte count to an 'int'
10636 when tracing.
0b432f21 10637
5e073ec7
PE
10638 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10639 here, since it parses constructs like leading '-' and spaces,
10640 which are not wanted; and it overflows with large numbers.
10641 Instead, simply match F[0-9]+, which is what is wanted anyway.
10642
36372bf9
PE
10643 * alloc.c: Remove unportable assumptions about struct layout.
10644 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10645 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10646 (allocate_vectorlike, make_pure_vector): Use the new macros,
10647 plus offsetof, to remove unportable assumptions about struct layout.
10648 These assumptions hold on all porting targets that I know of, but
10649 they are not guaranteed, they're easy to remove, and removing them
10650 makes further changes easier.
10651
0b432f21
PE
10652 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10653 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10654 (string_overrun_cookie): Now const. Use initializers that
10655 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10656 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10657 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10658 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10659 multiple of sizeof (EMACS_INT); it need not be, if
10660 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10661 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10662
895009e1
JB
106632011-04-26 Juanma Barranquero <lekktu@gmail.com>
10664
10665 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10666
6a7a1b0b
TZ
106672011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10668
10669 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10670 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10671 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10672
841a1577 106732011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10674
10675 * lisp.h (Qdebug): List symbol.
895009e1 10676 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10677 * keyboard.c (debug-on-event): New variable.
10678 (handle_user_signal): Break into debugger when debug-on-event
10679 matches the current signal symbol.
10680
f2d3ba6f
DN
106812011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10682
10683 * alloc.c (check_sblock, check_string_bytes)
10684 (check_string_free_list): Convert to standard C.
10685
42ce4c63
TZ
106862011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10687
10688 * w32.c (emacs_gnutls_push): Fix typo.
10689
825cd63c
EZ
106902011-04-25 Eli Zaretskii <eliz@gnu.org>
10691
fb11d64d
EZ
10692 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10693 "cast to pointer from integer of different size".
10694
825cd63c
EZ
10695 Improve doprnt and its use in verror. (Bug#8545)
10696 * doprnt.c (doprnt): Document the set of format control sequences
10697 supported by the function. Use SAFE_ALLOCA instead of always
10698 using `alloca'.
10699
10700 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10701 is one byte too soon. Don't use xrealloc; instead xfree and
10702 xmalloc anew.
10703
e061a11b
TZ
107042011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10705
10706 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10707 callbacks stage.
10708
10709 * gnutls.c: Renamed global_initialized to
10710 gnutls_global_initialized. Added internals for the
10711 :verify-hostname-error, :verify-error, and :verify-flags
10712 parameters of `gnutls-boot' and documented those parameters in the
10713 docstring. Start callback support.
9173deec
JB
10714 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10715 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10716 on error. Return error code.
e061a11b
TZ
10717 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10718 (emacs_gnutls_read): Likewise.
10719 (Fgnutls_boot): Return handshake error code.
10720 (emacs_gnutls_handle_error): New function.
10721 (wsaerror_to_errno): Likewise.
10722
10723 * w32.h (emacs_gnutls_pull): Add prototype.
10724 (emacs_gnutls_push): Likewise.
10725
10726 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10727 (emacs_gnutls_push): Likewise.
10728
107292011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10730
10731 * process.c (wait_reading_process_output): Check if GnuTLS
10732 buffered some data internally if no FDs are set for TLS
10733 connections.
10734
10735 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10736 (LIBS): Link to USER_LIBS.
10737 ($(BLD)/gnutls.$(0)): New target.
10738
fa6996bc
EZ
107392011-04-24 Eli Zaretskii <eliz@gnu.org>
10740
eb35682e
EZ
10741 * xdisp.c (handle_single_display_spec): Rename the
10742 display_replaced_before_p argument into display_replaced_p, to
10743 make it consistent with the commentary. Fix typos in the
10744 commentary.
10745
e2ad650c
EZ
10746 * textprop.c (syms_of_textprop): Remove dead code.
10747 (copy_text_properties): Delete obsolete commentary about an
10748 interface that was deleted long ago. Fix typos in the description
10749 of arguments.
10750
1b2de274
EZ
10751 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10752 to changes in oldXMenu/XMenu.h from 2011-04-16.
10753 <menu_help_message, prev_menu_help_message>: Constify.
10754 (IT_menu_make_room): menu->help_text is now `const char **';
10755 adjust.
10756
10757 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10758 to changes in oldXMenu/XMenu.h from 2011-04-16.
10759 (struct XMenu): Declare `help_text' `const char **'.
10760
10761 * xfaces.c <Qunspecified>: Make extern again.
10762
10763 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10764 required by POSIX.
1b2de274 10765
762b15be
EZ
10766 * doc.c (get_doc_string): Improve the format passed to `error'.
10767
10768 * doprnt.c (doprnt): Improve commentary.
10769
10770 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10771
10772 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10773 them with etags.
10774
f1052e5d
EZ
10775 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10776 changes in globals.h immediately force recompilation.
762b15be
EZ
10777 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10778 $(CURDIR)/s/ms-w32.h.
10779 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10780
fa6996bc
EZ
10781 * character.c (Fchar_direction): Function deleted.
10782 (syms_of_character): Don't defsubr it.
10783 <char-direction-table>: Deleted.
10784
e6c3da20
EZ
107852011-04-23 Eli Zaretskii <eliz@gnu.org>
10786
10787 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10788 * doprnt.c: Include limits.h.
10789 (SIZE_MAX): New macro.
04f2d78b
CB
10790 (doprnt): Return a size_t value. 2nd arg is now size_t.
10791 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10792 Improve overflow protection. Support `l' modifier for integer
10793 conversions. Support %l conversion. Don't assume an EMACS_INT
10794 argument for integer conversions and for %c.
10795
10796 * lisp.h (doprnt): Restore prototype.
10797
10798 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10799 $(SRC)/character.h.
10800
10801 * Makefile.in (base_obj): Add back doprnt.o.
10802
10803 * deps.mk (doprnt.o): Add back prerequisites.
10804 (callint.o): Depend on character.h.
10805
10806 * eval.c (internal_lisp_condition_case): Include the handler
10807 representation in the error message.
10808 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10809 when breaking from the loop.
10810
10811 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10812
10813 * callint.c (Fcall_interactively): When displaying error message
10814 about invalid control letter, pass the character's codepoint, not
10815 a pointer to its multibyte form. Improve display of the character
10816 in octal and display also its hex code.
10817
10818 * character.c (char_string): Use %x to display the (unsigned)
10819 codepoint of an invalid character, to avoid displaying a bogus
10820 negative value.
10821
10822 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10823 `error', not SYMBOL_NAME itself.
10824
10825 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10826 character arguments to `error'.
10827
10828 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10829 to `error' in error message about FINAL_CHAR argument. Make sure
10830 FINAL_CHAR is a character, and use %c when it is passed as
10831 argument to `error'.
10832
4ffd0d6b 108332011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10834
10835 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10836
10837 * w32.c: Include <time.h>.
10838 (sys_localtime): New function.
10839
4ffd0d6b 108402011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10841
10842 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10843
4ffd0d6b 10844 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10845
4ffd0d6b 108462011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10847
4ffd0d6b
GM
10848 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10849 zombies (Bug#8467).
aac0c6e3 10850
04c56954
EZ
108512011-04-19 Eli Zaretskii <eliz@gnu.org>
10852
10853 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10854 gl_state.e_property when gl_state.object is Qt.
10855
10856 * insdel.c (make_gap_larger): Remove limitation of buffer size
10857 to <= INT_MAX.
10858
16a43933
CY
108592011-04-18 Chong Yidong <cyd@stupidchicken.com>
10860
10861 * xdisp.c (lookup_glyphless_char_display)
10862 (produce_glyphless_glyph): Handle cons cell entry in
10863 glyphless-char-display.
10864 (Vglyphless_char_display): Document it.
10865
10866 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10867 glyphless-char-display.
10868
4581706e
CY
108692011-04-17 Chong Yidong <cyd@stupidchicken.com>
10870
10871 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10872
10873 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10874
10875 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10876 definition for no-X builds.
10877
4887c6e2 108782011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10879
fd35b6f9
PE
10880 Static checks with GCC 4.6.0 and non-default toolkits.
10881
5c1ccb01
PE
10882 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10883
006c5daa
PE
10884 * process.c (keyboard_bit_set): Define only if SIGIO.
10885 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10886 (send_process): Repair possible setjmp clobbering.
10887
efc736d3
PE
10888 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10889
4e2fe2e6
PE
10890 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10891
f97334a2
PE
10892 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10893
4e75f29d
PE
10894 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10895 Define only if needed.
10896
90efadd1
PE
10897 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10898 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10899 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10900
3c647824
PE
10901 * dispextern.h (struct redisplay_interface): Rename param
10902 to avoid shadowing.
e264f262 10903 * termhooks.h (struct terminal): Likewise.
761383f4 10904 * xterm.c (xembed_send_message): Likewise.
3c647824 10905
b58c5c4a
PE
10906 * insdel.c (make_gap_smaller): Define only if
10907 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10908
cad59032
PE
10909 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10910 it.
10911
c339dc2e
PE
10912 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10913 so that we aren't warned about unused symbols.
10914
91a3e27b
PE
10915 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10916
399c71d3 10917 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10918
8ffc96f5
PE
10919 * xfns.c (x_real_positions): Mark locals as initialized.
10920
eef9bc79
PE
10921 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10922
098db9dd
PE
10923 * xterm.c: Fix problems found by static analysis with other toolkits.
10924 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10925 (x_dispatch_event): Declare static if USE_GTK, and
10926 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10927 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10928 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10929 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10930 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10931
eb18f6cc
PE
10932 * xmenu.c (menu_help_callback): Pointer type fixes.
10933 Use const pointers when pointing at readonly data. Avoid pointer
10934 signedness clashes.
10935 (FALSE): Remove unused macro.
10936 (update_frame_menubar): Remove unused decl.
10937
1fe72bf8
PE
10938 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10939
60d9e1db
PE
10940 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10941 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10942 (single_menu_item): Rename local to avoid shadowing.
10943
39261c26
PE
10944 * keyboard.c (make_lispy_event): Remove unused local var.
10945
018c5e19
PE
10946 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10947 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10948
63d2b86e
PE
10949 * bitmaps: Change bitmaps from unsigned char back to the X11
10950 compatible char. Avoid the old compiler warnings about
10951 out-of-range initializers by using, for example, '\xab' rather
10952 than 0xab.
10953
aefd87e1
PE
10954 * xgselect.c (xgselect_initialize): Check vs interface
10955 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10956
bf501fb9
PE
10957 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10958
e9829fdf
PE
10959 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10960 to read-only memory.
10961
1086c095
PE
10962 * fns.c (vector): Remove; this old hack is no longer needed.
10963
2baccd04 10964 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10965 Remove unused var.
dde42981 10966 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10967
72391843 10968 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10969
436c16df 10970 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10971 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10972 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10973
92bb796d 10974 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10975 (x_term_init): Remove local to avoid shadowing.
92bb796d 10976
764430a3 10977 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10978
10979 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10980 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10981
d1dfb56c
EZ
109822011-04-16 Eli Zaretskii <eliz@gnu.org>
10983
c4354cb4
EZ
10984 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10985
d1dfb56c
EZ
10986 Fix regex.c, syntax.c and friends for buffers > 2GB.
10987 * syntax.h (struct gl_state_s): Declare character position members
10988 EMACS_INT.
10989
10990 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10991
04f2d78b
CB
10992 * textprop.c (verify_interval_modification, interval_of):
10993 Declare arguments EMACS_INT.
d1dfb56c
EZ
10994
10995 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10996 EMACS_INT.
10997
10998 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10999
11000 * indent.c (Fvertical_motion): Local variable it_start is now
11001 EMACS_INT.
11002
11003 * regex.c (re_match, re_match_2, re_match_2_internal)
11004 (bcmp_translate, regcomp, regexec, print_double_string)
11005 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11006 (re_compile_pattern, re_exec): Declare arguments and local
11007 variables `size_t' and `ssize_t' and return values `regoff_t', as
11008 appropriate.
11009 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11010 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11011 <compile_stack_type>: `size' and `avail' are now `size_t'.
11012
11013 * regex.h <regoff_t>: Use ssize_t, not int.
11014 (re_search, re_search_2, re_match, re_match_2): Arguments that
11015 specify buffer/string position and length are now ssize_t and
11016 size_t. Return type is regoff_t.
11017
613052cd
BK
110182011-04-16 Ben Key <bkey76@gmail.com>
11019
11020 * nsfont.m: Fixed bugs in ns_get_family and
11021 ns_descriptor_to_entity that were caused by using free to
11022 deallocate memory blocks that were allocated by xmalloc (via
11023 xstrdup). This caused Emacs to crash when compiled with
11024 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11025 --enable-checking=xmallocoverrun). xfree is now used to
11026 deallocate these memory blocks.
11027
4170f62f 110282011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11029
71b41406
PE
11030 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11031
9587a89d
PE
11032 emacs_write: Accept and return EMACS_INT for sizes.
11033 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11034 et seq.
11035 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11036 Accept and return EMACS_INT.
11037 (emacs_gnutls_write): Return the number of bytes written on
11038 partial writes.
11039 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11040 (emacs_read, emacs_write): Remove check for negative size, as the
11041 Emacs source code has been audited now.
9587a89d
PE
11042 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11043 (emacs_read, emacs_write): Use it.
273a5f82
PE
11044 * process.c (send_process): Adjust to the new signatures of
11045 emacs_write and emacs_gnutls_write. Do not attempt to store
11046 a byte offset into an 'int'; it might overflow.
9587a89d 11047 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11048
3e047f51
PE
11049 * sound.c: Don't assume sizes fit in 'int'.
11050 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11051 Return EMACS_INT, not int.
3e047f51 11052 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11053 Accept EMACS_INT, not int.
11054 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11055 record read return values.
11056
cc39a9db
BK
110572011-04-15 Ben Key <bkey76@gmail.com>
11058
c9d0ec6d
JB
11059 * keyboard.c (Qundefined): Don't declare static since it is used
11060 in nsfns.m.
11061 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11062 static since they are used in nsfont.m.
cc39a9db 11063
6c60eb9f
SM
110642011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11065
11066 * process.c (Qprocessp): Don't declare static.
11067 * lisp.h (Qprocessp): Declare again.
11068
7990b61a
JB
110692011-04-15 Juanma Barranquero <lekktu@gmail.com>
11070
11071 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11072
5d4cb038
PE
110732011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11074
8bd7b830 11075 Improve C-level modularity by making more things 'static'.
cd64ea1d 11076
e3b27b31
PE
11077 Don't publish debugger-only interfaces to other modules.
11078 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11079 (verify_bytepos, count_markers): Move decls to the only modules
11080 that need them.
11081 * region-cache.h (pp_cache): Likewise.
11082 * window.h (check_all_windows): Likewise.
11083 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11084
5d4cb038
PE
11085 * sysdep.c (croak): Now static, if
11086 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11087 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11088
11089 * alloc.c (refill_memory_reserve): Now static if
11090 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11091 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11092
e87b6180
PE
11093 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11094 Define only if USE_LUCID.
11095
ac64929e
PE
11096 * xrdb.c (x_customization_string, x_rm_string): Now static.
11097
6f37259d
PE
11098 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11099 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11100
1683e3ab
PE
11101 * xdisp.c (draw_row_with_mouse_face): Now static.
11102 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11103
de9c2632
PE
11104 * window.h (check_all_windows): Mark externally visible.
11105
2b96acb7
PE
11106 * window.c (window_deletion_count): Now static.
11107
11108 * undo.c: Make symbols static if they're not exported.
11109 (last_undo_buffer, last_boundary_position, pending_boundary):
11110 Now static.
11111
50436f33
PE
11112 * textprop.c (interval_insert_behind_hooks): Now static.
11113 (interval_insert_in_front_hooks): Likewise.
11114
64520e5c
PE
11115 * term.c: Make symbols static if they're not exported.
11116 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11117 (max_frame_lines, tty_set_terminal_modes):
11118 (tty_reset_terminal_modes, tty_turn_off_highlight):
11119 (get_tty_terminal): Now static.
11120 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11121 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11122 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11123 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11124 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11125
1fa53021
PE
11126 * sysdep.c: Make symbols static if they're not exported.
11127 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11128 Now static.
11129 (sigprocmask_set, full_mask): Remove; unused.
11130 (wait_debugging): Mark as visible.
11131 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11132 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11133
d4b43b22
PE
11134 * syntax.c (syntax_temp): Define only if !__GNUC__.
11135
b7c513d0
PE
11136 * sound.c (current_sound_device, current_sound): Now static.
11137
989b29ad
PE
11138 * search.c (searchbufs, searchbuf_head): Now static.
11139
13a55a78
PE
11140 * scroll.c (scroll_cost): Remove; unused.
11141 * dispextern.h (scroll_cost): Remove decl.
11142
de68a1fc
PE
11143 * region-cache.h (pp_cache): Mark as externally visible.
11144
40ccffa6
PE
11145 * process.c: Make symbols static if they're not exported.
11146 (process_tick, update_tick, create_process, chan_process):
11147 (Vprocess_alist, proc_buffered_char, datagram_access):
11148 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11149 (deactivate_process): Mark defn as static, as well as decl.
11150 * lisp.h (create_process): Remove decl.
11151 * process.h (chan_process, Vprocess_alist): Remove decls.
11152
ad64fc97
PE
11153 * print.c: Make symbols static if they're not exported.
11154 (print_depth, new_backquote_output, being_printed, print_buffer):
11155 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11156 (print_interval, print_number_index, initial_stderr_stream):
11157 Now static.
11158 * lisp.h (Fprinc): Remove decl.
11159 (debug_output_compilation_hack): Mark as externally visible.
11160
adddb265
PE
11161 * sysdep.c (croak): Move decl from here to syssignal.h.
11162 * syssignal.h (croak): Put it here, so the API can be checked when
11163 'croak' is called from dissociate_if_controlling_tty.
11164
1717ede2
PE
11165 * minibuf.c: Make symbols static if they're not exported.
11166 (minibuf_save_list, choose_minibuf_frame): Now static.
11167 * lisp.h (choose_minibuf_frame): Remove decl.
11168
fa5fb2bc
PE
11169 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11170
1e3890d1
PE
11171 * lread.c: Make symbols static if they're not exported.
11172 (read_objects, initial_obarray, oblookup_last_bucket_number):
11173 Now static.
11174 (make_symbol): Remove; unused.
11175 * lisp.h (initial_obarray, make_symbol): Remove decls.
11176
8a1414fa
PE
11177 * keyboard.c: Make symbols static if they're not exported.
11178 (single_kboard, recent_keys_index, total_keys, recent_keys):
11179 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11180 (this_single_command_key_start, echoing, last_auto_save):
11181 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11182 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11183 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11184 (Vlispy_mouse_stem, double_click_count):
11185 Now static.
11186 (force_auto_save_soon): Define only if SIGDANGER.
11187 (ignore_mouse_drag_p): Now static if
11188 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11189 (print_help): Remove; unused.
11190 (stop_character, last_timer_event): Mark as externally visible.
11191 * keyboard.h (ignore_mouse_drag_p): Declare only if
11192 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11193 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11194 * lisp.h (echoing): Remove decl.
11195 (force_auto_save_soon): Declare only if SIGDANGER.
11196 * xdisp.c (redisplay_window): Simplify code, to make it more
11197 obvious that ignore_mouse_drag_p is not accessed if !defined
11198 USE_GTK && !defined HAVE_NS.
11199
93ea6e8f
PE
11200 * intervals.c: Make symbols static if they're not exported.
11201 (merge_properties_sticky, merge_interval_right, delete_interval):
11202 Now static.
11203 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11204
77382fcc
PE
11205 * insdel.c: Make symbols static if they're not exported.
11206 However, leave prepare_to_modify_buffer alone. It's never
11207 called from outside this function, but that appears to be a bug.
11208 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11209 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11210 (adjust_after_replace_noundo): Remove; unused.
11211 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11212 (signal_before_change): Remove decls.
77382fcc 11213
9306c32e
PE
11214 * indent.c (val_compute_motion, val_vmotion): Now static.
11215
cd44d2eb
PE
11216 * image.c: Make symbols static if they're not exported.
11217 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11218 if USE_GTK.
11219 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11220 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11221
ad9a7a06
PE
11222 * fringe.c (standard_bitmaps): Now static.
11223 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11224
81626931
PE
11225 * frame.c: Make symbols static if they're not exported.
11226 (x_report_frame_params, make_terminal_frame): Now static.
11227 (get_frame_param): Now static, unless HAVE_NS.
11228 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11229 (x_get_resource_string): Remove; not used.
11230 * frame.h (make_terminal_frame, x_report_frame_params):
11231 (x_get_resource_string); Remove decls.
11232 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11233 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11234
239f9db9
PE
11235 * font.c, fontset.c: Make symbols static if they're not exported.
11236 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11237 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11238 * font.c (font_close_object): Now static.
11239 * font.h (font_close_object): Remove.
11240 * fontset.c (FONTSET_OBJLIST): Remove.
11241 (free_realized_fontset) #if-0 the body, which does nothing.
11242 (face_suitable_for_char_p): #if-0, as it's never called.
11243 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11244 * xfaces.c (face_at_string_position):
11245 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11246 since 0 is always ASCII.
11247
dfcf3579
PE
11248 * fns.c (weak_hash_tables): Now static.
11249
5045092b
PE
11250 * fileio.c: Make symbols static if they're not exported.
11251 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11252 (Vwrite_region_annotation_buffers): Now static.
11253
57a96f5c
PE
11254 * eval.c: Make symbols static if they're not exported.
11255 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11256 * lisp.h (backtrace_list): Remove decl.
11257
35f08c38
PE
11258 * emacs.c: Make symbols static if they're not exported.
11259 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11260 (fatal_error_code, fatal_error_signal_hook, standard_args):
11261 Now static.
11262 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11263 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11264 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11265 * lisp.h (fatal_error_signal_hook): Remove decl.
11266 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11267
f44bd759
PE
11268 * editfns.c: Move a (normally-unused) function to its only use.
11269 * editfns.c, lisp.h (get_operating_system_release): Remove.
11270 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11271 worth the hassle of breaking this out.
11272
b532497d
PE
11273 * xterm.c: Make symbols static if they're not exported.
11274 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11275 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11276 (x_destroy_window, x_delete_display):
11277 Now static.
11278 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11279 (x_mouse_leave): Remove; unused.
11280 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11281 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11282 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11283 Remove decls.
11284 (x_mouse_leave): Declare only if WINDOWSNT.
11285 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11286 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11287 USE_X_TOOLKIT.
11288
1675728f
PE
11289 * ftxfont.c: Make symbols static if they're not exported.
11290 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11291 HAVE_FREETYPE.
11292 * font.h (ftxfont_driver): Likewise.
11293
e4cebfca
PE
11294 * xfns.c: Make symbols static if they're not exported.
11295 (x_last_font_name, x_display_info_for_name):
11296 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11297 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11298 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11299 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11300 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11301 (last_show_tip_args): Now static.
11302 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11303 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11304 (x_screen_planes): Remove; unused.
11305 * dispextern.h (x_screen_planes): Remove decl.
11306
5bf46f05
PE
11307 * dispnew.c: Make symbols static if they're not exported.
11308 * dispextern.h (redraw_garbaged_frames, scrolling):
11309 (increment_row_positions): Remove.
11310 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11311 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11312 Now static.
11313 (redraw_garbaged_frames): Remove; unused.
11314
435f4c28
PE
11315 * xfaces.c: Make symbols static if they're not exported.
11316 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11317 Remove decls.
11318 * xterm.h (defined_color): Remove decls.
11319 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11320 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11321 (menu_face_changed_default, defined_color, free_realized_face):
11322 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11323 (ascii_face_of_lisp_face): Remove; unused.
11324
8524aef3
PE
11325 * xdisp.c: Make symbols static if they're not exported.
11326 * dispextern.h (scratch_glyph_row, window_box_edges):
11327 (glyph_to_pixel_coords, set_cursor_from_row):
11328 (get_next_display_element, set_iterator_to_next):
11329 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11330 (show_mouse_face): Remove decls
11331 * frame.h (message_buf_print): Likewise.
11332 * lisp.h (pop_message, set_message, check_point_in_composition):
11333 Likewise.
11334 * xterm.h (set_vertical_scroll_bar): Likewise.
11335 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11336 (message_buf_print, scratch_glyph_row, displayed_buffer):
11337 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11338 (get_next_display_element, show_mouse_face, window_box_edges):
11339 (frame_to_window_pixel_xy, check_point_in_composition):
11340 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11341 (glyph_to_pixel_coords): Remove; unused.
11342
16390cd2
PE
11343 * dired.c (file_name_completion): Now static.
11344
11345 * dbusbind.c (xd_in_read_queued_messages): Now static.
11346
a25f4dfa
PE
11347 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11348 * data.c (circular_list_error): Remove.
11349
14a9c8df
PE
11350 * commands.h (last_point_position, last_point_position_buffer):
11351 (last_point_position_window): Remove decls.
11352 * keyboard.c: Make these variables static.
11353
04f2d78b
CB
11354 * coding.h (coding, code_convert_region, encode_coding_gap):
11355 Remove decls.
74ab6df5
PE
11356 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11357 (iso_code_class, detect_coding, code_convert_region): Now static.
11358 (encode_coding_gap): Remove; unused.
11359
38dfbee1
PE
11360 * chartab.c (chartab_chars, chartab_bits): Now static.
11361
a2cb4e63
PE
11362 * charset.h (charset_iso_8859_1): Remove decl.
11363 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11364 Now static.
11365
127198fd
PE
11366 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11367 * ccl.c (Vccl_program_table): Now static.
11368 (check_ccl_update): Remove; unused.
11369
d85b608f
PE
11370 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11371 * category.h: ... from here.
11372 * category.c (check_category_table, set_category_set): Now static.
11373
31cd66f3
PE
11374 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11375 * lisp.h: Remove these decls.
11376
c358e587
PE
11377 * buffer.c (buffer_count): Remove unused var.
11378
e78aecca
PE
11379 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11380 so that it's not optimized away.
11381 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11382 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11383 exported only to the debugger.
11384
e192d7d3 11385 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11386 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11387
92470028
PE
11388 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11389 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11390 was inaccessible from Lisp.
11391 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11392 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11393
244ed907
PE
11394 alloc.c: Import and export fewer symbols, and remove unused items.
11395 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11396 is defined.
11397 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11398 it's not optimized away by whole-program optimization.
11399 (message_enable_multibyte, free_misc): Remove.
11400 (catchlist, handlerlist, mark_backtrace):
11401 Declare only if BYTE_MARK_STACK.
11402 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11403 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11404 (message_enable_multibyte): Remove decl.
11405 (free_misc, interval_free_list, float_block, float_block_index):
11406 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11407 (cons_free_list, last_marked_index):
11408 Now static.
11409 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11410 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11411 (mark_backtrace): Define only if BYTE_MARK_STACK.
11412 * xdisp.c (message_enable_multibyte): Now static.
11413
61c2b50e 11414 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11415 This makes it easier for human readers (and static analyzers)
11416 to see whether these variables are used from other modules.
11417 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11418 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11419 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11420 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11421 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11422 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11423 * xmenu.c, xselect.c:
11424 Declare Q* vars static if they are not used in other modules.
11425 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11426 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11427 Remove decls of unexported vars.
11428 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11429
95c82688
PE
11430 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11431
16a97296
PE
11432 Make Emacs functions such as Fatom 'static' by default.
11433 This makes it easier for human readers (and static analyzers)
11434 to see whether these functions can be called from other modules.
11435 DEFUN now defines a static function. To make the function external
11436 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11437 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11438 (Finit_image_library):
16a97296
PE
11439 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11440 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11441 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11442 Remove decls, since these functions are now static.
11443 (Funintern, Fget_internal_run_time): New decls, since these functions
11444 were already external.
95c82688 11445
16a97296
PE
11446 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11447 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11448 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11449 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11450 * keyboard.c, keymap.c, lread.c:
11451 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11452 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11453 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11454 Mark functions with DEFUE instead of DEFUN,
11455 if they are used in other modules.
11456 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11457 decls for now-static functions.
11458 * buffer.h (Fdelete_overlay): Remove decl.
11459 * callproc.c (Fgetenv_internal): Mark as internal.
11460 * composite.c (Fremove_list_of_text_properties): Remove decl.
11461 (Fcomposition_get_gstring): New forward static decl.
11462 * composite.h (Fcomposite_get_gstring): Remove decl.
11463 * dired.c (Ffile_attributes): New forward static decl.
11464 * doc.c (Fdocumntation_property): New forward static decl.
11465 * eval.c (Ffetch_bytecode): New forward static decl.
11466 (Funintern): Remove extern decl; now in .h file where it belongs.
11467 * fileio.c (Fmake_symbolic_link): New forward static decl.
11468 * image.c (Finit_image_library): New forward static decl.
11469 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11470 * intervals.h (Fprevious_property_change):
11471 (Fremove_list_of_text_properties): Remove decls.
11472 * keyboard.c (Fthis_command_keys): Remove decl.
11473 (Fcommand_execute): New forward static decl.
11474 * keymap.c (Flookup_key): New forward static decl.
11475 (Fcopy_keymap): Now static.
11476 * keymap.h (Flookup_key): Remove decl.
11477 * process.c (Fget_process): New forward static decl.
11478 (Fprocess_datagram_address): Mark as internal.
11479 * syntax.c (Fsyntax_table_p): New forward static decl.
11480 (skip_chars): Remove duplicate decl.
11481 * textprop.c (Fprevious_property_change): New forward static decl.
11482 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11483 Now internal.
11484 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11485 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11486
785bbd42
PE
11487 * editfns.c (Fformat): Remove unreachable code.
11488
8b913b57
AS
114892011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11490
11491 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11492 change. (Bug#8496)
11493
a6744a35
EZ
114942011-04-13 Eli Zaretskii <eliz@gnu.org>
11495
11496 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11497 when at ZV. (Bug#8487)
11498
e7974947
AS
114992011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11500
baad03f0
AS
11501 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11502 (Bug#8437)
11503 * keyboard.c (parse_tool_bar_item): Likewise.
11504 * sound.c (sound_cleanup, alsa_close): Likewise.
11505 * termcap.c (tgetent): Likewise.
11506 * xfns.c (x_default_font_parameter): Likewise.
11507 * xsettings.c (read_and_apply_settings): Likewise.
11508
e7974947
AS
11509 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11510 (overrun_check_free): Protoize.
11511
28272684
PE
115122011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11513
11514 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11515 since callers should never pass a negative size.
11516 Change the signature to match that of plain 'read' and 'write'; see
11517 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11518 * lisp.h: Update prototypes of emacs_write and emacs_read.
11519
11997c76
EZ
115202011-04-11 Eli Zaretskii <eliz@gnu.org>
11521
11522 * xdisp.c (redisplay_window): Don't try to determine the character
11523 position of the scroll margin if the window start point w->startp
e896f03c 11524 is outside the buffer's accessible region. (Bug#8468)
11997c76 11525
8a2cbd72
EZ
115262011-04-10 Eli Zaretskii <eliz@gnu.org>
11527
11528 Fix write-region and its subroutines for buffers > 2GB.
11529 * fileio.c (a_write, e_write): Modify declaration of arguments and
11530 local variables to support buffers larger than 2GB.
11531 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11532
11533 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11534 argument, local variables, and return value.
11535
11536 * lisp.h: Update prototypes of emacs_write and emacs_read.
11537
11538 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11539
4073e537 115402011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11541
1ebfdcb6
PE
11542 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11543
b2ded58d
PE
11544 Fix more problems found by GCC 4.6.0's static checks.
11545
7d66342c
PE
11546 * xdisp.c (vmessage): Use a better test for character truncation.
11547
bbf47d44
PE
11548 * charset.c (load_charset_map): <, not <=, for optimization,
11549 and to avoid potential problems with integer overflow.
9248994d 11550 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11551 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11552 * editfns.c (Fformat): Likewise.
1e69125e 11553 * syntax.c (skip_chars): Likewise.
3befa583 11554
e3019616
PE
11555 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11556 This also lets GCC 4.6.0 generate slightly better loop code.
11557
becfa255
PE
11558 * callint.c (Fcall_interactively): <, not <=, for optimization.
11559 (Fcall_interactively): Count the number of arguments produced,
11560 not the number of arguments given. This is simpler and lets GCC
11561 4.6.0 generate slightly better code.
11562
dae0cd48
PE
11563 * ftfont.c: Distingish more carefully between FcChar8 and char.
11564 The previous code passed unsigned char * to a functions like
11565 strlen and xstrcasecmp that expect char *, which does not
11566 conform to the C standard.
11567 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11568 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11569 char * when the C standard requires it.
11570
76032d70
PE
11571 * keyboard.c (read_char): Remove unused var.
11572
eb3f1cc8
PE
11573 * eval.c: Port to Windows vsnprintf (Bug#8435).
11574 Include <limits.h>.
11575 (SIZE_MAX): Define if the headers do not.
11576 (verror): Do not give up if vsnprintf returns a negative count.
11577 Instead, grow the buffer. This ports to Windows vsnprintf, which
11578 does not conform to C99. Problem reported by Eli Zaretskii.
11579 Also, simplify the allocation scheme, by avoiding the need for
11580 calling realloc, and removing the ALLOCATED variable.
11581
70476b54
PE
11582 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11583
12020a9e
PE
11584 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11585 But keep the doprint source code for now, as we might revamp it
11586 and use it again (Bug#8435).
ea6c7ae6
PE
11587 * lisp.h (doprnt): Remove.
11588 * Makefile.in (base_obj): Remove doprnt.o.
11589 * deps.mk (doprnt.o): Remove.
11590
5fdb398c
PE
11591 error: Print 32- and 64-bit integers portably (Bug#8435).
11592 Without this change, on typical 64-bit hosts error ("...%d...", N)
11593 was used to print both 32- and 64-bit integers N, which relied on
11594 undefined behavior.
61bdb816 11595 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11596 * lisp.h (error, verror): Mark as printf-like functions.
11597 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11598 Report overflow in size calculations when allocating printf buffer.
11599 Do not truncate output string at its first null byte.
11600 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11601 Truncate the output at a character boundary, since vsnprintf does not
11602 do that.
11603 * charset.c (check_iso_charset_parameter): Convert internal
11604 character to string before calling 'error', since %c now has the
11605 printf meaning.
11606 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11607 overflow when computing char to be passed to 'error'. Do not
11608 pass Lisp_Object to 'error'; pass the integer instead.
11609 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11610 formatted with plain %d.
11611
b189fa66
PE
11612 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11613
bff87ef0
PE
11614 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11615
7e2cac20
PE
11616 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11617
ce4d90b5
PE
11618 * xterm.c (x_catch_errors): Remove duplicate declaration.
11619
266c9547
PE
11620 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11621
79c49ad2
PE
11622 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11623
368f4090
JM
116242011-04-10 Jim Meyering <meyering@redhat.com>
11625
11626 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11627 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11628 return ssize_t not "int", and use size_t as the buffer length.
11629 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11630 * gnutls.h: Update declarations.
11631 * process.c (read_process_output): Use ssize_t, to match.
11632 (send_process): Likewise.
11633
a32d4040
CY
116342011-04-09 Chong Yidong <cyd@stupidchicken.com>
11635
11636 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11637
8546720e 116382011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11639
04f2d78b
CB
11640 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11641 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11642
8546720e
GM
11643 * xterm.c (handle_one_xevent):
11644 * xmenu.c (create_and_show_popup_menu):
11645 * xselect.c (x_decline_selection_request)
11646 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11647
0a2f5c1a 116482011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11649
11650 Fix some uses of `int' instead of EMACS_INT.
11651 * search.c (string_match_1, fast_string_match)
11652 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11653 (scan_buffer, find_next_newline_no_quit)
11654 (find_before_next_newline, search_command, Freplace_match)
11655 (Fmatch_data): Make some `int' variables be EMACS_INT.
11656
11657 * xdisp.c (display_count_lines): 3rd argument and return value now
11658 EMACS_INT. All callers changed.
11659 (pint2hrstr): Last argument is now EMACS_INT.
11660
11661 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11662 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11663 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11664 (decode_coding_utf_16, decode_coding_emacs_mule)
11665 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11666 (decode_coding_ccl, decode_coding_charset)
11667 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11668 (decode_coding_iso_2022, decode_coding_emacs_mule)
11669 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11670 <char_offset, last_offset>: Declare EMACS_INT.
11671 (encode_coding_utf_8, encode_coding_utf_16)
11672 (encode_coding_emacs_mule, encode_invocation_designation)
11673 (encode_designation_at_bol, encode_coding_iso_2022)
11674 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11675 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11676 Declare EMACS_INT.
11677 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11678 (encode_invocation_designation): Last argument P_NCHARS is now
11679 EMACS_INT.
11680 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11681 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11682
11683 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11684 All users changed.
11685
11686 * ccl.c (Fccl_execute_on_string): Declare some variables
11687 EMACS_INT.
11688
8546720e 116892011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11690
11691 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11692
4e19a977
CS
116932011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11694
11695 * process.c (Fformat_network_address): Doc fix.
11696
87302331
R
116972011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11698
ee7683eb 11699 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11700
cbb59342
CY
117012011-04-08 Chong Yidong <cyd@stupidchicken.com>
11702
11703 * keyboard.c (read_char): Call Lisp function help-form-show,
11704 instead of using internal_with_output_to_temp_buffer.
11705 (Qhelp_form_show): New var.
e0d38eeb 11706 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11707
11708 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11709
11710 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11711
e67a13ab
CY
117122011-04-06 Chong Yidong <cyd@stupidchicken.com>
11713
04f2d78b
CB
11714 * process.c (Flist_processes): Remove to Lisp.
11715 (list_processes_1): Delete.
e67a13ab 11716
973f782d
EZ
117172011-04-06 Eli Zaretskii <eliz@gnu.org>
11718
7c106b1e
EZ
11719 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11720
973f782d
EZ
11721 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11722
41cf7d1a 117232011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11724
ca23cc88
PE
11725 Fix more problems found by GCC 4.6.0's static checks.
11726
f390e2d5
PE
11727 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11728
42eea0d0
PE
11729 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11730
b69769da 11731 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11732
f9541e84
PE
11733 * xdisp.c (vmessage): Mark as a printf-like function.
11734
13841b55
PE
11735 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11736
c136c10f
PE
11737 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11738
5e2d4a30
PE
11739 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11740 printf-like functions.
11741 (tiff_load): Add casts to remove these marks before passing them
11742 to system-supplied API.
11743
583f48b9
PE
11744 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11745
b25d760e
PE
11746 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11747 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11748 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11749 directly, rather than having caller test rule sign. This avoids
11750 some unnecessary tests.
11751 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11752 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11753 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11754
bc7b6697 11755 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11756 (xfont_open): Avoid unnecessary tests.
bc7b6697 11757
27ccc379
PE
11758 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11759
dcd5c89a
PE
11760 * composite.h, composite.c (composition_gstring_put_cache):
11761 Use EMACS_INT, not int, for length.
11762
b13a45c6
PE
11763 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11764 breaking out part of COMPOSITION_DECODE_RULE.
11765 (COMPOSITION_DECODE_RULE): Use it.
11766 * composite.c (get_composition_id): Remove unused local vars,
11767 by using the new macro.
11768
1e792e4d
PE
11769 * textprop.c (set_text_properties_1): Change while to do-while,
11770 since the condition is always true at first.
11771
dc6c6455 11772 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11773 (interval_deletion_adjustment): Return unsigned value.
11774 All uses changed.
dc6c6455 11775
aba7731a
PE
11776 * process.c (list_processes_1, create_pty, read_process_output):
11777 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11778 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11779 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11780 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11781 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11782
fdfc4bf3
PE
11783 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11784
fca8fe46 11785 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11786 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11787
06a0259a 11788 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11789 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11790 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11791
e7b9e80f
PE
11792 * print.c (print_error_message): Avoid int overflow.
11793
56201685
PE
11794 * font.c (font_list_entities): Redo for clarity,
11795 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11796
78834453 11797 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11798 (font_score): Avoid potential overflow in diff calculation.
78834453 11799
0bc0b309 11800 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11801 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11802
e610eaca
PE
11803 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11804
b895abce
PE
11805 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11806 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11807 can always succeed if overflow has undefined behavior.
11808
1f1d9321 11809 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11810 (wordify): Omit three unnecessary tests.
1f1d9321 11811
c59478bc
PE
11812 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11813 All callers changed. This avoids the need for an unused var.
11814
79b73827
PE
11815 * casefiddle.c (casify_region): Remove var that is set but not used.
11816
a4db5dfe
PE
11817 * dired.c (file_name_completion): Remove var that is set but not used.
11818
43aae36e
PE
11819 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11820
2a47c44d 11821 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11822 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11823
a37c69bf
PE
11824 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11825 Check for integer overflow on size calculations.
11826
328ab8e7
PE
11827 * buffer.c (Fprevious_overlay_change): Remove var that is set
11828 but not used.
11829
e5a2a5cb
PE
11830 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11831 Remove vars that are set but not used.
8d84a6eb 11832 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11833 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11834
a60e5f68
PE
11835 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11836
f661cb61 11837 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11838 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11839
f0397f5a
PE
11840 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11841 that are set but not used.
11842
8664db06 11843 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11844 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11845
6abdaa4a
PE
11846 * xselect.c (x_get_local_selection, x_handle_property_notify):
11847 Remove vars that are set but not used.
11848
0ce7538d 11849 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11850 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11851
9ae848fc
PE
11852 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11853 Remove var that is set but not used.
0b918413
PE
11854 (scroll_bar_windows_size): Now size_t, not int.
11855 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11856 Check for overflow.
9ae848fc 11857
a5a62657
PE
11858 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11859 (map_tty_color) [!defined MSDOS]: Likewise.
11860
5c5cdd39
PE
11861 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11862
66ebf983
PE
11863 * coding.c: Remove vars that are set but not used.
11864 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11865 All callers changed.
11866 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11867 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11868 (decode_coding_charset): Remove vars that are set but not used.
11869
1be4d761
PE
11870 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11871 that is set but not used.
11872
47553fa8
PE
11873 * print.c (print_object): Remove var that is set but not used.
11874
1f7196bf 11875 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11876 The gnulib version avoids calling malloc in the usual case,
11877 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11878 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11879 * filelock.c (current_lock_owner): Likewise.
11880 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11881 * sysdep.c: Include allocator.h, careadlinkat.h.
11882 (emacs_no_realloc_allocator): New static constant.
11883 (emacs_readlink): New function.
fdb61804
PE
11884 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11885 ../lib/careadlinkat.h.
d1fdcab7 11886
f84c17c7
SM
118872011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11888
11889 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11890 first non-nil return value).
11891
ef3862ad
JD
118922011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11893
11894 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11895 if not defined (Bug#8403).
11896
376a7006
JB
118972011-04-02 Juanma Barranquero <lekktu@gmail.com>
11898
11899 * xdisp.c (display_count_lines): Remove parameter `start',
11900 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11901 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11902 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11903 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11904 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11905 and thereabouts. All callers changed.
11906 (get_per_char_metric): Remove parameter `f', unused since
11907 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11908
6ca3801d
JM
119092011-04-02 Jim Meyering <meyering@redhat.com>
11910
11911 do not dereference NULL upon failed strdup
11912 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11913 (ns_get_family): Likewise.
11914
d8e2b5ba
JB
119152011-04-02 Juanma Barranquero <lekktu@gmail.com>
11916
11917 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11918
8c74fcbd
JD
119192011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11920
11921 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11922 later (Bug#8403).
11923
7200d79c
SM
119242011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11925
03408648 11926 Add lexical binding.
7200d79c 11927
03408648
SM
11928 * window.c (Ftemp_output_buffer_show): New fun.
11929 (Fsave_window_excursion):
11930 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11931
11932 * lread.c (lisp_file_lexically_bound_p): New function.
11933 (Fload): Bind Qlexical_binding.
11934 (readevalloop): Remove `evalfun' arg.
11935 Bind Qinternal_interpreter_environment.
11936 (Feval_buffer): Bind Qlexical_binding.
11937 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11938 Mark as dynamic.
11939 (syms_of_lread): Declare `lexical-binding'.
11940
11941 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11942
11943 * keyboard.c (eval_dyn): New fun.
11944 (menu_item_eval_property): Use it.
ca105506
SM
11945
11946 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11947
03408648
SM
11948 * fns.c (concat, mapcar1): Accept byte-code-functions.
11949
11950 * eval.c (Fsetq): Handle lexical vars.
11951 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11952 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11953 (FletX, Flet): Obey lexical binding.
11954 (Fcommandp): Handle closures.
11955 (Feval): New `lexical' arg.
11956 (eval_sub): New function extracted from Feval. Use it almost
11957 everywhere where Feval was used. Look up vars in lexical env.
11958 Handle closures.
11959 (Ffunctionp): Move from subr.el.
11960 (Ffuncall): Handle closures.
11961 (apply_lambda): Remove `eval_flags'.
11962 (funcall_lambda): Handle closures and new byte-code-functions.
11963 (Fspecial_variable_p): New function.
11964 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11965 but without exporting it to Lisp.
23aba0ea 11966
23aba0ea 11967 * doc.c (Fdocumentation, store_function_docstring):
03408648 11968 * data.c (Finteractive_form): Handle closures.
23aba0ea 11969
03408648
SM
11970 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11971 interactive spec.
ba83908c 11972
04f2d78b
CB
11973 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11974 New byte-codes.
03408648
SM
11975 (exec_byte_code): New function extracted from Fbyte_code to handle new
11976 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11977
03408648 11978 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11979
03408648 11980 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11981
e2abce01
JB
119822011-03-31 Juanma Barranquero <lekktu@gmail.com>
11983
11984 * xdisp.c (redisplay_internal): Fix prototype.
11985
63696a73 119862011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11987
63696a73 11988 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11989 (try_scrolling): Use it when setting scroll_limit.
11990 Limit scrolling to 100 screen lines.
63696a73
EZ
11991 (redisplay_window): Even when falling back on "recentering",
11992 position point in the window according to scroll-conservatively,
11993 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11994
11995 (try_scrolling): When point is above the window, allow searching
11996 as far as scroll_max, or one screenful, to compute vertical
11997 distance from PT to the scroll margin position. This prevents
11998 try_scrolling from unnecessarily failing when
11999 scroll-conservatively is set to a value slightly larger than the
12000 window height. Clean up the case of PT below the margin at bottom
12001 of window: scroll_max can no longer be INT_MAX. When aggressive
12002 scrolling is in use, don't let point enter the opposite scroll
12003 margin as result of the scroll.
12004 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12005 threshold of 100 lines for never-recentering scrolling.
12006
e4cc2dfc
JB
120072011-03-31 Juanma Barranquero <lekktu@gmail.com>
12008
12009 * dispextern.h (move_it_by_lines):
12010 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12011 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12012 (message_log_check_duplicate): Remove parameters `prev_bol' and
12013 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12014 (redisplay_internal): Remove parameter `preserve_echo_area',
12015 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12016
12017 * indent.c (Fvertical_motion):
12018 * window.c (window_scroll_pixel_based, Frecenter):
12019 Don't pass `need_y_p' to `move_it_by_lines'.
12020
1c470562
SM
120212011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12022
44f230aa
SM
12023 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12024 steal a few bits to be more compact.
12025 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12026 Remove unneeded casts.
12027
1c470562
SM
12028 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12029
888adce9
ZK
120302011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12031
12032 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12033 binding" message (bug#7967).
12034
f838ed7b
PE
120352011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12036
77861b95
PE
12037 Fix more problems found by GCC 4.6.0's static checks.
12038
de6dbc14
PE
12039 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12040 Remove unused local var.
12041
f838ed7b
PE
12042 * editfns.c (Fmessage_box): Remove unused local var.
12043
792c7b2b
PE
12044 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12045 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12046 Omit unused local vars.
c499e557 12047 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12048 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12049 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12050 Omit unused local var.
12051
ba0165e1
PE
12052 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12053 Don't assume string length fits in int.
32ad8845 12054 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12055 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12056
3c59b4c9
PE
12057 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12058 instead of alloca (Bug#8344).
12059
a3eed478 12060 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12061 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12062
eb4d412d
PE
12063 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12064
1658b401
PE
12065 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12066 concerns.
12067
12068 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12069
12070 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12071
9a2c6e05
PE
12072 * keyboard.c (syms_of_keyboard): Use the same style as later
12073 in this function when indexing through an array. This also
12074 works around GCC bug 48267.
12075
03d0a109
PE
12076 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12077
44f730c8
PE
12078 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12079
fe75f926
PE
12080 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12081 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12082
ffa8c828
PE
12083 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12084 This avoids undefined behavior on integer overflow, and is a bit
12085 more convenient anyway since it is compared to a size_t variable.
12086
c5101a77
PE
12087 Variadic C functions now count arguments with size_t, not int.
12088 This avoids an unnecessary limitation on 64-bit machines, which
12089 caused (substring ...) to crash on large vectors (Bug#8344).
12090 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12091 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12092 All variadic functions and their callers changed accordingly.
c5101a77
PE
12093 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12094 * data.c (arith_driver, float_arith_driver): Likewise.
12095 * editfns.c (general_insert_function): Likewise.
12096 * eval.c (struct backtrace.nargs, interactive_p)
12097 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12098 (funcall_lambda, mark_backtrace): Likewise.
12099 * fns.c (concat): Likewise.
12100 * frame.c (x_set_frame_parameters): Likewise.
12101 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12102 0 if not found, not -1. All callers changed.
12103
dd3f25f7
PE
12104 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12105 (stack_copy_size): Now size_t, not int.
12106 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12107
461c2ab9
JB
121082011-03-28 Juanma Barranquero <lekktu@gmail.com>
12109
12110 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12111 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12112 All callers changed.
12113
12114 * lisp.h (multibyte_char_to_unibyte):
12115 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12116 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12117 * character.h (CHAR_TO_BYTE8):
12118 * cmds.c (internal_self_insert):
12119 * editfns.c (general_insert_function):
12120 * keymap.c (push_key_description):
12121 * search.c (Freplace_match):
12122 * xdisp.c (message_dolog, set_message_1): All callers changed.
12123
f6d62986
SM
121242011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12125
12126 * keyboard.c (safe_run_hook_funcall): New function.
12127 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12128 don't set the hook to nil, but remove the offending function instead.
12129 (Qcommand_hook_internal): Remove, unused.
12130 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12131 Vcommand_hook_internal.
12132
12133 * eval.c (enum run_hooks_condition): Remove.
12134 (funcall_nil, funcall_not): New functions.
12135 (run_hook_with_args): Call each function through a `funcall' argument.
12136 Remove `cond' argument, now redundant.
12137 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12138 (Frun_hook_with_args_until_failure): Adjust accordingly.
12139 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12140
1db5b1ad
JB
121412011-03-28 Juanma Barranquero <lekktu@gmail.com>
12142
12143 * dispextern.h (string_buffer_position): Remove declaration.
12144
12145 * print.c (strout): Remove parameter `multibyte', unused since
12146 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12147
12148 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12149 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12150 All callers changed.
12151
12152 * w32.c (_wsa_errlist): Use braces for struct initializers.
12153
12154 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12155 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12156 All callers changed.
12157 (string_buffer_position): Likewise. Also, make static (it's never
12158 used outside xdisp.c).
12159 (cursor_row_p): Remove parameter `w', unused since
12160 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12161 (decode_mode_spec): Remove parameter `precision', introduced during
12162 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12163 All callers changed.
12164
5ffb62aa
JD
121652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12166
12167 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12168
461c2ab9 121692011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12170
12171 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12172 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12173 (ns_update_auto_hide_menu_bar): New functions.
12174 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12175 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12176 ns_constrain_all_frames.
12177 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12178 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12179
5c380ffb
JD
121802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12181
12182 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12183
9af30bdf
GM
121842011-03-27 Glenn Morris <rgm@gnu.org>
12185
12186 * syssignal.h: Replace RETSIGTYPE with void.
12187 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12188 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12189 Replace SIGTYPE with void everywhere.
12190 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12191 * s/template.h (SIGTYPE): Remove commented out definition.
12192
e2abce01
JB
121932011-03-26 Eli Zaretskii <eliz@gnu.org>
12194
12195 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12196 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12197
f868cd8a
JB
121982011-03-26 Juanma Barranquero <lekktu@gmail.com>
12199
59eb0929
JB
12200 * w32.c (read_unc_volume): Use parameter `henum', instead of
12201 global variable `wget_enum_handle'.
12202
12203 * keymap.c (describe_vector): Remove parameters `indices' and
12204 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12205 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12206
f868cd8a
JB
12207 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12208
12209 * keyboard.c (timer_check): Remove parameter `do_it_now',
12210 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12211 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12212 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12213
12214 * keyboard.c (read_char):
12215 * w32menu.c (w32_menu_display_help):
12216 * xmenu.c (show_help_event, menu_help_callback):
12217 Adjust calls to `show_help_echo'.
12218
12219 * gtkutil.c (xg_maybe_add_timer):
12220 * keyboard.c (readable_events):
12221 * process.c (wait_reading_process_output):
12222 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12223
12224 * insdel.c (adjust_markers_gap_motion):
12225 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12226 (gap_left, gap_right): Don't call it.
12227
2ecf6fdb
CY
122282011-03-25 Chong Yidong <cyd@stupidchicken.com>
12229
12230 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12231 incurred during fontification.
12232
6b1f9ba4
JB
122332011-03-25 Juanma Barranquero <lekktu@gmail.com>
12234
12235 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12236 (DEFVAR_PER_BUFFER): Don't pass it.
12237
12238 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12239 (scrolling_window): Don't pass it.
12240
0f4a96b5
JB
122412011-03-25 Juanma Barranquero <lekktu@gmail.com>
12242
12243 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12244
12245 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12246 and `suffix'.
12247 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12248 of variables specific to SELinux and computation of `encoded_absname'.
12249
12250 * image.c (XPutPixel): Remove unused variable `height'.
12251
12252 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12253
12254 * unexw32.c (get_section_info): Remove unused variable `section'.
12255
12256 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12257 (system_process_attributes): Remove unused variable `sess'.
12258 (sys_read): Remove unused variable `err'.
12259
12260 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12261 (w32_wnd_proc): Remove unused variable `isdead'.
12262 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12263 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12264 (x_create_tip_frame): Remove unused variable `tem'.
12265
12266 * w32inevt.c (w32_console_read_socket):
12267 Remove unused variable `no_events'.
12268
12269 * w32term.c (x_draw_composite_glyph_string_foreground):
12270 Remove unused variable `width'.
12271
1149507c
JB
122722011-03-24 Juanma Barranquero <lekktu@gmail.com>
12273
12274 * w32term.c (x_set_glyph_string_clipping):
12275 Don't pass uninitialized region to CombineRgn.
12276
9c88f339
JB
122772011-03-23 Juanma Barranquero <lekktu@gmail.com>
12278
12279 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12280 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12281 (Fx_close_connection): Remove unused variable `i'.
12282
12283 * w32font.c (w32font_draw): Return number of glyphs.
12284 (w32font_open_internal): Remove unused variable `i'.
12285 (w32font_driver): Add missing initializer.
12286
12287 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12288 (fill_in_menu): Remove unused variable `items_added'.
12289
12290 * w32term.c (last_mouse_press_frame): Remove static global variable.
12291 (w32_clip_to_row): Remove unused variable `f'.
12292 (x_delete_terminal): Remove unused variable `i'.
12293
12294 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12295 (NOTHING): Remove unused static global variable.
12296 (uniscribe_check_otf): Remove unused variable `table'.
12297 (uniscribe_font_driver): Add missing initializers.
12298
dee091a3
JD
122992011-03-23 Julien Danjou <julien@danjou.info>
12300
12301 * term.c (Fsuspend_tty, Fresume_tty):
12302 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12303 * window.c (temp_output_buffer_show):
12304 * insdel.c (signal_before_change):
12305 * frame.c (Fhandle_switch_frame):
12306 * fileio.c (Fdo_auto_save):
12307 * emacs.c (Fkill_emacs):
12308 * editfns.c (save_excursion_restore):
12309 * cmds.c (internal_self_insert):
12310 * callint.c (Fcall_interactively):
12311 * buffer.c (Fkill_all_local_variables):
12312 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12313 Use Frun_hooks.
0f4a96b5 12314 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12315 unconditionally since it does the check itself.
dee091a3 12316
2c520ab5 123172011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12318
c9c49752
PE
12319 Fix more problems found by GCC 4.5.2's static checks.
12320
8abc3f12
PE
12321 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12322 the first time through the loop, since we know p0 < p1 then.
12323 This also avoids a gcc -Wstrict-overflow warning.
12324
a2d26660
PE
12325 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12326 leading to a memory leak, possible in functions like
12327 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12328 of objects (Bug#8318).
a2d26660 12329
916c72e9
PE
12330 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12331 that could (at least in theory) be that large.
12332
19ab8a18
PE
12333 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12334 This is less likely to overflow, and avoids undefined behavior if
12335 overflow does occur. All callers changed. Use strtoul to scan
12336 for the unsigned long integer.
b7cbbd6f
PE
12337 (pint2hrstr): Simplify and tune code slightly.
12338 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12339
f0641eff
PE
12340 * scroll.c (do_scrolling): Work around GCC bug 48228.
12341 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12342
7f650bb9
PE
12343 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12344 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12345 (validate_x_resource_name): Simplify count usage.
12346 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12347
37dd57d1
PE
12348 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12349 fail (Bug#8306).
81e56e61 12350
699979fc 12351 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12352
401bf9b4
PE
12353 * process.c (Fmake_network_process): Use socklen_t, not int,
12354 where POSIX says socklen_t is required in portable programs.
12355 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12356 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12357 (Fmake_network_process, server_accept_connection):
12358 (wait_reading_process_output, read_process_output):
12359 Likewise.
12360
b93aacde
PE
12361 * process.c: Rename or move locals to avoid shadowing.
12362 (list_processes_1, Fmake_network_process):
12363 (read_process_output_error_handler, exec_sentinel_error_handler):
12364 Rename or move locals.
4dc343ee 12365 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12366 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12367 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12368 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12369 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12370
af8a867c 12371 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12372 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12373 Include tparam.h instead, since it declares them.
af8a867c
PE
12374 * cm.h (PC): Remove extern decl; tparam.h now does this.
12375 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12376 * terminfo.c: Include tparam.h, to check interfaces.
12377 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12378 (tparam): Adjust signature to match interface in tparam.h;
12379 this removes some undefined behavior. Check that outstring and len
12380 are zero, which they always are with Emacs.
12381 * tparam.h (PC, BC, UP): New extern decls.
12382
0248044d 12383 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12384 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12385
8ff096c1 12386 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12387 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12388 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12389 (ftfont_list): Remove unused local.
49eaafba
PE
12390 (get_adstyle_property, ftfont_pattern_entity):
12391 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12392 Rename locals to avoid shadowing.
8ff096c1 12393
e2be39f6
PE
12394 * xfont.c (xfont_list_family): Mark var as initialized.
12395
c9735e30
PE
12396 * xml.c (make_dom): Now static.
12397
8f5201ae
PE
12398 * composite.c (composition_compute_stop_pos): Rename local to
12399 avoid shadowing.
b246f932
PE
12400 (composition_reseat_it): Remove unused locals.
12401 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12402 (composition_update_it): Mark var as initialized.
11b61122
PE
12403 (find_automatic_composition): Mark vars as initialized,
12404 with a FIXME (Bug#8290).
8f5201ae 12405
760fbc2c
PE
12406 character.h: Rename locals to avoid shadowing.
12407 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12408 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12409 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12410 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12411 to avoid shadowing.
12412
ff08eb85
PE
12413 * textprop.c (property_change_between_p): Remove; unused.
12414
fc7bf025
PE
12415 * intervals.c (interval_start_pos): Now static.
12416
235d7abc
PE
12417 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12418
44f230aa
SM
12419 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12420 Rename locals to avoid shadowing.
3e7d6594 12421
50060332
PE
12422 * sound.c (wav_play, au_play, Fplay_sound_internal):
12423 Fix pointer signedness.
d01f234b 12424 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12425 (wav_play): Initialize a variable to 0, to prevent undefined
12426 behavior (Bug#8278).
50060332 12427
c4fc4e30
PE
12428 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12429
918436ed
PE
12430 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12431
c939f91b
PE
12432 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12433 clobbering (Bug#8298).
b9c7f648
PE
12434 * sysdep.c (sys_subshell): Likewise.
12435 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12436
6bd8c144
PE
12437 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12438 This should get cleaned up, so that child_setup has the
12439 same signature on all platforms.
12440
7710357c 12441 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12442 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12443
c59da222
CY
124442011-03-22 Chong Yidong <cyd@stupidchicken.com>
12445
12446 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12447 not to be necessary, and produces flickering.
12448
66b87493
GM
124492011-03-20 Glenn Morris <rgm@gnu.org>
12450
12451 * config.in: Remove file.
12452
45b6f6d5
JB
124532011-03-20 Juanma Barranquero <lekktu@gmail.com>
12454
12455 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12456 are now in src/globals.h.
12457 (syms_of_minibuf): Remove spurious & from previous change.
12458
cd394be1 124592011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12460
12461 * minibuf.c (completing-read-function): New variable.
12462 (completing-read-default): Rename from completing-read.
12463 (completing-read): Call completing-read-function.
12464
b14e3e21
CY
124652011-03-19 Juanma Barranquero <lekktu@gmail.com>
12466
12467 * xfaces.c (Fx_load_color_file):
12468 Read color file from absolute filename (bug#8250).
12469
f2b726e6
JB
124702011-03-19 Juanma Barranquero <lekktu@gmail.com>
12471
12472 * makefile.w32-in: Update dependencies.
12473
09f6ff02
EZ
124742011-03-17 Eli Zaretskii <eliz@gnu.org>
12475
12476 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12477
29a6015a
PE
124782011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12479
a3a6c54e
PE
12480 Fix more problems found by GCC 4.5.2's static checks.
12481
b766f867
PE
12482 * process.c (make_serial_process_unwind, send_process_trap):
12483 (sigchld_handler): Now static.
12484
be02381c
PE
12485 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12486 That way, the code declares only the vars that it needs.
12487 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12488 * s/cygwin.h (PTY_ITERATION): Likewise.
12489 * s/darwin.h (PTY_ITERATION): Likewise.
12490 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12491
57048744
PE
12492 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12493 * process.c (allocate_pty): Don't declare stb unless it's needed.
12494
7914961c 12495 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12496 (CONSTANTLIM): Remove; unused.
12497 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12498 Define only if needed.
7914961c 12499
b3967b18
PE
12500 * unexelf.c (unexec): Name an expression,
12501 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12502 Use a different way to cause a compilation error if anyone uses
12503 n rather than nn, a way that does not involve shadowing.
73366a00 12504 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12505
29a6015a
PE
12506 * deps.mk (unexalpha.o): Remove; unused.
12507
43cfc33e 12508 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12509 * unexec.h: New file.
ce701a33
PE
12510 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12511 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12512 Depend on unexec.h.
12513 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12514 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12515 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12516 Change as necessary to match prototype in unexec.h.
ce701a33 12517
01f44d5a
PE
12518 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12519 shadowing.
4f63c6bb 12520 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12521
a6670b0b
PE
12522 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12523 Rename locals to avoid shadowing.
12524
cef2010d 12525 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12526 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12527
d4d7173a
PE
12528 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12529
f08b802a
PE
12530 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12531 warning when compiling print.c.
12532
3ddb0639
PE
12533 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12534 instead of using an uninitialized var.
5ad03b97 12535 (font_sort_entities): Mark var as initialized.
3ddb0639 12536
170a2692
PE
12537 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12538
e663c700
PE
12539 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12540 pointers to constants.
89bc529a 12541 (font_parse_fcname): Remove unused vars.
7b81e2d0 12542 (font_delete_unmatched): Now static.
ea838e10 12543 (font_get_spec): Remove; unused.
13a547c6
PE
12544 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12545 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12546 Rename or move locals to avoid shadowing.
e663c700 12547
2a80c887 12548 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12549 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12550
1384fa33 12551 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12552 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12553
8b2c52e9
PE
12554 * alloc.c (mark_backtrace): Move decl from here ...
12555 * lisp.h: ... to here, so that it can be checked.
12556
475545b5 12557 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12558 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12559 (lisp_indirect_variable): Name an expression,
12560 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12561 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12562
b1349114 12563 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12564 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12565 Use const pointer when appropriate.
b1349114 12566
a2928364
PE
12567 * lisp.h (get_system_name, get_operating_system_release):
12568 Move decls here, to check interfaces.
12569 * process.c (get_operating_system_release): Move decl to lisp.h.
12570 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12571 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12572 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12573 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12574 (Fformat_time_string, Fencode_time, Finsert_char):
12575 (Ftranslate_region_internal, Fformat):
12576 Rename or remove local vars to avoid shadowing.
9710023e 12577 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12578
a415e694
PE
12579 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12580 avoid shadowing.
12581
8ef4622d
PE
12582 * lisp.h (eassert): Check that the argument compiles, even if
12583 ENABLE_CHECKING is not defined.
12584
946f9a5b
PE
12585 * data.c (Findirect_variable): Name an expression, to avoid
12586 gcc -Wbad-function-cast warning.
112396d6 12587 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12588 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12589 (Fmake_variable_buffer_local, Fmake_local_variable):
12590 Mark variables as initialized.
52746918 12591 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12592
e5aab7e7 12593 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12594 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12595 Rename locals to avoid shadowing.
dff45157
PE
12596 (mark_stack): Move local variables into the #ifdef region where
12597 they're used.
7bc26fdb
PE
12598 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12599 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12600 needed otherwise.
12601 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12602 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12603 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12604
e5aab7e7
PE
12605 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12606 avoids undefined behavior in theory.
12607
4da60324
PE
12608 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12609
88043301
PE
12610 Use functions, not macros, for up- and down-casing (Bug#8254).
12611 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12612 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12613 to use the following functions instead of these macros.
12614 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12615 EMACS_INT, since callers assume the returned value fits in int.
12616 (upcase1): Likewise, for UPCASE_TABLE.
12617 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12618 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12619 the race-condition problem in the old DOWNCASE.
88043301 12620
19ed5445
PE
12621 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12622 Rename locals to avoid shadowing.
12623 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12624 (regex_compile, re_search_2, re_match_2_internal):
12625 Remove unused local vars.
952db0d7
PE
12626 (FREE_VAR): Rewrite so as not to use empty "else",
12627 which gcc can warn about.
da053e48 12628 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12629 (RETALLOC_IF): Define only if needed.
12630 (WORDCHAR_P): Likewise. This one is never needed, but is used
12631 only in a comment talking about a compiler bug, so put inside
12632 the #if 0 of that comment.
12633 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12634 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12635 Remove; unused.
19ed5445 12636
1f3561e4 12637 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12638 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12639 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12640
ded6f8f7
PE
12641 * search.c (simple_search): Remove unused var.
12642
dbd37a95
PE
12643 * dired.c (compile_pattern): Move decl from here ...
12644 * lisp.h: ... to here, so that it can be checked.
12645 (struct re_registers): New forward decl.
12646
7e47afad
PE
12647 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12648
85f24f61
PE
12649 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12650 All uses changed.
12651 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12652 Rename locals to avoid shadowing.
5671df8f 12653 (Fvertical_motion): Mark locals as initialized.
85f24f61 12654
181aa2be 12655 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12656 (casify_region): Mark local as initialized.
181aa2be 12657
930d429c
PE
12658 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12659
7082eac6
PE
12660 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12661 New macros, so that the caller can use some names other than
12662 gcpro1, gcpro2, etc.
12663 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12664 of the new macros.
12665 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12666 argument, for consistency with GCPRO2_VAR, etc: it is now the
12667 prefix of the variable, not the variable itself. All uses
12668 changed.
38b2c076
PE
12669 * dired.c (directory_files_internal, file_name_completion):
12670 Rename locals to avoid shadowing.
12671
15206ed9
PE
12672 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12673 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12674 dired.c's scmp function, had undefined behavior.
12675 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12676 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12677 * buffer.h: ... to here, because these macros use current_buffer,
12678 and the new implementation with inline functions needs to have
12679 current_buffer in scope now, rather than later when the macros
12680 are used.
12681 (downcase, upcase1): New static inline functions.
12682 (DOWNCASE, UPCASE1): Reimplement using these functions.
12683 This avoids undefined behavior in expressions like
12684 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12685 from race conditions in accessing the global variables
12686 case_temp1 and case_temp2.
12687 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12688 * lisp.h (case_temp1, case_temp2): Remove their decls.
12689 * character.h (ASCII_CHAR_P): Move from here ...
12690 * lisp.h: ... to here, so that the inline functions mentioned
12691 above can use them.
12692
4a6bea26
PE
12693 * dired.c (directory_files_internal_unwind): Now static.
12694
f14b7e14
PE
12695 * fileio.c (file_name_as_directory, directory_file_name):
12696 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12697 Now static.
2893f146
PE
12698 (file_name_as_directory): Use const pointers when appropriate.
12699 (Fexpand_file_name): Likewise. In particular, newdir might
12700 point at constant storage, so make it a const pointer.
fd4ead52 12701 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12702 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12703 signedness issues.
f839df0c
PE
12704 (Fset_file_times, Finsert_file_contents, auto_save_error):
12705 Rename locals to avoid shadowing.
f14b7e14 12706
5716756e 12707 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12708 (Ftry_completion, Fall_completions): Rename or remove locals
12709 to avoid shadowing.
5716756e 12710
b4c3046a
PE
12711 * marker.c (bytepos_to_charpos): Remove; unused.
12712
b45db522
PE
12713 * lisp.h (verify_bytepos, count_markers): New decls,
12714 so that gcc does not warn that these functions aren't declared.
12715
85876d07
PE
12716 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12717 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12718 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12719 (copy_text): Remove unused local var.
85876d07 12720
03d78a21 12721 * filelock.c (within_one_second): Now static.
b3dd38ab 12722 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12723
5df8f01b
PE
12724 * buffer.c (fix_overlays_before): Mark locals as initialized.
12725 (fix_start_end_in_overlays): Likewise. This function should be
12726 simplified by using pointers-to-pointers, but that's a different
12727 matter.
b1d876f1 12728 (switch_to_buffer_1): Now static.
8f54f30a
PE
12729 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12730 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12731
a70072c9 12732 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12733 Fix pointer signedness issue.
edced198
PE
12734 (sys_subshell): Mark local as volatile if checking for lint,
12735 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12736 (MAXPATHLEN): Define only if needed.
a70072c9 12737
a0977c44
PE
12738 * process.c (serial_open, serial_configure): Move decls from here ...
12739 * systty.h: ... to here, so that they can be checked.
12740
a884fdcc
PE
12741 * fns.c (get_random, seed_random): Move extern decls from here ...
12742 * lisp.h: ... to here, so that they can be checked.
12743
604efe86 12744 * sysdep.c (reset_io): Now static.
b8950c94 12745 (wait_for_termination_signal): Remove; unused.
604efe86 12746
38fc62d9
PE
12747 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12748 (copy_keymap_item, append_key, push_text_char_description):
12749 Now static.
1004a21a 12750 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12751 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12752 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12753 (describe_map_tree):
12754 Rename locals to avoid shadowing.
38fc62d9 12755
2f2650da
PE
12756 * keyboard.c: Declare functions static if they are not used elsewhere.
12757 (echo_char, echo_dash, cmd_error, top_level_2):
12758 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12759 (read_char, kbd_buffer_get_event, make_lispy_position):
12760 (make_lispy_event, make_lispy_movement, apply_modifiers):
12761 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12762 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12763 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12764 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12765 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12766
a053e86c 12767 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12768 (mark_kboards): Move decl here ...
12769 * alloc.c (mark_kboards): ... from here.
a053e86c 12770
4752793e
PE
12771 * lisp.h (force_auto_save_soon): New decl.
12772
74f10ca7 12773 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12774 (DEFINE_DUMMY_FUNCTION): New macro.
12775 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12776 Use it.
c03cd23f
PE
12777 (main): Add casts to avoid warnings
12778 if GCC considers string literals to be constants.
74f10ca7 12779
022e70d4
PE
12780 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12781
59d6fe83
PE
12782 * dbusbind.c: Pointer signedness fixes.
12783 (xd_signature, xd_append_arg, xd_initialize):
12784 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12785 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12786 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12787 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12788
78320123
PE
12789 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12790 if GCC considers string literals to be constants.
49cebcca 12791 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12792
35ac2a97
SM
127932011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12794
fb103ca9
SM
12795 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12796 (print_preprocess, print_object): New macro to fix last change.
12797
35ac2a97
SM
12798 * print.c (print_preprocess): Don't forget font objects.
12799
62973b41
JB
128002011-03-16 Juanma Barranquero <lekktu@gmail.com>
12801
12802 * emacs.c (USAGE3): Doc fixes.
12803
0e48bb22
AS
128042011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12805
12806 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12807 structure.
12808
7684e57b
JB
128092011-03-14 Juanma Barranquero <lekktu@gmail.com>
12810
12811 * lisp.h (VWindow_system, Qfile_name_history):
12812 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12813 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12814 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12815
12816 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12817 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12818
12819 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12820 * w32console.c (detect_input_pending, read_input_pending)
12821 (encode_terminal_code):
12822 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12823 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12824 (w32_system_caret_y, Qfile_name_history):
12825 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12826 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12827 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12828 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12829 * w32proc.c (Qlocal, report_file_error):
12830 * w32term.c (Vwindow_system, updating_frame):
12831 * w32uniscribe.c (initialized, uniscribe_font_driver):
12832 Remove unneeded extern declarations.
12833
2aa46d6c
CY
128342011-03-14 Chong Yidong <cyd@stupidchicken.com>
12835
c96bbc66 12836 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12837
cffc6f3b
CY
128382011-03-13 Chong Yidong <cyd@stupidchicken.com>
12839
12840 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12841 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12842 These macros can no longer be used for assignment.
12843
44f230aa
SM
12844 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12845 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12846 (record_buffer_markers, fetch_buffer_markers): New functions for
12847 recording and fetching special buffer markers.
12848 (set_buffer_internal_1, set_buffer_temp): Use them.
12849
12850 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12851
12852 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12853
12854 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12855 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12856
12857 * xdisp.c (hscroll_window_tree):
12858 (reconsider_clip_changes): Use PT instead of BUF_PT.
12859
d251f04b
EZ
128602011-03-13 Eli Zaretskii <eliz@gnu.org>
12861
12862 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12863 $(EMACS_ROOT)/lib/intprops.h.
12864
f0c77cd1
PE
128652011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12866
3eca4629
PE
12867 Fix more problems found by GCC 4.5.2's static checks.
12868
7c86ee98
PE
12869 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12870 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12871 (xg_free_frame_widgets): Make it clear that a local variable is
12872 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12873 (gdk_window_get_screen): Make it clear that this macro is needed
12874 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12875 (int_gtk_range_get_value): New function, which avoids a diagnostic
12876 from gcc -Wbad-function-cast.
12877 (xg_set_toolkit_scroll_bar_thumb): Use it.
12878 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12879 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12880 (get_utf8_string, xg_get_file_with_chooser):
12881 Rename locals to avoid shadowing.
12882 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12883
41729b81
PE
12884 * xgselect.c (xg_select): Remove unused var.
12885
f0c77cd1
PE
12886 * image.c (four_corners_best): Mark locals as initialized.
12887 (gif_load): Initialize transparent_p to zero (Bug#8238).
12888 Mark another local as initialized.
ec6cf4c6 12889 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12890
ce0ad53d 12891 * image.c (clear_image_cache): Now static.
d5d5a617 12892 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12893 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12894 (x_edge_detection): Remove unnecessary cast that
12895 gcc -Wbad-function-cast diagnoses.
2037898d 12896 (gif_load): Fix pointer signedness.
6ae141d6
PE
12897 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12898 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12899
33383987 129002011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12901
d32df629
PE
12902 Improve quality of tests for time stamp overflow.
12903 For example, without this patch (encode-time 0 0 0 1 1
12904 1152921504606846976) returns the obviously-bogus value (-948597
12905 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12906 reports time overflow. See
12907 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12908 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12909 * editfns.c: Include limits.h and intprops.h.
12910 (TIME_T_MIN, TIME_T_MAX): New macros.
12911 (time_overflow): Move earlier, to before first use.
12912 (hi_time, lo_time): New functions, for an accurate test for
12913 out-of-range times.
12914 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12915 (Fget_internal_run_time): Don't assume time_t fits in int.
12916 (make_time): Use list2 instead of Fcons twice.
12917 (Fdecode_time): More accurate test for out-of-range times.
12918 (check_tm_member): New function.
12919 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12920 (lisp_time_argument): Don't rely on undefined left-shift and
12921 right-shift behavior when checking for time stamp overflow.
8be6f318 12922
fe31d94c
PE
12923 * editfns.c (time_overflow): New function, refactoring common code.
12924 (Fformat_time_string, Fdecode_time, Fencode_time):
12925 (Fcurrent_time_string): Use it.
12926
8be6f318
PE
12927 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12928 * dired.c (make_time): Move to ...
12929 * editfns.c (make_time): ... here.
12930 * systime.h: Note the move.
12931
09d9db2c 129322011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12933
126bc0dc
YM
12934 * fringe.c (update_window_fringes): Remove unused variables.
12935
c47cbdfd
YM
12936 * unexmacosx.c (copy_data_segment): Also copy __got section.
12937 (Bug#8223)
12938
7ac80be9
EZ
129392011-03-12 Eli Zaretskii <eliz@gnu.org>
12940
c96bbc66 12941 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12942 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12943 Constify `char *' arguments and their references according to
12944 prototypes in tparam.h.
12945
ecb0f94d 12946 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12947
7ac80be9
EZ
12948 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12949 Adapt all references accordingly.
12950
12951 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12952
ef1fd07e
TT
129532011-03-11 Tom Tromey <tromey@redhat.com>
12954
12955 * buffer.c (syms_of_buffer): Remove obsolete comment.
12956
7ef4b50c
EZ
129572011-03-11 Eli Zaretskii <eliz@gnu.org>
12958
12959 * termhooks.h (encode_terminal_code): Declare prototype.
12960
12961 * msdos.c (encode_terminal_code): Don't declare prototype.
12962
12963 * term.c (encode_terminal_code): Now external again, used by
12964 w32console.c and msdos.c.
12965
44f230aa
SM
12966 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12967 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12968
4b1ec863 129692011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12970
1714f52b 12971 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12972
4b1ec863
PE
12973 * fringe.c (update_window_fringes): Mark locals as initialized
12974 (Bug#8227).
12975 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12976
524c7aa6
PE
12977 * alloc.c (mark_fringe_data): Move decl from here ...
12978 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12979 to check its interface.
12980 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12981
a5c0af81 12982 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12983 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12984 (fontset_font): Mark local as initialized.
a9a06e0b 12985 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12986
b4716021
PE
12987 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12988
811e9bac 12989 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12990 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12991 (x_own_selection, Fx_disown_selection_internal): Rename locals
12992 to avoid shadowing.
12993 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12994
7e3ab302
PE
12995 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12996 so that the caller can use some name other than gcpro1.
12997 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12998 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12999 (Fx_backspace_delete_keys_p):
13000 Use them to avoid shadowing, and rename vars to avoid shadowing.
13001 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13002 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13003 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13004 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13005 Remove unused locals.
7e3ab302
PE
13006 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13007 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13008 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13009 macros.
f78faa98 13010
e2b13473
PE
13011 * xterm.h (x_mouse_leave): New decl.
13012
77f23912
PE
13013 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13014 Remove unused functions.
cdf4ba58
PE
13015 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13016 (x_calc_absolute_position): Now static.
7411c686 13017 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13018 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13019 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13020 unless they are used.
38d0b34a
PE
13021 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13022 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13023 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13024 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13025 (x_error_catcher, x_connection_closed, x_error_handler):
13026 (x_error_quitter, xembed_send_message, x_iconify_frame):
13027 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13028 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13029 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13030
44f230aa
SM
13031 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13032 Rename or move locals to avoid shadowing.
6b463e58 13033 (tty_defined_color, merge_face_heights): Now static.
5967d051 13034 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13035 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13036 does not deduce is never used uninitialized.
73719eba
PE
13037 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13038 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13039
426994c3 13040 * terminal.c (store_terminal_param): Now static.
5489860b 13041
032f1620 13042 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13043 (set_frame_menubar): Remove unused local.
d4323972 13044 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13045 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13046 since they might point to immutable storage.
281585b0
PE
13047 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13048 since it's unused otherwise.
032f1620 13049
367c19e5 13050 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13051 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13052 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13053 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13054 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13055 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13056 does not deduce are never used uninitialized.
70739cbe 13057
07b48fa9
PE
13058 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13059
8868a238 13060 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13061 * window.c (window_loop, size_window):
13062 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13063
7e5cf297 13064 * window.c (display_buffer): Now static.
d6550a9f
PE
13065 (size_window): Mark variables that gcc -Wuninitialized
13066 does not deduce are never used uninitialized.
a586633d
PE
13067 * window.h (check_all_windows): New decl, to forestall
13068 gcc -Wmissing-prototypes diagnostic.
5b555da1 13069 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13070
f6095868
PE
13071 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13072 shadowing.
13073 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13074 Include <limits.h>.
13075 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13076 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13077 (load_charset_map): Mark variables that gcc -Wuninitialized
13078 does not deduce are never used uninitialized.
53df7c11 13079 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13080
f38b440c
PE
13081 * coding.c (coding_set_source, coding_set_destination):
13082 Use "else { /* comment */ }" rather than "else /* comment */;"
13083 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13084 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13085 a block, when the outer 'i' will do.
13086 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13087 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13088 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13089 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13090 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13091 Rename locals to avoid shadowing.
13092 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13093 * coding.c (emacs_mule_char, encode_invocation_designation):
13094 Now static, since they're not used elsewhere.
413bb2db 13095 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13096 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13097 (decode_coding_emacs_mule): Mark variables that gcc
13098 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13099 (detect_coding_iso_2022): Initialize a local variable that might
13100 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13101 this initialization is needed. (Bug#8211)
5f58e762
PE
13102 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13103 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13104 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13105 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13106 Remove unused macros.
f38b440c 13107
232b38b9 13108 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13109 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13110 * character.c (string_count_byte8): Likewise.
232b38b9 13111
fb90da1b
PE
13112 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13113 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13114
fb93dbc2
PE
13115 * chartab.c (copy_sub_char_table): Now static, since it's not used
13116 elsewhere.
5c156ace
PE
13117 (sub_char_table_ref_and_range, char_table_ref_and_range):
13118 Rename locals to avoid shadowing.
bbcd0949 13119 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13120
7d3b3862 13121 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13122 (BIDI_BOB): Remove unused macro.
7d3b3862 13123
6be7d3da
PE
13124 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13125 deduce are never used uninitialized.
c2ed9c8b 13126 * term.c (encode_terminal_code): Likewise.
6be7d3da 13127
75f8807f 13128 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13129
50938595
PE
13130 * tparam.h: New file.
13131 * term.c, tparam.h: Include it.
13132 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13133 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13134 Move these decls to tparam.h, and make them agree with what
13135 is actually in tparam.c. The previous trick of using incompatible
13136 decls in different modules does not conform to the C standard.
13137 All callers of tparam changed to use tparam's actual API.
13138 * tparam.c (tparam1, tparam, tgoto):
13139 Use const pointers where appropriate.
13140
fbceeba2
PE
13141 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13142 * cm.h (struct cm): Likewise.
13143 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13144 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13145 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13146 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13147 (turn_on_face, init_tty): Likewise.
13148 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13149
7f3f1250
PE
13150 * term.c (term_mouse_position): Rename local to avoid shadowing.
13151
e6ca6543
PE
13152 * alloc.c (mark_ttys): Move decl from here ...
13153 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13154
c40f8d15
AS
131552011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13156
13157 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13158
cfe0661d
JB
131592011-03-09 Juanma Barranquero <lekktu@gmail.com>
13160
13161 * search.c (compile_pattern_1): Remove argument regp, unused since
13162 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13163 (compile_pattern): Don't pass it.
13164
0afb4571
J
131652011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13166
13167 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13168 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13169 for ! HAVE_GTK3.
13170 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13171
13172 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13173
13174 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13175 gdk_window_get_screen, gdk_window_get_geometry,
13176 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13177 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13178 (xg_get_pixbuf_from_pixmap): New function.
13179 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13180 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13181 Call xg_get_pixbuf_from_pixmap instead of
13182 gdk_pixbuf_get_from_drawable.
13183 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13184 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13185 (xg_check_special_colors): Use GtkStyleContext and its functions
13186 for HAVE_GTK3.
13187 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13188 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13189 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13190 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13191 Call gtk_widget_get_preferred_size.
0afb4571
J
13192 (xg_frame_resized): gdk_window_get_geometry only takes 5
13193 parameters.
44f230aa
SM
13194 (xg_win_to_widget, xg_event_is_for_menubar):
13195 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13196 (xg_set_widget_bg): New function.
13197 (delete_cb): New function.
895009e1 13198 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13199 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13200 (xg_set_background_color): Call xg_set_widget_bg.
13201 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13202 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13203 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13204 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13205 if ! HAVE_GTK3.
13206 (update_frame_tool_bar): Call gtk_widget_hide.
13207 (xg_initialize): Use GDK_KEY_g.
13208
13209 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13210 if ! HAVE_GTK3
13211 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13212
13213 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13214 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13215 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13216
1c2cc4ef
JB
132172011-03-08 Juanma Barranquero <lekktu@gmail.com>
13218
13219 * w32xfns.c (select_palette): Check success of RealizePalette against
13220 GDI_ERROR, not zero.
13221
33383987 13222See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13223
13224;; Local Variables:
13225;; coding: utf-8
aac0c6e3
MR
13226;; End:
13227
2f097256 13228 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13229
13230 This file is part of GNU Emacs.
13231
13232 GNU Emacs is free software: you can redistribute it and/or modify
13233 it under the terms of the GNU General Public License as published by
13234 the Free Software Foundation, either version 3 of the License, or
13235 (at your option) any later version.
13236
13237 GNU Emacs is distributed in the hope that it will be useful,
13238 but WITHOUT ANY WARRANTY; without even the implied warranty of
13239 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13240 GNU General Public License for more details.
13241
13242 You should have received a copy of the GNU General Public License
13243 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.