* url-future.el: Add general futures facility.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
333d54da 12011-05-31 Paul Eggert <eggert@cs.ucla.edu>
55d4c1b2
PE
2
3 Use 'inline', not 'INLINE'.
333d54da 4 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5 * alloc.c, fontset.c (INLINE): Remove.
6 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11
738db178
DN
122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13
14 Make it possible to run ./temacs.
15
16 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
17 syms_of_callproc does the same thing. Remove test for
18 "initialized", do it in the caller.
19 * emacs.c (main): Avoid calling set_initial_environment when dumping.
20
620c53a6
SM
212011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
22
23 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
24 (read_minibuf): Use get_minibuffer.
25 (syms_of_minibuf): Use DEFSYM.
26 (Qmetadata): New var.
27 * data.c (Qbuffer): Don't make it static.
28 (syms_of_data): Use DEFSYM.
29
e003a292
PE
302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
31
32 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
33 (CCL_CODE_MIN): New macro.
34
ed008a6d
PE
352011-05-30 Paul Eggert <eggert@cs.ucla.edu>
36
3687c2ef
PE
37 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
38
ed008a6d
PE
39 * eval.c (Qdebug): Now static.
40 * lisp.h (Qdebug): Remove decl. This reverts a part of the
41 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
42 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
43
d66c4c7c
CY
442011-05-29 Chong Yidong <cyd@stupidchicken.com>
45
46 * image.c: Various fixes to ImageMagick code comments.
47 (Fimagemagick_types): Doc fix.
48
5fbc2025
PE
492011-05-29 Paul Eggert <eggert@cs.ucla.edu>
50
0196f88a
PE
51 Minor fixes prompted by GCC 4.6.0 warnings.
52
53 * xselect.c (converted_selections, conversion_fail_tag): Now static.
54
5fbc2025
PE
55 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
56 (x_clipboard_manager_save_all): Move extern decl to ...
57 * xterm.h: ... here, so that it can be checked for consistency.
58
1dd3c2d9
CY
592011-05-29 Chong Yidong <cyd@stupidchicken.com>
60
61 * xselect.c (x_clipboard_manager_save_frame)
62 (x_clipboard_manager_save_all): New functions.
63 (Fx_clipboard_manager_save): Lisp function deleted.
64
65 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
66 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
67
68 * xterm.h: Update prototype.
69
5ba6571d
WX
702011-05-28 William Xu <william.xwl@gmail.com>
71
72 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
73 exiting (Bug#8239).
74
3eaff834
JM
752011-05-28 Jim Meyering <meyering@redhat.com>
76
e1900994 77 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
78 * fns.c (to_uchar): Define.
79 (crypto_hash_function): Use it to convert some newly-signed
80 variables to unsigned, to avoid sign-extension bugs. For example,
81 without this change, (md5 "truc") would evaluate to
82 45723a2aff78ff4fff7fff1114760e62 rather than the expected
83 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 84 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 85
0f6990a7
PE
862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
87
88 Integer overflow fixes.
c8a9ca5a 89
08686060
PE
90 * dbusbind.c: Serial number integer overflow fixes.
91 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
92 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
93 to hold a serial number that is too large for a fixnum.
94 (Fdbus_method_return_internal, Fdbus_method_error_internal):
95 Check for serial numbers out of range. Decode any serial number
59568bf0 96 that was so large that it became a float. (Bug#8722)
08686060 97
2d1fc3c7
PE
98 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
99 (Fdbus_call_method, Fdbus_call_method_asynchronously):
100 Use XFASTINT rather than XUINT when numbers are nonnegative.
101 (xd_append_arg, Fdbus_method_return_internal):
102 (Fdbus_method_error_internal): Likewise. Also, for unsigned
103 arguments, check that Lisp number is nonnegative, rather than
59568bf0 104 silently wrapping negative numbers around. (Bug#8722)
30217ff0 105 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 106 (Bug#8722)
2d1fc3c7 107
c8a9ca5a
PE
108 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
109
519e1d69
PE
110 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
111
30569699
PE
112 ccl: add integer overflow checks
113 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
114 (IN_INT_RANGE): New macros.
115 (ccl_driver): Use them to check for integer overflow when
116 decoding a CCL program. Many of the new checks are whether XINT (x)
117 fits in int; it doesn't always, on 64-bit hosts. The new version
118 doesn't catch all possible integer overflows, but it's an
847044ea 119 improvement. (Bug#8719)
30569699 120
c11285dc
PE
121 * alloc.c (make_event_array): Use XINT, not XUINT.
122 There's no need for unsigned here.
123
fdccd48e
PE
124 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
125 This follows up to the 2011-05-06 change that substituted uintptr_t
126 for EMACS_INT. This case wasn't caught back then.
127
37910ab2
PE
128 Rework Fformat to avoid integer overflow issues.
129 * editfns.c: Include <float.h> unconditionally, as it's everywhere
130 now (part of C89). Include <verify.h>.
131 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
132 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
133 (Fformat): Avoid the prepass trying to compute sizes; it was only
134 approximate and thus did not catch overflow reliably. Instead, walk
135 through the format just once, formatting and computing sizes as we go,
136 checking for integer overflow at every step, and allocating a larger
137 buffer as needed. Keep track separately whether the format is
138 multibyte. Keep only the most-recently calculated precision, rather
139 than them all. Record whether each argument has been converted to
140 string. Use EMACS_INT, not int, for byte and char and arg counts.
141 Support field widths and precisions larger than INT_MAX. Avoid
142 sprintf's undefined behavior with conversion specifications such as %#d
143 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
144 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
145 formatting out-of-range floating point numbers with int
146 formats. (Bug#8668)
147
2e6578fb
PE
148 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
149
0ae6bdee
PE
150 * data.c: Avoid integer truncation in expressions involving floats.
151 * data.c: Include <intprops.h>.
152 (arith_driver): When there's an integer overflow in an expression
153 involving floating point, convert the integers to floating point
154 so that the resulting value does not suffer from catastrophic
155 integer truncation. For example, on a 64-bit host (* 4
156 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
157 Do not rely on undefined behavior after integer overflow.
158
de883a70
PE
159 merge count_size_as_multibyte, parse_str_to_multibyte
160 * character.c, character.h (count_size_as_multibyte):
161 Renamed from parse_str_to_multibyte; all uses changed.
162 Check for integer overflow.
163 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
164 since it's now a duplicate of the other. This is more of
165 a character than a buffer op, so better that it's in character.c.
166 * fns.c, print.c: Adjust to above changes.
167
2ff916cb
PE
1682011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
169
170 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
171
f1b54466
PE
1722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
173
fb1ac845
PE
174 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
175 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
176 (x_clipboard_manager_save): Now static.
177 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
178
f1b54466
PE
179 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
180 (crypto_hash_function): Now static.
181 Fix pointer signedness problems. Avoid unnecessary initializations.
182
a9f737ee
CY
1832011-05-27 Chong Yidong <cyd@stupidchicken.com>
184
185 * termhooks.h (Vselection_alist): Make it terminal-local.
186
187 * terminal.c (create_terminal): Initialize it.
188
189 * xselect.c: Support for clipboard managers.
190 (Vselection_alist): Move to termhooks.h as terminal-local var.
191 (LOCAL_SELECTION): New macro.
192 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
193 (symbol_to_x_atom): Remove gratuitous arg.
194 (x_handle_selection_request, lisp_data_to_selection_data)
195 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
196 (x_own_selection, x_get_local_selection, x_convert_selection):
197 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
198 (some_frame_on_display): Delete unused function.
199 (Fx_own_selection_internal, Fx_get_selection_internal)
200 (Fx_disown_selection_internal, Fx_selection_owner_p)
201 (Fx_selection_exists_p): New optional frame arg.
202 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
203 (x_handle_selection_clear): Don't treat other terminals with the
204 same keyboard specially. Use the terminal-local Vselection_alist.
205 (x_clear_frame_selections): Use Frun_hook_with_args.
206
207 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
208
209 * xterm.h: Add support for those atoms.
210
e067f0c1
CY
2112011-05-26 Chong Yidong <cyd@stupidchicken.com>
212
213 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
214 (converted_selections, conversion_fail_tag): New global variables.
215 (x_selection_request_lisp_error): Free the above.
216 (x_get_local_selection): Remove unnecessary code.
217 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
218 of converted selections stored in converted_selections.
219 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
220 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
221 (x_convert_selection): New function.
222 (x_handle_selection_event): Simplify.
223 (x_get_foreign_selection): Don't ignore incoming requests while
224 waiting for an answer; this will fail when we implement
225 SAVE_TARGETS, and seems unnecessary anyway.
226 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
227 (Vx_sent_selection_functions): Doc fix.
228
0f4aebc0
LL
2292011-05-26 Leo Liu <sdl.web@gmail.com>
230
231 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
232
e61124cd
YM
2332011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
234
235 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
236
237 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
238 for fringe update if it has periodic bitmap.
239 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
240 and fringe_bitmap_periodic_p.
241
242 * fringe.c (get_fringe_bitmap_data): New function.
243 (draw_fringe_bitmap_1, update_window_fringes): Use it.
244 (update_window_fringes): Record periodicity of fringe bitmap in glyph
245 row. Mark glyph row for fringe update if periodicity changed.
246
247 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
248 for fringe update unless it has periodic bitmap.
249
f16d9837
KH
2502011-05-25 Kenichi Handa <handa@m17n.org>
251
252 * xdisp.c (get_next_display_element): Set correct it->face_id for
253 a static composition.
254
e1b90ef6
LL
2552011-05-24 Leo Liu <sdl.web@gmail.com>
256
257 * deps.mk (fns.o):
258 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
259
260 * fns.c (crypto_hash_function, Fsha1): New function.
261 (Fmd5): Use crypto_hash_function.
262 (syms_of_fns): Add Ssha1.
263
7400048f
PE
2642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
265
266 * gnutls.c: Remove unused macros.
267 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
268 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
269 Remove macros that are defined and never used.
270 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
271
abb71cf4
CY
2722011-05-22 Chong Yidong <cyd@stupidchicken.com>
273
274 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
275 (Fx_get_selection_internal): Minor cleanup.
276 (Fx_own_selection_internal): Rename arguments for consistency with
277 select.el.
278
6307db39
PE
2792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
280
281 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
282
f3d4e0a4
CY
2832011-05-22 Chong Yidong <cyd@stupidchicken.com>
284
285 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
286
4d8ade89
YM
2872011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
288
289 * dispnew.c (scrolling_window): Don't exclude the case that the
290 last enabled row in the desired matrix touches the bottom boundary.
291
32078c8d
GM
2922011-05-21 Glenn Morris <rgm@gnu.org>
293
294 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
295 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
296 and add some more files.
32078c8d 297
7285dc67
EZ
2982011-05-20 Eli Zaretskii <eliz@gnu.org>
299
300 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
301 report_file_error introduced by the change from 2011-05-07.
302
89d1bd22
PE
3032011-05-20 Paul Eggert <eggert@cs.ucla.edu>
304
305 * systime.h (Time): Define only if emacs is defined.
306 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
307 where the include path doesn't have X11/X.h by default. See
308 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
309
e23640bb 3102011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
311
312 * composite.c (find_automatic_composition): Fix previous change.
313
b9704ad9
GM
3142011-05-20 Glenn Morris <rgm@gnu.org>
315
316 * lisp.mk: New file, split from Makefile.in.
317 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
318 (shortlisp): Remove.
319 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
320
4a720484
GM
3212011-05-19 Glenn Morris <rgm@gnu.org>
322
323 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
324 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
325 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
326 (lisp): Set the order to that of loadup.el.
327 (shortlisp): Make it a copy of $lisp.
328 (SOME_MACHINE_LISP): Remove.
329 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
330 Use just $shortlisp, not $SOME_MACHINE_LISP too.
331
a28d4396
KH
3322011-05-18 Kenichi Handa <handa@m17n.org>
333
334 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
335 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
336 (find_automatic_composition): Mostly rewrite for efficiency.
337
a2b1fa8e
JB
3382011-05-18 Juanma Barranquero <lekktu@gmail.com>
339
340 * makefile.w32-in: Update dependencies.
341
8e1f5610
CS
3422011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
343
344 * menu.c: Include limits.h (fixes the MS-Windows build broken by
345 revision 104625).
346
7025ee00 3472011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 348
cdfa6eab
PE
349 Fix some integer overflow issues, such as string length overflow.
350
06d6db33
PE
351 * insdel.c (count_size_as_multibyte): Check for string overflow.
352
2b4560a8
PE
353 * character.c (lisp_string_width): Check for string overflow.
354 Use EMACS_INT, not int, for string indexes and lengths; in
355 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
356 the resulting string length overflows an EMACS_INT; instead,
357 report a string overflow if no precision given. When checking for
358 precision exhaustion, use a check that cannot possibly have
359 integer overflow. (Bug#8675)
360 * character.h (lisp_string_width): Adjust to new signature.
361
cb93f9be
PE
362 * alloc.c (string_overflow): New function.
363 (Fmake_string): Use it. This doesn't change behavior, but saves
364 a few bytes and will simplify future changes.
365 * character.c (string_escape_byte8): Likewise.
366 * lisp.h (string_overflow): New decl.
367
1a1f3366
PE
368 Fixups, following up to the user-interface timestamp change.
369 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
370 for UI timestamps, instead of unsigned long.
9fbd6841
PE
371 * msdos.c (mouse_get_pos): Likewise.
372 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
373 * w32gui.h (Time): Define by including "systime.h" rather than by
374 declaring it ourselves. (Bug#8664)
375
d4e3e4d3
PE
376 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
377 * image.c (clear_image_cache): Likewise.
378
f6a24d19
PE
379 * term.c (term_mouse_position): Don't assume time_t wraparound.
380
08dc5ae6
PE
381 Be more systematic about user-interface timestamps.
382 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
383 and sometimes 'EMACS_UINT', to represent these timestamps.
384 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
385 This makes the code easier to follow, and makes it easier to catch
386 integer overflow bugs such as Bug#8664.
387 * frame.c (Fmouse_position, Fmouse_pixel_position):
388 Use Time, not unsigned long, for user-interface timestamps.
389 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
390 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
391 * keyboard.h (last_event_timestamp): Likewise.
392 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
393 * menu.h (xmenu_show): Likewise.
394 * term.c (term_mouse_position): Likewise.
395 * termhooks.h (struct input_event.timestamp): Likewise.
396 (struct terminal.mouse_position_hook): Likewise.
397 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
398 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
399 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
400 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
401 what it was before.
402 * menu.h, termhooks.h: Include "systime.h", for Time.
403
8e55734a
PE
404 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
405 Don't assume that the difference between two unsigned long values
406 can fit into an integer. At this point, we know button_down_time
407 <= event->timestamp, so the difference must be nonnegative, so
408 there's no need to cast the result if double-click-time is
409 nonnegative, as it should be; check that it's nonnegative, just in
410 case. This bug is triggered when events are more than 2**31 ms
86db42d2 411 apart (about 25 days). (Bug#8664)
8e55734a 412
841f1b75 413 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 414 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 415
3e26f69c
PE
416 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
417 that always fit in int. Use a sentinel instead of a counter, to
418 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
419 * frame.h (struct frame): Use int for menu_bar_items_used
420 instead of EMACS_INT, since it always fits in int.
3e26f69c 421
5cc152c0
PE
422 * menu.c (grow_menu_items): Check for int overflow.
423
d89eb65e
PE
424 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
425
5235bd3e
PE
426 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
427 Before, the code was not consistent. These values cannot exceed
428 2**31 - 1 so there's no need to make them unsigned.
429 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
430 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
431 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
432 as modifiers.
433 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
434
bc827e23
PE
435 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
436 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
437 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
438 presumably because the widths might not match.
439
78eb494e
PE
440 * window.c (size_window): Avoid needless test at loop start.
441
04f2d78b
CB
4422011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
443
444 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
445
d2fc7e3d 4462011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
447
448 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
449
d2fc7e3d 4502011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
451
452 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
453 `width' to `bar_area_x' and `bar_area_width', respectively.
454 (x_scroll_run): Take account of fringe background extension.
455
04f2d78b
CB
456 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
457 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
458 `bar_area_width', respectively.
459 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
460 background extension.
461
79b70037
GM
4622011-05-10 Jim Meyering <meyering@redhat.com>
463
464 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
465
2f142cc5
JB
4662011-05-10 Juanma Barranquero <lekktu@gmail.com>
467
468 * image.c (Finit_image_library): Return t for built-in image types,
469 like pbm and xbm. (Bug#8640)
470
57679c86
AS
4712011-05-09 Andreas Schwab <schwab@linux-m68k.org>
472
473 * w32menu.c (set_frame_menubar): Fix submenu allocation.
474
888c9e86
EZ
4752011-05-07 Eli Zaretskii <eliz@gnu.org>
476
b0512a1d
EZ
477 * w32console.c (Fset_screen_color): Doc fix.
478 (Fget_screen_color): New function.
479 (syms_of_ntterm): Defsubr it.
480
7285dc67
EZ
481 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
482 unlink the temporary file if Fcall_process didn't create it in the
483 first place.
484 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
485 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
486 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
487 cue to call_process_cleanup not to close that handle.
488
4d3fcc8e
BK
4892011-05-07 Ben Key <bkey76@gmail.com>
490
491 * makefile.w32-in: The bootstrap-temacs rule now makes use of
492 one of two shell specific rules, either bootstrap-temacs-CMD or
493 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
494 to the previous implementation of the bootstrap-temacs rule.
495 The bootstrap-temacs-CMD rule is similar to the previous
496 implementation of the bootstrap-temacs rule except that it
497 makes use of the ESC_CFLAGS variable instead of the CFLAGS
498 variable.
499
500 These changes, along with some changes to nt/configure.bat,
501 nt/gmake.defs, and nt/nmake.defs, are required to extend my
502 earlier fix to add support for --cflags and --ldflags options
503 that include quotes so that it works whether make uses cmd or
504 sh as the shell.
505
b4289b64
MA
5062011-05-06 Michael Albinus <michael.albinus@gmx.de>
507
508 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
509 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
510 is a constant.
511 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
512 a string. Handle both cases.
513 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
514 (Fdbus_register_method): Use Qinvalid_function.
515
af4c0e28
JB
5162011-05-06 Juanma Barranquero <lekktu@gmail.com>
517
518 * makefile.w32-in: Update dependencies.
519 (LISP_H): Add inttypes.h and stdin.h.
520 (PROCESS_H): Add unistd.h.
521
c51453d9
EZ
5222011-05-06 Eli Zaretskii <eliz@gnu.org>
523
524 * lread.c: Include limits.h (fixes the MS-Windows build broken by
525 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
526
8ff0ac3c 5272011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 528
4c4b566b
PE
529 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
530
aab2b9b5
PE
531 * term.c (vfatal): Remove stray call to va_end.
532 It's not needed and the C Standard doesn't allow it here anyway.
533
c378da0b
PE
534 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
535 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
536
288b08c7
PE
537 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
538 bytes.
539
e3601888
PE
540 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
541
db6c0e74
PE
542 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
543
dd5963ea
PE
544 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
545
88c9450f
PE
546 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
547
2f9442b8
PE
548 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
549
c032b5f8
PE
550 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
551 * charset.c (Fdefine_charset_internal): Don't initialize
552 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 553 32-bit int (Bug#8600).
a108c10b
PE
554
555 * lread.c (read_integer): Be more consistent with string-to-number.
556 Use string_to_number to do the actual conversion; this avoids
557 rounding errors and fixes some other screwups. Without this fix,
558 for example, #x1fffffffffffffff was misread as -2305843009213693952.
559 (digit_to_number): Move earlier, for benefit of read_integer.
560 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 561 not a digit in any supported base. (Bug#8602)
a108c10b 562
ad5f9eea
PE
563 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
564
aec1708a
PE
565 * dispnew.c (scrolling_window): Return 1 if we scrolled,
566 to match comment at start of function. This also removes a
567 GCC warning about overflow in a 32+64-bit port.
568
47be4ab5
PE
569 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
570
371cac43
PE
571 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
572 Reported by Stefan Monnier in
573 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
574 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
575 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 576
d01a7826
PE
577 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
578 (EMACS_UINTPTR): Likewise, with uintptr_t.
579
7fd47d5c
PE
580 * lisp.h: Prefer 64-bit EMACS_INT if available.
581 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
582 on 32-bit hosts that have 64-bit int, so that they can access
583 large files.
122b0c86
PE
584 However, temporarily disable this change unless the temporary
585 symbol WIDE_EMACS_INT is defined.
7fd47d5c 586
8727937b
PE
587 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
588
8ac068ac
PE
589 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
590 This removes an assumption that EMACS_INT and long are the same
591 width as pointers. The assumption is true for Emacs porting targets
592 now, but we want to make other targets possible.
593 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
594 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
595 In the rest of the code, change types of integers that hold casted
596 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
597 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
598 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
599 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
600 No need to cast type when ORing.
601 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
602 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
603 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
604 assume EMACS_INT is the same width as char *.
605 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
606 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
607 Remove no-longer-needed casts.
608 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
609 (xg_tool_bar_help_callback, xg_make_tool_item):
610 Use EMACS_INTPTR to hold an integer
611 that will be cast to void *; this can avoid a GCC warning
612 if EMACS_INT is not the same width as void *.
613 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
614 * xdisp.c (display_echo_area_1, resize_mini_window_1):
615 (current_message_1, set_message_1):
616 Use a local to convert to proper width without a cast.
617 * xmenu.c (dialog_selection_callback): Likewise.
618
ede49d71
PE
619 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
620 Also, don't assume VALBITS / RAND_BITS is less than 5,
621 and don't rely on undefined behavior when shifting a 1 left into
622 the sign bit.
623 * lisp.h (get_random): Change signature to match.
624
2f30ecd0
PE
625 * lread.c (hash_string): Use size_t, not int, for hash computation.
626 Normally we prefer signed values; but hashing is special, because
627 it's better to use unsigned division on hash table sizes so that
628 the remainder is nonnegative. Also, size_t is the natural width
629 for hashing into memory. The previous code used 'int', which doesn't
630 retain enough info to hash well into very large tables.
631 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
632
2a866e7b
PE
633 * dbusbind.c: Don't possibly lose pointer info when converting.
634 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
635 Use XPNTR rather than XHASH, so that the high-order bits of
636 the pointer aren't lost when converting through void *.
637
51639eac
PE
638 * eval.c (Fautoload): Don't double-shift a pointer.
639
92394119
PE
640 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
641
dbdb9a7c
JB
6422011-05-06 Juanma Barranquero <lekktu@gmail.com>
643
644 * gnutls.c (DEF_GNUTLS_FN):
645 * image.c (DEF_IMGLIB_FN): Make function pointers static.
646
db7a0b4f
AS
6472011-05-05 Andreas Schwab <schwab@linux-m68k.org>
648
649 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
650 marker. (Bug#8610)
651
f7ff1b0f 6522011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
653
654 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
655 New version that can reserve upto 2GB of heap space.
656
f7ff1b0f 6572011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
658
659 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
660
639c109b
TZ
6612011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
662
663 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
664 `gnutls_certificate_set_x509_key_file'.
665
d2127135
JB
6662011-05-05 Juanma Barranquero <lekktu@gmail.com>
667
668 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
669 Update dependencies.
670
e968f4f3
JB
6712011-05-04 Juanma Barranquero <lekktu@gmail.com>
672
673 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
674 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
675 Remove unused parameter `fildes'.
676 * process.c (read_process_output, send_process): Don't pass it.
677
84d358f0
JB
6782011-05-04 Juanma Barranquero <lekktu@gmail.com>
679
680 Fix previous change: the library cache is defined in w32.c.
681 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
682 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
683
0898ca10
JB
6842011-05-04 Juanma Barranquero <lekktu@gmail.com>
685
686 Implement dynamic loading of GnuTLS on Windows.
687
688 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
689 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
690 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
691 Declare.
692
693 * gnutls.c (Qgnutls_dll): Define.
694 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
695 (gnutls_*): Declare function pointers.
696 (init_gnutls_functions): New function to initialize function pointers.
697 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
698 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
699 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
700 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
701 (emacs_gnutls_write, emacs_gnutls_read)
702 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
703 (Fgnutls_available_p): New function.
704 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
705 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
706 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
707
708 * image.c: Include w32.h.
709 (Vimage_type_cache): Delete.
710 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
711 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
712 (w32_delayed_load): Move to w32.c.
713
714 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
715
716 * w32.c (QCloaded_from, Vlibrary_cache): Define.
717 (w32_delayed_load): Move from image.c. When loading a library, record
718 its filename in the :loaded-from property of the library id.
719 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
720 Initialize and staticpro them.
721 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
722
723 * process.c: Include lisp.h before w32.h, not after.
724 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
725 instead of gnutls_record_check_pending.
726
727 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
728
ff4de4aa
TZ
7292011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
730
731 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
732 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
733 as passed in.
734
abe95abb
JD
7352011-05-03 Jan Djärv <jan.h.d@swipnet.se>
736
737 * xterm.c (x_set_frame_alpha): Do not set property on anything
738 else than FRAME_X_OUTER_WINDOW (Bug#8608).
739
e16e55d4
JB
7402011-05-02 Juanma Barranquero <lekktu@gmail.com>
741
742 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
743
bafcf6a5
JB
7442011-05-02 Juanma Barranquero <lekktu@gmail.com>
745
746 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
747 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
748 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
749 (gnutls_global_initialized, Qgnutls_bootprop_priority)
750 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
751 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
752 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
753 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
754 (Qgnutls_bootprop_callbacks_verify): Make static.
755
e7a6747f
AS
7562011-05-01 Andreas Schwab <schwab@linux-m68k.org>
757
19ed11ba
AS
758 * callproc.c: Indentation fixup.
759
e7a6747f 760 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
761 (wait_for_termination, interruptible_wait_for_termination):
762 Move after wait_for_termination_1.
e7a6747f 763
1ef14cb4
LMI
7642011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
765
766 * sysdep.c (interruptible_wait_for_termination): New function
767 which is like wait_for_termination, but allows keyboard
768 interruptions.
769
770 * callproc.c (Fcall_process): Add (:file "file") as an option for
771 the STDOUT buffer.
772 (Fcall_process_region): Ditto.
773
330d880c
EZ
7742011-04-30 Eli Zaretskii <eliz@gnu.org>
775
8db90b73
EZ
776 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
777 rather than `XVECTOR (FOO)->size'.
778
330d880c
EZ
779 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
780 inttypes.h, as a gnulib replacement is used if it not available in
781 system headers.
782
15cbd324
EZ
7832011-04-21 Eli Zaretskii <eliz@gnu.org>
784
785 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
786 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
787 of MOST_POSITIVE_FIXNUM. (Bug#8528)
788
789 * coding.c (coding_alloc_by_realloc): Error out if destination
790 will grow beyond MOST_POSITIVE_FIXNUM.
791 (decode_coding_emacs_mule): Abort if there isn't enough place in
792 charbuf for the composition carryover bytes. Reserve an extra
793 space for up to 2 characters produced in a loop.
794 (decode_coding_iso_2022): Abort if there isn't enough place in
795 charbuf for the composition carryover bytes.
796
7972011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 798
ae940cca
EZ
799 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
800 aborting when %lld or %lll format is passed.
801 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
802 %llo or %llx format is passed. (Bug#8545)
803
03ab8921
EZ
804 * window.c (window_scroll_line_based): Use a marker instead of
805 simple variables to record original value of point. (Bug#7952)
806
afda1437
EZ
807 * doprnt.c (doprnt): Fix the case where a multibyte sequence
808 produced by %s or %c overflows available buffer space. (Bug#8545)
809
f76dee0c
PE
8102011-04-28 Paul Eggert <eggert@cs.ucla.edu>
811
812 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 813 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 814
fdc5744d
JB
8152011-04-28 Juanma Barranquero <lekktu@gmail.com>
816
817 * w32.c (init_environment): Warn about defaulting HOME to C:\.
818
638f053a
JB
8192011-04-28 Juanma Barranquero <lekktu@gmail.com>
820
821 * keyboard.c (Qdelayed_warnings_hook): Define.
822 (command_loop_1): Run `delayed-warnings-hook'
823 if Vdelayed_warnings_list is non-nil.
824 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
825 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
826
d178f871
EZ
8272011-04-28 Eli Zaretskii <eliz@gnu.org>
828
829 * doprnt.c (doprnt): Don't return value smaller than the buffer
830 size if the message was truncated. (Bug#8545).
831
b124fd93
JB
8322011-04-28 Juanma Barranquero <lekktu@gmail.com>
833
834 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
835 (Fx_window_property): #if-0 the whole functions, not just the bodies.
836
e810457d
PE
8372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
838
839 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
840
ea51cceb
JB
8412011-04-27 Juanma Barranquero <lekktu@gmail.com>
842
843 * makefile.w32-in: Update dependencies.
844
94dcfacf
EZ
8452011-04-27 Eli Zaretskii <eliz@gnu.org>
846
847 Improve `doprnt' and its usage. (Bug#8545)
848 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
849 `format_end'. Remove support for %l as a conversion specifier.
850 Don't use xrealloc. Improve diagnostics when the %l size modifier
851 is used. Update the commentary.
852
853 * eval.c (verror): Simplify calculation of size_t.
854
855 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
856 messages.
857
f61f41d7
PE
8582011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
859
860 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
861 change.
862
96fb4434
PE
8632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
864
865 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
866 This makes this file independent of the recent pseudovector change.
867
671875da 8682011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 869
69e9b5a3
PE
870 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
871
b5f869a7 872 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 873 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 874 Remove unused local.
c8926152 875 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 876
841a1577 877 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
878 GCC 4.6.0 optimizes based on type-based alias analysis.
879 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
880 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
881 != &v->size, and therefore "v->size = 1; b->size = 2; return
882 v->size;" must therefore return 1. This assumption is incorrect
883 for Emacs, since it type-puns struct Lisp_Vector * with many other
884 types. To fix this problem, this patch adds a new type struct
f904488f 885 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
886 and pseudovectors, and helps optimizing compilers not get fooled
887 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
888 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
889 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
890 the size member.
eab3844f
PE
891 (XSETPVECTYPE): Rewrite in terms of new macro.
892 (XSETPVECTYPESIZE): New macro, specifying both type and size.
893 This is a bit clearer, and further avoids the possibility of
894 undesirable aliasing.
895 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 896 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
897 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
898 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
899 (ASIZE): Now uses header.size rather than size.
900 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
901 to avoid the hassle of writing XVECTOR (foo)->header.size.
902 (struct vectorlike_header): New type.
eab3844f
PE
903 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
904 object, to help avoid aliasing.
905 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
906 (SUBRP): Likewise, since Lisp_Subr is a special case.
907 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
908 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
909 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 910 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
911 changed to be "header.size" and "header.next".
912 * buffer.h (struct buffer): Likewise.
913 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
914 * frame.h (struct frame): Likewise.
915 * process.h (struct Lisp_Process): Likewise.
916 * termhooks.h (struct terminal): Likewise.
917 * window.c (struct save_window_data, struct saved_window): Likewise.
918 * window.h (struct window): Likewise.
919 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
920 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
921 * buffer.c (init_buffer_once): Likewise.
922 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
923 special case.
924 * process.c (Fformat_network_address): Use local var for size,
925 for brevity.
926
0df1eac5
PE
927 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
928
847ab9d1 929 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
930 * data.c (atof): Remove decl; no longer used or needed.
931 (digit_to_number): Move to lread.c.
932 (Fstring_to_number): Use new string_to_number function, to be
933 consistent with how the Lisp reader treats infinities and NaNs.
934 Do not assume that floating-point numbers represent EMACS_INT
935 without losing information; this is not true on most 64-bit hosts.
936 Avoid double-rounding errors, by insisting on integers when
937 parsing non-base-10 numbers, as the documentation specifies.
938 * lisp.h (string_to_number): New decl, replacing ...
939 (isfloat_string): Remove.
bc0a5c13 940 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 941 (read1): Do not accept +. and -. as integers; this
452f4150
PE
942 appears to have been a coding error. Similarly, do not accept
943 strings like +-1e0 as floating point numbers. Do not report
944 overflow for integer overflows unless the base is not 10 which
945 means we have no simple and reliable way to continue.
946 Break out the floating-point parsing into a new
947 function string_to_number, so that Fstring_to_number parses
948 floating point numbers consistently with the Lisp reader.
04f2d78b 949 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
950 (E_CHAR, EXP_INT): Remove, replacing with ...
951 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
952 (string_to_number): New function, replacing isfloat_string.
953 This function checks for valid syntax and produces the resulting
954 Lisp float number too. Rework it so that string-to-number
bc0a5c13 955 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
956 so that overflow for non-base-10 numbers is reported only when
957 there's no portable and simple way to convert to floating point.
452f4150 958
67769ffc
PE
959 * textprop.c (set_text_properties_1): Rewrite for clarity,
960 and to avoid GCC warning about integer overflow.
961
c20db43f
PE
962 * intervals.h (struct interval): Use EMACS_INT for members
963 where EMACS_UINT might cause problems. See
964 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
965 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
966 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
967 All uses changed.
37aa2f85
PE
968 (offset_intervals): Tell GCC not to worry about length overflow
969 when negating a negative length.
c20db43f 970
2538aa2f
PE
971 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
972 (overrun_check_free): Likewise.
973
f2d3008d
PE
974 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
975 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
976 word size.
977
ec8df744
PE
978 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
979 (gnutls_make_error): Rename local to avoid shadowing.
980 (gnutls_emacs_global_deinit): ifdef out; not used.
981 (Fgnutls_boot): Use const for pointer to readonly storage.
982 Comment out unused local. Fix pointer signedness problems.
983
640ee02d
PE
984 * lread.c (openp): Don't stuff size_t into an 'int'.
985 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
986 about possible signed overflow.
987
6048fb2a
PE
988 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
989 (GDK_KEY_g): Don't define if already defined.
990 (xg_prepare_tooltip): Avoid pointer signedness problem.
991 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
992
fa3c87e1
PE
993 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
994 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
995
2172544b
PE
996 * xfns.c (Fx_window_property): Simplify a bit,
997 to make a bit faster and to avoid GCC 4.6.0 warning.
998 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
999
9b821a21
PE
1000 * fns.c (internal_equal): Don't assume size_t fits in int.
1001
3c616cfa
PE
1002 * alloc.c (compact_small_strings): Tighten assertion a little.
1003
c2982e87
PE
1004 Replace pEd with more-general pI, and fix some printf arg casts.
1005 * lisp.h (pI): New macro, generalizing old pEd macro to other
1006 conversion specifiers. For example, use "...%"pI"d..." rather
1007 than "...%"pEd"...".
1008 (pEd): Remove. All uses replaced with similar uses of pI.
1009 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1010 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1011 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1012 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1013 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1014 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1015 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1016 64-bit hosts.
1017 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1018 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1019 * print.c (safe_debug_print, print_object): Likewise.
1020 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1021 to int.
6f04d126
PE
1022 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1023 avoiding the 0 flag, which is not portable.
c2982e87
PE
1024 * process.c (Fmake_network_process): Use pI to avoid cast.
1025 * region-cache.c (pp_cache): Likewise.
1026 * xdisp.c (decode_mode_spec): Likewise.
1027 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1028 behavior on 64-bit hosts with printf arg.
6f04d126 1029 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1030 (x_stop_queuing_selection_requests): Likewise.
1031 (x_get_window_property): Don't truncate byte count to an 'int'
1032 when tracing.
0b432f21 1033
5e073ec7
PE
1034 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1035 here, since it parses constructs like leading '-' and spaces,
1036 which are not wanted; and it overflows with large numbers.
1037 Instead, simply match F[0-9]+, which is what is wanted anyway.
1038
36372bf9
PE
1039 * alloc.c: Remove unportable assumptions about struct layout.
1040 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1041 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1042 (allocate_vectorlike, make_pure_vector): Use the new macros,
1043 plus offsetof, to remove unportable assumptions about struct layout.
1044 These assumptions hold on all porting targets that I know of, but
1045 they are not guaranteed, they're easy to remove, and removing them
1046 makes further changes easier.
1047
0b432f21
PE
1048 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1049 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1050 (string_overrun_cookie): Now const. Use initializers that
1051 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1052 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1053 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1054 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1055 multiple of sizeof (EMACS_INT); it need not be, if
1056 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1057 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1058
895009e1
JB
10592011-04-26 Juanma Barranquero <lekktu@gmail.com>
1060
1061 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1062
6a7a1b0b
TZ
10632011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1064
1065 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1066 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1067 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1068
841a1577 10692011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1070
1071 * lisp.h (Qdebug): List symbol.
895009e1 1072 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1073 * keyboard.c (debug-on-event): New variable.
1074 (handle_user_signal): Break into debugger when debug-on-event
1075 matches the current signal symbol.
1076
f2d3ba6f
DN
10772011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1078
1079 * alloc.c (check_sblock, check_string_bytes)
1080 (check_string_free_list): Convert to standard C.
1081
42ce4c63
TZ
10822011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1083
1084 * w32.c (emacs_gnutls_push): Fix typo.
1085
825cd63c
EZ
10862011-04-25 Eli Zaretskii <eliz@gnu.org>
1087
fb11d64d
EZ
1088 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1089 "cast to pointer from integer of different size".
1090
825cd63c
EZ
1091 Improve doprnt and its use in verror. (Bug#8545)
1092 * doprnt.c (doprnt): Document the set of format control sequences
1093 supported by the function. Use SAFE_ALLOCA instead of always
1094 using `alloca'.
1095
1096 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1097 is one byte too soon. Don't use xrealloc; instead xfree and
1098 xmalloc anew.
1099
e061a11b
TZ
11002011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1101
1102 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1103 callbacks stage.
1104
1105 * gnutls.c: Renamed global_initialized to
1106 gnutls_global_initialized. Added internals for the
1107 :verify-hostname-error, :verify-error, and :verify-flags
1108 parameters of `gnutls-boot' and documented those parameters in the
1109 docstring. Start callback support.
1110 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1111 unless a fatal error occured. Call gnutls_alert_send_appropriate
1112 on error. Return error code.
1113 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1114 (emacs_gnutls_read): Likewise.
1115 (Fgnutls_boot): Return handshake error code.
1116 (emacs_gnutls_handle_error): New function.
1117 (wsaerror_to_errno): Likewise.
1118
1119 * w32.h (emacs_gnutls_pull): Add prototype.
1120 (emacs_gnutls_push): Likewise.
1121
1122 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1123 (emacs_gnutls_push): Likewise.
1124
11252011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1126
1127 * process.c (wait_reading_process_output): Check if GnuTLS
1128 buffered some data internally if no FDs are set for TLS
1129 connections.
1130
1131 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1132 (LIBS): Link to USER_LIBS.
1133 ($(BLD)/gnutls.$(0)): New target.
1134
fa6996bc
EZ
11352011-04-24 Eli Zaretskii <eliz@gnu.org>
1136
eb35682e
EZ
1137 * xdisp.c (handle_single_display_spec): Rename the
1138 display_replaced_before_p argument into display_replaced_p, to
1139 make it consistent with the commentary. Fix typos in the
1140 commentary.
1141
e2ad650c
EZ
1142 * textprop.c (syms_of_textprop): Remove dead code.
1143 (copy_text_properties): Delete obsolete commentary about an
1144 interface that was deleted long ago. Fix typos in the description
1145 of arguments.
1146
1b2de274
EZ
1147 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1148 to changes in oldXMenu/XMenu.h from 2011-04-16.
1149 <menu_help_message, prev_menu_help_message>: Constify.
1150 (IT_menu_make_room): menu->help_text is now `const char **';
1151 adjust.
1152
1153 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1154 to changes in oldXMenu/XMenu.h from 2011-04-16.
1155 (struct XMenu): Declare `help_text' `const char **'.
1156
1157 * xfaces.c <Qunspecified>: Make extern again.
1158
1159 * syntax.c: Include sys/types.h before including regex.h, as
1160 required by Posix.
1161
762b15be
EZ
1162 * doc.c (get_doc_string): Improve the format passed to `error'.
1163
1164 * doprnt.c (doprnt): Improve commentary.
1165
1166 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1167
1168 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1169 them with etags.
1170
f1052e5d
EZ
1171 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1172 changes in globals.h immediately force recompilation.
762b15be
EZ
1173 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1174 $(CURDIR)/s/ms-w32.h.
1175 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1176
fa6996bc
EZ
1177 * character.c (Fchar_direction): Function deleted.
1178 (syms_of_character): Don't defsubr it.
1179 <char-direction-table>: Deleted.
1180
e6c3da20
EZ
11812011-04-23 Eli Zaretskii <eliz@gnu.org>
1182
1183 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1184 * doprnt.c: Include limits.h.
1185 (SIZE_MAX): New macro.
04f2d78b
CB
1186 (doprnt): Return a size_t value. 2nd arg is now size_t.
1187 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1188 Improve overflow protection. Support `l' modifier for integer
1189 conversions. Support %l conversion. Don't assume an EMACS_INT
1190 argument for integer conversions and for %c.
1191
1192 * lisp.h (doprnt): Restore prototype.
1193
1194 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1195 $(SRC)/character.h.
1196
1197 * Makefile.in (base_obj): Add back doprnt.o.
1198
1199 * deps.mk (doprnt.o): Add back prerequisites.
1200 (callint.o): Depend on character.h.
1201
1202 * eval.c (internal_lisp_condition_case): Include the handler
1203 representation in the error message.
1204 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1205 when breaking from the loop.
1206
1207 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1208
1209 * callint.c (Fcall_interactively): When displaying error message
1210 about invalid control letter, pass the character's codepoint, not
1211 a pointer to its multibyte form. Improve display of the character
1212 in octal and display also its hex code.
1213
1214 * character.c (char_string): Use %x to display the (unsigned)
1215 codepoint of an invalid character, to avoid displaying a bogus
1216 negative value.
1217
1218 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1219 `error', not SYMBOL_NAME itself.
1220
1221 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1222 character arguments to `error'.
1223
1224 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1225 to `error' in error message about FINAL_CHAR argument. Make sure
1226 FINAL_CHAR is a character, and use %c when it is passed as
1227 argument to `error'.
1228
4ffd0d6b 12292011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1230
1231 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1232
1233 * w32.c: Include <time.h>.
1234 (sys_localtime): New function.
1235
4ffd0d6b 12362011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1237
1238 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1239
4ffd0d6b 1240 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1241
4ffd0d6b 12422011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1243
4ffd0d6b
GM
1244 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1245 zombies (Bug#8467).
aac0c6e3 1246
04c56954
EZ
12472011-04-19 Eli Zaretskii <eliz@gnu.org>
1248
1249 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1250 gl_state.e_property when gl_state.object is Qt.
1251
1252 * insdel.c (make_gap_larger): Remove limitation of buffer size
1253 to <= INT_MAX.
1254
16a43933
CY
12552011-04-18 Chong Yidong <cyd@stupidchicken.com>
1256
1257 * xdisp.c (lookup_glyphless_char_display)
1258 (produce_glyphless_glyph): Handle cons cell entry in
1259 glyphless-char-display.
1260 (Vglyphless_char_display): Document it.
1261
1262 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1263 glyphless-char-display.
1264
4581706e
CY
12652011-04-17 Chong Yidong <cyd@stupidchicken.com>
1266
1267 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1268
1269 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1270
1271 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1272 definition for no-X builds.
1273
4887c6e2 12742011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1275
fd35b6f9
PE
1276 Static checks with GCC 4.6.0 and non-default toolkits.
1277
5c1ccb01
PE
1278 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1279
006c5daa
PE
1280 * process.c (keyboard_bit_set): Define only if SIGIO.
1281 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1282 (send_process): Repair possible setjmp clobbering.
1283
efc736d3
PE
1284 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1285
4e2fe2e6
PE
1286 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1287
f97334a2
PE
1288 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1289
4e75f29d
PE
1290 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1291 Define only if needed.
1292
90efadd1
PE
1293 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1294 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1295 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1296
3c647824
PE
1297 * dispextern.h (struct redisplay_interface): Rename param
1298 to avoid shadowing.
e264f262 1299 * termhooks.h (struct terminal): Likewise.
761383f4 1300 * xterm.c (xembed_send_message): Likewise.
3c647824 1301
b58c5c4a
PE
1302 * insdel.c (make_gap_smaller): Define only if
1303 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1304
cad59032
PE
1305 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1306 it.
1307
c339dc2e
PE
1308 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1309 so that we aren't warned about unused symbols.
1310
91a3e27b
PE
1311 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1312
399c71d3 1313 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1314
8ffc96f5
PE
1315 * xfns.c (x_real_positions): Mark locals as initialized.
1316
eef9bc79
PE
1317 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1318
098db9dd
PE
1319 * xterm.c: Fix problems found by static analysis with other toolkits.
1320 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1321 (x_dispatch_event): Declare static if USE_GTK, and
1322 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1323 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1324 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1325 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1326 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1327
eb18f6cc
PE
1328 * xmenu.c (menu_help_callback): Pointer type fixes.
1329 Use const pointers when pointing at readonly data. Avoid pointer
1330 signedness clashes.
1331 (FALSE): Remove unused macro.
1332 (update_frame_menubar): Remove unused decl.
1333
1fe72bf8
PE
1334 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1335
60d9e1db
PE
1336 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1337 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1338 (single_menu_item): Rename local to avoid shadowing.
1339
39261c26
PE
1340 * keyboard.c (make_lispy_event): Remove unused local var.
1341
018c5e19
PE
1342 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1343 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1344
63d2b86e
PE
1345 * bitmaps: Change bitmaps from unsigned char back to the X11
1346 compatible char. Avoid the old compiler warnings about
1347 out-of-range initializers by using, for example, '\xab' rather
1348 than 0xab.
1349
aefd87e1
PE
1350 * xgselect.c (xgselect_initialize): Check vs interface
1351 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1352
bf501fb9
PE
1353 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1354
e9829fdf
PE
1355 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1356 to read-only memory.
1357
1086c095
PE
1358 * fns.c (vector): Remove; this old hack is no longer needed.
1359
2baccd04 1360 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1361 Remove unused var.
dde42981 1362 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1363
72391843 1364 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1365
436c16df 1366 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1367 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1368 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1369
92bb796d 1370 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1371 (x_term_init): Remove local to avoid shadowing.
92bb796d 1372
764430a3 1373 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1374
1375 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1376 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1377
d1dfb56c
EZ
13782011-04-16 Eli Zaretskii <eliz@gnu.org>
1379
c4354cb4
EZ
1380 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1381
d1dfb56c
EZ
1382 Fix regex.c, syntax.c and friends for buffers > 2GB.
1383 * syntax.h (struct gl_state_s): Declare character position members
1384 EMACS_INT.
1385
1386 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1387
04f2d78b
CB
1388 * textprop.c (verify_interval_modification, interval_of):
1389 Declare arguments EMACS_INT.
d1dfb56c
EZ
1390
1391 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1392 EMACS_INT.
1393
1394 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1395
1396 * indent.c (Fvertical_motion): Local variable it_start is now
1397 EMACS_INT.
1398
1399 * regex.c (re_match, re_match_2, re_match_2_internal)
1400 (bcmp_translate, regcomp, regexec, print_double_string)
1401 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1402 (re_compile_pattern, re_exec): Declare arguments and local
1403 variables `size_t' and `ssize_t' and return values `regoff_t', as
1404 appropriate.
1405 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1406 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1407 <compile_stack_type>: `size' and `avail' are now `size_t'.
1408
1409 * regex.h <regoff_t>: Use ssize_t, not int.
1410 (re_search, re_search_2, re_match, re_match_2): Arguments that
1411 specify buffer/string position and length are now ssize_t and
1412 size_t. Return type is regoff_t.
1413
613052cd
BK
14142011-04-16 Ben Key <bkey76@gmail.com>
1415
1416 * nsfont.m: Fixed bugs in ns_get_family and
1417 ns_descriptor_to_entity that were caused by using free to
1418 deallocate memory blocks that were allocated by xmalloc (via
1419 xstrdup). This caused Emacs to crash when compiled with
1420 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1421 --enable-checking=xmallocoverrun). xfree is now used to
1422 deallocate these memory blocks.
1423
4170f62f 14242011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1425
71b41406
PE
1426 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1427
9587a89d
PE
1428 emacs_write: Accept and return EMACS_INT for sizes.
1429 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1430 et seq.
1431 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1432 Accept and return EMACS_INT.
1433 (emacs_gnutls_write): Return the number of bytes written on
1434 partial writes.
1435 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1436 (emacs_read, emacs_write): Remove check for negative size, as the
1437 Emacs source code has been audited now.
9587a89d
PE
1438 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1439 (emacs_read, emacs_write): Use it.
273a5f82
PE
1440 * process.c (send_process): Adjust to the new signatures of
1441 emacs_write and emacs_gnutls_write. Do not attempt to store
1442 a byte offset into an 'int'; it might overflow.
9587a89d 1443 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1444
3e047f51
PE
1445 * sound.c: Don't assume sizes fit in 'int'.
1446 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1447 Return EMACS_INT, not int.
3e047f51 1448 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1449 Accept EMACS_INT, not int.
1450 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1451 record read return values.
1452
cc39a9db
BK
14532011-04-15 Ben Key <bkey76@gmail.com>
1454
c9d0ec6d
JB
1455 * keyboard.c (Qundefined): Don't declare static since it is used
1456 in nsfns.m.
1457 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1458 static since they are used in nsfont.m.
cc39a9db 1459
6c60eb9f
SM
14602011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1461
1462 * process.c (Qprocessp): Don't declare static.
1463 * lisp.h (Qprocessp): Declare again.
1464
7990b61a
JB
14652011-04-15 Juanma Barranquero <lekktu@gmail.com>
1466
1467 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1468
5d4cb038
PE
14692011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1470
8bd7b830 1471 Improve C-level modularity by making more things 'static'.
cd64ea1d 1472
e3b27b31
PE
1473 Don't publish debugger-only interfaces to other modules.
1474 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1475 (verify_bytepos, count_markers): Move decls to the only modules
1476 that need them.
1477 * region-cache.h (pp_cache): Likewise.
1478 * window.h (check_all_windows): Likewise.
1479 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1480
5d4cb038
PE
1481 * sysdep.c (croak): Now static, if
1482 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1483 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1484
1485 * alloc.c (refill_memory_reserve): Now static if
1486 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1487 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1488
e87b6180
PE
1489 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1490 Define only if USE_LUCID.
1491
ac64929e
PE
1492 * xrdb.c (x_customization_string, x_rm_string): Now static.
1493
6f37259d
PE
1494 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1495 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1496
1683e3ab
PE
1497 * xdisp.c (draw_row_with_mouse_face): Now static.
1498 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1499
de9c2632
PE
1500 * window.h (check_all_windows): Mark externally visible.
1501
2b96acb7
PE
1502 * window.c (window_deletion_count): Now static.
1503
1504 * undo.c: Make symbols static if they're not exported.
1505 (last_undo_buffer, last_boundary_position, pending_boundary):
1506 Now static.
1507
50436f33
PE
1508 * textprop.c (interval_insert_behind_hooks): Now static.
1509 (interval_insert_in_front_hooks): Likewise.
1510
64520e5c
PE
1511 * term.c: Make symbols static if they're not exported.
1512 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1513 (max_frame_lines, tty_set_terminal_modes):
1514 (tty_reset_terminal_modes, tty_turn_off_highlight):
1515 (get_tty_terminal): Now static.
1516 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1517 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1518 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1519 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1520 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1521
1fa53021
PE
1522 * sysdep.c: Make symbols static if they're not exported.
1523 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1524 Now static.
1525 (sigprocmask_set, full_mask): Remove; unused.
1526 (wait_debugging): Mark as visible.
1527 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1528 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1529
d4b43b22
PE
1530 * syntax.c (syntax_temp): Define only if !__GNUC__.
1531
b7c513d0
PE
1532 * sound.c (current_sound_device, current_sound): Now static.
1533
989b29ad
PE
1534 * search.c (searchbufs, searchbuf_head): Now static.
1535
13a55a78
PE
1536 * scroll.c (scroll_cost): Remove; unused.
1537 * dispextern.h (scroll_cost): Remove decl.
1538
de68a1fc
PE
1539 * region-cache.h (pp_cache): Mark as externally visible.
1540
40ccffa6
PE
1541 * process.c: Make symbols static if they're not exported.
1542 (process_tick, update_tick, create_process, chan_process):
1543 (Vprocess_alist, proc_buffered_char, datagram_access):
1544 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1545 (deactivate_process): Mark defn as static, as well as decl.
1546 * lisp.h (create_process): Remove decl.
1547 * process.h (chan_process, Vprocess_alist): Remove decls.
1548
ad64fc97
PE
1549 * print.c: Make symbols static if they're not exported.
1550 (print_depth, new_backquote_output, being_printed, print_buffer):
1551 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1552 (print_interval, print_number_index, initial_stderr_stream):
1553 Now static.
1554 * lisp.h (Fprinc): Remove decl.
1555 (debug_output_compilation_hack): Mark as externally visible.
1556
adddb265
PE
1557 * sysdep.c (croak): Move decl from here to syssignal.h.
1558 * syssignal.h (croak): Put it here, so the API can be checked when
1559 'croak' is called from dissociate_if_controlling_tty.
1560
1717ede2
PE
1561 * minibuf.c: Make symbols static if they're not exported.
1562 (minibuf_save_list, choose_minibuf_frame): Now static.
1563 * lisp.h (choose_minibuf_frame): Remove decl.
1564
fa5fb2bc
PE
1565 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1566
1e3890d1
PE
1567 * lread.c: Make symbols static if they're not exported.
1568 (read_objects, initial_obarray, oblookup_last_bucket_number):
1569 Now static.
1570 (make_symbol): Remove; unused.
1571 * lisp.h (initial_obarray, make_symbol): Remove decls.
1572
8a1414fa
PE
1573 * keyboard.c: Make symbols static if they're not exported.
1574 (single_kboard, recent_keys_index, total_keys, recent_keys):
1575 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1576 (this_single_command_key_start, echoing, last_auto_save):
1577 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1578 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1579 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1580 (Vlispy_mouse_stem, double_click_count):
1581 Now static.
1582 (force_auto_save_soon): Define only if SIGDANGER.
1583 (ignore_mouse_drag_p): Now static if
1584 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1585 (print_help): Remove; unused.
1586 (stop_character, last_timer_event): Mark as externally visible.
1587 * keyboard.h (ignore_mouse_drag_p): Declare only if
1588 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1589 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1590 * lisp.h (echoing): Remove decl.
1591 (force_auto_save_soon): Declare only if SIGDANGER.
1592 * xdisp.c (redisplay_window): Simplify code, to make it more
1593 obvious that ignore_mouse_drag_p is not accessed if !defined
1594 USE_GTK && !defined HAVE_NS.
1595
93ea6e8f
PE
1596 * intervals.c: Make symbols static if they're not exported.
1597 (merge_properties_sticky, merge_interval_right, delete_interval):
1598 Now static.
1599 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1600
77382fcc
PE
1601 * insdel.c: Make symbols static if they're not exported.
1602 However, leave prepare_to_modify_buffer alone. It's never
1603 called from outside this function, but that appears to be a bug.
1604 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1605 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1606 (adjust_after_replace_noundo): Remove; unused.
1607 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1608 (signal_before_change): Remove decls.
77382fcc 1609
9306c32e
PE
1610 * indent.c (val_compute_motion, val_vmotion): Now static.
1611
cd44d2eb
PE
1612 * image.c: Make symbols static if they're not exported.
1613 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1614 if USE_GTK.
1615 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1616 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1617
ad9a7a06
PE
1618 * fringe.c (standard_bitmaps): Now static.
1619 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1620
81626931
PE
1621 * frame.c: Make symbols static if they're not exported.
1622 (x_report_frame_params, make_terminal_frame): Now static.
1623 (get_frame_param): Now static, unless HAVE_NS.
1624 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1625 (x_get_resource_string): Remove; not used.
1626 * frame.h (make_terminal_frame, x_report_frame_params):
1627 (x_get_resource_string); Remove decls.
1628 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1629 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1630
239f9db9
PE
1631 * font.c, fontset.c: Make symbols static if they're not exported.
1632 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1633 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1634 * font.c (font_close_object): Now static.
1635 * font.h (font_close_object): Remove.
1636 * fontset.c (FONTSET_OBJLIST): Remove.
1637 (free_realized_fontset) #if-0 the body, which does nothing.
1638 (face_suitable_for_char_p): #if-0, as it's never called.
1639 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1640 * xfaces.c (face_at_string_position):
1641 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1642 since 0 is always ASCII.
1643
dfcf3579
PE
1644 * fns.c (weak_hash_tables): Now static.
1645
5045092b
PE
1646 * fileio.c: Make symbols static if they're not exported.
1647 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1648 (Vwrite_region_annotation_buffers): Now static.
1649
57a96f5c
PE
1650 * eval.c: Make symbols static if they're not exported.
1651 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1652 * lisp.h (backtrace_list): Remove decl.
1653
35f08c38
PE
1654 * emacs.c: Make symbols static if they're not exported.
1655 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1656 (fatal_error_code, fatal_error_signal_hook, standard_args):
1657 Now static.
1658 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1659 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1660 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1661 * lisp.h (fatal_error_signal_hook): Remove decl.
1662 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1663
f44bd759
PE
1664 * editfns.c: Move a (normally-unused) function to its only use.
1665 * editfns.c, lisp.h (get_operating_system_release): Remove.
1666 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1667 worth the hassle of breaking this out.
1668
b532497d
PE
1669 * xterm.c: Make symbols static if they're not exported.
1670 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1671 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1672 (x_destroy_window, x_delete_display):
1673 Now static.
1674 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1675 (x_mouse_leave): Remove; unused.
1676 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1677 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1678 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1679 Remove decls.
1680 (x_mouse_leave): Declare only if WINDOWSNT.
1681 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1682 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1683 USE_X_TOOLKIT.
1684
1675728f
PE
1685 * ftxfont.c: Make symbols static if they're not exported.
1686 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1687 HAVE_FREETYPE.
1688 * font.h (ftxfont_driver): Likewise.
1689
e4cebfca
PE
1690 * xfns.c: Make symbols static if they're not exported.
1691 (x_last_font_name, x_display_info_for_name):
1692 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1693 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1694 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1695 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1696 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1697 (last_show_tip_args): Now static.
1698 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1699 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1700 (x_screen_planes): Remove; unused.
1701 * dispextern.h (x_screen_planes): Remove decl.
1702
5bf46f05
PE
1703 * dispnew.c: Make symbols static if they're not exported.
1704 * dispextern.h (redraw_garbaged_frames, scrolling):
1705 (increment_row_positions): Remove.
1706 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1707 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1708 Now static.
1709 (redraw_garbaged_frames): Remove; unused.
1710
435f4c28
PE
1711 * xfaces.c: Make symbols static if they're not exported.
1712 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1713 Remove decls.
1714 * xterm.h (defined_color): Remove decls.
1715 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1716 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1717 (menu_face_changed_default, defined_color, free_realized_face):
1718 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1719 (ascii_face_of_lisp_face): Remove; unused.
1720
8524aef3
PE
1721 * xdisp.c: Make symbols static if they're not exported.
1722 * dispextern.h (scratch_glyph_row, window_box_edges):
1723 (glyph_to_pixel_coords, set_cursor_from_row):
1724 (get_next_display_element, set_iterator_to_next):
1725 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1726 (show_mouse_face): Remove decls
1727 * frame.h (message_buf_print): Likewise.
1728 * lisp.h (pop_message, set_message, check_point_in_composition):
1729 Likewise.
1730 * xterm.h (set_vertical_scroll_bar): Likewise.
1731 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1732 (message_buf_print, scratch_glyph_row, displayed_buffer):
1733 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1734 (get_next_display_element, show_mouse_face, window_box_edges):
1735 (frame_to_window_pixel_xy, check_point_in_composition):
1736 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1737 (glyph_to_pixel_coords): Remove; unused.
1738
16390cd2
PE
1739 * dired.c (file_name_completion): Now static.
1740
1741 * dbusbind.c (xd_in_read_queued_messages): Now static.
1742
a25f4dfa
PE
1743 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1744 * data.c (circular_list_error): Remove.
1745
14a9c8df
PE
1746 * commands.h (last_point_position, last_point_position_buffer):
1747 (last_point_position_window): Remove decls.
1748 * keyboard.c: Make these variables static.
1749
04f2d78b
CB
1750 * coding.h (coding, code_convert_region, encode_coding_gap):
1751 Remove decls.
74ab6df5
PE
1752 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1753 (iso_code_class, detect_coding, code_convert_region): Now static.
1754 (encode_coding_gap): Remove; unused.
1755
38dfbee1
PE
1756 * chartab.c (chartab_chars, chartab_bits): Now static.
1757
a2cb4e63
PE
1758 * charset.h (charset_iso_8859_1): Remove decl.
1759 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1760 Now static.
1761
127198fd
PE
1762 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1763 * ccl.c (Vccl_program_table): Now static.
1764 (check_ccl_update): Remove; unused.
1765
d85b608f
PE
1766 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1767 * category.h: ... from here.
1768 * category.c (check_category_table, set_category_set): Now static.
1769
31cd66f3
PE
1770 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1771 * lisp.h: Remove these decls.
1772
c358e587
PE
1773 * buffer.c (buffer_count): Remove unused var.
1774
e78aecca
PE
1775 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1776 so that it's not optimized away.
1777 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1778 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1779 exported only to the debugger.
1780
e192d7d3 1781 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1782 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1783
92470028
PE
1784 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1785 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1786 was inaccessible from Lisp.
1787 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1788 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1789
244ed907
PE
1790 alloc.c: Import and export fewer symbols, and remove unused items.
1791 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1792 is defined.
1793 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1794 it's not optimized away by whole-program optimization.
1795 (message_enable_multibyte, free_misc): Remove.
1796 (catchlist, handlerlist, mark_backtrace):
1797 Declare only if BYTE_MARK_STACK.
1798 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1799 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1800 (message_enable_multibyte): Remove decl.
1801 (free_misc, interval_free_list, float_block, float_block_index):
1802 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1803 (cons_free_list, last_marked_index):
1804 Now static.
1805 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1806 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1807 (mark_backtrace): Define only if BYTE_MARK_STACK.
1808 * xdisp.c (message_enable_multibyte): Now static.
1809
61c2b50e 1810 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1811 This makes it easier for human readers (and static analyzers)
1812 to see whether these variables are used from other modules.
1813 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1814 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1815 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1816 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1817 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1818 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1819 * xmenu.c, xselect.c:
1820 Declare Q* vars static if they are not used in other modules.
1821 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1822 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1823 Remove decls of unexported vars.
1824 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1825
95c82688
PE
1826 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1827
16a97296
PE
1828 Make Emacs functions such as Fatom 'static' by default.
1829 This makes it easier for human readers (and static analyzers)
1830 to see whether these functions can be called from other modules.
1831 DEFUN now defines a static function. To make the function external
1832 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1833 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1834 (Finit_image_library):
16a97296
PE
1835 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1836 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1837 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1838 Remove decls, since these functions are now static.
1839 (Funintern, Fget_internal_run_time): New decls, since these functions
1840 were already external.
95c82688 1841
16a97296
PE
1842 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1843 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1844 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1845 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1846 * keyboard.c, keymap.c, lread.c:
1847 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1848 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1849 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1850 Mark functions with DEFUE instead of DEFUN,
1851 if they are used in other modules.
1852 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1853 decls for now-static functions.
1854 * buffer.h (Fdelete_overlay): Remove decl.
1855 * callproc.c (Fgetenv_internal): Mark as internal.
1856 * composite.c (Fremove_list_of_text_properties): Remove decl.
1857 (Fcomposition_get_gstring): New forward static decl.
1858 * composite.h (Fcomposite_get_gstring): Remove decl.
1859 * dired.c (Ffile_attributes): New forward static decl.
1860 * doc.c (Fdocumntation_property): New forward static decl.
1861 * eval.c (Ffetch_bytecode): New forward static decl.
1862 (Funintern): Remove extern decl; now in .h file where it belongs.
1863 * fileio.c (Fmake_symbolic_link): New forward static decl.
1864 * image.c (Finit_image_library): New forward static decl.
1865 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1866 * intervals.h (Fprevious_property_change):
1867 (Fremove_list_of_text_properties): Remove decls.
1868 * keyboard.c (Fthis_command_keys): Remove decl.
1869 (Fcommand_execute): New forward static decl.
1870 * keymap.c (Flookup_key): New forward static decl.
1871 (Fcopy_keymap): Now static.
1872 * keymap.h (Flookup_key): Remove decl.
1873 * process.c (Fget_process): New forward static decl.
1874 (Fprocess_datagram_address): Mark as internal.
1875 * syntax.c (Fsyntax_table_p): New forward static decl.
1876 (skip_chars): Remove duplicate decl.
1877 * textprop.c (Fprevious_property_change): New forward static decl.
1878 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1879 Now internal.
1880 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1881 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1882
785bbd42
PE
1883 * editfns.c (Fformat): Remove unreachable code.
1884
8b913b57
AS
18852011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1886
1887 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1888 change. (Bug#8496)
1889
a6744a35
EZ
18902011-04-13 Eli Zaretskii <eliz@gnu.org>
1891
1892 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1893 when at ZV. (Bug#8487)
1894
e7974947
AS
18952011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1896
baad03f0
AS
1897 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1898 (Bug#8437)
1899 * keyboard.c (parse_tool_bar_item): Likewise.
1900 * sound.c (sound_cleanup, alsa_close): Likewise.
1901 * termcap.c (tgetent): Likewise.
1902 * xfns.c (x_default_font_parameter): Likewise.
1903 * xsettings.c (read_and_apply_settings): Likewise.
1904
e7974947
AS
1905 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1906 (overrun_check_free): Protoize.
1907
28272684
PE
19082011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1911 since callers should never pass a negative size.
1912 Change the signature to match that of plain 'read' and 'write'; see
1913 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1914 * lisp.h: Update prototypes of emacs_write and emacs_read.
1915
11997c76
EZ
19162011-04-11 Eli Zaretskii <eliz@gnu.org>
1917
1918 * xdisp.c (redisplay_window): Don't try to determine the character
1919 position of the scroll margin if the window start point w->startp
e896f03c 1920 is outside the buffer's accessible region. (Bug#8468)
11997c76 1921
8a2cbd72
EZ
19222011-04-10 Eli Zaretskii <eliz@gnu.org>
1923
1924 Fix write-region and its subroutines for buffers > 2GB.
1925 * fileio.c (a_write, e_write): Modify declaration of arguments and
1926 local variables to support buffers larger than 2GB.
1927 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1928
1929 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1930 argument, local variables, and return value.
1931
1932 * lisp.h: Update prototypes of emacs_write and emacs_read.
1933
1934 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1935
4073e537 19362011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1937
1ebfdcb6
PE
1938 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1939
b2ded58d
PE
1940 Fix more problems found by GCC 4.6.0's static checks.
1941
7d66342c
PE
1942 * xdisp.c (vmessage): Use a better test for character truncation.
1943
bbf47d44
PE
1944 * charset.c (load_charset_map): <, not <=, for optimization,
1945 and to avoid potential problems with integer overflow.
9248994d 1946 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1947 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1948 * editfns.c (Fformat): Likewise.
1e69125e 1949 * syntax.c (skip_chars): Likewise.
3befa583 1950
e3019616
PE
1951 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1952 This also lets GCC 4.6.0 generate slightly better loop code.
1953
becfa255
PE
1954 * callint.c (Fcall_interactively): <, not <=, for optimization.
1955 (Fcall_interactively): Count the number of arguments produced,
1956 not the number of arguments given. This is simpler and lets GCC
1957 4.6.0 generate slightly better code.
1958
dae0cd48
PE
1959 * ftfont.c: Distingish more carefully between FcChar8 and char.
1960 The previous code passed unsigned char * to a functions like
1961 strlen and xstrcasecmp that expect char *, which does not
1962 conform to the C standard.
1963 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1964 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1965 char * when the C standard requires it.
1966
76032d70
PE
1967 * keyboard.c (read_char): Remove unused var.
1968
eb3f1cc8
PE
1969 * eval.c: Port to Windows vsnprintf (Bug#8435).
1970 Include <limits.h>.
1971 (SIZE_MAX): Define if the headers do not.
1972 (verror): Do not give up if vsnprintf returns a negative count.
1973 Instead, grow the buffer. This ports to Windows vsnprintf, which
1974 does not conform to C99. Problem reported by Eli Zaretskii.
1975 Also, simplify the allocation scheme, by avoiding the need for
1976 calling realloc, and removing the ALLOCATED variable.
1977
70476b54
PE
1978 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1979
12020a9e
PE
1980 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1981 But keep the doprint source code for now, as we might revamp it
1982 and use it again (Bug#8435).
ea6c7ae6
PE
1983 * lisp.h (doprnt): Remove.
1984 * Makefile.in (base_obj): Remove doprnt.o.
1985 * deps.mk (doprnt.o): Remove.
1986
5fdb398c
PE
1987 error: Print 32- and 64-bit integers portably (Bug#8435).
1988 Without this change, on typical 64-bit hosts error ("...%d...", N)
1989 was used to print both 32- and 64-bit integers N, which relied on
1990 undefined behavior.
1991 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1992 New macro.
1993 * lisp.h (error, verror): Mark as printf-like functions.
1994 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1995 Report overflow in size calculations when allocating printf buffer.
1996 Do not truncate output string at its first null byte.
1997 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1998 Truncate the output at a character boundary, since vsnprintf does not
1999 do that.
2000 * charset.c (check_iso_charset_parameter): Convert internal
2001 character to string before calling 'error', since %c now has the
2002 printf meaning.
2003 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2004 overflow when computing char to be passed to 'error'. Do not
2005 pass Lisp_Object to 'error'; pass the integer instead.
2006 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2007 formatted with plain %d.
2008
b189fa66
PE
2009 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2010
bff87ef0
PE
2011 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2012
7e2cac20
PE
2013 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2014
ce4d90b5
PE
2015 * xterm.c (x_catch_errors): Remove duplicate declaration.
2016
266c9547
PE
2017 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2018
79c49ad2
PE
2019 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2020
368f4090
JM
20212011-04-10 Jim Meyering <meyering@redhat.com>
2022
2023 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2024 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2025 return ssize_t not "int", and use size_t as the buffer length.
2026 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2027 * gnutls.h: Update declarations.
2028 * process.c (read_process_output): Use ssize_t, to match.
2029 (send_process): Likewise.
2030
a32d4040
CY
20312011-04-09 Chong Yidong <cyd@stupidchicken.com>
2032
2033 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2034
8546720e 20352011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2036
04f2d78b
CB
2037 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2038 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2039
8546720e
GM
2040 * xterm.c (handle_one_xevent):
2041 * xmenu.c (create_and_show_popup_menu):
2042 * xselect.c (x_decline_selection_request)
2043 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2044
0a2f5c1a 20452011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2046
2047 Fix some uses of `int' instead of EMACS_INT.
2048 * search.c (string_match_1, fast_string_match)
2049 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2050 (scan_buffer, find_next_newline_no_quit)
2051 (find_before_next_newline, search_command, Freplace_match)
2052 (Fmatch_data): Make some `int' variables be EMACS_INT.
2053
2054 * xdisp.c (display_count_lines): 3rd argument and return value now
2055 EMACS_INT. All callers changed.
2056 (pint2hrstr): Last argument is now EMACS_INT.
2057
2058 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2059 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2060 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2061 (decode_coding_utf_16, decode_coding_emacs_mule)
2062 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2063 (decode_coding_ccl, decode_coding_charset)
2064 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2065 (decode_coding_iso_2022, decode_coding_emacs_mule)
2066 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2067 <char_offset, last_offset>: Declare EMACS_INT.
2068 (encode_coding_utf_8, encode_coding_utf_16)
2069 (encode_coding_emacs_mule, encode_invocation_designation)
2070 (encode_designation_at_bol, encode_coding_iso_2022)
2071 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2072 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2073 Declare EMACS_INT.
2074 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2075 (encode_invocation_designation): Last argument P_NCHARS is now
2076 EMACS_INT.
2077 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2078 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2079
2080 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2081 All users changed.
2082
2083 * ccl.c (Fccl_execute_on_string): Declare some variables
2084 EMACS_INT.
2085
8546720e 20862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2087
2088 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2089
4e19a977
CS
20902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2091
2092 * process.c (Fformat_network_address): Doc fix.
2093
87302331
R
20942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2095
2096 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2097
cbb59342
CY
20982011-04-08 Chong Yidong <cyd@stupidchicken.com>
2099
2100 * keyboard.c (read_char): Call Lisp function help-form-show,
2101 instead of using internal_with_output_to_temp_buffer.
2102 (Qhelp_form_show): New var.
e0d38eeb 2103 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2104
2105 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2106
2107 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2108
e67a13ab
CY
21092011-04-06 Chong Yidong <cyd@stupidchicken.com>
2110
04f2d78b
CB
2111 * process.c (Flist_processes): Remove to Lisp.
2112 (list_processes_1): Delete.
e67a13ab 2113
973f782d
EZ
21142011-04-06 Eli Zaretskii <eliz@gnu.org>
2115
7c106b1e
EZ
2116 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2117
973f782d
EZ
2118 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2119
41cf7d1a 21202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2121
ca23cc88
PE
2122 Fix more problems found by GCC 4.6.0's static checks.
2123
f390e2d5
PE
2124 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2125
42eea0d0
PE
2126 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2127
b69769da 2128 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2129
f9541e84
PE
2130 * xdisp.c (vmessage): Mark as a printf-like function.
2131
13841b55
PE
2132 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2133
c136c10f
PE
2134 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2135
5e2d4a30
PE
2136 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2137 printf-like functions.
2138 (tiff_load): Add casts to remove these marks before passing them
2139 to system-supplied API.
2140
583f48b9
PE
2141 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2142
b25d760e
PE
2143 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2144 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2145 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2146 directly, rather than having caller test rule sign. This avoids
2147 some unnecessary tests.
2148 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2149 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2150 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2151
bc7b6697 2152 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2153 (xfont_open): Avoid unnecessary tests.
bc7b6697 2154
27ccc379
PE
2155 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2156
dcd5c89a
PE
2157 * composite.h, composite.c (composition_gstring_put_cache):
2158 Use EMACS_INT, not int, for length.
2159
b13a45c6
PE
2160 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2161 breaking out part of COMPOSITION_DECODE_RULE.
2162 (COMPOSITION_DECODE_RULE): Use it.
2163 * composite.c (get_composition_id): Remove unused local vars,
2164 by using the new macro.
2165
1e792e4d
PE
2166 * textprop.c (set_text_properties_1): Change while to do-while,
2167 since the condition is always true at first.
2168
dc6c6455 2169 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2170 (interval_deletion_adjustment): Return unsigned value.
2171 All uses changed.
dc6c6455 2172
aba7731a
PE
2173 * process.c (list_processes_1, create_pty, read_process_output):
2174 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2175 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2176 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2177 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2178 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2179
fdfc4bf3
PE
2180 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2181
fca8fe46 2182 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2183 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2184
06a0259a 2185 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2186 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2187 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2188
e7b9e80f
PE
2189 * print.c (print_error_message): Avoid int overflow.
2190
56201685
PE
2191 * font.c (font_list_entities): Redo for clarity,
2192 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2193
78834453 2194 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2195 (font_score): Avoid potential overflow in diff calculation.
78834453 2196
0bc0b309 2197 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2198 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2199
e610eaca
PE
2200 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2201
b895abce
PE
2202 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2203 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2204 can always succeed if overflow has undefined behavior.
2205
1f1d9321 2206 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2207 (wordify): Omit three unnecessary tests.
1f1d9321 2208
c59478bc
PE
2209 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2210 All callers changed. This avoids the need for an unused var.
2211
79b73827
PE
2212 * casefiddle.c (casify_region): Remove var that is set but not used.
2213
a4db5dfe
PE
2214 * dired.c (file_name_completion): Remove var that is set but not used.
2215
43aae36e
PE
2216 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2217
2a47c44d 2218 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2219 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2220
a37c69bf
PE
2221 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2222 Check for integer overflow on size calculations.
2223
328ab8e7
PE
2224 * buffer.c (Fprevious_overlay_change): Remove var that is set
2225 but not used.
2226
e5a2a5cb
PE
2227 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2228 Remove vars that are set but not used.
8d84a6eb 2229 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2230 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2231
a60e5f68
PE
2232 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2233
f661cb61 2234 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2235 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2236
f0397f5a
PE
2237 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2238 that are set but not used.
2239
8664db06 2240 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2241 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2242
6abdaa4a
PE
2243 * xselect.c (x_get_local_selection, x_handle_property_notify):
2244 Remove vars that are set but not used.
2245
0ce7538d 2246 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2247 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2248
9ae848fc
PE
2249 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2250 Remove var that is set but not used.
0b918413
PE
2251 (scroll_bar_windows_size): Now size_t, not int.
2252 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2253 Check for overflow.
9ae848fc 2254
a5a62657
PE
2255 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2256 (map_tty_color) [!defined MSDOS]: Likewise.
2257
5c5cdd39
PE
2258 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2259
66ebf983
PE
2260 * coding.c: Remove vars that are set but not used.
2261 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2262 All callers changed.
2263 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2264 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2265 (decode_coding_charset): Remove vars that are set but not used.
2266
1be4d761
PE
2267 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2268 that is set but not used.
2269
47553fa8
PE
2270 * print.c (print_object): Remove var that is set but not used.
2271
1f7196bf 2272 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2273 The gnulib version avoids calling malloc in the usual case,
2274 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2275 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2276 * filelock.c (current_lock_owner): Likewise.
2277 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2278 * sysdep.c: Include allocator.h, careadlinkat.h.
2279 (emacs_no_realloc_allocator): New static constant.
2280 (emacs_readlink): New function.
fdb61804
PE
2281 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2282 ../lib/careadlinkat.h.
d1fdcab7 2283
f84c17c7
SM
22842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2285
2286 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2287 first non-nil return value).
2288
ef3862ad
JD
22892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2290
2291 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2292 if not defined (Bug#8403).
2293
376a7006
JB
22942011-04-02 Juanma Barranquero <lekktu@gmail.com>
2295
2296 * xdisp.c (display_count_lines): Remove parameter `start',
2297 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2298 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2299 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2300 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2301 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2302 and thereabouts. All callers changed.
2303 (get_per_char_metric): Remove parameter `f', unused since
2304 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2305
6ca3801d
JM
23062011-04-02 Jim Meyering <meyering@redhat.com>
2307
2308 do not dereference NULL upon failed strdup
2309 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2310 (ns_get_family): Likewise.
2311
d8e2b5ba
JB
23122011-04-02 Juanma Barranquero <lekktu@gmail.com>
2313
2314 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2315
8c74fcbd
JD
23162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2317
2318 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2319 later (Bug#8403).
2320
7200d79c
SM
23212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2322
03408648 2323 Add lexical binding.
7200d79c 2324
03408648
SM
2325 * window.c (Ftemp_output_buffer_show): New fun.
2326 (Fsave_window_excursion):
2327 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2328
2329 * lread.c (lisp_file_lexically_bound_p): New function.
2330 (Fload): Bind Qlexical_binding.
2331 (readevalloop): Remove `evalfun' arg.
2332 Bind Qinternal_interpreter_environment.
2333 (Feval_buffer): Bind Qlexical_binding.
2334 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2335 Mark as dynamic.
2336 (syms_of_lread): Declare `lexical-binding'.
2337
2338 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2339
2340 * keyboard.c (eval_dyn): New fun.
2341 (menu_item_eval_property): Use it.
ca105506
SM
2342
2343 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2344
03408648
SM
2345 * fns.c (concat, mapcar1): Accept byte-code-functions.
2346
2347 * eval.c (Fsetq): Handle lexical vars.
2348 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2349 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2350 (FletX, Flet): Obey lexical binding.
2351 (Fcommandp): Handle closures.
2352 (Feval): New `lexical' arg.
2353 (eval_sub): New function extracted from Feval. Use it almost
2354 everywhere where Feval was used. Look up vars in lexical env.
2355 Handle closures.
2356 (Ffunctionp): Move from subr.el.
2357 (Ffuncall): Handle closures.
2358 (apply_lambda): Remove `eval_flags'.
2359 (funcall_lambda): Handle closures and new byte-code-functions.
2360 (Fspecial_variable_p): New function.
2361 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2362 but without exporting it to Lisp.
23aba0ea 2363
23aba0ea 2364 * doc.c (Fdocumentation, store_function_docstring):
03408648 2365 * data.c (Finteractive_form): Handle closures.
23aba0ea 2366
03408648
SM
2367 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2368 interactive spec.
ba83908c 2369
04f2d78b
CB
2370 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2371 New byte-codes.
03408648
SM
2372 (exec_byte_code): New function extracted from Fbyte_code to handle new
2373 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2374
03408648 2375 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2376
03408648 2377 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2378
e2abce01
JB
23792011-03-31 Juanma Barranquero <lekktu@gmail.com>
2380
2381 * xdisp.c (redisplay_internal): Fix prototype.
2382
63696a73 23832011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2384
63696a73 2385 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2386 (try_scrolling): Use it when setting scroll_limit.
2387 Limit scrolling to 100 screen lines.
63696a73
EZ
2388 (redisplay_window): Even when falling back on "recentering",
2389 position point in the window according to scroll-conservatively,
2390 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2391
2392 (try_scrolling): When point is above the window, allow searching
2393 as far as scroll_max, or one screenful, to compute vertical
2394 distance from PT to the scroll margin position. This prevents
2395 try_scrolling from unnecessarily failing when
2396 scroll-conservatively is set to a value slightly larger than the
2397 window height. Clean up the case of PT below the margin at bottom
2398 of window: scroll_max can no longer be INT_MAX. When aggressive
2399 scrolling is in use, don't let point enter the opposite scroll
2400 margin as result of the scroll.
2401 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2402 threshold of 100 lines for never-recentering scrolling.
2403
e4cc2dfc
JB
24042011-03-31 Juanma Barranquero <lekktu@gmail.com>
2405
2406 * dispextern.h (move_it_by_lines):
2407 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2408 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2409 (message_log_check_duplicate): Remove parameters `prev_bol' and
2410 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2411 (redisplay_internal): Remove parameter `preserve_echo_area',
2412 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2413
2414 * indent.c (Fvertical_motion):
2415 * window.c (window_scroll_pixel_based, Frecenter):
2416 Don't pass `need_y_p' to `move_it_by_lines'.
2417
1c470562
SM
24182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2419
44f230aa
SM
2420 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2421 steal a few bits to be more compact.
2422 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2423 Remove unneeded casts.
2424
1c470562
SM
2425 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2426
888adce9
ZK
24272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2428
2429 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2430 binding" message (bug#7967).
2431
f838ed7b
PE
24322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2433
77861b95
PE
2434 Fix more problems found by GCC 4.6.0's static checks.
2435
de6dbc14
PE
2436 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2437 Remove unused local var.
2438
f838ed7b
PE
2439 * editfns.c (Fmessage_box): Remove unused local var.
2440
792c7b2b
PE
2441 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2442 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2443 Omit unused local vars.
c499e557 2444 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2445 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2446 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2447 Omit unused local var.
2448
ba0165e1
PE
2449 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2450 Don't assume string length fits in int.
32ad8845 2451 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2452 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2453
3c59b4c9
PE
2454 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2455 instead of alloca (Bug#8344).
2456
a3eed478 2457 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2458 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2459
eb4d412d
PE
2460 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2461
1658b401
PE
2462 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2463 concerns.
2464
2465 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2466
2467 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2468
9a2c6e05
PE
2469 * keyboard.c (syms_of_keyboard): Use the same style as later
2470 in this function when indexing through an array. This also
2471 works around GCC bug 48267.
2472
03d0a109
PE
2473 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2474
44f730c8
PE
2475 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2476
fe75f926
PE
2477 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2478 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2479
ffa8c828
PE
2480 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2481 This avoids undefined behavior on integer overflow, and is a bit
2482 more convenient anyway since it is compared to a size_t variable.
2483
c5101a77
PE
2484 Variadic C functions now count arguments with size_t, not int.
2485 This avoids an unnecessary limitation on 64-bit machines, which
2486 caused (substring ...) to crash on large vectors (Bug#8344).
2487 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2488 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2489 All variadic functions and their callers changed accordingly.
c5101a77
PE
2490 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2491 * data.c (arith_driver, float_arith_driver): Likewise.
2492 * editfns.c (general_insert_function): Likewise.
2493 * eval.c (struct backtrace.nargs, interactive_p)
2494 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2495 (funcall_lambda, mark_backtrace): Likewise.
2496 * fns.c (concat): Likewise.
2497 * frame.c (x_set_frame_parameters): Likewise.
2498 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2499 0 if not found, not -1. All callers changed.
2500
dd3f25f7
PE
2501 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2502 (stack_copy_size): Now size_t, not int.
2503 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2504
461c2ab9
JB
25052011-03-28 Juanma Barranquero <lekktu@gmail.com>
2506
2507 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2508 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2509 All callers changed.
2510
2511 * lisp.h (multibyte_char_to_unibyte):
2512 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2513 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2514 * character.h (CHAR_TO_BYTE8):
2515 * cmds.c (internal_self_insert):
2516 * editfns.c (general_insert_function):
2517 * keymap.c (push_key_description):
2518 * search.c (Freplace_match):
2519 * xdisp.c (message_dolog, set_message_1): All callers changed.
2520
f6d62986
SM
25212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2522
2523 * keyboard.c (safe_run_hook_funcall): New function.
2524 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2525 don't set the hook to nil, but remove the offending function instead.
2526 (Qcommand_hook_internal): Remove, unused.
2527 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2528 Vcommand_hook_internal.
2529
2530 * eval.c (enum run_hooks_condition): Remove.
2531 (funcall_nil, funcall_not): New functions.
2532 (run_hook_with_args): Call each function through a `funcall' argument.
2533 Remove `cond' argument, now redundant.
2534 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2535 (Frun_hook_with_args_until_failure): Adjust accordingly.
2536 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2537
1db5b1ad
JB
25382011-03-28 Juanma Barranquero <lekktu@gmail.com>
2539
2540 * dispextern.h (string_buffer_position): Remove declaration.
2541
2542 * print.c (strout): Remove parameter `multibyte', unused since
2543 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2544
2545 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2546 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2547 All callers changed.
2548
2549 * w32.c (_wsa_errlist): Use braces for struct initializers.
2550
2551 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2552 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2553 All callers changed.
2554 (string_buffer_position): Likewise. Also, make static (it's never
2555 used outside xdisp.c).
2556 (cursor_row_p): Remove parameter `w', unused since
2557 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2558 (decode_mode_spec): Remove parameter `precision', introduced during
2559 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2560 All callers changed.
2561
5ffb62aa
JD
25622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2563
2564 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2565
461c2ab9 25662011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2567
2568 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2569 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2570 (ns_update_auto_hide_menu_bar): New functions.
2571 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2572 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2573 ns_constrain_all_frames.
2574 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2575 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2576
5c380ffb
JD
25772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2578
2579 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2580
9af30bdf
GM
25812011-03-27 Glenn Morris <rgm@gnu.org>
2582
2583 * syssignal.h: Replace RETSIGTYPE with void.
2584 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2585 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2586 Replace SIGTYPE with void everywhere.
2587 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2588 * s/template.h (SIGTYPE): Remove commented out definition.
2589
e2abce01
JB
25902011-03-26 Eli Zaretskii <eliz@gnu.org>
2591
2592 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2593 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2594
f868cd8a
JB
25952011-03-26 Juanma Barranquero <lekktu@gmail.com>
2596
59eb0929
JB
2597 * w32.c (read_unc_volume): Use parameter `henum', instead of
2598 global variable `wget_enum_handle'.
2599
2600 * keymap.c (describe_vector): Remove parameters `indices' and
2601 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2602 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2603
f868cd8a
JB
2604 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2605
2606 * keyboard.c (timer_check): Remove parameter `do_it_now',
2607 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2608 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2609 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2610
2611 * keyboard.c (read_char):
2612 * w32menu.c (w32_menu_display_help):
2613 * xmenu.c (show_help_event, menu_help_callback):
2614 Adjust calls to `show_help_echo'.
2615
2616 * gtkutil.c (xg_maybe_add_timer):
2617 * keyboard.c (readable_events):
2618 * process.c (wait_reading_process_output):
2619 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2620
2621 * insdel.c (adjust_markers_gap_motion):
2622 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2623 (gap_left, gap_right): Don't call it.
2624
2ecf6fdb
CY
26252011-03-25 Chong Yidong <cyd@stupidchicken.com>
2626
2627 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2628 incurred during fontification.
2629
6b1f9ba4
JB
26302011-03-25 Juanma Barranquero <lekktu@gmail.com>
2631
2632 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2633 (DEFVAR_PER_BUFFER): Don't pass it.
2634
2635 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2636 (scrolling_window): Don't pass it.
2637
0f4a96b5
JB
26382011-03-25 Juanma Barranquero <lekktu@gmail.com>
2639
2640 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2641
2642 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2643 and `suffix'.
2644 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2645 of variables specific to SELinux and computation of `encoded_absname'.
2646
2647 * image.c (XPutPixel): Remove unused variable `height'.
2648
2649 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2650
2651 * unexw32.c (get_section_info): Remove unused variable `section'.
2652
2653 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2654 (system_process_attributes): Remove unused variable `sess'.
2655 (sys_read): Remove unused variable `err'.
2656
2657 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2658 (w32_wnd_proc): Remove unused variable `isdead'.
2659 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2660 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2661 (x_create_tip_frame): Remove unused variable `tem'.
2662
2663 * w32inevt.c (w32_console_read_socket):
2664 Remove unused variable `no_events'.
2665
2666 * w32term.c (x_draw_composite_glyph_string_foreground):
2667 Remove unused variable `width'.
2668
1149507c
JB
26692011-03-24 Juanma Barranquero <lekktu@gmail.com>
2670
2671 * w32term.c (x_set_glyph_string_clipping):
2672 Don't pass uninitialized region to CombineRgn.
2673
9c88f339
JB
26742011-03-23 Juanma Barranquero <lekktu@gmail.com>
2675
2676 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2677 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2678 (Fx_close_connection): Remove unused variable `i'.
2679
2680 * w32font.c (w32font_draw): Return number of glyphs.
2681 (w32font_open_internal): Remove unused variable `i'.
2682 (w32font_driver): Add missing initializer.
2683
2684 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2685 (fill_in_menu): Remove unused variable `items_added'.
2686
2687 * w32term.c (last_mouse_press_frame): Remove static global variable.
2688 (w32_clip_to_row): Remove unused variable `f'.
2689 (x_delete_terminal): Remove unused variable `i'.
2690
2691 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2692 (NOTHING): Remove unused static global variable.
2693 (uniscribe_check_otf): Remove unused variable `table'.
2694 (uniscribe_font_driver): Add missing initializers.
2695
dee091a3
JD
26962011-03-23 Julien Danjou <julien@danjou.info>
2697
2698 * term.c (Fsuspend_tty, Fresume_tty):
2699 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2700 * window.c (temp_output_buffer_show):
2701 * insdel.c (signal_before_change):
2702 * frame.c (Fhandle_switch_frame):
2703 * fileio.c (Fdo_auto_save):
2704 * emacs.c (Fkill_emacs):
2705 * editfns.c (save_excursion_restore):
2706 * cmds.c (internal_self_insert):
2707 * callint.c (Fcall_interactively):
2708 * buffer.c (Fkill_all_local_variables):
2709 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2710 Use Frun_hooks.
0f4a96b5 2711 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2712 unconditionnaly since it does the check itself.
2713
2c520ab5 27142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2715
c9c49752
PE
2716 Fix more problems found by GCC 4.5.2's static checks.
2717
8abc3f12
PE
2718 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2719 the first time through the loop, since we know p0 < p1 then.
2720 This also avoids a gcc -Wstrict-overflow warning.
2721
a2d26660
PE
2722 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2723 leading to a memory leak, possible in functions like
2724 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2725 of objects (Bug#8318).
a2d26660 2726
916c72e9
PE
2727 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2728 that could (at least in theory) be that large.
2729
19ab8a18
PE
2730 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2731 This is less likely to overflow, and avoids undefined behavior if
2732 overflow does occur. All callers changed. Use strtoul to scan
2733 for the unsigned long integer.
b7cbbd6f
PE
2734 (pint2hrstr): Simplify and tune code slightly.
2735 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2736
f0641eff
PE
2737 * scroll.c (do_scrolling): Work around GCC bug 48228.
2738 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2739
7f650bb9
PE
2740 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2741 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2742 (validate_x_resource_name): Simplify count usage.
2743 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2744
37dd57d1
PE
2745 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2746 fail (Bug#8306).
81e56e61 2747
699979fc 2748 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2749
401bf9b4
PE
2750 * process.c (Fmake_network_process): Use socklen_t, not int,
2751 where POSIX says socklen_t is required in portable programs.
2752 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2753 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2754 (Fmake_network_process, server_accept_connection):
2755 (wait_reading_process_output, read_process_output):
2756 Likewise.
2757
b93aacde
PE
2758 * process.c: Rename or move locals to avoid shadowing.
2759 (list_processes_1, Fmake_network_process):
2760 (read_process_output_error_handler, exec_sentinel_error_handler):
2761 Rename or move locals.
4dc343ee 2762 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2763 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2764 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2765 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2766 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2767
af8a867c 2768 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2769 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2770 Include tparam.h instead, since it declares them.
af8a867c
PE
2771 * cm.h (PC): Remove extern decl; tparam.h now does this.
2772 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2773 * terminfo.c: Include tparam.h, to check interfaces.
2774 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2775 (tparam): Adjust signature to match interface in tparam.h;
2776 this removes some undefined behavior. Check that outstring and len
2777 are zero, which they always are with Emacs.
2778 * tparam.h (PC, BC, UP): New extern decls.
2779
0248044d 2780 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2781 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2782
8ff096c1 2783 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2784 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2785 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2786 (ftfont_list): Remove unused local.
49eaafba
PE
2787 (get_adstyle_property, ftfont_pattern_entity):
2788 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2789 Rename locals to avoid shadowing.
8ff096c1 2790
e2be39f6
PE
2791 * xfont.c (xfont_list_family): Mark var as initialized.
2792
c9735e30
PE
2793 * xml.c (make_dom): Now static.
2794
8f5201ae
PE
2795 * composite.c (composition_compute_stop_pos): Rename local to
2796 avoid shadowing.
b246f932
PE
2797 (composition_reseat_it): Remove unused locals.
2798 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2799 (composition_update_it): Mark var as initialized.
11b61122
PE
2800 (find_automatic_composition): Mark vars as initialized,
2801 with a FIXME (Bug#8290).
8f5201ae 2802
760fbc2c
PE
2803 character.h: Rename locals to avoid shadowing.
2804 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2805 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2806 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2807 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2808 to avoid shadowing.
2809
ff08eb85
PE
2810 * textprop.c (property_change_between_p): Remove; unused.
2811
fc7bf025
PE
2812 * intervals.c (interval_start_pos): Now static.
2813
235d7abc
PE
2814 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2815
44f230aa
SM
2816 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2817 Rename locals to avoid shadowing.
3e7d6594 2818
50060332
PE
2819 * sound.c (wav_play, au_play, Fplay_sound_internal):
2820 Fix pointer signedness.
d01f234b 2821 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2822 (wav_play): Initialize a variable to 0, to prevent undefined
2823 behavior (Bug#8278).
50060332 2824
c4fc4e30
PE
2825 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2826
918436ed
PE
2827 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2828
c939f91b
PE
2829 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2830 clobbering (Bug#8298).
b9c7f648
PE
2831 * sysdep.c (sys_subshell): Likewise.
2832 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2833
6bd8c144
PE
2834 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2835 This should get cleaned up, so that child_setup has the
2836 same signature on all platforms.
2837
7710357c 2838 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2839 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2840
c59da222
CY
28412011-03-22 Chong Yidong <cyd@stupidchicken.com>
2842
2843 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2844 not to be necessary, and produces flickering.
2845
66b87493
GM
28462011-03-20 Glenn Morris <rgm@gnu.org>
2847
2848 * config.in: Remove file.
2849
45b6f6d5
JB
28502011-03-20 Juanma Barranquero <lekktu@gmail.com>
2851
2852 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2853 are now in src/globals.h.
2854 (syms_of_minibuf): Remove spurious & from previous change.
2855
3ec03f7e
LL
28562011-03-20 Leo <sdl.web@gmail.com>
2857
2858 * minibuf.c (completing-read-function): New variable.
2859 (completing-read-default): Rename from completing-read.
2860 (completing-read): Call completing-read-function.
2861
b14e3e21
CY
28622011-03-19 Juanma Barranquero <lekktu@gmail.com>
2863
2864 * xfaces.c (Fx_load_color_file):
2865 Read color file from absolute filename (bug#8250).
2866
f2b726e6
JB
28672011-03-19 Juanma Barranquero <lekktu@gmail.com>
2868
2869 * makefile.w32-in: Update dependencies.
2870
09f6ff02
EZ
28712011-03-17 Eli Zaretskii <eliz@gnu.org>
2872
2873 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2874
29a6015a
PE
28752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2876
a3a6c54e
PE
2877 Fix more problems found by GCC 4.5.2's static checks.
2878
b766f867
PE
2879 * process.c (make_serial_process_unwind, send_process_trap):
2880 (sigchld_handler): Now static.
2881
be02381c
PE
2882 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2883 That way, the code declares only the vars that it needs.
2884 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2885 * s/cygwin.h (PTY_ITERATION): Likewise.
2886 * s/darwin.h (PTY_ITERATION): Likewise.
2887 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2888
57048744
PE
2889 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2890 * process.c (allocate_pty): Don't declare stb unless it's needed.
2891
7914961c 2892 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2893 (CONSTANTLIM): Remove; unused.
2894 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2895 Define only if needed.
7914961c 2896
b3967b18
PE
2897 * unexelf.c (unexec): Name an expression,
2898 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2899 Use a different way to cause a compilation error if anyone uses
2900 n rather than nn, a way that does not involve shadowing.
73366a00 2901 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2902
29a6015a
PE
2903 * deps.mk (unexalpha.o): Remove; unused.
2904
43cfc33e 2905 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2906 * unexec.h: New file.
ce701a33
PE
2907 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2908 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2909 Depend on unexec.h.
2910 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2911 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2912 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2913 Change as necessary to match prototype in unexec.h.
ce701a33 2914
01f44d5a
PE
2915 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2916 shadowing.
4f63c6bb 2917 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2918
a6670b0b
PE
2919 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2920 Rename locals to avoid shadowing.
2921
cef2010d 2922 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2923 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2924
d4d7173a
PE
2925 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2926
f08b802a
PE
2927 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2928 warning when compiling print.c.
2929
3ddb0639
PE
2930 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2931 instead of using an uninitialized var.
5ad03b97 2932 (font_sort_entities): Mark var as initialized.
3ddb0639 2933
170a2692
PE
2934 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2935
e663c700
PE
2936 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2937 pointers to constants.
89bc529a 2938 (font_parse_fcname): Remove unused vars.
7b81e2d0 2939 (font_delete_unmatched): Now static.
ea838e10 2940 (font_get_spec): Remove; unused.
13a547c6
PE
2941 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2942 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2943 Rename or move locals to avoid shadowing.
e663c700 2944
2a80c887 2945 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2946 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2947
1384fa33 2948 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2949 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2950
8b2c52e9
PE
2951 * alloc.c (mark_backtrace): Move decl from here ...
2952 * lisp.h: ... to here, so that it can be checked.
2953
475545b5 2954 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2955 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2956 (lisp_indirect_variable): Name an expression,
2957 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2958 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2959
b1349114 2960 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2961 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2962 Use const pointer when appropriate.
b1349114 2963
a2928364
PE
2964 * lisp.h (get_system_name, get_operating_system_release):
2965 Move decls here, to check interfaces.
2966 * process.c (get_operating_system_release): Move decl to lisp.h.
2967 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2968 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2969 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2970 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2971 (Fformat_time_string, Fencode_time, Finsert_char):
2972 (Ftranslate_region_internal, Fformat):
2973 Rename or remove local vars to avoid shadowing.
9710023e 2974 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2975
a415e694
PE
2976 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2977 avoid shadowing.
2978
8ef4622d
PE
2979 * lisp.h (eassert): Check that the argument compiles, even if
2980 ENABLE_CHECKING is not defined.
2981
946f9a5b
PE
2982 * data.c (Findirect_variable): Name an expression, to avoid
2983 gcc -Wbad-function-cast warning.
112396d6 2984 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2985 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2986 (Fmake_variable_buffer_local, Fmake_local_variable):
2987 Mark variables as initialized.
52746918 2988 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2989
e5aab7e7 2990 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2991 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2992 Rename locals to avoid shadowing.
dff45157
PE
2993 (mark_stack): Move local variables into the #ifdef region where
2994 they're used.
7bc26fdb
PE
2995 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2996 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2997 needed otherwise.
2998 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2999 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3000 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3001
e5aab7e7
PE
3002 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3003 avoids undefined behavior in theory.
3004
4da60324
PE
3005 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3006
88043301
PE
3007 Use functions, not macros, for up- and down-casing (Bug#8254).
3008 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3009 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3010 to use the following functions instead of these macros.
3011 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3012 EMACS_INT, since callers assume the returned value fits in int.
3013 (upcase1): Likewise, for UPCASE_TABLE.
3014 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3015 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3016 the race-condition problem in the old DOWNCASE.
88043301 3017
19ed5445
PE
3018 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3019 Rename locals to avoid shadowing.
3020 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3021 (regex_compile, re_search_2, re_match_2_internal):
3022 Remove unused local vars.
952db0d7
PE
3023 (FREE_VAR): Rewrite so as not to use empty "else",
3024 which gcc can warn about.
da053e48 3025 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3026 (RETALLOC_IF): Define only if needed.
3027 (WORDCHAR_P): Likewise. This one is never needed, but is used
3028 only in a comment talking about a compiler bug, so put inside
3029 the #if 0 of that comment.
3030 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3031 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3032 Remove; unused.
19ed5445 3033
1f3561e4 3034 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3035 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3036 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3037
ded6f8f7
PE
3038 * search.c (simple_search): Remove unused var.
3039
dbd37a95
PE
3040 * dired.c (compile_pattern): Move decl from here ...
3041 * lisp.h: ... to here, so that it can be checked.
3042 (struct re_registers): New forward decl.
3043
7e47afad
PE
3044 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3045
85f24f61
PE
3046 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3047 All uses changed.
3048 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3049 Rename locals to avoid shadowing.
5671df8f 3050 (Fvertical_motion): Mark locals as initialized.
85f24f61 3051
181aa2be 3052 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3053 (casify_region): Mark local as initialized.
181aa2be 3054
930d429c
PE
3055 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3056
7082eac6
PE
3057 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3058 New macros, so that the caller can use some names other than
3059 gcpro1, gcpro2, etc.
3060 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3061 of the new macros.
3062 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3063 argument, for consistency with GCPRO2_VAR, etc: it is now the
3064 prefix of the variable, not the variable itself. All uses
3065 changed.
38b2c076
PE
3066 * dired.c (directory_files_internal, file_name_completion):
3067 Rename locals to avoid shadowing.
3068
15206ed9
PE
3069 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3070 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3071 dired.c's scmp function, had undefined behavior.
3072 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3073 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3074 * buffer.h: ... to here, because these macros use current_buffer,
3075 and the new implementation with inline functions needs to have
3076 current_buffer in scope now, rather than later when the macros
3077 are used.
3078 (downcase, upcase1): New static inline functions.
3079 (DOWNCASE, UPCASE1): Reimplement using these functions.
3080 This avoids undefined behavior in expressions like
3081 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3082 from race conditions in accessing the global variables
3083 case_temp1 and case_temp2.
3084 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3085 * lisp.h (case_temp1, case_temp2): Remove their decls.
3086 * character.h (ASCII_CHAR_P): Move from here ...
3087 * lisp.h: ... to here, so that the inline functions mentioned
3088 above can use them.
3089
4a6bea26
PE
3090 * dired.c (directory_files_internal_unwind): Now static.
3091
f14b7e14
PE
3092 * fileio.c (file_name_as_directory, directory_file_name):
3093 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3094 Now static.
2893f146
PE
3095 (file_name_as_directory): Use const pointers when appropriate.
3096 (Fexpand_file_name): Likewise. In particular, newdir might
3097 point at constant storage, so make it a const pointer.
fd4ead52 3098 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3099 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3100 signedness issues.
f839df0c
PE
3101 (Fset_file_times, Finsert_file_contents, auto_save_error):
3102 Rename locals to avoid shadowing.
f14b7e14 3103
5716756e 3104 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3105 (Ftry_completion, Fall_completions): Rename or remove locals
3106 to avoid shadowing.
5716756e 3107
b4c3046a
PE
3108 * marker.c (bytepos_to_charpos): Remove; unused.
3109
b45db522
PE
3110 * lisp.h (verify_bytepos, count_markers): New decls,
3111 so that gcc does not warn that these functions aren't declared.
3112
85876d07
PE
3113 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3114 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3115 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3116 (copy_text): Remove unused local var.
85876d07 3117
03d78a21 3118 * filelock.c (within_one_second): Now static.
b3dd38ab 3119 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3120
5df8f01b
PE
3121 * buffer.c (fix_overlays_before): Mark locals as initialized.
3122 (fix_start_end_in_overlays): Likewise. This function should be
3123 simplified by using pointers-to-pointers, but that's a different
3124 matter.
b1d876f1 3125 (switch_to_buffer_1): Now static.
8f54f30a
PE
3126 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3127 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3128
a70072c9 3129 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3130 Fix pointer signedness issue.
edced198
PE
3131 (sys_subshell): Mark local as volatile if checking for lint,
3132 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3133 (MAXPATHLEN): Define only if needed.
a70072c9 3134
a0977c44
PE
3135 * process.c (serial_open, serial_configure): Move decls from here ...
3136 * systty.h: ... to here, so that they can be checked.
3137
a884fdcc
PE
3138 * fns.c (get_random, seed_random): Move extern decls from here ...
3139 * lisp.h: ... to here, so that they can be checked.
3140
604efe86 3141 * sysdep.c (reset_io): Now static.
b8950c94 3142 (wait_for_termination_signal): Remove; unused.
604efe86 3143
38fc62d9
PE
3144 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3145 (copy_keymap_item, append_key, push_text_char_description):
3146 Now static.
1004a21a 3147 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3148 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3149 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3150 (describe_map_tree):
3151 Rename locals to avoid shadowing.
38fc62d9 3152
2f2650da
PE
3153 * keyboard.c: Declare functions static if they are not used elsewhere.
3154 (echo_char, echo_dash, cmd_error, top_level_2):
3155 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3156 (read_char, kbd_buffer_get_event, make_lispy_position):
3157 (make_lispy_event, make_lispy_movement, apply_modifiers):
3158 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3159 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3160 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3161 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3162 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3163
a053e86c 3164 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3165 (mark_kboards): Move decl here ...
3166 * alloc.c (mark_kboards): ... from here.
a053e86c 3167
4752793e
PE
3168 * lisp.h (force_auto_save_soon): New decl.
3169
74f10ca7 3170 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3171 (DEFINE_DUMMY_FUNCTION): New macro.
3172 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3173 Use it.
c03cd23f
PE
3174 (main): Add casts to avoid warnings
3175 if GCC considers string literals to be constants.
74f10ca7 3176
022e70d4
PE
3177 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3178
59d6fe83
PE
3179 * dbusbind.c: Pointer signedness fixes.
3180 (xd_signature, xd_append_arg, xd_initialize):
3181 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3182 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3183 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3184 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3185
78320123
PE
3186 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3187 if GCC considers string literals to be constants.
49cebcca 3188 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3189
35ac2a97
SM
31902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3191
fb103ca9
SM
3192 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3193 (print_preprocess, print_object): New macro to fix last change.
3194
35ac2a97
SM
3195 * print.c (print_preprocess): Don't forget font objects.
3196
62973b41
JB
31972011-03-16 Juanma Barranquero <lekktu@gmail.com>
3198
3199 * emacs.c (USAGE3): Doc fixes.
3200
0e48bb22
AS
32012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3202
3203 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3204 structure.
3205
7684e57b
JB
32062011-03-14 Juanma Barranquero <lekktu@gmail.com>
3207
3208 * lisp.h (VWindow_system, Qfile_name_history):
3209 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3210 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3211 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3212
3213 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3214 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3215
3216 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3217 * w32console.c (detect_input_pending, read_input_pending)
3218 (encode_terminal_code):
3219 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3220 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3221 (w32_system_caret_y, Qfile_name_history):
3222 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3223 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3224 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3225 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3226 * w32proc.c (Qlocal, report_file_error):
3227 * w32term.c (Vwindow_system, updating_frame):
3228 * w32uniscribe.c (initialized, uniscribe_font_driver):
3229 Remove unneeded extern declarations.
3230
2aa46d6c
CY
32312011-03-14 Chong Yidong <cyd@stupidchicken.com>
3232
c96bbc66 3233 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3234
cffc6f3b
CY
32352011-03-13 Chong Yidong <cyd@stupidchicken.com>
3236
3237 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3238 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3239 These macros can no longer be used for assignment.
3240
44f230aa
SM
3241 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3242 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3243 (record_buffer_markers, fetch_buffer_markers): New functions for
3244 recording and fetching special buffer markers.
3245 (set_buffer_internal_1, set_buffer_temp): Use them.
3246
3247 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3248
3249 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3250
3251 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3252 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3253
3254 * xdisp.c (hscroll_window_tree):
3255 (reconsider_clip_changes): Use PT instead of BUF_PT.
3256
d251f04b
EZ
32572011-03-13 Eli Zaretskii <eliz@gnu.org>
3258
3259 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3260 $(EMACS_ROOT)/lib/intprops.h.
3261
f0c77cd1
PE
32622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3263
3eca4629
PE
3264 Fix more problems found by GCC 4.5.2's static checks.
3265
7c86ee98
PE
3266 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3267 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3268 (xg_free_frame_widgets): Make it clear that a local variable is
3269 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3270 (gdk_window_get_screen): Make it clear that this macro is needed
3271 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3272 (int_gtk_range_get_value): New function, which avoids a diagnostic
3273 from gcc -Wbad-function-cast.
3274 (xg_set_toolkit_scroll_bar_thumb): Use it.
3275 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3276 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3277 (get_utf8_string, xg_get_file_with_chooser):
3278 Rename locals to avoid shadowing.
3279 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3280
41729b81
PE
3281 * xgselect.c (xg_select): Remove unused var.
3282
f0c77cd1
PE
3283 * image.c (four_corners_best): Mark locals as initialized.
3284 (gif_load): Initialize transparent_p to zero (Bug#8238).
3285 Mark another local as initialized.
ec6cf4c6 3286 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3287
ce0ad53d 3288 * image.c (clear_image_cache): Now static.
d5d5a617 3289 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3290 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3291 (x_edge_detection): Remove unnecessary cast that
3292 gcc -Wbad-function-cast diagnoses.
2037898d 3293 (gif_load): Fix pointer signedness.
6ae141d6
PE
3294 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3295 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3296
33383987 32972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3298
d32df629
PE
3299 Improve quality of tests for time stamp overflow.
3300 For example, without this patch (encode-time 0 0 0 1 1
3301 1152921504606846976) returns the obviously-bogus value (-948597
3302 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3303 reports time overflow. See
3304 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3305 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3306 * editfns.c: Include limits.h and intprops.h.
3307 (TIME_T_MIN, TIME_T_MAX): New macros.
3308 (time_overflow): Move earlier, to before first use.
3309 (hi_time, lo_time): New functions, for an accurate test for
3310 out-of-range times.
3311 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3312 (Fget_internal_run_time): Don't assume time_t fits in int.
3313 (make_time): Use list2 instead of Fcons twice.
3314 (Fdecode_time): More accurate test for out-of-range times.
3315 (check_tm_member): New function.
3316 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3317 (lisp_time_argument): Don't rely on undefined left-shift and
3318 right-shift behavior when checking for time stamp overflow.
8be6f318 3319
fe31d94c
PE
3320 * editfns.c (time_overflow): New function, refactoring common code.
3321 (Fformat_time_string, Fdecode_time, Fencode_time):
3322 (Fcurrent_time_string): Use it.
3323
8be6f318
PE
3324 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3325 * dired.c (make_time): Move to ...
3326 * editfns.c (make_time): ... here.
3327 * systime.h: Note the move.
3328
09d9db2c 33292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3330
126bc0dc
YM
3331 * fringe.c (update_window_fringes): Remove unused variables.
3332
c47cbdfd
YM
3333 * unexmacosx.c (copy_data_segment): Also copy __got section.
3334 (Bug#8223)
3335
7ac80be9
EZ
33362011-03-12 Eli Zaretskii <eliz@gnu.org>
3337
c96bbc66 3338 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3339 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3340 Constify `char *' arguments and their references according to
3341 prototypes in tparam.h.
3342
ecb0f94d 3343 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3344
7ac80be9
EZ
3345 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3346 Adapt all references accordingly.
3347
3348 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3349
ef1fd07e
TT
33502011-03-11 Tom Tromey <tromey@redhat.com>
3351
3352 * buffer.c (syms_of_buffer): Remove obsolete comment.
3353
7ef4b50c
EZ
33542011-03-11 Eli Zaretskii <eliz@gnu.org>
3355
3356 * termhooks.h (encode_terminal_code): Declare prototype.
3357
3358 * msdos.c (encode_terminal_code): Don't declare prototype.
3359
3360 * term.c (encode_terminal_code): Now external again, used by
3361 w32console.c and msdos.c.
3362
44f230aa
SM
3363 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3364 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3365
4b1ec863 33662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3367
1714f52b 3368 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3369
4b1ec863
PE
3370 * fringe.c (update_window_fringes): Mark locals as initialized
3371 (Bug#8227).
3372 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3373
524c7aa6
PE
3374 * alloc.c (mark_fringe_data): Move decl from here ...
3375 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3376 to check its interface.
3377 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3378
a5c0af81 3379 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3380 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3381 (fontset_font): Mark local as initialized.
a9a06e0b 3382 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3383
b4716021
PE
3384 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3385
811e9bac 3386 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3387 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3388 (x_own_selection, Fx_disown_selection_internal): Rename locals
3389 to avoid shadowing.
3390 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3391
7e3ab302
PE
3392 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3393 so that the caller can use some name other than gcpro1.
3394 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3395 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3396 (Fx_backspace_delete_keys_p):
3397 Use them to avoid shadowing, and rename vars to avoid shadowing.
3398 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3399 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3400 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3401 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3402 Remove unused locals.
7e3ab302
PE
3403 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3404 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3405 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3406 macros.
f78faa98 3407
e2b13473
PE
3408 * xterm.h (x_mouse_leave): New decl.
3409
77f23912
PE
3410 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3411 Remove unused functions.
cdf4ba58
PE
3412 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3413 (x_calc_absolute_position): Now static.
7411c686 3414 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3415 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3416 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3417 unless they are used.
38d0b34a
PE
3418 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3419 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3420 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3421 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3422 (x_error_catcher, x_connection_closed, x_error_handler):
3423 (x_error_quitter, xembed_send_message, x_iconify_frame):
3424 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3425 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3426 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3427
44f230aa
SM
3428 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3429 Rename or move locals to avoid shadowing.
6b463e58 3430 (tty_defined_color, merge_face_heights): Now static.
5967d051 3431 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3432 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3433 does not deduce is never used uninitialized.
73719eba
PE
3434 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3435 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3436
426994c3 3437 * terminal.c (store_terminal_param): Now static.
5489860b 3438
032f1620 3439 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3440 (set_frame_menubar): Remove unused local.
d4323972 3441 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3442 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3443 since they might point to immutable storage.
281585b0
PE
3444 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3445 since it's unused otherwise.
032f1620 3446
367c19e5 3447 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3448 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3449 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3450 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3451 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3452 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3453 does not deduce are never used uninitialized.
70739cbe 3454
07b48fa9
PE
3455 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3456
8868a238 3457 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3458 * window.c (window_loop, size_window):
3459 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3460
7e5cf297 3461 * window.c (display_buffer): Now static.
d6550a9f
PE
3462 (size_window): Mark variables that gcc -Wuninitialized
3463 does not deduce are never used uninitialized.
a586633d
PE
3464 * window.h (check_all_windows): New decl, to forestall
3465 gcc -Wmissing-prototypes diagnostic.
5b555da1 3466 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3467
f6095868
PE
3468 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3469 shadowing.
3470 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3471 Include <limits.h>.
3472 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3473 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3474 (load_charset_map): Mark variables that gcc -Wuninitialized
3475 does not deduce are never used uninitialized.
53df7c11 3476 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3477
f38b440c
PE
3478 * coding.c (coding_set_source, coding_set_destination):
3479 Use "else { /* comment */ }" rather than "else /* comment */;"
3480 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3481 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3482 a block, when the outer 'i' will do.
3483 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3484 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3485 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3486 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3487 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3488 Rename locals to avoid shadowing.
3489 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3490 * coding.c (emacs_mule_char, encode_invocation_designation):
3491 Now static, since they're not used elsewhere.
413bb2db 3492 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3493 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3494 (decode_coding_emacs_mule): Mark variables that gcc
3495 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3496 (detect_coding_iso_2022): Initialize a local variable that might
3497 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3498 this initialization is needed. (Bug#8211)
5f58e762
PE
3499 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3500 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3501 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3502 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3503 Remove unused macros.
f38b440c 3504
232b38b9 3505 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3506 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3507 * character.c (string_count_byte8): Likewise.
232b38b9 3508
fb90da1b
PE
3509 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3510 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3511
fb93dbc2
PE
3512 * chartab.c (copy_sub_char_table): Now static, since it's not used
3513 elsewhere.
5c156ace
PE
3514 (sub_char_table_ref_and_range, char_table_ref_and_range):
3515 Rename locals to avoid shadowing.
bbcd0949 3516 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3517
7d3b3862 3518 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3519 (BIDI_BOB): Remove unused macro.
7d3b3862 3520
6be7d3da
PE
3521 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3522 deduce are never used uninitialized.
c2ed9c8b 3523 * term.c (encode_terminal_code): Likewise.
6be7d3da 3524
75f8807f 3525 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3526
50938595
PE
3527 * tparam.h: New file.
3528 * term.c, tparam.h: Include it.
3529 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3530 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3531 Move these decls to tparam.h, and make them agree with what
3532 is actually in tparam.c. The previous trick of using incompatible
3533 decls in different modules does not conform to the C standard.
3534 All callers of tparam changed to use tparam's actual API.
3535 * tparam.c (tparam1, tparam, tgoto):
3536 Use const pointers where appropriate.
3537
fbceeba2
PE
3538 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3539 * cm.h (struct cm): Likewise.
3540 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3541 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3542 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3543 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3544 (turn_on_face, init_tty): Likewise.
3545 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3546
7f3f1250
PE
3547 * term.c (term_mouse_position): Rename local to avoid shadowing.
3548
e6ca6543
PE
3549 * alloc.c (mark_ttys): Move decl from here ...
3550 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3551
c40f8d15
AS
35522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3553
3554 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3555
cfe0661d
JB
35562011-03-09 Juanma Barranquero <lekktu@gmail.com>
3557
3558 * search.c (compile_pattern_1): Remove argument regp, unused since
3559 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3560 (compile_pattern): Don't pass it.
3561
0afb4571
J
35622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3563
3564 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3565 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3566 for ! HAVE_GTK3.
3567 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3568
3569 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3570
3571 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3572 gdk_window_get_screen, gdk_window_get_geometry,
3573 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3574 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3575 (xg_get_pixbuf_from_pixmap): New function.
3576 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3577 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3578 Call xg_get_pixbuf_from_pixmap instead of
3579 gdk_pixbuf_get_from_drawable.
3580 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3581 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3582 (xg_check_special_colors): Use GtkStyleContext and its functions
3583 for HAVE_GTK3.
3584 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3585 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3586 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3587 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3588 Call gtk_widget_get_preferred_size.
0afb4571
J
3589 (xg_frame_resized): gdk_window_get_geometry only takes 5
3590 parameters.
44f230aa
SM
3591 (xg_win_to_widget, xg_event_is_for_menubar):
3592 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3593 (xg_set_widget_bg): New function.
3594 (delete_cb): New function.
895009e1 3595 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3596 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3597 (xg_set_background_color): Call xg_set_widget_bg.
3598 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3599 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3600 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3601 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3602 if ! HAVE_GTK3.
3603 (update_frame_tool_bar): Call gtk_widget_hide.
3604 (xg_initialize): Use GDK_KEY_g.
3605
3606 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3607 if ! HAVE_GTK3
3608 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3609
3610 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3611 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3612 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3613
1c2cc4ef
JB
36142011-03-08 Juanma Barranquero <lekktu@gmail.com>
3615
3616 * w32xfns.c (select_palette): Check success of RealizePalette against
3617 GDI_ERROR, not zero.
3618
33383987 3619See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3620
3621;; Local Variables:
3622;; coding: utf-8
aac0c6e3
MR
3623;; End:
3624
33383987 3625 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3626
3627 This file is part of GNU Emacs.
3628
3629 GNU Emacs is free software: you can redistribute it and/or modify
3630 it under the terms of the GNU General Public License as published by
3631 the Free Software Foundation, either version 3 of the License, or
3632 (at your option) any later version.
3633
3634 GNU Emacs is distributed in the hope that it will be useful,
3635 but WITHOUT ANY WARRANTY; without even the implied warranty of
3636 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3637 GNU General Public License for more details.
3638
3639 You should have received a copy of the GNU General Public License
3640 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.