Reset sys to nil in define-abbrevs
[bpt/emacs.git] / src / ChangeLog
CommitLineData
27f3c637
PE
12012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2
3 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4 Suggested by Stefan Monnier in
5 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6 * alloc.c (widen_to_Lisp_Object): New static function.
7 (mark_memory): Also mark Lisp_Objects by fetching pointer words
8 and widening them to Lisp_Objects. This would work even if
9 USE_LSB_TAG is defined and wide integers are used, which might
10 happen in a future version of Emacs.
11
3c9dfce6
CY
122012-02-25 Chong Yidong <cyd@gnu.org>
13
fa74b241
CY
14 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
15 Doc fix.
16
3c9dfce6
CY
17 * xselect.c (Fx_selection_exists_p): Doc fix.
18 (x_clipboard_manager_save_all): Print an informative message
19 before saving to clipboard manager.
20
9486df08
CY
212012-02-24 Chong Yidong <cyd@gnu.org>
22
23 * keyboard.c (process_special_events): Handle all X selection
24 requests in kbd_buffer, not just the next one (Bug#8869).
25
f01d3321
CY
262012-02-23 Chong Yidong <cyd@gnu.org>
27
28 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
29 call when setting menu-bar-lines and tool-bar-lines parameters.
30 (unwind_create_frame_1): New helper function.
31
32 * window.c (inhibit_window_configuration_change_hook): New var.
33 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 34 (syms_of_window): Initialize it.
f01d3321 35
86b847b6
CY
362012-02-22 Chong Yidong <cyd@gnu.org>
37
38 * xterm.c (x_draw_image_relief): Add missing type check for
39 Vtool_bar_button_margin (Bug#10743).
40
a59225b1
CY
412012-02-21 Chong Yidong <cyd@gnu.org>
42
43 * fileio.c (Vfile_name_handler_alist): Doc fix.
44
45 * buffer.c (Fget_file_buffer): Protect against invalid file
46 handler return value.
47
310f5bd4
PE
482012-02-20 Paul Eggert <eggert@cs.ucla.edu>
49
cb3a28cc
PE
50 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
51 when computing $valmask.
52
310f5bd4
PE
53 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
54 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
55 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
56 It's useless in that case, and it can cause problems on hosts
57 that allocate halves of EMACS_INT values separately.
58 Reported by Dan Horák. Diagnosed by Andreas Schwab in
59 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
60 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
61 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
62 it avoids undefined behavior on hosts where shifting right by more
63 than the word width has undefined behavior.
64
2375c96a
CY
652012-02-19 Chong Yidong <cyd@gnu.org>
66
67 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
68 (Funhandled_file_name_directory, Ffile_name_as_directory)
69 (Fdirectory_file_name, Fexpand_file_name)
70 (Fsubstitute_in_file_name): Protect against invalid file handler
71 return values (Bug#10845).
72
3eb49e71
EZ
732012-02-18 Eli Zaretskii <eliz@gnu.org>
74
75 * .gdbinit (pitx): Fix incorrect references to fields of the
76 iterator stack.
77
7b926f3f
CY
782012-02-17 Chong Yidong <cyd@gnu.org>
79
80 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
81
11273115
PE
822012-02-15 Paul Eggert <eggert@cs.ucla.edu>
83
84 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
85 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
86
c3a70e2b
CY
872012-02-15 Chong Yidong <cyd@gnu.org>
88
89 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
90 marked as special. Also, starting docstrings with * is obsolete.
91
0ca43699
AS
922012-02-13 Andreas Schwab <schwab@linux-m68k.org>
93
94 * gnutls.c (emacs_gnutls_write): Fix last change.
95
2e8f3c56
LI
962012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
97
98 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
99 send_process.
100
af70074f
SM
1012012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
102
103 * keymap.c (Fsingle_key_description): Handle char ranges.
104
95986d52
CY
1052012-02-12 Chong Yidong <cyd@gnu.org>
106
afd83bd1
CY
107 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
108 as that creates a dangerous corner case.
109
95986d52
CY
110 * window.c (Fdelete_window_internal): Invalidate the mouse
111 highlight (Bug#9904).
112
bd7da63e
GM
1132012-02-12 Glenn Morris <rgm@gnu.org>
114
115 * xselect.c (Fx_own_selection_internal)
116 (Fx_get_selection_internal, Fx_disown_selection_internal)
117 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
118 * nsselect.m (Fx_own_selection_internal)
119 (Fx_disown_selection_internal, Fx_selection_exists_p)
120 (Fx_selection_owner_p, Fx_get_selection_internal):
121 Sync docs and argument specs with the xselect.c versions.
122
77abcbc2
LI
1232012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
124
125 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
126
90b671e2
EZ
1272012-02-11 Eli Zaretskii <eliz@gnu.org>
128
1c0ca0b7
EZ
129 * w32select.c (Fx_selection_exists_p): Sync doc string and
130 argument list with xselect.c. (Bug#10783)
131
132 * w16select.c (Fx_selection_exists_p): Sync doc string and
133 argument list with xselect.c. (Bug#10783)
90b671e2 134
49241268
GM
1352012-02-10 Glenn Morris <rgm@gnu.org>
136
137 * fns.c (Fsecure_hash): Doc fix.
138
f998bbe7 1392012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
140
141 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
142
0992bd9c
CY
1432012-02-07 Chong Yidong <cyd@gnu.org>
144
145 * buffer.c (Fbuffer_local_variables)
146 (buffer_lisp_local_variables): Handle unbound vars correctly;
147 don't let Qunbound leak into Lisp.
148
af008560
GM
1492012-02-07 Glenn Morris <rgm@gnu.org>
150
dd605cc4
GM
151 * image.c (Fimagemagick_types): Doc fix.
152
af008560
GM
153 * image.c (imagemagick-render-type): Change it from a lisp object
154 to an integer. Move the doc here from the lisp manual.
155 Treat all values not equal to 0 the same.
156
1449fa1d
CY
1572012-02-06 Chong Yidong <cyd@gnu.org>
158
159 * doc.c (store_function_docstring): Avoid applying docstring of
160 alias to base function (Bug#2603).
161
3723ec07
AS
1622012-02-04 Andreas Schwab <schwab@linux-m68k.org>
163
164 * .gdbinit (pp1, pv1): Remove redundant defines.
165 (pr): Use pp.
166
79c1cc1e
CY
1672012-02-04 Chong Yidong <cyd@gnu.org>
168
169 * nsterm.m: Declare a global (Bug#10694).
170
d7f29f8e
EZ
1712012-02-04 Eli Zaretskii <eliz@gnu.org>
172
173 * w32.c (get_emacs_configuration_options): Include
174 --enable-checking, if specified, in the return value.
175
3b95a6f9
MR
1762012-02-04 Martin Rudalics <rudalics@gmx.at>
177
178 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
179 after rounding frame sizes. (Bug#9723)
180
d6fa96a6
EZ
1812012-02-04 Eli Zaretskii <eliz@gnu.org>
182
183 * keyboard.c (adjust_point_for_property): Don't position point
184 before BEGV. (Bug#10696)
185
df0b2940
PE
1862012-02-03 Paul Eggert <eggert@cs.ucla.edu>
187
188 Handle overflow when computing char display width (Bug#9496).
189 * character.c (char_width): Return EMACS_INT, not int.
190 (char_width, c_string_width): Check for overflow when
191 computing the width; this is possible now that individual
192 characters can have unbounded width. Problem introduced
193 by merge from Emacs 23 on 2012-01-19.
194
6bee44d6
MA
1952012-02-02 Michael Albinus <michael.albinus@gmx.de>
196
197 * dbusbind.c (Fdbus_register_method): Mention the return value
198 :ignore in the docstring.
199
44f92739
GM
2002012-02-02 Glenn Morris <rgm@gnu.org>
201
1b9f60cc
GM
202 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
203
44f92739
GM
204 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
205 Unconditionally set to t. (Bug#10673)
206 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
207 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
208 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
209
c5d3843c
KH
2102012-02-02 Kenichi Handa <handa@m17n.org>
211
212 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
213 0, do not call append_composite_glyph.
214
159462d4 2152012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
216
217 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
218 NULL (Bug#6988).
219 (x_produce_glyphs): If the component of a composition is a null
220 string, set it->pixel_width to 1 to avoid zero-width glyph.
221
78cef877
EZ
2222012-02-01 Eli Zaretskii <eliz@gnu.org>
223
224 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
225 first 2 arguments are identical. This makes inserting large
226 output from a subprocess an order of magnitude faster on
227 MS-Windows, where all sbrk'ed memory is always contiguous.
228
97897668
GM
2292012-01-31 Glenn Morris <rgm@gnu.org>
230
231 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 232 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
233 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
234
31fd3586
GM
2352012-01-29 Glenn Morris <rgm@gnu.org>
236
237 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
238
0e24a8b2
CY
2392012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
240
241 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
242
cc0adcb0
CY
2432012-01-28 Chong Yidong <cyd@gnu.org>
244
245 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
246
acc28cb9
CY
2472012-01-26 Chong Yidong <cyd@gnu.org>
248
9c69cfb7
CY
249 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
250
acc28cb9
CY
251 * search.c (Fsearch_forward, Fsearch_backward): Document negative
252 repeat counts (Bug#10507).
253
48da7392
GM
2542012-01-26 Glenn Morris <rgm@gnu.org>
255
256 * lread.c (syms_of_lread): Doc fix.
257
14af5f7f
CY
2582012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
259
260 * coding.c (encode_designation_at_bol): Change return value to
261 EMACS_INT.
262
0b21c100
CY
2632012-01-25 Chong Yidong <cyd@gnu.org>
264
265 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
266
3c2907f7
CY
2672012-01-21 Chong Yidong <cyd@gnu.org>
268
269 * floatfns.c (Fcopysign): Make the second argument non-optional,
270 since nil is not allowed anyway.
271
959ad23f
AS
2722012-01-21 Andreas Schwab <schwab@linux-m68k.org>
273
274 * process.c (read_process_output): Use p instead of XPROCESS (proc).
275 (send_process): Likewise.
276
34a02f46
MR
2772012-01-19 Martin Rudalics <rudalics@gmx.at>
278
279 * window.c (save_window_save, Fcurrent_window_configuration)
280 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
281 doc-strings.
282
1259009a 2832012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
284
285 * character.c (char_width): New function.
70d4fdf6
GM
286 (Fchar_width, c_string_width, lisp_string_width):
287 Use char_width (Bug#9496).
25ed9e61 288
6a6ee00d
MR
2892012-01-16 Martin Rudalics <rudalics@gmx.at>
290
291 * window.c (Vwindow_persistent_parameters): New variable.
292 (Fset_window_configuration, save_window_save): Handle persistent
293 window parameters.
294
c85efaf7
EZ
2952012-01-14 Eli Zaretskii <eliz@gnu.org>
296
297 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
298 thrashing the stack of the thread. (Bug#9087)
299
5944709e
PE
3002012-01-12 Paul Eggert <eggert@cs.ucla.edu>
301
302 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
303
e71f5d99
EZ
3042012-01-11 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (rows_from_pos_range): Handle the case where the
307 highlight ends on a newline. (Bug#10464)
308 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
309 he end column for display of highlight that ends on a newline
310 before a R2L line.
311
ce316182
GM
3122012-01-11 Glenn Morris <rgm@gnu.org>
313
314 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
315 from load-path also when installation-directory is nil. (Bug#10208)
316
5b43da69
GM
3172012-01-10 Glenn Morris <rgm@gnu.org>
318
74cc8ff9
GM
319 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
320
7d8d6e4e
GM
321 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
322 Update template values to be closer to their typical values these days.
5b43da69 323
a0db8d43
EZ
3242012-01-09 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (rows_from_pos_range): Accept additional argument
327 DISP_STRING, and accept any glyph in a row whose object is that
328 string as eligible for mouse highlight. Fixes mouse highlight of
329 display strings from overlays. (Bug#10464)
330
9a0115ab 3312012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 332
b9110d6a 333 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
334 * fileio.c (auto_saving_dir_umask): New static var.
335 (Fmake_directory_internal): Use it.
336 (do_auto_save_make_dir): Set it, instead of invoking chmod after
337 creating the directory. The old code temporarily assigns
338 too-generous permissions to the directory.
339 (do_auto_save_eh): Clear it.
b9110d6a 340 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
341 that the var is always cleared.
342
6c1bd3f3
EZ
3432012-01-07 Eli Zaretskii <eliz@gnu.org>
344
345 * search.c (scan_buffer): Pass character positions to
346 know_region_cache, not byte positions. (Bug#6540)
347
069d2b50
L
3482012-01-07 LynX <_LynX@bk.ru> (tiny change)
349
350 * w32.c (sys_rename): Report EXDEV when rename of a directory
351 fails because the target is on another logical disk. (Bug#10284)
352
75bf0d33
DB
3532012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
354
355 * xterm.c (x_embed_request_focus): New function.
356
357 * xterm.h: Add prototype.
358
359 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
360
1c6e5a32
GM
3612012-01-05 Glenn Morris <rgm@gnu.org>
362
363 * emacs.c (emacs_copyright): Update short copyright year to 2012.
364
651e947e
EZ
3652012-01-01 Eli Zaretskii <eliz@gnu.org>
366
367 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
368 Load gnutls_transport_set_lowat only if GnuTLS version is below
369 2.11.1.
370 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
371 GnuTLS versions below 2.11.1.
372
3778cdd8
AL
3732011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
374
375 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
376 to the doc string advising against its use for altering the way
377 windows are scrolled.
378
0e5317f7
KH
3792011-12-28 Kenichi Handa <handa@m17n.org>
380
381 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
382 coding-system ASCII compatible only when it does not produce BOM
383 on encoding (Bug#10383).
384
93d5ca1f
JD
3852011-12-26 Jan Djärv <jan.h.d@swipnet.se>
386
387 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
388 can scroll.
389 (create_and_show_popup_menu): Always use menu_position_func for
390 Gtk3 (Bug#10361).
391
ca22b785
AS
3922011-12-24 Andreas Schwab <schwab@linux-m68k.org>
393
394 * callint.c (Fcall_interactively): Don't truncate prompt string.
395
d048e1e6
EZ
3962011-12-23 Eli Zaretskii <eliz@gnu.org>
397
398 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
399 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 400 resumed from there (after widening). (Bug#10360)
d048e1e6 401
5ccaba1f
JD
4022011-12-22 Jan Djärv <jan.h.d@swipnet.se>
403
404 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
405
204ee57f
JD
4062011-12-21 Jan Djärv <jan.h.d@swipnet.se>
407
b81d40f0
JB
408 * nsterm.m (x_free_frame_resources):
409 Release f->output_data.ns->miniimage.
204ee57f
JD
410 (ns_index_color): Fix indentation. Do not retain
411 color_table->colors[i].
412
413 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
414 before returning.
415
416 * nsfns.m (x_set_background_color): Assign return value from
417 ns_index_color to face-background instead of NSColor*.
418 (ns_implicitly_set_icon_type): Fix indentation.
419 Change assignment in for loop to comparison.
420
421 * emacs.c (ns_pool): New variable.
422 (main): Assign ns_pool.
423 (Fkill_emacs): Call ns_release_autorelease_pool.
424
425 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
426 autorelease fdesc, release fdAttrs and tdict.
427 (ns_get_covering_families): Release charset.
428 (ns_findfonts): Release NSFontDescriptor created with new.
429 (ns_uni_to_glyphs): Fix indentation.
430 (setString): Release attrStr before assigning new value.
431
c803b2b7
JD
4322011-12-18 Jan Djärv <jan.h.d@swipnet.se>
433
678f4426
JD
434 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
435 and NS_IMPL_COCOA.
436 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
437 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
438
cd394be1 4392011-12-18 David Reitter <reitter@cmu.edu>
678f4426 440
5fecd5fc
JD
441 * nsterm.m (ns_term_init): Subscribe for notifications
442 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
443 to method trackingNotification in EmacsMenu.
444
445 * nsmenu.m (trackingMenu): New variable.
3771cb17 446 (trackingNotification): New method (from Aquamacs).
5fecd5fc 447 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 448 from Aquamacs (Bug#7030).
678f4426
JD
449
4502011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 451
c803b2b7
JD
452 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
453 (symbol_to_nsstring): Fix indentation.
454 (ns_symbol_to_pb): New function.
455 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
456 (Fns_rotate_cut_buffers_internal): Removed.
457 (Fns_store_selection_internal): Renamed from
458 Fns_store_cut_buffer_internal.
459 (ns_get_foreign_selection, Fx_own_selection_internal)
460 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
461 (Fns_get_selection_internal, Fns_store_selection_internal):
462 Use ns_symbol_to_pb and check if return value is nil.
463 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
464 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
465 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
466 renamed to Sns_store_selection_internal.
467 (ns_handle_selection_request): Move code to Fx_own_selection_internal
468 and remove this function.
469 (ns_handle_selection_clear): Remove, never used.
470 (Fx_own_selection_internal): Move code from ns_handle_selection_request
471 here.
472
e1b01a3a
KB
4732011-12-17 Ken Brown <kbrown@cornell.edu>
474
475 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
476 GID is unknown (Bug#10257).
477
2adb6e85
PE
4782011-12-17 Paul Eggert <eggert@cs.ucla.edu>
479
480 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
481 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
482 which caused a build failure on GNU/Linux IA-64. This problem was
483 introduced by my 2011-10-07 patch.
484
d1d7b339
JL
4852011-12-15 Juri Linkov <juri@jurta.org>
486
487 * image.c (imagemagick_error): New function. (Bug#10112)
488 (imagemagick_load_image): Comment out `MagickSetResolution' call.
489 Use `imagemagick_error' where ImageMagick functions return
490 `MagickFalse'.
491 (Fimagemagick_types): Add `Fnreverse' to return the list in the
492 proper order.
493
100d5755
KH
4942011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
495
496 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
497 fill background (Bug#8992).
498
454592a6
MR
4992011-12-13 Martin Rudalics <rudalics@gmx.at>
500
501 * window.c (Vwindow_combination_resize)
502 (Vwindow_combination_limit): Use t instead of non-nil in
503 doc-strings.
61d4b438
MR
504 (Vrecenter_redisplay): Add first sentence of doc-string on
505 separate line.
53524d93 506 (Frecenter): Fix doc-string typo.
454592a6 507
3633e3aa
KH
5082011-12-11 Kenichi Handa <handa@m17n.org>
509
510 * coding.c (Funencodable_char_position): Pay attention to the
511 buffer text relocation (Bug#9389).
512
7b9d523a
JD
5132011-12-10 Jan Djärv <jan.h.d@swipnet.se>
514
515 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
516 gtk_init (Bug#10100).
517
b73189c6
EZ
5182011-12-10 Eli Zaretskii <eliz@gnu.org>
519
520 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
521 IT->string is nil. (Bug#10263)
522
f7dfe5d6
JD
5232011-12-10 Jan Djärv <jan.h.d@swipnet.se>
524
83faebb4
JD
525 * nsterm.h (x_free_frame_resources): Declare.
526
f7dfe5d6
JD
527 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
528 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
529
530 * nsterm.h (ns_get_defaults_value): Declare.
531
532 * nsterm.m (ns_default): Call ns_get_defaults_value.
533
7cd4e72c
EZ
5342011-12-09 Eli Zaretskii <eliz@gnu.org>
535
536 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
537 (Bug#10170)
538
b34d7317
YM
5392011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
540
541 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
542 that where the value of an _OBJC_* symbol points to is in the .bss
543 section (Bug#10240).
544
76470ad1
KH
5452011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
546
547 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 548 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 549
745fff94
KH
5502011-12-08 Kenichi Handa <handa@m17n.org>
551
552 * ftfont.c (get_adstyle_property): Fix previous change
553 (Bug#10233).
554
6e44397c
JB
5552011-12-07 Juanma Barranquero <lekktu@gmail.com>
556
557 * w32.c (init_environment): If no_site_lisp, remove site-lisp
558 dirs from the default value of EMACSLOADPATH (bug#10208).
559
7efa6272
GM
5602011-12-07 Glenn Morris <rgm@gnu.org>
561
562 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
563 installation and source directories as well. (Bug#10208)
564
f6fc4d87
CY
5652011-12-06 Chong Yidong <cyd@gnu.org>
566
567 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
568
2bf26180
GM
5692011-12-06 Glenn Morris <rgm@gnu.org>
570
571 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
572 as an error, not just -1. (Bug#10217)
573
3a6ad4f0
CY
5742011-12-05 Chong Yidong <cyd@gnu.org>
575
576 * keyboard.c (process_special_events): New function.
577 (swallow_events, Finput_pending_p): Use it (Bug#10195).
578
75a3b399
PE
5792011-12-05 Paul Eggert <eggert@cs.ucla.edu>
580
581 * coding.c (encode_designation_at_bol): Don't use uninitialized
582 local variable (Bug#9318).
583
c3c9e25e
KH
5842011-12-05 Kenichi Handa <handa@m17n.org>
585
586 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
587 return Qnil (Bug#8046, Bug#10193).
588
5eb05ea3
KH
5892011-12-05 Kenichi Handa <handa@m17n.org>
590
591 * coding.c (encode_designation_at_bol): New args charbuf_end and
592 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
593 (coding_set_source): Return how many bytes coding->source was
594 relocated.
595 (coding_set_destination): Return how many bytes
596 coding->destination was relocated.
597 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
598 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
599
6002011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
601
602 * coding.c (CODING_CHAR_CHARSET_P): New macro.
603 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
604 macro (Bug#9318).
605
6062011-12-05 Andreas Schwab <schwab@linux-m68k.org>
607
608 The following changes are to fix Bug#9318.
609
a79703f5 610 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
611 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
612 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 613 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 614
7dbda6df
JB
6152011-12-05 Juanma Barranquero <lekktu@gmail.com>
616
617 * lisp.h (process_quit_flag): Fix external declaration.
618
6d5eb5b0
SM
6192011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
620
621 Don't macro-inline non-performance-critical code.
622 * eval.c (process_quit_flag): New function.
623 * lisp.h (QUIT): Use it.
624
a0c3fad0
JD
6252011-12-04 Jan Djärv <jan.h.d@swipnet.se>
626
627 * nsfns.m (get_geometry_from_preferences): New function.
628 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
629
6c07aac2
AS
6302011-12-04 Andreas Schwab <schwab@linux-m68k.org>
631
632 * emacs.c (Qkill_emacs): Define.
633 (syms_of_emacs): Initialize it.
634 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
635 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
636 (quit_throw_to_read_char): Add parameter `from_signal'.
637 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
638 * lisp.h (QUIT): Call Fkill_emacs if requested.
639
c052ead4
JD
6402011-12-03 Jan Djärv <jan.h.d@swipnet.se>
641
642 * widget.c (update_wm_hints): Return if wmshell is null.
643 (widget_update_wm_size_hints): New function.
644
645 * widget.h (widget_update_wm_size_hints): Declare.
646
647 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
648 widget_update_wm_size_hints (Bug#10104).
649
9e49252b
EZ
6502011-12-03 Eli Zaretskii <eliz@gnu.org>
651
652 * xdisp.c (handle_invisible_prop): If the invisible text ends just
653 before a newline, prepare the bidi iterator for consuming the
654 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 655 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 656
02b16839
JL
6572011-12-02 Juri Linkov <juri@jurta.org>
658
659 * search.c (Fword_search_regexp): New Lisp function created from
660 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
661 (Fword_search_backward, Fword_search_forward)
662 (Fword_search_backward_lax, Fword_search_forward_lax):
663 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
664 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
665
0068070e
SM
6662011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
667
668 * fileio.c (Finsert_file_contents): Move after-change-function call
669 to before the "handled:" label, since all "goto handled" appear in
670 cases where the *-change-functions have already been properly called
671 (bug#10117).
672
3360a3fc
AS
6732011-12-01 Andreas Schwab <schwab@linux-m68k.org>
674
675 * keyboard.c (interrupt_signal): Don't call kill-emacs when
676 waiting for input. (Bug#10169)
677
73d6c093
EZ
6782011-11-30 Eli Zaretskii <eliz@gnu.org>
679
680 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
681 verifies glyph row's hash code--we have just reallocated the
682 glyphs, so their contents can be complete garbage. (Bug#10164)
683
febe6bea
JB
6842011-11-30 Juanma Barranquero <lekktu@gmail.com>
685
686 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
687
801a4313
EZ
6882011-11-30 Eli Zaretskii <eliz@gnu.org>
689
690 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
691 attributes are tested _before_ calling verify_row_hash, to protect
692 against GCC re-ordering of the tests. (Bug#10164)
693
2b56b87e
JD
6942011-11-29 Jan Djärv <jan.h.d@swipnet.se>
695
696 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
697
698 * xterm.c (handle_one_xevent): Only set async_visible and friends
699 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 700 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
701 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
702
dbf31225
PE
7032011-11-28 Paul Eggert <eggert@cs.ucla.edu>
704
705 Remove GCPRO-related macros that exist only to avoid shadowing locals.
706 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
707 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
708 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
709 All uses changed to use GCPRO1 etc.
710 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
711 Revert to old implementation (i.e., before 2011-03-11).
712
1305621b
YM
7132011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
714
715 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
716 of scroll runs so as to avoid assigning disabled bogus rows and
717 unnecessary graphics copy operations.
718
8c9afb46
EZ
7192011-11-27 Eli Zaretskii <eliz@gnu.org>
720
721 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
722 (snprintf) [_MSC_VER]: Redirect to _snprintf.
723 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
724 (malloc, free, realloc, calloc): Redirect to e_* only when
725 compiling Emacs.
726
727 * lisp.h (GCTYPEBITS): Move before first use.
728 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
729 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
730 this macro definition.
731
732 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
733 _MSC_VER.
734
54e9e3bf
JD
7352011-11-27 Jan Djärv <jan.h.d@swipnet.se>
736
6d5eb5b0
SM
737 * gtkutil.c (xg_create_frame_widgets):
738 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
739 present with Gtk+ 2.0.
740
83aca1cb
PE
7412011-11-26 Paul Eggert <eggert@cs.ucla.edu>
742
743 * fileio.c (Finsert_file_contents): Undo previous change; see
744 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
745
5b76caa4
PE
7462011-11-26 Paul Eggert <eggert@cs.ucla.edu>
747
748 Rename locals to avoid shadowing.
749 * fileio.c (Finsert_file_contents):
750 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
751 * process.c (wait_reading_process_output):
752 Rename inner 'proc' to 'p' to avoid shadowing.
753 Indent for consistency with usual Emacs style.
754
8c535114
EZ
7552011-11-25 Eli Zaretskii <eliz@gnu.org>
756
757 * xdisp.c (redisplay_window): If cursor row is not fully visible
758 after recentering, and scroll-conservatively is set to a large
759 number, scroll window by a few more lines to make the cursor fully
760 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
761 (start_display): Don't move to the next line if the display should
762 start at a newline that is part of a display vector or an overlay
763 string. (Bug#10119)
8c535114 764
fa4fdb5c
JL
7652011-11-24 Juri Linkov <juri@jurta.org>
766
767 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
768 after the `MagickPingImage' call. (Bug#10112)
769
90ec88df
CY
7702011-11-23 Chong Yidong <cyd@gnu.org>
771
772 * window.c (Fcoordinates_in_window_p): Accept only live windows.
773
56e2e794
MR
7742011-11-23 Martin Rudalics <rudalics@gmx.at>
775
776 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
777 making another buffer current. (Bug#10114)
778
b6e64c41
GM
7792011-11-23 Glenn Morris <rgm@gnu.org>
780
781 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
782
6b21de18
CY
7832011-11-23 Chong Yidong <cyd@gnu.org>
784
785 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
786 using it (Bug#5984).
787
b12cd789
EZ
7882011-11-22 Eli Zaretskii <eliz@gnu.org>
789
790 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
791 and header-lines, as they don't have one computed for them.
792 (Bug#10098)
793
794 * .gdbinit (prow): Make displayed values more self-explaining.
795 Add row's hash code.
796
261b6fd4
LMI
7972011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
798
799 * process.c (wait_reading_process_output): Fix asynchrounous
800 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 801 (wait_reading_process_output): Add comment and URL.
261b6fd4 802
e7cfd277
JD
8032011-11-21 Jan Djärv <jan.h.d@swipnet.se>
804
805 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
806
a9b9b7f5
CY
8072011-11-21 Chong Yidong <cyd@gnu.org>
808
809 * window.c (Fnext_window, Fprevious_window): Doc fix.
810
b0d15b4f
SM
8112011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
812
813 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
814
fe7a3057
JB
8152011-11-20 Juanma Barranquero <lekktu@gmail.com>
816
817 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
818
d2999b1a
MR
8192011-11-20 Martin Rudalics <rudalics@gmx.at>
820
821 * window.c (Fset_window_combination_limit): Rename argument
822 STATUS to LIMIT.
823 (Vwindow_combination_limit): Remove "status" from doc-string.
824
d5ff9cd0
AS
8252011-11-20 Andreas Schwab <schwab@linux-m68k.org>
826
827 * m/ibms390.h: Remove.
828 * m/ibms390x.h: Don't include "ibms390.h".
829
a5bb9bd3
SM
8302011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
831
832 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
833 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
834
cd1181db
JB
8352011-11-20 Juanma Barranquero <lekktu@gmail.com>
836
837 * casetab.c (Fset_case_table):
838 * charset.c (Fcharset_after): Fix typos.
839
615a3b8d 8402011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 841
17e845af
PE
842 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
843 Otherwise, valgrind does not work on some platforms.
844 Problem reported by Andreas Schwab in
6a0bf43d
PE
845 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
846 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
847 is set, removing the need for VIRT_ADDRESS_VARIES.
848 (PURE_P): Use a more-efficient implementation that needs just one
849 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
850 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
851 to 4 (xorl, subq, cmpq, setbe).
852 * alloc.c (pure): Always extern now, since that's the
853 VIRT_ADDR_VARIES behavior.
854 (PURE_POINTER_P): Use a single comparison, not two, for
855 consistency with the new puresize.h.
856 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
857 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
858 Remove VIRT_ADDR_VARIES no longer needed.
859
f8fe6f96
EZ
8602011-11-19 Eli Zaretskii <eliz@gnu.org>
861
862 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
863 (erase_phys_cursor, update_window_cursor, show_mouse_face)
864 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
865 behave as if the cursor position were at the window margin.
866
867 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
868 and the cursor position is out of bounds, behave as if the cursor
869 position were at the window margin. (Bug#10075)
870
df05a53c
CY
8712011-11-18 Chong Yidong <cyd@gnu.org>
872
873 * window.c (Fwindow_combination_limit): Make first argument
874 non-optional, since it is meaningless for live windows like the
875 selected window.
876
2071918e
DA
8772011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
878
879 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
880
b50a28de
SM
8812011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
882
883 * intervals.c: Fix grafting over the whole buffer (bug#10071).
884 (graft_intervals_into_buffer): Simplify.
885
015137db
EZ
8862011-11-18 Eli Zaretskii <eliz@gnu.org>
887
888 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
889 hash values of the two rows.
890 (copy_row_except_pointers): Preserve the used[] arrays and the
891 hash values of the two rows. (Bug#10035)
68c95424 892 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
893
894 * xdisp.c (row_hash): New function, body extracted from
895 compute_line_metrics.
896 (compute_line_metrics): Call row_hash, instead of computing the
897 hash code inline.
898
899 * dispnew.c (verify_row_hash): Call row_hash for computing the
900 hash code of a row, instead of duplicating code from xdisp.c.
901
902 * dispextern.h (row_hash): Add prototype.
903
a2addb04
TH
9042011-11-18 Tassilo Horn <tassilo@member.fsf.org>
905
906 * frame.c (delete_frame): Don't delete the terminal when the last
907 X frame is closed if emacs is built with GTK toolkit.
908
df85d315
JB
9092011-11-17 Juanma Barranquero <lekktu@gmail.com>
910
911 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
912
a0c2d0ae
MR
9132011-11-17 Martin Rudalics <rudalics@gmx.at>
914
915 * window.c (Vwindow_splits): Rename to
916 Vwindow_combination_resize. Suggested by Juri Linkov.
917 (Fsplit_window_internal): Use Vwindow_combination_resize instead
918 of Vwindow_splits.
919
58179cce
JB
9202011-11-16 Juanma Barranquero <lekktu@gmail.com>
921
7877f373
JB
922 * nsfns.m (Fns_font_name):
923 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 924
b6f67890
MR
9252011-11-16 Martin Rudalics <rudalics@gmx.at>
926
927 * window.h (window): Rename slot "nest" to "combination_limit".
928 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
929 (Fset_window_nest): Rename to Fset_window_combination_limit.
930 (Vwindow_nest): Rename to Vwindow_combination_limit.
931 (recombine_windows, make_parent_window, make_window)
932 (Fsplit_window_internal, saved_window)
933 (Fset_window_configuration, save_window_save): Rename all
934 occurrences of window_nest to window_combination_limit.
935
c7015153
JB
9362011-11-15 Juanma Barranquero <lekktu@gmail.com>
937
938 * image.c (imagemagick_load_image): Fix typo.
939
322ad6ec
EZ
9402011-11-14 Eli Zaretskii <eliz@gnu.org>
941
942 * xdisp.c (display_line): Move the call to
943 highlight_trailing_whitespace before the call to
944 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
945 faces of all the glyphs to compute ROW's hash value.
946 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 947
f067b8ec
JB
9482011-11-14 Juanma Barranquero <lekktu@gmail.com>
949
950 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
951 just return (bug#10044).
952
1e5b2111
EZ
9532011-11-12 Eli Zaretskii <eliz@gnu.org>
954
7ef3cbd5
EZ
955 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
956 with user-defined heap size. Bump the default size of the temacs
957 heap to 27MB, to avoid memory warning when running temacs.
958 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
959
1e5b2111
EZ
960 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
961 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
962 (verify_row_hash) [XASSERTS]: New function.
963 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
964 that the hash value of glyph rows is correct.
1e5b2111 965
89d61221
MR
9662011-11-12 Martin Rudalics <rudalics@gmx.at>
967
968 * window.h (window): Remove splits slot.
969 * window.c (Fwindow_splits, Fset_window_splits): Remove.
970 (Fdelete_other_windows_internal, make_parent_window)
971 (make_window, Fsplit_window_internal, Fdelete_window_internal)
972 (Fset_window_configuration, save_window_save): Don't deal with
973 split status of windows.
974 (saved_window): Remove splits slot.
975 (Vwindow_splits): Rewrite doc-string.
976
97f18cc8
JD
9772011-11-11 Jan Djärv <jan.h.d@swipnet.se>
978
979 * xfns.c (unwind_create_frame):
980 * nsfns.m (unwind_create_frame):
981 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
982 Vframe_list (Bug#9999).
983
22a648b4
DA
9842011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
985
0b381c7e 986 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 987
659afede
KH
9882011-11-11 Kenichi Handa <handa@m17n.org>
989
990 * callproc.c (Fcall_process): Set the member dst_multibyte of
991 process_coding.
992
9ac0394b
KH
9932011-11-11 Johan Bockgård <bojohan@gnu.org>
994
995 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
996 avoid a crash (bug#9496).
997
2fbdc249
CY
9982011-11-09 Chong Yidong <cyd@gnu.org>
999
1000 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1001 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1002
ac6b1f81
PE
10032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1006
09db192c
PE
10072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 Avoid some portability problems by eschewing 'extern inline' functions.
1010 The trivial performance wins aren't worth the portability hassles; see
1011 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1012 et seq.
1013 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1014 (window_box_width, window_box_left, window_box_left_offset)
1015 (window_box_right, window_box_right_offset): Undo previous change,
1016 by removing the "extern"s.
1017 * intervals.c (adjust_intervals_for_insertion)
1018 (adjust_intervals_for_deletion): Undo previous change,
1019 making these static again.
1020 (offset_intervals, temp_set_point_both, temp_set_point)
1021 (copy_intervals_to_string): No longer inline.
1022 * xdisp.c (window_text_bottom_y, window_box_width)
1023 (window_box_height, window_box_left_offset)
1024 (window_box_right_offset, window_box_left, window_box_right)
1025 (window_box): No longer inline.
1026
105216ed
CY
10272011-11-08 Chong Yidong <cyd@gnu.org>
1028
1029 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1030 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1031 Signal an error if not a live window.
105216ed
CY
1032 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1033 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1034
ae9e237f
JB
10352011-11-07 Juanma Barranquero <lekktu@gmail.com>
1036
1037 * lisp.h (syms_of_abbrev): Remove declaration.
1038 Reported by CHENG Gao <chenggao@royau.me>.
1039
c7aa8333
EZ
10402011-11-07 Eli Zaretskii <eliz@gnu.org>
1041
1042 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1043 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1044 of temacs in GUI mode.
1045
be7f5545
MR
10462011-11-07 Martin Rudalics <rudalics@gmx.at>
1047
1048 * window.h: Declare delete_all_child_windows instead of
1049 delete_all_subwindows.
1050 * window.c (Fwindow_nest, Fset_window_nest)
1051 (Fset_window_new_total, Fset_window_new_normal)
1052 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1053 (delete_all_subwindows): Rename to delete_all_child_windows.
1054 (Fdelete_other_windows_internal, Fset_window_configuration):
1055 Call delete_all_child_windows instead of delete_all_subwindows.
1056 * frame.c (delete_frame): Call delete_all_child_windows instead
1057 of delete_all_subwindows.
1058
ca78dc43
PE
10592011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1062 This is also needed for porting to any host where GC_MARK_STACK is
1063 not GC_MAKE_GCPROS_NOOPS.
1064 (which_symbols): Use it.
1065
a0241d01
KH
10662011-11-07 Kenichi Handa <handa@m17n.org>
1067
1068 * coding.c (coding_set_destination): Check coding->src_pos only
1069 when coding->src_object is a buffer (bug#9910).
1070
1071 * process.c (send_process): Set the member src_multibyte of coding
1072 to 0 (bug#9911) when sending a unibyte text.
1073
1074 * callproc.c (Fcall_process): Set the member src_multibyte of
1075 process_coding to 0 (bug#9912).
1076
a64bfdfa 10772011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1078
1079 * xmenu.c (cleanup_widget_value_tree): New function.
1080 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1081 calling free_menubar_widget_value_tree directly (Bug#9830).
1082
cb41b32a
PE
10832011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 Fix some portability problems with 'inline'.
1086 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1087 (window_box_width, window_box_left, window_box_left_offset)
1088 (window_box_right, window_box_right_offset): Declare extern.
1089 Otherwise, these inline functions do not conform to C99 and
1090 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1091 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1092 * intervals.c (adjust_intervals_for_insertion)
1093 (adjust_intervals_for_deletion): Now extern, because otherwise the
1094 extern inline functions 'offset_intervals' couldn't refer to it.
1095 (static_offset_intervals): Remove.
1096 (offset_intervals): Rewrite using the old contents of
1097 static_offset_intervals. The old version didn't conform to C99
1098 because an extern inline function contained a reference to an
1099 identifier with static linkage.
1100
b7041366
AS
11012011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1102
1103 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1104 GC.
1105
88a37c4d
EZ
11062011-11-06 Eli Zaretskii <eliz@gnu.org>
1107
1108 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1109 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1110 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1111 return Qleft_to_right.
1112
49745b39
CY
11132011-11-06 Chong Yidong <cyd@gnu.org>
1114
1115 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1116 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1117 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1118 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1119 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1120 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1121 (Fwindow_vscroll): Doc fix.
1122 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1123 argument, since it makes no sense to pass a live window and for
1124 consistency with window-child.
1125
1f05cd82
CS
11262011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1127
1128 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1129 support MSVC.
1130
22610910
JR
11312011-11-05 Jason Rumney <jasonr@gnu.org>
1132
1133 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1134 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1135 fonts (Bug#6029).
1136 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1137 bitwise arithmetic preventing use of unicode-sip and non-truetype
1138 opentype fonts.
1139
a06776b2
EZ
11402011-11-05 Eli Zaretskii <eliz@gnu.org>
1141
3ad924ba
EZ
1142 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1143 "emacs"-only part.
1144
a06776b2
EZ
1145 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1146 initialization code to keep similarity to xfns.c after changes
1147 from 2011-11-05.
1148
c9e7db78
JD
11492011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1150
a97f8f3f
JD
1151 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1152 (unwind_create_frame): New function (Bug#9943).
1153 (Fx_create_frame): Restructure code to be more similar to the one in
1154 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1155 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1156 Move terminal->reference_count++ just before making the frame official
1157 (Bug#9943).
1158
1159 * nsterm.m (x_free_frame_resources): New function.
1160 (x_destroy_window): Move code to x_free_frame_resources.
1161
c9e7db78 1162 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1163 (Fx_create_frame, x_create_tip_frame):
1164 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1165 official. Move initialization of image_cache_refcount and
1166 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1167
a6fc3b5c
EZ
11682011-11-05 Eli Zaretskii <eliz@gnu.org>
1169
1170 Support MSVC build with newer versions of Visual Studio.
1171 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1172 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1173 nt/gmake.defs.
1174
1175 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1176 which are not supported by MSVC.
1177 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1178 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1179 bitfields.
1180 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1181 types in bitfields.
1182 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1183
1184 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1185
58179cce 11862011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1187
1188 Support MSVC build with newer versions of Visual Studio.
1189 * w32.c: Don't include w32api.h for MSVC.
1190 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1191
1192 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1193 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1194 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1195 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1196 e_* cousins.
1197 (alloca) [_MSC_VER]: Define to _alloca.
1198
1199 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1200
1201 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1202
a58c13ed
EZ
12032011-11-04 Eli Zaretskii <eliz@gnu.org>
1204
1205 * xdisp.c (note_mouse_highlight): If either of
1206 previous/next-single-property-change returns nil, treat that as
1207 the beginning or the end of the buffer. (Bug#9955)
1208
fe0b6370
JD
12092011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1210
a58c13ed 1211 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1212 label is not null (Bug#9951).
1213 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1214 may be NULL.
1215
89bd5ee1
EZ
12162011-11-04 Eli Zaretskii <eliz@gnu.org>
1217
1218 * window.c (Fwindow_body_size): Mention in the doc string that the
1219 return value is in frame's canonical units. (Bug#9949)
1220
84c3edb9
EZ
12212011-11-03 Eli Zaretskii <eliz@gnu.org>
1222
4e2fb5c7
EZ
1223 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1224
84c3edb9 1225 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1226 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1227 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1228
bc17a887
EZ
12292011-11-01 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1232 Don't stop backward scan on the continuation glyph, even though
1233 its CHARPOS is positive.
6d5eb5b0
SM
1234 (mouse_face_from_buffer_pos, note_mouse_highlight):
1235 Rename cover_string to disp_string.
bc17a887 1236
4ee88440
MR
12372011-11-01 Martin Rudalics <rudalics@gmx.at>
1238
1239 * window.c (temp_output_buffer_show): Don't use
1240 Vtemp_buffer_show_specifiers.
1241 (Vtemp_buffer_show_specifiers): Remove unused variable.
1242
c2ff3c02
EZ
12432011-10-30 Eli Zaretskii <eliz@gnu.org>
1244
1245 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1246 past the beginning of the current glyph matrix.
1247
58179cce 12482011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1249
1250 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1251 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1252 HAVE_GTK3 (Bug#9869).
b77a6a7f 1253
3b574623
JD
1254 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1255 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1256
b77a6a7f
JD
1257 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1258
1259 * xterm.c: Declare x_handle_net_wm_state to return int.
1260 (handle_one_xevent): Check if we are iconified but don't have
1261 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1262 (get_current_wm_state): Return non-zero if not hidden,
1263 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1264 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1265 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1266 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1267
196e41e4
PE
12682011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1271 so that this new function doesn't get optimized away by a
1272 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1273
021f2e1a
AS
12742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1275
1276 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1277
8b058d44
EZ
12782011-10-29 Eli Zaretskii <eliz@gnu.org>
1279
1280 Fix the `xbytecode' command.
1281 * .gdbinit (xprintbytestr): New command.
b50a28de 1282 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1283 (xbytecode): Print the byte-code string as well.
1284
4452fb80
EZ
12852011-10-29 Kim Storm <storm@cua.dk>
1286
8b058d44
EZ
1287 * alloc.c (which_symbols): New function.
1288
21b72067
AS
12892011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1290
1291 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1292 line. (Bug#9903)
1293
83ed7b5c
GM
12942011-10-29 Glenn Morris <rgm@gnu.org>
1295
1296 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1297 Not clear what it was for, and it causes various bugs. (Bug#9839)
1298
5a7a728b
EZ
12992011-10-28 Eli Zaretskii <eliz@gnu.org>
1300
1301 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1302 possible random value that matches one of those tested as
1303 condition to clear the mouse face.
1304
d3d0842f
CY
13052011-10-28 Chong Yidong <cyd@gnu.org>
1306
1307 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1308
31b39d13
DN
13092011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1310
1311 * window.c (make_window): Initialize phys_cursor_on_p.
1312
9aba6043
SM
13132011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1314
1315 * lisp.h (struct Lisp_Symbol): Update comments.
1316
c20992f4
JB
13172011-10-28 Juanma Barranquero <lekktu@gmail.com>
1318
1319 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1320
db4f02f2
EZ
13212011-10-28 Eli Zaretskii <eliz@gnu.org>
1322
1323 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1324 <oslsachem@gmail.com> for helping to debug this.
1325
1326 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1327 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1328 (g_b_init_get_glyph_outline_w): New static variables.
1329 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1330 (GetGlyphOutlineW_Proc): New typedefs.
1331 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1332 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1333 New functions.
1334 (w32font_open_internal, compute_metrics):
1335 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1336 instead of calling the "wide" APIs directly.
1337
1338 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1339
1340 * w32.h (syms_of_w32font): Add prototype.
1341
87e68db4
JB
13422011-10-27 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1345 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1346 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1347 (Fmove_to_window_line): Doc fix.
1348
435c1d67
CY
13492011-10-27 Chong Yidong <cyd@gnu.org>
1350
1351 * process.c (make_process): Set gnutls_state to NULL.
1352
1353 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1354 non-NULL, regardless of GNUTLS_INITSTAGE.
1355 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1356 an error. Set process slots as soon as we allocate them.
1357
1358 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1359
9c6c6f49
CY
13602011-10-27 Chong Yidong <cyd@gnu.org>
1361
9aba6043
SM
1362 * gnutls.c (emacs_gnutls_deinit): New function.
1363 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1364 (Fgnutls_deinit, Fgnutls_boot): Use it.
1365
1366 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1367 (deactivate_process): Call emacs_gnutls_deinit.
1368
657d08d3
JB
13692011-10-27 Juanma Barranquero <lekktu@gmail.com>
1370
1371 * image.c (x_create_x_image_and_pixmap):
1372 * w32.c (sys_rename, w32_delayed_load):
1373 * w32font.c (fill_in_logfont):
1374 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1375
5430d399
JB
13762011-10-26 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * w32fns.c (w32_default_color_map): New function,
1379 extracted from Fw32_default_color_map.
a7ef684b 1380 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1381
fe0055fa
PE
13822011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1385
e6346438
SM
13862011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1387
1388 * keyboard.c (test_undefined): New function (bug#9751).
1389 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1390
e112cc37
ET
13912011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1392
1393 * sysdep.c (init_sys_modes): Fix the check for the controlling
1394 terminal (Bug#6649).
1395
7b5d6677
EZ
13962011-10-20 Eli Zaretskii <eliz@gnu.org>
1397
1398 * dispextern.h (struct bidi_it): New member next_en_type.
1399
1400 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1401 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1402 current character, check also for next_en_type being WEAK_EN.
1403 (bidi_resolve_weak): Don't enter the expensive loop if the current
1404 position is before next_en_pos. Record the bidi type of the first
1405 non-ET, non-BN character we find, in addition to its position.
1406 (bidi_level_of_next_char): Invalidate next_en_type when
1407 next_en_pos is over-stepped.
1408
7da0b018
PE
14092011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1412 * editfns.c: Rewrite current-time-zone so that it invokes
1413 the equivalent of (format-time-string "%Z") to get the time zone name.
1414 This fixes a bug when the time zone name contains characters that
1415 need converting from the system time locale to Emacs internal format.
1416 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1417 that patch fixed format-time-string to do the conversion, but
1418 I forgot to fix current-time-zone.
1419 (format_time_string): New function, containing most of
1420 what Fformat_time_string used to contain.
1421 (Fformat_time_string): Rewrite in terms of format_time_string.
1422 This doesn't change this function's behavior.
1423 (current-time-zone): Rewrite to use format_time_string.
1424 This fixes the bug reported by Michael Schierl in
1425 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1426 Jason Rumney's 2007-06-07 change worked around this bug, but
1427 didn't fix it.
1428 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1429
8547b010
EZ
14302011-10-19 Eli Zaretskii <eliz@gnu.org>
1431
1432 * xdisp.c (start_display): If the character at POS is displayed
1433 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1434 (try_window_reusing_current_matrix): If a line ends in a display
1435 vector or the next line starts in a display vector, continue
1436 redrawing the window even though the character position of
1437 start_row was reached.
8547b010
EZ
1438 (Bug#9771, part 2)
1439
4e948d15
CY
14402011-10-18 Chong Yidong <cyd@gnu.org>
1441
1442 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1443 with nobreak-char-display too.
1444
4787455f
EZ
14452011-10-18 Eli Zaretskii <eliz@gnu.org>
1446
1447 Fix part 3 of bug#9771.
1448 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1449 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1450 non-neutral characters if the current character is a paragraph
1451 separator (a.k.a. Newline). This avoids running the same
1452 expensive loop twice, once when we consume the preceding newline
1453 and the other time when the line actually needs to be displayed.
1454 Avoid the loop when we see neutrals on the base embedding level
1455 following a character whose directionality is the same as the
1456 paragraph's. This avoids running the expensive loop when a line
1457 ends in a long sequence of neutrals, like control characters.
1458 Add assertion against STRONG_AL type. Slightly rearrange code
1459 that determines the type of a neutral given the first non-neutral
1460 that follows it.
1461 (bidi_level_of_next_char): Set next_en_pos to zero when
1462 invalidating its info.
1463
2c91f553
EZ
14642011-10-17 Eli Zaretskii <eliz@gnu.org>
1465
1466 * xdisp.c (push_display_prop): Determine whether to record string
1467 or buffer position by IT->string, not by IT->method. Allow
1468 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1469 (move_it_vertically_backward): Don't look for character position
1470 immediately after the newline when in a continuation line.
1471 (Bug#9771, part 1)
2c91f553 1472
c7b08b0d
MR
14732011-10-15 Martin Rudalics <rudalics@gmx.at>
1474
1475 * window.c (coordinates_in_window): Rewrite and delabelize
1476 vertical border check. (Bug#5357) (Bug#9618)
1477
6b02f655
SM
14782011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1479
1480 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1481 errors in XSetWindowBorder (bug#9310).
1482
81d40c92
DA
14832011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1486 avoid crash when xmalloc overrun checking is enabled.
1487
d4172c3b
EZ
14882011-10-13 Eli Zaretskii <eliz@gnu.org>
1489
1490 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1491 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1492 cursor motion with <left> and <right> arrow keys.
1493
1494 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1495 some callers set that themselves.
1496
b00eea75
EZ
14972011-10-12 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1500 display string and the previous row comes from the same string and
1501 is empty. (Bug#9739) (Bug#9738)
1502
8fe012c4
SM
15032011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1504
1505 * doc.c (get_doc_string): Encode file name (bug#9735).
1506
0074aef2
EZ
15072011-10-12 Eli Zaretskii <eliz@gnu.org>
1508
79beb178
EZ
1509 * bidi.c (bidi_level_of_next_char):
1510 * xdisp.c (get_visually_first_element): Remove old incorrect
1511 comments regarding the Unicode Line Separator character.
1512
0074aef2
EZ
1513 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1514
6e4b3fbe
DA
15152011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1516
1517 * alloc.c (Fgc_status): Do not access beyond zombies array
1518 boundary if nzombies > MAX_ZOMBIES.
1519 * alloc.c (dump_zombies): Add missing format specifier.
1520
0324f3af
PE
15212011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1522
b5525cac
PE
1523 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1524 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1525
0324f3af
PE
1526 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1527 Some packages use them to denote characters with modifiers.
1528
e9b5f888
AS
15292011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1532 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1533 matching a pp-number. Rename parameter var to var1.
1534
127827c0
SM
15352011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1536
1537 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1538
c8fd3bd0
GM
15392011-10-08 Glenn Morris <rgm@gnu.org>
1540
1541 * callint.c (Fcall_interactively): Give a more explicit error for the
1542 'c' case with a non-character input. (Bug#8479)
1543
352ec8ff
EZ
15442011-10-08 Eli Zaretskii <eliz@gnu.org>
1545
03669ccb
EZ
1546 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1547 lines.
7061c986
EZ
1548 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1549 lines that are hscrolled on the left.
03669ccb 1550
352ec8ff
EZ
1551 * dispnew.c (buffer_posn_from_coords): Account for a possible
1552 presence of header-line. (Bug#4426)
1553
a66cfb1c
SM
15542011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1555
6b02f655
SM
1556 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1557 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1558
7c5ee88e
PE
15592011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1562 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1563 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1564 this makes Emacs dump core during garbage collection on rare
1565 occasions. sizeof is obviously inferior to offsetof here, so
1566 stick with offsetof.
1567 (GC_POINTER_ALIGNMENT): New macro.
1568 (mark_memory): Omit 3rd (offset) arg; caller changed.
1569 Don't assume EMACS_INT alignment is the same as pointer alignment.
1570
df1bbe5b
SM
15712011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1572
1573 * keyboard.c (read_key_sequence_remapped): New var.
1574 (read_key_sequence): Compute remapping in the right buffer.
1575 (command_loop_1): Use read_key_sequence's remapping directly.
1576
51553db6
SM
15772011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1578
32c1fffd
SM
1579 * dired.c (file_name_completion): Don't expand file name.
1580 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1581 before checking file name handler.
1582
51553db6
SM
1583 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1584 they've been requested explicitly (bug#9591).
1585
b6bd1599 15862011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1587
1588 * keymap.c (Fsingle_key_description): Use make_specified_string
1589 instead of build_string to build string from push_key_description.
1590 (Bug#5193)
1591
f701dc2a
PE
15922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1593
4222c55d
PE
1594 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1595 This fixes a Y2038 bug on 64-bit hosts.
1596 * buffer.c (reset_buffer):
1597 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1598 (Fclear_buffer_auto_save_failure):
1599 Use 0, not -1, to represent an unset failure time, since time_t
1600 might not be signed.
1601
f701dc2a
PE
1602 Remove dependency on glibc malloc internals.
1603 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1604 Move back here from lisp.h, but with their new implementations.
1605 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1606 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1607 * charset.c (charset_table_init): New static var.
1608 (syms_of_charset): Use it instead of xmalloc. This removes a
1609 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1610 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1611 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1612 Move back to alloc.c.
1613 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1614 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1615
9ceebf39
JD
16162011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1617
1618 * nsterm.m (windowDidResize): Call x_set_window_size only when
1619 ns_in_resize is true. Otherwise set pixelwidth/height and
1620 call change_frame_size (Bug#9628).
1621
cb993c58
PE
16222011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1623
3930c88b
PE
1624 Port --enable-checking=all to Fedora 14 x86-64.
1625 * charset.c (syms_of_charset): Also account for glibc malloc's
1626 internal overhead when calculating the initial malloc maximum.
1627
cb993c58
PE
1628 Port --enable-checking=all to Fedora 14 x86.
1629 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1630 Move to lisp.h.
1631 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1632 (overrun_check_realloc, overrun_check_free):
1633 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1634 That way, xmalloc returns a properly-aligned pointer even if
1635 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1636 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1637 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1638 into account when calculating the initial malloc maximum.
1639 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1640 Move here from alloc.c, so that charset.c can use it too.
1641 Properly align; the old code wasn't right for common 32-bit hosts
1642 when configured with --enable-checking=all.
1643 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1644 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1645
31bed486
EZ
16462011-09-29 Eli Zaretskii <eliz@gnu.org>
1647
04c70788 1648 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1649 use EDOM.
1650
fbcaa2f3
EZ
16512011-09-28 Eli Zaretskii <eliz@gnu.org>
1652
1653 * xdisp.c (compute_display_string_end): If there's no display
1654 string at CHARPOS, return -1.
1655
1656 * bidi.c (bidi_fetch_char): When compute_display_string_end
1657 returns a negative value, treat the character as a normal
1658 character not covered by a display string. (Bug#9624)
1659
a239d4e9
JB
16602011-09-28 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * lread.c (Fread_from_string): Fix typo in docstring.
1663
88652fd5
EZ
16642011-09-27 Eli Zaretskii <eliz@gnu.org>
1665
1666 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1667 newline, reseat the iterator instead of bidi-iterating there one
1668 character at a time. (Bug#9610)
32c1fffd
SM
1669 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1670 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1671
ed497dd4
AS
16722011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1673
1674 * lread.c (readevalloop): Use correct code for NBSP.
1675 (read1): Likewise. (Bug#9608)
1676
b2bf61aa
MA
16772011-09-25 Michael Albinus <michael.albinus@gmx.de>
1678
1679 * dbusbind.c (Fdbus_register_signal): When service is not
1680 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1681
32bbb17c
GM
16822011-09-25 Glenn Morris <rgm@gnu.org>
1683
1684 * buffer.c (truncate-lines): Doc fix.
1685
94e0933e
CY
16862011-09-24 Chong Yidong <cyd@stupidchicken.com>
1687
1688 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1689 (Fset_window_next_buffers): Doc fix.
1690
cddde921
GM
16912011-09-24 Glenn Morris <rgm@gnu.org>
1692
1693 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1694
1260aef1
PE
16952011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1696
25b4bfa0
PE
1697 Fix minor problems found by static checking.
1698 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1699 * indent.c (Fvertical_motion): Fix == vs = typo.
1700
e3cbd34b
EZ
17012011-09-24 Eli Zaretskii <eliz@gnu.org>
1702
a66cfb1c
SM
1703 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1704 Default value is now t. Doc fix.
6bf7006f 1705
e3cbd34b 1706 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1707 logic when moving up, not only when moving down. Fix the
e3cbd34b 1708 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1709 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1710
1711 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1712 CHARPOS is covered by a display string which includes newlines.
1713 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1714 is covered by a display string with embedded newlines.
1715
a3de0cbd
MA
17162011-09-24 Michael Albinus <michael.albinus@gmx.de>
1717
1718 * dbusbind.c (Fdbus_register_signal): Add match rule to
1719 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1720 (Fdbus_register_method, Vdbus_registered_objects_table):
1721 Fix docstring.
a3de0cbd 1722
b260039d
JM
17232011-09-24 Jim Meyering <meyering@redhat.com>
1724
32c1fffd 1725 do not ignore write error for any output size
b260039d
JM
1726 The previous change was incomplete.
1727 While it makes emacs --batch detect the vast majority of stdout
1728 write failures, errors were still ignored whenever the output size is
1729 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1730 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1731 && echo FAIL: ignored write error
1732 FAIL: ignored write error
1733 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1734 && echo FAIL: ignored write error
1735 FAIL: ignored write error
1736 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1737
8eca8a7c
AS
17382011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1739
1740 * emacs.c (Fkill_emacs): In noninteractive mode exit
1741 non-successfully if a write error occurred on stdout. (Bug#9574)
1742
3341db62
EZ
17432011-09-21 Eli Zaretskii <eliz@gnu.org>
1744
1745 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1746 the xassert test.
1747
1748 * dispextern.h (struct it): Update the comment documenting what
1749 can it->OBJECT be.
1750
8c203dbf
EZ
17512011-09-20 Eli Zaretskii <eliz@gnu.org>
1752
1753 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1754 a display string, extend search for cursor position to end of row.
1755 (find_row_edges): If the row ends in a newline from a display
1756 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1757 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1758 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1759 non-empty line. Fixes confusing cursor motion with arrow keys at
1760 the beginning of a line that starts with whitespace.
8c203dbf 1761
a4824228
LMI
17622011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1763
1764 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1765 (bug#9493).
1766
33ed493b
CY
17672011-09-18 Chong Yidong <cyd@stupidchicken.com>
1768
1769 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1770 boolean (Bug#9154).
1771
56cd55c8
EZ
17722011-09-18 Eli Zaretskii <eliz@gnu.org>
1773
1774 * xdisp.c (display_line): Record maximum and minimum buffer
1775 positions even if no glyphs were produced (e.g., by a zero-width
1776 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1777 buffer positions that will be removed from the glyph row because
1778 they don't fit.
c02dcedf
EZ
1779 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1780 column is beyond frame width: don't subtract 1 "pixel" when
1781 computing width of the stretch.
3e62b7e0
EZ
1782 (reseat_at_next_visible_line_start): Undo the change made on
1783 2011-09-17 that saved paragraph information and restored it after
1784 the call to `reseat'. (Bug#9545)
56cd55c8 1785
5ed99d36 17862011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1787
1788 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1789 and turn window cursor on if cleared (Bug#9415).
1790
5ed99d36 17912011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1792
1793 * search.c (boyer_moore): Take unibyte characters from pattern
1794 literally. (Bug#9458)
1795
9bade7b2
EZ
17962011-09-18 Eli Zaretskii <eliz@gnu.org>
1797
1798 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1799
e5e9d610
PE
18002011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1801
87e4427a
PE
1802 Fix minor problem found by static checking.
1803 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1804 initialized, to pacify gcc -Wuninitialized.
1805
e5e9d610
PE
1806 * fileio.c: Report proper errno when syscall falls.
1807 (Finsert_file_contents): Save and restore errno,
1808 so that report_file_error outputs the correct diagnostic.
1809 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1810
a1674f0b
EZ
18112011-09-18 Eli Zaretskii <eliz@gnu.org>
1812
1813 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1814
fbfb6dd4
EZ
18152011-09-17 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1818 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1819
bb187662
EZ
18202011-09-17 Eli Zaretskii <eliz@gnu.org>
1821
1137e8b8 1822 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1823 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1824
1825 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1826 (bidi_find_paragraph_start): Search back for paragraph beginning
1827 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1828 (bidi_move_to_visually_next): Only trigger paragraph-related
1829 computations when the last character is a newline or at EOB, not
1830 just any NEUTRAL_B. (Bug#9470)
1831
bb187662
EZ
1832 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1833 truncated lines if point is covered by a display string. (Bug#9524)
1834
2e621251
PE
18352011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1838 (cons_to_x_long): New function.
1839 (lisp_data_to_selection_data): Use it. Correct the test for
1840 short-versus-long data; it was negated. Break out of vector
1841 loop, for efficiency, when a long datum is discovered.
1842
91a15bc6
SM
18432011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1844
1845 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1846
b41c3a35
EZ
18472011-09-16 Eli Zaretskii <eliz@gnu.org>
1848
1849 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1850 GCC PR/17406) by declaring this function with external scope.
1851
7812ba2d
PE
18522011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1855 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1856
cf7edc2a
AS
18572011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1858
1859 * editfns.c (Fformat): Correctly handle text properties on "%%".
1860
bd01620e
EZ
18612011-09-15 Eli Zaretskii <eliz@gnu.org>
1862
1863 * xterm.c (x_draw_composite_glyph_string_foreground):
1864 * w32term.c (x_draw_composite_glyph_string_foreground):
1865 * term.c (encode_terminal_code):
1866 * composite.c (composition_update_it, get_composition_id):
1867 * xdisp.c (get_next_display_element)
1868 (fill_composite_glyph_string): Add comments about special meaning
1869 of TAB characters in a composition.
1870
a02719a3
PE
18712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1874 This occurs when processing a multibyte format.
1875 Problem reported by Wolfgang Jenker.
a02719a3 1876
72589a3c
JB
18772011-09-15 Johan Bockgård <bojohan@gnu.org>
1878
1879 * xdisp.c (try_cursor_movement): Only check for exact match if
1880 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1881
1c14176c
PE
18822011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 Remove unused external symbols.
1885 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1886 * xdisp.c (calc_pixel_width_or_height): Now static.
1887 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1888 * indent.c (check_display_width):
1889 * w32term.c: Fix comment to match code.
1890 * xterm.c, xterm.h (x_catching_errors): Remove.
1891
d2eea5b5
PE
18922011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1893
1894 * xselect.c: Use signed conversions more consistently (Bug#9498).
1895 (selection_data_to_lisp_data): Assume incoming selection data are
1896 signed integers, not unsigned. This is to be consistent with
1897 outgoing selection data, which was modified to use signed integers
1898 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1899 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1900 expects long, not unsigned long.
1901
46888499
EZ
19022011-09-14 Eli Zaretskii <eliz@gnu.org>
1903
1904 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1905 computation of loop end. Reported by Johan Bockgård
1906 <bojohan@gnu.org>.
1907
ef8ef9fb
CY
19082011-09-13 Chong Yidong <cyd@stupidchicken.com>
1909
1910 * frame.c (Fother_visible_frames_p): Function deleted.
1911
fa819fed
EZ
19122011-09-12 Eli Zaretskii <eliz@gnu.org>
1913
1914 * indent.c (compute_motion): Process display vector front to back
1915 rather than the other way around. (Bug#2496)
1916
2ba8e008
SM
19172011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1918
1919 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1920
20f53c69
CY
19212011-09-11 Chong Yidong <cyd@stupidchicken.com>
1922
1923 * minibuf.c (Fread_from_minibuffer): Doc fix.
1924
d562d7a4
EZ
19252011-09-11 Eli Zaretskii <eliz@gnu.org>
1926
1927 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1928 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1929
1c4d7f3d
LMI
19302011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1931
1932 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1933 value for non-existent files.
1934
b885bf36
EZ
19352011-09-11 Eli Zaretskii <eliz@gnu.org>
1936
1937 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1938 set its "size" to -1. This will set the modtime_size field of
1939 the corresponding buffer to -1, which is what
1940 verify-visited-file-modtime expects for files that do not exist.
1941 (Bug#9139)
1942
6612f0bf
PE
19432011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1946 here ...
1947 * lisp.h: ... from here. push_key_description is no longer
1948 defined in keyboard.c, so its declaration should not be in
1949 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1950 logically belongs with push_key_description.
1951
dfb3f755
PE
19522011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 * buffer.h: Include <sys/types.h> instead of <time.h>.
1955 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1956 Problem reported by Herbert J. Skuhra.
1957
3134906c
LMI
19582011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1959
1960 * xml.c (parse_region): Make the parsing work for
1961 non-comment-starting XML files again (bug#9144).
1962
8d903f4e
AS
19632011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1964
1965 * image.c (gif_load): Fix calculation of bottom and right corner.
1966 (Bug#9468)
1967
80ad64f4
EZ
19682011-09-10 Eli Zaretskii <eliz@gnu.org>
1969
1970 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1971 redisplay in small windows.
1972
208a048d
EZ
19732011-09-09 Eli Zaretskii <eliz@gnu.org>
1974
1975 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1976
9b1c252e
MR
19772011-09-08 Martin Rudalics <rudalics@gmx.at>
1978
1979 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1980 Operate on live windows only.
1981
2949f33b
JB
19822011-09-08 Juanma Barranquero <lekktu@gmail.com>
1983
1984 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1985
e08dcafd
EZ
19862011-09-07 Eli Zaretskii <eliz@gnu.org>
1987
1988 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1989 only under bidi iteration.
1990
115b96bd
JD
19912011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1992
1993 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1994
c8199d0f
PE
19952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1998 Without this fix, the command to link temacs failed due to an
1999 undefined symbol __builtin_isnan. This is because
2000 /usr/include/iso/math_c99.h #defines isnan(x) to
2001 __builtin_isnan(x), but the bundled gcc, which identifies itself
2002 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2003 a __builtin_isnan.
2004 * floatfns.c (isnan): #undef, and then #define to a clone of
2005 what's in data.c.
2006 (Fisnan): Always define, since it's always available now.
2007 (syms_of_floatfns): Always define isnan at the Lisp level.
2008
e39b275c 20092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2010
2011 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2012
b2db44d9 20132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2014
f4af5137 2015 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2016 The previous code assumed that file offsets (off_t values) fit in
2017 EMACS_INT variables, which is not true on typical 32-bit hosts.
2018 The code messed up by falsely reporting buffer overflow in cases
2019 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2020 when "big" contains more than 2**29 bytes, even though this
2021 inserts just one byte and does not overflow the buffer.
2022 (Finsert_file_contents): Store file offsets as off_t
2023 values, not as EMACS_INT values. Check for overflow when
2024 converting between EMACS_INT and off_t. When checking for
2025 buffer overflow or for overlap, take the offsets into account.
2026 Don't use EMACS_INT for small values where int suffices.
2027 When checking for overlap, fix a typo: ZV was used where
2028 ZV_BYTE was intended.
2029 (Fwrite_region): Don't assume off_t fits into 'long'.
2030 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2031
ecfc0a49
MA
20322011-09-05 Michael Albinus <michael.albinus@gmx.de>
2033
2034 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2035
6511acf2 20362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2037
0999621a 2038 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2039
2040 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2041 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2042 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2043 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2044 (modify_event_symbol): Do not assume that the length of
2045 name_alist_or_stem is safe to alloca and fits in int.
2046 (Fexecute_extended_command): Likewise for function name and binding.
2047 (Frecursion_depth): Wrap around reliably on integer overflow.
2048 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2049 since some callers pass EMACS_INT values.
2050 (Fsingle_key_description): Don't crash if symbol name contains more
2051 than MAX_ALLOCA bytes.
2052 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2053 (get_minibuffer): Arg is now EMACS_INT, not int.
2054 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2055 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2056 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2057
2be7d702
PE
2058 * dbusbind.c (signature_cat): New function.
2059 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2060 Do not overrun buffer; instead, report string overflow.
2061
9d1df220
PE
2062 * dispnew.c (add_window_display_history): Don't overrun buffer.
2063 Truncate instead; this is OK since it's just a log.
2064
33ef5c64
PE
2065 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2066 even if the time zone offset is outlandishly large.
2067 Don't mishandle offset == INT_MIN.
2068
66c6fdd5
PE
2069 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2070 when creating daemon; the previous buffer-overflow check was incorrect.
2071
d749b01b
PE
2072 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2073 which has the guts of the old verror function.
2074
b5cd1905
PE
2075 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2076 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2077
6e1a67fb
PE
2078 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2079 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2080 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2081 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2082 length of string rather than counting it via multiple sprintfs;
2083 that's simpler and more reliable.
c21721cc
PE
2084 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2085 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2086 sprintf, in case result does not fit in int.
2087
c57b67fc
PE
2088 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2089 (fontset_from_font): Print it.
2090
8a401434
PE
2091 * frame.c (tty_frame_count): Now printmax_t, not int.
2092 (make_terminal_frame, set_term_frame_name): Print it.
2093 (x_report_frame_params): In X, window IDs are unsigned long,
2094 not signed long, so print them as unsigned.
2095 (validate_x_resource_name): Check for implausibly long names,
2096 and don't assume name length fits in 'int'.
2097 (x_get_resource_string): Don't blindly alloca invocation name;
2098 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2099 not fit in int.
2100
6e1a67fb
PE
2101 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2102 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2103 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2104
0df02bf3
PE
2105 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2106 Use esprintf, not sprintf, in case result does not fit in int.
2107
48e30793
PE
2108 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2109 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2110 it as a large positive number.
2111 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2112 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2113
a66ff6d8
PE
2114 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2115 in case result does not fit in int.
2116
aca216ff
PE
2117 * print.c (float_to_string): Detect width overflow more reliably.
2118 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2119 buffer overrun. Don't assume list length fits in 'int'. Treat
2120 print length of 0 as 0, not as infinity; to be consistent with other
2121 uses of print length in this function. Don't overflow print length
2122 index. Don't assume hash table size fits in 'long', or that
2123 vectorlike size fits in 'unsigned long'.
2124
31c286f7
PE
2125 * process.c (make_process): Use printmax_t, not int, to format
2126 process-name gensyms.
2127
55e5faa1
PE
2128 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2129
80f2e268
PE
2130 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2131 to avoid potential buffer overrun.
2132
670741ab
PE
2133 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2134 if X resource line is longer than 512 bytes.
2135
b7163a50
PE
2136 * xfns.c (x_window): Make sprintf buffer a bit bigger
2137 to avoid potential buffer overrun.
2138
ae58ff1f
PE
2139 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2140
c43c8a6a
PE
2141 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2142
3f8236f4
PE
21432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2144
53e9fe90 2145 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2146 Without these, Emacs silently mishandles large integers sometimes.
2147 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2148 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2149
6511acf2
PE
2150 * xdisp.c (try_window_id): Check Emacs fixnum range before
2151 converting to 'int'.
806add1d 2152
6511acf2 2153 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2154 Check that an Emacs fixnum is in range before assigning it to 'int'.
2155 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2156 values converted from Emacs fixnums.
2157 (Frecenter): Don't wrap around a line count if it is out of 'int'
2158 range; instead, treat it as an extreme value.
2159 (Fset_window_configuration, compare_window_configurations):
2160 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2161
6511acf2
PE
2162 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2163 that can exceed INT_MAX. Check that EMACS_INT value is in range
2164 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2165 (match_limit): Don't assume that a fixnum can fit in 'int'.
2166
6511acf2 2167 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2168 exceed INT_MAX.
2169
6511acf2 2170 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2171 (Fvertical_motion): Don't wrap around LINES values that don't fit
2172 in 'int'. Instead, treat them as extreme values. This is good
2173 enough for windows, which can't have more than INT_MAX lines anyway.
2174
fcb901a7
LMI
21752011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2176
0f2f6b6d
LMI
2177 * Require libxml/parser.h to avoid compilation warning.
2178
fcb901a7
LMI
2179 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2180
2181 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2182 since this reportedly can destroy thread storage.
2183
6e20a0d4
CY
21842011-08-30 Chong Yidong <cyd@stupidchicken.com>
2185
2186 * syntax.c (find_defun_start): Update all cache variables if
2187 exiting early (Bug#9401).
2188
148ae00e
EZ
21892011-08-30 Eli Zaretskii <eliz@gnu.org>
2190
f6cfbd8f
EZ
2191 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2192
148ae00e
EZ
2193 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2194 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2195 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2196
2197 * term.c (tty_append_glyph): New function.
2198 (produce_stretch_glyph): Static function and its prototype deleted.
2199
a66cfb1c
SM
2200 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2201 Add prototypes.
148ae00e 2202
c4a07a4c
PE
22032011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2204
2205 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2206 when checking :margin (Bug#9390).
2207 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2208 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2209 so that the name doesn't mislead. All uses changed.
2210
6bc8cd65
JB
22112011-08-28 Johan Bockgård <bojohan@gnu.org>
2212
2213 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2214 set_tty_hooks.
2215
dca4927e
EZ
22162011-08-27 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (move_it_to): Don't bail out early when reaching
2219 position beyond to_charpos, if we are scanning backwards.
2220 (move_it_vertically_backward): When DY == 0, make sure we get to
2221 the first character in the line after the newline.
2222
f2cad773
PE
22232011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2226 (ccl_driver): Do not generate an out-of-range pointer.
2227 (Fccl_execute_on_string): Remove unnecessary check for
2228 integer overflow, noted by Stefan Monnier in
2229 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2230 Remove a FIXME that didn't need fixing.
2231 Simplify the newly-introduced buffer reallocation code.
2232
0cae2cdb
JB
22332011-08-27 Juanma Barranquero <lekktu@gmail.com>
2234
2235 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2236
5fc295a4 22372011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2238
70c60eb2 2239 Integer and memory overflow issues (Bug#9196).
726e0ab1 2240
d31850da
PE
2241 * doc.c (get_doc_string): Rework so that
2242 get_doc_string_buffer_size is the actual buffer size, rather than
2243 being 1 less than the actual buffer size; this makes xpalloc more
2244 convenient.
2245
a69fbedb
PE
2246 * image.c (x_allocate_bitmap_record, cache_image):
2247 * xselect.c (Fx_register_dnd_atom):
2248 Simplify previous changes by using xpalloc.
2249
fe5c5d37
PE
2250 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2251 since either will do and ptrdiff_t is convenient with xpalloc.
2252
0065d054
PE
2253 * charset.c (charset_table_size)
2254 (struct charset_sort_data.priority): Now ptrdiff_t.
2255 (charset_compare): Don't overflow if priorities differ greatly.
2256 (Fsort_charsets): Don't assume list length fits in int.
2257 Check for size-calculation overflow when allocating sort data.
2258 (syms_of_charset): Allocate an initial charset table that is
2259 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2260
2261 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2262
2263 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2264 The actual value is always <= INT_MAX, and leaving it unsigned made
2265 overflow checking harder.
2266
2267 * dispextern.h (struct glyph_matrix.rows_allocated)
2268 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2269 with xpalloc. The values are still always <= INT_MAX.
2270
2271 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2272
2273 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2274 (SAFE_NALLOCA): New macro.
2275
2276 * region-cache.c (struct boundary.pos, find_cache_boundary)
2277 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2278 (set_cache_region, invalidate_region_cache)
2279 (revalidate_region_cache, know_region_cache, region_cache_forward)
2280 (region_cache_backward, pp_cache):
2281 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2282 so that ptrdiff_t * can be passed to xpalloc.
2283 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2284 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2285 (pp_cache): Don't assume cache_len fits in int.
2286 * region-cache.h: Adjust extern decls to match.
2287
2288 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2289 EMACS_INT, since either will do, for xpalloc.
2290
2291 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2292 (xnmalloc, xnrealloc, xpalloc): New functions.
2293
726e0ab1
PE
2294 * bidi.c (bidi_shelve_header_size): New constant.
2295 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2296 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2297
51f30bc5 2298 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2299 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2300 (overlay_strings):
2301 Don't update size of array until after memory allocation succeeds,
2302 because xmalloc/xrealloc may not return.
0065d054
PE
2303 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2304 now that we have proper integer overflow checking.
2305 (record_overlay_string, overlay_strings): Catch overflows when
2306 calculating size of overlay_str_buf.
726e0ab1 2307
0065d054
PE
2308 * callproc.c (Fcall_process): Check for size overflow when
2309 calculating size of args2.
2310 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2311 Normally we prefer signed values, but sticking with ptrdiff_t would
2312 require adding more-complicated checks.
726e0ab1
PE
2313
2314 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2315 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2316 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2317 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2318
2319 * character.c (Fstring): Check for size-calculation overflow.
2320
2321 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2322 unnecessary integer overflow. Check for size overflow.
2323 (encode_coding_object): Don't update size until xmalloc succeeds.
2324
2325 * composite.c (get_composition_id): Check for overflow in glyph
2326 length calculations.
2327
2328 Integer and memory overflow fixes for display code.
2329 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2330 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2331 (scrolling_window): Check for overflow in size calculations.
2332 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2333 Don't assume glyph table len fits in int.
2334 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2335 (row_table_size): Now ptrdiff_t, not int.
2336 (scrolling_window): Avoid overflow in size calculations.
2337 Don't update size until allocation succeeds.
2338 * fns.c (concat): Check for overflow in size calculations.
2339 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2340 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2341 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2342
2343 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2344 (get_doc_string): Check for size calculation overflow.
2345 Don't update size until allocation succeeds.
2346 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2347 EMACS_INT, where ptrdiff_t will do.
2348 (Fsubstitute_command_keys): Check for string overflow.
2349
2350 * editfns.c (set_time_zone_rule): Don't assume environment length
2351 fits in int.
2352 (message_length): Now ptrdiff_t, not int.
2353 (Fmessage_box): Don't update size until allocation succeeds.
2354 Don't assume message length fits in int.
2355 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2356
0065d054
PE
2357 * emacs.c (main): Do not reallocate argv, since there is a null at
2358 the end that can be overwritten, and this way there's no need to
2359 worry about size-calculation overflow.
2360 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2361
2362 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2363 alloc succeeds.
2364 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2365
2366 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2367 (x_set_scroll_bar_width, x_figure_window_size):
2368 Check for integer overflow.
2369 (x_set_alpha): Do not assume XINT fits in int.
2370
2371 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2372 This is for the members text_lines, text_cols, total_lines, total_cols,
2373 where the system imposes an 'int' limit.
2374
2375 * fringe.c (Fdefine_fringe_bitmap):
2376 Don't update size until alloc works.
2377
2378 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2379 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2380
2381 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2382 Check for size-calculation overflow.
2383 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2384 do, as we prefer signed integers.
2385 (id_to_widget.max_size, id_to_widget.used)
2386 (xg_store_widget_in_map, xg_remove_widget_from_map)
2387 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2388 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2389 Use and return ptrdiff_t, not int.
2390 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2391 * gtkutil.h: Change prototypes to match the above.
2392
2393 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2394 are duplicate now that they've been promoted to lisp.h.
2395 (x_allocate_bitmap_record, x_alloc_image_color)
2396 (make_image_cache, cache_image, xpm_load):
2397 Don't update size until alloc is done.
2398 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2399 (x_detect_edges):
3256efce 2400 Check for size calculation overflow.
726e0ab1
PE
2401 (ct_colors_allocated_max): New constant.
2402 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2403 overflow.
3256efce 2404
726e0ab1
PE
2405 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2406 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2407 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2408 Use ptrdiff_t, not int, to count maps.
2409 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2410 calculations. Don't update size until allocation succeeds.
2411 Redo calculations to avoid overflow.
726e0ab1
PE
2412 * keyboard.h: Change prototypes to match the above.
2413
2414 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2415 to count maps.
2416 (current_minor_maps): Check for size calculation overflow.
2417 * keymap.h: Change prototypes to match the above.
2418
2419 * lread.c (read1, init_obarray): Don't update size until alloc done.
2420
2421 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2422 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2423
726e0ab1
PE
2424 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2425 Now ptrdiff_t, not int.
2426 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2427 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2428
2429 * process.c (Fnetwork_interface_list): Check for overflow
2430 in size calculation.
2431
2432 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2433
2434 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2435 overflow. Don't bother calling xmalloc when xrealloc will do.
2436
2437 * search.c (Freplace_match): Check for size calculation overflow.
2438 (Fset_match_data): Don't assume list lengths fit in 'int'.
2439
2440 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2441 for command line length. Do not attempt to address one before the
2442 beginning of an array, as that's not portable.
2443
2444 * term.c (max_frame_lines): Remove; unused.
2445 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2446 not int.
2447 (encode_terminal_code, calculate_costs): Check for size
2448 calculation overflow.
2449 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2450 table lengths and related sizes. Don't update size until alloc
2451 done. Redo calculations to avoid overflow.
2452 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2453
2454 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2455 subtracting pointers.
2456 (gobble_line): Check for overflow more carefully. Don't update size
2457 until alloc done.
2458
2459 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2460 Don't update size until alloc done.
2461 Redo size calculations to avoid overflow.
2462 Check for size calculation overflow.
0065d054 2463 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2464
2465 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2466 Use ptrdiff_t, not int, for sizes.
2467 (store_mode_line_noprop_char): Don't update size until alloc done.
2468
0065d054
PE
2469 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2470 Use ptrdiff_t, not int, for sizes.
2471 (Finternal_make_lisp_face, cache_face):
2472 Check for size calculation overflow.
2473 (cache_face): Treat size calculation overflows as if they were
2474 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2475
2476 * xfns.c (x_encode_text, x_set_name_internal)
2477 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2478 sizes, since they can exceed INT_MAX in size. Check for size
2479 calculation overflow.
2480
0065d054
PE
2481 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2482 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2483 Don't update size until alloc done.
2484
0065d054 2485 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2486 as sprintf is limited to int lengths.
1d526e2f 2487
252c5ee1
PE
2488 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2489 (X_LONG_MIN): New macros.
864d7ce7
PE
2490 Use them to make the following changes clearer.
2491 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2492 This change doesn't affect the value now, but it may help remind
2493 future maintainers not to raise the value too much later.
2494 (SELECTION_QUANTUM): Remove, replacing with ...
2495 (selection_quantum): ... new function, which avoids overflow.
2496 All uses changed.
2497 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2498 assumption that selection length fits in 'int'.
2499 (x_reply_selection_request, x_handle_selection_request)
2500 (x_get_window_property, receive_incremental_selection)
2501 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2502 (lisp_data_to_selection_data, clean_local_selection_data):
2503 Use ptrdiff_t, not int, to record length of selection.
2504 (x_reply_selection_request, x_get_window_property)
2505 (receive_incremental_selection, x_property_data_to_lisp):
2506 Redo calculations to avoid overflow.
2507 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2508 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2509 something.
2510 (x_get_window_property, receive_incremental_selection)
2511 (lisp_data_to_selection_data, x_property_data_to_lisp):
2512 Check for size-calculation overflow.
2513 (x_get_window_property, receive_incremental_selection)
2514 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2515 Don't store size until memory allocation succeeds.
2516 (x_get_window_property): Plug memory leak on memory exhaustion.
2517 Don't double-block input; malloc is safe here. Don't assume 2**34
2518 - 4 fits in unsigned long. Add an xassert to check
2519 XGetWindowProperty overflow. Be more careful about overflow
2520 calculations, and distinguish size from memory overflow better.
2521 (receive_incremental_selection): When tracing, don't assume
2522 unsigned int is less than INT_MAX.
2523 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2524 harmful) conversions of unsigned short to int.
2525 (lisp_data_to_selection_data): Don't assume that integers
2526 in the range -65535 through -1 fit in an X unsigned short.
2527 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2528 result parameters unless successful. Rely on cons_to_unsigned
2529 to report problems with elements; the old code wasn't right anyway.
2530 (x_check_property_data): Check for int overflow; we cannot use
2531 a wider type due to X limits.
2532 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2533
726e0ab1 2534 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2535
0065d054
PE
2536 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2537 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2538 (x_color_cells): Don't store size until memory allocation succeeds.
2539 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2540 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2541 (x_term_init): Don't assume length fits in int (sprintf is limited
2542 to int size).
bc18e09d 2543
ebfa62c0
PE
2544 Use ptrdiff_t for composition IDs.
2545 * character.c (lisp_string_width):
2546 * composite.c (composition_table_size, n_compositions)
2547 (get_composition_id, composition_gstring_from_id):
2548 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2549 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2550 * window.c (Frecenter):
2551 Use ptrdiff_t, not int, for composition IDs.
2552 * composite.c (get_composition_id): Check for integer overflow.
2553 * composite.h: Adjust prototypes to match the above changes.
2554
d3411f89
PE
2555 Use ptrdiff_t for hash table indexes.
2556 * category.c (hash_get_category_set):
2557 * ccl.c (ccl_driver):
2558 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2559 * coding.c (coding_system_charset_list, detect_coding_system):
2560 * coding.h (struct coding_system.id):
2561 * composite.c (get_composition_id, gstring_lookup_cache):
2562 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2563 * image.c (xpm_get_color_table_h):
2564 * lisp.h (hash_lookup, hash_put):
2565 * minibuf.c (Ftest_completion):
2566 Use ptrdiff_t for hash table indexes, not int (which is too
2567 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2568 32-bit --with-wide-int hosts).
2569
e097a6fa
PE
2570 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2571 Add a FIXME comment about memory leaks.
2572 (syms_of_charset): Don't assume xmalloc returns.
2573
5637687f
PE
2574 Don't assume that stated character widths fit in int.
2575 * character.c (Fchar_width, c_string_width, lisp_string_width):
2576 * character.h (CHAR_WIDTH):
2577 * indent.c (MULTIBYTE_BYTES_WIDTH):
2578 Use sanitize_char_width to avoid undefined and/or bad behavior
2579 with outlandish widths.
a66cfb1c 2580 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2581 now that we have two such functions. All uses changed.
2582 (sanitize_char_width): New inline function.
2583
a2271ba2
PE
2584 Don't assume that tab-width fits in int.
2585 * character.h (sanitize_width): New inline function.
2586 (SANE_TAB_WIDTH): New macro.
2587 (ASCII_CHAR_WIDTH): Use it.
2588 * indent.c (sane_tab_width): Remove. All uses replaced by
2589 SANE_TAB_WIDTH (current_buffer).
2590 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2591
18c52557
PE
2592 * fileio.c: Integer overflow issues with file modes.
2593 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2594
caeeedc1
PE
2595 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2596 Remove unreachable code.
2597 (read_hex, load_charset_map_from_file): Check for integer overflow.
2598
6df6ae42 2599 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2600 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2601 (x_send_scroll_bar_event): Likewise. Check that the size does not
2602 exceed limits imposed by XClientMessageEvent, as well as the usual
2603 ptrdiff_t and size_t limits.
2604
b13995db
PE
2605 * keyboard.c: Overflow, signedness and related fixes.
2606 (make_lispy_movement): Use same integer type in forward decl
2607 that is used in the definition.
2608 (read_key_sequence, keyremap_step):
2609 Change bufsize argument back to int, undoing my 2011-03-30 change.
2610 We prefer signed types, and int is wide enough here.
2611 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2612 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2613 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2614 length, not size_t. Use ptrdiff_t for index, not int.
2615 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2616 possibility of integer overflow.
2617
13464394
PE
2618 Overflow, signedness and related fixes for images.
2619
2620 * dispextern.h (struct it.stack[0].u.image.image_id)
2621 (struct_it.image_id, struct image.id, struct image_cache.size)
2622 (struct image_cache.used, struct image_cache.ref_count):
2623 * gtkutil.c (update_frame_tool_bar):
2624 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2625 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2626 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2627 * nsmenu.m (update_frame_tool_bar):
2628 * xdisp.c (calc_pixel_width_or_height):
2629 * xfns.c (image_cache_refcount):
2630 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2631 on typical 64-bit hosts.
2632
2633 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2634 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2635 Omit unnecessary casts to int.
2636 (parse_image_spec): Check that integers fall into 'int' range
2637 when the callers expect that.
2638 (image_ascent): Redo ascent calculation to avoid int overflow.
2639 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2640 (lookup_image): Remove unnecessary tests.
2641 (xbm_image_p): Locals are now of int, not EMACS_INT,
2642 since parse_image_check makes sure they fit into int.
2643 (png_load, gif_load, svg_load_image):
2644 Prefer int to unsigned where either will do.
2645 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2646 old tiff_error_handler and tiff_warning_handler.
2647 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2648 stack buffer overflows. It uses only the features of vsnprintf
2649 that are common to both POSIX and native Microsoft.
2650 (tiff_error_handler, tiff_warning_handler): Use it.
2651 (tiff_load, gif_load, imagemagick_load_image):
2652 Don't assume :index value fits in 'int'.
2653 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2654 (imagemagick_load_image): Check that crop parameters fit into
2655 the integer types that MagickCropImage accepts. Don't assume
2656 Vimagemagick_render_type has a nonnegative value. Don't assume
2657 size_t fits in 'long'.
2658 (gs_load): Use printmax_t to print the widest integers possible.
2659 Check for integer overflow when computing image height and width.
2660
c11821d4
EZ
26612011-08-26 Eli Zaretskii <eliz@gnu.org>
2662
2663 * xdisp.c (redisplay_window): Don't force window start if point
2664 will be invisible in the resulting window. (Bug#9324)
2665
0c95fcf7
EZ
26662011-08-25 Eli Zaretskii <eliz@gnu.org>
2667
2668 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2669 the display spec is of the form `(space ...)'.
2670 (handle_display_spec): Return the value returned by
2671 handle_single_display_spec, not just 1 or zero.
2672 (handle_single_display_spec): If the display spec is of the form
2673 `(space ...)', and specifies display in the text area, return 2
2674 rather than 1.
fee65a97 2675 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2676 accurately, and prefer exact match for point under bidi.
2677 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2678
2679 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2680 into disp_prop; all users changed.
2681
2682 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2683 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2684 for the text covered by the display property.
2685
e4ed06f1
CY
26862011-08-25 Chong Yidong <cyd@stupidchicken.com>
2687
2688 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2689 Change return value to nil.
2690 (Frecord_buffer): Delete unused function.
2691
f67cdd7f
EZ
26922011-08-24 Eli Zaretskii <eliz@gnu.org>
2693
5980d4c6
EZ
2694 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2695 buffers, return left-to-right.
8610fe8b
EZ
2696 (set_cursor_from_row): Consider candidate row a win if its glyph
2697 represents a newline and point is on that newline. Fixes cursor
2698 positioning on the newline at EOL of R2L text within L2R
2699 paragraph, and vice versa.
2700 (try_cursor_movement): Check continued rows, in addition to
2701 continuation rows. Fixes unwarranted scroll when point enters a
2702 continued line of R2L text within an L2R paragraph, or vice versa.
2703 (cursor_row_p): Consider the case of point being equal to
2704 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2705 from the end of a short line to the beginning of a continued line
2706 of R2L text within L2R paragraph.
2707 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2708 composed characters.
5980d4c6 2709
f67cdd7f
EZ
2710 * bidi.c (bidi_check_type): Use xassert.
2711 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2712 members.
2713
bca633fb
EZ
27142011-08-23 Eli Zaretskii <eliz@gnu.org>
2715
2716 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2717 a character.
2718
4a5885a7
CY
27192011-08-23 Chong Yidong <cyd@stupidchicken.com>
2720
2721 * nsfont.m (ns_otf_to_script): Fix typo.
2722
0902a04e
KH
27232011-08-22 Kenichi Handa <handa@m17n.org>
2724
2725 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2726 extra slot even if the purpose is char-code-property-table.
2727
1a2e6670
EZ
27282011-08-23 Eli Zaretskii <eliz@gnu.org>
2729
8ddde651
EZ
2730 * xdisp.c (redisplay_window): When computing centering_position,
2731 account for the height of the header line. (Bug#8874)
2732
425cc014
EZ
2733 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2734 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2735 candidate is selected by the mouse, and that candidate has a
2736 composed character under the mouse.
2737
1a2e6670
EZ
2738 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2739 coordinates reported by pos-visible-in-window-p for a composed
2740 character in column zero.
2741
8b76d6f8
SM
27422011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2743
2744 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2745
dac347dd
EZ
27462011-08-22 Eli Zaretskii <eliz@gnu.org>
2747
2748 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2749 consider it a hit if to_charpos is anywhere in the range of the
2750 composed buffer positions.
2751
e013fb34
CY
27522011-08-22 Chong Yidong <cyd@stupidchicken.com>
2753
2754 * image.c (gif_load): Don't assume that each subimage has the same
2755 dimensions as the base image. Handle disposal method that is
2756 "undefined" by the gif spec (Bug#9335).
2757
bd1ba3e8
CY
27582011-08-20 Chong Yidong <cyd@stupidchicken.com>
2759
2760 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2761 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2762
54a1215b
EZ
27632011-08-19 Eli Zaretskii <eliz@gnu.org>
2764
823564e5
EZ
2765 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2766 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2767 from an Org mode buffer to a Speedbar frame.
2768
54a1215b
EZ
2769 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2770 a composition, take its buffer position from IT->cmp_it.charpos.
2771 Fixes cursor positioning at the beginning of a line that begins
2772 with a composed character.
2773
9778ebcc
EZ
27742011-08-18 Eli Zaretskii <eliz@gnu.org>
2775
0be6ee06
EZ
2776 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2777 character bidirectional type, use STRONG_L instead. Fixes crashes
2778 in a buffer produced by `describe-categories'.
2779
9778ebcc
EZ
2780 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2781 members before the level stack, so they would be saved and
2782 restored when copying iterator state. Fixes incorrect reordering
2783 around TABs covered by display properties.
2784
156bffbe
AS
27852011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2786
6b02f655 2787 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2788
72ad093b
CY
27892011-08-17 Chong Yidong <cyd@stupidchicken.com>
2790
2791 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2792 (internal_condition_case_2, internal_condition_case_n):
2793 Remove unnecessary aborts (Bug#9081).
72ad093b 2794
35774242
EZ
27952011-08-17 Eli Zaretskii <eliz@gnu.org>
2796
2797 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2798 has no `load' handler, try opening the file locally. (Bug#9311)
2799
db76dd85
KB
28002011-08-16 Ken Brown <kbrown@cornell.edu>
2801
2802 * gmalloc.c: Expand comment.
2803
b215eee5
EZ
28042011-08-16 Eli Zaretskii <eliz@gnu.org>
2805
2806 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2807 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2808
a4579d33
KB
28092011-08-16 Ken Brown <kbrown@cornell.edu>
2810
2811 Fix memory allocation problems in Cygwin build (Bug#9273).
2812
2813 * unexcw.c ( __malloc_initialized): Declare external variable.
2814 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2815
8b76d6f8
SM
2816 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2817 New variables.
a4579d33
KB
2818 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2819 dumped emacs.
2820 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2821 in the static heap.
2822 [CYGWIN] (special_realloc): New function.
2823 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2824 requests to realloc storage in the static heap.
2825
3ebec551
PE
28262011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 * bidi.c (bidi_initialize): Remove unused local.
2829
9fd8be00
EZ
28302011-08-15 Eli Zaretskii <eliz@gnu.org>
2831
6b02f655
SM
2832 * bidimirror.h:
2833 * biditype.h: Remove file.
2834 * makefile.w32-in ($(BLD)/bidi.$(O)):
2835 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2836
2837 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2838
2839 * chartab.c: Improve commentary for the uniprop_table API.
2840
32413314
EZ
2841 * bidi.c (bidi_paragraph_init): Support zero value of
2842 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2843 (bidi_initialize): Use uniprop_table instead of including
2844 biditype.h and bidimirror.h.
32413314 2845
9fd8be00
EZ
2846 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2847 coordinates of the iterator when restoring from ppos_it.
2848 (Bug#9296)
2849
5cf2b69b
KH
28502011-08-14 Kenichi Handa <handa@m17n.org>
2851
2852 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2853 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2854
daf17d00
EZ
28552011-08-14 Eli Zaretskii <eliz@gnu.org>
2856
2857 * xdisp.c (move_it_in_display_line_to): Don't invoke
2858 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2859 ppos_it. Fixes vertical cursor motion when line beginning is
2860 covered by an image. (Bug#9296)
2861
08e3161a
JD
28622011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2863
2864 * nsterm.h (ns_run_ascript): Declare.
2865 (NSAPP_DATA2_RUNASSCRIPT): Define.
2866
2867 * nsfns.m (as_script, as_result, as_status): New static variables.
2868 (ns_run_ascript): New function.
5e617bc2 2869 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2870 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2871 the event loop. Get status from as_status (Bug#7276).
2872
2873 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2874 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2875 the event loop (Bug#7276).
2876
a3720aa2
AS
28772011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2878
2879 * gnutls.c (QCgnutls_bootprop_priority)
2880 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2881 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2882 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2883 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2884 (QCgnutls_bootprop_verify_hostname_error)
2885 (QCgnutls_bootprop_callbacks_verify): Rename from
2886 Qgnutls_bootprop_..., all uses changed.
2887
2888 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2889 uses changed.
2890
0a0d27fb
PE
28912011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2892
19d5c50c
PE
2893 * xfaces.c (Qframe_set_background_mode): Now static.
2894 * dispextern.h (Qframe_set_background_mode): Remove decl.
2895
0a0d27fb
PE
2896 * process.c (Fnetwork_interface_info): Declare local only if needed.
2897
377538cb
JD
28982011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2899
2900 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2901 (Fnetwork_interface_list): Allocate in increments of bytes instead
2902 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2903 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2904 sockaddr.
2905 (struct ifflag_def): notrailers is smart on OSX.
2906 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2907 Get hardware address with getifaddrs if available.
2908
08fff70c
EZ
29092011-08-12 Eli Zaretskii <eliz@gnu.org>
2910
2911 * xdisp.c (iterate_out_of_display_property): xassert that
2912 IT->position is set to within IT->object's boundaries. Break from
2913 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2914 when IT->position is set up wrongly due to some bug.
2915 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2916 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2917 entry. Force push_it to save on the stack the current
2918 buffer/string position, to be restored by pop_it. Fix flags in
2919 the iterator structure wrt the object coming from a display
2920 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2921 properties. (Bug#9284)
2922
7be1c708 29232011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2924
7be1c708
CY
2925 * fontset.c (fontset_get_font_group): Add proper type checks.
2926 (Bug#9172)
aac0c6e3 2927
7be1c708 29282011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2929
7be1c708
CY
2930 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2931 and LC_VERSION_MIN_MACOSX.
2932 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2933 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2934
97bb72a6
EZ
29352011-08-08 Eli Zaretskii <eliz@gnu.org>
2936
2937 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2938 no-display-properties-and-no-overlays under bidi display.
2939 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2940 properties and overlays.
97bb72a6 2941
d5617611
CY
29422011-08-08 Chong Yidong <cyd@stupidchicken.com>
2943
37e11a63
CY
2944 * editfns.c (Fset_time_zone_rule): Document relationship with the
2945 setenv function.
2946
d5617611
CY
2947 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2948 the font entity extracted from the cache (Bug#8109).
2949
58872834
CY
29502011-08-07 Chong Yidong <cyd@stupidchicken.com>
2951
2952 * composite.c (autocmp_chars): Don't reset point. That is done by
2953 restore_point_unwind (Bug#5984).
2954
75bfc667
JL
29552011-08-07 Juri Linkov <juri@jurta.org>
2956
2957 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2958 to show the arg `TIME' instead of `TIMEVAL'.
2959
d1410150
EZ
29602011-08-06 Eli Zaretskii <eliz@gnu.org>
2961
2962 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2963 display property strides EOL and includes a newline, as in
2964 longlines-mode. (Bug#9254)
75b771e4
EZ
2965 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2966 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2967
2968 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2969 is non-zero, even if the data buffer is NULL. Fixes a crash in
2970 vertical-motion with longlines-mode. (Bug#9254)
2971
35928349
EZ
29722011-08-05 Eli Zaretskii <eliz@gnu.org>
2973
ec7cc85b
EZ
2974 * bidi.c <bidi_cache_total_alloc>: Now static.
2975 (bidi_initialize): Initialize bidi_cache_total_alloc.
2976
8b76d6f8 2977 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2978 cache. (Bug#9221)
2979
2980 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2981 amount allocated this far in `bidi_cache_total_alloc'.
2982 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2983 non-zero, only free the data buffer without restoring the cache
2984 contents. All callers changed.
2985
2986 * dispextern.h (bidi_unshelve_cache): Update prototype.
2987
2988 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2989 (move_it_in_display_line, move_it_to)
2990 (move_it_vertically_backward, move_it_by_lines): Replace the call
2991 to xfree to an equivalent call to bidi_unshelve_cache.
2992 (move_it_in_display_line_to): Fix logic of returning
412b6358 2993 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2994
e2e2423b
EZ
29952011-08-05 Eli Zaretskii <eliz@gnu.org>
2996
2997 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2998 came from a string character with a `cursor' property. (Bug#9229)
2999
ae9e757a
JD
30002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3001
3002 * Makefile.in (LIB_PTHREAD): New variable.
3003 (LIBES): Add LIB_PTHREAD (Bug#9216).
3004
3005 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3006 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3007
213bd7f2
AS
30082011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3009
6b02f655 3010 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3011
99aaf75f
JD
30122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3013
3014 * xterm.c (x_find_topmost_parent): New function.
3015 (x_set_frame_alpha): Find topmost parent window with
3016 x_find_topmost_parent and set the property there also (bug#9181).
3017 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3018
c74e9d86
PE
30192011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3020
3021 * callproc.c (Fcall_process): Avoid vfork clobbering
3022 the local vars buffer, coding_systems, current_dir.
3023
640c8776
SM
30242011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3025
3026 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3027
f26d0e4c
PE
30282011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3029
8a10d76c
PE
3030 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3031 so that it is not optimized away.
3032
f26d0e4c
PE
3033 * xdisp.c (compute_display_string_pos): Remove unused local.
3034
55439c61
EZ
30352011-08-02 Eli Zaretskii <eliz@gnu.org>
3036
3037 Fix slow cursor motion and scrolling in large buffers with
3038 selective display, like Org Mode buffers. (Bug#9218)
3039
3040 * dispextern.h (struct bidi_it): New member disp_prop_p.
3041
3042 * xdisp.c: Remove one-slot cache of display string positions.
3043 (compute_display_string_pos): Accept an additional argument
5e617bc2 3044 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3045 for a display string or property. If found, set DISP_PROP_P
3046 non-zero.
3047
3048 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3049 DISP_PROP_P, and pass it to compute_display_string_pos.
3050 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3051 non-zero. All callers of bidi_fetch_char changed.
3052
fb33fa43
SM
30532011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3054
3055 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3056
b099e063
DM
30572010-12-03 Don March <don@ohspite.net>
3058
3059 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3060 last character M-[char] is translated to ESC [char] (bug#7541).
3061
5cc7f7af
KH
30622011-08-02 Kenichi Handa <handa@m17n.org>
3063
d0fffa3f 3064 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3065
3066 * chartab.c (uniprop_table): Make it non-static.
3067
525d5e6e
EZ
30682011-08-01 Eli Zaretskii <eliz@gnu.org>
3069
3070 * xdisp.c (forward_to_next_line_start): Accept additional argument
3071 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3072 on the newline.
3073 (reseat_at_next_visible_line_start): Use the bidi iterator state
3074 returned by forward_to_next_line_start to restore the state of
3075 it->bidi_it after backing up to previous newline. (Bug#9212)
3076
31011111
AS
30772011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3078
3079 * regex.c (re_comp): Protoize.
3080 (re_exec): Fix return type.
3081 (regexec): Fix type of `ret'. (Bug#9203)
3082
476371c4
PE
30832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3084
e5d76069
PE
3085 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3086 This is needed if max-image-size is a floating-point number.
3087
9a79b20c
AS
30882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3089
3090 * print.c (print_object): Print empty symbol as ##.
3091
3092 * lread.c (read1): Read ## as empty symbol.
3093
d8c2fa78
AA
30942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3095
3096 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3097 setting frame foreground color (Bug#9175).
3098 (x_set_background_color): Likewise.
3099
ffe57a7a
AA
3100 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3101 contents (Bug#9176).
3102 (EmacsTooltip -init): Remove bezels and add shadows to
3103 tooltip windows.
3104
bf3492a5
AA
3105 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3106 or scroll bar (Bug#8470).
3107
d55e9c53
AA
3108 * nsfont.m (nsfont_open): Remove assignment to voffset and
3109 unnecessary vars hshink, expand, hd, full_height, min_height.
3110 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3111
3112 * nsterm.h (nsfont_info): Remove voffset field.
3113
d8c2fa78 31142011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3115
3116 Implement strike-through and overline on NextStep (Bug#8863).
3117
3118 * nsfont.m (nsfont_open): Use underline position provided by font,
3119 instead of hard-coded value of 2.
3120 (nsfont_draw): Call ns_draw_text_decoration instead.
3121
3122 * nsterm.h: Add declaration for ns_draw_text_decoration.
3123
3124 * nsterm.m (ns_draw_text_decoration): New function for drawing
3125 underline, overline, and strike-through.
3126 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3127 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3128 accommodate underlining, etc.
4843aac3 3129
4cc60b9b
EZ
31302011-07-28 Eli Zaretskii <eliz@gnu.org>
3131
bc7ece87
EZ
3132 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3133 default.
4cc60b9b 3134
476371c4
PE
31352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3136
66606eea
PE
3137 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3138 Without this fix, if a signal arrives just after memory fills up,
3139 'malloc' might be invoked reentrantly.
3140
476371c4
PE
3141 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3142 In other words, assume that every image size is allowed, on non-X
3143 hosts. This assumption is probably wrong, but it lets Emacs compile.
3144
f3fcc40d
AS
31452011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3146
3147 * regex.c (re_iswctype): Convert return values to boolean.
3148
350c992f
EZ
31492011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3150
3151 * xdisp.c (compute_display_string_pos): Don't use cached display
3152 string position if the buffer had its restriction changed.
3153 (Bug#9184)
3154
5266b4bb
PE
31552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3156
3157 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3158
2573a837 31592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3160
41f55ccd 3161 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3162
39e378da
PE
3163 * bidi.c: Integer size and overflow fixes.
3164 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3165 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3166 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3167 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3168 (bidi_find_other_level_edge):
3169 Use ptrdiff_t instead of EMACS_INT where either will do.
3170 This works better on 32-bit hosts configured --with-wide-int.
3171 (bidi_cache_ensure_space): Check for size-calculation overflow.
3172 Use % rather than repeated addition, for better worst-case speed.
3173 Don't set bidi_cache_size until after xrealloc returns, because it
3174 might not return.
3175 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3176 (bidi_cache_ensure_space): Also check that the bidi cache size
3177 does not exceed that of the largest Lisp string or buffer. See Eli
3178 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3179
5e927815
PE
3180 * alloc.c (__malloc_size_t): Remove.
3181 All uses replaced by size_t. See Andreas Schwab's note
3182 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3183
ca4aa935
PE
3184 * image.c: Improve checking for integer overflow.
3185 (check_image_size): Assume that f is nonnull, since
3186 it is always nonnull in practice. This is one less thing to
3187 worry about when checking for integer overflow later.
3188 (x_check_image_size): New function, which checks for integer
3189 overflow issues inside X.
3190 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3191 This removes the need for a memory_full check.
3192 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3193 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3194 (xbm_read_bitmap_data): Change locals back to 'int', since
3195 their values must fit in 'int'.
3196 (xpm_load_image, png_load, tiff_load):
3197 Invoke x_create_x_image_and_pixmap earlier,
3198 to avoid much needless work if the image is too large.
3199 (tiff_load): Treat overly large images as if
3200 x_create_x_image_and_pixmap failed, not as malloc failures.
3201 (gs_load): Use x_check_image_size.
3202
5f8f9cc2
PE
3203 * gtkutil.c: Omit integer casts.
3204 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3205 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3206
5adf60bc
PE
3207 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3208
c8907a93
PE
3209 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3210 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3211 would wrongly return t on a 64-bit host.
3212
e3c25c68
PE
3213 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3214 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3215 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3216 and therefore cause GCC to emit a bogus diagnostic in some cases.
3217
3f791afe
PE
3218 * image.c: Integer signedness and overflow and related fixes.
3219 This is not an exhaustive set of fixes, but it's time to
3220 record what I've got.
3221 (lookup_pixel_color, check_image_size): Remove redundant decls.
3222 (check_image_size): Don't assume that arbitrary EMACS_INT values
3223 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3224 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3225 (tiff_load, imagemagick_load_image):
3226 Check for overflow in size calculations.
3227 (x_create_x_image_and_pixmap): Remove unnecessary test for
3228 xmalloc returning NULL; that can't happen.
3229 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3230 (xpm_color_bucket): Use better integer hashing function.
3231 (xpm_cache_color): Don't possibly over-allocate memory.
3232 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3233 (gif_memory_source):
3234 Use ptrdiff_t, not int or size_t, to record sizes.
3235 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3236 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3237 either works, as we prefer signed integers.
3238 (tiff_read_from_memory, tiff_write_from_memory):
3239 Return tsize_t, not size_t, since that's what the TIFF API wants.
3240 (tiff_read_from_memory): Don't fail simply because the read would
3241 go past EOF; instead, return a short read.
3242 (tiff_load): Omit no-longer-needed casts.
3243 (Fimagemagick_types): Don't assume size fits into 'int'.
3244
3cc5a532
PE
3245 Improve hashing quality when configured --with-wide-int.
3246 * fns.c (hash_string): New function, taken from sxhash_string.
3247 Do not discard information about ASCII character case; this
3248 discarding is no longer needed.
3249 (sxhash-string): Use it. Change sig to match it. Caller changed.
3250 * lisp.h: Declare it.
3251 * lread.c (hash_string): Remove, since we now use fns.c's version.
3252 The fns.c version returns a wider integer if --with-wide-int is
3253 specified, so this should help the quality of the hashing a bit.
3254
b312a492
PE
3255 * emacs.c: Integer overflow minor fix.
3256 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3257 Define only if GNU_LINUX.
3258 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3259
dfd153ae
PE
3260 * dispnew.c: Integer signedness and overflow fixes.
3261 Remove unnecessary forward decls, that were a maintenance hassle.
3262 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3263 All uses changed.
3264 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3265 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3266 (prepare_desired_row, line_draw_cost):
3267 Use int, not unsigned, where either works.
3268 (save_current_matrix, restore_current_matrix):
3269 Use ptrdiff_t, not size_t, where either works.
3270 (init_display): Check for overflow more accurately, and without
3271 relying on undefined behavior.
3272
a81d11a3
PE
3273 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3274 Remove, replacing with the new symbols in lisp.h. All uses changed.
3275 * fileio.c (make_temp_name):
3276 * filelock.c (lock_file_1, lock_file):
3277 * xdisp.c (message_dolog):
3278 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3279 Use pMd etc. instead.
3280 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3281 replacing the pWIDE etc. symbols removed from editfns.c.
3282
3300e6fd
PE
3283 * keyboard.h (num_input_events): Now uintmax_t.
3284 This is (very slightly) less likely to mess up due to wraparound.
3285 All uses changed.
3286
fd05c7e9
PE
3287 * buffer.c: Integer signedness fixes.
3288 (alloc_buffer_text, enlarge_buffer_text):
3289 Use ptrdiff_t rather than size_t when either will do, as we prefer
3290 signed integers.
3291
903fe15d
PE
3292 * alloc.c: Integer signedness and overflow fixes.
3293 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3294 (__malloc_size_t): Default to size_t, not to int.
3295 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3296 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3297 Prefer ptrdiff_t to size_t when either would do, as we prefer
3298 signed integers.
3299 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3300 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3301 Now const. Initialize with values that are in range even if char
3302 is signed.
3303 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3304 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3305 These functions do the right thing with sizes > 2**32.
3306 (check_depth): Now ptrdiff_t, not int.
3307 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3308 Adjust to new way of storing sizes. Check for size overflow bugs
3309 in rest of code.
3310 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3311 slightly wrong anyway, as it missed one instance of
3312 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3313 (refill_memory_reserve): Omit needless cast to size_t.
3314 (mark_object_loop_halt): Mark as externally visible.
3315
ac82cc6a
PE
3316 * xselect.c: Integer signedness and overflow fixes.
3317 (Fx_register_dnd_atom, x_handle_dnd_message):
3318 Use ptrdiff_t, not size_t, since we prefer signed.
3319 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3320 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3321 x_dnd_atoms_size and x_dnd_atoms_length.
3322
c2d1e36d
PE
3323 * doprnt.c: Prefer signed to unsigned when either works.
3324 * eval.c (verror):
3325 * doprnt.c (doprnt):
3326 * lisp.h (doprnt):
3327 * xdisp.c (vmessage):
3328 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3329 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3330 prefer signed arithmetic to avoid comparison confusion.
3331 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3332 but is a bit tricky.
3333
0e926e56
PE
3334 Assume freestanding C89 headers, string.h, stdlib.h.
3335 * data.c, doprnt.c, floatfns.c, print.c:
3336 Include float.h unconditionally.
3337 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3338 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3339 * regex.c: Likewise for stddef.h, string.h.
3340 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3341 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3342 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3343 (STDC_HEADERS): Remove obsolete defines.
3344 * sysdep.c: Include limits.h unconditionally.
3345
9cfdb3ec
PE
3346 Assume support for memcmp, memcpy, memmove, memset.
3347 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3348 * regex.c (memcmp, memcpy):
3349 Remove; we assume C89 now.
3350
3351 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3352 (__malloc_safe_bcopy): Remove; no longer needed.
3353
cf950e6b 3354 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3355 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3356 well either way, and we prefer signed to unsigned.
3357
dbf38e02
LMI
33582011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3359
3360 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3361 closes the connection while we're reading (bug#9182).
3362
d6f0886c 33632011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3364
d6f0886c
JD
3365 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3366 are specified (Bug#9168).
24e0f6b1 3367
2eb1f9e6
PE
33682011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3369
3370 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3371 Found by GCC static checking and --with-wide-int on a 32-bit host.
3372
22381272 33732011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3374
3375 * xdisp.c (compute_display_string_pos): Fix logic of caching
3376 previous display string position. Initialize cached_prev_pos to
3377 -1. Fixes slow-down at the beginning of a buffer.
3378
f25e39b4
EZ
33792011-07-24 Eli Zaretskii <eliz@gnu.org>
3380
3381 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3382 for attrs[LFACE_FONTSET_INDEX].
3383
04c4b52e
PE
33842011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3385
3386 * xml.c (parse_region): Remove unused local
3387 that was recently introduced.
3388
c1734fbd
EZ
33892011-07-23 Eli Zaretskii <eliz@gnu.org>
3390
be18c5a5
EZ
3391 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3392 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3393
c1734fbd
EZ
3394 * xdisp.c (move_it_in_display_line_to): Record the best matching
3395 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3396 exit if none of the characters scanned was an exact match.
3397 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3398 when exact match is impossible due to invisible text, and the
3399 lines are truncated.
3400
a258d627
JD
34012011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3402
3403 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3404 for OSX >= 10.7.
3405
b6d5a689
EZ
34062011-07-22 Eli Zaretskii <eliz@gnu.org>
3407
0f74f785
EZ
3408 Fix a significant slow-down of cursor motion with C-n, C-p,
3409 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3410 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3411 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3412 (next_element_from_buffer): Call compute_stop_pos_backwards to
3413 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3414 base_level_stop.
3415 (reseat): Don't look for prev_stop, as that could mean a very long
3416 run.
3417 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3418 <cached_disp_overlay_modiff>: Cache for last found display string
3419 position.
551918c1 3420 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3421 about the same buffer in the same area of character positions, and
3422 the buffer wasn't changed since the time the display string
3423 position was cached.
551918c1 3424
b2d0c91a
EZ
34252011-07-22 Eli Zaretskii <eliz@gnu.org>
3426
3427 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3428 is an integer, which is important for empty lines. (Bug#9149)
3429
043604ee
CY
34302011-07-22 Chong Yidong <cyd@stupidchicken.com>
3431
3432 * frame.c (Fmodify_frame_parameters): In tty case, update the
3433 default face if necessary (Bug#4238).
3434
da4adb04
CY
34352011-07-21 Chong Yidong <cyd@stupidchicken.com>
3436
3437 * editfns.c (Fstring_to_char): No need to explain what a character
3438 is in the docstring (Bug#6576).
3439
9abd0532
LMI
34402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3441
3442 * xml.c (parse_region): Make sure we always return a tree.
3443
36881d16
HK
34442011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3445
3446 * xml.c (parse_region): If a document contains only comments,
3447 return that, too.
3448
1e98674d
LMI
34492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3450
3451 * xml.c (make_dom): Return comments, too.
3452
590bd467
PE
34532011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 Port to OpenBSD.
3456 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3457 and the surrounding thread.
3458 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3459 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3460 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3461 timer goes off.
3462 * s/openbsd.h (BROKEN_SIGIO): Define.
3463 * unexelf.c (unexec) [__OpenBSD__]:
3464 Don't update the .mdebug section of the Alpha COFF symbol table.
3465
f41628b2
LMI
34662011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3467
3468 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3469 (bug#8460).
3470
b59b67c5
PE
34712011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3472
15e3a074
PE
3473 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3474 This fixes some race conditions on the permissions of any newly
3475 created file.
3476
41bed37d
PE
3477 * alloc.c (valid_pointer_p): Use pipe, not open.
3478 This fixes some permissions issues when debugging.
3479
b59b67c5
PE
3480 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3481 If fchown fails to set both uid and gid, try to set just gid,
3482 as that is sometimes allowed. Adjust the file's mode to eliminate
3483 setuid or setgid bits that are inappropriate if fchown fails.
3484
925a6be7
SM
34852011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3486
3487 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3488 to compare Lisp_Objects.
3489 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3490 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3491 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3492
52968808
AS
34932011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3494
0a6a104b
AS
3495 * lread.c (read_integer): Unread even EOF character.
3496 (read1): Likewise. Properly record start position of symbol.
3497
52968808
AS
3498 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3499 symbol character follows.
3500
9e381cdd
PE
35012011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3502
3503 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3504 This works around a problem with the previous change to Fcopy_file.
3505 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3506 and without this change, GCC might complain about discarding
3507 fchown's return value.
3508
b5641435
JB
35092011-07-16 Juanma Barranquero <lekktu@gmail.com>
3510
3511 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3512
a8031457
PE
35132011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3516
dd889327
LMI
35172011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3518
750c33f7
LMI
3519 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3520 it's used from the C level.
3521
dd889327
LMI
3522 * process.c: Use the same condition for POLL_FOR_INPUT in both
3523 keyboard.c and process.c (bug#1858).
3524
87e86684
LM
35252011-07-09 Lawrence Mitchell <wence@gmx.li>
3526
3527 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3528 (Fgnutls_boot): Use it.
3529
64348f40
AS
35302011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3531
3532 * doc.c (Fsubstitute_command_keys): Revert last change.
3533
1d698799
LMI
35342011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3535
f863868c
LMI
3536 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3537 quotes the next character, and doesn't affect other longer
3538 sequences (bug#8935).
3539
1d698799
LMI
3540 * lread.c (syms_of_lread): Clarify that is isn't only
3541 `eval-buffer' and `eval-defun' that's affected by
3542 `lexical-binding' (bug#8460).
3543
aa4b6df6
EZ
35442011-07-15 Eli Zaretskii <eliz@gnu.org>
3545
3546 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3547 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3548
5d856da6
PE
35492011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3550
ad6042bb
PE
3551 Fix minor problems found by static checking.
3552 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3553 (elsz): Now a signed constant, not a size_t var. We prefer signed
3554 types to unsigned, to avoid integer comparison confusion. Without
3555 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3556 "cannot optimize loop, the loop counter may overflow", a symptom
3557 of the confusion.
f00bbb22 3558 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3559 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3560
6468f31c
LMI
35612011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3562
49080b10
LMI
3563 * search.c (Fre_search_backward): Mention `case-fold-search' in
3564 all the re_search_* functions (bug#8138).
3565
6468f31c
LMI
3566 * keyboard.c (Fopen_dribble_file): Document when the file is
3567 closed (bug#8056).
3568
c965adc5
EZ
35692011-07-14 Eli Zaretskii <eliz@gnu.org>
3570
df9733bf
EZ
3571 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3572 bidi_cache_idx.
3573
0bb23927
EZ
3574 Support bidi reordering of display and overlay strings.
3575 * xdisp.c (compute_display_string_pos)
3576 (compute_display_string_end): Accept additional argument STRING.
3577 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3578 (reseat_to_string): Initialize bidi_it->string.s and
3579 bidi_it->string.schars.
3580 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3581 NULL (avoids a crash in bidi_paragraph_init).
3582 Initialize itb.string.lstring.
0bb23927
EZ
3583 (init_iterator): Call bidi_init_it only of a valid
3584 buffer position was specified. Initialize paragraph_embedding to
3585 L2R.
3586 (reseat_to_string): Initialize the bidi iterator.
3587 (display_string): If we need to ignore text properties of
3588 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3589 original value of -1 will not work with bidi.)
3590 (compute_display_string_pos): First arg is now struct
3591 `text_pos *'; all callers changed. Support display properties on
3592 Lisp strings.
3593 (compute_display_string_end): Support display properties on Lisp
3594 strings.
3595 (init_iterator, reseat_1, reseat_to_string): Initialize the
3596 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3597 when iterating on a string not from display properties).
640c8776
SM
3598 (compute_display_string_pos, compute_display_string_end):
3599 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3600 arrow keys.
3601 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3602 base_level_stop; instead, set base_level_stop to BEGV.
3603 Fixes crashes in vertical-motion.
0bb23927
EZ
3604 (next_element_from_buffer): Improve commentary for when
3605 the iterator is before prev_stop.
3606 (init_iterator): Initialize bidi_p from the default value of
3607 bidi-display-reordering, not from buffer-local value. Use the
3608 buffer-local value only if initializing for buffer iteration.
3609 (handle_invisible_prop): Support invisible properties on strings
3610 that are being bidi-reordered.
3611 (set_iterator_to_next): Support bidi reordering of C strings and
3612 Lisp strings.
3613 (next_element_from_string): Support bidi reordering of Lisp
3614 strings.
3615 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3616 (display_string): Support display of R2L glyph rows.
3617 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3618 (init_iterator): Don't initialize it->bidi_p for strings
3619 here.
3620 (reseat_to_string): Initialize it->bidi_p for strings here.
3621 (next_element_from_string, next_element_from_c_string)
3622 (next_element_from_buffer): Add xassert's for correspondence
3623 between IT's object being iterated and it->bidi_it.string
3624 structure.
3625 (face_before_or_after_it_pos): Support bidi iteration.
3626 (next_element_from_c_string): Handle the case of the first string
3627 character that is not the first one in the visual order.
3628 (get_visually_first_element): New function, refactored from common
3629 parts of next_element_from_buffer, next_element_from_string, and
3630 next_element_from_c_string.
3631 (tool_bar_lines_needed, redisplay_tool_bar)
3632 (display_menu_bar): Force left-to-right direction. Add a FIXME
3633 comment for making that be controlled by a user option.
3634 (push_it, pop_it): Save and restore the state of the
3635 bidi iterator. Save and restore the bidi_p flag.
3636 (pop_it): Iterate out of display property for string iteration as
3637 well.
3638 (iterate_out_of_display_property): Support iteration over strings.
3639 (handle_single_display_spec): Set up it->bidi_it for iteration
3640 over a display string, and call bidi_init_it.
3641 (handle_single_display_spec, next_overlay_string)
3642 (get_overlay_strings_1, push_display_prop): Set up the bidi
3643 iterator for displaying display or overlay strings.
3644 (forward_to_next_line_start): Don't use the shortcut if
3645 bidi-iterating.
3646 (back_to_previous_visible_line_start): If handle_display_prop
3647 pushed the iterator stack, restore the internal state of the bidi
3648 iterator by calling bidi_pop_it same number of times.
3649 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3650 and we are bidi-iterating, don't decrement the iterator position;
3651 instead, set the first_elt flag in the bidi iterator, to produce
3652 the same effect.
3653 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3654 (push_display_prop): xassert that we are iterating a buffer.
3655 (push_it, pop_it): Save and restore paragraph_embedding member.
3656 (handle_single_display_spec, next_overlay_string)
3657 (get_overlay_strings_1, reseat_1, reseat_to_string)
3658 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3659 correctly. Don't assume unibyte strings are not bidi-reordered.
3660 (compute_display_string_pos)
3661 (compute_display_string_end): Fix handling the case of C string.
3662 (push_it, pop_it): Save and restore from_disp_prop_p.
3663 (handle_single_display_spec, push_display_prop): Set the
3664 from_disp_prop_p flag.
3665 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3666 (pop_it): Call iterate_out_of_display_property only if we are
3667 popping after iteration over a string that came from a display
3668 property. Fix a typo in popping stretch info. Add an assertion
3669 for verifying that the iterator position is in sync with the bidi
3670 iterator.
3671 (handle_single_display_spec, get_overlay_strings_1)
3672 (push_display_prop): Fix initialization of paragraph direction for
3673 string when that of the parent object is not yet determined.
3674 (reseat_1): Call bidi_init_it to resync the bidi
3675 iterator with IT's position. (Bug#7616)
3676 (find_row_edges): If ROW->start.pos gives position
3677 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3678 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3679 Reset the from_disp_prop_p flag.
3680 (SAVE_IT, RESTORE_IT): New macros.
3681 (pos_visible_p, face_before_or_after_it_pos)
3682 (back_to_previous_visible_line_start)
3683 (move_it_in_display_line_to, move_it_in_display_line)
3684 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3685 (try_scrolling, redisplay_window, display_line): Use them when
3686 saving a temporary copy of the iterator and restoring it back.
3687 (back_to_previous_visible_line_start, reseat_1)
3688 (init_iterator): Empty the bidi cache "stack".
3689 (move_it_in_display_line_to): If iterator ended up at
3690 EOL, but we never saw any buffer positions smaller than
3691 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3692 motion in bidi-reordered lines.
3693 (move_it_in_display_line_to): Record prev_method and prev_pos
3694 immediately before the call to set_iterator_to_next. Fixes cursor
3695 motion in bidi-reordered lines with stretch glyphs and strings
3696 displayed in margins. (Bug#8133) (Bug#8867)
3697 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3698 TO_CHARPOS.
640c8776
SM
3699 (pos_visible_p): Support positions in bidi-reordered lines.
3700 Save and restore bidi cache.
0bb23927
EZ
3701
3702 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3703 (bidi_paragraph_info): Delete unused struct.
3704 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3705 (bidi_cache_start): New variable.
3706 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3707 to zero.
3708 (bidi_cache_fetch_state, bidi_cache_search)
3709 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3710 (bidi_cache_find, bidi_peek_at_next_level)
3711 (bidi_level_of_next_char, bidi_find_other_level_edge)
3712 (bidi_move_to_visually_next): Compare cache index with
3713 bidi_cache_start rather than with zero.
3714 (bidi_fetch_char): Accept new argument STRING; all callers
3715 changed. Support iteration over a string. Support strings with
3716 display properties. Support unibyte strings. Fix the type of
3717 `len' according to what STRING_CHAR_AND_LENGTH expects.
3718 (bidi_paragraph_init, bidi_resolve_explicit_1)
3719 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3720 (bidi_level_of_next_char, bidi_move_to_visually_next):
3721 Support iteration over a string.
0bb23927
EZ
3722 (bidi_set_sor_type, bidi_resolve_explicit_1)
3723 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3724 can now be zero (for strings); special values 0 and -1 were
3725 changed to -1 and -2, respectively.
3726 (bidi_char_at_pos): New function.
3727 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3728 Call it instead of FETCH_MULTIBYTE_CHAR.
3729 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3730 initialized to valid values.
3731 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3732 values.
3733 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3734 the test for valid cached positions. Fix the logic for looking up
3735 the sentinel state in the cache. GCPRO the Lisp string we are
3736 iterating.
3737 (bidi_push_it, bidi_pop_it): New functions.
3738 (bidi_initialize): Initialize the bidi cache start stack pointer.
3739 (bidi_cache_ensure_space): New function, refactored from part of
3740 bidi_cache_iterator_state. Don't assume the required size is just
3741 one BIDI_CACHE_CHUNK away.
3742 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3743 (bidi_count_bytes, bidi_char_at_pos): New functions.
3744 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3745 always valid if bidi_cache_idx is valid.
3746 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3747 is valid if it's going to be used.
3748 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3749 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3750 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3751 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3752 (bidi_find_other_level_edge, bidi_cache_start_stack):
3753 All variables related to cache indices are now EMACS_INT.
c965adc5 3754
0bb23927
EZ
3755 * dispextern.h (struct bidi_string_data): New structure.
3756 (struct bidi_it): New member `string'. Make flag members be 1-bit
3757 fields, and put them last in the struct.
640c8776
SM
3758 (compute_display_string_pos, compute_display_string_end):
3759 Update prototypes.
0bb23927
EZ
3760 (bidi_push_it, bidi_pop_it): Add prototypes.
3761 (struct iterator_stack_entry): New members bidi_p,
3762 paragraph_embedding, and from_disp_prop_p.
3763 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3764 (bidi_shelve_cache, bidi_unshelve_cache):
3765 Declare prototypes.
0bb23927
EZ
3766
3767 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3768 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3769 and vector-like objects.
3770
3771 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3772 cache around display iteration.
3773
3774 * window.c (Fwindow_end, window_scroll_pixel_based)
3775 (displayed_window_lines, Frecenter): Save and restore the bidi
3776 cache around display iteration.
3777
3bbd2265
LMI
37782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3779
3780 * editfns.c (Fdelete_region): Clarify the use of the named
3781 parameters (bug#6788).
3782
adc47434
MR
37832011-07-14 Martin Rudalics <rudalics@gmx.at>
3784
3785 * indent.c (Fvertical_motion): Set and restore w->pointm when
3786 saving and restoring the window's buffer (Bug#9006).
3787
837c31f8
LMI
37882011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3789
3790 * editfns.c (Fstring_to_char): Clarify just what is returned
3791 (bug#6576). Text by Eli Zaretskii.
3792
ac389d0c
JB
37932011-07-13 Juanma Barranquero <lekktu@gmail.com>
3794
3795 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3796
0be0ce47
EZ
37972011-07-13 Eli Zaretskii <eliz@gnu.org>
3798
3799 * buffer.c (mmap_find): Fix a typo.
3800
cd18e7e3
JB
38012011-07-13 Johan Bockgård <bojohan@gnu.org>
3802
3803 Fix execution of x selection hooks.
3804 * xselect.c (Qx_lost_selection_functions)
3805 (Qx_sent_selection_functions): New vars.
3806 (syms_of_xselect): DEFSYM them.
3807 (x_handle_selection_request): Pass Qx_sent_selection_functions
3808 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3809 (x_handle_selection_clear,x_clear_frame_selections):
3810 Pass Qx_lost_selection_functions rather than
3811 Vx_lost_selection_functions to Frun_hook_with_args.
3812
47ea7f44
PE
38132011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3814
ac389d0c 3815 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3816 The old code sometimes used this field without initializing it.
3817
47ea7f44
PE
3818 * alloc.c (gc_sweep): Don't read past end of array.
3819 In theory, the old code could also have corrupted Emacs internals,
3820 though it'd be very unlikely.
3821
bc985c87
AS
38222011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3823
3824 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3825 argument. (Bug#4026)
bc985c87 3826
0cf34688
LMI
38272011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3828
b3dadd76
LMI
3829 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3830 key" (bug#4257).
3831
0cf34688
LMI
3832 * window.c (Fset_window_start): Doc fix (bug#4199).
3833 (Fset_window_hscroll): Ditto.
3834
270768cd
PE
38352011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3836
077e3dda 3837 Fix minor new problems caught by GCC 4.6.1.
270768cd 3838 * term.c (init_tty): Remove unused local.
490011a6 3839 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3840 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3841 not used otherwise.
270768cd 3842
b1f58454
CY
38432011-07-12 Chong Yidong <cyd@stupidchicken.com>
3844
3845 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3846
22b9578d
LMI
38472011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3848
6e70ab07
LMI
3849 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3850 are the mini-buffer and the echo area (bug#3320).
3851
22b9578d
LMI
3852 * term.c (init_tty): Remove support for supdup, c10 and perq
3853 terminals, which are no longer supported (bug#1482).
3854
8974cc9f
JB
38552011-07-10 Johan Bockgård <bojohan@gnu.org>
3856
3857 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3858
a560d974
JD
38592011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3860
3861 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3862 for non-popups (Bug#3642).
3863
1dae0f0a
AS
38642011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3865
268c2c36 3866 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3867 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3868 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3869 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3870 * data.c (fmod): Likewise.
3871 * dispnew.c (swap_glyphs_in_rows): Likewise.
3872 * emacs.c (memory_warning_signal): Likewise.
3873 * floatfns.c (float_error): Likewise.
3874 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3875 (otf_open, font_otf_capability, generate_otf_features)
3876 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3877 Likewise.
3878 * image.c (pbm_read_file): Likewise.
3879 * indent.c (string_display_width): Likewise.
3880 * intervals.c (check_for_interval, search_for_interval)
3881 (inc_interval_count, count_intervals, root_interval)
3882 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3883 * lread.c (defalias): Likewise.
268c2c36 3884 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3885 * regex.c (set_image_of_range_1, set_image_of_range)
3886 (regex_grow_registers): Likewise.
3887 * sysdep.c (strerror): Likewise.
3888 * termcap.c (valid_filename_p, tprint, main): Likewise.
3889 * tparam.c (main): Likewise.
3890 * unexhp9k800.c (run_time_remap, save_data_space)
3891 (update_file_ptrs, read_header, write_header, calculate_checksum)
3892 (copy_file, copy_rest, display_header): Likewise.
3893 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3894 Likewise.
3895 * xdisp.c (check_it): Likewise.
3896 * xfaces.c (register_color, unregister_color, unregister_colors):
3897 Likewise.
3898 * xfns.c (print_fontset_result): Likewise.
3899 * xrdb.c (member, fatal, main): Likewise.
3900
99033785
PE
39012011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 Fix minor problems found by static checking (Bug#9031).
3904 * chartab.c (char_table_set_range, map_sub_char_table):
3905 Remove unused locals.
3906 (uniprop_table): Now static.
3907 * composite.c (_work_char): Remove unused static var.
3908
9cb2ac56
JB
39092011-07-09 Juanma Barranquero <lekktu@gmail.com>
3910
3911 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3912
f25661f0
JD
39132011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3914
3915 * gtkutil.c (qttip_cb): Remove code without function.
3916
8278c4fe
EZ
39172011-07-09 Eli Zaretskii <eliz@gnu.org>
3918
3919 * w32.c (pthread_sigmask): New stub.
3920
1692ae2d 39212011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3922
8a6ebd58 3923 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3924 sigprocmask is portable only for single-threaded applications, and
3925 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3926 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3927 (LIBES): Use it.
3928 * callproc.c (Fcall_process):
3929 * process.c (create_process):
3930 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3931 Use pthread_sigmask, not sigprocmask.
123403e4 3932
1b854618
JD
39332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3934
3935 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3936 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3937 wrong (Bug#8591).
3938
3fe4b549
JD
39392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3940
0ce7e563
JD
3941 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3942 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3943 (xg_hide_tooltip): Fix comment.
3944
3fe4b549
JD
3945 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3946 in registerServicesMenuSendTypes.
3947 (validRequestorForSendType): Don't check ns_return_types.
3948
3949 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3950 ns_return_type.
3951
5df75e47
JR
39522011-07-08 Jason Rumney <jasonr@gnu.org>
3953
22610910
JR
3954 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3955 SH_SHOW for hidden windows (Bug#5482).
3956
5df75e47
JR
3957 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3958 frame struct members of non-existent frames (Bug#6284).
3959
699c10bd
JD
39602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3961
4393663b
JD
3962 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3963 variable firstTime not needed on OSX >= 10.6.
3964 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3965 >= 10.5. Use setKnobProportion, setDoubleValue.
3966
3967 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3968 (MAC_OS_X_VERSION_10_5): Define if not defined.
3969 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3970 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3971 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3972
3973 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3974 cString and lossyCString on OSX >= 10.4
3975
58179cce 3976 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3977 sizeToFit on OSX >= 10.2.
3978
3979 * nsimage.m (allocInitFromFile): Don't use deprecated method
3980 bestRepresentationForDevice on OSX >= 10.6.
3981
3982 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3983 to avoid warning.
3984
3985 * emacs.c: Declare unexec_init_emacs_zone.
3986
a63e0781
JD
3987 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3988
699c10bd
JD
3989 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3990
3991 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3992 on svcsMenu (Bug#8842).
3993
3994 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3995 ns_return_types.
3996 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3997
3998 * nsterm.m (QUTF8_STRING): Declare.
3999 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4000 (validRequestorForSendType): Return type is (id).
4001 Change indexOfObjectIdenticalTo to indexOfObject.
4002 Check if we have local selection before returning self (Bug#8842).
4003 (writeSelectionToPasteboard): Put local selection into paste board
4004 if we have a local selection (Bug#8842).
4005 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4006
4007 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4008 (ns_get_local_selection): Declare.
4009
54e10184
LMI
40102011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4011
9888ff71
LMI
4012 * keymap.c (describe_map_tree): Don't insert a double newline at
4013 the end of the buffer (bug#1169) and return whether we inserted
4014 something.
4015
54e10184
LMI
4016 * callint.c (Fcall_interactively): Change "reading args" to
4017 "providing args" to try to clarify what it does (bug#1010).
4018
15fa4783
KH
40192011-07-07 Kenichi Handa <handa@m17n.org>
4020
4021 * composite.c (composition_compute_stop_pos): Ignore a static
4022 composition starting before CHARPOS (Bug#8915).
4023
4024 * xdisp.c (handle_composition_prop): Likewise.
4025
a8815b00
EZ
40262011-07-07 Eli Zaretskii <eliz@gnu.org>
4027
4028 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4029 (Bug#9015)
4030
ef7b981d 40312011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4032
4033 * character.h (unicode_category_t): New enum type.
4034
4035 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4036 (Qchar_code_property_table): New variable.
4037 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4038 (UNIPROP_COMPRESSED_FORM_P): New macros.
4039 (char_table_ascii): Uncompress the compressed values.
4040 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4041 Uncompress the compressed values.
ac389d0c 4042 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4043 (char_table_ref_and_range): Uncompress the compressed values.
4044 (sub_char_table_set): New arg is_uniprop. Callers changed.
4045 Uncompress the compressed values.
4046 (sub_char_table_set_range): Args changed. Callers changed.
4047 (char_table_set_range): Adjuted for the above change.
4048 (map_sub_char_table): Delete args default_val and parent. Add arg
4049 top. Give decoded values to a Lisp function.
640c8776 4050 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4051 values to a Lisp function. Gcpro more variables.
4052 (uniprop_table_uncompress)
4053 (uniprop_decode_value_run_length): New functions.
4054 (uniprop_decoder, uniprop_decoder_count): New variables.
4055 (uniprop_get_decoder, uniprop_encode_value_character)
4056 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4057 New functions.
4058 (uniprop_encoder, uniprop_encoder_count): New variables.
4059 (uniprop_get_encoder, uniprop_table)
4060 (Funicode_property_table_internal, Fget_unicode_property_internal)
4061 (Fput_unicode_property_internal): New functions.
4062 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4063 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4064 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4065 char-code-property-alist.
4066
640c8776 4067 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4068 Vunicode_category_table.
4069
640c8776 4070 * font.c (font_range): Adjust for the change of
c805dec0
KH
4071 Vunicode_category_table.
4072
76b397fb
DN
40732011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4074
4075 * m/iris4d.h: Remove file, move contents ...
4076 * s/irix6-5.h: ... here.
4077
22b4128e
PE
40782011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4079
4080 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4081 * alloc.c (mark_buffer):
4082 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4083 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4084 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4085 This isn't true in general, and it's particularly not true
4086 if Emacs is configured with --with-wide-int.
4087 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4088 New macros, used in the buffer.c change.
4089
869795d6
JD
40902011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4091
4092 * xsettings.c: Use both GConf and GSettings if both are available.
4093 (store_config_changed_event): Add comment.
4094 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4095 (store_tool_bar_style_changed): New functions.
5e617bc2 4096 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4097 (struct xsettings): Move font inside HAVE_XFT.
4098 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4099 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4100 Move inside HAVE_XFT.
640c8776 4101 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4102 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4103 also.
4104 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4105 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4106 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4107 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4108 (parse_settings): Move check for font inside HAVE_XFT.
4109 (read_settings, apply_xft_settings): Add comment.
4110 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4111 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4112 call store_font_name_changed.
4113 (xft_settings_event): Add comment.
4114 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4115 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4116 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4117 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4118 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4119 (xsettings_get_system_font, xsettings_get_system_normal_font):
4120 Add comment.
869795d6 4121
d8ed26bd
PE
41222011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4123
4124 Random fixes. E.g., (random) never returned negative values.
4125 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4126 subseconds part to the entropy, as that's a bit more random.
4127 Prefer signed to unsigned, since the signedness doesn't matter and
4128 in general we prefer signed. When given a limit, use a
4129 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4130 latter isn't right if USE_2_TAGS_FOR_INTS.
4131 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4132 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4133
cabf1cac
SM
41342011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4135
4136 * textprop.c (text_property_stickiness):
4137 Obey Vtext_property_default_nonsticky.
4138 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4139 * w32fns.c (syms_of_w32fns):
4140 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4141
6e9b2be9
PE
41422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4143
4144 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4145 This is more efficient than Ffile_directory_p and avoids a minor race.
4146
90186c68
LMI
41472011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4148
7c301272
LMI
4149 * buffer.c (Foverlay_put): Say what the return value is
4150 (bug#7835).
4151
c4f2d8d4
LMI
4152 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4153 is a directory before asking whether to use the file name
4154 (bug#7564).
ad637907
LMI
4155 (barf_or_query_if_file_exists): Make the "File is a directory"
4156 error be more correct.
c4f2d8d4 4157
90186c68
LMI
4158 * fns.c (Frequire): Remove the mention of the .gz files, since
4159 that's installation-specific, but keep the mention of
4160 `get-load-suffixes'.
4161
da64016e
PE
41622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4163
4164 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4165 Report string overflow if the output is too long.
4166
7d47b580
JB
41672011-07-04 Juanma Barranquero <lekktu@gmail.com>
4168
a555cb87
JB
4169 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4170 (syms_of_gnutls): Remove duplicate DEFSYM for
4171 Qgnutls_bootprop_verify_hostname_error, an error for
4172 Qgnutls_bootprop_verify_error (which is no longer used).
4173
7d47b580
JB
4174 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4175 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4176 Also (re)move comments that are misplaced or no longer relevant.
4177
1e49bfab
LMI
41782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4179
4180 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4181
1485f4c0
CY
41822011-07-03 Chong Yidong <cyd@stupidchicken.com>
4183
4184 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4185 and background color parameters if they have been changed.
4186
a9ab721e
LMI
41872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4188
4189 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4190
cf7cff57
PE
41912011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4192
2e13213d
PE
4193 * xsettings.c (SYSTEM_FONT): Define only when used.
4194 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4195
cf7cff57
PE
4196 * keymap.c (access_keymap_1): Now static.
4197
7a8e04f7
CY
41982011-07-02 Chong Yidong <cyd@stupidchicken.com>
4199
4200 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4201 leave any prefix arg for the up event (Bug#1586).
4202
61352f62
LMI
42032011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4204
69bb1ef7
LMI
4205 * lread.c (syms_of_lread): Mention single symbols defined by
4206 `defvar' or `defconst' (bug#7154).
4207
61352f62 4208 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4209 (Frequire): Mention get-load-suffixes.
61352f62 4210
28545e04
MR
42112011-07-02 Martin Rudalics <rudalics@gmx.at>
4212
4213 * window.h (window): Remove clone_number slot.
4214 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4215 Remove.
4216 (make_parent_window, make_window, saved_window)
4217 (Fset_window_configuration, save_window_save): Don't deal with
4218 clone numbers.
4219 * buffer.c (Qclone_number): Remove declaration.
4220 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4221
3349e122
SM
42222011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4223
4224 Add multiple inheritance to keymaps.
4225 * keymap.c (Fmake_composed_keymap): New function.
4226 (Fset_keymap_parent): Simplify.
4227 (fix_submap_inheritance): Remove.
4228 (access_keymap_1): New function extracted from access_keymap to handle
4229 embedded parents and handle lists of maps.
4230 (access_keymap): Use it.
4231 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4232 (Fcopy_keymap): Handle embedded parents.
4233 (Fcommand_remapping, define_as_prefix): Simplify.
4234 (Fkey_binding): Simplify.
4235 (syms_of_keymap): Move minibuffer-local-completion-map,
4236 minibuffer-local-filename-completion-map,
4237 minibuffer-local-must-match-map, and
4238 minibuffer-local-filename-must-match-map to Elisp.
4239 (syms_of_keymap): Defsubr make-composed-keymap.
4240 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4241 (parse_menu_item): Trivial simplification.
4242
3279eb87
GM
42432011-07-01 Glenn Morris <rgm@gnu.org>
4244
4245 * Makefile.in (SETTINGS_LIBS): Fix typo.
4246
4550efdf
KI
42472011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4248
4249 * coding.c (Fencode_coding_string): Record the last coding system
4250 used, as the function doc string says (bug#8738).
4251
0949d2b6
JD
42522011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4253
4254 * xsettings.c (store_monospaced_changed): Take new font as arg and
4255 check for change against current_mono_font.
4256 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4257 (emacs_settings_constructor, emacs_settings_get_property)
4258 (emacs_settings_set_property, emacs_settings_class_init)
4259 (emacs_settings_init, gsettings_obj): Remove.
4260 (something_changedCB): New function for HAVE_GSETTINGS.
4261 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4262 with value as argument.
4263 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4264 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4265 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4266 "changed".
4267
4268 * xgselect.c: Add defined (HAVE_GSETTINGS).
4269 (xgselect_initialize): Ditto.
4270
4271 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4272 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4273 xg_select.
4274
bbc6b304
PE
42752011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4276
4277 * eval.c (struct backtrace): Simplify and port the data structure.
4278 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4279 signed bit field, as this assumption is not portable and it makes
4280 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4281 "char debug_on_exit : 1" as this is not portable either; instead,
4282 use the portable "unsigned int debug_on_exit : 1". Remove unused
4283 member evalargs. Remove obsolete comments about cc bombing out.
4284
9851bfc5
JD
42852011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4286
51bb811f 4287 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4288 Let HAVE_GSETTINGS override HAVE_GCONF.
4289 (store_monospaced_changed): New function.
4290 (EMACS_SETTINGS): A new type derived from GObject to handle
4291 GSettings notifications.
4292 (emacs_settings_constructor, emacs_settings_get_property)
4293 (emacs_settings_set_property, emacs_settings_class_init):
4294 New functions.
4295 (gsettings_client, gsettings_obj): New variables.
4296 (GSETTINGS_SCHEMA): New define.
4297 (something_changedCB): Call store_monospaced_changed.
4298 (init_gsettings): New function.
4299 (xsettings_initialize): Call init_gsettings.
4300 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4301 to NULL.
4302
640c8776 4303 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4304 GCONF_CFLAGS/LIBS.
4305
5386012d
MR
43062011-06-29 Martin Rudalics <rudalics@gmx.at>
4307
4308 * window.c (resize_root_window, grow_mini_window)
4309 (shrink_mini_window): Rename Qresize_root_window to
4310 Qwindow_resize_root_window and Qresize_root_window_vertically to
4311 Qwindow_resize_root_window_vertically.
4312
f13e0b08
PE
43132011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4314
4315 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4316
94515237
JB
43172011-06-27 Juanma Barranquero <lekktu@gmail.com>
4318
4319 * makefile.w32-in: Redesign dependencies so they reflect more
4320 clearly which files are directly included by each source file,
4321 and not through other includes.
4322
e43b6e43
MR
43232011-06-27 Martin Rudalics <rudalics@gmx.at>
4324
4325 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4326 (sort_overlays, overlay_strings): When an overlay's clone number
4327 matches the window's clone number process the overlay even if
4328 the overlay's window property doesn't match the current window.
4329
d68443dc
MR
4330 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4331 (Fwindow_hchild): Rename to Fwindow_left_child.
4332 (Fwindow_next): Rename to Fwindow_next_sibling.
4333 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4334 (resize_window_check): Rename to window_resize_check.
4335 (resize_window_apply): Rename to window_resize_apply.
4336 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4337 (Fdelete_other_windows_internal, resize_frame_windows)
4338 (Fsplit_window_internal, Fdelete_window_internal)
4339 (grow_mini_window, shrink_mini_window)
4340 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4341
c7e73be5
JD
43422011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4343
4344 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4345 (emacs_fixed_set_min_size): Remove.
4346 (emacs_fixed_new): Take frame as argument.
4347
4348 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4349 (_EmacsFixedPrivate): Remove minwidth/height.
4350 Add struct frame *f.
4351 (emacs_fixed_init): Initialize priv->f.
4352 (get_parent_class, emacs_fixed_set_min_size): Remove.
4353 (emacs_fixed_new): Set priv->f to argument.
4354 (emacs_fixed_get_preferred_width)
4355 (emacs_fixed_get_preferred_height): Use min_width/height from
4356 frames size_hint to set minimum and natural (Bug#8919).
4357 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4358 and use min_width/height from frames size_hint to set
4359 min_width/height (Bug#8919).
4360
4361 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4362 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4363 Fix indentation.
c7e73be5 4364
cf99dcf8
EZ
43652011-06-26 Eli Zaretskii <eliz@gnu.org>
4366
4367 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4368 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4369 called at ZV.
4370
029529ac
CY
43712011-06-26 Chong Yidong <cyd@stupidchicken.com>
4372
4373 * process.c (wait_reading_process_output): Bypass select if
4374 waiting for a cell while ignoring keyboard input, and input is
4375 pending. Suggested by Jan Djärv (Bug#8869).
4376
7a7ef429
PE
43772011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4378
4379 Use gnulib's dup2 module instead of rolling our own.
4380 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4381
11fdef7d 43822011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4383
4384 * dispnew.c (scrolling_window): Before scrolling, turn off a
4385 mouse-highlight in the window being scrolled.
4386
cd3520a4
JB
43872011-06-24 Juanma Barranquero <lekktu@gmail.com>
4388
4389 Move DEFSYM to lisp.h and use everywhere.
4390
4391 * character.h (DEFSYM): Move declaration...
4392 * lisp.h (DEFSYM): ...here.
4393
4394 * gnutls.c:
4395 * minibuf.c:
4396 * w32menu.c:
4397 * w32proc.c:
4398 * w32select.c: Don't include character.h.
4399
4400 * alloc.c (syms_of_alloc):
4401 * buffer.c (syms_of_buffer):
4402 * bytecode.c (syms_of_bytecode):
4403 * callint.c (syms_of_callint):
4404 * casefiddle.c (syms_of_casefiddle):
4405 * casetab.c (init_casetab_once):
4406 * category.c (init_category_once, syms_of_category):
4407 * ccl.c (syms_of_ccl):
4408 * cmds.c (syms_of_cmds):
4409 * composite.c (syms_of_composite):
4410 * dbusbind.c (syms_of_dbusbind):
4411 * dired.c (syms_of_dired):
4412 * dispnew.c (syms_of_display):
4413 * doc.c (syms_of_doc):
4414 * editfns.c (syms_of_editfns):
4415 * emacs.c (syms_of_emacs):
4416 * eval.c (syms_of_eval):
4417 * fileio.c (syms_of_fileio):
4418 * fns.c (syms_of_fns):
4419 * frame.c (syms_of_frame):
4420 * fringe.c (syms_of_fringe):
4421 * insdel.c (syms_of_insdel):
4422 * keymap.c (syms_of_keymap):
4423 * lread.c (init_obarray, syms_of_lread):
4424 * macros.c (syms_of_macros):
4425 * msdos.c (syms_of_msdos):
4426 * print.c (syms_of_print):
4427 * process.c (syms_of_process):
4428 * search.c (syms_of_search):
4429 * sound.c (syms_of_sound):
4430 * syntax.c (init_syntax_once, syms_of_syntax):
4431 * terminal.c (syms_of_terminal):
4432 * textprop.c (syms_of_textprop):
4433 * undo.c (syms_of_undo):
4434 * w32.c (globals_of_w32):
4435 * window.c (syms_of_window):
4436 * xdisp.c (syms_of_xdisp):
4437 * xfaces.c (syms_of_xfaces):
4438 * xfns.c (syms_of_xfns):
4439 * xmenu.c (syms_of_xmenu):
4440 * xsettings.c (syms_of_xsettings):
4441 * xterm.c (syms_of_xterm): Use DEFSYM.
4442
4228cf16
TZ
44432011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4444
cd3520a4 4445 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4446
7fcccf1e
PE
44472011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4448
7efb4e0e
PE
4449 Integer and buffer overflow fixes (Bug#8873).
4450
ff5844ad
PE
4451 * print.c (printchar, strout): Check for string overflow.
4452 (PRINTPREPARE, printchar, strout):
4453 Don't set size unless allocation succeeds.
4454
90532f02
PE
4455 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4456 for sizes. Check for string overflow more accurately.
4457 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4458
6d84508d
PE
4459 * macros.c: Integer and buffer overflow fixes.
4460 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4461 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4462 Use ptrdiff_t, not int, for sizes.
4463 Don't increment bufsize until after realloc succeeds.
4464 Check for size-calculation overflow.
4465 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4466
437b2cb4
PE
4467 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4468
8b9ac8b4
PE
4469 * lread.c: Integer overflow fixes.
4470 (read_integer): Radix is now EMACS_INT, not int,
4471 to improve quality of diagnostics for out-of-range radices.
4472 Calculate buffer size correctly for out-of-range radices.
4473 (read1): Check for integer overflow in radices, and in
4474 read-circle numbers.
82cb60d3
PE
4475 (read_escape): Avoid int overflow.
4476 (Fload, openp, read_buffer_size, read1)
4477 (substitute_object_recurse, read_vector, read_list, map_obarray):
4478 Use ptrdiff_t, not int, for sizes.
4479 (read1): Use EMACS_INT, not int, for sizes.
20270765 4480 Check for size overflow.
8b9ac8b4 4481
7fcccf1e
PE
4482 * image.c (cache_image): Check for size arithmetic overflow.
4483
bfbbd7e7
PE
4484 * lread.c: Integer overflow issues.
4485 (saved_doc_string_size, saved_doc_string_length)
4486 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4487 Now ptrdiff_t, not int.
4488 (read1): Don't assume doc string length fits in int. Check for
4489 out-of-range doc string lengths.
4490 (read_list): Don't assume file position fits in int.
39019e54 4491 (read_escape): Check for hex character overflow.
bfbbd7e7 4492
4e323265
LL
44932011-06-22 Leo Liu <sdl.web@gmail.com>
4494
4495 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4496 Move to minibuffer.el.
4497
85fece3e
PE
44982011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4499
20b84ce9 4500 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4501 The following patches are for when GLYPH_DEBUG && !XASSERT.
4502 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4503 * dispnew.c (flush_stdout):
4504 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4505 Mark as externally visible.
4506 * dispnew.c (check_window_matrix_pointers): Now static.
4507 * dispnew.c (window_to_frame_vpos):
4508 * xfns.c (unwind_create_frame):
4509 * xterm.c (x_check_font): Remove unused local.
4510 * scroll.c (CHECK_BOUNDS):
4511 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4512 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4513 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4514 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4515 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4516 Now static.
4517 (debug_method_add): Use va_list and vsprintf rather than relying
4518 on undefined behavior with wrong number of arguments.
4519 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4520 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4521 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4522 since we're not interested in debugging glyphs with old libraries.
4523 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4524 GCC 4.6.0's static checking.
4525
0766b489
PE
45262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4527
31fd4b32
PE
4528 Integer overflow and signedness fixes (Bug#8873).
4529 A few related buffer overrun fixes, too.
4530
b79e8648
PE
4531 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4532
0766b489
PE
4533 * dispextern.h (struct face.stipple):
4534 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4535 (x_bitmap_mask, x_allocate_bitmap_record)
4536 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4537 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4538 (x_create_bitmap_from_xpm_data):
4539 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4540 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4541 (.bitmaps_last):
4542 * xfaces.c (load_pixmap):
4543 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4544 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4545 (.bitmaps_last, struct x_output.icon_bitmap):
4546 Use ptrdiff_t, not int, for bitmap indexes.
4547 (x_allocate_bitmap_record): Check for size overflow.
4548 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4549
b081724f
PE
4550 Use ptrdiff_t, not int, for overlay counts.
4551 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4552 * editfns.c (overlays_around, get_pos_property):
4553 * textprop.c (get_char_property_and_overlay):
4554 * xdisp.c (next_overlay_change, note_mouse_highlight):
4555 * xfaces.c (face_at_buffer_position):
21514da7
PE
4556 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4557 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4558 (Fnext_overlay_change, Fprevious_overlay_change)
4559 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4560 Use ptrdiff_t, not int, for sizes.
21514da7 4561 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4562
3de73e5e
PE
4563 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4564
2606c57b
PE
4565 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4566 (x_session_initialize): Do not assume string length fits in int.
4567
aaafe47a
PE
4568 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4569 This is unlikely, but can occur if DPI is outlandish.
4570
2674ddc8 4571 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4572 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4573
28154962
PE
4574 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4575 * xrdb.c (magic_file_p, search_magic_path):
4576 Omit last arg SUFFIX; it was always 0. All callers changed.
4577 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4578
7de51af5
PE
4579 * xfont.c (xfont_match): Avoid need for strlen.
4580
25ed6cc3
PE
4581 * xfns.c: Don't assume strlen fits in int.
4582 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4583
4eab31dd
PE
4584 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4585 not unsigned long, as we prefer signed integers. All callers changed.
4586 Detect integer overflow in repeat count.
4587 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4588 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4589
171e2a58
PE
4590 * termcap.c: Don't assume sizes fit in int and never overflow.
4591 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4592 (gobble_line): Check for size-calculation overflow.
4593
ad39faca 4594 * minibuf.c (Fread_buffer):
6e5bb2dc 4595 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4596 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4597 Don't assume string length fits in int.
4598
52c61c22 4599 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4600 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4601
b5b8c9e5
PE
4602 * font.c: Don't assume string length fits in int.
4603 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4604 Use ptrdiff_t, not int.
ccd6111c
PE
4605 (font_intern_prop): Don't assume string length fits in int.
4606 Don't assume integer property fits in fixnum.
4607 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4608
882f0d81 4609 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4610 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4611 Reformulate so as not to need the command string.
4612 Invoke gzip -cd rather than gunzip, as it's more portable.
4613 (lock_info_type, lock_file_1, lock_file):
4614 Don't assume pid_t and time_t fit in unsigned long.
4615 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4616 (current_lock_owner): Prefer signed type for sizes.
4617 Use memcpy, not strncpy, where memcpy is what is really wanted.
4618 Don't assume (via atoi) that time_t and pid_t fit in int.
4619 Check for time_t and/or pid_t out of range, e.g., via a network share.
4620 Don't alloca where an auto var works fine.
4621
93f4cf88
PE
4622 * fileio.c: Fix some integer overflow issues.
4623 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4624 Don't assume string length fits in int.
4625 (directory_file_name): Don't assume string length fits in long.
4626 (make_temp_name): Don't assume pid fits in int, or that its print
4627 length is less than 20.
4628
f3e92b69
PE
4629 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4630
1bfdaf10
PE
4631 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4632
35016e9a
PE
4633 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4634
3d1e65a1
PE
4635 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4636 We prefer signed integers, even for size calculations.
4637
0b963a93
PE
4638 * emacs.c: Don't assume string length fits in 'int'.
4639 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4640 (main): Don't invoke strlen when not needed.
4641
573f4b54
PE
4642 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4643 (XD_DEBUG_MESSAGE): Don't waste a byte.
4644
989f33ba
PE
4645 * callproc.c (getenv_internal_1, getenv_internal)
4646 (Fgetenv_internal):
965d34eb
PE
4647 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4648
e4d29b33
PE
4649 * lread.c (invalid_syntax): Omit length argument.
4650 All uses changed. This doesn't fix a bug, but it simplifies the
4651 code away from its former Hollerith-constant appearance, and it's
4652 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4653 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4654
eb49b136
PE
4655 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4656 This didn't break anything, but it didn't help either.
4657 It's confusing to put a bogus integer in a place where the actual
4658 value does not matter.
9f62aeb1 4659 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4660 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4661
15375a22
PE
4662 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4663 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4664 implementation.
b61cc01c
PE
4665 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4666 We prefer signed types, and the value cannot exceed the EMACS_INT
4667 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4668 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4669 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4670 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4671
53b2623d
PE
4672 * indent.c (sane_tab_width): New function.
4673 (current_column, scan_for_column, Findent_to, position_indentation)
4674 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4675 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4676
51cab52b 4677 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4678
f2ed8a70
PE
4679 * lisp.h (lint_assume): New macro.
4680 * composite.c (composition_gstring_put_cache):
4681 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4682
abe80cc6
PE
4683 * editfns.c, insdel.c:
4684 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4685
b02c740e
PE
4686 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4687
ebc96716
PE
4688 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4689
b4e50fa0 4690 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4691 Use much-faster test for byte-length change.
311d5d7c 4692 Don't assume string byte-length fits in 'int'.
a4cf38e4 4693 Check that character arg fits in 'int'.
85461888 4694 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4695
c0c1ee9f
PE
4696 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4697
a498d7f4
PE
4698 * fns.c (concat): Catch string overflow earlier.
4699 Do not rely on integer wraparound.
4700
51cab52b
PE
4701 * dispextern.h (struct it.overlay_strings_charpos)
4702 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4703 * xdisp.c (forward_to_next_line_start)
4704 (back_to_previous_visible_line_start)
4705 (reseat_at_next_visible_line_start, next_element_from_buffer):
4706 Don't arbitrarily truncate the value of 'selective' to int.
4707
76031fad
PE
4708 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4709
5eb55db9
PE
4710 * composite.c: Don't truncate sizes to 'int'.
4711 (composition_gstring_p, composition_reseat_it)
4712 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4713 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4714 not EMACS_UINT, for indexes.
5eb55db9 4715
0703a717
PE
4716 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4717
d6202519
PE
4718 * buffer.c: Include <verify.h>.
4719 (struct sortvec.priority, struct sortstr.priority):
8961a454 4720 Now EMACS_INT, not int.
c20998a7 4721 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4722 (struct sortstr.size, record_overlay_string)
4723 (struct sortstrlist.size, struct sortlist.used):
4724 Don't truncate size to int.
4725 (record_overlay_string): Check for size-calculation overflow.
d6202519 4726 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4727
d5a19415
JM
47282011-06-22 Jim Meyering <meyering@redhat.com>
4729
029529ac 4730 Don't leak an XBM-image-sized buffer
d5a19415
JM
4731 * image.c (xbm_load): Free the image buffer after using it.
4732
a9041e6c
PE
47332011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4734
4735 Port to Sun C.
4736 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4737 that Sun C diagnosed.
4738 * fns.c (secure_hash): Fix pointer signedness issue.
4739 * intervals.c (static_offset_intervals): New function.
4740 (offset_intervals): Use it.
4741
7f3f739f
LL
47422011-06-21 Leo Liu <sdl.web@gmail.com>
4743
4744 * deps.mk (fns.o):
4745 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4746 sha512.h.
4747
4748 * fns.c (secure_hash): Rename from crypto_hash_function and change
4749 the first arg to accept symbols.
5b66d427 4750 (Fsecure_hash): New primitive.
7f3f739f
LL
4751 (syms_of_fns): New symbols.
4752
76147d94
DD
47532011-06-20 Deniz Dogan <deniz@dogan.se>
4754
4755 * process.c (Fset_process_buffer): Clarify return value in
4756 docstring.
4757
7d7d0045
CY
47582011-06-18 Chong Yidong <cyd@stupidchicken.com>
4759
4760 * dispnew.c (add_window_display_history): Use BVAR.
4761
4762 * xdisp.c (debug_method_add): Use BVAR.
4763 (check_window_end, dump_glyph_matrix, dump_glyph)
4764 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4765
4766 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4767 Likewise.
4768
4769 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4770 check till after the cache is created in init_frame_faces.
4771
ff2bc410
SM
47722011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4773
4774 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4775
28177add
PE
47762011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4777
dd3482fe
PE
4778 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4779 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4780 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4781
393d71f3 4782 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4783 * fileio.c (Finsert_file_contents):
4784 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4785 Remove the old (too-loose) buffer overflow checks.
4786 They weren't needed, since make_gap checks for buffer overflow.
4787 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4788 The old code merely checked for Emacs fixnum overflow, and relied
4789 on undefined (wraparound) behavior. The new code avoids undefined
4790 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4791
2e6813b0 4792 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4793 Tune. Don't use wider integers than needed. Don't use alloca.
4794 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4795
599a9e4f
PE
4796 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4797
99561444
PE
4798 * insdel.c, lisp.h (buffer_overflow): New function.
4799 (insert_from_buffer_1, replace_range, replace_range_2):
4800 * insdel.c (make_gap_larger):
4801 * editfns.c (Finsert_char):
4802 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4803
28177add
PE
4804 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4805
e69dafad
PE
48062011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4807
4baa020d 4808 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4809
b1c46f02
PE
4810 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4811 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4812
e69dafad
PE
4813 * fileio.c: Don't assume EMACS_INT fits in off_t.
4814 (emacs_lseek): New static function.
4815 (Finsert_file_contents, Fwrite_region): Use it.
4816 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4817
566684ea
PE
4818 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4819
e6966cd6
PE
4820 * fns.c: Don't overflow int when computing a list length.
4821 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4822 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4823 truncation on 64-bit hosts. Check for QUIT every
4824 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4825 faster and is responsive enough.
4826 (Flength): Report an error instead of overflowing an integer.
4827 (Fsafe_length): Return a float if the value is not representable
4828 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4829 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4830 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4831
dd0b0efb
PE
4832 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4833 (header_size, word_size): New constants.
4834 (allocate_vectorlike): Don't check size overflow here.
4835 (allocate_vector): Check it here instead, since this is the only
4836 caller of allocate_vectorlike that could cause overflow.
4837 Check that the new vector's length is representable as a fixnum.
4838
86fe5cfe
PE
4839 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4840 The previous code was bogus. For example, next_almost_prime (32)
4841 returned 39, which is undesirable as it is a multiple of 3; and
4842 next_almost_prime (24) returned 25, which is a multiple of 5 so
4843 why was the code bothering to check for multiples of 7?
4844
80e88859
PE
4845 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4846
4a2f0ad6
PE
4847 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4848
f66c7cf8
PE
4849 Variadic C functions now count arguments with ptrdiff_t.
4850 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4851 Back then I didn't know that the Emacs coding style prefers signed int.
4852 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4853 were being counted with int, which may truncate counts on 64-bit
4854 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4855 * lisp.h (struct Lisp_Subr.function.aMANY)
4856 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4857 Arg counts are now ptrdiff_t, not size_t.
4858 All variadic functions and their callers changed accordingly.
4859 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4860 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4861 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4862 * callint.c (Fcall_interactively): Check arg count for overflow,
4863 to avoid potential buffer overrun. Use signed char, not 'int',
4864 for 'varies' array, so that we needn't bother to check its size
4865 calculation for overflow.
4866 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4867 * eval.c (apply_lambda):
4868 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4869 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4870 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4871
a1759b76
PE
4872 * callint.c (Fcall_interactively): Don't use index var as event count.
4873
d96be9fc
PE
4874 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4875 * mem-limits.h (SIZE): Remove; no longer used.
4876
a690a978 4877 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4878
578c21e6
PE
4879 Remove unnecessary casts.
4880 * xterm.c (x_term_init):
4881 * xfns.c (x_set_border_pixel):
4882 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4883 These aren't needed now that we assume ANSI C.
4884
96f53c6c
PE
4885 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4886 It's more likely to cause problems (due to unsigned overflow)
4887 than to cure them.
4888
83c77d31
PE
4889 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4890
ee2079f1
PE
4891 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4892
6da65536
PE
4893 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4894
7147c4a4
PE
4895 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4896
193e32d9
PE
4897 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4898
e5533da6
PE
4899 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4900
9910e595
PE
4901 GLYPH_CODE_FACE returns EMACS_INT, not int.
4902 * dispextern.h (merge_faces):
4903 * xfaces.c (merge_faces):
01103c44
PE
4904 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4905 Don't assume EMACS_INT fits in int.
9910e595 4906
2638320e
PE
4907 * character.h (CHAR_VALID_P): Remove unused parameter.
4908 * fontset.c, lisp.h, xdisp.c: All uses changed.
4909
045eb8d9
PE
4910 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4911
c1f134b5
PE
4912 * fns.c (concat): Minor tuning based on overflow analysis.
4913 This doesn't fix any bugs. Use int to hold character, instead
4914 of constantly refetching from Emacs object. Use XFASTINT, not
4915 XINT, for value known to be a character. Don't bother comparing
4916 a single byte to 0400, as it's always less.
4917
395fcb93 4918 * floatfns.c (Fexpt):
327eeec8
PE
4919 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4920
abbd3d23
PE
4921 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4922 for characters.
4923
684a03ef
PE
4924 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4925
0fed43f3
PE
4926 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4927 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4928 incorrectly succeed when S was a string, because 4294967386 was
4929 truncated before it was used.
4930
8fd02eb7
PE
4931 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4932 Otherwise, an out-of-range integer could cause undefined behavior
4933 on a 64-bit host.
4934
f8c86b69
PE
4935 * composite.c: Use int, not EMACS_INT, for characters.
4936 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4937 EMACS_INT, for values that are known to be in character range.
4938 This doesn't fix any bugs but is the usual style inside Emacs and
4939 may generate better code on 32-bit machines.
4940
34206dd2
PE
4941 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4942 This is for reasons similar to the recent CHAR_STRING fix.
4943 * charset.c (Fencode_char): Check that character arg is actually
4944 a character. Pass an int to ENCODE_CHAR.
4945 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4946 wider than 'int', as a compile-time check to prevent future regressions
4947 in this area.
4948
c5958d4c 4949 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4950
4951 Make sure a 64-bit char is never passed to CHAR_STRING.
4952 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4953 by silently ignoring the top 32 bits, allowing some values
4954 that were far too large to be valid characters.
4955 * character.h: Include <verify.h>.
4956 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4957 arguments are no wider than unsigned, as a compile-time check
4958 to prevent future regressions in this area.
4959 * data.c (Faset):
01103c44 4960 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4961 (Fsubst_char_in_region):
4962 * fns.c (concat):
4963 * xdisp.c (decode_mode_spec_coding):
4964 Adjust to CHAR_STRING's new requirement.
4965 * editfns.c (Finsert_char, Fsubst_char_in_region):
4966 * fns.c (concat): Check that character args are actually
4967 characters. Without this test, these functions did the wrong
4968 thing with wildly out-of-range values on 64-bit hosts.
4969
d37ca623
PE
4970 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4971 These casts should not be needed on 32-bit hosts, either.
4972 * keyboard.c (read_char):
4973 * lread.c (Fload): Remove casts to unsigned.
4974
ea204efb
PE
4975 * lisp.h (UNSIGNED_CMP): New macro.
4976 This fixes comparison bugs on 64-bit hosts.
4977 (ASCII_CHAR_P): Use it.
4978 * casefiddle.c (casify_object):
01103c44 4979 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4980 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4981 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4982 * dispextern.h (FACE_FROM_ID):
4983 * keyboard.c (read_char): Use UNSIGNED_CMP.
4984
41cb286c
PE
4985 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4986 not to EMACS_INT, to avoid GCC warning.
4987
4a1b9832
PE
4988 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4989
55daad71
PE
4990 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4991 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4992 isn't needed on 32-bit machines.
8f95c75c 4993
01103c44
PE
4994 * buffer.c (Fgenerate_new_buffer_name):
4995 Use EMACS_INT for count, not int.
0ceccced 4996 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4997
4998 * data.c (Qcompiled_function): Now static.
4999
c6f072e7
PE
5000 * window.c (window_body_lines): Now static.
5001
20ce5912
PE
5002 * image.c (gif_load): Rename local to avoid shadowing.
5003
9c4c5f81
PE
5004 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5005 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5006 * alloc.c (make_save_value): Integer argument is now of type
5007 ptrdiff_t, not int.
5008 (mark_object): Use ptrdiff_t, not int.
5009 * lisp.h (pD): New macro.
5010 * print.c (print_object): Use it.
5011
c0c5c8ae
PE
5012 * alloc.c: Use EMACS_INT, not int, to count objects.
5013 (total_conses, total_markers, total_symbols, total_vector_size)
5014 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5015 (total_free_floats, total_floats, total_free_intervals)
5016 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5017 Now EMACS_INT, not int. All uses changed.
5018 (Fgarbage_collect): Compute overall total using a double, so that
5019 integer overflow is less likely to be a problem. Check for overflow
5020 when converting back to an integer.
5a25e253
PE
5021 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5022 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5023 These were 'int' variables that could overflow on 64-bit hosts;
5024 they were never used, so remove them instead of repairing them.
211a0b2a 5025 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5026 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5027 Previously, this ceilinged at INT_MAX, but that doesn't work on
5028 64-bit machines.
e46bb31a 5029 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5030
c78baabf 5031 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5032 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5033 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5034 when a (possibly-narrower) signed value would do just as well.
5035 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5036
c9d624c6
PE
5037 * alloc.c: Catch some string size overflows that we were missing.
5038 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5039 for convenience in STRING_BYTES_MAX.
5040 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5041 The definition here is exact; the one in lisp.h was approximate.
5042 (allocate_string_data): Check for string overflow. This catches
5043 some instances we weren't catching before. Also, it catches
5044 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5045 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5046 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5047
c9d624c6
PE
5048 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5049 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5050 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5051
353032ce
PE
5052 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5053
2bccce07
PE
5054 * alloc.c (Fmake_string): Check for out-of-range init.
5055
0ac30604
SM
50562011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5057
5058 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5059
c195f2de
JD
50602011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5061
5062 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5063 xg_get_default_scrollbar_width.
5064
5065 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5066 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5067 (style_changed_cb): Call update_theme_scrollbar_width and call
5068 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5069 all frames (Bug#8505).
5070 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5071 Call gtk_window_set_resizable if HAVE_GTK3.
5072 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5073 and height if HAVE_GTK3 (Bug#8505).
5074 (scroll_bar_width_for_theme): New variable.
5075 (update_theme_scrollbar_width): New function.
5076 (xg_get_default_scrollbar_width): Move code to
5077 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5078 (xg_initialize): Call update_theme_scrollbar_width.
5079
5080 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5081
5082 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5083
e10ac9f1
MR
50842011-06-12 Martin Rudalics <rudalics@gmx.at>
5085
5086 * frame.c (make_frame): Call other_buffer_safely instead of
5087 other_buffer.
5088
5089 * window.c (temp_output_buffer_show): Call display_buffer with
5090 second argument Vtemp_buffer_show_specifiers and reset latter
5091 immediately after the call.
5092 (Vtemp_buffer_show_specifiers): New variable.
5093 (auto_window_vscroll_p, next_screen_context_lines)
5094 (Vscroll_preserve_screen_position): Remove leading asterisks from
5095 doc-strings.
5096
2d3c217e 50972011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5098
7b7f97e8 5099 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5100 * buffer.c (Qclone_number): Remove for now, as it's unused.
5101 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5102 (record_buffer): Remove unused local.
5103 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5104 (set_frame_buffer_list): Remove; unused.
5105 * frame.h (other_visible_frames): Remove decl.
5106 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5107 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5108 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5109 if HAVE_GPM.
5110 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5111 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5112 Define only if HAVE_GPM.
5113 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5114 (update_hints_inhibit): Remove; never set. All uses removed.
5115 * widgetprv.h (emacsFrameClassRec): Remove decl.
5116 * window.c (delete_deletable_window): Now returns void, since it
5117 wasn't returning anything.
5118 (compare_window_configurations): Remove unused locals.
5119 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5120 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5121 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5122 the same widths as pointers. This follows up on the 2011-05-06 patch.
5123 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5124 * xterm.h: Likewise.
5125 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5126
1384b89e
JB
51272011-06-12 Juanma Barranquero <lekktu@gmail.com>
5128
5129 * makefile.w32-in: Update dependencies.
5130 (LISP_H): Add lib/intprops.h.
5131
1100a63c
CY
51322011-06-11 Chong Yidong <cyd@stupidchicken.com>
5133
5134 * image.c (gif_load): Add animation frame delay to the metadata.
5135 (syms_of_image): Use DEFSYM. New symbol `delay'.
5136
6198ccd0
MR
51372011-06-11 Martin Rudalics <rudalics@gmx.at>
5138
5139 * window.c (delete_deletable_window): Re-add.
5140 (Fset_window_configuration): Rewrite to handle dead buffers and
5141 consequently deletable windows.
5142 (window_tree, Fwindow_tree): Remove. Supply functionality in
5143 window.el.
5144 (compare_window_configurations): Simplify code.
5145
b6e3633c
AS
51462011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5147
1ab0dee5
AS
5148 * image.c (imagemagick_load_image): Fix type mismatch.
5149 (Fimagemagick_types): Likewise.
5150
b6e3633c
AS
5151 * window.h (replace_buffer_in_windows): Declare.
5152
9397e56f
MR
51532011-06-11 Martin Rudalics <rudalics@gmx.at>
5154
5155 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5156 Qclone_number. Remove external declaration of Qdelete_window.
5157 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5158 code.
640c8776
SM
5159 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5160 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5161 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5162 buffer list implementation.
5163 (other_buffer_safely): New function.
5164 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5165 calls to replace_buffer_in_windows and
5166 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5167 if allowed.
5168 (record_buffer): Inhibit quitting and rewrite using quittable
5169 functions. Run Qbuffer_list_update_hook if allowed.
5170 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5171 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5172 Move switch-to-buffer to window.el.
9397e56f
MR
5173 (bury-buffer): Move to window.el.
5174 (Vbuffer_list_update_hook): New variable.
5175
5176 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5177 section.
5178
5179 * window.h (resize_frame_windows): Move up in code.
5180 (Fwindow_frame): Remove EXFUN.
5181 (replace_buffer_in_all_windows): Remove prototype.
5182 (replace_buffer_in_windows_safely): Add prototype.
5183
5184 * window.c: Declare Qdelete_window static again. Move down
5185 declaration of select_count.
5186 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5187 (Fother_window): Move to window.el.
5188 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5189 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5190 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5191 window.el.
5192 (replace_buffer_in_windows): Implement by calling
5193 Qreplace_buffer_in_windows.
5194 (replace_buffer_in_all_windows): Remove with some functionality
5195 moved into replace_buffer_in_windows_safely.
5196 (replace_buffer_in_windows_safely): New function.
5197 (select_window_norecord, select_frame_norecord): Move in front
5198 of run_window_configuration_change_hook. Remove now obsolete
5199 declarations.
640c8776
SM
5200 (Fset_window_buffer): Rewrite doc-string.
5201 Call Qrecord_window_buffer.
9397e56f
MR
5202 (keys_of_window): Move binding for other-window to window.el.
5203
b50691aa
CY
52042011-06-11 Chong Yidong <cyd@stupidchicken.com>
5205
5206 * dispextern.h (struct image): Replace data member, whose int_val
5207 and ptr_val fields were not used by anything, with a single
5208 lisp_val object.
5209
5210 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5211 (gif_clear_image, gif_load, imagemagick_load_image)
5212 (gs_clear_image, gs_load): Callers changed.
5213
3f754b86
PE
52142011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5215
cca69397
PE
5216 * buffer.h: Include <time.h>, for time_t.
5217 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5218
109e28d0
PE
5219 Fix minor problems found by static checking.
5220
60737f02
PE
5221 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5222
4b66faf3
PE
5223 Make identifiers static if they are not used in other modules.
5224 * data.c (Qcompiled_function, Qframe, Qvector):
5225 * image.c (QimageMagick, Qsvg):
5226 * minibuf.c (Qmetadata):
5227 * window.c (resize_window_check, resize_root_window): Now static.
5228 * window.h (resize_window_check, resize_root_window): Remove decls.
5229
109e28d0
PE
5230 * window.c (window_deletion_count, delete_deletable_window):
5231 Remove; unused.
46a4ce9e
PE
5232 (window_body_lines): Now static.
5233 (Fdelete_other_windows_internal): Mark vars as initialized.
5234 Make sure 'resize_failed' is initialized.
5235 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5236 (resize_window_apply): Remove unused local.
5237 * window.h (delete_deletable_window): Remove decl.
5238
109e28d0 5239 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5240 (imagemagick_load_image): Fix pointer signedness problem by changing
5241 last arg from unsigned char * to char *. All uses changed.
5242 Also, fix a local for similar reasons.
5243 Remove unused locals. Remove locals to avoid shadowing.
5244 (fn_rsvg_handle_free): Remove; unused.
5245 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5246 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5247
3f754b86
PE
5248 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5249
2547adb1
CY
52502011-06-10 Chong Yidong <cyd@stupidchicken.com>
5251
5252 * image.c (gif_load): Fix omitted cast error introduced by
5253 2011-06-06 change.
5254
2c8e37d4
MR
52552011-06-10 Martin Rudalics <rudalics@gmx.at>
5256
5257 * window.h (resize_proportionally, orig_total_lines)
5258 (orig_top_line): Remove from window structure.
5259 (set_window_height, set_window_width, change_window_heights)
5260 (Fdelete_window): Remove prototypes.
5261 (resize_frame_windows): Remove duplicate declaration.
5262
440a42e3
EZ
52632011-06-10 Eli Zaretskii <eliz@gnu.org>
5264
5265 * window.h (resize_frame_windows, resize_window_check)
5266 (delete_deletable_window, resize_root_window)
5267 (resize_frame_windows): Declare prototypes.
5268
5269 * window.c (resize_window_apply): Make definition be "static" to
5270 match the prototype.
5271
562dd5e9
MR
52722011-06-10 Martin Rudalics <rudalics@gmx.at>
5273
5274 * window.c: Remove declarations of Qwindow_size_fixed,
5275 window_min_size_1, window_min_size_2, window_min_size,
5276 size_window, window_fixed_size_p, enlarge_window, delete_window.
5277 Remove static from declaration of Qdelete_window, it's
5278 temporarily needed by Fbury_buffer.
5279 (replace_window): Don't assign orig_top_line and
5280 orig_total_lines.
5281 (Fdelete_window, delete_window): Remove. Window deletion is
5282 handled by window.el.
640c8776
SM
5283 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5284 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5285 (Fdelete_other_windows): Remove. Deleting other windows is
5286 handled by window.el.
5287 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5288 handled in window.el.
5289 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5290 Window minimum sizes are handled in window.el.
5291 (shrink_windows, size_window, set_window_height)
5292 (set_window_width, change_window_heights, window_height)
5293 (window_width, CURBEG, CURSIZE, enlarge_window)
5294 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5295 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5296 handled in window.el.
5297 (make_dummy_parent): Rename to make_parent_window and give it a
5298 second argument horflag.
5299 (make_window): Don't set resize_proportionally any more.
5300 (Fsplit_window): Remove. Windows are split in window.el.
5301 (save_restore_action, save_restore_orig_size)
5302 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5303 Resize mini windows in window.el.
5304 (grow_mini_window, shrink_mini_window): Implement by calling
5305 Qresize_root_window_vertically, resize_window_check and
5306 resize_window_apply.
640c8776
SM
5307 (saved_window, Fset_window_configuration, save_window_save):
5308 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5309 resize_proportionally.
5310 (window_min_height, window_min_width): Move to window.el.
5311 (keys_of_window): Move bindings for delete-other-windows,
5312 split-window, delete-window and enlarge-window to window.el.
5313
5314 * buffer.c: Temporarily extern Qdelete_window.
5315 (Fbury_buffer): Temporarily call Qdelete_window instead of
5316 Fdelete_window (Fbury_buffer will move to window.el soon).
5317
5318 * frame.c (set_menu_bar_lines_1): Remove code handling
5319 orig_top_line and orig_total_lines.
5320
5321 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5322 set_window_height but set heights directly.
5323 (change_frame_size_1): Use resize_frame_windows.
5324
5325 * xdisp.c (init_xdisp): Don't use set_window_height but set
5326 heights directly.
5327
640c8776
SM
5328 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5329 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5330 run_window_configuration_change_hook.
5331
5332 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5333 instead of change_window_heights and run
5334 run_window_configuration_change_hook.
5335
1a13852e
MR
53362011-06-09 Martin Rudalics <rudalics@gmx.at>
5337
5338 * window.c (replace_window): Rename second argument REPLACEMENT to
5339 NEW. New third argument SETFLAG. Rewrite.
5340 (delete_window, make_dummy_parent): Call replace_window with
5341 third argument 1.
5342 (window_list_1): Move down in code.
5343 (run_window_configuration_change_hook): Move set_buffer part
5344 before select_frame_norecord part in order to unwind correctly.
5345 Rename count1 to count.
5346 (recombine_windows, delete_deletable_window, resize_root_window)
5347 (Fdelete_other_windows_internal)
5348 (Frun_window_configuration_change_hook, make_parent_window)
5349 (resize_window_check, resize_window_apply, Fresize_window_apply)
5350 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5351 (Fdelete_window_internal, Fresize_mini_window_internal):
5352 New functions.
1a13852e
MR
5353 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5354
f3d1777e
MR
53552011-06-08 Martin Rudalics <rudalics@gmx.at>
5356
496e208e
MR
5357 * window.h (window): Add some new members to window structure -
5358 normal_lines, normal_cols, new_total, new_normal, clone_number,
5359 splits, nest, prev_buffers, next_buffers.
5360 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5361 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5362
f3d1777e
MR
5363 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5364 Remove.
496e208e
MR
5365 (make_dummy_parent): Set new members of windows structure.
5366 (make_window): Move down in code. Handle new members of window
5367 structure.
5368 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5369 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5370 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5371 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5372 (Fset_window_next_buffers, Fset_window_clone_number):
5373 New functions.
496e208e
MR
5374 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5375 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5376 Doc-string fixes.
5377 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5378 Argument WINDOW can be now internal window too.
5379 (Fwindow_use_time): Move up in code.
5380 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5381 Rewrite doc-string.
5382 (Fset_window_configuration, saved_window)
5383 (Fcurrent_window_configuration, save_window_save): Handle new
5384 members of window structure.
b9e809c2
MR
5385 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5386 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5387 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5388 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5389 Qget_mru_window, Qresize_root_window,
5390 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5391 Qauto_buffer_name; staticpro them.
f3d1777e 5392
abde8f8c
MR
53932011-06-07 Martin Rudalics <rudalics@gmx.at>
5394
5395 * window.c (Fwindow_total_size, Fwindow_left_column)
5396 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5397 (Fwindow_list_1): New functions.
5398 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5399 (Fwindow_width, Fscroll_left, Fscroll_right):
5400 Use window_body_cols instead of window_box_text_cols.
5401 (delete_window, Fset_window_configuration):
5402 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5403 (delete_all_subwindows): Take a window as argument and not a
5404 structure. Rewrite.
190b47e6
MR
5405 (window_loop): Remove handling of GET_LRU_WINDOW and
5406 GET_LARGEST_WINDOW.
5407 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5408
5409 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5410 window_box_text_cols. delete_all_subwindows now takes a
5411 Lisp_Object as argument.
abde8f8c 5412
640c8776
SM
5413 * indent.c (compute_motion, Fcompute_motion):
5414 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5415
fa8a67e6
MR
5416 * frame.c (delete_frame): Call delete_all_subwindows with root
5417 window as argument.
5418
a54e3482
DC
54192011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5420
5421 * fns.c (Fputhash): Document return value.
5422
60002bf5
CY
54232011-06-06 Chong Yidong <cyd@stupidchicken.com>
5424
5425 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5426
0c671da6 54272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5428
b862a52a 5429 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5430
be44ca6c
PE
5431 Check for overflow when converting integer to cons and back.
5432 * charset.c (Fdefine_charset_internal, Fdecode_char):
5433 Use cons_to_unsigned to catch overflow.
5434 (Fencode_char): Use INTEGER_TO_CONS.
5435 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5436 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5437 * data.c (long_to_cons, cons_to_long): Remove.
5438 (cons_to_unsigned, cons_to_signed): New functions.
5439 These signal an error for invalid or out-of-range values.
5440 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5441 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5442 * font.c (Ffont_variation_glyphs):
5443 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5444 * lisp.h: Include <intprops.h>.
5445 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5446 (cons_to_signed, cons_to_unsigned): New decls.
5447 (long_to_cons, cons_to_long): Remove decls.
5448 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5449 (Fprimitive_undo): Use CONS_TO_INTEGER.
5450 * xfns.c (Fx_window_property): Likewise.
5451 * xselect.c: Include <limits.h>.
5452 (x_own_selection, selection_data_to_lisp_data):
5453 Use INTEGER_TO_CONS.
5454 (x_handle_selection_request, x_handle_selection_clear)
5455 (x_get_foreign_selection, Fx_disown_selection_internal)
5456 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5457 (lisp_data_to_selection_data): Use cons_to_unsigned.
5458 (x_fill_property_data): Use cons_to_signed.
5459 Report values out of range.
5460
d1f3d2af
PE
5461 Check for buffer and string overflow more precisely.
5462 * buffer.h (BUF_BYTES_MAX): New macro.
5463 * lisp.h (STRING_BYTES_MAX): New macro.
5464 * alloc.c (Fmake_string):
5465 * character.c (string_escape_byte8):
5466 * coding.c (coding_alloc_by_realloc):
5467 * doprnt.c (doprnt):
5468 * editfns.c (Fformat):
5469 * eval.c (verror):
5470 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5471 since they may not be the same number.
5472 * editfns.c (Finsert_char):
5473 * fileio.c (Finsert_file_contents):
5474 Likewise for BUF_BYTES_MAX.
5475
dd52fcea
PE
5476 * image.c: Use ptrdiff_t, not int, for sizes.
5477 (slurp_file): Switch from int to ptrdiff_t.
5478 All uses changed.
5479 (slurp_file): Check that file size fits in both size_t (for
5480 malloc) and ptrdiff_t (for sanity and safety).
5481
7f9bbdbb
PE
5482 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5483 if b->modtime has its maximal value.
5484
dfe18f82
PE
5485 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5486
84acfcf0
PE
5487 Don't assume time_t can fit into int.
5488 * buffer.h (struct buffer.modtime): Now time_t, not int.
5489 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5490 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5491
ccd9a01a
PE
5492 Minor fixes for signed vs unsigned integers.
5493 * character.h (MAYBE_UNIFY_CHAR):
5494 * charset.c (maybe_unify_char):
5495 * keyboard.c (read_char, reorder_modifiers):
5496 XINT -> XFASTINT, since the integer must be nonnegative.
5497 * ftfont.c (ftfont_spec_pattern):
5498 * keymap.c (access_keymap, silly_event_symbol_error):
5499 XUINT -> XFASTINT, since the integer must be nonnegative.
5500 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5501 since it makes no difference and we prefer signed.
5502 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5503 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5504 nonnegative.
5505
d6d100dd
SM
55062011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5507
5508 * window.h (Fwindow_frame): Declare.
5509
2b6148e4
PE
55102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5511
5512 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5513 (SPARE_MEMORY): Always define.
5514 (LARGE_REQUEST): Remove.
5515 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5516
f230ecc9
MR
55172011-06-06 Martin Rudalics <rudalics@gmx.at>
5518
727e958e
MR
5519 * lisp.h: Move EXFUNS for Fframe_root_window,
5520 Fframe_first_window and Fset_frame_selected_window to window.h.
5521
5522 * window.h: Move EXFUNS for Fframe_root_window,
5523 Fframe_first_window and Fset_frame_selected_window here from
5524 lisp.h.
5525
5526 * frame.c (Fwindow_frame, Fframe_first_window)
5527 (Fframe_root_window, Fframe_selected_window)
5528 (Fset_frame_selected_window): Move to window.c.
5529 (Factive_minibuffer_window): Move to minibuf.c.
5530 (Fother_visible_frames_p): New function.
5531
5532 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5533
f230ecc9
MR
5534 * window.c (decode_window, decode_any_window): Move up in code.
5535 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5536 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5537 (Fwindow_buffer): Move up and rewrite doc-string.
5538 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5539 (Fwindow_prev): New functions.
727e958e
MR
5540 (Fwindow_frame): Move here from frame.c. Accept any window as
5541 argument.
5542 (Fframe_root_window, Fframe_first_window)
5543 (Fframe_selected_window): Move here from frame.c. Accept frame
5544 or arbitrary window as argument. Update doc-strings.
5545 (Fminibuffer_window): Move up in code.
5546 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5547 (Fset_frame_selected_window): Move here from frame.c.
5548 Marginal rewrite.
727e958e
MR
5549 (Fselected_window, select_window, Fselect_window): Move up in
5550 code. Minor doc-string fixes.
f230ecc9 5551
4d09bcf6
PE
55522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5553
5554 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5555 Do not assume that spare memory exists; that assumption is valid
5556 only if SYSTEM_MALLOC.
5557 (LARGE_REQUEST): New macro, so that the issue of large requests
5558 is separated from the issue of spare memory.
5559
810928a2
AS
55602011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5561
172418ad
AS
5562 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5563 format. (Bug#8806)
5564
43f862f7
AS
5565 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5566
810928a2
AS
5567 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5568 before statements.
5569
a059fe24
JD
55702011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5571
5572 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5573
5574 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5575
5576 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5577 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5578
989bf368
JB
55792011-06-05 Juanma Barranquero <lekktu@gmail.com>
5580
5581 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5582
4b80f674
CY
55832011-06-04 Chong Yidong <cyd@stupidchicken.com>
5584
5585 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5586 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5587 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5588 New error handlers.
4b80f674
CY
5589 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5590 Obey Vx_select_enable_clipboard_manager. Catch errors in
5591 x_clipboard_manager_save (Bug#8779).
5592 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5593 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5594
99a33b77 55952011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5596
5597 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5598
99a33b77 55992011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5600
5601 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5602 in the current matrix if keep_current_p is non-zero.
5603
8264569d
EZ
56042011-06-04 Eli Zaretskii <eliz@gnu.org>
5605
5606 * bidi.c (bidi_level_of_next_char): Fix last change.
5607
57f97249
EZ
56082011-06-03 Eli Zaretskii <eliz@gnu.org>
5609
fec2107c 5610 Support bidi reordering of text covered by display properties.
57f97249 5611
fec2107c
EZ
5612 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5613 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5614 (bidi_cache_search, bidi_cache_iterator_state)
5615 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5616 (bidi_level_of_next_char, bidi_move_to_visually_next):
5617 Support character positions inside a run of characters covered by a
fec2107c
EZ
5618 display string.
5619 (bidi_paragraph_init, bidi_resolve_explicit_1)
5620 (bidi_level_of_next_char): Call bidi_fetch_char and
5621 bidi_fetch_char_advance instead of FETCH_CHAR and
5622 FETCH_CHAR_ADVANCE.
5623 (bidi_init_it): Initialize new members.
5624 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5625 definitions.
5626 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5627 instead of using explicit *_CHAR codes.
d6d100dd
SM
5628 (bidi_resolve_explicit, bidi_resolve_weak):
5629 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5630 bidirectional text is supported only in multibyte buffers.
5631 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5632 it to initialize the frame_window_p member of struct bidi_it.
5633 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5634 (bidi_resolve_explicit, bidi_resolve_weak)
5635 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5636 bidi_it->nchars is non-positive.
5637 (bidi_level_of_next_char): Don't try to lookup the cache for the
5638 next/previous character if nothing is cached there yet, or if we
5639 were just reseat()'ed to a new position.
c40e2fb2 5640
0e14fe90
EZ
5641 * xdisp.c (set_cursor_from_row): Set start and stop points
5642 according to the row's direction when priming the loop that looks
5643 for the glyph on which to display cursor.
5644 (single_display_spec_intangible_p): Function deleted.
5645 (display_prop_intangible_p): Reimplement to call
5646 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5647 Accept 3 additional arguments needed by handle_display_spec.
5648 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5649 values: lists, `(when COND...)' forms, etc.
5650 (single_display_spec_string_p): Support property values that are
5651 lists with the argument STRING its top-level element.
5652 (display_prop_string_p): Fix the condition for processing a
5653 property that is a list to be consistent with handle_display_spec.
fec2107c 5654 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5655 last portion of handle_display_prop.
5656 (compute_display_string_pos): Accept additional argument
5657 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5658 value of a `display' property is a "replacing spec".
5659 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5660 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5661 the display property, but just return a value indicating whether
5662 the display property will replace the characters it covers.
5663 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5664 frame_window_p members of struct bidi_it.
d6d100dd
SM
5665 (compute_display_string_pos, compute_display_string_end):
5666 New functions.
fec2107c
EZ
5667 (push_it): Accept second argument POSITION, where pop_it should
5668 jump to continue iteration.
5669 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5670
fec2107c
EZ
5671 * keyboard.c (adjust_point_for_property): Adjust the call to
5672 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5673
5674 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5675 (bidi_init_it): Update prototypes.
5676 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5677 (compute_display_string_pos, compute_display_string_end):
5678 Declare prototypes.
fec2107c
EZ
5679 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5680 EMACS_INT.
fc6f18ce 5681
40087514 56822011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5683
57f53182
PE
5684 Malloc failure behavior now depends on size of allocation.
5685 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5686 * lisp.h: Change signatures accordingly.
5687 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5688 All callers changed. (Bug#8762)
5689
5690 * gnutls.c: Use Emacs's memory allocators.
5691 Without this change, the gnutls library would invoke malloc etc.
5692 directly, which causes problems on non-SYNC_INPUT hosts, and which
5693 runs afoul of improving memory_full behavior. (Bug#8761)
5694 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5695 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5696 xfree instead of the default malloc, realloc, free.
5697 (Fgnutls_boot): No need to check for memory allocation failure,
5698 since xmalloc does that for us.
5699
ac32cd99 5700 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5701 * category.c (hash_get_category_set):
5702 * ccl.c (ccl_driver):
5703 * charset.c (Fdefine_charset_internal):
5704 * charset.h (struct charset.hash_index):
5705 * composite.c (get_composition_id, gstring_lookup_cache)
5706 (composition_gstring_put_cache):
5707 * composite.h (struct composition.hash_index):
5708 * dispextern.h (struct image.hash):
5709 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5710 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5711 (hashfn_equal, hashfn_user_defined, make_hash_table)
5712 (maybe_resize_hash_table, hash_lookup, hash_put)
5713 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5714 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5715 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5716 * image.c (make_image, search_image_cache, lookup_image)
5717 (xpm_put_color_table_h):
5718 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5719 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5720 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5721 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5722 * alloc.c (allocate_vectorlike):
5723 Check for overflow in vector size calculations.
5724 * ccl.c (ccl_driver):
5725 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5726 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5727 need to be updated by these changes.
40087514
PE
5728 * fns.c (make_hash_table, maybe_resize_hash_table):
5729 Check for integer overflow with large hash tables.
0de4bb68
PE
5730 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5731 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5732 (SXHASH_REDUCE): New macro.
5733 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5734 Use it instead of discarding useful hash info with large hash values.
5735 (sxhash_float): New function.
5736 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5737 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5738 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5739 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5740 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5741 Adjust signatures to match updated version of code.
5742 (consing_since_gc): Now EMACS_INT, since a single hash table can
5743 use more than INT_MAX bytes.
5744
698d32e2
DN
57452011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5746
5747 Make it possible to build with GCC-4.6+ -O2 -flto.
5748
5749 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5750
fd6fa53f
SM
57512011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5752
5753 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5754 Call minibuffer-inactive-mode.
5755
864db017
JB
57562011-05-31 Juanma Barranquero <lekktu@gmail.com>
5757
5758 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5759 Update dependencies.
5760
2ad0baf4
DN
57612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5762
5763 * data.c (init_data): Remove code for UTS, this system is not
5764 supported anymore.
5765
4fcc2638
DN
57662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5767
5768 Don't force ./temacs to start in terminal mode.
5769
5770 * frame.c (make_initial_frame): Initialize faces in all cases, not
5771 only when CANNOT_DUMP is defined.
5772 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5773
c56e0fd5
DN
57742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5775
5776 * dispnew.c (add_window_display_history): Use const for the string
5777 pointer. Remove declaration, not needed.
5778
333d54da 57792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5780
55d4c1b2 5781 Use 'inline', not 'INLINE'.
333d54da 5782 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5783 * alloc.c, fontset.c (INLINE): Remove.
5784 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5785 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5786 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5787 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5788 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5789
738db178
DN
57902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5791
5792 Make it possible to run ./temacs.
5793
5794 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5795 syms_of_callproc does the same thing. Remove test for
5796 "initialized", do it in the caller.
5797 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5798
620c53a6
SM
57992011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5800
5801 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5802 (read_minibuf): Use get_minibuffer.
5803 (syms_of_minibuf): Use DEFSYM.
5804 (Qmetadata): New var.
5805 * data.c (Qbuffer): Don't make it static.
5806 (syms_of_data): Use DEFSYM.
5807
e003a292
PE
58082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5809
5810 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5811 (CCL_CODE_MIN): New macro.
5812
ed008a6d
PE
58132011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5814
3687c2ef
PE
5815 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5816
ed008a6d
PE
5817 * eval.c (Qdebug): Now static.
5818 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5819 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5820 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5821
d66c4c7c
CY
58222011-05-29 Chong Yidong <cyd@stupidchicken.com>
5823
5824 * image.c: Various fixes to ImageMagick code comments.
5825 (Fimagemagick_types): Doc fix.
5826
5fbc2025
PE
58272011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5828
0196f88a
PE
5829 Minor fixes prompted by GCC 4.6.0 warnings.
5830
5831 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5832
5fbc2025
PE
5833 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5834 (x_clipboard_manager_save_all): Move extern decl to ...
5835 * xterm.h: ... here, so that it can be checked for consistency.
5836
1dd3c2d9
CY
58372011-05-29 Chong Yidong <cyd@stupidchicken.com>
5838
5839 * xselect.c (x_clipboard_manager_save_frame)
5840 (x_clipboard_manager_save_all): New functions.
5841 (Fx_clipboard_manager_save): Lisp function deleted.
5842
5843 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5844 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5845
5846 * xterm.h: Update prototype.
5847
5ba6571d
WX
58482011-05-28 William Xu <william.xwl@gmail.com>
5849
5850 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5851 exiting (Bug#8239).
5852
3eaff834
JM
58532011-05-28 Jim Meyering <meyering@redhat.com>
5854
e1900994 5855 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5856 * fns.c (to_uchar): Define.
5857 (crypto_hash_function): Use it to convert some newly-signed
5858 variables to unsigned, to avoid sign-extension bugs. For example,
5859 without this change, (md5 "truc") would evaluate to
5860 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5861 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5862 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5863
0f6990a7
PE
58642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5865
5866 Integer overflow fixes.
c8a9ca5a 5867
08686060
PE
5868 * dbusbind.c: Serial number integer overflow fixes.
5869 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5870 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5871 to hold a serial number that is too large for a fixnum.
5872 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5873 Check for serial numbers out of range. Decode any serial number
59568bf0 5874 that was so large that it became a float. (Bug#8722)
08686060 5875
2d1fc3c7
PE
5876 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5877 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5878 Use XFASTINT rather than XUINT when numbers are nonnegative.
5879 (xd_append_arg, Fdbus_method_return_internal):
5880 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5881 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5882 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5883 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5884 (Bug#8722)
2d1fc3c7 5885
c8a9ca5a
PE
5886 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5887
519e1d69
PE
5888 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5889
6df6ae42 5890 ccl: Add integer overflow checks.
30569699
PE
5891 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5892 (IN_INT_RANGE): New macros.
5893 (ccl_driver): Use them to check for integer overflow when
5894 decoding a CCL program. Many of the new checks are whether XINT (x)
5895 fits in int; it doesn't always, on 64-bit hosts. The new version
5896 doesn't catch all possible integer overflows, but it's an
847044ea 5897 improvement. (Bug#8719)
30569699 5898
c11285dc
PE
5899 * alloc.c (make_event_array): Use XINT, not XUINT.
5900 There's no need for unsigned here.
5901
fdccd48e
PE
5902 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5903 This follows up to the 2011-05-06 change that substituted uintptr_t
5904 for EMACS_INT. This case wasn't caught back then.
5905
37910ab2
PE
5906 Rework Fformat to avoid integer overflow issues.
5907 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5908 now (part of C89). Include <verify.h>.
5909 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5910 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5911 (Fformat): Avoid the prepass trying to compute sizes; it was only
5912 approximate and thus did not catch overflow reliably. Instead, walk
5913 through the format just once, formatting and computing sizes as we go,
5914 checking for integer overflow at every step, and allocating a larger
5915 buffer as needed. Keep track separately whether the format is
5916 multibyte. Keep only the most-recently calculated precision, rather
5917 than them all. Record whether each argument has been converted to
5918 string. Use EMACS_INT, not int, for byte and char and arg counts.
5919 Support field widths and precisions larger than INT_MAX. Avoid
5920 sprintf's undefined behavior with conversion specifications such as %#d
5921 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5922 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5923 formatting out-of-range floating point numbers with int
9173deec 5924 formats. (Bug#8668)
37910ab2 5925
2e6578fb
PE
5926 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5927
0ae6bdee
PE
5928 * data.c: Avoid integer truncation in expressions involving floats.
5929 * data.c: Include <intprops.h>.
5930 (arith_driver): When there's an integer overflow in an expression
5931 involving floating point, convert the integers to floating point
5932 so that the resulting value does not suffer from catastrophic
5933 integer truncation. For example, on a 64-bit host (* 4
5934 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5935 Do not rely on undefined behavior after integer overflow.
5936
de883a70
PE
5937 merge count_size_as_multibyte, parse_str_to_multibyte
5938 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5939 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5940 Check for integer overflow.
5941 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5942 since it's now a duplicate of the other. This is more of
5943 a character than a buffer op, so better that it's in character.c.
5944 * fns.c, print.c: Adjust to above changes.
5945
2ff916cb
PE
59462011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5947
5948 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5949
f1b54466
PE
59502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5951
fb1ac845
PE
5952 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5953 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5954 (x_clipboard_manager_save): Now static.
5955 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5956
f1b54466
PE
5957 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5958 (crypto_hash_function): Now static.
5959 Fix pointer signedness problems. Avoid unnecessary initializations.
5960
a9f737ee
CY
59612011-05-27 Chong Yidong <cyd@stupidchicken.com>
5962
5963 * termhooks.h (Vselection_alist): Make it terminal-local.
5964
5965 * terminal.c (create_terminal): Initialize it.
5966
5967 * xselect.c: Support for clipboard managers.
5968 (Vselection_alist): Move to termhooks.h as terminal-local var.
5969 (LOCAL_SELECTION): New macro.
5970 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5971 (symbol_to_x_atom): Remove gratuitous arg.
5972 (x_handle_selection_request, lisp_data_to_selection_data)
5973 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5974 (x_own_selection, x_get_local_selection, x_convert_selection):
5975 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5976 (some_frame_on_display): Delete unused function.
5977 (Fx_own_selection_internal, Fx_get_selection_internal)
5978 (Fx_disown_selection_internal, Fx_selection_owner_p)
5979 (Fx_selection_exists_p): New optional frame arg.
5980 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5981 (x_handle_selection_clear): Don't treat other terminals with the
5982 same keyboard specially. Use the terminal-local Vselection_alist.
5983 (x_clear_frame_selections): Use Frun_hook_with_args.
5984
5985 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5986
5987 * xterm.h: Add support for those atoms.
5988
e067f0c1
CY
59892011-05-26 Chong Yidong <cyd@stupidchicken.com>
5990
5991 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5992 (converted_selections, conversion_fail_tag): New global variables.
5993 (x_selection_request_lisp_error): Free the above.
5994 (x_get_local_selection): Remove unnecessary code.
5995 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5996 of converted selections stored in converted_selections.
5997 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5998 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5999 (x_convert_selection): New function.
6000 (x_handle_selection_event): Simplify.
6001 (x_get_foreign_selection): Don't ignore incoming requests while
6002 waiting for an answer; this will fail when we implement
6003 SAVE_TARGETS, and seems unnecessary anyway.
6004 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6005 (Vx_sent_selection_functions): Doc fix.
6006
0f4aebc0
LL
60072011-05-26 Leo Liu <sdl.web@gmail.com>
6008
6009 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6010
e61124cd
YM
60112011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6012
6013 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6014
6015 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6016 for fringe update if it has periodic bitmap.
ac389d0c 6017 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6018 and fringe_bitmap_periodic_p.
6019
6020 * fringe.c (get_fringe_bitmap_data): New function.
6021 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6022 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6023 row. Mark glyph row for fringe update if periodicity changed.
6024
6025 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6026 for fringe update unless it has periodic bitmap.
6027
f16d9837
KH
60282011-05-25 Kenichi Handa <handa@m17n.org>
6029
6030 * xdisp.c (get_next_display_element): Set correct it->face_id for
6031 a static composition.
6032
e1b90ef6
LL
60332011-05-24 Leo Liu <sdl.web@gmail.com>
6034
6035 * deps.mk (fns.o):
6036 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6037
6038 * fns.c (crypto_hash_function, Fsha1): New function.
6039 (Fmd5): Use crypto_hash_function.
6040 (syms_of_fns): Add Ssha1.
6041
7400048f
PE
60422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6043
6044 * gnutls.c: Remove unused macros.
6045 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6046 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6047 Remove macros that are defined and never used.
6048 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6049
abb71cf4
CY
60502011-05-22 Chong Yidong <cyd@stupidchicken.com>
6051
6052 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6053 (Fx_get_selection_internal): Minor cleanup.
6054 (Fx_own_selection_internal): Rename arguments for consistency with
6055 select.el.
6056
6307db39
PE
60572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6058
6059 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6060
f3d4e0a4
CY
60612011-05-22 Chong Yidong <cyd@stupidchicken.com>
6062
6063 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6064
4d8ade89
YM
60652011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6066
6067 * dispnew.c (scrolling_window): Don't exclude the case that the
6068 last enabled row in the desired matrix touches the bottom boundary.
6069
32078c8d
GM
60702011-05-21 Glenn Morris <rgm@gnu.org>
6071
6072 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6073 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6074 and add some more files.
32078c8d 6075
7285dc67
EZ
60762011-05-20 Eli Zaretskii <eliz@gnu.org>
6077
6078 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6079 report_file_error introduced by the change from 2011-05-07.
6080
89d1bd22
PE
60812011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6082
6083 * systime.h (Time): Define only if emacs is defined.
6084 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6085 where the include path doesn't have X11/X.h by default. See
6086 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6087
cd394be1 60882011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6089
6090 * composite.c (find_automatic_composition): Fix previous change.
6091
b9704ad9
GM
60922011-05-20 Glenn Morris <rgm@gnu.org>
6093
6094 * lisp.mk: New file, split from Makefile.in.
6095 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6096 (shortlisp): Remove.
6097 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6098
4a720484
GM
60992011-05-19 Glenn Morris <rgm@gnu.org>
6100
6101 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6102 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6103 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6104 (lisp): Set the order to that of loadup.el.
6105 (shortlisp): Make it a copy of $lisp.
6106 (SOME_MACHINE_LISP): Remove.
6107 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6108 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6109
a28d4396
KH
61102011-05-18 Kenichi Handa <handa@m17n.org>
6111
6112 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6113 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6114 (find_automatic_composition): Mostly rewrite for efficiency.
6115
a2b1fa8e
JB
61162011-05-18 Juanma Barranquero <lekktu@gmail.com>
6117
6118 * makefile.w32-in: Update dependencies.
6119
8e1f5610
CS
61202011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6121
6122 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6123 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6124
7025ee00 61252011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6126
cdfa6eab
PE
6127 Fix some integer overflow issues, such as string length overflow.
6128
06d6db33
PE
6129 * insdel.c (count_size_as_multibyte): Check for string overflow.
6130
2b4560a8
PE
6131 * character.c (lisp_string_width): Check for string overflow.
6132 Use EMACS_INT, not int, for string indexes and lengths; in
6133 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6134 the resulting string length overflows an EMACS_INT; instead,
6135 report a string overflow if no precision given. When checking for
6136 precision exhaustion, use a check that cannot possibly have
6137 integer overflow. (Bug#8675)
6138 * character.h (lisp_string_width): Adjust to new signature.
6139
cb93f9be
PE
6140 * alloc.c (string_overflow): New function.
6141 (Fmake_string): Use it. This doesn't change behavior, but saves
6142 a few bytes and will simplify future changes.
6143 * character.c (string_escape_byte8): Likewise.
6144 * lisp.h (string_overflow): New decl.
6145
1a1f3366
PE
6146 Fixups, following up to the user-interface timestamp change.
6147 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6148 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6149 * msdos.c (mouse_get_pos): Likewise.
6150 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6151 * w32gui.h (Time): Define by including "systime.h" rather than by
6152 declaring it ourselves. (Bug#8664)
6153
d4e3e4d3
PE
6154 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6155 * image.c (clear_image_cache): Likewise.
6156
f6a24d19
PE
6157 * term.c (term_mouse_position): Don't assume time_t wraparound.
6158
08dc5ae6
PE
6159 Be more systematic about user-interface timestamps.
6160 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6161 and sometimes 'EMACS_UINT', to represent these timestamps.
6162 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6163 This makes the code easier to follow, and makes it easier to catch
6164 integer overflow bugs such as Bug#8664.
6165 * frame.c (Fmouse_position, Fmouse_pixel_position):
6166 Use Time, not unsigned long, for user-interface timestamps.
6167 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6168 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6169 * keyboard.h (last_event_timestamp): Likewise.
6170 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6171 * menu.h (xmenu_show): Likewise.
6172 * term.c (term_mouse_position): Likewise.
6173 * termhooks.h (struct input_event.timestamp): Likewise.
6174 (struct terminal.mouse_position_hook): Likewise.
6175 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6176 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6177 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6178 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6179 what it was before.
6180 * menu.h, termhooks.h: Include "systime.h", for Time.
6181
8e55734a
PE
6182 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6183 Don't assume that the difference between two unsigned long values
6184 can fit into an integer. At this point, we know button_down_time
6185 <= event->timestamp, so the difference must be nonnegative, so
6186 there's no need to cast the result if double-click-time is
6187 nonnegative, as it should be; check that it's nonnegative, just in
6188 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6189 apart (about 25 days). (Bug#8664)
8e55734a 6190
841f1b75 6191 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6192 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6193
3e26f69c
PE
6194 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6195 that always fit in int. Use a sentinel instead of a counter, to
6196 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6197 * frame.h (struct frame): Use int for menu_bar_items_used
6198 instead of EMACS_INT, since it always fits in int.
3e26f69c 6199
5cc152c0
PE
6200 * menu.c (grow_menu_items): Check for int overflow.
6201
d89eb65e
PE
6202 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6203
5235bd3e
PE
6204 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6205 Before, the code was not consistent. These values cannot exceed
6206 2**31 - 1 so there's no need to make them unsigned.
6207 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6208 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6209 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6210 as modifiers.
6211 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6212
bc827e23
PE
6213 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6214 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6215 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6216 presumably because the widths might not match.
6217
78eb494e
PE
6218 * window.c (size_window): Avoid needless test at loop start.
6219
04f2d78b
CB
62202011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6221
6222 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6223
d2fc7e3d 62242011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6225
6226 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6227
d2fc7e3d 62282011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6229
6230 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6231 `width' to `bar_area_x' and `bar_area_width', respectively.
6232 (x_scroll_run): Take account of fringe background extension.
6233
04f2d78b
CB
6234 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6235 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6236 `bar_area_width', respectively.
6237 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6238 background extension.
6239
79b70037
GM
62402011-05-10 Jim Meyering <meyering@redhat.com>
6241
6242 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6243
2f142cc5
JB
62442011-05-10 Juanma Barranquero <lekktu@gmail.com>
6245
6246 * image.c (Finit_image_library): Return t for built-in image types,
6247 like pbm and xbm. (Bug#8640)
6248
57679c86
AS
62492011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6250
6251 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6252
888c9e86
EZ
62532011-05-07 Eli Zaretskii <eliz@gnu.org>
6254
b0512a1d
EZ
6255 * w32console.c (Fset_screen_color): Doc fix.
6256 (Fget_screen_color): New function.
6257 (syms_of_ntterm): Defsubr it.
6258
7285dc67
EZ
6259 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6260 unlink the temporary file if Fcall_process didn't create it in the
6261 first place.
6262 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6263 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6264 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6265 cue to call_process_cleanup not to close that handle.
6266
4d3fcc8e
BK
62672011-05-07 Ben Key <bkey76@gmail.com>
6268
6269 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6270 one of two shell specific rules, either bootstrap-temacs-CMD or
6271 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6272 to the previous implementation of the bootstrap-temacs rule.
6273 The bootstrap-temacs-CMD rule is similar to the previous
6274 implementation of the bootstrap-temacs rule except that it
6275 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6276 variable.
6277
6278 These changes, along with some changes to nt/configure.bat,
6279 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6280 earlier fix to add support for --cflags and --ldflags options
6281 that include quotes so that it works whether make uses cmd or
6282 sh as the shell.
6283
b4289b64
MA
62842011-05-06 Michael Albinus <michael.albinus@gmx.de>
6285
6286 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6287 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6288 is a constant.
6289 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6290 a string. Handle both cases.
6291 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6292 (Fdbus_register_method): Use Qinvalid_function.
6293
af4c0e28
JB
62942011-05-06 Juanma Barranquero <lekktu@gmail.com>
6295
6296 * makefile.w32-in: Update dependencies.
6297 (LISP_H): Add inttypes.h and stdin.h.
6298 (PROCESS_H): Add unistd.h.
6299
c51453d9
EZ
63002011-05-06 Eli Zaretskii <eliz@gnu.org>
6301
6302 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6303 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6304
8ff0ac3c 63052011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6306
4c4b566b
PE
6307 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6308
aab2b9b5
PE
6309 * term.c (vfatal): Remove stray call to va_end.
6310 It's not needed and the C Standard doesn't allow it here anyway.
6311
c378da0b
PE
6312 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6313 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6314
288b08c7
PE
6315 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6316 bytes.
6317
e3601888
PE
6318 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6319
db6c0e74
PE
6320 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6321
dd5963ea
PE
6322 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6323
88c9450f
PE
6324 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6325
2f9442b8
PE
6326 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6327
c032b5f8
PE
6328 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6329 * charset.c (Fdefine_charset_internal): Don't initialize
6330 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6331 32-bit int (Bug#8600).
a108c10b
PE
6332
6333 * lread.c (read_integer): Be more consistent with string-to-number.
6334 Use string_to_number to do the actual conversion; this avoids
6335 rounding errors and fixes some other screwups. Without this fix,
6336 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6337 (digit_to_number): Move earlier, for benefit of read_integer.
6338 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6339 not a digit in any supported base. (Bug#8602)
a108c10b 6340
ad5f9eea
PE
6341 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6342
aec1708a
PE
6343 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6344 to match comment at start of function. This also removes a
6345 GCC warning about overflow in a 32+64-bit port.
6346
47be4ab5
PE
6347 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6348
371cac43
PE
6349 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6350 Reported by Stefan Monnier in
6351 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6352 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6353 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6354
d01a7826
PE
6355 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6356 (EMACS_UINTPTR): Likewise, with uintptr_t.
6357
7fd47d5c
PE
6358 * lisp.h: Prefer 64-bit EMACS_INT if available.
6359 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6360 on 32-bit hosts that have 64-bit int, so that they can access
6361 large files.
122b0c86
PE
6362 However, temporarily disable this change unless the temporary
6363 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6364
8727937b
PE
6365 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6366
8ac068ac
PE
6367 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6368 This removes an assumption that EMACS_INT and long are the same
6369 width as pointers. The assumption is true for Emacs porting targets
6370 now, but we want to make other targets possible.
6371 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6372 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6373 In the rest of the code, change types of integers that hold casted
6374 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6375 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6376 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6377 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6378 No need to cast type when ORing.
6379 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6380 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6381 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6382 assume EMACS_INT is the same width as char *.
6383 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6384 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6385 Remove no-longer-needed casts.
6386 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6387 (xg_tool_bar_help_callback, xg_make_tool_item):
6388 Use EMACS_INTPTR to hold an integer
6389 that will be cast to void *; this can avoid a GCC warning
6390 if EMACS_INT is not the same width as void *.
6391 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6392 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6393 (current_message_1, set_message_1):
6394 Use a local to convert to proper width without a cast.
6395 * xmenu.c (dialog_selection_callback): Likewise.
6396
ede49d71
PE
6397 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6398 Also, don't assume VALBITS / RAND_BITS is less than 5,
6399 and don't rely on undefined behavior when shifting a 1 left into
6400 the sign bit.
6401 * lisp.h (get_random): Change signature to match.
6402
2f30ecd0
PE
6403 * lread.c (hash_string): Use size_t, not int, for hash computation.
6404 Normally we prefer signed values; but hashing is special, because
6405 it's better to use unsigned division on hash table sizes so that
6406 the remainder is nonnegative. Also, size_t is the natural width
6407 for hashing into memory. The previous code used 'int', which doesn't
6408 retain enough info to hash well into very large tables.
6409 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6410
2a866e7b
PE
6411 * dbusbind.c: Don't possibly lose pointer info when converting.
6412 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6413 Use XPNTR rather than XHASH, so that the high-order bits of
6414 the pointer aren't lost when converting through void *.
6415
51639eac
PE
6416 * eval.c (Fautoload): Don't double-shift a pointer.
6417
92394119
PE
6418 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6419
dbdb9a7c
JB
64202011-05-06 Juanma Barranquero <lekktu@gmail.com>
6421
6422 * gnutls.c (DEF_GNUTLS_FN):
6423 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6424
db7a0b4f
AS
64252011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6426
6427 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6428 marker. (Bug#8610)
6429
cd394be1 64302011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6431
6432 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6433 New version that can reserve upto 2GB of heap space.
6434
f7ff1b0f 64352011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6436
6437 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6438
639c109b
TZ
64392011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6440
6441 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6442 `gnutls_certificate_set_x509_key_file'.
6443
d2127135
JB
64442011-05-05 Juanma Barranquero <lekktu@gmail.com>
6445
6446 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6447 Update dependencies.
6448
e968f4f3
JB
64492011-05-04 Juanma Barranquero <lekktu@gmail.com>
6450
6451 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6452 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6453 Remove unused parameter `fildes'.
6454 * process.c (read_process_output, send_process): Don't pass it.
6455
84d358f0
JB
64562011-05-04 Juanma Barranquero <lekktu@gmail.com>
6457
6458 Fix previous change: the library cache is defined in w32.c.
6459 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6460 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6461
0898ca10
JB
64622011-05-04 Juanma Barranquero <lekktu@gmail.com>
6463
6464 Implement dynamic loading of GnuTLS on Windows.
6465
6466 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6467 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6468 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6469 Declare.
6470
6471 * gnutls.c (Qgnutls_dll): Define.
6472 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6473 (gnutls_*): Declare function pointers.
6474 (init_gnutls_functions): New function to initialize function pointers.
6475 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6476 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6477 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6478 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6479 (emacs_gnutls_write, emacs_gnutls_read)
6480 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6481 (Fgnutls_available_p): New function.
6482 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6483 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6484 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6485
6486 * image.c: Include w32.h.
6487 (Vimage_type_cache): Delete.
6488 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6489 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6490 (w32_delayed_load): Move to w32.c.
6491
6492 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6493
6494 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6495 (w32_delayed_load): Move from image.c. When loading a library, record
6496 its filename in the :loaded-from property of the library id.
6497 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6498 Initialize and staticpro them.
6499 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6500
6501 * process.c: Include lisp.h before w32.h, not after.
6502 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6503 instead of gnutls_record_check_pending.
6504
6505 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6506
ff4de4aa
TZ
65072011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6508
6509 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6510 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6511 as passed in.
6512
abe95abb
JD
65132011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6514
6515 * xterm.c (x_set_frame_alpha): Do not set property on anything
6516 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6517
e16e55d4
JB
65182011-05-02 Juanma Barranquero <lekktu@gmail.com>
6519
6520 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6521
bafcf6a5
JB
65222011-05-02 Juanma Barranquero <lekktu@gmail.com>
6523
6524 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6525 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6526 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6527 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6528 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6529 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6530 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6531 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6532 (Qgnutls_bootprop_callbacks_verify): Make static.
6533
e7a6747f
AS
65342011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6535
19ed11ba
AS
6536 * callproc.c: Indentation fixup.
6537
e7a6747f 6538 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6539 (wait_for_termination, interruptible_wait_for_termination):
6540 Move after wait_for_termination_1.
e7a6747f 6541
1ef14cb4
LMI
65422011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6543
6544 * sysdep.c (interruptible_wait_for_termination): New function
6545 which is like wait_for_termination, but allows keyboard
6546 interruptions.
6547
6548 * callproc.c (Fcall_process): Add (:file "file") as an option for
6549 the STDOUT buffer.
6550 (Fcall_process_region): Ditto.
6551
330d880c
EZ
65522011-04-30 Eli Zaretskii <eliz@gnu.org>
6553
8db90b73
EZ
6554 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6555 rather than `XVECTOR (FOO)->size'.
6556
330d880c
EZ
6557 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6558 inttypes.h, as a gnulib replacement is used if it not available in
6559 system headers.
6560
15cbd324
EZ
65612011-04-21 Eli Zaretskii <eliz@gnu.org>
6562
6563 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6564 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6565 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6566
6567 * coding.c (coding_alloc_by_realloc): Error out if destination
6568 will grow beyond MOST_POSITIVE_FIXNUM.
6569 (decode_coding_emacs_mule): Abort if there isn't enough place in
6570 charbuf for the composition carryover bytes. Reserve an extra
6571 space for up to 2 characters produced in a loop.
6572 (decode_coding_iso_2022): Abort if there isn't enough place in
6573 charbuf for the composition carryover bytes.
6574
65752011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6576
ae940cca
EZ
6577 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6578 aborting when %lld or %lll format is passed.
6579 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6580 %llo or %llx format is passed. (Bug#8545)
6581
03ab8921
EZ
6582 * window.c (window_scroll_line_based): Use a marker instead of
6583 simple variables to record original value of point. (Bug#7952)
6584
afda1437
EZ
6585 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6586 produced by %s or %c overflows available buffer space. (Bug#8545)
6587
f76dee0c
PE
65882011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6589
6590 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6591 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6592
fdc5744d
JB
65932011-04-28 Juanma Barranquero <lekktu@gmail.com>
6594
6595 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6596
638f053a
JB
65972011-04-28 Juanma Barranquero <lekktu@gmail.com>
6598
6599 * keyboard.c (Qdelayed_warnings_hook): Define.
6600 (command_loop_1): Run `delayed-warnings-hook'
6601 if Vdelayed_warnings_list is non-nil.
6602 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6603 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6604
d178f871
EZ
66052011-04-28 Eli Zaretskii <eliz@gnu.org>
6606
6607 * doprnt.c (doprnt): Don't return value smaller than the buffer
6608 size if the message was truncated. (Bug#8545).
6609
b124fd93
JB
66102011-04-28 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6613 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6614
e810457d
PE
66152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6616
6617 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6618
ea51cceb
JB
66192011-04-27 Juanma Barranquero <lekktu@gmail.com>
6620
6621 * makefile.w32-in: Update dependencies.
6622
94dcfacf
EZ
66232011-04-27 Eli Zaretskii <eliz@gnu.org>
6624
6625 Improve `doprnt' and its usage. (Bug#8545)
6626 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6627 `format_end'. Remove support for %l as a conversion specifier.
6628 Don't use xrealloc. Improve diagnostics when the %l size modifier
6629 is used. Update the commentary.
6630
6631 * eval.c (verror): Simplify calculation of size_t.
6632
6633 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6634 messages.
6635
f61f41d7
PE
66362011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6637
6638 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6639 change.
6640
96fb4434
PE
66412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6642
6643 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6644 This makes this file independent of the recent pseudovector change.
6645
671875da 66462011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6647
69e9b5a3
PE
6648 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6649
b5f869a7 6650 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6651 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6652 Remove unused local.
c8926152 6653 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6654
841a1577 6655 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6656 GCC 4.6.0 optimizes based on type-based alias analysis.
6657 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6658 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6659 != &v->size, and therefore "v->size = 1; b->size = 2; return
6660 v->size;" must therefore return 1. This assumption is incorrect
6661 for Emacs, since it type-puns struct Lisp_Vector * with many other
6662 types. To fix this problem, this patch adds a new type struct
f904488f 6663 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6664 and pseudovectors, and helps optimizing compilers not get fooled
6665 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6666 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6667 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6668 the size member.
eab3844f
PE
6669 (XSETPVECTYPE): Rewrite in terms of new macro.
6670 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6671 This is a bit clearer, and further avoids the possibility of
6672 undesirable aliasing.
6673 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6674 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6675 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6676 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6677 (ASIZE): Now uses header.size rather than size.
6678 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6679 to avoid the hassle of writing XVECTOR (foo)->header.size.
6680 (struct vectorlike_header): New type.
eab3844f
PE
6681 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6682 object, to help avoid aliasing.
6683 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6684 (SUBRP): Likewise, since Lisp_Subr is a special case.
6685 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6686 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6687 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6688 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6689 changed to be "header.size" and "header.next".
6690 * buffer.h (struct buffer): Likewise.
6691 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6692 * frame.h (struct frame): Likewise.
6693 * process.h (struct Lisp_Process): Likewise.
6694 * termhooks.h (struct terminal): Likewise.
6695 * window.c (struct save_window_data, struct saved_window): Likewise.
6696 * window.h (struct window): Likewise.
6697 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6698 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6699 * buffer.c (init_buffer_once): Likewise.
6700 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6701 special case.
6702 * process.c (Fformat_network_address): Use local var for size,
6703 for brevity.
6704
0df1eac5
PE
6705 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6706
847ab9d1 6707 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6708 * data.c (atof): Remove decl; no longer used or needed.
6709 (digit_to_number): Move to lread.c.
6710 (Fstring_to_number): Use new string_to_number function, to be
6711 consistent with how the Lisp reader treats infinities and NaNs.
6712 Do not assume that floating-point numbers represent EMACS_INT
6713 without losing information; this is not true on most 64-bit hosts.
6714 Avoid double-rounding errors, by insisting on integers when
6715 parsing non-base-10 numbers, as the documentation specifies.
6716 * lisp.h (string_to_number): New decl, replacing ...
6717 (isfloat_string): Remove.
bc0a5c13 6718 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6719 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6720 appears to have been a coding error. Similarly, do not accept
6721 strings like +-1e0 as floating point numbers. Do not report
6722 overflow for integer overflows unless the base is not 10 which
6723 means we have no simple and reliable way to continue.
6724 Break out the floating-point parsing into a new
6725 function string_to_number, so that Fstring_to_number parses
6726 floating point numbers consistently with the Lisp reader.
04f2d78b 6727 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6728 (E_CHAR, EXP_INT): Remove, replacing with ...
6729 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6730 (string_to_number): New function, replacing isfloat_string.
6731 This function checks for valid syntax and produces the resulting
6732 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6733 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6734 so that overflow for non-base-10 numbers is reported only when
6735 there's no portable and simple way to convert to floating point.
452f4150 6736
67769ffc
PE
6737 * textprop.c (set_text_properties_1): Rewrite for clarity,
6738 and to avoid GCC warning about integer overflow.
6739
c20db43f
PE
6740 * intervals.h (struct interval): Use EMACS_INT for members
6741 where EMACS_UINT might cause problems. See
6742 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6743 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6744 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6745 All uses changed.
37aa2f85
PE
6746 (offset_intervals): Tell GCC not to worry about length overflow
6747 when negating a negative length.
c20db43f 6748
2538aa2f
PE
6749 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6750 (overrun_check_free): Likewise.
6751
f2d3008d
PE
6752 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6753 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6754 word size.
6755
ec8df744
PE
6756 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6757 (gnutls_make_error): Rename local to avoid shadowing.
6758 (gnutls_emacs_global_deinit): ifdef out; not used.
6759 (Fgnutls_boot): Use const for pointer to readonly storage.
6760 Comment out unused local. Fix pointer signedness problems.
6761
640ee02d
PE
6762 * lread.c (openp): Don't stuff size_t into an 'int'.
6763 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6764 about possible signed overflow.
6765
6048fb2a
PE
6766 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6767 (GDK_KEY_g): Don't define if already defined.
6768 (xg_prepare_tooltip): Avoid pointer signedness problem.
6769 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6770
fa3c87e1
PE
6771 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6772 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6773
2172544b
PE
6774 * xfns.c (Fx_window_property): Simplify a bit,
6775 to make a bit faster and to avoid GCC 4.6.0 warning.
6776 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6777
9b821a21
PE
6778 * fns.c (internal_equal): Don't assume size_t fits in int.
6779
3c616cfa
PE
6780 * alloc.c (compact_small_strings): Tighten assertion a little.
6781
c2982e87
PE
6782 Replace pEd with more-general pI, and fix some printf arg casts.
6783 * lisp.h (pI): New macro, generalizing old pEd macro to other
6784 conversion specifiers. For example, use "...%"pI"d..." rather
6785 than "...%"pEd"...".
6786 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6787 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6788 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6789 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6790 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6791 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6792 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6793 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6794 64-bit hosts.
6795 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6796 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6797 * print.c (safe_debug_print, print_object): Likewise.
6798 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6799 to int.
6f04d126
PE
6800 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6801 avoiding the 0 flag, which is not portable.
c2982e87
PE
6802 * process.c (Fmake_network_process): Use pI to avoid cast.
6803 * region-cache.c (pp_cache): Likewise.
6804 * xdisp.c (decode_mode_spec): Likewise.
6805 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6806 behavior on 64-bit hosts with printf arg.
6f04d126 6807 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6808 (x_stop_queuing_selection_requests): Likewise.
6809 (x_get_window_property): Don't truncate byte count to an 'int'
6810 when tracing.
0b432f21 6811
5e073ec7
PE
6812 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6813 here, since it parses constructs like leading '-' and spaces,
6814 which are not wanted; and it overflows with large numbers.
6815 Instead, simply match F[0-9]+, which is what is wanted anyway.
6816
36372bf9
PE
6817 * alloc.c: Remove unportable assumptions about struct layout.
6818 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6819 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6820 (allocate_vectorlike, make_pure_vector): Use the new macros,
6821 plus offsetof, to remove unportable assumptions about struct layout.
6822 These assumptions hold on all porting targets that I know of, but
6823 they are not guaranteed, they're easy to remove, and removing them
6824 makes further changes easier.
6825
0b432f21
PE
6826 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6827 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6828 (string_overrun_cookie): Now const. Use initializers that
6829 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6830 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6831 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6832 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6833 multiple of sizeof (EMACS_INT); it need not be, if
6834 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6835 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6836
895009e1
JB
68372011-04-26 Juanma Barranquero <lekktu@gmail.com>
6838
6839 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6840
6a7a1b0b
TZ
68412011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6842
6843 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6844 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6845 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6846
841a1577 68472011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6848
6849 * lisp.h (Qdebug): List symbol.
895009e1 6850 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6851 * keyboard.c (debug-on-event): New variable.
6852 (handle_user_signal): Break into debugger when debug-on-event
6853 matches the current signal symbol.
6854
f2d3ba6f
DN
68552011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6856
6857 * alloc.c (check_sblock, check_string_bytes)
6858 (check_string_free_list): Convert to standard C.
6859
42ce4c63
TZ
68602011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6861
6862 * w32.c (emacs_gnutls_push): Fix typo.
6863
825cd63c
EZ
68642011-04-25 Eli Zaretskii <eliz@gnu.org>
6865
fb11d64d
EZ
6866 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6867 "cast to pointer from integer of different size".
6868
825cd63c
EZ
6869 Improve doprnt and its use in verror. (Bug#8545)
6870 * doprnt.c (doprnt): Document the set of format control sequences
6871 supported by the function. Use SAFE_ALLOCA instead of always
6872 using `alloca'.
6873
6874 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6875 is one byte too soon. Don't use xrealloc; instead xfree and
6876 xmalloc anew.
6877
e061a11b
TZ
68782011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6879
6880 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6881 callbacks stage.
6882
6883 * gnutls.c: Renamed global_initialized to
6884 gnutls_global_initialized. Added internals for the
6885 :verify-hostname-error, :verify-error, and :verify-flags
6886 parameters of `gnutls-boot' and documented those parameters in the
6887 docstring. Start callback support.
9173deec
JB
6888 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6889 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6890 on error. Return error code.
e061a11b
TZ
6891 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6892 (emacs_gnutls_read): Likewise.
6893 (Fgnutls_boot): Return handshake error code.
6894 (emacs_gnutls_handle_error): New function.
6895 (wsaerror_to_errno): Likewise.
6896
6897 * w32.h (emacs_gnutls_pull): Add prototype.
6898 (emacs_gnutls_push): Likewise.
6899
6900 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6901 (emacs_gnutls_push): Likewise.
6902
69032011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6904
6905 * process.c (wait_reading_process_output): Check if GnuTLS
6906 buffered some data internally if no FDs are set for TLS
6907 connections.
6908
6909 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6910 (LIBS): Link to USER_LIBS.
6911 ($(BLD)/gnutls.$(0)): New target.
6912
fa6996bc
EZ
69132011-04-24 Eli Zaretskii <eliz@gnu.org>
6914
eb35682e
EZ
6915 * xdisp.c (handle_single_display_spec): Rename the
6916 display_replaced_before_p argument into display_replaced_p, to
6917 make it consistent with the commentary. Fix typos in the
6918 commentary.
6919
e2ad650c
EZ
6920 * textprop.c (syms_of_textprop): Remove dead code.
6921 (copy_text_properties): Delete obsolete commentary about an
6922 interface that was deleted long ago. Fix typos in the description
6923 of arguments.
6924
1b2de274
EZ
6925 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6926 to changes in oldXMenu/XMenu.h from 2011-04-16.
6927 <menu_help_message, prev_menu_help_message>: Constify.
6928 (IT_menu_make_room): menu->help_text is now `const char **';
6929 adjust.
6930
6931 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6932 to changes in oldXMenu/XMenu.h from 2011-04-16.
6933 (struct XMenu): Declare `help_text' `const char **'.
6934
6935 * xfaces.c <Qunspecified>: Make extern again.
6936
6937 * syntax.c: Include sys/types.h before including regex.h, as
6938 required by Posix.
6939
762b15be
EZ
6940 * doc.c (get_doc_string): Improve the format passed to `error'.
6941
6942 * doprnt.c (doprnt): Improve commentary.
6943
6944 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6945
6946 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6947 them with etags.
6948
f1052e5d
EZ
6949 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6950 changes in globals.h immediately force recompilation.
762b15be
EZ
6951 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6952 $(CURDIR)/s/ms-w32.h.
6953 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6954
fa6996bc
EZ
6955 * character.c (Fchar_direction): Function deleted.
6956 (syms_of_character): Don't defsubr it.
6957 <char-direction-table>: Deleted.
6958
e6c3da20
EZ
69592011-04-23 Eli Zaretskii <eliz@gnu.org>
6960
6961 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6962 * doprnt.c: Include limits.h.
6963 (SIZE_MAX): New macro.
04f2d78b
CB
6964 (doprnt): Return a size_t value. 2nd arg is now size_t.
6965 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6966 Improve overflow protection. Support `l' modifier for integer
6967 conversions. Support %l conversion. Don't assume an EMACS_INT
6968 argument for integer conversions and for %c.
6969
6970 * lisp.h (doprnt): Restore prototype.
6971
6972 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6973 $(SRC)/character.h.
6974
6975 * Makefile.in (base_obj): Add back doprnt.o.
6976
6977 * deps.mk (doprnt.o): Add back prerequisites.
6978 (callint.o): Depend on character.h.
6979
6980 * eval.c (internal_lisp_condition_case): Include the handler
6981 representation in the error message.
6982 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6983 when breaking from the loop.
6984
6985 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6986
6987 * callint.c (Fcall_interactively): When displaying error message
6988 about invalid control letter, pass the character's codepoint, not
6989 a pointer to its multibyte form. Improve display of the character
6990 in octal and display also its hex code.
6991
6992 * character.c (char_string): Use %x to display the (unsigned)
6993 codepoint of an invalid character, to avoid displaying a bogus
6994 negative value.
6995
6996 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6997 `error', not SYMBOL_NAME itself.
6998
6999 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7000 character arguments to `error'.
7001
7002 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7003 to `error' in error message about FINAL_CHAR argument. Make sure
7004 FINAL_CHAR is a character, and use %c when it is passed as
7005 argument to `error'.
7006
4ffd0d6b 70072011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7008
7009 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7010
7011 * w32.c: Include <time.h>.
7012 (sys_localtime): New function.
7013
4ffd0d6b 70142011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7015
7016 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7017
4ffd0d6b 7018 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7019
4ffd0d6b 70202011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7021
4ffd0d6b
GM
7022 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7023 zombies (Bug#8467).
aac0c6e3 7024
04c56954
EZ
70252011-04-19 Eli Zaretskii <eliz@gnu.org>
7026
7027 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7028 gl_state.e_property when gl_state.object is Qt.
7029
7030 * insdel.c (make_gap_larger): Remove limitation of buffer size
7031 to <= INT_MAX.
7032
16a43933
CY
70332011-04-18 Chong Yidong <cyd@stupidchicken.com>
7034
7035 * xdisp.c (lookup_glyphless_char_display)
7036 (produce_glyphless_glyph): Handle cons cell entry in
7037 glyphless-char-display.
7038 (Vglyphless_char_display): Document it.
7039
7040 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7041 glyphless-char-display.
7042
4581706e
CY
70432011-04-17 Chong Yidong <cyd@stupidchicken.com>
7044
7045 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7046
7047 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7048
7049 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7050 definition for no-X builds.
7051
4887c6e2 70522011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7053
fd35b6f9
PE
7054 Static checks with GCC 4.6.0 and non-default toolkits.
7055
5c1ccb01
PE
7056 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7057
006c5daa
PE
7058 * process.c (keyboard_bit_set): Define only if SIGIO.
7059 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7060 (send_process): Repair possible setjmp clobbering.
7061
efc736d3
PE
7062 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7063
4e2fe2e6
PE
7064 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7065
f97334a2
PE
7066 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7067
4e75f29d
PE
7068 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7069 Define only if needed.
7070
90efadd1
PE
7071 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7072 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7073 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7074
3c647824
PE
7075 * dispextern.h (struct redisplay_interface): Rename param
7076 to avoid shadowing.
e264f262 7077 * termhooks.h (struct terminal): Likewise.
761383f4 7078 * xterm.c (xembed_send_message): Likewise.
3c647824 7079
b58c5c4a
PE
7080 * insdel.c (make_gap_smaller): Define only if
7081 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7082
cad59032
PE
7083 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7084 it.
7085
c339dc2e
PE
7086 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7087 so that we aren't warned about unused symbols.
7088
91a3e27b
PE
7089 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7090
399c71d3 7091 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7092
8ffc96f5
PE
7093 * xfns.c (x_real_positions): Mark locals as initialized.
7094
eef9bc79
PE
7095 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7096
098db9dd
PE
7097 * xterm.c: Fix problems found by static analysis with other toolkits.
7098 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7099 (x_dispatch_event): Declare static if USE_GTK, and
7100 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7101 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7102 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7103 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7104 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7105
eb18f6cc
PE
7106 * xmenu.c (menu_help_callback): Pointer type fixes.
7107 Use const pointers when pointing at readonly data. Avoid pointer
7108 signedness clashes.
7109 (FALSE): Remove unused macro.
7110 (update_frame_menubar): Remove unused decl.
7111
1fe72bf8
PE
7112 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7113
60d9e1db
PE
7114 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7115 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7116 (single_menu_item): Rename local to avoid shadowing.
7117
39261c26
PE
7118 * keyboard.c (make_lispy_event): Remove unused local var.
7119
018c5e19
PE
7120 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7121 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7122
63d2b86e
PE
7123 * bitmaps: Change bitmaps from unsigned char back to the X11
7124 compatible char. Avoid the old compiler warnings about
7125 out-of-range initializers by using, for example, '\xab' rather
7126 than 0xab.
7127
aefd87e1
PE
7128 * xgselect.c (xgselect_initialize): Check vs interface
7129 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7130
bf501fb9
PE
7131 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7132
e9829fdf
PE
7133 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7134 to read-only memory.
7135
1086c095
PE
7136 * fns.c (vector): Remove; this old hack is no longer needed.
7137
2baccd04 7138 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7139 Remove unused var.
dde42981 7140 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7141
72391843 7142 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7143
436c16df 7144 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7145 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7146 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7147
92bb796d 7148 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7149 (x_term_init): Remove local to avoid shadowing.
92bb796d 7150
764430a3 7151 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7152
7153 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7154 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7155
d1dfb56c
EZ
71562011-04-16 Eli Zaretskii <eliz@gnu.org>
7157
c4354cb4
EZ
7158 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7159
d1dfb56c
EZ
7160 Fix regex.c, syntax.c and friends for buffers > 2GB.
7161 * syntax.h (struct gl_state_s): Declare character position members
7162 EMACS_INT.
7163
7164 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7165
04f2d78b
CB
7166 * textprop.c (verify_interval_modification, interval_of):
7167 Declare arguments EMACS_INT.
d1dfb56c
EZ
7168
7169 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7170 EMACS_INT.
7171
7172 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7173
7174 * indent.c (Fvertical_motion): Local variable it_start is now
7175 EMACS_INT.
7176
7177 * regex.c (re_match, re_match_2, re_match_2_internal)
7178 (bcmp_translate, regcomp, regexec, print_double_string)
7179 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7180 (re_compile_pattern, re_exec): Declare arguments and local
7181 variables `size_t' and `ssize_t' and return values `regoff_t', as
7182 appropriate.
7183 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7184 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7185 <compile_stack_type>: `size' and `avail' are now `size_t'.
7186
7187 * regex.h <regoff_t>: Use ssize_t, not int.
7188 (re_search, re_search_2, re_match, re_match_2): Arguments that
7189 specify buffer/string position and length are now ssize_t and
7190 size_t. Return type is regoff_t.
7191
613052cd
BK
71922011-04-16 Ben Key <bkey76@gmail.com>
7193
7194 * nsfont.m: Fixed bugs in ns_get_family and
7195 ns_descriptor_to_entity that were caused by using free to
7196 deallocate memory blocks that were allocated by xmalloc (via
7197 xstrdup). This caused Emacs to crash when compiled with
7198 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7199 --enable-checking=xmallocoverrun). xfree is now used to
7200 deallocate these memory blocks.
7201
4170f62f 72022011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7203
71b41406
PE
7204 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7205
9587a89d
PE
7206 emacs_write: Accept and return EMACS_INT for sizes.
7207 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7208 et seq.
7209 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7210 Accept and return EMACS_INT.
7211 (emacs_gnutls_write): Return the number of bytes written on
7212 partial writes.
7213 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7214 (emacs_read, emacs_write): Remove check for negative size, as the
7215 Emacs source code has been audited now.
9587a89d
PE
7216 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7217 (emacs_read, emacs_write): Use it.
273a5f82
PE
7218 * process.c (send_process): Adjust to the new signatures of
7219 emacs_write and emacs_gnutls_write. Do not attempt to store
7220 a byte offset into an 'int'; it might overflow.
9587a89d 7221 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7222
3e047f51
PE
7223 * sound.c: Don't assume sizes fit in 'int'.
7224 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7225 Return EMACS_INT, not int.
3e047f51 7226 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7227 Accept EMACS_INT, not int.
7228 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7229 record read return values.
7230
cc39a9db
BK
72312011-04-15 Ben Key <bkey76@gmail.com>
7232
c9d0ec6d
JB
7233 * keyboard.c (Qundefined): Don't declare static since it is used
7234 in nsfns.m.
7235 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7236 static since they are used in nsfont.m.
cc39a9db 7237
6c60eb9f
SM
72382011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7239
7240 * process.c (Qprocessp): Don't declare static.
7241 * lisp.h (Qprocessp): Declare again.
7242
7990b61a
JB
72432011-04-15 Juanma Barranquero <lekktu@gmail.com>
7244
7245 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7246
5d4cb038
PE
72472011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7248
8bd7b830 7249 Improve C-level modularity by making more things 'static'.
cd64ea1d 7250
e3b27b31
PE
7251 Don't publish debugger-only interfaces to other modules.
7252 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7253 (verify_bytepos, count_markers): Move decls to the only modules
7254 that need them.
7255 * region-cache.h (pp_cache): Likewise.
7256 * window.h (check_all_windows): Likewise.
7257 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7258
5d4cb038
PE
7259 * sysdep.c (croak): Now static, if
7260 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7261 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7262
7263 * alloc.c (refill_memory_reserve): Now static if
7264 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7265 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7266
e87b6180
PE
7267 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7268 Define only if USE_LUCID.
7269
ac64929e
PE
7270 * xrdb.c (x_customization_string, x_rm_string): Now static.
7271
6f37259d
PE
7272 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7273 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7274
1683e3ab
PE
7275 * xdisp.c (draw_row_with_mouse_face): Now static.
7276 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7277
de9c2632
PE
7278 * window.h (check_all_windows): Mark externally visible.
7279
2b96acb7
PE
7280 * window.c (window_deletion_count): Now static.
7281
7282 * undo.c: Make symbols static if they're not exported.
7283 (last_undo_buffer, last_boundary_position, pending_boundary):
7284 Now static.
7285
50436f33
PE
7286 * textprop.c (interval_insert_behind_hooks): Now static.
7287 (interval_insert_in_front_hooks): Likewise.
7288
64520e5c
PE
7289 * term.c: Make symbols static if they're not exported.
7290 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7291 (max_frame_lines, tty_set_terminal_modes):
7292 (tty_reset_terminal_modes, tty_turn_off_highlight):
7293 (get_tty_terminal): Now static.
7294 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7295 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7296 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7297 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7298 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7299
1fa53021
PE
7300 * sysdep.c: Make symbols static if they're not exported.
7301 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7302 Now static.
7303 (sigprocmask_set, full_mask): Remove; unused.
7304 (wait_debugging): Mark as visible.
7305 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7306 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7307
d4b43b22
PE
7308 * syntax.c (syntax_temp): Define only if !__GNUC__.
7309
b7c513d0
PE
7310 * sound.c (current_sound_device, current_sound): Now static.
7311
989b29ad
PE
7312 * search.c (searchbufs, searchbuf_head): Now static.
7313
13a55a78
PE
7314 * scroll.c (scroll_cost): Remove; unused.
7315 * dispextern.h (scroll_cost): Remove decl.
7316
de68a1fc
PE
7317 * region-cache.h (pp_cache): Mark as externally visible.
7318
40ccffa6
PE
7319 * process.c: Make symbols static if they're not exported.
7320 (process_tick, update_tick, create_process, chan_process):
7321 (Vprocess_alist, proc_buffered_char, datagram_access):
7322 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7323 (deactivate_process): Mark defn as static, as well as decl.
7324 * lisp.h (create_process): Remove decl.
7325 * process.h (chan_process, Vprocess_alist): Remove decls.
7326
ad64fc97
PE
7327 * print.c: Make symbols static if they're not exported.
7328 (print_depth, new_backquote_output, being_printed, print_buffer):
7329 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7330 (print_interval, print_number_index, initial_stderr_stream):
7331 Now static.
7332 * lisp.h (Fprinc): Remove decl.
7333 (debug_output_compilation_hack): Mark as externally visible.
7334
adddb265
PE
7335 * sysdep.c (croak): Move decl from here to syssignal.h.
7336 * syssignal.h (croak): Put it here, so the API can be checked when
7337 'croak' is called from dissociate_if_controlling_tty.
7338
1717ede2
PE
7339 * minibuf.c: Make symbols static if they're not exported.
7340 (minibuf_save_list, choose_minibuf_frame): Now static.
7341 * lisp.h (choose_minibuf_frame): Remove decl.
7342
fa5fb2bc
PE
7343 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7344
1e3890d1
PE
7345 * lread.c: Make symbols static if they're not exported.
7346 (read_objects, initial_obarray, oblookup_last_bucket_number):
7347 Now static.
7348 (make_symbol): Remove; unused.
7349 * lisp.h (initial_obarray, make_symbol): Remove decls.
7350
8a1414fa
PE
7351 * keyboard.c: Make symbols static if they're not exported.
7352 (single_kboard, recent_keys_index, total_keys, recent_keys):
7353 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7354 (this_single_command_key_start, echoing, last_auto_save):
7355 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7356 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7357 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7358 (Vlispy_mouse_stem, double_click_count):
7359 Now static.
7360 (force_auto_save_soon): Define only if SIGDANGER.
7361 (ignore_mouse_drag_p): Now static if
7362 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7363 (print_help): Remove; unused.
7364 (stop_character, last_timer_event): Mark as externally visible.
7365 * keyboard.h (ignore_mouse_drag_p): Declare only if
7366 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7367 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7368 * lisp.h (echoing): Remove decl.
7369 (force_auto_save_soon): Declare only if SIGDANGER.
7370 * xdisp.c (redisplay_window): Simplify code, to make it more
7371 obvious that ignore_mouse_drag_p is not accessed if !defined
7372 USE_GTK && !defined HAVE_NS.
7373
93ea6e8f
PE
7374 * intervals.c: Make symbols static if they're not exported.
7375 (merge_properties_sticky, merge_interval_right, delete_interval):
7376 Now static.
7377 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7378
77382fcc
PE
7379 * insdel.c: Make symbols static if they're not exported.
7380 However, leave prepare_to_modify_buffer alone. It's never
7381 called from outside this function, but that appears to be a bug.
7382 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7383 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7384 (adjust_after_replace_noundo): Remove; unused.
7385 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7386 (signal_before_change): Remove decls.
77382fcc 7387
9306c32e
PE
7388 * indent.c (val_compute_motion, val_vmotion): Now static.
7389
cd44d2eb
PE
7390 * image.c: Make symbols static if they're not exported.
7391 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7392 if USE_GTK.
7393 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7394 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7395
ad9a7a06
PE
7396 * fringe.c (standard_bitmaps): Now static.
7397 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7398
81626931
PE
7399 * frame.c: Make symbols static if they're not exported.
7400 (x_report_frame_params, make_terminal_frame): Now static.
7401 (get_frame_param): Now static, unless HAVE_NS.
7402 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7403 (x_get_resource_string): Remove; not used.
7404 * frame.h (make_terminal_frame, x_report_frame_params):
7405 (x_get_resource_string); Remove decls.
7406 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7407 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7408
239f9db9
PE
7409 * font.c, fontset.c: Make symbols static if they're not exported.
7410 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7411 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7412 * font.c (font_close_object): Now static.
7413 * font.h (font_close_object): Remove.
7414 * fontset.c (FONTSET_OBJLIST): Remove.
7415 (free_realized_fontset) #if-0 the body, which does nothing.
7416 (face_suitable_for_char_p): #if-0, as it's never called.
7417 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7418 * xfaces.c (face_at_string_position):
7419 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7420 since 0 is always ASCII.
7421
dfcf3579
PE
7422 * fns.c (weak_hash_tables): Now static.
7423
5045092b
PE
7424 * fileio.c: Make symbols static if they're not exported.
7425 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7426 (Vwrite_region_annotation_buffers): Now static.
7427
57a96f5c
PE
7428 * eval.c: Make symbols static if they're not exported.
7429 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7430 * lisp.h (backtrace_list): Remove decl.
7431
35f08c38
PE
7432 * emacs.c: Make symbols static if they're not exported.
7433 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7434 (fatal_error_code, fatal_error_signal_hook, standard_args):
7435 Now static.
7436 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7437 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7438 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7439 * lisp.h (fatal_error_signal_hook): Remove decl.
7440 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7441
f44bd759
PE
7442 * editfns.c: Move a (normally-unused) function to its only use.
7443 * editfns.c, lisp.h (get_operating_system_release): Remove.
7444 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7445 worth the hassle of breaking this out.
7446
b532497d
PE
7447 * xterm.c: Make symbols static if they're not exported.
7448 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7449 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7450 (x_destroy_window, x_delete_display):
7451 Now static.
7452 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7453 (x_mouse_leave): Remove; unused.
7454 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7455 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7456 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7457 Remove decls.
7458 (x_mouse_leave): Declare only if WINDOWSNT.
7459 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7460 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7461 USE_X_TOOLKIT.
7462
1675728f
PE
7463 * ftxfont.c: Make symbols static if they're not exported.
7464 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7465 HAVE_FREETYPE.
7466 * font.h (ftxfont_driver): Likewise.
7467
e4cebfca
PE
7468 * xfns.c: Make symbols static if they're not exported.
7469 (x_last_font_name, x_display_info_for_name):
7470 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7471 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7472 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7473 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7474 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7475 (last_show_tip_args): Now static.
7476 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7477 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7478 (x_screen_planes): Remove; unused.
7479 * dispextern.h (x_screen_planes): Remove decl.
7480
5bf46f05
PE
7481 * dispnew.c: Make symbols static if they're not exported.
7482 * dispextern.h (redraw_garbaged_frames, scrolling):
7483 (increment_row_positions): Remove.
7484 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7485 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7486 Now static.
7487 (redraw_garbaged_frames): Remove; unused.
7488
435f4c28
PE
7489 * xfaces.c: Make symbols static if they're not exported.
7490 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7491 Remove decls.
7492 * xterm.h (defined_color): Remove decls.
7493 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7494 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7495 (menu_face_changed_default, defined_color, free_realized_face):
7496 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7497 (ascii_face_of_lisp_face): Remove; unused.
7498
8524aef3
PE
7499 * xdisp.c: Make symbols static if they're not exported.
7500 * dispextern.h (scratch_glyph_row, window_box_edges):
7501 (glyph_to_pixel_coords, set_cursor_from_row):
7502 (get_next_display_element, set_iterator_to_next):
7503 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7504 (show_mouse_face): Remove decls
7505 * frame.h (message_buf_print): Likewise.
7506 * lisp.h (pop_message, set_message, check_point_in_composition):
7507 Likewise.
7508 * xterm.h (set_vertical_scroll_bar): Likewise.
7509 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7510 (message_buf_print, scratch_glyph_row, displayed_buffer):
7511 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7512 (get_next_display_element, show_mouse_face, window_box_edges):
7513 (frame_to_window_pixel_xy, check_point_in_composition):
7514 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7515 (glyph_to_pixel_coords): Remove; unused.
7516
16390cd2
PE
7517 * dired.c (file_name_completion): Now static.
7518
7519 * dbusbind.c (xd_in_read_queued_messages): Now static.
7520
a25f4dfa
PE
7521 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7522 * data.c (circular_list_error): Remove.
7523
14a9c8df
PE
7524 * commands.h (last_point_position, last_point_position_buffer):
7525 (last_point_position_window): Remove decls.
7526 * keyboard.c: Make these variables static.
7527
04f2d78b
CB
7528 * coding.h (coding, code_convert_region, encode_coding_gap):
7529 Remove decls.
74ab6df5
PE
7530 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7531 (iso_code_class, detect_coding, code_convert_region): Now static.
7532 (encode_coding_gap): Remove; unused.
7533
38dfbee1
PE
7534 * chartab.c (chartab_chars, chartab_bits): Now static.
7535
a2cb4e63
PE
7536 * charset.h (charset_iso_8859_1): Remove decl.
7537 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7538 Now static.
7539
127198fd
PE
7540 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7541 * ccl.c (Vccl_program_table): Now static.
7542 (check_ccl_update): Remove; unused.
7543
d85b608f
PE
7544 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7545 * category.h: ... from here.
7546 * category.c (check_category_table, set_category_set): Now static.
7547
31cd66f3
PE
7548 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7549 * lisp.h: Remove these decls.
7550
c358e587
PE
7551 * buffer.c (buffer_count): Remove unused var.
7552
e78aecca
PE
7553 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7554 so that it's not optimized away.
7555 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7556 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7557 exported only to the debugger.
7558
e192d7d3 7559 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7560 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7561
92470028
PE
7562 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7563 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7564 was inaccessible from Lisp.
7565 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7566 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7567
244ed907
PE
7568 alloc.c: Import and export fewer symbols, and remove unused items.
7569 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7570 is defined.
7571 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7572 it's not optimized away by whole-program optimization.
7573 (message_enable_multibyte, free_misc): Remove.
7574 (catchlist, handlerlist, mark_backtrace):
7575 Declare only if BYTE_MARK_STACK.
7576 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7577 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7578 (message_enable_multibyte): Remove decl.
7579 (free_misc, interval_free_list, float_block, float_block_index):
7580 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7581 (cons_free_list, last_marked_index):
7582 Now static.
7583 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7584 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7585 (mark_backtrace): Define only if BYTE_MARK_STACK.
7586 * xdisp.c (message_enable_multibyte): Now static.
7587
61c2b50e 7588 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7589 This makes it easier for human readers (and static analyzers)
7590 to see whether these variables are used from other modules.
7591 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7592 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7593 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7594 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7595 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7596 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7597 * xmenu.c, xselect.c:
7598 Declare Q* vars static if they are not used in other modules.
7599 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7600 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7601 Remove decls of unexported vars.
7602 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7603
95c82688
PE
7604 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7605
16a97296
PE
7606 Make Emacs functions such as Fatom 'static' by default.
7607 This makes it easier for human readers (and static analyzers)
7608 to see whether these functions can be called from other modules.
7609 DEFUN now defines a static function. To make the function external
7610 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7611 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7612 (Finit_image_library):
16a97296
PE
7613 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7614 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7615 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7616 Remove decls, since these functions are now static.
7617 (Funintern, Fget_internal_run_time): New decls, since these functions
7618 were already external.
95c82688 7619
16a97296
PE
7620 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7621 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7622 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7623 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7624 * keyboard.c, keymap.c, lread.c:
7625 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7626 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7627 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7628 Mark functions with DEFUE instead of DEFUN,
7629 if they are used in other modules.
7630 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7631 decls for now-static functions.
7632 * buffer.h (Fdelete_overlay): Remove decl.
7633 * callproc.c (Fgetenv_internal): Mark as internal.
7634 * composite.c (Fremove_list_of_text_properties): Remove decl.
7635 (Fcomposition_get_gstring): New forward static decl.
7636 * composite.h (Fcomposite_get_gstring): Remove decl.
7637 * dired.c (Ffile_attributes): New forward static decl.
7638 * doc.c (Fdocumntation_property): New forward static decl.
7639 * eval.c (Ffetch_bytecode): New forward static decl.
7640 (Funintern): Remove extern decl; now in .h file where it belongs.
7641 * fileio.c (Fmake_symbolic_link): New forward static decl.
7642 * image.c (Finit_image_library): New forward static decl.
7643 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7644 * intervals.h (Fprevious_property_change):
7645 (Fremove_list_of_text_properties): Remove decls.
7646 * keyboard.c (Fthis_command_keys): Remove decl.
7647 (Fcommand_execute): New forward static decl.
7648 * keymap.c (Flookup_key): New forward static decl.
7649 (Fcopy_keymap): Now static.
7650 * keymap.h (Flookup_key): Remove decl.
7651 * process.c (Fget_process): New forward static decl.
7652 (Fprocess_datagram_address): Mark as internal.
7653 * syntax.c (Fsyntax_table_p): New forward static decl.
7654 (skip_chars): Remove duplicate decl.
7655 * textprop.c (Fprevious_property_change): New forward static decl.
7656 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7657 Now internal.
7658 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7659 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7660
785bbd42
PE
7661 * editfns.c (Fformat): Remove unreachable code.
7662
8b913b57
AS
76632011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7664
7665 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7666 change. (Bug#8496)
7667
a6744a35
EZ
76682011-04-13 Eli Zaretskii <eliz@gnu.org>
7669
7670 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7671 when at ZV. (Bug#8487)
7672
e7974947
AS
76732011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7674
baad03f0
AS
7675 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7676 (Bug#8437)
7677 * keyboard.c (parse_tool_bar_item): Likewise.
7678 * sound.c (sound_cleanup, alsa_close): Likewise.
7679 * termcap.c (tgetent): Likewise.
7680 * xfns.c (x_default_font_parameter): Likewise.
7681 * xsettings.c (read_and_apply_settings): Likewise.
7682
e7974947
AS
7683 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7684 (overrun_check_free): Protoize.
7685
28272684
PE
76862011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7687
7688 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7689 since callers should never pass a negative size.
7690 Change the signature to match that of plain 'read' and 'write'; see
7691 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7692 * lisp.h: Update prototypes of emacs_write and emacs_read.
7693
11997c76
EZ
76942011-04-11 Eli Zaretskii <eliz@gnu.org>
7695
7696 * xdisp.c (redisplay_window): Don't try to determine the character
7697 position of the scroll margin if the window start point w->startp
e896f03c 7698 is outside the buffer's accessible region. (Bug#8468)
11997c76 7699
8a2cbd72
EZ
77002011-04-10 Eli Zaretskii <eliz@gnu.org>
7701
7702 Fix write-region and its subroutines for buffers > 2GB.
7703 * fileio.c (a_write, e_write): Modify declaration of arguments and
7704 local variables to support buffers larger than 2GB.
7705 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7706
7707 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7708 argument, local variables, and return value.
7709
7710 * lisp.h: Update prototypes of emacs_write and emacs_read.
7711
7712 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7713
4073e537 77142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7715
1ebfdcb6
PE
7716 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7717
b2ded58d
PE
7718 Fix more problems found by GCC 4.6.0's static checks.
7719
7d66342c
PE
7720 * xdisp.c (vmessage): Use a better test for character truncation.
7721
bbf47d44
PE
7722 * charset.c (load_charset_map): <, not <=, for optimization,
7723 and to avoid potential problems with integer overflow.
9248994d 7724 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7725 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7726 * editfns.c (Fformat): Likewise.
1e69125e 7727 * syntax.c (skip_chars): Likewise.
3befa583 7728
e3019616
PE
7729 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7730 This also lets GCC 4.6.0 generate slightly better loop code.
7731
becfa255
PE
7732 * callint.c (Fcall_interactively): <, not <=, for optimization.
7733 (Fcall_interactively): Count the number of arguments produced,
7734 not the number of arguments given. This is simpler and lets GCC
7735 4.6.0 generate slightly better code.
7736
dae0cd48
PE
7737 * ftfont.c: Distingish more carefully between FcChar8 and char.
7738 The previous code passed unsigned char * to a functions like
7739 strlen and xstrcasecmp that expect char *, which does not
7740 conform to the C standard.
7741 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7742 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7743 char * when the C standard requires it.
7744
76032d70
PE
7745 * keyboard.c (read_char): Remove unused var.
7746
eb3f1cc8
PE
7747 * eval.c: Port to Windows vsnprintf (Bug#8435).
7748 Include <limits.h>.
7749 (SIZE_MAX): Define if the headers do not.
7750 (verror): Do not give up if vsnprintf returns a negative count.
7751 Instead, grow the buffer. This ports to Windows vsnprintf, which
7752 does not conform to C99. Problem reported by Eli Zaretskii.
7753 Also, simplify the allocation scheme, by avoiding the need for
7754 calling realloc, and removing the ALLOCATED variable.
7755
70476b54
PE
7756 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7757
12020a9e
PE
7758 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7759 But keep the doprint source code for now, as we might revamp it
7760 and use it again (Bug#8435).
ea6c7ae6
PE
7761 * lisp.h (doprnt): Remove.
7762 * Makefile.in (base_obj): Remove doprnt.o.
7763 * deps.mk (doprnt.o): Remove.
7764
5fdb398c
PE
7765 error: Print 32- and 64-bit integers portably (Bug#8435).
7766 Without this change, on typical 64-bit hosts error ("...%d...", N)
7767 was used to print both 32- and 64-bit integers N, which relied on
7768 undefined behavior.
61bdb816 7769 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7770 * lisp.h (error, verror): Mark as printf-like functions.
7771 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7772 Report overflow in size calculations when allocating printf buffer.
7773 Do not truncate output string at its first null byte.
7774 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7775 Truncate the output at a character boundary, since vsnprintf does not
7776 do that.
7777 * charset.c (check_iso_charset_parameter): Convert internal
7778 character to string before calling 'error', since %c now has the
7779 printf meaning.
7780 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7781 overflow when computing char to be passed to 'error'. Do not
7782 pass Lisp_Object to 'error'; pass the integer instead.
7783 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7784 formatted with plain %d.
7785
b189fa66
PE
7786 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7787
bff87ef0
PE
7788 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7789
7e2cac20
PE
7790 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7791
ce4d90b5
PE
7792 * xterm.c (x_catch_errors): Remove duplicate declaration.
7793
266c9547
PE
7794 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7795
79c49ad2
PE
7796 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7797
368f4090
JM
77982011-04-10 Jim Meyering <meyering@redhat.com>
7799
7800 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7801 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7802 return ssize_t not "int", and use size_t as the buffer length.
7803 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7804 * gnutls.h: Update declarations.
7805 * process.c (read_process_output): Use ssize_t, to match.
7806 (send_process): Likewise.
7807
a32d4040
CY
78082011-04-09 Chong Yidong <cyd@stupidchicken.com>
7809
7810 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7811
8546720e 78122011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7813
04f2d78b
CB
7814 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7815 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7816
8546720e
GM
7817 * xterm.c (handle_one_xevent):
7818 * xmenu.c (create_and_show_popup_menu):
7819 * xselect.c (x_decline_selection_request)
7820 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7821
0a2f5c1a 78222011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7823
7824 Fix some uses of `int' instead of EMACS_INT.
7825 * search.c (string_match_1, fast_string_match)
7826 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7827 (scan_buffer, find_next_newline_no_quit)
7828 (find_before_next_newline, search_command, Freplace_match)
7829 (Fmatch_data): Make some `int' variables be EMACS_INT.
7830
7831 * xdisp.c (display_count_lines): 3rd argument and return value now
7832 EMACS_INT. All callers changed.
7833 (pint2hrstr): Last argument is now EMACS_INT.
7834
7835 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7836 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7837 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7838 (decode_coding_utf_16, decode_coding_emacs_mule)
7839 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7840 (decode_coding_ccl, decode_coding_charset)
7841 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7842 (decode_coding_iso_2022, decode_coding_emacs_mule)
7843 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7844 <char_offset, last_offset>: Declare EMACS_INT.
7845 (encode_coding_utf_8, encode_coding_utf_16)
7846 (encode_coding_emacs_mule, encode_invocation_designation)
7847 (encode_designation_at_bol, encode_coding_iso_2022)
7848 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7849 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7850 Declare EMACS_INT.
7851 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7852 (encode_invocation_designation): Last argument P_NCHARS is now
7853 EMACS_INT.
7854 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7855 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7856
7857 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7858 All users changed.
7859
7860 * ccl.c (Fccl_execute_on_string): Declare some variables
7861 EMACS_INT.
7862
8546720e 78632011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7864
7865 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7866
4e19a977
CS
78672011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7868
7869 * process.c (Fformat_network_address): Doc fix.
7870
87302331
R
78712011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7872
ee7683eb 7873 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7874
cbb59342
CY
78752011-04-08 Chong Yidong <cyd@stupidchicken.com>
7876
7877 * keyboard.c (read_char): Call Lisp function help-form-show,
7878 instead of using internal_with_output_to_temp_buffer.
7879 (Qhelp_form_show): New var.
e0d38eeb 7880 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7881
7882 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7883
7884 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7885
e67a13ab
CY
78862011-04-06 Chong Yidong <cyd@stupidchicken.com>
7887
04f2d78b
CB
7888 * process.c (Flist_processes): Remove to Lisp.
7889 (list_processes_1): Delete.
e67a13ab 7890
973f782d
EZ
78912011-04-06 Eli Zaretskii <eliz@gnu.org>
7892
7c106b1e
EZ
7893 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7894
973f782d
EZ
7895 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7896
41cf7d1a 78972011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7898
ca23cc88
PE
7899 Fix more problems found by GCC 4.6.0's static checks.
7900
f390e2d5
PE
7901 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7902
42eea0d0
PE
7903 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7904
b69769da 7905 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7906
f9541e84
PE
7907 * xdisp.c (vmessage): Mark as a printf-like function.
7908
13841b55
PE
7909 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7910
c136c10f
PE
7911 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7912
5e2d4a30
PE
7913 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7914 printf-like functions.
7915 (tiff_load): Add casts to remove these marks before passing them
7916 to system-supplied API.
7917
583f48b9
PE
7918 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7919
b25d760e
PE
7920 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7921 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7922 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7923 directly, rather than having caller test rule sign. This avoids
7924 some unnecessary tests.
7925 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7926 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7927 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7928
bc7b6697 7929 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7930 (xfont_open): Avoid unnecessary tests.
bc7b6697 7931
27ccc379
PE
7932 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7933
dcd5c89a
PE
7934 * composite.h, composite.c (composition_gstring_put_cache):
7935 Use EMACS_INT, not int, for length.
7936
b13a45c6
PE
7937 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7938 breaking out part of COMPOSITION_DECODE_RULE.
7939 (COMPOSITION_DECODE_RULE): Use it.
7940 * composite.c (get_composition_id): Remove unused local vars,
7941 by using the new macro.
7942
1e792e4d
PE
7943 * textprop.c (set_text_properties_1): Change while to do-while,
7944 since the condition is always true at first.
7945
dc6c6455 7946 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7947 (interval_deletion_adjustment): Return unsigned value.
7948 All uses changed.
dc6c6455 7949
aba7731a
PE
7950 * process.c (list_processes_1, create_pty, read_process_output):
7951 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7952 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7953 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7954 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7955 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7956
fdfc4bf3
PE
7957 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7958
fca8fe46 7959 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7960 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7961
06a0259a 7962 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7963 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7964 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7965
e7b9e80f
PE
7966 * print.c (print_error_message): Avoid int overflow.
7967
56201685
PE
7968 * font.c (font_list_entities): Redo for clarity,
7969 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7970
78834453 7971 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7972 (font_score): Avoid potential overflow in diff calculation.
78834453 7973
0bc0b309 7974 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7975 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7976
e610eaca
PE
7977 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7978
b895abce
PE
7979 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7980 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7981 can always succeed if overflow has undefined behavior.
7982
1f1d9321 7983 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7984 (wordify): Omit three unnecessary tests.
1f1d9321 7985
c59478bc
PE
7986 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7987 All callers changed. This avoids the need for an unused var.
7988
79b73827
PE
7989 * casefiddle.c (casify_region): Remove var that is set but not used.
7990
a4db5dfe
PE
7991 * dired.c (file_name_completion): Remove var that is set but not used.
7992
43aae36e
PE
7993 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7994
2a47c44d 7995 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7996 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7997
a37c69bf
PE
7998 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7999 Check for integer overflow on size calculations.
8000
328ab8e7
PE
8001 * buffer.c (Fprevious_overlay_change): Remove var that is set
8002 but not used.
8003
e5a2a5cb
PE
8004 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8005 Remove vars that are set but not used.
8d84a6eb 8006 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8007 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8008
a60e5f68
PE
8009 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8010
f661cb61 8011 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8012 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8013
f0397f5a
PE
8014 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8015 that are set but not used.
8016
8664db06 8017 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8018 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8019
6abdaa4a
PE
8020 * xselect.c (x_get_local_selection, x_handle_property_notify):
8021 Remove vars that are set but not used.
8022
0ce7538d 8023 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8024 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8025
9ae848fc
PE
8026 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8027 Remove var that is set but not used.
0b918413
PE
8028 (scroll_bar_windows_size): Now size_t, not int.
8029 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8030 Check for overflow.
9ae848fc 8031
a5a62657
PE
8032 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8033 (map_tty_color) [!defined MSDOS]: Likewise.
8034
5c5cdd39
PE
8035 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8036
66ebf983
PE
8037 * coding.c: Remove vars that are set but not used.
8038 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8039 All callers changed.
8040 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8041 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8042 (decode_coding_charset): Remove vars that are set but not used.
8043
1be4d761
PE
8044 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8045 that is set but not used.
8046
47553fa8
PE
8047 * print.c (print_object): Remove var that is set but not used.
8048
1f7196bf 8049 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8050 The gnulib version avoids calling malloc in the usual case,
8051 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8052 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8053 * filelock.c (current_lock_owner): Likewise.
8054 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8055 * sysdep.c: Include allocator.h, careadlinkat.h.
8056 (emacs_no_realloc_allocator): New static constant.
8057 (emacs_readlink): New function.
fdb61804
PE
8058 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8059 ../lib/careadlinkat.h.
d1fdcab7 8060
f84c17c7
SM
80612011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8062
8063 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8064 first non-nil return value).
8065
ef3862ad
JD
80662011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8067
8068 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8069 if not defined (Bug#8403).
8070
376a7006
JB
80712011-04-02 Juanma Barranquero <lekktu@gmail.com>
8072
8073 * xdisp.c (display_count_lines): Remove parameter `start',
8074 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8075 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8076 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8077 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8078 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8079 and thereabouts. All callers changed.
8080 (get_per_char_metric): Remove parameter `f', unused since
8081 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8082
6ca3801d
JM
80832011-04-02 Jim Meyering <meyering@redhat.com>
8084
8085 do not dereference NULL upon failed strdup
8086 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8087 (ns_get_family): Likewise.
8088
d8e2b5ba
JB
80892011-04-02 Juanma Barranquero <lekktu@gmail.com>
8090
8091 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8092
8c74fcbd
JD
80932011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8094
8095 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8096 later (Bug#8403).
8097
7200d79c
SM
80982011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8099
03408648 8100 Add lexical binding.
7200d79c 8101
03408648
SM
8102 * window.c (Ftemp_output_buffer_show): New fun.
8103 (Fsave_window_excursion):
8104 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8105
8106 * lread.c (lisp_file_lexically_bound_p): New function.
8107 (Fload): Bind Qlexical_binding.
8108 (readevalloop): Remove `evalfun' arg.
8109 Bind Qinternal_interpreter_environment.
8110 (Feval_buffer): Bind Qlexical_binding.
8111 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8112 Mark as dynamic.
8113 (syms_of_lread): Declare `lexical-binding'.
8114
8115 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8116
8117 * keyboard.c (eval_dyn): New fun.
8118 (menu_item_eval_property): Use it.
ca105506
SM
8119
8120 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8121
03408648
SM
8122 * fns.c (concat, mapcar1): Accept byte-code-functions.
8123
8124 * eval.c (Fsetq): Handle lexical vars.
8125 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8126 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8127 (FletX, Flet): Obey lexical binding.
8128 (Fcommandp): Handle closures.
8129 (Feval): New `lexical' arg.
8130 (eval_sub): New function extracted from Feval. Use it almost
8131 everywhere where Feval was used. Look up vars in lexical env.
8132 Handle closures.
8133 (Ffunctionp): Move from subr.el.
8134 (Ffuncall): Handle closures.
8135 (apply_lambda): Remove `eval_flags'.
8136 (funcall_lambda): Handle closures and new byte-code-functions.
8137 (Fspecial_variable_p): New function.
8138 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8139 but without exporting it to Lisp.
23aba0ea 8140
23aba0ea 8141 * doc.c (Fdocumentation, store_function_docstring):
03408648 8142 * data.c (Finteractive_form): Handle closures.
23aba0ea 8143
03408648
SM
8144 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8145 interactive spec.
ba83908c 8146
04f2d78b
CB
8147 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8148 New byte-codes.
03408648
SM
8149 (exec_byte_code): New function extracted from Fbyte_code to handle new
8150 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8151
03408648 8152 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8153
03408648 8154 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8155
e2abce01
JB
81562011-03-31 Juanma Barranquero <lekktu@gmail.com>
8157
8158 * xdisp.c (redisplay_internal): Fix prototype.
8159
63696a73 81602011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8161
63696a73 8162 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8163 (try_scrolling): Use it when setting scroll_limit.
8164 Limit scrolling to 100 screen lines.
63696a73
EZ
8165 (redisplay_window): Even when falling back on "recentering",
8166 position point in the window according to scroll-conservatively,
8167 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8168
8169 (try_scrolling): When point is above the window, allow searching
8170 as far as scroll_max, or one screenful, to compute vertical
8171 distance from PT to the scroll margin position. This prevents
8172 try_scrolling from unnecessarily failing when
8173 scroll-conservatively is set to a value slightly larger than the
8174 window height. Clean up the case of PT below the margin at bottom
8175 of window: scroll_max can no longer be INT_MAX. When aggressive
8176 scrolling is in use, don't let point enter the opposite scroll
8177 margin as result of the scroll.
8178 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8179 threshold of 100 lines for never-recentering scrolling.
8180
e4cc2dfc
JB
81812011-03-31 Juanma Barranquero <lekktu@gmail.com>
8182
8183 * dispextern.h (move_it_by_lines):
8184 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8185 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8186 (message_log_check_duplicate): Remove parameters `prev_bol' and
8187 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8188 (redisplay_internal): Remove parameter `preserve_echo_area',
8189 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8190
8191 * indent.c (Fvertical_motion):
8192 * window.c (window_scroll_pixel_based, Frecenter):
8193 Don't pass `need_y_p' to `move_it_by_lines'.
8194
1c470562
SM
81952011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8196
44f230aa
SM
8197 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8198 steal a few bits to be more compact.
8199 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8200 Remove unneeded casts.
8201
1c470562
SM
8202 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8203
888adce9
ZK
82042011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8205
8206 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8207 binding" message (bug#7967).
8208
f838ed7b
PE
82092011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8210
77861b95
PE
8211 Fix more problems found by GCC 4.6.0's static checks.
8212
de6dbc14
PE
8213 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8214 Remove unused local var.
8215
f838ed7b
PE
8216 * editfns.c (Fmessage_box): Remove unused local var.
8217
792c7b2b
PE
8218 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8219 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8220 Omit unused local vars.
c499e557 8221 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8222 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8223 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8224 Omit unused local var.
8225
ba0165e1
PE
8226 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8227 Don't assume string length fits in int.
32ad8845 8228 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8229 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8230
3c59b4c9
PE
8231 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8232 instead of alloca (Bug#8344).
8233
a3eed478 8234 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8235 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8236
eb4d412d
PE
8237 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8238
1658b401
PE
8239 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8240 concerns.
8241
8242 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8243
8244 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8245
9a2c6e05
PE
8246 * keyboard.c (syms_of_keyboard): Use the same style as later
8247 in this function when indexing through an array. This also
8248 works around GCC bug 48267.
8249
03d0a109
PE
8250 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8251
44f730c8
PE
8252 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8253
fe75f926
PE
8254 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8255 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8256
ffa8c828
PE
8257 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8258 This avoids undefined behavior on integer overflow, and is a bit
8259 more convenient anyway since it is compared to a size_t variable.
8260
c5101a77
PE
8261 Variadic C functions now count arguments with size_t, not int.
8262 This avoids an unnecessary limitation on 64-bit machines, which
8263 caused (substring ...) to crash on large vectors (Bug#8344).
8264 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8265 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8266 All variadic functions and their callers changed accordingly.
c5101a77
PE
8267 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8268 * data.c (arith_driver, float_arith_driver): Likewise.
8269 * editfns.c (general_insert_function): Likewise.
8270 * eval.c (struct backtrace.nargs, interactive_p)
8271 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8272 (funcall_lambda, mark_backtrace): Likewise.
8273 * fns.c (concat): Likewise.
8274 * frame.c (x_set_frame_parameters): Likewise.
8275 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8276 0 if not found, not -1. All callers changed.
8277
dd3f25f7
PE
8278 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8279 (stack_copy_size): Now size_t, not int.
8280 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8281
461c2ab9
JB
82822011-03-28 Juanma Barranquero <lekktu@gmail.com>
8283
8284 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8285 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8286 All callers changed.
8287
8288 * lisp.h (multibyte_char_to_unibyte):
8289 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8290 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8291 * character.h (CHAR_TO_BYTE8):
8292 * cmds.c (internal_self_insert):
8293 * editfns.c (general_insert_function):
8294 * keymap.c (push_key_description):
8295 * search.c (Freplace_match):
8296 * xdisp.c (message_dolog, set_message_1): All callers changed.
8297
f6d62986
SM
82982011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8299
8300 * keyboard.c (safe_run_hook_funcall): New function.
8301 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8302 don't set the hook to nil, but remove the offending function instead.
8303 (Qcommand_hook_internal): Remove, unused.
8304 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8305 Vcommand_hook_internal.
8306
8307 * eval.c (enum run_hooks_condition): Remove.
8308 (funcall_nil, funcall_not): New functions.
8309 (run_hook_with_args): Call each function through a `funcall' argument.
8310 Remove `cond' argument, now redundant.
8311 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8312 (Frun_hook_with_args_until_failure): Adjust accordingly.
8313 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8314
1db5b1ad
JB
83152011-03-28 Juanma Barranquero <lekktu@gmail.com>
8316
8317 * dispextern.h (string_buffer_position): Remove declaration.
8318
8319 * print.c (strout): Remove parameter `multibyte', unused since
8320 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8321
8322 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8323 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8324 All callers changed.
8325
8326 * w32.c (_wsa_errlist): Use braces for struct initializers.
8327
8328 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8329 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8330 All callers changed.
8331 (string_buffer_position): Likewise. Also, make static (it's never
8332 used outside xdisp.c).
8333 (cursor_row_p): Remove parameter `w', unused since
8334 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8335 (decode_mode_spec): Remove parameter `precision', introduced during
8336 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8337 All callers changed.
8338
5ffb62aa
JD
83392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8340
8341 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8342
461c2ab9 83432011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8344
8345 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8346 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8347 (ns_update_auto_hide_menu_bar): New functions.
8348 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8349 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8350 ns_constrain_all_frames.
8351 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8352 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8353
5c380ffb
JD
83542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8355
8356 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8357
9af30bdf
GM
83582011-03-27 Glenn Morris <rgm@gnu.org>
8359
8360 * syssignal.h: Replace RETSIGTYPE with void.
8361 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8362 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8363 Replace SIGTYPE with void everywhere.
8364 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8365 * s/template.h (SIGTYPE): Remove commented out definition.
8366
e2abce01
JB
83672011-03-26 Eli Zaretskii <eliz@gnu.org>
8368
8369 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8370 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8371
f868cd8a
JB
83722011-03-26 Juanma Barranquero <lekktu@gmail.com>
8373
59eb0929
JB
8374 * w32.c (read_unc_volume): Use parameter `henum', instead of
8375 global variable `wget_enum_handle'.
8376
8377 * keymap.c (describe_vector): Remove parameters `indices' and
8378 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8379 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8380
f868cd8a
JB
8381 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8382
8383 * keyboard.c (timer_check): Remove parameter `do_it_now',
8384 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8385 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8386 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8387
8388 * keyboard.c (read_char):
8389 * w32menu.c (w32_menu_display_help):
8390 * xmenu.c (show_help_event, menu_help_callback):
8391 Adjust calls to `show_help_echo'.
8392
8393 * gtkutil.c (xg_maybe_add_timer):
8394 * keyboard.c (readable_events):
8395 * process.c (wait_reading_process_output):
8396 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8397
8398 * insdel.c (adjust_markers_gap_motion):
8399 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8400 (gap_left, gap_right): Don't call it.
8401
2ecf6fdb
CY
84022011-03-25 Chong Yidong <cyd@stupidchicken.com>
8403
8404 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8405 incurred during fontification.
8406
6b1f9ba4
JB
84072011-03-25 Juanma Barranquero <lekktu@gmail.com>
8408
8409 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8410 (DEFVAR_PER_BUFFER): Don't pass it.
8411
8412 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8413 (scrolling_window): Don't pass it.
8414
0f4a96b5
JB
84152011-03-25 Juanma Barranquero <lekktu@gmail.com>
8416
8417 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8418
8419 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8420 and `suffix'.
8421 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8422 of variables specific to SELinux and computation of `encoded_absname'.
8423
8424 * image.c (XPutPixel): Remove unused variable `height'.
8425
8426 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8427
8428 * unexw32.c (get_section_info): Remove unused variable `section'.
8429
8430 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8431 (system_process_attributes): Remove unused variable `sess'.
8432 (sys_read): Remove unused variable `err'.
8433
8434 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8435 (w32_wnd_proc): Remove unused variable `isdead'.
8436 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8437 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8438 (x_create_tip_frame): Remove unused variable `tem'.
8439
8440 * w32inevt.c (w32_console_read_socket):
8441 Remove unused variable `no_events'.
8442
8443 * w32term.c (x_draw_composite_glyph_string_foreground):
8444 Remove unused variable `width'.
8445
1149507c
JB
84462011-03-24 Juanma Barranquero <lekktu@gmail.com>
8447
8448 * w32term.c (x_set_glyph_string_clipping):
8449 Don't pass uninitialized region to CombineRgn.
8450
9c88f339
JB
84512011-03-23 Juanma Barranquero <lekktu@gmail.com>
8452
8453 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8454 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8455 (Fx_close_connection): Remove unused variable `i'.
8456
8457 * w32font.c (w32font_draw): Return number of glyphs.
8458 (w32font_open_internal): Remove unused variable `i'.
8459 (w32font_driver): Add missing initializer.
8460
8461 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8462 (fill_in_menu): Remove unused variable `items_added'.
8463
8464 * w32term.c (last_mouse_press_frame): Remove static global variable.
8465 (w32_clip_to_row): Remove unused variable `f'.
8466 (x_delete_terminal): Remove unused variable `i'.
8467
8468 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8469 (NOTHING): Remove unused static global variable.
8470 (uniscribe_check_otf): Remove unused variable `table'.
8471 (uniscribe_font_driver): Add missing initializers.
8472
dee091a3
JD
84732011-03-23 Julien Danjou <julien@danjou.info>
8474
8475 * term.c (Fsuspend_tty, Fresume_tty):
8476 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8477 * window.c (temp_output_buffer_show):
8478 * insdel.c (signal_before_change):
8479 * frame.c (Fhandle_switch_frame):
8480 * fileio.c (Fdo_auto_save):
8481 * emacs.c (Fkill_emacs):
8482 * editfns.c (save_excursion_restore):
8483 * cmds.c (internal_self_insert):
8484 * callint.c (Fcall_interactively):
8485 * buffer.c (Fkill_all_local_variables):
8486 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8487 Use Frun_hooks.
0f4a96b5 8488 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8489 unconditionally since it does the check itself.
dee091a3 8490
2c520ab5 84912011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8492
c9c49752
PE
8493 Fix more problems found by GCC 4.5.2's static checks.
8494
8abc3f12
PE
8495 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8496 the first time through the loop, since we know p0 < p1 then.
8497 This also avoids a gcc -Wstrict-overflow warning.
8498
a2d26660
PE
8499 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8500 leading to a memory leak, possible in functions like
8501 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8502 of objects (Bug#8318).
a2d26660 8503
916c72e9
PE
8504 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8505 that could (at least in theory) be that large.
8506
19ab8a18
PE
8507 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8508 This is less likely to overflow, and avoids undefined behavior if
8509 overflow does occur. All callers changed. Use strtoul to scan
8510 for the unsigned long integer.
b7cbbd6f
PE
8511 (pint2hrstr): Simplify and tune code slightly.
8512 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8513
f0641eff
PE
8514 * scroll.c (do_scrolling): Work around GCC bug 48228.
8515 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8516
7f650bb9
PE
8517 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8518 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8519 (validate_x_resource_name): Simplify count usage.
8520 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8521
37dd57d1
PE
8522 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8523 fail (Bug#8306).
81e56e61 8524
699979fc 8525 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8526
401bf9b4
PE
8527 * process.c (Fmake_network_process): Use socklen_t, not int,
8528 where POSIX says socklen_t is required in portable programs.
8529 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8530 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8531 (Fmake_network_process, server_accept_connection):
8532 (wait_reading_process_output, read_process_output):
8533 Likewise.
8534
b93aacde
PE
8535 * process.c: Rename or move locals to avoid shadowing.
8536 (list_processes_1, Fmake_network_process):
8537 (read_process_output_error_handler, exec_sentinel_error_handler):
8538 Rename or move locals.
4dc343ee 8539 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8540 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8541 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8542 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8543 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8544
af8a867c 8545 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8546 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8547 Include tparam.h instead, since it declares them.
af8a867c
PE
8548 * cm.h (PC): Remove extern decl; tparam.h now does this.
8549 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8550 * terminfo.c: Include tparam.h, to check interfaces.
8551 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8552 (tparam): Adjust signature to match interface in tparam.h;
8553 this removes some undefined behavior. Check that outstring and len
8554 are zero, which they always are with Emacs.
8555 * tparam.h (PC, BC, UP): New extern decls.
8556
0248044d 8557 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8558 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8559
8ff096c1 8560 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8561 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8562 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8563 (ftfont_list): Remove unused local.
49eaafba
PE
8564 (get_adstyle_property, ftfont_pattern_entity):
8565 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8566 Rename locals to avoid shadowing.
8ff096c1 8567
e2be39f6
PE
8568 * xfont.c (xfont_list_family): Mark var as initialized.
8569
c9735e30
PE
8570 * xml.c (make_dom): Now static.
8571
8f5201ae
PE
8572 * composite.c (composition_compute_stop_pos): Rename local to
8573 avoid shadowing.
b246f932
PE
8574 (composition_reseat_it): Remove unused locals.
8575 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8576 (composition_update_it): Mark var as initialized.
11b61122
PE
8577 (find_automatic_composition): Mark vars as initialized,
8578 with a FIXME (Bug#8290).
8f5201ae 8579
760fbc2c
PE
8580 character.h: Rename locals to avoid shadowing.
8581 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8582 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8583 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8584 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8585 to avoid shadowing.
8586
ff08eb85
PE
8587 * textprop.c (property_change_between_p): Remove; unused.
8588
fc7bf025
PE
8589 * intervals.c (interval_start_pos): Now static.
8590
235d7abc
PE
8591 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8592
44f230aa
SM
8593 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8594 Rename locals to avoid shadowing.
3e7d6594 8595
50060332
PE
8596 * sound.c (wav_play, au_play, Fplay_sound_internal):
8597 Fix pointer signedness.
d01f234b 8598 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8599 (wav_play): Initialize a variable to 0, to prevent undefined
8600 behavior (Bug#8278).
50060332 8601
c4fc4e30
PE
8602 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8603
918436ed
PE
8604 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8605
c939f91b
PE
8606 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8607 clobbering (Bug#8298).
b9c7f648
PE
8608 * sysdep.c (sys_subshell): Likewise.
8609 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8610
6bd8c144
PE
8611 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8612 This should get cleaned up, so that child_setup has the
8613 same signature on all platforms.
8614
7710357c 8615 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8616 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8617
c59da222
CY
86182011-03-22 Chong Yidong <cyd@stupidchicken.com>
8619
8620 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8621 not to be necessary, and produces flickering.
8622
66b87493
GM
86232011-03-20 Glenn Morris <rgm@gnu.org>
8624
8625 * config.in: Remove file.
8626
45b6f6d5
JB
86272011-03-20 Juanma Barranquero <lekktu@gmail.com>
8628
8629 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8630 are now in src/globals.h.
8631 (syms_of_minibuf): Remove spurious & from previous change.
8632
cd394be1 86332011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8634
8635 * minibuf.c (completing-read-function): New variable.
8636 (completing-read-default): Rename from completing-read.
8637 (completing-read): Call completing-read-function.
8638
b14e3e21
CY
86392011-03-19 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * xfaces.c (Fx_load_color_file):
8642 Read color file from absolute filename (bug#8250).
8643
f2b726e6
JB
86442011-03-19 Juanma Barranquero <lekktu@gmail.com>
8645
8646 * makefile.w32-in: Update dependencies.
8647
09f6ff02
EZ
86482011-03-17 Eli Zaretskii <eliz@gnu.org>
8649
8650 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8651
29a6015a
PE
86522011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8653
a3a6c54e
PE
8654 Fix more problems found by GCC 4.5.2's static checks.
8655
b766f867
PE
8656 * process.c (make_serial_process_unwind, send_process_trap):
8657 (sigchld_handler): Now static.
8658
be02381c
PE
8659 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8660 That way, the code declares only the vars that it needs.
8661 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8662 * s/cygwin.h (PTY_ITERATION): Likewise.
8663 * s/darwin.h (PTY_ITERATION): Likewise.
8664 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8665
57048744
PE
8666 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8667 * process.c (allocate_pty): Don't declare stb unless it's needed.
8668
7914961c 8669 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8670 (CONSTANTLIM): Remove; unused.
8671 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8672 Define only if needed.
7914961c 8673
b3967b18
PE
8674 * unexelf.c (unexec): Name an expression,
8675 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8676 Use a different way to cause a compilation error if anyone uses
8677 n rather than nn, a way that does not involve shadowing.
73366a00 8678 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8679
29a6015a
PE
8680 * deps.mk (unexalpha.o): Remove; unused.
8681
43cfc33e 8682 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8683 * unexec.h: New file.
ce701a33
PE
8684 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8685 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8686 Depend on unexec.h.
8687 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8688 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8689 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8690 Change as necessary to match prototype in unexec.h.
ce701a33 8691
01f44d5a
PE
8692 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8693 shadowing.
4f63c6bb 8694 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8695
a6670b0b
PE
8696 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8697 Rename locals to avoid shadowing.
8698
cef2010d 8699 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8700 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8701
d4d7173a
PE
8702 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8703
f08b802a
PE
8704 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8705 warning when compiling print.c.
8706
3ddb0639
PE
8707 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8708 instead of using an uninitialized var.
5ad03b97 8709 (font_sort_entities): Mark var as initialized.
3ddb0639 8710
170a2692
PE
8711 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8712
e663c700
PE
8713 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8714 pointers to constants.
89bc529a 8715 (font_parse_fcname): Remove unused vars.
7b81e2d0 8716 (font_delete_unmatched): Now static.
ea838e10 8717 (font_get_spec): Remove; unused.
13a547c6
PE
8718 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8719 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8720 Rename or move locals to avoid shadowing.
e663c700 8721
2a80c887 8722 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8723 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8724
1384fa33 8725 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8726 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8727
8b2c52e9
PE
8728 * alloc.c (mark_backtrace): Move decl from here ...
8729 * lisp.h: ... to here, so that it can be checked.
8730
475545b5 8731 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8732 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8733 (lisp_indirect_variable): Name an expression,
8734 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8735 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8736
b1349114 8737 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8738 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8739 Use const pointer when appropriate.
b1349114 8740
a2928364
PE
8741 * lisp.h (get_system_name, get_operating_system_release):
8742 Move decls here, to check interfaces.
8743 * process.c (get_operating_system_release): Move decl to lisp.h.
8744 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8745 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8746 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8747 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8748 (Fformat_time_string, Fencode_time, Finsert_char):
8749 (Ftranslate_region_internal, Fformat):
8750 Rename or remove local vars to avoid shadowing.
9710023e 8751 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8752
a415e694
PE
8753 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8754 avoid shadowing.
8755
8ef4622d
PE
8756 * lisp.h (eassert): Check that the argument compiles, even if
8757 ENABLE_CHECKING is not defined.
8758
946f9a5b
PE
8759 * data.c (Findirect_variable): Name an expression, to avoid
8760 gcc -Wbad-function-cast warning.
112396d6 8761 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8762 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8763 (Fmake_variable_buffer_local, Fmake_local_variable):
8764 Mark variables as initialized.
52746918 8765 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8766
e5aab7e7 8767 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8768 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8769 Rename locals to avoid shadowing.
dff45157
PE
8770 (mark_stack): Move local variables into the #ifdef region where
8771 they're used.
7bc26fdb
PE
8772 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8773 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8774 needed otherwise.
8775 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8776 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8777 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8778
e5aab7e7
PE
8779 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8780 avoids undefined behavior in theory.
8781
4da60324
PE
8782 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8783
88043301
PE
8784 Use functions, not macros, for up- and down-casing (Bug#8254).
8785 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8786 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8787 to use the following functions instead of these macros.
8788 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8789 EMACS_INT, since callers assume the returned value fits in int.
8790 (upcase1): Likewise, for UPCASE_TABLE.
8791 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8792 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8793 the race-condition problem in the old DOWNCASE.
88043301 8794
19ed5445
PE
8795 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8796 Rename locals to avoid shadowing.
8797 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8798 (regex_compile, re_search_2, re_match_2_internal):
8799 Remove unused local vars.
952db0d7
PE
8800 (FREE_VAR): Rewrite so as not to use empty "else",
8801 which gcc can warn about.
da053e48 8802 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8803 (RETALLOC_IF): Define only if needed.
8804 (WORDCHAR_P): Likewise. This one is never needed, but is used
8805 only in a comment talking about a compiler bug, so put inside
8806 the #if 0 of that comment.
8807 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8808 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8809 Remove; unused.
19ed5445 8810
1f3561e4 8811 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8812 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8813 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8814
ded6f8f7
PE
8815 * search.c (simple_search): Remove unused var.
8816
dbd37a95
PE
8817 * dired.c (compile_pattern): Move decl from here ...
8818 * lisp.h: ... to here, so that it can be checked.
8819 (struct re_registers): New forward decl.
8820
7e47afad
PE
8821 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8822
85f24f61
PE
8823 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8824 All uses changed.
8825 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8826 Rename locals to avoid shadowing.
5671df8f 8827 (Fvertical_motion): Mark locals as initialized.
85f24f61 8828
181aa2be 8829 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8830 (casify_region): Mark local as initialized.
181aa2be 8831
930d429c
PE
8832 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8833
7082eac6
PE
8834 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8835 New macros, so that the caller can use some names other than
8836 gcpro1, gcpro2, etc.
8837 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8838 of the new macros.
8839 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8840 argument, for consistency with GCPRO2_VAR, etc: it is now the
8841 prefix of the variable, not the variable itself. All uses
8842 changed.
38b2c076
PE
8843 * dired.c (directory_files_internal, file_name_completion):
8844 Rename locals to avoid shadowing.
8845
15206ed9
PE
8846 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8847 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8848 dired.c's scmp function, had undefined behavior.
8849 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8850 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8851 * buffer.h: ... to here, because these macros use current_buffer,
8852 and the new implementation with inline functions needs to have
8853 current_buffer in scope now, rather than later when the macros
8854 are used.
8855 (downcase, upcase1): New static inline functions.
8856 (DOWNCASE, UPCASE1): Reimplement using these functions.
8857 This avoids undefined behavior in expressions like
8858 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8859 from race conditions in accessing the global variables
8860 case_temp1 and case_temp2.
8861 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8862 * lisp.h (case_temp1, case_temp2): Remove their decls.
8863 * character.h (ASCII_CHAR_P): Move from here ...
8864 * lisp.h: ... to here, so that the inline functions mentioned
8865 above can use them.
8866
4a6bea26
PE
8867 * dired.c (directory_files_internal_unwind): Now static.
8868
f14b7e14
PE
8869 * fileio.c (file_name_as_directory, directory_file_name):
8870 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8871 Now static.
2893f146
PE
8872 (file_name_as_directory): Use const pointers when appropriate.
8873 (Fexpand_file_name): Likewise. In particular, newdir might
8874 point at constant storage, so make it a const pointer.
fd4ead52 8875 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8876 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8877 signedness issues.
f839df0c
PE
8878 (Fset_file_times, Finsert_file_contents, auto_save_error):
8879 Rename locals to avoid shadowing.
f14b7e14 8880
5716756e 8881 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8882 (Ftry_completion, Fall_completions): Rename or remove locals
8883 to avoid shadowing.
5716756e 8884
b4c3046a
PE
8885 * marker.c (bytepos_to_charpos): Remove; unused.
8886
b45db522
PE
8887 * lisp.h (verify_bytepos, count_markers): New decls,
8888 so that gcc does not warn that these functions aren't declared.
8889
85876d07
PE
8890 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8891 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8892 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8893 (copy_text): Remove unused local var.
85876d07 8894
03d78a21 8895 * filelock.c (within_one_second): Now static.
b3dd38ab 8896 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8897
5df8f01b
PE
8898 * buffer.c (fix_overlays_before): Mark locals as initialized.
8899 (fix_start_end_in_overlays): Likewise. This function should be
8900 simplified by using pointers-to-pointers, but that's a different
8901 matter.
b1d876f1 8902 (switch_to_buffer_1): Now static.
8f54f30a
PE
8903 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8904 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8905
a70072c9 8906 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8907 Fix pointer signedness issue.
edced198
PE
8908 (sys_subshell): Mark local as volatile if checking for lint,
8909 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8910 (MAXPATHLEN): Define only if needed.
a70072c9 8911
a0977c44
PE
8912 * process.c (serial_open, serial_configure): Move decls from here ...
8913 * systty.h: ... to here, so that they can be checked.
8914
a884fdcc
PE
8915 * fns.c (get_random, seed_random): Move extern decls from here ...
8916 * lisp.h: ... to here, so that they can be checked.
8917
604efe86 8918 * sysdep.c (reset_io): Now static.
b8950c94 8919 (wait_for_termination_signal): Remove; unused.
604efe86 8920
38fc62d9
PE
8921 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8922 (copy_keymap_item, append_key, push_text_char_description):
8923 Now static.
1004a21a 8924 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8925 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8926 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8927 (describe_map_tree):
8928 Rename locals to avoid shadowing.
38fc62d9 8929
2f2650da
PE
8930 * keyboard.c: Declare functions static if they are not used elsewhere.
8931 (echo_char, echo_dash, cmd_error, top_level_2):
8932 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8933 (read_char, kbd_buffer_get_event, make_lispy_position):
8934 (make_lispy_event, make_lispy_movement, apply_modifiers):
8935 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8936 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8937 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8938 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8939 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8940
a053e86c 8941 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8942 (mark_kboards): Move decl here ...
8943 * alloc.c (mark_kboards): ... from here.
a053e86c 8944
4752793e
PE
8945 * lisp.h (force_auto_save_soon): New decl.
8946
74f10ca7 8947 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8948 (DEFINE_DUMMY_FUNCTION): New macro.
8949 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8950 Use it.
c03cd23f
PE
8951 (main): Add casts to avoid warnings
8952 if GCC considers string literals to be constants.
74f10ca7 8953
022e70d4
PE
8954 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8955
59d6fe83
PE
8956 * dbusbind.c: Pointer signedness fixes.
8957 (xd_signature, xd_append_arg, xd_initialize):
8958 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8959 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8960 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8961 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8962
78320123
PE
8963 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8964 if GCC considers string literals to be constants.
49cebcca 8965 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8966
35ac2a97
SM
89672011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8968
fb103ca9
SM
8969 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8970 (print_preprocess, print_object): New macro to fix last change.
8971
35ac2a97
SM
8972 * print.c (print_preprocess): Don't forget font objects.
8973
62973b41
JB
89742011-03-16 Juanma Barranquero <lekktu@gmail.com>
8975
8976 * emacs.c (USAGE3): Doc fixes.
8977
0e48bb22
AS
89782011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8979
8980 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8981 structure.
8982
7684e57b
JB
89832011-03-14 Juanma Barranquero <lekktu@gmail.com>
8984
8985 * lisp.h (VWindow_system, Qfile_name_history):
8986 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8987 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8988 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8989
8990 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8991 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8992
8993 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8994 * w32console.c (detect_input_pending, read_input_pending)
8995 (encode_terminal_code):
8996 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8997 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8998 (w32_system_caret_y, Qfile_name_history):
8999 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9000 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9001 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9002 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9003 * w32proc.c (Qlocal, report_file_error):
9004 * w32term.c (Vwindow_system, updating_frame):
9005 * w32uniscribe.c (initialized, uniscribe_font_driver):
9006 Remove unneeded extern declarations.
9007
2aa46d6c
CY
90082011-03-14 Chong Yidong <cyd@stupidchicken.com>
9009
c96bbc66 9010 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9011
cffc6f3b
CY
90122011-03-13 Chong Yidong <cyd@stupidchicken.com>
9013
9014 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9015 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9016 These macros can no longer be used for assignment.
9017
44f230aa
SM
9018 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9019 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9020 (record_buffer_markers, fetch_buffer_markers): New functions for
9021 recording and fetching special buffer markers.
9022 (set_buffer_internal_1, set_buffer_temp): Use them.
9023
9024 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9025
9026 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9027
9028 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9029 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9030
9031 * xdisp.c (hscroll_window_tree):
9032 (reconsider_clip_changes): Use PT instead of BUF_PT.
9033
d251f04b
EZ
90342011-03-13 Eli Zaretskii <eliz@gnu.org>
9035
9036 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9037 $(EMACS_ROOT)/lib/intprops.h.
9038
f0c77cd1
PE
90392011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9040
3eca4629
PE
9041 Fix more problems found by GCC 4.5.2's static checks.
9042
7c86ee98
PE
9043 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9044 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9045 (xg_free_frame_widgets): Make it clear that a local variable is
9046 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9047 (gdk_window_get_screen): Make it clear that this macro is needed
9048 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9049 (int_gtk_range_get_value): New function, which avoids a diagnostic
9050 from gcc -Wbad-function-cast.
9051 (xg_set_toolkit_scroll_bar_thumb): Use it.
9052 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9053 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9054 (get_utf8_string, xg_get_file_with_chooser):
9055 Rename locals to avoid shadowing.
9056 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9057
41729b81
PE
9058 * xgselect.c (xg_select): Remove unused var.
9059
f0c77cd1
PE
9060 * image.c (four_corners_best): Mark locals as initialized.
9061 (gif_load): Initialize transparent_p to zero (Bug#8238).
9062 Mark another local as initialized.
ec6cf4c6 9063 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9064
ce0ad53d 9065 * image.c (clear_image_cache): Now static.
d5d5a617 9066 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9067 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9068 (x_edge_detection): Remove unnecessary cast that
9069 gcc -Wbad-function-cast diagnoses.
2037898d 9070 (gif_load): Fix pointer signedness.
6ae141d6
PE
9071 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9072 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9073
33383987 90742011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9075
d32df629
PE
9076 Improve quality of tests for time stamp overflow.
9077 For example, without this patch (encode-time 0 0 0 1 1
9078 1152921504606846976) returns the obviously-bogus value (-948597
9079 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9080 reports time overflow. See
9081 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9082 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9083 * editfns.c: Include limits.h and intprops.h.
9084 (TIME_T_MIN, TIME_T_MAX): New macros.
9085 (time_overflow): Move earlier, to before first use.
9086 (hi_time, lo_time): New functions, for an accurate test for
9087 out-of-range times.
9088 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9089 (Fget_internal_run_time): Don't assume time_t fits in int.
9090 (make_time): Use list2 instead of Fcons twice.
9091 (Fdecode_time): More accurate test for out-of-range times.
9092 (check_tm_member): New function.
9093 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9094 (lisp_time_argument): Don't rely on undefined left-shift and
9095 right-shift behavior when checking for time stamp overflow.
8be6f318 9096
fe31d94c
PE
9097 * editfns.c (time_overflow): New function, refactoring common code.
9098 (Fformat_time_string, Fdecode_time, Fencode_time):
9099 (Fcurrent_time_string): Use it.
9100
8be6f318
PE
9101 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9102 * dired.c (make_time): Move to ...
9103 * editfns.c (make_time): ... here.
9104 * systime.h: Note the move.
9105
09d9db2c 91062011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9107
126bc0dc
YM
9108 * fringe.c (update_window_fringes): Remove unused variables.
9109
c47cbdfd
YM
9110 * unexmacosx.c (copy_data_segment): Also copy __got section.
9111 (Bug#8223)
9112
7ac80be9
EZ
91132011-03-12 Eli Zaretskii <eliz@gnu.org>
9114
c96bbc66 9115 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9116 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9117 Constify `char *' arguments and their references according to
9118 prototypes in tparam.h.
9119
ecb0f94d 9120 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9121
7ac80be9
EZ
9122 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9123 Adapt all references accordingly.
9124
9125 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9126
ef1fd07e
TT
91272011-03-11 Tom Tromey <tromey@redhat.com>
9128
9129 * buffer.c (syms_of_buffer): Remove obsolete comment.
9130
7ef4b50c
EZ
91312011-03-11 Eli Zaretskii <eliz@gnu.org>
9132
9133 * termhooks.h (encode_terminal_code): Declare prototype.
9134
9135 * msdos.c (encode_terminal_code): Don't declare prototype.
9136
9137 * term.c (encode_terminal_code): Now external again, used by
9138 w32console.c and msdos.c.
9139
44f230aa
SM
9140 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9141 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9142
4b1ec863 91432011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9144
1714f52b 9145 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9146
4b1ec863
PE
9147 * fringe.c (update_window_fringes): Mark locals as initialized
9148 (Bug#8227).
9149 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9150
524c7aa6
PE
9151 * alloc.c (mark_fringe_data): Move decl from here ...
9152 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9153 to check its interface.
9154 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9155
a5c0af81 9156 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9157 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9158 (fontset_font): Mark local as initialized.
a9a06e0b 9159 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9160
b4716021
PE
9161 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9162
811e9bac 9163 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9164 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9165 (x_own_selection, Fx_disown_selection_internal): Rename locals
9166 to avoid shadowing.
9167 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9168
7e3ab302
PE
9169 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9170 so that the caller can use some name other than gcpro1.
9171 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9172 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9173 (Fx_backspace_delete_keys_p):
9174 Use them to avoid shadowing, and rename vars to avoid shadowing.
9175 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9176 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9177 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9178 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9179 Remove unused locals.
7e3ab302
PE
9180 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9181 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9182 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9183 macros.
f78faa98 9184
e2b13473
PE
9185 * xterm.h (x_mouse_leave): New decl.
9186
77f23912
PE
9187 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9188 Remove unused functions.
cdf4ba58
PE
9189 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9190 (x_calc_absolute_position): Now static.
7411c686 9191 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9192 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9193 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9194 unless they are used.
38d0b34a
PE
9195 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9196 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9197 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9198 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9199 (x_error_catcher, x_connection_closed, x_error_handler):
9200 (x_error_quitter, xembed_send_message, x_iconify_frame):
9201 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9202 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9203 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9204
44f230aa
SM
9205 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9206 Rename or move locals to avoid shadowing.
6b463e58 9207 (tty_defined_color, merge_face_heights): Now static.
5967d051 9208 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9209 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9210 does not deduce is never used uninitialized.
73719eba
PE
9211 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9212 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9213
426994c3 9214 * terminal.c (store_terminal_param): Now static.
5489860b 9215
032f1620 9216 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9217 (set_frame_menubar): Remove unused local.
d4323972 9218 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9219 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9220 since they might point to immutable storage.
281585b0
PE
9221 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9222 since it's unused otherwise.
032f1620 9223
367c19e5 9224 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9225 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9226 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9227 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9228 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9229 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9230 does not deduce are never used uninitialized.
70739cbe 9231
07b48fa9
PE
9232 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9233
8868a238 9234 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9235 * window.c (window_loop, size_window):
9236 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9237
7e5cf297 9238 * window.c (display_buffer): Now static.
d6550a9f
PE
9239 (size_window): Mark variables that gcc -Wuninitialized
9240 does not deduce are never used uninitialized.
a586633d
PE
9241 * window.h (check_all_windows): New decl, to forestall
9242 gcc -Wmissing-prototypes diagnostic.
5b555da1 9243 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9244
f6095868
PE
9245 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9246 shadowing.
9247 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9248 Include <limits.h>.
9249 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9250 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9251 (load_charset_map): Mark variables that gcc -Wuninitialized
9252 does not deduce are never used uninitialized.
53df7c11 9253 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9254
f38b440c
PE
9255 * coding.c (coding_set_source, coding_set_destination):
9256 Use "else { /* comment */ }" rather than "else /* comment */;"
9257 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9258 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9259 a block, when the outer 'i' will do.
9260 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9261 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9262 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9263 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9264 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9265 Rename locals to avoid shadowing.
9266 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9267 * coding.c (emacs_mule_char, encode_invocation_designation):
9268 Now static, since they're not used elsewhere.
413bb2db 9269 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9270 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9271 (decode_coding_emacs_mule): Mark variables that gcc
9272 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9273 (detect_coding_iso_2022): Initialize a local variable that might
9274 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9275 this initialization is needed. (Bug#8211)
5f58e762
PE
9276 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9277 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9278 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9279 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9280 Remove unused macros.
f38b440c 9281
232b38b9 9282 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9283 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9284 * character.c (string_count_byte8): Likewise.
232b38b9 9285
fb90da1b
PE
9286 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9287 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9288
fb93dbc2
PE
9289 * chartab.c (copy_sub_char_table): Now static, since it's not used
9290 elsewhere.
5c156ace
PE
9291 (sub_char_table_ref_and_range, char_table_ref_and_range):
9292 Rename locals to avoid shadowing.
bbcd0949 9293 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9294
7d3b3862 9295 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9296 (BIDI_BOB): Remove unused macro.
7d3b3862 9297
6be7d3da
PE
9298 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9299 deduce are never used uninitialized.
c2ed9c8b 9300 * term.c (encode_terminal_code): Likewise.
6be7d3da 9301
75f8807f 9302 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9303
50938595
PE
9304 * tparam.h: New file.
9305 * term.c, tparam.h: Include it.
9306 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9307 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9308 Move these decls to tparam.h, and make them agree with what
9309 is actually in tparam.c. The previous trick of using incompatible
9310 decls in different modules does not conform to the C standard.
9311 All callers of tparam changed to use tparam's actual API.
9312 * tparam.c (tparam1, tparam, tgoto):
9313 Use const pointers where appropriate.
9314
fbceeba2
PE
9315 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9316 * cm.h (struct cm): Likewise.
9317 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9318 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9319 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9320 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9321 (turn_on_face, init_tty): Likewise.
9322 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9323
7f3f1250
PE
9324 * term.c (term_mouse_position): Rename local to avoid shadowing.
9325
e6ca6543
PE
9326 * alloc.c (mark_ttys): Move decl from here ...
9327 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9328
c40f8d15
AS
93292011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9330
9331 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9332
cfe0661d
JB
93332011-03-09 Juanma Barranquero <lekktu@gmail.com>
9334
9335 * search.c (compile_pattern_1): Remove argument regp, unused since
9336 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9337 (compile_pattern): Don't pass it.
9338
0afb4571
J
93392011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9340
9341 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9342 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9343 for ! HAVE_GTK3.
9344 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9345
9346 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9347
9348 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9349 gdk_window_get_screen, gdk_window_get_geometry,
9350 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9351 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9352 (xg_get_pixbuf_from_pixmap): New function.
9353 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9354 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9355 Call xg_get_pixbuf_from_pixmap instead of
9356 gdk_pixbuf_get_from_drawable.
9357 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9358 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9359 (xg_check_special_colors): Use GtkStyleContext and its functions
9360 for HAVE_GTK3.
9361 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9362 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9363 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9364 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9365 Call gtk_widget_get_preferred_size.
0afb4571
J
9366 (xg_frame_resized): gdk_window_get_geometry only takes 5
9367 parameters.
44f230aa
SM
9368 (xg_win_to_widget, xg_event_is_for_menubar):
9369 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9370 (xg_set_widget_bg): New function.
9371 (delete_cb): New function.
895009e1 9372 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9373 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9374 (xg_set_background_color): Call xg_set_widget_bg.
9375 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9376 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9377 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9378 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9379 if ! HAVE_GTK3.
9380 (update_frame_tool_bar): Call gtk_widget_hide.
9381 (xg_initialize): Use GDK_KEY_g.
9382
9383 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9384 if ! HAVE_GTK3
9385 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9386
9387 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9388 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9389 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9390
1c2cc4ef
JB
93912011-03-08 Juanma Barranquero <lekktu@gmail.com>
9392
9393 * w32xfns.c (select_palette): Check success of RealizePalette against
9394 GDI_ERROR, not zero.
9395
33383987 9396See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9397
9398;; Local Variables:
9399;; coding: utf-8
aac0c6e3
MR
9400;; End:
9401
acaf905b 9402 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9403
9404 This file is part of GNU Emacs.
9405
9406 GNU Emacs is free software: you can redistribute it and/or modify
9407 it under the terms of the GNU General Public License as published by
9408 the Free Software Foundation, either version 3 of the License, or
9409 (at your option) any later version.
9410
9411 GNU Emacs is distributed in the hope that it will be useful,
9412 but WITHOUT ANY WARRANTY; without even the implied warranty of
9413 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9414 GNU General Public License for more details.
9415
9416 You should have received a copy of the GNU General Public License
9417 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.