* image.c (gif_load): Rename local to avoid shadowing.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c9d624c6
PE
12011-06-08 Paul Eggert <eggert@cs.ucla.edu>
2
20ce5912
PE
3 * image.c (gif_load): Rename local to avoid shadowing.
4
9c4c5f81
PE
5 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7 * alloc.c (make_save_value): Integer argument is now of type
8 ptrdiff_t, not int.
9 (mark_object): Use ptrdiff_t, not int.
10 * lisp.h (pD): New macro.
11 * print.c (print_object): Use it.
12
c0c5c8ae
PE
13 * alloc.c: Use EMACS_INT, not int, to count objects.
14 (total_conses, total_markers, total_symbols, total_vector_size)
15 (total_free_conses, total_free_markers, total_free_symbols)
16 (total_free_floats, total_floats, total_free_intervals, total_intervals)
17 (total_strings, total_free_strings):
18 Now EMACS_INT, not int. All uses changed.
19 (Fgarbage_collect): Compute overall total using a double, so that
20 integer overflow is less likely to be a problem. Check for overflow
21 when converting back to an integer.
5a25e253
PE
22 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
23 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
24 These were 'int' variables that could overflow on 64-bit hosts;
25 they were never used, so remove them instead of repairing them.
211a0b2a 26 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
27 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
28 Previously, this ceilinged at INT_MAX, but that doesn't work on
29 64-bit machines.
e46bb31a 30 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 31
c78baabf 32 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 33 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
34 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
35 when a (possibly-narrower) signed value would do just as well.
36 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 37
c9d624c6
PE
38 * alloc.c: Catch some string size overflows that we were missing.
39 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
40 for convenience in STRING_BYTES_MAX.
41 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
42 The definition here is exact; the one in lisp.h was approximate.
43 (allocate_string_data): Check for string overflow. This catches
44 some instances we weren't catching before. Also, it catches
45 size_t overflow on (unusual) hosts where SIZE_MAX <= min
46 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
47 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 48
c9d624c6
PE
49 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
50 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
51 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
52
353032ce
PE
53 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
54
2bccce07
PE
55 * alloc.c (Fmake_string): Check for out-of-range init.
56
f3d1777e
MR
572011-06-08 Martin Rudalics <rudalics@gmx.at>
58
496e208e
MR
59 * window.h (window): Add some new members to window structure -
60 normal_lines, normal_cols, new_total, new_normal, clone_number,
61 splits, nest, prev_buffers, next_buffers.
62 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 63 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 64
f3d1777e
MR
65 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
66 Remove.
496e208e
MR
67 (make_dummy_parent): Set new members of windows structure.
68 (make_window): Move down in code. Handle new members of window
69 structure.
70 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
71 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
72 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
73 (Fset_window_prev_buffers, Fwindow_next_buffers)
74 (Fset_window_next_buffers, Fset_window_clone_number): New
75 functions.
76 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
77 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
78 Doc-string fixes.
79 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
80 Argument WINDOW can be now internal window too.
81 (Fwindow_use_time): Move up in code.
82 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
83 Rewrite doc-string.
84 (Fset_window_configuration, saved_window)
85 (Fcurrent_window_configuration, save_window_save): Handle new
86 members of window structure.
b9e809c2
MR
87 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
88 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
89 (syms_of_window): New Lisp objects Qrecord_window_buffer,
90 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
91 Qget_mru_window, Qresize_root_window,
92 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
93 Qauto_buffer_name; staticpro them.
f3d1777e 94
abde8f8c
MR
952011-06-07 Martin Rudalics <rudalics@gmx.at>
96
97 * window.c (Fwindow_total_size, Fwindow_left_column)
98 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
99 (Fwindow_list_1): New functions.
100 (window_box_text_cols): Replace with window_body_cols.
101 (Fwindow_width, Fscroll_left, Fscroll_right): Use
102 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
103 (delete_window, Fset_window_configuration): Call
104 delete_all_subwindows with window as argument.
105 (delete_all_subwindows): Take a window as argument and not a
106 structure. Rewrite.
190b47e6
MR
107 (window_loop): Remove handling of GET_LRU_WINDOW and
108 GET_LARGEST_WINDOW.
109 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
110
111 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
112 window_box_text_cols. delete_all_subwindows now takes a
113 Lisp_Object as argument.
abde8f8c
MR
114
115 * indent.c (compute_motion, Fcompute_motion): Use
116 window_body_cols instead of window_box_text_cols.
117
fa8a67e6
MR
118 * frame.c (delete_frame): Call delete_all_subwindows with root
119 window as argument.
120
a54e3482
DC
1212011-06-07 Daniel Colascione <dan.colascione@gmail.com>
122
123 * fns.c (Fputhash): Document return value.
124
60002bf5
CY
1252011-06-06 Chong Yidong <cyd@stupidchicken.com>
126
127 * image.c (gif_load): Implement gif89a spec "no disposal" method.
128
0c671da6 1292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 130
b862a52a 131 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 132
be44ca6c
PE
133 Check for overflow when converting integer to cons and back.
134 * charset.c (Fdefine_charset_internal, Fdecode_char):
135 Use cons_to_unsigned to catch overflow.
136 (Fencode_char): Use INTEGER_TO_CONS.
137 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
138 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
139 * data.c (long_to_cons, cons_to_long): Remove.
140 (cons_to_unsigned, cons_to_signed): New functions.
141 These signal an error for invalid or out-of-range values.
142 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
143 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
144 * font.c (Ffont_variation_glyphs):
145 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
146 * lisp.h: Include <intprops.h>.
147 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
148 (cons_to_signed, cons_to_unsigned): New decls.
149 (long_to_cons, cons_to_long): Remove decls.
150 * undo.c (record_first_change): Use INTEGER_TO_CONS.
151 (Fprimitive_undo): Use CONS_TO_INTEGER.
152 * xfns.c (Fx_window_property): Likewise.
153 * xselect.c: Include <limits.h>.
154 (x_own_selection, selection_data_to_lisp_data):
155 Use INTEGER_TO_CONS.
156 (x_handle_selection_request, x_handle_selection_clear)
157 (x_get_foreign_selection, Fx_disown_selection_internal)
158 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
159 (lisp_data_to_selection_data): Use cons_to_unsigned.
160 (x_fill_property_data): Use cons_to_signed.
161 Report values out of range.
162
d1f3d2af
PE
163 Check for buffer and string overflow more precisely.
164 * buffer.h (BUF_BYTES_MAX): New macro.
165 * lisp.h (STRING_BYTES_MAX): New macro.
166 * alloc.c (Fmake_string):
167 * character.c (string_escape_byte8):
168 * coding.c (coding_alloc_by_realloc):
169 * doprnt.c (doprnt):
170 * editfns.c (Fformat):
171 * eval.c (verror):
172 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
173 since they may not be the same number.
174 * editfns.c (Finsert_char):
175 * fileio.c (Finsert_file_contents):
176 Likewise for BUF_BYTES_MAX.
177
dd52fcea
PE
178 * image.c: Use ptrdiff_t, not int, for sizes.
179 (slurp_file): Switch from int to ptrdiff_t.
180 All uses changed.
181 (slurp_file): Check that file size fits in both size_t (for
182 malloc) and ptrdiff_t (for sanity and safety).
183
7f9bbdbb
PE
184 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
185 if b->modtime has its maximal value.
186
dfe18f82
PE
187 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
188
84acfcf0
PE
189 Don't assume time_t can fit into int.
190 * buffer.h (struct buffer.modtime): Now time_t, not int.
191 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
192 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
193
ccd9a01a
PE
194 Minor fixes for signed vs unsigned integers.
195 * character.h (MAYBE_UNIFY_CHAR):
196 * charset.c (maybe_unify_char):
197 * keyboard.c (read_char, reorder_modifiers):
198 XINT -> XFASTINT, since the integer must be nonnegative.
199 * ftfont.c (ftfont_spec_pattern):
200 * keymap.c (access_keymap, silly_event_symbol_error):
201 XUINT -> XFASTINT, since the integer must be nonnegative.
202 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
203 since it makes no difference and we prefer signed.
204 * keyboard.c (record_char): Use XUINT when all the neighbors do.
205 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
206 nonnegative.
207
d6d100dd
SM
2082011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
209
210 * window.h (Fwindow_frame): Declare.
211
2b6148e4
PE
2122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
213
214 * alloc.c: Simplify handling of large-request failures (Bug#8800).
215 (SPARE_MEMORY): Always define.
216 (LARGE_REQUEST): Remove.
217 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
218
f230ecc9
MR
2192011-06-06 Martin Rudalics <rudalics@gmx.at>
220
727e958e
MR
221 * lisp.h: Move EXFUNS for Fframe_root_window,
222 Fframe_first_window and Fset_frame_selected_window to window.h.
223
224 * window.h: Move EXFUNS for Fframe_root_window,
225 Fframe_first_window and Fset_frame_selected_window here from
226 lisp.h.
227
228 * frame.c (Fwindow_frame, Fframe_first_window)
229 (Fframe_root_window, Fframe_selected_window)
230 (Fset_frame_selected_window): Move to window.c.
231 (Factive_minibuffer_window): Move to minibuf.c.
232 (Fother_visible_frames_p): New function.
233
234 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
235
f230ecc9
MR
236 * window.c (decode_window, decode_any_window): Move up in code.
237 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
238 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
239 (Fwindow_buffer): Move up and rewrite doc-string.
240 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
241 (Fwindow_prev): New functions.
727e958e
MR
242 (Fwindow_frame): Move here from frame.c. Accept any window as
243 argument.
244 (Fframe_root_window, Fframe_first_window)
245 (Fframe_selected_window): Move here from frame.c. Accept frame
246 or arbitrary window as argument. Update doc-strings.
247 (Fminibuffer_window): Move up in code.
248 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
249 (Fset_frame_selected_window): Move here from frame.c.
250 Marginal rewrite.
727e958e
MR
251 (Fselected_window, select_window, Fselect_window): Move up in
252 code. Minor doc-string fixes.
f230ecc9 253
4d09bcf6
PE
2542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
255
256 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
257 Do not assume that spare memory exists; that assumption is valid
258 only if SYSTEM_MALLOC.
259 (LARGE_REQUEST): New macro, so that the issue of large requests
260 is separated from the issue of spare memory.
261
810928a2
AS
2622011-06-05 Andreas Schwab <schwab@linux-m68k.org>
263
172418ad
AS
264 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
265 format. (Bug#8806)
266
43f862f7
AS
267 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
268
810928a2
AS
269 * xfns.c (x_set_scroll_bar_default_width): Move declarations
270 before statements.
271
a059fe24
JD
2722011-06-05 Jan Djärv <jan.h.d@swipnet.se>
273
274 * gtkutil.c (xg_get_default_scrollbar_width): New function.
275
276 * gtkutil.h: Declare xg_get_default_scrollbar_width.
277
278 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
279 min width by calling x_set_scroll_bar_default_width (Bug#8505).
280
989bf368
JB
2812011-06-05 Juanma Barranquero <lekktu@gmail.com>
282
283 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
284
4b80f674
CY
2852011-06-04 Chong Yidong <cyd@stupidchicken.com>
286
287 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
288 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
289 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
290 New error handlers.
4b80f674
CY
291 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
292 Obey Vx_select_enable_clipboard_manager. Catch errors in
293 x_clipboard_manager_save (Bug#8779).
294 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 295 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 296
99a33b77 2972011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
298
299 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
300
99a33b77 3012011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
302
303 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
304 in the current matrix if keep_current_p is non-zero.
305
8264569d
EZ
3062011-06-04 Eli Zaretskii <eliz@gnu.org>
307
308 * bidi.c (bidi_level_of_next_char): Fix last change.
309
57f97249
EZ
3102011-06-03 Eli Zaretskii <eliz@gnu.org>
311
fec2107c 312 Support bidi reordering of text covered by display properties.
57f97249 313
fec2107c
EZ
314 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
315 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
316 (bidi_cache_search, bidi_cache_iterator_state)
317 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
318 (bidi_level_of_next_char, bidi_move_to_visually_next):
319 Support character positions inside a run of characters covered by a
fec2107c
EZ
320 display string.
321 (bidi_paragraph_init, bidi_resolve_explicit_1)
322 (bidi_level_of_next_char): Call bidi_fetch_char and
323 bidi_fetch_char_advance instead of FETCH_CHAR and
324 FETCH_CHAR_ADVANCE.
325 (bidi_init_it): Initialize new members.
326 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
327 definitions.
328 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
329 instead of using explicit *_CHAR codes.
d6d100dd
SM
330 (bidi_resolve_explicit, bidi_resolve_weak):
331 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
332 bidirectional text is supported only in multibyte buffers.
333 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
334 it to initialize the frame_window_p member of struct bidi_it.
335 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
336 (bidi_resolve_explicit, bidi_resolve_weak)
337 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
338 bidi_it->nchars is non-positive.
339 (bidi_level_of_next_char): Don't try to lookup the cache for the
340 next/previous character if nothing is cached there yet, or if we
341 were just reseat()'ed to a new position.
c40e2fb2 342
0e14fe90
EZ
343 * xdisp.c (set_cursor_from_row): Set start and stop points
344 according to the row's direction when priming the loop that looks
345 for the glyph on which to display cursor.
346 (single_display_spec_intangible_p): Function deleted.
347 (display_prop_intangible_p): Reimplement to call
348 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
349 Accept 3 additional arguments needed by handle_display_spec.
350 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
351 values: lists, `(when COND...)' forms, etc.
352 (single_display_spec_string_p): Support property values that are
353 lists with the argument STRING its top-level element.
354 (display_prop_string_p): Fix the condition for processing a
355 property that is a list to be consistent with handle_display_spec.
fec2107c 356 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
357 last portion of handle_display_prop.
358 (compute_display_string_pos): Accept additional argument
359 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
360 value of a `display' property is a "replacing spec".
361 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
362 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
363 the display property, but just return a value indicating whether
364 the display property will replace the characters it covers.
365 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
366 frame_window_p members of struct bidi_it.
d6d100dd
SM
367 (compute_display_string_pos, compute_display_string_end):
368 New functions.
fec2107c
EZ
369 (push_it): Accept second argument POSITION, where pop_it should
370 jump to continue iteration.
371 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 372
fec2107c
EZ
373 * keyboard.c (adjust_point_for_property): Adjust the call to
374 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
375
376 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
377 (bidi_init_it): Update prototypes.
378 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
379 (compute_display_string_pos, compute_display_string_end):
380 Declare prototypes.
fec2107c
EZ
381 (struct bidi_it): New members nchars and disp_pos. ch_len is now
382 EMACS_INT.
fc6f18ce 383
40087514 3842011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 385
57f53182
PE
386 Malloc failure behavior now depends on size of allocation.
387 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
388 * lisp.h: Change signatures accordingly.
389 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
390 All callers changed. (Bug#8762)
391
392 * gnutls.c: Use Emacs's memory allocators.
393 Without this change, the gnutls library would invoke malloc etc.
394 directly, which causes problems on non-SYNC_INPUT hosts, and which
395 runs afoul of improving memory_full behavior. (Bug#8761)
396 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
397 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
398 xfree instead of the default malloc, realloc, free.
399 (Fgnutls_boot): No need to check for memory allocation failure,
400 since xmalloc does that for us.
401
ac32cd99 402 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
403 * category.c (hash_get_category_set):
404 * ccl.c (ccl_driver):
405 * charset.c (Fdefine_charset_internal):
406 * charset.h (struct charset.hash_index):
407 * composite.c (get_composition_id, gstring_lookup_cache)
408 (composition_gstring_put_cache):
409 * composite.h (struct composition.hash_index):
410 * dispextern.h (struct image.hash):
411 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
412 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
413 (hashfn_equal, hashfn_user_defined, make_hash_table)
414 (maybe_resize_hash_table, hash_lookup, hash_put)
415 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
416 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
417 (Fsxhash, Fgethash, Fputhash, Fmaphash):
418 * image.c (make_image, search_image_cache, lookup_image)
419 (xpm_put_color_table_h):
420 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 421 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
422 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
423 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
424 * alloc.c (allocate_vectorlike):
425 Check for overflow in vector size calculations.
426 * ccl.c (ccl_driver):
427 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
428 * fns.c, image.c: Remove unnecessary static decls that would otherwise
429 need to be updated by these changes.
40087514
PE
430 * fns.c (make_hash_table, maybe_resize_hash_table):
431 Check for integer overflow with large hash tables.
0de4bb68
PE
432 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
433 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
434 (SXHASH_REDUCE): New macro.
435 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
436 Use it instead of discarding useful hash info with large hash values.
437 (sxhash_float): New function.
438 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
439 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
440 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
441 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
442 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
443 Adjust signatures to match updated version of code.
444 (consing_since_gc): Now EMACS_INT, since a single hash table can
445 use more than INT_MAX bytes.
446
698d32e2
DN
4472011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
448
449 Make it possible to build with GCC-4.6+ -O2 -flto.
450
451 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
452
fd6fa53f
SM
4532011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
454
455 * minibuf.c (get_minibuffer, read_minibuf_unwind):
456 Call minibuffer-inactive-mode.
457
864db017
JB
4582011-05-31 Juanma Barranquero <lekktu@gmail.com>
459
460 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
461 Update dependencies.
462
2ad0baf4
DN
4632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
464
465 * data.c (init_data): Remove code for UTS, this system is not
466 supported anymore.
467
4fcc2638
DN
4682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
469
470 Don't force ./temacs to start in terminal mode.
471
472 * frame.c (make_initial_frame): Initialize faces in all cases, not
473 only when CANNOT_DUMP is defined.
474 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
475
c56e0fd5
DN
4762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
477
478 * dispnew.c (add_window_display_history): Use const for the string
479 pointer. Remove declaration, not needed.
480
333d54da 4812011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 482
55d4c1b2 483 Use 'inline', not 'INLINE'.
333d54da 484 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
485 * alloc.c, fontset.c (INLINE): Remove.
486 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
487 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
488 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
489 * gmalloc.c (register_heapinfo): Use inline unconditionally.
490 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
491
738db178
DN
4922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
493
494 Make it possible to run ./temacs.
495
496 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
497 syms_of_callproc does the same thing. Remove test for
498 "initialized", do it in the caller.
499 * emacs.c (main): Avoid calling set_initial_environment when dumping.
500
620c53a6
SM
5012011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
502
503 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
504 (read_minibuf): Use get_minibuffer.
505 (syms_of_minibuf): Use DEFSYM.
506 (Qmetadata): New var.
507 * data.c (Qbuffer): Don't make it static.
508 (syms_of_data): Use DEFSYM.
509
e003a292
PE
5102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
511
512 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
513 (CCL_CODE_MIN): New macro.
514
ed008a6d
PE
5152011-05-30 Paul Eggert <eggert@cs.ucla.edu>
516
3687c2ef
PE
517 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
518
ed008a6d
PE
519 * eval.c (Qdebug): Now static.
520 * lisp.h (Qdebug): Remove decl. This reverts a part of the
521 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
522 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
523
d66c4c7c
CY
5242011-05-29 Chong Yidong <cyd@stupidchicken.com>
525
526 * image.c: Various fixes to ImageMagick code comments.
527 (Fimagemagick_types): Doc fix.
528
5fbc2025
PE
5292011-05-29 Paul Eggert <eggert@cs.ucla.edu>
530
0196f88a
PE
531 Minor fixes prompted by GCC 4.6.0 warnings.
532
533 * xselect.c (converted_selections, conversion_fail_tag): Now static.
534
5fbc2025
PE
535 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
536 (x_clipboard_manager_save_all): Move extern decl to ...
537 * xterm.h: ... here, so that it can be checked for consistency.
538
1dd3c2d9
CY
5392011-05-29 Chong Yidong <cyd@stupidchicken.com>
540
541 * xselect.c (x_clipboard_manager_save_frame)
542 (x_clipboard_manager_save_all): New functions.
543 (Fx_clipboard_manager_save): Lisp function deleted.
544
545 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
546 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
547
548 * xterm.h: Update prototype.
549
5ba6571d
WX
5502011-05-28 William Xu <william.xwl@gmail.com>
551
552 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
553 exiting (Bug#8239).
554
3eaff834
JM
5552011-05-28 Jim Meyering <meyering@redhat.com>
556
e1900994 557 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
558 * fns.c (to_uchar): Define.
559 (crypto_hash_function): Use it to convert some newly-signed
560 variables to unsigned, to avoid sign-extension bugs. For example,
561 without this change, (md5 "truc") would evaluate to
562 45723a2aff78ff4fff7fff1114760e62 rather than the expected
563 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 564 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 565
0f6990a7
PE
5662011-05-27 Paul Eggert <eggert@cs.ucla.edu>
567
568 Integer overflow fixes.
c8a9ca5a 569
08686060
PE
570 * dbusbind.c: Serial number integer overflow fixes.
571 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
572 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
573 to hold a serial number that is too large for a fixnum.
574 (Fdbus_method_return_internal, Fdbus_method_error_internal):
575 Check for serial numbers out of range. Decode any serial number
59568bf0 576 that was so large that it became a float. (Bug#8722)
08686060 577
2d1fc3c7
PE
578 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
579 (Fdbus_call_method, Fdbus_call_method_asynchronously):
580 Use XFASTINT rather than XUINT when numbers are nonnegative.
581 (xd_append_arg, Fdbus_method_return_internal):
582 (Fdbus_method_error_internal): Likewise. Also, for unsigned
583 arguments, check that Lisp number is nonnegative, rather than
59568bf0 584 silently wrapping negative numbers around. (Bug#8722)
30217ff0 585 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 586 (Bug#8722)
2d1fc3c7 587
c8a9ca5a
PE
588 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
589
519e1d69
PE
590 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
591
30569699
PE
592 ccl: add integer overflow checks
593 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
594 (IN_INT_RANGE): New macros.
595 (ccl_driver): Use them to check for integer overflow when
596 decoding a CCL program. Many of the new checks are whether XINT (x)
597 fits in int; it doesn't always, on 64-bit hosts. The new version
598 doesn't catch all possible integer overflows, but it's an
847044ea 599 improvement. (Bug#8719)
30569699 600
c11285dc
PE
601 * alloc.c (make_event_array): Use XINT, not XUINT.
602 There's no need for unsigned here.
603
fdccd48e
PE
604 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
605 This follows up to the 2011-05-06 change that substituted uintptr_t
606 for EMACS_INT. This case wasn't caught back then.
607
37910ab2
PE
608 Rework Fformat to avoid integer overflow issues.
609 * editfns.c: Include <float.h> unconditionally, as it's everywhere
610 now (part of C89). Include <verify.h>.
611 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
612 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
613 (Fformat): Avoid the prepass trying to compute sizes; it was only
614 approximate and thus did not catch overflow reliably. Instead, walk
615 through the format just once, formatting and computing sizes as we go,
616 checking for integer overflow at every step, and allocating a larger
617 buffer as needed. Keep track separately whether the format is
618 multibyte. Keep only the most-recently calculated precision, rather
619 than them all. Record whether each argument has been converted to
620 string. Use EMACS_INT, not int, for byte and char and arg counts.
621 Support field widths and precisions larger than INT_MAX. Avoid
622 sprintf's undefined behavior with conversion specifications such as %#d
623 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
624 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
625 formatting out-of-range floating point numbers with int
626 formats. (Bug#8668)
627
2e6578fb
PE
628 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
629
0ae6bdee
PE
630 * data.c: Avoid integer truncation in expressions involving floats.
631 * data.c: Include <intprops.h>.
632 (arith_driver): When there's an integer overflow in an expression
633 involving floating point, convert the integers to floating point
634 so that the resulting value does not suffer from catastrophic
635 integer truncation. For example, on a 64-bit host (* 4
636 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
637 Do not rely on undefined behavior after integer overflow.
638
de883a70
PE
639 merge count_size_as_multibyte, parse_str_to_multibyte
640 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 641 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
642 Check for integer overflow.
643 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
644 since it's now a duplicate of the other. This is more of
645 a character than a buffer op, so better that it's in character.c.
646 * fns.c, print.c: Adjust to above changes.
647
2ff916cb
PE
6482011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
649
650 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
651
f1b54466
PE
6522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
653
fb1ac845
PE
654 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
655 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
656 (x_clipboard_manager_save): Now static.
657 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
658
f1b54466
PE
659 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
660 (crypto_hash_function): Now static.
661 Fix pointer signedness problems. Avoid unnecessary initializations.
662
a9f737ee
CY
6632011-05-27 Chong Yidong <cyd@stupidchicken.com>
664
665 * termhooks.h (Vselection_alist): Make it terminal-local.
666
667 * terminal.c (create_terminal): Initialize it.
668
669 * xselect.c: Support for clipboard managers.
670 (Vselection_alist): Move to termhooks.h as terminal-local var.
671 (LOCAL_SELECTION): New macro.
672 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
673 (symbol_to_x_atom): Remove gratuitous arg.
674 (x_handle_selection_request, lisp_data_to_selection_data)
675 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
676 (x_own_selection, x_get_local_selection, x_convert_selection):
677 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
678 (some_frame_on_display): Delete unused function.
679 (Fx_own_selection_internal, Fx_get_selection_internal)
680 (Fx_disown_selection_internal, Fx_selection_owner_p)
681 (Fx_selection_exists_p): New optional frame arg.
682 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
683 (x_handle_selection_clear): Don't treat other terminals with the
684 same keyboard specially. Use the terminal-local Vselection_alist.
685 (x_clear_frame_selections): Use Frun_hook_with_args.
686
687 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
688
689 * xterm.h: Add support for those atoms.
690
e067f0c1
CY
6912011-05-26 Chong Yidong <cyd@stupidchicken.com>
692
693 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
694 (converted_selections, conversion_fail_tag): New global variables.
695 (x_selection_request_lisp_error): Free the above.
696 (x_get_local_selection): Remove unnecessary code.
697 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
698 of converted selections stored in converted_selections.
699 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
700 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
701 (x_convert_selection): New function.
702 (x_handle_selection_event): Simplify.
703 (x_get_foreign_selection): Don't ignore incoming requests while
704 waiting for an answer; this will fail when we implement
705 SAVE_TARGETS, and seems unnecessary anyway.
706 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
707 (Vx_sent_selection_functions): Doc fix.
708
0f4aebc0
LL
7092011-05-26 Leo Liu <sdl.web@gmail.com>
710
711 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
712
e61124cd
YM
7132011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
714
715 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
716
717 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
718 for fringe update if it has periodic bitmap.
719 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
720 and fringe_bitmap_periodic_p.
721
722 * fringe.c (get_fringe_bitmap_data): New function.
723 (draw_fringe_bitmap_1, update_window_fringes): Use it.
724 (update_window_fringes): Record periodicity of fringe bitmap in glyph
725 row. Mark glyph row for fringe update if periodicity changed.
726
727 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
728 for fringe update unless it has periodic bitmap.
729
f16d9837
KH
7302011-05-25 Kenichi Handa <handa@m17n.org>
731
732 * xdisp.c (get_next_display_element): Set correct it->face_id for
733 a static composition.
734
e1b90ef6
LL
7352011-05-24 Leo Liu <sdl.web@gmail.com>
736
737 * deps.mk (fns.o):
738 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
739
740 * fns.c (crypto_hash_function, Fsha1): New function.
741 (Fmd5): Use crypto_hash_function.
742 (syms_of_fns): Add Ssha1.
743
7400048f
PE
7442011-05-22 Paul Eggert <eggert@cs.ucla.edu>
745
746 * gnutls.c: Remove unused macros.
747 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
748 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
749 Remove macros that are defined and never used.
750 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
751
abb71cf4
CY
7522011-05-22 Chong Yidong <cyd@stupidchicken.com>
753
754 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
755 (Fx_get_selection_internal): Minor cleanup.
756 (Fx_own_selection_internal): Rename arguments for consistency with
757 select.el.
758
6307db39
PE
7592011-05-22 Paul Eggert <eggert@cs.ucla.edu>
760
761 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
762
f3d4e0a4
CY
7632011-05-22 Chong Yidong <cyd@stupidchicken.com>
764
765 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
766
4d8ade89
YM
7672011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
768
769 * dispnew.c (scrolling_window): Don't exclude the case that the
770 last enabled row in the desired matrix touches the bottom boundary.
771
32078c8d
GM
7722011-05-21 Glenn Morris <rgm@gnu.org>
773
774 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
775 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
776 and add some more files.
32078c8d 777
7285dc67
EZ
7782011-05-20 Eli Zaretskii <eliz@gnu.org>
779
780 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
781 report_file_error introduced by the change from 2011-05-07.
782
89d1bd22
PE
7832011-05-20 Paul Eggert <eggert@cs.ucla.edu>
784
785 * systime.h (Time): Define only if emacs is defined.
786 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
787 where the include path doesn't have X11/X.h by default. See
788 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
789
e23640bb 7902011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
791
792 * composite.c (find_automatic_composition): Fix previous change.
793
b9704ad9
GM
7942011-05-20 Glenn Morris <rgm@gnu.org>
795
796 * lisp.mk: New file, split from Makefile.in.
797 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
798 (shortlisp): Remove.
799 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
800
4a720484
GM
8012011-05-19 Glenn Morris <rgm@gnu.org>
802
803 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
804 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
805 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
806 (lisp): Set the order to that of loadup.el.
807 (shortlisp): Make it a copy of $lisp.
808 (SOME_MACHINE_LISP): Remove.
809 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
810 Use just $shortlisp, not $SOME_MACHINE_LISP too.
811
a28d4396
KH
8122011-05-18 Kenichi Handa <handa@m17n.org>
813
814 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
815 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
816 (find_automatic_composition): Mostly rewrite for efficiency.
817
a2b1fa8e
JB
8182011-05-18 Juanma Barranquero <lekktu@gmail.com>
819
820 * makefile.w32-in: Update dependencies.
821
8e1f5610
CS
8222011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
823
824 * menu.c: Include limits.h (fixes the MS-Windows build broken by
825 revision 104625).
826
7025ee00 8272011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 828
cdfa6eab
PE
829 Fix some integer overflow issues, such as string length overflow.
830
06d6db33
PE
831 * insdel.c (count_size_as_multibyte): Check for string overflow.
832
2b4560a8
PE
833 * character.c (lisp_string_width): Check for string overflow.
834 Use EMACS_INT, not int, for string indexes and lengths; in
835 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
836 the resulting string length overflows an EMACS_INT; instead,
837 report a string overflow if no precision given. When checking for
838 precision exhaustion, use a check that cannot possibly have
839 integer overflow. (Bug#8675)
840 * character.h (lisp_string_width): Adjust to new signature.
841
cb93f9be
PE
842 * alloc.c (string_overflow): New function.
843 (Fmake_string): Use it. This doesn't change behavior, but saves
844 a few bytes and will simplify future changes.
845 * character.c (string_escape_byte8): Likewise.
846 * lisp.h (string_overflow): New decl.
847
1a1f3366
PE
848 Fixups, following up to the user-interface timestamp change.
849 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
850 for UI timestamps, instead of unsigned long.
9fbd6841
PE
851 * msdos.c (mouse_get_pos): Likewise.
852 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
853 * w32gui.h (Time): Define by including "systime.h" rather than by
854 declaring it ourselves. (Bug#8664)
855
d4e3e4d3
PE
856 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
857 * image.c (clear_image_cache): Likewise.
858
f6a24d19
PE
859 * term.c (term_mouse_position): Don't assume time_t wraparound.
860
08dc5ae6
PE
861 Be more systematic about user-interface timestamps.
862 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
863 and sometimes 'EMACS_UINT', to represent these timestamps.
864 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
865 This makes the code easier to follow, and makes it easier to catch
866 integer overflow bugs such as Bug#8664.
867 * frame.c (Fmouse_position, Fmouse_pixel_position):
868 Use Time, not unsigned long, for user-interface timestamps.
869 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
870 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
871 * keyboard.h (last_event_timestamp): Likewise.
872 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
873 * menu.h (xmenu_show): Likewise.
874 * term.c (term_mouse_position): Likewise.
875 * termhooks.h (struct input_event.timestamp): Likewise.
876 (struct terminal.mouse_position_hook): Likewise.
877 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
878 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
879 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
880 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
881 what it was before.
882 * menu.h, termhooks.h: Include "systime.h", for Time.
883
8e55734a
PE
884 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
885 Don't assume that the difference between two unsigned long values
886 can fit into an integer. At this point, we know button_down_time
887 <= event->timestamp, so the difference must be nonnegative, so
888 there's no need to cast the result if double-click-time is
889 nonnegative, as it should be; check that it's nonnegative, just in
890 case. This bug is triggered when events are more than 2**31 ms
86db42d2 891 apart (about 25 days). (Bug#8664)
8e55734a 892
841f1b75 893 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 894 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 895
3e26f69c
PE
896 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
897 that always fit in int. Use a sentinel instead of a counter, to
898 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
899 * frame.h (struct frame): Use int for menu_bar_items_used
900 instead of EMACS_INT, since it always fits in int.
3e26f69c 901
5cc152c0
PE
902 * menu.c (grow_menu_items): Check for int overflow.
903
d89eb65e
PE
904 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
905
5235bd3e
PE
906 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
907 Before, the code was not consistent. These values cannot exceed
908 2**31 - 1 so there's no need to make them unsigned.
909 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
910 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
911 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
912 as modifiers.
913 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
914
bc827e23
PE
915 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
916 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
917 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
918 presumably because the widths might not match.
919
78eb494e
PE
920 * window.c (size_window): Avoid needless test at loop start.
921
04f2d78b
CB
9222011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
923
924 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
925
d2fc7e3d 9262011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
927
928 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
929
d2fc7e3d 9302011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
931
932 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
933 `width' to `bar_area_x' and `bar_area_width', respectively.
934 (x_scroll_run): Take account of fringe background extension.
935
04f2d78b
CB
936 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
937 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
938 `bar_area_width', respectively.
939 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
940 background extension.
941
79b70037
GM
9422011-05-10 Jim Meyering <meyering@redhat.com>
943
944 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
945
2f142cc5
JB
9462011-05-10 Juanma Barranquero <lekktu@gmail.com>
947
948 * image.c (Finit_image_library): Return t for built-in image types,
949 like pbm and xbm. (Bug#8640)
950
57679c86
AS
9512011-05-09 Andreas Schwab <schwab@linux-m68k.org>
952
953 * w32menu.c (set_frame_menubar): Fix submenu allocation.
954
888c9e86
EZ
9552011-05-07 Eli Zaretskii <eliz@gnu.org>
956
b0512a1d
EZ
957 * w32console.c (Fset_screen_color): Doc fix.
958 (Fget_screen_color): New function.
959 (syms_of_ntterm): Defsubr it.
960
7285dc67
EZ
961 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
962 unlink the temporary file if Fcall_process didn't create it in the
963 first place.
964 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
965 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
966 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
967 cue to call_process_cleanup not to close that handle.
968
4d3fcc8e
BK
9692011-05-07 Ben Key <bkey76@gmail.com>
970
971 * makefile.w32-in: The bootstrap-temacs rule now makes use of
972 one of two shell specific rules, either bootstrap-temacs-CMD or
973 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
974 to the previous implementation of the bootstrap-temacs rule.
975 The bootstrap-temacs-CMD rule is similar to the previous
976 implementation of the bootstrap-temacs rule except that it
977 makes use of the ESC_CFLAGS variable instead of the CFLAGS
978 variable.
979
980 These changes, along with some changes to nt/configure.bat,
981 nt/gmake.defs, and nt/nmake.defs, are required to extend my
982 earlier fix to add support for --cflags and --ldflags options
983 that include quotes so that it works whether make uses cmd or
984 sh as the shell.
985
b4289b64
MA
9862011-05-06 Michael Albinus <michael.albinus@gmx.de>
987
988 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
989 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
990 is a constant.
991 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
992 a string. Handle both cases.
993 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
994 (Fdbus_register_method): Use Qinvalid_function.
995
af4c0e28
JB
9962011-05-06 Juanma Barranquero <lekktu@gmail.com>
997
998 * makefile.w32-in: Update dependencies.
999 (LISP_H): Add inttypes.h and stdin.h.
1000 (PROCESS_H): Add unistd.h.
1001
c51453d9
EZ
10022011-05-06 Eli Zaretskii <eliz@gnu.org>
1003
1004 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1005 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1006
8ff0ac3c 10072011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1008
4c4b566b
PE
1009 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1010
aab2b9b5
PE
1011 * term.c (vfatal): Remove stray call to va_end.
1012 It's not needed and the C Standard doesn't allow it here anyway.
1013
c378da0b
PE
1014 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1015 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1016
288b08c7
PE
1017 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1018 bytes.
1019
e3601888
PE
1020 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1021
db6c0e74
PE
1022 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1023
dd5963ea
PE
1024 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1025
88c9450f
PE
1026 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1027
2f9442b8
PE
1028 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1029
c032b5f8
PE
1030 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1031 * charset.c (Fdefine_charset_internal): Don't initialize
1032 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1033 32-bit int (Bug#8600).
a108c10b
PE
1034
1035 * lread.c (read_integer): Be more consistent with string-to-number.
1036 Use string_to_number to do the actual conversion; this avoids
1037 rounding errors and fixes some other screwups. Without this fix,
1038 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1039 (digit_to_number): Move earlier, for benefit of read_integer.
1040 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1041 not a digit in any supported base. (Bug#8602)
a108c10b 1042
ad5f9eea
PE
1043 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1044
aec1708a
PE
1045 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1046 to match comment at start of function. This also removes a
1047 GCC warning about overflow in a 32+64-bit port.
1048
47be4ab5
PE
1049 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1050
371cac43
PE
1051 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1052 Reported by Stefan Monnier in
1053 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1054 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1055 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1056
d01a7826
PE
1057 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1058 (EMACS_UINTPTR): Likewise, with uintptr_t.
1059
7fd47d5c
PE
1060 * lisp.h: Prefer 64-bit EMACS_INT if available.
1061 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1062 on 32-bit hosts that have 64-bit int, so that they can access
1063 large files.
122b0c86
PE
1064 However, temporarily disable this change unless the temporary
1065 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1066
8727937b
PE
1067 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1068
8ac068ac
PE
1069 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1070 This removes an assumption that EMACS_INT and long are the same
1071 width as pointers. The assumption is true for Emacs porting targets
1072 now, but we want to make other targets possible.
1073 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1074 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1075 In the rest of the code, change types of integers that hold casted
1076 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1077 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1078 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1079 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1080 No need to cast type when ORing.
1081 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1082 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1083 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1084 assume EMACS_INT is the same width as char *.
1085 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1086 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1087 Remove no-longer-needed casts.
1088 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1089 (xg_tool_bar_help_callback, xg_make_tool_item):
1090 Use EMACS_INTPTR to hold an integer
1091 that will be cast to void *; this can avoid a GCC warning
1092 if EMACS_INT is not the same width as void *.
1093 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1094 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1095 (current_message_1, set_message_1):
1096 Use a local to convert to proper width without a cast.
1097 * xmenu.c (dialog_selection_callback): Likewise.
1098
ede49d71
PE
1099 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1100 Also, don't assume VALBITS / RAND_BITS is less than 5,
1101 and don't rely on undefined behavior when shifting a 1 left into
1102 the sign bit.
1103 * lisp.h (get_random): Change signature to match.
1104
2f30ecd0
PE
1105 * lread.c (hash_string): Use size_t, not int, for hash computation.
1106 Normally we prefer signed values; but hashing is special, because
1107 it's better to use unsigned division on hash table sizes so that
1108 the remainder is nonnegative. Also, size_t is the natural width
1109 for hashing into memory. The previous code used 'int', which doesn't
1110 retain enough info to hash well into very large tables.
1111 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1112
2a866e7b
PE
1113 * dbusbind.c: Don't possibly lose pointer info when converting.
1114 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1115 Use XPNTR rather than XHASH, so that the high-order bits of
1116 the pointer aren't lost when converting through void *.
1117
51639eac
PE
1118 * eval.c (Fautoload): Don't double-shift a pointer.
1119
92394119
PE
1120 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1121
dbdb9a7c
JB
11222011-05-06 Juanma Barranquero <lekktu@gmail.com>
1123
1124 * gnutls.c (DEF_GNUTLS_FN):
1125 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1126
db7a0b4f
AS
11272011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1128
1129 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1130 marker. (Bug#8610)
1131
f7ff1b0f 11322011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1133
1134 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1135 New version that can reserve upto 2GB of heap space.
1136
f7ff1b0f 11372011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1138
1139 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1140
639c109b
TZ
11412011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1142
1143 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1144 `gnutls_certificate_set_x509_key_file'.
1145
d2127135
JB
11462011-05-05 Juanma Barranquero <lekktu@gmail.com>
1147
1148 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1149 Update dependencies.
1150
e968f4f3
JB
11512011-05-04 Juanma Barranquero <lekktu@gmail.com>
1152
1153 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1154 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1155 Remove unused parameter `fildes'.
1156 * process.c (read_process_output, send_process): Don't pass it.
1157
84d358f0
JB
11582011-05-04 Juanma Barranquero <lekktu@gmail.com>
1159
1160 Fix previous change: the library cache is defined in w32.c.
1161 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1162 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1163
0898ca10
JB
11642011-05-04 Juanma Barranquero <lekktu@gmail.com>
1165
1166 Implement dynamic loading of GnuTLS on Windows.
1167
1168 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1169 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1170 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1171 Declare.
1172
1173 * gnutls.c (Qgnutls_dll): Define.
1174 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1175 (gnutls_*): Declare function pointers.
1176 (init_gnutls_functions): New function to initialize function pointers.
1177 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1178 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1179 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1180 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1181 (emacs_gnutls_write, emacs_gnutls_read)
1182 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1183 (Fgnutls_available_p): New function.
1184 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1185 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1186 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1187
1188 * image.c: Include w32.h.
1189 (Vimage_type_cache): Delete.
1190 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1191 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1192 (w32_delayed_load): Move to w32.c.
1193
1194 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1195
1196 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1197 (w32_delayed_load): Move from image.c. When loading a library, record
1198 its filename in the :loaded-from property of the library id.
1199 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1200 Initialize and staticpro them.
1201 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1202
1203 * process.c: Include lisp.h before w32.h, not after.
1204 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1205 instead of gnutls_record_check_pending.
1206
1207 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1208
ff4de4aa
TZ
12092011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1210
1211 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1212 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1213 as passed in.
1214
abe95abb
JD
12152011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1216
1217 * xterm.c (x_set_frame_alpha): Do not set property on anything
1218 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1219
e16e55d4
JB
12202011-05-02 Juanma Barranquero <lekktu@gmail.com>
1221
1222 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1223
bafcf6a5
JB
12242011-05-02 Juanma Barranquero <lekktu@gmail.com>
1225
1226 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1227 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1228 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1229 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1230 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1231 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1232 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1233 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1234 (Qgnutls_bootprop_callbacks_verify): Make static.
1235
e7a6747f
AS
12362011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1237
19ed11ba
AS
1238 * callproc.c: Indentation fixup.
1239
e7a6747f 1240 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1241 (wait_for_termination, interruptible_wait_for_termination):
1242 Move after wait_for_termination_1.
e7a6747f 1243
1ef14cb4
LMI
12442011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1245
1246 * sysdep.c (interruptible_wait_for_termination): New function
1247 which is like wait_for_termination, but allows keyboard
1248 interruptions.
1249
1250 * callproc.c (Fcall_process): Add (:file "file") as an option for
1251 the STDOUT buffer.
1252 (Fcall_process_region): Ditto.
1253
330d880c
EZ
12542011-04-30 Eli Zaretskii <eliz@gnu.org>
1255
8db90b73
EZ
1256 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1257 rather than `XVECTOR (FOO)->size'.
1258
330d880c
EZ
1259 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1260 inttypes.h, as a gnulib replacement is used if it not available in
1261 system headers.
1262
15cbd324
EZ
12632011-04-21 Eli Zaretskii <eliz@gnu.org>
1264
1265 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1266 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1267 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1268
1269 * coding.c (coding_alloc_by_realloc): Error out if destination
1270 will grow beyond MOST_POSITIVE_FIXNUM.
1271 (decode_coding_emacs_mule): Abort if there isn't enough place in
1272 charbuf for the composition carryover bytes. Reserve an extra
1273 space for up to 2 characters produced in a loop.
1274 (decode_coding_iso_2022): Abort if there isn't enough place in
1275 charbuf for the composition carryover bytes.
1276
12772011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1278
ae940cca
EZ
1279 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1280 aborting when %lld or %lll format is passed.
1281 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1282 %llo or %llx format is passed. (Bug#8545)
1283
03ab8921
EZ
1284 * window.c (window_scroll_line_based): Use a marker instead of
1285 simple variables to record original value of point. (Bug#7952)
1286
afda1437
EZ
1287 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1288 produced by %s or %c overflows available buffer space. (Bug#8545)
1289
f76dee0c
PE
12902011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1293 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1294
fdc5744d
JB
12952011-04-28 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1298
638f053a
JB
12992011-04-28 Juanma Barranquero <lekktu@gmail.com>
1300
1301 * keyboard.c (Qdelayed_warnings_hook): Define.
1302 (command_loop_1): Run `delayed-warnings-hook'
1303 if Vdelayed_warnings_list is non-nil.
1304 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1305 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1306
d178f871
EZ
13072011-04-28 Eli Zaretskii <eliz@gnu.org>
1308
1309 * doprnt.c (doprnt): Don't return value smaller than the buffer
1310 size if the message was truncated. (Bug#8545).
1311
b124fd93
JB
13122011-04-28 Juanma Barranquero <lekktu@gmail.com>
1313
1314 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1315 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1316
e810457d
PE
13172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1320
ea51cceb
JB
13212011-04-27 Juanma Barranquero <lekktu@gmail.com>
1322
1323 * makefile.w32-in: Update dependencies.
1324
94dcfacf
EZ
13252011-04-27 Eli Zaretskii <eliz@gnu.org>
1326
1327 Improve `doprnt' and its usage. (Bug#8545)
1328 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1329 `format_end'. Remove support for %l as a conversion specifier.
1330 Don't use xrealloc. Improve diagnostics when the %l size modifier
1331 is used. Update the commentary.
1332
1333 * eval.c (verror): Simplify calculation of size_t.
1334
1335 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1336 messages.
1337
f61f41d7
PE
13382011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1339
1340 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1341 change.
1342
96fb4434
PE
13432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1346 This makes this file independent of the recent pseudovector change.
1347
671875da 13482011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1349
69e9b5a3
PE
1350 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1351
b5f869a7 1352 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1353 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1354 Remove unused local.
c8926152 1355 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1356
841a1577 1357 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1358 GCC 4.6.0 optimizes based on type-based alias analysis.
1359 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1360 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1361 != &v->size, and therefore "v->size = 1; b->size = 2; return
1362 v->size;" must therefore return 1. This assumption is incorrect
1363 for Emacs, since it type-puns struct Lisp_Vector * with many other
1364 types. To fix this problem, this patch adds a new type struct
f904488f 1365 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1366 and pseudovectors, and helps optimizing compilers not get fooled
1367 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1368 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1369 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1370 the size member.
eab3844f
PE
1371 (XSETPVECTYPE): Rewrite in terms of new macro.
1372 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1373 This is a bit clearer, and further avoids the possibility of
1374 undesirable aliasing.
1375 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1376 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1377 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1378 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1379 (ASIZE): Now uses header.size rather than size.
1380 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1381 to avoid the hassle of writing XVECTOR (foo)->header.size.
1382 (struct vectorlike_header): New type.
eab3844f
PE
1383 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1384 object, to help avoid aliasing.
1385 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1386 (SUBRP): Likewise, since Lisp_Subr is a special case.
1387 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1388 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1389 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1390 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1391 changed to be "header.size" and "header.next".
1392 * buffer.h (struct buffer): Likewise.
1393 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1394 * frame.h (struct frame): Likewise.
1395 * process.h (struct Lisp_Process): Likewise.
1396 * termhooks.h (struct terminal): Likewise.
1397 * window.c (struct save_window_data, struct saved_window): Likewise.
1398 * window.h (struct window): Likewise.
1399 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1400 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1401 * buffer.c (init_buffer_once): Likewise.
1402 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1403 special case.
1404 * process.c (Fformat_network_address): Use local var for size,
1405 for brevity.
1406
0df1eac5
PE
1407 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1408
847ab9d1 1409 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1410 * data.c (atof): Remove decl; no longer used or needed.
1411 (digit_to_number): Move to lread.c.
1412 (Fstring_to_number): Use new string_to_number function, to be
1413 consistent with how the Lisp reader treats infinities and NaNs.
1414 Do not assume that floating-point numbers represent EMACS_INT
1415 without losing information; this is not true on most 64-bit hosts.
1416 Avoid double-rounding errors, by insisting on integers when
1417 parsing non-base-10 numbers, as the documentation specifies.
1418 * lisp.h (string_to_number): New decl, replacing ...
1419 (isfloat_string): Remove.
bc0a5c13 1420 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1421 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1422 appears to have been a coding error. Similarly, do not accept
1423 strings like +-1e0 as floating point numbers. Do not report
1424 overflow for integer overflows unless the base is not 10 which
1425 means we have no simple and reliable way to continue.
1426 Break out the floating-point parsing into a new
1427 function string_to_number, so that Fstring_to_number parses
1428 floating point numbers consistently with the Lisp reader.
04f2d78b 1429 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1430 (E_CHAR, EXP_INT): Remove, replacing with ...
1431 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1432 (string_to_number): New function, replacing isfloat_string.
1433 This function checks for valid syntax and produces the resulting
1434 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1435 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1436 so that overflow for non-base-10 numbers is reported only when
1437 there's no portable and simple way to convert to floating point.
452f4150 1438
67769ffc
PE
1439 * textprop.c (set_text_properties_1): Rewrite for clarity,
1440 and to avoid GCC warning about integer overflow.
1441
c20db43f
PE
1442 * intervals.h (struct interval): Use EMACS_INT for members
1443 where EMACS_UINT might cause problems. See
1444 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1445 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1446 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1447 All uses changed.
37aa2f85
PE
1448 (offset_intervals): Tell GCC not to worry about length overflow
1449 when negating a negative length.
c20db43f 1450
2538aa2f
PE
1451 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1452 (overrun_check_free): Likewise.
1453
f2d3008d
PE
1454 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1455 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1456 word size.
1457
ec8df744
PE
1458 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1459 (gnutls_make_error): Rename local to avoid shadowing.
1460 (gnutls_emacs_global_deinit): ifdef out; not used.
1461 (Fgnutls_boot): Use const for pointer to readonly storage.
1462 Comment out unused local. Fix pointer signedness problems.
1463
640ee02d
PE
1464 * lread.c (openp): Don't stuff size_t into an 'int'.
1465 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1466 about possible signed overflow.
1467
6048fb2a
PE
1468 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1469 (GDK_KEY_g): Don't define if already defined.
1470 (xg_prepare_tooltip): Avoid pointer signedness problem.
1471 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1472
fa3c87e1
PE
1473 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1474 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1475
2172544b
PE
1476 * xfns.c (Fx_window_property): Simplify a bit,
1477 to make a bit faster and to avoid GCC 4.6.0 warning.
1478 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1479
9b821a21
PE
1480 * fns.c (internal_equal): Don't assume size_t fits in int.
1481
3c616cfa
PE
1482 * alloc.c (compact_small_strings): Tighten assertion a little.
1483
c2982e87
PE
1484 Replace pEd with more-general pI, and fix some printf arg casts.
1485 * lisp.h (pI): New macro, generalizing old pEd macro to other
1486 conversion specifiers. For example, use "...%"pI"d..." rather
1487 than "...%"pEd"...".
1488 (pEd): Remove. All uses replaced with similar uses of pI.
1489 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1490 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1491 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1492 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1493 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1494 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1495 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1496 64-bit hosts.
1497 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1498 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1499 * print.c (safe_debug_print, print_object): Likewise.
1500 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1501 to int.
6f04d126
PE
1502 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1503 avoiding the 0 flag, which is not portable.
c2982e87
PE
1504 * process.c (Fmake_network_process): Use pI to avoid cast.
1505 * region-cache.c (pp_cache): Likewise.
1506 * xdisp.c (decode_mode_spec): Likewise.
1507 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1508 behavior on 64-bit hosts with printf arg.
6f04d126 1509 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1510 (x_stop_queuing_selection_requests): Likewise.
1511 (x_get_window_property): Don't truncate byte count to an 'int'
1512 when tracing.
0b432f21 1513
5e073ec7
PE
1514 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1515 here, since it parses constructs like leading '-' and spaces,
1516 which are not wanted; and it overflows with large numbers.
1517 Instead, simply match F[0-9]+, which is what is wanted anyway.
1518
36372bf9
PE
1519 * alloc.c: Remove unportable assumptions about struct layout.
1520 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1521 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1522 (allocate_vectorlike, make_pure_vector): Use the new macros,
1523 plus offsetof, to remove unportable assumptions about struct layout.
1524 These assumptions hold on all porting targets that I know of, but
1525 they are not guaranteed, they're easy to remove, and removing them
1526 makes further changes easier.
1527
0b432f21
PE
1528 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1529 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1530 (string_overrun_cookie): Now const. Use initializers that
1531 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1532 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1533 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1534 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1535 multiple of sizeof (EMACS_INT); it need not be, if
1536 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1537 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1538
895009e1
JB
15392011-04-26 Juanma Barranquero <lekktu@gmail.com>
1540
1541 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1542
6a7a1b0b
TZ
15432011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1544
1545 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1546 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1547 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1548
841a1577 15492011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1550
1551 * lisp.h (Qdebug): List symbol.
895009e1 1552 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1553 * keyboard.c (debug-on-event): New variable.
1554 (handle_user_signal): Break into debugger when debug-on-event
1555 matches the current signal symbol.
1556
f2d3ba6f
DN
15572011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1558
1559 * alloc.c (check_sblock, check_string_bytes)
1560 (check_string_free_list): Convert to standard C.
1561
42ce4c63
TZ
15622011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1563
1564 * w32.c (emacs_gnutls_push): Fix typo.
1565
825cd63c
EZ
15662011-04-25 Eli Zaretskii <eliz@gnu.org>
1567
fb11d64d
EZ
1568 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1569 "cast to pointer from integer of different size".
1570
825cd63c
EZ
1571 Improve doprnt and its use in verror. (Bug#8545)
1572 * doprnt.c (doprnt): Document the set of format control sequences
1573 supported by the function. Use SAFE_ALLOCA instead of always
1574 using `alloca'.
1575
1576 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1577 is one byte too soon. Don't use xrealloc; instead xfree and
1578 xmalloc anew.
1579
e061a11b
TZ
15802011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1581
1582 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1583 callbacks stage.
1584
1585 * gnutls.c: Renamed global_initialized to
1586 gnutls_global_initialized. Added internals for the
1587 :verify-hostname-error, :verify-error, and :verify-flags
1588 parameters of `gnutls-boot' and documented those parameters in the
1589 docstring. Start callback support.
1590 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1591 unless a fatal error occured. Call gnutls_alert_send_appropriate
1592 on error. Return error code.
1593 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1594 (emacs_gnutls_read): Likewise.
1595 (Fgnutls_boot): Return handshake error code.
1596 (emacs_gnutls_handle_error): New function.
1597 (wsaerror_to_errno): Likewise.
1598
1599 * w32.h (emacs_gnutls_pull): Add prototype.
1600 (emacs_gnutls_push): Likewise.
1601
1602 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1603 (emacs_gnutls_push): Likewise.
1604
16052011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1606
1607 * process.c (wait_reading_process_output): Check if GnuTLS
1608 buffered some data internally if no FDs are set for TLS
1609 connections.
1610
1611 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1612 (LIBS): Link to USER_LIBS.
1613 ($(BLD)/gnutls.$(0)): New target.
1614
fa6996bc
EZ
16152011-04-24 Eli Zaretskii <eliz@gnu.org>
1616
eb35682e
EZ
1617 * xdisp.c (handle_single_display_spec): Rename the
1618 display_replaced_before_p argument into display_replaced_p, to
1619 make it consistent with the commentary. Fix typos in the
1620 commentary.
1621
e2ad650c
EZ
1622 * textprop.c (syms_of_textprop): Remove dead code.
1623 (copy_text_properties): Delete obsolete commentary about an
1624 interface that was deleted long ago. Fix typos in the description
1625 of arguments.
1626
1b2de274
EZ
1627 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1628 to changes in oldXMenu/XMenu.h from 2011-04-16.
1629 <menu_help_message, prev_menu_help_message>: Constify.
1630 (IT_menu_make_room): menu->help_text is now `const char **';
1631 adjust.
1632
1633 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1634 to changes in oldXMenu/XMenu.h from 2011-04-16.
1635 (struct XMenu): Declare `help_text' `const char **'.
1636
1637 * xfaces.c <Qunspecified>: Make extern again.
1638
1639 * syntax.c: Include sys/types.h before including regex.h, as
1640 required by Posix.
1641
762b15be
EZ
1642 * doc.c (get_doc_string): Improve the format passed to `error'.
1643
1644 * doprnt.c (doprnt): Improve commentary.
1645
1646 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1647
1648 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1649 them with etags.
1650
f1052e5d
EZ
1651 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1652 changes in globals.h immediately force recompilation.
762b15be
EZ
1653 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1654 $(CURDIR)/s/ms-w32.h.
1655 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1656
fa6996bc
EZ
1657 * character.c (Fchar_direction): Function deleted.
1658 (syms_of_character): Don't defsubr it.
1659 <char-direction-table>: Deleted.
1660
e6c3da20
EZ
16612011-04-23 Eli Zaretskii <eliz@gnu.org>
1662
1663 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1664 * doprnt.c: Include limits.h.
1665 (SIZE_MAX): New macro.
04f2d78b
CB
1666 (doprnt): Return a size_t value. 2nd arg is now size_t.
1667 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1668 Improve overflow protection. Support `l' modifier for integer
1669 conversions. Support %l conversion. Don't assume an EMACS_INT
1670 argument for integer conversions and for %c.
1671
1672 * lisp.h (doprnt): Restore prototype.
1673
1674 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1675 $(SRC)/character.h.
1676
1677 * Makefile.in (base_obj): Add back doprnt.o.
1678
1679 * deps.mk (doprnt.o): Add back prerequisites.
1680 (callint.o): Depend on character.h.
1681
1682 * eval.c (internal_lisp_condition_case): Include the handler
1683 representation in the error message.
1684 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1685 when breaking from the loop.
1686
1687 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1688
1689 * callint.c (Fcall_interactively): When displaying error message
1690 about invalid control letter, pass the character's codepoint, not
1691 a pointer to its multibyte form. Improve display of the character
1692 in octal and display also its hex code.
1693
1694 * character.c (char_string): Use %x to display the (unsigned)
1695 codepoint of an invalid character, to avoid displaying a bogus
1696 negative value.
1697
1698 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1699 `error', not SYMBOL_NAME itself.
1700
1701 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1702 character arguments to `error'.
1703
1704 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1705 to `error' in error message about FINAL_CHAR argument. Make sure
1706 FINAL_CHAR is a character, and use %c when it is passed as
1707 argument to `error'.
1708
4ffd0d6b 17092011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1710
1711 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1712
1713 * w32.c: Include <time.h>.
1714 (sys_localtime): New function.
1715
4ffd0d6b 17162011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1717
1718 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1719
4ffd0d6b 1720 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1721
4ffd0d6b 17222011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1723
4ffd0d6b
GM
1724 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1725 zombies (Bug#8467).
aac0c6e3 1726
04c56954
EZ
17272011-04-19 Eli Zaretskii <eliz@gnu.org>
1728
1729 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1730 gl_state.e_property when gl_state.object is Qt.
1731
1732 * insdel.c (make_gap_larger): Remove limitation of buffer size
1733 to <= INT_MAX.
1734
16a43933
CY
17352011-04-18 Chong Yidong <cyd@stupidchicken.com>
1736
1737 * xdisp.c (lookup_glyphless_char_display)
1738 (produce_glyphless_glyph): Handle cons cell entry in
1739 glyphless-char-display.
1740 (Vglyphless_char_display): Document it.
1741
1742 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1743 glyphless-char-display.
1744
4581706e
CY
17452011-04-17 Chong Yidong <cyd@stupidchicken.com>
1746
1747 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1748
1749 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1750
1751 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1752 definition for no-X builds.
1753
4887c6e2 17542011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1755
fd35b6f9
PE
1756 Static checks with GCC 4.6.0 and non-default toolkits.
1757
5c1ccb01
PE
1758 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1759
006c5daa
PE
1760 * process.c (keyboard_bit_set): Define only if SIGIO.
1761 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1762 (send_process): Repair possible setjmp clobbering.
1763
efc736d3
PE
1764 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1765
4e2fe2e6
PE
1766 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1767
f97334a2
PE
1768 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1769
4e75f29d
PE
1770 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1771 Define only if needed.
1772
90efadd1
PE
1773 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1774 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1775 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1776
3c647824
PE
1777 * dispextern.h (struct redisplay_interface): Rename param
1778 to avoid shadowing.
e264f262 1779 * termhooks.h (struct terminal): Likewise.
761383f4 1780 * xterm.c (xembed_send_message): Likewise.
3c647824 1781
b58c5c4a
PE
1782 * insdel.c (make_gap_smaller): Define only if
1783 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1784
cad59032
PE
1785 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1786 it.
1787
c339dc2e
PE
1788 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1789 so that we aren't warned about unused symbols.
1790
91a3e27b
PE
1791 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1792
399c71d3 1793 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1794
8ffc96f5
PE
1795 * xfns.c (x_real_positions): Mark locals as initialized.
1796
eef9bc79
PE
1797 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1798
098db9dd
PE
1799 * xterm.c: Fix problems found by static analysis with other toolkits.
1800 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1801 (x_dispatch_event): Declare static if USE_GTK, and
1802 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1803 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1804 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1805 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1806 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1807
eb18f6cc
PE
1808 * xmenu.c (menu_help_callback): Pointer type fixes.
1809 Use const pointers when pointing at readonly data. Avoid pointer
1810 signedness clashes.
1811 (FALSE): Remove unused macro.
1812 (update_frame_menubar): Remove unused decl.
1813
1fe72bf8
PE
1814 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1815
60d9e1db
PE
1816 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1817 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1818 (single_menu_item): Rename local to avoid shadowing.
1819
39261c26
PE
1820 * keyboard.c (make_lispy_event): Remove unused local var.
1821
018c5e19
PE
1822 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1823 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1824
63d2b86e
PE
1825 * bitmaps: Change bitmaps from unsigned char back to the X11
1826 compatible char. Avoid the old compiler warnings about
1827 out-of-range initializers by using, for example, '\xab' rather
1828 than 0xab.
1829
aefd87e1
PE
1830 * xgselect.c (xgselect_initialize): Check vs interface
1831 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1832
bf501fb9
PE
1833 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1834
e9829fdf
PE
1835 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1836 to read-only memory.
1837
1086c095
PE
1838 * fns.c (vector): Remove; this old hack is no longer needed.
1839
2baccd04 1840 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1841 Remove unused var.
dde42981 1842 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1843
72391843 1844 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1845
436c16df 1846 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1847 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1848 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1849
92bb796d 1850 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1851 (x_term_init): Remove local to avoid shadowing.
92bb796d 1852
764430a3 1853 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1854
1855 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1856 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1857
d1dfb56c
EZ
18582011-04-16 Eli Zaretskii <eliz@gnu.org>
1859
c4354cb4
EZ
1860 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1861
d1dfb56c
EZ
1862 Fix regex.c, syntax.c and friends for buffers > 2GB.
1863 * syntax.h (struct gl_state_s): Declare character position members
1864 EMACS_INT.
1865
1866 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1867
04f2d78b
CB
1868 * textprop.c (verify_interval_modification, interval_of):
1869 Declare arguments EMACS_INT.
d1dfb56c
EZ
1870
1871 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1872 EMACS_INT.
1873
1874 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1875
1876 * indent.c (Fvertical_motion): Local variable it_start is now
1877 EMACS_INT.
1878
1879 * regex.c (re_match, re_match_2, re_match_2_internal)
1880 (bcmp_translate, regcomp, regexec, print_double_string)
1881 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1882 (re_compile_pattern, re_exec): Declare arguments and local
1883 variables `size_t' and `ssize_t' and return values `regoff_t', as
1884 appropriate.
1885 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1886 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1887 <compile_stack_type>: `size' and `avail' are now `size_t'.
1888
1889 * regex.h <regoff_t>: Use ssize_t, not int.
1890 (re_search, re_search_2, re_match, re_match_2): Arguments that
1891 specify buffer/string position and length are now ssize_t and
1892 size_t. Return type is regoff_t.
1893
613052cd
BK
18942011-04-16 Ben Key <bkey76@gmail.com>
1895
1896 * nsfont.m: Fixed bugs in ns_get_family and
1897 ns_descriptor_to_entity that were caused by using free to
1898 deallocate memory blocks that were allocated by xmalloc (via
1899 xstrdup). This caused Emacs to crash when compiled with
1900 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1901 --enable-checking=xmallocoverrun). xfree is now used to
1902 deallocate these memory blocks.
1903
4170f62f 19042011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1905
71b41406
PE
1906 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1907
9587a89d
PE
1908 emacs_write: Accept and return EMACS_INT for sizes.
1909 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1910 et seq.
1911 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1912 Accept and return EMACS_INT.
1913 (emacs_gnutls_write): Return the number of bytes written on
1914 partial writes.
1915 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1916 (emacs_read, emacs_write): Remove check for negative size, as the
1917 Emacs source code has been audited now.
9587a89d
PE
1918 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1919 (emacs_read, emacs_write): Use it.
273a5f82
PE
1920 * process.c (send_process): Adjust to the new signatures of
1921 emacs_write and emacs_gnutls_write. Do not attempt to store
1922 a byte offset into an 'int'; it might overflow.
9587a89d 1923 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1924
3e047f51
PE
1925 * sound.c: Don't assume sizes fit in 'int'.
1926 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1927 Return EMACS_INT, not int.
3e047f51 1928 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1929 Accept EMACS_INT, not int.
1930 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1931 record read return values.
1932
cc39a9db
BK
19332011-04-15 Ben Key <bkey76@gmail.com>
1934
c9d0ec6d
JB
1935 * keyboard.c (Qundefined): Don't declare static since it is used
1936 in nsfns.m.
1937 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1938 static since they are used in nsfont.m.
cc39a9db 1939
6c60eb9f
SM
19402011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1941
1942 * process.c (Qprocessp): Don't declare static.
1943 * lisp.h (Qprocessp): Declare again.
1944
7990b61a
JB
19452011-04-15 Juanma Barranquero <lekktu@gmail.com>
1946
1947 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1948
5d4cb038
PE
19492011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1950
8bd7b830 1951 Improve C-level modularity by making more things 'static'.
cd64ea1d 1952
e3b27b31
PE
1953 Don't publish debugger-only interfaces to other modules.
1954 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1955 (verify_bytepos, count_markers): Move decls to the only modules
1956 that need them.
1957 * region-cache.h (pp_cache): Likewise.
1958 * window.h (check_all_windows): Likewise.
1959 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1960
5d4cb038
PE
1961 * sysdep.c (croak): Now static, if
1962 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1963 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1964
1965 * alloc.c (refill_memory_reserve): Now static if
1966 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1967 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1968
e87b6180
PE
1969 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1970 Define only if USE_LUCID.
1971
ac64929e
PE
1972 * xrdb.c (x_customization_string, x_rm_string): Now static.
1973
6f37259d
PE
1974 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1975 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1976
1683e3ab
PE
1977 * xdisp.c (draw_row_with_mouse_face): Now static.
1978 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1979
de9c2632
PE
1980 * window.h (check_all_windows): Mark externally visible.
1981
2b96acb7
PE
1982 * window.c (window_deletion_count): Now static.
1983
1984 * undo.c: Make symbols static if they're not exported.
1985 (last_undo_buffer, last_boundary_position, pending_boundary):
1986 Now static.
1987
50436f33
PE
1988 * textprop.c (interval_insert_behind_hooks): Now static.
1989 (interval_insert_in_front_hooks): Likewise.
1990
64520e5c
PE
1991 * term.c: Make symbols static if they're not exported.
1992 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1993 (max_frame_lines, tty_set_terminal_modes):
1994 (tty_reset_terminal_modes, tty_turn_off_highlight):
1995 (get_tty_terminal): Now static.
1996 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1997 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1998 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1999 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2000 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2001
1fa53021
PE
2002 * sysdep.c: Make symbols static if they're not exported.
2003 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2004 Now static.
2005 (sigprocmask_set, full_mask): Remove; unused.
2006 (wait_debugging): Mark as visible.
2007 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2008 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2009
d4b43b22
PE
2010 * syntax.c (syntax_temp): Define only if !__GNUC__.
2011
b7c513d0
PE
2012 * sound.c (current_sound_device, current_sound): Now static.
2013
989b29ad
PE
2014 * search.c (searchbufs, searchbuf_head): Now static.
2015
13a55a78
PE
2016 * scroll.c (scroll_cost): Remove; unused.
2017 * dispextern.h (scroll_cost): Remove decl.
2018
de68a1fc
PE
2019 * region-cache.h (pp_cache): Mark as externally visible.
2020
40ccffa6
PE
2021 * process.c: Make symbols static if they're not exported.
2022 (process_tick, update_tick, create_process, chan_process):
2023 (Vprocess_alist, proc_buffered_char, datagram_access):
2024 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2025 (deactivate_process): Mark defn as static, as well as decl.
2026 * lisp.h (create_process): Remove decl.
2027 * process.h (chan_process, Vprocess_alist): Remove decls.
2028
ad64fc97
PE
2029 * print.c: Make symbols static if they're not exported.
2030 (print_depth, new_backquote_output, being_printed, print_buffer):
2031 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2032 (print_interval, print_number_index, initial_stderr_stream):
2033 Now static.
2034 * lisp.h (Fprinc): Remove decl.
2035 (debug_output_compilation_hack): Mark as externally visible.
2036
adddb265
PE
2037 * sysdep.c (croak): Move decl from here to syssignal.h.
2038 * syssignal.h (croak): Put it here, so the API can be checked when
2039 'croak' is called from dissociate_if_controlling_tty.
2040
1717ede2
PE
2041 * minibuf.c: Make symbols static if they're not exported.
2042 (minibuf_save_list, choose_minibuf_frame): Now static.
2043 * lisp.h (choose_minibuf_frame): Remove decl.
2044
fa5fb2bc
PE
2045 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2046
1e3890d1
PE
2047 * lread.c: Make symbols static if they're not exported.
2048 (read_objects, initial_obarray, oblookup_last_bucket_number):
2049 Now static.
2050 (make_symbol): Remove; unused.
2051 * lisp.h (initial_obarray, make_symbol): Remove decls.
2052
8a1414fa
PE
2053 * keyboard.c: Make symbols static if they're not exported.
2054 (single_kboard, recent_keys_index, total_keys, recent_keys):
2055 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2056 (this_single_command_key_start, echoing, last_auto_save):
2057 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2058 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2059 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2060 (Vlispy_mouse_stem, double_click_count):
2061 Now static.
2062 (force_auto_save_soon): Define only if SIGDANGER.
2063 (ignore_mouse_drag_p): Now static if
2064 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2065 (print_help): Remove; unused.
2066 (stop_character, last_timer_event): Mark as externally visible.
2067 * keyboard.h (ignore_mouse_drag_p): Declare only if
2068 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2069 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2070 * lisp.h (echoing): Remove decl.
2071 (force_auto_save_soon): Declare only if SIGDANGER.
2072 * xdisp.c (redisplay_window): Simplify code, to make it more
2073 obvious that ignore_mouse_drag_p is not accessed if !defined
2074 USE_GTK && !defined HAVE_NS.
2075
93ea6e8f
PE
2076 * intervals.c: Make symbols static if they're not exported.
2077 (merge_properties_sticky, merge_interval_right, delete_interval):
2078 Now static.
2079 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2080
77382fcc
PE
2081 * insdel.c: Make symbols static if they're not exported.
2082 However, leave prepare_to_modify_buffer alone. It's never
2083 called from outside this function, but that appears to be a bug.
2084 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2085 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2086 (adjust_after_replace_noundo): Remove; unused.
2087 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2088 (signal_before_change): Remove decls.
77382fcc 2089
9306c32e
PE
2090 * indent.c (val_compute_motion, val_vmotion): Now static.
2091
cd44d2eb
PE
2092 * image.c: Make symbols static if they're not exported.
2093 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2094 if USE_GTK.
2095 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2096 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2097
ad9a7a06
PE
2098 * fringe.c (standard_bitmaps): Now static.
2099 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2100
81626931
PE
2101 * frame.c: Make symbols static if they're not exported.
2102 (x_report_frame_params, make_terminal_frame): Now static.
2103 (get_frame_param): Now static, unless HAVE_NS.
2104 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2105 (x_get_resource_string): Remove; not used.
2106 * frame.h (make_terminal_frame, x_report_frame_params):
2107 (x_get_resource_string); Remove decls.
2108 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2109 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2110
239f9db9
PE
2111 * font.c, fontset.c: Make symbols static if they're not exported.
2112 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2113 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2114 * font.c (font_close_object): Now static.
2115 * font.h (font_close_object): Remove.
2116 * fontset.c (FONTSET_OBJLIST): Remove.
2117 (free_realized_fontset) #if-0 the body, which does nothing.
2118 (face_suitable_for_char_p): #if-0, as it's never called.
2119 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2120 * xfaces.c (face_at_string_position):
2121 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2122 since 0 is always ASCII.
2123
dfcf3579
PE
2124 * fns.c (weak_hash_tables): Now static.
2125
5045092b
PE
2126 * fileio.c: Make symbols static if they're not exported.
2127 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2128 (Vwrite_region_annotation_buffers): Now static.
2129
57a96f5c
PE
2130 * eval.c: Make symbols static if they're not exported.
2131 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2132 * lisp.h (backtrace_list): Remove decl.
2133
35f08c38
PE
2134 * emacs.c: Make symbols static if they're not exported.
2135 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2136 (fatal_error_code, fatal_error_signal_hook, standard_args):
2137 Now static.
2138 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2139 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2140 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2141 * lisp.h (fatal_error_signal_hook): Remove decl.
2142 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2143
f44bd759
PE
2144 * editfns.c: Move a (normally-unused) function to its only use.
2145 * editfns.c, lisp.h (get_operating_system_release): Remove.
2146 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2147 worth the hassle of breaking this out.
2148
b532497d
PE
2149 * xterm.c: Make symbols static if they're not exported.
2150 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2151 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2152 (x_destroy_window, x_delete_display):
2153 Now static.
2154 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2155 (x_mouse_leave): Remove; unused.
2156 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2157 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2158 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2159 Remove decls.
2160 (x_mouse_leave): Declare only if WINDOWSNT.
2161 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2162 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2163 USE_X_TOOLKIT.
2164
1675728f
PE
2165 * ftxfont.c: Make symbols static if they're not exported.
2166 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2167 HAVE_FREETYPE.
2168 * font.h (ftxfont_driver): Likewise.
2169
e4cebfca
PE
2170 * xfns.c: Make symbols static if they're not exported.
2171 (x_last_font_name, x_display_info_for_name):
2172 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2173 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2174 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2175 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2176 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2177 (last_show_tip_args): Now static.
2178 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2179 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2180 (x_screen_planes): Remove; unused.
2181 * dispextern.h (x_screen_planes): Remove decl.
2182
5bf46f05
PE
2183 * dispnew.c: Make symbols static if they're not exported.
2184 * dispextern.h (redraw_garbaged_frames, scrolling):
2185 (increment_row_positions): Remove.
2186 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2187 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2188 Now static.
2189 (redraw_garbaged_frames): Remove; unused.
2190
435f4c28
PE
2191 * xfaces.c: Make symbols static if they're not exported.
2192 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2193 Remove decls.
2194 * xterm.h (defined_color): Remove decls.
2195 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2196 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2197 (menu_face_changed_default, defined_color, free_realized_face):
2198 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2199 (ascii_face_of_lisp_face): Remove; unused.
2200
8524aef3
PE
2201 * xdisp.c: Make symbols static if they're not exported.
2202 * dispextern.h (scratch_glyph_row, window_box_edges):
2203 (glyph_to_pixel_coords, set_cursor_from_row):
2204 (get_next_display_element, set_iterator_to_next):
2205 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2206 (show_mouse_face): Remove decls
2207 * frame.h (message_buf_print): Likewise.
2208 * lisp.h (pop_message, set_message, check_point_in_composition):
2209 Likewise.
2210 * xterm.h (set_vertical_scroll_bar): Likewise.
2211 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2212 (message_buf_print, scratch_glyph_row, displayed_buffer):
2213 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2214 (get_next_display_element, show_mouse_face, window_box_edges):
2215 (frame_to_window_pixel_xy, check_point_in_composition):
2216 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2217 (glyph_to_pixel_coords): Remove; unused.
2218
16390cd2
PE
2219 * dired.c (file_name_completion): Now static.
2220
2221 * dbusbind.c (xd_in_read_queued_messages): Now static.
2222
a25f4dfa
PE
2223 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2224 * data.c (circular_list_error): Remove.
2225
14a9c8df
PE
2226 * commands.h (last_point_position, last_point_position_buffer):
2227 (last_point_position_window): Remove decls.
2228 * keyboard.c: Make these variables static.
2229
04f2d78b
CB
2230 * coding.h (coding, code_convert_region, encode_coding_gap):
2231 Remove decls.
74ab6df5
PE
2232 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2233 (iso_code_class, detect_coding, code_convert_region): Now static.
2234 (encode_coding_gap): Remove; unused.
2235
38dfbee1
PE
2236 * chartab.c (chartab_chars, chartab_bits): Now static.
2237
a2cb4e63
PE
2238 * charset.h (charset_iso_8859_1): Remove decl.
2239 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2240 Now static.
2241
127198fd
PE
2242 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2243 * ccl.c (Vccl_program_table): Now static.
2244 (check_ccl_update): Remove; unused.
2245
d85b608f
PE
2246 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2247 * category.h: ... from here.
2248 * category.c (check_category_table, set_category_set): Now static.
2249
31cd66f3
PE
2250 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2251 * lisp.h: Remove these decls.
2252
c358e587
PE
2253 * buffer.c (buffer_count): Remove unused var.
2254
e78aecca
PE
2255 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2256 so that it's not optimized away.
2257 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2258 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2259 exported only to the debugger.
2260
e192d7d3 2261 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2262 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2263
92470028
PE
2264 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2265 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2266 was inaccessible from Lisp.
2267 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2268 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2269
244ed907
PE
2270 alloc.c: Import and export fewer symbols, and remove unused items.
2271 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2272 is defined.
2273 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2274 it's not optimized away by whole-program optimization.
2275 (message_enable_multibyte, free_misc): Remove.
2276 (catchlist, handlerlist, mark_backtrace):
2277 Declare only if BYTE_MARK_STACK.
2278 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2279 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2280 (message_enable_multibyte): Remove decl.
2281 (free_misc, interval_free_list, float_block, float_block_index):
2282 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2283 (cons_free_list, last_marked_index):
2284 Now static.
2285 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2286 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2287 (mark_backtrace): Define only if BYTE_MARK_STACK.
2288 * xdisp.c (message_enable_multibyte): Now static.
2289
61c2b50e 2290 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2291 This makes it easier for human readers (and static analyzers)
2292 to see whether these variables are used from other modules.
2293 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2294 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2295 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2296 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2297 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2298 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2299 * xmenu.c, xselect.c:
2300 Declare Q* vars static if they are not used in other modules.
2301 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2302 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2303 Remove decls of unexported vars.
2304 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2305
95c82688
PE
2306 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2307
16a97296
PE
2308 Make Emacs functions such as Fatom 'static' by default.
2309 This makes it easier for human readers (and static analyzers)
2310 to see whether these functions can be called from other modules.
2311 DEFUN now defines a static function. To make the function external
2312 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2313 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2314 (Finit_image_library):
16a97296
PE
2315 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2316 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2317 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2318 Remove decls, since these functions are now static.
2319 (Funintern, Fget_internal_run_time): New decls, since these functions
2320 were already external.
95c82688 2321
16a97296
PE
2322 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2323 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2324 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2325 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2326 * keyboard.c, keymap.c, lread.c:
2327 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2328 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2329 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2330 Mark functions with DEFUE instead of DEFUN,
2331 if they are used in other modules.
2332 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2333 decls for now-static functions.
2334 * buffer.h (Fdelete_overlay): Remove decl.
2335 * callproc.c (Fgetenv_internal): Mark as internal.
2336 * composite.c (Fremove_list_of_text_properties): Remove decl.
2337 (Fcomposition_get_gstring): New forward static decl.
2338 * composite.h (Fcomposite_get_gstring): Remove decl.
2339 * dired.c (Ffile_attributes): New forward static decl.
2340 * doc.c (Fdocumntation_property): New forward static decl.
2341 * eval.c (Ffetch_bytecode): New forward static decl.
2342 (Funintern): Remove extern decl; now in .h file where it belongs.
2343 * fileio.c (Fmake_symbolic_link): New forward static decl.
2344 * image.c (Finit_image_library): New forward static decl.
2345 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2346 * intervals.h (Fprevious_property_change):
2347 (Fremove_list_of_text_properties): Remove decls.
2348 * keyboard.c (Fthis_command_keys): Remove decl.
2349 (Fcommand_execute): New forward static decl.
2350 * keymap.c (Flookup_key): New forward static decl.
2351 (Fcopy_keymap): Now static.
2352 * keymap.h (Flookup_key): Remove decl.
2353 * process.c (Fget_process): New forward static decl.
2354 (Fprocess_datagram_address): Mark as internal.
2355 * syntax.c (Fsyntax_table_p): New forward static decl.
2356 (skip_chars): Remove duplicate decl.
2357 * textprop.c (Fprevious_property_change): New forward static decl.
2358 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2359 Now internal.
2360 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2361 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2362
785bbd42
PE
2363 * editfns.c (Fformat): Remove unreachable code.
2364
8b913b57
AS
23652011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2366
2367 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2368 change. (Bug#8496)
2369
a6744a35
EZ
23702011-04-13 Eli Zaretskii <eliz@gnu.org>
2371
2372 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2373 when at ZV. (Bug#8487)
2374
e7974947
AS
23752011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2376
baad03f0
AS
2377 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2378 (Bug#8437)
2379 * keyboard.c (parse_tool_bar_item): Likewise.
2380 * sound.c (sound_cleanup, alsa_close): Likewise.
2381 * termcap.c (tgetent): Likewise.
2382 * xfns.c (x_default_font_parameter): Likewise.
2383 * xsettings.c (read_and_apply_settings): Likewise.
2384
e7974947
AS
2385 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2386 (overrun_check_free): Protoize.
2387
28272684
PE
23882011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2391 since callers should never pass a negative size.
2392 Change the signature to match that of plain 'read' and 'write'; see
2393 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2394 * lisp.h: Update prototypes of emacs_write and emacs_read.
2395
11997c76
EZ
23962011-04-11 Eli Zaretskii <eliz@gnu.org>
2397
2398 * xdisp.c (redisplay_window): Don't try to determine the character
2399 position of the scroll margin if the window start point w->startp
e896f03c 2400 is outside the buffer's accessible region. (Bug#8468)
11997c76 2401
8a2cbd72
EZ
24022011-04-10 Eli Zaretskii <eliz@gnu.org>
2403
2404 Fix write-region and its subroutines for buffers > 2GB.
2405 * fileio.c (a_write, e_write): Modify declaration of arguments and
2406 local variables to support buffers larger than 2GB.
2407 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2408
2409 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2410 argument, local variables, and return value.
2411
2412 * lisp.h: Update prototypes of emacs_write and emacs_read.
2413
2414 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2415
4073e537 24162011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2417
1ebfdcb6
PE
2418 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2419
b2ded58d
PE
2420 Fix more problems found by GCC 4.6.0's static checks.
2421
7d66342c
PE
2422 * xdisp.c (vmessage): Use a better test for character truncation.
2423
bbf47d44
PE
2424 * charset.c (load_charset_map): <, not <=, for optimization,
2425 and to avoid potential problems with integer overflow.
9248994d 2426 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2427 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2428 * editfns.c (Fformat): Likewise.
1e69125e 2429 * syntax.c (skip_chars): Likewise.
3befa583 2430
e3019616
PE
2431 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2432 This also lets GCC 4.6.0 generate slightly better loop code.
2433
becfa255
PE
2434 * callint.c (Fcall_interactively): <, not <=, for optimization.
2435 (Fcall_interactively): Count the number of arguments produced,
2436 not the number of arguments given. This is simpler and lets GCC
2437 4.6.0 generate slightly better code.
2438
dae0cd48
PE
2439 * ftfont.c: Distingish more carefully between FcChar8 and char.
2440 The previous code passed unsigned char * to a functions like
2441 strlen and xstrcasecmp that expect char *, which does not
2442 conform to the C standard.
2443 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2444 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2445 char * when the C standard requires it.
2446
76032d70
PE
2447 * keyboard.c (read_char): Remove unused var.
2448
eb3f1cc8
PE
2449 * eval.c: Port to Windows vsnprintf (Bug#8435).
2450 Include <limits.h>.
2451 (SIZE_MAX): Define if the headers do not.
2452 (verror): Do not give up if vsnprintf returns a negative count.
2453 Instead, grow the buffer. This ports to Windows vsnprintf, which
2454 does not conform to C99. Problem reported by Eli Zaretskii.
2455 Also, simplify the allocation scheme, by avoiding the need for
2456 calling realloc, and removing the ALLOCATED variable.
2457
70476b54
PE
2458 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2459
12020a9e
PE
2460 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2461 But keep the doprint source code for now, as we might revamp it
2462 and use it again (Bug#8435).
ea6c7ae6
PE
2463 * lisp.h (doprnt): Remove.
2464 * Makefile.in (base_obj): Remove doprnt.o.
2465 * deps.mk (doprnt.o): Remove.
2466
5fdb398c
PE
2467 error: Print 32- and 64-bit integers portably (Bug#8435).
2468 Without this change, on typical 64-bit hosts error ("...%d...", N)
2469 was used to print both 32- and 64-bit integers N, which relied on
2470 undefined behavior.
2471 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2472 New macro.
2473 * lisp.h (error, verror): Mark as printf-like functions.
2474 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2475 Report overflow in size calculations when allocating printf buffer.
2476 Do not truncate output string at its first null byte.
2477 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2478 Truncate the output at a character boundary, since vsnprintf does not
2479 do that.
2480 * charset.c (check_iso_charset_parameter): Convert internal
2481 character to string before calling 'error', since %c now has the
2482 printf meaning.
2483 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2484 overflow when computing char to be passed to 'error'. Do not
2485 pass Lisp_Object to 'error'; pass the integer instead.
2486 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2487 formatted with plain %d.
2488
b189fa66
PE
2489 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2490
bff87ef0
PE
2491 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2492
7e2cac20
PE
2493 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2494
ce4d90b5
PE
2495 * xterm.c (x_catch_errors): Remove duplicate declaration.
2496
266c9547
PE
2497 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2498
79c49ad2
PE
2499 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2500
368f4090
JM
25012011-04-10 Jim Meyering <meyering@redhat.com>
2502
2503 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2504 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2505 return ssize_t not "int", and use size_t as the buffer length.
2506 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2507 * gnutls.h: Update declarations.
2508 * process.c (read_process_output): Use ssize_t, to match.
2509 (send_process): Likewise.
2510
a32d4040
CY
25112011-04-09 Chong Yidong <cyd@stupidchicken.com>
2512
2513 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2514
8546720e 25152011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2516
04f2d78b
CB
2517 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2518 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2519
8546720e
GM
2520 * xterm.c (handle_one_xevent):
2521 * xmenu.c (create_and_show_popup_menu):
2522 * xselect.c (x_decline_selection_request)
2523 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2524
0a2f5c1a 25252011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2526
2527 Fix some uses of `int' instead of EMACS_INT.
2528 * search.c (string_match_1, fast_string_match)
2529 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2530 (scan_buffer, find_next_newline_no_quit)
2531 (find_before_next_newline, search_command, Freplace_match)
2532 (Fmatch_data): Make some `int' variables be EMACS_INT.
2533
2534 * xdisp.c (display_count_lines): 3rd argument and return value now
2535 EMACS_INT. All callers changed.
2536 (pint2hrstr): Last argument is now EMACS_INT.
2537
2538 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2539 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2540 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2541 (decode_coding_utf_16, decode_coding_emacs_mule)
2542 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2543 (decode_coding_ccl, decode_coding_charset)
2544 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2545 (decode_coding_iso_2022, decode_coding_emacs_mule)
2546 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2547 <char_offset, last_offset>: Declare EMACS_INT.
2548 (encode_coding_utf_8, encode_coding_utf_16)
2549 (encode_coding_emacs_mule, encode_invocation_designation)
2550 (encode_designation_at_bol, encode_coding_iso_2022)
2551 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2552 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2553 Declare EMACS_INT.
2554 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2555 (encode_invocation_designation): Last argument P_NCHARS is now
2556 EMACS_INT.
2557 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2558 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2559
2560 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2561 All users changed.
2562
2563 * ccl.c (Fccl_execute_on_string): Declare some variables
2564 EMACS_INT.
2565
8546720e 25662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2567
2568 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2569
4e19a977
CS
25702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2571
2572 * process.c (Fformat_network_address): Doc fix.
2573
87302331
R
25742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2575
2576 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2577
cbb59342
CY
25782011-04-08 Chong Yidong <cyd@stupidchicken.com>
2579
2580 * keyboard.c (read_char): Call Lisp function help-form-show,
2581 instead of using internal_with_output_to_temp_buffer.
2582 (Qhelp_form_show): New var.
e0d38eeb 2583 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2584
2585 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2586
2587 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2588
e67a13ab
CY
25892011-04-06 Chong Yidong <cyd@stupidchicken.com>
2590
04f2d78b
CB
2591 * process.c (Flist_processes): Remove to Lisp.
2592 (list_processes_1): Delete.
e67a13ab 2593
973f782d
EZ
25942011-04-06 Eli Zaretskii <eliz@gnu.org>
2595
7c106b1e
EZ
2596 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2597
973f782d
EZ
2598 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2599
41cf7d1a 26002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2601
ca23cc88
PE
2602 Fix more problems found by GCC 4.6.0's static checks.
2603
f390e2d5
PE
2604 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2605
42eea0d0
PE
2606 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2607
b69769da 2608 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2609
f9541e84
PE
2610 * xdisp.c (vmessage): Mark as a printf-like function.
2611
13841b55
PE
2612 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2613
c136c10f
PE
2614 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2615
5e2d4a30
PE
2616 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2617 printf-like functions.
2618 (tiff_load): Add casts to remove these marks before passing them
2619 to system-supplied API.
2620
583f48b9
PE
2621 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2622
b25d760e
PE
2623 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2624 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2625 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2626 directly, rather than having caller test rule sign. This avoids
2627 some unnecessary tests.
2628 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2629 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2630 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2631
bc7b6697 2632 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2633 (xfont_open): Avoid unnecessary tests.
bc7b6697 2634
27ccc379
PE
2635 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2636
dcd5c89a
PE
2637 * composite.h, composite.c (composition_gstring_put_cache):
2638 Use EMACS_INT, not int, for length.
2639
b13a45c6
PE
2640 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2641 breaking out part of COMPOSITION_DECODE_RULE.
2642 (COMPOSITION_DECODE_RULE): Use it.
2643 * composite.c (get_composition_id): Remove unused local vars,
2644 by using the new macro.
2645
1e792e4d
PE
2646 * textprop.c (set_text_properties_1): Change while to do-while,
2647 since the condition is always true at first.
2648
dc6c6455 2649 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2650 (interval_deletion_adjustment): Return unsigned value.
2651 All uses changed.
dc6c6455 2652
aba7731a
PE
2653 * process.c (list_processes_1, create_pty, read_process_output):
2654 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2655 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2656 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2657 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2658 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2659
fdfc4bf3
PE
2660 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2661
fca8fe46 2662 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2663 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2664
06a0259a 2665 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2666 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2667 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2668
e7b9e80f
PE
2669 * print.c (print_error_message): Avoid int overflow.
2670
56201685
PE
2671 * font.c (font_list_entities): Redo for clarity,
2672 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2673
78834453 2674 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2675 (font_score): Avoid potential overflow in diff calculation.
78834453 2676
0bc0b309 2677 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2678 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2679
e610eaca
PE
2680 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2681
b895abce
PE
2682 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2683 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2684 can always succeed if overflow has undefined behavior.
2685
1f1d9321 2686 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2687 (wordify): Omit three unnecessary tests.
1f1d9321 2688
c59478bc
PE
2689 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2690 All callers changed. This avoids the need for an unused var.
2691
79b73827
PE
2692 * casefiddle.c (casify_region): Remove var that is set but not used.
2693
a4db5dfe
PE
2694 * dired.c (file_name_completion): Remove var that is set but not used.
2695
43aae36e
PE
2696 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2697
2a47c44d 2698 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2699 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2700
a37c69bf
PE
2701 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2702 Check for integer overflow on size calculations.
2703
328ab8e7
PE
2704 * buffer.c (Fprevious_overlay_change): Remove var that is set
2705 but not used.
2706
e5a2a5cb
PE
2707 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2708 Remove vars that are set but not used.
8d84a6eb 2709 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2710 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2711
a60e5f68
PE
2712 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2713
f661cb61 2714 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2715 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2716
f0397f5a
PE
2717 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2718 that are set but not used.
2719
8664db06 2720 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2721 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2722
6abdaa4a
PE
2723 * xselect.c (x_get_local_selection, x_handle_property_notify):
2724 Remove vars that are set but not used.
2725
0ce7538d 2726 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2727 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2728
9ae848fc
PE
2729 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2730 Remove var that is set but not used.
0b918413
PE
2731 (scroll_bar_windows_size): Now size_t, not int.
2732 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2733 Check for overflow.
9ae848fc 2734
a5a62657
PE
2735 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2736 (map_tty_color) [!defined MSDOS]: Likewise.
2737
5c5cdd39
PE
2738 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2739
66ebf983
PE
2740 * coding.c: Remove vars that are set but not used.
2741 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2742 All callers changed.
2743 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2744 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2745 (decode_coding_charset): Remove vars that are set but not used.
2746
1be4d761
PE
2747 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2748 that is set but not used.
2749
47553fa8
PE
2750 * print.c (print_object): Remove var that is set but not used.
2751
1f7196bf 2752 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2753 The gnulib version avoids calling malloc in the usual case,
2754 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2755 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2756 * filelock.c (current_lock_owner): Likewise.
2757 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2758 * sysdep.c: Include allocator.h, careadlinkat.h.
2759 (emacs_no_realloc_allocator): New static constant.
2760 (emacs_readlink): New function.
fdb61804
PE
2761 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2762 ../lib/careadlinkat.h.
d1fdcab7 2763
f84c17c7
SM
27642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2765
2766 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2767 first non-nil return value).
2768
ef3862ad
JD
27692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2770
2771 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2772 if not defined (Bug#8403).
2773
376a7006
JB
27742011-04-02 Juanma Barranquero <lekktu@gmail.com>
2775
2776 * xdisp.c (display_count_lines): Remove parameter `start',
2777 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2778 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2779 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2780 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2781 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2782 and thereabouts. All callers changed.
2783 (get_per_char_metric): Remove parameter `f', unused since
2784 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2785
6ca3801d
JM
27862011-04-02 Jim Meyering <meyering@redhat.com>
2787
2788 do not dereference NULL upon failed strdup
2789 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2790 (ns_get_family): Likewise.
2791
d8e2b5ba
JB
27922011-04-02 Juanma Barranquero <lekktu@gmail.com>
2793
2794 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2795
8c74fcbd
JD
27962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2797
2798 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2799 later (Bug#8403).
2800
7200d79c
SM
28012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2802
03408648 2803 Add lexical binding.
7200d79c 2804
03408648
SM
2805 * window.c (Ftemp_output_buffer_show): New fun.
2806 (Fsave_window_excursion):
2807 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2808
2809 * lread.c (lisp_file_lexically_bound_p): New function.
2810 (Fload): Bind Qlexical_binding.
2811 (readevalloop): Remove `evalfun' arg.
2812 Bind Qinternal_interpreter_environment.
2813 (Feval_buffer): Bind Qlexical_binding.
2814 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2815 Mark as dynamic.
2816 (syms_of_lread): Declare `lexical-binding'.
2817
2818 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2819
2820 * keyboard.c (eval_dyn): New fun.
2821 (menu_item_eval_property): Use it.
ca105506
SM
2822
2823 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2824
03408648
SM
2825 * fns.c (concat, mapcar1): Accept byte-code-functions.
2826
2827 * eval.c (Fsetq): Handle lexical vars.
2828 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2829 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2830 (FletX, Flet): Obey lexical binding.
2831 (Fcommandp): Handle closures.
2832 (Feval): New `lexical' arg.
2833 (eval_sub): New function extracted from Feval. Use it almost
2834 everywhere where Feval was used. Look up vars in lexical env.
2835 Handle closures.
2836 (Ffunctionp): Move from subr.el.
2837 (Ffuncall): Handle closures.
2838 (apply_lambda): Remove `eval_flags'.
2839 (funcall_lambda): Handle closures and new byte-code-functions.
2840 (Fspecial_variable_p): New function.
2841 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2842 but without exporting it to Lisp.
23aba0ea 2843
23aba0ea 2844 * doc.c (Fdocumentation, store_function_docstring):
03408648 2845 * data.c (Finteractive_form): Handle closures.
23aba0ea 2846
03408648
SM
2847 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2848 interactive spec.
ba83908c 2849
04f2d78b
CB
2850 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2851 New byte-codes.
03408648
SM
2852 (exec_byte_code): New function extracted from Fbyte_code to handle new
2853 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2854
03408648 2855 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2856
03408648 2857 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2858
e2abce01
JB
28592011-03-31 Juanma Barranquero <lekktu@gmail.com>
2860
2861 * xdisp.c (redisplay_internal): Fix prototype.
2862
63696a73 28632011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2864
63696a73 2865 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2866 (try_scrolling): Use it when setting scroll_limit.
2867 Limit scrolling to 100 screen lines.
63696a73
EZ
2868 (redisplay_window): Even when falling back on "recentering",
2869 position point in the window according to scroll-conservatively,
2870 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2871
2872 (try_scrolling): When point is above the window, allow searching
2873 as far as scroll_max, or one screenful, to compute vertical
2874 distance from PT to the scroll margin position. This prevents
2875 try_scrolling from unnecessarily failing when
2876 scroll-conservatively is set to a value slightly larger than the
2877 window height. Clean up the case of PT below the margin at bottom
2878 of window: scroll_max can no longer be INT_MAX. When aggressive
2879 scrolling is in use, don't let point enter the opposite scroll
2880 margin as result of the scroll.
2881 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2882 threshold of 100 lines for never-recentering scrolling.
2883
e4cc2dfc
JB
28842011-03-31 Juanma Barranquero <lekktu@gmail.com>
2885
2886 * dispextern.h (move_it_by_lines):
2887 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2888 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2889 (message_log_check_duplicate): Remove parameters `prev_bol' and
2890 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2891 (redisplay_internal): Remove parameter `preserve_echo_area',
2892 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2893
2894 * indent.c (Fvertical_motion):
2895 * window.c (window_scroll_pixel_based, Frecenter):
2896 Don't pass `need_y_p' to `move_it_by_lines'.
2897
1c470562
SM
28982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2899
44f230aa
SM
2900 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2901 steal a few bits to be more compact.
2902 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2903 Remove unneeded casts.
2904
1c470562
SM
2905 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2906
888adce9
ZK
29072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2908
2909 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2910 binding" message (bug#7967).
2911
f838ed7b
PE
29122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2913
77861b95
PE
2914 Fix more problems found by GCC 4.6.0's static checks.
2915
de6dbc14
PE
2916 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2917 Remove unused local var.
2918
f838ed7b
PE
2919 * editfns.c (Fmessage_box): Remove unused local var.
2920
792c7b2b
PE
2921 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2922 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2923 Omit unused local vars.
c499e557 2924 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2925 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2926 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2927 Omit unused local var.
2928
ba0165e1
PE
2929 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2930 Don't assume string length fits in int.
32ad8845 2931 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2932 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2933
3c59b4c9
PE
2934 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2935 instead of alloca (Bug#8344).
2936
a3eed478 2937 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2938 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2939
eb4d412d
PE
2940 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2941
1658b401
PE
2942 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2943 concerns.
2944
2945 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2946
2947 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2948
9a2c6e05
PE
2949 * keyboard.c (syms_of_keyboard): Use the same style as later
2950 in this function when indexing through an array. This also
2951 works around GCC bug 48267.
2952
03d0a109
PE
2953 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2954
44f730c8
PE
2955 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2956
fe75f926
PE
2957 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2958 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2959
ffa8c828
PE
2960 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2961 This avoids undefined behavior on integer overflow, and is a bit
2962 more convenient anyway since it is compared to a size_t variable.
2963
c5101a77
PE
2964 Variadic C functions now count arguments with size_t, not int.
2965 This avoids an unnecessary limitation on 64-bit machines, which
2966 caused (substring ...) to crash on large vectors (Bug#8344).
2967 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2968 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2969 All variadic functions and their callers changed accordingly.
c5101a77
PE
2970 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2971 * data.c (arith_driver, float_arith_driver): Likewise.
2972 * editfns.c (general_insert_function): Likewise.
2973 * eval.c (struct backtrace.nargs, interactive_p)
2974 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2975 (funcall_lambda, mark_backtrace): Likewise.
2976 * fns.c (concat): Likewise.
2977 * frame.c (x_set_frame_parameters): Likewise.
2978 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2979 0 if not found, not -1. All callers changed.
2980
dd3f25f7
PE
2981 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2982 (stack_copy_size): Now size_t, not int.
2983 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2984
461c2ab9
JB
29852011-03-28 Juanma Barranquero <lekktu@gmail.com>
2986
2987 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2988 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2989 All callers changed.
2990
2991 * lisp.h (multibyte_char_to_unibyte):
2992 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2993 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2994 * character.h (CHAR_TO_BYTE8):
2995 * cmds.c (internal_self_insert):
2996 * editfns.c (general_insert_function):
2997 * keymap.c (push_key_description):
2998 * search.c (Freplace_match):
2999 * xdisp.c (message_dolog, set_message_1): All callers changed.
3000
f6d62986
SM
30012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3002
3003 * keyboard.c (safe_run_hook_funcall): New function.
3004 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3005 don't set the hook to nil, but remove the offending function instead.
3006 (Qcommand_hook_internal): Remove, unused.
3007 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3008 Vcommand_hook_internal.
3009
3010 * eval.c (enum run_hooks_condition): Remove.
3011 (funcall_nil, funcall_not): New functions.
3012 (run_hook_with_args): Call each function through a `funcall' argument.
3013 Remove `cond' argument, now redundant.
3014 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3015 (Frun_hook_with_args_until_failure): Adjust accordingly.
3016 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3017
1db5b1ad
JB
30182011-03-28 Juanma Barranquero <lekktu@gmail.com>
3019
3020 * dispextern.h (string_buffer_position): Remove declaration.
3021
3022 * print.c (strout): Remove parameter `multibyte', unused since
3023 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3024
3025 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3026 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3027 All callers changed.
3028
3029 * w32.c (_wsa_errlist): Use braces for struct initializers.
3030
3031 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3032 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3033 All callers changed.
3034 (string_buffer_position): Likewise. Also, make static (it's never
3035 used outside xdisp.c).
3036 (cursor_row_p): Remove parameter `w', unused since
3037 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3038 (decode_mode_spec): Remove parameter `precision', introduced during
3039 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3040 All callers changed.
3041
5ffb62aa
JD
30422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3043
3044 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3045
461c2ab9 30462011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3047
3048 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3049 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3050 (ns_update_auto_hide_menu_bar): New functions.
3051 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3052 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3053 ns_constrain_all_frames.
3054 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3055 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3056
5c380ffb
JD
30572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3058
3059 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3060
9af30bdf
GM
30612011-03-27 Glenn Morris <rgm@gnu.org>
3062
3063 * syssignal.h: Replace RETSIGTYPE with void.
3064 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3065 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3066 Replace SIGTYPE with void everywhere.
3067 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3068 * s/template.h (SIGTYPE): Remove commented out definition.
3069
e2abce01
JB
30702011-03-26 Eli Zaretskii <eliz@gnu.org>
3071
3072 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3073 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3074
f868cd8a
JB
30752011-03-26 Juanma Barranquero <lekktu@gmail.com>
3076
59eb0929
JB
3077 * w32.c (read_unc_volume): Use parameter `henum', instead of
3078 global variable `wget_enum_handle'.
3079
3080 * keymap.c (describe_vector): Remove parameters `indices' and
3081 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3082 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3083
f868cd8a
JB
3084 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3085
3086 * keyboard.c (timer_check): Remove parameter `do_it_now',
3087 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3088 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3089 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3090
3091 * keyboard.c (read_char):
3092 * w32menu.c (w32_menu_display_help):
3093 * xmenu.c (show_help_event, menu_help_callback):
3094 Adjust calls to `show_help_echo'.
3095
3096 * gtkutil.c (xg_maybe_add_timer):
3097 * keyboard.c (readable_events):
3098 * process.c (wait_reading_process_output):
3099 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3100
3101 * insdel.c (adjust_markers_gap_motion):
3102 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3103 (gap_left, gap_right): Don't call it.
3104
2ecf6fdb
CY
31052011-03-25 Chong Yidong <cyd@stupidchicken.com>
3106
3107 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3108 incurred during fontification.
3109
6b1f9ba4
JB
31102011-03-25 Juanma Barranquero <lekktu@gmail.com>
3111
3112 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3113 (DEFVAR_PER_BUFFER): Don't pass it.
3114
3115 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3116 (scrolling_window): Don't pass it.
3117
0f4a96b5
JB
31182011-03-25 Juanma Barranquero <lekktu@gmail.com>
3119
3120 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3121
3122 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3123 and `suffix'.
3124 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3125 of variables specific to SELinux and computation of `encoded_absname'.
3126
3127 * image.c (XPutPixel): Remove unused variable `height'.
3128
3129 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3130
3131 * unexw32.c (get_section_info): Remove unused variable `section'.
3132
3133 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3134 (system_process_attributes): Remove unused variable `sess'.
3135 (sys_read): Remove unused variable `err'.
3136
3137 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3138 (w32_wnd_proc): Remove unused variable `isdead'.
3139 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3140 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3141 (x_create_tip_frame): Remove unused variable `tem'.
3142
3143 * w32inevt.c (w32_console_read_socket):
3144 Remove unused variable `no_events'.
3145
3146 * w32term.c (x_draw_composite_glyph_string_foreground):
3147 Remove unused variable `width'.
3148
1149507c
JB
31492011-03-24 Juanma Barranquero <lekktu@gmail.com>
3150
3151 * w32term.c (x_set_glyph_string_clipping):
3152 Don't pass uninitialized region to CombineRgn.
3153
9c88f339
JB
31542011-03-23 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3157 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3158 (Fx_close_connection): Remove unused variable `i'.
3159
3160 * w32font.c (w32font_draw): Return number of glyphs.
3161 (w32font_open_internal): Remove unused variable `i'.
3162 (w32font_driver): Add missing initializer.
3163
3164 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3165 (fill_in_menu): Remove unused variable `items_added'.
3166
3167 * w32term.c (last_mouse_press_frame): Remove static global variable.
3168 (w32_clip_to_row): Remove unused variable `f'.
3169 (x_delete_terminal): Remove unused variable `i'.
3170
3171 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3172 (NOTHING): Remove unused static global variable.
3173 (uniscribe_check_otf): Remove unused variable `table'.
3174 (uniscribe_font_driver): Add missing initializers.
3175
dee091a3
JD
31762011-03-23 Julien Danjou <julien@danjou.info>
3177
3178 * term.c (Fsuspend_tty, Fresume_tty):
3179 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3180 * window.c (temp_output_buffer_show):
3181 * insdel.c (signal_before_change):
3182 * frame.c (Fhandle_switch_frame):
3183 * fileio.c (Fdo_auto_save):
3184 * emacs.c (Fkill_emacs):
3185 * editfns.c (save_excursion_restore):
3186 * cmds.c (internal_self_insert):
3187 * callint.c (Fcall_interactively):
3188 * buffer.c (Fkill_all_local_variables):
3189 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3190 Use Frun_hooks.
0f4a96b5 3191 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3192 unconditionnaly since it does the check itself.
3193
2c520ab5 31942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3195
c9c49752
PE
3196 Fix more problems found by GCC 4.5.2's static checks.
3197
8abc3f12
PE
3198 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3199 the first time through the loop, since we know p0 < p1 then.
3200 This also avoids a gcc -Wstrict-overflow warning.
3201
a2d26660
PE
3202 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3203 leading to a memory leak, possible in functions like
3204 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3205 of objects (Bug#8318).
a2d26660 3206
916c72e9
PE
3207 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3208 that could (at least in theory) be that large.
3209
19ab8a18
PE
3210 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3211 This is less likely to overflow, and avoids undefined behavior if
3212 overflow does occur. All callers changed. Use strtoul to scan
3213 for the unsigned long integer.
b7cbbd6f
PE
3214 (pint2hrstr): Simplify and tune code slightly.
3215 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3216
f0641eff
PE
3217 * scroll.c (do_scrolling): Work around GCC bug 48228.
3218 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3219
7f650bb9
PE
3220 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3221 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3222 (validate_x_resource_name): Simplify count usage.
3223 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3224
37dd57d1
PE
3225 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3226 fail (Bug#8306).
81e56e61 3227
699979fc 3228 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3229
401bf9b4
PE
3230 * process.c (Fmake_network_process): Use socklen_t, not int,
3231 where POSIX says socklen_t is required in portable programs.
3232 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3233 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3234 (Fmake_network_process, server_accept_connection):
3235 (wait_reading_process_output, read_process_output):
3236 Likewise.
3237
b93aacde
PE
3238 * process.c: Rename or move locals to avoid shadowing.
3239 (list_processes_1, Fmake_network_process):
3240 (read_process_output_error_handler, exec_sentinel_error_handler):
3241 Rename or move locals.
4dc343ee 3242 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3243 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3244 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3245 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3246 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3247
af8a867c 3248 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3249 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3250 Include tparam.h instead, since it declares them.
af8a867c
PE
3251 * cm.h (PC): Remove extern decl; tparam.h now does this.
3252 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3253 * terminfo.c: Include tparam.h, to check interfaces.
3254 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3255 (tparam): Adjust signature to match interface in tparam.h;
3256 this removes some undefined behavior. Check that outstring and len
3257 are zero, which they always are with Emacs.
3258 * tparam.h (PC, BC, UP): New extern decls.
3259
0248044d 3260 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3261 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3262
8ff096c1 3263 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3264 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3265 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3266 (ftfont_list): Remove unused local.
49eaafba
PE
3267 (get_adstyle_property, ftfont_pattern_entity):
3268 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3269 Rename locals to avoid shadowing.
8ff096c1 3270
e2be39f6
PE
3271 * xfont.c (xfont_list_family): Mark var as initialized.
3272
c9735e30
PE
3273 * xml.c (make_dom): Now static.
3274
8f5201ae
PE
3275 * composite.c (composition_compute_stop_pos): Rename local to
3276 avoid shadowing.
b246f932
PE
3277 (composition_reseat_it): Remove unused locals.
3278 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3279 (composition_update_it): Mark var as initialized.
11b61122
PE
3280 (find_automatic_composition): Mark vars as initialized,
3281 with a FIXME (Bug#8290).
8f5201ae 3282
760fbc2c
PE
3283 character.h: Rename locals to avoid shadowing.
3284 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3285 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3286 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3287 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3288 to avoid shadowing.
3289
ff08eb85
PE
3290 * textprop.c (property_change_between_p): Remove; unused.
3291
fc7bf025
PE
3292 * intervals.c (interval_start_pos): Now static.
3293
235d7abc
PE
3294 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3295
44f230aa
SM
3296 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3297 Rename locals to avoid shadowing.
3e7d6594 3298
50060332
PE
3299 * sound.c (wav_play, au_play, Fplay_sound_internal):
3300 Fix pointer signedness.
d01f234b 3301 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3302 (wav_play): Initialize a variable to 0, to prevent undefined
3303 behavior (Bug#8278).
50060332 3304
c4fc4e30
PE
3305 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3306
918436ed
PE
3307 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3308
c939f91b
PE
3309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3310 clobbering (Bug#8298).
b9c7f648
PE
3311 * sysdep.c (sys_subshell): Likewise.
3312 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3313
6bd8c144
PE
3314 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3315 This should get cleaned up, so that child_setup has the
3316 same signature on all platforms.
3317
7710357c 3318 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3319 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3320
c59da222
CY
33212011-03-22 Chong Yidong <cyd@stupidchicken.com>
3322
3323 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3324 not to be necessary, and produces flickering.
3325
66b87493
GM
33262011-03-20 Glenn Morris <rgm@gnu.org>
3327
3328 * config.in: Remove file.
3329
45b6f6d5
JB
33302011-03-20 Juanma Barranquero <lekktu@gmail.com>
3331
3332 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3333 are now in src/globals.h.
3334 (syms_of_minibuf): Remove spurious & from previous change.
3335
3ec03f7e
LL
33362011-03-20 Leo <sdl.web@gmail.com>
3337
3338 * minibuf.c (completing-read-function): New variable.
3339 (completing-read-default): Rename from completing-read.
3340 (completing-read): Call completing-read-function.
3341
b14e3e21
CY
33422011-03-19 Juanma Barranquero <lekktu@gmail.com>
3343
3344 * xfaces.c (Fx_load_color_file):
3345 Read color file from absolute filename (bug#8250).
3346
f2b726e6
JB
33472011-03-19 Juanma Barranquero <lekktu@gmail.com>
3348
3349 * makefile.w32-in: Update dependencies.
3350
09f6ff02
EZ
33512011-03-17 Eli Zaretskii <eliz@gnu.org>
3352
3353 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3354
29a6015a
PE
33552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3356
a3a6c54e
PE
3357 Fix more problems found by GCC 4.5.2's static checks.
3358
b766f867
PE
3359 * process.c (make_serial_process_unwind, send_process_trap):
3360 (sigchld_handler): Now static.
3361
be02381c
PE
3362 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3363 That way, the code declares only the vars that it needs.
3364 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3365 * s/cygwin.h (PTY_ITERATION): Likewise.
3366 * s/darwin.h (PTY_ITERATION): Likewise.
3367 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3368
57048744
PE
3369 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3370 * process.c (allocate_pty): Don't declare stb unless it's needed.
3371
7914961c 3372 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3373 (CONSTANTLIM): Remove; unused.
3374 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3375 Define only if needed.
7914961c 3376
b3967b18
PE
3377 * unexelf.c (unexec): Name an expression,
3378 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3379 Use a different way to cause a compilation error if anyone uses
3380 n rather than nn, a way that does not involve shadowing.
73366a00 3381 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3382
29a6015a
PE
3383 * deps.mk (unexalpha.o): Remove; unused.
3384
43cfc33e 3385 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3386 * unexec.h: New file.
ce701a33
PE
3387 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3388 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3389 Depend on unexec.h.
3390 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3391 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3392 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3393 Change as necessary to match prototype in unexec.h.
ce701a33 3394
01f44d5a
PE
3395 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3396 shadowing.
4f63c6bb 3397 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3398
a6670b0b
PE
3399 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3400 Rename locals to avoid shadowing.
3401
cef2010d 3402 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3403 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3404
d4d7173a
PE
3405 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3406
f08b802a
PE
3407 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3408 warning when compiling print.c.
3409
3ddb0639
PE
3410 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3411 instead of using an uninitialized var.
5ad03b97 3412 (font_sort_entities): Mark var as initialized.
3ddb0639 3413
170a2692
PE
3414 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3415
e663c700
PE
3416 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3417 pointers to constants.
89bc529a 3418 (font_parse_fcname): Remove unused vars.
7b81e2d0 3419 (font_delete_unmatched): Now static.
ea838e10 3420 (font_get_spec): Remove; unused.
13a547c6
PE
3421 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3422 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3423 Rename or move locals to avoid shadowing.
e663c700 3424
2a80c887 3425 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3426 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3427
1384fa33 3428 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3429 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3430
8b2c52e9
PE
3431 * alloc.c (mark_backtrace): Move decl from here ...
3432 * lisp.h: ... to here, so that it can be checked.
3433
475545b5 3434 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3435 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3436 (lisp_indirect_variable): Name an expression,
3437 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3438 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3439
b1349114 3440 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3441 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3442 Use const pointer when appropriate.
b1349114 3443
a2928364
PE
3444 * lisp.h (get_system_name, get_operating_system_release):
3445 Move decls here, to check interfaces.
3446 * process.c (get_operating_system_release): Move decl to lisp.h.
3447 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3448 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3449 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3450 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3451 (Fformat_time_string, Fencode_time, Finsert_char):
3452 (Ftranslate_region_internal, Fformat):
3453 Rename or remove local vars to avoid shadowing.
9710023e 3454 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3455
a415e694
PE
3456 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3457 avoid shadowing.
3458
8ef4622d
PE
3459 * lisp.h (eassert): Check that the argument compiles, even if
3460 ENABLE_CHECKING is not defined.
3461
946f9a5b
PE
3462 * data.c (Findirect_variable): Name an expression, to avoid
3463 gcc -Wbad-function-cast warning.
112396d6 3464 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3465 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3466 (Fmake_variable_buffer_local, Fmake_local_variable):
3467 Mark variables as initialized.
52746918 3468 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3469
e5aab7e7 3470 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3471 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3472 Rename locals to avoid shadowing.
dff45157
PE
3473 (mark_stack): Move local variables into the #ifdef region where
3474 they're used.
7bc26fdb
PE
3475 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3476 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3477 needed otherwise.
3478 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3479 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3480 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3481
e5aab7e7
PE
3482 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3483 avoids undefined behavior in theory.
3484
4da60324
PE
3485 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3486
88043301
PE
3487 Use functions, not macros, for up- and down-casing (Bug#8254).
3488 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3489 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3490 to use the following functions instead of these macros.
3491 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3492 EMACS_INT, since callers assume the returned value fits in int.
3493 (upcase1): Likewise, for UPCASE_TABLE.
3494 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3495 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3496 the race-condition problem in the old DOWNCASE.
88043301 3497
19ed5445
PE
3498 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3499 Rename locals to avoid shadowing.
3500 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3501 (regex_compile, re_search_2, re_match_2_internal):
3502 Remove unused local vars.
952db0d7
PE
3503 (FREE_VAR): Rewrite so as not to use empty "else",
3504 which gcc can warn about.
da053e48 3505 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3506 (RETALLOC_IF): Define only if needed.
3507 (WORDCHAR_P): Likewise. This one is never needed, but is used
3508 only in a comment talking about a compiler bug, so put inside
3509 the #if 0 of that comment.
3510 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3511 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3512 Remove; unused.
19ed5445 3513
1f3561e4 3514 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3515 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3516 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3517
ded6f8f7
PE
3518 * search.c (simple_search): Remove unused var.
3519
dbd37a95
PE
3520 * dired.c (compile_pattern): Move decl from here ...
3521 * lisp.h: ... to here, so that it can be checked.
3522 (struct re_registers): New forward decl.
3523
7e47afad
PE
3524 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3525
85f24f61
PE
3526 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3527 All uses changed.
3528 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3529 Rename locals to avoid shadowing.
5671df8f 3530 (Fvertical_motion): Mark locals as initialized.
85f24f61 3531
181aa2be 3532 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3533 (casify_region): Mark local as initialized.
181aa2be 3534
930d429c
PE
3535 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3536
7082eac6
PE
3537 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3538 New macros, so that the caller can use some names other than
3539 gcpro1, gcpro2, etc.
3540 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3541 of the new macros.
3542 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3543 argument, for consistency with GCPRO2_VAR, etc: it is now the
3544 prefix of the variable, not the variable itself. All uses
3545 changed.
38b2c076
PE
3546 * dired.c (directory_files_internal, file_name_completion):
3547 Rename locals to avoid shadowing.
3548
15206ed9
PE
3549 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3550 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3551 dired.c's scmp function, had undefined behavior.
3552 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3553 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3554 * buffer.h: ... to here, because these macros use current_buffer,
3555 and the new implementation with inline functions needs to have
3556 current_buffer in scope now, rather than later when the macros
3557 are used.
3558 (downcase, upcase1): New static inline functions.
3559 (DOWNCASE, UPCASE1): Reimplement using these functions.
3560 This avoids undefined behavior in expressions like
3561 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3562 from race conditions in accessing the global variables
3563 case_temp1 and case_temp2.
3564 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3565 * lisp.h (case_temp1, case_temp2): Remove their decls.
3566 * character.h (ASCII_CHAR_P): Move from here ...
3567 * lisp.h: ... to here, so that the inline functions mentioned
3568 above can use them.
3569
4a6bea26
PE
3570 * dired.c (directory_files_internal_unwind): Now static.
3571
f14b7e14
PE
3572 * fileio.c (file_name_as_directory, directory_file_name):
3573 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3574 Now static.
2893f146
PE
3575 (file_name_as_directory): Use const pointers when appropriate.
3576 (Fexpand_file_name): Likewise. In particular, newdir might
3577 point at constant storage, so make it a const pointer.
fd4ead52 3578 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3579 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3580 signedness issues.
f839df0c
PE
3581 (Fset_file_times, Finsert_file_contents, auto_save_error):
3582 Rename locals to avoid shadowing.
f14b7e14 3583
5716756e 3584 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3585 (Ftry_completion, Fall_completions): Rename or remove locals
3586 to avoid shadowing.
5716756e 3587
b4c3046a
PE
3588 * marker.c (bytepos_to_charpos): Remove; unused.
3589
b45db522
PE
3590 * lisp.h (verify_bytepos, count_markers): New decls,
3591 so that gcc does not warn that these functions aren't declared.
3592
85876d07
PE
3593 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3594 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3595 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3596 (copy_text): Remove unused local var.
85876d07 3597
03d78a21 3598 * filelock.c (within_one_second): Now static.
b3dd38ab 3599 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3600
5df8f01b
PE
3601 * buffer.c (fix_overlays_before): Mark locals as initialized.
3602 (fix_start_end_in_overlays): Likewise. This function should be
3603 simplified by using pointers-to-pointers, but that's a different
3604 matter.
b1d876f1 3605 (switch_to_buffer_1): Now static.
8f54f30a
PE
3606 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3607 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3608
a70072c9 3609 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3610 Fix pointer signedness issue.
edced198
PE
3611 (sys_subshell): Mark local as volatile if checking for lint,
3612 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3613 (MAXPATHLEN): Define only if needed.
a70072c9 3614
a0977c44
PE
3615 * process.c (serial_open, serial_configure): Move decls from here ...
3616 * systty.h: ... to here, so that they can be checked.
3617
a884fdcc
PE
3618 * fns.c (get_random, seed_random): Move extern decls from here ...
3619 * lisp.h: ... to here, so that they can be checked.
3620
604efe86 3621 * sysdep.c (reset_io): Now static.
b8950c94 3622 (wait_for_termination_signal): Remove; unused.
604efe86 3623
38fc62d9
PE
3624 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3625 (copy_keymap_item, append_key, push_text_char_description):
3626 Now static.
1004a21a 3627 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3628 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3629 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3630 (describe_map_tree):
3631 Rename locals to avoid shadowing.
38fc62d9 3632
2f2650da
PE
3633 * keyboard.c: Declare functions static if they are not used elsewhere.
3634 (echo_char, echo_dash, cmd_error, top_level_2):
3635 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3636 (read_char, kbd_buffer_get_event, make_lispy_position):
3637 (make_lispy_event, make_lispy_movement, apply_modifiers):
3638 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3639 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3640 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3641 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3642 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3643
a053e86c 3644 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3645 (mark_kboards): Move decl here ...
3646 * alloc.c (mark_kboards): ... from here.
a053e86c 3647
4752793e
PE
3648 * lisp.h (force_auto_save_soon): New decl.
3649
74f10ca7 3650 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3651 (DEFINE_DUMMY_FUNCTION): New macro.
3652 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3653 Use it.
c03cd23f
PE
3654 (main): Add casts to avoid warnings
3655 if GCC considers string literals to be constants.
74f10ca7 3656
022e70d4
PE
3657 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3658
59d6fe83
PE
3659 * dbusbind.c: Pointer signedness fixes.
3660 (xd_signature, xd_append_arg, xd_initialize):
3661 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3662 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3663 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3664 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3665
78320123
PE
3666 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3667 if GCC considers string literals to be constants.
49cebcca 3668 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3669
35ac2a97
SM
36702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3671
fb103ca9
SM
3672 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3673 (print_preprocess, print_object): New macro to fix last change.
3674
35ac2a97
SM
3675 * print.c (print_preprocess): Don't forget font objects.
3676
62973b41
JB
36772011-03-16 Juanma Barranquero <lekktu@gmail.com>
3678
3679 * emacs.c (USAGE3): Doc fixes.
3680
0e48bb22
AS
36812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3682
3683 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3684 structure.
3685
7684e57b
JB
36862011-03-14 Juanma Barranquero <lekktu@gmail.com>
3687
3688 * lisp.h (VWindow_system, Qfile_name_history):
3689 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3690 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3691 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3692
3693 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3694 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3695
3696 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3697 * w32console.c (detect_input_pending, read_input_pending)
3698 (encode_terminal_code):
3699 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3700 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3701 (w32_system_caret_y, Qfile_name_history):
3702 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3703 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3704 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3705 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3706 * w32proc.c (Qlocal, report_file_error):
3707 * w32term.c (Vwindow_system, updating_frame):
3708 * w32uniscribe.c (initialized, uniscribe_font_driver):
3709 Remove unneeded extern declarations.
3710
2aa46d6c
CY
37112011-03-14 Chong Yidong <cyd@stupidchicken.com>
3712
c96bbc66 3713 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3714
cffc6f3b
CY
37152011-03-13 Chong Yidong <cyd@stupidchicken.com>
3716
3717 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3718 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3719 These macros can no longer be used for assignment.
3720
44f230aa
SM
3721 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3722 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3723 (record_buffer_markers, fetch_buffer_markers): New functions for
3724 recording and fetching special buffer markers.
3725 (set_buffer_internal_1, set_buffer_temp): Use them.
3726
3727 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3728
3729 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3730
3731 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3732 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3733
3734 * xdisp.c (hscroll_window_tree):
3735 (reconsider_clip_changes): Use PT instead of BUF_PT.
3736
d251f04b
EZ
37372011-03-13 Eli Zaretskii <eliz@gnu.org>
3738
3739 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3740 $(EMACS_ROOT)/lib/intprops.h.
3741
f0c77cd1
PE
37422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3743
3eca4629
PE
3744 Fix more problems found by GCC 4.5.2's static checks.
3745
7c86ee98
PE
3746 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3747 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3748 (xg_free_frame_widgets): Make it clear that a local variable is
3749 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3750 (gdk_window_get_screen): Make it clear that this macro is needed
3751 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3752 (int_gtk_range_get_value): New function, which avoids a diagnostic
3753 from gcc -Wbad-function-cast.
3754 (xg_set_toolkit_scroll_bar_thumb): Use it.
3755 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3756 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3757 (get_utf8_string, xg_get_file_with_chooser):
3758 Rename locals to avoid shadowing.
3759 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3760
41729b81
PE
3761 * xgselect.c (xg_select): Remove unused var.
3762
f0c77cd1
PE
3763 * image.c (four_corners_best): Mark locals as initialized.
3764 (gif_load): Initialize transparent_p to zero (Bug#8238).
3765 Mark another local as initialized.
ec6cf4c6 3766 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3767
ce0ad53d 3768 * image.c (clear_image_cache): Now static.
d5d5a617 3769 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3770 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3771 (x_edge_detection): Remove unnecessary cast that
3772 gcc -Wbad-function-cast diagnoses.
2037898d 3773 (gif_load): Fix pointer signedness.
6ae141d6
PE
3774 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3775 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3776
33383987 37772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3778
d32df629
PE
3779 Improve quality of tests for time stamp overflow.
3780 For example, without this patch (encode-time 0 0 0 1 1
3781 1152921504606846976) returns the obviously-bogus value (-948597
3782 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3783 reports time overflow. See
3784 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3785 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3786 * editfns.c: Include limits.h and intprops.h.
3787 (TIME_T_MIN, TIME_T_MAX): New macros.
3788 (time_overflow): Move earlier, to before first use.
3789 (hi_time, lo_time): New functions, for an accurate test for
3790 out-of-range times.
3791 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3792 (Fget_internal_run_time): Don't assume time_t fits in int.
3793 (make_time): Use list2 instead of Fcons twice.
3794 (Fdecode_time): More accurate test for out-of-range times.
3795 (check_tm_member): New function.
3796 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3797 (lisp_time_argument): Don't rely on undefined left-shift and
3798 right-shift behavior when checking for time stamp overflow.
8be6f318 3799
fe31d94c
PE
3800 * editfns.c (time_overflow): New function, refactoring common code.
3801 (Fformat_time_string, Fdecode_time, Fencode_time):
3802 (Fcurrent_time_string): Use it.
3803
8be6f318
PE
3804 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3805 * dired.c (make_time): Move to ...
3806 * editfns.c (make_time): ... here.
3807 * systime.h: Note the move.
3808
09d9db2c 38092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3810
126bc0dc
YM
3811 * fringe.c (update_window_fringes): Remove unused variables.
3812
c47cbdfd
YM
3813 * unexmacosx.c (copy_data_segment): Also copy __got section.
3814 (Bug#8223)
3815
7ac80be9
EZ
38162011-03-12 Eli Zaretskii <eliz@gnu.org>
3817
c96bbc66 3818 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3819 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3820 Constify `char *' arguments and their references according to
3821 prototypes in tparam.h.
3822
ecb0f94d 3823 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3824
7ac80be9
EZ
3825 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3826 Adapt all references accordingly.
3827
3828 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3829
ef1fd07e
TT
38302011-03-11 Tom Tromey <tromey@redhat.com>
3831
3832 * buffer.c (syms_of_buffer): Remove obsolete comment.
3833
7ef4b50c
EZ
38342011-03-11 Eli Zaretskii <eliz@gnu.org>
3835
3836 * termhooks.h (encode_terminal_code): Declare prototype.
3837
3838 * msdos.c (encode_terminal_code): Don't declare prototype.
3839
3840 * term.c (encode_terminal_code): Now external again, used by
3841 w32console.c and msdos.c.
3842
44f230aa
SM
3843 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3844 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3845
4b1ec863 38462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3847
1714f52b 3848 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3849
4b1ec863
PE
3850 * fringe.c (update_window_fringes): Mark locals as initialized
3851 (Bug#8227).
3852 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3853
524c7aa6
PE
3854 * alloc.c (mark_fringe_data): Move decl from here ...
3855 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3856 to check its interface.
3857 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3858
a5c0af81 3859 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3860 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3861 (fontset_font): Mark local as initialized.
a9a06e0b 3862 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3863
b4716021
PE
3864 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3865
811e9bac 3866 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3867 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3868 (x_own_selection, Fx_disown_selection_internal): Rename locals
3869 to avoid shadowing.
3870 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3871
7e3ab302
PE
3872 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3873 so that the caller can use some name other than gcpro1.
3874 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3875 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3876 (Fx_backspace_delete_keys_p):
3877 Use them to avoid shadowing, and rename vars to avoid shadowing.
3878 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3879 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3880 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3881 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3882 Remove unused locals.
7e3ab302
PE
3883 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3884 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3885 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3886 macros.
f78faa98 3887
e2b13473
PE
3888 * xterm.h (x_mouse_leave): New decl.
3889
77f23912
PE
3890 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3891 Remove unused functions.
cdf4ba58
PE
3892 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3893 (x_calc_absolute_position): Now static.
7411c686 3894 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3895 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3896 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3897 unless they are used.
38d0b34a
PE
3898 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3899 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3900 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3901 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3902 (x_error_catcher, x_connection_closed, x_error_handler):
3903 (x_error_quitter, xembed_send_message, x_iconify_frame):
3904 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3905 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3906 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3907
44f230aa
SM
3908 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3909 Rename or move locals to avoid shadowing.
6b463e58 3910 (tty_defined_color, merge_face_heights): Now static.
5967d051 3911 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3912 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3913 does not deduce is never used uninitialized.
73719eba
PE
3914 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3915 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3916
426994c3 3917 * terminal.c (store_terminal_param): Now static.
5489860b 3918
032f1620 3919 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3920 (set_frame_menubar): Remove unused local.
d4323972 3921 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3922 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3923 since they might point to immutable storage.
281585b0
PE
3924 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3925 since it's unused otherwise.
032f1620 3926
367c19e5 3927 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3928 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3929 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3930 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3931 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3932 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3933 does not deduce are never used uninitialized.
70739cbe 3934
07b48fa9
PE
3935 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3936
8868a238 3937 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3938 * window.c (window_loop, size_window):
3939 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3940
7e5cf297 3941 * window.c (display_buffer): Now static.
d6550a9f
PE
3942 (size_window): Mark variables that gcc -Wuninitialized
3943 does not deduce are never used uninitialized.
a586633d
PE
3944 * window.h (check_all_windows): New decl, to forestall
3945 gcc -Wmissing-prototypes diagnostic.
5b555da1 3946 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3947
f6095868
PE
3948 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3949 shadowing.
3950 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3951 Include <limits.h>.
3952 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3953 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3954 (load_charset_map): Mark variables that gcc -Wuninitialized
3955 does not deduce are never used uninitialized.
53df7c11 3956 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3957
f38b440c
PE
3958 * coding.c (coding_set_source, coding_set_destination):
3959 Use "else { /* comment */ }" rather than "else /* comment */;"
3960 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3961 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3962 a block, when the outer 'i' will do.
3963 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3964 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3965 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3966 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3967 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3968 Rename locals to avoid shadowing.
3969 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3970 * coding.c (emacs_mule_char, encode_invocation_designation):
3971 Now static, since they're not used elsewhere.
413bb2db 3972 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3973 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3974 (decode_coding_emacs_mule): Mark variables that gcc
3975 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3976 (detect_coding_iso_2022): Initialize a local variable that might
3977 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3978 this initialization is needed. (Bug#8211)
5f58e762
PE
3979 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3980 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3981 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3982 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3983 Remove unused macros.
f38b440c 3984
232b38b9 3985 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3986 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3987 * character.c (string_count_byte8): Likewise.
232b38b9 3988
fb90da1b
PE
3989 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3990 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3991
fb93dbc2
PE
3992 * chartab.c (copy_sub_char_table): Now static, since it's not used
3993 elsewhere.
5c156ace
PE
3994 (sub_char_table_ref_and_range, char_table_ref_and_range):
3995 Rename locals to avoid shadowing.
bbcd0949 3996 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3997
7d3b3862 3998 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3999 (BIDI_BOB): Remove unused macro.
7d3b3862 4000
6be7d3da
PE
4001 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4002 deduce are never used uninitialized.
c2ed9c8b 4003 * term.c (encode_terminal_code): Likewise.
6be7d3da 4004
75f8807f 4005 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4006
50938595
PE
4007 * tparam.h: New file.
4008 * term.c, tparam.h: Include it.
4009 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4010 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4011 Move these decls to tparam.h, and make them agree with what
4012 is actually in tparam.c. The previous trick of using incompatible
4013 decls in different modules does not conform to the C standard.
4014 All callers of tparam changed to use tparam's actual API.
4015 * tparam.c (tparam1, tparam, tgoto):
4016 Use const pointers where appropriate.
4017
fbceeba2
PE
4018 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4019 * cm.h (struct cm): Likewise.
4020 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4021 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4022 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4023 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4024 (turn_on_face, init_tty): Likewise.
4025 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4026
7f3f1250
PE
4027 * term.c (term_mouse_position): Rename local to avoid shadowing.
4028
e6ca6543
PE
4029 * alloc.c (mark_ttys): Move decl from here ...
4030 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4031
c40f8d15
AS
40322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4033
4034 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4035
cfe0661d
JB
40362011-03-09 Juanma Barranquero <lekktu@gmail.com>
4037
4038 * search.c (compile_pattern_1): Remove argument regp, unused since
4039 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4040 (compile_pattern): Don't pass it.
4041
0afb4571
J
40422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4043
4044 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4045 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4046 for ! HAVE_GTK3.
4047 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4048
4049 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4050
4051 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4052 gdk_window_get_screen, gdk_window_get_geometry,
4053 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4054 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4055 (xg_get_pixbuf_from_pixmap): New function.
4056 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4057 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4058 Call xg_get_pixbuf_from_pixmap instead of
4059 gdk_pixbuf_get_from_drawable.
4060 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4061 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4062 (xg_check_special_colors): Use GtkStyleContext and its functions
4063 for HAVE_GTK3.
4064 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4065 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4066 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4067 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4068 Call gtk_widget_get_preferred_size.
0afb4571
J
4069 (xg_frame_resized): gdk_window_get_geometry only takes 5
4070 parameters.
44f230aa
SM
4071 (xg_win_to_widget, xg_event_is_for_menubar):
4072 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4073 (xg_set_widget_bg): New function.
4074 (delete_cb): New function.
895009e1 4075 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4076 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4077 (xg_set_background_color): Call xg_set_widget_bg.
4078 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4079 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4080 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4081 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4082 if ! HAVE_GTK3.
4083 (update_frame_tool_bar): Call gtk_widget_hide.
4084 (xg_initialize): Use GDK_KEY_g.
4085
4086 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4087 if ! HAVE_GTK3
4088 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4089
4090 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4091 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4092 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4093
1c2cc4ef
JB
40942011-03-08 Juanma Barranquero <lekktu@gmail.com>
4095
4096 * w32xfns.c (select_palette): Check success of RealizePalette against
4097 GDI_ERROR, not zero.
4098
33383987 4099See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4100
4101;; Local Variables:
4102;; coding: utf-8
aac0c6e3
MR
4103;; End:
4104
33383987 4105 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4106
4107 This file is part of GNU Emacs.
4108
4109 GNU Emacs is free software: you can redistribute it and/or modify
4110 it under the terms of the GNU General Public License as published by
4111 the Free Software Foundation, either version 3 of the License, or
4112 (at your option) any later version.
4113
4114 GNU Emacs is distributed in the hope that it will be useful,
4115 but WITHOUT ANY WARRANTY; without even the implied warranty of
4116 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4117 GNU General Public License for more details.
4118
4119 You should have received a copy of the GNU General Public License
4120 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.